kpod: display image dates from inspection data, and don't display non-OCI settings in "inspect"

We parse image data when checking if an image matches a label filter for kpod images, so extend that to read the image inspection data and OCI configuration blob.
Use the creation date from an image's inspection data when the image is to be used as a reference date, and for display.
Only show the image's OCI configuration in kpod inspect, since that's the only information cri-o will use when it attempts to run the image.  This discards the "parent" image's ID, so we drop that field, too.

Updated to also drop non-OCI information from container inspection results.

LGTM
@14rcole PTAL
@runcom PTAL

LGTM pending tests.  A couple of small questions, if they need addressing they can be addressed later in a follow up PR.

Tweaked to fix a lint error.

LGTM


add env goanywhere_mft CVE-2023-0669

Hello @SuperX-SIR thanks for your contribution!
Reproduction steps appears to be missing from the testbed, can you provide them? A list of curl commands would be ideal.

appears to be missing

Simply download the listed Docker images and run them as instructed.
Vulnerable image
kutzhanov/goanywhere:6.8.6

safe iamge
helpsystems/goanywhere-mft:7.1.3

run the container
docker run --publish 38000:8000 --publish 38001:8001 --publish 38005:8005 --publish 38006:8006 --publish 38009:8009 --publish 38010:8010 --publish 38443:8443 --publish 38021:8021 --publish 38022:8022 --publish 32001-32300:32001-32300 --publish 34434:4434 --publish 34121:2121 --publish 39909:9909 --publish 34222:2222  --publish 36330:6330 --publish 35005:5005  --name my_mft_6_8_6 kutzhanov/goanywhere:6.8.6

Hello @SuperX-SIR, I am referring to the command injection vulnerability reproduction steps.

It would be better if you could provide a PoC under the form of easy to reproduce steps in the testbed's README.md file. You can refer to this if in doubt.

Hello @SuperX-SIR, do you have any follow up on this?

Hello @SuperX-SIR, do you have any follow up on this?

Solved this week


[Improve][Core] remove Plugin implementation default override method

Purpose of this pull request
Code improve, remove Plugin implementation default override method, move it into Plugin default method.

Check list

[x] Code changed are covered with tests, or it does not need tests for reason:
[x] If any new Jar binary package adding in you PR, please add License Notice according
New License Guide
[x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs

please resolve conflicts files, thx


Knowledge tool calls always retrieves information from the first query that was made to it.

Electron build from 4cb8a0c26317f
Steps to reproduce the problem:

Chat with Tildy and use "Add Knowledge" to add file - MyFeb12.pdf which has diet plan.
Asked a question about what I can eat in empty stomach?
I get a response from knowledge.
Get to another thread and use "Add Knowledge" to add file - Insurance_Handbook_20103.pdf.
Ask a question relating to insurance

I am not presented with information from knowledge
Knowledge tool calls always retrieves information for the query from step 2 - "what I can eat in empty stomach?"

This issue is addressed when testing with latest build - a8d8c5c39b3d


Allow DOMDocument usage

I was working on a legacy project for a client that uses the DOMDocument to render the HTML. Using this repo on that project would involve rendering the DOMDocument into a HTMLDocument, then back again.
A few more type checks on $html in the HTMLDocumentProtector's constructor will be beneficial.

I did look into that actually - even wrote a test for it.  Then it failed and I concluded that the best solution would be to update the phpgt HtmlDocument constructor to accept a DomDocument.  Otherwise this module needs to start worrying about what type of Document it is whenever it needs to interact with it.

That's a much better idea.

See phpgt/dom#25


epic(ui): Inventory-Centric Views

This involves the implementation of views for inventory and inventory affiliations. They include:

Component Instances
Services
Users - Service Owner, Support Groups.

Note: This Epic is a work in progress and will be reviewed for refinement soon.

The services and components list views are already implemented.


Release reset branches

Description of changes
This pull request includes:

a script to run when promoting an RC to distribution channels (GitHub releases and NPM)
added CI step to pull the release commit into a release branch so that release can open PR of release commit
added CI step to reset main to match the latest release
added to GitHub release payload the release commit so that tag/release includes commit

Issue #, if available

Description of how you validated changes
Checklist

[ ] PR description included
[ ] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #10694 (3039e1d) into dev (171f51a) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev   #10694   +/-   ##
=======================================
  Coverage   47.37%   47.37%
=======================================
  Files         669      669
  Lines       33063    33063
  Branches     6671     6671
=======================================
+ Hits        15663    15664    +1
+ Misses      15722    15721    -1
  Partials     1678     1678

Impacted Files
Coverage Δ

...li/src/domain/amplify-usageData/getUsageDataUrl.ts
100.00% <0.00%> (+12.50%)
:arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


allow separate export z

Only followings or only followers or only lists and so on.
https://mastodon.social/@lateralty/109415793597461232

Perhaps an interim step could be to just include "following", "followed by", and the Twitter username in each CSV line?


wpsoffice: <IP_ADDRESS>15 -> <IP_ADDRESS>64

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

it seems not necessary to replace unvendoredLibraries if we use autoPatchelfHook

if don‘t use  autoPatchelfHook， wps won't start

override steam-run doesn't seem to be needed

libcef.so(SkinCenter in wps) will crash if don't use steam-run (buildFHSEnv also does not work)

The following build script basically works fine for me：
{ lib
, stdenv
, mkDerivation
, fetchurl
, dpkg
, wrapGAppsHook
, wrapQtAppsHook
, autoPatchelfHook
, alsa-lib
, libtool
, nspr
, mesa
, qt4
, libtiff
, cups
, xorg
, steam-run
, makeWrapper
}:

stdenv.mkDerivation rec {
  pname = "wpsoffice";
  version = "<IP_ADDRESS>64";

  src = fetchurl {
    url = "http://wdl1.pcfg.cache.wpscdn.com/wpsdl/wpsoffice/download/linux/${lib.last (lib.splitString "." version)}/wps-office_${version}.XA_amd64.deb";
    sha256 = "sha256-9qZGqs4nsB9mWCJTi2x+vWmMF0sEoUYgEzLI//hijfU=";
  };

  unpackCmd = "dpkg -x $src .";
  sourceRoot = ".";

  postUnpack = ''
    # distribution is missing libkappessframework.so, so we should not let
    # autoPatchelfHook fail on the following dead libraries
    rm -rv opt/kingsoft/wps-office/office6/addons/pdfbatchcompression
  '';

  nativeBuildInputs = [ dpkg wrapGAppsHook wrapQtAppsHook makeWrapper autoPatchelfHook ];

  buildInputs = with xorg; [
    alsa-lib
    libXdamage
    libXtst
    libtool
    nspr
    mesa
    qt4
    libtiff
    cups.lib
  ];

  dontWrapQtApps = true;
  dontWrapGApps = true;

  installPhase = ''
    runHook preInstall

    prefix=$out/opt/kingsoft/wps-office
    mkdir -p $out
    cp -r opt $out
    cp -r usr/* $out
    for i in wps wpp et wpspdf; do
      substituteInPlace $out/bin/$i \
        --replace /opt/kingsoft/wps-office $prefix
    done
    for i in $out/share/applications/*;do
      substituteInPlace $i \
        --replace /usr/bin $out/bin
    done

    for i in wps wpp et wpspdf; do
      mv $out/bin/$i $out/bin/.$i-orig
      makeWrapper ${steam-run}/bin/steam-run $out/bin/$i \
        --add-flags $out/bin/.$i-orig \
        --argv0 $i
    done
    runHook postInstall
  '';

  postFixup = ''
    for f in "$out"/bin/*; do
      echo "Wrapping $f"
      wrapProgram "$f" \
        "''${gappsWrapperArgs[@]}" \
        "''${qtWrapperArgs[@]}"
    done
  '';

  meta = with lib; {
    description = "Office suite, formerly Kingsoft Office";
    homepage = "https://www.wps.com";
    platforms = [ "x86_64-linux" ];
    hydraPlatforms = [ ];
    license = licenses.unfreeRedistributable;
    maintainers = with maintainers; [ mlatus th0rgal ];
  };
}

Is qt4 still needed? See  #174634 (67beee6)

Is qt4 still needed? See #174634 (67beee6)
It‘s necessary for some libraries in wps

auto-patchelf: 10 dependencies could not be satisfied
error: auto-patchelf could not satisfy dependency libQtCore.so.4 wanted by /nix/store/1wbqrayq6ayxrv7nal32kz32a4chsl7x-wpsoffice-<IP_ADDRESS>64/opt/kingsoft/wps-office/office6/librpcetapi.so
error: auto-patchelf could not satisfy dependency libQtNetwork.so.4 wanted by /nix/store/1wbqrayq6ayxrv7nal32kz32a4chsl7x-wpsoffice-<IP_ADDRESS>64/opt/kingsoft/wps-office/office6/librpcetapi.so
error: auto-patchelf could not satisfy dependency libQtXml.so.4 wanted by /nix/store/1wbqrayq6ayxrv7nal32kz32a4chsl7x-wpsoffice-<IP_ADDRESS>64/opt/kingsoft/wps-office/office6/librpcetapi.so
error: auto-patchelf could not satisfy dependency libQtCore.so.4 wanted by /nix/store/1wbqrayq6ayxrv7nal32kz32a4chsl7x-wpsoffice-<IP_ADDRESS>64/opt/kingsoft/wps-office/office6/librpcwpsapi.so
error: auto-patchelf could not satisfy dependency libQtNetwork.so.4 wanted by /nix/store/1wbqrayq6ayxrv7nal32kz32a4chsl7x-wpsoffice-<IP_ADDRESS>64/opt/kingsoft/wps-office/office6/librpcwpsapi.so
error: auto-patchelf could not satisfy dependency libQtXml.so.4 wanted by /nix/store/1wbqrayq6ayxrv7nal32kz32a4chsl7x-wpsoffice-<IP_ADDRESS>64/opt/kingsoft/wps-office/office6/librpcwpsapi.so
error: auto-patchelf could not satisfy dependency libQtCore.so.4 wanted by /nix/store/1wbqrayq6ayxrv7nal32kz32a4chsl7x-wpsoffice-<IP_ADDRESS>64/opt/kingsoft/wps-office/office6/librpcwppapi.so
error: auto-patchelf could not satisfy dependency libQtNetwork.so.4 wanted by /nix/store/1wbqrayq6ayxrv7nal32kz32a4chsl7x-wpsoffice-<IP_ADDRESS>64/opt/kingsoft/wps-office/office6/librpcwppapi.so
error: auto-patchelf could not satisfy dependency libQtXml.so.4 wanted by /nix/store/1wbqrayq6ayxrv7nal32kz32a4chsl7x-wpsoffice-<IP_ADDRESS>64/opt/kingsoft/wps-office/office6/librpcwppapi.so
error: auto-patchelf could not satisfy dependency libXv.so.1 wanted by /nix/store/1wbqrayq6ayxrv7nal32kz32a4chsl7x-wpsoffice-<IP_ADDRESS>64/opt/kingsoft/wps-office/office6/libavdevice.so.58.10.100

Maybe I can try to remove these libraries

Fortunately, these few libraries that depend on qt4 do not seem to be necessary.
Basic functionality works fine for me


Fixing indentation

+1

duplicate of https://github.com/crowbar/crowbar/pull/2187

As this is a duplicate and the other PR is already merged we can close that. If I'm wrong just reopen it.


Setup Slack integration for ESS

We would like to have notifications in our chat room when there is activity in the Github repository.

Works now.


externalize metadata and make it version based

motivation: share package metadata for swift versions and platforms
changes:

introduce new directory for share metadata
create metadata file for rpms, swift 5.5.0
update centos 8 spec and script to use the shared metadata

@shahmishal this builds on top of #32, see https://github.com/apple/swift-installer-scripts/pull/33/commits/31db6d335e420cf7d83f542fccfdb749f1f0b334 for the actual changes, once we merge #32 I will rebase on top

@shahmishal @tachoknight @futurejones wdyt about this technical approach to achieve some of the ideas mentioned inhttps://github.com/apple/swift-installer-scripts/pull/23#issuecomment-938275941? we still need to figure out the actual values, so focus on the technical aspect of how this is wired up

I really think that this project should be separated into the different package manager families of distributions.

This seems like just an additional level of indirection; if I want to build Swift for Ubuntu or Fedora, why not just go to the appropriate directory directly, without having to be know about the package type?

@tachoknight, what I am discussing is not about building swift. Its about packaging the swift toolchain for distribution using the native packaging system.
Knowing the package type and what the different package managers require is the key point and the most relevant information. I wouldn't have thought of this as an 'additional level of indirection'.
If you want to build the swift toolchain then this is already covered at https://github.com/apple/swift.

@futurejones i like the proposed directory structure and totally agree with your assessment
note this PR does not attempt to canonicalize the metadata across different package managers - the proposed shared metadata file is qualified to be for RPM only, so it can be shared across centos, amazon linux, etc

what I am discussing is not about building swift. Its about packaging the swift toolchain for distribution using the native packaging system.
Knowing the package type and what the different package managers require is the key point and the most relevant information. I wouldn't have thought of this as an 'additional level of indirection'.

i suspect @tachoknight point was the explicit directory representing the type of package (eg RPM) is redundant as it can be implicitly derived from the linux distro
personally i can go either way

@futurejones @tachoknight @shahmishal updated to reflect the directory structure suggested by @futurejones which I think makes this nice.
should we move forward with this?

Admittedly I'm not sure how it makes it better than just going to the appropriate distro directory, but if that's how folks like it, then ¯_(ツ)_/¯.

@shahmishal please merge when you are ready

what i'd really would have loved this cool metadata idea would solve, that the dependencies can be easier extracted. e.g.

a list of software and version which the build depends on, e.g. ninja, ICU, i.e. non-apple
a list of urls to build swift, e.g. llvm-project
a list of urls to be built when swift is built, swift source code, e.g. swift-crypto
the list of URLs in representation git-url, maybe even a git repo with submodules so one can do a shallow clone with depth 1.
the list of URLs in represenation binary download

because currently i do the following check update_checkout/update-checkout-config.json, and need to check if it is tag or branch as arch wants the direct https url to feed into "git clone".

@shahmishal @tomerd for the arch linux and family build what @tachoknight suggests seems slimmer. the package scripts are so small that a directory structure imo over-complicates it.

it makes it easier to share metadata in a format that is agnostic to the package manager. the original PR had it in a separate place, but this makes it easy to reason about. in any case, this is something we can change later, so I suggest we continue with this for the sake of making progress

what i'd really would have loved this cool metadata idea would solve, that the dependencies can be easier extracted. e.g.
a list of software and version which the build depends on, e.g. ninja, ICU, i.e. non-apple
a list of urls to build swift, e.g. llvm-project
a list of urls to be built when swift is built, swift source code, e.g. swift-crypto
the list of URLs in representation git-url, maybe even a git repo with submodules so one can do a shallow clone with depth 1.
the list of URLs in represenation binary download
because currently i do the following check update_checkout/update-checkout-config.json, and need to check if it is tag or > branch as arch wants the direct https url to feed into "git clone".

this is the general direction I would like to go to, but this PR starts with the minimal and easy to extract and share metadata. I can see follow on PRs to extract these as well, especially since some of this may be version specific

@shahmishal @tomerd for the arch linux and family build what @tachoknight suggests seems slimmer. the package scripts are so small that a directory structure imo over-complicates it.

it makes it easier to share metadata in a format that is agnostic to the package manager. the original PR had it in a separate place, but this makes it easy to reason about. in any case, this is something we can change later, so I suggest we continue with this for the sake of making progress

agreed, metadata should be as close as possible to the usage. but the structure seems really complex, let us digest this path: platforms/Linux/RPM/shared/metadata/5.5.0/metadata.inc.  why it cannot be simply: rpm/metadata.inc, and rpm/fedora-8/package.spec, msi/whatebber ?
lets then look at why rpm should be there. you have the problem of operating systems where one could have multiple formats, e.g. for windows you have msi, chocolatey, winget, and zip. for fedora you have rpm, and tar ball. arch linux base, use shell scripting, just like tar ball.
another decision point is the version number. 5.5.0 is in the path while the whole structure is stored in a source code repo, where versions are usually tags, not in the path. of course there may be good reasons for doing it. a new version of swift-formater comes, and you want to change it for 5.5.x and 5.4.x in one go instead of checking out 20 branches and re-tag. but IFF you decide that this repo should not follow the same versioning schemes as other swift repos, why not making it so that you can easy drop prehistoric stuff easily later on, and put the version on top: 5.5.0/rpm/metadata.inc.
another aspect is the change rate. ideally this metadata contains volatile data like version numbers which is a pain. but - here i agree with you that it can be fixed any time.
in a summary, a simple directory structure would be cool. extracting later on is easy in case somebody finds it too much work to maintain. something flexible like:
swift-installer-scripts
  ├ fedora-8
  │   ├ package.spec
  │   └ ...
  ├ shared
  │   ├ rpm
  │   │   ├ metadata.inc
  │   │   └ ...
  │   └ ...
  ├ windows-11
  │   ├ winget
  │   │   ├ swiftlang.json
  │   │   └ ...
  │   ├ msi
  │   └ ...
  └ ...

that fedora uses the rpm shared is convention. if you really like it, put 5.5.0 on top.


Cross origin request blocked for http://svc.webspellchecker.net/spellcheck31/script/ssrv.cgi not working with Firefox 93.0

some days ago, i integrated this plugin with my Django admin panel. everything works fine but scayt spelling checker is not working in my firefox.

Therefore i investigated and found that i have to configure  django-cors-headers with my application. I did. still it's not working for my web application
And below are my configuration to allow cross origin request from django application.
INSTALLED_APPS = [
    ' . . .'
    'ckeditor',
    'corsheaders'
    ' . . .'
]
MIDDLEWARE = [
    ". . .",
    "corsheaders.middleware.CorsMiddleware",
    "django.middleware.common.CommonMiddleware",
    " . . .",
]
CORS_ALLOW_ALL_ORIGINS = True

CORS headers seem to be missing on the webspellchecker host, not on your end.

Thanks for an update!


AttributeError: module 'pyrodigal' has no attribute 'GeneFinder'

Hi! When I installed this tool step-by-step following the instruction, and run the test data, it failed and I was getting the following error:
File "gvclass/workflow/scripts/opgecall.py", line 350, in
main()
File "gvclass/.snakemake/conda/a158724ed561e361e5749fd13bbd0687_/lib/python3.10/site-packages/click/core.py", line 1130, in call
return self.main(*args, **kwargs)
File "gvclass/.snakemake/conda/a158724ed561e361e5749fd13bbd0687_/lib/python3.10/site-packages/click/core.py", line 1055, in main
rv = self.invoke(ctx)
File "gvclass/.snakemake/conda/a158724ed561e361e5749fd13bbd0687_/lib/python3.10/site-packages/click/core.py", line 1404, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "gvclass/.snakemake/conda/a158724ed561e361e5749fd13bbd0687_/lib/python3.10/site-packages/click/core.py", line 760, in invoke
return __callback(*args, **kwargs)
File "gvclass/workflow/scripts/opgecall.py", line 256, in main
run_genecalling_codes(fnafile, code, gffout)
File "/home/yangbing/local_software/gvclass/workflow/scripts/opgecall.py", line 206, in run_genecalling_codes
geneFinder = pyrodigal.GeneFinder(meta=metaFlag)
AttributeError: module 'pyrodigal' has no attribute 'GeneFinder'
I also try other version of pyrodigal but it still doesnt work...
Thanks for your time and help!

Would you be able to try running gvclass through Docker or Apptainer? While we plan to integrate the additional genetic codes / pyrodigal in a more effective way, I cannot provide a specific timeline for it right now.


Cannot resize window when KPCTabsControl takes whole width

This one is weird and I don't remember this was a problem a few weeks ago: I have a tab bar at the top of my window + constraints so it has full width. Whatever size the window has in Interface Builder is the final width when I start the program. Height resizes just fine. I don't get any horizontal resizing handles, though. Can't make the window wider or narrower.

It happens even when I ...

set the width to 500 and center it horizontally in its container
don't set a width and center it

(No matter the content hugging or compression resistance.)
It works when I ...

neither set a width or X-location constraint
don't set a width and add leading=0

Hi! Thanks for the issue report. I'll have a look asap, but I am currently traveling. Would it be possible for you to send me a test project with the right problematic setup?

Hi. I just published v1.6.1 with a small fix. I have taken the project demo, and turned Autolayout ON in the  xib. And indeed, it appeared that you couldn't resize the window. I am still struggling a bit at understanding the AutoLayout stuff. I had to revert a boolean in the code (that I already toggled in the past...). But with the new value, the tabs control works whatever the AutoLayout switch in the xib: on and off work. Let me know if it is also ok for you.

Strange: turning AL on alone didn't break the sample app for me. Will integrate the new version today and see in the shipping app.

On 28 May 2016, at 15:41, Cédric Foellmi<EMAIL_ADDRESS>wrote:
Hi. I just published v1.6.1 with a small fix. I have taken the project demo, and turned Autolayout ON in the xib. And indeed, it appeared that you couldn't resize the window. I am still struggling a bit at understanding the AutoLayout stuff. I had to revert a boolean in the code (that I already toggled in the past...). But with the new value, the tabs control works whatever the AutoLayout switch in the xib: on and off work. Let me know if it is also ok for you.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

That did it, thanks! I wonder what else I messed up when I removed that toggle and it still didn't work 🤔

👍🏻


Update device.py

Bug fix for error:
Traceback (most recent call last):
  File "/cache/home/nr620/tinygrad/examples/testMulti.py", line 71, in <module>
    O = simpFunc(Xs)
  File "/cache/home/nr620/tinygrad/examples/testMulti.py", line 62, in simpFunc
    t = x+1
  File "/cache/home/nr620/tinygrad/tinygrad/tensor.py", line 832, in __add__
    def __add__(self, x) -> Tensor: return self.add(x)
  File "/cache/home/nr620/tinygrad/tinygrad/tensor.py", line 786, in add
    return mlops.Add.apply(*self._broadcasted(x, reverse)) if x.__class__ is Tensor or x else self
  File "/cache/home/nr620/tinygrad/tinygrad/tensor.py", line 33, in apply
    ret = Tensor(ctx.forward(*[t.lazydata for t in x], **kwargs), device=ctx.device, requires_grad=ctx.requires_grad)
  File "/cache/home/nr620/tinygrad/tinygrad/mlops.py", line 97, in forward
    def forward(self, x:LazyBuffer, y:LazyBuffer) -> LazyBuffer: return x.e(BinaryOps.ADD, y)
  File "/cache/home/nr620/tinygrad/tinygrad/features/multi.py", line 91, in e
    assert all_same([x.device for x in msrcs]), f"all buffers must have the same device {[x.device for x in msrcs]}"
AssertionError: all buffers must have the same device [('GPU:0', 'GPU:1', 'GPU:2', 'GPU:3'), ('GPU', 'GPU:1', 'GPU:2', 'GPU:3')]

for code:
X = Tensor.ones(N, N)
Xs = X.shard(('GPU:0','GPU:1','GPU:2','GPU:3'), 0) def simpFunc(x) -> Tensor:
    t = x+1
    t = t.sum(1)
    return t.realize()
O = simpFunc(Xs)

that's not the right fix. it should be fixed in ops_gpu. also bugfix pr needs a regression test

It breaks in the same way for CUDA also. It's a new bug introduced with multi tensor. The replace method will always replace ':0' with '' irregardless of multi or single gpu. Will try adding a multi flag for device

Also looks like Linters Unit Test has a bug. An else statement can follow a return statement

There is a test for it, but the unit test is skipped for GPU and CUDA
unittest.skipIf(CI and Device.DEFAULT in {"GPU", "CUDA"}, "no GPU CI")
class TestMultiTensor(unittest.TestCase):
  def test_shard(self):
    X = Tensor.ones(256).contiguous().realize()
    X.shard_((d0, d1), 0)
    for lb in X.lazydata.lbs:
      assert lb.shape == (128,)

  def test_shard_same_device(self):
    X = Tensor.ones(256).contiguous().realize()
    X.shard_((d0, X.device), 0)
    (X + X).realize()

  def test_shard_plus_one_sum(self):
    X = Tensor.ones(256).contiguous().realize()
    X.shard_([d0, d1], 0)
    (X + 1).sum().realize()

@chenyuxyz Is this a good fix?

it's not the right fix. but the issue is legit. feel free to file an issue or commit a broken test and skip it in CI


Create tabular dataset

This creates a new abstract dataset called tabular. It contains common
functionality of features and label management that is shared between the
CsvDataset, the TablesawDataset, and likely future datasets from other tabular
sources.

Codecov Report

Merging #1699 (993fcfb) into master (bb5073f) will decrease coverage by 1.56%.
The diff coverage is 68.45%.

@@             Coverage Diff              @@
##             master    #1699      +/-   ##
============================================
- Coverage     72.08%   70.52%   -1.57%
- Complexity     5126     5511     +385
============================================
  Files           473      522      +49
  Lines         21970    24410    +2440
  Branches       2351     2647     +296
============================================
+ Hits          15838    17214    +1376
- Misses         4925     5889     +964
- Partials       1207     1307     +100

Impacted Files
Coverage Δ

api/src/main/java/ai/djl/modality/cv/Image.java
69.23% <ø> (-4.11%)
:arrow_down:

...rc/main/java/ai/djl/modality/cv/output/Joints.java
71.42% <ø> (ø)

.../main/java/ai/djl/modality/cv/output/Landmark.java
100.00% <ø> (ø)

...main/java/ai/djl/modality/cv/output/Rectangle.java
72.41% <0.00%> (ø)

...i/djl/modality/cv/translator/BigGANTranslator.java
21.42% <ø> (-5.24%)
:arrow_down:

...odality/cv/translator/BigGANTranslatorFactory.java
33.33% <0.00%> (+8.33%)
:arrow_up:

...nslator/InstanceSegmentationTranslatorFactory.java
14.28% <0.00%> (-3.90%)
:arrow_down:

.../ai/djl/modality/cv/translator/YoloTranslator.java
8.33% <0.00%> (-0.50%)
:arrow_down:

.../modality/cv/translator/YoloTranslatorFactory.java
8.33% <0.00%> (-1.67%)
:arrow_down:

...i/djl/modality/cv/translator/YoloV5Translator.java
5.38% <0.00%> (-0.31%)
:arrow_down:

... and 285 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1981f3...993fcfb. Read the comment docs.


[Dependabot] Group golang.org/x updates

Instead of having 3+ Dependabot PRs every time there is a new patch release for golang.org/x packages, there will be a single PR to update all of them at the same time.

@luolanzone Could I get a review on this? It will reduce the number of Dependabot PRs that have to be tested and merged.


use envvars as default value for sensitive argments.

Treat influx addr, username and password as sensitive credentials.
It's preferable to read sensitive information from envvars.
commandline arguments can be read from the process table for ex: ps -aux
Solution in this PR:

Use os.Getenv() to retrieve default values from env vars  when constructing command flags.
Do not mark these as required flags, if not set and env var defaults are used.
Manual test for empty string values and error out accordingly.

requested changes pushed in latest commit

requested changes made.
I have locally built version running now using envvars
sensuctl handler info influxdb-particle
=== influxdb-particle
Name:                  influxdb-particle
Type:                  pipe
Timeout:               30
Filters:
Mutator:
Execute:               RUN:  /usr/local/bin/sensu-influxdb-handler -d 'particle'
Environment Variables: INFLUXDB_ADDR=http://localhost:8086, INFLUXDB_USER=nunya, INFLUXDB_PASS=business


[nfc] Enable member function templates silgen test.

This test was disabled until #30630 (support calling C++ constructors) landed. That patch landed a while ago, so this test should be enabled.

I'm going to merge this as soon as the tests pass. If someone has an objection, it will be very easy to revert (but I highly doubt that anyone will object).

I'm going to merge this as soon as the tests pass. If someone has an objection, it will be very easy to revert (but I highly doubt that anyone will object).

@swift-ci please smoke test.

@swift-ci please smoke test.

@swift-ci please smoke test.

@swift-ci please smoke test.


Pool Balls go pitch black after starting game

I modified the default material for the pool balls to make it a bit more personal, they all look fine on the initial load, but once a game starts the material changes and looks incorrect.


M3-531 expansion panels updates

Few things addressed here:

moved plus/minus icons to the left of the label
fixed open state conditional (we omitted to include the defaultExpanded props in there)
add styling so that we have a consistent hover state for the header

Note: the focus state is still persistent as this is addressed in a PR that has not been merged yet

@howdiz this is our reaction to feedback from previous review regarding hover/active state of expansion panels. Look good?
http://www.giphy.com/gifs/c75sp6xjTuEbVUtt5S

@asauber fixed, thx

@asauber Are we good to go here?

looks good, rebased and merging


Sometimes the Whole Atom Got Frozen

If a certain condition is met, every time the whole Atom will be frozen and have to be closed and restarted. I don't know if this bug lies in the core or in the tree-view.
Steps to reproduce:
First, create 2 directories with 3 subdirectories:
mkdir lib
mkdir lib/c-v0.1.0
mkdir lib/c-v0.2.0
mkdir test
mkdir test/c-v0.1.0

Then, in each subdirectory place an empty file main.js:
touch lib/c-v0.1.0/main.js
touch lib/c-v0.2.0/main.js
touch test/c-v0.1.0/main.js

Then type atom . to open Atom. Then click these 3 files to open them. When the third file is clicked, the whole Atom will be frozen.
This bug exists in v1.3.2. I haven't tested beta versions.

This has been fixed in the beta channel. Thanks for reporting!


[TEVA-2154] remove TF lock file - provider conflicts

Jira ticket URL
https://dfedigital.atlassian.net/browse/TEVA-2154
Changes in this PR:

The terraform.lock.hcl file introduced in the 0.14 release of the Terraform CLI does not co-exist peacefully with existing plugin cache. Removing the lock file and adding to .gitignore until the behaviour is fixed.

Review app deployed to https://teaching-vacancies-review-pr-3036.london.cloudapps.digital


Add 'sudo lecture'

Hey there, I noticed that the sudo lecture from Linux/Unix is currently not included in the program yet and wanted to ask if it could be added in a future release. :)
We trust you have received the usual lecture from the local System
Administrator. It usually boils down to these three things:

    #1) Respect the privacy of others.
    #2) Think before you type.
    #3) With great power comes great responsibility.

Would also be great if you used sudo as non-admin that it will say "This incident will be reported"

This would be great addition.

Hi,
In addition to presenting this text from Windows Terminal and other console windows when first launching sudo, I think it would be great to include this in Settings/System/For developers/Sudo dialog that shows up when sudo is first enabled (at least GUI and script method are two known ways to launch sudo in Germanium and earlier platforms).
Thanks.


SLEEP-1337 Add support for mobile bulk uploads

In Trypelim, we have performance issues on the form uploads.
To improve the performance of the uploads, we're grouping forms and org units into zip files (batches of 2000 forms) and upload these with only 1 API call per zip file.
This PR adds a job to process these bulk uploads:

A new API endpoint /api/mobile/bulkupload/ that takes a zip_file. This endpoint simply uploads the file to S3, launches an async job, and returns HTTP 204.
The process job creates a record in the APIImport for future reference (and to be able to tag as has_problem) and processes all files in the zip in a db transaction.

Related JIRA tickets : https://bluesquare.atlassian.net/browse/SLEEP-1337
Self proofreading checklist

[ ] Did I use eslint and black formatters
[x] Is my code clear enough and well documented
[ ] Are my typescript files well typed
[ ] New translations have been added or updated if new strings have been introduced in the frontend
[x] My migrations file are included
[x] Are there enough tests
[ ] Documentation has been included (for new feature)

@mathvdh assigning you for review, I think Martin is too busy at the moment


[Proposal]: .NET DI council

The idea here is to add some process to how we govern features that go into the DI abstraction by having the authors of dependency injection containers be the gate for new features. The original goal of the abstraction was to support a minimal set of features that most container authors could implement directly or via a small bridge (the initial feature set was designed looking at existing container implementations). Over the last couple of releases, we've had a couple of stalled feature requests because of this:

https://github.com/aspnet/Extensions/pull/2475
https://github.com/aspnet/Extensions/pull/536

Currently our stance is that we will not add any more features unless containers that already support the current abstraction continue to work. I'd like to formalize that process a bit more and have container authors that support the MEDIA (Microsoft.Extensons.DependenyInjection.Abstraciton) chime in on what their thoughts are.
Here's my proposal for the initial set of people:
Unity  - @ENikS
Autofac -  @tillig, @alexmg
LightInject - @seesharper
Lamar, StructureMap - @jeremydmiller
DryIoc - @dadhi
StashBox - @z4kn4fein
Grace - @ipjohnson
Please let me know if I've left somebody out the list here is based on my history of working on this project and having these contributors involved (this it the OG list 😄). This is an open discussion so I don't want to dictate what the process should be (though I have some ideas). Lets try to come up with something concrete based on the following example:
There's a discussion about Func<T>. There's a pull request open that seems to pass all the tests. Lets come up with how we would evaluate and accept/reject features like this.

I'm curious if this may extend beyond containers that implement the conforming container interface. For example, if there is a hook for a non-conforming container to inject things into an ASP.NET Core controller; and the abstraction now declares Func<T> support is valid so ASP.NET Core framework base controller classes somehow start requiring it; then the non-conforming container also needs to support that.

This doesn't affect non-conforming containers at all. Non-conforming containers work alongside the default implementation of the DI container.

@tillig The main difference between an adapter and a conforming container is that when using an adapter, everything is resolved through the adapter. That includes all the AspNet.Core infrastructure in addition to "user defined" services. With a confirming container, the AspNet Core infrastructure is resolved using the default container (MS.DI) while "your code" is resolved through the confirming container. So for instance, if the AspNet Core team starts to rely on new functionality in the abstraction for use in the AspNet Core infrastructure, every adapter needs to handle that.

OK, so if...

A non-conforming container registers an IControllerActivator that resolves controllers and controller dependencies from that non-conforming container AND
Base controllers or dependencies provided by the ASP.NET Core framework start requiring Func<T> or start assuming that the weird generic "filtering" thing is going on from #536 AND
The underlying non-conforming container doesn't support that but the default container implementation does, so it's assumed everything does

...then that's not the stuff we'd we're talking about here. Fair enough.
I just remember being somewhat bitten by "we assume registration of services will yield an IEnumerable<T> in the exact same order during resolve time" and that seems like it would have affected both conforming and non-conforming containers. However, if we're not talking about that sort of thing here, then good to go.

I just remember being somewhat bitten by "we assume registration of services will yield an IEnumerable in the exact same order during resolve time" and that seems like it would have affected both conforming and non-conforming containers. However, if we're not talking about that sort of thing here, then good to go.

yeah, my guess is that AspNet Core infrastructure relies on this behaviour and that is probably why it is part of the specification.
You could say that it will affect non-confirming containers as well if you start out using only MS.DI and then later on switch to a non-confirming container for "your services". Then there is a chance that some behaviour has changed and it might break.
Also be aware that it is not only the AspNet Core infrastructure that is affected by a change/addition to the abstraction. Every library/code that builds upon IServiceCollection will also be affected.

Sure. I don't mean to ride ASP.NET Core, it's just the most convenient example I can think of at the moment. It seems like from a "required supported features" standpoint it goes both ways:

From the composition root out through the leaves by way of IServiceProvider resolving IControllerActivator (or other hooks for non-conforming containers).
From the leaves, testing against the "default services" (based on the default container) and assuming incorrectly that "however the injection happens, it'll just work."

If we're defining a set of common features that all "sources of injection" (be they conforming or non conforming containers) need to support - that netstandard of containers - then it seems like it does affect both conforming and non-conforming containers.
Again, latching onto ASP.NET Core, if a framework-provided base class in a controller class hierarchy requires Func<T>, even the non-conforming container implementing IControllerActivator then needs to support that. That's perhaps a contrived example but the idea is there.
public class MyController : HttpClientControllerBase
{
  public MyController(Func<HttpClient> clientFactory) : base(clientFactory){}
}
public abstract class HttpClientControllerBase
{
  public HttpClientControllerBase(Func<HttpClient> clientFactory)
  {
    // Some value-added controller base class from the framework, but which lives
    // in the class hierarchy of application code. This will come from the non-conforming
    // container via IControllerActivator, not the IServiceProvider.
  }
}

From a blinders-on standpoint, saying "containers and lifetime scopes should support Func<T>" isn't a huge deal by any means. But it does imply that it isn't just containers that implement IServiceProvider or IServiceScope that will be affected by the decision. It's anything in the system that is responsible for resolving dependencies.
MEDIA.IServiceProvider => MEDIA.IServiceScope => IControllerActivator => need to resolve Func<T>.

That being said, I welcome this council initiative so that we can discuss the abstraction going forward. At the same time I'd like to point out that it is important that we don't raise the bar too high.

I concur with @seesharper The council should help foster new functionality while still keeping compatibility with existing adapters. Func<T> and constrained generics seem like two worth while features.
@davidfowl is there any president to follow or is this type of thing new ground?

I suggest SimpleInjector's: @dotnetjunkie
He was very involved in the original discussion wrt to conforming containers.

@Tornhoof that's fine but I guess I should be more clear what this is. I wanted to make the current process a bit more formal but I didn't intend for this to be a design by committee thing. I want to get the opinions of the DI authors to see if we should allow new features into the abstraction since we currently reject every new feature. I haven't thought through how that would work other than tagging people on issues or PRs.

@davidfowl You asked

Please let me know if I've left somebody out the list here is based on my history of working on this project and having these contributors involved (this it the OG list 😄)
I suggested Steven, that's it. No hidden agenda here.

I welcome the initiative. The abstraction should evolve and new features should not be stopped.
Unity already implements both of the features in question, so it would be desirable to keep it compatible with existing implementation, otherwise you have my vote.

I want to clear up one thing, Microsoft is still going to ultimately decide on what features to include/exclude into the container abstraction. The goal of this is to formalize how we go about evaluating new features and we need to not only consider new container authors that want to implement the abstraction. That's why we should be extremely conservative when looking at new features. For example, Func<T> does not work in the stashbox container (https://github.com/aspnet/Extensions/pull/2475/files#diff-38ee0d32417bbdf7da2b4438bf87deceR8).

So an extremely low overhead way to start this. I'm going to make a team on github (if the powers that be allow it) with the people in this group. When new issues or pull requests come up, I'll tag the group to have a discussion about it and we can take it from there.

For example, Func does not work in the stashbox container

@davidfowl Not entirely true, it just doesn't pass the assertion that you get a Func<IService> from the container. Instead, you get a Func<ActualService> when ActualService is the registration. Let me see what I can do to make them pass.

@davidfowl Changed the skipped tests, they don't have to be skipped any more and StashBox fully supports Func<T>.

If we take Func<T> as a "simple" example, we need a few more tests to prove that we have a consistent behaviour across all containers. Once we start to talk about deferred service resolution like Func<T>, there are questions like ..What if the service is registered as a scoped service? LightInject closes the Func<T> around the scope from which the graph was requested to ensure that we don't need ambient context such as storing the "current" scope in an AsyncLocal<T>.

We might be getting in the weeds a bit if we dive too deep into specific features in this particular issue since it seems like this was more about the formation of the council using those noted items as examples. If there's a GitHub team, maybe we can have some chats there?

Ok great let’s feel this out with the discussion being on Func<T>.

Just wanted to emphasise that there might be more than meets the eye even when it comes to adding the simplest feature 😊.

@davidfowl @danielcweber Yeah, I also noticed those broken tests and thanks for pointing out that not the entire functionality is broken, but Stashbox behaves a bit different. However, that was a glitch in the implementation which I already fixed. I'll release the fix with the next version soon, but first I want to finish some other ongoing developments on it.
I also fixed that part recently which caused the open generic related tests to fail, so with the next version all the skipped tests should pass.

I haven't forgotten about this 😄

Does...does this mean constrained generics might actually make it in? 😍


Tasks for blog tutorial

[x] Intro
[x] Minimal view
[x] *args trick for building out content
[ ] Read files from disk
[ ] List articles view
[ ] YAML parsing
[ ] Markdown formatting
[ ] Detail view
[ ] RSS feed
[ ] Pages independent of the list of articles (about and contact come to mind)
[ ] Import and Export of articles
[ ] Tagging and categorization of data
[ ] Deployment
[ ] Ability to scale for large volumes of readers (caching)
[ ] Migrate to database
[ ] Authentication
[ ] Socials
[ ] Favicon
[ ] Web form for data controls
[ ] Tests

+1 excited for this!

Form validation within the web form section would be a good addition.

@pydanny I'd love to write something to include for rendering Jupyter Notebooks as blog posts as a second format to markdown.  I think it would loop through the cells in the JSON and have each rendered based on the cell type.

Markdown cells -> Rendered with MarkdownJS
Code Cells -> Rendered with  HighlightJS
Cell Output -> TBD, probably depends on what the output is

I can also do this as a separate blog post that builds on this tutorial if that's better.


Bridgetown 1.2.0 upgrade

I suspect Bridgetown 1.2.0 will be out in a few weeks. The site will be upgraded to it eventually.

Commit 3305895cc3ae373ffe84fe178e6e1f71734817c0 closes this pull.


Hot to render a button/image/hyperlink column?

How to render a button/image/hyperlink to a specific column by delegating a function?
I need put a clickable column to open an URL.

If you're building the table and then initializing the DataTable you can just set the contents of the cell to be the link you want.
However, +1 for the option of formatter being a function that formatting can be delegated to.

Cell formatting / rendering is definitely something that needs to be added.

A custom column renderer can now be used. See the columns option.

Excellent news @Mobius1 !!!
Thank you.

Closing this now. Reopen if any issues arise.


Fix flash cache fallback

Apparently I didn't test the fallback/error handling... and my emulator hits both of these cases.

:grin:
Thank you!

:grin:
Thank you!


Issues with claim mapping when multi value attributes in the claims.

There is an issue when processing role claim when the claims are multi valued.
ex :- roles=[Ljava.lang.Object;@60d47880,

Can you provide a bit more details on how to reproduce this?
For example, in which flow did you encounter this error?


Support for UUID as ids

We at Uber are evaluating adoption of the CAPS library but need support for UUID as ids. I see that the library is limited to Long ids. Is there any gotchas that I should be aware before I attempt changing the library to use UUID? Also is there any design documentation that can help me ramp-up on the library?

Hey. Thanks for your interest in CAPS and sorry for the late reply.
You are right, we currently enforce the id datatype to Long. However, it is possible to change this to any data type supported by Spark. Unfortunately, Spark has no native support for Java UUIDs. We actually did an experiment using StringType and it did not require a lot of changes in the code base.
Before doing this, I was wondering if your use-case involves a static data set. In that case, one could transform / generate identifiers in an independent job, persist the graph and use it for querying. We have tooling for id-generation as part of the SQL PGDS.
If you wanna adapt the library to handle String ids instead of Long ids, one of the biggest "gotchas" is how we avoid collisions when computing a union over multiple graphs. This is needed during CONSTRUCT ON clauses. We currently store a graph identifier (a graph tag) in the upper bits on an identifier. Those tags would need to be encoded into the String-ID, too.
In both cases = generating long ids or changing the id type - we could have a call and discuss the options. Let me know what you think.
I will prepare an up-to-date architecture overview of Okapi/CAPS in the next days and share it in the repo.

Please have a look at these Google slides for an overview of the project and its modules. It is probably not as detailed as you'd like. Let me know if you have additional questions.

Hi Martin, thanks a lot for your time and feedback. The google slides get us started down the path of understanding CAPS library better. Looking forward to your more detailed overview.
As to the ids, we also came to the same conclusion regarding UUID vs String. Also, our use case does not allow for generating Long identifiers.
I was able to convert the library to use StringType. However, it needed quite a lot of changes especially in the tests. We ended up commenting out quite a few test-cases. Can you point me to your experiment using StringType, if you still have it? I'm now working on parameterizing the library so that it can support both Long and String. Did you explore that path already?

Hey. Unfortunately, there is no branch that contains our previous experiments. We thought about generalizing the identifier type but didn't actually go forward with it. If you want me to have a look at what you've already done, you can point me to a branch or open a PR.

Thanks a lot for responding. I got a bit sidetracked and forgot to check this thread. Will forward the PR soon.

@ram-senth we just merged our new ID representation, CAPS identifiers are now of BinaryType. You could already cast your string UUIDs to BinaryType and that should just work as an ID column.


fix move tables from connect context to statement context (#44568)

pick: (#44568)
Problem Summary:
When using tables in connect context, it would keep on memory in next run in the same session, but it should not be in memory when running next sql statement
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)

Test

[ ] Regression test
[ ] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[ ] No need to test or manual test. Explain why:

[x] This is a refactor/code format and no logic has been changed.
[ ] Previous test can cover this change.
[ ] No code files have been changed.
[ ] Other reason

Behavior changed:

[x] No.
[ ] Yes.

Does this need documentation?

[x] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

run buildall

already processed by #45679


Fix #932

Fixes #932
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Delete all SDL enabled apps from device

Install  SDL enabled app that contains older router service ( < lib version 4.5) (eg Ford Alexa), connect to Core/TDK, App shows and hosts router service
Install Hello Sdl app, app also shows on tdk
Shutdown Core/TDK
Ensure all apps destroy their sessions and services

Summary

Removed dynamic creation of TransportRecords for older router services and replaced with a constant one.

Changelog
Bug Fixes

#932

CLA

[x] I have signed the CLA

Codecov Report

Merging #1021 into release/4.8.0-rc1 will increase coverage by 0.06%.
The diff coverage is 20%.

@@                   Coverage Diff                   @@
##             release/4.8.0-rc1    #1021      +/-   ##
=======================================================
+ Coverage                 45.2%   45.26%   +0.06%
  Complexity                3623     3623
=======================================================
  Files                      433      433
  Lines                    20153    20146       -7
  Branches                  2159     2157       -2
=======================================================
+ Hits                      9110     9119       +9
+ Misses                   10602    10584      -18
- Partials                   441      443       +2

Impacted Files
Coverage Δ
Complexity Δ

...com/smartdevicelink/transport/TransportBroker.java
23.26% <20%> (+0.68%)
20 <1> (ø)
:arrow_down:

...smartdevicelink/encoder/VirtualDisplayEncoder.java
28.97% <0%> (+4.54%)
8% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f074f87...bfd210e. Read the comment docs.


Screenshot pixel comparison - visual regression testing

What is your Scenario?
Visual regression testing using testcafe. Compare screenshots that testcafe takes to test for changes to page styling.
What are you suggesting?
Able to take a screenshot in a test, that then gets saved to a folder somewhere, then on subsequent tests that image is compared against to see for any regression.
What alternatives have you considered?
Currently use backstop.js, but we would much rather share our POM's and use the testcafe api to write these tests.
Additional context
No response

Thank you for your suggestion!
However, we have a similar one here: https://github.com/DevExpress/testcafe/issues/1207. Thus, I'm closing this issue. Please subscribe to https://github.com/DevExpress/testcafe/issues/1207 to stay tuned and keep track of our progress.


[WFRP4e System] Item Post to Chat calculates wrong price amount

When we post a Trapping Item to the Chat with "Post Quantity 1" and "Item Quantity 3", price will still display only for single item (1 unit).
If player pressed "PAY", they only pay for single item, despite there being 3.
Same happens for "Post Quantity". So long story short, there is no difference between the two at least from what I can tell, so something most likely is broken.
From<EMAIL_ADDRESS>11.302wfrp4e: 6.5.9wfrp4e-archives1: 3.0.2wfrp4e-archives2: 3.0.6wfrp4e-core: 3.1.4wfrp4e-rnhd: 3.0.7wfrp4e-up-in-arms: 3.0.6wfrp4e-wom: 3.0.5wfrp4e-zoo: 3.0.2Active Modules: darkraven-games-soundscapes-free, dice-so-nice, forien-armoury, forien-quest-log, forien-unidentified-items, foundryvtt-simple-calendar, lib-wrapper, michaelghelfi, polyglot, popout, tabletop-rpg-music, token-action-hud, tomcartos-ostenwold, wfrp4e-gm-toolkit

This is simply a limitation. Item price is assumed to be the price for the quantity, e.g. the price of 12 Arrows.


Integration Issue When Adding Secret

Hi @KiraPC,
Apologies if this has been answered somewhere. I cant seem to find anything. Im just at the stage where Im trying to add the integration after downloading from HACS. When I add it from the list, it asks for a name for the Hub and the token and secret. On entering the details the window flashes away and the form is shown with all the fields empty. I cant actually get to the stage where it is shown with all of the other integrations. Im fairly new to Home Assistant and may be doing something wrong here.
Followed instructions on downloading through HACS
Sourced the token and secret via the app on mobile device
Tested response using the API URL via power shell with positive response (API v1.0) so secret works
Use of these when adding the integration returns a suspected error. The same thing happens if I put "a" in all 3 fields, just faster as the failed response is returned faster.
Just wondering if there are any quirks im missing here. I also rolled back to v1.1.1 incase there was an issue with the latest. Unsure what im doing wrong.
https://youtu.be/5CiSmIjn8QE

Had some luck.
Reset the secret a few times and copied the string from the switchbot app and pasted directly to HA (on the same device). Previously had been sending the strings via email to a different device before pasting.


slidesToShow not working?

short description of the bug / issue, provide more detail below.

Tried using slidesToShow setting - doesn't work? auto adjusts width but doesn't show X amount of slides.
Steps to reproduce the problem
Here is my code (no jsfiddle as generated with PHP):
jquery:
$('.product-gallery').slick({
    arrows: false,
    fade: true,
    infinite: true,
    slidesToShow: 4,
    slidesToScroll: 1
});

php/html:
<?php if (count($product_gallery_slides) > 0) : ?>

        <?php foreach ($product_gallery_slides as $slide) : ?>

                <img src="<?php echo plugins_url('path/to/images/'). $slide->slide_img; ?>"
                     alt="<?php echo $info->model_name; ?> Slider" />

        <?php endforeach; ?>

<?php endif; ?>

====================================================================
What is the expected behaviour?
...   to show 4 slides at once
====================================================================
What is observed behaviour?
...  it shows one result
====================================================================
More Details

Which browsers/versions does it happen on?
Linux Mint Firefox

Which jQuery/Slick version are you using?
jQuery - 3.21.1
can't find my download link I used (new OS so data lost)

Did this work before?
Not sure - hadn't tried

I fixed using:
    $('.product-gallery').slick({
        arrows:         false,
        autoplay:       true,
        autoplaySpeed:  4500,
        infinite:       true,
        pauseOnFocus:   false,
        pauseOnHover:   false,
        slidesToShow:   4,
        slidesToScroll: 1
    });

please close :)

Can't use fade : true it seems..

You could but only with slidesToShow: 1 for now


Add latest alias

This commit adds a Lambda alias called latest that points to the
most recently published version of the function. This is a workaround
for a defect in the data source aws_lambda_function:
https://github.com/terraform-providers/terraform-provider-aws/issues/10038

@JonRoma please review, squash merge, and tag with version v3.1.1.


Porting custom video player in Lightning SDK

Hi,
Is there anyway we can port a custom video player in Lightning SDK and use/augment the standard Videplayer apis (https://rdkcentral.github.io/Lightning-SDK/#/plugins/videoplayer)?
We want to add a custom player to enhance current Videoplayer capabilities like playing drm and ads and collecting custom metrics information.
Please let us know if this is achievable.

hi, anyone has any pointers about this?

This is highly achievable; The VideoPlayer plugin is nothing more then a bit of abstraction for the HTMLVideoElement https://github.com/rdkcentral/Lightning-SDK/blob/6d239403a40c4f53ea1054ebd79124e712102ea1/src/MediaPlayer/index.js#L94
If your app needs more advanced functionality like DRM protected content we highly encourage you to build (or port) your own player and where needed use VideoPlayer methods: https://rdkcentral.github.io/Lightning-SDK/#/plugins/videoplayer?id=available-methods


[new] - Implement aria-role-supports-attribute

Fixes #17
Name change?
Thinking maybe just role-supports-attribute
This one was difficult because of the implicit roles. Not sure I managed to get every use case because elements with various props resolve to different implicit roles.

Coverage increased (+0.2%) to 99.109% when pulling dcd7e3dd305d0ce45e0cda2adb431c961ee91204 on develop into 47ab6e638108294f17fbe78bd56e234552ced900 on master.

Coverage increased (+0.2%) to 99.109% when pulling ca96b7418bde0ff753deff2bf2d50ccb76311a6a on develop into 47ab6e638108294f17fbe78bd56e234552ced900 on master.


RO/v1/deregister-application does not call ALT/v1/delete-ltp-and-dependents

Problem:
when RO/v1/deregister-application is invoked then it calls ALT/v1/update-ltp.
However, it should call ALT/v1/delete-ltp-and-dependents based on load file forwarding ServiceRequestCausesLtpDeletionRequest.

I also noticed that ALT/v1/delete-fc-port is not called during RO/v1/deregister-application.
I think it is because load file forwarding ServiceRequestCausesFcPortDeletionRequest does not contain input fc-port with ro-0-0-1-op-s-3002 (v1/deregister-application).
Is it desired? or a bug?

This issue seems to be wrongly assigned.
Checked ForwardingList and CONFIGfile:

/v1/deregister-application is invoking ALT/v1/delete-ltp-and-dependents, which seem to be correct.

Might it be possible that this issue describes some fault in the implementation and needs to be assigned to the person who implemented the RO?

I am referencing the question in the comment from 24th of August:

If RO/v1/deregister-application is calling ALT/v1/delete-ltp-and-dependents, not just the LTPs, but also the FcPorts, which are referencing the LTPs, shall be deleted.
So, it is not necessary to additionally call ALT/v1/delete-fc-port for deleting the FcPorts.

closing based on clarification in last comment


[📖] Links to Discord are not working

Suggestion
Links to Discord are not working. All links lead to https://qwik.builder.io/chat, but I get a message that this page was not found (404). I found a link on https://qwikcommunity.com, namely https://discord.com/invite/bNVSQmPzqy, but this invitation seems to be broken. Where can I find the actual link to the Discord group?

until it get fixed, you can use the following link -
https://discord.gg/U5yhC4bdjr

@shairez Thank you very much!

Should be fixed now, thanks for letting us know.
https://github.com/BuilderIO/qwik/commit/7a7620331da2914617dfc999d06534dc3569fb29


resources/page: Fix sections and taxonomies path for AMP and similar

This shall Fixes #7159 .
Before this fix
/{section}/amp/
/{taxonomy}/amp/
/en/{section}/amp
/en/{taxonomy}/amp/
/th/{section}//amp
/th/{taxonomy}/amp/

After this fix
/amp/{section}/
/amp/{taxonomy}/
/en/amp/{section}/
/en/amp/{taxonomy}/
/th/amp/{section}/
/th/amp/{taxonomy}/

I'm a little surprised there were no test break, but I think you need to argue why
/en/amp/{section}/
Is more correct than:
/en/{section}/amp
Note that the current implementation is, if I remember correctly, deliberate. So, for a given page/section/whatever, add /amp to the path to get to the AMP version.

I'm a little surprised there were no test break,

it seems there is no testing about the AMP page  path expectation.  :joy: and AMP Format is the only one that provide the
d.Type.Path

So, I would expect it does not break any tests.

but I think you need to argue why
/en/amp/{section}/
Is more correct than:
/en/{section}/amp
Note that the current implementation is, if I remember correctly, deliberate. So, for a given page/section/whatever, add /amp to the path to get to the AMP version.

Ummm, I'm not so sure which one is correct. but for me, if keeping one folder for AMP version then it would be easier for debugging.
But the current behavior is mixing as below:
/en/{section,taxonomy,term}/amp/
/en/amp/{page}/

So I would like to avoid mixing as below:
/en/amp/{page,section,taxonomy,term}/
``

Note: This issue related to #5760, then `/en/amp/{section}/` would be the correct one.

the second commit, I have added test case section,taxonomy,term for amp page.

This PR is ready, @bep  if you have any comment let me know.
This also fix #7342 as User config
[outputFormats]
  [outputFormats.AppFormat]
    name = "app"
    isPlainText = false
    mediaType = "text/html"
    isHTML = true
    permalinkable = true
    path = "app"

[outputs]
  section = ["HTML", "APP"]
  page = ["HTML", "APP"]

User config define path
path = "app"
Before this fix
/{section}/app/
/{taxonomy}/app/
/en/{section}/app/
/en/{taxonomy}/app/
/th/{section}/app/
/th/{taxonomy}/app/

After this fix
/app/{section}/
/app/{taxonomy}/
/en/app/{section}/
/en/app/{taxonomy}/
/th/app/{section}/
/th/app/{taxonomy}/

without this fix, it lead User to confuse about what is the Custom output path as comment in #7342

I've created a repository with the minimum required to demonstrate the problem.
https://github.com/maxwedwards/hugo_issue_7342
Browse to /blog and see a working image
Browse to /blog/app and see that the image is broken
Browse to /blog/post1 and see that the image is working
Browse to app/blog/post2 and see that the image is working
Note that the image is available at: /app/blog/grapefruit.jpg but the index.html is at /blog/app.
Hope I'm explaining myself.

see the original comment: https://github.com/gohugoio/hugo/issues/7342#issuecomment-636887704

I belive this fixed, will never be merged, so anyone want this fix, I have forked this project to https://github.com/neohugo/neohugo.


added >= python3.3 support, yeah!

Changed some little code to make django-disqus work with >= Python 3.3 and >= Django 1.6 keeping backward compatibility.

I've merged another PR which includes these changes. Thanks anyway!


bots: Refactor youtube bot.

I have modified the Youtube bot (as a GCI task ) to use the Youtube Data API instead of BeautifulSoup.
The bot now responds with single video as well as a list of videos.
There are a couple of things left to do , but I have opened this PR for feedback on any changes that maybe  needed.
TO-DO:

[x] Handle errors from API
[ ] Add more tests
[ ] Add documentation

I haven't done a detailed review yet, but this seems like a reasonable approach so far!

Merged, thanks @SivagiriVisakan!  I can tell a lot of careful work went into this!


Add file extension (.html.twig)

Hello! I added recognition of popular twig file extension - .html.twig, is is used in Symfony2 framework by default. I this it will be useful )

Merged, thanks.


Updates to SendGrid bindings

@andresnava : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


feat: added Rename button to File Explorer

This PR...
Changes

added Rename file or folder functionality to File Explorer
added Select All hotkey (ctrl+a or cmd+a)

Screenshots

lgtm! And liked this!!

Looks good! Let's do one last change, instead of creating two redux actions: setScanExcludesUpdated and setScanExcludesOutdated, you could create a single setScanExcludesStatus action.
You could rename isScanExcludesUpdated to scanExcludesStatus and set the type to 'applied' | 'outdated' , then use the setScanExcludesStatus to toggle between applied or outdated. Thanks!

Looks good! Let's do one last change, instead of creating two redux actions: setScanExcludesUpdated and setScanExcludesOutdated, you could create a single setScanExcludesStatus action. You could rename isScanExcludesUpdated to scanExcludesStatus and set the type to 'applied' | 'outdated' , then use the setScanExcludesStatus to toggle between applied or outdated. Thanks!

Done.


Set up Prettier

I must say, I don't agree with all of the decisions that Prettier makes, but considering that it's such a ubiquitous tool, I see why we would wanna have it in our project.
Closes #151

Looks like we need to reconfigure eslint and stylelint to be compatible with Prettier


Publish Versioned Artifacts

Hey everyone! Love this project. I have been recommending it for GitOps as an export tool.
Given the current state of the project, it's difficult to tell what state the software is in. Additionally, for people that don't have golang installed on their local boxes or know anything about it, compiling from source is a huge barrier to entry. Is there a plan to start implementing binary releases for various architectures based on semantically versioned code?

Hello,
We recently created a release with artifacts https://github.com/konveyor/crane/releases/tag/v0.0.1
Please note that many of the plugins and other such utilities are not yet built/available but we are working on some enhancements in this space: https://github.com/konveyor/enhancements/pull/41
This enhancement will be superseded IIUC by another engineer shortly if you would like to follow along with that!
Going to close this issue as I believe that the main ask has been completed. Could you re-open if you disagree?


Update LICENSE

Scan submitted to Checkmarx

Checkmarx scan completed
Full Scan Details
Checkmarx Scan Summary

Severity
Count

High
29

Medium
12

Low
36

Informational
0

Violation Summary

Severity
Count

High
25

Details

Lines
Severity
Category
File
Link

22 23 24 25 10 26 27 28 47
High
Reflected_XSS
app/routes/profile.js
Checkmarx

34 10
High
Reflected_XSS
app/routes/contributions.js
Checkmarx

71 60
High
Stored_XSS
app/data/contributions-dao.js
Checkmarx

24 25 26
High
Code_Injection
app/routes/contributions.js
Checkmarx

78
High
Reflected_XSS
app/routes/index.js
Checkmarx

98
High
Stored_XSS
app/data/profile-dao.js
Checkmarx

24 25
High
Security_Misconfiguration
app/routes/profile.js
Checkmarx

192 256 191
High
Reflected_XSS
app/routes/session.js
Checkmarx

195
High
Security_Misconfiguration
app/routes/session.js
Checkmarx

85
High
Security_Misconfiguration
server.js
Checkmarx

Library
Severity
CVE

Scan submitted to Checkmarx

Scan submitted to Checkmarx

Checkmarx scan completed
Full Scan Details
Checkmarx Scan Summary

Severity
Count

High
29

Medium
12

Low
36

Informational
0

Violation Summary

Severity
Count

High
25

Details

Lines
Severity
Category
File
Link

22 23 24 25 10 26 27 28 47
High
Reflected_XSS
app/routes/profile.js
Checkmarx

34 10
High
Reflected_XSS
app/routes/contributions.js
Checkmarx

71 60
High
Stored_XSS
app/data/contributions-dao.js
Checkmarx

24 25 26
High
Code_Injection
app/routes/contributions.js
Checkmarx

78
High
Reflected_XSS
app/routes/index.js
Checkmarx

98
High
Stored_XSS
app/data/profile-dao.js
Checkmarx

24 25
High
Security_Misconfiguration
app/routes/profile.js
Checkmarx

192 256 191
High
Reflected_XSS
app/routes/session.js
Checkmarx

195
High
Security_Misconfiguration
app/routes/session.js
Checkmarx

85
High
Security_Misconfiguration
server.js
Checkmarx

Library
Severity
CVE

Scan submitted to Checkmarx


Adding support for flowing compilation settings to views

Fixes #871

Updated.

Copying here since the comment got buried:

Based on what I'm seeing here though it's going to resolve all the options from the project.json + defaults for the current framework and current configuration. What happens if there's commandline args affecting compilation as part of the current environment?

I don't follow - what do you mean by current environment?

Presumably this code is running under klr.exe right? Any settings that affected klr.exe are part of the current environment. So is there ANYTHING that affects the compilation behavior of klr.exe and isn't stored in project.json? (environment variables, commandline).
If that's possible (now or in the future), then this strategy is broken.

:shipit: after a brief discussion and adding a protected property for compilation settings

Presumably this code is running under klr.exe right? Any settings that affected klr.exe are part of the current environment. So is there ANYTHING that affects the compilation behavior of klr.exe and isn't stored in project.json? (environment variables, commandline).

AFAIK, we don't have anything that does this as yet. That said if we do have additional options that could modify the behavior of compilation, we'd probably evolve the interface to ensure these are covered. @davidfowl  might have more insight on the likelihood of something like this happening.


Rent data read from excel

Rent data read from excel.

This need not be merged. We will get this closed.


White outline around objects in web examples.

Bevy version
Web examples
What you did
Opened examples in Chrome (Version 108.0.5359.124 (Official Build) (64-bit)) and Firefox (108.0.2 (64-bit)). All scenes have problems with rendering apparently antialiased objects - both 2d and 3d:

I am running on Linux Ubuntu 18.04, Nvidia Quadro P1000, Driver Version: 525.60.13

maybe related to #3593

Indeed. I tried to find a similar issue, but didn't see this one. In my case, I don't know the version and can't change samples count.

This may be fixed in https://github.com/bevyengine/bevy/pull/7356. @nikitablack are you able to test?

I tested it. It is the same. The interesting thing I noticed though is that some examples look correct:

This is a screenshot from the UI/text example.


Llm06 sensitive info disclosure

@aishields , thank you for the fix with person name. with this small PR, I changed:

import path for config
person name pattern
test case improvement

Merged @AkerkeKesha changes


set ObservableObjectPublisher on Published

Solution to #160 and #97?

LGTM

  Generated by :no_entry_sign: Danger Swift against 4f8644c9a4acdf98c55e69f0809b08f66e5702dd

https://github.com/apple/swift-evolution/blob/master/proposals/0267-where-on-contextually-generic.md will solve that, right?

@nidegen I don't think so. This is still compile-time stuff. Apple uses runtime introspection in their implementation for a reason.

I was thinking that maybe it would work to add the static subscript function in a conextually generic extension. In principle, everything should be known at compile tim, or am I missing something?

In principle, everything should be known at compile time, or am I missing something?
No. Published can't possibly know at compile time anything about the object that it's contained in.

OK. Bute EnclosingSelf is not type-checked then? I am confused, sorry for the questions:)

OK. But EnclosingSelf is not type-checked then?

Well, it is, but that doesn't help us. Even if we constrain EnclosingSelf to be ObservableObject, this won't help us, because things are the other way around really: it's not Published that sets its objectWillChange property by taking a publisher instance from ObservableObject's objectWillChange. It's ObservableObject that should store the newly created publisher instance somewhere. And that "somewhere" is the @Published properties of the class that conforms to ObservableObject.
Simply put, we want the following semantics: suppose we have a class that conforms to ObservableObject and has some @Published properties. We wan't to be able to access the objectWillChange property once and get a publisher instance, then access it again and get the same publisher instance. We can only do this by using some magic in the implementation of objectWillChange.

I am confused, sorry for the questions:)

It's OK, I'm happy to answer them!

I see, getting the publisher from ObservableObject is impossible, I agree. But how are you so certain that it is not Published that takes the publisher from ObservableObject? What is bad about that?
If there is no way to do it the way you want it in normal Swift, I don't see why Apple would change so much to their version.

But how are you so certain that it is not Published that takes the publisher from ObservableObject? What is bad about that?

Because in order for the static subscript of @Published to be called, we need to access one of the @Published properties. But the objectWillChange publisher should be stored somewhere even if we never access any of the @Published properties in our client code.
In other words, this code should work:
class Foo: ObservableObject {
    @Published var i = 0

    init() {}
}

let foo = Foo()
assert(foo.observableObject === foo.observableObject)

Another thing is that we can't afford to access ObservableObject's objectWillChange property in Published because the client can always implement objectWillChange themselves instead of relying on the default implementation. In that case, we'll have the situation where in OpenCombine that implementation is invoked when we access the static subscript in Published, but in Combine it's not invoked. This is the kind of semantic incompatibility that we want to avoid.

OK, I thought the subscript got called on init. But with the second argument I have to agree.
Looking at the subscript proposal, I still think they did it somehow like that:)
You mean:
assert(foo.observableObject === foo._i.observableObject)

right?

You mean:
assert(foo.observableObject === foo._i.observableObject)

right?
Nope. I've made a typo, it should be foo.objectWillChange instead of foo.observableObject, but otherwise what I've written is correct. Meaning that the objectWillChange property should not return a new publisher instance each time it is accessed.

ha, I did actually make the same mistake reading. Of course it is objectWillChange.


The description for "Kudu publish API(type=static)" is NOT correct?

Kudu publish API reference says as following.
"- type=static: Deploy a static file (e.g. a script). By default, the file is deployed to /home/site/scripts. The target path can be specified with path."
As far as I tried,

"path" must be specified when type=static.
Only path under /home/site/wwwroot can be specified.

When "path" is not specified, by default, the file is NOT deployed to /home/site/scripts as follows.

When path except under /home/site/wwwroot is specified, the following error occurs.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4ce674e6-fcb7-a867-2a74-f28f6a1b0204
Version Independent ID: 461fc0b5-ac32-54b8-cdb6-76a2c8e6052f
Content: Deploy files to App Service - Azure App Service
Content Source: articles/app-service/deploy-zip.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

@take-4c, Thanks for the feedback! We are taking a look into this and will get back to you soon.

take-4c, Apologies for the delay! We'd been discussing on this internally. Currently, there is no mechanism in the Kudu publish API to deploy a static file to a custom directory outside of wwwroot. So, limiting the path to just ‘/home/site/wwwroot/’ for static deployment. We have shared the feedback to our product team.
For now, you may try using the Azure CLI command “az webapp deploy” to deploy a zip file with the script to the desired directory.  az webapp deploy --resource-group <group-name> --name <app-name> --src-path <zip-package-path>
We have raised a PR, updating to - type=static: Deploy a static file (e.g. a script). By default, the file is deployed to /home/site/wwwroot., the published changes would reflect in the doc in a few hours.
Once again, thanks for taking time to share your value feedback to improve Azure docs.

take-4c, the document reflects the published changes. Thanks again taking time to share your value feedback to improve Azure docs.

@AjayKumar-MSFT -san,
Thank you! :)


Removing default for volume-plugins mountpoint

All checks test if this is defined meaning there is no way to undefine it. Also adding in volume mount statement in docker based kubelet.
ref https://github.com/kubernetes-incubator/kubespray/pull/2132

ci check this

I'm not a big fan of this approach. We have people now relying on this behavior as it was.
Undefine is possible with a hack: !!null value in your group vars or external vars file. It does work, last I checked.
What is the problem with keeping this var enabled, but fixing the double mount issue?

@bradbeam can you change the PR topic to reflect the new intent? Maybe set it to Improve handling of volume-plugins dir


TypeError: Cannot read property 'body2' of undefined

0
When I test the component and I try to mount it, I get the error in the title. When I dug into the stack trace I found the result in the file:
<EMAIL_ADDRESS>and the code in this file is this:
var styles = function styles(theme) {
return {
root: {
margin: 0
},
body2: theme.typography.body2, //this line makes the exception
........
adding the end of the stack trace:
at stytlesOrCreator (node_modules/@material-ui/core/Typography/Typography.js:34:29)
at Object.create (node_modules/@material-ui/styles/getStylesCreator/getStylesCreator.js:32:35)
at attach (node_modules/@material-ui/styles/makeStyles/makeStyles.js:113:32)
at func (node_modules/@material-ui/styles/makeStyles/makeStyles.js:258:7)

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
my test crashes
Expected Behavior 🤔
not crashing LOL
Your Environment 🌎

Tech
Version

Material-UI
v4.9.4

React
v16.3.1

TypeScript
v3.7.2

@RoeiRom Please provide a minimal reproduction test case. This would help a lot 👷 .
A live example would be perfect. This codesandbox.io template may be a good starting point. Thank you!

Forgot to wrap the mounted component with the MuiThemeProvider


Fix Build badge and add some more

Fix the broken Build badge link.
Also add some more to avoid a single badge display, but it's a personal preference so I'm open for feedback.

Codecov Report

Merging #317 (c15b1ed) into main (18e3903) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 45.21%.

@@           Coverage Diff            @@
##             main     #317    +/-   ##
========================================
  Coverage   39.74%   39.74%
========================================
  Files         105      105
  Lines       11230    11337   +107
========================================
+ Hits         4463     4506    +43
- Misses       6320     6373    +53
- Partials      447      458    +11

Files Changed
Coverage Δ

banyand/metadata/schema/checker.go
33.82% <0.00%> (+0.49%)
:arrow_up:

pkg/run/run.go
0.00% <0.00%> (ø)

test/stress/cases/istio/repo.go
0.00% <0.00%> (ø)

banyand/metadata/schema/node.go
7.14% <11.11%> (+7.14%)
:arrow_up:

banyand/measure/metadata.go
49.19% <50.00%> (ø)

banyand/metadata/server.go
48.93% <50.00%> (-2.18%)
:arrow_down:

banyand/metadata/schema/etcd.go
57.14% <50.98%> (-1.34%)
:arrow_down:

banyand/metadata/client.go
38.46% <54.16%> (+2.62%)
:arrow_up:

banyand/liaison/grpc/server.go
66.86% <63.63%> (-0.01%)
:arrow_down:

banyand/measure/service.go
74.75% <87.50%> (+0.49%)
:arrow_up:

... and 4 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


add animation duration

Adds a duration property
For our project we want to have the animation duration set to 250ms. That's why we want to have it customizable. The prop is optional and set to 300ms by default.
@hieunc229

Hey Daniel, it definitely makes it more convenient when using the component. I have merged the PR and push it to the latest version (v1.6.0)
Thanks for the PR.


Warning from Browserslist

Thanks for this project :)
Since adopting this in ocaml-ci we're seeing the following message when we build the project
Browserslist: caniuse-lite is outdated. Please run:
  npx browserslist@latest --update-db
  Why you should do it regularly: https://github.com/browserslist/browserslist#browsers-data-updating

Following the directions does not do much - the warning continues to occur. Wondering if this is because caniuse-lite requires updating here?

Hi @novemberkilo!
I just upgraded to the latest tailwindcss version (3.2.4). Do you still have the warning using the latest commit?

I confirm that using latest tailwind fixes this warning.

Thanks @tmattio for the quick turnaround. Much appreciated :)


Fixes #162

I fixed the little typo in the doc.

Thanks for the correction.
For future modifications on the documentation, you should PR from/to the mkdocs branch.
For the time being, I will accept this PR to the gh-pages branch because the build process of the documentation may be broken due to new versions of the API generation software and I don't have time to fix it right now.

Avec plaisir ! I'll take a look at that.
(It's always funny when you'll end speaking english with someone and you'll discover afterward he's living in the same town in France)


workbench:  factor initial dev feedback

@Jasagredo has generously supplied some feedback from using the Workbench:

For localised packages, the README mistakingly mentions the necessity to comment out their corresponding source-repository-package clauses, which is unnecessary
The package localisation should be explicitly mentioned
The version manifest report should precede the executable prebuilds
The executable prebuilds should have an option for verbosity
The executable prebuilds should retain colors
locli verbosity might need turning down by default

Merged, as part of https://github.com/input-output-hk/cardano-node/pull/4351


How can I listen to sms with the app closed?

Hey first of all thanks for the code!
Is there a way of keeping this listener susceptible to sms's even when the app was totally killed?
Thanks

Hey @asystat — thanks for reporting this "known issue". I would need some time to figure this out and write some code, which quite frankly, I don't have that time now. Hate to disappoint. However, if you have some to spare and Java coding skills, feel free to go ahead and move a PR — I would totally support and love to get it merged.
Thanks, sorry. Really.

@CentaurWarchief would you be interested in doing this as a paid job?

@beakshy Do you still need it? Maybe I can help.

@beakshy, Yes, Help me.


FEZ stick pinout

Not all pins are labeled on the silk. Document the missing pins

Fixed in PR #467


fatal error: cuda.h: No such file or directory

When running the training section of the readme i get an error regarding cuda.h. Is it possible to specify a path for the composer to look for the cuda support? I have cuda.h under ~/anaconda3/include/cuda.h and also have ~/anaconda3/include/cuda_runtime.h which some general stackoverflow articles recommended when running into issues with cuda.h.
What i'm running:
# Train an MPT-125m model for 10 batches
composer train/train.py \
  train/yamls/mpt/125m.yaml \
  data_local=my-copy-c4 \
  train_loader.dataset.split=train_small \
  eval_loader.dataset.split=val_small \
  max_duration=10ba \
  eval_interval=0 \
  save_folder=mpt-125m

The error i'm getting:
/tmp/tmpd3ybp9wv/main.c:2:10: fatal error: cuda.h: No such file or directory
    2 | #include "cuda.h"
      |          ^~~~~~~~
compilation terminated.

There is also a giant stack trace which i can include if that's useful.

This fixed the issue for me.
pip install xentropy-cuda-lib<EMAIL_ADDRESS>

This fixed the issue for me.
pip install xentropy-cuda-lib<EMAIL_ADDRESS>
Thanks, this solved my issue. I came across another issue once I got past the one I posted, but it was related to my local GPU being a 4090 which is apparently tied to Triton PTX (ptxas fatal   : Value 'sm_89' is not defined for option 'gpu-name'), which is obviously not tied to original issue I posted.
I reran the README.md on an A100 40g with the fix recommended from @P1ayer-1 and had no issues with the dataloader/training step.


disable path-marker rendering test

Background
Chrome 65 can't rendering out path-marker layer correctly, disable it for now.

Change List

Disable path-marker rendering test
use test-render-react cause the test-render has bug which allowed failed rendering test pass the full test set.

what's the issue? care to put up a screenshot?

Chrome 64

Chrome 65

@1chandu Not necessary for now, PathMarkerLayer is still under experimental-layers folder.


Use ImageBitmap in gltf reader when possible

This PR allows the GLTF reader to load textures using ImageBitmaps instead of HTMLImageElements when possible (ie. when createImageBitmap is available).
This should improve slightly the time spend in the glTexImage2D call in Firefox, and DecodeImage in Chromium based browser.
This PR changes several functions to allow the use of ImageBitmaps, including the TextureImageSource type and functions previously using CanvasOrImage type.

@DStradley Can you take a look at this PR and comment with any feedback?  Particularly in relation to your own earlier performance findings with very large textures.

@TitouanLeDuigou
Some questions from the team:

How are you measuring the performance gain?
What is the range of texture sizes you expect to get for reality models?  What texture sizes did you test with?

We observed that a proposed change similar to this caused a slowdown in loading very large textures (approaching 4K and up) for Firefox and iOS.
FYI @DStradley @pmconne

How are you measuring the performance gain?

To measure whether a change is an improvement or not, I compared the results of profiling in Firefox and Chrome in a reality model (Orlando and Philadelphia) while playing the same camera path, before and after applying the change.
I then looked at time spent in a time range (generally around 30 seconds) to check if the time spent in the most costly functions was reduced.
In this case, I was particularly interested in the glTexImage2D that represented around 8-9% of the script time in Firefox before the changes. After, it went down around 1.5%. I did not notice such changes with Chrome, but I have here noticed that the time spent in DecodeImage decreased significantly as well, by it is mitigated by a slight increase in the overall scripting time that I could not pinpoint.
I am aware this method is far from perfect even though it seems to provide decent indicators. If you have better techniques to measure efficiently performance gain or regression, I would be interested.

What is the range of texture sizes you expect to get for reality models? What texture sizes did you test with?

I tested with the reality models mentioned above. I think the texture size vary between 512 and 2048, being always a power of two.

We observed that a proposed change similar to this caused a slowdown in loading very large textures (approaching 4K and up) for Firefox and iOS.

During the modifications I did notice Firefox taking more time in glTexImage2D if using ImageBitmaps and rendering into a canvas before the call to loadTexture2DImageData (from 8% to 14% of script time, globally - I imagine it would get worse with bigger textures or textures that need to be resized). However, sending the ImageBitmap directly to loadTexture2DImageData (and therefor to glTexImage2D) had the opposite effect. I suspect Firefox being less efficient with handling canvas is the reason of this.
Maybe this was the reason of the slowdown you observed in this previous change?
I did not test with iOS, so I do not know whether it affects positively or negatively this platform. If needed, it is still possible to disable this feature in the gltf reader for mobiles.
Edit: it seems Firefox profiling results are different between Firefox 98 and 99. In the most recent version I am unable to reproduce the numbers I got on the profiles of the master branch.

I am aware this method is far from perfect even though it seems to provide decent indicators. If you have better techniques to measure efficiently performance gain or regression, I would be interested.

@DStradley do you remember offhand the method you used for measuring performance on the texture loading?  @TitouanLeDuigou was using built-in profiling.

I am aware this method is far from perfect even though it seems to provide decent indicators. If you have better techniques to measure efficiently performance gain or regression, I would be interested.

@DStradley do you remember offhand the method you used for measuring performance on the texture loading? @TitouanLeDuigou was using built-in profiling.

@TitouanLeDuigou If I recall, correctly @DStradley used standalone HTML / JavaScript files which contained very small unit tests which would load textures various ways to validate the time spent in the various methods, in order to precisely narrow it down.  He also used the regular timing routines in JavaScript itself.

@TitouanLeDuigou If I recall, correctly @DStradley used standalone HTML / JavaScript files which contained very small unit tests which would load textures various ways to validate the time spent in the various methods, in order to precisely narrow it down. He also used the regular timing routines in JavaScript itself.

This sounds like very useful tests. I would be interested to run them on this branch to compare with master if it is possible. Maybe avoiding using a canvas with ImageBitmaps when possible can impact positively the results?
Another point is that, currently, if the ImageBitmap is not at the correct dimension, we fallback to a canvas to resize it before calling glTexImage2D (which is not ideal). However, the createImageBitmap function call provides options to resize them at the bitmap creation, thus eliminating the need of the canvas trick. Sadly, it seems that this option is very recent (this year for Firefox desktop, no support for safari iOS, etc.) and I don't think we can rely on its support yet.
Here are some observations I made in the Firefox profiler. In master, it looks like this:

After the changes, it looks like this:

The time spent in glTexImage2D is heavily reduced, because the image decoding is done separately at the ImageBitmap creation.
It seems we are not really taking less time, but the image decoding part is being done asynchronously (the specs tell us it has to be done in parallel).
This sounds like a good idea to avoid blocking the thread while loading the textures, especially with reality models loading requiring many textures.

@TitouanLeDuigou
As far as timing goes:

We used standalone HTML / JavaScript samples which wrapped specific texture load logic in JavaScript timers.  See Date.now().
This timing is more accurate than the profiler, but there are precision and jitter issues.  The browser timing resolution is only 1 ms with a 2 ms jitter.  This is due to browsers purposely not providing high-accuracy timers (and purposely introducing jitter) in order to avoid certain kinds of attacks.
For async calls, the time spent waiting on the async needs to be included in the timing as well.
For things like createImageBitmap(), the browser can execute the call using a web worker.  If it does so, it will not show up in the normal profiler (there may be ways to profile web workers separately).
Takeaway:

Need to time code that takes enough time to run in order avoid the influence of the accuracy issues.
Alternatively, you can loop and time the total of many samples in a single timing loop.  Based on that number, you can determine your average.  This approach only works if your loop contains only the code you are interested in timing.

We observed:

createImageBitmap does not necessarily behave with an async benefit anywhere but Chromium (shows up in DOM when profiling on Firefox).
createImageBitmap performed poorly with 4K+ textures on Firefox, Safari, and iOS (basically anywhere non-Chromium).
There is difficulty in measuring performance gain on smaller textures (roughly 1Kx1K and under) because they load so quickly. The browser timing resolution is only 1 ms with a 2 ms jitter, and these textures loaded close to 2 ms.  For 2Kx2K textures, the timing was around 16 ms, which is more measurable.  We believe this is still large enough to slow down on non-Chromium browsers.

@pmconne @DStradley

@markschlosseratbentley @DStradley please review.

createImageBitmap performed poorly with 4K+ textures
We currently limit textures to max 4k.

The browser timing resolution is only 1 ms with a 2 ms jitter
This can now be bypassed using COOP or COEP headers.

For async calls, the time spent waiting on the async needs to be included
Only if we're awaiting and blocking the main thread until the read completes. If we're displaying a placeholder image for the texture until the async read completes, we don't care about the async time unless it's very large.

@markschlosseratbentley @DStradley please review.

createImageBitmap performed poorly with 4K+ textures

We currently limit textures to max 4k.

The browser timing resolution is only 1 ms with a 2 ms jitter

This can now be bypassed using COOP or COEP headers.

For async calls, the time spent waiting on the async needs to be included

Only if we're awaiting and blocking the main thread until the read completes. If we're displaying a placeholder image for the texture until the async read completes, we don't care about the async time unless it's very large. If the blocking time is small, overall page responsiveness should be improved.

@pmconne This all makes sense to me.  @DStradley ?

Superseded by #4010.


Disable next buttons once clicked on multi-step sign-up

The next step button could be accidentally double-clicked, disable it with JavaScript once it is clicked.

This was resolved with #288 thanks to @iafb