macOS High Sierra reports Continuity as working but I see no results.

Have you tried these steps? Yes.
Is there already an open topic for this issue? Not that I found
Please include the following information.

OS Version: macOS High Sierra 10.13 Developer Beta 4 (17A315), iOS 11 Developer Beta 4
Device model: 13-Inch Late 2011 MacBook Pro i7 (2640M), iPhone 7 (A1660)
Dongle or replaced card?: replacement card
Used dongle/card: BCM94331PCIEBT4CAX

Your Issue:
macOS reports Continuity as active but Instant HotSpot and Continuity do NOT work also Airdrop and MacID do work.

Steps done to try to fix the issue:
iCloud logout/login process on my MBP and iPhone 7 and waiting a few days (after logging back into iCloud on both devices) before trying the logout/login process. I have been using the High Sierra developer beta since release and have been patiently waiting for a couple weeks to see if it just starts working for me.
edit: updated macOS version

MacBook Late-2009 17A291m, iPod touch 6th gen iOS 11 DB2
Same here but AirDrop works.

Did HandOff, etc. work in this same hardware setup running

Sierra 10.12 (presumably, with CAT)?
El Capitan 10.11 (presumably, without CAT)?

@PeterHolbrook Yes everything has been working since Yosemite w/ the exact same setup.

Mac model: 13-Inch Late 2011 MacBook Pro i7 (2640M)
Dongle or replaced card?: replacement card
Used dongle/card: BCM94331PCIEBT4CAX

Looking at the output when running activate shows CAT is attempting to make it’s changes (kext backup and patching) within it’s sandboxed environment, which it sees as a read only filesystem. I don’t think it did this in Sierra.
Maybe apps can only access System resources through a sandbox in High Sierra, regardless of its GateKeeper status. High Sierra does make several changes to security including improved SIP and more stringent standards for non-Apple kexts so it’s entirely possible.

@croaker-1 anyway around this?

Hello to all:
I think this is a problem with High Sierra.
For example. In Sierra after activate CAT, must open FaceTime and log out and login to make work. That sometime was necessary for any Mac after a System update.
Now when sign out of FaceTime and sign in again do not ask for password. Then I think really is not login out.

Try to unpair and pair your iPhone

Well: After a lot try out nothing happens.
I logout and login iCloud from each application as I did in Sierra, but do not work.
Some people ask me why to migrate to High Sierra, and must tell is because the GPU better performance. Indeed the internal temperatures drop down 10ºC

hate to read you're having the same issue but i'm also glad i'm not the only person w/ the issue as well, more hope of a fix coming down the pipeline. . .

Hi,
Latest beta (public beta 7 I think)
Used card: BCM94331PCIEBT4CAX
MacBook Pro 15 i7 Early 2011
I disabled System Integrity Protection using Recovery and terminal "csrutil disable" then ran latest CAT and works without any issue for me between Iphone 7 PLUS (ios 10.3.3) and also between Ipad Mini 3 with ios 11

This bodes well for the future, for those of us with 2011 machines and who have bought the 4CAX wifi Extreme card: just the news I've been waiting for!
 Thanks for sharing and happy new month!
Sent from my iPad

On 1 Sep 2017, at 11:15, Doru Brad<EMAIL_ADDRESS>wrote:
Hi,
Latest beta (public beta 7 I think)
Used card: BCM94331PCIEBT4CAX
MacBook Pro 15 i7 Early 2011
I disabled System Integrity Protection using Recovery and terminal "csrutil disable" then ran latest CAT and works without any issue for me between Iphone 7 PLUS (ios 10.3.3) and also between Ipad Mini 3 with ios 11
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

No problem, I just updated so needed this test 👍

I do not know how 11digits can make work his MBP.
I have an early Mac Book Pro 17 2.2 GHz Intel Core i7 with the same BCM94331PCIEBT4CAX BT card installed.
Now I update to macOSx 10.13 Beta (17A358a) and nothing happens. And in my General Preferences Continuity appears OK

I will run CAT again and will notify if can make work

Something wrong happens. I deactivate CAT to being all again new. And return from recovery. Well...... Continuity keep active like my Mac is new???
I don't understand.

What can I say -- works for me:
See here my mode: https://screencast.com/t/thJdoA82
Did you do this? : I disabled System Integrity Protection using Recovery and terminal "csrutil disable"

Look: I deactivate CAT and can't find the original driver....

After that Startup in Recovery Mode and run csrutil disable.
Reboot to run CAT again but....

I think that is the problem.

Then:
There are some can help to find the original driver

After reinstalling all again. Running CAT and verify that Continuity is ON. NOTHING HAPPENS.

When you say "nothing happens" what do you refer to? Does handoff not work or airdrop? I used just airdrop ...

After upgrade to Beta 8 - run csrutil - run CAT.....
And you can see all is on:

Well: Call and iDrop works fine:

But continuity nothing happens.
And Handoff neither

I reset iCloud as I did before with Sierra, but do not work either

I have only installed High Sierra betas on a VMware Fusion virtual machine, but, naturally that will never let me check on Continuity/Handoff features. What fjdr describes reminds me of my experience with El Capitan and Sierra.
I purchased the Bcm94360cd BT/Wi-Fi module and installed it on my Mac Pro 5,1 (2010). As soon as I did that, I had full Continuity/Handoff functionality in El Capitan without doing anything else (no need whatsoever for CAT). However, when I upgraded to macOS Sierra, I immediately lost Instant Hotspot and Handoff. In addition, my Apple Watch would not bypass password entry, a newly added functionality in Sierra. Only months later did I learn the Apple had deliberately excluded the pairing of the Bcm94360cd and the Mac Pro 5,1 as being supported for such functions, but CAT was able to effect the magic, and it did very well indeed.
Now, the last picture DOES show the Instant Hotspot for fjdr's iPhone, which is a very GOOD sign. That handoff doesn't work for you right now is probably just a glitch. I suggest that you log out of iCloud both on your Mac and your iPhone, reboot both and log back in. It will probably work.
If your iPhone hadn't been listed as an Instant Hotspot Wi-Fi source, that would have been a bad sign and my advice would have been different.

Rethinking your situation, I think the appearance of your iPhone as a Wi-Fi source is not the automatic response of the Instant Hotspot function, but the result of your manual tweaking of a personal hotspot. So, it appears I was wrong. When you ran CAT in High Sierra, did it display any messages indicating the successful replacement of handoff kexts? Can you compare said kexts with their respective unmodified version in the backup directory probably created by CAT? They should be different.
In the worst-case scenario, do you have a backup copy of your CAT-modified Sierra handoff kexts? Substituting them for the current non-functional High Sierra ones might do the trick. In any case, be cautious. You might need to disable SIP and make sure you can boot your computer in case of system corruption.

Hello Peter:
I recover the kext files from TimeMachine when I ran Sierra ( when CAT works ). But doesn't work neither.
I force install of CAT. And if you can see, all appears OK. Maybe is another think that deny the Handoff access?

I don't know what to think. In my case, as soon as the Instant Hotspot issue was solved in Sierra (thanks to the CAT beta), handoff began working immediately. If I remember correctly, I didn't even have to reboot the computer.
Doble-check the following:

I suggest that you disable SIP until you solve this issue.
Are you sure you are using the latest beta of CAT. The stable, regular version, is known NOT to work on Sierra, so it might fail to work in High Sierra as well.

Well. I think all is wrong. When try uninstall CAT appears the river wasn't found on back up.

I will do manually to start up again

I only used CAT once, on one of the previous iterations of Sierra. I am presently running 10.12.6 with no issues.
I don't suppose this is significant, because other users reported running CAT on Sierra directly from a Finder window, but I couldn't do that. In my case, noble-clicking on the CAT icon did nothing. Because of that, I simply opened the application package and went to the relevant script, running it from Terminal. That's how it worked for me. But, as I say, others reported it worked for them in a simpler manner.

I don't know about uninstalling CAT. I've never tried it.

Dear Peter: Thanks for your assistance and do not worry. I repeat all the procedure and does not work.
Since I install HIGH SIERRA BETA Continuity/Handoff doesn't work. I think must be a kind of forbidden access to my Mac ( MacBookPro8,3 ).
Indeed when try to deactivate CAT, you may see in the last screenshot I sent, "Reinstalling original Apple Driver ------ NOT OK" is a odd thing that never happens before 10.13.
When have time to do this, I search what is the real difference between Sierra and High Sierra in Handoff. Maybe I must write in same resource file: Hardware detected..... MacBookPro8,3)
Best regards

Please, consider studying Czo's and my own contributions at https://forums.macrumors.com/threads/macos-high-sierra-10-13-unsupported-macs-thread.2048478/page-14. Therein I explain a theoretical way to make Handoff work in High Sierra even if CAT shouldn't work. Have a look at it. Naturally, you must find out how to "translate" my manual instructions for your case. My theoretical example applies to a Mac Pro 3,1 and a Mac Pro 5,1. The board id for a Mac Book Pro, et cetera, will be different, so you need that "translation", but my observations there might in theory solve your situation. Good luck.

Thanks: I must now find the next parameters to my MacBook Pro 8,3: or Where can find?
Mac-FC02E91DDD3FA6A4

DID ProductCode
18986
Immediate Proximity Threshold
-24
Max Proximity Threshold
-45
Proximity Threshold
-33

I am editing and add this:

Mac-942459F5819B171B

DID ProductCode
18982
Immediate Proximity Threshold
-40
Max Proximity Threshold
-50
Proximity Threshold
-45

It should be easier than all that. Editing /System/Library/Frameworks/IOBluetooth.framework/Versions/A/Resources/SystemParameters.plist ought to be trivial. You simply have to change the "ContinuitySupport" value (for your relevant case) to the boolean value "true".
As for /System/Library/Extensions/IO80211Family.kext/Contents/PlugIns/AirPortBrcm4360.kext/Contents/MacOS/AirPortBrcm4360, I think you simply need to follow Czo's advice in his message #335. So, put in a nutshell you need to run
sudo -E perl -pi -e "s/\Mac-00BE6ED71E35EB86/\Mac-F221BEC8\0\0\0\0\0\0\0\0/" /System/Library/Extensions/IO80211Family.kext/Contents/PlugIns/AirPortBrcm4360.kext/Contents/MacOS/AirPortBrcm4360
from the Terminal, replacing Mac-F221BEC8\0\0\0\0\0\0\0\0 with your computer's board id (presumably Mac-942459F5819B171B). If you aren't comfortable running such a command, you can also edit the relevant file using a Hex editor, but you need to be very careful. Changing one single wrong byte might be a disaster.
Once the kexts are modified and in place, you also need to delete the kext cache.

Dear Peter: I FINALLY RESOLVE THE ISSUE.
I went kext by kext associated to Bluetooth and Bradcom card, replace the numbers and voila!!

@PeterHolbrook this is exactly what CAT should be doing.
I currently do not have the beta installed, which is why I'm not really able to offer much support for it, I will however try to fix everything for high sierra as soon as it's out.
could someone please send me their CAT patched kext to<EMAIL_ADDRESS>for me to review?

@fjdr
Congratulations. When High Sierra is released I'll try and see what CAT does. If it doesn't work, at least we know how to solve the issue manually.

Sysfloat. I try several times to send my kext I modify thanks to Peter Holbrook. But the address appears do not exist.

@fjdr Very sorry about that I made a typo in the address.
<EMAIL_ADDRESS>

@sysfloat
Thank you. Excellent.

After some work....

Got everything working in the lastest (last) beta of HS (through the advice of fdjr and Peterholbrook), but one thing I've never gotten to work well with either HS or Sierra is the apple watch unlocking. The feature shows up and I can check the box. But always seem to get the dreaded 'unable to communicate' message when trying to activate it. Running a 2011 iMac with the necessary upgraded hardware. Signing in and out of iCloud and ticking and unticking boxes doesn't seem to work. Handoff, Instant Hotspot, Airdrop, etc. all work perfectly. Just this one little thing seems to be being difficult.
All the necessary stuff is checked and triple checked (same iCloud account, wi-fi, bluetooth, etc), anyone had any luck with this feature working consistently?

Hello Surtin: I haven't an Apple Watch to test with it. Sorry can't help.

@surtin: When I first upgraded my Mac Pro 5,1 to macOS Sierra, apart from losing Instant Hotspot and Handoff, I noticed that my brand-new Apple Watch Series 2 also failed to unlock the computer. "Unlocking" would take up to five minutes, but unlocking was never achieved. I also get that stuff about not being able to communicate with the watch, although it was on my wrist, less than one metre from the computer.
The situation solved itself, months later, after running CAT. I don't recall I had to do anything else.

Honestly it just started working randomly. Seems that part of continuity just needs a bit of random time and it starts working. Weird.

@surtin are you saying you managed to get Apple Watch unlock working on HS? I have 2 Mac minis, one mid 2011 which I have applied CAT to and handoff works but no tick box for unlock mack via apple watch & a 2012 Mac mini which should be supported which aslo does not have the tick box..? I was hoping this was a HS issue and devs would be able to fix it but I'm starting to think theres something more to it?

Yeah. Unlock with Apple watch has been working fine for me after initial hiccups.
On Sep 19, 2017, 12:17 PM -0500, nuvzzy<EMAIL_ADDRESS>wrote:

@surtin are you saying you managed to get Apple Watch unlock working on HS? I have 2 Mac minis, one mid 2011 which I have applied CAT to and handoff works but no tick box for unlock mack via apple watch & a 2012 Mac mini which should be supported which aslo does not have the tick box..? I was hoping this was a HS issue and devs would be able to fix it but I'm starting to think theres something more to it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@PeterHolbrook
Hi - I've had a similar experience as reported above so have 2 questions please:-

can patched CAT kext file be sent to me at<EMAIL_ADDRESS>please?
If not will CAT be updated to automatically perform what is required (besides disabling System Integrity Protection)?  If so when?

Appreciate any responses.

@jasare: The "CAT kext file" is not universal, meaning it is unlikely the one working for me will work for you. For instance, I have a Mac Pro 5,1 of 2010. If you have a Mac Mini, or a MacBook Air, or even a Mac Pro 5,1 of 2012, my kext file would do you no good.
Your best chance is in using CAT and hope for the best. I've just used it and, as it did in Sierra (for me and nobody else I'm aware of), it simply fails. It says my administrative password is a "wrong login". So, I simply run contitool.sh (inside the CAT package) from Terminal using sudo, and that works.
I can't tell you whether an updated version of CAT will appear. Sysfloat said one should appear shortly.

Same issue for me on a clean install of macOS High Sierra 10.13 on a Mac Pro 5,1, using a Broadcom BCM943602CDP.
When running CAT for the first time it says that Continuity is already active and then quits.

@sysfloat have you been able to make any progress on this? It would seem as though a few have gotten it working but most have not.
We're very grateful for you looking into this!

For those interested in fixing this problem by themselves, the solution is quite simple really, although people prone to clumsy errors should probably refrain from trying this, as failure to follow the instructions to the letter might cripple your Mac.
First of all, you should be certain that you have an up-to-date backup of your High Sierra disk and that you know how to use it in case something goes wrong. If you don't know how to restore from a backup, don't read any further.
Secondly, you should disable SIP, at least for the time being. Boot your Mac from the High Sierra Recovery Partition. Once booted, go to the Tools menu and open Terminal. Then, in Terminal, enter
csrutil disable
Reboot your Mac normally.
Next you need to find out your computer board id. It's different for every particular Mac model. For instance, my Mac board id is "Mac-F221BEC8" because it's a Mac Pro 5,1 of 2010. If it had been a Mac Pro 5,1 of 2012, its board id would be different. If you don't know yours, Google your specific model until you find two or three corroborating testimonies that what you find is, indeed, your computer board id.
So, repeating the explanation above that I posted 29 days ago, do the following:

Using TextEdit or a similar tool, open /System/Library/Frameworks/IOBluetooth.framework/Versions/A/Resources/SystemParameters.plist. You should see a list of board ids. Find the relevant entry for your model. Once found, you should see that it has one subelement called "ContinuitySupport". Presumably, it has the boolean value "false"; that should be changed to "true". Save the file.

Study this command (it's one single line):

sudo -E perl -pi -e "s/\Mac-00BE6ED71E35EB86/\Mac-F221BEC8\0\0\0\0\0\0\0\0/" /System/Library/Extensions/IO80211Family.kext/Contents/PlugIns/AirPortBrcm4360.kext/Contents/MacOS/AirPortBrcm4360
Notice that "F221BEC8\0\0\0\0\0\0\0\0" is the "short" board-id (excluding the "Mac-" part) of the Mac Pro 5,1 of 2010, followed by eight nulls, making up the 16 bytes used by the current "long" board ids. Now, edit the above line (for instance, using TextEdit) so that, instead of "F221BEC8\0\0\0\0\0\0\0\0" you paste whatever board id your computer has. If it is eight bytes long, remember to add the eight nulls. Now, double check that your modified line is the correct equivalent of the instruction above for your computer.

Open Terminal. Select your previously edited instruction of step 2 and drag it to your Terminal window. Press Enter. You'll be prompted to enter your administrative password. Do it.

Now you only need to delete the kext cache:
Enter this in Terminal:
cd /System/Library/Extensions/
sudo touch .

Boot your computer.

Instant Hotspot, Handoff, Universal Clipboard and Apple Watch Unlock should work. If they don't, your BT/Wi-Fi card might not be compatible with the hardware identified by the AirPortBrcm4360.kext. If there isn't a particular kext for your card, you may be out of luck.
Another explanation for the above procedure not to work might be that there's something wrong in your Apple ID data in your devices and/or in the relevant choices you make as to how Continuity/Handoff should work.
Lastly, chances are you might have done something wrong in following the above procedure. Repeat it slowly, just in case.

Wow thanks for that detailed step by step , ill give it ago & update if i get it working 😃

@PeterHolbrook You sir are awesome.
I just did this on my Mac Pro 5,1 2010 and it worked perfectly. Every single feature works, including Apple Watch unlock.
Thank you very much for the detailed guide!

i will give it a try as well wit my early 2011 Mac Book Pro 13"
Oh and the following command will give you the Board ID
sysctl hw.model | awk '{ print $2 }' ioreg -l | awk -F\" '/board-id/ { print $4 }'

Hey,
one question! Do I have to change only the bold Part of the Code to my MAC-ID or the italic one as well?
sudo -E perl -pi -e "s/\Mac-00BE6ED71E35EB86/\Mac-F221BEC8\0\0\0\0\0\0\0\0/" /System/Library/Extensions/IO80211Family.kext/Contents/PlugIns/AirPortBrcm4360.kext/Contents/MacOS/AirPortBrcm4360
Thanks!

Just the second one. The first one is one of the Apple-blessed board ids. The command simply substitutes the second board-id (your computer's) for the first one (a fully compatible, supported Mac). When High Sierra reads the relevant kext, it "learns" your computer is compatible and, all of a sudden, the Mac-00BE6ED71E35EB86 board-id sinks into oblivion.

Thanks, I will give it a try!

A cleaner command to check board id is:
ioreg -lp IOService | grep board-id
Also, this site seems to have every board id in existence:
https://github.com/upekkha/AppleHardwareTest
Finally, the Mac Pro 4,1 shares the same board id as the Mac Pro 5,1 it would seem.

Oh last question. My ID has 16 bytes. Do I have to put these ** between the last 6 digits? No thats just for the 8 byte numbers or?

Here is what I'm seeing when I search my board ID
Mac-031AEE4D24BFF0B1

Proximity Threshold
-40
Immediate Proximity Threshold
-30
Max Proximity Threshold
-50
DID ProductCode
18990
theres no "ContinuitySupport
"
Can I just add it?
Also when I try to save it says I do not own this file but can save a dupe, do I just then delete the older file? thanks

For me it went almost fine on my MacBook Pro.
When I wanted to delete the cache with ur command
cd /System/Library/Extensions/ sudo touch
it said something like no such directory.
Well Airdrop works now like a charm! But Handoff not.  -.-

@nuvzzy I think you need an Wificard with "ac"network for Apple Watch unlocking

@nixontira i was under the impression according to the compatibility chart that since my mac mini 2012 was a light green apple watch unlock would work with CAT? I did buy the suggested bluetooth usb dongle to test aswel

@nuvzzy:
My probably wrong understanding of the 16-bit entries in SystemParamenters.plist up to now was that they were Handoff-supported machines. Now that I come to think of it, they are probably a mixed bunch. Chances are that my explanation above about "ContinuitySupport" would work for them.
Provided you have a backup of your High Sierra installation, you might want to carry out this experiment:

Make sure you have some way to boot your computer externally or that your Recovery Partition is functional.
Save your current /System/Library/Frameworks/IOBluetooth.framework/Versions/A/Resources/SystemParameters.plist somewhere safe, like a pen drive.
Rewrite the entire entry of your board id (Mac-031AEE4D24BFF0B1) so that it looks like the one for a Mac Pro 5,1 of 2010 ("Mac-F221BEC8"), but leave "Mac-031AEE4D24BFF0B1" in place, not "Mac-F221BEC8", and set "ContinuitySupport" to "true". Save the file.
Proceed as above.
If your computer boots and Handoff, etc., work, we've been successful. Exit this procedure.
If your computer doesn't boot, this advice is wrong, and further study would be necessary. Cause your computer to boot from your external media or make it start from the Recovery Partition. I'll assume you're booting from the Recovery partition, that your pen drive is called MyPenDrive and that the saved version of SystemParameters.plist is at its root level.
Run Terminal and enter:
cd /System/Library/Frameworks/IOBluetooth.framework/Versions/A/Resources/
mv /Volumes/MyPenDrive/SystemParameters.plist .
Reboot. It should work, but the computer is in the original state and you'll need to study further. For instance, try to identify what Mac model of the 16-bit entries represents. Find out which of those models are certified by Apple as supporting Handoff in High Sierra and which aren't (presumably, yours isn't supposed to officially work with Handoff). See if you can identify any telltale differences between a  16-bit entry for a supported model and one for an unsupported model.  Reboot and see if that works.

@Nixontira:
Your syntax "cd /System/Library/Extensions/ sudo touch" is wrong. It's like this:
You first enter
cd /System/Library/Extensions/
Now you enter
sudo touch .
That should do it.

One important observation: The above detailed procedure is known to work with the Apple Broadcom Bcm94360cd - 802.11 A/B/G/N/AC + Bluetooth 4.0 card. There's no reason to think it might work with external USB dongles, unless they sported that particular card or something very, very similar.

Hi guys,
sorry for not updating you and the tool for such a long time.
I had a lot of work to do for the university and my exams and just hadn't had the time to work on it.
I finally installed High Sierra on my MacBook Pro 2011 today and fixed hopefully most of the tools issues.
There's also a new option to download legacy kexts which downloads a fresh version of the IO80211Family.kext and places it into the current directory if CAT. I intend to update cat further to allow the user this option as it provides an alternative way to obtain a clean kext in case the recovery partition does not work. The option currently only downloads the kext but doesn't install it yet. I will fully implement this feature after verifying the tool works on 10.13.
Why didn't CAT work on 10.13?
Well it actually did, kinda... All the patches are the same the only thing that was missing was actually applying them on 10.13. Some patches are only required for certain OS versions and since CAT didn't recognize 10.13 it didn't apply all patches needed for safety reasons.
This explains why you might got conflicting reading when running the diagnostics.
I made some changes which should allow CAT to complete any partial patches done previously.
TL;DR:
Updated CAT, should now work on 10.13, use the beta branch (2.6b1). Report any issues!
Huge thanks to @PeterHolbrook for trying to help users here, his steps are valid and should work most of the time. (Some further more complicated patches might be required for some mac configurations)

Hey,
I'm sorry for the "spam" but I would really like to enjoy CAT on my macbook pro mid 2010.
I've already created an issue but with no success.
I'm currently using OS High Sierra.
Can anyone please help me?
https://github.com/dokterdok/Continuity-Activation-Tool/issues/370

Sysfloat, I ran the new build a single time on my 5,1 and everything works. Handoff, Hotspot, apple watch unlock... Excellent!

@sysfloat
The manual way @PeterHolbrook said didn't work out for me. When I tried to use ur new branch of CAT it said me it's already activated. So I tried to safe back my old files of kext and the file in frameworks folder. But then Wifi stopped working completely... then I tried to use the new CAT tool to bring back the legacy files... well... the download worked, but after that it told me it couldn't copy the files to right direction... soooo I was kinda frustrated haha. Thats why I had to clean install HS again. After that I forgot to deactivate SIP, BUT actually the process of installing CAT worked fine! Even without deactivating SIP(I forgot deactivating it). The only thing I had to do after installing, was logging out of iCloud -->Reboot-->Logging back in. And everything works perfect now! THANKS @sysfloat
So two things I noticed that doesn't work properly yet are:

Kext Backup during CAT installation because of only reading Rights. (but I think u know about that problem?!)
Legacy download of Kext Files and copy process to final directory

Yep thats it... @sysfloat it would be cool, if you could describe what the CAT tool does different to the process @PeterHolbrook described. What files get edited, what commands are used... I like to know what happens behind those lil Programs :D
Again Thanks!

Actually I didn't deactivate SIP this on particular time, but had deactivated many times before in attempts to make the old builds work. Does SIP stay off?

@daze513 in the moment I wrote my comment I was thinking of the same thing. Will SIP stay deactivated even if I do a clean install?

@Nixontira Well SIP is part of the OS if I'm not mistaken, so if you reinstall, the state of SIP is the Fresh install state which is Activated.
Now I'm not sure if its persistent across multiple boots and stuff. I would think once you turn it off once it stays off but maybe someone can verify as I'm not sure.

Correct, your SIP configuration wil stay the same even when installing/upgrading/reinstalling macOS.
@Nixontira it shouldn't be necessary to reinstall macOS, I will try to update CAT to handle weird configurations and half way done patches better in the future.
I know about the rights issues, this will get fixed in the next version as well as the legacy kext feature.

I'm running macOS High Sierra and installed CAT 2.4b5 (which I used for macOS Sierra). When it didn't work, I read through here and found that there's a CAT 2.6b3 which I've downloaded.
When trying to uninstall the older version of CAT, I get this message:
Restoring kexts...                      OK. No backups made with the tool were found, using the OS X Recovery Disk backups.
Mounting Recovery HD...                 NOT OK. Error mounting 'Recovery HD'
If I simply just try to install CAT 2.6b3 over the old one, I get:
OS X reports Continuity as active.
How can I remove CAT 2.4b5 without having to reinstall macOS High Sierra from scratch?

@namster2k this should have been fixed by the new beta 2.6b4 released yesterday (3671006fe15a583902cce535d4950eca051b52c0)

@sysfloat I downloaded CAT 2.6b4 and ran the uninstall.

However I'm still unable to install CAT 2.6b4 as OSX reports Continuity as active.

Any suggestions?

@namster2k seems like apple does not include the IO80211Family.kext on the recovery partition anymore which is very odd.
The next update will allow you to download a clean version of the kext directly from apple and use that to restore.

Awesome, thanks a lot @sysfloat! I'm looking forward to the next update.
Thank you for all of your hard work!

I got board Mac-B809C3757DA9BB8D. Where do I find the parameters to add my info to the SystemParameters.plist?

I couldn't get this to work on my Mac Pro, I have the AirPortBrcmNI, so with the CAT tool it reports the card as not supported.  I followed Peter's procedure but changing for the other NIC and I still don't see personal hotspot, App Handoff and clipboard.  Airdrop works though.

I have a 2012 Mac Pro (model 5,1 - board ID F221BEC8) with the BCM94360CD + adapter properly installed about a year ago.  I never needed to run CAT under Sierra as I always had the correct wireless card according to the compatibility chart.   Continuity/Handoff/etc. was fully working up until around the last Sierra update (10.12.6).
Now Handoff is broken (no handoff either direction, no universal clipboard, no instant hotspot).   According to CAT diagnostics, everything is already working.   It's been weeks, and I tried every trick imaginable, zapped the PRAM, logging in/out of iCloud, rebooting in between logging out/in of iCloud, toggling Bluetooth, and reset the Bluetooth module via the advanced Bluetooth menu.
Can anyone here help me with this?  Can anyone confirm that this configuration should be working?  Or did something change now requiring CAT?  Thank you!

I used -f from commandline with latest version and then it worked.  I think 12.6 they changed the hardware that is allowed, now CAT is requied.

I used -f from commandline with latest version and then it worked. I think 12.6 they changed the hardware that is allowed, now CAT is requied.

In the SystemParameters.plist file, under my board ID, I see "false" under "ContinuitySupport"... that would confirm what you're saying, I guess?
Can you explain more about how to do -f from the command line?  Also, exactly which CAT version worked for you and for which OS?  Thanks!

Yes, as Peter reported its now changed to false or was added.
cd Continuity Activation Tool.app/Contents/Resources/
then sudo contitool.sh -f
I'm on High Serria 10.13.1, I have 4.1 flashed to 5.1

Mac-Pro:~ username$ cd /Applications/Utilities/Continuity\ Activation\ Tool.app/Contents/Resources/
Mac-Pro:Resources username$ sudo contitool.sh -f
Password:
sudo: contitool.sh: command not found

I'm getting a command not found error.   Not sure what I am doing wrong there.

@sysfloat I'm on a MacBookAir4,2 (Mid 2011) with macOS High Sierra 10.13.1 (17B1003). I forced reinstall CAT 2.6b6 but still Auto Unlock with Apple Watch doesn't work. You mentioned you would have added option to download clean version of kext directly from Apple: since CAT 2.6b6 doesn't give option to download kext for 10.13.1, is there a way to download them manually?
Also, CAT System Diagnostic says WARNING. Unknown Bluetooth features have been detected (code:11). This tool can try to fix this. even after force-reinstalling it: should I be worried about it?
Thank you and the rest of team behind CAT for all your hard work!

hi, I tried to install the beta actiation tool, on the system's report everything is ok, but air drop activated on everything as my iphone, my mac mini half 2011, does not find it.

Hi guys I was wondering if their will be an update for the High Sierra 10.13.6. I can get it to work but as soon as my computer goes to sleep or gets turned off. I loose the ability to use my WiFi. It doesn’t recognize the card and I have to re-install OS. I have done this now several times. I am hoping for an update to solve this issue. Can anyone help?? Thank you very much.

You must have some other problem causing that.  Beta branch of CAT works fine for me with High Sierra and new internal BT card in 2012 Mac Pro

Ya I have the proper internal card. I have high Sierra 10.13.6 and like I said. It works fine at first then all of sudden my WiFi card is no longer available like it’s not installed but as soon as I reinstall OS works perfectly fine without the Bluetooth 4.0 options. If I run the program again it will work but eventually do the same thing. I did see that it wasn’t tested for this version of OS when I was running the program so I am hoping and wondering if we can get an update on this.

Are you using Beta branch of CAT?   Otherwise, I’m telling you that it’s working for me so update not needed.  Must be something unique to your system because once you get it working, it makes no sense what happens next.

Yes using the beta. I used both. I also have to unlock the SIP in order to make it work. Then I lock it back. I did it without locking it and always the same result

I think you have a 2012 MacBook Pro is the difference. I have a 2011. Also I wonder if your using high Sierra 10.13.6 maybe you have a different version

I think you have a 2012 MacBook Pro is the difference.

I don't recall saying that I had a MacBook anything.
I have a 2012 Mac Pro.  (Model "MacPro5,1")
macOS 10.13.6 (17G5019)
You can't change any system level files with SIP locked.   However afterwards, keeping it locked or unlocked does not make any functional difference... it's just personal preference regarding system vulnerability at that point.
Since OS 10.12.6, the CAT GUI application would not apply any changes because it thinks Handoff/Continuity is already active;  CAT has to be forced via command line.
Also, you have to log out of iCloud, then REBOOT before logging back into iCloud.

Ok so maybe that’s what the problem is. Do I logout of iCloud before or after the CAT is run

Do I logout of iCloud before or after the CAT is run

Does not matter.  What matters is that you reboot before logging back into iCloud.

I have the same problem with fjdr. But I can't solute it.

airdrop is working
handoff and instant hotspot not working
I can't use TextEdit to change .plist
becoz I can't change edit permissions in this folder.
/System/Library/Frameworks/IOBluetooth.framework/Versions/A/Resources/SystemParameters.plist ought to be trivial. You simply have to change the "ContinuitySupport" value (for your relevant case) to the boolean value "true".

@ALL
MBP 17“ Late 2011
BCM94331PCIEBT4CAX
BD ROM included ACCS
16 GB RAM
SamSung SSD 480 GB
macOS 10.13.6
AirDrop:
disable SIP
CAT use normally
HandOff and others:
method with patch of IO80211Family.kext and change boolean in plist
Plist can be edited by TextEdit -> copy original file on Desktop (or somewhere else), edit normally and copy to original location edited plist - authorize admin and all is OK.
RESTART
Enable SIP
BOOT
Complete working https://support.apple.com/en-us/HT204681

@ALL
MBP 17“ Late 2011
BCM94331PCIEBT4CAX
BD ROM included ACCS
16 GB RAM
SamSung SSD 480 GB
macOS 10.13.6
AirDrop:
Log out of iCloud
Disable SIP from Recovery mode
Use the latest beta continuity Patcher
RESTART by script
HandOff and others:
this command in Terminal get your board number
ioreg -l | grep "board-id" | awk -F\" '{print $4}'
edit
/System/Library/Frameworks/IOBluetooth.framework/Versions/A/Resources/SystemParameters.plist
Look for your board yourID and change the Continuity flag under them to "true".
Plist can be edited by TextEdit -> copy original file on Desktop (or somewhere else), edit normally and copy to original location edited plist - authorize admin and all is OK.
Run these commands in Terminal
sudo -E perl -pi -e "s/\Mac-00BE6ED71E35EB86/\Mac-yourID/" /System/Library/Extensions/IO80211Family.kext/Contents/PlugIns/AirPortBrcm4360.kext/Contents/MacOS/AirPortBrcm4360
sudo -E perl -pi -e "s/\Mac-00BE6ED71E35EB86/\Mac-yourID/" /System/Library/Extensions/IO80211Family.kext/Contents/PlugIns/AirPortBrcmNIC.kext/Contents/MacOS/AirPortBrcmNIC
RESTART
Log into iCloud
RESTART
test functions
RESTART to Recovery mode
csrutil enable --without kext
BOOT
Complete working https://support.apple.com/en-us/HT204681
Note: All types of AirPort cards have same ID for replacing (00BE6ED71E35EB86)

Just to confirm, will this work with a Bluetooth 4.0 adapter? Or is this only for the AirPort replacements?
I want to try it, I see Continuity is True in the IOBluetooth.framework file, but while I can airdrop from my XS Max to my Mac, I can't the other way around. phone calls, those work, as do SMS and Messages, but none of the other features work, but they have sporadically in the past.

I tired this today, and after following all the instructions I could find, I thought I’d have another go at activation on my Mac Pro 5.1, last TIM it trashed my OS install & had to restore..
First I removed the connector to my existing on board Bluetooth adapter and installed my GMYLE .
I then rebooted removing SIP
I ran CAT system check, everything looked good
I Ran activation, it finished with a NOT OK backup failed for two files,
I pressed ok to reboot and it crashed halfway & got stuck in a reboot loop,
I finally got it to boot after a PRam reset but continuity isn’t working and WiFi hardware is missing, maybe disconnecting the existing Apple Bluetooth removes the wifi card too. Doh
Now I’m stuck trying to restore my system, if boot it with SIP off it crashes , if I PRam reset it switches back on SIP & I cant uninstall CAT..:(
Why did I bother...

@boomish the SIP configuration is stored in the NVRAM. So when you reset NVPRM, you need disable SIP in recovery again.
WiFi hardware is missing.
I used have same problem on my Macbook Air 2011 mid. If you can use wifi in recovery, it was problem with sip. Just try
"csrutil enable --without kext"in recovery, or "csrutil disable"
then nomal reboot, you will see wifi hardware.

@ALL
MBP 17“ Late 2011
BCM94331PCIEBT4CAX
BD ROM included ACCS
16 GB RAM
SamSung SSD 480 GB
macOS 10.13.6
AirDrop:
Log out of iCloud
Disable SIP from Recovery mode
Use the latest beta continuity Patcher
RESTART by script
HandOff and others:
this command in Terminal get your board number
ioreg -l | grep "board-id" | awk -F\" '{print $4}'
edit
/System/Library/Frameworks/IOBluetooth.framework/Versions/A/Resources/SystemParameters.plist
Look for your board yourID and change the Continuity flag under them to "true".
Plist can be edited by TextEdit -> copy original file on Desktop (or somewhere else), edit normally and copy to original location edited plist - authorize admin and all is OK.
Run these commands in Terminal
sudo -E perl -pi -e "s/\Mac-00BE6ED71E35EB86/\Mac-yourID/" /System/Library/Extensions/IO80211Family.kext/Contents/PlugIns/AirPortBrcm4360.kext/Contents/MacOS/AirPortBrcm4360
sudo -E perl -pi -e "s/\Mac-00BE6ED71E35EB86/\Mac-yourID/" /System/Library/Extensions/IO80211Family.kext/Contents/PlugIns/AirPortBrcmNIC.kext/Contents/MacOS/AirPortBrcmNIC
RESTART
Log into iCloud
RESTART
test functions
RESTART to Recovery mode
csrutil enable --without kext
BOOT
Complete working https://support.apple.com/en-us/HT204681
Note: All types of AirPort cards have same ID for replacing (00BE6ED71E35EB86)

Hi Community
I know it's an old story, but unfortunately I'm stuck. Handoff support is always off. I tried CAT which does not work for me.
I suspect that my Airport ID is wrong and I do not know how I can read it out. In the last posts is the number 00BE6ED71E35EB86
Where can I get this number?
Mac Pro 5.1
macOS High Sierra 10.13.6
Bluetooth Card: BCM943602CPDAX
Thanks for your help

Mac Pro 5.1
macOS High Sierra 10.13.6
Bluetooth Card: BCM943602CPDAX

I have a Mac Pro 5.1 with High Sierra and the upgraded Wifi card as per the chart...
https://github.com/dokterdok/Continuity-Activation-Tool/wiki/Compatibility
"BCM94360CD + adapter"
Everything is working here.   I had to use CAT but it only works for me as a terminal command with the -f flag set.

Mac Pro 5.1
macOS High Sierra 10.13.6
Bluetooth Card: BCM943602CPDAX

I have a Mac Pro 5.1 with High Sierra and the upgraded Wifi card as per the chart...
https://github.com/dokterdok/Continuity-Activation-Tool/wiki/Compatibility
"BCM94360CD + adapter"
Everything is working here. I had to use CAT but it only works for me as a terminal command with the -f flag set.
Quoting from my previous comment:

Since OS 10.12.6, the CAT GUI application would not apply any changes because it thinks Handoff/Continuity is already active; CAT has to be forced via command line.
Also, you have to log out of iCloud, then REBOOT before logging back into iCloud.

Hey Sparky
Now I've put the BCM94360CD in my Mac Pro and I can't connect to every bluetooth device.
How can i solve this..?


No package gitlab-runner-14.8.0 available

The agent was not starting correctly, I found this in the user-data logs:
No package gitlab-runner-14.8.0 available

It turns out, that package has been un-released due to a regression.

I am sorry for the noise, this was fixed in 4.41.1. I misread the latest version available.


add option noreverse

Add option --noreverse for cli reporter
This option check should we reverse failed steps output or not.

Sorry but what does reverse output mean? ;)

@DavertMik
Currently failure steps output is reversed:
e.g.
// test code
I.amOnPage('/');
I.see('blabla');

//failure output
We didn't receive message for order (1502852) with state ((order) => order._embedded.counterProposals[0].status === 'approved' && order.quantity === 2). Check additional context to see latest message for this order we receive

Scenario Steps:
// here is error message
...
// here is reversed steps output
- I.see("blabla") at Test.<anonymous> (tests/test.js:159:20)
- I.amOnPage("/") at Test.<anonymous> (test/test.js:158:20)

with --noreverse option steps output will be:
- I.amOnPage("/") at Test.<anonymous> (test/test.js:158:20)
- I.see("blabla") at Test.<anonymous> (tests/test.js:159:20)

Once I figure out how to update documentation to make this clear I will merge the PR 😄

I think this option has no big sense anymore as we have Allure reporter
Probably you should use it, and leave CLI reporter as simple as possible


Modify lobby configuration page to be as in the mock up instead of dropdown menu and allow for more options

701acaa


feat: Added logging module for logging to console/file

Also added test for the logging module and logging functionality in Model, Policy and Role Manager modules.

@rushitote plz merge commits:

@hsluoyz Done.


[ENH] Tidy up the utils directory

Describe the feature or idea you want to propose
there is a lot of old legacy code clutering up utils, this tidies it up. Some done by #1042
Describe your proposed solution

[x] slope_and_trend.py: two private methods, slope not used anywhere, trend only used in theta forecaster. Removes slope, moved private method and test to theta.py
[x] profiling.py: very simplistic method for time profiling a classifier. Not used or useful. Removed
datetime.py: method get_time_index is only used in transformations.collections.segmenter, but _coerce_duration_to_int is used all over, leave this one
[x] estimator_checks.py: single method called check_estimator that runs tests on a single estimator. Quite useful, but should probably be in the testing module. #1313
[x] mflow_aeon.py. "The mlflow_aeon module provides an MLflow API for aeon forecasters." See #968 #1285
[x] multiindex.py. Single function flatten_multiindex used in transformations and datatypes. leave
[x] sampling.py. stratified_resample used in benchmarking/experiments. Move there
[x] seasonality.py. autocorrelation_seasonality_test, used only in transformations.detrend.ConditionalDeasonalizer. Can move ther
[x] sklearn.py. Tests if a sklearn estimator. USed in the overloaded operators. Not going to mess with that atm
[x] stats.py. Weighting functions used in performance functions and forecasting ensemble. Rename?

Describe alternatives you've considered, if relevant
No response
Additional context
No response

Hi!
I would like to work on the sampling.py and seasonality.py files.

all done


[hotfix][table][api][unionAll] - Corrected unionAll operator doc

What is the purpose of the change

Corrected unionAll  doc

Brief change log

Corrected unionAll doc

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving):  no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector:  no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

@wuchong - Can you please review this PR ?  Thanks

Thanks @wuchong


simulator(dm): implement some core components

What problem does this PR solve?

Issue Number: ref #4835
What is changed and how it works?
Implemented some core components of the simulator:

modification candidate pool (MCP)
random SQL generator based on unique keys

Check List
Tests

Unit test

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change

Side effects

Increased code complexity

Related changes
N/A
Release note
None

/run-verify

Codecov Report

Merging #4838 (e7e2386) into master (9607554) will increase coverage by 0.2890%.
The diff coverage is 53.4869%.

Flag
Coverage Δ

cdc
59.7615% <53.4869%> (-0.1608%)
:arrow_down:

dm
52.8157% <ø> (+0.7868%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #4838        +/-   ##
================================================
+ Coverage   55.6402%   55.9292%   +0.2890%
================================================
  Files           494        525        +31
  Lines         61283      65109      +3826
================================================
+ Hits          34098      36415      +2317
- Misses        23750      25153      +1403
- Partials       3435       3541       +106

/run-verify

ping @dsdashun

What should we do about this PR @dsdashun

/merge

/hold
I think we can merge it after the v6.1 LTS release

/hold
I think we can merge it after the v6.1 LTS release

seems doesn't matter, this module is quite standalone

/unhold
just learned that code freeze for v6.1 is 5/19

/merge


Update minimum Python version to 3.8

We use typing.Protocol and other 3.8-only features extensively, so the min version should never have been 3.7.
Closes #31

Can't you just import from typing_extensions instead?

@kylebarron that's a good thought; I think there are other (minor) 3.8 features as well though. Quick audit from https://docs.python.org/3/whatsnew/3.8.html:

functools.lru_cache() can now be used as a straight decorator rather than as a function returning a decorator

https://github.com/gjoseph92/stackstac/blob/23f683f91253982d3ad059f21a2806785e9652f9/stackstac/prepare.py#L33

Added a new functools.cached_property() decorator, for computed properties cached for the life of the instance

https://github.com/gjoseph92/stackstac/blob/23f683f91253982d3ad059f21a2806785e9652f9/stackstac/raster_spec.py#L2

Other typing stuff:

A dictionary type with per-key types. See PEP 589 and typing.TypedDict.

Literal types. See PEP 586 and typing.Literal.

Protocol definitions. See PEP 544, typing.Protocol and typing.runtime_checkable().

I think it would definitely be possible to be 3.7-compatible though. If we hear from users that the lack of 3.7 support is an issue, then we definitely can look into it, but until I hear that I'd rather not prioritize it.


Change how we root all application libraries

When rootallapplicationassemblies is specified, we currently go over all assemblies passed to ILC as input or reference, find out which ones are not framework assemblies, and root all types in them so that they're available for arbitrary reflection at runtime.
The problem is that NuGet packages or SDKs can have many assemblies in them, but only some of them are actually used by user code. Good example is the Microsoft.WindowsDesktop.App SDK that has both WinForms and WPF in it.
With this change, we'll only root assemblies where we actually saw the app using something in them. This way a WinForms app will not include all of WPF.
With this, we could possibly regress apps that do Assembly.Load on an assembly that is otherwise unused. Those apps will have to use RD.XML. We could also add a simple data flow analysis for the simplest cases to avoid RD.XML if really needed.
ASP.NET still works without RD.XML for this.
Most of this commit is just mechanically moving stuff around.

Looks like we need to add xunit to CoreFX rd.xml.


Document creating an extension from scratch

Description
Initial work on documentation to create an extension from scratch.  Demonstrated the ability to create an index and add a document to it.
Issues Resolved
In support of #603
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #610 (212af84) into main (ebc684a) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff            @@
##               main     #610   +/-   ##
=========================================
  Coverage     63.97%   63.97%
  Complexity      244      244
=========================================
  Files            49       49
  Lines          1088     1088
  Branches         35       35
=========================================
  Hits            696      696
  Misses          381      381
  Partials         11       11

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Can we a better name for the file @dbwiddis? Something like CREATE_YOUR_FIRST_EXTENSION?


chore: import type testing assertions from 'tsd-lite' package

Hi, I am maintaining of the 'tsd-lite' package, which you are using for testing types (via 'jest-runner-tsd').
Just noticed that you are importing the type tests assertions from 'tsd'. It would be better to import from 'tsd-lite', because the assertions differ between the packages. (They are less buggy and more predictable in 'tsd-lite'.)
Also notice how many useless dependencies got removed.
The upcoming release of 'tsd-lite' will disallow importing from 'tsd'. So this is a quick maintenance PR to help you upgrade smoother.

Never mind.


convert text to Tensorflow records

Is there any code available to convert text to Tensorflow records in a format that the REALM code understands ?

https://github.com/google-research/language/blob/master/language/realm/generate_retrieval_corpus.py

https://github.com/google-research/language/blob/master/language/realm/generate_retrieval_corpus.py


Set RyuJit IL offsets for prolog and epilog.

Fix issue #270.
Repro case ( thanks Michal):
public static int Main(string[] args)
{ // breakpoint here works only with prolog symbol.
  {
    return 100;
  }
} // breakpoint here works only with epilog symbol.

RyuJit map from native to IL contains special symbols for Epilog, Prolog and NO_MAPPING.
PR supports Epilog and Prolog in CoreRT.

Some tests are failing with:

System.ArgumentException: An item with the same key has already been added. Key: 393
at System.ThrowHelper.ThrowAddingDuplicateWithKeyArgumentException(Object key)
at System.Collections.Generic.Dictionary`2.Insert(TKey key, TValue value, Boolean add)
at ILCompiler.DependencyAnalysis.ObjectWriter.BuildDebugLocInfoMap(ObjectNode node)

Also, take a look at the failing CoreCLR tests:
System.Diagnostics.Debug.Assert(Boolean condition, String message, String detailMessage)ILCompiler.DependencyAnalysis.ObjectWriter.BuildDebugLocInfoMap(ObjectNode node)

@dotnet-bot test Windows_NT Debug + CoreCLR tests

/cc @jashook @mmitche why did the OSX jobs start when windows was requested?

The CI machine deleted the CoreCLR tests zip file yesterday so the CI will fail as-is. I'm fixing it up; hang tight

Should be fixed - You can now rebase against master and push your changes again to pick up the fix

@dotnet-bot Test this please

The fix looks right, but sometimes we have wrong native offsets. I think a contract for the map [native offset,IL offset] is that all native offsets are unique. We have to check the contract and find why RyuJit generates wrong pMap.


Some tiny typo fixes and improvements

LGTM

Thanks for the feedback! By the way - the guideline document is very useful and a nice read!

:+1:

Big thank you for your contribution. :)

👍


Docker build failing on Linux (Xubuntu 16.04)

The instructions do not say to create a new directory called earth-analytics-binder, but in order to cd to it, I created it and copied environment.yml and Dockerfile into this new folder.
When running the provided command (docker build -t earthlab/earth-analytics .), the build seems to fail when trying to download repodata.json.bz2 file from https://repo.anaconda.com/pkgs/main/linux-64/.  I checked that the file exists, but it appears to have been updated today and may have an error.

oh @jlpalomino  this is another update. the repo used to be called earth-analytics-binder. so if you cloned the repo you'd have that dir. just last week - we renamed the repo to earth-analytics-python-env so please update the instructions to cd to that dir which a user will have after cloning the repo!

also it's interesting you needed the token and i didn't. can we try this again together so i can see please? also i think we renamed the docker image earth-analytics-python so there may be a few dated things here in the documentation. let's figure it out. Also @mbjoseph  may be able to help test on his linux machine.

when we sort it out you can submit a pr to update the docs!! i've assigned this to you.

Bah. As @jlpalomino noticed and @lwasser points out, out the docs are out of date :frowning_face:
The instructions to build the image should be:
cd earth-analytics-python-env
docker build -t earthlab/earth-analytics-python-env .

I can confirm that the URL generated substitutes the container ID for localhost. I have no idea why this is. But if we can fix it, that would be great. I posted something on Twitter tagging the Jupyter team and Docker but all I got was crickets. We could probably open an issue here to get help: https://github.com/jupyter/docker-stacks
We can always check the build status on Docker Hub here if we need to: https://hub.docker.com/r/earthlab/earth-analytics-python-env/builds/
We also might want to add these badges to the README to point to the automated build and get the status:

^ in markdown is [![Docker Automated build](https://img.shields.io/docker/automated/earthlab/earth-analytics-python-env.svg)](https://hub.docker.com/r/earthlab/earth-analytics-python-env/)

^ is [![Docker Build Status](https://img.shields.io/docker/build/earthlab/earth-analytics-python-env.svg)](https://hub.docker.com/r/earthlab/earth-analytics-python-env/)

🐐 baaaaaaaaah
thanks @mbjoseph  i can ask Tim about this too :) i'm curious about how that all works and sometimes a key is really not necessary anyway. @jlpalomino let's update, add the badges and such as max suggests above! it will be a good exercise for you to get used to our GH workflow :) i find each place i work is slightly different so good to practice for everyone! :)

To resolve this issue about the install itself, I will create a pull request to update the README.md, per the response by Max.
I'll create new issues for the URL generated by Docker (i.e. URL generated substitutes the container ID for localhost) in both earthlab/earth-analytics-python-env and jupyter/docker-stacks.

No need for a new issue on jupyter/docker-stacks. I found an existing issue on jupyter/docker-stacks (https://github.com/jupyter/docker-stacks/issues/642) that addresses this issue with the URL generated by Docker (i.e. URL generated substitutes the container ID for localhost), and it works.
docker run --hostname localhost -it -p 8888:8888 earthlab/earth-analytics-python-env
I'll create a new issue and pull request to update the README.md to update the command.


Test passes when run for the first time, but fails after that

File bin/fsevent_watch gets deleted after the first run, but never gets recreated .

this library is being deprecated in favor of a version that makes use of FFI, and so I am closing old issues as will-not-fix. rejoice in the fact that fsevent_watch in the new version will be purely ruby and entirely unused unless you need it for debugging. please be patient with me just a short while longer.


[issue-311] Copy Change - Guest Message Update

Remove the link icon from the guest room

Remove the link icon from the guest room

That's not a part of this PR. The PR updated the language with the Link requires the Link Icone with following format. "Invite [Link Icon]"


Golang update required, chmod +x on .sh, terraform s3 refactor

Terraform major version refactor. S3 bucket resource changes.
Chmod on all .sh files to +x
Golang was not fetching pakages and the version had to be updated to have it work.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks so much for your contribute. Most of the fixes in this PR has been fixed in the release v0.2.0.
I'm going to close this PR.
Feel free to reopen it if you think that something is missing.


Update linkliar to 2.0.0

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Additionally, if updating a cask:

[ ] If the sha256 changed but the version didn’t,
provide public confirmation by the developer: {{link}}

2.0.0 is tagged as "latest" but "beta", seems to encourage it to be used on sierra.


Poll for input as-needed from frontend, not just on vblank

Right now most frontends just do it in the event loop, waiting for v-blank.  Latency suffers from it and this is crappy for things like fighting games. It should be called whenever the register is read from, with caching to compensate for the fact games will be doing a lot of reads in succession to compensate for chatter in real hardware.

libcaca uses an events mechanism very similar to SDL, but I don't know if you can poll; in addition, its function for retrieval is very slow. I'll have a talk with the libcaca guys to see how we can best do this accurately.

I'll take it, for SDL and libcaca at least. Windows can already do this inheriently.


⚠ Anthelion has degraded performance

In ad83cd4, Anthelion ($ATH) experienced degraded performance:

HTTP code: 502
Response time: 2149 ms

Resolved: Anthelion performance has improved in c19b6fd after 411 days, 12 hours, 44 minutes.


Image upgrade

Hi, I can see that you a simple logo. What do you think about having an image upgrade (A banner for the GitHub project or any other graphics that your app would need).
I can sent you some drafts if you like. I`m thinking about some ideas, something with a nice question mark to give it a more stylish view to the project.
Let me know what do you think.

Thank your issue， it’s very nice！please send it to<EMAIL_ADDRESS>

This is a draft that I`m working on, let me know what do you think.

Thanks sir for such great banner! I like it~-v0v-

That's great, let me make the vectors to pull request that.

You can send it to<EMAIL_ADDRESS>thanks~


[BUG] API Docs not found

Describe the bug
Link to API docs fails to locate said docs.
To Reproduce
Click on the link for API docs in the README

It looks like pub.dev can't build the docs because it's using an "old" (stable) flutter version: https://pub.dev/documentation/photo_view/latest/log.txt


Roll to docker version 5: workflows, readmes

Ran ./scripts/helpers/roll_docker_version.sh -r="Updating" -v=5 but undid the changes in integrations/docker as those did not seem needed.
Updated roll script to support "no docker" option since this seems to be what we want.

What is the no-docker for?

KW32 requires code updates. Will not update yet.


removed unused cpu thingy line of code

ermmm, no its actually very used
take a look at line 68 and 69 of that same file just for example

ermmm, no its actually very used
take a look at line 68 and 69 of that same file just for example


Improve CID creation by using layer digest

Do not merge until impact has been verified with performance tests.


grpc.Errorf runs afoul of "go vet".

The go vet tool expects functions named "Errorf" to take a format string as a first argument. gRPC's version takes a codes.Code. Unfortunately, service implementations that use gRPC and go vet get bombarded with errors due to the perceived misuse of Errorf.
A solution would be to rename gRPC's Errorf function to something that doesn't collide with standard library expectations. Another solution would be to update go vet to probe the function signature that it's asserting and confirm that it matches expectations about format string placement.

Are you asking specifically about the Go implementation of gRPC?

This is an known issue. https://github.com/grpc/grpc-go/issues/90
On Fri, Jan 22, 2016 at 3:13 PM, Michael Lumish<EMAIL_ADDRESS>wrote:

Are you asking specifically about the Go implementation of gRPC?
—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/issues/4840#issuecomment-174083341.


[WIP] Solana: Memo field in transfer

Description
Solana: Support Memo field in transfer.  Fixes #1988

Optional Memo in (native) transfer
Optional Memo in token transfer

Testing instructions
Solana unit tests.
Types of changes

New feature (non-breaking change which adds functionality)

Checklist

[x] Prefix PR title with [WIP] if necessary.
[x] Add tests to cover changes as needed.
[x] Update documentation as needed.
[x] I have read the guidelines for adding a new blockchain
[x] If there is a related Issue, mention it in the description (e.g. Fixes #<issue_number> ).

Nice, can you also add optional reference pubkeys support too?

Sample real transfer transactions:
with memo:
https://solscan.io/tx/3j24Pr73djPxFuhTMj9r3CWedFzc8pxFsyh6VkCNmf1tc4HhhMAoFZ6yrya7qa5y2mCVMZcmjuTLvmcvWoLzmryj
with memo and 3 references:
https://solscan.io/tx/5EtBJaRc5kaUQLvCfrPCP2kosVUzg125sEmp74DWVN46wNZ22bPQHCaciKKd4AwELoUn3wmD3KYb8U8TsDQ6ZvT7


unknown field

root@k8s-master01:~/k8s-dra-driver# kubectl logs nvidia-dra-k8s-dra-driver-kubelet-plugin-6dwrr -n nvidia-dra
Defaulted container "plugin" out of: plugin, init (init)
W0723 10:45:38.823998       1 warnings.go:70] unknown field "spec.allocatableDevices[0].gpu.cudaDriverVersion"
W0723 10:45:38.824041       1 warnings.go:70] unknown field "spec.allocatableDevices[0].gpu.driverVersion"
I0723 10:45:38.838612       1 device_state.go:146] using devRoot=/driver-root
W0723 10:45:38.841493       1 warnings.go:70] unknown field "spec.allocatableDevices[0].gpu.cudaDriverVersion"
W0723 10:45:38.841507       1 warnings.go:70] unknown field "spec.allocatableDevices[0].gpu.driverVersion"
W0723 10:45:38.845637       1 warnings.go:70] unknown field "spec.allocatableDevices[0].gpu.cudaDriverVersion"
W0723 10:45:38.845649       1 warnings.go:70] unknown field "spec.allocatableDevices[0].gpu.driverVersion"

This means you didn't rebuild / reinstall your CRDs after updating the code base from an earlier release.


font-family fallback fonts not respected -- default font used if first one not found

The font-family CSS definition can list a few fonts.  The browser is supposed to "select the first font on the list that is installed on the computer"
I've noticed that when the first font can't be loaded, none of the fallback fonts are attempted either.  Possibly related to #10592 ("Web Fonts do not render, use fallback fonts instead"), but that one seems to be focused on webfont support whereas this issue is pointing out that phantom is not doing what it should on a font-family CSS definition, regardless of webfont or not.
Reproduced on ubuntu and os-x using Phantom 1.9.7.
REPRODUCE:

Make sure you have a unique font installed, for example the beautiful and open Gentium

On ubuntu, verify it's installed with $ fc-list | grep -i gentium

Create a demo HTML file with a font-family list to rasterize with phantom:

phantom-no-fallback-demo.html

   <title>Testing Phantom Font Support</title>

Default font @ 36.  Next line Gentium.

      The Quick Brown Fox Jumped Over the Lazy Dog

<PHONE_NUMBER>

      ABCDEFGHIJKLMNOPQRSTUVWXYZ

      abcdefghijklmnopqrstuvwxyz

phantom-no-fallback-demo.js:
var system = require("system"),
    page = require("webpage").create();

page.viewportSize = {
  width:  1000,
  height: 100
};

page.open("./phantom-no-fallback-demo.html", function(status) {
    if ("fail" == status) {
        console.log("error Cannot load service page.");
    } else {
        page.render("font-test.png");
        console.log("Screen grab success.  Look for 'font-test.png' to see output.");
    }
    phantom.exit();
});

Run the script: $ phantomjs phantom-no-fallback-demo.js and look at font-test.png

EXPECTED:

Phantom should have fallen back to the second font in the font-family list (Gentium in this example)
In Chrome, it looks as expected:

ACTUAL:

Phantom just uses a default font after it can't find the first one:

If you change the .family-with-fallback definition to make Gentium or whatever the first font in your list, it works:

Conclusion is that phantom only tries the first font-family item instead of falling back across the entire list.

+1
getting the same problem

+1

+1

This still exists, I've tried to include Source Han Sans and it doesn't work properly.
For example if the font family is:
font-family: 'Titillium Web,source-han-sans-simplified-c,sans-serif'

it works fine on the browser, in phantomjs it doesn't, if I use instead
font-family: 'source-han-sans-simplified-c'

it works fine on phantomjs too

+1
and I partially solved this problem installing the font in Linux under /usr/share/fonts/truetype/font-name/file.ttf and cleaning up cache with fc-cache -fv

+1
I am using a custom font that covers a specific letters cases, and need the fallback font to be used with other cases.


Parameter types more

This is a reference PR for that PR #12.

Sorry, I missed this PR at first because I did not get a notification


CSVLogger does not work

Hi, I would like to log the experiments on local only, so I changed the logger to CSVLogger in the lasaft/trainer.py:
log = args['log']
    if log == 'False':
        args['logger'] = False
    elif log == 'wandb':
        args['logger'] = WandbLogger(project='lasaft_exp', tags=[model_name], offline=False, name=run_id)
        args['logger'].log_hyperparams(model.hparams)
        args['logger'].watch(model, log='all')
    elif log == 'tensorboard':
        raise NotImplementedError
    else:
        args['logger'] = True  # default
        default_log_path = os.path.join(ckpt_path,'lightning_logs')
        args['logger'] = CSVLogger(default_log_path, version='0')
        mkdir_if_not_exists(default_log_path)

I also set progress_bar_refresh_rate = 0, then when I run main.py, it shows the error:
Traceback (most recent call last):
  File "/opt/conda/envs/lasaft/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 644, in run_train
    self.train_loop.run_training_epoch()
  File "/opt/conda/envs/lasaft/lib/python3.8/site-packages/pytorch_lightning/trainer/training_loop.py", line 564, in run_training_epoch
    self.trainer.run_evaluation(on_epoch=True)
  File "/opt/conda/envs/lasaft/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 758, in run_evaluation
    self.evaluation_loop.on_evaluation_end()
  File "/opt/conda/envs/lasaft/lib/python3.8/site-packages/pytorch_lightning/trainer/evaluation_loop.py", line 100, in on_evaluation_end
    self.trainer.call_hook('on_validation_end', *args, **kwargs)
  File "/opt/conda/envs/lasaft/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1101, in call_hook
    trainer_hook(*args, **kwargs)
  File "/opt/conda/envs/lasaft/lib/python3.8/site-packages/pytorch_lightning/trainer/callback_hook.py", line 183, in on_validation_end
    callback.on_validation_end(self, self.lightning_module)
  File "/opt/conda/envs/lasaft/lib/python3.8/site-packages/pytorch_lightning/callbacks/model_checkpoint.py", line 212, in on_validation_end
    self.save_checkpoint(trainer, pl_module)
  File "/opt/conda/envs/lasaft/lib/python3.8/site-packages/pytorch_lightning/callbacks/model_checkpoint.py", line 259, in save_checkpoint
    self._save_top_k_checkpoints(trainer, pl_module, monitor_candidates)
  File "/opt/conda/envs/lasaft/lib/python3.8/site-packages/pytorch_lightning/callbacks/model_checkpoint.py", line 566, in _save_top_k_checkpoints
    self._update_best_and_save(current, epoch, step, trainer, pl_module, metrics)
  File "/opt/conda/envs/lasaft/lib/python3.8/site-packages/pytorch_lightning/callbacks/model_checkpoint.py", line 608, in _update_best_and_save
    self._save_model(filepath, trainer, pl_module)
  File "/opt/conda/envs/lasaft/lib/python3.8/site-packages/pytorch_lightning/callbacks/model_checkpoint.py", line 335, in _save_model
    self.save_function(filepath, self.save_weights_only)
  File "/opt/conda/envs/lasaft/lib/python3.8/site-packages/pytorch_lightning/trainer/properties.py", line 327, in save_checkpoint
    self.checkpoint_connector.save_checkpoint(filepath, weights_only)
  File "/opt/conda/envs/lasaft/lib/python3.8/site-packages/pytorch_lightning/trainer/connectors/checkpoint_connector.py", line 408, in save_checkpoint
    atomic_save(checkpoint, filepath)
  File "/opt/conda/envs/lasaft/lib/python3.8/site-packages/pytorch_lightning/utilities/cloud_io.py", line 63, in atomic_save
    torch.save(checkpoint, bytesbuffer)
  File "/opt/conda/envs/lasaft/lib/python3.8/site-packages/torch/serialization.py", line 372, in save
    _save(obj, opened_zipfile, pickle_module, pickle_protocol)
  File "/opt/conda/envs/lasaft/lib/python3.8/site-packages/torch/serialization.py", line 476, in _save
    pickler.dump(obj)
TypeError: cannot pickle '_csv.writer' object

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "main.py", line 60, in <module>
    trainer.train(parser.parse_args(), hp)
  File "/home/feitao/Projects/music_unmix/lasaft/lasaft/source_separation/conditioned/scripts/trainer.py", line 177, in train
    trainer.fit(model, training_dataloader, validation_dataloader)
  File "/opt/conda/envs/lasaft/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 513, in fit
    self.dispatch()
  File "/opt/conda/envs/lasaft/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 553, in dispatch
    self.accelerator.start_training(self)
  File "/opt/conda/envs/lasaft/lib/python3.8/site-packages/pytorch_lightning/accelerators/accelerator.py", line 74, in start_training
    self.training_type_plugin.start_training(trainer)
  File "/opt/conda/envs/lasaft/lib/python3.8/site-packages/pytorch_lightning/plugins/training_type/training_type_plugin.py", line 111, in start_training
    self._results = trainer.run_train()
  File "/opt/conda/envs/lasaft/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 676, in run_train
    self.train_loop.on_train_end()
  File "/opt/conda/envs/lasaft/lib/python3.8/site-packages/pytorch_lightning/trainer/training_loop.py", line 134, in on_train_end
    self.check_checkpoint_callback(should_update=True, is_last=True)
  File "/opt/conda/envs/lasaft/lib/python3.8/site-packages/pytorch_lightning/trainer/training_loop.py", line 164, in check_checkpoint_callback
    cb.on_validation_end(self.trainer, model)
  File "/opt/conda/envs/lasaft/lib/python3.8/site-packages/pytorch_lightning/callbacks/model_checkpoint.py", line 212, in on_validation_end
    self.save_checkpoint(trainer, pl_module)
  File "/opt/conda/envs/lasaft/lib/python3.8/site-packages/pytorch_lightning/callbacks/model_checkpoint.py", line 259, in save_checkpoint
    self._save_top_k_checkpoints(trainer, pl_module, monitor_candidates)
  File "/opt/conda/envs/lasaft/lib/python3.8/site-packages/pytorch_lightning/callbacks/model_checkpoint.py", line 566, in _save_top_k_checkpoints
    self._update_best_and_save(current, epoch, step, trainer, pl_module, metrics)
  File "/opt/conda/envs/lasaft/lib/python3.8/site-packages/pytorch_lightning/callbacks/model_checkpoint.py", line 608, in _update_best_and_save
    self._save_model(filepath, trainer, pl_module)
  File "/opt/conda/envs/lasaft/lib/python3.8/site-packages/pytorch_lightning/callbacks/model_checkpoint.py", line 335, in _save_model
    self.save_function(filepath, self.save_weights_only)
  File "/opt/conda/envs/lasaft/lib/python3.8/site-packages/pytorch_lightning/trainer/properties.py", line 327, in save_checkpoint
    self.checkpoint_connector.save_checkpoint(filepath, weights_only)
  File "/opt/conda/envs/lasaft/lib/python3.8/site-packages/pytorch_lightning/trainer/connectors/checkpoint_connector.py", line 408, in save_checkpoint
    atomic_save(checkpoint, filepath)
  File "/opt/conda/envs/lasaft/lib/python3.8/site-packages/pytorch_lightning/utilities/cloud_io.py", line 63, in atomic_save
    torch.save(checkpoint, bytesbuffer)
  File "/opt/conda/envs/lasaft/lib/python3.8/site-packages/torch/serialization.py", line 372, in save
    _save(obj, opened_zipfile, pickle_module, pickle_protocol)
  File "/opt/conda/envs/lasaft/lib/python3.8/site-packages/torch/serialization.py", line 476, in _save
    pickler.dump(obj)
TypeError: cannot pickle '_csv.writer' object

I found if I don't use any logger, say only use:
log = args['log']
    if log == 'False':
        args['logger'] = False
    elif log == 'wandb':
        args['logger'] = WandbLogger(project='lasaft_exp', tags=[model_name], offline=False, name=run_id)
        args['logger'].log_hyperparams(model.hparams)
        args['logger'].watch(model, log='all')
    elif log == 'tensorboard':
        raise NotImplementedError
    else:
        args['logger'] = True  # default
        #default_log_path = os.path.join(ckpt_path,'lightning_logs')
        #args['logger'] = CSVLogger(default_log_path, version='0')
        #mkdir_if_not_exists(default_log_path)

Then the code works perfectly (except that I cannot track the loss). Can anyone help? Thank you.

hi @sun-peach,
I think it is a version issue.
I added lines for the csv logger (see https://github.com/ws-choi/Conditioned-Source-Separation-LaSAFT/commit/556904c506124f89d074d14c4b336b3d62070152).
I checked that it works fine for training.
Please check the version of each library.
Especially, check versions of the following libraries.
pytorch-lightning==1.1.6
torch==1.7.1


docs(belt): update Option-module docs

Hey all! Love all your work on this!!
I copied over everything from https://bucklescript.github.io/bucklescript/api/Belt_Option.html, and added a few examples.
Currently, I've added:
**Usage**
...
**Examples**

To all functions, it'd be nice if these could be anchor-links for easy sharing. But might be something for the future. 🙂
Let me know if there's anything that needs changing!
Closes #3

Looking good! 🎉
@lessp I agree with the anchors, we need to refine our md extraction / rendering process a little bit before we can do that, on the other hand, we have anchor links for function names already, so this should be good enough for now :-)
I wonder if usage is redundant (since we have examples as well), but let's experiment here!

This is fantastic! Thanks @lessp

@ryyppy I was thinking about Usage redundancy and it makes docs really hard to follow.
For me, one of the best examples is Elm package docs. For example: https://package.elm-lang.org/packages/rtfeldman/elm-css/latest/Css#batch where first you have type signature and then detailed explanation with usage examples

@baransu Yeah, we are currently figuring out the semantic structure of the markdown. There are some limitations we hit with our current setup, since we don't have access to the raw data of the type signatures. We will get there until we found a good way to access odoc data as JSON in a way we need it!


gnu(21840)=8254

Please check that you provide the following details when submitting new values of Gnu(n):

[x] Version of GAP and critical packages: GrpConst, Cubefree, etc.
[x] Brief description of the computer used for the calculation (operating system, processor, RAM)
[x] Runtime required for the calculation
[x] GAP commands used for the calculation
[x] Confirm that the output r of ConstructAllGroups is a list of groups (ForAll(r,IsGroup) should return true), otherwise confirm that if the output contained lists of groups, then those groups were also shown to be pairwise non-isomorphic.

gnu(21840)=8254
GAP      4.8.4
GrpConst 2.5
Runtime: 43227174 ms (12.01 hrs)
Isomorphic groups eliminated
To maintainers: for new results, add to data/gnudata.g this line:
GNU_SAVE( 21840, 8254, WITH_GC );

Calculations performed in a virtual machine running Ubuntu 64 bit, , with 1997mb ram.
Gap commands used: r:=GnuByConstructAllGroups(21840);;
( ForAll(r.result,g->IsGroup(g));  returns true.)

Thank you for submitting new gnu(n). We will recalculate it and add to the database if we get the same result.
Checklist for the reviewer:

[ ] checked and assigned labels "new (n<50000)" or "recomputation", if needed
[ ] set "replication needed" label (unless it starts immediately)
[ ] changed it to "replication in progress" label when the replication has been started
[ ] changed it to "replicated" after successful replication review
[ ] reproducible value of gnu(n)
[ ] no essential runtime differences
[ ] sufficient level of technical details

Checklist for the maintainer:

[ ] correct arguments of command to store data
[ ] correct location of new line in the data file
[ ] mention submitter and reviewer in the commit message
[ ] Close corresponding issue from the commit message

gnu(21840)=8254
GAP      4.8.4
GrpConst 2.5
Runtime: 45828306 ms (12.73 hrs)
Isomorphic groups eliminated
Replicated by @alex-konovalov on Ubuntu 16.04 on Azure cloud standard DS13 v2 instance (8 cores, 56 GB memory)
To maintainers: for new results, add to data/gnudata.g this line:
GNU_SAVE( 21840, 8254, WITH_GC );


Image and tag names not displayed correctly when registry host[:port] present

I have service containers deployed in swarm-mode from images tagged with the registry host and port, e.g.:  registry.local:5000/vote:v1.   I want to display then using docker-swarm-visualizer for a demo but they appear incorrectly.
Expected image name:  (Option 1) vote or  (Option 2) registry.local:5000/vote
(Not too fussed which option)
Expected image tag: v1
Actual image name: registry.local
Actual image tag: 5000/vote
I was playing around to see how this could be done and found this regex works for Option 1:
let imageNameRegex = /([^/]+?)(\:([^/]+))?$/

The image name and tag can be retrieved like so:
let imageName = imageNameMatches[1]
let tagName = imageNameMatches[3]

This works for these possible combinations:

registry.local:5000/vote:v1
registry.local/vote:v1
registry.local/vote
vote:v1
vote

You might be able to think of a nicer regex.
I can submit a pull request if you think its a good idea.

+1, I wanted to solve this myself, but I see you already made a PR. I'd love to see this merged @ManoMarks.

Merged


Fixes NaN Error in Render

Currently if render is called with curr = 0 and total = 0 it evaluates as 0/0 = NaN which causes cascading type errors in the function.
This patch adds a 0 value for ratio if it currently not calculable, preventing additional errors.

This is a clever solution, but I am not sure if this is the direction we should take.  I am more inclined to say that an error should be thrown if 0 is passed as total.  I am not sure why anyone would want to pass 0 anyway.

@thebigredgeek it would be nice to be able to populate the total later as sometimes you dont know it upfront.
Might be nice to have the progress bar support an unknown mode similar to how chrome does when you dont get a content-length with your download.

Hmm yeah I can see your point, but I don't know if this change accomplishes that :(.  The API would need to be drastically changed to accommodate such functionality... it would need to be able to consume lazy evaluations rather than simple static properties.


Add function to get bytes per pixel from image format

I want to add function to get bytes per pixel from image format.
That idea was provide by @Brent-A during this discussion.
Is your feature request related to a problem? Please describe.

It is useful when specifying stride bytes in k4a_image_create() or k4a::image::create().
// Before
k4a::image output_image = k4a::image::create(source_image.get_format(),
                                             output_width,
                                             output_height,
                                             output_width * 4 * static_cast<int32_t>(sizeof(uint8_t)));

// After
const int32_t bytes_per_pixel = k4a_get_pixel_size_from_image_format(source_image.get_format());
k4a::image output_image = k4a::image::create(source_image.get_format(),
                                             output_width,
                                             output_height,
                                             output_width * bytes_per_pixel);

Describe the solution you'd like

Add function to get bytes per pixel from image format.
K4A_EXPORT int32_t k4a_get_pixel_size_from_image_format(k4a_image_format_t format);

int32_t k4a_get_pixel_size_from_image_format(k4a_image_format_t format)
{
    switch (format)
    {
    case K4A_IMAGE_FORMAT_COLOR_BGRA32:
        return (int32_t)sizeof(uint8_t) * 4;
    case K4A_IMAGE_FORMAT_DEPTH16:
    case K4A_IMAGE_FORMAT_IR16:
        return (int32_t)sizeof(uint16_t);
    case K4A_IMAGE_FORMAT_CUSTOM8:
        return (int32_t)sizeof(int8_t);
    case K4A_IMAGE_FORMAT_CUSTOM16:
        return (int32_t)sizeof(int16_t);
    case K4A_IMAGE_FORMAT_CUSTOM:
        return (int32_t)sizeof(int16_t) * 3;
    default:
        return -1;
    }
}

Describe alternatives you've considered

The function returns bytes per pixel by input image format.
Additional context

Here are some example locations where this type of functionality might be useful. It's worth reviewing these to evaluate how well a solution will work for the various callers.

rgbz.c
image.c
Image.cs
matroska_read.cpp
matroska_write.cpp
mfcamerareader.cpp
uvc_camerareader.cpp
k4a.hpp

Some trends I see:

Most call sights are only interested in a subset of the image formats (e.g. they only really deal in CUSTOM* or in BGRA or they explicitly don't deal with MJPEG).
NV12 is a complicated case where "pixel size" doesn't always get the desired result
YUY2 is another case where "pixel size" is awkward.

Design considerations:

K4A_IMAGE_FORMAT_CUSTOM's pixel size is undefined. It's 6 bytes for the point cloud generation, but that format is left open to interpretation for other arbitrary user data types. It might be better to create a new K4A_IMAGE_FORMAT_POINT_CLOUD to be explicit since we've trended toward more specialized format codes that we originally expected.
This is also a bit related to issue #40. We have a few cases where it would be useful to have programmatic metadata about enum types rather than just the documentation. If we add new APIs for getting metadata on enum types they should be consistent.
Should pixels sizes be assumed to be multiples of bytes? (e.g. is there a potential for 12 bit pixels) Stride is defined in bytes since it ensures byte alignment of lines, but pixels formats can be somewhat arbitrarily packed. In YUY2 for example, being more akin to average pixel size.

Some alternatives to consider:

A function that returns minimum stride given a pixel format and a width?
modify k4a_image_create to accept 0 as the stride parameter and automatically allocate an appropriate minimum stride for formats that it can be done with?

Related issue #587. This was a case where stride/pixel size/buffer size were being interpreted incorrectly.

It might be better to create a new K4A_IMAGE_FORMAT_POINT_CLOUD to be explicit since we've trended toward more specialized format codes that we originally expected.

I agree. I think it make clarify purpose of k4a::image than K4A_IMAGE_FORMAT_CUSTOM.

Should pixels sizes be assumed to be multiples of bytes?
A function that returns minimum stride given a pixel format and a width?

It makes sense. It is fit with this purpose.

Here are some example locations where this type of functionality might be useful. It's worth reviewing these to evaluate how well a solution will work for the various callers.

Thank you for your research. The API that provides stride seems useful in many case.

I'm thinking that just modifying k4a_image_create to succeed when you pass in a zero stride might be the simplest. In most cases the stride is being calculated just to satisfy the argument to k4a_image_create anyhow.


Create Blog “career-advice-for-success-in-the-gulf-job-market”

Automatically generated by Netlify CMS

👷 Deploy Preview for sukumaran processing.

Name
Link

🔨 Latest commit
e2660eb8c3d263c318076bdc856007b01fd87e72

🔍 Latest deploy log
https://app.netlify.com/sites/sukumaran/deploys/64bc96037cba3200086e98d5


Brackets Sprint-43 Conflict with ReadAsText:

I'm probably titling this wrong, but what I am trying to explain is that with the most recent update brackets develops internal errors for me when the Themes extension is enabled. Mainly (from the browser Developer Tools).

I'm not sure if this is a brackets issue, (I don't think it is theme-dependent, as it also occurred above with the main theme), and functionally everything still seems to work, just more of a concern than anything.
Thank you though, the extension is wonderful otherwise, I am glad to have it!

Sounds great, good luck!

@jtflynnz i never got to digging into this issue because I stopped seeing at some point. please let me know if you still this issue.

No, this no longer seems to pop up with the latest version of Brackets (1.2), so it must have been something with the version at the time. Thanks for checking back though!


Only require needed submodules from 'unicode_utils'

Requiring 'unicode_utils' is pretty slow, and for short scripts it can have a noticeable impact on startup times. See lang/unicode_utils#6
As far as I can see, tty-table only uses display_width, and nothing else from the library. Simply changing require 'unicode_utils' to require 'unicode_utils/display_width' reduced the startup times for the scripts I tested on my linux laptop by roughly 100ms.

Coverage decreased (-0.09%) to 97.647% when pulling fa2791fb869efdf5f756f714f5607ac965b8d6cc on huyderman:partial_unicode_utils into adf7607d284dc513a5f57e0b6abc3a2fb314fa28 on piotrmurach:master.

See also https://github.com/janlelis/unicode-display_width

Hi Jo-Herman,
Thanks for using the library! I like the alternative solution(unicode-display_width) since it has more up to date unicode reference and brings what the library uses. I'm happy to switch over provided I won't have any more unicode utils needs. Maybe for the start we can require the files directly to reduce the load time.
This project depends on another library called verse which usesunicode_utils. I think verse would benefit also from requiring directly the modules it needs. Would you have time to submit PR for verse as well? We could then upgrade the verse and this library and release new version.

Hey, I have updated library to use the unicode-display_width dependency as well as fixed the issues with verse regarding unicode processing. Please install the v0.6.0 and let me know if things get faster for you.

Did some quick'n'dirty tests with one of my cli-apps that used tty-table, and total execution time reported by time dropped by about 200ms.  :+1:

Sweet! Thanks for checking.


ManifoldUpdate callback

The probabilistic, Kalman-filtering equivalent to DiffEqCallback.jl's ManifoldProjection.
The callback does one single update on a given information operator (u) -> residual. The update assumes that the residual should be zero.
It is also non-iterative, and therefore probably not as 100% reliable as the optimization-based ManifoldProjection, but this should be easily expandable by performing iterated updates (as in the IEKF).
EDIT: It's an IEKF update now :heavy_check_mark:

Codecov Report

Merging #79 (8e5818f) into main (4508747) will increase coverage by 0.17%.
The diff coverage is 92.85%.

:exclamation: Current head 8e5818f differs from pull request most recent head 994a505. Consider uploading reports for the commit 994a505 to get more accurate results

@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
+ Coverage   87.51%   87.68%   +0.17%
==========================================
  Files          24       25       +1
  Lines         913      942      +29
==========================================
+ Hits          799      826      +27
- Misses        114      116       +2

Impacted Files
Coverage Δ

src/ProbNumDiffEq.jl
66.66% <ø> (ø)

src/filtering/update.jl
96.42% <87.50%> (-3.58%)
:arrow_down:

src/callbacks.jl
95.00% <95.00%> (ø)

src/gaussians.jl
71.42% <0.00%> (+1.42%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4508747...994a505. Read the comment docs.


Overwite env var results in duplicates that cannot be removed

Describe the bug
When I take the action 'variable override' for an environment variable via the Amplify console, I get 1 input line to define the value and branch. When I save, I get a confirmation message but the override appears 2 times.
When I enter the manage variables again and try to remove one of the doubles, everythings seems to go ok but the 2 overrides keep appearing in the overview. When I try to add another environment variable, I get the error that I cannot have duplicate overrides..
To Reproduce
Steps to reproduce the behavior:

Go to manage variables

Add an override for a variable

Press save

Go to manage variables

Remove a duplicate of the override

Press save

Expected behavior
Only one override should appear.
** Screenshot**

@ben-elsen, we're actively looking into this issue for you and hope to give you an update soon.

@nimacks Ok thanks!

@ben-elsen Hi, the fix was pushed. We will schedule a deployment to resolve the issue.

Hi @ garyleefight Thanks! Do you have an idea when the deployment is sheduled yet?

@ben-elsen
You can try again and it will work.
If there are any other questions please let us know.


Question on use with blogs

👋 Hi! This looks like a great plugin -- was just thinking about use cases and it doesn't seem appropriate for a markdown blog given that the images are sourced via a graphql query and the blog would not have access to that (unless it's written in MDX?).
Cheers!

Hi, yes you need to make graphql queries to fetch images using this plugin. MDX is really cool too because of the experience gotten from writing interactive components in markdown.


Don't detect the laravel locale language and don't show anything when I change the language manually

Im trying to set the package language to spanish but It doesn't detect the locale language, the diffForHumans() only show in english. And when I try to set the language manually with " Lang::setLocale('es'); " the  diffForHumans() function return a empty string, without errors, or anything to track the issue.
Pd: The package looks great, I really want to see it working =)

@jrivera294, could you be trying to use it like $etc->created_at->diffForHumans()? If so, see https://github.com/jenssegers/laravel-date/issues/44.


fix: multiple environment infrastructures

Describe your changes
Currently when getting infrastructures via the SDK we are using GetInfrastructureList which retrieves all of the infrastructure definitions for a particular environment, and then we just select the first option:
readInfrastructure(d, &resp.Data.Content[0])

When a user has multiple infrastructures defined for a particular environment this is causing issues when trying to work with anything other than the first-configured infrastructure definition. The plan will always show changes that need to be made:

Terraform will perform the following actions:

  # harness_platform_infrastructure.dev_sa will be updated in-place
  ~ resource "harness_platform_infrastructure" "dev_sa" {
      ~ deployment_type = "ECS" -> "Kubernetes"
        id              = "lab"
      ~ name            = "lab" -> "sa"
        tags            = []
      ~ type            = "ECS" -> "KubernetesDirect"
      ~ yaml            = <<-EOT
            infrastructureDefinition:
          -   name: lab
          -   identifier: lab
          +   name: sa
          +   identifier: sa
              description: ""
              tags: {}
              orgIdentifier: default
              projectIdentifier: development
              environmentRef: dev
          -   deploymentType: ECS
          -   type: ECS
          +   deploymentType: Kubernetes
          +   type: KubernetesDirect
              spec:
          -     connectorRef: account.sales
          -     region: us-west-2
          -     cluster: riley-lab
          +     connectorRef: account.sagcp
          +     namespace: riley-dev-<+service.name>
          +     releaseName: release-<+INFRA_KEY>
              allowSimultaneousDeployments: false
        EOT
        # (4 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

harness_platform_infrastructure.dev_sa: Modifying... [id=lab]
harness_platform_infrastructure.dev_sa: Modifications complete after 0s [id=sa]

Apply complete! Resources: 0 added, 1 changed, 0 destroyed.
➜  terraform git:(main) ✗ tf apply
<redacted refresh output>

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # harness_platform_infrastructure.dev_sa will be updated in-place
  ~ resource "harness_platform_infrastructure" "dev_sa" {
      ~ deployment_type = "ECS" -> "Kubernetes"
        id              = "lab"
      ~ name            = "lab" -> "sa"
        tags            = []
      ~ type            = "ECS" -> "KubernetesDirect"
      ~ yaml            = <<-EOT
            infrastructureDefinition:
          -   name: lab
          -   identifier: lab
          +   name: sa
          +   identifier: sa
              description: ""
              tags: {}
              orgIdentifier: default
              projectIdentifier: development
              environmentRef: dev
          -   deploymentType: ECS
          -   type: ECS
          +   deploymentType: Kubernetes
          +   type: KubernetesDirect
              spec:
          -     connectorRef: account.sales
          -     region: us-west-2
          -     cluster: riley-lab
          +     connectorRef: account.sagcp
          +     namespace: riley-dev-<+service.name>
          +     releaseName: release-<+INFRA_KEY>
              allowSimultaneousDeployments: false
        EOT
        # (4 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

harness_platform_infrastructure.dev_sa: Modifying... [id=lab]
harness_platform_infrastructure.dev_sa: Modifications complete after 0s [id=sa]

Apply complete! Resources: 0 added, 1 changed, 0 destroyed.

To fix this I switched to using GetInfrastructure where we can target the specific infrastructure definition we are looking for.
I am not sure if the check for soft-delete is still needed here, so I decided to leave it in.
Comment Triggers

PR Check triggers

Build: trigger build
Sub Category Field Check: trigger subcategoryfieldcheck

@rssnyder Changes look good. Can you help make your branch public so I can run some tests before merging this?

@rssnyder Changes look good. Can you help make your branch public so I can run some tests before merging this?

My fork is public, can you be more specific in what you need me to do?

trigger build

trigger subcategoryfieldcheck

@rssnyder please help us resolve the build failing issue.

@rssnyder please help us resolve the build failing issue.

fixed, built locally

trigger build

trigger subcategoryfieldcheck

done in https://github.com/harness/terraform-provider-harness/commit/8399ef5ef7ac24534447eb0c950b3aa71ea3a7ad


fix Calling "uninstall" after state has been cleared

This has been manually merged, and shipped in v1.1.3. Thanks once again for the PR :)

@wnr awesome!


Dev task 14324 nas sdk 20200429

Preparation done before release v1.01

no conlicts and merge directly.