Package Access approved doesn't mean you can join that Team in MS Teams

I tested access to be as member of private Office 365 group. Once approved, he/she can join that Private SPO, but not that Team in MS Teams.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 06201faf-0037-3647-4e91-bb0af80d4812
Version Independent ID: 1b397d76-ecfe-046e-a4c4-0fe5293bceb3
Content: What is entitlement management? - Azure AD
Content Source: articles/active-directory/governance/entitlement-management-overview.md
Service: active-directory
Sub-service: compliance
GitHub Login: @msaburnley
Microsoft Alias: ajburnle

@narismadz Thanks for the question! We're investigating this and will get back to you shortly.

@narismadz, We performed the same scenario in our labs and it seems to be working as expected.
Steps taken to repro the issue:

Created a private  group in EXO
Added user 1 as admin and user2 as member
Went to to  user1's Teams client and created a team from an existing 0365 group.

User1 ==> Admin
User2==> Member
Findings:
User 1 can upload file and open the same in SPO
User 2 can also see the team and could see the file uploaded in files tab by user1.
Result:
Everything works as expected.
To help you troubleshoot this issue we would need to look into the environment and how things are setup. If your tenant is authorized for support case, it would be great if you can create a support case with the Team's Support team and get an engineer on call to you help you troubleshoot the issue. If you cannot create a case, then we can enable a one time free case to help you troubleshoot this issue.
Also, we would like to know the steps you took while trying to set this up so that we can try that same in lab and check the results.
Meanwhile do let me know if your tenant is authorized to create the support case or not.

closing this thread for now


Added Terminator II support + Better error handling

Enabled communication with  the terminator II by adding a slave_id to all modbus reads and writes.
Error handling for Connection-/Access-/Parsing-Errors in:

read_input_registers
read_holding_registers
write_registers

LGTM 👍  Thanks for your contribution!


[Discussion] Llava on a Multimodal Leaderboard?

Discussion
@haotian-liu could you submit Llava-Llama-2 on the leader board below when it's officially out?
https://github.com/BradyFU/Awesome-Multimodal-Large-Language-Models/tree/Evaluation
Hopefully it scores better.

LLaVA-1.5 is now on the leaderboard and SoTA on more :)


Camera chuangmi.camera.029a02 cam switch not working

Device model / 设备型号
chuangmi.camera.029a02
Component version / 插件版本
0.7.13
HA core version / HA版本
2023.9.3
Integrated mode / 集成方式
Cloud (云端模式)
The problem / 问题详情
The cam switch doesn't work anymore

Entity attributes / 实体属性
switch.chuangmi_029a02_ce23_switch_status
Home Assistant Logs / 系统日志

I have the same issue. Any update on this?

I'm facing the same issue as well :/.

maybe related issue?


[Svelte]  on:input event is not being propagated

So as the title says. The  component is "eating" the "on:input" events.
If I try to use this:
<Input
  on:input={(e) => {
	  // never called
	  console.log('on:input');
  }}
/>

... callback is never called and nothing is print. Tracking down the source, I can see this is caused by this line:
https://github.com/AgnosticUI/agnosticui/blob/b577e806b9915b37684f67d1ad2292172de57cff/agnostic-svelte/src/lib/components/Input/Input.svelte#L400
... which is not propagating the event. I was hoping to implement a "validate-on-type" using <Input/>.
Is this a bug or desired behavior?
Thanks,
Howe

Hi, I looked into this and think I've fixed it. It looks like lines 392-420 of Input.svelte used:
value={value}
on:input={e => value = e.target.value}
rather than
bind:value.
This because type is dynamic in:
type={inputType}
so two-way binding through bind:value can't be used. It looks like this manual two-way binding doesn't bubble the manually created on:input event.
My commit changes line 342:
$: inputType = type;
to a use directive:
function typeAction(node) {    node.type = type; }
so that the type of the inputs can be assigned non-dynamically:
<input use:typeAction>
allowing for the use of bind:value.
The inputs now have a simple on:input event which appears to bubble properly.
I'm submitting a pull request, hope this is fix is correct!


Add the count function

[ ] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[ ] None of my changes are plagiarized from another source without proper attribution.
[ ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Congrats @Tankica  on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝


[WIP] Upgrade to React 16

I'm only opening up this now so we have a good view of the changes.
We need to wait until React 16 is really released and when Enzyme has a release that is compatible with it.
The changes needed in our code base seem small.

Will close this for now, will revisit later


Fixes Issue #14

I haven't found a good way to connect to OpenShift if we are already running inside it. Any thoughts?

bcade8de3892076696f0d61e497fe91ff9881683
1d5bbe74d91c6ef684edbde153486176426f6d6b


Handle new attributes that the validator sees

Possible ways to handle are:

Add to the database, but flag as not enabled (admin will have to)
Send to a queue for notification (or in conjunction with above)

      if FederationAttribute.new_attributes?(attrs.keys)
        # FederationAttribute.new_attributes(attr.keys).each do |attribute|
        #   send_off_to_sqs(attribute)
        # end
      end

I don't believe that the flux of attribute changes or the lack of complexity in doing this via the UI + Ansible PR for the Shibboleth SP has proven to be overly burdensome.
Closing, current approach sufficient.


REF: move warm_start to init

Mirrors scikit-learn estimators: https://github.com/scikit-learn/scikit-learn/blob/0fb307bf3/sklearn/linear_model/_stochastic_gradient.py
It probably makes sense to make a _fit method, which will also help accommodate the use of epochs (which should always be 1 for partial_fit).

Closing as this was implemented in #67


Suggestion: PyReturn to keep result type when it can be a special type like NotImplemented

For now, we take advantage of PyResult<T> when T != PyObjectRef but this is not always working because sometimes a method can return a NotImplemented value. When the actual result type is hidden into PyObjectRef, unwrapping the payload is painful and not safe.
By adding another option-like enum, it can be transform into a PyObjectRef at the last stage. Then we can reuse the value in other operation. Please check the second commit (https://github.com/RustPython/RustPython/commit/4b5479040e8d816faafef10b75aa6fdfc6b58508#diff-509d6ec78ee702db3d9c46957c6ecbe0R207-R209) about the example.
This is a Proof-of-concept PR. Let me know if there are any bad idea or any improvement suggestion. I don't think the names and the PyInt adoption is the best now. (Unlike PyFloat example, PyInt part doesn't give any value but just looking more verbose.)

Thanks for making this proof of concept!
A few of my thoughts about this change:

The name PyReturn seems a bit odd to me. Something like PyValue would be better to me.
How are NotImplemented values returned from python code handled? Are those transformed into the specific enum variant?

All in all I am not sure this change is a good idea. I see the point that we must check for the NotImplemented value, since this is an Ok value, not an error.
Maybe another idea is to create a new Err variant for returning either an exception, or a NotImplemented value?
type PyArithmaticResult<T> = Result<T, ArithmaticError>;

enum ArithmaticError {
    Exception(PyObjectRef),
    NotImplemented,
};

fn ne(&self, other: PyObjectRef, vm: &VirtualMachine) -> PyArithmaticResult<bool> {
}

This has the benefit we can re-use the .map function of the Result type, so we do not require to re-implement this.
Btw, I see the benefits of having functions return PyArithmaticResult<bool> instead of PyResult without a type parameter, I think this is a good idea!

Btw, thanks for the detailed explanation of the goal of this change! Nicely done!

If you prefer to define PyArithmaticResult as Result type rather than a value, this declaration also will work.
enum PyArithmaticResult<T> {
    Ok(Option<T>),
    Err(PyObjectRef),
}

Arithmatic operations never(or rarely) return a None value, so I think Ok(None) can represent NotImplemented

Hmm, actually I'm in doubt about this, as you already mentioned, it might rarely occur that the result is indeed None, and then we are faced with an issue, since None rust values are magically converted into python None values, this might become tricky. Also, I think the best option is to create a new Result type, with a new error type, since we can then re-use the map function of the built-in Result type in rust.
This actually boils down to my initial proposal of the PyArithmaticResult type.

I like the idea of an option-like enum that we use as the Ok type for PyResult. That way, we can still use ? to propagate errors (although we could also do that for ArithmaticError if we implement From<PyBaseExceptionRef>), and we don't have to implement Try for a type like PyReturn ourselves. It would also make it very easy to work with thanks to the monadish interface of map, map_or, unwrap_or_else, etc that Option-like types usually have.

I renamed it to PyArithmaticValue and added a special common form PyComparisonValue.
If the Result approach only take advantage of map function, please check the revised code with macro to generate them. Then option-like and Result will have same start line. (When they are technically same, I also prefer vote for option-like one as it is an Ok value)
About python generated NotImplemented, I don't think we ever need to transform any PyObject into PyArithmaticValue. So it will not happen. In that case, we will have PyObject as same as now.
I think this is especially useful for __ne__ functions not to have duplicated implementations in every class - though i don't see more usefulness that much yet.


Implemented toEndWith matcher

What
Add toEndWith matcher with the test suite

Why
Closes issue #40

Notes
Housekeeping

[x] Unit tests
[x] Documentation is up to date
[x] No additional lint warnings
[x] Add yourself to contributors list (yarn contributor)

Codecov Report

Merging #76 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #76   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          23     25    +2
  Lines         101    110    +9
  Branches       13     14    +1
=====================================
+ Hits          101    110    +9

Impacted Files
Coverage Δ

src/matchers/toEndWith/predicate.js
100% <100%> (ø)

src/matchers/toEndWith/index.js
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb2c2b5...71de370. Read the comment docs.

Thanks @marcinlichwala great stuff!


Added logic to update ModelStatus

Signed-off-by: Suresh Nakkeran<EMAIL_ADDRESS>As part of this PR, ModelStatus field is added in InferenceServiceStatus struct which will be used for updating single model deployment status and ModelMesh predictor status.

/retest

@Suresh-Nakkeran Please help rebase paul's status API PR

/retest

/retest

/lgtm
/approve


store Netty Http Response in SessionContext

after discussing this PR with Arthur, I found an alternate solution. This PR is not necessary.


Could we have a option to 'Start Minimized in tray'?

As there a option to auto emulation when a controller is connected, i think that would complement it nicely.

This will be added to 4.x version


Bug Report: Web Development Course image is not linked to its updated Image

ISSUE
When we open the Resources section and see the Web Development courses Section we notice that image for one of the courses is not present.
Expected behavior
It should show the the image of the course in it.
Actual Behavior
This is the Screenshot of the improperly linked  image.

👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Hi @imaaquibali ,
Could u assign this issue to me as a part of Hacktoberfest?

@Shivyoddha Go for it!


Can't count files

Hi, I have this code:
int files = 0;
if (SFileOpenArchive(_T("Eden_RPG_S2_3.1C.w3x"), 0, 0, &hM)) {
	if (GetLastError() == ERROR_SUCCESS) {
		hFile = SFileFindFirstFile(hM, "*", &data, NULL);
		while (SFileFindNextFile(hFile, &data)) {
			files++;
		}
		std::cout << files << " files \n";
	}
}

nError = GetLastError();
   if(nError != ERROR_SUCCESS)  printf("errror %d", nError);

which works fine for "normal" w3 maps, but not for "protected" ones.  How does MPQ Editor work and this not?

Re: [ladislav-zezula/StormLib] Can't count files (#130)
Hi,
try to open each one. Protected maps are crap, they
contain lots of bogus entries in the hash tables.
L.
Hi, I have this code:
int files = 0;
if (SFileOpenArchive(_T("Eden_RPG_S2_3.1C.w3x"), 0, 0, &hM)) {
 if (GetLastError() == ERROR_SUCCESS) {
  hFile = SFileFindFirstFile(hM, "*", &data, NULL);
  while (SFileFindNextFile(hFile, &data)) {
   files++;
  }
  std::cout << files << " files \n";
 }
}
nError = GetLastError();
   if(nError != ERROR_SUCCESS)  printf("errror %d", nError);
which works fine for "normal" w3 maps, but not for "protected" ones. How does MPQ Editor work and this not?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
--
S pozdravem,
 Ladislav Zezula
<EMAIL_ADDRESS>

Well, map does not have listfile, so just wanted a method to iterate all its files.  For protected map, SFileOpenArchive return true but GetLastError() gives 1392

SFileOpenArchive return true but GetLastError() gives 1392

Only check LastError when a function returns false. Otherwise, GetLastError usually returns whatever was there before.

Yeah my bad, SFileOpenArchive gives 1392 error, but MPQ Editor opens it fine

I still don't understand how MPQ Editor can open it but stormLib can't


Frozen core densities / dipoles

currently, the density may be computed with ccdensity.compute_onepdm(. . ., withref = True), which is intended to include the reference (SCF) contribution to subsequent one-electron property calculations by adding twos along the diagonal of the occ-occ block. this is generally only used in the real-time code to compute dipoles which include the SCF contribution, rtcc.dipole(. . ., withref = True). while this works for all-orbital calculations, this is not correct in the case of frozen-core, as the SCF dipole should still be computed with all orbitals (only the correlated calculation freezes the core).
this can't be remedied by simply extending the density matrix for that one computation, since the MO-basis dipole integrals are stored on the wfn without the core as (NACT x NACT). we could either

pull the SCF dipole off the reference wfn (computed automatically in Psi) and store it on the ccwfn,
just pull it from the ref wfn if requested in rtcc.dipole, or
remove the withref option all together.

I'm in favor of the latter, but they're all pretty simple solutions.
luckily, this shouldn't have any impact on previous results, as generally we only use the induced dipole in RTCC, and this option isn't really used anywhere else. @lothian
as a side note, I came across this issue because I made the same mistake again in my CIS code I'm using for some real-time CI work. :)

This is all true.  And if we decided to include the orbital response in our RT-CC calculations (something I've been pondering recently), then this would become more of an issue.  In addition, I want to add analytic gradients to PyCC because we need a good reference implementation of that, and this issue plagues both the one- and two-electron densities for those.
I think that, for now, we should just remove the withref option from ccdensity.compute_onepdm() and make sure the documentation is clear that the code only produces the correlated contribution.


Furigana is invisible on dark mode

mirigana v0.20 on Firefox 78.0.2, MacOS 10.15.5
Light:

Dark:

Thank you for your feedback!
Version 0.22 has been published for the firefox.
The chrome version will be available after the review.
New font color white was added.
You can choose it in the popup window from your address bar.

Thanks.


JS: change precision of js/loop-bound-injection to high

Change precision of js/loop-bound-injection to high.
Also fixes an FP.
We already found that kind of FP for for (var i = 0... loops, so it was just a case of adapting it for _.forEach(...) loops.
Me taking a rough look at the results from the Chris API gives an ~80% TP rate, which is better than I expected, and I'm therefore upgrading precision of the query to high.
There are still false positives, but they are hard to eliminate in a nice way.
Performance evaluation is on the way, but I would be surprised if performance changed.

Performance evaluation is done.
The performance is within the margin of error of the previous performance.

@asger-semmle, this looks good to go?


TagUI crashes when download link is clicked

Hi Ken,
I'm currently writing a TagUI script on one of our corporate websites.
There's a series of reports that the users need to download, and I encounter one very strange situation which I've never seen before.
For each report, the robot will enter the report ID, then click the "Generate Report" button. Then it will click a pulldown menu and then choose "PDF".
If I do it manually, the moment I click "PDF" from the pulldown menu, the report will be generated and straightaway downloaded to the default Downloads folder (in Windows 10).
For your TagUI, you actually created a separate profile for TagUI, right?  When I do this manually in my own Chrome, everything works fine. I see the file downloaded in the Downloads folder.
However, when I run it using TagUI script, the moment it clicks the PDF from the pulldown menu, TagUI crashes.  The file is actually downloaded, and I can see the file in the Downloads menu.  However, because TagUI crashes, it cannot continue to run the rest of the reports.
To make sure that it's not error in my TagUI script, I put a LIVE early in the script.  Then I manually download the PDF using the Chrome initiated by TagUI.  True enough, the Chrome by TagUI crashes the moment I select PDF from the pulldown menu.
There's no error message at all in the command prompt.  The Chrome/TagUI just crashes.

Has any of your users encountered such thing before - in which downloading a file in the user Chrome works fine, but the same link using TagUI Chrome crashes the browser?

Is there any other log files somewhere that I can show you so that you have more clues as to where might be the problem?

p.s. the link is not the standard
<a href="url">

type, so I cannot grab the url and go to the download link direct. It's one of those server generated one.

Thanks for the detailed background of the issue. As it is not a public website to share replication steps, my best guess is it is some non-standard link or button. So different that can crash the underlying framework when Chrome sends message back to TagUI.
My first thought will be to use dom step to send JS code directly to the webpage to click the link. that way, no matter what happens, TagUI will still be safe from getting crash. Then if there is a way to tackle this properly, then a longterm solution should be explored.
Will have a look more when you drop by my place this afternoon 👍

Solution found -
chrome_step('Page.setDownloadBehavior',{behavior: 'allow', downloadPath: 'c:\\Users\\userid\\Downloads'});

Summary - for some reason, the website does not like having the file download location set to the location of the automation flow. Solution done in person just now is modifying tagui_parse.php to comment out the line in url_intent() to not change default download location. However, above statement can also be run to change default file download location to a folder user desires and it should work too.


XCode 7.2 Support

:+1:

:+1:

:+1:

👍

Sorry if this is a question that has been answered before, but is there a way to make Polychromatic compatible with all future versions of Xcode? I'd be glad to help with this, if someone can point me in the right direction! :smile:

@Jasdev Not that I know of; they used to be compatible indefinitely but they intentionally added this system.


Cover the crowdin.ts class by Unit tests

This class is an important part of the application, so it would be great to have Unit tests for its methods.

Actual coverage
crowdin.ts

Hi @andrii-bodnar I think I can work on this, can you assign it to me?
thanks

Hi @MaurizioPz, sure, thank you!


go get failed

after set $GOPATH to ~/gocode and run the go get command, it reported error, as shown below:

$ go get github.com/parkomat/parkomat
# github.com/miekg/dns
gocode/src/github.com/miekg/dns/client.go:431: undefined: tls.DialWithDialer
gocode/src/github.com/miekg/dns/dnssec.go:257: undefined: crypto.Signer
gocode/src/github.com/miekg/dns/dnssec.go:321: undefined: crypto.Signer
gocode/src/github.com/miekg/dns/sig0.go:16: undefined: crypto.Signer
# golang.org/x/net/webdav
gocode/src/golang.org/x/net/webdav/webdav.go:619: (&url.URL literal).EscapedPath undefined (type *url.URL has no field or method EscapedPath)

same here.......ace
go get github.com/parkomat/parkomat
golang.org/x/net/webdav
go/src/golang.org/x/net/webdav/webdav.go:619: (&url.URL literal).EscapedPath undefined (type *url.URL has no field or method EscapedPath)

Which version of Go are you using?
I am not able to reproduce it...

Ok it seems like the problem occurs with Go 1.4.
I suggest using at least Go 1.5

thanks, my Ubuntu 14.04 distributes with go version go1.2...

@felix021 please check this project https://github.com/moovweb/gvm
It works well with Ubuntu 14.04 and makes you use latest Go versions easily.


added setEmissiveFactor to scene-graph API

This was one of the gaps between scene-graph and editing-adapter and it was blocking some new UI in the editor, so it got higher priority.

looking good


Research the situation around MonoGame + .NET Core + NixOS

Add nixos-unstable channel, install dotnet-sdk.
Write the following into default.nix:

with import <nixpkgs> {}; {
    CamanisEnv = stdenv.mkDerivation {
        rpath = stdenv.lib.makeLibraryPath [ stdenv.cc.cc libunwind libuuid icu openssl zlib curl ];
        name = "Camanis";
        buildInputs = [ mesa xorg.libX11 mono46 libunwind libuuid icu patchelf ];
        LD_LIBRARY_PATH="${libunwind}/lib:${libuuid}/lib";
    };
}

nix-shell
dotnet run

The output is the following:
Unhandled Exception: Microsoft.Xna.Framework.Graphics.NoSuitableGraphicsDeviceException: Failed to create graphics device! ---> System.NullReferenceException: Object reference not set to an instance of an object.
   at MonoGame.OpenGL.GL.GetString(StringName name)
   at MonoGame.OpenGL.GL.LoadExtensions()
   at MonoGame.OpenGL.GL.LoadEntryPoints()
   at MonoGame.OpenGL.GraphicsContext..ctor(IWindowInfo info)
   at MonoGame.OpenGL.GL.PlatformCreateContext(IWindowInfo info)
   at MonoGame.OpenGL.GL.CreateContext(IWindowInfo info)
   at Microsoft.Xna.Framework.Graphics.GraphicsDevice.PlatformSetup()
   at Microsoft.Xna.Framework.Graphics.GraphicsDevice.Setup()
   at Microsoft.Xna.Framework.Graphics.GraphicsDevice..ctor(GraphicsAdapter adapter, GraphicsProfile graphicsProfile, PresentationParameters presentationParameters)
   at Microsoft.Xna.Framework.Graphics.GraphicsDevice..ctor(GraphicsDeviceInformation gdi)
   at Microsoft.Xna.Framework.GraphicsDeviceManager.CreateDevice(GraphicsDeviceInformation gdi)
   at Microsoft.Xna.Framework.GraphicsDeviceManager.CreateDevice()
   --- End of inner exception stack trace ---
   at Microsoft.Xna.Framework.GraphicsDeviceManager.CreateDevice()
   at Microsoft.Xna.Framework.GraphicsDeviceManager.Microsoft.Xna.Framework.IGraphicsDeviceManager.CreateDevice()
   at Microsoft.Xna.Framework.Game.DoInitialize()
   at Microsoft.Xna.Framework.Game.Run(GameRunBehavior runBehavior)
   at Microsoft.Xna.Framework.Game.Run()
   at Camanis.Program.main(String[] argv) in /home/fornever/Camanis/Program.fs:line 11
Aborted

Voices from the other side suggested to use the following workaround:
with import <nixpkgs> {};
mkShell {
  buildInputs = [
    dotnet-sdk
    mono
  ];
  LD_LIBRARY_PATH = stdenv.lib.makeLibraryPath [
    freetype
    libGL
    pulseaudio
    xorg.libX11
    xorg.libXrandr
  ];
}

Thanks ^,.^
Friedrich von Never
2019년 12월 7일 (토) 오후 10:33, Friedrich von Never<EMAIL_ADDRESS>작성:

Voices from the other side suggested to use the following workaround:
with import  {};mkShell {
buildInputs = [
dotnet-sdk
mono
];
LD_LIBRARY_PATH = stdenv.lib.makeLibraryPath [
freetype
libGL
pulseaudio
xorg.libX11
xorg.libXrandr
];
}
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ForNeVeR/Gyges/issues/5?email_source=notifications&email_token=AAJJOPIMGENI4ZIVBIRRAWLQXOQZFA5CNFSM4EKGAXHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGGG6NA#issuecomment-562851636,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJJOPPXY5BQF2UFHOHXV23QXOQZFANCNFSM4EKGAXHA
.

We don't use NixOS for this game, currently. If there're any collaborators, we may resurrect the effort. Otherwise, I'm closing this for now (which doesn't mean we don't support Linux in general or NixOS for development; we do, but on the contributor-driven basis).

I had this problem for another MonoGame project. This happens when the OpenGL driver shared library fails to load.
For me, LD_DEBUG showed me that as it attempts to load, the version lookup for GLIBC_2.xx fails. MonoGame doesn't throw any exception at this point. GetString does, only because it just happens to be the first GL function call that is attempted. My NixOS system (and Mesa) was compiled with a newer glibc version than the game's ELF's interpreter. One could probably use nixGL, but updating nixpkgs to match glibc versions worked for me.

@libjared, thanks a lot for your help!


As much as it pains my soul...clamp.

When in doubt, just clamp it...

Nooooooooooooo....ok
:+1:


No node found error

Error: No node found for selector: body > section > div.g12 > div > div.ui-tabs-panel.ui-widget-content.ui-corner-bottom > div.Manager.angular-form.importsManagerForm.ng-scope > div > div > form > div > div > section:nth-of-type(2) > div:nth-of-type(2) > input
Selector as written above produces results when typed in the Chrome dev console. Error comes when trying to automate against web page https://app.c2atom.com/home#/imports-manager
Steps to reproduce
run index.js after renaming from index.txt
See also page in html form
imports-manager.txt
.
index.txt
Tell us about your environment:

Puppeteer version:
Platform / OS version: Windows 10-1709-64 bits
URLs (if applicable): https://app.c2atom.com/home#/imports-manager
Node.js version: 8.12.0

What steps will reproduce the problem?
running index.js
What is the expected result?
selecting the item and being able to type in some text.
What happens instead?
Error

@fibag21, this seems like a synchronization issue where your puppeteer script is faster than what's happening in the application. You can play around with the waitUntil options in page.goto() or use the page.waitForSelector() before any of the click, type, or select calls. Also, improving some of the css selectors might help. (i.e. BUTTON_SELECTOR='button[type='submit']' can be used instead)

Thanks k3mayo for the quick reply. page.waitForSelector() did the trick. I do not have any influence on improving the CSS.
Issue SOLVED


Client's thread

I cant create more than 1 client. When create 2nd, its thread just freezes, setting only TdLib parameters and dont go on further. Coding on Java. Can I create more client to provide more users cause Im using Spring Security via session managment.

new Thread(client, "TDLib thread").start();
How do I should define client in new thread and is It possible to use for all clients one thread? Please, I need to resolve this problem very quickly, and what about ExecutorService?

You can't simultaneously use the same database directory from 2 or more TDLib instances. One user = one directory = one instance.

So, I just need to load new native library for new client?

`
try {
java.io.File directory = new java.io.File(libDir);
java.io.File nativeLibrary = FileUtils.getFile(directory, "libtdjni.so");
  Path newLibraryPath = Paths.get(libDir + "lib" + userLogin + ".so");

  try {
    Files.copy(nativeLibrary.toPath(), newLibraryPath, StandardCopyOption.REPLACE_EXISTING);
  } catch (IOException exception) {
    logger.severe(exception.getMessage());
  }

  java.io.File newLibrary = FileUtils.getFile(newLibraryPath.toString());

  logger.info("New instance of native library: " + newLibrary.getAbsolutePath());
  System.load(newLibrary.getAbsolutePath());
} catch (UnsatisfiedLinkError e) {
  e.printStackTrace();
}

`
I did like this, but no success

If you want to log in as a different user, then yes.


deprecate 'useWSL' launch config attribute

With the advent of the "Remote WSL" extension it is no longer necessary to continue the useWSL "hack". Consequently we should start deprecating the use of "useWSL" in launch configs.

using the "useWSL" attribute in launch configs results in a deprecation squigglie.
running a launch configs that uses a "useWSL" attribute results in a notification (with the option to turn future notifications off).

This works just fine, adding verified label.
However in order to have this we have introduced a new setting
debug.node.showUseWslIsDeprecatedWarning
I am always against introducing settings for obscure scenarios that less than 0.1% of our users will hit.
My personal preference is to put this in workspace storage.
So if the user clicks ignore, he will no longer be reminded about the deprecation.
I can not imagine a scenario where a user would go to our setting file and be like "I would like to get that warning again" and change the value of this setting. If he remembers to do that he will actually just fix the thing and start using the extension, he will never change this setting imho. Thus it should not be a setting but in local storage per workspace.


"ballerina test" runs tests when the folder is not named "tests"

Description:
$Subject
Steps to reproduce:
Run ballerina test at the project root level.
├── ballerina.conf
├── data_backed_service
│   ├── employee_db_service.bal
│   └── xxxx
│       └── employee_db_service_test.bal

Tests will be executed regardless of the folder tests reside.
guide git:(0.981.0-changes) ✗ ballerina test --config ./ballerina.conf
Compiling tests
    data_backed_service:0.0.0

Running tests
    data_backed_service:0.0.0
ballerina: started HTTP/WS endpoint <IP_ADDRESS>:9090
	[pass] testAddEmployeeResource
	[pass] testRetrieveByIdResource
	[pass] testUpdateEmployeeResource
	[pass] testDeleteEmployeeResource

	4 passing
	0 failing
	0 skipped

This issue is not reproducible anymore.


objectionary.com

I own this domain: objectionary.com.  The idea was introduced by David West in his book "Object Thinking" ten years ago. The idea is that objects will stay in some "repository" and applications will use them. Objects, not libraries, artifacts, binaries. Maybe it's time to use this paradigm in EO?

Could you explain more this idea?
Is this something about the Memory object?

@mdbs99 I'm not sure yet, but maybe just like that. We deploy objects there and we use them from there. Not JAR libraries, but .eo files. We will manage dependencies on the level of objects, not libraries. In the language I will say import org.eolang.string and the object will be retrieved from objectionary. Together with other objects it depends on.

I didn't understand the difference, in the code level, between dependencies from objects instead of libraries.
When you say import org.eolang.string for me it's mean org.eolang library.

@yegor256 is this objectionary is kind of repository or factory?

@englishman both. David West says "object-dictionary-factory"

@yegor256 these objects will be shared, like a "conection pool"?

Which version of org.eolang.string will be imported from objectionary?

@amaembo good question. maybe we will use it like this:
import org.eolang.string:1.4.8
import org.eolang.if:1.3

We will specify versions per object.

@yegor256 I like the syntax, but I didn't understand which "version" do you're talking about.

@yegor256 what if ten different classes in your project import ten different versions of org.eolang.string? Will you package all of them inside the resulting application? Also note that you will have problems with code generation (regardless whether you want to produce Java code or JVM bytecode): you will have to rename all these different versions to avoid possible clashes. While this might look like an implementation detail, the renamed class name could be visible in debugger, exception stack traces, etc.

@amaembo what's about ten different objects with same name and different versions? Remember, they are objects, not classes. Yes, the stacktrace may look strange, but we can name them right. For example org.eolang.string will look like org.eolang.string$1$4$8 in Java.

@yegor256 another question: suppose that source file A (I'm trying my best to avoid the word "class") refers to org.eolang.string:1.4.8 while source file B refers to org.eolang.string:1.4.9. Can the string object from file A be passed into file B and used there?

Few weeks ago I thought exactly same thing. But I started from other side. Every object is a concept of ontological modeling. What is ontological modeling? It's process of describing concepts and relationships, and building a model in current domain. It as programming, isn't it?
People, who work with ontology, use repositories of concepts, for maximal reusing them. And repository operates not with domain or project, it works with every concept. It can supply separately one concept for your own schema by concept's url.

I like this idea very, very much! I'm pretty sure other languages have something similar, but I'm not an expert... What exactly would you be getting from the objectionary? The source code for an object's version? A compiled version?

@MadridianFox, how do  they deal with different versions of the same concept, is that possible?

It can supply separately one concept for your own schema by concept's url.

@amaembo I believe it's a problem of a compiler. Let's say, we represent objects as JVM static methods (I believe, that's how it will work). In that case string:1.4.8 is one static method, while string:1.4.9 is just another static method. No conflicts. In other words, I don't think we will use JVM objects at all, simply because they are not powerful enough.

I guess published EO objects would depend on each-other kind of like how Docker images build on each-other - so you would have a particular version of the object. However its interfaces would also need to be versioned the same way.. so it will be a versioned dependency graph.
Semantic versioning can be calculated programmatically (at least in terms of API compatibility) - see for instance how japicmp checks each method.

I do not quite understand how we can publish a string object. Object should have state.
What is the state of the object org.eolang.string:1.4.8?

It should be an empty string (length() = 0), a reasonable default, just
like an empty list is reasonable default for implementations of Collection
interface?
(It's constructor would allow deriving objects with other state, obviously)
On 31 Mar 2017 10:14 am, "Andrey Valyaev"<EMAIL_ADDRESS>wrote:

I do not quite understand how we can publish a string object. Object
should have state.
What is the state of the object org.eolang.string:1.4.8?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/yegor256/eo/issues/22#issuecomment-290661632, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAPd5UgFw2H-IqpPJT9d5miBpzjjokj5ks5rrMPfgaJpZM4K1X6q
.

if org.eolang.string:1.4.8 have default value, we can use this value in code.
If(Eq(hello, org.eolang.string:1.4.8), ...)
This is like a static variable...
What is the default value for If or Eq

Eq default should be false.
If default is tricky. Lacking generics and null, perhaps also false?
On 1 Apr 2017 8:28 pm, "Andrey Valyaev"<EMAIL_ADDRESS>wrote:
if org.eolang.string:1.4.8 have default value, we can use this value in
code.
If(Eq(hello, org.eolang.string:1.4.8), ...)
This is like a static variable...
What is the default value for If or Eq
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/yegor256/eo/issues/22#issuecomment-290941814, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAPd5ey2qTQy3OLdQ9RVotiTlpoHT67nks5rrqV2gaJpZM4K1X6q
.

We'll continue in #214

Job gh:cqfn/eo#22 is not assigned, can't get performer


feat: service support kong deck mode plugins convert

Codecov Report

Merging #36 (f6478ff) into main (86c24b6) will increase coverage by 0.14%.
The diff coverage is 64.96%.

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   70.27%   70.41%   +0.14%
==========================================
  Files          13       13
  Lines         777      835      +58
==========================================
+ Hits          546      588      +42
- Misses        158      170      +12
- Partials       73       77       +4

Impacted Files
Coverage Δ

pkg/kong/kong.go
14.81% <0.00%> (-2.43%)
:arrow_down:

pkg/kong/plugin.go
76.73% <61.53%> (+0.20%)
:arrow_up:

pkg/kong/globalrules.go
51.21% <63.15%> (+1.21%)
:arrow_up:

pkg/kong/service.go
73.17% <64.28%> (-2.20%)
:arrow_down:

pkg/kong/route.go
67.77% <66.66%> (+2.96%)
:arrow_up:

pkg/kong/consumer.go
92.00% <100.00%> (+0.69%)
:arrow_up:

test/e2e/utils/delete.go
41.81% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91ce75e...f6478ff. Read the comment docs.


Launch Terminal fails if directory contains a space

OS X 10.10.5, Atom 1.11.2, hydrogen-launcher 1.0.2
Hydrogen Launcher: Launch Terminal gives an error if your project directory contains a space:
Command failed: open -a Terminal.app /Users/dnowacki/Documents/Space Dir/py The files /Users/dnowacki/Documents/Space and /Dir/py do not exist.
(Needs enclosing quotes around full path)
Hydrogen Launcher: Launch Jupyter Console works OK with a space, however (and is the real reason I paid the price of admission 👍 )

Thanks for reporting. I'll fix it when I'm back at home.

I just released v1.0.3. It should work now.
Please report if anything is broken.

Awesome, thanks


Adding sample for execute-shellcode-via-enumuilanguages.yml

Example file for https://github.com/mandiant/capa-rules/pull/505
File source: https://www.virustotal.com/gui/file/ffcf88ead82bdfc159376026f5a9a7da49e593497674bdb6fa7f7d03dd9398d9

thank you!


Asking to add some string basic interview quetions for builiding confidence

Description of Change

Description Of change: proposing for adding a string interview quetions and a readme file listing a documentation of strings and a associated stl.
File names: folder name: interviewquetions
path- C-Plus-Plus\strings\interviewQuetions
I acknowledge that all my contributions will be made under the project's license.

@realstealthninja


Plasma

This is a duplicate of #86
Really sorry about this. I accidentally deleted my fork of this repo thinking it was already merged.

#86 was unmerged because we were waiting on Readme and mogrify_detect.ex
This one includes those changes - thanks - so probably okay to merge. Objections from anyone?

@talklittle nope. let's go!


Add malay wordlist

Add wordlist for Bahasa Melayu. Source: https://github.com/open-dict-data/ipa-dict/blob/master/data/ma.txt

I'll add it @0xN1 thanks!

@kalpetros thanks! i've squashed the commits :)


drivers: can: add structs for common configuration and data fields

Add structs and initializers for common CAN controller driver configuration and data fields. Refactor all in-tree drivers to use these.
This is refactoring is a clean-up and preparation for moving some of the driver API functions to be common functions (e.g. can_get_max_bitrate()) and introducing new common functions (e.g. can_get_transceiver(), can_get_mode(), ...).
There are no functional changes in this PR.

I would even go one step further and add accessor functions for the common fields. For example:
common.started -> is_started(&common)
They can be inline function in the header, so it won't bloat, but we still have the chance to change the internals of common without changing all drivers.

I would even go one step further and add accessor functions for the common fields. For example:
common.started -> is_started(&common)
They can be inline function in the header, so it won't bloat, but we still have the chance to change the internals of common without changing all drivers.

Yes, this is what I described as the next steps in the description of this PR.


Can't access server logs via web interface

I can't access the server logs for either makeabilitylab-test or makeabilitylab via the web interface. I receive different errors, however, for both.
For: https://makeabilitylab-test.cs.washington.edu/logs/
They look blank:

If I try to view, say, 50 lines by using the dropdown menu, I get another error:

For: https://makeabilitylab.cs.washington.edu/logs/

@mechanicjay just got back to me with an important reminder that these logs are only the auto-deploy logs and the logs from the frontend proxy (and not the application logs):

I've fixed the fs permissions which were preventing the log viewer from working.  Just a reminder the only logs that are available at the link are the logs from the autodeploy process and the logs from the front-end proxy.  The application logs will still only be available over ssh.


Bad Request in email link

Hi,
I created a stack in the ca-central region yesterday
I have tried connecting via the link sent via the email from AWS/Cloudformation
I have still been unable to utilize the pcluster manager service
I get the following HTTP error when connecting to the link

Cheers

I have since deleted the stack as I don't want it to cost me while I cannot access it.

This will be fixed in PR #83
Sorry about that.
On Apr 1, 2022, at 8:41 AM, Nicholas Yue @.***> wrote:

I have since deleted the stack as I don't want it to cost me while I cannot access it.
—
Reply to this email directly, view it on GitHubhttps://github.com/aws-samples/pcluster-manager/issues/86#issuecomment-1086052648, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABKJ77DJTUDHZTWUOUQYTTTVC4KGNANCNFSM5SJB7GMQ.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Fixed now!


Externalise a few timeouts & fix timeout for hostSupportsUefi in libvirt ready command wrapper

Description
This PR fixes bug introduced in #8502. Timeout for script execution was set to 60 ms instead of 60s which resulted in host not getting UEFI enabled. This is a blocker for 4.19 release.
We do this by introducing a new agent parameter agent.script.timeout (default - 60 seconds) to use as a timeout for the script checking host's UEFI status.
We also externalize the timeout for the ReadyCommand by introducing a new global setting ready.command.wait (default - 60 seconds).
For ModifyStoragePoolCommand, we don't externalize the timeout to avoid confusion for the user. Since, the required timeout can vary depending on the provider in use and we are only setting the wait for default host listener for now. Instead, we reuse the global wait setting by dividing it by 5 making the default value of 6 minutes (1800/5 = 360s) for ModifyStoragePoolCommand.
Note: the actual time, the MS waits is twice the wait set for a Command. Check reference code below.
https://github.com/apache/cloudstack/blob/19250403e645c76f60b17aa4aeb4dc915f5ca206/engine/orchestration/src/main/java/com/cloud/agent/manager/AgentAttache.java#L406-L442

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[x] Minor

Bug Severity

[x] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

How did you try to break this feature and the system with this change?

@blueorangutan package

@blueorangutan package

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 8412

is this maybe suitable for 4.18.2 even?

is this maybe suitable for 4.18.2 even?

We will need to add changes in this PR https://github.com/apache/cloudstack/pull/8502 to 4.18 as well.

@blueorangutan package

@blueorangutan package

@blueorangutan package

@blueorangutan test

@blueorangutan test matrix

@vishesh92 a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[SF] Trillian test result (tid-8925)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47048 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8547-t8925-kvm-centos7.zip
Smoke tests completed. 121 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

@blueorangutan package

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[SF] Trillian test result (tid-8924)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 48332 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8547-t8924-vmware-67u3.zip
Smoke tests completed. 120 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_02_balanced_drs_algorithm
Failure
135.16
test_cluster_drs.py

@blueorangutan package

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 8435

@blueorangutan test matrix

@vishesh92 a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[SF] Trillian test result (tid-8936)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41623 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8547-t8936-xenserver-71.zip
Smoke tests completed. 120 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_02_trigger_shutdown
Failure
341.90
test_safe_shutdown.py

@blueorangutan test ubuntu22 kvm-ubuntu22

@weizhouapache a [SL] Trillian-Jenkins test job (ubuntu22 mgmt + kvm-ubuntu22) has been kicked to run smoke tests

@blueorangutan test alma9 kvm-alma9

[SF] Trillian test result (tid-8938)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52708 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8547-t8938-kvm-centos7.zip
Smoke tests completed. 120 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_08_upgrade_kubernetes_ha_cluster
Failure
940.82
test_kubernetes_clusters.py

[SF] Trillian test result (tid-8937)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 53125 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8547-t8937-vmware-67u3.zip
Smoke tests completed. 120 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_list_vms_metrics_history
Error
15.12
test_metrics_api.py

@blueorangutan package

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

-1 (binding)
@vishesh92 this PR does not fix #8506. The issue and the thread it mentions is related to a generic solution, which was not even discussed.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 8440

-1 (binding)
@vishesh92 this PR does not fix #8506. The issue and the thread it mentions is related to a generic solution, which was not even discussed.

@GutoVeronezi would it make sense to keep the issue open for further work and continue with this PR or are you -1 on the PR changes as well?

-1 (binding)

binding does not apply to PRs. That said, if you have objections and a way forward we will not merge (on any solidly argued -1)

@vishesh92 this PR does not fix #8506. The issue and the thread it mentions is related to a generic solution, which was not even discussed.

@GutoVeronezi , I suppose you are referring to the solution mentioned in this comment: https://github.com/apache/cloudstack/pull/8502#discussion_r1450506118 ?
If so, this is a good idea and would obsolete this PR, but not without implementation. Do you have code ready to replace the code here?

-1 (binding)
@vishesh92 this PR does not fix #8506. The issue and the thread it mentions is related to a generic solution, which was not even discussed.

@GutoVeronezi I agree that this PR does not fix #8506. We need to revisit the timeouts for Commands on both the MS (#8506) & agents (#8011 - Agents don't even consider timeout which is set in the Commands).
The main purpose of #8502 was to fix the failures we were seeing in e2e tests, but I introduced another bug (because of using 60ms instead of 60s for the script's timeout).
In this PR, I wanted to fix the bug I introduced and address your concerns at least for the changes I did in my previous PR (#8502).
Regarding externalizing timeouts for all commands, IMO we shouldn't try to fix it for now. I would like to do that but it would be a very big change and it will require more discussion and planning because the same Command can processed by different providers depending on an environment and the required timeout can be different depending on the scenario and the setup.
I would like to get this PR merged for now since it's a blocker for unblock 4.19 release. Let me know what you think?

@GutoVeronezi would it make sense to keep the issue open for further work...

Sure do, because the issue is not being fixed by this PR.

... are you -1 on the PR changes as well?

No. Indeed, I proposed the externalization of the timeout settings, vide https://github.com/apache/cloudstack/pull/8502#discussion_r1450410628 (and the author of the PR was against it at first: https://github.com/apache/cloudstack/pull/8502#discussion_r1452036208). My point is that this PR does not even touch the essence of the issue; therefore, saying it solves the issue does not make sense.

binding does not apply to PRs.

Thanks, @DaanHoogland. I think I missed this detail from the docs.

@GutoVeronezi , I suppose you are referring to the solution mentioned in this comment: #8502 (comment) ?
If so, this is a good idea and would obsolete this PR, but not without implementation. Do you have code ready to replace the code here?

No, there is no code ready yet; before implementing something every each way, we should discuss the pros and cons. That is the purpose of the issue.

I would like to get this PR merged for now since it's a blocker for unblock 4.19 release. Let me know what you think?

I see #8502 was a blocker, but why this one is a blocker?

@vishesh92, please, improve the description of the PR to reflect the real proposal (which is different from issue #8506), mentioning PR #8502 and explaining why it is a blocker.

I see #8502 was a blocker, but why this one is a blocker?
I used 60 ms instead of 60000 ms as timeout for the script. This resulted in all hosts having UEFI status as false.

@vishesh92, please, improve the description of the PR to reflect the real proposal (which is different from issue #8506), mentioning PR #8502 and explaining why it is a blocker.

I have updated the PR description.

@blueorangutan package

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 8443

@blueorangutan test matrix

@vishesh92 a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[SF] Trillian test result (tid-8941)
Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22
Total time taken: 50172 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8547-t8941-kvm-ubuntu22.zip
Smoke tests completed. 121 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

[SF] Trillian test result (tid-8942)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 55621 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8547-t8942-kvm-alma9.zip
Smoke tests completed. 121 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

[SF] Trillian test result (tid-8946)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43130 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8547-t8946-xenserver-71.zip
Smoke tests completed. 121 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

[SF] Trillian test result (tid-8948)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43265 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8547-t8948-kvm-centos7.zip
Smoke tests completed. 121 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

[SF] Trillian test result (tid-8947)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 48946 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8547-t8947-vmware-67u3.zip
Smoke tests completed. 119 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

ContextSuite context=TestAccounts>:setup
Error
0.00
test_accounts.py

ContextSuite context=TestAddVmToSubDomain>:setup
Error
0.00
test_accounts.py

test_DeleteDomain
Error
9.30
test_accounts.py

test_forceDeleteDomain
Failure
9.18
test_accounts.py

ContextSuite context=TestRemoveUserFromAccount>:setup
Error
10.38
test_accounts.py

ContextSuite context=TestTemplateHierarchy>:setup
Error
12.21
test_accounts.py

test_02_balanced_drs_algorithm
Error
429.31
test_cluster_drs.py

@GutoVeronezi are your concerns with this PR addressed? I'll proceed with 4.19RC4 if no objections


transformObjectKeys - duplicate variable declaration

Hi, managed to reproduce the error with a minimal example below:
Error will only happen if exceeds 50 assignments.
const a1 = { x: 1 }
, a2 = { x: 2 }
, a3 = { x: 3 }
, a4 = { x: 4 }
, a5 = { x: 5 }
, a6 = { x: 6 }
, a7 = { x: 7 }
, a8 = { x: 8 }
, a9 = { x: 9 }
, a10 = { x: 10 }
, a11 = { x: 11 }
, a12 = { x: 12 }
, a13 = { x: 13 }
, a14 = { x: 14 }
, a15 = { x: 15 }
, a16 = { x: 16 }
, a17 = { x: 17 }
, a18 = { x: 18 }
, a19 = { x: 19 }
, a20 = { x: 20 }
, a21 = { x: 21 }
, a22 = { x: 22 }
, a23 = { x: 23 }
, a24 = { x: 24 }
, a25 = { x: 25 }
, a26 = { x: 26 }
, a27 = { x: 27 }
, a28 = { x: 28 }
, a29 = { x: 29 }
, a30 = { x: 30 }
, a31 = { x: 31 }
, a32 = { x: 32 }
, a33 = { x: 33 }
, a34 = { x: 34 }
, a35 = { x: 35 }
, a36 = { x: 36 }
, a37 = { x: 37 }
, a38 = { x: 38 }
, a39 = { x: 39 }
, a40 = { x: 40 }
, a41 = { x: 41 }
, a42 = { x: 42 }
, a43 = { x: 43 }
, a44 = { x: 44 }
, a45 = { x: 45 }
, a46 = { x: 46 }
, a47 = { x: 47 }
, a48 = { x: 48 }
, a49 = { x: 49 }
, a50 = { x: 50 }
, a51 = { x: 51 }

The problem can be easily reproduced just with this code:
const c = { x: 1 };

and
transformObjectKeys: true

Yes, that's the shortest test.
Should add this into the unit tests too.

Can you try this branch?
https://github.com/javascript-obfuscator/javascript-obfuscator/pull/552
Will it help?

Tested and looks good - no more duplicate variable errors.

Can you also test it on?
#555

Did a quick test, hit errors below in different files:

ReferenceError: Cannot access 'cO' before initialization
Identifier 'bf' has already been declared

Can narrow down the cause if needed.

It would be great

Is there anyway to create a branch version of the obfuscator.io web obfuscate and evaluate?
This will help to speed up finding the problem.

you can just clone this repo
https://github.com/javascript-obfuscator/javascript-obfuscator-ui

Try to disable self defending, domain lock, debug protection. Error still happens?

Updated PR. Please try now #555.

Self defending, domain lock, debug protection is disabled when I tested this.

Oh, to be clear, comment in https://github.com/javascript-obfuscator/javascript-obfuscator/issues/550#issuecomment-585213719 is referring to the variable-preserve-improvements branch.
And I just tested new-mangled-names-generator the error is:

Identifier 'b' has already been declared

The new-mangled-names-generator branch have same bug as https://github.com/javascript-obfuscator/javascript-obfuscator/issues/550#issuecomment-583743033

Hmm. Cant reproduce
https://github.com/javascript-obfuscator/javascript-obfuscator/issues/550#issue-561958467
and
https://github.com/javascript-obfuscator/javascript-obfuscator/issues/550#issuecomment-583743033

So which branch to test on? Then I'll check it out when I'm free.

new-mangled-names-generator. This branch contains all changes from variable-preserve-improvements and also I re-implemented much smarter idenitiferNamesGenerator: 'mangled'.
So, with new idenitiferNamesGenerator: 'mangled' implementation I got few Identifier 'b' has already been declared errors, related to the debugProtection, selfDefending and domainLock options. But I fixed it with the last commit, and after that, I asked you to test this branch.
So, it looks like there is something else, that I did not catch.

I tried pulling the branch (into my node_modules replacing the javascript-obfuscator directory) and re-run it but still getting result as above.

Can you show your options, and code if possible?

Options as below:
    target: 'node',
    identifierNamesGenerator: 'mangled',
    rotateStringArray: true,
    splitStrings: true,
    splitStringsChunkLength: 15,
    stringArray: true,
    stringArrayEncoding: 'base64',
    stringArrayThreshold: 0.9,
    shuffleStringArray: true,
    transformObjectKeys: true,

The rest is false. For code, I will need to prepare first.

Merged new-mangled-names-generator to the variable-preserve-improvements branch. Now all tests should be on variable-preserve-improvements

Testing on latest variable-preserve-improvements branch, it seems that it goes into infinite loop.

Please, provide options each time when something wrong, because i have no idea what is wrong without options and details.

I fixed another problem. You can try again. Not sure if it helps btw.

My tests are passed. So, if you still have any problems, i need to know how to reproduce it, because without it i can't write regression tests and fix it.

Hi @sanex3339, the options I used is the same as https://github.com/javascript-obfuscator/javascript-obfuscator/issues/550#issuecomment-585602790.
Just tested the latest also going to an infinite loop.
One note, I can't find which file is causing this because the CLI output will list all the files like: [javascript-obfuscator-cli] Obfuscating file: ... upfront rather than showing the file name when it starts to process on that file.

You can try again.
I spent a whole day to fix many bugs. Changed a huge amount of things.
I added more runtime tests: webpack bootstrap code, and now in tests, I obfuscate obfuscator itself.
These tests allowed me to find and fix many bugs.
Also, I had to rework the self-defending code, so now it slightly smaller. And when the self-defending mechanism will be triggered, it will freeze the browser without the maximum call stack error.

Appreciated your time spent. However, it is still the same. I turned on the log but there's no filename in the log.
The only info I found is it stuck at Preparing... stage.
Will be helpful if the filename is included in the log.
Hope this helps.
[A lot more logs above...]

[javascript-obfuscator] Version: 0.25.0

[javascript-obfuscator] Obfuscation started...

[javascript-obfuscator] Random generator seed: 344031425...

[javascript-obfuscator] Transformation stage: Initializing...

[javascript-obfuscator] Transformation stage: Preparing...

[javascript-obfuscator] Transformation stage: Converting...

[javascript-obfuscator] Transformation stage: Obfuscating...

[javascript-obfuscator] Transformation stage: Finalizing...

[javascript-obfuscator] Obfuscation completed. Total time: 1.797 sec.

[javascript-obfuscator] Version: 0.25.0

[javascript-obfuscator] Obfuscation started...

[javascript-obfuscator] Random generator seed: 156613164...

[javascript-obfuscator] Transformation stage: Initializing...

[javascript-obfuscator] Transformation stage: Preparing...

[javascript-obfuscator] Transformation stage: Converting...

[javascript-obfuscator] Transformation stage: Obfuscating...

[javascript-obfuscator] Transformation stage: Finalizing...

[javascript-obfuscator] Obfuscation completed. Total time: 0.031 sec.

[javascript-obfuscator] Version: 0.25.0

[javascript-obfuscator] Obfuscation started...

[javascript-obfuscator] Random generator seed: 127309717...

[javascript-obfuscator] Transformation stage: Initializing...

[javascript-obfuscator] Transformation stage: Preparing...

So, it stucked during obfuscation? Not during code evaluation?

Testing on latest variable-preserve-improvements branch, it seems that it goes into infinite loop.

I'mabout this comment

I added build time to the version message.
Could you update from this branch again and show me log messages with the version?
I want to be sure that you're using the latest build.

Sorry for not being clear enough, yes it stuck during obfuscation.
Below is the latest log and stuck in the Preparing...
[javascript-obfuscator] Version: 0.25.0_2020-02-16T21:43:37.017Z

[javascript-obfuscator] Obfuscation started...

[javascript-obfuscator] Random generator seed: 410740464...

[javascript-obfuscator] Transformation stage: Initializing...

[javascript-obfuscator] Transformation stage: Preparing...

Hi. Any news about the possibility of providing your code for me to debug?

I will send you by email. Also for the infinite loop, I'm still waiting for the log that includes the filename that is being processed.
So, I can narrow down the exact file that cause this problem.

About the filename, how did you use obfuscator? Via CLI, node API or webpack plugin?
Currently, filenames should works only via CLI

Will add file name to the log

How did you obfuscate your code? Via CLI, node.js API or plugin?
Because currently via CLI you should have an output like:
[javascript-obfuscator-cli] Obfuscating file: test/a.js...

[javascript-obfuscator-cli] Obfuscating file: test/b.js...

I'm using CLI with command as below:
javascript-obfuscator dist --config ./config.js --exclude node_modules --output obfuscated

Cannot reproduce.
For me it shows file paths:
[javascript-obfuscator-cli] Obfuscating file: dist/a.js...

[javascript-obfuscator-cli] Obfuscating file: dist/b.js...

So, the problem here
https://github.com/javascript-obfuscator/javascript-obfuscator/blob/master/src/cli/utils/SourceCodeReader.ts#L116
But i have no idea why did you get an empty path here.

No. The main app shouldn't know about the file name.
I will output the file name only on the CLI side

The problem is that it shows all Obfuscating file messages at first and only after that - log messages of the obfuscation stages

I will fix it in a few hours

I updated it. Now the file names should display in the correct places

Hi. Any news? This is the only reason why I still didn't merge this PR to the master branch

Yes, just emailed to you.

I didn't get anything on my primary mail sanex3339 a t yandex and javascript-obfuscator a t yandex

Found the problem with Identifier 'a' has already been declared.
Will try to fix it

But what about infinity loop?

Updated. Try now.

Latest test looks good. Test based on https://github.com/javascript-obfuscator/javascript-obfuscator/issues/550#issuecomment-585602790
No more errors and infinite loop. Thanks.

Finally! Thank you for the help!
I think i will release beta version later today or tomorrow

Actually why not? Released as 0.25.0 just a few seconds ago. Thank you again for your help!

Hi, apparently this will cause c[a139b(...)] is not a function error if I disable transformObjectKeys.

Can you send a file?

You can use the same file.

Will try. Options as described above, but without transform object keys?

Yes.

Hi. Tried a few times with options:
module.exports = {
    compact: false,
    target: 'node',
    identifierNamesGenerator: 'mangled',
    rotateStringArray: true,
    splitStrings: true,
    splitStringsChunkLength: 15,
    stringArray: true,
    stringArrayEncoding: 'base64',
    stringArrayThreshold: 0.9,
    shuffleStringArray: true
};

I commented this lines:
/*const extend = require("extend");
const primitives_1 = require("lib/primitives");
const utils_1 = require("lib/utils");
const part_1 = require("lib/sql/part");
const util_1 = require("util");*/

And just tried to evaluate code with node.js:
node index-obfuscated.js --config coonfig.js

No errors for me

Code to reproduce:
function foo() {
  var foo = 1;

  return () => {
  	const { a } = {a: 3};

    console.log(foo, a);
  };
}
foo();

The fix here:
https://github.com/javascript-obfuscator/javascript-obfuscator/pull/562

Tested and it works. Thanks.

Released as 0.25.1


Some issues with using pyppeteer to call draw_mermaid_png

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangGraph/LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangGraph/LangChain rather than my code.
[X] I am sure this is better as an issue rather than a GitHub discussion, since this is a LangGraph bug and not a design question.

Q1: When your diagram contains overly long mermaid syntax, it's impossible to use the API to render the mermaid diagram
from langgraph.graph import MessagesState, StateGraph

workflow = StateGraph(MessagesState)
workflow.set_entry_point("foo")
workflow.add_node("foo", lambda _: None, metadata={"foo": "bar" * 3000})
workflow.set_finish_point("foo")
app = workflow.compile()

app.get_graph().draw_mermaid_png(output_file_path="123.png")

  File "...../python3.12/site-packages/langchain_core/runnables/graph.py", line 606, in draw_mermaid_png
    return draw_mermaid_png(
           ^^^^^^^^^^^^^^^^^
  File ..../python3.12/site-packages/langchain_core/runnables/graph_mermaid.py", line 215, in draw_mermaid_png
    img_bytes = _render_mermaid_using_api(
                ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "...../python3.12/site-packages/langchain_core/runnables/graph_mermaid.py", line 338, in _render_mermaid_using_api
    raise ValueError(
ValueError: Failed to render the graph using the Mermaid.INK API. Status code: 400.

Q2: Unable to use pyppeteer to render mermaid in the main thread's event loop
from langchain_core.runnables.graph import MermaidDrawMethod
from langgraph.graph import MessagesState, StateGraph

app = StateGraph(MessagesState).compile()

async def main() -> None:
    app.get_graph().draw_mermaid_png(
        output_file_path="123.png", draw_method=MermaidDrawMethod.PYPPETEER
    )

if __name__ == "__main__":
    import asyncio

    asyncio.run(main())

RuntimeError: asyncio.run() cannot be called from a running event loop
sys:1: RuntimeWarning: coroutine '_render_mermaid_using_pyppeteer' was never awaited

Q3: When using pyppeteer and input() simultaneously, it cannot be interrupted
from langchain_core.runnables.graph import MermaidDrawMethod
from langgraph.graph import MessagesState, StateGraph

pyppeteer = MermaidDrawMethod.PYPPETEER
app = StateGraph(MessagesState).compile()

# It can normally exit using Ctrl + C.
# app.get_graph().draw_mermaid_png(output_file_path="123.png")

# It cannot exit using Ctrl + C, and if you forcibly close the terminal,
# the program continues to run, and resources like DB connections are not released.
app.get_graph().draw_mermaid_png(output_file_path="123.png", draw_method=pyppeteer)

try:
    while True:
        temp = input("Enter: ")
        print(temp)
except KeyboardInterrupt:
    print("Exit")

Description
Q1
For the first issue, since the API request uses a GET request, if your mermaid syntax is too large (a very big graph), the request will fail.
Current solution: Use local pyppeteer.
Question: Is there a similar POST request that can accommodate a larger content length?
Q2
For the second issue, calling _render_mermaid_using_pyppeteer uses an asynchronous method that creates an event loop. However, if this method is called within an existing event loop, it will not execute.
Current solution: Move the function to a synchronous block.
Question: Can you provide an asynchronous method or solve the event loop issue?
Q3
Mysterious error?
When using pyppeteer alone, it terminates normally.
When using the API with input(), it also terminates normally.
However, when using pyppeteer with input(), it cannot be interrupted(use ctrl + C), and even if the terminal is forcibly closed, the process persists, and resources cannot be released.

System Info
langchain-core==0.3.6
langgraph==0.2.28
pyppeteer==2.0.0
plaform==linux
python-version==3.12.6

Should be in langchain-core i have an outstanding PR to fix this, will try to fix next week

Should be in langchain-core i have an outstanding PR to fix this, will try to fix next week

I'm curious about what causes the issue with Q3.
It works fine on its own, but when used together with input(), the program becomes uninterruptible.
I'm not sure if anything other than input could trigger this problem.

Not sure about Q3, for Q2 you could also try doing below (for interactive/notebook workflows)
import nest_asyncio
nest_asyncio.apply()


Granite and Sandstone hard to tell apart

Created for CtlAltDel
"would be great if we had a little bit more contrast between sandstone and granite."
Describe the bug
Sandstone and Granite have minimal differences making them harder to mine
they are also untextured
To Reproduce
Go to a granite mine in the Kharidian Desert
Expected behavior
Colors more similar to vanilla
Screenshots

Current Sandstone and Granite

Should be fixed by #122

fixed by merged #122


Update to latest MessageHub.Client to re-establish communication with MessageHub after breaking changes were introduced

Acccording to team Titans MessageHub communication has breaking changes from 26th of November.
We'll need to fix this.
See this post:

Tested on U002 that peek still works


Remove VSRC1 projects

Once we have successfully signed bits we should remove the VSRC1 projects.
Commits to revert (in dev and release):
https://github.com/aspnet/Caching/commit/88cd18e169a3c3a0f284f13ec3530de18e2a901d
https://github.com/aspnet/Caching/commit/8a39f14ea115a2888e85bb5f7b5406d5bebd04da
https://github.com/aspnet/Caching/commit/fe08daa4ea2693b943c4e771d09a77fef87b9377

https://github.com/aspnet/Caching/commit/473d4b96b5661c8846b93ea2152a1aa00f5b643a


VIDSCS-47: stop stream overlay should go away when stopping a ScreenToCanvas publisher

The "stop sharing" overlay doesn't go away when you stop a ScreenToCanvas publisher. This is because we were making a GDM request but never stopping the actual tracks we got from this call.
To test:
To reproduce:

Run meet locally
Press the screenshareCanvas button and select a tab. See that a stop screenshare overlay appears at the bottom of your screen as in the image.

Press the screenshareCanvas button again. Note that the publisher goes away but the overlay doesn't.

To test the fix:

Copy the content of opentok-angular.js to the same file in your local meet node-modules.
Repeat the above steps and verify that the overlay does go away when stopping the screenshareCanvas publisher.

tested LGTM!! 🚀🚀


validate raise error jsonschema.exceptions.ValidationError: 'triggers' is a required property

I did the stackstorm Installation in Ubuntu VM with the one line installation. I'm integrating this with the prometheus. So from prometheus the alert is sent to alertmanager and from there its posting to stackstorm webhook. When the alert triggers, its able to push the data to stackstorm and the webhook instance is getting triggered, however the rule is not getting executed. Please find below the Rules and Action I have defined.
Rules:

name: "prometheus_integration_rule"
pack: "demo"
description: "Prometheus-stackstorm event handler."
enabled: true

trigger:
    parameters:
        url: "demo"
    type: "core.st2.webhook"

criteria:
    trigger.body.alerts[0].labels.alertname:
        type: "startswith"
        pattern : "Disk_usage_kafka"
action:
    ref: "demo.kafka_demo_disk_action"
    parameters:
        payload: "{{trigger}}"

Action:

name: "kafka_demo_disk_action"
pack: "demo"
runner_type: "python-script"
description: "On receiving a trigger, ssh into the problematic hosts and perform some action."

Traceback (most recent call last):
File "/opt/stackstorm/st2/lib/python3.8/site-packages/st2reactor/rules/enforcer.py", line 100, in enforce
execution_db = self._do_enforce()
File "/opt/stackstorm/st2/lib/python3.8/site-packages/st2reactor/rules/enforcer.py", line 165, in _do_enforce
return self._invoke_action(
File "/opt/stackstorm/st2/lib/python3.8/site-packages/st2reactor/rules/enforcer.py", line 258, in _invoke_action
liveaction_db, execution_db = action_service.request(liveaction_db)
File "/opt/stackstorm/st2/lib/python3.8/site-packages/st2common/services/action.py", line 210, in request
liveaction, execution = create_request(liveaction)
File "/opt/stackstorm/st2/lib/python3.8/site-packages/st2common/services/action.py", line 117, in create_request
util_schema.validate(
File "/opt/stackstorm/st2/lib/python3.8/site-packages/st2common/util/schema/init.py", line 350, in validate
jsonschema.validate(instance=instance, schema=schema, cls=cls, *args, **kwargs)
File "/opt/stackstorm/st2/lib/python3.8/site-packages/jsonschema/validators.py", line 541, in validate
cls(schema, *args, **kwargs).validate(instance)
File "/opt/stackstorm/st2/lib/python3.8/site-packages/jsonschema/validators.py", line 130, in validate
raise error
jsonschema.exceptions.ValidationError: 'triggers' is a required property
Failed validating 'required' in schema['properties']['triggers']:

You have specified in your action definition that you want a parameter called triggers to be passed to it:
name: "kafka_demo_disk_action"
pack: "demo"
runner_type: "python-script"
description: "On receiving a trigger, ssh into the problematic hosts and perform some action."
enabled: true
entry_point: "kafka_demo_disk_action.py"
parameters:
triggers:
type: "string"
description: "Trigger received"
required: true
output_schema:
result:
type: "string"

But when you call your action from your rule you don't pass a parameter called triggers to it, you are passing a parameter called payload to it:
action:
   ref: "demo.kafka_demo_disk_action"
   parameters:
       payload: "{{trigger}}"

So you need to make sure you use the same parameter name in your action definition and the name of the parameter you are passing to the action.

Thanks @amanda11 It worked

I am currently planning to use p rometheus as well, can you share your best practices with me? @Anz14


#9 App crashes when open budget category

If category was added after budget, pressing on budget category details causes app crash

Resolved


Prompt for unspecified flags

Some flags are required. We should prompt the user for them if they aren't specified.

The number of flags were reduced so this isn't as important now. Will revisit if needed.


Remove v1 profile labels

Felix Calculation Graph: use v3 Profile instead of v1 ProfileLabels
Felix Syncer: stop sending v1 profile labels, as no longer needed
Remove ProfileLabelsKey infrastructure, which is now unused

Strictly speaking this is going to introduce an incompatibility with old versions of Typha I believe, but those versions should be sufficiently old enough now that I don't think it matters.
Still worth a quick spin with a mismatched version (e.g., off by one minor version) if we don't already have such an automated test case.

@caseydavenport Thanks, good thought.  It should be good because we have been streaming the whole v3.Profile resource (as well as the v1 pieces) for a long time now.  Do you know what options or existing setup we have for running that kind of version skew test?

@neiljerram whoops! Missed your comment.
I'm not sure what options there are besides installing an old version of Typha and a new version of calico/node on a cluster by hand. I think it's safe to merge this without that test though, since as you say v3 profiles have been coming across for a long time now.
I don't even know what sort of version skew you'd need to test, but it's probably not supported anyway now that I think about it :laughing:


Add basket icons to the UI icons collection

Add an icon to indicate "add to basket" action. A shopping cart icon I think is what better fit the need

https://github.com/wfp/carbon-icons/commit/a77dc491e5f4df9870ff0044decb4495271e1836 added in v0.075


Remove support for the netebpfext's XDP hook in ebpf-for-windows

Describe the feature you'd like supported
Currently, ebpf-for-windows has netebpfext extension that supports XDP.
This enhancement request is to move the existing netebpfext's XDP support in ebpf-for-windows, so it can be integrated with xdp-for-windows with the native xdp extension supported.
Proposed solution
Instead of removing the existing support of XDP in netebpfext extension, the following steps are proposed:
a.	Add a new program and attach type: BPF_PROG_TYPE_XDP_TEST and BPF_XDP_TEST in eBPF headers and create new GUIDs for EBPF_PROGRAM_TYPE_XDP_TEST and EBPF_ATTACH_TYPE_XDP_TEST respectively.
b.	Implement necessary changes in netebpfext to use the TEST versions in its program information.
c.	Modify the program information export tool to export _TEST variants of XDP.
d.	Adjust the xdp_tests to override the program type and attach type.
Additional context
No response

This issue will be addressed in two parts. The first change is PR #3040, which removes the 'XDP' hook from netebpfext and converts the functionality to an XDP_TEST hook type.
Once the full XDP functionality is migrated to XDP for windows, then a follow up change in this repo should be taken to remove XDP_TEST functionality from netebpfext.

As mentioned in #3088, we should make sure to update any documentation once xdp_test is removed (to ensure that our samples accurately show debugging samples from in-repo extensions, such as sample_ext)

See also #3212


chore: bench: large simp_arith task

This PR adds a simp_arith benchmark.
This benchmark highlights some improvable asymptotics in Nat.Linear, which
will be fixed subsequently.

!bench


build: add js lib tests to ci

Adds running of the knora-api-js-lib tests to the Makefile and Github CI
the passing of these tests cannot be made mandatory knora-api, because the dependency is the other way around. The reviewer, before approving a PR, needs to make sure, that a PR is in place and ready for merging in knora-api-js-lib.
--
resolves #1554
resolves #1599

The JS Lib Tests test is failing because there are some missing changes from a pending branch in knora-api-js-lib that provides the code that is missing. The branch in knora-api-js-lib can only be merged if this branch gets merged first.

FAILED TESTS:
2457
  ResourcesEndpoint
2458
    method createResource
2459
      ✖ should create a resource with values
2460
        HeadlessChrome 80.0.3987 (Linux 0.0.0)
2461
      Error: Expected $['http://<IP_ADDRESS>:3333/ontology/0001/anything/v2#hasDecimal']['http://api.knora.org/ontology/knora-api/v2#decimalValueAsDecimal']['@value'] = '1.5' to equal '100000000000000.000000000000001'.
2462
          at <Jasmine>
2463
          at UserContext.<anonymous> (src/api/v2/resource/resources-endpoint.spec.ts:243:36 <- src/api/v2/resource/resources-endpoint.spec.js:290:48)
2464
          at <Jasmine>
2465

This is a problem with precision in JavaScript (https://github.com/dasch-swiss/knora-api-js-lib/issues/126). Until this is fixed, the test data for "http://<IP_ADDRESS>:3333/ontology/0001/anything/v2#hasDecimal" should be something whose precision can be correctly represented without an additional lib. Maybe you can ask @benjamingeer to change the test data for now.

So far, I have just fixed this manually in the test data. But because your tests generate everything automatically, this hack fails here.

@benjamingeer @subotic I think all that has to be done to make this PR work is changing the test value for http://<IP_ADDRESS>:3333/ontology/0001/anything/v2#hasDecimal in "v2/resources/create-resource-with-values-request.json" from "100000000000000.000000000000001" to "1.5". The precision issue will be dealt with in https://github.com/dasch-swiss/knora-api-js-lib/issues/126 and additional unit tests can be added to check for the correct handling of precision, but those could be independent from Knora (no additional generated test data needed).

@tobiasschweizer That request is also used to test Knora. I thought that was the whole idea here: we use the same request to test Knora and to test the client code. If we change it to 1.5, we're not testing Knora's handling of decimal precision.

That request is also used to test Knora. I thought that was the whole idea here: we use the same request to test Knora and to test the client code. If we change it to 1.5, we're not testing Knora's handling of decimal precision.

I understand. So should be patch the test data after its generation until https://github.com/dasch-swiss/knora-api-js-lib/issues/126 is done?

generate test data
parse JSON
manipulate the value in question
serialize it back

I think I could write a script that could be called from npm run.

@tobiasschweizer How about just disabling that test until https://github.com/dasch-swiss/knora-api-js-lib/issues/126 is done?

The problem is that this affects the test for resource creation: https://github.com/dasch-swiss/knora-api-js-lib/blob/da6f34514f33e64d1734ae9d2d37c21f958be2af/src/api/v2/resource/resources-endpoint.spec.ts#L111-L245
It's not a test that is specific to decimal values.

The problem is that this affects the test for resource creation

OK, but it seems to me that if you can't create a resource with a decimal value, you can't create a resource, so that test should fail or be disabled.

Let's say that I give it a try and if it takes too much time to write the script, I will think you disabling the test.

if you can't create a resource with a decimal value

You absolutely can. The problem is just that precision is lost in JS with the given decimal number.

The problem is just that precision is lost in JS with the given decimal number.

But that's a bug. If there's a bug, then I think the test should fail or be disabled.

But that's a bug. If there's a bug, then I think the test should fail or be disabled.

It's the way JS can handle precision without any additional libraries or workarounds.

It's the way JS can handle precision without any additional libraries or workarounds.

I could imagine various ways of dealing with this in JS, including using a string rather than a number. But from the user's point of view, that's irrelevant. If the resource creation test passes, the user should be able to trust that they can create a resource with any value type and get the expected result. If that's not true, the test should fail.

@benjamingeer thanks for the review :-) I will merge this. Whatever else needs to be done, can then be done in a different PR.


Second press of CMD+A should select parent list after instead of selecting whole tree

On second thought, I think this feature would be unnecessarily complicated since child nodes don't usually have information about their parents. It seems that other outlining apps work as your plugin does now. I think that is more than enough—thank you very much!


support passing a FileCollection

Currently you can only pass a single root directory, plus list of files.
Using a gradle FileCollection would give the user much more control, as we could exclude certain directories.

that's a good idea. I'm currently (too) busy with other things - but I'd very much like to support you, if you like to approach this issue...
thanx for your interest in htmlSC, Gernot

I'm looking into providing a PR with this. In my opinion this requires a bigger change and I would like to confirm with you, @gernotstarke, that you're happy with what I would like to do:

remove Configuration.ITEM_NAME_sourceDir and change Configuration.ITEM_NAME_sourceDocuments to be treated as a collection of Files
remove sourceDir from HtmlSanityCheckTask
change sourceDocuments on HtmlSanityCheckTask to be a org.gradle.api.file.FileCollection which is easy to be turned into a set of Files using its getFiles() method and use that in HtmlSanityCheckTask.setupConfiguration()
pass the value of Configuration.ITEM_NAME_sourceDocuments straight through in AllChecksRunner's constructor instead of using FileCollector.getHtmlFilesToCheck()
remove all FileCollector.getHtmlFilesToCheck() methods together with any methods that are only used from them and any tests exercising the removed code
change the existing examples in readme to use Project.fileTree() so that they exactly match the current logic with regards to recursively finding files in sourceDir as well as matching files by names specified in sourceDocuments

These are obviously breaking changes but I believe that they will provide a much more flexible mechanism for specifying which files to check compared to what's currently there thanks to using the outstanding finding and filtering capabilities of Gradle's FileCollection API.

@erdi, thank you so much for your structured proposal: Yes, I'm perfectly happy with your suggestions, they sound plausible to me.
I'm honored to have you "on board"...
(with your massive experience in testing: in case you have any suggestions on how to better and/or more effectively test htmlSC - please feel free...)
regards, Gernot

Thanks for confirming that you’re happy with the proposed changes.
Hopefully I will find some time tomorrow to make them and submit a PR.
I’m not sure what you mean by me “being on board” but we are using your
sanity checker on a project at work and I’m just contributing back changes
that we had to apply in a custom built artifact to be able to use it. I
hate custom builds and forks and it makes me very happy that contributing
back to the project has been so swift so far - thanks for being so
responsive to issues and PRs.
With regards to testing I’m not sure I see anything standing out that would
need changing. I was very positively surprised that an integration test
using GradleRunner has already been in place as I’m used to writing one
from scratch when contributing back to Gradle plugin projects.
On Sat, 9 Feb 2019 at 17:25, Dr. Gernot Starke<EMAIL_ADDRESS>wrote:

@erdi https://github.com/erdi, thank you so much for your structured
proposal: Yes, I'm perfectly happy with your suggestions, they sound
plausible to me.
I'm honored to have you "on board"...
(with your massive experience in testing: in case you have any suggestions
on how to better and/or more effectively test htmlSC - please feel free...)
regards, Gernot
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aim42/htmlSanityCheck/issues/264#issuecomment-462062801,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMii3YdNjuzJ2rRvzZtAErzsT2o-QVvks5vLwSbgaJpZM4ankEO
.

I'd suggest using ConfigurableFileCollection instead, to start making use of lazy configuration:
https://docs.gradle.org/current/userguide/lazy_configuration.html

I might be missing something but as far as I understand what I suggested will not prevent you from assigning a ConfigurableFileCollection to HtmlSanityCheckTask.sourceDocuments if you so wish. I also don't see why my proposal would be at odds with using lazy configuration. Can you please elaborate, @thc202?

That one can set a ConfigurableFileCollection into HtmlSanityCheckTask.sourceDocuments does not make it a lazy property (thus one is still with the same problems that lazy configuration meant to solve).

I find being able to use FileCollection API for specifying which files to check and changing properties on HtmlSanityCheckTask to org.gradle.api.provider.Property (as that is what I believe you are suggesting, @thc202, albeit in a very convoluted way) to be two orthogonal concerns.

While I think using lazy properties everywhere (it makes sense) is the ultimate goal I was not suggesting that. I just suggested using ConfigurableFileCollection instead of FileCollection, it was a quick win, especially since the API is already being broken. (Granted I was not explicit on the whole changes required (i.e. making sourceDocuments final also) but linked to the documentation which shows that.)

have you "on board"...

Marcin, by "on board" I meant that I feel honoured having you as contributor.

I think I now understand what you meant. Instead of making
sourceDocuments a writable FileCollection you suggest making it a read
only ConfigurableFileCollection initialized to a FileTree based on
sourceDir. I will submit a PR with such change.
On Sun, 10 Feb 2019 at 17:00, thc202<EMAIL_ADDRESS>wrote:

While I think using lazy properties everywhere (it makes sense) is the
ultimate goal I was not suggesting that. I just suggested using
ConfigurableFileCollection instead of FileCollection, it was a quick win,
especially since the API is already being broken. (Granted I was not
explicit on the whole changes required (i.e. making sourceDocuments final
also) but linked to the documentation which shows that.)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aim42/htmlSanityCheck/issues/264#issuecomment-462151235,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMii2sRbdI6WYjterNFtn4JohSNLtbxks5vMFAogaJpZM4ankEO
.


Tests coverage

Highest coverage as we can do.

Could you please help me with it? :smiley: @hranicka @haltuf

I wonder - does it make sense to create tests for something that is created and managed by someone else (i.e. gopay itself, in this case)?
I'm not even sure, if it is possible: you will have to mock \SoapClient object to reach satisfactory tests coverage. @f3l1x

I see 2 cons on it.

We will see BC breaks and new stuff.

Basic coverage could helps with 100% understanding and usage of API.

Alright. Any idea how to mock \SoapClient without having to touch the inner structure of the classes?

I think the only way how to do it right is refactor classes first.

There is static code usage (usage of GopayConfig, GopayHelper) - we should use mocks of these classes.
Echo? https://github.com/Markette/GopayApi/blob/master/src/GopayHTTP.php#L49
\SoapClient

In my opinion, deeper refactoring for Unit tests will be necessary.
The code looks old (originally - "var" properties: https://github.com/Markette/GopayApi/commit/8ac44f1efa8df7270207d281e86a5492e0e6edb9#diff-ddaeb08b83402a1d4c9f4cd1bf65aaf2L9).

This is what I was worried about.. If we refactor official API, then every upcoming update will require more and more changes (in fact, they may diverge in time) - this is the reason why I initially dismissed the idea to write tests for this part when it used to be included in Markette\Gopay.
The question is: does the increased complexity/work connected with unit tests & neccessary refactoring be outweighed by the benefits of this approach? I'm rather sceptical about it (on the other hand, I do not want to sound like a grouch)

If you want to refactor original classes made by Gopay themselves, I would rather contact them first. @haltuf has very good point.

Ahmm, I have concidered once again and you're right. I'll keep current tests.
So, we can tag version v2.5 and use it in gopay:master. Right?

Current GopayApi should be OK for gopay:master .
But we should inspect the code (IDE helps) if everything is really OK (eg. called methods exist etc).

It's time for a new release, we could push it to master for now.
Did you find any IDE errors or warnings? @hranicka

@f3l1x I can check it today evening. I do it on new branch of https://github.com/Markette/Gopay and make pull request to master if everything will be OK? Than you can release new version.

@hranicka :+1:

Everything seems OK.
I've released GopayApi v2.5.0.
Closing this issue?

Sure. Great.


SSL verification fails

ipa distribute:hockeyapp -a xxx -i xxx -r alpha -f xxx.ipa -d xxx.app.dSYM.zip -m "" --notify --verbose --trace
I get the following error message:

http.rb:923:in `connect': SSL_connect returned=1 errno=0 state=SSLv3 read server certificate B: certificate verify failed

Does anybody has the same problem? I'm on latest Yosemite and use ruby 2.2.0 installed with homebrew.

same problem here

This most likely indicates that HockeyApp's API is not serving valid SSL certificates. You should contact their support to get this resolved.

hi @mattt - is this possible even though the upload is successful using the HockeyApp API directly from the command line using curl and https? doesn't that suggest that their API is working fine?

The bug is in fact not related to either shenzen or hockey app's SSL certs.  But posting this here to help others having the same issue.
Fix
From https://github.com/Homebrew/homebrew/issues/32251#issuecomment-71938608
Removing the expired certificate fixes it
 sudo security delete-certificate -Z 2F173F7DE99667AFA57AF80AA2D1B12FAC830338/System/Library/Keychains/SystemRootCertificates.keychain
 brew postinstall openssl

Some debugging steps
Test with ssl-doctor
Before
ruby doctor.rb upload.hockeyapp.net:443
OpenSSL 1.0.1i 6 Aug 2014: /usr/local/etc/openssl
SSL_CERT_DIR=""
SSL_CERT_FILE=""

HEAD https://upload.hockeyapp.net:443
OpenSSL::SSL::SSLError: SSL_connect returned=1 errno=0 state=SSLv3 read server certificate B: certificate verify failed

The server presented a certificate that could not be verified:
  subject: /C=BE/O=GlobalSign nv-sa/OU=Root CA/CN=GlobalSign Root CA
  issuer: /C=BE/O=GlobalSign nv-sa/OU=Root CA/CN=GlobalSign Root CA
  error code 10: certificate has expired

Fix
 sudo security delete-certificate -Z2F173F7DE99667AFA57AF80AA2D1B12FAC830338/System/Library/Keychains/SystemRootCertificates.keychain
 brew postinstall openssl

Verify
ruby doctor.rb upload.hockeyapp.net:443
OpenSSL 1.0.1i 6 Aug 2014: /usr/local/etc/openssl
SSL_CERT_DIR=""
SSL_CERT_FILE=""
HEAD https://upload.hockeyapp.net:443
OK

https://github.com/raggi/openssl-osx-ca


NOISSUE - Fix CI to fetch tags

What type of PR is this?

This is a quick fix of CI scirpt.
What does this do?

Since our code build includes the latest Git tag for the Health endpoint, we need to have at least the latest tag available during building binaries in the CI.
Which issue(s) does this PR fix/relate to?

There is no such issue.
Have you included tests for your changes?

N/A
Did you document any new/modified feature?

N/A
Notes

N/A

Unfortunately, fetching tags on this action is still broken: https://github.com/actions/checkout/issues/1471. I had to add a manual step for that.


bruig: Redesign navigation and update settings page

Close #425
This marks a major redesign of the way in which we navigate the mobile app.  This is now more closely aligned to most mobile apps in the marketplace.
Settings and more 'advanced' screens are now located in the upper left corner 'avatar' button.
Next we will put contextual menus in the upper right.

Ah whoops, overlooked that. Will fix.

@miki-totefu ok should be all set now.

Yah it's underneath the debug tag.