Make provider attributes available in bids

The scope of this is larger than just GPU attributes but GPU model is the biggest painpoint at this time.
When deploying for a GPU, the bid engine doesn't return the GPU model or vendor. This is crucial for users to know which provider to choose for which model, especially when deploying with a wildcard in the SDL.
Here's an example of a bid:
{
    "bid": {
        "bid_id": {
            "owner": "akash1...tkvk",
            "dseq": "12793097",
            "gseq": 1,
            "oseq": 1,
            "provider": "akash19p4t9d069nashxre9jg6j60cqlqkvtht6egpc9"
        },
        "state": "open",
        "price": {
            "denom": "uakt",
            "amount": "368.320765000000000000"
        },
        "created_at": "12793100"
    },
    "escrow_account": {
        "id": {
            "scope": "bid",
            "xid": "akash...tkvk/12793097/1/1/akash1...pc9"
        },
        "owner": "akash1...pc9",
        "state": "open",
        "balance": {
            "denom": "uakt",
            "amount": "5000000.000000000000000000"
        },
        "transferred": {
            "denom": "uakt",
            "amount": "0.000000000000000000"
        },
        "settled_at": "12793100",
        "depositor": "akash1...pc9",
        "funds": {
            "denom": "uakt",
            "amount": "0.000000000000000000"
        }
    }
}

Also, if the protobuf types are to change for the bids, I think it would be a great idea to also add the model/vendor chosen on the deployment or lease. Currently on the deployment, we can see the model/vendor requested, but not the one leased.

Also, I think it would be a great idea to have something generic to handle other specs/attributes than GPUs, like the type of CPU offered or memory or disk etc etc. To not have to change the protobuf type later on. Something like an attribute array.

Oct 17 sync: This will need a network upgrade

Nov 7:

Finalized updates to the blockchain and verified that network upgrade works
Once the end-to-end tests and verified, will be able to cut a release
Mainnet upgrade is set for Nov 20th


Error during az storage container generate-sas: self.account_key should not be None

Describe the bug
Command Name
end=`date -d "5 minutes" '+%Y-%m-%dT%H:%M:%SZ'`
`az storage container generate-sas -n '$web' --account-name $1 --https-only --permissions dlrw --expiry $end -otsv`

Note this command is being run in Azure Pipelines (see below for repro steps)
Errors:
WARNING: There are no credentials provided in your command and environment, we will query for the account key inside your storage account.
Please provide --connection-string, --account-key or --sas-token as credentials, or use `--auth-mode login` if you have required RBAC roles in your command. For more information about RBAC roles in storage, visit https://docs.microsoft.com/en-us/azure/storage/common/storage-auth-aad-rbac-cli.
Setting the corresponding environment variables can avoid inputting credentials in your command. Please use --help to get more information.
ERROR: The command failed with an unexpected error. Here is the traceback:
ERROR: self.account_key should not be None.
Traceback (most recent call last):
  File "/opt/az/lib/python3.6/site-packages/knack/cli.py", line 233, in invoke
    cmd_result = self.invocation.execute(args)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 664, in execute
    raise ex
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 727, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 719, in _run_job
    return cmd_copy.exception_handler(ex)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/command_modules/storage/__init__.py", line 338, in new_handler
    raise ex
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 698, in _run_job
    result = cmd_copy(params)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/__init__.py", line 331, in __call__
    return self.handler(*args, **kwargs)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/core/__init__.py", line 816, in default_command_handler
    return op(**command_args)
  File "/opt/az/lib/python3.6/site-packages/azure/cli/command_modules/storage/operations/blob.py", line 666, in generate_container_shared_access_signature
    user_delegation_key=user_delegation_key)
  File "/opt/az/lib/python3.6/site-packages/azure/multiapi/storage/v2018_11_09/blob/baseblobservice.py", line 421, in generate_container_shared_access_signature
    _validate_not_none('self.account_key', self.account_key)
  File "/opt/az/lib/python3.6/site-packages/azure/multiapi/storage/v2018_11_09/common/_error.py", line 130, in _validate_not_none
    raise ValueError(_ERROR_VALUE_NONE.format(param_name))
ValueError: self.account_key should not be None.
To open an issue, please run: 'az feedback'

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.
Create an Azure DevOps Pipeline that uses a stage like this:
parameters:
  - name: appStorageAccountName
    type: string
  - name: azureSubscription
    type: string

stages:
  - stage: Deploy
    displayName: Deploy Artifacts
    jobs:
      - deployment: Deploy
        environment: Dev
        pool:
          vmImage: ubuntu-latest
        strategy:
          runOnce:
            deploy:
              steps:
                - task: AzureCLI@2
                  inputs:
                    azureSubscription: ${{parameters.azureSubscription}}
                    scriptLocation: inlineScript
                    scriptType: bash
                    inlineScript: |
                      end=`date -d "5 minutes" '+%Y-%m-%dT%H:%M:%SZ'`
                      sas=`az storage container generate-sas -n '$web' --account-name $1 --https-only --permissions dlrw --expiry $end -otsv`
                    arguments: ${{parameters.appStorageAccountName}}
                  displayName: Generate SAS

Expected Behavior
No error. This was passing 3 hours ago for us and now it is failing consistently. Output still contains the warning, but it succeeded with no ERRORs:
WARNING: There are no credentials provided in your command and environment, we will query for the account key inside your storage account.
Please provide --connection-string, --account-key or --sas-token as credentials, or use `--auth-mode login` if you have required RBAC roles in your command. For more information about RBAC roles in storage, visit https://docs.microsoft.com/en-us/azure/storage/common/storage-auth-aad-rbac-cli.
Setting the corresponding environment variables can avoid inputting credentials in your command. Please use --help to get more information.

Environment Summary
Azure Pipelines hosted agent ubuntu-latest
Details from az-version:
azure-cli                         2.19.1 *

Please let us know how we are doing: https://aka.ms/azureclihats
and let us know if you're interested in trying out our newest features: https://aka.ms/CLIUXstudy

core                              2.19.1 *
telemetry                          1.0.6

Extensions:
azure-devops                      0.18.0

Python location '/opt/az/bin/python3'
Extensions directory '/opt/az/azcliextensions'

Python (Linux) 3.6.10 (default, Feb 10 2021, 05:17:27)
[GCC 9.3.0]

Additional Context

Note, I was able to install a newer version 2.20.0 in the Azure Pipelines hosted agent via:
sudo apt-get update
sudo apt install -y --allow-downgrades azure-cli=2.20.0-1~focal

However this didn't fix the issue.

storage

Hi @adiun. Thanks for reaching out to us.
As you can see from the WARNING message, we will query for the account key inside your storage account as only account name is provided and the storage server need credentials to authenticate. If we can't succeed to query account key from the account name provided, then the command will fail.
Most likely --account-name $1 reference some not existing storage account. Can you run az storage account keys list --account-name $1 to check whether the account exist or not and whether querying account key succeed or not.

As I noted in #9346 -
I can verify this issue occurs when you try to run the command and your AZ is logged in to a different subscription than where your storage account is.
The thing is users do not understand why it suddenly occurs and why the command just stops working (and the error message is misleading).
I think the error message should be more descriptive (not just a key error failure) and say something like "Make sure you are logged in to the same subscription as your storage account is in"

Yes, the storage account didn't exist in that subscription which caused this error. Sorry for the delay in follow-up.
I totally agree with @bondib - the error message needs to be fixed since it made me think there was some internal error, especially since it contains:
ERROR: The command failed with an unexpected error.
To open an issue, please run: 'az feedback'

@evelyn-ys will fix the error message in this sprint.

Thanks @bondib @adiun
PR #17200 has added warning message like this:
> az storage container generate-sas --account-name notexist -n mycontainer
There are no credentials provided in your command and environment, we will query for the account key inside your storage account.
Please provide --connection-string, --account-key or --sas-token as credentials, or use `--auth-mode login` if you have required RBAC roles in your command. For more information about RBAC roles in storage, visit https://docs.microsoft.com/en-us/azure/storage/common/storage-auth-aad-rbac-cli.
Setting the corresponding environment variables can avoid inputting credentials in your command. Please use --help to get more information.

Skip querying account key due to failure: Storage account 'notexist' not found.
The command failed with an unexpected error. Here is the traceback:
self.account_key should not be None.
Traceback (most recent call last):


Bump Halibut to 5.0.429

Background
Bump Halibut to 5.0.429 to get the changes in https://github.com/OctopusDeploy/Halibut/pull/221

[sc-42761]

Green Server Build for the full chain with this change to Tentacle here https://github.com/OctopusDeploy/OctopusDeploy/pull/17609

@LukeButters I will hold of merging this as you will have changes to halibut coming through soon as well.
Full server chain passed with this bump.
I'll leave it open just incase we do want to merge it but if not we can close it when you bump to halibut lands in tentacle


Breadcrumbs TaxaonID missing

[x] Rename breadCrum to breadCrumbs
[x] Provide taxonId with respective breadcrumb

Fixed by commit https://github.com/strandls/biodiv-taxonomy/commit/b808fc8b224bbf1b54f839eff68083d174e502b4


solving an issue #3

Number 100 bug- issue solved. #3

Thank you @prasoonjain006 . You did a great job!

Glad to solve my first issue @Apoorve73


Implement time-out for unallocated jobs

While testing with https://github.com/mycobactopia-org/MTBseq-nf pipeline, I noticed that the heavy process of TBFULL wasn't allocated to any machine due to occupied resources and this was reflected on the Nextflow side.
I'm thinking there must be a timeout we can implement to manually fail those jobs and then resubmit them.

related #71


Always return "Value cannot be null. Parameter name: source"

First of all, thank your team for developing this wonderful component. I am very excited.
I'm trying it out, but it always gives me an "Value cannot be null. Parameter name: source" in an advise panel.
Is there something wrong with my input?
Token and model were set according to README.
The model is "gpt-3.5-turbo".

environment

win11
ghpt v1.2(via package manager)

Hey @hrntsm can you try running this PR in debug and letting me know what the Advice panel says now?
#3

I got the same error. You have to make sure when you type in the "GPT model*:" that it is the exact same name you have given the generated API key.

Hi @clicketyclackety,
I tried #3 and it works well.

But I couldn't get any meaningful results; I'm trying with GPT-3.5-turbo, so maybe it's a bit predictable and weak.
I have signed up for the GPT-4 waiting list and look forward to testing its capabilities in full.
Thank you for your quick response.

Hi @clicketyclackety,
I tried #3 and it works well.

But I couldn't get any meaningful results; I'm trying with GPT-3.5-turbo, so maybe it's a bit predictable and weak.
I have signed up for the GPT-4 waiting list and look forward to testing its capabilities in full.
Thank you for your quick response.

Awesome @hrntsm , I'll try it myself again and release a new build if it works for me too. Yeah it struggles with rectangles. I think it wants the component but currently it creates a parameter. I'll do some GPT3.5/4 comparisons

Error: 429 Too Many Requests {
"error": {
"message": "You exceeded your current quota, please check your plan and billing details.",
"type": "insufficient_quota",
"param": null,
"code": null
}
}


dep: Updated some dependencies.

Type of change:

[ ] Bugfix
[ ] New feature provided
[ ] Improve performance
[ ] Backport patches
[ ] Documentation
[ ] Refactor
[x] Chore
[ ] CI/CD or Tests

What this PR does / why we need it:

closes: 1729
closes: #1765
closes: #1763
Pre-submission checklist:

[ ] Did you explain what problem does this PR solve? Or what new features have been added?
[ ] Have you added corresponding test cases?
[ ] Have you modified the corresponding document?
[ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Codecov Report

Merging #1782 (666434b) into master (b4d1eed) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 666434b differs from pull request most recent head 88b25ec. Consider uploading reports for the commit 88b25ec to get more accurate results

@@           Coverage Diff           @@
##           master    #1782   +/-   ##
=======================================
  Coverage   39.35%   39.35%
=======================================
  Files          91       91
  Lines        8063     8063
=======================================
  Hits         3173     3173
  Misses       4484     4484
  Partials      406      406

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Use sha384 for jQuery's hash.

@jmervine: can you do the same for /stylesheets/style.css and push to the merge and then merge it?

@XhmikosR Yeah, I'll update everything, everywhere to use 384, over both 256 and 512.

Only stylesheets/style.css is left.

Ah, I see, for some reason I though the assets in public were still 256/512.


Missing mdcheck script

Describe the bug
When swraid is enabled, also systemd timer units mdcheck_start etc are installed. mdcheck_start.service and mdcheck_continue.service include references to /usr/share/mdadm/mdcheck script. But the script is missing in that location. In fact, it's missing from the mdadm closure entirely.
Steps To Reproduce
Steps to reproduce the behavior:

Enable swraid
systemctl cat mdcheck_start, note ExecStart referencing /usr/share/mdadm/mdcheck
Observe that /usr/share/mdadm/mdcheck does not, in fact, exist

Expected behavior
The ExecStart path to point to an existing file.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Nixpkgs 7bba2df68503b68634e0070483ddaf6d59dc6530
Notify maintainers
I guess @ekleog?
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.41, NixOS, 24.05 (Uakari), 24.05.20240728.7bba2df`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.5`
 - nixpkgs: `/nix/store/vmpqgycgppcl0limg2xsl1sbr6d716jx-source`

Add a :+1: reaction to issues you find important.

We're not gonna put stuff in /usr, if anything it should be built with a flag or patched to the correct prefix

The point is, currently broken systemd units are installed. Also, their presence creates a false impression that periodic scrubbing happens on NixOS, which it absolutely does not because the script that does the actual work is nowhere to be found. How exactly that is fixed is secondary, but it needs to be fixed.

Sure systemd services shouldn't point to nonexistent paths, but this is a github issue tracker, of course we will discuss how things should be fixed.


[WIP] on the fly normalization

Enable on the fly normalization command when parsing data before tokenization.
Can be used in tokenize.lua:
th tools/tokenize.lua -normalize_cmd "$PWD/normalize_english.sh" < raw_en.txt > norm_en.tok

and in train.lua - using dynamic dataset options:
th tools/train.lua -train_dir baseline -tok_src_normalize_cmd "$PWD/normalize_english.sh" ...

Also add possibility to display preprocessed/tokenized data during preprocess with -log_level DEBUG:
...
[09/15/17 23:46:38 DEBUG] [90:1] no￨C lunch￨L and￨L sausage￨L in￨L the￨L evening￨L
[09/15/17 23:46:38 DEBUG] [90:2] Kein Frühstück und Wurst zum Abendbrot
...

Codecov Report

Merging #377 into master will decrease coverage by <.01%.
The diff coverage is 86.79%.

@@            Coverage Diff            @@
##           master    #377      +/-   ##
=========================================
- Coverage   71.11%   71.1%   -0.01%
=========================================
  Files          74      74
  Lines        6459    6482      +23
=========================================
+ Hits         4593    4609      +16
- Misses       1866    1873       +7

Impacted Files
Coverage Δ

onmt/utils/FileReader.lua
89.18% <100%> (-0.15%)
:arrow_down:

onmt/data/Preprocessor.lua
92.4% <85.41%> (-0.82%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6426893...77e08b9. Read the comment docs.


Dropdowns covering page content

This is how many dropdowns work, but we certainly can change this if need be.  Let me know your thoughts!  Moving the page content up and down based on the height of the dropdown may be a little disorienting for some users.

Maybe another question is if we should have "hover" or "click" interactions on the dropdowns.  Either are good options!

Added x's to close the dropdowns.  Can retools this anyway we need to, but hopefully this will solve the main part of the problems we were experiencing with the dropdown menu.

The box is good.  The branding ended up going a bit too far though, and the format is all changed
Go back the old format, then:
add our floating nav bar to the top
put the URN box back on the right where it was before. that had a very clean look
you can keep our banner on the top with the manuscript image in the background or you can just use the white background logo but please get rid of the manuscript image for the rest of the page.  If you want to make it look like our other pages, that image is brightened substantially -- see our css https://github.com/CopticScriptorium/CopticScriptorium.github.io/blob/master/scriptorium.css with 	background-color: hsla(40,53%,100%,0.80);  The ms image has an 80% brightness on our homepage for the content box.  Given the format you have here with the rows I recommend eliminating it or fading it out dramatically in the background of the content area.
For now keep the font and the brown background for the menu-- that looks good

Maybe start by eliminating it at least for content.

This looks good.  Thanks! I think ready to close.


Update Lab03_Patient Access & Service Center.md

Module: 00
Lab/Demo: 00
Fixes # .
Changes proposed in this pull request:

Submitted by AnthonyOakley on behalf of MOC Labs Review.


The outputs is empty

I have trained the PSPnet on the VOC datasets according to your steps, and now I need to test the trained model, so I run the command python inference.py --config config.json --model ./saved/PSPNet/10-28_05-10/best_model.pth --images test_images, there are 10 images named *.jpg to be tested, however the outputs is empty, do you know the reason?
`(torch110) jenny@ubuntn:~/pytorch_segmentation$ python inference.py --config config.json --model ./saved/PSPNet/10-28_05-10/best_model.pth --images test_images/
0it [00:00, ?it/s]
`

Hi, from the iterations, it seems no images were found, can you re-check the images file and the images extension, you can also print the variable image_files and see if the images were detected.

Hi, from the iterations, it seems no images were found, can you re-check the images file and the images extension, you can also print the variable image_files and see if the images were found.

Thanks for your quick reply, I think the problem is that the images are not found. but the code looks correct, image_files = sorted(glob(os.path.join(args.images, '*.{args.extension}'))) and  I have tried the relative path and absolute path, it doesn't work.  The images needed to be tested are ipg format.
 python inference.py --config config.json --model ./saved/PSPNet/10-28_05-10/best_model.pth --images test_images
or
python inference.py --config config.json --model ./saved/PSPNet/10-28_05-10/best_model.pth --images /home/jenny/pytorch_segmentation/test_images

can you try hard coding the path and the extension (args.images and args.extension) to see if the error is indeed the image loading

can you try hard coding the path and the extension (args.images and args.extension) to see if the error is indeed the image loading

Yeah, I have solved this problem after using the absolute path(home/jenny/pytorch_segmentation/test_images ) for the args.images, there is no / before the home, and the image_files is defined as
image_files = sorted(glob(os.path.join(args.images, '*.'+args.extension)))

Hi, I am also trying to train the PSP model on VOC, have you met this problem when executing the train.py? https://github.com/yassouali/pytorch_segmentation/issues/31
Thank you!


GitHub brousseau dev

I made a mistake while adding the commits in #39 for the bootstrap fixes, and mistakenly dropped to carry the commits that were already there! These add the proper commits.


Want to integrate dynamodb record creation and s3 image upload using amplify and graphql

I upload image and its information.
This flow is as follows

Upload image
Create image information if uploading finish successfully

I think it isn`t smart because of splitting processes 1. and 2.
Could I integrate these processes?
<script lang="ts">
methods: {
    async uploadToS3andDB (selectedImg: S3payload) {
      const uuid: string = this.uuid()
      const objectID: string = selectedImg.name + '_' + uuid
      const filePath: string = selectedImg.name + '/' + objectID + '.jpg'
      const result: S3Result = (
        await Storage.put(filePath, selectedImg.fileObj)
      ) as S3Result
      if (result.key !== undefined) {
        const storeName: string = this.$store.getters['user/storeName']
        const params: APITypes.CreateInfoInput = {
          name: selectedImg.name,
          objectID: objectID,
          store: storeName,
          fileName: objectID + '.jpg',
          filePath: filePath,
          labels: []
        }
        const response: GraphQLResult | Observable<object> = (
          await API.graphql(
            graphqlOperation(createInfo, { input: params })
          )
        )
        if (this.isGraphQLResult(response)) {
          if (this.isCreatePanInfoMutation(response.data)) {
            console.log(response.data.createInfo)
          }
        } else {
          throw new Error(String(result))
        }
      } else {
        throw new Error(String(result))
      }
    }
}
<script>

Is S3Object releated in this feature ?
https://aws-amplify.github.io/docs/cli-toolchain/graphql#s3-objects
https://github.com/aws-samples/aws-amplify-graphql/blob/07fafcb9581956114808c73f4265d8f655c896e1/src/GraphQL/MutationCreatePicture.js

@yukitaka13-1110 This is tied to complex object support in Amplify JS for AppSync. I'll move it over to the JS repo and mark it as an enahcnement.


Growl Integration

Hermes is the best Pandora player I've found yet. However, having support for Growl (providing a notification whenever a new song starts playing) would make it far better.

Now Growl integration is perfect!


Document use cases and best practices for cache support.

To support performance in APIs for master data resources, we should describe how to specify caching support.

Relevant links to this:

Hypertext Transfer Protocol (HTTP/1.1): Caching, https://tools.ietf.org/html/rfc7234
Storing Responses to Authenticated Requests, https://tools.ietf.org/html/rfc7234#section-3.2

I'll just use this issue as a brain dump for notes that I already had on this:

the RFC defines the proper framework for HTTP Caching, I don't believe we need any special rules for our guidelines, maybe some examples
the biggest aspect of this is a service/implementation aspect, rather than API design

I have three immediate ideas how caching could be implemented

Server-side, reverse-proxy

requests are passing through e.g. an nginx before the reach the actual service
either nginx ignores authorization headers when serving responses (very bad!)
or nginx uses the authorization header as part of the cache key (effectively creating per client/instance caches which may give a poor hit rate)
or nginx implements JWT token validation which should be doable using some custom scripts
or nginx always validates requests with the origin server doing the authorization (not 100% sure this works)
completely transparent for clients
doesn't save clients a roundtrip to the server
could be offered as a standalone appliance/docker image

Client-side, in-memory

requests are cached on each client instance, in memory
saves roundtrip
requires http client library with caching support, e.g. https://hc.apache.org/httpcomponents-client-ga/tutorial/html/caching.html
since each instance has their cache, the hit rate is not as good as it could be

Client-side, proxy

requests are cached on a proxy on the client side that is shared with all client instances
all requests to the service are done against the local proxy instead
proxy can ignore authorization header under the assumption that it can trust it local clients (to be discussed!)
transparent for client instances
saves remote roundtrip
could be offered as a standalone appliance/docker image

As I said I'm primarily using this as a brain dump. There is no claim of being complete.

yes, these are 3 variants for a generic http cache configuration (inside client instance (lib), client group specific server proxy, or general server proxy). Let me also mention local client instance caching of resources (not on http level). A typical example is read-only master data, e.g. article color palette, that is stored in-memory in master data specific cache and gets periodically updated via asynchronous http calls (which may/should support etags/cache-expiry hints).


#2058 Create oc symlink at crc start time

Activate the bundle (eg install oc symlink) only on start action
Previously almost each commands recreated the symlink.
Fixes #2058

/lgtm


Razer Hydra driver stopped working

Hello, Razer Hydra controllers have stopped working in new games and in old ones.
Previously, they worked well and we could play almost all games.
The developer has already updated the driver, but it looks like you changed the SDK again and the driver broke again.
It seems that the developer has lost interesting and no longer wants to update the driver.
Could you please return the support of these controllers? Maybe the official driver? This is one of the most affordable ways to try and use VR. This will allow VR to reach more players around the world and popularize the idea of VR.
Thanks.
Driver in steam,
Github repo.

For example, in Pavlov VR, the controllers stopped working at all, although they still worked in April 2019.
Grip does not work in The Gallery Episode 1, in some other games, it seems that Grip also did not work.
At the same time, everything on the initial steamvr screen works like type controllers, but the menu does not call, although it seemed to work fine on openvr 1.0.12.
Razer Hydra has enough buttons to emulate Vive controllers, there are even 4 extra buttons that you can use to rotate the player around its axis (because of the wires it will not work), as well as to move up or down (for example, crouch and the starting position).
@bjj @connerbrooks , could you fix the driver?

In PavlovVR managed to include controllers. It was necessary to choose some kind of customization of the controllers and it worked only with it. The official setup did not work. This is strange, most do not need any custom controller settings and by default it doesn’t work, earlier it used to work.

I fixed the buttons in the driver from BetaVR and also added a crouch button. The updated driver can be found here. Since BetaVR no longer supports the driver, let's now join forces in this repository.
Checked in games: Half-Life: Alyx, VRChat, PavlovVR. Everything works well.

Added recognition of Hydra controllers as Index controllers, this gives a little more convenient control and better compatibility (for example, with RE VR mods).
The updated driver can be found here.


Storage Uploads - Switch to the Filebase/IPFS pipeline

### Tasks
- [ ] Court v1
- [x] Court v2
- [ ] Escrow v1
- [x] Escrow v2
- [ ] Curate v1
- [ ] Curate v2
- [ ] Proof of Humanity v1
- [x] Proof of Humanity v2
- [ ] Dispute Resolver v1

PoH-V2 status:
PoH-V2 already using filebase to store files: https://github.com/Proof-Of-Humanity/proof-of-humanity-v2-web/blob/master/src/app/api/ipfs-upload/route.ts
We don't know which bucket are we using, so I'm creating a new bucket within the main account and asking to Martin to change the env variables in netlify to point to the new poh-v2 bucket.

Curate-V2 status:
As in PoH-V2, curate-v2 is already using Filebase to pin new files according to this file: https://github.com/kleros/curate-v2/blob/master/web/netlify/functions/uploadToIPFS.ts
Cheching to which bucket are we pointing

Escrow-v2:
Same situation as PoH-v2

For the v1 apps: https://github.com/kleros/court-functions/issues/11


Issue with disabling Threaded view in settings

When I disable the Threaded view in display settings, It doesn't apply to the list immediately. I should close the app and open it again to see threaded view disabled.
To Reproduce
Steps to reproduce the behavior:

Go to Settings
Go to General Settings
Go to Display
Uncheck Threaded View
Back to the messages list
Settings didn't apply
We should restart the application to apply

Expected behavior
It should apply immediately after uncheck
Environment (please complete the following information):

K-9 Mail version: 5.803 (28003)
Android version: 11
Device: Emulator
Account type: IMAP

You can fix this by adding a parameter to MessageListActivityAppearance and initializing it with K9.isThreadedViewEnabled. If the value changes the MessageList activity will be recreated.
https://github.com/k9mail/k-9/blob/51e6820d9289973347c342cab9db763d7fcaee70/app/ui/legacy/src/main/java/com/fsck/k9/activity/MessageList.kt#L519-L521
I'd love to get a pull request fixing this issue.

My comment from PR #6011 that attempted to fix this issue:

I was wrong in the issue comment. Restarting the activity isn't enough because whether or not to show a threaded list is passed as an argument to MessageListFragment.
I see two possible ways to fix this issue:

Create a new instance of MessageListFragment with the correct arguments when this situation is detected.
Instead of using a boolean for ARG_THREADED_LIST, use an enum with values for "enabled", "disabled" and "use app config".

The first option is probably a bit more work. But using it we should also be able to handle the situation where the user is displaying the list of messages in a thread before going to settings and disabling the thread view.


error Error: https://github.com/microsoft/node-sqlite3/releases/download/v5.1.6-bins/sqlite3-v5.1.6-napi-v3-linux-x64.tar.gz: Request failed "404 Not Found"

VS Code Version:
OS Version:  debian12

ON Building from source
yarn
yarn install v1.22.22
$ node build/npm/preinstall.js
[1/4] Resolving packages...
Couldn't find any versions for "native-keymap" that matches "3.4.0"
? Please choose a version of "native-keymap" from this list: 3.3.3
Couldn't find any versions for "node-pty" that matches "^0.11.1"
? Please choose a version of "node-pty" from this list: 0.10.1
error Error: https://github.com/microsoft/node-sqlite3/releases/download/v5.1.6-bins/sqlite3-v5.1.6-napi-v3-linux-x64.tar.gz: Request failed "404 Not Found"
at ResponseError.ExtendableBuiltin (/usr/lib/node_modules/yarn/lib/cli.js:696:66)
at new ResponseError (/usr/lib/node_modules/yarn/lib/cli.js:802:124)
at Request. (/usr/lib/node_modules/yarn/lib/cli.js:66750:16)
at Request.emit (node:events:519:28)
at module.exports.Request.onRequestResponse (/usr/lib/node_modules/yarn/lib/cli.js:142287:10)
at ClientRequest.emit (node:events:519:28)
at HTTPParser.parserOnIncomingClient (node:_http_client:698:27)
at HTTPParser.parserOnHeadersComplete (node:_http_common:119:17)
at TLSSocket.socketOnData (node:_http_client:540:22)
at TLSSocket.emit (node:events:519:28)

There is no Downloads endpoint in https://github.com/microsoft/node-sqlite3/releases/ instead there is endpoint  ' tags ' tags endpoint

Does this happen on the latest main, even after you run a git clean? git clean -xfd

Unfortunately, we don't support issues regarding building code-oss (source) in this issue tracker :( Perhaps you can look up the issue somewhere like StackOverflow? I haven't seen this, and I'm on node v20.13.1


<EMAIL_ADDRESS>issue with editor.api.d.ts

monaco-editor version: monaco-editor-core
Browser: chrome 70
OS: fedora 29
It appears the editor.api.d.ts file is not generated correctly and has many type errors/mistakes.
Position on CompletionItemProvider, for example, points to the lib.dom.d.ts's Position interface, and not monaco.Position.
Only saw issue in monaco-editor-core package<EMAIL_ADDRESS>(newer?) appears to be fine.
also, and unrelated, insertText should be optional on CompletionItem
EDIT: I see you actually use insertText and assume its defined. in TypeScript's API its optional (getCompletionsAtPosition), and if not defined, label is used instead. Will account for it in my provider.

you're looking at monaco.d.ts, while importing symbols (using esm) from 'monaco-editor-core' pointed typescript to editor.api.d.ts (which is where the .d.ts has errors).

I still cannot reproduce. Here is what I get in editor.api.d.ts:

It looks like the issue is already fixed<EMAIL_ADDRESS>I still see the error in<EMAIL_ADDRESS>The two versions have a different editor.api.d.ts file.


Updated to reflect system defaults

Per latest information from voicemail team, transcription is enabled by default, profanity masking is disabled by default

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Set-CsOnlineVoicemailPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


JIT is incompatible with OpenCensus Extension

Hi,
I used the opencensus extension with JIT compiler but the JIT compiler was disabled with the error.
PHP Warning:  JIT is incompatible with third party extensions that override zend_execute_ex(). JIT disabled. in Unknown on line 0

The extension seems override the method zend_execute_ex.
https://github.com/census-instrumentation/opencensus-php/blob/dcc7feab38507dedc0097d5bb459b81b1439c1ae/ext/opencensus_trace.c#L38
Is OpenCensus Extension compatible with JIT compiler ? I would like to use the extension to trace the library I use in my application.
Also appreciate any workaround for tracing third party libraries. Thanks.

The extension predates the JIT compiler, and it doesn't really receive future development anymore. In addition, its overriding of zend_execute_ex does cost a bit of performance (~20%).
I used to use this extension in the past (even contributed fixes to it), but mostly leave it disabled these days to benefit from better default performance. Instead, I manually trace performance-critical sections using Tracer::inSpan in the PHP library (i.e. without the native extension); it should get you the insights you need, without the performance penalty.

@MrMage Thanks for sharing the performance information !! It is very useful for me when I instrument.
Do you have any recommendation when we want to capture traces with third party libraries (such as DB) ?
If I used Tracer::inSpan, I would want to trace more specifically to figure out if the latency comes from my implementation or not.

I trace e.g. all Laravael controller route handlers and all DB queries automatically. From there, I know which routes are slow, and can add more instrumentation to those routes as needed.
Here's the code I use:
app/Http/Controllers/Controller.php
<?php

declare(strict_types=1);

namespace App\Http\Controllers;

use Illuminate\Foundation\Auth\Access\AuthorizesRequests;
use Illuminate\Foundation\Bus\DispatchesJobs;
use Illuminate\Foundation\Validation\ValidatesRequests;
use Illuminate\Routing\Controller as BaseController;
use OpenCensus\Trace\Tracer;

class Controller extends BaseController
{
    use DispatchesJobs,
        ValidatesRequests,
        AuthorizesRequests;

    public function callAction($method, $parameters)
    {
        return Tracer::inSpan(
            [
                'name' => static::class . '::' . $method,
            ],
            fn () => parent::callAction($method, $parameters)
        );
    }
}

app/Database/PostgresConnection.php
<?php

declare(strict_types=1);

namespace App\Database;

use Illuminate\Contracts\Debug\ExceptionHandler;
use Illuminate\Database\Grammar;
use OpenCensus\Trace\Span;
use OpenCensus\Trace\Tracer;

class PostgresConnection extends \Illuminate\Database\PostgresConnection
{
    /* other methods */

    protected function run($query, $bindings, \Closure $callback)
    {
        // Trace any database queries. Alternatively, this could also be implemented by listening to
        // `\Illuminate\Database\Events\QueryExecuted` events; see e.g. `\Spatie\LaravelIgnition\Recorders\QueryRecorder`.
        $args = \func_get_args();
        return Tracer::inSpan(
            [
                'name' => 'DatabaseConnection::run',
                'attributes' => [
                    'query' => $query,
                ],
                'kind' => Span::KIND_CLIENT,
            ],
            // Can't use `\func_get_args()` directly here because the arguments to `fn ()` are empty.
            fn () => parent::run(...$args)
        );
    }
}

@MrMage Thanks. These samples are really helpful for me to understand how to instrument the code.
And I really appreciate your kind response.


Make Password Rest Mail Translatable

if password reset email get translatable, there is no need make new notification and overwrite the
sendPasswordResetNotification() in  User Model
PR for translation files sent

This is already customizable I believe.

who i can translate password reset text and make email multilingual without
make new notification and overwriting sendPasswordResetNotification()  in User model ?


feat: follow the community agreement and explicitly use tailwindcss

遵循社区约定使用 tailwind.config.js 配置文件，同时暴露入口文件的原因是为了 taiwindcss 的下一个版本插件用法
可能的写法是
@import 'tailwindcss';
@plugin '@tailwindcss/typography';
@plugin '@tailwindcss/forms' {
          strategy: base;
        }

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC. https://github.com/umijs/tnf/pull/22
[ ] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests and other checks with pnpm ci

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features and fix bugs should all be patch before we release 0.1.0. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

[x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Closes: https://github.com/umijs/tnf/issues/29

@Xy2002 cc

@Xy2002 cc

之前有想过这么做，但是在 #2  里说预想的方式是按tailwindcss:{}，所以我理解可能出现了一些偏差。目前的这个做法我觉得是最好的，很好的解决了所有问题，感谢大佬耐心的修改 😂


fix: api migration version e2e fix

Description of changes
Migration test version API  fix

Issue #, if available

Description of how you validated changes
Checklist

[ ] PR description included
[ ] yarn test passes
[x] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #9000 (89eb53f) into api-ext-rebase-2 (f62dd02) will not change coverage.
The diff coverage is n/a.

@@                Coverage Diff                @@
##           api-ext-rebase-2    #9000   +/-   ##
=================================================
  Coverage             55.49%   55.49%
=================================================
  Files                   883      883
  Lines                 49940    49940
  Branches              10757    10757
=================================================
  Hits                  27714    27714
  Misses                20183    20183
  Partials               2043     2043

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f62dd02...89eb53f. Read the comment docs.


Find all references returns no result

VSCode Version:1.11.2
OS Version:Ubuntu 16.04
Language: C

Steps to Reproduce:
1.Open the codes.
2.Choose a function, right click and from the menu select "Find all references". It shows no results. But in fact, there are references to the function in the codes.
I know this issue has been reported in earlier version (1.2) but it seems the issue is still there in 1.11.2. Any suggestions? Or maybe, which version should already have the bug fixed?
Thanks,

Please file against the extension from which you expect reference results.


Some characters are missing in generated output

Nodejs : 7.4.0
Postgres : 9.6.1
schemats : 1.0.1
While using last version 1.0.1 of this module, I run into a strange bug : in the generated file, some characters are missing, always in the third line of first interface declaration.
Eg, in the following example, the file contains export type sal_matriculetring; instead of export type sal_matricule = string;
4 characters  = s are missing
Excerpt of output :
/**
 * AUTO-GENERATED FILE @ 2017-01-24 13:27:02 - DO NOT EDIT!
 *
 * This file was generated with schemats node package:
 * $ schemats generate -c postgres://username:password@localhost:5432/testpayroll -t pay_salarie_sal -o schema.ts
 *
 * Re-run the command above.
 *
 */

export namespace pay_salarie_salFields {
    export type sal_id = number;
    export type sal_matriculetring;

With another table, the missing characters are in nearly the same place :
/**
 * AUTO-GENERATED FILE @ 2017-01-24 13:33:18 - DO NOT EDIT!
 *
 * This file was generated with schemats node package:
 * $ schemats generate -c postgres://username:password@localhost:5432/testpayroll -t pay_contrat_cnt -o schema.ts
 *
 * Re-run the command above.
 *
 */

export namespace pay_contrat_cntFields {
    export type cnt_soldetc_mdp_id = number | null;
    exporte tex_id = number | null;

Of course, expected : export type tex_id instead of exporte tex_id
4 characters typ are missing
It's the only issue in the output file : all other lines are correct.
I don't reproduce the issue with osm artifact test file, which is weird.

I've also seen this before.. and it's frustrating. So far I believe the issue is either with the fs.saveFile function or typescript-formatter.

Thx for your quick answer and for the clue.
I will investigate when I have some time.

No problem. I've seen it happening for one day [1] but I'm unable to reproduce it now for some reason.

Removed a potential culprit with https://github.com/SweetIQ/schemats/pull/38 .

Thanks !
But after have merged #38 locally, I still have the issue. No difference at all.

I will probably have to look into typescript-formatter then..

@xiamx how good are your tests? You don't really know that without code coverage. Check out - all my modules have it, you can use them as an example ;)

@vitaly-t tests are admittedly not comprehensive at the moment :joy: . We only have end to end tests as of now. I should start adding some unit tests

I'm experiencing the same problem with export type password = string being generated as expoype password = string

I will take another look at this over the weekend

Anything? It's a killer bug, you know, very critical :wink:

@vitaly-t :joy: I can't reproduce it, neither locally nor on CI.. even though code coverage report by Istanbul is at 100% line covered

Bumping the version of typescript-formatter to 4.1.0. @abenhamdine @Jujunol can you guys please paste the content of your tsconfig.json and tslintrc (if any)? It should help me reproduce this bug locally.

Bug still present in 1.1.0 for me, unfortunately.
I reproduce every time with a schema with a single table
Here's the dump of the db :
dump.txt
And the output file :

/**
 * AUTO-GENERATED FILE @ 2017-02-08 16:14:07 - DO NOT EDIT!
 *
 * This file was generated with schemats node package:
 * $ schemats generate -c postgres://username:password@localhost:5432/test_schemats_2 -o schema.ts -t cta_situationcompte_sco
 *
 * Re-run the command above.
 *
 */

export namespace cta_situationcompte_scoFields {
    export type sco_id = number;
    export type sco_t_debit = number;
    export type sco_total_credit = number;
    export type sco_nb_ecritures = number;
    export type pst_id = number;
    export type cpt_id = number;

}

export interface cta_situationcompte_sco {
    sco_id: cta_situationcompte_scoFields.sco_id;
    sco_total_debit: cta_situationcompte_scoFields.sco_total_debit;
    sco_total_credit: cta_situationcompte_scoFields.sco_total_credit;
    sco_nb_ecritures: cta_situationcompte_scoFields.sco_nb_ecritures;
    pst_id: cta_situationcompte_scoFields.pst_id;
    cpt_id: cta_situationcompte_scoFields.cpt_id;

}

@abenhamdine Thanks. This is very helpful in reproducing it.
I can confirm If I disable typescript-formatter, by replacing index.ts
    let formatterOption = {
        replace: false,
        verify: false,
        tsconfig: true,
        tslint: true,
        editorconfig: true,
        tsfmt: false
    }

    const processedResult = await processString('schema.ts', output, formatterOption)
    return processedResult.dest

with simply return output
The generated file will have export type sco_total_debit = number; generated correctly. This is a weird issue and certainly suggests a bug in typescript-formatter (or a misusage of it in my part.) We use typescript-formatter to (mainly) generate files with correct indentation levels specified by the project's tslintrc or editorconfig.

Maybe we can receive some help of its author @vvakame I've created an issue there https://github.com/vvakame/typescript-formatter/issues/74

Interestingly, by removing the comment header from the input, we the issue disappeared. So maybe the temporal solution is to feed only the output without header to typescript-formatter, and then add the header afterward.

After some lengthy debug on typescript-formatter, I proposed a fix here https://github.com/vvakame/typescript-formatter/pull/75. I'll release a fix for schemats quickly by pointing the typescript-fromatter version to our fork.

1.1.1 solved the pb for me. Thx a lot @xiamx  ! 💃 😄 🎉
@Jujunol could you confirm if it's the case for you too ?

@abenhamdine awesome, glad to know it fixed it !
Let's keep this tracking issue open until patches are merged in the upstream typescript-formatter project.

Thank you everyone, the patch is merged to typescript-formatter. Closing this issue with the release v1.1.2


Website broken in Safari 15.5

Something very weird is going on…

Aha, serialization is broken, P3 colors are serializing as color(p3 ...)


STORM-1213: Remove sigar binaries from source tree

See https://issues.apache.org/jira/browse/STORM-1213 for description.
Also removes the LICENSE entry for sigar, since I believe that is unnecessary since it is Apache licensed.

+1

+1

+1

Actually I just tried to run this and it looks like the libraries are under resources/resources/ instead of just resources/  because of this I am getting linking errors when trying to use the metrics.

Sorry about the comments after giving it a +1.  I manually ran LatencyVsThroughput and saw that it was not working.

Even with changing the directory I am getting
java.lang.UnsatisfiedLinkError: org.hyperic.sigar.Sigar.getPid()J
	at org.hyperic.sigar.Sigar.getPid(Native Method) ~[stormjar.jar:0.11.0-SNAPSHOT]
	at org.apache.storm.metrics.sigar.CPUMetric.<init>(CPUMetric.java:38) ~[stormjar.jar:0.11.0-SNAPSHOT]
	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:1.8.0]
	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) ~[?:1.8.0]
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:1.8.0]
	at java.lang.reflect.Constructor.newInstance(Constructor.java:408) ~[?:1.8.0]
	at java.lang.Class.newInstance(Class.java:433) ~[?:1.8.0]
	at backtype.storm.utils.Utils.newInstance(Utils.java:91) ~[storm-core-0.11.0-SNAPSHOT.jar:0.11.0-SNAPSHOT]
	at backtype.storm.metric.SystemBolt.registerMetrics(SystemBolt.java:150) ~[storm-core-0.11.0-SNAPSHOT.jar:0.11.0-SNAPSHOT]
	at backtype.storm.metric.SystemBolt.prepare(SystemBolt.java:143) ~[storm-core-0.11.0-SNAPSHOT.jar:0.11.0-SNAPSHOT]
	at backtype.storm.daemon.executor$fn__5157$fn__5170.invoke(executor.clj:777) ~[storm-core-0.11.0-SNAPSHOT.jar:0.11.0-SNAPSHOT]
	at backtype.storm.util$async_loop$fn__556.invoke(util.clj:480) [storm-core-0.11.0-SNAPSHOT.jar:0.11.0-SNAPSHOT]
	at clojure.lang.AFn.run(AFn.java:22) [clojure-1.7.0.jar:?]
	at java.lang.Thread.run(Thread.java:744) [?:1.8.0]

We need to do some more work to understand the difference between this patch and what we were doing before.

@revans2 How are you running it (i.e. local/remote/unit test)? My first thought is that we may just need to bind the dependency plugin to a different maven lifecycle.

@revans2 That directory structure is what's in master right now:
https://github.com/apache/storm/tree/master/external/storm-metrics/src/main/resources/resources

In master https://github.com/apache/storm/tree/master/external/storm-metrics/src/main/resources gets mapped into the base directory of the jar.  So https://github.com/apache/storm/tree/master/external/storm-metrics/src/main/resources/resources goes to jar://storm-merics.jar/resources/
For my tests I launch a single node cluster
$ mvn clean install -DskipTests -Drat.skip
$ cd storm-dist/binary
$ mvn clean package
$ tar -xzvf ./target/*.tar.gz
$ cd apache-strom*
$ ./bin/storm dev-zookeeper & #nimbus, ui, logviewer, supervisor,
$ ./bin/storm jar ./examples/storm-starter/storm-starter-topologies-0.11.0-SNAPSHOT.jar storm.starter.ThroughputVsLatency 2000 1 5

I just did a diff of the contents of the two jars, old and new(this patch plus me moving the native libraries) and I came up with the following. Around the max native pieces
Only in ./new/resources: libsigar-universal64-macosx-1.6.4.dylib
Only in ./old/resources: libsigar-universal-macosx.dylib
Only in ./old/resources: libsigar-universal64-macosx.dylib

It looks like the version number in the dylib might be messing up the linking somehow.

yes that is it.  When I moved resources/libsigar-universal64-macosx-1.6.4.dylib to resources/libsigar-universal64-macosx.dylib and reran it all worked.

@revans2 Ah... okay. So we need to change resources/resources to just resources, and remove the -1.6.4 from the libraries, correct?
That should be doable with the dependency plugin.

@ptgoetz Yes you are correct about the changes.

@revans2 I couldn't get the maven dependency plugin to do what I wanted, so I changed tactics. I switched to using the maven antrun plugin to download and unpack the sigar native binaries. It downloads the archive to the local maven repository alongside the other sigar dependencies so it only needs to download it once.
The good news is that allowed me to use the full binary archive, so it includes support for windows and other OSes/architectures. On the down side it's somewhat brittle compared to using "pure" maven, and IMO is kind of ugly. It's also hard-coded to use google code, which is supposedly going away at some point, but that's the only place I could find the archive with a published checksum.

@ptgoetz
+1 the changes look good and my manual tests all pass.
I Agree the it kind of ugly.  Ideally what we need to do is to talk to sigar and see if they can update their native jar to do what we want.  It should be fairly simple to have them remove the version number from the jar.


MuJoCo xml parser?

With the recent open-sourcing of MuJoCo and significant increase in use of mujoco xmls in the community, is there any hope of having a mujoco XML parser soon?

Yes, sure. This is in the roadmap


A few of our of composer lock files do not show advisory warnings using the Client but work using Curl

We have a number of composer.lock files that we send to the api, many work just fine but there are a few, like that attached, that will show no issues via the SecurityChecker class but if I use curl or upload via the site we get the expected failed results.
Just curious if there is something wrong with the file or client that would cause this?
Since I can not attach the files I will link via dropbox
https://www.dropbox.com/s/oiyfzpavjx8qc73/example.json?dl=0
The test I run to show all of this is here:
<?php

namespace Tests\Feature;

use Tests\TestCase;
use Illuminate\Foundation\Testing\WithFaker;
use Illuminate\Foundation\Testing\RefreshDatabase;
use GuzzleHttp\Client;
use GuzzleHttp\Psr7\Response;
use SensioLabs\Security\Crawler;
use SensioLabs\Security\SecurityChecker;

class CustomSensioClientTest extends TestCase
{

    public function setUp()
    {
        parent::setUp();
        //$this->markTestSkipped("Working on figuring out a glitch in the API");
    }

    public function testCurlExec()
    {
        $lock = base_path("tests/fixtures/example.json");
        //$lock = base_path("tests/fixtures/known_failing.json");
        $command = "curl -H \"Accept: application/json\" https://security.sensiolabs.org/check_lock -F lock=@{$lock}";
        exec($command, $output, $status);
        dd($status, $command, $output);
    }

    public function testTheirCleint()
    {
        //$lock = base_path("tests/fixtures/known_failing.json");
        $lock = base_path("tests/fixtures/example.json");
        $crawler = new Crawler();
        $checker = new SecurityChecker($crawler);
        $results = $checker->check($lock);
        dd("here", $results);
    }

    public function testTalkingToAPI()
    {
        $lock = base_path("tests/fixtures/example.json");
        //$lock = base_path("tests/fixtures/known_failing.json");
        /** @var Client $client */
        $client = new Client([
            'base_uri' => "https://security.symfony.com",
            'timeout' => 20,
            'allow_redirects' => true,
        ]);
        $options['headers'] = ["Accept" => "application/json"];
        //$options['headers'][] = ["Content-Type" => "multipart/form-data"];
        $options['multipart'] = [
            [
                'name' => 'lock',
                'contents' => fopen($lock, 'r')
            ]

        ];

        /** @var Response $results */
        $results = $client->request("POST", "/check_lock", $options);

        dd(json_decode($results->getBody(), true), $results->getStatusCode(), $lock);

    }
}

Again the curl one giving me the results I expected.

Apparently, you are using the master branch of security-checker, which is not released yet. I've just tried with the 4.1 branch and it works as expected.


Fix the field skipper and tests

The tests and the implementation were incorrect. The skipper needed to use skipType instead of skipField since the typeid was already read off the wire. skipField continues to exist but only as a vestige of the skip tests. All use in the context of a struct uses skipType.

r @malandrew @abhinav

lgtm :+1:


[Question]: How to specify an external switch?

I'm trying to deploy k3s full deployment but the VM keeps getting an internal IP address instead of an external one that I specify in the config file. From the logs it looks like it's using an internal switch instead of the external switch. The document is unclear on how to specify an existing external switch with a Wi-Fi adapter.

specify the DeploymentType as "ScalableCluster" instead of "SinglemachineCluster" in your json file

That works. Thank you @parameshbabu


feat: Added test to apply the same tests to UDTs as we do for parameters

Description

Simplified tests
Added utility in test helper file to get a flat list of all parameter (& UDTs)
Re-Grouped template tests into general, parameters, variables, resources & outputs
Regenerated docs
Fixed found issue with RoleAssignment UDT's 'condition' property description
Added bugfix for workflow trigger of PR #707
Fixed issue of Test-ModuleLocally when invoking only for Pester and a child-module

Pipeline

@AlexanderSehr looks good as discussed offline, but requires conflict resolution

I won't be able to do this before next Wednesday. Will keep you posted


v3.5.2 failed to load file://android_asset/www/build/vendor.js at system startup

Ionic version:  (check one with "x")
[ ] 1.x (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[ x] 3.x
I'm submitting a ...  (check one with "x")
[ x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:

the debug console (chrome://inspect/#devices ) displays : "Failed to load resource: net::ERR_FILE_NOT_FOUND     file://android_asset/www/build/vendor.js"  after system start-up
Expected behavior:

there is no such error on before upgrade (v3.5.0)
Steps to reproduce:

upgrade to v3.5.2. build and run  the application by "ionic cordova run android" ,  after the apps had been downloaded to the phone and started up on the phone; open Chrome browser, enter "chrome://inspect/#devices" in the address bar, click  the application under the device, and this will open up the debug page, and you will find the error  on the first line in the Console
Related code:
ionic cordova run android

Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
global packages:

    @ionic/cli-utils : 1.5.0
    Cordova CLI      : 7.0.1
    Ionic CLI        : 3.5.0

local packages:

    @ionic/app-scripts              : 1.3.7
    @ionic/cli-plugin-cordova       : 1.4.0
    @ionic/cli-plugin-ionic-angular : 1.3.1
    Cordova Platforms               : android 6.0.0
    Ionic Framework                 : ionic-angular 3.5.0

System:

    Node       : v8.1.4
    OS         : Linux 4.4
    Xcode      : not installed
    ios-deploy : not installed
    ios-sim    : not installed
    npm        : 5.0.3

I attached a screen-shot  of the bug here

Have you read the change log? vendor.js should be added to your index.html?
https://github.com/ionic-team/ionic/blob/master/CHANGELOG.md

I have the same problem. The reason I get a 404 on that file is because I have added to the index.html however the build system doesn't produce the file

@CoDanny did you update app-scripts too? could you check in node_modules that app-script 2.0.2 is correctly installed (and not a version < 2.0.0)?

@peterpeterparker my ionic info
global packages:

    @ionic/cli-utils : 1.5.0
    Cordova CLI      : 7.0.1
    Ionic CLI        : 3.5.0

local packages:

    @ionic/app-scripts              : 2.0.2
    @ionic/cli-plugin-cordova       : 1.4.1
    @ionic/cli-plugin-ionic-angular : 1.3.2
    Cordova Platforms               : android 6.2.3 ios 4.4.0
    Ionic Framework                 : ionic-angular 3.5.2

System:

    Node       : v8.1.4
    OS         : macOS Sierra
    Xcode      : Xcode 8.3.3 Build version 8E3004b
    ios-deploy : 1.9.0
    ios-sim    : 5.0.8
    npm        : 5.0.3

@CoDanny oki doki, still I would check that app-script 2.0.2 is really under node_modules. I had some weird side effect after the introduction of package-lock.json, sometimes better to double check...
 cat<EMAIL_ADDRESS>| grep version

Thanks, it's right:
$ cat<EMAIL_ADDRESS>| grep version
    "type": "version",
  "version": "2.0.2"

@CoDanny thx for the check, sorry that these investigation didn't solved your problem :(

@CoDanny , would you mind deleting your lock file and your node_modules and doing a fresh install. We have ran into nothing but issues with the lock files in npm 5, even if the lock file looks correct.

@jgw96 I did that a couple of time, no change

@CoDanny hmmm mind sharing a repo we could reproduce this with?

Hi guys. I am experiencing the same issue here. I tried updating from ionic v2 to v3 and literally everything exploded. I think I managed to go through every changelog and applied the changes.
It didn't help. I deleted everything and reinstalled from scratch.  (Even the plugins)
global packages:

    @ionic/cli-utils : 1.5.0
    Cordova CLI      : 7.0.1
    Ionic CLI        : 3.5.0

local packages:

    @ionic/app-scripts              : 2.0.2
    @ionic/cli-plugin-cordova       : 1.4.1
    @ionic/cli-plugin-ionic-angular : 1.3.2
    Cordova Platforms               : android 6.2.3
    Ionic Framework                 : ionic-angular 3.5.3

System:

    Node       : v7.7.1
    OS         : macOS Sierra
    Xcode      : Xcode 8.2.1 Build version 8C1002
    ios-deploy : 1.9.1
    ios-sim    : 6.0.0
    npm        : 4.2.0

@mehrad-rafigh Can you show your package.json file?

@Sampath-Lokuge there you go
{
    "name": "ionic-hello-world",
    "author": "Ionic Framework",
    "homepage": "http://ionicframework.com/",
    "private": true,
    "scripts": {
        "clean": "ionic-app-scripts clean",
        "clean:install": "rimraf node_modules/ platforms/ plugins/ && npm install",
        "lint": "ionic-app-scripts lint",
        "build": "ionic-app-scripts build"
    },
    "dependencies": {
        "@angular/animations": "4.1.3",
        "@angular/common": "4.1.3",
        "@angular/compiler": "4.1.3",
        "@angular/compiler-cli": "4.1.3",
        "@angular/core": "4.1.3",
        "@angular/forms": "4.1.3",
        "@angular/http": "4.1.3",
        "@angular/platform-browser": "4.1.3",
        "@angular/platform-browser-dynamic": "4.1.3",
        "@angular/platform-server": "4.1.3",
        "@ionic-native/app-version": "3.14.0",
        "@ionic-native/barcode-scanner": "3.14.0",
        "@ionic-native/core": "3.14.0",
        "@ionic-native/device": "3.14.0",
        "@ionic-native/diagnostic": "3.14.0",
        "@ionic-native/geolocation": "3.14.0",
        "@ionic-native/launch-navigator": "3.14.0",
        "@ionic-native/splash-screen": "3.14.0",
        "@ionic-native/status-bar": "3.14.0",
        "@ionic/storage": "2.0.1",
        "@ngx-translate/core": "7.0.0",
        "@ngx-translate/http-loader": "0.1.0",
        "cordova-android": "^6.2.3",
        "cordova-browser": "^4.1.0",
        "cordova-ios": "^4.4.0",
        "cordova-plugin-actionsheet": "^2.3.3",
        "cordova-plugin-app-version": "^0.1.9",
        "cordova-plugin-compat": "^1.1.0",
        "cordova-plugin-console": "^1.0.7",
        "cordova-plugin-crosswalk-webview": "^2.3.0",
        "cordova-plugin-device": "^1.1.6",
        "cordova-plugin-dialogs": "^1.3.3",
        "cordova-plugin-geolocation": "^2.4.3",
        "cordova-plugin-splashscreen": "^4.0.3",
        "cordova-plugin-statusbar": "^2.2.3",
        "cordova-plugin-whitelist": "^1.3.2",
        "cordova-plugin-wkwebview-engine": "git+https://github.com/driftyco/cordova-plugin-wkwebview-engine.git#4221015eb3f309fe593a7d81205b691e27088743",
        "ionic-angular": "3.5.3",
        "ionic-plugin-keyboard": "^2.2.1",
        "ionicons": "3.0.0",
        "phonegap-plugin-barcodescanner": "^6.0.7",
        "rxjs": "5.4.0",
        "sw-toolbox": "3.6.0",
        "uk.co.workingedge.phonegap.plugin.launchnavigator": "^4.0.1",
        "zone.js": "0.8.12"
    },
    "devDependencies": {
        "@ionic/app-scripts": "2.0.2",
        "@ionic/cli-plugin-cordova": "1.4.1",
        "@ionic/cli-plugin-ionic-angular": "1.3.2",
        "@types/jasmine": "2.2.34",
        "jasmine-core": "2.5.2",
        "karma": "1.4.0",
        "karma-chrome-launcher": "2.0.0",
        "karma-jasmine": "1.1.0",
        "karma-typescript": "2.1.5",
        "rimraf": "2.6.1",
        "rollup-plugin-replace": "^1.1.1",
        "typescript": "2.3.4"
    },
    "cordovaPlugins": [
        "cordova-plugin-console",
        "cordova-plugin-whitelist",
        "ionic-plugin-keyboard",
        "cordova-plugin-screen-orientation"
    ],
    "cordovaPlatforms": [
        {
            "platform": "android",
            "version": "",
            "locator": "android"
        },
        {
            "platform": "ios",
            "version": "",
            "locator": "ios"
        }
    ],
    "description": "bestellbar-hybrid2: An Ionic project",
    "config": {
        "ionic_rollup": "./config/rollup.config.js",
        "ionic_bundler": "webpack",
        "ionic_source_map_type": "source-map"
    },
    "cordova": {
        "plugins": {
            "cordova-plugin-wkwebview-engine": {},
            "ionic-plugin-keyboard": {},
            "cordova-plugin-whitelist": {},
            "cordova-plugin-console": {},
            "cordova-plugin-statusbar": {},
            "cordova-plugin-device": {},
            "cordova-plugin-splashscreen": {},
            "cordova-plugin-geolocation": {
                "GEOLOCATION_USAGE_DESCRIPTION": " "
            },
            "phonegap-plugin-barcodescanner": {
                "CAMERA_USAGE_DESCRIPTION": " "
            },
            "cordova-plugin-crosswalk-webview": {
                "XWALK_VERSION": "23+",
                "XWALK_LITEVERSION": "xwalk_core_library_canary:17+",
                "XWALK_COMMANDLINE": "--disable-pull-to-refresh-effect",
                "XWALK_MODE": "embedded",
                "XWALK_MULTIPLEAPK": "true"
            },
            "cordova-plugin-app-version": {},
            "uk.co.workingedge.phonegap.plugin.launchnavigator": {}
        },
        "platforms": [
            "android",
            "ios"
        ]
    }
}

@mehrad-rafigh You can check out my upgrade guide: https://forum.ionicframework.com/t/guide-how-to-update-to-ionic-3-x/87516

Hi @danielsogl . I actually used your guide to upgrade :/

Can you downgrade to app-scripts 1.3.12 and try it again (remove the  )

Hi @danielsogl. I tried your suggestion and it works. Seems to me that there is some issue with app-scripts

@mehrad-rafigh would you mind posting a repo we could use to reproduce this? I cannot reproduce it with any of my testing apps.

Hi @jgw96. Thank you for responding. Unfortunately I cannot share the repo...but...I figured out the problem. It is due to my rollup config, which replaces environment variables for our app, REST API Url and the like. So...where do I get some help about that? :(

I also use a custom rollup.config.js. In case this helps I'm going to paste here:
var nodeResolve = require('rollup-plugin-node-resolve');
var commonjs = require('rollup-plugin-commonjs');
var globals = require('rollup-plugin-node-globals');
var builtins = require('rollup-plugin-node-builtins');
var json = require('rollup-plugin-json');

// https://github.com/rollup/rollup/wiki/JavaScript-API

var rollupConfig = {
  /**
   * entry: The bundle's starting point. This file will
   * be included, along with the minimum necessary code
   * from its dependencies
   */
  entry: process.env.IONIC_APP_ENTRY_POINT,

  /**
   * sourceMap: If true, a separate sourcemap file will
   * be created.
   */
  sourceMap: true,

  /**
   * format: The format of the generated bundle
   */
  format: 'iife',

  /**
   * dest: the output filename for the bundle in the buildDir
   */
  dest: process.env.IONIC_OUTPUT_JS_FILE_NAME,

  /**
   * plugins: Array of plugin objects, or a single plugin object.
   * See https://github.com/rollup/rollup/wiki/Plugins for more info.
   */
  plugins: [
    builtins(),
    commonjs({
      include: 'node_modules/**',
      namedExports: {
        'node_modules/three/build/three.js':
        [
          'PerspectiveCamera',
          'OrthographicCamera',
          'Vector3',
          'Vector2',
          'Scene',
          'AmbientLight',
          'PointLight',
          'WebGLRenderer',
          'Matrix4',
          'MeshPhongMaterial',
          'FlatShading',
          'Mesh',
          'EventDispatcher',
          'Quaternion',
          'MOUSE',
          'DefaultLoadingManager',
          'XHRLoader',
          'BufferGeometry',
          'Geometry',
          'BufferAttribute',
          'Face3'
        ]
      }
    }),
    nodeResolve({
      module: true,
      jsnext: true,
      main: true,
      browser: true,
      extensions: ['.js']
    }),
    globals(),
    json()
  ]

};

module.exports = rollupConfig;

the file is at /scripts/rollup.config.js in my repo.

Hello, all! As this now seems to be an issue with you all's custom rollup configs I am going to close this as a support question. To get help with your rollup config's I would recommend that you ask this question on our forum or on our slack channel. Thanks for using Ionic!

@jgw96 Wouldn't it be worth find out why our changes break the build and writing a migration guide for people that have done changes to these files? Changes to these files in the way we have done them is a supposedly supported feature.

For me, the problem was that I used the wrong root path when importing json file in my code. For instance, I had to change ../../assets/i18n/en.json to ./assets/i18n/en.json.
With the --livereload it worked but not in --prod. But now with this changes it works.
Hope it will help!! :)


Get more than 100 Releases

_Originally posted by @stefanstranger in https://github.com/DarqueWarrior/vsteam/issues/35
The REST API includes an x-ms-continuationtoken response header that, unfortunately, is not readily accessible when using Invoke-RestMethod.  In order to access the response header(s) it may be necessary to use Invoke-WebRequest (or similar).
Steps to reproduce
Get-VSTeamRelease -definitionId 12 -Top 200
Get-VSTeamRelease -definitionId 12 -ContinuationToken '???'

Expected behavior

-Top 200 should return 200
Results should always include a ContinuationToken (if the response headers include x-ms-continuationtoken) to use in subsequent calls in order to retrieve all releases.

Actual behavior

-Top 200 returns 100
No ContinuationToken is returned, therefore it is not possible to request another page.

Environment data
OS

[ ] macOS
[X] Windows
[ ] Linux

Server

[ ] TFS 2017
[ ] TFS 2018
[ ] Azure DevOps Server
[X] Azure DevOps Service

> Get-VSTeamAPIVersion
Name                           Value
----                           -----
ServiceFabricEndpoint          5.0-preview
Build                          5.0
ExtensionsManagement           5.1-preview
Release                        5.1-preview
Version                        VSTS
MemberEntitlementManagement    5.1-preview
Packaging                      5.1-preview
Tfvc                           5.0
Git                            5.1-preview
Core                           5.0
Graph                          5.1-preview
DistributedTask                5.0-preview

> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      5.1.17134.765
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.17134.765
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

Thanks for the detailed issue. I will ping the team and see what we can do about this.

So I have good news and bad news.  Good news is there is a thread going internally to get to the bottom of this. Bad news this API call for releases is not implemented correctly at the moment. Once it is corrected we can add support.

This change is going to take a bit of work. The code currently uses Invoke-RestMethod and only in PowerShell Core does that call give you access to the returned headers. I just did some quick testing and I can change the code to still work in 5.x but you can't get to the headers there. This feature would only be supported in 6 or later.
Even with that it will take time to surface the continuation token up the stack so the caller will have access to it to pass to subsequent calls to get the rest of the items.
There is a second method of paging at APIs in AzD can support using $Top and $Skip.  However, the Release API only supports $Top at the moment and not $Skip. I have an email into the team to see if they plan to add the $Skip parameter support as well. If so that will be a much faster fix.

any update on that? I can try to implement something if the team was already able to fix the issue.

I rolled my own Get-VSTSRelease that indirectly calls Invoke-WebRequest as a workaround, but the effort to integrate it with (or conditionally circumvent) vsteam's _callAPI is a bit daunting.

Agreed. I am looking into other options as well. There have been internal threads on how the API has implemented this.

Are there any plans to move to PSCore? That would also solve the problem, wouldn't it?

@MichelZ isn't the module itself PSCore ready? I thought so always...


Defining & Passing data in more complex data structures like List & Dictionary Objects

In case user needs to pass data in more complex data structures like lists,dictionary,tuples etc, how can it be defined & passed as parameters inside functions(actions)?
Example:
List of standard common labels across application pages , to be verified  so the list of those labels/objects can be passed around as arguments to functions  to verify .

I made some changes and now the steps can accept different type of vars like tuples, dicts, lists, ints and booleans. The values will not be cast to strings as before. It also works when storing values in the data file.

@lucianopuccio can you still safe strings with this change in Data ? I am getting some odd behavior with this latest commit:
For instance , the following csv content for Data will result in an valueError when loading the testcase in the GUI:
csv content:

H1,H3,H2
AB,EF,CD

Error when trying to open this test case to edit it via the GUI:
ValueError: malformed node or string: <_ast.Name object at 0x7f6a82bfd128>
quoting the csv content like 'AB','EF,'CD' will make it load, BUT after saving the test case data is stored again without the single quotes

This is partially fixed now (0.3.1)
The issue with using csv is that every value is a string by default. So what Golem does is try to convert each cell value of the csv to another variable type and if it cannot, it falls back to string. So for instance, True without quotes will be converted to boolean, 123 without quotes will be converted to int, and so on. This is definitely not pythonic.
A better solution would be to use JSON instead. Something like this:
[
  {
    "user": "user1",
    "some_array": [1, 2, 3],
    "some_bool": true
  },
  {
    "user": "user2",
    "some_array": [4, 5, 6],
    "some_bool": false
  }
]

Conversion from JSON to Python is pretty straightforward.
A couple of caveats: in the test builder, in the data table, string values would require to be surrounded by quotes. Currently they do not require quotes, but this it not necessarily better.
Second, each data set would need to define the names for each value, as apposed to the CSV where they were just defined in the fist row, and all the data sets would need to be consistent.
Another approach, store single test data inside the test file itself (as an array of dictionaries). This is because I don't see much value in keeping it in a separate file. Or at least it could be optional to use either way.
Let me know what you think, thanks

I would suggest to keep it simple in that scenario and stick with the current functionality using CSV only for now.

I added the 'test_data' setting to define where should the test data be saved, setting it to 'csv' will work the way it was working before, setting it to 'infile' will store the data inside the test itself (as a list of dictionaries).
I think this can be closed for now. Thanks!

@NRfpneflfifcL so the import error was because the test file had invalid syntax? if that's the case it is expected. What can be improved is the logging so it is easier to debug. If that was not the case let me know.
Just in case. The infile data should be a dictionary or a list of dictionaries. each item in the list is considered a data set (the test will be run once per each data set) and in that case, all the test sets should have the same keys.
data = [
    {
        'username': 'username01',
        'password': 'password01'
    },
    {
        'username': 'username02',
        'password': 'password02'
    }
]

def test(data):
    # ...
    send_keys(some_element, data.username)
    send_keys(other_element, data.password)

If you have questions, feel free to ask here: https://gitter.im/golem-framework/golem
Have a good day!

Yes, test had a line with relative import that caused an error in import_module. Improved logging will help a lot for such cases. Thank you!


UI should appear when player is paused

Otherwise the window could look like this:

YouTube has the same behavior. The paused state causes the player controls to always show.

I believe this was fixed by @dcposch.


go: Version libyamlscript.h

Rename the generated libyamlscript.h file to include the version

Merged. Sorry didn't get marked that way.


Postgres installation and configuration

Should go after https://github.com/AppScale/appscale-thirdparties/pull/1.

Daily build no. 6926


Authentication errors should redirect by default

I'm creating this PR as a discussion point ONLY
I'm aware you're nervous of incorporating breaking changes and if agreed you'd likely roll this into your own vNext branches which I've seen discussed but do not appear to be public(?)
However, if you'd like me to create a workable request then please tell me which branch you'd like me to work off of.
What issue does this PR address?
Authentication errors do not appear to be handled as per the OpenId/OAuth specifications.
Firstly, please see https://openid.net/specs/openid-connect-core-1_0.html#AuthError which has a paragraph stating:

If the End-User denies the request or the End-User authentication fails, the OP (Authorization Server) informs the RP (Client) by using the Error Response parameters defined in Section <IP_ADDRESS> of OAuth 2.0 [RFC6749].

Now read https://tools.ietf.org/html/rfc6749#section-<IP_ADDRESS>, specifically the following paragraph:

If the request fails due to a missing, invalid, or mismatching
redirection URI, or if the client identifier is missing or invalid,
the authorization server SHOULD inform the resource owner of the
error and MUST NOT automatically redirect the user-agent to the
invalid redirection URI.
If the resource owner denies the access request or if the request
fails for reasons other than a missing or invalid redirection URI,
the authorization server informs the client by adding the following
parameters to the query component of the redirection URI using the
"application/x-www-form-urlencoded" format, per Appendix B:

This appears to me to state that all errors (other than for bad redirect URIs) should be returned to the client.
The OIDC spec then goes on to re-enforce this:

Unless the Redirection URI is invalid, the Authorization Server returns the Client to the Redirection URI specified in the Authorization Request with the appropriate error and state parameters.

Again, I only made this initial PR to help portray what I understand to be required here. I'm looking for your thoughts before taking this any further as to not waste time.
Does this PR introduce a breaking change?
Yes
Please check if the PR fulfills these requirements

[ ] The commit follows our guidelines
[ ] Unit Tests for the changes have been added (for bug fixes / features)

Other information:

Our implementation is following this guidance: https://tools.ietf.org/html/draft-bradley-oauth-open-redirector

appreciate the link, will have a look

I have read the document over and I may have interpreted it wrong but am I correct this specification only applies where an authorisation server permits the registration of 'unauthenticated' clients.
We have a closed system where clients are registered by administrators, and clients must authenticate securely (https://tools.ietf.org/html/rfc7521). In this case I believe we do not need such a mitigation.
Is there any scope to consider an option for this behaviour? Or will I need to provide a custom endpoint handler & result?

My boss has confirmed:

We are not an open redirector , we only redirect to predefined urls, setup out of bounds :+1:

So I would indeed be looking for an option to disable this behaviour if you'd consider such a PR (a non-breaking addition)?

Closing this non-PR in favour of this feature request: https://github.com/IdentityServer/IdentityServer4/issues/3400


Update to latest Zig Nightly

Currently errors on build/test due to changes in build and standard library in Zig nightly. Updated to work on Zig 0.14.0-dev.839+a931bfada, and also completed a small TODO to change man pages cache directory creation to pure Zig.
Tested both man page generation output in .zig-cache and passed all zig build test tests on x86_64 Linux.

We now pin only to release versions. We’ll update when 0.14 is out! Sorry.

Oh, got it! Would a quick update to the README be possible? I believe the README still states that libxev relies on Zig master.

Ah whoops. Yes that’s help. I’ll try to get to it another day too.


Prefer Ed25519 keys for authentication

Pending Ed25519 support in WebCrypto

https://deno.com/blog/v1.26#webcrypto-secure-curves 👀

The support for Ed25519 in<EMAIL_ADDRESS>doesn't seem mature enough just yet

<EMAIL_ADDRESS>has fixed support for Ed25519


Value type properties are not serialized properly

I encountered a regression in the recent Bridge.NET 16.1 release. When you call JsonConvert.SerializeObject() on an object that has a value type property, the property does not get serialized correctly. Adding the ObjectLiteral attribute to the class fixes the problem, so I believe it is related to changes in reflection in 16.1.
Steps To Reproduce
https://deck.net/cc50624a20455f41d38591fca347902b
public class Program
{
    public static void Main()
    {
        Product product = new Product();

        product.Name = "Apple";
        product.Price = 3.99;

        string output = JsonConvert.SerializeObject(product, Formatting.Indented);

        // Write the json string
        Console.WriteLine(output);
    }
}

public class Product
{
    public string Name { get; set; }

    public double Price { get; set; }
}

Expected Result
{
  "Name": "Apple",
  "Price": 3.99
}

Actual Result
{
  "Name": "Apple",
  "Price": {}
}

Confirmed. We will fix this immediately.

I think this also can be closed?
https://github.com/bridgedotnet/Bridge/issues/3066
I guess we need to compile only JSON package... Pls correct me if I am not right...

Version 1.1.0 was released, and Deck.NET has been updated. Your original sample is now working correctly.
https://deck.net/cc50624a20455f41d38591fca347902b


Installation, Usage, and Reference Materials

Hello, I would like to inquire about tinyspice. Could you please provide instructions on how to install and use the circuit simulator? Additionally, I'm curious to know if there were any specific reference materials or books that you consulted while developing TinySPICE?

Hi there - thanks for the interest!
I've updated the README with more instructions. Links to references can be found in the openoffice file Tiny-Spice_Circuit_Simulation.fodt in the docs folder.


master: almost all tilelayer.wms options are added to wmsParams

It looks like there is code in TileLayer.WMS that is meant to filter out crs, uppercase, and anything that looks like it belongs to this.options.  The crs and uppercase filters still work, but the rest of the options are passed on, e.g: pane, attribution, opacity, and tileSize.  These end up getting added to the URL, which is usually harmless, but can break things depending on the property.  (I've seen WMS services break when the attribution was set with HTML content).
I think this has to do with the use of hasOwnProperty() as the filter predicate which isn't working with the new this.options prototype stack.  In leaflet.wms' Overlay I ended up using an explicit blacklist but I'm not sure that's the right approach either.

Has this bug been fixed in Leaflet 1.0?


Add support for Partitioning::DistributeBy in expressions function

Which issue does this PR close?

Closes https://github.com/apache/arrow-datafusion/issues/3234
Rationale for this change

Optimizer rules re-write DistributeBy partitioning without any expressions without this fix.
What changes are included in this PR?

Handle Partitioning::DistributeBy
New integration test suite

Are there any user-facing changes?

Codecov Report

Merging #3229 (1988945) into master (c72f547) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #3229   +/-   ##
=======================================
  Coverage   85.83%   85.83%
=======================================
  Files         291      291
  Lines       52947    52948    +1
=======================================
+ Hits        45447    45449    +2
+ Misses       7500     7499    -1

Impacted Files
Coverage Δ

datafusion/expr/src/logical_plan/plan.rs
78.04% <0.00%> (+0.03%)
:arrow_up:

datafusion/core/src/physical_plan/metrics/value.rs
87.43% <0.00%> (+0.50%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jdye64  This is ready for review


ODataClient.Internals.cs - AssertHasKey can not throw exception...

...if the entity has no key requirement.
As per OData 4.01 it is valid to have an entity without key as contained entity that is unique - i.e. at the end of a :1 relationship.
This, i.e:
        var updatedResponse = await c.For<OdataApi.Event>()
            .Key(fetched.Identity)
            .NavigateTo<EventResponse>(x => x.Response)
            .Set(insertedResponse)
            .UpdateEntryAsync();

would update the Response navigation property on an Event class. This is a :1 relationship and marked as contained, and as such it does not have the requirement of a key.
Reference: http://docs.oasis-open.org/odata/new-in-odata/v4.01/new-in-odata-v4.01.pdf
Element 5.5: New: Key-Less Entity Types
Key properties of an entity type can now be part of a related entity type provided the navigation path to
the “remote” key property consists only of single-valued, non-nullable segments. And of course, these key
properties need an alias
Given that this is a runtime test, I am not sure it makes any sense to actually keep it.
Stack Trace:
Message:
Test method Tests.Api.Odata.Web.Controllers.EventTests.PostPutPatchResponse threw exception:
System.InvalidOperationException: No entry key specified.
Stack Trace:
RequestBuilder.AssertHasKey(FluentCommand command)
RequestBuilder.UpdateRequestAsync(Boolean resultRequired, CancellationToken cancellationToken)
ODataClient.UpdateEntryAsync(FluentCommand command, Boolean resultRequired, CancellationToken cancellationToken)
BoundClient`1.UpdateEntryAsync(Boolean resultRequired, CancellationToken cancellationToken)
EventTests.PostPutPatchResponse() line 270
ThreadOperations.ExecuteWithAbortSafety(Action action)
In this particular case, the check makes no sense and the patch chould be sent without a key for EventResponse.

Do we know that an entity has no key from the metadata model - if so we can make it conditional

We do.
Look at http://api.obb.tuev-daily.de/odata/$metadata
i.e.

This is a 1:1 relationship which is contained, so AccountProile per specs does NOT need a key.
It actually does not matter whether the ENTITY has a key or not.
As my code says:
var updatedResponse = await c.For<OdataApi.Event>()
.Key(fetched.Identity)
.NavigateTo(x => x.Response)
Here EventResponse is not a collection and there is a key for the Event. EventResponse actually has a key (for legacy reasons, pending removal), but you are not supposed to use it.
It alls dpends on the navigation. As I am moving from an entity with key throuh a :1 navigation property, a key is not needed because the object is uniquely identivied through the parent key and navigation property. The backend can / has to sort out which response is meant by using the key on the parent.

Can I suggest you provide a patch then ;-)
Let me know if you need a hand


Broke/can't start after 4.10.0 Upgrade daedalus-4.10.0-mainnet-21740

I launched Daedalus and it told me I need to update.  I accepted and it installed.  After the setup finish, upon launching I'm met with:
[Window Title]
Error
[Main Instruction]
A JavaScript error occurred in the main process
[Content]
Uncaught Exception:
Error: Could not locate the bindings file. Tried:
 → C:\Program Files\Daedalus Mainnet\resources\app\build\detection.node
 → C:\Program Files\Daedalus Mainnet\resources\app\build\Debug\detection.node
 → C:\Program Files\Daedalus Mainnet\resources\app\build\Release\detection.node
 → C:\Program Files\Daedalus Mainnet\resources\app\out\Debug\detection.node
 → C:\Program Files\Daedalus Mainnet\resources\app\Debug\detection.node
 → C:\Program Files\Daedalus Mainnet\resources\app\out\Release\detection.node
 → C:\Program Files\Daedalus Mainnet\resources\app\Release\detection.node
 → C:\Program Files\Daedalus Mainnet\resources\app\build\default\detection.node
 → C:\Program Files\Daedalus Mainnet\resources\app\compiled\14.16.0\win32\x64\detection.node
 → C:\Program Files\Daedalus Mainnet\resources\app\addon-build\release\install-root\detection.node
 → C:\Program Files\Daedalus Mainnet\resources\app\addon-build\debug\install-root\detection.node
 → C:\Program Files\Daedalus Mainnet\resources\app\addon-build\default\install-root\detection.node
 → C:\Program Files\Daedalus Mainnet\resources\app\lib\binding\node-v89-win32-x64\detection.node
    at bindings (C:\Program Files\Daedalus Mainnet\resources\app\dist\main\index.js:28264:9)
    at Object.../../nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-daedalus-modules-4.10.0/node_modules/usb-detection/index.js (C:\Program Files\Daedalus Mainnet\resources\app\dist\main\index.js:209884:163)
    at __webpack_require__ (C:\Program Files\Daedalus Mainnet\resources\app\dist\main\index.js:20:30)
    at Module../source/main/ipc/hardwareWallets/ledger/deviceDetection/eventDrivenDetection.ts (C:\Program Files\Daedalus Mainnet\resources\app\dist\main\index.js:222768:71)
    at __webpack_require__ (C:\Program Files\Daedalus Mainnet\resources\app\dist\main\index.js:20:30)
    at Module../source/main/ipc/hardwareWallets/ledger/deviceDetection/deviceDetection.ts (C:\Program Files\Daedalus Mainnet\resources\app\dist\main\index.js:222507:79)
    at __webpack_require__ (C:\Program Files\Daedalus Mainnet\resources\app\dist\main\index.js:20:30)
    at Module../source/main/ipc/hardwareWallets/ledger/deviceDetection/index.ts (C:\Program Files\Daedalus Mainnet\resources\app\dist\main\index.js:222867:74)
    at __webpack_require__ (C:\Program Files\Daedalus Mainnet\resources\app\dist\main\index.js:20:30)
    at Module../source/main/ipc/getHardwareWalletChannel.ts (C:\Program Files\Daedalus Mainnet\resources\app\dist\main\index.js:221105:98)
[OK]

I also checked the Windows Event Log for errors. There was nothing from Daedalus 4.10, but interestingly there was one from when 4.9.1 shutdown to begin the installation.

Note:

I've resolved the problem by uninstalling Daedalus, manually downloading the installer, then installing.
Reinstalling without first uninstalling didn't change anything

Hi @DerekZiemba do you have detection.node file in this path?

We cannot reproduce your error. We have retested your scenario today, and it simply works on our side. Could it be an antivirus you are using? Or a bitflip 😐 ?

@danielmain Yep.  But since I uninstalled and deleted the directory, I couldn't tell you what was there before.

We have retested your scenario today, and it simply works on our side. Could it be an antivirus you are using?
I have Antivirus/Defender disabled for performance reasons.

Or a bitflip

That's actually the first thought that popped into my head upon seeing eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-daedalus-modules-4.10.0 .  Surely that's not a real path?


Security Council Manager Affordance Change Action

Shifts some of the emergency council's privileges over to the non-emergency council. Specifically these 4 SecurityCouncilManager roles are transferred: MEMBER_ADDER_ROLE, MEMBER_REPLACER_ROLE, MEMBER_ROTATOR_ROLE, MEMBER_REMOVER_ROLE.
yarn ts-node scripts/printAccessControlRoles.ts shows the following roles on the manager:
Checking roles for 0xD509E5f5aEe2A205F554f36E8a7d56094494eDFC "Security Council Manager" on chain 42161

Accounts with '0x0000000000000000000000000000000000000000000000000000000000000000':
0xCF57572261c7c2BCF21ffD220ea7d1a27D40A827

Accounts with 'COHORT_REPLACER':
0x467923B9AE90BDB36BA88eCA11604D45F13b712C

Accounts with 'MEMBER_ADDER':
0x423552c0F05baCCac5Bfa91C6dCF1dc53a0A1641

Accounts with 'MEMBER_REMOVER':
0x6f3a242cA91A119F872f0073BC14BC8a74a315Ad
0x423552c0F05baCCac5Bfa91C6dCF1dc53a0A1641

Accounts with 'MEMBER_ROTATOR':
0x423552c0F05baCCac5Bfa91C6dCF1dc53a0A1641

Accounts with 'MEMBER_REPLACER':
0x423552c0F05baCCac5Bfa91C6dCF1dc53a0A1641

Documentation is also updated to reflect this change.
Proposal data: https://github.com/ArbitrumFoundation/governance/pull/290
Seatbelt: https://github.com/ArbitrumFoundation/governance-seatbelt/pull/30

+1 let's keep it as a strict subset of emergency powers

+1 let's keep it as a strict subset


fix: data-table border styling

Coverage remained the same at 89.783% when pulling d21ef112c339390470b3bc11fc368e70174ffeb1 on ciduarte/data-table into 7137541aba62bc7ef6b4a13044d7bc7d9970da19 on master.

:tada: This PR is included in version 13.17.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: