Generational backups not working

Ik looks like generational backups are not working.
I have my backups on last 7 daily + last 4 weekly + 12 monthly and 10 yearly

But all my backups are saved.
It looks like the settings are ignored.

Am I missing something?

I'm seeing the same thing.

From the logs, it looks like the correct backups to be deleted have been identified, but they are never deleted.
05/09/2024 16:27:26 [43] Verbose: File Sync Disabled...
05/09/2024 16:27:52 [18] Verbose: Checking backups
05/09/2024 16:27:52 [18] Verbose: Refreshing existing backups...
05/09/2024 16:27:52 [18] Verbose: Backup Interval Completed.
05/09/2024 16:27:52 [18] Verbose: Ignoring 'External' backup: WeeklyBackup: Monday, April 15, 2024
05/09/2024 16:27:52 [18] Verbose: Ignoring 'External' backup: MonthlyBackup: Monday, April 1, 2024
05/09/2024 16:27:52 [18] Verbose: Ignoring 'External' backup: MonthlyBackup: Wednesday, November 1, 2023
05/09/2024 16:27:52 [18] Verbose: Ignoring 'External' backup: core_2024.4.1
05/09/2024 16:27:52 [18] Verbose: Ignoring 'External' backup: MonthlyBackup: Tuesday, August 1, 2023
05/09/2024 16:27:52 [18] Verbose: Ignoring 'External' backup: MonthlyBackup: Thursday, June 1, 2023
05/09/2024 16:27:52 [18] Verbose: Ignoring 'External' backup: MonthlyBackup: Monday, May 1, 2023
05/09/2024 16:27:52 [18] Verbose: Ignoring 'External' backup: WeeklyBackup: Monday, March 25, 2024
05/09/2024 16:27:52 [18] Verbose: Ignoring 'External' backup: MonthlyBackup: Friday, March 1, 2024
05/09/2024 16:27:52 [18] Verbose: Ignoring 'External' backup: core_2024.5.1
05/09/2024 16:27:52 [18] Verbose: Ignoring 'External' backup: WeeklyBackup: Monday, April 8, 2024
05/09/2024 16:27:52 [18] Verbose: Ignoring 'External' backup: core_2024.4.3
05/09/2024 16:27:52 [18] Verbose: Ignoring 'External' backup: core_2024.4.4
05/09/2024 16:27:52 [18] Verbose: Ignoring 'External' backup: MonthlyBackup: Sunday, October 1, 2023
05/09/2024 16:27:52 [18] Verbose: Ignoring 'External' backup: YearlyBackup: Sunday, January 1, 2023
05/09/2024 16:27:52 [18] Verbose: Ignoring 'External' backup: core_2024.3.3
05/09/2024 16:27:52 [18] Verbose: Ignoring 'External' backup: Pre ramses_cc upgrade
05/09/2024 16:27:52 [18] Verbose: Ignoring 'External' backup: MonthlyBackup: Friday, December 1, 2023
05/09/2024 16:27:52 [18] Verbose: Ignoring 'External' backup: addon_core_ssh_9.13.0
05/09/2024 16:27:52 [18] Verbose: Ignoring 'External' backup: core_2024.4.2
05/09/2024 16:27:52 [18] Verbose: Ignoring 'External' backup: YearlyBackup: Monday, January 1, 2024
05/09/2024 16:27:52 [18] Verbose: Ignoring 'External' backup: MonthlyBackup: Saturday, July 1, 2023
05/09/2024 16:27:52 [18] Verbose: Ignoring 'External' backup: addon_a0d7b954_grafana_9.2.1
05/09/2024 16:27:52 [18] Verbose: Ignoring 'External' backup: MonthlyBackup: Thursday, February 1, 2024
05/09/2024 16:27:52 [18] Verbose: Ignoring 'External' backup: MonthlyBackup: Friday, September 1, 2023
05/09/2024 16:27:53 [38] Verbose: Last local backup Date: 05/09/2024 01:09:09
05/09/2024 16:27:53 [38] Verbose: Last online backup Date: 05/09/2024 01:09:09
05/09/2024 16:27:53 [38] Verbose: Online backups synced. No upload required
05/09/2024 16:27:53 [38] Verbose: Evaluating Online Generational Backups
05/09/2024 16:27:53 [38] Verbose: Backup (b83ae5a1 (05/04/2024 01:00:41) retained for Generational Daily policy OneDrive
05/09/2024 16:27:53 [38] Verbose: Backup (b1124422 (05/05/2024 01:01:12) retained for Generational Daily policy OneDrive
05/09/2024 16:27:53 [38] Verbose: Backup (228dc4ff (05/06/2024 01:01:45) retained for Generational Daily policy OneDrive
05/09/2024 16:27:53 [38] Verbose: Backup (b219d659 (05/07/2024 01:02:55) retained for Generational Daily policy OneDrive
05/09/2024 16:27:53 [38] Verbose: Backup (b22c747c (05/08/2024 01:05:36) retained for Generational Daily policy OneDrive
05/09/2024 16:27:53 [38] Verbose: Backup (fddb5250 (05/09/2024 01:09:09) retained for Generational Daily policy OneDrive
05/09/2024 16:27:53 [38] Verbose: Backup (fddb5250 (05/09/2024 01:09:09) retained for Generational Weekly policy OneDrive
05/09/2024 16:27:53 [38] Verbose: Backup (b83ae5a1 (05/04/2024 01:00:41) retained for Generational Weekly policy OneDrive
05/09/2024 16:27:53 [38] Verbose: Backup (3e0bcbe2 (04/27/2024 01:16:01) retained for Generational Weekly policy OneDrive
05/09/2024 16:27:53 [38] Verbose: Backup (af515d34 (04/20/2024 01:07:50) retained for Generational Weekly policy OneDrive
05/09/2024 16:27:53 [38] Verbose: Backup (fddb5250 (05/09/2024 01:09:09) retained for Generational Monthly policy OneDrive
05/09/2024 16:27:53 [38] Verbose: Backup (9960f4f6 (04/30/2024 01:18:06) retained for Generational Monthly policy OneDrive
05/09/2024 16:27:53 [38] Verbose: Backup (fddb5250 (05/09/2024 01:09:09) retained for Generational Yearly policy OneDrive
05/09/2024 16:27:53 [38] Verbose: Found 15 OneDrive backups that can be removed (Generational Rules)
05/09/2024 16:27:53 [38] Verbose: Potential OneDrive backups for removal: 3022b976 (04/14/2024 10:21:20),8f7c5796 (04/16/2024 01:00:46),b33e53f3 (04/17/2024 01:02:47),9d3be703 (04/18/2024 01:04:41),162f3f8a (04/19/2024 01:06:36),79db235d (04/21/2024 01:08:28),656873a7 (04/22/2024 01:09:14),529b8d58 (04/23/2024 01:10:21),7befcceb (04/24/2024 01:11:58),a10139cd (04/25/2024 01:13:38),7e1429d3 (04/26/2024 01:14:31),634518ef (04/28/2024 01:16:32),ac1fb793 (04/29/2024 01:16:53),5dde4913 (05/01/2024 01:19:53),20f4401b (05/02/2024 17:50:20)
05/09/2024 16:27:53 [38] Verbose: Evaluating Local Generational Backups
05/09/2024 16:27:53 [38] Verbose: Backup (b219d659 (05/07/2024 01:02:55) retained for Generational Daily policy local
05/09/2024 16:27:53 [38] Verbose: Backup (228dc4ff (05/06/2024 01:01:45) retained for Generational Daily policy local
05/09/2024 16:27:53 [38] Verbose: Backup (b22c747c (05/08/2024 01:05:36) retained for Generational Daily policy local
05/09/2024 16:27:53 [38] Verbose: Backup (b83ae5a1 (05/04/2024 01:00:41) retained for Generational Daily policy local
05/09/2024 16:27:53 [38] Verbose: Backup (fddb5250 (05/09/2024 01:09:09) retained for Generational Daily policy local
05/09/2024 16:27:53 [38] Verbose: Backup (b1124422 (05/05/2024 01:01:12) retained for Generational Daily policy local
05/09/2024 16:27:53 [38] Verbose: Backup (fddb5250 (05/09/2024 01:09:09) retained for Generational Weekly policy local
05/09/2024 16:27:53 [38] Verbose: Backup (b83ae5a1 (05/04/2024 01:00:41) retained for Generational Weekly policy local
05/09/2024 16:27:53 [38] Verbose: Backup (3e0bcbe2 (04/27/2024 01:16:01) retained for Generational Weekly policy local
05/09/2024 16:27:53 [38] Verbose: Backup (af515d34 (04/20/2024 01:07:50) retained for Generational Weekly policy local
05/09/2024 16:27:53 [38] Verbose: Backup (fddb5250 (05/09/2024 01:09:09) retained for Generational Monthly policy local
05/09/2024 16:27:53 [38] Verbose: Backup (9960f4f6 (04/30/2024 01:18:06) retained for Generational Monthly policy local
05/09/2024 16:27:53 [38] Verbose: Backup (fddb5250 (05/09/2024 01:09:09) retained for Generational Yearly policy local
05/09/2024 16:27:53 [38] Verbose: Found 15 local backups that can be removed (Generational Rules)
05/09/2024 16:27:53 [38] Verbose: Potential local backups for removal: 20f4401b (05/02/2024 17:50:20),9d3be703 (04/18/2024 01:04:41),656873a7 (04/22/2024 01:09:14),3022b976 (04/14/2024 10:21:20),79db235d (04/21/2024 01:08:28),7e1429d3 (04/26/2024 01:14:31),5dde4913 (05/01/2024 01:19:53),a10139cd (04/25/2024 01:13:38),ac1fb793 (04/29/2024 01:16:53),529b8d58 (04/23/2024 01:10:21),b33e53f3 (04/17/2024 01:02:47),7befcceb (04/24/2024 01:11:58),634518ef (04/28/2024 01:16:32),8f7c5796 (04/16/2024 01:00:46),162f3f8a (04/19/2024 01:06:36)
05/09/2024 16:27:53 [38] Verbose: Ignoring 'External' backup: WeeklyBackup: Monday, April 15, 2024
05/09/2024 16:27:53 [38] Verbose: Ignoring 'External' backup: MonthlyBackup: Monday, April 1, 2024
05/09/2024 16:27:53 [38] Verbose: Ignoring 'External' backup: MonthlyBackup: Wednesday, November 1, 2023
05/09/2024 16:27:53 [38] Verbose: Ignoring 'External' backup: core_2024.4.1
05/09/2024 16:27:53 [38] Verbose: Ignoring 'External' backup: MonthlyBackup: Tuesday, August 1, 2023
05/09/2024 16:27:53 [38] Verbose: Ignoring 'External' backup: MonthlyBackup: Thursday, June 1, 2023
05/09/2024 16:27:53 [38] Verbose: Ignoring 'External' backup: MonthlyBackup: Monday, May 1, 2023
05/09/2024 16:27:53 [38] Verbose: Ignoring 'External' backup: WeeklyBackup: Monday, March 25, 2024
05/09/2024 16:27:53 [38] Verbose: Ignoring 'External' backup: MonthlyBackup: Friday, March 1, 2024
05/09/2024 16:27:53 [38] Verbose: Ignoring 'External' backup: core_2024.5.1
05/09/2024 16:27:53 [38] Verbose: Ignoring 'External' backup: WeeklyBackup: Monday, April 8, 2024
05/09/2024 16:27:53 [38] Verbose: Ignoring 'External' backup: core_2024.4.3
05/09/2024 16:27:53 [38] Verbose: Ignoring 'External' backup: core_2024.4.4
05/09/2024 16:27:53 [38] Verbose: Ignoring 'External' backup: MonthlyBackup: Sunday, October 1, 2023
05/09/2024 16:27:53 [38] Verbose: Ignoring 'External' backup: YearlyBackup: Sunday, January 1, 2023
05/09/2024 16:27:53 [38] Verbose: Ignoring 'External' backup: core_2024.3.3
05/09/2024 16:27:53 [38] Verbose: Ignoring 'External' backup: Pre ramses_cc upgrade
05/09/2024 16:27:53 [38] Verbose: Ignoring 'External' backup: MonthlyBackup: Friday, December 1, 2023
05/09/2024 16:27:53 [38] Verbose: Ignoring 'External' backup: addon_core_ssh_9.13.0
05/09/2024 16:27:53 [38] Verbose: Ignoring 'External' backup: core_2024.4.2
05/09/2024 16:27:53 [38] Verbose: Ignoring 'External' backup: YearlyBackup: Monday, January 1, 2024
05/09/2024 16:27:53 [38] Verbose: Ignoring 'External' backup: MonthlyBackup: Saturday, July 1, 2023
05/09/2024 16:27:53 [38] Verbose: Ignoring 'External' backup: addon_a0d7b954_grafana_9.2.1
05/09/2024 16:27:53 [38] Verbose: Ignoring 'External' backup: MonthlyBackup: Thursday, February 1, 2024
05/09/2024 16:27:53 [38] Verbose: Ignoring 'External' backup: MonthlyBackup: Friday, September 1, 2023

The generational deletions are non-aggressive, so if the number of backups are underneath the Max Backups in your config they will not be deleted. Once the Max Backups number is reached, the backups will be deleted according to the set generational rules.

I think that introduces complications to the logic. The generational check currently only applies to retention not the backup creation schedule.
Say for example I have configured 1 daily and 2 weekly backups and have set my backup schedule to daily.
Every day when a new backup is created, based on retention only it will delete the previous days backup, essentially preventing a backup to be kept for over a week.
I tried going that route initially when I was implementing this but it introduced too many cases to handle and potential breaks.


Add running examples snakemake

I'm going to merge this so we have the Jenkins file in main to set up the pipeline


Questions about RoI

Hi, thanks for the wonderful work! It really inspired me a lot.
I  have some tiny issues with the fMRI signal. I wonder if we can get the precise RoI for each voxel, as shown in Table 2 of the supplements.  I wonder if we can know which region a certain voxel lies, like V1 or V2? (How can we visualize it?)
I would be more than grateful for your help!
Thanks again for your attention!

Hi @xiaoyao3302
The official NSD doc provides such info. Data preprocessing scripts from SDRecon and Brain-Diffuser handle ROI processing for specific voxels. For visualization, pycortex may be useful, though I haven’t personally used it. Hope this helps!

Many thanks for the quick and useful response, I will check the links! Thank you! Congratulations again for the wonderful work!


Issue#422 Implementation of CreateCluster() API

Implementation of CreateCluster API will be part of this PR.
Unit test case, Integration test and Sample example will be part of different PR

updated PR with all the changes from the master

I have written the Unit test case for create cluster for "no error", but some how I am getting backtrace in my unit test case "CreateCluster"  on line number 721 : auto actual = future.get();
I tried and debug but do not know where i am missing, and did not get any clue yet, If I get any pointer on this.
I have saved my code in below feature branch
https://github.com/GoogleCloudPlatform/google-cloud-cpp/compare/master...roopak-qlogic:Issue-422_SAVE?expand=1

Backtrace: error has been resolved, Thanks

yes I am doing my changes in my one of the branch, just for save my code, once they complete I will include in this PR for review, even bigtable/client/instance_admin.h indentation also fixed in my saved copy branch, tomorrow I will push all for review

Integration test and sample snippet will be in separate PR

Updated, Now it should be OK.


docs: Update Form to follow new component template

Component template details here: https://www.notion.so/carbondesignsystem/Component-template-working-doc-d0d04df0f71c4c64a45c01834ee90336
Find (and add) specific action items for components here: https://www.notion.so/carbondesignsystem/7a1a698e3ad544b1a4180e29febc0cd2?v=bcad0aa949cb4ce1931a71b3be24a771

This work will be covered in a new issue.

This work will be covered in a new issue.


add Particular.CodeRules 0.4.0

I'm not sure we want to add this package to this repo. This means we have to enforce our coding styles on the actual template content.
The templates are currently designed to match default VS as much as possible, which is why the using statements are located where they are, and we don't need to be enforcing ConfigureAwait in template code.

@bording I've only actually added the package to the tests project. Initially, I added it to all of them, and fixed the violations, but then I realised that we don't want the package ref to travel with the templates, so I removed it, but I left the violation fixes in.
However, you are correct that templates should remain as they are, so I'll revert the violation fixes.

@bording given that the only comment from your last review is addressed, I'm merging, but we can revisit if there's anything left outstanding.


Support decompiling to languages other than Solidity

Support decompiling to Yul and Vyper.
Yul description can be found here https://docs.soliditylang.org/en/latest/yul.html
Vyper examples can be found here https://docs.vyperlang.org/en/stable/vyper-by-example.html

Experimental support for Yul has been added. Vyper not planned for now.


About apm-sdk-plugin

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ ] Question or discussion
[ ] Bug
[x] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?

Bug

Which version of SkyWalking, OS and JRE?

Which company or project?

What happened?
If possible, provide a way to reproduce the error. e.g. demo application, component version.

Requirement or improvement

Please describe your requirements or improvement suggestions.
Our project  was Golang stack and now  we want to use skywalking as our open tracing platform，while there seems to be not so much support for Golang. I wonder if there‘s any schedule  for you excellent committers to overwrite the apm-sdk-plugin in Golang? If not maybe we can contribute some code to skywalking.

You are asking in the wrong place, check https://github.com/SkyAPM/go2sky
More importantly, read the documents. We gave all the links to all language agents.


handler: finalize the migration only when it is in complete state

The workload update migration relies on the change condition on the VMI to understand if the update migration needs to be canceled. The removal of the condition and the migration set to completed are racy. This change helps to coordinates the removal of the change conditions only after the migration it has been set as final.

What this PR does
Before this PR:
No coordination between the change conditions removal and workload update migration cancellation
After this PR:
Virt-handler finalized the migration only after the status of the migration has been set to completed

Fixes #12297
Release note

NONE

/test all

/cc @xpivarc

Checking if this change breaks something

/test all

/cc @vladikr

The current fix isn't correct, but I believe the right way to fix the issue is to remove the change conditions only when the migration is set to complete


Added distribution build.sh.

Signed-off-by: dblock<EMAIL_ADDRESS>Description
This is an updated build.sh from https://github.com/opensearch-project/opensearch-build/pull/1956 that publishes more than 1 ZIP. Will remove it from that PR.
Issues Resolved
Part of https://github.com/opensearch-project/opensearch-build/issues/1950
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Nevermind, I see https://github.com/opensearch-project/opensearch-build/pull/1956#issuecomment-1097141413


FalsePositive

class Foo{}
const Bar = Foo.bind(null);

assert(false === isCallable(Bar)); // fails, bound constructor is not callable
assert(false === isCallable(new Proxy(Foo, {})); // fails, constructor proxy is not callable
assert(false === isCallable(Proxy)); // fails, Proxy itself is not callable

You already filed this and we discussed it in #30 :-)

assert(false === isCallable(Proxy)); // fails, Proxy itself is not callable

That’s because Proxy.toString() returns:
function Proxy(target, handler) { [native code] }

Instead of:
class Proxy { [native code] }

I'm confused; in which engine does the toString include argument names?

It’s allowed by the specification: https://tc39.es/ecma262/#sec-function.prototype.tostring.

Sure it is, but which engines actually do it?


Initialization fixes

separate info from the control interface:
Better and cleaner to have info as a separate singleton object as other parts (like config and ctrl group management classes) also depend on it.
don't try to use uninitialized rdt interface
disable rdt interface if initialization fails
separate initialization from configuration:
Now SetConfig() must be separately called after Initialize().

Rebased

Codecov Report

Merging #1 (f081c2e) into main (85bb56a) will increase coverage by 0.74%.
The diff coverage is 56.60%.

@@            Coverage Diff             @@
##             main       #1      +/-   ##
==========================================
+ Coverage   48.91%   49.66%   +0.74%
==========================================
  Files           6        6
  Lines         877      888      +11
==========================================
+ Hits          429      441      +12
+ Misses        347      345       -2
- Partials      101      102       +1

Impacted Files
Coverage Δ

pkg/rdt/config.go
45.34% <33.33%> (ø)

pkg/rdt/rdt.go
54.28% <70.96%> (+2.57%)
:arrow_up:

pkg/rdt/info.go
54.28% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85bb56a...f081c2e. Read the comment docs.

Rebased


Slack Notifier dysfunctional

Description
See - https://github.com/layer5io/wasm-filters/actions/runs/1659252187

@leecalcote
This is already fixed in my previous PR.
Have a look at the latest workflow run https://github.com/layer5io/wasm-filters/actions/runs/1670343253
I think we can close this one 🤔

Oh! Excellent. Good. ✔


chore(ci): Improve CI

:tada: This PR is included in version 0.9.6 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[controller] Fix multiple AdminExecutionTasks working on the same store at the same time.

Summary, imperative, start upper case, don't end with a period

Current state: when we create AdminExecutionTask , we did not check if there is AdminExecutionTask for one store on the fly, so if one AdminExecutionTask  is waiting for a lock (e.g. updating  store operation waiting for the store level write lock and that lock is currently unavailable), it is possible that AdminConsumptionTask will create multiple AdminExecutionTask s for a single store until they occupy all threads from ExecutorService 's thread pool, they are all waiting for the same store-level lock.
Besides, executorService.invokeAll(tasks, processingCycleTimeoutInMs, TimeUnit.MILLISECONDS)
will cancel every invoked tasks, even the task is emitted by not getting thread from pool to execute.  ExecutorService will try to cancel the AdminExecutionTask  waiting for a lock after timeout, but that will not terminate that thread (as the acquiring locking operation by AutoCloseableLock is not interruptible).   Then that AdminExecutionTask  will keep occupying one thread from ExecutorService 's thread pool until the lock is released. Note here, skipping message will not be useful anymore.  Ideally, we expect the same stuck AdminExecutionTask could be terminated by InterruptedException, but currently lock waiting one by locks[i].lock() can not achieve that.
This PR has the following changes to address the issue:

Adding check to see if there is AdminExecutionTask is running for a store.
Integration test to simulate the lock.
Use executorService.submit instead of executorService.invokeAll, as the task timeout (e.g lock waiting) of executorService.submit will not be marked as done, so that main thread could check to see the thread is running.

How was this PR tested?

CI
Does this PR introduce any user-facing changes?

[ ] No. You can skip the rest of this section.
[ ] Yes. Make sure to explain your proposed changes and call out the behavior change.

I have a few questions:

is it expected to run some admin logic, which is not interruptible? I think we should make all the logic interruptible, otherwise, it can block the graceful shutdown.
Is there any particular type of admin message, which would stuck or take longer time than others?

We face a similar situation when implementing async gauge execution, and we adopted the following strategy, which seems to work well: tehuti-io/tehuti#31
cc @xunyin8

Regarding your questions:
One case for logic non-interruptible is:  our current store level lock acquiring inside VeniceHelixAdmin through AutoCloseableLock is not interruptible by using lock.lock(): https://github.com/linkedin/venice/blob/f07d0c13edcd64e730a88925390b4c739f4ac4f5/internal/venice-common/src/main/java/com/linkedin/venice/utils/locks/AutoCloseableMultiLock.java#L18. When a thread is waiting for the lock, it is not interruptible. We could improve this by using lock.lockInterruptibly(), but I found it will some test failure, which I am trying to figure out.
But thanks for suggested solutions, let me figure out if it works.

@haoxu07, LGTM and thanks for the fix.


Replace Lifeboat with Overcast

Once Lifeboat drops PGM support, replace any links to Lifeboat with Overcast Network and PGM. Map images will have to be moved to our repos as maps.oc.tc probably won't stay up much longer.

👍

https://github.com/MCResourcePile/MCResourcePile.github.io/pull/36


No interpolation on directory creation failure error message

When bandcampsync cannot create a directory, it outputs:
Failed to create directory: {local_path} ({e}), skipping purchase...

It should print the value of local_path and e. This line is the likely culprit:
https://github.com/meeb/bandcampsync/blob/d26f5de60a429cad12a617b9c2d22da6114715df/bandcampsync/__init__.py#L48

Ah yes, the stealthy missing f. I'll add that in short, thanks for the issue.

Fixed in the above commit and will be bundled into the next release.


Add builds for windows and macOS

Pull Request Checklist:

[x] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes #1500

[ ] Tests for the changes have been added (for bug fixes / features)

[ ] (If applicable) Documentation has been added / updated (for bug fixes / features)

[ ] CHANGES.rst has been updated (with summary of main changes)

[ ] Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

Adds both a Windows and macOS build to check the testing suite against different platforms.
the .lock file generated in the cache is now removed after the testing data has been copied, and the file lock has been released.
The prefetch argument for tox is now available for general testing environments.

Does this PR introduce a breaking change?
No.
Other information:
The approved tag is listed here to ensure that the relevant builds are being triggered. This PR still requires review approval.
In order to run Windows build tests, $ xclim prefetch_testing_data must be called first to gather the testing data.
Did you know that Windows doesn't support Unix-style File Locking (fcntl)? This was what was preventing asynchronous handling of testing data fetching from working.

No, you're right, this unfortunately doesn't resolve #1500, but I now know why the windows call to pytest on conda may have been failing previously.
I'm going to try running $ xclim prefetch as one of the setup commands prior to testing when we build on conda-forge from now, and that should fix any potential problems from that source.
I'm going to add a call to $ xclim --help here to get more information.

coverage: 90.171% (+0.01%) from 90.16%
when pulling 3e4b8ecc27ffb11a0d7a077b446c0bd446588b66 on multi-os-builds
into d09bd4bbb2f60e416f0d05d33f3bc78e8f42b647 on master.


Doc: Remove legacy webhook proposal

The Webhook proposal has been moved to the
operator-framework/enhancement repository in a recent PR [1]. This
commit removes a legacy proposal that exists in the olm repository.
Ref:
[1] https://github.com/operator-framework/enhancements/pull/9

/retest

Can we leave a placeholder with a link to the new doc, for people that have saved links to this one?

/retest

@ecordell addressed your comment.

/lgtm
/approve
doc-only


fix: Updates dynamic tables query parsing to correctly handle tables that include "as" in their name (#2329)

The Index in the query parsing is too greedy and grabs any string with the letter "as" in them. If a table has "as" then the query is never a match and the dynamic is recreated in every terraform plan.
Test Plan
I have not tested locally since I'm not comfortable running acceptance tests against our live snowflake account. Creating a draft PR in hopes that CI will run tests and you all can review and verify the change.
References
Attempts to fix #2329

Hey. It wouldn't work, e.g. because you can have " AS " as a part of the comment. Also, the cut number was not adjusted (3 -> 5).
I am closing it and following up on it in #2421 PR.


Allow users to tune out of channels

Discord allows permissions on a per-channel, per-user basis. Allow users to tune out of channels via a command which adds a permission stipulating that person cannot view that channel.
Three commands:
channel hide {channel} - hides channel
channel show {channel} - shows channel
channel hidden - gets all hidden channels for the user

Note: If somebody hides a channel they have no way of re-referencing it on channel show, unless they remember the channel's id, or
in channel show plain string is used to iterate through the guild's channels and find the channel user wants.


Remove CODEOWNERS

Retire CODEOWNERS after https://github.com/knative/test-infra/issues/2751

/approve
/lgtm


Fix overview section of explanation section

This PR fixes missing links and introduction to sub-sections of the Explanation section in the overview of explanation section.

Updated overview of the Explanation section. The following sections may be removed such as:

Conversational - the contents here are discussed in SDK & CUI
Motivation - the contents here are discussed in What can you do with Wechaty

Hi, my suggestion is:

We should merge Conversational and SDK & CUI together and commit all of the related changes to this PR.
We should merge Motivation and What can you do with Wechaty together and commit all of the related changes to this PR.

Also, I think the sequence of the overview part is different from the sidebar, I suggest they should use the same sequence, or it may confuse the reader.

Updated overview of the Explanation section. The following sections may be removed such as:
Conversational - the contents here are discussed in SDK & CUI
Motivation - the contents here are discussed in What can you do with Wechaty

Hi, my suggestion is:

We should merge Conversational and SDK & CUI together and commit all of the related changes to this PR.
We should merge Motivation and What can you do with Wechaty together and commit all of the related changes to this PR.

Also, I think the sequence of the overview part is different from the sidebar, I suggest they should use the same sequence, or it may confuse the reader.

Motivation is already part of  What can you do with Wechaty.


commonjs conditional statement

The current conditional statement allows the else block to execute.  Even if the first if statement is true in certain race conditions, the lack of the else if statement allows the else block to still run.  The browser then throws an Uncaught Reference error:

I've added this change on this pull-request -- https://github.com/rmm5t/jquery-timeago/pull/238


Start from isnt working

Testing with CLI and in .citrc file , both don't limit to start with location. maybe overwritten by the include list

AH im being an idiot, so include does override, startwith doesnt exclude items outside of the directore.


Redis Connectivity Issues in 1.2.2

Bug description
After upgrading the control plane from Istio v.1.2.0 to 1.2.2 we started getting the following error message on pods that have Istio sidecar running and connect to a redis instance outside the mesh
 [RedisException]
 read error on connection to redis.mydomain.io:6379

After checking the sidecar logs on affected pods, we found the following entries
[2019-07-10 10:10:09.297][20][warning][config] [external/envoy/source/common/config/grpc_mux_subscription_impl.cc:73] gRPC config for type.googleapis.com/envoy.api.v2.Cluster rejected: Error adding/updating cluster(s) outbound|6379||serviceA.ns.svc.cluster.local: cluster: cluster type 'original_dst' may only be used with LB type 'original_dst_lb'

ServiceA has the following kube config:
apiVersion: v1
kind: Service
metadata:
  name: serviceA
  namespace: ns
spec:
  clusterIP: None
  ports:
  - name: redis
    port: 6379
    protocol: TCP
    targetPort: redis
  selector:
    app: redis
    release: serviceA
  sessionAffinity: None
  type: ClusterIP
status:
  loadBalancer: {}

Note: the port name is: redis and there is no ClusterIP since its a headless service.
At this point all pods inside the mesh that made outbound calls to our external Redis instance, could not communicate until we rolled back to Istio 1.2.0
As a side note, I noticed other people having similar issues with redis headless services in Dicuss
https://discuss.istio.io/t/istio-ingress-gateway-always-stale/3018/2
Affected product area (please put an X in all that apply)
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[x ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Expected behavior
Redis communication happens properly
Steps to reproduce the bug
Upgrade the control plane from Istio v.1.2.0 to 1.2.2
Version (include the output of istioctl version --remote and kubectl version)
client version: 1.2.2
citadel version: 1.2.2
galley version: 1.2.2
ingressgateway version: 1.2.2
pilot version: 1.2.2
policy version: 1.2.2
sidecar-injector version: 1.2.2
telemetry version: 1.2.2
Client Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.4", GitCommit:"c27b913fddd1a6c480c229191a087698aa92f0b1", GitTreeState:"clean", BuildDate:"2019-03-01T23:34:27Z", GoVersion:"go1.12", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"13+", GitVersion:"v1.13.7-eks-c57ff8", GitCommit:"c57ff8e35590932c652433fab07988da79265d5b", GitTreeState:"clean", BuildDate:"2019-06-07T20:43:03Z", GoVersion:"go1.11.5", Compiler:"gc", Platform:"linux/amd64"}

How was Istio installed?
Helm Chart
Environment where bug was observed (cloud vendor, OS, etc)
AWS EKS
Additionally, please consider attaching a cluster state archive by attaching
the dump file to this issue.

Hi,
I have the similar problem using 1.2.2 in 1.20 everything works fine
The error:
org.springframework.data.redis.RedisSystemException: Redis exception; nested exception is io.lettuce.core.RedisException: java.io.IOException: Connection reset by peer
kube config:
apiVersion: v1
kind: Service
metadata:
  name: redis-sso
spec:
  ports:
  - port: 6379
    name: redis
  selector:
    app: redis-sso
  clusterIP: None
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: redis-sso
spec:
  selector:
    matchLabels:
      app: redis-sso
  strategy:
    type: Recreate
  template:
    metadata:
      labels:
        app: redis-sso
    spec:
      containers:
      - image: redis:5
        name: redis-sso
        ports:
        - containerPort: 6379
          name: redis-sso

Version (include the output of istioctl version --remote and kubectl version)
client version: 1.2.2
citadel version: 1.2.2
galley version: 1.2.2
ingressgateway version: 1.2.2
pilot version: 1.2.2
policy version: 1.2.2
sidecar-injector version: 1.2.2

Client Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.0", GitCommit:"e8462b5b5dc2584fdcd18e6bcfe9f1e4d970a529", GitTreeState:"clean", BuildDate:"2019-06-20T04:49:16Z", GoVersion:"go1.12.6", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"12+", GitVersion:"v1.12.8-gke.10", GitCommit:"f53039cc1e5295eed20969a4f10fb6ad99461e37", GitTreeState:"clean", BuildDate:"2019-06-19T20:48:40Z", GoVersion:"go1.10.8b4", Compiler:"gc", Platform:"linux/amd64"}

How was Istio installed?
Helm Chart and Quick Start Evaluation Install
Environment where bug was observed (cloud vendor, OS, etc)
Google Cloud

A simple workaround is remove the name: redis from ports. I think this new  filter/feature #14582 change the filter. I don't know how to change the PILOT_ENABLE_REDIS_FILTER to make a real test.
New kube config without problem
apiVersion: v1
kind: Service
metadata:
  name: redis-sso
spec:
  ports:
  - port: 6379
  selector:
    app: redis-sso
  clusterIP: None
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: redis-sso
spec:
  selector:
    matchLabels:
      app: redis-sso
  strategy:
    type: Recreate
  template:
    metadata:
      labels:
        app: redis-sso
    spec:
      containers:
      - image: redis:5-alpine
        name: redis-sso
        ports:
        - containerPort: 6379
          name: redis-sso

I found the issue and fixed it in both Master and 1.2 release.

@ramaraochavali Even with #16289,  i still can not access redis server, with error.
[2019-08-15 04:07:37.779][31][warning][upstream] [external/envoy/source/common/upstream/original_dst_cluster.cc:76] original_dst_load_balancer: No downstream connection or no original_dst.
[2019-08-15 04:20:28.242][31][warning][upstream] [external/envoy/source/common/upstream/original_dst_cluster.cc:76] original_dst_load_balancer: No downstream connection or no original_dst.

And the listener and cluster config is
$istioctl pc listener  cli-57fc5649dd-ch9sf --port=6379 -ojson
[
    {
        "name": "<IP_ADDRESS>_6379",
        "address": {
            "socketAddress": {
                "address": "<IP_ADDRESS>",
                "portValue": 6379
            }
        },
        "filterChains": [
            {
                "filterChainMatch": {
                    "prefixRanges": [
                        {
                            "addressPrefix": "<IP_ADDRESS>",
                            "prefixLen": 32
                        }
                    ]
                },
                "filters": [
                    {
                        "name": "mixer",
                        "typedConfig": {
                            "@type": "type.googleapis.com/istio.mixer.v1.config.client.TcpClientConfig",
                            "transport": {
                                "networkFailPolicy": {
                                    "policy": "FAIL_CLOSE",
                                    "baseRetryWait": "0.080s",
                                    "maxRetryWait": "1s"
                                },
                                "checkCluster": "outbound|9091||istio-policy.istio-system.svc.cluster.local",
                                "reportCluster": "outbound|9091||istio-telemetry.istio-system.svc.cluster.local",
                                "reportBatchMaxEntries": 100,
                                "reportBatchMaxTime": "1s"
                            },
                            "mixerAttributes": {
                                "attributes": {
                                    "context.proxy_version": {
                                        "stringValue": "65535.65535.65535"
                                    },
                                    "context.reporter.kind": {
                                        "stringValue": "outbound"
                                    },
                                    "context.reporter.uid": {
                                        "stringValue": "kubernetes://cli-57fc5649dd-ch9sf.default"
                                    },
                                    "destination.service.host": {
                                        "stringValue": "redis-cart.default.svc.cluster.local"
                                    },
                                    "destination.service.name": {
                                        "stringValue": "redis-cart"
                                    },
                                    "destination.service.namespace": {
                                        "stringValue": "default"
                                    },
                                    "destination.service.uid": {
                                        "stringValue": "istio://default/services/redis-cart"
                                    },
                                    "source.namespace": {
                                        "stringValue": "default"
                                    },
                                    "source.uid": {
                                        "stringValue": "kubernetes://cli-57fc5649dd-ch9sf.default"
                                    }
                                }
                            },
                            "disableCheckCalls": true
                        }
                    },
                    {
                        "name": "envoy.tcp_proxy",
                        "typedConfig": {
                            "@type": "type.googleapis.com/envoy.config.filter.network.tcp_proxy.v2.TcpProxy",
                            "statPrefix": "BlackHoleCluster",
                            "cluster": "BlackHoleCluster"
                        }
                    }
                ]
            },
            {
                "filters": [
                    {
                        "name": "mixer",
                        "typedConfig": {
                            "@type": "type.googleapis.com/istio.mixer.v1.config.client.TcpClientConfig",
                            "transport": {
                                "networkFailPolicy": {
                                    "policy": "FAIL_CLOSE",
                                    "baseRetryWait": "0.080s",
                                    "maxRetryWait": "1s"
                                },
                                "checkCluster": "outbound|9091||istio-policy.istio-system.svc.cluster.local",
                                "reportCluster": "outbound|9091||istio-telemetry.istio-system.svc.cluster.local",
                                "reportBatchMaxEntries": 100,
                                "reportBatchMaxTime": "1s"
                            },
                            "mixerAttributes": {
                                "attributes": {
                                    "context.proxy_version": {
                                        "stringValue": "65535.65535.65535"
                                    },
                                    "context.reporter.kind": {
                                        "stringValue": "outbound"
                                    },
                                    "context.reporter.uid": {
                                        "stringValue": "kubernetes://cli-57fc5649dd-ch9sf.default"
                                    },
                                    "destination.service.host": {
                                        "stringValue": "redis-cart.default.svc.cluster.local"
                                    },
                                    "destination.service.name": {
                                        "stringValue": "redis-cart"
                                    },
                                    "destination.service.namespace": {
                                        "stringValue": "default"
                                    },
                                    "destination.service.uid": {
                                        "stringValue": "istio://default/services/redis-cart"
                                    },
                                    "source.namespace": {
                                        "stringValue": "default"
                                    },
                                    "source.uid": {
                                        "stringValue": "kubernetes://cli-57fc5649dd-ch9sf.default"
                                    }
                                }
                            },
                            "disableCheckCalls": true
                        }
                    },
                    {
                        "name": "envoy.redis_proxy",
                        "typedConfig": {
                            "@type": "type.googleapis.com/envoy.config.filter.network.redis_proxy.v2.RedisProxy",
                            "statPrefix": "outbound|6379||redis-cart.default.svc.cluster.local",
                            "settings": {
                                "opTimeout": "5s"
                            },
                            "latencyInMicros": true,
                            "prefixRoutes": {
                                "catchAllRoute": {
                                    "cluster": "outbound|6379||redis-cart.default.svc.cluster.local"
                                }
                            }
                        }
                    }
                ]
            }
        ],
        "deprecatedV1": {
            "bindToPort": false
        },
        "listenerFiltersTimeout": "0.010s"
    }
]

------

$ istioctl pc cluster cli-57fc5649dd-ch9sf --fqdn="redis-cart.default.svc.cluster.local" -ojson
[
    {
        "name": "outbound|6379||redis-cart.default.svc.cluster.local",
        "type": "ORIGINAL_DST",
        "connectTimeout": "10s",
        "lbPolicy": "ORIGINAL_DST_LB",
        "circuitBreakers": {
            "thresholds": [
                {
                    "maxRetries": 1024
                }
            ]
        }
    }
]

Version 1.2.3 has resolved our issue.
https://istio.io/blog/2019/announcing-1.2.3/

@hzxuzhonghu you may be seeing a different issue. The cluster seems to be generated correctly now.


Use new krb5 download url when enable vcpkg

What changes were proposed in this pull request?
Use new krb5 download url when enable vcpkg, because the web site of krb5 has moved to https://www.kerberos.org/
How was this patch tested?

@zhouyuan  can you help to review? Thanks


Search SDK: Refactoring argument checks to reduce duplication

The changes in SearchServiceClient and SearchIndexClient are in response to earlier code review feedback. The rest is just my general annoyance with writing four lines of code to check for null when one would do.

Please hold off merging this until I get sign-off from my team. Thanks.

Ok, it's ready to merge now.


What is the order defining for Segment  at  the same level ?

Question
What is the order defining for segment  at the same level ?
My display:

actually , my calling order is :
/home/par
-> /home/test210
-> /home/test310
-> /home/test410
-> /home/test1
-> /home/test501
Isn't it order by start time ?
My data
{"data":{"trace":{"spans":[{"traceId":"6.6.1573622778174619","segmentId":"6.6.1573622778174626","spanId":0,"parentSpanId":-1,"refs":[],"serviceCode":"w.com","startTime":1573622778177,"endTime":1573622779586,"endpointName":"/home/par","type":"Entry","peer":"","component":"","isError":false,"layer":"Http","tags":[],"logs":[{"time":1573622779586,"data":[{"key":"message","value":"handleFoundRoute : App\\Controllers\\Home@par"}]},{"time":1573622779587,"data":[{"key":"message","value":"Redis execute [ expire ] BSID_3cj4rt0b51gu6fk35cbq0vhk9k"}]}]},{"traceId":"6.6.1573622778174619","segmentId":"6.6.1573622778452776","spanId":0,"parentSpanId":-1,"refs":[{"traceId":"6.6.1573622778174619","parentSegmentId":"6.6.1573622778174626","parentSpanId":0,"type":"CROSS_PROCESS"}],"serviceCode":"w.com","startTime":1573622778453,"endTime":1573622778773,"endpointName":"/home/testcall/320","type":"Entry","peer":"","component":"","isError":false,"layer":"Http","tags":[],"logs":[{"time":1573622778774,"data":[{"key":"message","value":"test call by 320"}]},{"time":1573622778774,"data":[{"key":"message","value":"handleFoundRoute : App\\Controllers\\Home@testcall"}]},{"time":1573622778774,"data":[{"key":"message","value":"Redis execute [ expire ] BSID_3cj4rt0b51gu6fk35cbq0vhk9k"}]}]},{"traceId":"6.6.1573622778174619","segmentId":"6.6.1573622778205991","spanId":0,"parentSpanId":-1,"refs":[{"traceId":"6.6.1573622778174619","parentSegmentId":"6.6.1573622778174626","parentSpanId":0,"type":"CROSS_PROCESS"}],"serviceCode":"w.com","startTime":1573622778206,"endTime":1573622778417,"endpointName":"/home/testcall/210","type":"Entry","peer":"","component":"","isError":false,"layer":"Http","tags":[],"logs":[{"time":1573622778431,"data":[{"key":"message","value":"test call by 210"}]},{"time":1573622778431,"data":[{"key":"message","value":"handleFoundRoute : App\\Controllers\\Home@testcall"}]},{"time":1573622778431,"data":[{"key":"message","value":"Redis execute [ expire ] BSID_3cj4rt0b51gu6fk35cbq0vhk9k"}]}]},{"traceId":"6.6.1573622778174619","segmentId":"6.6.1573622779019177","spanId":0,"parentSpanId":-1,"refs":[{"traceId":"6.6.1573622778174619","parentSegmentId":"6.6.1573622778174626","parentSpanId":0,"type":"CROSS_PROCESS"}],"serviceCode":"w.com","startTime":1573622779019,"endTime":1573622779432,"endpointName":"/home/testcall/412","type":"Entry","peer":"","component":"","isError":false,"layer":"Http","tags":[],"logs":[{"time":1573622779432,"data":[{"key":"message","value":"test call by 412"}]},{"time":1573622779432,"data":[{"key":"message","value":"handleFoundRoute : App\\Controllers\\Home@testcall"}]},{"time":1573622779432,"data":[{"key":"message","value":"Redis execute [ expire ] BSID_3cj4rt0b51gu6fk35cbq0vhk9k"}]}]},{"traceId":"6.6.1573622778174619","segmentId":"6.6.1573622779458109","spanId":0,"parentSpanId":-1,"refs":[{"traceId":"6.6.1573622778174619","parentSegmentId":"6.6.1573622778174626","parentSpanId":0,"type":"CROSS_PROCESS"}],"serviceCode":"w.com","startTime":1573622779458,"endTime":1573622779465,"endpointName":"/home/testcall/5","type":"Entry","peer":"","component":"","isError":false,"layer":"Http","tags":[],"logs":[{"time":1573622779466,"data":[{"key":"message","value":"test call by 5"}]},{"time":1573622779466,"data":[{"key":"message","value":"handleFoundRoute : App\\Controllers\\Home@testcall"}]},{"time":1573622779466,"data":[{"key":"message","value":"Redis execute [ expire ] BSID_3cj4rt0b51gu6fk35cbq0vhk9k"}]}]},{"traceId":"6.6.1573622778174619","segmentId":"6.6.1573622779491062","spanId":0,"parentSpanId":-1,"refs":[{"traceId":"6.6.1573622778174619","parentSegmentId":"6.6.1573622778174626","parentSpanId":0,"type":"CROSS_PROCESS"}],"serviceCode":"w.com","startTime":1573622779491,"endTime":1573622779545,"endpointName":"/home/testcall/54","type":"Entry","peer":"","component":"","isError":false,"layer":"Http","tags":[],"logs":[{"time":1573622779546,"data":[{"key":"message","value":"test call by 54"}]},{"time":1573622779546,"data":[{"key":"message","value":"handleFoundRoute : App\\Controllers\\Home@testcall"}]},{"time":1573622779546,"data":[{"key":"message","value":"Redis execute [ expire ] BSID_3cj4rt0b51gu6fk35cbq0vhk9k"}]}]}]}}}

This seems like multiple segments, rather than multiple spans. Right?
Right now it is not ordered from my understanding. We may need to add them by start time.

TraceQueryService#findRoots should order the return list, by start time.

Could you work on this? @bnubobby This should be an easy PR.

@wu-sheng
This multiple segments.
But in terms of start  time,  api "/home/test210"  should be ahead of   "/home/test310"
Maybe it's an interface error ?  I try it

This could be resolved in the backend.  Try to find this TraceQueryService#findRoots and order the result list, and check whether UI is working.

@bnubobby Any update? Have you tried the method I gave to you?

@wu-sheng
yes , Try to find this TraceQueryService#findRoots and order the result list  is ok.
I tried to submit PR,  but something went wrong   at
PR
Now I'm waiting for the new version

@bnubobby I am a little confused, that PR is not same as the method I gave you. What is the matter you mean?

@wu-sheng
maybe it's a mistake,   sort by database or sort by application  , I choose  database.
All in all, it's good to solve it, Thank you for your patience and  support.

Good to know. My PR is merged, this should be good in next release.


zip files cannot be used in 'path'

I believe this is due to a combination of two things:

zipfile's are not recognized as urls, because they do not use the standard :// syntax, they are instead just :.
When recognized as a URL, a / is added to the search path, which zipfile doesn't handle.

The following patch worked on my unix system:
diff --git a/runtime/autoload/zip.vim b/runtime/autoload/zip.vim
index ea086e088..6a12ac3c8 100644
--- a/runtime/autoload/zip.vim
+++ b/runtime/autoload/zip.vim
@@ -200,8 +200,8 @@ fun! zip#Read(fname,mode)
   set report=10

   if has("unix")
-   let zipfile = substitute(a:fname,'zipfile:\(.\{-}\)::[^\\].*$','\1','')
-   let fname   = substitute(a:fname,'zipfile:.\{-}::\([^\\].*\)$','\1','')
+   let zipfile = substitute(a:fname,'zipfile:\(//\)\?\(.\{-}\)::[^\\].*$','\2','')
+   let fname   = substitute(a:fname,'zipfile:\(//\)\?.\{-}::/\?\([^\\].*\)$','\2','')
   else
    let zipfile = substitute(a:fname,'^.\{-}zipfile:\(.\{-}\)::[^\\].*$','\1','')
    let fname   = substitute(a:fname,'^.\{-}zipfile:.\{-}::\([^\\].*\)$','\1','')

I expect it could easily be extended to windows, but I don't have such a system available to test.
This functionality would allow gf and :find to work with languages which have jars in their path such as Java, Clojure, etc.
I am happy to drive this, but I wanted to know if this is something that made sense, first.

It appears that this doesn't work entirely correctly as if you have multiple jars in your path, the existence check passes unconditionally on all of them.

It appears that this doesn't work entirely correctly as if you have multiple jars in your path, the existence check passes unconditionally on all of them.

I'd like to do:
let &path = 'zipfile:/home/dominic/.m2/repository/org/clojure/clojure/1.9.0/clojure-1.9.0.jar::'
:find clojure/core.clj

and have zipfile:/home/dominic/.m2/repository/org/clojure/clojure/1.9.0/clojure-1.9.0.jar::clojure/core.clj open.


Windows python 2.7 troubles

Two tests are disabled because they cause a segfault (!) when running in appveyor (2.7).
This should definitely be fixed before we can release.
a3d4e67
See also: https://github.com/inbo/niche_vlaanderen/issues/39 - switching to rasterio 1.0 dev versions is a possible solution.

https://github.com/conda-forge/rasterio-feedstock/issues/44

Update: I can now confirm that errors only happen when conda is used (with python 2.7). Using plain python no problems occur.

Fixed when using the latest rasterio build in conda.
https://github.com/conda-forge/rasterio-feedstock/commit/291097a049e83f2457f2ef80d9dba48f774ba43a
All tests are now enabled again.


rViz simulation size on Windows

ISSUE TEMPLATE ver. 0.4.0

Which TurtleBot3 platform do you use?

[X] Burger
[ ] Waffle
[ ] Waffle Pi

Which ROS is working with TurtleBot3?

[ ] ROS 1 Kinetic Kame
[ ] ROS 1 Melodic Morenia
[X] ROS 1 Noetic Ninjemys
[ ] ROS 2 Dashing Diademata
[ ] ROS 2 Eloquent Elusor
[ ] ROS 2 Foxy Fitzroy
[ ] etc (Please specify your ROS Version here)

Which SBC(Single Board Computer) is working on TurtleBot3?

[ ] Intel Joule 570x
[X] Raspberry Pi 3B+
[ ] Raspberry Pi 4
[ ] etc (Please specify your SBC here)

Which OS you installed on SBC?

[X] Raspbian distributed by ROBOTIS
[ ] Ubuntu MATE (16.04/18.04/20.04)
[ ] Ubuntu preinstalled server (18.04/20.04)
[ ] etc (Please specify your OS here)

Which OS you installed on Remote PC?

[ ] Ubuntu 16.04 LTS (Xenial Xerus)
[ ] Ubuntu 18.04 LTS (Bionic Beaver)
[ ] Ubuntu 20.04 LTS (Focal Fossa)
[X] Windows 10
[ ] MAC OS X (Specify version)
[ ] etc (Please specify your OS here)

Specify the software and firmware version(Can be found from Bringup messages)

Software version: [x.x.x]
Firmware version: [x.x.x]

Specify the commands or instructions to reproduce the issue.

Launch rViz simulation using roslaunch turtlebot3_fake turtlebot3_fake.launch

Copy and Paste the error messages on terminal.

Please describe the issue in detail.

The simulation display starts in a tiny rectangle at the bottom left corner of the window (see image above). It resizes and takes up the whole window, as it should from the beginning, as soon as I resize the rViz window.

Hello @rlkamalapurkar.
First of all, it would be appreciated if you could understand that ROS window is not an official supported OS for TurtleBot3.
I think there is a problem with Rviz.
If you post it on the ros forum or rviz github issue, you will be able to receive more accurate feedback.
thank you

This issue will be closed due to prolonged inactivity. if the issue persists, feel free to reopen it.


Transaction created by SBFN are not propagated to C++ nodes

Steps

Create transaction using Swagger API on SBFN
Check memory pool on Stratis-Qt/StratisD-Qt

Not an issue
This is explained by the small transaction fee
ERROR: AcceptToMemoryPool : not enough fees 6203feab1f6ba6bb6f535fa0c22f995f219e44c7810892307489dc6e5ef5b1d6, 1960 < 10000


UI: Show error toast for 500 server response while fetching glossary terms

Affected module
Does it impact the UI, backend or Ingestion Framework?
UI
Describe the bug
A clear and concise description of what the bug is.
A user was facing issue, initially all glossary terms were not displaying in the list but displayed after search. Server response was 500 while fetching glossary terms but no error toast was displayed.
To Reproduce

Expected behavior
A clear and concise description of what you expected to happen.
Error toast should be shown for failed API response to the user.
Version:

OS: [e.g. iOS]
Python version:
OpenMetadata version: [e.g. 0.8]
OpenMetadata Ingestion package version: [e.g. openmetadata-ingestion[docker]==XYZ]

Additional context
Add any other context about the problem here.

@aniketkatkar97 I assume this is fixed? cc @chirag-madlani

@harshach As the whole glossary was revamped, this should not be an issue now.


Renaming a project that is referenced results in a warning in the error list complaining about old name

Create a new Class Library (A)
Create a new Class Library (B)
Add a reference from A -> B
Rename B -> C

Expected: Reference to updated and no errors or warnings
Actual: Got a warning in the Error List about being unable to resolve the old name:
Warning		The referenced project '..\B\B.csproj' does not exist.	A	C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\15.0\Bin\Microsoft.Common.CurrentVersion.targets	1742

This looks to be a timing thing, probably coming from design-time build.

Filed this: https://github.com/dotnet/roslyn-project-system/issues/1426, which is probably ultimately the underlying cause - but I do question why a design-time build was launched based on the old snapshot.

Verified that this doesn't repro anymore.


2.9.14 version of the provider is not working on the proxmox 8.1.3

There are two main issues:

Plugin crush panic: interface conversion: interface {} is string, not float64 (This can be work-arounded by using MaartendeKruijf/proxmox provider)
Duplicate disk created when clonnig from the template.

Is there any provider version which fixes both issues?
Otherwise the provider cant be used at all.
Thank you very much!

check comments in these issues
https://github.com/Telmate/terraform-provider-proxmox/issues/863
https://github.com/Telmate/terraform-provider-proxmox/issues/884
https://github.com/Telmate/terraform-provider-proxmox/issues/887

@pescobar thank you, i already checked them. But i want to use the provider in proper way like:
terraform {
  required_providers {
    proxmox = {
      source = "telmate/proxmox"
      version = "2.9.1x"
      #source = "MaartendeKruijf/proxmox"
      #version = "0.0.1"
      #source = "TheGameProfi/proxmox"
      #version = "2.9.16"
    }
  }
}

:-)))
I mean this provider is the most downloaded one from all providers.
Otherwise, the idea of stable IaC on proxmox is not achievable.
Can i help somehow?

AFAIK the only way to get a working provider today is to build the latest code in master yourself. There are some docs in the issues I linked before
If you want to contribute to maintain the project you can join the discussion in https://github.com/Telmate/terraform-provider-proxmox/issues/884

Hi! Check work RC v3.0.1-rc1 on Terraform 1.6.6 / 1.7.1 with ProxMox 8.1.3. The error is gone. Everything works well. Thanks to all!

cloudinit doesn't work :/

@electropolis cloudinit works in v3.0.1-rc1. But there is a big problem with disks. This provider is awful!

@electropolis cloudinit works in v3.0.1-rc1. But there is a big problem with disks. This provider is awful!

cloudinit with snippets doesn't work at all. Disks ? what problem?

with snippets to?! Oh sh* )))
Here is problem with disks.

with snippets to?! Oh sh* ))) Here is problem with disks.

I managed to have it work as @Tinyblargon described here
I don't have any problem with disks but as I see in that issue there is no possibility to create disks in loop.

Yep )

Yep )

The only solution is to defined different tf file for servers with more than one disk. But for me it doesn't make sense. Probably I will set different tf file for different vm types. This is one is perfect for creating nodes for k3s purpose.

I want to create k8s cluster ) But I want to use different disks for system, logs and overlays. And two or more network interfaces.

Having additional disk in that cluster doesn't make sense in my opinion. Every node doesn't have any additional disk. Those additional disks are sharable object storage so Node can use RWX. Network interfaces? Network interfaces can be easily attached from cloudinit using network-config


feat: allow writing properties on creation selectively

Inspired by #5 and based on the latest version in master, I implemented an option __allowCreation that will receive an array of property keys that will be allowed to be set at creation.
For explanation and example check the updated README.
Added a specific test.

Might be worth it adding another test to check if update of whitelisted properties still fails.

Not sure about the instance id fix I introduced...


elixir-ls: 0.11.0 -> 0.12.0

Description of changes
Running  update.sh to bump to latest version :)
CHANGELOG: https://github.com/elixir-lsp/elixir-ls/releases/tag/v0.12.0
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

thank you @marsam!


Fix issue with pjax-standalone of resetting scroll position to top on popState (back/forward)

https://github.com/brigade/delayed-scroll-restoration-polyfill


Long delay (visually) before anything happens when selecting a new network

Switching from MAINNET to DEV for example, makes one think the action did not go through, so while you click the menu again.. the delay expires and refreshed the entire screen.
Makes for poor UX.
Indicate something is happening or speed up switching.

Just a side note: If you have a fast connection & the peers are not slow, you barely ever notice this. However I agree that it's still nice to show a loading indicator.


Shed 64-bit warnings for cgltf_write

Explicitly cast from cgltf_size to int to avoid unnecessary warnings. Also replaces a case of int for size_t and a couple of cases of size_t for cgltf_size.

I'm not sure if I made a mistake when requesting a review again - is that the best way of notifying you guys that I think I'm done with adjustments?


Can´t acces Advanced Wireless Terminal in other dimensions

I can´t access my storage system with the advanced wireless terminal in other dimension.
The terminal works perfectly all over the overworld.
I´ve load my chunks with the ftb chunks mod. The chunks are forceloaded but it still doesnt work.
Im playing on an selfmade minecraft fabric server. My server plays on the version 1.21.
The following is a list of the mod versions i`ve installed on the server:
ftb-chunks-fabric-2100.1.0.jar
ftb-essentials-fabric-2100.1.0.jar
ftb-library-fabric-2100.1.2.jar
ftb-teams-fabric-2100.1.0.jar
toms_storage_fabric-1.21-2.0.5.jar

Having the same issue with a similar modlist

I can't reproduce it, make sure you have the latest version installed on the server.


Correct incorrect service url

What? and Why?
Correcting url of the receipt service
Checklist

[ ] CHANGELOG.md updated? (if required)

Codecov Report

Merging #69 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #69   +/-   ##
=======================================
  Coverage   85.57%   85.57%
=======================================
  Files           6        6
  Lines         208      208
=======================================
  Hits          178      178
  Misses         30       30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7df8132...4016625. Read the comment docs.


Reaper 5.11

http://forum.cockos.com/showthread.php?t=170389

Thank you for the contribution. It was merged directly as 6e5e1479d83d4037ba9667fd8ad882441a650afc to keep commit history cleaner. Your contribution is still credited to you.


acknowledge use of futiles code

see https://github.com/apache/incubator-pekko-connectors/pull/167 (this issue is only needed if 167 is merged - I will probably update the #167 to include this)
https://github.com/johanandren/futiles (Apache license but has no NOTICE file)
part of https://github.com/apache/incubator-pekko-connectors/issues/55

added to #167


Choices field proper display in the ListView

When displaying a choices field in the ListView, it shows the actual value instead of the display, which is preferred in the CMS environment. Setting it to the field name memory_type displays this:

While if you put the actual helper method that gets added automatically, get_memory_type_display, it displays correctly the content, but displays an invalid title then:

It would be nice that before displaying the column, there would be a check trying to find a "get_XXX_display" in the instance, and if it's there, show that value instead of the field's value.

Instead of giving the field as a string in the fields list you can also give a (title, field) tuple so in this case you could do fields = [('get_memory_type_display', 'Memory Type')].
Another option is to give a verbose property to the model field, if given, this verbose name will be used instead of the field name.

Doesn't Marcos' solution help? [('get_memory_type_display', 'memory type')] That would solve your problem.
Or is it about automating this step, so you don't have to look up the field name in the model? If that's the case, it seems easier to just stick to Django convention. ChoiceFields aren't used all over the place anyway.

well the solution I mentioned fixes it, but get_{field}display should have worked implicitly in this case,
the fallback sequence should be: first try get{field}_display, if not available then use the field value.


FIX #57

Added a new method ExifUtils.readMetaDataAsTable which return a lua
table with all exif keys and values
Adapted ExfiUtils.findFirstMatchingValue accordingly
Removed unneeded methods

nice work. Great use of a branch

approved. will give you time to push/respond if you want before i merge.

merged. nice work.


matrix unanswered questions

Are you requesting a feature, reporting a bug or asking a question?
Asking a question
What is the current behavior?
Is there a way to find unanswered questions in a matrix.  I can do it for simple objects like textbox following this advice https://github.com/surveyjs/surveyjs/issues/1053 but I haven't been able to do it for any type of matrix control.
What is the expected behavior?
I"d like to enter "unanswered" in the question not answered and have it included in my result set
How would you reproduce the current behavior (if this is a bug)?
Provide the test code and the tested page URL (if applicable)
Tested page URL:
Test code
your_code_here

Specify your

browser:
browser version:
surveyjs platform (angular or react or jquery or knockout or vue):
surveyjs version:

@DCToddM Here is the example
Thank you,
Andrew


URL Encoder should treat newline to %0D%0A

Description

Steps To Reproduce

Go to 'Encoders / Decoders > URL'

Choose 'Encode'

Input:
123
123

Output will be 123%0D123 which is wrong. It should be 123%0D%0A123 or 123%0A123

Expected behavior
It should be 123%0D%0A123 or 123%0A123.
DevToys Version
Version <IP_ADDRESS> | X64 | RELEASE | b949a18 | b949a18
Relevant Assets/Logs
# - [02/20/2023 17:07:53]
Feature name: Failed to copy from custom text box
Custom message:
Exception message: OpenClipboard Failed (Exception from HRESULT: 0x800401D0)
Exception stack trace:
   at System.Runtime.InteropServices.McgMarshal.ThrowOnExternalCallFailed(Int32, RuntimeTypeHandle) + 0x21
   at __Interop.ComCallHelpers.Call(__ComObject, RuntimeTypeHandle, Int32) + 0xb8
   at __Interop.ForwardComStubs.Stub_17[TThis](__ComObject, Int32) + 0x24
   at Windows.ApplicationModel.DataTransfer.Clipboard.Flush() + 0x2c
   at DevToys.UI.Controls.CustomTextBox.CopyTextBoxSelectionToClipboard() + 0xc6

From my testing, it seems the inherent C# functions used for the URL Encoder have no option for it to return anything other than a %0D. It would require a custom function to either do the whole encoding or to scan for %0D and add %0A after or replace it.

Could be related to this issue
https://github.com/microsoft/microsoft-ui-xaml/issues/1826

I think @ebejko is right.  It's related to textbox control. Any text put it on that control. All the newline can only be interpret as \r only. It's so weird.
No matter what this issue should be addressed and it's fundamental. This should have some way to solve it.


Path from URL should be changed

The application currently reads the URLs and changes them to paths. This should be changed as the paths are already available in the version_number.json
"libraries": [
        {
            "name": "com.mojang:netty:1.6",
            "downloads": {
                "artifact": {
                    "size": 7877,
                    "sha1": "4b75825a06139752bd800d9e29c5fd55b8b1b1e4",
                    "path": "com/mojang/netty/1.6/netty-1.6.jar",
                    "url": "https://libraries.minecraft.net/com/mojang/netty/1.6/netty-1.6.jar"
                }
            }
        },

Fixed


Create SECURITY.md

Change the security you use
Make sure you have checked all steps below.
Issue

[x] My PR addresses the following issues and references them in the PR title. For example, "Issue 1234 - My Sleeper
PR"

Resolves https://github.com/gchq/sleeper/issues/XXX

Tests

[x] My PR adds the following tests OR does not need testing for this extremely good reason:

MyUnitTest

Documentation

[x] In case of new functionality, my PR adds documentation that describes how to use it, or I have linked to a
separate issue for that below.
[x] If I have added, removed, or updated any external dependencies used in the project, I have updated the
NOTICES file to reflect this.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi, thanks very much for the suggestion! I've raised this as an issue:

https://github.com/gchq/sleeper/issues/2361

I'll just close this for now as it seems to be just a template.

Please raise issues for anything you like. If you raise a pull request you can link it to the issue by filling in the template in the pull request description.


⚠ Bofrost.lu has degraded performance

In feb976d, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2234 ms

Resolved: Bofrost.lu performance has improved in 7426b8b after 6 minutes.


Serious development issues - will this plugin ever work as intended?

Let me first say that I love this plugin's intention. Everything it does is exactly what we need in obsidian, but don't have.
The only problem is, even with this plugin, we still don't have it.
Spaces has several basic issues that prevent it from being usable. It slows obsidian down, its limited methods of adding notes to spaces is convoluted, it takes ages to drag notes from underneath into a space/folder, you can't select multiple notes, and all that on top of the fact that its drag and drop is completely broken and always far off from where it should be. Like, why is it so beyond buggy?
The next thing is the flow editor. I don't even know where to begin with the issues going on here, but I'm sure you're aware of them. Sometimes it causes wikilinks to embed without being embed links. It also massively slows down note loading time, causes scroll issues, and other weird things.
The inline context doesn't even work properly. Adding tags and properties often do not update, which is just a non-starter. I mean, it entirely defeats the purpose of having that. Selecting a file icon and getting it to display is often a problem too.
I can't comment on the "maker mode" function because I disabled that (honestly) rather useless feature. But I'm sure some people use it. Maybe it could be handier if the user could cusomize the available options in the dropdown, but the options are so basic even my 10 year old nephew knows those codes and wouldn't use maker mode. That being said, don't let my characterization of this feature distract you from the greater issues.
Not to mention, Make.MD has tons of compatibility issues with other plugins. Of course this is bound to happen, but honestly, I've never seen it this bad before.
I find it amazing that there are so many people (in particular, youtubers and bloggers) lauding this plugin because it shows just how many people out there will support something that just doesn't work (yet) just because it's new and shiny. There is no way a reasonable person could use this plugin for more than a couple of weeks without completely giving up on it. I have talked to countless people who said they faced endless issues with this plugin, even people who say it constantly makes obsidian crash.
The development for this is so far out of control, I am wondering whether its issues will ever be sorted, and most of all, I wonder whether people will be more careful what they promote. This plugin is in the EARLY development stages, and has no place being shared to the average user, who will just waste their time adapting their workflows only to soon find they will have to revert back to what they were doing when they inevitably discover it's so buggy.

Thanks for the feedback! 0.7 is a rewrite of the backend for spaces and contexts to improve many of these issues and is currently in preview testing for the discord community. Expecting to release it in the next few days.
Get Outlook for iOShttps://aka.ms/o0ukef

From: huachuman @.>
Sent: Friday, March 31, 2023 7:47:19 AM
To: Make-md/makemd @.>
Cc: Subscribed @.***>
Subject: [Make-md/makemd] Development issues (Issue #85)
Let me first say that I love this plugin's intention. Everything it does is exactly what we need in obsidian, but don't have.
The only problem is, even with this plugin, we still don't have it.
Spaces has several basic issues that prevent it from being usable. It slows obsidian down, its limited methods of adding notes to spaces is convoluted, it takes ages to drag notes from underneath into a space/folder, you can't select multiple notes, and all that on top of the fact that its drag and drop is completely broken and always far off from where it should be. Like, why is it so beyond buggy?
The next thing is the flow editor. I don't even know where to begin with the issues going on here, but I'm sure you're aware of them. Sometimes it causes wikilinks to embed without being embed links. It also massively slows down note loading time, causes scroll issues, and other weird things.
The context don't even work properly. Adding tags and properties often do not update, which is just a non-starter. I mean, it entirely defeats the purpose of having that. Selecting a file icon and getting it to display is often a problem too.
I find it amazing that there are so many people lauding this plugin because it shows just how many people out there will support something that just doesn't work (yet). There is no way a reasonable person could use this plugin for more than a couple of weeks without completely giving up on it.
—
Reply to this email directly, view it on GitHubhttps://github.com/Make-md/makemd/issues/85, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAFHKNSGZ3DHSJ5O3LVHNQLW6274PANCNFSM6AAAAAAWORM2IY.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

0.7 has been released and should improve reliability considerably, would love to hear your feedback.

I'm running version 0.9.1004 and all I can say is that it's still pretty much breaking everything else that I had that was working.


Zombie lark process maxing CPU

Just saw a zombie lark process maxing out one of my cores. I don't have a repro yet, but putting this here to remind me/us to keep an eye out and see if we can repro/debug it.

@jonathandturner What OS do you have a zombie lark process on?


Add a property to the views to indicate the scale

Because the SkiaSharp views are using actual device pixels, this may be unexpected for some apps. I think we should expose two options:

A property to indicate the current scale
This is especially noticeable on UWP when dragging the window from a hi-res display to a low res monitor, the image should stay the same size when drawing with the same coordinates.
A property to enable automatic scaling
Currently, the rendering is done with device pixels, an option to draw with "base" pixels and automatically scale

These options might have a secondary option to indicate whether to scale the completed image (draw a bitmap of 100x100, but then scaling it up to 200x200 when blitting - may cause blurring) or to scale all drawing operations (drawing a bitmap of 200x200, but all draw operations are scaled up).

Definitely looking forward to this feature. I couldn't figure out why my sketch wasn't taking up the full size of it's parent component. I think this feature will fix that for me. Thanks for the awesome code!

I want to look at this some more in the next release, but for this release I decided to expose the current canvas size as a property. Although we still can't control the scaling to be used, we can calculate the scaling:
float scaling = view.CanvasSize.Width / view.Width;

This will get the canvas size from the last draw operation. If anything changes, such as the view's size, pixel density or scaling, then the canvas size will be recalculated on the next draw cycle. The update is not immediate. In the next release we could see about immediate updates, but for this release I am actually reading the values from the last canvas.

I have now also added a property (to the bitmap-based views) that can be used to disable automatic scaling:
// assume view.Size == (100, 100)
// assume iPhone retina (2x)

// a larger canvas on hi-res displays
view.IgnorePixelScaling = false;
// view.CanvasSize == (200, 200)

// the canvas size is directly related to display independent view size
view.IgnorePixelScaling = true;
// view.CanvasSize == (100, 100)

I only added this to raster-based views as this was a difference that might not be default for all platforms. GL-based views actually use the framebuffer dimensions and then is scaled to fit anyway. If this feature is desired on GL views for some reason, I can add it there. But right now, since scaling doesn't look so great, this is just for "compatibility" (if you can use that word).

@jasonCodesAway, remember you can also just scale your drawings up using the canvas matrix. In the latest released version (v1.55.0) I added a property called CanvasSize which you can use to detect the actual size of the canvas:
var scale = view.CanvasSize.Width / view.Width;

This scale can also be used to scale up the canvas before drawing:
SKCanvas canvas = ...;
canvas.Scale(scale);

In order to use other matrix translations, you can save and restore matrix state:
canvas.Save();
// . . .
canvas.Restore();

In the next version (probably v1.55.1) I added a property to disable screen scaling. But, this does not look so great as the image is just stretched. The best way to do this is to scale the canvas up, and draw to that. Then, when it is displayed, the image is still sharp. The reason this works is that it is just a matrix, and all drawing operations are scaled on the fly.

Awesome! Thank you. I'm making good use of SkiaSharp in our Xamarin Forms app :) 👍


Howto catch error without using logger ?

Hello Everyone, thank for this good lib...very useful :) I have read almost all the documentation and some source code and i don't find information about error catching. The only way to handle error is passing by ErrorLog:
<AuthenticationProvider configuration={oidcConfiguration} loggerLevel={oidcLog.ERROR} logger={authLogger}>
.....

I want to show network error in the page (through snackbar component). Is possible through logger but it's seems to be not natural way ? Is-it possible for example to catch network error ?
For example if i put wrong url authority server i get this error:

Thanks :)

We're getting the same error. Our Authentication Server is only accessible through a VPN, if the user is not connected to the VPN he'll get the Network Error message as well.

In v4 login function is a promise.
You can also subcrise to all internal events in order to get error.
Do you still need this? I will detail it in v4 the readme very soon.


CMake attempts to set properties on hdf5-static instead of hdf5-shared when BUILD_STATIC_LIBS is set to OFF

Description
CMake attempts to properties on hdf5-static instead of hdf5-shared when BUILD_STATIC_LIBS is set to OFF
https://github.com/InsightSoftwareConsortium/ITK/blob/15af3aed65693811448c9af22ce9d09ff9f3000a/Modules/ThirdParty/HDF5/CMakeLists.txt#L84
The test to decide if it is shared or static is performed on BUILD_SHARED_LIBS, perhaps it should be done on  BUILD_STATIC_LIBS ?
If one manually set BUILD_SHARED_LIBS to ON in the CMake cache, it fixes the issue.
Steps to Reproduce

Configure CMake with BUILD_STATIC_LIBS set to OFF
Get:

set_property could not find TARGET hdf5-static.
Perhaps it has not yet been created.
Call Stack (most recent call first):
  CMake/ITKModuleMacros.cmake:464 (itk_module_target_name)
  Modules/ThirdParty/HDF5/src/CMakeLists.txt:106 (itk_module_target)

Versions
v5.4.0
Environment
CMake 3.29.6

For the record, the interesting if(BUILD_SHARED_LIBS) set(ITKHDF5_LIBRARIES hdf5_cpp-shared...) appears introduced with pull request #2247 commit df5f96179af5220d080780e4fc31d3de7e23e7b3, by @KrisThielemans, Jan 10, 2021.

I cannot see anything wrong with my PR 😄 . I have no idea what the interaction is between BUILD_SHARED_LIBS and BUILD_STATIC_LIBS. It seems a bit surprising that both exist (and are not the opposite of eachother).

Thanks for double-checking @KrisThielemans 👍 I have to admit I don't understand the problem well enough 🤷

Hello, To give more context:
I just wanted to recompile a fresh ITK build after I stopped using it for a few years, when I pressed configure for the first time, I got this:

Because I wanted a dynamic build and BUILD_STATIC_LIBS was just in front of me, I set it to OFF without concern for BUILD_SHARED_LIBS which is at this step actually already in the cache, but as an advanced variable.
The helper message was just "Build Static Libraries" I thought setting it to OFF would be enough for a dynamic build.
The idea of BUILD_STATIC_LIBS is to allow both dynamic and static build for hdf5 and openj2
It is declared here as an option in the hdf5 module:
https://github.com/InsightSoftwareConsortium/ITK/blob/15af3aed65693811448c9af22ce9d09ff9f3000a/Modules/ThirdParty/HDF5/src/itkhdf5/CMakeLists.txt#L509-L531
There is a test to take care of both variable being set to OFF (my case), it will set a new variable ONLY_SHARED_LIBS to ON in order to force a dynamic build.
The problem is that this variable is not tested when hdf5 targets rare created.
The most conservative way to fix the problem is to add a test on ONLY_SHARED_LIBS
if (BUILD_SHARED_LIBS OR ONLY_SHARED_LIBS)
here:  https://github.com/InsightSoftwareConsortium/ITK/blob/15af3aed65693811448c9af22ce9d09ff9f3000a/Modules/ThirdParty/HDF5/src/itkhdf5/src/CMakeLists.txt#L1251
here: https://github.com/InsightSoftwareConsortium/ITK/blob/15af3aed65693811448c9af22ce9d09ff9f3000a/Modules/ThirdParty/HDF5/src/itkhdf5/hl/src/CMakeLists.txt#L60
and here: https://github.com/InsightSoftwareConsortium/ITK/blob/15af3aed65693811448c9af22ce9d09ff9f3000a/Modules/ThirdParty/HDF5/src/itkhdf5/c%2B%2B/src/CMakeLists.txt#L107
IMHO, it would be more user-friendly to keep things specific to one module using variable specific for the module -- If it was me, I would remove the BUILD_STATIC_LIBS option and use H5_ENABLE_STATIC_LIB and H5_ENABLE_SHARED_LIB declared later on as option. Same thing for opnjp2 if it is needed.

PS: I can do a PR with the conservative fix if you consider it relevant.

A PR with the conservative fix sounds good!

Ahh, but that would be a difference relative to upstream.

You would need to mark deviations with
 # ITK --start
 ...
 # ITK --stop

Think whether the additional maintenance is justified by convenience that change would bring, and how often that convenience would be exercised.

Maybe better would be a PR against upstream HDF5' relevant branches, and than updating ITK's bundled version of HDF5? But that is a lot more work.

Maybe better would be a PR against upstream HDF5' relevant branches, and than updating ITK's bundled version of HDF5? But that is a lot more work.

Sounds like a lot of work indeed.
In addition, the bug only rises later during ITK's configuration (even though it seems to be an inconsistency in HDF5), when it tries to add properties on non-existing HDF5 targets. HDF5 maintainers might not accept the changes for a 1.12.4 version (the bundled version is 1.12.1 which I could not find in the HDF5 repo). The current version of HDF5 is 1.16.0, and it seems that changes occurred regarding thees things, it might be fixed already.

Think whether the additional maintenance is justified by convenience that change would bring, and how often that convenience would be exercised.

TBH I don't feel qualified to decide about that. If I'm the only one stepping on this, it might be easier to let things are they are.

I would have to set BUILD_SHARED_LIBS to ON at some point anyway, perhaps the right thing to do is to set it visible in the cache (not mark as advanced) for convenience ?


[DO NOT MERGE] KB moniker branch

Opening (and then immediately closing) this PR so that the change history is preserved after the branch is deleted (and branch content can be restored later if needed).

Docs Build status updates of commit dec2813:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/OfficeDev/office-js-docs-pr, working directory: W:\xunq-s, target branch: master, target branch commit: 43735e90ba7a99a4654a19fe56fa4db1cc89e3e2, source commit: dec2813fdf5befc7daa2b5fdbf9b95760f5f1a40.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


No incoming http request at terminal

Hi,
With my old project, I see the incoming http requests at terminal like this:
POST /api/login 200 816 - 42.802 ms
POST /api/users/me 200 800 - 39.342 ms

But when I run this boilerplate, I see nothing at terminal, so can someone show me the way to enable terminal logs again? Very thanks!
My run script:
"scripts": {
    "dev": "nodemon -w server --verbose --exec 'NODE_ENV=development DEBUG=App,$DEBUG babel-node index.js --presets es2015,stage-3'",
    "start": "DEBUG=App,$DEBUG babel-node index.js",
    "test": "NODE_ENV=test mocha --trace-deprecation server/test/$file --compilers js:babel-core/register --timeout 20000 --slow 500"
  }

I'll have sometime in my hand this evening to investigate further. However, as something on top of my head: Express little logger as a middlewear might unblock you:
var logger = function(req, res, next) {
    console.log(`Logging the request: ${req.url}`);
    console.log(`Logging the respone status: ${res.status}`);
    next(); // Passing the request to the next handler in the stack.
}

I'll make sure I test & investigate the issue for you asap!

Thank you for quick reply, but I added morgan instead of use express.logger (I read this in Moving to Express 4). And very pleasure to hear something good about this from you.
Thanks!

@namhq1989 Morgan would work.  If you have a solution you like, I'd be happy to accept a PR that adds logging to this boilerplate by default.  Morgan and its default Express integration would be nice.

@developit I added it, please check and update your code.
Thanks!

Fixed after merging #22 :)


Create a print stylesheet optimized for generating hard copies or a PDF of the reveal.js slide decks.

Potential areas of exploration and improvement:

Standard branded page header and footers
Adjust type for printed matter rather than the screen
Page numbers
Extract links and display as footnotes

Hello @tima,
I'm interesting by this enhancement.
I think it would be fine to also have page numbers directly on deck, should I need to open a separate issue for this ?


play-java-ebean-example - JSR-303 validated property 'name' does not have a corresponding accessor

Hello,
I'm completelly new to play, so I don't understand much of it yet. I wanted to try java+ebean example, but it didn't compile. Since the problem was connected to sbt-play-ebean plugin, I updated it to 6.2.0-RC4. Play version itself was already tha latest 2.8.13.
Then I needed to change deprecated version of EbeanServer to Database and Ebean to DB:
I changed this:
private final EbeanServer ebeanServer;

this.ebeanServer = Ebean.getServer(ebeanConfig.defaultServer());

to this:
private final Database ebeanServer;

this.ebeanServer = DB.getDefault();

Now the application runs, but when I want to change any entity in the database, it crashes with this error:
play.api.http.HttpErrorHandlerExceptions$$anon$1: Execution exception[[IllegalStateException: JSR-303 validated property 'name' does not have a corresponding accessor for data binding - check your DataBinder's configuration (bean property versus direct field access)]]

I don't understand the databinder thing. It should work without getters/setters but it is not. List page is rendered well, the problem is in the edit page - none of the fields of the particular computer are prefilled, after saving it crashes.
Thank you for any help in advance!

@pogurek The sample should work now, please try again.

play-enhancer is not maintained anymore, so I recommend to stop using it and use getters and setters instead (or switch to a 3rd party library like lombok)

Lombok was another thing I was about to ask. However, I though there is some internal play mechanism which can deal with accessing entity attributes. Fine for me, though. Thank you!

Despite I like the idea of Lombok very much, I tend to not using it with accessing database. There are more caveats than advantages, imho. I wasted enough time with Lombok + JPA so far. Unless there is generic support for that I'm not going to bother. Maybe if Java Records could be used it might be helpfull. But I'm not an expert. Thanks again!


Video not working on firefox

Version

Phaser Version: 3.85.2
Operating system: windows 11 and android 14
Browser: Firefox

Description
On firefox the video game object is not working in some devices.
Example Test Code
https://github.com/user-attachments/assets/317bee4c-a2d1-4c69-a2b7-51bb59907b38
https://github.com/user-attachments/assets/73c7ffe7-2b27-4341-8481-bd221849ec9a
Additional Information
This example works in some devices and it also works canvas mode but it stops showing the video on firefox in android.

Which devices? Not all devices can play all video formats.

The computer is a windows 11 with a intel 11700k and a nvidia gtx 1650 and the android is a realme gt neo 3t, but it works correctly in other browsers the only problem is firefox.


fastgltf probably shouldn't use tellg to get file sizes, might not always be the file size

Seen here for example:
    std::ifstream file(path, std::ios::ate | std::ios::binary);
    auto length = static_cast<std::streamsize>(file.tellg());
    file.seekg(0);

This has some issues, and there is a bunch of discussion here: https://stackoverflow.com/questions/2409504/using-c-filestreams-fstream-how-can-you-determine-the-size-of-a-file
But long, short, if using c++17 or later, then:
   auto length = std::filesystem::file_size( path );

I am aware of this issue and I do use this answer's idea in the GltfDataBuffer. Could you please pinpoint a line where I do use tellg?


Base32 Decode or Encode

I see you're using "DecodeString". Is that intentionally or you it supposed to say "EncodeString"
key, err := base32.StdEncoding.DecodeString(inputNoSpacesUpper)
Thanks much

It is intentional. From the accompanying blog entry:

First we'll need to base32 decode the secret. Google presents it with spaces and in lowercase to make it easier to grok for humans, but base32 actually does not allow spaces and only allows uppercase letters. Thus:
original_secret = xxxx xxxx xxxx xxxx xxxx xxxx xxxx xxxx
secret = BASE32_DECODE(TO_UPPERCASE(REMOVE_SPACES(original_secret)))


[Farsight RPG Community Edition]css, attributes fix and skill update

Fixed width of "Punti Vitalità" label: The label was more large than the sheet max-size.

Fixed width of checkboxes: changed width from auto to 15px, there was an issue where to activate them you need to click slightly left.

Deleted ability "Manomettere": this ability came from an alpha version of the game, now has been deleted.

Fixed attributes in short bio: "Specie" and "Classe e Livello" was missing for attribute registration, now they will be saved properly.

Submission Checklist
Required

[X] The pull request title clearly contains the name of the sheet I am editing.
[X] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[X] The pull request makes changes to files in only one sub-folder.
[X] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: <   >  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is: <   > (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is: <   > (i.e. Dungeons & Dragons, FATE)

[ ] I have followed the Character Sheets Standards when building this sheet.

[ ] This sheet has been made on behalf of, or by, the game's publisher.
[ ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <   >
[ ] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

Character Sheet Info Roll20 Internal Use only.


Input doesn't set placeholderTextColor when using color tokens

Current Behavior
Using tamagui on web with NextJS.
It seems like the Input component is not recognizing the color tokens in it's placeholderTextColor prop. When using a regular color e.g. red it works but when I try to use a token $red it doesn't.
Inspected CSS:

Expected Behavior
It should work with color tokens.
Tamagui Version
1.15.0

Reproduction
Render an Input component somewhere and pass in `placeholderTextColor="$someToken"` as a prop.

System Info
System:
    OS: Linux 6.2 Fedora Linux 37 (Workstation Edition)
    CPU: (16) x64 12th Gen Intel(R) Core(TM) i7-1260P
    Memory: 14.96 GB / 31.04 GB
    Container: Yes
    Shell: 5.2.15 - /bin/bash
  Binaries:
    Node: 18.12.1 - ~/.nvm/versions/node/v18.12.1/bin/node
    Yarn: 3.3.1 - ~/.nvm/versions/node/v18.12.1/bin/yarn
    npm: 8.19.2 - ~/.nvm/versions/node/v18.12.1/bin/npm
  Browsers:
    Chrome: 112.0.5615.121
    Firefox: 113.0b3

This is working for me both on next.js (site) and sandbox (webpack) but the type isn't there, I'll fix the type

Fix going out here for types https://github.com/tamagui/tamagui/commit/a01477b9fe70870eab9a3ad3be5d21bebf578259