no audio

bot is displayed like its sending audio (green circle around avatar) but there is no sound coming from it

same issue. Getting this error:
2021-12-30 16:30:04: Estatus: Error cd conexión al canal
2021-12-30 16:30:04: Error: Could not find an Opus module! Please install @discordjs/opus, node-opus, or opusscript.
2021-12-30 16:30:04:     at new OpusStream (/home/ubuntu/discobot/node_modules/prism-media/src/opus/Opus.js:42:13)
2021-12-30 16:30:04:     at new Encoder (/home/ubuntu/discobot/node_modules/prism-media/src/opus/Opus.js:130:5)
2021-12-30 16:30:04:     at AudioPlayer.playPCMStream (/home/ubuntu/discobot/node_modules/discord.js/src/client/voice/player/BasePlayer.js:58:34)
2021-12-30 16:30:04:     at AudioPlayer.playUnknown (/home/ubuntu/discobot/node_modules/discord.js/src/client/voice/player/BasePlayer.js:53:17)
2021-12-30 16:30:04:     at VoiceConnection.play (/home/ubuntu/discobot/node_modules/discord.js/src/client/voice/util/PlayInterface.js:71:28)
2021-12-30 16:30:04:     at initDispatcher (/home/ubuntu/discobot/index.js:82:38)
2021-12-30 16:30:04:     at /home/ubuntu/discobot/index.js:61:4

fyi, I tried running the following which did the trick:
npm i discordjs/opus

You may have forgotten to install the application through NPM first. discordjs/opus is one of the dependencies listed within package.json.

Don't forget to install all dependencies, npm i discordjs/opus is mandatory. If for some reason you can't install opus, try npm i opusscript


Set Starting learning rate

This is not an issue per say, maybe a modification/extension
I feel there should be an argument to set the learning rate at epoch zero, then gradually increase it to the target learning rate over some number of epochs (=5 in the paper).
Let me know what you guys think

Feels the same.
Was wondering where the initial lr parameter at for a long time.


pull request for e2e test at 11/24/2016 15:26:07

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Llama 3 support?

Is Llama 3 (specifically the instruct models) supported by the code as-is (Llama 2 path), or are changes required (e.g., to support the new tokenizer)?
And, do you have any plans to release a pretrained Eagle for Llama 3? (e.g., like https://huggingface.co/yuhuili/EAGLE-llama2-chat-7B)

You need to modify the instruction templates (such as those in eagle/ge_data/ge_data_all_vicuna.py). Training the draft model for LLaMA 3 is our next step.

Hey @kalradivyanshu, support for LLaMA3 has now been updated.


Running boss_migrate:make fails if there's no priv/migrations directory

Hey guys,
I was playing around with CB and wanted to make a migration. The above happens if that directory isn't present. The error is fairly opaque, just {error,enoent}.
Is there a possibility to detect and create the directory or make the error more programmer-friendly?

That sounds reasonable. +1

If someone points me in the right direction, I can attempt to make this change.

I believe that required module for the changes is boss_migrate. It's source can be found here PATH_TO_YOUR_APP/deps/boss/src/boss/boss_migrate.erl. make/2 function should be changed (line 16).  However I was not able to reproduce this issue after default installation of CB. The issue was reproduced when I manually deleted priv/migrations folder.

It might be fixed in the latest version. I'll try again.

/priv/migrations created by default on new projects. not an issue anymore


root: populate ROOT_INCLUDE_PATH via the setupHook

Description of changes
The ROOT_INCLUDE_PATH variable allows to specify include paths to be used by cling, the C++ interpreter. Populating this variable would serve the same functionality as implemented in the cc-wrapper with adding -isystem to the compilation flags.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

cc @ShamrockLee @yipengsun

So, does this mean all C++ libraries listed in a nix-shell will be picked up by the ROOT interpreter? For example if I list boost as part of the buildInputs for my nix-shell, ROOT will be able to include boost headers and use them in the interpreter?
I guess boost is not a very good example, as it is mostly header-only. For C++ libraries that has a .so file, will just populating the ROOT_INCLUDE_PATH also make them work?

Good question. Yes, I believe header-only libraries, like most of the boost.dev, should just work with this. And shared libraries can be picked up automatically if they have a .rootmap file and are in LD_LIBRARY_PATH. Otherwise, they will have to be declared with a #pragma cling load("foo"), or R__LOAD_LIBRARY(foo), or a manual .L foo, or a gSystem->Load("foo") in rootlogon.C; well, something from this list should work.

Result of nixpkgs-review pr 189926 run on x86_64-darwin 1

9 packages built:

apfelgrid
applgrid
hepmc3
python310Packages.hepmc3
python39Packages.hepmc3
root
root5
xfitter
yoda-with-root


L2 Boomerang Doesn't Wake Up The Maku Tree

oos-randomizer_log_2018-08-11_080720.txt
I'll go through my completed vanilla game tonight to see which items can and can't wake up the Maku tree. The L-2 Boomerang is not one of them (or I'm doing something wrong).
E: Bombs do work but the timing isn't obvious so players could theoretically waste their ten "free" bombs trying to wake up the Maku Tree. Also not all casuals would think to try them (as I didn't).
Further Edit: Actually, it looks like the only items that can't wake up the Maku Tree are the bracelet, feather/cape, shovel, and the boomerangs, so maybe add a note to the readme file about using bombs to wake up the Maku tree?
Yet another edit: It looks like the Bracelet's locked behind itself again anyway (it's in the Square Jewel Chest) - I need the bracelet to leave town from the north (Blaino's got the flippers, which you can loop around the Moblin's Fortress to get there if you've got your animal companion (NOTE: or the Cape and Pegasus seeds if you have Moosh as your companion, or the Flippers if Ricky is your companion), but you still need to access Spool Swamp to activate animal companions, and you'd still need to have ember seeds and a feather) or to enter Spool from Subrosia, and I need ember seeds from the Spool Swamp tree to exit town from the east, and I need a feather to get into Subrosia from town anyway (which the nearest feather is... behind the ember seeds, which are growing in Spool Swamp)

IMO L-2 boomerang is a pretty nice starting item since you can get the 30 rupee chest in hero's cave with it (same deal with bracelet), which is enough for bombs and for Blaino. L-1 boomerang, on the other hand, is a terrible starting item. The items that can and can't wake up the Maku Tree are in the logic already; I tested them all, and yes, nearly everything works.
But yes, you are expected to use bombs if you don't get a starting item that pops the bubble. In fact, you can be expected to do D1 up to the dungeon item with bombs as your only weapon. The randomizer doesn't expect you to do extremely difficult tricks like HSS skip, poe skip, or magnetless D7, but it does expect you to do some less difficult speedrun/non-casual strats and it does expect you to be inventive. Other people have also expressed confusion over the boomerangs as starting items, so I could put a note in the readme, but by that logic I should be putting a lot of weird things in the readme, like how you can kill the moblins across the gap in D2 by throwing a pot from the previous room, or how you can push enemies into pits using the shovel, or how you can use scent seeds from a satchel as a weapon.
Sorry about the bracelet in the square jewel chest; that problem is specific to that chest and was fixed in 1.3.1 yesterday.

I'd suggest just a note about waking the Maku tree with bombs, framed as an example of the necessary creative thinking.

Added FAQ to readme in https://github.com/jangler/oos-randomizer/commit/dde06bb1542888e3faec77e1ca1363a4acc8ee2b.


Rubocop 0.46.0 -D flag suppresses "Missing frozen string literal comment" error

When running Rubocop 0.46.0 with the -D flag enabled on my project I get the following:
ben@project:~/project$ rubocop -D
Inspecting 30 files
..............................
30 files inspected, no offenses detected

When I run it without the -D flag I get:
ben@project:~/project$ rubocop
Inspecting 30 files
CCCCCCCCCCCCCCCCCCCCCCCCCCCCCC
Offenses:
Rakefile:1:1: C: Missing frozen string literal comment.
# Add your own tasks in files placed in lib/tasks ending in .rake,
^
config.ru:1:1: C: Missing frozen string literal comment.
# This file is used by Rack-based servers to start the application.
^
...
30 files inspected, 30 offenses detected

Expected behavior
With the -D flag I expect to also get 30 errors with the cop name added
Actual behavior
As above, no string literal errors
Steps to reproduce the problem
Create a file with this issue and use the -D flag in your call to rubocop
RuboCop version
0.46.0 (using Parser <IP_ADDRESS>, running on ruby 2.3.3 x86_64-linux)

@ben-rabid: I'm not able to reproduce this. I've tried a file with first line a comment, a blank line, or Ruby code. All variations correctly report an offense both with and without the -D option.
Please provide some file content for which you see this happening. 😀

@Drenmi very strange, here's another example:
ben@project:~/project$ rubocop
Inspecting 30 files
.......C......................

Offenses:

bin/bundle:1:1: C: Missing frozen string literal comment.
#!/usr/bin/env ruby
^

30 files inspected, 1 offense detected
ben@project:~/project$ rubocop -D
Inspecting 30 files
..............................

30 files inspected, no offenses detected

Contents of bin/bundle
ben@project:~/project$ cat bin/bundle
#!/usr/bin/env ruby
ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile", __FILE__)
load Gem.bin_path("bundler", "bundle")

Still can not reproduce. 😞 The only discernible difference is I'm on OS X.
Waiting to see if someone else can reproduce it. 😅

I also fail to reproduce this issue inside a Docker container.
0.47.1 (using Parser <IP_ADDRESS>, running on ruby 2.3.3 x86_64-linux)

@ben-rabid Can you still reproduce this? If you can, please try adding --cache false to both invocations and see what happens. I have a feeling it's related to caching.

@Drenmi @jonas054 We're running version 0.48.0 these days both rubocop -D and rubocop are reporting the issue as you'd expect.
I'm not sure when this changed on my environment, but it's working fine now. Thanks for taking the time to look into it, I wish I knew why it was being weird for me. It's on 64bit Ubuntu in a Virtualbox container.


Intraday Commodities and Government Bonds returning empty list

Hello, I am trying to get intraday data for both the commodities and government bonds exchange. I am pulling from Jan 1, 2020 to Jan 1, 2022. However, the request is returning an empty list. For reference, I am using symbols including CL.COMM and US3Y.GBOND
Thanks!

My mistake. Those markets only publish at 5 minute intervals.


Brief bug summary

Describe the bug
This error shows up in the apiserver logs when concurrent requests for the /api/users/me occur for the first time from the same user.
{"level":"error","ts":1687482540.8690588,"caller":"zap@v0.1.0/zap.go:87","msg":"can't create user record: duplicated key not allowed","status":500,"method":"GET","path":"/api/users/me" ....

How to Reproduce
Repeatedly run the TestConcurrentApiAccess e2e test.
Expected Behavior
No error should occur.  The /api/users/me call should be idempotent.
Deployment Environment
No response
Additional Context
No response

We may want to change the api.transaction(...) so that if it fails the first time, we try again a second time in hopes that it was an optimistic concurrency error and the 2nd run will gracefully handle the new DB state.


Is there a deployment tutorial for the platform?

Is there a deployment tutorial for the platform?

Please read our document https://tech.iotn2n.com/


certbot: add certbot.withPlugins

Simplifies making use of certbot plugins introduced in https://github.com/NixOS/nixpkgs/pull/92696.
This can be used to wrap certbot to include some plugins.
certbot.withPlugins has a similar calling convention as python*.withPackages:
certbot.withPlugins (cp: [ cp.certbot-dns-foo ])

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@FRidh I pushed the version that tries to use certbot.overridePythonAttrs, but doesn't work. Can you take a look? Otherwise, I'd propose to just drop the last commit and merge as-is.

See https://github.com/FRidh/nixpkgs/tree/certbot for what I would say is the preferred solution.

Agreed. Thanks for the commits! I pushed them to this PR (slightly modifying HEAD~1) while doing so. PTAL.

I'll squash the commits adding the withPlugins feature, but I think having individual commits of the refactor/move itself should make things more understandable.
The trailing whitespace cleanups are harder to get rid of, my editor is really persistent on cleaning these up :-D I'll see if I can move them into a individual commit, so git blame is happy - we should really just have a github check preventing them from occuring in first place IMHO.

Can I use this inside my system configuration? Not sure how to configure it
environment.systemPackages = with pkgs; [
  (certbot.withPackages (ps: with ps; [ certbot-dns-inwx ] ) )
];

You need to use certbot.withPlugins, not certbot.withPackages, so the following would work:
certbot.withPlugins (ps: with ps; [ certbot-dns-cloudflare ])

Note certbot-dns-inwx isn't packaged yet, but you can take a look at the other existing certbox-dns-* plugins, happy to review a PR adding inwx :-)

Thanks that worked for me, at least importing the plugin where I have the PR here https://github.com/NixOS/nixpkgs/pull/190677
Unfortunately it doesn't get recognized yet

[root@piproxy:~]# certbot certonly -a dns-inwx -d example.org
Saving debug log to /var/log/letsencrypt/letsencrypt.log
The requested dns-inwx plugin does not appear to be installed
Ask for help or search for solutions at https://community.letsencrypt.org. See the logfile /var/log/letsencrypt/letsencrypt.log or re-run Certbot with -v for more details.

Let's take this over to the PR, this is unrelated to the introduction of certbot.withPlugins itself.


allow for more than 64 items

Fixes and closes #1
Not sure how you feel about this. I assume since you used a uint64 and bit shifting to store the selected indexes that you were trying to be as space conscious as possible, so I tried to keep as much of that as I could.

Thank you for your PR.
I need to add unit tests and verify this feature before merging it.
Due to other busy matters, I may handle this PR on October 22nd.

I adjusted the existing tests to account for the changes. Idk if that's good enough for you.


Nuxt production build not including Global and Module CSS

Version
v2.12.2
Reproduction link
https://codesandbox.io/s/modest-shaw-3j0tm
Steps to reproduce
1.) Install vue-chartist via npm npm install vue-chartist
2.) Add Chartist css file to assets/css/
3.) Create vue-chartist plugin:
import Vue from 'vue'
import VueChartist from 'vue-chartist'
Vue.use(VueChartist)
4.) Update nuxt.config.js
- css: ['~/assets/css/chartist.css'],
-  plugins: ['~/plugins/vue-chartist'],
5.) "npm run dev" command will show that the chart is working in dev with a chart that is properly styled:

6.) "npm run build" command to build project
7.) Serving the /dist folder will show a chart that is missing styling and looks broken:

What is expected ?
Chart should look the same in dev as in production build
What is actually happening?
Production build seems to be missing global css from nuxt config leading to a chart that is there but missing styling/looks broken.
Additional comments?
From as best as I can tell I have been following the docs for including plugins and styling and I love Nuxt so I would 100% hope this is just me misunderstanding something in the docs rather than an actual bug but I can't see where I have gone wrong.
In addition the 'Font-Awesome'  module seems to be broken as well as I can see the icons on my project page when I load up the dist folder for a split second and then they disappear. Just like the Chartist charts they work fine in dev. I would assume there is some connection between the two not working but that is loaded via the 'modules' option in nuxt.config so I'm focusing on one thing at a time.
Thanks for any and all assistance!

This bug report is available on Nuxt community (#c10551)

I think purge css omits computed classnames from the build so you might need to add the 'nuxt-purgecss' plugin and then add whitelist entries to include the classes you need.

That would make sense except I usually use tailwind and I don't think I have had any problems with the those computed classes. And actually chartist.css is just plain css, so I do not think it has any compiled styling anywhere.

Check this out https://github.com/FullHuman/purgecss/issues/74
I ran into a similar issue recently with styling discrepancies between dev/prod and whitelisting certain classes from purgecss ended up resolving it.

+1 I'm also having the same issue with my build. I'm using fullpage.js, works fine on dev, but most of the styles are missing when running a production build.

try adding 'nuxt-purgecss' to your buildModules in your nuxt.config
then add any pattern involving 'ct-' to your whitelist
export default {
  purgeCSS: {
    whitelistPatterns: [
      /ct-.*/
    ],
}

Just wanted to state that updating the Nuxt Config file and whitelisting purgeCss with
"purgeCSS: {
whitelistPatterns: [/^ct/]
},"
and I seem to be good to go.
Thanks for all the help!

Like @nttdataxd you need to whitelist your classes if you use @nuxtjs/tailwindcss < 2.0


all_there? should give more explicit failure message

When all_there? fails, the current failure output is not very helpful to figure out what element/section has a problem:
Failure/Error: expect(home_page).to be_all_there
       expected `#<CourseHomePage:0x007ff910ec8518 @course_num="MAN 101", @course_title="How to Manny">.all_there?` to return true, got false

IOW, all_there? is good at finding problems, but not good at helping you pinpoint how to fix them. For that reason, I don't find all_there? useful at all.
It would be better if the output stated exactly which element could not be found. Ideally, the output would be like Capybara gives when you try to access an element that can't be found:
Failure/Error: expect(home_page.page_heading).to have_text('COURSE HOME')
     Capybara::ElementNotFound:
       Unable to find css "h2.page-title > spqn.title-text"

So, if all_there? could have failure output something like this, I'd love it:
Failure/Error: expect(home_page).to be_all_there
       expected `#<CourseHomePage:0x007ff910ec8518 @course_num="MAN 101", @course_title="How to Manny">.all_there?` to return true, got false
       (element 'page_heading' not found: Unable to find css "h2.page-title > spqn.title-text")

@stevof See also https://github.com/natritmeyer/site_prism#load-validations

@tmertens Load Validations -- very cool, is that new? I'll check it out. But I don't think that's what I'm asking for. The thing that prompted me to open this ticket about all_there? is this: our designers are refreshing the UI and making changes to markup and CSS. I want to call all_there? and have it tell me which elements can't be found.
I realize I could write code to do this, either roll my own, or use Load Validations, but that's a ton of work. Seems like all_there? is already iterating through the elements, so i just want it to have a more helpful error message.

booleans favour true / false assertions. Load Validations are being enhanced slightly at the moment


Only move the selected line if there is actually a line to move to.

This just helps sort out issues I was seeing where you could click outside the buffer and the selected line would seem to move. (I.e. open Oni2 and just click in the buffer that isn't line 1).
For now I've gone with a "don't move at all" but I could see that "move to the last line" would also be nice, so any opinions?

Ah, nice catch @CrossR , thank you for the fix!

For now I've gone with a "don't move at all" but I could see that "move to the last line" would also be nice, so any opinions?

I don't have a strong opinion here, the "don't move at all" behavior seems reasonable to me - we can change it down the road if there is a compelling reason 👍


Is including accessibility support in you roadmap?

Currently we are looking for a react component toolkit, but accessibility support is one of our top requirement, have you consider adding this support?

No. At least not in the near future.

thanks for the answer!


permissive -> permissive-

https://github.com/TheLartians/ModernCppStarter/blob/60769908b67fc9b34848e941314622209c8fb21a/CMakeLists.txt#L51-L52
This line of code is wrong. Being permissive means to let details slide.
permissive- means being conformant.
https://docs.microsoft.com/en-us/cpp/build/reference/permissive-standards-conformance?view=msvc-160

Oh yeah, seems to be a typo that got through code review in #80. 😱
Thanks for reporting!


"It looks like row 8 should actually have 3 columns, instead of 2. in line 7."

At https://github.com/Helsinki-NLP/LanguageCodes/blob/618bd4f54879d3efaec23c1e45d3b5f3e1a07370/data/iso639-5_to_iso639-3.tsv#L8, GitHub reports:

We can make this file beautiful and searchable if this error is corrected: It looks like row 8 should actually have 3 columns, instead of 2. in line 7.

It certainly is unusual for GH to be unable to render a .CSV or .TSV file as an HTML table.

Those data files are intermediate sources for the modules. I don't see a need to make them beautiful as long as they serve their internal purpose in a correct way. They are not really meant for browsing and searching.


NTR abnormal protein targeting to vacuole of  extracellular protein

Follow on from
https://github.com/pombase/fypo/issues/2719
I missed this.
I want to capture the vacuolar targeting of normally secreted proteins.
At present I'm just using
abnormal protein targeting to vacuole
Do you think its appropriate to have something along the lines
abnormal protein targeting to vacuole of  extracellular protein?

I looked at the paper, and I don't see this phenotype. I only see the other way round - Cpy1 is normally vacuolar, but secreted in the vps901 mutants; Cps1 is also normally vacuolar but kind of goes punctate cytoylasmic (as far as I can tell) in the mutants.
I can add a new term such as 'decreased protein targeting to vacuole', or even 'decreased protein targeting to vacuole, with protein secreted'. How specific do you want? How many terms?

or maybe everything you'd need went in for #2719 ...?

I looked at the paper, and I don't see this phenotype....

You are right ...I thought that the acid phosphatase secretion assay was  identifying pho1 in the vacuole instead of extracellular, but her it is only  not in the supernatant.

Oh I'm looking a the wrong paper. I'm still doing PMID:27082518 scrub that

I went back to the vps paper
curs/92800aaf61c226d9#
I still need
decreased protein targeting to vacuole, with protein secreted'
for that one, then I think i'm done.

decreased protein targeting to vacuole, with protein secreted FYPO:0005547

edit file: f60ef64b041e47900fcd4c23fc8df2509c03bb7a
release: 256754d4c284572089d920f8ed9bdab8139dce99


feat(mvp): Initial airdrop contract

moving from draft to test ci

Working on making the validation concurrent (so adding someone to the group doesn't invalidate all the others' proofs), but it also makes it so that if you remove someone from a group, there's a chance they might front-run your transaction and claim before being removed.
I think this is the way to go at Worldcoin, since we'd be adding people way more often than removing anyone, but open to discussion.


[Ready for Review] Prereg + Draft Registrations

Replacing https://github.com/CenterForOpenScience/osf.io/pull/3284
Associated proposal: https://docs.google.com/document/d/1-CdCKQCQFZ_ju5TEWqIKEII7WiellBurb53sGWJduJ0/edit
Purpose
The Prereg prize will require several new infrastructure components. In particular this project requires partial/draft registrations. This PR replaces the old registration creation workflow to support partial registration states and updates the UI to a more modern JS implementation.
Changes

Remove old style registration editor and replace with new editor
Add UI and backend support for DraftRegistration CRUD

Side Effects
Registrations page:
A new tab has been added to show and create Draft Registrations. This UI lets users create, edit, and delete Draft Registrations. The blue bar shows the progress of completed items in the registration form.
Old:

New:

Picking a template:
Users can now preview the registration schema before starting the registration process.
Old:

New:

Filling in form data:
Old:

New:

First pass (syntax) complete.

@HarryRybacki can you please pull the lastest code and confirm this is still a problem?

@samchrisinger all seems to be working now.

@samchrisinger UI issue -- upon starting a new draft registration (after selecting registration type and clicking start) the Last saved reports invalid date but should have a place holder or something.

Fix alignment:

Be sure to check the style guidelines for proper capitalization of help text, buttons,  etc.

Based on note from @HarryRybacki , I'll begin reviewing this PR in reference to [#OSF-3517]. (sorry for the confusion wrt #4280; I'll move comments over as appropriate)
Let me know if you need to make any changes to this PR during the review process- thanks!

Note for the reviewees per discussion with @HarryRybacki : due to our release timeline, I won't generally stall review for items that I mark [ui comment]. However, I will still note empty pages or unintuitive behaviors for advisement, even when I am not actively requesting an immediate change.
Final decision on whether UI changes are necessary will be left to the release team. Hope this helps clarify workflow.

When starting a brand-new post-collection registration, I get "invalid date" for "last saved", and clicking on the save button does not do anything. This should be checked and fixed before release.
There are no JS console errors, and I get these errors on a brand new project created specifically for the purpose of testing draft registrations. (to avoid schema migration issues) It has no content other than a name and description.

As discussed with Harry, there is a UI bug: continuing "next" on the prereg question UI eventually loops you back to the first question.
A progress indicator would be extremely helpful; this "next" button behavior is extremely unintuitive.

When starting a brand-new post-collection registration, I get "invalid date" for "last saved", and clicking on the save button does not do anything. This should be checked and fixed before release.

As a follow up to the comment above: I also see "invalid date" on the list of draft registrations tab.

Action items for #3476. Most of the blockers are one liners. It's not so bad, honest. Some items are negotiable, but others (like safe handling of user inputs) are not.
Insofar as a pass has been performed, pass ~1 complete. As with any long PR, I’ve gone through and triaged to produce a set of action items (for now and later).
Immediate blockers
Must be addressed before passing this basic code review.
Your own notes
Any TODO items called out by the devs themselves should be addressed before this gets to review. Here are github links; check for code comments also.

[ ] URL discussion

Visible UI glitches
Issues that are user facing. Fix now to save QA the trouble of a ticket.

Display of "invalid date" message

[ ] 1, 2
[ ] 3

[ ] Empty draft tab for non-admins
[ ] User-facing typo

Documentation, style, and cleanup
Small and easy cleanup in areas that will be used often or changed little. Most of these are one line or less.

[ ] A line was deleted, potentially breaking addon settings pages
Behavior of the autoload decorator should match what the docstring says it does. Two options exist (change function + uses, or change docstring)

[ ] Wording changes
[ ] Typo (or just change to str; no reason for url spec to contain unicode)
[ ] More conventional function decorator

[ ] Check whether permissions are too lax
[ ] Too much stuff in try/except block
Use context manager in unit tests

[ ] 1
[ ] 2
[ ] 3

[ ]  Keyword arguments are not positional.
[ ] Unused variable def
[ ] Logger.error
[ ] Ordering of imports- I won’t enforce making everything pretty, but at least don’t actively make things worse

Handling of user inputs and text
Good security habits are always in the scope of the PR.

Sanitization, escaping, bindings

[ ] Sanitize user inputs

All push_status_message usages should specify trust=False

[ ] 1
[ ] 2
[ ] 3

[ ] Use sjson filter and move to template
[ ] Method writes HTML when it should be writing text
[ ] KO binds HTML instead of text
[ ] HTML should never be in language.py, and it leads to display anomaly in markupsafe page

To be addressed in later development
Won’t block this round of code review, but should be addressed before the PR is merged.

[ ] Add some tests of permissions- who can and can’t access a given view

[ ] Use self.user.auth directly to enhance readability of above

[ ] Document what branched_from means
[ ] DRY test code
[ ] Instance vars can be local
[ ] Remove unused template import 1, 2
[ ] Mock unnecessary calls to archiver
[ ] Split unit test that does multiple things
Remove unused cleverness

[ ] There is a string method for this
[ ] Loops are a language feature (2x or more)
[ ] Computed Observable can be property

[ ] Clean up tests involving JSON payloads
[ ] Change unclear test name
[ ] Date to isoformat explicitly for readability (readability improvement; will save a trip to docs when parsing the datetime from viewmodels)
[ ] Computed can be pureComputed
[ ] Typo in test

Future notes
Things not reviewed
Large chunks of this PR had no review, because it references features to be implemented/reworked on side branches.

Files marked ignore
Large sections of JS dealing with comments, file picker widgets, etc
Swathes of commented out code for features to be implemented someday

JIRA tickets to be created

[ ] Spell out names of organizations in Prereg UI
[ ] Possibly malformed schema: A bunch of countries are missing from a schema list; we should check whether schema is malformed and possible typo
[ ]  Document what pre-existing flag fields on the node model do- I can’t review what should be set if I don’t know what the flags mean
Possible improvement: our schemas are paginated, but the UI is not. This makes some code unnecessarily convoluted.
[ ] A module has the same name as a builtin. Change that

Copy of @abought's post so I show progress easier
Action items for #3476. Most of the blockers are one liners. It's not so bad, honest. Some items are negotiable, but others (like safe handling of user inputs) are not.
Insofar as a pass has been performed, pass ~1 complete. As with any long PR, I’ve gone through and triaged to produce a set of action items (for now and later). I hope this is useful in some small way.
Immediate blockers
Must be addressed before passing this basic code review.
Your own notes
Any TODO items called out by the devs themselves should be addressed before this gets to review. Here are github links; check for code comments also.

[ ] URL discussion

Visible UI glitches
Issues that are user facing. Fix now to save QA the trouble of a ticket.

Display of "invalid date" message

[x] 1, 2
[x] 3

[ ] Empty draft tab for non-admins
[ ] User-facing typo

Documentation, style, and cleanup
Small and easy cleanup in areas that will be used often or changed little. Most of these are one line or less.

[ ] A line was deleted, potentially breaking addon settings pages
Behavior of the autoload decorator should match what the docstring says it does. Two options exist (change function + uses, or change docstring)

[ ] Wording changes
[ ] Typo (or just change to str; no reason for url spec to contain unicode)
[ ] More conventional function decorator

[ ] Check whether permissions are too lax
[ ] Too much stuff in try/except block
Use context manager in unit tests

[ ] 1
[ ] 2
[ ] 3

[ ]  Keyword arguments are not positional.
[ ] Unused variable def
[ ] Logger.error
[ ] Ordering of imports- I won’t enforce making everything pretty, but at least don’t actively make things worse

Handling of user inputs and text
Good security habits are always in the scope of the PR.

Sanitization, escaping, bindings

[ ] Sanitize user inputs

All push_status_message usages should specify trust=False

[ ] 1
[ ] 2
[ ] 3

[ ] Use sjson filter and move to template
[ ] Method writes HTML when it should be writing text
[ ] KO binds HTML instead of text
[ ] HTML should never be in language.py, and it leads to display anomaly in markupsafe page

To be addressed in later development
Won’t block this round of code review, but should be addressed before the PR is merged.

[ ] Add some tests of permissions- who can and can’t access a given view

[ ] Use self.user.auth directly to enhance readability of above

[ ] Document what branched_from means
[ ] DRY test code
[ ] Instance vars can be local
[ ] Remove unused template import 1, 2
[ ] Mock unnecessary calls to archiver
[ ] Split unit test that does multiple things
Remove unused cleverness

[ ] There is a string method for this
[ ] Loops are a language feature (2x or more)
[ ] Computed Observable can be property

[ ] Clean up tests involving JSON payloads
[ ] Change unclear test name
[ ] Date to isoformat explicitly for readability (readability improvement; will save a trip to docs when parsing the datetime from viewmodels)
[ ] Computed can be pureComputed
[ ] Typo in test

Future notes
Things not reviewed
Large chunks of this PR had no review, because it references features to be implemented/reworked on side branches.

Files marked ignore
Large sections of JS dealing with comments, file picker widgets, etc
Swathes of commented out code for features to be implemented someday

JIRA tickets to be created

[ ] Spell out names of organizations in Prereg UI
[ ] Possibly malformed schema: A bunch of countries are missing from a schema list; we should check whether schema is malformed and possible typo
[ ]  Document what pre-existing flag fields on the node model do- I can’t review what should be set if I don’t know what the flags mean
Possible improvement: our schemas are paginated, but the UI is not. This makes some code unnecessarily convoluted.
[ ] A module has the same name as a builtin. Change that

A test is failing.

@abought tests passing!

Confirmed tests passing, and that all items in the immediate blocker checklist have been resolved. There are two new comments worth looking at regarding those items.
I have not done any other form of re-review on this PR outside of that checklist, as I am informed that work has moved to an ongoing feature branch. Pinging @erinmayhood to determine best JIRA lane to move this ticket.
(preferably once the exception and the strip_html bits have been resolved. :) )

This PR appears to have been deprecated by ongoing work on the feature/draft-reg branch, and can probably be closed.


Error with multiple strings in the same line

This throws an error fyi:
const debug = require('debug')('example')

With the error:
Error: Cannot find module 'debug')('example'
    at Function.Module._resolveFilename (module.js:327:15)
    at Function.Module._load (module.js:278:25)
    at Module.require (module.js:355:17)
    at require (internal/module.js:13:17)
    at Object.<anonymous> (/Users/justin/.nvm/versions/node/v5.2.0/lib/node_modules/node-required/bin/required:191:7)
    at Module._compile (module.js:399:26)
    at Object.Module._extensions..js (module.js:406:10)
    at Module.load (module.js:345:32)
    at Function.Module._load (module.js:302:12)
    at Function.Module.runMain (module.js:431:10)

I'm assuming this has to do with a regular expression that is a little greedy.
Probably this line

I think this is a real issue still but I don't want to see it in my issue list anymore.


Feature: change accordion behavior on active state

Instead of dispaly: none and dispaly: block
use
visibility: hidden;
  height: 0;
  opacity: 0;

and
 visibility: visible;
  opacity: 1;

and then we can add transition effect:
  transition: visibility 0s, opacity 0.5s linear;

Hi @kob-e, why, what’s your use case?

Closing the issue until there’s a reply.


Guard against NPE in JavaTypeSignatureBuilders in methodArgumentSignature.

@jkschneider brought up a great point that java docs may refer to types that don't exist due to drift.
It's possible other symbols are missing types, and we will need a more holistic fix.
But this will guard against the NPE for now.
Note: This will cause the signature to be different than the source.
fixes #1377

I'm not sure this is fixed in the best place. Would method type attribution be missing or invalid on a javadoc element that referred to a non-existent method?

I'm not sure this is fixed in the best place. Would method type attribution be missing or invalid on a javadoc element that referred to a non-existent method?

Hmm, that's a great point.
The root issue may exist elsewhere.
There's no guarantee that the ClassSymbol was completed.
type() covers missing/bad type conditions and returnsUnknownTypes(), but it isn't called in several places.
I'm going to close this PR, since your comment makes a lot of sense.
Do you already have an idea of how this should be fixed?


circ_ap changes

stop using maneuver nodes for this.
create a function to do the DeltaV vector computation for the current vehicle state,
that is, for the current altitude and body, construct the circular orbit speed; then
from our orbital velocity, construct the desired orbital velocity that is horizontal
and has the right speed.
On the first call, store the UT of the apoapsis as the "start circ burn time", and
set up the throttle manager to use a function that obtains DeltaV from the above,
keeps the autopilot pointing us in the correction direction, and computes the throttle.
Throttle is zero until the "start circ burn time" is reached, then is the computed
throttle for the error controller, limited to 0..1, discounted based on attitude error.

fixed.


Pipeline workflow tests-be failing on main branch

Noticed it on https://github.com/HyphaApp/hypha/pull/2402: build log
Then tried building the pipeline against main branch just to confirm and it failed there as well: build log.
cc: @frjo

@sks444 Good catch!
I just run all the test in my local setup and there I see no errors.

@frjo, yes, this seems like a problem with python itself. https://bugs.python.org/issue44061
Let me take it ahead.


GeoLite2 (:geoip2) request.location.ip returns nil

Hi, I have set up geocoder to do the IP lookup locally with GeoLite2 (I am using the free GeoLite2-Country.mmdb binary database).
It works pretty good for my needs, but I can't use request.location.ip anymore, to return the visitors IP address. It returns nil.
request.location.country_code works btw (returns "AT" = country code for my country)

Hi @alereisan
You should be able to get the ip from request.ip directly. This will be the ip that was used to query the GeoipLite2 database. The request.location is the returned data of the query.

works perfectly, thanks!


Add SF Volume Disk Counter Sample and template

Purpose

Add SF Volume Disk Counter Sample and template

Copy Counter to counterSFVolumeDisk
Update service.yaml
Update schemaVersion to 1.0.0-preview2
Rename app,network,..  to be added suffix "SFVD"
Add \templates\counterSFVolumeDisk\sfvd_mesh_rp.windows.json

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code
az mesh deployment create --resource-group {rg} --template-url {…/templates/counterSFVolumeDisk/sfvd_mesh_rp.windows.json} --parameters "{'location': {'value': 'eastus'}}"

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check
Verify that the following are valid

...

Other Information

@VipulM-MSFT Can you please help merge this?

This needs to go to the  2018-09-01-preview branch, not master. API version and schema are tied to upcoming refresh.


Submitter name does not accept dashes (-)

Similar to issues #765 when entering my name: Marie-Odette St-Hilaire.

Thanks for creating the issue!  I submitted a fix that should be merged soon


Updated to null-safety, removed Firebase from Android

I know you have been working hard on the update, so I wanted to help where I could. I migrated the main plugin, not the example, to null-safety and I removed the FCM service for Android. I've tested this plugin along side the firebase_messaging plugin and it works flawlessly. You can set up firebase_messaging's background handler to run the following function and it will create a notification from this plugin every time you receive a push notification, even if the app has been killed. This allows use of action buttons with the flexibility of push notifications. The only thing I've been trying to figure out is how to not show the default FCM notification and only show the AwesomeNotification instead.
Future<dynamic> _onFCM(RemoteMessage message) async {
  WidgetsFlutterBinding.ensureInitialized();
  AwesomeNotifications().createNotification(
    content: NotificationContent(
      channelKey: "Basic",
      id: 4,
      title: message.notification?.title ?? "New Notification",
      body: message.notification?.body ?? "",
    ),
    actionButtons: [
      NotificationActionButton(
        key: 'Reply',
        label: 'Reply',
        buttonType: ActionButtonType.InputField,
      ),
    ],
  );
}

#97
#128

Excelent! Now i gonna check your changes and merge it with the actual 0.0.6. Thank you so much!!

@rafaelsetragni  One thing I noticed while going through your source code is that you seem to use nullable values very often, but you could very well make many of them non-nullable. For example, in the Android Java code you have a HashMap for default values in case the user enters a null value. While that's a great idea, I think it would just be easier to make some of those values non-nullable in the first place (Notification id, title, channel key, etc). It would make your project more maintainable for yourself as well because you don't have to handle so many different edge cases. Just my 2 cents.

@rafaelsetragni One thing I noticed while going through your source code is that you seem to use nullable values very often, but you could very well make many of them non-nullable

They are nullable many times because when you receive a push data, you are not sure that any field will be filled, even the non-nullable. So, I made a hash map with these default values to ensure that at least the critical fields will be filled, even in the worst scenario, and the notification will be delivered.

I think now that you’re removing firebase notifications service you can be confident that the notification that’s delivered follows the correct format. Even if a scheduled notification is corrupted somehow, it might be better not to show a notification and instead display an error for the developer to handle. That way there’s never any weird behavior to deal with.


Move cs file to subfolder creates error "file not found" on start scene

Godot version:
3.0rc1 mono version
OS/device including version:
Not related.
Issue description:
When I move a cs file to a subfolder and I want to run a scene, I get an error because the cs file cannot be found any more:
As it is german I translate it to english.
CSC(0,0): Source file "D:\Programmieren\godot\error\Test.cs" was not found
Steps to reproduce:

Create project, add a spatial node and attach a cs script called "test.cs".
Start the project - works.
create a subfolder with any name
move the cs file to the subfolder.
Start scene, get error as described

Something similar happen when you detach a script from the node and delete from the resource folder.
Minimal reproduction project:
Not needed.

This is caused by the fact that the .csproj file does not automatically detect changes to .cs files (whether it's them being moved, deleted or renamed) - see #12917 and #12415.
You can either manually edit the .csproj file, or use a dedicated IDE that can automatically update .csproj files when changes occur, to resolve this.

Closing this as duplicate.


Add wallet_watchAsset to supported RPC API

We should add support for wallet_watchAsset to the RPC methods which provides an interface that prompts users to add ERC-20 tokens and NFTs suggested by the network even when they have token autodetection or NFT autodetection disabled, and without having to interact with contract addresses.
https://eips.ethereum.org/EIPS/eip-747
https://docs.metamask.io/wallet/how-to/display/tokens/
Context
This would help with non-Flow wallets who can add FLOW and USDCf automatically as a result

This is not something to support on the RPC, it's wallet specific functionality which needs to be supported


MAINT: Encapsulate error message handling in NI_LineBuffer.

This encapsulates the raising of exceptions in calls to the NI_LineBuffer
"class" inside the "class" itself, simplifying its use throughtout the code
base.

LGTM, thanks @jaimefrio


NIFI-3300 Implemented usage of ZooKeeper chroot capability in the con…

…nect string
Updated ZooKeeper connect string parsing tests
Updated admin doc for ZooKeeper Migrator migration of nifi root nodes, updated source and destination ZK check by servers in the connection string instead of the entire connection string
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit?

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[x] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Reviewing

@jtstorck I'm hitting an issue restoring to a different path on the same server
Exception in thread "main" java.lang.IllegalArgumentException: Source ZooKeeper config ZooKeeperEndpointConfig{connectString=zk-kerberos:2181/, servers=[zk-kerberos:2181], path=/} for the data provided can not be the same as the configured destination ZooKeeper config ZooKeeperEndpointConfig{connectString=zk-kerberos:2181/abcd, servers=[zk-kerberos:2181], path=/abcd}
        at com.google.common.base.Preconditions.checkArgument(Preconditions.java:145)
        at org.apache.nifi.toolkit.zkmigrator.ZooKeeperMigrator.writeZooKeeper(ZooKeeperMigrator.java:137)
        at org.apache.nifi.toolkit.zkmigrator.ZooKeeperMigratorMain.main(ZooKeeperMigratorMain.java:160)

@brosander Good catch, this should be allowed.  I'll update the code and add a test for this use case.

+1 Merging


Get Profile Data API , Unauthorized Error

senario: first login by swagger interface then call profile API :

@ @ShahrzadAzari

I made some changes and resolve this issue.
You can now authorize your user after logging in and getting access token, like the image below:

@ali6600alamdari


Add reference to Input Mono, another powerline compatible font

Would you mind sending me a screenshot of the Input font with the theme, so i can approve the PR?

Here you go:

Thanks for the PR.

And BTW, you can align the triangles with the other segments by changing the vertical length of the characters.
Here is a screenshot of my setup.


The installer v4.0 could not work well on windows 7 with python 3.4.2 installed

Install mbed-cli with all default extras via installer v4.0, there is no shortcut created on desktop.
Could not find python in mbed-cli folder.

@0xc0170 I'm pretty sure that the current innstaller does not have this behavior. Closing; please reopen if I am mistaken.


Adding the capability to create and draw graphics primitives

This adds the capability to create and draw graphics primitives:

A new "HelloTriangle" sample was added
The GraphicsBuffer type supports writing data to the buffer

This causes a new resource allocation per buffer. Ideally we would have larger allocations and this would be a view into that
This only supports writing data today and always creates an "upload" buffer. Ideally we would create GPU only and CPU read, write, or read/write buffers as appropriate
Only vertex buffers are supported right now

The GraphicsPipeline type carries all the pipeline state (namely shaders) for rendering a primitive

Only Vertex and Pixel shaders are supported right now, but both are optional
You cannot currently customize the vertex input layout

The GraphicsPrimitive type was added and tracks the pipeline used to render it and the vertices it is made of

Ideally this would also support optional indexing

The GraphicsShader type was added and tracks the bytecode and entry point for a given shader

Only vertex and pixel shaders are supported right now

The above types are created via GraphicsDevice.Create*
Graphics primitives are are drawn via GraphicsContext.Draw

Forgot to post the sample screenshot


Error: Unable to resolve action Integral-Healthcare/robin-ai-reviewer@v[INSERT_LATEST_RELEASE]

I tried and got this error. Maybe you know what caused it?
Secret source: Actions
Prepare workflow directory
Prepare all required actions
Getting action download info
Error: Unable to resolve action `Integral-Healthcare/robin-ai-reviewer@v[INSERT_LATEST_RELEASE]`, unable to find version `v[INSERT_LATEST_RELEASE]`

Maybe I need to replace "INSERT_LATEST_RELEASE" with an accurate value.


Enable Markdown linter (remark-lint) for Stickler CI

Signed-off-by: Ben Alkov<EMAIL_ADDRESS>Maintainers will complete the following section:

[ ] Commit messages are descriptive enough
[ ] "Signed-off-by:" line is present in each commit
[ ] Code coverage from testing does not decrease and new code is covered
[ ] JSON/YAML configuration changes are updated in the relevant schema
[ ] Changes to metadata also update the documentation for the metadata
[ ] Pull request includes link to an osbs-docs PR for user documentation updates
[ ] New feature can be disabled from a configuration file

Can you push a broken markdown change to see if this is working?


adds nuage as restricted source in dataset-author component

Coverage remained the same at 0.0% when pulling 98e064faa384fde782cf02463938be2018858d27 on theseyi:restrict-nuage into 6be2e04786d99a10429371c523ad5f2d7852ff8d on linkedin:linkedin.

Coverage remained the same at 0.0% when pulling 65cb3c41afe4ca32c5d2eedb543af4947551bda7 on theseyi:restrict-nuage into 6be2e04786d99a10429371c523ad5f2d7852ff8d on linkedin:linkedin.


Fix problems with Bound

Group.toBound's return type was wrongly marked Group. Closes #214
Bound stores top left and bottom right Pts separately. Close #213

For 2, top left and bottom right Pts were separate from Pts that are indexable using integers.
This causes that, when a calculation method such as add inherited from Group is used on a Bound, the Bound's corner Ptss are sometimes not updated, as Group uses integer indices for getting the member Pts.
In order to fix this, the separate members _topLeft and _bottomRight are removed from Bound. topLeft and bottomRight are now just getters for integer-indexable Pts.

@ii41 - Thank you so much for catching this bug and providing such a great fix too. Really appreciate it!


[Task]: Multi Pane Layout: Phase 2

[ ] Resize property pane controls to take full width
[ ] Tabs pane can be minimised with no regard of min size
[ ] Improve Tabs pane resize perf
[ ] Limit Width of side tabs based on canvas scale limits

Can we add the hiding of the right pane in the feature flag? Either here or in phase 3


Aws2 tests with localstack don't need to use long timeouts

A lot of aws tests are taking a lot of time (because of timeouts required for use of real AWS )
It should be possible to differentiate (real vs local) in tests and skip long timeouts for localstack.
Too long timeouts could make problems on CI.

Fixed way back in 2.5.0 in https://github.com/apache/camel-quarkus/commit/0a6f53f242f776165da502cd588158d8c3e5c957.


bin: add openstack terraform migration script for 2.18 -> 2.19

What this PR does / why we need it: Added migration script for the terraform state for v2.18 -> v2.19 for openstack environments to prevent terraform from trying to recreate nodes.
Which issue this PR fixes (use the format fixes #<issue number>(, fixes #<issue_number>, ...) to automatically close the issue when PR gets merged): fixes #176
Public facing documentation PR (if applicable)

Special notes for reviewer:
The issue states that the script should make it so that terraform doesn't want to change anything, but I think because of how significantly the terraform module has changed this is not really viable. The script will make it so that terraform doesn't try to destroy anything important, but it will make some changes to the state.
I have tried this on safespring and citycloud. You can test the script yourself on any environment, since it only makes local changes.
Checklist:

[X] Proper commit message prefix on all commits
[ ] Updated the public facing documentation
Is this changeset backwards compatible for existing clusters? Applying:

[ ] is completely transparent, will not impact the workload in any way.
[ ] requires running a migration script.
[ ] requires draining and/or replacing nodes.
[ ] will break the cluster.
I.e. full cluster migration is required.

is destroying and re-creating module.compute.openstack_compute_floatingip_associate_v2.k8s_nodes and module.compute.openstack_compute_floatingip_associate_v2.k8s_master expected?

Yes, I tried to look into if this was preventable but kubespray has switched this resource from openstack_compute_floatingip_associate_v2 to openstack_networking_floatingip_associate_v2, so it seemed difficult (even if we did it in the script, we'd still have to remove the old ones and create the new ones). Since these resources are only used internally to associate floating IPs to nodes, I don't think it should cause issues.

there was a short network interruption after applying the changes, but other than that looks good. (cleura fra1)


Temporary workaround for qemu issues

Signed-off-by: Roman Shaposhnik<EMAIL_ADDRESS>

Hey @nordmark take a look


Create partyreadycheck

Display an alert and play a sound to check ready status of your party. Currently only works for ToB parties.

Do not set loadWhenOutdated and enabledByDefault

Done

My bad, that @Extension annotation was left over from OpenOSRS development. Thanks for your patience :)

My bad, that annotation was left over from development within another client. Thanks for your patience :)


Feature: token count / context management

It would be great to know if the message about to be sent is going to fix in the conversation context.
In this way, we can avoid having garbled / nonsense back from the model.

Hi @peperunas, unfortunately Ollama currently does not expose model context length in the API. I have submitted an issue to address this and planning to support it as soon as it's implemented. For now will close the issue.


Feature request: Support Shell script file type

Hi @leodevbro and others,
Thank your for the great works and ideas.
Looking forward blockman will support Bash/Zsh Shell scripts in the near future.
Thanks and regards,
Alan

Thanks. I'll try it in the near future. Also you can help me if you can find any good parser/tokenizer of Bash/Zsh Shell scripts.


fix: hotfixes for Stan v2.33

Added all the missing ones from #12
The only unnecessary are now 'array', 'multiplier', 'offset', 'upper', and 'lower'.

After this we are ready for a release @eigenfoo.
I can make a PR to nixpkgs.
I am also adding the CI tests to run on PRs.

There you go all green!

Perfect, thanks so much!

Thanks I think it makes sense to tag a release now.


drivers: sensor: initial driver of Invensense ICM42605 motion sensor

drivers: sensor: Initial driver of Invensense ICM42605
Initial driver and sample application of
TDK Invensense ICM42605 6-axis motion sensor.
This driver provide DTS for nRF52 DK board DTS setting.
Providing features are below.
Sensor data streaming - Accel, gyro
Tap, Double tap triggering.
Set/Get FSR, ODR by set attr API
Support multi instance feature.
samples: sensor: sample app of ICM42605 motion sensor
Sample appication of TDK Invensense ICM42605
motion sensor.
Signed-off-by: JuHyun Kim<EMAIL_ADDRESS>This is a resubmission of #28466

@MaureenHelm @galak @nashif Please review this pull request.

Please review the buildkite failure:
INFO    - /workdir/zephyr/sanity-out/nrf52dk_nrf52832/samples/sensor/icm42605/sample.sensor.icm42605/build.log
ERROR   - Including boilerplate (Zephyr base): /workdir/zephyr/cmake/app/boilerplate.cmake
-- Application: /workdir/zephyr/samples/sensor/icm42605
-- Zephyr version: 2.4.99 (/workdir/zephyr)
-- Found Python3: /usr/bin/python3.6 (found suitable exact version "3.6.9") found components:  Interpreter
-- Found west (found suitable version "0.8.0", minimum required is "0.7.1")
-- Board: nrf52dk_nrf52832
-- Cache files will be written to: /root/.cache/zephyr
-- Found toolchain: zephyr (/opt/sdk/zephyr-sdk-0.11.4)
-- Found dtc: /opt/sdk/zephyr-sdk-0.11.4/sysroots/x86_64-pokysdk-linux/usr/bin/dtc (found suitable version "1.5.0", minimum required is "1.4.6")
-- Found BOARD.dts: /workdir/zephyr/boards/arm/nrf52dk_nrf52832/nrf52dk_nrf52832.dts
-- Found devicetree overlay: /workdir/zephyr/samples/sensor/icm42605/boards/nrf52dk_nrf52832.overlay
Error: nrf52dk_nrf52832.dts.pre.tmp:498.21-22 syntax error
FATAL ERROR: Unable to parse input tree
CMake Error at /workdir/zephyr/cmake/dts.cmake:206 (message):
  command failed with return code: 1
Call Stack (most recent call first):
  /workdir/zephyr/cmake/app/boilerplate.cmake:589 (include)
  /workdir/zephyr/share/zephyr-package/cmake/ZephyrConfig.cmake:24 (include)
  /workdir/zephyr/share/zephyr-package/cmake/ZephyrConfig.cmake:35 (include_boilerplate)
  CMakeLists.txt:8 (find_package)

-- Configuring incomplete, errors occurred!

Please review the buildkite failure:
INFO    - /workdir/zephyr/sanity-out/nrf52dk_nrf52832/samples/sensor/icm42605/sample.sensor.icm42605/build.log
ERROR   - Including boilerplate (Zephyr base): /workdir/zephyr/cmake/app/boilerplate.cmake
-- Application: /workdir/zephyr/samples/sensor/icm42605
-- Zephyr version: 2.4.99 (/workdir/zephyr)
-- Found Python3: /usr/bin/python3.6 (found suitable exact version "3.6.9") found components:  Interpreter
-- Found west (found suitable version "0.8.0", minimum required is "0.7.1")
-- Board: nrf52dk_nrf52832
-- Cache files will be written to: /root/.cache/zephyr
-- Found toolchain: zephyr (/opt/sdk/zephyr-sdk-0.11.4)
-- Found dtc: /opt/sdk/zephyr-sdk-0.11.4/sysroots/x86_64-pokysdk-linux/usr/bin/dtc (found suitable version "1.5.0", minimum required is "1.4.6")
-- Found BOARD.dts: /workdir/zephyr/boards/arm/nrf52dk_nrf52832/nrf52dk_nrf52832.dts
-- Found devicetree overlay: /workdir/zephyr/samples/sensor/icm42605/boards/nrf52dk_nrf52832.overlay
Error: nrf52dk_nrf52832.dts.pre.tmp:498.21-22 syntax error
FATAL ERROR: Unable to parse input tree
CMake Error at /workdir/zephyr/cmake/dts.cmake:206 (message):
  command failed with return code: 1
Call Stack (most recent call first):
  /workdir/zephyr/cmake/app/boilerplate.cmake:589 (include)
  /workdir/zephyr/share/zephyr-package/cmake/ZephyrConfig.cmake:24 (include)
  /workdir/zephyr/share/zephyr-package/cmake/ZephyrConfig.cmake:35 (include_boilerplate)
  CMakeLists.txt:8 (find_package)

-- Configuring incomplete, errors occurred!

@MaureenHelm Removed typo in overlay file and build test is passed

@MaureenHelm @galak Please review this PR.

@MaureenHelm can you take another look.

@MaureenHelm Changed yaml commit to sensor driver commit

@MaureenHelm Need your comment for CS.

@MaureenHelm Happy new year! And please give me any feedback or comments.

@MaureenHelm Happy new year! And please give me any feedback or comments.

@MaureenHelm Modified call tap_fetch directly and it works well, Thank you.

@MaureenHelm Modified call tap_fetch directly and it works well, Thank you.

@MaureenHelm Please give any comments.

@MaureenHelm Please give any comments.

@MaureenHelm Thank you and I will consider CS issue after merge.

@MaureenHelm Thank you and I will consider CS issue after merge.

@galak Please review or approve this PR.

@galak Please review or approve this PR.

This is a big PR that's been open for a long time and gone through many rounds of review, so I'm ok with it going in now as-is. But please consider submitting a follow up PR to address the chip select issue.

Should we open an enhancement or bug for this?

This is a big PR that's been open for a long time and gone through many rounds of review, so I'm ok with it going in now as-is. But please consider submitting a follow up PR to address the chip select issue.

Should we open an enhancement or bug for this?

#31460

#31460


runtime: mexit leads to SIGSEGV due to g.m becoming nil

Issue is reproducible on openbsd/amd64 with both go1.17.7 and -tip.
While debugging test failures (for another software package - delve), the go test run will regularly hit a SIGSEGV like the following:
Thread 5 received signal SIGSEGV, Segmentation fault.
[Switching to thread 129486]
0x00000000007a6f2e in runtime.lock2 (l=0xec5e98 <runtime.sched+24>) at /usr/local/go/src/runtime/lock_sema.go:42
42              if gp.m.locks < 0 {
(gdb) bt
#0  0x00000000007a6f2e in runtime.lock2 (l=0xec5e98 <runtime.sched+24>) at /usr/local/go/src/runtime/lock_sema.go:42
#1  0x00000000007dac0d in runtime.lockWithRank (l=<optimized out>, rank=<optimized out>) at /usr/local/go/src/runtime/lockrank_off.go:23
#2  runtime.lock (l=<optimized out>) at /usr/local/go/src/runtime/lock_sema.go:37
#3  runtime.mexit (osStack=true) at /usr/local/go/src/runtime/proc.go:1532
#4  0x00000000007da86f in runtime.mstart0 () at /usr/local/go/src/runtime/proc.go:1372
#5  0x000000000080b425 in runtime.mstart () at /usr/local/go/src/runtime/asm_amd64.s:248
#6  0x0000000000e420f4 in crosscall_amd64 () at gcc_amd64.S:40
#7  0x000000000080b420 in ?? ()
#8  0x000000c0000011e0 in ?? ()
#9  0x00007f7ffffc7b68 in ?? ()
#10 0x0000000000e41ff0 in ?? () at gcc_openbsd_amd64.c:51
#11 0x0000000297c8ee70 in ?? ()
#12 0x000000027d9ca8a8 in ?? ()
#13 0x0000000000e42024 in threadentry (v=<optimized out>) at gcc_openbsd_amd64.c:63

This is occurring due to gp.m becoming nil during the following in mexit (it is non-nil before this line and is nil immediately afterwards):
        // Release the P.
        handoffp(releasep())

The next piece of code is:
        lock(&sched.lock)

And this leads to a gp.m.locks dereference and hence a SIGSEGV.
This seems to be triggered by the fact that these tests run code that calls runtime.LockOSThread - adding a matching runtime.UnlockOSThread call makes the issue disappear, as does removing the runtime.LockOSThread call. Additionally, the openbsd/amd64 port uses system threads, which may play a part.
So far I've been unsuccessful in reducing the test suite to provide a minimal reproducer. However, it is easy to trigger and I can provide further information as needed.

This is also reproducible on FreeBSD 13 with Go 1.18:
[Switching to LWP 106157 of process 3253]
runtime.lock2 (l=0xe29178 <runtime.sched+24>) at /usr/local/go/src/runtime/lock_futex.go:53
53		if gp.m.locks < 0 {
(gdb) bt
#0  runtime.lock2 (l=0xe29178 <runtime.sched+24>) at /usr/local/go/src/runtime/lock_futex.go:53
#1  0x00000000007e7be5 in runtime.lockWithRank (l=<optimized out>, rank=<optimized out>) at /usr/local/go/src/runtime/lockrank_off.go:22
#2  runtime.lock (l=<optimized out>) at /usr/local/go/src/runtime/lock_futex.go:47
#3  runtime.mexit (osStack=true) at /usr/local/go/src/runtime/proc.go:1535
#4  0x00000000007e78a9 in runtime.mstart0 () at /usr/local/go/src/runtime/proc.go:1385
#5  0x0000000000812b85 in runtime.mstart () at /usr/local/go/src/runtime/asm_amd64.s:367
#6  0x0000000000dbe1e0 in crosscall_amd64 () at gcc_amd64.S:40
#7  0x0000000801612500 in ?? ()
#8  0x000000c000131d40 in ?? ()
#9  0x0000000000000001 in ?? ()
#10 0x0000000000000001 in ?? ()
#11 0x00007fffdf7f9fc0 in ?? ()
#12 0x0000000000812b80 in ?? ()
#13 0x0000000000dbdd95 in threadentry (v=<optimized out>) at gcc_freebsd_amd64.c:72
Backtrace stopped: previous frame inner to this frame (corrupt stack?)

Of interest, this is also a system/pthread created thread (entry is via threadentry in gcc_freebsd_amd64.c). In this case the gp.m is not nil, but a minimal value:
(gdb) print gp.m
$1 = (runtime.m *) 0x137

The reproducer is:
$ git clone https://github.com/go-delve/delve
$ cd delve/pkg/terminal
$ go test

Thanks for the report. Could you please attach a more complete "go env" with hardware, OS version ,etc? Thanks.  It would also help to understand which testpoint is the one that triggers the error.

Thanks for the report. Could you please attach a more complete "go env" with hardware, OS version ,etc?

On openbsd/amd64:
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/joel/.cache/go-build"
GOENV="/home/joel/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="openbsd"
GOINSECURE=""
GOMODCACHE="/home/joel/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="openbsd"
GOPATH="/home/joel/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/openbsd_amd64"
GOVCS=""
GOVERSION="go1.17.7"
GCCGO="gccgo"
AR="ar"
CC="cc"
CXX="c++"
CGO_ENABLED="1"
GOMOD="/home/joel/src/delve/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build3281329351=/tmp/go-build -gno-record-gcc-switches"

On freebsd/amd64:
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/joel/.cache/go-build"
GOENV="/home/joel/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="freebsd"
GOINSECURE=""
GOMODCACHE="/home/joel/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="freebsd"
GOPATH="/home/joel/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/freebsd_amd64"
GOVCS=""
GOVERSION="go1.18"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="cc"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/usr/home/joel/src/delve/go.mod"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build1993072459=/tmp/go-build -gno-record-gcc-switches"

Another data point is that both of these are virtual machines that have a single vCPU.

It would also help to understand which testpoint is the one that triggers the error.

As far as I can determine, there is no single test case that triggers it - I suspect it relates to the cycling of goroutines and threads that have called runtime.LockOSThread.


Support for sub devices?

Hi,
does this library support sub devices as well? E.g. ZigBee TRV via Tuya Gateway?

Yes


[5.4] Facades as a separate package

No need to move them. That's a massive break for no reason. We can just create a subpackage if we really wanted.

What Graham said.


Revert "Pin flake8==2.6.2 in tox"

Reverts #411
Flake8 3.0 and teamcity-messages are now compatible. See: https://github.com/JetBrains/teamcity-messages/releases/tag/v1.20
This reverts commit 0a39e4b4098ebf4928ee200388243277ce21c78d.

https://teamcity.mesosphere.io/viewLog.html?buildId=356551&buildTypeId=DcosIo_Dcos_CodeQuality&tab=buildLog#_state=57&focus=551 -- seems to be working.

:ship:


Update task.cls

Hi @evshvarov ,
I noticed an error in the listbuild with the days of week.
Could you please merge this pull request ?
Thank you.
Lorenzo.

Sure! could you please also bump the module version?

ooops yes


feat(dom): autoUpdate

Solves No. 3 in #1538
Firstly, getScrollParents has been renamed to getOverflowAncestors as I think it is more accurate.
Secondly, this export has 4 options and it looks like this:
import {autoUpdate} from '@floating-ui/dom';

async function update() {
  // computePosition call in here
}

const cleanup = autoUpdate(reference, floating, update, {
  // default options
  ancestorScroll: true,
  ancestorResize: true,
  elementResize: true,
  animationFrame: false,
});

ancestorScroll
Update whenever a scrollable ancestor is scrolled
ancestorResize
Update whenever a scrollable ancestor is resized (as this is only the native resize event, only works on window and VisualViewport)
elementResize
Update whenever the reference or floating elements change in size using a ResizeObserver
animationFrame
Watch every animation frame for reference rect changes and only update when it changes location on the screen (e.g. for animations or general layout changes). This disables all the above listeners since they become unnecessary. I think there may be situations where the floating element needs to be updated even if its clientRect values didn't change, but sure of which.

@atomiks can you clarify what ancestorScroll does more exactly?
I'd expect it to update the position of the element if the ancestor of the referenceEl scrolls but I guess I'm misunderstanding the intention because nothing happens when I scroll an ancestor, even if it's the direct ancestor of the referenceEl.


Discord Server.

A Discord server would be good to inform about updates and general chatting and recommendations.

Fenix2GSX has already a dedicated Channel on the unofficial GSX Discord which I check very regularly. That is enough. I certainly do not want any more Discord than that.


[Function Expose] Codeunit 5940 CreateServHeader & CreateAllServLines

We would like to able to call this two methods in codeunit 5940

CreateServHeader
CreateAllServLines

We wil use this two methods to create service invoices
Thanks

Hi, we've gone ahead with your request. We usually include these types of changes in the next minor release, so look for it there.


Evdi on debian jessie

Hi guys,
i have a aoc usb display with Bus 002 Device 004: ID 17e9:ff0d DisplayLink
I use the ubuntu driver from displaylink.com and not working
This is result of the kernel message
[drm] evdi: evdi_stats_init
Mar[drm] Initialized evdi 1.0.68 19700101 on minor 0
Mar[W] evdi_painter_disconnect (dev=0) An unknown connection to ffff8800a1e6a600 tries to close us - ignoring
Mar[W] evdi_painter_disconnect (dev=0) An unknown connection to ffff8800a1e6a600 tries to close us - ignoring
Mar[D] evdi_detect Painter is disconnected
Mar[D] evdi_detect Painter is disconnected
Mar[D] evdi_detect Painter is disconnected
Mar[D] evdi_detect Painter is disconnected
Mar[D] evdi_painter_crtc_state_notify (dev=0) Notifying crtc state: 0
Mar[D] evdi_painter_crtc_state_notify (dev=0) Notifying crtc state: 0
Mar[W] evdi_painter_disconnect (dev=0) An unknown connection to ffff8800b5e3a000 tries to close us - ignoring
Mar[D] evdi_painter_connect (dev=0) Connected with ffff8800b5e3a000
Mar[D] evdi_painter_connect (dev=0) Edid (3 bytes): 94 c4 00
Mar[D] evdi_detect (dev=0) Painter is connected
Mar[D] evdi_detect (dev=0) Painter is connected
Mar[D] evdi_painter_get_edid (dev=0) 94 c4 00
MarRaw EDID:
Mar  	94 c4 00 ef dd 7f 00 00 94 c4 00 ef 00 00 00 00
Mar   	00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
Mar  	00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
Mar  	00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
Mar  	00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
Mar  	00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
Mar  	00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
Mar  	00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
evdevdi.0: DVI-I-1: EDID invalid.
Can you help me?
Best regards Alberto

The EDID looks indeed invalid. What cable are you using for the monitor? Can you try with other (shorter/better quality) cable?

No feedback so far, closing this - please use DisplayLink forum for further help.


Insert head content into html_to_vdom

There's currently some awkwardness in converting django views to VDOM, due to the fact that the head content is never loaded into the page.
For example, CSS/JS that is within <head> is simply never added to the page.
This PR makes html_to_vdom use the same approach browsers use when merging two HTML/body node trees. Namely, the contents of the <head> and <body> tags are directly spit out onto the page, while removing those top level tags themselves.
Checklist
Please update this checklist as you complete each item:

[X] Tests have been included for all bug fixes or added functionality.
[x] The changelog.rst has been updated with any significant changes.
[X] GitHub Issues which may be closed by this Pull Request have been linked.

Could this be implemented as a transform instead?

I don't think we should bake this into html_to_vdom. It's not clear to me that this approach to dealing with html/head/body is universally applicable. For example, in the future, we could allow users to declare head elements in IDOM by leveraging a tool like react-helmet. In which case, we'd actually want to preserve the head/body distinction. Thus I think this should be implemented as a transform. One that could be included in IDOM core given its broad, but not necessarily universal, appeal.

Given that helmet exists, I'm okay with that. On a different note, is there truly a purpose for us to keep the idom.html.html and idom.html.body representations?

We could, though there's not much cost to having them there either. If you feel strongly about it, I'd be ok removing them.

It has been converted to a transform.

Let me know if deleting body is something you want to commit to. I personally think removing it helps set expectations, since currently I don't see any way to use it.

I didn't have it set to VdomDict because mypy didn't like that for some reason. Was easier to set as a generic dict than figure it out at the time.

I reverted the VdomDict type hint change since I wasn't entirely sure what was wrong.

Could this transform be more simply written as?
def del_html_body_transform(vdom: VdomDict) -> VdomDict:
    """Removes ``<html>``, ``<head>``, and ``<body>`` elements.

    This is accomplished by turning any matching elements into fragments.
    See :func:`idom.html._` for more details on element fragments.

    .. note::

        Intended for use with :func:`html_to_vdom`.

    Parameters:
        vdom:
            The VDOM dictionary to transform.
    """
    return {**vdom, "tagName": ""} if vdom["tagName"] in ("html", "body", "head") else vdom

Yeah.
Results in an uglier final VDOM with a bunch of fragments, but functionally would work the same when rendered.


Add ParentId in OCS and webdav REPORT responses

Web offers a navigation into parent folders in various pages / situations:

for file listings on search result page or in the search preview items (each file can and likely has a different parent)
share listings on shared with others / shared via link pages (each shared file could have a different parent)
in personal/project spaces when looking at the Shares section in the right sidebar of a subfolder or file of a shared parent folder
(in the future: favorites listing)

In order to solve https://github.com/owncloud/web/issues/6247 we need to be able to include the file id of the respective parent into the navigation.
As a result, the GA blocking requirement is: Web needs the parent id of files/folders listed in OCS share and webdav REPORT responses.
Edit: The property already exists in the OCS APi and is called file_parent, hence a fitting name for WebDAV would be oc:file-parent.

And another use case: after deleting the current folder the web ui navigates up to the parent folder. That led me to the thought: Would be really helpful if we'd have the parentId in all propfinds as well. Saves us from doing a propfind on the parent path just for navigating there... from what you showed me last week this should be easy to achieve, right?

REPORT requests are still pending.

All done so far.
The search index stores the parentID from now on. Existing items from the index will not have a file-parent but will get one when they are re-indexed.
./ocis/bin/ocis search index --space <space> --user <user can be used to recreate the index

recreating the index only works when a non memory registry is used. Otherwise ocis search index ----space 1284d238-aa92-42ce-bdc4-0b0000009157$some-admin-user-id-0000-000000000000 --user admin cannot look up the search service and will error.
Try setting MICRO_REGISTRY=mdns to use the mdns registry. But this needs to happen for both: running ocis server and ocis search index ....
@rhafer @micbar in effect using our default in memory registry makes it impossible to use cli commands if they need to look up services ...

TODO QA team:

[ ] add API tests to cover this case


Add an availability to specify a scheduler

Define scheduler property to specify which scheduler is used for reducing and observing the state stream. Note that this queue must be a serial queue. The default scheduler is CurrentThreadScheduler.
final class MyReactor: Reactor {
  let scheduler: Scheduler = SerialDispatchQueueScheduler(qos: .default)

  func reduce(state: State, mutation: Mutation) -> State {
    // executed in a background thread
    heavyAndImportantCalculation()
    return state
  }
}

@devxoul
You save my life! working perfectly.


Add support for Python 3.10

Python 3.10 was released last week:

https://discuss.python.org/t/python-3-10-0-is-now-available/10955

We can also remove some redundant Python 2.6 code.

Yep, I have been thinking about EOL for 2 as well. Last time I had pulled numbers was in February, which had closer to 5% usage: https://github.com/prometheus/client_python/issues/535#issuecomment-784386056. Usage dropping below 2% certainly makes deprecation seem reasonable (as well as more and more projects and AWS discontinuing support).


Update Manipulations.php to let manipulations arrays also

WIth this fix you can send a normal manipulation:
$media->manipulations = [
    'resized' =>['width' => 123, 'height' => 123],
];

And also this kind of manipulations:
$resizedConversion = Manipulations::create()
    ->width(123)
    ->apply()
    ->manualCrop(20, 20, 10, 10);

$media->manipulations = [
    'resized' => $resizedConversion->toArray()
];

Updated. How you like it now! 👍

Do it!

Is everything ok now yes?

Haven't come around to this one yet. Holiday 🌴

Enjoy 😄

Thank you!

Thanks for the merge 😄