Unverified bug report on huntr.dev- heap-buffer-overflow in function utfc_ptr2len and function utf_head_off

Hi sir, I have made a bug report on huntr.dev. The report is unverified for past 1 week. May I know if my bug report is valid or require me to edit further?
link to the bug report: https://huntr.dev/bounties/db7be8d6-6cb7-4ae5-9c4e-805423afa378/
Thank you!

Hi sir, I have made a bug report on huntr.dev. The report is
unverified for past 1 week. May I know if my bug report is valid or
require me to edit further?
link to the bug report: https://huntr.dev/bounties/db7be8d6-6cb7-4ae5-9c4e-805423afa378/

I'm running a bit behind dealing with issues.  It's on the todo list,
I should get to it in a few days.
--
hundred-and-one symptoms of being an internet addict:
66. You create a homepage with the impression to cure the afflicted...but
your hidden agenda is to receive more e-mail.
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Thank you very much Sir. Much appreciated! :)

Let's not have one issue on huntr also have an issue on github, that creates a confusing exception.
I'll close this one.

Hi Sir, is there any update on this? thank you!!


New tool: gftools-check-family-name.py based on namecheck.fontdata.com query for unique family name

Originally requested at https://github.com/googlefonts/fontbakery/issues/494
example
http://namecheck.fontdata.com/?q=lobster tells us that the "Lobster" name is already in use.

We now do this in fontbakaery, not here.


Creating channel blocks main thread

Hello again @danielrhodes
I found out that creating a Channel sometime blocks the main thread.
My code:
webSocketsRoomChannel = SocketRouter.shared.client.create(WebSocketEventsChannel.channel, identifier: channelIdPayload, autoSubscribe: true, bufferActions: true)

The stack:

I will come up with a fix if I find one
Update:

Is this an infinite cycle?

Have you retained the channel anywhere?

it's a simple variable on the conversations view controller

What version are you using? Something similar to the above used to happen, especially if the the channel had not been retained anywhere. But that should be fixed now.

- ActionCableClient (0.2.2):
    - Starscream (~> 2.0.1)

Do you have some sample code for how you are setting up everything and in the view controller. Would be happy to take that and test it on my end.

class ConversationViewController: UIViewController {
    var webSocketsRoomChannel: Channel?
    func subscribeToWebsocketChannel() {
        guard SocketRouter.shared.isConnected, let channel = viewModel.channel, let identifier = channel.identifier else {
            print("socket is not connected or data is not sufficient")
            return
        }
        let channelIdPayload = ["channel_id" : identifier]
        self.webSocketsRoomChannel = SocketRouter.shared.client.create(WebSocketEventsChannel.channel, identifier: channelIdPayload, autoSubscribe: true, bufferActions: true)

        // Receive a message from the server. Typically a Dictionary.
        webSocketsRoomChannel?.onReceive = { (JSONResponse : Any?, error : Error?) in
            print("Received", JSONResponse ?? "N/A", error ?? "no error")

        }

        // A channel has successfully been subscribed to.
        webSocketsRoomChannel?.onSubscribed = {
            print("Yay! You're subscribed!")
        }

        // A channel was unsubscribed, either manually or from a client disconnect.
        webSocketsRoomChannel?.onUnsubscribed = {
            print("Unsubscribed")
        }

        // The attempt at subscribing to a channel was rejected by the server.
        webSocketsRoomChannel?.onRejected = {
            print("Rejected")
        }
    }

    func removeWebSocketsNotifications() {
        // Remove channel subscription
        webSocketsRoomChannel?.unsubscribe()
        // Stop listening notification
        NotificationCenter.default.removeObserver(self)
    }

    func addWebSocketsNotifications() {
        NotificationCenter.default.addObserver(self, selector: #selector(webSocketConnected(_:)), name: NSNotification.Name(rawValue: WebsocketDidConnectNotification), object: nil)

        NotificationCenter.default.addObserver(self, selector: #selector(webSocketDisconnected(_:)), name: NSNotification.Name(rawValue: WebsocketDidDisconnectNotification), object: nil)
    }

    func webSocketConnected(_ notification: NSNotification) {
        print("\(self.className): web socket connected")
        if let roomChannel = webSocketsRoomChannel, roomChannel.isSubscribed == false {
            subscribeToWebsocketChannel()
        }
    }

    func webSocketDisconnected(_ notification: NSNotification) {
        print("\(self.className): web socket disconnected")
    }
}

So from the looks of Instruments above, it seems like either you were running the application for a very long time or you might be calling subscribeToWebsocketChannel very very often. The code you highlighted is simply doing a Dictionary lookup, which isn't blocking, and is O(1), so I'm not sure how that would be causing a problem.
I did, however, find that there was some JSON encoding being done from the calling thread (which I assume is main in this case), and so for whatever reason, this might be the source of the slowness.
Try out the json_encoding_on_calling_thread_fix branch and tell me if that worked for you.
In your Podfile, you can do the following:
pod 'ActionCableClient', :git => 'https://github.com/danielrhodes/Swift-ActionCableClient.git', :branch => 'json_encoding_on_calling_thread_fix'

Note that I had to change the API slightly, but now there is a callback on the channel.action(:) method telling you if the action was successfully sent or an error occurred. There is an example on the main README and in the header docs.

I have it again:

I will try with the json_encoding_on_calling_thread_fix branch as well and let you know how it goes.
Thanks a lot for the support.
PS: subscribeToWebsocketChannel is done only once

@danielrhodes the new method of sending an action doesn't call the callback when an error occurs

Do you mean on the server side or client side? If the error is on the server side, there is no way for the client to know an error occurred.

on client side

What was the specific error you were looking for?

creating a channel blocks the main thread

How many times are you calling this over the course of runtime? And how many total channels do you have? I ran the example app and put client.create in a 5000 iteration loop (on the main thread) and profiled it to see if anything weird came up.

Nothing there indicates anything amiss given how many times it was called. In fact, most of that would only occur once because it checks to see if there's already a channel. So that reduces the performance bottleneck to doing a lookup in a dictionary.
Perhaps a Dictionary lookup could cause a performance problem if there were an unusually large number of objects or were called in a very tight loop. Swift does not necessarily have the most optimized version of this, but it's certainly not a blocking operation.

I'm only doing it once

So you only go into that ViewController once the entire time the app is running? And it completely blocks the main thread?
From looking at your code above, can you try calling subscribeToWebsocketChannel() in viewDidLoad and removing those NSNotification observers in addWebSocketsNotifications. You can subscribe to a channel before the client connects and it will automatically subscribe once a connection occurs.

I will definitely try that.
I have a list of channels, which I can select. And sometimes, very randomly - it completely freezes like that.
Thank you for your support. I will try and let you know how it goes

@danielrhodes there's a retain cycle in the create function:


[docs] use emulator instead of simulator when referring to avd

Deploy preview for react-native ready!
Built with commit 068a0524abf2ffc7b7c9e8369a550e51f39622a6
https://deploy-preview-2264--react-native.netlify.app

my pleasure


Is it possible to use Angular 2

Hi,
Is it possible to use this carousel in Angular2 app? If yes - have you some example of it?

is there any Angular2 version available yet ? or can we use slick directive in angular2 ?
please help ...

+1

+1

+1


more tests and refactoring

Main thing this does is refactor the redis wrapper.
The biggest issue here is that for some reason I told Manuel to include the ld object in redis, but this is flawed because in a disaster scenario LD would be down and the client would not be able to be instantiated.
This also starts to add some more tests to other parts of the application.

Codecov Report

Merging #7 into master will increase coverage by 59.06%.
The diff coverage is 70.58%.

@@             Coverage Diff             @@
##           master       #7       +/-   ##
===========================================
+ Coverage    3.78%   62.85%   +59.06%
===========================================
  Files           6        6
  Lines         132      140        +8
===========================================
+ Hits            5       88       +83
+ Misses        127       52       -75

Impacted Files
Coverage Δ

relay_commander/ld.py
64% <ø> (+64%)
:arrow_up:

relay_commander/redis.py
75% <100%> (+75%)
:arrow_up:

relay_commander/rc.py
60.97% <25%> (+60.97%)
:arrow_up:

relay_commander/replayBuilder.py
70.83% <33.33%> (+70.83%)
:arrow_up:

relay_commander/generators.py
33.33% <0%> (+33.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20fbb4e...fbcdc1e. Read the comment docs.


feat: disable chart's context menu

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

cc @starsz PTAL the auto preview CI

cc @starsz PTAL the auto preview CI

The reason is that [SkyeYoung](https://github.com/SkyeYoung) is not a member of api7? So he can't get the env in Auto Preview CI.

will fix on #194


"Unrecognised migration name format" error when trying to use SQL migrations

Which version and edition of Flyway are you using?
Flyway 9.10.2
If this is not the latest version, can you reproduce the issue with the latest one as well? (Many bugs are fixed in newer releases and upgrading will often resolve the issue)
I am using the latest version of Flyway (9.10.2).
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)
Java API with a Spigot plugin for minecraft
Which database are you using? (Type & version)
MariaDB 10.6.11
Which operating system are you using?
Windows 10 64-Bit
What did you do? (Please include the content causing the issue, any relevant configuration settings, the SQL statement(s) that failed (if any), and the command you ran)
I tried migrating a database using an sql migration.
Flyway configuration:
flyway = Flyway.configure(plugin.getClass().getClassLoader())
                .dataSource(DataSource.ds)
                .validateMigrationNaming(true)
                .locations("classpath:db/migration")
                .sqlMigrationPrefix("V")
                .sqlMigrationSeparator("__")
                .load();

The migration was in src/main/resources/db/migration/V1__Initial_setup.sql. As far as I can tell this is following the standard naming and location conventions for Flyway which the configurations above don't change.
What did you expect to see?
[INFO]: Current version of schema "db": << Empty Schema >>
[INFO]: Migrating schema "db" to version 1 - Initial setup
[INFO]: Successfully applied 1 migration to schema "db"
What did you see instead?
org.flywaydb.core.api.FlywayException: Invalid SQL filenames found:
Unrecognised migration name format: V1__Initial_setup.sql
        at org.flywaydb.core.internal.resource.ResourceNameValidator.validateSQLMigrationNaming(ResourceNameValidator.java:59) ~[InventoryGuiThing-1.0-SNAPSHOT-all.jar:?]
        at org.flywaydb.core.FlywayExecutor.execute(FlywayExecutor.java:144) ~[InventoryGuiThing-1.0-SNAPSHOT-all.jar:?]
        at org.flywaydb.core.Flyway.migrate(Flyway.java:128) ~[InventoryGuiThing-1.0-SNAPSHOT-all.jar:?]
        at com.gmail.alxdoesstuff.InventoryGuiThing.onEnable(InventoryGuiThing.java:49) ~[InventoryGuiThing-1.0-SNAPSHOT-all.jar:?]
        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:264) ~[paper-api-1.19.3-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:371) ~[paper-api-1.19.3-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:544) ~[paper-api-1.19.3-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.craftbukkit.v1_19_R2.CraftServer.enablePlugin(CraftServer.java:578) ~[paper-1.19.3.jar:git-Paper-350]
        at org.bukkit.craftbukkit.v1_19_R2.CraftServer.enablePlugins(CraftServer.java:492) ~[paper-1.19.3.jar:git-Paper-350]
        at net.minecraft.server.MinecraftServer.loadWorld0(MinecraftServer.java:635) ~[paper-1.19.3.jar:git-Paper-350]
        at net.minecraft.server.MinecraftServer.loadLevel(MinecraftServer.java:434) ~[paper-1.19.3.jar:git-Paper-350]
        at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:301) ~[paper-1.19.3.jar:git-Paper-350]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1101) ~[paper-1.19.3.jar:git-Paper-350]
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:316) ~[paper-1.19.3.jar:git-Paper-350]
        at java.lang.Thread.run(Thread.java:833) ~[?:?]

Internally, Flyway makes use of the ServiceLoader and I suspect changing the ClassLoader is causing the service that implements our migration name validation to not be detected
Could you try removing plugin.getClass().getClassLoader() and see if it works? If it does, you would need to modify or use a different ClassLoader

I removed plugin.getClass().getClassLoader()
Instead of the exception it cant find the migrations at all anymore:
[15:29:22 WARN]: [org.flywaydb.core.internal.command.DbValidate] No migrations found. Are your locations set up correctly?
[15:29:22 INFO]: [org.flywaydb.core.internal.command.DbMigrate] Current version of schema `db`: << Empty Schema >>
[15:29:22 INFO]: [org.flywaydb.core.internal.command.DbMigrate] Schema `db` is up to date. No migration necessary.```

What's likely happening here is that the migrations are only found by the ClassLoader you get from plugin.getClass().getClassLoader()
It might be worth looking at custom ClassLoaders so that you can combine the default with the one from your plugin, or using a ClassLoader that can access the classes in your project and plugin, though this depends on how your project is set up. At this point however this is a problem outside of Flyway so closing for now


test(ui): add owasp zap scanner in ci/cd

Signed-off-by: Ramkumar Chinchani<EMAIL_ADDRESS>
What type of PR is this?

Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Superseded by https://github.com/project-zot/zot/pull/1224


Can fade animation be closed?

I just want the image of placeholder

@DanteAndroid  Did you solve the problem?  I use this in adapter。when Data loading complete，how to close FiftyShadesOf ？

@florent37 , can you please help us out ??? how to close this animation ??

stop方法


feat(release): Update SDK to use API released on 2023-11-07 travis

:tada: This PR is included in version 0.20.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Multi-line Mode

Is there a way to enter multi-line mode that doesn't involve pasting in a multi-line snippet of code? Or a way to enter a newline without evaluating the content (e.g. Cmd-Enter or Alt-Enter). Sometimes it would be nice to define a method over multiple lines, for example.

Poking through the code, I see that Shift-Enter does what I want. Somehow I missed that combination when trying the first time.


Autosave after delay makes cursor jump to beginning of line

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.57.1
OS Version: macOS Big Sur 11.4

Steps to Reproduce:

Disable all extensions
Set Auto Save on with default option (afterDelay)

without disabled extension it works.


Blaze can trigger crashes in the LLVM

import numpy as np

from odo import discover
from dask.array import from_array
from dask.array.blaze import compute, symbol

nx = np.arange(600).reshape((20, 30))
dx = from_array(nx, blockshape=(4, 5))
sx = symbol('x', discover(dx))

expr = sx.mean(axis=0)

dask_ns = {sx: dx}

result = compute(expr, dask_ns)
result2 = np.array(result)
print(result2)

We get the output
python crash_llvm.py
python: LeaksContext.h:54: void llvm::LeakDetectorImpl<T>::addGarbage(const T*) [with T = llvm::Value]: Assertion `Ts.count(o) == 0 && "Object already in set!"' failed.
[1]    18320 abort      python test.py

This works fine if we operate without threads (e.g. using result.compute(get=dask.async.get_sync)) which supports the theory that this is due to simultaneous compilation.  @seibert @sklam we provide the signature to the function; is there a way to trigger the compilation before we have data for it?

Given the number of PRs that are blocking on this it might also make sense to remove this functionality from dask temporarily.

we provide the signature to the function; is there a way to trigger the compilation before we have data for it?

You can do it with compile_isolated - assuming func is an undecorated Python function:
from numba.compiler import compile_isolated

compiled_func = compile_isolated(func, sig).entry_point

Then call compiled_func where you would have called func.
The Numba dispatcher attempts to ensure that the compiler is not re-entered by another thread during compilation - if this is happening, then it could be a bug in Numba.

Whoops, I forgot that you are using vectorize - the way to compile a ufunc is to use a UFuncBuilder, e.g.:
from numba.npyufunc.ufuncbuilder import UFuncBuilder

def myadd(a, b):
    return a + b

ufb = UFuncBuilder(myadd)

# cres will contain the CompileResult, if you want it
cres = ufb.add("int32(int32, int32)")
cres = ufb.add("int64(int64, int64)")

# ufunc is the compiled ufunc
ufunc = ufb.build_ufunc()


fix: deep match with higher level siblings

The level parameter was being incremented at each loop iteration instead of only inside of a new walk call. So for example
├── a          <- level 0
├── b          <- level 1 (should be 0)
│   ├── c      <- level 2 (should be 1)

Thank you so much @RedHatter – I'll merge this over the weekend

This PR is causing two tests to fail:
  glob: glob
    ✖ should be equivalent
    -----------------------
      operator: deepEqual
      expected: |-
        [ 'test/fixtures/a.js', 'test/fixtures/a.mp3', 'test/fixtures/a.txt', 'test/fixtures/b.js', 'test/fixtures/b.txt', 'test/fixtures/ond', 'test/fixtures/one', 'test/fixtures/two' ]
      actual: |-
        [ 'test/fixtures/a.js', 'test/fixtures/a.mp3', 'test/fixtures/a.txt', 'test/fixtures/b.js', 'test/fixtures/b.txt', 'test/fixtures/deep', 'test/fixtures/ond', 'test/fixtures/one', 'test/fixtures/two' ]
      at: <anonymous> (test/glob.js:11:7)
      stack: |-
  glob: options.filesOnly
    ✖ should be equivalent
    -----------------------
      operator: deepEqual
      expected: |-
        [ 'test/fixtures/a.js', 'test/fixtures/a.mp3', 'test/fixtures/a.txt', 'test/fixtures/b.js', 'test/fixtures/b.txt', 'test/fixtures/ond', 'test/fixtures/one', 'test/fixtures/two' ]
      actual: |-
        [ 'test/fixtures/a.js', 'test/fixtures/a.mp3', 'test/fixtures/a.txt', 'test/fixtures/b.js', 'test/fixtures/b.txt', 'test/fixtures/deep', 'test/fixtures/ond', 'test/fixtures/one', 'test/fixtures/two' ]
      at: <anonymous> (test/glob.js:11:7)
      stack: |-


Bug with the 'sum' aggregation.

When I run the code on the doc page:
import numpy as np; np.random.seed(sum(map(ord, 'calmap')))
import pandas as pd
import calmap
all_days = pd.date_range('1/15/2014', periods=700, freq='D')
days = np.random.choice(all_days, 500)
events = pd.Series(np.random.randn(len(days)), index=days)
calmap.yearplot(events, year=2015)
I get the following result:

Only when I change the aggregation to be mean, I get the expected result:
calmap.yearplot(events, year=2015,how=u'mean')

python version: 3.7.1
pandas version: 0.23.4
calmap version: 0.0.7
matplotlib version: 3.0.1

This is fixed with the addition of a dropzero argument with a default True value for calplot in calplot.

Hi, if this problem still exists and you'd like to create a PR to fix it please direct it to https://github.com/MarvinT/calmap/
That is the version that gets published to pypi and has received several updates to fix some existing issues.

Thank you for creating the issue. Unfortunately I don't have the time to maintain this project. As per @MarvinT 's comment, please see https://github.com/MarvinT/calmap/ instead.


Scalebar coordsys

If we use a map that is in Webmercator, the scalebar will be "wrong" as the distances in webmercator differ about 50% from reality (in the luxembourg area).
This means that we cannot use the standard scalebar.
We would need to specify the coordinate system to be used for the scalebar (in this case EPSG:2169) while the map is in EPSG:3857.
See http://blogs.esri.com/esri/arcgis/2010/03/05/measuring-distances-and-areas-when-your-map-uses-the-mercator-projection/ for more information on the subject.
Or also https://github.com/camptocamp/ngeo/pull/172

this might be related: https://github.com/Geoportail-Luxembourg/geoportailv3/issues/689
We do specify EPSG:2169 as scalebar srs, but the resulting scalebar is not correct.


why can't I run specific browser version?

I have the following configuration file browsers.json:
{
    "chrome": {
        "default": "69.0",
        "versions": {
            "60.0": {
                "image": "selenoid/chrome:60.0",
                "port": "4444",
                "path": "/",
                "tmpfs": {
                    "/tmp": "size=128m"
                }
            },
            "69.0": {
                "image": "selenoid/chrome:69.0",
                "port": "4444",
                "path": "/",
                "tmpfs": {
                    "/tmp": "size=128m"
                }
},
    "firefox": {
        "default": "60.0",
        "versions": {
            "50.0": {
                "image": "selenoid/firefox:50.0",
                "port": "4444",
                "path": "/wd/hub",
                "tmpfs": {
                    "/tmp": "size=128m"
                }
            },
            "60.0": {
                "image": "selenoid/firefox:60.0",
                "port": "4444",
                "path": "/wd/hub",
                "tmpfs": {
                    "/tmp": "size=128m"
        }
            }
        }
    },

In tests I have the following code:
capabilities = {
                "browserName": "chrome",
                "version": "60.0"
            }
            options = webdriver.ChromeOptions()
            options.add_argument('--ignore-certificate-errors')
            options.add_argument('--no-sandbox')
            self.driver = webdriver.Remote(
                command_executor="http://localhost:4444/wd/hub",
                desired_capabilities=capabilities, options=options)

question: why can't I run specific browser version? It gives me exception:
WebDriverException: Message: Requested environment is not available
If I don't specify version in capabilities, test runs successfully.

@hicaptn what's inside the log file? ENVIRONMENT_NOT_AVAILABLE messages are showing which version is in reality passed to Selenoid.

@vania-pooh I've faced another issue. Most probably I've deleted something accidentally and now I get:
2018/06/05 15:01:38 [-] [INIT] [Loading configuration files...]
2018/06/05 15:01:38 [-] [INIT] [Loaded configuration from config/browsers.json]
2018/06/05 15:01:38 [-] [INIT] [Using default containers log configuration because of: read error: open config/container-logs.json: no such file or directory]
2018/06/05 15:01:38 [-] [INIT] [Did not manage to determine your Docker API version - using default version: 1.37]
2018/06/05 15:01:38 [-] [INIT] [Timezone: Local]
2018/06/05 15:01:38 [-] [INIT] [Video Dir: /home/anatolii/video]
2018/06/05 15:01:38 [-] [INIT] [Listening on :4444]

it's when i do ./cm selenoid start --vnc

@hicaptn this message is OK:
2018/06/05 15:01:38 [-] [INIT] [Using default containers log configuration because of: read error: open config/container-logs.json: no such file or directory]

@vania-pooh but why nothing happens after this? before when I did ./cm selenoid start --vnc  it showed that starting docker, starting selenoid etc. But now after this command I cannot execute anything..

ran without configuration manager successfully

Because ./cm selenoid --start overwrites things only with --force flag. Otherwise it considers everything configured and does nothing.

Seems to be resolved. Closing. Feel free to reopen.


[keyvault-certificates] Migrate to TypeSpec

Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR: (Applicable only to SDK release request PRs)
Checklists

[ ] Added impacted package name to the issue description.
[ ] Does this PR need any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here.)
[ ] Added a changelog (if necessary).

API change check
APIView has identified API level changes in this PR and created following API reviews.
@azure/keyvault-certificates


In page anchor links sometimes don't work

Example here:
https://guide.wagtail.org/en-latest/how-to/copying-and-aliasing-pages/#copying-pages
When clicking copying pages, you don't get anchored down the page as the id doesn't match.
The ID on the heading is draftjs_exporterenginesstringelt-object-at-0x7fba786ee680 so it looks like drafttail is doing something weird.

This seems to happen if the heading contains subelements, e.g. if you use bold/italic inside the heading. Fix in #225.


GH-5159 close child of GroupIterator

GitHub issue resolved: #5159
Briefly describe the changes proposed in this PR:
I've added the child argument's iterator as (volatile) field in the GroupIterator so that it can be closed while building entires.

PR Author Checklist (see the contributor guidelines for more details):

[x] my pull request is self-contained
[x] I've added tests for the changes I made
[x] I've applied code formatting (you can use mvn process-resources to format from the command line)
[x] I've squashed my commits where necessary
[x] every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

Should we check if the current iterator is closed within the loop? We have the isClosed() method we can call. For performance reasons the backing variables isn't volatile, but it should still get updated eventually. The variable is set before the handleClose() method is called, so it would be a nice safety net in case the argumentsIter doesn't close correctly for some reason.

Thanks for this fix. Very good catch and a nice and clean solution!

Should we check if the current iterator is closed within the loop? We have the isClosed() method we can call. For performance reasons the backing variables isn't volatile, but it should still get updated eventually. The variable is set before the handleClose() method is called, so it would be a nice safety net in case the argumentsIter doesn't close correctly for some reason.

Yes, that's good to add.

LGTM! thank you @frensjan

Thanks @frensjan !
I've merged the PR and it'll ve part of the next bug fix release which is due any day now.


How to send message?

 client.send_message(111111111, {
    '@type' => 'inputMessageText',
    'text' => {
      '@type' => 'formattedText',
      'text' => text,
      'entities' => []
    }
  })

Hello, I use #send_message method, but I think second argument hash, instead of TD::Types::InputMessageContent it's not a right way, can you help me how I can build TD::Types::InputMessageContent?
P.S. Very nice gem, thanks for your work.

Hello!
Here's working example: https://github.com/centosadmin/redmine_bots/blob/master/lib/redmine_bots/telegram/tdlib/add_bot.rb

@funk-yourself thanks!


DDB Magic Item Spell Save DC Bonus Not Applying on Import

First, thank you so much for all of your work on this module - absolutely integral to my Foundry setup.
My players have some items that add a bonus to spell save DC and spell attack (Ex. Moon Sickle). However, when importing into Foundry, the spell attack bonus is reflected, but not the spell save DC bonus. I was able to find a workaround by adding a dummy item that adds a bonus to the "Warlock Spell Save DC" instead (Rod of the Pact Keeper), and that bonus does apply properly when imported.
I'm running v10 288 and 3.1.20 of the module. Steps to reproduce below:

Create a druid in DDB and add/equip/attune the Moon Sickle +1
Note the spell save DC and spell attack bonuses in DDB
Import into Foundry VTT
Note the spell save DC and spell attack bonuses - in my tests, the spell attack matches, but the spell save DC does not reflect the magic item.
Replace the Moon Sickle with a Rod of the Pact Keeper +1 (equip/attune)
Note the spell save DC and spell attack bonuses in DDB - it will not reflect the item bonus since it is limited to Warlocks
Import into Foundry VTT
Note the spell save DC and spell attack bonuses - in my tests, the item bonuses are properly reflected in Foundry

So this ends up being 2 bugs that are probably related:

Bonus - Spell Save DC is not being reflected when imported into Foundry
Bonus - Warlock Spell Save DC is being reflected when imported into Foundry even if the player is not a Warlock.

Ah! Thanks for this report. I've fixed this in the soon to be released v3.1.21

Dude....you rock. 👏


Fix sonar complaining about statements in notebooks

Sonarqube complained about statements that "have no effect" in the examples, but these are the output cell values for sphinx-gallery, so not actually a bug

Shall I just include the examples for everything?

probably.. Those aren't really subject to code quality

@kosack with excluding the examples/**, codecov and sonarqube now agree on the coverage value


Speed up code

self-explanatory

parallelize the data

implemented multi-processing and made code  more condensed and readable


FreeBSD port

Summary of changes
This brings in a FreeBSD support for LTFS.
Description
This brings in FreeBSD support for LTFS.  This requires the FreeBSD tape improvements checked in to FreeBSD in February 2015.  Specifically, it will work on FreeBSD 10.2 or 11.0 or newer releases.
The port was modeled on the lin_tape backend.  It uses a combination of the FreeBSD sa(4) tape driver and the pass(4) SCSI passthrough driver to send commands to the tape drive.
The encryption support has not been tested, but the rest of the functionality has been in production on Spectra Logic Black Pearl products since 2013.  The port also passed LTO Consortium LTFS Compliance Verification:
https://www.lto.org/technology/ltfs/ltfs-compliance-verification/
There is currently no failover support in the FreeBSD backend.  It could be done at some point if someone wants to do it.
This also includes a different mrsw lock implementation for FreeBSD only to resolve some deadlocks that we experienced with the default implementation.  One of my co-workers mentioned it in this issue:
https://github.com/LinearTapeFileSystem/ltfs/issues/8
I am working on a second pull request with most of the rest of Spectra Logic's changes to LTFS.  That one isn't ready yet.  It is mostly independent of this change, but there may be some minor dependencies.
Type of change

New feature (non-breaking change which adds functionality)
This change requires a documentation update

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have confirmed my fix is effective or that my feature works

Hi Ken,
Thank you for your great enhancement!!
It's good overall and I can marge the PL if you can modify (or confirm) the following 2 major comments.
Mandatory: The magic word of the copyright
Please use the different magic word for copyright registered to both Spectra Logic and IBM and Spectra Logic only.  OO_Copyright_BEGIN -  OO_Copyright_END is used copyright registered only to IBM. And the contents will changed automatically by the replace_copyright.pl script.
Following 2 magic words are used at this time.

OO_Copyright_BEGIN -  OO_Copyright_END -> BSD (IBM Only)
ZZ_Copyright_BEGIN -  ZZ_Copyright_END -> IBM Proprietary (Used in IBM internal code)

So how about to define following two?

SS_Copyright_BEGIN -  SS_Copyright_END -> BSD (Spectra Logic Only)
OS_Copyright_BEGIN -  OS_Copyright_END -> BSD (IBM & Spectra Logic)

Optional: Definition of MultiReaderSingleWriter (MRSW)
Downgrading lock logic in the current code is little bit danger, I think.
//downgrades a write lock to a read lock
static inline void
writetoread_mrsw(MultiReaderSingleWriter *mrsw)
{
	/*
	 * The original intent of this function was to downgrade from write lock
	 * to read lock with higher priority than incoming write
	 * locks. pthread_rwlock doesn't provide this semantic,so we just
	 * release the lock and reacquire a reader lock on it. This demotion is
	 * only used by _ltfs_fsraw_write_data_unlocked() to release the write
	 * lock before returning. If there are pending writers on the volume
	 * lock at this point, they could prevent
	 * _ltfs_fsraw_write_data_unlocked)_ from returning immediately.
	 */
	pthread_rwlock_unlock(mrsw);
	// Someone can cut in here
	pthread_rwlock_rdlock(mrsw);
}

As I commented in Issue #8, it is good to add exclusive mutex into the MRSW for FreeBSD. This is optional, you can do it if you want to now. Or you can split out this change into another PL. If you don't have any plan to do, I will work on this and I will unified MRSW for Linux/macOS and MRSW for FreBSD later. Please let me know what is your preference.
My proposal is as follows
Structures
typedef struct {
	pthread_mutex_t lock;
} ltfs_mutex_t;

typedef struct {
	pthread_rwlock_t  lock;
} ltfs_rwlock_t;

typedef struct {
	ltfs_mutex_t write_exclusive_mutex;
	ltfs_rwlock_t rwlock;
	uint32_t long_lock;
};

Acquire a write lock

Acquire write_exclusive_mutex
Acquire rwlock on write

Release a write lock

Release rwlock on write
Release write_exclusive_mutex

Acquire a read lock

Acquire write_exclusive_mutex
Acquire rwlock on read
Release write_exclusive_mutex

Release a read lock

Release rwlock on write

Once I will close this PL.
Could you made additional changes I commented "Mandatory" in the previous comment at least? And please create the new PL again when the changes are finished.
Then I will merge this patch to the master branch.
Thank you your contribution in advance !

Hi Abe-san,
I have done all of the above, except for the MRSW changes.  It's fine with me if you do a unified MRSW implementation.
I'll put in another pull request shortly with the updates.  (I don't think I can re-open this one.)

Hi Ken, Sure it sounds good to me.
I realized this comment today. I had a notification but I seemed to find wrong places.
I will add an another MRSW implementation which can support Linux, OSX and FreeBSD in the near future.
At first, I will add the switch to use which MRSW architecture. And then, move to new one when we have a confidence of that behavior.

Hi Abe-san,
Sounds like a good plan.
I have more LTFS changes coming eventually, but I have to balance working on those with working on a number of other unrelated things at the moment.


Fix status to Result conversions

Following the changes in https://github.com/rust-osdev/uefi-rs/issues/360, warning status were supposed to be treated as errors when converted to Results. But instead they were incorrectly being converted to Result::Ok. Fix that, and add a new unit test for that case.

I missed this rather important conversion bug in #361! :flushed:

Oops, good catch. I guess it's a good thing we didn't rush with the new release :))


Why jointly training a preference predictor with rating data does not help much with preference prediction?

I wonder that Why jointly training a preference predictor with rating data does not help much with preference prediction?
Could you explain it in details?

Thank you for your interest in our work! We have tried jointly training an aesthetic predictor on top of the CLIP image encoder on Simulacra and AVA. The model structure is exactly the same as the official aesthetic predictor. We empirically find that the preference accuracy does not improve compared to training only on the preference data.
This may indicate that preference data and rating data characterize different aspects of the image. Preference data is annotated with pairwise comparison while rating data is not. Moreover, the rating data from AVA is not conditioned on prompts, and the Simulacra is relatively noisy as we observed, which has a domain shift from the preference data.

You mean that you train a score predictor on Simulacra and AVA. But evaluated on preference data (maybe the metric is acc or others) and found no improvement. Am I right?

Thank you for your interest in our work! We have tried jointly training an aesthetic predictor on top of the CLIP image encoder on Simulacra and AVA. The model structure is exactly the same as the official aesthetic predictor. We empirically find that the preference accuracy does not improve compared to training only on the preference data. This may indicate that preference data and rating data characterize different aspects of the image. Preference data is annotated with pairwise comparison while rating data is not. Moreover, the rating data from AVA is not conditioned on prompts, and the Simulacra is relatively noisy as we observed, which has a domain shift from the preference data.

You mean that you train a score predictor on Simulacra and AVA. But evaluated on preference data (the metric is acc or others) and found no improvement. Am I right?

No, under this setting, the preference predictor is jointly trained with the score predictor. They use different heads and different data during training, and separately evaluated. They only share the image encoder.

No, under this setting, the preference predictor is jointly trained with the score predictor. They use different heads and different data during training, and separately evaluated. They only share the image encoder.

thx.


Error during BulkImport

So I'm running into a strange error I haven't seen before. I re-added var_dump($errorItems) to the ImportException class and below is what I got during bulk import error:
[624]=>
  array(1) {
    ["index"]=>
    array(5) {
      ["_index"]=>
      string(20) "games_20141227034103"
      ["_type"]=>
      string(4) "game"
      ["_id"]=>
      string(4) "4958"
      ["status"]=>
      int(404)
      ["error"]=>
      string(61) "IndexShardMissingException[[games_20141227034103][0] missing]"
    }
  }

With a clean reset I indeed meant to delete all indices and re-indexing. This is really strange. Is there anything obviously different with this piece of data that's being indexed? Are you able to make the bulk import work if you remove this particular data element? I'm not quite sure how to help you with this. It still seems like a Elasticsearch specific error, but maybe it's a Larasearch processing error with specific data.

With a clean reset I indeed meant to delete all indices and re-indexing. This is really strange. Is there anything obviously different with this piece of data that's being indexed? Are you able to make the bulk import work if you remove this particular data element? I'm not quite sure how to help you with this. It still seems like a Elasticsearch specific error, but maybe it's a Larasearch processing error with specific data.

I'm not sure what the problem is, it was working and now it's not. I'm currently in the middle of upgrading to Laravel 5.0 and that may break this package so I will take another look at it once I've completed the upgrade.

I was having the same problem, it was because the charset of the database is different to the ES charset. To fix it use the eloquent mutator methods and apply utf8_encode() to all Text and VarChar columns. I hope this works for you

@pfeiferchristopher I'm curious if you did the Laravel 5 upgrade. I'm just going to check what needs to be changed. Is it ok to close this issue for now or do you need more help?

I have upgraded and haven't re-implemented Elastic search yet. But go ahead
and close it. Not much needs changing if you need a hand I'm pretty
familiar with L5 now.
On Sun, Feb 1, 2015 at 9:27 AM, iverberk<EMAIL_ADDRESS>wrote:

@pfeiferchristopher https://github.com/pfeiferchristopher I'm curious
if you did the Laravel 5 upgrade. I'm just going to check what needs to be
changed. Is it ok to close this issue for now or do you need more help?
—
Reply to this email directly or view it on GitHub
https://github.com/iverberk/larasearch/issues/49#issuecomment-72369166.

Thanks for the feedback!


Support alignment in renderings

See #5

Alignment is used in the rendered message. This library does not modify the message rendering. The renderings property is just supposed to store the rendered properties, with no alignment.


After setup of Java 17, subprocess still runs with 11

Description:
The JRuby build installs specific versions of JDK to build and run tests with, but it seems like any JRuby subcommand run by the build is picking up a Java 11 install regardless of the setup-java JDK version.
This recently came up here: https://github.com/jruby/jruby/pull/8378/checks#step:2:4079
The JRuby build apparently ran with Java 17 (creating org/jruby/Main with bytecode version 61), but when a later part of the build shells out to run JRuby it appears to run with Java 11 (failing to load JRuby because it supports up to bytecode version 55).
I do not see how it could be picking up Java 11 in the subprocess.
Task version:
"v4"
Platform:

[x] Ubuntu
[ ] macOS
[ ] Windows

Runner type:

[x] Hosted
[ ] Self-hosted

Repro steps:
See failed build here: https://github.com/jruby/jruby/pull/8378/checks#step:2:4079
Expected behavior:
All Java-related commands should run with the setup-java JDK version (17 in this case).
Actual behavior:
It seems that some commands (subprocess run from maven, for example) is picking up Java 11 somewhere.

Hi @headius 👋,
Thank you for your report. We will investigate the issue and get back to you as soon as we have updates.

I believe I have worked around it temporarily by explicitly removing the preinstalled JDK packages, installing the version I need, and proceeding from there. I have no theories as to why it picks up one of the preinstalled JDKs in a subprocess of Maven.

Hi @headius,
It looks like the Action worked correctly. The logs indicate that the JAVA_HOME is correctly set to Java 17, and I observe the same error occurring when running with Java 21.
I attempted to reproduce the issue on a simple project, and everything functioned as expected. Therefore, I believe this might be an issue specific to your setup.
Could you please try to reproduce the issue outside of your repository on a different simple project?

@priyagupta108 A simpler project probably would not show the same effect, but it might be possible to simulate enough of it by having Maven shell out to a subprocess and see if it picks the wrong JDK.
Notice that in my subsequent commits I had to remove all the "wrong" JDKs that were installed by default or they would be selected; it is almost as if something in either Maven or the toolchain around it is defaulting to /usr/bin/java which probably was still set up as the java alternative for Ubuntu. This might happen if, for example, the subprocess env loses the custom PATH set up by setup-java (I assume it sets PATH to the requested JDK?).
Given the default set of JDKs, perhaps there's more that setup-ruby could do to make the JDK it installs actually be registered as the default JDK for the system?

@headius 👋 , Thank you for the detailed explanation.
I attempted to reproduce the issue by setting up a similar environment, but I was unable to replicate the problem.
The setup-java action sets the PATH to the requested JDK version but does not switch versions through update-alternatives. If the specified Java version is available in the hosted toolcache directory, the action will add Java's bin directory to the PATH and create the JAVA_HOME environment variable. If the specified version is not available, the action will download it to the hosted toolcache directory, add it to the PATH, and create the JAVA_HOME environment variable. In most cases, setting the JAVA_HOME environment variable is sufficient to specify which Java version should be used by tools and scripts.
However, some tools and subprocesses might not respect the JAVA_HOME environment variable and instead rely on the system's default java and javac.
As a workaround, you can update the system's default Java version using the update-alternatives command. This ensures that the correct Java version is used even if JAVA_HOME is not respected. Here is a sample configuration:
- name: Set alternatives for java and javac
  run: |
    sudo update-alternatives --set java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java
    sudo update-alternatives --set javac /usr/lib/jvm/temurin-17-jdk-amd64/bin/javac

Hello, @headius ! Just checking in to see if there are any updates on your end regarding this issue? Thank you :)

Thank you for providing the update and suggestion regarding the configuration of the default Linux Java alternative.
Since the issue seems to be related to a glitch with Maven and JRuby rather than setup-java action, I am closing this issue. Please feel free to reach out to us in case of any concerns.


Tabbing onto and off minimised layer group selection

This appears to occur in Chrome (32 & 33) - the other browsers I have access to seem to function correctly (IE8-11/Firefox). I don't have an earlier version of chrome to test with at present, sorry.
When a map has the layer group controls, you can tab onto the minimized layer selection div. However the next tab doesn't take you to the radio buttons, it takes you to the start of the page. Doing a shift tab alternatively takes you to the footer of the page. If you cycle back through all the links on the page you can get to the radio buttons.
Edit: Now confirmed to not work correctly in version 33 of chrome also.

Is working with Leaflet 1.7.1 and Chrome 96


Mistake in SimpleListAdapter get item

@Override
public Object getItem(int position) {
if (mStrings == null && position > 0)
return mStrings.get(position);
else
return null;
}
*****should be:
@Override
public Object getItem(int position) {
if (mStrings != null && position > 0)
return mStrings.get(position - 1);
else
return null;
}

There is another error somewhere in the code, So that even with this code, the "no selection" always displays in myTextView the value number 1 instead it should be 0 or null and it does not display anything.

Hi @NivaLevy
Thanks for using the library, yes you right, it's a mistake i fix it


How do I install/add this skill?

Just added the README with setup information! :)


get secret as environnement variable from aws secretsmanager

Hi,
How to get secret as environnement variable from aws secretsmanager, is there an extension to do that ?
The need is to allow adding configuration inside the application.properties or application.yml at startup available for application boot.
Thank's
Best regards,
RAQAOUI MOHAMED

Currently, there is no configuration source for aws secretsmanager, but you can use the client directly to retrieve the secret value. See https://quarkiverse.github.io/quarkiverse-docs/quarkus-amazon-services/dev/amazon-secretsmanager.html
You should be able to build your own ConfigSourceFactory like
public class SecretsManagerConfigSourceProvider implements ConfigSourceFactory {

    @Inject
    SecretsManagerClient secretsManagerClient;

    @Override
    public Iterable<ConfigSource> getConfigSources(final ConfigSourceContext context) {
        List<ConfigSource> result = new ArrayList<>();
        // Retrieve all secrets using pagination and stream
        Map<String, String> secretsMap = secretsManagerClient.listSecretsPaginator().stream()
                .flatMap(response -> response.secretList().stream())
                .collect(Collectors.toUnmodifiableMap(SecretListEntry::name, secret -> getSecretValue(secretsManagerClient, secret.arn())));

        result.add(new SecretsManagerConfigSource(secretsMap, 0));

        return result;
    }

    private static String getSecretValue(SecretsManagerClient secretsManager, String secretArn) {
        GetSecretValueRequest getSecretValueRequest = GetSecretValueRequest.builder()
                .secretId(secretArn)
                .build();
        GetSecretValueResponse getSecretValueResponse = secretsManager.getSecretValue(getSecretValueRequest);
        return getSecretValueResponse.secretString();
    }

    private static final class SecretsManagerConfigSource extends MapBackedConfigSource {

        public SecretsManagerConfigSource(Map<String, String> propertyMap, int ordinal) {
            super("SecretsManagerConfigSource", propertyMap, ordinal);
        }
    }

    @Override
    public OptionalInt getPriority() {
        return OptionalInt.of(290);
    }
}

@scrocquesel any suggestions for using this secrets extension with something like the reactive-pg-client quarkus extension that requires credentials available during STATIC_INIT? The above approach I suspect will result in the same issue where the SecretsManagerClient is not yet initialized during STATIC_INIT as its not available until RUNTIME_INIT.
I don't want to speak for OP, but I suspect that's why they're looking for a way to read secrets and inject as environment variable.

reactive-pg-client

@madocx The Draft PR above is an attempt to have the config read during STATIC_INIT. Tests demonstrate that it can be used to feed the other sdk clients produced at runtime.
I kept the PR as a draft because it has not been tested thoroughly in real use cases, and I don't know if the filter configuration part matches the way AWS secrets are generally used.
If you're willing to test it in your project and provide valuable feedback, it is something I can finally merge.

Hi @scrocquesel ,
for me it work fine with @StaticInitSafe annotation :
@StaticInitSafe  public class IotSecretsManagerConfigSourceFactory implements  ConfigSourceFactory {
And also the dependencies below :
  implementation platform('software.amazon.awssdk:bom:2.19.29')     implementation 'software.amazon.awssdk:secretsmanager'     implementation 'software.amazon.awssdk:sts'
And also WEB Identity Provider and right role on aws EKS .
Best reguards,
RAQAOUI MOHAMED

Excellent, thank you @scrocquesel! I'll implement it today and give it a whirl.

@scrocquesel, briefly looking through the draft PR I have an initial concern I figured I'd pass along. It looks like you're using the same approach as the example above where you're paginating all secrets in the account and retrieving them. If I misunderstood this please correct me, I don't have an understanding of much of the code changes in the PR.
Assuming my interpretation is correct, this is not the most efficient way to do this, as you're billed per secret retrieval by AWS. In larger organizations, there may be hundreds if not thousands of secrets in an account. Ideally, this functionality would be configurable to only retrieve the secrets in a specific config list.

@madocx
Yes by providing a secret name that want to pull , we can be more precise for secret that we want :
`   @Override
public Iterable getConfigSources(ConfigSourceContext context) {
final ConfigValue value = context.getValue("secretname");
if (value == null || value.getValue() == null) {
return Collections.emptyList();
}
     return Collections.singletonList(new IotSecretsManagerConfigSource(VERSION_STAGE,SECRET_MANAGER_ORDINAL,CONFIG_SOURCE_NAME,value.getValue(),SecretsManagerClient.create()));

}

`

Ideally, this functionality would be configurable to only retrieve the secrets in a specific config list.

Yet, this introduces another level of configuration. Might there be a solution that balances cost concerns while avoiding the extra configuration? What if the extension listed all the secrets, but it lazily retrieved the value of each secret? In this case, the extension will incur a charge for each page of secrets it retrieves, but it only incurs a charge for retrieving the secret value when it's actually needed.

My concern with that would be adding to cold start time in lambdas. I'm all for avoiding unneeded configuration, but I'm not sure this is the place for that. I guess as long as that functionality is able to be disabled with optional configuration.

If I understand, the proposed configuration restricts the secrets available to this extension to only those in some allowed list, so that the function only retrieves the secrets that it actually uses (for cost reasons).
Is that duplicative to what one might achieve with IAM configuration? That is, if my account has hundreds of secrets, but my Lambda function only needs 4 of those secrets, then I should only permit the IAM role that my function assumes to access only the 4 secrets it needs. It's my understanding that an API call to list secrets from this function would only retrieve the 4 secrets it needs. Furthermore, addressing this concern with IAM permissions ultimately leads to a better "least privilege" outcome.

@scrocquesel, briefly looking through the draft PR I have an initial concern I figured I'd pass along. It looks like you're using the same approach as the example above where you're paginating all secrets in the account and retrieving them. If I misunderstood this please correct me. I don't have an understanding of much of the code changes in the PR but tried to identify the meat of where it was retrieving the secrets.
Assuming my interpretation is correct, this is not the most efficient way to do this, as you're billed per secret retrieval by AWS. In larger organizations there may be hundreds if not thousands of secrets in an account. Ideally, this functionality would be configurable to only retrieve the secrets in a specific config list.

That's why from what I remember I tried to add filtering.

Not that I'm aware of. Secret value will always be returned as a string value via the AWS api, even if a json structure (in which case it will be escaped). I think its reasonable to expect users to handle their string values accordingly.

@MedRAQAOUI looking at your ConfigFactory more closely, I'm not sure if you intended this or not, but you're bypassing the quarkus extension managed SecretsManagerClient. I suspect if you try injecting the client rather than doing a create you'll get an error since its currently not available during STATIC_INIT and is why the PR @scrocquesel is working on is necessary.
The main downside to this approach is you lose the other benefits of the extension - mainly the configuration options exposed for both sync and async http clients, and credential providers. For your use case this may not be a problem, but I do believe its non-optimal.

you're bypassing the quarkus extension managed SecretsManagerClient. I suspect if you try injecting the client rather than doing a create you'll get an error since it's currently not available during STATIC_INIT

I ran into the same issue while trying to implement a ConfigSource for AWS Secrets Manager, and that's how I came upon @scrocquesel 's work 🙂.

@madocx this code was before @scrocquesel's work

you're bypassing the quarkus extension managed SecretsManagerClient. I suspect if you try injecting the client rather than doing a create you'll get an error since it's currently not available during STATIC_INIT

I ran into the same issue while trying to implement a ConfigSource for AWS Secrets Manager, and that's how I came upon @scrocquesel 's work 🙂.

Yes, the whole purpose of the PR is to provide the client to the configsource with the same config experience as other extension.
Also, to reduce cost, we may need to cache the retrieved values because config source can be called multiple times. How should we handle value changes ? But, I ran out of time and left it for a future PR.

Also, to reduce cost, we may need to cache the retrieved values because config source can be called multiple times. How should we handle value changes ? But, I ran out of time and left it for a future PR.

All other implementations I've seen for secrets handle this with a TTL configuration. Rotating secrets should allow for enough overlap between them that any TTL value is not a problem. I suggest any TTL be optional though, as there are many use cases where secret rotation is not utilized due to technical limitations of other systems.
So perhaps default of indefinite cache, with configurable TTL for rotation?

@MedRAQAOUI @scrocquesel  I noticed this issue is still open. We need the same functionality to read the configuration, but from SSM parameter store.
I'm thinking about joining our efforts to contribute a separate quarkiverse extension for this in spirit of https://docs.powertools.aws.dev/lambda/java/utilities/parameters/ to read from both ssm  and secretsmanager.
Also I was thinking about https://openfeature.dev/ integration extension sometimes, so we may need reading from the AppConfig as well.
If you don't mind, I'll register new extension request for this on quarkiverse

@pragmasoft-ua for me reading from aws secretsmanager only needs to implement these 2 interfaces:

io.smallrye.config.common.AbstractConfigSource
io.smallrye.config.ConfigSourceFactory
And to have AWS authentification managed out of java code by the cloud (in our side AWS EKS) you need to add aws sts dependancy :
software.amazon.awssdk:sts
In addition to WEB IDENTITY PROVIDER mechanism well configured on AWS EKS (declaration of aws IAM role that identify the aws EKS cluster).

If you want the code of AbstractConfigSource and  ConfigSourceFactory implementation I can share it with you.

@MedRAQAOUI @scrocquesel I noticed this issue is still open. We need the same functionality to read the configuration, but from SSM parameter store.
I'm thinking about joining our efforts to contribute a separate quarkiverse extension for this in spirit of https://docs.powertools.aws.dev/lambda/java/utilities/parameters/ to read from both ssm and secretsmanager.
Also I was thinking about https://openfeature.dev/ integration extension sometimes, so we may need reading from the AppConfig as well.
If you don't mind, I'll register new extension request for this on quarkiverse

It could be a good idea. This extension is mainly designed to provide clients and has been designed to offer clients at the RUNTIME_INIT phase. Unfortunately, ConfigSourceFactory requires everything to be set up earlier. I attempted to share the same spirit of being able to choose the client implementation (sync/async/url/netty/apache/crt), but it resulted in a lot of duplicated code, and I don't think it's really necessary.
I believe that having a simpler extension focused only on providing the configuration would be easier to implement. Nonetheless the PR is still opened for contribution. I don't use AWS myself, so I have no added value regarding STS.

For reference, this sample implements both a credential provider and config source factory


Add documentation about Nginx for static file redirect

Serve all files with Nginx when using LocalStore (including repodata.json)
Add nginx config to docker-compose for local testing
Add documentation about nginx configuration

I think serving json files with Nginx when it is already configured for channels makes sense as it can compress json files and add max-age to the cache-control header (as shown in the example and documentation). The only drawback I see is that the max-age will be the same for all channels. It has to be hard-coded in Nginx configuration and can't be set to the channel ttl.
This is only enabled for the LocalStore as Nginx needs to be configured. Maybe it should be enabled via a different option so it can be used when using another package store?

This would fix #414


Pctc

Fixes #1668  (partly)

Hello @williamFalcon! Thanks for opening this PR.

In the file pytorch_lightning/trainer/data_loading.py:

Line 220:120: E501 line too long (124 > 119 characters)

Do see the Hitchhiker's guide to code style

@williamFalcon are you trying to fix this: #1920  ?

@awaelchli partly. also enabling this to take a number of batches instead of just a percent.

@awaelchli @Borda take a look?

besides the new Trainer flags, it's not easy to see what's the difference to #1920. It seems you have re-implemented it.

@williamFalcon are you trying to fix this: #1920 ?

@awaelchli partly. also enabling this to take a number of batches instead of just a percent.

so shall #1920 be merged first? otherwise, it may raise plenty of conflicts...

btw, this was not reviewed as @awaelchli @Borda asked to rebase it on #1920

I wonder if overfit_batches can be removed entirely. It's good to strive for an API where there's only one way to do things, and I feel like the problem with these trainer args is that it's not clear what the difference between setting overfit_batches=1 or limit_val_batches=1 and limit_train_val=1 is?
Regardless, this PR is still an improvement to how it was before. Is there any reason you didn't put deprecation warnings in?

This was a two-part PR.
The warnings are here https://github.com/PyTorchLightning/pytorch-lightning/pull/2220
This was the time to remove overfit but i realized it actually serves a different approach.
overfit_batches will actually use the train set for train, val and test so you can truly overfit. It also removes the shuffle from the training set so you iterate over the same exact stuff.
However, the other 3 flags don't serve that purpose. Those are more for only using some of the data for training, val or test (likely for debugging purposes)

Hi, I'm getting an error
~/.local/lib/python3.7/site-packages/pytorch_lightning/callbacks/progress.py in total_val_batches(self)
     99             is_val_epoch = trainer.current_epoch % trainer.check_val_every_n_epoch == 0
    100             total_val_batches = trainer.num_val_batches if is_val_epoch else 0
--> 101             total_val_batches = sum(total_val_batches)
    102         return total_val_batches
    103

TypeError: 'int' object is not iterable

from a line added in this PR: https://github.com/PyTorchLightning/pytorch-lightning/commit/04c794ca72f45dd492e49baff773c2b8e274b9ed#diff-c611176c04f224f1ec16a768aec9c527R101
Turns out sum(0) doesn't work in python, so maybe it should be
total_val_batches = sum(trainer.num_val_batches) if is_val_epoch else 0

I'm writing this here instead in a new issue, as this is a very fresh PR, I hope that's ok.  Also, I wonder how this got past the tests.

@pwl good catch, mind sending a fix PR?


feat: Added darktheme for the signup and signin page

Summary
Added the dark theme for signin and signup page
Description
we don't have the dark theme for both signin and signup page we only have a dark theme for home page i have added that one also
Images
signup page

signin page

Issue(s) Addressed
Enter the issue number of the bug(s) that this PR fixes

Template should be strictly Closes < #329>
Example: Closes: #329

Prerequisites

[ yes ] Have you followed all the CONTRIBUTING GUIDELINES?

Thank you Ameerjafar! Your PR title meets our guidelines.

Hello krishnaacharyaa Thank you for your PR. Unfortunately, it doesn't meet our quality checks.
Please ensure you follow our contribution guidelines. The PR title should match the required format.
For example, it should be like: fix-#124: Added responsiveness to the Home page screen.
If you have any query kindly check our contributor guidelines.

Hello krishnaacharyaa Thank you for your PR. Unfortunately, it doesn't meet our quality checks.
Please ensure you follow our contribution guidelines. The PR title should match the required format.
For example, it should be like: fix-#124: Added responsiveness to the Home page screen.
If you have any query kindly check our contributor guidelines.

Thank you krishnaacharyaa! Your PR title meets our guidelines.

Thank you krishnaacharyaa! Your PR title meets our guidelines.

Thank you Ameerjafar! Your PR title meets our guidelines.

Thank you Ameerjafar! Your PR title meets our guidelines.

Thank you Ameerjafar! Your PR title meets our guidelines.

Thank you Ameerjafar! Your PR title meets our guidelines.

@Ameerjafar can you please check in the other places and see if there is requirement to make the fields even darker? Can you check standards of the dark theme forms, and we can change it everywhere, may be in the next PR, i'm fine with that. just once can you check

@krishnaacharyaa i have just reopned the pr

@krishnaacharyaa ok sir.


August component broken

Home Assistant release with the issue:
0.75.3

Last working Home Assistant release (if known):
N/A
Operating environment (Hass.io/Docker/Windows/etc.):
Ubuntu 16.04 venv

Component/platform:
august
https://www.home-assistant.io/components/august/

Description of problem:
Doesn't work. I can't really tell what it is, logs below.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
august:
  login_method: email
  username<EMAIL_ADDRESS>  password: !secret aug_pass

Traceback (if applicable):
2018-09-06 14:50:38 ERROR (SyncWorker_0) [homeassistant.components.august] Unable to connect to August service: 403 Client Error: Forbidden for url: https://api-production.august.com/session
2018-09-06 14:50:39 ERROR (MainThread) [homeassistant.setup] Error during setup of component august
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/homeassistant/setup.py", line 148, in _async_setup_component
    component.setup, hass, processed_config)  # type: ignore
  File "/usr/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/lib/python3.6/dist-packages/homeassistant/components/august.py", line 151, in setup
    return setup_august(hass, config, api, authenticator)
  File "/usr/local/lib/python3.6/dist-packages/homeassistant/components/august.py", line 114, in setup_august
    state = authentication.state

Additional information:
None.

Fixed with an update.


Fix import_requested_observations ABC

Fixes import_requested_observations by:

merging #2408
adjusting for divergence of main and #2408

A few trivial additional simplifications.

coverage: 93.477% (-0.01%) from 93.489%
when pulling 74047a7bf802e97b37a329f922a006db3183aff6 on jdc-refactor-inat-job
into ad17a0026e65b055aeb64e3ca211c539cd1656a3 on main.


Change title font

We kept the same font that is used in logos for titles but its purpose should only be decorative.
We could keep it only for branding (logos, banners) and use something else (keep Source Sans for titles?)

Yes, I agree.


Can't log into Sandbox.

In Chrome and Firefox, when I enter my username and password, then click Save, nothing happens.   In other words, it doesn't appear to authenticate me to the Sandbox page.
Also, I never see the Try! buttons for any of the documented commands (GET/PUT/POST/DELETE).  I'm using the same user name and API key that I use for testing the Ruby API.  I also do not see the editable fields that are shown on this page: https://www.textmagic.com/docs/api/sandbox/

User error, but the current UI is a bit counter-intuitive.


[CI] Compilation of React-Native 0.8.0-rc.2 fails on CI services due to unknown selector for UIFont

Since I've upgraded to 0.8.0-rc.2 I'm encountering the following errors while building the project with a build server:
/Users/distiller/xx/ios/node_modules/react-native/React/Base/RCTConvert.m:821:37: warning: undeclared selector 'systemFontOfSize:weight:' [-Wundeclared-selector]
    if ([UIFont respondsToSelector:@selector(systemFontOfSize:weight:)]) {
                                    ^
/Users/distiller/xx/ios/node_modules/react-native/React/Base/RCTConvert.m:822:22: error: no known class method for selector 'systemFontOfSize:weight:'
      font = [UIFont systemFontOfSize:fontSize weight:fontWeight];
                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/distiller/xx/ios/node_modules/react-native/React/Base/RCTConvert.m:857:39: warning: undeclared selector 'systemFontOfSize:weight:' [-Wundeclared-selector]
      if ([UIFont respondsToSelector:@selector(systemFontOfSize:weight:)]) {
                                      ^
/Users/distiller/xx/ios/node_modules/react-native/React/Base/RCTConvert.m:858:24: error: no known class method for selector 'systemFontOfSize:weight:'
        font = [UIFont systemFontOfSize:fontSize weight:fontWeight];
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings and 2 errors generated.

Locally, it seems to build and run fine. I'm not sure what the solution should be here, but I guess there are a few options such as increasing the compilation target or fixing the build settings on my build server (I'm using CircleCI).
See also:
http://stackoverflow.com/questions/29345692/why-does-uifont-systemfontofsizeweight-not-crash-on-ios-8-0

Are you capable of setting the version of xcode used? Based on documentation here https://circleci.com/docs/ios#software-versions it seems to have a compatible xcode version. I ran into this when upgrading to 0.8.0-rc and was running XCode 6.1and have since upgraded to 6.2 and no longer have these issues.

@browniefed that indeed seemed to be the problem. For Circle CI users, the following can be used to fix this issue:
machine:
  xcode:
    version: "6.3.1"

I'm having the same problem locally just trying to build it. It keeps on failing.

@rashthedude same comment, make sure your XCode is up to date if you are getting this particular error.

@browniefed I'm in the midst of downloading and installing 6.3 but surely updates for react native shouldn't push the users to install the latest and greatest xcode which in many cases is not possible due Maverick or lower not supporting it.

@rashthedude From my knowledge XCode is directly tied to certain IOS versions therefore yes you'll have to generally keep your XCode up to date to take advantage of react-native, and the latest IOS and IOS features.
I'm currently on Mavericks running 6.2 which is supported, however I do imagine in the future I'll need to upgrade to Yosemite and the most recent XCode.

@browniefed It does make sense having to be able to develop for the latest IOS needs a more refined Xcode. I hope Xcode 7 doesn't become a requirement anytime soon.


add Alamofire namespace to DataResponse and DownloadResponse debugDes…

Update DataResponse debugDescription
Goals :soccer:
Update log message of DataResponse and DownloadResponse to include [Alamofire] namespace at the beginning of the line, that will help search and filter the log message, like other libraries do such as Firebase SDKs

Thanks for the PR!
debugDescription isn't a logging description, it's what's seen in the debugger when printing the variable, so I'm not sure it's appropriate to attempt to namespace it. This would be something better handling in an actual logger, if Alamofire actually shipped one (I can see the value, if we can constrain the feature set). For example, this would be entirely unnecessary if logging through OSLog, as OSLog already has the notion of namespaces internally, allowing users to print what they want and capturing the namespace as part of the data recorded. You can see this when viewing logs in the Console app.
So ultimately I don't think this is a good fit for the library and should be part of whatever logging solution consumers come up with, or a logger that's provided by Alamofire.
@cnoon Any thoughts?

what I meant is in order to log request to console  and not use a 3rd party for that we may  do it like that
.responseObject { (response: DataResponse<Response<T>,AFError>) in
                print(response)
//...
        }

or when want more details, can use debugPrint(response)
but the log in the console will be lost among all other logs.

I understand the desire here, as well as your implementation, but I don't think it's appropriate to add extraneous information to the debug description like this. If you need a log marker you can add them yourself. Your implementation from the PR can be done fairly simply in code:
response.debugDescription.split(separator: "\n").map { "[Alamofire]: \($0)" }.joined(separator: "\n")

Whereas, if this change were adopted, anyone using a dedicated logging system that can automatically separate logging sources would get a bunch of text they didn't want, obscuring what they're trying to log.
In essence, what you want is easier to add programmatically than it is to remove, so it probably shouldn't be added.


Attempt to speed up MacOS builds.

Seems that older MacOS versions had buggy C89 implementations and include incompatible headers without asking.


Refactor tests.

To avoid rgb-tools/rgb-lib#15.
It can be done by using the test_context crate.
https://docs.rs/test-context/latest/test_context/

I tried to use test_context. But it's too hard to pack a actix_web App object into TestContext. I'll try another approach. I close this as won't fix.


Please expand_path on inherit_from

No such file or directory - /Users/ryan/Work/p4/zss/src/minitest/dev/~/.rubocop.seattle.yml

I can look at fixing this today unless someone else wants to!

@mattjmcnaughton By all means - go ahead!


Incorrect redirects after creating entry or DM entry

Description

In the campaign details page, there is a entry button in order to create an entry. After clicking on it, filling the entry form and clicking create, the user is incorrectly redirected to the (assigned)character's detail page.
In the campaign details page, there is a DM entry button in order to create an entry. After clicking on it, filling the DM entry form and clicking create, the user is incorrectly redirected to the DM entry index page.

Expected Behavior

After creating an entry or a DM entry, the user should be redirected to the campaign details page if they initially clicked on entry and DM entry buttons there.
Actual Behavior

Steps to Reproduce

For Entry

Create a campaign with assigned character
Click on campaign (go to its detail page)
Create an entry and click create
You are now incorrectly redirected
For DM Entry
Create a campaign
Click on campaign (go to its detail page)
Create a DM entry and click create
You are now incorrectly redirected

Context

Possible Fix

Other
Description

Additional Notes

Hey team! Please add your planning poker estimate with ZenHub @bcobo341 @IanjhPhillips @JasonGadoury @RobertoNittolo


Could not run RunnerDeployment with organization setting

Hi, I just installed this for my organization and I already saw that the runners are running:
› kubectl get runner
NAME                        ORGANIZATION   REPOSITORY   LABELS   STATUS
github-runner-dn442-25m4h   lifepal                              Running
github-runner-dn442-btkzd   lifepal                              Running
github-runner-dn442-pxgh6   lifepal                              Running
github-runner-dn442-xzd2k   lifepal                              Running

And the runners are registered within the organization as well as shown below.

And this is how I installed the runners:
apiVersion: actions.summerwind.dev/v1alpha1
kind: RunnerDeployment
metadata:
  name: github-runner
spec:
  replicas: 4
  template:
    spec:
      organization: <my org>

However, the actions could not be run. This was the error I got from the action log

It looks like I must have missed a setting somewhere?

@rezmuh Hey! Maybe there's any issue in your workflow definition? Would u mind sharing it?
To me, a docker run like this one, in a job on a self-hosted runner, just works: https://github.com/mumoshu/runnertest/blob/master/.github/workflows/test.yaml#L18

Hi, this is the workflow definition I tried to run.
name: pull-request

on:
  pull_request

env:
  CARGO_TERM_COLOR: always

jobs:
  build:
    runs-on: self-hosted
    container: rust:1.43.0

    services:
      db:
        image: postgres:10.1-alpine
        env:
          POSTGRES_USER: postgres
          POSTGRES_PASSWORD: postgres
          POSTGRES_DB: postgres
        ports:
        - 5432:5432
        # Add a health check
        options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5

    steps:
    - uses: actions/checkout@v2
      with:
        ssh-key: ${{ secrets.SSH_KEY }}
        submodules: 'recursive'
    - uses: actions/cache@v2
      with:
        path: |
          ~/.cargo/registry
          ~/.cargo/git
          target
        key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
    - name: Install rustfmt
      run: rustup component add rustfmt --toolchain 1.43.0-x86_64-unknown-linux-gnu
    - name: Build binary
      run: cargo build
    - name: Run tests
      run: cargo test

Here's a longer version of the log. Looks like the issue is on actions/cache ?

@rezmuh Thanks! Perhaps it has something to do with GH Actions' services support?
Would you mind running:

ls -l /var/run/docker.sock before any other job in your workflow
chmod 666 on /var/run/docker.sock  before any other job in your workflow

still the same. I even removed the services just to see if it would build without it. But it still stopped at the same step. However, I found another error from the annotations:

Perhaps it has something to do with how my Kubernetes is setup? Does it require certain type of network that my kubernetes doesn't support? If it any helps, my Kubernetes cluster is on EKS (version v1.13) and was installed through eksctl.

@rezmuh Would you mind confirming that you do know that any changes to workflow yaml must be in the master branch to work? (In other words, I was wondering if you tried to test it with a workflow run triggered via a pull request that changes your workflow definitino

@mumoshu no, i wasn't aware that changes to workflow yaml must be in master branch because i tried creating a pull-request workflow that is only triggered during pull-request and it worked. even though master branch doesn't have that workflow file yet.

btw, i just tested to create a self-hosted runner on a separate EC2 instance and I got the same error. I fixed it by adding a Docker daemon and add the user group into a docker group to be able to run the workflow.
So I presume this runner has Docker in Docker inside Kubernetes? Then I guess the issue is that the pod / runner could not connect to Docker in Docker?

Thanks. I think we're close.
Yes, it's a dind inside a K8s pod. Each one-shot runner pod has a sidecar container that's named docker which is running a docker daemon.
Even though I'm still unable to reproduce your exact issue, the user/group settings seem not "correct" between the runner and the dockerd containers.
In docker container I see:
/ # id $(whoami)
uid=0(root) gid=0(root) groups=0(root),0(root),1(bin),2(daemon),3(sys),4(adm),6(disk),10(wheel),11(floppy),20(dialout),26(tape),27(video)
/ # ls -lah /var/run/docker.sock
srw-rw----    1 root     root           0 Jun 22 11:39 /var/run/docker.sock

Where in runner container I can see:
$ id $(whoami)
uid=1000(runner) gid=1000(runner) groups=1000(runner),27(sudo)
$ ls -lah /var/run/docker.sock
srw-rw---- 1 root root 0 Jun 22 11:38 /var/run/docker.sock

For me, it seems to be "accidentally" working due to that the docker.sock has rw for gid 27and both root user in docker container and runner user in runner container belongs to 27. But 27 is video in the docker container and sudo in the runner container, which seems this just a coincidence.
What're outputs of id $(whoami) on your env? Probably that's the key.

let me try to reproduce this in a few hours. However, is it possible to make runner user as a part of docker group? would that solve the issue?

@rezmuh Yeah probably. Is there any "reserved" gid for the docker group that I can use? We need to explicitly specify and share the same gid for docker group between both containers.

Too bad that adding docker group to the dind container would require us to fork the dind image 😢

Well, how about adding the runner user to root(0) group? It might be "mostly" safe as long as we don't use a privileged container.
runner@mumoshu-runnertest-hzvfg-r4xq6:/$ sudo usermod -aG root runner
runner@mumoshu-runnertest-hzvfg-r4xq6:/$ id runner
uid=1000(runner) gid=1000(runner) groups=1000(runner),0(root),27(sudo)

More concretely, how about adding usermod -aG root runner to our runner Dockerfile here?
https://github.com/summerwind/actions-runner-controller/blob/master/runner/Dockerfile#L46
cc/ @summerwind

sorry for the late response. weird that I see the ids very similar to yours:
on docker container:
# id $(whoami)
uid=0(root) gid=0(root) groups=0(root),0(root),1(bin),2(daemon),3(sys),4(adm),6(disk),10(wheel),11(floppy),20(dialout),26(tape),27(video)
# ls -lah /var/run/docker.sock
srw-rw----    1 root     root           0 Jun 23 04:08 /var/run/docker.sock

and on the runner container:
# id $(whoami)
uid=0(root) gid=0(root) groups=0(root),0(root),1(bin),2(daemon),3(sys),4(adm),6(disk),10(wheel),11(floppy),20(dialout),26(tape),27(video)
ls -lah /var/run/docker.sock
srw-rw---- 1 root root 0 Jun 23 04:08 /var/run/docker.sock

Btw here's some errors I saw from docker container log:
https://gist.github.com/rezmuh/ea44373ff09112fe2368265c7d9e0c5b
Not sure if it helps

@rezmuh Thanks! That helps.
So our user commands like docker run within job step run seem to work as expected.
I'm now curious if this has something to do with container: rust:1.43.0 used for your job. (You're still using the rust container to run steps, right?
I tried to reproduce your error on EKS nodes using this workflow definition, but has no luck.
For me it throws a different error:

Give the above information, do you have any idea on how I can reproduce your issue?

JFYI, with services only, it works on EKS nodes for me:
https://github.com/mumoshu/runnertest/blob/master/.github/workflows/test.yaml#L1

@rezmuh Which version of actions-runner-controller are you using?

Not sure if I follow the question. But I installed it using:
$ kubectl apply -f https://github.com/summerwind/actions-runner-controller/releases/latest/download/actions-runner-controller.yaml
Then I used Github Personal Access Token, then I used a RunnerDeployment to deploy (as shown in the beginning of the issue body)
But i don't think the issue comes from rust:1.143.0 container only though. I tested this yesterday with a different workflow in different repository (doesn't have services but does use actions built with Docker) and it failed with the same error

@rezmuh Thanks. I've tried to reproduce it using the latest release of actions-runner-controller and a prerelease version of it, but had no luck.
I'm using a personal access token, and a RunnerDeploment, too. So probably that's not the issue.
All I can say is that this can hannep when our pods or clusters have different configurations.
How's your EKS cluster created? WIth eksctl, cdk, or anything else? Can you still reproduce the problem on K8s 1.15 or greater?
I'm using eksctl 0.22.0 and K8s 1.16.

i created using eksctl but on an older version 0.12.0 and kube 1.12. Let me try to upgrade both and see if it works

So, i upgraded my cluster using eksctl 0.22.0 and K8s 1.16. But now I see different errors, like below:

This happens on multiple repositories (one is using Rust, the other one is using Nodejs)

I also tried to create a new cluster in EKS with the latest version but got the same error :(

Btw, i have figured this out now. Looks like I needed to create a custom image on for the action runners. So this now works fine.

@rezmuh Yes, those various "no such file or directory" errors are due to that your custom job image specified via container lacks required executables used by pre-made actions like actions/checkout@v2.
So apparently your original issue seemed have been caused by older versions of K8s, which was good to know! Thank you so much for your patience and help!

Hey @rezmuh & @mumoshu I was hoping to pick your brain on this since I am having the same issue as rezmuh mentioned here: https://github.com/summerwind/actions-runner-controller/issues/60#issuecomment-648779624
I am also using a custom image for my runner and my workflow has the container attribute set. When I try to run my job I get this error; Please note that pulling and running the container is working fine (DinD part):
/usr/bin/docker exec  7b29d4c942123bf7715192b49827897b24041d30ba06b093a2028148cc5ca77f sh -c "cat /etc/*release | grep ^ID"
OCI runtime exec failed: exec failed: container_linux.go:349: starting container process caused "exec: \"/__e/node12/bin/node\": stat /__e/node12/bin/node: no such file or directory": unknown

When I replace my custom runner image with the summerwind/actions-runner image, everything works fine, which gives me the impression that the error is not caused by the container that I specified in my workflow.

@erikkn Hey!

Hey @mumoshu! Thank you for your reply :)!
Yes, I did install the node package in my runner image, but unfortunately this did not solve my problem; I tried to do some manual debugging and when I was looking into the summerwind/actions-runner image I noticed that the node package is not installed in that package.
Please note that I am 'not' using DinD, just a sidecarContainer, which uses the docker:dind container, just like the summerwind/actions-runner does with the proper volumeMounts.

In the light of full transparency, here is my Docker sidecarContainer stdout:
time="2020-11-15T10:52:10.018015952Z" level=info msg="Loading containers: done."
time="2020-11-15T10:52:10.047691220Z" level=info msg="Docker daemon" commit=4484c46 graphdriver(s)=overlay2 version=19.03.13
time="2020-11-15T10:52:10.048050310Z" level=info msg="Daemon has completed initialization"
time="2020-11-15T10:52:10.095094243Z" level=info msg="API listen on [::]:2376"
time="2020-11-15T10:52:10.095365779Z" level=info msg="API listen on /var/run/docker.sock"
time="2020-11-15T10:52:34.918740107Z" level=info msg="shim containerd-shim started" address=/containerd-shim/ef95dd4484eec1cf8e230e0fe83c2ee23f152a4f23531bbfb97f093aabdfa716.sock debug=false pid=446
time="2020-11-15T10:52:36.035255010Z" level=error msg="stream copy error: reading from a closed fifo"
time="2020-11-15T10:52:36.035625469Z" level=error msg="stream copy error: reading from a closed fifo"
time="2020-11-15T10:52:36.040737025Z" level=error msg="Error running exec 8abef485c6c27eefc11437d7b9f7a1814bc7e03309cc5ab92408c75697192b7d in container: OCI runtime exec failed: exec failed: container_linux.go:349: starting container process caused \"exec: \\\"/__e/node12/bin/node\\\": stat /__e/node12/bin/node: no such file or directory\": unknown"
time="2020-11-15T10:52:36.261430760Z" level=error msg="stream copy error: reading from a closed fifo"
time="2020-11-15T10:52:36.261527617Z" level=error msg="stream copy error: reading from a closed fifo"
time="2020-11-15T10:52:36.265450572Z" level=error msg="Error running exec df7363480c392836241889688419a68fa52588a7229b759c9b5d62b934c351c0 in container: OCI runtime exec failed: exec failed: container_linux.go:349: starting container process caused \"exec: \\\"/__e/node12/bin/node\\\": stat /__e/node12/bin/node: no such file or directory\": unknown"
time="2020-11-15T10:52:36.378291317Z" level=info msg="shim reaped" id=b15e076e911f481a0d61c404dac81896bf4f3d2314a72ef65c91b59c4c036c3a
time="2020-11-15T10:52:36.388600667Z" level=info msg="ignoring event" module=libcontainerd namespace=moby topic=/tasks/delete type="*events.TaskDelete"

I stumbled upon this (https://github.com/actions/checkout/issues/334) issue, but the file /__e/node12/bin/node command they mention at the bottom for test, errors out in the official summerwind/actions-runner as well.

@erikkn Thanks for the report! I'm now reading https://github.com/actions/checkout/issues/334#issuecomment-716068696 and wondering if we need to copy all the deps included in the actions runner's release archive into our runner image, and provide missing shared libraries.
Probably it takes a few days for me to finish that. Until then, it would be great if you could keep using checkout v1

Thanks a lot! I am quite new to this scene, but I am very keen to help out where I can, please let me know if there is anything.

Running into the same issue with the cache step as commented here: https://github.com/summerwind/actions-runner-controller/issues/190#issuecomment-728259356
Let me know if you want to sync-up about those libraries / or if you have a list somewhere so I can help to tackle this.

Linking this to @erikkn's awesome PR #203. I'll take a deeper look soon 🙏


Backend: Migrate PPL Logs queries to the backend

PPL Logs are processed into dataFrames on the FE, and as timeSeries on the BE. They should probably be separated out.
ES plugin doesn't support PPL queries, but maybe the Logs PR for Lucene could be something to look at for reference.
Some general guidelines are:

Create visualization to compare between frontend and backend flows, preferably in a shared Cloud dashboard e.g. clouddatasources.grafana.net
Unit tests in the frontend should be copied or updated in the backend to assert the same behavior and add unit tests when there are none.

Check Elasticsearch repo for related tests – helpful when there are no OpenSearch tests in the frontend or backend

We should match OpenSearch's backend behavior to the current frontend behavior, but be aware it may not always make sense. Elasticsearch's current behavior is also another resource for how OpenSearch should behave.

Let's be pragmatic about this – our foremost goal is the migration of OpenSearch's frontend behavior. We can aim for some Elasticsearch feature parity, but only within reason.

Often there is a PR in the Elasticsearch backend data source migration https://github.com/grafana/grafana/issues/54011 which is 75% of what OpenSearch will need
Migrate or implement: i.e. make any changes to code in backend
Use the dashboard created above to compare visualization results (data frame comparison)

Can also inspect data frame on a more detailed basis

Note: (Similarly to Lucene Logs of the FE) It looks like PPL Logs are not completely correctly processed on the Frontend, as the int field is passed as string. This isn't the case on the BE, as seen from the screenshot.

maybe we can also fix this one: https://github.com/grafana/opensearch-datasource/issues/212 with this ticket


Fix course list not refreshing and course page not redirecting after unenrolment

2 fixes were carried out on pull request crux-bphc#336, namely:-
1)Course page still opens even after unenrolment.
2)Local course list does not refresh after unenrolment.

This PR has two merge commits that are totally necessary. I'm not sure if this a way to convert this directly into a linear history using an interactive rebase. You can always start the process from scratch in a separate branch and cherry pick your specific commit.
I haven't gone through the code yet.


Usage Limitations, how to work around?

I'm facing the github error (limit 65536 characters).
When using this in for my real repo with multiple contributors, I get this error:
RequestError [HttpError]: Validation Failed: {"resource":"Issue","code":"custom","field":"body","message":"body is too long"}, {"resource":"Issue","code":"custom","field":"body","message":"body is too long (maximum is 65536 characters)"}

What's a good workaround I can use? I can see that the report was generated, only the posting failed. Is there anywhere else I could download the MD file from?

Right now there are only 2 options that I see.

Inputs values. You can change configuration via inputs. Hide unnecessary information. For example, you can use only one method for AGGREGATE_VALUE_METHODS or hide some tables via SHOW_STATS_TYPES input. Another way to reduce size of the body is to hide users via HIDE_USERS. In case you need all information in report, try to split it in different reports via REPORT_DATE_START и REPORT_DATE_END
You can get markdown string as an output and split it manually. Post it as an issue and comment after it.

I'm aware of this problem. I will handle it later. I hope my options help you.

I needed to see the users.. I used theSHOW_STATS_TYPES for now, but I still would like to generate the entire data together.
Splitting by dates was going to be my last resort, as I'll have to start aggregating several tables myself.

You can get markdown string as an output and split it manually. Post it as an issue and comment after it.
🤔
how can I get the MD as a string?

Thanks for all your efforts btw!

🤔
how can I get the MD as a string?
By setting EXECUTION_OUTCOME == output?

Yep!

EXECUTION_OUTCOME: output seems to be an invalid input

Released fix

Super fast! Checking now

Well the validation seems to pass, so does the entire workflow. But unfortunately I'm not seeing any output in the console log. Do I need to get it somewhere manually?

You can access data on the next step via outputs

Got it, thanks a lot! Closing this issue


chore: Replace implementation by new shim proposal from beta react docs

The new beta react docs describe a new userland implementation of useEvent which makes use of useInsertionEffect which allows calling the event function in a useLayoutEffect or useEffect.
This PR updates the current implementation to the one propsed in the beta react docs here.
If the library is used with a react version <18 the hook falls back to useLayoutEffect.

I'm going to do some React 18 testing, and make sure this works as intended.
I'll also see if I can create some side-by-side tests for these different scenarios.

I upgraded to React 18 with no issues.  Tests pass!

Published as 0.9.3


[AVCe, HEVCe] Fix for default MaxQPI, MaxQPP, MaxQPB

Issue: MDP-50776
Test:  manually (behavior is needed)

@ogolikov the question is still there, why don't you set minimum QP to 1 inside void MfxHwH264Encode::SetDefaults ? You did it for hevc

ok, I checked driver code, so they are clamping QPs to range [1, 51], see https://github.com/intel/media-driver/blob/bc5190beb1f538f239b00ba3b4aa222fe7f4ee7d/media_driver/agnostic/common/codec/hal/codechal_vdenc_avc.cpp#L3212


Add flags and is_remix() to dpp::attachment

Added flags and is_remix() method to dpp::attachment, dpp::message

i'll merge it once the builds are complete, okay?!

i'll merge it once the builds are complete, okay?!

yes

i'll merge it once the builds are complete, okay?!

build successful


Custom Action for Deep Link

I am attempting to follow along with the example found at (https://docs.urbanairship.com/guides/ios-deep-linking/#customizing-the-deep-link-action) and I cannot find a constant in the Xamarin component/nuget package that corresponds to the constant "kUADeepLinkActionDefaultRegistryName".
It seems there should be a similar constant in the Xamarin project, but if there is there is no public access to it.

HI there,
You're right, it looks as though the action name constants are not in the binding. My guess is that the tool we're using to generate bindings doesn't include preprocessor macros, which is how these are defined in the SDK.
As a workaround for now you can try using the literal name, "deep_link_action", which is unlikely to go away time soon.

@marc-scig I have tried using the string directly, and when I do that I receive the following error when attempting to open my app from a push notification:

Attempting to JIT compile method '(wrapper managed-to-native) UrbanAirship.UAActionCompletionHandler:wrapper_aot_native (object,UrbanAirship.UAActionResult)' while running in aot-only mode. See https://developer.xamarin.com/guides/ios/advanced_topics/limitations/ for more information.

It seems to me that there is something weird going on in the UAActionCompletionHandler that the Xamarin compiler isn't able to handle. I am using Visual Studio 7.1.5 (build 2) with Xamarin.iOS 11.
This is the code I have set up in my AppDelegate to do the custom action:
//custom action             UAAction deepLinkAction = UAAction.Action(HandleUAActionBlock);             UAirship.Shared.ActionRegistry.UpdateAction(deepLinkAction, "deep_link_action");
and void HandleUAActionBlock(UAActionArguments args, UAActionCompletionHandler completion)         {             completion.Invoke(UAActionResult.EmptyResult());         }

@samshiffman321 We are looking into it

@samshiffman321 We discovered the problem. It is a binding issue in ApiDefinition.cs. We will release a new version with the fix on Monday.

@samshiffman321 We have released version 4.6.1 to address the run-time exception. Let us know if you have any further issues.


Change batched NMS threshold for-loop version

According to the benchmark link https://github.com/pytorch/vision/issues/1311#issuecomment-781329339, for GPU the threshold should be higher (which is why detectron2 used 40k).
This PR changes the threshold to be device dependent.

LVIS has 1200 classes. So in the last NMS of a faster r-cnn trained on LVIS it's common to have 10k-30k boxes.

IIRC we added thresholding in detectron2 because batched_nms OOM for a specific model with too many boxes. Then we did some benchmarks and determined 40k threshold for GPU. This is similar to the conclusion in #1311.
D17157130 has some discussions at the time.


Added checks to identify and report any obsolete fields in openedx.yaml

Relevant JIRA issue here

Note that you can run the checks locally on this or another repo to test the output, like pytest --repo-health --repo-health-path=. --repo-path=../edx-platform --noconftest.  Then look at the generated repo_health.yaml file.