[SPARK-28213][SQL][followup] code cleanup and bug fix for columnar execution framework

What changes were proposed in this pull request?
I did a post-hoc review of https://github.com/apache/spark/pull/25008 , and would like to propose some cleanups/fixes/improvements:

Do not track the scanTime metrics in ColumnarToRowExec. This metrics is specific to file scan, and doesn't make sense for a general batch-to-row operator.
Because of 2, we need to track scanTime when building RDDs in the file scan node.
use RDD#mapPartitionsInternal instead of flatMap in several places, as mapPartitionsInternal is created for Spark SQL and we use it in almost all the SQL operators.
Add limitNotReachedCond in ColumnarToRowExec. This was in the ColumnarBatchScan before and is critical for performance.
Clear the relationship between codegen stage and columnar stage. The whole-stage-codegen framework is completely row-based, so these 2 kinds of stages can NEVER overlap. When they are adjacent, it's either a RowToColumnarExec above WholeStageExec, or a ColumnarToRowExec above the InputAdapter.
Reuse the ColumnarBatch in RowToColumnarExec. We don't need to create a new one every time, just need to reset it.
Do not skip testing full scan node in LogicalPlanTagInSparkPlanSuite
Add back the removed tests in WholeStageCodegenSuite.

How was this patch tested?
existing tests

Test build #108228 has started for PR 25264 at commit 3afa85b.

cc @revans2  @tgravescs @hvanhovell @HyukjinKwon @dongjoon-hyun @viirya @gatorsmile

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13329/
Test PASSed.

Test build #108228 has finished for PR 25264 at commit 3afa85b.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class ColumnarToRowExec(child: SparkPlan) extends UnaryExecNode with CodegenSupport
case class InputAdapter(child: SparkPlan) extends UnaryExecNode with InputRDDCodegen

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108228/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13343/
Test PASSed.

Test build #108242 has started for PR 25264 at commit 816f079.

cc @rednaxelafx Please post your comment about the changes. Thanks!

Test build #108242 has finished for PR 25264 at commit 816f079.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108242/
Test FAILed.

Test build #108290 has started for PR 25264 at commit ec2a2b8.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13389/
Test PASSed.

After more thoughts, I think we should still insert InputAdapter under ColumnarToRowExec. But we can simplify the whole-stage-codegen planning logic a bit, because codegen stage can never overlap with a columnar stage, as whole-stage-codegen is completely row-based. When these 2 stages are adjacent, it's either a RowToColumnarExec above WholeStageExec, or a ColumnarToRowExec above the InputAdapter.

Test build #108290 has finished for PR 25264 at commit ec2a2b8.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108290/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13466/
Test PASSed.

Test build #108371 has started for PR 25264 at commit 6bcbcc6.

Test build #108371 has finished for PR 25264 at commit 6bcbcc6.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108371/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13469/
Test PASSed.

Test build #108375 has started for PR 25264 at commit 6bcbcc6.

Test build #108375 has finished for PR 25264 at commit 6bcbcc6.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108375/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13475/
Test PASSed.

Test build #108380 has started for PR 25264 at commit 6bcbcc6.

Test build #108380 has finished for PR 25264 at commit 6bcbcc6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108380/
Test PASSed.

@cloud-fan  are you going to update InputAdapter supportsColumnar and doExecuteColumnar?

@tgravescs no I'm not going to. It's correct that InputAdapter can support columnar execution if its child supports, by calling child.doExecuteColumnar.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13618/
Test PASSed.

Test build #108524 has started for PR 25264 at commit af177aa.

Test build #108524 has finished for PR 25264 at commit af177aa.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108524/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13637/
Test PASSed.

Test build #108543 has started for PR 25264 at commit 308fc11.

Test build #108543 has finished for PR 25264 at commit 308fc11.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108543/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13650/
Test PASSed.

Test build #108559 has started for PR 25264 at commit 308fc11.

Test build #108559 has finished for PR 25264 at commit 308fc11.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108559/
Test PASSed.

thanks for the review, merging to master!


[plugins|tiling] Safari window when terminated isn't removed for window tree

I'm able to only reproduce this reliably with Safari, not sure if it's specific to that only.

be in a bsp desktop
start Safari, window should take all space available (single node)
quit Safari
launch Safari again, window takes only half of the desktop space

This doesnt seem to be specific to Safari.
I can reproduce for a lot of applications by doing the following:

be in a bsp desktop
start Safari, Notes (applications that behave similar)
quit application WITHOUT closing the window
launch any application or window


GEODE-9211: Replace 'GemFire' by 'Geode' in LocatorLauncher & ServerL…

…auncher
LocatorLauncher and ServerLauncher classes have a lot of references to GemFire in Javadocs. They should be substituted by Geode.

Besides javadoc changes, there are quite a few external help message related changes. I've request @davebarnes97 to take a quick look too.

this looks like a straightforward search-and-replace.  The product is called Geode, after all.

Review by code owners still pending

thanks @echobravopapa !


Indexing error when mixing SDP and SOCP

The following JuMP code produces an internal indexing error:
using JuMP

m = Model()

@defVar(m, x[1:1,1:1], SDP)
@defVar(m, y)
@defVar(m, z >= 0)
@defVar(m, t >= 0)
@addConstraint(m, (y-1)^2 <= z^2)
@addConstraint(m, (x[1,1]-1)^2 <= t^2)

solve(m)

ERROR: Mosek.MosekError(1204,"The index value 7 occurring in argument '(asub+aptrb[1])[0]' is too large.")
 in putarowslice at /Users/huchette/.julia/v0.4/Mosek/src/msk_functions.jl:2644
 in putarowslice at /Users/huchette/.julia/v0.4/Mosek/src/msk_functions.jl:2622
 in addquadconstr! at /Users/huchette/.julia/v0.4/Mosek/src/MosekLowLevelQCQO.jl:148
 in addQuadratics at /Users/huchette/.julia/v0.4/JuMP/src/solvers.jl:87
 in solveSDP at /Users/huchette/.julia/v0.4/JuMP/src/solvers.jl:622
 in solve at /Users/huchette/.julia/v0.4/JuMP/src/solvers.jl:27

MPB calls:
using MathProgBase, Mosek
model = MathProgBase.model(MosekSolver())
MathProgBase.loadconicproblem!(model,
    [0.0,0.0,0.0,0.0],
    sparse(Int[], Int[],Float64[], 0, 4),
    Float64[],Any[],Any[(:SDP,1:1),(:NonNeg,[3,4]),(:Free,[2])])
MathProgBase.addquadconstr!(model,
    Int32[2,2],
    [-1.0,-1.0],
    Int32[2,3],
    Int32[2,3],
    [1.0,-1.0],
    '<',
    -1.0)
MathProgBase.addquadconstr!(model,
    Int32[1,1],
    [-1.0,-1.0],
    Int32[1,4],
    Int32[1,4],
    [1.0,-1.0],
    '<',
    -1.0)

The error is in this second call to addquadconstr!.

This works to reproduce something similar:
using MathProgBase, Mosek
model = MathProgBase.model(MosekSolver())
MathProgBase.loadconicproblem!(model,
    [0.0,0.0,0.0,0.0],
    sparse(Int[], Int[],Float64[], 0, 4),
    Float64[],Any[],Any[(:SDP,1:1),(:NonNeg,[3,4]),(:Free,[2])])
MathProgBase.addquadconstr!(model,
    Int32[2,2],
    [-1.0,-1.0],
    Int32[2,3],
    Int32[2,3],
    [1.0,-1.0],
    '<',
    -1.0)
MathProgBase.addquadconstr!(model,
    Int32[1,1],
    [-1.0,-1.0],
    Int32[1,4],
    Int32[1,4],
    [1.0,-1.0],
    '<',
    -1.0)

ERROR: Mosek.MosekError(1204,"The index value 5 occurring in argument '(asub+aptrb[1])[0]' is too large.")
 in putarowslice at /Users/huchette/.julia/v0.4/Mosek/src/msk_functions.jl:2644
 in putarowslice at /Users/huchette/.julia/v0.4/Mosek/src/msk_functions.jl:2622
 in addquadconstr! at /Users/huchette/.julia/v0.4/Mosek/src/MosekLowLevelQCQO.jl:148

I don't think it was ever intended that you could mix loadconicproblem! and addquadconstr!.

I think we are out somewhere in the "in theory it should work but I'd appreciate if you didn't test it" territory. I'll take a look at it.

In theory it should work, but conic solvers which support SDP and SOCP
definitely don't need to implement the quadratic interface as well. I.e.,
this wont work for SCS.
On Jun 11, 2015 9:14 AM, "Ulf Worsøe"<EMAIL_ADDRESS>wrote:

I think we are out somewhere in the "in theory it should work but I'd
appreciate if you didn't test it" territory. I'll take a look at it.
—
Reply to this email directly or view it on GitHub
https://github.com/JuliaOpt/Mosek.jl/issues/49#issuecomment-111020374.

If we don't want to mix that's fine, though there should be an error saying so I guess. I just didn't want to get into the game of doing the transformation (new variables) from quadratic to SOC in JuMP.

There's no new variables needed to convert to conic form, just some rows of
the constraint matrix which belong to SOC.
On Jun 11, 2015 5:22 PM, "Joey Huchette"<EMAIL_ADDRESS>wrote:

If we don't want to mix that's fine, though there should be an error
saying so I guess. I just didn't want to get into the game of doing the
transformation (new variables) from quadratic to SOC in JuMP.
—
Reply to this email directly or view it on GitHub
https://github.com/JuliaOpt/Mosek.jl/issues/49#issuecomment-111171249.

Moses adds new variables internally, but yes you are right if you have the expression as Σ aff^2 <= t^2.
If you have everything in terms form, not sure how best to convert it to this form. Should probably just hold off for the norm stuff.

Wait,
@addConstraint(m, (y-1)^2 <= z^2)
@addConstraint(m, (x[1,1]-1)^2 <= t^2)

aren't even in standard SOCP-via-quadratic form. What do you expect to happen? When you pass this to Mosek, it goes into quadratic mode, not conic mode, afaik.

This is culled from an example from about a year ago that used to work fine (with the old JuMP/Mosek interface). Not sure if it was going through the conic mode or not.

I think the SDP code in JuMP should throw an error when there's a quadratic constraint that's not in standard SOCP form. Manually doing the extra variables is annoying, but we'll hopefully have a better solution soon.

@joehuchette, okay to close this?


test run_examples4.sh fails with parallel build with netcdf-c-4.7.2 and HDF5-1.10.5

I am trying for the first time to build netcdf-c-4.7.2 with hdf5-1.10.5 with parallel I/O.
I am seeing this error:
make[4]: Entering directory '/home/ed/Downloads/netcdf-c-4.7.2/examples/C'
PASS: format
PASS: sfc_pres_temp_more
PASS: simple
FAIL: run_examples4.sh
PASS: run_filter.sh
PASS: run_examples.sh

Running the bash script I see:
ed@mikado:~/Downloads/netcdf-c-4.7.2/examples/C$ bash -h run_examples4.sh
*** Running examples for netCDF-4.
*** running simple_nc4 examples...
/home/ed/Downloads/netcdf-c-4.7.2/examples/C/.libs/simple_nc4_wr: symbol lookup error: /home/ed/Downloads/netcdf-c-4.7.2/liblib/.libs/libnetcdf.so.15: undefined symbol: H5Pset_all_coll_metadata_ops

This does not happen with hdf5-1.10.4.

Looking at this now more closely, but this hasn't cropped up in our local testing.  In the interest of duplicating the environment as closely as possible, are you using mpich for parallel, and make check -j?

Running make check with hdf5-1.10.5 with parallel I/O I see:
make  check-TESTS
make[1]: Entering directory '/home/tester/netcdf-c/examples/C'
make[2]: Entering directory '/home/tester/netcdf-c/examples/C'
PASS: run_examples.sh
PASS: format
PASS: sfc_pres_temp_more
PASS: simple
PASS: run_examples4.sh
PASS: run_filter.sh
PASS: run_par_test.sh

Running the script directly, I see:
tester@29c434c8abeb:~/netcdf-c/examples/C$ ./run_examples4.sh
*** Running examples for netCDF-4.
*** running simple_nc4 examples...
*** SUCCESS writing example file simple_nc4.nc!
*** SUCCESS reading example file simple_nc4.nc!
*** running simple_xy_nc4 examples...
*** SUCCESS writing example file simple_xy_nc4.nc!
*** SUCCESS reading example file simple_xy_nc4.nc!
*** Examples successful!
tester@29c434c8abeb:~/netcdf-c/examples/C$

Investigating the libnetcdf and libhdf5 libraries I see:
tester@29c434c8abeb:~/netcdf-c/liblib/.libs$ nm libnetcdf.so.15 | grep all_coll_metadata
                 U H5Pset_all_coll_metadata_ops

tester@29c434c8abeb:~/netcdf-c/liblib/.libs$ nm /usr/lib/libhdf5.so | grep H5Pset_all_coll_metadata
0000000000204db1 T H5Pset_all_coll_metadata_ops
tester@29c434c8abeb:~/netcdf-c/liblib/.libs$

OK, it went away when I used make check instead of make -j check. So looks like a parallel build issue...

I ran make check -j as well and am not seeing it, but isn't that the way with race conditions. I'll keep poking at it here as well.

OK, maybe just my dumb mistake. Maybe I should have run make clean first!


Value not changed

If I use storage.current?.set('somekey', 'value') and to get the value storage.current?.getString('somekey') but I did not receive new value. I receive new value if I reload my app. How to solved this? Use Hook is work, but otherside I want to use like asyncstorage style for my helper function.

I don't understand the last sentence.
Share the full code please


Add ´debug´ library

Use debug.js to make possible debug the library when executing

As is a very simple library we don't need a debug, just return errors with enough information...


Default icon for Python's init.py shouldn't be Django icon

Hello! First of all, thanks for this plugin! I'm using it in all of my Jetbrains IDEs.
I've created a new basic Python project and I have realised that default icon for __init__.py is Django icon. But it shouldn't be. Because each package of Python should have this file, it's not specific to Django. I think it should be a normal Python file icon.
In case it helps, I'm using PyCharm 2020.3.1 and Atom Material Icon 32.0.

you're right. what about the same icon as index.js ?

This one, right? Yes, I think it would be good.

ok thanks


New linter: DisableLinterReason

Fixes #514. DisableLinterReason is explained over at #514 as well.
As for the implementation, a few notes:

I chose to disable it by default, since it's not exactly standard, or obvious.
I copied the COMMAND_REGEX from control_comment_processor.rb. There's probably a better way, but I dunno what y'all would prefer. Make COMMAND_REGEX a public constant in control_comment_processor.rb? Extract it out to constants.rb? utils.rb?

Thanks for the pull request!
Merged in 3f459fe.


Financing

Hi :wave:,
I'm Romuald from the Lsos, an organization that develops financial solutions for open source projects, and we are currently doing outreach to projects we like.
One of our solutions is the Lsos Commons which I believe could fit; is that something React Tooltip would be interested in?
If not I'm sorry for having opened this ticket and I'll close it :).

We developed a new solution: the Lsos Donation Fund. Unlike the Lsos Commons, the Lsos Donation Fund doesn't alter your license and everything stays free; the donation fund is about collecting donations on your behalf by using a "donation-reminder".
We estimate the donation-reminder to substantially increase donations. Sublime Text, for example, achieves impressive results using a similar technique.
We are just starting (we are finishing up the implementation of the donation-reminder) and we are looking for a handful of early adopters to try out the donation-reminder.
Would that be something you'd be up to? The only thing you have to do is to add our @lsos/donation-fund npm module to your dependencies which implements the donation-reminder. We take care of everything but we'll let you know exactly about our plans and what the npm module does. You are more than welcome to object to anything and give feedback.
For example, we plan to show the donation-reminder only to large companies and make it removable. But if you want to further increase donations we can change things.
While in the long term the goal is to distribute company donations among all open source projects used by the company, at the beginning we expect that most donations will go to our early adopters.
We care a lot about transparency; each company will see to what open source projects its donations goes to, and each open source project will see from what companies its donations came from.
Let me know if you are interested, we are super eager to give this experiment a shot!

Hi @brillout, thank you so much, and sorry for the delay!
We don't have interest at the moment


Update documentation to indicate preview status

The README notes this is in active development and users should wait to use this, however we've now released a provider (Command) using this SDK and expect to support it and encourage use.
This project should likely be considered in preview status, as pre-1.0, but with intent to GA. Provider implementations are needed and should be encouraged.

Not sure what concretely this is tracking - given that the README does note the status. I think this is okay to close - and to focus on plan for GA.


Impact of channel noise

Hello, how did you add noise? Is it directly added to a channel on the entire dataset?

In each batch, we first randomly select one channel and then add noise to it.

Thank you for your reply. Furthermore, in the ablation experiment, did you notice that channel independent MLP performed well on the ETT dataset?

Thank you for highlighting this detail. In some cases, when the correlation between different channels is low, ignoring it could potentially lead to better performance.

Thank you for your reply. Your work has inspired me a lot.

I’m glad to hear that our work has inspired you. Please feel free to share any further thoughts or questions!


Add remove button at node header

Fixes #2
As bug inside Godot engine may take for a while to be fixed, here is a an elegant solution at my view

Looks good!


Update build.ps1 to use SHA1 instead of MD5

This change is necessary for use on FIPS compliant servers

@kakrofoon thank you for your interest in helping with this project.  However, I am going to go ahead and close this PR.  Let me explain why...
This is the example repository.  If we were to accept any modifications to the bootstrapper scripts, they would happen over here in the resources repository:
https://github.com/cake-build/resources
However, I also don't think that this change is required.  The hash that is being used here is merely to assert whether something has been changed.  It is not intended to protect any private information.  In fact, the packages.config file is likely stored in plain text in the repository, therefore, it doesn't matter what hash is used, as the contents of the file are stored in plain text.

I'll happily resubmit this to another repository, but the change is at
least somewhat necessary,
If a server has been designated as FIPS compliant, these hashes do not run.
Full stop.
For this particular item, it's not a big deal - it just refreshes the file
no matter what.
For WYAM, this particular issue broke their script.
I work for NASA; all of our servers are required to use FIPS compliant
hashes and encryption.
Microsoft is trending that way, so it'll be a good idea to move in that
direction before we have to.
On Tue, Feb 27, 2018 at 1:36 PM, Gary Ewan Park<EMAIL_ADDRESS>wrote:

@kakrofoon https://github.com/kakrofoon thank you for your interest in
helping with this project. However, I am going to go ahead and close this
PR. Let me explain why...
This is the example repository. If we were to accept any modifications to
the bootstrapper scripts, they would happen over here in the resources
repository:
https://github.com/cake-build/resources
However, I also don't think that this change is required. The hash that is
being used here is merely to assert whether something has been changed. It
is not intended to protect any private information. In fact, the
packages.config file is likely stored in plain text in the repository,
therefore, it doesn't matter what hash is used, as the contents of the file
are stored in plain text.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cake-build/example/pull/38#issuecomment-368999407,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALE2sefAeGsHDPq9hDeVvMbe9OU_tbzaks5tZFkogaJpZM4SVYhh
.

@kakrofoon https://github.com/cake-build/resources would be the correct place, just a FYI we're refactoring the bootstrappers and there might be zero hashes in the new ones. Read more about that at https://github.com/cake-build/resources/issues/53

@kakrofoon is there anything preventing you from modifying the bootstrapper locally for these machines?  We recommend that users modify the bootstrapper to fit with their own environments when required.
NOTE: We were very happy to here about Cake being used at NASA 😄

We do, this change would just be to keep people from having to do it
themselves or research the issue.
On Wed, Feb 28, 2018 at 2:36 AM, Gary Ewan Park<EMAIL_ADDRESS>wrote:

@kakrofoon https://github.com/kakrofoon is there anything preventing
you from modifying the bootstrapper locally for these machines? We
recommend that users modify the bootstrapper to fit with their own
environments when required.
NOTE: We were very happy to here about Cake being used at NASA 😄
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cake-build/example/pull/38#issuecomment-369160421,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALE2sZaSEjar9g5fIQ4nAtZZuMUHHfJuks5tZQ_9gaJpZM4SVYhh
.

@kakrofoon makes sense.  Once we review the current state of the bootstrappers, if we still have the requirement for the hashing that we are doing, we will definitely change away from using MD5.
Thanks for reaching out!


500 error on http://demo.wellcommerce.org/order/address

customer enter the address and submit,return 500 error

Fixed


Inconsistent behavior of Windows authentication between IIS integration and WebListener

From @leastprivilege on December 21, 2016 14:17
Both add Negotiate and NTLM.
WebListener gives the schemes display names of Windows:Negotiate and Windows:NTLM.
With IIS integration the display names are empty.
Since display name is often used in generic code to populate the login page - it would be nice to always have a display name - or never. But be consistent ;)
Copied from original issue: aspnet/Security#1076

The descriptions were removed from IISIntegration, so we should also remove them from WebListener.


Logger for Android GCM

At the moment the send method return only false or true which makes impossible to debug eventual issues.
I have added a basic logger for Android GCM errors.

Thanks for this! It would be useful if this was also applied to the other platforms - would you be happy to add in there as well?

I am closing this issue to create a new one with the branch "logger" that I created instead of "logger-android".


npm start error

Hi, been facing this issue from yesterday and havent found the solution. so here's the error I got after typing npm install
module.js:339
throw err;
^
Error: Cannot find module 'depd'
at Function.Module._resolveFilename (module.js:337:15)
at Function.Module._load (module.js:287:25)
at Module.require (module.js:366:17)
at require (module.js:385:17)
at Object. (C:\xampp\htdocs\laravelOktober\node_modules\express\lib\express.js:5:17)
at Module._compile (module.js:435:26)
at Object.Module._extensions..js (module.js:442:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:311:12)
at Module.require (module.js:366:17)
[nodemon] app crashed - waiting for file changes before starting...

Not sure what's wrong. Just did a clean install on OS X, no problems. Still experiencing the issue?

well unfortunately i'm using Windows 10 and some people had been solved by that kind of way but that's not solving mine. Which node_modules should I delete? node_modules in nodejs folder or node_modules inside npm folder?

In your project root there is node_modules with other directories (app, config, database, vendor, resources). That node_modules should be deleted.
That helps, if smth went wrong during npm install because then you can do fresh npm install again.

okay then i was wrongly delete the folder. it works now. thanks allantatter :)

No problem, glad I could help :) The problem wasn't because of this package then. From time to time, smth can go wrong with npm install.

ok buddy :D well finally i can try react in laravel

allan, how do I use react function in view and controller? been trying the whole night but couldnt find the solution on how to use it.

If you followed the readme about copying exaple resources from the package's directory (https://github.com/allantatter/laravel-react#setup-server-rendering-with-nodejs-application) then you should be able to put the following inside routes.php and should work when you visit the homepage.
<?php

Route::get('/', function () {
    return React::component('Name', ['name' => 'Allan']);
});

If it works, then you can also have it in the controller and return it the same way as in routes.php and in a blade view like {!! React::component('Name', ['name' => 'Allan']) !!}.
Was this the answer to your question?

yeah that answers my question. i did copy to the resources folder and copy this following code
"scripts": {
"start": "cd resources/scripts && nodemon --harmony server.js",
"test": "echo "Error: no test specified" && exit 1"
},
"dependencies": {
"dotenv": "^1.1.0",
"envify": "^3.4.0",
"express": "^3.5.1",
"node-jsx": "^0.12.4",
"react": "^0.13.1",
"react-router": "^0.13.2"
}
to my package.json and put them right after devDependencies. is that correct?

okay it works now. maybe i was wrongly put the resources folder.

Ok, great :)
My package.json looks like this:
{
  "private": true,
  "scripts": {
    "start": "cd resources/scripts && nodemon --harmony server.js",
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "devDependencies": {
    "gulp": "^3.8.8"
  },
  "dependencies": {
    "laravel-elixir": "^3.0.0",
    "bootstrap-sass": "^3.0.0",
    "dotenv": "^1.1.0",
    "envify": "^3.4.0",
    "express": "^3.5.1",
    "node-jsx": "^0.12.4",
    "react": "^0.13.1",
    "react-router": "^0.13.2"
  }
}


Cannot compile from assembly

When compiling https://musl.libc.org, I get the following:
/usr/local/bin/lacc -std=c99 -nostdinc -Wa,--noexecstack -D_XOPEN_SOURCE=700 -I./arch/x86_64 -I./arch/generic -Iobj/src/internal -I./src/include -I./src/internal -Iobj/include -I./include  -O2 -pipe -Wno-pointer-to-int-cast -Werror=implicit-function-declaration -Werror=implicit-int -Werror=pointer-sign -Werror=pointer-arith -Werror=int-conversion -Werror=incompatible-pointer-types -Werror=discarded-qualifiers -Werror=discarded-array-qualifiers -Waddress -Warray-bounds -Wchar-subscripts -Wduplicate-decl-specifier -Winit-self -Wreturn-type -Wsequence-point -Wstrict-aliasing -Wunused-function -Wunused-label -Wunused-variable   -DCRT -c -o obj/crt/x86_64/crti.o crt/x86_64/crti.s
/usr/local/bin/lacc -std=c99 -nostdinc -Wa,--noexecstack -D_XOPEN_SOURCE=700 -I./arch/x86_64 -I./arch/generic -Iobj/src/internal -I./src/include -I./src/internal -Iobj/include -I./include  -O2 -pipe -Wno-pointer-to-int-cast -Werror=implicit-function-declaration -Werror=implicit-int -Werror=pointer-sign -Werror=pointer-arith -Werror=int-conversion -Werror=incompatible-pointer-types -Werror=discarded-qualifiers -Werror=discarded-array-qualifiers -Waddress -Warray-bounds -Wchar-subscripts -Wduplicate-decl-specifier -Winit-self -Wreturn-type -Wsequence-point -Wstrict-aliasing -Wunused-function -Wunused-label -Wunused-variable   -DCRT -c -o obj/crt/x86_64/crtn.o crt/x86_64/crtn.s
Unrecognized input file crt/x86_64/crti.s.
Unrecognized input file crt/x86_64/crtn.s.

I tried to compile a simple hello world from C to to assembly and then from assembly to a Linux binary, lacc -S main.c -o main.s, lacc main.s -o main, but it shows this on the second command:
file format not recognized; treating as linker script

I'm not sure if I should report it here or at musl
If you could implement compiling from assembly, that would be appreciated, thanks

Although lacc can understand some inline assembly, it is not a complete assembler, and compiling .s input files is not supported. You should rather use an actual assembler to compile those files.

usually the compiler driver automatically invokes the assembler when it detects an assembly file being passed to it. just like it calls the linker when the input is object files.

Does lacc have it's own linker or does it use the system one? I'm working on a distro which uses lacc and musl, lacc is the first thing that is compiled and it can link binaries somehow.

There is no linker, only a very crude implementation of a driver invoking the system linker (see src/backend/linker.c).
I guess it is reasonable to assume that lacc would also know how to invoke the assembler, so I may implement something like that. Otherwise what I would prefer was to actually be able to assemble, so perhaps some time in the future it will work. I will keep this bug open as a reminder :=)

Is the system linker part of the kernel or part of something else?


Closing right click menu with esc on request/send/cancel money request messages adds blue border around the message

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app
Open any report
On any request/send/cancel money request message, right click to open mark as unread and reaction popup
Click on esc to close the popup and observe that blue border is added around the message
Try step 3 and 4 on normal message and observe that it does not add blue border

Expected Result:
App shouldn't add blue border around any message on using esc to close the right click popup menu
Actual Result:
App adds blue border around request/send/cancel money request message when we use esc to close right click menu for that message
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43996225/234728407-b6fdcd66-76eb-46fb-81d5-c5780a6daa83.mp4
https://user-images.githubusercontent.com/43996225/234728417-821b9cf3-4ad0-49bf-8812-0b4ec49e15f8.mp4
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682523637828939
View all open jobs on GitHub

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Yep, I can replicate on v36:
https://user-images.githubusercontent.com/30815269/234737161-fee07fde-c1fa-4f29-b4c0-f453dd1498c6.mp4

Just awaiting C+'s response in the other issue to see if these issues are linked/similar.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Closing right click menu with esc on request/send/cancel money request messages adds blue border around the message
What is the root cause of that problem?
This is dupe with so many issue posts dating to at least 2022 from what I can see and they keep getting reported over and over when it's one issue but people reporting each issue are unaware of that so I will propose a solution for the entire issue.
Let's start by clarifying that the issue is happening whenever a Pressable element is right clicked then the esc key is pressed, for most elements that will require a double press of esc to show the outline, the point is that the browser will focus on the element and when it does, it will show the outline as I will demonstrate in the below screen recording:
https://user-images.githubusercontent.com/74202751/234929124-9334baf5-464f-4a86-947b-63eae7189756.mov
Please keep in mind that if you want to replicate the issue for elements outside of the currently open report, you must double press esc to get the outline. again the point is that the browser should focus the element.
Now for the root cause for these issues, it's because for some reason we are applying box-shadow color on focus in the web's index.html:
https://github.com/Expensify/App/blob/41eec3c513ea0cb1c433091692ea289e588040e0/web/index.html#L48-L51
What changes do you think we should make in order to solve the problem?
We can set the focus behaviour to none for the box-shadow
style={[
    :focus-visible {
        outline: 0;
        box-shadow: none;
    }

Result
https://user-images.githubusercontent.com/74202751/234931100-411591d4-399a-4415-a2c6-4fdd12c57b6a.mov

@jliexpensify This seems related to #17419 , issue is same problem occurring at different places!

@AmjedNazzal We need to outline when we intentionally focus on, changing there will break every where!

@jliexpensify Let's add hold for now!

@Santhosh-Sellavel - added HOLD, let me know when it should be taken off hold and if you want to also be assigned this one.

@jliexpensify Huh... This is 4 days overdue. Who can take care of this?

This is on Hold

So far pretty much everyone in this thread agreed there's nothing "wrong" here so let's do nothing 👍


prevent editor data update when data is unchanged

The JSON editor is both responding to changes when context.data is updated, and updating context.data when changes are detected in the editor.  This creates circular logic where the editor tries to set context.data to the same value it just received.

editor detects change in context.data, sets editor value
editor picks up this change as an edit, sets context.data
editor detects change in context.data but knows it was initiated by the editor so it ignores it.

Once data is loaded from a URL parameter or file, the same sequence repeats.
This PR interrupts #2 above and will only set context.data if the current value in the text editor is different (meaning the user has edited the geojson)
The bigger reason to fix this inefficiency is because each time context.data is updated it dispatches a change event, which is picked up by the map and causes setData() on the data source AND removes and re-renders all the markers.  The latter can be costly and cause a visual "blip", and should only be called when there is actually new data to render.

This is the first use of lodash directly... I recall needing it but doing a JSON.stringify() comparison last week, so maybe we should clean that up.


ggplot graph window hangs on macOS Sierra

Just installed latest version through pip3 (python 3.5.2) - ggplot 0.11.5
type in the example code:
from ggplot import *
p = ggplot(aes(x='date', y='beef'), data=meat)
p
p + geom_point()

At this point, graphic window opens, but it has no content, and graphic window as well as ipython console hangs ...

I'm experiencing the same problem as described above. I get an empty plot. I'm running this with ipython (2.7) and get the following error:
"AttributeError: 'DataFrame' object has no attribute 'select_dtypes'"


Consolidate input and output handling

Consolidate input and output handling.

[ ] Have common input selection for scripts with similar IO profiles:

[ ] Accepts CSV from STDIN or as file argument

[ ] csv-slice
[ ] csv-filter
[ ] csv-cut

[ ] Accepts a list of CSVs as file arguments or a piped list of files

[ ] css-cat

[ ] Question: Instead of as a list of CSVs as it does now, should csv-cat treat input from STDIN as a CSV?

[ ] Have all scripts use a common -o --output FILENAME method for selecting out; default should be STDOUT

csv-cat: The unix cat utility reads input from standard in as a file. The correct approach may be to do the same here for consistency. However, csv-cat also does some things cat does not: sort and uniqueness operations. Should those behaviors be moved to separate programs?


Document that TestResultsPublisher.exe is the underlying workhorse and the hosts it needs access to.

There are a large list of hosts one must allow for all functionality of a TFS build agent to work.
As noted here for publishing test results you only seem to need two of them.
For the sake of easing troubleshooting please note that TestResultsPublisher.exe is called by this task and that the agent it runs on needs access to https://vstmrblob.vsassets.io and https://.vstmr.visualstudio.com specifically.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fdb3a1b2-9878-405f-bc40-2fb7853cb423
Version Independent ID: fdb3a1b2-9878-405f-bc40-2fb7853cb423
Content: PublishTestResults@2 - Publish Test Results v2 task
Content Source: task-reference/publish-test-results-v2.md
Product: devops
Technology: devops-cicd-tasks
GitHub Login: @steved0x
Microsoft Alias: sdanie

Thank you for your feedback. We are migrating this issue to our new documentation feedback system, and closing this issue.
As we phase out GitHub issues for this repository, we encourage you to propose changes using public PRs or submit feedback through our updated control at the top of the page. For more information on our feedback systems, see https://aka.ms/contentuserfeedback.


Blazorise extension?

Hi @smfields, I liked what you did with the LottieAnimation for Blazorise, and so I wanted to see the guy behind. That's how I found out about this BlazorSplit component. BlazorSplit looks really good.
So I wanted to ask if you would be willing to make it part of Blazorise extensions. I think it would a great addon :)

@stsrki Yea I'd definitely be willing to do that. I'll open up an issue on the Blazorise repo since I've got a couple questions about the implementation, and we can start the discussion there.

That's great to hear. Thank you ☺


Security problem on compiled version

Hi,
I have compiled everything with no errors and tested the demo in source\demos\99_Minimal.
If I use debug.html all is ok; when i use index.html i get the error
Uncaught Error: SECURITY_ERR: DOM Exception 18
on Chrome 14.0.835.186
and
Security error
on Firefox 8.0
Thanks,
Vito

security issues (related to CORS) are now fixed in latest WebSDK / WebViewer.


support open with openflag?

how to support open with openflag

in conversions.go   case fusekernel.OpOpen handle openflags? type fuseops.OpenFileOp add openflags

close issues

Is this issue fixed? or is there a workaround?


__init_hid_device : Exception: No devices found

Hello there. The script cannot list USB devices. What can I try?

Hi,
Try lsusb and look for
Bus 003 Device 003: ID 2516:0051 Cooler Master Co., Ltd.
Verify that usb cable is properly connected to your cooler and that rgb header is not

Thanks. I just learned that the USB cable is needed and that I don't have it installed. They didn't plug it when I bought the PC and it's not in the boxes. I'll try again when I get the cable.


Code review request: CUDPP 1.1.1 branch

Purpose of code changes on this branch:

Review the changes I've made to the 1.1.1 branch before we release it.

When reviewing my code changes, please focus on:

Changes to scan_cta.cu, segmented_scan_cta.cu, radixsort_cta.cu,
radixsort_app.cu, cudpp_util.h, cudpp_globals.h

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 11 Mar 2010 at 5:16

Since CUDPP 1.1.1 is released, this bug can be closed.  No feedback from
anyone. :(

Original comment by<EMAIL_ADDRESS>on 13 May 2010 at 12:33

Changed state: Done


Code Crashes

Hello, I have a problem of running the code. It crashed after a couple of non-target trials presented, besides I couldn't use the keyboard to skip the instruction but the key "Enter" worked. The output showed "Experiment ended with exit code 1 [pid:11916]".

Sorry I don't have the capacity to maintain this code base any more.
If you managed to fix it, I am happy to review the fix.
However, I won't push any new changes.

Ok, thanks for your response.


Add TopBar & Settings

It should include the back button and a settings button. The settings button opens a modal popup with sliders for GUI size and background color. The values for these settings are saved to localstorage. GUI size scales the width of the sidebar GUI, with scroll overflow for excess height.

Done-ish. We'll do more thinking about this during implementation.


Fix issue where new dot views have not been added properly on refresh…

Fixes issue #177

and #78 ... @Mozharovsky is the project still alive? do you need help maintaining it?

@stefreak Yeah the project is still alive, no worries. Thanks for your contribution, good job!


Feat endpoint exceptions

Adds new exception types to make the exceptions more readable in code.
Connects to OSGP/Platform#288

All is well.


Bitnami Httpd image

Things that are left:

Generating readme using jinja scripts.
Publishing the image on RapidFort
Running functional_tests just in case

needs_ci


PcfAdminPolicy - hardcoded IAM policy without environment prefix

This causes a failure in provisioning more than 1 environment in a single AWS account -
* aws_iam_policy.PcfAdminPolicy: Error creating IAM policy PcfAdminPolicy: EntityAlreadyExists:

Closed via #11


Fix extra parameter in call to _addItem

I introduced one parameter too much in a call to _addItem from _addChoice (here: 0b3cf1a#diff-27edd04b91c69d5ee4cfac4012766ef7R2202) so the former doesn't get the custom properties and can't set them in the newly created item.
Related to issue https://github.com/jshjohnson/Choices/issues/196

Thanks :D 💯


Added support for custom joins and query as source

Added support for source outside of current DB (with some crazy REPLACE statements - could use some work). Done because we sometimes have a separate staging database instead of a Staging schema.
Added support to use a query instead of a fixed set of values so this can be used for ETL operations
Added support for a custom set of columns for joining. Useful when there are no PKs defined.

Thank you for your contribution, and sorry it's taken so long to respond. I believe that the 3 points you mentioned have now been covered by other PR's:

Added support for source outside of current DB (with some crazy REPLACE statements - could use some work).

I took a slightly different tack with this (see #47): rather than parsing a potentially unquoted string, I decided to add some validation for the @target_table parameter (by the way, I presume this is what you mean't by "source"?). This consists of some simple checks to ensure that, if a multi-part reference is specified in the param, that it is already qualified with square brackets. If it fails this validation, an error is raised by the utility.

Added support to use a query instead of a fixed set of values so this can be used for ETL operations

Support for this was added in #37: specify @include_values = 0 (new param) to have the data queried from the table directly, rather than a VALUES clause generated.

Added support for a custom set of columns for joining. Useful when there are no PKs defined.

Support for this was added in #46: specify @cols_to_join_on = "'Column1','Column2','Column3'" (new param) to provide a custom set of join columns.
It would be great if you could confirm whether the above covers the combined changes in this PR. If there's still some aspects of your PR still outstanding, feel free to respond and I'll raise issue records for them.


build: Add markdownlint

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#12  👈
#11
#10
#9
#8
#7
#6
#5
#4
#3
#2
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MikeRatcliffe and the rest of your teammates on  Graphite


Adding kruize document

Signed-off-by: Aaruni Aggarwal<EMAIL_ADDRESS>

Here is the preview after making formatting changes :
https://aaruniaggarwal.github.io/extra/kruize/
If its looking good then I will create a new PR.


Fixes for ingress

Use alias $ing instead of .Values.ingress in the ingress template.

I tried it out and it works but I'm not sure how since I don't see $ing defined anywhere. How is its value being set?

See the first line in the ingress template? I am essentially creating a shortcut alias for .Value.ingress named $ing. It’s just for readability. Does not fix my issue of using service.name in the ingress.yaml. It should be working as service.name is defined/defaults to empty string in your values.yaml.

@amorey I'm at a loss here. Even manually setting service.name using --set is still breaking.
helm install kubetail --values values.yaml --set service.name=kubetail kubetail/kubetail
    Error: INSTALLATION FAILED: template: kubetail/templates/ingress.yaml:22:31: executing "kubetail/templates/ingress.yaml" at <.Values.service.name>: nil pointer evaluating interface {}.service

My values.yaml is simply:
deployment:
  resources:
    requests:
      cpu: 250m
      memory: 128Mi
    limits:
      cpu: 1
ingress:
  enabled: true
  annotations:
    traefik.ingress.kubernetes.io/router.entrypoints: websecure
    traefik.ingress.kubernetes.io/router.tls: "true"
    traefik.ingress.kubernetes.io/router.tls.certresolver: le
  hosts:
    - host: kubetail.mydomain.com
      paths:
        - path: /
          pathType: Prefix
  tls:
    - hosts:
        - kubetail.mydomain.com

See the first line in the ingress template? I am essentially creating a shortcut alias for .Values.ingress named $ing. It’s just for readability. Does not fix my issue of using service.name in the ingress.yaml. It should be working as service.name is defined/defaults to empty string in your values.yaml.

Ahhh... I see. The first two lines were hidden in the GitHub diff so I couldn't figure out where you were defining $ing.

I submitted a PR to your fork. If that looks ok you can merge and update the PR here.


Patch apparmor for CVE-2024-31755

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] If you are adding/removing a .spec file that has multiple-versions supported, please add @microsoft/cbl-mariner-multi-package-reviewers team as reviewer (Eg. golang has 2 versions 1.18, 1.21+)
[ ] Ready to merge

Summary
Add patch for CVE-2024-31755
Change Log

Add patch file for CVE-2024-31755

Does this affect the toolchain?
NO
Associated issues

#xxxx

Links to CVEs

https://nvd.nist.gov/vuln/detail/CVE-2024-31755

Test Methodology

Pipeline build id: Buddy Build

Auto cherry-pick results:

main :white_check_mark: -> https://github.com/microsoft/azurelinux/pull/9302

Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=581117&view=results


Keyboard auto opens on script startup

Hi ,
Great script, stumbled across after moving to win 10 , disabling windows 10 shortcuts and trying to open the emoji keyboard via autohotkey
One issue I encoutnred
Script opens keyboard on start - bad if adding to windows startup -  I think there's a return missing at the end of the  autorun area
adding return on line 102, fixes this issue.
Cheers

Hi, there was indeed a missing return.
I fixed it in b982152

Hi, there was indeed a missing return.
I fixed it in b982152


Archiver fails with PostgreSQL 10 in standby mode

The archiver service fails if run on a standby node with PostgreSQL 10. The current query uses pg_current_wal_lsn() and pg_walfile_name() and we cannot call those functions in standby mode.

Problem also occurs in check_replication_slots on a standby node.


Modify /var/log/mongodb directory perms to support arbitrary user IDs

For an image to support running as an arbitrary user, directories and files that may be written to by processes in the image should be owned by the root group and be read/writable by that group.
Add the following to the Dockerfile to set the directory permissions for /var/log/mongodb to allow users in the root group to create files in that directory in the built image:
RUN chgrp 0 /var/log/mongodb &&
chmod g=u /var/log/mongodb
Currently, the directory is created with the following permissions:
$ ls -al /var/log/mongodb
total 0
drwxr-xr-x. 2 mongodb mongodb  6 Apr 30 19:15 .
drwxr-xr-x. 1 root    root    48 Apr 30 19:15 ..
$

According to https://docs.openshift.com/container-platform/3.9/creating_images/guidelines.html:
Adding the following to your Dockerfile sets the directory and file permissions to allow users in the root group to access them in the built image:
RUN chgrp -R 0 /some/directory &&
chmod -R g=u /some/directory
Because the container user is always a member of the root group, the container user can read and write these files. The root group does not have any special permissions (unlike the root user) so there are no security concerns with this arrangement.
I'm not sure I understand your comment "I would not recommend running processes in the root group since that will give much more access than something like the mongodb group would." The above docs indicate that the container user is always a member of the root group. It also states that the root group does not have any special permissions (unlike the root user). Please clarify.

They can recommend it and that is their choice, but I am not comfortable with doing so.  There are files and directories in the container that are root group owned that have greater permissions on group than that of other; this is what I mean by "more access".  It may not be special access like the root user but it is still more access than the mongodb group.
The /var/log/mongodb directory is created by the MongoDB installer; this image does not use that by default and instead logs to stdout.  See also https://github.com/docker-library/mongo/issues/35#issuecomment-95309699, https://github.com/docker-library/mongo/issues/90, and https://github.com/docker-library/mongo/issues/103#issuecomment-233438299.

Your clarification makes perfect sense. Thanks.


Provide more context in model evaluation activity

Our model evaluation scenarios assume that the participants know what the researcher prioritizes when working with cancer cell lines or drug screening.  Participants come from many sub-domains of biology, so we should add more context and explanation.

This is now working well after the May and August 2021 workshops.


[MRG] TVM function, test and readme

[MRG] Conversion of model to TVM
Does this change require updates to documentation?
Yes, this change requires an update to documentation as it provides additional functionality to ML-Model-CI

Read files in /test and hub/converter to follow our coding and organization style.

@amritaravishankar

@amritaravishankar The test environment of Github action supports import tvm currently,  you can merge the latest code to your branch to check if the test will pass

@amritaravishankar The test environment of Github action supports import tvm currently, you can merge the latest code to your branch to check if the test will pass

@amritaravishankar Now the tvm  import error has been fixed, you can go ahead now.


fix: LSDV-4853: Add warning message when user selects more choices th…

…an maxUsages
PR fulfills these requirements

[x] Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
[x] Tests for the changes have been added/updated (for bug fixes/features)
[ ] Docs have been added/updated (for bug fixes/features)
[x] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
[x] Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)
(check all that apply)

[ ] Product design
[x] Frontend

Describe the reason for change
(link to issue, supportive screenshots etc.)
What does this fix?
(if this is a bug fix)
What is the new behavior?
(if this is a breaking or feature change)
What is the current behavior?
(if this is a breaking or feature change)
What libraries were added/updated?
(list all with version changes)
Does this change affect performance?
(if so describe the impacts positive or negative)
Does this change affect security?
(if so describe the impacts positive or negative)
What alternative approaches were there?
(briefly list any if applicable)
What feature flags were used to cover this change?
(briefly list any if applicable)
Does this PR introduce a breaking change?
(check only one)

[ ] Yes, and covered entirely by feature flag(s)
[ ] Yes, and covered partially by feature flag(s)
[ ] No
[ ] Not sure (briefly explain the situation below)

What level of testing was included in the change?
(check all that apply)

[ ] e2e
[ ] integration
[ ] unit

Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

Codecov Report
Patch coverage: 60.66% and project coverage change: -2.98 :warning:

Comparison is base (8c63614) 67.94% compared to head (e7edfaf) 64.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1470      +/-   ##
==========================================
- Coverage   67.94%   64.97%   -2.98%
==========================================
  Files         397      439      +42
  Lines       26123    27405    +1282
  Branches     6984     7147     +163
==========================================
+ Hits        17749    17806      +57
- Misses       7007     9599    +2592
+ Partials     1367        0    -1367

Impacted Files
Coverage Δ

src/tags/TagBase.js
100.00% <ø> (ø)

src/tags/control/BrushLabels.js
100.00% <ø> (ø)

src/tags/control/Choice.js
91.30% <ø> (-1.74%)
:arrow_down:

src/tags/control/EllipseLabels.js
100.00% <ø> (ø)

src/tags/control/KeyPointLabels.js
72.72% <ø> (ø)

src/tags/control/Labels/Labels.js
84.00% <ø> (ø)

src/tags/control/PolygonLabels.js
100.00% <ø> (ø)

src/tags/control/RectangleLabels.js
100.00% <ø> (ø)

src/tags/control/TimeSeriesLabels.js
57.89% <ø> (ø)

src/tags/control/VideoRectangle.js
100.00% <ø> (ø)

... and 26 more

... and 237 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Laravel Collection issue?

Larastan Version: 1.0.1
--level used: 0
Pull request with failing test: uncertain what this means?

Description
When I run level 0, after fixing all other errors, the only thing i have left is:
 -- -------------------------------------------------------------------------------------------------------------
     Error
 -- -------------------------------------------------------------------------------------------------------------
     Child process error (exit code 255):

     In Collection.php line 12:

       Cannot declare class Illuminate\Support\Collection, because the name is already in use

     PHP Fatal error:  Cannot declare class Illuminate\Support\Collection, because the name is already in use in
     C:\repos\portal-main\vendor\laravel\framework\src\Illuminate\Collections\Collection.php on line 12

     Child process error (exit code 255):

     In Collection.php line 12:

       Cannot declare class Illuminate\Support\Collection, because the name is already in use

     PHP Fatal error:  Cannot declare class Illuminate\Support\Collection, because the name is already in use in
     C:\repos\portal-main\vendor\laravel\framework\src\Illuminate\Collections\Collection.php on line 12

 -- -------------------------------------------------------------------------------------------------------------

 [ERROR] Found 2 errors

Thank you for your report!
Try checking your autoloader and add the --debug flag to the command line.

Debug flag runs out in the middle of the files. I've checked the last file in the list, and the one that would follow, and neither has any references to the Collection class (only collection objects without typing). Not really sure what you mean about the autoloader - the project usually works on its own.
I ran it with xdebug and got this in the bottom of the stack trace:
PHP  29. NunoMaduro\Larastan\Types\ModelRelationsDynamicMethodReturnTypeExtension->isMethodSupported($methodReflection = class PHPStan\Reflection\ResolvedMethodReflection { private $reflection = class PHPStan\Reflection\Dummy\ChangedTypeMethodReflection { private $declaringClass = class PHPStan\Reflection\ClassReflection { ... }; private $reflection = class PHPStan\Reflection\Php\PhpMethodReflection { ... }; private $variants = [...] }; private $resolvedTemplateTypeMap = class PHPStan\Type\Generic\TemplateTypeMap { private $types = [...]; private $lowerBoundTypes = [...] }; private $variants = [0 => class PHPStan\Reflection\ResolvedFunctionVariant { ... }] }) phar://C:/repos/portal-main/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/MutatingScope.php:3332
PHP  30. PHPStan\Type\ObjectType->isSuperTypeOf($type = class PHPStan\Type\ObjectType { private $className = 'Illuminate\\Collections\\Collection'; private $subtractedType = NULL; private $classReflection = NULL; private $cachedParent = NULL; private $cachedInterfaces = NULL; private $currentAncestors = [] }) C:\repos\portal-main\vendor\nunomaduro\larastan\src\Types\ModelRelationsDynamicMethodReturnTypeExtension.php:48
PHP  31. PHPStan\Reflection\ReflectionProvider\MemoizingReflectionProvider->hasClass($className = 'Illuminate\\Collections\\Collection') phar://C:/repos/portal-main/vendor/phpstan/phpstan/phpstan.phar/src/Type/ObjectType.php:219
PHP  32. PHPStan\Reflection\ReflectionProvider\ChainReflectionProvider->hasClass($className = 'Illuminate\\Collections\\Collection') phar://C:/repos/portal-main/vendor/phpstan/phpstan/phpstan.phar/src/Reflection/ReflectionProvider/MemoizingReflectionProvider.php:31
PHP  33. PHPStan\Reflection\ReflectionProvider\ClassBlacklistReflectionProvider->hasClass($className = 'Illuminate\\Collections\\Collection') phar://C:/repos/portal-main/vendor/phpstan/phpstan/phpstan.phar/src/Reflection/ReflectionProvider/ChainReflectionProvider.php:25
PHP  34. PHPStan\Reflection\Runtime\RuntimeReflectionProvider->hasClass($className = 'Illuminate\\Collections\\Collection') phar://C:/repos/portal-main/vendor/phpstan/phpstan/phpstan.phar/src/Reflection/ReflectionProvider/ClassBlacklistReflectionProvider.php:39
PHP  35. class_exists($class = 'Illuminate\\Collections\\Collection') phar://C:/repos/portal-main/vendor/phpstan/phpstan/phpstan.phar/src/Reflection/Runtime/RuntimeReflectionProvider.php:147
PHP  36. Composer\Autoload\ClassLoader->loadClass($class = 'Illuminate\\Collections\\Collection') phar://C:/repos/portal-main/vendor/phpstan/phpstan/phpstan.phar/src/Reflection/Runtime/RuntimeReflectionProvider.php:147
PHP  37. Composer\Autoload\includeFile($file = 'C:\\repos\\portal-main\\vendor\\composer/../laravel/framework/src/Illuminate\\Collections\\Collection.php') phar://C:/repos/portal-main/vendor/phpstan/phpstan/phpstan.phar/vendor/composer/ClassLoader.php:428
PHP  38. include() phar://C:/repos/portal-main/vendor/phpstan/phpstan/phpstan.phar/vendor/composer/ClassLoader.php:571

Was able to find it - turns out, there was a PHPDoc referencing Illuminate/Collections/Collection, but it's intended to be Illuminate/Support/Collection. It was trying to verify whether the two classes are related, and instantiation was failing.

Would be beneficial if this wouldn't crash the whole thing but I have no clue how that would be done. Thanks nonetheless @szepeviktor


Extra security for bracketed past ?

Hi @jonathanslenders,
I was wondering if bracketed past was there mostly for security reasons or not.
And if so I was wondering, would it be also possible/desirable, when you past something we could/should have an overlay highlighter that mark non-ascii caracters with specific token with a different visual style.
Thus decreasing chances of pastjacking.
Idea to refine, and that of course we don't need to implement here directly.

Hi Matthias,
Bracketed paste is not really a security feature. It exists mainly for the following two reasons:

Detect which fragments are pasted and preserve the indentation of the pasted text when the input is multiline. The result is that the pasted text also won't cause any execution if it contains a newline. (Which could be considered a security feature.)
Speedup of the input parser. In the vt100 InputStream parser, there are some significant speedups which are possible because of bracketed paste. Without this, the state machine of the parser would have to process every single character. While, with, it can quickly search through the input data.

Note that there is a key binding that handles Keys.BracketedPaste. This is the binding that decides what to do with the payload. If ever desirable, we could do some other stuff in there:
https://github.com/jonathanslenders/python-prompt-toolkit/blob/master/prompt_toolkit/key_binding/bindings/basic.py#L336
If you want to highlight non-ascii characters in a certain way, that is very easy by passing a custom Lexer (which possibly wraps a Pygments lexer.) Non visible escape sequences are already displayed in a visible way. Try to do a "quoted insert" of Escape or Ctrl-x for instance.  In emacs mode: Ctrl-Q Ctrl-X, this will render the Ctrl-X character as ^X. In vi-mode: Ctrl-V Ctrl-X.


Automated Package Upgrade

:tada: This PR is included in version 2.2.318 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


refactor(cta): version aware package manager usage, closes #3382

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Docs
[ ] New Binding issue #___
[ ] Code style update
[X] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes, and the changes were approved in issue #___
[X] No

Checklist

[X] When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
[X] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
[X] I have added a convincing reason for adding this feature, if necessary

Other information

TODOs:

[ ] Actually try running this PR
[ ] Add tests back, with local cli.js or published?

will reopen against create-tauri-app repo later.


Added: windows-software-development-kit-windows 10.1.18362.1

replaced with https://github.com/appget/appget.packages/pull/4571/files


Automatic Documentation generation

We definitely need some sort of automatic generation of documentation for functionality in the code base.
Especially if we're looking to get devs involved, it's going to ease the entry point if we have documentation they can browse through.

[ ] Documentation Tool choice?
[ ] Automatic Generation of Documentation
[ ] Automatic Deploy of Documentation

Was already looking into this. I thought about just using JSDoc 3, unless someone has anything against it or a better alternative.

I started documentating shit on a branch, and for now we're looking into using documentation.js to generate the documentation pages. Syntax is the same as JSDoc, so.


Is Iron capable of determining whether a request is with or without "www"?

How can I determine whether it's "www" or "" request to my domain on  a server?
And how can I redirect from "www" to ""?

You would loot at the url value in the request input to your handler.

You can peek into the Host header. Simply match that against your www prefixed TLD and you're ready to go

Closing, this has been answered and there have been no followups. :)


kio: Information Leak when accessing https when using a malicious PAC file

The versions of kio and kdelibs in Nixpkgs are affected by this security advisory. Affected systems may leak sensitive information from HTTPS URLs. Patches are available; at least we need to patch the unstable and release-17.03 branches. It would probably be advisable to patch release-16.09 as well.
ATTN @grahamc
I will deal with this when I have a chance, but as patches are readily available you may want to take a look if you have time before I do.

I'm working on these patches, and will definitely backport to 16.09.

How does this look for kio in 16.09, 17.03, and unstable? Still researching kdelibs.
diff --git a/pkgs/development/libraries/kde-frameworks/kio/default.nix b/pkgs/development/libraries/kde-frameworks/kio/default.nix
index 7623e44..23d24b4 100644
--- a/pkgs/development/libraries/kde-frameworks/kio/default.nix
+++ b/pkgs/development/libraries/kde-frameworks/kio/default.nix
@@ -4,7 +4,7 @@
 , kdbusaddons, kdoctools, ki18n, kiconthemes, kitemviews
 , kjobwidgets, knotifications, kservice, ktextwidgets, kwallet
 , kwidgetsaddons, kwindowsystem, kxmlgui
-, qtscript, qtx11extras, solid
+, qtscript, qtx11extras, solid, fetchpatch
 }:

 kdeFramework {
@@ -17,5 +17,12 @@ kdeFramework {
     ktextwidgets kwallet kwidgetsaddons kwindowsystem kxmlgui solid qtscript
     qtx11extras
   ];
-  patches = copyPathsToStore (lib.readPathsFromFile ./. ./series);
+  patches = (copyPathsToStore (lib.readPathsFromFile ./. ./series))
+   ++ [
+     (fetchpatch {
+       name = "SanitizeURLsBeforePassingThemToFindProxyForURL.patch";
+       url = "https://cgit.kde.org/kio.git/patch/?id=f9d0cb47cf94e209f6171ac0e8d774e68156a6e4";
+       sha256 = "1s6rcp8rrlhc6rgy3b303y0qq0s8371n12r5lk9zbkw14wjvbix0";
+     })
+   ];
 }

and for kdelibs in 16.09:
diff --git a/pkgs/desktops/kde-5/applications/kdelibs/default.nix b/pkgs/desktops/kde-5/applications/kdelibs/default.nix
index c7c8c25..b165db5 100644
--- a/pkgs/desktops/kde-5/applications/kdelibs/default.nix
+++ b/pkgs/desktops/kde-5/applications/kdelibs/default.nix
@@ -3,7 +3,7 @@
   automoc4, bison, cmake, flex, libxslt, perl, pkgconfig, shared_mime_info,
   attica, attr, avahi, docbook_xml_dtd_42, docbook_xsl, giflib, ilmbase,
   libdbusmenu_qt, libjpeg, libxml2, phonon, polkit_qt4, qca2, qt4,
-  shared_desktop_ontologies, soprano, strigi, udev, xz, pcre
+  shared_desktop_ontologies, soprano, strigi, udev, xz, pcre, fetchpatch
 }:

 kdeApp {
@@ -28,6 +28,11 @@ kdeApp {
     ./0001-old-kde4-cmake-policies.patch
     ./0002-polkit-install-path.patch
     ./0003-remove_xdg_impurities.patch
+    (fetchpatch {
+      name = "SanitizeURLsBeforePassingThemToFindProxyForURL.patch";
+      url = "https://cgit.kde.org/kdelibs.git/patch/?id=1804c2fde7bf4e432c6cf5bb8cce5701c7010559";
+      sha256 = "1y9951wgx35yf24i6gjz219fhspyqri1jvbw4fybd8nwwjb6ciz1";
+    })
   ];

   # cmake does not detect path to `ilmbase`

kdelibs 17.03 / unstable:
diff --git a/pkgs/applications/kde/kdelibs/default.nix b/pkgs/applications/kde/kdelibs/default.nix
index 0292b51..e5a5566 100644
--- a/pkgs/applications/kde/kdelibs/default.nix
+++ b/pkgs/applications/kde/kdelibs/default.nix
@@ -3,7 +3,7 @@
   automoc4, bison, cmake, flex, libxslt, perl, pkgconfig, shared_mime_info,
   attica, attr, avahi, docbook_xml_dtd_42, docbook_xsl, giflib, ilmbase,
   libdbusmenu_qt, libjpeg, libxml2, phonon, polkit_qt4, qca2, qt4,
-  shared_desktop_ontologies, soprano, strigi, udev, xz, pcre
+  shared_desktop_ontologies, soprano, strigi, udev, xz, pcre, fetchpatch
 }:

 kdeApp {
@@ -28,6 +28,11 @@ kdeApp {
     ./0001-old-kde4-cmake-policies.patch
     ./0002-polkit-install-path.patch
     ./0003-remove_xdg_impurities.patch
+    (fetchpatch {
+      name = "SanitizeURLsBeforePassingThemToFindProxyForURL.patch";
+      url = "https://cgit.kde.org/kdelibs.git/patch/?id=1804c2fde7bf4e432c6cf5bb8cce5701c7010559";
+      sha256 = "1y9951wgx35yf24i6gjz219fhspyqri1jvbw4fybd8nwwjb6ciz1";
+    })
   ];

   # cmake does not detect path to `ilmbase`

If these look good, I can commit them later. I'm unable to commit right now, though, as I can't sign commits yet on my new computer.

OK I'm moving to commit them. I didn't give him much time, but we have revert for a reason :)

These are done in:
kio: 5ce0626 / 6469580 / 6469580
and kdelibs: 6469580 / 7abda54 / 17a3e97


Support iconset Dutch government

Please support icon set fo Dutch government https://www.rijkshuisstijl.nl/bouwstenen/beeld/iconen-en-pictogrammen
This is related to https://github.com/PanderMusubi/rijkshuisstijl-paletten-kleurverlopen If needed I can do translation and testing of the set.

I cannot find a way to download the icon set from the website in SVG format. Can you help get the icon set?

This is pending until I get access to the SVG files.

News about this? The link seems broken.

Handing this over to the person that wants to work on this. Access to the icons can be requested via the link above.


[bug]: account/manage handle error message

Summary
Problem
When changing the handle for an account, where the domain does not have the TXT record yet the api returns this error:
Couldn't find DNS TXT record for _did.<domain> set to <accountDid>

and it should be
Couldn't find DNS TXT record for _did.<username>.<domain> set to <accountDid>

So, this is the relevant code for this request:
https://github.com/fission-codes/fission-server/blob/25a54e5e8a114c0acdb72883c5a74985011537e8/fission-server/src/routes/account.rs#L308-L330
I think you may be misunderstanding something. E.g. I'd be issuing a request PATCH /api/v0/account/handle/matheus23.com and have a DNS TXT record at _did.matheus23.com set to did:key:<accountDID>.
There's no more username, only the handle.

so the record is on _did.<domain> not on _did.<username>.<domain> ? but the local doh is on _did.<username>.localhost
what if domain owner whats to do multiple accounts ?
on the same topic i wrote some notes on username/handle :

username and handle should be more explicit

username should just be username hugomrdias
handle should be hugomrdias.fission.codes
account info uses username  as <username>.<domain>
patch username uses  username  as <username>
patch handle uses handle as just the domain

we should describe better username, handle and domain in the context of this api

what if domain owner whats to do multiple accounts ?

Then the domain owner should/could use subdomains. I.e. work.matheus23.com and personal.matheus23.com.

I think that's better than requiring them to add an additional subdomain. What if I do want to use matheus23.com? I don't want to be forced to use fission.matheus23.com or matheus23.matheus23.com, that'd be weird.

we should describe better username, handle and domain in the context of this api

Yep. :100:% Agree. Should we just use username as e.g. matheus23, and handle as matheus23.com or matheus23.computer.name? (or .localhost if running locally. Eventually I think it'll be .computer.name when deployed).
Also - what is your opinion on having handles & usernames simultaneously. I felt like it'd make sense to always have a username, since that's what we have control over. Otherwise it's possible that domain names expire, what would a user's username be then?
That's why all of the things are somewhat weird right now. I only return the handle, if available in account info, not the username, even though in theory it still exists. But at the same time the patch handle & patch username routes are different. So it's weird.

Closing this in favor of #239

we should describe better username, handle and domain in the context of this api

Yep. 💯% Agree. Should we just use username as e.g. matheus23, and handle as matheus23.com or matheus23.computer.name? (or .localhost if running locally. Eventually I think it'll be .computer.name when deployed).
Also - what is your opinion on having handles & usernames simultaneously. I felt like it'd make sense to always have a username, since that's what we have control over. Otherwise it's possible that domain names expire, what would a user's username be then? That's why all of the things are somewhat weird right now. I only return the handle, if available in account info, not the username, even though in theory it still exists. But at the same time the patch handle & patch username routes are different. So it's weird.

Imo we should only have handle, by default and as a fallback we provide .computer.name but users can setup up their own domain. We can call this username but we should only have one human readable property.


Add Sanakoyeu 2018 gan loops

Blocked by #176 and #189. I'll review after these are merged.

I will add the tests later when the loops are ready.

@jbueltemeier If you are happy, you can merge this. I'll add tests later myself.


You do not have 'axes.backends.AxesBackend' in your settings.AUTHENTICATION_BACKENDS.

Hello guys,
I came again to django and i'm trying to implements this good package, but i'm getting this warning message:
 You do not have 'axes.backends.AxesBackend' in your settings.AUTHENTICATION_BACKENDS.
The problem is, i have that setting set up in my files:
 (backend)  joselito92@joselito-asus-rog  ~/Proyectos/Work/erasmus/backend/erasmus  ./manage.py diffsettings
ALLOWED_HOSTS = ['*']
AUTHENTICATION_BACKENDS = ['axes.backends.AxesModelBackend', 'django.contrib.auth.backends.ModelBackend']

What's happening?

@SalahAdDin your authentication backend is axes.backends.AxesModelBackend instead of axes.backends.AxesBackend. The old axes.backends.AxesModelBackend has been renamed and only a backwards compatibility class is available for it.
The documentation on Read the Docs is still pending an update to version 5.0. In the meantime you can check the installation instructions in here:
https://github.com/jazzband/django-axes/blob/5.0/docs/2_installation.rst

I think documentation is outdated.
Thank you very much.

@SalahAdDin the documentation has now been updated.
There was an issue with the Read the Docs webhooks and GitHub being out of sync.

Sorry to bring up old issues but I derived a custom class from AxesBackend and I still get this warning.
It's a bug, right @aleksihakli ? if 'axes.backends.AxesBackend' not in settings.AUTHENTICATION_BACKENDS does not check for child classes.

I'll remove the deprecation check, it's not that necessary.

@GitRon the best solution seems to be to silence the check with the SILENCED_SYSTEM_CHECKS flag.
Could you try setting the following configuration flag in your settings.py and see what it does?
SILENCED_SYSTEM_CHECKS = ['axes.W003']

I think explicitly silencing the checks is a better approach than implicitly forgetting to add the authentication backend and possibly sporting security flaws in the project.
If this is a sound solution I'll add documentation on it and describe the check warnings that are configured for Axes.

The docs now have a section about disabling system checks for Axes.

Really great! Thanks!


Update on Payment card number

Hello,
An update on Payment card number was released the 2022-12-21T11:37:01Z. Check for any new Issuer identification number edit. Link to the diff. Here is the summary:
Fixed Distinguish link

← Previous revision
Revision as of 11:37, 21 December 2022

Line 1:
Line 1:

If this Wikipedia's edit does not affect us, just ask for this issue to be close.
In case of trouble, ask for @aloisdg

This doesn't change the specs


Typedarrayelements

Work from previous pull request to add new typed array's stuff, but using 'generic' (i.e. non type-specific array) where needed (to not use macros whenever possible).
This includes:
*ArrayBuffer.isView()

TypedArray's:

keys()/values()/@@iterator
subarray()
join()
forEach()
of()
toString()

Oops, had forgotten to add indexOf() ;)

after that, looks good to go!


Emoji followed by punctiation fail

The following doesn't render Emoji as expected:
### Works
Smile: :smile:

Smile: :grin: .

### Doesn't work
Smile: :smile:.

Smile: (What? :smile:)

Smile: -:smile:

Produces:

This one should have been fixed from latest already. Are you using 0.10.5?

@xoofx Could be nice if babelmark could render the emojis :smile:

So I assume that it was already fixed

Sorry yeah it was definitely working in 0.10.6. I was on 0.10.4 before (i think) so that was not working.


Upgrade to camel-2.19.0

Vote is now open: http://camel.465427.n5.nabble.com/VOTE-Release-Apache-Camel-2-19-0-td5798264.html
Note the 2.19 tag has been recut, so it may be worth validating things against this again.

ok, thanks

On 26. Apr 2017, at 08:43, James Netherton<EMAIL_ADDRESS>wrote:
Vote is now open: http://camel.465427.n5.nabble.com/VOTE-Release-Apache-Camel-2-19-0-td5798264.html http://camel.465427.n5.nabble.com/VOTE-Release-Apache-Camel-2-19-0-td5798264.html
Note the 2.19 tag has been recut, so it may be worth validating things against this again.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/wildfly-extras/wildfly-camel/issues/1370#issuecomment-297255156, or mute the thread https://github.com/notifications/unsubscribe-auth/AAO80n0OvzcxI7-Sb98eeSfM2pN_uBZ2ks5rzueWgaJpZM4KYoVl.


pygo: Provide a default return if not inferred

This still fails infer_ops.  I'll get to that soon.  But I dont mind if this doesnt make it into v0.3.0 ; it is only replacing one problem with a different more predicable problem.

After this change, the only gofmt error for the sample on https://github.com/adsharma/py2many/issues/402 is
./cls.go:11:9: undefined: x

And now most of the go self transpilation is successful except for gofmt errors.

Looks good. Perhaps rebase on top of #396 ?

Closed via 0a043bd


Value or undefined is not the same as an optional, and should not be a required property either

type A = {
    b: string | undefined
}

is not the same as:
type A = {
    b?: string | undefined
}

The first requires undefined to be set, and can't just be left out.
Zod though both seem to infer:
type A = {
    b: string | undefined
}

to an optional when writing the schema first and then inferring a type. And when doing the other way around, writing a schema for the type, thinks it's required and only accepts the following:
type A = {
    b: string | undefined
}

const a = z.ZodScheme<A> = z.object({
    b: z.string()
})

even though it should be z.string().or(z.undefined())
But writing is it should be results in error:
Property 'b' is optional in type '{ b?: string | undefined; }' but required in type 'A'
Am I missing something?

I guess I'm not really seeing what problem you are talking about. I tested 2 situations and they both seem to be working as expected. Please help me to understand what is not working correctly.
type A = {
    b: string | undefined
}

const a: z.ZodSchema<A> = z.object( {
//    ^
// Property 'b' is optional in type '{ b?: string | undefined; }' but required in type 'A'.
    b: z.string().optional(),
} )

type inferredA = z.infer<typeof a>
// type inferredA = {
//     b: string | undefined;
// }

const foo: z.infer<z.ZodSchema<{ b?: string | undefined }>> = {} // no error
const bar: z.infer<z.ZodSchema<{ b: string | undefined }>> = {} // error
//    ^^^
// Property 'b' is missing in type '{}' but required in type '{ b: string | undefined; }'.


refactor: export types (Part 1)

Closes #5721 #5722
This is the first half of exporting released components that have typescript support. This PR exports their respective types.
What did you change?

Exports props interfaces
Renames index.js -> index.ts
Exports the types in component's index.ts file

Not sure why I'm getting a Axios error on this test

We have an issue open, https://github.com/carbon-design-system/ibm-products/issues/5782 @amal-k-joy is looking at this

It looks like there are a lot of changes included here not related to the TypeScript changes. Can you double check that changed files?

@matthewgallo I'm confused why, It's changes that main has so don't know why the difference isn't seen?

Also don't know why it's undoing the copyright headers

Going to try to rebase and see if that works


Users from onprem AD really not supported?

"Windows Virtual Desktop only supports Azure AD Domain Services users who are sourced from Azure Active Directory. Users sourced from Windows Server AD are not supported at this time."
Does this mean I currentlyneed AAD DS for WVD to work?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d2eeca14-80ef-c0b4-2719-80ceb286ba3d
Version Independent ID: b7d3df23-3158-2807-eecc-73e7230c2033
Content: What is Windows Virtual Desktop?  - Azure
Content Source: articles/virtual-desktop/overview.md
Service: virtual-desktop
GitHub Login: @Heidilohr
Microsoft Alias: helohr

@Chai-NED Thanks for your query. We are looking into this and will update you.

@Chai-NED Yes, this is currently not supported at this time. This support will be added soon. Please follow the this page for the updates on WVD.
I am closing the issue for now.
Thanks.


Support for beforeAll and afterAll

This adds support for beforeAll and afterAll... something i'd really like to see (and something @jasminebdd said you were interested in)

+1

+1

I would also like to see this....

+1

Jumping the bandwagon
+1
Although a possible workaround (for now) is just to run your functions outside the describe block and access the results stored in a variable.
Or am I doing something wrong? ><

+1

+1

I am looking for a way to do this to integrate my Javascript tests with Browserify -- I need to start a copy of the server and pull down the server Javascript bundle, and it doesn't make sense to do this more than once.  Also, I want to do this across every test in the suite, so I don't see a way to do it outside of a beforeAll/afterAll.  I can prevent the server from running more than once, but I also need to shut it down when the tests are complete, and I don't see how to do that.
I see a workaround: I can start it and have every suite increment a counter in their local beforeEach and decrement in their afterEach.  Yuck.

3 months more and this one is one year old.

@pivotal ping ping ping ping ping.

+1 for mocha. DOWN WITH PIVOTAL :D

+1

sorry, everyone, i'm deleting my fork of jasmine. I don't want anything to do with this project.

Apologies to fat and everyone else invested in the outcome of this thread for the lack of motion/feedback on this pull request -- most of our Jasmine efforts have been focused on making sure we work with Rails 3.1.
I don't think anyone should plan on seeing this in Jasmine any time soon, although I think we'd like to make it possible for end-users to change how Jasmine works (either via callback hooks or add-ons).
The big obstacle here is adding a beforeAll to the public interface, a feature which none of the maintainers really want to encourage or support.

So Jasmine is integrated with the bloated Rails framework - that makes it final to me  - Goodbye Jasmine. No more Jasmine , ever.

Iroal... I didn't infer that to mean that it's integrated with Rails, but rather it's just made to work with Rails. Regardless, fortunately Mocha is a suitable alternative.

@jprichardson I'd really like to understand what the problem is with beforeAll/afterAll. I'm using it all over the place in my current test suite (mocha). Am I doing it wrong? Is it an antipattern?

pulled last comment, I see it was clarified above.

The same, switching to mocha.

I'm late to the party here, but I have the same issue in some of my specs where the setup and teardown is too expensive to execute each time.  I (as well as everyone here with this issue) am smart enough to know when it makes sense to execute beforeEach vs beforeAll.  If I use it incorrectly and wind up with broken specs, I have nobody to blame but myself.  I would consider beforeAll / afterAll to be another tool in the toolbox to use where appropriate.
That said, here is a workaround that has suited us well.  Just include these definitions in a helper file somewhere:
var beforeAll = function(fn) {
  it('[beforeAll]', fn)
}

var afterAll = function(fn) {
  it('[afterAll]', fn)
}

It is obviously a little silly, but it gets the job done for us.  Just be sure the beforeAll() is at the top of your describe block, and the afterAll() is at the bottom of your describe block.  If you have issues involving the order of execution between the all() and each() helpers, you should be able to resolve them using a nested describe block.
To the maintainers of jasmine: thank you for an exceptional tool.  Don't let the haters get you down.  Obviously you can decide what jasmine is and is not, but I still highly encourage you to implement this functionality.  It is clear that a lot of people need it, and please do not infer that your user base is not smart enough to use it properly.  Yes, it can cause "test smells" and it should be used with caution, but when you need it, you need it.


DTSAM-286 Demo of bad behaviour in existing new ASB implementation

Jira link (if applicable)
DTSAM-286 "Review how new ASB message processing handles failures"
Change description
For testing purposes: no change in behavour: i.e. to demo the bad behaviour in existing new ASB implementation.

NB: This is a test PR, the primary PR for this ticket is #1901.

Checklist

[x] commit messages are meaningful and follow good commit message guidelines
[x] README and other documentation has been updated / added (if needed)
[x] tests have been updated / new tests has been added (if needed)
[x] Does this PR introduce a breaking change - NO

Closing this TEST PR as the parent one is now merged.


Discord channel creation on request rather than automatic

This could be configured through hunt settings or something.

Maybe we can have a checkbox on the creation form (default can be configured at the hunt settings level). Should be pretty easy to implement.

In addition to checkbox on creation form, maybe the links on the tables to the discord channel should be "create a channel" links if channel does not exist. So that if a puzzle gets worked on by remote people after it's creation in cardboard, people can still make channels.

In addition to checkbox on creation form, maybe the links on the tables to the discord channel should be "create a channel" links if channel does not exist. So that if a puzzle gets worked on by remote people after it's creation in cardboard, people can still make channels.

I was planning to make it so that the edit modal has the checkbox available


Retrieve data from EBAM PLUS

We need a basic script to retrieve data from the EBAM PLUS.
A new record is produced hourly, approximately on the hour (within precision of EBAM clock). The script will be triggered hourly via cron and only needs to retrieve the latest record.
Data should be saved to a folder in /var/log in comma- or tab-separated values files.

The bench test script test_ebam_comms.py is verified to work correctly and can be used as a starting point.  More notes are in docs/develop.md.

Let's record the data into files stored under /var/log/ebam/, named after the current month. (We can revisit log rotation later on.)
Use a comma- or tab separated values format. We can reconsider too if other formats are more convenient.

Closed by 008fd2413f0cfe3b31389ad997e0d0514b199b35


Add tflint

Include tflint in arkade. This would allow us to use it as part of our CICD pipeline to verify our terraform resources via the arkade-get Github workflow.
Expected Behaviour
Similar to any other tool – tflint: latest would be great, plus support to point it to specific versions.
Current Behaviour
A Pluggable Terraform Linter
Possible Solution
Add tflint to arkade
Context
We are currently using this tool in our CICD pipeline, so it would be nice to install it the same way as the other tools used in the pipeline.
If requesting a CLI for "arkade get"
How many downloads does this tool have? 2,335,234
If approved, are you willing to submit a pull request for this? Yes

Please go ahead and send a PR

Great @cyberox


Unexpected CLGEMM (F16) performance comparison results between Mali-G71 (bifrost arch) vs Mali-T880 (midgrad arch)

Hello,

Are the OpenCL functions optimized for Mali bifrost architecture (Mali-G71)? Or are they mainly optimized for Mali Midgrad architecture? or for both architectures?
I ran CLGEMM on Huawei Mate 9 (ARM Mali-G71) and Galaxy S7 edge (Mali-T880) [both have same number of shader cores].  I used the same code as shown in "https://github.com/ARM-software/ComputeLibrary/issues/62".  Summary of the result is quite unexpected for Mali-G71. I stated the summary below:
a) For larger matrix size, the performance of Mali-T880 is significantly better (~2x to 3x) than  Mali-G71
b) As the matrix size increases, the throughput "GOPS/s" increases in case of Mali-T880 but it decreases in case of Mali-G71!

Th results are stated below:
Matrix size= (MNK)
Matrix size= 196 * 160 * 528
[Mali-T880] --> 12.34 GOPS/s,  [Mali-G71] --> 12.77 GOPS/s
Matrix size= 196 * 256 * 1152
[Mali-T880] --> 25.08 GOPS/s,  [Mali-G71] --> 31.38 GOPS/s
Matrix size= 12544 * 64 * 147
[Mali-T880] --> 41.32 GOPS/s,  [Mali-G71] --> 51.59 GOPS/s
Matrix size= 3136 * 192 * 576
[Mali-T880] --> 71.83 GOPS/s,  [Mali-G71] --> 41.17 GOPS/s
Matrix size= 1000 * 1000 * 1000
[Mali-T880] --> 75.23 GOPS/s,  [Mali-G71] --> 20.60 GOPS/s

It would be of great help if anyone could give a reason for such performance gap for larger matrix size. Is it an optimization issue (not optimized for bifrost arch) or an architecture issue?

Hi @atrah22,
At the current stage, CLGEMM (both fp32 and fp16) have not been optimized for Mali Bifrost architectures but just for Mali Midgard.
The reason why you see better performance for large matrices should be behind the number of dispatched threads on the GPU.
Let's take in consideration the 2 cases:
Matrix size= 196 * 160 * 528
and
Matrix size= 1000 * 1000 * 1000
Since each work-item (thread) computes 8x4 output elements for GEMM fp16, this means that we are going to dispatch:
196 * 160 * 528 - > ~1000 threads
1000 * 1000 * 1000 - > 31250 threads
In cases of few threads the risk is to dispatch the whole workload on few GPU cores and then to have less performance.
Hope this can help you.
Thanks,
Gian Marco


Fix interpretation of GetModuleFileName in sample code

Fix interpretation of GetModuleFileName in sample code

Thanks for the PR, Jason, sorry for the delay processing it.


feat(wandb): save models on wandb

Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[X] Did you read the contributor guideline, Pull Request section?
[X] Did you make sure to update the docs?
[ ] Did you write any new necessary tests?
[X] If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?
This PR allows to save checkpoints in wandb directory which is uploaded at the end of the script. See example
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

awesome!


Correct variable used for gating_repo location

If we decide to pass down a different "gating_repo" value using
cifmw_bop_gating_repo, we hit an issue when hitting the create_repo step
This PR has:

[X] Appropriate testing (molecule, python unit tests)
[X] Appropriate documentation (README in the role, main README is up-to-date)

recheck

recheck