[Web] IndexSizeError: Failed to execute 'ellipse' on 'CanvasRenderingContext2D': The major-axis radius provided (-0.5) is negative

I'm trying to run this project on Flutter Web, but it's not working.
Log output:
Launching lib\main.dart on Chrome in debug mode...
Syncing files to device Chrome...
Debug service listening on ws://<IP_ADDRESS>:51057/iVYKod7--YU=
Debug service listening on ws://<IP_ADDRESS>:51057/iVYKod7--YU=
══╡ EXCEPTION CAUGHT BY SCHEDULER LIBRARY ╞═════════════════════════════════════════════════════════
The following DomException object was thrown during a scheduler callback:
  IndexSizeError: Failed to execute 'ellipse' on 'CanvasRenderingContext2D': The major-axis radius
provided (-0.5) is negative.

When the exception was thrown, this was the stack:
C:/b/s/w/ir/cache/builder/src/out/host_debug/flutter_web_sdk/lib/_engine/engine/dom_renderer.dart 526:14               ellipse
C:/b/s/w/ir/cache/builder/src/out/host_debug/flutter_web_sdk/lib/_engine/engine/canvas_pool.dart 528:25                [_runPath]
C:/b/s/w/ir/cache/builder/src/out/host_debug/flutter_web_sdk/lib/_engine/engine/canvas_pool.dart 600:5                 drawPath
C:/b/s/w/ir/cache/builder/src/out/host_debug/flutter_web_sdk/lib/_engine/engine/bitmap_canvas.dart 345:17              drawPath
C:/b/s/w/ir/cache/builder/src/out/host_debug/flutter_web_sdk/lib/_engine/engine/surface/recording_canvas.dart 1179:11  apply
C:/b/s/w/ir/cache/builder/src/out/host_debug/flutter_web_sdk/lib/_engine/engine/surface/recording_canvas.dart 136:24   apply
C:/b/s/w/ir/cache/builder/src/out/host_debug/flutter_web_sdk/lib/_engine/engine/surface/picture.dart 272:35            paintCallback
C:/b/s/w/ir/cache/builder/src/out/host_debug/flutter_web_sdk/lib/_engine/engine/surface/surface.dart 48:14             commitScene
C:/b/s/w/ir/cache/builder/src/out/host_debug/flutter_web_sdk/lib/_engine/engine/surface/scene_builder.dart 546:7       <fn>
C:/b/s/w/ir/cache/builder/src/out/host_debug/flutter_web_sdk/lib/_engine/engine/profiler.dart 36:18                    timeAction
C:/b/s/w/ir/cache/builder/src/out/host_debug/flutter_web_sdk/lib/_engine/engine/surface/scene_builder.dart 540:12      build
packages/flutter/src/rendering/layer.dart 808:35                                                                       buildScene
packages/flutter/src/rendering/view.dart 230:36                                                                        compositeFrame
packages/flutter/src/rendering/binding.dart 406:18                                                                     drawFrame
packages/flutter/src/widgets/binding.dart 865:13                                                                       drawFrame
packages/flutter/src/rendering/binding.dart 284:5                                                                      [_handlePersistentFrameCallback]
packages/flutter/src/scheduler/binding.dart 1113:15                                                                    [_invokeFrameCallback]
packages/flutter/src/scheduler/binding.dart 1052:9                                                                     handleDrawFrame
packages/flutter/src/scheduler/binding.dart 968:5                                                                      [_handleDrawFrame]
C:/b/s/w/ir/cache/builder/src/out/host_debug/flutter_web_sdk/lib/_engine/engine/window.dart 725:13                     _invoke
C:/b/s/w/ir/cache/builder/src/out/host_debug/flutter_web_sdk/lib/_engine/engine/window.dart 338:5                      invokeOnDrawFrame
C:/b/s/w/ir/cache/builder/src/out/host_debug/flutter_web_sdk/lib/_engine/engine.dart 213:18                            <fn>
════════════════════════════════════════════════════════════════════════════════════════════════════
Another exception was thrown: PersistedScene: is in an unexpected state.

Flutter Doctor:
C:\flutter\flutter\bin\flutter.bat doctor --verbose
[√] Flutter (Channel beta, 1.19.0-4.1.pre, on Microsoft Windows [versÃ£o 10.0.18363.900], locale pt-BR)
    • Flutter version 1.19.0-4.1.pre at C:\flutter\flutter
    • Framework revision f994b76974 (7 days ago), 2020-06-09 15:53:13 -0700
    • Engine revision 9a28c3bcf4
    • Dart version 2.9.0 (build 2.9.0-14.1.beta)

[√] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at C:\Users\Rodrigo\AppData\Local\Android\sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 4.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 46.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] Connected device (2 available)
    • Web Server • web-server • web-javascript • Flutter Tools
    • Chrome     • chrome     • web-javascript • Google Chrome 83.0.4103.106

• No issues found!
Process finished with exit code 0

But it runs fine on emulator and physical device.

Minimal reproducible code sample
import 'package:flutter/material.dart';

void main() => runApp(MaterialApp(home: MyApp()));

class MyApp extends StatefulWidget {
  @override
  _MyAppState createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  @override
  Widget build(BuildContext context) {
    return SafeArea(
      child: Scaffold(
        body: Center(
          child: TextField(
            decoration: InputDecoration(
              labelText: 'Label',
              border: OutlineInputBorder(
                borderRadius: BorderRadius.circular(0.0),
              ),
            ),
          ),
        ),
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel master, 1.20.0-1.0.pre.56, on Mac OS X 10.15.5 19F101, locale en-GB)
    • Flutter version 1.20.0-1.0.pre.56 at /Users/nevercode/dev/flutter
    • Framework revision 248d746575 (18 hours ago), 2020-06-15 14:46:09 -0700
    • Engine revision 965fbbed17
    • Dart version 2.9.0 (build 2.9.0-14.0.dev 2b917f5b6a)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/nevercode/Library/Android/sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 46.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.46.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.11.0

[✓] Connected device (5 available)
    • Redmi Note 7       • 6345c469                                 • android-arm64  • Android 9 (API 28)
    • Nevercode’s iPhone • b668e524315069f3db3661ac11ff1f66afafebdb • ios            • iOS 13.5
    • macOS              • macOS                                    • darwin-x64     • Mac OS X 10.15.5 19F101
    • Web Server         • web-server                               • web-javascript • Flutter Tools
    • Chrome             • chrome                                   • web-javascript • Google Chrome 83.0.4103.97

• No issues found!

+1
Hi, i have same issue on my Flutter web project.
Please fix ASAP, thanks.

Have that issue with my project too (Flutter 1.20.0-7.3.pre):
Another exception was thrown: IndexSizeError: Failed to execute 'ellipse' on
'CanvasRenderingContext2D': The major-axis radius provided (-10.2488) is
negative.
Another exception was thrown: IndexSizeError: Failed to execute 'ellipse' on
'CanvasRenderingContext2D': The major-axis radius provided (-10.2488) is
negative.
Another exception was thrown: Assertion failed:
org-dartlang-sdk:///flutter_web_sdk/lib/_engine/engine/bitmap_canvas.dart:817:12
Another exception was thrown: IndexSizeError: Failed to execute 'ellipse' on
'CanvasRenderingContext2D': The major-axis radius provided (-10.2488) is
negative.
Another exception was thrown: IndexSizeError: Failed to execute 'ellipse' on
'CanvasRenderingContext2D': The major-axis radius provided (-10.2488) is
negative.

Minimal reproducible code sample
import 'package:flutter/material.dart';

void main() => runApp(MaterialApp(home: MyApp()));

class MyApp extends StatefulWidget {
  @override
  _MyAppState createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  @override
  Widget build(BuildContext context) {
    return SafeArea(
      child: Scaffold(
        body: Center(
          child: TextField(
            decoration: InputDecoration(
              labelText: 'Label',
              border: OutlineInputBorder(
                borderRadius: BorderRadius.circular(0.0),
              ),
            ),
          ),
        ),
      ),
    );
  }
}

flutter doctor -v

Hi @VladyslavBondarenko, if it can be useful I have temporarily solved it by changing the labelText to hintText, and now the TextFields works fine on Chrome.
With this solution you will lose the animation of the label when the field takes focus.

You can keep the animation if you change the Radius from zero to just 1.0. (const BorderRadius.all(Radius.circular(1.0))). This does work and the user will merely notice the difference.
You can even use the kIsWeb constant to only apply this to web and keep your mobile code on zero radius.

This bug does not exist anymore in Flutter 2.5.0.


The Division 2 - performance

I tried the latest amdvlk on The Division 2 and find the performance a bit sub par. Despite from the initial shader stutter, the gpu clock, does never really exceed 1300 Ghz nor runs at 99% utilisation. I am wondering since this is an AMD title.
Another user reported 90 fps for the game on a navi XT, he used the latest amdgpu-pro with the 139 version of amdvlk. For me that did not work tho, on that version graphics are heavily glitching for me.
Are there some options I can tune or do you have some ideas for me?
On RADV the performance is equally.
I made a vid on amdvlk:
https://www.youtube.com/watch?v=V1wFngvW8Yc
Thx in advance,
Greetings ~ent

Dumb idea here: could it be the GPU thinks its core-bound.

I got a 24 on core load, tho its not maxed out frequncy-wise.


Update api_gw_stack.py

Issue #, if available:
Description of changes:
At time of writing, when pulling the latest from main and running in us-east-1 you receive the following error - note it appears as an auth error, but it's really a Layer version not found/available error:
User: arn:aws:sts::<ACCOUNT>:assumed-role/cdk-hnb659fds-cfn-exec-role-<ACCOUNT>-us-east-1/AWSCloudFormation is not authorized to perform: lambda:GetLayerVersion on resource: arn:aws:lambda:us-east-1:336392948345:layer:AWSDataWrangler-Python39:3 because no resource-based policy allows the lambda:GetLayerVersion action (Service: Lambda, Status Code: 403, Request ID: e3ba4d96-9898-419b-afa8-e9fc90ad25c6)

This fixes the AWSDataWrangler-Python39 Lambda layer version to :9 for us-east-1. Note, this PR technically only fixes the issue when using us-east-1 as other regions have different version numbers. Notice the different versions by region here.

@jcsturges
Thanks for pointing this out and also providing a solution. The layer version 3 works for Oregon only.
I believe if we could move these configurations to the cdk.json file instead it would also then work for other regions.
ILet me know if you could take it up else will work on a fix for the same .

Fixed this in the latest merge


A legitimate domain is being blocked

There's one entry in the hosts file that it's blocking images hosted on Blogger/Blogspot, the address is the following:
1.bp.blogspot.com
It's breaking several blogs, can you remove it?
Examples:
http://submundo-hq.blogspot.com.br/
http://cinespacemonster.blogspot.com.br/2015/10/v-batalha-final-aka-v-original.html

@mitchellkrogza can you please advise?

Will be addressed in today's commit.
On 04 Mar 2017 07:28, "Steven Black"<EMAIL_ADDRESS>wrote:

@mitchellkrogza https://github.com/mitchellkrogza can you please advise?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/StevenBlack/hosts/issues/257#issuecomment-284129373,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJgARexp4A25AuhozDeW88b6paS6oJg-ks5riPaFgaJpZM4MS8BC
.

I appreciate it.

No problem, appreciate you alerting me to it, helps a lot keeping a legit
list. That domain is from a very early list I started with when I branched
off into my own projects.
On 04 Mar 2017 09:45, "Drako Frost"<EMAIL_ADDRESS>wrote:

I appreciate it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/StevenBlack/hosts/issues/257#issuecomment-284135032,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJgARTjx-c1_uSNIECwkF6aLPOZTabhMks5riRaAgaJpZM4MS8BC
.

Fixed in https://github.com/mitchellkrogza/Badd-Boyz-Hosts/commit/13486d1092c0e51f9fb58ce5deb8e8d1034bd27e

Regenerated. Thanks everybody!
Closing.


Binary sensor missing last_changed and last_updated in states

Home Assistant release with the issue: 0.100

Last working Home Assistant release (if known): 0.97 ? maybe lower
Operating environment (Hass.io/Docker/Windows/etc.): Hassbian

Integration: Z-Wave/Template Sensor

Description of problem:
I have some z-wave binary sensors (motion sensors) that I used to be able to tell when they were last updated. I used this to denoted when a motion changed. Now, the states of last_changed appears to be 'None' even tho there is a history and in the modal, it shows time since last change.
Here is my template to show it:
{{state_attr('binary_sensor.ecolink_motion_detector_sensor_2', 'last_updated')}}

States shows this:
<template state binary_sensor.ecolink_motion_detector_sensor_2=off; node_id=23, value_index=0, value_instance=1, value_id=72057594428784640, friendly_name=Front Entry Motion Sensor @ 2019-10-16T11:36:18.631427-05:00>
This works in the templating test section:
{{ as_timestamp(states.binary_sensor.ecolink_motion_detector_sensor_2.last_updated) | timestamp_custom("%b %d %Y %I:%M%p") }}

but using "states." is not supposed to be used in templating according to the documentation.
Here is a screen show showing the information is available and what is produces:

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
front_entry_motion_last_changed:
  friendly_name: 'Front Entry Motion Last Changed'
  entity_id: binary_sensor.ecolink_motion_detector_sensor_2
  icon_template: 'mdi:walk'
  value_template: '{{as_timestamp(state_attr("binary_sensor.ecolink_motion_detector_sensor_2", "last_updated")) | timestamp_custom("%b %d %Y %I:%M%p")}}'

Traceback (if applicable):

Additional information:

@ImNightwing is this still an issue?


IE 11: Invalid operand to ‘instanceof’: Function expected

Hello. Thank you for your library!
I have problem in Internet Explorer 11.
I have web application 1 which has signalR. And I have another application2 (without signalR) which has iframe with application 1.
When I close iframe (remove from dom) in application 2 I get error: Invalid operand to ‘instanceof’: Function expected every ~10-15 seconds.
After debug I saw that after close iframe ArrayBuffer is undefined in signalR. But I open iframe with app 1 ArrayBuffer is defined.

Info

"@aspnet/signalr": "1.0.3"
Microsoft.AspNetCore.SignalR 1.0.3
npm 6.1.0
The JavaScript client
IIS Express
Windows 10
IE 11

@BrennanConroy we can probably be a little more defensive here.

This fix will appear in the 1.1.0-preview3 release
Fixed via https://github.com/aspnet/SignalR/commit/ef3d3b1cddebf43e6f8bbfc81519a11356d2095a


[sui framework][verifier] Make Transfer functions restricted

Transfer functions are now private to the module that defines the type

This restriction is lifted for types with store

delete_child_object is the odd function out, and is not "private". The assumption is that if you were able to get the VersionedID, the module has already "destroyed" the object, and this function is just for cleanup.

I will need help with being pointed to what docs to fix

I want to understand better the context of this change. Is it so that modules can define arbitrary condition under which the transfer can happen, such as "you can only transfer your coin if your address ends with 0 "? And why is the restriction lifted for objects with store ability?

Is it so that modules can define arbitrary condition under which the transfer can happen

Yes

And why is the restriction lifted for objects with store ability?

It is an ergonomics win, without changing expressiveness. If the type has key+store, anyone can wrap it into a simple object that exposes all of the transfer operations, bypassing any logic in the defining module.
In other words, if you have store, you cannot actually restrict any transfers, so the transfer functions are no longer actually private.
We believe that more often than not, this is actually what you want. So relaxing it for store improves the ergonomics in the common case, and removes the dance of going into/out of a wrapper with exposed transfer functions


Retrieval Eval error for KGs with no object properties

https://github.com/dice-group/Ontolearn/blob/90996aa453d1ab3526f308f8ee24eae447cfa26d/examples/retrieval_eval.py#L89-L91
This causes in error if we use a KG with no object properties. (e.g. lymphography.owl)
Thus we should change the maximum to max(0, int(len(nc) * args.ratio_sample_nc).

Yes. Could you fix it ?

Yes. Could you fix it ?

Yes! Ig the same holds for this sampling of named concepts:
    if args.ratio_sample_nc:
        # (6.1) Subsample if required.
        nc = {i for i in random.sample(population=list(nc), k=max(1, int(len(nc) * args.ratio_sample_nc)))}

but are there kgs that dont define classes?

Yes!

ok then i will change that as well :)

Thank you 👍

fixed in #488


/functions directory in root does not work

As per docs on Cloudflare Pages, I tried adding a /functions/hello.ts file in my project but when I visit /hello, it shows error page.

Hi @fineshop what you linked is the documentation for generic Pages Functions, if you are working on a next-on-pages project you should not use Pages Functions but Next api routes instead (or more specifically edge api routes as we mention in our nextjs guide).
I hope this helps, if it does please let me know so that I can close this issue, if doesn't feel free to provide more details so I can try to assist further 🙂

Yes, you can use rewrites to map /users to /api/users (in this way both /users and /api/users will return the same but I am not sure if you can prevent /api/users to respond, I guess it'd need a bit of playing around)
But unfortunately it doesn't look like next-on-pages supports rewrites at the moment, I'll create an issue for that.

Closing this issue as I think it's not applicable / resolved

@dario-piotrowicz how would you go about configuring a codebase so that the /functions directory at the root of the project can be used in tandem with @cloudflare/next-on-pages?
I need to be able to deploy a non-edge function alongside the edge functions that are automatically generated by @cloudflare/next-on-pages.

Pages isn't well positioned to do that unfortunately, I was chatting with @GregBrimble today and he has plans to make Pages more flexible in the future so that what you're asking would be really simple to implement 😓 (he's started with this PR but it doesn't look like things are going to progress any time soon unfortunately: https://github.com/cloudflare/workers-sdk/pull/1740)
Right now... I am not really sure, you could make your repo a monorepo and have two different pages applications one with /functions and one with the next-on-pages app?
Anyways could you give me more details? what are you trying to accomplish and why aren't Next api routes enough? maybe there is something that can be done without using /functions?


Ignore streaming methods.

Currently Gapic generator does not support gRPC-streaming methods,
we will skip streaming methods for the time being (otherwise
the generated code will behavior incorrectly or lead to compile
errors).
Note that this skip can't be done solely on the configuration
yaml (i.e. not-listing methods in the yaml file), because
many of the generators silently assume the existence of
MethodConfig instances and end up with NullPointerExceptions.
Rather than supporting missing MethodConfig cases, I believe this
special-handling of gRPC-streaming would be better because
anyways this type of special-handling will be necessary when we start
supporting gRPC-streaming methods for a specific language without
affecting other languages.

@pongad already did the same thing in https://github.com/googleapis/toolkit/pull/328 ...

Oh... good to know. Closing.


Error - [webpack] Error processing webpack stats: TypeError: Cannot read property 'toJson' of undefined v2.0

Target SharePoint environment
SharePoint Online
What SharePoint development model, framework, SDK or API is this about?
💥 SharePoint Framework
Developer environment
Windows
What browser(s) / client(s) have you tested

[ ] 💥 Internet Explorer
[ ] 💥 Microsoft Edge
[X] 💥 Google Chrome
[ ] 💥 FireFox
[ ] 💥 Safari
[ ] mobile (iOS/iPadOS)
[ ] mobile (Android)
[ ] not applicable
[ ] other (enter in the "Additional environment details" area below)

Additional environment details

Google Chrome 104.0.5112.102
SPFx version 1.14.0
Node.js version 14.18.0

Describe the bug / error
After creating new webpart and running it (or whatever else webpart) in dev server I've started to receive this errors:

Later I've discovered that the error is thrown beacuse of 'react-pdf' library I am using to create pdf files in other webparts I've created before and where haven't had any issue.
I've discovered from issue #7691 that the problem can have the roots inside the file WebpackTask.js coming from gulp-core-build-webpack, I after added additional check for stats and everything works well.
Before:

After:

Steps to reproduce

Install new webpart;
Run gulp serve;

Expected behavior
serve and bundle commands complete without error.

@DimaIpatii I believe it behaves correctly.
The task doesn't fail but prints the error if any.
I'm not sure "swallowing" the errors is good.

@AJIXuMuK I've tried to console stats and it was undefined, so for that reason it throws this error.

Right. But why do you think our engine should swallow it?


Various refactorings for __owned.

Various problems I noticed, along with a rename, to reflect the two sorts of ownership, plus pulling the shared/inout bits into a unified enum, to reflect their mutual exclusivity.

@swift-ci please smoke test and merge

https://github.com/apple/swift/pull/14874
@swift-ci please smoke test

Oh, that's a bit embarrassing. Let's use the right link this time.
https://github.com/apple/swift-lldb/pull/355
@swift-ci please smoke test

apple/swift-lldb#355
@swift-ci please smoke test

apple/swift-lldb#355
@swift-ci please smoke test

apple/swift-lldb#355
@swift-ci please smoke test

apple/swift-lldb#355
@swift-ci please smoke test.

apple/swift-lldb#355
@swift-ci please smoke test.

apple/swift-lldb#355
@swift-ci please smoke test.

apple/swift-lldb#355
@swift-ci please smoke test.

apple/swift-lldb#355
@swift-ci please smoke test.

apple/swift-lldb#355
@swift-ci please smoke test

apple/swift-lldb#355
@swift-ci please smoke test

apple/swift-lldb#355
@swift-ci please smoke test

apple/swift-lldb#355
@swift-ci Please smoke test

apple/swift-lldb#355
@swift-ci please smoke test.

I'm afraid this change broke all the LLDB bots. Could you please take a look?
When renaming API, a full test might be more appropriate.

Note that this might block full pull request testing.


xSQLServerMaxDop: Tests need to be implemented for this resource

Details of the scenario you try and problem that is occurring:
There are no tests for this resource yet.
The DSC configuration that is using the resource (as detailed as possible):
n/a
Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a
Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev

I take this one. PR in progress, I'll update comment with the PR reference.


Capture javac args in a @argfile

This should fix issue #151

Can one of the admins verify this patch?

I think the cla I had signed was for one email address but these commits are associated with another. I've added a cla agreement for my the email address associated with the commits in this pull

can you say "I signed it" or something, and see if the bot picks it up?

@johnynek having my co-pilot  ( @jrodbeta ) verify his cla. I think its a combination of both of our agreements. I'll check in after

I signed it

I signed it

"CLAs are signed, but unable to verify author consent"
So maybe all the authors need to have signed since there are multiple ones?

I think we're just trying to figure out how to trip the pr bot now

cool, okay since it looks like I am just supposed to verify these multi-person commits, it looks like it is legit, and it looks like the build passes, so I'll merge.
Thanks for the contribution, @softprops and @jrodbeta

thanks man

Thanks @johnynek  I'm wondering if it's because of company email.  I'll get the company CLA done for next time.

as an FYI from my experiments with the bot it seems like the primary email needs to sign (Be it private or corporate)

no test here :( @johnynek I'd suggest that at least for bug fixes targeted like this we mandate a test. WDYT?

I'm happy to follow up with some unit tests.

I would appreciate that

@ittaiz It would be nice to have a test that failed before and now works. We are testing this code in the existing java-scala mixed targets, which is why I accepted it without a stronger test.
I kind of bias towards being pretty certain it is not worse, especially for newer contributors. But, yes, ideally we could be stronger and be sure that it is even better than it was before.

I understand. The problem I'm worried about is the fear of change or its
reckless friend the regression. We will eventually refactor and/or add
features there and we want that agility.
On Tue, 28 Feb 2017 at 20:09 P. Oscar Boykin<EMAIL_ADDRESS>wrote:

@ittaiz https://github.com/ittaiz It would be nice to have a test that
failed before and now works. We are testing this code in the existing
java-scala mixed targets, which is why I accepted it without a stronger
test.
I kind of bias towards being pretty certain it is not worse, especially
for newer contributors. But, yes, ideally we could be stronger and be sure
that it is even better than it was before.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/rules_scala/pull/155#issuecomment-283118332,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABUIFxQOcfFrBpvYTM3hQ4HUktfS6xoFks5rhGLigaJpZM4MNxre
.


Game Freezes at some point

Game freezes at some point during gameplay and becomes unresponsive to user inputs.
Steps to reproduce the error:

Type a wrong word to fill the boxes and match the target.

For example, let's say you got Target = 12 and the number of boxes is 4. Type P (3 pts) 4 times and it will match the target / fill the boxes.

Hit Enter

It will reject your input and then freeze until reloaded.

Cause of error
A dictionary API is used to validate every word if the word a) fills all boxes and b) meets the target score.
So when you follow the steps to reproduce the arrow above, you end up with an invalid word meeting the criteria to be run against the API. This returns an error that is caught by the .catch block but then freezes the application.

Solved at https://github.com/NARUDESIGNS/word-target/commit/3d2d3258fdf5a89887285367d9e96ab547e55c8e


tests: remove unused variable

header_len was never read here. The newer LLVM versions warn on this
now.

/retest


added and query

part of #97

And query is deprecated. https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-and-query.html


URL using bad/illegal format or missing URL everytime

Basic request not work.
Ethon::Easy.new(url: "google.com").perform
ETHON: Libcurl initialized
ETHON: performed EASY effective_url=www.example.com response_code=0 return_code=url_malformat total_time=0.0
=> :url_malformat

https://github.com/typhoeus/ethon/issues/238

Finally, in repo, current MR and issue not receive reply so think is not maintained actively

Hi @mrdev023
Sorry for the delay, I missed the notification.
Can you please share the ruby code & on which endpoint you are trying ?

Hi @mrdev023 Sorry for the delay, I missed the notification.
Can you please share the ruby code & on which endpoint you are trying ?

https://github.com/getbrevo/brevo-ruby?tab=readme-ov-file#getting-started
And i have this bug with newer version of libcurl.
In my fedora 39, it works well (libcurl 8.2). https://fedora.pkgs.org/39/fedora-x86_64/libcurl-8.2.1-3.fc39.x86_64.rpm.html
In my NixOS, it doesn't work (libcurl 8.7.1) https://search.nixos.org/packages?channel=unstable&show=curl&from=0&size=50&sort=relevance&type=packages&query=curl

I no longer use the official gem but this https://github.com/unovafr/brevo-openapi one which I regenerated from your documentation
i use https://github.com/unovafr/brevo-openapi/blob/main/flake.nix#L14 faraday library instead of typhoeus

STATUS : Not reproduced
Code
require 'brevo'
Brevo::AccountApi.new.get_account

If return Unauthorized (Brevo::ApiError) so it's ok
otherwise return URL using bad/illegal format or missing URL
Fedora (8.2.1) =>  OK
Arch (8.7.1) => OK

I think finally it's a bug libcurl side or distroside all my previous test work well now. I close issue after test your gem in my project with full environment and if is work well also.

It work on alpine 3.18 in our side i close this issue


Constant Peer ID upon restart of services

Can potentially integrate changes (and flags?) from Bootstrap node
Definitely should be done for allocator
What about proxy within container? (i.e. if container restarts, should it maintain the same peer ID?)
Perhaps each service should use a different default key filename than what's in Bootstrap right now. This'll accomodate multiple services running within the same disk namespace (e.g. root namespace or same container).

Will support this feature for Proxy service as well.


Zib-HealthProfessional

The pattern profiles include a comment on their .title being simply 'Reference'. In the https://simplifier.net/NictizR4Zib2020dev project this .title is indeed used when referring to the pattern. However in my own test project on Simplifier the .name is used instead (making the comment in the pattern profiles redundant).

The pattern profiles include a comment on their .title being simply 'Reference'. In the https://simplifier.net/NictizR4Zib2020dev project this .title is indeed used when referring to the pattern. However in my own test project on Simplifier the .name is used instead (making the comment in the pattern profiles redundant).

Do you know where this difference comes from?

The pattern profiles include a comment on their .title being simply 'Reference'. In the https://simplifier.net/NictizR4Zib2020dev project this .title is indeed used when referring to the pattern. However in my own test project on Simplifier the .name is used instead (making the comment in the pattern profiles redundant).

Do you know where this difference comes from?

No, unfortunately not. I have created https://nictiz.atlassian.net/browse/ZIBFHIR2024-401 to keep track of this issue.


fix(nextjs): Fix interstitial infinite loop error message indentation

Type of change

[x] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[ ] @clerk/clerk-js
[ ] @clerk/clerk-react
[x] @clerk/nextjs
[ ] @clerk/remix
[ ] @clerk/types
[ ] @clerk/themes
[ ] @clerk/localizations
[ ] @clerk/clerk-expo
[ ] @clerk/backend
[ ] @clerk/clerk-sdk-node
[ ] @clerk/shared
[ ] @clerk/fastify
[ ] @clerk/chrome-extension
[ ] gatsby-plugin-clerk
[ ] build/tooling/chore

Description

[x] npm test runs as expected.
[x] npm run build runs as expected.

After the fix:

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


[Android] Bar chart renders incorrectly when data changes multiple times

Libraries Installed
"react-native-gifted-charts": "1.4.8",
"react-native-svg": "15.2.0",
"expo-linear-gradient": "~13.0.2",
"react-native-linear-gradient": "*"

Explanation
If the data in a bar chart is changed (one to several times) the chart begins to render the data incorrectly. When the chart is animated it takes several changes to surface the bug but the chart begins rendering some bars the wrong color and/or doesn't render them at all. If the chart is not animated then old data will remain on the chart.
The issue originally occurred for me using an Expo Dev Client build but the minimum reproduction proved it will also happen in Expo Go.
The same code works fine on iOS.

Screenshots
Android

iOS

Reproduction Videos
Animated
https://github.com/Abhinandan-Kushwaha/react-native-gifted-charts/assets/43148991/3c62f11f-67c1-4c31-ab9a-cc2d20b94011
Not Animated
https://github.com/Abhinandan-Kushwaha/react-native-gifted-charts/assets/43148991/3631eb84-8fda-4e37-bdbc-e5c125730325
Same code on iOS behaving as expected
https://github.com/Abhinandan-Kushwaha/react-native-gifted-charts/assets/43148991/9f2f2f58-bb9f-4358-bca3-624a08a65f03

Reproduction Steps
I have a repository here: https://github.com/Justin-Terry/minimum-charts-repro
If you'd prefer to do it yourself, this is the component.
import {FC, useState} from 'react'
import {
    Button, Dimensions,
    StyleSheet, View,
} from 'react-native'
import { SafeAreaView } from 'react-native-safe-area-context'
import {BarChart} from "react-native-gifted-charts";

const BAR_SPACING = 3

const tempDayData = [
    { value: 0 },
    { value: 50 },
    { value: 100 },
    { value: 150 },
    { value: 200 },
    { value: 250 },
    { value: 300 },
    { value: 350 },
    { value: 400 },
    { value: 450 },
    { value: 500 },
    { value: 550 },
    { value: 600 },
    { value: 650 },
    { value: 700 },
    { value: 750 },
    { value: 800 },
    { value: 850 },
    { value: 900 },
    { value: 950 },
    { value: 1000 },
    { value: 1050 },
    { value: 1100 },
    { value: 1150 },
]

const tempWeekData = [
    { value: 0 },
    { value: 100 },
    { value: 200 },
    { value: 300 },
    { value: 400 },
    { value: 500 },
    { value: 600 },
]

const tempMonthData = [
    { value: 0 },
    { value: 35 },
    { value: 70 },
    { value: 105 },
    { value: 140 },
    { value: 175 },
    { value: 210 },
    { value: 245 },
    { value: 280 },
    { value: 315 },
    { value: 350 },
    { value: 385 },
    { value: 420 },
    { value: 455 },
    { value: 490 },
    { value: 525 },
    { value: 560 },
    { value: 595 },
    { value: 630 },
    { value: 665 },
    { value: 700 },
    { value: 735 },
    { value: 770 },
    { value: 805 },
    { value: 840 },
    { value: 875 },
    { value: 910 },
    { value: 945 },
    { value: 980 },
    { value: 1015 },
    { value: 1050 },
]

interface HomeScreenProps {}

const HomeScreen: FC<HomeScreenProps> = () => {
    const [data, setData] = useState(tempDayData)
    const [chartWidth, setChartWidth] = useState(Dimensions.get('screen').width)

    return (
        <SafeAreaView style={styles.page} edges={['top']}>
                <View style={styles.buttonWrapper}>
                    <Button
                        title={'DAY'}
                        onPress={() => setData(tempDayData)}
                    />
                    <Button
                        title={'WEEK'}
                        onPress={() => setData(tempWeekData)}
                    />
                    <Button
                        title={'MONTH'}
                        onPress={() => setData(tempMonthData)}
                    />
                </View>
                <BarChart
                    isAnimated={true}
                    animationDuration={500}
                    data={data}
                    width={chartWidth}
                    spacing={BAR_SPACING}
                    barWidth={8}
                    height={chartWidth / 2}
                />
        </SafeAreaView>
    )
}

export default HomeScreen

const styles = StyleSheet.create({
        page: {
            flex: 1,
            backgroundColor: 'white'
        },
        buttonWrapper: {
            margin: 24,
            flexDirection: 'row',
            justifyContent: 'space-between'
        },
        pageContent: {
            flexGrow: 1,
            paddingTop: 24,
            paddingHorizontal: 16,
            alignItems: 'center',
        },
    })

@Justin-Terry a very hacky way to resolve this issue is to add a key prop to the bar chart and ensure that the value changes each time a click is made. For instance, the title for the buttons, that you have, could be used.
The key prop triggers the bar chart to rerender each time its value changes.

Hi @Justin-Terry 👋
Thanks for reporting this bug.
The issue with Bars not re-rendering on data change in case of non-animated chart has been fixed in version 1.4.18
Please use the latest version of the library.


Terracotta server PID file creation/deletion using startup scripts

This PR contains the .bat file changes only. sh file changes will be on similar lines, and can be done quickly. I can update the PR with sh changes as well once the overall philosophy and approach is approved.

Can one of the admins verify this patch?

This appears (not a BAT expert) to only support a single running server at a time, no?
I'm not clear on the requirements... maybe that's fine.


"MPS is not normalized" when I try to PastaQ.getsamples(ψ, bases)

I got an error that "MPS is not normalized, norm=1.000000042243257" when I tried to PastaQ.getsamples(ψ, bases). I understand that the MPS norm should be 1, but I'm curious about the reason why the norm is not 1. Does the approximation of floating point numbers cause it, or is there something wrong with my code? In addition, the norm obtained by running my code is usually 1e-8 orders of magnitude different from 1. Could this error be larger? Thanks very much.

Probably the check is too strict. Can you try normalizing your MPS explicitly?

Probably the check is too strict. Can you try normalizing your MPS explicitly?

Thanks for your reply. I fix it by dividing by its norm,i.e., ψ=ψ / LinearAlgebra.norm(ψ), and then it doesn't raise any error. I'm not sure about the meaning of the check is too strict, since I didn't find something like eps in the docs. Actually, I'm curious about the reason and I can accept the current error, 1e-8,  but I'm worried that this error could get larger in some extreme cases.


Go to a method from an array with a class and the method [feature]

Hello.
I have a code with a class and a method.
use App\Http\Controllers\API\CalculatorController;

Route::get('computation/{id}', [CalculatorController::class, 'getComputation']); // \App\Http\Controllers\API\CalculatorController@getComputation

I would like to go to a method by this route declaration.
Thanks.

@stef-k , Not working with named routes with class.

Working
Not working
Working


Unification error for datetimes (minimum/maximum)

Reporting a bug

[X] I have tried using the latest released version of Numba (most recent is
visible in the change log (https://github.com/numba/numba/blob/master/CHANGE_LOG).
[X] I have included below a minimal working reproducer (if you are unsure how
to write one see http://matthewrocklin.com/blog/work/2018/02/28/minimal-bug-reports).

Checked the docs and GH issues and can't find anything similar after a quick search.
conda list produces for numpy/numba:
numba                     0.49.1           py38h47e9c7a_0
numpy                     1.18.5           py38h6530119_0
numpy-base                1.18.5           py38hc3f5095_0

Minimum Workable Example
import numpy as np
import numba

@numba.njit
def test(a, b, some_condition):
    if some_condition:
        x = a
    else:
        x = np.minimum(a, b)

    return x

test(np.datetime64("2000-01-01"), np.datetime64("2020-06-29"), False)

This produces the following error:
Cannot unify datetime64[] and datetime64[D] for 'x.2'

def test(a, b, some_condition):
    <source elided>

    return x
    ^

Expected outcome
I would expect the smallest datetime (or largest for np.maximum) to be returned. For integers the test works great so what I think is happening is that np.minimum discards some metadata of the dtype, though I'm not entirely clear on how to fix this (e.g. if I use np.minimum(a, b).astype("datetime64[D]") I get a new error Unknown attribute 'astype' of type datetime64[]).
Full traceback

Traceback details
test(np.datetime64("1700-01-01"), np.datetime64("2000-01-01"), False)
Traceback (most recent call last):
File "<...>\lib\site-packages\numba\core\dispatcher.py", line 401, in _compile_for_args
error_rewrite(e, 'typing')
File "<...>\lib\site-packages\numba\core\dispatcher.py", line 344, in error_rewrite
reraise(type(e), e, None)
File "<...>\lib\site-packages\numba\core\utils.py", line 80, in reraise
raise value.with_traceback(tb)
numba.core.errors.TypingError: Failed in nopython mode pipeline (step: nopython frontend)
Cannot unify datetime64[] and datetime64[D] for 'x.2', defined at <...>/scratch.py (691)
File "scratch.py", line 691:
def test(a, b, some_condition):

return x
^

[1] During: typing of assignment at <...>/scratch.py (691)
File "M1Code.py", line 691:
def test(a, b, some_condition):

return x
^

Conda isn't giving me Numba 0.50.1 with either conda update --all or conda install -c numba numba so I will try a new environment in a short while

@AA-Turner thanks for submitting this, I can confirm I am able to reproduce this on this mornings master 0.51.0dev0-122-g9ce5c30d32. It seems like it might be a bug in Numpy and I do agree with your initial guess.


Implement a suppressServer setting for high-security builds

Improvements
This pull request implements a Boolean setting called suppressServer, whose default value is `false'.
If a build or plugin explicitly sets it to true, the sbt-1.x server will not start up
(exactly as if sbt.server.autostart were set to start).
Users may manually override this setting by running the startServer command at the interactive prompt.
Motivation
Projects often encounter private information, such as deployment credentials, private keys, etc.
For such projects, it may be preferable to reduce the potential attack surface than to enjoy the
interoperability offered by sbt's server. Projects that wish to make this tradeoff can set suppressServer
to true in their build. Security-sensitive plugins can define this setting as well, modifying the
default behavior in favor of security.
(My own motivation is that I am working on a plugin for developing Ethereum applications
with scala and sbt. It must work with extremely sensitive private keys.)

See also a recent conversation on Stack Exchange.

Hi @swaldman,
Thank you for your contribution! We really value the time you've taken to put this together.
Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:
http://www.lightbend.com/contribute/cla

This PR just happened to land on the tail end of 1.1.1. Normally it's a bit more of waiting :)

I'd just like to say, thankyou @swaldman . This was driving me crazy.

@fommil thanks! i'm delighted it wasn't just me who will find this useful.

@hrj You can write:
val autoStartServer = settingKey[Boolean]("")
autoStartServer := false


Update constraints.md with composite key example

There was no example on how to set a primary key as an composite of several columns, even though it was mentioned in the text. In my opinion it helps greatly with clarity to give an example outright, as there is no other example (that I could find) that clearly shows a composite key.
I reused the example for a single column primary key to outline the difference when a composite key is used:
Old example:
CREATE TABLE students(id INTEGER PRIMARY KEY, name VARCHAR);
INSERT INTO students VALUES (1, 'Student 1');
INSERT INTO students VALUES (1, 'Student 2');
-- Constraint Error: Duplicate key "id: 1" violates primary key constraint'

New example added after the old example, showing a composite primary key:
CREATE TABLE students (id INTEGER, name VARCHAR, primary key (id, name));
INSERT INTO students VALUES (1, 'Student 1');
INSERT INTO students VALUES (1, 'Student 2');
INSERT INTO students VALUES (1, 'Student 1');
-- Constraint Error: Duplicate key "id: 1, name: Student 1" violates primary key constraint

@szarnyasg  - thank you, ofcourse - I'll do it right away! Would an example for an unique key (vs a primary key) be a bit too much or something that I should propose, by the way?

I think another example on that is fine too!


[Feature Request] Ability to move and resize popped out stage

Perhaps use hotkeys to enable window decorations, full screen, etc.

Since we can't have any controls listed on the popout, place them where the stage used to be in the main window.


fix: Allow symfony/process 7x

This is needed for Laravel 11 support (because Laravel 11 requires symfony/process 7x)
Looks like the changes from v6 to v7 are minimal and unrelated: https://github.com/symfony/process/blob/7.1/CHANGELOG.md

Thanks for your contribution!


Show alarm on full screen like system alarm

System alarms are shown on full screen even when the screen is locked making it easy for a user to snooze or stop the alarm.
Alarm plugin has a full screen display UI but notification on Android is the standard size. Can we make it to show on the entire screen (similar to the example UI) when screen is locked similar to system alarm?

Hi @sagar1garg
On Android, if you want the notification to be full screen you have to enable androidFullScreenIntent parameter and the screen has to be locked. I chose to not show the full screen notification when device is unlocked because it would be too intrusive for your users. Imagine you're watching a video or writing a message and you get interrupted by a full screen alarm notification... I believe a simple notification is enough don't you think?
I'm closing the issue then but feel free to ask if you have any question.


gravitas was moved to a new file

This solves the bug #4

I'm seeing that this repo does not have the tests that has the other repositories, that has the other repositories, maybe later I can help with that


Support fluent and clean up

This allows you to now support using the module with fluent
It also splits out objects into classes which we can find the tables for and then tables which are just truncated
Task is now run from populate-task and documented correctly for running it

@jakxnz I've become old and can't relate to emojis anymore 😂
You might want to try out https://github.com/adrhumphreys/silverstripe-fixtures
I found that with Fluent, Elemental, and Populate, you end up spending more time debugging missing data in some key table or some such. I still need to get around to updating this PR to reflect the changes I made when making the module

You might want to try out https://github.com/adrhumphreys/silverstripe-fixtures

Thanks for the suggestion. Can you elaborate on what that solves @adrhumphreys ?
I did end up testing this branch, and found that it didn't quite manage a clean slate, and so my populate task crashed because of duplicate keys.

@jakxnz just need to find time to update the autocomplete code a bit 🙏🏽
The module solves the issue of needing to have a lot of specificity in the order things need to be loaded and increasing the ease of adding in functionality to that creation. I also found often you'll not have put a correct value in, say you have a default value set on write, that doesn't get automatically set anymore so you need to specify it
You end up with these hard to read yml files that sort of go like:
create the elemental area for the page
create the elemental area for the layout block
create the page and link to the area
create the carousel block and link to the area

Where it becomes more difficult to conceptualise what is being done in the populate config
The idea with the other module is you create fixtures in PHP in which you call the normal creation methods that you have in Silverstripe. If you want to create 50 objects with random numbers you can just write a loop to do that.
It manages the loading order by allowing the developer to explicitly state the dependencies for a fixture rather than manually ordering them
It also provides a few purging options, you can choose any/all of the three, array of classes to delete, array of tables to delete, a method called unload which you can write your own code in
This isn't all smooth though as you'll have a performance hit since you're calling all the after writes etc for your models now when populating them. I just found the tradeoff worth it

The module solves the issue of needing to have a lot of specificity in the order things need to be loaded and increasing the ease of adding in functionality to that creation

Nice. Yep, I have experienced this. Cool that you're working on an enhancement! @adrhumphreys

For anyone looking for a way to support Fluent via populate, I raised a PR against @adrhumphreys fork, with some adjustments that worked for our project https://github.com/adrhumphreys/silverstripe-populate/pull/1

Hey @adrhumphreys there's a few outstanding changes suggested on this, do you still want to look at merging it in at some point?
I'm just trying to work out which order to merge changes in - whether merging #26, #32 then #33 makes the most sense or something else...

I've fixed all the conflicts in README.md and rebased/merged the master branch in.
Any final thoughts @jakxnz, @adrhumphreys, @michalkleiner or @chrispenny?
If not, I'm happy to merge it now and we can tidy things up later.
One question I have is how does it actually support fluent now @adrhumphreys? I see there is some old code that supported it by checking if the Fluent extension was applied to an object that was being truncated, but this appears to have been removed. I don't see anything added to the fluent module either, so does it just handle it implicitly now and you didn't have to do anything? Or am I missing something obvious here? 🙂

All good with me, all the remaining stuff is quite minor.

@madmatt , it currently supports fluent by exposing an extension point that can be used to clear tables created by other modules e.g
PopulateExtension.php:
/**
 * @param array $tables
 * @param string $className
 * @param array $classTables e.g ['Class\Name' => 'Table']
 */
public function updateTruncateObjectTables(&$tables, &$className, &$classTables)
{
    // Update truncate object tables
    foreach ($classTables as $className => $baseTable) {
        /** @var DataObject|Versioned|FluentExtension $obj */
        $obj = Injector::inst()->get($className);

        if (!$obj->hasExtension(FluentExtension::class)) {
            // No localised tables to clear
            continue;
        }

        $fluentTable = $obj->getLocalisedTable($baseTable);

        $tables[$fluentTable] = $fluentTable;

        if (!$obj->hasExtension(Versioned::class)) {
            // No localised versioned tables to clear
            continue;
        }

        $stages = $obj->getVersionedStages();

        foreach ($stages as $stage) {
            $table = $obj->stageTable($fluentTable, $stage);

            // Include localised base and live table
            $tables[$table] = $table;
        }

        $versionedTable = "{$fluentTable}_Versions";

        // Include localised versions table
        $tables[$versionedTable] = $versionedTable;
    }
}

I felt this approach was less opinionated and had better grouping of concerns.
The title of the PR is a bit misleading.


balloon: fix C28170 warning for 'StatInitializeWorkItem'

warning C28170: The function 'StatInitializeWorkItem' has been declared to be
in a paged segment, but neither PAGED_CODE nor PAGED_CODE_LOCKED was found:
This warning is not emitted for functions that are __forceinline.
This warning makes Static Tools Logo Test to fail due to the warning marked as
'Must Fix'.
Signed-off-by: Sergey Bykov<EMAIL_ADDRESS>

@sb-ntnx Thanks!


Add South Africa national route shields

Adds shield support for national routes of South Africa. National routes have a blue pentagonal shield with a white border and yellow text. All routes in South Africa have a letter prefix, which is shown on shields in small font above the route number, though for the purposes of this project, the prefix is displayed inline with the route number.
South Africa has additional route networks on a more local level (provincial, regional, metropolitan), though tagging would need to be more complete and consistent before these routes can have shield support: #484

For context, South Africa’s directions signs follow a UK design: no shield, just a number in plain text in gold, with the alphabetic designation inline.

However, the blue pentagon remains in the SADC-RTSM and reportedly on maps. On the pentagon, the “N” appears above the route number, and a cardinal direction can optionally appear below the route number. I think it would be suboptimal to include inline prefixes on these shields or the ones in #484, just as it would be suboptimal to include “US” on a California-style U.S. Route shield.

This seems like a reasonable graphical representation to me based on the limited photos shared.

Between this and #162, I suspect the prefixes are just there for consistency with way refs. The photos above aren’t representative of how routes are marked on maps. Normally the pentagon contains just the route number, or it has “N” above the route number, just like on what would be the trailblazer sign.

I think we should at least give the South African community a heads-up about this issue or address it on our end via #141. If we land national route shields with the prefixes, they’ll look out of place next to provincial and metropolitan routes (#484), which likely won’t have enough horizontal space for an inline prefix.

I guess a potential solution would be to treat the prefix as banner text floating above the shield, which would involve removing the prefixes from ref values in route=road relations. I had been considering something similar with Brazil (#425).

Shield icon scrapped in favor of draw function:


Fix uv init a sub-package by path

Summary
Resolves #5242
Test Plan
See the CI failure for the new failing test.

Thanks!


[tests-only][full-ci] removing the setresponse in given/then step in FileVersionsContext

Description
We have used setResponse() and $this->response in the Given/Then steps and some helper functions (maybe to reuse existing available methods). But storing responses from Given/Then steps and helper functions is not a good idea because it can lead to a false positive assertion in the Then steps.
So, check the use of setResponse() and $this->response in

Given steps
Then steps (Then steps can use $this->response but must prevent saving to it)
Helper functions

Related Issue
https://github.com/owncloud/ocis/issues/7082
Motivation and Context

To  remove setResponse() and $this->response in the Given/Then steps and some helper functions
To avoid false positive assertions

How Has This Been Tested?

test environment:
locally
CI

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[X] Tests only (no source changes)

Checklist:

[ ] Code changes
[ ] Unit tests added
[ ] Acceptance tests added
[ ] Documentation ticket raised:

made some more changes to remove when step used by then step. so can you review again the last two commits @saw-jan @SwikritiT @SagarGi


Fix uncaught exception on checking the existence of a loader

Because if there is no extension on the latest iteration is exception occurs, which currently is not catched, and the work will be completed a fatal error.
https://github.com/sculpin/sculpin/blob/70acab357b1f4ff8bdff5b6a3339d30183cd83ca/src/Sculpin/Bundle/TwigBundle/FlexibleExtensionFilesystemLoader.php#L105

Thanks!


Relocate fields from .status to .spec

Move the following fields [1] from .status to .spec in the Account CR. It's not only a best practice on CRD design, but in order to support migrating clusters, we need to have all fields we want to persist as part of the spec object, otherwise they will be lost from the status after migration.

Clearly this is still a WIP, but things I noticed at a glance:

Move the following fields [1] from .status to .spec

There's no [1] footnote.
The fields were copied, not moved. Based on the comment I assume that was intentional. Is it a good idea to have them in both places though? Or is this for some transitional phase where the status fields are being deprecated; and a subsequent change will actually remove them?
There's no code yet to set the fields :) but I wonder what happens if there's a discrepancy. Since spec and status updates have to be two separate commands, one may fail; which is the source of truth?
I assume the user won't be allowed to set these fields. How will you handle it if they try?

(Are these kinds of design discussions happening in a card somewhere?)

Clearly this is still a WIP, but things I noticed at a glance:

Yes, this PR is far from finished. Expect to be open for a while, until all commits are done. There is lot's of experimentation. Many thanks for your comments -- they are really valuable.

There's no [1] footnote.

what do you mean by footnote ? can you give an examle?

The fields were copied, not moved. Based on the comment I assume that was intentional. Is it a good idea to have them in both places though? Or is this for some transitional phase where the status fields are being deprecated; and a subsequent change will actually remove them?

The idea behind this change is to make sure we can preserve the state during hive relocation. So the spec fields are going to be the ones to do that. That means all the logic the operator has at the very moment (e.g. if status.state X, then do Y), it will rely only the the spec.State.

There's no code yet to set the fields :) but I wonder what happens if there's a discrepancy. Since spec and status updates have to be two separate commands, one may fail; which is the source of truth?

After this PR, the source of truth should always be the spec.fields.

I assume the user won't be allowed to set these fields. How will you handle it if they try?

Good question. I haven't though of that. I can try using https://github.com/operator-framework/operator-sdk/issues/1587 but after reading a bit about it, it seems tough (a newer version of operator might be needed to support this).

(Are these kinds of design discussions happening in a card somewhere?)

I will send you the doc in Slack ;)

would be good to update the docs to include a section on cluster migration and how the new fields are utilised

yes, there will be an SOP for this.

As of this moment, the reconciliation failed with https://github.com/openshift/aws-account-operator/blob/bf6f58eb7a119e41905eca4ff287d45b52fa9b5a/pkg/controller/account/account_controller.go#L657 this error. @dastergon feel free to debug this.

It seems to be working fine now. Things to fix:

When I do oc get account osd-creds-mgmt-osd-staging-1 -n aws-account-operator I don't see the status. I have to do -o json to see it.
Go tests need to be adjusted to the new code. They are not passing at the moment. To test this against integration tests at the moment, go to the Makefile and remote lint and test from the make test-all target.

When I do oc get account osd-creds-mgmt-osd-staging-1 -n aws-account-operator I don't see the status. I have to do -o json to see it.

You should be able to tailor what you want to see via kubebuilder print columns. You’ll need to make op-generate afterwards to get them into the CRD.

Go tests need to be adjusted to the new code. They are not passing at the moment. To test this against integration tests at the moment, go to the Makefile and remote lint and test from the make test-all target.

Best way to debug these is to use ./boilerplate/_lib/container-make test lint. That’ll run the tests in a container that matches the CI environment.

Codecov Report

Merging #563 (7662044) into master (460ae6f) will increase coverage by 1.09%.
The diff coverage is 12.50%.

@@            Coverage Diff             @@
##           master     #563      +/-   ##
==========================================
+ Coverage   13.28%   14.37%   +1.09%
==========================================
  Files          45       45
  Lines        3878     4299     +421
==========================================
+ Hits          515      618     +103
- Misses       3340     3658     +318
  Partials       23       23

Impacted Files
Coverage Δ

pkg/controller/account/account_controller.go
0.49% <0.00%> (+0.14%)
:arrow_up:

pkg/controller/account/byoc.go
35.19% <0.00%> (+0.37%)
:arrow_up:

pkg/controller/account/iam.go
0.00% <0.00%> (ø)

...controller/accountclaim/accountclaim_controller.go
8.30% <0.00%> (+0.55%)
:arrow_up:

pkg/controller/accountclaim/reuse.go
26.87% <0.00%> (+1.10%)
:arrow_up:

pkg/controller/utils/status.go
0.00% <0.00%> (ø)

pkg/localmetrics/localmetrics.go
52.01% <0.00%> (-1.45%)
:arrow_down:

pkg/apis/aws/v1alpha1/account_types.go
89.70% <87.50%> (-0.78%)
:arrow_down:

...g/controller/accountpool/accountpool_controller.go
43.66% <100.00%> (+0.58%)
:arrow_up:

pkg/apis/scheme/scheme.go
60.00% <0.00%> (-3.64%)
:arrow_down:

... and 44 more

/hold
There's some pre-work (on cluster) to do before this is merged and deployed, so let's take care to merge when we're ready.

Is this still relevant?

This is not strictly required since cluster relocation has been handled manually, so I think we should close this PR.


Equipment Model Import still broken

See #1140, when we updated the equipment model table we broke some stuff (ran across this when reviewing #1081). I've fixed it, will push this into v5.2.0.

Note to self, we really need specs for this, but I guess that will probably wait until #899.


Updated automation-hrw-run-runbooks.md

Corrected typo naxautomation  to nxautomation

Verified the update.
@LeeSchuenemeyer Thanks for submitting the fix.


Use binding the same way as google home

Google home has eWelink binding. I think it will be better to use the same bindings api. Current imlementation by using mobile api does not work consistent, a lot of times it is not responding in HA.

Can you please elaborate the meaning of "eWelink binding"? do you mean API? if so i'm glad to let you know that thanks to @2016for who provided the documentation to official API from itead, the current implementation of websocket branch it's around 90% in line with it.
which begs the question: have you tried the websocket branch yet? the state changes are almost instantly

https://www.itead.cc/blog/sonoff-work-with-google-home
I mean such integration. I don't know details, but somehow in Google home, they bind ewelink devices to google home, and it works without any issues. I expect it should be possible to "fake" it for HA.

I'm sorry but your request is a bit out of scope, I'll try not to go too deep into details but the way google home works is by contacting Google servers first AND THEN itead servers, and yes it works flawlessly because they invest a ton of money in it and they have full support from itead team :P.
As an example, I was previously controlling sonoff devices using "fake" Alexa/Echo API, and I can assure you 100% it was not faster than current implementation.
There are many other options for Sonoff (and alike) devices, this is just an option, unfortunately is not working for everyone...


Ball 118 not available

I don't know if it was added recently, but the 118 ball is not available in your API

Some colors are not available at all


add swedish locale for keywords ajv 5.0.0

Coverage remained the same at 89.791% when pulling 1d69a3c0b069a1528eae02f1aa603d2888acddcc on Limmen:v2.0.0 into c9bc0fb353fcf94797a7fc9caccf1f33e45b638b on epoberezkin:v2.0.0.

Thank you


FIX: empty SeqView absolute/relative position returns 0

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
185 unchanged lines in 9 files lost coverage.


Include setup instructions

Hi I'm trying to set it up as shim module on an Ember app but didn't manage to get it working.
My goal was to reference the soundmanager library like this on a Controller/Component:
import soundManager from 'ember-cli-soundmanager-shim/soundmanager2-shim';
Thanks

Hey @torcasitas sorry I didn't see this before. I've been meaning to create an addon for this but for now please see the updated README with usage instructions.


NobodyNada: Blacklist Forever Bust

NobodyNada requests the blacklist of the following keyword(s):

F - MS search
o - MS search
r - MS search
e - MS search
v - MS search
e - MS search
r - MS search

MS search

B - MS search
u - MS search
s - MS search
t - MS search

F has been seen in 37682 true positives, 8240 false positives, and 1743 NAAs.
o has been seen in 39235 true positives, 8677 false positives, and 2040 NAAs.
r has been seen in 38509 true positives, 8634 false positives, and 1956 NAAs.
e has been seen in 39232 true positives, 8702 false positives, and 2076 NAAs.
v has been seen in 33987 true positives, 7338 false positives, and 1251 NAAs.
e has been seen in 39232 true positives, 8702 false positives, and 2076 NAAs.
r has been seen in 38509 true positives, 8634 false positives, and 1956 NAAs.
has been seen in 40122 true positives, 8764 false positives, and 2156 NAAs.
B has been seen in 35723 true positives, 7865 false positives, and 1517 NAAs.
u has been seen in 38094 true positives, 8408 false positives, and 1839 NAAs.
s has been seen in 39223 true positives, 8647 false positives, and 2039 NAAs.
t has been seen in 38874 true positives, 8675 false positives, and 2031 NAAs.

...what happened here?

This seems to be a little broken; I'll see if I can fix it. The code is all fine however.


[FR]Configure URL Base

Ive been struggling to set this up for a while with sonarr and radarr just loading blank pages. Ended up having to deploy everything, jump on the NFS server update the url base in the configs and then restart the containers
Would be great if we could set this in the my-values.yaml file

I actually think this may just be a bug not a fr

Hi @anothersmith! Thank you for reporting this :)
Can you share the media server CR you used to deploy it?
URL and base path is configured via initcontainers for all pieces, it would be great if you can share one of the broken configs to look into that a bit deeper.
Thank you!

general:   ingress_host: media.local   image_tag: arm64v8-latest   storage:     customVolume: true     volumes:       nfs:         server: <IP_ADDRESS>         path: /opt/plexmedia plex:   enabled: false

I am having the same issue, if i figure out how to resolve it ill post here

Maybe a little late to the party, but I had this problem for a while and read through the initContainer function.
In *arr-resources.yaml, the init container is this:
apiVersion: v1 data:   config.xml: |     <Config>       <UrlBase>{{ .Values.sonarr.ingress.path }}</UrlBase> // here sets the UrlBase     </Config>   init-sonarr.sh: |     #!/bin/bash     echo "### Initializing config ###"     if [ ! -f /sonarr-config/config.xml ]; then       cp -n /init-sonarr/config.xml /sonarr-config/config.xml       echo "### No configuration found, intialized with default settings ###"     fi kind: ConfigMap metadata:   name: init-sonarr-cm
This is supposed to save to a shared volume between that and the main container. This only gets created if we specify the container in our values file.
So for me this'd look like
Values.yaml
radarr:   enabled: true   volume:     name: radarr-config     storageClassName: "local-path"     accessModes: ReadWriteOnce     storage: 5Gi
Hope it helps.


Plot ATT/EPH time series to check jitter

One note on the reports - it would be useful to extract and plot time series of the ATT/EPH covariance matrix diagonal magnitude (effectively, std) from the L1B xml.  Will potentially help us understand why some products have larger jitter error than others.  And the mean values for the full image may be a predictor for the expected pointing precision.  Can discuss further when Ben is back.  I think we did this in early testing for jitter correction.

I think better metadata parsing using ASP's built-in functionality is priority prior to this: https://github.com/uw-cryo/asp_plot/issues/25#issuecomment-2303133565


fix: install epel repo in RHEL 7 using static repo file

What problem does this PR solve?:
This PR is stacked on https://github.com/mesosphere/konvoy-image-builder/pull/781
Installs epel release for RHEL/Centos 7.9 using static repo files

Tested the fix locally successfully on Centos 7 AMI

CI job: https://github.com/mesosphere/konvoy-image-builder/actions/runs/4746923145


Added is null for new APIs

e.g. Trello and noun project

Wasn't trivial bug to fix.
It was actually two bugs which independently produced exactly same result :)


Add assertions on input types

This PR introduces assertthat as a dependency and adds a bunch of assertions on inputs. This will help in debugging and add extra protection against unintended queries being executed on users' ES clusters.

@austin3dickey I just made the changes you recommended. The build failing was just R CMD CHECK doing its thankless but important job! I had used query in a few places where the object is actually called query_body.
Should hopefully build 🤞

Codecov Report

Merging #62 into master will decrease coverage by 1.29%.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##           master      #62     +/-   ##
=========================================
- Coverage   72.11%   70.81%   -1.3%
=========================================
  Files           3        4      +1
  Lines         538      586     +48
=========================================
+ Hits          388      415     +27
- Misses        150      171     +21

Impacted Files
Coverage Δ

R/elasticsearch_parsers.R
77.21% <100%> (+0.1%)
:arrow_up:

R/utils.R
100% <100%> (ø)

R/elasticsearch_eda_funs.R
38.83% <20%> (-4.54%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18fef75...4ae0726. Read the comment docs.

@austin3dickey this is building now and I made the recommended changes, so gonna merge it up. This will look (in a Github email) like I "dismissed your review", but I actually did do all the things.
Kind of wish this had tasks like Bitbucket

@austin3dickey ha joke's on me apparently I need one positive review no matter what to merge.
At your earliest convenience, no rush

ugh I think I know what this is. Trying locally, I was seeing a bunch of errors about multiple types not being allowed. The shakespeare data has mixed types :/

This is working now! Gonna ship it


How to add Quotes

Hey
I can't see in api option for adding quotes how can I doo that ?
I saw that I can handle adding quote but how to add them ?
Best Regards
Przemysław Kamiński

Hi.
Events QuoteAdded and QuoteRemoved will be raised when you add/remove expert MtApi.ex4 on chart in MT4 (same steps with MtApi5.ex5 for MT5).
In another words on each opening MT chart with MtApi expert you will have event QouteAdded in MtApi client. And vise versa, you will recieved event QuoteRemoved when you close one of the chart with MtApi expert.

let say if i have two mtAPI.ex4 on two different chart with same currency. one is showing h1, one is showing m5.
if both of them are calling the quoteAdd and quoteUpdate how can I know which one triggered the event?

You can use event QuoteUpdate where you will receive MtQuote object with ExpertHandle value.
This value is unique for each chart with MtApi.ex4.


Custom UI for Views Container

Currently views container only allows to create tree views. It would be good that some other UI elements can be added such as button, text inputs, dropdown, among others.
This all can be done in web-views, however some times we don't need full power from web-view but instead it would be highly beneficial to leverage the views container to have all extra inputs.
Some extension follow a hacky approach for buttons which is treating elements from the tree views as buttons. This is some times unintuitive and undesired. Also it doesn't allows to create text boxes.

Duplicate of #46585


Add PromCon 2024 blog post

What this PR does / why we need it:
Add PromCon 2024 blog post
Special notes for your reviewer:
/cc @rickardsjp
Release note:

/lgtm

@n-boshnakov Thanks for merging the PR. I noticed that it is not published yet on the website. Is there any step missing?

@n-boshnakov Thanks for merging the PR. I noticed that it is not published yet on the website. Is there any step missing?

I've checked the website and build logs, but I can't say for certain. By all accounts it should have appeared already.
I'll look into the matter some more.

@chrkl Because it does not have extension .md

@chrkl Because it does not have extension .md

Good catch, thanks! 🤦


Async test

Hi, right now i'm not using async test, because of clearing database before each test.
  def clear_database do
    @tables
    |> Enum.each(fn(table) ->
      table |> db |> delete |> run
    end)
  end

Is it possible to get new connection for every test like ecto and enable async test ?

I'm still investigating problem, one thing that i noticed that pool_mod parameter does nothing. You can pass any module with no effect. I guess it should be a pool instead.

Close this, more details here: https://github.com/robconery/moebius/issues/86


!!![FEATURE] add document iterator

The newly added iterators do iterate the toc tree to find the order of rendering of documents. This is required to have single page outputs in the correct order. The downside of this new approach is that only documents that are in a toc-tree are rendered.

We would also have to render orphans that are not connected to the toctree. It is totally "legal" to have orphans. In the rendering I would attach all orphans to the end of their corresponding directory in alphabetical order if there is more then one. I would exclude them from rendering int the prev-next buttons (and maybe single HTML) however. We could the leave the responsibity of if they should be rendered or not to the renderer and only have something like an "Is orphan" check
In sphinx all orphans must have the :orphan: modifier at the top of the document or they cause a warning. In either case they are rendered and can be linked with :ref: and :doc: links or cannonical URLs

I have updated the iterator to ensure orphans are rendered, I use a weak map to track the rendered documents, every time we see a document the flag is set to false this has 2 effects, documents that are seen are not rendered a second time, and documents that are not seen will be rendered afterwards.
There is no option yet to render just the non-orphans, but I think this is easy to implement by adding a filter to the iterator that can be configured via the constructor of the iterator.


node.start() is freezes

Another trouble appeared. I build my project for STM32 without any mistakes.
So I initialized my single node like in manual:
https://uavcan.org/Implementations/Libuavcan/Tutorials/2._Node_initialization_and_startup/
It's right and has not any troubles.
	node_id = 1;
        auto& node = getNode();
	node.setNodeID(node_id);
	node.setName("AirSensor");
	node.start();
	uavcan::Publisher <uavcan::protocol::NodeStatus> pub(node);
	pub.init();
        pub.setPriority(uavcan::TransferPriority::MiddleLower);
	node.setModeOperational();

But programm stops on node.start(). I spied this hell in debugger and found that program freezes at SentToIface function in uc_can_io.cpp (string 231):
    ICanIface* const iface = driver_.getIface(iface_index);
    if (iface == UAVCAN_NULLPTR)
    {
        UAVCAN_ASSERT(0);   // Nonexistent interface  ----> This macros freeze the programm
        return -ErrLogic;
    }

Actually  UAVCAN_ASSERT(0); freeze all platform. And no any error returns.
So, driver_.getIface(iface_index); always returns 0 at first, because iface_index variable we get from -->
res = sendToIface(i, frame, tx_deadline, flags); where i get from cycle (for (i=0.. bla-bla-bla))
And.. driver_.getIface(iface_index) goes to:
CanIface* CanDriver::getIface(uavcan::uint8_t iface_index)
{
    if (iface_index < UAVCAN_STM32_NUM_IFACES)
    {
        return ifaces[iface_index];  //--->this returns to me
    }
    return UAVCAN_NULLPTR;
}

I have UAVCAN_STM32_NUM_IFACES=1 and as I said I always get 0 value at first, and it returns ifaces[0]=0. Then it goes to UAVCAN_ASSERT(0); that completely freezes all programm (like in eternal while-cycle)
I cannot understand what happens?? How init nodes on STM32 properly??

The STM32 implementation of the drivers can use several "backends" depending on your RTOS. Did you define one of UAVCAN_STM32_CHIBIOS, UAVCAN_STM32_NUTTX, UAVCAN_STM32_BAREMETAL or UAVCAN_STM32_FREERTOS?
You should also define UAVCAN_STM32_TIMER_NUMBER to a timer that can be freely used by UAVCAN.

Of course, I defined it in build_config.hpp:
define UAVCAN_STM32_BAREMETAL 1
.....
define UAVCAN_STM32_TIMER_NUMBER 7
....
and #define UAVCAN_STM32_NUM_IFACES 1
..
But problem still exist. Actually I only commented  UAVCAN_ASSERT(0); ( this freezes, so i think that it's compilator's feauture) and program works further, but returns ErrLogic at string below.
Maybe I forgot something else, or this driver works not properly with STM32F407..?! (try to launch it on Discovery-board)

Hmm thats weird. I am using UAVCAN in an F407 without any issue. I just noticed that TIM7 is a "basic timer", I am currently using TIM2. Could you try with that one to see if that works please?

Yes. I use this driver. So I compiled DSDL-directory and included it in project. So I directly defined UAVCAN_STM32_TIMER_NUMBER , UAVCAN_STM32_NUM_IFACES and ets. in build_config.hpp at stm32 driver. I dont used 'make' command. So now I think, maybe it's causes the trouble?!

I see, that this func returns ifaces[0]=0, that call ErrLogic issue:
CanIface* CanDriver::getIface(uavcan::uint8_t iface_index)
{
if (iface_index < UAVCAN_STM32_NUM_IFACES)
{
return ifaces[iface_index]; //returns 0, that calls error
}
return UAVCAN_NULLPTR;
}
In debugger I also found that:

Failed to execute MI command:
-var-create - * &(((ifaces[0])->pending_tx_))
Error message from debugger back end:
-var-create: unable to create variable object
It seems that programm cannot set unzero-value to ifaces[x]. I still cannot understans, why.
I use Atollic TRUEstudio project, generated with CubeMX

What IDE your use?

This topic is closed, I fixed troubles. The reason was simple. I initialized CAN bus twice (in HAL first, and in libuavcan second), that caused conflict. And node init-process ended with error.  But I cannot understand why assert(x) macro go to frost. But now it's not so matter for me.


Widget state of a panel param not sync with the param value

MRE :
class Test(param.Parameterized):
    test = param.Number(default=0)

    @param.depends('test', watch=True)
    def _check_in_bounds(self):
        if self.test > 4:
            self.test = 3

inst = Test()
p = Param(inst.param, parameters=['test'], show_name=False)
pn.panel(p)

inst.test = 1 => sync OK
inst.test = 5 => sync NOK

I think events are being swallowed to avoid them bouncing around. I'll look into removing the checks which prevent events from bouncing back and forth and replacing them with some more principled approach.


[FEATURE] Random Color Flipper (RCF)

Created a Random Color Flipper using HTML, CSS & JS.

Kindly Assign me this task to add this new Unique Project to the Table.

Made a PR.
Kindly Review.


docs: migrate to main branch

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[x] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes #371  🦕

@parthea OwlBot seems to be failing on this PR, could you help take a look? Not sure what's triggering it to fail :/

@dandhlee Unrelated to your changes, there is a syntax error in owlbot.py here in the main branch.
Instead of
templated_files = common.py_library(
python.py_samples(skip_readmes=True)
    samples=False,  # set to True only if there are samples
    microgenerator=True,
    cov_level=98,

)

s.move(templated_files, excludes=[".coveragerc"])  # microgenerator has a good .coveragerc file

It should be
templated_files = common.py_library(
    samples=False,  # set to True only if there are samples
    microgenerator=True,
    cov_level=98,

)

s.move(templated_files, excludes=[".coveragerc"])  # microgenerator has a good .coveragerc file

python.py_samples(skip_readmes=True)

Fixed it. Please take a look again!


[icon themes] Hide sidebar's Tree View/Explorer arrows

As opened and closed folders can have different icons, the arrows should be given as an optional to get a minimalistic workbench theming (say for themes like Material Theme from Mattia Astorino or Nord theme)

Any update? i think this can be a workbench setting

News? :)

It would have to be part of the file icon theme to specify that (not a workbench preference)
But I currently have no time to implement it. PR are welcome. It new setting would be added to https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/services/themes/common/workbenchThemeService.ts#L48 and used by the file explorer.

+1 Please telle me how I can make this pr

Thanks for the PR, @tam5!

@tam5 Thank you.

@aeschli When will this PR be shipped with the insiders build?

Yes, it's already in the latest insiders.

@aeschli Sorry, I can't figure how to hide these arrows. There is not a setting called hidesExplorerArrows

@equinusocio It's a new property for file icon themes. The built-in file icon themes aren't using it, but to try it out, add "hidesExplorerArrows":"true" to the top level of the minimal file icon theme

@aeschli Thank you. I tried on my icon theme, both "hidesExplorerArrows": "true" and "hidesExplorerArrows": true but it doesn't work.
{
   "hidesExplorerArrows": "true",
   "iconDefinitions":{
      "_folder_dark":{
         "iconPath":"./icons/folder.svg"
      },
      ...
   },
   "fileExtensions":{
      "cmd":"_file_cmd",
      "mustache":"_file_mustache",
      "rails":"_file_rails",
      ...
   },
   "fileNames":{
      "gruntfile.js":"_file_grunt",
      ...
   },
   "file":"_file_dark",
   "folder":"_folder_dark",
   "folderExpanded":"_folder_open",
   "folderNames":{
      "node_modules":"_file_nodejs",
      ".git":"_file_git",
      ".github":"_file_github",
      ".gulp":"_file_gulp",
      "bower_components":"_file_bower"
   }

}

@aeschli Consider to use visibility: hidden instead of display: none to keep the same space for nested folders/files.

@aeschli @equinusocio I went back and forth on that as you can even see on the PR. Not sure there is a right or wrong answer, we'll just have to wait until more customization is available for the sidebar (i.e. padding) so everyone can decide for themselves.

@equinusocio Sorry, I mistyped, it has to be "hidesExplorerArrows":true (no quotes around `true')

To verify: Install an icon theme e.g. https://marketplace.visualstudio.com/items?itemName=gebilaoxiong.vscode-flatland-icon-theme. In the extensions folder find the extension and its icon theme file and add "hidesExplorerArrows":true

This works on Material Theme.


[Question] will pulsar roll over if there is only one topic in a namespace

I would like to ask friends who have used online, will pulsar roll over if there is only one topic in a namespace? Too much pressure on zk? The reason for this question is to assume that I want to adjust only one topic to write only some brokers and bookies, and do not want to affect other topics, because I need to unload to force disconnection

I would like to ask friends who have used online, will pulsar roll over if there is only one topic in a namespace? Too much pressure on zk?

What does rollover mean here?
And it depends on how many topics/namespaces you have. If only have thousands of topics/namespaces, don't need to worry about the pressure on zk.

The reason for this question is to assume that I want to adjust only one topic to write only some brokers and bookies, and do not want to affect other topics, because I need to unload to force disconnection

do you want to do the isolation for some topics?
Yes, currently only namespace can apply isolation policies.
for unloading, you can only unload a topic, not the whole namespace.

I tested the unload topic to no avail. Both bk and broker are the same, so I have to unload namespace.

@zcola It's better to share more information about the issue that you have to unload the namespace to recover. If the bug has been fixed, you don't need to use one topic per namespace.

Ok, I will open another issue


fix UI for the compare page in default theme

Bug report
Title
fix UI for the compare page in default theme
Issue Description
fix UI for the compare page in default theme
Preconditions
1. framework Version- master

Steps to reproduce
1. step1- change shop to default theme
2. step2- add product to compare list & go to compare page

Actual result

Resolved.


Does drogon have a recommended way to do parameter validation for HttpRequest?

Maybe

Use an annotation like Spring of Java. (impossible)
Use a common filter, and the rules for validation can be transferred into it in a way.
Inject different filter into different HttpController method. (Use if-else in the filter)
Use if-else in every post-put handler method.

Thanks for the feature request. Drogon currently doesn’t have a “sanctioned” way to do input validation. The options you already presented are currently the way to go.
This is indeed something I could imagine being part of the core framework.

Can someone give some examples for input validation?


Change arg to use Interpreter instead of path:string

Required for perf improvements.
We're using python.path in a number of places when we have the full interpreter information.
I.e. there are no instances when we'll not have interpreter information, hence use that instead of using the executable path.
Else in the lower decks we end up trying to resolve the python env information from the path.

Codecov Report

Merging #8337 (0c4bf40) into main (7406de0) will decrease coverage by 0%.
The diff coverage is 76%.

:exclamation: Current head 0c4bf40 differs from pull request most recent head 8e2583b. Consider uploading reports for the commit 8e2583b to get more accurate results

@@          Coverage Diff          @@
##            main   #8337   +/-   ##
=====================================
- Coverage     71%     71%   -1%
=====================================
  Files        374     373    -1
  Lines      23559   23561    +2
  Branches    3625    3623    -2
=====================================
- Hits       16897   16875   -22
- Misses      5203    5224   +21
- Partials    1459    1462    +3

Impacted Files
Coverage Δ

src/client/api/pythonApi.ts
68% <ø> (-1%)
:arrow_down:

src/client/api/serviceRegistry.ts
100% <ø> (ø)

src/client/api/types.ts
100% <ø> (ø)

src/client/common/process/types.ts
100% <ø> (ø)

src/client/datascience/activation.ts
86% <ø> (ø)

...cience/data-viewing/dataViewerDependencyService.ts
87% <ø> (ø)

.../datascience/jupyter/interpreter/jupyterCommand.ts
48% <ø> (ø)

...er/jupyterInterpreterSubCommandExecutionService.ts
88% <ø> (-3%)
:arrow_down:

...yter/interpreter/nbconvertExportToPythonService.ts
82% <ø> (ø)

...atascience/kernel-launcher/kernelLauncherDaemon.ts
88% <ø> (-3%)
:arrow_down:

... and 20 more


Lipgloss doesn't detect background correctly when using wish

Describe the bug
When using the bubbletea.MakeRenderer function,  lipgloss.AdaptiveColor and lipgloss.Renderer.HasDarkBackground always assume a black background, even though the terminal emulator from which i am using ssh has set a light background.
Setup
I'm running the wish example locally with go run . and also use a local terminal to access the ssh server.
It happens on Fedora 40 and MacOS with Gnome Terminal, iTerm2 and the standard mac terminal (all using zsh).
To Reproduce

Use the bubbletea example from the examples folder
Log HasDarkBackground using
log.Info(renderer.HasDarkBackground()) in the teaHandler function right after creating the renderer using the bubbletea middleware
Create a new Lipgloss Style in the teaHandler function that uses the renderer created using the bubbletea middleware and lipgloss.AdaptiveColor
3.1 Render some text in the View() method of the model using the adaptive color lipgloss style

Source Code
I've created a simple one-file example in this gist:
https://gist.github.com/Aerochrome/5fd2af09f94eda22a0875068b8824acc
Expected behavior
When accessing with a terminal emulator with a light background, the second line should be colored pink.
When accessing with a dark background, the second line should be colored red.
Screenshots
Expectation:

Reality:

Additional context
DISCLAIMER: I am very new to TUIs and fairly new to go, so i'm not sure how useful my debugging findings actually are, but i want to share them nonetheless in case they're of any use.
I suspect that this issue might be related to a missing Fd() method implementation on the ssh.Session struct.
In the bubbletea.newRenderer method in this file a check is performed on whether the Slave pointer is nil. If so, it passes the session struct into lipgloss.NewRenderer.
While this struct has a Write method, it doesn't seem to implement the Fd method.
When adding a very rudimentary one like so, the background color check seems to work properly and produces a working example.
func (sess *session) Fd() uintptr {
    return sess.pty.Slave.Fd() // Also works if sess.pty.Slave is nil
}

Of course, this doesn't account for sess.pty.Slave being nil (even though it produces a working example even if it is nil and i'm unsure why).
This suspicion is further confirmed by looking at an older wish example in the lipgloss repository, where a "helper" struct is created to pass into lipgloss.Renderer.SetOutput which also implements Write and Fd.
It also implements Read, though it doesn't seem to influence the outcome of a working example in my case.
So i've tried to use this helper struct, setting tty to pty.Slave and passing it into bubbletea.MakeRenderer like so, which produces a working example.
sessionBridge := &sshOutput{
    Session: s,
    tty: pty.Slave,
}

renderer := bubbletea.MakeRenderer(sessionBridge)

Again, this also works if pty.Slave is nil.
It is also worth mentioning that in my case checking pty.Master and pty.Slave against nil in the teaHandler function returns true in both cases, even though s.Pty() returns true as third return value which i assume means that a PTY was accepted for this session.
I don't know if this is expected behavior in this specific case?
log.Info(pty.Master == nil)
log.Info(pty.Slave == nil)

Also running into this! Happy to help if there's any opportunity to do so.

FWIW we're looking into it :)
thanks for the detailed report

Awesome, thank you!
Glad i was able to help :)

can you try on main?

Sure!
I've tried to run the example i provided in the gist with the main branch of wish, however the issue still persists.
I've executed

go get github.com/charmbracelet/wish@main
go mod tidy

And i am now on version v1.4.1-0.20240502183613-927ad4fbed5f of wish.
Perhaps there is something else i'm missing?

afaik that should be it, can you share the project you're working on?

Of course!
I've pushed my test project here: https://github.com/Aerochrome/charm-bg-test

right now it'll only work if you use allocatepty, I'm afraid
still looking into it though

awesome, thank you!


Fix lockmass being applied/removed on metadata-only DetailLevels

fixed lockmass being applied/removed when only metadata DetailLevels are requested (since it only impacts the binary data)
fixed centroiding being applied for fast and instant metadata levels (it's still needed for accurate defaultArrayLength on full metadata)

@bspratt I didn't test that this fixes the Skyline import time. Did you test that (for your patch variant)?

I did - it made it half as awful, which is to say still awful.
On Thu, Feb 20, 2020 at 12:26 PM Matt Chambers<EMAIL_ADDRESS>wrote:

@bspratt https://github.com/bspratt I didn't test that this fixes the
Skyline import time. Did you test that (for your patch variant)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ProteoWizard/pwiz/pull/941?email_source=notifications&email_token=AAJFE6JLWBUIYKCLBUWLLRLRD3RNVA5CNFSM4KYWGAH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMP6DPQ#issuecomment-589291966,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJFE6L5WAZGWX4EUUKSU43RD3RNVANCNFSM4KYWGAHQ
.

Hmm. I did some local testing with msbenchmark and I started to suspect the reason for the long import is that Skyline is asking for metadata without lockmass refinement, and binary data with lockmass refinement. That would cause it to cycle through apply/remove/apply/remove/apply/remove and each application takes about 15 seconds on this file. (Once it's applied it has no cost to request the next spectrum with refinement).
Since there's no reason to apply OR remove lockmass if only metadata is requested, adding an if condition seemed like an easy fix. However if it still has awful import time (msbenchmark takes 22 seconds to enumerate all spectra with binary data for 190731_BSAd_dil45_MSE_W_03_10_50B_2uL.raw) even with this fix, then I guess what I suspected above is wrong. Oh I see. Your patch would be removing lockmass if metadata only and lockmass==0. I'll test this version in Skyline myself then. Thanks.

I don't think so - see line 537 in MsDataFileImpl.cs

I also played with msconvert with and without lockmass correction, dramatic difference in processing speed. It really does seem to be something on the vendor side.

I do not see the difference in msconvert times with and without lockmassRefiner. What command-lines were you using?

Well it seems to be fixed. I can import 190731_BSAd_dil45_MSE_W_03_10_50B_2uL.raw in about 60 seconds.

Fixed by these changes? Or fixed by something else? If it is a simple and low risk enough fix, then we would obviously like to see it in the upcoming 20.1 patch. i.e. merged to the 20.1 branch.

By these changes.

I'll let perftests run overnight.

I just tested it here - seems to be working well. No idea why I was seeing
what I did yesterday.
This is probably worth backporting to the release branch.
On Thu, Feb 20, 2020 at 2:19 PM Matt Chambers<EMAIL_ADDRESS>wrote:

I'll let perftests run overnight.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ProteoWizard/pwiz/pull/941?email_source=notifications&email_token=AAJFE6IEQTVHX6QVZRREED3RD36VNA5CNFSM4KYWGAH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMQTUDA#issuecomment-589380108,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJFE6P32XXZE6NK7IMTFTDRD36VNANCNFSM4KYWGAHQ
.


Full commands tutorial written.

I’ve written a full command beginner guide, adding it here.
Originally at: https://gist.github.com/VideoCarp/24addfd65c82cb38009b5c34bfa2c188

Looks good! You will need to add the proper front-matter, which is at the top of all pages. Please see another page in the tutorials for an example.
This allows the page to go into the sidebar, and be searchable etc.

I’ve done that. Forgot to reply earlier.