Cannot render ePub contents

I compiled the SDK Launcher Android (master) and then I run it in a Nexus 7 2013 edition (Android 6.0.1)
Result:

I am able to list the epub files
I am able to open an ePub file and see the metadata (for instance, book "Utopia" from Thomas More - https://www.epubbooks.com/book/424-utopia)
I am not able to open book contents. The app shows an error while opening URL http://<IP_ADDRESS>:8080/chapter-003.html"

See logcat output - logcat.txt

Could you please try again with the latest code from the develop branch?
https://github.com/readium/SDKLauncher-Android/tree/develop
Please use Android Studio, make sure to install / update the latest NDK v14 and other framework dependencies (AS will let you know about available automatic updates).
Remember to check your SDKLauncher-Android/SDKLauncher-Android/local.properties file, it should look like:
ndk.dir=/Users/me/Library/Android/sdk/ndk-bundle
sdk.dir=/Users/me/Library/Android/sdk
readium.ndk_experimental=true
readium.ndk_clang=false
readium.ndk_skipARM=false
readium.ndk_skipX86=false
readium.sign_key_password=only_needed_for_release
readium.sign_store_password=only_needed_for_release

Thanks. Now it is working.


OAuth2 configuration should not modify local.php

After setting up OAuth2 authentication, I've noticed my local.php file has been modified (rewritten actually). This is somewhat annoying as I've had comments there (and some commented-out settings) which I tend to use in development and have been deleted. As this file is not committed to git and there is no backup, I now need to go and manually figure out what I'm missing.
Would be nice if any local configuration could be written to apigility.local.php or something similar, which is loaded just as well by default ZF2 apps but does not touch any local user files.

Hmm.. this shouldn't be here but in zfcampus/zf-apigility-admin
Sorry for the noise.


Automated download script fails to verify signature

When trying to install apigeecli inside an Ubuntu installation under Windows (using WSL), running the command provided in the documentation
curl -L https://raw.githubusercontent.com/apigee/apigeecli/main/downloadLatest.sh | sh -

produces an error with the signature being invalid. However using wget to download the zip file with the binaries and the signature file, and using the command to get cosign to validate the package, the validation is working as expected. Please see below screenshot for reference.

STEPS TO REPRODUCE:

run

curl -L https://raw.githubusercontent.com/apigee/apigeecli/main/downloadLatest.sh | sh -

observe signature validation error

@mattcolombo - can you try now?

Looks like it's working fine now! Thanks for the quick help 🙂
M


Already existing setup jobs are never reexecuted

@eliobischof  is it still open and which milestone should it be assigned?

@stebenz  I think you fixed this?

@eliobischof @stebenz Is this fixed? Can we close this?

@fgerschwiler  this should be fixed, otherwise, I think we can close it anyway as it stale for a long time


Returning empty markdown files

Having a bit of an issue getting the generated markdown files to work. I followed the example in the readme, and added my API key to an environment variable:
from notion2md.exporter.block import MarkdownExporter
from dotenv import load_dotenv
load_dotenv()
MarkdownExporter(block_id='my_block_id',output_path='test.md',download=True).export()

In this case, I'm getting the page directory generated, but the .md file inside is unfortunately empty. Do you know what could be causing this?
For reference, I'm using Python 3.9.13 and these Notion libraries:
notion-client==1.0.0
notion2md==2.7.6

I think the update of notion-client made the issue. Please check it again because I updated notion2md to support the update of notion-client. Thank you

Thanks for the update, unfortunately I'm unable to upgrade as your dependencies require notion-client>=1.0.1 and at the time of writing the latest version of this package is 1.0.0. The npm version is 1.0.1, but not the PyPI version.

I fixed it but I mentioned different issue... my bad. I upgraded the notion2md, so please reinstall notion2md. Again, I apologize to mention the wrong issue number. Thank you for making this issue


update spring cloud version to Hoxton.sr8

Update spring cloud version to Hoxton.sr8
Remove microsoft auth client dependency

Test with piggy metrics

@zmssp have we tested it with our get-started tutorial?


Change password link is escaped/doesn't work with Custom User

Django version: 5.0.4
Django-Unfold version: 0.29.1
Great project!
In the django-admin, the link meant to redirect to change password view/form doesn't work, and appears to be escaped.

By modifying the UserChangeForm, and explicitly calling mark_safe, the link begins to work.

Here's the full code snippet

from django.contrib.auth import get_user_model
from django.contrib.auth.forms import (
    UserCreationForm as BaseUserCreationForm,
    ReadOnlyPasswordHashField,
)
from django.utils.safestring import mark_safe

class UserForm(BaseUserChangeForm):
    password = ReadOnlyPasswordHashField(
        label=_("Password"),
        help_text=mark_safe(
            _(
                "Raw passwords are not stored, so there is no way to see this "
                "user’s password, but you can change the password using "
                'this form.'
            )
        ),
    )

    class Meta:
        model = get_user_model()
        fields = [
            "email_address",
            "password",
        ]

    def __init__(self, *args, **kwargs):
        super().__init__(*args, **kwargs)
        password = self.fields.get("password")
        if password:
            password.help_text = mark_safe(
                password.help_text.format(f"../../{self.instance.pk}/password/")
            )

Please check out the docs for more information:
https://github.com/unfoldadmin/django-unfold?tab=readme-ov-file#user-admin-form

My bad!
Just missed that in the docs. Thanks 👍

Please check out the docs for more information:
https://github.com/unfoldadmin/django-unfold?tab=readme-ov-file#user-admin-form

The Link does not work anymore. What's the solution for this issue?
We also use a custom user model and the link is not interpreted as HTML. We followed the docs here: https://unfoldadmin.com/docs/installation/auth/
except we can't use admin.site.unregister(User) because it raises an error (django.contrib.admin.exceptions.NotRegistered: The model User is not registered)
Do we miss anything? The rest of the UserAdmin looks like a regular unfold page.

Hi @Zerotask , I would make sure to check you're using the  UserCreate, UserEdit and PasswordChange forms provided by unfold.
You can find an example in https://github.com/unfoldadmin/django-unfold/blob/3f463d2c4a3e2506255b0381162a97609241a340/tests/server/example/admin.py#L15


Fix typo in PersistQueryClientRootOptions

the 't' was missing here

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3a127bf) 41.71% compared to head (8f58da6) 67.19%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6698       +/-   ##
===========================================
+ Coverage   41.71%   67.19%   +25.47%
===========================================
  Files         179        9      -170
  Lines        7007      253     -6754
  Branches     1416       58     -1358
===========================================
- Hits         2923      170     -2753
+ Misses       3713       73     -3640
+ Partials      371       10      -361

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


0.9.5 / 0.10.0 release

I've originally set the release date for the next release to April 1. As we're approaching 100 commits again (60 in the src dir) we should probably stick to that.
Is there anything that has to land before we do our next release? The milestone itself is empty (just removed while as that is blocked on the type fixes).
We also still have the version number "issue". IIRC the main argument against a 0.10.0 release is that it looks a lot like an 0.1.0. My preference would be to do a 0.10.0 as sticking to 0.9.x feels like we're doing minor patch releases. But if there is good reason to stick to 0.9.0 thats fine too (or do we skip to 0.11.0?)
@ajor @brendangregg  @danobi  @mmarchini @mmisono

I was seeing BTF support failing on some prod machines. Lemme debug it tomorrow. Maybe it regressed.

I think I have the fix: https://github.com/iovisor/bpftrace/pull/1220

A new release would certainly be very welcome for LLVM10 support, we're using the latest git to test against LLVM10 right now in Alpine Linux Edge.

With #1186 almost done I think we should merge that and do the 0.10 release. highlights of the release would be:

kfuncs
c++ demangle
the fixes around type:;ctx
llvm10

internally we have the new parser, type fixes etc. Total of 90+ commits in the src/ dir.
@danobi  @mmisono

Looks good to me!
As of the next version, I don't have strong opinion but 0.10.0 is straightforward to me.

0.10.0 sounds good to me. It might be a bit confusing mathematically but it's pretty consistent with how software releases go.


Diagnostic Log. I can't find it!

This feature is important for writing extensions, so why remove them?

Hi there, your issue has been closed due to not correctly following the issue template. Please read the documentation about filing issues and open a new issue which does follow the issue template. Do not reply to this issue with more information or with a correctly formatted issue, as that will only lead to confusion.
I try to address all github issues and fix bugs quickly, but badly formatted issues or poorly described bug reports especially are a significant drain on project resources. Taking a few minutes to file a good issue makes a huge difference and will get it addressed faster - everybody wins!
In github when you first create a new issue the form is pre-populated with a template which you should read over and follow. As linked above there is documentation going into more detail about what makes a good issue.


[lexical-react]: Fix incorrect addition of empty cells on table paste

This PR fixes the issue with empty cells getting incorrectly added to a table upon paste.
Before
When a table with rows with unequal sizes and merged cells is pasted, we add the empty cells in the wrong row.
For example, a table like this:

After
Empty cells are now added to the correct row.

Fantastic! Well done! Please add a test for this copy-paste use case, there are quite a few to take inspiration from, so it should be easy to add one.

@etrepum good with this one?


Domain activation is Failed - Trying to connect with DNS on Cloudflare.

App Id: d17fa87jt51ttt
Region: ap-southeast-2
Step: Domain activation
Status: Failed
Issue/question
I have the DNS hosted in Cloudflare and when I tried to configure my custom domain, it consistently fails on the Domain Activation step.
Error message
Error message: One or more of the CNAMEs you provided are already associated with a different resource.
Additional information
Please add any other relevant information. Please feel free to include screenshots.
I am following the docs but the parts on domain configuration are pretty scarce.

Discovered the issue in Cloudfront where I had pervious deployments which were now defunct but configured with the same CNAME values.

Discovered the issue in Cloudfront where I had pervious deployments which were now defunct but configured with the same CNAME values.


Unwanted behaviour on org-agenda todo state change for todo states with @ note taking

What did you expect to happen?
When changing todo state from within org-agenda, the buffer the todo heading is in is opened and then there immediately is a message with Buffer <file>.org modified; kill anyway? (y or n).
This only happens for todo states which should record a note to the logbook (e.g. FILE(f@)).
What actually happened?
Popup buffer only opens when n is sent to the y-or-n-p prompt.
Additional details:
The prompt only appears when the target buffer has not already been opened.

Steps to reproduce:

SPC h E
Insert into Doom Sandbox Buffer:

(after! org
  (setq org-todo-keywords '((sequence "TODO(t)"
                                      "PROJ(p)"
                                      "STRT(s@)"
                                      "WAIT(w@/!)"
                                      "HOLD(h@/!)"
                                      "IDEA(i)"
                                      "FILE(f@)"
                                      "|"
                                      "DONE(d!)"
                                      "KILL(k@)")
                            (sequence "[ ](T)"
                                      "[-](S)"
                                      "[?](W)"
                                      "|"
                                      "[X](D)")
                            (sequence "|"
                                      "OKAY(o)"
                                      "YES(y)"
                                      "NO(n)"))))

C-c C-p (the behaviour does not occur when only loading Vanilla Doom)
Make test.org and insert a todo topic with schedule
(org-agenda nil "a")
Go to topic
(org-agenda-todo "FILE")
Press n to get to wanted state

System information:
pastebin link

I tracked it down to (add-hook 'post-command-hook 'org-add-log-note 'append) in org-add-log-setup in org.el, where post-command-hook is (gcmh-register-idle-gc winner-save-old-configurations sp--post-command-hook-handler evil-repeat-post-hook org-add-log-note). org-add-log-note is only called after the prompt.
This is where I am stumped however since I don't know how to step through only this specific post-command-hook with edebug_

So after updating both Emacs and Doom a few times in the last few weeks this no longer occurs and works just as intended.


Display possible subcommands for non-leaf nested subcommands

When using nested subcommands, the generated help doc does not list subcommands for any non-leaf subcommand whose distance from a leaf is > 1.
For example, given a sub command structure
foo
└── a
    └── one
        ├── blue
        └── red

The this command correctly enumerates subcommands in the SUBCOMMANDS section in the help doc
foo a one --help

But these commands do not
foo --help

foo a --help

I just ran into this.

/bounty $75

/attempt #113

Can you show how a desired output should look like?


Should implement RFC draft for health check

The health check module should implement the RFC draft for health check.
The latest official version of the draft can be found here: https://datatracker.ietf.org/doc/html/draft-inadarei-api-health-check-06
To participate in the development of the draft: https://github.com/inadarei/rfc-healthcheck/
For an example of a Python library that implements the Health Check API: https://github.com/Colin-b/healthpy

I'm going to read the draft later on. THanks @christianhujer ! :)

1. Add right mime type

Health Check Response Format for HTTP APIs uses the JSON format
described in [RFC8259] and has the media type "application/
health+json".

Reference: https://datatracker.ietf.org/doc/html/draft-inadarei-api-health-check-06#section-3
2. Add status field on response

status: (required) indicates whether the service status is acceptable
or not.  API publishers SHOULD use following values for the field:

"pass": healthy (acceptable aliases: "ok" to support Node's
Terminus and "up" for Java's SpringBoot),
"fail": unhealthy (acceptable aliases: "error" to support Node's
Terminus and "down" for Java's SpringBoot), and
"warn": healthy, with some concerns.

Should we follow recommendation? Should we allow custom? As it's SHOULD, we probably should allow custom...
Reference: https://datatracker.ietf.org/doc/html/draft-inadarei-api-health-check-06#section-3.1
3. Validate input status

The value of the status field is case-insensitive and is tightly
related with the HTTP response code returned by the health endpoint.
For "pass" status, HTTP response code in the 2xx-3xx range MUST be
used.  For "fail" status, HTTP response code in the 4xx-5xx range
MUST be used.  In case of the "warn" status, endpoints MUST return
HTTP status in the 2xx-3xx range, and additional information SHOULD
be provided, utilizing optional fields of the response.

We should probably validate the MUSTs here i.e. not allow the user to add 400 on "pass", even if it's obvious.
Reference: https://datatracker.ietf.org/doc/html/draft-inadarei-api-health-check-06#section-3.1
4. Version ?

version: (optional) public version of the service.

Should we use FastAPI(version=...) here? Even if it's optional, should it really be optional? If yes, should we make the default the FastAPI.version? I'd say "yes" for the questions here... But allow disabling/using another version.
Reference: https://datatracker.ietf.org/doc/html/draft-inadarei-api-health-check-06#section-3.2
5. Add releaseId callable

releaseId: (optional) in well-designed APIs, backwards-compatible
changes in the service should not update a version number.  APIs
usually change their version number as infrequently as possible, to
preserve stable interface.  However, implementation of an API may
change much more frequently, which leads to the importance of having
separate "release number" or "releaseId" that is different from the
public version of the API.

We should probably add a callable to retrieve this value. If callable provided, releaseId will be on the response, otherwise the field will not be available. If callable result is None, should we send the releaseId? I would say yes, to make every response follow the same pattern. But I'm open here.
Reference: https://datatracker.ietf.org/doc/html/draft-inadarei-api-health-check-06#section-3.3
6. Add notes field

notes: (optional) array of notes relevant to current state of health

I need to think about this. Should we give power to the user or have fastapi-health give a summary by itself? Should we have this field at all?
Reference: https://datatracker.ietf.org/doc/html/draft-inadarei-api-health-check-06#section-3.4
7. Add serviceId

serviceId (optional) is a unique identifier of the service, in the
application scope.

Add a str field, if None, don't provide.
Reference: https://datatracker.ietf.org/doc/html/draft-inadarei-api-health-check-06#section-3.8
8. Add description

description (optional) is a human-friendly description of the
service.

Add a str field, if None, don't provide.
Reference: https://datatracker.ietf.org/doc/html/draft-inadarei-api-health-check-06#section-3.9
9. Output ?

output: (optional) raw error output, in case of "fail" or "warn"
states.  This field SHOULD be omitted for "pass" state.

Need to think about it.
Reference: https://datatracker.ietf.org/doc/html/draft-inadarei-api-health-check-06#section-3.5
10. Add checks object

checks (optional) is an object that provides detailed health statuses
of additional downstream systems and endpoints which can affect the
overall health of the main API.  Please refer to the "The Checks
Object" section for more information.

Reference:

https://datatracker.ietf.org/doc/html/draft-inadarei-api-health-check-06#section-3.6
https://datatracker.ietf.org/doc/html/draft-inadarei-api-health-check-06#section-4

11. Links ?

links (optional) is an object containing link relations and URIs
[RFC3986] for external links that MAY contain more information about
the health of the endpoint.  All values of this object SHALL be URIs.
Keys MAY also be URIs.  Per web-linking standards [RFC8288] a link
relationship SHOULD either be a common/registered one or be indicated
as a URI, to avoid name clashes.  If a "self" link is provided, it
MAY be used by clients to check health via HTTP response code, as
mentioned above.

Need to think about it.
Reference: https://datatracker.ietf.org/doc/html/draft-inadarei-api-health-check-06#section-3.7
12. Security concerns

Clients need to exercise care when reporting health information.
Malicious actors could use this information for orchestrating
attacks.  In some cases, the health check endpoints may need to be
authenticated and institute role-based access control.

Maybe use a dependency to validate the usage of the endpoint - allowing the client to choose the best authentication method.
Reference: https://datatracker.ietf.org/doc/html/draft-inadarei-api-health-check-06#section-6
13. Cache control ?

Health check responses SHOULD be assigned a freshness lifetime
(e.g., "Cache-Control: max-age=3600") so that clients can
determine how long they could cache them, to avoid overly frequent
fetching and unintended DDOS-ing of the service.  Any method of
cache lifetime negotiation provided by HTTP spec is acceptable
(e.g.  ETags are just fine).

Need to think about it.
Reference: https://datatracker.ietf.org/doc/html/draft-inadarei-api-health-check-06#section-9

I'll have to introduce break changes to be compliant with the draft, or introduce a new structure to handle the draft.
I'll probably opt for the latter. Add HealthRoute and a deprecation warning on the health sounds reasonable. I'd like to maintain the basic usage as simple as possible, but I may have to enforce some output from the condition callables.

Most of the implementation can be found here: https://github.com/Kludex/fastapi-health/pull/11/
I'll finish it tomorrow. Feedback is welcome in the meantime.

Any updates on that? Did you manage to finish the implementation as of now?

I'm going to check this week. I have a week off from work. :eyes:

I've merged #16.

I'll continue to work on it in the following days. I'll need to add a documentation as well.


Review and update content on the publications page

This issue dealt with copy-edit review. Continued changes and additions suggested in new issues, such as #188


Merge workshop/lib functionalities into main branch

@jason-fries any thoughts on this?  Still relevant?  Can chat about offline too


Problem: the lib is crashing when trying to parse the FIXME string.

Solution: optional int parsing

+1

Steps to reproduce:
Search last.fm with Track query:
Collection results = Track.search("The Police", "Mother", 10, LAST_FM_API_KEY);
Expected results:
An empty or non empty collection returned from search.
Actual results:
The following stacktrace:
INFO: Post body: method=track.search&limit=10&track=Mother&artist=The+Police&api_key=xyz
java.lang.NumberFormatException: For input string: "FIXME"
at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
at java.lang.Integer.parseInt(Integer.java:580)
at java.lang.Integer.parseInt(Integer.java:615)
at de.umass.lastfm.MusicEntry.loadStandardInfo(MusicEntry.java:207)
at de.umass.lastfm.Track$TrackFactory.createItemFromElement(Track.java:697)
at de.umass.lastfm.Track$TrackFactory.createItemFromElement(Track.java:694)
at de.umass.lastfm.ResponseBuilder.buildCollection(ResponseBuilder.java:70)
at de.umass.lastfm.ResponseBuilder.buildCollection(ResponseBuilder.java:61)
at de.umass.lastfm.Track.search(Track.java:216)

...

I have verified adelnizamutdinov's fix by consuming a release (https://github.com/kgilmer/lastfm-java/releases/tag/0.1.3) with it into my project via jitpack.

I'm still not sure how I include your solution to my project. :(

@AnujDutt2701 use https://jitpack.io/#adelnizamutdinov/lastfm-java/827407b4e2

@adelnizamutdinov I still get the same error.

Any other fix that may be available for this? I'm stuck at the moment,

Thanks for this fix, merging this now finally.
I believe an easier fix for this issue would be to replace the whole definition with just boolean streamable = "1".equals(s); so feel free to update this PR later.


[FR]: Change Category to predefined category

Is your feature request related to a problem? Please elaborate.
I'm using cross-seed and with seasons and sonarr it gives issues, because it will be added to qbt before it's fully imported and changed from Category to Post-Import Category
what results in to that you have for example 5 seasons that sonarr thinks it needs to import.
now the dev from cross seed made a work around that that works if you use the same download location for the both categories.
it reuses the current category and adds .cross-seed at the end to it.

Describe the solution you'd like
option that qbit manage changes the category to a predefined category
example:
cat:
  movies-hd: /data/.torrents/movies/hd
  movies-uhd: /data/.torrents/movies/uhd
  Radarr-HD.cross-seed: /data/.torrents/movies/hd
  Radarr-UHD.cross-seed: /data/.torrents/movies/uhd
  movies-hd.cross-seed: /data/.torrents/movies/hd
  movies-uhd.cross-seed: /data/.torrents/movies/uhd
# This changes the category to another category.
# usage: old-category: new-category
# WARNING: if the paths are different and Default Torrent Management Mode is set to automatic the files could be moved !!!
change-cat:
  Radarr-HD.cross-seed: movies-hd
  Radarr-UHD.cross-seed: movies-uhd
  movies-hd.cross-seed: movies-hd
  movies-uhd.cross-seed: movies-uhd

Does your solution involve any of the following?

[X] New config option
[ ] New command option

Describe alternatives you've considered
Manual change the category :(
Who will this benefit?
People use Cross-Seed and like a organized library
and other people with their own use case for what ever reason
Additional Information
No response

This is added in develop. Please see updated sample config on how to use this function. It will automatically run on --cat-update
https://github.com/StuffAnThings/qbit_manage/blob/dddafaf0ed6b736d5fc9418a1894809551ea0ba0/config/config.yml.sample#L40-L47


Can't connected wifi

I can't connect to wifi The settings are correct: ssid and password api key. All time is connected to WIFI "myssid" preloader goes to the end and shows Connected to WIFI "myssid" and so nothing else is displayed all the time. Wifi data entered in the settings and esp8266 file manula connect wifi and the connection does not work. In console i have this :
`Connecting to WiFi P4 2G/44FCWXRC
.Connected...Initializing touch screen...
ISR not in IRAM!
User exception (panic/abort/assert)
Abort called

stack>>>

ctx: cont
sp: 3ffffed0 end: 3fffffc0 offset: 0000
3ffffed0:  3ffe89ba 00000000 55002e2e 4020c9f1
3ffffee0:  000000fe 00000000 00000000 00000000
3ffffef0:  00000000 00000000 00000000 00ff0000
3fffff00:  5ffffe00 5ffffe00 3ffe89ae 00000000
3fffff10:  00000002 00000005 3ffe8534 4020b12a
3fffff20:  40100526 00000000 002e2e2e 4020b13c
3fffff30:  3ffef71c 00000000 3ffe8534 4020b645
3fffff40:  00000000 3ffef768 3ffe8f3f 4020970c
3fffff50:  40209700 3ffef768 3ffe8f3f 3ffef894
3fffff60:  3fffdad0 000000ff 3ffe8534 4020b6f4
3fffff70:  3fffdad0 3ffef768 3ffe8534 402056dd
3fffff80:  3fffdad0 3ffef768 3ffef518 40201d39
3fffff90:  feefeffe feefeffe feefeffe feefeffe
3fffffa0:  3fffdad0 00000000 3ffef854 4020ab2c
3fffffb0:  feefeffe feefeffe 3ffe858c 40100e45
<<<stack<<<
ets Jan  8 2013,rst cause:2, boot mode:(3,6)
load 0x4010f000, len 3456, room 16
tail 0
chksum 0x84
csum 0x84
va5432625
~ld
16
`

I am having exact the same issue... And this happened after an update. Not a brand new installation. Before that it was running. My Arduino IDE as well as all libraries are absolutely up to date. There must be an error in the code

Earlier versions of the IDE allowed an interrupt service routine to not reside in IS RAM, so this is why the issue is occurring, if your downgrade to a an IDE version maybe 2.4.2 it will be OK until the source code is modified to include the IRAM prefixes, actually I thought they had been updated, are you sure you have the latest source code?

The issue title is "Can't connected wifi". Yet the console log apparently says
Connecting to WiFi P4 2G/44FCWXRC
Connected...

So, no, WiFi connection is not an issue.

actually I thought they had been updated

Yes, they have. If folks bothered to read the documentation linked in the README, particularly https://docs.thingpulse.com/guides/wifi-color-display-kit/#install-libraries, they wouldn't have this issue.


Post search (editor)

ref https://github.com/bm-sms/daimon-news-misc/issues/173

一通り実装とテストが終わったので、どなたかレビューお願いしたいです！ 🙇

@ryota-sasabe
Sorry to my late :<
I'll review this PR soon.
Can you rebase to resolve conflict?

If you don't want to include Post#bodyin search condition, I think using AR may simplify code than using Groonga.
How do you think about this?

The specification is good for me 👍
I think it is simple, small and useful.
@ryota-sasabe
We left some comments here, can you confirm it?

Could you display the number of search results?
It is useful to know the number of posts specified query (such as how many posts do a category have?)

If the number of search results is large, numerical values are displayed under pagination, so I thought that it could be substituted.
Is that okay with that?

I fixed the points pointed out, so please review again. :bow:

I left some comments, however  I think this PR is totally AWESOME ✨
I'll merge & deploy when you update my points 🚀

AWESOME 🐦


Widget Sleepstatus: fix potential crash

Crash happened when trying to edit this widget with the Widget Editor

Thanks - although honestly w should be defined all the time, so if this fails in the widget editor, it's the editor that really needs fixing :)

... so I'm not sure we should really merge this - I'm sure there are a bunch of other widgets out there that will fail too. Best to fix where draw is called and ensure it gets called correctly

I will have a look at the Widget Editor code.


Update library_polymerase FOR HODGKINS 2023

adding AccuPrime™ Taq DNA
to be 100% clear this is for Hodgkins 2023, not Caruana
Pull Request
This PR is for a

[ ] New Publication(s)
[ ] Correction

For the following list(s):

[ ] ancientmetagenome-environmental (README)
[ ] ancientmetagenome-hostassociated (README)
[ ] ancientsinglegenome-hostassociated (README)

New Publication
Publication Information
This pull request is to add samples from the following publication(s):
This is to close
Checklist

[ ] Publication is published (preprints currently not accepted)?
[ ] Checked the publication is not already in the database?
[ ] Checked samples in this publication are not previously published data (newly re-sequenced metagenomes are OK!)?
[ ] Samples are shotgun metagenomes (hostassociated-singlegenome may also contain whole-genome enriched data)?
[ ] Checked the list follows conventions as described in the corresponding sample type's README file (e.g. using ERS/SRS accession codes for ENA/SRA)?
[ ] Changelog is updated to include the publication under 'Added'?
[ ] Pull request has passed validation checks (see automated comment from github-bot)?
[ ] Review requested from @SPAAM-community/ancientmetagenomedir?
[ ] (If applicable) Made a separate PR to add new categories to controlled lists (stored under /assets/enums, e.g. material or archive)? If so the corresponding PR is here:

I see you (correctly) adjusted the HotStar one - make sure that it's update din the table too for whichever study it's used in

Can you please merge this, this action is blocked for me.


Testing: upgrade HTML to identify mis-cased anchors

Closes #238
The version of HTML Proofer that we were using wasn't identifying situations where internal links were broken because of uppercase characters in all-lowercase links (or other variations of case errors).  This upgrades just our testing libraries (i.e. Jekyll is not upgraded) to get a new version of HTML Proofer that does verify correct casing.
You can generate the same dependency changes as in this PR by running the following command on master:
bundle update -g testing

If you don't run the above command but you do have this PR in your history (e.g., it's been merged to master), you can update your dependencies by running:
bundle install

You can verify that incorrect casing is detected by running make with the upgraded HTML Proofer version by with the first commit in this PR dropped (as it fixes a previously-undetected incorrectly cased link).

ACK 837b731bd7501aa6cf14a1867d6a514c3513866e. Thanks Dave!


Add support for Siri Shortcuts for starting and stopping trips

This enables a couple of things:

Make all trip modes available to the Siri Shortcuts app for multi-step shortcuts
Donate the correct shortcut every time a trip is started and stopped so that Siri can analyze when you start and stop trips and provide smart suggestions for starting and stopping trips
Shortcuts should use custom intents so they can run in the background and not have to launch the app.

@aaronpk I have the Shortcuts and Donations working, and am working on the custom Intent handler. This will introduce some added complexity to the app though, so I want to make sure this is something you're cool with. A Siri Intent is an extension which runs in a different process. That means the SQLite database will need to be stored in an App Group rather than within the primary app, allowing for both the app and the extension to communicate with it.

Whoa, this is very cool. I haven't used siri suggestions so I didn't even know this was possible. I'd be open to changes with the app group stuff to make this work!

Awesome, sounds good! I'll finish up my work on it then, and do some testing and then open the PR 👍

I would like this too!

Would be way cool. 👍

Sounds good. I’m hoping to get this merged in at some point. My iOS development has slowed because my work laptop (which can only be used for official work stuff, which this is not) is the only Mac I really have access to currently. Once I get my Mac issues resolved, this is one of the first iOS things I’m gonna wrap up 🙂

Shoot, I wish I could help on that -- I see from your profile you are just up the road a piece.  The "snow storm" closed the schools down here in the commonwealth.  Let me know your apple ID and I can at least Apple Pay Cash you a coffee.
Thanks again

Follow up: I'd still love this. Ideally with the iOS 13 "shortcuts with parameters" actions we'd have one shortcut with "start XYZ tracking" where we could set the kind of tracking inside the Shortcut, and also a Shortcut to check if a session is running. This would also hook into Shortcuts automations, so when you start an outdoor walk workout on your Apple Watch it could start a walk in Compass.

Very late to the party, I know, but I would really like something like this if it were to be possible.

Are people still interested in this?

Yes!

Are people still interested in this?

Very definitely!

I'm planning to prototype this over the next week or so.  Will report back.

This would be s great addition! I say this because Overland currently drains too much battery, which is obviously expected with the setting I have. But most of the time, I am at work or at home. And overland is still running in the background and draining battery.
If we have shortcut support, I can automate Overland to stop recording when I arrive at home/work, and resume as soon as I leave that area. Would definitely save a lot of battery.

My prototyping has turned into a bit of a deeper exploration into a more fully featured app.  But still plan to bring this and a couple of other features to overland

Any updates on this?
Would be great to be able to start and stop the logging for example based on carplay connection. I'm only interested in tracking my drives with the car. Without this my battery is draining for nothing.

I have a bunch of it working in a standalone app.

Can you elaborate a bit more on that please?


bug report: shell completion doesn't work with sub-commands v3-alpha4

Checklist

[x] Are you running the latest v3 release? The list of releases is here.
[x] Did you check the manual for your release? The v3 manual is here. Could not find the manual, link points to 404
[x] Did you perform a search about this feature? Here's the GitHub guide about searching.

What problem does this solve?
If fixed, shell completion of sub-commands should work same as v2. For example:
mycli sub1 --generate-shell-completion

Instead of calling/ completing sub1 command the cli executes the action of sub1.
The issue is here https://github.com/urfave/cli/blob/v3.0.0-alpha4/help.go#L448-L455.

--generate-shell-completion is popped from arguments slice when checkShellCompleteFlag is run for mycli
In next recursive execution of Run for sub1 function checkShellCompleteFlag returns false as there is no --generate-shell-completion

Solution description

A separate recursive function is needed to find the last sub-command in chain.
If argument slice contains --generate-shell-completion the the last sub-command directly should be invoked for completion as it doesn't need chaining
Else Run should continue with existing steps

If the solution correct, I will try to provide a PR for this

@yogeshlonkar This issue is present only in v3. If you look at v2 the shellComplete flag is set in context which is used to check later on. If you can add the flag back into context that would be great

@yogeshlonkar try this fix and see if it helps


Add support for hand velocities (with patched server)

Forwards the velocity of both hands to the server rather than a zero vector. Has no effect unless the alvr-streamer server has been patched to forward hand velocities to SteamVR.

LGTM


Added Project Section

Issue Title: Add Project Section
Issue Number: #15
Close #15
Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x] I have commented on my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy-to-understand README.md
[x] The Project Section works well on different devices.

A small Description of the project :
Description:
This pull request enhances the functionality of the "Project Section"  in the HTML document by adding smooth scrolling behavior and dynamic visibility based on the user's scroll position. Here are the key changes:
CSS:
Improved the styling of the button for better user experience.
Added a smooth transition effect on hover to make the button more interactive.
JavaScript:

Added a click event listener to the "Github" button.
When clicked, the page now smoothly Works
These enhancements provide a smoother and more user-friendly experience for navigating the webpage.

Here is the Video Illustration of the Feature:
https://github.com/divyanshudhruv/Minifolio/assets/129049677/4aff7886-a524-400f-86ae-e414ef445262
Screenshots

@divyanshudhruv Check This Sir..

@divyanshudhruv ?

@Kapileswar-Moharana  Ok

Please change the merging branch to divyanshudhruv:changes

@divyanshudhruv How can i change the branch to "divyanshudhruv:changes"

@divyanshudhruv How can i change the branch to "divyanshudhruv:changes"

Aur Please Jldi Batao..


Readme : add note re ansible v2, and spelling

Added a note for ansible 2.x users (as was raised in #1), and some minor spelling updates.

@scottjbarr thank you


Mention link to doc in github readme

For most of the packages a link to the documentation is given in the short readme on the github-page. I expected the same for dpf-core. As it was not mentioned I asumed there is no further documentation available ^^ Only found the link on the left side today. Maybe you could add a link in the readme like its done for pymapdl or dpf-post.

Thanks @akaszynski  👍


Removed legacy ML.NET clustering tutorial

The new tutorial is already live: #521 and dotnet/docs#9620 are merged to live.
So, the old one can be removed.
/cc: @JRAlexander

Thanks, @pkulikov!


Add .gitignore to cache directory

Closes #195

Great, Thanks!

Renamed variable for consistency.

Should it be added to changelog?

yes, let's add a changelog

@karpetrosyan, how does it look?

@karpetrosyan, how does it look?

lgtm 🎉


KNL-1419 Only send notifications to site members.

If a user is a member of the global review realm and has the content.all.groups permission then they get all notification message even if they aren't actially a member of the site. This prevents non-site members from ever getting a notification.

LGTM


make startTransaction typings return a Promise

Judging from my experience when working with the startTransaction function, and from the documentation, I believe startTransaction returns a Promise that resolves to a Transaction, and not the actual Transaction itself.
Docs mentioning startTransaction, where it is awaited:

https://vincit.github.io/objection.js/api/model/static-methods.html#static-starttransaction
https://vincit.github.io/objection.js/guide/transactions.html#creating-a-transaction

Coverage remained the same at 97.06% when pulling bf1245a615a525a087d19eada9f7a56055babd13 on JReinhold:patch-1 into 8967382e081943d3154234ff17bae4f2166e94f8 on Vincit:master.

Thank you! I've fixed this in 2.1.2. Your PR had errors so I couldn't merge it.


Add support for delay variance and loss/reorder correlations

tc allows setting a variance ± on the delay option.
Additionally, both loss and reorder support correlation, which helps better simulate real-life packet burst loss / delays.

https://wiki.linuxfoundation.org/networking/netem

Thank you for contributing!


Error when bulk inserting into a table for an entity with ignored properties

I have an entity with certain properties in an owned type that are not mapped to the database (by specifying builder.Ignore() in fluent API). Trying to bulk insert into the entity's table I receive the error
Input array is longer than the number of columns in this table.
I think I found the problem in SqlBulkOperation.GetDataTable: When creating the DataTable the EF mapping information is used to obtain the list of ownedEntityProperties:
var ownedEntityProperties = ownedEntityType.GetProperties().ToList();
ownedEnttiyType is of type Microsoft.EntityFrameworkCore.Metadata.IEntityType. Accordingly, ignored properties are not included in ownedEntityProperties.
When filling the actual data into the DataTable created, however, the PropertyInfo array obtained via System.Reflections is used. Thus, the properties ignored in the mapping are added as well which results in the error described above.
I think I was able to fix this problem and will try to create a pull request soon.

I have accepted your pull request but then changed(simplified) the fix.
Could you test if new NuGet 2.2.0 works for your case.
I have tested it with this structure and it passes:
public class ChangeLog
{
    public int ChangeLogId { get; set; }

    public string Description { get; set; }

    public Audit Audit { get; set; }
}

[Owned]
public class Audit
{
    public string ChangedBy { get; set; }

    [NotMapped]
    public DateTime? ChangedTime { get; set; }
}

Thank you very much for merging my fix! Unfortunately, with NuGet Package 2.2.2 I still get an error in my program:
System.ArgumentException: Input array is longer than the number of columns in this table.
at System.Data.DataTable.NewRecordFromArray(Object[] value)
at System.Data.DataRowCollection.Add(Object[] values)
at EFCore.BulkExtensions.SqlBulkOperation.GetDataTable[T](DbContext context, IList1 entities, SqlBulkCopy sqlBulkCopy)    at EFCore.BulkExtensions.SqlBulkOperation.Insert[T](DbContext context, IList1 entities, TableInfo tableInfo, Action`1 progress)
The same program works fine with the fork I created for my pull request.

Sorry, I deleted my previous comment which stated that the problem persists because I thought I had made a mistake when testing the new release. But after a second test, I can confirm the issue is still there. Unfortunately, my model is quite complex and not suited for a short example.
One difference to your example, however, is that I have ignored properties in the parent class and in the owned types. So maybe adding a [NotMapped] Property to ChangeLog might reproduce the problem.

I have found the difference.
It was due to fact that my condition for excluding Ignored properties is based on [NotMapped] attribute and you say that you have configured it with .Ignore()` in FluentAPI.
Try now version 2.2.3

Thanks a lot! Version 2.2.3 works fine with my program! I didn't know it makes a difference whether the mappings are defined using attributes or the FluentAPI, sorry. Thanks again for your great support!


Implement exhaustive event handling for Fiber/Script-based Entity Threads

Our current approach for event handling is to capture a single eligible event object in one pass, then handle the event in a once-per-frame 'step' of the Entity Thread. -- Instead, we should provide the ability to handle multiple events in a single frame, updating scripts as events are dequeued, rather than deferring the work.
Threads using this exhaustive approach could then use
co_await next_frame;

or similar, if this exhaustive capturing behavior was not intended. -- e.g. to prevent handling multiple input events on a single frame.

Implemented initial support for this. We'll need to revisit this when script coroutines become scheduled, rather than executing on the main thread.


test: add test for ESLint v9

close #183

@ota-meshi https://github.com/eslint-community/eslint-utils/blob/0c21af5e9ece98a1232dc9d4729d93b20f8d2bc5/package.json#L68

Any plan to release a new version?

This doesn't just add a test, it also fixes compatibility, right?

I think it's already compatible with v9 (>=8.0.0).
If you use the pre-release, you only need to force install it. Or do you think we also have to do a pre-release?

Opened a separate PR for allowing ESLint 9 pre-releases, as that's what's needed for eg. @fisker to be unblocked with eslint-plugin-unicorn: https://github.com/eslint-community/eslint-utils/pull/206
I will review this one separately as its about testing to ensure that we actually work as expected with it, which as you say @ota-meshi we should be 🙂


[Event Hubs] Changes to adopt newer implementation of OperationTimeoutError handling

Based on work being done as part of #4171, while we have decided on direction to make OperationTmeoutError retryable. We decided to have changes in for at least EventHubs before concluding #4171  in order to verify handling of all affected usecases.
This issue is based off of changes from #4171 and is used to track changes required in EventHubs to update the various operations and decisions, conclusion around it.
Once this concludes, depending on complexity involved, we can move ahead to update Service Bus accordingly as well.

Based on investigation done for #2891 (If OperationTimeoutError is to be retryable or not), some conclusions have been captured at https://github.com/Azure/azure-sdk-for-js/issues/2891#issuecomment-509338705 that are applicable to identifying what are the affected operations that need to be updated.
Current efforts to test changes in EventHubs would help with it as well.

It is now known that using this approach and ensuring that Event Hubs and Service Bus can continue to work as expected is not trivial.
Based on current bandwidth, we don't have time to explore this approach at the moment.
There are talks about having a pipeline for amqp libraries just like we do for http, in which case retry policy and implementations will be re-visited and re-factored at which point it would be expected for the retry() to implement its own timer.
Therefore, closing this issue.


Why is fzf control t significantly slower when using fd?

Checklist

[X] I have read through the manual page (man fzf)
[X] I have searched through the existing issues
[X] For bug reports, I have checked if the bug is reproducible in the latest version of fzf

Output of fzf --version
0.56.2 (brew)
OS

[ ] Linux
[X] macOS
[ ] Windows
[ ] Etc.

Shell

[ ] bash
[X] zsh
[ ] fish

Problem / Steps to reproduce
i'm a bit surprised that using fd in FZF_CTRL_T_COMMAND seems to make fzf control + t much slower
https://github.com/user-attachments/assets/41497f89-e917-4a57-a60b-0d4b7ff5e9a8
$ export FZF_CTRL_T_COMMAND=''

$ <control + t>
# instant
  2369/2369 (0) ───────────────

$ export FZF_CTRL_T_COMMAND='fd  --type file --strip-cwd-prefix --hidden'

$ <control + t>
# noticeable lag here

$ fd  --type file --strip-cwd-prefix --hidden | fzf
# running control t command on its own and piping to fzf gives instant results

sidebar, fzf is an incredible tool, thanks so much for creating, sharing, and maintaining this!

I can't reproduce the problem.  I'll try doing this again on a fresh shell setup to isolate the issue

You can try something like env -i PATH=$PATH bash --noprofile --rcfile <(fzf --bash)

not able to reproduce on a fresh shell, must be specific to my setup, will keep investigating and report back eventually

Thanks, I'll close this for now.

ok was able to reproduce it, this was due to the fact that i had a slow running process in my .zshenv.
# my zshenv
sleep 10

for some reason, this affects the control t command only if we set an alternative FZF_CTRL_T_COMMAND.

ok was able to reproduce it

Thanks for digging through. I was able to reproduce it as well.
When FZF_CTRL_T_COMMAND is set, the command is executed with $SHELL -c …, in
your case with zsh -c ….

[!NOTE]
The only file you can alter which is started with every zsh (unless you use the -f option) is .zshenv,
Source: Z-Shell Frequently-Asked Questions

The .zshenv file typically includes options, environment variables, and
occasionally small functions[^1], usually without noticeably affecting
performance.

for some reason, this affects the control t command only if we set an alternative

If you add the --with-shell 'zsh -fc'[^2][^3] flag to your FZF_CTRL_T_OPTS,
the issue should not occur.
[^1]: Fzf cannot find a function configured as FZF_ALT_C_COMMAND · Issue #3743 · junegunn/fzf · GitHub
[^2]: fzf/CHANGELOG.md 0.51.0
[^3]: If a script altered the PATH, it might use a different zsh version, so
it's better to specify the full path, see list below.
```bash
# Depends on whether your 'SHELL' is defined (echo $SHELL).
--with-shell "$SHELL -fc"

# Works most of the time, but will return the alias if there is one for 'zsh'.
--with-shell "$(builtin which zsh) -fc"
# Same as above.
--with-shell "$(command -v zsh) -fc"

# Seems to be the most reliable way to always use your intended 'zsh' version.
--with-shell "$(command which zsh) -fc"

# 'zsh' specific, see 'man' pages on the syntax
# man 1 zshmodules | less -p "THE ZSH/PARAMETER MODULE"
--with-shell "${commands[zsh]} -fc"
# man 1 zshexpn | less -p "=' expansion"
--with-shell "$(printf =zsh) -fc"
```

first, this is a fantastic answer, thanks for all the effort here on both the explanation and solution. learned a bit here.

the command is executed with $SHELL -c …

curious, i notice the more files in the directory, the slower this process is. i would intuitively expect a command executed in $SHELL -c ... to pay a one time cost in setting up the shell, so it would be equally slow independent on the number of files. but at least observationally it doesn't seem to be the case. full disclosure—my issue is totally solved now from the information you gave me, i'm just curious here.


Fallback for external functions

Add fallback for external functions
based on:
https://github.com/inkle/ink/blob/master/Documentation/RunningYourInk.md#fallbacks-for-external-functions
It is now possible to implement a dummy/error function for each external
functions. It must have been the same name and same number of arguments
and will be executed if the external function was not bind when needed.
IF the external functions will get bind later, then it will be called
the next time.
Introduces new flag: FALLBACK_FUNCTION to add a new execution
dimension
Introduce new value type: ex_fn_not_found to signal failed external

Was merged with #49

Was merged with #49


大佬按步骤做的 没成功 alist是先前已经部署好的 就把那部分删掉了 这是啥原因

2024/06/01 16:10:21 [emerg] 1#1: unknown directive "js_shared_dict_zone" in /etc/nginx/conf.d/plex.conf:9
2024/06/01 16:10:22 [emerg] 1#1: unknown directive "js_shared_dict_zone" in /etc/nginx/conf.d/plex.conf:9
2024/06/01 16:10:22 [emerg] 1#1: unknown directive "js_shared_dict_zone" in /etc/nginx/conf.d/plex.conf:9
2024/06/01 16:10:23 [emerg] 1#1: unknown directive "js_shared_dict_zone" in /etc/nginx/conf.d/plex.conf:9
2024/06/01 16:10:24 [emerg] 1#1: unknown directive "js_shared_dict_zone" in /etc/nginx/conf.d/plex.conf:9
2024/06/01 16:10:26 [emerg] 1#1: unknown directive "js_shared_dict_zone" in /etc/nginx/conf.d/plex.conf:9
2024/06/01 16:10:29 [emerg] 1#1: unknown directive "js_shared_dict_zone" in /etc/nginx/conf.d/plex.conf:9
2024/06/01 16:10:36 [emerg] 1#1: unknown directive "js_shared_dict_zone" in /etc/nginx/conf.d/plex.conf:9
2024/06/01 16:10:49 [emerg] 1#1: unknown directive "js_shared_dict_zone" in /etc/nginx/conf.d/plex.conf:9
2024/06/01 16:11:15 [emerg] 1#1: unknown directive "js_shared_dict_zone" in /etc/nginx/conf.d/plex.conf:9
2024/06/01 16:12:06 [emerg] 1#1: unknown directive "js_shared_dict_zone" in /etc/nginx/conf.d/plex.conf:9
2024/06/01 16:13:06 [emerg] 1#1: unknown directive "js_shared_dict_zone" in /etc/nginx/conf.d/plex.conf:9
2024/06/01 16:14:06 [emerg] 1#1: unknown directive "js_shared_dict_zone" in /etc/nginx/conf.d/plex.conf:9
2024/06/01 16:15:07 [emerg] 1#1: unknown directive "js_shared_dict_zone" in /etc/nginx/conf.d/plex.conf:9

nginx 内置的 njs 版本低了
需要 > 0.8.0，直接 nginx:latest 即可
This directive appeared in version 0.8.0.
https://nginx.org/en/docs/http/ngx_http_js_module.html#js_shared_dict_zone

2024/06/02 07:58:13 [notice] 1#1: using the "epoll" event method
2024/06/02 07:58:13 [notice] 1#1: nginx/1.26.1
2024/06/02 07:58:13 [notice] 1#1: built by gcc 13.2.1 20231014 (Alpine 13.2.1_git20231014)
2024/06/02 07:58:13 [notice] 1#1: OS: Linux 5.13.x
2024/06/02 07:58:13 [notice] 1#1: getrlimit(RLIMIT_NOFILE): 1024:4096
2024/06/02 07:58:13 [notice] 1#1: start worker processes
2024/06/02 07:58:13 [notice] 1#1: start worker process 19
2024/06/02 07:58:13 [notice] 1#1: start worker process 20
2024/06/02 07:58:13 [notice] 1#1: start worker process 21
2024/06/02 07:58:13 [notice] 1#1: start worker process 22
我换了个镜像 然后显示这个 试了下远程播放 没成功


APIs POST/PATCH error response is not conforming to other endpoint error responses

Summary
When you make a POST request to /consumers without any data provided you will get back a hash of field: error-message response:
POST /consumers/

{
  "custom_id": "At least a 'custom_id' or a 'username' must be specified",
  "username": "At least a 'custom_id' or a 'username' must be specified"
}

Doing the same request on /apis returns a non-conforming response where it is instead "message": error-message:
POST /apis/

{
  "message": "at least one of 'hosts', 'uris' or 'methods' must be specified"
}

The /consumers response is preferable due to the potential of multiple fields having errors.
Steps To Reproduce

POST /consumers
POST /apis
Compare

Additional Details & Logs

Kong version (0.10.1)
OS (macOS)

I do think that generic message is useful as well. In to POST /apis case none of hosts, uris or methods are wrong by per se, so it might not be correct to mark them all with red in UI for example, but generic message before those fields is alright.
The self_check and custom field validators are also something bit of a pain. E.g. with POST things like hosts, uris, or methods is needed, but with PATCH you can actually remove them. That is actually alright, and maybe we could consider if that self_check is needed at all there.

closing based on @nijikokun feedback.


Add a maintainer file for each package

This isn't that urgent (i.e. enhancement rather than bug) and only useful for meta purposes and should not interfere with the package manager. But I think we can add a maintainer file for clarity (who gets to maintain this package? and who should we, as in users, contact in case shit hits the fan?)
I know we can check who committed first to the package (i.e. a simple git log without options), but as you can see, git's own git log is not very reliable for this. You have to dig into git blame each file, but that won't work if the file/commit is overwritten.
For example, bspwm which I originally submitted has the first git log commit attributed to you (just check git log $DIR_TO_COMMUNITY/bspwm or GitHub's own history), so if we take this at face value, you're the one maintaining this package, not me. This also can work as an additional "commitment" by the maintainer of the respective packages should one wants to submit one's own package.

For example, bspwm which I originally submitted has the first git log commit attributed to you

This is only due to the repository split no?

For example (berry added after the split):
commit ef36a72e61b5ddd1adce605c54736cdf7df333e6
Author: Cliford Sab<EMAIL_ADDRESS>Date:   Sat Sep 21 11:46:39 2019 +0800

    berry: bump to 0.1.3

commit 2644e848b024846eb39ed15678571f52fdc88b8d
Author: Cliford Sab<EMAIL_ADDRESS>Date:   Sun Sep 15 23:06:40 2019 +0800

    berry: new package at 0.1.2

Oh right. I think so. So it won't really affect new packages.
So, what would happen to the old packages, then? If you're fine with leaving it as is then I'm good.

Old packages will be listed under my name until each maintainer pushes
a new commit if and when their packages require a change or have an
update.
On 9/21/19, M. Herdiansyah<EMAIL_ADDRESS>wrote:

Closed #29.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/kisslinux/community/issues/29#event-2652057573


user_id fields in the messages table is always set to the model's ID regardless of who sent the message

Describe the bug
The user_id field in the messages table is always set to the model's ID.
To Reproduce
When you scrape the messages between a user and a model, the user_id in the messages table in user_data.db is always set to the model's id, no matter who sent the message.
Expected behavior
Messages in the messages table should have their user_id field set to whoever sent the message.  So any messages i've sent to a model should have my user_id and any sent to me by a model should have their user_id. This is the behaviour of Digital Criminal's script.

fixed with
https://github.com/datawhores/OF-Scraper/commit/de035d2591c795392cb79b33193f2aedf2a51b7e


Makefile bugfix

Running $(MAKE) in the make target with concurrency >1 can cause multiple make instances to download the same tools/ dependencies at the same time. This results in vaulty files and broken tests.
These $(MAKE) calls were introduced in https://github.com/cert-manager/cert-manager/pull/6749.
Kind
/kind bug
Release Note
NONE

/retest

/retest

/retest

/retest

/approve


Add refresh_interval every 15 minutes

Without an event catcher we should refresh relatively frequently.  Also
deleted the unused inventory_object_refresh setting since this is always
true now

Kasparov backport details:
$ git log -1
commit 1a61ebb3ad7e26121cd8e009c4d885b2735725c4
Author: gregoryb-at-ibm<EMAIL_ADDRESS>Date:   Sun Nov 22 10:45:05 2020 +0200

    Merge pull request #45 from agrare/add_refresh_interval

    Add refresh_interval every 15 minutes

    (cherry picked from commit 2816fd852ace25919a6b0f3fcf25cfeabb9c1d62)


Skip flaky tests in the Slack notification

What does this PR do?

Skip flaky tests in the Slack notification
Motivation

The notification currently also print the flakes, example:

This test is in fact flaky and did not make the job fail (the other one did)
https://github.com/DataDog/datadog-agent/blob/0d39c837ce789bdd039632a85e9b0929ede31af6/comp/dogstatsd/server/server_test.go#L82-L85
Additional Notes

Tested with CI_PIPELINE_ID=41214170 deva notify.send-message -n merge --dry-run
Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


[enhancement] adding a release

Please can you add a release for this app so we can download it compiled

I am currently working on other projects but I intend to release a WinForm and WPF version sometime in the future.


[un] homepage update

update homepage according to mocks

This is looking great, Jennifer!
Some mobile overflow finds (iphone 12 pro screen size)

thanks for the reviews

Thank you! last thing found some mobile overflow in the top section


Add Write clausal core / traces and support io.Writer interface

In this pull request I have added:

WriteClausalCore
WriteCompactTrace
WriteExtendedTrace

All 3 of these methods accept io.Writer, and will internally feed that to the FILE pointer required by the picosat C API
Additionally, Print() has been updated to also accept io.Writer.

I'm intrigued by the idea of using an io.Writer instead of an os.File. We just need to be careful to ensure that the pipes are always getting closed. (I'm sure you did that -- this comment will serve as a note to myself to look for that when I'm reviewing your code, whenever I get to it.)
As always, awesome work. Look forward to reading and testing. Thanks again!

Good catches on both points. Sorry about that.
I overlooked the race condition, only thinking about acquiring the locks
for the UNSAT check. I've fixed that to acquire the lock once for the
entire time.
You were also correct that I missed one case of closing the pipe. The read
side was always closed, but because the write side of the pipe was being
closed at a specific moment to signal the goroutine reader to finish, I
overlooked that there was a case where the write pipe would not be closed
if the cfdopen() call failed and bailed early. I've added a defer close to
the write pipe to make sure both sides are no closed no matter what, when
the function scope finishes.
On Thu, Feb 26, 2015 at 4:36 AM William Schwartz<EMAIL_ADDRESS>wrote:

I'm intrigued by the idea of using an io.Writer instead of an os.File. We
just need to be careful to ensure that the pipes are always getting closed.
(I'm sure you did that -- this comment will serve as a note to myself to
look for that when I'm reviewing your code, whenever I get to it.)
As always, awesome work. Look forward to reading and testing. Thanks again!
—
Reply to this email directly or view it on GitHub
https://github.com/wkschwartz/pigosat/pull/13#issuecomment-75981761.

Working on a pull request to merge into your pull request at https://github.com/wkschwartz/pigosat/tree/write-traces. Will submit as a pull request to your fork soon.

This is an old topic but what was the status of this merge? I just got back to looking at some old code.

@justinfx It turns out I had gotten part way through some edits to this last summer. I have some commits I'd like to add to this PR. I believe you can hit Edit on the PR and click "Allow edits from maintainers" to allow me to post this commits to this branch. I'll have a few more commits to make, but I'd like you to have an opportunity to discuss the changes before I merge them, as this PR was your idea.
Some more things I want to look at

[ ] Shorten up some more of the doc strings and minimize the amount of Picosat's documentation we borrow
[ ] Verify correctness of Cgo interface (I think Cgo has changed something about the way C and Go pass pointers since two versions ago when this was first written)
[ ] Be more consistent with how we handle Null pointers (should probably return nils to Go?)

Again, that to do list is just stuff I want to look at. I don't have a real opinion about them yet until I get a chance to look at it.

Fixed! And yea they tightened up the rules about passing pointers that contains pointers to cgo. But from what I have experience so far, you immediately get compilation errors when you have that situation. You are still allowed to pass pointers as long as they stay alive for the duration of the call and don't also contain pointers.

Still getting permission denied errors. Will try again in a few hours. In
the mean time you can take a look at my "assumptions" branch.
On Sunday, September 25, 2016, Justin Israel<EMAIL_ADDRESS>wrote:

Fixed! And yea they tightened up the rules about passing pointers that
contains pointers to cgo. But from what I have experience so far, you
immediately get compilation errors when you have that situation. You are
still allowed to pass pointers as long as they stay alive for the duration
of the call and don't also contain pointers.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/wkschwartz/pigosat/pull/13#issuecomment-249446333,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABWiFQLcHheR7sro2u7Ax9MPFYZzY0cuks5qtuCkgaJpZM4Dlbuk
.

--
William Schwartz
cell:<PHONE_NUMBER>

In case we got wires crossed, I also allowed edits on #12

Oh now I see why I was confused. My mistake! Thanks!
On Sunday, September 25, 2016, Justin Israel<EMAIL_ADDRESS>wrote:

In case we got wires crossed, I also allowed edits on #12
https://github.com/wkschwartz/pigosat/pull/12
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/wkschwartz/pigosat/pull/13#issuecomment-249447227,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABWiFSh3tDVC00bZVv-h5dKejvyGuBYDks5qtuSkgaJpZM4Dlbuk
.

--
William Schwartz
cell:<PHONE_NUMBER>

After some confusion on my part about how to close files in cFileWriterWrapper, I now have everything compiling, and the code looks pretty clean at this point, I think.
Two test failures left (TestPrint works), copied below. I'll come back to this tonight or Wednesday, but maybe you can have a think about it first.
--- FAIL: TestWriteClausalCore (0.00s)
	pigosat_test.go:476: Test 1: Expected Unsatisfiable clausal core to start with 'p cnf'; got {"" '\x00' "\x00\x00\x00\x00" "\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00" '\x00'}
	pigosat_test.go:476: Test 4: Expected Unsatisfiable clausal core to start with 'p cnf'; got {"" '\x00' "\x00\x00\x00\x00" "\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00" '\x00'}
	pigosat_test.go:476: Test 6: Expected Unsatisfiable clausal core to start with 'p cnf'; got {"" '\x00' "\x00\x00\x00\x00" "\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00" '\x00'}
	pigosat_test.go:476: Test 7: Expected Unsatisfiable clausal core to start with 'p cnf'; got {"" '\x00' "\x00\x00\x00\x00" "\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00" '\x00'}
=== RUN   TestWriteTrace
--- FAIL: TestWriteTrace (0.00s)
	pigosat_test.go:500: Test 1: Unsatisfiable formula to produced no compact trace
	pigosat_test.go:514: Test 1: Unsatisfiable formula to produced no extended trace
	pigosat_test.go:500: Test 4: Unsatisfiable formula to produced no compact trace
	pigosat_test.go:514: Test 4: Unsatisfiable formula to produced no extended trace
	pigosat_test.go:500: Test 6: Unsatisfiable formula to produced no compact trace
	pigosat_test.go:514: Test 6: Unsatisfiable formula to produced no extended trace
	pigosat_test.go:500: Test 7: Unsatisfiable formula to produced no compact trace
	pigosat_test.go:514: Test 7: Unsatisfiable formula to produced no extended trace

I actually didn't write this to use the goroutine for performance reasons.
If I recall correctly, it was to prevent a case I was hitting where the
write to the pipe was blocking because no one was reading on the other end.
The goroutine starts a read right away and drains the pipe. I'm remembering
writing and testing this code and seeing no output until I did this. Can
you confirm you tested this change and saw output?
On Tue, 27 Sep 2016, 4:43 AM William Schwartz<EMAIL_ADDRESS>wrote:

@wkschwartz commented on this pull request.
In pigosat.go
https://github.com/wkschwartz/pigosat/pull/13#pullrequestreview-1562828:

defer p.ready(true)()

if Status(C.picosat_res(p.p)) != Unsatisfiable {

return errors.New("expected to be in Unsatisfiable state")

}

return cFileWriterWrapper(f, func(cfile *C.FILE) error {

// void picosat_write_extended_trace (PicoSAT *, FILE * trace_file);

_, err := C.picosat_write_extended_trace(p.p, cfile)

return err

})
+}

+// A wrapper to take an io.Writer interface and feed it
+// the output from picosat functions that specifically
+// need a *C.FILE
+func cFileWriterWrapper(w io.Writer, writeFn func(*C.FILE) error) (err error) {

I got rid of the goroutine and error channel because I felt like it
added complexity to a part of the code that I suspect won't ever be the
speed bottleneck. Let me know if you disagree.
I tried to catch errors that come out of all the files we need to
close here.
wp and cfile now both close after the read from rp. From what I
can tell reading the documentation https://golang.org/pkg/os/#Pipe,
there's no need to flush, sync, or close the write end of the pipe before
reading from the read end of the pipe. I'm not sure we need to flush or
close cfile for all of cfile's content to make it into wp, but I
suspect we don't. Thoughts?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/wkschwartz/pigosat/pull/13#pullrequestreview-1562828,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AARPxhC8TkYCxpyWHwGY_gx6AypkNHzaks5qt-gEgaJpZM4Dlbuk
.

http://man7.org/linux/man-pages/man7/pipe.7.html
The parts about a write blocking if the kernel bugger is full is why I did the read in the goroutine and also probably the reason you are getting those test failures. I had the problem at first too where I wasn't getting the output because the read copy never succeeded. Pipe(7) says you shouldn't rely upon platform specific buffer sizes and should read as soon as possible or the write can block if the buffer fills with no reader.

You're absolutely right. My bad.
I just pushed a commit that adds a test for this blocking behavior. The test fails on the current version of the code. I tried switching back to your original goroutine algorithm, but the test is still failing. I'll take another crack at it later. In the meantime, let me know if you see anything wrong with the test.

I found the cause of the failures. Three things are needed:

The change to cfdopen() where the err != nil is causing "Error calling WriteClausalCore: illegal seek" errors for me in the tests. Research into the problem has shown me that checking the error when a valid pointer was returned is causing the problem. When I changed it to simply check cfile == nil and then return the err, it worked again...

At this point I am now blocking on TestCFileWriterWrapper. When I reverted the logic back to reading in a goroutine, this stopped blocking.

Now I am back to that garbled output from the traces. When I added back in the C.fflush(cfile) after the succesfull write, I get the proper expected output and the tests pass related to the usage of cFileWriterWrapper

This was where I discovered the hint about reading the error from a succeeded fdopen(): http://comp.unix.programmer.narkive.com/g4gxgYP4/fdopen-cause-illegal-seek

Hopefully this fixes it. I haven't had your problem number 1 but I'm happy to take your word for it because checking whether cfile == nil fits with the documentation anyway. I take it you're running Linux?
As for 2 and 3, I put back your goroutine code and the fflush call.
All the tests pass for me. Take a look and tell me if I missed anything. I'm going to give everything another once-over and if we're both happy, I'll merge.

I take it you're running Linux?

Ya, I first tested this on my linux box at work, and saw the error right away. It is possible I might not have seen this if I tried it at home on osx
I see you have added back the reading of the pipe in the goroutine, but placed it after the write call. Wouldn't this defeat the purpose? We would want to start the reader before we call write, otherwise write can block and never return.
	// We have to read from the pipe in a separate goroutine because the write
	// end of the pipe will block if the pipe gets full.
	errChan := make(chan error)
	go func() {
		_, e := io.Copy(w, rp)
		errChan <- e
	}()

	if err = writeFn(cfile); err != nil {
		wp.Close()
		return err
	}

Beyond that, I only have one remaining comment. We might want to use a buffered channel here for the read of the pipe:
	errChan := make(chan error, 1)

Because if we were to error and bail out early before <-errChan at the end of the function, we would leak a goroutine. But if we buffer it to a size of one, we expect to only put one return value in there and it will allow the goroutine to finish no matter what.

Seems like you covered everything I could possibly think of! Awesome. Happy with this when you are. Thanks for the work!!

Again, you're right. I updated the tests to detect the first issue (the order of the goroutine/write calls). I can imagine a test that would cause the channel blocking/goroutine leaking issue, but I don't know how to test for a leaked goroutine.

Yay! Thanks for all of that hard work.


d3 format transfer minus(-) to ascii 8722 code

except transfer -8888 to -8,888, I found that d3 format transfer the minus(ascii 45) to an unexcepted code which ascii code is 8722
except -8,888
actual −8,888
u can pick the minus to compare

This works correctly with a "minus sign" character, which is not the same as the minus operator; see https://www.compart.com/en/unicode/U+2212

This works correctly with a "minus sign" character, which is not the same as the minus operator; see https://www.compart.com/en/unicode/U+2212

I know it's difference between Hyphen-Minus and Minus Sign. But I can't understand why should use Hyphen-Minus which may make excel cell calculate error. or can u provide a optional parameter for users to choose freely?
Additionally, I found some popular number format dependencies and make a demo. u can found the difference between d3 format and other utils.
https://codesandbox.io/p/sandbox/d3format-x2shz3?file=%2Fsrc%2Findex.mjs

We use a minus sign because it is the better typographical choice. d3-format is for formatting numbers for human consumption, not for Excel calculations. Why not use a different library if you want a hyphen minus?


Multiple code quality fix-1

This pull request is focused on resolving occurrences of Sonar rules
squid:S2864 - "entrySet()" should be iterated when both the key and value are needed.
squid:S1066 - Collapsible "if" statements should be merged.
You can find more information about the issues here:
https://dev.eclipse.org/sonar/rules/show/squid:S2864
https://dev.eclipse.org/sonar/rules/show/squid:S1066
Please let me know if you have any questions.
Faisal Hameed

@faisal-hameed,
It looks good, but could you please have a look at my comments? Thanks!

@carlspring Ok, I will rename variables.

@carlspring changes done.

:+1: Many thanks for the fix!


Vaccination QR-Code isn't equal to scanned vaccination code (EXPOSUREAPP-7416)

Parameterise Qr-Code error correction level

As this bug was newly introduced in 2.3 it would be nice to get it in to 2.3, not sure why the ticket has 2.4 as fix version :/ Do you think it's possible without a lot of work?


A task was canceled - Reconnect error at ExchangeClientCredentials

Hello all,
unfortunately, from time to time we receive the following error
The request was canceled due to the configured HttpClient.Timeout of 100 seconds elapsing., A task was canceled., A task was canceled.

at System.Net.Http.HttpClient.HandleFailure(Exception e, Boolean telemetryStarted, HttpResponseMessage response, CancellationTokenSource cts, CancellationToken cancellationToken, CancellationTokenSource pendingRequestsCts)
   at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
   at <StartupCode$Pulsar-Client>.$TokenClient.ExchangeClientCredentials@47.MoveNext()
   at <StartupCode$Pulsar-Client>.$AuthenticationOauth2.newToken@100.MoveNext()
   at Pulsar.Client.Auth.OAuth2.AuthenticationOauth2.GetAuthData()
   at <StartupCode$Pulsar-Client>.$ConnectionPool.clo@136-31.MoveNext()
   at <StartupCode$Pulsar-Client>.$ConnectionPool.clo@130-30.MoveNext()
   at <StartupCode$Pulsar-Client>.$BinaryLookupService.FindBroker@61.MoveNext()
   at <StartupCode$Pulsar-Client>.$ConnectionHandler.-ctor@48-37.MoveNext(),
   at System.Threading.Tasks.TaskCompletionSourceWithCancellation`1.WaitWithCancellationAsync(CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.GetHttp11ConnectionAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)
   at System.Net.Http.DiagnosticsHandler.SendAsyncCore(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
   at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
   at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)

"exceptions": [
      {
        "Depth": 0,
        "ClassName": "System.Threading.Tasks.TaskCanceledException",
        "Message": "The request was canceled due to the configured HttpClient.Timeout of 100 seconds elapsing.",
        "Source": "System.Net.Http",
        "StackTraceString": "   at System.Net.Http.HttpClient.HandleFailure(Exception e, Boolean telemetryStarted, HttpResponseMessage response, CancellationTokenSource cts, CancellationToken cancellationToken, CancellationTokenSource pendingRequestsCts)\n   at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)\n   at <StartupCode$Pulsar-Client>.$TokenClient.ExchangeClientCredentials@47.MoveNext()\n   at <StartupCode$Pulsar-Client>.$AuthenticationOauth2.newToken@100.MoveNext()\n   at Pulsar.Client.Auth.OAuth2.AuthenticationOauth2.GetAuthData()\n   at <StartupCode$Pulsar-Client>.$ConnectionPool.clo@136-31.MoveNext()\n   at <StartupCode$Pulsar-Client>.$ConnectionPool.clo@130-30.MoveNext()\n   at <StartupCode$Pulsar-Client>.$BinaryLookupService.FindBroker@61.MoveNext()\n   at <StartupCode$Pulsar-Client>.$ConnectionHandler.-ctor@48-37.MoveNext()",
        "RemoteStackTraceString": null,
        "RemoteStackIndex": 0,
        "HResult": -2146233029,
        "HelpURL": null
      },
      {
        "Depth": 1,
        "ClassName": "System.TimeoutException",
        "Message": "A task was canceled.",
        "Source": null,
        "StackTraceString": null,
        "RemoteStackTraceString": null,
        "RemoteStackIndex": 0,
        "HResult": -2146233083,
        "HelpURL": null
      },
      {
        "Depth": 2,
        "ClassName": "System.Threading.Tasks.TaskCanceledException",
        "Message": "A task was canceled.",
        "Source": "System.Private.CoreLib",
        "StackTraceString": "   at System.Threading.Tasks.TaskCompletionSourceWithCancellation`1.WaitWithCancellationAsync(CancellationToken cancellationToken)\n   at System.Net.Http.HttpConnectionPool.GetHttp11ConnectionAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)\n   at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)\n   at System.Net.Http.DiagnosticsHandler.SendAsyncCore(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)\n   at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)\n   at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)",
        "RemoteStackTraceString": null,
        "RemoteStackIndex": 0,
        "HResult": -2146233029,
        "HelpURL": null
      }
    ]

Unfortunately, we are unable to reproduce the error consistently. It occurs intermittently, typically when there is a network problem or the authentication server is unavailable. Most clients (both consumers and producers) are able to reconnect automatically, as expected. However, some clients remain stuck in the error message mentioned above, resulting in an infinite loop. In such cases, it becomes difficult to identify that the consumer, for example, is no longer able to establish a connection. Moreover, the error only generates a warning. It occurs every minute because there is a one-minute delay before each retry attempt. Unfortunately, authentication always fails during these attempts.

Regarding the issue, we suspect that either the HttpClient is being disposed or the task is being completed, causing the call to the OAuth server to be canceled directly. However, our knowledge of F# is limited, so we would appreciate your assistance in identifying and resolving the problem. You can find the relevant code snippet at this location: GitHub link.
Currently, the only workaround is to restart the entire Kubernetes pod, after which everything returns to normal.
We will continue our efforts to reproduce and resolve the issue. Once we have more information, we will provide updates. If you require any further assistance, please let us know.

@danny-krueger Hi, thank you for reporting, could you please share the .NET version you use

Anyway, I've commited the change (using IHttpClientFactory), if you could verify this somehow before I published a Nuget package, this will be helpful

Hi @Lanayx, thank you for the prompt response. We frequently use .NET 6.0, but occasionally we also use .NET 7.0.
We will try it out, but we need some time to test it.

We have now intensively tested the new variant with IHttpClientFactory. After our testing last weekend, everything looks very good. Can you please create a release from this and provide the new version?

Ready https://www.nuget.org/packages/Pulsar.Client/2.13.0


Create customized hook then put "exec < /dev/tty" into it for user input but not work as expected

Hi team,
Maybe I should mark this issue as feature request? I create my own hook terraform_plan locally for the purpose to review all the changes before commit. My idea is to check if things defined in main.tf are ok through this hook, then user input yes or no. If yes, pre-commit will pass otherwise pre-commit will fail.
To achieve this, I add exec < /dev/tty in this hook. The snippet looks like this. I create this hook based on terraform_fmt.sh.
function per_dir_hook_unique_part {
  local -r args="$1"
  # shellcheck disable=SC2034 # Unused var.
  local -r dir_path="$2"

  # add PROJECT_ID and APPLICATION_DEFAULT_CREDENTIALS here (dynamically)
  project_id=$(gcloud config get-value project)
  credentials=$(gcloud secrets versions access latest --secret="application-default-credentials")

  echo "PROJECT_ID: ${project_id}"
  echo "CREDENTIALS: ${credentials}"
  terraform plan -var "PROJECT_ID=${project_id}" -var "APPLICATION_DEFAULT_CREDENTIALS=${credentials}"

  exec < /dev/tty
  read -p "Do you agree this plan? (Y/N): " answer
  echo "answer: ${answer}"
...

I expect that the output of terraform plan ... and the prompt Do you agree this plan? (Y/N) should appear before I can enter my answer. But actually nothing shown and it just hangs there waiting for the input.

Until I give an input "Y", every output string defined in this hook (ex: output string through echo, terraform plan) comes out.

Do you think this is an issue? or anything else I miss or wrong?
Thanks.

Do you think this is an issue?

That's by GIT design: https://github.com/observing/pre-commit/issues/62
You may want to try to redirect tty directly into read like this https://stackoverflow.com/a/45495062/5093149
(the exec thing seemingly should do the work too, though since it fails you, it's worth to try the read ... < /dev/tty approach maybe)

I try read ... < /dev/tty but still not work. I think it should not be a bug from this repo but related to pre-commit? So far I'm not very sure what the root cause is..

but related to pre-commit?

It's even not pre-commit but GIT: it doesn't expect hooks to use standard input.
Also there might be some another culprit somewhere on the way granted read ... < /dev/tty didn't work for you 🤔 Maybe try and simplify your hook as much as possible for testing, replace everything with just a few lines of code to echo and read input, turn on trace output (set -x), an so on — since others report redirecting tty works for them, there might be something we don't see here.
Please let us know the outcome of your findings.

A few notes:

Success tf plan does not mean that you will get success with tf apply
In most cases tf plan takes much time, which violates the idea of "quick check before committing". That's can be a problem when you'll try to force usage of this hook across the team.
This hook needs interaction with the user which is unusual for pre-commit users, but let it be
This hook doesn't automate any checks, it's more likely ask folks to see tf plan output

tf plan is not much different from tf validate. Also, you are already able to check remote API by tflint with --deep option, much quicker than run tf plan

By the way, it still can work for your case, but I highly recommend to check https://github.com/terraform-linters/tflint-ruleset-google/blob/master/docs/deep_checking.md


Current month disappear after changing to next month (only after minification)

Current month disappear when switching to next month

When switching twice to previous month, the name of the current month overlap the previous one.

After investigation, I found that the slideLeftNew and slideRightNew persist on the span element instead of being removed.

Your Environment

flatpickr v2.6.3
Gulp task runner
Babel transpiler
cssnano as minifier
Chrome/ Firefox
Windows 7

I can confirm, I get the same behaviour.

I think I found the source of problem, after minification the events animation name's are changed as you can see here:

I get a slightly different variety of this error, even with @irjayjay's fix applied.
v 3.0.6 -  Webpack-minified through Laravel-mix.
Screenshots without the fix applied.
First opening Flatpickr:

After changing month once:

After changing month several times:

Hello,
This seems like more of an issue with minifiers than flatpickr.
For cssnano, you need to set the safe option to true.
I use uglifyjs for minified builds without problems using default settings.
If you still run into problems, please feel free to re-open the issue.

@MarkVesterskov did you find a way to solve the problem? I have the exact same problem of changed event names, as you stated. I'm using Laravel Mix (a webpack wrapper), with Laravel 5.4

@OmathiasO Nope, for now i dont have any fix for it - my app is still in development, so i havn't bothered too much trying to fix it.
My best guess regarding Laravel Mix (thich i also use) would be to copy the webpack.config.js to your root directory, and add the safe-option @chmln mentinoned to override the default config.

@irjayjay's solution worked for me but this is a legit issue and should be re-opened. Like @OmathiasO, I am also getting this with Laravel Mix (on Laravel 5.4).

Same issue here, I disabled cssnano & uglifyjs completely. And the issue is still there.

I found this un-documented option:
https://github.com/chmln/flatpickr/blob/0d44cdf9c9d1af5dd48b1ba88e2f74ce238c7054/src/types/options.ts#L135
It fix the issue for me (by removing all the animations).
flatpickr(classElement, {
    animate: false,
});

:wave:

To fix this I had to specify reduceIdents: false in the postcss options for cssnano in my Grunt file (cssnano docs)

I can confirm the issue still exists in latest version, and @damienalexandre's fix is epic!


Compiler thinks array.push() doesn't change length

In the code below, the compiler sees the comparison of array.length against 0 and the return statement, and then assumes that comparison remains true even after the array is mutated, presumably based on the logic that "if we get past the return statement this means that array.length is 0 (forever)".
When we modify the array (e.g. by appending items to it, or calling some other mutating functions like pop or splice), the compiler still thinks the length is 0 and generates an error when the code tries to compare the length with anything else.
The output of the program at runtime is what you would expect:
Contains one element
[ 'test' ]

TypeScript Version:  3.8.2
Search terms: array, array.push(), array.pop(), array.splice(), array.length, properties mutation, property narrowing, array mutation, TS2367
Code
function test(array: string[]): void {
    if (array.length !== 0)
        return;
    array.push("test");
    if (array.length === 1) {
        console.log("Contains one element");
    }
}

function main(): void {
    const values: string[] = [];
    test(values);
    console.log(values);
}

main();

Expected behavior:
No compile errors.
Actual behavior:
Compile error:
sample.ts(5,9): error TS2367: This condition will always return 'false' since the types '0' and '1' have no overlap.
Another example
More generally, it appears that the control flow analysis is not aware of the fact that method calls can modify the object on which they are called.
class Counter {
    public value: number = 0;
    public increment(): void {
        this.value++;
    }
}

function inc(c: Counter): void {
    if (c.value !== 3) {
    }
    else {
        c.increment();
        if (c.value === 4) {
        }
    }
}

Expected behavior:
No compile errors. The compiler should recognise that a method which it does not know to be pure is being called on the object, and invalidate any assumptions it holds about the value of the object's properties.
Actual behavior:
sample.ts:13:13 - error TS2367: This condition will always return 'false' since the types '3' and '4' have no overlap.
Playground Link:
https://www.typescriptlang.org/play/?ts=3.8-Beta#code/GYVwdgxgLglg9mABFApgZygCgIYCdfYCeAXIhrjGAOYDaAugJSkBucMAJogN4BQi-iGMEQ58RAHQAbFNSgALRAEIAvMsQAGBnwE7cKKCFxgA3Nv54ChcQAcQaOZgBEqDI4amdQkRYnTZC1TUARi0dHQgENDhpKTgqJwBhBChsSjREBBREFGkAWxkoN1MAXx4eCLAMRGZsSRB0UnJKWjpENXpTFywauvR3csjolFj4nvq0fqA
Related Issues:
None

Exact duplicate of #35795 for details see #9998


Once the nodes get disks, all related replica managers will be recreated and engine image will become state deploying. But client cleanup function won't wait for the creation complete and engine image becoming state ready.
In the following test cases, the client will try to create and attach volumes with deploying engine image. Then error out.

Solution:
Add engine image reset in client cleanup function.

Merged, wait for the nightly test.

Didn't see the error in nightly test so far.


[BUG] New Homepage Featured Blog Post Does Not Always Show Author Name

Describe the bug
The newly released homepage "Featured Blog Posts" preview element displays author name + Twitter handle. Depending on what content is featured the author name does not always appear leaving an empty space before a "|" followed by the @OpenSearchProj Twitter handle.
To Reproduce
Steps to reproduce the behavior:

Go to https://opensearch.org/ on a desktop browser at full width (the component collapses into something else responsively for smaller device screens).
Scroll down to Featured Blog Posts
Observe that the featured blog post may, or may not show an author name. At this moment the "Exploring OpenSearch 2.10" post is featured written by James McIntyre, but James's name is not appearing.

Expected behavior
Author name should always appear.

Resolved in https://github.com/opensearch-project/project-website/pull/2309


Error: unable to claim interface: LIBUSB_ERROR_ACCESS

I successfully compiled master df1ac74 on my intel macos 10.15.7 and receive the following:
./fluxengine read mac
Reading from: :d=0:s=0-1:t=0-79
Using GreaseWeazle with serial number GW0101717747431232004E4B52
Error: unable to claim interface: LIBUSB_ERROR_ACCESS

Debugging so far I attempted to run as root with no change, unloaded all non-apple kexts. Ran as root with no change (via sudo and su -).
When the device is plugged in I see devices under /dev (cu.usbmodem14301 & tty.usbmodem14301)
I am able to read with gw and fluxengine on my windows 10 PC, so the hardware side seems fine. I am able to read disks via gw on my mac.
Using a STM32F1 bluepill with adapter board. Flashed with gw 0.22.
Hopefully I didn't just miss something obvious, and thanks for the great software.

It looks like the OSX serial driver is claiming the device, preventing the FluxEngine client from accessing it<EMAIL_ADDRESS>

It appears I 10.15.x does not have the driver mentioend in that article
$ sudo kextunload -b com.apple.driver.AppleUSBFTDI
(kernel) Kext com.apple.driver.AppleUSBFTDI not found for unload request.
Failed to unload com.apple.driver.AppleUSBFTDI - (libkern/kext) not found.

I was able to find that driver mentioned here https://ftdichip.com/drivers/vcp-drivers/ and was able to install it/load it: sudo kextload -b com.FTDI.driver.FTDIUSBSerialDriver
But I can not unload any Apple ones - the one coordenate that looks to be the one (though I am guessing) fails:
sudo kextunload -b com.apple.driver.usb.serial
(kernel) Can't remove kext com.apple.driver.usb.serial; services failed to terminate - 0xdc008018.
Failed to unload com.apple.driver.usb.serial - (libkern/kext) kext is in use or retained (cannot unload).

The names do not match what 10.15 has. There is no specific Apple FTDI or Serial USB drivers I can see that I are able to be  unload:
$ kextstat | grep -i Serial
   88   10 0xffffff7f80f6c000 0xe000     0xe000     com.apple.iokit.IOSerialFamily (11) 549F5E3F-1A70-34C7-B631-1B6C260A5273 <8 7 6 5 3 1>
  133    2 0xffffff7f845c1000 0x2e000    0x2e000    com.apple.driver.AppleOnboardSerial (1.0) 04C224BA-2B2E-3710-9088-F2B580F209ED <88 85 8 6 5 3 1>
  170    0 0xffffff7f84886000 0xa000     0xa000     com.apple.iokit.IOBluetoothSerialManager (7.0.6f8) 7F31357D-6ED1-31C1-B1BB-4F6ECC325A75 <88 8 6 5 3 1>
  189    0 0xffffff7f845f5000 0x7000     0x7000     com.FTDI.driver.FTDIUSBSerialDriver (2.4.4) B137605C-32D8-3E81-89B6-E1F8039FC427 <88 64 6 5 3 1>
  190    1 0xffffff7f846cf000 0x6000     0x6000     com.apple.driver.usb.serial (6.0.0) FC10C12C-E713-344A-A233-F90CEFDBFA84 <88 21 6 5 3 1>

$ kextstat | grep -i USB
   19    2 0xffffff7f80dd2000 0x4000     0x4000     com.apple.driver.AppleUSBHostMergeProperties (1.2) 8BB30FDB-96F5-3EC8-B246-F0C4F91A7562 <5 3 1>
   20    9 0xffffff7f80dd6000 0xe000     0xe000     com.apple.driver.usb.AppleUSBCommon (1.0) B1BAE081-4EBD-3BD2-8699-68CAF8D86C9A <6 5 3 1>
   21   20 0xffffff7f80de4000 0xfa000    0xfa000    com.apple.iokit.IOUSBHostFamily (1.2) 0495ACDF-FE50-3D21-B8F0-0CE099678419 <20 19 18 8 7 6 5 3 1>
   24    1 0xffffff7f8130a000 0x34000    0x34000    com.apple.iokit.IOUSBMassStorageDriver (157.140.1) B996556C-8E44-3CDA-BE58-9E7B66CA396C <23 22 21 13 7 6 5 3 1>
   42    2 0xffffff7f81456000 0x15000    0x15000    com.apple.driver.AppleUSBTDM (489.120.1) A9F252DD-D1DE-3D4E-9DDF-BEF2BEC435F8 <41 36 24 23 22 21 8 7 6 5 3 1>
   62    1 0xffffff7f839a5000 0x58000    0x58000    com.apple.driver.usb.AppleUSBXHCI (1.2) 74B2F241-D11F-35D6-ABF3-4A7F278D879A <21 20 12 8 7 6 5 3 1>
   63    0 0xffffff7f83c5b000 0x35000    0x35000    com.apple.driver.usb.AppleUSBXHCIPCI (1.2) BC4BBC92-050F-31EC-89D0-5B24C92E7996 <62 21 20 13 12 8 7 6 5 3 1>
   64    1 0xffffff7f818c1000 0x99000    0x99000    com.apple.iokit.IOUSBFamily (900.4.2) F778E0DD-D561-32BD-BB0A-A3ACB9F72671 <21 20 13 8 6 5 3 1>
   70    3 0xffffff7f8197e000 0x9000     0x9000     com.apple.driver.usb.AppleUSBVHCICommon (1.0) B73E5C62-32A5-30B6-A017-94CDE09D9BF0 <21 20 8 6 5 3 1>
   71    1 0xffffff7f81987000 0xd000     0xd000     com.apple.driver.usb.AppleUSBVHCICommonBCE (1.0) 403F6F06-1824-3B5D-91FA-ED853D575D60 <70 67 20 8 6 5 3 1>
   72    1 0xffffff7f81994000 0x28000    0x28000    com.apple.driver.usb.AppleUSBVHCI (1.2) 3DBCADE7-0C47-30F7-80F9-52BE8E3BC1E4 <70 21 20 8 7 6 5 3 1>
   73    0 0xffffff7f819c0000 0x4000     0x4000     com.apple.driver.usb.AppleUSBVHCIBCE (1.2) A4363027-002A-3A86-B87A-DC456326FB10 <72 71 70 67 21 20 12 8 7 6 5 3 1>
  106    3 0xffffff7f80eee000 0x8000     0x8000     com.apple.driver.usb.AppleUSBHostCompositeDevice (1.2) F4942637-A6A9-37B8-86A7-34535B0E30C3 <21 20 7 6 5 3 1>
  107    4 0xffffff7f81b8b000 0x8000     0x8000     com.apple.driver.usb.networking (5.0.0) 4FD6761A-BA62-34F0-8810-FBB1DFF57A44 <21 7 6 5 3 1>
  108    3 0xffffff7f82a95000 0x8000     0x8000     com.apple.driver.usb.cdc (5.0.0) 76EE2BFC-2674-324A-8F9F-408A7B949FA8 <107 106 21 6 5 3 1>
  109    0 0xffffff7f82a9d000 0x11000    0x11000    com.apple.driver.usb.cdc.ncm (5.0.0) CC150672-4E2A-3F58-94C3-04670F8DFF0F <108 107 106 32 21 17 7 6 5 3 1>
  189    0 0xffffff7f845f5000 0x7000     0x7000     com.FTDI.driver.FTDIUSBSerialDriver (2.4.4) B137605C-32D8-3E81-89B6-E1F8039FC427 <88 64 6 5 3 1>
  190    1 0xffffff7f846cf000 0x6000     0x6000     com.apple.driver.usb.serial (6.0.0) FC10C12C-E713-344A-A233-F90CEFDBFA84 <88 21 6 5 3 1>
  191    0 0xffffff7f846d5000 0x8000     0x8000     com.apple.driver.usb.cdc.acm (5.0.0) 792BCB82-E6B8-3334-9BA2-2DFE99A25026 <190 108 107 106 88 21 6 5 3 1>
  192    0 0xffffff7f846dd000 0xc000     0xc000     com.apple.driver.usb.cdc.ecm (5.0.0) BA2432F2-3DF0-337F-B359-999261DBD472 <108 107 32 21 19 6 5 3 1>

I'm afraid this is well beyond my knowledge of OSX.
The issue here is that the GW exposes a serial device, which the OS is claiming, and that's preventing the FluxEngine client from accessing it. This isn't a problem on Linux because there, the OS will release the device if a libusb program wants to use it. But that seems not to be the case here, or on Windows. This could all be avoided by talking the GW via the serial device, which is what the GW client does, but that's not easy to do given the FluxEngine client architecture. I'm going to have to work on this.

A bit beyond me here too on OSX. If GW and FE both spoke the same USB protocol then you wouldn't have to switch the drivers back and forth in windows. I may just jump over to linux now as my ultimate goal was to script GW & FE together.