Revert "[SPARK-37733][BUILD] Change log level of tests to WARN"

What changes were proposed in this pull request?

This reverts commit c0cedb136cf807aebe0319ca86175cf8eed8b8b0.
Why are the changes needed?

#35011 changes log level and causes some tests that check log message failed.
Actually #34965 was merged not long ago which fixes logging issue for hive-thriftserver module that produces large log output.
Does this PR introduce any user-facing change?

No
How was this patch tested?

Pass tests.

cc @gengliangwang @HyukjinKwon

Test build #146563 has started for PR 35014 at commit eb46d81.

Codecov Report

Merging #35014 (c0cedb1) into master (c0cedb1) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head c0cedb1 differs from pull request most recent head eb46d81. Consider uploading reports for the commit eb46d81 to get more accurate results

@@           Coverage Diff           @@
##           master   #35014   +/-   ##
=======================================
  Coverage   59.47%   59.47%
=======================================
  Files         202      202
  Lines       39295    39295
  Branches     7481     7481
=======================================
  Hits        23372    23372
  Misses      14752    14752
  Partials     1171     1171

Flag
Coverage Δ

unittests
59.47% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0cedb1...eb46d81. Read the comment docs.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/51038/

Oops sorry my bad

let me merge this since this is a clean revert

Merged to master.

sorry guys. I had to wait for the test results.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/51038/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/51038/

Late LGTM. Thank you @viirya

Test build #146563 has finished for PR 35014 at commit eb46d81.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146563/

thank you @HyukjinKwon @gengliangwang


HTTP Coordinator lookup thunders coordinator with enableLookupSyncOnStartup

io.druid.query.lookup.LookupReferencesManager#loadAllLookupsAndInitStateRef thunders the living hell out of the coordinator on a rolling restart of a bunch of nodes and there is no retry in io.druid.query.lookup.LookupReferencesManager#fetchLookupsForTier
This is when enableLookupSyncOnStartup is enabled

@drcrallen you mean when historicals/peons startup , each of them send one request to coordinator and coordinator is not able to handle that traffic ?
adding @a2l007

Yes, when you have hundreds of nodes and do a rolling update, a lot of them can call back to the coordinator at the same time. It doesn't seem to like that traffic. And it is especially problematic if the coordinator is having GC issues (not believed to be related) at the time causing either a jvm crash or a net disconnect.

ok, that sounds more of a problem of coordinator not handling the load.. however request for getting lookups for a tier from coordinator (/druid/coordinator/v1/lookups/<tier>) is very lightweight so it shouldn't really be troublesome, sounds like problem is somewhere else e.g. true cause of GC. how many jetty threads do you have at coordinator ?
sidenote: yes, I think https://github.com/druid-io/druid/blob/master/server/src/main/java/io/druid/query/lookup/LookupReferencesManager.java#L514 can have some retries and a configurable timeout but that is unrelated . it appears you're having problem on the coordinator node rather than historical/peon nodes. @a2l007 please add retries.

The coordinator should always be counted on to have some form of problem (from a defensive programming standpoint). So I agree a backoff would probably solve or severely reduce the impact of this issue.
Curing the coordinator GC issues is something we are working on.

@himanshug one thing I have NOT been able to investigate is if there's unexpected pinch points in the leadership securing functionality that can be exacerbated with concurrent requests. No hint yet that is possible but I think this is one of the first things that has a heavy concurrent and time sensitive connection to the leader that is attempted.

dev-sync discussion: @leventov to raise PR adding retries with back-off .


tiptop-py: init at 0.2.8

Description of changes
tiptop is a command-line system monitoring tool like top btop htop gotop.
It displays various interesting system stats and graphs them.
https://github.com/nschloe/tiptop
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1364

Now squash the commits into one.


feat: Define trunk through param --trunk/-t or git config mergify-cli.stack-trunk

Change-Id: Id3a796b1f263da2ea5b2c77a6a2f46f305e41261
Depends-On: #160

This pull request is part of a stack:

chore: rename git_push_stack to mergify_cli (#156)
fix: Make worktree compliant (#157)
feat: get token through gh auth token if not provided by --token or GITHUB_TOKEN env var (#158)
fix: convert coroutine to task (#159)
feat: Add control on draft or open status through a param (#160)
feat: Define trunk through param --trunk/-t or git config mergify-cli.stack-trunk (#161)


Limiting cache size per node

Hi,
Let’s say I wish to limit the amount of space I used on local disk per machine. Where do i configure that?

The closest thing you can do, to limit the amount of space used, is to configure LRU (eviction system) config:
	"lru_config": {
		"lowwm":		75,
		"highwm":		90,
		"atime_cache_max":	65536,
		"dont_evict_time":	"120m",
		"capacity_upd_time":	"10m",
		"lru_enabled":  	true
	},

more info: https://github.com/NVIDIA/dfcpub#lru
Hope that helps, if you have any other questions let us know.


Config files updating

Hi again,
Can we use this package or edit it to allow us updating config files.php ?
Il would be better :)
Thanks

Honestly I don't see much use in using PHP as a persistent config store, but you can write your own pretty easily:
<?php

use Sven\FileConfig\Stores\Store;
use Sven\FileConfig\File;

class PhpConfig implements Store
{
    public function __construct(File $file)
    {
        $this->file = $file;
    }

    public function get($key)
    {
        // implementation
    }

    public function set($key, $value)
    {
        // implementation
    }

    public function delete($key)
    {
        // implementation
    }
}

Then you can use like you would normally:
$file = new \Sven\FileConfig\File('/path/to/config.php');

$config = new PhpConfig($file);

$config->set('foo', 'bar'); // true
$config->get('foo'); // 'bar'
$config->delete('foo'); // true

Thanks for quick reply,
I tried your suggestion but I got this error :

Parse error: syntax error, unexpected '='
in File.php (line 25)

It looks like you're running the code with an older version of PHP. This package requires PHP 7.1 oor higher.

my php version :
PHP 7.2.3-1+ubuntu16.04

I think you're not running the code with that version 🙂 The tests pass fine on PHP 7.1, both on my machine locally and on CircleCI. Double-check to make sure your (web)server is using that version of PHP as well.


CP013: Support querying the load factor of an execution context

There was feedback from Jacksonville that it would be useful to be able to query the load factor of an execution context, as to make a decision based on the current load of different contexts.

cut&paste from email thread:

I have been interpreting "concurrency" as a guaranteed-not-to-exceed upper bound, not a promise-to-provide.  When accounting for contention in an algorithm the guaranteed-not-to-exceed is the thing.

The intention for D0796r2 was that  concurrency() would return the maximum number of threads of execution associated with this execution resource, so guaranteed-not-to-exceed. But you raise a good point here that an execution resource may have a potential concurrency of N but an execution resource may not  be able to guarantee that N threads of execution will always be capable of making forward progress at once. I agree that the latter is a property which is more associated with an execution context than an execution resource; the resource reflecting the hardware potential and the context reflecting whats actually available.
I think these two properties should be separated, or at least we need to clarify that concurrency() only states the maximum potential concurrency of the resource. We could also introduce a member function to the context which provides the current concurrency guarantee, i.e. the number of threads of execution currently available. I believe this is related to something which was requested at Jacksonville; the ability to query an execution context for it's current load factor

I don't believe a current concurrency guarantee is feasible.  The number of concurrency resources utilized (or conversely not-utilized) at some instant during the call to the measuring function is probably the best that could be done.


A website!

Current coverage is 94.06% (diff: 100%)

Merging #78 into master will not change coverage

@@             master        #78   diff @@
==========================================
  Files             1          1
  Lines           118        118
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            111        111
  Misses            7          7
  Partials          0          0

Powered by Codecov. Last update cb6c793...4f0fede


[MRG] set_annotation

The remaining failing tests are due this assignation:
https://github.com/mne-tools/mne-python/blob/609515033e9917423aa4005c294a7c64919b21e6/mne/externals/decorator.py#L83
does anyone see a workaround to call set_annotation() here?

Where does that show up as a problem in the tests?

(you can try working around the problem by temporarily renaming all .annotations refs in that file to ._annotations or so, but I'm surprised that's what's breaking things)

@massich this is the code that you need to fix / udpate:
https://github.com/mne-tools/mne-python/blob/master/mne/io/fiff/raw.py#L108

@agramfort can you review / merge this ?

ok please update what's new page in the API section. Thanks

@massich please rebase when updating what's new. It shoudl also fix the circle issue.

Awesome! Now we can actually get started where we left the first week of
January :D
On Fri, Aug 3, 2018 at 4:36 PM Alexandre Gramfort<EMAIL_ADDRESS>wrote:

Merged #4870 https://github.com/mne-tools/mne-python/pull/4870 into
master.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mne-tools/mne-python/pull/4870#event-1770097240, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AB0fiu2PgVJ3w6PbBz_nDd4TRzoyrO5oks5uNF_VgaJpZM4RcNN4
.


Eigen Conversion - Part 2

Same as #232 but rebased on current master.
Conversion Quaternion/Euler isn't yet consistent with the previously used getRPY method

Correct

Q(w,x,y,z) 0.001000 0.008836 0.024367 0.999582
R=
  -0.999516 -0.00156857   0.0177143
 0.00242986   -0.998485   0.0486966
  0.0176168   0.0487319    0.998656
Eigen yaw 3.14002 pitch  0.0487512 roll -0.0176444
matrix
-0.999842 -0.001569 0.017717
0.002430 -0.998810 0.048704 2
0.017620 0.048740 0.998656
getRPY sol1 3.13916 -0.0176206 0.0487667
getRPY sol2 -0.00243063 3.15921 -3.09283

Not Correct

Q(w,x,y,z) -0.003000 0.008836 0.024367 0.999582
R=
 -0.999516 0.00642808  0.0175193
-0.0055668  -0.998485  0.0487672
 0.0178117  0.0486612   0.998656
Eigen yaw 0.00643775 pitch  3.09291 roll 3.12375
matrix
-0.999826 0.006429 0.017522
-0.005568 -0.998794 0.048775
0.017814 0.048669 0.998656
getRPY sol1 -3.13602 -0.0178154 0.0486957
getRPY sol2 0.00556857 3.15941 -3.0929

I went trought the code of the tf and eigen libraries to make sure the quaternion to euler angles transformation are correct.
The rotation matrix definition are the same. In Eigen
R =
1 - (2yy + 2zz), 2xy - 2zw,        2zx + 2yw
2xy + 2zw,       1 - (2xx + 2zz),  2zy - 2xw
2zx - 2yw,       2zy + 2xw,        1 - (2xx + 2yy)

while in the tf package https://github.com/ros/geometry/blob/d718a1f4ff206e5d9196fbc1156293929583bed2/tf/include/tf/LinearMath/Matrix3x3.h#L148
R =
1 - (2yy + 2zz) / d , (2xy - 2zw) / d,        (2zx + 2yw) / d
(2xy + 2zw) / d,      1 - (2xx + 2zz) / d,    (2zy - 2xw) / d
(2zx - 2yw) / d,      (2zy + 2xw) / d,        1 - (2xx + 2yy) / d

where d = xx + yy + zz + ww
If the quaternion length, d, is ~1 , the rotation matrices are the same.
If the tf package getRPY  ( ( https://github.com/ros/geometry/blob/d718a1f4ff206e5d9196fbc1156293929583bed2/tf/include/tf/LinearMath/Matrix3x3.h#L294-L360 ) first the pitch, then roll, then yaw angles are calculated.
Threfore the equivalent in eigen (https://github.com/libigl/eigen/blob/1f05f51517ec4fd91eed711e0f89e97a7c028c0e/Eigen/src/Geometry/EulerAngles.h#L37) is EulerAngles(1, 0, 2)
However the transformations are not yet consistent between the two libraries.

@jkflying there is still some issue with the quaternion/euler conversion. See my previous comment.

@jkflying I reverted to the tf package for the quaternion to euler conversion because it will take me more time to figure out what's wrong.
Sitl Logs: https://review.px4.io/plot_app?log=d03de169-0f6c-4cec-95c7-de02e2231dfd
https://review.px4.io/plot_app?log=16a81856-1681-4798-bf1b-cbc2a7bb6edd

I've SITL tested this, it is behaving the same as current master.
Interestingly, outside of the node itself, toEigen() is not used except for the PCL pointcloud types, and toPoint() is not used at all! Nice work!


Hot Module reloading in vite

Describe the feature
With hot module reloading you don't have to do a full page refresh to view the changes you made in the code. This is quite nice and makes iterating much faster. Pinia supports hot module reloading with code like this:
import { acceptHMRUpdate } from "pinia";

if (import.meta?.hot) {
  import.meta.hot.accept(acceptHMRUpdate(useSomeStore, import.meta.hot));
}

Also see: https://vitejs.dev/guide/api-hmr.html
Is something like this also possible for pinia orm? At the moment every time I change anything about a pinia-orm model it reloads the whole page. Is a hmr like with pinia possible?
Additional information

[ ] Would you be willing to help implement this feature?
[ ] Could this feature be implemented as a module?

Final checks

[X] Check existing discussions and issues.

Good question....it should be possible. But i think this one of the low prio features ^^.

It sounds like it would be quite complicated. Then indeed low priority. I had hoped it might be simple :)

Woah thanks for doing this anyways!


no such table: main.classroom_student__old

This is what happen when I click sign Up button

update your pip, django. and sqlite3.. it will handle.

to which version should I upgrade the pip, Django. and sqlite3


Cannot get plugins when pubspec.yaml contains git url

Hi, I have my own flutter plugin in gitlab and this is a part of my pubspec.yaml.
dependencies:
  flutter:
    sdk: flutter

  # The following adds the Cupertino Icons font to your application.
  # Use with the CupertinoIcons class for iOS style icons.
  cupertino_icons: ^0.1.3
  spotu_auth:
    git:
      url: git@gitlab.com:spotu/flutter/plugin/spotu_auth.git

When I run hover plugins get command to get plugins, I get an error attached below.
I think yaml parser has a problem to parse git url.
Hover doctor
$ hover doctor
hover: Hover version v0.41.5 running on darwin
hover: Sharing flutter version
Flutter 1.17.0 • channel beta • https://github.com/flutter/flutter.git
Framework • revision e6b34c2b5c (10 days ago) • 2020-05-02 11:39:18 -0700
Engine • revision 540786dd51
Tools • Dart 2.8.1
hover: Flutter engine commit: https://github.com/flutter/engine/commit/540786dd51f112885a89792d678296b95e6622e5
hover: Finding out the C compiler version
Apple clang version 11.0.3 (clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin19.4.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
hover: Sharing the content of go.mod
module spotuprofessional/go

go 1.14

require (
	github.com/go-flutter-desktop/go-flutter v0.40.1
	github.com/go-flutter-desktop/plugins/path_provider v0.4.0
	github.com/go-flutter-desktop/plugins/shared_preferences v0.4.3
	github.com/go-flutter-desktop/plugins/video_player v0.0.3
	github.com/pkg/errors v0.9.1
)
hover: Sharing the content of hover.yaml
application-name: ""
executable-name: ""
package-name: ""
license: ""
target: lib/main_desktop.dart
branch: ""
cache-path: ""
opengl: ""
engine-version: ""
hover: Sharing the content of go/cmd
go/cmd/import-path_provider-plugin.go	go/cmd/import-shared_preferences-plugin.go	go/cmd/import-video_player-plugin.go	go/cmd/main.go	go/cmd/options.go

Error output
Using hover plugins get to get plugins, I get the following
error:
hover: failed to parse URL from string %sgit@gitlab.com:spotu/flutter/plugin/spotu_auth.git: parse "git@gitlab.com:spotu/flutter/plugin/spotu_auth.git": first path segment in URL cannot contain colon

hover doesn't support url plugin.
please clone the repo localy, and import it using:
  spotu_auth:
    path: ../path_to_plugin

@pchampio Ok. Is there any plan to support url plugin? Thank you.

This isn't our priority ATM.
Maybe in the future.
Leaving this PR open.

@pchampio Ok. Thanks.


Feature/colon after space with tests

[x] Related to https://github.com/PolymerLabs/polyclean/pull/9, spaces before colons should not be trimmed, only after
[x] Adds a basic test setup
[ ] Invites others to add more test cases...

@azakus @deedubbu please advice!

Can you rewrite this test with mocha and chai instead of tape?

Done. @azakus

LGTM

Creating a v1.2.2, by chance?

Merged a few other things and went to v1.3.0

I don't think this in var stripCss = this.stripCss; is going to be the right scope. Shouldn't it be var stripCss = exports.stripCss; instead?


rpmqa: log exception info if remove fails

For some exceptions repr() actually gives less information than str().
Since this exception is not a business-as-usual occurrence and may need investigation, guard against this by using the built-in exception display functionality of the logging module.

@lcarva

Coverage remained the same at 88.372% when pulling 0fa991e251a051e4f75eed33c12749fe9e9a2b15 on rpmqa-report-exception-info into 7db1beb549468807b629601ac3e47401b051e14c on master.


Support and/or document plus addressing

Context

Gmail, Zoho and several other mail providers automatically forward all<EMAIL_ADDRESS>to<EMAIL_ADDRESS>It is an automatic alias system that helps users have their mail boxes well ordered and is required by some softwares (such as Odoo, which uses it to detect and process bounces).
Expected Behavior

This should be automatic out of the box if something like PLUS_ADDRESSING=1 is passed.
Actual Behavior

Still not tested. TODO.

@Yajo i can confirm<EMAIL_ADDRESS>works out of the box - i use it with a number of my mail users.

Well, that's great! Then this should be documented instead.


DRAFT: Fix mac M1/M2 chip build

Purpose
Fix mac M1/M2 chip build.
Two issues were identified in mac M1/M2 chip build:

Issue with build version of protocArtifact and pluginArtifact properties.
Java 1.8 incompatibility with M1 chip. Java 1.8 is not officially supported on the Apple M1 chip architecture. However, it is possible to install and use Java 1.8 on an M1-based Mac by using Rosetta 2, which is a built-in translation layer that allows apps designed for x86_64 architecture to run on Apple Silicon.

Changes
There are two profiles defined: mac-os and other-os. The mac-os profile is activated when the operating system is Mac, and it sets the protocArtifact and pluginArtifact properties to constant values. The other-os profile is activated when the operating system is not Mac, and it uses the ${os.detected.classifier} variable in the protocArtifact and pluginArtifact properties.
Issue Link
https://github.com/Concordium/concordium-java-sdk/issues/204
Checklist

[x] My code follows the style of this project.
[x] The code compiles without warnings.
[x] I have performed a self-review of the changes.
[x] I have documented my code, in particular the intent of the
hard-to-understand areas.
x] (If necessary) I have updated the CHANGELOG.

Relevant Screenshots

@soerenbf Can you just confirm on your m1/m2 mac that this works? Thanks.


DLP should use default Java java.awt.Color class and not redefine a Color class with limited functionalities

ImageRedactionConfig imageRedactionConfig = ImageRedactionConfig.newBuilder()
          .setInfoType(infoType)
          .setRedactionColor(Color.newBuilder().setBlue())
          .build();

setRedactionColor takes in a custom com.google.privacy.dlp.v2beta1.Color.class : requiring the use of builders to set RGB values :
This is a painful user experience.

This this defined at a language-independent level (proto), this isn't surprising to me. Would it be sufficient to provide a converter utility method?

I guess that would suffice

Hi @jabubake. You can now do Color.asDlpColor(<some awt color>).

Woot :)


New Version of Evosuite

Hello,
A new version of evosuite is now available with additional test generation techniques implemented (e.g Dynamosa).  Unlike evosuite 1.0.6 , evosuite.jar and evosuite-standalone-runtime.jar is not available on the download link (source code only). Could you please suggest how to include the new version in init.sh?
Thanks

Hi @neelofarhassan,
My understanding is that the new EvoSuite release will include the jars (as release assets) soon. Once these are available, we can upgrade Defects4J to use the newest version.
In the meantime, you could build EvoSuite yourself, locally add the built jars, and test the new version.
Also, we'd welcome a pull request that updates the init.sh script once the jars for the new EvoSuite version are available.
Thanks,
René

EvoSuite 1.1.0 is now the default in master

EvoSuite 1.1.0 is now the default in master


Job Overview endpoint

add /jobs/overview endpoint to retrieve a list of jobs and their run stats
add ListJobsRequest to prepare for query string searching
add JobOverviewResource for future-proofing transformations of data
add CustomOrder scope to JobStatus to allow for ordering by different criteria
remove unreachable return statement in base Controller

Hey @shutupflanders , thanks a lot for this PR. As long as #78 works for you I've decided to go down that route rather than a separate API for the dashboard and the JS client, but thank you for submitting this and leading the project in the right direction!


For obj_index=10 the scores matrix have no value

Hello
when I run "python ./-Results/Generate_detection.py --model /home/DJ-RN-master/-Results/400000_DJR"
I have this error:
Traceback (most recent call last):
File "./-Results/Generate_detection.py", line 27, in
scores[obj_index] = np.concatenate(scores[obj_index], axis=0)
File "<array_function internals>", line 6, in concatenate
ValueError: need at least one array to concatenate
For obj_index=10 the scores matrix have no value. What do I do?

Because I took a small amount of test data that does not have a value for some objects in scores. How can I correct the code?
I took 50 test data for exam

Did you test your model on the full HICO-DET test set? If not, the number of pairs would not be matching and our NIS could not be successfully performed. Maybe you could skip the NIS procedure.


Added Achievements Fragment Tests

Description
Added Achievements Fragment Tests
Tests performed (required)
Tested ProdDebug on Google Pixel 2 with API level 29

@misaochan @domdomegg I need to create a copy of TestAppAdapter as I was not able to access the existing TestAppAdapter which is in the package org.wikipedia let me know if there is a better way.
P.S. we would be needing the TestAppAdapter for many future test classes.

@misaochan @domdomegg I need to create a copy of TestAppAdapter as I was not able to access the existing TestAppAdapter which is in the package org.wikipedia let me know if there is a better way.
P.S. we would be needing the TestAppAdapter for many future test classes.


Pinpoint service

Please help keep the CHANGELOG up to date by providing a one sentence summary of your change:
included in pull, this adds the pinpoint service. I saw a failing integration test which may indicate variance in this services usage of the rest-json protocol

some hints from the bug tracker of the go sdk point towards the content-type header for pinpoint to be sensitivity. Looking at its docs that may be because it tries to be a little extra fancy with supporting  an extra, on demand, content type application/hal+json

This is getting a bit stale. @softprops will you be able to update this in the near future or should we close for now? Thanks!

Closing for the moment, happy to review a Pinpoint PR when it's ready to go. 👍


Fix node not being properly handled after control removal in HoareOptimizer

Summary
Hoare optimizer didn't update cache properly if the control was removed from gate.
Closes https://github.com/Qiskit/qiskit/issues/11201

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
10 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.03%) to 89.545%

Files with Coverage Reduction
New Missed Lines
%

crates/qasm2/src/lex.rs
4
90.93%

crates/qasm2/src/parse.rs
6
97.62%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
59583

Relevant Lines:
66540

💛  - Coveralls

cc @jakelishman I guess?

@jakelishman should I tag someone else for review?


Microsoft/Phi-1.5: Update convert script

Hi there 👋
Fixes #760
In one of the latest commits, the team at Microsoft changed model's architecture (Phi-1.5 that is) to a more conventional one, instead of putting everything in a "layer" variable.
This PR reflects these changes.

Tests seem to be failing

That's because I quickly tested tests/test_convert_hf_checkpoint.py and the ones that are failing is in tests/test_model.py 😊.
The reason is that the modeling file is fixed:
https://github.com/Lightning-AI/lit-gpt/blob/21c1c5941fd56216875a250fb2c03053ba649793/tests/test_model.py#L275
I think it's better to link to the latest version from HF Hub: https://huggingface.co/microsoft/phi-1_5/blob/main/modeling_phi.py
So if anything is changed again with the modeling we will know it before someone creates an issue.

I agree. But you will need to deal with this local import: https://huggingface.co/microsoft/phi-1_5/blob/main/modeling_phi.py#L20


Swagger file in relative path

I am having difficulty adding the Swagger file when it is in another directory. The plugin only recognizes the file when it is in the same directory as the file.md
Example of my structure
project
│   test.md
│
└───assets
│   │   └───swagger
│   │       |  openapi.json

Attempts to add openapi.json:

./assets/swagger/openapi.json
/assets/swagger/openapi.json
assets/swagger/openapi.json

@miquelis I created another MkDocs plugin to render Swagger UI https://github.com/blueswen/mkdocs-swagger-ui-tag. Which could include OpenAPI Spec file cross directories like include image in MkDocs. Maybe my plugin could fit your requirement.

As written in the docs:

Place an OpenAPI json file in the same folder as the .md file.

That's actually a security feature, to prevent LFI/RFI attacks. We don't want someone to write ../../../../etc/passwd would we 😉
While we have the !!swagger-http!! to compensate, adding a config option to disable the security and allow accessing arbitrary files might be an option.

@bharel the way dotnet webserver handles this is that by default it won't serve past the "base" directory. So for example, for mkdocs this would be the same as not allowing navigation beyond the folder with mkdocs file in it. So if your ".md" file was a in a subdirectory, relative paths to other subdirectories woould be fine so long as the navigation depth wasn't beyond the base directory with mkdocs file.

We can add that as a separate feature

Let's try it. I now allow it using a configuration option.


error

Hi!
Thanks for MeeusSunMoon but I get an error:
1st I declare
    <script type='text/javascript' src='moment-with-locales.min.js' charset='utf-8'></script>
    <script type='text/javascript' src='moment-timezone-with-data.min.js' charset='utf-8'></script>
    <script src="dist/meeussunmoon.min.js"></script>

but when I start my test app I get the error:
  TypeError: r.tz is not a function | meeussunmoon.min.js:7:11538
What's wrong?
Thanks
Pit

Hi, could you share a code-snippet of how you're using the library? Also could you try with the non-minified version in order to get a useful line number in the error output?

Thanks for your fast response.
I solved the problem: I had a wrong date conversion.   :-{
Thanks Pit

Glad you got it solved :-)


Bump top_dev to dev

S-mode external interrupt (#1028)
Adding RTC (#1019)
Adding aviary test package (#1022)
Adding UCE as CCE type (#1043)

CI is failing because of: https://github.com/black-parrot-sdk/black-parrot-sdk/pull/33/files, but I tested locally and it passed. So I'm going to update the SDK version in CI before merging. CI runs on other branches will fail until they pull from dev

Is there any documentation about how to use these or if someone wants to create a new testbench with a special testing config how to do that? I see that the testbench makefiles substitute in the bp_common_test_pkg.sv file for bp_common_pkg.sv. Is that all that is required since the test package overloads the bp_common_pkg name?

Yeah to switch out the available configs, just need to compile bp_common_test_pkg.sv instead of bp_common_pkg.sv. The other use case is for tapeout builds that have different configurations, same deal, you just compile one versus the other. e_bp_default_cfg and e_bp_custom_cfg are always available regardless of the aviary

And, to confirm, since the test_pkg file overloads the package naming, the standard import bp_common_pkg::* works in the testbench modules?

Yep!


Non static method 'detectLanguage' should not be called statically.

Hello,
I'm trying to implement your package (V7.0) with my Laravel8 project but I'm facing this issue with calling methods Non static method 'detectLanguage' should not be called statically.
use JoggApp\GoogleTranslate\GoogleTranslate;
`
public function index()
{
    dd(GoogleTranslate::detectLanguage(['Hello world', 'Laravel is the best']));
}

`
is there a problem with this implementation?

just do use GoogleTranslate;


Add support for staging buffer/image for the Rebind Allocator.

Some traces are having corruptions due to missing support for non host visible memory
Case not handled: Staging Image copy with offset

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

CI gfxreconstruct build queued with queue ID 50288.

CI gfxreconstruct build # 3270 running.

CI gfxreconstruct build # 3270 failed.

CI gfxreconstruct build queued with queue ID 50605.

CI gfxreconstruct build # 3273 running.

CI gfxreconstruct build # 3273 failed.

CI gfxreconstruct build # 3350 running.

CI gfxreconstruct build # 3350 passed.

CI gfxreconstruct build queued with queue ID 87876.

CI gfxreconstruct build # 3540 running.

CI gfxreconstruct build # 3540 passed.


Log timezone and formatter->timezone

I have \Yii2::$app->formatter->defaultTimeZone not equal php timezone
I can see
framework/log/Target.php#L273-L274
framework/log/Target.php#L119
So... I can get a message time with php timezone instead of a yii2 application default timezone in all cases?
I expect a time value in log is native for yii2 application if \Yii2::$app->formatter->defaultTimeZone is set.
The yii\i18n\Formatter|formatter is a build-in component, any apps can use it, right?
But i must use additional settings - yii\base\Application::timeZone|timeZone
I think need tell about this differences as a note in the formatter and log chapters.
Additional info

Q
A

Yii version
dev

PHP version
7.1.8

Operating system

So... I can get a message time with php timezone instead of a yii2 application default timezone in all cases?

have you read the docs of defaultTimeZone? It is used to determine the timezone of values in the database, which are formatted and converted to timeZone. So setting defaultTimezone should not affect log formatting at all.

@cebe
I tell about update docs...

It is used to determine the timezone of values in the database

I read guide formatting. I don't see "database" (without ICU database)
I read guide log
I don't see anything about timezone. Only one time timestamp in Message Formatting.
I think can be add to example settings additional line
return [
    // the "log" component must be loaded during bootstrapping time
    'bootstrap' => ['log'],
    // the "log" component process messages with timestamp. Set php timezone to create correct timestamp
    'timeZone' => 'America/Los_Angeles',
    'components' => [
        'log' => [
            'targets' => [
                [
                    'class' => 'yii\log\DbTarget',
                    'levels' => ['error', 'warning'],
                ],
                [
                    'class' => 'yii\log\EmailTarget',
                    'levels' => ['error'],
                    'categories' => ['yii\db\*'],
                    'message' => [
                       'from' =><EMAIL_ADDRESS>                       'to' =><EMAIL_ADDRESS><EMAIL_ADDRESS>                       'subject' => 'Database errors at example.com',
                    ],
                ],
            ],
        ],
    ],
];


Make getRandomLatLng() less likely to prefer higher latitudes

Types of Changes

[x] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description

The current implementation of getRandomLatLng() assumes that the Earth is a flat rectangle and chooses a latitude and longitude uniformly, which ends up preferring higher latitudes once the rectangle is projected onto a sphere. This PR modifies the implementation to sample from the surface of the earth with equal probability (see https://math.stackexchange.com/questions/114135/how-can-i-pick-a-random-point-on-the-surface-of-a-sphere-with-equal-distribution).
I preserved the behaviour of only choosing a latitude in the range [-85, 85] ((Math.acos(0.995) * 57.2958) - 90 == -84.3 and (Math.acos(-0.995) * 57.2958) - 90 == 84.3).
How Has This Been Tested?

I couldn't get Cypress working locally or on CI, but I verified that the trigonometric way of generating latitudes maintains the same bounds and played a few test games on a local deployment.
Screenshots (if appropriate):

@all-contributors please add @zhudotexe for code


Download location changes with consecutive downloads

OS/Platform
Debian, Ubuntu, and derivatives
Installed
Flatpak
Version
115.0.5790.98
Have you tested that this is not an upstream issue or an issue with your configuration?

[X] I have tried reproducing this issue in Chrome and it could not be reproduced there
[X] I have tried reproducing this issue in vanilla Chromium and it could not be reproduced there
[ ] I have tried reproducing this issue in ungoogled-chromium with a new and empty profile using --user-data-dir command line argument and it could not be reproduced there

Description
Whenever I download several files in a row, after I specify the download location for the first file, every subsequent download location prompt opens on what I assume is a temporary location.
How to Reproduce?
Download several files in a row with "Ask for location every time" option enabled.
Actual behaviour
Whenever I download several files in a row, after I specify the download location for the first file, every subsequent download location prompt opens on what I assume is a temporary location :

This location still displays the files in the previously selected folder (i.e. at least the first downloaded file), but clicking "Download" doesn't seem to do anything, and I then have to navigate to the correct folder again.
This only seems to happen when saving to a different drive/partition than home.
Expected behaviour
The download prompt should open on the last download location.
Relevant log output
No response
Additional context
Reproduced in both Ubuntu 22.04 LTS and Zorin OS 16 (based on Ubuntu LTS 20.04 LTS).
Cross-posted from the Flatpak GitHub because I'm not sure this was the right place to ask.

I'll close this issue since it was reported upstream.

Could you point to the upstream issue ? I couldn't find anything related to that specific bug. Thanks !

I meant that it must be a Flatpak issue, therefore it is sufficient that issue reported there. Sorry for ambiguous wording.

I see, thanks for the clarification !


[BUG] Cant read again

This software bug again... Can't read data from blabla...
It's annoying T_T
@sdomi4

Offsets are correct and there hasn't been another update. Can you check you are receiving the correct offsets (13.4.2 with "Manager": "0x21716E0")?

Yes all is ok (now 13.15 is release so dont work) but with the good offsets i have an error

Offsets are updated for 13.15

I have good offsets but... i have this message again and I double check offsets so here this is not the problem


Recommended approach for fetching/storing multiple different relationships

To my understanding, it seems like the recommended approach so far when working with objects that can have relationships is to create extra data classes that bundle them together, similar to the example here with the shopping carts.
However, in a more realistic scenario, an object might have several different relationships.
For example:
Car {
  Owner
  Wheels
  Passengers
  Garage
}

Some functions (especially render-ones) might want all, or some, or none of those children. I don't think it makes much sense to fetch them all separately in case you're dealing with many objects (e.g. 100 cars in the example above).
How should one go about structuring this stuff?
Should you create several different data classes? E.g. CarWithOwner, CarWithGarageAndPassengers, CarWithOwnerAndWheelsAndPassengersAndGarage etc. That seems to get messy and unmaintainable fast since you also need completely different code-paths for the fetching due to the different return types.
Should you create one extra data class (per main object) that has the ability to hold all the children? E.g. CarExt that extends Car with the fields owner, wheels, passengers, garage that are all nullable and can be loaded when needed (e.g. pass flags to the DAO). Naturally, you could run into issues with forgetting to toggle the right flags and therefore e.g. owner is null when you need it, but those can easily be caught when testing in development.
The second approach seems saner to me but isn't mentioned anywhere. It's still not ideal since it requires me to declare an extra class for every data class, just for those extra fields. At that point I might as well rename Car to CarDB or something and only use the bare types when directly interacting with moor. Now, if #114 gets implemented the mixin way we have more control over the data class and can therefore add extra fields if we want to without needing an extra data class. However, I still wanted to open a separate issue for this since I haven't seen it properly discussed anywhere (only seen the CarWithPassengers approach suggested).
What are peoples' thoughts about this? Has anyone used moor in a bigger codebase and solved this problem in some clever way? I don't like approaches that manually modify the generated code since you then have to commit it and remember to fix it after each generation. I would love to get some official insight on this and perhaps hear what the long-term plan/solution is. To me, it feels like moor should just add these fields for us since it must be quite common to want to load certain relationships right away (e.g. with joins).

It's not immediately helpful, but I can outline my plans for this in the long-term from the perspective as a library author.
The problem you mentioned is that, especially with many relationships, you never know which to load. For n possible relationships we can't possibly generate 2ⁿ classes and automatic mapping methods.
We could have fields like Future<Owner> owner (or stream?) on the generated model, so that we'd lazily load the entity the first time the future is awaited. I'm not sure what the usability impact of that would be, but I like how it exposes that another async query is necessary.
I've been a bit reluctant to add ORM-like features to moor because it feels like I'd open a pandora's box of feature creep into the project. Moor and it's generator are complex enough on their own, and to me it feels like a proper ORM with the features you mentioned would be even more complex. Moor is designed to be a convenient, but thin wrapper around sql. I don't see how features like these could realistically fit into moor without negatively impacting users who prefer the relational style of it.
I'm considering writing an ORM around moor as a mostly-independent project. Initially it would allow something like #114 with a Room-like style of generating tables from models instead of the other way around as in moor (see what I did there? :laughing:). I'd say that this suggestion would fit quite nicely into that:
@Entity
abstract class Car { // implementation of this would be generated
  final String model;
  @PrimaryKey
  final String vin;

  @mapToOne
  Future<Person> get owner;

  @mapToMany
  Stream<List<Wheel>> get wheels;

  // ...
}

Since it would be built on top of moor (rather than being a part of it), I will be able to experiment with those features more freely and I don't have to deal with the added complexity of integrating these features into moor. I've thought about this for some time now, I want to get started when I have some time.

What about using https://pub.dev/packages/tuple for the time being?

@North101 It simplifies the naming, but you'd still end up with tons of different types (even if they are all just a tuple at the end of the day). I think ideally I'd want one single method for fetching things, e.g. getCars(loadWheels, loadPassengers, ...) that would conditionally load the desired data.
@simolus3 Thanks for the lengthy response. I agree with you that ORM features would be a pandora's box and I don't think adding them is a good idea. Whether I can call car.wheels or have to call WheelsService.getByCar(car) doesn't really matter since I still have to deal with the async headache. I think a framework like Flutter (or most UI frameworks for that matter) requires/encourages you to plan your data loading better and therefore convenient lazy-loading methods become less useful/needed.
Building an ORM on top of moor sounds like a fine plan (and yes, great pun 😆). Though, with that being said, it looks like floor is already building an ORM that looks a lot like what you're describing, and it sounded like he would utilize a part of moor already (the SQL parser to begin with). It also looks like you guys could benefit a lot from each-others help (due to the size of these projects), but I'll leave it at that.
I think, ultimately, if you feel like #114 is too much for this project, then the way forward would be to treat moor as the thin wrapper it is and only use the data classes it generates to interact with moor. Probably name them something different as I suggested above (this could obviously be done by the user) and then inherit them and define more fields/methods as one likes. This could be done on an as-needed basis (e.g. not needed for simple small projects, or not for simple tables).
Alternatively, if you think #114 would still be useful here (as a flexible bridge between the wrapper -> orm world), one could treat the data classes generated by moor as a flexible foundation that the user could do whatever they wish with (e.g. build orm-like functionality, or something more bare/simple). One could certainly argue that it might look a tad awkward to have to define both a table AND an empty data class (that mixes in the mixin) to get started, but tbh I don't think it's a real problem. Sure, in the ORM world one would not expect it, but yeah, this ain't an ORM.
Personally, I'm starting to lean towards the first approach. Regardless, I think it would make sense to clarify in the README or somewhere else what the purpose/goal is with moor and what it isn't. I think what you wrote above is great and will help people who find their way to this issue.

At the moment we’re trying two different approaches.
The first approach is to simply not do any joins and resolve relationships as late as possible - often with switchMaps close to the UI, or components that lazily fetch data as they appear on screen. The n+1 problem isn’t as scary with sqlite, but we mainly use this approach on form-like screens as opposed to long lists.
The second approach is to do very specific queries to select the exact columns we need for the screen/use case. We mainly take this approach when combining query results in dart would be more complicated/expensive than just writing the join in sql - often for long detailed lists.
There’s some more interesting discussion here. I’ve been meaning to experiment with using views but haven’t had a chance.

@Mike278 For the second approach, what type does the DAO return? A custom one for that specific query or a custom one that is also used generally elsewhere?

Yep a custom one for that specific query.

I'm trying to evaluate the viability of aggressively using the lazy getter approach in my app, and am wondering if anyone knows/has experience with how expensive it really is?
Like, if all of my getters are .watch() streams, that's not just n+1 queries, it's n+1 watchers, streams, StreamBuilders, etc. How expensive are those abstractions, and... should I care? Does it even matter?
/// Lazy getters approach.
///
/// Simple, defers evaluation until render, but results in:
/// * n+1 queries and db watchers (or no db watchers with futures)
/// * the need for lots of StreamBuilders or FutureBuilders
extension TaskMethods on Task {
  Stream<List<CalendarEvent>> get calendarEvents =>
      db.calendarEvents.query((ce) => ce.whereTaskIs(this)).watch();
}

/// Upfront complex query approach.
///
/// Only 1 query + stream, but:
/// * more complex query code (not a big deal)
/// * either awkward or redundant domain models (kind of annoying)
/// * _or_ TupleN results (also annoying/awkward)
extension AppDatabaseMethods on AppDatabase {
  Stream<List<Tuple2<Task, List<CalendarEvent>>>> tasksWithEvents() => tasks
      .query()
      .join([leftOuterJoin(calendarEvents, calendarEvents.onTaskRef(tasks))])
      .watch()
      .map(
        arrayAgg(
          (row) => row.readTable(tasks),
          (row) => row.readTableOrNull(calendarEvents),
        ),
      )
      .map(tuplify2);
}

arrayAgg and tuplify2 for those interested
/// Aggregate the results of [readValue] into a `List<V>` under the unique keys from [readKey].
///
/// Uses [LinkedHashMap] so order is maintained.
LinkedHashMap<K, List<V>> Function(List<TypedResult>) arrayAgg<K, V>(
  K Function(TypedResult) readKey,
  V? Function(TypedResult) readValue,
) =>
    (rows) {
      final agg = LinkedHashMap<K, List<V>>();
      for (final row in rows) {
        final key = readKey(row);
        agg[key] ??= [];
        final value = readValue(row);
        if (value != null) {
          agg[key]!.add(value);
        }
      }
      return agg;
    };

/// Convert aggregates' entries into tuples of (key, value)
List<Tuple2<D, D2>> tuplify2<D, D2>(Map<D, D2> aggregates) =>
    aggregates.entries.map((e) => Tuple2(e.key, e.value)).toList();

It is also possible to use a generic record type like Tuple* to compose convenience getters, offsetting the pain of rewriting all your models for each view, but... it is still worse DX than just lazily streaming methods from already-generated models IMO

extension TaskWith on Tuple2<Task, dynamic> {
  Task get task => first;
  String get title => first.title;
  String get description => task.description;
}

extension TaskWithEventsGetters on Tuple2<Task, List<CalendarEvent>> {
  List<CalendarEvent> get calendarEvents => second;
}

/// The below uses both extensions
String _firstStart(Tuple2<Task, List<CalendarEvent>> t) =>
    t.title + ' ' + t.calendarEvents.first.start.toString();

That's an interesting question! In general, I think the cost of a sqlite query tends to be overestimated because most of us are coming from database servers where each query requires a network roundtrip. That's not an issue with sqlite, where simple queries are quite cheap. We could consider implementing a cache for prepared statements in moor to improve performance for queries with the same sql code but different variables. I didn't do any benchmarking to see if that's actually a bottleneck though.
But intuitively, I'd recommend optimizing for DX and then open issues in moor if you run into specific scenarios that the library could optimize. Stream queries don't have a high overhead, you just need to be aware that moor always invalidates streams on a per-table basis. So if you have say hundreds of independent streams on a table that all have to update for a tiny change affecting one row, that might cause a performance hit. In those cases, a single stream with joins might be a better solution.

I'm closing discussion issues that are older than a year.
This is one of them.


Implement smooth shading for RidgeBasedPolyhedron

Implemented the same way as for Terrain and Honeycomb.
Common code factored out in class SmoothShaderProcessor and reused for
all 3 cases

Set empirical step for discretization 0.0001
Existing step didn't work for polyhedron.
Revert/change if needed

With/without:


Support for transposition

This PR adds support for having a transposed view (mutable or not) of an array. We probably also want to have a transposition with copy that doesn't change the storage order.

I've also added a version of transpose that consumes the array, returning an OwnedArray.
What do you think?

Hi, a single method could serve all use cases, i.e. transpose views or ownedarray in place.

.swap_axes already exists, but I guess it's only useful for 2d arrays. Not sure when you ever need transposing anything else, though.

Hi, a single method could serve all use cases, i.e. transpose views or ownedarray in place.

I hadn't thought of that, so if someone wants a transposed view it would be a.view().transpose()?
In that case though the transpose_into method I made would need an additional into_owned method able to get out of Rc with copying if necessary.

.swap_axes already exists, but I guess it's only useful for 2d arrays. Not sure when you ever need transposing anything else, though.

I had missed swap_axes, maybe it should have transposition in its doc then. But in my opinion transposition is useful in more cases than 2d arrays, a pattern I likeis to implement some method on C-order, then rely on some double transposition trick to have it work on F-order arrays too. I've used that pattern quite some times when interfacing python with C++ code.

Just a note: transposition for ndim > 2 could mean any permutation, not necessarily in reverse order: e.g. http://docs.scipy.org/doc/numpy-1.10.1/reference/generated/numpy.transpose.html
For 2d the only other permutation is the inverse, so there's that

I see, that would need a dedicated function, something like fn permute_axes(self, perm: D) where D: Dimension.

@bluss the new version has a single transpose() implementation.

We can make this super simple, just reverse dimensions in place (.slice_mut().reverse()). Not sure we want the into owned method? Why is it needed?

We can make this super simple, just reverse dimensions in place (.slice_mut().reverse()).

Neat. I'll do that.

Not sure we want the into owned method? Why is it needed?

I thought the functionality might be useful. However I have no use case for it yet, so I'll remove it from this PR and it might come back if someday I find I need it :)

It's done. It makes a much simpler PR :)

I'll change the name of the method - .reversed_axes, given the discussion about transposition being an even more general operation.

Also, thanks, simple is always better..


added QC report local module

Generates a formatted csv file for each read SEPARATELY

Change this to use debug txt file output from faqcs to remove the dependency on pdftotext and reading pdf files.


MSSQL Async Query using Celery fails with error year 54755 is out of range

A clear and concise description of what the bug is.
How to reproduce the bug

Enabled async quries using celery via https://superset.apache.org/docs/installation/async-queries-celery
Enabled async database queries through database configuration for mssql server
open the sql tab and run the query
See error

Expected results
Get back the query results like when I had the async queries disabled
Actual results
fails with error year 54755 is out of range
Screenshots
If applicable, add screenshots to help explain your problem.
Environment
docker running superset
(please complete the following information):

superset version

2022-10-14 08:20:43,968:INFO:root:Configured event logger of type <class 'superset.utils.log.DBEventLogger'>
Falling back to the built-in cache, that stores data in the metadata database, for the following cache: FILTER_STATE_CACHE_CONFIG. It is recommended to use RedisCache, MemcachedCache or another dedicated caching backend for production deployments
2022-10-14 08:20:43,973:WARNING:superset.utils.cache_manager:Falling back to the built-in cache, that stores data in the metadata database, for the following cache: FILTER_STATE_CACHE_CONFIG. It is recommended to use RedisCache, MemcachedCache or another dedicated caching backend for production deployments
Falling back to the built-in cache, that stores data in the metadata database, for the following cache: EXPLORE_FORM_DATA_CACHE_CONFIG. It is recommended to use RedisCache, MemcachedCache or another dedicated caching backend for production deployments
2022-10-14 08:20:43,977:WARNING:superset.utils.cache_manager:Falling back to the built-in cache, that stores data in the metadata database, for the following cache: EXPLORE_FORM_DATA_CACHE_CONFIG. It is recommended to use RedisCache, MemcachedCache or another dedicated caching backend for production deployments
/usr/local/lib/python3.8/site-packages/flask_appbuilder/models/sqla/interface.py:68: SAWarning: relationship 'SqlaTable.slices' will copy column tables.id to column slices.datasource_id, which conflicts with relationship(s): 'Slice.table' (copies tables.id to slices.datasource_id). If this is not the intention, consider if these relationships should be linked with back_populates, or if viewonly=True should be applied to one or more if they are read-only. For the less common case that foreign key constraints are partially overlapping, the orm.foreign() annotation can be used to isolate the columns that should be written towards.   To silence this warning, add the parameter 'overlaps="table"' to the 'SqlaTable.slices' relationship. (Background on this error at: https://sqlalche.me/e/14/qzyx)
for prop in class_mapper(obj).iterate_properties:
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Superset 0.0.0-dev
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

python version: 3.8.13

Make sure to follow these steps before submitting your issue - thank you!

[ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[ ] I have reproduced the issue with at least the latest released version of superset.
[ ] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
no idea really how to investigate furher.
Regards

Closing this as stale since it's been silent for so long, and we're trying to steer toward a more actionable Issues backlog. If people are still encountering this in current versions (currently 3.x) feel free to re-open this, open a new Issue, or open a PR to address the problem.


Next release?

There's an unreleased fix on master. Could you make a release to crates.io?

0.3.2 should be published now: https://crates.io/crates/http-muncher
Thanks for reporting!


Documentation - not clear that arrays are allowed in the first argument of applySpec

I spent about an hour and a half looking for a method that could take an array of functions, apply them to an arbitrary value, and produce an array of the results.
After some experimentation, I found out that applySpec is able to do precisely that:
R.applySpec([n => n + 1, n => n - 1])(5);    //=> [6, 4]

and that it even works on arrays within objects and objects within arrays, ad infinitum. But the documentation doesn't say anything about this.
I think it would be helpful if the docs mentioned that applySpec is able to do this, or is this deliberately undocumented?

This is not an answer to your question, but this is how I would express your algorithm in code:
//    T :: a -> (a -> b) -> b
const T = x => f => f(x);

R.map(T(5), [R.add(1), R.add(-1)]);  // => [6, 4]

The T combinator was added in #2309 and will be available—as R.applyTo—in the next release.

@davidchambers Thanks for your comment. In my case, applySpec is perfect for my needs because the functions I'm applying are constant and it's the value that changes, so it's helpful to have the arguments in the order [functions], value rather than value, [functions].
This is how I'm actually using it:
// DOMNode -> [DOMNode]
const allDescendants =
    node => compose(flatten, map(applySpec([identity, allDescendants])), allChildNodes)(node);

// doing this instead of filtering allDescendants in order to avoid potentially
// building a huge array and filtering it
// (String, String) -> DOMNode -> [DOMNode]
const descendants =
    (localName, uri) => node => compose(
            flatten,
            applySpec([filter(hasName(localName, uri)), map(descendants(localName, uri))]),
            allChildNodes
    )(node);

I'm very new to functional programming, so maybe there's a better way to go about this, but it produces the desired output.

A PR to update the the documentation would be apt.  This works only by accident of the implementation, but it's behavior worth keeping if we ever change the function.  So a new test case would be a good idea too.

@CrossEye Sure, I'll prepare a PR with some documentation adds and unit tests. Thanks.


simulation-analysis profiling : data_stagein field empty in the dataframe

I am using the devel branch for profiling. I have data being staged in during the simulation stage (https://github.com/radical-cybertools/radical.ensemblemd/blob/master/usecases/extasy_gromacs_lsdmap/01_static_gromacs_lsdmap_loop.py#L171-L173), but the data_stagein field remains empty in the dataframe : https://gist.github.com/vivek-bala/0a57e898e05e72f454c1.
Same holds for the data_stagein for the Analysis stage as well.

what pilot branch are you using?

I believe this is the RP on pypi. (https://github.com/radical-cybertools/radical.ensemblemd/blob/devel/setup.py#L127)

Are your using "link_input_data" as your link above suggests? 'Linking' is not recorded as data staging.

Hmmm .. Is it the same for 'copy_input_data' as well ? So "data_stagein" would mean transfer to the remote host and not the "staging" into the CUs in any of the simulation/analysis steps ?

Transfer that crosses host-boundaries and that are using RP's data staging are recorded. Linking and copying on the same host, i.e., between steps are not.
Maybe that's something that can be improved in the future if the new RP staging directives are implemented throughout EnMD.

Transfer that crosses host-boundaries and that are using RP's data staging are recorded. Linking and copying on the same host, i.e., between steps are not.

In the devel branch, those actions are in enacted in different components, and thus have different states, and thus get separate entries in the state history, so they will be easy to dig out again.  If it is very urgent, we can do some kind of fixing in master, but devel is what represents the clean approach to that specific problem.

This is resolved in the devel profiling.


Add table gcp_iam_workloadidentitypools

References
https://cloud.google.com/iam/docs/reference/rest/v1/projects.locations.workloadIdentityPools
https://cloud.google.com/iam/docs/reference/rest/v1/projects.locations.workloadIdentityPools.providers
When adding workload identity pools, the providers that are associated with an identity pool are super useful as well.
A general overview on Workload Identity Pools and providers is available here: https://cloud.google.com/iam/docs/manage-workload-identity-pools-providers

Thanks @chr-b, for creating this request with detailed API references 👍 .
I think it is better to create two separate tables based on the APIs and docs that you sent over:

gcp_iam_workload_identity_pool
gcp_iam_workload_identity_pool_provider

If anyone is interested in trying to add these tables, we're always excited to see new PRs coming in! For more information on our coding and documentation standards, please have a look at Table and Column Standards and Table Documentation Standards. If you have any questions about the development process otherwise, please let us know!


Added new activities to Nanoflow documentation

These were missing. Now more aligned with activities documentation.
Since I've also added microflows call, this should only get merged for 8.8 and later

All good no edits. Thanks for your use of the serial comma @Robinfr .


Extension monaco-languageclient-project.langium-example is already registered

using the react component in vscode mode i am getting this
(on 2nd mount of component)
any idea what could cause this?
is there some destroy/unregister missing?

@cdietrich In the meantime I have added explicit disposal of the extension https://github.com/TypeFox/monaco-components/blob/react-python/packages/monaco-editor-wrapper/src/editorAppVscodeApi.ts#L77-L81 but I wasn't able to reproduce your exact issue. Can you provide an example or repo / source link? Thanks

need to check how easily i can factor out an example. we meanwhile use the monaco classic variant

need to check how easily i can factor out an example. we meanwhile use the monaco classic variant

A unit test here on branch that fails is an idea. Don't know how much boiler-plate code that requires, though. But once in place it will be handy for other react component related tests.
This repo started with unit tests, but we are improving.

might also be fixed by newer versions already

#43 tracks the creation of unit tests for monaco-editor-react.

@cdietrich should I transfer this to the other repo? Is it still applicable?

i dont know. feel free to close.

Closing this here. Feel free to open a new issue here: https://github.com/TypeFox/monaco-languageclient if required.


Check for slack_token parameter before launch

So I thought I'll try to contribute as much as I can (I have no active Go knowledge so we'll see for other issues). It's for https://github.com/erroneousboat/slack-term/issues/19. It has also fixed https://github.com/erroneousboat/slack-term/issues/18 for me.

Output:
2016/10/18 18:39:17 ERROR: not able to load config file (/Users/gabortakacs/slack-term.json): invalid character '"' after object key:value pair
exit status 1

LGTM!
Fixes #18
Fixes #19

Nice!


added full path to support sharing with enterprise

@karlkfi can we make an exception for this particular link?

Why? This will break dev.dcos.io

@karlkfi so we can reuse this topic here: https://docs.mesosphere.com/1.7/administration/installing/local/. alternatively we could remove from the enterprise doc (which might make sense).

Long term, I'd like to see a /releases on mesosphere.com that provides links to the Enterprise downloads. Then the public change logs can go there and the download links can just be password protected.

@karlkfi what is dev.dcos.io used for? Staging?

Yes. It's for verifying that changes to the website look correct before promoting them to production.

okay, i will stop sharing this topic, and update the link on enterprise.


Upgrade pydocstyle to 2.0.0

2.0.0
Major Updates

Support for numpy conventions verification has been added.
Support for Python 2.6 has been dropped.
Support for PyPy3 has been temporarily dropped, until it will be equivalent to CPython 3.3+ and -
supported by pip.
Support for the pep257 console script has been dropped. Only the pydocstyle console script should be used.
Errors are now printed to stdout instead of stderr.

New Features

Decorator-based skipping via --ignore-decorators has been added.
Support for using pycodestyle style wildcards has been added.
Superfluous opening quotes are now reported as part of D300.
Fixed a false-positive recognition of D410 and added D412.
Added --config= flag to override the normal config file discovery and choose a specific config file.
Support for specifying error codes with partial prefix has been added, e.g., --select=D101,D2.
All configuration file can now have the .ini extension.
Added better imperative mood checks using third party stemmer.

Bug Fixes

Made parser more robust to bad source files.
Modules are now considered private if their name starts with a single underscore. This is a bugfix where “public module” (D100) was reported regardless of module name.
Removed error when all is a list.
Fixed a bug where the @ sign was used as a matrix multiplication operator in Python 3.5, but was considered a decorator by the parser.

What should we do with this PR?  If no one is going to pick it up, let's close it?

Yeah, let's close it.


Update to gtk

We'll need to wait for https://github.com/gtk-rs/gtk/pull/714 to be merged first as a last check.
cc @sdroege @EPashkin

👍


tree.pandas.df() with branches==None AttributeError

This seems like it crept in recently, as it used to work.
>>> import uproot
>>> tree = uproot.open("Zmumu.root")["events"]
>>> tree.pandas.df(["pt1", "eta1", "phi1", "pt2", "eta2", "phi2"])

... works
>>> import uproot
>>> tree = uproot.open("Zmumu.root")["events"]
>>> tree.pandas.df()
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-6-6bcef7f7c748> in <module>()
      1 import uproot
      2 tree = uproot.open("Zmumu.root")["events"]
----> 3 tree.pandas.df()
      4

/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/uproot/_connect/to_pandas.py in df(self, branches, entrystart, entrystop, flatten, cache, basketcache, keycache, executor, blocking)
     41     def df(self, branches=None, entrystart=None, entrystop=None, flatten=True, cache=None, basketcache=None, keycache=None, executor=None, blocking=True):
     42         import pandas
---> 43         return self._tree.arrays(branches=branches, outputtype=pandas.DataFrame, entrystart=entrystart, entrystop=entrystop, flatten=flatten, cache=cache, basketcache=basketcache, keycache=keycache, executor=executor, blocking=blocking)

/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/uproot/tree.py in arrays(self, branches, outputtype, entrystart, entrystop, flatten, cache, basketcache, keycache, executor, blocking)
    498         # if blocking, return the result of that function; otherwise, the function itself
    499         if blocking:
--> 500             return wait()
    501         else:
    502             return wait

/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/uproot/tree.py in wait()
    451                             array = future()
    452
--> 453                             entries = numpy.empty(len(array.content), dtype=numpy.int64)
    454                             subentries = numpy.empty(len(array.content), dtype=numpy.int64)
    455                             starts, stops = array.starts, array.stops

AttributeError: 'Strings' object has no attribute 'content'

18:balarsen@rbsp4 Downloads $ pip list
Package                    Version
-------------------------- ----------------------------
alabaster                  0.7.11
appnope                    0.1.0
arrow                      0.12.1
astropy                    3.0.3
atomicwrites               1.1.5
attrs                      18.1.0
Babel                      2.6.0
backcall                   0.1.0
BayesInst                  0.3.dev22+ga7d5c0d.d20180706
bleach                     2.1.3
certifi                    2018.4.16
chardet                    3.0.4
click                      6.7
coverage                   4.5.1
cycler                     0.10.0
Cython                     0.28.4
decorator                  4.3.0
docutils                   0.14
docx                       0.2.4
entrypoints                0.2.3
et-xmlfile                 1.0.1
gitdb2                     2.0.4
GitPython                  2.1.11
h5py                       2.8.0
html5lib                   1.0.1
hypothesis                 3.66.1
idna                       2.7
imagesize                  1.0.0
ipykernel                  4.8.2
ipython                    6.4.0
ipython-genutils           0.2.0
ipywidgets                 7.2.1
jdcal                      1.4
jedi                       0.12.1
Jinja2                     2.10
joblib                     0.12.0
jsonschema                 2.6.0
jupyter                    1.0.0
jupyter-client             5.2.3
jupyter-console            5.2.0
jupyter-core               4.4.0
kiwisolver                 1.0.1
LANLpygeometry             0.1
lxml                       4.2.3
MarkupSafe                 1.0
matplotlib                 2.2.2
mistune                    0.8.3
more-itertools             4.2.0
nbconvert                  5.3.1
nbformat                   4.4.0
nose                       1.3.7
notebook                   5.6.0
numexpr                    2.6.5
numpy                      1.14.5
openpyxl                   2.5.4
packaging                  17.1
pandas                     0.23.3
pandocfilters              1.4.2
parameterized              0.6.1
parso                      0.3.1
path.py                    11.0.1
patsy                      0.5.0
pbr                        4.1.0
pexpect                    4.6.0
pickleshare                0.7.4
Pillow                     5.2.0
pip                        10.0.1
pluggy                     0.6.0
prometheus-client          0.3.0
prompt-toolkit             1.0.15
ptyprocess                 0.6.0
py                         1.5.4
Pygments                   2.2.0
pymc3                      3.4.1
pyparsing                  2.2.0
pytest                     3.6.3
pytest-cov                 2.5.1
python-dateutil            2.7.3
pytz                       2018.5
pyzmq                      17.1.0
qtconsole                  4.3.1
requests                   2.19.1
ruamel.appconfig           0.5.4
ruamel.std.argparse        0.8.1
ruamel.std.pathlib         0.6.3
scikit-learn               0.19.1
scikit-optimize            0.5.2
scipy                      1.1.0
seaborn                    0.8.1
Send2Trash                 1.5.0
setuptools                 40.0.0
setuptools-scm             2.1.0
setuptools-scm-git-archive 1.0
simplegeneric              0.8.1
six                        1.11.0
sklearn                    0.0
smmap2                     2.0.4
snakefood                  1.4
snowballstemmer            1.2.1
spacepy                    0.1.6
Sphinx                     1.7.5
sphinx-git                 10.1.1
sphinxcontrib-websupport   1.1.0
stevedore                  1.28.0
STUDIO                     0.0.0
tables                     3.4.4
terminado                  0.8.1
testpath                   0.3.1
Theano                     1.0.2
tornado                    5.1
tqdm                       4.23.4
traitlets                  4.3.2
uproot                     2.9.4
urllib3                    1.23
version-information        1.0.3
virtualenv                 16.0.0
virtualenv-clone           0.3.0
virtualenvwrapper          4.8.2
wcwidth                    0.1.7
webencodings               0.5.1
widgetsnbextension         3.2.1
xarray                     0.10.7
xlwt                       1.3.0
xmltodict                  0.11.0

I have no idea how to go about figuring out the issue, but adding
    def test_issue102(self):
        t = uproot.open("tests/samples/Zmumu.root")["events"]
        assert len(t.pandas.df(["pt1", "eta1", "phi1", "pt2", "eta2", "phi2"])) == 2304
        assert len(t.pandas.df()) == 2304

tests/test_issues.py
At least captures the error

Thanks for catching this— I'll fix it as soon as possible. It's not a mysterious bug— but it illustrates that I need to systemize some of the special case handing for different branch types. You're getting this error because some of your branches have string type and the DataFrame-handling code doesn't handle that case.
You can avoid this error (for now) by reading the data as arrays and converting them into a DataFrame:
df = pandas.DataFrame(columns=tree.allkeys(), data=tree.arrays())

The thing you would be missing by doing this is the ability to flatten jagged data into a DataFrame with a MultiIndex. (It's equivalent to flatyen=False).
I'll fix it as soon as possible (but it could be a week— on vacation).

Perfect, no problem. Thanks for the hard work! Enjoy the vacation.

An interesting observation on some 100M plain (not jagged etc) root files.
tree = uproot.open("./zep_hemisphere_1_95.root")['EventInfo']
%timeit df = pandas.DataFrame(columns=tree.allkeys(), data=tree.arrays())
# 1min 16s ± 552 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

def makedf(tree):
         df = {}
         for k in tree.keys():
             df['k'] = tree[k].array()
         return pd.DataFrame(df)
%timeit makedf(tree)
# 44.1 s ± 539 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

This is a pretty notable difference in speed and seems like the first should be faster but maybe has other stuff behind the scenes that slow it down.

That's weird. The tree.arrays method is literally each branch.array in sequence when there is no executor (parallel processing). It internally creates functions and uses them once to accommodate parallel processing, which might be a slight hit that scales with the number of branches (not the size of their contents).
The other confounding variable here is constructing the DataFrame, which has performance characteristics that are mysterious to me. My prescription of setting columns and data is because it gives Pandas all the information at once (presumably, it can make use of that information to optimize) and columns sets the order. columns is the only Pandas difference between your two examples.
If it turns out to be array versus arrays, I'll look into it with more examples. I won't change it on the basis of one example because it might not be general, especially if it means complicating the code (separate parallel and sequential cases) for the sake of a speedup.

And the plot thickens with not understanding how the heck data frames are constructed.
In my case  pandas.DataFrame(tree.arrays()) and pandas.DataFrame(columns=tree.allkeys(), data=tree.arrays()) give the same result.
%timeit df = pandas.DataFrame(tree.arrays())
# 30.9 s ± 597 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

(Seeing as I'm traveling with my family, I can't try these things myself, but I can keep giving you suggestions of things to try. I don't know, however, if your physics case really needs more performance on reading these DataFrames. As a library developer, I'm on the lookout for speedups, but if your focus is on physics, the difference between a minute and half a minute isn't that different.)
I suggested using columns because the order of the columns might be important. The dict returned by tree.arrays() might yield the same order, but not necessarily. It might also work to use an OrderedDict:
import collections
df = pandas.DataFrame(tree.arrays(outputtype=collections.OrderedDict))

When uproot fills an OrderedDict, it does so in the TTree's natural branch order.
But then again, maybe the column order doesn't matter to you.  :)

Thanks, I really only point these out for interesting things as a method to more fully understand what is at the bottom of the whole system. Seems like the actual bug is easy to fix when you return and that the rest is really file it away deep in the brain as a "oh I remember that" when it comes back as enhancements or someone's application requires more speed that currently is there. As you point out that is not me currently other than being nerd driven.
My particular love of this package is driven by moving away from root as early in my processing as possible and enabling me to use tools I am more comfortable with. I'm not a HEP guy but a space physics guy using geant for instrument responses.

I got up before everyone else and fixed the original bug that started this thread. I couldn't find the performance difference, but I don't have your file. Considering the changes that are in store for this bit of code, however, it might not be worth tuning it until after the awkward-arrays are in.


Update README.md to include Azure Government Deviations

Updated ReadMe file with instructions for deploying to Azure Government

@dstrockis


Add Appalaroshini's file

created a branch, created a file and made a commit and opened a pull request

okkk


[Explicit Modules] Use external dependency info to determine if discovered binary dependenceis are frameworks.

The driver library's client may supply information about the current module's dependencies, incl. whether or not they are frameworks. With the dependency scanner no longer re-using source module information from a prior scan (https://github.com/apple/swift/pull/63201), such modules will be reported as prebuilt binary dependencies.
Moreover, add a check to avoid resolving the main module's source module information with a binary dependency, covering an edge case of a module having a dependency with the same name.

@swift-ci test

@swift-ci test


Test-DbaMaxMemory error

Bug Report

General Troubleshooting steps

[ x] Verified running latest release of dbatools?
[x ] Verified errors are not related to permissions?
[x ] Can duplicate in new/fresh PowerShell.exe session?

Version Information

Operating System (Name|Version):
Win 10 Pro
PowerShell Version:
PSVersion                      5.1.14393.1480
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14393.1480
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
SQL Server (Edition|Version):
SQL 2014 SP2

Steps to Reproduce

[ ] Attach any screenshots (if possible/allowed)
[ ] Attach logs generated by dbatools (Get-DbatoolsLog)
[ x] Attach output from PowerShell console (if possible/allowed)
Test-DbaMaxMemory Error.txt

Thanks! Was able to repro. Will have a fix in within a couple hours!


Warning: pattern.indexOf is not a function Use --force to continue.

Trying to run the ts command causes error:
Warning: pattern.indexOf is not a function Use --force to continue.

I tried to debug, but could not find the cause.
grunt-cli v0.1.13
grunt v0.4.5
typescript v1.7.3
Tried all grunt-ts versions until 4.2.0 which worked without issues.
Gruntfile.js configuration:
   ts: {
            development: {
                src: ['src/ts/**/*.ts'],
                outDir: 'src/js',
                options: {
                    module: 'amd',
                    target: 'es5',
                    sourceMap: true,
                    declaration: false,
                    noImplicitAny: false,
                    comments: true
                }
            }
    }

Maybe there's something I'm missing blindly, but could not find it nor all the results Googling the same error just related mostly to grunt "files" needing to be array of objects instead of object.

Is there any stack trace? :rose:

Google told there was hidden (?) --stack parameter.
TypeError: pattern.indexOf is not a function
    at /Users/xxx/node_modules/grunt/lib/grunt/file.js:55:29
    at Array.forEach (native)
    at processPatterns (/Users/xxx/node_modules/grunt/lib/grunt/file.js:53:34)
    at Object.file.expand (/Users/xxx/node_modules/grunt/lib/grunt/file.js:110:17)
    at /Users/xxx/node_modules/grunt-ts/tasks/ts.js:318:48
    at next (/Users/xxx/node_modules/grunt-ts/tasks/modules/utils.js:336:23)
    at /Users/xxx/node_modules/grunt-ts/tasks/modules/utils.js:342:9
    at invokeResolver (/Users/xxx/node_modules/es6-promise/dist/commonjs/promise/promise.js:42:5)
    at new Promise (/Users/xxx/node_modules/es6-promise/dist/commonjs/promise/promise.js:29:3)
    at asyncSeries (/Users/xxx/node_modules/grunt-ts/tasks/modules/utils.js:329:12)

Actual paths sensored.
Had I knows existance of this parameter earlier I could have debugged more.. :)

This is the full grunt config.
        // Typescript compiler
		ts: {
			production: {
				src: ['src/ts/main.ts'],
				out: 'src/js/main.js',
				options: {
					module: 'amd',
					target: 'es5',
					sourceMap: false,
					declaration: false,
					noImplicitAny: false,
					comments: false
				}
			},
            watch: {
                src: ['src/ts/**/*.ts'],
                outDir: 'src/js',
                watch: 'src/ts',
                options: {
                    module: 'amd',
                    target: 'es5',
                    sourceMap: true,
                    declaration: false,
                    noImplicitAny: false,
                    comments: true
                }
            },
            // All files separate
            development: {
                src: ['src/ts/**/*.ts'],
                outDir: 'src/js',
                options: {
                    module: 'amd',
                    target: 'es5',
                    sourceMap: true,
                    declaration: false,
                    noImplicitAny: false,
                    comments: true
                }
            }
		},

grunt ts:development used as the command to run just the development part. The stacktrace points to line which is executed only if options.watch exists. Added some logging and the options look like this at that point:
Running "ts:development" (ts) task
{ warnings: [],
  errors: [],
  watch:
   { src: [ 'src/ts/**/*.ts' ],
     outDir: 'src/js',
     watch: 'src/ts',
     options:
      { module: 'amd',
        target: 'es5',
        sourceMap: true,
        declaration: false,
        noImplicitAny: false,
        comments: true } },
  comments: true,
  declaration: false,
  module: 'amd',
  noImplicitAny: false,
  sourceMap: true,
  target: 'es5',
  CompilationTasks: [ { src: [Object], out: undefined, outDir: 'src/js' } ],
  tsconfig: null,
  removeComments: false,
  fast: 'watch',
  compile: true,
  htmlOutDir: null,
  htmlOutDirFlatten: false,
  htmlModuleTemplate: '<%= filename %>',
  htmlVarTemplate: '<%= ext %>',
  failOnTypeErrors: true,
  emitGruntEvents: false,
  targetName: 'development' }

Not sure if this is intended to include all target configuration merged (or something like that?). Seems the options get messed up in optionsResolver.resolveAsync().

I suspect it's because you're using watch as a target.  watch is one of the options we use for grunt-ts that gets passed along to Grunt. https://github.com/TypeStrong/grunt-ts#watch  So Grunt is trying to call indexOf on the object.
Perhaps you could rename it to w or watched or live or something?

I created a demo for this and my theory was correct - using watch as the target name causes this issue.  Technically, this was a bug that was fixed in 5.0 since watch should be settable on the ts object to apply to all targets.
I think the best solution is to ban reserved words as target names within grunt-ts - and we should throw a hard error like "The grunt-ts keyword 'watch' cannot be used as a target name." or something, rather than failing in a confusing way that produces GitHub tickets.
@jounii I know that's not awesome to hear, but does that make sense?

After looking at this more, I think a warning is more appropriate.  That way if it works, great, if not at least people know why.
These will throw warnings:
'amdloader', 'html', 'htmlOutDir', 'htmlOutDirFlatten', 'reference', 'testExecute', 'tsconfig', 'templateCache', 'vs', 'watch'.
This should be in v5.3.0-beta.5.

OK, make sense in that regard. Of course not sure why you would want the options flat on the root object. Many plugins seem to use options property for the default shared options, probably just because of this mix-up with target names. Easy to override target names people use.
I renamed my target now to "watcher".

Great.  Yeah we use some options on the target (those above) but most on the options object.  Thanks for the report!

This is resolved via a warning in grunt-ts v5.3.0 which was just pushed to npm.  Please comment or re-open if there are any remaining issues.  Thank you for contributing!  You're in the patch notes.

I just ran into the same issue. Had a default target for the build process which does not watch files and a separate target for development that does watch files. The only hint in the console was:

Warning: pattern.indexOf is not a function Use --force to continue.

I did not get any other warning or error message and renaming 'watch' to 'dev' solved the problem.

Are you on latest grunt-ts?

yep, in my package.json: "grunt-ts": "^5.5.1"

Thanks! @noelklein

What version of node and grunt are you using @Cdvalencia / @noelklein  ?

@nycdotnet
"grunt": "~0.4.4",
"grunt-angular-templates": "^1.0.3",
"grunt-asset-injector": "^0.1.0",
"grunt-autoprefixer": "~3.0.4",
"grunt-build-control": "DaftMonk/grunt-build-control",
"grunt-concurrent": "~2.2.1",
"grunt-contrib-clean": "~1.0.0",
"grunt-contrib-concat": "~1.0.0",
"grunt-contrib-copy": "~1.0.0",
"grunt-contrib-cssmin": "~1.0.1",
"grunt-contrib-htmlmin": "~1.1.0",
"grunt-contrib-imagemin": "~1.0.0",
"grunt-contrib-jshint": "^1.0.0",
"grunt-contrib-less": "^1.2.0",
"grunt-contrib-uglify": "~1.0.1",
"grunt-contrib-watch": "~1.0.0",
"grunt-dom-munger": "^3.4.0",
"grunt-env": "~0.4.1",
"grunt-express-server": "~0.5.2",
"grunt-google-cdn": "~0.4.0",
"grunt-karma": "~0.12.2",
"grunt-mocha-test": "~0.12.7",
"grunt-newer": "~1.1.2",
"grunt-ng-annotate": "^2.0.1",
"grunt-node-inspector": "~0.4.1",
"grunt-nodemon": "~0.4.1",
"grunt-open": "~0.2.3",
"grunt-protractor-runner": "^3.0.0",
"grunt-rev": "~0.1.0",
"grunt-svgmin": "~3.1.2",
"grunt-usemin": "~3.1.1",
"grunt-wiredep": "~2.0.0",

@Cdvalencia ty - what node version?

8.1.3
8.1.2
7.0.0

4.5.0 (Currently using 64-bit executable)

'Warning: pattern.indexOf is not a function Use --force to continue.'
Upgrading my version of node (was v6) fixed things for me.


Cli updates

I have opened a new request so ignore the last one. Here are my changes to the CLI output:

Added a json flag for raw output of network show, network list, node show and node list.

Added prettytables for network, node and switch outputs.

Here is my current output:
-bash-4.2$ hil node list all
+-----------+
| node list |
+-----------+
|   node1   |
|   node2   |
|   node3   |
|   node4   |
+-----------+
-bash-4.2$
-bash-4.2$ hil node show node1
MAIN TABLE
+-----------+-------------+
| ATTRIBUTE | INFORMATION |
+-----------+-------------+
|  project  |     proj    |
|    name   |    node1    |
+-----------+-------------+

NIC TABLE
+-----------+---------------------+
| ATTRIBUTE |     INFORMATION     |
+-----------+---------------------+
|   label   |         nic1        |
|  macaddr  |  aa:bb:cc:dd:ee:01  |
|   switch  |       switch1       |
|    port   |       te1/0/11      |
|  networks | network1(vlan/1510) |
|           |                     |
+-----------+---------------------+
+----------+-----------------------+
|  label   |          nic2         |
| macaddr  |   ab:cd:ef:gh:ij:34   |
|  switch  |        switch1        |
|   port   |        te1/0/12       |
| networks | fancy_name(vlan/1512) |
|          |  fibernet(vlan/1513)  |
|          |  network1(vlan/1510)  |
|          |                       |
+----------+-----------------------+
+----------+---------------------+
|  label   |         nic3        |
| macaddr  |  qw:er:ty:ui:op:56  |
|  switch  |       switch1       |
|   port   |       gi1/0/11      |
| networks | internet(vlan/1511) |
|          |                     |
+----------+---------------------+

METADATA TABLE
+----------------+-----------------+
| METADATA LABEL |  METADATA INFO  |
+----------------+-----------------+
|      SSD       |   Samsung_EVO   |
|      RAM       | Kingston_hyperx |
|   Processor    |     Intel_i5    |
|  Power_Supply  |   Corsair_650   |
+----------------+-----------------+
-bash-4.2$
-bash-4.2$ hil network list
+--------------+------------+--------------+
| network name | network id | project name |
+--------------+------------+--------------+
|  fancy_name  |    1512    |     proj     |
|   network1   |    1510    |     proj     |
|   internet   |    1511    |     proj     |
|   fibernet   |    1513    |     proj     |
+--------------+------------+--------------+
-bash-4.2$
-bash-4.2$ hil network show internet
+-----------------+-------------+
|    Attribute    |     Info    |
+-----------------+-------------+
|      owner      |     proj    |
|                 |             |
|       name      |   internet  |
|                 |             |
|      access     |     proj    |
|                 |             |
|     channels    | vlan/native |
|                 |  vlan/1511  |
|                 |             |
| connected-nodes | node1->nic3 |
|                 | node2->nic4 |
+-----------------+-------------+
-bash-4.2$
-bash-4.2$ hil switch list
+-------------+
| switch list |
+-------------+
|   switch1   |
|   switch2   |
+-------------+
-bash-4.2$

What are your opinions?

I was able to add a title to the tables instead of having a lousy label text on top. But since I'm looping on the NIC table I wasn't able to remove the title from the individual NIC sections like shown in the previous output. So I just have an empty row between each section. How does this look?
-bash-4.2$ hil node show node1
+-------------------------+
|        MAIN TABLE       |
+-----------+-------------+
| ATTRIBUTE | INFORMATION |
+-----------+-------------+
|  project  |     proj    |
|    name   |    node1    |
+-----------+-------------+
+-----------------------------------+
|             NIC TABLE             |
+-----------+-----------------------+
| ATTRIBUTE |      INFORMATION      |
+-----------+-----------------------+
|   label   |          nic1         |
|  macaddr  |   aa:bb:cc:dd:ee:01   |
|   switch  |        switch1        |
|    port   |        te1/0/11       |
|  networks |  network1(vlan/1510)  |
|           |                       |
|   label   |          nic2         |
|  macaddr  |   ab:cd:ef:gh:ij:34   |
|   switch  |        switch1        |
|    port   |        te1/0/12       |
|  networks | fancy_name(vlan/1512) |
|           |  fibernet(vlan/1513)  |
|           |  network1(vlan/1510)  |
|           |                       |
|   label   |          nic3         |
|  macaddr  |   qw:er:ty:ui:op:56   |
|   switch  |        switch1        |
|    port   |        gi1/0/11       |
|  networks |  internet(vlan/1511)  |
|           |                       |
+-----------+-----------------------+
+----------------------------------+
|          METADATA TABLE          |
+----------------+-----------------+
| METADATA LABEL |  METADATA INFO  |
+----------------+-----------------+
|      SSD       |   Samsung_EVO   |
|      RAM       | Kingston_hyperx |
|   Processor    |     Intel_i5    |
|  Power_Supply  |   Corsair_650   |
+----------------+-----------------+
-bash-4.2$

@radonm suggested that it would be better to have 1 table for node show because that means less scrolling.
@apoorvemohan @mosayyebzadeh you guys are heavy users of the HIL CLI, any opinions on this?

@zenhack Yes sorry actually someone else had also worked on the code with me before and I didn't pay attention to this while completing it. I will clean this up and also upload the switch output by tomorrow. Let me know if you find something else too.

One command should display one table (not multiple), so second option looks better to me

Updates:

Variable name changes for node and networks

Output changes

Raw output to json dumps

Correction to node output for connected nodes including link aggregation

Added switch output with json flags

@RobinKaul Do you think you will have time to finish this, or can someone else take over?

@naved001 It'll be better if someone can take over if you're in a pinch for time.

closing this in favor of #1051


DocPath does not allow network directory locations

I'm getting the "Document path is not correct" error on trying to use a directory on an NAS (I have the Windows Documents redirected from the C drive to \\SERVER\Redirected\Documents).
Looking into it; the issue could be either the file separator regex at line 377 (ModManager.java), where to get a network file to work, the path requires '\\\\', except the replaceAll function is used on it. The new File(path) at line 403 (ModManager.java) may also fail without converting the network path to a URI (though I am not 100% sure on whether the four backslashes circumvents this required change)

Since I don't have the possibility to test, if you could test the linked build
This build : https://drive.google.com/file/d/1u7StGfyjLhDGsqIYpdFYEzTPS3Ef3Sa8/view?usp=sharing
Change line
docPathStr = docPathStr.replaceAll("(\\\\+|/+)", Matcher.quoteReplacement(File.separator));

to
Path path = Paths.get(docPathStr);
path = Paths.get("/").resolve(path.normalize()).normalize();
docPathStr = path.toString();
System.out.println(docPathStr);

(yes, I leave a print of the string in the console in case it could be useful)

Change worked. Everything seems to be recognized. Thanks!


Unable to change keys [Possible Linux only issue]

Whenever I attempt to change a key the key selection goes blank and I'm unable to change it
I'd assume this is a Linux only issue since I havent seen anything in the issues about this.
https://streamable.com/527ozx

May I ask how you injected the linux build into your csgo since instead of using window's DLLs linux uses .SO files (I think)
Did you use a program to inject or is there something else I am missing?

As of now you can bind a key for aimbot and thirdperson on linux. More to come.

As of now you can bind a key for aimbot and thirdperson on linux. More to come.

As of now you can bind a key for aimbot and thirdperson on linux. More to come.

Thank you.

As of now you can bind a key for aimbot and thirdperson on linux. More to come.

Thank you.

May I ask how you injected the linux build into your csgo since instead of using window's DLLs linux uses .SO files (I think)
Did you use a program to inject or is there something else I am missing?

check how it's done in aimtux, it was internal too

May I ask how you injected the linux build into your csgo since instead of using window's DLLs linux uses .SO files (I think)
Did you use a program to inject or is there something else I am missing?

check how it's done in aimtux, it was internal too