game data for 2017 regular season

This project is awesome!
Now that the 2017 regular season schedule is out, at what point will we be able to access the schedule with the following? =>
>>> import nflgame
>>> nflgame.games(2017)
[]

Thank you!
Nick

Or maybe a better question is this => Is there a way to access the full upcoming schedule with the nflgame package?
Thank you!
Nick

In file nflgame/live.py if you comment out line 73 and uncomment line 68 you should then be able to run update_sched.py --year 2017 in your nflgame site-packages directory.

The work-a-round is nice to have but how might I write this in a maintainable way?

Also this isn't working for me.  I can see the games in nflgame.sched.games as well as schedule.json... however nflgame.games(2017) is not working for me.

nflgame.games only looks at games that have already taken place.
My schedule has only the first game of the preseason currently in it after running the nflgame-update-schedule script.
import nflgame

year = 2017
week = 0
kind = 'PRE'

past_games = nflgame.games(year=year, week=week, kind=kind)
for game in past_games:
    print game

print '-'

future_games = [game for game in nflgame.live._games_in_week(year=year, week=week, kind=kind) if game['eid'] not in [g.eid for g in past_games]]
for game in future_games:
    print '{} at {} on {}/{} {}'.format(game['away'], game['home'], game['month'], game['day'], game['time'])

-
DAL at ARI on 8/3 8:00
[Finished in 0.7s]

I see. Whats the best way to access the upcoming games?

As far as I can tell, the NFL hasn't updated the schedule page we use yet.
http://www.nfl.com/liveupdate/scorestrip/ss.xml

I dont understand why i'm seeing the game data in schedule.json then...
also... the data seems to be in nflgame.sched.games...
>>> import nflgame
>>> nflgame.sched.games.popitem()
(u'2017123114', {u'week': 17, u'meridiem': u'PM', u'gamekey': u'57488', u'season_type': u'REG', u'away': u'SF', u'year': 2017, u'month': 12, u'eid': u'2017123114', u'time': u'4:25', u'home': u'LA', u'wday': u'Sun', u'day': 31})

Well, I'll be...
In that case, you should be able to use the code above to view the games week by week:
import nflgame

year = 2017
week = 17
kind = 'REG'

past_games = nflgame.games(year=year, week=week, kind=kind)
for game in past_games:
    print game

print '-'

future_games = [game for game in nflgame.live._games_in_week(year=year, week=week, kind=kind) if game['eid'] not in [g.eid for g in past_games]]
for game in future_games:
    print '{} at {} on {}/{} {}'.format(game['away'], game['home'], game['month'], game['day'], game['time'])

I believe the data is there because i ran
python update_sched.py --year 2017

Could you break down this line for me?  I'm not THAT familiar with python ;)
[game for game in nflgame.live._games_in_week(year=year, week=week, kind=kind) if game['eid'] not in [g.eid for g in past_games]]
Particularly the first part... [game for game....
I'm assuming this somehow takes the results of the for loop?

That's a list comprehension.
even_numbers = [n for n in [0, 1, 2, 3, 4] if n%2 == 0]
print even_numbers
alt_even_numbers = []
for n in [0, 1, 2, 3, 4]:
    if n%2 == 0:
        alt_even_numbers.append(n)
print alt_even_numbers

[0, 2, 4]
[0, 2, 4]

This line:
future_games = [game for game in nflgame.live._games_in_week(year=year, week=week, kind=kind) if game['eid'] not in [g.eid for g in past_games]]

can be rewritten as follows:
past_game_eids = []
for g in past_games:
    past_game_eids.append(g.eid)

future_games = []
for game in nflgame.live._games_in_week(year=year, week=week, kind=kind):
    if game['eid'] not in past_game_eids:
        future_games.append(game)

Nice! I could read it and tell what it was doing but it's nice to put the name to it.  Thank you very much for your attention to my questions.
Is there no easy way to pull the entire schedule from 2017 into an object? Just curious.

Have you looked at all at nfldb?
import nfldb

db = nfldb.connect()
q = nfldb.Query(db)
q.game(season_year=2017, season_type='Regular')
for game in q.as_games():
    print game

Prints out every game in the 2017 regular season.
Your query can be further filtered like so:
import nfldb

db = nfldb.connect()
q = nfldb.Query(db)
q.game(season_year=2017, season_type='Regular')
q.game(team='MIN')

for game in q.as_games():
    print game

Regular 2017 week 1 on 09/11 at 06:10PM, NO (0) at MIN (0)
Regular 2017 week 2 on 09/17 at 12:00PM, MIN (0) at PIT (0)
Regular 2017 week 3 on 09/24 at 12:00PM, TB (0) at MIN (0)
Regular 2017 week 4 on 10/01 at 12:00PM, DET (0) at MIN (0)
Regular 2017 week 5 on 10/09 at 07:30PM, MIN (0) at CHI (0)
Regular 2017 week 6 on 10/15 at 12:00PM, GB (0) at MIN (0)
Regular 2017 week 7 on 10/22 at 12:00PM, BAL (0) at MIN (0)
Regular 2017 week 8 on 10/29 at 08:30PM, MIN (0) at CLE (0)
Regular 2017 week 10 on 11/12 at 12:00PM, MIN (0) at WAS (0)
Regular 2017 week 11 on 11/19 at 12:00PM, LA (0) at MIN (0)
Regular 2017 week 12 on 11/23 at 11:30AM, MIN (0) at DET (0)
Regular 2017 week 13 on 12/03 at 12:00PM, MIN (0) at ATL (0)
Regular 2017 week 14 on 12/10 at 12:00PM, MIN (0) at CAR (0)
Regular 2017 week 15 on 12/17 at 12:00PM, CIN (0) at MIN (0)
Regular 2017 week 16 on 12/23 at 07:30PM, MIN (0) at GB (0)
Regular 2017 week 17 on 12/31 at 12:00PM, CHI (0) at MIN (0)

I've considered it but it seemed unnecessary/additional complication.  I am developing a simple office pool app that requires simple schedule data with win/loss...
Instead I have a very simple psql db and i'm using nflgame to import things once a season.

@derek-adair nfldb's database is extremely simple and follows a straight-forward relational model: http://burntsushi.net/stuff/nfldb/nfldb-condensed.pdf

Sure, i get that.  However, I only need two of those tables (Team/Game) and have quite a bit of other custom junk that I have tacked on for the app.  In the future I will consider making the switch but that requires some changes I'm not prepared to take on in this current round of development.  Also lazy.

If you don't want a DB and don't mind parsing a little JSON you can check out my espn scraper https://github.com/andr3w321/espn_scraper
import espn_scraper as espn

scoreboard_urls = espn.get_all_scoreboard_urls("nfl", 2017)
for scoreboard_url in scoreboard_urls:
    data = espn.get_url(scoreboard_url, cached_path="cached_json")
    week = data['content']['sbData']['week']['number']
    for event in data['content']['sbData']['events']:
        print(event['season']['type'],
              event['season']['year'],
              week,
              event['competitions'][0]['competitors'][0]['team']['abbreviation'],
              event['competitions'][0]['competitors'][0]['score'],
              event['competitions'][0]['competitors'][1]['team']['abbreviation'],
event['competitions'][0]['competitors'][1]['score'])

outputs
1 2017 1 DAL 0 ARI 0
1 2017 2 CAR 0 HOU 0
1 2017 2 MIA 0 ATL 0
1 2017 2 BUF 0 MIN 0
1 2017 2 BAL 0 WSH 0
1 2017 2 NE 0 JAX 0
1 2017 2 CLE 0 NO 0
1 2017 2 GB 0 PHI 0
1 2017 2 CHI 0 DEN 0
1 2017 2 NYG 0 PIT 0
1 2017 2 CIN 0 TB 0
1 2017 2 KC 0 SF 0
...etc

As a long-term user of nflgame, to me one of the biggest annoyances is the need to manually edit _CUR_SCHEDULE or git pull in order to get schedule updates for postseason, or for a new season.
Is there not some way in code to get nflgame to detect when the season type has changed, and switch the _CUR_SCHEDULE url automatically?

Just tried to update schedule for 2017 & no luck...
cartier@cartier-VirtualBox:~/Documents/nflAPI/lib/python2.7/site-packages/nflgame$ python update_sched.py --year 2017
Last updated: 2017-08-10 15:27:08.076242
Updating (2017, PRE, 0)...
Updating (2017, PRE, 1)...
Updating (2017, PRE, 2)...
Updating (2017, PRE, 3)...
Updating (2017, PRE, 4)...
Updating (2017, REG, 1)...
Updating (2017, REG, 2)...
Updating (2017, REG, 3)...
Updating (2017, REG, 4)...
Updating (2017, REG, 5)...
Updating (2017, REG, 6)...
Updating (2017, REG, 7)...
Updating (2017, REG, 8)...
Updating (2017, REG, 9)...
Updating (2017, REG, 10)...
Updating (2017, REG, 11)...
Updating (2017, REG, 12)...
Updating (2017, REG, 13)...
Updating (2017, REG, 14)...
Updating (2017, REG, 15)...
Updating (2017, REG, 16)...
Updating (2017, REG, 17)...
Updating (2017, POST, 1)...
Updating (2017, POST, 2)...
Updating (2017, POST, 3)...
Updating (2017, POST, 4)...
But when trying to get 2017 season after updating

import nflgame
season = nflgame.games(2017)
Traceback (most recent call last):
File "", line 1, in
File "/home/cartier/Documents/nflAPI/lib/python2.7/site-packages/nflgame/init.py", line 229, in games
return list(games_gen(year, week, home, away, kind, started))
TypeError: 'NoneType' object is not iterable

I'm certain live.py was using http://www.nfl.com/liveupdate/scorestrip/ss.xml for the URL & there's clearly data there... is it a must to use the database or did I leave something out?

no games will appear in nflgame.games() until they are completed.  That query is looking for regular season games by default.  If you want to see the completed pre-season games (AFTER running the command you did to update the schedule), try this...
s = nflgame.games(year=2017, kind="PRE")
If you want to return a list of games not played, i've found the best way is to use _search_schedule.
import nflgame
s = nflgame._search_schedule(year=2017)

Also I agree with @kirkman that the manual aspect of updating/maintaining schedules is... not desirable.


Add an example a customer asked about

I haven't checked the syntax myself. It's what the customer reported finally working. Eric, I figured you would know for sure.


Adjust README wording to make first steps clearer.

I found the process of getting started (especially with my own PDFs) somewhat confusing based on the README (see Issue for details).
Here's an attempt to make some of the wording more clear.

Let me know if my proposed amendment is clear

I could imagine users not too familiar with the concepts of the host system and container might get a bit confused by the bit after the mkdir command (e.g. “the root of the filesystem” implicitly referring to the container's file system). If you ask me, I'd argue it's enough for someone to know that they might have to create the directory. Knowing that an equivalent exists within the container doesn't strike me as super relevant for getting the system up and running.
Also, just a minor thing, but I feel the following bit beginning with “For instance, you can [...]” now sounds a bit weird (i.e., what is “for instance” now referring to?). Maybe something like “Below you can see an example of how to download, preprocess, and assign some PDFs:” would be better fitting.

Gotcha, that makes sense. Let's merge as is.

“For instance, you can [...]” now sounds a bit weird (i.e., what is “for instance” now referring to?).

I think it just meant to be analogous to "For example", as to emphasize that the command that follows doesn't have to be executed verbatim. Feel free to propose additional verbiage changes as you see fit -- any improvement in clarity is a good move!

Thanks for accepting the PR. ^_^

“For instance, you can [...]” now sounds a bit weird (i.e., what is “for instance” now referring to?).

I think it just meant to be analogous to "For example", as to emphasize that the command that follows doesn't have to be executed verbatim.

Agreed. Sorry for not making my point clear there. I was trying to say that directly following the paragraph starting with “In order to run a local environment”, the “For instance” is clear—it gives an example of how to go about running a local environment. However, if the “For instance” follows the bit about creating a directory, it reads a bit as if what follows also is about the skiff directory. But that might just be me.
In any case

Feel free to propose additional verbiage changes as you see fit -- any improvement in clarity is a good move!

sure! If I come across something I'll send another PR. :)


New Internals for RC

based off the bestselling novel  this PR creates the listeners that will respond when Connectors emit events.
It does not yet touch connectors apart from creating an AbstractConnector they will inherit from

Codecov Report

Merging #267 (443f8d8) into master (5178456) will increase coverage by 1.33%.
The diff coverage is 85.54%.

@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
+ Coverage   63.14%   64.48%   +1.33%
==========================================
  Files          71       74       +3
  Lines        1620     1698      +78
  Branches      230      241      +11
==========================================
+ Hits         1023     1095      +72
+ Misses        415      410       -5
- Partials      182      193      +11

Impacted Files
Coverage Δ

packages/react-celo/src/utils/local-storage.ts
54.16% <75.00%> (+0.67%)
:arrow_up:

packages/react-celo/src/utils/resurrector.ts
77.77% <77.77%> (ø)

packages/react-celo/src/utils/persistor.ts
85.71% <85.71%> (ø)

packages/react-celo/src/connectors/common.ts
71.87% <90.00%> (+8.23%)
:arrow_up:

...ckages/react-celo/src/connectors/wallet-connect.ts
62.12% <100.00%> (+1.18%)
:arrow_up:

packages/react-celo/src/constants.tsx
69.60% <100.00%> (+0.60%)
:arrow_up:

...act-celo/src/hooks/use-wallet-connect-connector.ts
15.21% <100.00%> (+1.88%)
:arrow_up:

packages/react-celo/src/screens/placeholder.tsx
100.00% <100.00%> (ø)

packages/react-celo/src/screens/private-key.tsx
47.36% <100.00%> (ø)

packages/react-celo/src/utils/updater.ts
100.00% <100.00%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5178456...443f8d8. Read the comment docs.


Image resize dimensions in the Dataloader

I wonder about the operation In the following lines:
https://github.com/yhenon/pytorch-retinanet/blob/ef2c16f4ad66b652b836be36465ee63c978f3194/retinanet/dataloader.py#L363-L364
I assume that it suppose to round up the image dimensions to the closest number divisible by 32.
But, when the dimensions already divisible by 32 there is an Extra padding to the image.

For example for image in size 608x608px  :   32 - rows%32 = 32-0 = 32 .
So the image will pad with Extra pad_w=32 pixels.

Suggested change for example:
 pad_w = ( 32 - rows%32 ) % 32
 pad_h = ( 32 - cols%32 ) % 32

I would like to hear your opinion.
Erez.

pytorch-retinanet/retinanet/dataloader.py

I think the pictures have same size after collater operation in dataloader.


Moved the default values table

Moved the article from the keywords folder to the builtin-types folder where it looks to fit better. As for TOC, it's updated according to the trend of getting rid of the "Reference tables for types" node.

Thanks @pkulikov
I've approved this PR, and I'll :shipit: now.


Add Notice to Rate Spread Calc

Add the following banner to the Rate Spread calc page:

7/18/2019: Two sets of APOR values were published for the week of 03/04/19 and 06/17/19. The APOR values published by the Bureau and incorporated into the Bureau’s rate spread calculator are available in the tables accessible from this page.

Add to the banner at the bottom of the page.

@wpears  Can you add this to the text already on the notice at the bottom of that page, I updated the text to include a date for the new notice.
To distinguish the previous text, lets add 2/16/2018: to the existing block of text there. (via the closed ticket date from #121 )


Rename classes to reflect Discovery Search name change to Data Connect

The main change is expected to be to the DiscoverySearchClient which will be renamed DataConnectClient.
The fasp.search sub-package will retain its current name. It's siblings are named fast.loc and fasp.workflow and roughly correspond to DRS and WES/TES functions respectively. However, the packages include equivalent functionality from other sources and are named to reflect the functionality covered rather than the specific GA4GH specification used.

Created branch from master for rename work
Renamed DiscoverySearchClient as above
Renamed the module to data_connect_client.py
Updated scripts and notebooks to use new names
Made some changes to README's and notebooks which refer to search
Still to do. Comprehensive review for references to Search in text of notebooks, README's etc.


It seems that some files are missing

Hello, I am very interested in your work, and I am very happy to see the open source work, but I found that the get_Mahalanobis_score method under score.py does not seem to be provided, and the code of the ImageNet experiment is missing, is it convenient to provide it later?

Hi, the demo code for ImageNet experiment is updated. get_Mahalanobis_score is not used in this demo, so you can ignore it.


Charcode constants confuse hex and decimal

I have:

[x] searched open and closed issues for duplicates: #166 #144

Bug description
I had some problems switching to the correct code page when trying to print characters such as the euro currency sign €, latin characters with diacritics (in my case ä, ö, ü for German texts) and other characters such as 'ß'. After looking into the Constant definitions for a bit and comparing it to the code tables my printer provides (image will follow below), I found out that the constants use the decimal number of the code page (e.g. 14), when the \x escape expects a hexadecimal number (e.g. 0e).
Reproduction example
The following examples assume an arbitrary escpos printer instance is assigned to the name 'printer'.
# should switch to MS-DOS codepage 858 encoding (West european & euro sign)
printer.charcode('EURO')
# BUG: prints '„' (lower double 9 quote) instead of 'ä', '€' is never printed
printer.text('bär, total: 3€\n')
# set the encoding & codepage manually
printer.codepage = 'cp858'
# note the use of \x0e instead of \x14
printer._raw(b'\x1b\x74\x0e')
# this works as expected
printer.text('bär, total: 3€\n')

Device info
Printer: MunByn ITPP047
python-escpos version: 2.2.0
python version: 3.7.* (tried 3.7.3, 3.7.4)
operating system (uname -a):
5.2.2-1-MANJARO #1 SMP PREEMPT Sun Jul 21 12:53:04 UTC 2019 x86_64 GNU/Linux
Improvement Proposal
The Codepage constants are to be extended substantially to represent all available standard codepages. The Codepage constants are to be modified to set the correct codepages.
Generally, I would like to change the charcode function to work in two different fashions:

Input a number which represents the codepage to be set via the actual ESCPOS command, as well as a CodecInfo object which can convert Python strings into codepage-compatible bytestrings. Very useful if the printer has additional, weird or misplaced code pages.
Input a string which represents a Python encoding to be used. The Printer sets the codepage variable to the according CodecInfo by using codecs.lookup(name) and sends an ESCPOS command to the printer. The codepage to send to the printer will be obtained through a lookup dictionary which maps Python encodings to codepage numbers. (I am fully aware that not all Python encodings will be compatible with at least one codepage, the best example being utf-8. This is an acceptable shortcoming, as such encodings produce printing errors at the present time and would continue to do so.)

This will mean that the codepage variable contains a CodecInfo object with conversion capabilities, and not just an encoding string. This will allow the use of non-registered codecs as well as registered codecs obtainable through the codecs.lookup(name) method.
Final words
As I don't currently have the time to do work on this library, I currently cannot implement the changes myself. Also, I don't know how the situation is on other printers and whether there is a general problem with the constants (or is it just me? maybe). When I find some time, I will definitely implement the above changes and attach PRs to this issue. When some does it before me: Great, thanks!
I am very open to suggestions and/or changes regarding the API change proposed above.
Thank you all very much in advance, kleinesfilmröllchen
PS: image of codetables:

PPS: if you were guessing, yes, I am German, please don't judge my English too hard :)

It occurs to me that most of the time, instead of the unknown characters, nothing is printed at all, so expect that result as well if you are testing this.

Proposed Labels: bug easy

Hi, thank you for the extensive report. Have you tried more current versions of the project than v2.2?

Hey, sorry for leaving this dormant for a year.
I have not worked with the printer over the last year because the project had been finalized and we'll only need it to run it in about half a year. Also, I don't have it on hand right now, so I can't check whether upgrading to escpos 3+ will work. I'll however put a (mental) pin in this and do the upgrade tests as soon as I get the printer back.

I ran into this issue while trying to print Swedish text (with "ÅÄÖ/åäö" characters) on the Munbyn ITPP047 with python-escpos 2.2.0.
The issue seems to be fixed in 3.0a8 though, as I don't have to specify a codepage manually for my characters to be printed correctly.

No further feedback, seems to be fixed in v3


There is an error in the connections between CustomNodes.

Describe the Bug
description
I have created two CustomNodes and customized the Handle positions. However, when I connect them, I noticed that the endpoints of the connection line do not align with the rendered positions, but rather with the initial Handle positions.
there is my code:
The ParamHandle controls the position and style of the Handle, with the topOffset parameter specifically affecting the Handle's position. However, it seems that when performing endpoint connections, the Edge is not reading the actual computed position, but rather a different position.
 function ParamHandle({name, id, type ,isSource}: any) {
    /** @type {React.RefObject<HTMLDivElement>} */
    const [flowInstance] = useAtom(flowInstanceAtom)
    const topOffsetAtom = useMemo(() => atom(0), [])
    const ref: React.MutableRefObject<HTMLDivElement | undefined> = useRef<HTMLDivElement>();
    const updateNodeInternals = useUpdateNodeInternals();
    const [topOffset, setTopOffset] = useAtom(topOffsetAtom);
    useEffect(() => {
        if (ref.current && ref.current.offsetTop && ref.current.clientHeight) {
            setTopOffset(ref.current.offsetTop + ref.current.clientHeight / 2);
            updateNodeInternals(id);
        }
    }, [id,ref, ref.current, ref.current?.offsetTop, updateNodeInternals])

    useEffect(() => {
        updateNodeInternals(id);
    }, [topOffset, updateNodeInternals])

    return (
            // @ts-ignore

{name}

            <Handle type={isSource ? "source" : "target"} id={id} position ={ isSource ? Position.Right : Position.Left}
                    className={`-mr-0.5  w-3 h-3  border-2 dark:bg-gray-800`} style = {{top:topOffset}}
                isValidConnection = {(connection)=>valideConnect(connection,flowInstance)}
            />

    );
};

ActorNode use ParamHandle
function ActorNode({id}:any){

    const updateNodeInternals = useUpdateNodeInternals();

    return (

 Actor

             {/*<ParamHandle name={PromptComponentEnum[PromptComponentEnum.prompt]} id={ParamTypeToNodeType(PromptComponentEnum.prompt)} isSource = {false} />*/}
            <ParamHandle name = "A" id={ParamTypeToNodeType(PromptComponentEnum.prompt)} isSource = {false}/>

    );
}

Please help me, I've spent an entire day trying to figure out why this is happening. I couldn't find the answer I was looking for on the official website or Google. I'm a beginner in React and React Flow.
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue

When I connect two nodes using the drag-and-drop method, an error occurs. However, when I use the click method to connect them, it works correctly.

When I drag the Edge, it snaps to a position,but the snapped position is not aligned with the rendered Handle position.  Instead, it snaps to the initial position, which is the incorrect position.

Expected behavior
I would like to see the two Handles correctly connected together.
Screenshots or Videos

Platform
Chrome
Additional context
No response

I could imagine that you don't need to calculate anything in order to position the handles. I am also pretty sure that that's the root of the issue here. The new position isn't rendered yet and updateNodeInternals is called to early. Why are you not overwriting the default handle location with a fixed value? Check this example: https://reactflow.dev/docs/examples/overview/ (overview.css).

Please re-open with a codesandbox (https://new.reactflow.dev/react-ts) or repo.


Connecting to MotherDuck with saas_mode=true returns Permission Error

Consider the following dbt profile:
jdw:
  outputs:
    dev:
      type: duckdb
      schema: jdw
      path: 'md:jdw_dev?saas_mode=true'
      threads: 4
      extensions:
        - httpfs
  target: dev

When running dbt build, this error is returned to the terminal: Permission Error: File system LocalFileSystem has been disabled by configuration
dbt logs are below - believe it needs to auth to MotherDuck first and then read the catalog, not attempt to read the catalog from local first.
12:55:54.564054 [debug] [MainThread]: Sending event: {'category': 'dbt', 'action': 'invocation', 'label': 'start', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x107226ba0>, <snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x106ffb170>, <snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x107275c10>]}

============================== 12:55:54.565821 | 965f4632-3809-4cdb-b962-a1c79e6389eb ==============================
12:55:54.565821 [info ] [MainThread]: Running with dbt=1.8.5
12:55:54.566120 [debug] [MainThread]: running dbt with arguments {'printer_width': '80', 'indirect_selection': 'eager', 'log_cache_events': 'False', 'write_json': 'True', 'partial_parse': 'True', 'cache_selected_only': 'False', 'profiles_dir': '/Users/jacobmatson/.dbt', 'fail_fast': 'False', 'debug': 'False', 'log_path': '/Users/jacobmatson/code/jdw/logs', 'warn_error': 'None', 'version_check': 'True', 'use_colors': 'True', 'use_experimental_parser': 'False', 'no_print': 'None', 'quiet': 'False', 'empty': 'False', 'log_format': 'default', 'invocation_command': 'dbt build --threads=1', 'warn_error_options': 'WarnErrorOptions(include=[], exclude=[])', 'introspect': 'True', 'target_path': 'None', 'static_parser': 'True', 'send_anonymous_usage_stats': 'True'}
12:55:54.652719 [debug] [MainThread]: Sending event: {'category': 'dbt', 'action': 'project_id', 'label': '965f4632-3809-4cdb-b962-a1c79e6389eb', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x104f7c5c0>]}
12:55:54.675700 [debug] [MainThread]: Sending event: {'category': 'dbt', 'action': 'adapter_info', 'label': '965f4632-3809-4cdb-b962-a1c79e6389eb', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x107317c80>]}
12:55:54.676139 [info ] [MainThread]: Registered adapter: duckdb=1.8.2
12:55:54.683166 [debug] [MainThread]: checksum: 643640a45b16e0d012867be4ac17daaa0c3ce97300faec3ce9a6de300b5e1c09, vars: {}, profile: , target: , version: 1.8.5
12:55:54.722496 [debug] [MainThread]: Partial parsing enabled: 0 files deleted, 0 files added, 0 files changed.
12:55:54.722710 [debug] [MainThread]: Partial parsing enabled, no changes found, skipping parsing
12:55:54.735009 [debug] [MainThread]: Sending event: {'category': 'dbt', 'action': 'load_project', 'label': '965f4632-3809-4cdb-b962-a1c79e6389eb', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x110026810>]}
12:55:54.772713 [debug] [MainThread]: Sending event: {'category': 'dbt', 'action': 'resource_counts', 'label': '965f4632-3809-4cdb-b962-a1c79e6389eb', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x110027080>]}
12:55:54.772937 [info ] [MainThread]: Found 25 models, 24 sources, 410 macros
12:55:54.774389 [info ] [MainThread]:
12:55:54.774644 [debug] [MainThread]: Acquiring new duckdb connection 'master'
12:55:54.776749 [debug] [ThreadPool]: Acquiring new duckdb connection 'list_jdw_dev'
12:55:54.797769 [debug] [ThreadPool]: Using duckdb connection "list_jdw_dev"
12:55:54.797967 [debug] [ThreadPool]: On list_jdw_dev: /* {"app": "dbt", "dbt_version": "1.8.5", "profile_name": "jdw", "target_name": "dev", "connection_name": "list_jdw_dev"} */

    select schema_name
    from system.information_schema.schemata

    where catalog_name = '"jdw_dev"'

12:55:54.798091 [debug] [ThreadPool]: Opening a new connection, currently in state init
12:55:55.681082 [debug] [ThreadPool]: DuckDB adapter: Error running SQL: /* {"app": "dbt", "dbt_version": "1.8.5", "profile_name": "jdw", "target_name": "dev", "connection_name": "list_jdw_dev"} */

    select schema_name
    from system.information_schema.schemata

    where catalog_name = '"jdw_dev"'

12:55:55.681726 [debug] [ThreadPool]: DuckDB adapter: Rolling back transaction.
12:55:55.682787 [debug] [MainThread]: Connection 'master' was properly closed.
12:55:55.683354 [debug] [MainThread]: Connection 'list_jdw_dev' was properly closed.
12:55:55.683687 [info ] [MainThread]:
12:55:55.684026 [info ] [MainThread]: Finished running  in 0 hours 0 minutes and 0.91 seconds (0.91s).
12:55:55.684447 [error] [MainThread]: Encountered an error:
Runtime Error
  Permission Error: File system LocalFileSystem has been disabled by configuration
12:55:55.686160 [debug] [MainThread]: Resource report: {"command_name": "build", "command_wall_clock_time": 1.1479763, "process_user_time": 0.905537, "process_kernel_time": 0.136788, "process_mem_max_rss": "154533888", "command_success": false, "process_in_blocks": "0", "process_out_blocks": "0"}
12:55:55.686713 [debug] [MainThread]: Command `dbt build` failed at 12:55:55.686622 after 1.15 seconds
12:55:55.687035 [debug] [MainThread]: Sending event: {'category': 'dbt', 'action': 'invocation', 'label': 'end', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x107275c10>, <snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x10768b020>, <snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x107638290>]}
12:55:55.687338 [debug] [MainThread]: Flushing usage events

Thanks @matsonj for reporting! This looks like it's not a bug in dbt-duckdb, but I am investigating and will follow up here once we figure it out.

Hi @matsonj , just to loop back with you on this - it looks like a patch for a security vulnerability that caused this error. It will be fixed in DuckDB 1.1.0. I'm going to close this since it's not related to dbt-duckdb.


SDK-3825: update 2.3 C++ samples to support drowsiness

Added support for Drowsiness, can be enabled using --drowsiness. Can write drowsiness data to CSV file and overlaid output video.
Adding everyone to review.

General comment about refactoring the program options logic ... I think there are a set of options that are common to webcam and video modes, and PlottingImageListener only cares about these common options.  We could implement those common options in a base class with the video and webcam options being subclasses, or maybe even simpler would be to break out the video and webcam options into two additional, unrelated structs used only within the video and webcam apps.  But let's do that in a separate PR.


Fixed broken link for Baidu's WARP CTC

Description
This PR fixes a broken link for Baidu' WARP CTC as was pointed out in this Github Issue : #12528 .
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] Changes are complete (i.e. I finished coding on this PR)
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@szha


Update Travis to test with latest Django

Update  .travis.yml to test with latest Django versions.

I'd like to do it

@Matusf thanks
Django security releases issued: 1.10.3, 1.9.11 and 1.8.16

PR merged. Thank you.


Support Elastic Tabstops

ref: http://nickgravgaard.com/elastic-tabstops/

FYI, here is my experimental implementation for Atom: https://github.com/hax/atom-elastic-tabstops

@hax Maybe they can consider the Sulime Text's implementation, which is adding spaces before tabs. It will perform better compatibility if you copy and paste the code into someplace else.

@be5invis But it's not REAL Elastic Tabstops and lose many benefits of it. And as the original author, such implementations could not call itself "Elastic Tabstops". 🐹

@hax I think an extension is insufficient. Maybe you should push a PR.

@be5invis I think you are right, and that's why I didn't start to migrate my implementation for atom to vsc 🤔

This would be pretty nice to have.

@be5invis is it that the extension API is not deep enough to support this feature?

Is there a chance we will see this implemented?

Is there a chance we will see this implemented?
I also need to do this sometime !

@lillem4n @martin-t I beg to differ. This argument (espoused by the author of the original concept, no less) was what IMHO prevented the adoption of elastic tabstops back in the days of Sublime Text when there was a pretty nice plugin for it.
The sad truth is we can't make elastic tabstops ubiquitous overnight; in an editor that does not support them, tab-based elastic tabstops would look wrong. However, the space-based approximation is completely portable - one could even maintain the alignment manually (like some of us do anyway), with the plugin taking over if available. A sort of "progressive enhancement", if you wish.
Thanks for the plugin link @djmisterjon, I'm going to give it a spin now.

@egasimus I see your point, but that implementation is something else. Indentation with tabs and alignment with spaces is enhancement from just spaces, but the risk there is it never progresses. It just works "good enough" and will stay that way. I'd love indentation perfection. :)

At the risk of making the issue TO...
@egasimus Automatically creating tables with spaces might be a step in the right direction for some uses but it needs a different name. A lot of codebases avoid adjusting the column width in tables because it creates too much diff noise (which arguably is an issue with diff algos being too primitive). Calling it elastic tabstops will turn people off from it even though the true elastic tabstops would solve their issues.
Reusing the name of a good idea for a half-baked implementation is really not cool. At best it creates confusion among people who know both implementations and they end up talking past each other - both using the same terms but meaning different things. At worst people who don't know any better run into the bad implementation and discard the whole idea as bad. In my experience people are very prone to confusing bad ideas and bad implementations and the effort spent explaining "no, i mean the true elastic tabstops, they don't have these issues" is time that could have been spent more productively.

Oh, also, it is already named "Smart tabs": https://www.emacswiki.org/emacs/SmartTabs :)

Smart tabs is using spaces for alignment, so you get the same diff problems that were already mentioned.

@ExE-Boss Yes, that was my point. Smart tabs already exists as a different concept and does not solve the problem fully that elastic tabstops does.

As many have pointed out, any implementation that uses spaces for alignment instead of tabs absolutely misses the point of "elastic tabstops" and should not be called such. Space alignment has that "diff problem" but the biggest issue is, in my opinion, that it assumes monospace font which is an absolute deal-breaker for anyone who likes to use proportional fonts (and "proportional" here does not necessarily mean some quirky Comic Sans, but very decent semi-proportional code fonts such as iA fonts or Input Sans).
Why would someone want to use proportional font for code? For variety of reasons. It is simply aesthetically pleasing when letters have their own space and aren't forced to fit into uniform rectangles (more elaborate argument here). When one writes markdown, it is very sensible to use such proportional font. Elastic tabstops would be then an absolute killer feature for markdown tables — one could use proportional fonts and align table columns whithout needing to adjust all other rows — and the tabs would behave as in any text processor.

aligns struct declarations using the elastic tabstops algorithm

Important distinction, it’s called “elastic tabstops lite”:

This hack looks at cells above and below the one that's being edited and appends/removes spaces to/from the ends of them to keep things lined up. It changes the contents of the buffer (ugh!) rather than changing the view.
This does keep things aligned but it has some significant disadvantages over proper elastic tabstops:
only works with monospaced fonts
means text cannot be replaced outside the editor through the use of sed etc. and still line up
mixes tabs and spaces
columns of text suddenly jump to the next fixed tabstop position once a cell gets too wide
obviously an ugly hack

Inserting spaces in the buffer to push text to the next fixed tabstop position is obviously an ugly hack but I'm charitably going to call this "elastic tabstops lite" since it does have a similar effect even if the tabstops aren't being moved at all. If you end up implementing this hack, please use the name "elastic tabstops lite" so that users don't get confused.

Is it possible to add spaces only in view, stripping them when saved to disk?
This still won't work with proportional fonts.

4 years (T_T)

Do we have an idea of the work breakdown required to actually implement this functionality?

I don't know if this helps, but I just opened an issue on the Monaco repo: https://github.com/microsoft/monaco-editor/issues/1973
Since this is a lower-level feature and the maintainers of these repos may not be the same, my hope is that they may actually give answers on what would be needed to support this.

I implemented Elastic Tabstops Lite.
It's just a temporary solution though.

I made Elastic Tabstops Mono.
This time it's a Visualization, not Formatters (not modify file).
Only works with monospaced fonts though.
Still a temporary solution though.
I keep both extensions because both have pros and cons.

I made Elastic Tabstops Mono.

Oooh really cool! What’s the disadvantage of that one compared with ETL?

I made Elastic Tabstops Mono.

Oooh really cool! What’s the disadvantage of that one compared with ETL?

Everything is broken:

Cursor position around tab
Vertical block selection
...

Is it possible to get font width?
At least if I assume monospaced fonts used.

I've used elastic tabstops in a few different contexts and I have always found them to be absolutely wonderful.
If we could get them to go mainstream I really think it would be a major, positive revolution in how we format code.
If VSCode would implement them (and after the botched multi-cursor horrorshow that is presented as "column selection" in VSCode, I have to emphasize: implement them correctly), I think it could go a long way towards making the concept mainstream.
They really are great. If you haven't ever looked into them, check out Nick's site, as mentioned in the OP:
http://nickgravgaard.com/elastic-tabstops/
I dream of a day when people just expect elastic tabstops in every editor, by default, the same way they currently expect static tabstops now.

If VSCode gets support for them, it would stop me from moving to Emacs and implementing them there. I know Emacs already handles mixed fonts/sizes inline quite well, allowing e.g. WYSIWYG markdown editing.
My motivation is that I want multi-column alignment to work for the font I will be using regardless, which is Input Sans, likely in a lighter, narrower variant than the default (but that depends on the screen and setup).

The day elastic tab stops get implemented is the day I will switch from Sublime to VSCode.

Is there a fundamental issue that makes this hard to implement? I wouldn't mind contributing with some guidance.

 Any implementation would need to be able to set the width of every individual \t character separately and dynamically.

 Any implementation would need to be able to set the width of every individual \t character separately and dynamically.

I did that.
Scroll up to Jul 27, 2020.

@markonius One of the idiosyncrasies of vscode that I'm aware of is that tabs are implemented using space characters. I believe that's a reason why all the solutions so far only work with monospaced fonts.
alexdima put together a prototype extension here which caught my eye: https://github.com/microsoft/vscode/issues/115307#issuecomment-769783361. It apparently replaces the tabs rendered by vscode with inline content. Perhaps that's a place to start?

@isral
Is the extension working for the latest vscode version right now? How do you trigger the tab stop format function? Which shortcut or mouse click input should I do?

@Trung0246
I'm currently using the mono version (not lite) on VS Code 1.57.1.
Try enable in settings > extension > elastic tabstops
I try to message you but both our github accounts are private.

That elastic tabstops work with proportional fonts is important for me because I would use them in Markdown or LATEX tables, and proportional fonts are useful for Markdown and LATEX because Markdown and LATEX have paragraphs of text, and these are much more readable with proportional fonts than with monospaced fonts.

this one can be also interesting.
https://www.npmjs.com/package/eslint-plugin-smarter-tabs

I made Elastic Tabstops Mono.

Very cool!
Seems like it runs into the same problem as some other elastic tabstops implementations: indentation levels being treated as table columns. I think the clean solution is for indent level changes to always imply new table, and for indent tabs to always follow the static tab width. The counterpoint to that would be trailing comments across minimal block changes, e.g.:
if some_condition():     # This condition relates to X
    do_thing()           # Trim the hedges
elif other_condition():  # This condition relates to Y
    do_other_thing()     # Reticulate the splines

which might lend itself to a special case of aligning trailing comments, in the absence of other table features.
+1 to getting a mainline implementation, if elastic tabs became a stock feature in VSCode and Github's web views, it could drive adoption to the point of it being considered a "standard editor feature" within a few months, if not weeks.

I work on a Elastic Tabstops extension for Vscode forked from @isral 's implementation and wrote a detailed documentation on the topic (implementation, issues). It works with monospaced fonts but still suffers from the same annoying issues isral mentioned:

Because tab characters are only stretched visually (via letterSpacing decoration) the internal cursor position is different from the visual cursor position and if you move up or down the cursor jumps left and right randomly and it drives you nuts. This is also the reason why vertical selections are completely off. (see here for an in-depth explanation and here for conversion algorithm).
All other features which rely on tab alignment behave strangly (most notably vertical cursor movement and vertical selection, but also Shift+Tab intendation, code formatting etc.)
There is flickering around the current block on every text change because it's stretched and rendered concurrently on every text change. This could probably be mitigated with performance optimizations.

Despite these shortcomings I've used it ever since because I found reading and formatting much more pleasing and just accept the wacky cursor movement.
The problem right now is that vscode stores tabs in the DOM as <span>    </span> so the whole document is basically a grid of monospaced characters, probably to make all the distance calculations much easier. An extension cannot change the content of the DOM (why?), only decorations (like letter-spacing) or display visual fake-characters (:before property). I tried to intercept the cursor movement and convert between these "coordinate-systems" but it didn't work reliably probably due to some concurrency (..if I remember correctly, it was one year ago).
I think one immediate solution that could work is to convert the whole document to spaces and just use the elastic tabstop logic when characters are inserted or deleted. But this probably requires a lot of performance optimization and caching, as changing the whole document back and forth on every keystroke is going to be slow.
Another intermediate solution would be for vscdoe to allow extension to change the DOM content (at least for the tab-spans). Then it would at least work for monospaced fonts. I don't know what can of worms will be opened by that, but I also don't understand why it isn't allowed. If we could overwrite the tab behaviour however and insert varying numbers of   depending on where the tab is, all the distance and spacing calcuations of downstream features should work out of the box.
The ideal solution of course would be non-uniform tabstops and genuine support for proportional fonts but then vscode needs to calculate distances and spacing based on font-metrics and all features which depend on this have to be re-checked (vertical cursor movement, vertical selection, code formatting, Shift+Tab behaviour etc.) and require fixing. This is a major change and I assume MS will only tackle it if this issue gets a lot more upvotes (right now it's on page 3 ;) ).

I released a new version of my elastic tabstops extension which automatically inserts alignment spaces before elastic tabstops on every text change. Conceptually this is a merge between @isral 's "Elastic Tabstops Mono" (broken cursor movement) and "Elastic Tabstops Lite" (formatter only) but applies the formatting immediately. Because spaces are used together with tabs for alignment the cursor movement is predictable and works. I added options for different spacing of elastic tabstops, storing/omitting the alignment spaces on file save, and fixed indentation levels.
Download!
I documented most details at https://elastic-tabstops.readthedocs.io/implementation.html
Technical details

On every textchange the elastic tabstops are calculated by ignoring all spaces before elastic tabstops
Get text ranges of "spaces before elastic tabstops" (····→) of the document and replace them with alignment spaces directly in the document
Calculate elastic tabstops again with the alignment spaces and apply decorations (letterSpacing) to override the modulos alignment from classic tab interpretion

Another major difference to isral's version is that editors and documents are handled separately because decorations only apply to editors and text changes only apply to documents. Note that in vscode the same document can be opened by multiple editors (split-view) but we only want to insert the alignment spaces in the document once. Also I had to modify the document via a TextEditor (instead of WorkspaceEdit), otherwise the alignments will be written to the undo stack.
Issues
cannot delete alignment spaces: If you try to delete a space it will be immediately added again until you delete the actual tab. This could be fixed by checking for text changes which delete an alignment space and then deleting the tab instead. However a text change can be anything from: one-line insert/replace/delete, multi-cursor insert/replace/delete, search-and-replace, pasting, formatting etc. which all would have to be treated differently, snap-align the cursor to the closest tabstop, apply the change at the corrected position and fix the cursor position afterwards. I think it works very well without it.
files always appear as changed: Because the alignment spaces are written directly into the document it will always appear as changed and vscode will always ask you if you really want to close the file. if the option elasticTabstops.storeSpaces=false it will even ask if you just saved the file because the alignment spaces are removed and then re-added on save.
Vscode
Another intermediate solution for vscode I found is if they could treat decoration: { before: { textContent } } as actual characters which are handled by the cursor movement. Although I think they are intented for "hints" (type hinting, parameter value hinting) which should be ignored by the cursor movement. Maybe this needs a option before: { textContentHandledByCursor: boolean }.
Again I would prefer the ideal solution to get support for proportional fonts.
Please advertize this issue more and make people up-vote it!
Maybe we will get the real solution earlier.

The community has 60 days to upvote the issue.
If it receives 20 upvotes we will move it to our backlog.
If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
The VSCode team said that 20 votes were required, and they would include this feature.
They can’t really be lying to that extent, to the point of not respecting their own charter and implemented protocols, right?
... Or can they?

@jonlepage It says they will move it to their Backlog, which they have. According to the Issues Triaging wiki page, this means:

Our team is in favor of implementing the feature request/fix the issue. The issue is not yet assigned to a concrete iteration. If and when a Backlog item is scheduled for a concrete iteration depends on how well the issue aligns with our Roadmap. We review and update our roadmap at least once every 12 months. The Backlog helps us shaping our Roadmap but it is not the only source of input. Therefore, some Backlog items will be closed as out-of-scope once it becomes clear that they do not align with our Roadmap.

Although the team is in favor of it, there's no guarantee that it will get implemented. But the fact that it's still open means they haven't ruled it out, which is a good thing.

@jonlepage thanks for the link. while github issues are not a democracy I still assume that more upvotes will make them consider it more.

extension is available on the marketplace now: https://marketplace.visualstudio.com/items?itemName=gerold-meisinger.elastic-tabstops-lite-redux

I also like to point out the github monaspace project. It's five different fonts with the same monospace width which can be used for different language features.

githubnext:

Variable fonts are not yet well-supported in VS Code, and it is not yet possible to mix multiple fonts. Stay tuned, we're talking with the VS Code team about it!

looking forward to it!


Variables aren't picked up when generating PHPDoc Blocks.

I've added some variables which I use in the "Includes" tab under "File and Code Templates". Some of these Includes are used are used in "Templates".
An example is the Template PHP Class, which uses the includes PHP File Header and PHP Class Doc Comment, which in turn contain some custom variables.
When I create a new "PHP Class", all variables are filled in correctly.
But when I have an existing file and generate the PHPDoc Block for a class, the variables are not filled in.
Am I expecting to much here? Or is it indeed a bug?

Is it still not possible to do?

Is it still not possible to do?

Yes, this is still true. I created an issue to fix this in PhpStorm: https://youtrack.jetbrains.com/issue/WI-33656


Create an ASP.NET Core app with Vue

Project Templates

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 32a18270-91cd-2a02-2eb8-2c8b1ed03737
Version Independent ID: c58d57e5-a0c2-201d-f6dd-076ad5971fcb
Content: Use Angular with ASP.NET Core
Content Source: aspnetcore/client-side/spa/angular.md
Product: aspnet-core
Technology: aspnetcore-clientside
GitHub Login: @SteveSandersonMS
Microsoft Alias: stevesa

@tdykstra  can you add the symbol showing an external link?

Do you know how to get it in a Markdown file? In Learn site HTML they get it with a data-linktype attribute, e.g. TypeScript programming language I don't think they'll let us put that in a Markdown file, and we can't put it in a .yml file.


Prevent flash when dismissing reCAPTCHA modal

Description
On iOS devices a flash was seen when dismissing the reCAPTCHA modal. This is a small change to fix that issue.
Other changes
N/A
Tested
Tested locally on iOS and Android release builds.
How others should test

Navigate to 'Connect your phone Number'
Enter in a number and tap 'Start'
When the reCAPTCHA modal is served tap 'Close'
Check that no flash is observed.

Related issues

Fixes #2644

Backwards compatibility
Yes

Hey @MuckT, We have verified above issue in Latest iOS Test Flight Release Build V1.36.0 & updated the status in test rails.
Observation:

For iOS Platform: Screen flicker or screen refresh is observed when user taps on close button from re-captcha screen & on the timer screen when user successfully complete re-captcha verification. Minor screen flicker.mp4

Test rail links:
iOS 15 : https://valoraapp.testrail.io/index.php?/tests/view/50652
Device: iPhone 13 mini (15.1.1)
Thanks..!!

Hey @MuckT, We have verified above issue in Latest Android Internal Release Build V1.36.0 & updated the status in test rails.
Observation:

For Android platform: Screen flicker is not observed when user taps on close button from re-captcha screen & on the timer screen when user successfully complete re-captcha verification.

Test rail link:
Android 11 : https://valoraapp.testrail.io/index.php?/tests/view/51719
Device: Samsung Galaxy F41(11.0)
Thanks..!!


Picasso Painting preview does not look like what the final project ends up looking like if screen width is greater than the preview width

Describe the Issue
See this comment on the forum regarding the final version compared to the preview that is shown at the beginning of the project.
Affected Page
https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-intermediate-css-by-building-a-picasso-painting/step-89
Your code

Expected behavior
I expect the final version of the painting to look the same regardless of the width of the preview pane.  I think this project needs to be refactored so that the painting looks the same regardless of the user's screen size.  The elements should not shift around or if they do shift around, they should do so proportionately.  You really notice the differences when you look at the eyes of the characters.  They are hidden in the preview but show up in the final version. Maybe a fixed width for the project should be used.
Screenshots
Preview of project:

Actual final project in preview pane on my screen:

System

Device: [e.g. iPhone 6, Laptop]
OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04]
Browser: [e.g. Chrome, Safari]
Version: [e.g. 22]

Additional context
No response

Pretty sure it would take a major redesign to make that responsive. It is using a lot of fixed px units for the dimensions and positions. It also looks like some of the elements are not inside the proper containers to have the correct relative/absolute relationship.
I will say the image it is supposed to be is also not the easiest to recreate in CSS.
https://github.com/freeCodeCamp/CurriculumExpansion/issues/132#issuecomment-492755813

Pretty sure it would take a major redesign to make that responsive.

Maybe, but something needs to be done here.  It does not have to be responsive.  It either needs to use percentages to keep things aligned correctly or use fixed widths. When I first saw this project over in the curriculumExplansion repo as a prototype, I assumed it would be a fixed width design when it was transposed over to the curriculum.

Sure, it can be made fixed width and just have it overflow as well. Without having looked much at the code I would imagine that would still be quite a few code changes and I'd assume as a result test changes.

I don't know if this necessarily needs to be fixed - but yea, that behavior is a little rough. If someone wants to fix it, I wouldn't oppose.

It sounds like quite an extensive rework would be required. Given that it's still recognisably art, regardless of screen size, I think it's fine as is.


Permanent option display

For use in classic "menu" use cases

This should be possible regardless of whether immediate mode is activated


add callback for text show/hide

Those callback are useful when wanting to display the OS virtual keyboard.
fixes #274
Linux example:
package main

// the file virtual_keyboard_linux.go is used to show the 'onboard'
// vitrual keyboard upon text input.

import (
	"os/exec"
	flutter "github.com/go-flutter-desktop/go-flutter"
)

var onBoard = exec.Command("onboard")

func init() {
	options = append(options,
		flutter.VirtualKeyboardShow(func(){
			err := onBoard.Start()
			if err != nil {
				return
			}
		}),
	)
}

I plan to tag this into the next minor (or major) release.


Add default importability setting

Summary
Add default importability setting for applying @package or @private to entire project without adding JSDoc.
I think it's similar thought with https://github.com/uhyo/eslint-plugin-import-access/issues/2.
Sorry for the sudden, but I hope you take a look when you have time!

Released as v1.1.0. Thank you 🎁

Thank you too!


07/23/2018 14:18 : Create Pull Request for branch prTesting_2018072314 -> master

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[Feature] Warning for profane language

As a community being inclusive is important and language plays a big role in keeping a community inclusive. Feature request to warn people for not using English or using profane or slangs in the chat.

I want to give it a shot.

Hey @kaiwalyakoparkar. I want to give it a shot to this issue.

@SriSatyaT Good to hear that. Go for it if you need any help let me know :)

@kaiwalyakoparkar Sure!

@kaiwalyakoparkar I have some doubts. Lets have a discussion?

@kaiwalyakoparkar Have an issue.

bot is popping a message when I use restricted words as well.

Let's have a discussion?

@kaiwalyakoparkar Facing an issue here.

@SriSatyaT okay, don't worry. I will help you with some resources and will look into the issue.

hey @kaiwalyakoparkar I can try this when I have time

@ctnkaan go for it. I will assign it to you. Let me know if you need any help

PR #79 fixes this issue


Path routing broken for micro-frontends

Description
If the micro-frontend is configured to use path routing instead of hash routing, Luigi will perform full-page iframe reload instead of letting the micro frontend's router take care of navigation.
Expected result
Micro frontend SPA performs navigation without page being reloaded.

Troubleshooting
Looks like luigi.navigate event is performing window.location.replace every time navigation event occurs. This is bad :).

detection of mf routing method is required.
if path routing used, use history.push api

Related: https://github.com/kyma-project/luigi/issues/452
Needs to be fixed, to make https://github.com/kyma-project/console/issues/750 fully working

Fixed for Angular/Vue/React routers in #500 . Bear in mind that merging this solution will break catalog/instances views in Console because of https://github.com/kyma-project/console/issues/798


[FEATURE REQUEST] Upgrade to latest Flutter version

Upgrade the AllSQL Flutter app to the latest version of Flutter, along with all the dependencies.

Hello @masteradit , I can work on this

Hello @masteradit , I can work on this

Hi @rohithmada00, apologies for the late reply. I had already completed this a few days ago, it was a pretty big change as the dependencies we were using are no longer supported. So I decided to rewrite the entire application from scratch and also organise the code in a better way. I will be creating more issues soon, so feel free to star this repo and keep an eye on the issues tab.


disable_bootstrap_checks not documented

Describe the bug
When attaching an agent the following can be logged

WARNING: -Xverify:none and -noverify are not supported by the Elastic APM Java Agent. In an upcoming version, the agent will not start when these flags are set, unless the system property elastic.apm.disable_bootstrap_checks is set to true.

However, there is no mention of the disable_bootstrap_checks  property in the docs.
Steps to reproduce
Attach 1.23.0 agent to an OpenJDK-11 JVM started with -Xverify:none.

It should also emphasise that it needs to be set as a system property (of the target JVM?). Passing it as agent config doesn't work.

Thank for reporting.
This is not a regular agent config option - it needs to be read very early on bootstrap, before any agent mechanism, including the config mechanism, starts up. So we do not document it as part of the agent configs, and so we do not need to explain how it is not an agent config.
Instead, the warning message only talks about it as a system property.
Currently, this is a warning. In future release, we will fully enable this bootstrap check, so the agent will not start by default when these configs are set. When we do that, we may add a note as we do in the supported JVMs.


Template to Broadcast Button Required

Email Template -> Broadcast
Notification Template -> Broadcast
this is to send Email to multiple Contact/Companies from Template pages after creating New Template
Required by @vinpahilwani
Discussed over Phone

#318 this is Required to do this


Negative word for you

Hello, sry why you close my PR

Sry, I couldn’t understand this task. It's not your PR's fault.


refactor: do not expose state caches outside regen

Motivation
State cache handling is a very sensitive part of Lodestar and should be handled with care. Exposing the state cache data structure directly encourages assumptions about which state may or may not be available. IMO consumers should always go through regen as the ultimate provider of any state under some constraints (sync only, allow replay, etc)
NOTE: there's no change of logic**, just added enough new methods to map 1:1 current unstable

Related to https://github.com/ChainSafe/lodestar/issues/4005

Description
Make state caches data structure internal to regen only

:tada: This PR is included in v1.9.0 :tada:


Feature Idea: Advanced Git Parsing

It would be useful to have advance git parsing.
Could possibly use https://github.com/linrongbin16/giturlparser.lua
This would allow for some neat features:

Opening directly to a file:

https://github.com/moyiz/git-dev.nvim/blob/5808fe220441a7ed70a2882d91912353337c6035/README.md

Opening up with a specific branch checked out:

https://github.com/neovim/neovim/tree/release-0.9
Happy to help with a PR.
Thanks for the awesome plugin!

I was just checking the repo to see if this was somehow possible. It'd be a great thing to add!

It sounds like a great idea, thanks for the suggestion!
It could possibly imply future support for opening repositories and files directly from shell nvim https://github.com/.... (this claim needs to be verified).
At this stage I prefer to not add "hard" dependencies to this project.
Notice that the URLs in the issue are vendor specific and not actual Git URIs (e.g. GitLab would have a /-/ in the URL to separate repository from blob / tree references, Gitea / Forgejo / Codeberg use totally different format).
giturlparser.lua is not aware of the differences between different git hosting platforms and won't be able to extract refs and specific file paths from it (which makes sense, since these are not actually valid Git URIs). Implementing a complete vendor aware URL parser that should cover all of these nuances, but it would take some time.
A possible alternative for the moment could be to extend / replace GitRef object to support file field, which could instruct the opener function of a specific file in the repository to auto-open. For the first example, it could be something similar to :GitDevOpen moyiz/git-dev.nvim '{ref="5808fe220441a7ed70a2882d91912353337c6035",file="README.md"}'.
Pros: quick, control is the user hands. Con: No seamless "copy-paste" support for URLs from browser, which seem to miss the purpose of this suggestion.
I will try to play with the vendor aware URL parser, so I am leaving this issue open.
Feel free to jump in with thoughts / suggestions :slightly_smiling_face:

This is awesome! 🥳


Add connection filtering

Merge in connection filtering and fixes associated with that.

I had to rework things a bit to merge nicely but this PR contains your connection filtering changes and some minor fixes.


in/decreased size vs enlarged/small, etc

Some terms in MP have primary term name of "enlarged X" and may or may not have "increased X size" as a synonym.
Other terms in MP have primary term name of "increased X size" and may or may not have "enlarged X " as a synonym.
A similar situation exists for decreased and small in term names.
This should be reconciled; at a minimum the appropriate synonyms should be added to all terms.
Reported by: cindyJax
Original Ticket: obo/mammalian-phenotype-requests/956

Reviewing size terms


Node version

See photo:

I cannot replicate this. Did you recently update Node.js from 12.11.1 at all (soemthing might have cached somewhere)?

@oznu @netRunner0 i could replicate this. I also use the homebridge-hue-Plugin, so the "bug" (not really one though) was the same on my setup.
I updated nodejs from 12.14.1 to 12.16.2. After the update, the terminal shows the correct version, but it takes 1 or 2 restarts and some time before it has actually been recognized in the config-ui-x. As you said @oznu, it will have something to do with cached files.

I can confirm the same.
Just updated to latest stable node, even after 2 restarts of homebridge-ui the version on statuspage is behind

Are you running with hb-service @tooh? If so you may need to ensure the UI is actually restarting (it decides if it needs to restart, or if only Homebridge needs to restart when you restart Homebridge via the UI). You can force a service restart by running:
sudo hb-service restart

@oznu  running hb-service restart solved it

Thanks @tooh, you can do a full restart from the Homebridge Settings section.


camelCase

Would there a possibility to get camel casing behind a flag?
This would be great feature in few cases. For example a web-app which uses multiple APIs and some of them return camel case. Would be great if everything would use the same casing.

Can you provide a short example of the current output and the output you'd like to see?

For example a table of users:
CREATE TABLE users (
	  first_name VARCHAR(50) NOT NULL
);

Which now would produce:
type User struct {
	FirstName    string    `json:"first_name"`
}

But what would be nice to have, is the ability to have json tags with camel case, for example:
type User struct {
	FirstName    string    `json:"firstName"`
}

So basically an option to say underscores in a table definition should be converted to camel case.

It's working well if the column name on the table is snake case:
CREATE TABLE users (
	  first_name VARCHAR(50) NOT NULL
);

it produce:
type User struct {
	FirstName    string    `json:"firstName"`
}

but when the table column name is in the camelCase:
CREATE TABLE users (
	  firstName VARCHAR(50) NOT NULL
);

it produce:
type User struct {
	FirstName    string    `json:"firstname"`
}

I tried to use both json_tags_case_style: none and json_tags_case_style: camel but those option produce lowercases


[BUG]: Unable to make project public

Scenario: Sharing a Project
Step: 2. Making Project Public
Link to the project: https://app.staging.terarium.ai/projects/a2a48418-dc22-4e72-a7b6-45ae28e3998c/overview

Issue:

Unable to change a project from private to public access

Currently the code checks that all users that can WRITE to a given project can make that project public or private.  Ideally this should be modified back to only users that can ADMINISTRATE.  I was going to change the SpiceDB permissions for the Admin Group to have that permission, and then we can alter the code as we see fit.


Move project id lookup out of requests

Current dependencies on/for this PR:

main

PR #361

PR #362   👈

This comment was auto-generated by Graphite.


Remove linting and semistandard as a feature

BREAKING CHANGE: This change removes semistandard from the project entirely.  It is now removed from the Dockerfile, and from the dependencies.  The lint command has also been entirely removed.  Please use prettier and eslint instead.
Fixes #168

Thanks. Can you cut a release?


docs: arch docs for SDS

We should have arch docs for SDS, both as a high level topic, and in all the cases where we talk about other xDS.
cc @qiwzhang @lizan @PiotrSikora @JimmyCYJ any interest in picking this up?

I think it is better to have this doc before 1.8.0 release.

Thanks for @qiwzhang picking this up.

Done! Thank you @qiwzhang!


Question: Filter Textfiles

Hi,
not sure if this is the correct place to ask this question, probably not (sorry), but I'd like to know whether it is possible to display a search field above the table to filter the tabledata. The filter should work on all columns, not a specific one. So I would like to have kind of a full text search that searches over all columns.

This is definitely possible. But it has very little to do with react-table itself. You'll need to make your own text  field above the table which filters the data prop being passed to react-table. The table will re-render with the newly filtered data.

thanks!


suggestions for documentation

Apologies if this is not a good place to drop this suggestion...
In the endless pursuit of perfection... in PDF page 26 (Setup and Overview) There are images with conflicting project names (QuickstartIdentityServer in one, IdentityServerQuickStart in the other),
but what may prove confusing to a complete novice (such as me) is the quickstart section that follows. It shows all three projects at a point in the documentation where the person stepping through the instructions will have (thus far) created only one. Perhaps an explanatory comment on this or, alternatively, move this section to a later spot in the document after one or both of the other projects has been created?

sheds light on where less skilled sailors will founder on the rocks
Excellent

If you have it set to Current selection then that just means whichever project you currently have selected is the one that will be started if you choose Debug->Start Debugging or Debug->Start Without Debugging.
So ensure you select the server project first and start that.  Give it a little while to start up properly before you start the other projects.

Ah, you caught that third paragraph before I removed it. I'm rather new to Visual Studio but rather than explain what I finally figured out just after posting the comment, I went back and removed it. What had held me up prior this morning's try of the good guidance (Ctrl+F5) was my assumption that I could not start a project after another had begun. Obviously (in hindsight) not true, but I only just discovered that Ctrl+F5 really does allow me to start projects in succession. I decided this problem was far more related to my ignorance than to the document. :)


Allow external secrets in CDK config file

For https://www.medplum.com/docs/self-hosting/datadog
Users don't want to hardcode DD_API_KEY in the JSON file.

Bumping priority on this for customer needs.


Fix some typos in Date.swift

Fixed some typos found in Date.swift.

We should do the same PR for Date.swift in the swift repo.

OK, I'll make a PR.


No robust Validation in forms

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Absence of robust validation in the forms , the users are free to enter any number and any email in the forms.
Describe the solution you'd like
A clear and concise description of what you want to happen.
To address this issue using express-validation and regex techniques.
Allowing server side checking of the data and flashing the users with the respective message inorder to significantly decrease the amount of spam form fills and to notify the user if he/she has entered wrong info mistakenly.
##Record
[x] I agree to follow this project's Code of Conduct
[x] I'm a GSSoC'24 contributor
[x] I want to work on this issue

Kindly assign me this issue under GSSoC24, i would like to work on it


Is there a way to control the color of the label

Received this question from email.

Hope you are doing good !!
I came to know about your d3Kit-timeline library. This is wonderful.
I wanted to know is there a way to control the color of the label. I have to display several items on the time line, but the depending upon some condition the label color should be either green, red or black.
Following is my scenario:-
suppose I have few country name, depending upon the continent these countries labels color should appear on the time line.
Europe
UK            - Red color
Ireland       - Red color
Germany   - Red color
France      - Red color
America
Canada      - Yellow color
USA           - Yellow color
Brazil         - Yellow color
Asia
Japan         - Blue color
India           - Blue color
China          - Blue color
please help me to accomplish this.
Regards,
Shaheen Ahmad

You can set the options "labelBgColor" as a function and compute the color you want from the data point.
var chart = new d3KitTimeline('#chart', {
  labelBgColor: function(d) {
    if(d === 'UK') return 'red';
    else if(d==='Ireland') return 'red';
    ...
    else return 'blue';
  }
})
.data(data);

Please refer to the doc for other options (label text color, etc.).
https://github.com/kristw/d3kit-timeline/blob/master/docs/api.md


Is there a way to scale the ui

 Is there a way to scale the ui because it appears very small.

The latest version scales to the size of your screen now, but there is currently no way to change it further.

Ok thanks

There is a new version of Abnormal V1.1 that has an update UI with the option to change the UI scale. You can get it from V1.1 branch.


Use Intel intrinsics for SHA256

Use Intel SHA extensions for SHA256 when available. Fallback to BMI instructions.

This looks good to me but not unsure about the rationale.
Is it due to improved performance ?

This looks good to me but unsure about the rationale.
Is it due to improved performance ?

Yes, the goal is to improve performance.
I've compared SHA256 performance against the baseline code without CPU extensions on my MacBook (Intel(R) Core(TM) i5-1038NG7 CPU @ 2.00GHz).
The SHA version is about 80% faster than the baseline, and the BMI version is about 15% faster.


Authorization issue - version 3.5.32

When debugging a local bot via the emulator we cannot authorize using the bot Id and password. Here is a screen shot of what we're seeing:

Here is the output from visual studio:

Microsoft.Bot.Connector.MicrosoftAppCredentials+OAuthException: Bad Request ---> System.Net.Http.HttpRequestException: Response status code does not indicate success: 400 (Bad Request).
at System.Net.Http.HttpResponseMessage.EnsureSuccessStatusCode()

Bot Emulator version: 3.5.32
Bot Builder version: 3.9.0
OS/IDE: Windows 10, VS Prof 2015 Version 14.0.25431.01 Update 3
Note: This is working from the web test channel in the portal, but only giving this 400 error from the emulator. We are also using a  custom Credential provider, but have confirmed it is still reading the credentials from our repo correctly:
[BotAuthentication(CredentialProviderType = typeof(BotCredentialProvider))]

I'm also having this issue. Looks to be similar to #1938.

We released version 3.5.33 of the emulator today with a new option in App Settings to use v1.0 authorization tokens. Can you try this?

Also having the same issue. Already updated to 3.5.33 and Used v1.0 authorization tokens.

Also having said issue.

Thank you for reporting this! The emulator's auth endpoint is returning errors for a small percentage of users. We're actively working to solve the problem, and a fix is in validation at this time. I will post back here when the fix is live.

@brandmanager2017 You're seeing a different issue, I believe. You're receiving a 401 error code. Can you verify a few facts for me:

Are you using the C# BotBuilder SDK?
Are you using your own CredentialProvider?

If these two things are true, then you're likely hitting a bug in the C# SDK related to parsing the v2.0 auth token. The workaround is to open the emulator's App Settings dialog and check the "use v1.0 authentication tokens" checkbox. A proper fix for this has been made in the C# SDK and is currently in the release pipeline.

@arthurtina724 Does forcing the use of v1.0 auth tokens resolve the issue for you?

@eanders-MS looks like that solution will work for us, but there are some warnings to move up to the bot builder 3.11.0 or greater. thanks for the help
06:15:39] Warning: The bot is using SDK version 3.9.1.
[06:15:39] Warning: SDK versions earlier than 3.11.0 use an authentication configuration that will no longer work with the emulator after November 15, 2017.
[06:15:39] Warning: For your bot to continue working with the emulator, please update your bot to use an SDK version greater than or equal to 3.11.0.


Comparison against TF-IDF Vectorizer (from scratch)

Description
TF-IDF is one of the most famous algorithms when it comes to keyword extraction from text. Your task is to create a function that will extract keywords from text using the TF-IDF algorithm and compare the results against this library. How similar / different are the results ?
NOTE : You have to build the Tf-idf algorithm for keyword extraction from scratch. You will then compare its performance against sklearn's TfidfVectorizer and rake_new2.
For reference :
For your reference, you may read this link
Folder Structure, Function details
Create a folder tfidf_vectorizer in the root directory. The folder must contain a .py file that will contain the function for extracting the keywords from text using the Tfidf algorithm written from scratch.
Structure : tfidf_vectorizer/extract_keywords_tfidf_scratch.py
Acceptance Criteria

[ ] Code must be properly formatted.
[ ] Code must be accompanied by appropriate comments.
[ ] File structure must be strictly maintained.
[ ] Test cases must be present at the end of the code.
[ ] Variables and functions must be properly named
[ ] IMPORTANT : Make sure requirements.txt file is updated if you are including any new library.
[ ] All instructions provided in the Description must be strictly followed.

Definition of Done

[ ] All of the required items are completed.
[ ] Approval by 1 mentor.

Time Estimation
2.5-3 hours (or more if needed)

Is it okay if I work on this issue during Hacktoberfest?

Is it okay if I work on this issue during Hacktoberfest?

Yes sure @2bit-hack . Just make sure the PR is made after Oct 1.
Assigning it to you.

I have a few questions regarding the implementation:

Will there be a corpus of documents provided against which to run the TF-IDF algorithm?
(Something like get_keywords(document, documents, stopwords)?)
Will these documents be text files or plaintext strings (or potentially both)?
How do I measure performance / accuracy of the implementation versus the other algorithms? Do I perform a diff?

I have a few questions regarding the implementation:

Will there be a corpus of documents provided against which to run the TF-IDF algorithm?
(Something like get_keywords(document, documents, stopwords)?)
Will these documents be text files or plaintext strings (or potentially both)?
How do I measure performance / accuracy of the implementation versus the other algorithms? Do I perform a diff?

You have to run the tf-idf  algorithm on only one document. That document can be a large corpus, or an article, or just 3 lines of text. The function will take in the document, the stopwords and the max_num of keywords the user wants to extract.
If max_num == None, then extract all keywords.
Else, extract max_num keywords.
Default : None
The function will return the keywords along with their tf-idf weights.
Answered in the above point.
The major difference that you will find is the number of keywords extracted, as tf-idf will go over all words but rake_new2 returns phrases mostly. So, in order to compare :
- Choose a small text to work one. Using your knowledge, mark out what according to you are key words/phrases
in the text.
- Extract keywords using both rake_new2 and tf-idf and calculate their recall / precision score (against the
keywords you manually extracted).
- Time both the algorithms (using Python's time library) to see which algorithm extracts keywords faster.

tf-idf is a corpus based algorithm whereas RAKE can work on single documents. Like, if I have a collection of documents, I can figure out the tf-idf scores for a document against all the documents in the corpus. But if there's just one document, will tf-idf still work?

tf-idf is a corpus based algorithm whereas RAKE can work on single documents. Like, if I have a collection of documents, I can figure out the tf-idf scores for words in one document against all the documents in the corpus. But if there's just one document, will tf-idf still work?

See, say you take a corpus of N documents. Like, N Stackoverflow posts for example. Your IDF will depend on all N posts. Do the calculation. Then choose one post, say post_3. Run TF-IDF and RAKE for that chosen document and compare.

Oh, okay. So do I change the function signature to be something like def keywords(docs, selected_doc, stopwords)?

Oh yes..thanks for pointing that out. Yes you change the function to include the corpus.

Alright, thank you so much!

The code for keyword extraction using TF-IDF goes into tfidf_vectorizer/extract_keywords_tfidf_scratch.py. Where do the tests of RAKE vs TF-IDF go? I noticed there's a tests folder, does it go there?

The code for keyword extraction using TF-IDF goes into tfidf_vectorizer/extract_keywords_tfidf_scratch.py. Where do the tests of RAKE vs TF-IDF go? I noticed there's a tests folder, does it go there?

yes, create a separate file in the tests folder.

So far, I've implemented tf-idf and written a main.py file for testing its usage. I've also created a file in tests which runs both RAKE and tf-idf against a document (RAKE is being given just one document, tf-idf is also fed a small corpus), prints the results from extracting keywords, and prints the runtime of both algorithms. I'm a bit confused by the precision scoring thing though. Should I manually assign keywords/phrases/both? If, for instance, RAKE extracts 'object oriented' and tf-idf extracts 'object' (RAKE generally extracts phrases, tf-idf extracts words only), do I score them equally? I'm not quite sure how exactly the F-scores are being calculated.

@2bit-hack Basically you have to toil a bit. What they have done in the paper is that, they have marked out keywords manually. Then they ran the algorithms, and checked which algorithm gave results closer to the ones they had manually derived, and calculated the precision score (TP/TP+FP).
Like, say according to you, 'object oriented' is a keyword(it makes more sense), so you have noted it down. Now according to RAKE, it gave 'object oriented' but TF-IDF gave 'object'. So for RAKE, it is a True Positive, but for TF-IDF, it's a False Positive.
Iterate for all keywords, and calculate the scores for the two algorithms.

@BALaka-18 I've sent a PR, could you please take a look?


update code to use new retirement schema

Move away from the SetMemberSubject#retired_workflow_ids instead use the SubjectWorkflowCount#retired_at field in data dumps and the Subject#retired_for_workflow? method.

@marten this needs to be in before we remove the retired_workflow_ids schema setup.

I was working on something like this too, but hadn't reached a PR yet. Mine is going in this direction, but I don't mind rebasing on yours either:
   def retired_for_workflow?(workflow)
     if workflow && workflow.is_a?(Workflow) && workflow.persisted?
-      set_member_subjects.first.retired_workflow_ids.include?(workflow.id)
+      set_member_subjects.joins(:subject_workflow_counts)
+                         .where(subject_workflow_counts: {workflow_id: workflow.id})
+                         .where.not(subject_workflow_counts: {retired_at: nil})
+                         .any?
     else
       false
     end

and:
-  belongs_to_many :retired_workflows, class_name: "Workflow"
+  has_many :retired_subject_workflow_counts, -> { retired }, class_name: 'SubjectWorkflowCount'
+  has_many :retired_workflows, through: :retired_subject_workflow_counts, source: :workflow
   has_many :subject_workflow_counts, dependent: :destroy
   has_many :workflows, through: :subject_set

   def retire_workflow(workflow)
-    retired_workflows << workflow
-    save!
+    count = subject_workflow_counts.find_or_create_by!(workflow_id: workflow.id)
+    count.retire!
+  end
+
+  def retired_workflow_ids
+    retired_workflows.pluck(:id)
+  end

Right, should have asked. I was looking at the classification & subject dumps earlier and realised that they will be busted if we remove the prev schema. I kinda prefer your explicit relations to be fair but i won't get to work on this again till next week. If this PR is all good then can you just rebase over it?

Also make sure the subjects#set_member_subjects belong to a subject set that belongs to the workflow in question.

Seems like specs fail because the controller spec still sets retiredness with sms.retired_workflows. If you change that the rest is LGTM.

Or let me know if you want me to fix it up btw.


Added mount options for swap partition

@anhvoms : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

#sign-off

@srijang: I'm sorry - only the author of this article, @danielsollondon, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

Merging with PM approval. Thanks for the review @srijang.


Investigate performance impact of making TensorLike strict

Bug / performance issue / build issue
TensorLike is defined as (object,)
Expected behavior
TensorLike should be defined as in the comment in the code (np.ndarray, tf.Tensor, tf.Variable, Parameter). This will require someone checking it doesn't significantly impact performance
System information:

GPflow version: develop

Oh, it's not actually a type annotation, is it? I'm just used to FooLike being a Union of stuff that can (easily) be converted to a Foo. Like PathLike.


fix show_tags for some users

Proposed change
set  show_link_counts = false in FindAllTags second prompt

Type of change

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (thank you!)
[ ] Code quality improvements to existing code or addition of tests
[ ] Documentation update

Additional information
Some users experience an empty dialog after calling show_tags, when the tag has been selected and a prompt with the files that contain the tag should appear.
My understanding is that the flag will call linkutils.generate_backlink_map to get a list of backlinks. I can't see the purpose for the count in the context of showing tags, so I believe that false should be the value for all cases

This PR fixes or closes issue: fixes #226
This PR is related to issue:

Checklist

[x] I am running the latest version of the plugin.
[x] The code change is tested and works locally.
[x] There is no commented out code in this PR.
[ ] The code has been formatted using Stylua (a .stylua.toml file is provided)
[ ] The code has been checked with luacheck (a .luacheckrc file is provided)
[ ] The README.md has been updated according to this change.
[ ] The doc/telekasten.txt helpfile has been updated according to this change.

Ok I will merge this as it seems to fix an issue by disabling a feature with limited benefits in this particular case anyway.
Nonetheless I created #256 as a reminder to look into this a bit more and hopefully fix the issue.


Develop2

Description
Please include a summary of the changes.
Issues Fixed or Closed

Fixes #(issue)

Type of Change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation change (non-code changes affecting only the wiki)
[ ] Infrastructure change (changes related to the github repo, build process, or the like)

Checklist

[ ] My code was submitted to the nightly branch of the repository.

Same with this one you should completely delete it

sorry i didnt wanted to merge anything into your repo. it is just for me to be able to synchronize my tests


Added a command-line argument to vstest.console.exe for setting environment variables

Description
Added /Environment command-line argument to vstest.console.exe for setting up environment variables. Using this switch will force the tests to be run in an isolated process.
Related issue
#669

@msftbot, hold this until @nohwnd approves.

:shipit:


feature: support Two Phases to Start Exec Process like Init

File pr to runc: https://github.com/opencontainers/runc/issues/3453

When containerd 2.0 releases, the embedshim doesn't use runcext to watch the exit event. The embedshim will be migrated into standalone process. So, embedshim will have two options:

still continue to work on runC side
Or use pidfd and sub-reaper to handle


feat: server$ this will be defined most of the times

fixes #3751

Amazing thank you!!

yay!! I'm very excited for this too thank you!!


Disallow parallel synchronization of same collection?

Not sure if the current behavior is dangerous.

Hmm, maybe locking could be seen as a performance enhancement though.

Want to implement this in the next major version.

Unnecessary and only introduces another dependency...


(Vulkan) Make vulkan cross-project

Use library https://github.com/KhronosGroup/Vulkan-Headers/tree/cfebfc96b2b0bce93da7d12f2c14cc01793ae25c

Vulkan is now built statically. Commit 00b1eef.


Groups plugin row date range not working

Hi,
the feature from  https://github.com/angular-gantt/angular-gantt/issues/561 dosen't seem to work, even though I did specify "from" and "to" for the parent row groups with following options:
"groups": {
  "enabled": true,
  "display": "overview",
  "from": "2008-07-24T00:00:00.000Z",
  "to": "2011-07-24T00:00:00.000Z"
},

the child overview is still rendered out site the given range, see the plunker: http://plnkr.co/edit/bIQRRQo0fGPb4QfdViLu?p=preview
How is possible to display childs overview only with in the given range?

Seems to be a bug :(

Thanks for the quick response because I was getting desperate.

Sorry about that :(
angular-gantt lacks unit testing and UI acceptance tests. Feature worked at the time of the commit, but seems broken now.

In fact it's not a bug. It's because your have set display: overview so in this case it just deplay overview of the underlying tasks.
See this one : http://plnkr.co/edit/KkLhpPJA1IwT0RA9JE6M?p=preview

To do want you want, you have to remove display: overview option, and customize the look of the grouping bar with some CSS.

Is it possible implement this feature for display: overview as well?
If you are engaged else where or don't have time for this feature, can you point me where should I implement it so that similar to display:group implementation?
Thanks in advance.

I don't think it really make sense to try to achieve this. I've changed the dates of underlying tasks in your plunkr, and you will see that overview are really overview of tasks, it's not grouping anything ...
http://plnkr.co/edit/FyrpSVAxgJu23cCuOYZj?p=preview
But anyway, if you want to fork this, it's in the groups plugin.

But i'll enhance docs to explain that from/do dates are only used for groups mode.

It really is reasonable to update the docs so that no body else falls into this pitfall.
For my case it's required in order show collisions between tasks. I have made quick & dirty solution for this problem. If same one needs or want to have my solution message me.