Add support for third party NES/SNES controllers

Adds support for the 8BitDo Retro Receiver NES/SNES/SFC Classic Edition.

It is not super clear how is that 8bitdo different from the "Nintendo Super Nes Classic Edition" (aka SNES mini) controler.
It should be the same button with the same code.
I used the Classic Controler and this test code worked fine for me.
https://github.com/jfurcean/CircuitPython_WiiChuck/blob/main/examples/snes_controller_simpletest

The data coming out of third party NES/SNES controllers such as the 8BitDo do not match that of the standard Nintendo controllers when encryption is disabled. The data for the buttons are stored in buffer[6] and buffer[7] instead of buffer[4] and buffer[5]. I have updated this to check if buffer[4] and buffer[5] are all 0. All 0s would indicate that all buttons are pressed which should be impossible to be in that state. On some third party controllers including the 8BitDo the data in buffer[4] and buffer[5] are always all 0.


AccountInfo.getTradingFee() in currency or percent?

Hello, do you know, is  the trading fee returned in currency or in percents? Or does it depends on each Exchange? Thank you!

I think the fee should generally be returned as a fraction, e.g. 0.005 for 0.5% trading fee. It is possible though that there is not much consistency here across exchange implementations in XChange. Those that provide this information will generally simply return whatever the API returns so you should check the API docs of particular exchanges. I just tried a few exchange implementations in XChange: Taurus returns what the API returns (but the API docs don't clearly say what it is), and Bitso, Bitmarkets, Cointrader, IndependentReserve and The Rock don't return anything at all.

I think two kinds of fees have been confused:

fee for doing trades on the exchange (usually %)
"network transaction fee" for withdrawing currency (usually flat)
The exchanges I've looked at so far tend to provide #2 in the api, but I think it's #1 that xchange stores and cares about.

getTradingFee()  should be 1. above and in a percentage. I don;t think we have a "network transaction fee", but it could be that some implementors falsely added that to getTradingFee()  impl.

Thanks for reponses.


Fix bug with multiple GOPATH full package name resolving

This commit fixes the bug where GOPATH values that are longer than the input package name cause 'slice bounds out of range'  errors.

Mind throwing a test on it?

Sure no problem, do you have some advice on how to mock/control build.Default.GOPATH? Or do I need to change the method signature or read the GOPATH environment variable directly?

It looks like its public, can you set it? 😈

If you're about pop into https://gitter.im/gqlgen/Lobby


Bad Responsiveness

the responsiveness of the site needs improvement

@SatyaJaiss , I am assigning this task to you. However, another contributor is currently working on the Signup and Contact Us pages. Once those issues are resolved, I will notify you.

can you help me i solved the issue, how can I submit it?

I have made a PR, kindly review.

i want to work on it To give responsiveness to the webpage


[Feature Request]: New version of this mod for DQ3HD2D

It seems like the community is using this mod for Dragon Quest III HD-2D, a humble request from someone that appreciates your work: can a version of this mod, or at least something similar be made for Dragon Quest III HD-2D?
Thanks in advance, I really appreciate your time.
Found in the wild:
https://www.youtube.com/watch?v=GtPOHgkndr4

Notably, I tested a few of the features that P3RFix provide on DQ3HD2D.  Here is what I found to be working:
Set all other options to false.
FPS Cap works as expected and the FPS in game and in the menu will run at the provided FPS Cap.
[FPS Cap]
AdjustFPSCap = true
Framerate = 144
Screen Percentage does ~seem~ to increase drawing detail, GPU consumption is raised, but this has interesting issues and seems to introduce delays when speaking to NPCs.
[Screen Percentage]
Enabled = true
Value = 200

It makes sense that some parts of P3RFix are working given that DQ3 HD probably uses UE 4.27.2 as well. That said, a game specific fix for DQ3 HD is not really something I can work on without access to the game.

I have a dedicated fix up now for Dragon Quest 3 HD-2D Remake.
https://github.com/Lyall/DQ3Fix


namespaces {}?

I am trying to determine how to get more details about the cause of a failure to import an RDF file.
I attempted to import the file available at https://ebiquity.umbc.edu/get/a/resource/361.rdf
The file successfully loads in Protege 5.20. When I used the procedure CALL semantics.importRDF("Cloud-Security-and-Compliance-Onotology-UMBC-361.rdf","RDF/XML", {shortenUrls: false, typesToLabels: true })
The result was termination status "OK, 0 triples loaded, namespaces { }, extrainfo "".  Started streaming 1 records after 22 ms and completed after 22 ms.
I installed by copying the file https://github.com/jbarrasa/neosemantics/releases/download/<IP_ADDRESS>/neosemantics-<IP_ADDRESS>.jar and following the instructions at https://github.com/jbarrasa/neosemantics.
The installation is on neo4j version 3.4.4, the community edition. I found no log information generated by the failed call to semantics.importRDF.

Hi pbh77, thanks for trying out neosemantics and sorry for the late reply.
The problem is that the RDF file you're trying to load is actually not serialised as RDF/XML, it's Turtle (https://www.w3.org/TR/turtle/).
All you need to do is set the format param to the right value (Turtle in this case) just like this:
semantics.importRDF("Cloud-Security-and-Compliance-Onotology-UMBC-361.rdf","Turtle", {shortenUrls: false, typesToLabels: true })
Let me know if this helps.
JB.


Button rendered without href url on Outlook email

Describe the bug
I'm using MjmlButton in an email template, but apparently in Outlook, the button does not have the href set with the url that is passed to it. Testing on Gmail it works and renders fine.
MJML environment:

OS: Any
MJML Version: 3.1.2

Email sending environment(for rendering issues):

Platform used to send the email: Tempmail; Litmus

Affected email clients (for rendering issues):

Email Client: Outlook
OS: Any
Browser: Multiple

Screenshots

In the example above, only a td element is rendered. In other cases, an a tag is rendered, but without the href, like below:

    Verify Email

I'm not sure this is related to MJML here as the href is in the output HTML
from MJML. There's something on your end that either alter the HTML before
sending, or your url is invalid this version of Outlook completely remove
the href if the url contains a non valid URL
On Tue, Jul 23, 2024 at 10:51 PM Rodrigo Miranda Santana <
@.***> wrote:

Describe the bug
I'm using MjmlButton in an email template, but apparently in Outlook, the
button does not have the href set with the url that is passed to it.
Testing on Gmail it works and renders fine.
MJML environment:

OS: Any
MJML Version: 3.1.2

Email sending environment(for rendering issues):

Platform used to send the email: Tempmail; Litmus

Affected email clients (for rendering issues):

Email Client: Outlook
OS: Any
Browser: Multiple

Screenshots
Screenshot.2024-07-23.at.5.34.37.PM.png (view on web)
https://github.com/user-attachments/assets/ee6af8fc-1c0b-4e55-a6b6-6f0bfa8c5402
In the example above, only a td element is rendered. In other cases, an a
tag is rendered, but without the href, like below:

    Verify Email

—
Reply to this email directly, view it on GitHub
https://github.com/mjmlio/mjml/issues/2886, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAELHTLD5EBYXVJQASJ4PZLZN265NAVCNFSM6AAAAABLLFTH6KVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQZDMMJQGUYDANY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I'm not sure this is related to MJML here as the href is in the output HTML from MJML. There's something on your end that either alter the HTML before sending, or your url is invalid this version of Outlook completely remove the href if the url contains a non valid URL
…
On Tue, Jul 23, 2024 at 10:51 PM Rodrigo Miranda Santana < @.> wrote: Describe the bug I'm using MjmlButton in an email template, but apparently in Outlook, the button does not have the href set with the url that is passed to it. Testing on Gmail it works and renders fine. MJML environment: - OS: Any - MJML Version: 3.1.2 Email sending environment(for rendering issues): - Platform used to send the email: Tempmail; Litmus Affected email clients (for rendering issues): - Email Client: Outlook - OS: Any - Browser: Multiple Screenshots Screenshot.2024-07-23.at.5.34.37.PM.png (view on web) https://github.com/user-attachments/assets/ee6af8fc-1c0b-4e55-a6b6-6f0bfa8c5402 In the example above, only a td element is rendered. In other cases, an a tag is rendered, but without the href, like below:   Verify Email   — Reply to this email directly, view it on GitHub <#2886>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAELHTLD5EBYXVJQASJ4PZLZN265NAVCNFSM6AAAAABLLFTH6KVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQZDMMJQGUYDANY . You are receiving this because you are subscribed to this thread.Message ID: @.>

Sure, but how does MJML handle the href prop that is passed to MjmlButton to prevent it from being invalid for Outlook emails? Seems like it is something it does behind the curtains.

It doesn't do anything it just put it in href as is.
On Tue, Jul 23, 2024 at 11:40 PM Rodrigo Miranda Santana <
@.***> wrote:

I'm not sure this is related to MJML here as the href is in the output
HTML from MJML. There's something on your end that either alter the HTML
before sending, or your url is invalid this version of Outlook completely
remove the href if the url contains a non valid URL
… <#m_3200159729116019348_>
On Tue, Jul 23, 2024 at 10:51 PM Rodrigo Miranda Santana < @.*> wrote:
Describe the bug I'm using MjmlButton in an email template, but apparently
in Outlook, the button does not have the href set with the url that is
passed to it. Testing on Gmail it works and renders fine. MJML environment:

OS: Any - MJML Version: 3.1.2 Email sending environment(for rendering
issues): - Platform used to send the email: Tempmail; Litmus Affected email
clients (for rendering issues): - Email Client: Outlook - OS: Any -
Browser: Multiple Screenshots Screenshot.2024-07-23.at.5.34.37.PM.png (view
on web)
https://github.com/user-attachments/assets/ee6af8fc-1c0b-4e55-a6b6-6f0bfa8c5402
https://github.com/user-attachments/assets/ee6af8fc-1c0b-4e55-a6b6-6f0bfa8c5402
In the example above, only a td element is rendered. In other cases, an a
tag is rendered, but without the href, like below: Verify Email — Reply to
this email directly, view it on GitHub <#2886
https://github.com/mjmlio/mjml/issues/2886>, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAELHTLD5EBYXVJQASJ4PZLZN265NAVCNFSM6AAAAABLLFTH6KVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQZDMMJQGUYDANY
https://github.com/notifications/unsubscribe-auth/AAELHTLD5EBYXVJQASJ4PZLZN265NAVCNFSM6AAAAABLLFTH6KVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQZDMMJQGUYDANY
. You are receiving this because you are subscribed to this thread.Message
ID: @.*>

Sure, but how does MJML handle the href prop that is passed to MjmlButton
to prevent it from being invalid for Outlook emails? Seems like it is
something it does behind the curtains.
—
Reply to this email directly, view it on GitHub
https://github.com/mjmlio/mjml/issues/2886#issuecomment-2246364776, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAELHTNDPLIBC4L5H3Q37ETZN3EWLAVCNFSM6AAAAABLLFTH6KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBWGM3DINZXGY
.
You are receiving this because you commented.Message ID:
@.***>

We don't do anything for this as we don't want to alter your href as you
can use a templating language or anything else on your end. You can try
with a bare example url it should work just fine.
The issue is most likely on your end


print all models

@rultor release, tag is 0.0.26

@rultor release, tag is 0.0.26

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.0.26

@yegor256 Done! FYI, the full log is here (took me 2min)


Islands with a period in name are not detected

What version of HonoX are you using?
0.1.5
What steps can reproduce the bug?
Create an island called something like create-project.form.tsx. Hard refresh.
What is the expected behavior?
It should load the island in devtool's sources tab called /app/islands/create-project.form.tsx.
What do you see instead?
Nothing, the file is not loaded.
Additional information
Naming the island create-project-form.tsx does work as intended.

This is undocumented and worth considering in the future, but is intentional and not a bug.


Updated Bengali Translation

use proper commit messages please (yarn commit or yarn commit:signed)

Do I merge?

Do I merge?

no, check discord


CRA 4 failed to make SASS variables available to JavaScript (OK with CRA 3.x)

How to read SASS variables in JavaScript?
With Create React App 3.x it is possible to make SASS variables available to JavaScript. To make variables available, we simply need to export them with the :export syntax. For example:
$color-black: #000000;

:export {
    colorBlack: $color-black;
}

We can then import the SCSS file into JavaScript to access the variables defined in the file:
import colors from './template/colors.scss';

console.log('colors', colors.colorBlack); // will output #000000 in the console

It can be really useful to export SASS variables. For example, in our projects, we often create custom themes for Material UI to change the colors, the typography, the components... and will also use SASS. Therefore, we can directly import SASS variables in our Material UI theme:
import { createMuiTheme } from '@material-ui/core/styles';

const theme = createMuiTheme({
  palette: {
    primary: {
      main: colors.colorBlack,
    },
    secondary: {
      main: colors.colorBlue,
    },
  },
});

As far as I know, react-scripts use css-loader as a dependency to configure webpack to enable this feature.
More info about :export here and here.
Describe the bug
Create Rect App 4.0.0 cannot read the exported variables. The variables are undefined.
Did you try recovering your dependencies?
Yes.
Which terms did you search for in User Guide?
N/A
Environment
Output of npx create-react-app --info:
Environment Info:

  current version of create-react-app: 4.0.0
  running from /home/user/.npm/_npx/119730/lib/node_modules/create-react-app

  System:
    OS: Linux 5.4 Ubuntu 20.04.1 LTS (Focal Fossa)
    CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
  Binaries:
    Node: 12.18.1 - ~/.nvm/versions/node/v12.18.1/bin/node
    Yarn: 1.22.5 - /usr/bin/yarn
    npm: 6.14.5 - ~/.nvm/versions/node/v12.18.1/bin/npm
  Browsers:
    Chrome: 86.0.4240.111
    Firefox: 82.0.2
  npmPackages:
    react: ^17.0.1 => 17.0.1
    react-dom: ^17.0.1 => 17.0.1
    react-scripts: 4.0.0 => 4.0.0
  npmGlobalPackages:
    create-react-app: Not Found

Steps to reproduce
N.B: You can clone my demo repositories (see below) if you don't want to manually reproduce the bug.
Requirements: you need to setup Sass in Create React App. Please follow the documentation here.

Create a SCSS file
Export a variable with the :export keyword (see example above)
On a JavaScript file or a React Component, import the SCSS file
Try to read the variable

Expected behavior
The value of the SASS variable should be available in JavaScript.
Actual behavior
The variable is undefined.
Reproducible demo
You can close the following repositories and just run yarn start.
With CRA 3:
https://github.com/guicara/create-react-app-3-bug-scss-variable-export

With CRA 4:
https://github.com/guicara/create-react-app-4-bug-scss-variable-export

Anyone have some ideas or suggestions?
Thank you for your help!

I've got some updates...
I have just discovered, that CRA 4 is able to read the SASS variables if the SASS file is named as <name>.module.scss.
In App.tsx of the demo repository, we can do something like that:
import colors from './template/colors.module.scss';

Not ideal but it works.

The issue is not resolved yet.

I've got some updates...
I have just discovered, that CRA 4 is able to read the SASS variables if the SASS file is named as <name>.module.scss.
In App.tsx of the demo repository, we can do something like that:
import colors from './template/colors.module.scss';

Not ideal (these SASS files are not CSS modules in this context) but it works.

yeah this solution works fine, but still issue is not resolved :(

With the new release of CRA (4.0.2), I looked into this again. Unfortunately, it is still not working.
However, after seeing this issue at css-loader, I decided to look into this again and found a more elegant solution than the one described above.
The issue is caused by the fact that in the Webpack configuration offered by Create React App. In there, the non-module scss files have the CSS-loader compileType module (that is the default). Since CSS-loader v4 broke :import and :export, you now need to explicitly specify the compileType to be icss (see https://github.com/webpack-contrib/css-loader/issues/1134).
This can be configured in the css-loader options (the example is given at https://github.com/webpack-contrib/css-loader#separating-interoperable-css-only-and-css-module-features).
This means the Webpack configuration offered by Create React App needs to be modified. Since we use craco in our project, we can do the following.
In craco.config.js:
    style: {
    css: {
      loaderOptions: (cssLoaderOptions, { env, paths }) => {
        // We want to select the CSS loader config for all plain `.scss` files. In the current CRA Webpack configuration,
        // this SCSS rules are defined by using `importLoaders: 3`. To make a distinction between the rules for SCSS modules
        // and plain SCSS files, we need to look for the loaderOptions where no modules are set. The if-statement below
        // filters this and keeps existing CRA configuration for all other rules intact.
        //
        // See https://github.com/facebook/create-react-app/blob/b9963abde5870d46cd906160f98f81dbc0a5ecf2/packages/react-scripts/config/webpack.config.js#L563
        if (cssLoaderOptions.importLoaders !== 3 || cssLoaderOptions.modules) return cssLoaderOptions

        return {
          ...cssLoaderOptions,
          modules: {
            compileType: 'icss',
          },
        }
      },
    },
  },

The above configuration will make exporting SASS variables work again (without renaming files to .module.scss) :tada:.
Of course, this is very hacky and fully depends on the current setup of the CRA webpack configuration. I'll issue a PR ASAP at CRA to fix this over there.

PR can be found here: https://github.com/facebook/create-react-app/pull/10511

The above configuration will make exporting SASS variables work again (without renaming files to .module.scss)

That's great news!
Thank your for the PR @thabemmz. Hope it will be merged soon.

@thabemmz Thanks for looking into this, much appreciated.

Bump

I ran into this issue today while migrating a project into a new CRA4 app. Hoping this gets fixed soon.

Is this fix merged in 4.0.3?

@TakanashiOuken The issue is not resolved yet with 4.0.3

Getting same issues in latest version 4.0.3 and Also having vulnerabilities due to css-loader dependancies

Bump

The .module solution above worked for me, but in case anybody run into this issue: I could not access a sass variable in JavaScript because i exported a variable name starting with $.
Works:
:export {   slideTransitionDuration: $slide_transition_duration; }
Doesn't work:
:export {   $slideTransitionDuration: $slide_transition_duration; }

Looks like the fix was released with CRA v5 but it didn't resolve the issue for me.

Will this fix be backported as a patch in CRA4? Or will we be required to upgrade to CRA5 to resolve this issue without using CRACO?

I'm still having this issue on CRA v5, with and without .module.scss. Did anyone find a solution for v5?


ValueError: Number of features of the model must match the input

I am using random forest model to predict the sales quantity.
I have listed all parts in a row based while the quantity is in a monlthy based (each column represent a month)
During splitting the data in to train and test:
the training data will have less columns than the test set. meaning that I added one month to the test data.
when i run the model, an error is rasied :
ValueError: Number of features of the model must match the input. Model n_features is 22 and input n_features is 23.
Could you please help me on how to tackle this problem.
your help is really appreciated,
thanks in Advanced

Hi, I think i had the same challenge some weeks ago. But this is the issue.
Call the transform method only on your training set. do not use fit_transform method on your set, use just the transform method.


Swift4

Had an issue with xcode 9 new source control so I apologize for the multiple commits/Pull request that may have come through. Most recent one is valid and the one to be merged.

@JPwharton Can you check this?
https://travis-ci.org/ytakzk/Fusuma/builds/244633122?utm_source=github_status&utm_medium=notification


Vi Mode Tr Parse Error

For some weird reason, vi_mode module throws an error for tr when it is at /usr/bin. What is strange is that the variable ${ZVM_MODE} still working fine, but tr cannot make it uppercase. The error is:
tr: misaligned [:upper:] and/or [:lower:] construct

I guess that if I change the symbol to upper case manually I can solve this bug. It is just a few vi modes so it will not be a problem. This must be one of those cases that tr fails in zsh.


I get a warning that could not be found when compiled with gradle libc++_shared.so and libgodot_android.so libraries?

Godot version
3.5.1
Plugin version
1.3.2
Phone information
android 9
Issue description
After compiling as APK, I get the following warning when I run the application.

Steps to reproduce
I received a warning from Gradle during the compilation.
Additional context
No response

Thank you for opening this issue we will investigate this

Are you getting these warning on Android Studio compilation (Plugin development) or on Godot export?
Try to update the Java/Gradle of your PC to check if these warnings still appear.

Closing the issue because this doesn't seem to be from the plugin


[FEATURE] Allow parsers to be extended in Plugin.extend()

Is this a unique feature?

[X] I have checked "open" AND "closed" issues and this is not a duplicate

Is your feature request related to a problem/unavailable functionality? Please describe.
I want to be able to replace/override the HTML parsers for plugins. At the moment the ExtendPlugin doesn't allow for parsers to be specified, so only the default parsers can be used.
A simple use case is to use react-email components when serializing for email optimized HTML
Proposed Solution
Expose parsers in ExtendPlugin so that one can replace the default parsers if needed.
Screenshots
No response
Do you want to work on this issue?
Yes
If "yes" to the above, please explain how you would technically implement this (issue will not be assigned if this is skipped)
Update the ExtendPlugin type..and whatever else needs to happen

Good point.
I'll add it in the next patch releases

hey @mdwt  👋
We built fully functional Email-Builder via @yoopta/email-editor
Check it out in examples: https://yoopta.dev/examples/withEmailBuilder/email-builder


Thoughts on https://www.w3.org/TR/wai-aria-practices/#accordion

Hey!
I'm creating a accordion component myself, and during the research I looked at the WAI-ARIA Authoring Practices 1.1 which contains a section about Accordion together with an example.
I just wanted to check with you guys, if you had read it, and if so, what you think about it.
Cheers

EDIT 2017-10-11: Added links.

@pudgereyem your query is quite open-ended - would you be able to give a little bit of context or perhaps let us know what, specifically, you'd like us to comment on? This is the reference material against which I built react-accessible-tooltip, and though I've only joined react-accessible-accordion relatively recently, I highly suspect it was the source material used here too.

Hi @pudgereyem
It was quite a while ago but indeed, it looks like we were highly influenced by the source repos we used to build this one. Both are using tab and we didn't really question this.
I made the changes here (https://github.com/springload/react-accessible-accordion/pull/32) to follow the ARIA for accordion. Please feel free to comment & give any feedback.
Thanks.

@vincentaudebert @ryami333 awesome. If I get time later I can check out the changes in https://github.com/springload/react-accessible-accordion/pull/32. However, I'm not a user of this repo (as of now). Just wanted to tell you.
Cheers!

No worries I think I will merge it at some point soon as it makes more sense ARIA wise. But just looking for a second opinion.
@ryami333 or @samanthaksanders feel free to jump in too for the review.

I take it we're using simple div's and applying roles and level so that there are no associated styles people will need to apply? If it were me I'd consider using native host language elements like headings and buttons so you wouldn't need to apply these roles and levels. Food for thought anyway.
I also presume we have only made the role region change for the strict accordion option not the multi collapse right?
Avoid using the region role in circumstances that create landmark region proliferation, e.g., in an accordion that contains more than approximately 6 panels that can be expanded at the same time.

Are there any actionables here, or can this issue be closed?

@ryami333 I'll give it more thoughts asap once the new version is out.

Yes we should probably scrap #32 and redo it since we've just released a new version with a lot of updates. Let's move from tab related attributes to the accordion.
For reference here is tab related approach:
https://www.w3.org/TR/wai-aria-practices/#tabpanel
And the probably preferred accordion approach:
https://www.w3.org/TR/wai-aria-practices/#accordion

Thinking big picture here - would it make more sense to actually split this into two different packages (or atleast two different sets of components) - one for the Accordion approach and one for the Tab approach? I think it would be a tidier implementation than the conditional-based approach we have at the moment.

We could @ryami333
Although it looks like supporting both in one package is the "normal" behaviour for most (all?) of the other similar packages and users might expect the same from RAA.

So we might need to split into multiple component sets then, eg.

Accordion, AccordionItem, AccordionItemTitle, AccordionItemBody.
TabPanel, TabPanelItem, TabPanelItemTitle, TabPanelItemBody.

Otherwise, as I mentioned above, this is just going to get too hard to maintain.

I would agree to something like that.
Let's get the aria changed first then we can investigate the full keyboard support and split if it's really necessary? Or you reckon it could be worth to split right now and have clearer maintenance/improvements later on?

Nah fixing the aria first makes sense to me, then we'll work out the next steps.

Hi guys, is this still being worked on?

Heya @teemopower, are you asking if the project is still being worked on, or about this issue specifically? There's not really any actionables here as AFAIK, just some discussion about future direction and priorities.

Spec compliance issues have all been resolved (and strictly browser-tested!) in the upcoming v3.0.0 release. Track progress of that release here and here 🍾


There is no good PHP completion plugin.

There is no good PHP completion plugin.
Can you develop one yourself?

Thanks for reaching out!
Because we treat our issues list as the Atom team's backlog, we close issues that are questions since they don't represent a task needing to be completed. For most questions about Atom there are a lot of options, check out:

User Documentation — The Atom Flight Manual
Developer Documentation — Atom API Documentation
FAQ — The Atom FAQ on Discuss
Message Board — Discuss, the official Atom and Electron message board
Chat — Join the Atom Slack team

On Discuss and in the Atom Slack team, there are a bunch of helpful community members that should be willing to point you in the right direction.


Fix wayland missing cursor.

This fixes the problem with the window automatically closing itself when
the mouse goes over it.

LGTM - but cant check it myself atm.

Thanks!


WIP: Binary sensor class

This is what I was thinking for a binary sensor class, which gives me this:

Requires https://github.com/balloob/home-assistant-polymer/pull/32

Is it mostly to support frontend enhancement? I like it.

I like it very much :dolphin: I think it's good to go.

Okay I'll clean it up tomorrow.


Analize if we want to use factories and service locator pattern for building the app in Main

Closing as for the moment we are using DI and there's no need to add any factory


JOSS Submission Review (Reviewer 2): Test Suite

The current coverage of the test suite is as follows (with pytest-cov)
--------- coverage: platform darwin, python 3.10.14-final-0 ----------
Name                                          Stmts   Miss  Cover
-----------------------------------------------------------------
pyforce/pyforce/__init__.py                       3      0   100%
pyforce/pyforce/offline/__init__.py               0      0   100%
pyforce/pyforce/offline/geim.py                 123    123     0%
pyforce/pyforce/offline/pbdw.py                  51     51     0%
pyforce/pyforce/offline/pod.py                  132     53    60%
pyforce/pyforce/offline/sensors.py              193    193     0%
pyforce/pyforce/offline/weak_greedy.py           80     80     0%
pyforce/pyforce/online/__init__.py                0      0   100%
pyforce/pyforce/online/geim_synthetic.py        108    108     0%
pyforce/pyforce/online/indirect_recon.py         77     77     0%
pyforce/pyforce/online/pbdw_synthetic.py        173    173     0%
pyforce/pyforce/online/pod_interpolation.py      67     67     0%
pyforce/pyforce/online/pod_projection.py         59     59     0%
pyforce/pyforce/online/tr_geim_synthetic.py     141    141     0%
pyforce/pyforce/tools/__init__.py                 0      0   100%
pyforce/pyforce/tools/backends.py               140     63    55%
pyforce/pyforce/tools/functions_list.py          76     16    79%
pyforce/pyforce/tools/plotting.py                69     69     0%
pyforce/pyforce/tools/timer.py                   15     15     0%
pyforce/pyforce/tools/write_read.py             132     81    39%
pyforce/setup.py                                  4      4     0%
pyforce/tests/__init__.py                         0      0   100%
-----------------------------------------------------------------
TOTAL                                          1643   1373    16%

I may have carried out the coverage test incorrectly, but if not, the current coverage seems relatively low. While high coverage does not necessarily guarantee correctness, there are several untested areas in the package, especially some of its key features.
Would the authors consider improving this by selectively testing the most critical areas, at least with some basic sanity checks? Would this require a significant amount of additional work for the current submission? Since the other reviewers have not yet finalized their feedback, I would encourage the authors to consider extending the test suite.
Thank you!

I don't link this issue to the main review thread because I don't think having a particular coverage is a review criteria. So just take it as a (strong) recommendation 😃.

Would the authors consider improving this by selectively testing the most critical areas, at least with some basic sanity checks? Would this require a significant amount of additional work for the current submission?
Thank you very much for the suggestion, I will try to add some tests these days to have a better coverage. It shouldn't be a huge amount of work 😄

I have added more tests for the most important classes here (i plan to add something else for PBDW online, weakgreedy and write_read modules in the coming days):
https://github.com/Steriva/ROSE-pyforce/commit/849b4b587a66d5d53864d79fe24224cf46eeb3ef
Thank you again for your feedback.

I have added the tests in #19 and here's the total coverage
--------- coverage: platform darwin, python 3.10.14-final-0 ----------
Name                                          Stmts   Miss  Cover
-----------------------------------------------------------------
pyforce/pyforce/__init__.py                       3      0   100%
pyforce/pyforce/offline/__init__.py               0      0   100%
pyforce/pyforce/offline/geim.py                 123      6    95%
pyforce/pyforce/offline/pbdw.py                  50      5    90%
pyforce/pyforce/offline/pod.py                  135     20    85%
pyforce/pyforce/offline/sensors.py              194      9    95%
pyforce/pyforce/offline/weak_greedy.py           80     20    75%
pyforce/pyforce/online/__init__.py                0      0   100%
pyforce/pyforce/online/geim.py                  112     11    90%
pyforce/pyforce/online/indirect_recon.py         80     80     0%
pyforce/pyforce/online/pbdw.py                  204     69    66%
pyforce/pyforce/online/pod_interpolation.py      71     20    72%
pyforce/pyforce/online/pod_projection.py         62     18    71%
pyforce/pyforce/online/tr_geim.py               147     38    74%
pyforce/pyforce/tools/__init__.py                 0      0   100%
pyforce/pyforce/tools/backends.py               140     57    59%
pyforce/pyforce/tools/functions_list.py          76     11    86%
pyforce/pyforce/tools/plotting.py                52     27    48%
pyforce/pyforce/tools/timer.py                   15      2    87%
pyforce/pyforce/tools/write_read.py             251    151    40%
pyforce/setup.py                                  4      4     0%
pyforce/tests/__init__.py                         0      0   100%
-----------------------------------------------------------------
TOTAL                                          1799    548    70%

The most relevant and functionalities have been included.

Great! Thank you!
I consider this issue resolved.


Implement the new STD microfacet distribution function

https://bv.univ-poitiers.fr/access/content/user/mribar03/website/projects/eg_2017/index.html

Isotropic variant implemented in #1303

Rest added in https://github.com/appleseedhq/appleseed/pull/1399


Update imports on paste: really broken when copying entire file

Related to https://github.com/dart-lang/sdk/issues/31238
Dart: 2.0.0-dev.5.0
IntelliJ: IntelliJ IDEA 2017.3 EAP (Ultimate Edition)
Build #IU-173.3302.5, built on October 17, 2017
Start with this code:
import 'dart:html';

import 'package:angular/angular.dart';

import '../src/repo_report.dart';

@Directive(selector: '[usageCell]')
class UsageDirective implements OnInit {
  final ElementRef _el;

  TableCellElement get _element => _el.nativeElement as TableCellElement;
  // ...
}

Paste the entire contents into a new file, at the same spot in the lib hierarchy.
Result:
import 'package:angular/src/core/metadata.dart';

import 'package:angular/src/core/metadata/lifecycle_hooks.dart';

import 'package:angular/src/core/linker/element_ref.dart';

import 'dart:html';

import 'package:repo_manager/src/repo_report.dart';

import 'dart:html';

import 'package:angular/angular.dart';

import '../src/repo_report.dart';

@Directive(selector: '[usageCell]')
class UsageDirective implements OnInit {
  final ElementRef _el;

  TableCellElement get _element => _el.nativeElement as TableCellElement;
  // ...
}

https://dart-review.googlesource.com/c/sdk/+/93483

I believe this is fixed. I can't reproduce when the disableManageImportsOnPaste is false.

Closing for now; re-open if still an issue.


Theme customization

Hi
I would like to change the opacity of the highlighted section 2 from 1. I have tried with the custom themes, but it is not possible to differentiate the 2 zones, can I get some help from you?
thank you
Angelo.

I was able to customize the theme, is it possible to better align these elements?

You cant move elerment with theming

certainly not in the theme :) I wanted to know which file I had to go to modify to change the aspect ratio of the bar


Page contradicts itself about whether the "Source DocLib" field is required

The JSON file section says it is required as with CSV files:

As with a CSV file, the minimum required values are Source, Source DocLib, Target Web, and Target DocLib.

(emphasis mine)
However, the CSV file section says it is optional:

Column content
Description

...
...

Column 2 "Source DocLib"
Optional. Enter the name of the SharePoint Server document library that you're migrating. If you leave this field empty, all document libraries will be migrated. This column needs to be empty when migrating from a local file share.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 27475eb6-82f5-1f75-a304-e5696092a3e1
Version Independent ID: e9bd89b2-a04d-5509-5c76-fc0602cc8515
Content: Format your JSON or CSV file for data content migration - SharePoint - Migrate to Microsoft 365
Content Source: migration/how-to-format-your-csv-file-for-data-content-migration.md
Service: sharepoint-online
Sub-service: sharepoint-migration
GitHub Login: @JoanneHendrickson
Microsoft Alias: jhendr

Thanks for your feedback


Ability to change the password

Hello,
I have been using the app and so far it has been amazing. However it seems currently at least as far as I have looking into the Settings menu that you are unable to change the password required for logging in.
If so it would be a great feature to add. Let me know if I am overlooking something or that this is currently just not available.

One of those things I should've added a long time ago but forgot 😅 thanks for the suggestion

Moving this to the next release

There is now a field on the settings page which will decrypt the current data, switch passwords and then encrypt the data again with the new password.
It should also update the password for all stored API keys which were encrypted with the same password (So all keys that are clickable in the switch keys menu)


css to change background of a select which has option:selected doesn't work on 4.1 version

Here is the fiddle for 4.0.13
https://jsfiddle.net/mArtinko5MB/tkazg3Lc/3/
Here is the fiddle for 4.1
https://jsfiddle.net/mArtinko5MB/6Lw7s09v/4/

This is because Select2 has an accessibility issue in 4.0 where the title attribute was not being set for placeholders. We fixed this in 4.1 with the accessibility overhaul, which means that your hack for detecting when a selection is present no longer works.

This appears to be more of a usage question than a bug report or common feature request.  As we continue to keep the Select2 issue tracker geared towards these two areas, bug reports and common feature requests, we are redirecting usage questions to other communities such as the mailing list, IRC, or Stack Overflow.


Add Event Trigger functionality

I've added some quick functionality into the base project that allows the Android version of the game to trigger String typed events that the Android app listens to and then can act on. This will allow things like:

Interstitial Ad triggers
Review Solicitation
Social Sharing
Etc.

I'm not 100% happy with overloading your JavascriptInterface, but no other really clean way occurred to me.
You could argue this is not core functionality, but I think it's a key piece of taking games to the next level (and I've seen a fair amount of feedback requesting this across different RPG Maker MV forums).
Happy to hear feedback or for you to make any changes required.

I think after we tried the extensions idea I much prefer doing it this way. However, I don't think using the bootstrap boot JS interface is the best thing to do, there could be circumstances where the boot JS interface is not used: https://github.com/AltimitSystems/mv-android-client/blob/b482e8beb348ec85587bca867750c9183d6e409d/app/src/main/java/systems/altimit/rpgmakermv/WebPlayerActivity.java#L71
What I have been leaning towards in my head is the idea of simply having a JS interface called "Android" and bundling extended functionality such as this into that.
A message system is an okay solution, however it does involve the developer diving into Java - and avoiding needing developers to touch the Java is a goal of this project. I also think a simple string message might not be enough, perhaps we should be using Android Intents here and writing a JS wrapper for that.
The 3 example use cases you gave can be done in JavaScript and do not need any special behaviours in MV Android Client to perform (although I admit there are Android SDK features that would make Social Sharing much nicer).
What we should do is start an "Android" JS interface for MV developers to use and carefully integrate features into that. For example; Android Storage is a big one that we had with the extension system and I'd like to bring back at some point.
Also your commit removes the Altimit Community copyright notice in "webview_default_page", try not to make changes to files not related to your feature.
Lastly, I am thinking that tutorials for specific functionality should be separate markdown files that are linked from the ReadMe. Better yet, we could probably use the GitHub Wiki feature to do something more complete.
What are your thoughts?

What I have been leaning towards in my head is the idea of simply having a JS interface called "Android" and bundling extended functionality such as this into that.
That seemed like overkill for the single event solution I proposed, but I agree to separate it if there are multiple functions (especially if there are places where the Bootstrapper isn't called).
A message system is an okay solution, however it does involve the developer diving into Java - and avoiding needing developers to touch the Java is a goal of this project. I also think a simple string message might not be enough, perhaps we should be using Android Intents here and writing a JS wrapper for that.
Agreed for more advanced functionality. I actually started with showAdvertisement(TYPE) and a second function but since I had only three initial use cases, I condensed down to a single string event.
Brainstorming now:

showAdvertisementInterstitial()
solicitReview() (the review solicitation can be done inside the game, this function would send an Intent to open the game page in the Play store)
solicitSocialShare() (same as above, except with a share intent)
...?

The 3 example use cases you gave can be done in JavaScript and do not need any special behaviours in MV Android Client to perform (although I admit there are Android SDK features that would make Social Sharing much nicer).
I think my use case may be different than most--I'm an Android developer with almost no understanding of game design and new to RPG Maker. I'd rather do most of this at the Android layer when it deals with device-native functionality. To keep the game itself as platform agnostic as possible.
For less experienced Android developers who want to implement this functionality, it's a lot easier to copy-paste some Android code (especially if we give a good template and all they need to do is swap in their Admob ID).
What we should do is start an "Android" JS interface for MV developers to use and carefully integrate features into that. For example; Android Storage is a big one that we had with the extension system and I'd like to bring back at some point.
Is there any concern with pollution/conflict with RPG Maker's JS? I didn't take a look at how good they are about wrapping their JS. If we use the "Android" namespace, we should be fine unless they add native functionality in the future.
Also your commit removes the Altimit Community copyright notice in "webview_default_page", try not to make changes to files not related to your feature.
Sorry, I pulled that out when playing around--good catch. I'll be more careful with my commits in the future.
Lastly, I am thinking that tutorials for specific functionality should be separate markdown files that are linked from the ReadMe. Better yet, we could probably use the GitHub Wiki feature to do something more complete.
Sounds good. Most repos have a high-level overview of functionality and then individual links to the specifics, that's probably a good approach if we expect more than a couple.
What are your thoughts?
I agree with all your points above--do you want to own creating the base Android JS interface and I can help flesh it out with individual functionality/examples?

For now I don't have the time budget to work on MV Android Client, so if you don't mind receiving and iterating on feedback then you're welcome to implement the changes discussed here and I can review them and provide direction where necessary.
The plan for now should be implementing an Android JS interface as a separate class file, so Java developers can directly extend it as desired, and probably starting off with replacing the message system with an intent system - which would at some point involve a way to convert JS object parameters to Bundles for Intent putExtras (JS -> JSON -> Bundle). Java developers can then use Android Intents as normal, which could facilitate in avoiding the need to hard-modify existing code.


Write a better user guide for mint

It could include e.g.:

FAQs
Common issues and troubleshooting steps
Known issues and workarounds

I suggest that first, a new release is made. There are so many nice features on latest main, that if proper docs are made (which I do agree with), new release must be made alongside.


fix: typo

module does not have the option node12, which I think is a typo.

@Amorites please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

> > Options:
> - (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
>```
>@microsoft-github-policy-service agree
>```
> - (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
>```
>@microsoft-github-policy-service agree company="Microsoft"
>```

> <details>
    <summary>Contributor License Agreement</summary>

### Contribution License Agreement
This Contribution License Agreement (**“Agreement”**) is agreed to by the party signing below (**“You”**),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.
1. **Definitions**.
**“Code”** means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to Microsoft under this Agreement.
**“Project”** means any of the projects owned or managed by Microsoft and offered under a license
approved by the Open Source Initiative (www.opensource.org).
**“Submit”** is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
**“Submission”** means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.
2. **Your Submission**. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.
3. **Originality of Work**. You represent that each of Your Submissions is entirely Your original work.
Should You wish to Submit materials that are not Your original work, You may Submit them separately
to the Project if You (a) retain all copyright and license information that was in the materials as You
received them, (b) in the description accompanying Your Submission, include the phrase “Submission
containing materials of a third party:” followed by the names of the third party and any licenses or other
restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
guidelines concerning Submissions.
4. **Your Employer**. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.
5. **Licenses**.
  * **Copyright License**. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
parties.
  * **Patent License**. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.
  * **Other Rights Reserved**. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.
6. **Representations and Warranties**. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
7. **Notice to Microsoft**. You agree to notify Microsoft in writing of any facts or circumstances of which
You later become aware that would make Your representations in this Agreement inaccurate in any
respect.
8. **Information about Submissions**. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.
9. **Governing Law/Jurisdiction**. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.
10. **Entire Agreement/Assignment**. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

> </details>
<!-- Policy app identification https://img.shields.io/static/v1?label=ContributorLicenseAgreement. -->

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree


[Android] Interference with resources?

I had the gem installed and working, but I noticed my layout files located in 'resources/layout/activity_item.xml' were not available when trying to reference them with R::Layout::Activity_item

Exception raised: NameError: uninitialized constant Activity_item' 09-30 15:37:00.580  3526  3526 E com/xx/eventer: 	from item_activity.rb:5 in onCreate'

attempting to retreive the id:
resources.getIdentifier('activity_item', 'layout', packageName)
returns 0
Removing the gem and full clean and rebuild solved that problem

I just needed to specify the resources path with app.resources_dirs in the rakefile.


Status page

opening #430 against master instead of hs_staging

a few extra things:

remove the links from the Racks and Slaves headers, since all the links below go to the same page
add anchors to the different rack and slave types (i.e. #active #decomissioning, etc) and update the status page links to point to the right thing
have the overdue number link to the scheduled task page

cool, that's all set.

Fix for numbers in the column on update: https://github.com/HubSpot/Singularity/pull/720


Logging large values to rerun.set_time_seconds() causes hang/crash

Describe the bug

Using the Python SDK, logging a time before logging an entity causes the GUI to hang then crash. The process itself never exits.
I am logging various sensor data to the same stream  via rerun.log_points(), rerun.log_image(), etc.
For each call, I first set the time of that recorded sensor data.

Using a "frame ID" works fine e.g. rr.set_time_sequence("frame_id", step).
I tried logging my dataset's timestamps as nanoseconds: rr.set_time_nanos("timestamp", timestamp). This wasn't correct for my case.
I instead logged timestamps as seconds: rr.set_time_nanos("timestamp", timestamp). This causes the hang/crash.

[sidenote: turned out my dataset uses a custom time reference: nanoseconds since something domain specific]
To Reproduce
Reproduced on the clock example: examples/python/clock/main.py. Apply the diff below, where we scale up the step by 1e9 e.g. nanoseconds:
@ examples/python/clock/main.py:46 @ def log_clock(steps: int) -> None:
    for step in range(steps):
        t_secs = step

-        rr.set_time_seconds("sim_time", t_secs)
+        rr.set_time_seconds("seconds", t_secs * 1e9)        # causes the app to hang
+        # rr.set_time_nanos("nano seconds", t_secs * 1e9)   # this works fine

The full process:

pip install -U rerun-sdk  # get 0.7.0 at time of writing
git clone git@github.com:rerun-io/rerun.git  # Clone the repository
cd rerun/
git checkout 0.7.0
# code -n examples/python/clock/main.py  # open file to apply the diff above
python examples/python/clock/main.py  # opens the GUI

Interestingly, the logging itself takes a really high, suggesting some type checks/conversions are slowing things down?

In the GUI, change the logging time to choose seconds, which causes the app to hang

Wait ~7 minutes, the GUI app does crash and close... but the process does not. You can still find python -m rerun --port 9876 in htop still chugging along doing something (for me CPU% floats around ~25%). Watching htop as I switch to seconds in the GUI to enter failure mode, I notice that memory spikes to fill my memory, then seems to clear itself and again spike, then clear itself and become stable.

Playing with datatypes on the Python side had no effect. E.g rr.set_time_seconds("seconds", float(t_secs * 1e9)), ends with the same result. I haven't starting poking around into the bindings/rust code.
Expected behavior

An error, or perhaps a sane conversion? The docs already speak of some assumptions on timestamps based on their magnitude.
Backtrace

No backtrace is given.
Desktop (please complete the following information):

OS: MacOS Ventura 13.4.1

Rerun version

rerun_py 0.7.0 [rustc 1.69.0 (84c898d65 2023-04-16), LLVM 15.0.7] aarch64-apple-darwin prepare-0.7 9cf3033, built 2023-06-16T15:39:37Z

Whoa, thanks for the report and the reproduce!
I can reproduce on main, and in debug builds we get a panic:
thread 'ThreadId(1)' panicked at 'attempt to add with overflow', re_time_panel/src/paint_ticks.rs:213

   8: core::panicking::panic_fmt
             at core/src/panicking.rs:64:14
   9: core::panicking::panic
             at core/src/panicking.rs:114:5
  10: re_time_panel::paint_ticks::paint_ticks
             at re_time_panel/src/paint_ticks.rs:213:9
  11: re_time_panel::paint_ticks::paint_time_range_ticks
      re_time_panel::paint_ticks::paint_time_ranges_and_ticks
             at re_time_panel/src/paint_ticks.rs:49:21
  12: re_time_panel::TimePanel::expanded_ui
             at re_time_panel/src/lib.rs:263:9

I'll take a look right away


Measures not displaying correctly from email alert

We've had an email from a user:

Hi
Just some feedback re your excellent monthly updates.
Best-case possible savings
We compared this practice's spending with the best-performing 10% on all the areas we track. If it prescribed as well as those practices, it could save around £10,000. Here's a list of measures, sorted by potential cost savings.
I might be wrong, but am wondering if the list of measures, sorted by potential cost savings is correct?  When clicking on it, it seems to show measures that the practice is good on?  Have found the same on the monthly updates for other practices
Thanks

On checking, this does seem the case, and it's only showing 5 measures.  If you change the practice in the URL, the same 5 measures show up (https://openprescribing.net/practice/L83106/measures/?utm_medium=email&utm_campaign=monthly+alert+2024-11-27&utm_source=dashboard-alerts&utm_content=%2Femail%2Fmonthly+alert+2024-11-27%2Fdashboard-alerts%2F11245&sortBySavings=1).
If you click on "potential for improvement", it corrects itself.

EDIT: it turns out it's not just from the email alert - it's happening even without, until you ctrl-F5

Just to confirm @richiecroker, for that specific practice is this what the link should be:
https://openprescribing.net/practice/K83043/measures/?tags=cost&sortBySavings=1
i.e. linking specifically the measures tagged "cost saving"?

@evansd it's basically mimicking this;

And that doesn't seem to work properly

Interesting. I can't replicate that behaviour.
For instance, when I open this link:
https://openprescribing.net/practice/K83043/measures/?tags=core&sortBySavings=1
I get the same measures in the same order as if I open this link and then click the "Potential savings" button:
https://openprescribing.net/practice/K83043/measures/?tags=core
That also doesn't quite tie in with what the original email was saying:

When clicking on it, it seems to show measures that the practice is good on?

Which sounds more like the wrong measures being shown, rather than the right measures in the wrong order.
It's quite possible there are two bugs here. But linking to the right set of measures seems like the most important one to fix.

I'm reopening this because it's not yet clear whether there's more than one bug here and although I'm confident the linked PR is an improvement there may be more work we need to do.

@evansd i'm just looking at this, and still getting the same issue.  I have tried in both Edge and Chrome.
In summary:
If I click on https://openprescribing.net/practice/K83043/measures/?tags=core&sortBySavings=1
I get the same 4 measures:

If I click on "Potential for improvement" it corrects itself:

If I click on "Potential savings" it returns to the 4
And the 4 always seem to be:
Toothpaste
Glutenfree
Erectile Dysfunction
Bile Acid Sequestrants

I've just tried at regional level, and get the same thing (with the addition of probiotics)

I think this is basically working as intended Rich. Of all the measures on that page (which are just the "core" measures), those four are the only ones with a cost-saving value.
If you look at the measures tagged as cost saving you get a more sensible list:
https://openprescribing.net/practice/K83043/measures/?tags=cost&sortBySavings=1
I've updated the link in the email to point to the cost saving measures, which is presumably what it should have done all along.
There is one bit of behaviour though which is arguably a bug, or arguably not, depending on the intentions of whoever built this. Switching to "Potential savings" filters out any measures without savings, but it keeps measures with negative cost savings (i.e. where the practice is doing better than the median). It would be easy to filter those out to and then the page would display a warning like this:

I think that's probably less confusing overall, although it does mean that you can't sort measures to show how well you're saving money.


feat(poetry): bump poetry version to v1.5.1

This PR bumps poetry version to 1.5.1 which is last version that supports Python 3.7 as well as updates poetry-plugin-export to v1.4.0.
We are going to release it as a v2.0.0 of this action so we don't break any existing users of this action.

:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Tests for Future API

We need tests for the Future API

I believe we are talking about the deleted Future api


Klmanga　Source request

Source name
Klmanga
Source link
https://klmanga.si
Source language
japanese
Other details
No response
Acknowledgements

[X] I have checked that the extension does not already exist by searching the extension listing and verified it does not appear there.
[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a meaningful title with the source name.
[ ] I have admitted that I am a clown by having checked this box, as I have not read these acknowledgements.
[X] I will fill out all of the requested information in this form.

New URL: https://klmanga.is/


701 - clang-tidy improvement for CMakeResourceDependencies.cpp

CMakeResourceDependencies is often built by CMake in the context of users of CppMicroServices - if you've configured clang-tidy to run in the user project, it complains about the "old-style" constructor and requests a modernized = default.
Signed-off-by: Ingmar Sittl<EMAIL_ADDRESS>I've tested that this produces the exact same output as the previous code on different gcc and clang versions.
I can also create a PR to bring this small improvement to development, if you want.

It looks like this change causes build failures on macOS:
/Users/runner/work/CppMicroServices/CppMicroServices/cmake/CMakeResourceDependencies.cpp:29:33: error: defaulted function definitions are a C++11 extension [-Werror,-Wc++11-extensions]
  CMakeResourceDependencies() = default;
                                ^
1 error generated.

This error is surprising, I thought we were compiling using c++11? It would appear that CMakeResourceDependencies.cpp isn't being compiled with c++11 or greater.

It looks like this change causes build failures on macOS:
/Users/runner/work/CppMicroServices/CppMicroServices/cmake/CMakeResourceDependencies.cpp:29:33: error: defaulted function definitions are a C++11 extension [-Werror,-Wc++11-extensions]
  CMakeResourceDependencies() = default;
                                ^
1 error generated.

This error is surprising, I thought we were compiling using c++11? It would appear that CMakeResourceDependencies.cpp isn't being compiled with c++11 or greater.

This piece of code in cmake\usFunctionEmbedResources.cmake is what is compiling CMakeResourceDependencies.cpp (only on macOS):
add_custom_command(
        OUTPUT ${_source_output}
        COMMAND ${CMAKE_CXX_COMPILER} ${_us_resource_cxx_flags} -c ${US_CMAKE_RESOURCE_DEPENDENCIES_CPP} -o stub.o
        COMMAND ${CMAKE_LINKER} -r -sectcreate __TEXT us_resources ${_zip_archive_name} stub.o -o ${_source_output}
        DEPENDS ${_zip_archive}
        WORKING_DIRECTORY ${_zip_archive_path}
        COMMENT "Linking resources zip file ${_zip_archive} for ${US_RESOURCE_TARGET}"
        VERBATIM
       )

I haven't checked the compiler flags however I assume they don't contain std=c++11

confirmed, the compiler command doesn't have any C++ language version set, i.e. --std=cXXXX is not present on the command line. so the default is c++98

I haven't checked the compiler flags however I assume they don't contain std=c++11

confirmed, the compiler command doesn't have any C++ language version set, i.e. --std=cXXXX is not present on the command line. so the default is c++98

a simple solution could be to prepend --std=c++14 (or on development to c++17) to _us_resource_cxx_flags here - that also allows users to override the --std setting themselves in their CMAKE_CXX_FLAGS to a later standard without problems

I can also create a PR to bring this small improvement to development, if you want.

@jeffdiclemente: should I also create a corresponding PR for development?

I can also create a PR to bring this small improvement to development, if you want.

@jeffdiclemente: should I also create a corresponding PR for development?

@insi-eb sure, that sounds good to me. thanks!


Update wikibase-manifest-schema-v2.json

Remove comma so that the JSON is valid.
@wetneb: this seams required…

@wetneb: what do you think?
Regards, Antoine


HeiseBridge Images are gigantic and taking forever to load

Is your feature request related to a problem? Please describe.
If I read heise, the image load takes forever and I now know why. The Images are gigantic! Sometimes up to 21Mb!

This is clearly a feature, as you can see in line 64, but I think nobody wants to load a 21Mb picture, especially not for just an newsarticle and then also all of them.
Describe the solution you'd like
There are way smaller versions of the pictures which should loaded instead.
e.g. this is the article:
https://www.heise.de/news/Studie-Europa-und-Deutschland-liegen-bei-Wasserstoffpatenten-vorn-7454652.html
this is the small pic loaded in the article:
https://heise.cloudimg.io/v7/_www-heise-de_/imgs/18/3/6/7/7/0/9/6/shutterstock_2133921961-c5307b04341c5ce8.jpeg?force_format=avif%2Cwebp%2Cjpeg&org_if_sml=1&q=85&width=642
this is the pic HeiseBridge loads (the loading is kinda nostalgic ;)):
https://www.heise.de/imgs/18/3/6/7/7/0/9/6/shutterstock_2133921961-c5307b04341c5ce8.jpeg
In my opinion, the smaller ones are big enough.
heise also seems to think so, as they are the default.
Describe alternatives you've considered
An option to select if you want the small or big pictures.

Fixed by https://github.com/RSS-Bridge/rss-bridge/pull/3214


Content issues in 'Kerberos OAuth2 Grant'

Description:
Need to update the 3rd step in https://apim.docs.wso2.com/en/latest/learn/api-security/oauth2/grant-types/kerberos-oauth2-grant/#configuring-kerberos-grant-with-api-manager as below.

Replace the 1st line attachment to 'org.wso2.carbon.identity.application.authenticator.iwa-5.3.13.jar' which can be found in https://drive.google.com/file/d/1ICQhdTNvCasnHLW6HEG9sANS8WBIZJbx/view
Remove the 2nd line which is 'org.wso2.carbon.identity.idp.metadata.saml2_1.0.1.jar'.

Suggestions,
It's better if we can include the sample client information as in the identity server documentation https://is.docs.wso2.com/en/latest/learn/kerberos-grant/#configuring-kerberos-grant-with-the-identity-server in step 6.
Affected Product Version:
3.0.0

Fixed in https://github.com/wso2/docs-apim/pull/821


Organized README

Play-with-docker reference is added and organized the references.

#2

Read about incorporating suggested changes at https://help.github.com/articles/incorporating-feedback-in-your-pull-request/

@ibnesayeed applied the suggestions. Please review and merge the PR.

LGTM! Thanks @avinashdesireddy for the PR.


Hide create new button for single files.

- Summary
Hides the "Publish and Create New" button for single-file collections. Uses the code from the "Quick Add" button.
Fix #1183.

- Test plan
Manually tested with both simple and editorial workflows.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@erquhart Do we need to be checking for this somewhere farther down than the UI, so that even if a "create new" button was left, it wouldn't work?

Deploy preview for netlify-cms-www ready!
Built with commit 7f516f78ef49ed55878db9922c47ea07561b8b23
https://deploy-preview-1200--netlify-cms-www.netlify.com

Deploy preview for cms-demo ready!
Built with commit 7f516f78ef49ed55878db9922c47ea07561b8b23
https://deploy-preview-1200--cms-demo.netlify.com

@tech4him1 I agree it should be more centralized, but this is fine for now.


Create an action menu button component

Create an action menu button. This button shows a dropdown with a list of links on click and offers various ways to browse that list.

Requirement
URL

Accessibility
https://www.w3.org/WAI/ARIA/apg/patterns/menu-button/examples/menu-button-actions-active-descendant/

Design
https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components?node-id=134%3A1328&t=Aq1KrFMZrhO2HRgt-1 (needs revision)

Existing implementation
Internet Header Language Switch on Desktop  https://next.design-system.post.ch/?path=/story/components-internet-header-header--default (does not fulfill accessibility requirements)

Proposed API
<post-menu-button items="Array<{ url: string, text: string, target: string }>">
  Button text
</post-menu-button>

In order to provide flexibility to the list item template, there are (at least) two options:
Option 1: Custom template for list items
This approach uses a input attribute accepting an array of items. The control over the list markup is with the component and accessibility can be guaranteed. Still, there is a possibility to customize the list item template in a general way. A possible implementation could look like this: https://lit.dev/playground/#gist=78bf6997e7ecf38d8d981f66d7e3f472.
Custom list item template implementation
A slot might not be best suited for this use case, therefore an external reference could make more sense.
<post-menu-button items="Array<string>" list-item-template="custom-menu-button-list-item-template">
  Button text
</post-menu-button>

<template id="custom-menu-button-list-item-template">
  <post-icon name="1001" />
  <slot></slot>
</template>

++ Simple implementation
++ Items are passed via JS API in most cases anyway
++ Full control over list items from within web component
-- Limited possibility to define custom template, just one template for all items. A language selector dropdown with custom flag icons for every language would not be possible (easily)
-- Needs JS to render items
Option 2: User defined list of items
Another approach for supporting custom templates could be to take a list of links as slotted content instead of an array of items as property.
Test implementation (WIP): https://lit.dev/playground/#gist=212821f67bab636ff2d53552251373e7
<post-menu-button>
  Button text
  Apples
  Pears
  Oranges
  Strawberries
</post-menu-button>

++ Items are defined with standard markup and fully customizable, a language selection with custom flag icons would easily be possible
++ Items are available before JS loads (when not rendered client side)
-- Limited control over slotted items from within web component, their state could change any moment
-- Implementation has to listen to slot changes in order to register correct event handlers
Option 3
There is also the possibility to split up the component into smaller parts in order to give more flexibility as to the contents of each element.

A container for the relative anchor
A button to keep control of user input
A link list that serves as dropdown

<post-menu-button>
  <post-button variant="primary">Button text</post-button>
  <post-menu-button-list>

Optional header content

    Link 1
    Link 2

Optional category heading

    Link 3

Optional footer content

  </post-menu-button-list>
</post-menu-button>

++ Maximum content flexibility
-- More complicated interaction between components from component perspective (quagmire of slots)
-- More markup required
-- Implementation has to listen to slot changes in order to register correct event handlers
Edge cases

The dropdown list should never be hidden by page boundaries. If the action menu button is placed directly at the edge of the screen, the dropdown list should adapt its alignment. Default alignment is bottom left.
There might be content before or after the link list
There might be cateogries of links or grouped link lists

Examples of possible use cases
Language switch

Login widget

https://headlessui.com/react/listbox


nixos-tests uefiUsb and uefiCdrom broken on master

Issue description
Bisect suggest that #57559 is the cause, so I guess something is probably up with the setup of the EFI specifics. cc @Ekleog
https://hydra.nixos.org/build/91515608
https://hydra.nixos.org/build/91515885
log:
running the VM test script
machine: starting vm
machine: QEMU running (pid 593)
machine: waiting for unit ‘multi-user.target’
machine: running command: systemctl --no-pager show "multi-user.target"
machine: waiting for the VM to finish booting
machine# qemu-system-x86_64: warning: hub 0 is not connected to host network
machine# .PXE-E18: Server response timeout.
machine# UEFI Interactive Shell v2.2
machine# EDK II
machine# UEFI v2.60 (EDK II, 0x00010000)
machine# Mapping table
machine#       FS0: Alias(s):CD1c1:;BLK4:
machine#           PciRoot(0x0)/Pci(0x1,0x1)/Ata(0x0)/CDROM(0x1)
machine#      BLK2: Alias(s):
machine#           PciRoot(0x0)/Pci(0x1,0x1)/Ata(0x0)
machine#      BLK3: Alias(s):
machine#           PciRoot(0x0)/Pci(0x1,0x1)/Ata(0x0)/CDROM(0x0)
machine#      BLK0: Alias(s):
machine#           PciRoot(0x0)/Pci(0x1,0x0)/Floppy(0x0)
machine#      BLK1: Alias(s):
machine#           PciRoot(0x0)/Pci(0x1,0x0)/Floppy(0x1)
machine#      BLK5: Alias(s):
machine#           PciRoot(0x0)/Pci(0x1,0x1)/Ata(0x0)/HD(2,MBR,0xC8E0E6EE,0x2244,0xA800)
machine# Press ESC in 5 seconds to skip startup.nsh or any other key to continue.Press ESC in 4 seconds to skip startup.nsh or any other key to continue.Press ESC in 3 seconds to skip startup.nsh or any other key to continue.Press ESC in 2 seconds to skip startup.nsh or any other key to continue.Press ESC in 1 seconds to skip startup.nsh or any other key to continue.
(600.00 seconds)
building of '/nix/store/91a4db50p5rsjyd2na68p5qkd70sibin-vm-test-run-boot-uefi-cdrom' timed out after 7200 seconds of silence

Steps to reproduce
❯ nix-build nixos/release.nix -A tests.boot.uefiUsb

@srhb This does look like something that could be due to #57559 indeed. I've just pushed a revert of it, and will attempt to fix it sometime later, thank you for the notice! :)


Add table with additional cursors

These IDs are also available and used in WPF: https://learn.microsoft.com/dotnet/api/system.windows.input.cursortype
https://github.com/dotnet/wpf/blob/main/src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Input/Cursor.cs#L373-L385
OCR_RDR* cursors are internally used in Win32 in "reader mode" that is activated with EnterReaderModeHelper.

@Karl-Bridge-Microsoft can you please take a look?


microk8s restarted without supervision

When you make a new release, you turn off and on microk8s on my production servers, sometimes breaking it, that seems pretty ridiculous.
Obviously I would like you to keep updating this code, but until this bug is fixed it seems like a pretty risky endeavor.

@termie
@lazzarello creates a PR for the documentation. It contains a way how to pin the exact version of micro8s.

bump, I've been pinning the version for > 1 year now and it's working great. any way that information can get added to the user documentation?


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-2.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 2329

Questions ?
Please refer to the Backport tool documentation


Modify report.test.ts to be able to generate the zip file from some xml

[ ] The xml should NOT come from a file, instead it should be generated. Keep it fairly simple but See the xbrl example here
[ ] There should be a utility method that takes the generated xml, creates the file, then creates a report.json, and zips them together.
[ ] There should be a test-case-zip where the xml content is static, for a predictable digest.
[ ] There should be a test-case-zip where the xml content has some randomness in order to generate a different digest each time, probably just adding a millisecond timestamp will be sufficient.

Moving to reg-pilot beta


Init logging mechanism

In this PR, we init the Logger class to log to the Manim Notebook output pane in VSCode as well as to a dedicated log file. For users to access this log file, we add a Manim Notebook: Open log file command. I've also included a section in the Readme explaining how to report an issue using this log file.
As I had to search way too long to find the relevant information on how to log in a VSCode extension, I've also written a StackOverflow answer.
A subsequent PR will then add respective Logger.trace() etc. statements at important places in the code.

Thanks @VladimirFokow, that's a good idea, otherwise users might complain about performance. I've also updated the Regex to match another case, see the docstrings.

yes


Tools and tool_choice not available correctly to older models

Heya, I was just updating my implementation to the new tools and tool_choice options, but I get the following response when using gpt-4-0613 or gpt-3.5-turbo-0613:
{
  "error": {
    "message": "Unrecognized request arguments supplied: tool_choice, tools",
    "type": "invalid_request_error",
    "param": null,
    "code": null
  }
}

While the docs state that the old functions and function_call have been deprecated:
https://github.com/MicrosoftDocs/azure-docs/blob/24d4fcdfc00d4fc4425ce9f75d53fc577d0dc7da/articles/ai-services/openai/reference.md?plain=1#L269
It doesn't sound correct to have developers maintain two versions of the API. What is the proposed solution? It seems like a fix Microsoft needs to implement?
See also: https://github.com/openai/openai-python/issues/926
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: fadd6778-b11c-d9af-1bd9-e3ed394e0fcb
Version Independent ID: 45436c53-4aae-284b-a6c5-3f47c9342537
Content: Azure OpenAI Service REST API reference - Azure OpenAI
Content Source: articles/ai-services/openai/reference.md
Service: azure-ai-openai
GitHub Login: @mrbullwinkle
Microsoft Alias: mbullwin

@Afstkla
Thanks for your feedback! We will investigate and update as appropriate.

@Afstkla
I understand your concern. The error message you received indicates that the tool_choice and tools parameters are not recognized by the API. This is because these parameters were introduced in the 2023-12-01-preview version of the API, which is not yet generally available.
The documentation you referenced is correct in stating that the functions and function_call parameters have been deprecated in favor of tools and tool_choice. However, it seems that the API has not yet been updated to support these new parameters.
I recommend reaching out to Microsoft support for further assistance with this issue. They may be able to provide more information on when the API will be updated to support the tools and tool_choice parameters, or offer a workaround in the meantime.

@Afstkla
We are going to close this thread.if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.


Yourls are not shortening my url

Hi, i've installed recently yourls un my domain, all the installation process were fine but now when i want to short a url, the result doesn't work. Even if using the default way that creates the link randomly or using a the manual way to create it. The long url works fine, but the short url is trying to open the short url, it's not redirecting to the long url.
Long url: https://domain.es/servicios/?utm_medium=post&utm_source=linkedin
Short url: https://dom.es/servicios
And this short url shows a not found error.
Thanks in advance

https://github.com/YOURLS/YOURLS/wiki/Troubleshooting-first-steps


merging as tom

Type of reader (if reader related)
None
Description of the new feature / enhancement
Merging chapters as toms.
In setting: "Merg chapters into toms".
It would recognize name of chapters and it there is "vol 1" and so on, it would merge into one when reading, so in other words it would just make reading easier.
Because there would be less clicking.
Not like merging into 1 file, but more like reading without need of clickin to next file(chapter) only before new tom.

Scenario when this would be used?
No response
Supporting information
No response

Like what @omodia said, its not very practical. And if you try to make them join using predefined name then again you will have to rename everything.
There are many tools available for this task, and in my opinion using them will be better.
I have plans for continuous reader that automatically add next/previous chapters without loading. That will kind of resolve your problem.

Like what @omodia said, its not very practical. And if you try to make them join using predefined name then again you will have to rename everything. There are many tools available for this task, and in my opinion using them will be better.
I have plans for continuous reader that automatically add next/previous chapters without loading. That will kind of resolve your problem.

Thx this is what I was hoping for.


fix(session): add cookie_persistent to ensure is lifetime is applied

Summary
At present, the schema configuration cookie_lifetime on the session plugin does nothing. As per the docs on lua-resty-session

session.cookie.lifetime holds the cookie lifetime in seconds in the future. By default this is set to 3,600 seconds. This can be configured with Nginx set $session_cookie_lifetime 3600;. This does not set cookie's expiration time on session only (by default) cookies, but it is used if the cookies are configured persistent with session.cookie.persistent == true. See also notes about ssl_session_timeout.

I.e. to ensure this value is used, cookie.persistent must also be set to true. Currently this is not possible with the session plugin.
Full changelog

Add schema option cookie_persistent to session plugin
Add test to assert that Expires and Max-Age are set on session cookie using cookie_lifetime when cookie_persistent = true

Issue reference

No issue has been raised.

Summary
At present, the schema configuration cookie_lifetime on the session plugin does nothing. As per the docs on lua-resty-session

session.cookie.lifetime holds the cookie lifetime in seconds in the future. By default this is set to 3,600 seconds. This can be configured with Nginx set $session_cookie_lifetime 3600;. This does not set cookie's expiration time on session only (by default) cookies, but it is used if the cookies are configured persistent with session.cookie.persistent == true. See also notes about ssl_session_timeout.

I.e. to ensure this value is used, cookie.persistent must also be set to true. Currently this is not possible with the session plugin.
Full changelog

Add schema option cookie_persistent to session plugin
Add test to assert that Expires and Max-Age are set on session cookie using cookie_lifetime when cookie_persistent = true

@bungle Thanks for the feedback. As expected you are correct - it seems that I have misread the underlying code. I'll go ahead and close this PR now. I do however have a use-case for a persistent cookie and so, I am wondering if you are open to me (re)opening this as a separate(?) feat PR to add/enable this configuration option?
For reference:

cookie.lifetime is used to calculate session.expiry on save here.
expiry is encoded into the cookie value here


Allow use of slot for imageComponent

I wanted to use this package with PhotoSwipe, similar to https://fergaldoyle.github.io/image-masonry/svelte-advanced.html
I was able to get most of what I needed by using the imageComponent prop except for the on:click handler.
This PR makes it possible to use a slot instead. It's not a breaking change because the current <svelte:component ... is set as the default slot contents.

Nice, thanks! This is honestly how it should have been done in the first place, idk why I made it a prop 🙃


RangeError when reducer returns React element

Node version: 6.10.3
npm version: 3.10.10
Operating system: Windows 10 version 1703
Command line used: N/A
Steps to reproduce:
If a reducer (any reducer) returns a state with a React element in it e.g.
return {
  myState:
Hello World

}

Then the following error is produced:
RangeError: Maximum call stack size exceeded

trackProperties
trackProperties
trackProperties
trackProperties
trackProperties
...

This only happens when an HTTP request is made to some Route which would end up dispatching to such reducer.
When navigating from a route that doesn't have a reducer returning an React element inside the state, then the error is not produced and all seems to work fine.
Example:

An HTTP request to route / is made.
User navigate from / to /reducer
/reducer dispatches an action
Some reducer returns a React element in the state e.g.
Hello World

No error shows up
User refreshes the /reducer page to force an HTTP request
The error shows up
Change the reducer so that it does not return a React element.
Refresh the page and the error is gone (this proves that the React element causes the error).

The Redux store is for storing plain data, not React elements. I've never seen anyone store a React element in the store, nor have I tried. That said, this isn't a Slingshot bug. I'd suggest posting on the Redux repo for guidance on whether the Redux store supports this use case.


interactive data mapplots work well with Gradio?

will the interactive data mapplots work well with Gradio?

I'm not familiar enough with gradio to say. It does output html, which you can access by calling str on the plot output object. If you can dump the HTML into an iframe it should just work (this is how it works from within a notebook).


Several TODO tasks

@VoVAllen

Add CI to the project. Just use travis should be fine.
Lint check from dmlc-core. You could follow the setup in dgl.
More tests.

We should test the case when A->B and then A goes out-of-scope.
Different devices (CPU, GPU tests)

Look like FromDLPack does not support data types other than float.

Also, what's the problem of inheriting TF's allocator?

Missing license file. Does TF use Apache 2.0?

Yes. I added the apache license to our repo.


LocalizationManager.gd broken when exported.

Everything works perfectly in the editor, but upon exporting (debug, to android with one-click-deploy) it doesn't work.
Logs
This is what logcat (ran withadb logcat godot:* *:S) had to say
At startup

11-18 16:14:04.457  8069  8124 E godot   : **SCRIPT ERROR**: Parse Error: The identifier "EditorPlugin" isn't a valid type (not a script or class), or couldn't be found on base "self".
11-18 16:14:04.457  8069  8124 E godot   :    At: res://addons/localization_editor/model/LocalizationData.gd:34:GDScript::reload() - Parse Error: The identifier "EditorPlugin" isn't a valid type (not a script or class), or couldn't be found on base "self".
11-18 16:14:04.457  8069  8124 E godot   : **ERROR**: Method failed. Returning: ERR_PARSE_ERROR
11-18 16:14:04.457  8069  8124 E godot   :    At: modules/gdscript/gdscript.cpp:585:reload() - Method failed. Returning: ERR_PARSE_ERROR
11-18 16:14:04.470  8069  8124 E godot   : **SCRIPT ERROR**: Parse Error: The identifier "EditorPlugin" isn't a valid type (not a script or class), or couldn't be found on base "self".
11-18 16:14:04.470  8069  8124 E godot   :    At: res://addons/localization_editor/model/LocalizationData.gd:34:GDScript::reload() - Parse Error: The identifier "EditorPlugin" isn't a valid type (not a script or class), or couldn't be found on base "self".
11-18 16:14:04.470  8069  8124 E godot   : **ERROR**: Method failed. Returning: ERR_PARSE_ERROR
11-18 16:14:04.470  8069  8124 E godot   :    At: modules/gdscript/gdscript.cpp:585:reload() - Method failed. Returning: ERR_PARSE_ERROR
11-18 16:14:04.482  8069  8124 E godot   : **SCRIPT ERROR**: Parse Error: The identifier "EditorPlugin" isn't a valid type (not a script or class), or couldn't be found on base "self".
11-18 16:14:04.482  8069  8124 E godot   :    At: res://addons/localization_editor/model/LocalizationData.gd:34:GDScript::reload() - Parse Error: The identifier "EditorPlugin" isn't a valid type (not a script or class), or couldn't be found on base "self".
11-18 16:14:04.482  8069  8124 E godot   : **ERROR**: Method failed. Returning: ERR_PARSE_ERROR
11-18 16:14:04.482  8069  8124 E godot   :    At: modules/gdscript/gdscript.cpp:585:reload() - Method failed. Returning: ERR_PARSE_ERROR
11-18 16:14:04.483  8069  8124 E godot   : **SCRIPT ERROR**: Parse Error: The class "LocalizationData" couldn't be fully loaded (script error or cyclic dependency).
11-18 16:14:04.483  8069  8124 E godot   :    At: res://addons/localization_editor/LocalizationManager.gd:90:GDScript::reload() - Parse Error: The class "LocalizationData" couldn't be fully loaded (script error or cyclic dependency).
11-18 16:14:04.483  8069  8124 E godot   : **ERROR**: Method failed. Returning: ERR_PARSE_ERROR
11-18 16:14:04.483  8069  8124 E godot   :    At: modules/gdscript/gdscript.cpp:585:reload() - Method failed. Returning: ERR_PARSE_ERROR
11-18 16:14:04.483  8069  8124 E godot   : **ERROR**: Script does not inherit a Node: res://addons/localization_editor/LocalizationManager.gd
11-18 16:14:04.483  8069  8124 E godot   :    At: main/main.cpp:1783:start() - Condition "!valid_type" is true. Continuing.

At set_placeholder

11-18 16:14:10.753  8069  8124 E godot   : **ERROR**: (Node not found: "LocalizationManager" (relative to "/root").)
11-18 16:14:10.753  8069  8124 E godot   :    At: scene/main/node.cpp:1372:get_node() - Condition "!node" is true. Returned: __null
11-18 16:14:10.753  8069  8124 E godot   : **SCRIPT ERROR**: Attempt to call function 'set_placeholder' in base 'null instance' on a null instance.
11-18 16:14:10.753  8069  8124 E godot   :    At: res://Scripts/Utils.gd:154:ldone_popup() - Attempt to call function 'set_placeholder' in base 'null instance' on a null instance.

Result of get_tree().root.print_tree_pretty()

Notice the absence of LocalizationManager

11-18 16:14:10.752  8069  8124 I godot   :  ┖╴root
11-18 16:14:10.752  8069  8124 I godot   :     ┠╴Utils
11-18 16:14:10.752  8069  8124 I godot   :     ┖╴Main scene
11-18 16:14:10.752  8069  8124 I godot   :        ┠╴BackgroundUI
11-18 16:14:10.752  8069  8124 I godot   :        ┃  ┠╴BG
11-18 16:14:10.752  8069  8124 I godot   :        ┃  ┖╴Panel
11-18 16:14:10.752  8069  8124 I godot   :        ┠╴Selected
11-18 16:14:10.752  8069  8124 I godot   :        ┠╴SelectionSprite
-------------------------------- snip --------------------------------

Result of get_tree().root.print_tree_pretty() when ran inside the editor

Notice LocalizationManager being present this time

 ┖╴root
    ┠╴LocalizationManager
    ┠╴Utils
    ┖╴Main scene
       ┠╴BackgroundUI
       ┃  ┠╴BG
       ┃  ┖╴Panel
       ┠╴Selected
       ┠╴SelectionSprite
------------- snip -------------

The Code
var localization_manager

# --- snip ---

func ensure_localization_manager():
	get_tree().root.print_tree_pretty()

	if !localization_manager:
		localization_manager = get_tree().root.get_node("LocalizationManager")

func ldone_popup(amount: int, max_amount: int):
	ensure_localization_manager()

	localization_manager.set_placeholder("AMOUNT", str(amount))
	localization_manager.set_placeholder("MAXAMOUNT", str(max_amount))

	var popup = POPUP_LDONE_SCENE.instance() # localization_manager.tr(..) is done in _ready()
	get_tree().root.add_child(popup)

Additional info
Godot Engine v3.3.3.stable.official.b973f997f - https://godotengine.org
OpenGL ES 3.0 Renderer: Mesa Intel(R) UHD Graphics 620 (KBL GT2)
OpenGL ES Batching: ON

I have also tried using the singleton instead of get_node at runtime, but same results. I also experimented with adding some extra filters to the include non-resource files/folders box under the Resources tab in the export settings, but to no avail. Script Export Mode compiled made things even worse, the provided logs are from text mode
This is with the most recent commit 0209a33, but the same results apply with bbcdda3.
Source code of the affected game is private, but feel free to ask some more specifics if the provided information wasn't enough.

Hi, thx for bug report. Can you export as Desktop application, or is this issue only on adb export? Can you give me a simple single scene project/game with this bug? I try to fix next week.

Please try it with new release 1.5.8 i do some bugfixes for game export: https://github.com/VP-GAMES/LocalizationEditor/commit/3bcb94782f4bb22b18552a71a8555a3fe8ed20b1

Sorry for not following up on this issue, I was a bit busy... But it works now! Thank you very much.


enable support of alternate backend in building

Description of the change

extend Config type with Maybe Text for the optional backend entry
execute the alternateBackend in build, if it exists
add Dhall utility for optional entry in a Map

Checklist:

[x] Added the change to the "Unreleased" section of the changelog
[x] Added some example of the new feature to the README
[x] Added a test for the contribution (if applicable)

P.S.: the above checks are not compulsory to get a change merged, so you may skip them. However, taking care of them will result in less work for the maintainers and will be much appreciated 😊

@csicar thanks for doing this! 💯

Thanks for merging :)
I really like the code style of the spago code-base. Are you following a specific style-guide?

I've started work on the --run option (seems easy enough). But I think it does not make sense to implement it completely before the CLI spec is defined.
E.g. for running the test command you would need to choose the Test.Main module as the entry point, which should probably be supported by the CLI spec

@csicar

But I think it does not make sense to implement it completely before the CLI spec is defined

Agreed. I think we should close #355 (as the initial request was implemented here), and open two more issues: one for discussing/tracking the CLI spec for alternate backends, and the other one for the --run option

I really like the code style of the spago code-base. Are you following a specific style-guide?

Thanks 🙂 I don't follow a specific styleguide (consciously at least), and by now I forgot all the things I read and incorporated in my style, but I can say that I am heavily influenced by Gabriel Gonzales' style, which I find very pleasant to read.
So a good place to look could be the dhall-haskell codebase.
In general I just try to write "super boring code", so that it's accessible to people that are not familiar with certain operators, so it's easy to refactor when coming back to it after months, etc.
Some articles I find useful and usually recommend:

http://www.haskellforall.com/2015/09/how-to-make-your-haskell-code-more.html
https://chrisdone.com/posts/german-naming-convention/

I also run stylish-haskell on every save, to keep imports tidy

thanks for the insight :)

You're welcome! 🙂