Cancel Cross Region Restore Operation in API - 2023-12-15

ARM (Control Plane) API Specification Update Pull Request

[!TIP]
Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

[!NOTE]
As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

 Click here to see the details of Step 1
Breaking changes review (Diagram Step 1)
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:

The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
You believe there is no need for you to request breaking change approval, for any reason.
Such claims must be reviewed, and the process is the same.

 Click here to see the details of Step 2
ARM API changes review (Diagram Step 2)

For help with Step 2 / "ARM review", see https://aka.ms/azsdk/pr-arm-review.

 Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!

[ ] New resource provider.
[x] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix OpenAPI spec quality issues in S360.
[ ] Other, please clarify:

edit this with your clarification

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

 Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@ms-zhenhua Can you please check the PR now. the Lint Diff would fail as we have 2 versions. This was reviewed and discussed in the breaking change meeting

    "operationId": "BackupUsageSummariesCRR_List",

Using this CRR abbreviation everywhere doesn't really seem good for readability of the doc.
I also am finding it surprising in the context of the resource URI and the description of the operation, that the abbreviation appears here

Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:27 in ab6f027. [](commit_id = ab6f027996394f5999dba76faae9576f11521e1d, deletion_comment = False)

"/subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupCrrJob": {

I guess unfortunately 'CRR' ship has maybe already sailed. :(

Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:195 in ab6f027. [](commit_id = ab6f027996394f5999dba76faae9576f11521e1d, deletion_comment = False)

    },

I think its supposed to include a final operation response declaration, like 204 if there's no response content? Or 200 if there's a final response content after you finish polling on the Location header.

Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:291 in ab6f027. [](commit_id = ab6f027996394f5999dba76faae9576f11521e1d, deletion_comment = False)

        "$ref": "#/parameters/ApiVersion"

Consider removing your definitions of these common parameters and redirecting to commontypes types.json instead

Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:258 in ab6f027. [](commit_id = ab6f027996394f5999dba76faae9576f11521e1d, deletion_comment = False)

      "type": "string"

could add
"format": "arm-id"

Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:2490 in ab6f027. [](commit_id = ab6f027996394f5999dba76faae9576f11521e1d, deletion_comment = False)

    "operationId": "BackupUsageSummariesCRR_List",

Using this CRR abbreviation everywhere doesn't really seem good for readability of the doc.
I also am finding it surprising in the context of the resource URI and the description of the operation, that the abbreviation appears here
Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:27 in ab6f027. [](commit_id = ab6f027, deletion_comment = False)

This is an existing API and we have not made any changes here. It would not be possible to fix it now

"/subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupCrrJob": {

I guess unfortunately 'CRR' ship has maybe already sailed. :(
I do still think its an unfortunate appearance of Azure jargon in the REST API though. :(
Has it shipped as a public API doc already?
Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:195 in d9dcaa9. [](commit_id = d9dcaa9, deletion_comment = False)

Yes, unfortunately the ship has sailed a long time back and this PR is just a minor renovation

      "type": "string"

could add "format": "arm-id" if its not breaking, which I'm unclear on (it seems nonbreaking on the wire at least)
Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:2490 in d9dcaa9. [](commit_id = d9dcaa9, deletion_comment = False)

Added this

        "$ref": "#/parameters/ApiVersion"

Consider removing your definitions of these common parameters and redirecting to commontypes types.json instead
Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:258 in ab6f027. [](commit_id = ab6f027, deletion_comment = False)

Done the needful

    },

I think its supposed to include a final operation response declaration, like 204 if there's no response content? Or 200 if there's a final response content after you finish polling on the Location header.
Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:291 in ab6f027. [](commit_id = ab6f027, deletion_comment = False)

Added 200 as recommended

        "$ref": "#/parameters/ApiVersion"

Same for other parameters + operations - like SubscriptionId, and azure 'Location' parameter

In reply to:<PHONE_NUMBER>

Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:258 in ab6f027. [](commit_id = ab6f027996394f5999dba76faae9576f11521e1d, deletion_comment = False)

        "$ref": "#/parameters/ApiVersion"

Its not really required for my signoff though.

In reply to:<PHONE_NUMBER>

Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:258 in ab6f027. [](commit_id = ab6f027996394f5999dba76faae9576f11521e1d, deletion_comment = False)

        "$ref": "#/parameters/SubscriptionId"

Same for other parameters + operations - like SubscriptionId, and azure 'Location' parameter

Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:264 in 291d4c8. [](commit_id = 291d4c8b38a7b326a846cb97bcd0f5301d9a3c33, deletion_comment = False)

        "$ref": "#/parameters/AzureRegion"

Same for other parameters + operations - like SubscriptionId, and azure 'Location' parameter

Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:261 in 291d4c8. [](commit_id = 291d4c8b38a7b326a846cb97bcd0f5301d9a3c33, deletion_comment = False)

  "post": {

just wondering, why was this API originally a POST as opposed to get?

Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:196 in 291d4c8. [](commit_id = 291d4c8b38a7b326a846cb97bcd0f5301d9a3c33, deletion_comment = False)

  "post": {

just wondering, why was this API originally a POST as opposed to get?
Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:196 in 291d4c8. [](commit_id = 291d4c8, deletion_comment = False)

Only to enable LAC on source vault, since GET does not have a body :(

        "$ref": "#/parameters/ApiVersion"

Same for other parameters + operations - like SubscriptionId, and azure 'Location' parameter
In reply to:<PHONE_NUMBER>
Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:258 in ab6f027. [](commit_id = ab6f027, deletion_comment = False)

Fixed this

There are many LintDiff errors, can you address more?

I have addressed the ones for the ordering of parameters and also for using common types.. The others are related to the already existing APIs and I dont think i should make changes in the existing APIs. The reason being this is a special scenario for swagger for the cross region restore operation

      "format": "arm-id"

does it make sense to use https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-arm-id-details also?
Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:2494 in 291d4c8. [](commit_id = 291d4c8, deletion_comment = False)

Keeping this as arm-id and not adding the scope here

        "$ref": "#/parameters/AzureRegion"

Same for other parameters + operations - like SubscriptionId, and azure 'Location' parameter
Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:261 in 291d4c8. [](commit_id = 291d4c8, deletion_comment = False)

updated

  "post": {

Any special reason the verb is POST? Like read permissions being too permissive? Or you don't want to return a typical resource response body? Or secrets in the response?
It looks like otherwise you could maybe have gone with 'GET' since its 'listing job resources'.

Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:304 in aacf11a. [](commit_id = aacf11a194beb1f092805e86a91e6fca36222e00, deletion_comment = False)

          "$ref": "#/definitions/NewErrorResponse"

I wonder why you are using this thing called NewErrorResponse instead of the standard error response?

Refers to: specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2023-12-15/bms.json:408 in aacf11a. [](commit_id = aacf11a194beb1f092805e86a91e6fca36222e00, deletion_comment = False)

/pr RequestMerge

@rkmanda There are a lot of lintDiff errors here, which supposedly aren't related to the changes of the PR, yet they show up as 'caused by new version', I wonder why / how to resolve this. I didn't have a problem with the new changes proposed as far as I understand them.

@asmaskar Could you please take a follow-up work item to add documentation for your /operations API?

You're still getting a lot of lint errors for existing APIs that don't follow all the recommended practices. Could you please take a followup work item to look at addressing all the linter errors about API doc best practice which can be fixed with minimal impact? Such as:

consider adding 'pattern' constraint on vault names, fabric names, and so on - just to properly document your already existing enforcement rules that your service enforces
add x-ms-pageable annotation on your LIST APIs
specify schema for 200 response codes if you have one
document the Location header if your service already returns it with 202 responses
not documenting error response codes explicitly if not needed (its implied)
mark location property with correct mutability
addressing the 'different schemas' warnings:

/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response.
Location: Microsoft.RecoveryServices/stable/2023-12-15/bms.json#L552

There are still a number of lint errrors .. were these already discussed with the previous arm reviewer ?  If so they need to be suppressed accordingly before merge.

@TimLovellSmith  @raosuhas  Will it be fine if i create a work item and assign it to the owner of the already existing APIs, making changes to all the existing ones right now will be a very big change when i am not fully sure of all the APIs

@asmaskar To make that a little more concrete, I'd suggest first you start by discussing the linter errors involving the prospective owners of all those work items, so you can come to agreement with them about which are the ones that you all together will actually fix. Then in this PR, after you're clear on what's going to get fixed, and what is not going to get fixed, add your linter suppressions for everything that is not planned to fix.


[fuzz] misc HCM fuzz bugs

Commit Message: Fixes two minor HCM fuzz bugs
Additional Description: Adds codec dispatch error action, which throw exception now performs. Also fixes a buffer overflow in test code.
Risk Level: Low
Testing: Corpus entries added
Fixes:

https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=22137
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=22098

/review @adisuissa

Looks good to me.


deb: Address lintian errors

Currently we get following lintian errors & warnings:
E: td-agent changes: bad-distribution-in-changes-file unstable
E: td-agent: embedded-library opt/td-agent/lib/ruby/2.4.0/x86_64-linux/psych.so: libyaml
E: td-agent: extended-description-is-empty
E: td-agent: no-copyright-file
W: td-agent: binary-without-manpage usr/bin/td
W: td-agent: binary-without-manpage usr/sbin/td-agent
W: td-agent: binary-without-manpage usr/sbin/td-agent-gem
W: td-agent: maintainer-script-needs-depends-on-adduser postinst
W: td-agent: maintainer-script-should-not-use-recursive-chown-or-chmod postinst:60
W: td-agent: maintainer-script-should-not-use-recursive-chown-or-chmod postinst:63
W: td-agent source: missing-debian-source-format
W: td-agent source: no-debian-copyright
W: td-agent: package-has-unnecessary-activation-of-ldconfig-trigger
W: td-agent: possibly-insecure-handling-of-tmp-files-in-maintainer-script postinst:62
W: td-agent source: unused-build-dependency-on-cdbs
W: td-agent: unusual-interpreter opt/td-agent/lib/ruby/gems/2.4.0/gems/bundler-1.16.6/lib/bundler/templates/Executable #!<%=
W: td-agent: unusual-interpreter opt/td-agent/lib/ruby/gems/2.4.0/gems/bundler-1.16.6/lib/bundler/templates/Executable.bundler #!<%=
W: td-agent: unusual-interpreter opt/td-agent/lib/ruby/gems/2.4.0/gems/bundler-1.16.6/lib/bundler/templates/Executable.standalone #!<%=
W: td-agent: uses-dpkg-database-directly postinst (line 37)
W: td-agent: uses-dpkg-database-directly postinst (line 40)
N: 360 tags overridden (224 errors, 136 warnings)

In addition, we are now suppressing more errors/warning by overriding lintian tags:
$ cat td-agent/debian/td-agent.lintian-overrides
td-agent: package-contains-vcs-control-file
td-agent: windows-devel-file-in-package
td-agent: dir-or-file-in-build-tree
td-agent: ruby-script-but-no-ruby-dep
td-agent: script-not-executable
td-agent: python-script-but-no-python-dep
td-agent: executable-not-elf-or-script
td-agent: missing-dep-for-interpreter
td-agent: gz-file-not-gzip
td-agent: no-upstream-changelog
td-agent: library-not-linked-against-libc
td-agent: wrong-path-for-interpreter
td-agent: duplicate-font-file
td-agent: jar-not-in-usr-share
td-agent: incorrect-libdir-in-la-file

We should ensure to address them by proper ways.

W: td-agent source: missing-debian-source-format

It is regarded to be as a native package.

W: td-agent source: missing-debian-source-format

It is regarded to be as a native package.

I've created PR for this issue. https://github.com/clear-code/td-agent-builder/pull/39

E: td-agent: extended-description-is-empty

It seems that there is abstruction about td-agent, but not additional explanation.

E: td-agent: extended-description-is-empty

It seems that there is abstruction about td-agent, but not additional explanation.

Ive created PR for this issue. https://github.com/clear-code/td-agent-builder/pull/40

E: td-agent changes: bad-distribution-in-changes-file unstable

It seems that changelog td-agent (3.7.1-1) unstable; urgency=low is wrong.

./lib/apt/build.sh should be modified instead of td-agent/apt/build.sh.

./lib/apt/build.sh should be modified instead of td-agent/apt/build.sh.

Yes, later one is just copied from former one.

E: td-agent changes: bad-distribution-in-changes-file unstable

I've create PR for this issue https://github.com/clear-code/td-agent-builder/pull/41

I've found trivial one in d/control, so I've also filed as PR about Homepage:
https://github.com/clear-code/td-agent-builder/pull/42

W: td-agent source: unused-build-dependency-on-cdbs

I've created PR for this issue. https://github.com/clear-code/td-agent-builder/pull/43

Issue status is a bit moving forwarded.

[ ] E: td-agent changes: bad-distribution-in-changes-file unstable https://github.com/clear-code/td-agent-builder/pull/41 woking
[x] E: td-agent: extended-description-is-empty https://github.com/clear-code/td-agent-builder/pull/40
[x] W: td-agent source: missing-debian-source-format https://github.com/clear-code/td-agent-builder/pull/39
[ ] W: td-agent source: unused-build-dependency-on-cdbs https://github.com/clear-code/td-agent-builder/pull/43 (working)
[x] Fixed Homepage: https://github.com/clear-code/td-agent-builder/pull/42

A bit updated lintian on buster. some errors was fixed.
W: td-agent source: unused-build-dependency-on-cdbs
W: td-agent source: changelog-should-mention-nmu
W: td-agent source: source-nmu-has-incorrect-version-number 3.7.1-1
W: td-agent source: no-debian-copyright
W: td-agent-dbgsym: debug-file-with-no-debug-symbols usr/lib/debug/.build-id/6f/81198e00dfa50d5c65d06de9c3c04dcbb7d1ea.debug
W: td-agent-dbgsym: debug-file-with-no-debug-symbols usr/lib/debug/.build-id/a6/f706fb69f35b460a6374692c1fedd9d8d0bff3.debug
E: td-agent: no-copyright-file
W: td-agent: uses-dpkg-database-directly postinst (line 37)
W: td-agent: uses-dpkg-database-directly postinst (line 40)
W: td-agent: binary-without-manpage usr/bin/td
W: td-agent: binary-without-manpage usr/sbin/td-agent
W: td-agent: binary-without-manpage usr/sbin/td-agent-gem
W: td-agent: incorrect-path-for-interpreter opt/td-agent/bin/jeprof (#!/usr/bin/env perl != /usr/bin/perl)
W: td-agent: unusual-interpreter opt/td-agent/lib/ruby/gems/2.4.0/gems/bundler-1.16.6/lib/bundler/templates/Executable #!<%=
W: td-agent: unusual-interpreter opt/td-agent/lib/ruby/gems/2.4.0/gems/bundler-1.16.6/lib/bundler/templates/Executable.bundler #!<%=
W: td-agent: unusual-interpreter opt/td-agent/lib/ruby/gems/2.4.0/gems/bundler-1.16.6/lib/bundler/templates/Executable.standalone #!<%=
W: td-agent: maintainer-script-should-not-use-recursive-chown-or-chmod postinst:60
W: td-agent: possibly-insecure-handling-of-tmp-files-in-maintainer-script postinst:62
W: td-agent: maintainer-script-should-not-use-recursive-chown-or-chmod postinst:63
W: td-agent: package-has-unnecessary-activation-of-ldconfig-trigger
N: 278 tags overridden (151 errors, 127 warnings); 1 unused override
N: Some overrides were ignored, since the tags were marked "non-overridable".
N: Use --verbose for more information.

I'm working on manpage.

I've fixed https://github.com/clear-code/td-agent-builder/pull/45
W: td-agent: binary-without-manpage usr/bin/td
W: td-agent: binary-without-manpage usr/sbin/td-agent
W: td-agent: binary-without-manpage usr/sbin/td-agent-gem

Related to #45, I've found a typo in td-agent-gem, I'll feedback to upstream

Related to #45, I've found a typo in td-agent-gem, I'll feedback to upstream
https://github.com/ruby/ruby/blob/ac2c07e98373bb62be618001c897fa9d5809d8a4/lib/rubygems/command.rb#L651

Already fixed in upstream.

I've fixed  W: td-agent: unusual-interpreter via  https://github.com/clear-code/td-agent-builder/pull/46

W: td-agent: possibly-insecure-handling-of-tmp-files-in-maintainer-script postinst:62

Fixed in  https://github.com/clear-code/td-agent-builder/pull/47

Progress summary:

W:binary-without-manpage https://github.com/clear-code/td-agent-builder/pull/45 (on review)
W:unusual-interpreter https://github.com/clear-code/td-agent-builder/pull/46 (on review)
W:possibly-insecure-handling-of-tmp-files-in-maintainer-script https://github.com/clear-code/td-agent-builder/pull/47 (review feedback fixed)
W:maintainer-script-should-not-use-recursive-chown-or-chmod https://github.com/clear-code/td-agent-builder/pull/48 (waiting review)
W:package-has-unnecessary-activation-of-ldconfig-trigger https://github.com/clear-code/td-agent-builder/pull/49 (wating review)

Here is the progress,

W:binary-without-manpage
　* https://github.com/clear-code/td-agent-builder/pull/45 (Fixed CI)
W:unusual-interpreter

https://github.com/clear-code/td-agent-builder/pull/46 (Tried to simplify by wildcard, but not succeeded)

W:maintainer-script-should-not-use-recursive-chown-or-chmo

https://github.com/clear-code/td-agent-builder/pull/48 (Fixed and merged)

I'll fix E: td-agent: no-copyright-file

Progress summary:

W:binary-without-manpage deb: install missing manpages

https://github.com/clear-code/td-agent-builder/pull/45 (Merged)

W: incorrect-path-for-interpreter

https://github.com/clear-code/td-agent-builder/pull/55 (Merged)

E: td-agent: no-copyright-file

https://github.com/clear-code/td-agent-builder/pull/56 (Work in progress)

Current status of lintian with master:
W: td-agent source: changelog-should-mention-nmu
W: td-agent source: source-nmu-has-incorrect-version-number 3.7.1-1
W: td-agent source: no-debian-copyright
E: td-agent: no-copyright-file
W: td-agent: uses-dpkg-database-directly postinst (line 37)
W: td-agent: uses-dpkg-database-directly postinst (line 40)
W: td-agent-dbgsym: debug-file-with-no-debug-symbols usr/lib/debug/.build-id/6f/81198e00dfa50d5c65d06de9c3c04dcbb7d1ea.debug
W: td-agent-dbgsym: debug-file-with-no-debug-symbols usr/lib/debug/.build-id/a6/f706fb69f35b460a6374692c1fedd9d8d0bff3.debug
N: 222 tags overridden (106 errors, 116 warnings); 2 unused overrides
N: Some overrides were ignored, since the tags were marked "non-overridable".
N: Use --verbose for more information.

I'm working on E:td-agent: co-copyright-file in https://github.com/clear-code/td-agent-builder/pull/56

It seems that it is better to inject  new depended rake task to build:deb_config

missing license by gem specificaiton:
cool.io-1.6.0.gem
async-pool-0.2.0.gem
td-0.16.8.gem
webhdfs-0.9.0.gem

I've send PR to add missing licenses.
https://github.com/tarcieri/cool.io/pull/67
https://github.com/socketry/async-pool/pull/4
https://github.com/treasure-data/td/pull/236
https://github.com/kzk/webhdfs/pull/38

I've fixed #56

https://github.com/tarcieri/cool.io/pull/67 merged
https://github.com/socketry/async-pool/pull/4 merged
https://github.com/kzk/webhdfs/pull/38 merged

TODO:

W: td-agent source: space-in-std-shortname-in-dep5-copyright
E: td-agent: incorrect-libdir-in-la-file
W: td-agent: package-contains-vcs-control-file
W: td-agent-dbgsym(may be overrided)

W: td-agent source: missing-license-paragraph-in-dep5-copyright apache license version 2.0 (paragraph at line 128)
W: td-agent source: space-in-std-shortname-in-dep5-copyright apache license version 2.0 (paragraph at line 128)

It is better to feedback to ruby-kafka about gemspec license field. http://spdx.org/licenses/
Files: downloads/plugin_gems/15-ruby-kafka-1.0.0.gem
Copyright: Daniel Schierbeck
License: Apache License Version 2.0

I've fixed spdx license warning.
https://github.com/clear-code/td-agent-builder/pull/57

I've fixed E: td-agent: incorrect-libdir-in-la-file
https://github.com/clear-code/td-agent-builder/pull/58

I've fixed W: td-agent: package-contains-vcs-control-file
https://github.com/clear-code/td-agent-builder/pull/59

I've send another PR to remove unused override rule.
https://github.com/clear-code/td-agent-builder/pull/60

close this issue if https://github.com/clear-code/td-agent-builder/pull/63 is merged.

As all PRs are merged, I'll close this PR!


Getting FailedPrecondition error in model_garden_pytorch_mistral notebook

Expected Behavior
Trying to deploy the prebuilt mistral model with the Jupyter notebook with vLLM in the notebook.
I have tried a couple of different configurations - the one I want to use is:
machine_type = "n1-standard-16"
accelerator_type = "NVIDIA_TESLA_T4"
accelerator_count = 2

I have tried all the steps in the notebook to build the container and each different configuration comes back with an error.
Actual Behavior
As above
Steps to Reproduce the Problem

Test model_garden_pytorch_mistral.ipynb code to check that this builds the model
Try the configuration as above

Can you let me know what I am doing wrong here, as it doesn't seem apparent?

@kathyyu-google can you please check if you can assist? Thanks.

Hi @StatsGary, could you try if the fixes mentioned in #2620 (which also faced a FAILED_PRECONDITION error) address your issue? You may directly run the updated notebook or try adjusting --max-model-len and/or --max-num-batched-tokens. Thank you!

Hi @kathyyu-google - this indeed resolved the issue. I managed to deploy this using the UI successfully in the interim, but thanks for the response.


Rework scripts and modules

The code will be in different .py files.
We will use jupyter only for the visualisation of the results.


Better docs for exposing ports to public

There should be more information in the readme regarding exposing ports to the public i.e.:

How does it work?
What proxy/service does it use?
How do I close and cleanup it? Do I need to explicitly remove the created network/bridge?
Is it safe - does it use ONLY official docker images under the hood? (if not, it might be good to contribute further to do so). IMHO it could contain a warning that it might not be safe as you let others connect/run stuff on your local machine (if you do it from your desktop).

I agree ppl can see that in the code but I'd expect a good project to have such crucial info in the readme.

The first three points are covered in the plugin documentation - https://github.com/lukaszlach/clip/tree/master/clips/expose
The last point is something I was also thinking about, dive and runlike and run from the official images (created by the authors of the respective tools), ngrok does not have an official image, I use the one I have been using since. It may be a good idea to create a dedicated image for this plugin.

"expose" clip now uses an image from my namespace, until ngrok creates its own official one.


Minified file not sync to remote server

What steps will reproduce the problem?

   1.create style.css
   2.minify it in separate file (it's immediately sync with remote server)
   3.change style.css, minify it again
   4.minified files changed byt not synchronized to remote server

What is the expected output? What do you see instead?

   Minified file must cause sync of itself

What version of the product are you using? On what operating system?

   Product Version: NetBeans IDE 8.0.2 (Build<PHONE_NUMBER>05)
   Обновления: Среда NetBeans IDE обновлена до версии NetBeans 8.0.2 Patch 1
   Java: 1.8.0_25; Java HotSpot(TM) 64-Bit Server VM 25.25-b02
   Runtime: Java(TM) SE Runtime Environment 1.8.0_25-b18

Please provide any additional information below.

A attach a video demonstration

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 16 May 2015 at 1:13
Attachments:

css.mp4

I guess it is a php project? There is no sync to remote function in other project types (Maybe maven but I don't know). So please reopen if still valid and give more information. If anyone will read this :D


Ineffectual mount label. What are the effects?

Hi @codenrhoden / @cduchesne,
When working on PR #397 I noticed that line #101 in the OS driver linux.go is ineffectual. It means that the value is never used. Let's look at lines 101 and 102:
	options := formatMountLabel("", opts.MountLabel)
	options = fmt.Sprintf("%s,%s", opts.MountOptions, opts.MountLabel)

The first value is never used because it's immediately overridden with the second. Now, the issue is that I'm not sure what the correct resolution is. Clearly what's there is what is working, so perhaps I could just remove the first line. However, what was the original intention? I need to look into it more. This issue is a reminder to do that as well as me asking you two to take a look as well. Thanks!

Hell, it looks worse than that to me:
	options := formatMountLabel("", opts.MountLabel)
	options = fmt.Sprintf("%s,%s", opts.MountOptions, opts.MountLabel)
	if fsType == "xfs" {
		options = fmt.Sprintf("%s,nouuid", opts.MountLabel)
	}

If you specify a mount label, it's not going to be applied, since options is overwritten on the second line. But, if you do specify a mountlabel, I think that fmt.Sprintf line is going to spit out an invalid format for the mount command. it doens't have the context= key in front of it...
But the other thing is in the XFS block. All the mount options are lost for XFS (unless this was done on purpose?) becaues that fmt.Sprintf passes opts.MountLabel instead of options...
Just a first glance at it... I need to take another look at the diff between mount -t xfs and mount -t ext3 and see if options and labels are handled correctly I guess.


chore(deps): Included dependency review

Dependency Review GitHub Action in your repository to enforce dependency reviews on your pull requests.
The action scans for vulnerable versions of dependencies introduced by package version changes in pull requests,
and warns you about the associated security vulnerabilities.
This gives you better visibility of what's changing in a pull request,
and helps prevent vulnerabilities being added to your repository.

https://docs.github.com/en/code-security/supply-chain-security/understanding-your-software-supply-chain/about-dependency-review#dependency-review-enforcement
Signed-off-by: naveensrinivasan<EMAIL_ADDRESS>

@cpanato  👀

Codecov Report

Merging #540 (5aeaef6) into main (be77c26) will decrease coverage by 0.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #540      +/-   ##
==========================================
- Coverage   35.68%   35.47%   -0.22%
==========================================
  Files          18       18
  Lines        1415     1415
==========================================
- Hits          505      502       -3
- Misses        851      853       +2
- Partials       59       60       +1

Impacted Files
Coverage Δ

pkg/ca/fileca/load.go
58.62% <0.00%> (-10.35%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be77c26...5aeaef6. Read the comment docs.


.NET 9 Tests RC 1 seems to handle empty collections differently in my project

Describe the bug
While adding net9.0 tfm to a project a couple of my tests started to fail where snapshot
{
  Item1: Accepted,
  Item2: []
}

Example:
https://github.com/devlead/Blobify/blob/3298d272164892bedd43f45af7f581fe83f5fb0f/src/Blobify.Tests/Unit/Services/Storage/TokenServiceTests.PutAsync.verified.txt#L1-L4
Became:
{
  Item1: Accepted
}

Changing code from
// Then
await Verify(result);

to
// Then
await Verify(result)
    .DontIgnoreEmptyCollections();

Sorted the issue with the tests that started failing,
Minimal Repro
Haven't created a minimal repro yet, but  at least locally on my machine if I remove this line, the test will start to consistently assert differently on net9.0 than net8.0
 .DontIgnoreEmptyCollections();

https://github.com/devlead/Blobify/blob/2a4175240d932c3a4368a9f76b9e5994a65bfe5c/src/Blobify.Tests/Unit/Services/Storage/TokenServiceTests.cs#L52

so omitting the empty collection is the correct behavior.
it was a bug that in earlier versions of .net it was included. that will be fixed in the next release of verify
i submitted a PR to Blobify to include empty collections by default https://github.com/devlead/Blobify/pull/4

Thanks for the PRs, for be it would've been fine if they were omitting by default, what threw me was that it behaved differently in same test project based on TFM.


exclude appname from check_longest_query

Currently, there's --exclude to filter out some queries.
To filter out pg_dump (i.e.), we have to --exclude '^COPY'. That's a bit too agressive.
What about adding a new parameter --appexclude (i.e.) to improve that?
It could then be implemented as well in check_oldest_idlexact (issue #91 ) for harmonisation.
Any advice against this?

--exclude can be used to filter out both query and application_name

Issue fixed, thanks a lot for your contribution.


⚠ Bofrost.com has degraded performance

In 572c48e, Bofrost.com (https://www.bofrost.com) experienced degraded performance:

HTTP code: 200
Response time: 940 ms

Resolved: Bofrost.com performance has improved in a233e15.


(GH-719) Tagged commits on Hotfix branch do not use the correct seman…

…tic version number
Hotfix and Release branches should use the unique semantic version
number - implemented in (GH-616).
To fully implement as intended, the logic for applying the correct
semantic version format needs to ensure that the 'is tagged' check
is applied to each of the branch types.

@codemonkey256 your changes have been merged, thanks for your contribution 👍
@gep13 we may perhaps want to get this one out in a 2.0.2 release? (Not assigned a milestone to the referenced issue).

@codemonkey256 thanks for getting this done!  Looking to get a new version of Cake.Recipe released tonight, so this fix will go out with it.  Thanks


CPU Temperature graphs not working in 24.7.7

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[X] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[X] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
After upgrading to 24.7.7, I found that the reporting graphs were not working. I reset the RRD data and restarted the system. The graphs re-populated, except for the cputemp graph.
After some troubleshooting, I tracked the issue to the recent RRD refactoring (https://github.com/opnsense/core/pull/7836). I found that the sysctl command to get CPU temps was returning an error. Also, the RRD filename is not defined in Types/Temperature.php.
To Reproduce
Steps to reproduce the behavior:

Install OPNsense 24.7.6
Ensure Thermal Sensors are configured correctly under System -> Settings -> Miscellaneous
Ensure "Enables the RRD graphing backend" is checked under Reporting -> Settings.
Ensure non-zero values are displayed in the System/Cputemp graph under Reporting -> Health.
Upgrade to OPNsense 24.7.7
Go to Reporting -> Settings
Click "Reset RRD Data"
Wait over 1 minute

Actual behavior

The system-cputemp RRD is not recreated
There is no System/Cputemp graph under Reporting -> Health, or if there is a graph it does not update.

Expected behavior

The system-cputemp RRD should be listed under Reporting -> Settings
The System/Cputemp graph under Reporting -> Health should appear with non-zero values.

Describe alternatives you considered
N/A
Screenshots
N/A
Relevant log files
N/A
Additional context
N/A
Environment
Software version used and hardware type if relevant, e.g.:
OPNsense 24.7.7 (amd64).
Intel® Pentium® J3710 2.64Ghz Quad Core (using coretemp)
Network Intel® I225-V

I've submitted a pull request with a fix: https://github.com/opnsense/core/pull/8024


zope-interface>=5

When I run "python setup.py install" in the mamba-1p1p1 folder, I get the following error:
Processing dependencies for mamba-ssm==1.1.1
Searching for zope-interface>=5
Reading https://pypi.org/simple/zope-interface/
No local packages or working download links found for zope-interface>=5
error: Could not find suitable distribution for Requirement.parse('zope-interface>=5')
However, I have installed zope-interface==5 or zope-interface==6.2 and it still gives the same error.
What is the reason for this? How can I fix it?

I faced the same issue with v1.1.0
I fixed it by manually cloning the latest release https://github.com/state-spaces/mamba/tree/v1.2.0 and running python3 setup.py install. it works

I faced the same issue with v1.1.0 I fixed it by manually cloning the latest release https://github.com/state-spaces/mamba/tree/v1.2.0 and running python3 setup.py install. it works

Thank you so much, you are my savior 🫡! I have successfully installed v1.2.0!🙌
However, when I tested the code (Test Code), there was a headache.
Error: causal_conv1d_fwd(): incompatible function arguments. The following argument types are supported ... .
In fact, I have downloaded its whl and successfully installed it, version causal_conv1d-1.2.0.post2+cu118torch2.1cxx11abiFALSE-cp310-cp310-linux_x86_64.whl. Obviously, it's not working properly.
Have you encountered such a problem? Or are you also installing this version of causal_conv1d? I was a little tempted to back off because I could use the lower version of mamba, but I really wanted to try Vim 😵.
Test Code:
import torch
from mamba_ssm import Mamba
batch, length, dim = 2, 64, 16
x = torch.randn(batch, length, dim).to("cuda")
model = Mamba(
# This module uses roughly 3 * expand * d_model^2 parameters
d_model=dim, # Model dimension d_model
d_state=16,  # SSM state expansion factor
d_conv=4,    # Local convolution width
expand=2,    # Block expansion factor
).to("cuda")
y = model(x)
assert y.shape == x.shape

Hey @ZJier
I tried the same code and had the same issue. I am running this code on Nvidia AGX Xavier and by default mamba_ssm and causal-conv1d did not support my GPU.
I just added support using these PRs and it works now. I would recommend you do the same for your GPU.
Reference
causal-conv1d PR - https://github.com/Dao-AILab/causal-conv1d/pull/20
mamba PR - https://github.com/state-spaces/mamba/pull/262
Nvidia CUDA compatibility - https://developer.nvidia.com/cuda-gpus
i hope this helps

Hey @ZJier
I tried the same code and had the same issue. I am running this code on Nvidia AGX Xavier and by default mamba_ssm and causal-conv1d did not support my GPU.
I just added support using these PRs and it works now. I would recommend you do the same for your GPU. After the edits, you need to reinstall mamba_ssm and causal-conv1d
Reference causal-conv1d PR - Dao-AILab/causal-conv1d#20 mamba PR - state-spaces/mamba#262 Nvidia CUDA compatibility - https://developer.nvidia.com/cuda-gpus
i hope this helps

Thank you so much for answering all my questions.😺😺😺
I'm using a laptop, which seems to be a little different from the embedded system solution.🤪
I followed up on this error and found that the part parameters passed into the causal_conv1d_fwd() function seemed to be missing, preventing me from running the test code correctly.🤔
I think the problem may still be related to the mamba and causal-conv1d library installation, although both versions are correct.
I have built a lot of new virtual environments, and I'm already using an older version of the mamba library, not vision mamba, which works fine.
I read the vision mamba paper, and I found that the transformer encoder in vision transformer is directly replaced with the state model in mamba (not vision mamba), and it has the prototype of vision mamba. This solution seemed to solve my problem from another Angle.
Thank you very much for your help again. Good luck to you 🫡!
Exception has occurred: TypeError
causal_conv1d_fwd(): incompatible function arguments. The following argument types are supported:
1. (arg0: torch.Tensor, arg1: torch.Tensor, arg2: Optional[torch.Tensor], arg3: Optional[torch.Tensor], arg4: Optional[torch.Tensor], arg5: Optional[torch.Tensor], arg6: bool) -> torch.Tensor


Getting issue in evaluating submission in worker

Hi,
I am setting up the competition Machine Translation for Indian Languages @https://www.codabench.org/competitions/2889/
Since the default queue has a 600 second time limit, I switched to custom queue with remote worker.
The competition is result submission only.
So as per my understanding an ingestion program is not required.
However, the submission is not getting processed and throwing error given below:

Please can you help with the issue as I am not able to solve it using the documentation

Can you please attach your yaml file here

Can you change your command to
command: python3 metrics.py

assuming metrics.py is your scoring program

It is now not able to find the program

Hi,
On further investigation of logs it seems that the codabench server interacts with the remote worker machine and tries to run the scoring code locally.

And may be due to security restrictions in the network the code does not get copied to the worker. Is my understanding correct?

I am not sure what is wrong there but you can check this bundle which is results only competition and you can modify it to meet your needs and then submit a submission to see what happens

Hi @surupendu

Was the submissions working before on the default queue?
Is there an actual problem with the scoring of submissions?

The ingestion program not found is a warning, not an error message. It is normal to receive it in case of result submission competitions.

Hi @Didayolo
Earlier due to the issue with the zipping of the scoring program at folder level, the evaluation was not working as the submission was getting timed out.
As I could not access the logs in the default queue, I switched to using remote worker queue where in the logs showed that it was searching for the ingestion program. Turns out I needed to zip the scoring program at a file level instead of folder level (based on solution provided by @ihsaan-ullah)
However now the remote worker started giving the issue that "metrics.py" not found in directory.
I switched to using the default queue and my submissions started working correctly.
The submissions are now using the default queue.
My only concern now is that if I switch to using a remote worker out of need for heavy computation then I will face the issue of scoring program not found, the error that I was getting earlier.

@surupendu @ihsaan-ullah
It is absolutely not normal, and quite concerning, that the submissions works on the default queue but not on a custom queue.
This could indicate that recent changes made to the compute worker's code (#1408) are breaking something.
Indeed, the workers of the default queue are not up-to-date, while @surupendu is using the latest version of the code when creating the workers.

I have recently setup new workers on Google Cloud. I haven't any problem like this

Indeed. @surupendu Are you still experiencing problems?

@Didayolo and @ihsaan-ullah thank you for the support.
I am now running the competition on default queue.
If I face any issue in custom queue I will share the logs with you.
We can close the issue for now.


Parent tags display the same note multiple times

I have a tag heirachy that is
#Dope/Scratch
#Dope/D001
When I just click on the tag #Dope it displays 1 note as many times as it has child tags. So a tag that has both those sub-tags, displays 2 times in the sidebar that is filtering them.

Im unsure if this is intended or if its a bug. I would prefer for it to only show the tag once, maybe its a setting im missing.
Either way, LOVE this plugin, makes obsidian usable to me! Thanks!

Sorry for being delayed!
I think that you probably wanted to view it like this:

As shown in the screenshot, this should be possible. Maybe one of the settings is conflicted with the other.
My setting like the below makes the previous screenshot. May I ask about your configuration?


Remove legacy dcpower support

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?
Removes legacy nidcpower support.  nitsm now only supports nidcpower with cxp.
Why should this Pull Request be merged?
Resolves #119
What testing has been done?
Full suite.

[x] I have run the automated tests (required if there are code changes)

/azp run


Extractor need to fixed for 365datascience.teachable.com

Checklist

[x] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2020.03.24
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-u', 'PRIVATE', '-p', 'PRIVATE', '-F', '--no-check-certificate', 'https://365datascience.teachable.com/courses/361452', '-v']
[debug] Encodings: locale cp1256, fs mbcs, out cp720, pref cp1256
[debug] youtube-dl version 2020.03.24
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.17134
[debug] exe versions: ffmpeg git-2020-02-16-8578433, ffprobe git-2020-02-16-8578433
[debug] Proxy map: {}
[generic] 361452: Requesting header
[redirect] Following redirect to https://365datascience.teachable.com/p/intro-to-data-and-data-science
[generic] intro-to-data-and-data-science: Requesting header
WARNING: Falling back on generic information extractor.
[generic] intro-to-data-and-data-science: Downloading webpage
[generic] intro-to-data-and-data-science: Extracting information
[TeachableCourse] Downloading 365datascience.teachable.com login page
[TeachableCourse] Logging in to 365datascience.teachable.com
[TeachableCourse] intro-to-data-and-data-science: Downloading webpage
[download] Downloading playlist: Intro to Data and Data Science
[TeachableCourse] playlist Intro to Data and Data Science: Collected 5 video ids (downloading 5 of them)
[download] Downloading video 1 of 5
[Teachable] Downloading 365datascience.teachable.com login page
[Teachable] 5638888: Downloading webpage
[download] Downloading playlist: Welcome to Intro to Data and Data Science
[Teachable] playlist Welcome to Intro to Data and Data Science: Collected 1 video ids (downloading 1 of them)
[download] Downloading video 1 of 1
[Wistia] l2jjrj0ew7: Downloading JSON metadata
[info] Available formats for l2jjrj0ew7:
format code   extension  resolution note
mp4-224p      mp4        400x224     329k , mp4 container, h264, 1.60MiB
iphone-360p   mp4        640x360     670k , mp4 container, h264, 3.26MiB
md_mp4-540p   mp4        960x540     836k , mp4 container, h264, 4.06MiB
hd_mp4-720p   mp4        1280x720   1203k , mp4 container, h264, 5.85MiB
hd_mp4-1080p  mp4        1920x1080  2379k , mp4 container, h264, 11.56MiB
original      mp4        1920x1080  10256k , 49.84MiB (best)
[download] Finished downloading playlist: Welcome to Intro to Data and Data Science
[download] Downloading video 2 of 5
[Teachable] 5537196: Downloading webpage
[download] Downloading playlist: Traditional Data: Real-life Examples
[Teachable] playlist Traditional Data: Real-life Examples: Collected 1 video ids (downloading 1 of them)
[download] Downloading video 1 of 1
[Wistia] ef6fjmbkij: Downloading JSON metadata
[info] Available formats for ef6fjmbkij:
format code   extension  resolution note
mp4-224p      mp4        400x224     200k , mp4 container, h264, 2.56MiB
iphone-360p   mp4        640x360     307k , mp4 container, h264, 3.92MiB
md_mp4-540p   mp4        960x540     384k , mp4 container, h264, 4.90MiB
hd_mp4-720p   mp4        1280x720    525k , mp4 container, h264, 6.71MiB
hd_mp4-1080p  mp4        1920x1080   813k , mp4 container, h264, 10.39MiB
original      mp4        1920x1080  1548k , 19.77MiB (best)
[download] Finished downloading playlist: Traditional Data: Real-life Examples
[download] Downloading video 3 of 5
[Teachable] 5537224: Downloading webpage
[download] Downloading playlist: Big Data: Real-life Examples
[Teachable] playlist Big Data: Real-life Examples: Collected 1 video ids (downloading 1 of them)
[download] Downloading video 1 of 1
[Wistia] ad2ppqpeu1: Downloading JSON metadata
[info] Available formats for ad2ppqpeu1:
format code   extension  resolution note
mp4-224p      mp4        400x224     187k , mp4 container, h264, 2.10MiB
iphone-360p   mp4        640x360     273k , mp4 container, h264, 3.07MiB
md_mp4-540p   mp4        960x540     331k , mp4 container, h264, 3.74MiB
hd_mp4-720p   mp4        1280x720    458k , mp4 container, h264, 5.16MiB
hd_mp4-1080p  mp4        1920x1080   677k , mp4 container, h264, 7.63MiB
original      mp4        1920x1080  1372k , 15.44MiB (best)
[download] Finished downloading playlist: Big Data: Real-life Examples
[download] Downloading video 4 of 5
[Teachable] 5537246: Downloading webpage
[download] Downloading playlist: Business Intelligence (BI): Real-life Examples
[Teachable] playlist Business Intelligence (BI): Real-life Examples: Collected 1 video ids (downloading 1 of them)
[download] Downloading video 1 of 1
[Wistia] x1nh89ldqi: Downloading JSON metadata
[info] Available formats for x1nh89ldqi:
format code   extension  resolution note
mp4-224p      mp4        400x224     231k , mp4 container, h264, 2.90MiB
iphone-360p   mp4        640x360     342k , mp4 container, h264, 4.29MiB
md_mp4-540p   mp4        960x540     468k , mp4 container, h264, 5.87MiB
hd_mp4-720p   mp4        1280x720    657k , mp4 container, h264, 8.25MiB
hd_mp4-1080p  mp4        1920x1080  1090k , mp4 container, h264, 13.67MiB
original      mp4        1920x1080  3481k , 43.65MiB (best)
[download] Finished downloading playlist: Business Intelligence (BI): Real-life Examples
[download] Downloading video 5 of 5
[Teachable] 5537270: Downloading webpage
[download] Downloading playlist: Traditional Methods: Real-life Examples
[Teachable] playlist Traditional Methods: Real-life Examples: Collected 1 video ids (downloading 1 of them)
[download] Downloading video 1 of 1
[Wistia] ypx6a0ntig: Downloading JSON metadata
[info] Available formats for ypx6a0ntig:
format code   extension  resolution note
mp4-224p      mp4        400x224     197k , mp4 container, h264, 3.99MiB
iphone-360p   mp4        640x360     338k , mp4 container, h264, 6.85MiB
md_mp4-540p   mp4        960x540     381k , mp4 container, h264, 7.73MiB
hd_mp4-720p   mp4        1280x720    533k , mp4 container, h264, 10.81MiB
hd_mp4-1080p  mp4        1920x1080   865k , mp4 container, h264, 17.52MiB
original      mp4        1920x1080  2124k , 43.02MiB (best)
[download] Finished downloading playlist: Traditional Methods: Real-life Examples
[download] Finished downloading playlist: Intro to Data and Data Science

Description

Teachable extractor extract only videos which have "fa fa-youtube-play" icon.. other videos which have "fa fa-lightbulb-o" icon aren't be extracted

You must provide account credentials.

@dst

You must provide account credentials.

I sent credentials to your gmail


public api DTLS_VERSION_LT

Please provide us an alternative for this in public api.
DTLS_VERSION_LT

You want to compare DTLS versions?

Yes that is what we want to do.
		if (DTLS_VERSION_LT(nid, DTLS1_2_VERSION) && level >= 4)
			return 0;

I've marked this as a feature request for post 1.1.0. This isn't currently available in 1.0.2 (although there is an internal macro that does this in 1.1.0).

I’m not sure that’s  the right thing to do.  It's a feature lost by making things opaque.
I think a better way to do this is to have constants for each version, and an API to get the version, like we do with TLS.

Shifting to post 1.1.1

Marking as inactive, to be closed at the end of 3.4 dev barring further input


Add query matching terms in a set

fix the 2nd half of #1494

Codecov Report

Merging #1539 (dac6ddb) into main (d641979) will increase coverage by 0.02%.
The diff coverage is 95.41%.

@@            Coverage Diff             @@
##             main    #1539      +/-   ##
==========================================
+ Coverage   93.92%   93.94%   +0.02%
==========================================
  Files         249      250       +1
  Lines       45903    46197     +294
==========================================
+ Hits        43114    43402     +288
- Misses       2789     2795       +6

Impacted Files
Coverage Δ

src/query/mod.rs
100.00% <ø> (ø)

src/query/set_query.rs
95.41% <95.41%> (ø)

src/indexer/delete_queue.rs
94.76% <0.00%> (-3.46%)
:arrow_down:

src/directory/mmap_directory.rs
90.37% <0.00%> (-0.71%)
:arrow_down:

common/src/serialize.rs
85.89% <0.00%> (-0.09%)
:arrow_down:

common/src/bitset.rs
98.48% <0.00%> (-0.02%)
:arrow_down:

src/indexer/operation.rs
0.00% <0.00%> (ø)

fastfield_codecs/src/monotonic_mapping.rs
100.00% <0.00%> (ø)

fastfield_codecs/src/line.rs
99.18% <0.00%> (+0.04%)
:arrow_up:

src/indexer/index_writer.rs
97.17% <0.00%> (+0.17%)
:arrow_up:

... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Should I depreciate BooleanQuery::new_multiterms_query? It does the same thing, but is probably slower as soon as there is more than one term per field being searched


documentation razor to string

[EDIT by guardrex to fix the code block ... @hoksource, use triple-backticks]
I need to render razor with model data to a string for sending html emails.
This is for web api and console application/scheduled tasks
I need to use the razor view engine for or some sort of an html engine for .razor or .cshtml to generate an html string given an input model simple data class like
public class Person
{
    public string FirstName { get; set; }
    public string LastName { get; set; }
}

to

    @Model.FirstName

    @Model.LastName

it is kinda messy to write the html from concatinating and htmlencoding strings.
Is there a documentation for my use case?

@hoksource Are you looking at a specific topic? We don't provide general programming support. For general questions, we recommend the usual support channels ...

Stack Overflow
ASP.NET Core Slack
ASP.NET Gitter

Took me a while to figure it out. this works for web apis this was taken from the PartialViewExecutor and ViewExecutor sample
https://github.com/dotnet/aspnetcore/blob/09722d1ce59d4a7740451e065256ec62cbdb32a9/src/Mvc/Mvc.ViewFeatures/src/PartialViewResultExecutor.cs
https://github.com/dotnet/aspnetcore/blob/9abf4bfe3f09d0dafc9b7abd8441e6683e9bf612/src/Mvc/Mvc.ViewFeatures/src/ViewExecutor.cs

    public class RazorTextWriterRenderer
    {

        MvcViewOptions _mvcViewOptions;
        ICompositeViewEngine _viewEngine;
        IModelMetadataProvider _modelMetaDataProvider;
        ITempDataDictionaryFactory _tempDataFactory;

        public RazorTextWriterRenderer(
        IOptions<MvcViewOptions> mvcViewOptions,
        ICompositeViewEngine viewEngine,
        IModelMetadataProvider modelMetaDataProvider,
        ITempDataDictionaryFactory tempDataFactory
        )
        {
            _mvcViewOptions = mvcViewOptions.Value;
            _viewEngine = viewEngine;
            _modelMetaDataProvider = modelMetaDataProvider;
            _tempDataFactory = tempDataFactory;
        }

        public async Task RenderPartialAsync<T>(
            ActionContext context,
            string partialName, T model, TextWriter writer)
        {

            var viewResult = _viewEngine.GetView(null, partialName, false);

            viewResult.EnsureSuccessful(null);
            var view = viewResult.View;

            var viewData = new ViewDataDictionary<T>(_modelMetaDataProvider, context.ModelState)
            {
                Model = model
            };
            var vc = new ViewContext(context, view, viewData,
            _tempDataFactory.GetTempData(context.HttpContext),
            writer,
            _mvcViewOptions.HtmlHelperOptions);

            using (view as IDisposable)
            {
                await view.RenderAsync(vc);
            }

        }

    }


[libmagic] Add new port

This library can be used to classify files according to magic number tests.
libmagic currently doesn't support Windows platform.
Related issue #7895
The latest version 5.37 in ftp://ftp.astron.com/pub/file/ cannot be reached, so I get the source from here https://github.com/threatstack/libmagic.

The threatstack mirror is very old (5 years or so)...  If FTP can't be used, there is a much more up-to-date mirror on github at https://github.com/file/file

@zrax thanks for your info. I have updated.

/azp run

LGTM

/azp run

Please modify ci.baseline.txt to account for the windows failures

/azp run


Dependency screen showing Missing line, probably in error

This is a dashboard that was imported from the Internal Logs content pack.

Saving the dashboard removes the missing item.
Before

After


Bluetooth: Mesh: Transport: Fix calculating SeqAuth

This patch fixes case where Mesh is receiving segmented data with
SEQ and SeqZero as in logs below:
bt_mesh_trans_recv: src 0x07FF dst 0x0001 seq 0x00031FFF friend_match 0
bt_mesh_trans_recv: Payload dd7ffc016e5c7f861272e5f7577a6644
trans_seg: ASZMIC 0 AKF 1 AID 0x1D
trans_seg: SeqZero 0x1FFF SegO 0 SegN 1
trans_seg: ######## seq_auth=204799
bt_mesh_trans_recv: src 0x07FF dst 0x0001 seq 0x00032000 friend_match 0
bt_mesh_trans_recv: Payload dd7ffc21abb5a7
trans_seg: ASZMIC 0 AKF 1 AID 0x1D
trans_seg: SeqZero 0x1FFF SegO 1 SegN 1
trans_seg: ######## seq_auth=212991
Original-patch-by: Łukasz Rymanowski<EMAIL_ADDRESS>Signed-off-by: Johan Hedberg<EMAIL_ADDRESS>

This is a port of https://github.com/apache/mynewt-nimble/pull/161 to Zephyr

@rymanluk FYI

Codecov Report

Merging #9477 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9477   +/-   ##
=======================================
  Coverage   52.19%   52.19%
=======================================
  Files         212      212
  Lines       25921    25921
  Branches     5570     5570
=======================================
  Hits        13529    13529
  Misses      10129    10129
  Partials     2263     2263

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 734eda3...df068a5. Read the comment docs.


Getting trainer.generate() to generate output using the reference model

Often in the PPO process we need to use the relative difference of rewards from the output of the model and the reference model. Would it be possible to allow the trainer.generate() method to specify which of the two models we want to see output from?

this sounds like a good idea cc @lvwerra
However you can call generate directly with trainer.ref_model.generate() I think,

Sounds good. Although i think the generate() function has a bunch of extra logic before and after calling the generate() on the actual model itself. Would probably have to duplicate those code in my training script to ensure consistency.
Another thing is, i'm currently using the peft disable_adapter() approach for the reference model, so i think i would actually need to manually do that instead of using the ref_model field directly?


Overshoot during navigation

There appears to be some less than ideal travel when using waypoints with at least the emulated drone. The picture below shows the flight path the drone took when making a 10 m x 10 m box. During the travel to the first waypoint, the drone overshot the waypoint by approximately 7 m before turning around to overshoot the waypoint again. I got the same results with both the NED and Global/Rel. Alt reference frames.

Has anyone else had any problems like this?

Never had this issue. Can you test in DIRECT_TO mode instead of DUBIN ?

It did the same thing in DIRECT_TO as well as DUBIN.

Here's something interesting I found that seems to be related somehow to the overshoot. The closer waypoint 0 is to the take-off location, the further the drone overshoots. I did some tests where I kept all of the waypoints the same except for waypoint 0, which I moved around.

These pictures show that as I move waypoint 0 forward, the drone overshoots waypoint 1 less.

I also tested this by moving the waypoint south and west as well. The pattern was the same, so it is not that waypoint 0 was closer to waypoint 1.

The picture that I showed in the original post contradicts this as there was overshoot moving to waypoint 0 instead (which is located 10 meters from the take-off location). However, that test had the altitude at 2 m instead of 10 m (The take-off altitude is set to 2 for all tests). So I tried a similar layout with global frame waypoints flying at 2 m and 10 m.

The one flying at 2 m experienced overshoot whereas the one flying at 10 m did not. This implies that there is also an altitude effect on the issue as well

I tried another test where I put 2 consecutive waypoints on top of each other, but that did not cause any overshoot so it seems to be only near the starting waypoints:


[ALLUXIO-2471] [branch-1.4] User UGI getShortUserName to get login user

https://alluxio.atlassian.net/browse/ALLUXIO-2471
We should use ugi.getShortUserName to get the user's login name, rather than the full principal name.

@peisun1115

LGTM. thanks for the fix

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12807/Failed Tests: 1org.alluxio:alluxio-tests: 1alluxio.hadoop.FileSystemAclIntegrationTest.loadDirMetadataMode
Test FAILed.

Jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12808/
Test PASSed.

@calvinjia  can you please take another look?

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12811/
Test PASSed.

Merged build finished. Test PASSed.


nixos/dockd: add new service

Motivation for this change
Adds the dockd service for nixos and all the dependencies, libthinkpad and the daemon itself "dockd".
Dockd is a dock management daemon for the Lenovo Thinkpads, very helpful if you are running minimal wm, like i3. It allows you to configure for example, a set of multiple monitors when you dock you laptop.
https://github.com/libthinkpad/dockd
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg eval

@roberth  I can simplify the expression, but getting back to the idea of adding dockd in nixos, do you think is a good idea to add a project that is maybe rather immature, in terms of the hard-code of paths and maybe the quality of the project. Also, maybe this is not that relevant to a lot of people to put it directly in nixos, I could just add this in some other repo and to be used by those who really want to have this sort of thing going on. :thinking: . Also thanks for the review, you've been very kind and helpful.

Thanks :)
Since we don't have a standard solution for sharing packages outside the nixpkgs repo, I do think nixpkgs may be a good place for this. However, if you feel like trying out NUR and it satisfies your needs, you could go with that. Discoverability of dockd will be worse, so you'll need to do some promotion.

Are there any updates on this pull request, please?

Are there any updates on this pull request, please?

@mmahut I'm no longer using NixOS in the particular thinkpad where dockd was relevant (using it along i3wm).
Also the upstream dockd project it no very well maintained, that's why it kind of discouraged me to keep working on this PR and officially include a package that would turn abandon-ware very quickly.
Still, I can put the work on a additional overlay to be  included by those who don't  really care about anything and just enjoy the pleasures of automatically adjust into the additional monitors when is docked. With enough :clap:s and :tada:s I can make it happen.
@roberth would it be better if I just close this PR? To at least make it -1 in the number of open PRs?

Hey @cyraxjoe,
Kinda sad story :confused:; it looks like you put some of your best effort into the module but it was a bit complicated.
I don't think we have a policy about PR closing yet, so I'd say it's up to you. If you think you'll spend time on this, leave it open, but by the looks of it you can close it. If you leave the branch on your repo it will still be usable here, even if closed.
I'll mention this on #nixos in case someone wants to pick it up from here.


Implement new models

[ ] mistralai/Mixtral-8x22B-v0.1
[ ] HuggingFaceH4/zephyr-orpo-141b-A35b-v0.1

Fixed in #24


Display list of events

Hello and thanks for sharing this great calendar code.
I was able to add the control into my project, but was wondering if you happen to have any sample code to display List of Events for the selected day as shown in this image.  Any assistance is greatly appreciated.
Kia

Sorry, it's a specific code that I used for a client project, I can't give it to you.


fix: point gradle to correct project dependencies

Hi Adrian,
Could you take a look at these commits to fix up the project? I also added some detail to the README, and fixed an NPE in the GetQuoteCommand (plus added some logging so users can see the outcome of the quote)

Hi Adrian,
I've updated the branch based on changes in master, can i merge?


textsize is deprecated in Pillow 10

Textsize is deprecated in Pillow 10, according to:
https://pillow.readthedocs.io/en/stable/deprecations.html#font-size-and-offset-methods
Resulting in the following error in the Netbox version below:
<class 'AttributeError'>
'ImageDraw' object has no attribute 'textsize'
Python version: 3.10.6
NetBox version: 3.5.5
The textsize function is used in the utilities.py file, line 43.
The (temporary) solution was to downgrade do Pillow 9.5.0.

Smae problème my side.

same problem here
does anyone know a fix?

For netbox-docker you can set:
pillow==9.5.0

In the plugin_requirements.txt and then docker compose build and docker compose up -d

I think in the file /utilities.py you may replace line 43         w, h = draw.textsize(text, font=fnt) with         w, h = draw.textlength(text, font=fnt)
Releasenotes from Pillow: https://pillow.readthedocs.io/en/stable/releasenotes/10.0.0.html chapter "Font size and offset methods"

just quick fix for that #53

fixed


[Question] Periodic performance degradation

I am benchmarking bulk API to inserts bunch of documents against CouchDB cluster.
I am batching 500 documents into one request and my setup is comprised of 3 CouchDB nodes.
I am facing periodic performance degradation.
I think this is because CouchDB should periodically synchronize its pending changes.
I could observe many pending_changes logs.
[warning] 2017-12-13T07:22:48.173767Z<EMAIL_ADDRESS><0.294.0> -------- mem3_sync shards/a0000000-bfffffff/lambda-bmt_activations.1513147731<EMAIL_ADDRESS>{pending_changes,54247}

I already looked into this guide, but it did not help me
http://docs.couchdb.org/en/2.1.1/maintenance/performance.html#disk-and-file-system-performance
Once performance is dropped, it took about 30s ~ 60s to get back to the stable state.

Is there any way to alleviate this problem?

Hi @style95, CouchDB is configured to ~continuously cross-check the replicas of each database shard for consistency. The warning messages you observed are emitted when one of the replicas falls behind in its cross-checks, which can definitely be a side-effect of maxing out the incoming write load on the cluster. The cross-checks are not scheduled at any particular interval; rather, they are queued up whenever writes are committed.
I'm not sure those warning messages are directly related to your observed throughput degradation though. Performance degradation that recovers on its own while the load is still applied is an interesting case. Do you have automatic compactions configured or anything like that? I think we may need a fair bit more detail to offer much constructive advice here.

@kocolosk Thanks
I have this configuration.
[compaction_daemon]
check_interval = 300
min_file_size = 131072

[compactions]
_default = [{db_fragmentation, "70%"}, {view_fragmentation, "60%"}]

I think, to minimize the impact of cross-check, it might be better to reduce the check interval.
Then side effects might be distributed across time.
Could I just reduce that check_interval value to get what I described above?

OK, it may be the case that the server is triggering compactions and the competition for resources is what is slowing you down in those intervals. When the compaction finishes your throughput is restored. You can determine if this is the case by checking the Active Tasks in the dashboard (or use the _active_tasks endpoint).
Changing the check_interval might defer things a bit, but you'd still have the possibility of a compaction running during your benchmark. There are many other settings you can apply to tune the compactor's resource utilization:
http://docs.couchdb.org/en/2.1.1/config/compaction.html
You could also disable compaction during the test, but note that compaction does need to run periodically even if your database never updates individual documents.
Note that compaction is a separate process from the one generating the pending_changes messages. I think those are less likely to be related to the changes in throughput personally.
I'm going to go ahead and close this issue for now but by all means re-open if you have further questions :)

@kocolosk Thank you for the answer. But I am still curious.
AFAIK, compaction is the progress of deleting old revisions.
In my benchmark, I always insert new documents with bulk insertion.
In this case, there could be compaction which affects performance such tremendously?
Is there any interval to synchronize(internally and across node) bunch of bulk-inserted documents?

A very fair question.
It turns out that compaction cleans up more than just old document revisions. Any time a document is written CouchDB needs to update a pair of Btree indexes that help to quickly locate the document on disk. Like everything else in CouchDB, these indexes are maintained in a purely copy-on-write fashion. This means that the database file accumulates a lot of old Btree nodes, even when the database is only seeing new inserts.  Eventually the volume of old Btree nodes alone is enough to trip the db_fragmentation threshold.

Very clear.
Thank you very much @kocolosk : )


KAFKA-4996: Fix findbugs multithreaded correctness warnings for streams

Ping @dguy @guozhangwang for review.

The build failures are unrelated to this PR

retest this please

@dguy Thanks for the review. I have made the required change. Kindly check.


RoutablePageMixin doesn't work if included after Page

When defining a Page subclass then RoutablePageMixin works only if it's included before Page:
So this works:
class EventPage(RoutablePageMixin, Page):
but this one yields a 404:
class EventPage(Page, RoutablePageMixin):

That's because RoutablePageMixin's serve method needs to override the default one provided by Page. Is this a problem?

Well, I've just realised that this is how MRO works in python, so there's technically nothing wrong with it but it's easy to miss (e.g. it's in the wrong order in the example on #764 too). Could we perhaps call RoutablePageMixin.serve from Page.serve if it's a RoutablePageMixin class?

I'm absolutely against giving RoutablePage any special-case treatment in wagtailcore, as per the reasoning in https://github.com/torchbox/wagtail/issues/1012#issuecomment-75143188. If this is catching people out regularly, then we could add a note to the docs to point out that the order is significant, or perhaps add a system check on startup that outputs a warning if they're in the wrong order.


Make ooth messages customizable (and internationalizable)

Most Ooth and ooth plugin messages are currently hardcoded, move them i18n/en.json and make them configurable.

Also it would be nice to get an error code as well as the text message. This will ease implementing specific behaviors depending on the error.

This is done. @ela34 I opened a new ticket for your request: https://github.com/nmaro/ooth/issues/61


pip install from repository/directory fails

A fresh install from the repository (pip install<EMAIL_ADDRESS>or from a local checkout (pip install .) fails:
Collecting<EMAIL_ADDRESS>  Cloning https://github.com/scottkosty/vit.git (to revision 2.x) to /tmp/pip-req-build-_32miw36
Branch '2.x' set up to track remote branch '2.x' from 'origin'.
Switched to a new branch '2.x'
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-req-build-_32miw36/setup.py", line 4, in <module>
        from vit import version
      File "/tmp/pip-req-build-_32miw36/vit/__init__.py", line 2, in <module>
        from .application import Application
      File "/tmp/pip-req-build-_32miw36/vit/application.py", line 14, in <module>
        import urwid
    ModuleNotFoundError: No module named 'urwid'

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-req-build-_32miw36/

vit: 5b71e2e1c4f050b540b22867e1210c71e1964ac6
Python: 3.7.3 (via pyenv)

I can reproduce this error, but must admit I'm stumped as to why.
urwid is listed as a dependency in requirements.txt, and I specifically read that file in and pass it to install_requires in setup.py: https://github.com/scottkosty/vit/blob/2.x/setup.py#L6-L18
That's the suggested approach from this SO post: https://stackoverflow.com/questions/36963563/pip-wont-install-my-packages-dependencies
So any ideas welcome.
For the local checkout via pip install ., running pip install -r requirements.txt first is an easy workaround
The instructions at DEVELOPMENT.md also work.

A wild guess: the issue is with https://github.com/scottkosty/vit/blob/2.x/setup.py#L4 as it executes vit/__init__.py and there, vit.application.Application is imported. The file vit/application.py contains the import urwid line.

Ah yes, I think you're right about that. I was trying to be clever about centralizing the version info. Looks like I'll need to parse that file manually instead of importing it.

Should be fixed by https://github.com/scottkosty/vit/commit/b6966ce09f58e4fb06ebce8fdc6e4caeeb1387f0
Can you verify?

Successfully installed a fresh venv via:
pip install git+https://github.com/scottkosty/vit@b6966ce09f58e4fb06ebce8fdc6e4caeeb1387f0


Post process effect regression in 1.39.0

Could be related to #2848.
The outline layer is very first one in the layers composition. It works correctly with build 1.38.4, but starts "lagging" behind the model with 1.39.0 (similar to my old issue #2519). Changing the layer order doesn't seem to change anything.
Please, let me know if a repro is needed.

a repro would be useful. I'm investigating some issues with post-effects at the moment.
Thanks!

Here is the repro:
https://playcanvas.com/project/764016/overview/post-process-issue
As a side note: in the repro, I could not set the outline layer as the very first one in the layers composition- the app throws. This doesn't happen in the production project, though. Not sure, perhaps the shadows were calculated by then. I moved it after World layer in the repro.

I was testing this yesterday in my fork, and still had some issues .. but right now with this PR it seems to work correctly
https://github.com/playcanvas/engine/pull/2882
I was changing priorities of camera and maybe few other little bits, not entirely sure.
The engine release with the PR should be out in the next few days .. fingers crossed this is a good solution.

@mvaligursky My results:

1.38.4 - no lag (https://launch.playcanvas.com/1088894?use_local_engine=https://code.playcanvas.com/playcanvas-1.38.4.js)
1.39.0 - lag (https://launch.playcanvas.com/1088894?use_local_engine=https://code.playcanvas.com/playcanvas-1.39.0.js)
1.39.3 - lag (https://launch.playcanvas.com/1088894?use_local_engine=https://code.playcanvas.com/playcanvas-1.39.3.js)

So yes, it still seems to be a problem with the latest engine.

It needs changes to camera priority now .. try this
https://launch.playcanvas.com/1093398?debug=true
the project: https://playcanvas.com/project/766088/overview/post-process-issue--lex

Thank you for looking into this, @mvaligursky!
So, from the looks of it, the only thing changed in your project was the Camera priority from 0 to 1, making it lower in priority than the Outline Camera. However, when I changed that priority in my sample project, I get the following error:

It is as if I set the Outline layer the very first one in the layers composition. Same throw. Do I need to change something else?

This is the long standing issue in the engine I still need to untangle, related to directional shadow map being used in the camera / layer before the world or something along these lines (not entirely sure on the conditions). I might have to either disable the light from the first camera / layer or change type to non-directional, experiment with that please.

Right, changing the light to Spot or Point mitigated the error with the shadow map.

related issue (there are more I think)
https://github.com/playcanvas/engine/issues/2518
I'll close this, but please reopen if anything else is needed on this.


openapi generator is failing

using this definition
openApiSpec=https://raw.githubusercontent.com/InterNetX/internetx-swagger-files/master/src/domainrobot.json
and openapi generator via maven
            <!-- https://mvnrepository.com/artifact/org.openapitools/openapi-generator-maven-plugin -->
            <plugin>
               <groupId>org.openapitools</groupId>
               <artifactId>openapi-generator-maven-plugin</artifactId>
               <version>7.0.0</version>
               <executions>
                  <execution>
                     <goals>
                        <goal>generate</goal>
                     </goals>
                     <configuration>
                        <inputSpec>${openApiSpec}</inputSpec>
                        <generatorName>java</generatorName>
                        <library>resttemplate</library>
                        <apiPackage>${openApiPackage}</apiPackage>
                        <modelPackage>${openApiModelPackage}</modelPackage>
                        <useSpringBoot3>true</useSpringBoot3>
                        <generateApis>true</generateApis>
                        <generateApiDocumentation>false</generateApiDocumentation>
                        <generateApiTests>true</generateApiTests>
                        <generateModels>true</generateModels>
                        <generateModelDocumentation>true</generateModelDocumentation>
                        <generateModelTests>false</generateModelTests>
                        <generateSupportingFiles>true</generateSupportingFiles>
                        <legacyDiscriminatorBehavior>false</legacyDiscriminatorBehavior>
                        <configOptions>
                           <delegatePattern>true</delegatePattern>
<EMAIL_ADDRESS>                        </configOptions>
                     </configuration>
                  </execution>
               </executions>
            </plugin>

results into
domainrobot.json [0:0]: unexpected error in Open-API generation
org.openapitools.codegen.SpecValidationException: There were issues with the specification. The option can be disabled via validateSpec (Maven/Gradle) or --skip-validate-spec (CLI).
 | Error count: 8, Warning count: 2
Errors:
	-attribute paths.'/bulk/clientAccount/{label}/clientCustomer'. Declared path parameter label needs to be defined as a path parameter in path or operation level
	-attribute paths.'/bulk/zone/_domainSafe'(put).operationId is repeated
	-attribute paths.'/bulk/zone/_domainSafe'(delete).operationId is repeated
	-attribute paths.'/bulk/domain/_domainSafe'(delete).operationId is repeated
	-attribute paths.'/zone/{name}/{systemNameServer}/zoneQuery/_search'. Declared path parameter name needs to be defined as a path parameter in path or operation level
	-attribute paths.'/zone/{name}/{systemNameServer}/zoneQuery/_search'. Declared path parameter systemNameServer needs to be defined as a path parameter in path or operation level
	-attribute paths.'/bulk/domain/_domainSafe'(put).operationId is repeated
	-attribute paths.'/object/_assignment'(put).operationId is repeated
Warnings:
	-attribute paths.'/bulk/clientAccount/{label}/clientCustomer'. Declared path parameter label needs to be defined as a path parameter in path or operation level
	-attribute paths.'/bulk/zone/_domainSafe'(put).operationId is repeated
	-attribute paths.'/bulk/zone/_domainSafe'(delete).operationId is repeated
	-attribute paths.'/bulk/domain/_domainSafe'(delete).operationId is repeated
	-attribute paths.'/zone/{name}/{systemNameServer}/zoneQuery/_search'. Declared path parameter name needs to be defined as a path parameter in path or operation level
	-attribute paths.'/zone/{name}/{systemNameServer}/zoneQuery/_search'. Declared path parameter systemNameServer needs to be defined as a path parameter in path or operation level
	-attribute paths.'/bulk/domain/_domainSafe'(put).operationId is repeated
	-attribute paths.'/object/_assignment'(put).operationId is repeated

using
<skipValidateSpec>true</skipValidateSpec>
it is generating but still leaving the feeling that api client will sooner or later fail on the above named issues.
Can someone clarify or even fix the openapi definition?

@dpalic
Thank you for the issue! I raised an issue internally and we will try to fix this. This will take a while, but will leave this issue open until the problem is solved. I keep you updated.

Is there any timeframe in this regard? The OpenAPI spec doesn't validate as is. We're not using openapitools / java but posted here since my issue (generating for golang) is closely related. Thanks.


Force basename when location doesn't include it

This treats basename as the minimally viable pathname. Combined with a change to redux-simple-router to replace history with the initial location, this will allow for / -> /base/, /foo -> /base/foo/, /base -> /base/, /base/foo -> /base/foo/. As it is now, it's possible for a redux app to run at both / and /base, contrary to expectations.

Post-https://github.com/rackt/redux-simple-router/pull/141 RSR no longer works that way, so this is no longer relevant.

Post-https://github.com/rackt/redux-simple-router/pull/141 RSR no longer works that way, so this is no longer relevant.

But I'm working off of master of redux-simple-router and the behavior is still that way. Because basename will be '' in when someone enters, say, localhost:3000, and no attempt is made by RSR to replace history with the initial location, the address bar will stay localhost:3000. This is still relevant.

But I'm working off of master of redux-simple-router and the behavior is still that way. Because basename will be '' in when someone enters, say, localhost:3000, and no attempt is made by RSR to replace history with the initial location, the address bar will stay localhost:3000. This is still relevant.

If you like, I can make a repo demonstrating.

If you like, I can make a repo demonstrating.

Huh? That seems extremely odd and overly-specific. You're saying that, given an app with a basename of /foo, you want to redirect users from / to /foo?

Huh? That seems extremely odd and overly-specific. You're saying that, given an app with a basename of /foo, you want to redirect users from / to /foo?

That's just not right. If your basename is set to foo, then / does not map to:
{
  pathname: '/',
  basename: '/foo'
}

"When the app inits" is not a meaningful concept here – if somehow you're handling things above the basename, that's outside the concern of the router or of the basename-configured history.
But in no case should it just lie to you.

That's just not right. If your basename is set to foo, then / does not map to:
{
  pathname: '/',
  basename: '/foo'
}

"When the app inits" is not a meaningful concept here – if somehow you're handling things above the basename, that's outside the concern of the router or of the basename-configured history.
But in no case should it just lie to you.

Yes. That's exactly how, say, rootURL works in Ember. It seems highly odd to me for an app to work at two different states of the address bar. It should represent the minimally viable mount point for the app, and paths that are "deficient" should be corrected. Right now it works as nothing more than a way for the develop to say "*if the path includes basename, ignore basename" but it's much more natural to think of it as "if path doesn't include basename, make sure it does".

Yes. That's exactly how, say, rootURL works in Ember. It seems highly odd to me for an app to work at two different states of the address bar. It should represent the minimally viable mount point for the app, and paths that are "deficient" should be corrected. Right now it works as nothing more than a way for the develop to say "*if the path includes basename, ignore basename" but it's much more natural to think of it as "if path doesn't include basename, make sure it does".

That's just not right. If your basename is set to foo, then / does not map to

I didn't say it did. I said the app boots just fine, which is highly odd to me and contrary to how routers work in other frameworks with similar root or base url settings.

That's just not right. If your basename is set to foo, then / does not map to

I didn't say it did. I said the app boots just fine, which is highly odd to me and contrary to how routers work in other frameworks with similar root or base url settings.

if somehow you're handling things above the basename, that's outside the concern of the router or of the basename-configured history.

If they are, they shouldn't be mounting the app yet, but the app is mounted. And if it is, it should utilize basename.

if somehow you're handling things above the basename, that's outside the concern of the router or of the basename-configured history.

If they are, they shouldn't be mounting the app yet, but the app is mounted. And if it is, it should utilize basename.

I suppose we could throw an exception there. I don't know that this is better than the current behavior. In no event should we report a location that's inconsistent with the URL, though.
But why are you even bothering to set a basename if your app is handling /?

I suppose we could throw an exception there. I don't know that this is better than the current behavior. In no event should we report a location that's inconsistent with the URL, though.
But why are you even bothering to set a basename if your app is handling /?

Fair point about that not being inconsistent. It's handling because that's the out of the box behavior, which I was hoping to change by making the basename setting more of a way of declaring where an app should redirect to if something else is attempted (again similar to what other framework routers such as Ember's do). But, you're right that that's not history's job.

Fair point about that not being inconsistent. It's handling because that's the out of the box behavior, which I was hoping to change by making the basename setting more of a way of declaring where an app should redirect to if something else is attempted (again similar to what other framework routers such as Ember's do). But, you're right that that's not history's job.

Yeah just redirecting to the basename is the right way to handle this if it comes up, though it's a bit of an odd scenario anyway.

Yeah just redirecting to the basename is the right way to handle this if it comes up, though it's a bit of an odd scenario anyway.

In any case, thanks for taking the time to walk me through your thinking.

In any case, thanks for taking the time to walk me through your thinking.

No problem.

No problem.

I think I'm having this issue. My basename is about:mytool and I want pages to be about:mytool?page/1, about:mytool?page/2, etc. (new URL('about:mytool')).host shows that there is no basename. @taion how did you handle this?
In another instance when I am running locally, my basepath should be file:///C:/Users/Mercurius/Documents/GitHub/Non-JSX-React-Router-Redux-Demo/app.html but router is making links go to file:///?page1


Test Plan

Testing your Subscriber
Discovery

[x] GET or HEAD, finding the Link header with rel=hub and rel=self
[ ] GET and look in XML contents
[ ] GET and look in HTML contents
[ ] .host-meta
[ ] Must prioritize Link header over HTML link tag

Subscription

[ ] Request a subscription with callback, mode, topic parameters
[ ] Request a subscription with a secret
[ ] Request a subscription with lease_seconds
[ ] Unsubscribe

Subscription Verification

[ ] Acknowledge a valid pending subscription
[ ] Reject a verification request with an invalid topic URL

Distribution

[ ] Return 2xx when the notification payload is delivered
[ ] Accept a valid signature for authenticated distribution
[ ] Reject an invalid signature
[ ] Reject delivery with no signature if subscription was made with a secret

Testing your Publisher
The spec only describes how the publisher advertise the hub and topic URLs.

[x] Publisher advertises the URLs in HTTP headers
[x] Publisher advertises the URLs in HTML tags
[x] Publisher advertises the URLs in XML tags

These tests are not for compliance, but help publishers test whether their feeds are working properly.

[x] A notification is received when the publisher has updated the content

Testing your Hub
Subscription

[ ] Allows subscription requests with callback, mode and topic parameters
[ ] Allows subscriptions with a secret
[ ] Allows subscribers to request a lease duration
[ ] Ignores a lease duration request
[ ] Must ignore additional parameters
[ ] Must allow subscribers to re-request active subscriptions
[ ] Supports unsubscribing

Distribution

[ ] Sends a notification with matching content type
[ ] Sends only a diff in the notification
[ ] Sends a notification with a valid signature

Double check this list matches the exit criteria https://github.com/w3c/pubsub/issues/56


issue when running on ubuntu server

This is an issue you'll have to debug yourself as there's no way I'll be able to replicate this as your version of Python isn't finding a globally defined variable.

This is an issue you'll have to debug yourself as there's no way I'll be able to replicate this as your version of Python isn't finding a globally defined variable. Like literally just look at line 15, you're error is saying that's not there

If i eliminate that simillar error for different lines start to show up

Again, it's something with your setup. The language is not functioning as it should, this isn't an error in the code within this repo. There is no way for me to give input beyond this.


cypress/included:3.8.2

@Bkucera what do you think if I update this image a little bit and we start doing what I have described in https://github.com/cypress-io/cypress-docker-images/tree/master/examples/included-as-non-root-alternative
This way users right away will be able to run Cypress Docker image as non-root user


Pull in #495 from cel-go: Add join to strings ext library

https://github.com/google/cel-go/pull/495

Fixed via #140