Exception not being caught in 0.3.3

We have a inheritance tree of exceptions are subs of Exception.  Using 0.3.2, our tests are caught and returned as JSON.  With 0.3.3 the exception bubble up to the test runner causing a failure.  Here are examples of our Exceptions:
class ApiException(Exception):
    def __init__(self, code, message):
        self.code = code
        if message is not None:
            self.data = {
                'status': code,
                'message': message
            }

class BadAuth(ApiException):
    def __init__(self,  message):
        self.code = 403
        if message is not None:
            self.data = {
                'status': self.code,
                'message': message
            }

Hey, I may be wrong, but why can't you do this instead:
class BadAuth(ApiException):
def init(self,  message):
self.code = 403
super(ApiException, self).init(self.code, message)

@iamsteveholmes can you provide an example failing test case that demonstrates this?

@ueg1990 looks right.

@joshfriend our app is a bit nested for that and these are functional tests.  But let me see if I can come up with a simplified example.

Here is an example

Here's a script that works as expected with 0.3.2, but the exception bubbles all the way up on 0.3.3
from flask import Flask
from flask_restful import Resource, Api

app = Flask(__name__)
api = Api(app)

class ApiError(Exception):
    def __init__(self, code, message = None):
        self.code = code
        if message is not None:
            self.data = {
                'status': code,
                'message': message
            }

class HelloWorld(Resource):
    def get(self):
        raise ApiError(404,'not found!')

api.add_resource(HelloWorld, '/')

if __name__ == '__main__':
    #app.run(debug=True)
    app.config['TESTING'] = True
    client = app.test_client()
    resp = client.get('/')
    print dict(data=resp.data, status=resp.status_code)

Looks like the cause is the change from 0.3.2 and 0.3.3 in handle_error:
Relevant change:
# in 0.3.2
if not hasattr(e, 'code') and current_app.propagate_exceptions:

# 0.3.3
if not isinstance(e, HTTPException) and current_app.propagate_exceptions

See #445, #111

Sublassing werkzeug.exceptions.HTTPException did the trick!  A real server no longer blows up the same way, and it works with app.testing = True.  Thanks so much for the explanation

Closing since the change introduced by #342 was intended to work this way and it seems like everyone has found that subclassing HTTPException works perfectly well.

Docs should probably be updated to note that the error class needs to subclass HTTPException http://flask-restful.readthedocs.io/en/0.3.5/extending.html#define-custom-error-messages


feat: Support proxy config and env vars for HTTP, TCP and TLS Probers

close #193
Code changes:

Add the proxy configuration to support socks5 proxy for TLS and TCP probes.
Support the $ALL_PROXY environment variable for TLS and TCP probes.
Support the $HTTP_PROXY and $HTTPS_PROXY environment variable for HTTP probe

Codecov Report

Merging #194 (b0c96e4) into main (62ea263) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
+ Coverage   93.92%   94.09%   +0.16%
==========================================
  Files          46       44       -2
  Lines        3655     3655
==========================================
+ Hits         3433     3439       +6
+ Misses        155      151       -4
+ Partials       67       65       -2

Impacted Files
Coverage Δ

probe/http/http.go
97.80% <ø> (ø)

probe/base/base.go
100.00% <100.00%> (ø)

probe/tcp/tcp.go
100.00% <100.00%> (ø)

probe/tls/tls.go
100.00% <100.00%> (ø)

daemon/daemon_unix.go

daemon/daemon_windows.go

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

I couldnt get the socks5 to work with environment variables, but i am not sure i tested right. every format combination i tried with ALL_PROXY had no effect. HTTP_PROXY and HTTPS_PROXY work as expected each affects only their corresponding protocol.

By using the following command, you can create a SOCKS5 proxy. then you can set ALL_PROXY=socks5://<IP_ADDRESS>:1080
ssh -D 1080 -qCN<EMAIL_ADDRESS>
Besides, you can set a wrong socks5 server, such as ALL_PROXY=socks5://<IP_ADDRESS>:1024, and you can see the error message dial tcp <IP_ADDRESS>:1024: connect: connection refused for TCP or TLS probe.


Unexpected behavior for check_items (with respect to the doc)

In the doc, it is said :

Before calling this method, the use of check_items() is encouraged, in order to confirm that the item to be created contains only valid fields.

and then an example is provided
template = zot.item_template('book')
template['creators'][0]['firstName'] = 'Monty'
template['creators'][0]['lastName'] = 'Cantsin'
template['title'] = 'Maris Kundzins: A Life'
resp = zot.create_items([template])

If we modify this example to follow the recommendation of using check_items() as follow
template = zot.item_template('book')
template['creators'][0]['firstName'] = 'Monty'
template['creators'][0]['lastName'] = 'Cantsin'
template['title'] = 'Maris Kundzins: A Life'
zot.check_items([template])
resp = zot.create_items([template])

it crashes with
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/oreilly/.local/lib/python3.4/site-packages/pyzotero/zotero.py", line 806, in check_items
    to_check = set(i for i in list(item['data'].keys()))
KeyError: 'data'

It is not obvious how to use check_items() in conjunction with item_template() since these templates miss a bunch of fields that seems to be expected (fields that are there when used it in conjunction with items() for example).

This should be fixed, and is on PyPI as 1.2.4
With regard to the additional top-level fields (u'links', u'library', u'version', u'meta', u'key',]) you see when you retrieve an item using e.g. items(), that's additional metadata that isn't required in order to create items, and Pyzotero checks for these keys and removes them prior to uploading, so you can round-trip retrieved items that you've modified.


Page Render Issue in Ckeditor scayt plugin used for spell checker

I have used ckscayt with ckeditor for spell checker. Its rendering the page whenever ckeditor initialize in the page. I am using ckeditor version 4.7.0 and angular version 1.6.0. Can we stopped it?


multiple URLs on command-line: stops at first private youtube URL

(note I've obfuscated the username and URLs below as they are not to be publicised)
Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.01.28. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[X] I've verified and I assure that I'm running youtube-dl 2017.01.28

Before submitting an issue make sure you have:

[X] At least skimmed through README and most notably FAQ and BUGS sections
[X] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[X] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add -v flag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
$ youtube-dl -v --username<EMAIL_ADDRESS>https://youtu.be/link1 https://youtu.be/link2 https://youtu.be/link3 https://youtu.be/link4
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'--username', u'PRIVATE', u'https://youtu.be/link1', u'https://youtu.be/link2', u'https://youtu.be/link3', u'https://youtu.be/link4']
Type account password and press [Return]:
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.01.28
[debug] Python version 2.7.10 - Darwin-16.3.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 3.2.2, ffprobe 3.2.2
[debug] Proxy map: {}
[youtube] Downloading login page
[youtube] Logging in
[youtube] link1: Downloading webpage
[youtube] link1: Downloading video info webpage
[youtube] link1: Extracting video information
[youtube] link1: Downloading MPD manifest
[youtube] link1: Downloading MPD manifest
[download] The Composer Animatie Deel 5-link1.mp4 has already been downloaded and merged
[youtube] link2: Downloading webpage
[youtube] link2: Downloading video info webpage
ERROR: link2: YouTube said: This video is private.
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 694, in extract_info
    ie_result = ie.extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 359, in extract
    return self._real_extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 1379, in _real_extract
    expected=True, video_id=video_id)
ExtractorError: link2: YouTube said: This video is private.
<end of log>

Description of your issue, suggested solution and other information
Youtube-dl finished downloading link1, then finds out link2 is private but does not continue with the rest of the links.
I expected youtube-dl to continue trying to download with link3 and further so it can show which of the links were OK and which ones were private.
This saves running youtube-dl multiple times with different URLs each requiring entering the password manually.
I can share affected URLs privately if needed to solve the issue.

This is expected behavior. Use -i.


@conda-forge-admin please rerender

Additional comment:
See https://github.com/conda-forge/bipedal-locomotion-framework-feedstock/pull/21#issuecomment-1459969318 .

I did manually in https://github.com/conda-forge/librobometry-feedstock/pull/7 .


TsGreedy

Let's create TsGreedy to wrap RqGreedy

@rultor release, tag is 0.9.9

@rultor release, tag is 0.9.9

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.9.9

@yegor256 Done! FYI, the full log is here (took me 20min)


Stand alone image files are no longer added to R.files in v5.0

R.generated.swift would contain both R.file and R.image references to "stand alone" (i.e. not in an asset catalogue) using v4.x, with the optimisation in PR #451, specifically commit 4fc7d553 this no longer happens.
The impact is that any API's that take a URL to an image resource rather than a UIImage can't use R.swift.
I've made a quick PR #497 to temporarily patch rswift to restore the previous behaviour.
I'm guessing in the long run it would be better in general to expose a URL attribute on the R.image entries.

Hi Craig! Thanks for using R.swift and taking the time to report this issue and even submit a PR to fix it. Very helpful that you also have referenced the exact commit breaking this behavior.
This is an unintended breaking change that should not have happend, I think your PR is a good workaround that we can use. I will merge and release this asap.
After that I think we should remove the assumption from this code that if a resource matches a certain type it cannot also be of another type. I think this can cause more bugs in the future and the performance gain will probably be minimal in most cases.

So, R.swift 5.0.3 with the fix is released for some some days now. I would like to keep this issue open as a reminder that we need to refactor the if/else tree that caused this issue.
For reference that if/else tree can be found here: https://github.com/mac-cain13/R.swift/commit/4fc7d5536d8d69db6d940c3bd3c2f51a947aa1a7#diff-ea7e2f5adb89f7fbf2fb90c1a2586281R39

I'm afraid this is still an issue. Fonts are files are not parsed in my project, although on version 4 it worked corectly


Add 'not a request for a utility type' to the feature issue template

Please do bikeshed the wording, but I think we should probably have a checklist item for this given a non-trivial amount of asks for this which we immediately decline unless it's paired with some other need.

I probably laughed harder at the title of this PR than I want to admit. 😄  It's definitely true, asks for new utility types are right up there with 9998 dupes and bug reports about type narrowing not working for indexed access.
And yeah, there should probably be a contributor FAQ for this kind of thing (assuming there isn't already).  It's like how people aren't supposed to submit typo fixes, it doesn't really seem to be documented except in other issues and maybe the issue template, so the usual recourse is just to dupe to a random rejected issue of the same type, which isn't really an ideal way to communicate policy.


Beautification takes forever to complete with PHPCBF

Description
When running beautify on save with PHPCBF, the file takes a very very long time to beautify.
Expected Results
Technically the same? The beautification process takes at least 20 seconds.
Steps to Reproduce

Write PHP Code in atom.
Save file.
Wait at least 20 seconds to continue.

Debug
Here is a link to the debug.md Gist: https://gist.github.com/jamesaspence/cb81d77bf97fe7f9ac4b36b9af337150#final-options
Checklist

[X] I have tried uninstalling and reinstalling Atom Beautify to ensure it installed properly
[X] Searched for existing Atom Beautify Issues at https://github.com/Glavin001/atom-beautify/issues
so I know this is not a duplicate issue
[X] Generated debugging information and added link for debug.md Gist to this issue

Closing this due to it being a duplicate of https://github.com/Glavin001/atom-beautify/issues/893. Woops!


Remove ObjectPool leak flag from GroupDataProviderImpl::mKeySetIterators

Problem
The ObjectPool leak reported in #12503 ObjectPool leaks in GroupDataProviderImpl is no longer reproducable; possibly fixed by d25a3ef9.
Change overview
Remove the ‘allow leaks’ flag from GroupDataProviderImpl::mKeySetIterators.
Testing
CI.

fast track: trivial change


Fix hierarchy spelling

It is by your spelling vigilance that children may sleep soundly at night. Thank you.


Dockerbuildfile for Maven starves on Ubuntu

When running docker build with the new dockerfiles it starves after the testphase downloading some java-dom "xenia" images.
The Download Rate drops to b/s and I have not seen it finish.
This error does not occur in the pipeline.

Worked on Windows 10 with Docker for Desktop
But i think they are using Docker 19 so that´s maybe the reason

Downloading from apache: https://repository.apache.org/content/repositories/releases/org/apache/maven/doxia/doxia-module-xdoc/1.0/doxia-module-xdoc-1.0.jar
Downloaded from apache: https://repository.apache.org/content/repositories/releases/org/apache/maven/doxia/doxia-module-xdoc/1.0/doxia-module-xdoc-1.0.jar (28 kB at 1.3 kB/s)
Downloading from apache: https://repository.apache.org/content/repositories/releases/org/apache/maven/doxia/doxia-module-xhtml/1.0/doxia-module-xhtml-1.0.jar
Downloaded from apache: https://repository.apache.org/content/repositories/releases/org/apache/maven/doxia/doxia-module-xhtml/1.0/doxia-module-xhtml-1.0.jar (22 kB at 972 B/s)
Downloading from apache: https://repository.apache.org/content/repositories/releases/org/jdom/jdom/1.1/jdom-1.1.jar
Last lines bevore hangup.
This is after the tests

Also appears on Docker 19.0

By Commit 86ecbb2c52787b1a04546156ef43059dfcf90533 it worked on Docker4Windows with Docker Version 19.0.X
This included having /app/target etc. for both worker and pulser.
Maybe the Azure Pipeline added some additional stuff?


Problem with chapter and section headings

I'm having an odd problem with chapter and section headings.  It's odd because it was previously working; I don't think I changed anything, and now it's not working.
Here's the minimum test case that replicates the problem.  I have a notebook that looks like this:
{
 "cells": [
  {
   "cell_type": "markdown",
   "metadata": {},
   "source": [
    "# Chapter Title\n",
    "\n",
    "Some text"
   ]
  },
  {
   "cell_type": "markdown",
   "metadata": {},
   "source": [
    "## Section Title\n",
    "\n",
    "More text\n"
   ]
  }
 ],
 "metadata": {
  "celltoolbar": "Tags",
  "kernelspec": {
   "display_name": "Python 3",
   "language": "python",
   "name": "python3"
  },
  "language_info": {
   "codemirror_mode": {
    "name": "ipython",
    "version": 3
   },
   "file_extension": ".py",
   "mimetype": "text/x-python",
   "name": "python",
   "nbconvert_exporter": "python",
   "pygments_lexer": "ipython3",
   "version": "3.7.9"
  }
 },
 "nbformat": 4,
 "nbformat_minor": 4
}

And then I run fastdoc like this
fastdoc_convert_all --path . --dest_path convert_book

And here's the output
== Chapter Title

Some text

== Section Title

More text

I was expecting the first one to be a chapter heading and the second to be a section heading.
And then I'm extra confused because when I build this on Atlas I get two chapters instead of two sections.
Any idea what's happening?

Solution is to downgrade pandoc to 2.3.1.

Here's the issue in the nbconvert repo:
https://github.com/jupyter/nbconvert/issues/1456

For those using Ubuntu, the following steps worked for me:
# download pandoc v3.2.1 from their github releases
wget https://github.com/jgm/pandoc/releases/download/2.3.1/pandoc-2.3.1-1-amd64.deb
# install pandoc
sudo dpkg -i pandoc-2.3.1-1-amd64.deb

For those using macOS, there is a well written blog here, although I could not make it work with Big Sur 😢

Or conda install pandoc=3.2.1 should work on every platform, as long as you have conda installed.

Or conda install pandoc=3.2.1 should work on every platform, as long as you have conda installed.

There's a typo in the version number here, possibly because I had it permuted in the previous comment - sorry!
For some reason conda install pandoc=2.3.1 does not work for me if I do the following
conda create --name foo python=3.8 -y && conda activate foo
conda install pandoc=2.3.1

Doing a search for the available versions gives
conda search pandoc
Loading channels: done
# Name                       Version           Build  Channel
pandoc                      <IP_ADDRESS>      ha5e8f32_1  pkgs/main
pandoc                         2.2.1      h1a437c5_0  pkgs/main
pandoc                       <IP_ADDRESS>               0  pkgs/main
pandoc                       <IP_ADDRESS>               0  pkgs/main
pandoc                          2.10               0  pkgs/main
pandoc                        2.10.1               0  pkgs/main
pandoc                          2.11      h0dc7051_0  pkgs/main

so presumably the appropriate choice is conda install pandoc=<IP_ADDRESS>.
Environment information
conda info
active environment : foo
    active env location : /Users/lewtun/miniconda3/envs/foo
            shell level : 1
       user config file : /Users/lewtun/.condarc
 populated config files : /Users/lewtun/.condarc
          conda version : 4.9.2
    conda-build version : not installed
         python version : 3.7.6.final.0
       virtual packages : __osx=10.16=0
                          __unix=0=0
                          __archspec=1=x86_64
       base environment : /Users/lewtun/miniconda3  (writable)
           channel URLs : https://repo.anaconda.com/pkgs/main/osx-64
                          https://repo.anaconda.com/pkgs/main/noarch
                          https://repo.anaconda.com/pkgs/r/osx-64
                          https://repo.anaconda.com/pkgs/r/noarch
          package cache : /Users/lewtun/miniconda3/pkgs
                          /Users/lewtun/.conda/pkgs
       envs directories : /Users/lewtun/miniconda3/envs
                          /Users/lewtun/.conda/envs
               platform : osx-64
             user-agent : conda/4.9.2 requests/2.25.1 CPython/3.7.6 Darwin/20.2.0 OSX/10.16
                UID:GID : 501:20
             netrc file : None
           offline mode : False

conda config --show-sources
==> /Users/lewtun/.condarc <==
auto_activate_base: False
ssl_verify: True
channels:
  - defaults


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-main" workflow

SonarQube Quality Gate Result

Result: :white_check_mark: OK
Triggered by @zxkane on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
91.10
< 80

Duplicated lines density
:white_check_mark: OK
0
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
0
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:white_check_mark: OK
0
> 0

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 8/5/2024, 00:16:10 (UTC+0)

SonarQube Code Analytics
Quality Gate passed

Additional information
The following metrics might not affect the Quality Gate status but improving them will improve your project code quality.
Issues
 0 Bugs
 0 Vulnerabilities
 0 Code Smells
Coverage and Duplications
No data Coverage
No data Duplication


Seperate modules using different aws profiles

Hi all
I want to know if there is a way I can switch AWS profiles in flight between my modules...
e.g
s3 Module --> Creates bucket in AWS Account A
(dependant on s3 Module) r53 module --> Crerate Alias in AWS Account B
Is this even possible?
I currently am using TERRAGRUNT_IAM_ROLE=AWS_ARN which points to Account A?
Obviously this fails with Access denied when trying to create the ALIAS in Account B....
Thanks in advance!

One option is to assume different roles in your Terraform code using assume_role in the AWS provider. You then authenticate to some account that has permissions to assume either role and Terraform will do the rest.

I tried adding the following to the terraforms main.yml
assume_role {
role_arn     = "arn:aws:iam::ACCOUNT_NUMBER_B:role/SuperAdmin"
session_name = "ops-profile"
external_id  = "ops-profile"
}
I still had the TERRAGRUNT_IAM_ROLE=AWS_ARN exported which pointed to Account A?
but received...
Error: Error refreshing state: 1 error(s) occurred:

provider.aws: The role "arn:aws:iam::ACCOUNT_NUMBER_B:role/SuperAdmin" cannot be assumed.
There are a number of possible causes of this - the most common are:

The credentials used in order to assume the role are invalid
The credentials do not have appropriate permission to assume the role
The role ARN is not valid

I managed to resolve this the way you stated, I had to allow the correct permission with the assume roles within IAM between the accounts,
works perfectly now, thank you

Can terragrunt use named profiles in the modules backends explicitly? For my use case, I don't want to set environment credentials in advance, I want terragrunt to do it in the same way terraform does.
i.e.
provider "aws" {
  profile = "${var.aws_profile}"
  region  = "${var.region}"

This would be the dream!


az container - Specify private IP to use.

Is your feature request related to a problem? Please describe.
I'm currently using Azure Container Instances with the bring your vNet functionality. Whilst we can specify the subnet, there doesn't seem to be a way to specify the private IP we would like to use.
To get the IP we must run the following command after the container is created
$ az container show --resource-group myResourceGroup --name appcontainer --query ipAddress.ip --output tsv
<IP_ADDRESS>

Describe the solution you'd like
I'd like to be able to specify the IP at the time of creating the container by passing in an additional command line argument for the az container create command.
Describe alternatives you've considered
N/A
Additional context
This is the guide I've been following to create container instances with a custom vNet.
https://docs.microsoft.com/en-us/azure/container-instances/container-instances-vnet

container

@heymega Apologies for the late reply. Thanks for reaching out to us. We will update this thread once we have more details about this. As a workaround to this you can refer this article if you want to configure a single public IP address for outbound and inbound traffic to a container group. Please let us know if you still have a requirement of specifying a private IP address manually ?
@macolso Could you please look into this and let us know if this ask is achievable ?


Upgrade Nutch Conda Package

Nutch 2.x has bindings to elasticsearch and a REST api. These are must-have features.

@brittainhard Could I please be un-assigned from this issue?


MudDataGrid Column ignore Visible = false

Bug type
Component
Component name
MudDataGrid
What happened?
MudDataGrid Column has property Visible defaults to true.
If I change it to false or "false" it is still visible.
Expected behavior
Visible property should hide column in MudDataGrid
Reproduction link
https://try.mudblazor.com/snippet/jVNNj9owEL3nTzCyegiHhktvBES7ZSlVoSuRW1WtTDKi7jp2ZDvLsij_veNgUkBalhwSO35vPt48Pz4uuFCJ4a_a9Ca1FWoDq511WCZLdMk356rku9UqCmeLuvgiPTiZvvCykmiTr9zxZKELlDaaCPUXcweedycFKgd_umUUpUT38JkRBcwpiR2xyVRiSac2yfgTxp_6bBwBPemdlnWp7GF38geyEQscBvcCZTFiy7pco2GQCSeRtrQc3ERciY26FbvkJd6KfdBWOKFvjr3Qkv-vv91Bya3t-Omg0yMdnMg4jqJJTuLDHlpcZcQzdwjzqapLNHwtMQ3JxnCUGkagcAs_hHXdYdwfRiGCdjRDLEA_o6EUCNzuVA4Zt0_wU80VdcaleMXis_8f91vavmvzJAvfcnFqgWSG7t7o0luqJadnNYxjtsU1r8SgQiN0IXLnG2BUmg_cRFHTC9gkt70zu5I8ksomzS1lUcTPh9EZIsMX15o5WdGp74B7OLWtaLK24jm-5-9Dk1W9liKHXNKAjt1eaBAg1hlfwMzouqIJbdANwfpXc4kUdFWOprmODDG9G98PebgYF7gO-Mur8WA0qe12PmDMbMmlZP3fb2T19-V61kLTl4RsLXwVOW9nL4Ixc2dodG9VGiidI0M5mV61i-DB8xn4x6CrjYIPbO8rb-Aj7H2fDRt2sCZ4q_kH
Reproduction steps

Add MudDataGrid
Set Column property Visible to false
Run
...

Relevant log output
No response
Version (bug)
6.0.6
Version (working)
No response
What browsers are you seeing the problem on?
Firefox, Chrome, Microsoft Edge, Safari, Other
On what operating system are you experiencing the issue?
Windows, Linux, Android
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

MudDataGrid is under active development, the finished component and what features or purpose it will have is not determent yet.
Currently it has issues, lacking documentation, sub components and parameters that does not work, or will be removed.
Until then please don't do feature requests for it, nor open issues.


Continuity in reservoir outflows

Reservoir.cpp: incorrectly increases outflow_new when reservoir storage falls below zero. Should replace - with + sign on line 287 to correct.

Modification made and corresponding unit test added. Thanks!


[BUG] pydantic.errors.PydanticImportError: BaseSettings has been moved to the pydantic-settings package

I install obsei[all] in a venv, then run python .\example\facebook_example.py. I get:
10/24/2023 17:18:31 - WARNING - obsei -

By default `pip install obsei` will only install core dependencies.
To install all required dependencies use `pip install obsei[all]`.
Refer https://obsei.com/#install-obsei for more options.

Traceback (most recent call last):
  File "D:\Programming\Topic modelling\obsei\example\facebook_example.py", line 4, in <module>
    from obsei.source.facebook_source import FacebookSource, FacebookSourceConfig
  File "D:\Programming\Topic modelling\obsei\.venv\Lib\site-packages\obsei\source\facebook_source.py", line 5, in <module>
    from pydantic import BaseSettings, Field, PrivateAttr
  File "D:\Programming\Topic modelling\obsei\.venv\Lib\site-packages\pydantic\__init__.py", line 218, in __getattr__
    return _getattr_migration(attr_name)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\Programming\Topic modelling\obsei\.venv\Lib\site-packages\pydantic\_migration.py", line 294, in wrapper
    raise PydanticImportError(
pydantic.errors.PydanticImportError: `BaseSettings` has been moved to the `pydantic-settings` package. See https://docs.pydantic.dev/2.4/migration/#basesettings-has-moved-to-pydantic-settings for more details.

For further information visit https://errors.pydantic.dev/2.4/u/import-error

I then pip install pydantic-settings and change line 5 of both obsei\source\facebook_source.py and .venv\Lib\site-packages\obsei\source\facebook_source.py from
from pydantic import BaseSettings, Field, PrivateAttr

to
from pydantic import Field, PrivateAttr
from pydantic_settings import BaseSettings

and run again. I still get the same error. I don't know what goes wrong or the version of pydantic I need to use.
See also: No module named 'pydantic.v1' even though pip list see it

@ooker777  Thanks for raising this issue. Can you please check with latest release 0.0.15 and confirm. We have moved to Pydantic V2


UPM doesn't build anymore...

There is an issue with SWIG bindings + st7335, you're using mraa_gpio_init but then storing the result in a mraa::Gpio not a mraa_gpio_context. Change comes from ab730038fdb7e8e60be5f45a04b5b2d44131f842 from @andreivasiliu2211.
You really should look into setting up travis so you catch these before merging.

Hi.
There were some issues regarding the previous merge. I have fixed the
compilation issues. They are now, together with the other proposed changes,
in a pull request here [1], waiting to be merged.
Regards,
Andrei
[1] https://github.com/intel-iot-devkit/upm/pull/256
On Fri, Sep 18, 2015 at 3:15 PM, Brendan Le Foll<EMAIL_ADDRESS>wrote:

There is an issue with SWIG bindings + st7335, you're using mraa_gpio_init
but then storing the result in a mraa::Gpio not a mraa_gpio_context. Change
comes from ab73003
https://github.com/intel-iot-devkit/upm/commit/ab730038fdb7e8e60be5f45a04b5b2d44131f842
from @andreivasiliu2211 https://github.com/andreivasiliu2211.
You really should look into setting up travis so you catch these before
merging.
—
Reply to this email directly or view it on GitHub
https://github.com/intel-iot-devkit/upm/issues/259.

PR was merged and the build is back to normal thanks to @andreivasiliu2211 for patching the remaining sensors. Seems like I was linking against stale objects locally when I tested before pushing.
I'm pretty sure travis wouldn't have made any difference here but yes, it would be nice to have it.


Discriminator decorator does not allow documentation of discriminator property in base model in OpenAPI/OpenApi3

Using a typical discriminator pattern:
@discriminator("foo")
model A{
 ...
}

model B extends A {
  @doc("The discriminator property for A types")
  foo: "B"
}

model C extends A {
  @doc("The discriminator property for A types")
  foo: "C"
}

There is no mechanism for adding documentation to the 'foo' property in Model 'A' above.  This is required for OpenAPI emitters and likely some language emitters.
We should fix this, we could use one of the following mechanisms:

Add a second parameter to the @discriminator property allowing documentation for the discriminator field
Take the @doc element from one of the child types extending the base property
Have a boilerplate documentation string  like 'discriminator property for A' in emitters

Per discussion, go with option (3) - add a boilerpate description of the 'foo' property if no documentation is present.


Cannot nest elements unless parent contains at least one child

Problem:

Given a list of top-level nodes, I am not presented with a drop-target for nesting unless the parent already contains at least one child. In the jsbin link below, notice that you can drag-n-drop to nest under Item 1 but not under Items 2-5.

In my own application (this doesn't happen in the jsbin example below) I am able to nest children if I drag-n-drop from below the parent (drag upwards) but if I drag in the opposite direction I am not presented with a drop target for nesting. I am only presented with a drop target for swapping the top-level items.

JSBin/JSFiddle demonstrating the problem:
https://jsbin.com/notiyoheho/1/edit?html,js,output

Look at the code for the nested example on the SortableJS website.
It is about balancing the swapThreshold and the emptyInsertThreshold options to get a smooth nested list experience.

@owen-m1 Any chance you could add a visual demonstration similar to http://sortablejs.github.io/Sortable/#thresholds showing the balance/trade-offs between the two?
Also, I think it might be problematic that one property is specified as a percentage and the other in terms of pixels. I don't see how you could safely fine-tune these values unless they are in the same units. Is there any chance we could modify the property to use the same units, or at the very least let us override the default units so they use the same ones?

@cowwoc It would take a lot of work to make a demo, but it shouldn't be too hard to just fiddle around with the values in code to get a good balance.
I will consider adding pixel units for the swap thresholds though.

@cowwoc This is indeed an issue.
I'm also not able to get this to work by playing with the values.
The nested list example on the SortableJS website should have this feature.
@owen-m1 If it would take a lot of work for you to make this then this is not easy.

I've good results adding those 2 setting on https://jsbin.com/yogohirifo/edit?html,js,output
    invertedSwapThreshold: .2,
    emptyInsertThreshold: .2


Systemd Service Type should be forking

Delphi-Cookbook-Third-Edition/Chapter07/CODE/RECIPE03_daemon_fork/consoled.service
Type should be forking because systemd considers the service started up once the process forks and the parent has exited. PIDFile should be also specified as well so systemd can keep track of the main process.
[1] https://wiki.archlinux.org/index.php/Systemd

Hi, thank you for your note. In the modern systemd the forking is now 100% handled by the systemd environment so there is really no need to do anything in that arena.

Thank you for giving a note. As solution is given closing the issue.


Typo in blob/develop/docs/installation.rst

Under Advanced Installations "git clone<EMAIL_ADDRESS>should be "git clone git@github.com:awslabs/aws-sam-cli.git"

@jmayeux-circle I thought we already fixed this once. Regardless, would you be willing to send a PR with the fix?

Closing as this was addressed.


[VL] Fix ORC related failed UT

Please change this PR to target on the main branch, thanks.

The failed tests nested column: Count(nested sub-field) not push down seem not relevant to ORC. We can disable them in this PR, and I will take a look further.

The failed tests nested column: Count(nested sub-field) not push down seem not relevant to ORC. We can disable them in this PR, and I will take a look further.

disable GlutenOrcV2AggregatePushDownSuite, Velox don’t support ORC v2 yet.

@chenxu14 We have enabled spark 3.4 in Gluten. Can you help to also enable the orc unit test in Spark 3.4? Thanks.

move work to #3805


#98942 Clear Search Pattern Fields

Make clear button a 2-stage button
Clear search fields if text is present, and leave file pattern fields, otherwise clear file pattern fields
Introduce clear method on PatternInputWidget

Edit (Took me longer than it should have to realise what a 2-stage button means...)

This PR fixes #98942

Thanks!
This should additionally at minimum change the hover text of the button to reflect the two stages, and ideally have two separate icons. (@misolori for input re. icons)

I wouldn't create a separate icon for this, we already do this in the Settings & Keyboard Shortcut search input. I'd ensure you update the title properly.
I also think this should be behind a setting as people will be split on a preference. I'd personally want it to clear everything on a single click.

Happy to take a look at both the title, and the setting.
Any preference on what the default behaviour should be for clearing?

@JacksonKearl what are you thinking that the title should be updated to say?

Thanks @roblourens! I'll hold fire for now then.

I don't know that we need to update the title, I think that it already will say "Clear Search Results" when there are no search results and it is just clearing the input box. If we want to be totally specific, I think there would 3 states.

"Clear Search Results" whenever there are search results because we need to be clear that those are going away
"Clear Search Query"
"Clear Extra Query Fields" or something like that

But I don't know that it's necessary, what do you think @JacksonKearl?

I'm convinced, people will probably discover it anyways if they really need it.

Just to be clear, this is the behaviour I see in the Insiders' Build:

The first click clears the search results and the query/replace terms and does not affect the Files to Include/Exclude fields.
The second click clears the Files to Include/Exclude fields.

I like this, it just wasn't clear from the preceding comments that this was how it would turn out.


Year_one name changes

Current behavior
Currently, we use the "year_one" naming convention for many outputs (scalars and time series) that include degradation, making them not a true "year_one" metrics.
We also have some inconsistencies in naming of outputs.
Changes

Name changes shown in table below
Generally, changes are for energy outputs (not costs) that include "year_one", and are changed to annual_ for scalars and to production_to_, thermal_to_ etc. for time series.
Included help text to this end in results page for relevant output keys
Added output: CHP thermal_production_series_mmbtu_per_hour

Note: Year_one cost calculations (and potentially year_one energy outputs for techs including degradation (currently just PV) will be updated in a separate PR (see https://github.com/NREL/REopt.jl/issues/161 for details).

Key
SubKey
Series or Total
Cost or Energy
New Name

AbsorptionChiller
year_one_to_tes_series_ton
Series
Energy
production_to_tes_series_ton

year_one_to_load_series_ton
Series
Energy
production_to_load_series_ton

year_one_thermal_consumption_series_mmbtu_per_hour
Series
Energy
thermal_consumption_series_mmbtu_per_hour

year_one_thermal_consumption_mmbtu
Total
Energy
annual_thermal_consumption_mmbtu

year_one_thermal_production_tonhour
Total
Energy
annual_thermal_production_tonhour

year_one_electric_consumption_series_kw
Series
Energy
electric_consumption_series_kw

year_one_electric_consumption_kwh
Total
Energy
annual_electric_consumption_kwh

Boiler
year_one_fuel_consumption_series_mmbtu_per_hour
Series
Energy
fuel_consumption_series_mmbtu_per_hour

year_one_fuel_consumption_mmbtu
Total
Energy
annual_fuel_consumption_mmbtu

year_one_thermal_production_series_mmbtu_per_hour
Series
Energy
thermal_production_series_mmbtu_per_hour

year_one_thermal_production_mmbtu
Total
Energy
annual_thermal_production_mmbtu

year_one_thermal_to_tes_series_mmbtu_per_hour
Series
Energy
thermal_to_tes_series_mmbtu_per_hour

year_one_thermal_to_steamturbine_series_mmbtu_per_hour
Series
Energy
thermal_to_steamturbine_series_mmbtu_per_hour

year_one_thermal_to_load_series_mmbtu_per_hour
Series
Energy
thermal_to_load_series_mmbtu_per_hour

lifecycle_fuel_cost
Total
Cost
lifecycle_fuel_cost_after_tax

CHP
year_one_fuel_used_mmbtu
Total
Energy
annual_fuel_consumption_mmbtu

year_one_electric_energy_produced_kwh
Total
Energy
annual_electric_production_kwh

year_one_thermal_energy_produced_mmbtu
Total
Energy
annual_thermal_production_mmbtu

year_one_electric_production_series_kw
Series
Energy
electric_production_series_kw

year_one_to_grid_series_kw
Series
Energy
electric_to_grid_series_kw

year_one_to_battery_series_kw
Series
Energy
electric_to_battery_series_kw

year_one_to_load_series_kw
Series
Energy
electric_to_load_series_kw

year_one_thermal_to_tes_series_mmbtu_per_hour
Series
Energy
thermal_to_tes_series_mmbtu_per_hour

year_one_thermal_to_waste_series_mmbtu_per_hour
Series
Energy
thermal_curtailed_series_mmbtu_per_hour

year_one_thermal_to_load_series_mmbtu_per_hour
Series
Energy
thermal_to_load_series_mmbtu_per_hour

year_one_thermal_to_steamturbine_series_mmbtu_per_hour
Series
Energy
thermal_to_steamturbine_series_mmbtu_per_hour

add
Total
Energy
thermal_production_series_mmbtu_per_hour

year_one_chp_fuel_cost_before_tax
Total
Cost
year_one_fuel_cost_before_tax

year_one_chp_standby_cost_before_tax
Total
Cost
year_one_standby_cost_before_tax

lifecycle_chp_fuel_cost_after_tax
Total
Cost
lifecycle_fuel_cost_after_tax

lifecycle_chp_standby_cost_after_tax
Total
Cost
lifecycle_standby_cost_after_tax

ElectricStorage
year_one_soc_series_fraction
Series
Energy
soc_series_fraction

year_one_to_load_series_kw
Series
Energy
storage_to_load_series_kw

ElectricUtility
year_one_energy_supplied_kwh
Total
Energy
annual_energy_supplied_kwh

year_one_to_load_series_kw
Series
Energy
production_to_load_series_kw

year_one_to_battery_series_kw
Series
Energy
production_to_battery_series_kw

year_one_emissions_tonnes_CO2
Total
Energy
annual_emissions_tonnes_CO2

year_one_emissions_tonnes_NOx
Total
Energy
annual_emissions_tonnes_Nox

year_one_emissions_tonnes_SO2
Total
Energy
annual_emissions_tonnes_SO2

year_one_emissions_tonnes_PM25
Total
Energy
annual_emissions_tonnes_PM25

ExistingBoiler
year_one_fuel_consumption_series_mmbtu_per_hour
Series
Energy
fuel_consumption_series_mmbtu_per_hour

year_one_fuel_consumption_mmbtu
Total
Energy
annual_fuel_consumption_mmbtu

year_one_thermal_production_series_mmbtu_per_hour
Series
Energy
thermal_production_series_mmbtu_per_hour

year_one_thermal_production_mmbtu
Total
Energy
annual_thermal_production_mmbtu

year_one_thermal_to_tes_series_mmbtu_per_hour
Series
Energy
thermal_to_tes_series_mmbtu_per_hour

year_one_thermal_to_steamturbine_series_mmbtu_per_hour
Series
Energy
thermal_to_steamturbine_series_mmbtu_per_hour

year_one_thermal_to_load_series_mmbtu_per_hour
Series
Energy
thermal_to_load_series_mmbtu_per_hour

ExistingChiller
year_one_to_tes_series_ton
Series
Energy
production_to_tes_series_ton

year_one_to_load_series_ton
Series
Energy
production_to_load_series_ton

year_one_electric_consumption_series_kw
Series
Energy
electric_consumption_series_kw

year_one_electric_consumption_kwh
Total
Energy
annual_electric_consumption_kwh

year_one_thermal_production_tonhour
Total
Energy
annual_thermal_production_tonhour

Generator
year_one_to_battery_series_kw
Series
Energy
production_to_battery_series_kw

year_one_to_grid_series_kw
Series
Energy
production_to_grid_series_kw

year_one_to_load_series_kw
Series
Energy
production_to_load_series_kw

year_one_energy_produced_kwh
Total
Energy
Keep as-is for now

average_annual_energy_produced_kwh
Total
Energy
annual_energy_produced_kwh

average_annual_fuel_used_gal
Total
Energy
annual_fuel_consumption_gal

PV
year_one_energy_produced_kwh
Total
Energy
Keep as-is for now

average_annual_energy_produced_kwh
Total
Energy
annual_energy_produced_kwh

year_one_to_load_series_kw
Series
Energy
production_to_load_series_kw

year_one_to_battery_series_kw
Series
Energy
production_to_battery_series_kw

year_one_to_grid_series_kw
Series
Energy
production_to_grid_series_kw

year_one_curtailed_production_series_kw
Series
Energy
production_curtailed_series_kw

average_annual_energy_exported_kwh
Total
Energy
annual_energy_exported_kwh

Site
year_one_emissions_tonnes_CO2
Total
Energy
annual_emissions_tonnes_CO2

year_one_emissions_tonnes_NOx
Total
Energy
annual_emissions_tonnes_Nox

year_one_emissions_tonnes_SO2
Total
Energy
annual_emissions_tonnes_SO2

year_one_emissions_tonnes_PM25
Total
Energy
annual_emissions_tonnes_PM25

year_one_emissions_from_fuelburn_tonnes_CO2
Total
Energy
annual_emissions_from_fuelburn_tonnes_CO2

year_one_emissions_from_fuelburn_tonnes_NOx
Total
Energy
annual_emissions_from_fuelburn_tonnes_NOx

year_one_emissions_from_fuelburn_tonnes_SO2
Total
Energy
annual_emissions_from_fuelburn_tonnes_SO2

year_one_emissions_from_fuelburn_tonnes_PM25
Total
Energy
annual_emissions_from_fuelburn_tonnes_PM25

SteamTurbine
year_one_thermal_consumption_mmbtu
Total
Energy
annual_thermal_consumption_mmbtu

year_one_electric_energy_produced_kwh
Total
Energy
annual_electric_production_kwh

year_one_thermal_energy_produced_mmbtu
Total
Energy
annual_thermal_production_mmbtu

year_one_thermal_consumption_series_mmbtu_per_hour
Series
Energy
thermal_consumption_series_mmbtu_per_hour

year_one_electric_production_series_kw
Series
Energy
electric_production_series_kw

year_one_electric_to_grid_series_kw
Series
Energy
electric_to_grid_series_kw

year_one_electric_to_battery_series_kw
Series
Energy
electric_to_battery_series_kw

year_one_electric_to_load_series_kw
Series
Energy
electric_to_load_series_kw

year_one_thermal_to_tes_series_mmbtu_per_hour
Series
Energy
thermal_to_tes_series_mmbtu_per_hour

year_one_thermal_to_load_series_mmbtu_per_hour
Series
Energy
thermal_to_load_series_mmbtu_per_hour

HotThermalStorage
year_one_soc_series_fraction
Series
Energy
soc_series_fraction

year_one_to_load_series_mmbtu_per_hour
Series
Energy
storage_to_load_series_mmbtu_per_hour

ColdThermalStorage
year_one_soc_series_fraction
Series
Energy
soc_series_fraction

year_one_to_load_series_ton
Series
Energy
storage_to_load_series_ton

Wind
year_one_to_battery_series_kw
Series
Energy
production_to_battery_series_kw

year_one_to_grid_series_kw
Series
Energy
production_to_grid_series_kw

average_annual_energy_exported_kwh
Total
Energy
annual_energy_exported_kwh

year_one_to_load_series_kw
Series
Energy
production_to_load_series_kw

year_one_energy_produced_kwh
Total
Energy
Keep as-is for now

average_annual_energy_produced_kwh
Total
Energy
annual_energy_produced_kwh

year_one_curtailed_production_series_kw
Series
Energy
production_curtailed_series_kw

The "cooling" techs, ElectricChiller and AbsorptionChiller, currently use the "electric" tech naming convention for series, i.e. "production_to", whereas the "heating" techs currently use "thermal_to". The cooling techs are really producing thermal too, cold thermal. We also talked about just using "production" (or just not necessarily specifying electric vs thermal) when a tech only produces one type (e.g. electric, heating thermal, cooling thermal). The two options to make this more consistent are 1) change the cooling tech outputs to "thermal_to", or 2) change the heating (only) tech outputs to "production_to". I think I like option 1 because it's a little more specific and differentiated with any electric production. Thoughts?

The "cooling" techs, ElectricChiller and AbsorptionChiller, currently use the "electric" tech naming convention for series, i.e. "production_to", whereas the "heating" techs currently use "thermal_to". The cooling techs are really producing thermal too, cold thermal. We also talked about just using "production" (or just not necessarily specifying electric vs thermal) when a tech only produces one type (e.g. electric, heating thermal, cooling thermal). The two options to make this more consistent are 1) change the cooling tech outputs to "thermal_to", or 2) change the heating (only) tech outputs to "production_to". I think I like option 1 because it's a little more specific and differentiated with any electric production. Thoughts?

@Bill-Becker I agree with option 1 (does the table below align with what you're thinking?).
I also think we could maybe even go one step further and name all series outputs for electric-only techs "electric_to" (instead of "production_to") for consistency across the board. This could make querying results for "thermal" or "electric" outputs easier--what do you think?

Key
SubKey
New Name

AbsorptionChiller
year_one_to_tes_series_ton
thermal_to_tes_series_ton

year_one_to_load_series_ton
thermal_to_load_series_ton

year_one_thermal_consumption_series_mmbtu_per_hour
thermal_consumption_series_mmbtu_per_hour

year_one_thermal_consumption_mmbtu
annual_thermal_consumption_mmbtu

year_one_thermal_production_tonhour
annual_thermal_production_tonhour

year_one_electric_consumption_series_kw
electric_consumption_series_kw

year_one_electric_consumption_kwh
annual_electric_consumption_kwh

ExistingChiller
year_one_to_tes_series_ton
thermal_to_tes_series_ton

year_one_to_load_series_ton
thermal_to_load_series_ton

year_one_electric_consumption_series_kw
electric_consumption_series_kw

year_one_electric_consumption_kwh
annual_electric_consumption_kwh

year_one_thermal_production_tonhour
annual_thermal_production_tonhour

@adfarth Option 1 it is, and yes I also agree with "electric_to" instead of "production_to". Thanks! I'm going to get to your other questions/checks soon, and the full review.

@adfarth Option 1 it is, and yes I also agree with "electric_to" instead of "production_to". Thanks! I'm going to get to your other questions/checks soon, and the full review.

Addressed in https://github.com/NREL/REopt.jl/pull/160/commits/c693109c82b70775fa9abc0a88538db01dbc919b and https://github.com/NREL/REopt.jl/pull/160/commits/18213880b77d8da19e0a14069eb467300999a082


Implement IPv6 support for distributed XGBoost

Currently distributed XGBoost does not support IPv6, this is explicitly asserted in rabit/include/rabit/internal/socket.h
Our internal network is IPv6 only, which means we can't run XGBoost out of the box.
IPv6 is 20+ years old, and IPv4 is being phased out more and more as the time progresses. I think it is very important to enable IPv6 in XGBoost for more successful adoption.

Hi @ikriv , thank you for raising the issue.  Would you like to work on this?

I will take a deeper look into this.

I will try to implement it after 1.6.
Note to myself:

[ ] Check NCCL support.
[ ] Change socket wrapper to support IPV6.
[ ] Implement it in Python tracker.
[ ] Possible change in Scala tracker.

Thank you so much, @trivialfis! I think Python tracker is already good (at least it does not complain loudly), it's the socket wrapper that insists on IPv4

Not yet.  I will update this thread.

Hi, can anyone here help with providing guidance on testing IPv6 on a public cloud like AWS or GCP? I'm not an expert on network administrating and got lost in those cloud documents.
The draft PR is here: https://github.com/dmlc/xgboost/pull/8225 .

I tested the code using GCP VM instances. Feel free to try it if you are interested in this.

Q: is there any plan for ipv6 support on pyspark :)

Would be great if there people with expertise can help work on this. It takes some effort to setup a test environment in the CI and we don't have any admin.

Is spark ipv6 supported now? If not I'd like to contribute.


Admin should be able to edit mentor details

Description:

Admin should be able to edit mentor details

Tasks:

We need an endpoint to update mentor details like category, name, profile picture etc

Acceptance Criteria:

There's an endpoint to update mentor details only accessible to admins

@Disura-Randunu Would you like to work on this?

@anjula-sack Sure. Should I prioritize this issue or #155

@anjula-sack Sure. Should I prioritize this issue or #155

You can prioritize this

@anjula-sack img-url is a property of profile. Shall I make it possible to update other profile data within the mentor update as well?

@anjula-sack Also, since there's an image, it will be a form-data request. The issue is with type conversions specially with key-value pairs in the "application" property. those values will always be strings since we're passing them through a form data like below.

we could pass all the other data as a JSON value in the form and parse it in the backend
or we could convert in the backend but there will be multiple checks
or else make a seperate API call for the image upload and then use the returned string as the imageUrl in another request along with other data.
otherwise can just convert the image to base64

what do you think?

Yeah let's go with first option since it's more flexible and we probably will refactor how we are handling the applications. @Disura-Randunu

@anjula-sack what about the profile data other than image? Should they be updatable within mentor update?

@anjula-sack what about the profile data other than image? Should they be updatable within mentor update?

yes

@anjula-sack added PR


Fix error on older systems

Add support for older versions as noted in https://www.gnu.org/software/libtool/manual/html_node/Invoking-libtoolize.html

Hi @csanders-git,
Merged ;) thanks.


Add support for Hotmart

Checklist

[X] I'm reporting a new site support request
[X] I've verified that I'm running yt-dlp version 2022.04.08 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that none of provided URLs violate any copyrights or contain any DRM to the best of my knowledge
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and am willing to share it if required

Region
No response
Example URLs

Course playlist: https://hotmart.com/product/platinum-yoga-su-misura/E39738113D?sck=HOTMART_SITE

Description
Would it be possible to add support for videos from hotmart.com? It requires users to be logged in before they can view videos.
Verbose log
The output log is very log and my terminal doesn't display the whole things.

The output log is very log and my terminal doesn't display the whole things.

I still need to see it!!
yt-dlp -sUv "URL" --cookies-from-browser chrome > log.txt 2>&1

Then upload log.txt here

There a few issues here:

the page scraping extractor is broken as the video provider has changed to hotmart
hotmart authentication is probably different to the previous video provider
video segments are encrypted and although segment decryption is supported, the URL for the encryption key itself (m3u8 EXT-X-KEY) is also encrypted

So even if you deal with the first two issues you still have the last one. How practical a solution is would depend on how often the video provider changes their EXT-X-KEY encryption strategy and how easy those changes are to determined.

How can I DM you a hotmart URL to try?

@pukkandan here is log file
log.txt


Incorrect colors

Hi,
several Royal TSX customers have reported an issue to me that I wasn't taking very seriously until I started some more in-depth debugging today.
It seems like color rendering is slightly off compared to MSRDP and what I'm seeing when connecting directly to the console (via VMware) of the machine.
This is most easily seen when something should be 100% white. When using FreeRDP it's a light gray instead of 100% white.
Here are three screenshots:
VMware Console

MSRDP

FreeRDP

Now if you use a color picker and pick the white color in the user icon you will notice that in the first two screenshots it's 100% white but FreeRDP renders it as R:248 G:252 B:248.
I have only been able to reproduce when connecting to Windows Server 2012 R2 machines and older. Also, as soon as I turn on /gfx the issue is gone.
Any idea what's going on?
thx,
felix

You could try building without sse, there may be a lossy color conversion at work.
(Should be a rounding error about 4?)

@akallabeth I just tried this and got the same result.
 Do you know which codec is used for the session?

@akallabeth Doesn't seem to matter.
Tried with defaults, with /nsc and /rfx. Same results. Only if I use /gfx white is really white.

Ah, got you the wrong way around, so with gfx it is ok, but plain ROP colors are off?

Exactly.

Did you compare it to mstsc using the same codecs?
So, no gfx or rfx, but plain old rdp?
Might be a side effect of these ROP operations.
Might also help to check the old rdp specs, maybe they got updated with a corrected color conversion formula.

Seems to be related to color format conversion. Whenever the remote host uses 16 bit colors, I get the incorrect color values.
/gfx just happens to "fix it" because it forces 32 bit on the server.
So this is OS agnostic. I tried with 2003, 7, 2008, 2012, 2016 and 10. Whenever the remote OS uses 16 bit color depth I see the problem.

Ah, so if you use /bpp:32 without gfx it is also correct?

Yes, but since Windows servers by default limit to 16 bit I first thought it has no impact. Once you switch on /gfx though, the server seems to lift that limit and I can see in the FreeRDP connection log that 32 bit is used. For client OS's it's enough to set /bpp:32.

Ok, so the culprit is the 16 -> 32 bit conversion...
Yes, that sounds like there could be some calculations that produce slightly off colors in that case.

Yes, looks like that's the problem. @akallabeth Any idea how to fix it?

Hmm, no, not right away.

Same issue with 15 bit. Although the colors are again slightly different:

No problem with 8 bit:

Again, no problem with 24bit:

Let me guess, offset is at most 8?

Yeah, looks like it.

Unfortunately, enough for users to notice. ;-)

So should be at most 4 for green 565 bit at /bpp:16...
Could reduce the offset to 4(2) if we just take the average

How does MS do it though as it's always 100% white no matter the color depth in their clients?

Better color filter. Might also be a off by 1 on our side as an offset of 8 means we're one (16bit) value off

Can you actually reproduce this on your side and if so can you look into it?

Can try next week, but no idea if I can provide a fix any time soon.

Couldn't ask for more. Thx!


stream arn reference

stream arn in output seems incorrect
https://github.com/terraform-aws-modules/terraform-aws-dynamodb-table/blob/4e2c8ec638d03276038766afa24cdca41453ef67/outputs.tf#L13
shouldn't this be tfvar.stream_enabled ? try(aws_dynamodb_table.this[0].stream_arn, aws_dynamodb_table.autoscaled[0].stream_arn, "") : null

Thank you for reporting this issue! Fixed in #46

This issue has been resolved in version 1.2.1 :tada:


Controls delay on the screen

Hi, thanks for the good work!
I use this code to read data from a racing wheel. The problem is that the data aren't exactly real time, because there is some kind of internal delay. When for example I stop steering the wheel I can see in the screen all the values between my current position and the previous for many seconds. I want to do it exactly real time like this: http://html5gamepad.com/
Thanks!

@skaftanis for realtime performance your processing has to be shorter than the signal sampling.
How many samples per second do you receive? What is your processing time? Do you drop samples on jitter? Do you process one sample at a time or a block of samples? etc.
I recommend you getting started with passing the data received on your callbacks (start with raw data) with a timestamp attached into another thread that only has a receiving queue that writes to a file.
Straight file operations are usually much faster than visual IO (e.g. print to screen in an IDE or even CLI).
That'd give you a context in what are your realtime expectations like data throughput and jitter.
PyWinUSB does asynchronous reading in a dedicated python thread which only posts messages to a consumer thread.
That's the reason you don't loose data, your data would get accumulated if your rate of consumption is slower than the rate of production.
Based on your analysis you might need to (not necessarily mutually exclusive options):

Do faster processing
Decimate the data
Drop data

Anyway... start with data :-)


Fix an error on the document:

param value should be string instead of number

Thanks for this. I'm not sure we want to force users pass strings. I do think params should be normalised though

@posva Em... I think maybe it's better to force the user to use string for the router params, consider:

When the param is part of the url, like /abc/123 for router /abc/:id, the id will be a string instead of number, it may not be a good idea for the user to pass the param as a number pragmatically.
The param member is defined as string in the TypeScript description file so set the param as a number is conflict with the description router.d.ts:

export interface Route {
  path: string;
  name?: string;
  hash: string;
  query: Dictionary<string>;
  params: Dictionary<string>; // <- this one
  fullPath: string;
  matched: RouteRecord[];
  redirectedFrom?: string;
  meta?: any;
}


Fix homepage to use SSL in MoneyMoney Cask

The HTTP URL is already getting redirected to HTTPS. Using the HTTPS URL directly
makes it more secure and saves a HTTP round-trip.

Looks good, thanks! :+1:


One contract per route

I would like to organize my codebase by use case and not by entity. For example, the docs describe the following structure for the entity "Post":
export const contract = c.router({
  createPost: {...},
  getPosts: {...},
});

As you can see, the contract mixes multiple use cases (creating a Post and retrieving a Post).
I would prefer it if i could define two contracts separately:
// api/posts/get/contract.ts
export const contract = c.router({...});

// api/posts/post/contract.ts
export const contract = c.router({...});

Then, i would like to create routes like this:
// api/posts/get/route.ts
import {contract} from "./contract";

registerRoute(contract, async ({ body }) => {
  return {
    status: 201,
    body: {...},
  };
});

// api/posts/post/route.ts
import {contract} from "./contract";

registerRoute(contract, async ({ body }) => {
  return {
    status: 201,
    body: {...},
  };
});

You can define a single endpoint contract using c.query or c.mutation, and assuming you are using a Next.js backend, you can define a single endpoint handler using createSingleRouteHandler as documented here


Response 500 on songs recommendation

Looks like something changed from jiosaavn's side, will try to fix this

@shahil-yadav fixed in https://github.com/sumitkolhe/jiosaavn-api/releases/tag/v0.0.3


Unnecessary pull request restriction

Gitea version: 1.8.2
Operating system: CentOs 7
Database:

[x] SQLite

Can you reproduce the bug?

[x] Yes

Description
Unable to approve own pull request if you are the only whitelisted user capable of approving requests.
This restriction seems unnecessary.

If you the the only approver, why not just merge it?
From another point of view, "approve own pull request" seems also unnecessary .... GitHub also do not allow self-approve IIRC.

We allow approving your own PR at all?
No, just tested it, that's not possible, and I would like to keep it this way…

There is a way and it is if you are the admin of the repository.
I opened a feature request to disable this since code review is beneficial (the repo admin can turn it off if they need to force something through).

There is a way and it is if you are the admin of the repository.

If they are the only user, why just consider "Merge it" as approved and "Close it" as rejected? Why someone needs to approve their own PRs?

There is a way and it is if you are the admin of the repository.

If they are the only user, why not just consider "Merge it" as approved and "Close it" as rejected? Why someone needs to approve their own PRs?

Why enable branch protection if you are the only user.


Postgres TLS Support

This has been tested and works but the API added to tokio-postgres is hacky and will need some refinement.
Closes #386

Hmmmmm, looks like some of the commits don't pass the checks on their own. Does it make sense to combine them or maybe just squash on merge?

Hmmmmm, looks like some of the commits don't pass the checks on their own. Does it make sense to combine them or maybe just squash on merge?

I typically just squash merge


[SR-13220] Compiling for iOS 8.0, but module  has a minimum deployment target of iOS 13.5

Previous ID
SR-13220

Radar
None

Original Reporter
JonasVautherin (JIRA User)

Type
Bug

Environment
macOS 10.15.5
Xcode 11.5 (11E608c)
swift 5.2.4
SPM 5.2.0

Additional Detail from JIRA

Votes
0

Component/s
Package Manager

Labels
Bug

Assignee
None

Priority
Medium

md5: d583c0bc9d117d9eafb1524a0a258969

Issue Description:
For the record, this comes from here: https://github.com/grpc/grpc-swift/pull/887.
It seems like `swift package generate-xcodeproj` sometimes wrongly guesses that a dependency requires iOS 13.5.
Here are detailed steps to reproduce with SwiftProtobuf:
1. Create a new project with `swift package init`.
2. In `dependencies`, add `.package(name: "SwiftProtobuf", url: "https://github.com/apple/swift-protobuf.git", from: "1.9.0"),
3. In `targets: (dependencies`, add `SwiftProtobuf`)
4. Run `swift package generate-xcodeproj`
5. Run `open <project-name>.xcodeproj` to open with Xcode
6. In the (only) source file "<project>.swift", add the line: `import SwiftProtobuf`
7. Try to build for "iPhone 11".
You should see the following error:
> Compiling for iOS 8.0, but module 'SwiftProtobuf' has a minimum deployment target of iOS 13.5: /path/to/x86_64-apple-ios-simulator.swiftmodule
But SwiftProtobuf does not require iOS 13.5.

generate-xcodeproj command doesn't exist anymore. Closing.


Just wanted to say thanks!

Thanks for putting this back out there! Pulled my own custom integration and imported yours... all working great

Thank you so much Sir!

Absolute legend.
Resigned to the idea of losing Mazda integration forever and finally upgraded past 2023.10 yesterday. Then found this not even 24hrs later. Installed and everything is back up, totally seamless.

Just bought a Mazda today. Was really disappointed when I couldn't add to HA. Then I found this Repo. A huge Thank you from me.

Awesome! Thanx!

Great job, mate!

Is this still working? not working for me

Is this still working? not working for me

Still working here! 👍🏻

Yes it's working. Maybe your problem is the one that everyone has... you can connect only ONE user to My Mazda with privileges really useful, the other ones users you connect are useless. And you can have only ONE "admin" user connected at a time. So, if you use the My Mazda app on your phone (i.e.) you can't use this integration.
This is NOT AN INTEGRATION PROBLEM, i'ts just your usual friendly Mazda idiocracy...
My $0.02, of course.

Yes it's working. Maybe your problem is the one that everyone has... you can connect only ONE user to My Mazda with privileges really useful, the other ones users you connect are useless. And you can have only ONE "admin" user connected at a time. So, if you use the My Mazda app on your phone (i.e.) you can't use this integration. This is NOT AN INTEGRATION PROBLEM, i'ts just your usual friendly Mazda idiocracy... My $0.02, of course.

can you explain a bit more?
i've installed the mazda app on my android phone and with same credentials, logged in with the integration.
to improve functionality in home assistant i need to do what? just logoff and uninstall the app?

I believe what you need to do is have a separate MyMazda user account for the HA integration, instead of using the same one you do with the MyMazda app.
In the MyMazda app, if you go to Settings > MyMazda > My Vehicle, there's a 'DRIVERS' tab where you can add additional drivers/accounts. I added a new one to use with the HA integration (with a different email address), and you can specify what permissions they have (you obviously need to give the new account some permissions so it can read the data).

I believe what you need to do is have a separate MyMazda user account for the HA integration, instead of using the same one you do with the MyMazda app.
In the MyMazda app, if you go to Settings > MyMazda > My Vehicle, there's a 'DRIVERS' tab where you can add additional drivers/accounts. I added a new one to use with the HA integration (with a different email address), and you can specify what permissions they have (you obviously need to give the new account some permissions so it can read the data).

thanks you!! :D

I believe what you need to do is have a separate MyMazda user account for the HA integration, instead of using the same one you do with the MyMazda app.
In the MyMazda app, if you go to Settings > MyMazda > My Vehicle, there's a 'DRIVERS' tab where you can add additional drivers/accounts. I added a new one to use with the HA integration (with a different email address), and you can specify what permissions they have (you obviously need to give the new account some permissions so it can read the data).

Yes, with current version of the app this works fine. Previously, additional drivers didn't have enough permissions to see all data of the car. Thank you very much.

What does the integration show?  I took delivery of a new mazda today, and no data shows in the app (or HA?).  I'm wondering if it takes a while for the data to flow through to the app etc.  My 5 years free Roadside assistance is also showing as "expired" or something....so something it wrong.

What does the integration show? I took delivery of a new mazda today, and no data shows in the app (or HA?). I'm wondering if it takes a while for the data to flow through to the app etc. My 5 years free Roadside assistance is also showing as "expired" or something....so something it wrong.

@GeorgeCastanza sounds like you need to enable Mazda Connected Services from the car dashboard itself so you can get updates in the Mazda app. As I recall, first time setup should also ask you for the car VIN


Align libvirt version to 5.0.0

What this PR does / why we need it:
Currently, we use different libvirt versions under:

builder container 5.0.0
virt-launcher 4.9.0
libvirt-go 4.8.0

I want to align our libvirt version under all places to 5.0.0(and on the way to update our dependencies)
Relevan kubevirt/libvirt PR - https://github.com/kubevirt/libvirt/pull/19
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

Use libvirt 5.0.0

/hold cancel


Update lambda deploy to use aws lambda cli command

So here is a potential way to deploy the lambda. This is what we do at work because 99% of the time we're just redeploying the code and then use the AWS Paramstore/chamber to set our secrets/config variables. So i added a step to update the config vars. Well github copilot did so I'm guessing it might work?

Note this is 100% untested.


MRE metric

Thanks for the interesting work.
I saw you used the MRE metric in paper, but I didn't find it in the code.
Could you please update it to the code?
Thanks a lot.

Hi, @packer-c, I collected it from the baseline repository: https://github.com/WenjieDu/SAITS/blob/master/modeling/utils.py, feel free to adapt as desired
Juan

Got it! thank you.


Improve response cards

Currently response cards behaved differently on iOS compared to web. In web response card would collapse upon a click, and would show the choice as a normal text. on iOS the response card remained open and just highlighted the selection. This PR fixes it and iOS response cards will behave like in web.

!squash

!merge


withdraw error

still the same problem

Hello!
I had sell 2500 monyx for 0.00004 = 0.1btc, but received only 0.05 and order closed.
Screen:
https://i.gyazo.com/34bd81e9a3c7081a4fb9c0a618eea055.png
Give me back my monyx or btc, please.
Nickname: JohnRameez
Mail<EMAIL_ADDRESS>Regards


[Feature request] Capability to break up zip or 7zip files

This is primarily for Cloud backup users that usually have a file backup size limit.  For example, Google Drive has a 50 meg file size limit (according to this article).
Current behavior
Files saved to the available archive (under the Versioning tab of the Watcher window) grow over time as files are versioned with no discernible limit.
Requested behavior
Ability to break up individual ZIP or 7ZIP files into limited size files, For example, a 115 meg file would become six separate 20 meg files.

Google Drive max file size is about 12GB these days. Anyway, I am implementing a max size in the next version, otherwise the files grow to insane sizes


Cardboard box can cause "internal exception io.netty.handler.codec.decoderexception"

ok.. consider this.. a person is packing up things to move their base.. and wants to "pack light"
they use cardboard boxes to pack up a few ME drives with disks in them.. and those drives have deep storage units that are full... they also place it into a diamond chest with ALOT of other things.. so everything is quite full..
then this person puts that into a cardboard box so they can carry it...
they get disconnected with "internal exception io.netty.handler.codec.decoderexception" with various port errors and saying packets are too large.
When they login they could fall through the world till they hit like -1.6XX and can't do anything (solution to this is to be killed.. its better if you have a gravestone so the box can be stored in it since its now a crashing box)
I understand its because it has to send all the data thats in the cardboard box to the user and its just too much!
So does this discribe a silly person? :)
I wonder if there can be a check to see if the packet would be too large as you put on the cardboard box and have it reject/pop off if it would be too much?

While I think doing that is really dumb, I agree that it should not be possible to put a block with an inventory into a cardboard box if the inventory already contains a cardboard box. The dolly from JABBA should probably also be blacklisted if it contains something.

its not dumb per say.. it could have backpacks full of stuff ...
I understand blacklisting but feel it wont make sense is there a way to see how big the dataload would be and then fail?
Also the issue would be cardbard boxes in a ME system would cause this as well! so it would need the data check still.

I doubt that it is possible to get the size of the data. What I don't really get is why the client needs the NBT data from the cardboard box.

unknown.. but it is only a theory?

@XFactHD To eliminate visual desyncs, that's why. How is your client supposed to know what is inside the box on the server if no packet is set to tell your client that it is in the box?

Right. As far as I know, there really isn't a way to see the "size" of the data of a cardboard box.  I can't say that I intended boxes to be used for ME drive transport :)

@iKaneki-Ken why does the client need to know what's in the box? As far as I recall the cardboard box is not like the JABBA dolly which changes its texture when you transport something with it.

@XFactHD If the client doesn't know what's in the box, it can cause a visual desync, which in turn can make it seem like if you remove the item in the box and put it in your inventory, nothing will show up in your inventory until the next player inventory event triggered.

good knowlage
Maybe there could be a warning @aidancbrady that happens when you do pack a ME drive or other known items that could be a issue?
this way people don't do it if they are stupid like me :)

@iKaneki-Ken the cardboard box is not like a pouch, you can't take anything out of the box and put it in your inventory. You need to place the box and shift right click it to reveal the contents, which in my opinion is where the client needs to know what's inside the box.

@XFactHD Understood, irregardless though, a sync packet is still recommended for a situation like that.

@iKaneki-Ken recomendeed or REQUIRED? IE are is it sending data that does not need to be sent and could just be kept on the server side and not cause a crash?


qt types compatibility

Hello
Is it make sense to prepare pull request with Qt types support? (or at least try to do it)
I believe sfinae magic should be enough for this.
Or library should be stl compatible only? Asking just for saving our time)

What Qt types are you talking about here. As Qt is dependent on C++ so all types will work except std::string which anyway you can convert it to QString by using fromStdString method.

What Qt types are you talking about here. As Qt is dependent on C++ so all types will work except std::string which anyway you can convert it to QString by using fromStdString method.

What Qt types are you talking about here. As Qt is dependent on C++ so all types will work except std::string which anyway you can convert it to QString by using fromStdString method.

Yep, but it doesn't look elegant. Moreover I noticed some weird issues with non-ascii symbols in patch -- it leads to crash.

What Qt types are you talking about here. As Qt is dependent on C++ so all types will work except std::string which anyway you can convert it to QString by using fromStdString method.

Yep, but it doesn't look elegant. Moreover I noticed some weird issues with non-ascii symbols in patch -- it leads to crash.

I dont know if the devs are active for this repositories.

Or use other from fffaraz/awesome-cpp#csv repo

Or use other from fffaraz/awesome-cpp#csv repo

You could use other. But their could be subtle difference between these libraries. For fast parsing, csv2 is the best.


Can Sentinel be used to create a Data Invetory

More of a query really, can Sentinel be used to create a data inventory? We already have tool that does this but if Sentinel can do the same then I can see a cost saving to be possibly be had.

Hi @DonDonDeDon, thanks for flagging this issue, we will investigate this issue and get back to you with some updates. Thanks!

Hi @DonDonDeDon, Sentinel cannot be used to create Data inventory, we are closing this issue from GitHub. If you still need support for this issue, feel free to re-open it any time. Thank you for your co-operation.


Examples for other response codes do not render in UI

Using example from https://mattfrear.com/2015/04/21/generating-swagger-example-responses-with-swashbuckle/
decorate your action method with multiple response codes, and add an example to at least one other non 200 response code.
The resulting JSON doc will show examples next to other (non 200) response codes - GOOD, see snippet below:
http://imgur.com/a/s6hTA
But unfortunately, user interface for non 200 response codes ignores examples, and just renders response type definition (default behavior).
http://imgur.com/a/QducM

I am having the same issue, was this ever resolved?

I managed to get the examples to show up, but only one of the examples show in the Swagger UI even when many are defined in the Json

@JuanEstradaUY can you create a minimal project reproducing this issue?
That would help a lot troubleshooting

Any update on this issue?


access to registered thread names

code.viator reported this on 2017-02-28T10:52:26Z
Transfered from https://issues.dlang.org/show_bug.cgi?id=17234
CC List

jack (@JackStouffer)
razvan.nitu1305
simen.kjaras

Description
std.concurrency have `register` function for associate tid with some name and tid can be obtained by this name, but no accessors for get all associate names by tid. This information stored in private __gshared variable `namesByTid` and can be provided by function `string[] registredNames(Tid tid)` for example.

razvan.nitu1305 commented on 2017-07-14T13:17:48Z
PR : https://github.com/dlang/phobos/pull/5609

simen.kjaras commented on 2020-02-20T12:15:48Z
locate goes the opposite way: Given a name, get the tid. What's being requested here is given a tid, get the name(s).

Something like this:

/**
 * Gets the names associated with tid.
 *
 * Params:
 *  tid = The Tid to locate within the registry.
 *
 * Returns:
 *  The associated names or null if tid is not registered.
 */
string[] locate(Tid tid) {
    synchronized (registryLock)
    {
        if (auto name = tid in namesByTid)
            return *name;
        return [];
    }
}

b2.temp commented on 2020-02-20T11:58:30Z
this was added at some point: Tid locate(string name);

razvan.nitu1305 commented on 2017-07-14T13:40:02Z
*** Issue 17231 has been marked as a duplicate of this issue. ***


when tapping on "See the component" (in expanding sheet), Voice Over doesn't vocalize the title (Sheet bottom tutorial) but the "close" button first

Announcement on the tile and focus on the main text


Unable to use Cloudera Manager Python Shell

Hello,
I'm trayng to use cmps, and i have error when i'm trying to authenticate .
help
Regards,

hi @Zouaui
please show errors for you question. and show your code.

Thank you for your reply
I think the issue is related to the certificate.
regards

ok. good luck for you


Lazy load with Modal Revisited

https://github.com/verlok/lazyload/issues/50
Trying to re-open this issue. The lazy loader wont work for either the content or modal. I tried the code that was originally used. Not sure what im doing wrong.
Wondering if my external script tag for the the vanilla.js is all i need and if its in the right place.
<---Physical Modal---->

Project Name
Lorem ipsum dolor sit amet consectetur.

 Lorem ipsum dolor sit amet, consectetur adipisicing elit. Est blanditiis dolorem culpa incidunt minus dignissimos deserunt repellat aperiam quasi sunt officia expedita beatae cupiditate, maiores repudiandae, nostrum, reiciendis facere nemo!

Date: January 2017
Client: Threads
Category: Illustration

                  Close Project

<----- A class initiator with image----->

Threads

Illustration

The modal:

Project Name
Lorem ipsum dolor sit amet consectetur.

 Lorem ipsum dolor sit amet, consectetur adipisicing elit. Est blanditiis dolorem culpa incidunt minus dignissimos deserunt repellat aperiam quasi sunt officia expedita beatae cupiditate, maiores repudiandae, nostrum, reiciendis facere nemo!

Date: January 2017
Client: Threads
Category: Illustration

                  Close Project

Project Name
Lorem ipsum dolor sit amet consectetur.

 Lorem ipsum dolor sit amet, consectetur adipisicing elit. Est blanditiis dolorem culpa incidunt minus dignissimos deserunt repellat aperiam quasi sunt officia expedita beatae cupiditate, maiores repudiandae, nostrum, reiciendis facere nemo!

Date: January 2017
Client: Threads
Category: Illustration

                  Close Project

I must admit that I didn’t understand what you’re trying to do here and how.
Could you please specify

why your images uses the regular src attribute instead of the data- ones
why did you put the lazy class in the outer div instead of in the img
where did you put the script tag for the LazyLoad and how
where did you put the new LazyLoad code and with which options

Ultimately, did you read the README file and took a look at the demos in the demos folder?

It limited what i could upload for code
On Tue, Mar 5, 2019 at 1:21 AM Andrea Verlicchi<EMAIL_ADDRESS>wrote:

I must admit that I didn’t understand what you’re trying to do here and
how.
Could you please specify

why your images uses the regular src attribute instead of the data-
ones
why did you put the lazy class in the outer div instead of in the img
where did you put the script tag for the LazyLoad and how
where did you put the new LazyLoad code and with which options

Ultimately, did you read the README file and took a look at the demos in
the demos folder?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/verlok/lazyload/issues/320#issuecomment-469568512,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Akj-lStiyIej5a_-H02WZkIHsN66jaKwks5vThr-gaJpZM4bdn45
.

--
http://www.jakearciniega.com

That’s probably because you initially didn’t wrap your code inside the triple backtick. Try that again.

Hey @jakeman1031,
do you still need help or you did find the information you needed in the README or in the demos?

Sorry I haven’t responded sooner. I my modal working. However, the destroy
portion I cannot. My modal is similar to the one on that agency template.
However, my minified js is difficult to read. Does the destroy take the
image and unload it again?
On Wed, Mar 6, 2019 at 12:12 AM Andrea Verlicchi<EMAIL_ADDRESS>wrote:

Hey @jakeman1031 https://github.com/jakeman1031,
do you still need help or you did find the information you needed in the
README or in the demos?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/verlok/lazyload/issues/320#issuecomment-469982051,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Akj-lZXMjCX5M-axGVYcY0za6eQvPMfCks5vT1w9gaJpZM4bdn45
.

--
http://www.jakearciniega.com

I guess you're speaking about #50 and specifically to this comment

I think I figured it out:
var globalLazyLoad = new LazyLoad();

var modalLazyLoad;
$('.modal')
        .bind('shown.bs.modal', function () {
            modalLazyLoad = new LazyLoad({
                container: this
            });
        })
        .bind('hidden.bs.modal', function () {
            modalLazyLoad.destroy();
        });

It seems to work. Could you please confirm if this is the right way to do it?

The destroy does not unload images, it just destroys the LazyLoad instance so you don't have any IntersectionObserver or other pending event listeners.
I still don't understand what you're trying to do and what doesn't work in your case.

Yes. So is there no way to unload an image?
On Wed, Mar 6, 2019 at 12:20 AM Andrea Verlicchi<EMAIL_ADDRESS>wrote:

I guess you're speaking about #50
https://github.com/verlok/lazyload/issues/50 and specifically to this
comment
I think I figured it out:
var globalLazyLoad = new LazyLoad();
var modalLazyLoad;
$('.modal')
.bind('shown.bs.modal', function () {
modalLazyLoad = new LazyLoad({
container: this
});
})
.bind('hidden.bs.modal', function () {
modalLazyLoad.destroy();
});
It seems to work. Could you please confirm if this is the right way to do
it?
The destroy does not unload images, it just destroys the LazyLoad
instance so you don't have any IntersectionObserver or other pending
event listeners.
I still don't understand what you're trying to do and what doesn't work in
your case.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/verlok/lazyload/issues/320#issuecomment-469983771,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Akj-lby3RnOxhwPg9VDF0dFd61J6zOtPks5vT14sgaJpZM4bdn45
.

--
http://www.jakearciniega.com

Yes. So is there no way to unload an image?

What do you mean by “unload”?

set its source to another source
set its source to an empty string
remove the image from the DOM

LazyLoad doesn’t do any of those, but you can do it yourself in your javascript code.

Ok so whats the best way to write that?
Remove it from the dom seems to be right
On Wed, Mar 6, 2019 at 6:25 AM Andrea Verlicchi<EMAIL_ADDRESS>wrote:

Yes. So is there no way to unload an image?
What do you mean by “unload”?

set its source to another source
set its source to an empty string
remove the image from the DOM

LazyLoad doesn’t do any of those, but you can do it yourself in your
javascript code.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/verlok/lazyload/issues/320#issuecomment-470088609,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Akj-lSVGn7iPQMq5Gvm5SYr8NsQpnw53ks5vT7PTgaJpZM4bdn45
.

--
http://www.jakearciniega.com

Here’s how to remove an element from the DOM
https://developer.mozilla.org/en-US/docs/Web/API/ChildNode/remove
I’m closing this issue now, if you have any question related to LazyLoad feel free to reopen. Otherwise it’s plenty of answers on Stackoverflow, MDN, Google etc.


[Menus] Wrong documentation

I'm trying to apply code examples from http://material-ui.com/#/components/menus, but it doesn't work. It works with exception:
Warning:
  Failed propType: Required prop `index` was not specified in `MenuItem`.
  Check the render method of `ToolBar`.warning @ bundle.js:42343
Warning:
  Failed propType: Required prop `menuItems` was not specified in `Menu`.
  Check the render method of `ToolBar`.

Material-ui: v0.13.3
ReactJS: v0.14.3

Are you importing the right components?

Same problem here:
const { Menu,	MenuItem } = MUI;
MenuTest = React.createClass({
  render() {
    return (
			<Menu>
				<MenuItem primaryText="Maps" />
				<MenuItem primaryText="Books" />
				<MenuItem primaryText="Flights" />
				<MenuItem primaryText="Apps" />
			</Menu>
    );
  }
});

Get error messages:

Warning: Failed propType: Required prop index was not specified in MenuItem. Check the render method of MenuTest. react-runtime-dev.js:1697:9
Warning: Failed propType: Required prop menuItems was not specified in Menu. Check the render method of MenuTest. react-runtime-dev.js:1697:9
TypeError: this.props.menuItems is undefined

Tried adding keys to the menuItems and passing the menuItems as array but I only get an empty white box on the screen:
const { Menu,	MenuItem } = MUI;
MenuTest = React.createClass({
	render() {
		let test = [
			<MenuItem index={0} primaryText="AAA" />,
			<MenuItem index={1} primaryText="BBB" />,
			<MenuItem index={2} primaryText="CCC" />,
			<MenuItem index={3} primaryText="DDD" />,
			<MenuItem index={4} primaryText="EEE" />,
			<MenuItem index={5} primaryText="FFF" />,
		];
		return (
			<Menu menuItems={test} />
		);
	}
});

Also tried the following with the same results (just an empty white box):
const { Menu,	MenuItem } = MUI;
MenuTest = React.createClass({
	render() {
		let test = [
			<MenuItem index={0}>AAA</MenuItem>,
			<MenuItem index={1}>BBB</MenuItem>,
			<MenuItem index={2}>CCC</MenuItem>,
			<MenuItem index={3}>DDD</MenuItem>,
			<MenuItem index={4}>EEE</MenuItem>,
			<MenuItem index={5}>FFF</MenuItem>,
		];
		return (
			<Menu menuItems={test} />
		);
	}
});

@rdagger You can't use MUI.
You need to use
import Menu from 'material-ui/lib/menus/menu';
import MenuItem from 'material-ui/lib/menus/menu-item';
import MenuDivider from 'material-ui/lib/menus/menu-divider';

Sorry, I should have mentioned my code is using Meteor.  All the other Material UI components work.  For example the following IconMenu code works great:
injectTapEventPlugin();
const { IconMenu, MenuItem } = MUI;
const { SvgIcons } = MUI.Libs;
MenuTest = React.createClass({
	render() {
		const accountIcon = <SvgIcons.ActionAccountCircle color='Black'/>;
		accountItems = [
			<MenuItem index={0} target="/login" key="login">Login</MenuItem>,
			<MenuItem index={1} target="/join" key="join">Join</MenuItem>
		];
		return (
				<IconMenu style={{marginLeft: '100px'}}
					onItemTouchTap={this._handleAccountMenu}
					iconButtonElement={accountIcon}>
					{accountItems}
				</IconMenu>
		);
	},
	_handleAccountMenu(e){
		console.log(e.target);
	}
});

@oliviertassinari After your reply, I looked at the Meteor source code and I figured out the problem.  I needed to reference MUI.Libs instead of just MUI.  Thanks for your help.  Here is a working sample:
const { Menu,   MenuItem } = MUI.Libs;
MenuTest = React.createClass({
    render() {
        return (
					<Menu>
						<MenuItem primaryText="Maps" />
						<MenuItem primaryText="Books" />
						<MenuItem primaryText="Flights" />
						<MenuItem primaryText="Apps" />
					</Menu>
        );
    }
});

I'm not using  meteor but I am also getting the index required error. I have imported the menu and menu item components

Solution of this issure is using children elemnt like this:
 <MenuItem {...props...}>
   primary text will be here
</Menuitem>

The documentation was updated with https://github.com/callemall/material-ui/pull/2443.

My implementation fails at
const NavigationClose = require('material-ui/lib/svg-icons/navigation/close')
'can't find module'
Using Typescript/reactjs (.tsx)
Any clue of how to get around this, or where to look for documentation, would be appreciated.
The problem seems to be that close is not included in material-ui.d.ts file.

Yeah, I had to add definitions in material-ui.d.ts, mirroring NavigationMenu entries, both for NavigationClose and MoreVertIcon. Most material-ui/lib/svg-icons/... icons do not yet of .d.ts entries.
(I also had to create a .d.ts file for react-tap-event-plugin)
/// <reference path="../typings/react-tap-event-plugin.d.ts" />

I take it the authors use .jsx but not typescript? or they have more available to their local dev environment than has been released. IAC presumably will get worked out over time.

@HenrikBechmann This is not a typescript project. and we don't maintain the definition files. That is because you'll see a lot of regressions going on when using those files from DefinitelyTyped.
But there is a discussion going on, maybe we can generate the definition files directly from the source.

@subjectix automated generation of def files would be awesome! In the meantime it's not a showstopper, because there are good patterns to follow. Just annoying ;-)
Generally your project looks good. Early days, but I'm encouraged to keep going with it.
Thanks for all your work!

Henrik

@HenrikBechmann Awesome indeed, I use typescript myself all the time. Thanks for your feedback :+1: :smile:


[Backport v3.5] ICMP memory leak on invalid priority

Describe the bug
If an ICMP echo request is sent with an invalid priority, an allocated packet is not released.
To Reproduce
Internal implementation of ICMP, no application code should directly call these functions.
Expected behavior
The packet should be dropped if the priority check fails.
Impact
Potential memory leak if further adjustments were to be added to the ICMP implementation.
Logs and console output
N/A
Environment (please complete the following information):
N/A
Additional context
A bug report is required to be able to backport the fix to the latest released version of zephyr.

Closing since https://github.com/zephyrproject-rtos/zephyr/pull/65826 was merged.


Drag and drop does not work with dynamic added elements.

I'm creating a directive that adds the data-drag and jqyoui-draggable attributes to an element on compile function, and they does not get the drag option.  Even manually adding the class attribute with class="ui-draggable ui-draggable-handle" does not work.
Does the lib support something like this?
I know events are added to existing elements, and can't handle new ones, but take a look at this: https://learn.jquery.com/events/event-delegation/

Make sure you have included drag libraries correctly and compiling the element (with drag properties) properly. Adding those classes dynamically will not help.
If you share a demo on JSFiddle or Plnkr, it will be helpful for me to understand the problem well.


ESLint isn't on for .ts files

Describe the bug
If you create a new SvelteKit project like this
npm create svelte@latest my-app-2 and then cd my-app-2, and then npm i, and then modify src/routes/+page.ts with an obvious syntax error like thisShouldError() on line 5... there are no eslint errors generated.
Here's the whole file that eslint thinks is fine.
// since there's no dynamic data here, we can prerender
// it so that it gets served as a static asset in production
export const prerender = true;

thisShouldError();

However if you do the same in the script tag of the +layout.svelte, it does error.
<script>
	import Header from './Header.svelte';
	import './styles.css';
	thisShouldError()
</script>

svelte-check does throw an error for the thisShouldError() call in the .ts file.
Because eslint doesn't output anything, my text editor doesn't alert me to the problem.
Reproduction
See above.
Logs
No response
System Info
System:
    OS: macOS 13.4.1
    CPU: (10) arm64 Apple M1 Max
    Memory: 2.71 GB / 32.00 GB
    Shell: 3.6.1 - /opt/homebrew/bin/fish
  Binaries:
    Node: 18.16.1 - /opt/homebrew/opt/node@18/bin/node
    npm: 9.5.1 - /opt/homebrew/opt/node@18/bin/npm
  Browsers:
    Chrome: 114.0.5735.133
    Edge: 114.0.1823.58
    Safari: 16.5.1
  npmPackages:
    @sveltejs/adapter-auto: ^2.0.0 => 2.1.0
    @sveltejs/kit: ^1.20.4 => 1.20.5
    svelte: ^4.0.0 => 4.0.0
    vite: ^4.3.6 => 4.3.9

Severity
serious, but I can work around it
Additional Information
No response

Hey, I created a new kit project (selecting typescript & eslint) and svelte check does error for me using your example

Uninstalling "JavaScript and TypeScript Nightly" in VSCode fixed the issue my language server was having.  So I'm seeing the errors now in .ts files.  I still feel eslint path/to/some/file.ts shouldn't say "All Good", though.

Ah yea, that extension is known to cause issues - try running npm run lint as that showed the issue for me with eslint :pray:

Ah yea, that extension is known to cause issues - try running npm run lint as that showed the issue for me with eslint :pray:

I can confirm this bug and also that it's not limited to VS Code. My neovim config also has the same issue.
Using the example @Arro gave above and using this file structure in ./src:
.
├── app.d.ts
├── app.html
├── lib
│   └── index.ts
└── routes
    ├── +page.server.ts
    ├── +page.svelte
    └── +page.ts

I was only able to get in-editor diagnostics from eslint in the +page.svelte file. I added the exact same error in all 3 of the ts files shown above, including the lib/index.ts file, and no diagnostics were shown other than what tsserver provides.
Running pnpm check output all 4 errors as expected.
Running pnpm exec eslint . from the project root ONLY SHOWS ONE ERROR - the error in the svelte file.
Example repo here ready to test, just run pnpm install and then test as needed.
This was tested on Ubuntu in WSL, using Neovim with a linter plugin. Eslint is confirmed working in other non-Sveltekit projects.

I'm not sure if it's related, but I had to do the following to get eslint working in VS Code after running the create-svelte helper:
In .eslintrc.cjs, add the following lines under parserOptions:
project: "./tsconfig.json",
tsconfigRootDir: __dirname,

In tsconfig.json, remove this line:
"moduleResolution": "bundler"

It's always been a struggle for me to get a new SvelteKit project set up with eslint, so it would be good if create-svelte would set the right configuration options by default. Are there good reasons why these options aren't the default?