HADOOP-18330-S3AFileSystem removes Path when calling createS3Client

Description of PR
added new parameter object in s3ClientCreationParameters that returns full s3a path
How was this patch tested?
Tested against the following endpoint -> s3.us-east-1.amazonaws.com
For code changes:

[ X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 44s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
37m 58s

trunk passed

+1 :green_heart:
compile
1m  0s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
0m 55s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 53s

trunk passed

+1 :green_heart:
mvnsite
1m  1s

trunk passed

+1 :green_heart:
javadoc
0m 49s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 51s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 36s

trunk passed

+1 :green_heart:
shadedclient
21m  5s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 25s
/patch-mvninstall-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

-1 :x:
compile
0m 24s
/patch-compile-hadoop-tools_hadoop-aws-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-aws in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
javac
0m 24s
/patch-compile-hadoop-tools_hadoop-aws-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-aws in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
compile
0m 24s
/patch-compile-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-aws in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

-1 :x:
javac
0m 24s
/patch-compile-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-aws in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 28s
/results-checkstyle-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws: The patch generated 1 new + 5 unchanged - 0 fixed = 6 total (was 5)

-1 :x:
mvnsite
0m 26s
/patch-mvnsite-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

+1 :green_heart:
javadoc
0m 24s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

-1 :x:
javadoc
0m 25s
/patch-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-aws in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

-1 :x:
spotbugs
0m 24s
/patch-spotbugs-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

+1 :green_heart:
shadedclient
23m 52s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
0m 34s
/patch-unit-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

+1 :green_heart:
asflicense
0m 51s

The patch does not generate ASF License warnings.

93m 10s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4572/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4572

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 02a8be022526 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0da1d072df2d7f52d259eeb60d4500b7b576b4d2

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4572/1/testReport/

Max. process+thread count
704 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4572/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

get yetus to stop failing the build, then run the integration tests against an s3 bucket, then i will review

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 42s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
38m 31s

trunk passed

+1 :green_heart:
compile
1m  2s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
0m 54s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 52s

trunk passed

+1 :green_heart:
mvnsite
1m  2s

trunk passed

+1 :green_heart:
javadoc
0m 49s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 51s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 33s

trunk passed

+1 :green_heart:
shadedclient
21m  2s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 39s

the patch passed

+1 :green_heart:
compile
0m 42s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
0m 42s

the patch passed

+1 :green_heart:
compile
0m 37s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 37s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 27s

the patch passed

+1 :green_heart:
mvnsite
0m 41s

the patch passed

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 32s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 13s

the patch passed

+1 :green_heart:
shadedclient
20m 27s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 40s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 51s

The patch does not generate ASF License warnings.

98m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4572/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4572

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux df2b3c78addb 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 19ee4f51782c0cd33de1ec1715613ecd5744ea25

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4572/2/testReport/

Max. process+thread count
732 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4572/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

ok, which s3 endpoint did you run the tests against?

ok, which s3 endpoint did you run the tests against?

Just ran the tests against us-east-1

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m  5s

trunk passed

+1 :green_heart:
compile
1m  3s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
0m 50s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 45s

trunk passed

+1 :green_heart:
mvnsite
0m 57s

trunk passed

+1 :green_heart:
javadoc
0m 41s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 44s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 31s

trunk passed

+1 :green_heart:
shadedclient
22m 22s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 39s

the patch passed

+1 :green_heart:
compile
0m 43s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
0m 43s

the patch passed

+1 :green_heart:
compile
0m 37s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 37s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 27s

the patch passed

+1 :green_heart:
mvnsite
0m 41s

the patch passed

+1 :green_heart:
javadoc
0m 23s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 32s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 13s

the patch passed

+1 :green_heart:
shadedclient
20m 26s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 44s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 52s

The patch does not generate ASF License warnings.

102m 46s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4572/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4572

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 32b996b7804d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 1de79b6766c59f26890a2968c83a7e0ad85cf9e4

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4572/3/testReport/

Max. process+thread count
719 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4572/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Greetings, I was wondering what version of hadoop was this change merged into? Is it in 3.3.4 or will this come out with 3.3.5 release?

The first release candidate is up for testing. Download and test it. This is the only way you can be sure that the actual shipped version does what you need.

where can I download this "candidate" 3.3.5 version you are talking about? It's nowhere on your website.

we put up RCs for review through our dev lists; if you really want to get involved in pre-release code you should subscribe. here is the announcement. as it warns, I've been on vacation for most of the month, hence my lack of replies.

---------- Forwarded message ---------
From: Steve Loughran
Date: Wed, 21 Dec 2022 at 19:28
Subject: [VOTE] Release Apache Hadoop 3.3.5
To: Hadoop Common<EMAIL_ADDRESS>Hdfs-dev<EMAIL_ADDRESS>yarn-dev<EMAIL_ADDRESS>mapreduce-dev<EMAIL_ADDRESS>Mukund and I have put together a release candidate (RC0) for Hadoop 3.3.5.
Given the time of year it's a bit unrealistic to run a 5 day vote and expect people to be able to test it thoroughly enough to make this the one we can ship.
What we would like is for anyone who can to verify the tarballs, and test the binaries, especially anyone who can try the arm64 binaries. We've got the building of those done and now the build file will incorporate them into the release -but neither of us have actually tested it yet. Maybe I should try it on my pi400 over xmas.
The maven artifacts are up on the apache staging repo -they are the ones from x86 build. Building and testing downstream apps will be incredibly helpful.
The RC is available at:
https://dist.apache.org/repos/dist/dev/hadoop/hadoop-3.3.5-RC0/
The git tag is release-3.3.5-RC0, commit<PHONE_NUMBER>d
The maven artifacts are staged at
https://repository.apache.org/content/repositories/orgapachehadoop-1365/
You can find my public key at:
https://dist.apache.org/repos/dist/release/hadoop/common/KEYS
Change log
https://dist.apache.org/repos/dist/dev/hadoop/hadoop-3.3.5-RC0/CHANGELOG.md
Release notes
https://dist.apache.org/repos/dist/dev/hadoop/hadoop-3.3.5-RC0/RELEASENOTES.md
This is off branch-3.3 and is the first big release since 3.3.2.
Key changes include

Big update of dependencies to try and keep those reports of
transitive CVEs under control -both genuine and false positive.
HDFS RBF enhancements
Critical fix to ABFS input stream prefetching for correct reading.
Vectored IO API for all FSDataInputStream implementations, with
high-performance versions for file:// and s3a:// filesystems.
file:// through java native io
s3a:// parallel GET requests.
This release includes Arm64 binaries. Please can anyone with
compatible systems validate these.

Please try the release and vote on it, even though i don't know what is a good timeline here...i'm actually going on holiday in early jan. Mukund is around and so can drive the process while I'm offline.
Assuming we do have another iteration, the RC1 will not be before mid jan for that reason
Steve (and mukund)

When can we expect the official release for version 3.3.5.
its out

I’m curious what the hold up is.

one of the big problems is lack of testing of release candidates. it is very frustating to have a release ready and then, during the week of voting on it, not enough people review it. One contribution everyone can make to any of the ASF project is to help validate the release.
If you depend on something working, this is an important thing to do. If any bug surfaces now, it wont get fixed for three months at least.


Wasm example for stabilityai/stablelm-2-zephyr-1_6b

Since we have Phi wasm examples which perform quite well in browser, it would be nice to support stabilityai/stablelm-2-zephyr-1_6b since it just 1.6B model.

Since this model is supported in "normal" examples here https://github.com/huggingface/candle/blob/main/candle-examples/examples/stable-lm/main.rs#L131 , it would be great to get wasm demo as we have wasm examples for Phi models.


feat(#1432): basic dataset settings

This PR includes needed components to create a basic set of settings for token and text classification datasets.
The new required API endpoints are implemented as a new API version (v1).
The client components are built in a different way. Now, the main API client contains child APIs (datasets API for now) that can be used for specific API communication. Also, the inner client wraps the httpx client, it's easier to use the client directly:
self._client.post("/api/v1/datasets"....)

Closes #1432
Update

A rb.create_dataset is provided
The dataset settings models are found under the module rubrix.datasets
Settings can only be provided on dataset creation
No way to fetch already configured dataset settings

A simple code snippet:
import rubrix as rb
from rubrix.datasets import TextClassificationSettings

settings = TextClassificationSettings(labels_schema={ "Positive", "Negative" })
rb.create_dataset(name="a-new-dataset", settings=settings)
...
rb.log(name="a-new-dataset", records....)

TODOs

[ ] The settings documentation part
[ ] A place in guides
[ ] Check provided annotations in records when log records against labels schema (new API)
[ ] Allow read settings from UI

@frascuchon I had a quick look at the client part, and from my side, this looks goood. But maybe we could have a quick call tomorrow for a high-level overview.


Fix stiff feet while walking

This bug was caused by the fact that the animations were exported without skin from Mixamo. If the animations are exported with skin, they work fine on different humanoid models.


[Access Request] Page 344 Navigation - SetSource

Hello, could you please make the SetSource procedure protected, so we can call it from our extension?
protected procedure SetSource(PostingDate: Date; DocType2: Text[100]; DocNo: Text[50]; SourceType2: Integer; SourceNo2: Code[20])

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


LANG-1300: Change CharSequenceUtils to support supplementary characters

@chtompki
I'm tackling the root cause now.

Coverage increased (+0.01%) to 94.548% when pulling 721a6e59f7e4f5c0f3196d3eb0e81cab5e41d065 on MarkDacek:Lang1300CharSequenceUtilsChange into 6597c196521af500feef7a02610727eafa7ec1dc on apache:master.

Coverage increased (+0.01%) to 94.548% when pulling 721a6e59f7e4f5c0f3196d3eb0e81cab5e41d065 on MarkDacek:Lang1300CharSequenceUtilsChange into 6597c196521af500feef7a02610727eafa7ec1dc on apache:master.

Coverage increased (+0.01%) to 94.548% when pulling c7c424fb9c3a39b6ea036242e44cdca324f7d104 on MarkDacek:Lang1300CharSequenceUtilsChange into 6597c196521af500feef7a02610727eafa7ec1dc on apache:master.

Definitely looking better than #250. I'm fiddling around with this locally currently. I'll keep you posted.
@dmjones500 - Since you logged LANG-1300, you have any thoughts on this one?

Coverage increased (+0.01%) to 94.548% when pulling a8f41ec97d139f5d0d7cf161e8484f2bb809facc on MarkDacek:Lang1300CharSequenceUtilsChange into 6597c196521af500feef7a02610727eafa7ec1dc on apache:master.

Coverage increased (+0.01%) to 94.548% when pulling 66f8569ecc8173d61b7d182f4da0223ae7dbda38 on MarkDacek:Lang1300CharSequenceUtilsChange into 6597c196521af500feef7a02610727eafa7ec1dc on apache:master.

Coverage increased (+0.01%) to 94.548% when pulling 66f8569ecc8173d61b7d182f4da0223ae7dbda38 on MarkDacek:Lang1300CharSequenceUtilsChange into 6597c196521af500feef7a02610727eafa7ec1dc on apache:master.

Sorry @chtompki, I've been crazy busy lately and haven't moved many issues forward at all.
These changes look good. One thing I've noticed (which is no fault of this change) is the method behaves differently if the input is a String. String.indexOf(int ch) returns the index, as measured by code points. However the remainder of the method will return the index measured in code units.
I haven't had the time to prove this with a unit test, but might be worth looking into this at the same time.

@chtompki  I'm far from a complexity expert, but if we keep a running tally of the current index in terms of code points, I don't see us going from O(n) to O(n2). Wouldn't O(n2) imply that for each item in the input, we traverse the entire input again?

@dmjones500 - You're correct there, I wasn't thinking about it properly because I was thinking in terms of lastIndexOf moving in from the end of the CharSequence and then having to traverse in from the beginning to sort out the number of surrogate pairs in the prefix to the matching character. But, if you simply start with that traversal, then you remain at O(n).

Just a question I have on this.
Are we to do this for ALL calls to this method, or only those where the search char is a supplementary char?

@chtompki Please look this over. We have some interesting conflicts here.

The issue mentioned above. indexOf("a") will double-count surrogate-pairs if they exist. We can fix this if need be.
A string with two surrogate-pairs will read as length 4, though we will treat it as length 2 for the purpose of these operations. E.G. :
```
final int CODE_POINT = 0x2070E;
StringBuilder builder = new StringBuilder();
builder.appendCodePoint(CODE_POINT);
builder.appendCodePoint(CODE_POINT);
StringUtils.lastIndexOf(builder, CODE_POINT, 2)

the bottom line will return -1, wheras the builder.toString()... version returns 2. I suspect this is just that they disregarded our issue and start at charAt(2) instead of our iterative approach here.

Coverage increased (+0.004%) to 94.54% when pulling b45435c950e6f6864671bdffde29e26cdc8ce15b on MarkDacek:Lang1300CharSequenceUtilsChange into 6597c196521af500feef7a02610727eafa7ec1dc on apache:master.

Coverage increased (+0.004%) to 94.54% when pulling b45435c950e6f6864671bdffde29e26cdc8ce15b on MarkDacek:Lang1300CharSequenceUtilsChange into 6597c196521af500feef7a02610727eafa7ec1dc on apache:master.

Coverage increased (+0.04%) to 94.576% when pulling b45435c950e6f6864671bdffde29e26cdc8ce15b on MarkDacek:Lang1300CharSequenceUtilsChange into 6597c196521af500feef7a02610727eafa7ec1dc on apache:master.

We need to agree on the desired behaviour of the method. Based on the signature, I think we can adjust it to support supplementary characters without violating the implied contract of the method. The issue for me is about indexes.
Based on the JavaDoc description, I suggest we return the code unit index. This is because the input is a CharSequence and the JavaDoc states:

Finds the first index within a CharSequence, handling null.

Also, a CharSequence only has methods which operate on code unit indexes. So returning a code unit index would be helpful for further operations on the sequence.
What does everyone else think? We should obviously update the JavaDocs to make it crystal clear what we decide, either way.

@dmjones500 - you think we should bubble this up to the dev list?

Okay. It seems that we'll want some clearer documentation. Note that the javadoc on indexOf in the jdk follows:
/**
     * Returns the index within this string of the first occurrence of the
     * specified character, starting the search at the specified index.
     *

     * If a character with value ch occurs in the
     * character sequence represented by this String
     * object at an index no smaller than fromIndex, then
     * the index of the first such occurrence is returned. For values
     * of ch in the range from 0 to 0xFFFF (inclusive),
     * this is the smallest value k such that:
     *

     * (this.charAt(k) == ch) && (k >= fromIndex)
     *

     * is true. For other values of ch, it is the
     * smallest value k such that:
     *

     * (this.codePointAt(k) == ch) && (k >= fromIndex)
     *

     * is true. In either case, if no such character occurs in this
     * string at or after position fromIndex, then
     * -1 is returned.
     *
     *

     * There is no restriction on the value of fromIndex. If it
     * is negative, it has the same effect as if it were zero: this entire
     * string may be searched. If it is greater than the length of this
     * string, it has the same effect as if it were equal to the length of
     * this string: -1 is returned.
     *
     *
All indices are specified in char values
     * (Unicode code units).
     *
     * @param   ch          a character (Unicode code point).
     * @param   fromIndex   the index to start the search from.
     * @return  the index of the first occurrence of the character in the
     *          character sequence represented by this object that is greater
     *          than or equal to fromIndex, or -1
     *          if the character does not occur.
     */

Let's see if we can get something along these lines on both CharSequenceUtils as well as StringUtils. Furthermore, I think we should stick as closely to the implementation in String as possible simply generalizing to CharSequence's.

Chiming in here. I'd recommend using code units so that it's compatible with the other operations like substring. Of course, this would still break if you called substring(index+1) since you'd be taking the second byte of a supplementary character, but I'd still argue that this is the path to take.

I'm going to make some documentation changes here. I'll keep you apprised as I make them.

Coverage increased (+0.05%) to 94.585% when pulling b521820b23c45fd068618d10955eceed48801eff on MarkDacek:Lang1300CharSequenceUtilsChange into 6597c196521af500feef7a02610727eafa7ec1dc on apache:master.

Going to fix the javadoc build and then pull this in.


style: Fix position of mat-menu and box-shadow

resolve #53

I changed the height of mat-dialog-container class to max-height, otherwise it looks as follow:


Change model switch labels

In version 7170 of ccp4i2-devel, the Iris report was incorporated into the report of another task known as REFMAC.
REFMAC takes a model as input and outputs a refined model. These input and output models are used as the 'Previous/Latest' of Iris, but these labels do not make sense in the context of refinement. 'Input/Output' would be preferable.
Therefore, we should add an option to pass custom labels into Iris validation that replace the 'Previous/Latest' labels.

Addressed in https://github.com/glycojones/iris-validation/commit/e00e70346a4ab6ae31578ec8c9b6662cfa97a527


Rebrand to gmggroup

We changed the name in May and need to change the organization name in GitHub

@fwkoch I have updated the links to ReadTheDocs for the documentation. Once this merges - I think that is most things? Can you do a quick search for other things in the code base that use the old branding?


cmd/9g, cmd/7g: use dedicated zero register in componentgen

Once cl 2606 goes in, all architectures will use a zero register in componentgen. However, 7g and 9g have a dedicated zero register; use it instead of zeroing a temp.
I'll do this once the compiler is in Go.
/cc @4ad as fyi

SGTM. The convenience of 7g's ZR register is significant.
On 13 Feb 2015 05:29, "Josh Bleecher Snyder"<EMAIL_ADDRESS>wrote:

Once cl 2606 goes in, all architectures will use a zero register in
componentgen. However, 7g and 9g have a dedicated zero register; use it
instead of zeroing a temp.
I'll do this once the compiler is in Go.
/cc @4ad https://github.com/4ad as fyi
—
Reply to this email directly or view it on GitHub
https://github.com/golang/go/issues/9855.


bug in Printing errors

Rasa NLU version=  rasa-nlu 0.13.1
Operating system  = windows 7 enterprise home
Content of model configuration file:
following the rasa-workshop-pydata-berlin
Issue:
o/p is printing in str form but still showing typo error
TypeError                                 Traceback (most recent call last)
<ipython-input-41-4a2e157bcd0b> in <module>()
      1 from rasa_nlu.evaluate import run_evaluation
      2
----> 3 run_evaluation("nlu.md", model_directory)

C:\ProgramData\Anaconda3\lib\site-packages\rasa_nlu\evaluate.py in run_evaluation(data_path, model_path, errors_filename, confmat_filename, intent_hist_filename, component_builder)
    628
    629         evaluate_intents(intent_results, errors_filename, confmat_filename,
--> 630                          intent_hist_filename)
    631
    632     if extractors:

C:\ProgramData\Anaconda3\lib\site-packages\rasa_nlu\evaluate.py in evaluate_intents(intent_results, errors_filename, confmat_filename, intent_hist_filename)
    268
    269     if errors:
--> 270         save_nlu_errors(errors, errors_filename)
    271
    272     cnf_matrix = confusion_matrix(targets, predictions)

C:\ProgramData\Anaconda3\lib\site-packages\rasa_nlu\evaluate.py in save_nlu_errors(errors, filename)
    203
    204     utils.write_to_file(filename,
--> 205                         json.dumps(errors, indent=4, ensure_ascii=False))
    206     logger.info("Model prediction errors saved to {}.".format(filename))
    207

C:\ProgramData\Anaconda3\lib\site-packages\rasa_nlu\utils\__init__.py in write_to_file(filename, text)
    194     """Write a text to a file."""
    195
--> 196     with io.open(filename, 'rw', encoding="utf8") as f:
    197         f.write(str(text))
    198

TypeError: expected str, bytes or os.PathLike object, not NoneType
check 196-197

Can you check what the value of errors is?

I am not sure how to check the value ?
On Mon, 27 Aug 2018 at 12:26 PM, Akela Drissner-Schmid <
<EMAIL_ADDRESS>wrote:

Can you check what the value of errors is?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/RasaHQ/rasa_nlu/issues/1342#issuecomment-416132868,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AlW6C6vkFWQ9X0b-m7bfHgsHlGsQJp_7ks5uU5gvgaJpZM4WLyHO
.

add a print(errors) in the code of that nlu file

Getting this same error while using Spacy 1.8.2,
but when I update spacy to 2.1.0, I start getting this error:
File "~/lib/python3.6/site-packages/spacy/util.py", line 136, in load_model
raise IOError(Errors.E050.format(name=name))
OSError: [E050] Can't find model 'None'. It doesn't seem to be a shortcut link, a Python package or a valid path to a data directory.


Update travis to work correctly.

I noticed that Travis was coming up with build errors. This will fix it.

 It works, I promise you :neckbeard:

Yeah, some of the worker working. Okay i merge this request. Thanks.


dermatozoon, fleme (logical-conflict)

This pull request was generated by the 'mq' tool

/trunk merge


rspec tests -- not passing on vanilla checkout

I hit this on mac and linux, using ruby 2.1 and 2.0, on bash and zsh.  Is there additional config required to get this working?
Thanks!
-Travis
[master][~/git/community/rufus-scheduler]$ bundle exec rspec
RUBY_VERSION: 2.0.0
RUBY_PLATFORM: x86_64-linux
.......................................................FF.............................................................................................................................................................................................................................................................................................
Pending: (Failures listed here are expected and do not affect your suite's status)

Rufus::Scheduler#at accepts an ActiveSupport time thinggy
Not yet implemented
./spec/schedule_at_spec.rb:143

Rufus::Scheduler#schedule_in accepts an ActiveSupport .from_now thinggy
Not yet implemented
./spec/schedule_in_spec.rb:73

Failures:

Rufus::Scheduler::CronLine#matches? matches correctly when there is a sun#2 involved
Failure/Error: expect(cl(line).matches?(time)).to eq(true)
expected: true
got: false
(compared using ==)
./spec/cronline_spec.rb:54:in `match'
./spec/cronline_spec.rb:641:in `block (3 levels) in <top (required)>'

Rufus::Scheduler::CronLine#matches? matches correctly when there is a L involved
Failure/Error: expect(cl(line).matches?(time)).to eq(true)
expected: true
got: false
(compared using ==)
./spec/cronline_spec.rb:54:in `match'
./spec/cronline_spec.rb:647:in `block (3 levels) in <top (required)>'

Finished in 3 minutes 29.5 seconds (files took 0.17997 seconds to load)
344 examples, 2 failures, 2 pending
Failed examples:
rspec ./spec/cronline_spec.rb:639 # Rufus::Scheduler::CronLine#matches? matches correctly when there is a sun#2 involved
rspec ./spec/cronline_spec.rb:645 # Rufus::Scheduler::CronLine#matches? matches correctly when there is a L involved

Hello,
Travis-CI tells me Ruby 2.1 and 2.2 are OK: https://travis-ci.org/jmettraux/rufus-scheduler
My OSX succeeds and says:
$ ruby -v
ruby 2.1.3p242 (2014-09-19 revision 47630) [x86_64-darwin14.0]
$ uname -a
Darwin satsuma.local 14.5.0 Darwin Kernel Version 14.5.0: Tue Sep  1 21:23:09 PDT 2015; root:xnu-2782.50.1~1/RELEASE_X86_64 x86_64

My Debian GNU/Linux succeeds and says:
$ ruby -v
ruby 2.1.3p242 (2014-09-19 revision 47630) [x86_64-linux]
$ uname -a
Linux dejima 3.16.0-4-amd64 #1 SMP Debian 3.16.7-ckt11-1+deb8u5 (2015-10-09) x86_64 GNU/Linux

I manage my Ruby with https://github.com/postmodern/chruby and build them with https://github.com/postmodern/ruby-install#readme
Sorry.


Is there any possible to simplify the query API?

Supposed, query API is used more frequently, could it the more clean?
dataset.query().filter()

Could use it be:
dataset.filter()

No intention of changing it at present time. DataCollectionQuery objects (created by DataCollection#query) are queryable subsets of the larger DataCollection and can not do things like adding indices, etc. Would prefer to keep concerns separate. :smile:

Make sense to me. But we are deeply influenced by jQuery: Write less get more. How about add a query alias: "q". dataset.q().filter.

You're free to create your own fork and write an alias. I prefer code that is readable and easy to reason about upon seeing it for the first time.

All right.

What if you passed the filter info as a parameter to the .query() method call? Example:
'''
dataset.query({name: "John"})
'''

You overwrite the query function. Then the original query().filter should not work.

BTW,  'this.query = function(filters){' if this is current instance, you should create method on prototype, otherwise each instance will have a different function but the functionality is the same.

Yes that should be on the prototype, not the instance.


:oncomplete functions don't want to accept an iterator as an argument

I'm not sure if this is a bug,an intended feature, or an error on my part, but I felt it'd be worth posting regardless.
Whenever you have a tween inside of an iteration and try to pass the iterator as an argument to the function within :oncomplete, it gives the error "expected function or callable". A (barebones) example of what I'm attempting to do is below:
for i, player in ipairs(playerList) do
    flux.to(player, moveSpeed, {x =xvalue, y = yvalue}):delay(.5):oncomplete(resetAction(player))
end
A temporary solution I've found is that by calling a mediating function with :oncomplete to then call the main function with the arguments, you can get by without an issue.
If you'd like more code to find the issue, I can provide it as soon as possible.

Writing the below with assumption that the resetAction() function isn't itself returning a function:
The :oncomplete() function expects a function as its argument, though resetAction is a function you are calling it immediately and its return value is being passed to the oncomplete function. The "temporary" solution you mentioned is the actual solution -- this assures a function is being passed which when executed does the resetAction(player) call which is the expected behaviour.
The following example may make things more clear:
local f = function() return 10 end
print( type( f ) ) -- prints "function"
print( type( f() )) -- prints "number"
print( type( function() f() end ) ) -- prints "function"

Ah, that makes sense. I greatly appreciate the reply, and apologize for flagging a false "issue". I'll go ahead and close this.


NTR cell cycle switching terms

Hi,
I would like to request the term

negative regulation of cell cycle switching, mitotic to meiotic cell cycle (GO:0051728 )
for pombe pat1(aka ran1)
signal transduction (GO:0007165) involved in cell cycle switching, mitotic to meiotic cell cycle

standard defs...
e.g. see PMID:17674143
cheers
Antonia.

@Antonialock   Quick question:
Would it be correct to make 'signal transduction involved in cell cycle switching, mitotic to meiotic cell cycle' a child of 'intracellular signal transduction' (GO:0035556), or do you just want it to be a direct child of 'signal transduction ' (GO:0007165)?

yes cheers, intracellular

Still need to add signal transduction terms.  Will do that tomorrow.

Signal transduction term now added.


Chapter 12 Example 05 Compile Errors

Dear Author,
I bought your second edition Modern C++ book on Amazon.com in the United States.
I am using the gcc g++ 10.1.0 compiler on Windows 10 laptop with Cygwin terminal window.
While compiling chapter 12 example 12_05, with #define USE_RANGES_V3 getting
following compile errors
$ g++-10.1.0 -Wall -std=c++20 main.cpp -o main.exe
In file included from /usr/local/include/c++/10.1.0/range/v3/view.hpp:17,
from main.cpp:10:
/usr/local/include/c++/10.1.0/range/v3/view/adaptor.hpp:18:10: fatal error: concepts/concepts.hpp: No such file or directory
18 | #include <concepts/concepts.hpp>
|          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
ssjus@LAPTOP-DK5PVG34 ~/CPP/Modern_CPP_Ed2_Ck_Bk_SSJ/Ch_12/chapter12_05
I have a file with name: concepts (i.e. without .hpp extension) include file in the following folder:
C:\cygwin64\usr\local\include\c++\10.1.0
I have a concepts.hpp file in each of the following folders:
C:\cygwin64\usr\local\include\c++\10.1.0\range\v3\action
C:\cygwin64\usr\local\include\c++\10.1.0\range\v3\functional
C:\cygwin64\usr\local\include\c++\10.1.0\range\v3\iterator
C:\cygwin64\usr\local\include\c++\10.1.0\range\v3\range
C:\cygwin64\usr\local\include\c++\10.1.0\range\v3\utility
File sizes in each of these folders are different.
12_05 example is compiling without errors, if I don't define  USE_RANGES_V3
But I need also to compile without errors when I use  #define USE_RANGES_V3
Please let me know how to fix the above compile errors.
Thanks and best regards,
SSJ

I don't know about Cygwin, I never used that. But you can always try these samples with wandbox.org or godbolt.org.
Here is a sample of of chapter12_05 using ranges v3 on wandbox.
https://wandbox.org/permlink/OyvrBVMl5BuxDMSF


Configure Renovate

Welcome to Renovate! This is an onboarding PR to help you understand and configure settings before regular Pull Requests begin.
🚦 To activate Renovate, merge this Pull Request. To disable Renovate, simply close this Pull Request unmerged.

Detected Package Files

pyproject.toml (poetry)

What to Expect
With your current configuration, Renovate will create 3 Pull Requests:

Update dependency toml to v0.10.2

Schedule: ["at any time"]
Branch name: renovate/toml-0.x
Merge into: develop
Upgrade toml to 0.10.2

Update dependency click to v8

Schedule: ["at any time"]
Branch name: renovate/click-8.x
Merge into: develop
Upgrade click to ^8.0

Update dependency pydocstyle to v6

Schedule: ["at any time"]
Branch name: renovate/pydocstyle-6.x
Merge into: develop
Upgrade pydocstyle to ^6.0.0

❓ Got questions? Check out Renovate's Docs, particularly the Getting Started section.
If you need any further assistance then you can also request help here.

This PR has been generated by Renovate Bot.

@chadell To enable renovate this PR needs merged then it will open the 3 PRs mentioned.  It will update the pyproject.toml and the lock...


Have a standalone library for the common functions, like scheduler, message queues, etc?

The sniffer that does not need the OT stack, but need the otPlatRadio interface, common scheduler, message queue, etc.
Then the sniffer needs to include libopenthread.a, which causes the multiple definitions error. The mac and sniffer both use otPlatRadioSignalReceiveDone.
Do we need to have a standalone library for the common functions that does not related with the thread stack? Then other app could do not always need to include the whole ot stack, while they do not need to use it, or only part of it.

Hi Lu,
It may be good to move all such otPlat callbacks into a delegate model
where any given otPlatModule has an otPlatModuleRegister to pass a
structure of function pointers.
Alternatively, the build system can be adjusted to create a libotplatform.a
that has weak stub implementations of the callbacks, which then gets linked
correctly for any given app / platform pair.
Martin
On May 22, 2016 8:41 AM, "Lu Wang"<EMAIL_ADDRESS>wrote:

The sniffer that does not need the OT stack, but need the otPlatRadio
interface, common scheduler, message queue, etc.
Then the sniffer needs to include libopenthread.a, which causes the
multiple definitions error. The mac and sniffer both use
otPlatRadioSignalReceiveDone.
Do we need to have a standalone library for the common functions that does
not related with the thread stack? Then other app could do not always need
to include the whole ot stack, while they do not need to use it, or only
part of it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/openthread/openthread/issues/60

There are two things to consider here:

The sniffer as a dedicated standalone app.
The core OpenThread library also providing IEEE 802.15.4 packet capture capability.

For 1, I don't think it makes any sense to have a dedicated sniffer app that links against libopenthread.a.  Instead, the dedicated sniffer app should just link against the C++ code in src/core directly.
For 2, it will be necessary to have both the full Thread stack along with sniffer capabilities compiled together with a single radio interface.

@jwhui , thanks for your clarification. I think that I can close this issue.


Corrected the cellml text in the sodium channel tutorial

PR to update the text of the sodium_ion_channel.cellml text to reflect the code used to produce the figures, and the equations in the text.

Ready for review/merge please @nickerso @agarny

Sorry @kerimoyle, but GitHub doesn't allow me to review your PR. @nickerso, anything that could be done about this?
This aside, the PR looks good, although it would be nice to have a link to the model that is actually used so we can properly review your changes. Right now, we have to "trust" you. :)

Haha, you don't have to trust me ... you could just read it the code and compare it to the equations in the text ;)  I just took the code from OpenCOR and copied it here verbatim.  The results from the solver look fine to me (though have used the published initial conditions, not the steady-state starting point which I think was used to create the original figures).  Here's my results: https://libcellml-tutorials.readthedocs.io/en/pr344_documentation/tutorials/tutorial7/tutorial7_cpp.html#run-the-model

Ok, also it's mathematically equivalent, there is a slight difference regarding the equation for alpha_m. Here, we have a multiplication by 0.1 while in your PR you have a division by 10. FWIW, it's computationally more efficient to have a multiplication by 0.1. Something similar for alpha_h and beta_h.
Otherwise, in your RTD, there is<EMAIL_ADDRESS>

Din't worry about my RTD, they're not ready for review yet, just to show
the outcome of my solver.  The only changes to this PR are taking the code
that's already here and copying the cellml text.  Any efficiencies or other
ways of doing things I haven't looked at at all ...
On Thursday, 19 December 2019, Alan Garny<EMAIL_ADDRESS>wrote:

Ok, also it's mathematically equivalent, there is a slight difference
regarding the equation for alpha_m. Here
https://libcellml-tutorials.readthedocs.io/en/pr344_documentation/tutorials/tutorial7/tutorial7_cpp.html#create-the-m-gate-component,
we have a multiplication by 0.1 while in your PR you have a division by 10.
FWIW, it's computationally more efficient to have a multiplication by 0.1.
Something similar for alpha_h and beta_h.
Otherwise, in your RTD
https://libcellml-tutorials.readthedocs.io/en/pr344_documentation/tutorials/tutorial7/tutorial7_cpp.html#run-the-model,
there is<EMAIL_ADDRESS>—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ABI-Tutorials/CellML-OpenCOR-PMR/pull/14?email_source=notifications&email_token=ALFXCNC5NJERO7MY3NWOXSDQZPKDVA5CNFSM4J5EOFO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHK2J5Y#issuecomment-567649527,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALFXCNFPMDF5VLSLZALL25LQZPKDVANCNFSM4J5EOFOQ
.

Sorry @kerimoyle, but GitHub doesn't allow me to review your PR. @nickerso, anything that could be done about this?

Done. I think :)

I would have thought that the raw cellml and the cellml text had the same
formulation? I haven't changed anything, just copied the code that was
there to get rid of the mistakes...?
On Thursday, 19 December 2019, Alan Garny<EMAIL_ADDRESS>wrote:

@agarny commented on this pull request.
Looks good, just my comment here
https://github.com/ABI-Tutorials/CellML-OpenCOR-PMR/pull/14#issuecomment-567649527
about the slightly different mathematical formulations.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ABI-Tutorials/CellML-OpenCOR-PMR/pull/14?email_source=notifications&email_token=ALFXCNDCA7PNFHD4PZUCKDLQZPSHZA5CNFSM4J5EOFO2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCP3N22I#pullrequestreview-334945641,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALFXCNBNGEKQOQ7K6LFK3BTQZPSHZANCNFSM4J5EOFOQ
.

I would have thought that the raw cellml and the cellml text had the same formulation? I haven't changed anything, just copied the code that was there to get rid of the mistakes...?

Not sure I am following you. I am comparing the code in source/cellml_encaps_and_inter.rst and source/resources/sodium_ion_channel.cellml (actually, why .cellml since it's actually a CellML Text representation of a real CellML file) compared with what I can read here and here.

I think need to compare to the models linked to from the tutorial rather than the libCellML tutorials that @kerimoyle is working on. e.g., via the OpenCOR link in the figure caption...

Agreed with @nickerso, but what is that model? Is it ../resources/tutorial7_SodiumChannelModel.cellml? That's the only reference I could find on RTD. If so, then it would be nice to have that CellML file reformatted. It makes it unnecessarily difficult to check its math.

This is the one from #13. It is given as an OpenCOR link in the figure caption at https://tutorial-on-cellml-opencor-and-pmr.readthedocs.io/en/latest/cellml_encaps_and_inter.html - which links through to  this SED-ML, which is in this PMR workspace. Which ends up with this version of the HH sodium channel: https://models.physiomeproject.org/e/430/sodium_ion_channel.cellml/view.

Thanks @nickerso, it looks good to me then.


Browsing Netflix catalogue is working, but videos can't be played

I'm submitting a ...

[x] bug report
[ ] feature request
[ ] support request

General infomration
Can't play any videos using plugin
Prerequisites

[x] Are you running the latest version? 0.13.12

Description
No videos playing.
Steps to Reproduce

Select Netflix Add-on
Browse catalog, select show, select episode
No fun :(

Expected behavior: Playing TV series
Actual behavior: Not playing
Context (Environment)
LibreELEC on RPi3
Installation

[ ] I installed the plugin via zip from the Releases page
[x] I´m using the Netflix Repo
[ ] I´m using a different source (Please tell which)

Operating System

[ ] Linux (x86/x64)
[ ] OSX (x86/x64)
[ ] Windows (x86/x64)
[x] Linux (ARM)
[ ] Android

Additional informatin on the environment
Using latest alpha of LibreELEC
Debug log
http://ix.io/1mCv

Widevine is not properly installed, so not a plugin issue. If it was installed via inputstreamhelper, you might suffer from #465. See there for a possible workaround.
 Remove it and let inputstreamhelper install it. If you're still experiencing issues, apply the workaround in #465.

@caphm thank you for your prompt answer!


CI: Enable PR previews using Surge

Pull Request Template
Description
This PR adds a new GHA workflow to deploy PR previews on Surge instead of Netlify, and restricting all functionality over GHA itself.
Fixes https://github.com/developersIndia/website/issues/155
Changes Include

[ ] Bug fix 🐛 (non-breaking change which fixes an issue)
[X] New feature ✨ (non-breaking change which adds functionality)
[ ] Breaking change 😢 (fix or feature that would cause existing functionality to not work as expected)
[X] Refactor ⚒ (code change that neither fixes a bug nor adds a feature)
[X] Tooling ⚙ (Changes to the build process or auxiliary tools and libraries such as documentation generation)
[ ] Performance ⚡ (code change that improves performance)- [ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
This workflow is used across various projects I have contributed to, like Devfiles and LocalStack and works perfectly!
Checklist

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have checked my code and corrected any misspellings

I've been busy lately (because my grandma passed away recently) but I took a brief look at it & the workflow looks legit. Would it work remains to be seen, so @HarshCasper can we discuss on Discord about testing the workflow on some weekend?
@Bhupesh-V do we've the bandwidth to move our workflow to Surge from Netlify?


Persistent Cache

Is your feature request related to a problem? Please describe.
Currently the LM cache is kept in memory of the python process. It would be nice to persist the cache to disk so that future programs can also benefit from historic queries.
Describe the solution you'd like
Support persisting the cache to disk.

Fixed in #57


Spacing

Spacing is all over the place. The header has a weird padding-bottom. Some things are centered, some are left-aligned, but the left-aligned sections have different paddings on the left. Spacing between sections is also rather arbitrary. The "Learn more about how we're different" and "Get in touch" buttons have slightly different heights. The aws logo looks much larger than the other ones. On the "members" page, the mozilla logo is wrapped on a new line on my screen, making it stand out.
I'd be willing to help with these problems, if that's okay.

Thanks for the offer! We'll be continuing to work on the website and I am willing to take some small changes but in general we don't have the personnel to support larger volunteer efforts at this time.
In general I would also encourage you to potentially file your issue with more empathetic language.

I'm sorry about the language, I didn't mean to offend anyone. English is not my native language, so I sometimes find it difficult to get the tone right.
I hope you'll reconsider accepting contributions. I'm very excited about the foundation and would like to help, if only by making the website more accessible :)


Update functions.php

To support docker container url

Manually merged via https://github.com/amphp/dns/commit/585acfaf7794e68e843295573bf4c8c5730ada61 into v0.9.x.


Inform user about option to turn off new version notifications

Add info about how to turn off new version notification, to the new version notification message ;-)

https://github.com/redhat-developer/odo/pull/792


[FEATURE] Pagination for Search page

Description
It would be great to add pagination for search page to enhance the performance, user experience and scalability of applications dealing with large datasets. It will enable efficient data retrieval, reduce network overhead, and simplifies data management.
Implementation

add Pagination component
implement pagination to search
show 20 results per page
add dynamic button to navigate different pages

Desired behavior

Screenshots
No response
Additional information
if the idea sounds good, I can take on it.

Good idea @badrivlog as requested I have assigned this to you.

Hey @SaraJaoude  i have started work on this. I think you didn't assigned this issue to me correctly as you mentioned. Please assign this to me.
Thank you.

Hey @SaraJaoude i have started work on this. I think you didn't assigned this issue to me correctly as you mentioned. Please assign this to me.
Thank you.

Now assigned @badrivlog

I think we need to move the searching and pagination to the API as part of this issue

I think we need to move the searching and pagination to the API as part of this issue

Yes we need API for search to move data filtration logic. My idea is request data based on input value and filter the data and then get that specific data from the db. Implement pagination for loaded data.
Can i do it like this?

Great 👍  yes get the mongo database to filter the data, it will be the most efficient 💯
There is also full text search, but this could be done as part of another issue, so this issue doesn't grow https://www.mongodb.com/docs/atlas/atlas-search/

Thank you for your most valuable guidance ❤

Thank you for improving this, it is a big task 💪 if you want to discuss or need any help, let us know - EddieHub Discord might be better
Also, I recommend creating a draft pull request early, so we can chat about the direction sooner

Hey @rajpatelbot thank you for your interest. but I've almost done the work with all the functionalities required. currently I'm double checking the code to ensure work for best afterwards i will create PR for this issue

@eddiejaoude
I wanted to bring your attention to a pull request I submitted #7748 I understand that you might be busy, but I would greatly appreciate it if you could take a moment to review my contribution.
If you have any concerns, suggestions, or feedback on the changes I proposed, I'm more than willing to incorporate them and improve the pull request accordingly. Your guidance and expertise would be invaluable to me as a beginner, and I'm eager to learn from your insights.
Thank you 🙏 for providing this opportunity for beginners like me to contribute to the project. Your guidance and feedback would be immensely helpful in my journey as a contributor.

Hi @badrivlog , apologies for the delay, I am a bit behind with GitHub notifications

I had a quick look, looks great, I left a few small comments - let's see if we can get it merged today or tomorrow 👍

I had a quick look, looks great, I left a few small comments - let's see if we can get it merged today or tomorrow 👍

made changes as you suggested 👍


runtime: invalid pc-encoded table f=runtime.exitsyscallfast

Background
Wallet recovery doesn't complete
Your environment

version of lnd
Version 0.4.2-beta commit=f1256ba41b033e62de2980b89bc7e278f76a0880
which operating system (uname -a on *Nix)
Linux bitcoin 4.9.0-6-amd64 #1 SMP Debian 4.9.88-1+deb9u1 (2018-05-07) x86_64 GNU/Linux
version of btcd, bitcoind, or other backend
bitcoin-0.16.2-x86_64-linux-gnu
any other relevant environment details

Steps to reproduce
Start lnd, lncli create with recovery mode.
Expected behaviour
Wallet recovery completed
Actual behaviour
Lnd exits with error:
lnd.log

Can you describe your situation in more detail? Hard to investigate from a single sentence.

I've attached the complete log. The lnd process is not running afterwards.
I'm still trying the wallet recovery for the issue #1141.

Which version of go are you using?

go version go1.10.3 linux/amd64

Can you try updating to go1.11 and trying again? Looks like this was an issue for ARM, but has been fixed since then.

With go1.11 the error did not reappear.


Response for request to '/task/report/create' was already committed (code=302)

I am upgrading from vm:true to env:flex (via appengine-web.xml) and get the following error on one of my routes.
WARNING: Response for request to '/task/report/create' was already committed (code=302). This might result in lost log messages.
I am using the latest version of the appengine maven plugin to deploy, and this is the auto generated app.yaml that it creates.
runtime: java
env: flex
module: 'report'
automatic_scaling:
  min_num_instances: 1
  max_num_instances: 5
threadsafe: True
auto_id_policy: default
beta_settings:
  'enable_app_engine_apis': 'true'
  'source_reference': '11db0552bf47f6f29b22ab9a2ac49c0858c81e44'
health_check:
  enable_health_check: False
  check_interval_sec: 10
resources:
  cpu: 2.0
  memory_gb: 7.0
api_version: '1.0'
handlers:
- url: (/.*/)
  static_files: __static__\1index.html
  upload: __NOT_USED__
  require_matching_file: True
  login: optional
  secure: optional
- url: (/)
  static_files: __static__\1index.html
  upload: __NOT_USED__
  require_matching_file: True
  login: optional
  secure: optional
- url: (/.*)
  static_files: __static__\1
  upload: __NOT_USED__
  require_matching_file: True
  login: optional
  secure: optional
- url: /.*
  script: unused
  login: optional
  secure: optional

skip_files: app.yaml

I get a similar error on /_ah/health but with a 403. I do not have a handler implemented in my application for that route.

I am not entirely sure this is relevant, but when I remove the following, it works.
<user-data-constraint>
    <transport-guarantee>CONFIDENTIAL</transport-guarantee>
</user-data-constraint>

Odd because it worked in vm:true, and simple routes that return a static response are unaffected by the addition/removal of the transport-guarantee


[BugFix]Fix select empty cloudnative table bug

Fixes #issue
add a cn into cluster;
create a cloudnative table t;
execute "select * from t";
report error : "Backend node not found. Check if any backend node is down.";
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

[FE PR Coverage Check]
:disappointed: fail : 1 / 2 (50.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/CoordinatorPreprocessor.java
1
2
50.00%
[783]

[FE PR Coverage Check]
:disappointed: fail : 25 / 60 (41.67%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/CoordinatorPreprocessor.java
16
49
32.65%
[556, 560, 561, 562, 563, 564, 565, 566, 796, 797, 798, 799, 800, 801, 802, 1993, 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001, 2192, 2193, 2194, 2195, 2196, 2197, 2198, 2199, 2200]

:large_blue_circle:
com/starrocks/qe/SimpleScheduler.java
8
10
80.00%
[91, 103]

:large_blue_circle:
com/starrocks/qe/Coordinator.java
1
1
100.00%
[]

[FE PR Coverage Check]
:disappointed: fail : 24 / 37 (64.86%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/CoordinatorPreprocessor.java
15
26
57.69%
[527, 528, 529, 530, 531, 532, 539, 540, 550, 551, 552]

:large_blue_circle:
com/starrocks/qe/SimpleScheduler.java
8
10
80.00%
[92, 104]

:large_blue_circle:
com/starrocks/qe/Coordinator.java
1
1
100.00%
[]

[FE PR Coverage Check]
:disappointed: fail : 43 / 62 (69.35%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/planner/OlapScanNode.java
5
9
55.56%
[397, 398, 402, 403]

:large_blue_circle:
com/starrocks/qe/CoordinatorPreprocessor.java
22
36
61.11%
[201, 420, 432, 439, 441, 452, 453, 454, 455, 456, 457, 501, 1381, 1383]

:large_blue_circle:
com/starrocks/qe/SimpleScheduler.java
11
12
91.67%
[102]

:large_blue_circle:
com/starrocks/planner/MetaScanNode.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/qe/Coordinator.java
1
1
100.00%
[]

@mergifyio backport branch-3.1

[FE PR Coverage Check]
:disappointed: fail : 35 / 54 (64.81%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/server/WarehouseManager.java
0
5
00.00%
[96, 97, 98, 99, 100]

:large_blue_circle:
com/starrocks/planner/OlapScanNode.java
5
9
55.56%
[397, 398, 402, 403]

:large_blue_circle:
com/starrocks/qe/CoordinatorPreprocessor.java
14
23
60.87%
[200, 415, 423, 430, 432, 443, 487, 1367, 1369]

:large_blue_circle:
com/starrocks/qe/SimpleScheduler.java
11
12
91.67%
[101]

:large_blue_circle:
com/starrocks/planner/MetaScanNode.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/qe/Coordinator.java
1
1
100.00%
[]

@mergify backport branch-3.1


TLF-11: Add start page for LMR

What

Added start page - TLF-11

Why

Added the landing page to match the design on Mural, as part of the flow for the LMR Phase 1 development

How

Added step to the index.js file in the /apps/lmr folder
Added HTML template to /views folder, including the links
Added variables in pages.json for populating the HTML template with the content

Testing

Tests passing locally

While I review the code, I have noted that below behaviour files,

clear-session.js
set-form-type.js

these are not configured and used in code. So ideally this can be removed.

I've removed these two behaviours now.


Add gallery entity

All images will belong to a gallery
content images will belong to a "content" gallery. This way devs can easily create/manage sites that do require a gallery. The requirement of a content gallery should add little overhead, and can be removed by the dev if they prefer.

Gallery added as a WIP. much work still needed

Completed PR #256


adapt some minigames to be playbable for different amounts of players

5a40c4bba84f3595a1f86d3897ea3df11912f9e0

decided to leave 2v2 out because of an unexpected 500 error a few hours before the deadline

2c22fe7036e01df0a2c3fd8070fb4faf7791a84e


Use a new approach to aligning labels with their table rows.  #1532

Use a new approach to aligning labels with their table rows that should reduce the round-off problems by forcing each row to the desired height, and doing the same with the labels.  Resolves issue #1532 (and #1500).

LGTM.


bump nginx to 1.9

Description
bumps nginx to 1.9.3
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Tested e2e. Will be tested manually before release
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 88.845%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
2031

Relevant Lines:
2286

💛  - Coveralls

/ok-to-test sha=ef29782


Zoom bug in semantic segmentation model

Describe the bug
In the semantic segmentation model, when you zoom in to annotate, leave the task and return to it, the annotations look empty. If you zoom in to the same level an annotation was made, they reappear and stay regardless of the zoom level. However, they disappear again on leaving and re-entering the task.
To Reproduce
Steps to reproduce the behavior:
Zoom in to annotate -> zoom out -> choose a different task -> go back to the previous annotated task
Expected behavior
The annotations should appear regardless of zoom level
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

OS: MacOS 11
Label Studio Version 1.1

Additional context
Add any other context about the problem here.

Yes. It seems to have been fixed. Thanks.


move gollm scripts into terarium

Description

Include a summary of the changes and the related issue.
Include relevant motivation and context.

Resolves #(issue)

LGTM, but packages/gollm/dev.sh does not work as expected.

what is wrong with it?

Everything works for me!


LibWeb: Bail from various navigable operations when no active window

If we end up in a situation where the navigable no longer has an active window, we can't perform navigation or many other navigable operations.
These are all ad-hoc, since the navigables spec is basically all written as if there's always an active window. Unfortunately, the active window comes from the active document's browsing context, which is a nullable concept even in the spec, so we do need to deal with null here.
This removes all the locally reproducible crashes when running WPT over the legacy Japanese encoding directory on my computer.
Yes, this is a bit of a monkey patch, but it should be harmless since we're (as I understand it) dealing with navigables that are still hanging around with related tasks queued on them. Once all these tasks have been completed, the navigables will go away anyway.

Seems to get rid of the encoding crashes when run locally on my machine ;^)
Results of running ./Meta/WPT.sh run encoding/legacy-mb-\*
Before:
Ran 1206 tests finished in 138.9 seconds.
  • 1193 ran as expected. 0 tests skipped.
  • 9 tests crashed unexpectedly
  • 1 tests timed out unexpectedly
  • 4 tests had unexpected subtest results

After:
Ran 1206 tests finished in 120.8 seconds.
  • 1202 ran as expected. 0 tests skipped.
  • 4 tests had unexpected subtest results


SO-3125: Resolve validation performance issues

https://snowowl.atlassian.net/browse/SO-3125
This pull request resolves validation performances by utilizing the jobs API, to async run multiple validation rules.

Thank you!


flashrom: Add libjaylink

Motivation for this change
WIP
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Depends on #140901

Oops, I just noticed that I added gcc9Stdenv to the patch which adds J-Link support. Fixed now.

What is left here? I would like to get this merged.

Result of nixpkgs-review pr 140902 run on x86_64-linux 1

1 package built:

flashrom

@Lassulus Thanks a lot!


Update sites.js

To add your site to the webring, you must be a current student or an alum of the undergraduate Software Engineering program at the University of Waterloo (Waterloo, ON, Canada).
Full Name: Elijah Kurien
Cohort Year: 2028
Full website URL: elijahkurien.com
So we know you're human:
LinkedIn or a similar profile: https://www.linkedin.com/in/elijahkurien/

Hey Simran – Made these changes to the sites.js! SE Webring will be pushed with my latest updates to my website where I flesh out each of my experiences. Is this okay?

@elijah0528 Thanks for the updates! Yeah, as long as you eventually add a link back to the webring somewhere on your site you should be fine.


Team work contract

Similar to what you did in DSCI 522, create a team-work contract. The contract should outline how you are committed to work together so that you are accountable to one another. Again, you may start with your team contract document from 522 and adapt it for your new team. It is a fairly personal document and please do not push it into your public repositories. Instead, save it somewhere your team can easily share it, and you can share a link to it, or a copy with us in your submission to Canvas to prove you did this.

Discussed and agreed by the team: https://github.com/UBC-MDS/DSCI-524-Group12/wiki/Team-Work-Contract


PrefixItems OpenAPI 3.1

https://json-schema.org/understanding-json-schema/reference/array.html#tuple-validation
Todo

[x] Add Tests
[x] Update Swagger-Zod to also include the prefixItems
[x] Make a list(docs) of all OpenAPI syntaxes we provide

very cool!!!!!


Implemented 8-bit cells

This honors values to stay within the 8-bit range of 0-256. This is the default for Brainfuck.
PHP's Modulo isn't a "true" modulo as it does not wrap negative values. Because if that I introduced a custom mod function.
The following script (which made use of going "negative") didn't work and now does:
-[------->+<#]#>+++.+[--->+<]>.------------.--.--[--->+<]>-.-----------.----.

Thank you for you contribution @Wouter0100 !


🏗 Flatten VuePress project

As mentioned in #291, maintenance could be easier by maintaining markdown directly rather than compiling from the defaults.yml file. The project becomes a simple VuePress project with a docs folder containing our content.
This could lead to more freedom in pages format as well as discussed in #206 and #221.
Also, yarn start now works to run VuePress in dev mode 🚀
That's a big breaking change and officially introduces macos-defaults v2 until more technical revamps 😄

Had to rollback Prettier to v2 because of https://github.com/vuejs/vuepress/issues/3165.
Looking good now. Probably a few things could be simplified next! I'll merge this right now :)


RFX Switch does not support all off button on nexa pet-910

Home Assistant release (hass --version):
0.39.3
Python release (python3 --version):
3.6.0
Component/platform:
Windows 10
Description of problem:
i have a nexa PET-910 remote and it has 3 on off buttons and one "all off button".
here are the id´s of all buttons using auto discovery:
switch:
  platform: rfxtrx
  automatic_add: True
  devices:
    0b110000015b026601010f80:
      name: remote1Button1
    0b110003015b026602010f80:
      name: remote1Button2
    0b11000b015b026603010f80:
      name: remote1Button3
#    0b110000015b026601030080:
#      name: remote1ButtonAllOff

now if i uncomment the all off button it does not show up in the gui, and pressing it uncommented or not does nothing.
Expected:
It should either show up as a separate switch or it should switch the other 3 off.

Have you tried hass --script check_config  the button is enabled?
And read this https://home-assistant.io/getting-started/troubleshooting-configuration/

As im running windows i can't run the hass command but i can use the py -m homeassistant --script check_config and it gives not output so im guessing everything is correct?
I have also used YAML Lint to verify my config file and no errors where found!


Documentation build on Windows

Currently building the documentation requires make. As a documentation developer I would like to be able to build the doc on Windows-based machines. The things that need to happen in order for this to work:

Convert Makefile to CMake
Convert doc/Makefile to CMake
Check that the sphinx and breathe, alongside genrest, work correctly on Windows

cc @ru-fu

sphinx already generates a bat script for windows, IMO we should use that instead of creating out own using cmake

@nashif but then we would have to have specific instructions per platform, and on top of that we need to run things like genrest.py. This allows us to have a single codebase to build on all platforms, and one that is consistent with our build system.


Convert Nibbles inner Vec to Bytes/ArrayVec

Convert the Nibbles inner type to Bytes or ArrayVec

@chirag-bgh we need to change how Nibbles are represented internally. You should change type of Nibbles::hex_data


Code review and refactor: split license find from license verification

api update:
LicenseLocationInfo should be removed from the original api (provide an overloaded method without that parameter, or a setter)

License retrieval has been split.

Implemented see locator package


Function name matches in ballerina/regex package does not follow function naming guidelines

It should have been named as match IMO. Can you please explain the rationale behind this function name?
Here is the current function signature.
function matches(string stringToMatch, string regex) returns boolean

Related to #2689

Honestly, I can't recall how we came up with the function name as matches. These functions came from the stringutils package[1] we had before. I think we referred to Java APIs when designing.  So, as you said, it should be the match function.
We will look into this. Maybe we can depreciate this API introduces a new API by correcting the name.
Thanks for pointing this out.

https://github.com/ballerina-attic/module-ballerina-stringutils/blob/master/stringutils-ballerina/natives.bal

Let's deprecate this method in Swan Lake Update 1

@kalaiyarasiganeshalingam Please look into this

As per comment[1], we are going to leave matches as is. Hence closing this issue.

https://github.com/ballerina-platform/ballerina-standard-library/issues/2689#issuecomment-1062545173


fix: Move sources and javadoc plugins to release profile

Fixes #110

Thanks, @aalmiray, for your fix


Cachix socket failure

post-build-hook: Failed to connect to Cachix Daemon
post-build-hook: Tried to connect to: /Users/runner/work/_temp/cachix-daemon-dUkDHy/daemon.sock
post-build-hook:
post-build-hook: cachix: Network.Socket.connect: <socket: 23>: does not exist (Connection refused)
error: program '/Users/runner/work/_temp/cachix-daemon-dUkDHy/post-build-hook.sh' failed with exit code 1

https://github.com/fedimint/fedimint/actions/runs/8911648208/job/24473403024#step:6:131

Mac isn't self-hosted though afaik.

https://github.com/cachix/cachix-action/issues/185
Hopefully this gets fixed soon, dependabot will update this action automatically, will re-open if it still is bothering us.


Try telling who is requesting missing package

Problem
When requested package reqires a packge that is missing, error message only tells what was missing, but not telling which package has that requirement. Unless you crawl the resolving log with verbose enabled.
For example:
>rez-env maya-2020 nice_pipeline
00:37:26 ERROR    PackageFamilyNotFoundError: package family not found: foo (searched: /path/to/packages)

Proposal
When PackageFamilyNotFoundError occurred, catch it internally and look up extracted requirements to find the dependent and re-raise another a bit more detailed PackageFamilyNotFoundError.
Result:
>rez-env maya-2020 nice_pipeline
00:37:26 ERROR    PackageFamilyNotFoundError: package family not found: foo, was required by: maya (searched: /path/to/packages)

love this idea. I think allan is back from vacay maybe next week, I bet this is a quick merge and I would find very useful.

I really like this too, simple and saves time trawling through rez env --verbose

Since I find #972 is also a helpful idea and much related with original implementation, I refactored the code and the logic can be shared in both cases.
Here is my test cases, and the output would be as follows:
Conflict on merge
====================
The context failed to resolve:
The following package conflicts occurred: (dep==1 <--!--> dep==2)
	dep==1: foo==1
	dep==2: bar==1

Conflict on intersect
====================
The context failed to resolve:
The following package conflicts occurred: (kai==1 <--!--> kai==2)
	kai==1: tom==1
	kai==2: -

Conflict on intersect (deeper)
====================
The context failed to resolve:
The following package conflicts occurred: (python==2 <--!--> python==3)
	python==2: pymel==2 <-- maya==2020 <-- pipeline==1
	python==3: houdini==18

Required package not found
====================
package family not found: oops, was required by: dummy==1|==2 (searched: memory@any)

Required package not found (deeper)
====================
package family not found: oops, was required by: dummy==2 (searched: memory@any)

There are a few issues here that make this not quite so straightforward. I like the idea though, but I think it has to be refined. The following are in order of severity:
1: It costs something to run _dep_info, and that's bad, because DependencyConflict objects can be created many times in any given solve. This will slow down the solver, adding info to a potentially large number of DependencyConflict objects that never get seen - because it's quite normal for a solve to go through many phases before the final, accepted phase is found. Basically this is adding an extra performance cost to every attempted solve phase, when you only want to see that info in the final phase, and if the solve failed. Any solution that adds extra contextual info to a conflict, needs to do so after the solve has finished, so it doesn't add cost to successful solves. In other words, it needs to be derived from the solve graph.
2: Dependency info is shown as a chain, but this doesn't reflect what's actually going on, since dependencies in the solve graph are parts of the DAG. For example, consider:
The following package conflicts occurred: (python==2 <--!--> python==3)
	python==2: pymel==2 <-- maya==2020 <-- pipeline==1

This may be true, but may also be disguising the fact that this is also true:
The following package conflicts occurred: (python==2 <--!--> python==3)
	python==2: pymel==2 <-- maya-2020+<maya-2020.1 <-- floob==1.2.3

3: Similar to (2), the PackageFamilyNotFound error is not taking into account that multiple packages may have requested the missing package.
I think we need to target this PR specifically at the PackageFamilyNotFound case for the moment. Performance is not an issue here because the exception is raised and the solve ends there. We only need to show the immediate packages that requested the missing package, and that doesn't require the generic _dep_info function.
In terms of what to do about (1) and (2), we can talk about that in a separate PR specifically made for that case. My 2c on that is that we should be able to generate a list of chains for each conflicting requirement, because this shows the right info (it's basically showing multiple flattened paths in a DAG). We can also do this post-solve. I don't think it's as bad as it seems though, and I think there may be an elegant solution.
What you really need to do is get the solve graph (see Solver.get_graph), and extract all the conflict paths from that. There are three benefits to doing it this way:

There remains just one function that generates graph info from the solve;
This will also work for "total reduction" type failures, which this PR does not take into account;
This will show info that this PR is missing - the actual package requests in the chain. Ie whereas a chain shown in this PR might be foo-1 --> python==2.7.3, the actual chain is more likely to be something like foo-1 --> python-2 --> python==2.7.3. Because you're deriving the chain from extractions only, the requires info (ie that foo requires python-2 in this eg) can be lost (eg, in cases where multiple extractions overlap and are merged).

I'm going to close this PR, as I want to get into the habit of doing that rather than leaving loads of PRs hanging. But as I said I think this is headed in the right direction, and a PR targeted at the PackageFamilyNotFound case should be straightforward.

Thanks Alan, great hints ! ❤

3: Similar to (2), the PackageFamilyNotFound error is not taking into account that multiple packages may have requested the missing package.

I'll submit another PR that only focusing on PackageFamilyNotFound, which will be based on commit 4c51335 plus above point fixed.
And yes, I'll go check out the graph and try that again. 👍🏼

Thanks @nerdvegas for the information and @davidlatwe for trying to do an initial implementation.
Originally I opened #972 so I can have a go at it someday. It's more clear now, with the feedback from https://github.com/nerdvegas/rez/pull/971#issuecomment-728667415,  on things to look out for when implementing it


[MM-58780] Don't account for scaleFactor on Windows when resizing if the matching screen is the primary monitor

Summary
Further to the fix I did for the Electron bug here: https://github.com/electron/electron/issues/10862
The primary monitor on Windows doesn't need to care about the scale factor, and will respect it when resetting its window bounds. This PR checks to see if the primary monitor is the matching screen and won't use the scaleFactor if the windows bounds aren't set.
Ticket Link
https://mattermost.atlassian.net/browse/MM-58780
Closes https://github.com/mattermost/desktop/issues/3067
Fixed an issue where the window size will get smaller on Windows after a restart if the primary monitor is used and is scaled

Harshil is out so you may want to get another reviewer


Problem initializing default value for flag from code

Doing this in the code:
    define_flag context : String,
      description: "",
      default: Dir.current,
      short: x

Shows up in the terminal like this:
  --context, -x (default: Dir.current)

Hello,
Same here. Have you found a solution or a work around?


Use colon operator instead of Cons

Use the infix operator instead of the Cons constructor to clean up the code, especially because it remove a lot of parenthesis.
Modify the Show instance to use the infix operator instead of Cons:

> show (1 : 2 : 3 : Nil)
"(1 : (2 : (3 : Nil)))"

Personally, I like this better than
"(Cons 1 (Cons 2 (Cons 3 Nil)))"

Maybe it would even close #43.

👍 Looks good.
I think it would be nice to use intercalate ":" in the show instance to reduce the unnecessary parens though, if possible.

I think it would be nice to use intercalate ":" in the show instance to reduce the unnecessary parens though, if possible.

Oh right, this is much better. Now it looks like this:
> show (1 : 2 : 3 : Nil)
"(1 : 2 : 3 : Nil)"

👍  Thanks!

Thanks!


update roadmap for 2024

Remove return address proposal which had no activity/development.
Mark Haveno as completed.
Remove ring size task which is duplicate of Seraphis.
Add "proposed task" status.

Add ideas from Monero Research Lab

^ updated the commit description
https://deploy-preview-2310--barolo-time-757cf9.netlify.app/resources/roadmap/
LGTM

Thanks! Some initial thoughts:

We could link the open mrl open research issue as the only proposed task https://github.com/monero-project/research-lab/issues/94 (Rucknium is in MRL and we can let them maintain/update that list appropriately)
FCMP++ can be listed (linking to kayabanerves recent blog) as on-going. https://www.getmonero.org/2024/04/27/fcmps.html
eth-xmr swaps are "completed" but the last update in their matrix room was that not many people came forward to test. But this is my unqualified opinion. I think bch-xmr should be listed as also on-going. Last i seen they where working on a monero web wallet. Depends how we define completed : a swap on main/testnet or a working gui/cli that has peers to swap.with which we can link users to.
we also seen an MVP xmr-ltc testnet atomic swap from kayabanerve @ https://bounties.monero.social/posts/112/21-050m-xmr-to-ltc-atomic-swap but  im not sure of any projects integrating/actively working on it  (early days)
monerod rust implementation - Cuprate

we also seen an MVP xmr-ltc testnet atomic swap from kayabanerve @ https://bounties.monero.social/posts/112/21-050m-xmr-to-ltc-atomic-swap but im not sure of any projects integrating/actively working on it (early days)

xmr <> ltc has been working via basicswap for a long time. Currently uses adaptor sigs

tbh XMR-BCH doesn't look very completed to me.
and work on Seraphis not started should i change it to planned?

@nahuhh since when? for adding to roadmap

@nahuhh since when? for adding to roadmap

Just saw this.
ltc<>xmr has been live on basicswap since dec 2022

We can get some MRL input on removing tych. That open ccs was refunded to the GF a while ago

Triptych should be removed. Its not ongoing nor upcoming. Iirc it evolved into lelantus spark and seraphis

edited excerpts without full context from an informal chat in monero lounge regarding layer2's below: (which is being deleted in this PR)
<kayabanerve> [...] FCMP++s enable some PCNs as Seraphis (the protocol) would.
<kayabanerve> So we are indirectly working on those, even if I don't support the enabled instances I know of.

Rucknium mentions cores intentions of making layer 1 scale and "Since 7 years ago, a few papers on Monero payment channels have been published. No production code implementing them AFAIK"
My thoughts on layer2's are that this was probably added because it's a popular buzzword and people bring it up a lot

LWS subaddress support was completed as of Dec 2023

@nahuhh  do you have link for it?

https://github.com/vtnerd/monero-lws/commit/b4426b4a74f1ab83f076288c34816447bc1577ba
I spoke with vtnerd to confirm subaddress support

didn't add the commit link, not very useful for the roadmap

The ETH<>XMR atomic swaps should likely move to completed as well. I'm not sure the date. I think May 2023, but need to double check

bumping this:
Went from prerelease to release in may 2023
Tldr: BCH is marked as completed, so eth should be as well.

The ETH<>XMR atomic swaps should likely move to completed as well.

plowsof:

Depends how we define completed : a swap on main/testnet

this is how id define completed ^.  liquidity or consumer grade tooling isn't essential to completion.

I'm personally ok with listing both BCH and ETH as completed. I don't believe we waited for [unstoppableswaps] before considering BTC<>XMR as complete, but considered "complete" to imply that the protocol was functional

finally


Powertoys failing to run shell commands

Microsoft PowerToys version
0.57.2
Running as admin

[X] Yes

Area(s) with issue?
PowerToys Run
Steps to reproduce
I installed it using the exe from https://github.com/microsoft/PowerToys/releases/tag/v0.57.2
then after I ran it. the first thing I tried was run a command line command (echo hello using > echo hello) but it gave me this error.

✔ Expected Behavior
it should run the command
❌ Actual Behavior
but it gave me this error.
no command line commands are working

echo is not a Windows shell command, it's a Command Line command.
The shell plugin works a bit more like if you typed it in the Run dialog (Win+R) for example. echo can't be run from there, as well.

echo is not a Windows shell command, it's a Command Line command. The shell plugin works a bit more like if you typed it in the Run dialog (Win+R) for example. echo can't be run from there, as well.

I typed > any command line command here as far as I heard that should run a command line command

The "shell" plugin runs shell commands.

The "shell" plugin runs shell commands.

the what about this command line command

ok I got it I am such a dumbass

sorry

It sort of behaves like a command line for most cases, so the confusion is not that much of a stretch ;)
Thank you for the feedback.


Running pnpm test locally results in import/no-unresolved errors

When I run pnpm test locally, eslint fails with this import rule. In other projects, I often disable this import error since typescript already checks imports and more reliably.
I'm not suggesting to disable the rule here necessarily, but I would like to figure out how to fix it. And also, I'd like to understand how it succeeds in CI. I tried doing a fresh install of all my node_modules and still got the same errors
...

/Users/tyler/gitspace/waku/packages/create-waku/template/24_nesting/src/components/InnerApp.tsx
  1:26  error  Unable to resolve path to module 'react'  import/no-unresolved

/Users/tyler/gitspace/waku/packages/create-waku/template/24_nesting/src/main.tsx
  1:28  error  Unable to resolve path to module 'react'             import/no-unresolved
  2:41  error  Unable to resolve path to module 'react-dom/client'  import/no-unresolved

✖ 66 problems (66 errors, 0 warnings)

@himself65 is this something you'd be familiar with?

remove template files, it’s old and copy during build step

Awesome, thanks!


Request for example using ResizeGroup

Category
[x] Enhancement
[ ] Bug
[ ] Question
Version
Latest
Expected / Desired Behavior / Question
I use the Pivot component a lot but am always concerned about the width on the page.
Then today I stumbled upon the ResizeGroup example and think it would be really helpful option.
Unfortunately I can't figure out how to reverse engineer that example in my webpart.
The biggest part is where do I find this file?
import * as stylesImport from './ResizeGroup.Example.scss';
Thanks for considering an example I can actually build/test!

Based on the latest version of Fluent UI docs which had a working CodePen sample, I was able to reverse engineer the referenced scss file by just incorporating my the css directly in my own file:
const styles = mergeStyleSets({
    root: {
      display: 'block',
    },
    resizeIsShort: {
        width: '400px',
      },
    settingsGroup: {
      paddingTop: '20px',
    },
    itemCountDropdown: {
      width: '180px',
    },
  });


typechecker: Cache struct IDs for internally used classes

This makes us avoid repeatedly searching in the project's structs for
internally used structs by caching their IDs the first time they're seen
in the global namespace.

I'm not really a big fan of the .unwrap() everywhere, can we just put those inside the actual helper methods so we're not unwrapping values everywhere else in the code?

Seconding @mustafaquraish = .unwrap() is a bit of a "code smell"

The intention was something like "if we ever get a chance to actually display this to the user beyond a panic, make it as simple as replacing those unwraps with an err = err.or(error)", but I see your point. Will fix.

The intention was something like "if we ever get a chance to actually display this to the user beyond a panic, make it as simple as replacing those unwraps with an err = err.or(error)", but I see your point. Will fix.

I don't think this is a case we necessarily want to handle as a compiler error. If everything has gone right we should never hit this error, otherwise something went wrong in including the prelude. Even previously we weren't treating this as a compiler error but just panicking the program with the .expect(...)

Even gcc reports its internal errors with detailed information about what caused it tot crash, so I don't see why we shouldn't also give some info to the user to aid debugging. :^)

This has a conflict. Also I agree the unwrap() looks silly. :)


Initialize the Website

Intialise the project by using create-react-app.
Include:

[x] Typescript
[x] storybook
[x] README  file
[x] License

Done


Close google chrome after flow ends - try updating tagui

Hello!
I have this question.
How can I close google chrome after flow ends?

Hi @fjchavez by default google chrome will close after the flow ends. Does your google chrome not close? Can you check with version of TagUI you are running on, by running the tagui command in command prompt or terminal.

Hi @ruthtxh ,
The version is tagui v6.74. My OS is Windows 11.
I made these changes in tagui
// Changed tagui.cmd to open google chrome in incognito: chrome_switches=--user-data-dir=chrometagui_user_profile --incognito --remote-debugging-port=9222 about:blank
// Changed tagui_parse.php in setDownloadBehavior from allow to default
Maybe it is because of these changes? If so, how do I make it close keeping these changes?

Hi @fjchavez
Can you try updating tagui and see if the error persists? You can update by running tagui update from the command prompt.

Closing issue due to lack of updates, feel free to reopen.


fix(plugin): match erase/add_entry behavior with libs

In the built-in libs tables, erasing a nonexistent entry is an error, while adding an entry that overwrites an already existing one is fine.
Since there's no explicit spec for this, AFAICT, let's align our tables to that behavior as well.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area ci

/area event

/area event_derive

/area plugin

/area plugin_api

/area plugin_derive

/area plugin_tests

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: gnosek
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [gnosek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 1a0b47367d1b686c2d93222eb6c2021d27975db6

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: gnosek, mrgian
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [gnosek,mrgian]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/approve


mediapipe version <IP_ADDRESS>

Hi,
looking to run your code, but I get an error when trying to install mediapipe==<IP_ADDRESS> as follows:

ERROR: Could not find a version that satisfies the requirement mediapipe==<IP_ADDRESS> (from versions: 0.10.5, 0.10.7, 0.10.8, 0.10.9, 0.10.10, 0.10.11)
ERROR: No matching distribution found for mediapipe==<IP_ADDRESS>

Im running in a conda env in widnows...

Hi @delray,
Can you tell me the python version you are using ?

I tried 3.11 3.9 and 3.7 and got the same error on each one

Hi @delray,
Can you try with mediapipe==0.10.15 on python=3.10.13 ?


Clean up orders to be more deterministic

Where we sort by a set of values that can be equal and conflict, it uses arbitrary database ordering (usually based on "when was this row last edited" but not always). This is inconvenient as it means some things can float around in lists. We should fix this by making sure orders are unique.
Example locations (incomplete list):

[ ] character lists only sort by lowercased character names; these should probably sort next by screenname and then by ID, but the middle part is optional here

Fixed in #680


ScaledReordered interface

This PR adds an interface for wrapping an inner operator (like a direct or iterative solver) into a (for now symmetrical, e.g. RCM) reordering via a reordering factory and diagonal scaling via one row and one column scaling diagonal matrix.
The ScaledReordered LinOp applies the given scaling and reordering to the system matrix and generates the inner operator on the modified problem. It manages three vectors, a right-hand side and a solution vector for the inner operator, and an intermediate vector used for the permutations.
With a permutation matrix P, a row scaling matrix R, and a column matrix C, the system matrix and vectors are scaled and permuted such that instead of the original system of equations
A*x = b
the inner operator solves
P*R*A*C*P^T*y = P*R*b.
Hence, when generating a ScaledReordered LinOp, the new system matrix P*R*A*C*P^T is computed. When it is applied to vectors b and x, the right-hand side vector is modified to P*R*b, and the solution y to the inner system gives the solution x to the original system via x = C*P^T*y.
When using an inner operator that uses an initial guess, currently the initial guess for the inner system is computed by y_0 = P*C^(-1)*x_0, which is the same as using x_0 for the system P*R*A*x = P*R*b. For the inverse diagonal scaling here I added an inverse_apply to the matrix::Diagonal. I still need to add tests for that.
Any feedback is welcome, especially on ideas regarding how to handle algorithms like RCM that generate a reordering, but also be able to handle MC64 that generates both a reordering and scaling coefficients and simpler equilibration techniques that only generate scaling coefficients.

format!

format!

AFAIR, combing scaled and reordered together allows some algorithms uses only one operation.
how do you do that when a new LinOp?

AFAIR, combing scaled and reordered together allows some algorithms uses only one operation. how do you do that when a new LinOp?

At the moment, not at all. So far the operations are not merged yet.

will the merged operations be in this class or another class inherited from this class?
if there's another class, the clone will only give the clone of ScaledReordered class not itself.

format!

Depends on  #1171  now.

Ready to merge after #1171