fix the starctl exit too soon due to grep

What this PR does:
Fixing the starctl script not working on Linux. Explanation:

script has set -e on line two which means exit on any error
grep returns exit code 1 in case nothing is found, thus this is considered as error and aborts

Why and how this works in the original cassandra script I don't know.. But it could be that the bang here is #!/bin/bash and in https://github.com/apache/cassandra/blob/trunk/bin/cassandra it's #!/bin/sh..
On my machine now:
$ ./starctl --cluster-name test --cluster-version 4.0 --developer-mode
Running java -server -Dstargate.libdir=./stargate-lib -Djava.awt.headless=true -jar ./stargate-lib/stargate-starter-1.0.76-SNAPSHOT.jar --cluster-name test --cluster-version 4.0 --developer-mode
[INFO] JAR DIR: ./stargate-lib
[INFO] Loading persistence backend persistence-cassandra-4.0-1.0.76-snapshot.jar
[INFO] Installing bundle persistence-cassandra-4.0-1.0.76-SNAPSHOT.jar
[INFO] Installing bundle animal-sniffer-annotations-1.9.jar
[INFO] Installing bundle asm-7.1.jar
[INFO] Installing bundle asm-analysis-7.1.jar
[INFO] Installing bundle asm-tree-7.1.jar

And with following command:
ise        93180  128  3.1 16446184 1030656 pts/4 Sl+ 14:42   0:23 java -server -Dstargate.libdir=./stargate-lib -Djava.awt.headless=true -jar ./stargate-lib/stargate-starter-1.0.76-SNAPSHOT.jar --cluster-name test --cluster-version 4.0 --developer-mode

Then after installing sudo apt-install libjemalloc2 I get correct startup and command:
ise        93961  163  1.6 10342596 531792 pts/4 Sl+  14:45   0:09 java -server -Dcassandra.libjemalloc=/usr/lib/x86_64-linux-gnu/libjemalloc.so.2 -Dstargate.libdir=./stargate-lib -Djava.awt.headless=true -jar ./stargate-lib/stargate-starter-1.0.76-SNAPSHOT.jar --cluster-name test --cluster-version 4.0 --developer-mode

Thanks, I realized that I missed a test - running starctl on Linux when libjemalloc is not present.


Swagger type for "Extension.uses" property seems to be incorrect

The swagger.json file has the type of the Extension.uses property as an OptionalInt. But when the BE returns this property the type is number. The Connection, ConnectionOverview, and Connector types also have the uses property and should also be checked.

Maybe we should just coerce OptionalInt to number, as that's really what it is for the UI, a number attribute that may or may not be present in the response.

I've been doing it this way: extension.uses as number. The value seems to always be present for the customization objects. Should I be doing this in a different, safer way maybe? Like checking first to see if it is actually a number.

it's fine that way I'd say


Help fix broken / ignored unit tests or other analytics!

After merging #3856 one unit test class, TypeRegistryTest, intermittently stalled during local testing. It may be fine on some OSes or in Jenkins, but oddly it stalled even with the @Ignored annotation added to the tests. It would be good if a few different people to re-enable those tests and run them locally several times (one at a time, all three at once, etc) and make sure they don't stall - if not then we can re-enable and I'll just blame my workspace.
Additionally at present we skip 7 tests in EntityAwareWorldProviderTest and another 7 in ParallelTest for reasons of the past I don't remember off the top of my head, but the files and Git / GitHub history may help shed some background info on that topic.
Finally there are two tests in the ModuleTestingEnvironment that are getting stuck in infinite loops for me testing locally in LocalChunkProvider.checkForUnload() - not sure that'd relate to these changes. ClientConnectionTest and ExampleTest
Beyond unit tests there are plenty of other code analytics that result in issues, although the stats are still only published in our new Jenkins which isn't exposed publicly yet, although regular contributors can request access any time for some insight. In the meantime you can run gradlew check locally and find an abundance of warnings :-)
In Jenkins specifically unit tests tend to fail if they involve a game environment, #3415 has the details and it would be a lovely thing to fix as well.
Marking Good First Issue as these topics are all mildly unrelated to anything else and decent detective hunts for curious contributors, even if they aren't necessarily going to be easy!
Edit: there is also a weird issue where SpotBugs works for some modules but not others, resulting in no build/reports/spotbugs directory. I saw an error related to it at one point, but forgot where. It showed both locally and in Jenkins so it shouldn't be hard to replicate if looking across a few modules. Pretty sure Pathfinding had the failure. Could run gradlew spotbugsMain to selectively just run SpotBugs in a workspace then go looking for which modules made that build dir or not.

Wanted to leave this link here as well: https://github.com/jenkinsci/warnings-ng-plugin/blob/master/doc/Documentation.md
It goes a bit beyond the origin of this issue, but beyond hooking analytics back up in the new Jenkins at all there are so many options floating around for how we could do more. I also tried to enable the Sonarsource web scanner but while it worked fine for one project dynamically making it figure out multiple from one set of config / add more as needed without manual action might take a bit more work

How's the code coverage? I've worked with JUnit and Mockito before and would be happy to work with unit tests.

Hi @lizzyd710! ... well, we have some! 😁
But 700+ tests barely make a dent in the engine project here when it comes to percentage coverage, then there are oodles of modules and other side projects. We're always low on tests - any assistance writing more would be really appreciated!

In TypeRegistryTest I uncommented the @Test annotations (but not the @Ignored) and none of them stalled for me. Here's my results:

testModuleTypes(): Passed, 6s 356ms
testNonModuleTypes(): Ignored, 4s 141ms
testWhitelistedTypes(): Ignored, 2s 795ms

(Also using Windows 10)

Sure, at this point I'm less worried about the tests stalling in our Jenkins server, since that'll get tested as part of a PR now. Previously when I ignored things and wrote this issue we were still trying to get our build server up and running properly :-)

Is this issue still open?

Generally yes. It does need a decent bit of investigation first, though. But sure, go ahead, give it a try and ideally first drop your findings about broken or ignored tests in here before starting to try to fix them :wink:

when building with java-11 it ends with:
❯ gradle clean build
...
> Task :subsystems:TypeHandlerLibrary:spotbugsTest
M B PI: The used identifier ?>?2/2??? as field name in class org.terasology.persistence.typeHandling.InMemorySerializerTest$TypeGetter.STRING in source file ?>?3/2??? shadows the publicly available identifier from the Java Standard Library.  In InMemorySerializerTest.java
M C EC: Using .equals to compare two byte[]'s, (equivalent to ==) in org.terasology.persistence.typeHandling.coreTypes.factories.BytesTypeHandlerTest.byteArraySerializeDeserialize()  At BytesTypeHandlerTest.java:[line 42]
M C EC: Using .equals to compare two byte[]'s, (equivalent to ==) in org.terasology.persistence.typeHandling.coreTypes.factories.BytesTypeHandlerTest.byteArraySerializeDeserialize()  At BytesTypeHandlerTest.java:[line 45]
M C EC: Using .equals to compare two byte[]'s, (equivalent to ==) in org.terasology.persistence.typeHandling.InMemorySerializerTest.serializeBytes()  At InMemorySerializerTest.java:[line 309]
M C EC: Using .equals to compare two byte[]'s, (equivalent to ==) in org.terasology.persistence.typeHandling.InMemorySerializerTest.serializeByteBuffer()  At InMemorySerializerTest.java:[line 338]
H C RV: org.junit.jupiter.api.Assertions.assertThrows(Class, Executable) not thrown in org.terasology.persistence.typeHandling.InMemorySerializerTest.serializeString()  At InMemorySerializerTest.java:[line 82]
H C RV: org.junit.jupiter.api.Assertions.assertThrows(Class, Executable) not thrown in org.terasology.persistence.typeHandling.InMemorySerializerTest.serializeStrings()  At InMemorySerializerTest.java:[line 113]
H C RV: org.junit.jupiter.api.Assertions.assertThrows(Class, Executable) not thrown in org.terasology.persistence.typeHandling.InMemorySerializerTest.template(PersistedData)  At InMemorySerializerTest.java:[line 136]
H C RV: org.junit.jupiter.api.Assertions.assertThrows(Class, Executable) not thrown in org.terasology.persistence.typeHandling.InMemorySerializerTest.serializeBoolean()  At InMemorySerializerTest.java:[line 255]
H C RV: org.junit.jupiter.api.Assertions.assertThrows(Class, Executable) not thrown in org.terasology.persistence.typeHandling.InMemorySerializerTest.serializeBytes()  At InMemorySerializerTest.java:[line 319]
H C RV: org.junit.jupiter.api.Assertions.assertThrows(Class, Executable) not thrown in org.terasology.persistence.typeHandling.InMemorySerializerTest.serializeByteBuffer()  At InMemorySerializerTest.java:[line 348]
H C RV: org.junit.jupiter.api.Assertions.assertThrows(Class, Executable) not thrown in org.terasology.persistence.typeHandling.InMemorySerializerTest.serializeNull()  At InMemorySerializerTest.java:[line 392]
H C RV: org.junit.jupiter.api.Assertions.assertThrows(Class, Executable) not thrown in org.terasology.persistence.typeHandling.InMemorySerializerTest.checkIsArray(PersistedData)  At InMemorySerializerTest.java:[line 434]
H C RV: org.junit.jupiter.api.Assertions.assertThrows(Class, Executable) not thrown in org.terasology.persistence.typeHandling.InMemorySerializerTest.checkIsNumber(PersistedData)  At InMemorySerializerTest.java:[line 458]
H C RV: org.junit.jupiter.api.Assertions.assertThrows(Class, Executable) not thrown in org.terasology.persistence.typeHandling.InMemorySerializerTest.checkValueArray(PersistedData, PersistedData, Set)  At InMemorySerializerTest.java:[line 486]
H C RV: org.junit.jupiter.api.Assertions.assertThrows(Class, Executable) not thrown in org.terasology.persistence.typeHandling.InMemorySerializerTest.lambda$checkValueArray$8(Executable)  At InMemorySerializerTest.java:[line 512]
H C RV: org.junit.jupiter.api.Assertions.assertThrows(Class, Executable) not thrown in org.terasology.persistence.typeHandling.InMemorySerializerTest.lambda$checkValueArray$4(Executable)  At InMemorySerializerTest.java:[line 497]
M P UuF: Unused field: org.terasology.persistence.typeHandling.coreTypes.factories.ObjectFieldMapTypeHandlerFactoryTest$SomeClass.t  In ObjectFieldMapTypeHandlerFactoryTest.java
M P SIC: Should org.terasology.persistence.typeHandling.FutureTypeHandlerTest$ResultCaptor be a _static_ inner class?  At FutureTypeHandlerTest.java:[lines 41-50]
M P UuF: Unused field: org.terasology.persistence.typeHandling.coreTypes.factories.ObjectFieldMapTypeHandlerFactoryTest$SomeClass.list  In ObjectFieldMapTypeHandlerFactoryTest.java
SpotBugs ended with exit code 1

> Task :subsystems:TypeHandlerLibrary:spotbugsMain
SpotBugs ended with exit code 1

i'll give to fix these ones a try.


Add changes

Its not working yet because for some reason the context popup isn't showing but the logic is there

Putting this here so I don't lose it: https://hesambayat.com/how-to-create-dialog-boxes-with-react-hook-and-react-context/


Cannot find namespace in 'JSX'

When using stencil @one I get the following error.

Probably has to be compiled and published to npm using the new stencil one

I also have the same when trying to stencil router

Updates the @stencil/router


Use currentSrc instead of src for picture stories

fixes #38
tested locally in Firefox 85 on MacOS

Hi, @GianpaMX
I tested this change and it can't run on macOS Firefox 85. The Img has no currentSrc attribute.
Thanks feedback this bug. I fixed it use srcset.


Put checker.jar on processor path.

Also, create separate checkTypes tasks, one for each source set, that runs a checker.

I'm going to fix this so that the Checker Framework is run using a different task and ErrorProne is run for the standard compileJava tasks.

@smillst It looks like this isn't yet ready, because I don't see any use of the checkerframework*.gradle files.

@smillst It looks like the tests are failing with an infinite loop.


heco  chain

Can you explain how to add heco chain to gnosis safe?

Could you elaborate on your question @sd2020bs and provide some more information?


Card with empty body and only actions is not rendered

Platform
What platform is your issue or question related to? (Delete other platforms).

Android

Author or host
Host MS Teams
Version of SDK
Latest Master
Issue
Card with only buttons and empty body do not render on Android but work fine on HTML renderer .
{
	"$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
	"type": "AdaptiveCard",
	"version": "1.0",
	"body": [
	],
	"actions": [
		{
			"type": "Action.ShowCard",
			"title": "Set due date",
			"card": {
				"type": "AdaptiveCard",
				"body": [
					{
						"type": "Input.Date",
						"id": "dueDate",
						"title": "Select due date"
					},
					{
						"type": "Input.Text",
						"id": "comment",
						"isMultiline": true,
						"placeholder": "Add a comment"
					}
				],
				"actions": [
				    {
				        "type": "Action.OpenUrl",
						"title": "OK",
						"url": "http://adaptivecards.io"
			        }
				]
			}
		},
		{
			"type": "Action.OpenUrl",
			"title": "View",
			"url": "http://adaptivecards.io"
		}
	]
}

Merged


[FR] More detailed stock status

Please verify that this feature request has NOT been suggested before.

[X] I checked and didn't find a similar feature request

Problem statement
I want to track the stock status especially of used parts in a more detailed manner and not just "Ok", "Damaged", ... so that I can later use that information with a e-commerce software to display the status to the user.
Suggested solution
I want to specify specific categories where I can rate the stock.
E.g.:

Name
Rating

Technical working
1-6

Optical appearance
1-6

But I'm not sure where and how to implement that, curious about your thoughts.
Describe alternatives you've considered

Add that to the stock notes in a defined format
Use a custom plugin with metadata or AppMixin and a custom model

Examples of other systems
No response
Do you want to develop this?

[X] I want to develop this.

I think that to support this (and other users have request custom stock status codes too) we would need to reconsider how the stock status is handled entirely.
Currently, the "status" field is included in the decision of "is this stock item available" or "in stock". So, a "quarantined" item is not in stock, but a "damaged" item is. So, it affects core InvenTree business logic. Extending this field to allow custom values would make this very difficult to manage.
So, I do not have an immediate solution to this. But I think that we would potentially need to move away from the "status" value actually having an impact on business logic. Especially if users want custom values here to use to track properties of the stock item

Maybe we can set the business logic state on a user defined status code. E.g. Ok means available, and damaged, quarantized, ... not available. Where ok, damaged, ... can be user defined and each assigned a business logic group (available/not available)
But I do not think that would solve my needs. Maybe I'm best with using a panel plugin in combination with metadata or a custom model.

Removing the logic is probably difficult / a step back - not being able to use damaged stock for example is a very useful thing. But adding custom display states that are free text but always coupled to a business logic state should be very easy.
This is also is probably a duplicate of https://github.com/inventree/InvenTree/issues/4289 thinking more about it

I think it's a bit different to stock status, I want to rate the stock in multiple categories, but not just one select. But after thinking a bit more about it, it seems like it's a niche use case, so I'll use a plugin and we can close this.


[BUG] This engine instance already disposed when using InsertBulk

Version
Windows 10, >=5.0.20 (was working fine in 5.0.15), .Net Framework 4.6
Describe the bug
After updating to the new version I get the exception
LiteDB.LiteException: 'This engine instance already disposed'
Lets say I get 10 tasks and iterate through them then the exception comes on "Next" after processing the first Task object.
I think it has to do with the update of the TaskExecution collection in between but it was always working in at least 5.0.15. I updated to 5.0.20 because of bug #2351
A workaround is to declare listExecs before the For loop and do the InsertBulk afterwards. Nevertheless, it was working fine in 5.0.15 and it should not dispose the engine instance.
Code to Reproduce
Using db As New LiteDB.LiteDatabase($"Filename={DBLiteName};connection=shared")
Dim tasks = db.GetCollection(Of Task)("Task").FindAll
Dim execs = db.GetCollection(Of TaskExecution)("TaskExecution")

For Each myTask As Task In tasks
    Dim listExecs As New List(Of TaskExecution)
    Dim hist As New TaskExecution With {
        .TaskID = myTask.Id
    }
    listExecs.Add(hist)
    execs.InsertBulk(listExecs)
Next
End Using

Expected behavior
Code should iterate through all Tasks found and insert objects of type TaskExecution to the collection
ScreenshotsStackTrace:
LiteDB.LiteException
HResult=0x80131500
Message=This engine instance already disposed.
Source=LiteDB
StackTrace:
at LiteDB.Engine.EngineState.Validate()
at LiteDB.BsonDataReader.Read()
at LiteDB.SharedDataReader.Read()
at LiteDB.LiteQueryable1.<ToDocuments>d__26.MoveNext()    at System.Linq.Enumerable.WhereSelectEnumerableIterator2.MoveNext()

Are you able to reproduce the error without sharedmode?

Hi Jonas
It looks like I was using LiteDB incorrectly. Up until version 5.0.15 I was successfully using the code below without the "ToList" function. According to the official documentation, I should have used ToList. Not sure why it was working in earlier versions or maybe not using ToList was based on a comment a read somewhere in order to improve performance or reduce memory consumption - I can't remember.
I updated my code and no further problems so far. In addition, the other Issue #2351 no longer occurs.
Dim tasks = db.GetCollection(Of Task)("Task")
For Each tsk As Task In tasks.FindAll.ToList
tasks.Update(tsk)
Next
Many thanks
Martin


Difficulty with basic initial setup of powercalc

I'm having a hard time getting powercalc past an initial initialization.
Config

Dockerized HASS 2022.08.03
HACS installed powercalc (v0.24.8, v0.24.7, and v0.25.0-beta4 all tested with same results)

Configuration (with extension changed for GH support) configuration.yaml.
Setup always fails with what looks like a YAML parsing error. See
logs.txt.
Config check (docker exec homeassistant python -m homeassistant --script check_config --config /config) passes and attempts to relocate the powercalc block, add manual config entries, and configuring via the UI all result in the same error.
I'm sure I'm missing something basic (I'm a new HASS user), but I'm at a loss as to what. I've worked with folks on the HASS Discord and haven't had any success. Thanks in advance for the help!

Pretty sure your problem is with this piece of YAML configuration:
sensor:
  platform: emoncms
  api_key: !secret emoncms_api_key
  url: http://emonpi.local/emoncms
  id: 1
  sensor_names:
      30: "Living Room Temp"
      31: "REDACTED"
      32: "Kitchen Temp"
      33: "Basement Temp"
      34: "Dining Room Temp"

That needs to be:
sensor:
  - platform: emoncms
    api_key: !secret emoncms_api_key
    url: http://emonpi.local/emoncms
    id: 1
    sensor_names:
      30: "Living Room Temp"
      31: "REDACTED"
      32: "Kitchen Temp"
      33: "Basement Temp"
      34: "Dining Room Temp"

I wil handle this better in powercalc component so you don't get a cryptic error like this.

That was totally the issue. Thank you very much for the help! I'll leave this open as it looks like you want to improve the logging, but my issue is resolved! 🥳

better error handling is already implemented. Closing this issue.


Subtracted 1 from the number of rows, to prevent text from being cut …

…off at bottom when scrollable. Solves issue #2468
PR is ready to be merged. I think this is the correct solution for the problem related to the issue #2468.
I've tested with powershell and it is working as it should.

This might be only a temporary fix, as it is probably related with this xterm issue

Hey there, please try again with the new Hyper v2 release we picked up the xterm version that fixes this.


Very broken on Firefox

It is nice to see a WE extension manager on Firefox, but it seems to be a too direct port, because it is very broken at the moment.
What works:

List itself
Filtering (search)
Extension settings

What doesn't:

Extension icons (except for this extension's)
Fonts (compared to screenshot)
Enabling-disabling
Buttons "disable all" and "more..."

Tested on DevEd 57.0b14 and Nightly 58.0a1 (2017-11-03) on Ubuntu 17.10.

Wow, I didn't know it was posted on Mozilla Addons.
@HangYang can you add me as a developer on AMO? I'm user bfred_it

@bfred-it sorry, was testing AMO uploading and publish this accidently...

Crazy, Firefox doesn't support this at all:
Only extensions whose 'type' is 'theme' can be enabled and disabled

Source: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/management/setEnabled
Bugzilla to keep an eye on: https://bugzilla.mozilla.org/show_bug.cgi?id=1282982

Ha... I think Firefox will support it soon... maybe after all of the extensions on AMO becomes webextension

does it work for now ? 😀

You can check the last link I posted, from bugzilla.


Create doc comments

There were still a few files where normal comments (//) instead of doc comments (///) were used. I replaced (hopefully all of) them with doc comments where ever it was suitable.
Otherwise nothing should have changed.

@lucalewin Thanks for the PR! I've did some documentation cleanup at another PR as well, so that one will conflict with this one, but I'll merge yours first.


*: add codegen for version/version.go

cc/ @hasbro17

Test:
fanmins-MacBook-Pro:operator-framework fanminshi$ operator-sdk new test-operator
Create /Users/fanminshi/work/src/github.com/operator-framework/test-operator/cmd/manager/main.go
Create /Users/fanminshi/work/src/github.com/operator-framework/test-operator/pkg/apis/apis.go
Create /Users/fanminshi/work/src/github.com/operator-framework/test-operator/pkg/controller/controller.go
Create /Users/fanminshi/work/src/github.com/operator-framework/test-operator/pkg/build/Dockerfile
Create /Users/fanminshi/work/src/github.com/operator-framework/test-operator/pkg/build/build.sh
Create /Users/fanminshi/work/src/github.com/operator-framework/test-operator/deploy/role.yaml
Create /Users/fanminshi/work/src/github.com/operator-framework/test-operator/deploy/role_binding.yaml
Create /Users/fanminshi/work/src/github.com/operator-framework/test-operator/deploy/operator.yaml
Create /Users/fanminshi/work/src/github.com/operator-framework/test-operator/scripts/codegen/Boilerplate.go.txt
Create /Users/fanminshi/work/src/github.com/operator-framework/test-operator/version/versions.go
Run dep ensure ...
could not find project Gopkg.toml, use dep init to initiate a manifest
2018/09/20 15:27:00 failed to exec dep []string{"ensure", "-v"}: exit status 1
fanmins-MacBook-Pro:operator-framework fanminshi$ cat test-operator/version/versions.go
package version

var (
	Version = "0.0.1"
)

LGTM


Support for quotes and replies

Hi. I have been using this bot for a couple of months and I really like it. One thing I think would be nice is if the bot could interact with quotes and replies. For example if I quote or reply to someone else's message with "@my_example_bot translate this" it should translate the quoted/replied message. Is this possible? Thank you in advance.

Do you mean to use it in a group chat?

Yes, that's why I said while quoting or replying to someone else's message.

Sounds like a good idea,I'll try tomorrow.

The dev branch has already added this feature, you need to add an environment variable to activate it. EXTRA_MESSAGE_CONTEXT = "true"

Thank you! It seems to be working as intended.


[Bug]: failed to debug or execute PL object

ODC version
4.2.1
OB version
not related
What happened?
I create a pl object, such as procedure, which only contains out parameters.
eg.
create or replace procedure pl_debug_proc3(p1 out integer)
as
begin
p1 := 1234;
end;

I try to execute it and an exception is thrown:

by the way, this pl can be executed successfully by anonymous block.

What did you expect to happen?
execute this pl successfully.
How can we reproduce it (as minimally and precisely as possible)?
follow 'what happened'
Anything else we need to know?
No response
Cloud
No response

the front end gives an error request which leaks anonymousBlock

further more, failed to execute a pl without any parameters:

which is normal on odc 4.2.0

Fixed In Commit 91dabffcdc65bf8a9c9091c411337e61977ce526
------
晓康
Wed Oct 18 11:48:04 2023 +0800

Fixed In Commit 91dabffcdc65bf8a9c9091c411337e61977ce526 ------ 晓康 Wed Oct 18 11:48:04 2023 +0800

😂 404 not found

pass


Dart null safety

There is this new feature in dart that requires dart code to be null safety?
Any plans to support that?

Duplicate of #1673


P 31: missing '#' in line 8

Thanks for your work

Thanks for the report. Can you detail where is the missing #?

in
31. How to ignore all numpy warnings (not recommended)?
the line:
An equivalent way, with a context manager:
must start with a "#" as first char.

Thanks. Can you make a PR?


The Anitube extension has stopped working on Aniyomi. But the site is still up.

Steps to reproduce

1- Open Aniyomi.
2- Open any anime from the Anitube Library.
3- Try starting an episode.
Expected behavior
Start the episode.
Actual behavior

Video keeps loading and gives error.
Crash logs
No response
Aniyomi version
<IP_ADDRESS>
Android version
Android 14
Device
Samsung
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extension's repository.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

If this is an issue with an extension, I should be opening an issue in the extension's repository.

Se isso for um problema com uma extensão, devo abrir um problema no repositório da extensão.

I don't understand

Your opening an issue about an extension in the repo for the app. You're in the wrong place

Open an issue in a repo where that extension is being maintained. We don't associate with extensions anymore, so we can't/won't tell you where exactly

Open an issue in a repo where that extension is being maintained. We don't associate with extensions anymore, so we can't/won't tell you where exactly

GitHub correct?

If the people maintaining the extensions are using github, sure

Se as pessoas que mantêm as extensões estiverem usando o github, claro

So you are telling me to talk about my problem on the website where I downloaded the anime extension "Anitube". for Aniyomi?

Eu já disse para você perguntar onde está sendo mantido

How the hell am I supposed to know where this extension is being kept!?

That's up to you to find. I already told you that we don't associate with extensions anymore and will not say where they're being maintained


server: Add "objectId" to /api/event/:id

Needed for https://github.com/serlo/api.serlo.org/issues/92
Here is the only exception, where objectId is defined differently:
            case 'discussion/create':
                return [
                    '__typename' => 'CreateThreadNotificationEvent',
                    'actorId' => $event->getActor()->getId(),
                    'threadId' => $event->getObject()->getId(),
                    'objectId' => $event->getParameter('on')->getId(),
                ];

Making this into a draft PR until the contracts are live.


Added an of(size:) method to the Font enum.

Added a utility method, of(size:), to the Font enum so that you can get a UIFont instance right from the enum value.

Codecov Report

Merging #4 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
+ Coverage   93.27%   93.32%   +0.04%
==========================================
  Files           3        4       +1
  Lines         535      539       +4
==========================================
+ Hits          499      503       +4
  Misses         36       36

Impacted Files
Coverage Δ

UIFontComplete/Font.swift
100% <100%> (ø)

UIFontCompleteTests/UIFontCompleteTests.swift
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17ecc85...20e14e6. Read the comment docs.

@jrtibbetts Thanks! This is awesome! LGTM!

@Nirma, you're quite welcome. This pod is a great idea.


[WIP] Convert AuthKey operations to SupportsFeatureMixin

[ ] https://github.com/ManageIQ/manageiq-ui-classic/pull/7876
[ ] https://github.com/ManageIQ/manageiq-api/pull/1080
[ ] https://github.com/ManageIQ/manageiq-providers-amazon/pull/722
[ ] https://github.com/ManageIQ/manageiq-providers-ibm_cloud/pull/287
[ ] https://github.com/ManageIQ/manageiq-providers-openstack/pull/733

@miq-bot cross-repo-test /all, ManageIQ/manageiq-ui-classic#7876, ManageIQ/manageiq-api#1080, ManageIQ/manageiq-providers-amazon#722, ManageIQ/manageiq-providers-ibm_cloud#287, ManageIQ/manageiq-providers-openstack#733

taking out of WIP since the cross-repo tests (https://github.com/ManageIQ/manageiq-cross_repo-tests/pull/497) are passing.


Configuration for the console plugin to choose levels. Fixes #391.

For example:
Raven.addPlugin(require('raven-js/plugins/console'), console, ['error']);

Would you mind changing the 3rd parameter to be an object, options? (Then extract levels from options.)


PermissionError: [Errno 13] Permission denied: 'c:\programdata\anaconda3\lib\site-packages\conda-4.6.8-py3.6.egg-info\PKG-INFO'

The fact accessing this fails due to permission isn't related to the extension, please check your permissions, closing this.


Added Python 2 and (more) Windows support.

Python 2 support:

Add print_function and input imports
Add a check before os.makedir() because in Python 2 there is no argument
exists_ok

Windows support:

Change os.environ['HOME'] to os.getenv() with a default to
os.path.expanduser('~') because there was no such variable on Windows.
Ubuntu was fine.
If on Windows, message will ask for CTRL-Z instead of CTRL-D because
of... windows behavior with EOF.

0 entries crashing:

The script was crashing if you tried to see notes and there were none. It
now checks for 0 len entries and says that there are none.

Hey @dvdme
Thanks for contributing!
I suggest some changes though

Should it be from __builtin__ import input instead of builtins. Was giving me an import error when I tried it with the latter.

input()

This should work too for backwards compatibility
try:
    input = raw_input
except NameError:
    pass

What do you think!
Do take a look at #3. @BrandtM has done some cool addons.

@dvdme Please update your branch with the master before adding any feature or git will throw a Merge conflict

The ImportError was because I had to install the future module.
Adding future to requirements.txt should solve it but your solution also works fine.
Keep either one.

Are you referring to from __future import print_function?

No, I had to pip install future for from builtin import input to work, at least on Python 2

Not sure why you had that issue.
But this works for me
tasdik at Acer in ~
$ python2
Python 2.7.8 (default, Jun 18 2015, 18:54:19)
[GCC 4.9.1] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import sys
>>> sys.version
'2.7.8 (default, Jun 18 2015, 18:54:19) \n[GCC 4.9.1]'
>>> from __future__ import print_function
>>>

Ohk. The try method is the go to option then I guess.

Yes, the try method avoid issues with having to install the future module.
I agree.

Feature added in commit 2a6064e79d80e980b2bb2726fd0d6a57cddce1de


How to set response type to text on a request filter

Have you read the FAQ and checked for duplicate open issues?
Yes, but I didn't found a duplicate.
What version of Shaka Player are you using?
2.5.11
Please ask your question
I need to know how to modify the request made by Shaka when requesting the DRM license to use Fairplay. I need to set the response type to text but I don't find the way to do it since the request object that the request filter receives does not have any place to override the response type of the request.
Thanks

What do you mean by response type?  Are you trying to request a specific response type from the server? Are you trying to interpret the response in a certain way, or parse it as text?  I'm having trouble understanding your question, because response type sounds like part of the response, not part of the request.

Sorry if I am not clear. What I am trying to do is request a specific response type from the server, with type text.

I don't know what that means in general terms.  Is there a specific request header you want to send?  Or a specific parameter or other thing the server is expecting?  We can help you customize the request however you need, but I don't yet understand what you need.

If you are talking about the xhr.responseType field, this is just how the browser interprets the response.  The server always sends the same data, that field is used to auto convert the bytes to a string.  We always accept as bytes and have utilities in shaka.util.StringUtils to convert to a string if needed.

@TheModMaker is right. I was confused due to a previous experience with another media player that I used. I was able to make it work without any special configuration. Thank you for the help.

Glad we could help!


Add additional blending modes

Linear Light

I recently added them to my addon library as well and I think MM could make  use of these as well. I took them from here:
https://www.shadertoy.com/view/XdS3RW

Hey, this would be my first contribution here. Just wanted to ask if technically I did everything correctly. I would add all the other blend modes from the source if everything is done right until now.

Nice one @paddy-exe! I was actually needing hard mix today. You should probably add this into the documentation page as well. https://github.com/RodZill4/material-maker/blob/master/material_maker/doc/node_filter_blend.rst
Maybe we should consider adding more detailed information about each blend mode to that page or have a separate page with more info.

@Arnklit Thanks! Good to hear. I added the docs node additions. I think it would help if the blending modes would be explained directly in the blend node documentation even if it would mean a lot of information on one page. Perhaps an example picture showing the effect of the mode?


Fix the broken anchor, links and typo of zh-TW

@AllThingsSmitty
I did some fix of the translation.
Also, the heading is translated into traditional chinese, so the original anchors are broken.
I have fixed that.
Sorry for the mutiple commits.
@SamSSY Please check this.  Hope it help :)
https://github.com/lockys/awesome-search
https://awesomelists.top/#/repos/AllThingsSmitty/jquery-tips-everyone-should-know

@lockys thanks!


Add HomerRong's file

created a branch, created a file and made a commit, and opened a pull request


fix(modal): use role=dialog

Seeing what some others do:

react-aria-modal uses role="dialog" on dialog body and aria-hidden="true" on body
Antd uses role="dialog" on mask and role="document" on modal body, no aria-hidden/aria-modal
Atlaskit uses role="dialog" on dialog body, no aria-hidden/aria-modal
Material uses role="document", no aria-hidden/aria-modal
Blueprint has no roles or aria attributes

Latest w3c aria spec for modals recommends role="dialog" and aria-modal="true", so I'll stick with that for now given the inconsistency among all the other implementations.
Some more details on aria-modal


problems/others: add go code for minsteps

Codecov Report

Merging #26 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #26   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          14     15    +1
  Lines         306    336   +30
=====================================
+ Hits          306    336   +30

Flag
Coverage Δ

#go
100% <100%> (ø)
:arrow_up:

#javascript
100% <ø> (ø)
:arrow_up:

Impacted Files
Coverage Δ

problems/other/mxsteps/mxsteps.go
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5a9565...a24af1c. Read the comment docs.


Bugfixes/dedupe viewmodels

Changes in this pull request
Issue fixed: #700
Checklist

[X] All tests pass. Demo project builds and runs.
[X] I added tests, an experiment, or detailed why my change isn't tested.
[X] I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.
[X] I have reviewed the contributing guide

@rnystrom What do you think of the PR? Happy or prefer more changes necessary?

Awesome, this looks good to me! I'm going to make a few changes myself b/c I've made you wait too long on this ha. Sorry for the delay! Really great work here.

@weyert quick request for next PR, update your Xcode whitespace settings to these. It'll remove all the newline whitespace stuff.

Sure, will do! Didn't know it existed :) What are the changes you had in mind?


[Feature Request] :latest tag for docker registry

I tend to run my dev environments on docker and use docker-compose to manage them. I was surprised that the :latest tag was missing from the docker registry, adding it would be great to keep sendria up to date with every release by updating the docker image .

The
$ docker run -p 1025:1025 -p 1080:1080 msztolcman/sendria

from the README does not work, so this works:
$ docker run -p 1025:1025 -p 1080:1080 msztolcman/sendria:v<IP_ADDRESS>

Yes, a latest tag would be great :-)


Validate credit cards

[ ] Visa
[ ] Mastercard
[ ] Elo
[ ] Diners
[ ] Hipercard
[ ] Amex

@dleitee
Close here. ;)

@rdiego26 Thank you!!!


Add "Notifications on this device" in the settings

The IOS client allows to disable the notifications for only the current client.
It would be nice to have the same behaviour on the android client

fixed in
https://github.com/vector-im/vector-android/commit/d8e45b7f2fb1a32e50be8527695b02e7778b83ba


Remove mTLS enablement via service annotation.

See #5826.

@yangminzhu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
4cceed6f42ff7baed70d81ea1266c0106f99e96f
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
7dacdd7f019240eb3c1892fcfc3d1fc8b210d33d
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
7dacdd7f019240eb3c1892fcfc3d1fc8b210d33d
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
7dacdd7f019240eb3c1892fcfc3d1fc8b210d33d
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
7dacdd7f019240eb3c1892fcfc3d1fc8b210d33d
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
7dacdd7f019240eb3c1892fcfc3d1fc8b210d33d
link
/test e2e-bookInfo

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
ff285afa3ddf49da835d1fc514061a1e421c1fb2
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
7dacdd7f019240eb3c1892fcfc3d1fc8b210d33d
link
/test e2e-bookInfo

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
ff285afa3ddf49da835d1fc514061a1e421c1fb2
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
ff285afa3ddf49da835d1fc514061a1e421c1fb2
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
ff285afa3ddf49da835d1fc514061a1e421c1fb2
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
ff285afa3ddf49da835d1fc514061a1e421c1fb2
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
ff285afa3ddf49da835d1fc514061a1e421c1fb2
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
ff285afa3ddf49da835d1fc514061a1e421c1fb2
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
ff285afa3ddf49da835d1fc514061a1e421c1fb2
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
ff285afa3ddf49da835d1fc514061a1e421c1fb2
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
ff285afa3ddf49da835d1fc514061a1e421c1fb2
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
ff285afa3ddf49da835d1fc514061a1e421c1fb2
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
ff285afa3ddf49da835d1fc514061a1e421c1fb2
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
ff285afa3ddf49da835d1fc514061a1e421c1fb2
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
ff285afa3ddf49da835d1fc514061a1e421c1fb2
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
ff285afa3ddf49da835d1fc514061a1e421c1fb2
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@yangminzhu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
ff285afa3ddf49da835d1fc514061a1e421c1fb2
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: yangminzhu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
Assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS
pilot/OWNERS
tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
ff285afa3ddf49da835d1fc514061a1e421c1fb2
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
daf68b860e8c691784c33a082140ed0c62043624
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
daf68b860e8c691784c33a082140ed0c62043624
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
daf68b860e8c691784c33a082140ed0c62043624
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
daf68b860e8c691784c33a082140ed0c62043624
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
daf68b860e8c691784c33a082140ed0c62043624
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
2e0ecc78fdbf98056676aa18553ce42870509b67
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
daf68b860e8c691784c33a082140ed0c62043624
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
2e0ecc78fdbf98056676aa18553ce42870509b67
link
/test e2e-simple

prow/istio-pilot-e2e.sh
2e0ecc78fdbf98056676aa18553ce42870509b67
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
2e0ecc78fdbf98056676aa18553ce42870509b67
link
/test e2e-simple

prow/istio-pilot-e2e.sh
2e0ecc78fdbf98056676aa18553ce42870509b67
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
a2e47f592e6902dbff1f1460bf9eab8c62fc033a
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
2e0ecc78fdbf98056676aa18553ce42870509b67
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
a2e47f592e6902dbff1f1460bf9eab8c62fc033a
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
a2e47f592e6902dbff1f1460bf9eab8c62fc033a
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
2e0ecc78fdbf98056676aa18553ce42870509b67
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
a2e47f592e6902dbff1f1460bf9eab8c62fc033a
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
a2e47f592e6902dbff1f1460bf9eab8c62fc033a
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
a2e47f592e6902dbff1f1460bf9eab8c62fc033a
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
2e0ecc78fdbf98056676aa18553ce42870509b67
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
a2e47f592e6902dbff1f1460bf9eab8c62fc033a
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
a2e47f592e6902dbff1f1460bf9eab8c62fc033a
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
a2e47f592e6902dbff1f1460bf9eab8c62fc033a
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
a2e47f592e6902dbff1f1460bf9eab8c62fc033a
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
a2e47f592e6902dbff1f1460bf9eab8c62fc033a
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
a2e47f592e6902dbff1f1460bf9eab8c62fc033a
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
a2e47f592e6902dbff1f1460bf9eab8c62fc033a
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
a2e47f592e6902dbff1f1460bf9eab8c62fc033a
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
a2e47f592e6902dbff1f1460bf9eab8c62fc033a
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
a2e47f592e6902dbff1f1460bf9eab8c62fc033a
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
a2e47f592e6902dbff1f1460bf9eab8c62fc033a
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
a2e47f592e6902dbff1f1460bf9eab8c62fc033a
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
a2e47f592e6902dbff1f1460bf9eab8c62fc033a
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
cf4d84a938a5a8b3376d2235628dfd6d0af44782
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
a2e47f592e6902dbff1f1460bf9eab8c62fc033a
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
a2e47f592e6902dbff1f1460bf9eab8c62fc033a
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
a2e47f592e6902dbff1f1460bf9eab8c62fc033a
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
cf4d84a938a5a8b3376d2235628dfd6d0af44782
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
cf4d84a938a5a8b3376d2235628dfd6d0af44782
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
a2e47f592e6902dbff1f1460bf9eab8c62fc033a
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
a2e47f592e6902dbff1f1460bf9eab8c62fc033a
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
cf4d84a938a5a8b3376d2235628dfd6d0af44782
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
cf4d84a938a5a8b3376d2235628dfd6d0af44782
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
cf4d84a938a5a8b3376d2235628dfd6d0af44782
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
a2e47f592e6902dbff1f1460bf9eab8c62fc033a
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
cf4d84a938a5a8b3376d2235628dfd6d0af44782
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
cf4d84a938a5a8b3376d2235628dfd6d0af44782
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
cf4d84a938a5a8b3376d2235628dfd6d0af44782
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
cf4d84a938a5a8b3376d2235628dfd6d0af44782
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
cf4d84a938a5a8b3376d2235628dfd6d0af44782
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
cf4d84a938a5a8b3376d2235628dfd6d0af44782
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
cf4d84a938a5a8b3376d2235628dfd6d0af44782
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
cf4d84a938a5a8b3376d2235628dfd6d0af44782
link
/test e2e-simple

prow/e2e-bookInfoTests-v1alpha3.sh
cf4d84a938a5a8b3376d2235628dfd6d0af44782
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
cf4d84a938a5a8b3376d2235628dfd6d0af44782
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
cf4d84a938a5a8b3376d2235628dfd6d0af44782
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
cf4d84a938a5a8b3376d2235628dfd6d0af44782
link
/test e2e-simple

prow/e2e-bookInfoTests-v1alpha3.sh
cf4d84a938a5a8b3376d2235628dfd6d0af44782
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
cf4d84a938a5a8b3376d2235628dfd6d0af44782
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
cf4d84a938a5a8b3376d2235628dfd6d0af44782
link
/test e2e-simple

prow/e2e-bookInfoTests-v1alpha3.sh
cf4d84a938a5a8b3376d2235628dfd6d0af44782
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
cf4d84a938a5a8b3376d2235628dfd6d0af44782
link
/test e2e-simple

prow/e2e-bookInfoTests-v1alpha3.sh
cf4d84a938a5a8b3376d2235628dfd6d0af44782
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
cf4d84a938a5a8b3376d2235628dfd6d0af44782
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test e2e-bookInfo

prow/e2e-bookInfoTests-v1alpha3.sh
237f1092ce5824c8cd0cc5ec616ebf8cad3a83af
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4543bad1b34242e6948bb586f564587a6fb941b2
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-pilot-e2e-envoyv2-v1alpha3

@yangminzhu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
aec386e1caf910284bea81bdd0ec2d5881d397e4
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
Approval requirements bypassed by manually added approval.
This pull-request has been approved by: yangminzhu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS
pilot/OWNERS
tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Add OSZ TIEM

Institution/School Name
OSZ TIEM
Instiution/School Website
osztiem.de
Email Users
Please place an x between the square brackets if yes

[x] Students (in some cases)
[x] Academic/Teaching Staff
[ ] Other/Support Staff
[ ] Alumni

Education Levels
Please place an x between the square brackets if yes

[ ] Post-graduate research
[ ] Graduate School
[x] College (University) or Undergraduate School or equivalent
[ ] Community College or equivalent
[ ] High School or equivalent
[ ] Elementary School or equivalent

@BigROba Pull request merged. Thank you!


Email me whenever you bill my credit card

I just got charged $10, which is fine, but you really need to send me a receipt via email when this happens.  And for extra credit, warn me the day before in a separate email.
This is why I think you need to do this:

Everybody else sends email receipts.  That's really the main reason.  It's a convention now that if you charge somebody's card, especially in an offline background process, you send an email receipt.

It is way easier for me to forward an email to a bookkeeper than it is to log in to a site, save an HTML page and then forward that.  I consider gittip donations a marketing-related business expense.

If you warn me first, it might reduce chargebacks / fraud complaints / failed charges.  You can put a link in the warning email back to my account so that I can immediately cancel my giving.

Keep up the good work!

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/454131-email-me-whenever-you-bill-my-credit-card?utm_campaign=plugin&utm_content=tracker%2F85909&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F85909&utm_medium=issues&utm_source=github).

+1 https://gratipay.freshdesk.com/helpdesk/tickets/1733


Doing more libiberty test compat...

Coverage increased (+0.004%) to 90.944% when pulling a12263283e43711e9773095a72c0d1f3fb52e4f9 on libiberty-test-compat into 6e0abf6dd1e7b24a868531b0a7b59dc9164fc18c on master.


⚠ Ixtanet SAT has degraded performance

In 30103ae, Ixtanet SAT ($MEDIA_SAT) experienced degraded performance:

HTTP code: 200
Response time: 20578 ms

Resolved: Ixtanet SAT performance has improved in 47032e3.


⚠ ClamAV has degraded performance

In c251244, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 71 ms

Resolved: ClamAV performance has improved in abd2064.


Health Check/Sanity Check

We noticed today that our ALB ingress controller was reaped several times by the k8s health checker -- however, the logs suggested the controller was up and responding the in the reconcile loop. When we port-forwarded to the pod and tried to load the /healthz endpoint, we experienced the connection hanging / no result from the health check endpoint.
At a minimum, I think it might be worth setting an HTTP client timeout -- if unset, the default aws config uses an http client without a connection timeout.
Because the ALB controller leaves this unset, it uses the default client:
https://github.com/kubernetes-sigs/aws-alb-ingress-controller/blob/master/internal/aws/cloud.go#L82
Which leaves the health check endpoint susceptible to a hung connection:
https://github.com/kubernetes-sigs/aws-alb-ingress-controller/blob/master/internal/aws/healthcheck.go#L16-L19
Setting a timeout would at a minimum let the controller respond to the health check, and give us logs sooner when an endpoint hangs. And maybe this also gives the sdk a chance to retry before k8s decides the pod is unhealthy. I'd be happy to open a PR if that sounds reasonable!
Somewhat of a tangent -- if the health check finds an AWS service (or the network) is unhealthy, should that actually cause the pods to be labeled unhealthy and get restarted?  I've got a mixed opinion. As the operator, I'd want to get notified, but at the same time, the restart behavior doesn't resolve the issue and is triggering an unrelated crashloop alert.
Perhaps we could collect stats out of band, like the number of AWS API calls failing (or reconcile loops failing), and use those stats to determine the health/liveliness?

Hi @mothershipper
Thanks for reporting this.
I agree that the current healthy check mechanism is not correct. we should only do such AWS service-api checks at controller startup if required. reboot the controller pod via healthCheck won't solve aws service unavailability issue.
We'll fix this in our next up-coming v2.0.0 GA release.

@mothershipper
In our v2.0.0 release, we simply used a ping handler to respond to healthz requests.
we shouldn't check aws services at healthz as restart the pod won't help in such case.
closing this.


Open source?

This project is licensed under the GNU General Public License v3.0 which states that the source code must be open for all users.  However, and maybe I'm dense, but I'm unable to locate the source code.  Does it live somewhere else?  Thank you!

Yeah sorry it's not open source, this is more of an information-page.


Fix calling insert with an object that has a length property

This PR resolves https://github.com/brianc/node-sql/issues/323 by only changing the statement into a select if arguments doesn't exist or if it is an empty array. If arguments just an object then an insert statement is generated.

Thanks a lot for your work on this!  Sorry it took me a while to get to it - life got in the way & I got really busy tending to some things.  I'll merge this now & push a new minor version to npm here in just a few minutes. ❤


Using AnalyticsNode causes node process to hang

Hello, I'm currently working on a library that wraps this library to support both Node.js and React (as well as providing some custom validation logic).  As I've been working on the Node.js side, I noticed that running code similar to the sample script in https://github.com/segmentio/analytics-next/pull/352 causes the node process to hang.  I have two questions:

Is it intended for the node process to keep running after calling AnalyticsNode.load?  If so, is there a way to gracefully stop the process?
Is this the best library to use for integrating Segment into backend Node.js applications?  I saw that there's https://github.com/segmentio/analytics-node, but using the same library for both frontend and backend would simplify the maintenance of our wrapper library.

Any help would be appreciated, thank you!

@chrismeyers Thanks for logging this issue!

Is it intended for the node process to keep running after calling AnalyticsNode.load? If so, is there a way to gracefully stop the process?

That's not the intention. It looks like we have a bug in our flushing logic that keeps a setTimeout running - this works fine in the browser but in node.js it's keeping the process open. We'll need to fix that.

Is this the best library to use for integrating Segment into backend Node.js applications?

We want to make AnalyticsNode from this library on par with the analytics-node package, but we have not yet fully ported all the tests and behavior over to be able to fully recommend switching over. We've been discussing when to tackle this - potentially in the next quarter.

Hey @chrisradek, thanks for the quick response!
Regarding the setTimeout bug, I just wanted to make sure I wasn't going crazy 😄
The current functionality of AnalyticsNode fits the needs of our internal wrapper library, so any additional improvements moving forward would be great!


Fixed typo in starter

Hi Team,
I followed the tutorial in the Readme.md:
❯ loco new
✔ ❯ App name? · myapp
✔ ❯ What would you like to build? · SaaS app (with DB and user auth)

🚂 Loco app generated successfully in:
myapp

After cding into myapp and running cargo loco start, I noticed the app running on localhost:3000 had a typo.

It looks like what happened is that the typo was fixed 5 months ago, but you forgot to run: "vite build" to rebuild the dist folder - hence the typo remained in the starter.
In the meantime, this branch just removes the extra "s" from the dist file.
A deeper fix would be to run 'vite build' on master (within starters/saas/frontend) and then retest the loco CLI in dev mode with the regenerated dist folder

Just noticed you've already got docs on running the CLI locally - I need to tweak the commands a bit on mac to get it to work for me
Pretty awesome! 🤯
In any case, I reran vite build, tested the saas app generater with the locally-running cli & all tests pass  👍

Hey @ElishaKay,
We avoid accepting pull requests that include compiled or bundled code. This policy is in place for security reasons, to protect users from content that we can't validate.
I've opened a PR to address this issue. I appreciate your understanding.

@kaplanelad sure thing - all good :)
Glad I could help 😊


Implement effective_on support for rule_data.yml

This patch implements support for an effective_on key in data from rule_data.yml.
The patch works by transforming data with effective_on dates into a format the rest of the codebase will understand transparently, without breaking backwards compatibility.
Examples: As long as a key is formatted as such:
key:
  - value: "ec-policies"
    effective_on: "2024-01-01T00:00:00Z"

it will be reformatted to look like this:
key: "ec-policies"

On the other hand, if the date is not yet effective, the value will be empty.

The behavior described in the PR description seems to not match the patch.
key:
  - value: "ec-policies"
    effective_on: "2024-01-01T00:00:00Z"

versus:
key:
  value: "ec-policies"
  effective_on: "2024-01-01T00:00:00Z"

The first one is more useful I think, since most of the time our rule data is a list, e.g. I was thinking we wanted to suppor this:
allowed_stuff:
  - foo
  - bar
  # Starting next month baz is also allowed
  - value: baz
    effective_on: <next month>

Or maybe this:
allowed_stuff:
  - effective_on: <today>
    value:
    - foo
    - bar
  # Starting soon, also baz
  - effective_on: <next month>
    value:
    - foo
    - bar
    - baz

I might be wrong, but it seems like neither of these would be supported currently.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4458d87) 100.00% compared to head (8a95372) 100.00%.
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #860   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           93        93
  Lines         4582      4610   +28
=========================================
+ Hits          4582      4610   +28

Files
Coverage Δ

policy/lib/rule_data.rego
100.00% <100.00%> (ø)

policy/lib/rule_data_test.rego
100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Closing in favor of https://github.com/enterprise-contract/ec-policies/pull/894, which is the better way forward.


OnEnter Docs

Previously, the onEnter docs where here.
Where are those docs now? What happened to onEnter?
I don't see anything to reflect the above in the change log.

There is a new version. The 3.x docs are under the v3 branch now.

What happened to onEnter?
I don't see anything to reflect the above in the change log.

@timdorr What about the rest?

https://github.com/ReactTraining/react-router/blob/v3/docs/API.md#onenternextstate-replace-callback


Fixed matrix index

Hi,
If I'm not mistaken that index should be updated in the following way. Performance seems to be better with this change

Hi Mikhail,
Thanks for reading the code and making a contribution.
Although, I'm having a difficulty trying to understand your suggestion.
tf.get_variable("variable_name", shape=[dim1, dim2]) is a function for creating/reusing a trainable variable in TensorFlow.
The "variable_name" can be anything you want, as long as you use it consistently.
So could you explain why you are suggesting we change from 'W_'+str(i) to 'W_'+str(i+1)?
Also it's not so clear to me why changing that would give better performance.
Thanks,
Ed

Hi Ed,
Thank you for the response.
After your comment I realized that my changes doesn't make sense. I missed that variables in the loop above are called "W_i" while variable that I was trying to change was "Wi" (with no underscore). So I thought that you were creating a new variable with the same name. Regarding to performance I meant quality - probably it happened due to some random perturbations. It is quite unstable for my dataset.
Sorry for the disturbance. I'm closing the PR
Thanks,
Mikhail


Add sample and fix sqlserver barrier script

Merge csharp-sample into sdk solution to debug sample and sdk projects conveniently.
Fix barrier.sqlserver.sql
Add sqlserver barrier example into DtmSample project

@catcherwong integration test have problem, pls re-run it .


how to build .tflite file and two outputs

this is my command:
bazel build //tensorflow/contrib/lite/toco:toco
bazel-bin/tensorflow/contrib/lite/toco/toco
--input_file=/tmp/frozen_graph.pb
--input_format=TENSORFLOW_GRAPHDEF
--output_format=TFLITE
--output_file=/tmp/mobilenet_v1_224.tflite
--inference_type=FLOAT
--input_arrays=input
--output_arrays=MobilenetV1/Predictions/Reshape_1
--output_arrays=MobilenetV1/Logists
--input_shares=1,224,224,3
add this .tflite in android demo , but only find one output. maybe  the .tflite  file load one output,  I  think this problem is this last output_arrays over coverage the next output_arrays. Could anyone can sovle this problem , very appreciate

I'm a little confused. The command you are running doesn't seem to match your title? Where is the second pb? What are you trying to accomplish. Thanks!

sorry , it`s my fault. it should be one lite file and two outputs. for example,
intput:  Tensor("input:0", shape=(1, 384, 384, 3), dtype=float32)
output:
Tensor("Depth/output:0", shape=(192, 192, 1), dtype=float32)
Tensor("Saliency/output:0", shape=(192, 192), dtype=float32)
thanks

Nagging Assignee @aselle: It has been 17 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

You should use
--output_arrays="MobilenetV1/Predictions/Reshape_1","MobilenetV1/Logists"

Nagging Assignee @aselle: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Please refer to @michaeltinsley's comment. Thanks!


Add verbose option

I'm not a fan of -V, maybe --verbose is enough, don't add a short one. I'm grepping in some man files to check if there's a clear concensus on this one.

Here's the choices for the option(s)

--verbose
-v --verbose (conflicts with -v --version)
-V --verbose

OK stats are:
    384        --version
    246        -V, --version
     70        -v, --version

so clearly not -v (for verbose). I'd go for the first one: only the long one.

hahaha but I was mostly right 😁 --verbose only it is !

Oh, did I messed up between "--verbose" and "--version" as we were on the PR about "--version" I though it was the "--version" issue! (see my stats are about --version, not --verbose).
For version I'm ok with --version and -v. -v is good as we can use it multiple times like -v -vv, -vvv, which is nicely handled by argparse count argument.

for verbose you mean ? --version is about to be merged

Fixed in the message, it's a mess. It's late for my défense.

Oh right crap, SIGDODO after verbose is merged and another PR is out


When hitting f2 key it doesn't replace the word in the comments

VSCode Version: 1.27.2
OS Version: Ubuntu 18.04

Steps to Reproduce:
1.Hit f2
2.Write the new name
3.Hit enter
And will see that it doesn't replace in the comments.

Does this issue occur when all extensions are disabled?: Yes/No

The rename is a semantic rename and it there fore only renames symbol references and not the matches in comments.


Add resource (Mock API) to web-development-resources-part2.md

Add jsoning api (my website), a mock rest API to create custom APIs from JSON for prototyping, to web-development-resources-part2.md

approved


Added support for pascal case conversion

Using the pascal-case dependency, I've added support for conversion to PascalCase. Unit tests also included inline with others you have done.

Coverage remained the same at 100.0% when pulling e93604f8a15447a31e075dc08e6507fcd47581f6 on kelfish:master into e6bf56f4e142162049164e96e9398ae56053379f on BinaryThumb:master.

@frostney - anything I can do to help get this pull request merged please?


Fix the dockerfiles downloading Falco tar.gz package with ADD from URL

Describe the bug
When the FALCO_VERSION env variable contains a version string with a character like + the resulting URL to download the TAR.GZ package does not resolve correctly.
For example, this is happening here:
https://github.com/falcosecurity/falco/blob/802b9f7b69af665593dfa99431c6b9d7abf5c94f/docker/minimal/Dockerfile#L11
To solve this the URL needs to be url-encoded.
How to reproduce it
Try to build the docker/minimal image using FALCO_VERSION=0.20.0+d77080a.
Expected behavior
The ADD command to fetch the tar.gz package correctly from its URL.
Environment

Falco version: 0.20.0

System info:

Cloud provider or hardware configuration:
OS: Arch Linux

Kernel: Linux l13o1 5.4.10-arch1-1 #1 SMP PREEMPT Thu, 09 Jan 2020 10:14:29 +0000 x86_64 GNU/Linux

Installation method:

Additional context
The same applies when downloading the Falco packages with curl.

/assign
/milestone 0.21.0


Fix some typos & presentation in ProjectSpec doc

Especially:

targets root key is supposed to be a dictionary but is documented as root level to just be a Target
Some mis-indentation in one of the examples
Some markdown renderers don't like if you don't have an empty line after a header, so I added them to be sure to render it properly in all markdown softwares.

Thanks @AliSoftware 👍


Fix HTTP/2: retry requests rejected with REFUSED_STREAM

This patch gets the client to retry HTTP/2 requests rejected with REFUSED_STREAM by inspecting the error detail.
I found the issue with highly concurrent requests in HTTP/2 made to the server that is configured to allow the smaller number of concurrent streams. So for example, a client makes, say, 500 concurrent requests to an HTTP/2 server while the server's max_concurrent_streams is set to 100. In this case the client is allowed to initiate 500 concurrent streams until the initial SETTINGS frame from the server reaches to the client, though the server will reject 400 streams by responding REFUSED_STREAM.
From the standpoint of users of reqwest crate, I would expect the crate to deal with this kind of situation behind the scenes. Actually, as far as I searched, Go and libcurl provides the retry logic when they encounter REFUSED_STREAM. Considering the "ergonomic, batteries-included" characteristic of reqwest, I believe automatic retry would be very nice to have.
Here's a repo containing reproducible code written in a couple different languages. It also has rust-patched code which demonstrates that this patch does fix the issue.
https://github.com/magurotuna/deno-fetch-h2-stream-error-repro

Thanks for this! I think this might be something we can do, I'll have to go carefully read the spec about REFUSED_STREAM again. But something I was wondering: assuming that this is a safe thing to retry, could we have a unit test for it?  It might mean the support test server might need to pass some options to hyper...

Sure, I'll add a unit test!

Added two test cases in f6ad3c6.
I added two, because I found that if we use the existing test server, it just passed this test without the retry logic - after some investigation, it turned out that the hyper server is so fast that we can't reproduce a scenario that I saw when using nginx as a server, that is, server's initial SETTINGS frame reaches the client later than the client having already opened more streams than is allowed.
In order to get a test case that fails without the retry, the new server has been added that can simulate a "slow" server. I confirmed that the test case using this "slow" server does fail without the retry logic.

A related topic; thinking a bit further about the fact that we get REFUSED_STREAM errors when making too many concurrent requests, doing retry is certainly a mitigation, but another approach would be that we start with the relatively small number of concurrent streams until the server's initial SETTINGS frame arrives. This should reduce the chance of getting rejected with REFUSED_STREAM in the first place.
I've opened a proposal issue in h2 (https://github.com/hyperium/h2/issues/731). But I believe retry is still good to have also.

Saw CI failed due to missing h2::Error::is_reset method. To address it I bumped h2 crate to 0.3.14 as it was supported since this version.

Sorry for making many commits to pass the CI. I made a small fix in 895f282 (the port 19999 was introduced mistakenly in f6ad3c6 for me to easily debug it).
I locally confirmed that cargo nextest --locked --workspace have passed.

Thank you for starting the CI many times! I now understand how the test suite works against many feature flags.


Update templates to Webpack 2

I'll merge this at the start of next week, but posting it here as a PR first just in case anyone can spot any issues.
Moving to awesome-typescript-loader improves the Angular2Spa Webpack build times (down from about 7.5s to about 4s on my machine). It makes no difference to the other templates, which were already fast to build, but I've migrated them to awesome-typescript-loader for consistency.
Anyone who reads this: please let me know if you think there are any problems with this, or some opportunity to make things simpler still with Webpack 2.
Note: If you're trying to read the diff, it makes much more sense if you ignore whitespace differences (because indentation changed). This URL will give an indentation-ignoring diff: https://github.com/aspnet/JavaScriptServices/pull/615/files?w=1

LGTM! 👍
Don't seeing anything off the bat that looks off.

Brilliant! Any idea the size of the output files now it uses treeshaking?

@LiverpoolOwen I wouldn't expect any significant size changes yet: you'd also need (at minimum) to be precompiling your views so that the set of API calls your code makes is known at compile time. I hope this is something we will get soon, but it depends on things like ngc compatibility with Angular Universal, Webpack, etc., and last time I checked it wasn't ready for that.

This is now merged into dev and will be released as generator-aspnetcore-spa version 0.8.0 shortly.


Unsafe

Hello
I was just wondering is it possible to create it without unsafe areas?
I need it to be safe, and I don't want to learn this whoe algorithm to make it myshelf...
~RB

Sure, try this one. The unsafe version is more than twice as fast though.
SipHash.txt

Thanks!
I'm sure it'll be fine, I'm programing in c#, I don't need speed :)

Surprisingly, C# is capable of very high speeds if used properly. The SipHash unsafe C# implementation is competitive with C++ implementation (currently only on 64-bit .NET Core JIT, but the bit rotations optimizations are coming to the next major release of full .NET).
Anyway, feel free to reopen this issue if anything more comes up.


blacklists are not working

Describe the bug
Black list works in istio 1.0.5 but doesn't work in 1.1.1
Here is my settings:
---
apiVersion: v1
items:
- apiVersion: config.istio.io/v1alpha2
  kind: listentry
  metadata:
    creationTimestamp: "2019-04-02T08:22:09Z"
    generation: 1
    name: details-hzqi-test-version-listentry
    namespace: hzqi-test
    resourceVersion: "13877651"
    selfLink: /apis/config.istio.io/v1alpha2/namespaces/hzqi-test/listentries/details-hzqi-test-version-listentry
    uid: 68c4987e-5520-11e9-a25f-005056a45a16
  spec:
    value: source.labels["app"] + "." + source.namespace + "-version:" + source.labels["version"]
kind: List
metadata:
  resourceVersion: ""
  selfLink: ""
---
apiVersion: v1
items:
- apiVersion: config.istio.io/v1alpha2
  kind: listchecker
  metadata:
    creationTimestamp: "2019-04-02T08:22:09Z"
    generation: 1
    name: details-hzqi-test-black-listchecker
    namespace: hzqi-test
    resourceVersion: "13877650"
    selfLink: /apis/config.istio.io/v1alpha2/namespaces/hzqi-test/listcheckers/details-hzqi-test-black-listchecker
    uid: 68c10d20-5520-11e9-a25f-005056a45a16
  spec:
    blacklist: true
    cachingInterval: 0s
    overrides:
    - 'productpage.hzqi-test-version: v1'
    ttl: 0s
kind: List
metadata:
  resourceVersion: ""
  selfLink: ""
---
apiVersion: v1
items:
- apiVersion: config.istio.io/v1alpha2
  kind: rule
  metadata:
    creationTimestamp: "2019-04-02T08:22:11Z"
    generation: 1
    name: details-hzqi-test-black-rule
    namespace: hzqi-test
    resourceVersion: "13877659"
    selfLink: /apis/config.istio.io/v1alpha2/namespaces/hzqi-test/rules/details-hzqi-test-black-rule
    uid: 69ea545c-5520-11e9-a25f-005056a45a16
  spec:
    actions:
    - handler: details-hzqi-test-black-listchecker.listchecker
      instances:
      - details-hzqi-test-version-listentry.listentry
    match: destination.labels["app"] == "details" && destination.namespace == "hzqi-test"
kind: List
metadata:
  resourceVersion: ""
  selfLink: ""
---

Expected behavior
blacklist should be work in istio 1.1.1
Steps to reproduce the bug
deploy the bookinfo sample into namespace hzqi-test and then create resources provided upper.
Version
istio 1.1.1
kube 1.13.3
Installation
using helm chart

In istio 1.1 we disabled policy enforcement by default. Did you enable policy enforcement when you run your test? https://istio.io/docs/tasks/policy-enforcement/enabling-policy/

@bianpengyuan thanks. I'll check the settings and feedback.

Hi, I confirm the blacklist works when enabled the policy following the doc, but it doesn't work as 1.0.5 even I set cachingInterval: 0s and ttl: 0s.  The details service is blocked when the rule is created immediately. this is what we expect, but the details service is still blocked event I deleted the rule.  When I refresh the bookinfo page frequently, I can see the details several times. this is not what we expect. We want to see the details page always if the rule doesn't exist.

Hello, I confirm the blacklist works as expected now. the details page is still blocked because it has ratelimit policy.


[1.6.2] Why MU is undeliverable with rocket?

There're 2 types of MUs:

Packed (not stackable). These ones shouldn't be deliverable to a space platform — it's ok. Like rocket-silo.
Empty (stackable). These ones should be deliverable to a space platform. But not placeable there. Like cargo-landing-pad.

I believe they should be placeable in the space platform surface. It does not ruin space platform balance as they are large entity and can only can store one item type.


Use synonyms when searching

What changed, and why it matters
This PR adds the capability to specify a list of synonyms to be used when searching.  It adds them at index-creation time, there are a couple of them seeded in the PR so it's obvious where to add more.
Note that this PR clashes with #649 so I've built it on top of that and will leave as draft until that is accepted/rejected (and if the latter, I'll rebuild it on main).

Good point!  I've broken the synonyms out into a different file, as opposed to the whole analyzer, as I think that's a more approachable way for people to add new synonyms (I think there's more likely to be synonym changes in the future than wider analyzer changes).  However, if you think the whole analyzer should be broken out instead, then I'm happy to do that instead, just let me know.
Also possible future enhancement: GitHub action to lint-check the JSON file.

I see your point and agree that keeping just synonyms in a separate file makes it easier for people to add synonyms.
One question about file location - should we put it next to other vocabulary files we have?
Also, extra bonus if we add couple of lines into the README how to add the synonyms! :)
One more question - can I test this somehow locally? Or how did you test this change?

One question about file location - should we put it next to other vocabulary files we have?

Do you mean in .github/styles/Vocab/ ?  It feels a little strange to put this into a .github directory, but I really don't have a strong feeling about it.  If you'd prefer it to be there, then I'm happy to move it?

Also, extra bonus if we add couple of lines into the README how to add the synonyms! :)

I've added it to the SEARCH doc - does that get me the bonus points? :)

One more question - can I test this somehow locally? Or how did you test this change?

Yes, you should be able to follow the steps at the bottom of the SEARCH.md doc ("Testing changes to search functionality") - let me know internally if any of that doesn't work and I'll debug it with you.

On the .github directory issue: vale stuff (the .github/styles directory) is there because that's where the github action for vale says we should put it. In the future, there will be multiple subdirectories (not just styles) in  the more specific .github/vale.
I'd be tempted to keep the JSON file next to the script, at least for the moment - we can think about project organisation later on as we gain more tooling.

Did this PR need the indexes recreating on OpenSearch to take effect? Or does it do its magic when the search runs?

Yes, the analyzer is setup at index-creation time.


Copy / paste entities from the GUI

Add options to copy / cut / paste models through the GUI.
Hotkeys:

Cut = CTRL+X
Copy =  CTRL+C
Paste = CTRL+V

The option should also be available from the context (right-click) menu.

I'll dump some more things I discussed with @adlarkin here:
The quick way
The quickest approach at the moment would make use of the SpawnFromDescription event and pass the contents of components::ModelSdf (requires https://github.com/ignitionrobotics/ign-gazebo/pull/851)
Drawbacks of this approach:

Only works for models (not lights, actors, etc)
Requires the GUI to parse the SDF file to create the spawn preview that's attached to the mouse. This can take a non-negligible time for models with multiple links, joints and materials.

The :sparkles:  great :sparkle:  way
My recommended implementation involves using the clone_name field of msgs::EntityFactory:
1: UserCommands

[ ] Make the UserCommands system parse the clone_name field here:
https://github.com/ignitionrobotics/ign-gazebo/blob/24be610ac1e8889b6c538a110c84da7f91360a39/src/systems/user_commands/UserCommands.cc#L726-L731
This would probably entail:

Getting an entity ID from its name
Copying all entities and components that compose this entity

Recursively include all children
Make sure the new entities have different IDs

This could be in its own PR. One way to verify that this works would be:

Start ign gazebo shapes.sdf

On another terminal, call:
 ign service -s /world/shapes/create \
     --reqtype ignition.msgs.EntityFactory \
     --reptype ignition.msgs.Boolean \
     --timeout 300 \
    --req 'clone_name: "box", pose {z: 10}, name: "box_copy"'

A red box is spawned and falls on top of the original one.

2: 3D Scene

[ ] Create a new SpawnFromCloneName GUI event (or some name like that) that just takes a top-level entity's name. And listen to it from Scene3D.

[ ] Implement the event's behaviour inside Scene3D. Follow the pattern of spawnSdfString / spawnSdfPath:
https://github.com/ignitionrobotics/ign-gazebo/blob/24be610ac1e8889b6c538a110c84da7f91360a39/src/gui/plugins/scene3d/Scene3D.cc#L217-L222
Finally
Unlike those spawning methods though, instead of generating a preview from an SDF file:
https://github.com/ignitionrobotics/ign-gazebo/blob/24be610ac1e8889b6c538a110c84da7f91360a39/src/gui/plugins/scene3d/Scene3D.cc#L978
We'll create a new method that generates a preview by copying an existing visual.

[ ] Finally, just add
      else if (!this->dataPtr->spawnCloneName.empty())
      {
         req.set_clone_name(this->dataPtr->spawnCloneName);
      }

here:
https://github.com/ignitionrobotics/ign-gazebo/blob/24be610ac1e8889b6c538a110c84da7f91360a39/src/gui/plugins/scene3d/Scene3D.cc#L1343-L1355

3: New copy / paste plugin

[ ] Create a new GUI plugin that calls the SpawnFromCloneName when the user requests it