Failed to get the current route name of nested route.

Hello, author! I try get the current route from a Navigator widget, but it always return the route name of root.
Navigator(
      key: Get.nestedKey(1),
      initialRoute: '/home',
      onGenerateRoute: (settings){
        print(settings);

        switch(settings.name){
          case '/home':
            return GetPageRoute(
                page: ()=> Home()
            );

          case '/userZone':
            return GetPageRoute(
                page: ()=> UserZone()
            );
        }
      },
    )

Specifically, when pushing to /home, I use Get.currentRoute to check the route name to avoid the duplicate routing, but the output is always return /.  How do I solve this problem?

Hello, i was facing with same problem and i have fixed this issue like that;
I created a variable on my controller
String? currentDashboardRoute;
and i filled it inside the on generate root and then i used it where ever i want
onGenerateRoute: (settings) {
  Get.routing.args = settings.arguments;
  controller.currentDashboardRoute = settings.name;
  return settings.getPageRoute;
}


catch and discriminate different exception types (take 2)

This replaces #39.
Specific C++ exceptions are translated to javascript exceptions with the same type name. The error message from the C++ error is copied into the Javascript error.

@thmiceli, looks like there are some build errors.

Looks like an issue with node 0.10 and earlier. I'll am looking into it.

The CI failures are now fixed.

I added an error handling section to the documentation. The source code formatting has been fixed.
Also, the custom-error-generator version is pinned to 7.0.0.

Here is what a thrown JavaScript exception looks like once serialized to JSON:
{ stack:
[ 'DuplicateCorrelationIdException: BLPAPI_ERROR_DUPLICATE_CORRELATIONID',
'    at /blah/blpapi.js:33:20',
'    at invoke (/blah/blpapi.js:45:15)',
'    at exports.Session.subscribe (/blah/blpapi.js:93:23)',
'    at null. (/blah/examples/MarketSubscription.js:23:17)',
'    at emit (events.js:107:17)',
'    at session.emit (/blah/blpapi.js:53:19)' ],
message: 'BLPAPI_ERROR_DUPLICATE_CORRELATIONID',
captureStackTrace: [Function: captureStackTrace],
stackTraceLimit: 10 }


Small cleanup on cypress gitignore

Description
Some GHA are failing due to lack of cleanup of downloads folder: https://github.com/kubeflow/model-registry/actions/runs/10948937500/job/30401082009?pr=403
@isinyaaa gently provided a quick fix. This PR is just some FUP PR for our better code organization.
How Has This Been Tested?

Merge criteria:

All the commits have been signed-off  (To pass the DCO check)

[X ] The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
[NA ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ X] The developer has manually tested the changes and verified that the changes work.
[X ] Code changes follow the kubeflow contribution guidelines.

@Griffin-Sullivan can you please take a look over this one?

/lgtm


Refactored process

This is a part of coming playbook configuration hints feature.

Current coverage is 86.15% (diff: 77.84%)

Merging #73 into master will increase coverage by 0.81%

@@             master        #73   diff @@
==========================================
  Files            55         56     +1
  Lines          3603       3655    +52
  Methods           0          0
  Messages          0          0
  Branches        335        333     -2
==========================================
+ Hits           3075       3149    +74
+ Misses          448        423    -25
- Partials         80         83     +3

Powered by Codecov. Last update 422655e...91f66b2


Change the way rubocop thinks about heredocs?

I was about to put in a request to have the LineLength cop ignore heredocs and, when I searched old issues, I realized there seems to be a bit of a theme.
It seems people have issues with heredocs when rubocop tries to style them.  Typically you use heredocs for preformatted text.  Preformatted text which may or may not exceed line length.  Preformatted text which may or may not be representing Ruby.
I don't really care about syntax within my heredocs in general and considering a lot of heredocs are representations of other languages (eg SQL, YAML, JavaScript, etc), rubocop doesn't exactly play a part in those.
Additionally there are many places in the code which are doing heredoc-specific logic.  It seems ripe for extraction.
I felt like a discussion may be in order to think about how else we might construct the cops to work with heredocs.
Heredoc Key Whitelist
Specifies the allowable keys to use in heredocs.  Example:
Style/HeredocKey:
  Whitelist:
    - HEREDOC
    - SQL
    - RUBY
    - TEXT
    - CONTENTS

my_heredoc = <<-HERDOC
  Here's my Heredoc
HERDOC

The above would cause an error.
Heredoc Configuration Mixin
The Heredoc configuration mixin would enable cops to perform special behavior when they encounter a heredoc.  Example:
Metrics/LineLength:
  Heredocs:
    ExcludeKeys:
      - SQL
      - TEXT
      - XML

Metrics/LineLength:
  Heredocs:
    Exclude: true

Aaaaaaaaaaaaaaand GO :crossed_flags: :runner:

Would love to see a way to ignore heredocs. We have quite a bit of SQL inline and also indent the SQL and then call ActiveSupport's .strip_heredoc on it. Thus, they're fairly often above the 80 chars limit.
I might take a shot at it, but first wanted to ask, what the collaborators would like to see. Either ignore all heredocs, or only heredocs with certain keys as delimiters, as suggested above by @jfelchner.

For what it's worth, I wholly agree that line length should be ignored inside here documents.
Actually, in my opinion, that should be the default behavior, and not something that should be explicitly enabled.
Here documents already disrupt the regular flow of code - it's what they do. There is no reason to apply Ruby guidelines to something that could be a poem from 1754, as far as rubocop is concerned.
If people never want to go over a certain number of characters in a line, then they should either move the heredoc to an external file or to a regular string. If people use heredocs it's for a reason, and that reason is not compatible with limiting formatting to an arbitrary number of characters per line.

@fphilipe circling back on this issue.  Are you still interested in trying to take a crack?  If so mention bbatsov and see what he'd like to do.

@jfelchner @bbatsov Taking a shot at this. I'll be opening a PR soon to discuss a first draft.


3.9.0 not released on ansible galaxy?

https://galaxy.ansible.com/angstwad/docker_ubuntu

While it's not available yet on galaxy
I put this in my requirements.yml
---
# How to use this file?
# https://docs.ansible.com/ansible/latest/reference_appendices/galaxy.html#installing-multiple-roles-from-a-file
#
# To update roles you can run `ansible-galaxy install -r ansible/roles/requirements.yml --force`
- name: angstwad.docker_ubuntu
  src: git+https://github.com/angstwad/docker.ubuntu.git
  version: v3.9.0


Ejected customized theme causing type errors in Typescript

I have gone through these following points

[x] Check latest documentation: https://docs.nativebase.io/
[x] Check for existing open/closed issues for a possible duplicate before creating a new issue: https://github.com/GeekyAnts/NativeBase/issues
[x] Use the latest NativeBase release: https://github.com/GeekyAnts/NativeBase/releases
[x] Check examples from NativeBase KitchenSink https://github.com/GeekyAnts/NativeBase-KitchenSink
[x] For discussion purpose make use of NativeBase Slack: http://slack.nativebase.io/
[x] For queries related to theme, check Theme Variables from Docs and live NativeBase Theme Editor http://nativebase.io/customizer/

Issue Description
Ejecting the native base theme and extending it in the component files creates Typescript errors similar to:
Type '{ children: string; bold: true; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<H3> & Readonly<H3> & Readonly<{ children?: ReactNode; }>'.       Property 'bold' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<H3> & Readonly<H3> & Readonly<{ children?: ReactNode; }>'.
node, npm, react-native, react and native-base version, expo version if used, xcode version
node: 10.15.1
nom: 6.11.3
RN: 0.59.8
react: 16.8.3
NB: ^2.13.8
expo: SDK34
Expected behaviour
When extending the theme, the prop types for the components are updated to reflect new custom component props.
Actual behaviour
The NB component prop types are not updated and therefore Typescript is not made aware of the new prop.
Steps to reproduce
Basic code snippet to demonstrate:
H3.js (note I added the "bold" theme item after ejecting):
import variable from './../variables/platform';

export default (variables = variable) => {
  const h3Theme = {
    '.bold': { /// this was added after ejecting
      fontFamily: variables.fontFamilyBold,
    },
    color: variables.textColor,
    fontSize: variables.fontSizeH3,
    lineHeight: variables.lineHeightH3,
  };

  return h3Theme;
};

Component:
import * as React from 'react';
import { StyleProvider, H3 } from 'native-base';
import platform from '../theme/variables/platform';

const Example = () => (
  <StyleProvider style={getTheme(platform)}>
    <H3 bold>text</H3> /// this line causes the error. No error when "bold" is removed
  </StyleProvider
)

export Example

Not sure I can create a snack with an ejected theme, if so let me know how and I will!

Hi @bscaspar , please update to latest native-base v2.13.14 . Closing for now. Let us know if the issue still persists.


Use Mojo test runner

Use the mojo test command for running our unit tests for more useful failure output

Looks good! Merging


Refactor editor

All information describing this refactoring is in #106

This info may be useful to split the editor.js in several files while maintaining access to global variables.


fix: add Plugin to built-in d.ts from @types/webpack

ref: https://github.com/webpack/webpack/issues/11630
Many typings of packages use Plugin now. If they have to change it to use WebpackPluginInstance they treat it as a breaking change. This is a large impact on packages even if webpack@5 is a major update version and a breaking change (ex: https://github.com/getsentry/sentry-webpack-plugin/pull/233 ) . Could you avoid this situation?

What kind of change does this PR introduce?

bugfix
Did you add tests for your changes?

Does this PR introduce a breaking change?

no
What needs to be documented once your changes are merged?

Thanks for your contribution. I am closing PR because it is too stale..


App not found IOS

I am launching a flutter app (App 1) from another flutter app (App 2) on Android and it works perfectly. However, I keep getting the same error on IOS. It does not recognize the package name.
I have tried with multiple apps but is the same result, it currently just recognizes the calendar package.
pubspec.yaml file flutter_appavailability
main.dart App 2
import 'package:flutter_appavailability/flutter_appavailability.dart';

//Future void method
if (Platform.isIOS) {

_installedApps = [
        {"app_name": "example", "package_name": "com.flutter.example"},
      ];

      print(await AppAvailability.checkAvailability("com.flutter.example")); //ERROR

 //Widget build
return Container {
 child : Row(
   ...
   GestureDetector(
    ...
    onTap: () {
              Scaffold.of(context).hideCurrentSnackBar();
              AppAvailability.launchApp(installedApps[0].["package_name"])
                  .then((_) {
                print("App ${installedApps[0]["app_name"]} launched!");
              }).catchError((err) {
                Scaffold.of(context).showSnackBar(SnackBar(
                    content: Text(
                        "App ${installedApps[0]["app_name"]} not found!")));
                print(err);
      });
...
 ),
}

info.plist App 1
<key>CFBundleIdentifier</key>
	<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>

project.pbxproj App 1
PRODUCT_BUNDLE_IDENTIFIER = com.flutter.example;
Output App 2
[VERBOSE-2:ui_dart_state.cc(148)] Unhandled Exception: PlatformException(, App not found com.flutter.example, null)
#0      AppAvailability.checkAvailability (package:flutter_appavailability/flutter_appavailability.dart:40:9)

Hi @lauralarez
Try including the following in your Info.plist
<key>LSApplicationQueriesSchemes</key>
<array>
   <string> package_name </string>
</array>

Hi @lauralarez
Try including the following in your Info.plist
<key>LSApplicationQueriesSchemes</key>
<array>
   <string> package_name </string>
</array>

Not work yet


Change "elementary, LLC" to "elementary LLC."

What it says on the tin. Minor technicality for the footer.

Is this how LLC is legally formatted? If you're using the legal name, it's probably best to follow whatever legal guidelines exist. "elementary, LLC" seems better because I read it as "elementary, Limited Liability Company", which is strange without a comma.

Well Cassidy is the legal owner of the LLC, so that's probably why he filed ;p I think formatting varies by region.

“elementary LLC.” is the legal name of elementary LLC.


fix: update to eye v4.17.6

fix: update to eye v4.17.6

:tada: This PR is included in version 6.8.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release
v6.8.5

Your semantic-release bot :package::rocket:


Debug provide capability to always show stack frame column indicator

Issue Type: Bug
In my debug extension it frequently happens that debugging stops in multiple positions within a line. That's why I heavily depend on proper debug position markers.
However the handling is currently not fully satisfying:

For the first stop on a line the debug marker is never shown:

Well, not always as this image shows:

, but mostly it's missing. The difference here is that in case 1) this was the first stop on that line, while for 2) we have a recursive rule, so when I step-in the debugger ends up at the first rule name (the body of a rule begins after the colon). Pretty inconsistent. The debug marker should always show unless there is no column info (however my stack traces always has column info).

Also within a line the marker shows up or not, depending on how a position was reached (not the position itself).

Reached the position after stepping into identifier and returned.

Reached the position after stepping over identifier.

The debug marker is not shown for non-TOS elements in a call stack and the TOS loses the marker when navigating the call stack.

As you can here the marker before the identifier rule is lost when returning after selecting other than the TOS in the stack trace. That's a pretty bad thing as you totally lose where you came from. Imagine a rule body with 20 and more sub rule invocations, spread over multiple lines, which is very common in such grammar files.
I guess 1) is implemented by intention to support languages that rarely use debug stops within a line, but I beg for an option to always show the debug markers and always respect the given column value!
Btw: you can see this behavior also with the TS debugger, e.g. when you debug a for-loop, which is one of the rare occasions where a debug position within a line is used.
VS Code version: Code 1.23.1 (d0182c3417d225529c6d5ad24b7572815d0de9ac, 2018-05-10T16:03:31.083Z)
OS version: Darwin x64 17.5.0

System Info

Item
Value

CPUs
Intel(R) Xeon(R) CPU E5-1650 v2 @ 3.50GHz (12 x 3500)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledvideo_decode: enabledvideo_encode: enabledvpx_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
32.00GB (15.41GB free)

Process Argv
/Applications/Visual Studio Code.app/Contents/MacOS/Electron

Screen Reader
no

VM
0%

@mike-lischke thanks for your feedback.
This is currently designed behavior as you guessed correctly. I will leave this open to provide a debug adapter capability to always show a column and not be overly smart.
fyi @weinand
Also we really like concise issues, long text takes a lot of time to read.

Also we really like concise issues, long text takes a lot of time to read.

Well, I reported 3 problems which are very likely all caused by the same implementation. I assumed that would make things more compact. I can create 3 individual issues instead, but I doubt that makes handling easier in any way.

I was afraid this would happen and I don't consider this issue a feature request, but rather a bug. The behavior is inconsistent and should be fixed.

Moving to backlog. Thanks


[freerdp] linux build failure

Host Environment

OS: Ubuntu 20.04
Compiler: gcc 9.2.1

To Reproduce
Steps to reproduce the behavior:
./vcpkg install freerdp
Failure logs
Relevant fail is:
/usr/bin/ld: /home/ken/vcpkg/installed/x64-linux/debug/lib/libgobject-2.0.a(gboxed.c.o): undefined reference to symbol 'g_markup_parse_context_ref'
/usr/bin/ld: /lib/x86_64-linux-gnu/libglib-2.0.so.0: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.

install-x64-linux-dbg-out.log
Additional context
The glib dependency seems to have built.

Thanks for posting this issue. I installed freerdp successfully with the VCPKG latest source on Linux. Did you run git pull before installing freerdp?

Yes I had just installed it.

I happened to have a Ubuntu 18.04 around and it did build sucessfully. The run above is on Ubuntu 20.04.

Sorry I am late. Due to I don't have Ubuntu 20.04 machine, could you please try to install new version freerdp on Ubuntu 20.04? The attached file is the new version freerdp file.
freerdp.zip

Hi Lili, my bad too, apologies I missed the notification on this. Yes confirmed we're good with freerdp2 off of git current (ie as of this writing) on an up to date Ubuntu 20.04. Thank you!

I will submit a PR to update freerdp to new version, waiting for PR merged and closing this issue again.


Bug: Favorites movie list does not get updated when only one movie is added

https://github.com/user-attachments/assets/3a39f06e-0f9c-452e-acaa-c28a0463d071

@mehul-m-prajapati I saw this earlier on all the defualt lists in daccotta (top 5 , fav, watchlist). Please fix it for all in once. DO let me know if you need any help.


libsass: 3.6.1 -> 3.6.2

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libsass/versions.
meta.description for libsass is: '"A C/C++ implementation of a Sass compiler"'.
meta.homepage for libsass is: '"https://github.com/sass/libsass"
Release on GitHub
Compare changes on GitHub

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 3.6.2 with grep in /nix/store/ax9n1519fkb8pnrssg0jqc7pikncbh6v-libsass-3.6.2

directory tree listing: https://gist.github.com/3a796ff2ffb999233313b1c75a9b28f1

du listing: https://gist.github.com/ed3c6fbe200bb1175b25173be4285eda

Rebuild report (if merged into master) (click to expand)

8632 total rebuild path(s)
2871 package rebuild(s)
2863 x86_64-linux rebuild(s)
2611 i686-linux rebuild(s)
603 x86_64-darwin rebuild(s)
2555 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
AgdaSheaves
AgdaStdlib
Sylk
TotalParserCombinators
abiword
adapta-gtk-theme
adementary-theme
adoptopenjdk-icedtea-web
adwaita-qt
aesop
afew
agdaBase
agdaIowaStdlib
agdaPrelude
aj-snapshot
akonadi
akregator
alarm-clock-applet
albert
almanah
alot
alsaTools
amarok
amarok-kf5
amtk
android-file-transfer
anki
antimicro
antimony
anydesk
ao
apitrace
apmplanner2
appeditor
appimage-run
appstream-glib
appstream-qt
apvlv
aqemu
arandr
aravis
arc-icon-theme
arc-theme
areca
ario
ark
arx-libertatis
asciidoc-full
asciidoc-full-with-plugins
astroid

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ax9n1519fkb8pnrssg0jqc7pikncbh6v-libsass-3.6.2 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A libsass https://github.com/r-ryantm/nixpkgs/archive/e4b4ff8099685dea7e82ae6ccd3899337a121632.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ax9n1519fkb8pnrssg0jqc7pikncbh6v-libsass-3.6.2
ls -la /nix/store/ax9n1519fkb8pnrssg0jqc7pikncbh6v-libsass-3.6.2/bin

cc @codyopel @offlinehacker for testing.

@GrahamcOfBorg build sassc


Migrate ip_address field to ip_addresses

The automatic migration did not pick up this change and it breaks
current setups as it only adds a new field which is empty.
This means that clients who dont request a new IP will not have any IP
at all.

@enoperm, could you help me test this? It seem to work for my sqlite setup, and I think this is needed as 0.13.0-beta2.

@enoperm, could you help me test this? It seem to work for my sqlite setup, and I think this is needed as 0.13.0-beta2.

I too, have a sqlite setup, so if that works for you I expect no differences here. My current in-use database is old enough to have an ip_address field, but it is all empty as all current nodes in it have joined after the change to ip_addresses, so if anything, this would break that setup, I'll have to drop that column before I upgrade to this version if I do not want lose all my addresses. :)
I could try configuring an older 0.11 or 0.12 build with postgres and upgrade that, in case you were looking to confirm behaviour on such a setup.
At any rate, the code change itself looks good, assuming it does not fail when the column does not exists anymore (ie. subsequent startups), but I suppose that's why the return value is ignored.

One little observation, that may improve readability further down the road: in go you can use backtics for string literals, so one does not need to escape quotes in strings like SQL statements:
"create extension if not exists \"uuid-ossp\";"
// vs
`create extension if not exists "uuid-ossp";`

At any rate, the code change itself looks good, assuming it does not fail when the column does not exists anymore (ie. subsequent startups), but I suppose that's why the return value is ignored.


chore(deps): upgrade configuration

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-configuration-k8s-31-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4830

Questions ?
Please refer to the Backport tool documentation


Force map headings (h2, h3, etc)

Category
[ ] Bug
[x] Enhancement
Hi,
Is there currently a way to define how the headings are mapped (e.g. h1, h2, h3, etc)? The problem we are facing now is that through governance we've trained authors to not use "Heading 1" in classic because it conflicts with the page title. So our top level headings on all of our pages are H2. Since "heading 1" in modern is now actually an H2, the engine demotes the heading number of the content when it is transformed (so an H2 in classic becomes an H3 in modern) and all of our pages are missing top level headings. Ideally we would like to be able to specify that H2 is considered a top level heading for content and have it translate to an H2 on the modern site page as well.
Thoughts? Is this currently possible?
Thanks!

@mbice : today this is not possible OOB, but you can consider creating a custom build of page transformation. The needed changes are simple and need to be done in https://github.com/pnp/sp-dev-modernization/blob/dev/Tools/SharePoint.Modernization/SharePointPnP.Modernization.Framework/Transform/HtmlTransformator.cs#L104.
The complexity will be in building both the modernization library as PnP PowerShell

@jansenbe thanks for the clarification. I tried pre-transforming the content to increase the heading counts (e.g. H2 is converted to H1, H3 to H2, etc) before it goes through full transformation, at which point it gets moved back down to where it was when it started. This way an H2, which is our top level heading in all our content, stays an H2 after transformation. Bit of a workaround, but seems to work well enough at this point.
Thanks!


A task is never finished when "File name too long" by log file occurs

Environment
digdag 0.9.24 (Server mode)
Problem
When a digfile is pushed, the following validation works well.
Failed to store: {"message":"Validating project failed\nworkflow /tmp/digdag-tempdir5894056088905123786/push/new-project_1377544233838658341/new.dig Validating workflow failed\ntask name must not be longer than 255 characters: \"

On the other hands, the following dig file doesn't be validated. When this dig file run, the following error occurs and the task keeps to show "running" status.
+repeat:
  loop>: 10
  _do:
    +no_problem:
      sh>: echo "hello world"
    +aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa_aaa:
      if>: ${i != 0}
      _do:
        sh>: echo "${i}"

[root@ip-172-31-46-53 logs]# tail server.log
Caused by: java.nio.file.FileSystemException: /opt/digdag/logs/tasklogs/2018-02-05/0.1new@20180205T072606+0000/+new+repeat^sub+loop-0+aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa<EMAIL_ADDRESS>File name too long
	at sun.nio.fs.UnixException.translateToIOException(UnixException.java:91)
	at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
	at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
	at sun.nio.fs.UnixFileSystemProvider.newByteChannel(UnixFileSystemProvider.java:214)
	at java.nio.file.spi.FileSystemProvider.newOutputStream(FileSystemProvider.java:434)
	at java.nio.file.Files.newOutputStream(Files.java:216)
	at io.digdag.core.log.LocalFileLogServerFactory$LocalFileLogServer$LocalFileDirectTaskLogger.<init>(LocalFileLogServerFactory.java:170)
	at io.digdag.core.log.LocalFileLogServerFactory$LocalFileLogServer.newDirectTaskLogger(LocalFileLogServerFactory.java:147)
	... 9 common frames omitted

Expected Results
Adding validation for a length of task name.
Or
Workflow should be failed immediately when this error happens.

Same issue for me.  Took me a while to track it down (I didn't think of looking at the digdag log...).
I've got some tasks get are generating really long filenames:  e.g.
/mnt/apps/logs/dbaapps01.prod.fooz.com/digdag/sessions/2018-03-12/0.1refresh_scrub_databases@20180312T073750-0600/+refresh_scrub_databases+refresh_scrubbers^sub+for-0=my_class=0=prt+process_scrubbers+postmake_prt^sub+mask_scrub_prt+create_camo_validator_premask+validate_camouflage_masking^sub+for-0=project=0=SAPI.AS2<EMAIL_ADDRESS>
Which is throwing this message
2018-03-12 09:10:55 -0600 [ERROR] (task-thread-5) io.digdag.core.agent.MultiThreadAgent: Uncaught exception. Task queue will detect this failure and this task will be retried later.
java.lang.RuntimeException: java.nio.file.FileSystemException: /mnt/apps/logs/dbaapps01.prod.fooz.com/digdag/sessions/2018-03-12/0.1refresh_scrub_databases@20180312T073750-0600/+refresh_scrub_databases+refresh_scrubbers^sub+for-0=my_class=0=prt+process_scrubbers+postmake_prt^sub+mask_scrub_prt+create_camo_validator_premask+validate_camouflage_masking^sub+for-0=project=0=SAPI.AS2<EMAIL_ADDRESS>File name too long
	at com.google.common.base.Throwables.propagate(Throwables.java:160)
	at io.digdag.core.log.LocalFileLogServerFactory$LocalFileLogServer.newDirectTaskLogger(LocalFileLogServerFactory.java:150)
	at io.digdag.core.log.LogServerManager.newInProcessTaskLogger(LogServerManager.java:78)
	at io.digdag.core.agent.InProcessTaskCallbackApi.newTaskLogger(InProcessTaskCallbackApi.java:92)
	at io.digdag.core.agent.OperatorManager.run(OperatorManager.java:114)
	at io.digdag.core.agent.MultiThreadAgent.lambda$null$0(MultiThreadAgent.java:127)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

The error could be reproduced with local log-server. When we use S3 log-server, log files are not created on specified S3 path with any error messages.

@muga @toru-takahashi v0.9.26 fixed this issue. please take a look when you have time.


Cleanup migrations

This follows #701 with some cleanup:

Our current implementation doesn't make use of the name + schema overload of SqlGenerationHelper.DelimitIdentifier making for an overly verbose implementation.

Additionally, the NpgsqlMigrationsSqlGenerator.Rename expected already delimited names, while NpgsqlMigrationsSqlGenerator.Transfer expected names to not be delimited.

Cosmetically, this removes three annotations that are (now) already included in the base classes, so Rider/ReSharper is happy to let us omit them here.

@roji wrote:

This looks good, but I honestly think we can merge this work into #701, to have a single PR. I'm not sure it's critical to fix 2.1.x (we don't have any complaints), and even if we do we can consider backporting this entire work.

Okay, I'll close this and cherry-pick it to #701.


How to add more labels to nodes?

We know each node has the following properties:
title is the primary label for the node.
subtitle is a secondary label for the node.
expanded shows children of the node if true, or hides them if false. Defaults to false.
children is an array of child nodes belonging to the node.
But what if you want to attach more data to a node and display it in the tree? Can you add more labels to nodes? What is the best solution?
FYI an obvious quick and dirty solution would be to concatenate the data and store it in the two labels provided in the
Example:
{
    title: 'value1',
    sub-title: 'value2',
    id: 'value3' //this is an extra addition
    history: [], //this is an extra addition
    expanded: true,
    children: []
}

Something like this would work:
https://codesandbox.io/s/l92xx8wxp9

I came up with a similar solution myself. Thanks!


Ideas for V3

Because the V1 works but for small currents only and the V2 failed, I'm considering a new approach:

Use 4S 18650 to achieve 12.8 - 16.8 V which could then be connected to a much more efficient buck (step down) converter
Power the whole thing from 19 V or 24 V source, eliminating a need for boost converter charger
Use CC/CV capable buck DC-DC converter + BMS to charge the battries. The converter will take care of charging, BMS will protect the batteries.
Maybe add a disconnection circuit (or EN pin on the converter) to allow for a software defined charging stop.
Use 2nd buck converter on the output to produce 12 V (with >= 3A) from batteries
Use P-type MOSFET to control batteries output (to prevent continuous load sharing)
Optionally generate additional output voltages if needed (9V or 5V etc.), always with it's own additional buck converter.

This would also produce smaller currents compatible with INA219 and with narrower PCB traces.
Rough idea:

For example this step down https://www.laskakit.cz/step-down-menic-s-xl4016e1/ should handle up to 8A and convert 24V to anything between 2V - 22V.
Alwo with 24V / 16.8 V / 12V combo there's no need for a MOSFET to prevent load sharing: when powered the D2 diode has always 24V on cathode and <24V on anode and it won't conduct. Only when the input power drops below the battery voltage the D2 will turn on.

Updated schematic:

⚠ Don't forget that IRF5210 (and almost any other MOSFET) has |Vgs(max)| < 20V.
⚠ CC/CV buck converter has a separate GND on IN vs OUT. There's a shunt resistor between them and it must not be clamped otherwise the CC won't work. Separate GND1 and GND2 must be used there!
Simulation for controlling the IRF5210 using 3.3V source:

This should be within a safe Vgs range.

Good point on CCCV modules with isolated ground: https://forum.arduino.cc/t/using-constant-current-buck-converter-with-common-ground/861109/4


Switch to markdown readme

I actually don't know how much of ogg development will happen on GitHub but markdown readme suits it much better. You can preview markdown readme here: https://github.com/stopiccot/ogg/tree/readme_md

Merged upstream. Thanks!


Not taking advantage of Tegra K1

Running Boardwalk on an Nvidia Shield Tablet is extremely slow (~5 FPS) due to it emulating OpenGL 1.4 on OpenGL ES. The TK1 SoC supports OpenGL 4.4 and Boardwalk should be passing through to that instead of using OpenGL ES.

You should add a version of opengl to use or like if you have a nexus 9 or Nvidia Shield tablet use opengl 4.4, if you do not, do not change any opengl settings or something

Or maybe a different version of Boardwalk, like Boardwalk for tegra k1 or something and normal boardwalk in the store


Fixing nested dictionary with space in key

Changes included in the 1.8.0 release now live on NuGet


Hi this is Tofus, I'd like to join this project's community

Your public repo
https://github.com/Tofuswang/gov4git-identity-public.git
Your public branch
main
Your email (optional)
<EMAIL_ADDRESS>

Approved

tofuswang added to community.


CSV downloads on DoltLab are not currently supported

Attempting to download a zip or table CSV file on DoltLab results in a 404 not found page

Supported in DoltLab v0.5.0


Update health-alerts.md

Added the 'NTLM Auditing is not enabled' health alert

Docs Build status updates of commit d74c821:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

ATPDocs/health-alerts.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Trt execution provider

Is it necessary to abbreviate to TRT? TensorRT would be a lot more obvious as a prefix.

Steven, do you've CI setup for this or will that be a separate PR?

Steven, do you've CI setup for this or will that be a separate PR?
I am working on python binding and CI setup right now, and it will be a separate PR.


is it possible to open two websockets connection with SignalR

Hi.  I have been using your package for a while, so it works greate, but now I have a task which requires me to create two websockets connection. One channel is for taking about 50 photos (it comes from server having about 2MB size for each, which is pretty big), the second is for getting time, user's auth, keep user's data, so my question is:
How can I open two websockets connection concurrently?
I have read that the websocket works synchronously and it is impossible to make it asynchronous (I guess?...), so maybe you, as the creator of this package, can advise me something to solve this problem (if it exists)?
Now with SignalR package I need to start my websockets connection every time I want to use request to the server. For example, now it looks like this:
The first request on page
 Future<String> getTime()async{
    //some code for building url which I took from from SignalR official docs

    await connection.start()
    hubconnection.invoke('getTime');
    }

the second page:
Future<String> getUsersData()async{
    //some code for building url which I took from from SignalR official docs

    await connection.start()
    hubconnection.invoke('getUsersData');
    }

So I am not sure about this line: await connection.start() because I think this means that every time I go to a page where there can be up to five such requests, the websocket starts every time, which greatly affects the performance of the app. Is it possible to make this line shared between all requests once or is there some way to improve the work?
PS I am working on the prev version of you package not the recent one.
Thanks you!

Currently it is not possible to open two signalr connections concurrently. This is something absolutely doable but needs some development.

Hi :) thanks for replying, I will be waiting for the new feature :)

This could have been easily avoided if the service wasn't a static class, easy fix and I simply cannot wait for an update, considering last update was 10 months ago. I'll be forking this project with these changes as its a necessity for my app; and appears to be no other alternative flutter plugins yet!
I'll repost with the forked branch here shortly.

Here's an example of how I have gotten it to work. I have forked his code so you will need to add this to your pubspec.yaml
  signalr_flutter:
    git:
      url: https://github.com/joseph-lewis/signalr_flutter
      ref: master

then in terminal,
flutter clean;flutter pub get;flutter packages upgrade
I haven't found a way to achieve this without the Future.delayed, as it happens too quick and then some SignalR connections get missed. But this now fits my requirements for multiple SignalR connections, and hope it does for you too.
Here's the example below - (Note the only change the to SignalR object is the starting parameter, where it requests an ID field as a string, so it can identify the different SignalR's. I keep track of these SignalR connections in a Map where the key is the ID, and the value is the SignalR object.
Note: I have only spent a couple of hours on this tested both ios and android which work. I will test more soon and make sure everything works as expected. Let me know if you find anything.
Map<String, SignalR> signalRMap = {};

for (int tripId in tripIdList) {
        if (signalRMap[tripId] != null) {
          print("SignalR ($tripId) - Already in signalR LIST! Continue -");
          continue;
        }

        var signalR = SignalR(tripId.toString(), signalRURL, "broadcastHub",
            hubMethods: hubMethods,
            statusChangeCallback: (value) {
              print("SignalR Status: " + value);
            },
            headers: headers,
            queryString: "token=$authKey",
            hubCallback: (methodName, message) => processMessage(message));
        signalRMap[tripId] = signalR;
        print("SignalR Status: " + "Connecting");

        var success = await signalR.connect();
        await Future.delayed(Duration(milliseconds: 500));
        serviceActive = true;

        if (success == true) {
          await signalR.invokeMethod("appWatch", arguments: ['$tripId']);
          print("SignalR Status:" + "Send App Watch");

          await Future.delayed(Duration(milliseconds: 500));
        }
      }


Reuse same AVPlayer instance

We are currently throwing away and re-creating the AVPlayer. It would be nicer if we just reused the same instance and exchanged the item if the source changes.

@johanneslumpe - are there any tradeoffs here? what is the cost of throwing away & creating a new one?

@brentvatne: I am going back and forth in the  in my small app, which has a page that loads .
Everytime i go to the page with , memory usage jumps by around 70MB. I think thats cos new instance is alloc'ed each time.

@eduedix - that sounds like a good enough reason right there! thanks

It would be indeed useful to have an API, which could let me kill the instance. It seems having only 1 instance is still not the optimum solution.

@eduedix - ideally how would you like to manage this?

@eduedix it's one instance per element, not sure why you need multiple players per element?

@brentvatne at the very least we'd save the cost of allocating a new instance. It might not be a huge optimization, but less allocation is always better ;)

@brentvatne @johanneslumpe I am still in for only one instance. But it seems instance stays on in the background forever.

@brentvatne @eduedix I just pushed a small fix branch for this.
https://github.com/brentvatne/react-native-video/tree/feature/fix-unremoved-playerlayer
After that gets merged, you should see a significant memory drop, when removing the view with the video.


adout  "sprop-parameter-sets=" is Connection error ,

When I connect to the camera RTSP stream, receive the parse parameter 'sprp-parameter sets=', I output a connection error. In fact, after I remove the judgment about 'sprp-parameter sets=' in the source code, the video is played normally

I have the same problem, did you solve it?


Cache service responded with 500

I have constantly returned cache service respond with error 500 for one of my projects:
Run msys2/setup-msys2@v2
Restoring package cache...
  Error: getCacheEntry failed: Cache service responded with 500

Other projects with same github actions work fine!

Looks like the issue in actions/cache - https://github.com/actions/cache/issues/698

I hit it once too getCacheEntry failed: connect ETIMEDOUT <IP_ADDRESS>:443
Maybe we should be more forgiving in that case?

I think it might have been some temporary reliability issue on GitHub's side. @chronoxor is it still happening?

Maybe we should be more forgiving in that case?

Is there an explicit way of filtering that error apart from string matching?

Maybe we should be more forgiving in that case?

Is there an explicit way of filtering that error apart from string matching?

Not sure. Since even official actions failed and this was a real problem on GH's end maybe we shouldn't.

The issue was fixed on actions/cache side! The issue can be closed. But I think it's good idea to continue somehow even if cache is not available.


weather: ensure correct size

the curl to wttr.in returns a result 125 characters wide that does not display nicely on smaller terminals.
Therefore, if terminal smaller than 125 characters, get a less detailed weather view.

Batman approves


scrollbars don't work properly in Select and SelectBox

There's some issue with scrollbars (ScrollView) in Select and SelectBox components

@AustralianAI hey! I really appreciate it. And sorry for such late response.
So the issue happens when you try to scroll by dragging the scrollbar thumb - it doesn't work in Select and SelectBox component. Feel free to ask any questions if you get stuck with something

@AustralianAI and by the way, you can test the behavior on our demo app


API Basejump: URL shortener

User stories:

I can pass a URL as a parameter and I will receive a shortened URL in the JSON response.
When I visit that shortened URL, it will redirect me to my original link.

Happy to do this one!

Hi @george-stepanek this is a good start, but I was hoping that instead of using an existing URL shortener (Google's), this would actually create a new record in the database with both a shortened URL and the full URL it corresponds to. And then if you tried to visit that short URL, it would forward to the full URL.
Thus, if your domain was urlshortener.herokuapp.com, I could do urlshortener.herokuapp.com/http://google.com and it would return urlshortener.herokuapp.com/fdS542, and when I then went to urlshortener.herokuapp.com/fdS542, it would take me to google.com.
Could you implement this?

How's this?
https://shurli.herokuapp.com/
Can create with:
https://shurli.herokuapp.com/new/https://www.google.com
or
https://shurli.herokuapp.com/new/www.google.com
I might need more to check if url is valid, otherwise might mess up code if someone creates a url of a short id

@QuincyLarson Happy to make that change, but it looks like @HermanFassett is already onto it... :)

Updated to check for . in url so short id's won't be posted. Also fixed error with not including queries.
I'm also thinking of adding custom short urls. Do you think that could be a possible bonus user story?

@george-stepanek I agree - @HermanFassett's app looks like exactly what we need.
@HermanFassett Wow - this works great! Yes - I think it should ensure it's a valid URI first and return an error if it isn't. I'm adding that to the user stories above.

@HermanFassett I've updated the user stories. I see that your app already detects invalid URLs (though you might want to tighten up the regex it uses to check them a bit), so I will mark this issue as closed, and we will use your project as the example project for the Basejump. Great work here, to both you and @george-stepanek!

@HermanFassett  I'm getting a Heroku application error when I click the link. Problem with Procfile maybe??

@Deftwun I'm not at home with a computer but I'll check into it when I get a chance, thanks for letting me know

@Deftwun the logs weren't enlightening and restarting the app made it live again, but I'll keep my eye out for what could have caused that.


A version in Python

Basically the same as your Go version + CNAME support (it addresses #2). https://www.bortzmeyer.org/files/tiny-resolver.py You are welcome to include it in your Github repository / article if you wish.

added to the README, thanks!


default rgbd_dataset_freiburg1_desk.yaml

It seems to have turned out a little poorly.

Hey there,
Can you please post PSNR and ATE? Also, keep in mind, that for TUM many regions are unobserved and the depth map quality is poor. This leads to artifacts caused by a single-view SLAM setup.


Commenting On CodeBase

I Will Be Working On This Issue So First Comers Will Have No Problem In Understanding CodeBase Of This Project

Also fix the indentations (use tab) and make the code look prettier and easier to read.


Documentation for vercel

Adds the hint how to host on vercel in the misc section

@loreanvictor ping ❤

@loreanvictor ping ❤

Thanks for the ping! I will merge this on Friday alongside a bunch of other updates. Thanks again!


Confirm with Platform services that we support node 14 or node 16?

Acceptance Criteria

[ ] Answer this question

as part of the some future EOL planning I am doing for our 3rd party apps ecosystem, we are planning on upgrading all 3rd party apps to Node 16 in March 2022 since Node 12 is EOL as of April 2022. Are there any reasons why we should not upgrade to Node 16?

I've asked #help-nr1-platform-services for direction here.


Class not found DatatypeFactory

Getting this error when trying to use the library in a fragment:
 java.lang.ClassNotFoundException: Didn't find class "org.apache.xerces.jaxp.datatype.DatatypeFactoryImpl" on path: DexPathList[[zip file "/data/app/net.ddns.himion0.yoke-1/base.apk"],nativeLibraryDirectories=[/data/app/net.ddns.himion0.yoke-1/lib/arm64, /vendor/lib64, /system/lib64]]
... 27 more
     Caused by: java.lang.NoClassDefFoundError: Class not found using the boot class loader; no stack trace available

This inside the main Activity after the SugarContext.init(getApplicationContext()) is called
java.lang.NoSuchFieldException: No field mFlags in class Landroid/service/media/MediaBrowserService$Result; (declaration of 'android.service.media.MediaBrowserService$Result' appears in /system/framework/framework.jar:classes2.dex)

I got the same error a few hours ago - solved it by updating version of sugar to 1.5 from 1.4 - Multidex was not working in 1.4. It might be the case here too...

I tried adding:
 compile 'com.github.satyan:sugar:1.5'
to the build.gradle file however I coudn't get it to run

Confirmed worki


[pigeon] Fix some straggler lint issues in the codegen

Use case
We still have to manually edit the generated code before we can submit because our linter blocks submission.
These are the particular lints that still block:

Java classes need to be final.
public interface Reply should have javadoc
channelReply -> { callback.reply(null); } can be written as channelReply -> callback.reply(null)

Proposal
Fix the codegen to correct the above or add annotations to ignore them.

I tried turning on the FinalClass check and it didn't find any problems in any of the code I was generating (https://checkstyle.sourceforge.io/apidocs/com/puppycrawl/tools/checkstyle/checks/design/FinalClassCheck.html).  Know more about where this is showing up?

  /** Generated class from Pigeon that represents Flutter messages that can be called from Java. */
  public static final class TimerRepositoryApi {
    private final BinaryMessenger binaryMessenger;

    public TimerRepositoryApi(BinaryMessenger argBinaryMessenger) {
      this.binaryMessenger = argBinaryMessenger;
    }
    /** Generated class from Pigeon that represents a Reply. */
    public interface Reply<T> {
      void reply(T reply);
    }

    public void activate(Reply<Void> callback) {
      BasicMessageChannel<Object> channel =
          new BasicMessageChannel<>(
              binaryMessenger,
              "dev.flutter.pigeon.TimerRepositoryApi.activate",
              new StandardMessageCodec());
      channel.send(null, channelReply -> callback.reply(null));
    }

    public void deactivate(Reply<Void> callback) {
      BasicMessageChannel<Object> channel =
          new BasicMessageChannel<>(
              binaryMessenger,
              "dev.flutter.pigeon.TimerRepositoryApi.deactivate",
              new StandardMessageCodec());
      channel.send(null, channelReply -> callback.reply(null));
    }

    public void setTimerData(TimerData argInput, Reply<Void> callback) {
      BasicMessageChannel<Object> channel =
          new BasicMessageChannel<>(
              binaryMessenger,
              "dev.flutter.pigeon.TimerRepositoryApi.setTimerData",
              new StandardMessageCodec());
      Map<String, Object> inputMap = argInput.toMap();
      channel.send(inputMap, channelReply -> callback.reply(null));
    }
  }

  private static Map<String, Object> wrapError(RuntimeException exception) {
    Map<String, Object> errorMap = new HashMap<>();
    errorMap.put("message", exception.toString());
    errorMap.put("code", exception.getClass().getSimpleName());
    errorMap.put("details", null);
    return errorMap;
  }

Can anybody update me on the state of this issue? I'd like to try and resolve some of these issues if they are still prevalent.

@tarrinneal these bugs are still relevant for Google. I don't think they've been addressed since.


ignore protocl case

Closing this due to a lack of feedback. Please come back with more details if you think this is still relevant and we can reopen this :+1:


Extract oro/property-access

At the moment oro/config depends on classes from the property access component. In order to reference these classes, oro/property-access should be extracted into a subtree split and uploaded to Packagist.
I will submit a separate PR to incorporate these changes into the config component.

Hi, @z38. Thank you very much for your pull request! It was merged to development branch, soon you'll see it at master.


Fix DispatchMiddlewareFactory duplicate

Provide a narrative description of what you are trying to accomplish:
In version 2.2.0 The DispatchMiddleware::class is an invokable, but it also has a factory. The factory is used in zend-expressive-router and is causing a conflict. The DispatchMiddlewareFactory should be used instead.

[x] Are you fixing a bug?

[x] Detail how the bug is invoked currently.
[x] Detail the original, incorrect behavior.
[x] Detail the new, expected behavior.
[x] Base your feature on the master branch, and submit against that branch.
[ ] Add a regression test that demonstrates the bug, and proves the fix.
[ ] Add a CHANGELOG.md entry for the fix.

Only merge it into 2.2.0?


Fab cannot float correctly while the window is narrow

For example on the mobile browser the FAB is stick to the bottom of the layout but not float.
If this is bug? In desktop browser the FAB is works very well. I think this issue is easy to reproduce.

It looks like I am doing something wrong but I don't know what's is wrong...
The example FAB looks good on mobile browser.

The position is fixed, so I am not sure what is going on. Can you show some reproducible code?

Let me extract to some example code, will attach it later.

I used react-tiny-fab in one of my repo.
I created a component named MenuFab. Just abstract the properties into objects.
Then I used this component in a page, just passing some property objects into it.
Finally I render this in a semantic-ui-react component Container.
To illustrate the issue, attached some screenshots.

in desktop it works fine.

in narrow window (to mimic the mobile browser), the fab disappear.

indeed it sticks to the bottom of the page, is not floating now.

I thought I have made some mistakes because in your document page there is not such issue.

I would like to see the dev tools and check out the element to see if some style is being overwritten. If you look at the docs page of this library and change the width to mimic mobile, you'll see that the FAB acts as expected. If you could create a codesandbox to show the reproducible code, I could better debug it. It's hard to say with only seeing screenshots.

OK, I will try to repro the issue in CodeSandbox.

I am going to close this for now but feel free to ping me if you can reproduce this.

@dericgw I could reproduce this on a very narrow width
check https://aabuhijleh.com please

@shanhuiyang were you able to fix this?


[Doc Improvement][Build outgoing webhooks-SBS][2716678]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-outgoing-webhooks.yml
86
9
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit c56e54d:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/concepts/deploy-and-publish/appsource/prepare/teams-store-validation-guidelines.md
:warning:Warning
View
Details

msteams-platform/sbs-outgoing-webhooks.yml
:warning:Warning
View
Details

msteams-platform/concepts/deploy-and-publish/appsource/prepare/teams-store-validation-guidelines.md

Line 965, Column 238: [Warning: bookmark-not-found] Cannot find bookmark '#botmessagespamming' in 'concepts/deploy-and-publish/appsource/prepare/teams-store-validation-guidelines.md'.
Line 0, Column 0: [Suggestion: disallowed-domain] Url 'https://www.microsoft.com/legal/intellectualproperty/trademarks/usage/general' references a disallowed domain 'https://www.microsoft.com'. This poses a security risk.
Line 0, Column 0: [Suggestion: disallowed-domain] Url 'https://www.microsoftvolumelicensing.com/DocumentSearch.aspx?Mode=3&DocumentTypeId=46' references a disallowed domain 'https://www.microsoftvolumelicensing.com'. This poses a security risk.
Line 0, Column 0: [Suggestion: disallowed-domain] Url 'https://support.office.com/article/use-markdown-formatting-in-teams-4d10bd65-55e2-4b2d-a1f3-2bebdcd2c772' references a disallowed domain 'https://support.office.com'. This poses a security risk.
Line 0, Column 0: [Suggestion: disallowed-domain] Url 'https://www.microsoft.com/legal/intellectualproperty/trademarks' references a disallowed domain 'https://www.microsoft.com'. This poses a security risk.
Line 88, Column 2: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'br' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 89, Column 2: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'details' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 124, Column 2: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'br' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 125, Column 2: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'details' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 152, Column 2: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'br' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 153, Column 2: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'details' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 180, Column 2: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'br' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 181, Column 2: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'details' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 210, Column 2: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'br' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 211, Column 2: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'details' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 226, Column 2: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'br' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 227, Column 2: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'details' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 262, Column 2: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'br' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 265, Column 2: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'details' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 362, Column 2: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'br' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 363, Column 2: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'details' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 389, Column 2: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'br' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 390, Column 2: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'details' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 517, Column 2: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'br' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 518, Column 2: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'details' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-outgoing-webhooks.yml
87
9
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-outgoing-webhooks.yml
87
11
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit fe5b0f9:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

msteams-platform/sbs-outgoing-webhooks.yml
:x:Error

Details

msteams-platform/sbs-outgoing-webhooks.yml

Line 122, Column 5: [Error: invalid-image] Invalid attribute.
Line 30, Column 1: [Warning: file-not-found - See documentation] Invalid file link: '../assets/images/sbs-outgoing-webhooks/output-result1.png'.
Line 56, Column 5: [Warning: file-not-found - See documentation] Invalid file link: '../assets/images/sbs-outgoing-webhooks/clone-repository.png'.
Line 65, Column 4: [Warning: file-not-found - See documentation] Invalid file link: '..assets/images/sbs-outgoing-webhooks/manage-team.png'.
Line 69, Column 4: [Warning: file-not-found - See documentation] Invalid file link: '..assets/images/sbs-outgoing-webhooks/app-selection.png'.
Line 79, Column 4: [Warning: file-not-found - See documentation] Invalid file link: '.../assets/images/sbs-outgoing-webhooks/create-outgoing-webhook.png'.
Line 98, Column 5: [Warning: file-not-found - See documentation] Invalid file link: '.../assets/images/sbs-outgoing-webhooks/select.png'.
Line 105, Column 6: [Warning: file-not-found - See documentation] Invalid file link: '.../assets/images/sbs-outgoing-webhooks/security-token.png'.
Line 114, Column 5: [Warning: file-not-found - See documentation] Invalid file link: '.../assets/images/sbs-messagingextension-action/VSopenfile.png'.
Line 118, Column 5: [Warning: file-not-found - See documentation] Invalid file link: '.../assets/images//sbs-outgoing-webhooks/open-project.png'.
Line 128, Column 5: [Warning: file-not-found - See documentation] Invalid file link: '.../assets/images//sbs-outgoing-webhooks/outgoing-webhook-certificate.png'.
Line 132, Column 5: [Warning: file-not-found - See documentation] Invalid file link: '.../assets/images//sbs-outgoing-webhooks/outgoing-webhooks-ready.png'.
Line 143, Column 4: [Warning: file-not-found - See documentation] Invalid file link: '.../assets/images/sbs-outgoing-webhooks/type-mention.png'.
Line 152, Column 4: [Warning: file-not-found - See documentation] Invalid file link: '.../assets/images/sbs-outgoing-webhooks/output-result.png'.
Line 159, Column 4: [Warning: file-not-found - See documentation] Invalid file link: '.../assets/images/sbs-outgoing-webhooks/output-result1.png'.
Line 0, Column 0: [Suggestion: disallowed-domain] Url 'https://www.microsoft.com/microsoft-teams/download-app' references a disallowed domain 'https://www.microsoft.com'. This poses a security risk.
Line 0, Column 0: [Suggestion: disallowed-domain] Url 'https://visualstudio.microsoft.com' references a disallowed domain 'https://visualstudio.microsoft.com'. This poses a security risk.
Line 0, Column 0: [Suggestion: disallowed-domain] Url 'https://ngrok.com/download' references a disallowed domain 'https://ngrok.com'. This poses a security risk.
Line 0, Column 0: [Suggestion: disallowed-domain] Url 'https://github.com/OfficeDev/Microsoft-Teams-Samples' references a disallowed domain 'https://github.com'. This poses a security risk.
Line 41, Column 83: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'br' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 41, Column 131: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'br' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 41, Column 170: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'br' isn't allowed.  Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-outgoing-webhooks.yml
87
11
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit e48947d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/sbs-outgoing-webhooks.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-outgoing-webhooks.yml
87
11
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit 7c92779:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/sbs-outgoing-webhooks/app-selection.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/clone-repository.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/create-outgoing-webhook.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/manage-team.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/open-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/outgoing-webhooks-ready.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/output-result.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/output-result1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/security-token.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/Select.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/type-mention.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/update-hmac2.png
:white_check_mark:Succeeded
View

msteams-platform/sbs-outgoing-webhooks.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-outgoing-webhooks.yml
87
11
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-outgoing-webhooks.yml
84
14
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit 116e32d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/sbs-messagingextension-action/VSopenfile.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/app-selection.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/clone-repository.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/create-outgoing-webhook.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/manage-team.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/open-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/outgoing-webhooks-ready.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/output-result.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/output-result1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/security-token.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/Select.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/type-mention.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/update-hmac2.png
:white_check_mark:Succeeded
View

msteams-platform/sbs-outgoing-webhooks.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-outgoing-webhooks.yml
84
14
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit ae7dfb1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/sbs-messagingextension-action/VSopenfile.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/app-selection.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/clone-repository.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/create-outgoing-webhook.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/manage-team.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/open-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/outgoing-webhooks-ready.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/output-result.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/output-result1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/security-token.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/Select.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/type-mention.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/update-hmac2.png
:white_check_mark:Succeeded
View

msteams-platform/sbs-outgoing-webhooks.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-outgoing-webhooks.yml
87
11
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit 2fbe2f5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/sbs-messagingextension-action/VSopenfile.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/app-selection.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/clone-repository.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/create-outgoing-webhook.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/manage-team.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/open-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/outgoing-webhooks-ready.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/output-result.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/output-result1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/security-token.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/Select.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/type-mention.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/update-hmac2.png
:white_check_mark:Succeeded
View

msteams-platform/sbs-outgoing-webhooks.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-outgoing-webhooks.yml
87
11
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit 1e5edbb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/sbs-messagingextension-action/VSopenfile.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/app-selection.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/clone-repository.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/create-outgoing-webhook.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/manage-team.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/open-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/outgoing-webhooks-ready.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/output-result.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/output-result1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/security-token.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/Select.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/type-mention.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/update-hmac2.png
:white_check_mark:Succeeded
View

msteams-platform/sbs-outgoing-webhooks.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-outgoing-webhooks.yml
87
11
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit d82cb69:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/sbs-messagingextension-action/VSopenfile.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/app-selection.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/clone-repository.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/create-outgoing-webhook.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/manage-team.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/open-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/outgoing-webhooks-ready.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/output-result.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/output-result1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/security-token.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/Select.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/type-mention.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/update-hmac2.png
:white_check_mark:Succeeded
View

msteams-platform/sbs-outgoing-webhooks.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-outgoing-webhooks.yml
87
11
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit 06ec755:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/sbs-messagingextension-action/VSopenfile.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/app-selection.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/clone-repository.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/create-outgoing-webhook.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/manage-team.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/open-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/outgoing-webhooks-ready.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/output-result.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/output-result1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/security-token.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/Select.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/type-mention.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/update-hmac2.png
:white_check_mark:Succeeded
View

msteams-platform/sbs-outgoing-webhooks.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-outgoing-webhooks.yml
87
11
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit 68e42e3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/sbs-messagingextension-action/VSopenfile.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/app-selection.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/clone-repository.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/create-outgoing-webhook.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/manage-team.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/open-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/outgoing-webhooks-ready.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/output-result.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/output-result1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/security-token.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/Select.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/type-mention.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/update-hmac2.png
:white_check_mark:Succeeded
View

msteams-platform/sbs-outgoing-webhooks.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-outgoing-webhooks.yml
87
11
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit c56a98a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/sbs-messagingextension-action/VSopenfile.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/app-selection.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/clone-repository.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/create-outgoing-webhook.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/manage-team.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/open-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/outgoing-webhooks-ready.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/output-result.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/output-result1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/security-token.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/Select.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/type-mention.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/update-hmac2.png
:white_check_mark:Succeeded
View

msteams-platform/sbs-outgoing-webhooks.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-outgoing-webhooks.yml
87
11
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit c05b2e1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/sbs-messagingextension-action/VSopenfile.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/app-selection.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/clone-repository.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/create-outgoing-webhook.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/manage-team.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/open-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/outgoing-webhooks-ready.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/output-result.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/output-result1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/security-token.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/Select.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/type-mention.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/update-hmac2.png
:white_check_mark:Succeeded
View

msteams-platform/sbs-outgoing-webhooks.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/sbs-outgoing-webhooks.yml
87
11
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit f2dd955:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/sbs-messagingextension-action/VSopenfile.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/app-selection.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/clone-repository.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/create-outgoing-webhook.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/manage-team.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/open-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/outgoing-webhooks-ready.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/output-result.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/output-result1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/security-token.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/Select.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/type-mention.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/sbs-outgoing-webhooks/update-hmac2.png
:white_check_mark:Succeeded
View

msteams-platform/sbs-outgoing-webhooks.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Enable python 3.8

Hello,
The last major version of our beloved language was released on 14th october
https://www.python.org/dev/peps/pep-0569/#id6
This PR activate it :

[x] Add classifier to be installable via pip
[x] Add to CI

Also, doing this I have notice that CI was running on the same version : 3.6.3.
For example, https://travis-ci.org/squeaky-pl/japronto/jobs/521410512#L449 run on 3.6.3 but 3.5.3 was expected

Thank you.

@squeaky-pl is a release planned so as a wheel will be available on pypi ?

Still waiting for python 3.8 version on pypi. :eyes:
ERROR: Could not find a version that satisfies the requirement japronto (from -r requirements.txt (line 1)) (from versions: none)
ERROR: No matching distribution found for japronto (from -r requirements.txt (line 1))


fix: revert builtin components width control to use styled components

I tested every built-in component's width locally, and they look great.

I tested every built-in component's width locally, and they look great.

There were some components—I think Navigation was one of them—that re-used some of the builtin components like Button and Image. When I moved these to a class I accidentally shipped some bugs because it was very hard to see where those props were being passed (some of them were just spread). Did you check for that too @fikrikarim?

I tested every built-in component's width locally, and they look great.

There were some components—I think Navigation was one of them—that re-used some of the builtin components like Button and Image. When I moved these to a class I accidentally shipped some bugs because it was very hard to see where those props were being passed (some of them were just spread). Did you check for that too @fikrikarim?
It's possible that for those my solution was moving it back to Styled Components so this might not be an issue

Ah you're right. I missed those. I updated the Image and Button. There should be no more components that use responsiveWidth directly.


Fix typo in fallback corefile and make fallback corefile match template

@frenck This has nothing to do with our current discussion. The first commit fixes a clear bug. The second commit simply makes the fallback corefile match the template corefile. The template corefile was likely updated and the fallback corefile was overlooked.