Update "Be the first person to comment!" screen when you start a new DM

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
Sent DM message to someone I hadn't messaged before
Expected Result:
The blank screen should have avatars, a message for "This is the beginning of your chat history with XXXX (pronouns), as well as showing the timezone above the message input when messaging someone 1:1.
Actual Result:
Only see "Be the first person to comment!"
Solution
Let's update this state/area to include the users icon, name, preferred pronouns and the time in their time zone (only if 1:1 DM).

Design files are here in Figma
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Expensify/Expensify Issue URL: link
View all open jobs on Upwork
Upwork job: https://www.upwork.com/jobs/~0159561fdd76ccd036

Triggered auto assignment to @michaelhaxhiu (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@mallenexpensify
What's it gonna be for the new group chat?

Great point @Santhosh-Sellavel ! I addressed your question in an old internal issue we had been working on, I instructed folks to post comments/feedback to this issue.  We have two choices

Address group chats in this GH and figure out what we want before posting the job.
Only focus on the single DM usecase for now and address groups later.

Is this going to be external? @mallenexpensify

It will very likely be external @Santhosh-Sellavel , @michaelhaxhiu needs to triage the issue first, part of that is figuring out what we want to do about group messages.  My hunch is it's best to fix this issue specifically for the 1:1 DM usecase now then create a new issue in the future to address both group messages and possibly rooms.
@michaelhaxhiu, this shouldn't require a designer, an engineer should be able to take care of everything

Great question about the group. I want to say lets work on how the 1:1 looks like and then probably handle the group in a new GH to keep things neat and tidy. I'd love to say whatever we use for 1:1 will work for the group but ard to say that as of now :)

@megankelso @michelle-thompson I vaguely recall that we explored what this screen would look like for various use cases... actually I think it was @michelle-thompson that did it for Concierge Travel.
So basically we could do something like this?

And maybe before we have those features ready to go, we could just use a generic message for the group situation like so:

And then in terms of scalability, looks like Michelle had mocked up something like this for when a group has lots of participants:

Cool, happy to move forward with the generic messaging you've mocked up above!

Sweet, so I think maybe we want to make the avatars in my mockup a bit smaller like your original mocks (the one at the bottom) for scalability purposes. Otherwise, then I think we just need to decide if we're going to add Group chats to the exported Upwork issue?

Ahh, you mean so the size of the avatar never has to change? And I figure might as well add group chats to this issue.

Yeah, I think I like the size you had here:

...better than the larger size I used. So that gives us something like this:

Agreed, I think that looks good too

I agree, this looks good! I do wonder if we should make this a bit more consistent. What comes to mind for me is using the existing UI pattern to show local time (above the chat input) and including the same "this is the beginning for your chat" message, but perhaps adding the pronouns. Curious for thoughts?

I'm into it! Curious what this would look like if you were to DM someone in the same time zone?

I'm suggesting it still show the time for the first chat, regardless of what time zone. Curious if you had something else in mind?

Ahhh, I see. I think that would be fine too, I'm keen with either direction!

Oh, I really like that idea about the timezone. Actually taking this a step further, perhaps the name above the message for the 1:1 case is redundant as well? So that leaves us with this:

yes, agreed! we can drop the name. I like the addition of pronouns to the group but I'm not sure how scaleable it is for larger group chats. For example, if we added them to the next screen:

Curious for thoughts. would it be weird to make a rule that pronouns are included only for group chats of 3 people and under or so?

I think you can have up to eight people in DMs, so it's possible to include pronouns for everyone! It looks a little busy, but I don't particularly mind that since this screen is temporary.

I agree, I think it will be okay. It's probably not very likely that all 8 members of the group will have their pronouns set anyways.

@michaelhaxhiu Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@shawnborton @michelle-thompson will let you @michaelhaxhiu know when he should review it for triage? Also.. huge, double plus, bonus points if you can update the OP with the deliverables for the contributors.

Cool, I updated the original comment with the new screenshots, I think this is ready for @michaelhaxhiu

Triggered auto assignment to @puneetlath (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Posted to upwork just now, and added job link in GH body.

As shown in the picture, I suggest we can fix this by placing it above the text input not at the centre in a fixed position.
reasons:
1 - on smaller screens fixed positions (which is the centre) will be under the keyboard. so it will not be visible. above the keyboard, we can use keyboard avoiding view and will be in the best position, not mater user have a smaller or larger device
2 - by default keyboard should be open (auto-focused) because the user is here to start the chat. this will  reduce one more step
3 - In a group chat, we should see only two in that group and with others tag if he clicks other we can show other people in that chat as details, otherwise the user could be overwhelmed.
4 - I recommend "write a message" over "say hello" because it is not a social app or fun app, a professional app should use professional words.

I like the feedback that the keyboard should be open by default on mobile devices. However, let's please stick with our mockups where the empty state is vertically centered in the available empty space. We also want to keep "Say hello" as it's in line with our brand tone.

That's a good start @MirFahad58, nice!
I agree with Shawn's feedback regarding sticking to vertical centering, as shown in the mockups.

I like the feedback that the keyboard should be open by default on mobile devices.

Good call, one less step for the user. Can you show a quick screenshot of this screen with the keyboard expanded?

Ok

Sounds good. @puneetlath is assigned to review proposals here.

this one is with sticking to vertical centring.

and this one is for what I was suggesting.

Please stick with the style from our mockups. It looks like your mockups have a different font as well as the timezone being centered.

yeah, I just wanted to share the idea, just created my separate mock to get ideas and work around it.

the development will be based on styles from your mockups.

@michaelhaxhiu FYI I'm focused on allocations and then OOO the rest of the week, so going to unassign myself.

Triggered auto assignment to @roryabraham (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Okay, despite not making a formal proposal, it seems like @MirFahad58 has a pretty good grip on this task. @MirFahad58 If you're interested in working on this, can you please write up a proposal for how you would implement this in the code?

yeah sure @roryabraham

First, I will understand the flow in the app, and what you guys had used (like a UI library) or used custom components, so text inputs and other components must be already there, I will reuse with my purpose and styling, And again I will look in the code structure, how flexes are implemented.. etc
I will start from the build a basic structure of the screen by adding flexes for each section, after that the header part and make a separate one so we can reuse it for different chats like group chats etc.
After that will create a custom avatar as a separate component so we can pass the source and height width as props;
Conditionally if there is no chat history we will show the "be the first person to comment" screen. and Input will have autoFocus so the keyboard should auto open.
but for all this, I have to go through the code base and see which components are prebuilt and I can reuse those.

Okay, good enough for me @MirFahad58. @michaelhaxhiu let's hire @MirFahad58 on Upwork.
@MirFahad58 Since I believe this will be your first pull request in this repo, let me give you some pointers to help you succeed and to help ensure that the PR review moves quickly. I strongly recommend that you read over these resources before submitting your PR and refer to them as needed while you work:

Please read our JavaScript style guide.

If necessary, prefer the use of Underscore.js over built-in JavaScript array methods. Underscore has lots of useful utilities and generally has better null-checking.
Also use lodashGet instead of any optional chaining.

Read over the style guide. This provides guidance on creating styles in this repo. We want to keep our styles as generic and reusable as possible.
Read over the structure of the app. In particular, the directory structure, file naming/structure, and platform-specific style extensions will be relevant in this PR. We do not use the react-native Platform library (i.e: no Platform.select).
Read the contributing guidelines.

Thanks! If you have any questions, refer to "asking questions" in the contributing guidelines.

Ok thanks

In terms of building the empty state component, keep in mind that this component will be reused for rooms as well. So we want to make sure we can extend this component to support a custom room avatar and a custom message below the avatar as well:

Yeah sure

Hired on upwork!

Started working on the issue, linted the code, but was unable to commit. need someone to help.

getting verified tag for commits on other repos but unable to commit on this one, getting gpg error and already done with gpg step by step process.

@MirFahad58

commit on this one?

Are you trying to push your changes directly in this repo

no, forked and created a new branch.

getting this error

Are you using the GUI to commit?
If then, check whether you configured git settings correctly.
Try in the terminal using the following command, this works like charm!

git commit -S -m "Your Commit message"

@Santhosh-Sellavel  Same for both

Try going through this documentation, This will help.
https://docs.github.com/en/github/authenticating-to-github/managing-commit-signature-verification/signing-commits
Clone the repo in a new folder, try to set up this first! @MirFahad58

resolved, thanks a lot @Santhosh-Sellavel

I need to know, do I have to just create the screen or have to integrate with data also?
I am not clear.

@michaelhaxhiu @roryabraham done with the issue, here are the screenshots before creating PR I am improving the code. but here is the 1st look.

all test cases are passed.

Hi @MirFahad58 - it looks like you are not using the correct style for the timezone. Please reference the mockups for the correct styles, but we should already have these styles in place as we currently show the timezone for a user when you message someone outside of your own timezone.
Could you also please put a space   between the Name and (pronouns) as well? Thanks!

Yeah already done screenshot were little bit old

Sounds good, we look forward to seeing your PR!

@shawnborton pull request should be to "main" branch?

@MirFahad58 yup, that is correct.

need help how to sign CLA

CLA - You must sign our Contributor License Agreement by following the CLA bot instructions that will be posted on your PR
https://github.com/Expensify/App/blob/main/CONTRIBUTING.md#user-content-submit-your-pull-request-for-final-review

Are you still having issues @MirFahad58 ?

No thanks

As an update:

@MirFahad58 has updated his PR and we are waiting on @shawnborton to review.
I inquired with @roryabraham in New Expensify to see if he may be able to review it sooner.
If not, let's wait on Shawn to review monday/tuesday of next week.

@MirFahad58 you had a few questions in Upwork Chat about payment earlier today, so I wanted to refer you to the Payment for Contributors section of the Contributing to Expensify guide. If you have follow up questions, let's discuss on this GH issue per the instructions. Thanks!

Ok, I got it no more questions.

Update:

@MirFahad58 had some personal commitments last week, and was able to update the PR for review https://github.com/Expensify/App/pull/4921#issuecomment-917553733
Next up, we are waiting on Rory to review

Hi @MirFahad58, I've placed this issue on hold as per this update, as we are prioritising issues related to a feature release scheduled for 9/24. As an apology for the delay, we will add a $100 bonus as a thank you for waiting.

@kadiealexander  ok thanks i will wait for that.

I added the $100 as a milestone to the Upwork job.

@MirFahad58 the old upwork job expired so I re-posted a new one here. Can you apply so I can re-hire you? I added the $100 additional so the new job total is $350.
https://www.upwork.com/jobs/~01225edf8b252ecf69

Ok . Asap i will do

@michaelhaxhiu it isn't expired yet I think still in the active section. meanwhile, I submitted proposal on new one also.

Ah you are correct @MirFahad58, thanks -- I will close the new one sorry for the confusion.

thanks

I have started to review the PR and I will let you know @roryabraham when this is ready for review.

Triggered auto assignment to @jboniface (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Hello @michaelhaxhiu @shawnborton i need the translation for these in es.js
reportActionsView: {
beginingOfChatHistroy: 'This is the beginning of your chat history with',
beginingOfChatHistroyPrivate: 'This is the beginning of the private',
beginingOfChatHistroyPrivateSectionPart: 'room, invite others by @mentioning them.',
},

let me try this

Guys, PR is ready for final review. These changes are were long back. :smile:

we did that change long time ago.

@michaelhaxhiu @parasharrajat @shawnborton @roryabraham no one is reviewing the PR?

Oh I see. I am seeing that the PR has the n6-hold label. Let me double check if this PR review needs to be held longer or not.

not sure where this one is at

I left some review comments about a week ago but the PR hasn't been updated. I know there have been lots of delays on our side, but @MirFahad58 let's get this issue over the finish line!

@roryabraham i will update asap.

@michaelhaxhiu @roryabraham  @shawnborton
I think PR is ready to merge all checks have passed.

and I left some messages on U.W need the response

@MirFahad58 can you make sure to send any messages concerning your progress in GH? We have more visibility here and there are more eyes to weigh in on your inquiries.

@michaelhaxhiu I requested a bonus milestone for n6-hold on U.W and want to submit the work for the current milestone as I have to match my expenses for this month. Thanks

PR merged 🎉

@michaelhaxhiu  as PR is merged now. I need response for above comment. Please reply

@MirFahad58
We'll pay the remaining amount due after 7 days of no regressions.
Let's do a quick buddy check on the outstanding payment that's owed for your work, as I'd like to make sure it's fair!

$500 for completing the job (The job was initially $250, but we increased that to $500 due to increase scope - context)
$250 bonus for the n6 hold (Already paid via Milestone in Upwork)

@michaelhaxhiu let men correct, the 250 that was paid,  was not of n6-hold bonus it was half of $500 from jobs. Thanks
that's why i added a milestone for n6-hold

Ok so it sounds like you are saying:

The $250 that was already paid was for your initial work ✅
The $250 n6 hold bonus hasn't been sent yet, and you are requesting that be sent today
Finally, we owe $250 for the increased scope of work, which will be paid in 6 days.

Is that right?

right

Ok got it. I think that is fine, I'll issue the $250 payment now.
Then, you'll receive the remaining $250 on November 25.

yup thanks

Paid final $250 to @MirFahad58 , thanks for the help and patience.

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.1.16-10 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/4921

If no regressions arise, payment will be issued on 2021-12-06. :confetti_ball:


Cannot scan individual branch

Running "sudo ./GitSPDX.py branch=https://github.com/joverkamp/SPDXHub" works just fine and pushes the SPDX document accordingly to the repository.
Running the program on an individual branch i.e. "https://github.com/joverkamp/SPDXHub/tree/master" results in a repo not found error.
Is this a bug, or a technical constraint?

I ran into the the same issue.

If you have ever used github before you must specify a branch by using the URI. This should always end with .git.


Added BMSCE Bangalore

I have added BMS College of Engineering, Bangalore. The official site of college is http://bmsce.ac.in/

@bhattaraijay05 Pull request merged. Thank you!


Error while running npm start

<EMAIL_ADDRESS>start /Users/xxx/provably-fair-project
node scripts/start.js "dev"

Cannot read property 'entryOption' of undefined
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: node scripts/start.js "dev"
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!      /Users/xxx/.npm/_logs/2019-08-25T13_03_11_833Z-debug.log

Fixed.


unable to use different oob method during provisioning  (IDFGH-3292)

Environment

Development Kit:      [ESP32-Wrover-Kit|ESP32-DevKitv1
Kit version [v1|
Module or chip used:  [ESP32-WROOM-32]
IDF version (run git describe --tags to find it):
idf 4.0
Build System:         [Make|CMake|idf.py]
Compiler version (run xtensa-esp32-elf-gcc --version to find it):
// 1.22.0-80-g6c4433a
Operating System:     [Windows]
(Windows only) environment type: [MSYS2 mingw32|ESP Command Prompt|Plain Command Prompt|PowerShell].
Using an IDE?: [|Yes (please give details)] vs code
Power Supply:         [USB]

Problem Description
//Detailed problem description goes here.
Hello,
I am implementing the OOB authentication, it has been mention in the docs that to disable the no OOB behavior we must set the value of the static OOB to some thing. so to do this  I follow the example given https://github.com/espressif/esp-idf/blob/master/examples/bluetooth/esp_ble_mesh/ble_mesh_node/onoff_server/main/ble_mesh_demo_main.c
and change the structure of the provision as below
const uint8_t static_oob_val[] = {0x01};
esp_ble_mesh_prov_t provision = {
.static_val = static_oob_val,
.static_val_len = sizeof(static_oob_val),
.uuid = dev_uuid,
.oob_info=ESP_BLE_MESH_PROV_OOB_STRING,
.output_size = 4,
.output_actions = ESP_BLE_MESH_DISPLAY_STRING,
};
to my surprise that still the app nrf mesh as well as the esp ble mesh provisioned the device with no oob support. What I am missing here? is there is any example which shows  how to provision the node with the OOB?
Expected Behavior
the expected behavior or the desired result is shown in the video by the nordic semiconductors
https://www.youtube.com/watch?v=XthbU9NP0Yg the provisioning of  the device is done with  blink of the led. there is no option to select oob method during the provisioning in that video.

Thanks for reporting, we will look into.

Hi @ankit-thealchemist
Sorry for the late reply.
In the example onoff_server, you can set the oob method like the following in the structure esp_ble_mesh_prov_t,
const uint8_t static_oob_val[] = {1};
esp_ble_mesh_prov_t provision = {
.uuid = dev_uuid,
.static_val = static_oob_val,
.static_val_len = sizeof(static_oob_val),
.output_size = 4,
.output_actions = ESP_BLE_MESH_DISPLAY_STRING,
.input_size = 4,
.input_actions = ESP_BLE_MESH_PUSH,
};

Then on the nRF Mesh side, you need to choose to use No OOB, Static OOb, Output OOb or Input OOB for authentication.

For Static OOB, you need to input the same value which is used in the example;
For Output OOB, you need to get the number or string from the ESP_BLE_MESH_NODE_PROV_OUTPUT_NUMBER_EVT or ESP_BLE_MESH_NODE_PROV_OUTPUT_STRING_EVT, and input it on the app side;
And for Input OOB, after the ESP_BLE_MESH_NODE_PROV_INPUT_EVT comes, you need to invoke esp_ble_mesh_node_input_number or esp_ble_mesh_node_input_string to input the value which is displayed on the app.

BTW, I use the nRF Mesh App (version 2.4.1) to test these authentication methods.
Thanks.

Hi @ankit-thealchemist
Sorry for the late reply.
In the example onoff_server, you can set the oob method like the following in the structure esp_ble_mesh_prov_t,
const uint8_t static_oob_val[] = {1};
esp_ble_mesh_prov_t provision = {
.uuid = dev_uuid,
.static_val = static_oob_val,
.static_val_len = sizeof(static_oob_val),
.output_size = 4,
.output_actions = ESP_BLE_MESH_DISPLAY_STRING,
.input_size = 4,
.input_actions = ESP_BLE_MESH_PUSH,
};

Then on the nRF Mesh side, you need to choose to use No OOB, Static OOb, Output OOb or Input OOB for authentication.

For Static OOB, you need to input the same value which is used in the example;
For Output OOB, you need to get the number or string from the ESP_BLE_MESH_NODE_PROV_OUTPUT_NUMBER_EVT or ESP_BLE_MESH_NODE_PROV_OUTPUT_STRING_EVT, and input it on the app side;
And for Input OOB, after the ESP_BLE_MESH_NODE_PROV_INPUT_EVT comes, you need to invoke esp_ble_mesh_node_input_number or esp_ble_mesh_node_input_string to input the value which is displayed on the app.

BTW, I use the nRF Mesh App (version 2.4.1) to test these authentication methods.
Thanks.

yes you are right @Campou I have to choose the OOB method during provisioning. That's exactly my question, why? OR My precise question is how to disable the no OOB method of provisioning
in esp ble mesh device?
I perceive that that OOB authentication is for the security reason.
consider a scenario that I make the ble devices and they are waiting to be provisioned. They are guarded with the static OOB method for MITM attack.  Now suppose some one open the nrf ble mesh and provisioned the device with the no oob method. Isn't it a big security flaw. Why would any one uses the other  OOB method when NO oob method is present.

Hi @ankit-thealchemist
I think two solutions can be used.

Using Public Key OOB, so when an attacker uses the nRF Mesh App to provision the device, the public key will be unreachable
Add some specific checks in the stack, for example, when an unprovisioned device supports Static OOB, and if it receives a Provisioning Start PDU with No OOB choosn, the PDU will be ignored by the device.

Thanks.

@Campou will try the above mention method and will let you know.

Hi @ankit-thealchemist
Have provided a menuconfig option to use the second solution for checking if No OOB could be used on the node side, and this change will be synced to Github later.
Thanks.

Hello @Campou,
Thats an excellent news! keenly waiting for the update to be live!
thanks for the support.

Hi @ankit-thealchemist
Have provided a menuconfig option to use the second solution for checking if No OOB could be used on the node side, and this change will be synced to Github later.
Thanks.

do the given functionality in  menuconfig become live on git hub?

Hi @ankit-thealchemist
Currently not, please have a try with this patch 0001-ble_mesh-stack-Not-using-No-OOB-if-others-are-suppor.patch.zip, which contains the changes for this.
Thanks.

Hi @Campou
I confirm that this patch + the BLE_MESH_NOT_USE_NO_OOB parameter selection, produce the expected effect; prevent the provision of a device configured with a static key, when there is "No OOB" selected on the provisioner side.

Would it be possible to integrate the patch into the ESP-IDF repository?

Hi @Campou
I confirm that this patch + the BLE_MESH_NOT_USE_NO_OOB parameter selection, produce the expected effect; prevent the provision of a device configured with a static key, when there is "No OOB" selected on the provisioner side.

Would it be possible to integrate the patch into the ESP-IDF repository?

Hello @ankit-thealchemist
I am facing similar issue right now. I want to disable No OOB because I am using Static OOB. Can you please tell me suggest me solution apart from patch?

Hello @hipal31
We can't do nothing... Patch is the only option for now..


Remove already ignored files.

Cleaned up the .gitignore file and removed the files that should already be ignored.
Having the local.properties file checked in threw an error when opening project on a Windows machine, it should be environment generated (even says so in the comment).
Corrected two spelling errors and added a table to the Readme file.

Looks good to me.


Simple create operation doesn't work with sqlite:  cannot store TEXT value in INTEGER column ads.paid"

I have the following code that breaks with this error:
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Database(SqliteError { code: 3091, message: "cannot store TEXT value in INTEGER column ads.paid" })', packages/backend/src/main.rs:74:36

specifically: cannot store TEXT value in INTEGER column ads.paid"
    let pool = SqlitePool::connect("sqlite:sqlite.db").await.unwrap();
    let mut conn = pool.acquire().await.unwrap();

    sqlx::query!(
        r#"
        CREATE TABLE IF NOT EXISTS ads (
            id INTEGER PRIMARY KEY AUTOINCREMENT,
            company TEXT NOT NULL,
            position TEXT NOT NULL,
            remote TEXT NOT NULL,
            apply_link TEXT NOT NULL,
            description TEXT NOT NULL,
            paid INTEGER NOT NULL
        ) STRICT;
    "#
    )
    .execute(&mut conn)
    .await
    .unwrap();

    let a = Ad {
        id: 12,
        company: "netflix".to_string(),
        apply_link: "lskfjd".to_string(),
        description: "des".to_string(),
        position: "des".to_string(),
        remote: "des".to_string(),
        paid: 1,
    };

    let output = a.create(&pool).await.unwrap();

it seems like numeric types are being stored as strings, which in this case breaks it.

After adding a pool.close() to the end of the code I was able to get it working using the axum-support branch. I've reworked the proc_macro code generation portion, making the futures it returns Send. This allows it to work with Axum, but I also squashed a few bugs in the process. I'll comment here once that code is merged to main. I'll also try and work this up in to a unit test. Thanks for reporting it.


[SR SQL Planner Summer Camp] Support recover partition in new Parser and Analyzer

What type of PR is this：

[ ] bug
[x] feature
[ ] enhancement
[ ] refactor
[ ] others

Which issues of this PR fixes ：

Fixes #7942
Problem Summary(Required) ：

[FE PR Coverage check]
:disappointed: fail : 11 / 14 (78.57%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/sql/ast/AstVisitor.java
0
1
00.00%

:large_blue_circle:
com/starrocks/analysis/RecoverPartitionStmt.java
2
3
66.67%

:large_blue_circle:
com/starrocks/sql/analyzer/RecoverPartitionAnalyzer.java
3
4
75.00%

:large_blue_circle:
com/starrocks/sql/analyzer/Analyzer.java
2
2
100.00%

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
4
4
100.00%

miss privilege check

[FE PR Coverage Check]
:heart_eyes: pass : 19 / 22 (86.36%)
file detail

path
covered line
new line
coverage
not covered line detail

:large_blue_circle:
com/starrocks/sql/ast/AstVisitor.java
0
1
00.00%
[338]

:large_blue_circle:
com/starrocks/analysis/RecoverPartitionStmt.java
2
3
66.67%
[91]

:large_blue_circle:
com/starrocks/sql/analyzer/RecoverPartitionAnalyzer.java
3
4
75.00%
[9]

:large_blue_circle:
com/starrocks/sql/analyzer/Analyzer.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/parser/AstBuilder.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/sql/analyzer/PrivilegeChecker.java
8
8
100.00%
[]


Winget deployment version 1.0.64

1.0.64 version currently on review https://github.com/microsoft/winget-pkgs/pull/133021

Deployed


Don't run pre-push hooks when deleting remote branches

Fixes #204

Thank you for the PR!
I approve this PR and I could merge this PR at this time.
But I'm sorry to say that I might not be able to go through release process since I'm a little bit low on mental/time capacity for a while with personal issues, workload at work, etc.
(Although I can just bump and tag a new version and let CI handle the process, I'm not sure it'll still work after the last release. It might need some works due like following up dependencies updates, etc.)
I'll release a new version as I get better.
Thank you for your understanding.

No problem. This isn't a massive blocker for me (I was just following up on some old PRs) and life comes first of course so no rush.
I took a quick look at updating the dependencies and it seems that the git2 update breaks a few tests. I might dive in at some point and take a stab at fixing it.

Hey there @foriequal0 I hope you're doing well.
In #209 I updated all the dependencies.

It took too long. I'll cleanup some tests and lint.
It'll reslve https://github.com/foriequal0/git-trim/pull/210, https://github.com/foriequal0/git-trim/pull/209, https://github.com/foriequal0/git-trim/pull/213, and some dependabot PRs at once.

It took too long. I'll cleanup some tests and lints. It'll resolve #209, #213, and some dependabot PRs at once.

 Glad to see you're back on to things instead.

Please rebase onto the new master branch, then I'll merge it.


OCPBUGS-23886: CVE-2023-47108: bump go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp to v0.46

Bump go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp to fix CVE-2023-47108. cc @openshift/storage

/jira refresh

/lgtm


Enhancement: Add a rejection sampler

Summary
Currently the batch method fails with a validation error if any of the generated rows fail the schema validators. To allow use of the package in a testing environment, it would be useful to be able to generate a dataframe of any size using a rejection sampler method. This method should store the random seeds of successful builds in order to reproduce the same dataframe each time.
I have created a class that performs these actions included below. Given this is something I have needed for my project, it could be a useful feature for others wanting to use Polyfactory for testing. I built it based off the original pydantic factories package, but I imagine it would be pretty similar for the additional Factory options in Polyfactory.
Basic Example
import time
import json
import pandas as pd
from polyfactory.factories.pydantic_factory import ModelFactory

class RejectionSampler:
    """Function to create a synthetic dataset based off the pydantic schema,
    dropping rows that do not meet the validation set up in the schema.

    Parameters
    ----------

    factory (ModelFactory): pydantic factories ModelFactory created from pydantic schema
    size (int): Length of dataset to create
    """

    def __init__(self, factory: ModelFactory, size: int) -> None:

        self.factory = factory
        self.size = size
        self.used_seeds = []

    def setup_seeds(self):

        start = time.time()

        synthetic_data = pd.DataFrame()

        # start seed at 1, increase seed by 1 each pass/fail of factory.build() to ensure reproducibility
        seed_no = 1

        for _ in range(self.size):
            result = None
            while not result:
                try:
                    self.factory.seed_random(seed_no)
                    result = self.factory.build()
                    result_dict = json.loads(result.json())
                    synthetic_data = synthetic_data.append(
                        pd.DataFrame(result_dict, index=[0])
                    )
                    self.used_seeds += [seed_no]
                    seed_no += 1
                    result = True
                except ValidationError:
                    seed_no += 1

        end = time.time()

        print(f"finished, took {seed_no-1} attempts to generate {self.size} rows")
        print(f"took {end-start} seconds to setup seeds")

    def generate(self):

        start = time.time()

        synthetic_data = pd.DataFrame()

        for seed in self.used_seeds:
            self.factory.seed_random(seed)
            result = self.factory.build()
            result_dict = json.loads(result.json())
            synthetic_data = synthetic_data.append(pd.DataFrame(result_dict, index=[0]))

        end = time.time()

        print(f"took {end-start} seconds to generate new data")

        return synthetic_data

Drawbacks and Impact
No response
Unresolved questions
No response

Hiya, sure - but this requires a dependency on pandas or Polars, no?

True, it could instead just return a list of jsons removing the pandas dependency but keeping the reproducible valid batch component?

Yes, this should not have a dependency on any third party library to do.

How about adding the possibility of installing it as an extension?
I mean something like
pip install polyfactory[pandas] or pip install polyfactory[extras]

@williamjamir why do you want to have pandas for this? Also, I'm not sure about the need for this feature. polyfactory should not be creating instances that fail the validation of any of the libraries it supports. If it does, then that's a bug which should be fixed.


Use specific commit SHAs to refer to builder images

Currently, we set imagePullPolicy: Always to make sure we're always using the latest builder images. This causes an up to 30s delay for each job, because prow has to pull the image first. The better solution is to use unique tags like 2.0-${COMMIT_SHA} so that prow can reuse an image if it has been pulled before.
There's one disadvantage to this solution, and that is the fact that we're now pushing all containers at once if one of them changes. We could implement it the same way as before, but I think it's helpful to have a full set of images per commit SHA - this way, you don't have to remember which commit introduced proxy-builder changes and which introduced maistra-builder changes - if there's one image with that SHA, all the other images are present, too.
Note that I've also removed the 1.2 builder image

I think the gain is minimum, right? I mean, kubelet will not download the image every time, it will check if the image resolves to a SHA not previously downloaded. I'm ok with the changes if they save a few seconds, we should just make sure to not complicate things too much :)

You're probably right on this. I guess I'll do some more benchmarking to see where the bottlenecks actually are in terms of job startup times.

I'm also thinking on unifying the images (not having a separate image for the proxy). I'm playing with it and can submit a pr later on.

Cool, I think that makes sense - if it's easy to do. With envoy being so picky about the build env, I'm not sure it'll work in the long run.


UserInfo endpoint and ACR_Values

HI, I am using OIDC-Client and IDentityServer4, For some custom claims I have overridden ProfileService that added some claim based on the ACR_Values passed by the client in authentication request.
but as ProfileService of Identityserver also called for UserInfo endpoint the ACR_Values are not available there,
How can I get the ACR_Values in profileservice when itis called by USerInfo endpoint

This seems to be a general question about IdentityServer - not a bug report or an issue.
Please use one of the our free or commercial support options
See here for more details.
Thanks!


Install optional dependencies with "extras" requirements

What about using setuptools's extras_require to defines optional dependencies?
You could then have e.g., pip install xraylarch[gui], xraylarch[jupyter],  xraylarch[dev],...
This remains fully compatible with installer scripts, but it would avoid to have copies of the dependencies at different places (the scripts can then call e.g., pip install xraylarch[gui,jupyter].
This is mostly for use with pip.
It would also give a single place where to look for dependencies. Indeed, when updating dependencies in xraylarch conda packaging, it wasn't clear what are the optional dependencies.

@t20100 thanks for proposing this. I am in favor of it. Personally, I would like to get rid of the install_extras command in various places. Installing packages at the runtime is dangerous.

@t20100 @maurov Yes, I am in favor of this. Switching to pyproject/setup.cfg has been on my to-do list for a while, and that would make that easier.  I think the main questions for me are what are "basic" and what are "extras", but I agree with the concept.

For the conda packaging, I considered current requirements.txt as the default dependencies since this is enforced by setup.py as install_required dependencies and the rest as "extras" dependencies.

@t20100 Yes, I agree.  That's not to say we can't change what is listed there ;).

@t20100 @maurov OK, I have made progress on setup.cfg with multiple [options.extras_require] paragraphs, and removing all of the code to add packages needed for specific domains at runtime.
I committed to master, but really as a request-for-comments, that setup.cfg has a [larix] option that will require everything needed for wxPython GUIs and for Jupyter notebooks, including ploty and py3dmol.  This [larix] is different from [all] in not installing [dev] and [doc] requirements.
I have tested proof-of-concept installations scripts that will eventually do
pip install xraylarch[larix]

For completeness, a plain
pip install xraylarch

will install a pretty bare "xraylarch library", but some might want installed on a server.
At the moment, the xraylarch on PyPI does not have a [larix] target.  I would like to tag and push the master branch as 0.9.73 fairly soon (end of the week?) to update these installation scripts.

This looks great, thanks! It makes it really clear.

@newville it is fine from my side too, thanks! I would then remove the redundant requirements.txt and requirements-extra.txt


Update CLIMATE.md

1289 proper description with PR#33

Hello, I updated the docs so the device files tables are not generated directly from the files. So I will close this PR as not required anymore.


deps: updates to TinyGo 0.28.1

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Updates to latest TinyGo which progresses its applicability to things including json and ASN code.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Minimum TinyGo is now latest TinyGo 0.28.1 (technically 0.28.0 is fine)
What are the benchmark results of this change?
goos: darwin
goarch: arm64
pkg: sigs.k8s.io/kube-scheduler-wasm-extension/internal/e2e
                                       │ v0.27.0.txt  │            v0.28.1.txt             │
                                       │    sec/op    │   sec/op     vs base               │
PluginFilter/noop/params:_small-12       199.7n ± 14%   189.6n ± 2%   -5.06% (p=0.002 n=6)
PluginFilter/noop/params:_real-12        191.7n ±  3%   189.2n ± 1%   -1.30% (p=0.002 n=6)
PluginFilter/wasm/params:_small-12       6.869µ ±  2%   6.844µ ± 1%        ~ (p=0.180 n=6)
PluginFilter/wasm/params:_real-12        50.39µ ±  1%   50.57µ ± 1%        ~ (p=0.394 n=6)
PluginScore/noop/params:_small-12        241.8n ±  1%   243.2n ± 1%        ~ (p=0.327 n=6)
PluginScore/noop/params:_real-12         206.4n ±  1%   207.9n ± 0%   +0.73% (p=0.002 n=6)
PluginScore/wasm/params:_small-12        5.158µ ±  0%   3.918µ ± 1%  -24.03% (p=0.002 n=6)
PluginScore/wasm/params:_real-12         49.36µ ±  2%   51.76µ ± 2%   +4.85% (p=0.002 n=6)

Can we somehow tell users about the recommended tinygo version?

yeah. actually we are missing any info at all about building the guest, so when we make that we should also tell them about the tinygo version ;) I've personally delayed this until the functionality is a little farther because compiling guest locks in the ABI, which is moving still.

until the functionality is a little farther because compiling guest locks in the ABI, which is moving still.

Sounds good. 🙆♂


Added the missing space

Added the missing space on step 5 ::  https://docs.microsoft.com/en-us/azure/site-recovery/hyper-v-azure-powershell-resource-manager#step-5-install-the-provider-and-agent

@Daya-Patil : Thanks for your contribution! The author, @sujayt, has been notified to review your proposed change.

@curtand - The changes in your article groups-lifecycle.md are duplicated in https://github.com/MicrosoftDocs/azure-docs/pull/29752. Could you review or provide feedback?
@ggailey777 - The changes in your article azure-developer-guide.md are duplicated in https://github.com/MicrosoftDocs/azure-docs/pull/29752. Could you review or provide feedback?
The updates in hyper-v-azure-powershell-resource-manager.md look fine but I don't want to merge the typo fix because the other two files are duplicates of an open public repo PR.
Thanks.

Dirty PR, created new one https://github.com/MicrosoftDocs/azure-docs/pull/29998


react-native init AwesomeProject SyntaxError :

react-native init AwesomeProject no longer works for me. It did just a few hours ago. I am working on a macbook pro and I have tried:

Restarting
Removing and Reinstalling react-native-cli
Installing Yarn
Different node js versions with nvm

I always get the exact same error:
Last login: Thu Dec  8 17:07:25 on ttys000
<IP_ADDRESS>
javac 1.8.0_111
node version v6.9.2
npm version 3.10.9

~ => cd documents
documents => react-native init AwesomeProject
This will walk you through creating a new React Native project in /Users/alexbanks/Documents/AwesomeProject
Using yarn v0.17.10
Installing react-native...
/Users/alexbanks/Documents/AwesomeProject/node_modules/react-native/local-cli/util/Config.js:43
  cwd: string,
     ^
SyntaxError: Unexpected token :
    at Object.exports.runInThisContext (vm.js:76:16)
    at Module._compile (module.js:542:28)
    at loader (/Users/alexbanks/Documents/AwesomeProject/node_modules/babel-register/lib/node.js:144:5)
    at Object.require.extensions.(anonymous function) [as .js] (/Users/alexbanks/Documents/AwesomeProject/node_modules/babel-register/lib/node.js:154:7)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/Users/alexbanks/Documents/AwesomeProject/node_modules/react-native/local-cli/cliEntry.js:13:16)

👍   Running into the same error.  Glad I'm not the only one.

face the same error with react native 0.39.1. seems caused by the syntax of
const Config = {
get(
cwd: string,
defaultConfig?: ConfigT | null,
pathToConfig?: string | null,
): ConfigT {
let baseConfig;
// Handle the legacy code path where pathToConfig is unspecified
...........
inside config.js.
looks like typescript...

Yep, I'm getting this as well, for basically any run of the react-native cli for a pre-existing project. Started with 0.39.

What was the last working version?

I am also experiencing this issue after trying to upgrade a 0.35.0 project.
0.38.0 appears to be the last working version. 0.39.0 and 0.39.1 both fail whenever trying to run any react-native CLI scripts.
Tried switching between multiple different versions of react-native-cli to no avail.

Hi, I got the same error, but before it was ok.
Here is my trace error:
➜  Pro react-native init RNGank
This will walk you through creating a new React Native project in /Users/noprom/Documents/Dev/ReactNative/Pro/RNGank
Installing react-native from npm...
Consider installing yarn to make this faster: https://yarnpkg.com

/Users/noprom/Documents/Dev/ReactNative/Pro/RNGank/node_modules/react-native/local-cli/util/Config.js:43
  cwd: string,
     ^
SyntaxError: Unexpected token :
    at Object.exports.runInThisContext (vm.js:78:16)
    at Module._compile (module.js:543:28)
    at loader (/Users/noprom/Documents/Dev/ReactNative/Pro/RNGank/node_modules/babel-register/lib/node.js:144:5)
    at Object.require.extensions.(anonymous function) [as .js] (/Users/noprom/Documents/Dev/ReactNative/Pro/RNGank/node_modules/babel-register/lib/node.js:154:7)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.require (module.js:498:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/Users/noprom/Documents/Dev/ReactNative/Pro/RNGank/node_modules/react-native/local-cli/cliEntry.js:13:16)

My react-native version:
➜  Pro react-native -v
react-native-cli: 1.2.0
react-native: n/a - not inside a React Native project directory

My npm version:
➜  Pro npm version
{ npm: '3.10.9',
  ares: '1.10.1-DEV',
  cldr: '30.0.2',
  http_parser: '2.7.0',
  icu: '58.1',
  modules: '51',
  node: '7.2.1',
  openssl: '1.0.2j',
  tz: '2016g',
  unicode: '9.0',
  uv: '1.10.1',
  v8: '5.4.500.44',
  zlib: '1.2.8' }

same issue happended herer, i try proxy changes ,reinstall yarn , reinstall node.js, and nothing helps, seems like babel did`t transformed successful.

+1
I received the same error as well.

react-native init HelloWorld > Error
react-native init HelloWorld2 > No Error
:(

I was getting the same error.  I hit Cmd-D and clicked Debug JS Remotely.  The app refreshed and the syntax error was gone.
If I turn off remote debugging, the error returns.

FYI - Until this gets resolved, you can use rninit (https://www.npmjs.com/package/rninit) to install using the previous version of react-native. This worked for me:
rninit init mobile --source<EMAIL_ADDRESS>

me too.
react-native 0.39.1 occured but solved

package.json
"react": "15.3.2",
"react-addons-shallow-compare": "15.3.2",
"react-native": "0.38.0",
...
npm update
react-native -v
react-native-cli: 1.3.0
react-native: 0.38.0
react-native run-ios

** BUILD SUCCEEDED **
...

+1，me too
react-native: 0.39.0 and 0.39.1 error
react-native: 0.38.0 is work

I have the same issue with react-native:  0.39.1

fallback to 0.38 to resolve this.
react-native init MyProject --version 0.38.0
ping @grabbou

On the same boat as @namKolo
react-native-cli: 1.3.0 react-native: 0.39.1

@riyanpratama  You can roll back to version 0.38.0 as @sunnylqm  said. It works for me

@namKolo sadly, still had the same problem here.

@riyanpratama  sorry it should be 0.38.1.

@namKolo created with react-native init fukBS --version 0.38.1 and still got the same error.

@riyanpratama  Please run npm uninstall react-native then npm i<EMAIL_ADDRESS>I hope it will help you. But it is just a trick. Hope the bug wil be fixed soon !

@namKolo The trick worked for me 👍

I just tried react-native init AwesomeProject again, without the trick... and it worked. I was able to create and run the project on both ios and android.

react-native init RNGank --version 0.38.0

This works for me.

in file "node_modules/react-native/Libraries/Core/InitializeCore.js"
delete 'use strict';
and it works

Interestingly, I get this error on an iPhone 4s simulator running 8.1 (and as @gwmccull mentioned it goes away on remote debugging), but not on an iPhone 6 simulator running 10

@facebook-github-bot duplicate #11389


Manual deserialization of nested enum

I have this slightly complex case that I need some help with. I have an AST which I need to deserialize from a slightly different JSON.
I created a minimized testcase for it:
The AST:
#[derive(Deserialize, Debug)]
struct Resource<'ast> {
    #[serde(borrow)]
    body: Vec<Entry<'ast>>
}

#[derive(Deserialize, Debug)]
enum Entry<'ast> {
    #[serde(borrow)]
    Message(Message<'ast>),
    Term(Term<'ast>),
    Comment(Comment<'ast>)
}

#[derive(Deserialize, Debug)]
struct Message<'ast> {
    #[serde(borrow)]
    comment: Comment<'ast>
}

#[derive(Deserialize, Debug)]
struct Term<'ast> {
    #[serde(borrow)]
    comment: Comment<'ast>
}

#[derive(Deserialize, Debug)]
enum Comment<'ast> {
    ResourceComment { content: &'ast str },
    GroupComment { content: &'ast str },
}

The result JSON may look like this:
{
        "body": [
          {
            "type": "ResourceComment",
            "content": "Foo"
          },
          {
            "type": "Message",
            "comment": {
              "type": "GroupComment",
              "content": "Faa"
            }
          },
         {
            "type": "Term",
            "comment": {
              "type": "ResourceComment",
              "content": "Faa"
            }
          }
        ]
}

The trick here is that the Resource::body elements encode their type using the type field. For Term and Message this would work, but for Comments they actually communicate the type of the comment inside the Comment enum.
What I believe I need here is a deserializer that will look at the Resource::body element type field, and if it's Message or Term it just sends it to the derived deserializer for that struct.
If it's ResourceComment or GroupComment it will send it to the derived deserialized for Comment enum.
How would it work?

Here's a playground example which tries to use untagged/tagged and produces wrong output (Message for Term) - https://play.rust-lang.org/?gist=eefa510d5c805e8fb9e6281d282942a4


Update VM

What current issue(s) does this address, or what feature is it adding?

update to match https://github.com/neo-project/neo-vm/pull/95 and https://github.com/neo-project/neo-vm/pull/126
resolve memory leak when executing invocation transactions

How did you solve this problem?
How did you make sure your solution works?

for the VM update I ran the newer JSON test files + make test
for the VM memory leak I ran this test before and after fixing and confirmed the memory usage stays low

import unittest
import binascii
from neo.VM.ExecutionEngine import ExecutionEngine
from neo.VM import InteropService
from neo.Core.Cryptography.Crypto import Crypto
from pympler.tracker import SummaryTracker

class VMLeak(unittest.TestCase):
    def test_vm_context_leak(self):
        service = InteropService.InteropService()
        script_container = None
        script_table = None
        tracker = SummaryTracker()
        for _ in range(10000):
            engine = ExecutionEngine(crypto=Crypto.Default(), service=service, container=script_container, table=script_table, exit_on_error=True)
            script_data = binascii.unhexlify('00C57655C86B00C5766AC86A56C86C')
            engine.LoadScript(script_data)
            engine.Execute()
        tracker.print_diff()

Are there any special changes in the code that we should be aware of?
Please check the following, if applicable:

[ ] Did you add any tests?
[X] Did you run make lint?
[X] Did you run make test?
[X] Are you making a PR to a feature branch or development rather than master?
[ ] Did you add an entry to CHANGELOG.rst? (if not, please do)

Coverage increased (+0.004%) to 86.908% when pulling eedb5752c3f6cd82363de8f653fc82af5120f8d0 on ixje:vm-update into 56a424093e5baa6567bf66f93aa0c4c7c75df055 on CityOfZion:development.


Remove dead code (Company Investment)

I can't find evidence that this code is being used so I'm removing the dead weight.

This may well be needed as a reference when adding the investment pipeline.

This may well be needed as a reference when adding the investment pipeline.

Could we find it in history instead?


New version: blacktop.ipsw 3.1.370

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Automated with GoReleaser
Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/112799&drop=dogfoodAlpha

@microsoft-github-policy-service agree

I don't see anywhere where the reason for the validation failure is explained?

Looking for some errors I see:
****************************************************************************************
Rebuilding Cache
****************************************************************************************
Status: Completed
##[error] Result: Failed
##[error] One or more errors occurred. (Exception of type 'System.OutOfMemoryException' was thrown.) Exception of type 'System.OutOfMemoryException' was thrown.

So it looks like for some reason your CI is exhausting it's memory?  The only thing I can think on my end is I'm using the goreleaser tool created by @caarlos0 and maybe it's creating 2 PRs sharing some UUID or something?

Manual Validation failed with:

5:22:38 PM:  > 2023-07-24 17:22:37.778 [FAIL] Installer failed security check. Url: https://github.com/blacktop/ipsw/releases/download/v3.1.370/ipsw_3.1.370_windows_i386.zip Result: 0x80004005

We can retry the scan tomorrow.

@wingetbot run

/azp run


Release the memory in arvcameratest.c

Hi,
I have a question about the release of the memory in arvcameratest.c of ARAVIS 0_3_3. I modified the program to handle several cameras with one program alternately. This program makes a loop that one camera takes a snapshot with a software trigger and the analysis of the image is done and then it goes to the next camera and do the same procedure. As a start point, I ran the program with only a single camera. Then I found the short of memory after some loops. I inserted system("free") to check how the amount of free memory is decreasing. I found that setting the callback function written in every loop might be suspicious.
l.261 g_signal_connect (stream, "new-buffer", G_CALLBACK (new_buffer_cb), &data);
I guess that unset of the callback function or releasing the memory of "data" is necessary to avoid the problem. If you know anything, could you teach me how to do that?

Hello
Sorry for the delay of my answer
I searched a little bit in the internet and found this sample:
http://code.metager.de/source/xref/gnome/DevelopmentTools/aravis/tests/arvexample.c
It looks like your sample. I guess, you used it too.
Some annotations:
As far as I know, it is totally wrong to do
g_signal_connect (stream, "new-buffer", G_CALLBACK (new_buffer_cb), &data)
more than once.
Move it out of the look you use in you main() function at 	while(cap_check<10){...}
The trick is setting up the Aravis library and callbacks and camera. Then you run the software trigger in the loop. If the loop has ended you clean up the Aravis and other things.

Closed since there are no more answers.


feature: add the possibility to display a tree that represents the multiplet

See: http://www.cheminfo.org/Spectra/NMR/Tools/Multiplet_simulator/index.html

Very nice indeed!
If the "copy url" could allow to return to the same multiplet (so the one could show someoneelse a multiplet) it would be even better... You don't have to save the cession, but have the J,m as arguments when  the page is called!
Anyways, nice....

A fabulous feature would be to be able to drop a spectrum on top of the simulation (so that we could do manual adjustments.... have little buttons to increase, decrease J's.... or with the mouse....


Replace rebus with foundatio

I opened this on behalf of kog.

I thought we might be able to get away with @AndyCJ doing a review while I was at work since they're my commits, but I guess GH is smarter than that. I'll close this and resubmit.


Change defaultSubDomain installation failed (Azure Stack)

Before deploying OpenShift 3.9 on Azure Stack i changed the following parameters and the deployment failed. The customer want's to use their own domain for the OpenShift deployment.
defaultSubDomainType  nipio to custom
defaultSubDomain changeme to apps.tmw-d.domain.nl
domain.nl is the domain of the customer is it possible to do it this way or am i missing something.
Kind Regards,
Arie

Arie,
Are they doing a private cluster in that they are not exposing anything to the Internet?


Blazor server template error when scaffolded identity pages are added

The blazor server template does not play nicely with the scaffolded identity templates when the individual user accounts selection is made.
Version: 3.0.0-rc1.19457.4
Repro steps:

Select File > New > Project and select the serverside Blazor app using Visual Studio 2019 preview and the 3.0.0-rc1.19457.4 version of .net core.
During the blazor server template create, select the change link below Authentication and select the individual user accounts option.
Once the template is created add a scaffolded identity page to the project.  Right-click on the solution and select add > new scaffolded item.  Select Identity and click 'Add'.  At this point, you should presented with a list of possible custom identity views to generate.  Select Login and Register scaffolded views and select the application db context in the drop-down and click 'Add'.
When the view is generated you will get the compile error below:

Error | CS0246 | The type or namespace name 'IWebHostEnvironment' could not be found (are you missing a using directive or an assembly reference?)

To fix the compile error look at the top of the /Pages/Shared/_Layout.cshtml file in the project.  You will see new using declarations were added to the top of the file but the very top line is missing the @using directive (see code below).  Adding @using will fix the compile error but the template will look wonky with two top navs both containing a log in a register link.  I think what is happening is that the add new scaffolding should not be touching the shared layout used by the Blazor view.  I suspect a new shared layout should be scaffolded in under the Areas/Identity/Pages/Shared path.

[note the missing @using in the _Layout.cshtml page below]
Microsoft.AspNetCore.Hosting
@using Microsoft.AspNetCore.Mvc.ViewEngines
@inject IWebHostEnvironment Environment
@inject ICompositeViewEngine Engine

Duplicate of #13699

This is still an open issue; The fix (aspnet/Scaffolding#1066) mentioned in #13699 does not resolve this.  It has to do with the layout page referenced by the scaffolded identity views.  The identity scaffolding mechanism incorrectly adjusts the _layout.cshtml page used by the Blazor views.  When this happens, we see two navbars present in the browser (one from the injected identity view and the one from the Blazor template view).

Thanks for contacting us, @joseph-adam.
This is indeed a duplicate issue and will be fixed for the upcoming 3.1 release.


stop container on ctrl-c during cog predict

When running cog predict if the user hits "ctrl-c" the docker container is left running
This catches the ctrl-c and terminates docker container
Signed-off-by: Jesse Andrews<EMAIL_ADDRESS>

Before - starting whisper - then hitting ctrl-c leaves a dangling docker container (consuming GPU/CPU):
$ cog predict        r8.im/cjwbw/whisper@sha256:770db50964b436879e870139c9c1504d6326774d8acc92e6815c19b68367ec51 -i<EMAIL_ADDRESS>
Starting Docker image r8.im/cjwbw/whisper@sha256:770db50964b436879e870139c9c1504d6326774d8acc92e6815c19b68367ec51 and running setup()...
^C

$ docker ps
CONTAINER ID   IMAGE                 COMMAND                  CREATED         STATUS         PORTS                                       NAMES
f8e53da30689   r8.im/cjwbw/whisper   "python -m cog.serve…"   9 seconds ago   Up 8 seconds   <IP_ADDRESS>:5081->5000/tcp, :::5081->5000/tcp   angry_shamir

after: hitting ctrl-c during startup (note: whisper takes a while to startup due to loading the weights):
$ cog predict        r8.im/cjwbw/whisper@sha256:770db50964b436879e870139c9c1504d6326774d8acc92e6815c19b68367ec51 -i<EMAIL_ADDRESS>
Starting Docker image r8.im/cjwbw/whisper@sha256:770db50964b436879e870139c9c1504d6326774d8acc92e6815c19b68367ec51 and running setup()...
^C
Stopping container...
ⅹ Failed to get container status: exit status 1
$ docker ps
CONTAINER ID   IMAGE     COMMAND   CREATED   STATUS    PORTS     NAMES
$

after: hitting ctrl-c during predict run (whisper transcription on a large mp3)
$ cog predict        r8.im/cjwbw/whisper@sha256:770db50964b436879e870139c9c1504d6326774d8acc92e6815c19b68367ec51 -i<EMAIL_ADDRESS>
Starting Docker image r8.im/cjwbw/whisper@sha256:770db50964b436879e870139c9c1504d6326774d8acc92e6815c19b68367ec51 and running setup()...
Running prediction...
Transcribe with base model
^C
Stopping container...
ⅹ Failed to POST HTTP request to http://localhost:5081/predictions: Post "http://localhost:5081/predictions": EOF
$ docker ps
CONTAINER ID   IMAGE     COMMAND   CREATED   STATUS    PORTS     NAMES
$

✨

@allcontributors please add @anotherjesse for code


scripts: helpers.sh: use primary clipboard on wayland with mouse

Follow the same logic as in X and use the primary clipboard for Wayland sessions when mouse support is on.
Note a new parameter (@yank_wayland_mouse), which is off by default, was introduced so that the old behavior is maintained. That means that users need to set the following in their tmux.conf:
set -g @yank_wayland_mouse 'true'
to enable the above behavior.

@bruno-  @ctjhoa @jbnicolai can anyone give some feedback or is this not maintained anymore?

Hey! Thanks for the PR!
Why have a yank_wayland_mouse option in addition to yank_selection_mouse? I guess your reasoning is to keep backwards compatibility? I think it'd ok not to have it. Only people that have yank_selection_mouse set AND don't use it AND are on wayland would encounter different behaviour, if I understood correctly.

guess your reasoning is to keep backwards compatibility?

Exactly...

Only people that have yank_selection_mouse set AND don't use it AND are on wayland would encounter different behaviour, if I understood correctly.

Not sure about that. I think anyone using wayland with mouse will see different behavior. With this change wl-copy --primary will be used by default (assuming no option is given). And that is different from using wl-copy.


Cannot view currently running queries in top tabs

Issue Type: Feature Request
Would be nice to easily view which tabs have queries that are executing. Most of the time if there's a long running query, I'll work on something else on another tab, and have no idea when the other query finishes or errors out. If there's multiple tabs open, it's hard sometimes to even find which tab has the long running query.
Azure Data Studio version: azuredatastudio 1.36.2 (2299a76973585fa962cfd06e8acab4abb41567de, 2022-05-19T04:18:20.649Z)
OS version: Windows_NT x64 10.0.14393
Restricted Mode: No

dupe of #9334


Touch issues with xcode6

iOS 7 (frank-cucumber 1.2.3)
pry(#Frank::Console)> touch("view marked:'Some text'")
=> [true]
Element with selector successfully touched.
iOS 8 (frank-cucumber 1.2.3)
pry(#Frank::Console)> touch("view marked:'Some text'")
=> [true]
Element with selector not touched but something else is touched.

Hi all,
Just encountered this issue - have to test one case in landscape on the 6+ (8.1). Trying the pre-release version. Tailing the app log shows that the point calculations seem to be correct:
Jan  8 10:38:22 JCs-*****.local *****[33724]: Using Shelley 1.2.3 to select views with selector: view:'UIImageView' marked:'Adjustments' in windows: (
	    "<UIWindow: 0x79ebc210; frame = (0 0; 736 414); opaque = NO; autoresize = RM+BM; gestureRecognizers = <NSArray: 0x79ebc9b0>; layer = <UIWindowLayer: 0x79ebc180>>",
	    "<UITextEffectsWindow: 0x79e58ab0; frame = (0 0; 736 414); opaque = NO; gestureRecognizers = <NSArray: 0x79e584a0>; layer = <UIWindowLayer: 0x79e588f0>>",
	    "<UIStatusBarWindow: 0x79e9a2b0; frame = (0 0; 736 414); opaque = NO; gestureRecognizers = <NSArray: 0x79e7d590>; layer = <UIWindowLayer: 0x79e9a700>>"
	)
Jan  8 10:38:22 JCs-*****.local *****[33724]: tapping at (412.00,22.00)

Measuring the point <412, 22> on the simulator is the correct point, however the actual tap appears to touch a view in the very top left corner, so seems this might be where it's still going wrong, unless there's something else at my end that I'm missing
Please let me know if I can do anything to help!

@itsthejb, one thing you could do which would really help is to provide a sample app plus test which reproduces the bug. That will make it a lot easier for someone to fix. You could either make a really simple app from scratch, share your actually app (or a stripped down portion of it), or modify one of the example apps in this repo.

@moredip Ok, here's a test project that recreates the issue: https://github.com/itsthejb/FrankRotateIssue
There is a feature to test this at https://github.com/itsthejb/FrankRotateIssue/blob/master/Frank/features/touch.feature. Basically there are three UIImageView instances posing as buttons with attached gesture recognisers. Not sure if this bastardisation contributes to the issue or not, but am mimicking the full project as closely as possibly. The test checks the update of the test label. The test label text should match the accessibility id of the touched button (set the view controller code), but it does not. Most interestingly, touching button 3 actually triggers the Back button, which is on the top-left of the view and not tested directly.
Hopefully this can help to find a solution :+1:


update multi select to accept onChange handler

Currently most of our components have an onChange prop that can be passed but the multiselect component does not.  We would like to have an onChange handler so we can conditionally show/hide other fields in the form based on what options are selected in the multi-select component.

I can start looking at this.

I can start looking at this.

:tada: This issue has been resolved in version 2.6.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 2.6.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[bug] switch: docs pages show both on and off message

There is an issue where both the on and off messages are shown when the id of pfe-switch is equal to disabled. Visit https://patternflyelements.org/components/switch/#disabled to see the issue.

After a review of the page, there is an h3 that receives an id of disabled. The example code also has an id of disabled which causes the conflict.

is that id conflict (on the page) the root cause?


Inject Caching-Mechanism

Inject Caching-Mechanism via the PSR-6 Caching Interface: https://www.php-fig.org/psr/psr-6/

Important: Consider different sessions (#2) when caching.


Position cursor in a field by mouse-click

This should work both when the field has focus and when it doesn't i.e. to give it focus and with the cursor positioned within text where the click was.

Duplicate of #150


CASMTRIAGE-6991 & CASMPET-7058

Backport of https://github.com/Cray-HPE/csm/pull/3407

Duplicate of #3404


⚠ ClamAV has degraded performance

In 396f4bd, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 197 ms

Resolved: ClamAV performance has improved in c4d5e87.


fix: buggy state fetch

Fixes,
src/controller_binaries.rs:222 2023-11-02T23:30:40 [INFO] - Stopping all services
thread panicked while processing panic. aborting.

just tested, seems to be working fine now 🚀


Center all strings in SemanticDebugger

Fixes https://github.com/flutter/flutter/issues/4647

LGTM, bonus points if you can test it!

I wish there was an easy way to test this. As it stands, I cannot think of one, though :(


Improve Util.Pp pretty-printers

This PR brings a few features:

usage of Format boxes to provide the same formatting as deriving show and abide by Format’s rule that all content should be output into some box,
the possibility to require the output to be truncated,
a couple of pretty-printers that were missing,
a couple of typo fixes.

The possibility to truncate would address #308 if all pretty-printers in STM and Lin were always using Util.Pp (this is #343).

LGTM, thanks!
I think an environment variable is the right solution, to allow for both a "shortened print" and a "full one" without having to recompile.
Should we do something similar for bytes?
Would it make sense to add unit/expect tests to ensure that it works as intended and protect ourselves against future breakage? :thinking:
Finally (for another PR) I agree that we should seriously consider switching Lin+STM to use these for consistent
argument and result printing.

I’ve added an internal test for the pretty-printers, with variants for the truncation.

Should we do something similar for bytes?
I don’t see what you have in mind, Util.Pp contains a pp_bytes pretty-printer.

I don’t see what you have in mind, Util.Pp contains a pp_bytes pretty-printer.

My bad, I was too fast reading the cut off code as only applying to strings and not bytes :facepalm:
Since this is located in to_show I assume the cut off applies to all to-string-coercions (string, bytes, list, ...) passing through that function, right?

The added tests look great BTW, and the expect outputs nicely answer the above question :sweat_smile:
I guess having it print the final closing quote or square bracket like the OCaml toplevel will require some form of type-directed approach?
utop # String.make 375 'a';;
- : string =
"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"... (* string length 375; truncated *)
utop # List.init 375 (fun _ -> [0]);;
- : int list list =
[[0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0];
 [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0];
 [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0];
 [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0];
 [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0];
 [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0];
 [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0];
 [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0];
 [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0];
 [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0];
 [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [0]; [...]; ...]

This is just a thought - not meant as critique. I'm quite happy with this as a first version!

The added tests look great BTW, and the expect outputs nicely answer the above question 😅

:sweat_smile:

I guess having it print the final closing quote or square bracket like the OCaml toplevel will require some form of type-directed approach?

I think so. At the level where the truncating mechanism is located in that PR, it sees only the stream of bytes to output, without structure. I wondered whether the boxing or tagging mechanisms in formatters could be retargeted for that kind of purposes, but I didn’t find how.

Reviewing the CI logs I realise (finally!) that (obviously, as it is one of the main goal of Format) the result produced by to_show can be a multiline string while print_triple_vertical assumes it is not the case (see this example for instance).
(It must have been the case already with the pretty-printers generated by ppx_deriving.show since we have something really similar, hidden by the fact that long lines are not readable anyway)
A simple way to fix pretty-printing with print_triple_vertical is to set the formatter margin to max_int.
But now I wonder: do we want to_show functions to always generate one-liners? Or should we add the margin as an (optional?) argument to override the default 78? :thinking:

First of all, let me state that print_triple_vertical is an ugly piece of code that I'm not proud of! :sweat_smile:
(I don't know whether it can be written more cleanly with Formatters).
I agree that it assumes 1-line cmd strings when stitching them together.
Code aside, too long outputs (strings, bytes, lists, ...) mangle the upside down Y-shape printed, which motivated the request for abbreviating print functions in #308
In CI logs, I'd rather skim over, e.g., an abbreviated string in an comprehendable Y-shape rather than see a long string in full detail. That suggests we should set the environment variable in the CI workflows.
I suspect other end-users would prefer such a default setup too :thinking:
It would however be nice to be able to print the full string some way (locally and in the CI), say to create a standalone reproducer. That should however be possible by resetting the MCTUTILS_TRUNCATE environment variable.
To keep things nice and without wrapped lines in the former scenario, setting the formatter margin to max_int sounds reasonable.
There may be cases I'm overlooking, say record types with lists in them that could warrant multi-line formatted strings. So far, such types haven't occurred in the interfaces we have tested :shrug:

CI summary for the latest run 64c1902

Cygwin trunk part 2 failed to trigger STM Sys test parallel
before also timing out during a 253.7s Lin CList int64 test with Thread
after a 2403.4s STM Sys test parallel, 1071.1s STM Weak test parallel, 3267.4s STM Weak HashSet test parallel, 5028.3s Lin ref int64 test with Thread and 1424.6s Lin CList int test with Thread #384
Linux ppc64le failed with an STM Bytes test sequential segfault and an STM Float Array test sequential model difference #380

Neither of these are related to the PR, so I'll go ahead and merge

Actually, it would be nice with a CHANGES entry to document changes in the user-facing Util.Pp module.
Could I convince you to add one @shym?

Indeed!
Should I add also a default setting to MCTUTILS_TRUNCATE to 50 I’ve tested locally? As Util.Pp are used only for STM commands, it won’t bring the hoped truncation for the worse offenders (Dynlink, say) just yet, though.

Should I add also a default setting to MCTUTILS_TRUNCATE to 50 I’ve tested locally?

Yep, please do! :pray:

CI summary for 13d87f8

Win bytecode trunk/5.2 timeout during threadomain #203
Cygwin trunk/5.2 timeout during 1343.7s Lin CList int test with Thread after 2276.9s STM Sys test parallel, 10291.7s Lin ref int64 test with Thread #384
Linux ppc64le trunk/5.2 failure with a STM Array test sequential ABRT and a STM Float Array test sequential SEGV #380

None of these are related to the PR, so I'll merge (and I mean it this time!)


eliminate dependency on PROJECT_HOME env var

no environment variables should need to be set to download and build any bb4 projects.

This var is no longer needed. I cannot find any references to it.


Gemini engineering windoors given correct access

About the PR

Replaced two windoors with an atmos lock at the engineering frontdesk with ones that have an engineering lock. On master the inner two are engineering and the outer two atmos.
Why / Balance

Engineers should be able to open their own front desk windoors.
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

2 engineering frontdesk windoors changed from atmos locked to engineering locked.

superceded map was derotated


Add a tooltip when there's no rate available

Overview
When there’s no rate available on a trade pair, add a tooltip on “no rate available”.
The tooltip will copy is: "This is often due to very limited or no liquidity on the trade pair."
References and additional details
You can see this error when picking some really unknown erc-20 and trying to trade to a more popular asset.
Acceptance Criteria
User sees a tooltip option whenever they see the "no rate available" trade error.
Need By Date
No response
Screenshots/Mockups
No response
Estimated effort
No response

Closed by https://github.com/shapeshift/web/pull/2789/commits/359a459e80927dfbbaf4e46ae0d73cb1d43e0434


Deno support

Motivation
deno v1 just released. It looks like it will gain a lot of traction and possible overtake Node at some point. It would be a good idea to provide support from the start to attract more projects and be ahead of the curve.
Proposed solution
Add a mod.ts file (similar to deno's fs module) that allows users to import JS SDK modules. It should be fairly easy to implement as the changes should mostly related to the imports on ts modules.
Although, perhaps the reliance on rxjs will be a stopper, since that isn't deno-ready.

@kentico-ericd could you possibly try testing the latest version of SDK with deno? We are no longer using rxjs and use only couple of deps.


Navbar is missing is Login Page.

Is there an existing issue for this?

[X] I have searched the existing issues

Issue Description
Navbar is missing is Login Page.
Suggested Change
Add navbar in login page.
Rationale
No response
Urgency
Medium
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24EXTD contributor
[X] I have starred the repository

@Ibrangrd not required


Support list of official managed OS channels for user selection

Support list of official managed OS channels for user selection. For elemental-operator 1.6 and onwards.
Docs: https://elemental.docs.rancher.com/next/channels/#available-channels
Backend PR: https://github.com/rancher/elemental-operator/pull/797 -> info will come from the Metadata resource
Possible UX solution is to have another page, after hitting CREATE on list view, which would show the official channels + option to add a custom one.
If you clicked one one of the official ones, it would show the current create/edit interface with all the information pre-populated.
If clicked on custom, then it's the current create/edit interface without anything filled.

@aalves08 The new backend PR is a new one: https://github.com/rancher/elemental-operator/pull/800

@aalves08 We are targeting elemental-operator 1.7.x for the channel enabled flag.
This won't make it on 1.6.x


Adjustment of section name of articles

When an article is promoted in the latest section and it has no image on, then the section name hovers incorrectly over the banner / content on the top of the site
Before:

After:

🍰 🍰 Looks good


💡[Feature]: Add language model in LLM Copilot Ext for VS Code IDE

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
The proposed feature integrates an advanced language model into the LLM Copilot extension for VS Code, providing contextual code suggestions, automated documentation, and real-time error detection. This integration enhances coding efficiency, improves code quality, and adapts to individual user preferences over time.

Use Case
This feature would significantly enhance my use of the project by streamlining the coding process with intelligent, context-aware suggestions that save time and reduce errors. Automated documentation and real-time feedback would improve code quality and maintainability, while personalized recommendations would align with my coding style, making the development experience more efficient and enjoyable.
Benefits
-Increased coding efficiency and reduced time spent on searching for solutions or documentation.
-Improved code quality through real-time feedback and adherence to best practices.
-Enhanced learning experience for novice developers through guided suggestions and automated documentation.
Add ScreenShots

Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@sanjay-kv plz review and in assign it to me.


parse slots and slot connections from manifest

Or that can only be implied by having a particle consume it and no other particle in the recipe providing it? (which might lead to the strategizer finding other ways to create that slot that might not be intended? probably fine in most cases)

I hadn't considered consumes at the recipe level, but I don't think we need it. What you describe here seems reasonable to me.

I made the changes we discussed, PTAL
Thanks!


EXC_BAD_ACCESS error on IOS

I'm using custom SSD model (I tried my own and three other models that were trained by users)
They work fine in Android, but in IOS it fails here:
if (interpreter->AllocateTensors() != kTfLiteOk) {
    callback(@[@"Failed to allocate tensors!"]);
  }

With EXC_BAD_ACCESS
When I use ssd_mobilenet.tflite from model Zoo IOS does not throw error

Same issue here.

Any solution over here? I'm facing the same issue :)

Hey guys, are you using the customized tflite model? I think when generating tflite files, the version of tensorflow-lite should be specified. This repo only accepts tensorflow-lite r1.12, which means the tflite file generated by other versions might not match the interpreter. In this case, you may need to replace these files:
ios/Pods/TensorflowLite/Frameworks/tensorflow_lite.framework/Headers/Tensorflow to a suitable version (e.g. tensorflow r2.8)
ios/Pods/TensorflowLite/Frameworks/tensorflow_lite.framework/Headers/flatbuffers to a suitable version (e.g. flatbuffer 1.12, which will match tf r2.8)


Add a way to specify grid starting point in TextureAtlas

Currently, if one were to use the from_grid and from_grid_with_padding methods to create a TextureAtlas from a texture, the grid will always have the image origin (top left, 0,0) as its origin point. This change allows specifying a different offset, to be used with spritesheets with a margin, or images packing several spritesheets with different tile sizes.

That would be cleaner, I just didn't want to risk making a breaking change for a first PR but there it is

@oledfish could you add this or something similar to the PR description?
## Migration Guide

`TextureAtlas::from_grid_with_padding` was merged into `from_grid` which takes two additional parameters for padding and an offset.

// 0.8
TextureAtlas::from_grid(texture_handle, Vec2::new(24.0, 24.0), 7, 1);
// 0.9
TextureAtlas::from_grid(texture_handle, Vec2::new(24.0, 24.0), 7, 1, None, None)

// 0.8
TextureAtlas::from_grid_with_padding(texture_handle, Vec2::new(24.0, 24.0), 7, 1, Vec2::new(4.0, 4.0));
// 0.9
TextureAtlas::from_grid_with_padding(texture_handle, Vec2::new(24.0, 24.0), 7, 1, Some(Vec2::new(4.0, 4.0)), None)

@oledfish once the Migration Guide is in and merge conflicts are resolved I'll merge this in for you.

I am planning to adopt this PR to merge conflicts and include migration information.

Adopted in #6057 :)


Layout/Design basic reporting

We need reports to show 'number of items', 'value of items', and more, on a per county or per organization basis.

TODO:

[ ] move order_date create to submit action transition?
[ ] store county not as an editable string this will mess with reporting and such potentiallly


Conditions support

I basically copy pasted the code from here and modified a few things such as this.$form and this.form now being the same, as well as turning the addEventListener calls into vanilla JS methods.
I also had to add javascript const fieldName = condition.field.replace('{', '').replace('}', '') to support the [name = query
I haven't tested it too thoroughly but I'd be interested in your thoughts as it seems to work fairly well just by copy-pasting the existing logic.
https://user-images.githubusercontent.com/13629190/171787616-c15e0cbe-23fc-4381-840b-19c92cee77d5.mp4

Only problem is that validation doesn't take into account hidden status, not sure what the behaviour around this should be.


HTML

HTML
User Story
As a boot camp student,
I want a Prework Study Guide website (please),
so that I can review all the information I learned throughout Prework (which would be nice).
Acceptance Criteria
GIVEN a Prework Study Guide website
WHEN I visit the website in my browser
THEN I see four boxes titled HTML, CSS, Git, and JavaScript with associated notes listed
WHEN I view the study guide
THEN I see a dark blue header and footer, and four boxes with a shadow
WHEN I open the console in my browser
THEN I can see the four topics I learned listed along with a suggestion on what I should study first
WHEN I visit the website using the URL
THEN I can access my website from any browser

Jumped ahead a little bit, but it got handled.


[feature request] Success message when enabling add-ons in user settings

Reported by @caileyfitz on 0.24 Trello board.
Steps

Go to user settings page
Go to Configure Add-ons
Click a couple add-ons to enable
Press submit

Expected
There would be a success message saying "Settings updated."
Actual
There is no message. The submit button lights up for a fraction of a second after clicking it without a message. Additionally, there is a success message on the project settings page.
discovered that the success message doesn't happen until you authorize an add-on

related to https://github.com/CenterForOpenScience/osf.io/issues/1621

Related to, perhaps resolved in https://github.com/CenterForOpenScience/osf.io/pull/2414


minijail: 16 -> 17

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 134498 at d327f21b run on aarch64-linux 1

1 package failed to build:

crosvm

2 packages built successfully:

minijail
minijail-tools

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.


CoAP road map

This is the big tracking issue for all things related to the CoAP+security components that should be part of RIOT-rs.
The big picture
Having a CoAP server running should be a feature that's available for both application and system components -- if SUIT update is enabled, there'd be a resource to POST a manifest to, if sensors are configured to be exposed, they're there, link-layer security can use CoAP to bootstrap (RFC9031), and if the application adds resources, they go in too. All these should be protected unless explicitly configured otherwise, with OSCRE (RFC8613) and EDHOC (RFC9528, yay, it's published). Big steps are therefore:

[ ] CoAP server can run
[ ] CoAP client requests can be sent
[ ] Modules can describe their resources for a CoAP server to be spawend automatically
[ ] CoAP requests are processed through OSCORE
[ ] The credentials associated with a request (from OSCORE contexts) are available to the resources
[ ] Resources don't need to care about the credentials because there are global rules for what is allowed
[ ] EDHOC exchanges are processed into OSCORE contexts
[ ] Credentials for EDHOC exchanges are verified using a configured AS key
[ ] EDHOC exchanges are initiated on demand
[ ] Credentials for EDHOC exchanges are obtained on demand from an AS
[ ] Configuration (eg. the AS identity) can be provisioned through 3-party EDHOC (authz)

As a tracking issue, all those will be turned into issues over time. I'm not sure we'll get to all of those, and others might be added, but that's the rough plan.
I don't plan to do them all in full sequence -- that'd delay interactions with the rest of the system, and I'd like to have (for example) credential configuration going way before everything with OSCORE is polished to the point where EDHOC gets added. Thus, I'll start small with https://github.com/future-proof-iot/RIOT-rs/pull/225 and quickly add losely tacked together OSCORE and EDHOC components, getting everything in a very rough state before starting to make it well-managed piece by piece.
External dependencies

I'd rather not write a CoAP server bespoke for embassy-net or smoltcp and rater hone the one based on embedded-nal. This requires embedded-nal support for embassy-net, and while that is formally there, the only parts that are really implemented as of now are embedded-nal DNS (which is basically a simplified getaddrinfo). So we need

[ ] https://github.com/embassy-rs/embassy/issues/2516 for which I have a draft PR https://github.com/embassy-rs/embassy/pull/2519
but that depends on  smoltcp:

[ ] https://github.com/smoltcp-rs/smoltcp/issues/903 / https://github.com/smoltcp-rs/smoltcp/pull/904#issuecomment-1923604593

Part of the whole story will be setting up your own minimal AS. (Or, really, generic trust anchor, because SUIT firmware signing needs a key too.) It may make sense to have some very minimal piece of software around that is documented to not be production ready but can hold the relevant keys for long enough that you can migrate to a "real" authentication server at some point.


[TEST] Revert k8s multus CI image update

What this PR does / why we need it:
Just checking if I introduced the current test failures on the k8s multus image with the latest CI image update
DO NOT MERGE!
/hold

yes, so at least the CI update didn't cause this. That doesn't answer the question why it fails though. Will create an issue.
/close

logs: http://jenkins.ovirt.org/job/kubevirt_kubevirt_standard-check-pr/2036//artifact/check-patch.k8s-multus-1.11.1-release.el7.x86_64/mock_logs/script/stdout_stderr.log


Test enhancement

Changed log

It seems that the base project requires php-7.1 version at least.
The coverage variable is false by default, and let the coverage be true on php-7.1 version during Travis CI build.

I think the Travis CI build should be integrated for every oncoming commits and pull requests.