MariaDB service using the original non-blocking API

This PR provide an mariadb_service using the original non-blocking API without internal thread.
And this PR brings more dependences on boost, boost.string_view and boost.beast(bind_handler and handler_ptr).

This change is

Hey @hhggit, thanks a lot for your contribution! As you might already realize, I'm not actively maintaining Amy right now. I do want to, but just don't have enough time. Plus that C++ is no longer my daily working programming language anymore.
Since you are working on Amy and extending it, I wonder whether you have any interests in maintaining it in the future? If yes, I'm more than happy to grant you write access to this repository :)
(Intended to send you a private email but couldn't find your email address anywhere.)

@liancheng I'll be glad to join in maintaing. If you had any requirements or suggests,  or found anything I didn't do well enough, please feel free to tell me.
(my email<EMAIL_ADDRESS>

@hhggit Cool :) I've invited you to be a collaborator of this repository. Feel free to drop me an email<EMAIL_ADDRESS>whenever you have any questions.


Extend pybamm_install_odes to include support for macOS systems

The pybamm/install_odes.py script, i.e., the pybamm_install_odes entry point currently installs the build-time requirements (SUNDIALS), sets relevant environment variables, and scikits.odes for use by the optional solver. Considering that users can also use scikits.odes on macOS by pointing to a SUNDIALS installation using the SUNDIALS_INST environment variable, we can add suitable modifications to this script to make it work on all UNIX-based systems (macOS and Linux).
Some reference can be used from the install_KLU_Sundials.py which currently works for both macOS and Linux. However, a difference to be noted is that install_odes.py does not compile the KLU module, whereas the aforementioned script does.
This will help simplify the installation of scikits.odes and enable doing so without the usage of a nox session, and can then be tested in CI.

Installation logs

$ pybamm_install_odes
/Users/agriyakhetarpal/Desktop/PyBaMM/pybamm/scikits_odes_setup.log
Adding /Users/agriyakhetarpal/.local/lib to LD_LIBRARY_PATH in /Users/agriyakhetarpal/Desktop/PyBaMM/venv/bin/activate
Collecting scikits.odes
  Downloading scikits.odes-2.7.0.tar.gz (931 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 931.8/931.8 kB 6.0 MB/s eta 0:00:00
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Requirement already satisfied: scipy in ./venv/lib/python3.11/site-packages (from scikits.odes) (1.11.3)
Requirement already satisfied: numpy<1.28.0,>=1.21.6 in ./venv/lib/python3.11/site-packages (from scipy->scikits.odes) (1.26.0)
Building wheels for collected packages: scikits.odes
  Building wheel for scikits.odes (pyproject.toml) ... done
  Created wheel for scikits.odes: filename=scikits.odes-2.7.0-cp311-cp311-macosx_13_0_arm64.whl size=885590 sha256=9f954addb89481d0c6c169143aaa0267b816dc008ec8f901d1890283ae6c9373
  Stored in directory: /Users/agriyakhetarpal/Library/Caches/pip/wheels/41/7b/df/a45628ef0daaa6d2c60461a092198e27eaa4f72d995ed524a4
Successfully built scikits.odes
Installing collected packages: scikits.odes
Successfully installed scikits.odes-2.7.0

From scikits_odes_setup.log

2023-10-04 22:48:38,065 - scikits.odes setup - INFO - Starting scikits.odes setup
2023-10-04 22:48:38,065 - scikits.odes setup - INFO - Looking for sundials at /Users/agriyakhetarpal/.local
2023-10-04 22:48:38,065 - scikits.odes setup - INFO - Found sundials at /Users/agriyakhetarpal/.local

Looks like the output was truncated because I already have a SUNDIALS installation from nox -s pybamm-requires. So I guess it should be possible (and easier than I expected) to modify it, we just need to build without KLU (i.e., "-DENABLE_KLU=OFF" in the cmake_args, which I suspect is the default behaviour, so it can be omitted as well. Another thing to handle would be finding OpenMP on macOS similar to install_KLU_Sundials.py. Do you want to take this?

It should also be fine to build with KLU and reuse an existing SUNDIALS installation like it did for my case, because scikits.odes does not provide an interface for it at all

Do you want to take this?

Sure, happy to pick it up.

Idea: enable KLU and add logic for finding OpenMP in order for users and developers to reuse the SUNDIALS files, though this would work only for source installations and not for pip installations (which come bundled with the dynamic libraries already)


Failed to install gflags

ENV：

vcpkg version bd7cd7f56d5d9fdfeb1f57810a2ea77bf4d7e31a
Windows 10 professional, simplified Chinese locale
cmake: 3.9.1 c:/Program Files/CMake/
git:  2.14.1.windows.1
Installed VS

Microsoft Visual Studio Community 2017 15.2 (26430.16) Release
Microsoft Visual Studio Community 2015 Version 14.0.25431.01 Update 3

I have successfully installed libevent:x86-windows and libevent:x86-windows, but failed to install gflags.

The output is :
D:\git\vcpkg>vcpkg install glog gflags
The following packages will be built and installed:
    gflags:x86-windows
    glog:x86-windows
Building package gflags:x86-windows...
-- CURRENT_INSTALLED_DIR=D:/git/vcpkg/installed/x86-windows
-- DOWNLOADS=D:/git/vcpkg/downloads
-- CURRENT_PACKAGES_DIR=D:/git/vcpkg/packages/gflags_x86-windows
-- CURRENT_BUILDTREES_DIR=D:/git/vcpkg/buildtrees/gflags
-- CURRENT_PORT_DIR=D:/git/vcpkg/ports/gflags/.
-- Using cached D:/git/vcpkg/downloads/gflags-gflags-v2.2.0.tar.gz
-- Testing integrity of cached file...
-- Testing integrity of cached file... OK
-- Extracting done
-- Applying patch D:/git/vcpkg/ports/gflags/fix-install.patch
-- Applying patch failed. This is expected if this patch was previously applied.
-- Applying patch D:/git/vcpkg/ports/gflags/fix-install.patch done
-- Applying patch D:/git/vcpkg/ports/gflags/fix-static-linking.patch
-- Applying patch failed. This is expected if this patch was previously applied.
-- Applying patch D:/git/vcpkg/ports/gflags/fix-static-linking.patch done
-- Configuring x86-windows-rel
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:43 (message):
    Command failed: C:/Program Files/CMake/bin/cmake.exe;D:/git/vcpkg/buildtrees/gflags/src/gflags-2.2.0;-DGFLAGS_REGISTER_BUILD_DIR:BOOL=OFF;-DGFLAGS_REGISTER_INSTALL_PREFIX:BOOL=OFF;-DBUILD_gflags_nothreads_LIB:BOOL=OFF;-DBUILD_SHARED_LIBS=ON;-DVCPKG_TARGET_TRIPLET=x86-windows;-DCMAKE_CXX_FLAGS= /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP ;-DCMAKE_C_FLAGS= /DWIN32 /D_WINDOWS /W3 /utf-8 /MP ;-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON;-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON;-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON;-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE;-DCMAKE_VERBOSE_MAKEFILE=ON;-DVCPKG_APPLOCAL_DEPS=OFF;-DCMAKE_TOOLCHAIN_FILE=D:/git/vcpkg/scripts/buildsystems/vcpkg.cmake;-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON;-DCMAKE_CXX_FLAGS_RELEASE=/MD /O2 /Oi /Gy /DNDEBUG /Zi ;-DCMAKE_C_FLAGS_RELEASE=/MD /O2 /Oi /Gy /DNDEBUG /Zi ;-DCMAKE_SHARED_LINKER_FLAGS_RELEASE=/DEBUG /INCREMENTAL:NO /OPT:REF /OPT:ICF ;-DCMAKE_EXE_LINKER_FLAGS_RELEASE=/DEBUG /INCREMENTAL:NO /OPT:REF /OPT:ICF ;-G;Ninja;-DCMAKE_BUILD_TYPE=Release;-DCMAKE_INSTALL_PREFIX=D:/git/vcpkg/packages/gflags_x86-windows
    Working Directory: D:/git/vcpkg/buildtrees/gflags/x86-windows-rel
    See logs for more information:
      D:\git\vcpkg\buildtrees\gflags\config-x86-windows-rel-out.log
      D:\git\vcpkg\buildtrees\gflags\config-x86-windows-rel-err.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_configure_cmake.cmake:170 (vcpkg_execute_required_process)
  ports/gflags/portfile.cmake:18 (vcpkg_configure_cmake)
  scripts/ports.cmake:72 (include)

Error: Building package gflags:x86-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: gflags:x86-windows
  Vcpkg version: 0.0.83-bd7cd7f56d5d9fdfeb1f57810a2ea77bf4d7e31a

Additionally, attach any relevant sections from the log files above.

And the content of D:\git\vcpkg\buildtrees\gflags\config-x86-windows-rel-err.log is :
CMake Error at C:/Program Files/CMake/share/cmake-3.9/Modules/CMakeTestCXXCompiler.cmake:44 (message):
  The C++ compiler "C:/Program Files (x86)/Microsoft Visual
  Studio/2017/Community/VC/Tools/MSVC/14.10.25017/bin/HostX64/x86/cl.exe" is
  not able to compile a simple test program.

  It fails with the following output:

   Change Dir: D:/git/vcpkg/buildtrees/gflags/x86-windows-rel/CMakeFiles/CMakeTmp

  Run Build
  Command:"D:/git/vcpkg/downloads/tools/ninja/ninja-1.7.2/ninja.exe"
  "cmTC_81c7a"

  ninja: error: build.ninja:30: loading 'rules.ninja':
  系统找不到指定的文件。

  include rules.ninja

                     ^ near here

  CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
  CMakeLists.txt:94 (project)

rollback cmake to 3.8.2, cmake 3.9.x  create ninja project failed

Thanks @fcharlie
When I rollback cmake to 3.8.2, vcpkg will automatically try to install cmake 3.9.1 itself.

@zieckey rename cmake-3.8.2-win32-x86 to cmake-3.9.1-win32-x86

I used cmake-3.8.2-win64-x64.msi to install cmake. I cannot rename it to cmake-3.9.1-win64-x64.msi

@zieckey Please download https://cmake.org/files/v3.8/cmake-3.8.2-win32-x86.zip, unpack to vcpkg root downloads after rename cmake-3.8.2-win32-x86 to cmake-3.9.1-win32-x86 。

if you comment out the prefer_ninja in the gflags port file, does it compile?

As suggested by @fcharlie, chcp 65001 in the console you're running Vcpkg from is the best way to work around this issue.
Unfortunately, cmake+ninja has some trouble with non-English codepages on Windows, though I'm not sure where in the stack the true problem lies. We should probably fix this in the tool itself by setting the codepage before performing any build.

@ras0219-msft Ninja run on Windows Codepage 936 is success, but cmake 3.9 invoke ninja is failed !
cmake 3.8 is ok. cmake 3.9.x is stupid
https://github.com/fstudio/clangbuilder/blob/908c21f7d179a17d05469c48395fcb92f2f32e46/bin/ClangbuilderTarget.ps1#L239
My Clangbuilder PS Function (Start-Process convert encoding, .Net System.Diagnostics.Process  )
Function ClangNinjaGenerator{
    param(
        [String]$ClangExe,
        [String]$BuildDir
    )
    $env:CC=$ClangExe
    $env:CXX=$ClangExe
    Write-Host "Build llvm, Use: CC=$env:CC CXX=$env:CXX"
    Set-Workdir $BuildDir
    $Arguments=Get-ClangArgument
    $oe=[Console]::OutputEncoding
    [Console]::OutputEncoding = [System.Text.Encoding]::UTF8 ### Ninja need UTF8
    $exitcode = ProcessExec  -FilePath "cmake.exe" -Arguments $Arguments
    if ($exitcode -ne 0) {
        Write-Error "CMake exit: $exitcode"
        return 1
    }
    [Console]::OutputEncoding=$oe
    $PN = & Parallel
    $exitcode = ProcessExec -FilePath "ninja.exe" -Arguments "all -j $PN"
    return $exitcode
}

Function ProcessExec {
    param(
        [string]$FilePath,
        [string]$Arguments,
        [string]$WorkingDirectory
    )
    $ProcessInfo = New-Object System.Diagnostics.ProcessStartInfo
    $ProcessInfo.FileName = $FilePath
    Write-Host "$FilePath $Arguments $PWD"
    if ($WorkingDirectory.Length -eq 0) {
        $ProcessInfo.WorkingDirectory = $PWD
    }
    else {
        $ProcessInfo.WorkingDirectory = $WorkingDirectory
    }
    $ProcessInfo.Arguments = $Arguments
    $ProcessInfo.UseShellExecute = $false ## use createprocess not shellexecute
    $Process = New-Object System.Diagnostics.Process
    $Process.StartInfo = $ProcessInfo
    if ($Process.Start() -eq $false) {
        return -1
    }
    $Process.WaitForExit()
    return $Process.ExitCode
}

@fcharlie  I follow your advice, it works. Thanks.

Link to CMake's bugtracker https://gitlab.kitware.com/cmake/cmake/issues/17191

@zieckey @fcharlie please test #1682

@Mixaill I test it.

@bradking Thanks, @ras0219-msft  Now ,Your need create a patch to fix CMakeDetermineCompilerId.cmake, not need rebuild cmake, or wait cmake 3.9.2.
https://gitlab.kitware.com/brad.king/cmake/commit/de9840d1b89481132ee128715506f6aee9d0277c

I think in parallel with the upstream CMake fix, we should look at just always using chcp 65001 internally. This will further improve build consistency between machines, ensuring that everyone is able to reproduce any errors easily.

@ras0219-msft This will also fix various display problems, such as non-English text corruption (for example, in private ports).

Please report if the latest master fixes things for you.


Patch zlib vuln CVE-2022-37434

Patch CVE-2022-37434 by upgrading to Alpine 3.16.

Codecov Report

Merging #61 (b8f8109) into main (0595df7) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head b8f8109 differs from pull request most recent head a5eeb8e. Consider uploading reports for the commit a5eeb8e to get more accurate results

@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage   59.11%   59.11%
=======================================
  Files           4        4
  Lines         318      318
=======================================
  Hits          188      188
  Misses         98       98
  Partials       32       32

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Treat accented characters as being similar to their non-accented counterparts

Category:

[ ] fzf binary
[ ] fzf-tmux script
[ ] Key bindings
[ ] Completion
[ ] Vim
[ ] Neovim
[x] matching algorithms

OS

[x] Linux
[ ] Mac OS X
[ ] Windows
[ ] Windows Subsystem for Linux
[ ] Etc.

Shell

[ ] bash
[x] zsh
[ ] fish

$ fzf --version
0.15.9

I use fzf on my music collection. If I type antonio jobim so danco samba the top choice ends up being
./Antônio Carlos Jobim/[1965] - The Wonderful World Of Antonio Carlos Jobim/10 - Samba Do Aviao.mp3

Whereas it seems to me that this should be the one:
./Antônio Carlos Jobim/[1994] - Antonio Brasileiro/01 - Só Danço Samba.mp3

Makes sense. I'll pay special attention to this because Jobim is great.

Fixed in devel branch. I'm planning to release a new version in a few days, but feel free to test the devel branch (check out the branch and run install script to download the binary) and let me know of any issues you notice. Thanks.

I changed my mind. Normalization is enabled by default and one has to pass --literal to disable it.


API Reference not in Github pages documentation

I suspect that this is because the auto api requires a python package that is not installed in the documentation environment.

This is fixed!


Add base 16, 8 and 2 for numbering

Why not add bin and oct as well?

Honestly, I've never seen anyone using a hexadecimal numbering pattern for lists, not sure if it's really worth it to add this to the library. I guess there's no harm in adding it, but still.

@LaurenzV: I've mostly seen it done in kind of nerdy/techy publications as a sort of gimmick and wanted to replicate that
@lucifer1004: done

I first want to figure out the numbering story before having more patterns.

Numbering patterns need a general rework to handle the collision problem. Perhaps there will be base 2, 8, and 16 as part of that, but I think it will be easier to integrate that with this rework later than rebasing this, so I'm going to close this.


add trace_id_high for joining with zipkin_annotations

In Mysql 5.7 Reference Manual (8.3.1 How Mysql Uses Indexes):

If the table has a multiple-column index, any leftmost prefix of the index can be used by the optimizer to look up rows. For example, if you have a three-column index on (col1, col2, col3), you have indexed search capabilities on (col1), (col1, col2), and (col1, col2, col3).

In mysql.sql of zipkin:

ALTER TABLE zipkin_spans ADD INDEX(trace_id_high, trace_id, id) COMMENT 'for joining with zipkin_annotations';

So, I think it should add trace_id_high condition for joining with zipkin_annotations.

this should do what you want https://github.com/openzipkin/zipkin/pull/1909

I think this pr cloud be closed. can see #1909


Upgrade to Byzantium

The EVM used in TestRPC should be updated to Byzantium.
Expected Behavior
TestRPC should support the new opcodes such as REVERT, RETURNDATACOPY and RETURNDATASIZE. Also it should use the new transaction receipt structure.
Current Behavior
Currently it still uses the previous protocol version.
Possible Solution
Upgrade to the new release of ethereumjs-vm.
Context
Right now we cannot test contract code using new features of Byzantium.
This is also especially bad when testing for revert() as geth and TestRPC now have different behaviour.
This means you need separate checks for TestRPC (exception with "invalid opcode") and geth (no exception but status in receipt 1). Ideally the same test code should run on both.

Receipt should also contain a status property that indicates whether the transaction succeeded or a throw/revert bubbled up and rolled back the transaction.

Right now I'm using geth with --dev flag to test locally. https://gist.github.com/eduardonunesp/ec5c88609586988d01c35ebf51756e85

And include support for new precompiled contracts - modexp, alt_bn128_G1_add, alt_bn128_G1_mul & alt_bn128_pairing_product.

Here is pull request for RETURNDATASIZE and RETURNDATACOPY: https://github.com/ethereumjs/testrpc/pull/409
if you need it working right now you can use https://github.com/0v1se/testrpc

New opcodes added by upgrading to ethereumjs-vm v2.3.1 here: trufflesuite/ganache-core#19
Test maintenance for latest solc-js & vm update is here: trufflesuite/ganache-core#27
Addition of status flag in tx receipt is here: trufflesuite/ganache-core#28
The first one has found its way into testrpc v5.0.1 (in NPM under the beta tag, as it hasn't been fully vetted). I'm going to look into @riordant's comment above to see what, if anything, we need to do there. I'll likely release 5.0.2 (again, as a beta) with the status flag, and if other things need to be done for precompiled contracts, I'll push out a 5.0.3.
Finally, once I get a chance to sit down and audit TestRPC for compliance w/ the Byzantium changes, assuming we've covered them all, I'll close this issue.

@riordant it appears that these contracts are already supported in the v5.0.1 beta, thanks to ethereumjs-vm 2.3.1, so no further work is necessary for TestRPC to include this.
That said, I'm going to defer the release formerly known as 5.0.2 until I have a chance to review/accept trufflesuite/ganache-core#21 (shoutout to @mjkoo for his diligence on this one!). This PR comes with a few breaking changes, so this will wind up being 6.0.0, and with any luck I'll have it reviewed & merged to trufflesuite/ganache-core today.
I'll likely also bump ethereumjs-vm 2.3.1 to 2.3.2 in this release as well, as it's said to contain some bugfixes/optimizations. @jwasinger - please pipe up if you feel this would be a mistake.
As for when it'll be released, that's a bit less certain. I'll be traveling a bit tomorrow, but even still I will likely be able to get a TestRPC 6.0.0 out before the end of the week.

I've just released ganache-core 2.0.0, and I expect to be getting TestRPC 6.0.0 out to npm tomorrow morning, EDT. With that in mind, I'm closing this one.


impulse manifest

Please provide me sample json to create impulse.manifest.
Also please guide how i can use it for training deepspeech model.

please see https://github.com/PaddlePaddle/DeepSpeech/blob/develop/data/noise/chime3_background.py for create manifest.
training example under examples/tiny.


Not enough memory error when parsing pbf dataset

Hello.
I was trying to parse a pbf file (approx. 65 mb) and I get an "out of memorry" error. I also have noticed that others have this issue as well. My machine specs should be sufficient for parsing this data (16gb of ram, i7 CPU),... I suppose.
I tried to investigate why this memory error occurs on small datasets and in my case it looks like it comes from node elements that are returned from the parse_osm_data (cython method)  in pyrosm.py. Each node's property that is returned is an array of size x (in my case 8000). I couldn't manage to debug Cython code so I don't quite understand why this behavior happens. Is there any reason why all these elements are returned only for nodes. ?
Thank you.

Hmm, this sounds weird. A pbf of that size should fit to the memory if you have 16GB RAM. I assume you don't have anything else running at the same time that would consume a lot of memory?
Could you say which PBF file did you try to read, so I can check whether I can reproduce this behavior on my laptop?

Yes, I had other services running but I had available around 6-7 GB of memory and I thought this would be sufficient.
This is the data:
https://download.geofabrik.de/europe/germany/bayern/mittelfranken-latest.osm.pbf

Yes, unfortunately due to the logic how pyrosm now reads everything into memory at a first step, is not a good solution. There is discussion about this topic in many other issues as well. And there are plans to improve the memory handling by changing the logic how the data is read which should allow reading much bigger PBF files. However, it takes some time before getting this implemented.

@majkshkurti Which operating system you are working with? If on Unix, adding more Swap memory can help a little bit this issue: https://linuxize.com/post/how-to-add-swap-space-on-ubuntu-20-04/

Hmm, okay there is actually a significant different between the memory usage of pyrosm v0.5.3 vs the current version. With pyrosm==0.5.3 parsing e.g. the mittelfranken PBF can be done with ease, whereas with the current release, also my computer struggles parsing the file.
There have been some changes that might explain this, such as #50 which might explain why the numpy arrays now consume much more memory than before.. Will look into this!

I understand. Yes, I am using UNIX. The problem is that sometime I run this inside a docker container in which I can't allocate a lot of memory. I will switch to version 0.5.3 at the moment. I will have a look on the source code and think on how to improve the performance.
Thanks a lot for the great work.

Ah, yes sure, with Docker it can indeed be tricky to do any tricks with swap memory.
I already did a bit of improvements (in #151) which helped to bring the memory footprint down a bit (closer to the level as it was with v0.5.3) . I was able to read a PBF with size of 150MB with 16GB of memory and another 16GB of Swap.

Can confirm this issue, i tried also to read the mittelfranken and oberbayern pbf files, in both cases the Kernel just died without any error message.

Hi @HTenkanen
I think this issue has more to it than just the Memory issues. I am currently using this library in a GCP VM where i am facing ipython notebook kernel dying for the smallest of PBF files(Comores 3.3MB).
However i can get results if i call certain functions like get_network() but when i try to do a custom filter it kills the kernel.


use void 0 for undefined

related: https://github.com/vercel/swr/pull/1150/files#diff-a9f5a8b144cf49d7b58fc30f932087e24c4c11d1e741d7d1c8be1a2f6d81fe71R2
src/utils/helper.ts claims that undefined could be replaced by something else so it has to be avoided.
It's correct if it runs in sloppy mode, but the current implementation ({})[0] can still be replaced to something else.
( only if Object.prototype[0] is mutated before importing swr, though )
({})[0] // undefined

Object.prototype[0] = 'something else'

({})[0] // "something else"

It seems ({})[0] is not the best approach to avoid it, this PR uses void 0 instead

Thanks for noticing this and it's a very good point. We will address this after some minifier work!

Here's what I'm thinking about:
export const noop = () => {}

// The global value `undefined` can possibly be replaced by something else.
// This is a trick to get the safe `undefined` with shortest code.
export const UNDEFINED: undefined = (noop as any)[noop as any]

export const isUndefined = (v: any): v is undefined => v === UNDEFINED
export const isFunction = (v: any): v is Function => typeof v === 'function'
export const mergeObjects = (a: any, b: any) => Object.assign({}, a, b)

So the minified code will look like x[x], where x is an anonymous function.
The reason we are not using void 0 here is, the compiler currently inlines all UNDEFINED values to void 0 so the minified code will be ~100 bytes larger.

The alternative way above is shorter, but does not seem safer.
noop[noop] is still replaceable, since index accessing actually calls toString(), and all string key in objects are potentially pollutable if the key is not set.
const noop = () => {}

noop[noop] // undefined

Function.prototype['() => {}'] = 1

noop[noop] // 1

If you stick to smaller bundle and prefer it to using void 0, this PR could be closed.

For taking both smaller bundle and preventing pollution, I came up with something like this.
This needs longer code to assign, but codes accessing this could be minified to x._, right ?
const UNDEFINED = Object.freeze({  _: void 0 })

UNDEFINED._ // undefined

UNDEFINED._ = 1
UNDEFINED._ // undefined

Object.prototype._ = 1
UNDEFINED._ // undefined

But I'm not sure it's technically "safe" ( help wanted ).

@fsubal you can use NaN[0] to replace with {}[0] since varaiables like NaN, Infinity can't be mutated or assigned with properties. And only give 1 byte increased to dist bundle.

@huozhi No, NaN[0] can actually be overridden by mutating Number.prototype[0].
NaN[0] === undefined // true

Number.prototype[0] = 1

NaN[0] === 1 // true

It seems that the way we can have is either of

Getting more bundle size using void 0
Configuring (if possible) to prevent inlining from UNDEFINED to void 0
Accepting potential prototype pollution using something[0]
Accepting some overhead to prevent mutation using Object.freeze

I feel we need to find a way to avoid void 0 to be inlined as undefined on minifier side. Then adopting this change will be safe.

Is this really an issue in esm/strict mode?

@fsubal

for the sake of bundle size

I see, I wonder if any improvement in that aspect would already be covered by gzip/brotli compression. 🤔

To summarize the bundle size problem ( from my understanding ), currently merging this PR would lead to something like this.
When we have this source,
import { UNDEFINED } from 'src/utils/helpers'

// meaningless code but is useful for explaination
if (something() === UNDEFINED) {
  console.log(UNDEFINED, UNDEFINED, UNDEFINED, UNDEFINED)
}

We would get this,
// all undefined constants are inlined to void 0, which will make bundle size meaninglessly increase
if(a()===void 0){console.log(void 0,void 0,void 0,void 0)}

What we want instead is, for example,
// undefined is inlined only once, which could be acceptable
var x=void 0;if(a()===x){console.log(x,x,x,x)}

ref: https://github.com/vercel/swr/pull/1372#issuecomment-905423253
I think we have reached to the conclusion that we should change (or pursue) how to configure minifier of this project to accomplish the latter one, before merging this PR. https://github.com/vercel/swr/pull/1372#issuecomment-905519387


How do you import external modules for use in a Python script?

Never used IronPython before and so a bit stuck with importing an external module for use in a Python script. Done a lot of Googling, but no luck so far.
Any help would be appreciated. 🐈

This isn't exactly an issue with the project. I assume you're asking about external python modules, in which case you should probably ask over at the IronPython side of things. It seems like a common enough kind of question though so you should be able to find an answer.

I've scoured through quite a few searches to no avail unfortunately. Which is what initially lead me to submit an issue in the first place.
I'll have another search session tommorow and if I have any luck, post the results here for anybody with the same issue.

Right, once again did a lot of searching and nothing I've tried has worked, once again. At this point I'm ready to give up with the script (and Aurora) and figure something else out, hopefully it'll actually work out. :-/

Ended up scrapping IronPython and just made the script in C#, everything works perfectly fine now. 👍


Init Azure DevOps config

Tested successed on my forked repo:

Considering the block of Travis CI, we should force merge this and then I might create another pipeline for this repo.

Able to merge, succeed in my testing pipeline:


Fix new cookie mechanism not being session based

We had assumed that not passing days to window.GOVUK.cookie() set a default expiry, but it doesn't set any expiry date (therefore creating a session cookie).
This PR:

Sets the expiry date of the consent cookie and the seen_cookie_message cookie to 1 year
Adds a default expiry of 30 days to window.GOVUK.cookie()

 Some people are seeing the banner again after interacting with it

@tijmenb Will add the tests after the fix is complete, as there's a bit of a rush on getting this done 👍


Audio Clip Normalize Including Effects Chain

In DaVinci Resolve  18.6.2 and the public beta release 19: When you normalize an audio clip, the procedure is including the Effects Chain to assess the audio level.

Firstly, normalize the clip without any effects - note the audio levels and the peak display.
Place a gain-changing plugin, such as a compressor, into the effects chain.
Set the plugin up to significantly reduce the gain.
Run the normalize function again.
Disable the plugin.
Compare the audio clip levels now to before.

You will find the clip gain much higher than before, roughly or exactly equivalent to the gain change in the effects chain.
The effects chain should not be included in the audio clip normalize function.  The function should set audio levels relative to the audio clip before further processing.  This is an industry standard.
To include the effects chain in assessing the level and then applying that back to the clip introduces mayhem.

You can see the result at the input volume for processing for the clip.
Changing effects levels down the line are affecting the input level adjustment.  This is highly improper.


Responsive Subscribe section in mobile view

New Mockup
Please check assets/css/global.css, design-assets folder images, and figma files for updated style guides. Any new pull request should use the updated color, spacing, and sizing variables.
No Bootstrap or jQuery
Please refrain from adding Bootstrap or jQuery to the site. These pr's will be closed. They overwrite global styles. Vanilla CSS and JS is way better now anyways 😊
New Task:
What is the task
When in mobile view, the subscribe view is off the screen.
Who is the task for?

[x] I created this task for me to complete, I will create a PR soon.
[ ] I created this task for someone else to claim.
[ ] I think this is a task that multiple people can do

Confirm all of the following:

[x] I have looked at all the issues currently available and this does not exist or overlap with another ticket

⚠ PLEASE ONLY SUBMIT A PR FOR THIS TASK IF THIS TASK WAS AVAILABLE FOR YOU TO CLAIM

On it.


new release of the repo

Describe the bug / error
Hello Takeshi,
Could you please create a new release of the repo as I would like to leverage some of the features that were released this year.
The current version is almost 1 year old.
What is your Envoy/Istio version?

URL or snippet of your code including Envoy configuration
Additional context (Optional)

fair enough. thank you for the heads up! @harsha-konda

https://github.com/tetratelabs/proxy-wasm-go-sdk/releases/tag/v0.23.0 here you go


MolFromSmarts flips chiral center

Configuration:

RDKit Version: 2020.03 (but this is dates back to 2018.09 at least)
Operating system: Linux/MacOS
Python version (if relevant): 2.7 and 3.7
Installed with conda rdkit channel

Description:
MolFromSmarts flips the chiral center, and the molecule has inverse chirality vs the input. I came across this bug with sulphur but it also surface with carbon as a chiral center. I understand that SMARTS is not intended to roundtrip, but this is not an output problem, the molecule has actually inverse chiral tag.
In [23]: Chem.MolToSmarts(Chem.MolFromSmarts('[S@@](=O)(-C)-CC'))
Out[23]: 'O=[S@@](-C)-CC'

In [28]: Chem.MolToSmarts(Chem.MolFromSmarts('[C@@H](-O)(-C)-CC'))
Out[28]: 'O-[C@@&H1](-C)-CC'

The problem does not show up when chiral atom is not the first one:
In [37]: Chem.MolToSmarts(Chem.MolFromSmarts('C-[S@@](=O)-CC'))
Out[37]: 'C-[S@@](=O)-CC'

MolFromSmiles is free of that problem:
In [32]: Chem.MolToSmiles(Chem.MolFromSmiles('[S@@](=O)(-C)-CC'))
Out[32]: 'CC[S@](C)=O'

In [33]: Chem.MolToSmiles(Chem.MolFromSmiles('[C@@H](-O)(-C)-CC'))
Out[33]: 'CC[C@@H](C)O'

Another case, with ring closure. This might be unrelated, and only works without filled valence.
In [71]: Chem.MolToSmarts(Chem.MolFromSmarts('C1CC(-C)CC[C@@]1CO'))
Out[71]: 'C1CC(-C)CC[C@]1CO'

With H on chiral atom it is fine:
In [72]: Chem.MolToSmarts(Chem.MolFromSmarts('C1CC(-C)CC[C@@H]1CO'))
Out[72]: 'C1CC(-C)CC[C@@&H1]1CO'

The problem seems to be rooted in chiralAtomNeedsTagInversion https://github.com/rdkit/rdkit/blob/1dc9ac3fbf84a9a54a5cbf4adf9a115686c59c32/Code/GraphMol/Canon.cpp#L73-L81

I wanted to bump this issue. @greglandrum Did you have any time to look at this? Let me know how I can help if you need more examples/feedback from my side.

I believe the behavior in the case of [S@@](=O)(-C)-CC is correct: the SMARTS [S@@](=O)(-C)-CC and O=[S@@](-C)-CC are equivalent to each other just as the equivalent SMILES are.
The case of C with an implicit H in the SMARTS (addressed in #6730) is different.

@greglandrum I double checked that in Marvin and looks like the sulphur smiles is different according to ChemAxon toolkits


DF/F RoiResponseSeries fails on transition from 10 to 20 channel selections

https://neurosift.app/?p=/nwb&url=https://api.dandiarchive.org/api/assets/f02db27e-82eb-41dd-865a-a08bb41491da/download/&dandisetId=000728&dandisetVersion=draft&tab=neurodata-items:neurodata-item:/processing/ophys/DfOverF/DfOverF|RoiResponseSeries@neurodata-item:/processing/behavior/BehavioralTimeSeries/running_speed|TimeSeries
10 works great

Change it to 20 and nothing renders at all

I chunked these at ~10MB, a corresponding data selection streams very quickly in Python

No errors in console that I can see either, and doesn't matter how long I wait

@CodyCBakerPhD I think you just need to zoom in as the message says. This is to prevent excessive data loading. There's also a way to override that protection - click the ? button.

Zooming in time more did the trick!

There's also a way to override that protection - click the ? button.

That just leads to

I meant the other question mark :)
on the left tool panel for the timeseries view


[Port] properly escape slashes in constant strings with StringExpression/ValueExpression

Fixes #2443
Description
When encoding a string as an expression we need to properly handle slash.
Specific Changes

AdaptiveExpressions
AdaptiveExpressions.Tests

Testing
tests updated to validate round-trip slashes

Pull Request Test Coverage Report for Build 154878

2 of 2 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.857%

Totals

Change from base Build 154875:
0%

Covered Lines:
14828

Relevant Lines:
17011

💛  - Coveralls


Feature/add shoal mask

I think its is easier to have a function called get_shoal_mask() as it is easier to understand what it does compared to directly calling weil(). For all of the other masking algorithm we had a convention of get_"noise_type"_mask() wrapper function over the specific implementation(ryan(),ariza(), etc.).

Added

TODO, after Wu Jung Lee's comments to our PR:

[ ] move weill to echopype/mask/shoal.py, rename as private
[ ] move get_shoal_mask to echopype/mask/api.py
[ ] test setup part should now use pytest fixtures and be in tests/clean/conftest.py and requested by the test modules

Closing since no longer part of our workflow


Emails not sendind:

Hi, I set up the smt server at https://elasticemail.com/account#/create-account?r=20b444a2-b3af-4eb8-bae7-911f6097521c,
Put in all the info and installed your package but it is not sending any emails.
Do you know what could be wrong?
Do you have a test server I could use?
Thank you

Hi! Did you solve it? I have same issue

I have the same issue. Anyone?

I have this problem aswell...

I have the same issue, Emails are not sending. Did anyone resolve the issue.

Finally made this working

It's working, thank you Maciej


BHBC-1656: Download Project Shapefiles

Overview
Links to jira tickets

https://quartech.atlassian.net/browse/BHBC-1656

This PR contains the following changes

{List all the relevant changes. If there are many changes across many Jira tickets, organize the changes by Jira ticket}

This PR contains the following types of changes

[ ] New feature (change which adds functionality)
[ ] Enhancement (improvements to existing functionality)
[ ] Bug fix (change which fixes an issue)
[ ] Misc cleanup / Refactoring / Documentation
[ ] Version change

Checklist
A list of items that are good to consider when making any changes.
Note: this list is not exhaustive, and not all items are always applicable.
General

[ ] I have performed a self-review of my own code

Code

[ ] New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
[ ] I have avoided duplicating code when possible, moving re-usable pieces into functions
[ ] I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
[ ] My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
[ ] My code changes account for null/undefined values and handle errors appropriately
[ ] My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

[ ] My code follows the established style conventions
[ ] My code uses native material-ui components/icons/conventions when possible

Documentation

[ ] I have commented my code sufficiently, such that an unfamiliar developer could understand my code
[ ] I have added/updated README's and related documentation, as needed

Tests

[ ] I have added/updated unit tests for any code I've added/updated
[ ] I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

[ ] I have run the linter and fixed any issues, as needed
See the lint commands in package.json
[ ] I have run the formatter and fixed any issues, as needed
See the format commands in package.json

SonarCloud

[ ] I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Screenshots
Please add any relevant UI screenshots, if applicable.

Looks good, nice that it was simple to add.
Did you have anything else to add to this, or is it good to go?

Looks good, nice that it was simple to add.
Did you have anything else to add to this, or is it good to go?

That was all I had to add, I can open another pr or ticket for more code testing coverage.


Pin MLflow version to 1.23.0 on pyfunc-server and batch-prediction base image

What this PR does / why we need it:

The current implementation of the new base image for batch predictor upgrade the MLflow version to 1.30.0, however, there's a backward incompatibility in the loading model of SparkModel: https://github.com/mlflow/mlflow/pull/5290
The SparkModelCache.get_or_load in mlflow>=1.25.0 returns a tuple instead of a pyfunc object.
To make it more predictable, we also pin mlflow version in pyfunc's base image to 1.23.0 to match merlin-sdk's requirements.
Does this PR introduce a user-facing change?:

NONE

Checklist

[ ] Added unit test, integration, and/or e2e tests
[ ] Tested locally
[ ] Updated documentation
[ ] Update Swagger spec if the PR introduce API changes
[ ] Regenerated Golang and Python client if the PR introduce API changes

The current implementation of the new base image for batch predictor upgrade the MLflow version to 1.30.0

Wher do we specify mlflow 1.30.0?

The current implementation of the new base image for batch predictor upgrade the MLflow version to 1.30.0

Where do we specify mlflow 1.30.0?

We don't specify it but the mlflow library when logging the model. In conda.yaml, mlflow without any version constraint will be added to the dependencies list.

We don't specify it but the mlflow library when logging the model. In conda.yaml, mlflow without any version constraint will be added to the dependencies list.

Got it. But why don't we see similar problem for pyfunc server?

We don't specify it but the mlflow library when logging the model. In conda.yaml, mlflow without any version constraint will be added to the dependencies list.

Got it. But why don't we see similar problem for pyfunc server?

Because pyfunc server already uses pyfunc.load_model() directly: https://github.com/gojek/merlin/blob/main/python/pyfunc-server/pyfuncserver/model/model.py#L62
Compared to batch predictor that depends on SparkModelCache.get_or_load(): https://github.com/gojek/merlin/blob/main/python/batch-predictor/merlinpyspark/model.py#L70


Sensor BMI160: set of undersampling mode is not working

Problem description
In low power mode, the accelerometer current consumption is to high. After investigation I discovered that the undersampling mode wasn't corretly set in BMI160_REG_ACC_CONF.
To Reproduce
Steps to reproduce the behavior:

Add in prj.conf:

CONFIG_BMI160=y
CONFIG_BMI160_ACCEL_PMU_LOW_POWER=y
CONFIG_BMI160_GYRO_PMU_SUSPEND=y

Modify drivers/sensor/bmi160/bmi160.c

int bmi160_reg_field_update(struct device *dev, u8_t reg_addr,
			    u8_t pos, u8_t mask, u8_t val)
{
	u8_t old_val, new_val, val;

	if (bmi160_byte_read(dev, reg_addr, &old_val) < 0)
		return -EIO;
	val = (old_val & ~mask) | ((val << pos) & mask);
	if (bmi160_byte_write(dev, reg_addr, &val) < 0)
		return -EIO;
	if (bmi160_byte_read(dev, reg_addr, &new_val) < 0)
		return -EIO;

	if (reg_addr == BMI160_REG_ACC_CONF)
		printk("BMI160_REG_ACC_CONF - old: %d, value to write "
			  "in reg: %d, new val: %d", old_val, val, new_val);

	return 0;
}

Run a simple program
See that new value in BMI160_REG_ACC_CONF has not the expected value

Expected behavior
BMI160_REG_ACC_CONF: bit 7 of new_val should be enabled.
Impact
High current consumption in accelerometer low power mode
Solution
bmi160_pmu_set calls bmi160_reg_field_update() with a wrong pos parameter (shift of 128 instead of 7).
git diff drivers/sensor/bmi160/bmi160.h
@@ -170,7 +170,8 @@
 #define BMI160_ACC_CONF_ODR_MASK	0xF
 #define BMI160_ACC_CONF_BWP_POS		4
 #define BMI160_ACC_CONF_BWP_MASK	(0x7 << 4)
-#define BMI160_ACC_CONF_US		BIT(7)
+#define BMI160_ACC_CONF_US_POS		7
+#define BMI160_ACC_CONF_US_MASK		BIT(7)

 /* BMI160_REG_GYRO_CONF */
 #define BMI160_GYR_CONF_ODR_POS	0

git diff drivers/sensor/bmi160/bmi160.c
@@ -163,7 +163,7 @@ static int bmi160_pmu_set(struct device *dev, union bmi160_pmu_status *pmu_sts)
 	/* set the undersampling flag for accelerometer */
 	return bmi160_reg_field_update(dev, BMI160_REG_ACC_CONF,
-				       BMI160_ACC_CONF_US, BMI160_ACC_CONF_US,
+				       BMI160_ACC_CONF_US_POS, BMI160_ACC_CONF_US_MASK,
 				       pmu_sts->acc != BMI160_PMU_NORMAL);
 }

@vinceWii4 I created a pull request with the changes you suggested. The fix makes sense to me. 😃


Validate on blur for only custom validation rule

Hello,
I'm using vuetify and nuxt and i have an issue with custom validation on blur,
My code :
<v-text-field type="email" v-model="guest.email" name="email" label="Email" data-vv-as="email" data-vv-validate-on="blur" v-validate="'required|email|valid_email'" :error-messages="vErrors.collect('email')" ></v-text-field>
On blur all validations are triggered. I want that only valid_email (custom validation) be triggered on blur, and the others on submit (on validate form).

I think you could achieve a better experience for your users by using the new interaction modes, by setting the mode to eager your validation will be less frequent and less aggressive, but that only works for Validation Components, which I highly recommend over the directive.
You could only show the error for that rule if the field is blurred via the touched flag.
You could also debounce your email rule to prevent it from sending too many requests if that is what you are trying to avoid.
There is no way to do what you are asking at the moment and I don't believe I will be implementing it anytime soon. Especially if it can be handled in userland.


Incompatible dill versions in datasets 2.6.1

Describe the bug
datasets version 2.6.1 has a dependency on dill<0.3.6. This causes a conflict with dill>=0.3.6 used by multiprocess dependency in datasets 2.6.1
This issue is already fixed in https://github.com/huggingface/datasets/pull/5166/files, but not yet been released. Please release a new version of the datasets library to fix this.
Steps to reproduce the bug

Create requirements.in with only dependency being datasets (or datasets[s3])
Run pip-compile
The output is as follows:

Could not find a version that matches dill<0.3.6,>=0.3.6 (from datasets[s3]==2.6.1->-r requirements.in (line 1))
Tried: 0.2, 0.2, 0.2.1, 0.2.1, 0.2.2, 0.2.2, 0.2.3, 0.2.3, 0.2.4, 0.2.4, 0.2.5, 0.2.5, 0.2.6, 0.2.7, <IP_ADDRESS>, 0.2.8, <IP_ADDRESS>, <IP_ADDRESS>, 0.2.9, 0.3.0, 0.3.1, <IP_ADDRESS>, 0.3.2, 0.3.3, 0.3.3, 0.3.4, 0.3.4, 0.3.5, 0.3.5, <IP_ADDRESS>, <IP_ADDRESS>, 0.3.6, 0.3.6
Skipped pre-versions: 0.1a1, 0.2a1, 0.2a1, 0.2b1, 0.2b1
There are incompatible versions in the resolved dependencies:
  dill<0.3.6 (from datasets[s3]==2.6.1->-r requirements.in (line 1))
  dill>=0.3.6 (from multiprocess==0.70.14->datasets[s3]==2.6.1->-r requirements.in (line 1))

Expected behavior
pip-compile produces requirements.txt without any conflicts
Environment info
datasets version 2.6.1

Thanks for reporting, @vinaykakade.
We are discussing about making a release early this week.
Please note that in the meantime, in your specific case (as we also pointed out here: https://github.com/huggingface/datasets/issues/5162#issuecomment-1291720293), you can circumvent the issue by pinning multiprocess to 0.70.13 version (instead of using latest 0.70.14).
Duplicate of:

https://github.com/huggingface/datasets/issues/5162

You can also make pip-compile work by using the backtracking resolver (instead of the legacy one): https://pip-tools.readthedocs.io/en/latest/#a-note-on-resolvers
pip-compile --resolver=backtracking requirements.in

This resolver will automatically use multiprocess 0.70.13 version.


Revert "Merge pull request #3882 from zimingd/release-291-to-292-merge"

This reverts commit bf933a627a21e63f2d6843afc788a6c0d9295760, reversing
changes made to e498f6f791d472d2523d328ea3ecdb5a662c9b11.

Undo the revert of PLFM-5613 on the develop branch because the develop branch has additional commits checked in that relies on the code committed in PLFM-5613. Next step is to change the code in PLFM-5613 to accept base64 MD5s


Modify zfp source

[Added a zfp source library with a modification: variable "type" is changed to variable "_type",
to see if this change can help zfp binding passing the AppVeyor tests]
TODO:

[x ] Unit tests and/or doctests in docstrings
[x ] tox -e py37 passes locally
[x ] tox -e py27 passes locally
[x ] Docstrings and API docs for any new/modified user-facing classes and functions
[x ] Changes documented in docs/release.rst
[x ] tox -e docs passes locally
[ ] AppVeyor and Travis CI passes
[x ] Test coverage to 100% (Coveralls passes)

Sure, I will look into those conflicts.
On Wed, Mar 4, 2020 at 1:59 PM Ryan Abernathey<EMAIL_ADDRESS>wrote:

@halehawk https://github.com/halehawk just stopped by the Pangeo
telecon and expressed her desire to revive this work.
@jakirkham https://github.com/jakirkham - can you give us some idea
about your thoughts on this PR? It appears that the main problem is the
windows test failure. Any ideas how to resolve this?
Also, appears that the PR has gone stale, but the conflicts should be easy
to resolve. @halehawk https://github.com/halehawk - you could do this
now if you wanted.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zarr-developers/numcodecs/pull/164?email_source=notifications&email_token=ACAPEFEDPVUD4BVWJLKYOQLRF26KBA5CNFSM4GPQL5X2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEN2HZII#issuecomment-594836641,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACAPEFG3JLGRGY3QYPNV2XDRF26KBANCNFSM4GPQL5XQ
.

Sorry I very rarely use Windows and am a bit swamped atm. 😞

Maybe just skip Windows?

The other thing unclear to me about this PR is whether the submodule has been done correctly. It looks like 148 files have been added to this repo, i.e. all of the source files for zfp. Is that how it should look?

I can remove the zfp source codes. I added that for debugging purposes.
On Wed, Mar 4, 2020 at 3:44 PM Ryan Abernathey<EMAIL_ADDRESS>wrote:

The other thing unclear to me about this PR is whether the submodule has
been done correctly. It looks like 148 files have been added to this repo,
i.e. all of the source files for zfp. Is that how it should look?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zarr-developers/numcodecs/pull/164?email_source=notifications&email_token=ACAPEFANKIGC3GC2I6CPV73RF3KVXA5CNFSM4GPQL5X2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEN2Y6UQ#issuecomment-594906962,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACAPEFATUISD2X3LM6IZZO3RF3KVXANCNFSM4GPQL5XQ
.

I didn't see zfp source code from my fork repo. How to check zfp submodule?
On Wed, Mar 4, 2020 at 3:46 PM Haiying Xu<EMAIL_ADDRESS>wrote:

I can remove the zfp source codes. I added that for debugging purposes.
On Wed, Mar 4, 2020 at 3:44 PM Ryan Abernathey<EMAIL_ADDRESS>wrote:

The other thing unclear to me about this PR is whether the submodule has
been done correctly. It looks like 148 files have been added to this repo,
i.e. all of the source files for zfp. Is that how it should look?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zarr-developers/numcodecs/pull/164?email_source=notifications&email_token=ACAPEFANKIGC3GC2I6CPV73RF3KVXA5CNFSM4GPQL5X2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEN2Y6UQ#issuecomment-594906962,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACAPEFATUISD2X3LM6IZZO3RF3KVXANCNFSM4GPQL5XQ
.

I can't speak for the state of your local branches, but branch this PR comes from (halehawk:modify_zfp_source) definitely has those files in it: https://github.com/halehawk/numcodecs/tree/modify_zfp_source/zfp-0.5.4


Exceeding api’s quota.

The tools goes beyond the api limit for the ones that has a low quota, especially for the ones that are free.
Suggestion: If possible lowering the quota so that it allows api with a quota limit.

The tools goes beyond the api limit for the ones that has a low quota, especially for the ones that are free.
Suggestion: If possible lowering the quota so that it allows api with a quota limit.

I will change the provider that all of us can use a free api and run the model.

Change from OpenAI to Groq for free tier api usage


Type error in the interface ReceiptValidationResponse

Please use Discussion board if you want get some help out of it. Please report issue if there is a bug.

Version of react-native-iap
6.2.0
Version of react-native
0.64.2
Platforms you faced the error (IOS or Android or both?)
iOS
Expected behavior
The latest_receipt_info property of the interface ReceiptValidationResponse (used for validating app store receipts) should be an array as described in the official documentation of the receipt response. In this case I would expect a type like Record<string, unknown>[].
Actual behavior
The type of latest_receipt_info property is described as Record<string, unknown> which as mentioned above is incorrect.
Tested environment (Emulator? Real Device?)
Both Emulator and Real Device.
Steps to reproduce the behavior

Try to implement simple receipt validation using the validateReceiptIos method of IAP
Try to use the latest_receipt_info property in the resolved promise  as an array
You should get a type error since the currently defined type of the prop is not an array

Hello @hardmaster92, Looking at the documentation for that type: https://github.com/dooboolab/react-native-iap/blob/master/src/types/apple.ts#L203-L205 it looks like it's dependent on the iOS version. I don't know if this could be a problem for backward compatibility. Let me know of your thoughs

Hello @hardmaster92, Looking at the documentation for that type: https://github.com/dooboolab/react-native-iap/blob/master/src/types/apple.ts#L203-L205 it looks like it's dependent on the iOS version. I don't know if this could be a problem for backward compatibility. Let me know of your thoughs

If you want to support iOS 6 style receipts then the only solution that I suggest is using a union type so it would become Record<string, unknown> | Record<string, unknown>[] and then the developers could verify OS versions and cast it as desired

I think it's safe to say that iOS 6 is no longer used :)  Here is the fix: https://github.com/dooboolab/react-native-iap/pull/1402


Allow interaction with sites having invalid SSL/TLS certificate

Using chromeless with sites having an invalid TLS cert (self-signed, etc.) is not possible as chrome/chromium refuses to load them, and there are currently no commandline flags to override this behavior.

This seems possible via CDP (security domain - see https://chromedevtools.github.io/devtools-protocol/tot/Security/). https://github.com/cyrus-and/chrome-remote-interface/wiki/Bypass-certificate-errors-("Your-connection-is-not-private") has an example

I would love to see this implemented as well.

Yeah, I could use it too.  (right now, in fact 😞)

Chrome 64 can be implemented as @r0p0s3c mentioned with example
latest version has new interface setIgnoreCertificateErrors
shall we take compatibility into consideration?

Old version CDP can be implement as the [example](https://github.com/cyrus-and/chrome-remote-interface/wiki/Bypass-certificate-errors-("Your-connection-is-not-private") as @r0p0s3c mentioned.
The latest version of CDP has a new interface setIgnoreCertErrors

Is there any plan to have this merged any time soon? We use chromeless heavily but need to be able to screenshot sites with invalid certificates.


[Snyk] Security upgrade io.undertow:undertow-core from 2.2.24.Final to 2.3.8.Final

This PR was automatically created by Snyk using the credentials of a real user.![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)
Snyk has created this PR to fix 1 vulnerabilities in the maven dependencies of this project.
Snyk changed the following file(s):

tools/log4shellserver/pom.xml

Vulnerabilities that will be fixed with an upgrade:

Issue
Score
Upgrade

Uncontrolled Recursion SNYK-JAVA-IOUNDERTOW-7433720
  721
io.undertow:undertow-core:  2.2.24.Final -> 2.3.8.Final  No Known Exploit

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

 Following are detected SECRETS!! To be fixed !

{
"filename": "src/main/resources/application.properties",
"failure_list": [
{
"type": "filecontent",
"message": "Expected file to not contain base64 encoded texts such as: spring.datasource.password=eyJhbGciOiJIUzI1NiIs...",
"commits": [],
"severity": "high"
},
{
"type": "filecontent",
"message": "Potential secret pattern : #spring.datasource.password="hwgeytfwqefjweqhfwef"",
"commits": [
"c33fe3375f986fc5e70ccc603bff1e480ecd1666"
],
"severity": "low"
},
{
"type": "filecontent",
"message": "Potential secret pattern : spring.datasource.password=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiaWF0IjoxNTE2MjM5MDIyfQ.SflKxwRJSMeKKF2QT4fwpMeJf36POk6yJV_adQssw5c",
"commits": [
"c33fe3375f986fc5e70ccc603bff1e480ecd1666"
],
"severity": "low"
}
],
"warning_list": [],
"ignore_list": []
}

 Modified Files Coverage Summary

No coverage results for the modified files

 Overall Coverage Summary

            :green_circle: Instructions Coverage (31.77%)

            :red_circle: Branch Coverage (13.04%)


Payment Gateway template

Have an idea for a new HTML, CSS, or JS template? Describe it here.
Payment gateway template
Add a design file/ Screenshot of the template you want
List all the functionalities/ animations it should have(if any)

You are good to go , Please follow our templates guidelines template guidelines.

Hey, I couldn't understand how and where the css variables are to be added. If you don't mind, could you please help?

Check this example. And let me know if you still face any problems.

Hey @Akanksha-Sen you working on it? If you are facing any problem kindly let me know.


Fix PyTorchBackend TP vs DP inputs distribution across replicas and shards

fixes #217
@luzengxiangcn

Great Job! Thanks very much!


support link_shared access level

This PR supports the "link_shared" project access level. This is to be merged once the rest of the feature is feature-complete.

Perhaps we should reconsider whether we want to do this. There are things we want to do in the platform UI that we may not want to replicate here. For example, we are talking about requiring a password, and adding anough warnings etc. to the UI. I think it is totally fair to NOT show this option as part of a CLI deploy.


Move heapster jobs into their own project

This is a notice that the heapster jobs may begin failing at any time as we shut down jenkins - https://github.com/kubernetes/test-infra/issues/190

@piosz @loburm @x13n we need to migrate testing it looks like.  Can one of you take a look at this?

These jobs will start failing in the extremely near future

Please migrate them out of jenkins and into their own GCP project (if this hasn't happened already)

I need more context here. What jobs, where is this configured?

I need more context here. What jobs, where is this configured?

All the heapster jobs running in test-infra via jenkins
https://github.com/kubernetes/test-infra, the triggers are in prow/config.yaml and the rest of the config is in jobs/config.json and jenkins/job-configs.

Any jobs in jenkins/job-configs need to be moved to their own jenkins project or ideally migrated off of jenkins to prow. We are going to shut down the kubernetes jenkins and heapster/ cadvisor tests have been running on these clusters.

/cc @dashpole we discussed the cadvisor jobs and may look at heaspter as well if we have time.

With https://github.com/kubernetes/test-infra/pull/6359 merged, I guess this is done? Please reopen if not.


fix split on first colon so that passwords with colons are retained

maxsplit used so that creds only split once on colon delimiters and not on colons in a plaintext pw


set tcp nodelay for outgoing connections?

I was reading a blog post during my holiday and realized that we set tcp nodelay for client<->shotover connections but we dont set it for shotover <-> DB connections.
Should we?

Yes we should!!
On Thu, Jan 5, 2023 at 11:37 PM Lucas Kent @.***> wrote:

I was reading a blog post during my holiday and realized that we set tcp
nodelay for client<->shotover connections but we dont set it for shotover
<-> DB connections.
Should we?
—
Reply to this email directly, view it on GitHub
https://github.com/shotover/shotover-proxy/issues/985, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACG2BNZR5RPMTZJUJNC6MP3WQ2P5PANCNFSM6AAAAAATRZOARI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I wrote a benchmark that puts shotover as the bottleneck between the client and database.
I observed that:
Removing the client<->shotover nodelay halves our throughput.
Adding a shotover<->DB nodelay drops our throughput by about ~10%
So seems we should just leave it as is.
I am quite puzzled by these results though.

What does it do to latency though?
On Wed, Jan 25, 2023 at 8:06 PM Lucas Kent @.***> wrote:

I wrote a benchmark that puts shotover as the bottleneck between the
client and database.
I observed that:
Removing the client<->shotover nodelay halves our throughput.
Adding a shotover<->DB nodelay drops our throughput by about ~10%
So seems we should just leave it as is.
I am quite puzzled by these results though.
—
Reply to this email directly, view it on GitHub
https://github.com/shotover/shotover-proxy/issues/985#issuecomment-1403181251,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACG2BN5JP5RHUO5VYYRESADWUDGH3ANCNFSM6AAAAAATRZOARI
.
You are receiving this because you commented.Message ID:
@.***>

Tried enabling outgoing tcpnodelay again today, it seems to improve cassandra latency and regress redis latency.
I set a cap to operations per second to avoid the noise I have not yet eliminated from windsock.
redis (left nodelay=false, right nodelay=true)

cassandra (left nodealy=false, right nodelay=true)

We should retry this since the recent performance improvements

I got nagle'd on a hobby project just now and it gave me the insight I needed to know how to proceed here.
We wont see performance improvement on our current integration benchmarks because they are all stress tests.
We are stuffing as much data through 1 or 100 connections as possible.
This wont hit issues with tcp_nodelay enabled since constantly pushing more data in will force the packet out into the network and no delay will occur.
However if we set up a benchmark where we send 1 request every second on a single connection, the latency results of that benchmark should demonstrate tcp_nodelay causing us issues!

This morning I spent some time looking into this.
I set up a benchmark as I described above with 1 small request per second.
However this did not reproduce the issues of nagle's algorithm at all.
Whether i had tcp_nodelay enabled did not affect this benchmark.
And on closer analysis:

Each redis operation has a latency of ~0.6ms.
Each network hop between the 3 EC2 instances takes ~0.15ms.
There are 4 network hops that must be taken: client -> shotover -> redis -> shotover -> client
4 * 0.15 = 0.6 so we can reasonably conclude that all of our time is being taken up by the network hops.

Nagle's algorithm states that small packets should be delayed until we get an ACK back from the server.
So if nagle's was causing issues here we should be seeing 2 extra network hops of latency, giving us a latency of 0.9 ms
So all in all I'm really quite confused why we arent seeing any issues from nagle's algorithm being enabled. :confused:


github-copilot-cli: 0.1.33 -> 0.1.36

Description of changes
No changelog is provided, but the old version seems to be broken due to server-side changes.
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.


Could Not Create SSH Tunnel with command

This is what I get every time.
I am running my Laravel application in laradock, with nginx mysql.
I am trying to connect to a remote server on xxx.com.
All the required data is available. But I keep getting this error message.
So I tried to debug it, and when I put in the command when in the workspace (logged in on the linux machine) I can access SSH. It just does not give me an exit code, is that what you guys expect with return (bool)($return_var === 0);?
Can we force to give it an exit code?
This might be a super noob question, but I'm pretty new to docker AND opening ssh connections, so please excuse me for that.

Whenever I dump these two:
        exec($command, $this->output, $return_var);
        dump($this->output);
        dump($return_var);

I get this:

[]
1
[]
0
[]
1

But I keep getting this error message

What error message?

The error message that the package gives: Could Not Create SSH Tunnel with command /ssh command here/

I get the same error when trying to connect to a remote server.

Pull the latest version and open a new ticket if you continue to have issues.


Fix hyperkube docs

Kubernetes 1.3.0-alpha.5 requires to update the user guide for starting Hyperkube.
Sections:
"Running Kubernetes Locally via Docker"
"Portable Multi-Node Clusters"
Fixes https://github.com/kubernetes/kubernetes/issues/26943

Sorry, I guess the file "CNAME" leaked into the PR. I will remove it

Maybe hold this before we get https://github.com/kubernetes/kubernetes/issues/26943#issuecomment-224519722 solved?

@luxas What needs to be done for this to be merged?

@cheld Can you rebase and use the shared mount solution instead?

I am on holidays. I will do end if week

I deleted my doc fork. I don't think I can recover this PR. So I created a new one.


About the parameter: skip_pass

Thank you for your great work! I have observed that in vqgan model, self.loss function needs the skip_pass parameter:

However, in the loss function, the parameter seems to miss.

So now I get this error:

Thank you for your interest in our research!
We've just identified and fixed the code error.
It should work fine now. Thanks a lot.

Thank you very much!


Consistency Update for label and input elements for last lessons

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x] My changes do not use shortened URLs or affiliate links.

I do not believe this is necessary since the input is nested within the label element.

I do not believe this is necessary since the input is nested within the label element.

In the previous lessons it is said as best practice and the solutions include this so I thought it should be consistent with the former lessons. On the other hand, are you saying this is unnecessary since input is nested within label? If this is the case then previous lessons should be updated.

Which previous lessons specifically are you referring?

@RandellDawson https://learn.freecodecamp.org/responsive-web-design/basic-html-and-html5/create-a-set-of-checkboxes and https://learn.freecodecamp.org/responsive-web-design/basic-html-and-html5/create-a-set-of-radio-buttons mention


Most of the builtins are probably BROKEN!

Most of the builtins are probably broken! They don't await lib.call(...). So we probably end up having things happening in weird orders. Absolutely need to fix that..
(Copied from this: https://github.com/liam4/tlnccuwagnf/commit/30840710b0f4224507594f95cb63892114fecab9#commitcomment-17832221)

This is startling..
bad-call => (arg) {
  ifel(false, {}, { arg() });
};

bad-call({
  print('A');
  bad-call({
    print('B');
  });
});

bad-call({
  print('C');
  bad-call({
    print('D');
  });
});

A
C
C
D
D


chore: remove useless benchmark crate

Summary
The crates/bench is useless, this PR will remove it

Test Plan

Require Documentation?

[x] No
[ ] Yes, the corresponding rspack-website PR is __

need add a cli or a test for simple rust debug


Fails to build on i386 and armv7: the trait bound u64: ToUsize is not satisfied

error[E0277]: the trait bound `u64: ToUsize` is not satisfied
   --> /wrkdirs/usr/ports/devel/tarpaulin/work/tarpaulin-0.23.1/cargo-crates/llvm_profparser-0.3.0/src/instrumentation_profile/raw_profile.rs:308:35
    |
308 |             let (bytes, _) = take(header.padding_bytes_before_counters)(input)?;
    |                              ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `ToUsize` is not implemented for `u64`
    |                              |
    |                              required by a bound introduced by this call
    |
    = help: the following other types implement trait `ToUsize`:
              u16
              u32
              u8
              usize
note: required by a bound in `nom::bytes::complete::take`
   --> /wrkdirs/usr/ports/devel/tarpaulin/work/tarpaulin-0.23.1/cargo-crates/nom-7.1.1/src/bytes/complete.rs:408:6
    |
408 |   C: ToUsize,
    |      ^^^^^^^ required by this bound in `nom::bytes::complete::take`

For more information about this error, try `rustc --explain E0277`.
error: could not compile `llvm_profparser` due to previous error

rust-1.66.1
FreeBSD 13.1

I've just fixed this in latest master, will release a new version shortly


Removing my email from the CHANGELOG

This PR is to remove my email from the CHANGELOG and to replace it with my GitHub username.
When searching for my email via Google, the only hit is for the Covalent CHANGELOG. I've been getting a lot of spam in the last several days, so I would like to clean up this public trace of my email just in case. I have replaced my email with my GitHub username.
By default, it may be worth considering using usernames by default in the CHANGELOG. In any case, I'm aware that this is an automated process so this PR is only a band-aid solution. I wasn't sure where to adjust the automated procedure. Also, this PR will obviously fail for updating the CHANGELOG.

Thanks, @kessler-frost!


Some table rows have > right caret

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.50-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1729177128009089
Action Performed:

Open the workspace members page, Expenses page
Open categories and tags pages

Expected Result:
Should not have > at the right
Actual Result:
Right now some table rows use a right caret (>) at the end of the row, whereas others don't.
It's pretty obvious that we can tap any table row, so all of the carets from any table rows should be removed
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Standalone
[x] Android: HybridApp
[x] Android: mWeb Chrome
[x] iOS: Standalone
[x] iOS: HybridApp
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
![CleanShot 2024-10-17 at 17 03 20@2x](https://github.com/user-attachments/assets/9b5c4cdd-7dd5-4f50-9a7e-8b532a856381)
![CleanShot 2024-10-17 at 17 03 08@2x](https://github.com/user-attachments/assets/a4ebcbe3-4e56-4a33-b1db-d4ac434d54ba)
![CleanShot 2024-10-17 at 17 02 56@2x](https://github.com/user-attachments/assets/a647692d-8bda-4171-80c9-4736b0067d0a)
https://github.com/user-attachments/assets/d42ae5bd-416d-48e9-a943-60c0b80208db

View all open jobs on GitHub

Proposal
Please re-state the problem that we are trying to solve in this issue.
Some table rows have > right caret
What is the root cause of that problem?
Feature request
What changes do you think we should make in order to solve the problem?

We can remove this caret from here. If we want to remove caret from all pages
https://github.com/Expensify/App/blob/main/src/components/SelectionList/ListItemRightCaretWithLabel.tsx#L21-L27
What alternative solutions did you explore? (Optional)

Proposal Updated

Proposal
Please re-state the problem that we are trying to solve in this issue.
Some table rows have > right caret
What is the root cause of that problem?
Default value for shouldShowCaret is true here.
https://github.com/Expensify/App/blob/f8c7d43c320a82846dd729791bb1125a63d522d7/src/components/SelectionList/ListItemRightCaretWithLabel.tsx#L14
And we pass shouldShowCaret={false} on some pages while don't pass prop on few other pages.
What changes do you think we should make in order to solve the problem?
Option 1: If we want to keep this component for future use.
Let's change default value to false here and remove shouldShowCaret prop from following pages.
https://github.com/Expensify/App/blob/2c00cc58e713f0b8bb253d95e48b40503e7c1ddc/src/pages/workspace/reportFields/ReportFieldsListValuesPage.tsx#L102
https://github.com/Expensify/App/blob/2c00cc58e713f0b8bb253d95e48b40503e7c1ddc/src/pages/workspace/reportFields/WorkspaceReportFieldsPage.tsx#L121
Option 2: If we don't want to keep this component for future use then rename and redesign it.
function ListItemWithLabel({labelText}) {
    const styles = useThemeStyles();
    const theme = useTheme();

    return (
        <View style={styles.flexRow}>
            {!!labelText && <Text style={[styles.alignSelfCenter, styles.textSupporting, styles.pl2, styles.label]}>{labelText}</Text>}
         </View>
    );
}

and replace ListItemRightCaretWithLabel with new ListItemWithLabel component throughout.
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

sounds good to me! Let's keep the flexibility for the future.

PR is ready for review.
cc. @fedirjh

@fedirjh can you please complete the checklist?

@fedirjh role C+ requires payment through NewDot Manual Requests - Due $250
@ChavdaSachin role Contributor requires payment via Upworks - Paid $250


fix(blueprint): simplify actions boilerplate

Reduce the boilerplate surrounding adding actions.   with this patch,  you only need to add actions in the module, not in the container.
Updated variable name to better reflect redux naming.   see: https://github.com/davezuko/react-redux-starter-kit/issues/845#issuecomment-223837496

[Current coverage][cc-pull] is 70.58%

Merging [#936][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master       #936   diff @@
==========================================
  Files            15         15
  Lines            85         85
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits             60         60
  Misses           25         25
  Partials          0          0

Powered by Codecov. Last updated by [02e872b...f95dfe0][cc-compare]
[cc-base-branch]: https://codecov.io/gh/davezuko/react-redux-starter-kit/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/davezuko/react-redux-starter-kit/compare/02e872b6ec8245038da4e3c13a9a598dd5c56b38...f95dfe03e55542cc843760cb6b617f2f6393651d?src=pr
[cc-pull]: https://codecov.io/gh/davezuko/react-redux-starter-kit/pull/936?src=pr

Blueprints are being removed in an effort to simplify this project. I appreciate the PR, however. Thank you for your contribution!


Building the pgmq extension on windows

Hi,
is there any guide to get the pgmq postgres extension build on windows.
I see that there is a pgmq-extension directory and there are several .sql files in that and a pgmq.control file but no .dll that I could use on windows.
I see that there a MakeFile but not sure if that would build on windows, I guess you need a MakeFile.win to get it build on windows.

@mercurial-moon - there are no shared objects in the postgres extension. And we added a guide for windows installation. Can you take a look and reopen this issue if it does not work for you?


role manager should use serviceClass, not serviceShortId

ServiceClass is more stable, requires less spec knowledge. Since this change impacts a lot of code you are currently working on, I'm letting you fix that one.

I really don't see the point of doing this, unless we don't guarantee that shortIds are not unique.

shortId requires access to the specification, which serviceClass requires zero knowledge. Service class is also easier to use with SRV_* constants generated by the spec tool.

Fixed in

fixed


It doesn't do anything

Love the C# minimal API, but yours doesnt do anything lol

Actually I was able to TODO my whole life and organize all my problems.
Thanks Mike!

Thanks for checking it out pablo!


Use java 19 everywhere

Type of change

Enhancement / new feature

Description
Use java 19 as target and language level.
Additional Context
Software currency. We know there is some performance issue with netty 4 and JDK 17, this PR is to test the waters and see if there is anything that leaps out in our performance benchmark.

/perf

/perf

Results from perf test:
Possible performance regression was detected for benchmark 'kafka producer perf test Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite
Current: d096dab2d21cc5195df06c7b25188618213a2cbc
Previous: d331499423b49effe0e98c413319f1665407f8b6
Ratio

AVG Latency
172.09 ms
10.5 ms
16.39

95th Latency
671 ms
4 ms
167.75

99th Latency
804 ms
479 ms
1.68

What JDK were the perf tests run with? Was that JDK 19?

What JDK were the perf tests run with? Was that JDK 19?

Yep, 19 zulu.

/perf

I ran some basic perf tests as laid out in the benchmarking.md locally to make sure they were run on same hardware. I also ran with a slight variation using a fixed message from file instead of random data.
Randomised 1024 bytes messages from the kafka producer test client
 bin/kafka-producer-perf-test.sh \
    --topic perf-test \
    --throughput -1 \
    --num-records 10000000 \
    --record-size 1024 \
    --producer-props acks=all bootstrap.servers=localhost:9192

case
records/sec
avg latency
max latency
50th
95th
99th
99.9th

direct to kafka
85822
1.74ms
232.00 ms
0 ms
1ms
50ms
191ms

java 11 runtime at proxy
86772
2.20 ms
469.00 ms
0ms
1ms
64ms
223ms

java 19 runtime at proxy
87765
2.54 ms
252.00 ms
0 ms
1 ms
99 ms
217 ms

Fixed 1024 byte messages from the kafka producer test client
with open("out", "w") as f:
  f.write("a" * 1024)

bin/kafka-producer-perf-test.sh \
    --topic perf-test \
    --throughput -1 \
    --num-records 10000000 \
    --producer-props acks=all bootstrap.servers=localhost:9192 \
    --payload-delimiter , \
    --payload-file out

case
records/sec
avg latency
max latency
50th
95th
99th
99.9th

direct to kafka
219178
138.88 ms
396.00 ms
130 ms
171 ms
376 ms
392 ms

java 11 runtime at proxy
202486
150.34 ms
464.00 ms
142 ms
174 ms
396 ms
453 ms

java 19 runtime at proxy
212670
142.78 ms
403.00 ms
135 ms
180 ms
367 ms
396 ms

machine specs:
Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz
Dell XPS


Fix Headings for database comparison in FAQ

Floor and Firebase were H2 headings when I think they should have been H3 to fall under "How does drift compare to X?"
Thanks for all your hard work on drift! Very useful and much appreciated! :)

Thanks!


Fix parsing of comment on first line

I came across a bug in Cursor that made parsing of comments on the first line in a file not work.

Hi @oddbjornkvalsund , thanks for your contribution, I'll take a look at it ASAP this weekend! 👍

@oddbjornkvalsund I finally fixed this issue in #19 using your PR as a basis, but an extra fix was necessary and I wanted to redo the tests. So I'm closing this one unmerged but with my sincere thanks! :slightly_smiling_face:


[feat] chromium instead of webkit

Describe the problem
Performance slow
Describe the solution you'd like
Chromium
Alternatives considered
WebKit newer versions
Additional context
https://github.com/tauri-apps/tauri/issues/5761

Thanks for the request. There are no short term plans. Long term we're likely looking into cef (and maybe webview2 if Microsoft ever ports it to Linux). qtwebengine is completely off the table rn: https://github.com/tauri-apps/tauri/issues/4554 - that issue also mentions servo which we're also interested in but it will probablyyy be pretty nieche.

Servo is back in active development so maybe there something there?

Chromium (left) vs tauri webkit (right) performance comparison in linux
https://github.com/tauri-apps/tauri/assets/4569866/ab38e1ac-16a7-4456-9dbd-ee0ce29a112a

Chromium (left) vs tauri webkit (right) performance comparison in linux
simplescreenrecorder-2023-08-06_15.06.35.mp4

Yikes, still hoping for Servo eventually. I mean Servo can run cookie clicker now! (thats something)

have migrated my app to https://github.com/webui-dev/webui which injects my app into user machine browser and implements a protocol which allows my app running in user browser to communicate with my app deno backend, perhaps similar approach can be adopted for tauri

https://github.com/webui-dev/webui

and it works with tauri bundler, here example https://github.com/7flash/galaxy-desktop-app/blob/main/build.ts

Recent HN post about webui brings me here. It would be very cool if tauri also support these approach!

Recent HN post about webui brings me here. It would be very cool if tauri also support these approach!

You can achieve similar results by spawning Chrome instance directly from Deno server like demonstrated here: https://github.com/galaxydo/deno-chrome-app


Also add "processing" as an authz.status

I use this cookbook and i use the tests in this cookbook to check if everything is working.
I noticed that the cookbook was still working in production, but not on my test environments, and everything points to pebble.
The error is:
       acme_certificate[le-ssl.defaultacc1.example.com] (xplose-nginx::proxy line 38) had an error: RuntimeError: ruby_block[create certificate for le-ssl.defaultacc1.example.com] (xplose-nginx::proxy line 110) had an error: RuntimeError: [le-ssl.defaultacc1.example.com] Validation failed, unable to request certificate, Errors: [{url: https://<IP_ADDRESS>:14000/chalZ/wLdHSb7os93pSoqao6Iosof_xvjSbkPz1xgCz3x7kHQ, status: processing, error: } ]

It looks like the chef-acme cookbook doesn't support the processing status. Not sure if there are other extra changes needed, but i could fix my local development by just adding the processing status to the validation check.
Pebble introduced "processing" as a new response:  https://github.com/letsencrypt/pebble/pull/382

Thanks for the changes!
Will run the tests and release an update in the next few days


Modifying fqdn in an existing TunnelBinding does not clean up DNS records

DNS deletion is only executed in the finalizer.

Yes, that is correct. I could not think of a way to do that since the operator does not receive the diff of what has been modified.
We could check the current config and look at what changed, or mark the DNS entries with some unique operator ID and clean up everything when the binding is deleted, but I did not feel that was the most optimal solution. I will keep this issue open to track and find a proper solution. Do let me know if you have any ideas.

Given the flakey behavior and the ability to proxy star records, I would definitely prefer to disable Cloudflare API integration completely. The ability to programmatically manage the cloudflared configuration via CRDs is still very useful for us. Is there a timeline for #57?

That is a good approach. I will work on that, should be done soon and straightforward to complete that as a conditional check before calling the APIs.

@Quantum64 #71 is merged.


Error 0x80004005 when trying to save metadata

I am using File Metadata 1.2 x64 with Windows 7 Professional. The program seems to work fine but when trying to save metadata for a file (.txt, .zip, .dwg, etc) I get the 0x80004005. I tried to set full rights to the folder and the file in question (NTFS drive), with no success - can't save the metadata. What is the issue?
This work item was migrated from CodePlex
CodePlex work item ID: '9500'
Vote count: '2'

[Dijji@28/01/2015]
That error code is one of the most generic there is: its symbolic name is E_FAIL, i.e. it didn't work.  Still, it does indicate that the problem probably isn't to do with access privileges. Assuming that you're exporting the metadata from Explorer, you should be seeing a message box at the time of the failure. What does it say?

[UnknownUser@07/03/2015]

[codeplexmark@07/03/2015]
Having the same issue. Could it be that we need to install both x86 and x64 on a 64bit system ? (win7 x64 Ulti OS)

[codeplexmark@07/03/2015]
Nervermind, A simple reboot did the trick (restarting explorer process only didn't do it, I needed to reboot system).
Great tool

[Dijji@07/03/2015]
Wonderful.  Yes, these errors can occur when an extension is newly set up, because of Explorer caching.  See also http://filemeta.codeplex.com/discussions/447196
Dijji

[UnknownUser@08/06/2015]

Issue closed by Dijji with comment
Closing as the issue just seems to be the well-known edge effects that occur when File Meta support is switched on for an extension
Reason closed
Fixed


more tests for html report

more tests for the html report.

@simon3z it doesn't say anything:
gofmt -d pkg/inspector/image-inspector_test.go

is empty
This was existing in other parts of the file before.


copr: optimize ChunkedVecSized performance

Development Task
https://github.com/tikv/tikv/pull/8503 adds benchmark for structures modified in Chunk-based Computing RFC. The result shows that ChunkedVecSized<T> is 2x slower than original Vec<Option<T>>. We should figure out what caused such regression, and optimize performance of ChunkedVecSized.

@breeswish @TennyZhuang

[ ] benchmark for Vec<Option<T>> + Bitmap
Regression => optimize BitVec
No regression => optimize ChunkedVecSized

It seems that BitVec push is very slow. We may optimize this case.

Maybe we can have a benchmark again, comparing the latest optimization vs rust vec push?

Maybe we can have a benchmark again, comparing the latest optimization vs rust vec push?

@vn-ki got another idea on optimizing this. We could assume all bits are zero (or 1) on initialization, and we don't need to set one bit if we need to push false (or true) into the BitVec. I think we could benchmark performance after we have implemented all possible optimizations.

I'll get to this on Monday.


Minor fixes to Exporting tutorial, including example of PNG output

There were still some confusing and outdated bits.  The number of cells might have changed, which could change the output, but the rendered images should not have changed.
Provides further fixes for issue #468.

Ready to merge, as far as I know.

Looks good, thanks for making it consistent!

Ok. This is a good chance to show how the website building system works.
@jbednar

Click on 'Show all checks' next to 'All checks have passed'
Click on 'Details' next to s3-reference-data-cache (this name should be improved tbh).
Click on 'Update website' and follow it on buildbot.holoviews.org:8010. Once done, build.holoviews.org will be updated with the changes.

This is a lot easier than before though it could do with some improving (e.g names, more info on the webpage etc).

Okay, well since it's just text changes there's probably no need to rebuild the website in this case. I'll go ahead and merge.

Ok..nevermind.
@jbednar It would be good if you could try to follow those instructions the next time you have a chance to update the website or notebooks...

Ok.  So the idea is that these fixes will be seen the next time the website is changed by something else?

Ok. So the idea is that these fixes will be seen the next time the website is changed by something else?

Correct. Either someone build the website for a PR and build.holoviews.org is updated or you wait till the nightly and the changes appear on dev.holoviews.org.


Change opening datasets to use Intake plugins

Changes the method of opening datasets from using quest_io_plugins, to using the intake library (https://github.com/ContinuumIO/intake). Requires the intake-xarray plugin (https://github.com/ContinuumIO/intake-xarray) for reading rasters, and the intake_questhdf5 plugin (https://github.com/Aquaveo/intake_questhdf5) for reading hdf5 files (both XY and timeseries).
The local metadata db is changed so that there is an 'intake_plugin' and 'intake_args' fields for the dataset, which gives the appropriate plugin (ex: 'rasterio' from intake-xarray, 'quest_xyHdf5' or 'quest_timeseries_hdf5' from intake-questhdf5), along with the necessary arguments needed to use that plugin (ex: path, chunks, etc). The intake registry will give a list of plugins installed.
This only replaces opening a dataset, and does nothing for the visualization or output capability of the quest io plugins.

Can I help at all in this process?

Can I help at all in this process?

@martindurant thanks for offering to help with this. I am working to release a few bug fixes before integrating this PR in, so I have not yet had time to review it. I would be interested in you reviewing what @douggallup has done with using Intake in Quest and offer any suggestions you may have.


bug(gui-client/windows): GUI bail-out Couldn't connect to named pipe server at {path}\n    1: All pipe instances are busy.

This is documented in the user guide as a known issue. When this is closed, ensure it's removed from the user guide.
Describe the bug

The GUI is bailing out
The error message is wrong
It's not showing any error dialog even though an error happened, this is confusing to users
 Restart-Service -Name FirezoneClientIpcService fails with Error 1061: The service cannot accept control messages at this time.

To Reproduce

Open the resource-constrained test VM
Run the GUI and sign in
Close the GUI and immediately try to re-open it
The GUI will run for a bit and then bail out

Sometimes the IPC service even somehow gets into a state where no GUI is running and it still won't accept a GUI connection.
I replicated this synthetically on a dev machine like this:

Run the GUI normally and sign in so the computer has a token
Stop the GUI and IPC service
Re-compile the program to comment out the deep link server, which also provides single-instance for the GUI
Run a GUI instance and let it connect
Run a 2nd GUI instance. The second instance will throw this error.

Expected behavior

Expect the GUI to work if the IPC service is up
Expect the IPC service to always be up (not sure if it's hung or what, #5450 maybe related?)
Expect error messages to have correct formatting (#5445 will fix)
Expect a dialog if the GUI catches an error and bails out without crashing (#5454 will fix)
Expect Windows to be able to stop / restart the IPC service

Screenshots / Logs
GUI
{"time":"2024-06-19T16:56:00.9481957Z","target":"firezone_gui_client::client::auth","logging.googleapis.com/sourceLocation":{"file":"gui-client\\src-tauri\\src\\client\\auth.rs","line":"109"},"severity":"INFO","message":"Reloaded token from disk, starting in signed-in state."}
{"time":"2024-06-19T16:56:00.9484499Z","target":"firezone_gui_client::client::gui","logging.googleapis.com/sourceLocation":{"file":"gui-client\\src-tauri\\src\\client\\gui.rs","line":"466"},"severity":"INFO","apiUrl":"wss://api.firez.one/","message":"Starting connlib..."}
{"time":"2024-06-19T16:56:00.9484666Z","target":"firezone_gui_client::client::ipc","logging.googleapis.com/sourceLocation":{"file":"gui-client\\src-tauri\\src\\client\\ipc.rs","line":"91"},"severity":"INFO","clientPid":4596,"message":"Connecting to IPC service..."}
{"time":"2024-06-19T16:56:00.9485194Z","target":"firezone_gui_client::client::gui","logging.googleapis.com/sourceLocation":{"file":"gui-client\\src-tauri\\src\\client\\gui.rs","line":"235"},"severity":"ERROR","error":"Failed to restart session during app start\n\nCaused by:\n    0: Couldn't connect to named pipe server at `{path}`\n    1: All pipe instances are busy. (os error 231)","message":"run_controller returned an error"}
{"time":"2024-06-19T16:56:00.948641Z","target":"firezone_gui_client::client::gui","logging.googleapis.com/sourceLocation":{"file":"gui-client\\src-tauri\\src\\client\\gui.rs","line":"241"},"severity":"INFO","exitCode":"1"}

IPC service shows nothing after 16:50Z, not sure if it's hung up or what.
Platform (please complete the following information)

Component (i.e. macOS client / Linux client / Gateway / Admin portal): Windows GUI Client
Firezone Version (e.g. 1.0.0 or N/A): 1.0.9 11d76c4
OS and version: (e.g. Ubuntu 22.04 or N/A): Windows Server 2022
Deployment method: (e.g. Docker / Systemd / App Store or N/A): MSI from Github https://github.com/firezone/firezone/releases/tag/gui-client-1.0.9

Additional context
Still can't open About while the GUI is starting because of #5311
Refs #5377
Hypotheses

(Replicated) If the IPC service hangs up somewhere and doesn't disconnect its end of the pipe, e.g. the GUI disconnects but the service hasn't touched the pipe and hasn't noticed yet, then the error can happen
(Replicated, less likely) If something causes the deep link server to misbehave, a 2nd instance of the GUI could start
(Didn't replicate) If the GUI doesn't release its end of the pipe cleanly, the server might not release its end immediately

I believe this can reproduced by starting the GUI with no Internet connection. Or perhaps leaving Firezone running when there's no Internet for extended time.
Logs
no-internet.zip

I'll try to replicate that but it shouldn't. Given this sequence:

Reboot the system to clean up any zombie service issues
IPC service auto-starts and waits for a connection
User starts GUI
GUI tries to connect to the IPC service

At that point nothing critical depends on Internet. The IPC service won't start connlib until after the GUI has connected

Ah I see. I didn't do much rebooting during my testing.
I wonder if #5355 causes a busy loop that prevents the IPC service from responding, causing the issue here.

Maybe. I'll see if flooding the IPC service with set_dns requests causes them to queue up.

I'll try this next:

Start the GUI and make sure Firezone connects
Change networks
Restart the GUI

Had it replicate yesterday, might have been on 144418f47. I can't get it to replicate now, even though I'm trying to use the exact same setup:

Windows 11 dev laptop
USB-C dock for Ethernet
Swapping between Ethernet and Wi-Fi while the Client is signed in
Pinging github.com (which resolves to <IP_ADDRESS>, which happens to be an address on the LAN I'm on, must be something odd the ISP does)

Just can't get it to replicate.

I'm fairly confident this is fixed. Have been testing it over the last couple days with no issues. Optimistically closing!


dict.update should return None, not self

In .bzl files, the expression dict(a=1).update(b=2) evaluates to {a: 1, b: 2} but according to
https://github.com/bazelbuild/starlark/blob/master/spec.md#dictupdate
it should return None.
Both Pythons and Starlark-in-Go return None:
$ python # 2 or 3

x = {}
x.update(k=1)
x
{'k': 1}

$ starlark  # in Go

x = {}
x.update(k=1)
x
{"k": 1}

The Java standalone interpreter gives a strange error --- I have no idea what it means:
% blaze-bin/third_party/bazel/src/main/java/com/google/devtools/skylark/Skylark

x = {}
x.update(k=1)
parameter 'other' has no default value, in method call update(int k) of 'dict'

Googlers: see L23 of dart_dev_ctx.bzl in cr/223363742 for a real-world example.

Thanks!
That's a bug in Bazel.

In .bzl files, the expression dict(a=1).update(b=2) evaluates to {a: 1,
b: 2}

How does it do that? The bug is that dict.update doesn't take entries as
**kargs, so shouldn't that fail as per the example you gave?
On Thu, Nov 29, 2018 at 6:44 PM Laurent Le Brun<EMAIL_ADDRESS>wrote:

Thanks!
That's a bug in Bazel.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/starlark/issues/18#issuecomment-443036171,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABP1phtFT0XxLPhigdLCTycR2bje5RHzks5u0HFlgaJpZM4Y6uHs
.

Error message is bad, but the .update() method doesn't accept keyword arguments: https://docs.bazel.build/versions/master/skylark/lib/dict.html#update
If you do: x.update({"k": 1}), you'll see that update() returns None as expected.
cr/223363742 boils down to:
SomeInfo = provider(
    fields = {
        "...": "...",
    }.update(other_fields),

This is confusing, because update returns None. In other words, the dictionary is created, modified and thrown away.

make the Java impl and its doc match what the spec doc says

Right. Good enough, it's just a new feature and not a breaking change.
In the future, we can indeed extend the linter to catch this kind of things. Right now, we focus on the deprecated features, and help users migrate their code.

Fixed in Bazel