"java.lang.IllegalStateException: zip file closed" in multithreading execution

We have a Gauge project with step implemenations in an external JAR file located in the libs/ directory and execute the specs in parallel.
Expected behavior
The specs should run successfully in parallel with the following properties set:
enable_multithreading=true
package_to_scan=our.steps.directory

Actual behavior
The spec execution fails with the following exception:
Error ----------------------------------

[java]
Error in thread 19
zip file closed
java.lang.IllegalStateException: zip file closed
	at java.base/java.util.zip.ZipFile.ensureOpen(ZipFile.java:915)
	at java.base/java.util.zip.ZipFile$ZipEntryIterator.next(ZipFile.java:525)
	at java.base/java.util.zip.ZipFile$ZipEntryIterator.nextElement(ZipFile.java:518)
	at java.base/java.util.zip.ZipFile$ZipEntryIterator.nextElement(ZipFile.java:494)
	at org.reflections.vfs.ZipDir$1$1.computeNext(ZipDir.java:31)
	at org.reflections.vfs.ZipDir$1$1.computeNext(ZipDir.java:26)
	at com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:141)
	at com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:136)
	at org.reflections.Reflections.scan(Reflections.java:243)
	at org.reflections.Reflections.scan(Reflections.java:202)
	at org.reflections.Reflections.<init>(Reflections.java:123)
	at com.thoughtworks.gauge.execution.parameters.parsers.base.ParameterParsingChain.createReflections(ParameterParsingChain.java:47)
	at com.thoughtworks.gauge.execution.parameters.parsers.base.ParameterParsingChain.<init>(ParameterParsingChain.java:33)
	at com.thoughtworks.gauge.connection.MessageProcessorFactory.initializeExecutionMessageProcessors(MessageProcessorFactory.java:112)
	at com.thoughtworks.gauge.connection.MessageProcessorFactory.getProcessor(MessageProcessorFactory.java:87)
	at com.thoughtworks.gauge.RunnerServiceHandler.lambda$initializeSpecDataStore$2(RunnerServiceHandler.java:76)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)

[java]
Error in thread 20
zip file closed
java.lang.IllegalStateException: zip file closed
	at java.base/java.util.zip.ZipFile.ensureOpen(ZipFile.java:915)
	at java.base/java.util.zip.ZipFile$ZipEntryIterator.next(ZipFile.java:525)
	at java.base/java.util.zip.ZipFile$ZipEntryIterator.nextElement(ZipFile.java:518)
	at java.base/java.util.zip.ZipFile$ZipEntryIterator.nextElement(ZipFile.java:494)
	at org.reflections.vfs.ZipDir$1$1.computeNext(ZipDir.java:31)
	at org.reflections.vfs.ZipDir$1$1.computeNext(ZipDir.java:26)
	at com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:141)
	at com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:136)
	at org.reflections.Reflections.scan(Reflections.java:243)
	at org.reflections.Reflections.scan(Reflections.java:202)
	at org.reflections.Reflections.<init>(Reflections.java:123)
	at com.thoughtworks.gauge.execution.parameters.parsers.base.ParameterParsingChain.createReflections(ParameterParsingChain.java:47)
	at com.thoughtworks.gauge.execution.parameters.parsers.base.ParameterParsingChain.<init>(ParameterParsingChain.java:33)
	at com.thoughtworks.gauge.connection.MessageProcessorFactory.initializeExecutionMessageProcessors(MessageProcessorFactory.java:112)
	at com.thoughtworks.gauge.connection.MessageProcessorFactory.getProcessor(MessageProcessorFactory.java:87)
	at com.thoughtworks.gauge.RunnerServiceHandler.lambda$initializeSpecDataStore$2(RunnerServiceHandler.java:76)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)

[Gauge]
java runner quit unexpectedly. Check logs for more details.
ErrorMessage: transport is closing

Steps to reproduce

Create gauge-java project
Place a JAR file with your step implementations in the libs/ directory
Set enable_multithreading=true and package_to_scan to your steps package
Run gauge specs in parallel (-p)

Gauge version
Gauge version: 1.1.1
Plugins
-------
html-report (4.0.10)
java (0.7.9)
json-report (0.3.3)
screenshot (0.0.1)
xml-report (0.2.3)

Hints
According to https://github.com/ronmamo/reflections/issues/81 this might be an multithreading issue with the Reflections library version 0.9.11 used by the gauge-java plugin.

@stefan-valtech I tried to replicate this but got no luck. The execution happened as expected.
I have created a repo with a sample project which I used to replicate. https://github.com/BugDiver/gauge-java-489
Could you please check if you could replicate the issue on this, you can modify the project accordingly

@BugDiver   I tried to replicate this bug too and got the same error as above. To reproduce the bug i had to add more specs, so gauge runs it with more than 2 threads. (I checked out your repo, duplicated the specs and ran it also with gauge run specs -p) Nevertheless, sometimes it ran without any problems.
If i run it with gauge run specs -p -n=2 the execution happens as expected.
According to https://github.com/ronmamo/reflections/issues/81 this, i also tried to compile and install the gauge-java plugin with the downgraded version of reflections as mentioned there. This worked fine for me.
Gauge version
Gauge version: 1.1.1
Commit Hash: 6e0d83f

Plugins
-------
html-report (4.0.12)
java (0.7.9)
json-report (0.3.3)
screenshot (0.0.1)
spectacle (0.1.4)
xml-report (0.2.3)

System
 Processor Name:	Quad-Core Intel Core i7
 Processor Speed:	2,5 GHz
 Number of Processors:	1
 Total Number of Cores:	4
 Hyper-Threading Technology:	Enabled

 System Version:	macOS 10.15.6

Believe this was fixed in #662


Asking about the max_time

Hi authors,
Could I ask for an explanation for the part
max_time = nn.Max(3)(cudnn.ReLU()(conv_layer))
Theoretically, Is it different than using a temporal maxpooling on conv_layer ? I am quite confused at this part, because when I tried to use temporal maxpooling on the whole output sequence, it gave me different result.
Thank you very much,

Hi, this part combines the nonlinearity ReLU with temporal maxpooling. Does this answer your question?

Hi, thanks.
I see that you apply the convolution, then reshape it to opt.num_feat_maps, opt.max_sent-kernels[i]+1, then take the max over the opt.max_sent-kernels[i]+1 dimension.
I wonder if the following operations are mathematically the same.

do convolution
conv_output = conv(nn.Reshape(1, opt.max_sent, opt.vec_size, true)(lookup)))

-then do activation + temporal max pooling
output = nn.TemporalMaxPooling(cudnn.ReLU()(conv_output))
That's what I intended to ask. Sorry for the confusion.

I looked into TemporalMaxPooling (this didn't exist at the time code was written, neither was nn.Squeeze). I think the following series of commands are equivalent:

do convolution:
conv_output = nn.Reshape(...)(conv(nn.Reshape(1, opt.max_sent, opt.vec_size, true)(lookup)))

This can also be implemented more simply by replacing the outer Reshape with Squeeze.
followed by either

max:
output = nn.Max(3)(cudnn.ReLU()(conv_output))

temporal maxpooling:
output = nn.Squeeze()(nn.TemporalMaxPooling(opt.max_sent - kernels[i] + 1)(nn.Transpose({2,3})(cudnn.ReLU()(conv_output))))

since TemporalMaxPooling takes an argument of the size of the pool.
Let me know if this makes sense.

Thanks so much Jeffreyling,
Now I see that the nn.Transpose is what that makes the difference in my original question. I feel pretty relieved now about that. However, I am not sure that I understand the role of Transpose, could you please explain that to me ?
Best regards, and happy Easter !!!

It's needed because nn.TemporalMaxPooling does pooling over the first dimension (in batch mode, that's dimension 2). We have to swap dimensions 2 and 3 of conv_output since the time dimension is 3. In this case, Max would probably be the simpler operation...
Hope that helps!


include(GNUInstallDirs)

I encountered the same issue as #324, and it turned out ${CMAKE_INSTALL_INCLUDEDIR} is empty during compilation.
By looking at CMake documentation, I discover that we forgot to include GNUInstallDirs. After adding the line include(GNUInstallDirs), everything works fine.
I'd also suggest to add make install into out github workflow so that we can check if installation is successful.

Adding make install seems reasonable to me as well

Sounds good! I'll make another PR to include "make install" in github workflow

Just add the make install to this PR. It will be all housekeeping related.

Added "make install" check and merging


fix: add last_challenged_at field to mfa factors

What kind of change does this PR introduce?
deprecates sent_at in favour of the last_challenged_at field on factors. We use this to calculate whether it's appropriate to allow for more SMS-es to be sent.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>8
Details

45 of 64 (70.31%)  changed or added relevant lines in 2 files are covered.
14 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.05%) to 58.284%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/models/factor.go
19
25
76.0%

internal/api/mfa.go
26
39
66.67%

Files with Coverage Reduction
New Missed Lines
%

internal/models/errors.go
2
45.59%

internal/models/factor.go
12
72.0%

Totals

Change from base Build<PHONE_NUMBER>0:
-0.05%

Covered Lines:
9192

Relevant Lines:
15771

💛  - Coveralls


Question create marker icon

Hi....
I've configured the map toolbar in order to allow adding a markers in the map.
I was able to change the default marker icon to a L.divIcon after pm:create event and it works fine, but I was wondering if it may be possible to override the default  marker icon displayed while the user is selecting the target position

Thanks and best regards...

I am sorry... I found it finally...
https://github.com/geoman-io/leaflet-geoman/issues/728


Why no universal selektor

Hi,
why have the normalize.css no universal selector with margin and padding 0?
I have at Chrome several times problems with selectors like  -webkit-padding-start: as example from Chrome.
Cheers

Normalise preserves useful defaults, and hence does not intrusively reset margin and padding execpt where it is considered useful. You may want to look at using a more heavy duty CSS reset if you need it for your use-case.

@janstieler See the README under 'What does it do' - https://github.com/necolas/normalize.css#what-does-it-do
One reset package that builds on normalize is suitcss-base

Thanks for the answers everyone

Hi,
Thanks for your answers. I thought the problem with the chrome browser css is falling under “… and common browser inconsistencies”.
@simonsmith thanks for the package link.
Cheers
PS: I don't understand why I got thumbs down.


Version 4.2.4 could not control the mouse pointer

BEFORE SUBMITTING YOUR ISSUE, PLEASE LOOK AT THE PINNED ISSUES AND USE THE SEARCH FUNCTION TO MAKE SURE IT IS NOT ALREADY REPORTED. ALWAYS COMMENT ON AN EXISTING ISSUE INSTEAD OF MAKING A NEW ONE.
Describe the issue
I only have one macOS 12 virtual machine and when I upgraded UTM to 4.2.4, I could not control the mouse pointer in the virtual machine, when I reverted back to the previous version (4.1.6) everything was back to normal
Configuration

UTM Version: 4.2.4
macOS Version: 13.3.1
Mac Chip (Intel, M1, ...): M1

Crash log
Debug log
Upload VM

We recently changed the mouse/trackpad device due to issues people had with double clicking. Curious if the issue persists if you reinstall a new vm?


ChatDecorator -> TextDecorator

This can decorate any text given a player. Outdated docs are removed, and we can pull them from git history if we ever need them.

Okay, fine, I guess I should've renamed this when commands got proper decoration.


Factor out getRosDistro

Public-Facing Changes
None.
Description
Robustified fetching of ROS_DISTRO env var.

@achim-k PTAL.

Closing this due to lack of activity from the last feedback. We are happy to re-visit if you pick this up at a later time.


Back to top button on homepage

Issue Type:

[x] Feature Request

Describe the feature
Add scroll top button on homepage.
Possible solution

Describe the solution you thought of.

Screenshots

If applicable, add screenshots to help explain your problem.

@jigar-sable you want to work on this ?

@arpit456jain yes assign me


Typos

fixing typos

Check out PR #890. I think we've been working on the same thing... We should merge one of those two first, and see what changes are left to be done.

After merging #890 ther are now conflicts with this one. @Juized are you able to resolve conflicts?

@Juized merged - thx.


Use alterKeyspace endpoint from management-api to make multi DC more seamless

https://github.com/datastax/management-api-for-apache-cassandra/pull/30 added some stuff we needed. Multi-DC has problems coming up with system_auth and the createRole firing in one of the datacenters with LOCAL_ONE.

@jimdickinson how does the operator currently configure replication for system_auth?


Newest release has error. See attached image.

When trying to load the newest release the following error occurs.

I confirm this. First of all, if you click on the release link you will see something weird:

This is broken:
<script src="https://cdnjs.cloudflare.com/ajax/libs/openseadragon/3.1.0/openseadragon.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/<EMAIL_ADDRESS>
However, this works:
<script src="https://cdnjs.cloudflare.com/ajax/libs/openseadragon/3.1.0/openseadragon.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/<EMAIL_ADDRESS>

@rsimon The library I used was the release in the screenshot that I downloaded and loaded. I use script tags and use the order that I used before which is openseadragon, annotorious, openseadragon-annotorious

Yikes - sorry for this. Now I remember... ;-) Yes, I managed to build & release v2.7.5 with a broken build config. I did fix the bug, and pushed v2.7.6 to the npm registry (and the CDN). But then forgot to publish a ZIP package on GitHub. (Lesson learned: never do this stuff late at night...)
So as an immediate fix: you can pull the latest version - which is actuall v2.7.6 now - from the CDN here:
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/<EMAIL_ADDRESS>
<!-- JS -->
<script src="https://cdn.jsdelivr.net/npm/<EMAIL_ADDRESS>
I'll roll a GitHub release for v2.7.6, too, unpublish the broken v2.7.5, and close the issue when that's done.
Cheers, thanks for reporting & sorry for the inconvenience!


Remove implicit, rename date to datetime, rename datatype to valuetype

What is the goal of this PR?
Synchronise with changes in Grakn Core (https://github.com/graknlabs/grakn/pull/5722) that remove implicit types, and also updates to no longer use date, but instead use datetime (including a protocol update). Finally, we also propagate the change from datatype to value in graql and datatype to valuetype in the client implementatino.
What are the changes implemented in this PR?

Bump protocol and verification
use new datetime terminology where it wasn't before
remove implicit, datatype (-> valuetype), and date (-> datetime)

Good point! @sorsaffari you'll have to keep these things in mind when you get around to upgrading to the newest client :)


chore: ignite9 updates

Description

Closes #37
Closes #101
Adds an archive section for recipes pertaining to Ignite v8 and below
Adds admonition (although the warning one seems to come up as danger cc @cdanwards - https://docusaurus.io/docs/next/markdown-features/admonitions) to warn user about older recipe
Updates several recipes for Ignite 9

Screenshots

I noticed there's a broken link in the Detox Intro recipe.
The recipe says about Detox that it's included by default in Ignite. Since it has been removed, I would suggest to just remove that line.
Alternatively, the admonition could be used to let the reader know it is outdated


Make memset_s consistent with Darwin.

Resolves issue#51.
In Swift 5.3, a warning is viewed on Linux because memset_s implemented in this module returns Void.
This PR let the function return the same type with Darwin.
Checklist

[x] I've run tests to see all new and existing tests pass
[x] I've followed the code style of the rest of the project
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary

Result:
No warnings are viewed while building.

@swift-server-bot test this please

Thanks very much!


Kubernetes v1.23 on AWS workload clusters

Kubernetes v1.23 on AWS workload clusters

Released with v18.0.0


What about GitFlow? Seem better fit.

Key Benefits
Parallel Development
One of the great things about GitFlow is that it makes parallel development very easy, by isolating new development from finished work. New development (such as features and non-emergency bug fixes) is done in feature branches, and is only merged back into main body of code when the developer(s) is happy that the code is ready for release.
Although interruptions are a BadThing(tm), if you are asked to switch from one task to another, all you need to do is commit your changes and then create a new feature branch for your new task. When that task is done, just checkout your original feature branch and you can continue where you left off.
Collaboration
Feature branches also make it easier for two or more developers to collaborate on the same feature, because each feature branch is a sandbox where the only changes are the changes necessary to get the new feature working. That makes it very easy to see and follow what each collaborator is doing.
Release Staging Area
As new development is completed, it gets merged back into the develop branch, which is a staging area for all completed features that haven’t yet been released. So when the next release is branched off of develop, it will automatically contain all of the new stuff that has been finished.
Support For Emergency Fixes
GitFlow supports hotfix branches - branches made from a tagged release. You can use these to make an emergency change, safe in the knowledge that the hotfix will only contain your emergency fix. There’s no risk that you’ll accidentally merge in new development at the same time.

Hello Jens, thank you for your input!
Can you specify what you are missing? This is very close to what we are doing. We have feature branches, our master is the proposed development branch, our release branch is the proposed master.


Client.headers['RETS-UA-Authorization'] after Client.login()

//version 1 (works with hackish fix)
let Client;
Client = new rets.Client(clientSettings);
Client.login()
    .then(()=>{
           //hackish fix
            var a1, retsUaAuth;
            if (Client.settings.userAgentPassword && Client.settings.sessionId) {
                a1 = crypto.createHash('md5').update([Client.settings.userAgent,
             Client.settings.userAgentPassword].join(":")).digest('hex');
                retsUaAuth = crypto.createHash('md5').update([a1, "", Client.settings.sessionId || "",
          Client.settings.version || Client.headers['RETS-Version']].join(":")).digest('hex');
                Client.headers['RETS-UA-Authorization'] = "Digest " + retsUaAuth;
            }
            return Client.search.query(resource, class_name, query, search_options)
        })
    .then(res =>{
        Client.logout()
    })

//version 2  (works fine):
rets.getAutoLogoutClient(clientSettings, function (client) {
    return client.search.query(resource, class_name,query, search_options)
        .then(function (searchData) {
        console.log(client.search.client.settings)
            console.log(searchData)
        });
    }).catch(function (errorInfo) {
        var error = errorInfo.error || errorInfo;
        console.log("   ERROR: issue encountered:");
        console.log('   '+(error.stack||error).replace(/\n/g, '\n   '));
});

I'm having an issue with SFAR where the RETS-UA-Authorization header is lost during subsequent queries after login, giving an unauthorized client password error. Whereas the second version of the code works fine and retains the header throughout secondary queries.

`//version 1
let Client;
Client = new rets.Client(clientSettings);
Client.login()
.then(()=>{
//hackish fix
var a1, retsUaAuth;
if (Client.settings.userAgentPassword && Client.settings.sessionId) {
a1 = crypto.createHash('md5').update([Client.settings.userAgent,
Client.settings.userAgentPassword].join(":")).digest('hex');
retsUaAuth = crypto.createHash('md5').update([a1, "", Client.settings.sessionId || "",
Client.settings.version || Client.headers['RETS-Version']].join(":")).digest('hex');
Client.headers['RETS-UA-Authorization'] = "Digest " + retsUaAuth;
}
return Client.search.query(resource, class_name, query, search_options)
})
.then(res =>{
Client.logout()
})
//version 2 :
rets.getAutoLogoutClient(clientSettings, function (client) {
return client.search.query(resource, class_name,query, search_options)
.then(function (searchData) {
console.log(client.search.client.settings)
console.log(searchData)
});
}).catch(function (errorInfo) {
var error = errorInfo.error || errorInfo;
console.log("   ERROR: issue encountered:");
console.log('   '+(error.stack||error).replace(/\n/g, '\n   '));
});`

The 'hackish' fix is necessary because the session id doesn't get set until after you login (The getAutoLogoutClient function handles that), so the RETS-UA-Authorization header has to be updated with that session ID after login.  It might be possible to incorporate that logic into an additional .then in the login function itself, which is probably a better way to do it than the way I implemented it, but that would have to be tested.

I will take a look at it and do some testing later today.

Good catch, this was a very straightforward change.  It's up on master, but I'm having some trouble with npm publish so I haven't cut version 5.0.3 yet.  I'll do that when I can figure out what the problem is.

It's possible the problem is on NPM's end (https://status.npmjs.org/), I'll try again later.

v5.0.3 is up now, it should fix this.

Thanks a lot, really helpful


chore: Prepare 3.7.0 release

Detail

Prepare 3.7.0 release

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: e3f2213822d0d3107769d1dbc474e77e95c27ab5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: e3f2213822d0d3107769d1dbc474e77e95c27ab5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: 81d44717f416ec3ed53ecc8b869b48902db3203f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Pre-defined RequestPreprocessors for everyday ViUR development

I want to have these features in ViUR core:
def closedSystem(path):
    """in a closed system the only allowed url is /. All other urls needs a active user session"""
    if path.startswith("vi/"):
        path = path[3:]
    elif path.startswith("json/"):
        path = path[5:]

    if path.startswith("_tasks/"):
        return path
    if path not in ["", "vi", "settings", "skey", "user/auth_googleaccount/login", "user/auth_userpassword/login"] and not current.session.get().get("user"):
        raise errors.Forbidden()
    return path

# for Vue Development
if conf["viur.instance.is_dev_server"]:
    conf["viur.security.enableCORP"] = "cross-origin"

    def preprocessRequestHandler(path):
        closedSystem(path)
        referer = current.request.get().request.referer
        if referer and referer in ["http://localhost:8081/", "http://localhost:8082/"]:
            referer = current.request.get().request.referer[:-1]
            current.request.get().response.headers["Access-Control-Allow-Origin"] = referer
        current.request.get().response.headers["Access-Control-Allow-Credentials"] = "true"
        return path
else:
    conf["viur.security.enableCOOP"] = "same-origin-allow-popups"

    def preprocessRequestHandler(path):
        closedSystem(path)
        return path

conf["viur.requestPreprocessor"] = preprocessRequestHandler

Built-in domain enforcement?


flattenGroupedObject.test failing for all connectors

select distinct commit{*}, count(*) from slamengine_commits where commit{*} like "http%" group by committer.login

Needs investigation into why it's failing. As it's failing for all connectors, it's probably a qscript bug.

Hmm, this actually seems like a relatively complicated query due to the grouped map flatten within the autojoin.

@wemrysi Looks like this is hitting the Both case, at the very least.

@djspiewak Nice, I've been looking for a good example for that.


Add a feature to initialize from an existing wgpu adapter/device/queue

Pull Request Template
Checklist

[x] Confirmed that run-checks all script has been executed.
[x] Made sure the book is up to date with changes in this PR.

Related Issues/PRs
Some Discord discussions: https://discord.com/channels/1038839012602941528/1229453567694209105/1230282427629441075
Changes
This is useful when interacting with other wgpu applications (eg. displaying a burn tensor as a texture in egui). The existing devices are keyed by the wgpu Device ID. Alternatively they could be keyed per adapter which would be more inline with other burn WgpuDevice's (one per adapter), but also there's no real inherent reason to.
This also involves making Queue into an Arc. Alternatively, this could give up ownership of the queue, but it's helpful to be able to synchronize burn operations and custom wgpu operations.
Nb: Even with this feature it's still tricky to say, copy a burn buffer to a wgpu texture, as there's no access to wgpu bindings in the public Burn API. I've got a feature for that locally but not sure what the best way is, might open an issue for it.
Testing
run-checks all, using this feature in some local development.

Just checking on this! If this doesn't seem like the way to go I'm very happy to consider other approaches to initializing from existing WGPU devices, or the larger goal of WGPU interop in general. Thanks again!


Added Delete Functionality

Added feature to delete a challenge.
Changes proposed in this pull request:

Host can now delete the desired challenge.

Link to live demo: http://pr-XXX-evalai.surge.sh

Trash button besides the Toggle-Star button could be seen below.

Codecov Report

Merging #100 into master will decrease coverage by 0.24%.
The diff coverage is 29.16%.

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   53.43%   53.19%   -0.25%
==========================================
  Files          55       55
  Lines        2358     2382      +24
  Branches      253      255       +2
==========================================
+ Hits         1260     1267       +7
- Misses       1023     1040      +17
  Partials       75       75

Impacted Files
Coverage Δ

src/app/services/challenge.service.ts
29.74% <17.64%> (-1.46%)
:arrow_down:

src/app/services/endpoints.service.ts
65.62% <50%> (-0.51%)
:arrow_down:

...rc/app/components/challenge/challenge.component.ts
75% <60%> (-2.42%)
:arrow_down:

Impacted Files
Coverage Δ

src/app/services/challenge.service.ts
29.74% <17.64%> (-1.46%)
:arrow_down:

src/app/services/endpoints.service.ts
65.62% <50%> (-0.51%)
:arrow_down:

...rc/app/components/challenge/challenge.component.ts
75% <60%> (-2.42%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69ae0ff...40f5661. Read the comment docs.

Thanks for the reviews @Shekharrajak. @lunayach Can you please do the required changes. Let's get this merged 🎉

@Shekharrajak @RishabhJain2018  Could you see if this looks good?


TypeScript 4.x support

Hi, do you have a plan to support TypeScript 4.x?
Currently, when installing textlint-plugin-jsx, TypeScript 3 is installed. But I use TypeScript 4 in my project.
https://github.com/hata6502/textlint-plugin-jsx/blob/d1e0f47a4041c2739dba16b16c996923ccaac984/package.json#L24
Maybe, it seems nice to me to move typescript to peerDependencies like this:
{
  "peerDependencies": {
    "typescript": "3.x || 4.x"
  }
}

@hata6502 Thank you very much! 😄


fix training seq2seq

This was broken because pytorch-lightning tries to move the output of TransformerSeq2SeqTaskModule.collate to a device via pytorch_lightning.core.datamodule.LightningDataModule.transfer_batch_to_device that internally uses pytorch_lightning.utilities.apply_func.apply_to_collection. This method fails if any part of the input (arbitrary nested) is a frozen dataclass which is the case for our Annorations. To fix this, we simply remove the documents (and also metadata) from the batch since it is not used at all.
Notes:

To see the described behavior, #197 is necessary because otherwise apply_to_collection fails even earlier since it tries to iterate over the dataclass fields.
nox -p3.9 --session=tests_no_local_datasets passes except one test with external cause (this is fixed in #198).

I have to look into this in more detail. The problem is that collate may return arbitrary types, not just dicts tensors. For instance, GENRE (the entity linking method) will even return a function in collate that is then passed on to the model.

Sounds reasonable. Further information: https://pytorch-lightning.readthedocs.io/en/stable/extensions/datamodules.html#transfer-batch-to-device


Add support for v2 on sepolia

Fixes #400
Context
User reported issue trying to use SDK to query swap on sepolia
Replace this part of examples/swaps/swap.ts to test. (token's discord user was trying to swap)
    // User defined
    const rpcUrl = process.env.SEPOLIA_RPC_URL;
    const chainId = ChainId.SEPOLIA;
    const swapKind = SwapKind.GivenIn;
    const tokenIn = new Token(
        chainId,
        '0x8b80b78a377e9d40c599b0e2542e474c4440ddd2',
        18,
        'ZEEBU',
    );
    const tokenOut = new Token(
        chainId,
        '0x99205e5182c168216778e1d970a38dd59ee43f67',
        18,
        'ERC20Mint',
    );

Summary

Added the v2 vault address and BALANCER_QUERIES address to constants.ts

thanks guys! :)


XMemcached network layout exception: java.lang.OutOfMemoryError: Direct buffer memory

Hello,
We use memcached v2.4.6, and are currently getting the below error:
09-06-2020 09:36:34,934 ERROR MemcachedHandler:128 - XMemcached network layout exception: java.lang.OutOfMemoryError: Direct buffer memory
at java.nio.Bits.reserveMemory(Bits.java:694)
at java.nio.DirectByteBuffer.(DirectByteBuffer.java:123)
at java.nio.ByteBuffer.allocateDirect(ByteBuffer.java:311)
at sun.nio.ch.Util.getTemporaryDirectBuffer(Util.java:241)
at sun.nio.ch.IOUtil.read(IOUtil.java:195)
at sun.nio.ch.SocketChannelImpl.read(SocketChannelImpl.java:380)
at com.google.code.yanf4j.nio.impl.NioTCPSession.readFromBuffer(NioTCPSession.java:190)
at com.google.code.yanf4j.nio.impl.AbstractNioSession.onRead(AbstractNioSession.java:184)
at com.google.code.yanf4j.nio.impl.AbstractNioSession.onEvent(AbstractNioSession.java:324)
at com.google.code.yanf4j.nio.impl.SocketChannelController.dispatchReadEvent(SocketChannelController.java:54)
at com.google.code.yanf4j.nio.impl.NioController.onRead(NioController.java:150)
at com.google.code.yanf4j.nio.impl.Reactor.dispatchEvent(Reactor.java:310)
at com.google.code.yanf4j.nio.impl.Reactor.run(Reactor.java:177)
I reckon this might be similar to the issue in raised here, but I will appreciate specific insights on how to address this problem for this type of OOME - Direct buffer memory. And yes, we do use the xmemcached client as a singleton instance.
Thank you

It seems that you may have too many connections ,every connection will keep an read direct buffer. You can increase the max direct buffer size or decrease the connection pool size.

It seems that you may have too many connections ,every connection will keep an read direct buffer. You can increase the max direct buffer size or decrease the connection pool size.


Memory Leak Fixes

Describe the bug
When reinitializing the Simulator repeatedly, e.g., in a Reinforcement Learning (RL) setting, memory growth can be observed. Please find different fixes below (this is not a Pull Request due to the last item in the list).
To reproduce

ReactionWheelStateEffector Memory Leak
In addition to issue #441, the destructor ReactionWheelStateEffector::~ReactionWheelStateEffector() in src/simulation/dynamics/reactionWheels/reactionWheelStateEffector.cpp uses free() on a data structure allocated with new. Additionally, it may be helpful to delete the elements of rwOutMsgs:

ReactionWheelStateEffector::~ReactionWheelStateEffector()
{
    for (long unsigned int c = 0; c < this->rwOutMsgs.size(); c++) {
        delete this->rwOutMsgs.at(c);
    }

    for (long unsigned int c = 0; c < this->ReactionWheelData.size(); c++) {
        delete this->ReactionWheelData.at(c);
    }
}

Missing Py_DECREF in SWIG Eigen Type Map
There are missing Py_DECREF in src/architecture/_GeneralModuleFiles/swig_eigen.i in the fragment checkPyObjectIsMatrixLike. The changes are annotated with new decrement.

%fragment("checkPyObjectIsMatrixLike", "header", fragment="getInputSize") {

/*
This method returns an empty optional only if the given input is like the template type T.
Otherwise, the returned optional contains a relevant error message.
The size of the input is compared to the expected size of T (where dynamically
sized matrix T allow any number of rows/columns). Moreover, an error is raised for
ragged nested sequences (rows with different numbers of elements).
*/
template<class T>
std::optional<std::string> checkPyObjectIsMatrixLike(PyObject *input)
{
    auto maybeSize = getInputSize(input);

    if (!maybeSize)
    {
        return "Input is not a sequence";
    }

    auto [numberRows, numberColumns] = maybeSize.value();

    if (T::RowsAtCompileTime != -1 && T::RowsAtCompileTime != numberRows)
    {
        std::string errorMsg = "Input does not have the correct number of rows. Expected "
            + std::to_string(T::RowsAtCompileTime) + " but found " + std::to_string(numberRows);
        return errorMsg;
    }

    if (T::ColsAtCompileTime != -1 && T::ColsAtCompileTime != numberColumns)
    {
        std::string errorMsg = "Input does not have the correct number of columns. Expected "
            + std::to_string(T::ColsAtCompileTime) + " but found " + std::to_string(numberColumns);
        return errorMsg;
    }

    for(Py_ssize_t row=0; row<numberRows; row++)
    {
        PyObject *rowPyObj = PySequence_GetItem(input, row);
        Py_ssize_t localNumberColumns = PySequence_Check(rowPyObj) ? PySequence_Length(rowPyObj) : 1;
        if (localNumberColumns != numberColumns)
        {
            Py_DECREF(rowPyObj); // new decrement
            return "All rows must be the same length! Row " + std::to_string(row) + " is not.";
        }
        Py_DECREF(rowPyObj); // new decrement
    }

    return {};
}
}

Check for  Msg disown()
It may be of interest to verify whether <type>Msg.this.disown() is necessary in:

src/utilities/fswSetupRW.py (writeConfigMessage(), rwConfigMsg.this.disown(), line 87)
src/utilities/simIncludeRW.py (getConfigMessage(self), rwConfigMsg.this.disown(), line 379)

Expected behavior
With these changes, memory growth became unnoticeable for us even after millions of iterations.

Howdy @KD-92 , thanks for the feedback.  Something to look at in more detail.  Regarding item 3., the reason we use disown() in the factory classes to ensure that the message memory is not released after being created in a sub-routine.  There are likely better ways to do this that avoids creating msg objects which never get released

@schaubh @KD-92 @juan-g-bonilla
I think the conflict between to disown() or not to disown() is related to #676 . Developing a proper fix for that bug would allow the lifetime of the msg objects to be properly handled, instead of having to choose between mistakenly garbage collected in some situations vs intentionally leaked in all situations.


fix(dataset): check if property exist before deleting

in Safari, when it is use strict, if the dataset property is removed in DOM
deleting it again will cause an error
closes #309

done :D @caridy

Great! Thank you 😄


Show, hide and remove items

I'm missing methods or properties for hiding, showing and removing items/item groups or parts like options of a select. I like to do this to react to hardware platforms (e.g. remove dropdown items related to health for Aplite) or hide and show options related to certain selections (e.g. hide date related options if none of the slots in a watchface is configured to show a date)

Hide items +1


fix Support fe log rollover size strategy

Proposed changes
Issue Number: close #xxx

Support fe log rollover size strategy, default use age strategy. cloud use size stragegy
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall


ci: use alias latest and minimum to represent xcode cmd tool version

Issue #

Description

add alias latest and minimum to represent xcode cmd tool version

General Checklist

[ ] Added new tests to cover change, if needed
[ ] Build succeeds with all target using Swift Package Manager
[ ] All unit tests pass
[ ] All integration tests pass
[ ] Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
[ ] Documentation update for the change if required
[ ] PR title conforms to conventional commit style
[ ] New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
[ ] If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0d8f12a) 68.04% compared to head (abcc9f5) 68.08%.
Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3465      +/-   ##
==========================================
+ Coverage   68.04%   68.08%   +0.03%
==========================================
  Files        1079     1079
  Lines       36356    36356
==========================================
+ Hits        24739    24752      +13
+ Misses      11617    11604      -13

Flag
Coverage Δ

API_plugin_unit_test
67.07% <ø> (ø)

AWSPluginsCore
64.13% <ø> (ø)

Amplify
48.12% <ø> (ø)

Analytics_plugin_unit_test
81.16% <ø> (ø)

Auth_plugin_unit_test
78.99% <ø> (+0.09%)
:arrow_up:

CoreMLPredictions_plugin_unit_test
59.44% <ø> (ø)

DataStore_plugin_unit_test
81.40% <ø> (+0.04%)
:arrow_up:

Geo_plugin_unit_test
70.75% <ø> (ø)

Logging_plugin_unit_test
63.34% <ø> (ø)

Predictions_plugin_unit_test
37.16% <ø> (ø)

PushNotifications_plugin_unit_test
87.13% <ø> (ø)

Storage_plugin_unit_test
77.51% <ø> (ø)

unit_tests
68.08% <ø> (+0.03%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Initial federated COVID-rich ICU database documentation.

This pulls request provides initial documentation to the tables and standard terminologies included as part of MIMIC-Fed, a large, freely available federated COVID-rich ICU database comprising deidentified health-related data from Beth Israel Deaconess Medical Center (BIDMC) and Northwestern Memorial Health Center (NMHC).
The following tables are included as part of the hospital and icu modules in version 0.1.0 of the federated database:

Hosp Module:  Admissions, Patients, Labevents, D_labitems, Diagnoses_icd, D_icd_diagnosis, Prescriptions, Emar.
ICU Module: ICU_stays, D_items , Chartevents (vital signs), Procedure events.

MIMIC-Fed is a large, freely available federated COVID-rich ICU database

I'm not sure that "freely available" is a good description and would take those words out.
In any event this database isn't yet available at all.  Please add the following at the top of the page (maybe it should be added to each sub-page too?)
{{% pageinfo %}}
MIMIC-Fed is not yet released and its structure is subject to change.
{{% /pageinfo %}}

It is not clear to me what the long-term relationship will be between this data and "MIMIC-IV" as we know it.  I think it would be unfortunate to have two sets of documentation (that both have to be maintained and that would confuse visitors).  At the same time we don't want to give the impression that the new COVID stuff is already integrated in MIMIC-IV.
In terms of the website structure, I'd suggest one of two things:

Inside the MIMIC-IV top-level section, add a subsection (at the end, after Tutorials) labelled Federated (Beta).

Add a new top-level section (at the end, after MIMIC-II) labelled Federated (Beta).

As this database isn't released (nor is it a replacement for MIMIC-IV), it shouldn't be given "top billing" above MIMIC-IV, and at the same time the hope is that eventually this will be part of MIMIC-IV (it's clearly not separate from MIMIC-IV in the way that MIMIC-III is.)
@tompollard how would you feel about these options?
Additionally, someone suggested that "Federated" might not be a good term since it has a specific technical meaning when talking about databases.  Perhaps "Multi-center" could be used instead?

thanks @bemoody for the suggestions. I have updated the changes detailed in the commits.

@tompollard let us know if the changes look ok and we can deploy the changes on the website.

After discussions with @rgmark, @bemoody, @tompollard and @alistairewj, I have restructured the mimic-northwestern multi-center database to the main docs page, and replaced mentions of "federated" with "multi-center" to avoid confusion with another technical term under the term "federated learning".
This is a version that tries to address most of the points raised, though I think the website could be reviewed for any further suggestions either on formatting or naming etc.

After discussions with @rgmark regarding the MIMIC-NW project, MIMIC-NW: Harmonizing Northwestern's ICU Data with MIMIC's Data Structure, I will update the website to emphasize the MIMIC-NW database and adjust the release statement across the main page and modules accordingly. This version will serve as documentation for the data prior to its public release.


Playing with Version Numbers

Hi All,
In an effort to create a usable NuGet package, I am planning to test a theory of changing the version major number from 4 (4.70.xxx.0) to 5 (5.470.xxx.0), as the theory that I have is that it does not like the version 4.7 or 4.70. Due to these changes, I'll be first testing it out on the dev branch, before merging these changes to the stable branch IF successful.
Note: That a new NuGet package will be uploaded that will contain Testing in its string. Please do not use until further notice, as it may not work.

Update: I can now confirm as of Friday 28th September, 2018 that the problem with the Nuget packages was the major number of the version. Therefore, in the next update, the version number will change from 4.70.xxx.0 to 5.470.xxx.0.


Conditional progress bar

Is your feature request related to a problem? Please describe.
The progress bar is always active, and there is no easy way to disable it, as the call to
tqdm contains "disable=False".
Omitting this argument seems to do exactly what I would like to have: "If set to None, disable on non-TTY".
It would be great if there would be a way to disable the progress bar in non-TTY situations.
Describe the solution you'd like
No response
Describe alternatives you've considered
No response
Additional context
No response
Organisation
No response

Starting with tqdm 4.66, there are env variables to tweak behavior. Following variables are helpful in this context:
    export TQDM_MININTERVAL=10  # Minimum progress display update interval in seconds, tqdm>=4.66
    export TQDM_DISABLE=None    # If set to None, disable on non-TTY, tqdm>=4.66

Nevertheless, return tqdm(disable=False, ...) is a bit rude IMHO. It would be more straightforward to set this setting to disable=None.


Transform not working with Union types in Elysia

What version of Elysia is running?
"elysia": "^1.1.22"
What platform is your computer?
Microsoft Windows NT 10.0.19045.0 x64
What steps can reproduce the bug?
import { Elysia, t } from "elysia";

const app = new Elysia();

export const transformId = t
  .Transform(t.String())
  .Decode((value) => +value)
  .Encode((value) => value.toString());

const someSchema = t.Union([
  t.Object({
    id: transformId,
  }),
  t.Object({
    anotherId: transformId,
  }),
]);

app
  .post(
    "/hello",
    ({ body }) => {
      console.log(body); // => { id: "32523", }
      return "OK";
    },
    {
      body: someSchema ,
    }
  )
  .listen(3000);

curl --request POST \
  --url http://localhost:3000/hello \
  --header 'Content-Type: application/json' \
  --data '{
  "id": "32523"
}'

What is the expected behavior?
When sending a request to the /hello endpoint with a JSON body containing either an id or anotherId property, the transformation should be applied, converting the value to a string or number respectively.
What do you see instead?
The transformation is not applied, and the original value is received in the body object.
Additional information
close to https://github.com/elysiajs/elysia/issues/671
I checked only Union types, but I guess that Composite or Intersect types still don't work if there is a Transform inside them.
after in-depth analysis, I couldn't find the trouble spot. I work around compose.ts
if (validator.body) {
	if (
		normalize &&
		'Clean' in validator.body &&
		!hasAdditionalProperties(validator.body as any)
	)
		fnLiteral += 'c.body = validator.body.Clean(c.body);\n'

	console.log(validator.body.schema)
	console.log(validator.body.schema.type)
	// @ts-expect-error private property
	const doesHaveTransform = hasTransform(validator.body.schema)

i get this
{
  [Symbol(TypeBox.Kind)]: "Union",
  anyOf: [
    {
      type: "object",
      properties: [Object ...],
      required: [ "aid" ],
      [Symbol(TypeBox.Kind)]: "Object",
    }, {
      type: "object",
      properties: [Object ...],
      required: [ "uidLiked" ],
      [Symbol(TypeBox.Kind)]: "Object",
    }
  ],
}
undefined

For some reason it cant get the Type of the value. I look through all possible places but dont find where it can possible to set it up.
But if  [Symbol(TypeBox.Kind)]: "Object" then onsole.log(validator.body.schema.type) => Object
I found where it return undefined but dont make next steps for understanding whats wrong:
in utils.ts there is method getSchemaValidator which returns undefined and we cant look at type.
export const getSchemaValidator = <T extends TSchema | string | undefined>(
	s: T,
	{
		models = {},
		dynamic = false,
		normalize = false,
		additionalProperties = false,
		coerce = false,
		additionalCoerce = []
	}: {
		models?: Record<string, TSchema>
		additionalProperties?: boolean
		dynamic?: boolean
		normalize?: boolean
		coerce?: boolean
		additionalCoerce?: MaybeArray<ReplaceSchemaTypeOptions>
	} = {}
): T extends TSchema ? TypeCheck<TSchema> : undefined => {
	if (!s) {
		console.log('i go inside this and return undefined')
		return undefined as any
	}

For some reason getSchemaValidator called with s as undefined.  The only place from which it is called is index.ts
createBody() {
	if (this.body) return this.body

	return (this.body = getSchemaValidator(
		cloned.body,
		{
			dynamic,
			models,
			normalize,
			additionalCoerce: coercePrimitiveRoot()
		}
	))
},

Have you try removing the node_modules and bun.lockb and try again yet?
no

maybe this solution will solve your problem click


Update jquery.storage-field.js

1. Why is this change necessary?
This is a bug. If value is empty and a pseudo field exists "null" is set to the pseudo field.
2. What does this change do, exactly?
It fixes this behavior.
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Which documentation changes (if any) need to be made because of this PR?
6. Checklist

[ ] I have written tests and verified that they fail without my change
[x ] I have squashed any insignificant commits
[x ] This change has comments for package types, values, functions, and non-obvious lines of code
[x ] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-21553
Please use this issue to track the state of your pull request.

HI @sebastianlenz, thank you for your contribution! 💙


Null deserialization

Codecov Report

Merging #41 into master will decrease coverage by 1.48%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
- Coverage   96.21%   94.73%   -1.49%
==========================================
  Files          30       27       -3
  Lines        1056      816     -240
==========================================
- Hits         1016      773     -243
- Misses         40       43       +3

Impacted Files
Coverage Δ

include/ozo/binary_query.h
100% <ø> (ø)
:arrow_up:

include/ozo/binary_deserialization.h
96.38% <100%> (-3.62%)
:arrow_down:

include/ozo/type_traits.h
100% <100%> (ø)
:arrow_up:

include/ozo/impl/connection.h
61.9% <0%> (-9.53%)
:arrow_down:

include/ozo/impl/async_request.h
97.24% <0%> (-0.02%)
:arrow_down:

include/ozo/async_connect.h
100% <0%> (ø)
:arrow_up:

include/ozo/query_builder.h
100% <0%> (ø)
:arrow_up:

include/ozo/query_conf.h

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b728f9c...13c277b. Read the comment docs.


GenericModel 'Keyword' is returning a fatal error when given expected data parameters

Describe the bug
When requesting a model to be created from Keyword, the request's data contains a fatal error. This is occurring when giving the request a data parameter containing a dictionary value.
To Reproduce
Steps to reproduce the behavior:

Open a Python 3.7 shell
Import GAMEBENCH_CONFIG and ModelCreator
Set username, password, and company_id GAMEBENCH_CONFIG variables
Instantiate the ModelCreator
Use the ModelCreator to request a Keyword with the parameter of an empty session id and data with a dict value, representing what to search for:

session_request = {"session_id": "", "data": {"query": "<insert word here>"}}

Observe a fatal error occurs

Expected behavior
A request to the GameBench API can be made to query for certain words.
Desktop (please complete the following information):

macOS 10.14.4
Python 3.7.2

Additional Comments
This does not occur when using a cURL call https://docs.gamebench.net/api/documentation

Note: the value in query should not have array brackets []

The fix for this is merged into Master.


Set community meeting time to 16:00 UTC

Set community meeting time to 16:00 UTC
Signed-off-by: Amine Hilaly<EMAIL_ADDRESS>By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/lgtm


Extend the database probe timeout

Currently, WordPress will retry connecting to the database for 1 minute after the database connection info is provided through the database relation. However, this 1-minute timeout is too short for certain database charms. In this commit, we extend the database probe timeout from 1 minute to 5 minutes.

Looks like integration tests failed, I'm not sure why the required integration checks was skipped since it is supposed to always run, any guesses as to why?

Looks like integration tests failed, I'm not sure why the required integration checks was skipped since it is supposed to always run, any guesses as to why?

Actually, I see the problem. The required checks here are implemented differently. @yanksyoon could we please add a ticket to the backlog to change the required status checks to be implemented in the same way as in operator-workflows so that we don't get the skipped problem? See here for a reference: https://github.com/canonical/operator-workflows/blob/4575dbc5fa9aea6e207d990b5b72584782812a80/.github/workflows/integration_test.yaml#L253

Looks like integration tests failed, I'm not sure why the required integration checks was skipped since it is supposed to always run, any guesses as to why?

I think the branch protection rule * override the branch protection rule main. When was the * rule added?

Looks like integration tests failed, I'm not sure why the required integration checks was skipped since it is supposed to always run, any guesses as to why?

I think the branch protection rule * override the branch protection rule main. When was the * rule added?

I don't think so, GitHub applies to most specific one so the * should not apply. See the other comment for the reason. The check is actually marked as required but it was skipped which means it didn't fail so the require status checks to pass didn't work

The reason we have the * rule is to enforce signed commits


Could not open lock file

Hi!
I get the following errors when I try to push an app... Any idea what that could be? All other build packs with as usual.
remote: HEAD is now at 6380bff... Back to nginx
-----> Fetching custom buildpack
-----> nginx app detected
remote: E: Could not open lock file /var/lib/apt/lists/lock - open (13: Permission denied)
remote: E: Unable to lock directory /var/lib/apt/lists/
remote: E: Could not open lock file /var/lib/dpkg/lock - open (13: Permission denied)
remote: E: Unable to lock the administration directory (/var/lib/dpkg/), are you root?

Unfortunately it still doesn't work. Are there any other buildpacks for dokku and nginx? I would be happy to fix it if I had more details on issue. ping @progrium

This would should work: https://github.com/florianheinemann/dokku-buildpack-nginx

@florianheinemann Thanks a lot.. another one, I found that works for me is https://github.com/socialshop/heroku-buildpack-nginx


fix spell errors fixes multi-tenant doc page

Proposed changes
spelling error fixed for multi-tenant and win compilation pages

run buildall


Misc refactoring for read_taxonomy_file

These are follow-up items from https://github.com/instructlab/instructlab/pull/1767/files I will put this on hold for now so that Russell's PR merges without conflict. I will rebase later.

Can we maybe hold off on refactoring until 0.18.0 final is out?
I appreciate your contributions to improve code quality and agree that these lines should be cleaned up. But right now everybody is busy with getting 0.18 out of the door. Any refactoring PR takes time to review and can introduce bugs and merge conflicts.

@tiran of course I don't expect any of these to be given a priority or merge before GA. I'm adding hold labels everywhere. I assume reviewers should know these are not important and should not be reviewed / merged - only milestoned items should be given attention at this point. These are posted as placeholders for when the main branch is open for all kinds of work. (If I don't post these when they come up during code reviews, I will just forget about them.)

@booxter - could you please rebase, ty!


Added a new Button

Successfully added a new button

Hi, please refer Readme for file naming conventions!

Okay I will
On Wed, 31 May, 2023, 10:08 pm Poorvi, @.***> wrote:

Hi, please refer Readme for file naming conventions!
—
Reply to this email directly, view it on GitHub
https://github.com/Spyware007/Animating-Buttons/pull/791#issuecomment-1570561299,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7766U2M5NEGSMZ6GRZYIC3XI5XX3ANCNFSM6AAAAAAYUBKYCA
.
You are receiving this because you authored the thread.Message ID:
@.***>

I meant your HTML and CSS files

Okay I will do ASAP.
On Fri, 2 Jun, 2023, 5:08 pm Poorvi, @.***> wrote:

I meant your HTML and CSS files
—
Reply to this email directly, view it on GitHub
https://github.com/Spyware007/Animating-Buttons/pull/791#issuecomment-1573595666,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7766UY47PORDOPTXKL3HB3XJHGCDANCNFSM6AAAAAAYUBKYCA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hi, are you still working on this?

Sorry for the delay. I was caught up with something important this week. I
will do it till tomorrow.
On Tue, 6 Jun, 2023, 8:13 pm Poorvi, @.***> wrote:

Closed #791 https://github.com/Spyware007/Animating-Buttons/pull/791.
—
Reply to this email directly, view it on GitHub
https://github.com/Spyware007/Animating-Buttons/pull/791#event-9447293950,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7766UYQ3SH4J2NW3RGZJA3XJ4623ANCNFSM6AAAAAAYUBKYCA
.
You are receiving this because you authored the thread.Message ID:
@.***>


What if container take more than 30secs to start?

Hi Team,
There is scenario where many of our containers may take more than 30 secs to start. In other words, 30 seconds (probably) will not be enough for new replicas to start when VMs receive preemption signal.
Is it possible to modify this draining_timeout_when_node_expired_ms values to 45 secs to solve the above problem?

This is more of a hard limit from GCP Side. We get 30 secs before GCP force terminate the node.


[CP] Added CREATE perrmission and Citizen Projects listing

This PR was closed to be integrated into #1855


Need documentation on exporting data via TopoJSON

We need documentation in README.md for how a user can export data as TopoJSON from Dropchop.

@jczaplew Interested in adding this?

Yep! I can take care of it, along with #240 which is very similar

@jczaplew you should link to your blog post as well, it was a fascinating deep dive.


Make charts vertically responsive (#3105)

Ensure that the hidden iframe is stretched vertically in order to detect height changes. Remove the classlist check/call since it was incorrectly spelled (should be classList), but also useless since the iframe has just been generated. Also remove the callback check: addResizeListener should never be called w/o a valid callback.
Unit tests are coming in another PR!

Added visibility: hidden


Document frontend environment variables required for Auth0 setup

From ui/vite.config.js:
process.env.VITE_USE_AUTH0 ??= serverEnv.USE_AUTH0 ?? 'true'
process.env.VITE_AUTH0_DOMAIN ??= serverEnv.ISSUER
process.env.VITE_AUTH0_CLIENT_ID ??= serverEnv.ID_TOKEN_AUDIENCE
process.env.VITE_AUTH0_AUDIENCE ??= serverEnv.ACCESS_TOKEN_AUDIENCE

These four all need to be set in a docker-compose.override.yml file.

(if there's some way that is easy for you to tell me about them, I'll happily add the documentation)

ISSUER, ID_TOKEN_AUDIENCE, and ACCESS_TOKEN_AUDIENCE should be documented in the backend. I think we can reuse that documentation.


Stream Shutdown does not produce Error on incomplete protocol shutdown

As originally mentioned in #56, Asio.SSL has error::stream_truncated.
This StackOverflow Post does explain very well what it is good for: https://stackoverflow.com/questions/25587403/boost-asio-ssl-async-shutdown-always-finishes-with-an-error
(I think, that stream_truncated did not exist when that post was written and corresponds to the mentioned SSL_R_SHORT_READ.)
I have added #74 to show the current behavior of Asio.SSL and WinTLS in the relevant cases.
Looking at the Schannel Docs, i suspect that the sspi_shutdown class may have to be more complex than it currently is..?
As a sidenote: The StackOverflow post mentions that Asio should produce error::eof during shutdown in some cases.
I did not observe that in my tests. However, this is handled in the beast https sync/async examples and in the WinTLS async example, butn not in the WinTLS sync example.
Could it be, that the information is outdated and error::eof will not occur anymore?
At the very least, it seems inconsistent, that error::eof is handled in the async example, but not in the sync example.

The beast https server examples have a helpful comment on this topic. For example here.
In particular: When using with HTTP (or another "self-terminated" protocol) it is not necessary to wait for the peers close_notify.
For better performance (or simpler code?), many implementations just close the underlying transport after sending their close_notify, without waiting for the peer.
This also seems to be, what the current sspi_shutdown code in wintls is doing.
Although i do not quite understand why it is okay to always use InitializeSecurityContext in sspi_shutdown::operator() and not AcceptSecurityContext when running as a server, as the documentation clearly states. @laudrup, can you comment on that?
Altogether, i think it may be reasonable to keep the current shutdown functions as a more efficient variant to use with HTTP or other "self-terminated" protocols.
But as this library is supposed to be more general than that, the default shutdown functions should make sure that the shutdown procedure was completed properly. I could not find an existing implementation as a good reference, but according to the documentation, the shutdown should be implemented very similarly to the handshake with a loop similar to the one in stream::handshake(handshake_type, error_code&). Then, a new error code stream_truncated should be introduced analogously to asio::ssl and it should explicitly be set, when asio::error::eof occurs when trying to write our close_notify to the stream or when trying to read the peers close_notify from the stream.

As for a good reference implementation i have found https://github.com/steffengy/schannel-rs, which is rust but otherwise similar to wintls.
Notably, they use one function for the initial handshake and also for the shutdown. (https://github.com/steffengy/schannel-rs/blob/e93c3bcf588630717bc592fe9f36fc4b740589b5/src/tls_stream.rs#L583)
I believe that this is generally a good idea and that a lot of code can be share between the initial handshake and the shutdown.
As a first effort towards this end, i have added #77 to simplify the handshake code.

Please complete the PR

@InternalHigh
I guess it's up to you to complete this @jens-diewald :-)

Hi, I will try to find some time to look into this again.
At first, I should rebase this to the current master.
This applies to #77 as well, on which I based #78. @laudrup, it would be nice to merge this before, as it is an independent refactoring which should improve the code in its own right. It looks like the lowest tested boost version is 1.81 now, so I can even remove the post_self case distinction I introduced there.


looking ahead, condition filtering

should we get rid? it only has 5 annotations
FYPO:0005369 - abolished cell population growth at low temperature
(I would do inviable population , low temperature anyway?)
But....oddly  it's a descendant of
http://preview.pombase.org/term/FYPO:0000046
decreased cell population growth
as is
abolished anaerobic cell population growth
abolished cell population growth at high temperature
etc....

Added for #2107; some discussion there.
This is essentially the same "should we precompose this?" question that's arisen many times. I'll implement whatever we decide, but to date we haven't made a final decision about temperature+growth combinations.
I've created a label for precomposition questions, and added it to some closed tickets as well as this one. See the wiki as well as some of those tickets.
(I'm also giving this ticket a more informative title.)


Node v6.6.0 - UnhandledPromiseRejectionWarning emitted from tests

Node v6.6.0 (the current node build) now emits an warning for unhandled promise rejections (see Notable Changes in the Node 6.6.0 Release Notes).   When running the test suite on this version on node, multiple warnings (like the sample below) are emitted to the console.
(node:20070) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 8): Error: Network error: No more mocked responses for the query: {
  author {
    firstName
    lastName
  }
}

fragment authorDetails on Author {
  firstName
  lastName
}
, variables: undefined

To replicate:
$ node --version
v6.6.0
$ npm install && npm test

Oh! That explains why a lot of tests fail on Travis but not on my local computer... let me upgrade node and try again.

getting the same errors, when using node v6.6.0 and having tests running with mocha, using done()  in the assertions.

The only way to solve this in my case, was go back to use bluebird module

Can someone identify any unhandled rejections inside the client? I just quieted this in the tests by overriding the unhandled rejection warning.

@stubailo looks like this one is coming from test file not the actual client..
somewhere test are not handling reject..

I think it's fine to not handle every single rejection in the tests -- at least, it doesn't seem like a top priority to hunt every single one down.

I'm just wondering what @JonathanNasc was referring to, because it didn't sound like he was talking about the tests.

I am sorry, I was referring to use the ES6 native Promises in general.

Looks like this no longer effects us. Just ran the current test suite against Node.js v7.2.1 and we’re all green. Thanks for the report @shanonvl :+1:


fix(services/ghac)!: Remove enable_create_simulation support for ghac

Just to be sure, @huonw, are you relying on this feature?

cc @suyanhanx, PTAL, thanks!

No, Pants doesn't use this. It handles the empty file in a different way. Thanks for checking!


How are we handling the Email Service ?

I was looking at the option how email is being configured in this architecture

The automation is not setting up email. SES would be the "right" solution, but customers usually have their own SMTP gateways that they configure.

Do you have any reference changes that I need to make in moodle to use SES


F#116 improve waterfal chart

Description

폭포수 차트에서 차트 표현이 이상한 부분을 수정합니다.
Related Issue : #116

How Has This Been Tested?

폭푸수 차트를 표현 후 이전 카테고리 끝-다음 카테고리 시작이 이어지는 확인합니다.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project. it will be added soon
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document. it will be added soon
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Additional Context

run build
deploy to 1


Update LocalService LGSL code

What
Change the LGSL code of LocalService 100001 to 1827.
Why
The service was created using a dummy LGSL code (100001).  We now have a real LGSL code for this service (1827) and would like to use it instead of the dummy code.
We need to change the LGSL code in the local_services.csv file in case the local_transactions:fetch_and_clean rake task were to be re-run as it would incorrectly re-create the service as 100001.
Trello
⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠

This looks good, does it need to go in at the same time as https://github.com/alphagov/publisher/pull/1417 or can it be merged whenever?

This looks good, does it need to go in at the same time as #1417 or can it be merged whenever?

Umm! Unless someone runs this rake task once this PR is merged - but before the entire switch of the LGSL code is complete - nothing will happen. If they were to run it, the 100001 service would be removed and the 1827 service created - breaking the service.  Therefore, a safer approach would be to add the 1827 service - and not remove the 100001 service here.  Then removed the 100001 service in a separate PR that is merged once the switch is complete.

This looks good, does it need to go in at the same time as #1417 or can it be merged whenever?

Umm! Unless someone runs this rake task once this PR is merged - but before the entire switch of the LGSL code is complete - nothing will happen. If they were to run it, the 100001 service would be removed and the 1827 service created - breaking the service. Therefore, a safer approach would be to add the 1827 service - and not remove the 100001 service here. Then removed the 100001 service in a separate PR that is merged once the switch is complete.
I'll update this PR and create a separate one to remove 100001.

Okey doke, it sounds good to have both and then delete 100001 afterwards.
It sounds like doing that and using the service sync can simplify the tasks needed for: https://github.com/alphagov/publisher/pull/1417/files to not need to change the service if it can be done by the rake task to deal with this file.


RobotMotorsEstimation.cpp uses a non initialized variable m_n

While working on https://github.com/robotology/walking-teleoperation/issues/110 I noticed that here
https://github.com/robotology/walking-teleoperation/blob/82d3dd9d8d8fbaa3679b856b0cea2c93a0d48642/modules/HapticGlove_module/src/RobotMotorsEstimation.cpp#L129-L132
a variable named m_n is used, defined here
https://github.com/robotology/walking-teleoperation/blob/82d3dd9d8d8fbaa3679b856b0cea2c93a0d48642/modules/HapticGlove_module/include/RobotMotorsEstimation.hpp#L34
but it seems never initialized. It seems to affect how the motor state estimator covariance is obtained, but I am not sure if the output is actually used in other ways than just logging.

I guess this has to be equal to 3 as in https://github.com/robotology/walking-teleoperation/blob/82d3dd9d8d8fbaa3679b856b0cea2c93a0d48642/modules/HapticGlove_module/src/MotorEstimation.cpp#L10


Why can’t Tiller pull from a private Quay.io repo?

I believe there is a bug in Tiller.
Scenario:
Environment:
Kubernetes cluster in GKE
Tiller installed in the GKE cluster using the “helm init” command.
Cluster namespaces: “my_namespace” plus default namespaces:

my_namespace
default
kube-system
kube-default

Image:
Private Quay.io repo
Robot account on the private repo, read-only permission (or admin permission, I tried both). Robot account access secured with a Kubernetes secret.
Kubernetes secret added to all GKE cluster namespaces (my_namespace, default, kube-system, kube-default).
Behavior:
“helm install …” results in Kubernetes reporting “Error: Status 403…permission denied” from the Quay.io repository.
If I unlock the repo, “helm install …” works perfectly. So Tiller can pull from an unlocked Quay repo and can deploy to my namespace.
If I lock the repo and do a “helm dry-run” and copy/paste the Helm-generated manifest verbatim into a yaml file then deploy the yaml with kubectl (context: my-namespace), the deployment works perfectly. So Helm is putting the imagePullSecrets element into the manifest correctly and Quay allows access to a locked repo via the robot account and Kubernetes secret. The only difference is that Tiller is not in the picture.

We do this all the time with helm 2.8, minikube, docker for desktop, and a kops cluster (on AWS). You can verify this yourself, with the following, assuming your secret is called quay-registry-secret and you have the correct version of yq installed.
kubectl get secret quay-registry-secret --namespace my_example -o yaml | \
  yq .data.\".dockerconfigjson\"| tr -d \"| base64 --decode

I performed this suggestion in a few discrete steps so I would be sure not to miss anything. The Kubernetes secret decoded into the correct values. Here's what I did:
I checked my Kubernetes namespace and verified I'm operating in "my-namespace".
I retrieved the secret with "kubectl get secret quay-registry-secret -o yaml". It returned a block of yaml.
From within the yaml, I decoded the ".dockerconfigjson" section and I get completely reasonable looking output:
{
  "auths": {
    "quay.io": {
      "auth": "<snip!>",
      "email": ""
    }
  }

From the decoded ".dockerconfigjson" output, the "auth" string (that I replaced with "<snip!>) decodes into:
:5PI47MV1....<snip!>
Where "" matches the the robot account in Quay.
This all looks reasonable to me. Has anyone tried this exercise using GKE instead of AWS?

Was just working on this and found that we needed to patch the service account in the kube-system name space to add the imagePullSecret to that service account.
Confirm whether the kube-system service account has your secret in imagePullSecrets
kubectl get sa -n kube-system -o yaml
If not run the command below and replace $SECRETNAME with the name of the secret.
kubectl -n kube-system patch serviceaccount default -p "{\"imagePullSecrets\": [{\"name\": \"$SECRETNAME\"}]}"

Thanks for the help. I tried this.
Here is an abbreviated list of Kubernetes secrets scoped to the kube-system namespace. My quay.io pull secret is there:
$ kubectl get secrets -n kube-system
NAME                                     TYPE                                  DATA      AGE
<snip!>
**my-pull-secret**   kubernetes.io/dockerconfigjson        1         19d
<snip!>

After modifying the default service account as described, the secret appears in the yaml output from “kubectl get sa”:
- apiVersion: v1
  imagePullSecrets:
  - name: **my-pull-secret**
  kind: ServiceAccount
  metadata:
    creationTimestamp: 2018-02-27T23:04:43Z
    name: **default**
    namespace: kube-system
    resourceVersion: "2533331"
    selfLink: /api/v1/namespaces/kube-system/serviceaccounts/default
    uid: 9914e2fa-1c12-11e8-8b26-42010a8e00ec
  secrets:
  - name: default-token-d2jmz

However, we create our own Tiller-specific service account (helm init --service-account tiller) so that Tiller has the right permissions on our cluster. This is probably not necessary but I’m including it since Tiller is using the “tiller” service account for now and not “default”. I’ve given “tiller” the secret as well:
- apiVersion: v1
  imagePullSecrets:
  - name: **my-pull-secret**
  kind: ServiceAccount
  metadata:
    creationTimestamp: 2018-03-01T18:46:21Z
    name: **tiller**
    namespace: kube-system
    resourceVersion: "2535275"
    selfLink: /api/v1/namespaces/kube-system/serviceaccounts/tiller
    uid: d6078eb7-1d80-11e8-8b26-42010a8e00ec
  secrets:
  - name: tiller-token-6bng4

And to close the loop, when I check my robot account in Quay, the pull secret yaml is has the right name (my-pull-secret) and if I dry-run Helm the secret looks right:
apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  name: onlyatest-demo
  labels:
    app: demo
    chart: demo-0.1.0
    release: onlyatest
    heritage: Tiller
spec:
  replicas: 1
  template:
    metadata:
      labels:
        app: demo
        release: onlyatest
    spec:
      containers:
        - name: demo
          image: "**quay.io/mystuff/demo:81**"
          imagePullPolicy: Always
          ports:
            - containerPort: 3000
          resources:
      imagePullSecrets:
        - name: **my-pull-secret**

But after “helm install” I check the status of my Pod and I get:
  Normal   Pulling                7s (x2 over 23s)   kubelet, gke-showroom-default-pool-7264549b-g8lb  pulling image "quay.io/mystuff/demo:81"
  Warning  Failed                 6s (x2 over 22s)   kubelet, gke-showroom-default-pool-7264549b-g8lb  **Failed to pull image "quay.io/mystuff/demo:81": rpc error: code = Unknown desc = Error: Status 403 trying to pull repository mystuff/demo: "{\"error\": \"Permission Denied\"}"**
  Warning  FailedSync             6s (x5 over 22s)   kubelet, gke-showroom-default-pool-7264549b-g8lb  Error syncing pod

Closing due to inactivity. Please open a new ticket against Helm 3 if this issue persists. Thanks!


Timing issue when using Directional Light with Update Mode set to Once

Description
The order and timing seem to matter when using a Update mode Once Directional light.
Please find example project here https://playcanvas.com/editor/scene/611806
Steps to Reproduce

open project https://playcanvas.com/editor/scene/611806
launch the scene
refresh over and over and over

You will notice there are different results depending on the timing. Sometimes the shadow is drawn, sometimes it is not.

The repro project no longer works. There were many large changes in the shadow rendering, and this is likely no longer relevant. Please reopen if you can still reproduce the issue.


Increase baseline latency for single line suggestions

Add more baseline latency to single line suggestions, but after use accepts one completion, reduce latency of consecutive ones

Closed by https://github.com/sourcegraph/cody/pull/1202


how to fit binary trait in FaST-LMM

I have binary trait with 0 and 1. I wonder if the FaST-LMM is fine with such trait ?

Yes.  However, if you’re data has ascertainment bias, you should preprocess with https://www.nature.com/articles/nmeth.3285.
Best,
David
From: yejunbin<EMAIL_ADDRESS>Sent: Tuesday, June 26, 2018 9:03 AM
To: MicrosoftGenomics/FaST-LMM<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [MicrosoftGenomics/FaST-LMM] how to fit binary trait in FaST-LMM (#34)
I have binary trait with 0 and 1. I wonder if the FaST-LMM is fine with such trait ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftGenomics%2FFaST-LMM%2Fissues%2F34&data=02|01||1e74253590e84558ba6f08d5db7e403f|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636656257638920302&sdata=aOGEcUgUTHla4%2B8Ehlc1fpAm7JaAOBrVmPYKesCAkAA%3D&reserved=0, or mute the threadhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAI_N05HrZQiIsrk2wqIOe2AoQ_Hv8xtJks5uAlsigaJpZM4U4PKw&data=02|01||1e74253590e84558ba6f08d5db7e403f|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636656257638920302&sdata=yXLFWchWeTY1CC7Bt%2FM%2B%2FGWkTvhdDIbTm%2BJWGvfC8Fk%3D&reserved=0.


Serialize IDs as integers and not strings in PersistedSnapshot

The PersistedSnapshot type is serializing the DbId and TableId keys in the databases/tables map as strings. It should instead serialize as a an array of structs, then deserializing as the map with integer keys.

See: https://github.com/influxdata/influxdb/blob/f745ea69c88971103b2e998b305d170a0bee771e/influxdb3_id/src/serialize.rs#L32


replace sympy with ast

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


unicode compatability

Would like to see compatibility for unicode so we can use
"/uEff5"

I would not call it "compatibility", but rather a feature that replaces an hexadecimal number with the corresponding unicode character.
Sorry, it's out of the scope of the plugin. To achieve this functionality you can use PlaceholderAPI with the unicode expansion.


Release tracking

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
<EMAIL_ADDRESS>Minor Changes

#453 5855526 Thanks @rezrah! - - New font prop added to Text and Heading components to alternate between mona-sans and hubot-sans variable fonts. mona-sans remains the default.

Uses latest v1.0.1 releases of (Hubot Sans)[https://github.com/github/hubot-sans/releases/tag/v1.0.1] and (Mona Sans)[https://github.com/github/mona-sans/releases/tag/v1.0.1] fonts.
Added extralight weight option

Patch Changes

#468 a6251df Thanks @rezrah! - Force removal of link underlines in Card components, to prevent specificity issues with local stylesheet overrides.

#451 b15ab24 Thanks @joseph-lozano! - Fixed menu item overflow issues on narrow viewports in SubdomainNavBar.
In addition, the body element will now hide overflow content and prevent background scrolling when the menu is open.

#480 0e1e3bb Thanks @joseph-lozano! - Improved keyboard navigation in the SubdomainNavBar mobile menu using focus trapping.

#469 da4e989 Thanks @joseph-lozano! - Changed the aria-label for the GitHub link in the footer

#457 9ea0803 Thanks @joseph-lozano! - Fixed issue with prose un-ordered lists in dark mode

#479 1896326 Thanks @rezrah! - Increase tracking of 100 typographic position to improve readability

#479 1896326 Thanks @rezrah! - Added export for CardSkewEffect component

#468 a6251df Thanks @rezrah! - Added 'torchlight' hover effect to dark mode Card instances.
See: https://primer.style/brand/components/Card/react#torchlight-effect

<EMAIL_ADDRESS>Patch Changes

#457 9ea0803 Thanks @joseph-lozano! - Fixed issue with prose un-ordered lists in dark mode

#479 1896326 Thanks @rezrah! - Increase tracking of 100 typographic position to improve readability

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

Release test results
Universe

1 regression noticed to speaker highlight cards. Larger border radius values cause clipping of the speaker names. Non-blocking as this is a custom component built on top of the Primer Brand button component. A custom workaround will be required following an upgrade. cc. @simurai

Enterprise LP

No regressions found

Feature preview pages

No regressions found
Bugfixes verified to text-decoration of cards and new, default torchlight effect


Sourcemap urls without filename or path (only hash) in Chrome

Sorry wrong project

No worries. 👍


slickGoTo tests are failing

Use jest fake timers to resolve it.

Not going to fix, due to delayed setState callback in slickGoTo.


Timestamp of NavMenu and NavMenuItem not updated

Hey Owen,
due to some latency issues we have built a fragment_cache for some view partials.
cache [current_site.nav_menu_items.maximum(:updated_at).to_i, I18n.locale.to_s] do
We have encountered a problem regarding the updated_at timestamp of nav_menu_items. Like when you reposition a nav_menu_item in /admin/appearances/nav_menus the nav item does not update this timestamp.
Same is applicable to to NavMenu.
Hoping for a fix soon.
LG Dariusch

Fixed!


Add SSL Certificate not remembering Credentials File Content in UI

Describe the bug
When using the UI and creating an SSL Certificate with my provider Cloudflare, and using a DNS Challenge, the API token that the UI shows is the default every time I try and use it. Even though under the letsencrypt/credentials/credentials-X when I view it, it is my actual API token. But for whatever reason the the UI can't get the correct info from the credential file. Anything I can do? Or this is an actual bug? I tried just doing it as is, on the UI to see if it would go through, but it fails, because it's not the correct API.
Not sure if it's permissions or anything? But when reading the  docs, from what I could find, it doesn't state to create a specific user or anything. So not sure if it would be that.
Docker-Compose on Debian 10
v2.9.16

i also have the same type of issue, but i would like to have it pull the default API key (or entire file) when requesting a new certificate.
Can that be set somewhere?


Allow only camera or gallery

Connection with issue(s)

Close #23
Solution description
You can specify from which sources a user can select images, by setting them manually via availableImageSources = [ImageSourceOption.camera, ImageSourceOption.gallery]
Screenshots or Videos

To Do

[X] Read contributing guide
[X] Check the original issue to confirm it is fully satisfied
[X] Add solution description to help guide reviewers
[ ] Add unit test to verify new or fixed behaviour
[X] If apply, add documentation to code properties and package readme

I do not have access to an IOS Device so I could only test it on android and web


Chore/simplify docker compose

Adds a reverse proxy to the mock-servers to minimize how many ports are exposed.

We'll want to update the README with the new caddy method of adding a microservice. But otherwise LGTM.


Mitigate known pixel noise

Task/Issue URL: https://app.asana.com/0/1206580121312550/1207587846470650/f
BSK PR: https://github.com/duckduckgo/BrowserServicesKit/pull/851
macOS PR: https://github.com/duckduckgo/macos-browser/pull/2876
Important note
Do not merge this PR, as we'll merge these changes directly into main.  The reason this PR is open is to validate the BSK changes against iOS using the CI, and for testing validation.
Description
Removes known noise from VPN pixels.
Testing

Internal references:
Software Engineering Expectations
Technical Design Template

Superseded by https://github.com/duckduckgo/iOS/pull/2970


Preserve Original Window Size

Would it be possible to preserve the original window size, for windows that are maximized when dragged into a zone, so that they return to their last state if dragged from the zone? This would be similar to the way Windows 10 handles windows that are dragged after they are snapped to the edge of a screen.

Hi @esiemiat
thank you for your feedback, we are already tracking this feature in https://github.com/microsoft/PowerToys/issues/166
I will close this one as a duplicate.
Thank you.


Did the "Save as HTML" option disappear?

I was using the "Save as HTML" option.  I can't seem to find it.  Is it still available?

How should it work this time around?
Right-click foo.md file and hit Save as HTML to produce foo.md.html and nest it under foo.md? Then update foo.md.html every time foo.md is edited?

I thought the original implementation was pretty clean and straight forward.  Nesting the .html file under the .md file is fine, but I don't think the .md was carried over to the nested html filename.  Foo.md -> foo.html

@mcolegro ok, makes sense. So just like it was in the old extension? No improvements needed?

I think the way it works in the earlier version is pretty simple and straight forward.

The generation in the old version was nice. would be great if v2 could have it back.

Without "Save as HMTL", at the moment, I need to use an external tool such as notepad++ to convert to HTML. Please add this function back.

Are there any plans to fix this issue soon?

I switched back to the 1.x version to continue using the save to Html function.  I'll upgrade once the functionality has been added to the 2.x version.

Yeah I've had to downgrade as well as I need the .html generation, otherwise a great extension.


No confirmation page

In reviewing the code, it appears there is no way to present the buyer with a confirmation screen.
When a buyer enters their payment information, is there no supported way of capturing the input so to present a confirmation page where they can review the order before proceeding/processing? This example does processing upon submission of the credit card form fields that are injected via iframe. It doesn't seem to support entering payment information on one page and confirming on the next page - like my website has been doing for roughly 12 years.
Can this example be adapted/altered to capture payment information in one step and process the payment in another step?

Hi there,
no, that would defeat the purpose of what payment.js provides from a PCI compliance standpoint. As soon as the form is submitted, the credit card data is sent directly from the consumer's browser to First Data/Fiserv for processing, and a token is returned. The card data bypasses your server entirely (which is different than how yours works today, for good reason). Typically in a shopping cart scenario such as yours when using a product like payment.js, the tokenization request would be sent from the payment page, and then the subsequent authorization would be sent once the order is actually confirmed.
The other alternative to this is having the payment form and the order confirmation on the same page, where when the form is submitted, it will tokenize the credit card and then perform the authorization in one step as two separate callouts.

Hi and thanks for your reply on the issue. I do have a follow up question:
When the data in the form bypasses the server during tokenization as you described, the server is left unable to create a properly formed transaction request because those values (name, card number, expiry, cvv) are required parameters to later create the transaction. If name, card number, expiry and CVV bypass the server, they can't be saved or used to later build a request to process the actual transaction, post-successful tokenization.
When I look at the docs and testing here https://developer.payeezy.com/apis, if any of those 4 fields are not available or sent with the subsequent transaction request, the API will return an error saying the field is required.
I don't see an API example that doesn't require those 4 fields as parameters so I'm not sure what's missing. Any help would be much appreciated!


Fix class alias reference in static initializer for legacy class decorators

This fixes an issue related to the class alias reference we emit for legacy decorators. Prior to this fix, static initializers would run before the class alias was initialized when the target is ES2022 or greater since the static fields would be preserved and initialized inline in the class, as opposed to after the class which would be the case for ES2021 and lower targets.
Fixes #52004
Fixes #44908

Fantastic!! Thank you for the PR to fix this. I tried to work on the PR, but the code is quite a challenge to understand all of the meta concepts.


[BUG] Cannot create new Post

Laravel Version: 5.4.28
Voyager Version: 0.11.14
PHP Version: 7.1
Database Driver & Version: sqlite3

Description:
I cannot to create post after voyager installation, if I did not fill following fields: title, excerpt, meta_keywords, meta_description. After push the "create post" button, I got database error, with message "field :name cannot be null".

Steps To Reproduce:
For reproduce needs to install package use default instruction, but you should use sqlite database as driver:

laravel new test-bug && cd test-bug
composer require tcg/voyager
touch database/database.sqlite
.env file:

DB_CONNECTION=sqlite
DB_HOST=localhost
#DB_DATABASE=homestead
DB_USERNAME=homestead
DB_PASSWORD=secret

After add Voyager service provider inside config/app.php, run php artisan voyager:install --with-dummy
php artisan serve and then go to admin page -> posts -> create new post, type lorem ipsum dolar sit amet to the post body.
You got error.

How to fix:

Create new migration and updates database fields to use nullable option (->nullable()).
Validation of post create request, if fields require to the fill it.

excert is null give some content to it or change not null to fase in admin/database/post or in sql table

Labels: invalid


interactive image header error

I have a URL image added to the header, then sent with the interactive message. I received the below error:
{"error":{"message":"(#131009) Parameter value is not valid","type":"OAuthException","code":131009,"error_data":{"messaging_product":"whatsapp","details":"Text cannot be null for header type text"},"error_subcode":2494010,"fbtrace_id":"ADVfgNJuHt1I0vswkWjywNs"}}
{
  error: {
    message: '(#131009) Parameter value is not valid',
    type: 'OAuthException',
    code: 131009,
    error_data: {
      messaging_product: 'whatsapp',
      details: 'Text cannot be null for header type text'
    },
    error_subcode: 2494010,
    fbtrace_id: 'ADVfgNJuHt1I0vswkWjywNs'
  }

Could you send me the output from the function:
WhatsApp.logSentMessages((id, to, object) => console.log(object));

This will show the structure of the sent message to the API. However, keep in mind that the interactive header had been a little broken since #1, so I wouldn't be surprised if it's, once again, the same server side issue.

@Secreto31126 Here you go:
{"type":"list","action":{"button":"this is a subtitle","sections":[{"title":"this is a title","rows":[{"id":"action_a","title":"Action A","description":" "}]}]},"body":{"text":"this is a title"},"header":{"type":"image","image":{"link":"[https://upload.wikimedia.org/wikipedia/commons/9/91/T-bone-raw-MCB.jpg"}},"footer":{"text":"this](https://upload.wikimedia.org/wikipedia/commons/9/91/T-bone-raw-MCB.jpg%22%7D%7D,%22footer%22:%7B%22text%22:%22this) is a title"}}

It seems that footer is broken too (Without footer)
{"type":"list","action":{"button":"this is a subtitle","sections":[{"title":"this is a title","rows":[{"id":"action_a","title":"Action A","description":" "}]}]},"body":{"text":"this is a title"},"header":{"type":"image","image":{"link":"https://upload.wikimedia.org/wikipedia/commons/9/91/T-bone-raw-MCB.jpg"}}}

I think GitHub tried to parse the image's url with markdown 😆. Anyway, as I suspected, the framework is building the message as expected on the client, but the API freaks out because there's no text:
{
    "type": "list",
    "action": {
        "button": "this is a subtitle",
        "sections": [
            {
                "title": "this is a title",
                "rows": [
                    {
                        "id": "action_a",
                        "title": "Action A",
                        "description": " "
                    }
                ]
            }
        ]
    },
    "body": {
        "text": "this is a title"
    },
    "header": {
        // This is the standard structure for images, which as stated in #1 it sometimes works and sometimes doesn't
        // At least with interactive buttons, never tested it with lists
        "type": "image",
        "image": {
            "link": "https://upload.wikimedia.org/wikipedia/commons/9/91/T-bone-raw-MCB.jpg"
        }
    }
}

I tried with buttons BTW

On the other hand, on the Postman documentation, the example code for lists doesn't mention other types than texts. I will need to dive back into the documentation and see if there's any mention as how the API expects other headers types.
I will come back to this in an hour or so and test a bunch of things. Sorry for the inconvinience!

thanks @Secreto31126 in advance 🙂

Ok, I think I did some progress. The API documentation was updated and now includes a list of the valid headers types for each interactive.
Unfortunately, the only valid header for lists and multi products are texts (there's no mention of single products 🙄).
I will test with the other types and update the code to reject invalid headers for each type, preventing this error in the future.
Sorry for the bad news :/

Well, I tested with all the interactive types and with images and videos, and unfortunately none works except for buttons. I will start writting the new checks for the header, and read a little more in search for other weird exceptions.
PS: The documentation didn't mention single products because they simply don't support headers, got my own code to tell me that 😄.

THank you very much for you efforts 🙂

@Secreto31126 what do you mean by "and unfortunately none works except for buttons"?

None of the media types work as an interactive header except for buttons interactives. In other words, Media only works as a header for ActionButtons. I'm a pro at saying simple things the hard way :)
Anyway, a PR is on the oven, it should be ready in a few minutes.

Perfect, thank you @Secreto31126  :)


feat: support for API Key authentication

In 2018 Apple introduced the Appstore connect API. This provides a way to use JWT tokens to authenticate.
As I noted in #16 current versions of altool also support this way of authenticating. This PR adds the necessary options.
I am not sure what to do about ascProvider (aka the -itc_provider parameter). It is no longer mentioned in altool. Shall we remove it as well?
Closes #16

asc-provider is still in apple developer doc: https://developer.apple.com/documentation/xcode/notarizing_your_app_before_distribution/customizing_the_notarization_workflow
You can omit the asc-provider flag for the notarization call if your credentials are associated with only a single team. Otherwise, use the flag to indicate the provider short name for the appropriate team. Starting in Xcode 11, you can use altool to get a table of providers, provider short names, and team IDs associated with a given username and password using the list-providers flag: