TPPOVM gpindices not set properly through pickling

Describe the bug
The gpindices for TPPOVMs are not set properly through pickling. This appears to be a TPPOVM specific problem - states, operations, and UnconstrainedPOVMs are fine.
This is particularly insidious because mpi4py inherently uses pickling for interprocess communication, so fixing this is important for MPI parallelism.
To Reproduce
from pygsti.modelpacks import smq1Q_XY

target_model_1q=smq1Q_XY.target_model('full TP')

print('target_model_1q pre-pickle', flush=True)
target_model_1q._print_gpindices()

with open('model_pickle.pkl', 'wb') as f:
    pickle.dump(target_model_1q,f)
with open('model_pickle.pkl', 'rb') as f:
    target_model_1q_post = pickle.load(f)

print('target_model_1q post-unpickle', flush=True)
target_model_1q_post._print_gpindices()

The output is then:
target_model_1q pre-pickle
PRINTING MODEL GPINDICES!!!
>>> rho0 [TPState]: 3 params, indices=slice(0, 3, None)
>>> Mdefault [TPPOVM]: 4 params, indices=slice(3, 7, None)
  >>> Sub0 [FullPOVMEffect]: 4 params, indices=slice(3, 7, None)
    >>> Sub0 [FullState]: 4 params, indices=slice(3, 7, None)
  >>> Sub1 [ComplementPOVMEffect]: 4 params, indices=slice(3, 7, None)
    >>> Sub0 [FullPOVMEffect]: 4 params, indices=slice(3, 7, None)
      >>> Sub0 [FullState]: 4 params, indices=slice(3, 7, None)
>>> Gxpi2:0 [FullTPOp]: 12 params, indices=slice(7, 19, None)
>>> Gypi2:0 [FullTPOp]: 12 params, indices=slice(19, 31, None)
target_model_1q post-unpickle
PRINTING MODEL GPINDICES!!!
>>> rho0 [TPState]: 3 params, indices=slice(0, 3, None)
>>> Mdefault [TPPOVM]: 4 params, indices=slice(3, 7, None)
  >>> Sub0 [FullPOVMEffect]: 4 params, indices=slice(0, 4, None)
    >>> Sub0 [FullState]: 4 params, indices=slice(0, 4, None)
  >>> Sub1 [ComplementPOVMEffect]: 4 params, indices=slice(0, 4, None)
    >>> Sub0 [FullPOVMEffect]: 4 params, indices=slice(0, 4, None)
      >>> Sub0 [FullState]: 4 params, indices=slice(0, 4, None)
>>> Gxpi2:0 [FullTPOp]: 12 params, indices=slice(7, 19, None)
>>> Gypi2:0 [FullTPOp]: 12 params, indices=slice(19, 31, None)

Expected behavior
It is expected that the gpindices are unchanged through pickling, i.e. the line "  >>> Sub0 [FullPOVMEffect]: 4 params, indices=slice(0, 4, None)" should be "  >>> Sub0 [FullPOVMEffect]: 4 params, indices=slice(3, 7, None)".
Environment (please complete the following information):

pyGSTi v<IP_ADDRESS>
python 3.10
OSX 13.4

Being fixed in #336

Closing with the release of <IP_ADDRESS>


update fullpath method & add permission for example app

Thank you for your work!
Since directly adding it to the app did not work as expected after startup, I found the source code to test. I hope you can verify if the modifications I made are correct.

decode bytes with UTF-8.
update fullpath method.
sleep 100ms before entering passive mode, but I don't know what happened.
request storage permission for example on android.

It works as a server on Android 13, iOS 14, Windows 11, and Ubuntu 24.04. Specifically, iOS 14 uses Finder and Windows 11 uses Xshell to connect to Android 13, Windows 11, and macOS 14 as clients, all of which work normally. However, the file manager on Ubuntu fails to connect to the other three platforms. I noticed that Ubuntu provides more parameters, and I hope you can fix it and let me know once it's done.

PWD i forgot that command, and it ruined alot of the fixes i made.
for the other changes LGTM
thank you for your contribution.
also thank you for testing on windows, since i cant test on it and the paths were making me worried

@lawnvi
// I'm not sure what happened here, the client shows nothing if I comment out this line.
    await Future.delayed(const Duration(milliseconds: 100));

did you try with a lower value?

@lawnvi
// I'm not sure what happened here, the client shows nothing if I comment out this line.
    await Future.delayed(const Duration(milliseconds: 100));

did you try with a lower value?

yes, I tested with 0, and it worked on macOS and Android, but Windows required a higher value.

@lawnvi
// I'm not sure what happened here, the client shows nothing if I comment out this line.
    await Future.delayed(const Duration(milliseconds: 100));

did you try with a lower value?

yes, I tested with 0, and it worked on macOS and Android, but Windows required a higher value.

Going with your test on that one will leave it be.
Another question what's the problem with Linux? If you can elaborate more since I also doesn't have a linux machine


Use pybtex library for generating bibtex formatted strings

Hello there!
Here's an alternative way of generating bibtex formatted strings, using an external library called pybtex. It also requires setuptools, and apparently uses some of its deprecated calls, which triggers a warning.
But still, unit tests, robot tests and linting all pass, and the software appears to be working.

Rebased to resolve conflicts with https://github.com/turunenv/ohtu-s23-miniprojekti/commit/58e802b433c59f5c19be6ea78af13bf4f9fee70b

I believe the project has reached end-of-life, therefore closing this PR.


Remove link to contributing guide

The contributing guide links to the contributing guide. I think that explains it.

I can't imagine why the CI build would fail when checking this change.

@accidentaldeveloper The build fails because the FixAll code fix for SA1501 is non-deterministic.
(see also #2010 and #2067)

:+1:

Current coverage is 93.36%

Merging #2116 into master will increase coverage by +0.01% as of 8a00d55

@@            master   #2116   diff @@
======================================
  Files          566     566
  Stmts        35946   35946
  Branches      2315    2315
  Methods
======================================
+ Hit          33557   33560     +3
  Partial        761     761
+ Missed        1628    1625     -3

Review entire Coverage Diff as of 8a00d55

Powered by Codecov. Updated on successful CI builds.


Apache Kafka+Flink: Update to cratedb-flink-jobs-0.5, using Flink 1.18

About
A patch by @matriv is apparently part of Flink 1.18 now.

https://github.com/apache/flink-connector-jdbc/pull/29

Accompanying the release of cratedb-flink-jobs-0.5, which includes the update to Flink 1.18, this patch verifies it on CI.
/cc @surister

Thank you!


Roll engine 540fc977bb6b..8c2aeadc51e5 (1 commits)

git@github.com:flutter/engine.git/compare/540fc977bb6b...8c2aeadc51e5
git log 540fc977bb6b..8c2aeadc51e5 --no-merges --oneline
2019-10-15<EMAIL_ADDRESS>Roll src/third_party/dart 70a7ef3f58..50f7ae9c5d (18 commits)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/6296309836808192 , https://cirrus-ci.com/task/5170409929965568

Commit queue failed; closing this roll.


Author of seven_segments platform

I am wondering who created the seven_segments platform?
I need some changes to the script, but I am unsure how to handle these!
Thanks,
Frank

Read this https://home-assistant.io/developers/
Look to git history and you see who had write this platform
Make a PR with your suggestion

I did.

@pvizeli: I will look into it!
@fabaff: GREAT JOB! Thanks
This is my command:  ssocr -D rotate 357 crop 145 170 180 62 -t 40 -d -1 test.jpg
As you can see I don't want to use make_mono and erosion.....
For now I changed the following:
       self._command = [            'rotate', str(config[CONF_ROTATE]),            'crop', str(config[CONF_X_POS]), str(config[CONF_Y_POS]),            str(config[CONF_WIDTH]), str(config[CONF_HEIGHT]), '-t',            str(config[CONF_THRESHOLD]), '-d', str(config[CONF_DIGITS]),            self.filepath         ]         if config[CONF_SSOCR_TYPE]:             self._command.insert(0, config[CONF_SSOCR_TYPE]);         if config[CONF_MAKE_MONO]:             self._command.insert(0, 'make_mono');         self._command.insert(0, config[CONF_SSOCR_BIN])
(with the corrensponding changes in configuration.yaml and seven_segment.py (add default values and defining the extra config options)

What is the best way to get these changes into the main repo?
Do you have a seperate repo or do I need to follow pvizeli's advice?

Thanks for helping out!
Frank

@pvizeli:  If only I was a python man ;)

:) oh I missunderstand it


vsphere cpi and csi charts incompatible with rke2

What kind of request is this (question/bug/enhancement/feature request):
bug
Steps to reproduce (least amount of steps as possible):

Bring up an rke2 cluster with cloud-provider-name: "vsphere"

Result:
There are 3 incompatibilities here:

The CPI helm job fails to install due to RBAC conflicts:

Unable to continue with install: ClusterRole "cloud-controller-manager" in namespace "" exists...
Unable to continue with install: ClusterRoleBinding "cloud-controller-manager" in namespace "" exists...

If I delete those roles manually, the CPI chart installs, but it fails to set ProviderID on the node due to the selector on the daemonset - notice it does not contain the dash in control-plane for the node-selector, but the node does have it.
Not having the dash on the control-plane node-role label seems to make both this chart and RKE1 noncomplaint with upstream: https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.20.md#:~:text=Introduce a new label

The CSI chart installs, but it has the same nodeselector issue on the vsphere-csi-controller pod.

$ k describe ds -n kube-system vsphere-cloud-controller-manager
...
Node-Selector:  node-role.kubernetes.io/controlplane=true
...
Desired Number of Nodes Scheduled: 0
Current Number of Nodes Scheduled: 0
Number of Nodes Scheduled with Up-to-date Pods: 0
Number of Nodes Scheduled with Available Pods: 0
Number of Nodes Misscheduled: 0
Pods Status:  0 Running / 0 Waiting / 0 Succeeded / 0 Failed
...

$ k describe nodes
...
Labels:             beta.kubernetes.io/arch=amd64
                    beta.kubernetes.io/os=linux
                    kubernetes.io/arch=amd64
                    kubernetes.io/hostname=maxrke2
                    kubernetes.io/os=linux
                    node-role.kubernetes.io/control-plane=true
...

$ k get deployment.apps/vsphere-csi-controller -n kube-system -o yaml
...
spec:
  template:
    spec:
      nodeSelector:
        node-role.kubernetes.io/controlplane: "true"
...

Other details that may be helpful:
I start my rke2 server with:
# /etc/rancher/rke2/config.yaml
write-kubeconfig-mode: 644
cloud-provider-name: "vsphere"

and
# /var/lib/rancher/rke2/server/manifests/vsphere-values.yaml
apiVersion: helm.cattle.io/v1
kind: HelmChartConfig
metadata:
  name: rancher-vsphere-cpi
  namespace: kube-system
spec:
  valuesContent: |-
    vCenter:
      host: "myhost"
      datacenters: "mydatacenter"
      username: "myuser"
      password: "mypass"
      credentialsSecret:
        generate: true
---
apiVersion: helm.cattle.io/v1
kind: HelmChartConfig
metadata:
  name: rancher-vsphere-csi
  namespace: kube-system
spec:
  valuesContent: |-
    vCenter:
      host: "myhost"
      datacenters: "mydatacenter"
      username: "myuser"
      password: "mypass"
      clusterId: "myid"
      configSecret:
        generate: true
    storageClass:
      datastoreURL: "mydatastoreurl"

Initial failing helm pod logs:
+ helm_v3 install rancher-vsphere-cpi /rancher-vsphere-cpi.tgz
Error: rendered manifests contain a resource that already exists. Unable to continue with install: ClusterRole "cloud-controller-manager" in namespace "" exists and cannot be imported into the current release: invalid ownership metadata; label validation error: missing key "app.kubernetes.io/managed-by": must be set to "Helm"; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "rancher-vsphere-cpi"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "kube-system"

After clusterrole is manually deleted, the next failing helm pod logs:
Error: rendered manifests contain a resource that already exists. Unable to continue with install: ClusterRoleBinding "cloud-controller-manager" in namespace "" exists and cannot be imported into the current release: invalid ownership metadata; label validation error: missing key "app.kubernetes.io/managed-by": must be set to "Helm"; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "rancher-vsphere-cpi"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "kube-system"

Versions:
rke2 v1.21.0-alpha2+rke2r1
CPI Chart: https://charts.rancher.io/assets/rancher-vsphere-cpi/rancher-vsphere-cpi-1.0.000.tgz

Some thoughts on this issue:

The RBAC conflicts are due to RKE2 and the vsphere chart using generic names. Since they don't deploy the same resources, I will update the chart to use a less generic name and wrap the RBAC logic in a toggle to provide more flexibility.
I don't think the chart should contain any logic to set a node selector label based on RKE vs RKE2. It already provides a way to pass in your own node selector labels through the values.yaml, so you could pass in the control-panel label to override the controlplane default and it will work. The questions.yaml doesn't support objects though, so the user will need to do it through the values.yaml directly. As for RKE, I will create an issue to update the labels since we should aim to match upstream and we can then update the chart's default to control-plane so that default values work with both.

On part 2 above, if those labels don't change in time then that should at minimum be called out in the app-readme.md. A better solution would be to add a flag in the values.yaml that was for rke vs rke2 and then it swapped it for you. There is precedence for that where the UI will set it for you.

@cbron I've brought that up to @vincent99 before, and he mentioned there isn't something in the UI to configure the chart based on rke1 vs rke2. Also, questions.yaml doesn't support objects so it would need to be a field to specify the cluster type like rk1, rk2, or other, and swap the label based on the user's selection.

Oh, maybe the UI never did implement that, I get mixed up. Yes we'd do it that way, the logging chart does similar thing: https://github.com/rancher/charts/blob/dev-v2.6/charts/rancher-logging/rancher-logging/3.9.401+up3.9.4/values.yaml#L108

@cbron I updated my PR to include a question with a dropdown so the user can select between "rke", "rke2", or "other" and configure the chart with the correct node selector label based on the cluster type the user selects. However, there is a problem in the UI with enum typed field where the value is not overriding the value in the chart's values, so the user won't be able to use the drop down to select the cluster type. I created this issue to address that.

@cbron @PennyScissors I guess Vue doesn't currently support question defaults so we can add that.  But If you want default values to be applied, they should really be in values.yaml instead of questions.yaml.  If you do a cluster template or helm install of this chart directly, questions.yaml is not going to be read or processed by anything.

@vincent99 I agree for the most part. Default values should go in the values.yaml, but a default in questions.yaml seems like a better approach in this case because the question is used to set up something Rancher specific. If we set a default in values.yaml, the user would need to change it if they want to install the chart directly in a non-rke cluster.

Validated this is now working. RBAC issues have been resolved, and can specify the node selector which makes the other parts of the issue fine as well:
# /var/lib/rancher/rke2/server/manifests/vsphere-values.yaml
apiVersion: helm.cattle.io/v1
kind: HelmChartConfig
metadata:
  name: rancher-vsphere-cpi
  namespace: kube-system
spec:
  valuesContent: |-
    vCenter:
    ...
    cloudControllerManager:
      nodeSelector:
        node-role.kubernetes.io/control-plane: "true"
---
apiVersion: helm.cattle.io/v1
kind: HelmChartConfig
metadata:
  name: rancher-vsphere-csi
  namespace: kube-system
spec:
  valuesContent: |-
    ...
    csiController:
      nodeSelector:
        node-role.kubernetes.io/control-plane: "true"

I used v1.21.3+rke2r1 when validating.

I just had to realize that this issue also exists in the helm chart delivered with RKE2 1.20.11-rke2r1
node-role.kubernetes.io/controlplane: "true"
vs
node-role.kubernetes.io/control-plane: "true"
--> is there a reason why the included helm chart in RKE2 does not include a fix?


Rails 6 recommends removing require_dependency

This gem recommends using require_dependency in the initializer to set up bot reloading in development but those should be removed according to the rails 6 upgrade guide using the Zeitwerk autoloader.
It seems to me that maybe only config.autoload_paths is needed nowadays, so maybe we should update the Readme?

That sounds about right, @StefanWallin! I wonder if it'll be necessary to change the recommended file structure for Zeitwerk to do it's magic, too, though? I think we'll have to verify this before updating the README accordingly. 🤔 Pull requests welcome!


Checkstyle checker: support classpath file

Add the ability to externalize the checkstyle classpath. Similar to how it is done in javac.

Please don't do that.  The javac checker is a mess that needs to be simplified, rather than imitated everywhere else.
The syntastic way to deal with this kind of problems is to delegate as much as possible to the OS, by using environment variables and wrapper scripts.  If you set g:syntastic_java_checkstyle_classpath to an empty string you can manage classpath externally, by setting the CLASSPATH environment variable.
The Vim way to deal with this kind of problems is to use autocmds.  If you set autocmds for your projects you can update g:syntastic_java_checkstyle_classpath automatically.  You can source files from autocmds.
The IDE-minded way to deal with this kind of problems is to install a plugin that allows you to have per-project settings.  There are several such plugins around.
The Java way to deal with this kind of problems is to install Eclim and use that instead of syntastic.  There is no way syntastic will ever compete to Eclipse.
Sorry, but no.

hi @Scuilion same issue as yours

@wsdjeg Syntastic supports external checkers.  One way to do what you want is to copy the existing checker elsewhere, apply the patch in the PR, and use it as an external checker.  Another way is to have mnore people express interest in this, and persuade me to merge the PR. :)


chore(main): release 2.7.0

:robot: I have created a release beep boop
2.7.0 (2024-02-21)
Features

restart: display confirmation prompt when restarting the game (005497f)
restart: remove win title when the restart prompt is active (dbc4c7e)

Preview

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/NStefan002/2048.nvim/releases/tag/v2.7.0 :sunflower:


python2: No such file or directory

When i clone repo and run ./install.py show me error!

how can i fix this?

Hi @sajadabedi, I just made this change: https://github.com/milkbikis/powerline-shell/commit/b9845c56f3aa62cd2c6f42a914985f1bc3ff148d
This should solve the issue for you. Let me know if you run into anything else.


Remove isAddingOperationIds

After #83, isAddingOperationIds brings very little value since we no longer have to generate a custom extension to set id on Request.
I think it's just easier to remove the flag and always set the id on the Request if !operationId.isEmpty?
Are there any reasons not to do this?

I believe this was the consensus from #42.

Ah yes thanks for that, I forgot 😄


Pull Observability Operator objects from separate location

Pull manifests from a separate location
Feature Request
Background
The Observability operator will be installed by default on OpenShift Dedicated clusters. We want to leverage the operator to monitor ISV metrics, however, there is still a need to configure the operator for a given ISV in the form of ServiceMonitors and PrometheusRules. Given that each ISV will have specific criteria from which to trigger alerts, record metrics, etc, we need a more automated form of configuration for the operator.
Description of proposed solution
Considering that users of this operator could exist in disconnected environments, we see two potential/necessary solutions for this problem.  Adding the ability to pull manifests/objects from a remote url (manifestURL), and the ability to pull config from a secret or configmap.
The Kafka Observability Operator for reference. https://github.com/redhat-developer/observability-operator
Motivation
Low maintenance, repeatable configuration on OpenShift Dedicated environments.
thanks for the consideration

My first instinct is to say that it's a configuration management issue which is a bit away from the Observability Operator goals. I guess that each ISV will have to configure resources other than monitoring anyway?

@simonpasquier I hear you when you say config management issue, and I respectfully agree that maybe the Observability Operator shouldn't or does not care about the way in which it is configured, however, i think this transcends the scope of being just being a config management issue and could add a lot of value on top of the already very powerful Observability Operator by providing more flexibility, efficiency and deployment options when working on disconnected or even OSD environments.
Let's think of a common use-case - monitor a specific app, configure alerts for the app, and configure the alerts to trigger a page (say from PagerDuty) when something goes wrong. This would involve ServiceMonitors to scrape the app itself, another ServiceMonitor to federate cluster style metrics (say from openshift-monitoring), the PrometheusRules from which to trigger alerts, an AlertManagerConfig with credentials to send alert to PagerDuty, the remoteWrite info if you are sending your metrics to Observatorium or another prometheus, and necessary RBAC required to achieve these pieces.
We know this flow well and can attest that it does work very well indeed. However, this is a lot of steps. Imagine being able to replicate this process by supplying a manifestURL, or secret/configmap from which to obtain manifests to ultimately configure the Observability Operator. You still have a clean infrastructure-as-code style operator but now configuration can be consolidated essentially to just one step.
This could also lower the barrier of entry and democratize usage the Observability Operator. Even a more unexperienced engineer to monitoring would be able to point the Observability Operator spec to a manifestURL or secret that has been pre-populated with the manifests created by a platform operator or SRE style engineer.
To answer your last questions with regards to each ISV will have to configure resources other than monitoring anyway- that is the motivation for feature-request.  Each ISV will have a specific configuration to support monitoring of their given apps.
Thanks for the consideration and sorry for the long read. Just a thought though, do you think this would add value @simonpasquier? Or would this be more entirely out of scope?

To answer your last questions with regards to each ISV will have to configure resources other than monitoring anyway- that is the motivation for feature-request. Each ISV will have a specific configuration to support monitoring of their given apps.

My comment was more that ISV may have to configure resources other than monitoring (deployments? services?). If the answer is "no we only ever need to configure monitoring resources for ISV" then yes it might make sense for OBO to grow this capability but if the answer is "yes ISVs will have to deploy other kubernetes resources not related to monitoring" then you'd need something else anyway.
Assuming that we go this path, OBO would need to get additional permissions to create/update/delete monitoring resources. And we need to think about the full lifecycle:

how do you remove a resource?
how do you provision secrets?

To be clear, I'm not saying that OBO isn't the right tool here but I want to make sure that we evaluate carefully the consequences/options :)

Yes, these are all extremely valid points, @simonpasquier. Let's put this on hold for now. I may close this ticket. It seems like it may not be needed in the end for our team. Thank you!

As you like but we can definitely discuss it during one of the projet's office hours :)

@redmikhail


Move overview

In this PR I am streamlining the home page content by

Moving package usage  content from the home page to the quickstart.
Using tabs for installation instruction
Wrap disclaimer into a warning admonition

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.78%. Comparing base (32132b1) to head (f81582c).
Report is 284 commits behind head on development.

:exclamation:  There is a different number of reports uploaded between BASE (32132b1) and HEAD (f81582c). Click for more details.
HEAD has 8 uploads less than BASE

Flag
BASE (32132b1)
HEAD (f81582c)

9
1

Additional details and impacted files
@@               Coverage Diff                @@
##           development     #227       +/-   ##
================================================
- Coverage        97.30%   75.78%   -21.52%
================================================
  Files               18       24        +6
  Lines             1669     2358      +689
================================================
+ Hits              1624     1787      +163
- Misses              45      571      +526

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

position or spike counts

I don't know if I would remove that, it is very important to understand the basis object. We may refer to this modes of operation in the subsequent examples more explicitly to improve the flow of the description

Addressed all concerns


Warning: EmailInput is changing an uncontrolled input of type email to be controlled.

Hello,
i am getting this answer when entering an email in the example form (My Awesome Form). Can you help me here?
Thanks in advance

Hi @JD2k this issue should be resolved in the next release. I'll get to this now.

@JD2k Released in 1.1.1.


chore(functions): Fix flaky pubsub test, take 3

Increasing the retry count + throwing a few things at a wall (bash -c + printing to stderr) and seeing what sticks.

Note - approved, but you should get someone to test it on Windows.


Exception of type 'PnP.PowerShell.Commands.Model.Teams.GraphException' was thrown

Hi Team,
Having an issue with my Cx on step 2 when trying to create Azure AD Apps with provided cmdlet from documentation :
Initialize-PnPPowerShellAuthentication -ApplicationName ModernizationScannerApp -Tenant mycustomer.onmicrosoft.com -Scopes "SPO.Sites.FullControl.All","MSGraph.Group.Read.All"  -OutPath c:\temp -CertificatePassword (ConvertTo-SecureString -String "password" -AsPlainText -Force)
Result :
Initialize-PnPPowerShellAuthentication : Exception of type 'PnP.PowerShell.Commands.Model.Teams.GraphException' was thrown.
At line:1 char:1

Initialize-PnPPowerShellAuthentication -ApplicationName Modernization ...

CategoryInfo : NotSpecified: (:) [Initialize-PnPPowerShellAuthentication], GraphException
FullyQualifiedErrorId : PnP.PowerShell.Commands.Model.Teams.GraphException,PnP.PowerShell.Commands.Base.InitializePowerShellAut
hentication

Could you help me ?
Many thanks

Hello, can you do a Get-PnPException after the error is thrown and paste the stack trace here ?

For sure !
PS C:\Users\XXXXX> Get-PnPException
CorrelationId :
TimeStampUtc : 1/1/0001 12:00:00 AM
Message : Exception of type 'PnP.PowerShell.Commands.Model.Teams.GraphException' was thrown.
Stacktrace : at PnP.PowerShell.Commands.Utilities.REST.GraphHelper.d__14.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at PnP.PowerShell.Commands.Utilities.REST.GraphHelper.d__111.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at PnP.PowerShell.Commands.Utilities.REST.GraphHelper.<PostAsync>d__71.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at PnP.PowerShell.Commands.Base.InitializePowerShellAuthentication.ProcessRecord()
at System.Management.Automation.CommandProcessor.ProcessRecord()
ScriptLineNumber : 1

Hi Team ! Any update on this issue ?

Hey @JulienValentin78, have fixed it. Please give it a try tomorrow and let us know how it goes !
Thanks for reporting !


Intermittently, prefix information isn't fully returned from "ot-ctl prefix" CLI command

Describe the bug A clear and concise description of what the bug is.
When using the CLI command "ot-ctl prefix", I have noticed that intermittently, I am lacking some of the information, as shown in this example where I have 3 prefixes configured.  Intermittently, I lose the first part of the information for the first prefix.  It seems to come and go.
pi@rpi1:~ $ sudo ot-ctl prefix
fdde:ad00:dead:beef::/64 paros med
fdde:ad03:0:0::/64 paros med
2001:22:0:0::/64 paros med
Done
pi@rpi1:~ $ sudo ot-ctl prefix
paros med
fdde:ad03:0:0::/64 paros med
2001:22:0:0::/64 paros med
Done
pi@rpi1:~ $ sudo ot-ctl prefix
paros med
fdde:ad03:0:0::/64 paros med
2001:22:0:0::/64 paros med
Done
pi@rpi1:~ $ sudo ot-ctl prefix
fdde:ad00:dead:beef::/64 paros med
fdde:ad03:0:0::/64 paros med
2001:22:0:0::/64 paros med
Done
pi@rpi1:~ $

To Reproduce Information to reproduce the behavior, including:
I formed a thread network (of just the 1 node) using:

ot-ctl channel 11
ot-ctl networkname SilabsOpenThread
ot-ctl panid 0xABCD
ot-ctl extpanid DEAD00BEEF00CAFE
ot-ctl masterkey<PHONE_NUMBER>5566778899AABBCCDDEEEE
ot-ctl ifconfig up
ot-ctl thread start

I verified the OTBR was in state "leader"
I added 3 prefixes to my OTBR:

ot-ctl prefix add fdde:ad00:dead:beef::/64 paros med
ot-ctl prefix add fdde:ad03::/64 paros med
ot-ctl prefix add 2001:22::/64 paros med

I used the command "ot-ctl prefix" to view the configured prefixes multiple times and received differing results from each execution of the command.
1.  IEEE 802.15.4 hardware platform

Silabs BRD4161A

3. Build steps

git clone https://github.com/openthread/ot-br-posix
./script/bootstrap
NETWORK_MANAGER=0 ./script/setup
Verified my device was using ttyACM0
Configured /etc/default/otbr-agent with OTBR_AGENT_OPTS="-I wpan0 spinel+hdlc+uart:///dev/ttyACM0"
Built an RCP for my device

4. Network topology

Just the 1 device

Expected behavior A clear and concise description of what you expected to happen.

I think I should be getting a more consistent response from this CLI command.  Ideally the one with all 3 prefixes fully represented.

Console/log output If applicable, add console/log output to help explain your problem.

See above

@JaneFromSilabs @gabekassel , just merged https://github.com/openthread/openthread/pull/5087, which should resolve this issue.

Hi @jwhui ,
I believe this is still failing for me, at least in the non-interactive mode.  The interactive mode is working just fine.  I am at:
pi@rpi1:~/ot-br-posix $ git show commit 591cfebbe1a337f84bc2549505e2fc42886ab4a6 Author: Yakun Xu<EMAIL_ADDRESS>Date:   Wed Jun 10 01:51:22 2020 +0800
Is this expected behavior if you are not interactive?

@JaneFromSilabs , note that https://github.com/openthread/openthread/pull/5087 is a different repo and is a submodule of this repo. Can you ensure that third_party/openthread is up-to-date?
git submodule update --recurisve --depth 1

@jwhui , that worked, thank you!  Have a great weekend.  ~jane

@jwhui , that worked, thank you! Have a great weekend. ~jane

@JaneFromSilabs , great to hear!


Markers cannot have HTML content as child

If you insert HTML content, e.g. a
 element within a Marker, you will only get [object HTMLParagraphElement] instead of the HTML content. I haven't found any workaround to this. A custom component doesn't work either inside a Marker. Only text content seems to work.
          <Show when={locs()}>
            <For each={locs()}>{(loc, i) =>
              <Marker lngLat={loc.geometry?.coordinates} options={{ color: 'red' }}>

{loc.properties.osm_tags?.name}

              </Marker>
            }</For>
          </Show>

The above example renders [object HTMLParagraphElement] to the Markers.
Any ideas? Thanks.

Workaround that actually works until the Marker component gets fixed:
let m = new maplibregl.Marker({color: 'yellow'});
    m.setPopup(new maplibregl.Popup().setHTML("
Hello World!
"));
    m.setLngLat(markerLoc).addTo(mapContext.map);

Thanks for reporting this issue. Fixed in the latest version.


Add dirty/pristine state to form fields

I was looking for a way to show/enable a save button only if the user had actually modified a field instead of tabbing to the field. Most of the changes are the same as the code in setTouched to make sure all the appropriate validation happens

Try out https://joepuzzo.github.io/informed. I rewrote this library and will now be supporting informed instead. It has dirty and pristine at the form level


Hide "New" characters on "Swap character" popup

Hm this is honestly the main way I add characters. Not sure about others. I almost never go to the character index page

Hm this is honestly the main way I add characters. Not sure about others. I almost never go to the character index page

Maybe just an option to "hide" them like Seelie has?

Unrequired with latest change to character selector popup


Unwanted  tags

When I run UniHTML.purify('text \n text2') I get "text text2", but when I run UniHTML.purify('text \n\n text2') I get this instead:

    text

    text2

Is this a bug? How can I keep both \n and avoid the
 tags?

Hello,
Sorry for long time to respond.
Pass flag "noTextManhandle : true" in options.
This should skip a text processing like clearing whitespace including ''n'


Restrict minimum interval of password reset

Reusable apps and AUTH_USER_MODEL

Reusable apps shouldn’t implement a custom user model. A project may use many apps, and two reusable apps that implemented a custom user model couldn’t be used together.

signal:

https://docs.djangoproject.com/en/4.1/topics/signals/
https://docs.djangoproject.com/en/4.1/ref/signals/#pre-save


Create form object onto which question pages are placed

I dont think this would need to be editable in admin. Maybe it'll be view only

one huge advantage is that then we can possibly rewrite the wizard to be a DetailView subclass for Form


improve mechanism inside invocation rule

This improves the mechanism inside the invocation rule to check if all tasks are
completed.
Some temp variables are removed away, and it should check the task status in each loop,
to return the result when it is the right condition.
This enhance readability and the performance a little.

Thanks @xiekeyang - LGTM!


Amend GOVUK.stickAtTopWhenScrolling to "unstick" for smaller screens

For smaller screens (<768px) ensure that the element which was previously "stuck" is "unstuck",  (removing both the class which sets fixed positioning and the shim).
This PR adds mocks for the window scroll position, offset of the sticky element and the window dimensions and updates stickAtTopWhenScrolling to use these.
It adds new tests to ensure that the three conditions of checkScroll are met, to "stick" or "unstick (release)" a sticky element.
Tests:

Is there somewhere I can test this in a browser?

@nickcolley I'm going to duplicate this over in service-manual-frontend to test it works as expected, I'll let you know when it's possible to preview.

Hi @nickcolley, there's a branch for service-manual-frontend that demos this.

Stick at top when scrolling:

Release on resize (smaller than 768px):

A little pedantic, but stick-at-top-when-scrolling.js could do with some love in terms of consistent spacing around control structures and function definitions. For example, there's a mix of if(...){, if (...){, and if (...) { and there's a mix of function () {, function() { and function(){…

Yeah we're trying to avoid specific conversations around syntax and rather focus on bringing project linting across the whole repo (https://github.com/alphagov/govuk_frontend_toolkit/pull/334)

I’m happy with the code and approach. If someone else (@36degrees?) could OK the behaviour then I’m fine with it being merged.

Had a play with it and it seems to work as expected. Good stuff!
There are a few really picky edge cases:

If you scroll really quickly to e.g. the top of the document it doesn't quite keep up and you can end up with the wrong thing highlighted.
If you have a very short section at the end of your document it'll never become active as the previous heading doesn't leave the screen. This is especially odd if you click the heading to scroll down as the previous link becomes active instead.

However I think those really are edge cases and I'd be happy for this to go out as is.

Hi @36degrees, thanks!
We might want to keep those comments with the HighlightActiveSection JS - over here.
This PR is amending the "unsticking" (removing the position:fixed set for a sticky element) by checking on resize to see if the sticky element needs to be unstuck for smaller screens.
This is to avoid the situation where the page content on the right overlaps the fixed position nav on the left, before the viewport is narrow enough to collapse to a single column layout.

If you're happy to merge this - then I'll bump the version of the frontend toolkit in a separate PR, so we can pull these changes into service manual frontend.

Sorry, yes. I knew that wasn't part of these changes, yet still commented here. I blame my weary Friday brain.

I'm going to go ahead and merge as @36degrees doesn't have permission to merge this.


StyleKeyOverride should have a defaut value to parent control type

An example more than hundred words.
I am create a control that heritate from another control (i.e. ContentControl) and I don't plan to modify the style, I just want to add properties or tweak somethings.
without protected override Type StyleKeyOverride => typeof(ContentControl); the new control is not displayed in the UI.
Don't you think it would be more useful to use the parent control theme by default, instead of nothing? when no theme is provided/required.

That's a really good question. We have no real idea how to handle this. There are several ideas:

provide a minimal control template
use parent
throw an exception?
throw a warning?

The biggest issue is, you will have to maintain it and there will be edge-cases where this is not whished or even harmful. So it's probably not easy as one thinks in the first step.

Today our customer encountered an opposite issue😂.
Window on the other hand has a fixed stylekey, which means any inheritance will use Window as stylekey by default. His custom template will never be applied until explicitly setting stylekey to itself which is a really weird behaviour.

okay, interesting. Still a message or any kind of exception would be useful. "No Style found, fix it / import it". We have this kind of question often for DataGrid for example.

I think it's enough to add an analyzer that signals the problem.


TabControl styling not completely possible

Issue
Between the TabStrip and TabContent of the TabControl there is a line of 4 pixels which cannot be removed, the gap exists in both the light and dark theme.
Thing tried to fix the issue

Setting the margin and padding to 0 on TabControl and all TabItem
Using different style selectors to try and target the element with the 4 pixel top margin
TabControl > Border > DockPanel /template/ ContentPresenter#PART_SelectedContentHost
TabControl DockPanel /template/ ContentPresenter#PART_SelectedContentHost
DockPanel /template/ ContentPresenter#PART_SelectedContentHost
DockPanel /template/ ContentPresenter

But non of the options with success.
Visually on the tab control in the documentation it does not have any gap: http://avaloniaui.net/docs/controls/tabcontrol
Visual example of the Gap under TabItems in the TabStrip

As you can see on the picture, there is a 4 pixel gap under the gray tab item, as confirmed by the Visual Tree, however the styling does not allow for this value to be changed.
It might be me that has overseen something, however i would appreciate any options to try an fix this.
It is minor, but nevertheless style breaking.

The default theme specifies the padding for different values of TapStripPlacement: you can override it by providing a selector that is as specific (or more) specific, e.g. what I did was:
<Style Selector="TabControl[TabStripPlacement=Bottom]">
  <!-- Override styled behaviour -->
  <Setter Property="Padding" Value="0"/>
</Style>

Naturally, this needs to be qualified for each position, as the theme qualifies it for each position in order to place the padding on the correct edge of the tab control: https://github.com/AvaloniaUI/Avalonia/blob/master/src/Avalonia.Themes.Default/TabControl.xaml.

Thank you, That worked perfectly. 👍
I knew i was missing something obvious. :-)


fix: conflicting options now properly override each other

Found this bug by looking at @ariporad's branch here. Credit for finding this goes to him.
I added a unit test for it, and sure enough, the unit test won't pass unless this patch is applied.

LGTM!


Should we store default values for properties or access the defaults on the fly?

for now we store default, but I think it would be memory-efficient to just call them on the fly. to be discussed. @khsrali @GeigerJ2

We don't store the default, this are initialised within the pydantic models


unsafe:javascript:; multiselect (select2) breaks in strict Content Security Policy apps,

Description:
multiselect (select2) breaks in strict Content Security Policy apps.
I'm using select2 theme of UI-SELECT with multiselect option. When i close selected item, it makes an browser to show alert message.  related to this commit
I don't have plunker url, since we can not define strict content policy in plunker:
Angularjs1.7, UI-Select 0.18, and Select2 CSS

I have the same Issue after upgrading AngularJs .
But i found an solution:
https://anotherdevblog.com/2018/06/27/angularjs-adds-unsafe-before-links/
You only need to allow "javascript" Protocol to href elements.
angular.module("app", [])     .config(['$compileProvider', function ($compileProvider) {         $compileProvider.aHrefSanitizationWhitelist(/^\s*(https?|ftp|mailto|javascript):/); }]);


Tentative fix for a memory leak in fast_sequence.hxx

The issue is described in #437.

I will close and reopen to trigger a rebuild by travis ...


Squig pileup region error

Hello,
I am attempting to generate a signal to reference pileup using the following command:
REF=../linear_amplicon.fasta
ALIGNMENT=02_MHhal_squig_align.bam
OUTPUT_DIR=02_pileup
REGION=pSHNJXXX_Linear_-_pOSIP:34-110
squigualiser plot_pileup -f ${REF} -s ../signals.blow5 -a ${ALIGNMENT} -o ${OUTPUT_DIR} --region ${REGION} --tag_name "pileup"
The pileup is successfully generated when I use any region between 1-30, however anything over 30 and I receive an error message (attached at the bottom) e.g. 1-31, 30-60 etc.
I receive the same error message when running the command on my other data set too...

Many thanks,
Katie.

Hi @katiestoker,
Can you do a quick test separately by downloading the prebuilt executable (linux or macos) and running it on the given sample dataset?
The commands are available here
Thank you!

Hello,
I gave it a go and everything worked fine on the executable with the test data...
I tried running my own data here too but received a key error message again:

Thanks!

Hello,
Really sorry for the trouble. Can you please upload a minimal dataset with the commands you ran so that I can reproduce the error? It makes easy for me to debug.
Thank you.

Hello,
Yes I have attached the files below...
BAM file:
02_MHhal_squig_align.zip
Reference:
linear_amplicon.zip
Blow5 subset:
https://drive.google.com/file/d/1mJnZWlJ1LW87LR98np6s72ESMgavfxj-/view?usp=sharing
The commands I ran are as follows:
REF=linear_amplicon.fasta
MAP_SAM=mapped_02_MHhal.sam
mapped_02_MHhaI.zip
FASTQ=02_MHhal_filtered.fastq
02_MHhaI_filtered.zip
minimap2 -ax map-ont ${REF} ${FASTQ} -t8 --secondary=no -o ${MAP_SAM}
SIGNAL=signals.blow5 (the full dataset merged blow5 file)
f5c index ${FASTQ} --slow5 ${SIGNAL}
ALIGNMENT=02_MHhal_squig_align.bam
f5c eventalign -b mapped_02_MHhal.bam -r ${FASTQ} -g ${REF} --slow5 ${SIGNAL} -a -o 02_squig_eventalign.sam
samtools sort 02_squig_eventalign.sam -o ${ALIGNMENT}
samtools index ${ALIGNMENT}
squigualiser plot_pileup -f ${REF} -s ${SIGNAL_FILE} -a ${ALIGNMENT} -o ${OUTPUT_DIR} --region ${REGION} --tag_name "pileup"
Apologies for the long comment!
Thanks for the help.
Katie.

Hi Katie,
The issue is with the reference file I guess. It has both lower and upper case bases. When I replace all with upper case it worked for. Is there a valid reason to have a mix of cases?

Hello,
After changing this it has worked!
I seem to have checked for this issue in the SAM file rather than the reference file...
This is a mistake in the formatting, no valid reason for mix of cases.
Thanks for all your help.
All the best,
Katie.

Great!
I will take a look at the pipeline scripts too!
Thanks again for the help! (:


Initializing js/ts features Causes Application to hang

Issue Type: Performance Issue
Upon opening VS Code, JS/TS Features are initialized. This causes the Application to grind to a halt. I am not even using Typescript and I'm still forced to wait for this.
VS Code version: Code 1.43.1 (fe22a9645b44368865c0ba92e2fb881ff1afce94, 2020-03-18T07:17:38.324Z)
OS version: Linux x64 5.3.0-42-generic

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz (4 x 3306)

GPU Status
2d_canvas: unavailable_softwareflash_3d: unavailable_offflash_stage3d: unavailable_offflash_stage3d_baseline: unavailable_offgpu_compositing: unavailable_offmultiple_raster_threads: enabled_onoop_rasterization: unavailable_offprotected_video_decode: unavailable_offrasterization: unavailable_offskia_renderer: disabled_off_okvideo_decode: unavailable_offviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabled_readbackwebgl2: unavailable_off

Load (avg)
3, 1, 0

Memory (System)
15.58GB (8.92GB free)

Process Argv
--no-sandbox --unity-launch

Screen Reader
no

VM
0%

Process Info
CPU %	Mem MB	   PID	Process
    0	   112	 18228	code main
    0	    32	 18232	   zygote
    0	   112	 18272	   gpu-process
    0	    48	 18284	   utility
    0	   112	 18496	   shared-process
    0	     0	 18893	     /bin/sh -c /bin/ps -ax -o pid=,ppid=,pcpu=,pmem=,command=
    0	     0	 18894	       /bin/ps -ax -o pid=,ppid=,pcpu=,pmem=,command=
    1	   255	 18612	   window (server.js - tasteslikehome - Visual Studio Code)
    0	   223	 18634	     extensionHost
    0	    80	 18707	       electron_node tsserver.js
   35	   144	 18708	       electron_node tsserver.js
    0	    80	 18776	         electron_node typingsInstaller.js typesMap.js
    0	    96	 18744	       electron_node eslintServer.js
    0	     0	 18642	     /bin/bash
   26	   303	 18847	       npm
    0	    48	 18689	     watcherService
    0	    48	 18706	     searchService
    0	    96	 18873	   window (Issue Reporter)

Extensions (17)

Extension
Author (truncated)
Version

jsrefactor
cms
2.20.5

bracket-pair-colorizer
Coe
1.0.61

vscode-eslint
dba
2.1.1

es7-react-js-snippets
dsz
2.7.0

vscode-html-css
ecm
0.2.3

vscode-great-icons
emm
2.1.47

prettier-vscode
esb
3.20.0

php-debug
fel
1.13.0

php-intellisense
fel
2.3.14

php-pack
fel
1.0.2

auto-rename-tag
for
0.1.1

python
ms-
2020.3.69010

vsliveshare
ms-
1.0.1783

LiveServer
rit
5.6.1

open-in-browser
tec
2.0.0

vscodeintellicode
Vis
1.2.6

vscode-icons
vsc
10.0.0

What exactly doesn't work while you see the progress indicator? It only indicates that the typescript server that powers both JavaScript and TypeScript language features is initializing (it is run its own process so it doesn't block VS Code)

Well I can tell you that it is blocking VS Code from running. I can't do anything while that is running. Oftentimes it takes about 3-5 minutes to complete. Sometimes less, sometimes more.

But what does "can't do anything mean"? Does it not respond to any input?

Also does this reproduce with all extensions disabled?

Ahh. Seems I may have spoken prematurely. Seems to not block actual functionality (browsing to various site files, etc). But won’t allow you to install any node packages until VS Code has completed the task in question. Is that expected? Haven’t had a chance to disable all extensions.

No, it should not block that. How are you installing node packages?

I use NPM so... npm i <package name>

Do you see an error during the install? Please also test with extensions disabled to make sure one of them isn't causing this

Negative. No error seen. App just hangs while that task runs/completes.
My Repo Steps

Open VS Code
JS/TS Features are initialized
Install a node package in a project via npm i abcPackage
App hangs until JS/TS Features task is complete

I'll try and test with extensions disabled and report back.

Did you see this after disabling extensions?

Can you please collect the TS Server log from when this happens:

Set "typescript.tsserver.log": "verbose",
Restart VS Code and reproduce the problem
In VS Code, run the TypeScript: Open TS Server log command
This should open a large log file called tsserver.log

If you can share the log, I can take a look to see if anything stands out that would explain this

⚠Warning: The TypeScript log may include information from your workspace, including file paths and source code. If you have any concerns about posting this publicly on Github, just let me know and we can arrange something else. On our side, we only use these logs to investigate issues like this

I have the same problem. Vanilla es6 code (no typescript). Webpack & babel.
After "Initializing JS/TS language features" completes, intellisense works (f12/cmd+click, hover over imports etc).  The BIG problem however is, while "Initializing JS/TS language features" you can't even save a file (it gets put on the queue).
I REALLY want to use VS Code but this is a non-starter for me.
jsconfig.json
{
  "compilerOptions": {
    "target": "esnext",
    "module": "esnext",
    "experimentalDecorators": true,
    "moduleResolution": "node",
    "jsx": "react",
    "checkJs": false,
    "baseUrl": "./",
    "paths": {
      // lots of entries here
      "SomeImport": [
        "/full/path/to/SomeImport.js"
      ],
    }
  },
  "exclude": [
    "build",
    "node_modules",
    "native_asset",
    "native_helpers",
    "node_modules_static_ext",
    "webpack_loaders",
    "webpack_plugins",
    "webpack_tools",
    "asset",
    "electron",
    "native_v2"
  ]
}

@mjbvz did you mean "typescript.tsserver.trace": "verbose"?  Also I don't see TypeScript: Open TS Server log command as a command option:

If I use "typescript.tsserver.trace": "verbose" and open the Output console (and choose typescript in the dropdown) I get lots of output.
Here is the log output - note the "Request took 63321 ms" - it is typically longer :(
The only extensions I have installed:

@rynop Split your issue into #94943

Hi Matt -
Here's the latest results.
tsserver.log


Add Red/Black conditional formatting

Add conditional formatting that shows negative numbers in red, positive in black

@paddymul can you please assign this

Look at https://github.com/paddymul/buckaroo/blob/main/example-notebooks/styling-gallery.ipynb
Fixed by https://github.com/paddymul/buckaroo/pull/201 for release 0.6.1


changing endpoint for this portfolio site

Issue-Type: Suggestion
Thanks for finding this amazing template!

I believe this site should not be on /me endpoint but on /

Yeah but how do you fix it ?
I could create a repo with name oke-aditya.github.io but that will not allow me to use CI CD pipeline.
Plus I have URL shortener for this as bit.ly/oke_aditya (which is what people will use)
The endpoint I don't find a solution, do let me know if you have one.

we can't set CI CD pipeline with username.github.io?
URL shortener or using the domain name is always an option, but when we visit someones GitHub the first URL that's hit is username.github.io usually, maybe then a redirect can be added to there.

create index.html file
add this inside script window.location.replace("http://www.w3schools.com");

Also what CI CD pipelines are you using?

Since Jekyll build and run is run over GitHub, the site is built over github pages in gh-pages branch where I don't even push.
I don't push the site to master as you see.
I possibility is to setup username.github.io and add a CNAME to redirect to /me so both point same.


fetch_refspecs: Use dulwich for ssh urls.

Using pygit2 was causing https://github.com/iterative/dvc/issues/9080

This is ok as a workaround until we handle libgit2/pygit2 auth callbacks properly

Opened https://github.com/iterative/scmrepo/issues/197

Just manually installed the 0.1.13 release with dvc=2.45.1, and these changes appear to resolve https://github.com/iterative/dvc/issues/9080 for me! Thank you, all, for the quick response on this!


Exclude PR's from certain users?

It would be just dandy if there was a method (maybe I'm missing something) to filter the PR's so that I can exclude PR's from certain users (i.e., myself, as the main contributor to my project).
I'm mostly interested in displaying PR's that came from outside the maintainers. Mostly because if I include all of the PR's, the changelog is HUGE. But I want to make sure that we maintain in the changelog some credit for the other folks who submitted something :)

I'm a user of the rake variant of this tool. There, it's a bit easier to add functionality, since lambdas etc could be placed there, with, say "additional filtering".
How do you configure the tool?

I'm typing this on a phone. It doesn't come out very clearly.
Implementing new things is easier when ignoring CLI options. Like, you know, the hard part.

Right now, I have the gem installed locally and I just run the command with parameters (because we haven't released the software that is going to be using it, so I'm quite open to ideas).
We do our releases via github releases via Travis, so I had toyed with the idea of having Travis automatically run this, but it becomes a bit of a race condition due to the tags (the release is kicked off when Travis sees a tag).
That said, there's no reason I couldn't switch to using the rake variant.

💥 Experiment hint ahead: 📖
Ruby has open classes. You can override stuff, for fun and learning.
This Ruby method fetches issues and PRs from the API:
https://github.com/skywinder/github-changelog-generator/blob/bcacabcf5fca8eeaba7624b7f5551c9d92244b41/lib/github_changelog_generator/generator/generator.rb#L27-L36
You override it, and it could also call an additional proc which could filter your stuff.


README.md

please change go-cpe-dictionary command.
before:
$ go-cpe-dictionary fetch
after:
$ go-cpe-dictionary fetchnvd

@miyaimin
Thanks.
Would you please send a pull request :)


[nerdctl build] Set default output type=image

PR Description
Linked Issue: containerd/nerdctl#3629
This PR resolves #3629 for nerdctl build command when passed with:

--progress auto, --progress tty, or --progress flag is not specified (which then defaults to --progress auto)
--output flag is not specified

Example:
nerdctl build -t <TAG> --file .\Dockerfile .
Background
The issue occurs because the build progress output and the tarball are both sent to stdout on WIndows.
Solution
https://github.com/containerd/nerdctl/blob/0d7dc8ec4cda815acfca165b0281e801c4c5ef6e/pkg/cmd/builder/build.go#L216
When a user does not specify the --output flag, we default it to use type=image instead of type=docker because the image is actually uploaded to containerd image store. According to buildctl documentation, type=image is the native type for containerd.
Additional tasks

Only use the default image name when user has not specified one

Not included in this PR

When default type=oci
https://github.com/containerd/nerdctl/blob/0d7dc8ec4cda815acfca165b0281e801c4c5ef6e/pkg/cmd/builder/build.go#L220
type=docker
Currenly fails with archive/tar: invalid tar header moby/buildkit/issues/5528

References

buildctl output: containerd image store

I need to Wotk through this later, but I'm unclear how the current code works on non-Windows. How do those platforms distinguish a tar file from log output on stdout? They shouldn't be passing through a termInal on the way, the terminal is where nerdctl's stdio is connected, so I don't understand what's different on Windows.

Hey @TinaMor
I’ll have a look later today.
Curious too.

Deeply confused about this.

Why are the build output and tarball all going to the same location on Windows alone?

This does not make any sense.
I am squinting at nerdctl source and cannot figure it out.
Now suspecting buildctl might be the problem.

buildctl "output" goes to stderr.
Is it the case on windows?
foo="$(buildctl --addr=unix:///run/user/501/buildkit/buildkitd.sock build --progress=auto --frontend=dockerfile.v0 --local=context=/tmp/ --output=type=docker --local=dockerfile=/tmp --opt=filename=Dockerfile)"
or
buildctl --addr=unix:///run/user/501/buildkit/buildkitd.sock build --progress=auto --frontend=dockerfile.v0 --local=context=/tmp/ --output=type=docker --local=dockerfile=/tmp --opt=filename=Dockerfile >/dev/null

Following the buildctl documentation on using output, I run the buildctl commands for each.

Docker tarball
& "C:\Program Files\Buildkit\bin\buildctl.exe" `
    --addr=npipe:////./pipe/buildkitd `
    build `
    --progress=auto `
    --frontend=dockerfile.v0 `
    --local=context=. `
    --output=type=docker,name=docker.io/library/iis-server3:latest `
    --local=dockerfile=C:/Users/xxxxx `
    --opt=filename=Dockerfile

error: invalid output option: output: output file is required for docker exporter. refusing to write to console

OCI tarball
& "C:\Program Files\Buildkit\bin\buildctl.exe" `
    --addr=npipe:////./pipe/buildkitd `
    build `
    --progress=auto `
    --frontend=dockerfile.v0 `
    --local=context=. `
    --output=type=oci,dest=C:/Users/xxxxx/AppData/Local/Temp/output.tar,name=docker.io/library/iis-server2:latest `
    --local=dockerfile=C:/Users/xxxxx `
    --opt=filename=Dockerfile

[+] Building 2.4s (7/7) FINISHED
=> [internal] load build definition from Dockerfile                                                                                0.0s
=> => transferring dockerfile: 78B                                                                                0.0s
=> [internal] load metadata for docker.io/library/hello-world:latest                                                                       2.0s
=> [auth] library/hello-world:pull token for registry-1.docker.io                                                                          0.0s
=> [internal] load .dockerignore                                                                                0.0s
=> => transferring context: 122B                                                                                0.0s
=> [1/2] FROM docker.io/library/hello-world:latest@sha256:d211f485f2dd1dee407a80973c8f129f00d54604d2c90732e8e320e5038a0348                 0.1s
=> => resolve docker.io/library/hello-world:latest@sha256:d211f485f2dd1dee407a80973c8f129f00d54604d2c90732e8e320e5038a0348                 0.1s
=> CACHED [2/2] RUN echo "hello"                                                                                0.0s
=> ERROR exporting to oci image format                                                                                0.1s
=> => exporting layers                                                                                0.0s
=> => exporting manifest sha256:312b0358bbc84f03b6c40493bba15d0eea0b586cf19c901c8c8e5731e8185daf                                           0.0s
=> => exporting config sha256:0ba713f119e7b225effacd8744c7ee9601c023586f39c71cc2044c3dbf994d57                                             0.0s
=> => sending tarball                                                                                0.0s
------
> exporting to oci image format:
------
error: failed to solve: failed to get reader: content digest sha256:4a74766ac776b275376a07d5357fd928f8b871c9e3d409729ed7e1ff0c1e608c: not found

containerd image store
& "C:\Program Files\Buildkit\bin\buildctl.exe" `
    --addr=npipe:////./pipe/buildkitd `
    build `
    --progress=auto `
    --frontend=dockerfile.v0 `
    --local=context=. `
    --output=type=image,name=docker.io/library/iis-server3:latest `
    --local=dockerfile=C:/Users/xxxxx `
    --opt=filename=Dockerfile

[+] Building 2.3s (7/7) FINISHED
=> [internal] load build definition from Dockerfile                                                                                0.0s
=> => transferring dockerfile: 78B                                                                                0.0s
=> [internal] load metadata for docker.io/library/hello-world:latest                                                                1.9s
=> [auth] library/hello-world:pull token for registry-1.docker.io                                                                   0.0s
=> [internal] load .dockerignore                                                                                0.0s
=> => transferring context: 122B                                                                                0.0s
=> [1/2] FROM docker.io/library/hello-world:latest@sha256:d211f485f2dd1dee407a80973c8f129f00d54604d2c90732e8e320e5038a0348          0.1s
=> => resolve docker.io/library/hello-world:latest@sha256:d211f485f2dd1dee407a80973c8f129f00d54604d2c90732e8e320e5038a0348          0.1s
=> CACHED [2/2] RUN echo "hello"                                                                                0.0s
=> exporting to image                                                                                0.0s
=> => exporting layers                                                                                0.0s
=> => exporting manifest sha256:967e0c72299274e2770111f97d1d05c9b139417e755d8464b9e336a55276b543                                    0.0s
=> => exporting config sha256:0ba713f119e7b225effacd8744c7ee9601c023586f39c71cc2044c3dbf994d57                                      0.0s
=> => naming to docker.io/library/iis-server3:latest

When a user does not specify the --output flag, we default it to use type=image instead of type=docker because the image is actually uploaded to containerd image store. According to buildctl documentation, type=image is the native type for containerd.

Does this introduce a requirement that buildkit is configured to use the containerd worker? Or is that already a requirement for using nerdctl build for other reasons?

@AkihiroSuda @jsturtevant

Does this introduce a requirement that buildkit is configured to use the containerd worker? Or is that already a requirement for using nerdctl build for other reasons?

Any ideas?

@TBBle In Windows, containerd-worker is the default. There is ongoing work to support oci-worker on Windows. On Linux environments, [oci-worker is the default].(https://github.com/moby/buildkit/blob/5cd5a63de5d37512c24f20085607509b749df762/README.md#linux-setup)
Additionally, with the shift from docker to containerd, we then should switch to using type=image instead of type=docker as the default.
References:

What is the difference between oci workers and containerd workers?
Docker vs. Containerd: Understanding the Shift in Kubernetes

The OCI worker still has to be supported


Nightly mode looks bit weird for header as the color is pink

I think more focus should be in  the content like shabad, or search results etc. So better we keep everything black and avoid pink

Yeah it's a problem with material-ui dependency. #52 will fix this.


Kill Zapier app

Acknowledging

That maintaining code for a feature always takes time (eg. tests need to be updated, bugs...)
That unmaintained features can contain security issues, or be a vector for privilege escalation
That the bigger/more complex the code base, the harder it is for newcomers to get on board

Data

Time since feature has been deployed: 1 year
Number of integrations: 12

Reasons to kill

Very few users
Not a good test coverage
There are alternatives: we're still supporting "regular" webhooks, so with a custom service (or a pro Zappier account) you can still have the same feature
It's hard to extend/update/maintain, because the implementation was not properly specified from the start: we are using a custom integration where adding a new endpoint requires a lot of work, while we should have worked with standard REST Webhooks from the start
The APP is still in "Beta", it's not listed publicly on Zapier and it requires a fair amount of work if we want to tackle that (and also, more users)
Zapier is a proprietary solution. We should focus on standards (RSS, webhooks).

Reasons not to kill

Some users may be attached to it

Migration strategy

[x] Remove ad on the webhooks page
[x] Send notice to users that we'll deprecate Zapier app in the next few months
[x] Remove the webhooks
[x] Remove the app from Zapier
[x] Archive the app repo

If we decide to go with this change, we need to properly inform the users and to give them a delay to transition out before we remove the feature.

The following query returns 19 entries:
SELECT c.slug, n.*
FROM "Notifications" n
INNER JOIN "Collectives" c ON n."CollectiveId" = c.id
WHERE "webhookUrl" LIKE 'https://hooks.zapier.com/hooks/%'

Since using Webhooks requires a pro zapier account, removing the app now would break the feature for these integrations. Having RSS feeds for expenses, members, etc. (https://github.com/opencollective/opencollective/issues/3504) could provide a better way to migrate these.

Old docs, in case anyone is curious before it goes away (or wants to adopt it 🤷 ): https://docs.opencollective.com/help/v/master/collectives/integrations

@betree if this is killed let's tell @shannondwray for updating docs.

I've updated all the docs already. I'm still waiting to move to the next steps as some people may still depend on the Zapper integration.

@BenJam That'd be really helpful!

Okay I'm contacting each collective with the following:

Hi
I'm writing to let you know that as of Friday 11th June we will no longer trigger events in the Zapier platform.
We launched our Zapier support in June 2019 and since then we have seen a small number of collectives configure the integration, including your own.
As a small team it's essential that we prioritise our time and resources to deliver the most value we can as a platform for our Hosts and their Collectives. Supporting features that aren't used is not an efective use of our time and as such we will deprecate features when we feel that the cost of maintianing them outweighs the benefit of doing so.
If you are actively using Zapier to automate parts of your process then we recommend you get in touch with us at<EMAIL_ADDRESS>and we will help you work through and changes you may need to make.
Thank you
Ben
Head of Product, Open Collective.

I'll send them to each of the collectives with a webhook configured now.

I've removed all hooks from our systems, will proceed with removing the app in the next few days

just logged in and it looks like all the zaps on the ops account are off. If there's another account I'm sure @Betree will pick this up when he returns form his holiday.

Yes, it's all done. We needed to wait a bit because Zapier forces you to deprecate your app ~2 weeks before it can be deleted entirely. I just removed the app, so Zapier is now gone for good.

Approved


better-onetab on addons.mozilla.com reports "Oops! We can’t find that page"

I installed it a day or 2 ago, but it is no longer available for Firefox.
Link I have tried https://addons.mozilla.org/en-US/firefox/addon/better-onetab/
Is this a problem you know of?

Closing as  i see someone else posted it just before me.


Implications of Server API (CGI) for HTTP Response Status-Line

This issue particularly concerns JIT, but I expect it may also apply to other parts of Symphony.
I set up a hiawatha webserver after seeing it recommended on the forum, and used FastCGI for PHP.

This webserver runs on Linux, BSD, MacOS X and Windows. Although it can run any kind of CGI / FastCGI application, it has been optimized for usage with PHP.

Cached JIT images were not behaving properly: depending on the web browser in use, JIT-processed images would either be reloaded or not show and be broken.
Michael replied to a post I made at the forum, pointing me to JIT's image.php file and code returning a 304 status.
Because the server API is CGI, the Status-Line needs to be sent as
header('Status: 304 Not Modified');

instead of
header('HTTP/1.1 304 Not Modified');

However, the CGI-style of Status-Line doesn't work for my local test webserver which has PHP running via the Apache module route: mod_php5 (the most common configuration).
Info
Apache module vs. CGI
CGI 1.1 spec: Status
PHP Header function parameters - see FastCGI note
Hugo Leisink on this issue as it occurred in DokuWiki:

Found the bug. It's in 'http_conditionalRequest()' in the file 'inc/httputils.php'. At line 56, there is a statement 'header('HTTP/1.0 304 Not Modified');'. This is not allowed in a CGI script. If a CGI script wants to change the status code of a HTTP response, it should us the Status CGI header. It's clear that the Dokuwiki follow the Apache standards instead of the official standards. You can fix this bug by changing that line into 'header("Status: 304");'. You should consider reporting it to the Dokuwiki developers.

I don't know about the technical/historical reasons for the difference, but it seems clear that both the Apache module and CGI configurations should be accounted for by Symphony.
Possible solution
Use this phpinfo_array function found in a comment in the PHP manual to detect the server API and send appropriate header accordingly.

Can you try header('x', false, 304); and see what effect that has?

@DavidOliver: Great research on this topic, thanks!
@brendo: I tried:
header('Status: 304 Not Modified', true, 304);

and it seems to work on my Debian Squeeze server running Apache and mod_php5.
However, I think that we should

take a look at how other PHP systems solved this
do more tests

BTW: @DavidOliver is right – it's not only JIT. There is also the "internal Symphony" way of setting headers: Page->addHeaderToPage.

Using the header function's optional parameters... a much better idea than messing with converting phpinfo output to make an array, etc.!
Good news: it seems to be working fine for both mod_php5 and CGI.
Testing done
I did an initial quick test with both mod_php5 and FastCGI with header('x', false, 304); which worked fine.
The tests below were done with header('Status: 304 Not Modified', true, 304);.
Environments

Ubuntu 10.10, Apache 2.2.16, Apache 2.0 Handler (mod_php5), PHP 5.3.3-1ubuntu9.7
CentOS 5.7, Apache 2.2.17, Apache 2.0 Handler (mod_php5), PHP 5.2.17
Debian 6, Hiawatha 7.8.2, CGI/FastCGI, PHP 5.3.3-7+squeeze3

OSWebserverServer APIPHPDemo
Ubuntu 10.10Apache 2.2.16Apache 2.0 Handler (mod_php5)PHP 5.3.3-1ubuntu9.7n/a (my local dev)
CentOS 5.7Apache 2.2.17Apache 2.0 Handler (mod_php5)PHP 5.2.17demo (my shared hosting)
Debian 6Hiawatha 7.8.2CGI/FastCGIPHP 5.3.3-7+squeeze3demo (my VPS hosting)

Browsers

OSBrowser200 and 304 statuses confirmed
Ubuntu 10.10Firefox 8Yes
Ubuntu 10.10Chromium 14Yes
Windows 7Chrome 15Yes
Windows 7Opera 11.60Yes
Windows 7Firefox 5
Windows 7Safari 5
Windows 7Internet Explorer 9

Results
For all of the above combinations, all JIT images loaded up fine on initial page load after clearing the browser cache.
All subsequent soft refreshes showed all JIT images fine. Those browsers with 'Yes' above were used to confirm 200 and 304 statuses using their network inspectors.
On one occasion, I found that Internet Explorer didn't load the images up on the first page load; I had not cleared the cache. After clearing the cache, normal behaviour resumend and all image loads worked. I believe that this means if a Symphony user has an existing installation and then upgrades to a version which uses the new-style header setting, any site visitors with cached images via previous visits would need to clear their cache to successfully have the JIT images displayed via a reload.
header()

http_response_code: Forces the HTTP response code to the specified value. Note that this parameter only has an effect if the string is not empty.

I suppose from a code-maintenance point of view, it would be better/easier to use header('x', true, 304); than header('Status: 304 Not Modified', true, 304); as the http_response_code parameter overrides the string anyway?

On Thu Dec 15 18:20:44 2011, michael-e wrote:

@DavidOliver: Great research on this topic, thanks!
@brendo: I tried:
 header('Status: 304 Not Modified', true, 304);

and it seems to work on my Debian Squeeze server running Apache and mod_php5.
However, I think that we should

take a look at how other PHP systems solved this
do more tests

BTW: @DavidOliver is right – it's not only JIT. There is also the "internal Symphony" way of setting headers: Page->addHeaderToPage.

Reply to this email directly or view it on GitHub:
https://github.com/symphonycms/symphony-2/issues/972#issuecomment-3158182

Is there any reason why we can't set both Headers? The detection is
likely to be costly (and looks like a house of cards).

Is there any reason why we can't set both Headers?

What exactly do you mean by setting both headers? (I don't like the detection idea, so there might be a misunderstanding.)

What exactly do you mean by setting both headers?

header('Status: 304');
header('HTTP/1.0 304 Not Modified');

Although judging from @DavidOliver's testing, the 'x' trick works consistently. I can't remember where I saw that trick, but it looks like a solution.

I suppose from a code-maintenance point of view, it would be better/easier to use header('x', true, 304); than header('Status: 304 Not Modified', true, 304); as the http_response_code parameter overrides the string anyway?

Bingo. There is a certain amount of readability that writing a full header gives though, so happy with either solution.

@brendo: from testing it seems we don't need to set both headers individually. Simply changing the line to the following seems to work perfectly for both Apache 2.0 Handler and CGI:
header('Status: 304 Not Modified', true, 304);

(Or the above with the string (first parameter) containing a dummy character as per your code.)

Just to be clear, here's how the code is for my testing above:
// Check to see if the requested image needs to be generated or if a 304
// can just be returned to the browser to use it's cached version.
if(CACHING === true && (isset($_SERVER['HTTP_IF_MODIFIED_SINCE']) || isset($_SERVER['HTTP_IF_NONE_MATCH']))){
	if($_SERVER['HTTP_IF_MODIFIED_SINCE'] == $last_modified_gmt || str_replace('"', NULL, stripslashes($_SERVER['HTTP_IF_NONE_MATCH'])) == $etag){
		header('Status: 304 Not Modified', true, 304);
		exit;
	}
}

Does header('HTTP/1.1 304 Not Modified', true, 304) also work?
Thanks very much for your detailed testing and investigation by the way!

This is how Wordpress does it:
/**
 * Set HTTP status header.
 *
 * @since 2.0.0
 * @uses apply_filters() Calls 'status_header' on status header string, HTTP
 *		HTTP code, HTTP code description, and protocol string as separate
 *		parameters.
 *
 * @param int $header HTTP status code
 * @return unknown
 */
function status_header( $header ) {
	$text = get_status_header_desc( $header );

	if ( empty( $text ) )
		return false;

	$protocol = $_SERVER["SERVER_PROTOCOL"];
	if ( 'HTTP/1.1' != $protocol && 'HTTP/1.0' != $protocol )
		$protocol = 'HTTP/1.0';
	$status_header = "$protocol $header $text";
	if ( function_exists( 'apply_filters' ) )
		$status_header = apply_filters( 'status_header', $status_header, $header, $text, $protocol );

	return @header( $status_header, true, $header );
}

So, in short: They seem to use s.th. like:
header('HTTP/1.0 304 Not Modified', true, 304);

Could it be that the forst parameter is completely irrelevant if you sue the third one? So all of the following:

header('HTTP/1.0 304 Not Modified', true, 304);
header('Status: 304 Not Modified', true, 304);
header('x', true, 304);

wil have the same effect?
In this case it is a matter of taste, isn't it?

Could it be that the forst parameter is completely irrelevant if you sue the third one?

I believe so. This is what the header PHP documenation says, and my testing indicates.

BTW: It should be implemented in JIT and in Symphony's core function, of course...

In this case it is a matter of taste, isn't it?

It looks like it. The second probably the least presumptuous (in terms of HTTP1.0/HTTP1.1)

So I guess the PHP function, when given the third paramter, handles detecting Server API and sends the header accordingly?
It might be prudent to check the PHP code for this if possible.

Yes, it looks a bit like "black magic built into PHP (hopefully)".
:-)

It might be prudent to check the PHP code for this if possible.

I wouldn't know where to look to find that information unfortunately! I had a quick look over the php-src repo but couldn't track down the source of the header() function (C is a bit beyond my ability)

Ah, ok. I'm no programmer, but it seems to me it should be safe to rely on header to do its job when it's fed the status code as the third parameter.
Do you think this change could go into the next beta - might be a good time to see if there are any user issues? I'd be surprised if anyone notices, though.

Do you think this change could go into the next beta - might be a good time to see if there are any user issues? I'd be surprised if anyone notices, though.

Definitely, I'll push through the changes in the next hour.

So shouldn't we use variant 1 (header('HTTP/1.0 304 Not Modified', true, 304);)? Might be safer...

Awesomes. Thanks a lot for responding so quickly - this being updated should help me a lot with Symphony sites at my new hosting environment.
In the meantime, I don't suppose I can somehow take the changes you make for this and apply them to 2.2.5?

So shouldn't we use variant 1 (header('HTTP/1.0 304 Not Modified', true, 304);)? Might be safer...

Hugo, the author of Hiawatha, would say Status: 304 Not Modified is the correct way (CGI specs are greater than Apache's ways to him), but I think it's really down to preference as the string won't be used anyway.
I'd probably go for one of the other two variants myself (legibility is nicer without the 'HTTP/1.0/1' bit, and 'x' is convenient).

Pushed (and updated JIT as well), pulling from integration and submodule updating will produce the goods! This will be in Beta 2.

In the meantime, I don't suppose I can somehow take the changes you make for this and apply them to 2.2.5?

You could try to:
curl https://github.com/symphonycms/symphony-2/commit/82341ea766cdf05b89f08d1ed1985c7124984670.patch | git am

And then inside extensions/jit_image_manipulation
curl https://github.com/symphonycms/jit_image_manipulation/commits/0cd7c6f9840f1fec771ad352d3d1792faf853117.patch | git am
That might/should work for the immediate term.


chore: release main

:robot: I have created a release beep boop
generator-ui5-spreadsheetimporter: 0.6.0
0.6.0 (2024-05-08)
⚠ BREAKING CHANGES

Features

enable packaged deployment (#547) (6d3450b)

ui5-cc-spreadsheetimporter: 0.34.0
0.34.0 (2024-05-08)
⚠ BREAKING CHANGES

Features

enable packaged deployment (#547) (6d3450b)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/spreadsheetimporter/ui5-cc-spreadsheetimporter/releases/tag/generator-ui5-spreadsheetimporter-v0.6.0 :sunflower:

:robot: Release is at https://github.com/spreadsheetimporter/ui5-cc-spreadsheetimporter/releases/tag/ui5-cc-spreadsheetimporter-v0.34.0 :sunflower:


External script editing does not trigger reload of running game

Bugsquad edit: This bug has been confirmed several times already. No need to confirm it further.

Windows 10 Godot 3.0 v3.0.alpha.custom_build.af97525
Issue description:
Editing script file in external file editor with Sync Script Changes does not trigger reload
Steps to reproduce:

Create a scene and attach a new script file which prints something every second
Enable Sync Script Changes
Change message from normal editor - Godot reloads
Open external editor (for example VSCode) and edit it.
The file reloads in the Godot file editor if opened, but doesn't reload the project

Does this ERROR: set_path: Condition ' exists ' is true.? (ERROR: set_path: Another resource is loaded from path if building after 96b205d)

cc @reduz
I'm almost sure the error above is the cause, since I get it every time I focus the editor after editing the script (be it GDScript or C#) from an external editor. In the case of GDScript the error is produced in the call to set_path() from ResourceFormatLoaderGDScript::load().

@neikeq can confirm that I get an error message using a recent custom build fb25fe0
ERROR: Resource::set_path: Condition ' exists ' is true.
   At: core\resource.cpp:78

Looks like this was fixed recently, no idea by whom. Can you confirm it?

@neikeq could you or anyone confirm?

It doesn't happen for me anymore. Not sure about @DjPale

Using Godot 3.0.2.stable under linux.
I have the same issue with this error printed:

Another resource is loaded from path: res://scripts/bamboo.gd (possible cyclic resource inclusion)
modules/gdscript/gdscript.cpp:560 - Condition ' !p_keep_state && has_instances ' is true. returned: ERR_ALREADY_IN_USE

As this is a blocker for me, I'm trying to workaround the issue by sending "reload_scripts" to the remote debugger, I tried to marshall the command to make it decodable by https://github.com/godotengine/godot/blob/34c988cfa92f19c232b65990704816ba1c7d2622/core/io/marshalls.cpp#L87 but it is not working so I must be doing something wrong.

After tinkering more and reading how the wire protocol worked, I was able to make it work.
When the game is running, it will connect to a remote debugger, this remote debugger must send the following packet for the game to reload it's scripts:
"\x20\x00\x00\x00\x13\x00\x00\x00\x01\x00\x00\x00\x04\x00\x00\x00\x0e\x00\x00\x00reload_scripts\x00\x00"

I'm having the same bug. All I have to do is just save the file in the external editor and then click on the godot editor and the error shows up. I've cloned the repo and debugged the code. I see it go into resource.cpp:78
It seems to protect resources from being loaded from two different threads I think? Shouldn't there be an exception for when external_editor is checked? Or some way to detect if the resource is loaded from the external editor and not give an error?
I wanted to see if I could fix it but I don't think I know the code well enough and I'd probably just introduce another bug.
This is me trying multiple scripts. (plugin, root node script, child node script)
`ERROR: Another resource is loaded from path: res://addons/Aseprite/aseprite.gd (possible cyclic resource inclusion)
At: core\resource.cpp:78
ERROR: Another resource is loaded from path: res://main.gd (possible cyclic resource inclusion)
At: core\resource.cpp:78
running cmdline: "C:/Program Files/Microsoft VS Code/Code.exe" "C:/Users/Willy/repos/memory-puzzle" "--goto" "C:/Users/Willy/repos/memory-puzzle/Node2D.gd:0:0"
ERROR: Another resource is loaded from path: res://Node2D.gd (possible cyclic resource inclusion)
At: core\resource.cpp:78
MUST RELOAD? 0
ERROR: Another resource is loaded from path: res://Node2D.gd (possible cyclic resource inclusion)
At: core\resource.cpp:78
ERROR: Resource::set_path: Condition ' exists ' is true.
At: core\resource.cpp:78`

I am getting:
 core/resource.cpp:79 - Condition ' exists ' is true.
and
ERROR: Another resource is loaded from path: res://scripts/entity.gd (possible cyclic resource inclusion)    At: core/resource.cpp:79
as soon as I save a script file with VSCode and focus Godot while the game is running.
The running game is not updated with the changed script.
so... is Live Coding with external editors not usable since 2017 (if it ever has been working) and it has been pushed to milestone 4.0? that hampers my motivations to use Godot severely..

I also have update issues with godot and vscode but on macos 10.15 and godot 3.2. Everything is proper installed. script syncing is enabled and I get the error message
Another resource is loaded from path 'res://levels/wall_tool.gd' (possible cyclic resource inclusion).
script only updates by restarting godot or randomly

Related to: https://github.com/Rybadour/NodeConnectorGodot/issues/3
this plugin modifies the script and the user needs to close/open godot to see changes
godot plz fix!

Related to: Rybadour/NodeConnectorGodot#3
this plugin modifies the script and the user needs to close/open godot to see changes

This as well, not sure if the linked issue is exactly related but I do have to tell users to unfocus the editor window in order for the modifications to the script to show up. Can we add a mechanism to allow plugins to invalidate the cache that represents an edited script?

can't live edit on Atom and VS code as well on Mac os(10.14.6) in godot 2.21, 2.2, get this error all the time:

Another resource is loaded from path 'res://src/Player/Player.gd' (possible cyclic resource inclusion).

Same! Bump!
 Another resource is loaded from path 'res://src/Controllers/World/Items/ItemDb.gd' (possible cyclic resource inclusion).
 Another resource is loaded from path 'res://src/Controllers/GUI/DeathScreen/DeathScreen.gd' (possible cyclic resource inclusion).

Im using linux debian, and i have the same problem, i never use it so i just realized that it works on the builtin editor. i believe my error is the same as all linux users:
* Another resource is loaded from path 'res://[my script path]' (possible cyclic resource inclusion).
* modules/gdscript/gdscript.cpp:553 - Condition "!p_keep_state && has_instances" is true. Returned: ERR_ALREADY_IN_USE

We've had enough confirmations of this bug, no need to keep bumping the issue.

Sorry to bump this as well, but given that my workflow is a bit
different, I'd like to understand how this is intended to work.
Is the intent that, if I run my game from the editor, modifying scripts
in an external editor like VSCode should trigger a reload in the game
itself?
If so, is there any way to get this functionality outside of running in
the editor? I.e. a command line flag of some sort?
Thanks.

@ndarilek you can turn off external editor, then open any script in godot code editor, then turn on external VC code editor. When you make any changes in VSc, open godot code editor any save file. That will update code in live.
Anyway, there is another problem (maybe it's only me) I can't add signal node using Atom as external code editor, meanwhile in VSc it's work.

As of build 3fb9c776ff53fbdd656b648e05101eaeaa39c908, whenever I return to the editor after external script editing I usually get the error below, and have to change something and resave the script for it to reload successfully.
ERROR: Another resource is loaded from path 'res://main.gd' (possible cyclic resource inclusion).
   At: core\resource.cpp:82

The stack looks like:
godot.windows.tools.64.exe!_err_print_error(const char * p_function, const char * p_file, int p_line, const char * p_error, const char * p_message, ErrorHandlerType p_type) Line 83	C++
godot.windows.tools.64.exe!_err_print_error(const char * p_function, const char * p_file, int p_line, const char * p_error, const String & p_message, ErrorHandlerType p_type) Line 99	C++
godot.windows.tools.64.exe!Resource::set_path(const String & p_path, bool p_take_over) Line 82	C++
godot.windows.tools.64.exe!ResourceFormatLoaderGDScript::load(const String & p_path, const String & p_original_path, Error * r_error) Line 2290	C++
godot.windows.tools.64.exe!ResourceLoader::_load(const String & p_path, const String & p_original_path, const String & p_type_hint, bool p_no_cache, Error * r_error) Line 270	C++
godot.windows.tools.64.exe!ResourceLoader::load(const String & p_path, const String & p_type_hint, bool p_no_cache, Error * r_error) Line 401	C++
godot.windows.tools.64.exe!ScriptEditor::_reload_scripts() Line 791	C++
godot.windows.tools.64.exe!ScriptEditor::_test_script_times_on_disk(Ref<Resource> p_for_script) Line 889	C++
godot.windows.tools.64.exe!ScriptEditor::edit(const Ref<Resource> & p_resource, int p_line, int p_col, bool p_grab_focus) Line 2202	C++
godot.windows.tools.64.exe!ScriptEditor::edit(const Ref<Resource> & p_resource, bool p_grab_focus) Line 428	C++
godot.windows.tools.64.exe!ScriptEditorPlugin::edit(Object * p_object) Line 3518	C++
godot.windows.tools.64.exe!EditorNode::_edit_current() Line 1928	C++
godot.windows.tools.64.exe!EditorNode::push_item(Object * p_object, const String & p_property, bool p_inspector_only) Line 1709	C++
godot.windows.tools.64.exe!InspectorDock::_resource_selected(const Ref<Resource> & p_res, const String & p_property) Line 287	C++
godot.windows.tools.64.exe!InspectorDock::edit_resource(const Ref<Resource> & p_resource) Line 371	C++
godot.windows.tools.64.exe!EditorNode::edit_resource(const Ref<Resource> & p_resource) Line 703	C++
godot.windows.tools.64.exe!SceneTreeDock::_script_open_request(const Ref<Script> & p_script) Line 1200	C++
godot.windows.tools.64.exe!MethodBind1<SceneTreeDock,Ref<Script> const &>::call(Object * p_object, const Variant * * p_args, int p_arg_count, Variant::CallError & r_error) Line 867	C++
godot.windows.tools.64.exe!Object::call(const StringName & p_method, const Variant * * p_args, int p_argcount, Variant::CallError & r_error) Line 922	C++
godot.windows.tools.64.exe!Object::emit_signal(const StringName & p_name, const Variant * * p_args, int p_argcount) Line 1249	C++
godot.windows.tools.64.exe!Object::emit_signal(const StringName & p_name, const Variant & p_arg1, const Variant & p_arg2, const Variant & p_arg3, const Variant & p_arg4, const Variant & p_arg5) Line 1307	C++
godot.windows.tools.64.exe!SceneTreeEditor::_cell_button_pressed(Object * p_item, int p_column, int p_id) Line 76	C++
godot.windows.tools.64.exe!MethodBind3<SceneTreeEditor,Object *,int,int>::call(Object * p_object, const Variant * * p_args, int p_arg_count, Variant::CallError & r_error) Line 2403	C++
godot.windows.tools.64.exe!Object::call(const StringName & p_method, const Variant * * p_args, int p_argcount, Variant::CallError & r_error) Line 922	C++
godot.windows.tools.64.exe!Object::emit_signal(const StringName & p_name, const Variant * * p_args, int p_argcount) Line 1249	C++
godot.windows.tools.64.exe!Object::emit_signal(const StringName & p_name, const Variant & p_arg1, const Variant & p_arg2, const Variant & p_arg3, const Variant & p_arg4, const Variant & p_arg5) Line 1307	C++
godot.windows.tools.64.exe!Tree::_gui_input(Ref<InputEvent> p_event) Line 2622	C++
godot.windows.tools.64.exe!MethodBind1<Tree,Ref<InputEvent>>::call(Object * p_object, const Variant * * p_args, int p_arg_count, Variant::CallError & r_error) Line 867	C++
godot.windows.tools.64.exe!Object::call_multilevel(const StringName & p_method, const Variant * * p_args, int p_argcount) Line 764	C++
godot.windows.tools.64.exe!Object::call_multilevel(const StringName & p_name, const Variant & p_arg1, const Variant & p_arg2, const Variant & p_arg3, const Variant & p_arg4, const Variant & p_arg5) Line 865	C++
godot.windows.tools.64.exe!Viewport::_gui_call_input(Control * p_control, const Ref<InputEvent> & p_input) Line 1669	C++
godot.windows.tools.64.exe!Viewport::_gui_input_event(Ref<InputEvent> p_event) Line 2049	C++
godot.windows.tools.64.exe!Viewport::input(const Ref<InputEvent> & p_event) Line 2828	C++
godot.windows.tools.64.exe!Viewport::_vp_input(const Ref<InputEvent> & p_ev) Line 1446	C++
godot.windows.tools.64.exe!MethodBind1<Viewport,Ref<InputEvent> const &>::call(Object * p_object, const Variant * * p_args, int p_arg_count, Variant::CallError & r_error) Line 867	C++
godot.windows.tools.64.exe!Object::call(const StringName & p_method, const Variant * * p_args, int p_argcount, Variant::CallError & r_error) Line 922	C++
godot.windows.tools.64.exe!Object::call(const StringName & p_name, const Variant & p_arg1, const Variant & p_arg2, const Variant & p_arg3, const Variant & p_arg4, const Variant & p_arg5) Line 848	C++
godot.windows.tools.64.exe!SceneTree::call_group_flags(unsigned int p_call_flags, const StringName & p_group, const StringName & p_function, const Variant & p_arg1, const Variant & p_arg2, const Variant & p_arg3, const Variant & p_arg4, const Variant & p_arg5) Line 275	C++
godot.windows.tools.64.exe!SceneTree::input_event(const Ref<InputEvent> & p_event) Line 431	C++
godot.windows.tools.64.exe!InputDefault::_parse_input_event_impl(const Ref<InputEvent> & p_event, bool p_is_emulated) Line 442	C++
godot.windows.tools.64.exe!InputDefault::parse_input_event(const Ref<InputEvent> & p_event) Line 260	C++
godot.windows.tools.64.exe!InputDefault::flush_accumulated_events() Line 679	C++
godot.windows.tools.64.exe!OS_Windows::process_events() Line 2578	C++
godot.windows.tools.64.exe!OS_Windows::run() Line 3280	C++
godot.windows.tools.64.exe!widechar_main(int argc, wchar_t * * argv) Line 162	C++
godot.windows.tools.64.exe!_main() Line 184	C++
godot.windows.tools.64.exe!main(int _argc, char * * _argv) Line 196	C++

My situation is slightly different, I'm making an importer that translates one language to GDScript directly. Any time I click Reimport, I get the error message: Another resource is loaded from path 'res://<file>' (possible cyclic resource inclusion).
I create a GDScript object and modify its source code, and then use ResourceSaver to save it to a gd file. Even with a script.reload() the error remains

Adding another to the pile. v3.2.2.stable.official on macOS 10.15.5. Pretty simple repro:

Create new project
Create root node
Create new script in Godot (FileSystem -> right click -> New Script)
Attach script to node
Configure external editor to use VSCode (configuration below)
Double click the script in Godot to open in VSCode
Make any edit and save the script from VSCode (I added a comment)

The error doesn't seem to cause any other issues. Interestingly, turning off "Use External Editor" but editing from VSCode anyway, will still cause the error, even though the Godot code editor will immediately show the change.
I also tested editing the script in vim, and the error repros. Appears to happen any time a script is modified outside Godot.

Happy birthday bug! You are now three years old.

@ohnoimdead Please don't bump issues without contributing significant new information. Use the :+1: reaction button on the first post instead.

I was getting this issue today after deleting most of my scripts / scenes from within the Godot editor. I created a new script.cs and attached it to a node. Make a comment in script in vscode with //, save it and I would get the cyclic resource inclusion error.
Thankfully the issue went away when I disabled Use External Editor in Editor Settings

To fix, open the project, go to Project -> Tools -> C# -> Generate
https://www.reddit.com/r/godot/comments/uhtlcr/solution_can_instance_cannot_instance_script/


Installation error

When I just execute the installation command, following error is displayed. Are there any pre-requirements or something?
➜ node -v
v16.13.1

➜  npx create-strapi-starter my-project gatsby-catalog
? Choose your installation type Quickstart (recommended)
This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
    at getPackageInfo (/Users/s/.npm/_npx/ecd569b0a81a6814/node_modules/create-strapi-starter/utils/fetch-npm-starter.js:19:27)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async getStarterInfo (/Users/s/.npm/_npx/ecd569b0a81a6814/node_modules/create-strapi-starter/utils/build-starter.js:109:26)
    at async buildStarter (/Users/s/.npm/_npx/ecd569b0a81a6814/node_modules/create-strapi-starter/utils/build-starter.js:133:7)

npx create-strapi-starter@3 my-project gatsby-catalog

will solve this issue. I feel the documentation or template should be updated.

I experienced the same issue also, it couldn't be installed


Document and return JSON data for API errors

What type of PR is this:
/kind bug
What does this PR do / why we need it:
Fixes the API response data for the error cases, and documents these error responses in the openapi spec

/override windows-integration-test/Windows-test
[FAILED] [137.366 seconds]
odo dev command with api server tests when the component is bootstrapped when odo is executed with --no-watch and --api-server flags [BeforeEach] when a file in component directory is modified when /component/command endpoint is POSTed should trigger a push
  [BeforeEach] C:/Users/Administrator.ANSIBLE-TEST-VS/4280/tests/integration/cmd_dev_api_server_test.go:180
  [It] C:/Users/Administrator.ANSIBLE-TEST-VS/4280/tests/integration/cmd_dev_api_server_test.go:213
[...]
starterserver.go:78] Stopping the API server; encountered error: listen tcp :20000: bind: Only one usage of each socket address (protocol/network address/port) is normally permitted.


Add wagtail nightly to readme

Thanks for contributing to Wagtail! 🎉
Before submitting, please review the contributor guidelines .http://docs.wagtail.io/en/latest/contributing/index.html and check the following:

Do the tests still pass? (http://docs.wagtail.io/en/latest/contributing/developing.html#testing)
Does the code comply with the style guide? (Run make lint from the Wagtail root)
For Python changes: Have you added tests to cover the new/fixed behaviour?
For front-end changes: Did you test on all of Wagtail’s supported browsers? Please list the exact versions you tested.
For new features: Has the documentation been updated accordingly?

Closing as invalid - this is a direct copy of #5542.