Sighash method signatures could return no error or io::Error if it wasn't for input index argument

This is just a thought that annoys me, but I don't really have a proposed solution.
Currently methods like
    pub fn segwit_encode_signing_data_to<Write: io::Write>(
        &mut self,
        mut writer: Write,
        input_index: usize,
        script_code: &Script,
        value: u64,
        sighash_type: EcdsaSighashType,
    ) -> Result<(), Error> {

    pub fn segwit_signature_hash(
        &mut self,
        input_index: usize,
        script_code: &Script,
        value: u64,
        sighash_type: EcdsaSighashType,
    ) -> Result<SegwitV0Sighash, Error> {

Return this super generic sighash::Error type but in all cases it's either io::Error or this one special case
            let txin = &self.tx.borrow().input.get(input_index).ok_or(Error::IndexOutOfInputsBounds {
                index: input_index,
                inputs_size: self.tx.borrow().input.len(),
            })?;

If it wasn't for this case, the segwit_signature_hash method would not need to return an error at all the the first one could just return io::Error forwarded from the writer argument.
That's very unfortunate.
Oh going into the taproot variant, I see another exception to that rule that actually is a bug in the segwit variant:
            self.tx.borrow().output[input_index].consensus_encode(&mut single_enc)?;

That should also do a range check like it does in the taproot variant:
            self.tx
                .borrow()
                .output
                .get(input_index)
                .ok_or(Error::SingleWithoutCorrespondingOutput {
                    index: input_index,
                    outputs_size: self.tx.borrow().output.len(),
                })?
                .consensus_encode(&mut enc)?;

I can fix that.
Still, it seems that taproot has more error variants. Maybe we should have a SegwitError and TaprootError so that users of segwit can explicitly unwrap if indices are in range or something.

This MR fixes that one missing error for segwit: https://github.com/rust-bitcoin/rust-bitcoin/pull/1966

We could create an IndexedInput type which contained a reference to a specific vin as well a its index. Then constructing this may have a Result but it could be used in other methods that would become infallible.

Even more annoying part is that if we are writing to HashEngines as we do in the most common case, there is no possibility of io::Error. We can use the infaillable engine.input() methods.
impl io::Write for sha256::HashEngine {
    fn flush(&mut self) -> io::Result<()> { Ok(()) }

    fn write(&mut self, buf: &[u8]) -> io::Result<usize> {
        self.input(buf);
        Ok(buf.len())
    }
}

The only reason segwit_signature_hash should fail is if the index is out of bounds. There is some work on trying to return only the error types that are reachable instead of giant parent enum. If that experiment is successful, we should adopt it for this sighash module.
See related:
Suggestion to improve ergonomics: https://github.com/rust-bitcoin/rust-secp256k1/issues/633
Attempt of this at address module. https://github.com/rust-bitcoin/rust-bitcoin/pull/1950
cc @tcharding

Thanks @sanket1729 , yeah read this yesterday and did some more work on the error stuff you link to. I rekon we need to get on and work this error stuff out.

#2329 splits the general error up to a state that may be acceptable enough to close this.

I think we should close it regardless. Ultimately this is a "I wish Rust had dependent types" issue, but it doesn't, so there's nothing we can do. There is a trivial error variant that could in-principle be eliminated by extremely simple static analysis, but Rust can't do it, so we have to keep it.

Oh, only noticed this now. I had some ideas around this but forgot what they were. :D But one I have now is to use lgio which makes error generic so we can statically prove the IO case never happens in case of hashers.

Cool, what is your hoped time frame on being able to use lgio?

Crazy idea: use both lgio and bitcoin-io temporarily? Though I originally thought lgio can be skipped entirely because of push_decode, then until I started writing this comment I thought it can't but now I think it actually probably can if we can change the code to return an encoder. (So instead of encode_signing_data_to we would have signing_data_encoder.)

Oh, I remembered one of the ideas: have a method that signs all inputs and sets the witnesses so at least in the case when one is signing all inputs the out of bounds errors can be removed.


Big ping issue

Why does my bot have like 50000-70000 ping?

I find it hard to say anything with almost no information.

What is “my bot”? (Are you sure this is something using tsclientlib?)
What unit are these numbers in? (seconds, milliseconds, nanoseconds?)
From where to where is your bot connecting? (to localhost? to a server far away? what is your ping to that server?)

Yap you are right, I didn't say anything so...
I used this example https://github.com/ReSpeak/tsclientlib/blob/master/tsclientlib/examples/audio.rs and connected it to my Teamspeak server(based in Germany somewhere I think) (bot is started it from my computer, and I'm also connected to the server).
Teamspeak have the ability to check client connection info (right-click on the user to get some data about his connection)
So I checked my Teamspeak bot(tsclientlib) and it has 50000ms-70000ms.
If you need any additional data I can provide everything.

It works fine for me. See the attached screenshot for an example. The client that is shown is the tsclientlib audio example and it has a ping of 24 ms, which is about the same ping I get when pinging the server.

Also keep in mind that the generation of the data in this window is up to the client so the values can be off by any number of reasons not related to the network.

You are right, the ping is normal but it's like float, my ping was 50 for example and the ping on the bot is 50.881 so I thought that it was 50881, not 50.881, it's my bad.


Decimal Separator "." is ignored in Firefox

In Firefox, the decimal Separator "." is  not emitted by the on valueChanged callback.
When typing "123.", the callback returns "123"
In Chrome this works as expected. I can reproduce this behavior with this sandbox
Code Sandbox

Hi, sorry for the late reply.
I just tried the sandbox you've linked, and added console.log(newValue) and I can see 123. being logged. This is in Chrome 89 and Firefox 86.
What version of firefox are you using? and are you using the latest version of this package? (v3.3.0)

Hi,
no worries.
I'm using Firefox 86.0.1 on MacOS and react-currency-input-field 3.3.0.
In my case. the console.log statement just logs the value without the dot

hmmm, that's certainly weird, I can't seem to reproduce it. This is what I get:

Also, may I ask why you need the . ? because if you're parsing into a number 123. and 123 are essentially the same?

Also, may I ask why you need the . ? because if you're parsing into a number 123. and 123 are essentially the same?

 Just remembered that the value passed in needs to have a . at the end so that user can continue typing the decimal part.
So this is only happening in Firefox for you?


Make it possible to disable certain options

A system administrator may want to disable an option, e.g. --max-workers to enforce a system-wide setting. We could provide a way to disable selected options, or override any settings globally.
Context: https://outerbounds-community.slack.com/archives/C02116BBNTU/p1643346664124169

Thanks for opening this issue @tuulos.
In the meantime, I'll share a solution that worked for me. Adding a decorator on the flow that removed unwanted cli options:
def drop_cli_args(*arguments):
    def decorator(pipeline):
        def wrapper():
            for arg in arguments:
                if arg in sys.argv:
                    ind = sys.argv.index(arg)
                    sys.argv.pop(ind) # drop the arg
                    sys.argv.pop(ind) # drop the val
            return pipeline()
        return wrapper
    return decorator

@drop_cli_args("--max-workers")
class MFPipeline(FlowSpec):
....

In the above example, the user will not be able to override the max-workers system default as the --max-workers flag will be dropped before the flow is called. To do the same for other system defaults, you can just add more arguments to the decorator e.g. @drop_cli_args("--max-workers", "--max-num-splits")
p.s. I am yet to test this in production trying this out locally works fine.


Fix translation dataloadres in a.30

I want to merge this change because of fixing translation dataloadres in a.30

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-3633 Add dataloader to translations


Expose expected minimum in result response

Add expected minimum to the result.
Closes #10

Correct, the data structure will be able to support standard deviation (and additional values) in the current specification.


Not able to make executables

Hi all,
I'm trying to create an executeable by following the steps here:
https://github.com/google/grumpy#method-2-grumpc
The issue is when I try to build the go file. It creates a file roughly 21kB which seems too small nor is it executeable. Also, even after making a chmod +x on the file it cannot be run. The error that occurs is:
dev@mymachine:~/grumpy$ ./hello
./hello: line 1: syntax error near unexpected token `newline'
./hello: line 1: `!<arch>'

the go file produced from the command 'build/bin/grumpc hello.py > hello.go' is:
package __main__
import (
        πg "grumpy"
)
func initModule(πF *πg.Frame, _ []*πg.Object) (*πg.Object, *πg.BaseException) {
        var πTemp001 []*πg.Object
        _ = πTemp001
        var πE *πg.BaseException; _ = πE
        for ; πF.State() >= 0; πF.PopCheckpoint() {
                switch πF.State() {
                case 0:
                default: panic("unexpected function state")
                }
                // line 1: print "hello, world"
                πF.SetLineno(1)
                πTemp001 = make([]*πg.Object, 1)
                πTemp001[0] = πg.NewStr("hello, world").ToObject()
                if πE = πg.Print(πF, πTemp001, true); πE != nil {
                        continue
                }
                return nil, nil
        }
        return nil, πE
}
var Code *πg.Code
func init() {
        Code = πg.NewCode("<module>", "hello.py", nil, 0, initModule)
        πg.RegisterModule("__main__", Code)
}

if trying to build a simple go file with the code below, it works just fine (creates an executeable which i can run directly) so I don't think it's my Go installation that's been causing the issue.
package main

import "fmt"

func main() {
    fmt.Printf("hello, world\n")
}

I'm using go version go1.8.3 linux/amd64

 Comment by trotterdylan
Thursday Jul 20, 2017 at 16:41 GMT

Thanks for reporting this. There was a similar issue reported on the mailing list: https://groups.google.com/forum/#!forum/grumpy-users
Basically, I've been messing around with the toolchain and those instructions no longer work. I've since updated that section of the README.
I want to make it easier to build one-off binaries like in the old instructions, so I'm going to leave this issue open to track progress on that work.

 Comment by gregoff82
Thursday Jul 20, 2017 at 17:33 GMT

Hi,
Thanks for input! Now I know that that part is still a work in progress. Looking forward to the future instructions to build one-off binaries.
Thanks again!

 Comment by jwalters-gpsw
Thursday Jan 04, 2018 at 22:46 GMT

Need any help with this?

 Comment by ymy0
Friday May 25, 2018 at 03:00 GMT

I need help please，I have the same problem!!!
So if it can't work ,how should I deal with? Can I continue to use the GRUMPY?
Please


This is a security bug bounty test... Please ignore  ckqfjj

This is a security bug bounty test... Please ignore  ckqfjj

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[WIP]Odd even

split main.tex to main_even.tex and main_odd.tex. So now we generate odd_start and even_start doc in same time.

[ ] main_even.tex down a line \input{main.tex}.
[ ] main.tex  remove comments
[ ] Edit README.


Fix default aggregation function

Coverage remained the same at 92.082% when pulling 240641887cb52fecf6f88a89765d22d9ba5dab6f on SAP:aggregate-template into b98d99930f6afa85c72a6296bc148f832545e3ad on cloudfoundry-incubator:master.


How to work with next-intl?

Hi guys, I have a question about the demo project.
In the middleware.ts.
const protectedRoutes = ["/profile"];

export default function middleware(req) {
  const casdoorUserCookie = req.cookies.get("casdoorUser");
  const isAuthenticated = casdoorUserCookie ? true : false;

  if (!isAuthenticated && protectedRoutes.includes(req.nextUrl.pathname)) {
    return NextResponse.redirect(new URL('/login', req.url))
  }
}

variable req.nextUrl.pathname may have some locale prefix if your import  next-intl/ package in your project to support multi-language. So the proteced path can't be matched in this situation.  How to resolve it?

@alex-guoba what URL patterns you use for i18n and which URLs need to be authenticated are just your own problem. It's your business logic, not something general that should be covered in this example


Update relay dependency packages

Here is the full audit
➜  hedera-json-rpc-relay git:(main) ✗ npm audit
# npm audit report

async  2.0.0 - 2.6.3
Severity: high
Prototype Pollution in async - https://github.com/advisories/GHSA-fwr7-v2mv-hh25
fix available via `npm audit fix --force`
Will install<EMAIL_ADDRESS>which is a breaking change
node_modules/ganache-core/node_modules/async
  ganache-core  <=2.1.0-beta.7 || >=2.1.1
  Depends on vulnerable versions of async
  Depends on vulnerable versions of lodash
  Depends on vulnerable versions of web3
  Depends on vulnerable versions of web3-provider-engine
  node_modules/ganache-core
    @ethereum-waffle/provider  *
    Depends on vulnerable versions of @ethereum-waffle/ens
    Depends on vulnerable versions of ganache-core
    node_modules/@ethereum-waffle/provider
      @ethereum-waffle/chai  2.5.0 - 4.0.0-dev.e3fa452
      Depends on vulnerable versions of @ethereum-waffle/provider
      node_modules/@ethereum-waffle/chai
        ethereum-waffle  2.3.0-istanbul.0 - 4.0.0-dev.e3fa452
        Depends on vulnerable versions of @ethereum-waffle/chai
        Depends on vulnerable versions of @ethereum-waffle/provider
        node_modules/ethereum-waffle

cross-fetch  <=2.2.5 || 3.0.0 - 3.0.5
Severity: moderate
Incorrect Authorization in cross-fetch - https://github.com/advisories/GHSA-7gc6-qh9x-w6h8
Depends on vulnerable versions of node-fetch
fix available via `npm audit fix`
node_modules/ganache-core/node_modules/cross-fetch

elliptic  <6.5.4
Severity: moderate
Use of a Broken or Risky Cryptographic Algorithm - https://github.com/advisories/GHSA-r9p9-mrjm-926w
fix available via `npm audit fix`
node_modules/ganache-core/node_modules/elliptic
  @ethersproject/signing-key  <=5.0.9
  Depends on vulnerable versions of elliptic
  node_modules/ganache-core/node_modules/@ethersproject/signing-key

got  <11.8.5
Severity: moderate
Got allows a redirect to a UNIX socket - https://github.com/advisories/GHSA-pfrx-2q88-qq97
fix available via `npm audit fix --force`
Will install<EMAIL_ADDRESS>which is a breaking change
node_modules/ganache-core/node_modules/got
node_modules/ganache-core/node_modules/swarm-js/node_modules/got
  swarm-js  0.1.1 - 0.1.17 || >=0.1.35
  Depends on vulnerable versions of got
  node_modules/ganache-core/node_modules/swarm-js
  web3-bzz  *
  Depends on vulnerable versions of got
  Depends on vulnerable versions of swarm-js
  Depends on vulnerable versions of underscore
  node_modules/ganache-core/node_modules/web3-bzz
    web3  <=3.0.0-rc.4
    Depends on vulnerable versions of web3-bzz
    Depends on vulnerable versions of web3-core
    Depends on vulnerable versions of web3-eth
    Depends on vulnerable versions of web3-eth-personal
    Depends on vulnerable versions of web3-net
    Depends on vulnerable versions of web3-shh
    Depends on vulnerable versions of web3-utils
    node_modules/ganache-core/node_modules/web3

json-schema  <0.4.0
Severity: critical
json-schema is vulnerable to Prototype Pollution - https://github.com/advisories/GHSA-896r-f27r-55mw
fix available via `npm audit fix`
node_modules/ganache-core/node_modules/json-schema
  jsprim  0.3.0 - 1.4.1 || 2.0.0 - 2.0.1
  Depends on vulnerable versions of json-schema
  node_modules/ganache-core/node_modules/jsprim

lodash  <=4.17.20
Severity: high
Command Injection in lodash - https://github.com/advisories/GHSA-35jh-r3h4-6jhm
Regular Expression Denial of Service (ReDoS) in lodash - https://github.com/advisories/GHSA-29mw-wpgm-hmr9
fix available via `npm audit fix`
node_modules/ganache-core/node_modules/lodash

minimist  <1.2.6
Severity: critical
Prototype Pollution in minimist - https://github.com/advisories/GHSA-xvch-5gv4-984h
fix available via `npm audit fix`
node_modules/ganache-core/node_modules/minimist

node-fetch  <=2.6.6
Severity: high
node-fetch is vulnerable to Exposure of Sensitive Information to an Unauthorized Actor - https://github.com/advisories/GHSA-r683-j2x4-v87g
The `size` option isn't honored after following a redirect in node-fetch - https://github.com/advisories/GHSA-w7rc-rwvf-8q5r
fix available via `npm audit fix --force`
Will install<EMAIL_ADDRESS>which is a breaking change
node_modules/ganache-core/node_modules/fetch-ponyfill/node_modules/node-fetch
node_modules/ganache-core/node_modules/node-fetch
  fetch-ponyfill  1.0.0 - 6.0.2
  Depends on vulnerable versions of node-fetch
  node_modules/ganache-core/node_modules/fetch-ponyfill
    eth-json-rpc-middleware  1.1.0 - 5.0.2
    Depends on vulnerable versions of fetch-ponyfill
    node_modules/ganache-core/node_modules/eth-json-rpc-middleware
      eth-json-rpc-infura  <=5.0.0
      Depends on vulnerable versions of eth-json-rpc-middleware
      node_modules/ganache-core/node_modules/eth-json-rpc-infura
        web3-provider-engine  14.0.0 - 15.0.12
        Depends on vulnerable versions of eth-json-rpc-infura
        node_modules/ganache-core/node_modules/web3-provider-engine

normalize-url  4.3.0 - 4.5.0
Severity: high
ReDoS in normalize-url - https://github.com/advisories/GHSA-px4h-xg32-q955
fix available via `npm audit fix`
node_modules/ganache-core/node_modules/normalize-url

parse-path  <5.0.0
Severity: moderate
Authorization Bypass in parse-path - https://github.com/advisories/GHSA-3j8f-xvm3-ffx4
fix available via `npm audit fix --force`
Will install<EMAIL_ADDRESS>which is a breaking change
node_modules/parse-path
  parse-url  3.0.0 - 6.0.2
  Depends on vulnerable versions of parse-path
  node_modules/parse-url
    git-up  2.1.0 - 5.0.0
    Depends on vulnerable versions of parse-url
    node_modules/git-up
      git-url-parse  11.0.0 - 11.6.0
      Depends on vulnerable versions of git-up
      node_modules/git-url-parse
        @lerna/github-client  <=5.1.7
        Depends on vulnerable versions of git-url-parse
        node_modules/@lerna/github-client
          @lerna/version  3.11.0 - 5.1.7
          Depends on vulnerable versions of @lerna/github-client
          node_modules/@lerna/version
            @lerna/publish  3.11.0 - 5.1.7
            Depends on vulnerable versions of @lerna/version
            node_modules/@lerna/publish
            lerna  3.11.0 - 5.1.7
            Depends on vulnerable versions of @lerna/publish
            Depends on vulnerable versions of @lerna/version
            node_modules/lerna

path-parse  <1.0.7
Severity: moderate
Regular Expression Denial of Service in path-parse - https://github.com/advisories/GHSA-hj48-42vr-x3v9
fix available via `npm audit fix`
node_modules/ganache-core/node_modules/path-parse

simple-get  <2.8.2
Severity: high
Exposure of Sensitive Information in simple-get - https://github.com/advisories/GHSA-wpg7-2c88-r8xv
fix available via `npm audit fix`
node_modules/ganache-core/node_modules/simple-get

tar  <=4.4.17
Severity: high
Arbitrary File Creation/Overwrite on Windows via insufficient relative path sanitization - https://github.com/advisories/GHSA-5955-9wpr-37jh
Arbitrary File Creation/Overwrite via insufficient symlink protection due to directory cache poisoning using symbolic links - https://github.com/advisories/GHSA-qq89-hq3f-393p
Arbitrary File Creation/Overwrite via insufficient symlink protection due to directory cache poisoning using symbolic links - https://github.com/advisories/GHSA-9r2w-394v-53qc
Arbitrary File Creation/Overwrite due to insufficient absolute path sanitization - https://github.com/advisories/GHSA-3jfq-g458-7qm9
Arbitrary File Creation/Overwrite via insufficient symlink protection due to directory cache poisoning - https://github.com/advisories/GHSA-r628-mhmh-qjhw
fix available via `npm audit fix`
node_modules/ganache-core/node_modules/tar

underscore  1.3.2 - 1.12.0
Severity: high
Arbitrary Code Execution in underscore - https://github.com/advisories/GHSA-cf4h-3jhx-xvhq
fix available via `npm audit fix --force`
Will install<EMAIL_ADDRESS>which is a breaking change
node_modules/ganache-core/node_modules/underscore
  web3-core-helpers  <=1.3.6-rc.2 || 2.0.0-alpha - 3.0.0-rc.4
  Depends on vulnerable versions of underscore
  Depends on vulnerable versions of web3-eth-iban
  Depends on vulnerable versions of web3-utils
  node_modules/ganache-core/node_modules/web3-core-helpers
    web3-core-subscriptions  <=1.3.6-rc.2 || 2.0.0-alpha - 3.0.0-rc.4
    Depends on vulnerable versions of underscore
    Depends on vulnerable versions of web3-core-helpers
    node_modules/ganache-core/node_modules/web3-core-subscriptions
      web3-core-method  <=1.3.6-rc.2 || 2.0.0-alpha - 3.0.0-rc.4
      Depends on vulnerable versions of underscore
      Depends on vulnerable versions of web3-core-helpers
      Depends on vulnerable versions of web3-core-subscriptions
      Depends on vulnerable versions of web3-utils
      node_modules/ganache-core/node_modules/web3-core-method
      web3-eth  <=1.3.6-rc.2 || 2.0.0-alpha - 3.0.0-rc.4
      Depends on vulnerable versions of underscore
      Depends on vulnerable versions of web3-core
      Depends on vulnerable versions of web3-core-helpers
      Depends on vulnerable versions of web3-core-method
      Depends on vulnerable versions of web3-core-subscriptions
      Depends on vulnerable versions of web3-eth-abi
      Depends on vulnerable versions of web3-eth-accounts
      Depends on vulnerable versions of web3-eth-contract
      Depends on vulnerable versions of web3-eth-ens
      Depends on vulnerable versions of web3-eth-iban
      Depends on vulnerable versions of web3-eth-personal
      Depends on vulnerable versions of web3-net
      Depends on vulnerable versions of web3-utils
      node_modules/ganache-core/node_modules/web3-eth
      web3-eth-contract  <=1.3.6-rc.2 || 2.0.0-alpha - 3.0.0-rc.4
      Depends on vulnerable versions of underscore
      Depends on vulnerable versions of web3-core
      Depends on vulnerable versions of web3-core-helpers
      Depends on vulnerable versions of web3-core-method
      Depends on vulnerable versions of web3-core-subscriptions
      Depends on vulnerable versions of web3-eth-abi
      Depends on vulnerable versions of web3-utils
      node_modules/ganache-core/node_modules/web3-eth-contract
      web3-shh  <=1.3.5
      Depends on vulnerable versions of web3-core
      Depends on vulnerable versions of web3-core-method
      Depends on vulnerable versions of web3-core-subscriptions
      Depends on vulnerable versions of web3-net
      node_modules/ganache-core/node_modules/web3-shh
    web3-providers-http  <=1.0.0 || 1.2.0 - 1.3.5 || 3.0.0-rc.0 - 3.0.0-rc.4
    Depends on vulnerable versions of web3-core-helpers
    node_modules/ganache-core/node_modules/web3-providers-http
    web3-providers-ipc  <=1.3.6-rc.2 || >=3.0.0-rc.0
    Depends on vulnerable versions of underscore
    Depends on vulnerable versions of web3-core-helpers
    node_modules/ganache-core/node_modules/web3-providers-ipc
    web3-providers-ws  <=1.3.6-rc.2 || 3.0.0-rc.0 - 3.0.0-rc.4
    Depends on vulnerable versions of underscore
    Depends on vulnerable versions of web3-core-helpers
    node_modules/ganache-core/node_modules/web3-providers-ws
  web3-core-requestmanager  <=1.3.5 || 3.0.0-rc.0 - 3.0.0-rc.4
  Depends on vulnerable versions of underscore
  Depends on vulnerable versions of web3-core-helpers
  Depends on vulnerable versions of web3-providers-http
  Depends on vulnerable versions of web3-providers-ipc
  Depends on vulnerable versions of web3-providers-ws
  node_modules/ganache-core/node_modules/web3-core-requestmanager
  web3-eth-abi  <=1.3.6-rc.2 || 2.0.0-alpha - 3.0.0-rc.4
  Depends on vulnerable versions of underscore
  Depends on vulnerable versions of web3-utils
  node_modules/ganache-core/node_modules/web3-eth-abi
  web3-eth-accounts  <=1.3.5 || 2.0.0-alpha - 3.0.0-rc.4
  Depends on vulnerable versions of underscore
  Depends on vulnerable versions of web3-core
  Depends on vulnerable versions of web3-core-helpers
  Depends on vulnerable versions of web3-core-method
  Depends on vulnerable versions of web3-utils
  node_modules/ganache-core/node_modules/web3-eth-accounts
  web3-eth-ens  <=1.3.6-rc.2 || 2.0.0-alpha - 3.0.0-rc.4
  Depends on vulnerable versions of underscore
  Depends on vulnerable versions of web3-core
  Depends on vulnerable versions of web3-core-helpers
  Depends on vulnerable versions of web3-eth-abi
  Depends on vulnerable versions of web3-eth-contract
  Depends on vulnerable versions of web3-utils
  node_modules/ganache-core/node_modules/web3-eth-ens
  web3-utils  1.0.0-beta.8 - 1.3.5 || 2.0.0-alpha - 3.0.0-rc.4
  Depends on vulnerable versions of underscore
  node_modules/ganache-core/node_modules/web3-utils
    web3-core  <=1.3.5 || 2.0.0-alpha - 3.0.0-rc.4
    Depends on vulnerable versions of web3-core-helpers
    Depends on vulnerable versions of web3-core-method
    Depends on vulnerable versions of web3-core-requestmanager
    Depends on vulnerable versions of web3-utils
    node_modules/ganache-core/node_modules/web3-core
    web3-eth-iban  <=1.3.5 || 2.0.0-alpha - 3.0.0-rc.4
    Depends on vulnerable versions of web3-utils
    node_modules/ganache-core/node_modules/web3-eth-iban
    web3-eth-personal  <=1.3.5 || 2.0.0-alpha - 3.0.0-rc.4
    Depends on vulnerable versions of web3-core
    Depends on vulnerable versions of web3-core-helpers
    Depends on vulnerable versions of web3-core-method
    Depends on vulnerable versions of web3-net
    Depends on vulnerable versions of web3-utils
    node_modules/ganache-core/node_modules/web3-eth-personal
    web3-net  1.2.0 - 1.3.5 || 2.0.0-alpha - 3.0.0-rc.4
    Depends on vulnerable versions of web3-core
    Depends on vulnerable versions of web3-core-method
    Depends on vulnerable versions of web3-utils
    node_modules/ganache-core/node_modules/web3-net

ws  5.0.0 - 5.2.2
Severity: moderate
ReDoS in Sec-Websocket-Protocol header - https://github.com/advisories/GHSA-6fc8-4gx4-v693
fix available via `npm audit fix`
node_modules/ganache-core/node_modules/web3-provider-engine/node_modules/ws

yargs-parser  <=5.0.0
Severity: moderate
Prototype Pollution in yargs-parser - https://github.com/advisories/GHSA-p9pc-299p-vxgp
fix available via `npm audit fix --force`
Will install<EMAIL_ADDRESS>which is a breaking change
node_modules/@ensdomains/ens/node_modules/yargs-parser
  yargs  4.0.0-alpha1 - 7.0.0-alpha.3 || 7.1.1
  Depends on vulnerable versions of yargs-parser
  node_modules/@ensdomains/ens/node_modules/yargs
    solc  0.3.6 - 0.4.26
    Depends on vulnerable versions of yargs
    node_modules/@ensdomains/ens/node_modules/solc
      @ensdomains/ens  *
      Depends on vulnerable versions of solc
      node_modules/@ensdomains/ens
        @ethereum-waffle/ens  *
        Depends on vulnerable versions of @ensdomains/ens
        node_modules/@ethereum-waffle/ens

58 vulnerabilities (4 low, 20 moderate, 31 high, 3 critical)

I've ran an audit and there are no vulnerabilities currently.
hedera-json-rpc-relay % npm audit
found 0 vulnerabilities

Thanks @mgarbs
We address this with https://github.com/hashgraph/hedera-json-rpc-relay/pull/442 and i've connected them now


Get config from props - metrics(config)

Is there a way to get config from props for example in case of GoogleAnalytics I want to get trackingId from props.

Yeah it's possible to configure metrics wherever. However, typically, you'd configure it at the top level of your app where you would not need to pass trackingId down as a prop.
https://github.com/nfl/react-metrics#metrics-api-outside-a-react-component
import {createMetrics} from "react-metrics";

class YourComponent extends React.Component {
    componentDidMount() {
        const metrics = createMetrics({
            trackingId: this.props.trackingId
        });
    }
}

Closing this issue, feel free to reopen with some code sample of what you've tried if this doesn't answer the question.


rel="nofollow"

Is there any support for rel="nofollow" or can you advise how I can add this without overwriting the Liip core files?

you want to add rel="nofollow" to links automatically? I don't think we currently have a solution for this .. maybe using a custom class and some javascript it can work, but I assume you are more interested in stopping search engines? at any rate, this Bundle is currently stuck a bit in limbo as we are not getting done with https://github.com/liip/LiipUrlAutoConverterBundle/pull/14

It seems to OK fine apart from the rel issue. Which I created by making my own Extension

we are not really maintaining this library anymore because nobody at liip is currently using it. it is not up to date with recent symfony versions, not tested on php 7.1 or newer and so on. the travis-ci build fails for the antique php versions and obsolete symfony versions.
in our opinion, the evolution should be to use an existing library for finding urls in text, or splitting out the logic implemented here into a library and have the bundle only integrate the library into symfony.
we archive this bundle now.


added customizations for misva repo container

Just some initial customizations - good to go

Just some initial customizations - good to go


Unhandled error in plugin argenteam

Expected behavior:

Actual behavior:
It gets the list of shows from Trakt and starts searching for each show using the plug-ins. It then crashes.
Steps to reproduce:

Step 1: It happens every time it runs.

Config:
variables: secrets.yml

templates:

  tv:
    configure_series:
      settings:
        quality: 720p+
        identified_by: ep
      from:
        trakt_list:
          account: "{? trakt.account ?}"
          list: "{? trakt.series ?}"
          type: shows

  reject:
    regexp:
      reject:
        - \b(s|d)ub(s|bed|lado|titulado)?\b
        - \bhc\b
        - \bdual\b
        - \b3d\b
        - \bfre(nch)?\b
        - \bita(lian)?\b
        - \bspa(nish)?\b
        - \bger(man)?\b
        - \bcastellano\b
        - \brus(sian)?\b
        - \btamil\b
        - \bhindi\b
        - \bh265\b
        - \bx265\b
    content_filter:
      reject:
        - '*.rar'
        - '*.zip'
        - '*.exe'

  place_torrent:
    utorrent:
      url: "{? utorrent.url ?}"
      username: "{? utorrent.user ?}"
      password: "{? utorrent.pass ?}"
      path: "{? utorrent.path ?}"

  pushbullet:
    notify:
      entries:
        title: "[flexget] Downloading"
        message: "{{title}}"
        via:
          - pushbullet:
              api_key: "{? pushbullet.api ?}"

tasks:

  follow show from ep:
    seen: local
    trakt_list:
      account: "{? trakt.account ?}"
      list: "{? trakt.series ?}"
      type: episodes
    accept_all: yes
    set_series_begin: yes
    list_remove:
      - trakt_list:
          account: "{? trakt.account ?}"
          list: "{? trakt.series ?}"
          type: episodes
    list_add:
      - trakt_list:
          account: "{? trakt.account ?}"
          list: "{? trakt.series ?}"
          type: shows

  get shows:
    template:
      - tv
      - reject
      - place_torrent
      - pushbullet
    discover:
      what:
        - next_series_episodes:
            from_start: yes
      from:
        - piratebay:
            category: highres tv
        - limetorrents:
            category: tv
        - rarbg:
            category: [1, 18, 41, 49]
        - argenteam:
            force_subtitles: no

Log:

(click to expand)
Debug Log - https://pastebin.com/bTr4qX6a
2019-03-16 05:40 VERBOSE  trakt_list    get shows       Retrieving `shows` list `720p_list`
2019-03-16 05:40 VERBOSE  discover      get shows       Discovering 26 titles ...
2019-03-16 05:40 INFO     discover      get shows       Ignoring interval because of --discover-now
2019-03-16 05:40 INFO     task          get shows       Plugin next_series_episodes has requested task to be ran again after execution has completed. Reason: Look for next season
2019-03-16 05:40 VERBOSE  discover      get shows       The Big Bang Theory (2007) S12E18 hasn't been released yet (Expected: 2019-04-04 00:00:00)
2019-03-16 05:40 VERBOSE  discover      get shows       Modern Family (2009) S10E18 hasn't been released yet (Expected: 2019-03-20 00:00:00)
2019-03-16 05:40 VERBOSE  discover      get shows       Game of Thrones (2011) S08E01 hasn't been released yet (Expected: 2019-04-14 00:00:00)
2019-03-16 05:40 VERBOSE  discover      get shows       The Goldbergs (2013) S06E19 hasn't been released yet (Expected: 2019-03-20 00:00:00)
2019-03-16 05:40 VERBOSE  discover      get shows       Schooled (2019) S01E09 hasn't been released yet (Expected: 2019-03-20 00:00:00)
2019-03-16 05:41 VERBOSE  discover      get shows       Searching for `Shameless (2011) S04E04` with plugin `piratebay` (1 of 10)
2019-03-16 05:41 VERBOSE  discover      get shows       Searching for `Shameless (2011) S04E04` with plugin `limetorrents` (1 of 10)
2019-03-16 05:41 VERBOSE  discover      get shows       Searching for `Shameless (2011) S04E04` with plugin `rarbg` (1 of 10)
2019-03-16 05:41 VERBOSE  discover      get shows       Searching for `Shameless (2011) S04E04` with plugin `argenteam` (1 of 10)
2019-03-16 05:41 CRITICAL task          get shows       BUG: Unhandled error in plugin discover: list index out of range
2019-03-16 05:41 CRITICAL manager       get shows       An unexpected crash has occurred. Writing crash report to C:\Users\Amishman\flexget\crash_report.2<IP_ADDRESS>135803000.log. Please verify you are running the latest version of flexget by using "flexget -V" from CLI or by using version_checker plugin at http://flexget.com/wiki/Plugins/version_checker. You are currently using version 2.20.12
2019-03-16 05:41 WARNING  task          get shows       Aborting task (plugin: discover)

Additional information:

FlexGet version: 2.20.12
Python version: 2.7.13
Installation method: pip
Using daemon (yes/no): no
OS and version: Windows 7 Pro
Link to crash log:
crash_report.2<IP_ADDRESS>135803000.log

Looks like plugin argenteam crashes, removing it should allow others to work fine.

Removing the argenteam plugin fixed the issue. It does work properly now. Thank you.


add activationId to events message

Description
This change adds the activationId to messages on the events topic of type Activation. This is useful for external services that listen in on the events topic that may want to make reference to the activations
it is consuming.
Related issue and scope

[ ] I opened an issue to propose and discuss this change (#????)

My changes affect the following components

[ ] API
[ ] Controller
[x] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[ ] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[ ] Data stores (e.g., CouchDB)
[x] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[ ] Bug fix (generally a non-breaking change which closes an issue).
[x] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[x] I signed an Apache CLA.
[x] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[x] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

Thanks @bdoyle0182.

Just to confirm the impact on backward compatability.

Any existing code which is processing the user-events using older version of Message parsing code would work as is as it would just ignore activationId
New code reading older events - Should not happen in general

Should we account for case where parser should be able to handle missing activationId i.e. mark it as Option

Just to confirm the impact on backward compatability.

Any existing code which is processing the user-events using older version of Message parsing code would work as is as it would just ignore activationId
New code reading older events - Should not happen in general

Should we account for case where parser should be able to handle missing activationId i.e. mark it as Option

Not sure if it needs to be an Option as any existing external service to openwhisk parsing the events topic just wouldn't look for activationId right? It would just ignore until it started looking for the field.


[Question]: ,im getting this error  WARNING:llama_index.indices.knowledge_graph.retrievers:Index was not constructed with embeddings, skipping embedding usage... Index was not constructed with embeddings, skipping embedding usage...i can see new documents in their respective form in neo4j graphdb gui but i'm not sure if its issue with llm ..im using azureopenai and not openai

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
john9876_ — Today at 2:32 AM
Hi,im getting this error
WARNING:llama_index.indices.knowledge_graph.retrievers:Index was not constructed with embeddings, skipping embedding usage...
Index was not constructed with embeddings, skipping embedding usage...
Index was not constructed with embeddings, skipping embedding usage...
Index was not constructed with embeddings, skipping embedding usage...
Index was not constructed with embeddings, skipping embedding usage...

llm = AzureOpenAI(
    model="gpt-35-turbo",
    deployment_name="gpt35",
    api_key=api_key,
    azure_endpoint=azure_endpoint,
    api_version=api_version,
)
embed_model = AzureOpenAIEmbedding(
model="text-embedding-ada-002",
deployment_name="textexmbedding1",
api_key=api_key,
azure_endpoint=azure_endpoint,
api_version=api_version,
)
service_context = ServiceContext.from_defaults(
llm=llm,
embed_model=embed_model,
)
i'm using neo4j:5.11-enterprise with apoc plugin

Its more like a log thats way too verbose, not an actual issue
There is an option to use a vector store and embed triplets for vector retrieval, but if you don't enable it, then the default retrieval mode of "hybrid" changes and prints this error


chore(release): v1.0.0 🎉

:robot: I have created a release *beep* *boop*
1.0.0 (2022-10-09)
Features

init: publish as standalone package (cee9740)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/ehmpathy/simple-on-disk-cache/releases/tag/v1.0.0 :sunflower:


Roadmap

Is there a roadmap published for the MetaParticle project overall?
I would like to help contribute any way I can.

There are lots of open ideas/issues. One of the most interesting is how to integrate rollouts/upgrades.
Basically, if you see something interesting, feel free to file an issue or markdown to discuss the design...
(and I'll try to get a more formal roadmap together too...)

Thanks! I'll look around.


boards: arm: Board Creation for cy8cproto_063_ble

Adding support for Infineon cy8cproto_063_ble board

@npal-cy

Hi @sreeramIfx, you need to add dts\soc support for PSoC6 1M
DTS part:
dts\arm\infineon\psoc6\mpns\CYBLE_416045_02.dtsi (you can add all  PSoC6 1M MPNs)
dts\arm\infineon\psoc6\psoc6_01*.*
SOC part:
\soc\arm\infineon_cat1\psoc6\Kconfig.defconfig.soc.psoc6_01
\soc\arm\infineon_cat1\psoc6\Kconfig.soc.psoc6_01

Hi @galak

Can you refactor the duplication on the dts/arm/infineon/psoc6/psoc6_01/psoc6*.dtsi files. Looks like a fair amount of duplication under the pinctrl node.

package dtsi (dts/arm/infineon/psoc6/psoc6_01/psoc6_01.xxxxx.dtsi) reflect gpio resources and pinctrl nodes which is suitable for this  packages. Example if device has psoc6_01.124-bga-sip.dtsi we declare pinctrl for uart_scb0...uart_scb7, if it  psoc6_01.43-smt.dtsi we uart_scb0...uart_scb6 (we do not add uart_scb7, uart_scb8 because in does not supported by this kind of package). Let me know if it makes sense.

@galak, do you have any more questions on the DTSI files here?

The uart/i2c/spi/... as a scb node and than in the board dts it modifies the compatible for i2c/spi/uart.
Look at ATMEL sercom or NXP flecomm to see examples: https://github.com/zephyrproject-rtos/zephyr/blob/main/boards/arm/adafruit_feather_m0_lora/adafruit_feather_m0_lora.dts#L43
Here's a rough example of what the dtsi:
		scb4: scb@40650000 {
			compatible = "infineon,cat1-scb";
			reg = <0x40650000 0x10000>;
			#address-cells = <1>;
			#size-cells = <0>;
			interrupts = <45 6>;
			status = "disabled";
		};

		scb5: scb@40660000 {
			compatible = "infineon,cat1-scb";
			reg = <0x40660000 0x10000>;
			#address-cells = <1>;
			#size-cells = <0>;
			interrupts = <46 6>;
			status = "disabled";
		};

@galak we will have to make these changes to the already merged psoc6_02.dtsi as well. Can we make these changes in a separate PR? We want to review the implementations of ATMEL/NXP and work on our implementation as a separate task.

Some of the shared nodes in in the psoc6_01.xxx*dtsi files for things like hsiom, gpio, etc should be in a common dtsi file.

moved the gpio, hsiom nodes to a common file and used /delete-node/ to configure per package..

@galak we will have to make these changes to the already merged psoc6_02.dtsi as well. Can we make these changes in a separate PR? We want to review the implementations of ATMEL/NXP and work on our implementation as a separate task.

We should figure this out now.  The impact to psoc6_02.dtsi seems pretty small at this point since it only seems to be defining uart's and not all the other I2C, SPI, etc. nodes.

Updated @ https://github.com/zephyrproject-rtos/zephyr/pull/57814


Problems submitting additional information via rx.form

Describe the bug
Besides the component values inside rx.form, I would like to submit other information.
However, when I press the submit button, an error occurs.
To Reproduce
Steps to reproduce the behavior:
import reflex as rx

class ForeachState(rx.State):
    infos: list[dict[str, str]] = [
        {'name': "1st form", 'id': '1'},
        {'name': "5th form", 'id': '5'},
        {'name': "2nd form", 'id': '2'}
    ]

    def handle_submit(self, name: dict, info: dict[str, str]):
        print(name, info)

def form_box(info: dict[str, str]):
    return rx.vstack(
        rx.form(
            rx.input(
                placeholder="First Name",
                name="first_name",
            ),
            rx.input(
                placeholder="Last Name",
                name="last_name",
            ),
            rx.button("Submit", type="submit"),
            on_submit=lambda form_data: ForeachState.handle_submit(
                form_data, info),
        ),
    )

def foreach_example():
    return rx.flex(
        rx.foreach(ForeachState.infos, form_box),
    )

def index():
    return foreach_example()

app = rx.App()
app.add_page(index)

Expected behavior
I believe it should be possible to submit additional information via rx.form.
Screenshots

Specifics (please complete the following information):

Python Version: 3.11.4
Reflex Version: 0.5.2
OS: Windows10
Browser (Optional): Chrome

Additional context
Add any other context about the problem here.

dupe of #3210
current workaround is to pass the required values in rx.el.input(type="hidden") fields, but i agree it's not very satisfying. We'll try to come up with something nicer, but not sure when we'll be able to get to it.


I wrote a new loader without remote memory injection

FYI https://github.com/allfoxwy/vanilla-dll-sideloader/releases/latest
It works by modify PE import directory, not by remote memory injection. Should calm some security software complain.

The idea may be good, but it doesn't work on my ru client
https://wowruru.github.io/win_instruction.html

The idea may be good, but it doesn't work on my ru client https://wowruru.github.io/win_instruction.html

I built it on Turtle WoW.
Could you describe what is "doesn't work"? It can't patch WoW.exe? It's not loading mods? Or what?

This is a regular 1.12 client, only patched for loading ruRU resources.
WoW.exe was patched normally "WoW_sideload-DLL.exe" but does not start, the logs do not say anything about errors

That's sounds like sideload-DLL.dll not loaded.
You sure sideload-DLL.dll is also at the same folder with WoW_sideload-DLL.exe right?

That's sounds like sideload-DLL.dll not loaded.
You sure sideload-DLL.dll is also at the same folder with WoW_sideload-DLL.exe right?

yes all was in all folder, also with SuperWoW\vanilla-tweaks\VanillaFixes

Thanks, I'll have a look, I'm downloading that RU client. Maybe the RU .exe is different than English client.

Thanks, I'll have a look, I'm downloading that RU client. Maybe the RU .exe is different than English client.

np, vanillafixes injector works for me, it's just a remark

@shikulja I got some bugs fixed. Could you try https://github.com/allfoxwy/vanilla-dll-sideloader/releases/latest see if it works?
The Turtle EU client was so perfectly aligned so that those bugs didn't expose.
Thank you for mention this RU client.

@allfoxwy now works, thanks.
Still need a way to load custom dlls in the future

Added customized DLL loading code.

After I listen to Ayriana's words from turtle discord. I decided re-open this issue for a bit longer time.
I believe my loader has following advantage:

No remote memory injection, so less Windows Defender alarm.
My loader run in game's main thread.
My loader would fire a function call when EnterWorld game event happens. This means mods could execute LUA related function, as in that timing LUA environment is ready.

Would you consider have a look or maybe adapt it?
It would load VanillaFixes if its file name is "VfPatcher.Vanilla1121mod.dll"

it can load .dll files according to the pattern, but cannot load from the subdirectory in which the .dll+lua project is located

it can load .dll files according to the pattern, but cannot load from the subdirectory in which the .dll+lua project is located

Yes Ayriana on discord asking me to make a text file to direct loading process now.
I think I could write something later.

Would you consider have a look or maybe adapt it?

I considered the option of modifying WoW.exe for VanillaFixes but decided against it because some servers kick you if you have a modified game executable. You can get around this by renaming it to something else and keeping WoW.exe in the same folder but I think this would make VanillaFixes harder to use. If you use something like vanilla-tweaks on top it can get even more confusing.

My loader would fire a function call when EnterWorld game event happens. This means mods could execute LUA related function, as in that timing LUA environment is ready.

This also seems out of scope for VanillaFixes. It would be better suited for a generic modding framework for the game, where you could load VanillaFixes on top.
Basically, the launcher is just there to get VanillaFixes loaded, and it's supposed to be as easy as possible to use. I added the option to load other DLLs because otherwise it can conflict with e.g. nampower. I explained this in the readme:

The included launcher is intended to be easy to use and transparent to the user. It should "just work" for the most common cases. For a configurable alternative that works with VanillaFixes and supports multiple game versions, try wowreeb.

It would load VanillaFixes if its file name is "VfPatcher.Vanilla1121mod.dll"

I can rename the DLL if necessary but this would have to be done for all other DLLs like nampower.dll, SuperWoWhook.dll, etc. Maybe it would be better if you loaded DLLs from a "mods" folder or from a text file like VanillaFixes?
This code should work without any changes: https://github.com/hannesmann/vanillafixes/blob/main/src/textfile.c

I added the option to load other DLLs because otherwise it can conflict with e.g. nampower.
My loader won't work with nampower. Yes that one is special.

I can rename the DLL if necessary......
This code should work without any changes: https://github.com/hannesmann/vanillafixes/blob/main/src/textfile.c
I received some words from Discord also suggest text file is better (could have comments). So no need adapt file name to my loader, I would see if I could adapt your implementation.

it can load .dll files according to the pattern, but cannot load from the subdirectory in which the .dll+lua project is located
That's a big idea. I think need some time to come up a more complete plan like this.

I adapt textfile.c . Now both loader works the same way. (I used to load mod from working folder, now I follow VanillaFixes, using wow base folder either)
I would leave this issue open, in case we back on this topic or you need reach me.


Server Disconnected when running rs_pt_tutorial_1_web

Device : Intel Eucild
OS : ubuntu 16.04
I downloaded the lib via "apt-get install librealsense-sample beignet-opencl-icd", then I ran rs_pt_tutorial_1_web, the website show :
Server: Disconnected
How can I solve the issue..
Thanks.

The browser console shows errors:
THREE.WebGLRenderer()                   three.js:25050
init()                                                      buffer_view.js:36
                                       view.js:108


Differences between production and dev

Describe the bug
Highlighting is inconsistent between production build and webpack dev build (create-react-app)
To Reproduce
Here's a codesandbox I made which illustrates the problem:
https://1j1ym.csb.app/
Compare now with the deployed version:
https://csb-1j1ym.netlify.app/
As you can see the window is not colored in the production build
Expected behavior
Highlighting must behave the same independently of the environment
Context:
https://codesandbox.io/s/syntaxhighlighter-1j1ym
Package.json:
"react": "17.0.1",
"react-dom": "17.0.1",
"react-scripts": "4.0.0",
"@types/react-syntax-highlighter": "^13.5.0",
"react-syntax-highlighter": "^15.4.3"

I’m seeing similar behavior with tagged template literals, for example:
render() {
  return html`<div class="foo">some html</div>`;
}

In development, the nested HTML is highlighted properly, but in production it’s just one string.

This looks like a duplicate of #263


airline's denite extension get crashed when used with vim-grammarous

environment

vim: NVIM v0.2.0
vim-airline: ab6acde
OS: mac 10.12.6
Have you reproduced with a minimal vimrc: yes
What is your airline configuration: see the behaviors below for details.
if you are using terminal:
terminal: iterm2
$TERM variable: tmux-256color
color configuration (:set t_Co?): /
if you are using Neovim:
does it happen in Vim: I don't know because I don't have VIM 8.0 installed with python support.

actual behavior
See the issue here for details.
expected behavior
Airline's denite extension should not response to buffer with filetype other than denite, as @Shougo says.

Airline's denite extension should not response to buffer with filetype other than denite, as @Shougo says.

That is because of this comment If that is fixed, then we can use the normal &filetype check.
CC @Shougo

That is because of this comment If that is fixed, then we can use the normal &filetype check.

I have checked the code.
autocmd FileType denite call airline#update_statusline() is not needed.

The error still exists if you have removed the code.
I don't know about why it is called in non denite buffer.
vim-airline uses winnr.  I think vim-airline should use winid instead.

how to reproduce?

https://github.com/rhysd/vim-grammarous/issues/46#issue-252645625

it only happens in nvim?

In Vim8, I cannot find [grammarous] window.
It may be neovim only problem.  I don't know why.
@quinoa42 Ping.

sorry, I tried that. I installed neovim on debian (0.1.7), then i installed vim-plug and all those other plugin dependencies. Then I needed to install java, so I installed java. Then I needed to install the languagetool jar file, so I did that. And finally when I start with :GrammarousCheck it opens a window, that I cannot close manually, because it always reopens itsself afterwards. After finally killing that window with :2bw and running :Denite grammarous I only got a simple
[denite] denite.nvim does not work with this version.
[denite] It requires Neovim with Python3 support("+python3").

and now I don't feel adventurous for fixing this error.
Sorry, isn't there an easier way to reproduce this problem?

and now I don't feel adventurous for fixing this error.

$ pip install neovim is needed.

I still get the same error message. What do i need to set let g:python3_host_prog? The proposed value $HOME . "/.pyenv/versions/neovim3/bin/python" doesn't exist, even after installing pip install neovim

$pip3 install neovim is needed.
denite.nvim is Python3 plugin.

grr one more thing to install: sudo apt-get install python3-pip

still doesn't work

Please execute :CheckHealth command.

I installed neovim on debian (0.1.7)

This is old version...

g:ailrline_last_window_changed is something wrong.
I'm investigating the problem...

I installed neovim on debian (0.1.7)
Yeah, I figured, but I don't feel like building my own neovim and downloading another bunch of dependencies.

https://github.com/rhysd/vim-grammarous/issues/46#issuecomment-324804872
It fixes the problem.  So you don't need to test it.
I don't know why though.

BTW: removed the :let g:python3 provide Now I got a bunch of other errors:
Detected 1 grammatical error
[denite] Traceback (most recent call last):
[denite]   File "/home/chrisbra/.vim/pack/dist/start/denite.nvim/rplugin/python3/denite/__init__.py", line 33, in start
[denite]     return self._uis[buffer_name].start(args[0], args[1])
[denite]   File "/home/chrisbra/.vim/pack/dist/start/denite.nvim/rplugin/python3/denite/ui/default.py", line 97, in start
[denite]     self._denite.start(self._context)
[denite]   File "/home/chrisbra/.vim/pack/dist/start/denite.nvim/rplugin/python3/denite/denite.py", line 33, in start
[denite]     self.load_filters(context)
[denite]   File "/home/chrisbra/.vim/pack/dist/start/denite.nvim/rplugin/python3/denite/denite.py", line 202, in load_filters
[denite]     'denite.filter.' + name, path).load_module()
[denite]   File "<frozen importlib._bootstrap_external>", line 396, in _check_name_wrapper
[denite]   File "<frozen importlib._bootstrap_external>", line 817, in load_module
[denite]   File "<frozen importlib._bootstrap_external>", line 676, in load_module
[denite]   File "<frozen importlib._bootstrap>", line 268, in _load_module_shim
[denite]   File "<frozen importlib._bootstrap>", line 693, in _load
[denite]   File "<frozen importlib._bootstrap>", line 673, in _load_unlocked
[denite]   File "<frozen importlib._bootstrap_external>", line 673, in exec_module
[denite]   File "<frozen importlib._bootstrap>", line 222, in _call_with_frames_removed
[denite]   File "/home/chrisbra/.config/nvim/plugged/denite.nvim/rplugin/python3/denite/filter/converter_relative_abbr.py", line 8, in <module>
[denite]     from denite.util import relpath
[denite] ImportError: cannot import name 'relpath'
[denite] Please execute :messages command.

Plugin conflicts.
/home/chrisbra/.config/nvim/plugged/denite.nvim and /home/chrisbra/.vim/pack/dist/start/denite.nvim/

I see. I checked now in your suggested change to airline#extensions#denite#check_denite_mode

@chrisbra Hi, thanks for the fixing, but it seems that 5345c8f still cause errors(which can be reproduced with the exactly way mentioned before:
[denite] function denite#helper#call_denite[15]..denite#start[4]..<SNR>60_start[30].._denite_start[1]..denite#util#execute_path, line 11
[denite] Vim(edit):E37: No write since last change (add ! to override)
Error detected while processing function denite#get_status_sources:
line    1:
E121: Undefined variable: b:denite_statusline_sources
Error detected while processing function denite#get_status_sources:
line    1:
E15: Invalid expression: b:denite_statusline_sources
Error detected while processing function denite#get_status_path:
line    1:
E121: Undefined variable: b:denite_statusline_path
Error detected while processing function denite#get_status_path:
line    1:
E15: Invalid expression: b:denite_statusline_path
Error detected while processing function denite#get_status_linenr:
line    1:
E121: Undefined variable: b:denite_statusline_linenr
Error detected while processing function denite#get_status_linenr:
line    1:
E15: Invalid expression: b:denite_statusline_linenr
Error detected while processing function denite#get_status_sources:
line    1:
E121: Undefined variable: b:denite_statusline_sources

that should be fixed by @Shougo please. I can't do anything against that.

OK.  Denite fix is needed.
Please wait.

Fixed

thanks @Shougo!


Use final where possible and disallow construction of utility classes

This is a relatively minor change at this stage in the library's development, but its a change that you can't safely make later on if you have a lot of users.

@bowbahdoe Thank you for your contribution! The private constructors are definitely needed. I wasn't sure about making some of the classes final since case someone wanted to subclass them.. but then I can't think of a situation where subclassing either Email or EmailValidator would be necessary.
I'm going to go ahead and merge this and take care of the check style failures.


Errors exporting Principled BSDF with textures

Hi, I am trying to export a Principled BSDF material with textures (diffuse, metalness, roughness, normals) in glTF format but got errors. I've attached the textures used.
Metal_Steel_Brushed_001.zip

Probably our exporter should also tolerate these settings.

Which setting do you believe is causing the issue? The "Normal Map" node?

The reason for the error is that each of the textures for metallic and roughness are RGB textures with luminance as metallic / roughness. We assumed that only a single channel of such a texture would be responsible for metallic / roughness.
To fix it we would need to convert the a multichannel metallic / roughness input to grayscale before creating the MetallicRoughness texture.
@revyTH if you need a quick fix, add a Separate RGB node after the metallic and roughness textures and connect only one channel to the respective Principled BSDF sockets.

Could you provide a .blend or .gltf file for which the problem occurs?

Could you provide a .blend or .gltf file for which the problem occurs?

done!
cube2.zip

now the textures export correctly.
The empty node warnings come from the lights. I think it is more intuitive to leave them in, as at some point the KHR_lights_extension will use them


Can't import on android

Version: 6-official-126.2
Error: upgraded.UpgradedFactories
Android: 11
Samsung

That's my bad; I haven't dexified the jar file. I'll try to do that, but for some reason, I can't get it to work on my computer.

Yo try running this: https://github.com/genNAowl/Upgraded-Factories/releases/tag/2.1
If it works, close the issue

The person who created the issue https://github.com/genNAowl/Upgraded-Factories/issues/6 says it works on mobile now; Gonna assume it's the same for you.

After testing, it works great :)


UHUHUHU

Problem description

Problem location

I saw a problem on the following URL:

I couldn't find the information I wanted. I expected to find it near the following URL:

Other:

Project version(s) affected

Suggestions for a fix

There's isn't any information on the ticket for us to take action on. I'm closing the issue here for that reason. Feel free to add more information on the ticket to continue the conversation.


Implement transactions DB processor

We need to populate transaction data in horizon using the new experimental ingestion system. This will allow us to port the following endpoints to be compatible with the new ingestion system:
/transactions
/transactions/{tx_id}
/ledgers/transactions
/accounts/{account_id}/transactions
This work is part of #1577.

While working on this please make sure to use BatchInsertBuilder. Without it processing will be too slow for large ledger (we experience this in the old ingestion).

fixed in https://github.com/stellar/go/pull/2037


File with info about contributors and maintainers

Currently in the metadata, the info about the contributors (full name, GitHub username, email, ...) are added everytime. Then the email is often empty.
One solution for that would be to have at the root (or even better in an _data folder) a YAML file with the list of every contributors and maintainers with the useful info and with the GitHub username as key, like:
bebatut:
        name: "Bérénice Batut"
        email<EMAIL_ADDRESS>shiltemann:
        name: "Saskia Hiltemann"
        email:

and in the metadata files just having a list with the GitHub usernames of the contributors/maintainers:
contributors:
- bebatut
- shiltemann

We will need to update the layouts (_layouts/topic.html, _layouts/base_slides.html and _layouts/tutorial_hands_on.html) to parse the list and the correct information when needed.
But it will be easier to maintain and we can also add more information
What do you think?

yes, definitely, this was on my wishlist as well, makes it lot easier for contributers to update their contact information when it changes etc :+1:

We can do that once we have merged #484

fixed.


tora: fix build

Motivation for this change
We need to bump to latest unstable to fix the build.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build tora

Yeah they really should think about making a release https://github.com/tora-tool/tora/issues/132

@knedlsepp any motivation to continue with this PR?

We already have a newer version in staging.


Classic Bluetooth SPP slave with PIN

Hi,
I have problem with setting classic BT SPP slave to be secured with PIN.
Is it possible to achieve this with AT commands?
I was able to set ESP32 to be classic BT master and connect to slave which was secured with PIN,
i did it with command: "AT+BTSECPARAM=3,1,"some_pin".
But it seems it works only with master. Right?
I can't do this for slave.
I saw issue #138 and I used patch provided there and then:

I had to input PIN to be able to connect to ESP32 from my mobile :)
but:
when I try to connect to ESP32 from another ESP32 it is still possible without PIN :(
when I switch the role to master, scanning doesn't work (one of our devices has to change roles in runtime)  :(

Is this really impossilbe to set ESP32 as BT classic SPP slave with PIN using AT commands or I just make some mistake?
If this is the case are You plannning to introduce such command/commands?

Close because of no update for a long time, if you have any question, please reopen it again.


Cookies for different domains with same name disappear

It seems that cookies are stored in key / value dictionary that causing the problem in the storing cookies from different domains / subdomains in one session.
with aiohttp.ClientSession() as client:

    async with client.get('https://httpbin.org/cookies/set?test=ok') as resp:
        logging.info(await resp.json())

    async with client.get('https://httpbin.org/cookies') as resp:
        logging.info(await resp.json())

    async with client.get('https://http2bin.org/cookies/set?test=fail') as resp:
        logging.info(await resp.json())

    async with client.get('https://httpbin.org/cookies') as resp:
        logging.info(await resp.json())

    logger.info(client.cookies)

2016-08-25 21:57:38 INFO {'cookies': {'test_cookie': 'ok'}}
2016-08-25 21:57:39 INFO {'cookies': {'test_cookie': 'ok'}}
2016-08-25 21:57:39 INFO {'cookies': {'test_cookie': 'fail'}}
2016-08-25 21:57:39 INFO {'cookies': {}}

We are experiencing the same problem.

Same WIP  https://github.com/JeckLabs/aiohttp/commit/2259d07dc9fcc62c299ea95679e9fe1bed275e6a

Your WIP hack http.cookiejar.Cookie in ugly way, using very private API.
It's not acceptable.
Another question scaring me is: what to do with ClientSession.cookies?

Hmm, I think I have not used any private API, only public methods, and mock objects. That is the way requests do (see - http://docs.python-requests.org/en/master/_modules/requests/cookies/ ). I agree that's ugly, but allows use standard library code without copy/paste.
I think ClientSession.cookies return a list of Cookie in master. I fix that in https://github.com/JeckLabs/aiohttp/commit/668cbee48bf128de702cc45969e7112c59945612#diff-7dd84b5ef8d5eea2de1dfc5329411dfcL497 but maybe I missing something.
And now I have problems with tests:
In https://github.com/KeepSafe/aiohttp/blob/master/tests/test_client_functional.py#L1410 setting 3 cookies but expecting only 2.
In https://github.com/KeepSafe/aiohttp/blob/master/tests/test_client_functional.py#L1395 security flag is set but expecting receive cookie through insecure HTTP protocol.

I know how requests is implemented and considering it very dirty hack.
Better to copy-paste than mocking.
If aiohttp.CookieJar has bugs -- we should fix them.
Borrowing http.cookiejar implementation ideas is perfectly fine though.

So I can copy lib from https://hg.python.org/cpython/file/tip/Lib/test/test_http_cookiejar.py rewrite some method, and then copy tests from https://hg.python.org/cpython/file/tip/Lib/test/test_http_cookiejar.py , it's ok? Looks a bit tricky...

No, it's not OK.
I've wrote borrow implementation ideas but not "copy-paste the whole documentation along with obsolete modes and unused parts".
Do you want to use cookie policies? Do you want to support netscape-styled cookies? Really?

And, please, before starting to hack please tell me what do you want to do with ClientSession.cookies?

I can implement wrapper with SimpleCookie-like interface, it's relatively easy.
Existing aiohttp.CookieJar can be fixed to support multi-domain cookies, but I am don't understand what existed tests do, there may be some more bugs. It seems a lot of work to implement correct cookies support from scratch.

SimpleCookie is dict-like object where keys are cookie names.
It's accessible by cookies[name].
But for supporting non-overlapped domains the access should be cookies[domain][name].

Yes, cookies[doman][path][name] to be precise.
For backwards compatibility, I think your can leave SimpleCookie interface for ClientSession.cookies. Advanced users may access cookies structure via some method or additional property.

Yesterday I've tried to port http.cookiejar into aiohttp with appropriate API changing.
I've found the library has very ugly implementation and the only 85% test covered (which means all corner cases are not covered at all).
I just don't trust it and not sure if it works properly with all cookie flawors supposed to be supported by the library (it has a code for obsolete and outdated standards not used nowdays anymore).
aiohttp.CookieJar is much cleaner. I'm going to fix it's bugs.

Fixed by #1173


🐛 [firebase_massaging] Example flutter ios build is too old

Current version of flutter is 3.22.2 and If you create an application today, it will use Swift.
The current example app is old ios build on which the tests are taking place, all new users are facing a problem with message processing problems.
https://github.com/firebase/flutterfire/issues/12978
https://github.com/firebase/flutterfire/issues/12885
https://github.com/firebase/flutterfire/issues/12453
https://github.com/firebase/flutterfire/issues/12370
etc.
Can you please create working ios build with latest versions of packages with working appDelegate.swift and correct Info.plist etc. ?
I hope you will listen to the request, because now it is impossible to build a working build for production if it uses firebase_messaging and it is completely unclear what to do with it.

Any updates? Where can I see the latest instructions to configure push notifications on ios??


OpenAPI 3.0 links are not directing to the right urlMapping

❗ please do not add sensitive information in issues, you can provide extra information via email using issue number as reference ❗
Describe the issue
If servlet.ApiListenerServlet.urlMapping is changed, the OpenAPI links will still direct to /api/*
Reporter
@philipsens @nielsm5

To Reproduce
Steps to reproduce the behavior:

Set property servlet.ApiListenerServlet.urlMapping to a different url than /api/*
Go to webservices in the console
Click on a OpenAPI 3.0 link
See error

Seems to has been partially implemented in #3183


[Bug]: preview  not working in nested jsx

Version
System:
  OS: macOS 12.5
  CPU: (8) arm64 Apple M2
  Memory: 94.36 MB / 24.00 GB
  Shell: 5.8.1 - /bin/zsh
Browsers:
  Chrome: 117.0.5938.132
  Safari: 15.6
npmPackages:
  @rspress/plugin-last-updated: ^1.2.1 => 1.2.1
  @rspress/plugin-preview: ^1.2.1 => 1.2.1
  @rspress/plugin-typedoc: ^1.2.1 => 1.2.1
  rspress: ^1.2.1 => 1.2.1

Details
The  syntax provide a simple way to use complex components. I want to customize the outer layout of the preview and wrap the code with a layout component like this:

However, it failed. The code is not transformed into the preview component and retains its original content.

Reproduce link
https://github.com/kainstar/reproduce/tree/main/rspress-preview-in-nested-jsx-not-working
Reproduce Steps

pnpm install
open http://localhost:8080
only one preview block in page, expect two

Thank you for feedback. It'a bug from the AST traverse logic in preview plugin.


Feature: Create docs for input component

Is your feature request related to a problem? Please describe.
We need documentation for each component in the library (docs are in the readme)
Describe the solution you'd like
Add docs for input component

Hello, I'd love to help

hi @LucasMelvin15  Thank you. I'd rather this issue be solved by the person who created the component, so she can get more practice making PRs. Why don't you create a component yourself and write the documentation for it as well?


Python Style Guide

In the Dev COP discussion last week, cross-team code review was brought up as a nice-to-have, but often times non-team members don't necessarily know where it's appropriate to jump in. I think we can improve that one the back-end (and break down some of the barriers between our teams) with a Python style guide. This is also something that's come up in other conversations I've had over the past few weeks, and in a couple of code reviews I've participated in.
I know we generally try to follow PEP8, I know, but there are some idioms and conventions we might want to adopt for our own use that aren't covered by PEP8. Plus it's always nice to document the rationale we might have, as opposed to simply "because PEP8" — it opens it up to fully-informed reconsideration later.
An example that's more verbose than I'd anticipate us creating is Google's Python Style Guide. What's nice about Google's is it breaks down the rules into their pros and cons and decision-making.
There are three main concerns I'd have a style guide address, consistency, continuity, and readability.

Consistency and continuity
We have project teams that may pick up a project another team last worked one, and that was perhaps created by a different team altogether. We've got a lot of code that was writen by individuals that're no longer here, and we have people who've joined since they left.
This state of affairs is likely to continue, and so ensuring some consistency in our style across projects can help mitigate some of the overhead that comes from this sort of churn. Our code should be as easy as possible for others to maintain and extend as needed, long after we're gone.

Readability
Part of what makes code easier for others to maintain and extend is its readability. With a shared understanding of, say, the way lambdas are used, you're less likely to need to spend a lot of time understanding a five-line lambda that's used to sort a list of dictionaries (example from my own past).
In other words, you can spend less time trying to understand the mundane problems being solved, and more time understanding the way the more interesting problems are being solved.

I think this would also permit some more cross-team code reviews, because if we have a consistent style as a discipline, it means we can focus on more of the interesting bits of code, and less on variable naming, use of list comprehensions, that may vary from team to team, and than one of us from a different team might not be aware of.
I'm interested in what everyone thinks, if you have any favorite resources for Python style, or if you have strong feelings one way or the other about conventions or idioms we use, should be using, should not be using, etc. I would like to spend most of our meeting today discussing this.
Here are some resources I find helpful:

PEP8
Google's Python Style Guide
The Hitchiker's Guide to Python

Ultimately consistency and continuity are the core of what this whole effort to create back-end standards is all about. To get that effort moving again, I want to go back down and start at the bottom, the way we're writing our code, and then we can go from there.
I also realize not all of us write Python, and perhaps as part of this we can come up with some language-agnostic conventions that would help across languages. I'd welcome the input of those of you working on non-Python projects here.

This is a great relevant talk by Raymond Hettinger from PyCon 2015:
https://www.youtube.com/watch?v=wf-BqAjZb8M
He shows lots of good examples of how code can technically comply with PEP8 but not be as "Pythonic" as possible.

I love that his framing boils down to "don't commit atrocities".

I missed the gorilla
On Wed, Mar 9, 2016 at 11:44 AM, Will Barton<EMAIL_ADDRESS>wrote:

I love that his framing boils down to "don't commit atrocities".
—
Reply to this email directly or view it on GitHub
https://github.com/cfpb/back-end/issues/14#issuecomment-194389739.

Python Style Guide
I think there are a few basic steps to getting this underway:

We need to assemble any examples of Python style that we currently try to check for/enforce.

eRegs uses flake8 on a couple of repositories. What checks are disabled?
There's a Django linter that invokes pylint. What checks are disabled there? (Pointed out by @higs4281)
What are some examples of that we would consider to be Good Code™ here at CFPB (Python, Scala, or any language, really)? (@chosak)
Does Clousseu have any checks that would be relevant from a
stylistic point of view?

With that knowledge, what are some of the idioms, conventions, patterns, etc we want to encourage and/or enforce? Which ones are covered by some existing document (PEP8, etc) that we can link to?

We need to provide some level of automation for checking and authoring (excellent idea from @chosak).

Can we provide flake8 extensions for our rules and recommendations?
Can we provide editor configuration for vim, Sublime, etc, that will help author code in our prefered style?

@hillaryj has some experience creating a Python style guide.
@cfpb/back-end-team-admin, does anyone have anything else I'm missing?
--
So, I think the next step is to figure out some of the answers to the questions in 1. That will inform how we proceed.

Also for reference, the front-end team's JavaScript Guide.

I've been thinking a lot about this the past few weeks, and I think we need to start small. Let's start with editor configs, so we are all on the same page and we can generate some working artifacts from this effort right away. Then we can scale up to particular idioms/conventions in code we want to adhere to.
I'm going to propose that we follow PEP8 on identation and spaces-over-tabs. For maximum line numbers, I think we need something more sane than 79 chars. Does anyone have any particular favorite line lengths?
This gets us started with something, and we can continue to survey our existing landscape for particular examples of good style, style we want to discourage, etc.

By more sane do you mean greater than or less than 79 chars?  I think anything between 60 and 75 is good.  But I also think this shouldn't apply to characters from indentation. I feel like the main benefit is readability, not really the reasons listed here("Limiting the required editor window width makes it possible to have several files open side-by-side, and works well when using code review tools that present the two versions in adjacent columns") since we all have displays anyway.

I also prefer narrow lines (79 max) for readability's sake. Even though longer lines work on external displays, they're a real pain when you do disconnect and work directly from the laptop. 79 makes it easy to have two files open side by side on a normal laptop screen.

Why I prefer longer char lengths is that sometimes you have a long string and I hate breaking up strings artificially just to hew to a line length, especially because indentation can easily chew up a lot of your line space in python. Probably 95% of my code is 80 characters ore less, but my longest lines are almost exclusively strings with 12-20 characters of indentation and are typically up to 100 characters wide.
I support making a general line length guideline but also allowing for exceptions in cases that prevent, for example, chopping and hacking 12 characters off the end of a string just so it fits the line length.

@hillaryj Yeah, as I mentioned in my comment, I think this limit shouldn't apply to indentation. I'm not sure if there is a tool that does that already, but that would be ideal.

I think it's something we have to deal with — you could probably construct some custom text-width rules for vim that wouldn't take into account indentation, but it would likely be fairly fragile.
I have one other concerns though. Any maximum line width is intended to increase readability of the file by avoiding any weird text-wrapping that may happen as a result of not setting a line width or (if wrapping is disabled) side-scrolling. The width of my editor window doesn't change with each line, so if I have two lines, one with greater indentation but each with 80 chars of actual content, one will still either require wrapping or scrolling.
I think the width of windows (and ultimately screens when we're comparing files side-by-side) is going to dictate a maximum number of characters, spaces included, that can realistically be displayed on a line.

I'd add, I have spent years with vim configured at 79 characters, so that's my personal normal.
I would also strongly encourage anyone to break whatever line-width rules we might establish before doing something obscene to a string or anything else. Readability is the whole point.

The front-end team uses 80 characters. Since hopping between front-end and back-end code isn't that unusual, it may be worth keeping them consistent (even if that means changing what the front-end team uses).

I think consistency across all our development would be an excellent reason to choose 80.

I like the idea of cross-team consistency, but not really all that opinionated otherwise. This seems like one of those things where it's more valuable to make a decision and stick with it, than worry too much about making the right decision.

Alright, so let's adopt the front-end's line widths for consistency.
Next, I'd like to use line-widths and spaces as a starting point for editor configurations. The files can live in this repo (perhaps under editors/).  I can start a CFPB vim config, but it'd be good to have others volunteer to start configs for their editors of choice (I know with with Sublime users, not sure what else).
That gives us a starting point for other common config values we want to share across the discipline.

Coming out of discussion in GHE/CFGOV/platform/issues/183, we have the following which can be made into an alias or added as a pre-commit hook to run flake8 only on files that have been changed in git:
flake8 $(git status -s | grep -E '\.py$' | cut -c 4-)


Add Ionic 4 Support

Fix https://github.com/oktadeveloper/ionic-jhipster-starter/issues/19
Fix https://github.com/oktadeveloper/generator-jhipster-ionic/issues/67
Fix https://github.com/oktadeveloper/generator-jhipster-ionic/issues/58
Fix https://github.com/oktadeveloper/ionic-jhipster-starter/issues/18
Auth supported

[x] JWT
[ ] OAuth

App tested

[x] Monolith
[ ] Microservices

Left TODO

[x] Replace baseref in ionic.starter.json with latest hash commit
[x] Add editorconfig
[ ] Add entity support (will be added once this starter is available on the ionic-team repo)
[x] Update README.md
[ ] Fix CI?

Hi,
I tried to generate ionic 4 app to integrate jhipster  (" ionic start ionic4testi oktadeveloper/jhipster").
But I got the following error.
Unable to find starter template for oktadeveloper/jhipster
Could you please advise me.
Regards
Senaka

Yes, you got this error because my PR in the ionic-teams repository (https://github.com/ionic-team/starters/pull/749) has not been merged.
So the code in this repo isn't available at this time.
The CI is failing and I have to handle it to merge the PR in their repo.
By the way, I can provide you a workaround if you want this code right now


Compiler does not pass on the sampler

The sampler argument in generated alias fname_model(sampler::Turing.Sampler) is currently dropped. This might be a bug or unwanted behaviour.

I don't think this is still relevant now.


Feature Request: TAR file support

I see only rar unpacking is supported. LIDARR pulls approx 10% tar files - I have a bash script that deals with rar and tar and hoping to replace fully

Unpackerr supports most files types including tar files.

Thanks. Just reviewing release history and saw that 🤦♂

It uses this library and supports the same formats found in the readme. https://github.com/golift/xtractr


Added more accurate details on final constant use

Previous explanations was lightly incorrect - I tried to fix it without over complicating the subject.

[X] I have read freeCodeCamp's contribution guidelines.
[X] My pull request has a descriptive title (not a vague title like Update index.md)
[X] My pull request targets the master branch of freeCodeCamp.
[X] None of my changes are plagiarized from another source without proper attribution.
[X] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Could you please retry the check? It only failed due to a bug that was fixed by #24240.

All checks have passed now - please let me know if there is anything else I need to do on this pull request. Thank you.

All checks have passed now - please let me know if there is anything else I need to do on this pull request. Thank you.

Hello,
Sorry for no responses for a while, I have been very busy with school work unfortunately. I will submit a new PR in a few days - would you like me to reopen the PR now or once I have made the changes?
Thank you,
Harrison

Hi,
That's all right, take your time. I've re-opened the PR.


Attempting to fix timeouts of segmented iterator tests

flyby: add missing dependency to segmented_algorithm module

Performance test reportHPX PerformanceComparisonBENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTORFor Each(=)(=)(=)InfoPropertyBeforeAfterHPX Commita68196882e3e093ba44367f6675f538d613c9aa31b9579b501abe6fd046ed209714b3bff7308883aHPX Datetime2022-02-09T15:45:06+00:002022-04-11T19:07:40+00:00Hostnamenid00729nid01480Datetime2022-02-09T17:03:21.440240+01:002022-04-11T21:49:56.626678+02:00Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0ClusternamedaintdaintEnvfileComparisonBENCHMARKNO-EXECUTORFuture Overhead - Create Thread Hierarchical - Latch+InfoPropertyBeforeAfterHPX Commit96a2e4bd1c76207dea8d5302784962c9278824061b9579b501abe6fd046ed209714b3bff7308883aHPX Datetime2021-11-11T08:14:57+00:002022-04-11T19:07:40+00:00Hostnamenid00006nid01480Datetime2021-11-11T09:28:13.071121+01:002022-04-11T21:50:16.387604+02:00Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0ClusternamedaintdaintEnvfileComparisonBENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATORStream Benchmark - Add(=)--Stream Benchmark - Scale(=)(=)(=)Stream Benchmark - Triad(=)(=)-Stream Benchmark - Copy(=)(=)(=)InfoPropertyBeforeAfterHPX Commit71d8dbe40b737be02ea734f9d98fcc0b1e21f01a1b9579b501abe6fd046ed209714b3bff7308883aHPX Datetime2021-11-10T19:14:21+00:002022-04-11T19:07:40+00:00Hostnamenid00120nid01480Datetime2021-11-10T20:28:18.266961+01:002022-04-11T21:50:34.664829+02:00Compiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0ClusternamedaintdaintEnvfileExplanation of SymbolsSymbolMEANING=No performance change (confidence interval within ±1%)(=)Probably no performance change (confidence interval within ±2%)(+)/(-)Very small performance improvement/degradation (≤1%)+/-Small performance improvement/degradation (≤5%)++/--Large performance improvement/degradation (≤10%)+++/---Very large performance improvement/degradation (>10%)?Probably no change, but quite large uncertainty (confidence interval with ±5%)??Unclear result, very large uncertainty (±10%)???Something unexpected…

This indeed fixes all the timeouts. More problems with the segmented algorithms persist, however.


Tabs vertically centered

Describe the bug
I adore the theme and I'm using it in combination with catppuccin, but for some reason the tabs and some of the buttons are not vertically centered in the navbar. I tried changing stuff like --tab-min-height, add some paddings and margins and so on, but nothing seems to help and something is always off in the end.
They are off by few pixels and in reality it's not a big deal, but for some reason it's driving me crazy. Do you have any suggestions how to fix it?
Screenshots (optional)

So I created a new profile and cloned the repo to check it out and that was the moment that I realized something. The theme is fine, even with my custom config.
I use FancyZones and I like my apps not fully maximized, but the OS creates 1px grayish border around every window that is not fullscreen and that's why everything looks off 😄 I measured it again and everything is perfect when I take that 1px into account.
Thank you for the support and for the awesome theme and sorry for the issue, you may close it.

Ah, okay. I honestly wouldn't have wondered if this is another thing to add to the long list of things that behave differently on different setups. But I'm relieved that it's not. :D
No worries – I'd always rather want people to open issues and get them resolved, than people with issues being to afraid to ask. The goal is to have a solution in the end. And this can always be a reference for people experiencing similar issues. ^—^


Loading stripe domains in HiGlass

Hi, a colleague of mine analyzed "stripe" domains in our HiC maps using the method described in Vian et al 2018. He sent me text files. Can these "stripe" annotations be loaded into HiGlass?

Can you share the files?

Samir_batch3_N_A_MboI_20K.txt
Samir_batch3_G_A_MboI_20K.txt

Have you tried using clodius aggregate bedpe?
https://docs.higlass.io/data_preparation.html#bedpe-like-files

Yes, thank you! That worked!


Solved but for other beginners: invalid record at line ...

Hey,
thanks for that crate! I'm trying to get my arduino-nano to work. During flashing it reports: invalid record at line and a line number.
The output when I try to flash:
❯ avrdude -C/etc/avrdude/avrdude.conf -v -patmega168 -carduino -P/dev/ttyUSB0 -b19200 -D -Uflash:w:target/avr-atmega168/release/rust-arduino-blink.elf:i

avrdude: Version 6.3, compiled on Jan 26 2021 at 00:00:00
         Copyright (c) 2000-2005 Brian Dean, http://www.bdmicro.com/
         Copyright (c) 2007-2014 Joerg Wunsch

         System wide configuration file is "/etc/avrdude/avrdude.conf"
         User configuration file is "/home/dietrich/.avrduderc"
         User configuration file does not exist or is not a regular file, skipping

         Using Port                    : /dev/ttyUSB0
         Using Programmer              : arduino
         Overriding Baud Rate          : 19200
         AVR Part                      : ATmega168
         Chip Erase delay              : 9000 us
         PAGEL                         : PD7
         BS2                           : PC2
         RESET disposition             : dedicated
         RETRY pulse                   : SCK
         serial program mode           : yes
         parallel program mode         : yes
         Timeout                       : 200
         StabDelay                     : 100
         CmdexeDelay                   : 25
         SyncLoops                     : 32
         ByteDelay                     : 0
         PollIndex                     : 3
         PollValue                     : 0x53
         Memory Detail                 :

                                  Block Poll               Page                       Polled
           Memory Type Mode Delay Size  Indx Paged  Size   Size #Pages MinW  MaxW   ReadBack
           ----------- ---- ----- ----- ---- ------ ------ ---- ------ ----- ----- ---------
           eeprom        65    20     4    0 no        512    4      0  3600  3600 0xff 0xff
           flash         65     6   128    0 yes     16384  128    128  4500  4500 0xff 0xff
           lfuse          0     0     0    0 no          1    0      0  4500  4500 0x00 0x00
           hfuse          0     0     0    0 no          1    0      0  4500  4500 0x00 0x00
           efuse          0     0     0    0 no          1    0      0  4500  4500 0x00 0x00
           lock           0     0     0    0 no          1    0      0  4500  4500 0x00 0x00
           calibration    0     0     0    0 no          1    0      0     0     0 0x00 0x00
           signature      0     0     0    0 no          3    0      0     0     0 0x00 0x00

         Programmer Type : Arduino
         Description     : Arduino
         Hardware Version: 2
         Firmware Version: 1.16
         Vtarget         : 0.0 V
         Varef           : 0.0 V
         Oscillator      : Off
         SCK period      : 0.1 us

avrdude: AVR device initialized and ready to accept instructions

Reading | ################################################## | 100% 0.01s

avrdude: Device signature = 0x1e9406 (probably m168)
avrdude: safemode: hfuse reads as 0
avrdude: safemode: efuse reads as 0
avrdude: reading input file "target/avr-atmega168/release/rust-arduino-blink.elf"
avrdude: invalid record at line 51 of "target/avr-atmega168/release/rust-arduino-blink.elf"
avrdude: read from file 'target/avr-atmega168/release/rust-arduino-blink.elf' failed

avrdude: safemode: hfuse reads as 0
avrdude: safemode: efuse reads as 0
avrdude: safemode: Fuses OK (E:00, H:00, L:00)

avrdude done.  Thank you.

Solution
The problem was that the .elf file cannot be flashed directly, but rather needs to be "extracted" to a hex file using:
$ avr-objcopy -O ihex target/avr-atmega168/release/rust-arduino-blink.elf arduino-blink.hex
$ avrdude -C/etc/avrdude/avrdude.conf -v -patmega168 -carduino -P/dev/ttyUSB0 -b19200 -D -Uflash:w:arduino-blink.hex:i

On Fri, Jul 09, 2021 at 11:20:37AM -0700, Franz Dietrich wrote:

Closed #191.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/Rahix/avr-hal/issues/191#event-5001697327

Please consider to create a patch against our documentation.

@enaut, you seem to have an old version of avrdude.  Maybe consider upgrading?  Also, your Arduino Nano has an ATmega328P, not an ATmega168 so something is off with your commandline...
That said, I suggest you give the ravedude tool a shot.  It takes care of calling avrdude for you with the correct parameters, integrates with cargo nicely, and has a serial console if you need it.

@Rahix thanks for the reply - I do have avrdude 6.3 that seems to be recent - its from the fedora repositories? I do have an arduino nano with atmega168 and one with atmega328p did I mix something?
ravedude looks awesome!

I do have avrdude 6.3 that seems to be recent

Ah, wait, I was so used to seeing these problems due to old avrdude that I didn't look close enough.  You're commandline is wrong, the :i at the end needs to be :e for elf files.

I do have an arduino nano with atmega168 and one with atmega328p did I mix something?

I wasn't aware of any nano with ATmega168... Do you have any online information about that?  I only know of the ATmega328P version.

Oh so thanks :e is indeed way easier than manually converting.
It's not an actual arduino but a clone:
Many of the ebay clones are with the smaller chip for even cheaper nanos... just search for arduino nano 168 on ebay...
I didn't know about different chips either... and bought a small one instead of a 328p but the program I want to fit is too big. Hence I bought another with the bigger chip.


Monthly upgrade round for MCs

Bump components and deploy on all MCs
Testing:

[x]  gaia
[x]  gauss
[x]  ginger
[x]  giraffe
[x]  godsmack
[x]  gremlin

Production:

[ ]  akita
[x]  alpaca
[x]  anaconda
[x]  anchovy
[x]  anteater
[x]  argali
[x]  bandicoot
[x]  eagle
[x]  flamingo
[x]  fox
[ ]  gecko
[x]  goku
[x]  gollum
[x]  gorilla
[x]  icecream
[x]  kudu
[x]  otter
[x]  potato
[x]  talos
[x]  tiger
[x]  valkyrie
[x]  viking
[x]  viper
[x]  visitor

gecko will be rolled by Lorenzo and Dustin once SSO set up will be ready.


tf.unstack:AttributeError: 'module' object has no attribute 'unstack'

I am trying to use tf.unstack but is getting the error:
AttributeError: 'module' object has no attribute 'unstack'
I am trying the alternative code version of the two lines in ptb_word_lm.py

Could you fill out the issue template? (version info, reproducible example)

version: 0.11.0
reproducible example:
inputs = tf.unstack(inputs, num=num_steps, axis=1)
I am trying out ptb_word_lm.py provided with tensorflow itself. In the middle of the code a commented out portion provides a suggested improvement to the code. I am trying that suggestion. The line of code above is already provided by the original version of the ptb_word_lm.py but commented.My entire code is:
http://pastebin.com/U9guTEbv

tf.unstack wasn't added until v1.0.0-alpha. Try upgrading.

jart can you pls tell me which of the .py files have the unstack function? Actually upgrading is a problem in my machine.

@sharod Here's the commit that added unstack: https://github.com/tensorflow/tensorflow/commit/0ee63d0cdb63df0f34dada5176d6a5ad92fbccab. It appears to be a renaming of tf.unpack. So you should actually be able to just use that function in its place.