adding sonar major version 4.16

Hi Linda,
5 Checks failed above and I see following error:
module.hub_hadr[0].null_resource.exec_replication_cycle_on_dr (remote-exec): The exception was: "Replication script exited with code 1, full error: {'ok': 0.0, 'errmsg': 'Replication script exited with code 1', 'code': 151}"
Please share the access instructions for a live system so that I can pass on to respective team to look into this error.

Hi Jagdeep, the ssh keys of the environment are added to the github action as "Artifact", you can see then if you scroll down the action main page. By default, when an action runs, whether successful or failed, the resources are destroyed. To keep the resources for an investigation, you can use the "delay destroy" feature when you run the action manually.

Hi Linda - I was able to find the SSH key from Sonar machine from "Artifacts" section on Github actions page. and I successfully manually triggered the github actions with "delay destroy" option. But, I am facing issue while finding the public ip of host servers. I think I need to go through jumphost. Please share the jumphost information so that we can ssh to those servers.

Hi Jagdeep, you are right, when the machine is not publicly accessible, you have to go via a jump server. Usually, depending on the terraform example/recipe, the Hub is accessible directly and the gateways are accessible via a jump server which is the Hub. Now, you don't need to build the ssh command yourself, we generate it and we take into account whether there is a jump server or not. You can see in the terraform output, for each machine, what is the ssh command to reach it. You can find the terraform output in one of the steps in the github action output.

HI Linda. thanks for the information. I checked terraform output and i think i found the ssh command. I will try sshing with it.

Sure

Hi Team.. while pushing changes for adding major 4.16 version, github actions is failing. to debug, i re-ran the workflow manually with delay destroy. now i need to ssh to the created DR machine. i have the ssh key and ssh command. but i am getting following error:
➜ ~ ssh -i ssh_keys/dsf_ssh_key-dsf_cli-sonar-132-1-<EMAIL_ADDRESS>ssh: connect to host ec2-13-41-252-225.eu-west-2.compute.amazonaws.com port 22: Operation timed out
manual run link: https://github.com/imperva/dsfkit/actions/runs/9811668509
what might be the issue here?

Hi @jagdeep-sonar , the time has come to merge each product PR now. Do you know why the tests have failed. Can you fix it?

I don't know the cause yet. I was unable to access the logs of the machines created because of permission issues. Raised following PRs to sort permission issues:
https://github.com/imperva/dsfkit/pull/429
https://github.com/imperva/dsfkit/pull/433
waiting for approval on the later.
Once above PRs are merged in dev branch, i will pull latest code, add changes for 4.16 major version, then push the changes and pull logs if tests fail again.
Till then we can close this PR without merge. I will create new PR when changes are ready. does it sound ok?

I don't know the cause yet. I was unable to access the logs of the machines created because of permission issues. Raised following PRs to sort permission issues: #429 #433
waiting for approval on the later.
Once above PRs are merged in dev branch, i will pull latest code, add changes for 4.16 major version, then push the changes and pull logs if tests fail again.
Till then we can close this PR without merge. I will create new PR when changes are ready. does it sound ok?

You don't have to close and open a new PR. Once the new PRs are merged, you can just rebase this on top of the new dev branch

ok. sounds good. thank you.

rebased my branch to latest dev branch and pushed changes. ran github actions manually: https://github.com/imperva/dsfkit/actions/runs/10308411878
DSF POC CLI - AWS #137 failed.. tried to ssh into hub_dr to get replication logs, but again getting connection timeout:
➜  ~ ssh -i ssh_keys/dsf_ssh_key-dsf_cli-sonar-137-1-<EMAIL_ADDRESS>ssh: connect to host ec2-13-43-249-99.eu-west-2.compute.amazonaws.com port 22: Operation timed out
will investigate more on this tomorrow.

rebased my branch to latest dev branch and pushed changes. ran github actions manually: https://github.com/imperva/dsfkit/actions/runs/10308411878
DSF POC CLI - AWS #137 failed.. tried to ssh into hub_dr to get replication logs, but again getting connection timeout: ➜ ~ ssh -i ssh_keys/dsf_ssh_key-dsf_cli-sonar-137-1-<EMAIL_ADDRESS>ssh: connect to host ec2-13-43-249-99.eu-west-2.compute.amazonaws.com port 22: Operation timed out
will investigate more on this tomorrow.

You can't login because the environment is terminated once the test finishes. I have tried to re-run the failed jobs twice and it still failed during the replication process with some

module.agentless_gw_hadr[0].null_resource.exec_replication_cycle_on_dr (remote-exec): Replication failed!

It gives a feeling like it is deterministic failure.
To keep the environment up after a failure you need to set this attribute when you kick a manual test

rebased my branch to latest dev branch and pushed changes. ran github actions manually: https://github.com/imperva/dsfkit/actions/runs/10308411878
DSF POC CLI - AWS #137 failed.. tried to ssh into hub_dr to get replication logs, but again getting connection timeout: ➜ ~ ssh -i ssh_keys/dsf_ssh_key-dsf_cli-sonar-137-1-<EMAIL_ADDRESS>ssh: connect to host ec2-13-43-249-99.eu-west-2.compute.amazonaws.com port 22: Operation timed out
will investigate more on this tomorrow.

You can't login because the environment is terminated once the test finishes. I have tried to re-run the failed jobs twice and it still failed during the replication process with some

module.agentless_gw_hadr[0].null_resource.exec_replication_cycle_on_dr (remote-exec): Replication failed!

It gives a feeling like it is deterministic failure. To keep the environment up after a failure you need to set this attribute when you kick a manual test

Hi Eytan,
I selected this delay destroy option yesterday as well and then i did the same today and the build failed again:https://github.com/imperva/dsfkit/actions/runs/10357545368/job/28669795935

but then when i tried to ssh to hub_dr machine, i get same error again:

Hi Jagdeep, the delay is 30 minutes, after that the env is destroyed. See DESTROY_DELAY_SECONDS in https://github.com/imperva/dsfkit/blob/master/.github/workflows/dsf_poc_cli.yml
Did you run ssh during this timeframe?

HI Linda,
workflow run: https://github.com/imperva/dsfkit/actions/runs/10376028524
i tried within the 30 min window.

but still getting operation timeout for hub_dr and hub_main.

my branch has the latest ssh_cidr code as well to allow vancouver traffic:

can we get on a call to sort this out? or can you try manually running and then sshing into hub_dr machine? need to know if i am missing something.

Hi Jagdeep, I just started a manual run with a destroy delay. I will let you know. We can have a call if needed.

Hi Jagdeep, I successfully sshed to the Hub DR.

Please check that the CIDRs I used for your location are correct. Does your IP fall in one of these two? "<IP_ADDRESS>/28", "<IP_ADDRESS>/28"
If not, please let me know what are the correct CIDRs for your location. Thanks.

HI Linda,
my ip doesn't fall under above mentioned 2 ranges. Correct CIDRs for our location are mentioned below:
{
"id": "GP-US-North-West",
"comment":"Global-Protect VPN POP, US-North-West",
"ipRanges": [
"<IP_ADDRESS>/32",
"<IP_ADDRESS>/32",
"<IP_ADDRESS>/32",
"<IP_ADDRESS>/32",
"<IP_ADDRESS>/32",
"<IP_ADDRESS>/32"
]
},
{
"id": "GP-Canada-West",
"comment":"Global-Protect VPN POP, Canada-West",
"ipRanges": [
"<IP_ADDRESS>/32",
"<IP_ADDRESS>/32",
"<IP_ADDRESS>/32",
"<IP_ADDRESS>/32",
"<IP_ADDRESS>/32",
"<IP_ADDRESS>/32"
]
},
Reference: https://gitlab.imperva.local/imperva_infrastructure/it-networking/-/blob/master/Imperva-GP-Public-IPs.json
Please add these to the ALLOWED_SSH_CIDRS secret in Github.

Hi Jagdeep, I have added GP-Canada-West and GP-US-North-West to ALLOWED_SSH_CIDRS secret.

HI Linda,
Thanks for adding the new CIDRs. it works. i am able to SSH into machines.
Shared audit.log with David. will also fetch replication.log and share.

shared replication.log with David.

shared replication.log with David.

Any updates with that?

<IP_ADDRESS>.0 has issues with replication. we are waiting for <IP_ADDRESS>.0 which has fixes. it is currently in QA testing.

<IP_ADDRESS>.0 had issues with replication. so it is not be used anymore. Replacing 4.16 major version with <IP_ADDRESS>.0.
PR for dsfkit_backend: https://github.com/imperva/dsfkit_backend/pull/43

@eytannnaim are we able to get approval on this PR?


subtract locked tokens from balance

great but I think it would be better if locked would be returned separatly and then client would decide for themselves if he want to deduct it from the total or not.
There's also probably a separate field for reserved amount somewhere, try to see if it's there

So please instead of dedducting from balance, return 2 more fields
locked and reserved

Great, please also update balance example in README


Support Dart SDK 2.0.0

Pub resolution fails on projects that use Dart SDK 2.0.0+

Please add support to Dart SDK 2.0.0


Grunt build (fixes #955)

Alters the grunt build task to use graceful-fs and Promises. I have linted/tested locally but I cannot run Sauce CI as I do not have an account.

This looks incredible @tuespetre <3 -- running on CI :-)

@triblondon thank you! From what I understand, graceful-fs wraps the async read and write functions with a try/catch that will retry the action asynchronously as long as an EMFILE error is thrown.


scriptId: add NOTIFICATION_DISPLAY_INIT

Adds the NOTIFICATION_DISPLAY_INIT ScriptID.
Referencing the following cs2 file.
https://github.com/Joshua-F/cs2-scripts/blob/master/scripts/[clientscript,notification_display_init].cs2

We don't add ID definitions to the api unless they're used in the core client, as we otherwise cannot verify their accuracy.


Lazy Load Doesn't Function When Using gotoSlide()

Enjoy using this plugin and have started to implement it on a website that I am working on. Everything works great except for one issue with the lazy loading of the slider images. When You use the gotoSlide via javascript and go to a slide that hasn't loaded yet, the slide stays as the loading image and doesn't replace the source. Any ideas as to what is going on with this or how to fix it?

I wasn't able to replicate the problem. For me the images load well even when using the gotoSlide method. Can you post a link to your page?

I emailed you the link, just don't want the link published. Thank you for your help.

OK. I took a look at the page and I noticed that an error is thrown when you call gotoSlide(). You can see the error in the Console, in Developer Tools or Firebug. Please check what value is passed to gotoSlide and make sure it's an integer.

Thanks for the help David. I can't believe I didn't see that, spent hours testing this thing and never once realized that I was passing the numbers as a string.
Anyhow, anyone else facing the same issue make sure you use parseInt()
imageID = parseInt(imageID);
$('#sliderID').sliderPro('gotoSlide',imageID);


Use pac4j to protect the /authorize OAuth endpoint

I updated the pull request with automatic tickets delegator registration. It's ready for review and merge.

Excellent. I'll set some time aside tomorrow to review. Thanks.

It's a re-foundation which should make future improvements a lot easier.

:+1:
Looks good to me. Like the auto-registration method. Substantial work. Thanks!

@frett : any concern with this pull request?

So, AccessToken extends OAuthCode, which implies you can use an AccessToken anywhere you could use an OAuthCode, would there be any security implications tied to this?
maybe a better model is to have a base OAuthToken interface that both OAuthCode and AccessToken directly inherit from, this would be analogous to the Ticket, ServiceTicket, TicketGrantingTicket interfaces.

also, the JpaTicketRegistry would needs to be updated to understand those new types because several parts of that TicketRegistry explicitly reference different ticket types. (e.g. getTickets, getRawTicket, deleteSingleTicket)

The AccessToken and OAuthCode don't need a hierarchical relationship between them, even if the access token is stronger in terms of security.  I will do what you propose and add an OAuthToken parent for both.

For the JpaTicketRegistry, there is indeed a problem in the OAuth tokens deletion. I kept the AccessTokenImpl to be a son of OAuthCodeImpl (like PT and ST) to make things easier, even if (as I said previously), the AccessToken is not a son of OAuthCode,  both are children of OAuthToken. OAuthToken,  OAuthCode and OAuthCodeImpl are now in the cas-server-support-oauth-core module which has become a dependency of the JpaTicketRegistry module. And deletion queries will be added.

cas-server-support-oauth-core module which has become a dependency of the JpaTicketRegistry module. And deletion queries will be added.

How do you mean? I am not sure I entirely follow that. Why is dependency needed? and is there a way to keep this separate via pluggable injection points?

For example, in the deleteSingleTicket method, the appropriate query is created according to the type of the ticket.

I just updated the pull request, taken into account @frett 's comments. See: https://github.com/Jasig/cas/pull/1463/files#diff-4bdbc0e2e88e2d337ea33f88245438a4R134 for the JpaTicketRegistry changes.

Gotcha. One other question, is it possible to keep API changes in a core-api module for oauth, and keep impls separate?

It's certainly feasible, but isn't it a bit too much here? What's the expected benefit to have a oauth-core-api module?

Does the oauth module auto enable anything in the cas context? I find that in certain cases, one might just need a dependency on the API modules without the actual impl, and it's also helpful to know a dedicated module just for APIs. (This actually annoys me about the JPA ticket registry because both API and Impls of another module are bundled, but I dont know of a better way since annotations for JPA are required in impl classes)

The cas-server-support-oauth-core only contains tokens interfaces and implementations. Things are enabled when using the cas-server-support-oauth module. So I think we don't have the problem here, do we?

I'm going to skim over this once more today. For now I think the JPA support will work.
I do want to try and come up with a more dynamic way to register Ticket/OAuth types with the JpaTicketRegistry so we don't need the explicit dependency on OAuth. But I don't think that should hold up this work and can be accomplished in a separate PR.

Good deal.

added #1502 to capture the need to refactor JpaTicketRegistry

1 minor property comment, otherwise +1

Will merge to move to the next OAuth issue...


Procedure request: Please provide a getter-procedure for HideDialog in Codeunit "SignServContractDoc"

Please provide in Codeunit "SignServContractDoc":
procedure GetHideDialog(): Boolean
begin
exit(HideDialog);
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


docstring method for Base.Docs.doc(::Py)

It might be nice to make the Julia help fetch the Python docstrings if available?
Something like this: https://github.com/JuliaPy/PyCall.jl/blob/2728e20162db3c90198e2828c40e675924c73528/src/PyCall.jl#L260-L268

I already overloaded Docs.getdoc so help> pybuiltins.int works, for example. But I've just added an overload for Docs.doc too.

Yayy docstrings! 🌈

can we get a new release with this feature?

I've just updated it so the docstring is rendered as a code block. It's not especially pretty, but at least it preserves the formatting of the docstring.

There are some breaking changes on main, so I'm not rushing into another release, but it won't be long.


NPPES Mapping Update

Pull requests into this repository require the following checks to be completed by the submitter and reviewers.
Changes in this PR:
Changed way NPPES information was gathered and stored in prod vs dev.

make populatedb_prod: Prod now combines gathering the NPPES information, populating the database with the NPPES info and endpoint resource list info, and then deletes the NPPES files using the make populatedb_prod command.
make populatedb: Use this command to populate the database with all the endpoint resource information and the stored truncated NPPES files stored in the dev resources folder
make update_source_data_prod: Only updates the endpoint resources (not NPPES information) stored in the prod resources directory
make update_source_data: Updates the endpoint resources stored in the prod resources directory and gets NPPES information and creates smaller versions of the files to store in the dev resources folder

Submitter:

[x] Administrative tasks are complete.

This pull request describes why these changes were made.
The JIRA ticket links to this PR.
The JIRA ticket for this PR is: Lantern 437 JIRA Ticket

[x] Tests are complete.

Tests are included and test edge cases.
Tests have been run locally and pass.

[x] Code review has been performed.

Code diff has been done and checked to ensure only expected code is being committed.
A linter for the language has been run.

Primary Reviewer:

[ ] Code works.

Code has been run locally and the basic functionality affected by the PR has been checked.
Edge cases have been checked to ensure behavior is as expected.

[ ] Code review has been performed.

Code is maintainable, reusable, efficient, and correct.
Code accomplishes the tasks purpose.
Code follows style guidance appropriate for the language, including passing linter checks.
Code is well commented (which does not mean verbosely commented).

[ ] Tests are complete.

Tests are included and test edge cases.
Tests have been run locally and pass.

Merger:
Prior to merging, ensure that all checks have been completed. Delete the branch after the merge
is complete.

I got this message a number of times last night, though it was multiple hours after I had run make populatedb_prod and it didn't seem like it broke anything? I feel like you had mentioned it previously that you had seen this so just wanted to double check!
...
lantern-mq_1           | 2022-02-23 18:04:55.075 [warning] <0.2135.0> closing AMQP connection <0.2135.0> (<IP_ADDRESS>:41636 -> <IP_ADDRESS>:5672, vhost: '/', user: 'capabilityquerier'):
lantern-mq_1           | client unexpectedly closed TCP connection
lantern-mq_1           | 2022-02-23 18:04:55.076 [info] <0.2147.0> Closing all channels from connection '<IP_ADDRESS>:41636 -> <IP_ADDRESS>:5672' because it has been closed
lantern-mq_1           | 2022-02-23 18:04:55.700 [info] <0.2152.0> accepting AMQP connection <0.2152.0> (<IP_ADDRESS>:41640 -> <IP_ADDRESS>:5672)
lantern-mq_1           | 2022-02-23 18:04:55.703 [info] <0.2152.0> connection <0.2152.0> (<IP_ADDRESS>:41640 -> <IP_ADDRESS>:5672): user 'capabilityquerier' authenticated and granted access to vhost '/'
lantern-mq_1           | 2022-02-23 18:04:56.096 [warning] <0.2152.0> closing AMQP connection <0.2152.0> (<IP_ADDRESS>:41640 -> <IP_ADDRESS>:5672, vhost: '/', user: 'capabilityquerier'):
lantern-mq_1           | client unexpectedly closed TCP connection
...

Can you switch this over to merging in to main? it will be helpful to have this once we update production!


⚠ ETF has degraded performance

In 62c4a3b, ETF (https://markets.hankyung.com/equity-product/etf) experienced degraded performance:

HTTP code: 200
Response time: 6436 ms

Resolved: 신규상장 performance has improved in 0aee722.


embassy-stm32: add rs485 driver enable to uart

Might want to be able to set the driver enable timings using DEAT and DEDT at some point, but this is good enough for now for us.

Thanks!
bors r+

bors r+


Refactor print_function to use a new function called dump_function

On the Rust side, I would like to have access to the functions printed by print_function. @oflatt suggested a simple refactor, adding a dump_function function which dumps the Term objects, and then refactoring print_function to use dump_function. Then I can use dump_function to achieve my own goal.
Feel free to assign to me.

Turns out this is actually done! EGraph::function_to_dag.
Opened an issue to document the function: #367

Oh cool! There is an open issue in the Python bindings to expose print function, but I wasn't sure if I could get at the data. Nice to know that it's possible https://github.com/egraphs-good/egglog-python/issues/124


[CP] [dart2wasm] Make dart compile wasm accept --enable-experiment flags and pass those to compiler

Commit(s) to merge
3b02e41af1e9f5c60c7526cc87d47ae80a14c6c3
Target
stable
Prepared changelist for beta/stable
https://dart-review.googlesource.com/c/sdk/+/369240
Issue Description
We want dart compile wasm to support --enable-experiment so that e.g. the test runner can use it (https://github.com/dart-lang/test/pull/2233)
What is the fix
Add dart compile wasm support for --enable-experiment.
Why cherry-pick
So that e.g. the test runner can use it (https://github.com/dart-lang/test/pull/2233)
Risk
Low
Issue link(s)

Extra Info
No response

/cc @kevmoo

LGTM!

SGTM

The CP was merged.


How to config TensorRT network in order to quantize convolution layer weights in a per-tensor mode?

TensorRT supports two ways to build a quantization engine:

PTQ with calibration or dynamic range API defined by the user manually
Explicit quantization with Q/DQ ONNX model

The NNI speedup quantized model by TensorRT PTQ dynamic range API. But it seems that TensorRT PTQ dynamic range API will quantize activation in a per-tensor way while quantizing convolution weights in a per-channel way by default. The NNI QAT module quantizes both activation and weights in a per-tensor way, which is different from TensorRT PTQ.
Are there any methods to config TensorRT to quantize weights in a per-tensor mode?

It seems that TensorRT hasn't exposed API for setting per-channel or per-tensor mode right now.

It seems that TensorRT hasn't exposed API for setting per-channel or per-tensor mode right now.

yep, tensorrt only supports per-channel weight quantization under PTQ mode.


How to improve nested requires?

We would like to figure out how to improve requiring modules.
e.g. take a look at this - we have to go back in the folder tree to be able to require the logging module.
The same problem exists in our test env, see.
global require function
One option could be to add a global.requireSomething fn, which is able to read modules from a defined root path.
e.g. requireRoot('services') - would require a module from the core/server folder.
e.g. requireLib('errors') - would require a module inside core/server/lib
other options?
Wait that Node supports import and a similar module like ember-resolve. So you can do:
import * from 'ghost/services'

This looks interesting, https://www.npmjs.com/package/app-module-path.
Here is a whole list of ideas.

Furthermore, it would be great to raise an issue to design a solution for our dirty requires.

I could look at this task.
We are a group of 5 students from KTH in Stockholm and we have a task to look at refactoring issues in open source projects.

@davisfreimanis Sure 👍
Just writing down the steps for you how to tackle this task:

come up with an idea

look for references (how do others solve this problem?)
please post your full idea here as comment (+ share an example usage - a branch with a workable usage)

the Ghost team will review and approve or request changes (PR's are not accepted without approval)
after approval, you can finish the refactoring

If you have any questions, ping me in slack.

Hello!
I'm one of the other students from @KTH mentioned by @davisfreimanis above (the others are @dsalathe, @steinnp, and @hannahfloeter). We've looked at the options a bit and think the simplest solution is to use a global function requireRoot as you suggested (also suggested here).
An example usage is here. One thing we aren't sure about is where we could define the global function to have it be visible from tests as well? And do you think this seems like a good solution?

@ernstwi Hey, thanks for coming back. I'll reply tomorrow 👋

Just sharing some options i went through. I'll look into this tomorrow again. If you find anything else, please share. Before we can make a decision we have to get a clear overview of currently available options and upcoming options.

NODE_PATH

very simple, no hack
open discussion for deprecation was closed
documentation does not recommend using it
might has downsides with IDE completion

babel import root

requires Ghost to compile the source code
no-go option
https://github.com/entwicklerstube/babel-plugin-root-import

yarn workspaces

nice idea, but won't work with public npm repos
https://yarnpkg.com/blog/2017/08/02/introducing-workspaces/

npm local dependencies

huge disadvantage when editing local dependencies (you have to re-sync the modules as far as i understand)
https://medium.com/@arnaudrinquin/build-modular-application-with-npm-local-modules-dfc5ff047bcc

npm modules like https://www.npmjs.com/package/kraeve

they monkey patch the require module
Ghost supports all LTS node versions, i fear that this can trouble in the future e.g. if the require API changes in a node version
can also trouble with IDE completion

Thank you. I don't think I have enough node experience to offer a good opinion on which of these solutions is the best, but we did try the NODE_PATH approach with success on this branch.
We replaced all the relative paths in core/server with absolute paths (with core/server as root) and set the NODE_PATH environment variable manually, then tested with grunt test-all. So what remains to do if this is the option we go with is to set NODE_PATH programatically.

@ernstwi Thanks for coming back :)
Could you pls swing by our slack channel and ping me in the help channel. Thanks! 👋

In case it could be useful in future, here's a script to rewrite the require paths using the current directory as root.

What do you think about patching global.require? I'm thinking we could have some kind of registerRequirePrefix function that will allow you to set a prefix for requiring modules. The prefix would be linked to a directory and all requires containing the prefix would be resolved from the directory linked to the prefix. We could ensure than prefixes would have to be invalid packages names, so we can ensue there won't be conflict with installed packages. Below i've used : in the prefix name which isn't allowed in npm package names.
example usage
// index.js (entrypoint)
const registerRequirePrefix = require('register-require-prefix')
registerRequirePrefix('models:', __dirname + '/models');
registerRequirePrefix('ghost:', __dirname);

// some other file
const SomeModel = require('models:thing'); // equivalent of requiring __dirname/models/thing
// OR
const SomeModel = require('ghost:models/thing'); // same as above

@allouis Thanks for getting involved. It's a nice idea, but it also forces us to override the require module.


fix #427

What kind of change does this PR introduce? (check at least one)

[x] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:

[ ] It's submitted to the dev branch for v2.x (or to a previous version branch), not the master branch
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[ ] All tests are passing
[x] New/updated tests are included

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

目标分支改成 develop，原分支建议也以 develop 为基础

#459  改成develop分支了 @F-loat

嗯，可以直接改的其实


Bump JSON5 to 2.2.3

Fixes Prototype Pollution in JSON5 via Parse Method - https://github.com/advisories/GHSA-9c47-m6qq-7p4h

Oh, didn't know that was already done in https://github.com/Mogztter/asciidoctor-kroki/pull/394
Feel free to close this PR if you like


[pigeon] encode method not correctly handling nested objects

Is there an existing issue for this?

[X] I have searched the existing package issues
[X] I have read the guide to filing a bug

What package does this bug report belong to?
pigeon
What target platforms are you seeing this bug on?

Yes

Dependency versions
// Generated by pub
// See https://dart.dev/tools/pub/glossary#lockfile
packages:
async:
dependency: transitive
description:
name: async
sha256: "947bfcf187f74dbc5e146c9eb9c0f10c9f8b30743e341481c1e2ed3ecc18c20c"
url: "https://pub.dev"
source: hosted
version: "2.11.0"
boolean_selector:
dependency: transitive
description:
name: boolean_selector
sha256: "6cfb5af12253eaf2b368f07bacc5a80d1301a071c73360d746b7f2e32d762c66"
url: "https://pub.dev"
source: hosted
version: "2.1.1"
characters:
dependency: transitive
description:
name: characters
sha256: "04a925763edad70e8443c99234dc3328f442e811f1d8fd1a72f1c8ad0f69a605"
url: "https://pub.dev"
source: hosted
version: "1.3.0"
clock:
dependency: transitive
description:
name: clock
sha256: cb6d7f03e1de671e34607e909a7213e31d7752be4fb66a86d29fe1eb14bfb5cf
url: "https://pub.dev"
source: hosted
version: "1.1.1"
collection:
dependency: transitive
description:
name: collection
sha256: f092b211a4319e98e5ff58223576de6c2803db36221657b46c82574721240687
url: "https://pub.dev"
source: hosted
version: "1.17.2"
cupertino_icons:
dependency: "direct main"
description:
name: cupertino_icons
sha256: e35129dc44c9118cee2a5603506d823bab99c68393879edb440e0090d07586be
url: "https://pub.dev"
source: hosted
version: "1.0.5"
fake_async:
dependency: transitive
description:
name: fake_async
sha256: "511392330127add0b769b75a987850d136345d9227c6b94c96a04cf4a391bf78"
url: "https://pub.dev"
source: hosted
version: "1.3.1"
flutter:
dependency: "direct main"
description: flutter
source: sdk
version: "0.0.0"
flutter_lints:
dependency: "direct dev"
description:
name: flutter_lints
sha256: aeb0b80a8b3709709c9cc496cdc027c5b3216796bc0af0ce1007eaf24464fd4c
url: "https://pub.dev"
source: hosted
version: "2.0.1"
flutter_test:
dependency: "direct dev"
description: flutter
source: sdk
version: "0.0.0"
js:
dependency: transitive
description:
name: js
sha256: f2c445dce49627136094980615a031419f7f3eb393237e4ecd97ac15dea343f3
url: "https://pub.dev"
source: hosted
version: "0.6.7"
lints:
dependency: transitive
description:
name: lints
sha256: "6b0206b0bf4f04961fc5438198ccb3a885685cd67d4d4a32cc20ad7f8adbe015"
url: "https://pub.dev"
source: hosted
version: "2.1.0"
matcher:
dependency: transitive
description:
name: matcher
sha256: "6501fbd55da300384b768785b83e5ce66991266cec21af89ab9ae7f5ce1c4cbb"
url: "https://pub.dev"
source: hosted
version: "0.12.15"
material_color_utilities:
dependency: transitive
description:
name: material_color_utilities
sha256: "9528f2f296073ff54cb9fee677df673ace1218163c3bc7628093e7eed5203d41"
url: "https://pub.dev"
source: hosted
version: "0.5.0"
mediapipe_task_text:
dependency: "direct main"
description:
path: "../../mediapipe_task_text"
relative: true
source: path
version: "0.0.1"
mediapipe_task_text_android:
dependency: transitive
description:
path: ".."
relative: true
source: path
version: "0.0.1"
mediapipe_task_text_platform_interface:
dependency: transitive
description:
path: "../../mediapipe_task_text_platform_interface"
relative: true
source: path
version: "0.0.1"
meta:
dependency: transitive
description:
name: meta
sha256: "3c74dbf8763d36539f114c799d8a2d87343b5067e9d796ca22b5eb8437090ee3"
url: "https://pub.dev"
source: hosted
version: "1.9.1"
path:
dependency: transitive
description:
name: path
sha256: "8829d8a55c13fc0e37127c29fedf290c102f4e40ae94ada574091fe0ff96c917"
url: "https://pub.dev"
source: hosted
version: "1.8.3"
plugin_platform_interface:
dependency: transitive
description:
name: plugin_platform_interface
sha256: "6a2128648c854906c53fa8e33986fc0247a1116122f9534dd20e3ab9e16a32bc"
url: "https://pub.dev"
source: hosted
version: "2.1.4"
sky_engine:
dependency: transitive
description: flutter
source: sdk
version: "0.0.99"
source_span:
dependency: transitive
description:
name: source_span
sha256: "53e943d4206a5e30df338fd4c6e7a077e02254531b138a15aec3bd143c1a8b3c"
url: "https://pub.dev"
source: hosted
version: "1.10.0"
stack_trace:
dependency: transitive
description:
name: stack_trace
sha256: c3c7d8edb15bee7f0f74debd4b9c5f3c2ea86766fe4178eb2a18eb30a0bdaed5
url: "https://pub.dev"
source: hosted
version: "1.11.0"
stream_channel:
dependency: transitive
description:
name: stream_channel
sha256: "83615bee9045c1d322bbbd1ba209b7a749c2cbcdcb3fdd1df8eb488b3279c1c8"
url: "https://pub.dev"
source: hosted
version: "2.1.1"
string_scanner:
dependency: transitive
description:
name: string_scanner
sha256: "556692adab6cfa87322a115640c11f13cb77b3f076ddcc5d6ae3c20242bedcde"
url: "https://pub.dev"
source: hosted
version: "1.2.0"
term_glyph:
dependency: transitive
description:
name: term_glyph
sha256: a29248a84fbb7c79282b40b8c72a1209db169a2e0542bce341da992fe1bc7e84
url: "https://pub.dev"
source: hosted
version: "1.2.1"
test_api:
dependency: transitive
description:
name: test_api
sha256: daadc9baabec998b062c9091525aa95786508b1c48e9c30f1f891b8bf6ff2e64
url: "https://pub.dev"
source: hosted
version: "0.5.2"
vector_math:
dependency: transitive
description:
name: vector_math
sha256: "80b3257d1492ce4d091729e3a67a60407d227c27241d6927be0130c98e741803"
url: "https://pub.dev"
source: hosted
version: "2.1.4"
sdks:
dart: ">=3.0.0 <4.0.0"
flutter: ">=3.10.0"

Steps to reproduce

Declare a class that contains a list of another class Pigeon should serialize, ala this:

class ResultList {
  final List<Result> results;
}

class Result {
  // fields
}

Run Pigeon to generate bindings.
Run resultsList.encode()
Try to jsonEncode() the result.

NOTE: This issue is essentially the opposite of #119351, so it's possible I'm thinking about this wrong. Also, as far as I can tell, the desired functionality spelled out in #119351 is what Pigeon now does - so that issue should maybe be closed.
Expected results
The encoded values should be completely wire-compatible (aka - a list of strings).
Actual results
The actual results are a list of still-hydrated Result objects, which cannot be fully serialized.
Code sample
The generated code looks like this:
Object encode() {
  return <Object?>[
    results
  ];
}

But should look something like this:
Object encode() {
  return results.map<List<String>>((result) => result.encode()).toList();
}

It's also possible the type on map should be List<Any>, since it may actually contain yet more lists (of lists, of lists, etc).
Screenshots or Videos
No response
Logs
No response
Flutter Doctor output
flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, 3.13.0-7.0.pre.62, on macOS 13.4.1 22F770820d darwin-arm64, locale en)
[!] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
✗ cmdline-tools component is missing
Run path/to/sdkmanager --install "cmdline-tools;latest"
See https://developer.android.com/studio/command-line for more details.
✗ Android license status unknown.
Run flutter doctor --android-licenses to accept the SDK licenses.
See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.
[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.3)
[✓] IntelliJ IDEA Community Edition (version 2023.1.4)
[✓] VS Code (version 1.80.1)
[✓] Network resources
! Doctor found issues in 1 category.

4. Try to jsonEncode() the result.

What's the use case here? (And more generally, why do you expect that this would work?)

The actual results are a list of still-hydrated Result objects, which cannot be fully serialized.

When you say "fully serialized" are you talking about your attempt above to treat it as JSON, or about Pigeon encoding itself? If the latter, what actual errors are you seeing?


add method comments

add  method comments

this has some 10K commits & no jira created, no idea what is the intent please read the contribution guide, and raise a proper PR:
https://cwiki.apache.org/confluence/display/hadoop/how+to+contribute


Find fix for zlib install.

Solutions for this would be,
use https://github.com/nodeca/pako
or make our own

Depends - How hard could it be?

Depends - How hard could it be?

haven't looked into it too much but from looking at eris and djs, neither of them use zlib

Depends - How hard could it be?

haven't looked into it too much but from looking at eris and d.js, neither of them use zlib

Actually - d.js can use zlib (@discordjs/zlib) but that's just to speed things up.

Depends - How hard could it be?

haven't looked into it too much but from looking at eris and d.js, neither of them use zlib

Actually - d.js can use zlib (@discordjs/zlib) but that's just to speed things up. I would like to ship our own one with the module tho just to make it less of a pain in the arse to install.

yep, currently the only way to install it without some bs compiler is to use yarn


Follow googlecartographer/cartographer#859

@ojura no problem :)

@wally-the-cartographer merge

Merge requested by authorized user cschuet. Merge queue now has a length of 1.


Report: Use bootstrap dashboard example

Use bootstrap dashboard example, so user dont need to use other css links

Commit: https://github.com/adiralashiva8/robotframework-metrics/commit/ab940c3ba044a001768e950d1e51620f0bb825f6


Add assertion in ClearCommand

Codecov Report

Merging #108 (9808058) into master (dacd01f) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #108      +/-   ##
============================================
- Coverage     71.52%   71.42%   -0.10%
  Complexity      543      543
============================================
  Files            86       86
  Lines          1749     1750       +1
  Branches        197      198       +1
============================================
- Hits           1251     1250       -1
  Misses          429      429
- Partials         69       71       +2

Impacted Files
Coverage Δ

...ava/seedu/address/logic/commands/ClearCommand.java
60.00% <0.00%> (-40.00%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dacd01f...9808058. Read the comment docs.


Extensively refactor validation, to be more explicit and discoverable

Next step toward stdout output. Let me know if it conflicts with any work on splitting into modules - happy to solve any corresponding merge issues.
Changes:

Introduce some classes (Validator, ValidationRuleFactory) to provide a new, succinct way of running validation rules in the exact place where they're needed. Previously, validation was divorced from the operations that needed it (e.g. the code that checked whether a file existed was completely separate from the code that wanted to read from it).
Tweak the IoC responsibilities a bit, to reduce the number of "smart" providers we have (e.g. move OutputFormatProvider's responsibilities to an OutputFormatLookup class).
Extract a FileUtils interface, as a first step toward converting it into a FileSystem abstraction to let us create Cucumber tests that set up specific filesystem states (useful for testing things like validation and error handling).

Some parts have been merged into master. some parts superceded by parallel changes


Client model does not exist in the project

class BaseSetup(TenantTestCase):
def setup_tenant(self, tenant):
    """
    Add any additional setting to the tenant before it get saved. This is required if you have
    required fields.
    """
    # deleting the best power of life that you would
    tenant.company_name = "Test Company"

def setup_domain(self, tenant):
    """
    Add any additional setting to the domain before it get saved. This is required if you have
    required fields.
    """
    domain.ssl = True

def setUp(self):
    super(BaseSetup, self).setUp()
    self.c = TenantClient(self.tenant)

def test_user_profile_view(self):
    response = self.c.get(reverse('userprofile'))
    self.assertEqual(response.status_code, 200)

@staticmethod
def get_test_tenant_domain():
    return 'a.test.com'

@staticmethod
def get_test_schema_name():
    return 'a'`

`
I have written above code for test case for testing the user profile, but i get the following error even though I have client model class into the core application,
"App '%s' doesn't have a '%s' model." % (self.label, model_name))
LookupError: App 'core' doesn't have a 'client' model.
Please let me know answer of above question.
Thank you in advance ! :)

Are you using the latest from GIT or pypi?

I am using pypi.

Try using the latest in git


show more readable content in the generated search space file

In v0.1 and v0.2, if users use nni annotation in their trial code and use for example @nni.function_choice in their code, nni will use different numbers to designate different candidate functions from @nni.function_choice in the generated search space file. Thus, in webui, users only get the numbers instead of the real function names, which is very unfriendly. It would be great to use function names in the generated search space file.

Already fixed. Close it.


[BUG] unable to compile TS code when using snowpack as middleware

Bug Report Quick Checklist

[x] I am on the latest version of Snowpack & all plugins.
[x] I use package manager yarn (Fill in: npm, yarn, pnpm, etc).
[x] I run Snowpack on OS MacOS (Fill in: Windows, Mac, Linux, etc).
[x] I run Snowpack on Node.js v12+

Describe the bug
When running tsc in a project that imports snowpack, the following errors are produced:
node_modules/snowpack/lib/hmr-server-engine.d.ts:2:23 - error TS2307: Cannot find module 'ws' or its corresponding type declarations.

2 import WebSocket from 'ws';
                        ~~~~

node_modules/snowpack/lib/util.d.ts:19:21 - error TS2456: Type alias 'Awaited' circularly references itself.

19 export declare type Awaited<T> = T extends PromiseLike<infer U> ? Awaited<U> : T;
                       ~~~~~~~

node_modules/snowpack/lib/util.d.ts:19:67 - error TS2315: Type 'Awaited' is not generic.

19 export declare type Awaited<T> = T extends PromiseLike<infer U> ? Awaited<U> : T;
                                                                     ~~~~~~~~~~

Found 3 errors.

To Reproduce
We can't fix bugs that we can't see for ourselves. Issues often need to be closed if this section is skipped.

yarn init -y
yarn add typescript @types/node snowpack
tsconfig.json

{
    "compilerOptions": {
      "module": "esnext",
      "moduleResolution": "node",
      "esModuleInterop":true,
      "noImplicitAny": true,
      "preserveConstEnums": true,
      "removeComments": true,
      "sourceMap": true,
      "target": "ES2019",
      "allowJs": true,
      "outDir": "dist",
    },
    "include": ["src/**/*"],
    "exclude": ["node_modules", "**/*.spec.ts", "public"]
}

src/index.ts

import Snowpack from 'snowpack';

See error!

Expected behavior
The project should compile without any errors

It’s hard to tell without looking at your project, but I believe you may need to add compilerOptions.skipLibCheck: true to your TS config.
I don’t believe this is a known error with any types that Snowpack ships, as the errors pointed out don’t have anything to do with Snowpack.


Cargo install fails: no method named progress_chars found for enum Result in the current scope

Trying to install it with cargo install xwin on a machine running Arch Linux (up to date) and latest stable Rust (1.58.1 at this time) produces this error:

You need to use the --locked flag as in cargo install --locked xwin, cargo has a longstanding bug where the lockfile is completely ignored without that flag. I've updated the README because I always forget about this until someone files a bug. Sorry for the inconvenience.


Client Allocation Request for: 119REO

Client Allocation Questions
Core Information

Name: 119REO
Website / Social Media:  https://www.119reo.com/
Region: Asia (excl. Greater China)
DataCap Requested: 10TiB
Addresses to be Notarized: f1v6cvujoi6i7ooxgjzo5qbzj6sk2bfqihwadt7yq
Notary Requested: IreneYoung

@faopngineg Please subscribe to notifications for this Issue to be aware of updates. Notaries may request additional information on the Issue.

Hi @faopngineg  - Thanks for your application. Please answer the following questions to let us know about you, your company, and further information about the DataCap allocation.
Basic Info
What's your name and your position in your company?
Please introduce yourself and your team briefly. How many team members do you have in your R&D or core team? Could you provide several Github accounts or email addresses of them?
For your organization, Please describe its business, its history since inception, registration country, scale, employee counts, operation regions, named executive officers, relevant projects, industry reputation, etc.
Please show us some of your web pages, Github, social media accounts such as Twitter, Facebook, Naver blog, WeChat official account, etc. Please include as many relevant details to provide contextual information (with external links) to show your Web3 reputation or external reputation.
Please provide your company's business registration license. If you have any presentation documents about your business, please provide them to us. And also could send me via email for privacy concerns. My contact<EMAIL_ADDRESS>How long have the team core members been engaged in development?
What types of data do you plan to store with the DataCap and how many do you need? Could you please send us some of your sample data?
Regarding the data you intend to store, What’s the original source of those data, and do you have any proof of the ownership or authorization?
Where is your data stored now? Whether the data is stored on a server or a cloud service provider?
Track Record
Has your organization obtained DataCap before? if so, please answer the following sub-questions.
1.1 Please share all the links and recordings of your applications before.
1.2 How about your DataCap usage? Is there any remaining? Is there any information on the deals you've done and the miners you've allocated your DataCap to?
1.3 What was your allocation strategy plan then and how did you execute it?
Are there any disputes open against you from your previous DataCap allocations? If any, please describe any of your honors or disputes in the field of Filecoin.
Allocation Plan
Please describe your plan to use the DataCap as detailed as possible, including use case, amount, timespan, geography, storage providers, partners, etc.
How many regions do you plan to store the data in?
How many storage providers you intend to make dealing with?
Do you plan to record your allocation decisions and execution details in public? And how to realize it?
Do you agree to use the DataCap to only store data that abide by local regulations and is in compliance with the recipient miner’s terms of service?
We may further ask some questions and then give an accurate score to the application. Thank you for your cooperation!


Polymomial equation

Add the possibility to solve polynomial equation using QUBO

Migrated the code to a new repo : https://github.com/QuantumApplicationLab/qubops


Unify how missing field entries are handle in knn formats

It is possible to inappropriately use the knn formats and attempt to merge segments with mismatched field names.
None of the formats actually check for null, they just all assume that the field entry exists.
I opted to throw an IllegalArgumentException here to keep with the current behavior, but prevent an unexpected NPE.
Additionally, this unifies the scalar quantized formats, these checked for null values and returned null. But we should behave uniformly across all formats.
closes: https://github.com/apache/lucene/issues/13626

It is possible to inappropriately use the knn formats and attempt to merge segments with mismatched field names.

I don't understand this - what's inappropriate about it? I guess we have something like segment 1 has field A and segment 2 has field B. Shouldn't the merged segment have both fields?

@msokolov maybe?
Looking at the code, this has never worked this way. Field entry existence was just assumed to be handled by the perfield codec.
I tried digging into the other formats that have an "per field" version (e.g. docValues,) and when I tested, they also threw a NPE in a scenario like this.
So, I opted to keep what seems like the status quo.
But, I am happy to change it if I am wrong about intended behavior.

Separately, it looks like we call the KnnVectorsReader with the merged field info, which is not legal, we should call it with the field info of the segment.

Apologies, I was wrong here: KnnVectorsReader takes a String (rather than a FieldInfo) so it's not subject to this problem.

Unless there are rejections, I am going to move forward with merging this. Throwing an IAE seems way better than throwing an NPE.
If we want to change this behavior to be more lenient, that is fine, but I would rather fix this first and then we can figure out what the improved behavior should be.

Fine with me, I will work on fixing the merging logic then unless you plan on working on it.

Ah dang, yeah, I completely spaced on that since this PR is so old. I will do that right now & we can do that in this PR.

OK, I pushed up a fix for @msokolov's suggestion and your reminder @jpountz . I added a protection around our access to the KnnVectorReaders during merge. Additionally, I kept my new test, but these protections keep it from throwing (previously it did). This way we unify our access logic on missing (e.g. throw), and protect during merge by not attempting to access vector values that aren't there for a given field.

@benwtrent should we do the same check for PerFieldKnnVectorsFormat.FieldsReader? If the target reader is null, throw an IAE and ensure that we do not return null.

@bugmakerrrrrr I don't want to make that change as the PerFieldDocValuesFormat & PerFieldPostingsFormat field readers will return null if the field is missing. I want to at least try to unify the PerFieldKnnVectorsFormat with those
However, we are fairly inconsistent all over the place here. For example, in our Postings formats, we will check for null and return null, but for doc value formats, those look like they will throw NPEs.
Doc value exmaple:
  @Override
  public NumericDocValues getNumeric(FieldInfo field) throws IOException {
    NumericEntry entry = numerics.get(field.number);
    return getNumeric(entry);
  }

Postings:
  @Override
  public Terms terms(String field) throws IOException {
    assert field != null;
    FieldInfo fieldInfo = fieldInfos.fieldInfo(field);
    return fieldInfo == null ? null : fieldMap.get(fieldInfo.number);
  }


[WIP] Provide profile exporter tool

Please answer these questions before submitting pull request

Why submit this pull request?

[ ] Bug fix

[x] New feature provided

[ ] Improve performance

Related issues
#4104

New feature or improvement

Provide the profiled segment exporter tool. Using the command line to export trace and snapshot data.

Codecov Report

Merging #4416 into master will decrease coverage by 0.3%.
The diff coverage is 61.11%.

@@            Coverage Diff             @@
##           master    #4416      +/-   ##
==========================================
- Coverage   25.23%   24.93%   -0.31%
==========================================
  Files        1223     1223
  Lines       28271    28273       +2
  Branches     3891     3889       -2
==========================================
- Hits         7135     7049      -86
- Misses      20485    20575      +90
+ Partials      651      649       -2

Impacted Files
Coverage Δ

...oap/server/core/query/ProfileTaskQueryService.java
0% <0%> (ø)
:arrow_up:

...re/register/service/EndpointInventoryRegister.java
0% <0%> (ø)
:arrow_up:

...r/parser/standardization/ReferenceIdExchanger.java
0% <0%> (ø)
:arrow_up:

...lking/oap/query/graphql/resolver/ProfileQuery.java
0% <0%> (ø)
:arrow_up:

...p/server/core/profile/analyze/ProfileAnalyzer.java
68.51% <78.57%> (+2.56%)
:arrow_up:

.../apm/agent/core/remote/StandardChannelBuilder.java
0% <0%> (-100%)
:arrow_down:

.../skywalking/apm/agent/core/remote/GRPCChannel.java
0% <0%> (-81.25%)
:arrow_down:

...alking/apm/agent/core/remote/AgentIDDecorator.java
0% <0%> (-66.67%)
:arrow_down:

...lking/apm/agent/core/remote/TLSChannelBuilder.java
0% <0%> (-44.45%)
:arrow_down:

...king/apm/agent/core/remote/GRPCChannelManager.java
37.17% <0%> (-32.06%)
:arrow_down:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4660678...3ebdc4b. Read the comment docs.

I'm Still waiting for the documentation, which helps to review and gives the context to those who haven't talked to the author out of GitHub

I'm Still waiting for the documentation, which helps to review and gives the context to those who haven't talked to the author out of GitHub

Sure, I will write the document today.

I am not sure how many tool we are going to provide, but basically, it will be more than one.

@wu-sheng @kezhenxu94 The document has added. Please take a look. The code structure and e2e test I will keep to fix.


[RESOLVED] Interface eth0(): High error rate (>2 for 5m)

Problem started at 15:51:29 on 2023.05.10
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Operational data: errors in: 3, errors out: 0
Original problem ID: 20503
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23483&eventid=20503

Problem has been resolved in 24m 0s at 16:15:29 on 2023.05.10
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Original problem ID: 20503


WIP: Add authentication-reader role on KAS bootstrap

What this PR does / why we need it:
Ensures that the authentication reader role is created on KAS bootstrap instead of waiting for the HCCO to reconcile it. Should help to avoid pod restarts in e2e.
Checklist

[] Subject and description added to both, commit and PR.

/rest-required

/retest-required

/close


Custom Filler Alphabet/Characters

Allow specifying a custom alphabet or set of characters for filling empty puzzle spaces.

Closed with #71


Echonet

Does echonet package removed from pip ?

I am currently experiencing the same issue here.
I can't find the package.

Has there been a fix for this issue? @alexgcsa @Alicoo1907

@adikrishnanucd Unfortunately, same "ERROR: No matching distribution found for echonet" . I wonder if the owners removed the package?

@Alicoo1907 and @alexgcsa Thank you both very much for the clarification. I figured out that I needed to install the repository with pip. The problem has been resolved for me.
Just to clarify, to get rid of this issue:

Navigate to the cloned repository (i.e. dynamic/ folder)
Run pip install .
The echonet package should be installed and you can very by checking your installed Python packages with pip list or pip show echonet.

Thank you very much.

Oh, I just tried to install echonet with pip. I must have read or misunderstood. I'm closing the issue. Thanks both @alexgcsa @adikrishnanucd


Code duplication between codeworld.js and blockworld.js

These should be cleaned up to share the same common code when possible, rather than maintaining two copies.

I know about this, I was feeling guilty when doing this.
The common elements should be generalized and moved to a separate file.
A related problem is that the UI differs for FunBlocks and small differences creep into annoying places.

It's fine to start out with a copy.  I just wanted to get the bug tracking in place for cleaning it up.


fix syntax for test/README.md

fix syntax format error for test/README.md
Signed-off-by: DeShuai Ma<EMAIL_ADDRESS>

LGTM let's just wait for travis and merge /cc @mrunalp

@mdshuai Thanks for the change and it LGTM, but you need to sign your commit.

@TomSweeneyRedHat done

Your commit isn't signed yet and there's no need to run all the tests for this change :)

should ready now. thanks

Thank you @mdshuai!


Equip - build new servers in production

User Story
User Story
As an application support team, I need to ensure that the application is supportable and kept up to date.
ROC - the 3rd party supporting the application - need to upgrade both the application and the windows servers.
Unfortunately ROC does not have terraform skills, so we will need to do this work for them.
We have built the development servers and ROC has confirmed they are working as expected
This ticket is to build the servers in production - there will be a later ticket to help them migrate.
ROC can confirm server spec
Value / Purpose
This is to ensure that the application is supportable
Useful Contacts
<EMAIL_ADDRESS><EMAIL_ADDRESS>Additional Information
No response
Proposal / Unknowns
No response
Definition of Done

[ ] Documentation has been written / updated
[ ]  Liaise with ROC to confirm sizings
[ ] Servers built
[ ] Another team member has reviewed
[ ] Tests are green

New servers deployed

Contacted user and he is happy with the new prod servers


Fixes #4. Fixed all warnings in latest Xcode (7.0.1) related to all our targets. Excluding warnings generated from external Pod frameworks

@mkistler Feel free to review changes and ensure the warnings are gone for you. Tell me if you are concerned about the Pod warnings as well.

This is in relation to Issue #4

+1 Looks good and tests are passing (except iOS 9.1, which was failing before).


feat: renames app

What
Renames app 🔧

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add doc about manual_trigger option for testing farm

cc @lbarcziova

Hi, thanks for the contribtion!
As described in https://github.com/packit/packit-service/issues/1806#issuecomment-1569516694, there is still an issue regarding the dependant jobs, so I would wait with the documentation until this works for every use case.

thanks! This should now work in general (also for builds and propose-downstream), so it should be mentioned in the general docs as well. If you do not have time to do that, I can cover that part :)

Do you mean here https://github.com/packit/packit.dev/blob/main/content/docs/Configuration/examples.md ?


Allowed to specify cellModel and point neuron params in netParams.cellParams (not only in netParams.popParams)

Thanks for this @salvadord. Initial tests indicate it breaks the NP->NML export, but I do prefer the simpler format. Investigating further...


Displayed vs value delimiter

Is your feature request related to a problem? Please describe.
Currently, the delimiter option is used for both, displaying and setting the value.
Describe the solution you'd like
Having a separate delimiter option for the delimiter used for displaying the date range.
Describe alternatives you've considered
Using a handler for setting the value, with a different delimiter.
Additional context
https://github.com/wakirin/Litepicker/issues/94
@wakirin: This is really an issue because the user sees a delimiter (like ,) that is needed internally as field value.
This is very related to the date format itself: The user should see a different date format than the actual value of the input field.

Add onSelect event.
Add `
Set the desired format as you need in the hidden field in onSelect event.

Add onSelect event.
Add `
Set the desired format as you need in the hidden field in onSelect event.

Bonjour,
I guess @wakirin answer should resolve my problem but I'm not sure how to manage it in my code.
I got a simple form in which I want user to get the date in french format but I need to set the value in american format for my database.
The fields:
										<input id="day_from_picker_indisp" class="form-control required" name="day_from_indisp" data-prop="day_from_indisp" type="text" placeholder="Sélectionner une plage*" required  readonly="readonly"  /> 										<input id="day_to_picker_indisp" class="form-control required" type="text" name="day_to_indisp" data-prop="day_to_indisp" required readonly="readonly"  />
The Litepicker script:
		var dt = new Date(); 			 dt.setDate(dt.getDate()-1); 			new Litepicker({ 				element: document.getElementById('day_from_picker_indisp'), 				elementEnd: document.getElementById('day_to_picker_indisp'), 				singleMode: false, 				lang:'fr-FR', 				format:'DD MMM YY', 				resetButton: true, 				allowRepick: true, 				minDate: dt, 				tooltipText: { 					one: 'jour', 					other: 'jours' 				}, 				tooltipNumber: (totalDays) => { 					return totalDays - 1; 				} 			})
Now I can easily add hidden input fields to my form, but how can I populate them with the yyyy-mm-dd format?
Thank you for your help and the great plugin!


SPI chip select and device tree overlays

Hi,
I applied a device tree overlay on the RPI4, in order to customize the SPI chip select lines.
dtoverlay=spi0-2cs,cs0_pin=04,cs1_pin=27
However, pigpio doesn't respect this change.  It continues to use the default SPI chip select lines.  I believe this is because the chip select pins are hardcoded in pigpio.c.
Do you have ideas on how this could be fixed?  Could pigpio (somehow) query the system to determine which chip select lines have been configured for the main/aux SPI buses?

pigpio does not use the Linux SPI driver.
pigpio uses its own SPI driver which was written before the Linux SPI driver was available for the Pi.
For your use case I suggest you use the Linux SPI driver.


Problem with presenting new coordinator

Hi to everyone :)
After I updated iPhone to version 13.1.3 the problem with presenting new coordinators occurred. I made the simplest project to test it where I have 2 coordinators (AppCoordinator and MainCoordinator) and 2 screens (Splash screen and Main screen). When Main screen appears it looks like it was presented, not pushed - the white space on the top of the screen is SplashVC from other coordinator and I can swipe the current screen up and down. Here's image bellow

First I have AppCoordinator from where I'm presenting (new) MainCoordinator.
Here's code from my AppCoordinator:

 override func prepareTransition(for route: AppRoute) -> NavigationTransition {
    switch route {
    case .splash:
        let splashVC = SplashVC.instantiateFromNib()
        let viewModel: SplashVM = SplashVM(provider: provider)
        splashVC.bind(to: viewModel)
        viewModel.router = unownedRouter
        return .push(splashVC)
    case .exit:
        let coordinator = MainCoordinator(provider)
        return .present(coordinator)
    }
}

And the code from MainCoordinator:

class MainCoordinator: NavigationCoordinator<MainRoute> {
    init(){
       super.init(initialRoute: .main)
     }

override func prepareTransition(for route: MainRoute) -> NavigationTransition {
    switch route {
     case .main:
        let viewController = MainVC.instantiateFromNib()
        let viewModel: MainVM = MainVM(provider: provider)
        viewController.bind(to: viewModel)
        viewModel.router = unownedRouter
        return .push(viewController)
      }
   }
}

So, the question is if there's any way to avoid present like screens when I want to add new coordinator and how to do that? 😄

Sure, this is due to a change in UIKit in the iOS 13 SDK - The default modalPresentationStyle has been changed from .fullscreen to .automatic leading to this behavior. You can add the line coordinator.rootViewController.modalPresentationStyle = .fullscreen to revert to the old presentation style.


Dev/board

Functionality:
Allows the user logged in to see all his tasks right from the first sprint.
Solution:
Created a task board button and sent the user name and filtered tasks that had the user's name as assignee.
Risk level:

[ ] high
[X] medium
[ ] low

How to test:
ng serve and then click on the Task Board button on the navbar.

It would be better if we have this component as Dashboard, and move current component as board.
Also make this list box a little small.

It would be better if we have this component as Dashboard, and move current component as board.
Also make this list box a little small.


What operations should be wrapped into ReadAction and WriteAction?

There's currently just a single use of com.intellij.openapi.application.WriteAction across all codebase, in com.virtuslab.gitmachete.frontend.actions.toolbar.OpenMacheteFileAction:
    val macheteFile = WriteAction.compute(() -> Try
        .of(() -> GitVfsUtils.getMacheteFile(repo))
        .onFailure(e -> VcsNotifier.getInstance(project).notifyWeakError(/* displayId */ null,
            /* title */ "",
            /* message */ getString("action.GitMachete.OpenMacheteFileAction.notification.title.cannot-open"))))
        .getOrNull();

Let's determine where exactly ReadAction and WriteAction should be used, in particular if the existing invocation is correct.
It might be hard to deduce just from JetBrains docs... probably it might be needed to check the code of intellij-communty/official plugins.
See https://plugins.jetbrains.com/docs/intellij/general-threading-rules.html -> Writing data is only allowed from the UI thread wuuuut 😯 I suppose it refers to PSI/VFS, and not to writing files directly to disk (as we do with .git/machete) 😅 It means that WriteAction.compute is effectively a @UIEffect method in Checker terms, sth to reflect in Checker stubs.
Whatever the conclusions, let's immortalize them via ArchUnit tests or sth wherever applicable.

Load balancing, as @mkondratek is busy with features

Okay @MaciejG604 ... anything left to be done here? 🤔


[Plugin] Dynatrace Plugin

Summary
A plugin that will show information from Dynatrace in the catalog view for a component - such as recent problems, error traces, and synthetics results.
Context
Many organizations use Dynatrace as their observability platform - surfacing some of the information mentioned above would be a helpful feature.
Some requirements for this plugin will include:

an API key for dynatrace (would need to be in the app-config.yaml / the environment)
a dynatrace entity id annotation in the component's catalog-info.yaml, e.g. backstage.io/dynatrace-entity-id

I am interested in working on this item, so I would like to assign myself.

Just an update: I've got a first iteration close to completion. Should be ready to submit a PR soon!


Start pruning removed stats from SwiftypeTimeSeriesCollector

Once a stat was added to hourly or hourlyTimings it was never removed.
Now once a Gauge or Counter does not exist in StatsSummary the stat
is pruned.

Tests pass for me locally. It looks like the CI setup might be broken. It never makes it far enough to actually run the tests:
$ ./sbt ++$TRAVIS_SCALA_VERSION test
downloading sbt-launch.jar
bad sbt-launch.jar.  delete sbt-launch.jar and run ./sbt again.

The command "./sbt ++$TRAVIS_SCALA_VERSION test" exited with 1.

Before we jump into this, have you taken a look at twitter-server + finagle-stats instead?  All new features are targeted for twitter-server and finagle-stats, and we're hoping to deprecate ostrich in the next year or so, so if this is a problem there too, it might make sense to migrate and fix it there instead.
With that said, if you're not interested in switching, still happy to review / merge / support ostrich (at least until we deprecate it officially).

I ran into this issue while using Kestrel (which is already deprecated by Twitter). I've patched this fix in directly to our Kestrel fork. So, getting this into Ostrich is not blocking me. I also don't have the time right now to update Kestrel to use something else.
I'm just pushing this upstream because it looked like Ostrich was still active and I thought it might be useful. It fixes a pretty serious memory leak when the server has a changing set of stats, but I'm not sure how common that case is for most Ostrich users.
I guess it's up to you. I'd still like to merge it because even if Ostrich is deprecated soon someone will still be using it for a while. But if no one needs this fix, or there will never be another release of Ostrich then I don't want to waste your time.

I don't believe TimeSeriesCollector is used much at all here at Twitter due to its footprint. Also as @mosesn points out, we are moving away from Ostrich.
That said, this seems like a useful fix for people and this seems like a reasonable and localized fix. I'll try to get this patch applied.

Awesome. Thanks!

Ok merged this in locally and it should appear on the develop branch this coming Monday. Thanks for the patch.


try_spdm_send_receive_finish does not free session ID on error: session ID leak

Walking through the code for try_spdm_send_receive_key_exchange after allocating a session ID, nearly every error from there on causes the session ID to be freed.  Below is the only case where that does not happen and probably should free the session ID:
    opaque_length = *(uint16_t *)ptr;
    if (opaque_length > SPDM_MAX_OPAQUE_DATA_SIZE) {
        return RETURN_SECURITY_VIOLATION;
    }

And try_spdm_send_receive_finish doesn't bother to free the session ID in any error, which is session ID allocation leak unless the integrator does this for libspdm.  If an error happens here, it seems like most of the recoveries are to either: start KEY_EXCHANGE again, or redo attestation.  Either case would justify freeing the current session ID as cleanup in try_spdm_send_receive_finish, as try_spdm_send_receive_key_exchange would rightfully allocate a new unique session ID without the freeing of the current session ID.
Only a timeout is difficult in regards to FINISH.  In theory, the command could be retried, but if the transcripts mismatch, the responder would just send an ERROR response.  And using a timeout to jump back to KEY_EXCHANGE with the freed session ID would cause a reuse of the ID, but the responder may think the session ID is already in use by the requestor (as the responder may have sent the FINISH_RSP or missed the original FINISH request).

I think there are several issues:

req_key_exchange shall free session_id in SPDM_MAX_OPAQUE_DATA_SIZE errors. (following same error handling pattern)
red_psk_exchange shall include SPDM_MAX_OPAQUE_DATA_SIZE check, free session_id and return error. (following same error handling pattern)
I agree that finish/psk_finish shall cleanup in case of error. (following same error handling pattern)

Here the "same error handling pattern" means 1) free session_id, 2) free dhe_context if key is not established, 3) zero negotiated keys.

I will check it.


Workflow related API fixes

More smoke test fixes:

Missed one occurrence of replacing the deprecated way to check for an active graph for a node.
Making some changes to the workflow library routes. These routes already do not work (https://github.com/RackHD/RackHD/issues/89), but tests have passed with false positives so far because the /workflows/library route gets redirected to the /workflows/<id> route. Previously, this route improperly returned a 200 no matter what.

I think this may be controversial in regards to the /workflows/library/* addition/change, but I'm kind of at a loss for what to do. I don't want to continue with the current broken behavior just to keep incorrect tests passing.
Resolves https://github.com/RackHD/RackHD/issues/89
@RackHD/corecommitters @jlongever @heckj @VulpesArtificem

*** BUILD #459 ***

*** BUILD #461 ***
Test Name: Http.Api.Workflows GET /workflows/:id should return a single persisted graph
Error Details: expected { name: 'foobar' } response body, got { message: 'Object #<Object> has no method \'needOne\'' }
Stack Trace: Error: expected { name: 'foobar' } response body, got { message: 'Object #<Object> has no method \'needOne\'' }
    at error (node_modules/supertest/lib/test.js:235:13)
    at Test.assert (node_modules/supertest/lib/test.js:166:19)
    at assert (node_modules/supertest/lib/test.js:132:12)
    at node_modules/supertest/lib/test.js:129:5
    at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)
    at Test.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)
    at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)
    at _stream_readable.js:920:16

Test Name: Http.Api.Workflows GET /workflows/:id should return a 404 if not found
Error Details: expected 404 "Not Found", got 500 "Internal Server Error" Response body: { message: 'Object #<Object> has no method \'needOne\'' } Error: expected 404 "Not Found", got 500 "Internal Server Error"     at Test.assert (/var/lib/jenkins/jobs/on-http/workspace/build/node_modules/supertest/lib/test.js:205:15)     at assert (/var/lib/jenkins/jobs/on-http/workspace/build/node_modules/supertest/lib/test.js:132:12)     at /var/lib/jenkins/jobs/on-http/workspace/build/node_modules/supertest/lib/test.js:129:5     at Test.Request.callback (/var/lib/jenkins/jobs/on-http/workspace/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)     at Test.<anonymous> (/var/lib/jenkins/jobs/on-http/workspace/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)     at Test.EventEmitter.emit (events.js:95:17)     at IncomingMessage.<anonymous> (/var/lib/jenkins/jobs/on-http/workspace/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)     at IncomingMessage.EventEmitter.emit (events.js:117:20)     at _stream_readable.js:920:16     at process._tickDomainCallback (node.js:459:13)
Stack Trace: Error: expected 404 "Not Found", got 500 "Internal Server Error"
    at Test.assert (node_modules/supertest/lib/test.js:205:15)
    at assert (node_modules/supertest/lib/test.js:132:12)
    at node_modules/supertest/lib/test.js:129:5
    at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)
    at Test.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)
    at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)
    at _stream_readable.js:920:16

Test Name: Http.Api.Workflows GET /workflows/library should retrieve the graph library
Error Details: expected [ { name: 'foobar' } ] response body, got { message: 'Object #<Object> has no method \'needOne\'' }
Stack Trace: Error: expected [ { name: 'foobar' } ] response body, got { message: 'Object #<Object> has no method \'needOne\'' }
    at error (node_modules/supertest/lib/test.js:235:13)
    at Test.assert (node_modules/supertest/lib/test.js:166:19)
    at assert (node_modules/supertest/lib/test.js:132:12)
    at node_modules/supertest/lib/test.js:129:5
    at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)
    at Test.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)
    at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)
    at _stream_readable.js:920:16

*** BUILD #462 ***
Test Name: Http.Api.Workflows GET /workflows/:id should return a single persisted graph
Error Details: expected { name: 'foobar' } response body, got { message: 'Object #<Object> has no method \'needOne\'' }
Stack Trace: Error: expected { name: 'foobar' } response body, got { message: 'Object #<Object> has no method \'needOne\'' }
    at error (node_modules/supertest/lib/test.js:235:13)
    at Test.assert (node_modules/supertest/lib/test.js:166:19)
    at assert (node_modules/supertest/lib/test.js:132:12)
    at node_modules/supertest/lib/test.js:129:5
    at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)
    at Test.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)
    at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)
    at _stream_readable.js:920:16

Test Name: Http.Api.Workflows GET /workflows/:id should return a 404 if not found
Error Details: expected 404 "Not Found", got 500 "Internal Server Error" Response body: { message: 'Object #<Object> has no method \'needOne\'' } Error: expected 404 "Not Found", got 500 "Internal Server Error"     at Test.assert (/var/lib/jenkins/jobs/on-http/workspace/build/node_modules/supertest/lib/test.js:205:15)     at assert (/var/lib/jenkins/jobs/on-http/workspace/build/node_modules/supertest/lib/test.js:132:12)     at /var/lib/jenkins/jobs/on-http/workspace/build/node_modules/supertest/lib/test.js:129:5     at Test.Request.callback (/var/lib/jenkins/jobs/on-http/workspace/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)     at Test.<anonymous> (/var/lib/jenkins/jobs/on-http/workspace/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)     at Test.EventEmitter.emit (events.js:95:17)     at IncomingMessage.<anonymous> (/var/lib/jenkins/jobs/on-http/workspace/build/node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)     at IncomingMessage.EventEmitter.emit (events.js:117:20)     at _stream_readable.js:920:16     at process._tickDomainCallback (node.js:459:13)
Stack Trace: Error: expected 404 "Not Found", got 500 "Internal Server Error"
    at Test.assert (node_modules/supertest/lib/test.js:205:15)
    at assert (node_modules/supertest/lib/test.js:132:12)
    at node_modules/supertest/lib/test.js:129:5
    at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)
    at Test.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)
    at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)
    at _stream_readable.js:920:16

Test Name: Http.Api.Workflows GET /workflows/library should retrieve the graph library
Error Details: expected [ { name: 'foobar' } ] response body, got { message: 'Object #<Object> has no method \'needOne\'' }
Stack Trace: Error: expected [ { name: 'foobar' } ] response body, got { message: 'Object #<Object> has no method \'needOne\'' }
    at error (node_modules/supertest/lib/test.js:235:13)
    at Test.assert (node_modules/supertest/lib/test.js:166:19)
    at assert (node_modules/supertest/lib/test.js:132:12)
    at node_modules/supertest/lib/test.js:129:5
    at Test.Request.callback (node_modules/supertest/node_modules/superagent/lib/node/index.js:746:30)
    at Test.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:135:10)
    at IncomingMessage.<anonymous> (node_modules/supertest/node_modules/superagent/lib/node/index.js:938:12)
    at _stream_readable.js:920:16

+1

:+1:

:+1:  with some tacked-in documentation - to the API strings in particular since we're removing an API in a 1.1 API release, and notes in the user's guide documentation under workflows? This is probably something worthwhile to call out in a short email to the Corsair team and mailing list with this change - since it's a longer-standing bug in the 1.1 API that we can't seem to really resolve with breaking some level of backwards compatibility. I'm pretty sure this will impact the BOSH CPI team.
FYI: @kaleo211 @meganmurawski @oskoss  - I recall seeing the GET /workflows/library call in your code, so wanted to make sure you had a specific head's up on this.
FYI: @king-jam @jfrey @justink0

*** BUILD #465 ***

Function scripts pass with all dependencies locally.
+1 !

*** BUILD #468 ***

*** BUILD #469 ***


ResourceLoader: Add last resort life-time insurance for tokens

This was intended to come in #94169, but when reorganizing the commits it got lost.
It makes sure that even if all the load requesters are no longer referencing a token, it's still alive until the corresponding load task completes so the task itself isn't removed until not even the resource loader itself is done with it. It's kinda an edge case.

Cherry-pick for 4.3 included in #96606.

Needs rebase.

Rebased!

Thanks!


Error Running Zenbot on Mac - Cannot find module 'options'

I receive the following error with the new Zenbot version on Mac Sierra. I have tried a complete install and still receive the same error trying to find the 'options' module. Please advise. Thank you.
zenbot backfill gdax.BTC-USD --days 14
module.js:487
throw err;
^
Error: Cannot find module 'options'
at Function.Module._resolveFilename (module.js:485:15)
at Function.Module._load (module.js:437:25)
at Module.require (module.js:513:17)
at require (internal/module.js:11:18)
at Object. (/Users/agitate/zenbot/node_modules/gdax/node_modules/ws/lib/WebSocket.js:16:15)
at Module._compile (module.js:569:30)
at Object.Module._extensions..js (module.js:580:10)
at Module.load (module.js:503:32)
at tryModuleLoad (module.js:466:12)
at Function.Module._load (module.js:458:3)
at Module.require (module.js:513:17)
at require (internal/module.js:11:18)
at Object. (/Users/agitate/zenbot/node_modules/gdax/node_modules/ws/index.js:9:27)
at Module._compile (module.js:569:30)
at Object.Module._extensions..js (module.js:580:10)
at Module.load (module.js:503:32)
at tryModuleLoad (module.js:466:12)
at Function.Module._load (module.js:458:3)
at Module.require (module.js:513:17)
at require (internal/module.js:11:18)
at Object. (/Users/agitate/zenbot/node_modules/gdax/lib/clients/websocket.js:2:17)
at Module._compile (module.js:569:30)

Did you run npm install?

this is for sure a missing npm install

Hmmm - I am very capable of being a noob. I validated both node and nsm.
Node -v equals 8.1.2
Npm -v equals 5.0.3
I have two other zenbot 4 nodes running on Mac Sierra with the same versions that are running without issue. I also have Xcode dev tools installed as a prerequisite for node.js. I appreciate the pointer - any other suggestions?
Thanks
Marc
Sent from my iPhone

On Jun 19, 2017, at 5:50 AM, Chase<EMAIL_ADDRESS>wrote:
this is for sure a missing npm install
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I fell back to node v 6 to fix the issue
Sent from my iPhone

On Jun 19, 2017, at 5:50 AM, Chase<EMAIL_ADDRESS>wrote:
this is for sure a missing npm install
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Thank you for pointing me in the right direction. It ended up being the version. I fell back to node v 6 and installed. It works fine now. Thanks!
Sent from my iPhone

On Jun 19, 2017, at 12:12 AM, Takatoshi Nao<EMAIL_ADDRESS>wrote:
Did you run npm install?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Create a custom aggregation transform plugin

Create a custom aggregation transform plugin
:memo: Checklist

[ ] All user-facing changes have changelog entries.
[ ] The changes are reflected on docs.tenzir.com/vast, if necessary.
[ ] The PR description contains instructions for the reviewer, if necessary.

:dart: Review Instructions

I don't think this should be a native plugin, but rather something that's opt-in in plugins/. We can then add it to the CI as well, and it can have a separate changelog.


Add govuk-chat-infrastructure

As per https://docs.publishing.service.gov.uk/manual/github.html#create-and-configure-a-new-gov-uk-repo
The PR to add a README to this repo is still open: https://github.com/alphagov/govuk-chat-infrastructure/pull/1

Ah, thanks Aga! Sorry - should probably have dropped a link to the PR somewhere.


How can I add the ability to wrench-break an item?

I want to be able to shift-wrench to break some specific blocks (storagedrawers drawer controllers and more).
I imagined it's just a tag that I can apply through a datapack but I can't find it through the code. Am I missing something?

https://github.com/Creators-of-Create/Create/wiki/Useful-Tags#block-tags #create:wrench_pickup


Which browsers does this work in?

I couldn't find browser compatibility in the documentation. Can you please advise? Very useful library btw, great job!

Chrome (all platforms including mobile devices)
Firefox (all platforms including mobile devices)
Opera (all platforms including mobile devices)
Safari (all platforms including mobile devices)
Microsoft Edge (Windows 10)


Bind mount or link fails due file already existing

Every time I try to nixos-rebuild test I get these errors, tried on different machines, same result, my config can be found over at my github, and the impermanence setup in particular is here.
I am using nixos 24.05 and the corresponding impermanence version from stable.
Nov 24 18:01:31 workstation systemd[1]: Starting Bind mount or link '/persist/etc/ssh/ssh_host_rsa_key.pub' to '/etc/ssh/ssh_host_rsa_key.pub'...
Nov 24 18:01:31 workstation h676fqdgna11vgzyzsk450i0ymh3fg3n-impermanence-mount-file[64357]: A file already exists at /etc/ssh/ssh_host_rsa_key.pub!
Nov 24 18:01:32 workstation systemd[1]: persist-\x27-persist-etc-ssh-ssh_host_rsa_key.pub\x27.service: Main process exited, code=exited, status=1/FAILURE
Nov 24 18:01:32 workstation systemd[1]: persist-\x27-persist-etc-ssh-ssh_host_rsa_key.pub\x27.service: Failed with result 'exit-code'.
Nov 24 18:01:32 workstation systemd[1]: Failed to start Bind mount or link '/persist/etc/ssh/ssh_host_rsa_key.pub' to '/etc/ssh/ssh_host_rsa_key.pub'.

× persist-\x27-persist-etc-ssh-ssh_host_rsa_key\x27.service - Bind mount or link '/persist/etc/ssh/ssh_host_rsa_key' to '/etc/ssh/ssh_host_rsa_key'
     Loaded: loaded (/etc/systemd/system/persist-\x27-persist-etc-ssh-ssh_host_rsa_key\x27.service; enabled; preset: enabled)
     Active: failed (Result: exit-code) since Sun 2024-11-24 18:01:32 CET; 116ms ago
    Process: 64359 ExecStart=/nix/store/h676fqdgna11vgzyzsk450i0ymh3fg3n-impermanence-mount-file /etc/ssh/ssh_host_rsa_key /persist/etc/ssh/ssh_host_rsa_key  (code=exited, status=1/FAILURE)
   Main PID: 64359 (code=exited, status=1/FAILURE)
         IP: 0B in, 0B out
        CPU: 4ms

Simple setup, using nixos module
    environment.persistence."/persist" = {
      hideMounts = true;
      directories = [
        "/srv"
        "/.cache/nix/"
        "/etc/NetworkManager/system-connections"
        "/var/cache/"
        "/var/tmp/" # needed because we change the nix tmp dir to /var/tmp
        "/var/db/sudo/"
        "/var/lib/"
      ] ++ cfg.directories;
      files = [
        "/etc/machine-id"
        "/etc/ssh/ssh_host_ed25519_key"
        "/etc/ssh/ssh_host_ed25519_key.pub"
        "/etc/ssh/ssh_host_rsa_key"
        "/etc/ssh/ssh_host_rsa_key.pub"
      ] ++ cfg.files;
      users.${config.${namespace}.user.name} = {
        directories = [ ".dotfiles" ] ++ cfg.userDirectories;
      };
    };

All of the files that are failing
warning: the following units failed: persist-\x27-persist-etc-machine\x2did\x27.service, persist-\x27-persist-etc-ssh-ssh_host_ed25519_key.pub\x27.service, persist-\x27-persist-etc-ssh-ssh_host_ed25519_key\x27.service, persist-\x27-persist-etc-ssh-ssh_host_rsa_key.pub\x27.service, persist-\x27-persist-etc-ssh-ssh_host_rsa_key\x27.service

× persist-\x27-persist-etc-machine\x2did\x27.service - Bind mount or link '/persist/etc/machine-id' to '/etc/machine-id'
     Loaded: loaded (/etc/systemd/system/persist-\x27-persist-etc-machine\x2did\x27.service; enabled; preset: enabled)
     Active: failed (Result: exit-code) since Sun 2024-11-24 18:01:31 CET; 176ms ago
    Process: 64353 ExecStart=/nix/store/h676fqdgna11vgzyzsk450i0ymh3fg3n-impermanence-mount-file /etc/machine-id /persist/etc/machine-id  (code=exited, status=1/FAILURE)
   Main PID: 64353 (code=exited, status=1/FAILURE)
         IP: 0B in, 0B out
        CPU: 3ms

Nov 24 18:01:31 workstation systemd[1]: Starting Bind mount or link '/persist/etc/machine-id' to '/etc/machine-id'...
Nov 24 18:01:31 workstation h676fqdgna11vgzyzsk450i0ymh3fg3n-impermanence-mount-file[64353]: A file already exists at /etc/machine-id!
Nov 24 18:01:31 workstation systemd[1]: persist-\x27-persist-etc-machine\x2did\x27.service: Main process exited, code=exited, status=1/FAILURE
Nov 24 18:01:31 workstation systemd[1]: persist-\x27-persist-etc-machine\x2did\x27.service: Failed with result 'exit-code'.
Nov 24 18:01:31 workstation systemd[1]: Failed to start Bind mount or link '/persist/etc/machine-id' to '/etc/machine-id'.

× persist-\x27-persist-etc-ssh-ssh_host_ed25519_key.pub\x27.service - Bind mount or link '/persist/etc/ssh/ssh_host_ed25519_key.pub' to '/etc/ssh/ssh_host_ed25519_key.pub'
     Loaded: loaded (/etc/systemd/system/persist-\x27-persist-etc-ssh-ssh_host_ed25519_key.pub\x27.service; enabled; preset: enabled)
     Active: failed (Result: exit-code) since Sun 2024-11-24 18:01:31 CET; 158ms ago
    Process: 64354 ExecStart=/nix/store/h676fqdgna11vgzyzsk450i0ymh3fg3n-impermanence-mount-file /etc/ssh/ssh_host_ed25519_key.pub /persist/etc/ssh/ssh_host_ed25519_key.pub  (code=exited, status=1/FAILURE)
   Main PID: 64354 (code=exited, status=1/FAILURE)
         IP: 0B in, 0B out
        CPU: 6ms

Nov 24 18:01:31 workstation systemd[1]: Starting Bind mount or link '/persist/etc/ssh/ssh_host_ed25519_key.pub' to '/etc/ssh/ssh_host_ed25519_key.pub'...
Nov 24 18:01:31 workstation h676fqdgna11vgzyzsk450i0ymh3fg3n-impermanence-mount-file[64354]: A file already exists at /etc/ssh/ssh_host_ed25519_key.pub!
Nov 24 18:01:31 workstation systemd[1]: persist-\x27-persist-etc-ssh-ssh_host_ed25519_key.pub\x27.service: Main process exited, code=exited, status=1/FAILURE
Nov 24 18:01:31 workstation systemd[1]: persist-\x27-persist-etc-ssh-ssh_host_ed25519_key.pub\x27.service: Failed with result 'exit-code'.
Nov 24 18:01:31 workstation systemd[1]: Failed to start Bind mount or link '/persist/etc/ssh/ssh_host_ed25519_key.pub' to '/etc/ssh/ssh_host_ed25519_key.pub'.

× persist-\x27-persist-etc-ssh-ssh_host_ed25519_key\x27.service - Bind mount or link '/persist/etc/ssh/ssh_host_ed25519_key' to '/etc/ssh/ssh_host_ed25519_key'
     Loaded: loaded (/etc/systemd/system/persist-\x27-persist-etc-ssh-ssh_host_ed25519_key\x27.service; enabled; preset: enabled)
     Active: failed (Result: exit-code) since Sun 2024-11-24 18:01:31 CET; 136ms ago
    Process: 64355 ExecStart=/nix/store/h676fqdgna11vgzyzsk450i0ymh3fg3n-impermanence-mount-file /etc/ssh/ssh_host_ed25519_key /persist/etc/ssh/ssh_host_ed25519_key  (code=exited, status=1/FAILURE)
   Main PID: 64355 (code=exited, status=1/FAILURE)
         IP: 0B in, 0B out
        CPU: 4ms

Nov 24 18:01:31 workstation systemd[1]: Starting Bind mount or link '/persist/etc/ssh/ssh_host_ed25519_key' to '/etc/ssh/ssh_host_ed25519_key'...
Nov 24 18:01:31 workstation h676fqdgna11vgzyzsk450i0ymh3fg3n-impermanence-mount-file[64355]: A file already exists at /etc/ssh/ssh_host_ed25519_key!
Nov 24 18:01:31 workstation systemd[1]: persist-\x27-persist-etc-ssh-ssh_host_ed25519_key\x27.service: Main process exited, code=exited, status=1/FAILURE
Nov 24 18:01:31 workstation systemd[1]: persist-\x27-persist-etc-ssh-ssh_host_ed25519_key\x27.service: Failed with result 'exit-code'.
Nov 24 18:01:32 workstation systemd[1]: Failed to start Bind mount or link '/persist/etc/ssh/ssh_host_ed25519_key' to '/etc/ssh/ssh_host_ed25519_key'.

× persist-\x27-persist-etc-ssh-ssh_host_rsa_key.pub\x27.service - Bind mount or link '/persist/etc/ssh/ssh_host_rsa_key.pub' to '/etc/ssh/ssh_host_rsa_key.pub'
     Loaded: loaded (/etc/systemd/system/persist-\x27-persist-etc-ssh-ssh_host_rsa_key.pub\x27.service; enabled; preset: enabled)
     Active: failed (Result: exit-code) since Sun 2024-11-24 18:01:32 CET; 128ms ago
    Process: 64357 ExecStart=/nix/store/h676fqdgna11vgzyzsk450i0ymh3fg3n-impermanence-mount-file /etc/ssh/ssh_host_rsa_key.pub /persist/etc/ssh/ssh_host_rsa_key.pub  (code=exited, status=1/FAILURE)
   Main PID: 64357 (code=exited, status=1/FAILURE)
         IP: 0B in, 0B out
        CPU: 4ms

Nov 24 18:01:31 workstation systemd[1]: Starting Bind mount or link '/persist/etc/ssh/ssh_host_rsa_key.pub' to '/etc/ssh/ssh_host_rsa_key.pub'...
Nov 24 18:01:31 workstation h676fqdgna11vgzyzsk450i0ymh3fg3n-impermanence-mount-file[64357]: A file already exists at /etc/ssh/ssh_host_rsa_key.pub!
Nov 24 18:01:32 workstation systemd[1]: persist-\x27-persist-etc-ssh-ssh_host_rsa_key.pub\x27.service: Main process exited, code=exited, status=1/FAILURE
Nov 24 18:01:32 workstation systemd[1]: persist-\x27-persist-etc-ssh-ssh_host_rsa_key.pub\x27.service: Failed with result 'exit-code'.
Nov 24 18:01:32 workstation systemd[1]: Failed to start Bind mount or link '/persist/etc/ssh/ssh_host_rsa_key.pub' to '/etc/ssh/ssh_host_rsa_key.pub'.

× persist-\x27-persist-etc-ssh-ssh_host_rsa_key\x27.service - Bind mount or link '/persist/etc/ssh/ssh_host_rsa_key' to '/etc/ssh/ssh_host_rsa_key'
     Loaded: loaded (/etc/systemd/system/persist-\x27-persist-etc-ssh-ssh_host_rsa_key\x27.service; enabled; preset: enabled)
     Active: failed (Result: exit-code) since Sun 2024-11-24 18:01:32 CET; 116ms ago
    Process: 64359 ExecStart=/nix/store/h676fqdgna11vgzyzsk450i0ymh3fg3n-impermanence-mount-file /etc/ssh/ssh_host_rsa_key /persist/etc/ssh/ssh_host_rsa_key  (code=exited, status=1/FAILURE)
   Main PID: 64359 (code=exited, status=1/FAILURE)
         IP: 0B in, 0B out
        CPU: 4ms

Nov 24 18:01:31 workstation systemd[1]: Starting Bind mount or link '/persist/etc/ssh/ssh_host_rsa_key' to '/etc/ssh/ssh_host_rsa_key'...
Nov 24 18:01:31 workstation h676fqdgna11vgzyzsk450i0ymh3fg3n-impermanence-mount-file[64359]: A file already exists at /etc/ssh/ssh_host_rsa_key!
Nov 24 18:01:32 workstation systemd[1]: persist-\x27-persist-etc-ssh-ssh_host_rsa_key\x27.service: Main process exited, code=exited, status=1/FAILURE
Nov 24 18:01:32 workstation systemd[1]: persist-\x27-persist-etc-ssh-ssh_host_rsa_key\x27.service: Failed with result 'exit-code'.
Nov 24 18:01:32 workstation systemd[1]: Failed to start Bind mount or link '/persist/etc/ssh/ssh_host_rsa_key' to '/etc/ssh/ssh_host_rsa_key'.

User error


Fix typo

python -> Python

Learn Build status updates of commit 690f279:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/machine-learning/how-to-use-parallel-job-in-pipeline.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Looks good; thanks @changeworld


[BUG]: Cheese image is no longer displayed

Describe the bug
#german
Seit dem Update von Photobooth Version 3.3.0 auf 4.3.1 wird zwischen dem Countdown und dem Auslösen der Kamera das Cheese oder in meinem Fall das Bild mit der Kamera und dem Pfeil nach oben nicht mehr angezeigt. Ich habe danach auch im Ordner /privat die Datei cheese.png eingefügt und über das Admin Panel ausgewählt. Der Bildschirm bleibt in diesem Zeitraum leider weiter schwarz. Hat dieses Problem noch irgendwer außer mir?
#english
Since the update of Photobooth version 3.3.0 to 4.3.1, the cheese or in my case the image with the camera and the up arrow no longer appears between the countdown and the triggering of the camera. I then also inserted the file cheese.png in the /private folder and selected it via the admin panel. Unfortunately, the screen remains black during this period. Does anyone else have this problem besides me?
Steps to reproduce the behavior
#german
Cheeseeinblendung zwischen Countdown and Auslösen des Bildes
#english
Cheese overlay between countdown and triggering the image
Expected behavior
#german

Countdown
Cheese Bild
Aufnahme des Bildes

#english

Countdown
Cheese picture
Picture taking picture

Photobooth Version
4.3.1
Browser and browser version
IPad Safari, App Frameless, Safari Iphone 11
Operating System
Raspbian 11 bullseye
Did it work before?
Yes
Latest working version
3.3.0
Additional context
No response

Thanks for the report! Could you please test https://github.com/PhotoboothProject/photobooth/pull/118 ?

Hi Andi, I have customised the scr/core.js accordingly in line 385 with the effect that the cheese sequence not only remains black but is completely missing.

Thanks. Let me check later today or tomorrow. I'll let you know once there's something new to test

Thank you for troubleshooting. Possibly this really only affects my system and is not a general problem.

And this is what it looks like…
https://user-images.githubusercontent.com/33160929/210812400-f5bb6441-b441-410f-84b0-6eac1f59baca.MOV

For me it works with mentioned change. Make sure to run a "yarn build" after applying the change. Also maybe increase the cheese time slightly.


Add Kainan University

school website: https://www.knu.edu.tw/
thank you

@shenglung I am sorry for a delay with processing your request.
Pull request merged. Thank you!


github issues blog source

https://developer.github.com/v3/issues/#list-issues-for-a-repository

I think a better source is discourse, especially for my own blog. Not currently planned.


Locale specific option to join lists

The Join node should use Intl.ListFormat when joining the elements of an array and converting them to text.

Implemented