Modify curation review view to show facet changes

Right now the curation review view (e.g. https://clearlydefined.io/curations/1078) lights up the change the curator has made, for example a change to the definition, however it's very simple and not detailed enough to show facet editing.
We need to expand out this view to allow reviewers to see changes to facets easily. This page might need to be an augmented Full Details Page, perhaps, with highlighting of the facets a curator changed. We need to give the reviewers a much more at-a-glance understanding of what files will be ending up in the new facets if the change is accepted.

@fossygirl a read-only view of the Full Details View could be an acceptable solution?

@storrisi No, not completely. We need to highlight the facet changes, so this is a change.

@storrisi No, not completely. We need to highlight the facet changes, so this is a change.

Actually the FileList already shows which files are affected of a specific facets change.
Should we consider another kind of view for this specific behavior?

Can you show me a gif of reviewing a facet editing PR?

This is what a user see when he change facets values under the Full Details View.

That's not what I'm referring to. I'm referring to the link for reviewing that a person gets from a PR on https://github.com/clearlydefined/curated-data/pulls
For example, when I click on the link from https://github.com/clearlydefined/curated-data/pull/1078#issuecomment-465690231 I should be taken to view the highlighted facet changes. how do I view that?

Do you know a PR that contains some facets changes that we can use as a test?

Sure: https://github.com/clearlydefined/curated-data/pull/437

That PR doesn't show any detail on ClearlyDefined, maybe because it's closed?

Feel free to open some dev PRs that have facet editing if you need to reproduce this.

I've created a contribution on dev which contains a change to the facets.
This is what a user currently can see when looking at the contribution on https://dev.clearlydefined.io/curations/401

Okay, thank you. I still don't think that's obvious enough to users. Can we use the same highlighting mechanism we use for changes in other places on the website? The red color just says "warning" to me, it doesn't say "changed value."

Sure, we can definitely apply the same color.


CompleteCommissioning command ErrorCode - General commissioning

### Problem:
When Commissioning is already completed and again if CompleteCommissioning command is executed. The DUT need to send CompleteCommissioningResponse with ErrorCode as 'Error-NotCommissioning' but in Chip-Tool the ErrorCode is '0' success
### Expected behavior:
Commissioning is completed and again CompleteCommissioning command is executed.
The DUT need to respond with CompleteCommissioningResponse with ErrorCode as 'Error-NotCommissioning'.
### Actual behavior:
Commissioning is completed and again CompleteCommissioning command is executed.
The DUT responds CompleteCommissioningResponse with ErrorCode as '0'.
Command [ after commissioning]: sudo ./chip-tool generalcommissioning commissioning-complete 1 0
[1646203451.006659][3006:3006] CHIP:DL: writing settings to file (/tmp/chip_counters.ini-cvG9Su)
[1646203451.007344][3006:3006] CHIP:DL: renamed tmp file to file (/tmp/chip_counters.ini)
[1646203451.007401][3006:3006] CHIP:DL: NVS set: chip-counters/reboot-count = 11 (0xB)
[1646203451.008395][3006:3006] CHIP:DL: Got Ethernet interface: eth0
[1646203451.008992][3006:3006] CHIP:DL: Found the primary Ethernet interface:eth0
[1646203451.009584][3006:3006] CHIP:DL: Got WiFi interface: wlan0
[1646203451.009657][3006:3006] CHIP:DL: Failed to reset WiFi statistic counts
[1646203451.009726][3006:3006] CHIP:IN: UDP::Init bind&listen port=5542
[1646203451.009836][3006:3006] CHIP:IN: UDP::Init bound to port=5542
[1646203451.009862][3006:3006] CHIP:IN: TransportMgr initialized
[1646203451.009899][3006:3006] CHIP:DIS: Init fabric pairing table with server storage
[1646203451.011967][3006:3006] CHIP:IN: Loading certs from storage
[1646203451.012102][3006:3006] CHIP:IN: Generating compressed fabric ID using uncompressed fabric ID 0x0000000000000001 and root pubkey
[1646203451.012134][3006:3006] CHIP:IN: 0x04, 0xbf, 0xb2, 0xed, 0xbb, 0x39, 0xf1, 0x07,
[1646203451.012157][3006:3006] CHIP:IN: 0x12, 0x5f, 0x77, 0x0c, 0x32, 0x11, 0x24, 0xd9,
[1646203451.012180][3006:3006] CHIP:IN: 0x37, 0xcb, 0x25, 0x74, 0x80, 0xc1, 0x7e, 0xd7,
[1646203451.012203][3006:3006] CHIP:IN: 0xe2, 0xef, 0xae, 0x17, 0x92, 0xbc, 0x22, 0x5e,
[1646203451.012225][3006:3006] CHIP:IN: 0x9c, 0xf1, 0x12, 0x91, 0x8f, 0xf9, 0xf5, 0x3b,
[1646203451.012247][3006:3006] CHIP:IN: 0x83, 0xcc, 0x36, 0x09, 0x36, 0x93, 0x7f, 0x2c,
[1646203451.012269][3006:3006] CHIP:IN: 0x16, 0xbb, 0x67, 0x2c, 0xd5, 0xe7, 0x71, 0x40,
[1646203451.012291][3006:3006] CHIP:IN: 0xde, 0x2c, 0xe8, 0x79, 0x60, 0x01, 0xb2, 0x5c,
[1646203451.012311][3006:3006] CHIP:IN: 0x0c,
[1646203451.012372][3006:3006] CHIP:IN: Generated compressed fabric ID
[1646203451.012398][3006:3006] CHIP:IN: 0x8e, 0xeb, 0x06, 0x15, 0xc9, 0x9c, 0x97, 0x5f,
[1646203451.012662][3006:3006] CHIP:IN: Loading certs from storage
[1646203451.012737][3006:3006] CHIP:IN: Generating compressed fabric ID using uncompressed fabric ID 0x0000000000000002 and root pubkey
[1646203451.012767][3006:3006] CHIP:IN: 0x04, 0xbf, 0xb2, 0xed, 0xbb, 0x39, 0xf1, 0x07,
[1646203451.012791][3006:3006] CHIP:IN: 0x12, 0x5f, 0x77, 0x0c, 0x32, 0x11, 0x24, 0xd9,
[1646203451.012813][3006:3006] CHIP:IN: 0x37, 0xcb, 0x25, 0x74, 0x80, 0xc1, 0x7e, 0xd7,
[1646203451.012835][3006:3006] CHIP:IN: 0xe2, 0xef, 0xae, 0x17, 0x92, 0xbc, 0x22, 0x5e,
[1646203451.012857][3006:3006] CHIP:IN: 0x9c, 0xf1, 0x12, 0x91, 0x8f, 0xf9, 0xf5, 0x3b,
[1646203451.012880][3006:3006] CHIP:IN: 0x83, 0xcc, 0x36, 0x09, 0x36, 0x93, 0x7f, 0x2c,
[1646203451.012902][3006:3006] CHIP:IN: 0x16, 0xbb, 0x67, 0x2c, 0xd5, 0xe7, 0x71, 0x40,
[1646203451.012924][3006:3006] CHIP:IN: 0xde, 0x2c, 0xe8, 0x79, 0x60, 0x01, 0xb2, 0x5c,
[1646203451.012944][3006:3006] CHIP:IN: 0x0c,
[1646203451.012984][3006:3006] CHIP:IN: Generated compressed fabric ID
[1646203451.013010][3006:3006] CHIP:IN: 0x6f, 0x0e, 0x01, 0xd5, 0x24, 0x22, 0x0c, 0x76,
[1646203451.013220][3006:3006] CHIP:IN: Loading certs from storage
[1646203451.013291][3006:3006] CHIP:IN: Generating compressed fabric ID using uncompressed fabric ID 0x0000000000000003 and root pubkey
[1646203451.013321][3006:3006] CHIP:IN: 0x04, 0xbf, 0xb2, 0xed, 0xbb, 0x39, 0xf1, 0x07,
[1646203451.013344][3006:3006] CHIP:IN: 0x12, 0x5f, 0x77, 0x0c, 0x32, 0x11, 0x24, 0xd9,
[1646203451.013366][3006:3006] CHIP:IN: 0x37, 0xcb, 0x25, 0x74, 0x80, 0xc1, 0x7e, 0xd7,
[1646203451.013388][3006:3006] CHIP:IN: 0xe2, 0xef, 0xae, 0x17, 0x92, 0xbc, 0x22, 0x5e,
[1646203451.013411][3006:3006] CHIP:IN: 0x9c, 0xf1, 0x12, 0x91, 0x8f, 0xf9, 0xf5, 0x3b,
[1646203451.013433][3006:3006] CHIP:IN: 0x83, 0xcc, 0x36, 0x09, 0x36, 0x93, 0x7f, 0x2c,
[1646203451.013455][3006:3006] CHIP:IN: 0x16, 0xbb, 0x67, 0x2c, 0xd5, 0xe7, 0x71, 0x40,
[1646203451.013477][3006:3006] CHIP:IN: 0xde, 0x2c, 0xe8, 0x79, 0x60, 0x01, 0xb2, 0x5c,
[1646203451.013496][3006:3006] CHIP:IN: 0x0c,
[1646203451.013536][3006:3006] CHIP:IN: Generated compressed fabric ID
[1646203451.013561][3006:3006] CHIP:IN: 0x83, 0x73, 0xd7, 0xa8, 0x67, 0xde, 0x2e, 0xeb,
[1646203451.013884][3006:3006] CHIP:DL: writing settings to file (/tmp/chip_counters.ini-JgUPZP)
[1646203451.014525][3006:3006] CHIP:DL: renamed tmp file to file (/tmp/chip_counters.ini)
[1646203451.014577][3006:3006] CHIP:DL: NVS set: chip-counters/GlobalMCTR = 11000 (0x2AF8)
[1646203451.014734][3006:3006] CHIP:ZCL: Using ZAP configuration...
[1646203451.019018][3006:3006] CHIP:DL: Avahi client registered
[1646203451.020231][3006:3006] CHIP:CTL: System State Initialized...
[1646203451.021294][3006:3006] CHIP:CTL: Generating NOC
[1646203451.022466][3006:3006] CHIP:DIS: Verifying the received credentials
[1646203451.024297][3006:3006] CHIP:IN: Generating compressed fabric ID using uncompressed fabric ID 0x0000000000000001 and root pubkey
[1646203451.024336][3006:3006] CHIP:IN: 0x04, 0xbf, 0xb2, 0xed, 0xbb, 0x39, 0xf1, 0x07,
[1646203451.024362][3006:3006] CHIP:IN: 0x12, 0x5f, 0x77, 0x0c, 0x32, 0x11, 0x24, 0xd9,
[1646203451.024388][3006:3006] CHIP:IN: 0x37, 0xcb, 0x25, 0x74, 0x80, 0xc1, 0x7e, 0xd7,
[1646203451.024412][3006:3006] CHIP:IN: 0xe2, 0xef, 0xae, 0x17, 0x92, 0xbc, 0x22, 0x5e,
[1646203451.024437][3006:3006] CHIP:IN: 0x9c, 0xf1, 0x12, 0x91, 0x8f, 0xf9, 0xf5, 0x3b,
[1646203451.024460][3006:3006] CHIP:IN: 0x83, 0xcc, 0x36, 0x09, 0x36, 0x93, 0x7f, 0x2c,
[1646203451.024494][3006:3006] CHIP:IN: 0x16, 0xbb, 0x67, 0x2c, 0xd5, 0xe7, 0x71, 0x40,
[1646203451.024519][3006:3006] CHIP:IN: 0xde, 0x2c, 0xe8, 0x79, 0x60, 0x01, 0xb2, 0x5c,
[1646203451.024540][3006:3006] CHIP:IN: 0x0c,
[1646203451.024599][3006:3006] CHIP:IN: Generated compressed fabric ID
[1646203451.024705][3006:3006] CHIP:IN: 0x8e, 0xeb, 0x06, 0x15, 0xc9, 0x9c, 0x97, 0x5f,
[1646203451.024737][3006:3006] CHIP:DIS: Added new fabric at index: 1, Initialized: 1
[1646203451.024761][3006:3006] CHIP:DIS: Assigned compressed fabric ID: 0x8EEB0615C99C975F, node ID: 0x000000000001B669
[1646203451.024785][3006:3006] CHIP:CTL: Joined the fabric at index 1. Compressed fabric ID is: 0x8EEB0615C99C975F
[1646203451.025618][3006:3006] CHIP:CTL: Generating NOC
[1646203451.026776][3006:3006] CHIP:DIS: Verifying the received credentials
[1646203451.028886][3006:3006] CHIP:IN: Generating compressed fabric ID using uncompressed fabric ID 0x0000000000000002 and root pubkey
[1646203451.028931][3006:3006] CHIP:IN: 0x04, 0xbf, 0xb2, 0xed, 0xbb, 0x39, 0xf1, 0x07,
[1646203451.028961][3006:3006] CHIP:IN: 0x12, 0x5f, 0x77, 0x0c, 0x32, 0x11, 0x24, 0xd9,
[1646203451.028990][3006:3006] CHIP:IN: 0x37, 0xcb, 0x25, 0x74, 0x80, 0xc1, 0x7e, 0xd7,
[1646203451.029076][3006:3006] CHIP:IN: 0xe2, 0xef, 0xae, 0x17, 0x92, 0xbc, 0x22, 0x5e,
[1646203451.029104][3006:3006] CHIP:IN: 0x9c, 0xf1, 0x12, 0x91, 0x8f, 0xf9, 0xf5, 0x3b,
[1646203451.029132][3006:3006] CHIP:IN: 0x83, 0xcc, 0x36, 0x09, 0x36, 0x93, 0x7f, 0x2c,
[1646203451.029160][3006:3006] CHIP:IN: 0x16, 0xbb, 0x67, 0x2c, 0xd5, 0xe7, 0x71, 0x40,
[1646203451.029219][3006:3006] CHIP:IN: 0xde, 0x2c, 0xe8, 0x79, 0x60, 0x01, 0xb2, 0x5c,
[1646203451.029248][3006:3006] CHIP:IN: 0x0c,
[1646203451.029313][3006:3006] CHIP:IN: Generated compressed fabric ID
[1646203451.029345][3006:3006] CHIP:IN: 0x6f, 0x0e, 0x01, 0xd5, 0x24, 0x22, 0x0c, 0x76,
[1646203451.029379][3006:3006] CHIP:DIS: Added new fabric at index: 2, Initialized: 1
[1646203451.029405][3006:3006] CHIP:DIS: Assigned compressed fabric ID: 0x6F0E01D524220C76, node ID: 0x000000000001B669
[1646203451.029432][3006:3006] CHIP:CTL: Joined the fabric at index 2. Compressed fabric ID is: 0x6F0E01D524220C76
[1646203451.030362][3006:3006] CHIP:CTL: Generating NOC
[1646203451.031672][3006:3006] CHIP:DIS: Verifying the received credentials
[1646203451.033826][3006:3006] CHIP:IN: Generating compressed fabric ID using uncompressed fabric ID 0x0000000000000003 and root pubkey
[1646203451.033870][3006:3006] CHIP:IN: 0x04, 0xbf, 0xb2, 0xed, 0xbb, 0x39, 0xf1, 0x07,
[1646203451.033900][3006:3006] CHIP:IN: 0x12, 0x5f, 0x77, 0x0c, 0x32, 0x11, 0x24, 0xd9,
[1646203451.033928][3006:3006] CHIP:IN: 0x37, 0xcb, 0x25, 0x74, 0x80, 0xc1, 0x7e, 0xd7,
[1646203451.033956][3006:3006] CHIP:IN: 0xe2, 0xef, 0xae, 0x17, 0x92, 0xbc, 0x22, 0x5e,
[1646203451.033983][3006:3006] CHIP:IN: 0x9c, 0xf1, 0x12, 0x91, 0x8f, 0xf9, 0xf5, 0x3b,
[1646203451.034029][3006:3006] CHIP:IN: 0x83, 0xcc, 0x36, 0x09, 0x36, 0x93, 0x7f, 0x2c,
[1646203451.034058][3006:3006] CHIP:IN: 0x16, 0xbb, 0x67, 0x2c, 0xd5, 0xe7, 0x71, 0x40,
[1646203451.034085][3006:3006] CHIP:IN: 0xde, 0x2c, 0xe8, 0x79, 0x60, 0x01, 0xb2, 0x5c,
[1646203451.034110][3006:3006] CHIP:IN: 0x0c,
[1646203451.034171][3006:3006] CHIP:IN: Generated compressed fabric ID
[1646203451.034203][3006:3006] CHIP:IN: 0x83, 0x73, 0xd7, 0xa8, 0x67, 0xde, 0x2e, 0xeb,
[1646203451.034236][3006:3006] CHIP:DIS: Added new fabric at index: 3, Initialized: 1
[1646203451.034263][3006:3006] CHIP:DIS: Assigned compressed fabric ID: 0x8373D7A867DE2EEB, node ID: 0x000000000001B669
[1646203451.034290][3006:3006] CHIP:CTL: Joined the fabric at index 3. Compressed fabric ID is: 0x8373D7A867DE2EEB
[1646203451.034651][3006:3011] CHIP:DL: CHIP task running
[1646203451.034921][3006:3011] CHIP:DL: HandlePlatformSpecificBLEEvent 32786
[1646203451.034961][3006:3011] CHIP:TOO: Sending command to node 0x1
[1646203451.037141][3006:3011] CHIP:DL: Avahi resolve found
[1646203451.037249][3006:3011] CHIP:DIS: Node ID resolved for 0x0000000000000001
[1646203451.037278][3006:3011] CHIP:DIS:     Addr 0: [fe80::e65f:1ff:fe0e:baf8]:5540
[1646203451.037303][3006:3011] CHIP:CTL: OperationalDiscoveryComplete for device ID 0x0000000000000001
[1646203451.037910][3006:3011] CHIP:IN: Generating DestinationID. Fabric ID 0x0000000000000001, Dest node ID 0x0000000000000001, Random data
[1646203451.037950][3006:3011] CHIP:IN: 0x72, 0x58, 0x2d, 0x5c, 0x04, 0x6f, 0x88, 0x83,
[1646203451.037973][3006:3011] CHIP:IN: 0xe5, 0x1b, 0xb1, 0x38, 0xc5, 0x12, 0x96, 0x1c,
[1646203451.038023][3006:3011] CHIP:IN: 0x84, 0x03, 0xd1, 0x34, 0x06, 0x01, 0xed, 0xf5,
[1646203451.038048][3006:3011] CHIP:IN: 0x4a, 0xba, 0xdc, 0x7c, 0x3f, 0x8c, 0x56, 0x01,
[1646203451.038068][3006:3011] CHIP:IN: Root pubkey
[1646203451.038091][3006:3011] CHIP:IN: 0x04, 0xbf, 0xb2, 0xed, 0xbb, 0x39, 0xf1, 0x07,
[1646203451.038113][3006:3011] CHIP:IN: 0x12, 0x5f, 0x77, 0x0c, 0x32, 0x11, 0x24, 0xd9,
[1646203451.038135][3006:3011] CHIP:IN: 0x37, 0xcb, 0x25, 0x74, 0x80, 0xc1, 0x7e, 0xd7,
[1646203451.038156][3006:3011] CHIP:IN: 0xe2, 0xef, 0xae, 0x17, 0x92, 0xbc, 0x22, 0x5e,
[1646203451.038178][3006:3011] CHIP:IN: 0x9c, 0xf1, 0x12, 0x91, 0x8f, 0xf9, 0xf5, 0x3b,
[1646203451.038200][3006:3011] CHIP:IN: 0x83, 0xcc, 0x36, 0x09, 0x36, 0x93, 0x7f, 0x2c,
[1646203451.038222][3006:3011] CHIP:IN: 0x16, 0xbb, 0x67, 0x2c, 0xd5, 0xe7, 0x71, 0x40,
[1646203451.038244][3006:3011] CHIP:IN: 0xde, 0x2c, 0xe8, 0x79, 0x60, 0x01, 0xb2, 0x5c,
[1646203451.038263][3006:3011] CHIP:IN: 0x0c,
[1646203451.038283][3006:3011] CHIP:IN: IPK
[1646203451.038306][3006:3011] CHIP:IN: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
[1646203451.038328][3006:3011] CHIP:IN: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
[1646203451.038368][3006:3011] CHIP:IN: Generated DestinationID output
[1646203451.038393][3006:3011] CHIP:IN: 0x0b, 0xd7, 0xa7, 0xa1, 0xb7, 0xf8, 0x8c, 0xec,
[1646203451.038415][3006:3011] CHIP:IN: 0x4b, 0xf6, 0x07, 0x33, 0x2a, 0x78, 0x6f, 0x5a,
[1646203451.038436][3006:3011] CHIP:IN: 0x19, 0xe3, 0x63, 0x51, 0xda, 0xbb, 0x2c, 0xb3,
[1646203451.038458][3006:3011] CHIP:IN: 0xde, 0x9d, 0xf1, 0x42, 0xac, 0x31, 0xeb, 0x15,
[1646203451.038480][3006:3011] CHIP:SC: Including MRP parameters
[1646203451.038543][3006:3011] CHIP:IN: Prepared unauthenticated message 0xaaaae0aec778 to 0x0000000000000000 (0)  of type 0x30 and protocolId (0, 0) on exchange 59295i with MessageCounter:548347744.
[1646203451.038610][3006:3011] CHIP:IN: Sending unauthenticated msg 0xaaaae0aec778 with MessageCounter:548347744 to 0x0000000000000000 at monotonic time: 2896660 msec
[1646203451.038746][3006:3011] CHIP:SC: Sent Sigma1 msg
[1646203451.038779][3006:3011] CHIP:CTL: Address resolved for node: 0x0000000000000001
[1646203451.067649][3006:3011] CHIP:EM: Received message of type 0x31 with protocolId (0, 0) and MessageCounter:453304424 on exchange 59295i
[1646203451.067750][3006:3011] CHIP:EM: Found matching exchange: 59295i, Delegate: 0xffff78001068
[1646203451.067838][3006:3011] CHIP:EM: Rxd Ack; Removing MessageCounter:548347744 from Retrans Table on exchange 59295i
[1646203451.067898][3006:3011] CHIP:EM: Removed CHIP MessageCounter:548347744 from RetransTable on exchange 59295i
[1646203451.067978][3006:3011] CHIP:SC: Received Sigma2 msg
[1646203451.068054][3006:3011] CHIP:SC: Peer assigned session session ID 13
[1646203451.069433][3006:3011] CHIP:SC: The device does not support GetClock_RealTimeMS() API. This will eventually result in CASE session setup failures.
[1646203451.073872][3006:3011] CHIP:IN: Generating compressed fabric ID using uncompressed fabric ID 0x0000000000000001 and root pubkey
[1646203451.074102][3006:3011] CHIP:IN: 0x04, 0xbf, 0xb2, 0xed, 0xbb, 0x39, 0xf1, 0x07,
[1646203451.074165][3006:3011] CHIP:IN: 0x12, 0x5f, 0x77, 0x0c, 0x32, 0x11, 0x24, 0xd9,
[1646203451.074222][3006:3011] CHIP:IN: 0x37, 0xcb, 0x25, 0x74, 0x80, 0xc1, 0x7e, 0xd7,
[1646203451.074278][3006:3011] CHIP:IN: 0xe2, 0xef, 0xae, 0x17, 0x92, 0xbc, 0x22, 0x5e,
[1646203451.074333][3006:3011] CHIP:IN: 0x9c, 0xf1, 0x12, 0x91, 0x8f, 0xf9, 0xf5, 0x3b,
[1646203451.074388][3006:3011] CHIP:IN: 0x83, 0xcc, 0x36, 0x09, 0x36, 0x93, 0x7f, 0x2c,
[1646203451.074442][3006:3011] CHIP:IN: 0x16, 0xbb, 0x67, 0x2c, 0xd5, 0xe7, 0x71, 0x40,
[1646203451.074497][3006:3011] CHIP:IN: 0xde, 0x2c, 0xe8, 0x79, 0x60, 0x01, 0xb2, 0x5c,
[1646203451.074547][3006:3011] CHIP:IN: 0x0c,
[1646203451.074657][3006:3011] CHIP:IN: Generated compressed fabric ID
[1646203451.074721][3006:3011] CHIP:IN: 0x8e, 0xeb, 0x06, 0x15, 0xc9, 0x9c, 0x97, 0x5f,
[1646203451.076370][3006:3011] CHIP:SC: Found MRP parameters in the message
[1646203451.076471][3006:3011] CHIP:SC: Sending Sigma3
[1646203451.076990][3006:3011] CHIP:EM: Piggybacking Ack for MessageCounter:453304424 on exchange: 59295i
[1646203451.077049][3006:3011] CHIP:IN: Prepared unauthenticated message 0xaaaae0aec778 to 0x0000000000000000 (0)  of type 0x32 and protocolId (0, 0) on exchange 59295i with MessageCounter:548347745.
[1646203451.077100][3006:3011] CHIP:IN: Sending unauthenticated msg 0xaaaae0aec778 with MessageCounter:548347745 to 0x0000000000000000 at monotonic time: 2896699 msec
[1646203451.077254][3006:3011] CHIP:SC: Sent Sigma3 msg
[1646203451.088361][3006:3011] CHIP:EM: Received message of type 0x40 with protocolId (0, 0) and MessageCounter:453304425 on exchange 59295i
[1646203451.088402][3006:3011] CHIP:EM: Found matching exchange: 59295i, Delegate: 0xffff78001068
[1646203451.088446][3006:3011] CHIP:EM: Rxd Ack; Removing MessageCounter:548347745 from Retrans Table on exchange 59295i
[1646203451.088478][3006:3011] CHIP:EM: Removed CHIP MessageCounter:548347745 from RetransTable on exchange 59295i
[1646203451.088524][3006:3011] CHIP:SC: Success status report received. Session was established
[1646203451.088558][3006:3011] CHIP:IN: New secure session created for device 0x0000000000000001, LSID:1 PSID:13!
[1646203451.088681][3006:3011] CHIP:TOO: Sending cluster (0x00000030) command (0x00000004) on endpoint 0
[1646203451.088773][3006:3011] CHIP:DMG: ICR moving to [AddingComm]
[1646203451.088830][3006:3011] CHIP:DMG: ICR moving to [AddedComma]
[1646203451.088919][3006:3011] CHIP:IN: Prepared secure message 0xaaaae0aec778 to 0x0000000000000001 (1)  of type 0x8 and protocolId (0, 1) on exchange 59296i with MessageCounter:5873489.
[1646203451.088966][3006:3011] CHIP:IN: Sending encrypted msg 0xaaaae0aec778 with MessageCounter:5873489 to 0x0000000000000001 (1) at monotonic time: 2896710 msec
[1646203451.089081][3006:3011] CHIP:DMG: ICR moving to [CommandSen]
[1646203451.089119][3006:3011] CHIP:CTL: Device connected callback with null pairing delegate. Ignoring
[1646203451.089169][3006:3011] CHIP:EM: Sending Standalone Ack for MessageCounter:453304425 on exchange 59295i
[1646203451.089210][3006:3011] CHIP:IN: Prepared unauthenticated message 0xffff8afdd938 to 0x0000000000000000 (0)  of type 0x10 and protocolId (0, 0) on exchange 59295i with MessageCounter:548347746.
[1646203451.089250][3006:3011] CHIP:IN: Sending unauthenticated msg 0xffff8afdd938 with MessageCounter:548347746 to 0x0000000000000000 at monotonic time: 2896711 msec
[1646203451.089334][3006:3011] CHIP:EM: Flushed pending ack for MessageCounter:453304425 on exchange 59295i
[1646203451.092917][3006:3011] CHIP:EM: Received message of type 0x9 with protocolId (0, 1) and MessageCounter:14415629 on exchange 59296i
[1646203451.092974][3006:3011] CHIP:EM: Found matching exchange: 59296i, Delegate: 0xffff78003aa0
[1646203451.093030][3006:3011] CHIP:EM: Rxd Ack; Removing MessageCounter:5873489 from Retrans Table on exchange 59296i
[1646203451.093073][3006:3011] CHIP:EM: Removed CHIP MessageCounter:5873489 from RetransTable on exchange 59296i
[1646203451.093126][3006:3011] CHIP:DMG: ICR moving to [ResponseRe]
[1646203451.093204][3006:3011] CHIP:DMG: InvokeResponseMessage =
[1646203451.093249][3006:3011] CHIP:DMG: {
[1646203451.093291][3006:3011] CHIP:DMG:        suppressResponse = false,
[1646203451.093336][3006:3011] CHIP:DMG:        InvokeResponseIBs =
[1646203451.093393][3006:3011] CHIP:DMG:        [
[1646203451.093438][3006:3011] CHIP:DMG:                InvokeResponseIB =
[1646203451.093510][3006:3011] CHIP:DMG:                {
[1646203451.093557][3006:3011] CHIP:DMG:                        CommandDataIB =
[1646203451.093613][3006:3011] CHIP:DMG:                        {
[1646203451.093668][3006:3011] CHIP:DMG:                                CommandPathIB =
[1646203451.093728][3006:3011] CHIP:DMG:                                {
[1646203451.093788][3006:3011] CHIP:DMG:                                        EndpointId = 0x0,
[1646203451.093858][3006:3011] CHIP:DMG:                                        ClusterId = 0x30,
[1646203451.093921][3006:3011] CHIP:DMG:                                        CommandId = 0x5,
[1646203451.093985][3006:3011] CHIP:DMG:                                },
[1646203451.094096][3006:3011] CHIP:DMG:
[1646203451.094149][3006:3011] CHIP:DMG:                                CommandData =
[1646203451.094208][3006:3011] CHIP:DMG:                                {
[1646203451.094270][3006:3011] CHIP:DMG:                                        0x0 = 0,
[1646203451.094337][3006:3011] CHIP:DMG:                                        0x1 = "",
[1646203451.094405][3006:3011] CHIP:DMG:                                },
[1646203451.094461][3006:3011] CHIP:DMG:                        },
[1646203451.094522][3006:3011] CHIP:DMG:
[1646203451.094571][3006:3011] CHIP:DMG:                },
[1646203451.094630][3006:3011] CHIP:DMG:
[1646203451.094673][3006:3011] CHIP:DMG:        ],
[1646203451.094728][3006:3011] CHIP:DMG:
[1646203451.094771][3006:3011] CHIP:DMG:        InteractionModelRevision = 1
[1646203451.094813][3006:3011] CHIP:DMG: },
[1646203451.094921][3006:3011] CHIP:DMG: Received Command Response Data, Endpoint=0 Cluster=0x0000_0030 Command=0x0000_0005
[1646203451.094997][3006:3011] CHIP:TOO: Endpoint: 0 Cluster: 0x0000_0030 Command 0x0000_0005
[1646203451.095097][3006:3011] CHIP:TOO:   CommissioningCompleteResponse: {
[1646203451.095157][3006:3011] CHIP:TOO:     errorCode: 0
[1646203451.095200][3006:3011] CHIP:TOO:     debugText:
[1646203451.095242][3006:3011] CHIP:TOO:    }
[1646203451.095293][3006:3011] CHIP:DMG: ICR moving to [AwaitingDe]
[1646203451.095375][3006:3011] CHIP:EM: Sending Standalone Ack for MessageCounter:14415629 on exchange 59296i
[1646203451.095461][3006:3011] CHIP:IN: Prepared secure message 0xffff8afdd968 to 0x0000000000000001 (1)  of type 0x10 and protocolId (0, 0) on exchange 59296i with MessageCounter:5873490.
[1646203451.095522][3006:3011] CHIP:IN: Sending encrypted msg 0xffff8afdd968 with MessageCounter:5873490 to 0x0000000000000001 (1) at monotonic time: 2896717 msec
[1646203451.095666][3006:3011] CHIP:EM: Flushed pending ack for MessageCounter:14415629 on exchange 59296i
[1646203451.095918][3006:3006] CHIP:CTL: Shutting down the commissioner
[1646203451.095974][3006:3006] CHIP:CTL: Shutting down the controller
[1646203451.096026][3006:3006] CHIP:CTL: Shutting down the commissioner
[1646203451.096069][3006:3006] CHIP:CTL: Shutting down the controller
[1646203451.096135][3006:3006] CHIP:CTL: Shutting down the commissioner
[1646203451.096178][3006:3006] CHIP:CTL: Shutting down the controller
[1646203451.096237][3006:3006] CHIP:CTL: Shutting down the commissioner
[1646203451.096279][3006:3006] CHIP:CTL: Shutting down the controller
[1646203451.096331][3006:3006] CHIP:CTL: Shutting down the System State, this will teardown the CHIP Stack
[1646203451.097750][3006:3006] CHIP:DMG: IM WH moving to [Uninitialized]
[1646203451.097812][3006:3006] CHIP:DMG: IM WH moving to [Uninitialized]
[1646203451.097850][3006:3006] CHIP:DMG: IM WH moving to [Uninitialized]
[1646203451.097887][3006:3006] CHIP:DMG: IM WH moving to [Uninitialized]
[1646203451.098040][3006:3006] CHIP:BLE: BleConnectionDelegate::CancelConnection is not implemented.
[1646203451.098419][3006:3006] CHIP:DL: writing settings to file (/tmp/chip_counters.ini-y27y6o)
[1646203451.099484][3006:3006] CHIP:DL: renamed tmp file to file (/tmp/chip_counters.ini)
[1646203451.099583][3006:3006] CHIP:DL: NVS set: chip-counters/total-operational-hours = 0 (0x0)
[1646203451.099630][3006:3006] CHIP:DL: Inet Layer shutdown
[1646203451.099668][3006:3006] CHIP:DL: BLE shutdown
[1646203451.099709][3006:3006] CHIP:DL: System Layer shutdown

The issue is resolved in Img V3.7
ubuntu@ubuntu:~/apps$ ./chip-tool generalcommissioning commissioning-complete 1 0
[1651142135.945634][5391:5391] CHIP:DL: ChipLinuxStorage::Init: Using KVS config file: /tmp/chip_kvs
[1651142135.946212][5391:5391] CHIP:DL: ChipLinuxStorage::Init: Using KVS config file: /tmp/chip_factory.ini
[1651142135.946379][5391:5391] CHIP:DL: ChipLinuxStorage::Init: Using KVS config file: /tmp/chip_config.ini
[1651142135.946492][5391:5391] CHIP:DL: ChipLinuxStorage::Init: Using KVS config file: /tmp/chip_counters.ini
[1651142135.946835][5391:5391] CHIP:DL: writing settings to file (/tmp/chip_counters.ini-wUECdb)
[1651142135.947456][5391:5391] CHIP:DL: renamed tmp file to file (/tmp/chip_counters.ini)
[1651142135.947507][5391:5391] CHIP:DL: NVS set: chip-counters/reboot-count = 8 (0x8)
[1651142135.948356][5391:5391] CHIP:DL: Got Ethernet interface: eth0
[1651142135.948923][5391:5391] CHIP:DL: Found the primary Ethernet interface:eth0
[1651142135.949494][5391:5391] CHIP:DL: Got WiFi interface: wlan0
[1651142135.949564][5391:5391] CHIP:DL: Failed to reset WiFi statistic counts
[1651142135.949640][5391:5391] CHIP:IN: UDP::Init bind&listen port=0
[1651142135.949768][5391:5391] CHIP:IN: UDP::Init bound to port=48764
[1651142135.949794][5391:5391] CHIP:IN: BLEBase::Init - setting/overriding transport
[1651142135.949816][5391:5391] CHIP:IN: TransportMgr initialized
[1651142135.949850][5391:5391] CHIP:DIS: Init fabric pairing table with server storage
[1651142135.949978][5391:5391] CHIP:IN: Loading from storage for fabric index 0x1
[1651142135.952483][5391:5391] CHIP:IN: Loading from storage for fabric index 0x2
[1651142135.953138][5391:5391] CHIP:IN: Loading from storage for fabric index 0x3
[1651142135.953677][5391:5391] CHIP:DIS: Add fabric pairing table delegate
[1651142135.956678][5391:5391] CHIP:ZCL: Using ZAP configuration...
[1651142135.961174][5391:5391] CHIP:DL: Avahi client registered
[1651142135.962547][5391:5391] CHIP:CTL: System State Initialized...
[1651142135.962650][5391:5391] CHIP:CTL: Setting attestation nonce to random value
[1651142135.962704][5391:5391] CHIP:CTL: Setting CSR nonce to random value
[1651142135.962820][5391:5391] CHIP:CTL: Setting attestation nonce to random value
[1651142135.962891][5391:5391] CHIP:CTL: Setting CSR nonce to random value
[1651142135.963920][5391:5391] CHIP:CTL: Generating NOC
[1651142135.964987][5391:5391] CHIP:DIS: Verifying the received credentials
[1651142135.967188][5391:5391] CHIP:DIS: Added new fabric at index: 0x1, Initialized: 1
[1651142135.967231][5391:5391] CHIP:DIS: Assigned compressed fabric ID: 0xBA5D7B503B5AB2B7, node ID: 0x000000000001B669
[1651142135.967261][5391:5391] CHIP:CTL: Joined the fabric at index 1. Compressed fabric ID is: 0xBA5D7B503B5AB2B7
[1651142135.967431][5391:5391] CHIP:CTL: Setting attestation nonce to random value
[1651142135.967514][5391:5391] CHIP:CTL: Setting CSR nonce to random value
[1651142135.968484][5391:5391] CHIP:CTL: Generating NOC
[1651142135.969527][5391:5391] CHIP:DIS: Verifying the received credentials
[1651142135.971705][5391:5391] CHIP:DIS: Added new fabric at index: 0x2, Initialized: 1
[1651142135.971745][5391:5391] CHIP:DIS: Assigned compressed fabric ID: 0xE48A8729C4956A0D, node ID: 0x000000000001B669
[1651142135.971775][5391:5391] CHIP:CTL: Joined the fabric at index 2. Compressed fabric ID is: 0xE48A8729C4956A0D
[1651142135.971865][5391:5391] CHIP:CTL: Setting attestation nonce to random value
[1651142135.971951][5391:5391] CHIP:CTL: Setting CSR nonce to random value
[1651142135.972896][5391:5391] CHIP:CTL: Generating NOC
[1651142135.974055][5391:5391] CHIP:DIS: Verifying the received credentials
[1651142135.976187][5391:5391] CHIP:DIS: Added new fabric at index: 0x3, Initialized: 1
[1651142135.976226][5391:5391] CHIP:DIS: Assigned compressed fabric ID: 0x1C7BF35B444AAC3E, node ID: 0x000000000001B669
[1651142135.976249][5391:5391] CHIP:CTL: Joined the fabric at index 3. Compressed fabric ID is: 0x1C7BF35B444AAC3E
[1651142136.005908][5391:5396] CHIP:DL: CHIP task running
[1651142136.006152][5391:5396] CHIP:DL: HandlePlatformSpecificBLEEvent 32787
[1651142136.006189][5391:5396] CHIP:TOO: Sending command to node 0x1
[1651142136.006223][5391:5396] CHIP:CSM: FindOrEstablishSession: PeerId = BA5D7B503B5AB2B7:0000000000000001
[1651142136.006248][5391:5396] CHIP:CSM: FindOrEstablishSession: No existing OperationalDeviceProxy instance found
[1651142136.006293][5391:5396] CHIP:DIS: Resolving BA5D7B503B5AB2B7:0000000000000001 ...
[1651142136.008031][5391:5396] CHIP:DL: Avahi resolve found
[1651142136.008112][5391:5396] CHIP:DIS: Node ID resolved for BA5D7B503B5AB2B7:0000000000000001
[1651142136.008143][5391:5396] CHIP:DIS:     Addr 0: [fe80::e65f:1ff:fe0e:baf8]:5540
[1651142136.008394][5391:5396] CHIP:DIS: UDP:[fe80::e65f:1ff:fe0e:baf8%eth0]:5540: new best score: 3
[1651142136.008423][5391:5396] CHIP:DIS: Checking node lookup status after 2 ms
[1651142136.008445][5391:5396] CHIP:DIS: Keeping DNSSD lookup active
[1651142136.206721][5391:5396] CHIP:DIS: Checking node lookup status after 200 ms
[1651142136.207014][5391:5396] CHIP:CTL: Updating device address to UDP:[fe80::e65f:1ff:fe0e:baf8%eth0]:5540 while in state 1
[1651142136.207077][5391:5396] CHIP:CTL: OperationalDeviceProxy[BA5D7B503B5AB2B7:0000000000000001]: State change 1 --> 2
[1651142136.207521][5391:5396] CHIP:SC: Establishing CASE session to UDP:[fe80::e65f:1ff:fe0e:baf8%eth0]:5540
[1651142136.208865][5391:5396] CHIP:SC: RecoverInitiatorIpk: GroupDataProvider 0xaaaaffaac2f0, Got IPK for FabricIndex 1
[1651142136.208959][5391:5396] CHIP:SC: 0x72, 0xb2, 0xdf, 0x52, 0x98, 0x64, 0x7d, 0x91,
[1651142136.209019][5391:5396] CHIP:SC: 0x5a, 0x86, 0x5a, 0x6a, 0x1f, 0x65, 0x21, 0xe6,
[1651142136.209253][5391:5396] CHIP:SC: Including MRP parameters
[1651142136.209434][5391:5396] CHIP:IN: Prepared unauthenticated message 0xaaab0018e718 to 0x0000000000000000 (0)  of type 0x30 and protocolId (0, 0) on exchange 64319i with MessageCounter:2248764093.
[1651142136.209561][5391:5396] CHIP:IN: Sending unauthenticated msg 0xaaab0018e718 with MessageCounter:2248764093 to 0x0000000000000000 at monotonic time:<PHONE_NUMBER>208C37 msec
[1651142136.209890][5391:5396] CHIP:SC: Sent Sigma1 msg
[1651142136.209956][5391:5396] CHIP:CTL: OperationalDeviceProxy[BA5D7B503B5AB2B7:0000000000000001]: State change 2 --> 3
[1651142136.210022][5391:5396] CHIP:DIS: Discovery does not require any more timeouts
[1651142136.310556][5391:5396] CHIP:EM: Received message of type 0x31 with protocolId (0, 0) and MessageCounter:206586348 on exchange 64319i
[1651142136.310655][5391:5396] CHIP:EM: Found matching exchange: 64319i, Delegate: 0xffff90001218
[1651142136.310744][5391:5396] CHIP:EM: Rxd Ack; Removing MessageCounter:2248764093 from Retrans Table on exchange 64319i
[1651142136.310807][5391:5396] CHIP:EM: Removed CHIP MessageCounter:2248764093 from RetransTable on exchange 64319i
[1651142136.310891][5391:5396] CHIP:SC: Received Sigma2 msg
[1651142136.310998][5391:5396] CHIP:SC: Peer assigned session session ID 50806
[1651142136.312410][5391:5396] CHIP:SC: The device does not support GetClock_RealTimeMS() API. This will eventually result in CASE session setup failures.
[1651142136.318831][5391:5396] CHIP:SC: Found MRP parameters in the message
[1651142136.318940][5391:5396] CHIP:SC: Sending Sigma3
[1651142136.319650][5391:5396] CHIP:EM: Piggybacking Ack for MessageCounter:206586348 on exchange: 64319i
[1651142136.319898][5391:5396] CHIP:IN: Prepared unauthenticated message 0xaaab0018e718 to 0x0000000000000000 (0)  of type 0x32 and protocolId (0, 0) on exchange 64319i with MessageCounter:2248764094.
[1651142136.319995][5391:5396] CHIP:IN: Sending unauthenticated msg 0xaaab0018e718 with MessageCounter:2248764094 to 0x0000000000000000 at monotonic time:<PHONE_NUMBER>208CA5 msec
[1651142136.320339][5391:5396] CHIP:SC: Sent Sigma3 msg
[1651142136.329156][5391:5396] CHIP:EM: Received message of type 0x40 with protocolId (0, 0) and MessageCounter:206586349 on exchange 64319i
[1651142136.329202][5391:5396] CHIP:EM: Found matching exchange: 64319i, Delegate: 0xffff90001218
[1651142136.329243][5391:5396] CHIP:EM: Rxd Ack; Removing MessageCounter:2248764094 from Retrans Table on exchange 64319i
[1651142136.329268][5391:5396] CHIP:EM: Removed CHIP MessageCounter:2248764094 from RetransTable on exchange 64319i
[1651142136.329306][5391:5396] CHIP:SC: Success status report received. Session was established
[1651142136.329333][5391:5396] CHIP:IN: New secure session created for device 0x0000000000000001, LSID:18736 PSID:50806!
[1651142136.329407][5391:5396] CHIP:CTL: OperationalDeviceProxy[BA5D7B503B5AB2B7:0000000000000001]: State change 3 --> 4
[1651142136.329464][5391:5396] CHIP:TOO: Sending cluster (0x00000030) command (0x00000004) on endpoint 0
[1651142136.329546][5391:5396] CHIP:DMG: ICR moving to [AddingComm]
[1651142136.329591][5391:5396] CHIP:DMG: ICR moving to [AddedComma]
[1651142136.329692][5391:5396] CHIP:IN: Prepared secure message 0xaaab0018e718 to 0x0000000000000001 (1)  of type 0x8 and protocolId (0, 1) on exchange 64320i with MessageCounter:11197359.
[1651142136.329735][5391:5396] CHIP:IN: Sending encrypted msg 0xaaab0018e718 with MessageCounter:11197359 to 0x0000000000000001 (1) at monotonic time:<PHONE_NUMBER>208CAF msec
[1651142136.329920][5391:5396] CHIP:DMG: ICR moving to [CommandSen]
[1651142136.329973][5391:5396] CHIP:EM: Sending Standalone Ack for MessageCounter:206586349 on exchange 64319i
[1651142136.330015][5391:5396] CHIP:IN: Prepared unauthenticated message 0xffffa5342928 to 0x0000000000000000 (0)  of type 0x10 and protocolId (0, 0) on exchange 64319i with MessageCounter:2248764095.
[1651142136.330051][5391:5396] CHIP:IN: Sending unauthenticated msg 0xffffa5342928 with MessageCounter:2248764095 to 0x0000000000000000 at monotonic time:<PHONE_NUMBER>208CAF msec
[1651142136.330171][5391:5396] CHIP:EM: Flushed pending ack for MessageCounter:206586349 on exchange 64319i
[1651142136.341956][5391:5396] CHIP:EM: Received message of type 0x9 with protocolId (0, 1) and MessageCounter:9882569 on exchange 64320i
[1651142136.342007][5391:5396] CHIP:EM: Found matching exchange: 64320i, Delegate: 0xffff90005c20
[1651142136.342050][5391:5396] CHIP:EM: Rxd Ack; Removing MessageCounter:11197359 from Retrans Table on exchange 64320i
[1651142136.342074][5391:5396] CHIP:EM: Removed CHIP MessageCounter:11197359 from RetransTable on exchange 64320i
[1651142136.342131][5391:5396] CHIP:DMG: ICR moving to [ResponseRe]
[1651142136.342187][5391:5396] CHIP:DMG: InvokeResponseMessage =
[1651142136.342210][5391:5396] CHIP:DMG: {
[1651142136.342234][5391:5396] CHIP:DMG:        suppressResponse = false,
[1651142136.342282][5391:5396] CHIP:DMG:        InvokeResponseIBs =
[1651142136.342317][5391:5396] CHIP:DMG:        [
[1651142136.342342][5391:5396] CHIP:DMG:                InvokeResponseIB =
[1651142136.342383][5391:5396] CHIP:DMG:                {
[1651142136.342412][5391:5396] CHIP:DMG:                        CommandDataIB =
[1651142136.342447][5391:5396] CHIP:DMG:                        {
[1651142136.342481][5391:5396] CHIP:DMG:                                CommandPathIB =
[1651142136.342518][5391:5396] CHIP:DMG:                                {
[1651142136.342556][5391:5396] CHIP:DMG:                                        EndpointId = 0x0,
[1651142136.342596][5391:5396] CHIP:DMG:                                        ClusterId = 0x30,
[1651142136.342631][5391:5396] CHIP:DMG:                                        CommandId = 0x5,
[1651142136.342668][5391:5396] CHIP:DMG:                                },
[1651142136.342707][5391:5396] CHIP:DMG:
[1651142136.342740][5391:5396] CHIP:DMG:                                CommandData =
[1651142136.342777][5391:5396] CHIP:DMG:                                {
[1651142136.342815][5391:5396] CHIP:DMG:                                        0x0 = 3,
[1651142136.342855][5391:5396] CHIP:DMG:                                        0x1 = "",
[1651142136.342893][5391:5396] CHIP:DMG:                                },
[1651142136.342928][5391:5396] CHIP:DMG:                        },
[1651142136.342965][5391:5396] CHIP:DMG:
[1651142136.342993][5391:5396] CHIP:DMG:                },
[1651142136.343026][5391:5396] CHIP:DMG:
[1651142136.343049][5391:5396] CHIP:DMG:        ],
[1651142136.343080][5391:5396] CHIP:DMG:
[1651142136.343105][5391:5396] CHIP:DMG:        InteractionModelRevision = 1
[1651142136.343130][5391:5396] CHIP:DMG: },
[1651142136.343194][5391:5396] CHIP:DMG: Received Command Response Data, Endpoint=0 Cluster=0x0000_0030 Command=0x0000_0005
[1651142136.343249][5391:5396] CHIP:TOO: Endpoint: 0 Cluster: 0x0000_0030 Command 0x0000_0005
[1651142136.343319][5391:5396] CHIP:TOO:   CommissioningCompleteResponse: {
[1651142136.343357][5391:5396] CHIP:TOO:     errorCode: 3
[1651142136.343381][5391:5396] CHIP:TOO:     debugText:
[1651142136.343404][5391:5396] CHIP:TOO:    }
[1651142136.343443][5391:5396] CHIP:DMG: ICR moving to [AwaitingDe]
[1651142136.343503][5391:5396] CHIP:EM: Sending Standalone Ack for MessageCounter:9882569 on exchange 64320i
[1651142136.343578][5391:5396] CHIP:IN: Prepared secure message 0xffffa5342938 to 0x0000000000000001 (1)  of type 0x10 and protocolId (0, 0) on exchange 64320i with MessageCounter:11197360.
[1651142136.343618][5391:5396] CHIP:IN: Sending encrypted msg 0xffffa5342938 with MessageCounter:11197360 to 0x0000000000000001 (1) at monotonic time:<PHONE_NUMBER>208CBD msec
[1651142136.343749][5391:5396] CHIP:EM: Flushed pending ack for MessageCounter:9882569 on exchange 64320i
[1651142136.343961][5391:5391] CHIP:CTL: Shutting down the commissioner
[1651142136.344003][5391:5391] CHIP:CTL: Shutting down the controller
[1651142136.344033][5391:5391] CHIP:CTL: Shutting down the commissioner
[1651142136.344057][5391:5391] CHIP:CTL: Shutting down the controller
[1651142136.344087][5391:5391] CHIP:IN: Expiring all connections for fabric 1!!
[1651142136.344138][5391:5391] CHIP:CTL: Shutting down the commissioner
[1651142136.344164][5391:5391] CHIP:CTL: Shutting down the controller
[1651142136.344185][5391:5391] CHIP:IN: Expiring all connections for fabric 2!!
[1651142136.344218][5391:5391] CHIP:CTL: Shutting down the commissioner
[1651142136.344242][5391:5391] CHIP:CTL: Shutting down the controller
[1651142136.344262][5391:5391] CHIP:IN: Expiring all connections for fabric 3!!
[1651142136.344292][5391:5391] CHIP:CTL: Shutting down the System State, this will teardown the CHIP Stack
[1651142136.345313][5391:5391] CHIP:DMG: IM WH moving to [Uninitialized]
[1651142136.345363][5391:5391] CHIP:DMG: IM WH moving to [Uninitialized]
[1651142136.345381][5391:5391] CHIP:DMG: IM WH moving to [Uninitialized]
[1651142136.345397][5391:5391] CHIP:DMG: IM WH moving to [Uninitialized]
[1651142136.345416][5391:5391] CHIP:DMG: All ReadHandler-s are clean, clear GlobalDirtySet
[1651142136.345490][5391:5391] CHIP:BLE: BleConnectionDelegate::CancelConnection is not implemented.
[1651142136.345780][5391:5391] CHIP:DL: writing settings to file (/tmp/chip_counters.ini-87eETK)
[1651142136.346540][5391:5391] CHIP:DL: renamed tmp file to file (/tmp/chip_counters.ini)
[1651142136.346616][5391:5391] CHIP:DL: NVS set: chip-counters/total-operational-hours = 0 (0x0)
[1651142136.346645][5391:5391] CHIP:DL: Inet Layer shutdown
[1651142136.346666][5391:5391] CHIP:DL: BLE shutdown
[1651142136.346690][5391:5391] CHIP:DL: System Layer shutdown
So I am closing this ticket.


Links incorrectly receive markup

I have seen that "marked" parses Markdown within links. This should not happen.
Here is my example:
var link = 'https://www.nike.com/events-registration/event?id=6245&languageLocale=de_de&cp=EUNS_KW_DE_&s_kwcid=AL!2799!3!46005237943!b!!g!!womens%20running';

var options =  {
  renderer: new marked.Renderer(),
  gfm: false,
  tables: false,
  breaks: false,
  pedantic: false,
  sanitize: true,
  smartLists: false,
  smartypants: false
};

var output = marked(link, options);

The output is:

https://www.nike.com/events-registration/event?id=6245&languageLocale=dede&cp=EUNS_KW_DE&s_kwcid=AL!2799!3!46005237943!b!!g!!womens%20running

As you can see, the languageLocale=de_de&cp has been turned into languageLocale=dede&cp, so de_de became dede, which is wrong.

You could surround the link with <http://angle.brackets> or enable gfm for linkifying bare URLs.

#984


Have you tested ELMo on Chinese?

If you have conducted experiments on Chinese, how is the test perplexity?

I haven't run a Chinese only model, although others have.  Potentially relevant citations:

Polyglot Contextual Representations Improve Crosslingual Transfer https://arxiv.org/pdf/1902.09697.pdf
Pretrained ELMo for Many Languages: https://github.com/HIT-SCIR/ELMoForManyLangs


crashes if there is a slapper plugin

This plugin will crash if there are other slapper plugins

can u send me an error?


Fine tune layer selector

This PR fixes #10093 and fixes #10109 on builder side.

It depends on https://github.com/CartoDB/cartodb.js/pull/1447
CR @xavijam

LGTM! 🇪🇸


Incorrect dolbyVoice default value in ConferenceCreateParameters.

Documentation says that dolbyVoice by default is set to true, but in FlutterSDK it's false.

In the code we have to follow the documentation. Ie. the default should be true.

Documentation: https://api-references.dolby.io/comms-sdk-flutter/dolbyio_comms_sdk_flutter/ConferenceCreateParameters-class.html


makemkv: 1.10.6 -> 1.10.7

Motivation for this change
New version of makemkv, old version's 60-day key has expired
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

The commit seems to build, even on the failing build server. This tooks like a build server issue to me:
The command "./maintainers/scripts/travis-nox-review-pr.sh nixpkgs-verify nixpkgs-manual nixpkgs-tarball nixpkgs-unstable" exited with 1.


[request] Callback on emit complete.

Hello, would it be possible to add an callback when the emission has completed?
So basically when the lifetime of the emitter has ended.
I would like to do cleanup of stuff when I have emitters that only play once.
Just destroying the emitter is not enough for me.
Currently I have to set a timeout for the lifetime of the emitter to do the cleanup but I assume that you know in the emitter when it is done emitting since you also added playOnceAndDestroy.

Added in version 2.1.8

Sweet, thanks a lot! 👍


Patrol v2.0.1 clearPackageData "true" doesn't work

Steps to reproduce
Hi Patrol!
Nice upgrade with patrol v2! I love the test bundling feature.
But I seem to have a problem getting "clearPackageData" to work.
I am currently only testing Android builds, and have added this line in my app-specific build.gradle file during my upgrade to Patrol v2:

Do you have any idea why this isn't working? I would like to have complete isolation between my tests so that I don't have to start some of my tests by logging out.
I have 2 "_test.dart" files and the app is restarting before running each test file, but does not clear the app data as if I went into "Settings" - "Apps" - found my app and cleared it manually.
Have I misunderstood anything? Or am I missing anything.
Thank you!
Actual results
clearPackageData not working
Logs

Logs
No logs for this issue

Patrol version

Patrol Doctor output

Patrol Doctor output
You're using Patrol CLI 2.0, which has breaking changes.
Read the migration guide at https://patrol.leancode.co/v2.
Disable this warning by setting the PATROL_MIGRATED environment variable.

Patrol CLI version: 2.0.1
Program adb found in C:\Users\BenjaminMejbomBerndt\AppData\Local\Android\Sdk\platform-tools\adb.exe
Env var $ANDROID_HOME set to C:\Users\BenjaminMejbomBerndt\AppData\Local\Android\Sdk

Flutter Doctor output

Flutter Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 3.10.3, on Microsoft Windows [Version 10.0.22621.1848], locale en-DK)
[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
[√] Chrome - develop for the web
[!] Visual Studio - develop for Windows (Visual Studio Community 2022 17.4.2)
    X Visual Studio is missing necessary components. Please re-run the Visual Studio installer for the "Desktop development with C++" workload, and include these components:
        MSVC v142 - VS 2019 C++ x64/x86 build tools
         - If there are multiple build tool versions available, install the latest
        C++ CMake tools for Windows
        Windows 10 SDK
[√] Android Studio (version 2022.1)
[√] VS Code (version 1.79.1)
[√] Connected device (4 available)
[√] Network resources

! Doctor found issues in 1 category.

Hi @benjamin-inspectly, sorry for the problems.
It's strange that it doesn't work. How are you running the tests (patrol test or some cloud device farm)? What device and Android version? It'd also be helpful if you attached a log file from adb after running your tests:
adb logcat -d > logcat.txt

BTW, I see you're using patrol_cli v2.0.1, which requires at least patrol v2.0.1. I recommend always using the latest versions:)

Since this issue is old and has no new activity, I'm going to close it. Please create a new issue if you experience a similar problem.


Docs !== Documentation

This is an unfortunate story of a poorly named directory and boy that thought he would automate doc generation. That never happened. The content in docs/* is just examples programs. I'd like to figure out a way to mechanically link all the example programs to their respective API docs page (ie. the wiki content)

This is done


Change submission logic for regular form posts

If using onSubmit, it is only called when the form is valid. If using an action instead, the form can be submitted at any time regardless of the validity. This is not consistent.

An alternative suggestion would be that you could expose the field state or validity via the onSubmit or onBeforeSubmit callback so we can make a decision ourselves. As it stands currently, there's no way to stop a form submission based on its validity unless we connect to the store ourselves.

I'll have to give this a tiny bit more thought. Are there use-cases where developers expect actions.submit(model) to force-submit the form, no matter what?

So it seems that currently onSubmit is always ignored if the form is valid, and action is always executed no matter what.
Maybe it would be better to move some things around, here's some suggestions:

onBeforeSubmit could pass fieldState along with the event to the caller, this would be a good place to make a decision on whether we want to submit or not (we could check the form state ourselves and preventDefault if we wish).
before calling onSubmit we could check defaultPrevented, and if it's true it could bail out of onSubmit for consistency with the action prop.
There could be a prop on the form preventInvalidSubmit which would default to true and would prevent both mechanisms by default.
if preventInvalidSubmit is false, onSubmit would now get executed on an invalid form if not handled/cancelled in onBeforeSubmit

The first option seems like the simplest way to go - hopefully, we can avoid adding extra props. In the future, we can consider something like actions.forceSubmit(model).


Introduce message priority for Remote layer

Make it possible to give some messages priority for the Remote layer.
E.g. Gossip messages.
This can probably be solved with a priority queue, or an approach similar to system vs user messages for the mailbox.
The idea is to make gossip timeouts less frequent when a system is under heavy load

It would be fine to work on the priority, but as per the present proto.actor code also, we can configure the gossip (system level messages) intervals and timeouts.
Also another disadvantage is if we put a long gossip interval, other cluster members would be in an inconsistent state regarding the information of the grains/actors.
How can we tackle this?

Done


Use docker-zulip latest image

Previously, we were using a fork of docker-zulip to base our image on Ubuntu 20.04. The open upstream PR has been merged in and we can use that as a base image. The deploy time goes down from 34 minutes to 8 minutes with this change.

@wendorf yes! we're gonna delete our fork 🎉


Add OpenJ9 aarch64 JDK11 builds

Awaiting merging of https://github.com/ibmruntimes/openj9-openjdk-jdk11/pull/149 and https://github.com/eclipse/openj9/pull/5321 but it's close.

@karianna I'm assuming this doesn't need to be approved via the TSC? Initial builds may be without a fully working JIT and will therefore operate in -Xint mode by default but it'll be a starting point :-)

yeah this is pretty minor

My bad - this is a dup of https://github.com/AdoptOpenJDK/openjdk-build/issues/966


Loops?

I read your code and would need to do a lot to get to a state where I can edit it.
Are you planning on implementing loops? Like, running GET 20 times (without copy-pasting it 20 times in the script)?
Now that would be an awesome next step!

Yes actually, I am working on a looping system right now. It will be the
next commit.
On May 27, 2015 7:15 PM, "Nitin Khanna"<EMAIL_ADDRESS>wrote:

I read your code and would need to do a lot to get to a state where I can
edit it.
Are you planning on implementing loops? Like, running GET 20 times
(without copy-pasting it 20 times in the script)?
Now that would be an awesome next step!
—
Reply to this email directly or view it on GitHub
https://github.com/Max00355/HTTPLang/issues/5.

Yippie!!! Less work for me!  (boy, am I lazy!) :stuck_out_tongue_winking_eye:

I still hope that you make some contribution though, that'd be cool :)

I'm still reading the code. Will definitely poke around and shoot a pull request if/when I have something for you... This is a really, really cool thing you've done here :)

Cool, I look forward to seeing what you have to contribute. I am planning
on working on this for a while thanks to the reactions I've gotten. I'm
excited about where this might go :)
On May 27, 2015 8:42 PM, "Nitin Khanna"<EMAIL_ADDRESS>wrote:

I'm still reading the code. Will definitely poke around and shoot a pull
request if/when I have something for you... This is a really, really cool
thing you've done here :)
—
Reply to this email directly or view it on GitHub
https://github.com/Max00355/HTTPLang/issues/5#issuecomment-106125755.

Loops will be included in this weekend's commit. Stay tuned.

Nevermind! I had about an hour of spare time and I have implemented basic loops. Hopefully it can be expaned upon and improved in the future. Nested loops are not supported yet in this current version. I have also added a version number which is good.

:+1:


Create cuivehari

COMSATS university Islamabad

@HazenDeveloper lib/domains/pk/edu/cuivehari: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@HazenDeveloper Thank you for your patience while waiting for a review and processing your request. Pull request merged.


add contributing.md with link to CLA

Github shows a banner asking people who open pull reqs to read this, so might as well use that.

CLA
github docs on contributing.md

You mean CONTRIBUTING.md (case matters apparently):

In the file name field, type CONTRIBUTING or CONTRIBUTING.md (with all caps!)
(https://help.github.com/articles/setting-guidelines-for-repository-contributors/)

Good idea. I think we should add that to all repos in ARMmbed.

(all public ones, that is)

:cry: all caps

:sob: OH WELL, IT'LL HAVE TO DO.

Call me oldschool, but for files like this I prefer all-caps... helps visually distinguish the boilerplate in all repos (LICENSE, CONTRIBUTING, README) from the content.

Also worth mentioning clahub, which adds a commit status for whether people have agreed to the CLA – we use it for https://github.com/coggle/coggle-translations, has worked really well so far.


Correctedfd

Correct finite differences.

I'm closing this PR, because this functionality is working well in the 0.6 prerelease. We don't need to backport it to the 0.5 codebase.


Considering adding stylelint-declaration-use-variable plugin

https://www.npmjs.com/package/stylelint-declaration-use-variable

After reviewing the documentation for the plugin, I don't think we want to add it.
While I am pro variables, dictating in what circumstances they should be used doesn't seem like the right way to go about it. Variables should emerge as duplication is discovered.


Skip and Text Log

We need a skip function. Reader clicks on skip button to make the text fast-foward and click skip again to stop.
We also need a Text log for reader to keep track of story event if they forget previous text.
These two are essential for a Visual Novel.
I see that you are working on develop branch. I want to take time making a pull request but it would be kind of waste if you are gonna release a major update.
Is v2 ready to run for sample?

Hi there! Actually a skip functionality was added in the develop branch, it works by pressing the S key but doesn't have a button which would of course be really helpful! Specially when playing from mobile devices.
A text log is also a great idea, it would be an awesome addition!
The v2 is almost ready, the develop branch is all the code that will eventually become v2 so any pull requests should go there. There are major changes on the overall architecture between v2 and the versions before so I recommend you read the Contribution Guidelines that has instructions on setting it up and building it, also if you need any help, don't doubt on asking :+1:
Thanks a lot for wanting to contribute to Monogatari! :D

I have read the contribution guidelines however one thing I really concern that is Function Spacing
I was amazed because JS is not my primary language, however this somewhat become a controversy and people decided it should be optional. I think it should be optional too because really can't stand a space there after many years familiar with other coding styles.

XD yeah, I know they are hard to get used to, I didn't do it before but I spent some time developing on something that had similar guidelines and I just couldn't shake them off so now I use them in everything haha
The problem with making them optional would be that the code would then have some mixed styles and that's not desirable :/


Try to fix as many eslint errors as possible

These are left:
  4:22  error  'jsonToXML' is not defined  no-undef

/Users/thomaschaaf/develop/github/mjml/packages/mjml-migrate/src/migrate.js
   33:3  error  The body of a for-in should be wrapped in an if statement to filter unwanted properties from the prototype                                                             guard-for-in
   33:3  error  for..in loops iterate over the entire prototype chain, which is virtually never what you want. Use Object.{keys,values,entries}, and iterate over the resulting array  no-restricted-syntax
   55:3  error  The body of a for-in should be wrapped in an if statement to filter unwanted properties from the prototype                                                             guard-for-in
   55:3  error  for..in loops iterate over the entire prototype chain, which is virtually never what you want. Use Object.{keys,values,entries}, and iterate over the resulting array  no-restricted-syntax
   64:5  error  for..in loops iterate over the entire prototype chain, which is virtually never what you want. Use Object.{keys,values,entries}, and iterate over the resulting array  no-restricted-syntax
   76:3  error  for..in loops iterate over the entire prototype chain, which is virtually never what you want. Use Object.{keys,values,entries}, and iterate over the resulting array  no-restricted-syntax
   94:3  error  The body of a for-in should be wrapped in an if statement to filter unwanted properties from the prototype                                                             guard-for-in
   94:3  error  for..in loops iterate over the entire prototype chain, which is virtually never what you want. Use Object.{keys,values,entries}, and iterate over the resulting array  no-restricted-syntax
  113:3  error  for..in loops iterate over the entire prototype chain, which is virtually never what you want. Use Object.{keys,values,entries}, and iterate over the resulting array  no-restricted-syntax```

The jsonToXML.js is incorrect.. and will not work currently I don't understand the intention so I can't fix it. You should also rewrite the code so that it doesn't use for..in loops anymore :)

Hi @thomaschaaf
I will check that asap, thanks for the pr

Hi @thomaschaaf thanks for your PR,
I just checked it quickly and the only problem i see is the functions that become static (getStyles, renderAfter). These have to remain instance methods because they are common to all components and used when processing, and on most components they need to access this.

Well with no update on this one, we can close in favor of #1134 I think ?
Thanks for this contribution anyway


Get rid of AWS SDK 2.x.x

Hello.
First of. all, thanks to all maintainers and contributors for very useful library.
Found an issue in library dependencies. Library use AWS SDK 3 aside with AWS SDK 2. AWS is going to stop development of v2 version, which it notifies about, when I start my project:
(node:125) NOTE: We are formalizing our plans to enter AWS SDK for JavaScript (v2) into maintenance mode in 2023.

Please migrate your code to use AWS SDK for JavaScript (v3).
For more information, check the migration guide at https://a.co/7PzMCcy

It's already been done in this MR: https://github.com/nestjs-packages/sqs/pull/404 but it somewhy was closed as wontfix.
Could you please review this MR and merge it, or comment if something wrong here.
Thank you.

Attached new MR. Could you review it please?
https://github.com/nestjs-packages/sqs/pull/434

Any chance this will be merged? Is lib still maintained by anyone??

up

@zoryamba check this https://github.com/ssut/nestjs-sqs


Feature-request automatic "mark not present in bouquets"

In services-list there is context-command "mark not present in bouquets". I made it automatic by following in "app/ui/main.py":

add lines at end of function "fav_paste"
gen = self.mark_not_in_bouquets()
GLib.idle_add(lambda: next(gen, False), priority=GLib.PRIORITY_LOW)

add lines at enb of function "remove_favs"
gen = self.mark_not_in_bouquets()
GLib.idle_add(lambda: next(gen, False), priority=GLib.PRIORITY_LOW)

I'm used to this behaviour from "dreamset" so I've been adding this for already several versions of demoneditor, and with them I've done bigger changes in bouquets, so it seems that it works ok. And, I do modifications on services-list filtered for only-one-satellite-at-time, so these additions are fast.
Maybe you could add this to official demoneditor, so I don't have to add it manually for every new version.

so I don't have to add it manually for every new version

That is unnecessary. Just use extension. I did it quickly for your case.

favautomarker.zip
Just unpack it into a folder:
~/DemonEditor/tools/extensions
or:
root folder of the program/extensions
If everything works out, it can be added to the repo.
I haven't tested it completely! If you have questions or suggestions for improvement, it is better to open a separate issue here.

The extension has been updated and added to the repo. Further discussion can be found here.


updated dnscrypt-proxy to 2.0.9b

This updates dnscrypt-proxy to 2.0.9b.
The significantly less memory usage is the most noteworthy change (from ~130MB to  ~30MB) on my system.
Changelog at the official repository

Whitelists have been implemented: one a name matches a pattern in the whitelist, rules from the name-based and IP-based blacklists will be bypassed. Whitelists support the same patterns as blacklists, as well as time-based rules, so that some website can be normally blocked, but accessible on specific days or times of the day.
Lists are now faster to load, and large lists require significantly less memory than before.
New options have been added to disable TLS session tickets as well as use a specific cipher suite. See the example configuration file for a recommended configuration to speed up DoH servers on ARM such as Android devices and Raspberry Pi.
The -service install command now remembers what the current directory was when the service was installed, in order to later load configuration files with relative paths.
DoH: The "Cache-Control: max-age" header is now ignored.

Maybe not a good idea to update to a beta.

It is a good idea, since this will end up in a SimpleDNSCrypt snapshot.
And more people testing the beta is great!

Okie dokie

And updated to the final version :)

@royvou thank you! :)


Preview screen blank - tokens being chewed up!

Describe the bug
I am a new user to bolt and keen to test its capabilities. I have attempted some requests, and code has been generated, but in each instance the Preview screen is blank.

Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-76smdv
Steps to reproduce
Prompt what I wanted to build
Observe files being created and code generated
Once completed, click on the Preview tab
Observe blank preview screen
Tested in new chat - same behavior
Expected behavior
Preview the front-end that has been generated based on the prompt
Screen Recording / Screenshot
No response
Platform

Windows
Chrome
Version 130.0.6723.70

Additional context
No response

Appreciate the feedback! This is a known issue and is being tracked here: #1791.


⚠ Spryr has degraded performance

In 87220be, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 13751 ms

Resolved: Spryr performance has improved in 7941568 after 7 minutes.


Add Gradle configuration example

Add Gradle configuration example for Codegen

👍

@sczyh30 Did you signed the Eclipse CLA ?

Yes I've signed the Eclipse CLA :-)

Thanks !


Added the machine's architecture to macos doctor results.

Description
Now that apple supports multiple architectures I added the architecture to the flutter doctor output to help us track down bugs related to architecture.
Related Issues
https://github.com/flutter/flutter/issues/65976
Tests
none
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

Oh I see, this isn't for a target device, it's for this output:
[✓] Flutter (Channel unknown, 1.22.0-10.0.pre.212, on Mac OS X 10.15.5 19F101, locale en-US)


fluentd metrics are not shown on Prometheus

Hello kazegusuri,
I am trying to run fluent-plugin-prometheus on k8s,  I see fluentd pod on k8s targets, It is up. but I couldn't see any metrics related docker_command_log to execute on prometheus. Please, can you help this issue?
Please find my files in below.
Thanks,
Dockerfile:
FROM fluent/fluentd:v0.12-onbuild

USER root

RUN apk add --update --virtual .build-deps \
        sudo build-base ruby-dev \
 && sudo gem install \
        fluent-plugin-rewrite-tag-filter:1.5.6 \
        fluent-plugin-parser:0.6.1 \
        fluent-plugin-prometheus:0.3.0 \
 && sudo gem sources --clear-all \
 && apk del .build-deps \
 && rm -rf /var/cache/apk/* \
           /home/fluent/.gem/ruby/2.3.0/cache/*.gem

# listen port 24224 for Fluentd forward protocol
EXPOSE 24224
# prometheus plugin expose metrics at <IP_ADDRESS>:24231/metrics
EXPOSE 24231

fluent.conf
<source>
  @type forward
</source>
<source>
  @type prometheus
</source>

<filter docker.**>
  @type prometheus
  <metric>
    name docker_command_log
    type counter
    desc total docker commands
    #key log
  </metric>
</filter>

<match docker.**>
  @type copy
  <store>
    @type stdout
  </store>
</match>

k8s-development.yaml
...
apiVersion: v1
kind: Deployment
metadata:
  name: fluentd
spec:
  template:
    metadata:
      labels:
        app: fluentd
      name: fluentd
    spec:
      containers:
      - image: myimage
        name: fluentd
        ports:
        - containerPort: 24231
          hostPort: 24231

prometheus.yml
...
scrape_configs:
  # The job name is added as a label `job=<job_name>` to any timeseries scraped from this config.
  - job_name: 'prometheus'

    # Override the global default and scrape targets from this job every 5 seconds.
    scrape_interval: 5s

    # metrics_path defaults to '/metrics'
    # scheme defaults to 'http'.

    static_configs:
         - targets: ['localhost:9090','fluentd:24231']

Hi , you have not specified the input / source .
You may refer this ===> http://docs.fluentd.org/v0.12/articles/input-plugin-overview
Thanks
Anupam

Thank you for very detailed report.
I tried to reproduce the issue with you configuration and dockerfile, but it works fine.
Judging from your fluent.conf, do you refer this blog post right?
In the post,  run following command to run a docker container: (wrong)
sudo docker run -ti --name test --log-driver=fluentd ubuntu /bin/bash

The command may start container successfully and the logs are sent to Fluentd, but the message tag is different from one of that time.
Now we need to specify fluentd tag in the command-line: (right)
sudo docker run -ti --name test --log-driver=fluentd --log-opt tag="docker.{{.ID}}" ubuntu /bin/bash

Without --logopt, Fluentd receives invalid tag from other containers then logs something like this:
2017-07-01 16:33:41 +0000 [warn]: no patterns matched tag="347176804a85"

Thank you for the reply. Yes, I referred the blog, but I don't use the command to run a Docker container. I use k8s. I mentioned above (k8s-development.yaml). My actual problem is related Prometheus metric. I couldn't see docker_command_log metric.  Please find the screenshot in below.

Hmm, I don't have a k8s environment to confirm that.
I want to know with what tag each containers send logs to fluentd. Could you test with following config and run some command inside container on k8s?
<match **>
  @type stdout
</match>

I close this issue because not updated.
Please feel free to reopen if you have a update or comment.


fix(node-sdk): Put optional params into an object.

Closing as #41 is a superset of the changes proposed here


Add Type annotations developer guideline

Summary of changes
Add Type annotations developer guideline
CC @abravalheri feel free to wordsmith. I figured these things are probably better documented with sources than left in PR discussions.
Pull Request Checklist

[x] Changes have tests (N/A)
[x] News fragment added in newsfragments/. (N/A)
(See documentation for details)

@abravalheri Updated and added a few more details !

Thank you very much.


Add diagram with the status workflow

Coverage remained the same at 100.0% when pulling 2c389a925eadb7e8413f83ae3aaf810e144bbdc9 on ivanka-jakimchuk:master into 0ea9e90775a3161b2a271a58eb9cc87e0bc418f9 on openprocurement:master.


Switch to pioarduino platform and add proper solo1 support

Description:

Switch to pioarduino platform https://github.com/pioarduino/platform-espressif32
Add proper Solo1 support (using same Arduino core 3.0.4 and ESP-IDF 5.1.4 as the other variants)

Checklist:

[x] The pull request is done against the latest master branch
[x] Only relevant files were touched
[x] Only one feature/fix was added per PR and the code change compiles without warnings
[x] The code change is tested and works
[x] I accept the CLA.

You are fast :-)  You should remove the extra Ethernet lib. Arduino has its own well working one which does not have SPI conflicts as the universal Arduino Ethernet lib.

You should remove the extra Ethernet lib. Arduino has its own well working one which does not have SPI conflicts as the universal Arduino Ethernet lib.

Fully agree, but will take some more effort to remove our dependencies on the old lib


[tomcat:6.0.45-jre7] maxInactiveInterval not converted to seconds

Hi,
in the 6 versions of the image, the session-timeout of web.xml that is meant to be in minutes, is not converted to seconds in maxInactiveInterval.
It works on other image versions, where 30 minutes in the web.xml sets maxInactiveInterval value to 1800.

This looks like an configuration problem and is not really a problem with the images.
I can't see where maxInactiveInterval take a values in minutes in tomcat 6, 7, or 8, but only in seconds.  The only difference between the versions being a defaul value of 1800 seconds for 7 and 8, where 6 only has 60 seconds.

Hi,
the maxInactiveInterval should update its value according to  in the web.xml.
So according to this configuration of tomcat 7 :
tomcat:
  ports:
    - 8080:8080
    - 6789:6789/tcp
    - 6789:6789/udp
    - 6788:6788/udp
    - 6788:6788/tcp
  image: tomcat:7-jre7
  environment:
    - CATALINA_OPTS=-Dcom.sun.management.jmxremote -Dcom.sun.management.jmxremote.rmi.port=6788 -Dcom.sun.management.jmxremote.port=6789 -Dcom.sun.management.jmxremote.ssl=false -Dcom.sun.management.jmxremote.authenticate=false

After a docker-compose up
$ docker exec -ti d5799f3dce2c grep "session-timeout" /usr/local/tomcat/conf/web.xml
$ <session-timeout>30</session-timeout>

And the maxInactiveInterval equals 1800 (30*60seconds)
And according to this configuration of tomcat 6 :
tomcat:
  ports:
    - 8080:8080
    - 6789:6789/tcp
    - 6789:6789/udp
    - 6788:6788/udp
    - 6788:6788/tcp
  image: tomcat:6-jre7
  environment:
    - CATALINA_OPTS=-Dcom.sun.management.jmxremote -Dcom.sun.management.jmxremote.rmi.port=6788 -Dcom.sun.management.jmxremote.port=6789 -Dcom.sun.management.jmxremote.ssl=false -Dcom.sun.management.jmxremote.authenticate=false

After a docker-compose up
$ docker exec -ti 8ca18cda9bc8 grep "session-timeout" /usr/local/tomcat/conf/web.xml
$ <session-timeout>30</session-timeout>

And the maxInactiveInterval equals 30.
I tried the standard image of cloudesire/tomcat:6.0-jre7 and the maxInactiveInterval is well set to 1800, with a session-timeout of 30.


Jaeger implementation with Istio Telemetry V2 compmnent

Exploring Jaeger implementation with Istio Telemetry V2 and with Telemetry Mixer being deprecated and leads on the implementation, challenges would really help.

This should really be discussed in the Istio community - I see you have already asked the question there https://github.com/istio/istio/issues/25198 so will close this.


password creation criteria

We don't have any criteria for password creation (other than two field matching with each other).
We should enforce some criteria (length, complexity. etc.)

this may be an artifact of the old build.
Do we need to encrypt the signing key?
I will investigate further on this issue


Render reports to PDF

[x] Closes #319 .
[x] I am familiar with the contributing guidelines.
[ ] Tests added.
[ ] Updates entries to docs/source/api.rst for API changes.
[ ] Adds descriptions to appropriate "what's new" file in docs/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
[ ] Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

an example for the current code
test_output.pdf

Wow! That's great.

Right now, I've basically copied the HTML report. In the future, we'll probably want to make the two pretty different like including most plots in an appendix and condense most information in the body text/tables


No such file or directory    57 | #include "cereal/cereal.hpp"

F:/openfhe-development-main/src/core/include/utils/serializable.h:57:10: fatal error: cereal/cereal.hpp: No such file or directory
57 | #include "cereal/cereal.hpp"

I've encountered the same problem. How did you solve it?

I have encountered same issue with 1.2.0. Any idea how to fix it ?
/src/core/include/utils/serializable.h:60:10: fatal error: cereal/cereal.hpp: No such file or directory    60 | #include "cereal/cereal.hpp"       |          ^~~~~~~~~~~~~~~~~~~


[#6478] Update MongoPlugin for Reactive Streams

#6478

Codecov Report

Merging #6479 into master will decrease coverage by 0.02%.
The diff coverage is 1.49%.

@@            Coverage Diff             @@
##           master    #6479      +/-   ##
==========================================
- Coverage   39.54%   39.51%   -0.03%
==========================================
  Files        3083     3084       +1
  Lines       91953    92020      +67
  Branches    11886    11899      +13
==========================================
+ Hits        36359    36361       +2
- Misses      52586    52652      +66
+ Partials     3008     3007       -1

Impacted Files
Coverage Δ

...avercorp/pinpoint/plugin/mongo/MongoConstants.java
0% <ø> (ø)
:arrow_up:

...plugin/mongo/interceptor/PublisherInterceptor.java
0% <0%> (ø)

...in/mongo/interceptor/MongoRSessionInterceptor.java
0% <0%> (ø)
:arrow_up:

...m/navercorp/pinpoint/plugin/mongo/MongoPlugin.java
0% <0%> (ø)
:arrow_up:

.../mongo/interceptor/MongoCUDSessionInterceptor.java
0% <0%> (ø)
:arrow_up:

...rcorp/pinpoint/plugin/mongo/MongoTypeProvider.java
100% <100%> (ø)
:arrow_up:

...vercorp/pinpoint/rpc/packet/ClientClosePacket.java
55.55% <0%> (-11.12%)
:arrow_down:

...navercorp/pinpoint/rpc/common/SocketStateCode.java
82.92% <0%> (-2.44%)
:arrow_down:

...om/navercorp/pinpoint/rpc/codec/PacketDecoder.java
57.44% <0%> (-2.13%)
:arrow_down:

...cluster/zookeeper/ZookeeperClusterDataManager.java
52.9% <0%> (-1.94%)
:arrow_down:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14fea7e...e44e971. Read the comment docs.


TIFF Writer example does not work

Description
https://tomographicimaging.github.io/CIL/v24.0.0/io/
Example is
writer = TIFFWriter(file_name = '/path/to/folder', compression='uint8')

writer.write(original_data)

But 'write' doesn't take arguments

Environment

import cil, sys
print(cil.version.version, cil.version.commit_hash, sys.version, sys.platform)

Also some render issues


[Obsolete] MONDO_0015881  'gastroesophageal tumor'

Mondo term (ID and Label)
MONDO_0015881  'gastroesophageal tumor'
Reason for deprecation
We renamed this term from 'rare gastroesophageal tumor' to  'gastroesophageal tumor' (see #254). @ana-rath-orphanet we were wondering what the justification is for having this type of tumor class? Ideally, we'll have tumor types linked to Uberon terms, but Uberon only has UBERON:0007650 esophagogastric junction. The children of MONDO_0015881  'gastroesophageal tumor' are

'carcinoma of esophagus'
'esophageal neuroendocrine tumor'
'rare epithelial tumor of stomach'

so we couldn't use that Uberon term in the logical definition for MONDO_0015881  'gastroesophageal tumor'.
We think the best approach may be to obsolete MONDO_0015881  'gastroesophageal tumor' and reclassify MONDO_0018972 'rare epithelial tumor of stomach'
Suggested term to consider
MONDO_0021223 'digestive system neoplasm' (?)

related to #1750 https://github.com/monarch-initiative/mondo/pull/1750


[WIP] Adding a geom package

This is WIP!
I started developing a geom package for flame. It provides shapes and functions for geometric operations.
Since there is no extension functions in Dart, we don't take advantage of existing classes, like Rect: everything is re-created.
This classes use the Position class, but they are immutable. Position is not (for performance reasons).
I'm still deciding what is better. Maybe have two classes, because I could not figure out a way to make a class both mutable and immutable in Dart as well.
Probably would also like to add another breaking change to move Position inside the geom class, make rename it to Point.
For now this just adds the new files for review and ideas. Still figuring it out.

Will migrate this to a flame_geom package.

I moved all this code to a new package flame_geom, following in line with extract things to separated modules in flame.
I will close this issue for now, please head to the new repo for more details.


BUG: Fix csv_read bugs when using empty input. GH10467 & GH10413

closes #10413
closes #10467

pls add a whatsnew note (you can put both issues in a single entry)

@jreback - build is green.
Let me know if you'd like me to squash the commits or if you want a whatsnew note for the last commit.

Hi @jreback - just to clarify what's required. Are you happy to merge this if I add some extra tests to explicitly verify different index_col types (i.e. str, int, list of str, list of int)?

@santegoeds yes, just want to try to cover the bases on tests.

@jreback, build passing again.  Is this in line with your expectations?

very nice
comprehensive! thanks


Start using Waffle.io for issue management

More of a discussion for the collaborators — any interest in using Waffle.io for managing issues? It might help to improve workflow given there are a few of us now. I'm using it already to flag issues I want to work on in the immediate future. See: https://waffle.io/masayuki0812/c3

Closing for inactivity


Updated chart with new best practice labels

This PR only updates the template with new labels without changing any functionallity

See #1152


Extreme lag on client side with magic installed

With magic installed, whenever someone gets near a mob, their client will freeze for a solid 10 seconds, causing them to instantly die
This happens no matter how good their computer is
No errors appear in console, this is only a client side issue

I don't think that has anything to do with Magic (unless maybe you are talking about magic mobs you have spawned).
Otherwise there is nothing magic does to vanilla mobs, nor anything I can even think of you could do to a vanilla mob to make it lag a client, even if you tried.
Please remove the plugin and see if the problem persists.

Please let me know if you still think this is Magic's fault.


added myself

added my info for contributor

added my info for contributor

added my info for contributor

hey @Javeria-Asif,
there are too many changes in your submitted contribution,
dont do any changes to other files, use git, instead of uploading files,
watch this video Youtube and follow the steps...


Custom inspection API?

From observablehq/notebook#210:

It’d be need to have an equivalent to Node’s custom util.inspect hook.

Would this API enable others to build in-browser editors for notebooks, like what's currently available on the Observable beta?

Related https://observablehq.com/@mootari/custom-inspectors.


More granular control of suggestions box

We need a lot more granular control over the suggestions box.  So it is now wrapped in a container with access to the various standard container variables.
The previous suggestionsBoxDecoration has been removed (and integrated into the new container) as its redundant.
TBH, the outer wrapping Material/elevation is also not ideal and should be part of this new container, but I left it there so as not to break peoples integrations too much

May I be a little greedy and ask that you merge this into one coherent commit? For the commit message, pleae copy the PR description, rather than just "Update chips_input.dart". Thank you.

@nlfiedler I have a new version with blur capabilities on the way in just a few minutes


More function supports like fftfreq

Thank you for this great crate!
Do you have any plan to extend the functions like fftfreq and fftshift? It would be better to add more functions like what numpy.fft did. For example, the fftfreq can be helpful in the cases of drawing the frequency-amplitude curve. I have to write it everywhere if I need it right now. If it is approved, I can help to do it.

I've never heard of this. Do you have a link to a wikipedia article or some other resource I can check out?

I've never heard of this. Do you have a link to a wikipedia article or some other resource I can check out?

You can find the function in "https://numpy.org/doc/stable/reference/generated/numpy.fft.fftfreq.html" and its source Python code. It is very simply and just to generate the frequencies of "k/(N*T), k=0, 1, 2...N - 1" which is the sampled frequencies. It could be helpful to plot the frequency-amplitude figure.


Update to reflect fact that Essentials is now included by default in our Templates

I did a call with a customer using Xamarin for the first time, going through his pain points.
And he pointed out that our Essentials getting started instructions point out code changes that are already there, in apps created with the latest templates, which include Essentials.
Also, the code in the templates for OnRequestPermissionsResult is slightly different than what's in the docs here - it's a benign difference, but made the experience more confusing.
Anyway, we should update the doc to make clear that normally these steps aren't needed in most cases, for new projects created with the most recent Forms templates.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 78e6dee8-1182-bf1e-fd3a-e8d1aecc094a
Version Independent ID: 81202c69-317a-f0fa-7324-5316f7c1ceb7
Content: Get Started with Xamarin.Essentials - Xamarin
Content Source: docs/essentials/get-started.md
Product: xamarin
Technology: xamarin-essentials
GitHub Login: @jamesmontemagno
Microsoft Alias: jamont

Looks like this has been updated in the docs.


Manually trigger dubbo resource recycling

What is the purpose of the change
Manually trigger dubbo resource recycling
see more detail from #7693
Brief changelog
Verifying this change

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #7694 (27b6475) into master (2201510) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #7694      +/-   ##
============================================
- Coverage     59.18%   59.17%   -0.02%
+ Complexity      529      528       -1
============================================
  Files          1076     1076
  Lines         43465    43540      +75
  Branches       6355     6363       +8
============================================
+ Hits          25726    25764      +38
- Misses        14900    14912      +12
- Partials       2839     2864      +25

Impacted Files
Coverage Δ
Complexity Δ

...tadata/DynamicConfigurationServiceNameMapping.java
47.36% <0.00%> (-36.85%)
0.00% <0.00%> (ø%)

...nfig/configcenter/nop/NopDynamicConfiguration.java
75.00% <0.00%> (-12.50%)
0.00% <0.00%> (ø%)

...in/java/org/apache/dubbo/common/utils/JVMUtil.java
81.13% <0.00%> (-11.33%)
0.00% <0.00%> (ø%)

...apache/dubbo/registry/retry/AbstractRetryTask.java
47.22% <0.00%> (-5.56%)
0.00% <0.00%> (ø%)

.../metadata/definition/ServiceDefinitionBuilder.java
86.48% <0.00%> (-4.43%)
0.00% <0.00%> (ø%)

.../rpc/protocol/dubbo/LazyConnectExchangeClient.java
53.84% <0.00%> (-4.40%)
0.00% <0.00%> (ø%)

...bo/registry/client/migration/MigrationInvoker.java
28.57% <0.00%> (-4.17%)
0.00% <0.00%> (ø%)

.../main/java/org/apache/dubbo/qos/server/Server.java
75.00% <0.00%> (-4.17%)
0.00% <0.00%> (ø%)

...e/dubbo/registry/integration/DynamicDirectory.java
63.36% <0.00%> (-3.97%)
0.00% <0.00%> (ø%)

...apache/dubbo/rpc/cluster/support/ClusterUtils.java
66.03% <0.00%> (-3.78%)
0.00% <0.00%> (ø%)

... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2201510...27b6475. Read the comment docs.


Move Family Members to top section of family plan

Currently, adding Family Members to a plan is done through the Children / Pets section.
Remove the Children and Pets sections as well as the Walkthrough and Manage section.

List family members and pets below the Plan Name and provide provide an Add button as shown in the wireframes
https://xd.adobe.com/view/158c8bc4-5ef2-47dd-90c0-ba3c508e4d62-40df/screen/0eb324ee-9410-4607-a623-d921af922917
We won't have the option to add from contacts yet so just focus on manual entry for person and pet
https://xd.adobe.com/view/158c8bc4-5ef2-47dd-90c0-ba3c508e4d62-40df/screen/62ffb8d9-522f-4c6c-8bb0-925a5cd3c462

I labelled this as good first issue but beware that this might be a little more advanced than your typical first issue, unless you already have a good working knowledge of Vue


[FEATURE] Adjust the priority of experiments in the queue

🚀 Feature
When I have several experiments in the queue, I hope to change the priority of a particular experiment in the queue to achieve a 'jump the queue' effect.
Motivation
For example, I currently have 3 experiments in the queue. I want to bring the last experiment to the front. The current approach is to delete the first two experiments and then re-add them to the queue.

If I have many experiments in my queue, this operation is very tedious. Therefore, I want to use a simpler method to adjust the priority of experiments in the queue.

@haqishen this is unfortunately quite complicated to implement, so not sure we will try to add it anytime soon.


Add extensions list in the website

Reason/Context
As part of the "MVP integration of extensions catalog with AsyncAPI tools" mentorship program (detailed at https://github.com/asyncapi/extensions-catalog/issues/78), We would like to render these extensions in the website.
We want to add a new section, possibly under the "specification" section on the website, as shown in the provided image.
Additionally, we will create a pipeline to automatically update extensions website according to changes in the extension-catalog, which can be found at https://github.com/asyncapi/extensions-catalog". In other words,  pushing extensions definitions from the extentions catalog to this repo and render these as a list whenever some change is introduced.

No objections from my side, we do it already with:

spec repo push updates to Specification section
generator repo push updates to Generator section
soon cli repo will push updates to CLI section

so, stuff from extension-catalog should also be available here, just like in the future, bindings specs should be here.

@derberg are we going up with this issue?

yeah, but there first need to be done some work in extensions-catalog repo, a PR from @Sihamtahi, we need someone to pick up the work she started and cleanup there first

Can I try my hands on it?

be my guest, this is a PR than needs to be picked up https://github.com/asyncapi/extensions-catalog/pull/112 and there are already a lot of comments that should be good to guide you on what is missing.
of course I'm all yours if ya need help

@derberg Is this issue still open?

at the moment it is blocked by other issues

hey maintainers, just wanted to know if this issue is now up for execution

Hey @akkshitgupta currently I am working on it under AsyncAPI Mentorship Program

closing this as the PR has been raised and merged


fix: default symbols highlighting

Replace obsolete treesitter highlighting groups with the new highlighting groups.

This is definitely a bug fix worth merging! Fix #185

Fixed already! Thanks for the PR though


Gzip tools

Add basic gunzip & gzip tools

Codecov Report

Merging #94 (8d3f081) into main (dfcf469) will decrease coverage by 0.61%.
The diff coverage is 36.66%.

@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   68.05%   67.44%   -0.62%
==========================================
  Files         114      115       +1
  Lines        4561     4650      +89
==========================================
+ Hits         3104     3136      +32
- Misses       1457     1514      +57

Impacted Files
Coverage Δ

sources/libs/brutal/codec/gzip/gzip.c
57.42% <22.91%> (-31.47%)
:arrow_down:

sources/libs/brutal/hash/crc32.c
52.38% <52.38%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfcf469...8d3f081. Read the comment docs.


drain / uncordon for nodes

currently we just have delete for nodes, we should have proper action representations for nodes

[x] cordon/uncordon
[ ] ~drain~

Hey @GuessWhoSamFoo , you want me to pick this up? I'd like to get it in to the 0.12 release.

sure, feel free to grab it if you'd like

Closing this as done and opening a new issue for drain.


runcon: return UResult from uumain() function

See #2464.
I don't know how to test this one, so please review with care.

I have made the suggested changes and rebased.


Extend CTU autodetection to handle monorepo builds

Monorepo builds of Clang do not have 2 repository urls in their version
string. Another parsing strategy is added to CTU autodetection to handle
this case.

This PR is replaced by #2236.


Preview doesn't works in Page Editor

Link: http://webuzo.com/demos/Monstra

I think you are using the default plugin - MarkItUp! editor.  This is a good editor if you like to edit in raw HTML, but if you want to see the page in preview mode you need to use another editor plugin - see http://monstra.org/download/plugins for choices.
I prefer the CKEditor, but at the moment you need to install from the instructions on the forum, then edit config.js:

To allow underlines comment this line:

 //      config.removeButtons = 'Underline,Subscript,Superscript';

To allow div's add this near bottom:

config.extraAllowedContent = 'div(*){*}[*]';


Consider removing CLI dev command

I think we can remove the dev command entirely. Going forward, we'll want to exercise the beacon and validator commands since those are intended to be used in production.
E2e tests can give us the functionality of the dev command.
Originally posted by @wemeetagain in https://github.com/ChainSafe/lodestar/issues/1180#issuecomment-665983603

I tend to use dev command to quickly setup devnet for trying out api or various sync experiments.
E2e tests doesn't help with that as I need to wait for justified epoch every time

Closing since it has good use cases


Modal inside camera freezes the app when its closed

Is this a bug report?
Yes

Have you read the Bugs section of the Contributing to React Native Guide?
(Write your answer here.)
No

Environment

react-native -v: 0.46.2
node -v: 6.4.0
npm -v: 3.10.3
yarn --version (if you use Yarn):

Then, specify:

Target Platform:
IOS 10.2

Development Operating System:
Mac

Build tools:
react-native-camera: 0.9.4

Steps to Reproduce

(Write your steps here:)

Inside react-native-camera add a modal and set its initial visibility to false
Now set the modal to be visible through visible prop state update. It works fine.
Now close the modal and come back to camera. The whole camera view and app freezes.

Expected Behavior

The app should not freeze.
(Write what you thought would happen.)
Actual Behavior

(Write what happened. Add screenshots!)
Reproducible Demo
import { Modal } from 'react-native'
import Camera from 'react-native-camera'

class A extends Component {
  constructor(props) {
    super(props);
    this.set.vis = false;
  }
  render() {
    return (
     <Camera
          ref={(cam) => {
            this.camera = cam;
          }}
          aspect={Camera.constants.Aspect.fill}
        >
        <Modal visible={this.state.vis}> modal content </Modal>
     </Camera>
  )
  }
}

(Paste the link to an example project and exact instructions to reproduce the issue.)

This issue tracker is for issues in the core React Native library.


Update brushing example

Background
The brushing example uses outdated shaders from v6 scatterplot and arc layers.
Change List

Rewrite brushing layers with shader module & injection

Coverage remained the same at 61.784% when pulling af7d27e507da963bd775d7b9452c28bae2590cec on x/brushing-example into a746f07248f230fa55ef63d51df0c1c3473b60d1 on master.

Coverage remained the same at 61.784% when pulling af7d27e507da963bd775d7b9452c28bae2590cec on x/brushing-example into a746f07248f230fa55ef63d51df0c1c3473b60d1 on master.


Throttling in the EventStore

Hi!
Probably this is not the best place to ask this, but I'm sure that you can point me to the right direction.
It is about throttling.
How do we prevent the EventStore to be 'abused', let's say a process starts to send an event every second, exactly the sameone.
Do we want to store as it is?
Or do we want to prevent duplications? And how can we prevent that?
Which will be the best approach to deal with this:

Query the EventStore before insering the new event searching if already exists? (let's say that in our domain that's ok).
Just insert it and will be handled when projecting the events.

Thanks!

Hello,
I may have trouble understanding your request, but some thoughts: Why is your event producer producing events with equal identity? Or are you talking more about "structural equality", whereby an instance of an event will have fields with exactly the same values as some other event already stored in the stream? Nevertheless, if you want some kind of "throttling", could you buffer & filter the events in the producer side? On the question of storing them, it should depend on the application domain. So if you consider events "duplicate", handle them so in projections.
If you really want to prevent inserting them, you could e.g. keep a projection that maintains hashes of the seen events, but that ofc incurs cost of querying the projection for each insertion (which is certainly less expensive that querying the whole underlying stream)...
public class MyEventProjection
{
	public string Id { get; set; }

	private readonly HashSet<int> hashes = new HashSet<int>();

	public IEnumerable<int> Hashes => hashes;

	public void Apply(MyEvent myEvent)
	{
		hashes.Add(myEvent.GetHashCode());
	}
}

and then upon appending to a stream, something like
var hasBeenInserted =
session.Load<MyEventProjection>("mystream")?.Hashes.Contains(myEvent.GetHashCode()) ?? false;

@jokokko, thanks a lot for that.
IN our domain, we are indeed producing events with same identity (it is a kind of long running saga), and indeed in some cases the 'payload' or event data can be the same.
Thanks for the samples!