Pypi official release

Added changes to readme.md
Twine upload

Codecov Report

Merging #34 (867d30c) into main (e79829d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage   90.22%   90.22%
=======================================
  Files          57       57
  Lines        1821     1821
=======================================
  Hits         1643     1643
  Misses        178      178

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e79829d...867d30c. Read the comment docs.


Why isn't CMAKE_BUILD_TYPE=Release included in CMAKE_ARGS?

Comment:
I recently started using the auto-defined CMAKE_ARGS environment variable for my CMake-based conda builds, as suggested in the conda-forge docs on using CMake. Not only is it convenient, but I agree with the perspective in https://github.com/conda-forge/ctng-compiler-activation-feedstock/issues/77#issuecomment-1145159371 that using shared CMake settings helps keep the conda-forge ecosystem consistent.
However, I was recently surprised to learn that CMAKE_BUILD_TYPE=Release is not set by activate-gcc.sh in this repo (https://github.com/conda-forge/staged-recipes/pull/23297). It is set by activate-clang.sh for osx builds and by activate.bat for MSVC builds on Windows. I wasn't able to find any discussion on the motivation for this inconsistency across the platforms. In fact, all I could find was a discussion that was debating setting CMAKE_BUILD_TYPE=None (#87, https://github.com/conda-forge/conda-forge.github.io/issues/1859).
Is there a particular motivation why CMAKE_BUILD_TYPE=Release is the default for osx and win builds, but not linux? If not, can I send I PR to include CMAKE_BUILD_TYPE=Release in CMAKE_ARGS?

If not, can I send I PR to include CMAKE_BUILD_TYPE=Release in CMAKE_ARGS?

Yes, please

Instead of
cmake ${CMAKE_ARGS} .

you do
cmake ${CMAKE_ARGS} -DCMAKE_BUILD_TYPE=Debug .

It's ok to specify CMAKE_BUILD_TYPE twice?
cc @robertmaynard

Why has this been done? It has started breaking CI builds for us in Arrow. The build type is per-environment setting, not something that Conda should dictate to users. For example, it is recommended to build in Debug mode for development.

Not only is it convenient, but I agree with the perspective in #77 (comment) that using shared CMake settings helps keep the conda-forge ecosystem consistent.

I think this conflates two different things:

using conda environments for general development
using conda environments in order to build conda packages for conda-forge

There really should be two different environment variables for those. For example CMAKE_ARGS and CMAKE_ARGS_FOR_CONDA_BUILD.

We could set some variables likeBUILD_TYPE conditionally on the activation being run inside of CONDA_BUILD. We already have a conditional block for this in https://github.com/conda-forge/ctng-compiler-activation-feedstock/blob/688de6d31129e584a5f164a28c50806353056c63/recipe/activate-gcc.sh#L86

It has started breaking CI builds for us in Arrow.

@pitrou I'm sorry this has caused an issue for you. I appreciate that unexpected build failures are always frustrating.

Why has this been done?

The motivation is two-fold:

To be consistent with the other conda-forge compilers: vc-feedstock and clang-compiler-activation-feedstock. These both set CMAKE_BUILD_TYPE=Release in the env var CMAKE_ARGS, so it is inconsistent for the linux builds to be the exception
To promote consistency in the builds throughout the conda-forge ecosystem

There really should be two different environment variables for those. For example CMAKE_ARGS and CMAKE_ARGS_FOR_CONDA_BUILD.

Could you please explain why the workaround noted above isn't ideal for your setup? If you know you need a specific build type, you can include it in the call to cmake, and the value set in this repository is overridden. For example, if your CI builds use cmake ${CMAKE_ARGS} -DCMAKE_BUILD_TYPE=Debug ., then they will be unaffected by what conda-forge decides to set as its default.

Could you please explain why the workaround noted above isn't ideal for your setup?

It certainly works. It's just that 1) it's more fragile (you have to make sure you use the correct parameter order in your cmake invocation) 2) the change broke things for us in a rather gratuitous way, and without warning.
Certainly, regardless of the final decision made by conda-forge, we can easily work around it... However, in general, I don't think conda/conda-forge should change compilation defaults except where necessary (such as setting the correct library search path).
A general request: please think about user experience instead of doing unexpected changes like that. Also, I would suggest looking at what other package repositories do, because it can serve as a reference for good packaging practices. If Ubuntu/Fedora/etc. don't force the default CMake build type, why would conda-forge behave differently?

(in our particular case, "broke things for us in a rather gratuitous way" implies that we had 1) to research the underlying cause of our CI issues 2) try a workaround and schedule a general CI rebuild to ensure it doesn't break something else; that's easily one or two hours lost, not to mention the annoyance of unrelated CI failures on pending PRs)


Add script to calculate throughput to pods connected to VPP

Coverage increased (+0.01%) to 76.48% when pulling 87173c12fab73fd4ce5d1527c7a8ddb50adc7156 on jmedved:master into<PHONE_NUMBER>d4863bdf7de1cf4b8a92313e2b4515 on contiv:master.


chore(ci): Parallelize generate and test jobs

We can shave ~25% off the CI execution time by running the generate and test steps in parallel.
TODO

[ ] Make "Generate" check required in the branch protection rules

Codecov Report

Merging #994 (b222880) into main (5c15536) will increase coverage by 0.30%.
The diff coverage is 52.00%.

:exclamation: Current head b222880 differs from pull request most recent head accb23c. Consider uploading reports for the commit accb23c to get more accurate results

@@            Coverage Diff             @@
##             main     #994      +/-   ##
==========================================
+ Coverage   54.80%   55.11%   +0.30%
==========================================
  Files         106      106
  Lines       11653    11701      +48
==========================================
+ Hits         6387     6449      +62
+ Misses       4732     4718      -14
  Partials      534      534

Impacted Files
Coverage Δ

internal/storage/blob/store.go
40.35% <0.00%> (-1.10%)
:arrow_down:

internal/storage/db/internal/db.go
0.00% <0.00%> (ø)

internal/storage/disk/dirwatch.go
67.18% <28.57%> (-4.75%)
:arrow_down:

internal/storage/git/store.go
53.74% <40.00%> (-0.38%)
:arrow_down:

internal/storage/index/index.go
38.61% <60.00%> (+3.05%)
:arrow_up:

internal/storage/index/schema.go
50.00% <62.50%> (+16.66%)
:arrow_up:

internal/engine/ast.go
81.22% <100.00%> (+0.37%)
:arrow_up:

internal/server/server.go
55.69% <100.00%> (ø)

internal/engine/engine.go
65.44% <0.00%> (+0.78%)
:arrow_up:

internal/storage/index/builder.go
88.26% <0.00%> (+8.93%)
:arrow_up:

... and 1 more


CB-11873: Implement ENVIRONMENT_RESOURCE_ENCRYPTION_DELETE_STARTED_STATE - to delete the DES from Azure cloud

CB-11873: Implement ENVIRONMENT_RESOURCE_ENCRYPTION_DELETE_STARTED_STATE - to delete the DES from Azure cloud

If single Resource group - delete the DES.
If multi RG - delete the DES and then delete the resource group created for DES specifically.

retest this please


Enable Travis CI

I now have Travis running on push, performing both unit tests and image tests. I've raised the image test thresholds high enough to allow all tests to pass until we can figure out how to get more consistent images between our various development machines (I will open an issue to that effect).
There is an issue where all the unit tests are not running but I will investigate that in a separate topic.

Other than fixing the image tests (which can be on this or another PR) LGTM.

I'll fix the image tests on a different branch.


Ad user defined

Do not merge.  This triggers testing on fixed to wrtVector_setupCodeTemplate and convertWrtArgToIndices.

@perrydv @paciorek For branch AD-userDefined, is it safe to close this PR, since this is now migrated into ADoak?


Correct typo in README.md

In README.md, the cargo install command incorrectly names the crate so it doesn't work. Just fixing that. :)

Thank you for fixing this @tekacs

@all-contributors please add @tekacs for code

@all-contributors please add @tekacs for code


Use 1/3rd arcsecond NED as well.

Joerd pulls in the 1/9th arcsecond NED, but this doesn't have full coverage of the USA (yet?). The 1/3rd arcsecond has some issues around the coastline, but probably better than SRTM.

Background reading:

http://nationalmap.gov/3DEP/3dep_prodserv.html

Map availability preview:

http://viewer.nationalmap.gov/basic/?basemap=b1&category=ned,nedsrc&title=3DEP View

1/9 arc sec = 1 meter pixel size.
1/3 arc second = 10 meter pixel size.

I think the 1m is a separate dataset. 1/9th arcsecond should be about 3m,
which is consistent with 1/3rd arcsecond being 10m?

Right you are:
Project-based

* 1-meter – This dataset was introduced in 2015 with limited coverage of the U.S.,
but will be expanding as new DEMs from 3DEP quality level 2 or better lidar data
are acquired. Horizontal coordinates are referenced to the Universal Transverse
Mercator projection.

* 1/9 arc-second – This dataset covers about 25 percent of the conterminous U.S.
and is produced from 3-meter or higher resolution DEMs acquired by the USGS prior
to January 2015. Horizontal coordinates are referenced to geographic coordinates
(longitude, latitude). The 1/9 arc-second dataset will no longer be updated with
newly acquired DEMs; however, it will continue to be distributed.

Tracking in #64.


relax protobuf restriction

fixes https://github.com/microsoft/onnxconverter-common/issues/265
onnx itself specifics >=3.20.2 - https://github.com/onnx/onnx/blob/main/requirements.txt#L2C17-L2C17
onnxruntime has no restriction - https://github.com/microsoft/onnxruntime/blob/main/requirements.txt.in#L5

@microsoft-github-policy-service agree company="Canva"

hi @xiaowuhu would you be able to review this PR/trigger CI checks please :)

or maybe @fatcat-z?

@matty-rose The 3.20.2 version is specified by Microsoft internal security checking and recommended version. I just approved it to see if it can pass the CI pipeline, then waiting for some days to see if there has some security filed.

/azp run common-linux-conda-CI, common-win32-conda-CI

hey @xiaowhu @tianleiwu any update on the CI/security checking?

hi @xiaowhu @tianleiwu quick ping on this, any updates/anything I can do to help move this forward?

@wenbingl, @snnn please help trigger CI.

/azp run common-linux-conda-CI, common-win32-conda-CI

/azp run common-linux-conda-CI, common-win32-conda-CI

@matty-rose  relax it in several PRs with some other maintain work.


compose: Make conversation arrow double as a go-to-conversation button.

The chevron arrow icon before the topic / dm user field now also acts as a go to conversation button. Whenever the functionality is available, the plain icon changes to look and behave like a button. The old go to conversation button on the right of the field is removed.
Fixes: #28697.
(Alternative to #28915)

Screenshots and screen captures:
When the go to conversation functionality isn't available:
Light:

Dark:

When it is available:
Light:

Dark:

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

Works for me in manual testing!

Test-deploying on chat.zulip.org.

Merged, thanks @N-Shar-ma!


docs(README): link to ponyfill explanation

https://ponyfill.com
I coined the term ponyfill, and was finally able to create a page for it.

@sindresorhus Thanks again ;)


[Bug]: Phi-3-mini does not work when using Ray

Your current environment
PyTorch version: 2.3.0+cu121
Is debug build: False
CUDA used to build PyTorch: 12.1
ROCM used to build PyTorch: N/A

OS: Fedora Linux 40 (Workstation Edition) (x86_64)
GCC version: (GCC) 14.1.1 20240701 (Red Hat 14.1.1-7)
Clang version: 18.1.6 (Fedora 18.1.6-3.fc40)
CMake version: version 3.30.0
Libc version: glibc-2.39

Python version: 3.11.9 (main, Apr 19 2024, 16:48:06) [GCC 11.2.0] (64-bit runtime)
Python platform: Linux-6.9.9-200.fc40.x86_64-x86_64-with-glibc2.39
Is CUDA available: True
CUDA runtime version: Could not collect
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration:
GPU 0: NVIDIA GeForce RTX 4090
GPU 1: NVIDIA GeForce RTX 4090

Nvidia driver version: 555.58.02
cuDNN version: Could not collect
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

CPU:
Architecture:                         x86_64
CPU op-mode(s):                       32-bit, 64-bit
Address sizes:                        48 bits physical, 48 bits virtual
Byte Order:                           Little Endian
CPU(s):                               32
On-line CPU(s) list:                  0-31
Vendor ID:                            AuthenticAMD
Model name:                           AMD Ryzen 9 7950X 16-Core Processor
CPU family:                           25
Model:                                97
Thread(s) per core:                   2
Core(s) per socket:                   16
Socket(s):                            1
Stepping:                             2
CPU(s) scaling MHz:                   51%
CPU max MHz:                          5881.0000
CPU min MHz:                          545.0000
BogoMIPS:                             8999.97
Flags:                                fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good amd_lbr_v2 nopl xtopology nonstop_tsc cpuid extd_apicid aperfmperf rapl pni pclmulqdq monitor ssse3 fma cx16 sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw ibs skinit wdt tce topoext perfctr_core perfctr_nb bpext perfctr_llc mwaitx cpb cat_l3 cdp_l3 hw_pstate ssbd mba perfmon_v2 ibrs ibpb stibp ibrs_enhanced vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid cqm rdt_a avx512f avx512dq rdseed adx smap avx512ifma clflushopt clwb avx512cd sha_ni avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local user_shstk avx512_bf16 clzero irperf xsaveerptr rdpru wbnoinvd cppc arat npt lbrv svm_lock nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold avic v_vmsave_vmload vgif x2avic v_spec_ctrl vnmi avx512vbmi umip pku ospke avx512_vbmi2 gfni vaes vpclmulqdq avx512_vnni avx512_bitalg avx512_vpopcntdq rdpid overflow_recov succor smca fsrm flush_l1d amd_lbr_pmc_freeze
Virtualization:                       AMD-V
L1d cache:                            512 KiB (16 instances)
L1i cache:                            512 KiB (16 instances)
L2 cache:                             16 MiB (16 instances)
L3 cache:                             64 MiB (2 instances)
NUMA node(s):                         1
NUMA node0 CPU(s):                    0-31
Vulnerability Gather data sampling:   Not affected
Vulnerability Itlb multihit:          Not affected
Vulnerability L1tf:                   Not affected
Vulnerability Mds:                    Not affected
Vulnerability Meltdown:               Not affected
Vulnerability Mmio stale data:        Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed:               Not affected
Vulnerability Spec rstack overflow:   Mitigation; Safe RET
Vulnerability Spec store bypass:      Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:             Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:             Mitigation; Enhanced / Automatic IBRS; IBPB conditional; STIBP always-on; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds:                  Not affected
Vulnerability Tsx async abort:        Not affected

Versions of relevant libraries:
[pip3] mypy-extensions==1.0.0
[pip3] numpy==1.26.4
[pip3] nvidia-nccl-cu12==2.20.5
[pip3] onnx==1.16.1
[pip3] onnxruntime==1.18.1
[pip3] onnxruntime-gpu==1.18.1
[pip3] sentence-transformers==3.0.1
[pip3] torch==2.3.0
[pip3] torchvision==0.18.0
[pip3] transformers==4.42.4
[pip3] triton==2.3.0
[conda] numpy                     1.26.4                   pypi_0    pypi
[conda] nvidia-nccl-cu12          2.20.5                   pypi_0    pypi
[conda] sentence-transformers     3.0.1                    pypi_0    pypi
[conda] torch                     2.3.0                    pypi_0    pypi
[conda] torchvision               0.18.0                   pypi_0    pypi
[conda] transformers              4.42.4                   pypi_0    pypi
[conda] triton                    2.3.0                    pypi_0    pypi
ROCM Version: Could not collect
Neuron SDK Version: N/A
vLLM Version: 0.5.1
vLLM Build Flags:
CUDA Archs: Not Set; ROCm: Disabled; Neuron: Disabled
GPU Topology:
GPU0    GPU1    CPU Affinity    NUMA Affinity   GPU NUMA ID
GPU0     X      PHB     0-31    0               N/A
GPU1    PHB      X      0-31    0               N/A

Legend:

  X    = Self
  SYS  = Connection traversing PCIe as well as the SMP interconnect between NUMA nodes (e.g., QPI/UPI)
  NODE = Connection traversing PCIe as well as the interconnect between PCIe Host Bridges within a NUMA node
  PHB  = Connection traversing PCIe as well as a PCIe Host Bridge (typically the CPU)
  PXB  = Connection traversing multiple PCIe bridges (without traversing the PCIe Host Bridge)
  PIX  = Connection traversing at most a single PCIe bridge
  NV#  = Connection traversing a bonded set of # NVLinks

🐛 Describe the bug
Feel free to use this gist with a minimal Jupyter notebook.
When attempting to load any Phi-3 mini/small model using the AsyncLLMEngine and specifying ray as the distributed backend, Ray throws a:
ray.exceptions.RaySystemError: System error: No module named 'transformers_modules'

A pip list in my main project shows
sentence-transformers           3.0.1
transformers                             4.42.4

although it sounds like this is likely not a bug with my project.
I highly encourage you to look at the Jupyter notebook, but for completeness, here's how I'm trying to load the model:
from vllm import AsyncEngineArgs, AsyncLLMEngine

# model source: https://huggingface.co/microsoft/Phi-3-mini-128k-instruct

# this config works
mp_args = AsyncEngineArgs(
    model="../../models/microsoft/Phi-3-mini-128k-instruct",
    trust_remote_code=True,
    distributed_executor_backend="mp",
    max_model_len=8000, # limit mem utilization for this example
    disable_sliding_window=True, # needed in order to use flash-attn
)

# this config does not work. it just sits at
#   "INFO worker.py:1779 -- Started a local Ray instance. View the dashboard at..."
# The actor dies with a `ray.exceptions.RaySystemError: System error: No module named 'transformers_modules'`
ray_args = AsyncEngineArgs(
    model="../../models/microsoft/Phi-3-mini-128k-instruct",
    trust_remote_code=True,
    max_model_len=8000,
    engine_use_ray=True,
    distributed_executor_backend="ray",
)

# engine = AsyncLLMEngine.from_engine_args(mp_args)
engine = AsyncLLMEngine.from_engine_args(ray_args)

Additionally, here's the full System log from the dead actor:
1[2024-07-20 10:54:21,234 I<PHONE_NUMBER>20] core_worker_process.cc:107: Constructing CoreWorkerProcess. pid: 193920
[2024-07-20 10:54:21,235 I<PHONE_NUMBER>20] io_service_pool.cc:35: IOServicePool is running with 1 io_service.
[2024-07-20 10:54:21,236 I<PHONE_NUMBER>20] grpc_server.cc:134: worker server started, listening on port 32921.
[2024-07-20 10:54:21,238 I<PHONE_NUMBER>20] core_worker.cc:275: Initializing worker at address: <IP_ADDRESS>:32921, worker ID 8251a92f00f8164eafa28810f113655f1ff265d396be3f6ab41f0ba5, raylet b0e273bf47f964aa3b48176dcb0fc921baec9887c10c232502e64270
[2024-07-20 10:54:21,238 I<PHONE_NUMBER>20] task_event_buffer.cc:177: Reporting task events to GCS every 1000ms.
[2024-07-20 10:54:21,239 I<PHONE_NUMBER>20] core_worker.cc:704: Adjusted worker niceness to 15
[2024-07-20 10:54:21,239 I<PHONE_NUMBER>57] core_worker.cc:643: Event stats:

Global stats: 13 total (9 active)
Queueing time: mean = 6.636 us, max = 45.069 us, min = 6.370 us, total = 86.269 us
Execution time:  mean = 21.033 us, total = 273.426 us
Event stats:
	PeriodicalRunner.RunFnPeriodically - 7 total (5 active, 1 running), Execution time: mean = 1.971 us, total = 13.800 us, Queueing time: mean = 11.414 us, max = 45.069 us, min = 34.830 us, total = 79.899 us
	CoreWorker.ExitIfParentRayletDies - 1 total (1 active), Execution time: mean = 0.000 s, total = 0.000 s, Queueing time: mean = 0.000 s, max = -0.000 s, min =<PHONE_NUMBER>.855 s, total = 0.000 s
	ray::rpc::InternalPubSubGcsService.grpc_client.GcsSubscriberCommandBatch - 1 total (1 active), Execution time: mean = 0.000 s, total = 0.000 s, Queueing time: mean = 0.000 s, max = -0.000 s, min =<PHONE_NUMBER>.855 s, total = 0.000 s
	ray::rpc::WorkerInfoGcsService.grpc_client.AddWorkerInfo - 1 total (0 active), Execution time: mean = 229.476 us, total = 229.476 us, Queueing time: mean = 0.000 s, max = -0.000 s, min =<PHONE_NUMBER>.855 s, total = 0.000 s
	ray::rpc::InternalPubSubGcsService.grpc_client.GcsSubscriberPoll - 1 total (1 active), Execution time: mean = 0.000 s, total = 0.000 s, Queueing time: mean = 0.000 s, max = -0.000 s, min =<PHONE_NUMBER>.855 s, total = 0.000 s
	ray::rpc::WorkerInfoGcsService.grpc_client.AddWorkerInfo.OnReplyReceived - 1 total (0 active), Execution time: mean = 30.150 us, total = 30.150 us, Queueing time: mean = 6.370 us, max = 6.370 us, min = 6.370 us, total = 6.370 us
	Publisher.CheckDeadSubscribers - 1 total (1 active), Execution time: mean = 0.000 s, total = 0.000 s, Queueing time: mean = 0.000 s, max = -0.000 s, min =<PHONE_NUMBER>.855 s, total = 0.000 s

-----------------
Task Event stats:

IO Service Stats:

Global stats: 4 total (1 active)
Queueing time: mean = 4.330 us, max = 12.240 us, min = 5.080 us, total = 17.320 us
Execution time:  mean = 71.079 us, total = 284.315 us
Event stats:
	PeriodicalRunner.RunFnPeriodically - 1 total (0 active), Execution time: mean = 58.839 us, total = 58.839 us, Queueing time: mean = 12.240 us, max = 12.240 us, min = 12.240 us, total = 12.240 us
	ray::rpc::TaskInfoGcsService.grpc_client.AddTaskEventData - 1 total (0 active), Execution time: mean = 218.797 us, total = 218.797 us, Queueing time: mean = 0.000 s, max = -0.000 s, min =<PHONE_NUMBER>.855 s, total = 0.000 s
	CoreWorker.deadline_timer.flush_task_events - 1 total (1 active), Execution time: mean = 0.000 s, total = 0.000 s, Queueing time: mean = 0.000 s, max = -0.000 s, min =<PHONE_NUMBER>.855 s, total = 0.000 s
	ray::rpc::TaskInfoGcsService.grpc_client.AddTaskEventData.OnReplyReceived - 1 total (0 active), Execution time: mean = 6.679 us, total = 6.679 us, Queueing time: mean = 5.080 us, max = 5.080 us, min = 5.080 us, total = 5.080 us
Other Stats:
	grpc_in_progress:0
	current number of task status events in buffer: 0
	current number of profile events in buffer: 0
	current number of dropped task attempts tracked: 0
	total task events sent: 0 MiB
	total number of task attempts sent: 0
	total number of task attempts dropped reported: 0
	total number of sent failure: 0
	num status task events dropped: 0
	num profile task events dropped: 0

[2024-07-20 10:54:21,239 I<PHONE_NUMBER>20] event.cc:234: Set ray event level to warning
[2024-07-20 10:54:21,239 I<PHONE_NUMBER>20] event.cc:342: Ray Event initialized for CORE_WORKER
[2024-07-20 10:54:21,239 I<PHONE_NUMBER>57] accessor.cc:668: Received notification for node id = b0e273bf47f964aa3b48176dcb0fc921baec9887c10c232502e64270, IsAlive = 1
[2024-07-20 10:54:21,239 I<PHONE_NUMBER>57] core_worker.cc:4735: Number of alive nodes:1
[2024-07-20 10:54:21,240 I<PHONE_NUMBER>20] direct_actor_task_submitter.cc:36: Set max pending calls to -1 for actor 926791420e82ba35c48a118601000000
[2024-07-20 10:54:21,240 I<PHONE_NUMBER>20] direct_actor_task_submitter.cc:237: Connecting to actor 926791420e82ba35c48a118601000000 at worker 8251a92f00f8164eafa28810f113655f1ff265d396be3f6ab41f0ba5
[2024-07-20 10:54:21,240 I<PHONE_NUMBER>20] core_worker.cc:3010: Creating actor: 926791420e82ba35c48a118601000000
[2024-07-20 10:54:22,071 I<PHONE_NUMBER>20] core_worker.cc:878: Exit signal received, this process will exit after all outstanding tasks have finished, exit_type=USER_ERROR, detail=Worker exits because there was an exception in the initialization method (e.g., __init__). Fix the exceptions from the initialization to resolve the issue. Exception raised from an actor init method. Traceback: The actor died because of an error raised in its creation task, ray::_AsyncLLMEngine.__init__() (pid=193920, ip=<IP_ADDRESS>, actor_id=926791420e82ba35c48a118601000000, repr=<vllm.engine.async_llm_engine._AsyncLLMEngine object at 0x7fbb4bd12650>)
  At least one of the input arguments for this task could not be computed:
ray.exceptions.RaySystemError: System error: No module named 'transformers_modules'
traceback: Traceback (most recent call last):
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
          ^^^^^^^^^^^^^^^^^^^^^
ModuleNotFoundError: No module named 'transformers_modules'
[2024-07-20 10:54:22,071 W<PHONE_NUMBER>20] direct_actor_transport.cc:189: Actor creation task finished with errors, task_id: ffffffffffffffff926791420e82ba35c48a118601000000, actor_id: 926791420e82ba35c48a118601000000, status: CreationTaskError: Exception raised from an actor init method. Traceback: The actor died because of an error raised in its creation task, ray::_AsyncLLMEngine.__init__() (pid=193920, ip=<IP_ADDRESS>, actor_id=926791420e82ba35c48a118601000000, repr=<vllm.engine.async_llm_engine._AsyncLLMEngine object at 0x7fbb4bd12650>)
  At least one of the input arguments for this task could not be computed:
ray.exceptions.RaySystemError: System error: No module named 'transformers_modules'
traceback: Traceback (most recent call last):
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
          ^^^^^^^^^^^^^^^^^^^^^
ModuleNotFoundError: No module named 'transformers_modules'
[2024-07-20 10:54:22,079 I<PHONE_NUMBER>20] core_worker.cc:856: Try killing all child processes of this worker as it exits. Child process pids:
[2024-07-20 10:54:22,080 I<PHONE_NUMBER>20] core_worker.cc:815: Disconnecting to the raylet.
[2024-07-20 10:54:22,080 I<PHONE_NUMBER>20] raylet_client.cc:161: RayletClient::Disconnect, exit_type=USER_ERROR, exit_detail=Worker exits because there was an exception in the initialization method (e.g., __init__). Fix the exceptions from the initialization to resolve the issue. Exception raised from an actor init method. Traceback: The actor died because of an error raised in its creation task, ray::_AsyncLLMEngine.__init__() (pid=193920, ip=<IP_ADDRESS>, actor_id=926791420e82ba35c48a118601000000, repr=<vllm.engine.async_llm_engine._AsyncLLMEngine object at 0x7fbb4bd12650>)
  At least one of the input arguments for this task could not be computed:
ray.exceptions.RaySystemError: System error: No module named 'transformers_modules'
traceback: Traceback (most recent call last):
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
          ^^^^^^^^^^^^^^^^^^^^^
ModuleNotFoundError: No module named 'transformers_modules', has creation_task_exception_pb_bytes=1
[2024-07-20 10:54:22,080 I<PHONE_NUMBER>20] core_worker.cc:723: Shutting down a core worker.
[2024-07-20 10:54:22,080 I<PHONE_NUMBER>20] task_event_buffer.cc:188: Shutting down TaskEventBuffer.
[2024-07-20 10:54:22,080 I<PHONE_NUMBER>78] task_event_buffer.cc:170: Task event buffer io service stopped.
[2024-07-20 10:54:22,080 I<PHONE_NUMBER>20] core_worker.cc:749: Disconnecting a GCS client.
[2024-07-20 10:54:22,080 I<PHONE_NUMBER>20] core_worker.cc:753: Waiting for joining a core worker io thread. If it hangs here, there might be deadlock or a high load in the core worker io service.
[2024-07-20 10:54:22,080 I<PHONE_NUMBER>57] core_worker.cc:986: Core worker main io service stopped.
[2024-07-20 10:54:22,084 I<PHONE_NUMBER>20] core_worker.cc:766: Core worker ready to be deallocated.
[2024-07-20 10:54:22,084 I<PHONE_NUMBER>20] core_worker_process.cc:245: Task execution loop terminated. Removing the global worker.
[2024-07-20 10:54:22,084 I<PHONE_NUMBER>20] core_worker.cc:714: Core worker is destructed
[2024-07-20 10:54:22,084 I<PHONE_NUMBER>20] task_event_buffer.cc:188: Shutting down TaskEventBuffer.
[2024-07-20 10:54:22,084 I<PHONE_NUMBER>20] core_worker_process.cc:148: Destructing CoreWorkerProcessImpl. pid: 193920
[2024-07-20 10:54:22,084 I<PHONE_NUMBER>20] io_service_pool.cc:47: IOServicePool is stopped.
[2024-07-20 10:54:22,239 I<PHONE_NUMBER>20] stats.h:120: Stats module has shutdown.

Also, thank you guys for such a great library. Its very easy and fun to use and bugs like this are few and far between :smile:
Edit: I've also tried this with 0.5.2 and the 0.5.3 prerelease per @rkooo567 's question

does distributed_executor_backend="mp" work?

cc @rkooo567 @richardliaw for the ray error.

I feel like I have seen this before, and it may have been fixed in the latest version. have you tried 0.5.2?

I feel like I have seen this before, and it may have been fixed in the latest version. have you tried 0.5.2?

Oh dang I didn't even realize it already came out. Let me upgrade and report back.

I feel like I have seen this before, and it may have been fixed in the latest version. have you tried 0.5.2?

Oh dang I didn't even realize it came out. Let me upgrade and report back.

does distributed_executor_backend="mp" work?

Yes. I didn't explicitly set it in the original notebook because, as I understand it, mp is the default if there are enough GPUs on the local system to satisfy the tensor parallelization requirement. I'm updating the original notebook to include that in the working engine args.

I assume it is the same issue as https://github.com/vllm-project/vllm/pull/4286.
@baughmann is there a repro I can try?

maybe we need more fundamental solution for this case

@rkooo567 I put the content of the Jupyter notebook that I used to produce the error. You can find it in the OP, but I'll also put it here for your convenience :)
from vllm import AsyncEngineArgs, AsyncLLMEngine

# model source: https://huggingface.co/microsoft/Phi-3-mini-128k-instruct

# this config works
mp_args = AsyncEngineArgs(
    model="../../models/microsoft/Phi-3-mini-128k-instruct",
    trust_remote_code=True,
    distributed_executor_backend="mp",
    max_model_len=8000, # limit mem utilization for this example
    disable_sliding_window=True, # needed in order to use flash-attn
)

# this config does not work. it just sits at
#   "INFO worker.py:1779 -- Started a local Ray instance. View the dashboard at..."
# The actor dies with a `ray.exceptions.RaySystemError: System error: No module named 'transformers_modules'`
ray_args = AsyncEngineArgs(
    model="../../models/microsoft/Phi-3-mini-128k-instruct",
    trust_remote_code=True,
    max_model_len=8000,
    engine_use_ray=True,
    distributed_executor_backend="ray",
)

# engine = AsyncLLMEngine.from_engine_args(mp_args)
engine = AsyncLLMEngine.from_engine_args(ray_args)

Hello. I've been investigating the same error but in the context of multi-node inference with Ray. I created https://github.com/vllm-project/vllm/pull/6751 which fixes the issue for me.
Perhaps my fix will help in this scenario as well. I attempted to reproduce the error raised here using the code examples in this issue, but was unable to; the AsyncLLMEngine is created without error 🤔

@tjohnson31415 In my case I'm running only on a single node.
And oh, wow, the notebook didn't give you problems using the ray args? How strange

In my case I'm running only on a single node.

Yeah, that makes it interesting. In my understanding, https://github.com/vllm-project/vllm/pull/4286 should be the most recent fix for the single node case, but that fix looks like it was included in release v0.4.1... I just tested in my env with v0.5.1 and it worked with that too 🤔
Some other thoughts/questions:

Does it work for you if you use engine_use_ray=False? Maybe that is a new piece of the puzzle.
 If you run your code just as a python script, do you get the same error?

I'm not running in Jupyter in my test...

Do the transformers_modules dynamic modules exist in ~/.cache/huggingface/modules/transformers_modules/ (assuming HF_HOME and HF_MODULES_HOME are unset)? And are they regenerated by running your code?

I rm -rf ~/.cache/huggingface/modules/ each time I try to run the code to confirm that the modules do get regenerated.

Let me also take a look at it quickly. I am a little busy by other high priority task from our end.

@tjohnson31415 What I'll do is make a minimal conda env with a minimal reqs etc. and then perform the troubleshooting on that.
I will upload and post that repo when I'm able, but it may not be until later today

@tjohnson31415 @rkooo567 Here is a repo with conda for you all. Also created a basic readme for your convenience.
@tjohnson31415 Here's the update regarding your suggestions:

Does it work for you if you use engine_use_ray=False?
Yes, it does. Because then, as I understand it, it's not using Ray--it's using multiprocessing. I was able to use phi-3 with mp before, but I need to use it with Ray.

 If you run your code just as a python script, do you get the same error?
Yes, I'm afraid so. That's not surprising though as I run Jupyter notebooks in the same exact development environment I'm writing my application in.

Do the transformers_modules dynamic modules exist in...
Yes, it does. I added a note about this in the readme of the repo I posted. I see a Phi-3-mini-128k-instruct directory in that folder. If I delete .cache/huggingface/modules/transformers_modules/ it gets re-created the next time I try to run it with Ray.

@baughmann Ah, thanks for creating the repro-repo! I didn't realize that engine_use_ray=True would not print out any logs from the main engine loop. I can see the System error: No module named 'transformers_modules' error by looking in the logs in the Ray dashboard, as you stated in your repro steps.

As I understand it, with engine_use_ray=False, it's not using Ray

To make the server use Ray, distributed_executor_backend="ray" is sufficient. engine_use_ray is a separate configuration that puts the engine execution itself into a Ray process separate from the server process. With engine_use_ray=False the logs from the engine loop are printed directly to the console and there is no error.
The error occurs because the Ray worker spawned for the engine loop with engine_use_ray does not have its python path updated to include the dynamic modules generated for trust_remote_code. The failure occurs when communicating the ModelConfig from the main process to the Ray engine worker here.
The current way that the (non-engine) Ray workers handle this is that the WorkerWrapperBase is initialized where it runs init_cached_hf_modules before the args containing the ModelConfig are passed into init_worker. A wrapper/base like that could be added for the engine worker too... Or I think something similar to my fix in https://github.com/vllm-project/vllm/pull/6751 to pass the model configuration as a simple class instead of as an instance of a dynamic class generated in transformers_modules would work too.
But quickest fix is engine_use_ray=False.

@tjohnson31415 That most certainly did it! Thank you for the detailed explanation, that makes a lot of sense!
However, I would still expect parity between the models. Should we leave this ticket open, even though there is that workaround?

I am having this issue as well, and the workaround works. I am also curious as to when this will be implemented into the engine? If there is an open branch or fork, can someone link it here?

Just to note it here, there is a new RFC to remove --engine-use-ray altogether:
https://github.com/vllm-project/vllm/issues/7045
If the RFC is accepted, a fix for this issue may not be relevant for very long.

It would appear mp exec is now also affected in 0.6.1.post2
these two arguments to LLM don't help:
              distributed_executor_backend="mp",
              worker_use_ray=False,

ModuleNotFoundError: No module named 'transformers_modules.Phi-3'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/anaconda/envs/azureml_py310_sdkv2/lib/python3.10/multiprocessing/spawn.py", line 116, in spawn_main
    exitcode = _main(fd, parent_sentinel)
  File "/anaconda/envs/azureml_py310_sdkv2/lib/python3.10/multiprocessing/spawn.py", line 126, in _main
    self = reduction.pickle.load(from_parent)
ModuleNotFoundError: No module named 'transformers_modules.Phi-3'

resolved by removing '.' from the model name (path), before instantiating the engine. e.g. "weights/Phi3.5mini-instruct" -> "weights/Phi35mini-instruct" (on top of disabling Ray)

@nightflight-dk  it makes sense. the name might be used for import, and . has special meaning in python's import system.


GENERIC_PACKS not finding correct base_dir

Describe the problem
It seems that when specifying a GENERIC_PACK such as the latest RLCraft server pack the find command located at https://github.com/itzg/docker-minecraft-server/blob/master/scripts/start-setupModpack#L227 is not locating the correct base_dir location.
With the included example of the RLCraft the value of that base_dir variable gets set to /tmp/generic_pack_base/resources/customloadingscreen/sample when it should stay at /tmp/generic_pack_base for this modpack:
+ unzip -o -q -d /tmp/generic_pack_base /data/packs/RLCraft+Server+Pack+1.12.2+-+Release+v2.9.1c.zip
++ find /tmp/generic_pack_base -type d '(' -name mods -o -name plugins -o -name config ')' -printf %h -quit
+ base_dir=/tmp/generic_pack_base/resources/customloadingscreen/sample

RLCraft: https://www.curseforge.com/minecraft/modpacks/rlcraft
Container definition
Deployed in Kubernetes with the following file saved as rlcraft.yaml
kubectl apply -f rlcraft.yaml

apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: rlcraft
  namespace: dillon-minecraft-servers
spec:
  accessModes:
    - ReadWriteOnce
  resources:
    requests:
      storage: 10Gi
---
apiVersion: apps/v1
kind: Deployment
metadata:
  labels:
    run: rlcraft
  name: rlcraft
  namespace: dillon-minecraft-servers
spec:
  replicas: 1
  selector:
    matchLabels:
      run: rlcraft
  template:
    metadata:
      labels:
        run: rlcraft
    spec:
      securityContext:
        runAsUser: 1000
        fsGroup: 1000
      containers:
      - image: itzg/minecraft-server:java8
        tty: true
        stdin: true
        name: rlcraft
        env:
        - name: EULA
          value: "TRUE"
        - name: "TYPE"
          value: "FORGE"
        - name: "VERSION"
          value: "1.12.2"
        - name: "FORGE_INSTALLER_URL"
          value: "https://maven.minecraftforge.net/net/minecraftforge/forge/1.12.2-<IP_ADDRESS>60/forge-1.12.2-<IP_ADDRESS>60-installer.jar"
        - name: "GENERIC_PACK"
          value: "https://media.forgecdn.net/files/3655/676/RLCraft+Server+Pack+1.12.2+-+Release+v2.9.1c.zip"
        - name: "MEMORY"
          value: "5G"
        - name: "DEBUG"
          value: "true"
        ports:
        - name: minecraft
          containerPort: 25565
          protocol: TCP
        volumeMounts:
        - name: data
          mountPath: /data
        resources:
          requests:
            memory: 5Gi
            cpu: 4000m
          limits:
            memory: 8Gi
            cpu: 8000m
        livenessProbe:
          tcpSocket:
            port: 25565
      volumes:
      - name: data
        persistentVolumeClaim:
          claimName: rlcraft
---
apiVersion: v1
kind: Service
metadata:
  name: rlcraft
  namespace: dillon-minecraft-servers
  annotations:
    "mc-router.itzg.me/externalServerName": "private-server-address-here"
spec:
  ports:
    - name: minecraft
      protocol: TCP
      port: 25565
  selector:
    run: rlcraft
  type: ClusterIP

Container logs
Logs without DEBUG=true
chmod: changing permissions of '/data': Operation not permitted
[init] Running as uid=1000 gid=1000 with /data as 'drwxrwsr-x 3 0 1000 4096 May 20 01:08 /data'
[init] Resolved version given 1.12.2 into 1.12.2 and major version 1.12
[init] Resolving type given FORGE
[init] Downloading https://maven.minecraftforge.net/net/minecraftforge/forge/1.12.2-<IP_ADDRESS>60/forge-1.12.2-<IP_ADDRESS>60-installer.jar ...
[init] Installing Forge . This might take a minute or two...
[init] Finding installed server jar...
[init] Using server forge-1.12.2-<IP_ADDRESS>60.jar
[init] Downloading generic pack from https://media.forgecdn.net/files/3655/676/RLCraft+Server+Pack+1.12.2+-+Release+v2.9.1c.zip
[init] Checking if generic packs are up to date
[init] Generic pack(s) are out of date. Re-applying...
[init] Writing generic pack manifest ...
[init] Applying generic pack ...
[init] Saving generic pack(s) checksum
[init] Creating server.properties in /data/server.properties
[init] Disabling whitelist functionality
[init] Setting white-list to 'false' in /data/server.properties
[init] WARNING: whitelist enabled but not enforced. Set ENFORCE_WHITELIST=TRUE or update 'enforce-whitelist' in server.properties to enforce the whitelist.
[init] Setting enable-rcon to 'true' in /data/server.properties
[init] Setting rcon.password to 'minecraft' in /data/server.properties
[init] Setting rcon.port to '25575' in /data/server.properties
[init] Setting motd to 'A Forge Minecraft Server powered by Docker' in /data/server.properties
[init] Checking for JSON files.
[init] Setting initial memory to 5G and max to 5G
[init] Starting the Minecraft server...

Relevant part of the debug logs showing the variable values:
+ unzip -o -q -d /tmp/generic_pack_base /data/packs/RLCraft+Server+Pack+1.12.2+-+Release+v2.9.1c.zip
++ find /tmp/generic_pack_base -type d '(' -name mods -o -name plugins -o -name config ')' -printf %h -quit
+ base_dir=/tmp/generic_pack_base/resources/customloadingscreen/sample

Content of the manifest.txt file:
imagemeta/rotating_cake_top_left.json
imagemeta/rotating_cake_bottom_left.json
imagemeta/rotating_cake_bottom_right.json
imagemeta/rotating_cake_top_right.json
function/item_rotation.json
function/interpolate.json
action/sound_at_end.json
instruction/item_rotate_anti_clockwise.json
instruction/item_rotate_clockwise.json
image/block_cake_inner_4_wide.json
image/block_cake_side_4_wide.json
image/loading_bar_boss_percentage.json
image/text_status.json
image/dirt_background.json
image/text_status_white.json
image/cake_top_right.json
image/cake_bottom_right.json
image/panorama.json
image/bottom_bar.json
image/text_percentage_scrolling.json
image/text_sub_status_white.json
image/loading_bar_bevel_percentage.json
image/loading_bar_boss.json
image/text_generic_error.json
image/loading_bar_bevel.json
image/block_4_wide_percentage.json
image/cake.json
image/mojang_splash.json
image/text_percentage_white.json
image/cake_top_left.json
image/text_percentage.json
image/loading_bar_standard_percentage.json
image/cake_bottom_left.json
image/text_sub_status.json
image/item.json
image/block_4_wide.json
image/loading_bar_standard.json
image/horizontal_stripe.json
config/white.json
config/generic_error.json
config/forge_duplicate.json
config/rotating_cakes.json
config/default.json
config/worldload.json
config/custom.json
config/scrolling.json
config/scrolling_detailed.json

Thanks for reporting this. Since I'm not seeing a breadth first mode on find, maybe limiting the depth to 2 or 3 would suffice to avoid false matches.
A PR would be great if you're interested.

I wasn't able to recreate the issue, but I'm going to tighten up the maxdepth there and extra cleanup of the temp generic pack directory.


feat: add picker.hex_long/short

close #119
To easily specify only long/short hex.
local ccc = require'ccc'
ccc.setup {
  pickers = {
    ccc.picker.hex_long,
    ccc.picker.css_rgb,
    -- ...
  }
}

no problem, this implementation also works fine! Thanks for the implementation


Fix issue where the title bar drag area didn't extend into the sidebar

Resolved / Related Issues

This fixes an issue introduced in #4787 that @yaichenbaum pointed out

Details of Changes
Add details of changes here.

Moved drag area into sidebar split pane template
Move tab view to it's own spot within the template so that it does not occlude the drag area
Show paneroot on top of all other elements when in open compact overlay state

Validation
How did you test these changes?

[x] Built and ran the app
[ ] Tested the changes for accessibility

Screenshots (optional)
https://user-images.githubusercontent.com/59544401/116833636-37c04880-ab6f-11eb-9bac-c53802abef44.mp4

@winston-de Have you tested these changes when the multitasking setting is set to vertical?

@yaichenbaum Yes, works as expected.


Backlog - Tab Groups

Finish tab sets for Device and User detail pages.

User:  General, Groups, Devices, Notes
Device: General, Storage, Network, Software, Tools, Notes

Should be finished as of 1812.08.01


Issues  with save folder

I got the error
FileNotFoundError: [Errno 2] No such file or directory: 'save/37/shared.json'
save file is not available on https://worksheets.codalab.org/worksheets/0x37a9b8c44f6845c28866267ef941c89d/
I find it in out folder on
https://github.com/allenai/bi-att-flow/releases/tag/v0.3.0

I am facing the same issue. On running
basic/run_single.sh $HOME/data/squad/dev-v1.1.json single.json I get
Traceback (most recent call last):   File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main     "__main__", mod_spec)   File "/usr/lib/python3.6/runpy.py", line 85, in _run_code     exec(code, run_globals)   File "/mnt/blossom/data/amankansal/QA/2020-Hotpot-QA/bi-att-flow/basic/cli.py", line 109, in <module>     tf.app.run()   File "/mnt/blossom/data/amankansal/QA/2020-Hotpot-QA/bi-att-flow/bidaf_venv/lib/python3.6/site-packages/tensorflow/python/platform/app.py", line 43, in run     sys.exit(main(sys.argv[:1] + flags_passthrough))   File "/mnt/blossom/data/amankansal/QA/2020-Hotpot-QA/bi-att-flow/basic/cli.py", line 106, in main     m(config)   File "/mnt/blossom/data/amankansal/QA/2020-Hotpot-QA/bi-att-flow/basic/main.py", line 27, in main     _forward(config)   File "/mnt/blossom/data/amankansal/QA/2020-Hotpot-QA/bi-att-flow/basic/main.py", line 177, in _forward     test_data = read_data(config, config.forward_name, True)   File "/mnt/blossom/data/amankansal/QA/2020-Hotpot-QA/bi-att-flow/basic/read_data.py", line 206, in read_data     new_shared = json.load(open(shared_path, 'r')) FileNotFoundError: [Errno 2] No such file or directory: 'save/37/shared.json'
Folder 37 is not in save. The only ones are
34  35	70  71	72  73	74  75	76  77

@chetanchhabra Any luck on finding what this shared.json file is? I used the one from the out folder, but later ran into shape mismatch errors #113


EXISTS accepts a variable number of keys

From the docs:
Since Redis 3.0.3 the command accepts a variable number of keys

But in source code accepts only one key:
def exists(self, key):
    """Check if key exists."""
    fut = self._conn.execute(b'EXISTS', key)
    return wait_convert(fut, bool)

Thanks!

Updated


fix a UTF-8 related problem.

You could've added another commit to this one as well.

Oh. I didn't want to mess up the commit history because of my mistake. Do I have to commit to this one again?

No, all good! In the future you don't have to worry about the commit history, just keep committing to your PR. Git will take care of everything. Let's continue with the new PR!

I didn't know that. Thank you for letting me know!


Added upsert(Message) method to add or update message to adapter as appropriate

Useful when connecting adapter directly to streaming data source
Changed update methods to return boolean

#60


esp32: cache: test: add Flash/SPIRAM cache coex test

Add SPI Flash/SPI RAM coexistence test.
On ESP32, SPI Flash and SPIRAM both operate on storage and memory, respectively, through a shared cached region.
This test suite evaluates the integrity of the contents written by both peripherals, after some interleaved operations, in order to evaluate if coexistence between them is being kept.

@uLipe  @sylvioalves please, take a look


Use 'jackson-core' version 2.9.10

Context

Fixes #10902

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation
[ ] Recognize contributor in release notes

Thanks @MikeBerryFR - I cherry-picked this to the release branch. It'll be in 6.0


Verify all Collection fields map the same as GenericWork

With the exception of resource_type which will not be migrated, all of the Collection fields need to migrate the same way the fields in GenericWork do.
WDLL
All the Collection fields migrate and are treated the same way as fields on GenericWork.

What's NOT Being Migrated

description
keyword
ACLs
Managed DOIs
rights
resource types

Fixed in

https://github.com/psu-stewardship/scholarsphere/pull/1648
https://github.com/psu-stewardship/scholarsphere-client/pull/8
https://github.com/psu-stewardship/scholarsphere-4/pull/616


Added full name to Build's JSON

I want to be able to vizualize the fullName in Build JSON

Closed because of accidental merge. Opening a new one.


Creating custom tiles with custom sizes

Please do help me how to create tiles with custom look and feel with different sizes and shape. It will be greate if you can hep me small hello world example.
I use the following way to create tile, is it the right way
TileBuilder.create().build();
It create fix size tile with some default pic inside.
Regards

First of all you should take a look at the TilesFX demo project because there you will see how to use it. In this demo you will also find the usage of a custom tile skin. Please find the demo here: TilesFX Demo


right_shift + left_shift combination

Prior to macOS Sierra, I was able to map a simultaneous press of right shift and left shift to caps lock. This is not possible in Karabiner-Elements. I understand that this is likely the case because major changes in Sierra have necessitated a long update process to Karabiner.
Will this eventually be possible with Karabiner on Sierra? Alternatively, is there something else I can use to achieve this functionality?
Since I have remapped caps lock to delete, I currently have no way to trigger caps lock.

I got it working with this config.

@wincent, thanks so much for this. I've tried adding it to my config file, but it appears not to be working. I've never modified the config before, so I may have made a mistake or omitted a step?
Modified ~/.config/karabiner/karabiner.json
Here's my new config: https://pastebin.ubuntu.com/24888992/
After modifying, I quit Karabiner-Elements via the button on the GUI, and reopened it. My other remap continues to work. I'm running Karabiner-Elements version 0.90.92.
I've also tried setting Caps Lock to "No Action" in the "Modifier Keys" of System Preferences, as I think that previously may have had an impact under Karabiner.

I think you'll need at least 0.91.3 for this to work.

You are absolutely right. Had to do the beta update to get support for "complex_modifications". Thank you!
For those looking for this setup: make sure you are on a version after "complex_modifications" support was added, I think it might have a couple point releases before 0.91.3 (you may need to "Check for beta updates" in "Misc"). Then, open Terminal and run:
open ~/.config/karabiner/karabiner.json
And modify the file to include the lines @wincent linked to from his config. Save, quit Karabiner-Elements and reopen and you should be set.


Issues installing

I receive the following error when attempting to install this library.  The biggest issue that stands out to me is the last line (ImportError: No module named requests.packages.urllib3.exceptions)
Any thoughts on how to proceed forward with this error?
STDOUT: Downloading/unpacking pysecuritycenter==2.1
  Downloading pySecurityCenter-2.1.tar.gz
  Running setup.py (path:/tmp/pip-build-Wfk05K/pysecuritycenter/setup.py) egg_info for package pysecuritycenter
    Traceback (most recent call last):
      File "<string>", line 17, in <module>
      File "/tmp/pip-build-Wfk05K/pysecuritycenter/setup.py", line 3, in <module>
 import securitycenter
      File "securitycenter/__init__.py", line 1, in <module>
 from base import SecurityCenter4 as SecurityCenter
      File "securitycenter/base.py", line 1, in <module>
 from requests.packages.urllib3.exceptions import InsecureRequestWarning
    ImportError: No module named requests.packages.urllib3.exceptions
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):

  File "<string>", line 17, in <module>

  File "/tmp/pip-build-Wfk05K/pysecuritycenter/setup.py", line 3, in <module>

    import securitycenter

  File "securitycenter/__init__.py", line 1, in <module>

    from base import SecurityCenter4 as SecurityCenter

  File "securitycenter/base.py", line 1, in <module>

    from requests.packages.urllib3.exceptions import InsecureRequestWarning

ImportError: No module named requests.packages.urllib3.exceptions

can you please try to install the latest version?  2.1.6 is current (not 2.1)

Closing from lack of response.


pact-jvm subprojects not compiling in eclipse

Hello,
Four subprojects in pact-jvm (pact-model, pact-jvm-pact-broker, pact-jvm-support, and pact-publish) will not compile when imported into eclipse.  I'm using the latest version of Spring Tool Suite 4 and used File->Import->Gradle->Existing Gradle Project.
It seems like a class path issue based on the gradle configuration because everything builds fine from the command line.
I looked at the build.gradle file and settings.gradle file.  I noticed the four subprojects that will not build are all listed as independent includes in settings.gradle.  Seems like they may need reference other projects in their classpath.  But I'm unclear on how to achieve this.
Any ideas?
Regards,
John

Eclipse is not processing the Gradle project correctly. It works fine with IntelliJ IDEA. Maybe raise an issue with the Eclipse project?


[Docs] Update docs for "Running on Device"

Hi there,
I'm new to React Native and I was having problems with Running on Device yesterday on iOS. I was following this section of the docs:
https://facebook.github.io/react-native/docs/running-on-device-ios.html
I realised after I was using 0.28 and in the latest stable release 0.29 you don't have to change localhost to your IP Address on the network as stated in these docs.. In fact I couldn't even find localhost in the AppDelegate.m so this part no longer seems relevant and may be confusing to people reading it.

@facebook-github-bot label Documentation

I'm curious, how does it work now?

@inetfuture You can refer to 8c29a52c54392ce52148e7d3aa9f835537453aa4

get it, thanks


Move installation instructions from wiki to docs

Since the installation instructions are user focused (rather than developer focused), we should move the to the docs instead of the wiki.  The docs thread on installing starts at 4492598.  We can include a link to the documentation from the wiki.

Superseded by #511.


Creating Visulization for the Package workflows

[x]  Currently we have these steps for Pathways synthesis.
[x]  This needs to updated as we progress through other tasks.

Oh wait! one last thing! Could you also include the raw drawio file into the assets folder? So we have it as a reference in case we need to update it? Then you can merge it -- thanks!

@Jay-sanjay, if you can do this, then this PR is ready to merge. Thanks!


Support python match on Tree

I really like the new python match construct but it seems the Tree datatype doesn't currently support it.
I can monkey patch it in with Tree.__match_args__ = ("data", "children") , but inserting this line into https://github.com/lark-parser/lark/blob/master/lark/tree.py should support it reasonably. Alternatively, a dataclass annotation I believe would also enable pattern matching.

I support adding it.


feat(test): add very simple binCases test infra to build off of

What kind of change does this PR introduce?
🏗 Test Infrastructure 🏗

Did you add tests for your changes?
Well they are the changes :woman_cartwheeling:

If relevant, link to documentation update:
N/A ⛔

Summary
Adding some foundational binCases suite for testing bin commands. They will call child_process.exec(), and handler will verify if successfully ran. I am just laying the foundation for the tests. And looking for @sokra 's help for how much surface area we want to cover.
Helps make it possible to better cover changes in #3524.

Does this PR introduce a breaking change?
No way José!

Alright I took a stab at this. Turned out to be interesting to learn how to spawn processes and get reports from them, etc. I added an ARGUMENTS.json file which is an object of key value pairs.
{
"arg": "argvalue"
"arg2": "",
"arg4": "argvalue"
}
This seemed like a fun way to tackle it at least. Unless you are just expecting a flat string of args to be pulled in.

Looks like per tests I'll need to make sure I'm using path.join() everywhere (for windows).

@alistairjcbrown, since I have been pretty darn busy managing the influx of PR's and CodeReviews. I was reminded of this PR that needs some cleanup, but I thought it may be right down your alley. Essentially we lack coverage and infra for our bin/* stuff.
Would you be interested? (No pressure).

@TheLarkInn I don't have access to modify this branch directly, but I've updated the corresponding branch on my fork and created a PR with it, #3844
Feel free to close off that PR and pull the changes into this one to keep history, etc., if the changed look ok.

Sounds good closing.


Submissions and comments in /r/spam should be hidden when on a profile and the 'hide mod comments' button is clicked.

We might also want to change the phasing to 'hide mod actions'.  Thoughts?

cool

Sounds good to me.

Got this working in my fork, should I PR now or do you guys want to discuss more?

Sweet.   I think it's as discussed as need be.   Open a PR.

@agentlame


Send Dead Reckoned position and Best Age in the JSON so the client doesn’t have to calculate them

The client needs to dead reckon every second but only queries the server every 10, so this isn't going to work


Allow template_folder to be a pathlib.Path object

When constructing the Flask object, it would be nice if template_folder could be either a string (currently) or a pathlib.Path object. This would match static_folder, which is currently typed as Union[str, os.PathLike]. That functionality was added in  #3579; I was unable to find any reason why the same wasn't done for template_folder, so I assume it was an unintentional omission.
https://flask.palletsprojects.com/en/2.2.x/api/#application-object
Not having this functionality is not a dealbreaker, as it's pretty simple to do template_folder=str(path), but it would be nice and match static_folder. In SecureDrop our code is going to look like:
    app = Flask(
        __name__,
        template_folder=str(config.JOURNALIST_TEMPLATES_DIR.absolute()),
        static_folder=config.STATIC_DIR,
    )

...so implementing this would be nice.

Happy to review a PR


Relax phoenix_live_view version contraint

I tested this on phoenix_live_view 0.20 and works as expected

is there a reason for this change? What is it impacting ?

@DianaOlympos its impacting the ability install with live_view 0.20 which is the current version of live_view.

I will release a new version as soon as i get back to a computer today

Sorry, i should have had a better description. Thanks, but no stress on my side, we are using the fork for now.

Hey @DianaOlympos sorry for the tag but any chance we could get a release? The version on hex.pm is still unable to be used with liveview 0.20. Thanks in advance! :)

You are totally right. Life happened. I will do a release tomorrow. Ping me next week if it is not done

Should be done as v1.0.4!
https://hex.pm/packages/orion
Thank you for the reminder and for the patch.


👋 push View with Environment and EnvironmentObject

I've been racking my brain trying to figure out how to push a new view with environment modifiers in SwiftUI. So I was just wondering if it's possible, and if this usage is intended. Thank you for your work and your response.

Hey! Thanks for your kind words!
Well, this functionality wasn't intended indeed, but the library is still on very early stage, so I think it shouldn't be a problem to extend it in this direction.
And I must sorry you, but I'm a visualiser, so could you share please an example of functionality that you wanted to achieve?
Thanks and have a good day!

Oh thanks for your quick feedback and yes of course, here's a little example:
`import SwiftUI
import Combine
import Navigattie
struct FirstFlowScreen: NavigatableView {
@Environment(SharedVariables.self) var shared

@StateObject var navState = NavigationStateManager()

var titleView: String
var sharedFlowVM = BigFlowViewModel()

var body: some View {

    NavigationStack(path: $navState.inventorySelectionPath) {
        ScrollView(showsIndicators: false){

            //Content
        }
        .navigationDestination(for: NavigationStateManager.self) { state in
            switch state {
                case .goToView1: View1()
                    .environment(sharedFlowVM)
                    .environment(shared)
                    .environmentObject(navState)
                case .goToView2: View2()
                    .environment(sharedFlowVM)
                    .environment(shared)
                    .environmentObject(navState)
            }
        }
    }
}

}
`
Views depend on certain environment objects and are passed to it that way. And I'm wondering how to do this with Navigattie.
(I have another question that I'll do in another ticket ;) )

Hi, sorry for my late response, but I'm having a real crunch at work :)
Let's divide the problem you described into three parts:

FirstFlowScreen
If I have understood the purpose of this screen correctly, it should act like a RootView, which controls the entire flow inside the application.

EnvironmentObject value
Personally I try to avoid @EnvironmentObjects as much as I can, so if I were you I would consider using Singleton.

.navigationDestination modifier
By reimplementing 1 and 2, I think it's possible to avoid using that part of your code.

Hi, It's okay, don't worry about it.
Yes, it's almost like that. Except that the Tabview contains several flows. (FirstFlowScreen, SecondFlowScreen, ThirdFlowScreen, etc). Each first screen of each flow should be the RootView of its own flow.
I can see the reasons for avoiding EnvironmentObjects. ;)

Oh, so let's call these flows app states. Every app state can contain can flows. The design I propose is as follows:
struct ScreenA: View {
    @ObservedObject private var stateStore: StateStore = .shared

    var body: some View {
        switch stateStore.appStatus {
            case .stateA, .stateB: View1()
            case .stateC: View2()
            case .stateD: View3()
            case .stateE: View4()
            case .stateF: View5()
        }
    }
}

States are controlled by stateStore that works like a ViewModel. To initialize the correct state, just add a modifier to this structure, which calls the method from your VM:
struct ScreenA: View {
    @ObservedObject private var stateStore: StateStore = .shared

    var body: some View {
        Group {
            switch stateStore.appStatus {
                case .stateA, .stateB: View1()
                case .stateC: View2()
                case .stateD: View3()
                case .stateE: View4()
                case .stateF: View5()
            }
        }
        .task(stateStore.refreshCredentials)
    }
}

I know this is a closed issue, but I was actually needing this functionality. I have a view that has a "view" and "edit" mode. I'm using EditMode environment variable and its functionality with EditButton. I need to be able to set the editMode when calling the child view by using the modifier  .environment(.editMode, .constant(.active)) but can't use Navigattie to do so. Just wondering if you have any thoughts? I know I can completely roll my own implementation by optionally passing an "editmode" variable in the initializer, but then I can't use the EditButton and its functionality. Thanks for any insight you may have.


v1.2.1 does not show up in packist

https://packagist.org/packages/fasterimage/fasterimage shows v1.2.0 as the latest

Whoops -- something must have been off. Looks updated now. Thanks for letting me know!


Added Manjara Charitable Trust's RGIT and VJTI

Added Manjara Charitable Trust's Rajiv Gandhi Institute of Technology aka Rajiv Gandhi Institute of Technology aka RGIT and Veermata Jijabai Technological Institute which is a college in city of Mumbai in India.

@Harmanankohli Pull request merged. Thank you!


Add configuration settings to search results

Work in progress
Summary
This PR modifies the Sphinx search to:

allow indexing of individual configuration settings
display configuration setting results in a separate section on the result page

Configuration settings are added to the Sphinx index using a Domain (config), and an HTML anchor is added to the page using a Directive (setting).
Example:
.. config:setting:: ServiceSettings.SiteURL
  MM_SERVICESETTING_SITEURL

The above directive will add 2 terms to the search index: ServiceSettings.SiteURL and MM_SERVICESETTING_SITEURL. The directive will be replaced with an anchor (<a>) tag that can be used as a URL fragment (e.g., page.html#mid-page-heading); this takes the reader directly to the relevant section from the search results.
Why a domain?
Sphinx’s built-in search performs two activities:

Text search
Object search

The latter, Object search, seems to have been meant for documenting APIs as it allows a reference to a specific anchor (section) of the matched document. The text search does not reference an anchor at all.
Adding terms to an object search in Sphinx requires the use of a domain. There are several built-in domains for programming languages, such as C, C++, and Python. For this PR, a new domain (config) was created along with a directive (setting) to denote a configuration setting. The domain can be extended with directives which handle other kinds of configuration (e.g., environment variables).
Split results
In this PR, if there are search results that match a configuration setting, the results are split into a section for configuration setting matches and a section for all other matches. In this way configuration settings are shown prominently at the top of the search results.
If there are no configuration setting matches, the configuration setting result section will not be displayed.
Search result scoring
All results from a Sphinx search have a score or rating that shows the confidence in the result; a higher score means higher confidence. By default, results from object searches are scored higher than results from text searches. Results are still scored highest-to-lowest in each section if there are configuration setting matches.
The default search scoring is defined in source/_static/searchtools.js and is shown in the following list:

Object search

Full name match = 11
Partial name match = 6
Object “priority” (default: “Important results”)

“Important results” = 15
“Object results” = 5
“Unimportant results” = -5

Text search

Full title match = 15
Partial title match = 7
Full term match = 5
Partial term match = 2

The individual scores and how they are applied to results is configurable.

Hello @neflyte,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!


Unexpected native type exception in android

09-19 08:55:39.816   9079-10772/com.facebook.react.uiapp E/unknown:React﹕ Exception in native call from JS
com.facebook.react.bridge.UnexpectedNativeTypeException: TypeError: expected dynamic type string', but had type int64'
at com.facebook.react.bridge.ReadableNativeMap.getString(Native Method)
at com.facebook.react.uimanager.CatalystStylesDiffMap.getString(CatalystStylesDiffMap.java:72)
at com.facebook.react.views.text.ReactTextShadowNode.updateProperties(ReactTextShadowNode.java:320)
at com.facebook.react.views.textinput.ReactTextInputShadowNode.updateProperties(ReactTextInputShadowNode.java:102)
at com.facebook.react.uimanager.UIManagerModule.createView(UIManagerModule.java:256)
at java.lang.reflect.Method.invoke(Native Method)
at java.lang.reflect.Method.invoke(Method.java:372)
at com.facebook.react.bridge.BaseJavaModule$JavaMethod.invoke(BaseJavaModule.java:106)
at com.facebook.react.bridge.NativeModuleRegistry$ModuleDefinition.call(NativeModuleRegistry.java:126)
at com.facebook.react.bridge.NativeModuleRegistry.call(NativeModuleRegistry.java:64)
at com.facebook.react.bridge.CatalystInstance$NativeModulesReactCallback.call(CatalystInstance.java:326)
at com.facebook.react.bridge.queue.NativeRunnable.run(Native Method)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:31)
at android.os.Looper.loop(Looper.java:135)
at com.facebook.react.bridge.queue.MessageQueueThread$1.run(MessageQueueThread.java:137)
at java.lang.Thread.run(Thread.java:818)

Thanks for reporting! This might be a recent bug related to color handling which just got fixed on master.
Can you please share your JS code? Can you repro it consistently?

I just run the examples in react-native，and got the error. I hadn't wrote more than one code.

I pull down the newest codes, but still have the problem when I run examples

It's definitely caused by 9a2d05d9b2aea459ef3b3e92376cf15bca4d17fa, and it doesn't seem to be fixed in master yet.  If I revert this commit, UIExplorer comes up fine.  With the commit, you get this error.

Thanks, @malchev

Same problem. Here is the crash log in sample app com.facebook.react.movies
E: FATAL EXCEPTION: main
E: Process: com.facebook.react.movies, PID: 10425
E: com.facebook.react.bridge.UnexpectedNativeTypeException: TypeError: expected dynamic type `string', but had type `int64'
E:     at com.facebook.react.bridge.ReadableNativeMap.getString(Native Method)
E:     at com.facebook.react.uimanager.CatalystStylesDiffMap.getString(CatalystStylesDiffMap.java:72)
E:     at com.facebook.react.uimanager.BaseViewPropertyApplicator.applyCommonViewProperties(BaseViewPropertyApplicator.java:77)
E:     at com.facebook.react.uimanager.ViewGroupManager.updateView(ViewGroupManager.java:28)
E:     at com.facebook.react.views.view.ReactViewManager.updateView(ReactViewManager.java:87)
E:     at com.facebook.react.views.view.ReactViewManager.updateView(ReactViewManager.java:40)
E:     at com.facebook.react.uimanager.NativeViewHierarchyManager.createView(NativeViewHierarchyManager.java:182)
E:     at com.facebook.react.uimanager.UIViewOperationQueue$CreateViewOperation.execute(UIViewOperationQueue.java:137)
E:     at com.facebook.react.uimanager.UIViewOperationQueue$1.run(UIViewOperationQueue.java:574)
E:     at com.facebook.react.uimanager.UIViewOperationQueue$DispatchUIFrameCallback.doFrameGuarded(UIViewOperationQueue.java:622)
E:     at com.facebook.react.uimanager.GuardedChoreographerFrameCallback.doFrame(GuardedChoreographerFrameCallback.java:32)
E:     at com.facebook.react.uimanager.ReactChoreographer$ReactChoreographerDispatcher.doFrame(ReactChoreographer.java:114)
E:     at android.view.Choreographer$CallbackRecord.run(Choreographer.java:759)
E:     at android.view.Choreographer.doCallbacks(Choreographer.java:574)
E:     at android.view.Choreographer.doFrame(Choreographer.java:543)
E:     at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:747)
E:     at android.os.Handler.handleCallback(Handler.java:733)
E:     at android.os.Handler.dispatchMessage(Handler.java:95)
E:     at android.os.Looper.loop(Looper.java:136)
E:     at android.app.ActivityThread.main(ActivityThread.java:5114)
E:     at java.lang.reflect.Method.invokeNative(Native Method)
E:     at java.lang.reflect.Method.invoke(Method.java:515)
E:     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:786)
E:     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:602)
E:     at de.robv.android.xposed.XposedBridge.main(XposedBridge.java:132)
E:     at dalvik.system.NativeStart.main(Native Method)

:+1:

class:com.facebook.react.uimanager.BaseViewPropertyApplicator
line:51
String importantForAccessibility;
        if(props.hasKey("backgroundColor")) {
            importantForAccessibility = props.getString("backgroundColor");
            if(importantForAccessibility == null) {
                view.setBackgroundColor(0);
            } else {
                view.setBackgroundColor(CSSColorUtil.getColor(importantForAccessibility));
            }
        }

may should be the following
int importantForAccessibility;
        if(props.hasKey("backgroundColor")) {
            importantForAccessibility = props.getInt("backgroundColor");
            if(importantForAccessibility == null) {
                view.setBackgroundColor(0);
            } else {
                view.setBackgroundColor(importantForAccessibility);
            }
        }

can anyone try it?

Same issue here - so far on UIExplorer and Movies.

At least my problem is that UIExplorer's build.gradle depends on the prebuilt react native for Android.  Once I realized that and switched over to sources, things started working again.  Commit 9a2d05d9b2aea459ef3b3e92376cf15bca4d17fa changed Examples/UIExplorer, which caused the incompatibility with the prebuilt react native.  I guess the build.gradle files in Exapmples should switch to compile from sources by default:
diff --git a/Examples/UIExplorer/android/app/build.gradle b/Examples/UIExplorer/android/app/build.gradle
index 275ffb2..79fd9e8 100644
--- a/Examples/UIExplorer/android/app/build.gradle
+++ b/Examples/UIExplorer/android/app/build.gradle
@@ -27,9 +27,9 @@ dependencies {
compile 'com.android.support:appcompat-v7:23.0.1'
 // Depend on pre-built React Native

compile 'com.facebook.react:react-native:0.11.+'

// compile 'com.facebook.react:react-native:0.11.+'
// Depend on React Native source.
// This is useful for testing your changes when working on React Native.

// compile project(':ReactAndroid')

compile project(':ReactAndroid')
}

The examples don't build from source to keep the setup instructions less complicated (you need the NDK installed to build it).

@ide I installed the NDK, and then run the examples in idea with Genymotion, the error also happened

Hello
I just cloned the latest master (UTC/GMT is 20:00 on 23 September 2015) and I get the red screen of death saying:
TypeError: expected dynamic type 'string', but had type 'int64'
That is with the default project created with react-native init freedom and react-native run-android.
I also get this console output from react-native start
Unable to resolve module image!myIcon from Y:\fraedom\node_modules\react-native\Libraries\Image\Image.android.js
Unable to resolve module image!app_logo from Y:\fraedom\node_modules\react-native\Libraries\Components\ToolbarAndroid\ToolbarAndroid.android.js
Unable to resolve module image!icon_settings from Y:\fraedom\node_modules\react-native\Libraries\Components\ToolbarAndroid\ToolbarAndroid.android.js
Unable to resolve module image!some_icon from Y:\fraedom\node_modules\react-native\Libraries\Components\ToolbarAndroid\ToolbarAndroid.android.js
Unable to resolve module image!myButton from Y:\fraedom\node_modules\react-native\Libraries\Components\Touchable\TouchableHighlight.js
Unable to resolve module image!myButton from Y:\fraedom\node_modules\react-native\Libraries\Components\Touchable\TouchableOpacity.js

Any ideas how to fix that? @ide @malchev
Here is the complete output
Y:\fraedom>react-native start
 ┌────────────────────────────────────────────────────────────────────────────┐
 │  Running packager on port 8081.                                            │
 │                                                                            │
 │  Keep this packager running while developing on any JS projects. Feel      │
 │  free to close this tab and run your own packager instance if you          │
 │  prefer.                                                                   │
 │                                                                            │
 │  https://github.com/facebook/react-native                                  │
 │                                                                            │
 └────────────────────────────────────────────────────────────────────────────┘
Looking for JS files in
   Y:\fraedom

[8:55:21 AM] <START> Building Dependency Graph
[8:55:21 AM] <START> Crawling File System
[8:55:21 AM] <START> Loading bundles layout
[8:55:21 AM] <END>   Loading bundles layout (0ms)

React packager ready.

[8:55:31 AM] <END>   Crawling File System (9938ms)
[8:55:31 AM] <START> Building in-memory fs for JavaScript
[8:55:32 AM] <END>   Building in-memory fs for JavaScript (1265ms)
[8:55:32 AM] <START> Building in-memory fs for Assets
[8:55:33 AM] <END>   Building in-memory fs for Assets (1037ms)
[8:55:33 AM] <START> Building Haste Map
[8:55:34 AM] <START> Building (deprecated) Asset Map
[8:55:34 AM] <END>   Building (deprecated) Asset Map (166ms)
[8:55:34 AM] <END>   Building Haste Map (883ms)
[8:55:34 AM] <END>   Building Dependency Graph (13130ms)
[8:55:44 AM] <START> request:/index.android.bundle?platform=android
[8:55:44 AM] <START> find dependencies
Unable to resolve module image!myIcon from Y:\fraedom\node_modules\react-native\Libraries\Image\Image.android.js
Unable to resolve module image!app_logo from Y:\fraedom\node_modules\react-native\Libraries\Components\ToolbarAndroid\ToolbarAndroid.android.js
Unable to resolve module image!icon_settings from Y:\fraedom\node_modules\react-native\Libraries\Components\ToolbarAndroid\ToolbarAndroid.android.js
Unable to resolve module image!some_icon from Y:\fraedom\node_modules\react-native\Libraries\Components\ToolbarAndroid\ToolbarAndroid.android.js
Unable to resolve module image!myButton from Y:\fraedom\node_modules\react-native\Libraries\Components\Touchable\TouchableHighlight.js
Unable to resolve module image!myButton from Y:\fraedom\node_modules\react-native\Libraries\Components\Touchable\TouchableOpacity.js
[8:55:45 AM] <END>   find dependencies (145ms)
[8:55:45 AM] <START> transform
transforming [========================================] 100% 314/314
[8:55:45 AM] <END>   transform (89ms)
[8:55:45 AM] <END>   request:/index.android.bundle?platform=android (256ms)
::ffff:<IP_ADDRESS> - - [Wed, 23 Sep 2015 20:55:46 GMT] "GET /flow/ HTTP/1.1" 404 - "-" "okhttp/2.4.0"

cc @mkonicek ^ this issue may block 0.12

Here is the red screen of death I got:

Facing the same issue.

Thanks for reporting! This is a KP which was fixed on master, see https://github.com/facebook/react-native/issues/2983

@mkonicek Sorry, I belive it is still not fixed, see #2983 for details.

Hi @malchev
I still have this problem with the latest master.
Can you please tell me in more detail what your fix is?
I tried changing the 'guild.gradle' as you mentioned to:
dependencies {
    compile fileTree(dir: 'libs', include: ['*.jar'])
    compile 'com.android.support:appcompat-v7:23.0.1'
    // compile 'com.facebook.react:react-native:0.11.+'
    compile project(':ReactAndroid')
}

But only get:
Y:\hope>react-native run-android
Starting JS server...
Building and installing the app on the device (cd android && gradlew.bat install
Debug)...

FAILURE: Build failed with an exception.

* Where:
Build file 'Y:\hope\android\app\build.gradle' line: 29

* What went wrong:
A problem occurred evaluating project ':app'.
> Project with path ':ReactAndroid' could not be found in project ':app'.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.

BUILD FAILED

Total time: 7.219 secs
Could not install the app on the device, see the error above.

Y:\hope>

@BerndWessels obviously you need to add the ReactAndroid project/folder to your project folder.
Put the folder from react-native/ReactAndroid to your project's folder, then add include ':ReactAndroid' to settings.gradle. You'll be good to go.

@zakelfassi you can link it from node_modules also i guess. no need to copy.
In settings.gradle
include ':ReactAndroid', ':app'
project(': ReactAndroid').projectDir = new File(rootProject.projectDir, '../node_modules/react-native')

@zakelfassi OK, thank you, I try.
is this correct build.gradle:
apply plugin: 'com.android.application'

android {
    compileSdkVersion 23
    buildToolsVersion "23.0.1"

    defaultConfig {
        applicationId "com.hope"
        minSdkVersion 16
        targetSdkVersion 22
        versionCode 1
        versionName "1.0"
        ndk {
            abiFilters "armeabi-v7a", "x86"
        }
    }
    buildTypes {
        release {
            minifyEnabled false
            proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
        }
    }
}

dependencies {
    compile fileTree(dir: 'libs', include: ['*.jar'])
    compile 'com.android.support:appcompat-v7:23.0.1'
    // compile 'com.facebook.react:react-native:0.11.+'
    compile project(':ReactAndroid')
}

And where does the ReactAndroid folder has to be copied to exactly?

@zakelfassi Sorry, always get the same
Y:\hope>react-native run-android
Starting JS server...
Building and installing the app on the device (cd android && gradlew.bat install
Debug)...

FAILURE: Build failed with an exception.

* Where:
Build file 'Y:\hope\android\app\build.gradle' line: 29

* What went wrong:
A problem occurred evaluating project ':app'.
> Project with path ':ReactAndroid' could not be found in project ':app'.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.

BUILD FAILED

Total time: 3.487 secs
Could not install the app on the device, see the error above.

Y:\hope>

Is the Y:\hope\android\app\build.gradle the file to be modified as mentioned earlier?
Is it enough to copy the ReactAndroid folder into Y:\hope\android\app ?

Its started working for me. Thank you very much.
Neeraj Singh
09538101105
On Fri, Sep 25, 2015 at 3:49 AM, Bernd Wessels<EMAIL_ADDRESS>wrote:

@zakelfassi https://github.com/zakelfassi Sorry, always get the same
Y:\hope>react-native run-android
Starting JS server...
Building and installing the app on the device (cd android && gradlew.bat install
Debug)...
FAILURE: Build failed with an exception.

Where:
Build file 'Y:\hope\android\app\build.gradle' line: 29

What went wrong:
A problem occurred evaluating project ':app'.

Project with path ':ReactAndroid' could not be found in project ':app'.

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.

BUILD FAILED
Total time: 3.487 secs
Could not install the app on the device, see the error above.
Y:\hope>
Is the Y:\hope\android\app\build.gradle the file to be modified as
mentioned earlier?
Is it enough to copy the ReactAndroid folder into Y:\hope\android\app ?
—
Reply to this email directly or view it on GitHub
https://github.com/facebook/react-native/issues/2855#issuecomment-143064733
.

@neeraj-singh What did you do to make it run?

Followed the same thing
dependencies {
compile fileTree(dir: 'libs', include: ['*.jar'])
compile 'com.android.support:appcompat-v7:23.0.1'
// compile 'com.facebook.react:react-native:0.11.+'
compile project(':ReactAndroid')
}
with new pull from master.
Just this every time I need to kill other process which was listening to
port 8081. and after running ./packager/packager.sh only it was working.
Neeraj Singh
09538101105
On Fri, Sep 25, 2015 at 3:52 AM, Bernd Wessels<EMAIL_ADDRESS>wrote:

@neeraj-singh https://github.com/neeraj-singh What did you do to make
it run?
—
Reply to this email directly or view it on GitHub
https://github.com/facebook/react-native/issues/2855#issuecomment-143065234
.

@neeraj-singh Mmh, wonder why I get these errors mentioned above.
When I add this to Y:\hope\android\settings.gradle
include ':ReactAndroid'

And then run react-native run-android I get
Y:\hope>react-native run-android
Starting JS server...
Building and installing the app on the device (cd android && gradlew.bat install
Debug)...

FAILURE: Build failed with an exception.

* Where:
Build file 'Y:\hope\android\ReactAndroid\build.gradle' line: 8

* What went wrong:
Could not compile build file 'Y:\hope\android\ReactAndroid\build.gradle'.
> startup failed:
  build file 'Y:\hope\android\ReactAndroid\build.gradle': 8: unable to resolve c
lass de.undercouch.gradle.tasks.download.Download
 @ line 8, column 1.
     import de.undercouch.gradle.tasks.download.Download
     ^

  1 error

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.

BUILD FAILED

Total time: 4.367 secs
Could not install the app on the device, see the error above.

Y:\hope>

Any ideas?

try this
clean your project.
add the suggested line in your build.gradle file of example app you want to
run.
to build either use android-studio or use this command
./gradlew :Examples:Movies:android:app:installDebug
kill any process which is listening port 8081 if any
run
./packager/packager.sh
if running on device run this also
adb reverse tcp:8081 tcp:8081
reload js it should work.
Neeraj Singh
09538101105
On Fri, Sep 25, 2015 at 4:25 AM, Bernd Wessels<EMAIL_ADDRESS>wrote:

@neeraj-singh https://github.com/neeraj-singh Mmh, wonder why I get
these errors mentioned above.
When I add this to Y:\hope\android\settings.gradle
include ':ReactAndroid'
And then run react-native run-android I get
Y:\hope>react-native run-android
Starting JS server...
Building and installing the app on the device (cd android && gradlew.bat install
Debug)...
FAILURE: Build failed with an exception.

Where:
Build file 'Y:\hope\android\ReactAndroid\build.gradle' line: 8

What went wrong:
Could not compile build file 'Y:\hope\android\ReactAndroid\build.gradle'.

startup failed:
build file 'Y:\hope\android\ReactAndroid\build.gradle': 8: unable to resolve c
lass de.undercouch.gradle.tasks.download.Download
@ line 8, column 1.
import de.undercouch.gradle.tasks.download.Download
^

1 error

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.

BUILD FAILED
Total time: 4.367 secs
Could not install the app on the device, see the error above.
Y:\hope>
Any ideas?
—
Reply to this email directly or view it on GitHub
https://github.com/facebook/react-native/issues/2855#issuecomment-143070640
.

@malchev works for me as well, thanks

On Oct 3, 2015 9:01 PM, "Marconi Moreto Jr"<EMAIL_ADDRESS>wrote:
@malchev https://github.com/malchev works for me as well, thanks
—
Reply to this email directly or view it on GitHub
https://github.com/facebook/react-native/issues/2855#issuecomment-145303806
.

@BerndWessels Modify Y:\hope\android\build.gradle to the following:
// Top-level build file where you can add configuration options common to all sub-projects/modules.

buildscript {
    repositories {
        jcenter()
        mavenLocal()
    }
    dependencies {
        classpath 'com.android.tools.build:gradle:1.3.1'
        classpath 'de.undercouch:gradle-download-task:1.2'

        // NOTE: Do not place your application dependencies here; they belong
        // in the individual module build.gradle files
    }
}

allprojects {
    repositories {
        jcenter()
        mavenLocal()
    }
}

@yzarubin Thank you, will give it a try.

i found it also , now update gradle for latest is ok:
dependencies {
compile fileTree(dir: 'libs', include: ['*.jar'])
compile 'com.android.support:appcompat-v7:23.0.1'
compile 'com.facebook.react:react-native:0.12.+'
}

https://github.com/facebook/react-native/
npm start
The system cannot find the specified path.
why?  I have installed studio Android to the simulator, but the service is not open.
system : windows


Set up renovate batched dependencies

I rule and have completed some work on Case Manager that's ready for review!
Tell renovate to group our changes together
This pull request makes the following changes:

all minor and patch, together

Testing
You can validate the config via the renovate-config-validator script, but I don't know how to ask it to validate the batching 🤷🏼
It relates to the following issue #s:

Fixes #3049

For reviewer:

Adjust the title to explain what it does for the notification email to the listserv.
Tag this PR:

feature if it contains a feature, fix, or similar. This is anything that contains a user-facing fix in some way, such as frontend changes, alterations to backend behavior, or bug fixes.
dependencies if it contains library upgrades or similar. This is anything that upgrades any dependency, such as a Gemfile update or npm package upgrade.

If it contains neither, no need to tag this PR.

Question: why not just batch all patch and minor updates? Are there certain packages for which you wish to avoid batching?

Lots of failing builds recently. Maybe try rebasing main?


performance improvement when streaming PDFs

Hello,
I have noticed when the server does support ranges after reading the HTTP headers the stream is canceled (with disableStream=true), then range requests are made. In particular the first range request is made from byte 0.
I was wondering why not keep on reading the first chunk worth of data right after reading the headers?
It would save a connection setup + CORS preflight.
That could shave off a few 100ms extra.
Is there any reason for that?
Note: I'm using disableStream=true as on Chrome, running with disableStream=false (default) it will make the range requests wait for the full PDF to be downloaded.
Thank you!

I have noticed when the server does support ranges after reading the HTTP headers the stream is canceled (with disableStream=true), then range requests are made.

Yes, that's the intended behaviour with disableStream = true set.

I was wondering why not keep on reading the first chunk worth of data right after reading the headers?

Because that would significantly complicate the overall implementation, and could also (possibly) lead to issues with the initial request not actually being aborted as intended (or in time) in all cases depending on e.g. the PDF file-size and the chunk-size returned via streaming. It's actually quite easy to imagine how something like that may end up "breaking" the disableAutoFetch option in various ways, or at least make its behaviour inconsistent.

Note: I'm using disableStream=true as on Chrome, running with disableStream=false (default) it will make the range requests wait for the full PDF to be downloaded.

Please note that the general recommendation is to always let streaming be enabled, since that will generally lead to the best overall performance.
Note also that in that default case, with disableStream = false set, there shouldn't normally even be any range requests used.

Finally, please note that as-is this issue is a little "light" on the details to be easily actionable.
When opening an issue, please provide all of the information requested in https://github.com/mozilla/pdf.js/blob/master/.github/ISSUE_TEMPLATE.md; please also see https://github.com/mozilla/pdf.js/blob/master/.github/CONTRIBUTING.md (emphasis mine):

If you are developing a custom solution, first check the examples at https://github.com/mozilla/pdf.js#learning and search existing issues. If this does not help, please prepare a short well-documented example that demonstrates the problem and make it accessible online on your website, JS Bin, GitHub, etc. before opening a new issue or contacting us in the Matrix room -- keep in mind that just code snippets won't help us troubleshoot the problem.