Make SECRET_TOKEN random by default

I found no place where the current default value of SECRET_TOKEN is used. So I propose to make it random by default using SecureRandom.hex(32)

Thank you @maxmeyer 👍 I'm going to merge it


FormRecognizer: ModelName not found in Manage custom models of FormTrainingClient

Dear Team ,
Under manage Custom models , I was going through "Manage Custom Models Asynchronously"
However there seems to be some issue , certain properties are not found and there are errors being thrown
Eg: ModelName, Properties , etc
Code:
using Azure;
using Azure.Core;
using Azure.AI.FormRecognizer;
using Azure.AI.FormRecognizer.Training;
using System;
using System.Collections.Generic;
using System.Linq;
using System.Web;
using System.Web.UI;
using System.Web.UI.WebControls;

// List the models currently stored in the account.
AsyncPageable<CustomFormModelInfo> models = client.GetCustomModelsAsync();

await foreach (CustomFormModelInfo modelInfo in models)
{
    Console.WriteLine($"Custom Model Info:");
    Console.WriteLine($"  Model Id: {modelInfo.ModelId}");

    // These lines are the focal point of the problem:
    Console.WriteLine($"  Model name: {modelInfo.ModelName}");
    Console.WriteLine($"  Is composed model: {modelInfo.Properties.IsComposedModel}");
    // ...

    Console.WriteLine($"  Model Status: {modelInfo.Status}");
    Console.WriteLine($"  Training model started on: {modelInfo.TrainingStartedOn}");
    Console.WriteLine($"  Training model completed on: : {modelInfo.TrainingCompletedOn}");
}

Please help.

Thank you for your feedback.  Tagging and routing to the team best member able to assist.

@ShamineDsouza which version of the Form Recognizer library are you using? ModelName was introduced in package 3.1.0-beta.1 (NuGet | Changelog) so I wonder if you are targeting a different version.


Loss starts to increase during BERT model training

Hi, I'm trying to reproduce your results with the BERT model. After ~14000 training steps, loss started to increase. I tried rerun, but it didn't help me. Have you faced this problem? This situation looks similar to #3, #7.
Log:
[2020-07-28T15:25:54] Logging to logdir/bert_run/bs=6,lr=7.4e-04,bert_lr=3.0e-06,end_lr=0e0,att=1
...
[2020-07-29T13:59:21] Step 14100 stats, train: loss = 1.1323808431625366
[2020-07-29T13:59:27] Step 14100 stats, val: loss = 3.3228100538253784
...
[2020-07-29T14:08:51] Step 14200 stats, train: loss = 0.9168887138366699
[2020-07-29T14:08:57] Step 14200 stats, val: loss = 3.5443124771118164
...
[2020-07-29T14:18:30] Step 14300 stats, train: loss = 2.303567111492157
[2020-07-29T14:18:37] Step 14300 stats, val: loss = 4.652050733566284
...
[2020-07-29T14:28:01] Step 14400 stats, train: loss = 95.80101776123047
[2020-07-29T14:28:08] Step 14400 stats, val: loss =<PHONE_NUMBER>3320312

We also faced the same issue in our training. Our best guess is that it occurred because of gradient explosion. Even when you try to run the model from the previous checkpoint, you will get the same issue sometime down the line. Right now the only choice is to start training from scratch. If you solved the issue with some other techniques please do share.

@senthurRam33 I also think the problem is somewhere in gradients. I changed the loss to 'label_smooth' (see #10) and got more stable training.


Add integration test for new ORDER BY/LIMIT support in MyriaL

This should include both bagcomp and SQL syntax, and multi-attribute sort keys with varying directions.

We also need to add aggregate queries (sort by subset of grouping key).

fixed in #916


Malformed JSON

https://github.com/a7ex/xcresultparser/commit/ad453c7ba7b60c4fef555d1bbbc5c6e287ddbf89#diff-4139343d767bb586c64ef9d8663b2435008b06fed6b319f00a9a35978e310e01R65 this appears to cause malformed JSON output. Perhaps using the OSLog APIs would be better? Alternatively require an output file path.
private extension Set<String> {
    func isPathExcluded(_ path: String) -> Bool {
        print("Checking path: \(path)") // <----------------- this is the problem
        for excludedPath in self where path.contains(excludedPath) {
            return true
        }
        return false
    }
}

Can you try now? I created a 1.8.1 where I fixed the issue


[Testing] Review all modules' tests

Considering the changes in #40, this is a placeholder issue to review and update this module's test files.

Addressed in #50:

nilWriter
multiWriteCloser

Addressed in #51:

DB Model (Event.From(*event.Event))
Trace tests

Addressed in #53:

Event and Event protobuf tests
Event level tests
FmtTextBuilder tests

Addressed in #55:

Added formatter tests for:

XML
JSON
Protobuf
Gob

Addressed in #57:

Updated channeled logger tests
Updated LoggerConfig tests

Addressed in #59:

Rewritten logger.go tests

Addressed in #60:

Removed pointer deref in logger_test.go
Rewriting multilog_test.go, first part

Addressed in #61:

Added new multiLogger tests

Addressed in #63:

Added remaining Logger printer tests to print_test.go

Addressed in #64:

Added all multiLogger print tests to print_test.go

Addressed in #65:

Added all stdLogger print tests to print_test.go
Added remaining nilLogger print tests to print_test.go

Addressed in #66:

bazel run //:gazelle --  to fix build files for these changes

Addressed in #69:

Added store/db/mysql/mysql_test.go

Addressed in #70:

Added store/db/postgres/postgres_test.go

Addressed in #71:

Added store/db/mongo/mongo_test.go

Addressed in #72:

Added tests to grpc/address/address_test.go

Addressed in #73:

Finished tests in grpc/address/address_test.go

Addressed in #76:

Finished tests in grpc/server/conf_test.go

Addressed in #80:

Added tests in grpc/server/timing_test.go

Addressed in #81:

Finished tests in grpc/server/timing_test.go

Addressed in #82:

Finished tests in grpc/server/logging_test.go

Addressed in #83:

Added tests in grpc/client/client_test.go

Addressed in #85:

Added more tests to grpc/client/client_test.go

Addressed in #86:

Added more tests to grpc/client/client_test.go

Addressed in #87:

Added more tests to grpc/client/client_test.go

Addressed in #88:

Added tests to grpc/client/conf_test.go

Addressed in #89:

Added more tests to grpc/client/conf_test.go

Addressed in #90:

Added more tests to grpc/client/conf_test.go

Addressed in #92:

Added more tests to grpc/client/conf_test.go

Addressed in #93:

Added tests to grpc/client/backoff_test.go

Addressed in #95:

Added more tests to grpc/client/backoff_test.go

Addressed in #96:

Added more tests to grpc/client/backoff_test.go

Addressed in #97:

Added remaining tests to grpc/client/backoff_test.go

Addressed in #98:

Added tests to grpc/client/logging_test.go

Addressed in #99:

Added tests to grpc/client/logging_test.go

Addressed in #100:

Finished tests in grpc/client/logging_test.go

Addressed in #101:

Added tests to grpc/client/timing_test.go

Addressed in #102:

Retouched tests to grpc/client/backoff_test.go
Shaved off execution time for end-to-end tests in grpc/client/client_test.go

Addressed in #103:

Retouched tests in grpc/client/client_test.go
Retouched tests in grpc/client/conf_test.go

Addressed in #104:

Retouched tests in grpc/server/server_test.go

Addressed in #105:

Retouched tests in grpc/server/logging_test.go
Retouched tests in grpc/server/timing_test.go

Addressed in #106:

Reviewed tests in store/db/*, when the needed (E2E tests') environment variables aren't set, for the tests not to panic

Completed writing tests for all modules in the library, with 95.63% coverage.


chore(cargo): update homepage to repository

Change homepage key to instead use the repository key for correctly labeling/pointing to the GitHub repo.
This makes location of the source code easier to see Crates.io. 🙂

@Foorack Thanks you!


Possible minor typo on searching a dataset in Azure Purview

Items 2 and 3 of section Get started with lineage of the page read:

Select your Azure Purview account from the list, and then select Launch purview account from the Overview page.
On the Azure Purview Home page, search for a dataset name or the process name such as ADF Copy or Data Flow activity. And then press Enter.

But, I think, after going to Purview Account page, you need to first click on the Open Purview Studio link on the right pane to go to Purview Studio page - and then search for a dataset
Purview Home Page: This page does not have search bar for searching assets in your catalog. The next screen (Purview Studio page) has the search bar we are talking (in item 3) about.

Purview Studio page to search an asset in your catalog:

Thanks for the feedback! We are taking a look into this and will get back to you soon.

@srazasyed
The PR for the fix has been created and it will be merged soon. Thanks again for pointing this out, I am closing the issue based on this update, please let us know if there is something else that we can help you with.


str.h: Add missing close C-style comment

Whoops! Missed that, I need to make sure I always build before committing.
Thanks!


Update startup scripts to use "gitea" instead of "gogs"

Subject says it all

Will be fixed by merging https://github.com/go-gitea/gitea/pull/103


Discord channel

Can anyone provide me link of discord channel

https://discord.gg/CxxhNyrj

KODI Addon Discord

.

.

..


[BUG] spark.eventLog.enable and spark.eventLog.dir not working

Description
Please provide a clear and concise description of the issue you are encountering, and a reproduction of your configuration.
If your request is for a new feature, please use the Feature request template.

[ ] ✋ I have searched the open/closed issues and my issue is not listed.

Reproduction Code [Required]
  hadoopConf:
    # EMRFS filesystem
    fs.s3.customAWSCredentialsProvider: com.amazonaws.auth.WebIdentityTokenCredentialsProvider
    fs.s3.impl: org.apache.hadoop.fs.s3a.S3AFileSystem
    fs.s3a.impl: org.apache.hadoop.fs.s3a.S3AFileSystem
    fs.s3a.endpoint: s3.us-east-1.amazonaws.com
    fs.s3.buffer.dir: /mnt/s3
    fs.s3.getObject.initialSocketTimeoutMilliseconds: "2000"
    mapreduce.fileoutputcommitter.algorithm.version.emr_internal_use_only.EmrFileSystem: "2"
    mapreduce.fileoutputcommitter.cleanup-failures.ignored.emr_internal_use_only.EmrFileSystem: "true"
  sparkConf:
    # Required for EMR Runtime
    spark.driver.extraClassPath: /usr/share/aws/aws-java-sdk-v2/*:/usr/lib/hudi/*:/usr/lib/hadoop-lzo/lib/*:/usr/lib/hadoop/hadoop-aws.jar:/usr/share/aws/aws-java-sdk/*:/usr/share/aws/emr/emrfs/conf:/usr/share/aws/emr/emrfs/lib/*:/usr/share/aws/emr/emrfs/auxlib/*:/usr/share/aws/emr/security/conf:/usr/share/aws/emr/security/lib/*:/usr/share/aws/hmclient/lib/aws-glue-datacatalog-spark-client.jar:/usr/share/java/Hive-JSON-Serde/hive-openx-serde.jar:/usr/share/aws/sagemaker-spark-sdk/lib/sagemaker-spark-sdk.jar:/home/hadoop/extrajars/*
    spark.driver.extraLibraryPath: /usr/share/aws/aws-java-sdk-v2/*:/usr/lib/hudi/*:/usr/lib/hadoop/lib/native:/usr/lib/hadoop-lzo/lib/native:/docker/usr/lib/hadoop/lib/native:/docker/usr/lib/hadoop-lzo/lib/native
    spark.executor.extraClassPath: /usr/share/aws/aws-java-sdk-v2/*:/usr/lib/hudi/*:/usr/lib/hadoop-lzo/lib/*:/usr/lib/hadoop/hadoop-aws.jar:/usr/share/aws/aws-java-sdk/*:/usr/share/aws/emr/emrfs/conf:/usr/share/aws/emr/emrfs/lib/*:/usr/share/aws/emr/emrfs/auxlib/*:/usr/share/aws/emr/security/conf:/usr/share/aws/emr/security/lib/*:/usr/share/aws/hmclient/lib/aws-glue-datacatalog-spark-client.jar:/usr/share/java/Hive-JSON-Serde/hive-openx-serde.jar:/usr/share/aws/sagemaker-spark-sdk/lib/sagemaker-spark-sdk.jar:/home/hadoop/extrajars/*
    spark.executor.extraLibraryPath: /usr/share/aws/aws-java-sdk-v2/*:/usr/lib/hudi/*:/usr/lib/hadoop/lib/native:/usr/lib/hadoop-lzo/lib/native:/docker/usr/lib/hadoop/lib/native:/docker/usr/lib/hadoop-lzo/lib/native
    spark.hadoop.hive.metastore.client.factory.class: com.amazonaws.glue.catalog.metastore.AWSGlueDataCatalogHiveClientFactory
    # History logs
    spark.eventLog.dir: s3://abc/def/
    spark.eventLog.enable: "true"

Steps to reproduce the behavior:
Expected behavior
It will produce a log file at s3://abc/def/
Actual behavior
nothing
Environment & Versions

Spark Operator App version: v1beta2-1.3.8-3.1.1-amzn-4
Helm Chart Version: spark-operator-7.0.0
Kubernetes Version: AWS EKS 1.29.0
Apache Spark version: 3.5.0

Two items of note:
1- Try using s3a:// rather than s3://
2- Try adding the following to your sparkConf: spark.eventLog.logBlockUpdates.enabled: "true"

Two items of note: 1- Try using s3a:// rather than s3:// 2- Try adding the following to your sparkConf: spark.eventLog.logBlockUpdates.enabled: "true"

not working.

@ahululu Make sure webhook is enabled so hadoop/spark conf can be mounted as configmap. And could you provide detailed error message about event log not working?


TableView Cell quick datasource change

Hi I use kingfisher in a tableview cell. Id I quickly switch the datasource and some image are wrong. I guess it's because the NSURL get wasn't finished before the the datasource switch and therefore sets the image on the wrong cell.
as you can see here some images for persons are actually organisations

here is how I set the image on the cell in the `layoutSubviews` of the `UITableViewCell`
if let newURL = mainProfile?.imageURL {
            self.cellImage.kf_setImageWithURL(NSURL(string: newURL)!, placeholderImage: UIImage(named: "no photo"))
        } else {
            self.cellImage.image = UIImage(named: "no photo")
        }

Kingfisher will link your url to the image when using kf_setImageWithURL methods. When the image loading finished, there is a check on whether the url of downloaded image matches the target url. The image will be set only when the two urls match. So I guess it is probably not a Kingfisher issue.
The reason might be your cells of organization are reused in the persons tab, without cellImage updated (your layoutSubviews not get called in these two cells).

Strange I force the layoutSubviews in the cellForIndexpath. This only happens when the datasource changes while the view is scrolling

I guess I know why.
self.cellImage.image = UIImage(named: "no photo") it will not set the under-hood url for Kingfisher.
Would please try to change this line to:
self.cellImage.kf_setImageWithURL(NSURL(string: "")!, placeholderImage: UIImage(named: "no photo"))

and have a try to see the result?

I see! makes sense I will try it. I killed the scroll before switching the datasource and it seems like it resolved the problem. But this suggestion makes sense

@wieseljonas Hi.  :)
How's going on this?

@onevcat  Sorry! It's working to perfection! thanks a lot


Add WhiteSource config to exclude Docusaurus Dev Dependencies

Description
The following WhiteSource config changes were made to the project ...

"configMode": "LOCAL" added to .whitesource
whitesource.config added to project root
**/website/node_modules/** added to whitesource.config

This PR resolves the following issues ...

Resolves #1
Resolves #2
Resolves #3
Resolves #4
Resolves #5
Resolves #6
Resolves #7
Resolves #8

LGTM!

Hi @maoo - I have updated the package-lock.json to the latest version and updated the ODP documentation URL. It would be great if you could review, accept and merge as appropriate.


.Net Core 2.1 for Proxy

I am trying to use Proxy package (https://github.com/aspnet/Proxy), but get error about AddProxy is not defined. See details from here: https://stackoverflow.com/questions/42000362/creating-a-proxy-to-another-web-api-with-asp-net-core
Then I tried to compile the package from source codes. Add get an error about
Severity	Code	Description	Project	File	Line	Suppression State
Error		The current .NET SDK does not support targeting .NET Core 2.1.  Either target .NET Core 2.0 or lower, or use a version of the .NET SDK that supports .NET Core 2.1.	Microsoft.AspNetCore.Proxy.Samples	C:\Program Files\dotnet\sdk\2.1.4\Sdks\Microsoft.NET.Sdk\build\Microsoft.NET.TargetFrameworkInference.targets	135

Proxy is an unsupported experiment, please don't use it.

That notice should probably be added to the Readme on the Proxy repo

@byzheng The extension method for the proxy middleware was actually improperly named AddProxy. The proxy middleware is a terminal middleware and our convention for that is to prefix with Run instead of Add. Which is all just a long way of saying AddProxy was changed to RunProxy
https://github.com/aspnet/Proxy/blob/f127246246be358b3aa8c1b7c197ff496854dd08/src/Microsoft.AspNetCore.Proxy/ProxyExtensions.cs#L15-L20

@Tratcher - You say, "Proxy is an unsupported experiment, please don't use it.".
Does this indicate a failed experiment? Is there a reason it should not be used other than being unsupported?

@Tratcher - Fair enough, no worries. I assume there will be no official release anytime soon?

@nicbavetta there is nothing planned at this time as far as the Proxy is concerned.

Proxy is very useful to bridge with a spa project which enabled SSR. I deployed spa and web containers  separately, the web accepted and handled the request which is for /api* and, proxied the request which is not for /api* to the spa container.


Added default headers for search calls (netiquette)

I added some HTTP headers for cleaner requests on search and to be more conform to "be nice on the web".

Awesome, thank you very much.


Wrong session appears in browser.

When multiple sessions are running in different browsers, the session in one browser is sometimes replaced with that from another, and hence wrong, browser. The user may be different and not authenticated.

I made some  mods on 0.4.21 development but abandoned those.

Fixed now.


Generate material setup using ng add fails

Bug, feature request, or proposal:
Bug
What is the expected behavior?
As @jelbourn was presenting yesterday on stage at ngconf, I've tried to install the typical material setup using ng add. This should have resulted in an updated angular.json file, index.html, etc.
What is the current behavior?
Running ng add @angular/material fails with the following 2 lines:
Installing packages for tooling via npm.
Cannot read property 'includes' of undefined

What are the steps to reproduce?
ng new myapp
cd myapp
npm i @angular/material@next @angular/cdk@next --save
ng add @angular/material

Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular CLI: 6.0.0-rc.5
@angular/cdk                      6.0.0-rc.12
@angular/material                 6.0.0-rc.12
Is there anything else we should know?
I like your stuff :)

some issue

When i do:
npm install --save @angular/material @angular/cdk
it installs below:

<EMAIL_ADDRESS><EMAIL_ADDRESS>
Then, as per above solutions:
I do:
ng add @angular/material
it throws as below:
Installing packages for tooling via npm.
Cannot read property 'startTag' of undefined
NPM Version: 6.1.0

ng add<EMAIL_ADDRESS><----------- This worked for me

I am also facing the issue when I tried:
ng add @progress/kendo-angular-dropdowns
It installed below:
"@progress/kendo-angular-dropdowns": "^3.4.2"
But, at the end it throws as below:

Installed packages for tooling via npm.
Cannot read property 'includes' of undefined

Angular CLI: 7.3.0
Node: 10.11.0
OS: win32 x64
Angular: 7.2.3
NPM Version: 6.4.1


Possible vulnerability in spec

When binding:

200 OK MUST be returned if the binding already exists and the requested parameters are identical to the existing binding. The expected response body is below.

The response body must be valid JSON (at minimum {}) and supports several non-mandatory fields, including credentials.
The spec isn't explicit here, so it's not unreasonable that an implementor might conclude that the response body for this scenario should include credentials. This, however, would represent a severe vulnerability.
All that would ever be required to steal credentials from an existing binding would be to replay the original binding request.
Should the spec explicitly state that the 200 response must not include credentials?

This isn't fundamentally different from a GET is it? I would think both would be authenticated to protect it.
-Doug
Sent from my iPhone

On Jul 28, 2017, at 8:36 AM, Kent Rancourt<EMAIL_ADDRESS>wrote:
When binding:
200 OK MUST be returned if the binding already exists and the requested parameters are identical to the existing binding. The expected response body is below.
The response body must be valid JSON (at minimum {}) and supports several non-mandatory fields, including credentials.
The spec isn't explicit here, so it's not unreasonable that an implementor might conclude that the response body for this scenario should include credentials. This, however, would represent a severe vulnerability.
All that would ever be required to steal credentials from an existing binding would be to replay the original binding request.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

This isn't fundamentally different from a GET is it?

Fundamentally, no. But unless I'm blind (which is a possibility, I will admit), the spec doesn't include a GET for bindings.

would think both would be authenticated to protect it.

Authentication only establishes identity. It makes no assertion about permissions. (That's authorization, obviously.)
In the absence of any sort of authorization model, unless this gap in the spec is closed, nothing stops one authenticated app that simply knows the right instanceID and serviceID from making a PUT request that will effectively steal the credentials from an existing binding that another app has created.

I am not sure re: get, I think we have been underestimating the complexity.
If you have an async op, what does get return?
On Fri, Jul 28, 2017 at 3:08 PM Kent Rancourt<EMAIL_ADDRESS>wrote:

This isn't fundamentally different from a GET is it?
Fundamentally, no. But unless I'm blind (which is a possibility, I will
admit), the spec doesn't include a GET for bindings.
would think both would be authenticated to protect it.
Authentication only establishes identity. It makes no assertion about
permissions. (That's authorization, obviously.)
In the absence of any sort of authorization model, unless this gap in the
spec is closed, nothing stops one authenticated app that simply knows the
right instanceID and serviceID from making a PUT request that will
effectively steal the credentials from an existing binding that another app
has created.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/openservicebrokerapi/servicebroker/issues/282#issuecomment-318738136,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWXmKjKuuLsb2GGWPt0aqdjz7FGD02Jks5sSjG5gaJpZM4Omwi4
.

If you have an async op, what does get return?

I know it may be on the horizon, but async binding isn't currently in the spec, is it?
But, with certainty, the current version of the spec can easily be interpreted by a broker author in a way that would cause this vulnerability to manifest.

sorry - I wasn't clear. My point was that we're in the process of adding GET and so I would think we'd handle the returning of the metadata the same way.  In particular, we talked about how in some cases the broker may choose to return a subset of the data (or even none at all, or not even support GET).  So, once we add GET support we just need to clarify that the response to a duplicate binding request may actually be empty even though it does return a 200 - if a GET isn't support or returns an empty json.  But this is just my quick response with minimal thinking :-)   I'd like to wait until we have GET in there and see if we can make 'em consistent.

@krancour I take your point that a broker could return credentials again that were returned in a previous identical binding request. In most use cases we know of, brokers probably shouldn't do that.
As mentioned, we have an open issue that is investigating adding GET endpoints (for service instances and bindings) to the spec ( #159 ). We're also considering adding an update bindings endpoint ( #123 ) that may have security risks too.
@pmorie I think the latest thinking regarding what a broker should return during an async binding is that the GET endpoint will return 404 until the binding is ready. The catalog metadata will have a binding_gettable: true flag (or something similar) so that platforms know to distinguish between "endpoint not supported" and "resource not ready yet i.e. not found". But we can continue the discussion here on #159.

@mattmcneeney I might be mixing up threads but at the f2f didn't we talk about how a GET would return a non-404 while processing an async request? My concern with a 404 is that you can't tell whether the resource is "in progress and not ready" vs "I have no idea what you're talking about".  From a quick search I've seen some people advocating that a "202 Accepted" be returned since part of its description is "The request has been accepted for processing, but the processing has not been completed" - which seems to sort of fit.

Ah, OK. We should probably revisit this asap then before we get round to adding that bit of logic since this is in validation through implementation. Let's continue this discussion in #159.

Ok... future plans to (optionally) support GET binding aside... there is already an issue. The spec says if you receive a bind request identical to a previous bind request (a PUT, fwiw), you respond with a 200. It goes on to describe what the response looks like...
But it does not differentiate at all between the response to an original binding request with a 201 response vs. a repeat binding request with a 200 response. The question of whether the body of the 200 response should be identical to the body of the original 201 response is therefore left to the imagination of the implementor.
Are we confident that every implementor will be cognizant of the security considerations here, without those considerations having received even a passing mention in the spec?

@krancour it's always better to be safe than sorry, and GET endpoints aside (where we will probably document these security concerns), the text you're referring to may not be changed in that PR so I think it's a good idea to tackle this now.
Would you like to submit a PR with a draft of the change?

You got it.

@krancour are you working on a PR for this? I'm wondering if there is a design discussion needed on this during next week's f2f.

I haven't started yet. I've been in Jamaica. I can possibly start Monday... unless the consensus is that more discussion is needed.

Hey @krancour any updates on a PR? Even a very rough one would be welcome, the WG can then tidy anything up.

Taking this over with update bindings re-attempt

Closing due to inactivity.


[5.7] Make sure navigator item focus styles are only applied with keyboard navigation

Rationale: Fixes a small css bug, where focus outlines are shown when mouse clicks are used, causing issues both visually, and when clicking on the edge of the item as well.
Risk: Low
Risk Detail: Minor CSS refactor on isolated item
Reward: High
Reward Details: Removes keyboard-only navigation styling when using mouse, and fixes click area of navigator items
Original PR: https://github.com/apple/swift-docc-render/pull/307
Issue: rdar://93331047
Code Reviewed By: @marinaaisa
Testing Details: Visually inspected in the browser

@swift-ci test


Reverse Engineer: allow customizing the model after it is generated, before being passed to code gen

We want a simple "seam" where folks can get the Model just before it is passed to code generation and manipulate it. This is particularly important since we are removing templating for the moment.

This is MetadataReader.GetModel(). The method is virtual and can be overwritten.

I think this item was to track how the application developer would do it, not the provider. @rowanmiller?

Ah, yes. Who are "folks"?

:smile:

Reopening for now.

I didn't undertand if templating via .cshtml is being definitely replaced for the GetModel() approach or if the @rowanmiller 's "for the moment" means it will come back on a later release.
The cshtml templating was actually a pretty nice way to enable [the unsupported] pluralization: https://empiricalthoughts.wordpress.com/2015/09/12/entity-framework-7-database-model-pluralization-part-22/

We have decided to leave the choice of a template based code-gen technology open for now. It is true that Razor enabled plugging in your own pluralization logic... after all you can do pretty much anything with it, but it also leads to complicated templates that mix concerns like this with the actual code generation. One of the ideas we decided to explore is to provide a hook that allows any customization of the model (covered by this issue) plus very simple code gen at the end that just binds to the resulting model and focuses only on what code to generate and its formatting.

Closing in favor of https://github.com/aspnet/EntityFramework/issues/4038


Create Kiswahili / Swahili Version

Just wanted to add Kiswahili version of dates.
For Swahili speakers out there 😃

It's failing due to environment variable.
How do i go about solving this?

This is my FIRST successful PR.
YaaaaaaY!


PNA/PSA extern restrictions

There's very likely a hardware-centric reason as to why the restrictions specified in:
https://p4.org/p4-spec/docs/pna-working-draft-html-version.html#sec-extern-restrictions
exist. If someone could educate me on what that is, I would appreciate it.
Of course in s/ware it doesnt make sense to have such restrictions - but to write a "portable P4 program" we'll need to adhere to specified restrictions.

This PR is instended to address this issue. Please read it and see if it is missing anything you were hoping for: https://github.com/p4lang/pna/pull/127

I dont think #127 resolves this. It was more a question, as an example: Why is checksum extern only applicable on MainParser and MainDeparser. See Table 2 in the doc.

I believe it is accurate to say that the primary reason it was documented that way was because PSA defines it that way, which goes back to v1model, which is probably heavily influence by Tofino.
The proposed PR removes that restriction.  Is that not what you were hoping for?

@jafingerhut, it may provide the answer - but i am not following how making headers r/w in the deparser maps to that referenced table. I think my question is a lot more basic: Why those restrictions in that table? From a s/w pov it doesnt seem to make a lot of sense but there may be reasons given how h/w blocks are built.

My answer: "I believe it is accurate to say that the primary reason it was documented that way was because PSA defines it that way, which goes back to v1model, which is probably heavily influence by Tofino."
Does that answer make sense?
If we remove the restriction in that table where the Checksum and InternetChecksum externs can be instantiated, is that what you are hoping will change?  Because the PR does change that table in that way.

Does the

You ask: "Why those restrictions in that table?"
My answer: "I believe it is accurate to say that the primary reason it was documented that way was because PSA defines it that way, which goes back to v1model, which is probably heavily influence by Tofino."
Does that answer make sense?

Yes - i was more asking on the "why" is it so. Probably Tofino, but what is feature or limitation that makes it so.

If we remove the restriction in that table where the Checksum and InternetChecksum externs can be instantiated, is that what you are hoping will change? Because the PR does change that table in that way.

You are right - let me close this.


Make the owner for items configurable

The owner name is now hardcoded: https://github.com/xmidt-org/hecate/blob/58c1e38aff999f64ebf6084a5b9e9b121ddcbdda/main.go#L114

It'll be nice to also make the bucket name configurable. If these values are not provided through configuration, some default values should be used.


fix: copy-from-image: don't rename instead copy+delete to prevent "Invalid cross-device link" errors

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


CB-21288 Send message to event history indicating initial upscale adj…

…ustment for faster autoscaling
See detailed description in the commit message.

retest this please


fix: make db.Save() works

Codecov Report
Patch coverage has no change and project coverage change: -38.80 :warning:

Comparison is base (6da5c4a) 41.52% compared to head (0fa1f17) 2.72%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #54       +/-   ##
==========================================
- Coverage   41.52%   2.72%   -38.80%
==========================================
  Files           4       4
  Lines         472     513       +41
==========================================
- Hits          196      14      -182
- Misses        245     497      +252
+ Partials       31       2       -29

Flag
Coverage Δ

go-1.18.x
2.72% <0.00%> (-38.80%)
:arrow_down:

go-1.19.x
2.72% <0.00%> (-0.24%)
:arrow_down:

go-1.20.x
2.72% <0.00%> (-38.80%)
:arrow_down:

integration
?

macOS
?

ubuntu
2.72% <0.00%> (-35.84%)
:arrow_down:

unit
2.72% <0.00%> (-0.24%)
:arrow_down:

windows
?

ydb-22.5
?

ydb-23.1
?

ydb-23.2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

internal/dialect/dialect.go
0.00% <0.00%> (-50.00%)
:arrow_down:

... and 2 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


issue with babel when use WithStyle

When I do yarn test it fails with bellow error if use WithStyle

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
yarn test fail with error

Expected Behavior 🤔
yarn test should be pass

Steps to Reproduce 🕹
export any component using *WithStyle

Steps:

Context 🔦

Your Environment 🌎

----------tsconfig.js ---------------
{
"extends": "ts-config-single-spa",
"compilerOptions": {
"jsx": "react"
},
"include": [
"src/**/*"
]
}
----------------  bable.config.json----------------------
{
"presets": [
"@babel/preset-env",
"@babel/preset-react",
"@babel/preset-typescript"
],
"plugins": [
[
"@babel/plugin-transform-runtime",
{
"useESModules": true,
"regenerator": false
}
]
],
"env": {
"test": {
"presets": [
[
"@babel/preset-env",
{
"targets": "current node"
}
]
]
}
}
}
--

Tech
Version

Material-UI
v4.11.0

React
v16.12.0

Browser

TypeScript
v3.8.3

etc.

"@types/jest": "^25.2.1",
"@types/react": "^16.9.32",
"@types/react-dom": "^16.9.6",
"@types/systemjs": "^6.1.0",
"@types/webpack-env": "^1.15.1",

The issue has been closed because it does not conform to our issue requirements.
Please provide a minimal reproduction test case. This would help a lot 👷 .
A live example would be perfect. This codesandbox.io template may be a good starting point. Thank you!

Hello @oliviertassinari,
Here I attach zip for source code, in which you can reproduce this issue. Here I also write steps how to use it and how to reproduce this issue.
V2.zip
it require yarn
*********  How to use it ***********
Step 01 : unzip this zip in any folder (like in folder : demo)
Step 02 : cd demo/V2
Step 03 : yarn
Step 04 : yarn add jquery
Step 05 : yarn start
Step 06 : Open new terminal and cd demo/Core
Step 07 : yarn
Step 08 : yarn start
Step 09 : Open new terminal and cd demo/Dashboard
Step 10 : yarn
Step 11 : yarn start
Step 12 : Open http://localhost:7000
You can see web page like this :

*************** How to re produce issue  ****************
Step 01 : cd Demo/Core
Step 02 : yarn test
There will be an error like (image below) and test will be fail


Filter passed into IncompleteEventPublications.resubmitIncompletePublications(…) has no effect

Today I tried to implement some custom routes to resubmit individual outstanding event publications.
I noticed, that the filter in the resubmit function has no effect.
This might fix it: https://github.com/spring-projects/spring-modulith/pull/367

Good catch and even better timing. I'll take the PR from here.


Add code to use goddady dns cloud provider

What this PR does / why we need it:
This PR provides a new DNS cloud provider: Godaddy
Which issue this PR fixes
fixes #1442
Special notes for your reviewer:
As I can't build locally using Bazel due to this error reported
./hack/update-codegen.sh
Generating deepcopy funcs
Generating clientset for certmanager:v1alpha1 at github.com/jetstack/cert-manager/pkg/client/clientset
Generating listers for certmanager:v1alpha1 at github.com/jetstack/cert-manager/pkg/client/listers
Generating informers for certmanager:v1alpha1 at github.com/jetstack/cert-manager/pkg/client/informers
/Users/dabou/Code/go-workspace/src/github.com/jetstack/cert-manager/hack/update-bazel.sh: line 34: kazel: command not found

I was not able to test the new Cloud provider on my OpenShift instance

Thank you for this PR. We're in the process of changing how we handle DNS01 providers that should make the process easier for users and us as maintainers. You can read more about how we plan to handle these here
Unfortunately, this means we will not be reviewing and accepting this PR for the moment. Once we have the webhook implementation up and running, we'll let you know how to set up and get this running.
You can follow along with our webhook implementation at PR #1443

Many thanks @DanielMorsing for your response. Will the process to migrate be described somewhere ? If I understand the new logic, when the operator will receive a challenge request, then it will call the associated DNS provider [1]. Why do you use then a webhook ?
[1] https://github.com/jetstack/cert-manager/blob/039ef496c4af0ab46d5e919d1c9184bc0a1b80ba/pkg/acme/webhook/sample/cloudflare/cloudflare.go#L95:18

hey @cmoulliard,
At first glance, the webhook way of changing DNS records looks like a roundabout way of doing this, but it decouples cert-manager from DNS operators.
If you have an internal DNS service, the only way of adding support for it would be to fork cert-manager. Even if you're contributing providers back to the project like you are (and we appreciate this a lot!), you'd have to wait for a release until being able to use it. This decoupling will allow faster turnaround on the DNS providers and allows the team to focus more on features and bugfixes.
The ultimate goal is that people can write their own DNS webhooks without involving the core cert-manager team. Once the webhook lands, we'll help people with outstanding DNS provider PRs migrate to webhooks.

First of all, thanks for this pull request and for your time working on it.
As mentioned in the above comment, we have added a DNS01 provider extension
mechanism to cert-manager that allows out-of-tree DNS01 providers to be
built, including an example repository
to act as a template for how to implement your own providers.
At this time, we don't have the bandwidth nor means to maintain and automatically
test this DNS01 provider, and so I'm going to close this PR and ask that you
port your changes over to the new webhook example format in order to allow
anyone to use your new provider without needing to have it accepted into
the cert-manager codebase.
If in future your plugin has a wide user base and sufficient testing, we
may consider accepting it into the cert-manager project. The exact process
for this is still to be worked out, and we'd like to work with the community
to determine how we should best publish plugins for users :smile:
Again, thank you for your time, and I look forward to hearing your feedback
on the new DNS provider plugin feature!


[SPARK-17339][SPARKR][CORE] Fix some R tests and use Path.toUri in SparkContext for Windows paths in SparkR

What changes were proposed in this pull request?
This PR fixes the Windows path issues in several APIs. Please refer https://issues.apache.org/jira/browse/SPARK-17339 for more details.
How was this patch tested?
Tests via AppVeyor CI - https://ci.appveyor.com/project/HyukjinKwon/spark/build/82-SPARK-17339-fix-r
Also, manually,

I would like to make sure that this pass both AppVeyor CI for SparkR and Jenkins ones. So, I will remove [WIP] if the tests go okay for both.

Test build #64936 has started for PR 14960 at commit f42c182.

Test build #64936 has finished for PR 14960 at commit f42c182.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64936/
Test PASSed.

Test build #64972 has started for PR 14960 at commit 790d5b2.

Yup, finally we got a green - https://ci.appveyor.com/project/HyukjinKwon/spark/build/77-SPARK-17339-fix-r!

Test build #64972 has finished for PR 14960 at commit 790d5b2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64972/
Test PASSed.

Thanks @HyukjinKwon - LGTM but for a minor comment I had inline.

I found we can replace FileSystem.get in SparkContext#hadoopFile and SparkContext.newAPIHadoopFile with FileSystem.getLocal like SparkContext#hadoopRDD so once they are replaced, we need not discuss the case of comma-separated file list.
@HyukjinKwon You can replace them in this PR or not do it.

@sarutak Ah, I will do this here. Thanks!

I re-run the test after this commit - https://ci.appveyor.com/project/HyukjinKwon/spark/build/81-SPARK-17339-fix-r
Let's wait and see :)

Test build #65026 has started for PR 14960 at commit 41aaaf1.

seems to fail to build:
[INFO] Compiling 468 Scala sources and 74 Java sources to C:\projects\spark\core\target\scala-2.11\classes...
[ERROR] C:\projects\spark\core\src\main\scala\org\apache\spark\SparkContext.scala:995: type mismatch;
 found   : org.apache.spark.SparkConf
 required: org.apache.hadoop.conf.Configuration
[ERROR]     FileSystem.getLocal(conf)

Yeap, I quickly fixed and re-ran :). Thanks!

Looks like it passed ! LGTM pending our Jenkins tests

Test build #65026 has finished for PR 14960 at commit 41aaaf1.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65026/
Test FAILed.

retest this please

Test build #65030 has started for PR 14960 at commit 41aaaf1.

Test build #65030 has finished for PR 14960 at commit 41aaaf1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65030/
Test PASSed.

Merged build finished. Test PASSed.

LGTM. Merging this into master and branch-2.0. Thanks @HyukjinKwon !
And thanks @shivaram  and @felixcheung for the review !

I noticed this PR is not able to be merged cleanly to branch-2.0.
@HyukjinKwon If you would like to merge this into branch-2.0, please feel free to open another PR.

Sure! I will tomorrow.


Added support for VS2017

Hi MJP,
I added sln/proj files for vs2017 and changed HosekSky to be compiled from src (like you've done in another project).  Also added a pragma for vs2013 to compile.
Thanks for making these sources available, and for the great series on baking and SGs!
Boni

Thank you for the pull request, looks great!


Empty "cleos get actions"

I've created successful transaction with cleos transfer test1 eosio  "2.0000 SYS"
But cleos get actions eosio && cleos get actions test1 returns blank table.
Any thoughts?

The history_plugin has to be enabled and configured with --filter-on for get actions to work.


week 2 hw

Reviewed! Please include a link to the pull request in your document for the next time. Meets Expectations. See Google doc for more comments.


Amazon Price Tracker

Description
Create a script that allows users to input an Amazon product URL and track its price over time. The script could periodically scrape the product's price and send notifications to the user when the price drops below a certain threshold.
Fixes #2882

Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Documentation Update

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md
[x] My documentation follows Template for README.md
[x] I have added the project meta data in the PR template.
[x] I have created the requirements.txt file if needed.

Project Metadata
If there is no-file/nothing to fill the below fields with, then type: none
Example: If no requirements.txt needed/present, then type none in Requirments.
Category:

[ ] Calculators
[ ] AI/ML
[x] Scrappers
[ ] Social_Media
[ ] PDF
[ ] Image_Processing
[ ] Video_Processing
[ ] Games
[ ] Networking
[ ] OS_Utilities
[ ] Automation
[ ] Cryptography
[ ] Computer_Vision
[ ] Fun
[ ] Others

Title: script.py
Folder: Amazon Price Tracker
Requirements: <type the name of text file containing the required to install python packages, type None if no file required>
Script: <Enter the name of the .py file (The main entry point of the program)>
Arguments: <enter any arguments that the script needs but - separeted like: h-c-m>
Contributor: <Enter your Github handle/username without url>
Description: <Enter a one line description that describes your script. Also, explain the arguments usage here>

@avinashkranjan please merge this


Move 'ConstExtract' request from TypeCheckRequest into its own component's collection of requests.

This helps make sure that components that do not genuinely do not depend on libSwiftConstExtract do not need to actually have a dependency edge to it.

@swift-ci test

@swift-ci test

@swift-ci test

@swift-ci test

@swift-ci test macOS platform

@swift-ci test Linux


IE9 - update to template list not visible to callbacks

Is this a known issue?
If you go here:
http://www.ag-grid.com/angular-grid-cell-template/index.php
With IE, then from Dev Tools you select IE9, it will stop because of 'long running script', then it will crash.
Just curios if IE9 is not supported, or is this a defect?
I love your grid, implemented in my webapp, then found it doesn't play well with IE9 in this case :-(
(I also opened a StackOverflow thread: http://stackoverflow.com/questions/33295932/ie9-update-to-template-list-not-visible-to-callbacks )

It seems that on IE9 there's a loop that goes too many times, and even if a template is used by 22 cells, there are 60k callbacks waiting for it.
Trying to debug it now.

It seems that in IE9, TemplateService.templateCache update is not visible to all code using it.
The infinite loop is:
getTemplate, (wait in line until the call ends), call ends, template added to cache, run callback, callback doesn't see the template in templateCache, creates another callback, adds it to the queue, and so on.

I eventually found the issue. In IE9, the template is on responseText inside the response object.
In IE10+ and all other browsers it's on response.
So in order to fix it, in the above code, instead of:
 // response success, so process it
 this.templateCache[url] = httpResult.response;

I added:
 // response success, so process it
 //in IE9 the response is in - responseText
 this.templateCache[url] = httpResult.response || httpResult.responseText;

For future reference, adding the answer here. Had nothing to do with Angular. :)

Line 3451 in ag-grid.js.

great thanks!!!
i was in the middle of trying to figure it out

sorry, i'll try and stop doing what you want to do just before you do it :)


ACF using RBAC roles - No automatic way to obtain params for $user->can()

Hi,
It would be useful to have an automatic way to pass post/get/any parameters to an ACF filter when it is checking rbac roles (please, look the comments):
    public function behaviors()
    {
        return [
            'acf' => [
                'class' => AccessControl::className(),
                'rules' => [
                    [
                        'allow' => true,
                        'actions' => ['view'],
                         // current implementation of roles:
                        'roles' => ['manageOwnOrganization'],
                        // what I propose:
                        'roles' => [
                               'manageOwnOrganization' => ['id'], // or ['get' => 'id'] if I want a specific verb
                        ],
                    ],

And in https://github.com/yiisoft/yii2/blob/master/framework/filters/AccessRule.php#L151 those values could be get and sent to $user->can() as its second parameter... something like $user->can('manageOwnOrganization', ['id' => 9]). Where 9 is the $_REQUEST['id'] or $_GET['id'] if using the  ['get' => 'id'] option. If nothing is found it would send a null value and the programmer would manage it.
Use case
I have a rbac rule that verify if the logged user organization is the same that he is trying to manage. The user organization I can obtain from $user->identity, but the organization id comes from get or post data. In so many actions I have to make my own Yii::$app->user->can('manageOwnOrg', ['id' => $id]) to perform the correct filtering but it turns acf rules virtually unuseful to those cases.
It seems a very common use case for rbac/acf. I must confess I am not sure if we have another automatic way to get those parameters, but I couldn't find anyone.
Additional info

Q
A

Yii version
2.0.10

PHP version
7.0.1

Operating system
Mint 18

I'm against of this change.
Permissions checks with parameters is something more complicated, putting them inside a controller is a perfectly fine solution.
Here is an example.
Controller's action:
public function actionView($id)
{
    $model = $this->findModel($id);
    if (!Yii::$app->user->can('entry.view', ['model' => $model])) {
        throw new ForbiddenHttpException("Sorry, you don't have permission to view this entry.");
    }
    // The rest of the code
}

/**
 * @param integer $id
 * @return Entry
 * @throws NotFoundHttpException
 */
protected function findModel($id)
{
    $model = Entry::findOne($id);
    if ($model !== null) {
        return $model;
    } else {
        throw new NotFoundHttpException('This entry does not exist');
    }
}

RBAC Rule:
<?php

namespace frontend\rules\entries;

use yii\rbac\Rule;

class ViewRule extends Rule
{
    public $name = 'entry.view';

    public function execute($user, $item, $params)
    {
        /* @var $model \common\models\Entry */
        $model = $params['model'];

        return $model->is_active && !$model->isExpired();
    }
}

Early on I thought that writing checks for permissions with rules requiring parameters is inconsistent with ACF and therefore incorrect too.
But:

Usually you need to find the model and throw according 404 Not Found expection if it was not found first and only then throw 403 Forbidden expection in case of lack of needed permissions. Where we need to write 404 Not Found check in this approach? Putting this inside a RBAC rule is definetely incorrect, it's a controller's action job no doubt. With additional separate callback you lose integrity of the action and it's not absolutely clear what it does.
Checks can be more complicated, for example if you have admin permissions:

if (!Yii::$app->user->can('entry.view.all') && !Yii::$app->user->can('entry.view', ['model' => $model])) {
    throw new ForbiddenHttpException("Sorry, you don't have permission to view this entry.");
}

In this case if the user has admin role with according permission, we don't even need to further check the model to be accessible.

We can perform more intermediate actions before access check.
How to handle parameters in your approach? In this case we can just take it in usual way from controller's action parameters.

So, ACF is better to use without parameters when we need to reject request even without entering to the controllers's action on the early stage of request. Adding this feature does not bring any essential benefits. Also it can't be used in the way you wrote, I guess additional callbacks and customization will be needed and that's simply not worth implementing.

You should either move access check to controller or use AccessRule::$matchCallback.

Ok, thank you @arogachev and @klimov-paul.
I am already using access check in my controller, and this is what I want to avoid at the most since I have multiple roles and multiple permissions, some of them with rules, and it make me Repeat myself just because I have to get a parameter from post/get. I think I can do better.
However I will check the information you both provided and continue either using in controller or develop an extension to automatize this for web scenarios.
Thanks.

By the way, this is a duplicate of #7643.


Member functions cannot be converted to pointers

For example,
arc = lv.arc(scr)
a=lv.anim_t()
a.init()
a.set_exec_cb(lv.arc.set_value)

returns:
SyntaxError: Cannot convert 'function' to pointer!

See https://github.com/lvgl/lv_examples/issues/83#issuecomment-727646923

This can be worked around using lambda.
Only advantage is performance, but not sure that is worth the effort.
Closing for now.


Feature/minor port fix

fix syntax
tested on Ruby 2.2.0

thanks @matsubo for your contribution!
i think a better fix for the port issue would just be to change the README.md (in both HelloWorld and Archiving samples) to say the server runs on localhost:4567 instead of changing the implementation. The reason I say this is because if you set the port explicitly, its less clear how running the application with the -p CLI option would do. by using the default, its clear that this would override.
what do you think? if you agree, would you mind changing this in your PR, and I'll gladly accept it.

@aoberoi Agree and updated PR.
I thought Sinatra's default port had been changed from 4567 to 9393 but it's not.

Thanks!


Numpy.random implementations

This PR contains the implementation of different np.random.* functions.
TODO:

[x] We need to write tests for all cases, we have coverage for some but not for all.

Windows CI fails due to validation problems in 3rd party service. Will merge the PR.

Windows CI fails due to validation problems in 3rd party service. Will merge the PR.


Problem with binary write

Hi,
I have a problem with the write method on the workbook. I have this piece of very simple test-code, straight from the examples:
Meteor.methods

  export: (data) ->

    excel = new Excel('xlsx')
    workbook = excel.createWorkbook()
    worksheet = excel.createWorksheet()

    worksheet.writeToCell(0,0, 'Players leaderboard')
    workbook.addSheet('MySheet', worksheet)

    wopts = { bookType: 'xlsx', bookSST: false, type: 'binary' }

    # workbook.writeToFile("/Users/casperkaandorp/test.xlsx")
    wbout = workbook.write(wopts)

    return wbout

This doesn't work. On the console I read:
Exception while invoking method 'export' TypeError: Object [object Object] has no method 'write'
I don't get it. The writeToFile method works fine, I've seen the write-implementation but nevertheless Meteor claims not to have the write-method. Any pointers on this? Thanks and thanks for your great work!

I'm running into this same issue. I can't write my Excel file :(

I'm still running into this issue, and am not experienced enough with meteor or node yet to figure out what's causing it. I agree with @cskaandorp that I see the function for 'write' declared in the package, but it sure doesn't work.

I finally got it 'working'. So far none of the maintainers responded on this and the issue above still does not work.
This is what I did: I have downloaded this package and added it as a local package. Don't ask me why, but that got rid of the Type-error.
I verified that I did not had some older version of this package going which caused the error.
Anyway, this is not the end of it. The write function should deliver a string that needs to be converted to an ArrayBuffer so you can put it in a blob. I have seen several functions which are supposed to do it. None of them actually worked. On closer inspection there was something strange, it seemed that instead of the important bit was not returned from these examples. When I changed this, I got it to work. Here's my code (again, it runs this package locally, and in coffeescript):
  download: ->
    excel = new Excel('xlsx')
    # create a workbook
    workbook = excel.createWorkbook()
    # create a sheet on this motherfucker
    worksheet = excel.createWorksheet()
    worksheet.writeToCell(0,0, 'Some value')
    worksheet.writeToCell(0,1, 'Another Value')

    # add sheet to workbook
    workbook.addSheet('Some Sheet', worksheet)

    wopts = { bookType: 'xlsx', bookSST: false, type: 'binary' }
    wbout = workbook.write(wopts)

    s2ab = (s) ->
      buf = new ArrayBuffer(s.length)
      view = new Uint8Array(buf)
      for i in [0..s.length]
        view[i] = s.charCodeAt(i) & 0xFF
      return view # NOT RETURN buf

    return s2ab(wbout)

Client:
      Meteor.call 'download', (error, result) ->
        unless error
          console.log result
          saveAs(new Blob([result], { type: '' }), 'test.xlsx')
        else
          console.log error

Apart from the s2ab thing, I am still puzzled why this works when I add the package from local. So if anybody has some answers on this... that'd be great. Thanks,
Casper

That's super weird. It totally worked for me too... I'd love to not have a weird workaround though.

Hey guys,
Sorry to have been ignoring this for so long. Didn't keep up with the repo.
I haven't released a new version that includes the write function to atmospherejs, so that is why is was working locally but not from the published version. Update to 0.2.5 and it should work.

Thank you. I can confirm that this fixed it for me.

For me as well. Thanks from me as well! And thanks for your work.


DS-2829 Add the logo setter to the Community DTO

https://jira.duraspace.org/browse/DS-2829
That fixes potential deserialization issues.
This is covered by a test on the generated JAXB schema.
Background: I generated a REST client with wadl2java and there was an issue with the logo property of the Community DTO. That might not be the only one issue but that is a start. Pull request for branch dspace-5_x is coming...

Please, describe the issue and tell us how to reproduce it.

Hi,
the problem is:

https://demo.dspace.org/rest/communities returns JSON with some logo properties in community objects (they are null but they are there)
https://demo.dspace.org/rest/application.wadl/xsd0.xsd doesn't contain the logo property because there is no setter in the Community DTO

So I added the setter and covered this with a test that generates the JAXB schema.
Note that I am working on packaging a DSpace REST client, so I am currently patching the schema I get from the demo website before I use it to generate the client code.
On the PRs, I'm afraid the DTOs have changed from 5_x to master so that is why I picked the commit and patched it slightly. I need to rebase my 5_x PR now.

If you really want to reproduce the issue then have look at https://github.com/arnodb/dspace-rest-client, I've just patched xsd0.xsd in it, otherwise some test won't pass.

Hi @helix84 would you prefer me to log an issue somewhere in order to keep track of the issue?

Yes, that's what we normally do, we keep track of bugs in Jira (has more features than GitHub) and only to PRs here. But don't worry too much, anything that has a PR won't get lost, either.

OK, I've just signed up Jira and created https://jira.duraspace.org/browse/DS-2829.

Thank you. Can you please add the missing standard DSpace license header to the new files? Travis runs with license checks enabled, that's why the test build fails.

Hi, done. However I'm not sure what I did with the merge because there seem to be 20 commits in the PR whereas there is only one in reality.

The correct way to do this would be to checkout arnodb/rest-dto-sanity, add a commit and push to arnodb (origin). Then another commit would show up here.
You can still fix up a PR by undoing as many commits as you need (git reset --hard HEAD^) and then force-pushing.
In any case, we can just cherry-pick a single commit, so no worries: d5b4cf4

Here we are. branch resynchronized, license header added. Over to you :-).

Thank you Arnaud, I wasn't actually aware that REST/Jersey generated the wadl out of the box. I can recall a day that I was searching for how to get REST to output something akin to a WSDL, but for REST, a WADL.
I see that you have added a setter for the collection logo, however, I don't believe you could actually put the collection logo in DSpace REST. Would you mind going the extra mile, and uncomment this, and test it?  https://github.com/DSpace/DSpace/blob/77f696dad2aeae98f566e53f09780d6e070d3526/dspace-rest/src/main/java/org/dspace/rest/CollectionsResource.java#L452
// dspaceCollection.setLogo(collection.getLogo()); // TODO Add this option.
And test if you can set the collection logo. Also, thank you for adding the test case.
By the way, your other projects look interesting:
https://github.com/idmgroup/dspace-rest-client
https://github.com/idmgroup/DSpace-REST-Client-Perl
I think that lack of DSpace (REST) SDK's for languages is a barrier to people building integrations. And, at the same time, we can be refining the REST API itself. So, thanks for the help, on both fronts.

Hi Peter, yes I knew that we could generate a WADL descriptor but I was not aware that it was enabled by default. So I also discovered something. I'm doing that for my current employer.
If you need my email to discuss anything, you can dig in the commits log.
I will implement what you ask me to ASAP so that this change goes upstream seamlessly.
Note: I spotted that when I create an item, its name it not saved, only its metadata. I may report a bug soon about that.

Hi Peter, actually I don't know how to convert a REST Bitstream object into an API Bitstream object. I have just looked at addItemBitstream and it seems far from being trivial.

Okay, we can leave the setting of logo / bitstream off. Yes, non-trivial indeed.
Overall, +1


GetKeyboardState does not change the result after the first read

GetKeyboardState does not change the result after the first read
Example:
final lpKeyboardState = calloc.allocate<Uint8>(256);
final timer = Timer.periodic(const Duration(milliseconds: 250), (_) {
  GetKeyboardState(lpKeyboardState);
  print(' * Left Shift state: ${lpKeyboardState.elementAt(160).value}');
});
await Future.delayed(const Duration(seconds: 10)).whenComplete(() {
  timer.cancel();
  calloc.free(lpKeyboardState);
});

I think this is unrelated to win32. A quick search on SO suggests that you have to pump the message loop in order to get a new status. https://stackoverflow.com/questions/37142779/getkeyboardstate-cant-detect-while-i-am-pressing-the-key


oauth2 scope documentation fix

match the scope code with the written documentation

@m1schka-bdr Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

thinking about it again, it could also be that it was correct (at this position) but then it´s wrong at line 367
let me know

It should be x-* for exchange name, since the section is dedicated to topic permissions (which only apply to topic exchanges).
Thank you.

but then, as I corrected myself, everything should start with x-. should I provide another PR or do you want to leave it as it is right now?

nevermind, I just saw you corrected it in a follow up commit. thx


Support for more highlight groups

Brought up by @akthe-at  in a pull request they made. I have reworked the repo based on Folke's tokyonight
@akthe-at  if you want to give me a second pair of eyes on it, ive opened a branch tokyo-rework, if you change in your lua config for Eldritch:
{
  "eldritch-theme/eldritch-nvim",
  branch="rework-off-tokyo",
  lazy = false,
  priority = 1000,
  opts = { },
  config = function(_, opts)
    require("eldritch").setup(opts)
    vim.cmd([[colorscheme eldritch]])
  end,
}

Loading it up right now but I think your branch is rework-off-tokyo

Sorry didnt see the edit!

 This looks nice right now but is definitely a different look/feel at the moment compared with the other branch.

what do you think personally, i tried to align it more with tokyo nights patterns

this entire theme is very early in its life right now and I am totally open to a little collaboration and feedback, especially from its first users

There is something amiss with differentiating highlights. Here is tokyonight-night on a scratch/test python script:

Now for the the dev branch of eldritch for me is below this, notice the repeated cyan in a lot of places.

ok i will work on that

also ive changed the repo from eldritch-nvim to eldritch.nvim to match other nvim plugins

@akthe-at Ive pushed some updates, let me kow what you think, got rid of repetitive colors, added some darkening, I think will align more with the themes color patterns better. I still need to go through and change the highlight group for a bunch of plugins like Telescope and stuff but I think the LSP/Treesitter stufff should be good now, might need to test on a few more languages to be sure it flows well

I think things are moving along nicely! There is something still amiss when it comes to classes and their methods. I haven't had a chance to dig too deep and won't until tonight but here is what a quick glance shows:

There is a slight difference between class and method highlights before the lsp (basedpyright) kicks in and starts giving semantic tokens.

Are you referring to the blue and darker blue?

datetime.now().strftime(), the later two should match each other but not datetime in color

Ok will look into it

@akthe-at  To me im seeing datetime the "dark_cyan" color which is a more dark blue, and the now and strftime are cyan

@akthe-at  To me im seeing datetime the "dark_cyan" color which is a more dark blue, and the now and strftime are cyan

Super interesting, are you using pyright or basedpyright as an LSP in this photo? Or maybe another lsp all together?

Using basedpyright to test against what you said
Just pushed again, give that a try and tell me if you still see that

do you think its too conflicting of a color? I could change the dark cyan to something else maybe

Using basedpyright to test against what you said
Just pushed again, give that a try and tell me if you still see that

If it's still weird when I get home and check I will try to delete all my shada files, temp files, etc and double check and make sure I'm up to date on the lsp, etc. Your photo looks good and correct.

I do think that they are probably a little too close, here is gruvbox, rose pine and Tokyonight for comparison

Perhaps that pink or green from the palette? I think what draws me to this palette is that it feels like a mixture of dracula and Tokyonight

ya let me play around and see what looks good

I thought of it originally the other way around but I might like this more because the action is the bright part. I think that's fitting

OK so i got the latest commits on the development branch, all the highlights are working correctly and match yours as well. I think stuff is looking good in SQL, R, python, and htmldjango...I am not saying there isn't room to change anything but it looks a lot better than 24 hours ago...How are you feeling about it?

Couple of quick thoughts
string.documentation vs string vs string.html are all the same at the moment, not sure yet how I feel about that, I feel like I need a day of staring at the vibrant yellow text on an html page for a day of work to judge this.
Could use some color for the Icons for Dashboard.nvim (  DashboardIcon = { fg = <something, currently cyan like the words next to it>}  )

Couple of quick thoughts string.documentation vs string vs string.html are all the same at the moment, not sure yet how I feel about that, I feel like I need a day of staring at the vibrant yellow text on an html page for a day of work to judge this.
Could use some color for the Icons for Dashboard.nvim ( DashboardIcon = { fg = <something, currently cyan like the words next to it>} )

will work on this

.documentation vs string vs string.html are all the same at the moment, not sure yet how I feel about that, I feel like I need

Can you give me an example of the html with text you speak of, also dashboard icon is already set you should see it as cyan

@jacobrreed I think the dark yellow for the string.html is perfect. regular strings passed into functions as arguments and documentation strings are the same elsewhere and I think that is normal/fine. I was just thrown off when all three were the same in all spots, especially with how vibrant that was on an html page with a ton of tailwindcss inline. However, your change looks great.
Regarding the Dashboard Icons I was just seeing if you wanted the text and Icon to match, it makes sense to keep it the same as the text that accompanies it but I could also see having the icons as one of the other main core eldritch palette colors

ya let me change the dashboard icon to be the green
i think that fits bett

🔥

merged to master, thanks for the help if you find anything else let me know

Looks great! I noticed that the folke theme options like dim_inactive don't seem to actually work even though the code looks the same as tokyonight? Does it dim an inactive background for you? Do you want me to open a new issue for this?

ya cut another issue and ill look into it

@akthe-at Does it work for you with tokyo night? I personally use tint.nvim so I dont think I could tell the difference, i turned tint off and I dont see it working either. Tested with tokyonight as well

 NormalNC = { fg = c.fg, bg = options.transparent and c.none or options.dim_inactive and c.bg_dark or c.bg }, -- normal text in non-current windows

so if transparent is set it definitely wont work, but even if it is doesn't seem to make a difference

interesting...its not actually working right now on Tokyonight but definitely has in the past! This must be an upstream bug, I will file an issue there.

interesting...its not actually working right now on Tokyonight but definitely has in the past! This must be an upstream bug, I will file an issue there.

https://github.com/folke/tokyonight.nvim/issues/211

Nice find, that fix worked for me

Actually, I didn't even need to pass the background colors, just using this as my config fixed this issue.
  {
    "eldritch-theme/eldritch.nvim",
    priority = 1000,
    opts = {},
    config = function()
      require("eldritch").setup({
        dim_inactive = true,
        transparent = false,
        hide_inactive_statusline = true,
        lualine_bold = true,
      })
      vim.o.termguicolors = true
    end,
  },

Ok ya, so transparent has to be false for it to work, ill make a note of it in the docs


Added short Gulp Section to Intro

Issue #743 - Adding Gulp.
The basics have been added, but I will continue to add onto this throughout the week for another commit in the short future.

@zeldar Thanks for the contribution! If you can adjust the line comments above, and move the troubleshooting out of this PR and into a PR against the gh-pages (documentation) branch, it should be good to go!

@codydaig now we just have to move the troubleshooting out of this PR right?

@ilanbiala @zeldar Correct me if I am wrong, but looks like the troubleshooting got removed. If so I think it's ready.

Yep, but it still needs to be added to gh-pages in a separate PR. Let's get this squashed and merged?

This shouldn't hold 0.4.2 so I set it to 0.5.0

Just to clarify: @zeldar we'll still merge this whenever it comes around, so if it comes before 0.4.2 releases, great. If not, that's fine too, but we still want to merge this in.

@ilanbiala Yes, Troubleshooting was removed.
Do you want the addition of the Troubleshooting section pushed to this commit before squashing, or do you want me to create a new issue for Troubleshooting and push the Gulp Troubleshooting as a different commit?  Just wanted to clarify, but can have that finished this evening.

@zeldar The troubleshooting has to be to a separate PR since it will be against the gh-pages branch to have on the website / documentation.

@codydaig #1037 PR for gh-pages Gulp documentation and troubleshooting.
I have the same thing I wrote into the HTML in a TROUBLESHOOTING.md as well on my local machine, but noticed the TROUBLESHOOTING.md was blank.  Is there plans for that document, or is it part of the Jekyll process?
Do you need anything else from me on this PR?  Thank you for the help in getting sorted out.

@zeldar There aren't any plans for a TROUBLESHOOTING.md document.

LGTM

@zeldar @codydaig nice, looks like we can put this in for 0.4.2. @codydaig do you want to already start reformatting commit messages?

@ilanbiala We can't realistically start enforcing it until the changelog.md doc gets merged in. I'm starting too on my commits but I don't think we should enforce until 0.4.2 is released. All commits for 0.5.0 should follow the format.

Yeah makes sense.

@zeldar Can you squash down to 1 commit? Ping me once it's squashed and I'll merge.

@codydaig I believe this is ready. Thank you!

@zeldar Yup! Thanks a bunch!
LGTM


JSON documentation does not match implementation (frame_size)

The detection_template.json file indicates that each individual frame should populate the frame_size parameter. However, when the file is read "KeyError: 'frame_size'" is returned, unless the frame size is a parameter nested directly under video (on the same level as base_path).
My guess is that the behavior is correct (since videos can't dynamically change size), but the documentation is incorrect.

You're correct, it is supposed to be at the same level as base_path. The templates are being updated. Thanks!


Animation not displayed correctly

Basically I have the same problem like here https://github.com/Yalantis/Pull-to-Refresh.Rentals-iOS/issues/6 .
Is there a solution for this problem? My app is written in Swift.

fixed


MediaPipe  hand model

I'm using mediapipe to build my own appplications, but found the performance did not achieve the desired effect. so I'd like to training the model using my own data to meet the specific scenario. but the information of palm_detection and hand_landmark is insufficient, could you please give me more info? the paper "MediaPipe Hands: On-device Real-time Hand Tracking"( https://arxiv.org/abs/2006.10214v1) also encounter the same problem, any infomation about the above models ? please help me, thanks!

Hi @aureosun,
Is it implemented through python, javascript or other solutions available in mediapipe? Could you share the complete details to  understand the issue better, Thank you!


application doesn't launch

after #302 I have installed xclip ubuntu package and execute the same command:
(kivy-venv) ilya@ilya-965P-S3:~/ps/rbo17-cf/kivy-designer$ python -m designer
[INFO   ] [Logger      ] Record log in /home/ilya/.kivy/logs/kivy_17-04-15_33.txt
[INFO   ] [Kivy        ] v1.9.1
[INFO   ] [Python      ] v3.5.2 (default, Nov 17 2016, 17:05:23)
[GCC 5.4.0 20160609]
[INFO   ] [Factory     ] 179 symbols loaded
[INFO   ] [Image       ] Providers: img_tex, img_dds, img_gif, img_sdl2 (img_pil, img_ffpyplayer ignored)
[INFO   ] [Text        ] Provider: sdl2
[INFO   ] [OSC         ] using <multiprocessing> for socket
[INFO   ] [Window      ] Provider: sdl2(['window_egl_rpi'] ignored)
[INFO   ] [GL          ] OpenGL version <b'2.1 Mesa 12.0.6'>
[INFO   ] [GL          ] OpenGL vendor <b'X.Org R300 Project'>
[INFO   ] [GL          ] OpenGL renderer <b'Gallium 0.4 on ATI RV530'>
[INFO   ] [GL          ] OpenGL parsed version: 2, 1
[INFO   ] [GL          ] Shading version <b'1.20'>
[INFO   ] [GL          ] Texture max size <4096>
[INFO   ] [GL          ] Texture max units <16>
[INFO   ] [Window      ] auto add sdl2 input provider
[INFO   ] [Window      ] virtual keyboard not allowed, single mode, not docked
xclip version 0.12
Copyright (C) 2001-2008 Kim Saunders et al.
Distributed under the terms of the GNU GPL
[INFO   ] [Clipboard   ] Provider: xclip(['clipboard_dbusklipper', 'clipboard_gtk3'] ignored)
[INFO   ] [CutBuffer   ] cut buffer support enabled
Segmentation fault (core dumped)

And nothing else happening.

@LotosikRa Have you tried sudo apt-get install xclip ? ref: https://groups.google.com/forum/#!topic/kivy-users/cX1kFxxQZGk

@MysticMight sorry, I made a mistake - I have installed xclip package before. The issue is updated now.

This problem is related with your kivy installation. If you still having problems, please, come to the IRC channel or post in the maillist, so we can support you faster ;)
Thank you


"Error evaluating injectedJavaScript"

Minor issue, but when refreshing the token I'm getting a warning:
Error evaluating injectedJavaScript: This is possibly due to an unsupported return type. Try adding true to the end of your injectedJavaScript string. Error Domain=WKErrorDomain Code=5 "JavaScript execution returned a result of an unsupported type" UserInfo={NSLocalizedDescription=JavaScript execution returned a result of an unsupported type}

The way I'm using the library is:
import ReCaptchaV3 from '@haskkor/react-native-recaptchav3';
...
const captchaRef = React.createRef<ReCaptchaV3>();

const SignInPage = () => {
    ...
    <ReCaptchaV3
        ref={captchaRef}
        captchaDomain={environment.captchaBaseUrl}
        siteKey={environment.captchaSiteKey}
        action={'signIn'}
        onReceiveToken={token => {
            ...
        }}
    />
    ...
    captchaRef.current?.refreshToken();
    ...
}

It'd be nice to get rid of the warning completely, but I'll suppress it anyway, so this is really quite a minor thing.
Thank you for the nice library 😄

onReceiveToken is not firing when this error is thrown when refreshToken is called, making this library unusable in our case.


Add bool example type with "falsySupport"

Add bool example type with falsy support (which just does $ne: true on the field)
Add tests for the bool example type

Fails

:no_entry_sign:
This PR has failing tests. Please alleviate the errors and commit them

Warnings

:warning:
The README has not been updated. Please update the README.

Messages

:book:
Could not find any browser results.

:book:
We were able to automatically fix some formatting issues in this PR for you!

Some things that were possibly fixed:

Code that could be fixed via the --fix flag
Formatting that could be fixed by prettier

Take a look at this commit to see what happened in detail: 35ff02da10211f64c43d4efbbca86c9f74c1b85f
And look at this wiki page to see the reasoning behind the ESLint rules: https://github.com/smartprocure/eslint-config-smartprocure/wiki/Rules-and-Why-We-Chose-Them

  Generated by :no_entry_sign: dangerJS against f09d6539547e399cb0bbc2f37e1da4faad4031bf

All tests run locally with no issues. Not sure what CI is talking about.

Warnings

:warning:
The README has not been updated. Please update the README.

Messages

:book:
Could not find any browser results.

  Generated by :no_entry_sign: dangerJS against fa1c6bdd0282046ddd32472920ae8356a24741cb

This looks great, just two things:

I think I'd expect it to always with falsey support as described here in #58. The contexture-elasticsearch node behaves that way implicitly as well because that's how es works, so I think we can just kill the flag and make it always behave that way.

We should consider some way for bool to not have a value. Right now, value is either truthy or falsey, which means that simply adding the filter affects search results. Bool and exists are the only filters that behave this way which makes it pretty unintuitive. We could either allow null/undefined to count against hasValue (so hasValue becomes _.isNil, a slight departure from the es version), or maybe add a flag (less elegant). The UI could be something like [ ] Yes   [ ] No   [ ] Either for true/false/nil


Fixed getting UID/GID of the current process

Fixes https://github.com/Py-KMS-Organization/py-kms/issues/37.

Why should this fix it? As far as I know your calls will retrieve the current user and therefore do nothing. Additional the user which proposed that file wanted to specify the UID/GID via environment variables later on. We should think about defaulting to the current values, but still try to use the environment variables anyways.

Thank you for clarification.


Datetime test fix

Corrects timezone ambiguity in DatetimeTest so that all tests pass again. Changes expected timezone from NZT to UTC. Clarifies error messages so that you can tell numeric from string zero.

Presumably without this patch, the tests only successfully execute on NZ-based computers?  Seems like a good fix to me.


CORE-19017 migrate flow TimeoutEventCleanupProcessor to expect the MediatorState wrapper class

States saved by the mediator message pattern use a MediatorState wrapper object. The TimeoutEventCleanupProcessor does not currently expect this.

This is breaking a lot of builds so im going to merge. Any further comments on the design can be addressed in followups


comment out a break that was not properly Goosed all along

This is required to make it still Goose with https://github.com/tchajed/goose/pull/25.
Range loops do not support break anyway, so this was ignored in the Goose'd code all along. (I guess this means the real code ran faster than the code that was actually verified -- the early-break optimization was not verified.)

Superseded by https://github.com/mit-pdos/go-nfsd/commit/cb6ffb3a7afd5e64fd4f16e974455348c979eb6b


ng e2e breaks when webdriver-manager out of date

OS?

Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)

Ubuntu
Versions.

Please run ng --version. If there's nothing outputted, please run in a Terminal: node --version and paste the result here:

@angular/cli: 1.0.0-beta.31
Repro steps.

Was this an app that wasn't created using the CLI? What change did you do on your code? etc.

Run ng e2e with an out of date webdriver-manager.
The log given by the failure.

Normally this include a stack trace and some more information.

$ DISPLAY=:10 ng e2e --prod --env=ci
****************************************************************************************
This is a simple server for use in testing or debugging Angular applications locally.
It hasn't been reviewed for security issues.

DON'T USE IT FOR PRODUCTION USE!
****************************************************************************************
** NG Live Development Server is running on http://localhost:4200. **
 21% building modules 99/103 modules 4 active ...gets/src/app/table/table.component.tsmagicString.insertLeft(...) is deprecated. Use magicString.appendLeft(...) instead
Hash: ea1b24c233ed492d09cc
Time: 42423ms
chunk    {0} polyfills.f87c4a6686e3d9676fed.bundle.js (polyfills) 268 kB {5} [initial] [rendered]
chunk    {1} main.6e640f136426e5f8fc3b.bundle.js (main) 1.46 MB {4} [initial] [rendered]
chunk    {2} scripts.dd0fa2903fcecac43f2b.bundle.js (scripts) 1.3 kB {5} [initial] [rendered]
chunk    {3} styles.876b719d1c595c01c80b.bundle.css (styles) 69 bytes {5} [initial] [rendered]
chunk    {4} vendor.43bccd6adc65df20f10a.bundle.js (vendor) 2.76 MB [initial] [rendered]
chunk    {5} inline.c6b5057f43e1c851480a.bundle.js (inline) 0 bytes [entry] [rendered]
webpack: Compiled successfully.
[09:30:51] I/downloader - chromedriver: downloading version 2.26
[09:30:51] I/downloader - curl -o /home/vagrant/ng2-widgets/node_modules/protractor/node_modules/webdriver-manager/selenium/chromedriver_2.26linux64.zip https://chromedriver.storage.googleapis.com/2.26/chromedriver_linux64.zip
[09:30:51] I/direct - Using ChromeDriver directly...
[09:30:51] I/launcher - Running 1 instances of WebDriver
[09:30:51] E/direct - Error code: 135
[09:30:51] E/direct - Error message: Could not find chromedriver at /home/vagrant/ng2-widgets/node_modules/protractor/node_modules/webdriver-manager/selenium/chromedriver_2.26. Run 'webdriver-manager update' to download binaries.
[09:30:51] E/direct - Error: Could not find chromedriver at /home/vagrant/ng2-widgets/node_modules/protractor/node_modules/webdriver-manager/selenium/chromedriver_2.26. Run 'webdriver-manager update' to download binaries.
    at BrowserError.Error (native)
    at BrowserError.IError [as constructor] (/home/vagrant/ng2-widgets/node_modules/protractor/built/exitCodes.js:13:23)
    at BrowserError.ProtractorError [as constructor] (/home/vagrant/ng2-widgets/node_modules/protractor/built/exitCodes.js:21:28)
    at new BrowserError (/home/vagrant/ng2-widgets/node_modules/protractor/built/exitCodes.js:67:23)
    at Direct.getNewDriver (/home/vagrant/ng2-widgets/node_modules/protractor/built/driverProviders/direct.js:66:27)
    at Runner.createBrowser (/home/vagrant/ng2-widgets/node_modules/protractor/built/runner.js:198:43)
    at /home/vagrant/ng2-widgets/node_modules/protractor/built/runner.js:277:30
    at _fulfilled (/home/vagrant/ng2-widgets/node_modules/q/q.js:834:54)
    at self.promiseDispatch.done (/home/vagrant/ng2-widgets/node_modules/q/q.js:863:30)
    at Promise.promise.promiseDispatch (/home/vagrant/ng2-widgets/node_modules/q/q.js:796:13)
    at /home/vagrant/ng2-widgets/node_modules/q/q.js:556:49
    at runSingle (/home/vagrant/ng2-widgets/node_modules/q/q.js:137:13)
    at flush (/home/vagrant/ng2-widgets/node_modules/q/q.js:125:13)
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickCallback (internal/process/next_tick.js:98:9)
[09:30:51] E/launcher - Process exited with error code 135

The log says to update webdriver-manager (which used to happen as a part of the pree2e npm script in package.json).
Running that pre script manually fixes the problem:
$ npm run pree2e

><EMAIL_ADDRESS>pree2e /home/vagrant/ng2-widgets
> webdriver-manager update --standalone false --gecko false

[09:35:19] I/downloader - chromedriver: downloading version 2.26
[09:35:19] I/downloader - curl -o /home/vagrant/ng2-widgets/node_modules/protractor/node_modules/webdriver-manager/selenium/chromedriver_2.26linux64.zip https://chromedriver.storage.googleapis.com/2.26/chromedriver_linux64.zip
[09:35:19] I/update - chromedriver: unzipping /home/vagrant/ng2-widgets/node_modules/protractor/node_modules/webdriver-manager/selenium/chromedriver_2.26linux64.zip
[09:35:19] I/update - chromedriver: setting permissions to 0755 for /home/vagrant/ng2-widgets/node_modules/protractor/node_modules/webdriver-manager/selenium/chromedriver_2.26

Successful run
$ DISPLAY=:10 ng e2e --prod --env=ci
****************************************************************************************
This is a simple server for use in testing or debugging Angular applications locally.
It hasn't been reviewed for security issues.

DON'T USE IT FOR PRODUCTION USE!
****************************************************************************************
** NG Live Development Server is running on http://localhost:4200. **
 21% building modules 99/103 modules 4 active ...gets/src/app/table/table.component.tsmagicString.insertLeft(...) is deprecated. Use magicString.appendLeft(...) instead
Hash: dc835bf7904c1631debc
Time: 40454ms
chunk    {0} polyfills.f87c4a6686e3d9676fed.bundle.js (polyfills) 268 kB {5} [initial] [rendered]
chunk    {1} main.6e640f136426e5f8fc3b.bundle.js (main) 1.46 MB {4} [initial] [rendered]
chunk    {2} scripts.dd0fa2903fcecac43f2b.bundle.js (scripts) 1.3 kB {5} [initial] [rendered]
chunk    {3} styles.876b719d1c595c01c80b.bundle.css (styles) 69 bytes {5} [initial] [rendered]
chunk    {4} vendor.43bccd6adc65df20f10a.bundle.js (vendor) 2.76 MB [initial] [rendered]
chunk    {5} inline.c6b5057f43e1c851480a.bundle.js (inline) 0 bytes [entry] [rendered]
webpack: Compiled successfully.
[09:36:15] I/direct - Using ChromeDriver directly...
[09:36:15] I/launcher - Running 1 instances of WebDriver
[09:36:15] I/update - chromedriver: file exists /home/vagrant/ng2-widgets/node_modules/protractor/node_modules/webdriver-manager/selenium/chromedriver_2.26linux64.zip
[09:36:15] I/update - chromedriver: unzipping chromedriver_2.26linux64.zip
[09:36:15] I/update - chromedriver: setting permissions to 0755 for /home/vagrant/ng2-widgets/node_modules/protractor/node_modules/webdriver-manager/selenium/chromedriver_2.26
[09:36:15] I/update - chromedriver: v2.26 up to date
Spec started

Yes, even I'm facing the same issue. 'ng e2e' may not be calling the 'pree2e' script while running. The workaround provided above of running 'pree2e' works though.

I have the same issue but when running ng serve --aot --live-reload  and it comes from my service component where the only thing I do is call http.get method :P

We do run webdriver update, but now it's run directly without using npm scripts: https://github.com/angular/angular-cli/blob/master/packages/%40angular/cli/tasks/e2e.ts#L38
I'm not sure why that didn't work in your case. It might be related with the fact that now we use protractor@5, and yo had some old drivers? Not sure. If you can find a way to consistently repro with a new app I can investigate.

For me the suggested workaround did not work on a newly generated project.

For me the suggested workaround did not work on a newly generated project.

Downgrading to<EMAIL_ADDRESS>worked for me.

The issue seems to be with magic-string,
`insertLeft(index, content) {
if (!warned.insertLeft) {
console.warn('magicString.insertLeft(...) is deprecated. Use magicString.appendLeft(...) instead'); // eslint-disable-line no-console
warned.insertLeft = true;
}
return this.appendLeft(index, content);

}`
It's being called from

<EMAIL_ADDRESS>
I can be ignored

I had this happen with beta 31, too

@filipesilva I can confirm that I have protractor installed at 4.0.13 as per my package.json:
"protractor": "~4.0.13",

I take it that this would have been updated with an ng update but #4584 dictates that no longer works and won't be supported in the future.
Additionally, this package.json change wasn't included under any manual steps in CHANGELOG.md which has been said to be the replacement for ng update.
I will need to perform further investigation to see if the version change is related to this bug.
I'm concerned with the fact that my project's package.json is now out of date with the latest cli's package.json blueprint and has no way of being updated as part of a CLI upgrade.
Especially when hard to reproduce bugs may be introduced when new/altered CLI functionality relies on the latest package.json versions as per the blueprint.

I have a similar problem, but different error and the workaround suggested doesn't work for me.
Cannot find module 'protractor/node_modules/webdriver-manager/built/lib/cmds/update' from 'PROJECT_PATH'

@johnpapa  @Blasz  Running the e2e command without the webdriver update and adding pree2e below fixed this issue
"pree2e": "webdriver-manager update --standalone false --gecko false",
 "e2e": "ng e2e --no-webdriver-update",

@Blasz Also, to be able to migrate, you should copy-paste and merged all cli config files

We've added a step-by-step update doc for RCs, which we'll keep updated up to 1.0 (including).
If this is something we can fix from the CLI side I'd like to, but my understanding is that it's some kind of unsupported behaviour from protractor/webdriver-manager.
Does anyone have a better explanation?

@b-barry's trick did not work for me on a newly generated project, still the same error. I'm using Angular CLI 1.0.0.

@rkrisztian on a new project? That's really odd. Can you give me a full log please?

Attached e2e-log.txt.

Thanks for reporting this issue. This issue is now obsolete due to changes in the recent releases. Please update to the most recent Angular CLI version.
If the problem persists after upgrading, please open a new issue, provide a simple repository reproducing the problem, and describe the difference between the expected and current behavior.

To record, I tried "npm install --save-dev protractor@latest", the protractor version turned into:
"protractor": "^5.1.2", from "~4.0.13"
and the "ng e2e" worked.


Setting

may i ask u for the best setting sir?

There are no "best" settings. The code is somewhat documented, look at what each setting does and configure it according to your needs.
100 - 100 exponent factor and scale produces a linear input curve
I will release a hardware version of the remapper with many more features and better compatibility if there is enough interest.

Hello,
First of all I have to say nice work!
But i have a couple questions

How do I add extra mappings (cuz gui shows only W,A,S,D and sens)
I am currently using this for apex legends and sometimes left and right click bug and the weapon keeps shooting even if I dont press anything
Thank you


SQL Admin API Client base path has updated

https://github.com/googleapis/google-api-go-client/commit/8a410c21381766a810817fd6200fce8838ecb277#diff-fc3696d32750cf4e3f741d7d50fda5f4L79-R79
the diff is too big, but 5 days ago this happened:
- const basePath = "https://www.googleapis.com/sql/v1beta4/"
+ const basePath = "https://sqladmin.googleapis.com/"

And cloudsql proxy dialer ends up here:
https://github.com/GoogleCloudPlatform/cloudsql-proxy/blob/46c5533ff5bad7ea6a5e4966a670249d299f5880/proxy/proxy/dial.go#L75
Which creates the cert source with forced API path which is now wrong since google API version v0.14.0.
Note that you don't actually need to provide the path, empty string should work fine and it will use the default from the api:
https://github.com/GoogleCloudPlatform/cloudsql-proxy/blob/46c5533ff5bad7ea6a5e4966a670249d299f5880/proxy/certs/certs.go#L83-L89
As a consequence of that if using default dialer proxy with latest API, you'll get errors like so:

The requested URL /sql/v1beta4/sql/v1beta4/projects/{project_id}/instances/{instance}/createEphemeral?alt=json&prettyPrint=false was not found on this server.

Also raised in https://github.com/googleapis/google-api-go-client/issues/427

I was actually able to reproduce this by starting in a docker container as opposed to my local copy for some reason:
$ docker run --rm -it golang:1
$ go get github.com/GoogleCloudPlatform/cloudsql-proxy/cmd/cloud_sql_proxy

I confirmed it cloned at 231cffdfe5a16e0f922416ceb095f2c28783ad2d, then built the proxy (go build from /go/src/github.com/GoogleCloudPlatform/cloudsql-proxy/cmd/cloud_sql_proxy)  and saw the following:
$ go: extracting google.golang.org/api v0.15.0

Then running the proxy (/go/bin/cloud_sql_proxy -instances=project:region:instance=tcp:3306):

404. That’s an error.

The requested URL /sql/v1beta4/sql/v1beta4/projects/project/instances/instance?alt=json&prettyPrint=false was not found on this server.  That’s all we know.

Not quite sure why it works locally - I'm going to reopen and dedup against #331.

The issue turned out to be the default value for -host was still set, which was causing a problem with the binary as an executable (but not with the dialer).
This probably underscores our need for an e2e presubmit test to better prevent issues like this in the future.


Improve clarity of returned errors

It is not very obvious what exceptions are being thrown in code, it would be good to make it explicit.
e.g.
int.tryParse(null);

Unhandled exception:
Invalid argument(s): The source must not be null
#0      int.tryParse (dart:core-patch/dart:core/integers_patch.dart:112)
#1      main (file:///work/projects/dart/kbml_parser/main_test.dart:11:9)
#2      _startIsolate.<anonymous closure> (dart:isolate-patch/dart:isolate/isolate_patch.dart:279)
#3      _RawReceivePortImpl._handleMessage (dart:isolate-patch/dart:isolate/isolate_patch.dart:165)

It is not clear at all that this exception can be trapped with ArgumentError
If we compare this with Java - the exception being thrown is clearly shown :
java.lang.IllegalArgumentException: timeout value is negative

Ooops - I put this in the wrong githut

https://github.com/dart-lang/sdk/issues/33275


Automatic indentation of if ... then repeat until is wrong

1. Describe the bug
The automatic indentation of a repeat until loop after a condition is wrong.
2. To Reproduce
Steps to reproduce the behavior:

Create a simple repeat until with the usual check for existing records.

    local procedure MyProcedure()
    var
        Item: Record Item;
    begin
        if Item.FindSet() then
            repeat
                Message(Item.Description);
            until Item.Next() = 0;
    end;

3. Expected behavior
The indentation of the repeat until should be one tab more than the if FindSet() then
    local procedure MyProcedure()
    var
        Item: Record Item;
    begin
        if Item.FindSet() then
            repeat
                Message(Item.Description);
            until Item.Next() = 0;
    end;

4. Actual behavior
The indentation is two tabs instead of one. This reformats large parts of the source code which have to be manually reversed.
    local procedure MyProcedure()
    var
        Item: Record Item;
    begin
        if Item.FindSet() then
                repeat
                    Message(Item.Description);
                until Item.Next() = 0;
    end;

5. Versions:

AL Language:v9.3.642746
Visual Studio Code:1.68.1
Business Central: Platform 20.0.41086.41354 + Application 20.2.41144.41423

Duplicate #7091