Springfox with Spring 4.x annotations. Interfaces having Spring4.x annotations not supported in springfox

Note: Resteasy 2.3.5 supports interfaces for swagger documentation. But springfox doesn't
Problem Statement:
I am trying to generate Swagger Specification for SpringMVC Rest project. Springfox is not supporting annotations (Spring 4.x annotations) in interfaces for generating swagger documentation.
Key jars:
springfox-swagger-ui
springfox-swagger2
swagger-springmvc
My environment:

pom.xml
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>
    <groupId>springmvc.swagger</groupId>
    <artifactId>swagger</artifactId>
    <version>0.0.1-SNAPSHOT</version>
    <description>Swaggerpoc</description>

    <parent>
        <groupId>org.springframework.boot</groupId>
        <artifactId>spring-boot-starter-parent</artifactId>
        <version>1.3.0.RELEASE</version>
    </parent>

    <properties>
        <java-version>1.8</java-version>
        <api-common-version>1.0.3-SNAPSHOT</api-common-version>
        <api-messaging-version>1.0.3-SNAPSHOT</api-messaging-version>
    </properties>

    <dependencies>
        <dependency>
            <groupId>org.springframework.boot</groupId>
            <artifactId>spring-boot-starter-web</artifactId>
        </dependency>
        <dependency>
            <groupId>io.springfox</groupId>
            <artifactId>springfox-swagger-ui</artifactId>
            <version>2.5.0</version>
        </dependency>

        <!-- https://mvnrepository.com/artifact/io.springfox/springfox-swagger2 -->
        <dependency>
            <groupId>io.springfox</groupId>
            <artifactId>springfox-swagger2</artifactId>
            <version>2.5.0</version>
        </dependency>
        <!--
        <dependency>
            <groupId>io.springfox</groupId>
            <artifactId>springfox-core</artifactId>
            <scope>system</scope>
            <version>1</version>
            <systemPath>C:/Users/sachin_nikam/Desktop/springfox-core.jar</systemPath>
        </dependency> -->

        <!-- https://mvnrepository.com/artifact/com.mangofactory/swagger-springmvc -->
        <dependency>
            <groupId>com.mangofactory</groupId>
            <artifactId>swagger-springmvc</artifactId>
            <version>1.0.2</version>
        </dependency>

        <dependency>
            <groupId>org.springframework</groupId>
            <artifactId>spring-core</artifactId>
            <version>4.2.5.RELEASE</version>
        </dependency>
    </dependencies>

    <build>
        <plugins>
            <plugin>
                <groupId>org.springframework.boot</groupId>
                <artifactId>spring-boot-maven-plugin</artifactId>
            </plugin>
        </plugins>
    </build>

    <repositories>
        <repository>
            <id>spring-releases</id>
            <url>https://repo.spring.io/libs-release</url>
        </repository>
    </repositories>
    <pluginRepositories>
        <pluginRepository>
            <id>spring-releases</id>
            <url>https://repo.spring.io/libs-release</url>
        </pluginRepository>
    </pluginRepositories>
</project>

Interface
import Response;
import Contact;

@RequestMapping("/v1/contact")
@Api(value = "Contact services")
public interface ContactController {
    /**
     * Purpose: Fetch contacts.
     *
     *
     * @param employeeId
     * @param companyId
     *
     * @return ReturnResponse
     * @throws Exception
     * @see success data
     *
     */
    @ApiOperation(value = "getContacts", notes = "Gets the list of contacts", responseContainer = "List<Contact>")
    @ApiResponses(value = { @ApiResponse(code = 200, message = "Success", response = Response.class),
            @ApiResponse(code = 401, message = "Unauthorized", response =Response.class),
            @ApiResponse(code = 403, message = "Forbidden", response = Response.class),
            @ApiResponse(code = 404, message = "Not Found", response = Response.class),
            @ApiResponse(code = 500, message = "Internal server error occured", response = Response.class) })
    @RequestMapping(value = "/{companyId}/{employeeId}/contacts", method = RequestMethod.GET)
    Response<List<Contact>> getContacts(@PathVariable String employeeId,
            @PathVariable String companyId);
}

Models:

Reponse.java
@JsonAutoDetect
@JsonInclude(JsonInclude.Include.NON_NULL)
public class Response<T> implements Serializable {
    private static final long serialVersionUID = 1L;
    private T data;
    private Error error;
    private String statusCode;
    private String statusText;

    public T getData() {
        return this.data;
    }

    @JsonProperty("_error")
    public Error getError() {
        return this.error;
    }

    @JsonProperty("_statusCode")
    public String getStatusCode() {
        return this.statusCode;
    }

    @JsonProperty("_statusText")
    public String getStatusText() {
        return this.statusText;
    }
    public void setData(T data) {
        this.data = data;
    }
    public void setError(Error error) {
        this.error = error;
    }

    public void setStatusCode(String statusCode) {
        this.statusCode = statusCode;
    }

    public void setStatusText(String statusText) {
        this.statusText = statusText;
    }
}

Contact.java

import io.swagger.annotations.ApiModel;
import io.swagger.annotations.ApiModelProperty;

import java.io.Serializable;

import com.fasterxml.jackson.annotation.JsonAutoDetect;

@ApiModel
@JsonAutoDetect
public class Contact implements Serializable {

    private static final long serialVersionUID = 1L;

    @ApiModelProperty(notes = "The contact address 1", required = true)
    private String address1;
    @ApiModelProperty(notes = "The contact address 2", required = false)
    private String address2;

    // Getters and setters
    /**
     * @return the address1
     */
    public String getAddress1() {
        return address1;
    }
    /**
     * @param address1 the address1 to set
     */
    public void setAddress1(String address1) {
        this.address1 = address1;
    }
    /**
     * @return the address2
     */
    public String getAddress2() {
        return address2;
    }
    /**
     * @param address2 the address2 to set
     */
    public void setAddress2(String address2) {
        this.address2 = address2;
    }
}

Controller Implementation:

Contact Controller Impl
import Contact;
import Response;

@RestController
public class ContactControllerImpl implements ContactController  {

    /**
     * Purpose: Fetches Contacts details.
     *
     *
     * @param employeeId
     * @param companyId
     * @return Response
     *
     * @throws Exception
     * @see success data
     *
     */
     @Override
    public Response<List<Contact>> getContacts(@PathVariable String employeeId,
            @PathVariable String companyId) {
       final List<Contact> contactlist = new ArrayList<Contact>();
        return contactlist;
    }
}

Please run this code at your end. Interfaces are not supported by springfox API.
http://host:port/swagger-ui.html should list me interfaces instead of controller impl

@sac10nikam Looks like your controller doesn't implement the interface.
public class ContactControllerImpl /* missing implements ContactController */ {
//...
}

Thanks for pointing out. But I had missed it to add. Can you please run this as a project and see. The swagger doesn't work for above code if put swagger annotations and spring 4.x annotations in interface and in controller impl class I implement this interface. And override its method.
Ideally it should work. Please help.

Please share a github repo that reproduces the issue.

ok. Sure Will upload it in next 30 mins. Thanks.

Hi Dilip,
I have uploaded sample maven project.  https://github.com/sac10nikam/swagger-poc
Please have a look at it. I am online. We can talk/chat/communicate here.
Many Thanks,
Sachin

Hi,
I have uploaded my sample project. Please have a look.
Thanks,
Sachin
On Jul 14, 2016 8:17 PM, "Dilip Krishnan"<EMAIL_ADDRESS>wrote:

@sac10nikam https://github.com/sac10nikam Looks like your controller
doesn't implement the interface.
public class ContactControllerImpl /* missing implements ContactController */ {//...
}
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/springfox/springfox/issues/1389#issuecomment-232687374,
or mute the thread
https://github.com/notifications/unsubscribe/AGOFOK7rpv98wksWqRL2vG40-YPNu5mPks5qVkwKgaJpZM4JMI0c
.

See interfaces where? It seems to be working just fine.

In the attached image we could see controller implementation instead of
interface. Can you please check image from last message.
I.e. HTTP://host:port/context/swagger-springmvc.html should show list of
interfaces instead of controller.
It is fine but I want to support interface having swagger annotations and
spring 4.x annotations.
Thanks,
Sachin
On Jul 15, 2016 2:16 AM, "Dilip Krishnan"<EMAIL_ADDRESS>wrote:

See interfaces where? It seems to be working just fine.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/springfox/springfox/issues/1389#issuecomment-232787108,
or mute the thread
https://github.com/notifications/unsubscribe/AGOFODU83z9uzX76oIwHYVgJB4yJgOs8ks5qVqALgaJpZM4JMI0c
.

Those are just the descriptions. You can control those via annotations in the interface. In your case using the @Api#tags

Also just so it's clear, interface and implementations don't matter in the swagger Api description. It's the url, media type, query parameters etc. everything else can be controlled via annotations.

Thanks for your quick reply.
Please do below given change in project and see the output. This issue I want to resolve.
Change config/Application.java
Change @ComponentScan(basePackageClasses = { ContactControllerImpl.class })
to @ComponentScan(basePackageClasses = { ContactController.class })
and build it and run the application and hit http://localhost:8080/swagger-ui.html
Thanks,
Sachin

I don't see any difference. What are you expecting to resolve?
If you change the Api annotation like below you'll see what you're expecting to see.
@RequestMapping("/v1/contact")
@Api(value = "Contact services", tags = "Contact Services", description = "Contact Services")
//Instead of @Api(value = "Contact services")
public interface ContactController {
//...
}

Thanks.. I guess it is working.. I had checked it in the morning.. There was no change required. But I am still wondering why it was not show the list of interfaces.
Anyway thanks a lot for your time. Have a gr8 day.

Hi, I have a similar issue to the one reported here. I am using  springfox:2.6.1 with springboot:1.5.2.RELEASE and I would like to generate swagger documentation from java interfaces using spring mvc annotations. However my REST controller interfaces seem to be ignored.
Any help is welcome.

@sermojohn this should be fixed in 2.7

+1
@dilipkrish does it mean that just providing springfox with the RESTController interfaces we should be able to generate the docs/spec ?


TT-540 blockscout docker container start

Codecov Report

Merging #667 (76018d2) into main (d637ca0) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #667   +/-   ##
=======================================
  Coverage   42.32%   42.32%
=======================================
  Files           7        7
  Lines         482      482
=======================================
  Hits          204      204
  Misses        262      262
  Partials       16       16


[asmjit] Update to 2024-06-05

[x] Changes comply with the maintainer guide.
[x] SHA512s are updated for each updated download.
[x] The "supports" clause reflects platforms that may be fixed by this new version.
[x] Any fixed CI baseline entries are removed from that file.
[x] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

Is it possible to at least see what failed in packages that depend on asmjit?
It seems it's all about a polyhook package, but I have no idea what is wrong, build logs are not available.

BTW I think that maybe it's related to the following change:
if(VCPKG_LIBRARY_LINKAGE STREQUAL "static")
    vcpkg_replace_string("${CURRENT_PACKAGES_DIR}/include/asmjit/core/api-config.h"
        "#if !defined(ASMJIT_STATIC)"
        "#if 0"
    )
endif()

But this change does the right thing!
If you consume asmjit from cmake, then cmake is responsible for setting this flag, and this flag is documented properly in asmjit documentation. If anyone consumes a static library and doesn't use cmake then it's the responsibility of such project to define the flag explicitly.
I think vcpkg should not patch asmjit headers - there is no reason to, and I suggest the upstream should fix the tools that depend on asmjit instead of patching asmjit headers via vcpkg.

x64-windows error (i.e. unrelated to header fixup):
D:\b\polyhook2\src\6141013c7f-4f5bdd1209.clean\sources\ILCallback.cpp(258): error C2039: 'init': is not a member of 'asmjit::_abi_1_13::FuncSignature'

x64-linux error, similar:
/mnt/vcpkg-ci/b/polyhook2/src/6141013c7f-4f5bdd1209.clean/sources/ILCallback.cpp: In member function ‘uint64_t PLH::ILCallback::getJitFunc(const string&, const std::vector<std::__cxx11::basic_string<char> >&, asmjit::_abi_1_13::Arch, PLH::ILCallback::tUserCallback, std::string)’:
/mnt/vcpkg-ci/b/polyhook2/src/6141013c7f-4f5bdd1209.clean/sources/ILCallback.cpp:258:13: error: ‘struct asmjit::_abi_1_13::FuncSignature’ has no member named ‘init’
  258 |         sig.init(getCallConv(callConv),asmjit::FuncSignature::kNoVarArgs, getTypeId(retType), args.data(), (uint32_t)args.size());
      |             ^~~~

cmake is responsible for setting ASMJIT_STATIC and I verified that it's properly exported by cmake.

Microsoft cares for VS users which use pure msbuild, not CMake.

Regarding msbuild:
I'm not sure I can comment about msbuild as there is no msbuild support in AsmJit - if vcpkg only cares of VS msbuild users then I guess it should be clearly stated on its homepage? I've got the impression that vcpkg is a cross-platform solution that picks no sides. Since AsmJit uses cmake and this port depends on it I don't consider there is a problem here.
Regarding broken packages:
Is there any document/statement about not updating a package if it means that some other package in the whole vcpkg tree that depends on it cannot be built with that latest version? I cannot possibly fix all dependents - I only care of AsmJit and breaking changes are clearly documented here:

https://asmjit.com/doc/group__asmjit__breaking__changes.html

I think broken dependents should pin AsmJit at a specific version/commit instead of preventing AsmJit port update. Or how should this be even solved? I cannot update AsmJit without breaking other ports, but other ports cannot be updated to a newer AsmJit if AsmJit port is never updated... Or should a broken dependent deny lifetime updates of AsmJit in vcpkg?
As an author of AsmJit I just feel that it's irresponsible against AsmJit users to have outdated port on vcpkg that is known to have bugs at this point; and I would like to offer them a better support. However, I cannot possibly update all dependents that get broken with AsmJit port update as it's already used by a lot of existing software.

if vcpkg only cares of VS msbuild users then I guess it should be clearly stated on its homepage?

This was not the point I wanted to make. I just pointed out that not everybody is using CMake.
(I'm a community member. I do not even use Visual Studio.)

As an author of AsmJit I just feel that it's irresponsible against AsmJit users to have outdated port on vcpkg that is known to have bugs at this point; and I would like to offer them a better support. However, I cannot possibly update all dependents that get broken with AsmJit port update as it's already used by a lot of existing software.

I think there will be maintainers to help out after the weekend. YMMV.

Is there any document/statement about not updating a package if it means that some other package in the whole vcpkg tree that depends on it cannot be built with that latest version?

This is unfortunately a tough situation with vcpkg. From what I understand (I may be wrong) vcpkg needs packages to always be up to to date. I fought a very similar battle even getting polyhook, asmjit, and asmtk into vcpkg in the first place. There was a complex dependency tree and I had to submit PRs here in vcpkg and to each of those package repos then ensure they all landed at the same time to get everything into vcpkg.
I will fix the outdated API polyhook relies on so this can be resolved. Please give me a few days

I submitted a package update which will fill polyhook once asmjit port is updated here.

Thanks a lot, that was fast!
Maybe this should be reiterated then? Anything else to do to get this done?

I believe we need a vcpkg maintainer to confirm everything is ok now and complete the merge of both PRs at the same time.

I still think that having a build tree of 2428 packages developed totally independently to always build is a heroic effort. Of course we should not break other's code, but sometimes it's inevitable to fix bugs or to add new features.

@kobalicek @stevemk14ebr Thank you for your update and reply. However, asmjit is called as the upstream of polyhook2, and the FuncSignature::init function is deleted in the new asmjit, which causes polyhook2 to fail to compile on CI. Therefore, this error needs to be fixed in this PR before CI can pass.

Are you suggesting to do the changes from https://github.com/microsoft/vcpkg/pull/39105 within this PR?

Are you suggesting to do the changes from #39105 within this PR?

If they muz be updated together, then it must be in one PR.

Maybe this should be reiterated then? Anything else to do to get this done?

On arm64-osx, fbgemm needs to be looked at.

fbgemm upstream is already using a recent AsmJit, but vcpkg is not using fbgemm upstream...
There is still this bug regarding ARM open:
https://github.com/pytorch/FBGEMM/issues/2074
So I'm not sure fbgemm is even supposed to build on ARM.
This is honestly beyond my time limit so I'm giving up on this.

If they must be updated together, then it must be done in one PR.

The requirement for them to all be together is coming from vcpkg. These are independent projects.
Polyhook dependencies:

asmtk
asmjit
zydis

FBGEMM:

asmjit
... others ...

So when updating asmjit the vcpkg maintainers are saying we need to also update the upstream sources. That doesn't seem right to me, we should let these upstream packages temporarily break until their respective maintainers do the work to fix them. OR vcpkg adds proper versionioning to avoid the temporary breakage, letting the upstream sources do the migration when they have time.
I have already done the work for Polyhook update in https://github.com/microsoft/vcpkg/pull/39105.

I'm wondering what to do about fbgemm.
I tried on ARM64 Apple to build it in the current tree and it refuses to build it as AsmJit previously had "!arm" in the package supported list, so it transitioned to fbgemm.
This means that removing this restriction now allows fbgemm to be build on arm, so I think I should just add "!arm" to fbgemm instead so it's not built on this platform, agreed?
I don't feel like fixing something that never worked in the first place.

@stevemk14ebr I have already included your changes in this PR, you can close your PR, thanks a lot for a quick fix!

Usage test pass with following triplets:
x64-windows
x64-windows-static

Amazing, hopefully this could be merged soon as I need to update one more package, which depends on the latest asmjit, thanks!

This is a sad conclusion. I put in work to quickly fix polyhook. Please reopen this and just keep the patch in so we can all get along.

@stevemk14ebr
I have decided I'm not going to contribute to vcpkg anymore as there is no clear documentation about the issue that was discussed above, which is surprisingly a blocker.
AsmJit clearly specifies how to build and use it, and it offers feature selection and static/shared build selection via a compile-time macro, which is clearly documented on AsmJit's homepage. Cmake users have the advantage of using asmjit::asmjit target that already takes care of that. Msbuild users, however, should follow the official documentation and not rely on a package manager to patch headers for them. Any project that uses asmjit and relies on a package manager to patch headers for it I consider broken.
After exploring more pull requests here on vcpkg, I have concluded that this unclear requirement costs me and many others a lot of time and it seems it's only for users that cannot even setup their msbuild projects properly. I insist on having vanilla AsmJit here on vcpkg and I think it's a step forward. If vcpkg maintainers thing differently I really suggest to state that in the documentation and to describe how this integration with msbuild should work, and more importantly, I think that the CI pipeline should test that too, because this PR was green, but still rejected.
Because at the moment I have the following impression: if consuming X is a set of compiler and linker flags, you cannot just remove them both and say consuming X is just linking to libX and that's it. This would only work for minority of libraries, and especially it would not work for libraries that have dependencies. If I added a dependency to AsmJit it would break all of those fragile msbuild projects that @Neumann-A and @BillyONeal talked about...

I initially wanted to maintain this port, to submit new versions when an important bug-fix or feature gets merged, but I have reconsidered this as I don't want to maintain ports that patch AsmJit headers for literally no reason. If anyone wants an updated version, make your own PR. I haven't deleted my PR, so if anyone is interested, just fork this PR, add what vcpkg maintainers want, and make another PR.

I will be very happy, if a new version of Blend2D will be on VCPKG. There are important features. If I understand it correctly, there is a problem with this:
if(VCPKG_LIBRARY_LINKAGE STREQUAL "static")
    vcpkg_replace_string("${CURRENT_PACKAGES_DIR}/include/asmjit/core/api-config.h"
        "#if !defined(ASMJIT_STATIC)"
        "#if 0"
    )
endif()

Why VCPKG dont just define ASMJIT_STATIC?

@JakubMelka It actually does define it, and since there is windows-static runner it's proven it works.
The whole issue here is about patching the source code to make projects that are lazy to define it working.

@kobalicek, Is there a list of these projects? Maybe I can help with that. I strongly need new version of Blend2D in VCPKG and I can spare some time helping to fix this issue.

@JakubMelka If you want to spend time on this just fork this PR (my branch) and add the code patching that I have removed back. It's just for some invisible MSBuild users and vcpkg maintainers who rely on code patching.
However, I would update the version as AsmJit in this PR is already behind (missing a bug fix).
Once this is done I can help with Blend2D as it has some new cmake options to avoid patching.........

@kobalicek, @stevemk14ebr, I have prepared a new pull request, where I have reverted removal of the code. #39630


About periodic config

Hi Yura!
I am trying to implement transformer-plr. I cannot find config.model.periodic and config.model.autodis in report.json file or in default config file.
I found self.model.periodic = lib.PeriodicOptions(
self.model.d_num_embedding // 2,
self.model.periodic_sigma,
False,
'log-linear',
)
But I can not find the implement of autodis.
Thank you!

Hi! See this line in bin/train4.py.
To clarify, our paper does not propose AutoDis. AutoDis is a baseline from prior work.

I am not sure that I fully understand the question, do you need help with the "periodic" part?

Thank you for your reply!
I found the implement of periodic embedding here https://github.com/Yura52/rtdl/blob/main/rtdl/nn/_embeddings.py more practical. Is the implement of numerical embedding in rtdl/nn/embedding.py as same as in the current repo - tabular-dl-num-embeddings

Well, I hope they are the same :) Though, currently, I recommend copying the implementation from here: link
Regarding, the rtdl project, please, see this post to learn about the status of the project.

Well, I hope they are the same :) Though, currently, I recommend copying the implementation from here: link
Regarding, the rtdl project, please, see this post to learn about the status of the project.

Thank you!


Port version updates to 1.x

Wait, this didn't work.  I'll see what went wrong and will probably delete this.

I'm going to close this.  I can't seem to create a local branch based on canonical Helidon's 1.x branch for some reason without creating a new fork each time.  git concludes that a merge commit is necessary every time and I don't understand why.  I'll try another attempt to get the substance of this PR in.


Update find-it.js

Changing DIMES string split to starts with "#" instead of "#aspace_"

Let's hold off merging this until we've got everything re-exported.

@pjg250 you can merge this and push the code up to the server. Exports should be done shortly.


[SPARK-12475][BUILD][test-maven] Upgrade Zinc from <IP_ADDRESS> to 0.3.9

We should update to the latest version of Zinc in order to match our SBT version.

Test build #48158 has started for PR 10426 at commit 9c4d7ff.

Test build #48158 has finished for PR 10426 at commit 9c4d7ff.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48158/
Test FAILed.

Merged build finished. Test FAILed.

Jenkins, retest this please.

Test build #48172 has started for PR 10426 at commit 9c4d7ff.

+1 FWIW I have been using the latest zinc for a while with Spark, including 0.3.9 and never had an issue

Test build #48172 has finished for PR 10426 at commit 9c4d7ff.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/48172/
Test PASSed.

Merged build finished. Test PASSed.

Alright, merging this now. Thanks!


Change Minimum supported Windows to  version 16299?

Why?

closing was having issues when trying to run with anything below 16299

i think if the project moved to 15063  we could then make use of conditional xaml, I only open this as i was having an issue running with anything below 16299  but i found out what it was it will be fixed soon
Conditional xaml allows us to target different os versions  eg.  if paralaxview is only avaliable with api contract 5 and if the device does not it can display something else

We are still able to use parallax service instead with the Community Toolkit on Version 2.2.0


Code Hierarchy of better understanding

In readme file there should be a well defined hierarchy of code. Like how models are defined and other MVT architecture.

Can I work on this issue?

Hey I have updated the things. Please merge my PR


Fix shell spawn bug

Explicitly runs commands in the shell using the shell: true option flag. Fixes #12 compatibility issue.
Normally, running child processes directly via shell true is inadvisable since it could, in theory, run anything, but since this script sticks to Wrangler and is run on local dev machines, it seems unlikely to have a significant risk. Not sure of a better way to alternatively fix this that doesn't involve shell true.

Nice!


Capture Image from VM ask parameters not documented

when I use capture image from vm
https://msdn.microsoft.com/en-us/library/azure/mt163560.aspx
it ask for
Required parameter 'CaptureVMInput' is missing (null)

but nothing was told about this in the api doc, please fix it, thx :)

Cleaning up old issues from 2016 - 2018. Please reactivate this if it is still a problem.


Remove anuraaga from owners

I don't use Armeria much lately. It's still my favorite framework so I hope that changes but I think it's important for everyone that my review should not be required or expected for gRPC changes. I still watch the repo so may chime in anyways, and of course happy anytime to be added as a reviewer to a PR individually instead of automatically.

Apparently gRPC is crying about this change XD

I think it's important for everyone that my review should not be required

Don't agree at all. ;)
You always pointed out that I didn't think of and realize. Your comments were always helpful and led us in the right direction. So it's definitely required.
I hope this is just that you don't want to be added as a reviewer automatically because I want to see the 'Rag' moment as much as I can. 😄

And the build still fails

I hope this is just that you don't want to be added as a reviewer automatically

Yup don't worry I'll still be jumping in when the PR title sounds interesting :) But don't think others need to be blocked on it either.


:runReleaseDistributable fails with java.lang.IncompatibleClassChangeError

A standalone app ran using :runReleaseDistributable fails to launch due to the following crash:
Exception in thread "main" java.lang.IncompatibleClassChangeError:
class org.jetbrains.jewel.ui.painter.SvgPainterHint cannot extend
sealed interface org.jetbrains.jewel.ui.painter.PainterHint

Configuration:

Dependency
Version

Jewel
0.14.1

Compose
1.6.0-dev1397

JDK
jbr-17 --arch64

Kotlin
1.8.21

Gradle
8.5

Sample project: https://github.com/charlesmuchene/sample-jewel-build-release

The issue is a Proguard configuration issue, not a Jewel issue. You should either disable Proguard:
compose.desktop {
  buildTypes.release.proguard {
    isEnabled = false
  }
}

Or add the rule suggested by @devkanro to your Proguard rules file:
# Keep all PainterHints
-keep interface * extends org.jetbrains.jewel.ui.painter.PainterHint


Dataplane swagger for tables

This adds a swagger for Azure Tables and Cosmos DB Tables dataplane operations.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[x] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

/azp run automation - sdk

I see that documentation (https://docs.microsoft.com/en-us/rest/api/storageservices/query-entities) mentions x-ms-continuation-NextPartitionKey and x-ms-continuation-NextRowKey response headers but they seem not to be defined here.

/azp run automation - sdk

Can one of the admins verify this patch?

/azp run automation - sdk

/azp run automation - sdk


onPress and symbol layer with text, icon and iconTextFit: "both"

Describe the bug
If you create symbolLayer with textField and some Icon pinned and set iconTextFit: "both", onPress will be called on the whole icon area before scaling
To Reproduce
<MapboxGL.ShapeSource onPress={() => console.log('I.ve been pressed')}>
  <MapboxGL.SymbolLayer
    style={{
      textField="someText"
      iconImage: ['get', 'icon],
      iconTextFit: 'both'
    }}
  />
</MapboxGL.ShapeSource>
<MapboxGL.Images images={{example: exampleIcon, assets: ['pin']}} />

Expected behavior
If you press outside of a scaled image or text, but inside of a non-scaled image(which can't be seen), nothing happens.
Actual behavior
After pressing outside of a scaled image or text, but inside of a non-scaled image onPress is called
Versions (please complete the following information):

Platfrom: [Android]
Device: [Xiaomi mi8 lite]
OS: [Android 9, miui 11]
React Native Version [0.60.5]
react-native-mapbox-gl version [^7.0.4]

Additional context
Add any other context about the problem here.

If you press outside of a scaled image or text, but inside of a non-scaled image(which can't be seen), nothing happens.

What do you mean by scaled ?!

On android we use:
https://github.com/react-native-mapbox-gl/maps/blob/master/android/rctmgl/src/main/java/com/mapbox/rctmgl/components/mapview/RCTMGLMapView.java#L547
So it must be an an upstream queryRenderedFeatures issue with iconTextFit both.

I can see this issue as well
here is the issue video
https://user-images.githubusercontent.com/75946509/203498379-83ddac9a-0b83-4fa4-8f22-03fb65e7d34a.mov


straight-check-all/package does nothing

I regularly do a straight-pull-all and straight-check-all, but for a while now the latter hasn't done anything despite plenty of repos fast-forwarding. Same goes for straight-check-package on an updated package. One time, a week or so ago, the commands were working, but once I restarted Emacs it no longer worked and hasn't since. I hadn't modified my straight.el configuration before this issue arose. The value of straight-check-for-modifications is (find-at-startup find-when-checking). Not sure what other information is relevant to this, so let me know what else I can provide.

I can reproduce this issue. Thanks for reporting it. I'm not sure what's wrong.

I've got a similar issue where straight-rebuild-all does nothing in Emacs batch mode despite several packages being fast-forward merged.
Might be related to #412 as well.

M-x straight-rebuild-all should rebuild everything completely independent of whether any files have changed. If that's not the case, then something is seriously wrong.

It looks that this is fixed by:<PHONE_NUMBER>4416f595fb3e661796e9fea375dd6b

Oh lol I always forget to check which bugs I'm fixing


230-yolov8-optimization-benchmark

After the YOLOv8 model is converted to openvino, is the input image size dynamic? When testing, the inference speed is related to the input image size

@af-doom yes, we are export model with dynamic input shape, for benchmarking we are use benchmark_app which allow to specify target input size for benchmarking (by default we are use 640x640)

@af-doom yes, we are export model with dynamic input shape, for benchmarking we are using benchmark_app which allows to specify the target input size for benchmarking (by default we are using 640x640)
Thank you for your quick reply, but the detection time is related to the image size. How should I set the detection input to (640x640)

Do you mean in benchmark app or here?

inside notebook, benchmarking called by this comand:
benchmark_app -m $int8_model_det_path -d $device -api async -shape "[1,3,640,640]" -t 15

shape parameter declares input data shape for benchmarking,
more details about benchmark_app parameters can be found in documentation

Sorry, no, it's openvino

Do you mean in benchmark app or here?
Sorry, no, it's openvino

@af-doom  could you please provide more context, what you trying to run?
benchmark_app is openvino component, it is tool used for performance openvino model, so it is also run openvino.
Regarding just running inference using API, dynamic shapes mean that model accepts data of different input size, you need just provide data of shape what you need (resize image to specific size for example using preprocessing)

@af-doom could you please provide more context, what you trying to run?
benchmark_app is openvino component, it is tool used for performance measurement of openvino model, so it is also run openvino.
Regarding just running inference using API, dynamic shapes mean that model accepts data of different input size, you need just provide data of shape what you need (resize image to specific size for example using preprocessing)

Thank you very much for your reply


[Tracking] closable issues

[x] #2416: no response; seems fixed
[x] #2666: support provided, lack of response
[x] #2692: fixed
[x] #2696: seems fixed, no response
[x] #2967: won't implement (at least for now)
[x] #3021: obsoleted by #4268
[x] #3051: won't support zsh version
[x] #3129: no response
[x] #3193: unnecessary, polluted PR
[x] #3350: lack of response
[x] #3531: presumably solved, original poster unresponsive
[x] #3557: obsoleted by #4099
[x] #3624: obsoleted by #4268
[x] #3643: removes what is a feature of the kolo theme
[x] #3645: lack of response
[x] #3656: wontfix; current behavior looks intentional
[x] #3666: obsoleted by #3731
[x] #3672: obsoleted by #4099
[x] #3832: obsoleted by #4268
[x] #3879: won't implement; polluted PR from master branch
[x] #3895: support given
[x] #4043: obsoleted by #4342
[x] #4065: yet another case of wrong symbols for powerline themes
[x] #4048: fixed in #4230 by yourself @mcornella, as you said in #4048 (comment)
[x] #4144: obsoleted by #4342 and #4349
[x] #4157: seems fixed, no response
[x] #4179: seems to be solved for the time being
[x] #4206: won't implement
[x] #4265: solved
[x] #4281: obsoleted by #4268
[x] #4295: lack of response (even 20 minutes after :disappointed:)
[x] #4297: obsoleted by #4342
[x] #4400: solved by #4337
[x] #4405: question answered
[x] #4477: won't implement

How about

[ ] #3531: looks resolved by fixing user locale, no recent response

Added!

[ ] #3879: won't implement; polluted PR from master branch

Okie dokie!

[ ] #4405: question answered

Done

[ ] #3656: wontfix; current behavior looks intentional

done

[ ] #4157: seems fixed, no response

[ ] #4048: Fixed in #4230 by yourself @mcornella, as you said in https://github.com/robbyrussell/oh-my-zsh/issues/4048#issuecomment-136826150

Awesome job, by the way!

Added. This time it won't take long before they're closed :grin:

Ok, that should be all. From now on, no more closing-issues lists! :blush:

Couple more?

[ ] #3843: no response; seems off-topic for OMZ
[ ] #3830: no response; user configuration?
[ ] #3129: no recent response

done

Couple more:

[ ] #4105: no new themes
[ ] #4062: no new themes

[ ] #4494: no response, looks answered.

All done


[FEATURE REQUEST] Import .BSP using Unified Decompiler library

Maybe possible to integrate directly .BSP Import using https://github.com/twhl-community/HalfLife.UnifiedSdk.MapDecompiler library?
(+ Window with settings)

+1

Checkout latest-bsp-dec release
Had few hours to implement decompiler
Release based on .net6, so it can have .netcore specific issues
NOT RECOMMENDED to use as main editor, as .netcore version is untested, you can download it to different folder
I plan to move whole project to .net6, since MapDecompiler is based on .net6 - i might implement future features on that version
Planning to move decompiler as separate feature (now it is unified with 'Open file' feature)

Changed method using that library.
To avoid mixing licenses - separated DecompileTool into different project, and provided setting to enable/disable tool by user


Installer error selecting an existing service account

I am running the newv2.1.0 installer on my Cloud Shell with the command line options for the first time.
python install/gcp_installer.py \
	--cloudsql-region us-central1 \
	--gcs-location us-central1 \
	--gsuite-superadmin-email<EMAIL_ADDRESS>\
	--notification-recipient-email<EMAIL_ADDRESS>\
	--sendgrid-api-key ******** \
	--type server \
	--advanced \
	--dry-run

And I get to the part where it asks me if I want to Create or Reuse a GCP service account and so I enter 2 for "Reuse" and then it shows me the 4 existing service accounts in the project and I enter 2 again to the select the second service account in the list, and then I get a traceback:
Enter the number of your choice: 2
<EMAIL_ADDRESS>This is a dry run, so skipping this step.
Traceback (most recent call last):
  File "install/gcp_installer.py", line 23, in <module>
    gcp_installer.run()
  File "/home/sa_karlsson/forseti-security/install/gcp/gcp_installer.py", line 129, in run
    forseti_setup.run_setup()
  File "/home/sa_karlsson/forseti-security/install/gcp/installer/forseti_installer.py", line 137, in run_setup
    bucket_name)
  File "/home/sa_karlsson/forseti-security/install/gcp/installer/forseti_server_installer.py", line 115, in deploy
    deployment_tpl_path, conf_file_path, bucket_name)
  File "/home/sa_karlsson/forseti-security/install/gcp/installer/forseti_installer.py", line 251, in deploy
    message=loading_message)
  File "/home/sa_karlsson/forseti-security/install/gcp/installer/util/utils.py", line 436, in start_loading
    if exit_condition_checker and exit_condition_checker():
  File "/home/sa_karlsson/forseti-security/install/gcp/installer/forseti_installer.py", line 246, in <lambda>
    deployment_name, constants.DeploymentStatus.DONE))
  File "/home/sa_karlsson/forseti-security/install/gcp/installer/util/gcloud.py", line 849, in check_deployment_status
    deployment_name, '--format=json'])
  File "/home/sa_karlsson/forseti-security/install/gcp/installer/util/utils.py", line 379, in run_command
    stderr=subprocess.PIPE)
  File "/usr/lib/python2.7/subprocess.py", line 390, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1024, in _execute_child
    raise child_exception
TypeError: execv() arg 2 must contain only strings

Same issue also if I attempt to "Create GCP Service Account".


Add a git clean to bazel deps to get around protobuf BUILD issues

"Fixes" https://github.com/grpc/grpc/issues/9677

This seems to generate failures with sanity_linux_opt_native.tools/distrib/check_nanopb_output.sh, I'm abandoning this PR.


Bug: Enter key on react-bootstrap-typeahead doesn't submit

Environment
Host

item
version

GROWI
v3.1.9

How to reproduce? (再現手順)

Input any string to react-bootstrap-typeahead

HeaderSearchBox
NewPageNameInputter

Press enter key

What happens?  (期待される動作)

Form is submitted

Note

react-bootstrap-typeahead above v3.1.0 omitted submitFormOnEnter

fixed by #514


SerenityBDDReporter

SerenityBDDReporter should be improved to:

[x] work with the latest version of TypeScript #156 #105
[ ] make it easier to add custom domain events #161 #126 #59
[ ] support additional tags #132 and improve tag handling in general #110
[ ] correctly handle mocha's before and after hooks #171 #104
[x] support multi-example scenarios #168 #220

Stay strong /o/ (chearleader mode) !

Hope you're still doing good. I look forward to seeing the Jest integration (as this seem to be a prerequisite). Stay brave :)!

Thanks, much appreciated! There's quite a few things I needed to improve, you can see the progress so far on the 2.0 branch

The new SerenityBDDReporter is available as part of the @serenity-js/serenity-bdd module. Thanks for your patience and support!


found the missing part and corrected it.

Now the search is visible.

done! I have updated the code.

Thanks for contributing!

Thank You so much for merging.


Use require extensions instead of vm.runInContext

Parser does not work with external prop validation library (e.g. prop-types), mixin generator pattern (a function returning mixin) and external props.
You should instead use https://github.com/jackmellis/require-extension-hooks-vue to require vue components.

P.S. Nice work guys. Loved vue-styleguidist.

closing, as we do not intend to go down that route.


Need aws-lambda-adapter support a new way for deployment - via ZIP not only container

Hello @bnusunny,
As we already have CD pipeline from S3 to lambda, is there any way to deploy existing services using aws-lambda-adapter via S3 (a zip package)?

This is possible using Custom Runtime. For other managed runtimes, I need to do some research.

@Crescent617  I added an example to show to use Lambda Adapter with managed runtimes. Check it out here.

@bnusunny is there an example of this extension running on a custom runtime?

Not yet. What language you use with a custom runtime? @rohanshiva

@bnusunny I am just exploring custom runtimes so I wanted to see if there was already an example of this extension running on a custom runtime to learn a bit more. I don't have a language in my mind, but I am thinking of just creating a generic custom runtime that can run both node and python apps.

Custom runtime is more suitable for running PHP, rust, and other languages not have managed runtimes. I can create a simple example for running a web app written in Rust.

@bnusunny that would be great

@rohanshiva I pushed an axum example in PR#56.

thank you so much! @bnusunny


关于AMP

开启或关闭AMP对性能是否有影响？

Using AMP for training will reduce GPU memory consumption and speed up the training process. Meanwhile, performance(AUC, NP, P, ...) on datasets is generally not affected whether AMP is used or not.


Dashboard - Refactor GraphQL Services to support cassandra schema

The GraphQL schema and resolvers will need to be refactored to support reading / writing it's data from Cassandra. Currently, our graphql servers read / write data from azure table storage and postgres. This needs to be refactored to read / write from only cassandra. Postgres will only be used for news feed queries to collect the feature ids that intersect with the users current map bounds from the heatmap.
We should reorganize the existing schema to consolidate the flow-based type definitions.
What complete means
Here's a listing of the schemas that will need to be refactored

Edges Schema(used for terms and locations) - This will also need to support both entities, data source and source publisher.
Messages Schema
Facts Schema should be consolidated into the Messages Schema
Settings Schema
Tiles Schema
Aggregated Edges - popular locations, popular terms, etc

A listing of the refactored resolvers that will need to be adjusted

Edges: terms, locations, removeKeywords, addKeywords, saveLocations, removeLocations, popularLocations, timeSeries and topSources
Facts(should be consolidated into Messages): list & get
Messages: byBbox, byLocation, byEdges, eventDetails, publishEvents, translate and translateWords
Settings(ie the admin interface services): sites, createOrReplaceSite, modifyFacebookPages, modifyTrustedTwitterAccounts, removeFacebookPages, removeTrustedTwitterAccounts, modifyTwitterAccounts, removeTwitterAccounts, twitterAccounts, trustedTwitterAccounts, facebookPages, facebookAnalytics, termBlacklist, modifyBlacklist, removeBlacklist
Tiles: fetchTilesByBBox, fetchTilesByLocations, fetchPlacesByBBox, fetchEdgesByLocations and fetchEdgesByBBox

This task should be implemented after #17 -- in #17 we're going to re-implement all the existing resolvers in function of the new Cassandra data schema. After that is done, we can add new functionality as described in this task.


[API Proposal] Expose SqlConnection.IsAzureDb

Provisioning and/or runtime logic may depend on whether a specified SqlClient DataSource is traditional MSSQL or AzureDb.
The aim of this proposal is to expose the existing function for public consumption.
Rationale and Usage
This can be done in custom code by emulating the same logic as the ADP class, however that approach is fragile should (say) Azure open another endpoint (as happened with database.chinacloudapi.cn and secure.windows.net).
Here's an example callsite where we'd harden a user-supplied connection string (app.config) for SqlAzure. Today we do this via the emulation described above.

SqlConnectionStringBuilder sqlCsb = …; // Load from app.config
if (sqlCsb.IsAzureDb)
{
    sqlCsb.TrustServerCertificate = false;
    sqlCsb.Encrypt = true;
    … // Different security, retry policy, timeouts, etc
}

Proposed API
// Existing: src/System.Data.SqlClient/src/System/Data/Common/AdapterUtil.SqlClient.cs
namespace System.Data.Common
{
    internal static partial class ADP
    {
        // Code compares DataSource against a set of (internally) well-known endpoints
        internal static bool IsAzureSqlServerEndpoint(string dataSource) { … }
    }
}

// Suggested public api
public sealed class SqlConnectionStringBuilder
{
    public bool IsAzureDb => ADP.IsAzureSqlServerEndpoint(this.DataSource);
}

// and/or
public sealed class SqlConnection
{
    public bool IsAzureDb => ADP.IsAzureSqlServerEndpoint(this.DataSource);
}

Details

This would appear to be low-risk, since the functionality already exists and is leveraged by SqlClient.
The internal method may need to be hardened against nulls, casing, etc

Questions

Not sure what the best name for this property would be; IsAzureSql, IsAzure, IsAzureDb, IsAzureDataSource, IsAzureEndpoint
Not sure whether to expose this property on one or both classes
Not sure whether it should be a concrete property on the class(es) or rather extension method(s)

We can't guarantee that it always returns the correct value. And it could change over time. Right now those functions are used in places that continue to work if the method returns the wrong result. If you want to code a function into your app that does the same thing, SqlClient currently looks for the following endsWith in the datasource:
.database.chinacloudapi.cn
.database.windows.net
.database.cloudapi.de
.database.usgovcloudapi.net

I just want to reiterate the existing function's limitations. If it were to be made into a public API, we would want to ensure that it always returned the correct answer. Right now, it uses a brittle method of simply parsing the data source name, which may change in the future.
It's okay to do that where it is used internally because it's not used for critical functionality and if it's wrong, things still work, just a little differently. I would consider the setting of encrypt/trustservercertificate values to be security-critical and I would not want anyone depending on the current internal IsAzureDb implementation for those values.

Thanks @David-Engel, that is a good argument why it's not a safe bet.


Drag n drop tags

👍 😎 👍
You can drag tags from the tag tray onto any video and the tag will be added 😁

Ready 🚀
Was easier than expected 😁


subtitledBy="DATE" not working on Bar Chart

I have added subtitledBy="DATE" to all my line charts without any problems, but when I added it to a bar chart HOST was not displayed and the displayed date string was incorrect:
I want to see:   12 Oct 2019
but it shows:    00:04:49 Oct 12
Here is an extract from my XML file:

<yAxis label="KB/s"/>

<data stat="AVERAGE">
  <type name="IOADAPT" />
    <!-- Select only fcsN_read-KB/s,fcsN_write-KB/s fields,
         and ignore fcsN_xfer-tps-->
    <field regex="(.*)-KB/s"  aliasByGroup="1"/>
</data>

<data stat="WEIGHTED_AVERAGE">
  <type name="IOADAPT" />
    <field regex="(.*)-KB/s" aliasByGroup="1"/>
</data>

<data stat="MAXIMUM">
  <type name="IOADAPT" />
    <field regex="(.*)-KB/s" aliasByGroup="1"/>
</data>

Does setting dateFormat="'HOST' HH:mm:ss MMM dd" in the <barChart> element give you what you want?
You might also need to set the barsNamedBy attribute to STAT or FIELD_STAT to get everything charted correctly.
If you want to play around with this, it might be easier to do it in the GUI. Select View -> Custom Report in the menu and it will load a window that you can load and reload the report xml as you make change.

My message above was truncated for some reason. Here is the first part of the chart definition that I couldn't get to work for a bar chart:

<yAxis label="KB/s"/>

It was truncated again. I'll attach it instead.
barchart.txt

That looks correct to me and it seems to be parsing ok. What isn't working?

HOST was not displayed and the displayed date string was incorrect:
I want to see: HOST - 12 Oct 2019
but it shows: 00:04:49 Oct 12

Yes, this is a bug. Can you build from source and see if this fixes your issue?
In the current release you could also remove the barsNamedBy and categoriesNamedBy attributes to have the subtitle show up right, but I assume this won't be what you want.


Added Server with same name not adding data to InfluxDB

After added second server Then no data in InfluxDB added when this server checks
was only 21197 , added 13956 .

Using latest version in Unraid (linux x64)

When added another server with different name its OK.

but host "speed2.hot.net.il" data for same name 'HOT' is missing in influxDB

I suspect it's something with InfluxDB and not Speedtest Tracker. Speedtest Tracker doesn't care what the server attributes are, it just sends the data payload to InfluxDB.

just sends the data payload to InfluxDB
i think you right , after checked file:
https://github.com/alexjustesen/speedtest-tracker/blob/f65d35eccd65eebfa15c3edd5a4cff7f93e8f355/app/Jobs/SendDataToInfluxDbV2.php

but no idea what problem in influxDB maybe for it ...

Going to close this out as it seems to be an InfluxDb issue

Going to close this out as it seems to be an InfluxDb issue

OK, will be good to know if someone using export to influxDB with same name servers have this issue also ?!?

@alexjustesen
i think i have error on this check when second server with same name run :

i think this server (13956 - HOT) check, somehow dont include key "packetLoss" so becose of it ,dont write to influxdb,
then when 1st server (  21197 - HOT)check return i have next error :

but all checks i have in speedtest tracker available


Support Julia 0.7/1.0

There is a guide of what current packages should do to support the new package manager?

Not sure yet, there is a talk on Pkg3 from JuliaCon:
https://m.youtube.com/watch?v=GBi__3nF-rM

So basically many things fail. Below are what I know so far

ReverseDiff doesn't support 0.7 (https://github.com/JuliaDiff/ForwardDiff.jl/issues/345)

I can work around this by using Requires

Mamba has a dependency which doesn't support 0.7

I will probably remove it anyway

New coroutine interface - we didn't fix the warning in 0.6
I guess we should fix it first

@yebai Can you take care of updating the coroutine thing?

Oh I actually manage to hack it.

After fixing things mentioned above, I meet a problem in out compiler. I guess there is some change which makes our implementation doesn't work any more. I pushed my branch (https://github.com/TuringLang/Turing.jl/tree/github.com/TuringLang/Turing.jl/issues/462) with temp-fixes described above which makes using Turing work. Now below fails and I haven't figured out why
using Turing
@model g() = begin
  x ~ Normal(0, 1)
end
g()
end

with error
ERROR: LoadError: MethodError: objects of type Int64 are not callable
Stacktrace:
 [1] eval at ./boot.jl:319 [inlined]
 [2] eval(::Expr) at ./client.jl:399
 [3] #g#3(::Dict{Symbol,Any}, ::Dict{Symbol,Any}, ::Function) at /Users/kai/.julia/dev/Turing/src/core/compiler.jl:323
 [4] g() at ./none:0
 [5] top-level scope at none:0
in expression starting at <macrocall>:0

Thanks @yebai and @trappmartin !

I just pushed some commits to add Markdown to REQUIRE and resolve one syntax warning.

I resolved some syntax errors in the test. The compiler tests currently fail on my machine, and other tests probably too.

Is Turing Julia 1.0 ready?

We are working on it. Stay tuned.

I fixed the compiler issue. Please check my last two commits: 64b956b95499ccd1d81e1631983daf6ab1156991 and 24ba6cabd996530f4f560664b6622d86e7c86f9a

Until now we can do the following
@model m(x) = begin
  a ~ Normal(0, 1)
  x ~ Nromal(a, 1)
end

mf = m(1)

But when I call mf() I still get an error:
julia> mf()
ERROR: type is immutable
Stacktrace:
 [1] setproperty! at ./sysimg.jl:19 [inlined]
 [2] observe(::Nothing, ::Normal{Float64}, ::Int64, ::Turing.VarReplay.VarInfo) at /Users/kai/.julia/dev/Turing/src/samplers/sampler.jl:92
 [3] ##m_model#368 at ./REPL[2]:65 [inlined]
 [4] ##m_model#368(::Turing.VarReplay.VarInfo, ::Nothing) at ./none:0
 [5] ##m_model#368() at ./none:1
 [6] top-level scope at none:0

This may be related to my hack in 64b956b95499ccd1d81e1631983daf6ab1156991.

I fixed the compiler issue. Please check my last two commits: 64b956b and 24ba6ca

For better readability and maintainability,  I think we should split the compiler into more small functions and add tests to them.

@yebai, @xukai92 I just pushed a few quick fixes to this branch, one to get around the mutability error that @xukai92 is reporting. Feel free to cherry-pick or ignore altogether if not useful.

@yebai No problem! I really hope so, and that we can do a clean refactor to make Turing more maintainable as well.

Presently, I get the following confusing internal error message with @xukai92's code snippet.
using Turing
using Distributions
@model m(x) = begin
         a ~ Normal(0, 1)
         x ~ Normal(a, 1)
end
mf = m(1)
mf()

rec_backtrace at /home/Administrator/buildbot/worker/package_win64/build/src\stackwalk.c:94
record_backtrace at /home/Administrator/buildbot/worker/package_win64/build/src\task.c:246
jl_throw at /home/Administrator/buildbot/worker/package_win64/build/src\task.c:577
jl_type_error_rt at /home/Administrator/buildbot/worker/package_win64/build/src\rtutils.c:118
jl_type_error at /home/Administrator/buildbot/worker/package_win64/build/src\rtutils.c:124
jl_f_issubtype at /home/Administrator/buildbot/worker/package_win64/build/src\builtins.c:415
typeof_tfunc at .\compiler\tfuncs.jl:393
typeof_tfunc at .\compiler\tfuncs.jl:391
typeof_tfunc at .\compiler\tfuncs.jl:396
jl_apply_generic at /home/Administrator/buildbot/worker/package_win64/build/src\gf.c:2182
jl_apply at /home/Administrator/buildbot/worker/package_win64/build/src\julia.h:1538 [inlined]
jl_f__apply at /home/Administrator/buildbot/worker/package_win64/build/src\builtins.c:563
builtin_tfunction at .\compiler\tfuncs.jl:1170
builtin_tfunction at .\compiler\tfuncs.jl:1079
abstract_call at .\compiler\abstractinterpretation.jl:551
abstract_eval_call at .\compiler\abstractinterpretation.jl:798
abstract_eval at .\compiler\abstractinterpretation.jl:883
typeinf_local at .\compiler\abstractinterpretation.jl:1107
typeinf_nocycle at .\compiler\abstractinterpretation.jl:1163
typeinf at .\compiler\typeinfer.jl:15
typeinf_edge at .\compiler\typeinfer.jl:492
abstract_call_method at .\compiler\abstractinterpretation.jl:321
abstract_call_gf_by_type at .\compiler\abstractinterpretation.jl:81
abstract_call at .\compiler\abstractinterpretation.jl:769
abstract_eval_call at .\compiler\abstractinterpretation.jl:798
abstract_eval at .\compiler\abstractinterpretation.jl:883
typeinf_local at .\compiler\abstractinterpretation.jl:1107
typeinf_nocycle at .\compiler\abstractinterpretation.jl:1163
typeinf at .\compiler\typeinfer.jl:15
typeinf_edge at .\compiler\typeinfer.jl:492
abstract_call_method at .\compiler\abstractinterpretation.jl:321
abstract_call_gf_by_type at .\compiler\abstractinterpretation.jl:81
abstract_call at .\compiler\abstractinterpretation.jl:769
jl_apply_generic at /home/Administrator/buildbot/worker/package_win64/build/src\gf.c:2182
abstract_apply at .\compiler\abstractinterpretation.jl:477
abstract_call at .\compiler\abstractinterpretation.jl:525
abstract_eval_call at .\compiler\abstractinterpretation.jl:798
abstract_eval at .\compiler\abstractinterpretation.jl:883
typeinf_local at .\compiler\abstractinterpretation.jl:1107
typeinf_nocycle at .\compiler\abstractinterpretation.jl:1163
typeinf at .\compiler\typeinfer.jl:15
typeinf_edge at .\compiler\typeinfer.jl:492
abstract_call_method at .\compiler\abstractinterpretation.jl:321
abstract_call_gf_by_type at .\compiler\abstractinterpretation.jl:81
abstract_call at .\compiler\abstractinterpretation.jl:769
abstract_eval_call at .\compiler\abstractinterpretation.jl:798
abstract_eval at .\compiler\abstractinterpretation.jl:883
typeinf_local at .\compiler\abstractinterpretation.jl:1107
typeinf_nocycle at .\compiler\abstractinterpretation.jl:1163
typeinf at .\compiler\typeinfer.jl:15
typeinf_edge at .\compiler\typeinfer.jl:492
abstract_call_method at .\compiler\abstractinterpretation.jl:321
abstract_call_gf_by_type at .\compiler\abstractinterpretation.jl:81
abstract_call at .\compiler\abstractinterpretation.jl:769
abstract_eval_call at .\compiler\abstractinterpretation.jl:798
abstract_eval at .\compiler\abstractinterpretation.jl:883
typeinf_local at .\compiler\abstractinterpretation.jl:1107
typeinf_nocycle at .\compiler\abstractinterpretation.jl:1163
typeinf at .\compiler\typeinfer.jl:15
typeinf_edge at .\compiler\typeinfer.jl:492
abstract_call_method at .\compiler\abstractinterpretation.jl:321
abstract_call_gf_by_type at .\compiler\abstractinterpretation.jl:81
abstract_call at .\compiler\abstractinterpretation.jl:769
abstract_eval_call at .\compiler\abstractinterpretation.jl:798
abstract_eval at .\compiler\abstractinterpretation.jl:883
typeinf_local at .\compiler\abstractinterpretation.jl:1107
typeinf_nocycle at .\compiler\abstractinterpretation.jl:1163
typeinf at .\compiler\typeinfer.jl:15
typeinf_edge at .\compiler\typeinfer.jl:492
abstract_call_method at .\compiler\abstractinterpretation.jl:321
abstract_call_gf_by_type at .\compiler\abstractinterpretation.jl:81
abstract_call at .\compiler\abstractinterpretation.jl:769
abstract_eval_call at .\compiler\abstractinterpretation.jl:798
abstract_eval at .\compiler\abstractinterpretation.jl:883
typeinf_local at .\compiler\abstractinterpretation.jl:1107
typeinf_nocycle at .\compiler\abstractinterpretation.jl:1163
typeinf at .\compiler\typeinfer.jl:15
typeinf_ext at .\compiler\typeinfer.jl:567
typeinf_ext at .\compiler\typeinfer.jl:604
jfptr_typeinf_ext_1.clone_1 at C:\Users\Uigedail\AppData\Local\Julia-0.7.0\lib\julia\sys.dll (unknown line)
jl_apply_generic at /home/Administrator/buildbot/worker/package_win64/build/src\gf.c:2182
jl_apply at /home/Administrator/buildbot/worker/package_win64/build/src\julia.h:1538 [inlined]
jl_apply_with_saved_exception_state at /home/Administrator/buildbot/worker/package_win64/build/src\rtutils.c:257
jl_type_infer at /home/Administrator/buildbot/worker/package_win64/build/src\gf.c:275
jl_compile_method_internal at /home/Administrator/buildbot/worker/package_win64/build/src\gf.c:1784 [inlined]
jl_fptr_trampoline at /home/Administrator/buildbot/worker/package_win64/build/src\gf.c:1828
jl_apply_generic at /home/Administrator/buildbot/worker/package_win64/build/src\gf.c:2182
do_call at /home/Administrator/buildbot/worker/package_win64/build/src\interpreter.c:324
eval_value at /home/Administrator/buildbot/worker/package_win64/build/src\interpreter.c:428
eval_stmt_value at /home/Administrator/buildbot/worker/package_win64/build/src\interpreter.c:363 [inlined]
eval_body at /home/Administrator/buildbot/worker/package_win64/build/src\interpreter.c:682
jl_interpret_toplevel_thunk_callback at /home/Administrator/buildbot/worker/package_win64/build/src\interpreter.c:799
unknown function (ip: FFFFFFFFFFFFFFFE)
unknown function (ip:<PHONE_NUMBER>A4990F)
unknown function (ip: FFFFFFFFFFFFFFFF)
jl_toplevel_eval_flex at /home/Administrator/buildbot/worker/package_win64/build/src\toplevel.c:831
jl_toplevel_eval_in at /home/Administrator/buildbot/worker/package_win64/build/src\builtins.c:633
eval at .\boot.jl:319
jl_apply_generic at /home/Administrator/buildbot/worker/package_win64/build/src\gf.c:2182
eval_user_input at C:\cygwin\home\Administrator\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v0.7\REPL\src\REPL.jl:85
macro expansion at C:\cygwin\home\Administrator\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v0.7\REPL\src\REPL.jl:117 [inlined]
#28 at .\task.jl:262
jl_fptr_trampoline at /home/Administrator/buildbot/worker/package_win64/build/src\gf.c:1829
jl_apply_generic at /home/Administrator/buildbot/worker/package_win64/build/src\gf.c:2182
jl_apply at /home/Administrator/buildbot/worker/package_win64/build/src\julia.h:1538 [inlined]
start_task at /home/Administrator/buildbot/worker/package_win64/build/src\task.c:268
WARNING: Base.e is deprecated, use ℯ (\euler) or `Base.MathConstants.e`
 in module Turing
WARNING: Base.e is deprecated, use ℯ (\euler) or `Base.MathConstants.e`
 in module Turing
WARNING: Base.e is deprecated, use ℯ (\euler) or `Base.MathConstants.e`
 in module Turing
Internal error: encountered unexpected error in runtime:
TypeError(func=:<:, context="", expected=Type{T} where T, got=T0<:Real)
┌ Warning: broadcast will default to iterating over its arguments in the future. Wrap arguments of

Seems to me like an issue with the task.c shim.

Seems to me like an issue with the task.c shim.

Did you recompile task.c?

I also get that error but still manage to initialise vi by calling mf().
Also, after making Chain mutable, we are in the stage where we are kind of blocked by Mamba.Chain. As I mentioned in the very beginning of this issue, I disabled Mamba.Chain. I simply did this by commenting out Mamba.Chain and defining a dummy AbstractChain type (see https://github.com/TuringLang/Turing.jl/blob/github.com/TuringLang/Turing.jl/issues/462/src/Turing.jl#L25-L28).
Now when I try to call sample(mf, IS(100)), I get
ERROR: MethodError: no method matching Turing.Chains(::Array{Float64,3}; names=AbstractString["a", "lp"])
Closest candidates are:
  Turing.Chains() at /Users/kai/.julia/dev/Turing/src/Turing.jl:28 got unsupported keyword argument "names"
Stacktrace:
 [1] flatten!(::Turing.Chain) at /Users/kai/.julia/dev/Turing/src/core/io.jl:121
 [2] Turing.Chain(::Float64, ::Array{Turing.Sample,1}) at /Users/kai/.julia/dev/Turing/src/core/io.jl:105
 [3] sample(::getfield(Main, Symbol("###m_model#368")), ::IS) at /Users/kai/.julia/dev/Turing/src/samplers/is.jl:50
 [4] top-level scope at none:0

which is because of the lack of the real implementation of Chain utility functions.

Blocking issues for Julia 1.0

AD: change to Flux.Tracked #457
Mamba.Chain #413
Task communication #466

Waiting for this, thanks for the hard work.


Make "token_ttl" a parameter during "create" new token

I wonder if there is a way to change the token_ttl in a "per token" bases?
For example, once you call "$jwt->create($user, $token_ttl)" to get a token based on the provided "token_ttl" and not in the global config (set in parameters.yml or .env).
If you provide your preferences/restrictions I can submit a request with these changes.

I'm also looking for exactly this feature. I want to create short and long loving tokens.

@toxaco I just figured out, that you can set the exp in an JWT_CREATED event subscriber:
$data['exp'] = time() + 12334;

This is not exactly what I need, but with a little ugly hack you can use the user object to pass context information to the event and set the exp based on that information.

You might be able to do this by setting the default ttl to null and passing the ttl in the payload when creating the token.
lexik_jwt_authentication:
    token_ttl:   null

$payload['exp'] = time() + 36000;
$JWTManager->createFromPayload($user,$payload);

This is possible because the create method of DefaultJWSProvider and LcobucciJWSProvider both only use $this->ttl if $payload['exp'] is not set.

I found an issue with my previous solution as setting the token_ttl to null will bypass the exp validation of the token completely. see #889

I'm also looking for this feature.
Related https://github.com/lexik/LexikJWTAuthenticationBundle/issues/682

@jawira Perhaps you can assist with having a look at the PR918. I can not seem to get those tests working, which prevents the PR from being actioned.


Could not find package laravel/laravel with version 8 in a version installable using your PHP version, PHP extensions and Composer version.

Laravel Version: 9.0.0
PHP Version: 8.1

Description:
Hi I wanna install laravel 8 but whenever I execute this command "composer create-project laravel/laravel:^8.0 example-apps"
I'm getting this error  "Could not find package laravel/laravel with version 8 in a version installable using your PHP version, PHP extensions and Composer version."
but I have all the requirements. what is the issue? thanks

I am using PHP 8.1.2 and used the command you provided. It then started to install Laravel v8.6.11
Still I would recommend you don't create a Laravel 8 Project anymore and start working directly on a Laravel 9 Project.

Can confirm it works as expected for me.
What version of PHP are you using? Sorry for asking that, but the Laravel version you provided in the first line is wrong (9.0), so I'm not sure if the PHP version is also a mistake.
I guess your environment does not have all the requirements. What PHP extension have you installed?

Seems like this works as expected. Thanks @Jubeki & @rimace.


Fix MySql Insecue Messages, Error output and added optional ini path location

Fixes issues:
https://github.com/PowerShell/xMySql/issues/17
https://github.com/PowerShell/xMySql/issues/18
https://github.com/PowerShell/xMySql/issues/20
https://github.com/PowerShell/xMySql/issues/23

@andy1547,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@andy1547, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

@andy1547 Sorry that nobody have reviewed this for so long! Do you have time to work on this PR? If so can you resolve the tests that are failing? When that is done I will review this one!


Creating stats files from more modern sequencer technologies

Hi, I was curious in trying out your tool with some data from some more modern sequencers. I was reading the section on genotyping, and saw the sequencer argument only seems to support some older technologies. The ART dependency seems to not have had a release for around 8 years or so. Is there any way to run the tool on reads from NovaSeq 6000, or even NovaSeq X? Are there plans to update this dependency to allow for more modern types of technology?
Thanks!

Thanks for checking out the tool! Unfortunately ART has not been updated with new machines. That said, the sequencer model seems to play relatively little role in the simulation (to my understanding, it is used for simulating base errors). My approach is to use the most recent model with the corresponding read length. For example, for the NYGC 1000 Genomes data from a NovaSeq 6000 I used HSXn "HiSeqX PCR free (150bp)". I will update the README with that note.

That sounds like a good idea. A note in the README would definitely help. I'll try out the HSXn stats and see how it goes. Thanks!


made some design changes and fixed navbar in mobile version

These are the changes I made:

I have set the social links to the right side of the website in desktop mode, and to the bottom in the mobile version. I made these changes so that now in desktop mode user won't have to scroll to the bottom to see those and the website won't have an unnecessary scroll.
The navbar was not getting closed in the mobile version on clicking the links inside of it, there was a bug in js, fixed it now.
There are some more changes shown in the files because of Prettier extension, the code got formatted.

Here are the changes:

Sure,
I have reverted those design changes. and also the formatting.
The bug in the navbar was that in chrome if we minimize the window, then it doesn't work, because of the window. width condition was written inside the .test() function, so I have sent only that code now.
Thank you for reviewing the changes.


Suggestion: add config option to only break logs of the same type

...as mentioned by https://github.com/hammertater/treechop/issues/2#issuecomment-739562944.
This is not default behavior because modded trees are sometimes composed of multiple types of logs, but it should be an option.

On hold until each log has its own chopped block.

On hold until each log has its own chopped block.

No longer applicable in newer versions


Source files encoding granted to work without additional parameters and how to force source files with non-UTF 8 encoding

This question affects .csv files.

JSON, as per specification (https://tools.ietf.org/html/rfc8259), " JSON text exchanged between systems that are not part of a closed ecosystem MUST be encoded using UTF-8 [RFC3629]."
I assume when HXL is used on XLS, XLSX, the encoding is also enforced. (At least for now, Did not had any issues

[Question] The encoding granted to work out of the box
I have the following assumptions about both libhxl-python when used in other applications and via hxl-proxy:

ASCII files
Non ASCII files "but not using only ASCII (standard English letters and arabic numbers)"
Well encoded UTF-8 (without BOM)
Well encoded UTF-8 (with BOM)

So the question is: in theory, is this correct? (I think that this is more a question related to the python csv than the libhxl itself.)
[Feature] Way to specific source encoding on hxltag
All HXL Command line tools already assume that all HXL input already are UTF8. But some cases, at least on the first command, this may not be true. So my question: is possible to add an additional parameter to the HXL Command line tools to specify the source encoding explicitly? (note: this is about only the source encoding, not the output encoding)
In special the hxltag (Quick description: "Add HXL tags to a raw CSV file.") does not have some way for explicitly cite the source encoding and will raise exception (like "UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe9 in position 1893: invalid continuation byte"), but the libxhl-python already seems to have on most part of the code places to specify the source encoding (so this extra parameter is just not exposed).
Auto discover features of encoding
In theory, I think is possible to try guess the encoding and, at least for the hxltag, may eventually worth the effort to (at least if this does not affect the use on HXL-proxy) implement this. But this issue is just asking about be able to explicitly define on hxltag. But since when scanning the file the hxllib already is doing sample = input.peek(16384).decode(encoding), maybe in addition to the exact part of the error (e.g. still show message like 'UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe9 in position 1893: invalid continuation byte', or at least the 1893 number), also one friendly message that the source file may have bad encoding. This alone could help the user to explicitly define the source encoding.

Thanks for the report.
To do: add an --encoding option to the HXL command-line tools.


Deprecated - Terraform : Scaleway provider

Provider version 2.10 isn't downloadable anymore.
Need to pass to version 2.14 (latest)

v0.9.0 has been validated with scaleway terraform provider v2.16.2.


Support multiple haskell packages in the same repo for DISABLE_SDIST_GIT_CHECK option

We can have per project .packcheck.ignore files and each project can ignore the other project directories. The .packcheck.ignore file can reside in the same directory as the .cabal file.

We perhaps do not need to anything in packcheck to support this. If we have each project in its own directory which contains a .packcheck.ignore, packcheck just needs to list git files under that dir and compare it against the .packcheck.ignore file which it probably already does.


Replace three tie elif statements with one that check equality of player and computer variables

All is done.


Spiral Lane integration

🎉 New feature
Part of #265
Goes on top of #276
Summary
Integrates the SpiralGroundCurve into the builder to get RoadGeometries that support that ground geometry. Note that there are still some issues with tolerances which are underlying to the implementation in #276. The integration is achieved but the tolerance level is extremely high for SmallTownRoads.xodr at the moment.
Test it
Via unit and integration tests.
Checklist

[x] Signed all commits for DCO
[x] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if it affects the public API)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

c211f7e fixes the ground curve issues. Now, it is loading with the right tolerance.

https://github.com/maliput/maliput_malidrive/pull/277/commits/1fae47929e73f5e36729673142ec5d91c0595930 should fix the bazel pipeline.


Support incremental materialization for iceberg

What
Support merge materialisation incremental for iceberg.

Done in https://github.com/dbt-athena/dbt-athena/pull/47


Add producer application

Did you test the deployments somewhere? Please also make sure that your tests succeed

Did you test the deployments somewhere? Please also make sure that your tests succeed

works @yannick-roeder


[6.0][Tests] Update for "swift" diagnostic style change

Cherry-pick #72754 into release/6.0
CCC info incoming

https://github.com/apple/swift-syntax/pull/2587
@swift-ci Please test


Walls - Balance Error

I am getting an error when one side of my pair on walls mode runs out of money due to orders being filled.
Can't it be set up so the bot continues placing orders on the side of the pair where balance is remaining? This is normally a basic functionality of automated market making bots.
"INFO The bot Walls has been disabled"

If you weren't two steps ahead of me there'd be a prospect of being able to remedy your problem..
#15

I dont understand.
Will check back soon.


Possible fix for issue #188

This is  a possible fix for issue #188

Now it correctly parse (= ?r1 ?r2), (= ?r rob), (= (numeric_fluent ?r) (numeric_fluent2 ?r1 ?r2)) where rob is a constant and ?r , ?r1, and '?r2' are action parameters.
Added supports for constants in the arguments of numeric fluents (e.g. (numeric_fluent rob ?r))
Added some informative output for not supported features (e.g. #t as used in PDDL+)
Added one test case for the successful parsing

Still reviewing these changes, but over all they look good. Nice job!
The use of "==" to compare 2 doubles still seems a bit dubious to me. I'm not really sure about the best way to handle this. However, I did come across this approach, which might work.
https://en.cppreference.com/w/cpp/types/numeric_limits/epsilon
In that example, the comparison epsilon value is defined in terms of the machine epsilon value, the magnitude of the values, and the desired precision in ULPs. Perhaps we could just hard code the number of ULPs? (The example uses a value of 2.) Even with hard coding the number of ULPs, the comparison epsilon value will vary with the magnitude of the input values. This seems like it could strike the correct balance between problem generality and ease of use.

Indeed, this could be a good approach in the internals, but at planning level while specifying the domain one is expected to use =. We may handle this case in the proper way in a second PR if ok for you, otherwise we can extend this to handle as suggested.

LGTM!! Merging

We may handle this case in the proper way in a second PR if ok for you, otherwise we can extend this to handle as suggested.
:+1:


Contributors: Extension Methods

Description

Confession: I am not a big fan of having a single public class in its own namespace, so this possibly may affect my views on this discussion.

Now, currently

There is a root directory file Svg/Extensions,cs, which defines a number of extension classes.
There is also a folder Svg/ExtensionMethods, which contains an extension class (with public access), UriExtensions.cs.

Question
Why is there a need to have this folder Svg/ExtensionMethods?
NOTE Please there is no plan to remove this, as it  may result in breaking change (just a wish to understand the thought process here)

It defines a separate namespace Svg.ExtensionMethods
the class UriExtensions is public,.

@mrbean-bremen Got it, just trying to draw a quick attention 😄


Deployment time has increased

Problem: verifying instances message takes a lot of time (typically 30s)

If you want to skip the verification step you can pass --no-verify when you deploy.

Perfect thanks.


Fix for v8 in node 12.

Signed-off-by: Hal Gentz<EMAIL_ADDRESS>⚛👋 Hello there! Welcome. Please follow the steps below to tell us about your contribution.

Copy the correct template for your contribution

🐛 Are you fixing a bug? Copy the template from https://bit.ly/atom-bugfix-pr
📈 Are you improving performance? Copy the template from https://bit.ly/atom-perf-pr
📝 Are you updating documentation? Copy the template from https://bit.ly/atom-docs-pr
💻 Are you changing functionality? Copy the template from https://bit.ly/atom-behavior-pr

Replace this text with the contents of the template
Fill in all sections of the template
Click "Create pull request"

just to check if this is going to be merged anytime soon? Thanks!

+1 checking if this is going to be merged too please

+1 Will this be merged soon? Thanks!

Bump. Any plans to get it merged?

I'm not exactly sure who still has commit access to this repo and who the maintainers are, so, uhhh, I guess I can try pinging everybody who's ever merged a commit here before?
cc @rafeca @smashwilson @maxbrunsfeld @nathansobo @zcbenz @kevinsawicki @lee-dohm @daviwil @anaisbetts @damieng @joefitzgerald I guess :woman_shrugging:

FYI, for folks waiting for this, I've been maintaining a fork, spellchecker-prebuild that is a drop-in replacement (the same code), but with prebuilt binaries. It has this fix rolled into it, and now has Electron 7-compatible binaries published, so you can use it with Electron 7.

Sweet. I was personally planning to maintain a fork at goddessfreya/node-spellchecker until #130 gets merged in. Maybe we can roll our changes in together?

Yeah, I'm game, although unsure of the practical aspects. It looks like I'll be maintaining a prebuild fork indefinitely, and I have spellchecker-prebuild on npm pointing to my fork, so I'm loath to switch off my fork because of the extra work/fiddling it would entail.
Also, I have some hesitation about applying changes before they are released in node-spellchecker because then the versioning story gets confusing, and prebuilds kinda rely on version numbers and releases to function, so it's not as easy to using a git URL or something.
So I'm unsure of how we would do this, although very open to ideas...

Btw it also works well with Electron v8 (currently 8.0.0-beta.5).


Release v1.2 patch apply

Bringing forward some patches from 1.1 branch  (eventually they will be automated)
/hold

panic: test timed out after 30m0s

/retest


Bugfix/colejd/miscellaneous fixes

Resolves #556 and #548.
Edit: Also #608.
Edit: Also made it so that a SingleSubVC doesn't clear when it's loading new data. Might have broken something here but I tested and couldn't find anything. Feel free to revert that commit (c8bbcb9) if you're not into it.
Edit: Also centered the MDC loading indicator to the center of the container view instead of the collection view for SingleSubVC (#473)
Edit: Also fixed the thing where the nav drawer's header color wasn't set properly until the page was changed once

Oh man, great changes. Thank you!
I reverted c8bbcb9 though ;D


zsh shell not detected when installing

I'm using zsh on Mac with oh-my-zsh and when I try to install Starkli using:
curl https://get.starkli.sh | sh

I get the message:
Shell detection variables (for debugging use):
- ZSH_NAME =
- SHELL = /bin/zsh

starkliup: could not detect shell. Add '. /Users/david/.starkli/env' to your shell profile, or manually add '/Users/david/.starkli/bin' to your PATH environment variable.

Not a big deal but it would be nice if I could avoid having to add the path to my config file manually

regarding zsh, for completion , could be nice to add somewhere this in the future doc
starkli completions zsh > ~/.oh-my-zsh/completions/_starkli

I always loose~15minutes trying to remember the exact path to put this..!

@ClementWalter zsh completion is automatically handled. You shouldn't need to do this.
The real problem is that shell completion is only activated when the shell itself is detected, and that zsh is not properly detected, i.e. this issue.

I just pushed an update: https://github.com/xJonathanLEI/starkli/commit/7fb0d5c1f792ff679fcdfc73d461a88c7d883280
@barretodavid Could you please try the curl installation command again to see if it's fixed?
@ClementWalter Cloud you please test if command completion works now? (you might need to delete your custom completion and start a new terminal session first)
Thanks!

@xJonathanLEI I just tried on an Ubuntu VM but same issue:
$ curl https://get.starkli.sh | sh
>>>

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3530  100  3530    0     0   5737      0 --:--:-- --:--:-- --:--:--  5730
Installing starkliup...
######################################################################## 100.0%

Shell detection variables (for debugging use):
- ZSH_NAME =
- SHELL = /usr/bin/zsh

Run '. /home/parallels/.starkli/env' or start a new terminal session to use starkliup.
Then, simply run starkliup to install starkli.

Tried restarting the console but starkliup is not found
starkliup
zsh: command not found: starkliup

I'm using zsh with oh-my-zsh

@xJonathanLEI I did
cargo uninstall starkli
rm -rf ~/.oh-my-zsh/completions/_starkli
cargo install --locked starkli
exec $SHELL

no completion

@ClementWalter Installing from source won't (and shouldn't) work. Shell completion is only done for installation via starkliup.

Should I use the same command curl https://get.starkli.sh | sh to install that latest update?

Because I just tried and got the same issue. And yes, I'm using .zshrc


openms_suite not working

On my instance updating/reinstalling openms_suite does not install the latest tool versions. This would be really handy, because otherwise I would need to maintain the versions of all openms tools manually.
I also could not find a file that describes the suite contents in this repo.
Currently the suite lists old tool versions as "Missing repository dependencies"
e.g. openms_msgfplusadapter | c70264573191= v1
and also some old tool versions as "Installed repository dependencies"
e.g.:

openms_msgfplusadapter | 708c31c03d4f = v4
openms_msgfplusadapter | 2244cc0ac5cd = v6

But the latest version (v7) is not installed.

Could this be because I forgot to increase the tool version in my PR https://github.com/galaxyproteomics/tools-galaxyp/pull/263 (at least for some of the affected tools -- in particular msgfplus...).
mea culpa.
Maybe the planemo tooldshed publishing workflow could need a check for this .. and forgetful contributers like myself.

How do you install the tools? Do you install this from scratch?

just use pip install ephemeris https://github.com/galaxyproject/ephemeris, especially this one https://ephemeris.readthedocs.io/en/latest/commands/shed-tools.html you might also want to install latest master from github.

Got the latest version of ansible-galaxy-tools running. But it seems that the "dependencies" are not installed on my instance. So the state is that 2 old versions of each tool in the suite are installed. I also can install the suite, but the new versions of the tools in the suite are not installed.
the following command is executed
/tmp/venv/bin/python /tmp/venv/bin/shed-tools install -y install_repository_dependencies: true?install_resolver_dependencies: true?install_tool_dependencies: true?name: suite_openms?owner: galaxyp?revisions:?- 0c22108365d1?- 84b7c9bd29da?- 9533f0246dd0?tool_panel_section_label: Proteomics - OpenMS?tool_shed_url: https://toolshed.g2.bx.psu.edu? -a APIKEY -g http://bioinf2:8080

Played around with the options install_repository_dependencies, install_resolver_dependencies, install_tool_dependencies, but even setting all to true does not install the latest revisions of the tools.
the output is always something like:
[songalax@bioinf2 ~]$ cat /tmp/ephemeris__239ih
Storing log file in: /tmp/ephemeris__239ih
(1/3) Installing repository suite_openms from galaxyp to section "Proteomics - OpenMS" at revision 84b7c9bd29da (TRT: 0:00:01.227092)
	repository suite_openms installed successfully (in 0:05:02.734756) at revision 84b7c9bd29da
(2/3) Installing repository suite_openms from galaxyp to section "Proteomics - OpenMS" at revision 9533f0246dd0 (TRT: 0:05:04.537881)
	Repository suite_openms is already installed.
	repository suite_openms installed successfully (in 0:03:42.406959) at revision 9533f0246dd0
(3/3) Installing repository suite_openms from galaxyp to section "Proteomics - OpenMS" at revision 0c22108365d1 (TRT: 0:08:47.520421)
	Repository suite_openms is already installed.
	repository suite_openms installed successfully (in 0:03:17.294711) at revision 0c22108365d1
Installed repositories (3): [('suite_openms', None), ('suite_openms', None), ('suite_openms', None)]

Any ideas. Maybe a bug of shed-tools install?

Yep. I already tried the 0.9 version of ephemeris. I will follow https://github.com/galaxyproject/ephemeris/issues/111 .. thanks


MemcachedKeyCharacterError

Hi,
I am trying to use the @memoize decorator to cache a method in a view, with python-memcached present, like below:
class BlogView(generic.ListView, CoreBreadcrumbs):
    template_name = 'blog/blog.html'
    context_object_name = 'items'

    @memoize(timeout=3600)
    def get_paginate_by(self, queryset):
        return BlogSettings.objects.get().howmany_perpage
...

and I get the following error:
MemcachedKeyCharacterError: Control/space characters not allowed (key=':1:blog.views.BlogView.get_paginate_by.<blog.views.BlogView object at 0x03518AD0>_memver')

Full traceback - https://gist.github.com/DragosChirila/ce814ffd2a4d24e82c78c8cd013288e6
Am I doing something wrong here? Could you please advice?

Hi there,
please try to overwrite __repr__ with something simpler or use Redis. It seems like Memcached has character limitations for keys.

Thanks! Indeed, using something like
    def __repr__(self):
        """ Overwrite this for memcache key generation.
        """
        return '{}.{}'.format(self.__module__, self.__class__.__name__)

seems to work.
Still, I tried also to use the make_name parameter but without success. Do you have a working example with a custom make_name method?

What do you mean by "use the make_name parameter"? What is it?

Looking at the code - make_name has to be callable. What did you use? String?

I did it like this:
    @memoize(timeout=3600, make_name=make_name_for_view)
    def get_paginate_by(self, queryset):
        return BlogSettings.objects.get().howmany_perpage

where
def make_name_for_view(name):
    return 'my custom name'

But, make_name_for_view never gets called.


Hard to move cursor from row to hover

Testing #229359
This is just about our workbench hovers on lists in general, but when I hover a row in the scm graph view, first I feel prompted to hover on the right side of the row where the icons are. Then I get a tall hover on the far left side, and I feel like I should be able to move my cursor straight to the actions at the bottom of that hover box. But the cursor can't leave the narrow list row, or it will disappear.

Adding @Tyriar and @benibenj

Related: https://github.com/microsoft/vscode/issues/228121

Closing in favor of https://github.com/microsoft/vscode/issues/235483


why source code in libs?

Hi Maarten,
Thanks for sharing your work!
I've been working with asp.net core for a while, but very interested in learning orleans, react, redux stack.
In studying the code in this solution, was wondering why the lib folder has source code for things like MailKit/MimeKit/BouncyCastle when there exist .net core compatible nugets for those things?
Thanks,
Joe

I did that because when I wrote this code (in the project.json days) I had several problems getting those dependencies and versions working right (resulting in Assembly Load Exceptions) when using the original NuGet versions.
For instance, some packages use (the old) RxMain dependency while others have (the new) System.Reactive: if you get both of these in the dependency tree they will conflict.
I sometimes also did this to be able to be able to debug into external code, and was just lazy to revert back after I solved the problem.
I think that these problems have mostly resolved themselves now with updated versions of packages, the current Dotnet Core project system and vs 2017. You could try to replace the source versions in lib with the nuget versions of these dependencies. There is no changed functionality in them, I only modified the project files.

Thanks for your prompt response. Are you considering changing back to the nugets in this solution example? If I fork it and get it working with the nugets would you accept a pull request?

I recently updated all dependencies to new versions, and removed all the cloned code in the lib folder in exchange for the respective builds from nuget.


Updated testbed-swift to swift 4 string handling.

Result of Integration 1
Duration: 13 minutes and 27 seconds
Result: Build failed 1 test out of 223

Result of Integration 1
Duration: 13 minutes and 27 seconds
Result: Build failed 1 test out of 223

Result of Integration 3
Duration: 9 minutes and 30 seconds
Result: Build failed 1 test out of 223

Result of Integration 4
Duration: 10 minutes and 27 seconds
Result: All 223 tests passed, but please fix 1 warning.
Test Coverage: 63%

👍


versioning

I would like to use runner in version 0.1.6 since there is a but in newer version https://gitea.com/gitea/act_runner/issues/195. It would be nice if you could tag those images with corresponding version on gitea runner.

Fixed by https://github.com/vegardit/docker-gitea-act-runner/commit/fccc482c5d9e4cd6196d675cf1c7e546b5337864


Password transmitted in plain text via GET-Parameter

Describe the bug
These are two bugs, which lead to passwords being saved in the browser history.
First bug:
Microsoft Edge is unable to execute the Javascript code on https://meetfranz.com/login
Second bug:
When you login via https://meetfranz.com/login, the email address and password are transmitted via the GET parameter instead of the POST parameter if a Javascript error occurred or Javascript is disabled. This leads to the email address and password being saved to the browser history and being visible to other users. In the worst case, this could lead to third party websites being able to access the credentials via the Referrer-HTTP-Header.
To Reproduce
Steps to reproduce the behavior:

https://meetfranz.com/login
Enter any email address and an incorrect password.
Click "Login"
Check the address bar to see the entered email address and password.

Expected behavior
The password should be transmitted via the POST parameter.
Screenshots

Desktop (please complete the following information):
Any with disabled Javascript or an error in the javascript file.
Smartphone (please complete the following information):
Any with disabled Javascript or an error in the javascript file.

I have verified that this is happening in Microsoft Edge 42.17134.1.0 on Windows 10


HTTP 401 status

Hi,
I'm running this project, I guess I'm not understanding well this concepts.
I'm calling /api/v1/tokens.json and getting a token, based on my access's information. But, when I'll call some other secured method I get 401.
I'm using x-wsse and authorization headers:
X-WSSE: UsernameToken Username="andersonkoester", PasswordDigest="C/s2VtFhLHEeKmOgxgjyTWPsU0o=", Nonce="ZWE5Y2Q1YWU1MjdlZTExNQ==", Created="2015-03-03T18:40:55-03:00"
Authorization: WSSE profile="UsernameToken"
My idea is use this project integrated on other sample project I'm programming, but the returns are breaking my head right in the middle.
I don't think it was a issue, like I said, I think I'm not understanding well how it works.

I will check this out

It works when I removed "(role)" from pattern of this security config:
wsse_secured:
pattern:      (.)/(role)(.)
context:      user
stateless:    true
Now, all secured methods are allowed to access with my logged user.

thx for the trick but how do you access to salt.json with your pattern ?

@kahllac, I'm using an unique salt for each user (FOSUserBundle implementation) and it's save on my DB.

sorry, i don't understand. you never call the services user/salt.json ?

I'm sorry, I got it wrong. Let's see my actual security config file:
wsse_secured:
// this line grant security for this url patterns (/mng/, /acocunt/ and /app/) and it can't manage url using this patterns (/account/salt and /account/remember)
pattern:      (.)/(mng|account|app)(?!/(.)(salt|remember))(.)
context:      user
stateless:    true
wsse:
nonce_dir: null
provider: fos_userbundle
lifetime: 6000
anonymous:    false
I realy don't know if this way is the best, but I created, using regular expression, a simple filter on my security configuration to avoid the SecurityBundle deny these two urls that work without authentication token.

thx for your answere. How dide you manage the username param in salt.json call ?
api/v1/users/USERNAME/salt.json

Correct, my salt call is:
/account/{username}/salt.json

Thx, with your pattern and some change it's work.


Linter shows many errors with no reason

When writing any .ts file in Atom there is bunch of errors.
Disabling and enabling plugin (and Atom) helps only for few new lines of code. Then it shows new errors i.e. according to non-existing names of variables or functions.
Please notice that these errors are in part referring to non-existing line.
Atom    : 1.19.4
Electron: 1.6.9
Chrome  : 56.0.2924.87
Node    : 7.4.0
atom-typescript: 11.0.7
UPDATE: Closing file and opening it again clears these errors. But after writing and editing some code they will appear again.
I am trying now on Atom 1.20.0-beta5 but it's still happening.

Same issue here !

Same... i've tried disabling, uninstalling, restarting. It's like the linter functionality is holding on to some old/corrupted versions of files.

This might be related to #1333 in which case the fix is to downgrade to 19.3 or wait for the nice folks on the atom team to fix the TextBuffer implementation.

Finally i downgraded to 1.19.3, I didn't notice any similar problems for now. And I'm waiting for fixing TextBuffer :)

😬  This one's my fault. I merged a fix already. It will go out in Atom 1.19.5.

Works great in 1.19.5.. thanks max!

I still run into this issue in latest 1.20.1 Atom mostly when working with multiple panes.