No spinner / detection of in-progress after "Checking component version"

[kind/Enhancement]

Which functionality do you think we should update/improve?
See: https://asciinema.org/a/Szh9pBMWL5Rbg4gGVC0MvLHdi
After:
 ✓  Checking component
 ✓  Checking component version

There is a pause / hanging with no indication of anything happening.
This is because requests for DeploymentConfig is happening in the background:
 ✓  Checking component version
I0528 14:52:27.886865   17305 occlient.go:2668] Getting DeploymentConfig: example-dotnet-sjco-app
I0528 14:52:27.954528   17305 component.go:897] Source for component example-dotnet-sjco is file:///tmp/binary/example.war (binary)
I0528 14:52:27.954575   17305 url.go:78] Listing routes with label selector: app.kubernetes.io/name=app,app.kubernetes.io/component-name=example-dotnet-sjco
I0528 14:52:28.090355   17305 occlient.go:2668] Getting DeploymentConfig: example-dotnet-sjco-app
I0528 14:52:28.232134   17305 occlient.go:2668] Getting DeploymentConfig: example-java-fiov-app
I0528 14:52:28.277958   17305 component.go:897] Source for component example-java-fiov is file://example.war (binary)
I0528 14:52:28.278008   17305 url.go:78] Listing routes with label selector: app.kubernetes.io/name=app,app.kubernetes.io/component-name=example-java-fiov
I0528 14:52:28.410503   17305 occlient.go:2668] Getting DeploymentConfig: example-java-fiov-app
I0528 14:52:28.541864   17305 occlient.go:2668] Getting DeploymentConfig: foobar-app
I0528 14:52:28.588473   17305 component.go:897] Source for component foobar is file://./ (local)
I0528 14:52:28.588529   17305 url.go:78] Listing routes with label selector: app.kubernetes.io/name=app,app.kubernetes.io/component-name=foobar
I0528 14:52:28.719871   17305 occlient.go:2668] Getting DeploymentConfig: foobar-app
I0528 14:52:28.782189   17305 request.go:485] Throttling request took 62.161897ms, request: GET:https://api.engint.openshift.com:443/apis/apps.openshift.io/v1/namespaces/foo/deploymentconfigs/foobar-app
I0528 14:52:28.982332   17305 request.go:485] Throttling request took 159.347011ms, request: GET:https://api.engint.openshift.com:443/apis/apps.openshift.io/v1/namespaces/foo/deploymentconfigs?labelSelector=app.kubernetes.io%2Fname%3Dapp%2Capp.kubernetes.io%2Fcomponent-name%3Dfoobar
I0528 14:52:29.182426   17305 request.go:485] Throttling request took 154.431478ms, request: GET:https://api.engint.openshift.com:443/apis/apps.openshift.io/v1/namespaces/foo/deploymentconfigs?labelSelector=app.kubernetes.io%2Fcomponent-name%3Djava-fwwm%2Capp.kubernetes.io%2Fname%3Dapp
I0528 14:52:29.227504   17305 occlient.go:2668] Getting DeploymentConfig: java-fwwm-app
I0528 14:52:29.382125   17305 request.go:485] Throttling request took 154.474067ms, request: GET:https://api.engint.openshift.com:443/apis/apps.openshift.io/v1/namespaces/foo/deploymentconfigs/java-fwwm-app
I0528 14:52:29.425390   17305 component.go:897] Source for component java-fwwm is file://./ (local)
I0528 14:52:29.425440   17305 url.go:78] Listing routes with label selector: app.kubernetes.io/name=app,app.kubernetes.io/component-name=java-fwwm
I0528 14:52:29.582206   17305 request.go:485] Throttling request took 107.926258ms, request: GET:https://api.engint.openshift.com:443/apis/apps.openshift.io/v1/namespaces/foo/deploymentconfigs?labelSelector=app.kubernetes.io%2Fname%3Dapp%2Capp.kubernetes.io%2Fcomponent-name%3Djava-fwwm
I0528 14:52:29.681235   17305 occlient.go:2668] Getting DeploymentConfig: java-fwwm-app
I0528 14:52:29.782169   17305 request.go:485] Throttling request took 100.773444ms, request: GET:https://api.engint.openshift.com:443/apis/apps.openshift.io/v1/namespaces/foo/deploymentconfigs/java-fwwm-app
I0528 14:52:29.982429   17305 request.go:485] Throttling request took 149.016167ms, request: GET:https://api.engint.openshift.com:443/apis/apps.openshift.io/v1/namespaces/foo/deploymentconfigs?labelSelector=app.kubernetes.io%2Fname%3Dapp%2Capp.kubernetes.io%2Fcomponent-name%3Djava-fwwm
I0528 14:52:30.182525   17305 request.go:485] Throttling request took 155.124043ms, request: GET:https://api.engint.openshift.com:443/apis/apps.openshift.io/v1/namespaces/foo/deploymentconfigs?labelSelector=app.kubernetes.io%2Fcomponent-name%3Dnodejs-nuvb%2Capp.kubernetes.io%2Fname%3Dapp
I0528 14:52:30.225681   17305 occlient.go:2668] Getting DeploymentConfig: nodejs-nuvb-app
I0528 14:52:30.382476   17305 request.go:485] Throttling request took 156.641296ms, request: GET:https://api.engint.openshift.com:443/apis/apps.openshift.io/v1/namespaces/foo/deploymentconfigs/nodejs-nuvb-app
I0528 14:52:30.426136   17305 component.go:897] Source for component nodejs-nuvb is file://./ (local)
I0528 14:52:30.426188   17305 url.go:78] Listing routes with label selector: app.kubernetes.io/name=app,app.kubernetes.io/component-name=nodejs-nuvb
^C

Why is this needed?
This is needed to provide an indication that odo is still working / retrieving information / gathering information.

I have closed this in: https://github.com/openshift/odo/pull/1774
We now have an indicator of what's happening / no more "pausing"


Removed suspected typo

Just reading the source I noticed a double-exclamation point that confused me.  Removing both still passes all tests, so unless this is an advanced technique I'm guessing it's a typo so it might be removed to avoid confusing others.

Hah, nevermind. http://stackoverflow.com/questions/4686583/can-someone-explain-this-double-negative-trick

This kind of thing forces a coercion to a boolean type, it is usually intentional.
In this case, since the JS "&&" short circuits and returns its first value (if it evaluates to boolean true), adding the !! forces the function to return a boolean "true", instead of the value of the "filter" variable.


Update VisualBuilder to Allow External Bundling

It is common for our use-cases to use a Javascript bundler (e.g. Webpack, Browserify, jspm) to load third-party scripts and assets. The current mechanism of an "externalJS" array leaves a lot to be wanted: it demands that developers load scripts and their dependencies in the correct order, and that those dependencies don't have a module-loading mechanism or embedded assets. It also precludes the possibility of a rich asset pipeline that performs linting, transpilation, and embeds styles and data.
This commit allows developers to specify bundle configurations in pbiviz.json, which allow them to sidestep the pbiviz script-building mechanism while retaining the ability to use the pbiviz tool for live-reloading and packaging.
Using this change, here's the configuration I'm using to perform a custom build
pbiviz.json
{
  "visual": {
    "name": "pvtest",
    "displayName": "pvtest",
    "guid": "PBI_CV_34C79648_8924_4ACD_BE2B_F90F209A8CBA",
    "visualClassName": "Visual",
    "version": "1.0.0",
    "description": "",
    "supportUrl": "",
    "gitHubUrl": ""
  },
  "bundle": {
    "js": {
      "path": ".tmp/drop/visual.bundle.js"
    }
  },
  "apiVersion": "1.1.0",
  "author": {
    "name": "",
    "email": ""
  },
  "assets": {
    "icon": "assets/icon.png"
  },
  "externalJS": [
  ],
  "style": "style/visual.less",
  "capabilities": "capabilities.json"
}

webpack.config.js:
const path = require('path');
const webpack = require('webpack');

module.exports = {
    entry: path.join(__dirname, '.tmp', 'build', 'transpiled', 'visual.js'),
    output: {
        path: path.join(__dirname, '.tmp', 'drop'),
        filename: 'visual.bundle.js'
    },
    module: {
        loaders: [
            { test: /\.css$/, loader: 'style!css' },
            { test: /\.(js|jsx)$/, loaders: [ 'imports?powerbi=>window["powerbi"]' ] }
        ]
    },
    plugins: [
      new webpack.optimize.OccurenceOrderPlugin(),
      new webpack.DefinePlugin({
          'process.env': {
              'NODE_ENV': JSON.stringify(process.env.NODE_ENV || 'development')
          }
      })
    ]
};

tsconfig.json
{
  "compilerOptions": {
    "allowJs": true,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "target": "ES5",
    "sourceMap": false,
    "out": "./.tmp/build/transpiled/visual.js"
  },
  "files": [
    ".api/v1.1.0/PowerBI-visuals.d.ts",
    "typings/index.d.ts",
    "./src/visual.ts"
  ]
}

package.json
{
  "name": "visual",
  "devDependencies": {
    "imports-loader": "^0.6.5",
    "onchange": "^2.5.0",
    "typescript": "^1.8.10",
    "typings": "^1.3.2",
    "webpack": "^1.13.1"
  },
  "dependencies": {
    "debug": "^2.2.0"
  },
  "scripts": {
    "tsc": "tsc",
    "webpack": "webpack",
    "watch:tsc": "npm run tsc -- -w",
    "watch:webpack": "npm run webpack -- -w",
    "watch:copy": "onchange '.tmp/drop/visual.bundle.js' -- npm run copy",
    "watch": "npm-run-all -p watch:*",
    "copy": "cp .tmp/drop/visual.bundle.js .tmp/drop/visual.js",
    "start:pbiviz": "pbiviz start",
    "start": "npm-run-all tsc webpack copy -p watch start:pbiviz"
  }
}

src/visual.ts
const log = require("debug")("Visual");

module powerbi.extensibility.visual.PBI_CV_34C79648_8924_4ACD_BE2B_F90F209A8CBA.PBI_CV_34C79648_8924_4ACD_BE2B_F90F209A8CBA  {
    log("Loading Visual");
    export class Visual implements IVisual {
        private target: HTMLElement;
        private updateCount: number;

        constructor(options: VisualConstructorOptions) {
            log("Visual constructor", options);
            this.target = options.element;
            this.updateCount = 0;
        }

        public update(options: VisualUpdateOptions) {
            log("Visual update", options);
            this.target.innerHTML = `<p>Update count: <em>${(this.updateCount++)}</em></p>`;
        }

        public destroy(): void {
            // TODO: Perform any cleanup tasks here
        }
    }

    export var PBI_CV_34C79648_8924_4ACD_BE2B_F90F209A8CBA = {
        name: 'PBI_CV_34C79648_8924_4ACD_BE2B_F90F209A8CBA',
        displayName: 'pvtest',
        class: 'Visual',
        version: '1.0.0',
        apiVersion: '1.1.0',
        create: (options) => new powerbi.extensibility.visual.PBI_CV_34C79648_8924_4ACD_BE2B_F90F209A8CBA.Visual(options),
        custom: true
    };
}

Hi @darthtrevino, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

I'm going to commit a template to automate some of this boilerplate

Just as a note the externalJS attribute only exists because typescript has a bug in versions prior to 2.0 that doesn't compile some javascript libraries (ex. pixijs) defined in tsconfig properly. This was to serve as a workaround.
Agreed that it might be useful to have a notion of different types of "builders", though I don't like the idea of this being controlled via a config, and it makes future updates to the tool more complicated and difficult to test.
A better change would be to decouple the builder entirely, and allow for developers to specify which one they would like to use by importing the right module. Having said that, the thing to keep in mind is that we perform some changes "pre-compile" to ts/less files to encapsulate the code. You seem to have gotten around that by manually specifying the plugin in the ts config, which is incorrect as the plugin is an internal concept and we want to have full control on its generation since it provides critical information on what version of adapters to load and how to create visuals.
I would suggest if you still want to use webpack (or others) to build/bundle your code, you can, but just have it all bundle into one JS file and include that into your TS config and keep only the visual shell in the TS file.

Your concerns sound reasonable. The approach you're describing is problematic though. Bundlers will crawl a dependency graph using require or import statements starting from an entry point script. This entry point is usually the point at which you mount your application into the DOM. In the setup you described, we want to access functions that have been made available within the bundle and use them in the Typescript bootstrapping script to initialize the app.
To pull this off in webpack, we need to use either the expose-loader or the script-loader to define functions that the visual can use to begin rendering. These loaders are executed in the global context (window object), which means these bootstrapping functions that Typescript would use are window globals. This is just as, if not more dangerous than having the visual GUID embedded in your code.
I'll research this a bit more to see if there's a way around that, but the ideal scenario would be webpacking the visual starting at the root. This may be an appropriate case for a custom webpack plugin that could inject the GUID-modified namespaces into the bootstrapping sequence.

I played around with making a Webpack plugin last night, and it looks promising. The bundling configuration would look like this:
const path = require('path');
const webpack = require('webpack');
const PowerBIVisualPlugin = require('./PowerBIVisualPlugin');

module.exports = {
    entry: path.join(__dirname, 'src/visual.ts'),
    output: {
        path: path.join(__dirname, '.tmp', 'webpack'),
        filename: 'visual.bundle.js'
    },
    module: {
        loaders: [
            { test: /\.css$/, loader: 'style!css' },
            { test: /\.(ts|tsx)$/, loaders: [ 'ts', 'imports?powerbi=>window["powerbi"]' ] }
        ]
    },
    plugins: [
      new PowerBIVisualPlugin(require('./pbiviz.json')
    ]
};

PowerBI Visual Plugin: This is a sketch implementation that uses sentinel comments, which won't work in transpiled TS because it strips the closing comment. However, you can tap into the AST emitter in the plugin and use that to inject the guid-ified namespace without requiring sentinel comments.
const pbiviz = require('./pbiviz.json');

const VISUAL_START = "// powerbi-begin-visual";
const VISUAL_END = "// powerbi-begin-visual";
const guidNsHeader = guid => `
  var ${guid};
  (function (${guid}) {
`;
const guidNsFooter = guid => `
${guid}.Visual = Visual;
})(${guid} = visual.${guid} || (visual.${guid} = {}));
`;

function PowerBIVisualPlugin(options) {this.options = options;}

function wrapEntry(entry, guid) {
  return `
    ${entry.replace(VISUAL_START, guidNsHeader(guid)).replace(VISUAL_END, guidNsFooter(guid))}
    (function (powerbi) {
   	    var visuals;
   	    (function (visuals) {
   	        var plugins;
   	        (function (plugins) {
   	            plugins.${guid} = {
   	                name: '${guid}',
   	                displayName: ...
   	                create: function (options) { return new powerbi.extensibility.visual.${guid}.Visual(options); },
   	                custom: true
   	            };
   	        })(plugins = visuals.plugins || (visuals.plugins = {}));
   	    })(visuals = powerbi.visuals || (powerbi.visuals = {}));
   	})(powerbi || (powerbi = {}));
  `;
}

PowerBIVisualPlugin.prototype.apply = function(compiler) {
  compiler.plugin('compilation', function(compilation, callback) {
    compilation.plugin('seal', function() {
      const entry = compilation.modules[0];
      entry._source._value = wrapEntry(entry._source._value, this.options.visual.guid);
    });
  });
};

module.exports = PowerBIVisualPlugin;


run_once in gather and delegate facts

file-name: ceph-ansible/infrastructure-playbooks/rolling_update.yml
task-name: gather and delegate facts
As per the discussion over, fact gathering optimization for scalability #2553
I think we should have run_once: true in the rolling_update.yml fact gathering too.

name: gather and delegate facts
setup:
delegate_to: "{{ item }}"
delegate_facts: True
with_items: "{{ groups['all'] }}"
when:
- delegate_facts_host | bool

We should have the run_once set in this task this way. Isn't it?

name: gather and delegate facts
setup:
delegate_to: "{{ item }}"
delegate_facts: True
run_once: True
with_items: "{{ groups['all'] }}"
when:
- delegate_facts_host | bool

@TamizharasiS that's correct, thanks for reporting this


Recently added songs

It would be great if the method of adding recent songs was added.

It will be handled along with #27


Require explicit listener for /live/song/beat

Rather than automatically sending /live/song/beat to localhost, add a start_listen endpoint. Also means that any IP could register to listen for beat events.

Is this something you're working on, or are you looking for help? I'm currently looking through the codebase trying to understand how you put it together, so i can hack it for my own specific use case :P

Now done.

Start listening for beat events: /live/song/start_listen/beat
Beat events will be sent to /live/song/get/beat
Stop listening for beat events: /live/song/stop_listen/beat
cc @Coupe70


Ability to pan

Currently, there does not seem to be any way to pan across the diagram other than zooming in and out. It would greatly improve the user experience to implement a panning function (for example with space + mouse drag)

I agree, as a frequent user of this app, which I use instead of say Powerpoint, this would greatly benefit my life, my workflow, saving a lot of time.

Never mind, its right click and drag 💀


Hex to RGB Color Converter.md

📝 Description
Closes : https://github.com/illacloud/illa-builder/issues/2855
💣 Is this a breaking change (Yes/No):

[ ] Yes
[x] No

🚧 How to migrate?
Don't need.
📝 Additional Information
lol

I have created the UI and added basic program to fill in the text below, but not actually convert the Hex to RGB. The problem is, I'm not able to use a function inside the button trigger script.
I don't think a database is needed for a small application like this. Is it?


example error

Hi i got an error when i tried to run the examples
can you help me?
$ ros2 run dsr_example2_py dsr_service_motion_simple_class
_robot_id =
_robot_model =
_srv_name_prefix =
_topic_name_prefix =
Traceback (most recent call last):
File "/opt/ros/foxy/lib/python3.8/site-packages/rosidl_generator_py/import_type_support_impl.py", line 46, in import_type_support
return importlib.import_module(module_name, package=pkg_name)
File "/usr/lib/python3.8/importlib/init.py", line 127, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 1014, in _gcd_import
File "", line 991, in _find_and_load
File "", line 973, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'dsr_msgs2.dsr_msgs2_s__rosidl_typesupport_c'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/seok2/ros2_ws/install/dsr_example2_py/lib/dsr_example2_py/dsr_service_motion_simple_class", line 11, in
load_entry_point('dsr-example2-py==0.0.0', 'console_scripts', 'dsr_service_motion_simple_class')()
File "/usr/lib/python3/dist-packages/pkg_resources/init.py", line 490, in load_entry_point
return get_distribution(dist).load_entry_point(group, name)
File "/usr/lib/python3/dist-packages/pkg_resources/init.py", line 2854, in load_entry_point
return ep.load()
File "/usr/lib/python3/dist-packages/pkg_resources/init.py", line 2445, in load
return self.resolve()
File "/usr/lib/python3/dist-packages/pkg_resources/init.py", line 2451, in resolve
module = import(self.module_name, fromlist=['name'], level=0)
File "/home/seok2/ros2_ws/install/dsr_example2_py/lib/python3.8/site-packages/dsr_example2_py/dsr_service_motion_simple_class.py", line 24, in
from DSR_ROBOT2 import *
File "/home/seok2/ros2_ws/install/common2/bin/common2/imp/DSR_ROBOT2.py", line 52, in
_ros2_set_robot_mode             = g_node.create_client(SetRobotMode,           _srv_name_prefix +"system/set_robot_mode")
File "/opt/ros/foxy/lib/python3.8/site-packages/rclpy/node.py", line 1249, in create_client
check_for_type_support(srv_type)
File "/opt/ros/foxy/lib/python3.8/site-packages/rclpy/type_support.py", line 29, in check_for_type_support
msg_type.class.import_type_support()
File "/home/seok2/ros2_ws/install/dsr_msgs2/lib/python3.9/site-packages/dsr_msgs2/srv/_set_robot_mode.py", line 256, in import_type_support
module = import_type_support('dsr_msgs2')
File "/opt/ros/foxy/lib/python3.8/site-packages/rosidl_generator_py/import_type_support_impl.py", line 48, in import_type_support
raise UnsupportedTypeSupport(pkg_name)
rosidl_generator_py.import_type_support_impl.UnsupportedTypeSupport: Could not import 'rosidl_typesupport_c' for package 'dsr_msgs2'

I have same problem.
~/doosan_ws$ ros2 run dsr_example2_py dsr_service_motion_simple
_robot_id =
_robot_model =
_srv_name_prefix =
_topic_name_prefix =
Traceback (most recent call last):
File "/home/loungelab/doosan_ws/install/dsr_example2_py/lib/dsr_example2_py/dsr_service_motion_simple", line 11, in
load_entry_point('dsr-example2-py==0.0.0', 'console_scripts', 'dsr_service_motion_simple')()
File "/usr/lib/python3/dist-packages/pkg_resources/init.py", line 490, in load_entry_point
return get_distribution(dist).load_entry_point(group, name)
File "/usr/lib/python3/dist-packages/pkg_resources/init.py", line 2854, in load_entry_point
return ep.load()
File "/usr/lib/python3/dist-packages/pkg_resources/init.py", line 2445, in load
return self.resolve()
File "/usr/lib/python3/dist-packages/pkg_resources/init.py", line 2451, in resolve
module = import(self.module_name, fromlist=['name'], level=0)
File "/home/loungelab/doosan_ws/build/dsr_example2_py/dsr_example2_py/dsr_service_motion_simple.py", line 25, in
from DSR_ROBOT2 import *
File "/home/loungelab/doosan_ws/src/doosan-robot2/common2/imp/DSR_ROBOT2.py", line 52, in
_ros2_set_robot_mode             = g_node.create_client(SetRobotMode,           _srv_name_prefix +"system/set_robot_mode")
AttributeError: 'str' object has no attribute 'create_client'

Didn't you go through a separate modification?


@alloy => Upgrade artsy-eigen-web-association and others

To pull in the latest from https://github.com/artsy/artsy-eigen-web-association/pull/7

Why does this upgrade dependencies besides artsy-eigen-web-association?

Hmmm yea maybe a little aggressive.


Update Compose compiler to 1.3.0

Codecov Report

Merging #508 (41baac1) into main (d67b606) will increase coverage by 0.53%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #508      +/-   ##
==========================================
+ Coverage   74.62%   75.15%   +0.53%
==========================================
  Files          83       83
  Lines        4504     4504
  Branches      984      960      -24
==========================================
+ Hits         3361     3385      +24
  Misses        452      452
+ Partials      691      667      -24

Impacted Files
Coverage Δ

...xvanyo/composelife/ui/info/CellUniverseInfoCard.kt
69.45% <0.00%> (+0.49%)
:arrow_up:

...n/com/alexvanyo/composelife/ui/cells/CellWindow.kt
81.06% <0.00%> (+0.59%)
:arrow_up:

...lexvanyo/composelife/ui/action/ActionControlRow.kt
57.27% <0.00%> (+0.90%)
:arrow_up:

...oselife/ui/action/settings/InlineSettingsScreen.kt
67.00% <0.00%> (+1.00%)
:arrow_up:

...omposelife/ui/action/settings/CellShapeConfigUi.kt
67.85% <0.00%> (+1.19%)
:arrow_up:

...selife/ui/component/GameOfLifeProgressIndicator.kt
67.85% <0.00%> (+1.19%)
:arrow_up:

...ife/ui/action/settings/FullscreenSettingsScreen.kt
75.29% <0.00%> (+1.19%)
:arrow_up:

...o/composelife/ui/InteractiveCellUniverseOverlay.kt
84.27% <0.00%> (+1.25%)
:arrow_up:

...exvanyo/composelife/ui/action/InlineSpeedScreen.kt
64.47% <0.00%> (+1.31%)
:arrow_up:

...ife/ui/action/settings/QuickAccessSettingHeader.kt
59.21% <0.00%> (+1.31%)
:arrow_up:

... and 8 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


fix(modal): removed Closer component

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.001%) to 80.273%

Totals

Change from base Build<PHONE_NUMBER>:
-0.001%

Covered Lines:
7893

Relevant Lines:
8920

💛  - Coveralls


extraction error

since version 7.0.1 we get multiple extraction errors - please see the screenshots

This appears to be an issue related to the Lenovo driver pack itself and not the DAT.


See
https://github.com/envoyproxy/envoy/pull/21370#issuecomment-1210127481
Signed-off-by: John Howard<EMAIL_ADDRESS>
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

LGTM, but looks like a genuine issue with the docs build.

/retest
failure is downloading bazel, I don't think its related?

I am a bit unsure how to do this. If I remove it from metadata.yaml it fails with 'Did you forget to add 'envoy.tracers.lightstep''. If I add it there it fails with 'CodeChecker ERROR [extensions_registered] Metadata for unused extension found: envoy.tracers.lightstep'. Do I need to somehow use it in a NOP sort of way?

@phlax can you advise here? We basically had an API + extension + metadata. Then we removed all 3, which was a bit aggressive, so we want to restore the API + metadata only.

can you advise here? We basically had an API + extension + metadata. Then we removed all 3, which was a bit aggressive, so we want to restore the API + metadata only.

iiuc this is a novel situation that we didnt plan for when checking for the correct extension setup to generate docs (i think this would have always failed - even before metadata was separated out)
probably we can just add an ignore list for the code.checker - assuming that the rest of the code is happy with this setup

thinking about this further - i guess my one concern is that other machinery will read this - eg validation and perhaps the envoy binary would accept the config as valid but not work


turn connection seems to 'freeze' after 5 min

TURN permissions expire after 5 minutes, and are currently not refreshed.

A turn permission expires after 5 minutes if it is not refreshed. 1tp turn connections now occasionally refresh these permissions to avoid freezing after 5 min.


Intermediate files grow quite large

Example: 185 samples
Each sample ~700mb of result data
Intermediate files for all 185 samples 662GB!
Need to clean this up by default

Added a few tweaks with https://github.com/bactopia/bactopia-ap/commit/635c10d27ca651eca86b87f124c89a5a8e47f4df
Biggest change is intermediate FASTQs are deleted now. During the QC step, up to 4 copies (with subsequent filtering) was created and maintained. After successful completion they are removed by default.


backfeed comments/likes from youtube

I have a group of video that I uploaded to youtube years ago, I would like to backfeed the comments/likes from youtube to my website

discussion about this on chat today! @aaronpk would like it.
instructions on how to add a new silo. API links: video comments, community/channel comments


Hide Navigation/Header Bar ?

Hi there!
Great work on this starter app!
I was wondering if there's any way I can hide the navigation bar ?
For example, using this, when navigation to  the forms screen, is there a way to hide the NavigationBar  ?
Thanks!

Hi @EugeneLiang
Sorry, not that I'm aware. Although you could ask the question over at the react-native-navbar page.
Thanks for the feedback!


Completion is not provided in the generic portion of @inherits

Gonna move this to the compiler area path, as it looks to me like an error recovery issue.
Having this in Razor:

Ends up with this in the generated file:

Not surprising Roslyn is not providing completions about generic parameters there :)
Feel free to move it back my guess is wrong.

Turns out this is even more broken in fuse :)

There is a skipped integration test referencing this issue. Please unskip when fixing :)


Update the gce_run.sh to install needed Linux headers

@electrocucaracha PTAL

So, in general this worked for me, but the repos that access gitea do not become ready, because gitea is not a valid host. We need to insert a service in the default namespace for that - or actually, maybe in the porch-server namespace.
But...I figure that's all going to change when we shift off the "one-summit" deployment, right? So, I didn't worry about it yet.

So, in general this worked for me, but the repos that access gitea do not become ready, because gitea is not a valid host. We need to insert a service in the default namespace for that - or actually, maybe in the porch-server namespace.
But...I figure that's all going to change when we shift off the "one-summit" deployment, right? So, I didn't worry about it yet.

Actually, the current version used to install gitea package is v1. I haven't had a chance to test v2 and use metal LB services.
/lgtm

/approve


Error: Invalid Relationship

After upgrading my PE master to v2016.5.1 I'm consistently seeing the following error on puppet runs using ca_cert v1.6.1:
Could not retrieve catalog from remote server: Error 500 on SERVER: {"message":"Server Error: Invalid relationship: File[Wisconsin-State-Legislature-Issuing-CA.crt] { require => Package[ca-certificates] }, because Package[ca-certificates] doesn't seem to be in the catalog","issue_kind":"RUNTIME_ERROR"}
The package in question 'ca-certificates' is already installed on the node (Ubuntu 14.04). Please let me know if there's any additional info you'd like.

That sounds kind of like the ca_cert module isn't being included. Can you double check that you're including it (the ca_cert::ca type won't automatically set it up)?

So this is the extent of the code in the manifest:
    ca_cert::ca { 'Wisconsin-State-Legislature-Issuing-CA':
      ensure => 'trusted',
      source => 'puppet:///modules/profile/certs/wsl-sha1-eica.crt',
    }

Are you saying that I would need to: include ca_cert ?

Yep - if you add include ::ca_cert then all of the required packages will be added.

Yep, that looks like it. I'd being lying if I said I fully understand that but that's my problem :). Thanks so much for the help.

Awesome - I'm glad that worked.
The defined type ca_cert::ca only sets up the CA files and triggers a refresh of everything. The ca_cert module sets up the package and actual refresh task that the defines call. It works a lot like the puppetlabs/apt module if that helps at all.

Thanks for the details. It does help.


Call Screening Not Working

Hello,
Thanks for the wonderful module.
Just wanted to report :
a) Call screening was working in v2.1, but suddenly stopped working ( I can see the option in google setting, but when I receive a call, the 'Screen' button is missing and no matter what I do (Uninstall Reinstall Phone Apps and this Module), doesn't seem to help.
[Update]: Installed v2.2-beta-2 but still Call Screening does not seem to work.
[Update 2] : Call Screening Works (Manual Only, no automatic screening) if Google Phone App is Downloaded to v92
b) Google Setting seems to have disappeared.
c) Call Recording stops working if I install v2.1, but if I uninstall and install v2.02, the call recording works fine.
[Update] : Call Recording Works fine on v2.2-beta-2
Device : Xiaomi 12
ROM : MiUi 13.0.36 (Stable)
Google Phone Version : 95.0.491468435

It also stopped working for me after pixel 7 pro December update.


Notice triggered when $options['host'] is not set

On src/Phinx/Db/Adapter/MysqlAdapter.php:87, if no host is set in the config, the index "host" would not exist, therefor it will trigger a Notice:
PHP Notice:  Undefined index: host in .../vendor/robmorgan/phinx/src/Phinx/Db/Adapter/MysqlAdapter.php on line 87
However, I guess the PDO class falls back to "localhost" because the connection actually succeeds. I would fix it myself, but I don't know if you'd prefer to trigger an Exception or rather fallback to a "localhost" default (the same as PDO?).

Are you able to provide a pull request with your suggested changes?
As this triggers currently a notice but then does sth correct, it seems an exception might be a bit too BC breaking (and can be considered for a major jump).
Localhost fallback as a shortterm solution sounds like a good idea.

Hi @dereuromark - Im no longer using it so I guess if nobody else have complained, it may not be worth looking into (?)

Closing then for now.


Upload file without progress callback.

Win10 64bit
I cannot get the progress callback while the file uploading, after uploaded I got list of progress.

Try this and see if it works?

New: Progress reporting for synchronous methods Upload, Download, UploadFile and DownloadFile are now sent via delegates
Fix: Correctly send progress for synchronous methods and retain IProgress for async methods

Release.zip

Hello @gbanana  can you try that release and tell me if it works? Until you test I cannot push this release

Pushed
https://www.nuget.org/packages/FluentFTP/28.0.0


does not work if merged with bootstrap

Hello Andy,

I pulled your repo and installed it on my tiny web site index page : https://goo.gl/9fEs3e
It doesn't give any error but doesnt work either.
you can see my index.htm that has your library included for the above live link.

Did you ever get this working?


Assert check

Fixes #54.
cc @sdroege @EPashkin

cc @jsparber

:+1: or just move those few lines into lib.rs

No, I like having a rt file around. :)

@GuillaumeGomez Thanks, 👍 too


rpc sandbox supporting treasury factory

The file sandboxrpc/playground/treasuryfactory.js shows how to use the treasury factory with the sandbox. You can run this file with nodejs and test various ways of interaction.
Also there is a Playwright test that shows how to use it in Playwright and make the needed assertions that a treasury instance was successfully created.
resolves #193

@race-of-sloths include

@petersalomonsen Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Great job! Usain Bolt jealous of your results!

Current status: waiting for scoring
We're waiting for maintainer to score this pull request with @race-of-sloths score [0,1,2,3,5,8,13] command. Alternatively, autoscoring [1,2] will be applied for this pull request
What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow
For contributors:

Tag @race-of-sloths inside your pull requests
Wait for the maintainer to review and score your pull request
Check out your position in the Leaderboard
Keep weekly and monthly streaks to reach higher positions
Boast your contributions with a dynamic picture of your Profile

For maintainers:

Score pull requests that participate in the Race of Sloths and receive a reward
Engage contributors with fair scoring and fast responses so they keep their streaks
Promote the Race to the point where the Race starts promoting you
Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands

For contributors

Include a PR: @race-of-sloths include to enter the Race with your PR

For maintainers:

Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@race-of-sloths score 8


LDAP Validation Issue

The LDAP schema validation for email seems to be incorrect.
So if I attempt to do something like:
  ldap = {
    url        = var.ldap_url
    attributes = {
      email                  = ["mail"]
      id                     = var.attribute_id
      name                   = var.attribute_name
      preferred_username     = var.attribute_preferred_username
    }

It will fail with "Invalid Email"
The backing code looks like this:
var ldapAttrSchema = map[string]schema.Attribute{
	"email": schema.ListAttribute{
		Description: "The list of attributes whose values should be used as the email address.",
		ElementType: types.StringType,
		Optional:    true,
		Validators: []validator.List{
			listvalidator.ValueStringsAre(
				stringvalidator.RegexMatches(common.EmailRegexp, "Invalid email"),
			),
		},
	},

The EmailRegexp basically says the value needs to look like an email (i.e. example@gmail.com).
But that is generally not going to be the case because this is validating the LDAP Key, not the value of the email itself.
Should be a pretty simple fix I will try to create a quick PR

Hi @jland-redhat ,
Thank you for the contribution
I'm not so familiar with the ldap identity provider, but do you say that email attribute not contains actual email address?
@sagidayan can you please review this and the PR?

Yes I actually already created a PR with what I believe is the fix, hopefully explains it a little more

Thanks for opening the issue, and much more for opening the PR. Let's move the discussion there.

@jland-redhat thank you for contributing this
I'm closing the issue
Feel free to re-open in case you think need further actions


[DFP-34X-2C2] Access from outside of subnet

Hello. i have DFP-34X-2C2 connected to OPNSense.
DFP-34X-2C2 has IP <IP_ADDRESS> (mask <IP_ADDRESS>), and OPNSense has IP <IP_ADDRESS> on same intefrace.
Problem is that i have more subnets connected to OPNSense. (192.168.0.X; 192.168.1.X...)
I set rules to allow traffic between some subnets. Problem is that im not able to access DFP-34X-2C2 from different subnet.
Like accessing from <IP_ADDRESS> while DFP-34X-2C2 has IP <IP_ADDRESS> (mask <IP_ADDRESS>).
Is there some way to allow access from any IP and subnet on lan (sfp) side?
Maybe trought some commands, or editing files in filesystem. But im not sure if its R/W, and if changes presist reboot.
Thanx.

This mean: Route
The DFP-34X-2C2 don't have Route List to your subnet,
you need add Route List inside DFP-34X-2C2
another way is using NAT Masquerade just like WAN

This mean: Route
The DFP-34X-2C2 don't have Route List to your subnet,
you need add Route List inside DFP-34X-2C2
another way is using NAT Masquerade just like WAN

My subnet count is pretty flexible.
Is there way to add whole private (local) part of network to DFP-34X-2C2?

I think doing NAT Masquerade is much simpler and safe
This what I do in my Mikrotik, allow any address able to access my xPON ONU Stick
First, I give sfp-sfpplus1 an IP Address, such as <IP_ADDRESS>/24

Then, I add new masquerade firewall rules at second (after WAN masquerade)

Firewall rules should look like this:

WAN Masquerade
SFP Masquerade
...

I tried this method on Ubiquiti EdgeRouter 12, also works just fine

Solved by
route add -net <IP_ADDRESS>/0 gw <IP_ADDRESS> br0
but it didnt presist reboot. Any suggestions?

to make it persistence, you need modify the firmware and add into rc folder, this is why I choose NAT method.

to make it persistence, you need modify the firmware and add into rc folder, this is why I choose NAT method.

Thanx. Will try this.

@Anime4000 , Could I access from outside of subnet if I use a Media Converter? the IP of my ODI DFP-34X-2C2 connected to Realtek 2.5Gb Media Converter is <IP_ADDRESS> while my router is on <IP_ADDRESS> but I cannot access to <IP_ADDRESS> from router neither devices connected to the router

@Anime4000 , Could I access from outside of subnet if I use a Media Converter? the IP of my ODI DFP-34X-2C2 connected to Realtek 2.5Gb Media Converter is <IP_ADDRESS> while my router is on <IP_ADDRESS> but I cannot access to <IP_ADDRESS> from router neither devices connected to the router

Whats your netmask? Because <IP_ADDRESS> and <IP_ADDRESS> looks like in same subnet if subnet uses /24 cidr (<IP_ADDRESS> netmask) which is default on most routers.

@Anime4000 , Could I access from outside of subnet if I use a Media Converter? the IP of my ODI DFP-34X-2C2 connected to Realtek 2.5Gb Media Converter is <IP_ADDRESS> while my router is on <IP_ADDRESS> but I cannot access to <IP_ADDRESS> from router neither devices connected to the router

Whats your netmask? Because <IP_ADDRESS> and <IP_ADDRESS> looks like in same subnet if subnet uses /24 cidr (<IP_ADDRESS> netmask) which is default on most routers.

My Mikrotik LAN subnet is <IP_ADDRESS>/24, and I use NAT to access the stick WebGUI

@Anime4000 , Could I access from outside of subnet if I use a Media Converter? the IP of my ODI DFP-34X-2C2 connected to Realtek 2.5Gb Media Converter is <IP_ADDRESS> while my router is on <IP_ADDRESS> but I cannot access to <IP_ADDRESS> from router neither devices connected to the router

Whats your netmask? Because <IP_ADDRESS> and <IP_ADDRESS> looks like in same subnet if subnet uses /24 cidr (<IP_ADDRESS> netmask) which is default on most routers.

I have /24 as netmask on router and on SFP ODI in Media Converter but I cannot access to Telnet neither SSH and I cannot make ping from any device connected to router to <IP_ADDRESS> (SFP device)

@Anime4000 , Could I access from outside of subnet if I use a Media Converter? the IP of my ODI DFP-34X-2C2 connected to Realtek 2.5Gb Media Converter is <IP_ADDRESS> while my router is on <IP_ADDRESS> but I cannot access to <IP_ADDRESS> from router neither devices connected to the router

Whats your netmask? Because <IP_ADDRESS> and <IP_ADDRESS> looks like in same subnet if subnet uses /24 cidr (<IP_ADDRESS> netmask) which is default on most routers.

I have /24 as netmask on router and on SFP ODI in Media Converter but I cannot access to Telnet neither SSH and I cannot make ping from any device connected to router to <IP_ADDRESS> (SFP device).
The only way for to connect to SFP is connect Ethernet Cable from Media Converter to the device to connect (then all the devices wont have internet because it is the FTTH provider...)

Looks like some kind of fault...
Can be hardware issue, firmware issue or configuration issue. Hopefully its configuration issue.
Can you access reset button/pins on your device?

@Anime4000 , Could I access from outside of subnet if I use a Media Converter? the IP of my ODI DFP-34X-2C2 connected to Realtek 2.5Gb Media Converter is <IP_ADDRESS> while my router is on <IP_ADDRESS> but I cannot access to <IP_ADDRESS> from router neither devices connected to the router

Whats your netmask? Because <IP_ADDRESS> and <IP_ADDRESS> looks like in same subnet if subnet uses /24 cidr (<IP_ADDRESS> netmask) which is default on most routers.

I have /24 as netmask on router and on SFP ODI in Media Converter but I cannot access to Telnet neither SSH and I cannot make ping from any device connected to router to <IP_ADDRESS> (SFP device).
The only way for to connect to SFP is connect Ethernet Cable from Media Converter to the device to connect (then all the devices wont have internet because it is the FTTH provider...)

So, you can access your your SFP stick from pc, when pc is directly connected to ethernet port of media converter. But not trought router. Right?
But none of your devices can see it trought router, ans router itself also desnt see it?
If so, then maybe there is special port on router for guest network or WAN. They have configured separate subnets. WAN port is mostly DHCP client, or static IP, but you are most likely looking for VLAN  assigned by your provider and pppoe on top of it to get internet working.

Most router cannot allow set WAN IP Address besides the Internet/PPPoE
like in Mikrotik, I add sfp-sfpplus1 another IP Address (<IP_ADDRESS>/24)
then NAT it from <IP_ADDRESS>/24 to <IP_ADDRESS>
that how I did, I can access WebGUI or Telnet from <IP_ADDRESS> PC to <IP_ADDRESS> PON Stick
for non Mikrotik, I don't know, Ubiquiti can, but consumers Router are cannot!

Looks like some kind of fault... Can be hardware issue, firmware issue or configuration issue. Hopefully its configuration issue. Can you access reset button/pins on your device?

I'm sure that it is a configuration issue because it happened with my old stock ONU (Ufiber NanoG).

So, you can access your your SFP stick from pc, when pc is directly connected to ethernet port of media converter. But not trought router. Right?

That it's.

But none of your devices can see it trought router, ans router itself also desnt see it?

Router can to see the device.

If so, then maybe there is special port on router for guest network or WAN. They have configured separate subnets. WAN port is mostly DHCP client, or static IP, but you are most likely looking for VLAN assigned by your provider and pppoe on top of it to get internet working.

Most router cannot allow set WAN IP Address besides the Internet/PPPoE
for non Mikrotik, I don't know, Ubiquiti can, but consumers Router are cannot!

That would be. Maybe there are any way to allow set WAN IP address for to access to SFP of Media Converter in my OpenWRT router from any device of my LAN.


JavaScript suggestions are currently too intrusive

VSCode Version: 1.12.1
OS Version: Windows 10

Steps to Reproduce:

Type anything - the suggestions that come up may be filtered poorly, and block out desired snippets added by extensions

Related to this Stack Overflow question:  http://stackoverflow.com/questions/43850267/configure-visual-studio-code-suggestions/
It would be ideal to be able to see all sources for these suggestions, and be able to turn them off.  Or any other workarounds would be much appreciated too!  I selected the highlighted option in the image and tried to "go to definition" but none was found, so it appears to be really tricky tracking down the .d.ts file where these are coming from.

VSCode Version: 1.12.1
OS Version: macOS 10.12.3
I am experiencing this as well. As you can see, I have a perfect match with a snippet typed in the screenshot below but it's still not selected.

One option we have in the interim is to add this setting to your settings:
"editor.snippetSuggestions": "top"
That will place snippet suggestions higher in the sort order.

Whoa - that's 99% of what I need.  Thanks a ton @seanmcbreen

@mhegazy We've seen a few requests similar to this about reducing the number of completions in JavaScript contexts. I prototyped a simple filter, but there are a few complications:

The interface and type completion items are usually not helpful in regular JavaScript code, but they may be needed in JSDoc comments.
Completion items for some types such as Promise are of kind interface but also have an instance. We cannot differentiate completions for pure interface types from those like Promise.

We should be able to workaround the first issue on the VSCode side but the second would require a TS change. There may be other problems that I haven't considered here. Any thoughts on this?

Filtering should be done on the TS side of things. We should be able to filter compleations based on what the location allow.

@mjbvz can you please port this to the TS repo?

Opened https://github.com/Microsoft/TypeScript/issues/15750 to track reducing the number of type suggestions in js files
Closing as upstream

Fair enough - are you sure this couldn't be solved more easily in VS Code though?  Ie, just expose all the sources of these suggestions and let users blacklist as many or as few as desired?


Insert into Terminal requires 2 clicks if terminal is closed

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
Version: 1.87.0-insider (user setup)
Commit: 01ce8d869e4220577e194b2dd57bfa12437dfcf5
Date: 2024-02-20T01:53:30.190Z
Electron: 27.3.2
ElectronBuildId: 26836302
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.25987
OS Version: Windows 11 Insiders

Testing https://github.com/microsoft/vscode-python-debugger/issues/221
Steps to Reproduce:

Used sparkle to resolve an import issue with Copilot
Select Insert into Terminal, without my terminal already open

My terminal opens, but nothing is inserted
I need to select Insert into Terminal again

I would've expected Insert into Terminal to open the terminal and paste in the command, rather than requiring 2 interactions.

Doesn't happen on macOS for me, likely something happening on Windows.


http CONNECT proxies implemented

from txsocksx.http import HTTPConnectAgent
squidEndpoint = TCP4ClientEndpoint(reactor, '<IP_ADDRESS>', 3128)
agent = HTTPConnectAgent(reactor, proxyEndpoint=squidEndpoint
.... etc ...

Coverage decreased (-1.9%) to 94.561% when pulling b9ee0497207e337e8a015872769c3cdfc02fecda on mgrechukh:connect into 110f71d11704e6f9811701fd28424f400f8510b2 on habnabit:master.


User Password not encrypted in Database

Password needs to be encrypted before saving in database

Updated code to make password encrypted when stored in database.


Tuple Protocol

Evaluate whether tuple protocol can be added to RareCpp without major compromises to ergonomics or compile-time.

Sadly true tuple protocol requires specializations be placed in std or the global namespace, and this is something that the in-class REFLECT macro simply cannot do (even with the extremely jank measure of closing the class in the macro, that leaves you in an undefined namespace or the next outer of the nested types) - so there is no ideal solution to enabling tuple protocol. However there are a few less-than-ideal options....
1.) Implement an ADL get method using the REFLECT/REFLECT_NOTED macro, then document that the users must specialize tuple_size and tuple_element for their type in the global namespace, or use a macro such as RARE_ENABLE_TUPLE(types...) including the types they want tuple protocol for; as near as I can tell this does not strictly make a type tuple-like (as implementing std::get does), but it does enable structured bindings.
2.) Do not implement an ADL get method using the REFLECT/REFLECT_NOTED macro, but add a macro such as RARE_ENABLE_TUPLE(types...) that the user must place in the global namespace - this has less chance of a potential name-collision with existing get() methods in reflected structs/classes, at the cost of potentially being impossible to use within the bodies of said structs/classes.
3.) Add a wrapper type with tuple protocol - construct with a reference to the target object, and it has tuple-protocol all built-in.
Of those options (3) can be done regardless of whether (1) or (2) are done, but I think (1) and (2) should be either-or... further there's a major weakness in such a macro - namely templated types. When a type is templated the specializations for tuple_size and tuple_element look different (non-templateds lack the T<Ts...>'s) and I don't see a good way to get macros working with templates like that; if the macro required a complete type with multiple template parameters then macro parameters would involve a comma requiring macro uglification or un-ergonomic aliasing on the part of the user, on top of the many inconveniences of having to specify complete types in the first place instead of just the template.
So I think (3) is really the only generalizable solution from the above, unfortunate as having a wrapper type is, it's much preferable to a solution that can't be reasonably implemented/used with so common a use-case as templated classes.
Though I believe a (4) is also warranted here: that is simply document how a user can enable tuple protocol on a type using reflection themselves - no new macros/macro changes in the library, just a how-to & examples.

Finished in #109 , #111
Examples (of 3 and 4 respectively):
Tuplifying using wrapper type
Directly tuplifying reflected types
Docs:
member_type_tuple trait
tuplify(t) function

Released in 2.1.0


Unable to compile with Xamarin

I'm having an impossible time trying to compile this on my Mac with Xamarin. The instructions say just use xbuild parse.sln but both that and the IDE are giving me the errors:
Parse-SDK-dotNET/ParseCommon/Properties/AssemblyInfo.cs(7,7): Error CS0246: The type or namespace name `Parse' could not be found. Are you missing an assembly reference? (CS0246) (ParseCommon.Portable)
and similarly
Parse-SDK-dotNET/ParseCommon/Properties/AssemblyInfo.cs(7,7): Error CS0246: The type or namespace name `Parse' could not be found. Are you missing an assembly reference? (CS0246) (ParseCommon.Unity)
Seems like there is an error with the way the current version is setup in the repository but I'm not sure what to do about it.

As discussed previously, there's an issue with now xbuild handles search paths compared to MSBuild.
We don't currently support compiling the SDK in any environment other than Visual Studio, sorry (though the community edition plus a VM should work fine).
https://github.com/ParsePlatform/Parse-SDK-dotNET/issues/166#issuecomment-182609656


Fix versions

If this is true, where can I see which versions are for which extension?

Imagick does not have a releases which compiles on PHP 8. Y
You can check the formula directory for the available extensions for different PHP versions. All formulae in Formula directory have the format extension@php_version.

Ok, thanks 👍


Assignment One

Originally assigned on 2020-11-08
Hey Sam,
Here’s the first validator assignment:
Create a protocol called Validator that has a single function spelled validate(_:). That function takes a value of a particular type and returns a Bool indicating whether the value is valid or not.
For example, you might have an object CharacterCountValidator that validates that the number of characters in a string is in a given range:
struct CharacterCountValidator : Validator {
    let range: ClosedRange<Int>

    func validate(_ value: String) -> Bool {
        return range.contains(value.count)
    }
}

We might have another that returns whether an integer is even:
struct IsEvenValidator : Validator {
    func validate(_ value: Int) -> Bool {
        return value.isMultiple(of: 2)
    }
}

Exercises

Create the Validator protocol.
Implement the following validators:

CharacterCountValidator: This is free… see above.
CharacterSetValidator: This validates that none of the characters in a string are in a set of disallowed characters.
ContainsSubstringValidator: This validates that a string contains a given substring. The initializer should take the substring, as well as String.CompareOptions and an optional Locale to control how to search for the substring. Hint: use String.range(of:options:locale:) to perform the substring search.

InSetValidator: This validator ensures that a value is in a particular set of valid values.
Extra Credit

Convert CharacterCountValidator’s range to be any type of RangeExpression whose Bound is Int.
Create InRangeValidator, which validates that a value is contained within a given RangeExpression.

Once you’re done with this, let me know and I’ll send you assignment 2.
-Prachi

Finished the assignments


Fix Unecessary Failure

The download stats function in circuitpython_libraries.py was assigning the published date for releases to a variable. A few days ago, the Travis cron job started failing on the assignment, because the pub date was returning None.
I tried to verify this by running the API call for releases in a web browser, which didn't provide any insight.
I then inserted some debug prints in the script, and realized that the API response was including the draft release for 4.0.0-alpha.4. The draft release wasn't returned in the web browser; weird.
At any rate, the variable with the published date isn't used anywhere, so the simplest fix: don't assign it. 😄

Thanks!


feature gate deprecated APIs for GILPool

Some pieces of this don't feel super idiomatic -- GILGuard::acquire() returns None if the GIL is already acquired, so I didn't have an easy solution like adding a python() method to it.

Some pieces of this don't feel super idiomatic -- GILGuard::acquire() returns None if the GIL is already acquired, so I didn't have an easy solution like adding a python() method to it.

Yeah, that one is one me. My only defence is that this is the result of actually collapsing another layer of indirection, i.e. #3166.
But also have a look at #3685 where I introduced WithGIL as an RAII to use without GILPool, i.e. a type that we would keep in 0.23 when the GILPool is actually fully dropped.

I think there's a design question here, which is whether we want a new type, or we should just have GILGuard::acquire always return an instance?

I think there's a design question here, which is whether we want a new type, or we should just have GILGuard::acquire always return an instance?

The separate type seemed like the easier evolution but that approach has landed us in this mess in the first place.
If GILGuard should always return an instance, then I think it should itself become an Option-like enum with a variant containing PyGILState_STATE and a GILPool (or not depending on the feature, but possibly) and a None-like variant when there is nothing to be done.

IIRC, the main point was that GILGuard does not really help for the entry points when we know that GIL is already held and just want to set the correct lifetimes and update our own GIL count tracking. For this, the bare WithGIL type was rather helpful.

I think a WithGIL new type seems preferable to me; making the GILGuard be purely RAII seems like a better separation of concerns even if it works out a bit more verbose.

Actually given both types will also be RAII on the internal GIL_COUNT, on reflection I like the enum-like GILGuard too. I'd suggest Held and Assumed for the two variant names, given we use the term assume elsewhere too.

I'd suggest Held and Assumed for the two variant names, given we use the term assume elsewhere too.

I would suggest calling the Held variant Ensure as it is the one which involves a call to PyGILState_Ensure.
One potential downside I would mention (but I have not measured it), is that this will mean that we could end up allocating unused stack space for Python's thread state in every entry point. Probably depends on whether the compiler will SROA-explode the type or not...

I'll maybe get back to this today, or maybe not for a few days. If anyone else is champing at the bit to do that refactor, don't feel compelled to wait for me. Or I'll get to it later this week :-)

One potential downside I would mention (but I have not measured it), is that this will mean that we could end up allocating unused stack space for Python's thread state in every entry point. Probably depends on whether the compiler will SROA-explode the type or not...

Ah, true. I think the state returned by PyGILState_Ensure is just an integer, but still a downside.

Actually given both types will also be RAII on the internal GIL_COUNT, on reflection I like the enum-like GILGuard too. I'd suggest Held and Assumed for the two variant names, given we use the term assume elsewhere too.

Thinking further, I realise this is a non-argument as GilGuard can just contain a WithGIL, and WithGIL can then always be the RAII on GIL_COUNT. So I guess the answer is let's go with whatever feels cleaner in code.

This is rebased and should be ready for review now.


CLI errs when running generate without network connection

Potentially related to https://github.com/zenstackhq/zenstack/issues/1464
Ideally, there should also be some sort of timeout (e.g. 1 second), so that if you're on a slow network connection, running generate doesn't take a long time (I've encountered this issue before when running zenstack generate while on a train with a spotty internet connection).
I wonder if it's worth just creating a custom version checker function, e.g. something like: https://github.com/promptfoo/promptfoo/blob/fb6cbce74b0d627c7a6811923cb4f4d983e5ff73/src/updates.ts
Both get-latest-version and latest-version don't have timeouts.

Potentially related to #1464
Ideally, there should also be some sort of timeout (e.g. 1 second), so that if you're on a slow network connection, running generate doesn't take a long time (I've encountered this issue before when running zenstack generate while on a train with a spotty internet connection).
I wonder if it's worth just creating a custom version checker function, e.g. something like: https://github.com/promptfoo/promptfoo/blob/fb6cbce74b0d627c7a6811923cb4f4d983e5ff73/src/updates.ts
Both get-latest-version ~and latest-version~ don't have timeouts. Edit: latest-version seems to have a 10s timeout by default, but it's not possible to change.

Yes, it's a bit unfortunate the packages don't support timeout ... I'm replacing it fetch with timeout. Thanks for providing the reference implementation!


ROS2 porting

Please note my comments on this ROS2 branch in README.md. It gives an overview of completeness, amongst other infos.

@grischi
Just want to make sure it's pushed into the correct branch, I see "
grischi wants to merge 1 commit into TixiaoShan:master from grischi:ros2" on the top of this page, is it pushed to the master branch?

I don't have permission to create a branch in your repo. I think you have to create such a branch, and then I can change the target branch for this PR.

@grischi
I have created a new branch called "ros2".


Add hyperlinks to French and English BikeMaps sites.

Adding hyperlinks to link English <-> French and to link to BikeMaps site.

Also adding support for Google Analytics as part of this PR.


fixed issue when using deprecated annotation in combination with re…

…duced

Codecov Report

Merging #63 (e6b6526) into main (d6265e3) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##               main      #63   +/-   ##
=========================================
  Coverage     71.14%   71.14%
- Complexity      407      409    +2
=========================================
  Files            61       61
  Lines          1639     1639
  Branches        248      248
=========================================
  Hits           1166     1166
  Misses          342      342
  Partials        131      131

Impacted Files
Coverage Δ

...a/com/kaufland/validation/model/ModelValidation.kt
50.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add callback to attacker

Background
Adds an optional callback function to the attacker that is called synchronously after each hit.
Checklist

[ ] Git commit messages conform to community standards.
[ ] Each Git commit represents meaningful milestones or atomic units of work.
[ ] Changed or added code is covered by appropriate tests.

If we can get this from the channel, then this is not needed. Can you share an example of this approach?

https://github.com/tsenart/vegeta

Thanks, closing.


Terminal cursor doesn't reflect that the terminal is focused

Does this issue occur when all extensions are disabled?: Yes
Description
Terminal has focus, but the cursor displayed doesn't look like it does -- it's not filled white
Actual
https://github.com/microsoft/vscode/assets/16353531/68fc39a0-9961-45d0-8e68-c99a6c5a6342
Expected
with stable 1.81.1:
https://github.com/microsoft/vscode/assets/16353531/6fe14c7a-141f-4b63-b587-89787fd5de0f
Steps to Reproduce:
I don't have any, but I can repro even with a new vscode window without any workspace folders.
Version
Version: 1.82.0-insider
Commit: f1302be1e67e3af5fbeb8bbb2ea784de7bc96150
Date: 2023-09-01T11:13:22.523Z
Electron: 25.8.0
ElectronBuildId: 23503258
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 22.6.0

Can't seem to repro with 1.81.1 stable.
Within my vscode integrated terminal
$  zsh --version
zsh 5.9 (x86_64-apple-darwin22.0)

it's weirdly x86_64 even though I'm on arm64, but it seems ok - https://www.reddit.com/r/mac/comments/oq3tex/default_shell_zsh_on_mac_m1_is_x86/

The warning sign on the zsh icon doesn't matter. I see this behavior even without that icon present.
Another caveat is that it doesn't always occur -- occurs in one terminal but not another:
Uploading Screen Recording 2023-09-04 at 23.56.46.mov…

Upstream https://github.com/xtermjs/xterm.js/issues/4748

Thanks heaps! Love that it's fixed


Can not recieve Firebase message in android but ios can ?

I am using

"react-native": "0.42.3"
"react-native-fcm": "^6.0.2"
device using: Android 4.4, Android 6.0
I can not recieve Firebase message in android when app running in foreground and background but iOS can ?
Any one can help me?

@jacktv1  I can not get in ios when app in background. can you please help me


[20.03] vimUtils.vimrcFile: Backport fix packpath order

Motivation for this change
This is the backport of #78385. The comments of that PR said it should be backported. Sadly that never happened.
This broke e.g. haskell-vim syntax-highlighting when people upgraded from 19.09 to 20.03.
See: https://github.com/neovimhaskell/haskell-vim/issues/111
My guess is that the problem was introduced into master around 8dccb59bacef6ae1abc2725955aa3296c6160d2a from january. I could be wrong about that, but it definitely worked on 19.09.
So this was broken only for a few weeks. Sadly exactly when the branch-off happened.
@Mic92 @megheaiulian @jonringer
cc: @emptyflask

@maralorn : backport commits should be made with "git cherry-pick -x ..."

Didn‘t know. Fixed.


how to create my draft replay?

how to create my draft replay?

Hey, we are currently lacking documentation on how to do this, will mark it as required enhancement.


Freetype2 benchmark

Benchmark for freetype. As documented, this is a benchmark which could (in theory) find an int overflow with -fsanitize=ubsan, but it's quite difficult.

This is mostly self-contained and straightforward; I'm going to merge in the interest of more useful changes


Updates to support Ubuntu 16.04

I was always under the impression nginx was going to be a problem with 16.04 - is the version with the precompiled upload module being installed?

As far as I can see, that should not be a problem because of this: https://github.com/galaxyproject/ansible-galaxy-os/blob/master/tasks/ubuntu/packages.yml#L15


STAR parameters for multimappers

In order to use STAR output for Telescope we need to increase the number of valid alignments output for each read using –outFilterMultimapNmax and –outAnchorMultimapNmax. Try setting both to 200 and/or allow this to be configurable

I don't actually think they are using outAnchorMultimapNmax at least in STAR 2.7.9


Add check that windowsizes[3] should be multitude of windowsizes[2]

By default windowsizes = c(5, 900, 3600), but when sets to c(5, 900, 1200) it does not make sense as the 20 minute window will overlap with 1.333 15 minute window, by which the labelling will be ambiguous. Therefore, I think we need to add to check_params.R:
if (ws2/ws != round(ws2/ws)) {
  ws = ws2 * ceiling(ws/ws2)
  warning(paste0("The third value of parameter windowsizes needs to be a multitude of the second value.\n",
                    "The third value has been automatically adjusted to ",
                     ws, " seconds in order to meet this criteria.\n" call. = FALSE)
}

as a last step to the check of the windowsizes values.
This has only become relevant with setting nonwear_approach = "2023" where windows are expected to allign, which is why I did not account for it previously.
The relevant parts of the code are brought together in check_params in PR #1027 in https://github.com/wadpac/GGIR/blob/part1-simplification-v2/R/check_params.R.  So, it is probably easier to do the above when that PR is merged or to add it as an extra commit to that branch.

@vincentvanhees I added the suggested check as a commit in PR #1027

Completed in #1027

Completed in https://github.com/wadpac/GGIR/pull/1027


LineString, Circle, Rectangle, Polygon do not appear on iOS

Describe the bug
The map features other than Marker appear to be broken on iOS at the moment. These components used to work so we need to identify where the regression occurred.
Affects

[ ] Designer
[ ] Blocks editor
[x] Companion
[ ] Compiled apps
[ ] Buildserver
[ ] Debugging
[ ] Other... (please describe)

Expected behavior
The map features should appear on the map.
Steps to reproduce
Create an app using the above components on a map and connect the iOS companion. Note that none of the features are drawn on the map.

are you working on it?

Fixed by #3026


remove the broken links which go to codeplex

@zivkan @JonDouglas Closed the Insecure Link fix PR in favor of this PR, which removes the broken links that go to the decommissioned codeplex site, but retains the link text.

@zivkan @JonDouglas  - can you please review and approve this PR? Thank you!

Can I get some context as to why these links are being removed? Can we just update them from http to https to appease the tooling so we can hold onto the link for historical reasons? i.e. internet archive searching?

@JonDouglas The main issue is that if we just switch to https we still have broken links that give customers 404s (aside from tooling suggestions). An alternative might be to put the entire link into code style instead of a markdown link. Would that be preferred to the solution in this PR?

Given that these changes are in the release notes only, the value is primarily historical.
I like changing the entire link into code style.

Let's just move them to code style links then. I find it a bit unnecessary to remove historical links in the first place, even if they 404. Release notes need to be left alone as much as possible.

As suggested, I will use the code style for the broken links instead of removing them. So I will close this PR.


To make it possible to create abstract trees with abstract labels for nodes

We do tree kernel learning for paragraph-level representations called parse thicket and we include a lot of information for parse tree labels. In particular, verbnet tags. Also, we augment regular trees with discourse trees. Would it be possible to do in KELP?

We can easily customize any structured representation in KeLP (i.e., Trees, Graphs or Sequences) including additional information on the node labels. This can be done by defining a new implementation of the class StructureElement (see Kelp guide pag 12). Then you need to implement a proper kernel to exploit such additional information, or alternatively you can implement a new StructureElementSimilarityI to be used with the SmoothPartialTreeKernel.

Thanks a lot Simone - will look into it.
Also please consider our github project where you can leverage many different applications which have been deployed in the industry:
https://github.com/bgalitsky/relevance-based-on-parse-trees
[https://avatars3.githubusercontent.com/u/1051120?v=3&s=400]https://github.com/bgalitsky/relevance-based-on-parse-trees
bgalitsky/relevance-based-on-parse-treeshttps://github.com/bgalitsky/relevance-based-on-parse-trees
github.com
Automatically exported from code.google.com/p/relevance-based-on-parse-trees
This is where I am going to add a dependance to your KELP project. It will  extend my TreeKernelInterface package.
Regards
Boris

From: Simone Filice<EMAIL_ADDRESS>Sent: Tuesday, December 13, 2016 12:41:39 AM
To: SAG-KeLP/kelp-full
Cc: Boris Galitsky; Author
Subject: Re: [SAG-KeLP/kelp-full] To make it possible to create abstract trees with abstract labels for nodes (#1)
We can easily customize any structured representation in KeLP (i.e., Trees, Graphs or Sequences) including additional information on the node labels. This can be done by defining a new implementation of the class StructureElement (see Kelp guidehttp://sag.art.uniroma2.it/kelp-docs/kelp-guide_2.0.2.pdf pag 12). Then you need to implement a proper kernel to exploit such additional information, or alternatively you can implement a new StructureElementSimilarityI to be used with the SmoothPartialTreeKernel.

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/SAG-KeLP/kelp-full/issues/1#issuecomment-266678962, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABAJ8J_5Ryz5OA0Mz8f1MnlW0ytnO0oNks5rHlpDgaJpZM4LLPKG.


defining proctime and watermark at the same time makes the creation of EOWC query fail

Describe the bug
Please check out https://github.com/risingwavelabs/kube-bench/pull/332
As suggested by @stdrc, it seems that we shouldn't derive watermark for proctime by default, but only when the user asks for it.
To Reproduce
No response
Expected behavior
No response
Additional context
Related: https://github.com/risingwavelabs/risingwave/issues/12261
Known issue, may need to revisit to see if this should be considered as a bug, also cc: @st1page

maybe just refer to #12261, close now


Pass profile resource into Bots

Use Case
User driven: https://discord.com/channels/905144809105260605/1142177596856082533/1142177596856082533
When using a bot using 3rd party APIs like Stripe, the developer would like make sure they have the Patient resource of the bot invoker, to make sure they bill the correct account.
Proposal
The Bot "Run As User" feature sets the access token of the MedplumClient that is passed in, but does not set the profile resource. The proposal is to set both the accessToken and profileResource in the MedplumClient before passing it into the handler function

Quick and dirty workaround:  In the bot, run this at the beginning
await medplum.setActiveLogin(medplum.getActiveLogin());

For us to fix this the "right way" has a few hops:

We need a way to setProfile in MedplumClient.
We need to publish a new version of @medplum/core
Then we can update the executeBot pathways to use setProfile

Because of the "bot lambda layer" pattern, we need a published version of @medplum/core first :(

Not burning, happy to wait for the new version, but appreciate the workaround


Cherry pick for release/0.15 - Unit test of PLUGIN-191

BigQuery Multisink fails on table names with special characters
PR: #538
Unit Tests: #564
JIRA: https://cdap.atlassian.net/browse/PLUGIN-191

/gcbrun


Provisions for 1-person admin-approved team

Should be accomplished by allowing admin to edit team members
perhaps a workaround is manual database editing?


Add Kotlin in subcategory of languages

Fixes Issue

Closes #1053
Changes proposed

Add Subcategory Kotlin in "Language" category
Add resource in Subcategory java of "Language"
Screenshots

Note to reviewers
Kindly review my changes and please merge the PR

I have resolved the issues. Let me know if there are more issues in my PR

Sorry, I clicked on the wrong button.

What change should i do? I am confused here, It shows merging is blocked.

can you please resolve the merge conflicts?

can you please resolve the merge conflicts?

I have resolved the merge request but it shows merging is blocked

thanks, lgtm

it shows merging is blocked did i do something wrong and i can't find the changes requested by @CBID2


Support react16

I'll took a look tomorrow. Thanks, William!

@wlach hi! When npm package will be updated?

@ysokolovsky just published version 1.0.2 now, seems to work ok!


Windows terminal and tmux don't work well

Distro: wsl2 + ubuntu22.04
Terminal: Windows Terminal
Vim version: 9.0
Tmux version:  3.2a
What I have done (those below are in .vimrc):
" in .vimrc

if (has("termguicolors"))
    let &t_8f = "\<Esc>[38;2;%lu;%lu;%lum"
    let &t_8b = "\<Esc>[48;2;%lu;%lu;%lum"
    set termguicolors
endif
let g:one_allow_italics = 1
colorscheme one
set background=dark

Add true color for tmux:
# in .tmux.config

# Add truecolor support
set-option -ga terminal-overrides ",xterm-256color:Tc"
# Default terminal is 256 colors
set -g default-terminal "screen-256color"

What is the problem?

The italic comments don't work in tmux:

And I find when I remove the let g:one_allow_italics = 1, the highlights of the comments disapear, so I think there must be something wrong with this configuration.

The background dose not full the terminal fully (This happens when outside tmux):

I've resolved the first problem.
I find that my $TERM is xterm-256color, so I set xterm-256color as my tmux's default terminal, the italics will work.

I fix the second one by removing the backgrounds


antisera, enterohelcosis

This pull request was generated by the 'mq' tool
[test]
flake rate: 0.1
logical conflict every: 100
sleep for: 300s
close stale after: 4 hours
[pullrequest]
requests per hour: 0
deps=[a,e]

/trunk merge


Add pry-rails to the Gemfile

What does this do and why do you want it?

Allows you to do binding.pry to stop code execution and inspect things in real time. Switches rails c from irb to pry.

Is this an alternative to debugger?  If so anything it does better?

There is pry-debugger, but it's an interactive ruby env that has more power. Can cd into objects, ls their methods, etc.

Since you just saw what I can do with debugger, are there any other features which pry-rails does that debugger doesn't have?  Or am I still misunderstanding what pry does in the context of 'stop code execution and inspect things in real time'.

It's the tools pry rails and pry byebug have that makes it powerful.
_ is a variable that gives you the last returned value
$ method_name gives you the code of that method.
cd Object changes into the object
ls lists methods available within the current context.
On Fri, Aug 25, 2017, 7:11 PM Shawn Carnegie<EMAIL_ADDRESS>wrote:

Since you just saw what I can do with debugger, are there any other
features which pry-rails does that debugger doesn't have? Or am I still
misunderstanding what pry does in the context of 'stop code execution and
inspect things in real time'.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/emerald-rubies/tenacious/issues/108#issuecomment-325061178,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGaPS5brBxmHoc68eSJJkq6N_RqtqcYnks5sb2KlgaJpZM4OxkTy
.

ok sounds cool to install and try out.

I like pry-rails and pry-byebug together.
Game for making this a real issue for a greenie to install?

yeah

Please add pry-rails and pry-byebug, thanks!


ftplugin/scss.vim wrongly pulls shiftwidth setting from ftplugin/sass.vim

Steps to reproduce

Put this anywhere in your vimrc:

set shiftwidth=4

Create and edit a test.scss file with the following content:

html {
    margin: 0;
}

With the cursor over margin: 0, press Shift+== to autoindent, the line will be indented to only 2 spaces.

Expected behaviour
Just like with css, the editor should keep indentation at 4 spaces.
Problem:
When editing scss files, vim ignores the global shiftwidth settings and overrides it to 2.
I've noticed that ftplugin/scss.vim just loads the full ftplugin/sass.vim, and in the latter uses the option sass_recommended_style to control whether or not to override the global setting.
I'd argue that scss is much closer to css than to sass, and forcing a specific shiftwidth for scss makes little sense. So perhaps defaulting sass_recommended_style to 0 for scss would be a simple fix.
That said, I couldn't find any official "recommended" style for sass, or any other reason to force shiftwidth to be 2 spaces. So honestly I think the following section should just go away:
if get(g:, 'sass_recommended_style', 1)
  setlocal shiftwidth=2 softtabstop=2 expandtab
  let b:undo_ftplugin .= ' sw< sts< et<'
endif

Version of Vim
9.1
Environment
OS: Linux (Arch)
Terminal: alacrity
Logs and stack traces
No response

This was added in https://github.com/vim/vim/commit/a907c91992167e41da41008d4370e434e324cbf2 by the maintainer, @tpope

This was added in a907c91 by the maintainer, @tpope. Upstream is https://github.com/tpope/vim-haml.

Note that this only added the option to disable. The 'shiftwidth' default was previously in the indent plugin, and had lived there since the file was first created in 2008.
Times change, but it's not clear to me they've changed enough to rip this default out entirely. I'd say Sass and SCSS are in the same bucket as Yaml, where 2 is still the most common default. And the Yaml ftplugin has a recommended_style option, just like Sass.
If I were to propose something, it would be to standardize on a fallback g:recommended_style option, so that people that hate this sort of thing can opt-out once and for all.

Times change, but it's not clear to me they've changed enough to rip this default out entirely.

I understand your point, and I agree with keeping the SASS defaults until a stronger case is made (if ever). From what I understood, it's being phased out in favor of SCSS anyway.
That said, SCSS is an entirely different beast: the official documentation states it is a superset of CSS:

Sass has two syntaxes! The SCSS syntax (.scss) is used most commonly. It’s a superset of CSS, which means all valid CSS is also valid SCSS. The indented syntax (.sass) is more unusual: it uses indentation rather than curly braces to nest statements, and newlines instead of semicolons to separate them. All our examples are available in both syntaxes.

In this case I'd say there's a strong argument for removing the defaults, keeping it close to CSS. The syntax bears little resemblance with ruby, and it doesn't have its own recommended_style.

Any news on this? Thanks!

you want to discuss this on the upstream repo


Update Animist focus pool based on feats and features

Circle of Spirits and Dual Invocation (medium level 9) upgrade the focus pool to the number of attuned apparitions.
Third and Fourth apparitions increase the focus pool by 1.

Keep in mind that these features you mention use the number of primary apparitions, not the number of attuned apparitions. It might be a bit premature to use AELikes as counters when we don't know what implementation will look like yet.

Let's hold off until we know what our animist implementation looks like.


GSSAPI authentication

Hello,
I'm interested in GSSAPI(Kerberos) authentication tool. Is possible with this library?

Not without heavy patching. I'm interested in adding it, but not likely to have time in the next few months. Patches/pull requests are welcome, if you can find the time to do it yourself.

Ok,
Thank you!
I will try to add it!


Removing the bridge plugin should cause the plugin to still work (making it Pure-Forge only)

Fixed in latest


Landing

This sets the default landing page and applies the correct layout and styles. Next time I'll be sure to be in sync with master before submitting a new pull request. :)

Nice! This looks like solid setup stuff, and it's probably perfect. I'll approve as soon as I get my local environment working with Xcode - I'd like to see the changes in the app from master -> landing to get myself more familiar with React Native 😄


VirtualBox.find_machine() erroring on string and bytes

It seems the issue #99 is not only related to #102
In [1]: import sys

In [2]: sys.abiflags = ''

In [3]: import virtualbox

In [4]: vbox = virtualbox.VirtualBox()

In [5]: vm = vbox.find_machine(vbox.machines[0].name)
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
/usr/local/lib/python3.5/dist-packages/virtualbox/library_base.py in _call_method(self, method, in_p)
    194         try:
--> 195             ret = method(*in_params)
    196         except Exception as exc:

/usr/lib/virtualbox/sdk/bindings/xpcom/python/xpcom/client/__init__.py in findMachine(self, Param1)

TypeError: internal error in PyXPCOM, parameter must be a bytes object

During handling of the above exception, another exception occurred:

AttributeError                            Traceback (most recent call last)
<ipython-input-5-65f32237fea6> in <module>()
----> 1 vm = vbox.find_machine(vbox.machines[0].name)

/usr/local/lib/python3.5/dist-packages/virtualbox/library.py in find_machine(self, name_or_id)
   7278             raise TypeError("name_or_id can only be an instance of type basestring")
   7279         machine = self._call("findMachine",
-> 7280                      in_p=[name_or_id])
   7281         machine = IMachine(machine)
   7282         return machine

/usr/local/lib/python3.5/dist-packages/virtualbox/library_base.py in _call(self, name, in_p)
    184         method = self._search_attr(name)
    185         if inspect.isfunction(method) or inspect.ismethod(method):
--> 186             return self._call_method(method, in_p=in_p)
    187         else:
    188             return method

/usr/local/lib/python3.5/dist-packages/virtualbox/library_base.py in _call_method(self, method, in_p)
    210
    211             if errobj.msg is None:
--> 212                 errobj.msg = getattr(exc, 'msg', getattr(exc, 'message'))
    213             raise errobj
    214         return ret

AttributeError: 'TypeError' object has no attribute 'message'

Debian 9
Python 3.5
VirtualBox OSE 5.1.30_Debian r118389

This is funny: it seems the original error is due to input being str instead of the expected bytes.
Nevertheless, when using bytes, it complains of the opposite.
In [10]: vm = vbox.find_machine('IE11 - Win7')
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
/usr/local/lib/python3.5/dist-packages/virtualbox/library_base.py in _call_method(self, method, in_p)
    194         try:
--> 195             ret = method(*in_params)
    196         except Exception as exc:

/usr/lib/virtualbox/sdk/bindings/xpcom/python/xpcom/client/__init__.py in findMachine(self, Param1)

TypeError: internal error in PyXPCOM, parameter must be a bytes object

In [11]: vm = vbox.find_machine(b'IE11 - Win7')
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
/usr/local/lib/python3.5/dist-packages/virtualbox/library_base.py in _call_method(self, method, in_p)
    194         try:
--> 195             ret = method(*in_params)
    196         except Exception as exc:

/usr/lib/virtualbox/sdk/bindings/xpcom/python/xpcom/client/__init__.py in findMachine(self, Param1)

TypeError: This parameter must be a unicode object

Did you install the VirtualBox SDK with Python 3.5 from the website? If not can you try removing and reinstalling it?

I believe it came altogether with the virtualbox debian package.
noxdafox@playground:~$ apt-file search /usr/lib/virtualbox/sdk/bindings/xpcom/python/xpcom/client/__init__.py
virtualbox: /usr/lib/virtualbox/sdk/bindings/xpcom/python/xpcom/client/__init__.py

Instead of installing via Debian try installing via the website. Direct download to the 5.2.6 SDK. Uninstall the Debian package first.
This package is just the VirtualBox SDK right? Not the binaries for actual VirtualBox?

I really need to write up concrete documentation for setting up the environment correctly. I've never tested installing the SDK via package manager, just from the website downloads.

Unfortunately not, this package is the virtualbox package.
It seems the debian package installs everything at once. There's no such virtualbox-sdk package.

Try uninstalling and reinstalling from the website. :) Thanks for the help in debugging this!

I can't really uninstall this as I depend on the VBox shipped with Debian.
Nevertheless, I downloaded the sdk and replaced the installed bindings and the issue is still there.

Just install virtualbox and Python 3.
Note that VirtualBox OSE is not included in Debian 9 therefore you need to install from stretch backports.
More info here.

Okay thanks!

While investigating further I found this.
It seems the virtualbox debian package is broken and ships only the Python2 version, this would explain why it insists to find unicode parameters (Pyhton 3 has no unicode type anymore).
This might help clarifying also #102

Nice find! I'll have to add this to the documentation somewhere! :)

If I were you I'd raise an issue with Debian. Maybe they already switched to Python 3 for the next release?

I gave a try to the version from testing/buster and it messed all my environment as it pulled Python 3.6.
At the end, I was getting unable to import pyvbox error when trying to import virtualbox so I eventually gave up. This has become too time consuming.

If you've still go some energy left you should try the installer on the website for Ubuntu/Debian. I used this method and use VirtualBox on my Ubuntu 17.10 installation daily. :) I would just uninstall all the packaged VirtualBox installations first.

That was the first one I tried. Issue is the VNC plugin for that version was somehow mis-functioning (or rather not working at all).

Is the VNC plugin part of Guest Additions? For 5.2.6 it looks like they had a problem with the Guest Additions that's shipped with 5.2.6 and recommend upgrading. Look for the Important line right above the downloads on the Downloads page.

Nope the VNC is a separate extension working host-side.
It is shipped together with VirtualBox OSE packages and it works properly there. Yet I had no luck with the Oracle version.

BTW this is the error I get with VirtualBox 5.2.6 and pyvbox. This happens both with the one shipped via Debian testing/buster and the one installed from virtualbox.org with their SDK.
sudo dpkg -i virtualbox-5.2_5.2.6-120293~Debian~stretch_amd64.deb
sudo python3 vboxapisetup.py install

ipython3
Python 3.5.3 (default, Jan 19 2017, 14:11:04)
Type 'copyright', 'credits' or 'license' for more information
IPython 6.2.1 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import virtualbox
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
<ipython-input-1-1856251cb791> in <module>()
----> 1 import virtualbox

/usr/local/lib/python3.5/dist-packages/virtualbox/__init__.py in <module>()
    243
    244 # Lazy include...
--> 245 from virtualbox import pool  # noqa: F401
    246 from virtualbox import events  # noqa: F401

ImportError: No module named 'pyvbox'

Could you try installing pyvbox in a virtualenv and trying the same?

The import error becomes different.
In [1]: import virtualbox
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
<ipython-input-1-1856251cb791> in <module>()
----> 1 import virtualbox

~/development/virtualenvs/pyvbox/lib/python3.5/site-packages/virtualbox/__init__.py in <module>()
    243
    244 # Lazy include...
--> 245 from virtualbox import pool  # noqa: F401
    246 from virtualbox import events  # noqa: F401

ImportError: cannot import name 'pool'

Hmmm... I wonder why it doesn't like those imports. Could you try with non-ipython? I don't know much about how it does its magic.

Same.
python3
Python 3.5.3 (default, Jan 19 2017, 14:11:04)
[GCC 6.3.0 20170118] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import virtualbox
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/noxdafox/development/virtualenvs/pyvbox/lib/python3.5/site-packages/virtualbox/__init__.py", line 245, in <module>
    from virtualbox import pool  # noqa: F401
ImportError: cannot import name 'pool'
>>>

Could you tarball that whole venv up and attach it here?

Had to fool GitHub as it accepts only ZIP files (it just checks the extension tho). It's a tar.bz2.
pyvbox_tar_bz.zip

I'm able to reproduce this issue, I'll work on a fix.

Good to know! Thanks for your time & dedication.

Try installing 1.3.2 from PyPI!

This fixed the import error, thanks!
I still suffer from lots of other issues though.
This happens with both VirtualBox PUEL and VirtualBox OSE (setting sys.abiflags = '').
In [1]: import virtualbox
   ...: vbox = virtualbox.VirtualBox()
   ...: vm = vbox.find_machine(vbox.machines[0].name)
   ...: session = vm.create_session()
   ...: h, w, _, _, _, _ = session.console.display.get_screen_resolution(0)
   ...: png = session.console.display.take_screen_shot_to_array(0, h, w, virtualbox.library.BitmapFormat.png)
   ...:
---------------------------------------------------------------------------
UnicodeDecodeError                        Traceback (most recent call last)
~/development/virtualenvs/pyvbox/lib/python3.5/site-packages/virtualbox/library_base.py in _call_method(self, method, in_p)
    194         try:
--> 195             ret = method(*in_params)
    196         except Exception as exc:

/usr/lib/virtualbox/sdk/bindings/xpcom/python/xpcom/client/__init__.py in takeScreenShotToArray(self, Param1, Param2, Param3, Param4)

UnicodeDecodeError: 'utf-8' codec can't decode byte 0x89 in position 0: invalid start byte

During handling of the above exception, another exception occurred:

AttributeError                            Traceback (most recent call last)
<ipython-input-1-a41323a6ea59> in <module>()
      4 session = vm.create_session()
      5 h, w, _, _, _, _ = session.console.display.get_screen_resolution(0)
----> 6 png = session.console.display.take_screen_shot_to_array(0, h, w, virtualbox.library.BitmapFormat.png)

~/development/virtualenvs/pyvbox/lib/python3.5/site-packages/virtualbox/library.py in take_screen_shot_to_array(self, screen_id, width, height, bitmap_format)
  23680             raise TypeError("bitmap_format can only be an instance of type BitmapFormat")
  23681         screen_data = self._call("takeScreenShotToArray",
> 23682                      in_p=[screen_id, width, height, bitmap_format])
  23683         return screen_data
  23684

~/development/virtualenvs/pyvbox/lib/python3.5/site-packages/virtualbox/library_base.py in _call(self, name, in_p)
    184         method = self._search_attr(name)
    185         if inspect.isfunction(method) or inspect.ismethod(method):
--> 186             return self._call_method(method, in_p=in_p)
    187         else:
    188             return method

~/development/virtualenvs/pyvbox/lib/python3.5/site-packages/virtualbox/library_base.py in _call_method(self, method, in_p)
    210
    211             if errobj.msg is None:
--> 212                 errobj.msg = getattr(exc, 'msg', getattr(exc, 'message'))
    213             raise errobj
    214         return ret

AttributeError: 'UnicodeDecodeError' object has no attribute 'message'

This looks like it's an error with XPCOM. Could you open a new issue for this? :)

#111