tools/ci: Enable build sim:cxxtest

Summary
Impact
Add more build test for sim
Testing
Pass CI

Depends on https://github.com/apache/incubator-nuttx/pull/4487:
Undefined symbols for architecture x86_64:
"_macho_call_saved_init_funcs", referenced from:
_cxx_initialize in nuttx.rel
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Let's enable build first to catch the compiler issue, and fix the runtime error later?

Let's enable build first to catch the compiler issue, and fix the runtime error later?

i have no problem with it.

FYI, sim:cxxtest with a few debug options enabled fails like the following.
nuttx was compiled with optimization - stepping may behave oddly; variables may not be available.
Process 85832 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0xffffffffffffffe8)
    frame #0: 0x0000000100011fc6 nuttx`std::ios_base::ios_base() [inlined] std::ios_base::Init::Init(this=<unavailable>) at ios.cpp:96:4 [opt]
   93   #ifdef __UCLIBCXX_SUPPORT_CERR__
   94                           _cerr_filebuf.fp = stderr;
   95                           _cerr_filebuf.openedFor = ios_base::out;
-> 96                           cerr.mformat |= ios_base::unitbuf;
   97   #endif
   98   #ifdef __UCLIBCXX_SUPPORT_CLOG__
   99                           _clog_filebuf.fp = stderr;
Target 0: (nuttx) stopped.
(lldb)
(lldb) bt
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0xffffffffffffffe8)
  * frame #0: 0x0000000100011fc6 nuttx`std::ios_base::ios_base() [inlined] std::ios_base::Init::Init(this=<unavailable>) at ios.cpp:96:4 [opt]
    frame #1: 0x0000000100011f78 nuttx`std::ios_base::ios_base() [inlined] std::ios_base::Init::Init(this=<unavailable>) at ios.cpp:87:36 [opt]
    frame #2: 0x0000000100011f78 nuttx`std::ios_base::ios_base(this=<unavailable>) at ios:158:5 [opt]
    frame #3: 0x000000010001d96c nuttx`_GLOBAL__sub_I_ios.cpp [inlined] std::basic_ios<char, std::char_traits<char> >::basic_ios(this=<unavailable>, sb=0x0000000100024fc0) at ios:345:24 [opt]
    frame #4: 0x000000010001d960 nuttx`_GLOBAL__sub_I_ios.cpp [inlined] std::basic_ostream<char, std::char_traits<char> >::basic_ostream(this=<unavailable>, sb=0x0000000100024fc0) at ostream:57:6 [opt]
    frame #5: 0x000000010001d960 nuttx`_GLOBAL__sub_I_ios.cpp [inlined] __cxx_global_var_init.4 at ios.cpp:62:22 [opt]
    frame #6: 0x000000010001d960 nuttx`_GLOBAL__sub_I_ios.cpp at ios.cpp:0 [opt]
    frame #7: 0x00000001000032e5 nuttx`macho_call_saved_init_funcs + 101
    frame #8: 0x00000001000099f2 nuttx`cxx_initialize at cxx_initialize_macho.c:56:7 [opt]
    frame #9: 0x00000001000099ce nuttx`nxtask_startup(entrypt=(nuttx`::cxxtest_main(int, char **) at cxxtest_main.cxx:218), argc=1, argv=0x0000000101001540) at task_startup.c:64:3 [opt]
    frame #10: 0x00000001000076e6 nuttx`nxtask_start at task_start.c:130:7 [opt]
(lldb)
(lldb) p cerr
warning: `this' is not accessible (substituting 0)
(std::ostream) $0 = {
  std::basic_ios<char, std::char_traits<char> > = {
    std::ios_base = (mLocale = std::locale @ 0x0000600001525960, mformat = 0, mstate = '\0', mmode = '\0', mdir = '\0', mprecision = 0, mwidth = 0, mInit = std::ios_base::Init @ 0x0000600001525978)
    fill_char = '\0'
    mtied = nullptr
    mstreambuf = nullptr
    throw_mask = '\0'
  }
}
(lldb)

Look like we fix this problem locally, @zhuyanlinzyl could upstream the patch, let @yamt try it?

hi @yamt  you can try this patch
https://github.com/apache/incubator-nuttx/pull/5299
It fix  a bug in uclibxx constructor initialize


CI testing for VM/CNV

Spawning this issue from https://github.com/cloud-bulldozer/benchmark-wrapper/pull/261 which was caused because we did not test on anything outside of openshift (ie VMs, etc).
We currently do not have a method of CI testing CNV/VM's for benchmark-wrapper. As we continue to move forward this is something we should look into as it will likely become more prevelant.
cc: @sarahbx @jtaleric @amitsagtani97

@dry923  Just FYI, if you add CNV to the CI environment, we can run fio inside CNV VMs, that's already supported (except for issue 527 which I haven't had time to work on, but it has an easy fix described there).

Hey @bengland2 The hope would be we increase the coverage of SNAFU to cover, BM, VM, Container (Podman/docker), OCP...

+1 for VM/CNV testing, but we should probably look at moving away from python setup.py develop for CI builds and normal usage. That was the main difference between the two in #261.

Issue #261 was caused because of missing init file in the log_wrapper directory. It would still fail on outside of openshift (ie VMs, etc) without that file. benchmark-wrapper is installed as a python package and directories without init file are not included in the package.
Benchmark-wrapper CI uses benchmark-operator, the test for log_wrapper were not merged at that moment, else our CI would have found this issue.
@sarahbx  Another way to install benchmark-wrapper is pip install git+https://github.com/cloud-bulldozer/benchmark-wrapper.git but I guess that is similar to git clone and python setup.py develop

Hi @amitsagtani97 :) For VMs in benchmark-operator, we are using pip install git+https://... in the VMs. When running the pod versions of the same tests, they were successful. Looks like pip install -e is being used for the wrapper installs, which behaves the same as python setup.py develop.
https://github.com/cloud-bulldozer/benchmark-wrapper/blob/19c9e3bd3ad3f5bafb90648c31ecac9075c92643/snafu/uperf_wrapper/Dockerfile#L11

@learnitall I wonder how your staged CI would mitigate the need for this?


Fix upsert handling of nullable fields

Based on the feedback on #1761, the handling for upserting fields with a null value is correct: null values should never overwrite pre-existing data in upsert queries, since the document being upserted is in an unknown state and we can't know for certain that the value should be unset.
This PR brings this same behavior to fields with the nullable attribute set, where an upsert would always overwrite database values with a null value: this is now only done if the upsert results in an insertion, thus preserving pre-existing data but ensuring the normal behavior of the nullable flag is preserved.

Merge time! Thanks @alcaeus


Missing files to reproduce artifact

Hi, I was trying to build the artifact as  the instructions in the README, and some files are missing from the repo:
./scripts/install_cmake.sh
./scripts/install_deps.sh
Those are files used in install_sFuzz.sh
For this reason, I'm not able to run ./build.sh til the end, I get the error:
9.693     Configuring Z3
9.693     error: [Errno 2] No such file or directory: 'cmake': 'cmake'
9.693

Invalid


Cut New Release

what

Cut a new release

why

Latest code was merged ~1 year ago
Latest release is from 2016

Let's make that happen! https://github.com/wrouesnel/emailcli/releases/tag/v0.0.2 (should be built shortly)

@wrouesnel there's still no binary attachment on the release. Can you take a look? =)

Finally building (caught the tail end of the github outage and then you know, had to sleep :)

lol, yea, that was a pretty bad 24 hour outage! I was working the minute it hit. Thanks for getting that taken care of! we'll release that.


time: want more control over time.Format

Using go version go1.3.3 linux/amd64
func main() {
        t := time.Now()
        fmt.Printf("time: %v; format: %s\n", t, t.Format("20080101 10:00:00.000"))
}

Prints:
time: 2015-01-09 17:06:02.033307544 +0000 UTC; format: 90080101 10:00:00.033

I want YYYYMMDD, but time.Format is only layout by example, so it cannot know what digits mean year, month, day. I have to do it by hand.

Use the reference time. This is explained in the docs: http://golang.org/pkg/time/#pkg-constants

@ddietterich http://play.golang.org/p/REvcaiEavz

I read that documentation. I find nothing there that lets me distinguish years, months and days in a concatenated string. It just will not do what I want it to do.

@cespare Maybe there is a fix between 1.3.3 and 1.4? You can see that I did not get the correct year in my example.

@ddietterich as @bradfitz said, you need to use the reference time, not some other time of your choosing. (Examine carefully the difference between your code and mine.)

OK, I get it.
I find it entirely obscure and won't use it, but I cannot complain that it won't do what I want it to do.
Thanks!


[URGENT] Add issue template

I have noticed that multiple people are working on some issues. I have added issue templates so that it will not happen.

I am working on this


avoid creating PyRef inside __traverse__ handler

See https://github.com/PyO3/pyo3/issues/4265#issuecomment-2305890021
We cannot use PyRef<T> to guard access to the value inside a __traverse__ handler. Instead I use the PyClassObject<T> and manually perform the borrow checking.

cc @ngoldbaum

We could also make the change suggested by the comment here....
#[repr(transparent)]
pub struct PyRef<'p, T: PyClass> {
    // TODO: once the GIL Ref API is removed, consider adding a lifetime parameter to `PyRef` to
    // store `Borrowed` here instead, avoiding reference counting overhead.
    inner: Bound<'p, T>,
}

as that would also avoid changing reference counts.

I believe that would need #4390. Also in that thread https://github.com/PyO3/pyo3/pull/4390#discussion_r1702907653 there was the suggestion to maybe delay that change to 0.24

Yes agreed, I considered changing PyRef but would prefer to delay given there's enough breaking changes coming in 0.23. I also want to be careful with changing PyRef right now because I think it might need other changes for the freethreaded build.
I also think I might backport this fix to 0.22, which would be another reason not to have the breaking change here.

I did some local testing on this PR.
After rebasing on main to fix some noisy tests that were fixed by me last week, this does seem to fix the "accessing the GIL while a __traverse__  implementation is running" panics.

Great, will merge this. I am considering landing this as part of a stack of fixes in a 0.22.3 patch.


Kaspersky Internet Security detects false positive

It detected a range of Ollama files. Here is the full list:
ollama-kaspersky.txt

Kaspersky and MS Defender are turning into the worst security apps ever seen.
Try upload ext_server.dll and llama.dll on virus total or Kaspersky Threat Intelligence Portal and please share result so we can compare, because this two files from your list must be clean, there is some other reason why is detected as Trojan and and I'm afraid it isn't Go problem.

Is anyone still seeing these false positive reports?

No, the virus reports I encountered in version version 0.1.27 seems to be
fixed in version 0.1.28
On Tue, 12 Mar 2024 at 07:27, Daniel Hiltgen @.***>
wrote:

Is anyone still seeing these false positive reports?
—
Reply to this email directly, view it on GitHub
https://github.com/ollama/ollama/issues/2855#issuecomment-1989380624,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGDANJTD7JXV5OQN6HF7W5TYXYOS7AVCNFSM6AAAAABEBF6DKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBZGM4DANRSGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Will close as this seems to have subsided. Sorry about all the false positive warnings.


pl.lapp doesn't correct with flags

This example doesn't work correctly
local args_ = lapp [[
--hello
]]
This example works correctly
local args_ = lapp [[
--hello                             hello
]]
Is it correct behavior?

I think it should work correctly, that is, the rest of the line should be ignored correctly. So I'll have a look at this.

The first example:       th example.lua --hell
The second example: th example.lua --hello

The 'little hack' is to check if the rest of the line has exactly one char, and append it to the long parm. Feels like a hack, because it could be a multibyte char. Otherwise, have to look very carefully at how SIP is working here!


Clone parent repo with nested repos that contain branches

Do we now have a way to clone the root TFS collection with children repos that contain branches? I am getting the error below when using --braches=all argument.
error: cloning the whole repository or too high in the repository path doesn't permit to manage branches!
=> If you want to manage branches with git-tfs, clone one of this branch instead :
{Repos with branches listed here...}
It would be nice if the tool would allow it or provide a way to achieve the migration that follows our monorepo structure where the nested repos contain branches.
Appreciate the help.

Cloning multiple different independent repos in TFS with --branches=all can't work, because --branches=all
means that git-tfs will create a structure in git where each TFS branch is mapped to a git branch for one TFS repo. You are dealing with multiple TFS repos.
If you just want to have a code mirror of what is in TFS stored in git, then try cloning the root TFS collection with --branches=none.
In case you want the nested repos to be cloned into independent git repos, give their mainline as argument to the clone.

It would be nice if the tool would allow it or provide a way to achieve the migration that follows our monorepo structure where the nested repos contain branches.

I could add the matching one TFVC Collection into one or multiple Git repository is a very difficult (and perhaps impossible) thing to do.
Git-tfs is far from being able to do that.
And because git-tfs is mostly hibernating project that continue to live only with support of contributors, I don't think it will support it one day.
So, I think you should find another way to achieve what you want to do...

Cloning multiple different independent repos in TFS with --branches=all can't work, because --branches=all
means that git-tfs will create a structure in git where each TFS branch is mapped to a git branch for one TFS repo. You are dealing with multiple TFS repos.

That's what we observed when looking at the migration output with default --branches=auto. We wanted to try cloning separately the nested repo with branches using --branches=all then merge them onto the parent git repo, but then realized we could only merge a branch at one time. So we would probably need to create a matching branch on the parent repo for each branch in the nested repo. I don't think that is what we want though at this point but we are considering it as a last resort just for this one-time migration.
Thanks siprbaum.

It would be nice if the tool would allow it or provide a way to achieve the migration that follows our monorepo structure where the nested repos contain branches.

I could add the matching one TFVC Collection into one or multiple Git repository is a very difficult (and perhaps impossible) thing to do.
Git-tfs is far from being able to do that.
And because git-tfs is mostly hibernating project that continue to live only with support of contributors, I don't think it will support it one day.
So, I think you should find another way to achieve what you want to do...

Thanks pmiossec for sharing your thoughts. We did find git-tfs to migrate the collection fine with the default branches=auto except for the branches in the nested repo which is understandable because of the limitation of branching concept in git. We are considering other options and potentially might have to look into updating and migrating just the main lines of the nested repos with branches.

We ended up having to clone each repo separately and then used tomono script to recreate the monorepo structure and branches.


delete pkgs from core repo which have moved out into their own repos

appui pkgs have moved to https://github.com/iTwin/appui
presentation pkgs have moved to https://github.com/iTwin/presentation
eslint-plugin has moved to https://github.com/iTwin/eslint-plugin
map-layers has moved to https://github.com/iTwin/viewer-components-react

@iTwin/itwinjs-core-presentation is the presentation test app in this repo still required or will it be completely replaced by the one in the presentation repo?

@iTwin/itwinjs-core-presentation is the presentation test app in this repo still required or will it be completely replaced by the one in the presentation repo?

The test app will be completely removed from core repo. We'll also remove some of the tests in presentation-full-stack-tests suite.

I have PR removing presentation-components, presentation-testing and some full-stack-tests. I am only waiting for docs pipeline before I can complete it. https://github.com/iTwin/itwinjs-core/pull/4836

@aruniverse As docs pipeline was updated I looked again at my PR removing some presentation-full-stack-tests https://github.com/iTwin/itwinjs-core/pull/4836. I tried removing presentation-components and presentation-testing in that PR as well but it looks like those packages should be remove at the same time as ui. So that could be done in this PR.
As for presentation-full-stack-tests not all of them should be removed. The ones that needs to be removed are removed in this PR https://github.com/iTwin/itwinjs-core/pull/4836. So this PR should not need to make any changes in full-stack-test/presentation folder.

I presume #4580 is dead now @mdastous-bentley?
@eringram have you moved your WIP changes to viewer-components-react repo?

I presume #4580 is dead now @mdastous-bentley? @eringram have you moved your WIP changes to viewer-components-react repo?

Not yet but I plan to after this PR is merged. I think with my changes MapLayerImageryProvider will also need to be exposed since it's used by the map layers widget.

I presume #4580 is dead now @mdastous-bentley?
Depends on Erin's changes.  There's still a need to expose map-layer imagery providers to create a new format like we do in map-layers-formats.


Make UNIT consistent across codebase

Currently there's instances of 100000000 in the HTML side, which would be better and more consistent using the UNIT setup in the controller(s). E.g. {{ it.balance / ac.UNIT }} instead of {{ it.balance / 100000000 }}

This has been already accomplished


Detekt doesn't goes along with the new ksp version

Expected Behavior
When I update kotlin and ksp (I need to upgrade both at the same time) detekt doesn't review new files.
Observed Behavior
I'm updating my project from kotlin 1.9.10 to 1.9.20 and ksp from 1.9.10-1.0.13 to 1.9.20-1.0.13 (same problem with 1.9.20-1.0.14). And after this update detekt starts to complain about some files inside the build/generated folder.
Steps to Reproduce
If needed I can create a reproducer.
Context
I added this to my detekt task to debug it:
tasks.withType<Detekt>().configureEach {
    jvmTarget = jdkVersion

    doFirst {
        this as Detekt
        println("@@@@@@@@@@@@@@")
        this.source.visit { println(this) }
        println("@@@@@@@@@@@@@@")
    }
}

And before I update the generated files are not listed. As soon as I update kotlin & ksp the generated files appear.
Probably this is not related but while I was researching this I enabled the debug mode on detekt and I found this warnign:
warning: classpath entry points to a non-existent location: /Users/brais.gabin/Workspace/project/module/build/generated/ksp/main/classes

I think it is not related because that warning appears with the previous version and the new one.
Your Environment

Version of detekt used: 1.23.3
Version of Gradle used (if applicable): 8.4
Gradle scan link (add --scan option when running the gradle task): I can't share
Operating System and version: MacOS and Linux (CI)

I just find out that this issue is only on the jvm modules. On the android modules everything works as expected.

This was really easy to reproduce on a simple project. I updated the first post with a link to the repo with the reproducer and a link to the gradle scan.

Also see https://github.com/google/ksp/issues/1261
I haven't looked at what we can do in our project to work around this yet. Probably just excluding the path(s) in the meantime.

Closing as this is a problem on KSP or KGP.


docs: Update russian translation for env variables page

✅ Checklist

[x] I have followed every step in the contributing guide (updated 2022-10-06).
[x] The PR title follows the convention we established conventional-commit
[x] I performed a functional test on my final commit

Changelog

Updated Russian translation of the env variables page

Preview:
https://create-t3-app-git-fork-ronanru-env-t3-oss.vercel.app/ru/usage/env-variables
💯

Sorry, didnt see the PR at first, having to much on my plate now. LGTM


Level.Read() fails to handle errors while reading the level file

Reading the incorrect file format and version doesn't result in an error as it should.

no longer relevant.


feat: update electron-build version to 23.1.0 to fix MacOS 12.3 pytho…

…n path
PR Details

Update electron-builder version in @modern/create electron template.
Related to a fixed electron-builder issue: https://github.com/electron-userland/electron-builder/pull/6789
Description

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

[x] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[x] I have updated changeset
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.spencerHT seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Adding objects for results after the file is processed.

Adding objects for the result of the file process. fix default value for configuration (operation) add.


Add blank page

Can we add a new blank page after a specific page in pdf

No, since the PDF.js library doesn't support arbitrary editing.

For future reference: Please don't ignore the ISSUE_TEMPLATE, since the issue contains no actionable data or meaningful context.


Shade kubernetes and xds module

What is the purpose of the change
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #10514 (e9984ff) into 3.1 (6fdc6a5) will decrease coverage by 1.46%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.1   #10514      +/-   ##
============================================
- Coverage     65.48%   64.01%   -1.47%
- Complexity      318      334      +16
============================================
  Files          1275     1325      +50
  Lines         55045    56365    +1320
  Branches       8297     8358      +61
============================================
+ Hits          36048    36084      +36
- Misses        15072    16307    +1235
- Partials       3925     3974      +49

Impacted Files
Coverage Δ

.../serialize/hessian2/Hessian2SerializerFactory.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...sian2/dubbo/DefaultHessian2FactoryInitializer.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ian2/dubbo/AbstractHessian2FactoryInitializer.java
0.00% <0.00%> (-61.12%)
:arrow_down:

...ize/hessian2/dubbo/Hessian2FactoryInitializer.java
0.00% <0.00%> (-60.00%)
:arrow_down:

...common/serialize/hessian2/Hessian2ObjectInput.java
0.00% <0.00%> (-51.86%)
:arrow_down:

...ommon/serialize/hessian2/Hessian2ObjectOutput.java
0.00% <0.00%> (-43.75%)
:arrow_down:

...mmon/serialize/hessian2/Hessian2Serialization.java
40.00% <0.00%> (-40.00%)
:arrow_down:

...dubbo/remoting/zookeeper/ZookeeperTransporter.java
50.00% <0.00%> (-33.34%)
:arrow_down:

...dubbo/common/status/support/LoadStatusChecker.java
41.66% <0.00%> (-25.00%)
:arrow_down:

...ng/zookeeper/curator5/Curator5ZookeeperClient.java
43.86% <0.00%> (-24.53%)
:arrow_down:

... and 130 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


copySourcePathAssets: Failed to copy file from source to destination

I use the latest version (18.0) to compile an Adobe Air desktop project. As there are lots of files(eg. jpg, xml, png) should be copyed to output dir, I add "copySurcePathAssets" : true  to asconfig.json. And then I get an error "Failed to copy file from source [source-path]/.copyarea.db to destination [output-dir]/.copyarea.db" and the process terminated with exit code 1. I think it is caused by the file name. The file .copyarea.db is created by SCM(IBM Clear Case) in each dir of src. Is there anyway not copy these files to output dir??

Do you think that it would be enough to skip copying hidden files?

It may works on Linux or Mac, but I'm working on Windows. The `.copyarea.db' is NOT a hidden files on Windows. BTW, even though I get the error, but the file has been copyed. I can find it in output dir. So I don't know what happend indeed.

Something more. If I delete .copyarea.db from output dir then rerun compile task. I get file copy error but point to another file: "Failed to copy file from source [source-path]/config.xml to destination [output-dir]/config.xml". And the .copyarea.db is copyed to output dir with no error. The config.xml is just a simple READ ONLY xml file. So it seems like the problem is not caused by file name...

I did more test. Even though I delete all .copyarea.db files from source dir, I still get file copy failed error. If I build the project with other IDE (Intellij IDEA) once, get static files (png, xml...) copyed to output dir. And then use VS Code to compile project with copySourcePathAssets : false, everything works fine.

So it sounds like it's having trouble copying any files in your project, and .copyarea.db is not the cause.
I know that Windows often has problems related to having the same file open in multiple programs. Do you have any other programs running that might be reading or writing to files that are inside your project folder during the build?

I try to compile my project after close all other softwares, but  I still get the "failed to copy file" error. But I find a way to "solve" the problem : I add each resource floder to "files" in asconfig.json. Even I get the copy failed error, but in fact the files are already copyed to output dir.
"files" : [
    "src",
    "src/config",
    "src/assets",
    "src/db"
]

Well, I'm wrong. You can not simply ignore the "failed to copy file" error. Although the files are copyed to  output dir. But the compilation is NOT complete. There is no application describe xml file and no unpacked ANE files. You can not debug the program.

Is the "copySourcePathAssets" function provided by VS Code? I can't find any code line about this function in the source of extension.

It's implemented in the asconfigc module:
https://github.com/BowlerHatLLC/vscode-as3mxml/blob/master/asconfigc/src/main/java/com/as3mxml/asconfigc/ASConfigC.java
It uses Java's standard Files.copy().

I think I know what's happend.

In my project, those files (eg. jpg, xml) are all under the control of SCM, so they are all read only files. In https://github.com/BowlerHatLLC/vscode-as3mxml/blob/master/asconfigc/src/main/java/com/as3mxml/asconfigc/ASConfigC.java, line 332, we get a sourcePath from asconfig.json which is "src".
And then in https://github.com/BowlerHatLLC/vscode-as3mxml/blob/master/asconfigc/src/main/java/com/as3mxml/asconfigc/utils/ProjectUtils.java, line 259, we get a sourcePath too, which is also "src" (my main file is just in the src floder).
At last, in https://github.com/BowlerHatLLC/vscode-as3mxml/blob/master/asconfigc/src/main/java/com/as3mxml/asconfigc/ASConfigC.java, line 758, the ProjectUtils.findSourcePathAssets() return with a collection which contains two "src" value. And in the loop at line 764, it runs copySourcePathAssetToOutputDirectory() for "src" twice.
It can explan why every file have copyed but we still get "Failed to copy" error. Cause they are copyed twice, and the error occur in the second time.
So will you ignore duplicated value before put hem in to result in  findSourcePathAssets() (https://github.com/BowlerHatLLC/vscode-as3mxml/blob/master/asconfigc/src/main/java/com/as3mxml/asconfigc/utils/ProjectUtils.java).
BTW, I think the same thing may happend in copyHTMLTemplate() and copyAIRFiles(), you may check it out.
I hope it can help you fix the problem. I'm looking forward the new version of the extension.
At last, thank you for you effort to develop this extension. It's the only hope for me to sove my trouble (FB is realy poor efficiency, and IDEA is much too expensive )

Thank you, that's very useful information. I'll try to update it to remove duplicate source paths.

I assume that you didn't mean to close this.

Now you have already know the problem and  may fix it in next version of the extension. On the other hand, I comment the source path setting in asconfig.json, and I can work on my project now. So I think this issue has finished it's job. It's time to close it.

I will close it after I fix it. I need it to remain open so that I don't forget about it. :)


changes ordering of dipthonization and nasalization in pronunciation.grm

This fixes the scansion errors I was talking about when adding textproto comments. Previously, "Danaum" was mapped to "danawm," but in all instances the w does not glide.

I owe you a response on this in the next few days, sorry for delay. I just
have to bust out the pencil and paper and think about it a bit...
On Thu, Mar 3, 2022 at 7:06 PM jillianchang @.***>
wrote:

@.**** commented on this pull request.
In grammars/pronounce.grm
https://github.com/CUNY-CL/latin_scansion/pull/98#discussion_r819164400:

test_pron_19 = AssertEqual[

 "aut pelagō danaum īnsidiās suspectaque dōna" @ PRONOUNCE,

"awt pelagoː danawm iːnsidiaːs suspektakwe doːna"

"awt pelagoː danaũː iːnsidiaːs suspektakwe doːna"

Do you have new opinions on this?
—
Reply to this email directly, view it on GitHub
https://github.com/CUNY-CL/latin_scansion/pull/98#discussion_r819164400,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABG4OOZQ7FOLDXL73I75UTU6FHX3ANCNFSM5POA5A4Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

Okay, sorry, I have one more question, sorry to be such an annoyance on this.
This is currently implemented as a variable diaeresis rule. Is there a reason nasalization-before-diphthongization can't be implemented as mandatory, applying in pronounce.grm? If that is a correct description it's certainly cleaner.

Okay, sorry, I have one more question, sorry to be such an annoyance on this.
This is currently implemented as a variable diaeresis rule. Is there a reason nasalization-before-diphthongization can't be implemented as mandatory, applying in pronounce.grm? If that is a correct description it's certainly cleaner.

I think you are right on that. I already had the nasalization-before-diphthonizaiton, so what I did is remove the au variable rule. It should be good to go now.


Local docs currently broken

running sbt docs/previewSite gives me:
java.lang.RuntimeException: Error writing content for page tutorial/in-memory-model.html: Unknown snippet [/home/keir/Code/gsp-graphql/demo/src/main/scala/starwars/StarWarsData.scala (No such file or directory)] referenced from [tutorial/in-memory-model.html]

It looks like this was broken in https://github.com/gemini-hlsw/gsp-graphql/pull/253 ... @rpiotrow would you be able to take a look?


Export constants from token package

Signed-off-by: Dimitrios Markou<EMAIL_ADDRESS>

@mardim91 I presume this is for your webhook work, correct?
If so, are the constants the only dependencies you'd be pulling into the webhook repo? I ask, because minimizing dependencies is always on my mind, and I'm curious is there is a way to do so here :)

@mardim91 I presume this is for your webhook work, correct?
If so, are the constants the only dependencies you'd be pulling into the webhook repo? I ask, because minimizing dependencies is always on my mind, and I'm curious is there is a way to do so here :)

@edwarnicke yes you are right the constatns from sdk-sriov repo is my only dependency. I agree maybe we should try to minimize the dependencies. We can just create those constants in some folder inside the webhook repo but this seems like duplicate code for the same constants or maybe we can have like a policy to put all the constants of NSM universe in a single repo and all the projects can use that repo to import constants. One candidate repo for that could be nsm/api. What do you think ?

Yeah... I share your concern about defining constants in multiple places... its asking for a bug later on when things are renamed.
For many constants, we put them in the api repo if they are shared across different downstream repos.  Would that make sense here?  If so, where would it make sense to put it in the api repo?  Does the webhook currently depend on the API repo?
Like so many other things in code... this is going to be a game of trade-offs... so lets talk about the options and see what looks like the best among them :)

Yeah... I share your concern about defining constants in multiple places... its asking for a bug later on when things are renamed.
For many constants, we put them in the api repo if they are shared across different downstream repos. Would that make sense here? If so, where would it make sense to put it in the api repo? Does the webhook currently depend on the API repo?
Like so many other things in code... this is going to be a game of trade-offs... so lets

Right now webhook only depends on the sdk repo. In case that we decide that api repo is the right place from strategic perspective to gather all the NSM constants then we can make it a dependency to webhook repo. Regarding where to put the constants that I do not know yet but definetely makes sense to me to put the constants for sriov token to the api repo.

If the webhook depends on the sdk repo, it depends transitively on the api repo too :)
@Bolodya1997 - thoughts on the proper place to put this constant in the api repo?

@mardim91 Would it make sense to put SriovTokenLabel in `labels/sriov/constants.go' under https://github.com/networkservicemesh/api/tree/main/pkg/api/networkservice

@mardim91 Would it make sense to put SriovTokenLabel in `/pkg/api/networkservice/labels/sriov/constants.go' in https://github.com/networkservicemesh/api/

@edwarnicke yes ok I will do that. I guess we should abandon this PR right ?

@edwarnicke yes ok I will do that. I guess we should abandon this PR right ?

@mardim91 Feel free to Close it and submit the PR to API :)


Removal of filtered-discovery-page in Angular

In the initial entities implementation, a REST feature for filtered-discovery-page has been created.
This was later-on noticed as a feature which is not necessary.
Although the functionality is no longer used in Angular, we found some remnants
This PR removes the remainder of this functionality. It is related to https://github.com/DSpace/DSpace/pull/2499 but not dependent on that branch

I've done some more testing and the issue seems to be due to a really short cache timeout I had in my environment.dev.js. I was testing with an author that had hundreds of related publications, so the request took longer than my cache timeout. Using the default cache timeout I can't reproduce this issue.

Merging since this is at +2


SQUEEZE A TINY BIT OF SIZE IN PRODUCTION MODE

use gulp-preprocess to squeeze a few bytes in release mode of app by stripping of some checks
extended gulpfile and included two preprocessor constants DEBUG and VISUAL_DEBUG to control Kontra precompiler

Coverage remained the same at 99.334% when pulling 989423857b09207b8575964df55a2cead3275b23 on Quentie:conditionalCompilationUsingGulpPreprocess into f97dae475b846bfc2eac85e76a658acb46a5b89e on straker:master.

Coverage remained the same at 99.334% when pulling e9a372b88579963879e1f17753bc177a212b163b on Quentie:conditionalCompilationUsingGulpPreprocess into f97dae475b846bfc2eac85e76a658acb46a5b89e on straker:master.

Coverage remained the same at 99.334% when pulling 14cda37e0abe4d8d9a641d1b7aafb55c11c45009 on Quentie:conditionalCompilationUsingGulpPreprocess into f97dae475b846bfc2eac85e76a658acb46a5b89e on straker:master.

Amazing feature. Thanks for helping make this even smaller. I'll merge this in tomorrow evening in case you want to address my comment, otherwise I'll accept it as is.
Thanks again.


Uncaught (in promise) TypeError: (0 , _zipcelx2.default) is not a function

Hi, I tried to use this library by using the example of the page "How to use"
But I received the following error when I tried to generate the file (a button that run the code):
"Uncaught (in promise) TypeError: (0 , _zipcelx2.default) is not a function"
EDIT: I solved by using import 'zipcelx' instead of import zipcelx from 'zipcelx'

Thank you for noticing this. That is not the expected behavior, but I'm happy that you found a solution.


Make a handful of (minor) updates to README.md to enhance its flow and readability.

The CloudState README.md is just about the coolest guide that I've seen in a great long while; and I've pretty much seen them all.
The coherent narrative laid out in the README.md has done nothing less for me than give me a manifesto for building (and using) next generation serverless, the way it should be done. Kudos 👍
It has, in short order, nicely framed FaaS in the context it should be seen; a first (important) step toward stateful cloud computing, but a first step nonetheless 🌩
With that, and with utmost respect for the design captured by the author(s) of this terrific README.md, I suggest that we make a handful of (minor) updates to it so as to enhance its flow and readability even more than it currently stands.

All build checks on the related PR have passed.
At some point in time, will I get permissions to assign issues to myself? Thanks - In case the workflow we follow here is to have somebody assign issues to the relevant committer, I'm good with that workflow, too 👍

@akramtexas I think we need to set up a "committers" group or similar. Perhaps @jroper has some ideas?

@viktorklang Right, that sounds good. I'll defer to @jroper and you - Thanks, gentlemen 👍


Proposal: Allow function to satisfy interface while returning interface superset

Current behavior
Currently for a function to satisfy an interface, the signature of the function has to match the interface signature exactly.
In the case where the interface signature says the function should return an interface, the function can only return that interface, and not another interface which is a superset.
Meaning if you have the interfaces:
type ReaderOpener interface {
  Open() io.Reader
}
type ReadSeekerOpener interface {
  Open() io.ReadSeeker
}

Then the following type would satisfy ReadSeekerOpener, but not ReaderOpener.
type MyStruct struct {}
func (ms MyStruct) Open() io.ReadSeeker {}

Attempting to use MyStruct to satisfy ReaderOpener results in:
cannot use MyStruct literal (type MyStruct) as type ReaderOpener in assignment:
	MyStruct does not implement ReaderOpener (wrong type for Open method)
		have Open() io.ReadSeeker
		want Open() io.Reader

Proposal
The proposal is to allow functions returning an interface to satisfy the interface if the function returns an interface which is a superset of the one being satisfied.
Meaning that in the above code, MyStruct would satisfy both ReadSeekerOpener and ReaderOpener.
Now there is one particular about how "superset" is defined. It could either be 2 completely different interfaces with no inheritance, or one interface could be a composition containing the other.
Meaning:
type Reader interface {
  Read([]byte) (int, error)
}
type ReadSeeker {
  Read([]byte) (int, error)
  Seek(int64, int) (int64, error)
}

vs.
type Reader interface {
  Read([]byte) (int, error)
}
type ReadSeeker {
  Reader
  Seek(int64, int) (int64, error)
}

The key difference being that the latter ReadSeeker interface embeds the interface required in the ReaderOpener Open() signature.
While I think it might be nice if both would satisfy the proposed rule, if it matters, I think it would be reasonable to allow the latter to satisfy the proposal, but not the former.
Additional considerations
Explicit types
There's also the related case of an explicit type:
type ReaderOpener func() io.Reader

and whether a function which returns io.ReadSeeker should be assignable to a variable of this type.
I don't know that this needs to be addressed in this proposal, but I mention it as it seems related.
Function argument subsets
In theory the return superset logic should be able to be applied to function arguments, and whether interfaces can be subsets. Meaning whether a function with the signature func(io.Reader) should satisfy interface { func(io.ReadSeeker) }. In theory since the function only needs io.Reader, if it's given io.ReadSeeker, it should be able to operate normally.
So the consideration is that if return values are relaxed to allow interface supersets. Should function arguments be relaxed to allow interface subsets?

This seems related to this entry in the FAQ: https://golang.org/doc/faq#covariant_types.

Indeed it does. I was thinking that going from one interface to another might be a little different from that case of going from a concrete type to an interface, especially if the superset interface embeds the one being satisfied. But maybe they're the same.
The other thought behind why I was thinking the proposal makes sense is that go allows assignment to variables of an interface type as long as that interface is satisfied (regardless of whether it's another interface, or a concrete type).
open := func() io.ReadSeeker { ... }
var reader io.Reader = open()

So if reader was defined as an io.Reader, but we gave it a io.ReadSeeker, and this works, I'm not sure I see much difference.
Though this does seem pretty spot on to one part of that FAQ entry about

trying to express a type hierarchy through interfaces

Which if that's something just rejected on principal, I can understand that (go's opinionated nature is one of the best things about it). I think the proposal would make some things easier, but it's not like it can't be worked around.

The language doesn't support covariant returns in interface results, and that is an intentional decision as discussed in the FAQ.  Therefore, this proposal is a likely decline.  Leaving open for four weeks for final comments.

No further comments.  Closing.


namecheap

What provider would you like to see added to NPM?

https://www.namecheap.com/
Have you checked if a certbot plugin exists?
https://github.com/schubc/certbot_dns_namecheap

Is this a duplicate of #1151?

Indeed it is, sorry!


Fix PVI index labels

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8cf6e50) 72.93% compared to head (2761ff8) 72.93%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage   72.93%   72.93%
=======================================
  Files          17       17
  Lines         872      872
=======================================
  Hits          636      636
  Misses        236      236

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Gotta merge this. Need to find redemption today or die trying ...


Failed to fetch memo list, internal=no such column: visibility

Describe the bug
Logging into today on memos (using the dev tag, AKA latest main) causes memos not to show.
Steps to reproduce

Log in.
Notice no memos.
Top-right corner says "Failed to fetch memo list"

Screenshots or additional context
Logs is spammed with stuff like this:
2022-12-16T13:06:23Z method=GET uri=/api/memo/stats?creatorId=1 status=500 error=code=500, message=Failed to fetch memo list, internal=no such column: visibility
2022-12-16T13:06:23Z method=GET uri=/api/memo?rowStatus=NORMAL&limit=30 status=500 error=code=500, message=Failed to fetch memo list, internal=no such column: visibility
2022-12-16T13:06:23Z method=GET uri=/api/memo/stats?creatorId=1 status=500 error=code=500, message=Failed to fetch memo list, internal=no such column: visibility

Empty page after login, while I know I have memos set up.

try to delete the .air/ and re-run

Hello there,
Where would I find that? The only file that docker made regarding memos on my filesystem is memos_prod.db in the volume I assigned it to (per docker-compose's /var/opt/memos).

Hello, see this about the development of the memos.  https://github.com/usememos/memos/blob/main/docs/development.md.
Actually I don't recommend to use the dev image  if you are not familier enough  with docker.

Hello, see this about the development of the memos. https://github.com/usememos/memos/blob/main/docs/development.md.
Actually I don't recommend to use the dev image if you are not familier enough with docker.

Hello there,
Fixed the issue myself by running the updated SQL on the db. However I should mention that there's an error in the following file:
https://github.com/usememos/memos/blob/main/store/db/migration/prod/0.9/00__resource_visibility.sql
It currently says:
ALTER TABLE resource ADD COLUMN visibility TEXT NOT NULL CHECK (visibility IN ('PUBLIC', 'PROTECTED' 'PRIVATE')) DEFAULT 'PRIVATE';

but it should be:
ALTER TABLE resource ADD COLUMN visibility TEXT NOT NULL CHECK (visibility IN ('PUBLIC', 'PROTECTED', 'PRIVATE')) DEFAULT 'PRIVATE';

Otherwise it'll error because 'PRIVATE' broke the IN operator value list.
Thanks for the help though.


Transactions table - allow open in new tab

https://sloth-test.ucdavis.edu/aggie-enterprise/Transactions
Clicking on a row takes you to that row, which is nice, but ctrl+click or right-click -> open in a new tab should work too.  Not sure the best way to do that, but my guess is each column needs the content wrapped in an anchor tag maybe?  That might break searching though so you'd have to see what the best option is.
But I think it's going to be useful to compare 2 or more txns and there isn't a good way to do that if you can't open in new tab

https://github.com/ucdavis/Sloth/commit/bfdd51fa852a92058a6fd3efb568e3a558f16a85


Lower object efficiency

Compiling with -d flag adds the relevant branches to the output ntuple and makes efficiency histograms and plots out of this ntuple. They won't be found in the summary page (as of now), and hence need to be accessed manually.
Examples:-
http://uaf-10.t2.ucsd.edu/~bsathian/temp_e297fbD-PU200/mtv/var/T5_lower_base_0_0_eff_pt.pdf
http://uaf-10.t2.ucsd.edu/~bsathian/temp_e297fbD-PU200/mtv/var/pT5_lower_base_0_0_eff_pt.pdf
http://uaf-10.t2.ucsd.edu/~bsathian/temp_e297fbD-PU200/mtv/var/T5_lower_duplrate_pt.pdf
http://uaf-10.t2.ucsd.edu/~bsathian/temp_e297fbD-PU200/mtv/var/pT5_lower_fakerate_pt.pdf

NOTE : The reason for the high T5 duplicate rate is that T5s before duplicate cleaning are filled in here. This decision was taken quite recently (in light of T5 studies) - (old cod ref : https://github.com/bsathian/TrackLooper-1/blame/T5_bugFixes/code/core/write_sdl_ntuple.cc#L1024). Hence, a comparison with the "ORIGINAL" might not be possible.

efficiency/bin/createEffNumDenHists binary file should not be included in PR

I do not like whatever this n_accepted_simtrk is doing.
this kind of prolific copy-paste all over the place is what's gonna cause a giant headache in the future.
Can you explain to me what this is?

Don't change the Makefile and propagate another flag to efficiency/Makefile but rather change the performance.cc to accept the LSTNtuple.root as is, and decide based on what branches are available.

efficiency/python/make_classfiles.py.bak should not be included.

Apart from the comments by Philip, with which I agree (especially the one about the n_accepted_simtrk variable - I didn't understand it either when I checked the PR), I think we should clean out the commented lines, e.g. in the Makefile or the lst_plot_performance.py. They turn out to be confusing in the long run, if the reason why they are needed is not stated.

Updated with Philip's stuff


Parse tag markup once per instance

This change ensures that if there is a single instance of {% avatar foo %} which may be rendered multiple times, the tag_markup or text parameter value isn't parsed by Liquid for each render.

Thanks for the approval, Ben. But since the tests are failing, I'll have to think of an alternative..

@ashmaroli Thanks for all the great PRs this week. Any interest in maintaining this plugin, either in your own namespace or in Jekyll's?

Any interest in maintaining this plugin, either in your own namespace or in Jekyll's?

@benbalter I've pinged @mattr- regarding his opinion on transferring this plugin into the Jekyll Org.
Will get back to you once I get a response from him.

@benbalter Both Parker and Matt are of the opinion that it would be best if Jekyll Org adopts this project rather than have it transferred into my namespace. So, they may approach you for the transfer in the near future.


Fix/no sync

Fix sync

Codecov Report

Merging #648 (719940d) into development (df991a5) will decrease coverage by 0.03%.
The diff coverage is 33.33%.

@@               Coverage Diff               @@
##           development     #648      +/-   ##
===============================================
- Coverage        41.92%   41.88%   -0.04%
===============================================
  Files               35       35
  Lines             2519     2390     -129
===============================================
- Hits              1056     1001      -55
+ Misses            1463     1389      -74

Flag
Coverage Δ

unittests
41.88% <33.33%> (-0.04%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

cookietemple/lint/template_linter.py
49.77% <ø> (+6.20%)
:arrow_up:

cookietemple/sync/sync.py
15.69% <0.00%> (-0.17%)
:arrow_down:

cookietemple/bump_version/bump_version.py
67.50% <83.33%> (+5.73%)
:arrow_up:

cookietemple/__init__.py
100.00% <100.00%> (ø)

cookietemple/custom_cli/questionary.py
21.42% <0.00%> (-26.20%)
:arrow_down:

cookietemple/cookietemple_cli.py
50.31% <0.00%> (+1.24%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df991a5...719940d. Read the comment docs.

    def create_dot_cookietemple(self, template_version: str):
        """
        Overrides the version with the version of the template.
        Dumps the configuration for the template generation into a .cookietemple yaml file.
        :param template_version: Version of the specific template
        """
        log.debug('Creating .cookietemple.yml file.')
        self.creator_ctx.template_version = f'{template_version} # <<COOKIETEMPLE_NO_BUMP>>'
        self.creator_ctx.cookietemple_version = f'{cookietemple.__version__} # <<COOKIETEMPLE_NO_BUMP>>'
        # Python does not allow for hyphens (module imports etc) -> remove them
        no_hyphen = self.creator_ctx.project_slug.replace('-', '_')
        with open(f'{self.creator_ctx.project_slug if self.creator_ctx.language != "python" else no_hyphen}/.cookietemple.yml', 'w') as f:
            yaml = YAML()
            struct_to_dict = self.creator_ctx_to_dict()
            yaml.dump(struct_to_dict, f)

This is how we create the .cookietemple.yml file.
And this is an example of cookiecutter.version used: https://github.com/cookiejar/cookietemple/blob/fix/no_sync/cookietemple/create/templates/cli/cli_python/{{ cookiecutter.project_slug_no_hyphen }}/cookietemple.cfg#L2
{{ cookiecutter.version  }} is the template version here and not the version of CT!

@Zethson ready to merge?


Allow namespaces

I added a new option (--namespace) which allows to add a prefix to each constant.
This fix an issue when you have same identifier (XIB name, storyboard name...) than classname, which is typical when you work with XIB files (whatever.xib is the view for whatever.h which defines whatever class).

I'd rebase this when https://github.com/paulsamuels/SBConstants/pull/44 will be merged


希望尽快支持 glm-4-9b-chat，谢谢！

希望尽快支持 glm-4-9b-chat，谢谢！

Supported already on main branch.

So how to boot the model in web interface, I do not find the model

Node LLM run failed: [xinference] Error: An error occurred during streaming
使用GLM-4-chat报错


Fix console errors from auto-fill

cc @rushatgabhane
Details
There were some console errors on staging related to https://github.com/Expensify/App/pull/8059 that happen when using Google Chrome's autofill functionality. This should patch those errors.
Fixed Issues
$ https://github.com/Expensify/App/pull/8059
Tests

Verify that keyboard shortcuts continue to work as expected. (CMD+K, CMD+I, CMD+SHIFT+K, ESC, etc...)
Use Google Chrome's autofill on a form in NewDot. Make sure that no console error appears.

[ ] Verify that no errors appear in the JS console

PR Review Checklist
Contributor (PR Author) Checklist

[x] I verified the PR has a small number of commits behind main
[ ] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I clearly indicated the environment tests should be run in (Staging vs Production)

[x] I wrote testing steps that cover success & fail scenarios (if applicable)
[ ] I included screenshots or videos for tests on all platforms
[ ] I ran the tests & verified they passed on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[x] MacOS / Chrome
[ ] MacOS / Desktop

[x] I verified there are no console errors related to changes in this PR
[x] I followed proper code patterns (see Reviewing the code)

[x] I added comments when the code was not self explanatory
[x] I put all copy / text shown in the product in all src/languages/* files (if applicable)
[x] I followed proper naming convention for platform-specific files (if applicable)
[x] I followed style guidelines (in Styling.md) for all style edits I made
[x] I followed the JSDocs style guidelines (in STYLE.md)

[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I corroborated the UI performance was not affected (the performance is the same than main branch)
[x] If I created a new component I verified that a similar component doesn't exist in the codebase

PR Reviewer Checklist

[ ] I verified the PR has a small number of commits behind main
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the testing environment is mentioned in the test steps

[ ] I verified testing steps cover success & fail scenarios (if applicable)
[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors related to changes in this PR
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified comments were added when the code was not self explanatory
[ ] I verified any copy / text shown in the product was added in all src/languages/* files (if applicable)
[ ] I verified proper naming convention for platform-specific files was followed (if applicable)
[ ] I verified style guidelines were followed
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components are not impacted by changes in this PR (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I verified the UI performance was not affected (the performance is the same than main branch)
[ ] If a new component is created I verified that a similar component doesn't exist in the codebase

QA Steps

Open the JS console.
Use Google Chrome's autofill functionality on an input in NewDot.
Verify that no console errors appear.

[ ] Verify that no errors appear in the JS console

I didn't attach screenshots because I think I disabled Chrome's autofill in preference of 1Password. @rushatgabhane can you please help out with the testing on this? Credit should go to you anyways since this PR was your suggestion.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @yuwenmemon in version: 1.1.43-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @roryabraham in version: 1.1.43-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


add test instructions

closes #57
The new documentation on test creation can be found here

Codecov Report

Merging #125 (7e5be5e) into main (ecc2f7a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #125   +/-   ##
=======================================
  Coverage   81.22%   81.22%
=======================================
  Files         100      100
  Lines        5257     5257
=======================================
  Hits         4270     4270
  Misses        987      987

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Why remove DHT & NAT support?

DHT/NAT doesn't work well? I think p2p is really useful.

@smcduck It's temporarily removed by security reasons.

How does the peer discovery work without DHT?


pod-to-internet-connectivity installation check sometimes failed in CI

Describe the bug

I saw the failure at least twice:
https://github.com/antrea-io/antrea/actions/runs/9461915489/job/26063912880?pr=6427
[kind-kind] -------------------------------------------------------------------------------------------
[kind-kind] Running test: pod-to-internet-connectivity
[kind-kind] -------------------------------------------------------------------------------------------
[kind-kind] Validating connectivity from Pod antrea-test-1m2pj/test-client-84c4bb5558-wswd6 to the world (google.com)...
[kind-kind] /agnhost command '/agnhost connect google.com:80 --timeout=3s' failed: command terminated with exit code 1
[kind-kind] /agnhost stderr: TIMEOUT
[kind-kind] Test pod-to-internet-connectivity failed: Pod antrea-test-1m2pj/test-client-84c4bb5558-wswd6 was not able to connect to google.com: command terminated with exit code 1

agnhost connect only tries to establish TCP connection, not sure why 3s is not enough.
If it keeps failing, maybe we should consider increasing the timeout or switch to another address, like some github service.

For what it's worth, I think I saw it failed even back when we had the timeout set to 5s instead of 3s.
We know it's not a DNS issue, as the error message would be different.
It could be some firewall on the Google side. I agree with you, api.github.com may be a good option.

Wrote a simple bash script and executed in a local agnhost pod.
#!/bin/bash
timeout_duration=3s
iterations=50

usage() {
    echo "Usage: $0 [--timeout <seconds>] [--iterations <count>]"
    echo "  --timeout <seconds>   Specify the timeout duration in seconds for each command execution"
    echo "  --iterations <count>  Specify the number of times to execute the command (default: 50)"
    exit 1
}

while [[ $# -gt 0 ]]; do
    case $1 in
        --timeout)
            timeout_duration=$2
            shift 2
            ;;
        --iterations)
            iterations=$2
            shift 2
            ;;
        *)
            usage
            ;;
    esac
done

google_failure_count=0
github_failure_count=0

for ((i=1; i<=iterations; i++))
do
    /agnhost connect google.com:80 --timeout=$timeout_duration
    if [ $? -ne 0 ]; then
        ((google_failure_count++))
        echo "google.com t/o at try $i"
    fi

    /agnhost connect api.github.com:80 --timeout=$timeout_duration
    if [ $? -ne 0 ]; then
         ((github_failure_count++))
         echo "api.github.com t/o at try $i"
     fi
done

echo "Number of google.com failures: $google_failure_count"
echo "Number of api.github.com failures: $github_failure_count"

Some outputs:
bash-5.0# ./test.sh --timeout 3s --iterations 25
google.com t/o at try 1
TIMEOUT
Number of google.com failures: 1
Number of api.github.com failures: 0

bash-5.0# ./test.sh --timeout 2s --iterations 25
Number of google.com failures: 0
Number of api.github.com failures: 0

bash-5.0# ./test.sh --timeout 1s --iterations 50
TIMEOUT
google.com t/o at try 1
TIMEOUT
google.com t/o at try 37
Number of google.com failures: 2
Number of api.github.com failures: 0

bash-5.0# ./test.sh --timeout 1s --iterations 200
Number of google.com failures: 0
Number of api.github.com failures: 0

bash-5.0# ./test.sh --timeout 1s --iterations 500
TIMEOUT
api.github.com t/o at try 126
Number of google.com failures: 0
Number of api.github.com failures: 1

bash-5.0# ./test.sh --timeout 2s --iterations 1000
TIMEOUT
google.com t/o at try 1
Number of google.com failures: 1
Number of api.github.com failures: 0

bash-5.0# ./test.sh --timeout 1s --iterations 1000
TIMEOUT
google.com t/o at try 1
TIMEOUT
api.github.com t/o at try 533
TIMEOUT
google.com t/o at try 534
TIMEOUT
api.github.com t/o at try 534
TIMEOUT
api.github.com t/o at try 739
TIMEOUT
google.com t/o at try 923
TIMEOUT
api.github.com t/o at try 923
TIMEOUT
api.github.com t/o at try 961
Number of google.com failures: 3
Number of api.github.com failures: 5

In general api.github.com does seem to be more stable compared to google.com except when the timeout is set to be very small. However what I observed is clearly the 1st attempt to connect to google.com has a really high chance of failure, which imo is most likely DNS related. We could switch to api.github.com for this test, but adding a second try for agnhost connect would also likely to fix this issue

We could switch to api.github.com for this test, but adding a second try for agnhost connect would also likely to fix this issue

I think we should use the more stable target as the purpose of the check is to detect connectivity issues, adding retries may hide some intermittent issues.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-yml-archive-non-versioning-archive/pull/500 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-yml-archive-non-versioning-archive.git

Docs Build status updates of commit 5f7a7ba:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/TOC.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-3.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-3.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Make movingSum available for use

My PR from yesterday (#1808) doesn't work, I'm afraid. The missing piece is here.

Yes, looks like it was overlooked. Thanks!

Dangit, I was looking specifically for that and missed it. Thanks for catching it in hindsight.


Dark Theme

Its would be nice to have dark UI theme.

Proper theming engine should be implemented before we add dark theme. And that probably depends on settings page.


Make the tshout guide easier to follow

Description
Hi team,
I’ve been looking at the Kyverno Troubleshooting Guide, and while it’s really helpful, I feel it could be easier to use. It’s a bit hard to find what yo need quickly because everything is in one long section.
Here are a few ideas that might help:
break it up:
It would be great if the guide was split into sections like installation issues, policy problems, performance issues, and specific problems with clusters like EKS or AKS ...
add examples:
Some parts, like “Policies are not applied,” could use more examples. Showing the exact commands to run and what the output should look like would make it easier to follow.
add a table of content:
A little table at the top with links to the different sections would make it much quicker to jump to the part you need.
more details for common problems:
Some areas, like webhooks not working or AdmissionReview payloads not matching, could use more step-by-step instructions.
make solutions simpler:
It’d help if each solution started with the symptom, then explained what’s causing it, and finally how to fix it. A short tip on how to avoid the problem would also be great.
I think these small changes would make the guide way more user-friendly, especially for people who are new to Kyverno or troubleshooting Kubernetes.
Thanks for all the great work you’re doing!
Slack discussion
No response

HI @lhajouji - thanks for the suggestions, and PRs are welcome😃
We could start by adding a table of content for quick navigation and filling out details as follows.

Hello @realshuting ,


OpenComputers support | enhancement

Opencomputers support would be nice for checking wether a launchpad is empty or not, setting coördinates, getting current status (ready to launch/not enough energy) and of course launching missiles. It would also be nice for radar stations, not sure if these were going to be implemented in ICBM though.

It has been done

\o/


[FEATURE] Payoneer Payment Gateway

🚀 Feature Request
Is your proposal related to a problem?
Please add Payoneer Payment Gateway, it's required for us and only option that works.
(Write your answer here.)
Describe the solution you'd like
Payoneer Payment Gateway like others in CP.gg i.e PayPal and Stripe.

On 5 👍🏼 ill add it :)

On 5 👍🏼 ill add it :)

done now add it

I'm coding it right now! So stay tuned!


chore: update company name in LICENSE file (SDKCF-3582)

Description
All other files are up-to-date
Links
SDKCF-3582
Checklist

[X] I have read the contributing guidelines.
[ ] I wrote/updated tests for new/changed code
[X] I removed all sensitive data before every commit, including API endpoints and keys
[ ] I ran fastlane ci without errors

Codecov Report

Merging #5 (e98b52d) into main (c2435d0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage   75.96%   75.96%
=======================================
  Files          12       12
  Lines         258      258
=======================================
  Hits          196      196
  Misses         62       62

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2435d0...e98b52d. Read the comment docs.


Deleting a node in a parent pipeline causes PipelineStreamProcessor Exceptions in child

The scenario is:

Root Pipeline with multiple filter nodes:

parser
readRecordCountFilter
splitFilter
workFilter1
workFilter2
schema Filter
...

Child Pipeline inherits from Root, adds an extra filter (extraFilter) between workFilter1 and workFilter2
Root Pipeline is edited to remove workFilter2

This leads to the Child Pipeline generating errors like:
parser       parser - ContentHandlerProxy.open(): no underlying handler provided`

Then we can't edit the Child Pipeline structure because the UI pops up an Error:
Attempt to link from "extraFilter" to "workFilter2" but "workFilter2" is unknown`
...PipeineFactoryException`

and the nodes do not appear.

Duplicate of #420


Docker build issue

Please make sure that this is a build/installation issue and also refer to the troubleshooting documentation before raising any issues.
System information (Please provide as much relevant information as possible)

OS Platform and Distribution (e.g. Linux Ubuntu 16.04, Android 11, iOS 14.4): Xavier Ubuntu 18.04
Compiler version (e.g. gcc/g++ 8 /Apple clang version 12.0.0): Docker
Programming Language and version ( e.g. C++ 14, Python 3.6, Java ): NA
Installed using virtualenv? pip? Conda? (if python): Docker
MediaPipe version: v0.8.11
Bazel version: 5.2.0

Describe the problem:
Dockerfile is to be corrected.
Provide the exact sequence of commands / steps that you executed before running into the problem:
$ git clone -–depth 1 https://github.com/google/mediapipe.git
$ cd mediapipe
$ docker build --tag=mediapipe .
Complete Logs:
Include Complete Log information or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached:
Step 17/18 : RUN mkdir /bazel &&     wget --no-check-certificate -O /bazel/installer.sh "https://github.com/bazelbuild/bazel/releases/download/${BAZEL_VERSION}/bazel-${BAZEL_VERSION}-installer-linux-x86_64.sh" &&     wget --no-check-certificate -O  /bazel/LICENSE.txt "https://raw.githubusercontent.com/bazelbuild/bazel/master/LICENSE" &&     chmod +x /bazel/installer.sh &&     /bazel/installer.sh  &&     rm -f /bazel/installer.sh
---> Running in 9aa582388107
--2023-01-31 10:01:08--  https://raw.githubusercontent.com/bazelbuild/bazel/master/LICENSE
Resolving raw.githubusercontent.com (raw.githubusercontent.com)... <IP_ADDRESS>, 2405:200:1607:2820:41::36
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|<IP_ADDRESS>|:443... failed: Connection timed out.
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|2405:200:1607:2820:41::36|:443... failed: Cannot assign requested address.
Retrying.
--2023-01-31 10:03:20--  (try: 2)  https://raw.githubusercontent.com/bazelbuild/bazel/master/LICENSE
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|<IP_ADDRESS>|:443...
failed: Connection timed out.
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|2405:200:1607:2820:41::36|:443... failed: Cannot assign requested address.
Retrying.
--2023-01-31 10:05:32--  (try: 3)  https://raw.githubusercontent.com/bazelbuild/bazel/master/LICENSE
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|<IP_ADDRESS>|:443... failed: Connection timed out.
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|2405:200:1607:2820:41::36|:443... failed: Cannot assign requested address.
Retrying.
--2023-01-31 10:07:46--  (try: 4)  https://raw.githubusercontent.com/bazelbuild/bazel/master/LICENSE
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|<IP_ADDRESS>|:443... failed: Connection timed out.
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|2405:200:1607:2820:41::36|:443... failed: Cannot assign requested address.
Retrying.

Hello @PrinceP
We are not able to reproduce the issue at our end on Ubuntu 18.04. The file is downloaded well. Please refer the screenshot attached.

But it does seem like you are on a network which is not allowing access to the bazel license file and that is why the network is throwing connection timed out. This can happen if you are on a closed network like in an organization.
Can you please try to visit the link https://raw.githubusercontent.com/bazelbuild/bazel/master/LICENSE via browser first?

Not able to access -> https://raw.githubusercontent.com/bazelbuild/bazel/master/LICENSE
The network is working fine. No VPN is used.

@PrinceP Since you are not able to access it from the browser as well and this file has public visibility, this is definitely a network/firewall issue. Please contact your network administrator for permission to access this file.


Debugging Segmentation Faults in Codon

In C:
#ifdef __cplusplus
extern "C" {
#endif

__attribute__((visibility("default"))) std::array<double, 4> foo() {
    std::array<double, 4> bar;
    ....
    return bar;
}

#ifdef __cplusplus
}
#endif

In Codon:
LIBPATH = "foo.so"
from C import LIBPATH.foo() -> Ptr[float]

def run():
    while True:
        bar = foo()

In the above scenarios, when running the Codon script, the bar value is initially set to null or a dummy value. However, subsequent iterations seem to work fine. I'm not sure what the problem is at this point.
Additionally, printing the bar variable during the first iteration results in a segmentation fault. It appears this issue is related to the garbage collector (GC) in Codon. This information might be useful for debugging.
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff76ec712 in GC_find_limit_with_bound () from /home/user/.codon/lib/codon/libcodonrt.so
(gdb) bt
#0  0x00007ffff76ec712 in GC_find_limit_with_bound () from /home/user/.codon/lib/codon/libcodonrt.so
#1  0x00007ffff76ec530 in GC_init_linux_data_start () from /home/user/.codon/lib/codon/libcodonrt.so
#2  0x00007ffff76ea71d in GC_init () from /home/user/.codon/lib/codon/libcodonrt.so
#3  0x00007ffff76a7638 in seq_init () from /home/user/.codon/lib/codon/libcodonrt.so
#4  0x00007ffff7fb7548 in main[unclash] () from foo.so
#5  0x00007ffff7fc947e in call_init (l=<optimized out>, argc=argc@entry=1, argv=argv@entry=0x7fffffffd808, env=env@entry=0x7fffffffd818) at ./elf/dl-init.c:70
#6  0x00007ffff7fc9568 in call_init (env=0x7fffffffd818, argv=0x7fffffffd808, argc=1, l=<optimized out>) at ./elf/dl-init.c:33
#7  _dl_init (main_map=0x7ffff7ffe2e0, argc=1, argv=0x7fffffffd808, env=0x7fffffffd818) at ./elf/dl-init.c:117
#8  0x00007ffff7fe32ca in _dl_start_user () from /lib64/ld-linux-x86-64.so.2
#9  0x0000000000000001 in ?? ()
#10 0x00007fffffffdc5d in ?? ()
#11 0x0000000000000000 in ?? ()

Any comments would be welcomed.

Hi @gyuro -- there are a couple potential issues here:

bar will be destroyed when foo() returns due to C++'s RAII
Not sure if there will also be an ABI issue here from returning std::array; it's possible that this isn't ABI compatible with just returning a pointer

Probably best to return a raw pointer (e.g. bar.data()) and copy it on the Codon side. Does it work if you do this?

IMO, it's more effective to pass the arguments that need to be returned.
Thanks for your feedback!


FRAME: Add new poll hook + various other improvements to pallet hooks

complementing https://github.com/paritytech/substrate/pull/14275
related #13690

[x] Improve docs for all hooks
[ ] Tests
[ ] closes https://github.com/paritytech/substrate/issues/12135
[ ] TODOs

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2925898

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2925899

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3065528

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3065529


Bugfix in gradient code for tf.image.resize_nearest_neighbor

This PR prevents errors when computing gradients that involve tf.image.resize_nearest_neighbor and tensors with partially defined shapes.

Can one of the admins verify this patch?

Jenkins, test this please.


parameter_pa: 1.0.2-0 in 'jade/distribution.yaml' [bloom]

Increasing version of package(s) in repository parameter_pa to 1.0.2-0:

upstream repository: https://github.com/peterweissig/ros_parameter.git
release repository: https://github.com/peterweissig/ros_parameter-release.git
distro file: jade/distribution.yaml
bloom version: 0.5.26
previous version for package: null

parameter_pa
* updated year within license
* updated version number
* added install target to CMakeLists.txt
* Contributors: Peter Weissig

Note that this will likely be the last release into jade. https://discourse.ros.org/t/jade-eol-announcement/2240


Version 0.15.2 - Unable to upload files to server when running node with forever v0.15.2

Was previously using version 0.15.1 to run a Node.js webservice without issue.
As soon as I updated to version 0.15.2 of forever.js, we were unable to upload files to server until we reverted back to 0.15.1

Yes, same here. Script works fine without forever -w -c
Just runforever start myapp.js
it works fine


Regen

Part of https://github.com/gtk-rs/lgpl-docs/pull/48
cc @GuillaumeGomez, @sdroege

:+1:

@sdroege You can merge now. :p

It's still marked as WIP

It still need right gir-files

PR updated, must pass CI

CI passed


Remove environment variable capture in build-logic test

Because it may break configuration cache.

@bot-gradle test sc

OK, I've already triggered the following builds for you:

SanityCheck build

@bot-gradle test and merge

OK, I've already triggered a build for you.


Use python libtiff 0.4.1.

Also, use libtiff 4.0.8.

Yes -- large_image now uses pylibtiff 0.4.1, and this removes the overrides from what is specified there.


Add setter for messaging to allow configuring response timeout via st…

…age.

Not sure how I missed this, using reflection to configure it in the meanwhile :)


Improve both READMEs

Add a word of caution about the scope of the project
Put more directly how to try the lib in the main README
Add a section on why one wants to use Nickel for Nix

In case this escaped your radar @aspiwack , a gentle ping :slightly_smiling_face:


Issue1071/yapf

Formatting of Python code using yapf
cd $RDBASE
yapf --in-place --recursive --style $RDBASE/setup.cfg .

Any chance of a
make format
Target?  Or is that a silly idea?  One could imagine a Travis target that fails if code isn't formatted properly.

The yapf Python code comes with an API that allows to run the formatting over a file. This formatter returns a tuple (reformatted_code, encoding, changed). The changed boolean indicates if the formatter would make a change or not. We could therefore think about adding a script that could provide the function to format a given file or to check a file (or the full code for testing).
I'm not sure if requesting formatting is a good idea. A warning at least could be useful. I had one case where the formatting failed (Contrib/mmpa/indexer.py) due to the complex if structure (adding a few spaces after the elif statements fixed that problem), and another case where the file, I think, had latin1 encoding (that was fixed after I saved the file from eclipse).
So supporting but not enforcing, that would be my preference.

It's applied.
Thanks Peter!


Async onLeave and quiet push

Hi Guys,
I'm trying to implement asynchronous onLeave. The code looks like:
componentDidMount () {
        let router = this.context.router;
        router.setRouteLeaveHook(this.props.route, nextLocation => {
            this.onLeave().then(() => {
                router.push(nextLocation);
            }).catch(() => {
                router.push(nextLocation);
            });

            return false;
        });
}

The problem here is that router.push isn't quiet (it throws events) and this leave hook is calling recursively. So my question is: does react-router have quiet method for changing location? I read docs but I didn't see such ability.
Thanks!

Track the status of the transition yourself in component state.

I can't do that! Transition could be make from very different places.

Why are you constantly abandoning me instead of helping me to find out solution?

To my mind this is not the support which users expect from facebook...

Track the status of the transition yourself in component state.

And by the way I can't track transition made by browser (back button, hot key back button).

To my mind this is not the support which users expect from facebook...

Woah now...
A) This isn't Facebook. This is React Community. We're a collection of volunteer open source developers. There is no SLA here or requirement to support you.

This isn't a support channel. This is a bug tracker. As it says in the README, "For questions and support, please visit our channel on Reactiflux or Stack Overflow."

iii) This is a duplicate issue of #3406. Please don't open duplicates.

hey @deser, I hope these comments are helpful.
https://github.com/reactjs/react-router/issues/3406#issuecomment-216326975


Add tabler-icons guide to README and docs

(I'm using the https://typst.app/ web app - awesome package.)
The README.md example image and code don't match, until one finds a copy of tabler-icons.ttf and installs / uploads it.

Can codly bundle the TTF or WOFF2 fonts so that the example works out of the box?
It would be great to include a guide on how to use tabler-icons. Something like:

Search for the desired icon on https://tabler.io/icons
Click on the icon and note the hex, e.g. fa53 for brand-rust.
Change fa53 to your icon's hex in icon: text(font: "tabler-icons", "\u{fa53}"),
Download tabler-icons.ttf (perhaps from jsdelivr) and put it into Typst, more info here

Thanks.

As far as I know, it's not possible to currently bundle fonts so no. I might rework the example to just not include that. I will include a small section in the README on how to get them. Thanks


fix(organizations): set default status conditions

Description
In order to remove Organization resource we need to allow the lifecycle.Reconcile to set the Delete condition to successfully remove the finalizers.
What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[x] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Added tests?

[ ] 👍 yes
[ ] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help
[ ] Separate ticket for tests # (issue/pr)

Added to documentation?

[ ] 📜 README.md
[ ] 🤝 Documentation pages updated
[ ] 🙅 no documentation needed
[ ] (if applicable) generated OpenAPI docs for CRD changes

Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

test fail for cluster status_test.go which will be fixed in #683


Removes the @Inject annotations in brave-jaxrs2

The @Inject annotations create instantiation errors in CDI based environments and don’t seem to serve any purpose.
See discussion on #251

@adriancole please put this on hold. It requires further investigation I think.

https://github.com/openzipkin/brave/issues/191

The current test fails with
java.lang.NoSuchMethodException: Could not find a suitable constructor in com.github.kristofa.brave.jaxrs2.BraveContainerResponseFilter class.
	at org.glassfish.jersey.internal.inject.JerseyClassAnalyzer.getConstructor(JerseyClassAnalyzer.java:189)
	at org.jvnet.hk2.internal.Utilities.getConstructor(Utilities.java:186)
	at org.jvnet.hk2.internal.ClazzCreator.initialize(ClazzCreator.java:129)
	at org.jvnet.hk2.internal.ClazzCreator.initialize(ClazzCreator.java:182)
	at org.jvnet.hk2.internal.SystemDescriptor.internalReify(SystemDescriptor.java:713)
	at org.jvnet.hk2.internal.SystemDescriptor.reify(SystemDescriptor.java:668)
	at org.jvnet.hk2.internal.ServiceLocatorImpl.reifyDescriptor(ServiceLocatorImpl.java:418)
	at org.jvnet.hk2.internal.ServiceLocatorImpl.narrow(ServiceLocatorImpl.java:2120)
	at org.jvnet.hk2.internal.ServiceLocatorImpl.access$900(ServiceLocatorImpl.java:119)
	at org.jvnet.hk2.internal.ServiceLocatorImpl$10.compute(ServiceLocatorImpl.java:1260)
	at org.jvnet.hk2.internal.ServiceLocatorImpl$10.compute(ServiceLocatorImpl.java:1255)

@adriancole What do we do about the test failure?

looks like the failures are legit.

I'll have a look at these the next few days.

I've come up with an alternative way to solve the CDI related problems by excluding the brave packages and since I am not sure how to address the jersey requirements I've decided to discard this PR.

Thanks for the reply-back. if you have a snippet of how the exclude works,
please paste!


examples: add registry address to all container images

Since not all container runtimes use docker as the default image
registry it is necessary to specify the address for the correct
registry.
Signed-off-by: André Martins<EMAIL_ADDRESS>add container image registry for all examples and cilium yaml spec file.

This change is

test-me-please

test-me-please

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

test-me-please

I'd like to ensure that this does not break any of the files changed here, as we do not test all of these examples in CI. I.e., applying all of the files to K8s and validating that the containers can be pulled / the pods go into running state, for instance.

I'd like to ensure that this does not break any of the files changed here, as we do not test all of these examples in CI. I.e., applying all of the files to K8s and validating that the containers can be pulled / the pods go into running state, for instance.

We can test all docs before releasing the 1.1.
Without this changes the examples are currently broken for container runtimes that are not docker


When deleting final and only item, impossible to add more items

I am using Cocoon for the first time, and I'm finding that if you only have one item, and you remove that item, then adding another item is no longer possible.
I could add a conditional such that the "Remove" button next to an item is only rendered if there is only one item initially, but that wouldn't work if you add a new item (because at that point then you need to show the button next to the first item that was already there) -- in other words, the visibility of that button needs to be dynamic.
I didn't check through the code to see if this already happens in some form, or why you can't add another item to begin with, so I apologize -- I can do that later if need be. I was just wondering if you or anyone else has noticed this behavior before, or if there's something I need to do to make this happen (or, if this is even an issue). Thanks!

Nope, this behaviour should just work, so I am guessing you are doing something wrong. You are giving very little information for me to help you in any way.
My first guess (since you do not describe the behaviour in great detail): if after removing the last item, there is no "add" button anymore, I am guessing you are placing the link_to_add_association in the wrong place, and that could mean you are not used to reading haml views, so check out the erb examples
Please show me the view code, so I can help you better.

Hey, sorry for the lack of information. I didn't mean to imply that the gem was at fault -- I didn't have proper time to look into it, and simply needed a quick clarification.
As it turns out, you're correct, I was doing something wrong. I have a table where the user can add or delete rows. I'm using Cocoon like this:
<%= form_for :group do |f| %>

    <% group.group_items.each do |group_item|

        ... form fields go here ...
        <%= link_to_remove_association "Remove", f %>

    <% end %>

  <%= link_to_add_association(
    "Add group item",
    f,
    :group_items,
    partial: "group_item",
    "data-association-insertion-node" => ".group-items tr:last",
    "data-association-insertion-method" => "after",
  ) %>
<% end %>

You can probably notice the problem -- if you remove all rows, then .group-items tr:last won't match anything anymore, and thus it doesn't know where to insert a new row.
I wonder if it'd be worth it to print some kind of warning to the browser console if clicking on the "Add" link can't find an element to put the new item in? Or, would you be opposed to me adding a how-to to the wiki on using Cocoon to make a table the right way, to prevent someone else from running into this?


fix(ui): Update ConfigMgmt for async compliance scans

Description
Updates the Scan button in Config Management that was missed (doh) when updating the Compliance page to async scans. I chose to add the progress indicator to the widget instead of the top of the page due to that widget being the only context on this page that was dependent on the compliance scan.
This also fixes the tests to await the correct requests and assert on the presense/absence of the scan progress indicator where necessary.

Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Here I tell how I validated my change
e2e CI
Triggering the compliance scan via ConfigMgmt will display the in progress indicator within the widget on that page. The state will sync between this page and Compliance 1.0 if the user visits either before the scan is complete.
Triggering a scan via ConfigMgmt does not disable the button, allowing the user to restart an in-progress scan. This functionality is the same as the scan button on the Compliance 1.0 page.
https://github.com/stackrox/stackrox/assets/1292638/1a61c5ed-236e-4df0-a995-583151668f22

/test gke-ui-e2e-tests
/test ocp-4-11-merge-ui-e2e-tests

/test ocp-4-11-ui-e2e-tests

I ran the individual e2e tests locally and had them pass, and am running the full suite locally now.
If we can get clean e2e runs in CI on this PR, anyone who approves it can feel free to merge to get rid of quite a bit of red prow lines.

Both ocp-ui-e2e failures here are the other CI issue, unrelated to this fix.


disabled text field placeholder text is not shown

How to keep the placeholder text in disabled vaadin-text-field?

@sudipta1411 you can achieve this by creating theme module and overriding corresponding styles like this:
https://jsbin.com/taqinot/edit?html,output
Read more about theme modules in the ThemableMixin wiki, hope that helps.
I'm closing this as a non-issue. In the future please ask questions like this in our Slack channel


prevent uploading older version of file

Hello,
is it possible to add a feature to prevent uploading an older version of a file to the server?

Same for the opposite: Prevent or warn downloading an older version of file. We need file transfer rules here.


[SPARK-7966][GraphX] Implementation of Spreading Activation algorithm

I implemented the Spreading Activation algorithm and would love to get your feedback

Can one of the admins verify this patch?

Can one of the admins verify this patch?

I close this and will publish it on SparkPackages


[SE-0306] Ban "class" methods and properties in actors.

Explanation: Ban class methods, properties, and subscripts within an actor. Instead, require static like we do for structs and enums.
Scope: Affects a small number of actors.
Radar/SR Issue: rdar://80285441
Risk: Low.
Testing: PR testing and CI on main.
Original PR: https://github.com/apple/swift/pull/38298

@swift-ci please test

@swift-ci please nominate


Enhance the custom scale range

Note that the custom scale should only allow for a particular range. For instance, it seems that anything >20 has the same zoom level. I don't think that negative values should be allowed either. Consider adding these constrains to the definition of the inputs. I'm referring to this commit: https://github.com/cromanpa94/OSM.sf.shiny/commit/83596e8b43a820545c79eed49ac6d13ca5663d26.

Here's some relevant information on this, @rog-SARTHAK: https://leafletjs.com/examples/zoom-levels/

Addressed with the zoomSnap argument in this commit: https://github.com/cromanpa94/OSM.sf.shiny/commit/7c111ec8e757f9db3314976dbf7fd9f7cc9ceacf.


Build Header Component

Is your feature request related to a problem? Please describe.
Build out the Header Component as shown in the milestone.md file
Describe the solution you'd like
The Header should be Transparent or white colored and should be mobile responsive
Describe alternatives you've considered
It should contain the user icon and github icons towards the right part of the page
Additional context
You can use this Mockup

@phavor are you working on this one currently?

Yes I am.


[homeassistant.components.alexa] Received unknown intent RunScriptIntent - 0.50.2

Home Assistant release (hass --version): 0.50.2
Python release (python3 --version): Python 3.4.2
Component/platform: Linux raspberrypi 4.9.35-v7+ #1014 SMP Fri Jun 30 14:47:43 BST 2017 armv7l GNU/Linux
Component: Alexa
Description of problem:
I used the Alexa component with "intent_script" and It worked well.
it doesn't work now after the upgrade  0.49.1 -> 0.52.1 .
The request on Amazon test page: (I removed some information -> XXXXXXXXXXXXXX)
{
"session": {
"sessionId": "XXXXXXXXXXXXXXXXXXXXXXXXXXX",
"application": {
"applicationId": "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX"
},
"attributes": {},
"user": {
"userId": "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX"
},
"new": true
},
"request": {
"type": "IntentRequest",
"requestId": "XXXXXXXXXXXXXXXXXXXXXX",
"locale": "en-GB",
"timestamp": "2017-08-08T07:18:33Z",
"intent": {
"name": "RunScriptIntent",
"slots": {
"Script": {
"name": "Script",
"value": "TV on"
}
}
}
},
"version": "1.0"
}
The Answer:
{
"version": "1.0",
"response": {
"outputSpeech": {
"type": "PlainText",
"text": "This intent is not yet configured within Home Assistant."
},
"speechletResponse": {
"outputSpeech": {
"text": "This intent is not yet configured within Home Assistant."
},
"shouldEndSession": true
}
},
"sessionAttributes": {}
}
configuration.yaml -> script: !include_dir_merge_named script
script.yaml ->
tv_on:
sequence:
- service: switch.turn_on
entity_id: switch.power_living_room
- delay:
seconds: 5
- service: broadlink.send_packet_192_168_1_108
data:
packet:
- "XXXXXXXXXXXXX="
alexa.yaml ->
intent_script:
RunScriptIntent:
action:
service: script.turn_on
data_template:
entity_id: script.{{ Script | replace(" ", "_") }}
speech:
type: plain
text: OK
HASS log:
2017-08-08 09:08:05 INFO (MainThread) [homeassistant.components.http] Serving /api/alexa to XX.XX.XXX.XX (auth: True)
2017-08-08 09:08:05 WARNING (MainThread) [homeassistant.components.alexa] Received unknown intent RunScriptIntent
Could you help me?

I do not think the intents go under the alexa: heading any more. They go under the intent_script: in the configuration.yaml. I cannot tell if this how you have it configured.
I have
configuration.yaml ->
alexa:
intent_script: !include devices/intent_scripts.yaml
devices/intent_scripts.yaml ->
[My intents]

@grivers3 I have the exact setup like you said, and I get the same error message in the ApiAI console (This intent is not yet configured within Home Assistant.)
However I have followed the latest version of the api ai component https://home-assistant.io/components/apiai/ and is still does not work


Add Athena query and trigger tasks

Feature description
Link to the driver: https://docs.aws.amazon.com/athena/latest/ug/connect-with-jdbc.html
Example JDBC URL:
jdbc:awsathena://AwsRegion=[REGION];UID=[ACCESS KEY];PWD=[SECRET KEY];S3OutputLocation=[LOCATION]

# relying on a preconfigured AWS CLI profile:
jdbc:awsathena://AwsRegion=eu-central-1;S3OutputLocation=s3://declarative-orchestration/athena/

We already have an issue at AWS side for that: https://github.com/kestra-io/plugin-aws/issues/44