description for Input.is_mouse_button_pressed()

Nice. I don't think specifying the button values is required, since they are declared as constants in @Global Scope:
BUTTON_LEFT = 1
BUTTON_RIGHT = 2
BUTTON_MIDDLE = 3

I actually didn't know that. Thanks! I modified the description.

Tip: you can use [@Global Scope] to make a hyperlink to the actual @Global Scope help.
Thus I would rephrase to:
Returns whether the given mouse button is pressed or not. You can use the BUTTON_* constants listed in [@Global Scope] to refer to the specific buttons.

Could you also merge all commits into one with git rebase -i HEAD~3, and replace "pick" by "fixup" for all commits apart from the first one?

yes sir. done.

Awesome :)


Avoid streaming when x-amz-content-sha256 header is avaiable

When part is being uploaded to lakeFS, lakeFS uses streaming in order to upload that part to the object store. Streaming has some limitations when the connection is slow. It must sent a chunk every minute or so, in order to keep the connections alive. However chunks (except for the last one) minimum size is 8KB. Streaming will always fail when chunks smaller than that are uploaded.
Streaming is mandatory when the header x-amz-content-sha256 isn't sent to lakeFS. However we can avoid streaming and its limitations when the header exists.

With #1883 resolved, this issue becomes less urgent. Since we're not sending small chunks that fail the request, it's OK (or even better, depending on the rate and the s3 configured timeout for chunks vs. full objects) to use streaming even if you don't have to when the x-amz-content-sha256 header exist.
Closing for now, we may revisit this later if we see that streaming issues persist for slow connections.


update formdata-polyfill

Hi, I just published<EMAIL_ADDRESS>You might want to update.
not much changes you have to do
one breaking change is that it doesn't export anything, it shims the global formdata now

Thanks for the heads up!

Updated


urh package unable to be installed with uhd support

Describe the bug
I'm getting collision errors when trying to install the urh package with uhd support.
Steps To Reproduce
Steps to reproduce the behavior:

I'm on macOS 14.4.1, and using this template as my starter template (uses nix-darwin, home-manager etc.)
I've added the following to ~/nixos-config/modules/shared/packages.nix:

urh
(urh.override { USRPSupport = true; })
]

I then run nix run ./#build-switch

Expected behavior
The urh package should install with uhd support enabled.
Screenshots
I get the following error when running build-switch:
❯ nix run ./#build-switch
warning: Git tree '/Users/foo/nixos-config' is dirty
Running build-switch for aarch64-darwin
Starting build...
warning: Git tree '/Users/foo/nixos-config' is dirty
error: builder for '/nix/store/p28jhkibpj822j660dgb27w2vxkf5dyw-system-path.drv' failed with exit code 255;
       last 1 log lines:
       > error: collision between `/nix/store/fz61idkkjgk4bnyjpk9vn3yvbvvcp7d1-urh-2.9.6/bin/.urh_cli-wrapped' and `/nix/store/c8nps5q2z4cv3wd9nspashz5prwg6v04-urh-2.9.6/bin/.urh_cli-wrapped'
       For full logs, run 'nix log /nix/store/p28jhkibpj822j660dgb27w2vxkf5dyw-system-path.drv'.
error: 1 dependencies of derivation '/nix/store/b1cwid91iv61dwcrjg4abzpbghns1hh4-darwin-system-24.11.20240529.ad57eef+darwin4.c0d5b8c.drv' failed to build

Additional context
Add any other context about the problem here.
Notify maintainers
@r-ryantm @sikmir @AndersonTorres
Metadata
I'm sorry - this command doesn't seem to be working for me =(:
❯ nix-shell -p nix-info --run "nix-info -m"
error:
       … while calling the 'import' builtin
         at «string»:1:18:
            1| {...}@args: with import <nixpkgs> args; (pkgs.runCommandCC or pkgs.runCommand) "shell" { buildInputs = [ (nix-info) ]; } ""
             |                  ^

       … while realising the context of a path

       … while calling the 'findFile' builtin
         at «string»:1:25:
            1| {...}@args: with import <nixpkgs> args; (pkgs.runCommandCC or pkgs.runCommand) "shell" { buildInputs = [ (nix-info) ]; } ""
             |                         ^

       error: file 'nixpkgs' was not found in the Nix search path (add it using $NIX_PATH or -I)

Add a :+1: reaction to issues you find important.

you have urh twice in your config, just install one of those packages. that's generally what collisions indicate.

@victorhooi was your problem solved?

Yes - this was user error =(.
(Apologies - I am quite new to Nix, so I didn't realise that the override line itself also installs urh. I had perhaps naively assumed you'd need to define urh fine, then the override. For context, the original helpful suggestion here, but the misuse was mea culpa).


Location of install directory for users

Hi.
In your documentation the install directory is referred to as %localappdata%\Microsoft\Teams,
Under install I see the install directory as C:\ProgramData\kfl\Microsoft\Teams, install updated but not documentation?
When I check the user rights for C:\ProgramData\kfl\Microsoft\Teams I see that local users group has write access to the folder. Since domain users is a member of this group, it means that all users from the domain can overwrite update.exe in the Teams folder and replace it with a “bad” file, not good from a security perspective.
This would not be the case if the install was in %localappdata%\Microsoft\Teams.
In general I would like to handle Teams application like any other application in a enterprise environment, install to c:\program files (x86), and the patch it the way we patch all other applications.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7b13006b-d1de-8bc7-e0c6-b7022af0e731
Version Independent ID: d29dae65-bb28-8767-cfd7-07d2ed5fd460
Content: Install Microsoft Teams using MSI
Content Source: Teams/msi-deployment.md
Service: msteams
GitHub Login: @ninadara
Microsoft Alias: ninadara

Will this make it possible to install the teams application in a terminal server environment? Thanks for the clarification.

Two things:

The MSI has not been very reliable. It only successfully deployed on a small percentage of the Windows 7 computers.
The below document indicates that Teams is installed in the following two locations.
%appdata%\local\Microsoft\Teams
%appdata%\roaming\Microsoft\Teams

https://docs.microsoft.com/en-us/microsoftteams/get-clients

Let's not forget about SquirrelTemp please. In our findings, the following locations need to be allowed for Teams to run properly:
%AppData%\Microsoft\Teams
%LocalAppData%\Microsoft\Teams
%LocalAppData%\Microsoft\TeamsMeetingAddin
C:\Users%username%\AppData\Local\SquirrelTemp
C:\ProgramData%username%\SquirrelTemp
C:\Users%username%\AppData\Local\Microsoft\Teams\current\Squirrel.exe
SquirrelTemp is used to actually install Teams.
Microsoft: Get your act together please! Teams is all over the place. Please make it install and run from C:\Program Files and have user data go to the AppData folder for the user. No need to actually RUN Teams from the user's side of things! Think Enterprise-like! Please...

Should Teams match OS architecture or Office 2016 architecture?
For example, computers running Windows 10 x64 and Office 2016 x86.  Should the Team's architecture match Windows or Office?  Or does it matter?

Hey everyone. I'm investigating this so please be patient. I'm looking for PM owners so they can respond to these queries. Thanks, Tony

Sorry - getting used to this new comment system

No apologies necessary! I just wanted everyone to know that I’m reaching out to the owners of install and setup to get some answers for you!
From: mconwell<EMAIL_ADDRESS>Sent: Tuesday, April 17, 2018 8:37 AM
To: MicrosoftDocs/OfficeDocs-SkypeForBusiness<EMAIL_ADDRESS>Cc: Tony Smith<EMAIL_ADDRESS>Assign<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/OfficeDocs-SkypeForBusiness] Location of install directory for users (#101)
Sorry - getting used to this new comment system
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FOfficeDocs-SkypeForBusiness%2Fissues%2F101%23issuecomment-382037958&data=02|01|Tony.Smith%40microsoft.com|f5026e5f4a6b476e8cb608d5a4790322|72f988bf86f141af91ab2d7cd011db47|1|0|636595762006000219&sdata=mKfYryRU82xWWuBmDECDzD0ZZLVeRr00ZUcEUpCTaeA%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAdlCbmz9KK-mqq_wNxXh3JhrMdk3HNRjks5tpgwGgaJpZM4TJpzm&data=02|01|Tony.Smith%40microsoft.com|f5026e5f4a6b476e8cb608d5a4790322|72f988bf86f141af91ab2d7cd011db47|1|0|636595762006010228&sdata=VhVhgz61curciGozZFcPs2ofjTIvokjfwKj0gjQJHcA%3D&reserved=0.

Checking in - Still trying to locate an owner on the PG side.

Hi,
I'm currently trying to deploy this using a company PowerShell script to Software Center. Is there a commandline for installing to the user logged on without logging off or restarting? We seem to have issues deploying this application. Initially tested with the .EXE version of the install but that does not seem to properly install.

@ericgryan We deployed it the same way. Put on the script that after install of the crappy MSI from Microsoft, to create and run a scheduled task to run the Teams Installer .exe from C:\Program Files (x86)\Teams Installer (it goes to this directory even though one might install the 64-bit version; c'mon Microsoft!). This scheduled task gets ran as the user, and mimics what happens upon logon of the user. Once the task finishes, then it gets deleted per the script. Hope that helps!

@bgiacaman  Even if users reboot, or log off and come back in. It seems that the MSI still does not work in that situation. Do you perhaps have a code snip for that task scheduler sequence you can share?

From the documentation, it seems to indicated that the MSI will place the installer so that when a user logs into the machine it tries to determine if Teams is installed and if not it will run the installer.  Then the app is installed for the user after the user logs out and then back into the computer.
There does seem to be a "gotcha" if the user had previously had Teams installed.  Even after uninstalling it leaves traces that fools the MSI into thinking the program is still installed.
MS says:

Uninstall Teams App installed for every user profile
After uninstall, delete directory recursively under %localappdata%\Microsoft\Teams\
Redeploy the MSI package to that particular machine

MS has a script available to do steps 1 & 2
I have not tried this though.  Good luck.

Hey everyone! Thanks for the feedback! I'm trying to locate a PM to answer your questions. I will report back to this thread. Appreciate your patience. Thanks, Tony

I've assigned two PMs from the product group to lend you a hand. We appreciate the feedback. If there are addition/corrections/suggestions to the docs, please edit the topic by clicking Edit (on the right side of the topic) or use VsCode/GtiHub desktop. Let me know how I can help further.

For me, the real issue here is just a matter of the software being coded so that:

It writes like a normal 64 or 32 bit application to Program Files Directory.
It installs all it's components and shortcuts even if it fails to connect to the internet for the first time.

The reasoning behind these two previous premises is that  a great amount of IT infrastructures have certain restrictions to prevent writing to APPDATA folders. Also since we might need to adjust the firewall rules in order to allow the program to run, it is better to troubleshoot any exceptions while the program is fully installed.

@juturu and @voltarone for awareness.

Anything on this yet?? We've now realized that we are not able to open up Teams.exe from the User's AppData folder in the firewall because since the firewall is running as the system, it does not recognize user-specific system variables like %userprofile%, %localAppData%, etc. This MSI REALLY needs to change! Here's the solution we NEED, Microsoft:

Install and RUN Teams.exe from %ProgramFiles%
Put user data in %localAppData%; no need to copy the EXE there and run from there.

Once Teams.exe is put in the %ProgramFiles%, we will be able to open up the program in the firewall to run as intended. PLEASE HELP!!

Agree with everyone else. Please install to ProgramFiles and store user specific settings to AppData. That is how it SHOULD have been from the start. This MSI does little to nothing of solving the problem with Teams in a business/education environment. The way it is now makes it seem like the installation process was decided by some hipster coders who can't comprehend why it's a problem. There is a reason things are done the way they have been for decades. Your ripping holes in system security. Stop it already before someone takes advantage.

Microsoft Teams should have two installers. The same when Google Chrome has two installers. The basic installer should allow any user without admin credentials to install the app in AppData. But the MSI should behave similar to Google Chrome Browser for Enterprise. It allows an admin to deploy the app in ProgramFiles for any user that logs onto the computer.

RTFM!

as @ericgryan pointed out on May 4... a key issue for many of you is that the x64 MSI still "chucks" the Teams.exe installer in
C:\Program Files (x86)\Teams Installer\
It may rightfully BE a 32-bit exe that runs the installer (haven't bothered to check) but then the reg RUN key points to an invalid directory:
HKLM:\SOFTWARE\Wow6432Node\Microsoft\Windows\CurrentVersion\Run\ TeamsMachineInstaller : C:\Program Files\Teams Installer\Teams.exe --checkInstall --source=default

Just got news about installing in Program Files.  However, reading here, it looks like the installer just install the installation files in the Program Files and, once user logs in, execute to install in user's AppData folder.  While storing data in AppData is fine, my Software Restriction Policy prohibits running executables from AppData.  The main program must be installed in Program Files.  That was the goal.  Is this not made?  Then it's still useless in Enterprise environment.

Ugly workaround:
Whitelist install location for endusers %localappdata%\Microsoft\Teams\current and the two exe:s squirrel.exe and teams.exe AND
%localappdata%\Microsoft\Teams\update.exe
To enhance security, let AV know the current hashes and let %localappdata%\Microsoft\Teams\update.exe update squirrel.exe and teams.exe
Use a staging or preproduction environment to log in as a enduser, to check for in and outgoing traffic and allow it in firewall.
But there might be more connections added when plugins and other services are added to teams anyway.
Use fiddler 4 to check for connections https://www.telerik.com/fiddler

They have closed the UserVoice request to change the install locations citing this article. Again, this method of install is NOT secure nor ideal. Microsoft: This MSI REALLY needs to change! Here's the solution we NEED, Microsoft, here's what we need the MSI to do:

Install and RUN Teams.exe from %ProgramFiles%
Put user data in %localAppData%; no need to copy the EXE there and run from there.

Once Teams.exe (not the installer but the actual end-user software) is put in the %ProgramFiles% directory, we will be able to open up the program in the firewall to run as intended. PLEASE HELP!!

This is the UserVoice request they marked as closed :(
https://microsoftteams.uservoice.com/forums/555103-public/suggestions/17380159-improve-install-options-install-for-all-users-an?tracking_code=5ab634aa39ce2102495413ce97a86648#{toggle_previous_statuses}

@bgiacaman - I am going to surface this to the Teams group.. it sounds like the User Voice that was closed wasn't satisfactory?

Definitely did not meet the basic criteria for Enterprise users, which is to install the main program in ProgramFile once, not in each user’s AppData.  Program in ProgramFile, data in AppData.
Regards,
John Babbitt
Systems Administrator
Cutler Investment Group
525 Bigham Knoll, Jacksonville, OR 97530
Direct:<PHONE_NUMBER>tel:(541) 201-8700 | E-mail: support<EMAIL_ADDRESS>| http://www.cutler.comhttp://www.cutler.com/
The contents and/or document(s) accompanying this email contain information from Cutler Investment Group which may contain confidential client information. If you are not an intended recipient of this e-mail, please notify the sender, delete it and do not retain or redistribute it. Email messages sent to or from this address are subject to archive, monitoring and review by, and/or disclosure to, persons other than the recipient.
From: Ken Withee<EMAIL_ADDRESS>Sent: Tuesday, July 10, 2018 12:48 PM
To: MicrosoftDocs/OfficeDocs-SkypeForBusiness<EMAIL_ADDRESS>Cc: Technical Support<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/OfficeDocs-SkypeForBusiness] Location of install directory for users (#101)
@bgiacamanhttps://github.com/bgiacaman - I am going to surface this to the Teams group.. it sounds like the User Voice that was closed wasn't satisfactory?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/101#issuecomment-403944082, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AnAfKH_dlpGfXoNYNVevOuWTCroBxM59ks5uFQTlgaJpZM4TJpzm.

Agreed with others. The requirements of installs for Enterprise (install the actual application to Program Files NOT AppData) has not been met and will continue to prevent adoption of these products. Unfortunately I think the teams over at Microsoft understand the issue but don't actually want to solve it. They have taken the approach, like a few other devs, that there is "no problem" with it being installed for every user in AppData. Which is just plan wrong. It's an issue logistically for anyone running VDI. And an issue security wise for anyone that needs to run a locked down domain.

@kenwith exactly! It was totally not satisfactory and comments are closed for it. Please have it reopened. I also created another UserVoice request for the same thing but it did not have much votes to get noticed like the one they closed :/

Just a quick update. I am following up with Warren who manages the User Voice.

I share the same sentiment as others have expressed. The current Microsoft Teams installer does not meet the needs of Enterprise customers with an Enterprise deployment strategy.

Thank you for the feedback and our Microsoft Teams feature team have seen your feedback. Allow me to provide a response from the feature team.

Why Teams App is NOT installed in Program Files (aka per Machine)?
The goal was to ensure we provide our users with newest features and fixes as quickly as possible and ensure all users are getting the best experience possible from Microsoft Teams.

Therefore, we don’t limit the ability to update the software by requiring only IT Admin credentials. Unfortunately, if the product were installed under Program Files, that is exactly what would happen. Software under Program Files requires IT admin credentials and the updates would need to be managed per user which in turn would be a lot of overhead due to the frequency of updates to Microsoft Teams.

Why Not follow Office Installation Practice?
All Office apps require admin credentials to install & update. Office products are updated at a much slower rate than Teams. We are actively creating updates and new features as quickly as possible and having an admin prompt pop due to updates either several times a week or sometimes daily when in Teams would be frustrating for users.

Also, most managed deployments of Office happen via SCCM (msi based) which is handled by IT admins. The process is a system service and an install would not prompt the user for admin credentials.  Once the installation is complete all future updates are handled by SCCM. If IT admins were required to handle weekly SCCM for various updates, this too would be frustrating/annoying.
The overall goal is to try and make the installation as painless as possible while enabling our ability to keep Teams updated in a timely fashion without placing undo burden on IT admins within organizations.

The problem with your resolution is that it runs smack against Software Restriction Policies.  Most, if not all, enterprise setting has prohibited running software out of AppData and Temp folders.    Thus, enterprise users will not be allowed to use Teams App until this is corrected.  Microsoft needs to think like an enterprise firm.

Fine, then know that Teams will NEVER be used by a large number of Corporate entities.
Installing to AppData conflicts with Security Policies. To make matters worse you can't even whitelists the applications through other means like Certificate or Hash. It also tries to VIOLATE the very security measures put in place to protect my end users. It also conflicts with any RDS or VDI environment which is a MAJOR ISSUE.
Your "solution" for Teams installation simply doesn't work in a multitude of environments. If the group at Teams doesn't see that as a problem then I guess I don't see their product having a place in my environments.

@WarrenMicrosoftTeams - do you think it is possible to open a User Voice for a feature request to install in Program Files?

@WarrenMicrosoftTeams - Our organization also falls into the "Install to Program Files" camp.  Between this thread and other topics on the UserVoice site there appears to be two primary concerns from Enterprise customers with regards to the current installer practice, Terminal Services and Application Whitelisting.  What about having the Teams PG work with or solicit feedback from the PG responsible for Terminal Services and features like SRP\AppLocker .  Perhaps working with them directly they might help expose how the intent of "make the installation as painless as possible" may be falling a bit short for at least some Enterprise customers.  With any luck perhaps they may be able to make some suggestions that may offer a middle ground that still allows the Teams PG to "update in a timely fashion" while giving us the tools we need to perform our job.

@voltarone : there was a user voice opened for this request but it was marked as complete and closed by @WarrenMicrosoftTeams.
Here's the link: https://microsoftteams.uservoice.com/forums/555103-public/suggestions/17380159-improve-install-options-install-for-all-users

@WarrenMicrosoftTeams:
The response you provided from the feature team is inconceivable. It seems like no one there has ever worked in a true enterprise environment with SRPs/GPOs/Firewalls, etc. No one in an enterprise environment would ever think about running a software from the user's AppData; this idea even goes against Microsoft's own standards and practices. See OneDrive, Dropbox, and even Google had to provide the same change when they released their MSI package for enterprise environments. What we are asking for is not unreasonable and it is not impossible. What we need is for the MSI package for Teams to behave differently then the public's. We need the app to be redesigned to stop trying to load EXEs in the user's AppData path, and also stop defaulting the update process to go and run from there.
The MSI should:

Install the EXE in the Program Files directory (not a Teams Installer, but the actual Teams app EXE)
Store and reference user files (like settings, and other data) in the user's AppData path.
Redesign the behavior of the auto-update to put the downloaded update wherever the Teams app EXE is installed in (i.e. C:\Program Files\Microsoft Teams\DownloadedUpdate); as IT admins we can allow this path or specific EXEs running from this path to be allowed to function without administrator credentials.

Having the Teams' MSI standardized with the industry's practices will allow us as IT Admins to manage the app better across our domains. We would be able to create SRP rules for the software, as well as allow it through the firewall (something that we can't currently do, since we can't reference user variables as system variables in firewall rules because of a Microsoft limitation). Doing this will truly help us make the installation as painless as possible while enabling your ability to keep Teams updated in a timely fashion.
Thank you!

So essentially, Microsoft is saying screw your corporate policies and we're going to do it our way. Thanks Microsoft.

Hi All, I just noticed there is an AMA for the Teams product team tomorrow (Thursday, Aug 9) and it might be a good opportunity to bring up regarding the install directory and how it works with corporate policies. Here is the link: https://techcommunity.microsoft.com/t5/Microsoft-Teams-AMA/Announcing-a-Microsoft-Teams-AMA/m-p/216192#M1957
I will keep this thread open too and if anyone knows of a User Voice that we can link let's link it in here so we can add the up votes.

Left a comment here; I suspect many of you in this thread will understand:
https://github.com/MicrosoftDocs/msteams-docs/issues/238#issuecomment-422090416

Hi All, I am going to close this thread since this repo is for the docs. Any comment here will re-open this thread though so anyone with updates or requests for action from the community is welcome (example - if there is a user voice we can all up-vote feel free to post).
On a note, I know this issue is high on the radar of the product team and I ask about it every chance I get.

https://microsoftteams.uservoice.com/forums/555103-public/suggestions/34768153-improve-install-options-install-for-all-users-an

Thank you for posting the uservoice. We'll continue to track this issue there.

I have the same issue as @kfl64, Teams is installed the **c:\programdata<username>**Microsoft\Teams and not in the Local AppData as the documentation suggests. I searched everywhere, but can't find anything on why it install in the programdata\username folder.
The only thing I can think of is that our Software Restriction Policy. We block every .exe in the user profiles, so Teams can't install there after the users logs in. Can anyone confirm this or point me in the right direction why Teams isn't installed in the "correct" location.

Microsoft finally made it enterprise-friendly.  I have the full Remote Desktop Server package (RDG, RDB/RDC, RDSH) and Software Restriction Policies (SRP) yet I got this to work today with the enterprise-friendly installation.  You can read about it at https://docs.microsoft.com/en-us/microsoftteams/teams-for-vdi.  There are a few items to tweak, though:

Installation will fail unless you create a registry key, if one doesn't already exists, for either:
a.  HKLM\SOFTWARE\VMware, Inc.\VMware VDM\Agent, or
b. HKLM\Software\Citrix\PortICA

If you do not want to auto-start this for everyone (I had another group that doesn't use it at all and it annoys them every time they log in):

After installation, delete the registry value Teams from HKLM\SOFTWARE\WOW6432Node\Microsoft\Windows\CurrentVersion\Run.  Do not delete the other two TeamsMachineUninstaller* values.

If the user wants it to auto-start (unfortunately, Teams didn't have its own auto-start option), do these:
a. Right-click Start Menu (Windows logo key) and select "Run".
b. Enter "shell:startup" and press Enter.  This gives you the Startup folder.
c. Click Start Menu, scroll down to Microsoft Corporation, drag Teams to your Startup folder.

Enjoy!

@CIGAdmin I'm going to try this today! If this works you are a life saver.
I saw they released it for VDI/RDS environments so I had high hopes that shortly after they would release it for regular desktop users and finally resolve this issue. My initial attempts to install the VDI/RDS based installer on a regular desktop had failed.
They just recently as part of updates to Office365 they began pushing Teams to users without opt-in. The method they use is the "drop the installer in Program Files, run on user login, and install to AppData". Which was blocked by my SRP policies. No doubt this is a push to move everyone away from Skype with it being phased out soon.
I figured there had to be some "detection" method and way to trick the installer. Sounds like it's just this reg key.
Also, there are GPO methods (or reg keys) you can use now to prevent the auto installation of Teams or prevent it from running on first install. See https://docs.microsoft.com/en-us/DeployOffice/teams-install

Yep, that worked!
 I have had mine working since Aug 2019. Did you follow all the steps I outlined? What kind of issue are you having?

 The registry hack is what allowed us to use the machine-specific installation where there's no Citrix nor VMware. I had to also use this hack even though I have a native RDS setup; Microsoft didn't think about their own RDS!

Please respect the security of the environment. Allow Teams to run from a locked down directory. Thank you.

Allow Teams to run from a locked down directory.

@pcunite, are you using the machine-specific installation of Teams? If so, it's normally run under "C:\Program Files (x86)\Microsoft\Teams\current". That folder is read-only to my users and they're using Teams on RDS with UPD and SRP. See earlier instructions on how to get machine-specific Teams installed on your RDS server.
If you are using the user-specific installation of Teams (by far, the default), then it runs under user's own AppData folder. Normally not locked down but my SRP prevents running programs from anywhere but the Program Files and Windows folders, unless their certificates have been whitelisted within SRP.
Good luck getting yours up and running, whatever platform you are using (PC or RDS).

CIGAdmin
I have installed the teams in the program data files following your directions but the installer is still failing for users. I am running vmware virtual windows server 2019. I must be doing something wrong but for the life of me cant figure it out.

You need to check your GPO, and see if you have an SRP. If you have an SRP enabled and it blocks the appdata folder locations, Teams will install into programdata instead of appdata.

@JaredSysAdmin, you need to use the machine-wide installer. Make sure you read this thoroughly:
https://docs.microsoft.com/en-us/microsoftteams/teams-for-vdi#deploy-the-teams-desktop-app-to-the-vm
Pay attention to the switches needed to install these properly. Also, make sure you already edited your registry settings as I had instructed earlier in this thread. If you are installing this in a remote session as opposed to console session, be sure to do the usual CMD "change user /install" before installing and "change user /execute" after installing. GL

I make copy of my comment from issue #512 (https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/512#issuecomment-841816923) as summary:
Microsoft Teams Team, here is my arguments, why do not use installation per user in enterprise environment:

Office use MSI packages to Office 2013. From Office 2016 is used Click-to-Run install engine. Since Office 2016 use our self-update mechanism indenpedent of Microsoft Update. Is possible to disable it. So Office running in Program Files folder, and can update self.
Please inspire with Google Chrome/Chromium. Ask for Chromium/Chrome, or your Microsoft Edge team how make frequent updates of application in Enterprise environment without Administrator rights. If I want, it is possible to disable of the automatic update.
Weekly updates is maybe frustrating/annoying for SCCM admins, but they are responsible, not you. How many updates we make and how often it's none of your business. therefore, it is not possible for you to decide for them. Therefore, it is not possible for you to decide for them. Then all those tools and features like WSUS and deferred installation of updates would be not make sense.
Make multiple copies of application files is crazy idea not only from point of view from RDS servers admins, but for example shared workstations in education environments, or for example call centers, or other business with shift operations. I talking about scenario where is multiple users (in shifts) on single device.
In real secure environment with AppLocker, is not possible had any executable files in user profiles. This is suspicious and exploitable. For store of application files is used Program Files folders. Please use only Program Files folders. Realize that in a security-conscious society, it is absolutely unthinkable for a user to install an application.
It is strange that you, as a Microsoft part, do not behave consistently as others Microsoft's teams. I've been following this behavior for a few years with teams developing cross-platform tools, such as Visual Studio Code.  And because you're part of Microsoft, I find your team's behavior embarrassing. Please contact your own enterprise architecture and security engineers and ask them what you are doing wrong. Then you won't have so many upset people here and everyone will be happy.
Your product are great. however, also think not only of application users but also of administrators and listen to their needs. It's great to have an amazing product, but what's the point of deploying it when it's deployed in an environment of hundreds of users.


Mechanical mixer

Describe the Bug
I will try to describe the problem correctly, if, for example, put zinc and copper in a basin to produce brass and connect a mixer, and start twisting it, animation will begin, and if you stop and do not twist, then the mixer will stop, but the animation in the basin will that is, resources will continue to rotate in the basin and particles will fly out outside, the sounds will not disappear either, but the mixer does not work, I hope everything is clearly explained.
It also works without extraneous mods and without resource packs.
Reproduction Steps
1.Create a new world
2.Install a basin and mixer above it
3.Connect a small gear to the mixer and connect the handle to it
4.Put any objects that can be mixed in the basin (for example, zinc and copper)
5.Start turning the handle, and wait the mixer drops into the basin and starts spinning, then stop immediately
6.You will see how objects continue to spin in the basin, releasing particles and making sounds
Expected Result
It was expected that when the player stops turning the handle, the objects in the basin will stop spinning, releasing particles
Screenshots and Videos
No response
Crash Report or Log
No response
Operating System
Windows 7
Mod Version
0.5.1d
Minecraft Version
1.20.1
Other Mods
create
fabric api 0.91.0
Additional Context
No response

Occurs on forge aswell, report to the forge repo please.


layer_map fails on custom containers

layer_map fails on simple custom contaier layers such as the one shown below:
using Lux, Random, Setfield

struct SimpleCustom{L1, L2} <: Lux.AbstractExplicitContainerLayer{(:dense, :conv)}
    dense::L1
    conv::L2
end

l = SimpleCustom(Dense(3=>2), Conv((3,), 3=>2))

rng = Random.default_rng()
ps, st = Lux.setup(rng, l)

function zero_dense_params(l, ps, st, name)
    if l isa Dense
        @set! ps.weight = zero.(ps.weight)
        @set! ps.bias = zero.(ps.bias)
    end
    return l, ps, st
end

l_, ps_, st_ = Lux.@layer_map zero_dense_params l ps st

Output:
ERROR: LoadError: MethodError: no method matching keys(::Dense{true, typeof(identity), typeof(Lux.glorot_uniform), typeof(Lux.zeros32)})
Closest candidates are:
  keys(::Union{Tables.AbstractColumns, Tables.AbstractRow}) at ~/.local/share/julia/packages/Tables/T7rHm/src/Tables.jl:189
  keys(::Number) at ~/.local/src/julia/usr/share/julia/base/number.jl:93
  keys(::Tuple) at ~/.local/src/julia/usr/share/julia/base/tuple.jl:72
  ...
Stacktrace:
 [1] layer_map(f::typeof(zero_dense_params), l::SimpleCustom{Dense{true, typeof(identity), typeof(Lux.glorot_uniform), typeof(Lux.zeros32)}, Conv{1, true, 2, typeof(identity), typeof(Lux.glorot_uniform), typeof(Lux.zeros32)}}, ps::NamedTuple{(:dense, :conv), Tuple{NamedTuple{(:weight, :bias), Tuple{Matrix{Float32}, Matrix{Float32}}}, NamedTuple{(:weight, :bias), Tuple{Array{Float32, 3}, Array{Float32, 3}}}}}, st::NamedTuple{(:dense, :conv), Tuple{NamedTuple{(), Tuple{}}, NamedTuple{(), Tuple{}}}}, name::String)
   @ Lux ~/.local/share/julia/dev/Lux/src/contrib/map.jl:94
 [2] top-level scope
   @ ~/.local/share/julia/dev/Lux/src/contrib/map.jl:36
 [3] include(fname::String)
   @ Base.MainInclude ./client.jl:451
 [4] top-level scope
   @ REPL[2]:1
in expression starting at /home/nikopj/.local/share/julia/dev/Lux/test/contrib/map.jl:64

The above snippet is from the map.jl test file in my local clone of Lux, hence the last path.
My first thought is that layer_map is tailored for handling containers such as Parallel and Chain which have a very specific struct definition. It would be nice if custom containers that did not follow the form of Parallel and Chain could work. I'm not sure what the best way forward is, thoughts appreciated.

Should be fixed by #189

The new release will have the fix. We are also testing for custom layers in CI. Feel free to reopen the issue if the problem persists.

the fix works great, thanks!


Api Controller inserts Controller template

In the " New C# " menu "Api Controller" option creates a file with "Controller" template.
The last commit seems to fix this problem so I was curious when extension will be updated. I do not know if that is active repository.
Keep the good work!

I'm going to close it. It has been solved by #98.


What's the recommended way of dealing with node connectivity/identity issue caused by IP reused in a private network?

Hi,
What's the recommended way of dealing with connectivity/identity issue caused by IP reused in a private network such as Kubernetes?
For example, given two Substrate nodes alice and bob running and talking to each other, then bob goes away, then a new node charlie comes in using bob's old IP address, but alice will refuse to talk to charlie because the IP address was associated with bob's peer ID, not charlies.
This is a potential issue in Kubernetes as when pods or the underlying machines get restarted, they may get assigned such an IP that will trigger this issue. What's the recommended way of dealing with this?
Thanks.

There shouldn't be any problem caused by bob and charlie sharing the same IP.
What probably happen in your situation is that according to alice, charlie doesn't exist.
alice continues to try to contact bob and finds a man-in-the-middle (charie) instead, but she isn't smart enough to realize that this man-in-the-middle (charlie) should also be part of the network.
If, however, she learned about charlie's existence through the discovery process, then she would connect to it.
Alternatively, might also be a duplicate of https://github.com/paritytech/substrate/issues/4272

I can confirm charlie was part of the network initially but restarted and received bob's old IP, looks to be a duplicate of #4272 indeed based on the behavior observed. I'll add some info to that issue instead, thanks.
Duplicate of #4272


Networking: Ignore invalid and unconfigured interfaces

Ignore the non namespaced tunnel base devices like gre0, tunl0,
sit0, ipip0 etc. Also ignore any devices that do not have ip
address configured.
Fixes https://github.com/containers/virtcontainers/issues/391
Signed-off-by: Manohar Castelino<EMAIL_ADDRESS>

LGTM

@mcastelino you need to fix the test for this change.

lgtm

LGTM

Coverage decreased (-0.07%) to 65.618% when pulling f2ba9f1b4531f0922956389f69c5ff01e7d121a9 on mcastelino:topic/ignore_tunnel_base into ffacffa7891249e12a8debee606ee9867826d334 on containers:master.

@sboeuf can you review/merge. We also need to re-vendor this into cc-runtime.

@mcastelino oh yes sure, I hadn't realize you had rework the tests.

I am gonna include it in the re-vendoring ;)


AttributeError: 'TapLinuxSDK' object has no attribute 'set_haptic_command'

Was following the documentation and it looks like this isn't supported on Linux? Would be nice if that module implemented that function.
EDIT: Actually, it only looks like it's in the documentation, and not implemented in any of the platform-specific modules?

You are absolutely right.
It's a total mishap of ours...
The command is actually send_vibration_sequence.
Docs are fixed at 0.4.0


Windows Illegal Instruction Release Mode

Hi,
I have been using this crate via the tokio/bytes crates and after rust 1.19, I am getting illegal instruction errors when running in release mode. The following snippet fails in release mode:
extern crate iovec;

use iovec::IoVec;

fn main() {
    let iovec: &IoVec = Default::default();
}

with error:
error: process didn't exit successfully: `target\release\asd.exe` (exit code:<PHONE_NUMBER>) Illegal instruction
However, the following snippet succeeds in release mode:
extern crate iovec;

use iovec::IoVec;

fn main() {
    let buffer: &[u8] = Default::default();
    let iovec: &IoVec = buffer.into();
}

Both of the previous examples were run with lto = false. However, when setting lto = true, the first example succeeds while the second one fails.
I wasnt sure if I should report this to the rust repo, as I wasnt sure as to the guarantees of ub when transmuting some type (WSABUF) to [u8] that doesnt follow the actual layout of a [u8].
Platform (Windows 10):
rustc 1.20.0 (f3d6973f4 2017-08-27)
binary: rustc
commit-hash: f3d6973f41a7d1fb83029c9c0ceaf0f5d4fd7208
commit-date: 2017-08-27
host: x86_64-pc-windows-msvc
release: 1.20.0
LLVM version: 4.0

Thanks for the report! I've posted a PR in #5 along with a description of what I believe the issue is.


Using postcss-unopacity and postcss-filter-gradient together - shows 'Filter' declaration already exists

Hi Jonathan,
I used this two pluggins to cover grandient and opacity fallbacks to IE, but seems that as they both use 'filter' declaration, shows this message.

The filter declaration already exists, we have skipped this rule. - Repeated for each css so end up with lots of messages.

They both work well and the output css markup is correct, but is there a way to correct this warning messages? or how can I fix this?
Thanks!


RNA-seq variant calling: precision might be improved

Hi bcbio developers!
I have validated RNA-seq variant calling in BCBIO with SRR307898 dataset (GM12878 cell line).
The precision is 90%.
In bcbio-nextgen/bcbio/rnaseq/variation.py I see 3 steps
def rnaseq_gatk_variant_calling(data):
    data = dd.set_deduped_bam(data, dedup_bam(dd.get_work_bam(data), data))
    data = gatk_splitreads(data)
    data = gatk_rnaseq_calling(data)
    return data

While GATK best practices suggest one more important step: filtering (step 7).
https://software.broadinstitute.org/gatk/guide/article?id=3891.
In my experience it really improves precision at least to 95%.
Could you include this step into variation.py?
Also it would be nice to filter out RNA-editing sites by default.
It should not be complex:
bedtools subtract -header -a input.vcf -b rnaedit.bed >output.vcf

Many thanks,
SN

Hi Sergey,
Awesome, thanks so much for testing.  We provide editing sites from RADAR but don't have them run automatically:
genomes/Hsapiens/GRCh37/editing/RADAR-GRCh37.bed
if you intersect with those, does that give you the same bump in precision? I know there is also the DARNED database but I haven't been following the literature much to know whats the best resource to use. If RADAR works, and the BED file we provide looks good, we can totally add it to the postprocessing of the RNA-seq variants. Otherwise it would be great to know where you grabbed your BED file from.

Hi Roryk,
I filtered out RNAediting sites with bed file before measuring precision.
SN

Hi Sergey,
Yup-- but is the editing sites BED file you used from RADAR or another place?

Yes, it was from RADAR.

Thanks, this is super helpful. I've been messing around with Brent's vcfanno (https://github.com/brentp/vcfanno) for doing this. I was thinking instead of splitting the VCF up into possible-edits and not, we can instead tag each variant that is a possible deaminase event and overlaps the RADAR edit sites as a possible edit event in the INFO field. Would that work?

Thanks Sergey, added support for this in the development version. It uses vcfanno to add a possible_edit entry to the INFO field for events that are a) SNPs and b) overlap RADAR.

Thanks Roryk, the annotation approach is perfect. Anyone then could filter out these sites, or keep them.SN

Hi Roryk, in my initial post I started with GATK filtration step. Could you please implement this also?
java -jar GenomeAnalysisTK.jar -T VariantFiltration -R hg_19.fasta -V input.vcf -window 35 -cluster 3 -filterName FS -filter "FS > 30.0" -filterName QD -filter "QD < 2.0" -o output.vcf

This would boost the precision.

Hi Sergey,
Sure-- where did you pick those filters from and what do they do?

It is from GATK best practices for RNA-seq,
https://software.broadinstitute.org/gatk/guide/article?id=3891
To filter the resulting callset, you will need to apply hard filters, as we do not yet have the RNAseq training/truth resources that would be needed to run variant recalibration (VQSR).

We recommend that you filter clusters of at least 3 SNPs that are within a window of 35 bases between them by adding -window 35 -cluster 3 to your command. This filter recommendation is specific for RNA-seq data.

As in DNA-seq, we recommend filtering based on Fisher Strand values (FS > 30.0) and Qual By Depth values (QD < 2.0).

java -jar GenomeAnalysisTK.jar -T VariantFiltration -R hg_19.fasta -V input.vcf -window 35 -cluster 3 -filterName FS -filter "FS > 30.0" -filterName QD -filter "QD < 2.0" -o output.vcf

Please note that we selected these hard filtering values in attempting to optimize both high sensitivity and specificity together. By applying the hard filters, some real sites will get filtered. This is a tradeoff that each analyst should consider based on his/her own project. If you care more about sensitivity and are willing to tolerate more false positives calls, you can choose not to filter at all (or to use less restrictive thresholds).

An example of filtered (SNPs cluster filter) and unfiltered false variant calls:

In my testing this filter really improves precision.

Thanks Sergey, I added these filters-- we were counting on folks running their own filters on variants downstream, but I think people run the RNA-seq variant calling so seldomly that it makes sense to err on the side of leaving out some calls rather than including everything.

Thanks Roryk, this is what I need. I have tested the updated version with
details:
- algorithm:
    aligner: star
    effects: snpeff
    variantcaller: gatk
  analysis: RNA-seq
  description: SRR307898
  files:
  - /hpf/largeprojects/ccmbio/naumenko/RIVAL/pipeline_results/bcbio/input/SRR307898_1.fq.gz
  - /hpf/largeprojects/ccmbio/naumenko/RIVAL/pipeline_results/bcbio/input/SRR307898_2.fq.gz
  genome_build: GRCh37
upload:
  dir: ../final

In final/project/combined.vcf I see that SnpCluster filter is working.
But regarding RNAediting annotation I have not found anything. Maybe I forgot to turn it on?
bedtools intersect -header -a combined.vcf -b rnaedit.v2.bed > combined.rnaedit.vcf
cat combined.rnaedit.vcf | grep -vc '^#'
24764
cat combined.vcf | grep -c possible_edit
0

Combined.vcf does contain some variants in RNA editing sites and does not contain possible_edit annotation.
Please check this!
Thanks,
Sergey

Hi Sergey,
Sorry about that-- could you look through your log file and see what it says about vcfanno? It will just skip running vcfanno if it can't find the configuration files, and it would be helpful to know which it is missing.

Hi Roryk!
cat bcbio-nextgen-commands.log | grep vcfanno
<empty>

SN

Thanks, what about the debug log file? It should be spitting out some messages about why it is not running vcfanno.

Yes, you are right:
The vcfanno configuration /hpf/largeprojects/ccmbio/naumenko/tools/bcbio/genomes/Hsapiens/GRCh37/vcfanno/GRCh37-rnaedit.conf was not found for GRCh37, skipping.

Great-- if you do a data update with bcbio_nextgen.py upgrade --data  it should pull in the vcfanno directory to here: /hpf/largeprojects/ccmbio/naumenko/tools/bcbio/genomes/Hsapiens/GRCh37/vcfanno/. Let me know if that doesn't work.

I have updated successfully, but I have got an error:
subprocess.CalledProcessError: Command 'set -o pipefail; /hpf/largeprojects/ccmbio/naumenko/tools/bcbio/galaxy/../anaconda/bin/vcfanno -lua /hpf/largeprojects/ccmbio/naumenko/tools/bcbio/genomes/Hsapiens/GRCh37/vcfanno/GRCh37-rnaedit.lua -base-path /hpf/largeprojects/ccmbio/naumenko/tools/bcbio/genomes/Hsapiens/GRCh37/vcfanno /hpf/largeprojects/ccmbio/naumenko/tools/bcbio/genomes/Hsapiens/GRCh37/vcfanno/GRCh37-rnaedit.conf /hpf/largeprojects/ccmbio/naumenko/RIVAL/pipeline_results/bcbio/work/align/SRR307898/SRR307898_star/SRR307898-dedup.splitN.gvcf > /hpf/largeprojects/ccmbio/naumenko/RIVAL/pipeline_results/bcbio/work/align/SRR307898/SRR307898_star/tx/tmpXDMZ4S/SRR307898-dedup.splitNrnaedit-annotated.vcf.gz

=============================================
vcfanno version 0.0.11-beta [built with devel +5ec87ba Thu Apr 28 15:36:34 2016 +0000]

see: https://github.com/brentp/vcfanno
=============================================
vcfanno.go:108: [Flatten] unable to open file: /hpf/largeprojects/ccmbio/naumenko/tools/bcbio/genomes/Hsapiens/GRCh37/vcfanno//hpf/largeprojects/ccmbio/naumenko/tools/bcbio/genomes/Hsapiens/GRCh37/vcfanno/../editing/RADAR-GRCh37.bed.gz in /hpf/largeprojects/ccmbio/naumenko/tools/bcbio/genomes/Hsapiens/GRCh37/vcfanno
' returned non-zero exit status 1

Kind of path error somewhere. How to fix it?
SN

Hi Roryk,
could you please check if the filter gatk_filter_rnaseq(data, vrn_file, out_file):
from
https://github.com/chapmanb/bcbio-nextgen/blob/master/bcbio/rnaseq/variation.py
is actually running? The commands.log file does not contain VariantFiltration command.
SN

Hi Sergey,
Thanks, I fixed the code to run this properly and ran it on the dataset you are running and it appears to be working okay. The vcfanno edit annotation does not work 100% properly at the moment, the feature we are using to call if a possible edit is a SNP is in the unreleased version of vcfanno: https://github.com/brentp/vcfanno/releases/download/v0.1.0-dev/vcfanno   so right now it will just call if it overlaps an edit site, not if it could be one.

Thanks, Roryk!
Unfortunately the last step is not working for me. The pipeline tries to run the command
/hpf/largeprojects/ccmbio/naumenko/tools/bcbio/galaxy/../anaconda/bin/vcfanno -lua /hpf/largeprojects/ccmbio/naumenko/tools/bcbio/genomes/Hsapiens/GRCh37/vcfanno/GRCh37-rnaedit.lua -base-path /hpf/largeprojects/ccmbio/naumenko/tools/bcbio/genomes/Hsapiens/GRCh37/vcfanno /hpf/largeprojects/ccmbio/naumenko/tools/bcbio/genomes/Hsapiens/GRCh37/vcfanno/GRCh37-rnaedit.conf variation/combined.vcf | bgzip -c > variation/tx/tmpYNxXPd/combinedrnaedit-annotated.vcf.gz

This is throws an error
vcfanno.go:108: [Flatten] unable to open file: /hpf/largeprojects/ccmbio/naumenko/tools/bcbio/genomes/Hsapiens/GRCh37/vcfanno//hpf/largeprojects/ccmbio/naumenko/tools/bcbio/genomes/Hsapiens/GRCh37/vcfanno/../editing/RADAR-GRCh37.bed.gz in /hpf/largeprojects/ccmbio/naumenko/tools/bcbio/genomes/Hsapiens/GRCh37/vcfanno

SN

Hi Rory!
I found that the problem is not in the code, but in the database:
bcbio/genomes/Hsapiens/GRCh37/editing
the file RADAR-GRCh37.bed
should be processed:

remove first line
bedtools sort
bgzip
tabix

After that vcfanno runs, but with errors:
api.go:72: lua-error @ 12:122959771: <string>:2: attempt to index a non-table object(nil)
stack traceback:
	<string>:2: in function 'is_snp'
	<string>:6: in main chunk
	(tailcall): ?
	[G]: ?

in the result it annotates only a few indels (why indels?) with:
possible_rnaedit=err:<nil>

Not a problem for me  - I still can remove RNAediting events with bedtools, but this problematic
step does not allow the pipeline to finish correctly (empty final folder).
SN

Hi Sergey,
Sorry about that. If you do a data update, you should get a new version of the RADAR data that is sorted, zipped and indexed, I should have mentioned that. The err:nil error you are seeing is because the new functionality relies on an unreleased version of vcfanno (https://github.com/brentp/vcfanno). I'll bug brent to push a release so we can get that up to date.

Thanks Rory!
Could you please check the update procedure? I've just updated successfully and I see no changes in the Hsapiens/GRCh37/editing directory.

Hi Sergey,
Hm-- did you do a bcbio_nextgen.py upgrade -u development --data?

It looks like I forgot to bump the version. If you nuke the temporary directory that gets pulled in during the update (its tmp-cbl or something like that), relative to your current-working directory, you should pull down the new RADAR recipe from cloudbiolinux.

Unfortunately the update does not work. I see the correct RADAR.yaml in the temporary folder during the installation but the editing folder does not change. I tried also to remove the editing folder and RADAR string from versions.csv - did not help.
The upgrade command is
bcbio_nextgen.py upgrade  -u development --data

Not on the list?
INFO: List of genomes to get (from the config file at '{'install_liftover': False, 'genome_indexes': ['bwa', 'bowtie2', 'rtg', 'star'], 'genomes': [{'annotations': ['GA4GH_problem_regions', 'MIG', 'prioritize', 'dbsnp', 'hapmap', '1000g_omni_snps', 'ACMG56_genes', '1000g_snps', 'mills_indels', 'clinvar', 'cosmic', 'ancestral', 'qsignature', 'transcripts', 'mirbase'], 'validation': ['giab-NA12878', 'giab-NA24385', 'giab-NA24631', 'dream-syn3', 'dream-syn4'], 'name': 'Human (GRCh37)', 'dbkey': 'GRCh37'}, {'validation': ['platinum-genome-NA12878', 'giab-NA12878-remap', 'giab-NA12878-crossmap', 'dream-syn4-crossmap', 'dream-syn3-crossmap'], 'name': 'Human (hg38) full', 'dbkey': 'hg38', 'annotations': ['coverage', 'prioritize', 'dbsnp', 'hapmap_snps', '1000g_omni_snps', 'ACMG56_genes', '1000g_snps', 'mills_indels', '1000g_indels', 'clinvar', 'qsignature', 'transcripts']}, {'name': 'Mouse (mm10)', 'dbkey': 'mm10', 'annotations': ['problem_regions', 'dbsnp', 'transcripts', 'mirbase']}, {'name': 'Arabidopsis thaliana (TAIR10)', 'dbkey': 'TAIR10', 'annotations': ['mirbase']}], 'install_uniref': False}'): Human (GRCh37), Human (hg38) full, Mouse (mm10), Arabidopsis thaliana (TAIR10)

Hi Sergey,
Thanks for debugging, sorry about that. The cloudbiolinux issue was twofold: 1) RADAR was turned off and 2) the ggd recipe had some formatting issues. It looked like it was working for me because it didn't throw an error because it was turned off and I already had the tabixed files in that directory from testing. It should be all good now.

Thanks Rory, now it updates! Running GGD recipe: RADAR-GRCh37

Great! Thanks, sorry for how long it took.

vcfanno just got a new version, I'll update the bioconda recipe and after that this all should be working cleanly.

Great! I will calculate RNA-seq variant calling precision then and we hopefully will have a nice estimate!

Thanks a lot Sergey, happy to incorporate any other changes that seem like they will help. We haven't done too much RNA-seq variant calling work so your input is super helpful.

Hi Rory! Could please help me with this issue? I am completely stuck with it. https://github.com/chapmanb/bcbio-nextgen/issues/1546
SN

Hi Rory!
Sorry, I will bother you again with RNA-seq pipeline.
I'm running validation of RNA-seq variant calling with SRR307898 which is RNA-seq of NA12878
on the latest update of bcbio.
In the final/project/combinedrnaedit-annotated.vcf.gz
I have 178,994 variants, and
only 24 of them have possible_rnaedit annotation. They all are deletions and the annotation looks like 'possible_rnaedit=err:'. Sounds like a bug, eh?
When checking against the RADAR database I see much more.
bedtools intersect -a combinedrnaedit-annotated.vcf.gz -b ~/work/tools/bcbio/genomes/Hsapiens/GRCh37/editing/RADAR-GRCh37.bed.gz | wc -l
24764

For now I can filter with bedtools, but if you could fix the code to do RNAedit annotation properly, it would be of great help.
Thanks,
Sergey

Hi Sergey,
Huh-- let me see if I can reproduce with SRR307898 and get back to you.

Thanks Sergey, I tracked this down to vcfanno not supporting the way we were specifying the BED file. I fixed the RADAR BED files and it should work now, will test on your test dataset.

Thanks Rory for you work, now rna-seq pipeline annotates rna_editing events well!
Could you please check this 2PASS STAR issue if you have time: https://github.com/chapmanb/bcbio-nextgen/issues/1629


fix(circleci): unbreak plugin

Hey, I just made a Pull Request!
The CircleCI Plugin build info page got broken. Fixed it.
:heavy_check_mark: Checklist

[x] All tests are passing yarn test
[ ] Screenshots attached (for UI changes)
[ ] Relevant documentation updated
[x] Prettier run on changed files
[ ] Tests added for new functionality
[ ] Regression tests added for bug fixes

Could you please elaborate on what the problem was? Not quite sure what these changes are aimed towards

Not really. I had to choose between a quick fix and actual deeper investigation of the problem. Superficially the routing wasn't hitting the build page and was showing an empty page. I couldn't figure out why.


Fix unexpected websocket handshake failure degrading into infinite loop

Summary
The test suite (reasonably) presumes that websocket handshaking will succeed during testing. When it does not, the test suite gets (vocally) stuck in Mojo::IOLoop indefinitely. This change handles this edge case correctly, just resulting in failed tests.
The only known instance of this failure is when proxied HTTP connections are intercepted by local network security software and cause the handshaking to fail. This makes the behaviour unlikely to occur and may not be worth the cost to the codebase.
Motivation
The test suite failing into an infinite loop would appear to be unacceptable behaviour outside of unmitigatable failure such as malfunctioning RAM.
References
This PR has an alternative PR which implements the same fix in a different way (minimises line count).

Afraid i have to vote 👎, the described scenario is just too much of a fringe case.

Would there be any reasonable way to bail out of the test early if the OS breaks websockets? Some quick check near the top of the test script?

You could put in a test that checks that websocket tx's are being returned for proxied requests at the start and BAIL_OUT if not.
# Test websocket handshakes over proxy
$ua->proxy->http("http://<IP_ADDRESS>:$port");
my $got_websocket = undef;
$ua->get(
  'http://example.com/proxy' => sub {
    my ($ua, $tx) = @_;
    $got_websocket = $tx->is_websocket;
    Mojo::IOLoop->stop;
  }
);
Mojo::IOLoop->start;
ok $got_websocket, 'Websocket gotten' or BAIL_OUT('Proxied websocket handshaking failed');

As the concern is getting stuck in IOLoop, could IOLoop can have a timeout instead? This would have the benefit of protecting against other cases where you can get stuck in IOLoop, but would also require all instances of Mojo::IOLoop->stop to be replaced with Mojo::IOLoop->reset? Something like this:
# Proxy WebSocket
$ua = Mojo::UserAgent->new;
$ua->proxy->http("http://<IP_ADDRESS>:$proxy");
my $result = undef;
$ua->websocket(
  "ws://<IP_ADDRESS>:$port/test" => sub {
    my ($ua, $tx) = @_;
    $tx->on(finish => sub { Mojo::IOLoop->reset });
    $tx->on(message => sub { shift->finish; $result = shift });
    $tx->send('test1');
  }
);
_ioloop_timeout(5);
is $connected, "<IP_ADDRESS>:$port", 'connected';
is $result,    'test1test2',      'right result';
ok $read > 25, 'read enough';
ok $sent > 25, 'sent enough';

sub _ioloop_timeout {
  Mojo::IOLoop->timer(5 => sub { shift->reset });
  Mojo::IOLoop->start;
}

Or if it would be useful elsewhere, IOLoop could track the timer id and remove it whenever the loop is stopped, so you could just do this:
Mojo::IOLoop->start(timeout => 5);

But running the IOLoop for (up to) a certain amount of seconds seems to be pretty specific to preventing getting stuck in testing.

It may be worth mentioning that one of the rules governing Mojolicious is this:

The installation process should be as fast and painless as possible. (Less than a minute on most common hardware is a good rule of thumb)

As the installation process usually involves running the test suite which may fail (after all, that is the point of running it before installing), a failing test suite should also be as fast and painless as possible. An infinite loop caused by the lack of a check would seem to violate this rule.
With this in mind, should I raise an issue to deal with this in a general sense, so it isn't tied to this specific PR?

Afraid it looks like this pull request did not pass the vote.


Start-WBBackup + Exchange 2019 not clearing logs

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
ENV

Exchange Server 2019
running on Server 2019,
Circular logging not enabled
PS 7.4.3 (whichever version is currently issued via Windows Update)

Command
Start-WBBackup
Issue
When I back up servers running Exchange 2019, the logs are not being flushed when a successful backup is completed.  If I run Windows Ses]rver backup in the same setup, it flushes the log files.
Function
# PURPOSE: Start-AssembleAndExecuteBackup - Assembles the required commands and values and executes the backup
function Start-AssembleAndExecuteBackup {
    try {
        $Policy = New-WBPolicy
        $BackupLocation = New-WBBackupTarget -NetworkPath "$NetworkFQTarget"

        Add-SeperatorLineToLog
        Add-UpdateLogWithSingleLine "L" "CREATED OBJECTS" ""
        Add-UpdateLogWithSingleLine "R" "Objects" "Policy, VolumeList, and Backup Target Location"

        Add-WBSystemState $Policy
        Add-WBBareMetalRecovery $Policy
        Add-WBBackupTarget -Policy $Policy -Target $BackupLocation
        Set-WBVssBackupOptions -Policy $Policy -VssCopyBackup

        Add-SeperatorLineToLog
        Add-UpdateLogWithSingleLine "L" "STARTING BACKUP" ""

        if ($str_Testing -eq "ON") {
            Add-UpdateLogWithSingleLine "R" "Backup Testing Mode" "ON (No backup performed)"
        } else {
            Add-UpdateLogWithSingleLine "R" "Email" "Email Notification Sent"
            Start-WBBackup -Policy $Policy -Verbose
        }
    } catch {
        Write-Error "An error occurred: $_"
        Add-UpdateLogWithSingleLine "E" "Backup Error" "$($_.Exception.Message)"
    }
}

Expected behavior
The log files should be cleared once a successful backup completes

Actual behavior
Logs remain unflushed, no errors a reported by PS or Event Log

Error details
[22:23:33] COMPLETION STATUS                  :
[22:23:33]                              Email : Email Notification Sent
[22:23:33]                           Job Type : Backup
[22:23:33]                         Start Time : 26/09/2024 9:01 PM
[22:23:33]                           End Time : 26/09/2024 10:23 PM
[22:23:33]                          Job Items : Microsoft.Windows.ServerBackup.Commands.WBItem[]
[22:23:33]                          Job State : Completed
[22:23:33]                  Current Operation :
[22:23:33]                            HResult : 0
[22:23:33]                    Detailed Result : 0
[22:23:33]                        Error Descr :
[22:23:33]                                    :
[22:23:33]                         Version ID : 09/26/2024-11:01
[22:23:33]                     SuccessLogPath : C:\Windows\Logs\WindowsServerBackup\Backup-26-09-2024_11-01-48.log
[22:23:33]                     FailureLogPath : C:\Windows\Logs\WindowsServerBackup\Backup_Error-26-09-2024_11-01-48.log
[22:23:33]                   Data Transferred : C:\Windows\Logs\WindowsServerBackup\Backup_Error-26-09-2024_11-01-48.log
------------------------------------------------------------------

Environment data
Name                           Value
----                           -----
PSVersion                      7.4.3
PSEdition                      Core
GitCommitId                    7.4.3
OS                             Microsoft Windows 10.0.17763
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visuals
Nil to provide

The command in question isn't being maintained in this repository.
Please follow the guidance in Can Windows/Non-Core Powershell 5 bugs be reported here? to determine the appropriate place to report your issue.
If you end up creating an issue in the Feedback Hub, please share a link to it here.


Fixes 11924 : Add pgspider support

Describe your changes:
I created feature request #11924 and then this PR #11925 which adds a new PGSpider connector.
However, the @ulixius9 of the PR advised me that it would be better to create PGSpider as a sub-module of the Postgres connector.  In this PR, I followed his advice and implemented it.
This change adds the pgspider scheme to the postgres connector.

Services created with this pgspider scheme can import metadata from PGSpider.
The metadata that can be ingested is the data that the Postgres connector can ingest from Postgres, plus Lineage information from PGSpider's multi-tenant tables and foreign tables.
https://github.com/open-metadata/OpenMetadata/pull/11925#pullrequestreview-1474460573

Type of change:

[ ] Bug fix
[x] Improvement
[ ] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

Checklist:

[x] I have read the CONTRIBUTING document.
[x] My PR title is Fixes <issue-number>: <short explanation>
[x] I have commented on my code, particularly in hard-to-understand areas.
[x] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

[x] I have added tests around the new logic.
[ ] For connector/ingestion changes: I updated the documentation.

Thanks @megumiie! This LGTM, appreciate the changes. I think there are some checkstyle errors that you could, you can try it with py_format_check.
We'll bring this in after the release is done.
Thanks
cc @ulixius9


Add velocity to gripper command

Many robot grippers support effort, position, and velocity controls. The current technique to set the velocity involves reading a hardcoded value from the URDF. This is problematic when the user wants to change the gripper velocity at runtime. I propose a new gripper action message that supports a target_velocity field.
This PR is related to the controller developed in https://github.com/ros-controls/ros2_controllers/pull/1002

@MarqRazz  Okay, I removed the extra fields from the feedback topic and updated the comments

@mergifyio backport to humble


Data Descriptor Lost UncompressedSize

Steps to reproduce
1.Use ZipFile open android apk file
2.Do some Update
3.Data descriptor  UncompressedSize is wrong
4.ZipFile.TestArchive(true) is return false
Expected behavior
It is equal ZipEntry's Size
Actual behavior
It is 0x504B0304
Version of SharpZipLib
0.85, 0.86
Obtained from (place an x between the brackets for all that apply)

[-] Compiled from source

branch: master
commit: _______

[ .] Downloaded DLL from GitHub
[ ] Downloaded DLL from SourceForge
[ ] Downloaded DLL from _______
[ ] DLL included as part of
Package installed using:

[ ] NuGet
[ ] MyGet
[ ] Chocolatey

example of a unit test that looks to hit the issue (or something very similar at least):
[Test]
[Category("Zip")]
public void TestDescriptorUpdate()
{
    MemoryStream msw = new MemoryStreamWithoutSeek();
    using (ZipOutputStream outStream = new ZipOutputStream(msw))
    {
        outStream.UseZip64 = UseZip64.Off;
        outStream.IsStreamOwner = false;
        outStream.PutNextEntry(new ZipEntry("StripedMarlin"));
        outStream.WriteByte(89);

        outStream.PutNextEntry(new ZipEntry("StripedMarlin2"));
        outStream.WriteByte(91);
    }

    var zipData = msw.ToArray();
    Assert.IsTrue(ZipTesting.TestArchive(zipData));

    using (var memoryStream = new MemoryStream(zipData))
    {
        using (var zipFile = new ZipFile(memoryStream, leaveOpen: true))
        {
            zipFile.BeginUpdate();
            zipFile.Delete("StripedMarlin");
            zipFile.CommitUpdate();
        }

        memoryStream.Position = 0;

        using (var zipFile = new ZipFile(memoryStream, leaveOpen: true))
        {
            Assert.That(zipFile.TestArchive(true), Is.True);
        }
    }
}

i tried debugging the zipfile update, and i'm wondering if there is an issue in the GetDescriptorSize function in ZipFile:
private int GetDescriptorSize(ZipUpdate update)
{
    int result = 0;
    if ((update.Entry.Flags & (int)GeneralBitFlags.Descriptor) != 0)
    {
        result = ZipConstants.DataDescriptorSize - 4;
        if (update.Entry.LocalHeaderRequiresZip64)
        {
            result = ZipConstants.Zip64DataDescriptorSize - 4;
        }
    }
    return result;
}

Where I don't know what those -4s are for?
The test passes if those are removed, so i'm not sure if the issue isn't just that it's slicing the end off the descriptor when doing the update?
(though i'm not sure if there should really be a descriptor there after the update at all, given that the size fields for the entry are known at this point)

Actually, posted that and then saw the

comment in CopyEntryDirect, which sounds a tad suspicious given that GetDescriptorSize takes 4 bytes off the size.


Revert "Add BART for sequence classification (#134)"

Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Make get_components_without_identifiers() more concise

I saw an opportunity to make get_components_without_identifiers() without sacrificing clarity. In fact, the clarity might be slightly more!

Thank you, @goneall!


[NEW ALGORITHM] DBSCAN (Density-Based Spatial Clustering of Applications with Noise)

Issue will be closed if:

You mention more than one algorithm. You can create a separate issue for each algorithm once the current one is completed.
You propose an algorithm that is already present or has been mentioned in a previous issue.
You create a new issue without completing your previous issue.

Note: These actions will be taken seriously. Failure to follow the guidelines may result in the immediate closure of your issue.

Name:
[DBSCAN (Density-Based Spatial Clustering of Applications with Noise)]
About:
DBSCAN (Density-Based Spatial Clustering of Applications with Noise) is a popular clustering algorithm that groups data points based on their density and proximity to each other. It is particularly effective in discovering clusters of arbitrary shapes and handling noise in the data.
Key Concepts:
Density-Based Clustering: DBSCAN relies on the concept of density to identify clusters. It assumes that clusters are regions of high point density separated by regions of low density.
Core Points: A point is considered a core point if it has at least a minimum number of points (MinPts) within a specified radius (ε).
Border Points: A point is a border point if it is not a core point but is within the ε-neighborhood of a core point.
Noise Points: Points that are neither core nor border points are classified as noise or outliers.
Labels:
new algorithm, gssoc-ext, hacktoberfest, level1

Assignees:

[x] Contributor in GSSoC-ext
[x] Want to work on it

do not create unnecessary issues


ecnu

East China Normal University

the university's website is http://www.ecnu.edu.cn/ - please fix the path correctly

Closing till the answer comes


chore: enable build caching

This causes cmake to set the build directory to package/build/<wheel_tag>, which gets reused if you build again. Moving paths due to build isolation will automatically be corrected by scikit-build-core.
If you want to go all out, try:
pip install nanobind scikit-build-core[pyproject]
pip install --no-build-isolation -Ceditable.rebuild=true -ve .

Then make a C++ change, then open Python and import the project. ;)

Beautiful, thank you!


Add Myself

Thanks for adding your profile 👍 - I made a small comment, then I can merge it 🤓

Looks good 👍


fix(connector): fix start_offset and empty range

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
fix:

process start offset correctly
check empty range correctly

Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
Refer to a related PR or issue link (optional)

This PR is included in #7150


Default ListPreference Does Not Show on First App Run (Dev)

This is some weird bug where the default value for the preference will not show at first run. Possible fix here:
https://stackoverflow.com/questions/7342557/listpreference-default-value-not-showing-up

fix, one line from SO, 1 minute


Fix the names of ChaCha20-Poly1305 cipher suites in t1_trce.c.

Per RFC 7905, the cipher suite names end in "_SHA256". The original
implementation targeted the -03 draft, but there was a -04 draft right
before the RFC was published to make the names consistent.

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

Pushed. Thanks.


[T4A3][W15-A2] Wang Ce

ready for review

Some comments added. Feel free to add more comment if you have any questions. Once you are done, you may close the PR after reading comments.


Add Range streaming Interface

Range interface gives the stream that iterates through the sequence of given ints.
Examples:
Range(10, 20)
| Map(Then([](int x){ return x + 5; }))
| Collect<std::vector<int>>

(But actually, please give @benh a chance to take a look before you check it in 🙂 )


dbeaver/pro#148 sql editor hide statistics

Acceptance criteria:

[x] If there are multiple results with result sets and the option is enabled, the statistics tab is shown
[x] If there are multiple results with result sets and the option is disabled, the statistics tab is not shown
[x] If there are no results, the statistics tab is always shown
[ ] IMPORTANT When refreshing a tab that has tabs after it, they remain open (#19839)

verified


Server Profile Template connections broken with API 500+

API version 500 and up have a new field named connectionSettings that now contains the connections field used on the Server Profiles deployed from the template.  This makes it impossible to configure connections on server profile templates with newer API versions from Terraform.
Now that https://github.com/HewlettPackard/oneview-golang/pull/140 is merged, it should be possible to fix here.

@adarobin
Is there a status for this issue? Using the latest version of OneView 4.2 with api version 1000. Thanks.

@5mzJyf6m I don't work for HPE, but I would love to have this working in my environment too :-)
It appears that API 800 support may be added in the near future looking at #82 .  Perhaps @jyothis-gireesan can provide some insight.

@adarobin @5mzJyf6m
Hi,
This had been addressed for APIs grater than API 600.
Let me know if you have any questions before we close this issue.
Thanks.


find controller name

it would be very nice to get the controller name from the scope.

Batarang now shows controller names in the scope tree.

Is there any way to show controllers names injected by ngRoute ? I only see the scope id of the controller.

@fonzarely Sounds like a good candidate for a new issue - haven't tried that before.

Ok, i'll make one. thx

I am on<EMAIL_ADDRESS>I don't see controller name in the Scope Tree, or on the Model panel on right side. Am I missing something?


Pretrained Model for ModelNet and ShapeNetPart

Could you please also provide pretrained model for ModelNet and ShapeNetPart?

I am sorry but I cannot do it right now. I am focused on other projects. There should be a new version of the code in Pytorch soon, and I will try to release more pretrained models


Carousel example not changing slides with swipe

Software Versions

Python: 3.8.10
OS: Linux Mint 20.1
Kivy: 2.1.0.dev0 (08.11.2021)
Kivy installation method: Installed from sources from git using pip

Describe the bug
After running carousel example here I'm not able to use swipe motion to change slides.
Expected behavior
Horizontal swipe motion allows to change slides on carousel widget.
To Reproduce

Using lastest sources run example carousel_buttons.py
Use horizontal motion (left/right) to change slides.

Code and Logs and screenshots
For code reference above links to repo.
https://user-images.githubusercontent.com/20884974/140827737-be6f7041-5e7c-4173-a0f7-b347d70b0eaf.mp4
Additional context
Add any other context about the problem here.

I'm also a Linux Mint user, and the example is working fine here.

Python 3.8.12
OS: Linux Mint Mate Edition 20.2
Kivy: 2.1.0.dev0 43dc1cee8720ef46a383632da34a0bb101b92e02 (2021 Nov 19)
Kivy installation method: clone the master branch -> build from source

Retested - Working.


Update lammps.cyg

Lammps build in GNU environment

Does lammps not build with the Cray and Intel PrgEnv?

David, LAMMPS has got several packages which are built (being built) in gnu, and they use CFLAGS which are specific for GNU. If we use GNU by default it might compile any new package without any issue.
With Cray and Intel, we need to change cyg file every now and then for each new package.


[Bug]: Warning log error for application form permissions

ODC version
odc431
OB version

What happened?

What did you expect to happen?
Warning log is empty
How can we reproduce it (as minimally and precisely as possible)?
Execute application form permissions and view alarm logs
Anything else we need to know?
No response

pass


bootstrap details

Docs PR Template
Why this should be merged

How this works

How these changes were tested

To prevent any errors while building

[] run vale /docs/file/path on all changed .md files to ensure all grammar rules pass
[] run markdownlint /docs/file/path on all changed .md files to ensure all linting rules pass
[] complete the above two checks and all additional rules outlined in style-checker-notes.md to
ensure all checks pass

If a document was removed/deleted

[] the path to that doc must be redirected to a valid URL via the
_redirects file
[] _redirects were manually verified with the cloudflare preview link
[] sidebars.json reflects all changes made to file path

If a document was moved

[] all files that were moved from their current directory to a new path have had their paths
redirected via the _redirects file
[] _redirects were manually verified with the cloudflare preview link
[] sidebars.json reflects all changes made to file path

merged with translation warnings because the page wasn't initially translated to spanish


Replace rich progress bar to tqdm progress bar

All Submissions:
Type of change
Please delete options that are not relevant.

[ ] New feature (non-breaking change which adds functionality)

New Feature Submission:

[ ] Does your submission pass the tests?
[ ] Have you linted your code locally prior to submission?

Changes To Core Features:

[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your core changes, as applicable?
[ ] Have you successfully ran tests with your changes locally?

Description
This commit replaces the Rich progress bar implementation with TQDM #3487. The following changes were made:

Replaced Rich Progress Bar:

Updated the _zip function to use TQDM for progress bar handling.
TQDM is now responsible for displaying progress during zipping operations, providing a simpler and lighter alternative to Rich.

Preserved Pretty Printing with Rich:

Retained the use of rich.console for pretty printing logs and outputs to maintain readability and formatting in the console.

Updated Dependencies:

Added TQDM to pyproject.toml as a dependency.

Okay

i pushed a fix for the merge conflict here... but i think there are some other issues we need to resolve here before we can take this change.

update the dependency review CI job to accept the MIT / APL-2.0 license... unfortunately these combo licenses need to all be added in the workflow
this adds a new dependency but doesn't actually remove the rich dependency as specified by #3487

i'm hesitant to take the new dep without fully removing the old dep

We can use the termcolor (wheel size - 12.7KB source and built distribution 7.7KB) instead but for prompts (that uses rich too) that ask for what kind of template are you building. Or maybe select your region for deployment. I found an alternative born as an inquirer on PyPI (14.5KB). The tqdm is about 169.4KB on the source and 78.3KB on the built distribution.

It appears tqdm lacks necessary features such as colored text support and interactive prompts, so I left that part of the rich lib to handle it

It appears tqdm lacks necessary features such as colored text support and interactive prompts, so I left that part of the rich lib to handle it

Use termcolor and inquirer python

Okay

1. update the dependency review CI job to accept the MIT / APL-2.0 license... unfortunately these combo licenses need to all be added in the workflow

  The following dependencies have incompatible licenses:
  poetry.lock »<EMAIL_ADDRESS>– License: MIT AND MPL-2.0
  pyproject.toml »<EMAIL_ADDRESS>– License: MIT AND MPL-2.0
  Error: Dependency review detected incompatible licenses.

The dependency review failure is with MPL-2.0 license not APL-2.0. Note, that MPL is a copyleft license, so the maintainers should consider whether this might affect stakeholders. Might not be for most, but some enterprises steer clear of anything copyleft.
Here's a nice FAQ on MPL:
https://www.mozilla.org/en-US/MPL/2.0/FAQ/
Also, the fix is simply, just add MPL-2.0 to the allow list.


Support for LLaMA-2 70B with Grouped-Query Attention

Due to the Grouped-Query Attention introduced in LLaMA-2 70B，llama issue，it cannot be loaded into the collie implementation of LLaMA. Hope LLaMA-2 70B can be support in collie. Thanks
Traceback (most recent call last):
  File "/nvme1/gptdata/share1/projects/collie/examples/download.py", line 49, in <module>
    model = LlamaForCausalLM.from_pretrained(model_name, config=config)
  File "/nvme1/gptdata/share1/app/mambaforge/envs/collie/lib/python3.9/site-packages/collie/models/base.py", line 306, in from_pretrained
    state_dict = cls.load_parallel_state_dict(
  File "/nvme1/gptdata/share1/app/mambaforge/envs/collie/lib/python3.9/site-packages/collie/models/llama/model.py", line 414, in load_parallel_state_dict
    part_state_dict[key] = rearrange(
RuntimeError: shape '[8192, 8192]' is invalid for input of size 8388608

I got the same error for LLaMa2 70B

@kaiwang13 Could you please share how you resolved the issue?

@kaiwang13 Could you please share how you resolved the issue?

Just uninstall the old version and install the latest one from source code.

I just cloned the repo and installed it from the main branch. But I'm still facing the error. Do I need to install it from any specific branch?

Remove https://github.com/OpenLMLab/collie/blob/c9cc0055a52b96d156450b5734a0a1d0dbde4562/collie/models/llama/model.py#L425C1-L432C64

This resolved the issue of the shape error. But now it seems offloading to CPU memory and the process get killed because of CPU overloading. I have 450 GB of CPU memory and 4*A100 80 GB. I'm using the LOMO optimizer. Is this expected for LOMO?

This resolved the issue of the shape error. But now it seems offloading to CPU memory and the process get killed because of CPU overloading. I have 450 GB of CPU memory and 4*A100 80 GB. I'm using the LOMO optimizer. Is this expected for LOMO?

What I did cannot solve the problem. The pretrained state dict cannot be loaded for training without thos code.

okay, so is there any suggestion to solve the problem?

This resolved the issue of the shape error. But now it seems offloading to CPU memory and the process get killed because of CPU overloading. I have 450 GB of CPU memory and 4*A100 80 GB. I'm using the LOMO optimizer. Is this expected for LOMO?

What I did cannot solve the problem. The pretrained state dict cannot be loaded for training without thos code.

Do  you mean that the error occurs when loading pretrained state dict? Could you please show the error log?
Sorry for the late reply

I was testing this with the main branch. While loading the state dict, the CPU is taking around 550GB. Yesterday I tried that in a larger instance with 900GB CPU and it go some shape error during the train start as @kaiwang13 mentioned. I don't have access to that machine right now to share the log.
However, yesterday I tested the dev branch as well. In the dev branch, the CPU was taking only around 150GB. But there, I was getting OOM while saving the checkpoint after the first epoch. You can check issue #98 about this.
Let me know if these info is enough for you to proceed further

I was testing this with the main branch. While loading the state dict, the CPU is taking around 550GB. Yesterday I tried that in a larger instance with 900GB CPU and it got some shape error during the train start as @kaiwang13 mentioned. I don't have access to that machine right now to share the log.
However, yesterday I tested the dev branch as well. In the dev branch, the CPU was taking only around 150GB. But there, I was getting OOM while saving the checkpoint after the first epoch. You can check issue #98 about this.
Let me know if this info is enough for you to proceed further

Thanks for your information! llama-v2 is not updated to main branch yet, so it is normal to raise errors in main branch.
We will test the process of saving checkpoint later. Does OOM occur when using zero3 and LOMO when saving checkpoint?

Yes, I was using zero3 and LOMO. And I was getting GPU OOM while saving

Yes, I was using zero3 and LOMO. And I was getting GPU OOM while saving

Thanks a lot! We will try to fix it

@dittops @x54-729 Additionally, I tried training llama1-33b with a sequence length of 2048 and a batch size of 1 using AdamW with zero3 on 8xA100 80G. The training process went fine, but I encountered OOM when attempting to save the model.

We've found that the OOM problem is due to the parameter gathering process with DeepSpeed's API. And we plan to fix it by gathering parameters on CPU (or NVMe).

@x54-729 Please let me know if you have pushed any updates on this to the dev branch. I can try it out.

@x54-729 Please let me know if you have pushed any updates on this to the dev branch. I can try it out.

Hi, the bug is fixed in dev branch, maybe you can have a try.
FYI: https://github.com/OpenLMLab/collie/commit/82869ee41200502ea5144416c9d0035e10b3ef27 https://github.com/OpenLMLab/collie/commit/ac6eed4038e114d0482de14f7aff952817d6b381

I have tested the code. I was able to train and save the model.
I was testing by training a small dataset that contains the identity(English) of the model. But on inference, the model started generating Chinese instead of English while generating text related to identity.
I was using 70B + LOMO + Stage 3 + transformer-4.32.1
Any thoughts on what could be the issue here?


🐛 Fix compatibility issues with Node.js 12.x

Some deprecated function calls had been removed in the Node.js V8 APIs, so needed to upgrade those.
Resolves #32 and #50 by providing a native C implementation (1.x) compatible with Node.js 12.x.

:package: Upgraded the nan package, which resolved some transitive compatibility issues.
:bug: Replaced deprecated+removed GetFunction() calls with GetFunction(context).ToLocalChecked().
:bug: Replaced deprecated+removed ->ToInt32Value() call with .As<Int32>()->Value().

This PR intends to introduce no functional changes. It serves only to contain compatibility fixes specifically for the 1.x implementation, so upon merge would result in a patch version increment of that branch to 1.2.3.
To support this, a new v1.x branch has been created, to which this PR aims to be merged. This affects only the native C implementation, so no changes are needed on the master (2.x) branch.
References:

V8 Reference
nan

Ignore the CircleCI build error -- the 1.x branch does not have a CircleCI configuration.

:bulb: In fact, neither does 2.x, but even though org-level admin privileges are not necessary to start building a project to CircleCI, they are necessary to stop building the project.

cc @davidmurdoch and @bytezantium, who reported the 12.x compatibility issue. The steps in this comment, when used with version 1.2.3 (after this PR is merged and the resulting version is published), should serve as a workaround for web3 installation issues until other packages have had a chance to update their versions.

Given that this issue is actively blocking some web3 users, I'm going to go ahead and merge this to push a v1.2.3 release. I'll continue to monitor for any emergent issues, and if anything comes up, v1.2.2 and v2.0.2 are still available.


Bump build number

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

To fix https://github.com/conda-forge/r-userfriendlyscience-feedstock/pull/3

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Simple objects offset if saving/copying structure as image

Ketcher Version
Ketcher v2.4.2-123-g5fe7118b
Steps to Reproduce

Launch Ketcher
Create structure on canvas or load through "Open..." functionality (.ket file in .zip archive attached) or from templates
ketcher_simples.ket.zip
Draw several simple objects through "Shape Ellipse", "Shape Rectangle", "Shape Line" and "Add Text" functionality (attached file already contains simple objects)
Select the whole canvas using "Lasso tool" or Cmd/Ctrl+A shortcut
Save structure as image
5.1. Using "Copy as Image" functionality (upper toolbar, "Copy..." icon dropdown) and paste into MS Word
5.2. Using "Copy as Image" shortcut Cmd/Ctrl+Shift+F and paste into MS Word
5.3. Using "Save" functionality with PNG format.
5.4. Using "Save" functionality with SVG format.
Compare image (in MS Word or opened from file system) to structure and objects on canvas

Expected behavior
Image accords to structure and objects on canvas
Actual behavior
Simple objects on resulting image offsets from structure.
Screenshots
Canvas

Image

User agent:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7)
AppleWebKit/537.36 (KHTML, like Gecko)
Chrome/99.0.4844.51
Safari/537.36

Related issue in Indigo
epam/indigo#689


Allow passing React components as matchElement

This fixes a warning related to prop-types in development and closes https://github.com/helior/react-highlighter/issues/55.
Reference: https://github.com/facebook/react/issues/5143#issuecomment-147473269
typeof SomeClassBasedComponent is also a function, so we cover both functional and ’normal’ components (as well as strings such as "div"). At the same time, passing <SomeComponent /> (i.e. element instead of just component name) will still trigger a warning.

@helior WDYT?

Thanks @kachkaev

Thank you for cutting a new release – I see no PropTypes warning in 0.4.3 🎉


eos_validate_state role whitelist transceiver vendors

Issue Type

[ ] Template enhancement
[x] Role enhancement
[ ] Documentation enhancement (avd.sh)

Is your feature request related to a problem? Please describe.
We are using 3rd party optics with a verified vendor from our point of view. eos_validate_state role  reports "transceivers manufacturers" as FAIL.
Describe the solution you'd like
Make it possible to whitelist vendors via a variable.
Describe alternatives you've considered
Additional context
Add any other context or screenshots about the feature request here.

role:  eos_validate_state
task: hardware.yml

current code
- name: Gather transceivers inventory
  eos_command:
    commands: "show inventory | json"
  register: inventory
  tags:
    - hardware

- name: Validate transceivers manufacturers
  assert:
    that:
      - "xcvrSlot.value.mfgName in ['Not Present', 'Arastra, Inc.', 'Arista Networks']"
    fail_msg: transceivers manufacturers is "{{ xcvrSlot.value.mfgName }}"
    quiet: true
  loop: "{{ inventory.stdout_lines.0.xcvrSlots | dict2items }}"
  loop_control:
    loop_var: xcvrSlot
  ignore_errors: "{{ eos_validate_state_validation_mode_loose }}"
  register: transceiver_inventory_results
  tags:
    - hardware

So this task reports transceivers that are not in this list:

'Not Present'
'Arastra, Inc.'
'Arista Networks'

The above test is hardcoded in the task.
It can be moved in a variable (defined in the role/default/main.yml).
The default value of this list will be the same.


Simulator visualisation improvements

This PR is based on some hackday work on the autoscaler simulator. The primary goal was to improve the visualisation. A secondary outcome was some refactoring and speedup work.
The key changes:

CombinedScenario has been broken into step, ramp and sinusoidal scenarios. Common logic has been pulled up.
Scenarios are run in separate goroutines.
Scenario results are shown in a 3x1 multiplot, instead of on a single plot.

@jchesterpivotal Life's too short. Please show me the graphs. ;-)

Good point, I've uploaded a sample.


feat(data-table): support programmatic sorting

This PR adds the sortKey and sortDirection props to allow programmatic sorting.
This also allows the user to set a "default" sorted table without sorting the rows manually.
Usage
By default, the table is not sorted by a specific key. The sortKey value must be a valid key specified in the headers object.
Possible values for sortDirection include "none" or "ascending" or "descending".
Setting sortKey to null and sortDirection to "none" should reset the table rows to their initial order.
<DataTable
  sortable
  sortKey="name"
  sortDirection="descending"
  headers="{headers}"
  rows="{rows}"
/>

Notes
This refactored DataTable and TableHeader to avoid using a Svelte store to maintain state. Instead of passing a store down using setContext, sorting-related props are passed down directly.
As a result, this caused a minor breaking change where disableSorting in TableHeader has been removed.

Released in v0.65.0

This feature changed the sorting behavior, is this intended?

For example:
Click Name -> Sort by Name ASC
Click Port -> Sort by Port ASC
Click Port -> Sort by Port DESC
Click Name -> Sort by Name ASC
Now:
If you click on a column, the sortDirection of the previous sorted column gets cycled.
For example:
Click name -> Sort by Name ASC
Click Port -> Sort By Port DESC
Click Name-> No Sorting
I think the old behavior is more intuitive.

@chilligerchief This is definitely an unintended regression. Tracking in #1341.


Materials for METAR/Point obs

Tracker for reviewing and enhancing materials for Point observations w/ TDS
This one especially needs some love to make good use of Siphon and get rid of a lot of ugly hand-coding.

Just need to clean up the notebook at this point, but moved over to using siphon (much cleaner now)

Done (commit adc6fd193ea50e43bbaeb328107b947d4b01fa66)


K8SPG-337 update README

add shields to README
change README to have consistency between all our operators

Test name
Status

init-deploy
passed

demand-backup
passed

start-from-backup
passed

monitoring
passed

We run 4 out of 4

commit: https://github.com/percona/percona-postgresql-operator/pull/413/commits/e4133d22cd4609c4a4427a462bfb715d86448e21
image: perconalab/percona-postgresql-operator:PR-413-e4133d22c


fixio.fixprotocol.FieldType is absent

Just cloned from https://github.com/kpavlov/fixio.git. Can't see class fixio.fixprotocol.FieldType in repository.

This class is auto-generated from FIX 5.0 SP2 FIX dictionary from QuickFix
You may find it here: core/target/generated-sources/java/fixio/fixprotocol/FieldType.java


Make collapsible inventory configurable

Exports a boolean is_collapsible on the inventory and uses false as default to make behaviour least surprising (even though many games will probably have this set to true).
Maybe a collapsible inventory should be opened when an item is picked up as well. It's possible to open the inventory from an esc script, but it is inconvenient to couple all pick_ups with explicit opening of the inventory.

Is this PR supposed to fix #98 ?

Yes, in my opinion this is a reasonable fix for #98.

To illustrate easier, I'd integrate a button in the UI to show/hide the inventory since TAB is not straightforward.

Yeah, I think that's a good idea as well, and make it configurable whether it should trigger on click or mouse_entered. I think the most frequently used methods are either a small button in a corner or a mouse aware edge of the screen. This would allow both.

I gave this a quick test run and couldn't find anything disturbing.
To echo what I said on IRC, tab has been used before in games, but currently there's no documentation for UI element interaction nor even that the shortcuts exist.
I opened #125 so they're not forgotten and this can be merged and maybe the UI examples and documentation could come in another PR to not keep this stuff waiting.