Auto completion with PHP doesn't work as expected

Hey here,
I am trying to setup the editor with PHP Language Server (phpactor) and it looks ok but works a bit weird.
The auto-completion doesn't work in the beginning but when I add the first line or character, It starts working fine.
I can provide some code but at this stage I wanted to know if you experienced such behaviour or not.

How do you update the file on the actual filesystem the PHP language server runs on?

@CGNonofr not sure I understood the question, But let me give you more info.
The LSP is being ran by a web socket proxy. from the examples you have in this repo
import { resolve } from 'node:path'
import { runLanguageServer } from './server-runner.js'
import { getLocalDirectory } from './server-commons.js'

const processRunPath = resolve(
    getLocalDirectory(import.meta.url),
    getLocalDirectory(import.meta.url)
)

runLanguageServer({
    serverName: 'PHP',
    pathName: '/',
    serverPort: 8080,
    runCommand: './phpactor',
    runCommandArgs: ['language-server'],
    wsServerOptions: {
        noServer: true,
        perMessageDeflate: false,
    },
})

The rest of the files are a copy from the examples you have here.
and this is how I initiate the editor using the wrapper on my client
await wrapper.init({
                        languageClientConfig: {
                            languageId: 'php',
                            name: 'PHP Language Server',
                            options: {
                                $type: 'WebSocketUrl',
                                url: 'ws://<IP_ADDRESS>:8080',
                            },
                            clientOptions: {
                                documentSelector: ['php'],
                                workspaceFolder: {
                                    index: tab.value.name,
                                    name: 'workspace-' + tab.value.name,
                                    uri: vscode.Uri.parse(`${props.path}`),
                                },
                            },
                        },
                        wrapperConfig: {
                            editorAppConfig: {
                                $type: 'extended',
                                codeResources: {
                                    main: {
                                        text: props.value,
                                        uri: vscode.Uri.parse(
                                            `${props.path}/hello.php`
                                        ),
                                    },
                                },
                                userConfiguration: {
                                    json: JSON.stringify({
                                        'workbench.colorTheme':
                                            'Default Dark Modern',
                                    }),
                                },
                                editorOptions: {
                                    readOnly: props.readonly,
                                    fontSize:
                                        settingsStore.settings.editor.fontSize,
                                    minimap: {
                                        enabled: false,
                                    },
                                    wordWrap:
                                        settingsStore.settings.editor.wordWrap,
                                    theme: settingsStore.settings.theme,
                                    stickyScroll: {
                                        enabled: false,
                                    },
                                    automaticLayout: true,
                                    glyphMargin: false,
                                    scrollBeyondLastLine: false,
                                    lightbulb: { enabled: false },
                                    wordBasedSuggestions: 'off',
                                    suggestOnTriggerCharacters: true,
                                    quickSuggestions: {
                                        other: true,
                                        comments: true,
                                        strings: true,
                                    },
                                    parameterHints: {
                                        enabled: true,
                                    },
                                },
                                useDiffEditor: false,
                            },
                        },
                        loggerConfig: {
                            enabled: true,
                            debugEnabled: true,
                        },
                    })

Also to mention that this is an electronjs application.
Did I answer your question?

And I think yes, the actual filesystem

Exactly, the language server probably expect the file to exist to on the actual filesystem and be sync and to properly receive the willSave/didSave notification

interesting thought,
but still don't understand, after the first line or character, the autocompletion works perfectly fine.
I tried manipulate the document content on the websocket server before sending it to the LSP and didn't work.
Also tried to send textDocument/didChange request after initialization and add a fake first line to see if it initiates the expected auto completions but didn't work either.
It has to be a code change on the editor (like one character) and then works.

The file already exists on the actual filesystem btw.

Closing this, Looks like an issue of the LSP (phpactor) itself.


Feature/insert handlers

Fixes #1
Implemented insert management as a list of insert row handlers (that can be manipulated) where first handler returning true on method CanHandleInsert gets to insert the row. There now are 3 insert row handler:

IdentityInsert: Runs if there is one column that is both primary key and has identity. Uses scope identity to select inserted row
GeneratingInsert: Matches if pk's are set or unset with data types that can be generated or has defaults. Selects inserted row based on primary key values. Will attempt to set any unset primary keys using these strategies:

If column has default value or column is set with RawSql value, value is selected from the database
If column is int/long/short and a row in the table has previously been inserted, new value will be last value + 1
If column is of type uniqueidentifier/nvarchar/varchar/shortint/int/bigint the unique value generator is used to generate a new key

OutputInsert: Can handle any inserts but does not set any primary keys. uses OUTPUT inserted.* to select inserted row. Will disable any DDL table triggers during insert, as OUTPUT statement cannot be used with enabled triggers

TODO:

Figure out if OutputInsert is still needed?
Write tests to make sure each insert row handler works as intendend, especially GeneratingInsert since it has the most complex logic.

I think OutputInsert -handler probably won't be needed, so i removed it from default insert-handlers but left it in the code in case anyone would want to add it


Only clear scale cache if image has changed

The clear_cache method is called every time an ImageModel is saved. This has the side effect of removing scaled images from storage. When run behind a reverse caching proxy the calls to eg. get_image_url are not made on every request, thus the scale is not recreated, resulting in a 404 for the image on the web page.
This simple check fixes it. Initially I thought I would have to compare file contents but this is much simpler.

Coverage increased (+0.08%) to 60.33% when pulling 22dbd1fac0ad40535ab41d5f0794045634c4f9a5 on hedleyroos:master into 2bb2a91073855d7e53c1d4cfb2c704d2ebd7caab on jdriscoll:master.

Coverage increased (+0.08%) to 60.33% when pulling 22dbd1fac0ad40535ab41d5f0794045634c4f9a5 on hedleyroos:master into 2bb2a91073855d7e53c1d4cfb2c704d2ebd7caab on jdriscoll:master.

Hi,
I am currently in the middle of a house move - so rather busy! Might be a few weeks before I can take a look at this, but I will look into it.

Hi Richard. Have you moved house yet? :)

I've moved, but I'm still catching up on work/life. Will get back onto Photologue in a few more weeks.

Hi,
Thanks for the contrib! And my apologies for the delay in merging it.


Try to build LoraServer but error occured

go get github.com/brocaar/loraserver/...
then use commend 'make build' to build from the source code but error occur:
github.com/jmoiron/sqlx
../../jmoiron/sqlx/bind.go:142: undefined: strings.IndexByte
../../jmoiron/sqlx/sqlx.go:603: db.Ping undefined (type *DB has no field or method Ping)
github.com/garyburd/redigo/redis
../../garyburd/redigo/redis/conn.go:97: undefined: net.Dialer
github.com/Sirupsen/logrus
../../Sirupsen/logrus/writer.go:19: method logger.Debug is not an expression, must be called
../../Sirupsen/logrus/writer.go:21: method logger.Info is not an expression, must be called
../../Sirupsen/logrus/writer.go:23: method logger.Warn is not an expression, must be called
../../Sirupsen/logrus/writer.go:25: method logger.Error is not an expression, must be called
../../Sirupsen/logrus/writer.go:27: method logger.Fatal is not an expression, must be called
../../Sirupsen/logrus/writer.go:29: method logger.Panic is not an expression, must be called
../../Sirupsen/logrus/writer.go:31: method logger.Print is not an expression, must be called
../../Sirupsen/logrus/writer.go:41: undefined: bufio.NewScanner
github.com/brocaar/lorawan
../lorawan/phypayload.go:512: function ends without a return statement
github.com/eclipse/paho.mqtt.golang/packets
../../eclipse/paho.mqtt.golang/packets/packets.go:224: function ends without a return statement
github.com/elazarl/go-bindata-assetfs
../../elazarl/go-bindata-assetfs/assetfs.go:141: function ends without a return statement
github.com/rubenv/sql-migrate/sqlparse
../../rubenv/sql-migrate/sqlparse/sqlparse.go:19: undefined: bufio.NewScanner
../../rubenv/sql-migrate/sqlparse/sqlparse.go:20: undefined: bufio.ScanWords
../../rubenv/sql-migrate/sqlparse/sqlparse.go:49: undefined: bufio.NewScanner
github.com/lib/pq
../../lib/pq/conn.go:176: undefined: bufio.NewScanner
github.com/codegangsta/cli
../../codegangsta/cli/context.go:335: function ends without a return statement
make: *** [build] Error 2
anyone has any suggestion？

What OS you're issuing the make build command?
You can issue a uname -a and post the response.

Linux iZ23ny5ud5oZ 3.8.0-44-generic #66~precise1-Ubuntu SMP Tue Jul 15 04:01:04 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
ubuntu 14.04 server

and the response for
go version

go version go1

Say, from your first error that you're receiving

../../jmoiron/sqlx/bind.go:142: undefined: strings.IndexByte

The function strings.IndexByte was added in go version 1.2. So the rest of your issues can be related to that as well.
Update your go to the latest and try again. I am using go1.6 and everything looks to be fine.

thank you very much~~~


Bme280  Bmp080

I have 2 types of sensors, BME280 sparkfun and bmp 080
I am using same i2c lib for both.
The code for both is form the samples provided.
The bmp080 shows data, while bme280 every time the program is restarted shows different data.
They sit side by side:
Bmp080  T: 227       P: 97619
BMe280  T: -2322   P: 110000    H: 100000
Any hints ?

Hi @comarius,
Which software libraries are you using for both? Can you provide the links here along with the links to the boards?
Thank you.

Hi,
Bmp080 from amazon: https://www.amazon.ca/Puuli-Atmospheric-Pressure-Module-Altimeter/dp/B018VN2EZQ/ref=sr_1_5?ie=UTF8&qid=1521159473&sr=8-5&keywords=bmp085
which works OK.
Bme280 https://www.sparkfun.com/products/13676.
Which after every power on, gave me different bogus results.
I thought is the sensor but works ok whit this code:
https://www.blackmagicboxes.com/?p=608
Both sensors are using same I2C read/write and delay callbacks.
I am using this library:
https://github.com/yigityuce/BlackLib/tree/master/v3_0/BlackI2C
and the callbacks are using writeBlock/readBlock from this i2c.
The code to read Bme280 is this one:
https://github.com/BoschSensortec/BME280_driver  down the page at section:
int8_t stream_sensor_data_normal_mode(struct bme280_dev *dev){....}
My init is:
    _bme280.intf = BME280_I2C_INTF;
    _bme280.delay_ms = &delay;
    _bme280.read = &Bme_280::_iread;
    _bme280.write = &Bme_280::_iwrite;
      ::bme280_init(&_bme280); OK returns BME_OK

Bme_280::_iread & Bme_280::_iwrite  as I said calls the ic2lib blockR/W() finally.
Both Bme080 Bmp280 have same structure.

Hi @comarius,
Can you direct us to the Bme_280::_iread & Bme_280::_iwrite library? The sensor API expects them to perform the writes in a specific manner. Quite often, the write function is incorrect.

I really appreciate the prompt response.
They just wrappers from c++ class to adding a this pointer, but they pass all parameters here
Here is the call chain from Bme280 Class - > Base class and  -> i2c class. Is the same for write.
(I add to dev structure 'this', as well to read/write functors, so I can C++-it...)
 int8_t Bme_280::_iread(uint8_t device_addr,
                             uint8_t register_addr,
                             uint8_t *register_data,
                             uint16_t read_length, void* pthis)
    {
        if(((Bme_280*)pthis)->_ok){
            return ((Bme_280*)pthis)->busread(register_data, read_length, register_addr);
        }
        return 0;
   }
// base class

bool    WireBus::busread(uint8_t* buff, int len, int anyreg)
{
    return _pi2c->readBlock(anyreg, buff, len);
}

Where readBlock  / writeBlock are in this library.
https://github.com/yigityuce/BlackLib/blob/master/v3_0/BlackI2C/BlackI2C.cpp
to writeBlock / readBlock

@comarius,
We are not sure about the i2c smbus implementation, but you can refer to an alternate implementation here in this thread here.

Thank you. Ill let you know soon.


Adding worker node with Multi Cluster Engine

Adding a functionality that adding a worker node with Multi Cluster Engine based on AI Team's feedback

Ok we can work on this together after new year. I will take a look at this kubernetes module.

Superseded by #210


Allow extension to run in background task

Hi,
The idea is to have an option that allows one video (or playlist) played from the YouTube extension and simultaneously play songs from the Subsonic extension in the background.
The solution is to have the possibility to run the extension has a service, it's possible?

Hi, thanks for your feedback, but what the point in playing simultaneously
a Youtube video and music from Subsonic ?
2017-12-09 18:26 GMT+01:00 David<EMAIL_ADDRESS>
Hi,
The idea is to have an option that allows one video (or playlist) played
from the YouTube extension and simultaneously play songs from the Subsonic
extension in the background.
The solution is to have the possibility to run the extension has a
service, it's possible?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/gordielachance/plugin.audio.subsonic/issues/21, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AD42zW2xkyJKlTymvNLNBl9veN9wNnvWks5s-sKwgaJpZM4Q8K4P
.

In my case, I want to display a movie/clip/fireplace scene 🔥 (muted sound) and listen songs from my Subsonic library :)

Ok I understand my friend thank you! 🔥


Raise when trying to hash an empty file or dir

Note for reviewers: I renamed get_dir_hash to get_archive_hash (more accurate name)

The error messages are sometimes confusing
Hash doesn't match ...

Most of the times, this error is due to an unexpectedly empty directory.
This PR improves logging by raising an "Cannot hash empty file/folder" early, instead of raising a "hash doesn't match"-type of exception.
This PR assumes there's no use case when we want to support empty files/directories. If that assumption is incorrect, we could add a boolean option such as raise_if_empty to the get_dir_hash function

end to end tests: :heavy_check_mark:

unit tests are failing, otherwise LGTM

LGTM

@inalgnu Mind reviewing again?

@inalgnu Ooops I added a commit by mistake. It's ready for review again.


PHP only start square bracket in quote will make the vs code editor abnormal.

Does this issue occur when all extensions are disabled?: No

VS Code Version: 1.82
OS Version: Win10
Extensions: PHP debug 1.33.0

Version: 1.82.0 (user setup)
Commit: 8b617bd08fd9e3fc94d14adb8d358b56e3f72314
Date: 2023-09-06T22:07:07.438Z
Electron: 25.8.0
ElectronBuildId: 23503258
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.14393
Steps to Reproduce:

php file.
set string = "SELECT * FROM [", and write any statement after the string. The editor will be working abnormal.
set string = "SELECT * FROM [" and comment after the string. The editor will be working abnormal.
set string = "SELECT * FROM [".$_POST['getdb']."].[dbo].[tabl1] WHERE [column1] = 'PASSWORD'"; The red backet will be shown.

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.83.0. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

There are issues with complex sql string highlighting in php, and I believe there are issues in https://github.com/KapitanOczywisty/language-php/ that capture this


⚠ Roblox Group Api has degraded performance

In 00b1de4, Roblox Group Api (https://groups.roblox.com) experienced degraded performance:

HTTP code: 200
Response time: 2028 ms

Resolved: Roblox Group Api performance has improved in 54ae1c9.


pubsub: Large number of duplicate messages suddenly

I've been noticing an influx of duplicate messages. Previously I don't think I had ever came across one, suddenly started seeing large volumes of dupes. For example out of 50 messages that were all ACKd just recently, I saw 48 duplicates. It sounds similar to this issue:
https://github.com/GoogleCloudPlatform/google-cloud-java/issues/2465
When I look in Google Cloud Console at the API requests, I'm seeing large numbers of 499 error codes. In the last 4 days I have 1,312 200 error codes, but 7,580 499 error codes.
MaxOutstandingMessages = 10
MaxExtension = 10 minutes
Versions:

cloud.google.com/go: aeeacb092ec71c83668e4828857289d89c34b610
github.com/googleapis/gax-go: 317e0006254c44a0ac427cc52a0e083ff0b9622f
google.golang.org/genproto: 1e559d0a00eef8a9a43151db4665280bd8dd5886
google.golang.org/grpc: f92cdcd7dcdc69e81b2d7b338479a19a8723cfa3

@cristiangraz We have a working reproduction in Java. I'll see if I can also repro it here. Could you let us know how long the deadline on your subscription is?

@pongad Is the deadline different from MaxExtension in the ReceiveSettings struct? Just want to confirm I give you the right thing, MaxExtension is 10 minutes and MaxOutstandingMessages in this instance was set to 10.

@cristiangraz Sorry for the confusion, I was referring to deadline configured on pubsub subscription. You can get it from either the cloud console, or run
cfg, err := subscription.Config(ctx)
_ = err // handle err
fmt.Println(cfg.AckDeadline)

I sent a PR which should fix the problem to the Java repo. I plan to fix all the desgin concerns there first, then I'll replicate it here.

@pongad the deadline on the subscription is set to 10 seconds (from cloud console). Also in this instance all of the workers are completing in ~2-3 seconds once they start receive the message.

Same here. We tried using MaxOutstandingMessages = 10 and got lots of duplicates. Switching back to the default was much better. AckDeadline was also set to 10sec.

This symptom suggests that this is the same problem we're seeing in Java.
Our diagnosis is this: The perceived communication latency between pubsub server and the client can be high, so the client thinks messages expires further into the future than they actually do. By the time the client send "please give me more time" request to the server, it's too late: the server already considered the messages expired and resent them.

@pongad With a pubsub deadline (in cloud console of 10s): Pubsub starts counting the 10s before client starts counting 10s (due to latency) -- so pubsub has already resent the message before client could request an extension? Am I understanding that correctly?
If a worker on our end is processing a message in < 2s, does that mean there could up to 8s of latency between the pubsub server and our client? Is there something on the Pubsub server that has caused latency to increase recently? We're running on Google Container Engine, so trying to grasp what the latency issues might be inside the datacenter from GKE to Pubsub.
If we changed the subscription deadline to 30s for example, would that solve this issue?
We have MaxOustandingMessages (of 10 in this instance) equal to the number of goroutines processing messages (in order to avoid pulling messages before they are ready to be processed).
Thanks for all your help so far.

@cristiangraz There are a few details, so I need to answer out of order.

pubsub has already resent the message before client could request an extension? Am I understanding that correctly?

Yes, we believe that's the root cause.

If a worker on our end is processing a message in < 2s, does that mean there could up to 8s of latency between the pubsub server and our client?

There are a few variables at play. According to this comment each response contains "a single batch as published". So, if you set MaxOutstandingMessages = 10, the server might send us 11 messages in the same response. The client will process up to 10 messages concurrently, but the 11th message needs to wait until one of the first 10 finishes. So the 11th message might appear to take 4 seconds to process, etc.

Is there something on the Pubsub server that has caused latency to increase recently? We're running on Google Container Engine, so trying to grasp what the latency issues might be inside the datacenter from GKE to Pubsub.

I'm actually not 100% sure. After I reproduced the problem, the logs showed that there has to be some latency going on, but I cannot tell which component (gRPC? pubsub server? firewall? etc) is introducing the latency.

If we changed the subscription deadline to 30s for example, would that solve this issue?

That would certainly help. I should note that if you set it too high, it will take longer for the message to be redelivered if your machine crashes. If you decide to increase the deadline, could you let us know if it's helping?
I created a PR to Java client (after merging, I can replicate in other langs) that will make the client send "I need more time" message to the server earlier to account for the latency.

I am running into the same issue and it's incredibly frustrating. In my debugging, I set ReceiveSettings.NumGoroutines = 1, MaxOutstandingMessages = 1 and ReceiveSettings.MaxExtension = 10 * time.Minute.
With the default subscription.AckDeadline = 10seconds:

If I ack the msg as soon as I receive it, I get 100% deletion rate.
If I wait 100ms after (just sleep), I deleted 196 of 200 msgs.
If I wait 200ms after, I deleted 102 of 200 msgs.
If I wait 300ms after, I deleted only 68 of 200 msgs.

I also created a subscription w/ AckDeadline: 5 * time.Minute but the deletion/ack rate is slightly better. The last run I did w/ 300ms delay ack'ed 123 of 200 msgs.
Did Google Pubsub change something on their end? Seems like it's all happening in the last couple of days.

@pongad I tried to change the subscription deadline in the cloud console, but I didn't see any option for it. Is there any way to get more info internally from the Pubsub team about possible latency issues? It's definitely worrisome to see latency > 10-20ms inside of GKE, let alone the possibility of latency in the several seconds (if it's not related to streaming pull).
w.r.t. MaxOutstandingMessages and streaming pulls -- So if I set a value of 10, I should receive 10 messages? The only exception being that messages published in batch are also fetched in batch causing the streaming pull to possibly retrieve more than 10 messages and wait to process them? If that's correct, in our instance we were seeing duplicate messages mostly in an our domain system from an order. The order items are batch published in a single call to the fulfillment system, but the fulfillment system handles each message individually and publishes one at a time to the domain system (no batch publishing). They all are published around the same time, but not in a batch call. The domain system is where I am seeing the largest number of duplicates. If that's the only exception to more than MaxOutstandingMessages being received, then in our case there shouldn't be any messages that have been pulled but are waiting to begin processing? Is it possible something else is causing the latency?
This is only anecdotal as I haven't setup a test as thorough as @zhenjl, but from what I can observe duplicates are more likely when multiple messages are coming in around the same time (although not originating from a batch publish). When a worker only has a single message to process, I don't see any signs of duplicates so far -- even in the same workers.

I made a CL that should help with this.
@zhenjl Thank you for the measurements. This is in line with our expectation. If you ack the message very quickly, the acks will reach the server before the server expires the message, so there'd be fewer duplicates.
@cristiangraz You're right, I'm sorry. The only way to "change" the deadline right now is to delete the subscription and recreate. Hopefully the CL would mean you don't have to do that.
The fact that you're seeing this problem in your domain system is indeed suspicious. Could you let us know how you're publishing? If you're publishing by topic.Publish in the pubsub package, the publisher tries to batch messages together to increase performance. Could that be the problem?

@pongad Yeah we are using topic.Publish -- I suppose if several independent goroutines are calling Publish the client could be batching them.

We investigated this more. We believe the messages are buffered on a machine between your VM and the pubsub server. This explains the latency: pubsub server can send messages into the buffer faster than we can read it out, so some messages spend a few seconds in there. We're working to fix this.
In the immediate term, you can try reverting to v0.11.0. That version pulls messages from a slower endpoint that shouldn't be affected by this problem. If you see compile error like undefined: gax.MustCompilePathTemplate, you need to also revert gax-go to version v1.0.0. Please let me know if this helps.

Thanks @pongad. We rolled out a fix for all of our workers on Friday so they are unique by (subscription name, message id) using SQL locks, so we're currently protected from duplicate concurrent messages. I had some issues with v0.11.0 so am going to stay pinned to the current version until a fix is ready.
I appreciate all of your help digging into this, it sounds like you may have found the cause behind the latency. If you need any additional info please let me know.

+1 on this issue. We've been trying to determine for days why we aren't processing through our queues and reverting to v0.11.0 seems to have resolved the issue. We were showing a ton of Google Cloud Pub/Sub API errors in our cloud console.

I'm also seeing this issue. I had actually changed my ack deadline in the Google Cloud UI to 300 seconds, but noticed my messages being redelivered every 10. The UI showed me the deadline was 300 seconds though.
Recreating my subscription fixed that problem, but is there a reason that edit option isn't disabled if it isn't supported?

@ProfessorBeekums Subscription.Receive gets the ack deadline from the service at the beginning, and then remembers it for the life of the call. You have to call Receive again to get the change.

It's an active area of work internally. There should be fixes rolled out in the next couple of weeks.

I'm getting the same problem with this version: https://github.com/GoogleCloudPlatform/google-cloud-go/commit/8c4ed1f54434ff9ea67929c91a4a10db57a52780
My theory of this problem is the following:
This line:
https://github.com/GoogleCloudPlatform/google-cloud-go/blob/8dff92c85f4225d90bdd100ea741d9903acc259e/pubsub/iterator.go#L58
It always uses the 5 seconds before the deadline. Let's say we have 10 seconds ack deadline on the subscription.
OK case:

Time
Client
Server

0
Pull a message
Send a message

5
Ask for extension
Quickly accept the extension

Bad case (assuming it retries on failure):

Time
Client
Server

0
Pull a message
Send a message

5
Ask for extension
Somehow Erroring, hanging almost 5 seconds

10
Retrying modifyAckDeadline
Got it, but it's too late

Originally I started to experience this problem with this issue:
https://github.com/GoogleCloudPlatform/google-cloud-go/issues/382
As I recall, when I used the legacy client lib, I manually send modifyAckDeadline by myself, with a grace period of 15 seconds with 60 seconds of AckDeadline. At that time, it works much much better.
That makes me think of something like:
keepAlivePeriod := Max(po.ackDeadline - 5*time.Second, po.ackDeadline * 1/4)

for an easy mitigation. WDYT?

@tmatsuo From our analysis, things look slightly different from what you just mentioned.
In your table, the server sends and the client receives at about the same time. Our analysis shows that this isn't really the case. There could be significant buffering between client and server. So things might look kind of like this instead:

Time
Client
Server

0
Buffers (the client hasn't "seen" the message)
Send a message

6
Sees message

10

Message expires

11
Sends modack
Got it, but too late

Your solution might help to a degree. However, it's always possible for enough messages to back up that changing keep alive period won't help.
We're fixing this partly server-side so things look like this:

Time
Client
Server

0
Buffers (the client hasn't "seen" the message)
Send a message, but pause the "clock"

6
Sees message; notifies server [1]
starts the clock, message expires at time=16

11
Sends modack
Got it, with time to spare

The change [1] is already made to the client here.
Last week, we estimated that the server-side fix should be rolling out this week. I'll keep this thread updated.

@pongad Alright, it sounds promising :) Thanks!

@pongad
FWIW, although your scenario looks promising, I think the suggestion of mine or similar approach will also be needed, because I often observe duplicated messages certain time after the pull request was made.

duplicated messages certain time after the pull request was made

I'm not 100% sure I parse this right. Are you saying the duplicate arrive a certain time after you ack it?

@pongad
No. I mean that, it seems that the dups are happening for me at not only the first iteration of modack, but also on one of the subsequent iterations of modack. I'm not 100% confident though.

@pongad
I think some of the modack failures in our case might have been because of network congestion (and short grace period of course), sorry for the noise.

The server-side fix has landed. Could you try again and let us know if you're seeing fewer dups?
There is an untagged change on master that takes full advantage of the server feature, but we believe the fix should also work on the latest tagged version.

Still having the same number of duplicates here (europe-west-1)...

Still using v0.12.0

Thank you for letting us know @jfbus . I have reported this to the pubsub team.

I am also seeing duplicate with v0.14.0 Go client library.
Is this fixed in v0.16.0?

@dengliu I believe the fix hasn't been tagged yet. Would it be possible for you to try from master?

It looks to me like the change was added in v0.16.0 with https://github.com/GoogleCloudPlatform/google-cloud-go/commit/c9fc9dd1cdea3f1cfd34d266f624232ddf462083.
I am still having this issue on v0.17.0. In my case I suspect that my upload speed is getting saturated. I think some clarification on connection delays would be beneficial on this article: https://cloud.google.com/pubsub/docs/faq#duplicates

I tested the go client with v0.16.0 this week , but it didn't seem to be fixed.

@roger6106 @dengliu The pubsub team just rolled out more fixes that should further reduce the duplicate. The fix landed only a couple of days ago. Could you let us know if you're still seeing this problem?
If you are, could you let us know how long you're taking to process each message? It'd help us reproduce the problem.

@pongad what did u rolled out, anything changed on the server side?
We are seeing issues that pull rate sparodically become much lower than normal since 3 days ago.

@dengliu I checked with the pubsub team; this is indeed a problem on the server. They are working to resolve this.

@marklr, @anorth2, @jfbus and anyone else experiencing problems with Receive: we've been working on understanding the problem better.
One important fact I noticed when looking carefully at the Stackdriver Monitoring UI: the "StreamingPull message operations" and "StreamingPull Acknowledge message operations" are delta metrics, and the graphs are created with a "mean" aligner by default, so each data point represents the average number of messages since the last data point. But the graph is a line graph, which (to me, at least) suggests a rate. For example, I just published about 6000 messages over the course of a minute, or 60 msgs/sec. They were received by a simple program that used the default MaxOutstandingMessages of 1000 and acked each message after 20 seconds, for a maximum ack rate of 50 msgs/sec. These are the graphs I got:

It's not clear where the numbers on the y-axis come from, and it looks like there's a gap of about 1,000 messages between pulls and acks, but that is misleading:  the acks happen over a longer period of time. You have to integrate under the graph to compare. I find looking at rates to be much clearer. When I switched the aligner to "rate" (three-dot menu, Edit, Show more options, Aligner), I got these graphs:

These clearly show that I was publishing at 60 msgs/sec and acking at a peak 50 msgs/sec, exactly as expected.
Apologies if this is obvious to you all, but it wasn't to me.
None of that implies that there isn't a problem with PubSub on GKE. To try to collect more data, I added OpenCensus instrumentation to the client, with several measures related to streaming pull. The measures include stream opens and RPC retries as well as pull, ack, nack and modack counts. The code is in the latest commit of this repo. The program I linked to above exports the measures to StackDriver, and also logs them. When adding a graph to the UI, search for metrics containing "cloud.google.com/go/pubsub". Avoid the ones that end in "/cumulative"; they are obsolete.
I ran that program as a standalone pod on GKE, using kubectl logs -f to watch the logs directly. I didn't see anything that looked unusual. Every message eventually was acked. The number of modacks was five times the number of messages, but that is expected: we modack immediately when we get a message and then every 5s (when the ack deadline is 10s), so 5 modacks for 20s of processing is about right. (The number would be much lower if the ack deadline were longer). I did see Unavailable errors cause the stream to reopen every 90s or so, but crucially, that was only during idle periods: while messages were actively being pulled, the stream never failed.
So in short, I'm unable to reproduce the problem, and in fact I'm still not really clear on what the symptoms are. I hope the new metrics will shed some light.

We haven't heard any updates from those affected by this, and we currently have no way to reproduce. Closing until we have actionable information.

@tecbot:

Are you also running on GKE? If so, does the same problem occur if you run your docker container directly on GCE?

Please share as much of your Receive code as you're comfortable with. Especially useful are the ReceiveSettings you're using.

Could you enable the client instrumentation we recently added? Details are in my comment above.

Thanks for all the info. We don't have a theory yet about what you're seeing. The server doesn't buffer, and it doesn't rebundle—if the publisher sends 3 messages in one Publish RPC, then the subscriber will receive those three messages in one chunk.
The fact that your "ping" messages unsticks the subscribers is very interesting—we haven't observed that before.
I'm trying to look at the black graphs but am having trouble interpreting the y-axis. The raw counters always increment, so I don't think you could be using those directly since your graphs go down. Are you showing a delta? For example, in the third graph (between peaks), the average value for Ack is about 88. Is that 88 acks over the last 10s sampling interval? (OpenCensus sends sample data every 10s, unless you call SetReportingPeriod.) Is it 88 acks per second? Neither makes sense with the numbers you provided: if you're handling 30 messages every 2 minutes or so, your ack rate should be .25/s.

@tecbot Something is funky, or I'm misunderstanding.
For the top graphs: I think your graphs are saying that acks are happening steadily at around 90 per minute (or per second? I think it's saying per minute... but not sure), which seems good.
For the bottom graphs: Could you provide a also a graph showing num_undelivered_messages? The two reasons for the spikiness I could think of: there actually aren't any undelivered messages, or the processing time is ~20-40m.
I've taken your code and replicated it (see program here). I'm not sure how you're sending, so I used the gcloud console to send a message each second (actually, initially 2s, then 1s - you'll see a slight uptick early on). Here are the charts:

So unfortunately I'm unable to repro. Could you describe the way you're publishing? I'm interested in the following:

Are you using a program to publish? If so which language? If not which tool?
Could you describe any publish settings you've configured?
Could you provide a repro, if publishing via code?

FWIW we also encounter a similar experience using PubSub on GKE.
We reproduce this behavior when we suddenly stop consuming a subscription and then starting to acknowledge messages again.
When we notice such behavior the number of undelivered messages is in the order of the dozen of thousands at least.
When we restart consuming the subscription again by acking the messages, we see a surge in duplicated messages until the number of unack'ed messages drop to 0.
We also notice that the rate of duplicate message decreases as the number of undelivered messages drop.
Once the messages no longer accumulate in the queue we see almost no duplicate messages.

@sfriquet:

stop consuming a subscription and then starting to acknowledge messages again

So you exit from the call to Receive, then wait a while, then call Receive again?

When we restart consuming the subscription again by acking the messages, we see a surge in duplicated messages...

The timer for a message's ack deadline begins when the message arrives on the client, or after 10 minutes, whichever comes first. Messages arrive on the client in bulk, and may be buffered (by proxies or the client's network layer) before they arrive. If you ack slowly, messages may time out, and then you will see duplicates.
For example, say there are 10,000 undelivered messages when you call Receive, and you process them one at a time (one subscriber process, NumGoroutines=1, MaxOutstandingMessages=1). You ack each message after 1 second. After 10 minutes you have seen 600 messages, but there may be many more that have left the server and are in a buffer somewhere. Ten seconds later (assuming the default ack deadline of 10s), these messages will time out. You will see and ack them as you continue processing, but the server will have already marked them as expired and will redeliver them.
The bottom line is that it can be hard to distinguish this behavior—which is "normal," though undesirable—from a bug in the PubSub client or service.
It would help if you could give us more data.

Thanks for the advice.

When you say you added a "cache layer," do you mean a separate process/server? Because you may be able to get away with having each client process get rid of just the duplicates it sees.

Reading your explanations again it indeed seems that the duplicates would be on a per client basis. In such case 'caching' at the client level should work too and be much simpler to implement/maintain then.

duplicates would be on a per client basis

I don't think that's right. The service will load balance messages (including re-sent ones) across all streams in a subscription. However, if you only have a handful of streams, a significant fraction will end up on the same one. For instance, if you have two streams (processes), then each will see half the messages, and get half the dups. So a per-client solution will weed out a quarter of the dups. I guess that's not a great ratio, now that I do the math. In any case, my point was that a per-client solution is much simpler architecturally, and maybe it gives you enough de-duping to make your system perform adequately.

It seems like this issue is haunting us as we have it in multiple projects now.
After having followed this whole discussion and also spent time studying the internals of this library, we came to the conclusion that the current library is designed for pipelines having a setup with a somewhat stable incoming messages, and a high throughput in terms of processing.
In our case, we receive spikes of messages every 5 minutes, and the processing time of 1 message can vary and take up to a couple of seconds sometimes and there is not expected correlation between the number of incoming messages and the speed at which we want to process them.
If our understanding is correct, the streaming pull strategy used in this library can eventually fetch more messages than the MaxOutstandingMessages, which from a developer experience point of view is a bit hard to understand. I do understand now that this allows for a very high throughput in some scenarios. However it also introduces all issues discussed in this thread.
On our side, we tried leveraging the non streaming pull approach and so far it seems to address the problems. However our solution required us to re-implement parts of this pubsub client in order to re-create some of the needed features.
Is there any chance you could introduce a parameter letting the user choose wether to use the experimental streaming subscription pulling, or using the API endpoint? It seems like the latter respects the MaxOutstandingMessages and would work very fine in our use case.
Otherwise, if you plan to somehow deprecate the Pull endpoint in favour of the StreamingPull, is there any chances we could implement an option forcing the client to respect the max outstanding messages? Even a hack in the beginning, for example if the client was to Nack directly all messages after MaxOutstandingMessages amount has been received could help us solve our issue.
I hope this all makes sense. We feel like our current implementation re-invents the wheel, and given that you mentioned earlier that you were working on this case, I wanted to share our experimentations and expectations. I hope this is somewhat useful.

@rayrutjes, we'll pass your comments along to the PubSub team.

@christiangraz I'm curious why is this issue closed?

@sfriquet @johnreutersward The initial issue I was having regarding excessive duplicate messages has been fixed. There were lots of other unrelated comments on this issue that went quiet, but looks like there are some additional cases (like this one https://github.com/GoogleCloudPlatform/google-cloud-go/issues/778#issuecomment-380049492) related to duplicate messages that I missed. Apologies, reopening.
@jba Will leave this up to you or the team to close this whenever it's ready to be closed.

As of afb80096eae340697e1153d7af9a5a418ba75067, we support synchronous mode for Receive. If you want more control over throughput, please try it. (It ensures that you will never pull more than MaxOutstandingMessages from the Pub/Sub service at a time.)
I'm going to close this now. Reopen if you are still experiencing many duplicates and synchronous mode isn't helping.


Add a TRIM layer

Exclude grids and contours

Here is the geoserver wms request:
http://openmaps.gov.bc.ca/geo/pub/wms?service=wms&VERSION=1.1.1&REQUEST=GetMap&SRS=EPSG:4326&LAYERS=pub:WHSE_BASEMAPPING.TRIM_WATER_LINES,pub:WHSE_BASEMAPPING.TRIM_TRANSPORTATION_LINES,pub:WHSE_BASEMAPPING.DRA_DGTL_ROAD_ATLAS_MPAR_SP,pub:WHSE_BASEMAPPING.TRIM_WATER_POINTS,pub:WHSE_BASEMAPPING.TRIM_TRANSPORTATION_POINTS,pub:WHSE_BASEMAPPING.TRIM_CONTOUR_POINTS&styles=3345,3334,,3344,3333,3332&TRANSPARENT=TRUE&FORMAT=image/png&

I cannot seem to get anything but an empty (all-transparent) tile back from this service, here is an example url:
http://openmaps.gov.bc.ca/geo/pub/wms?service=WMS&request=GetMap&layers=pub%3AWHSE_BASEMAPPING.TRIM_WATER_LINES%2Cpub%3AWHSE_BASEMAPPING.TRIM_TRANSPORTATION_LINES%2Cpub%3AWHSE_BASEMAPPING.DRA_DGTL_ROAD_ATLAS_MPAR_SP%2Cpub%3AWHSE_BASEMAPPING.TRIM_WATER_POINTS%2Cpub%3AWHSE_BASEMAPPING.TRIM_TRANSPORTATION_POINTS%2Cpub%3AWHSE_BASEMAPPING.TRIM_CONTOUR_POINTS&styles=3345%2C3334%2C%2C3344%2C3333%2C3332&format=image%2Fpng&transparent=true&version=1.1.1&height=256&width=256&srs=EPSG%3A3857&bbox=-13462700.917811524,6339992.874085658,-13384429.400847504,6418264.391049678

Verified in test.


feat(Table): reduce table header bottom line weight

Small change to reduce table header bottom line weight
Closes

I forgot to update visual tests. I'm on it


actor count can go below zero

I have observed the behaviour described in https://github.com/kontainers/micrometer-akka/issues/106 and think I can reproduce it in unit tests.
I aim to have a look at fixing the issue in this fork.

Things should be better in v0.13.2 release


WebXR immersive VR launching issues on Desktop with Oculus AirLink

There's some oddness that I can't explain when launch PlayCanvas WebXR VR experiences on desktop via Oculus AirLink.
Forums thread: https://forum.playcanvas.com/t/recommended-setup-for-xr-development/22794
Setup:
Oculus Quest 1
Connected to Windows 10 with Oculus software using Air link
Using the Oculus OpenXR runtime
Chrome on Windows
PlayCanvas experiences only launches correctly if it's the only tab open that has a WebGL app.
If I have more than one tab (eg and Editor tab and Launch tab), the VR experience fails to load as shown below
https://user-images.githubusercontent.com/16639049/143031177-720c0cae-24cb-479c-a3b6-dbb2440810ef.mp4
However, the hello world from immersive web loads fine no matter the situation: https://immersive-web.github.io/webxr-samples/immersive-vr-session.html
Examples paths I've tried:
Two tabs open with https://immersive-web.github.io/webxr-samples/immersive-vr-session.html , starting VR in either works fine
One tab with https://immersive-web.github.io/webxr-samples/immersive-vr-session.html and another with https://developer.playcanvas.com/en/tutorials/webxr-controllerhand-models/ , starting VR in PlayCanvas fails while immersive-web works fine.
Two tabs open with https://developer.playcanvas.com/en/tutorials/webxr-controllerhand-models/ , neither succeeds entering into VR.

Forgot to mention that there weren't any error messages in the console log of the browser either.

I've not found a solution, no :(

Omg. Very frustrating..

After a ton of debugging, I found a fix to this issue and just made a PR for it. It was incredibly annoying to figure out what was causing the issue because using breakpoints in the chrome dev tools would stop the issue from occurring.


Address clippy warning

See #3

Applied the first 4 commits.
Fixes for borrow makes sense but applying would conflict (so held off for now).
The second last 2 (0d96e61 & ac526c6)  I'm not really finding so good, they change the code to meet some rules at the expense of readability IMHO.

0d96e61 is more compact but less readable (looses alignment, multiple if statements split null check with rb-tree logic).
ac526c6 makes it read as if the last two branches are different variations in the same category as the previous branches in the statement, where as they're really the same thing. AFAICS this is just a result of using a constant where an ifdef would be used in C... causing flow control that reads a bit strange. But I rather keep this as-is, since its more obvious the last else {...} has one purpose, not two.

Applied borrow fixes, the remaining two commits I rather leave out.
Thanks for the PR's, closing.


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-1.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 2657

Questions ?
Please refer to the Backport tool documentation


Feature: Ability to start the anchor text from the current position of the caret when no text is selected

When the link icon is clicked without selecting any text , the entire text present is highlighted and converted to the anchor text. I feel it would be more intuitive if the anchor text starts from the caret position when the link icon was clicked.
I would like to bring some thought to what if an option is provided to  have this behaviour: When the user clicks the link-icon in the lexical toolbar and types some text in the editor then the characters that are typed after the click should be taken as the link till a space is encountered. This is the case when user wants to insert a link from the current caret position as they type the text.
Summary
Scenario: No text is selected by user and link icon is clicked in the lexical toolbar
Current behaviour:
When no text is selected and user types some text and click link icon, you will notice the entire text is highlighted and made as a link label (anchor text)
Requested option:
When no text is selected and user types some text, clicks link icon and then starts typing. All the characters that are typed (till the space or end of text) after clicking the icon should be highlighted and taken as a link label (anchor text).
Also it would be helpful in case there was some particular reasoning for the library to behave in the way is it is currently for this particular case.

The library doesn't really behave this way, just the specific playground implementation of link insertion, which is just an example and not part of the public API. You should be able make links behave the way you are describing pretty easily using Lexical (split text, insert LinkNode or whatever).
Feel free to re-open if you have more questions.


Custom Batch Actions help?

How can I create buttons for setting selected fields to true and another one for false. I'm aware of customizing batch actions just not sure in the action code itself

example code im working from
@action('set_running', "Set state to 'running'", None) def action_set_running(self, ids):     self.set_dagrun_state(ids, State.RUNNING)


Allow drag and drop bound child node properties

Godot version:
3.1-stable-win64
Issue description:
Feature request:
I would like to be able to drag a property from a child node to its parent node, and have the parent node automatically have a "bound" property that maps to the child's property. For eacmple:
https://gyazo.com/0d487caaa48eacb9cd70afc46b91471e
After clicking on NPC in the inspector I would like to see a Sprite secion with a Texture property, that is linked to the Texture property on the NPC/Sprite node (so changing one changes the other)
Steps to reproduce:

Create a Node
Create a Sprite as a child of the Node
drag the Texture property from the Inspector to Node in the Scene tree
click on Node in the scene tree
notice there is no bound property

Minimal reproduction project:
None.
If you really want to use the project in the animated .gif above here is the most recent commit as of this report:
https://gitlab.com/youreperfectstudio/catherines-quest.git
fc8ff3e4ea5111ae878d538cff89a7b2fb7a0318

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.
The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.
If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!


CardMachineRequestorInfo has no public properties and CardPresentPaymentInfo is missing off payment method details

We've hit a few issues using this SDK for Tables.

CardMachineRequestorInfo  has all of it's properties missing public.
PaymentMethodDetails has CardPresentPaymentInfo missing

Hi Lewis, thanks for reporting the issue. We will fix it ASAP!

Hi Lewis, the issue is fixed now, please update to version 1.0.4
Let me know if you have any questions or more issues.


Dashboard Markdown deletes edits when changing the size of the component

When user adds new markdown into dashboard, edits the text and changes size of the markdown, the text gets lost.
Expected results
Both text and re-size should be saved
Actual results
Text user just wrote gets lost
How to reproduce the bug

Go to Dashboard
Click on 'Edit
Add Markdown
Edit text into the markdown & in a same step resize the markdown
click away - markdown size stays, text is lost

Checklist
Make sure these boxes are checked before submitting your issue - thank you!

[ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

@kgabryje

I'll look into it

@zuzana-vej @junlincc Can you check if the problem still appears after fix?

tested, all good! Thank you, Kasia!! closing~


build fix for rustc 1.52.1

Small fix for build issue. Also added .DS_Store to the gitignore. Works with rustc 1.52.1.

Thanks!


Redirects should be followed by default

Description
helix-fetch doesn't follow redirects by default. You have to explicitly set the redirect: 'follow' option. According to the Fetch spec redirect: 'follow'should be the implicit default.
To Reproduce
const resp = await fetch('https://httpstat.us/307');
assert.equal(resp.status, 200); // -> fails
assert.equal(resp.redirected, true); // -> fails

Expected behavior
Redirects should be followed by default, i.e. the above example should not fail

:tada: This issue has been resolved in version 1.8.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Can't run the example dnn_mmod_face_detection_ex

Hello,
I installed dlib without any problem (linked to cuda, cudnn,...). So i tried to use the pretrained model to test on some images:
./dnn_mmod_face_detection_ex mmod_human_face_detector.dat dlib-19.3/examples/faces/2008_004176.jpg
I used CUDA 8.0 and CUDNN 5.1.
The problem is I always get this error:
Error while calling cudnnSetFilter4dDescriptor((cudnnFilterDescriptor_t)filter_handle, CUDNN_DATA_FLOAT, CUDNN_TENSOR_NCHW, filters.num_samples(), filters.k(), filters.nr(), filters.nc()) in file dlib-19.3/dlib/dnn/cudnn_dlibapi.cpp:822. code: 3, reason: CUDNN_STATUS_BAD_PARAM
Could you help me where did I do wrong?

You shouldn't get that error.  There is probably something wrong with your CUDA install.  I would reinstall CUDA and cuDNN.

Thanks for your support. I found the problem. Dlib linked to wrong cudnn version. In our system contains both versions of cudnn for cuda 7.5 and  cuda 8.0. It actually linked to 7.5. I still don't know why. After corrected it, it works.

@peterpans01 I met the same problem, I used CUDA 8.0 and CUDNN 6.0. But I do not know how to slove the problem? Thanks.


Windows Desktop App: Minimize to tray setting disappeared (since 4.7.0)

I confirm (by marking "x" in the [ ] below: [x]):

[x] This is not a troubleshooting question. Troubleshooting questions go here: http://www.mattermost.org/troubleshoot/.
[x] This doesn't reproduce on web browsers (such as in Chrome). If it does, issue reports go to the Mattermost Server repository.
[x] I have read contributing guidelines.

Summary

Environment

Operating System: Windows 10 Pro (Build 19043.1151)
Mattermost Desktop App version: 4.7.1
Mattermost Server version: 5.36.1 on linux

Steps to reproduce
Update to Mattermost version 4.7.0 (or directly to 4.7.1?) from a previous 4.6.x version.
Expected behavior
"Minimize to tray" entry should show in the app settings. When enabled, app should minimize to systray when minimizing app window or when clicking the Mattermost entry in the task bar.
Observed behavior
"Minimize to tray" entry does not show in the app settings. App only mimimizes to systray when closing the app window.
The setting is still present in config.json but not in the Settings window:
  "showTrayIcon": true,
  "trayIconTheme": "light",
  "minimizeToTray": true,

Possible fixes
Currenty unknown.

I've just updated to 4.7.2 but the minimize to tray option is still not present. Is there any way to get this feature back?

I asked and a dev mentioned that it was intentionally removed, but we have a ticket to add it back in the future in a different form.

Created a JIRA ticket: https://mattermost.atlassian.net/browse/MM-40572

I'm on version 5.0.4 now but the issue remains.
I've enabled "Leave app running in notification area when application window is closed" an restarted the app.
When minimizing the app window, Mattermost still shows up both in the systray AND in the task bar!
The older behaviour was to show ONLY the systray icon when the app window was minimized.

@mreymann The setting only applies to when you close the window, the minimizeToTray naming in the background is a bit misleading, sorry for the confusion.
What the setting does is make sure the app stays open when you close the window, instead of outright closing the entire application.

Is there a chance to get the original feature back?

@mreymann I don't think we have any plans to do that, sorry for the inconvenience.

That's too bad. The way it is now, the useless Mattermost item in the taskbar just adds to the clutter ... :-(


Variable explorer does not show variables and crashes when buttons on side pressed

Description
What steps will reproduce the problem?

Changing the variable explorer preferences in the spyder preferences

What is the expected output? What do you see instead?
Please provide any additional information below
When I change any settings in the variable explorer Spyder crashes. When I run any script I cannot see any of the variables in the environment. It is empty. I have tried re-installing anaconda and spyder and neither works.
Version and main components

Spyder Version: 2.3.6
Python Version: 2.7.10
Qt Versions:  4.8.6, PyQt4 (API v2) 4.11.3 on Darwin

Optional dependencies
pyflakes >=0.5.0:  0.9.2 (OK)
pep8 >=0.6      :  1.6.2 (OK)
pygments >=1.6  :  2.0.2 (OK)
IPython >=1.0   :  4.0.0 (OK)
zmq >=2.1.11    :  14.7.0 (OK)
qtconsole >=4.0 :  4.0.1 (OK)
pandas >=0.13.1 :  0.16.2 (OK)
sphinx >=0.6.6  :  1.3.1 (OK)
psutil >=0.3    :  2.2.1 (OK)
rope >=0.9.2    :  0.9.4 (OK)
jedi >=0.8.1    :  0.9.0 (OK)
matplotlib >=1.0:  1.4.3 (OK)
sympy >=0.7.3   :  0.7.6 (OK)
pylint >=0.25   :  None (NOK)

Are you using 10.10 or 10.11 by any chance?

Closing because of lack of response.
If you're using 10.10 or 10.11, this problem could be fixed by an Anaconda update in a couple of weeks.

Are you using 10.10 or 10.11 by any chance?
I see that this question comes back often. Is it possible to include this information in the bug template ?

Yes, I think it's possible :-) Could you open an issue about it so I don't forget to do it?

Well I could, but I don't even know what 10.10 and 10.11 refer to exactly... Is it the Darwin version ?


add af_alg errors to the error queue

Im using the afalg engine on an embedded device with a crypto hardware ( sama5d2, atmel-aes kernel driver )
if the kernel operation fails the function EVP_DecryptUpdate() just returns 0 without any error Message
i had a look at the code and i think it should be changed to something like this to make the error visible
the reason why it failes is that the buffer which should be encrypted has a size of  22 kB
if the buffer is not aligned to pages the driver uses an internal buffer of 16 kB
because the buffer is larger the kernel crypto operation failes
of course this patch has to be reworked till it can be merged

This is outside of what we consider acceptable with CLA: trivial. Could you please submit a CLA? https://www.openssl.org/policies/cla.html

cla is send via email

ok i changed the error output to AFALGerr() and ERR_add_error_data()

Hi I will help you with everything you need but you have to subscribe to
the youtube channel and I will fulfill all your requests
https://youtu.be/aIaqr4eq18g
Pada Rab, 28 Sep 2022, 5:52 PM lordrasmus @.***>
menulis:

Im using the afalg engine on an embedded device with a crypto hardware (
sama5d2, atmel-aes kernel driver )
if the kernel operation fails the function EVP_DecryptUpdate() just
returns 0 without any error Message
i had a look at the code and i think it should be changed to something
like this to make the error visible
the reason why it failes is that the buffer which should be encrypted has
a size of 22 kB
if the buffer is not aligned to pages the driver uses an internal buffer
of 16 kB
because the buffer is larger the kernel crypto operation failes
You can view, comment on, or merge this pull request online at:
https://github.com/openssl/openssl/pull/19289
Commit Summary

15cd60a
https://github.com/openssl/openssl/pull/19289/commits/15cd60a9da65287348c4a9efbc7088175c993781
add af_alg errors to the error queue

File Changes
(3 files https://github.com/openssl/openssl/pull/19289/files)

M crypto/err/err.c
https://github.com/openssl/openssl/pull/19289/files#diff-18bb8d14441818db23a3b35b8c7f5ee816aee054f9f60505cad2b54e7f57028b
(1)
M engines/e_afalg.c
https://github.com/openssl/openssl/pull/19289/files#diff-04a829365afcd59bf41bae87205f83e0373eed322149df926944122a7994e703
(8)
M include/openssl/err.h.in
https://github.com/openssl/openssl/pull/19289/files#diff-ec5dfd8a17342474c2e21a5c5aa643b6674b4e00546a8aa95a1f214f5a7e94a5
(1)

Patch Links:

https://github.com/openssl/openssl/pull/19289.patch
https://github.com/openssl/openssl/pull/19289.diff

—
Reply to this email directly, view it on GitHub
https://github.com/openssl/openssl/pull/19289, or unsubscribe
https://github.com/notifications/unsubscribe-auth/APESUCSG2LHJTDYDPTYEHFDWAQIMTANCNFSM6AAAAAAQXTEPLU
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

This sounds like a bug, so I'm making it eligible for 3.0 as well.

First step
Hi I will help you with everything you need but you have to subscribe to
the youtube channel and I will fulfill all your requests
https://youtu.be/aIaqr4eq18g
Pada Sab, 8 Okt 2022, 5:46 PM Richard Levitte @.***>
menulis:

@.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
https://github.com/openssl/openssl/pull/19289#pullrequestreview-1135206270,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APESUCT23OJ3FECNVESLAJDWCE7IRANCNFSM6AAAAAAQXTEPLU
.
You are receiving this because you commented.Message ID:
@.***>

i have to close this pull request because my cla is now accepted

Closed and reopened.  Which should remove the need CLA tag.

i have to close this pull request because my cla is now accepted

?  No real need to do that...  unless you need to change the author line in the commits

ok if its not needed then i want close it
so anything else needs to be changed or can my first openssl cimmoit be merged :)

so anything else needs to be changed or can my first openssl commit be merged :)

Almost there :wink:

good question why the files are marked as executable
i guess samba changed that because i saved the files over an windows network mount
ill remove the executable bit

meanwhile if found another bug
if the buffer to enrypt is bigger then 64k the crypto device on my board just enrypts 64k
so the buffer is not fully encrypted
should i open another PR for that or add the check here ?

I'd suggest a separate PR, it's a different problem.

To finish this up, you need to make update.  What you will see is error related changes, which is exactly as it should be.

the changes from make update are a bit different than the output of the git action
this code lines are not changed on my machine
+static int ERR_AFALG_lib(void)
+{

if (lib_code == 0)

   lib_code = ERR_get_next_error_library();

return lib_code;
+}

but that wan't compile because its an used static function
and the check_ansi does not work because i get many error like this one
error: this statement may fall through [-Werror=implicit-fallthrough=]
im using gcc 11.2

is the code ok now ?

so the ansi check is failing because the define of PRId64 ist not compatibel with ansi c
i don't now an other portable way of printing an 64 Bit integer
i could build a workaround for that but i think that will be realy ugly
is it accaptable that the anso check fails for afalg ?
i dont think there is any system which supports afalg and needs ansi style code
maybe the afalg engine should be disabled for that check ?

Please avoid merge commits. Use git rebase and git push --force instead if you need to resolve conflicts.

can someone run the github actions ?

ok
i thinks it looks good now

so can it be merged ?
then i will start my next PR
that will be a bugfix related how ZERO_COPY ist used in afalg

It will be merged after 24h waiting period.

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Squashed the commits and merged to master branch. Thank you for your contribution.


No suggestion for for existing  words with mistake.

Hi, I'm not sure if spellcorrection is in scope of this plugin but I noticed dict suggest words only for new  typed in words, but it wont suggest anything of existing words with spell mistake:
https://user-images.githubusercontent.com/13521338/153725534-f5c9a3b5-1dab-4f75-8d2d-ccebe9872c3f.mp4
In video above TabNine suggested correction, but I got not entries from cmp-dict.
Any chances for cmp-dict to suggest correction for  spelling mistakes?

Thank you very much. This is a bug. I will fix it. The correct behavior is to look before the cursor, so the candidate appears for 'sent'.

9ae00514826bd26b84d86d67ed999cb4155c33e4

thanks. Btw. is there way to force cmp-dict  to take whole word under cursor into account?  The way it works now, it only 'checks' for letter that are before cursor. It would be cool if it could check whole workd  (and replace it too, rather than what is before cursor).
I will close this.

If you bring the cursor to the end of a word with ea, it will consider the whole word, but isn't that what you're talking about?

yest that works ok.  I just wish, cmp-dict could work if cursor in in the middle if word (kind of like cmp-tabnine where it takes into account whole word) , But that is not big deal .  Thanks for the fix


Version 9.3.1 broke compatibility with node 4.4.x and lower

This commit, used Buffer.alloc and Buffer.from which were backported in v4.5.0, I think this should have been major version release.

I agree. We had some builds using node 4.3.2 start failing this morning and tracked it down to nock changing from 9.3.0 to 9.3.1.

9.3.2 will resolve the issue

Thanks @PizzaAficionado

Done via https://github.com/node-nock/nock/pull/1144


feat: Update crus flows

wip: getting started
fleshing out the ability to add more than 1 bill

Current dependencies on/for this PR:

main

PR #13   👈

This stack of pull requests is managed by Graphite.


Improve error handling

This PR allows the host application to handle both load-time and runtime errors related to plugins.

new PluginStore option pluginErrorHandler

if errorDetails.loadError is true, the error has occurred while loading the given plugin
if errorDetails.loadError is false, the error was reported for an already loaded plugin (see below)

pluginErrorHandler: (manifest: PluginManifest, errorDetails: PluginErrorDetails) => void;

new PluginStore interface method reportPluginError

if the given plugin is currently loaded, pass provided error details to pluginErrorHandler
if the given plugin is not currently loaded, issue a console warning and do nothing

reportPluginError: (pluginName: string, errorMessage: string, errorCause?: unknown) => void;

useResolvedExtensions hook reports code reference resolution errors via reportPluginError API

useResolvedExtensions hook does not disable problematic plugins by default

aligns with openshift/console#12347
if necessary, problematic plugins can be disabled via the application provided pluginErrorHandler

const pluginStore = new PluginStore({
  // ... other options ...
  pluginErrorHandler: (manifest, errorDetails) => {
    if (!errorDetails.loadError && errorDetails.enabled) {
      pluginStore.disablePlugins([manifest.name]);
    }
  },
});

Codecov Report
Patch and project coverage have no change.

Comparison is base (9794d65) 40.05% compared to head (aaec4f9) 40.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #228   +/-   ##
=======================================
  Coverage   40.05%   40.05%
=======================================
  Files          69       69
  Lines        1685     1685
  Branches      362      362
=======================================
  Hits          675      675
  Misses        976      976
  Partials       34       34

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Closing in favor of #241


Blob mirror downloads don't announce blobs

The Issue
If an sd/head blob was downloaded via blob mirror, it's status is not set to announce.  @jackrobison working on a fix
System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

Fixed in https://github.com/lbryio/lbry/commit/fe43764bcb64e759b22a4e9e6547d58ea22374a3


As a ward nurse/doctor, I want to view and edit the todo list for each patient

So that I can have a reliable reference for tasks I need to facilitate for each patient

#42 is handling this


IAM configuration issues

Describe the bug
The deployment script for iam has the following issues

The default Login journey applies to the user managed object, rather than alpha_user
The gateway profile ig-agent is missing from the alpha realm
The test remote consent service has the incorrect URL - should be https://obdemo.dev.forgerock.financial/rcs

To Reproduce
Steps to reproduce the behaviour:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behaviour
A clear and concise description of what you expected to happen.
Current behaviour
A clear and concise description of what the current behaviour.
Screenshots
OPTIONAL - If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
OPTIONAL

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):
OPTIONAL

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
OPTIONAL - Add any other context about the problem here.
Workaround
OPTIONAL - If you have a workaround, please put the details here (remove this text)
Code analysis
OPTIONAL - If you already investigated the code, please share your finding here (remove this text)
Release Notes
Affected App: X
Description: X

Error in content - recreating


Allow configuring a maximum number of nodes put into orchestrated maintenance mode

When using the State API to put a storage node into safe maintenance mode, only one node is allowed in such a state, regardless of the redundancy levels we have set.
For example, in a 6x redundancy 3-group setup (2x redundancy per group) we would expect to be able to set a node in group0 and a node in group1 into maintenance mode.

We assume this is no longer relevant. Please reopen if still valid.


c# debugging - make tuning of log level work on linux

currently all debug logs are written to server (even if dotnet_mode: "Release")

fixed in v5.3.2


Feat/59 setup backend project structure

Please use this format and structure when implementing the backend. I've been looking into and trying ways to avoid initializing the sequelize instance every time we want to connect to db. And the most effective way that I could find is by using sequelize models, but I still can't get it to work correctly. These are just some TODOs that we can look into next, let's prioritize implementing our API endpoints for now (i.e., follow what we're doing for the testEndpoint). You can test the sample endpoint by opening localhost:8000/appstatus or localhost:8000/user/testEndpoint on your browser after doing all the steps mentioned in the README.

Oh just realized you are using cross-env. Was this necessary?


Coverlet report not generating for dotnet core project

This appears to be a common ticket, so apologies if you roll your eyes and point me to an existing ticket..
I am running this in TeamCity:
dotnet test `
%teamcity.build.checkoutDir%\UnitTests\UnitTests.csproj `
--no-build `
-c Release `
-l "console;verbosity=normal" `
-a %teamcity.build.checkoutDir%\UnitTests\bin\Release\netcoreapp3.1 `
/p:CollectCoverage=true `
/p:CoverletOutputFormat=teamcity `
/p:CoverletOutput='./coverlet/'

in the build log, it is clearly generating the correct output (unfortunately have to show a partial screenshot due to this being work code sigh..)

but on the build agent, there is no report, in fact.. just an empty folder..

Can you help me out here? I am obviously getting the stats raw into TC, which is progress from an hour or so ago.. but I am clearly missing something somewhere!

No probs, welcome to coverlet repo,
out implementation of teamcity is based on service message https://github.com/tonerdo/coverlet/blob/master/src/coverlet.core/Reporters/TeamCityReporter.cs
https://www.jetbrains.com/help/teamcity/build-script-interaction-with-teamcity.html#BuildScriptInteractionwithTeamCity-Reporting.NETCodeCoverageResults

ahh ok, so the way to get the full reporting in would be to use multiple formats?

ahh ok, so the way to get the full reporting in would be to use multiple formats?

Yep...if you're using .NET core app you should use vstest plat integration https://github.com/tonerdo/coverlet/blob/master/Documentation/VSTestIntegration.md because other way suffer of known issues https://github.com/tonerdo/coverlet/blob/master/Documentation/KnownIssues.md

Ok, thanks for the info.. bit unclear though with regards to:

vstest plat integration https://github.com/tonerdo/coverlet/blob/master/Documentation/VSTestIntegration.md

can that be used in addition to the output format flags/properties above?

can that be used in addition to the output format flags/properties above?

No no it's a complete different way to do coverage, coverlet is used through three "drivers"  msbuild(your way), .net tool and vstest integration.
Vstest integration is the most reliable(due to some test plat behaviour), so you should use the new way, take a look at our hello world sample https://github.com/tonerdo/coverlet/tree/master/Documentation/Examples/VSTest/HelloWorld

runsetting.xml is the way used by vstest platform to pass parameters in https://github.com/tonerdo/coverlet/blob/master/Documentation/VSTestIntegration.md#advanced-options-supported-via-runsettings

@WattsC-90 any news?Feel free to close if solved!

Close for stale conversation, feel free to reopen if needed.


the loss is aroung 20 for a long time

I start from the pretrained VGG-16 model,
but my loss is around 20 no matter how I adjust the learning rate or batchsize

@jamiechoi1995 please make sure you are following readme.md


subnet or iterate functions don't work

I'm not sure if I'm using the correct syntax or if something else is wrong. I can get this tool to work when using --vpc vpc-id but as suggested in the readme, my VPC is far too large and I'd like to break it down into subnets. I get the following error when trying to use the subnet feature as well as the iterate feature:
./mapall.py --region us-east-1 --subnet subnet-401c7b09
digraph G {
overlap=false
ranksep=1.6
splines=ortho
Traceback (most recent call last):
File "./mapall.py", line 1435, in
main()
File "./mapall.py", line 1431, in main
generate_map(args.output, args)
File "./mapall.py", line 1398, in generate_map
obj.draw(fh)
File "./mapall.py", line 328, in draw
if not self.inVpc(self.args.vpc) or not self.inSubnet(self.args.subnet):
File "./mapall.py", line 304, in inSubnet
if subnet and self['SubnetId'] != subnet:
File "./mapall.py", line 85, in getitem
return self.data.get(key, None)
AttributeError: 'Instance' object has no attribute 'get'

I also get the above, and the --iterate vpc fails with a different issue for me, but possibly because of a VPC with nothing connected to it, at a guess (didn't check, just speculating). Output here:
fred$ ./mapall.py --region ap-southeast-2 --iterate vpc
Traceback (most recent call last):
  File "./mapall.py", line 1449, in <module>
    main()
  File "./mapall.py", line 1442, in main
    generate_map(f, args)
  File "./mapall.py", line 1412, in generate_map
    obj.draw(fh)
  File "./mapall.py", line 1058, in draw
    if self.inVpc(self.args.vpc) and self.inSubnet(self.args.subnet):
  File "./mapall.py", line 1073, in inVpc
    for subnet in subnets.split(','):
AttributeError: 'NoneType' object has no attribute 'split'


Decouple Chargeback from ManageIQ/manageiq-consumption since it's not…

We are planning on archiving the ManageIQ/manageiq-consumption repository because we are not currently using it and do not have future plans to use it. Before that can happen, references in Chargeback need to be removed.

@gtanzillo is this the removal of the code developed with @chargio ?  if so, I would like to discuss that before it is removed.  /cc @Fryguy

That's correct, this is the removal of the "Chargio" integration. I'll make this PR WIP so that we can discuss

It is a pity but I understand why you don't want to have code that you are not using.
I still believe that this code is faster and easier to maintain that the existing one, though.

we need to remove also those methods():
ChargeableField#showback_measure
ChargeableField#showback_dimension

Chargeback#showback_category
ChargebackRateDetail#showback_unit

but I think your reason was to just unplugging consumption repo(those methods became just dead code after merging this PR) - so I can do it in follow up 👍
otherwise looks good to me 👍  Thanks!

The code will still be in the repo so we can always bring it back.  However, right now, that repo has failing tests with no one to fix them, and the maintenance burden is high for something we are not actually using.

@lpichler I'm assuming that we would also need a migration to remove all of the showback_* tables.

This seems ready to go, so can it be un-WIP-ed?

@gtanzillo I didn't realize this code was at a mergeable state - can you rebase?

@Fryguy are you sure we want to remove this?  I thought that this was the strategic direction for chargeback.

@Fryguy See https://github.com/ManageIQ/manageiq/pull/19550#issuecomment-562231715 - While there are no failing tests at the moment, it is still a maintenance overhead.


Timestamp request fails on 201

the sigstore timestamp project returns a 201 - created.  Witness errors out on the response

this is fixed with https://github.com/testifysec/go-witness/pull/29


1.0.5-alpha.3: Use querySelector to validate mwb epub file

Use querySelector to validate epub file

Alpha/1.0.6 not yet ready


Restore tests that now report the correct events.

The change to introduce Transmitter and Exchange has caused us to report
the correct events. Yay!

Great job on rearchitecting this!


Encapsulate Credentials behind a standard interface.

Credentials should be constructed using the various constructor functions. All constructors return the
Credentials interface which may be passed when creating a new client using the NewAuthenticatedClient() function.
I have retained backwards compatibility by leaving the existing NewClient() function in place for now.

@aeden I'm fine to merge the changes, but I have one question for you before proceeding. Are the changes targeting the current version of the API, or are they targeting API v2?

Are the changes targeting the current version of the API, or are they targeting API v2?

The changes I provided here should be compatible with either. Granted, if you try an unsupported authentication method then the API will error, but that's what I'd expect.
Let me reverse the question: is this library supposed to support v1, v2 or both?

Let me reverse the question: is this library supposed to support v1, v2 or both?

That's exactly the key of my question. I don't feel like I want to mix v1 and v2 in the same client. I'd like to keep them separate.
I still haven't decided whether master will be v1 or v2. I'm tempted to keep master targeting v1 for now, as even if this library is incomplete, it still adds some value as it implements a reasonable number of endpoints.
Therefore, my proposal is that this patch will include only the refactoring for v1. Then we start an api-v2 branch (as we're doing for the Ruby project) that we use as a (temporary) parallel master for API v2.

Am I correct in that the only change I need to make is to remove the OAuth credentials part?

Yes, that's correct.

@weppos how's that?


When will the finetune guideline be published?

Hello! Thank you for your awesome work! I'd like to ask when will the finetune guideline of Solo be published. I hope to do further research based on solo.

Hi Hongyuan,
Thanks for your interest! We have uploaded the code and guidance for instruction fine-tuning.
However, we are still working on uploading all our data for instruction fine-tuning to the huggingface since it is too large (100+G). We will complete this soon.

Really looking forward to it.


Different shape of conferences on conference list vs conference individual

Single conference:
{
    "data": {
        "id": "088b6df9-98e8-4f55-b0c4-5ac95671c221",
        "type": "conferences",
        "attributes": {
            "title": "asdf",
            "description": "asdf",
            "url": "asdf",
            "cfp_url": "",
            "starts_at": "2019-08-02 00:00:00",
            "ends_at": "2019-10-04 00:00:00",
            "cfp_starts_at": "2019-05-01 00:00:00",
            "cfp_ends_at": "2019-07-19 00:00:00"
        }
    }
}

Multiple conferences:
{
    "data": [
        {
            "id": "088b6df9-98e8-4f55-b0c4-5ac95671c221",
            "title": "asdf",
            "description": "asdf",
            "url": "asdf",
            "author_id": 1,
            "starts_at": "2019-08-02 00:00:00",
            "ends_at": "2019-10-04 00:00:00",
            "cfp_starts_at": "2019-05-01 00:00:00",
            "cfp_ends_at": "2019-07-19 00:00:00",
            "created_at": "2019-05-20 18:46:00",
            "updated_at": "2019-05-20 18:47:00",
            "cfp_url": "",
            "is_approved": true,
            "is_shared": false,
            "calling_all_papers_id": null
        },
        {}, {}, {}
    ]
}

The documentation shows the embedded attributes and we've done that intentionally in the ApiResource objects, so I believe this was an oversight in not doing it in the list.
Opening this because I want to talk to consumers about the impact before I make the change.

@rdohms Any input here?

@rdohms I'm about to change the API for this project. Please let me know in the next day or two if that's going to be a problem for Pronto!

@mattstauffer i don't rely on the conference endpoints yet, so we should be fine.

Thanks @rdohms!


Dev

project initiated with next js version 14
pages routing configured
antd-design lib added and application configured

Mergin dev to main


Pycurl error

Hi, thanks for the repository! I created a completely new conda environment on Ubuntu, installed only label-maker and now are getting this error when calling label-maker in cli:
Traceback (most recent call last):
  File "/home/philip/anaconda3/envs/label_maker/bin/label-maker", line 5, in <module>
    from label_maker.main import cli
  File "/home/philip/anaconda3/envs/label_maker/lib/python3.6/site-packages/label_maker/main.py", line 13, in <module>
    from label_maker.download import download_mbtiles
  File "/home/philip/anaconda3/envs/label_maker/lib/python3.6/site-packages/label_maker/download.py", line 6, in <module>
    from homura import download
  File "/home/philip/anaconda3/envs/label_maker/lib/python3.6/site-packages/homura.py", line 8, in <module>
    import pycurl
ImportError: /home/philip/anaconda3/envs/label_maker/lib/python3.6/site-packages/pycurl.cpython-36m-x86_64-linux-gnu.so: undefined symbol: CRYPTO_set_locking_callback

Any pointers? I tried upgrading the pycurl version, but then it shows:
ImportError: pycurl: libcurl link-time version (7.58.0) is older than compile-time version (7.60.0)
Thanks!

I solved it by doing conda install pycurl after pip installing label-maker.


remoteFilter results in undefined

Hi there,
I'm trying to use remoteFilter with v1.0.0. My code looks somehing like this:
  $('#dict').atwho({
    at: ":",
    callbacks: {
      remoteFilter: function(query, callback) {
        $.getJSON("/search", {q: query}, function(data) {  // /search returns a json-structure
          console.log(data.items, query)  // in data.items is an string array, for example ['x', 'y', 'z', 'a']
          callback(['x', 'y', 'z', 'a']) // for easy testing I'll use the array instead of data.itmes
        });
      }
    }
  });

If I now trigger the at, it shows four undefined instead of x, y, z and a. But console.log shows the correct array, so I'll assume it's correcly loaded via ajax.
Is something wrong with my code? I have overseen something?
Thank you very much!

Oh. the default data structure should be :
[{name: "one", name: "two", name: "three"}]

The fix can let the callback accept an array.

Thank you, works great!


Get and extract first data binding functions should be able to take props

This would enable removing the standard code for finding the screenView data bindings.

Get first data binding functions fixed.

Fixed


Does not work at ALL

Even with the crystal clear text "Photoshop" and computer typed text and with training the SwiftOCR is not capable of detecting anything. It always give wrong recognized text. Here is the image.

And it guesses:
HOYHLASSA

You need to use the training app and add recognition for lowercase letters because (by default) it only trains on upper case letters. Then go to your pod and replace OCR-Network with the OCR-Network in your desktop.


merge package from arlac77/npm-package-template

.travis.yml

chore(travis): remove node versions 10.2
chore(travis): add node versions 10.2.1

:tada: This PR is included in version 4.17.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


drivers: clock_control: Migrate to new logging subsys

Migrate from SYS_LOG to LOG logging mechanism.
Signed-off-by: Olivier Martin<EMAIL_ADDRESS>

Codecov Report

Merging #9429 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9429   +/-   ##
=======================================
  Coverage   52.17%   52.17%
=======================================
  Files         212      212
  Lines       25892    25892
  Branches     5561     5561
=======================================
  Hits        13508    13508
  Misses      10126    10126
  Partials     2258     2258

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b3a7ed...dbe1a65. Read the comment docs.

I have rebased the pull-request to fix the conflict after this pull-request has been merged https://github.com/zephyrproject-rtos/zephyr/commit/8cf8db3a73aa0658d728006e93d9ef5e0361a1b2

cherrypicked in #10029

addressed in #10029


jax.numpy: better docstring for allclose and isclose functions

Better docstring added for jax.numpy.allclose and jax.numpy.isclose.
Part of 21461

evaluation condition inserted and text fixed.


OAK-10542 : getLiveRevision must inspect split docs if local deleted …

…does not contain most recent committed revision.
This is currently waiting for https://github.com/apache/jackrabbit-oak/pull/1195 to be merged first - after which the tests will be unignored.

it disables an optimization that avoids looking at split docs; so in the worst case, we'd see a performance degradation, right?

right.

in most of the cases there wouldn't be any split documents anyway (in which cases this change is a virtual no-op)
in those cases where there are split document it would mostly not consider them neither as it isMostRecentCommitted would return true (in which case this change should not have any noticeable performance impact)
but in heavily updated nodes it would have an impact, yes. but that's also where the fix is needed.

btw: it does follow the same logic as in getNodeAtRevision (here)

Oh, good point.
Maybe open a TODO ticket to refactor this later into a single utility method?

yes I was considering a refactoring actually. there's a few subtleties and non-straight-forwards, so I opted out for now. Will add a TODO

change of plan : refactored the code duplication. /cc @reschke


Import from @/deepmerge DENOIFY: DEPENDENCY UNMET (BUILTIN)

Bug Report
This line is throwing in deno:
https://github.com/RebeccaStevens/deepmerge-ts/blob/0075d00a5fb8b905b390c8f91162760379dc41c5/dist/deno/types/options.ts#L1
Expected behavior
Expect it to Just Work™ :-)
Actual behavior
error: Relative import path "@/deepmerge DENOIFY: DEPENDENCY UNMET (BUILTIN)" not prefixed with / or ./ or ../
    at https://deno.land/x/deepmergets@v4.0.0/dist/deno/types/options.ts:1:54

Steps to reproduce
Import this into a deno project
Proposed changes
I guess the import is supposed to be ../deepmerge.ts but I suspect you're using a build process to build the deno version and so it seems like that needs to be fixed?

For any other impatient souls, I hot fixed this and it seems to work for me like so:
export { deepmerge } from "https://raw.githubusercontent.com/GenerousLabs/deepmerge-ts/3004e954dd06bfc3e2aaf7c98bc97a50c635fb10/dist/deno/mod.ts";


[RFC] Partitioning for a given backend

Description
Request for comments for the next PR on partitioning for a given backend

Printing graph statistics after call to optimize_for
Documentation: adding a markdown file with description and example(s)
Updating lib_subgraph examples to add ones using gluon

References

Recent related PRs: #15969 #15886

This feature has been merged and will be included as part of the mxnet 2.0. Thank you @mseth10


Add start-date parameter to CoarseUniverseGenerator

When CoarseUniverseGenerator generates fundamental data it starts from the date of the latest file in the fundamental data folder.
This works well if one need to generate newer data but did not work for me when I had to generate data for local backtesting from 1st January 2000.
The PR adds a new parameter start-date to the config.json in CoarseUniverseGenerator. This parameter is optional. If it is omitted the code would work as before.

Thank you for the PR @mushketyk!

If possible could you please rename "start-date" to something more specific (so people don't get confused with the algorithm start date) -- e.g. "coarse-universe-generator-start-date"

Please remove the data-folder changes from the config; they look like accidental anyway.

Overall looks good and we can merge in once those adjustments are fixed.

Hi @jaredbroad,
Thank you for your review!
I've renamed the parameter to "coarse-universe-generator-start-date" and changed data directory to "../../../Data" (same is used by Google and Yahoo downloaders), this should change these kind of issues in the future.


No way to set device

There is currently no way to set the device.
E.g. If I wanted to set the recording device to plughw:1,0, etc.
The following code in bumble-node.js after line 118 will add this feature.
	let device; 	if (this.options && this.options.device) { 		device = this.options.device; 	}
	this.recorder = new AudioRecorder({ 		device, 		program, 		silence: 0, 		paths: this.options ? this.options.paths : null 	});
https://github.com/ncpleslie/bumblebee-hotword-node/blob/master/lib/bumblebee-node.js
This could also be the reason why it closes for some users #4 #3
Failing to set a device on a Linux computer will just closeout.
I've tested this fix on a Raspbian where I've used node-audiorecorder in a few other places and can confirm it works correctly.
If you want, I can make a pull request to remedy this issue.

Okay great, I added the lines here:
https://github.com/jaxcore/bumblebee-hotword-node/commit/14dd0e5301f756e68c20b4a8846588f004020c9e
Can you confirm this works, and I'll republish it?

Yip. Works for me.
Tested on a Raspberry Pi 4 running Raspbian and passing plughw:2,0 through.
I used "bumblebee-hotword-node": "https://github.com/jaxcore/bumblebee-hotword-node/tarball/master"
Thanks for the update and the awesome project

Great, thanks for the help.  That's been published as v0.1.1


feat(e2e): relayer tests framework

Description:
Commit Message
add: client creation
add: connections handshake on both chains.
add: relayer crash and recover

see the guidelines for commit messages.
Changelog Entry
adds: relayer IBC test framework

Checklist:

[x] I have performed a self-review of my own code
[x] I have documented my code in accordance with the documentation guidelines
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have run the unit tests
[x] I only have one commit (if not, squash them into one commit).
[x] I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Closes:
#506, #592, #604.


return string version if parsed number is Infinity

I have run into an issue where the string version of 476677170e9305605797914192894822 is parsed as Infinity, which is expected. I'm proposing to return the string value if it's Infinity.
Or perhaps this should be not the default behavior, but an option passed to the constructor?

Coverage increased (+0.02%) to 97.654% when pulling 5959ddd9f29537d41c6a483a858fcc56b519c802 on geoffdutton:parse_number_infinity into 0f0a2980b3db5366b3d50e4d0da422cb7af100c9 on Leonidas-from-XIV:master.

Actually, I just realized I can do a simple custom value processor. Disregard this PR.


Some columns listing operators are displayed wrongly.

Logical OR 	`x 	y`

and
Conditional OR 	`x

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 362f3e73-a902-45e6-382d-328a4552a235
Version Independent ID: d4253465-4bfc-e473-f745-0d5e1ff4e76c
Content: Introduction
Content Source: spec/introduction.md
Product: dotnet-csharp
GitHub Login: @dotnet-bot
Microsoft Alias: wiwagn

This is related to #6335, which was fixed by dotnet/csharplang#1807.
However, now in GitHub interface, the table is not rendered correctly:

@BillWagner was the rendering logic updated such that the code-fenced pipe symbols must be escaped in the table? dotnet/csharplang#1807 should be reverted, then?

@mairaw This issue has been resolved

This is fixed now. Thanks for letting us know @FMNSSun.