Crash on Bluestacks 64-bit

Before opening an issue:

[x] I tested the latest release
[x] I looked at other issues (even the closed ones)
[x] I read the Troubleshooting Guide
[x] I'll fill this template properly

Describe the bug
FGA crashes on Bluestacks 64-bit
Screenshots

The issue here seems to bit libhoudini (ARM to x86/64 translation) isn't working well with the app.
Proposed solution is to add x86 and x86_64 to the ndk > abiFilters section in gradle. I have tested and confirmed it's working.
Device Info (please fill at-least 'Device model'):

Device model: Bluestacks 64-bit

Added a simple PR to fix. Tested working on my Bluestacks

I dont want to open a new issue post, because I dont think it's a problem that affects everyone. Probably just me.
So I'm going to post it here instead. I apologize for hijacking your post @thai-ng. I will post this comment as a separate issue if you find this comment troublesome.
I'm using Bluestacks 32-bit, build: v<IP_ADDRESS>0
When I was using the Canary build, and granted the .apk/app permission to overlay, it simply freezes when starting service.
It does not show a button for me.
Same problem occurs with older builds, as far back as April 2020. I dont know if it's a compatibility issue or not.
Lastly, I want to ask where is the Support Image Maker script / section in the latest Canary build?

Image maker was moved to the very first option in the battle config list when you press play.

I had the same thing happen to me! I found a way to work around the issue though. In Settings, go to the Engine tab and set the Graphics engine to Compatibility. Once I did that, everything started working.

This is written in the Troubleshooting Guide, which every Issue template asks you to check first, under the Emulator section.

It's hard to spot that when I was tunneling visioning, trying to debloat bluestacks, while simultaneously trying to get the app working with a 24 hour limit left on the lottery.
Also, this was under the windows section. Adding a copy and paste text into the blue stacks will help people like me in the future.

The app works great btw. Really sophisticated, elegant and easy to use.

Since bluestack released a new version I tried it, but still FGA doesn't work and the emulator will crash as soon as I start the service :(
My versione is <IP_ADDRESS>1 N32

@Ansem93 Your issue sounds like you didn't set the display to compatibility mode.

It now "works".
FGA Build 1589
Bluestack <IP_ADDRESS>26 N32
I Enabled "use Root for screenshots" in the advanced options.
The issue is that if I click on the play button nothing happen :(

I may have been wrong about root working, have to check later.

Double checked now:
Root disabled -> the service crash istantly but FGA isn't blocked anymore compared to before
Root enabled -> The service is correctly running, but the play button is not working. Not sure if I should open a new ticket for that :(

For now just switch to 32 bit.

My bad, I didn't see the update in the FAQ :( I tried everything:
-> I left the engine in performance mode and it works
-> After editing the bluestack file the play button now respond when clicked!
-> Root still need to be enabled
To me this case is closed :D


Added Feature Card item 21

Solved issue #189

My profile url :
https://www.clueless.tech/profile/40214392
@Rajdip019


Updated agent so connection timeouts cause a new DNS resolution, fixing issues where DNS changes.

Looks good, tested locally across 1.8, 1.9, 2.0, 2.1, 2.2 and JRuby, and all seemed mostly good.
I am getting a consistent failing test in JRuby 1.9 that seems unrelated ( it passes in master ):
-> % be rspec spec
  1) Secure without cert verify behaves like Instrumental Agent Instrumental::Agent enabled should allow outgoing metrics to be stopped
     Failure/Error: server.commands.join("\n").should include("increment foo.baz 1 #{tm.to_i}")
       expected "" to include "increment foo.baz 1<PHONE_NUMBER>"

Do you see same?
-> % ruby -v
jruby 1.7.19 (1.9.3p551) 2015-01-29 20786bd on Java HotSpot(TM) 64-Bit Server VM 1.8.0_45-b14 +jit [darwin-x86_64]

I see the same failure in master:
jason@charlie [master] instrumental_agent $ rspec spec/agent_spec.rb:305
Run options: include {:locations=>{"./spec/agent_spec.rb"=>[305]}}
  1) Secure without cert verify behaves like Instrumental Agent Instrumental::Agent enabled should allow outgoing metrics to be stopped
     Failure/Error: server.commands.join("\n").should include("increment foo.baz 1 #{tm.to_i}")
       expected "" to include "increment foo.baz 1<PHONE_NUMBER>"
     Shared Example Group: "Instrumental Agent" called from ./spec/agent_spec.rb:568
     # ./spec/agent_spec.rb:305:in `(root)'

 2/2 |========================= 100 ==========================>| Time: 00:00:01

Finished in 1.58 seconds
2 examples, 1 failure

Failed examples:

rspec ./spec/agent_spec.rb:298 # Secure without cert verify behaves like Instrumental Agent Instrumental::Agent enabled should allow outgoing metrics to be stopped
jason@charlie [master] instrumental_agent $ ruby -v
jruby 1.7.19 (1.9.3p551) 2015-01-29 20786bd on Java HotSpot(TM) 64-Bit Server VM 1.8.0_45-b14 +jit [darwin-x86_64]

I'll dig a little and see what I can find.
Are we assuming that the travis 1.9.3 failure was bogus since it passed locally?

Yeah, I think the Travis failure is bogus since I can get that to pass reliably locally. I wasn't able to get JRuby to pass in either branch locally, but I'll try again and see what happens.

After some more looking at this, I think the test is bad, and the badness of the test is exhibited more clearly in JRuby ( which would allow for parallel operation, and thus exhibit the bad conditions ). In any case, not related to this PR, so :+1:.


Introduce keepEmptyTags option

This came from issue #703 where if the content contains only empty tags, the content gets completely removed. It currently assumes if there is no text, the tags are not wanted or necessary. This is not always the case.
This introduces a new option for keepEmptyTags. To stay consistent with current functionality, the default value is false. Setting the value to true, the content will not be reset to an empty string even when there is not text in the tags.

What about #861


[BUG] Adding/removing svg elements breaks tooltip of existing elements

Bug description
Odd one but, when svg elements are added/removed, the existing svg element's tooltips stop working.
Version of Package
v5.21.6
To Reproduce
Reproduction: https://codesandbox.io/s/ecstatic-torvalds-vmy6qm?file=/src/index.tsx
Click the "show" button then hover over the black box, you'll note that the tooltip stops showing up.
There are ways to reproduce it outside svgs but they'll require unconventional code, SVG is the most straightforward way to demo this.
Expected behavior
Tooltip should still show up on the existing svg elements.
Screenshots
See code sandbox reproduction
Thanks!

It would make sense if the second svg failed to display the tooltip, since the tooltip only checks for potential anchors at the time it is mounted on the DOM, so elements added afterwards are usually ignored.
As a workaround, you can force a re-render on the tooltip so that it does the check again. The easiest way in your example is like this:
<Tooltip id="my-tooltip" key={visible} />

but you can try other ways.
This isn't a fix though, so we'll leave this open for now.

Thanks for the reply and great library, love the work you're putting in!

It would make sense if the second svg failed to display the tooltip

My initial thought as well, odd that the first one fails.
Since our svg is scattered across various components, passing around the key is a slight pain, our workaround is:
  useEffect(() => {
    const elements = document.querySelectorAll("rect");

    elements.forEach((element) => {
      const id = element.getAttribute("data-tooltip-id")!;
      const content = element.getAttribute("data-tooltip-content")!;
      element.setAttribute("data-tooltip-content", content);
      element.setAttribute("data-tooltip-id", id);
    });
  }, [visible]);

(which I'm not completely certain why it works).

@fatton139 I'd have to check, but very likely that works because updating the data-tooltip-content attribute of an anchor triggers a re-render, which makes the tooltip check again for all anchors.
Glad to know it works for now for your project, and we'll definitely be investigating this.

If it helps, here is an example outside an SVG:
https://codesandbox.io/s/nostalgic-heisenberg-tkz68f?file=/src/App.tsx

Considering 90% of bugs reported don't include a reproducible example (these are the most fun to debug 🙃🙃🙃), this will be more than enough. Thanks for taking the time.

For future reference

Whelp, that's embarassing. Sneaky regression bugs.
Feel free to use<EMAIL_ADDRESS>That's the only change from v5.21.6, so don't worry about the beta tag. Once we do an official release, we'll close this and you should be able to upgrade without trouble.
Confirming it works with the beta version

Tested on our end and works brilliantly! Thanks for the quick resolution! 💖

The beta version you mentioned fixed a similar issue for a project I'm working on and we are using the data-tooltip-id only (without anchorSelect).
In our case we are adding a new element with tooltip data-attributes after a POST API call, and only the added element would show the tooltip without refresh.

Fix available on official release<EMAIL_ADDRESS>


Responsive on mobile in landscape mode

The cleaver sideshows look really nice in a mobile device, especially in portrait mode the responsive design works well.
But the landscape view is less well:
I used a Samsung S3: with FireFox Mobile it is a bit crunched-up.
On mobile Chrome the portrait mode works well too, but the landscape mode is a mess: the layout collapses and can't navigate (or it hangs.. not sure :): I seems as if the arrow-controls are behind the content?

Closing for amount of time without interaction.


AzureChat not supporting getting the temperature inside the classic predictor

Hi Team,
I was trying to replicate the example for fine-tuning LM using SQL queries, I am using "from langchain_openai import AzureChatOpenAI" as LM and getting the following error when running program = dspy.TypedPredictor("context, question -> sql_query") line, please find the attached screenshot for your reference

We need to use dspy AzureOpenAI turbo = dspy.AzureOpenAI(     api_key=os.environ["AZURE_OPENAI_API_KEY"],     api_base=os.environ["AZURE_OPENAI_ENDPOINT"],     api_version=os.environ["OPENAI_API_VERSION"],     deployment_id = os.environ["DEPLOYMENT_NAME"],     max_tokens=250 )


Save manifest JSON files to the configured analytical database

Is there an existing feature request for this?

[X] I have searched the existing issues

Describe the Feature
While is is great that DBT generates JSON structured artifact / logging metadata as described here: https://docs.getdbt.com/reference/artifacts/dbt-artifacts/#notes
...they are of little use if they are not saved to the configured analytical database.
If this was done , then a package like the tails.com DBT artifacts package would not need the cumbersome steps indicated at the end: https://github.com/tailsdotcom/dbt_artifacts, the steps where you need to upload these files to your database...
This is even more problematic when you are solely on DBT cloud, as we are.
So while I realize that DBT is an T-L tool , I think an exception must be made for DBT related logging metadata that, if it is structured as JSON, can (for example) be loaded to a Snowflake variant data type with ease.
Describe alternatives you've considered
Doing this manually; not scalable / maintainable
Who will this benefit?
Everyone that wants to do analytics on DBT metadata or needs to store this logging metadata for compliance
Are you interested in contributing this feature?
No response
Anything else?
No response

Hey @bashyroger, thanks for making this request! It is a great question and we have been thinking about it.
We believe the best way to support answering those questions must be via the dbt Cloud Metadata API. That’s the most reliable, resilient, least crufty way to access this info. We are aware that you still have to use the Admin API to get job ids to then pass over to Metadata API and it would be a separate step out of the normally scheduled dbt run. And actively looking for solutions to resolve it
At the same time:

We understand why dbt users want to access this information right within their warehouse (dbt models on dbt models!) It’s the tooling that feels comfortable to them!
It’s frustrating that dbt-core deployments via Airflow/Dagster/etc have this capability, whereas dbt Cloud users really don’t, outside of the PUT hack on Snowflake

So:

We should continue to drill into what use cases/questions are motivating this ask — and pass that information back to the Metadata team as valuable user feedback. One thing we are thinking of is an automated tap for loading from the Metadata API to warehouses.
We should look into the possibility of similar “for now” hacks on other databases, which are necessarily super specific to those databases. Niall (from Brooklyn Data Co, maintainer of the dbt_artifacts package) opened issues in dbt-redshift + dbt-bigquery. But this method has its own drawbacks, any failed step in a dbt Cloud job causes subsequent steps to be skipped. So the PUT hack on Snowflake (and comparable hacks on Redshift/BigQuery) would continue to have the limitation where if a job fails, its artifact won’t be uploaded.

Hello
Any news on this please?
Cheers


Add --use-float flag to generate_c_source

If you add --use-float, any floating point
decoding/encoding will be done using the
float type instead of the double type
This is to be used on ECUs that only
have a single-precision floating point
unit
NOTE: If a database file is using a type
called Double (as in, the Signal in the DBC
file specifies Double), then this autogenerated
code will still use the double type, since there
is no other valid way to handle this

closes #393

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

11 of 11 (100.0%)  changed or added relevant lines in 2 files are covered.
5 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.09%) to 95.84%

Files with Coverage Reduction
New Missed Lines
%

cantools/logreader.py
1
97.17%

cantools/subparsers/monitor.py
2
85.0%

cantools/subparsers/plot.py
2
97.58%

Totals

Change from base Build<PHONE_NUMBER>:
-0.09%

Covered Lines:
6105

Relevant Lines:
6370

💛  - Coveralls

Sorry, have been off to a business trip this week. @samc1213 can you already confirm that this would be ready to be merged?
To other users of the code generator: I you had the chance to try this, I would appreciate your feedback.

Yes this should be good to merge

After review this pull request has exactly the same purpose as mine.
I compare the code => better than mine (I miss adding the 'f' suffix)
I try it => similar result.
The only thing that should be added is an example in README.rst so we know this option exists.

@jgui Thank you for taking a look. I updated README.rst in a similar fashion to your PR.

Ok gentlemen, I'll merge now. Thank you both for your contribution.
You can expect a release later today.


Offline chat messages are not received in order

Win7 64 bits v2.0.11
From client A (online) I sent to client B (offline):
"A"
"B"
"C"
"D"
Client B received the following when connected:
"B"
"A"
"D"
"C"

This is a server issue. The client displays them in the order they are received from the server. @rhcastilhos Would you mind logging this on the server?

Sure..
https://github.com/OpenBazaar/openbazaar-go/issues/690


how to display additional information in the sankey chart tooltips

Version
4.8.0
Steps to reproduce
There are no details in the documentation about to display the additional information in the tooltips. Can you please help us to display the additional information in the report. Please find the data format below.
sample-sankey-code.txt
What is expected?
I would like to display additional information like Average sales,  total sales value between the edges.
What is actually happening?
Chart displays the source and destination node and value properly.

I'd like to suggest using  formatter callback function to get the data of node and assemble and return your information.
(params: Object|Array, ticket: string, callback: (ticket: string, html: string)) => string

Hi,
Thanks for your response, I have tried the callback function parameter but the tooltip is not visible in the front-end chart now. It has display earlier. Please find the sample code I have used in the JS file.
formatter: function(param, ticket, callback){
// console.log("param"+JSON.parse(param.dta.source[0]));
//	return ${param.source} -> ${param.target} : ${value};
for(var i=0; i<param.length; i++){
console.log("param -> "+param[i].value);
return param[i].value;
}
		}

Please let me know where I did a mistake here.

@Vignesvar-ap Hi, I suppose that the information you need is all in the first parameter in the callback function.
Here is a demo. https://gallery.echartsjs.com/editor.html?c=x-2oD3M18w&v=1

Dear @plainheart,
Thank you very much for your support that the given sample code is working for me.

@Vignesvar-ap Hi, I suppose that the information you need is all in the first parameter in the callback function. Here is a demo. https://gallery.echartsjs.com/editor.html?c=x-2oD3M18w&v=1

Link is broken, can you provide a new link please?


ERROR_SPIRV_INVALID_ID_REFERENCE when using mediump in functions

Using mediump inside functions fails reflection with SPV_REFLECT_RESULT_ERROR_SPIRV_INVALID_ID_REFERENCE
Something as simple as:
float saturate( float x )
{
	return clamp( x, 0, 1 );
}

void main()
{
	gl_Position = worldViewProj * vec4( vertex, 1.0 );
	outVs.uv0.xy = uv0.xy;
	outVs.uv0.x = saturate( uv0.x );
}

Will fail if the function is modified to either:
float saturate( mediump float x ) // fails
{
	return clamp( x, 0, 1 );
}

mediump float saturate( float x ) // fails
{
	return clamp( x, 0, 1 );
}

I'm attaching two shaders. One without mediump and its generated SPIRV (using glslang) which works.
The other one with mediump and its generated SPIRV (using glslang) which fails.
This may be a glslang bug, but I suspect it's SPIRV-Reflect's. spir-val says nothing and the shader is compilable by the driver.
To be more specific it fails here.
Shaders.zip
Update
It seems to be an interesting oddity that target_id appears to be always 10, regardless of the shader. It may be a coincidence... or not.
Update 2 FIX
OK I found out why it's crashing. With the addition of decoration parsing, it's pointing to SpvOpFunctionParameter and SpvOpExtInst which aren't normally parsed. Solution would be to either silently ignore the returned nullptr if it's just RelaxedPrecision decoration or to actually load these Ops:
diff --git a/spirv_reflect.c b/spirv_reflect.c
index 11163a9..a4b94c6 100644
--- a/spirv_reflect.c
+++ b/spirv_reflect.c
@@ -734,6 +734,16 @@ static SpvReflectResult ParseNodes(SpvReflectPrvParser* p_parser)
       }
       break;

+      // Needed for 'OpDecorate xx RelaxedPrecision' to work
+      // See https://github.com/KhronosGroup/SPIRV-Reflect/issues/134
+      case SpvOpFunctionParameter:
+      case SpvOpExtInst:
+      {
+        CHECKED_READU32(p_parser, p_node->word_offset + 1, p_node->result_type_id);
+        CHECKED_READU32(p_parser, p_node->word_offset + 2, p_node->result_id);
+      }
+      break;
+
       case SpvOpTypeStruct:
       {
         p_node->member_count = p_node->word_count - 2;
@@ -4935,4 +4945,4 @@ const char* spvReflectBlockVariableTypeName(
         return NULL;
     }
     return p_var->type_description->type_name;
-}
\ No newline at end of file
+}

Update 3
It happened again this time with an OpFMul. I don't think it's reasonable to load all those Ops. I'll just go with plan B and ignore the return value on RelaxedPrecision decorations.
This solution works for me:
diff --git a/spirv_reflect.c b/spirv_reflect.c
index 11163a9..bef1ade 100644
--- a/spirv_reflect.c
+++ b/spirv_reflect.c
@@ -1368,7 +1368,11 @@ static SpvReflectResult ParseDecorations(SpvReflectPrvParser* p_parser)
     uint32_t target_id = 0;
     CHECKED_READU32(p_parser, p_node->word_offset + 1, target_id);
     SpvReflectPrvNode* p_target_node = FindNode(p_parser, target_id);
     if (IsNull(p_target_node)) {
+      if (p_node->op == (uint32_t)SpvOpDecorate && decoration == SpvDecorationRelaxedPrecision) {
+        // Many OPs can be decorated that we don't care about. Ignore those
+        // See https://github.com/KhronosGroup/SPIRV-Reflect/issues/134
+        continue;
+      }
       return SPV_REFLECT_RESULT_ERROR_SPIRV_INVALID_ID_REFERENCE;
     }
     // Get decorations

Hi - thanks for the fix. I manually merged it in. Let me know if this comes up again.


Definition of Airfoil Types

I was having a look at how the airfoil types are defined. The function getprofileTEtype has three possible outputs:

Flat
Sharp
Round

This function seems to be quite dependent on the correct input format as the points must start at the TE on the HP side and move around the airfoil from HP to LP, finishing at the TE again on the LP side and then back to the original starting point. I believe it also requires that if the AF is a flatback, it starts with a node placed between the HP side and LP side and that this is the starting node (also finishing at that node). Which if I'm correct makes the function quite sensitive to having the correct coordinate inputs and that even if an airfoil has a large separation between the LP and HP at the TE, but no middle node, then it wouldn't be considered a flatback
Additionally, I noticed that when finding the first aerofoil that requires adhesive for creating a shell mesh with adhesive, the criteria for this is that the angle between the TE on the HP side and the TE on the LP size is less than 45 degrees. Would I be correct in thinking that this is similarly a method for defining whether an airfoil is flatback or sharp?
My main questions are really how I can ensure that the coordinates of any airfoil I use are correctly formatted and are there criteria for defining whether an airfoil is a flatback?

@ecamare, can you provide input here? This is something that would be good to clarify in our docs.


link has no focus style on Safari on MacOS

🐛 Bug Report
There is no focus style for links on Safari
🤔 Expected Behavior
It should be possible to tell which element has focus
😯 Current Behavior
Using https://react-spectrum.adobe.com/react-spectrum/Link.html tabbing to the links in the page shows no focus style.
https://user-images.githubusercontent.com/1724479/215899029-cb26abd2-9ca9-4001-9dd4-f99baf11d224.mov
💁 Possible Solution
Safari doesn't seem to support
text-decoration: underline double;

It does seem to support
text-decoration-line: underline;
text-decoration-style: double;

🔦 Context

💻 Code Sample

🌍 Your Environment

Software
Version(s)

react-spectrum
3

Browser
Safari 16.3

Operating System
MacOS 13.2

🧢 Your Company/Team

🕷 Tracking Issue (optional)

Appears Safari doesn't support the text-decoration: double underline shorthand, but does support text-decoration-line: double

I can resolve this by switching
  &:focus-ring {
    text-decoration: underline;
    text-decoration-style: double;
  }

to
  &:focus-ring {
    text-decoration-line: underline;
    text-decoration-style: double;
  }

but I don't think we should have to as the base CSS seems like it should work to me.
Is this a a parcel bug @devongovett ?

Appears so. Filed https://github.com/parcel-bundler/lightningcss/issues/411

Will need to do some followup work here when https://github.com/parcel-bundler/lightningcss/issues/411 is fixed

Need to update parcel lightning-css now that it is released.


refactor(connector): add amount conversion framework to payu

Type of Change

[ ] Bugfix
[ ] New feature
[ ] Enhancement
[x] Refactoring
[ ] Dependency updates
[ ] Documentation
[ ] CI/CD

Description
This PR adds amount conversion framework to payu, for sending to connector.
fixes #5961
Additional Changes

[ ] This PR modifies the API contract
[ ] This PR modifies the database schema
[ ] This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

[x] I formatted the code cargo +nightly fmt --all
[x] I addressed lints thrown by cargo clippy
[x] I reviewed the submitted code
[ ] I added unit tests for my changes where possible

Hey @rahulpatwal0922 Kindly look into the changes

Sure @gorakhnathy7 I Will make the requested changes.

@gorakhnathy7 @Sakilmostak changes done.

@gorakhnathy7 @Sakilmostak changes done.

hey @rahulpatwal0922 can you push one empty commit, we want to run the remaining checks before merging this.

@rahulpatwal0922 Can you resolve the conflicts

@rahulpatwal0922 Can you resolve the conflicts

sure


Expose new isReady method

Related to #1562 and #1559

There seems to be a linting issue, but I cannot find anything wrong, the actions output is also not clear... any pointers?

Ah, nvm, found the linting issue, I need to run ./gradlew googleJavaFormat

undefined is not a function Not sure the method is correctly exposed...

I guess something like:
export const isReadyAndroid = (): Promise<boolean> =>
  getNativeModule(). isReadyAndroid();

is missing in the src/iap.ts

You are right, here is a new PR, please do check it carefully since I don't understand all the internals of the package
https://github.com/dooboolab/react-native-iap/pull/1604/files


There is still external CSS when inlineSSRStyles is true

Environment

Operating System: Linux
Node Version:     v16.16.0
Nuxt Version:     3.6.0
Nitro Version:    2.5.1
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      devtools, experimental
Runtime Modules:  -
Build Modules:    -

Reproduction
repo: https://github.com/abdAbdaldeen/nuxt-3-inlineSSRStyles
Describe the bug
The current behavior:
The component style will be added as external CSS when it has been reused in more than one place even if inlineSSRStyles: true,

please note that:

component-1 is the reused component
component-2 is used only once

The expected behavior:
all styles must be inline
same as NUXT 2 when you set build.extractCSS = false
https://v2.nuxt.com/docs/configuration-glossary/configuration-build/#extractcss
Additional context
No response
Logs
No response

By design, inlineSSRStyles doesn't inline all CSS. This is for several reasons:

we want to keep CSS files external so the CSS does not have to be added to the JS bundle (for client-side navigation)
therefore although we can inline CSS on server renders, we still have to have CSS files.
as much as possible we want to reduce duplication, so if we inline styles we shouldn't also load them in CSS if possible

However, there's definitely space for improving this implementation. Contribution is very welcome, but this issue itself is not a bug.

@danielroe Thanks, but I still have a question, is there any way to inline all CSS?

Not yet, no.


First attempt at basic axum-style state management

First attempt at Axum-style state management. The final PR should have:

[x] Routers for atspi::Event
[x] Handlers for atspi::Event
[x] Routers for OdiliaCommand
[x] Handlers for OdiliaCommand
[ ] Routers for input mechanisms
[ ] Handlers for input mechanisms

All should be able to implement some kind of state extraction, through types like the following:

[x] LastFocusedItem
[x] CurrentItem
[x] CaretPosition
[x] LastCaretPosition

Feel free to add additional items in the comments of this PR.
For right now, I've put together a basic EventHandlers type, that is able to connect up atspi events to various routers. At this time, I haven't seen how to add all the various parameters to a function yet, that's still to work on.
I'm hoping this makes for a more readable codebase. It sort of hides some of the complexity.

Blocked on https://github.com/odilia-app/atspi/issues/176

Now unblocked, but stil need to refactor a bunch to get the EventTypeProperties working when type erased. We can store it in fields as static strings (should be cheap that way).

alright, this is looking even better. Now, we have to make sure all the functionality of the current screenreader is converted to this new way of doing things, and seak to furthermore simplify things as regards the tower module and its associated services and so on. By that, I mean using tower provided auxiliary types, especially so that we may not have to define services manually, with structures, instead using cloasures and functions whenever possible, same for the layer function, better use that than having to make our own types for those. Also, we should definitely get rid of the nightly requirement, those toolchains are relatively unstable, and we want people contributing to odilia, including future selves, to have to do less, not more, to get up and running, and nightly for something like this is certainly not contributing to that.

we should definitely get rid of the nightly requirement

My argument against this is that the stabilization PR is already open and is one of the major hurdles in getting 2024 capture rules merged; the Rust team clearly has a pretty massive weight on them for this issue, and I have very strong faith this is very much in the "almost done" category—especially if it's going to be done by the end of this year.

well, another issue is that our CI doesn't build nightly as far as I know for one, and for another, distros such as debian and ubuntu package relatively old versions of rustc, rustup, etc, and having to be on the peek latest and greattest for this feature isn't the best user experience, especially if one has to actively opt into nightly to build this. Then, perhaps we should delay merging this till it's stabilised in rustc, so that people don't have to use nightly or RUSTC_BOOTSTRAP=1 to build odilia?

our CI doesn't build nightly as far as I know

Fixed by a recent commit.

Debian, Ubuntu

We already depended on features less than 6 months old. This is only marginally different, and it's one feature.

keep unmerged until it lands in stable

We are not production software and the difference between using a temporarily unstable feature will not be the difference between us and beung "production ready" in the next 6 months. It compiles, passes linting, and works.


[AUTO-CHERRYPICK] moby-engine: add back-compat symlink for docker-proxy - branch main

This is an auto-generated pull request to cherry-pick commit 5d85e6179451960dc3dafb0bb78e7e56fb0f3a3a to main. Original PR: #8978

Superseded by https://github.com/microsoft/azurelinux/pull/9002


superscript and subscript not working

Hi,
how to do this with showdown?
I use to do write for example : 1^st^ to put "st" upper
and H~2~0  to put 2 lower from the baseline

nevermind
using sup and sub tags :P


line128 in spectral_library.py: UnboundLocalError-local-variable-'predictions'-referenced-before-assignment

PR Checklist

[x] This comment contains a description of changes (with reason)
[ ] Referenced issue is linked
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] Documentation in docs is updated

Description of changes

Technical details

Additional context

line128_UnboundLocalError-local-variable-'predictions'-referenced-before-assignment

@WassimG Can you say sth. about this? This problem originates from having a failed connection to the server. This is improperly caught by the except block and will definitily lead to people complaining that they get a weird exception, i.e. variable referenced before assignment. I would go with sth. like @qussai96 has proposed here but clean up the code.


feat(builder): add (set) value method

this allows for builder patterns where the value is, or is not, set
mock.set_cookie("NAME", |b| b.value("VALUE").path("/"));

Please remove all changes with respect to formatting. I'll take a look as soon as that's removed.

Ah, sorry, thanks for the quick check, I should have noticed
I have taken the liberty of adding a settings file for VS Code which will stop this happening again, should people have auto format switched on - is that ok?
Ant


Document using string for class when defining a factory

If factory_bot definitions get loaded before the relevant model gets defined (see https://github.com/thoughtbot/factory_bot_rails/pull/264) the factory definition will raise a NameError: uninitialized constant:
factory :access_token, class: Doorkeeper::AccessToken

But using a string or symbol works fine, since we don't try to constantize it until later, when actually running the factory (https://github.com/thoughtbot/factory_bot/blob/master/lib/factory_bot/factory.rb#L22):
factory :access_token, class: "Doorkeeper::AccessToken"

I don't believe we have clear documentation about using a string or symbol for the class.

Also related to #1130


Error runnig picrust due to cannot import name '_convert_node_to_root_polytomy'

i am trying to run the Chemrein tutorial mention in the picrust page but when i try to exectue this cmd:
place_seqs.py -s seqs.fna -o out.tre -p 1 --intermediate place_working -t sepp --verbose
i got this error message:
hmmalign --trim --dna --mapali /home/kalai/miniconda3/envs/picrust2/lib/python3.8/site-packages/picrust2/default_files/prokaryotic/pro_ref/pro_ref.fna --informat FASTA -o place_working/query_align.stockholm /home/kalai/miniconda3/envs/picrust2/lib/python3.8/site-packages/picrust2/default_files/prokaryotic/pro_ref/pro_ref.hmm seqs.fna
All raw input sequences were the same length (400)
run_sepp.py --tree /home/kalai/miniconda3/envs/picrust2/lib/python3.8/site-packages/picrust2/default_files/prokaryotic/pro_ref/pro_ref.tre --raxml /home/kalai/miniconda3/envs/picrust2/lib/python3.8/site-packages/picrust2/default_files/prokaryotic/pro_ref/pro_ref.raxml_info --cpu 1 --molecule dna --outdir place_working/sepp_out -seed 297834 --alignment /home/kalai/miniconda3/envs/picrust2/lib/python3.8/site-packages/picrust2/default_files/prokaryotic/pro_ref/pro_ref.fna --fragment place_working/study_seqs_filtered.fasta
Error running this command:
run_sepp.py --tree /home/kalai/miniconda3/envs/picrust2/lib/python3.8/site-packages/picrust2/default_files/prokaryotic/pro_ref/pro_ref.tre --raxml /home/kalai/miniconda3/envs/picrust2/lib/python3.8/site-packages/picrust2/default_files/prokaryotic/pro_ref/pro_ref.raxml_info --cpu 1 --molecule dna --outdir place_working/sepp_out -seed 297834 --alignment /home/kalai/miniconda3/envs/picrust2/lib/python3.8/site-packages/picrust2/default_files/prokaryotic/pro_ref/pro_ref.fna --fragment place_working/study_seqs_filtered.fasta
Standard error of the above failed command:
Traceback (most recent call last):
File "/home/kalai/miniconda3/envs/picrust2/bin/run_sepp.py", line 3, in
from sepp.exhaustive import ExhaustiveAlgorithm
File "/home/kalai/miniconda3/envs/picrust2/lib/python3.8/site-packages/sepp/exhaustive.py", line 6, in
from sepp.algorithm import AbstractAlgorithm
File "/home/kalai/miniconda3/envs/picrust2/lib/python3.8/site-packages/sepp/algorithm.py", line 11, in
from sepp.tree import PhylogeneticTree
File "/home/kalai/miniconda3/envs/picrust2/lib/python3.8/site-packages/sepp/tree.py", line 25, in
from dendropy.datamodel.treemodel import _convert_node_to_root_polytomy as
ImportError: cannot import name '_convert_node_to_root_polytomy' from 'dendropy.datamodel.treemodel' (/home/kalai/miniconda3/envs/picrust2/lib/python3.8/site-packages/dendropy/datamodel/treemodel/init.py)
so i searched for sultion and tried this refference
downgrading from dendropy 4.6.1 to dendropy 4.5.2. however i ran into another problem, this time there is no error message available
place_seqs.py -s seqs.fna -o out.tre -p 1 --intermediate place_working -t sepp --verbose
hmmalign --trim --dna --mapali /home/kalai/miniconda3/envs/picrust2/lib/python3.8/site-packages/picrust2/default_files/prokaryotic/pro_ref/pro_ref.fna --informat FASTA -o place_working/query_align.stockholm /home/kalai/miniconda3/envs/picrust2/lib/python3.8/site-packages/picrust2/default_files/prokaryotic/pro_ref/pro_ref.hmm seqs.fna
All raw input sequences were the same length (400)
run_sepp.py --tree /home/kalai/miniconda3/envs/picrust2/lib/python3.8/site-packages/picrust2/default_files/prokaryotic/pro_ref/pro_ref.tre --raxml /home/kalai/miniconda3/envs/picrust2/lib/python3.8/site-packages/picrust2/default_files/prokaryotic/pro_ref/pro_ref.raxml_info --cpu 1 --molecule dna --outdir place_working/sepp_out -seed 297834 --alignment /home/kalai/miniconda3/envs/picrust2/lib/python3.8/site-packages/picrust2/default_files/prokaryotic/pro_ref/pro_ref.fna --fragment place_working/study_seqs_filtered.fasta
Error running this command:
run_sepp.py --tree /home/kalai/miniconda3/envs/picrust2/lib/python3.8/site-packages/picrust2/default_files/prokaryotic/pro_ref/pro_ref.tre --raxml /home/kalai/miniconda3/envs/picrust2/lib/python3.8/site-packages/picrust2/default_files/prokaryotic/pro_ref/pro_ref.raxml_info --cpu 1 --molecule dna --outdir place_working/sepp_out -seed 297834 --alignment /home/kalai/miniconda3/envs/picrust2/lib/python3.8/site-packages/picrust2/default_files/prokaryotic/pro_ref/pro_ref.fna --fragment place_working/study_seqs_filtered.fasta
Standard error of the above failed command:
[16:11:42] config.py (line 349):     INFO: Seed number: 297834
[16:11:42] algorithm.py (line 258):     INFO: Reading input alignment: <_io.TextIOWrapper name='/home/kalai/miniconda3/envs/picrust2/lib/python3.8/site-packages/picrust2/default_files/prokaryotic/pro_ref/pro_ref.fna' mode='r' encoding='UTF-8'>
[16:11:42] algorithm.py (line 265):     INFO: Reading input tree: <_io.TextIOWrapper name='/home/kalai/miniconda3/envs/picrust2/lib/python3.8/site-packages/picrust2/default_files/prokaryotic/pro_ref/pro_ref.tre' mode='r' encoding='UTF-8'>
[16:11:43] algorithm.py (line 238):     INFO: Decomposition Sizes are set to alignment: 2000 placement: 2000
[16:11:44] exhaustive.py (line 350):     INFO: Breaking into 16 placement subsets.
[16:11:45] exhaustive.py (line 397):     INFO: Breaking into 16 alignment subsets.
[16:11:45] filemgr.py (line 129):     INFO: Root temp directory built: /tmp/sepp/output.5zp54_ek
[16:11:45] exhaustive.py (line 412):     INFO: Breaking each alignment subset into 1 fragment chunks.
[16:11:45] jobs.py (line 131):     INFO: Finished hmmbuild Job with input: /tmp/sepp/output.5zp54_ek/root/P_0/A_0_0/hmmbuild.input.qd_oab9r.fasta
[16:11:46] jobs.py (line 131):     INFO: Finished hmmbuild Job with input: /tmp/sepp/output.5zp54_ek/root/P_1/A_1_0/hmmbuild.input.33m76xuy.fasta
[16:11:46] jobs.py (line 131):     INFO: Finished hmmbuild Job with input: /tmp/sepp/output.5zp54_ek/root/P_2/A_2_0/hmmbuild.input.zlgaaphn.fasta
[16:11:46] jobs.py (line 131):     INFO: Finished hmmbuild Job with input: /tmp/sepp/output.5zp54_ek/root/P_3/A_3_0/hmmbuild.input.pb_wxr37.fasta
[16:11:46] jobs.py (line 131):     INFO: Finished hmmbuild Job with input: /tmp/sepp/output.5zp54_ek/root/P_4/A_4_0/hmmbuild.input.j0ce8n_m.fasta
[16:11:46] jobs.py (line 131):     INFO: Finished hmmbuild Job with input: /tmp/sepp/output.5zp54_ek/root/P_5/A_5_0/hmmbuild.input.w5pa_r6c.fasta
[16:11:47] jobs.py (line 131):     INFO: Finished hmmbuild Job with input: /tmp/sepp/output.5zp54_ek/root/P_6/A_6_0/hmmbuild.input.ccuwc_4l.fasta
[16:11:47] jobs.py (line 131):     INFO: Finished hmmbuild Job with input: /tmp/sepp/output.5zp54_ek/root/P_7/A_7_0/hmmbuild.input.et31sokx.fasta
[16:11:47] jobs.py (line 131):     INFO: Finished hmmbuild Job with input: /tmp/sepp/output.5zp54_ek/root/P_8/A_8_0/hmmbuild.input.8nskshma.fasta
[16:11:47] jobs.py (line 131):     INFO: Finished hmmbuild Job with input: /tmp/sepp/output.5zp54_ek/root/P_9/A_9_0/hmmbuild.input.x_cq5crr.fasta
[16:11:47] jobs.py (line 131):     INFO: Finished hmmbuild Job with input: /tmp/sepp/output.5zp54_ek/root/P_10/A_10_0/hmmbuild.input.du6sjb38.fasta
[16:11:48] jobs.py (line 131):     INFO: Finished hmmbuild Job with input: /tmp/sepp/output.5zp54_ek/root/P_11/A_11_0/hmmbuild.input.ftjmdsuf.fasta
[16:11:48] jobs.py (line 131):     INFO: Finished hmmbuild Job with input: /tmp/sepp/output.5zp54_ek/root/P_12/A_12_0/hmmbuild.input.oi52ui6s.fasta
[16:11:48] jobs.py (line 131):     INFO: Finished hmmbuild Job with input: /tmp/sepp/output.5zp54_ek/root/P_13/A_13_0/hmmbuild.input.v8hrxy8h.fasta
[16:11:48] jobs.py (line 131):     INFO: Finished hmmbuild Job with input: /tmp/sepp/output.5zp54_ek/root/P_14/A_14_0/hmmbuild.input.ea23t3y.fasta
[16:11:48] jobs.py (line 131):     INFO: Finished hmmbuild Job with input: /tmp/sepp/output.5zp54_ek/root/P_15/A_15_0/hmmbuild.input.hk4b2_o0.fasta
[16:11:49] jobs.py (line 131):     INFO: Finished hmmsearch Job with input: model:/tmp/sepp/output.5zp54_ek/root/P_0/A_0_0/hmmbuild.model.71f500qb, fragments:/tmp/sepp/output.5zp54_ek/fragment_chunks/fragment_chunk_0unem3r_q.fasta, elim:99999999, filter:False, output:/tmp/sepp/output.5zp54_ek/root/P_0/A_0_0/FC_0_0_0/hmmsearch.results.7waoyjh
[16:11:49] jobs.py (line 131):     INFO: Finished hmmsearch Job with input: model:/tmp/sepp/output.5zp54_ek/root/P_1/A_1_0/hmmbuild.model.wzw4lmo2, fragments:/tmp/sepp/output.5zp54_ek/fragment_chunks/fragment_chunk_0unem3r_q.fasta, elim:99999999, filter:False, output:/tmp/sepp/output.5zp54_ek/root/P_1/A_1_0/FC_1_0_0/hmmsearch.results.01q6znzq
[16:11:49] jobs.py (line 131):     INFO: Finished hmmsearch Job with input: model:/tmp/sepp/output.5zp54_ek/root/P_2/A_2_0/hmmbuild.model.ok1sl_y9, fragments:/tmp/sepp/output.5zp54_ek/fragment_chunks/fragment_chunk_0unem3r_q.fasta, elim:99999999, filter:False, output:/tmp/sepp/output.5zp54_ek/root/P_2/A_2_0/FC_2_0_0/hmmsearch.results.h0ghdk3h
[16:11:49] jobs.py (line 131):     INFO: Finished hmmsearch Job with input: model:/tmp/sepp/output.5zp54_ek/root/P_3/A_3_0/hmmbuild.model.8w9tvipw, fragments:/tmp/sepp/output.5zp54_ek/fragment_chunks/fragment_chunk_0unem3r_q.fasta, elim:99999999, filter:False, output:/tmp/sepp/output.5zp54_ek/root/P_3/A_3_0/FC_3_0_0/hmmsearch.results.gv9x3lrj
[16:11:50] jobs.py (line 131):     INFO: Finished hmmsearch Job with input: model:/tmp/sepp/output.5zp54_ek/root/P_4/A_4_0/hmmbuild.model.1ew_o6qs, fragments:/tmp/sepp/output.5zp54_ek/fragment_chunks/fragment_chunk_0unem3r_q.fasta, elim:99999999, filter:False, output:/tmp/sepp/output.5zp54_ek/root/P_4/A_4_0/FC_4_0_0/hmmsearch.results.wpcb9nm0
[16:11:50] jobs.py (line 131):     INFO: Finished hmmsearch Job with input: model:/tmp/sepp/output.5zp54_ek/root/P_5/A_5_0/hmmbuild.model.sosd_1kr, fragments:/tmp/sepp/output.5zp54_ek/fragment_chunks/fragment_chunk_0unem3r_q.fasta, elim:99999999, filter:False, output:/tmp/sepp/output.5zp54_ek/root/P_5/A_5_0/FC_5_0_0/hmmsearch.results.jb4kdr54
[16:11:50] jobs.py (line 131):     INFO: Finished hmmsearch Job with input: model:/tmp/sepp/output.5zp54_ek/root/P_6/A_6_0/hmmbuild.model.dnv2q60j, fragments:/tmp/sepp/output.5zp54_ek/fragment_chunks/fragment_chunk_0unem3r_q.fasta, elim:99999999, filter:False, output:/tmp/sepp/output.5zp54_ek/root/P_6/A_6_0/FC_6_0_0/hmmsearch.results.se00ps9s
[16:11:50] jobs.py (line 131):     INFO: Finished hmmsearch Job with input: model:/tmp/sepp/output.5zp54_ek/root/P_7/A_7_0/hmmbuild.model.tq_yuqag, fragments:/tmp/sepp/output.5zp54_ek/fragment_chunks/fragment_chunk_0unem3r_q.fasta, elim:99999999, filter:False, output:/tmp/sepp/output.5zp54_ek/root/P_7/A_7_0/FC_7_0_0/hmmsearch.results.l4kc_05t
[16:11:50] jobs.py (line 131):     INFO: Finished hmmsearch Job with input: model:/tmp/sepp/output.5zp54_ek/root/P_8/A_8_0/hmmbuild.model.zliai6va, fragments:/tmp/sepp/output.5zp54_ek/fragment_chunks/fragment_chunk_0unem3r_q.fasta, elim:99999999, filter:False, output:/tmp/sepp/output.5zp54_ek/root/P_8/A_8_0/FC_8_0_0/hmmsearch.results.siviiht5
[16:11:51] jobs.py (line 131):     INFO: Finished hmmsearch Job with input: model:/tmp/sepp/output.5zp54_ek/root/P_9/A_9_0/hmmbuild.model.01bh3z82, fragments:/tmp/sepp/output.5zp54_ek/fragment_chunks/fragment_chunk_0unem3r_q.fasta, elim:99999999, filter:False, output:/tmp/sepp/output.5zp54_ek/root/P_9/A_9_0/FC_9_0_0/hmmsearch.results.4e27dyl9
[16:11:51] jobs.py (line 131):     INFO: Finished hmmsearch Job with input: model:/tmp/sepp/output.5zp54_ek/root/P_10/A_10_0/hmmbuild.model.5n0l3t0m, fragments:/tmp/sepp/output.5zp54_ek/fragment_chunks/fragment_chunk_0unem3r_q.fasta, elim:99999999, filter:False, output:/tmp/sepp/output.5zp54_ek/root/P_10/A_10_0/FC_10_0_0/hmmsearch.results.ia8pdxxt
[16:11:51] jobs.py (line 131):     INFO: Finished hmmsearch Job with input: model:/tmp/sepp/output.5zp54_ek/root/P_11/A_11_0/hmmbuild.model.as8c4e4t, fragments:/tmp/sepp/output.5zp54_ek/fragment_chunks/fragment_chunk_0unem3r_q.fasta, elim:99999999, filter:False, output:/tmp/sepp/output.5zp54_ek/root/P_11/A_11_0/FC_11_0_0/hmmsearch.results.yp_r0tit
[16:11:51] jobs.py (line 131):     INFO: Finished hmmsearch Job with input: model:/tmp/sepp/output.5zp54_ek/root/P_12/A_12_0/hmmbuild.model.ypbtml4t, fragments:/tmp/sepp/output.5zp54_ek/fragment_chunks/fragment_chunk_0unem3r_q.fasta, elim:99999999, filter:False, output:/tmp/sepp/output.5zp54_ek/root/P_12/A_12_0/FC_12_0_0/hmmsearch.results.6ww00o0w
[16:11:52] jobs.py (line 131):     INFO: Finished hmmsearch Job with input: model:/tmp/sepp/output.5zp54_ek/root/P_13/A_13_0/hmmbuild.model.n1pney03, fragments:/tmp/sepp/output.5zp54_ek/fragment_chunks/fragment_chunk_0unem3r_q.fasta, elim:99999999, filter:False, output:/tmp/sepp/output.5zp54_ek/root/P_13/A_13_0/FC_13_0_0/hmmsearch.results.wsbee_hc
[16:11:52] jobs.py (line 131):     INFO: Finished hmmsearch Job with input: model:/tmp/sepp/output.5zp54_ek/root/P_14/A_14_0/hmmbuild.model.fz7lb1xy, fragments:/tmp/sepp/output.5zp54_ek/fragment_chunks/fragment_chunk_0unem3r_q.fasta, elim:99999999, filter:False, output:/tmp/sepp/output.5zp54_ek/root/P_14/A_14_0/FC_14_0_0/hmmsearch.results.zyas34vo
[16:11:52] jobs.py (line 131):     INFO: Finished hmmsearch Job with input: model:/tmp/sepp/output.5zp54_ek/root/P_15/A_15_0/hmmbuild.model.al95m5tf, fragments:/tmp/sepp/output.5zp54_ek/fragment_chunks/fragment_chunk_0unem3r_q.fasta, elim:99999999, filter:False, output:/tmp/sepp/output.5zp54_ek/root/P_15/A_15_0/FC_15_0_0/hmmsearch.results.dbivdrul
[16:11:52] exhaustive.py (line 80):  WARNING: Fragments [] are not scored against any subset
[16:11:52] exhaustive.py (line 151):     INFO: Merging sub-alignments for placement problem : P_0.
[16:11:52] exhaustive.py (line 151):     INFO: Merging sub-alignments for placement problem : P_1.
[16:11:52] exhaustive.py (line 151):     INFO: Merging sub-alignments for placement problem : P_2.
[16:11:52] exhaustive.py (line 151):     INFO: Merging sub-alignments for placement problem : P_3.
[16:11:52] jobs.py (line 131):     INFO: Finished hmmalign Job with input: model:/tmp/sepp/output.5zp54_ek/root/P_9/A_9_0/hmmbuild.model.01bh3z82, fragments:/tmp/sepp/output.5zp54_ek/root/P_9/A_9_0/FC_9_0_0/hmmalign.frag.waqxz2k4.fasta, trim:False, base_alignment:/tmp/sepp/output.5zp54_ek/root/P_9/A_9_0/hmmbuild.input.x_cq5crr.fasta
[16:11:52] exhaustive.py (line 151):     INFO: Merging sub-alignments for placement problem : P_4.
[16:11:52] exhaustive.py (line 151):     INFO: Merging sub-alignments for placement problem : P_5.
[16:11:52] exhaustive.py (line 151):     INFO: Merging sub-alignments for placement problem : P_6.
[16:11:52] jobs.py (line 131):     INFO: Finished hmmalign Job with input: model:/tmp/sepp/output.5zp54_ek/root/P_11/A_11_0/hmmbuild.model.as8c4e4t, fragments:/tmp/sepp/output.5zp54_ek/root/P_11/A_11_0/FC_11_0_0/hmmalign.frag.t48txjup.fasta, trim:False, base_alignment:/tmp/sepp/output.5zp54_ek/root/P_11/A_11_0/hmmbuild.input.ftjmdsuf.fasta
[16:11:52] exhaustive.py (line 151):     INFO: Merging sub-alignments for placement problem : P_7.
[16:11:52] exhaustive.py (line 151):     INFO: Merging sub-alignments for placement problem : P_8.
[16:11:52] exhaustive.py (line 151):     INFO: Merging sub-alignments for placement problem : P_9.
[16:11:52] alignment.py (line 556):     INFO: Merging extension sto file (/tmp/sepp/output.5zp54_ek/root/P_9/A_9_0/FC_9_0_0/hmmalign.results.fj5lyusc) into base alignment (/tmp/sepp/output.5zp54_ek/root/P_9/A_9_0/hmmbuild.input.x_cq5crr.fasta).
[16:11:52] exhaustive.py (line 151):     INFO: Merging sub-alignments for placement problem : P_10.
[16:11:52] exhaustive.py (line 151):     INFO: Merging sub-alignments for placement problem : P_11.
[16:11:52] alignment.py (line 556):     INFO: Merging extension sto file (/tmp/sepp/output.5zp54_ek/root/P_11/A_11_0/FC_11_0_0/hmmalign.results.t87rlwqa) into base alignment (/tmp/sepp/output.5zp54_ek/root/P_11/A_11_0/hmmbuild.input.ftjmdsuf.fasta).
[16:11:53] jobs.py (line 131):     INFO: Finished hmmalign Job with input: model:/tmp/sepp/output.5zp54_ek/root/P_12/A_12_0/hmmbuild.model.ypbtml4t, fragments:/tmp/sepp/output.5zp54_ek/root/P_12/A_12_0/FC_12_0_0/hmmalign.frag.to9810fg.fasta, trim:False, base_alignment:/tmp/sepp/output.5zp54_ek/root/P_12/A_12_0/hmmbuild.input.oi52ui6s.fasta
[16:11:53] exhaustive.py (line 151):     INFO: Merging sub-alignments for placement problem : P_12.
[16:11:53] alignment.py (line 556):     INFO: Merging extension sto file (/tmp/sepp/output.5zp54_ek/root/P_12/A_12_0/FC_12_0_0/hmmalign.results.yoopqhla) into base alignment (/tmp/sepp/output.5zp54_ek/root/P_12/A_12_0/hmmbuild.input.oi52ui6s.fasta).
[16:11:53] jobs.py (line 131):     INFO: Finished hmmalign Job with input: model:/tmp/sepp/output.5zp54_ek/root/P_13/A_13_0/hmmbuild.model.n1pney03, fragments:/tmp/sepp/output.5zp54_ek/root/P_13/A_13_0/FC_13_0_0/hmmalign.frag.8nh16bh5.fasta, trim:False, base_alignment:/tmp/sepp/output.5zp54_ek/root/P_13/A_13_0/hmmbuild.input.v8hrxy8h.fasta
[16:11:53] exhaustive.py (line 151):     INFO: Merging sub-alignments for placement problem : P_13.
[16:11:53] alignment.py (line 556):     INFO: Merging extension sto file (/tmp/sepp/output.5zp54_ek/root/P_13/A_13_0/FC_13_0_0/hmmalign.results.dzt7ffpb) into base alignment (/tmp/sepp/output.5zp54_ek/root/P_13/A_13_0/hmmbuild.input.v8hrxy8h.fasta).
[16:11:53] exhaustive.py (line 151):     INFO: Merging sub-alignments for placement problem : P_14.
[16:11:53] exhaustive.py (line 151):     INFO: Merging sub-alignments for placement problem : P_15.
multiprocessing.pool.RemoteTraceback:
"""
Traceback (most recent call last):
File "/home/kalai/miniconda3/envs/picrust2/lib/python3.8/multiprocessing/pool.py", line 125, in worker
result = (True, func(*args, **kwds))
File "/home/kalai/miniconda3/envs/picrust2/lib/python3.8/site-packages/sepp/scheduler.py", line 74, in call
return self.run()
File "/home/kalai/miniconda3/envs/picrust2/lib/python3.8/site-packages/sepp/jobs.py", line 150, in run
raise JobError("\n".join([
sepp.scheduler.JobError: The following execution failed:
/home/kalai/miniconda3/envs/picrust2/bin/pplacer --out-dir /tmp/sepp/output.5zp54_ek/root/P_9 -j 1 -r /tmp/sepp/output.5zp54_ek/root/P_9/pplacer.backbone.iudu1qy8.fasta -s /home/kalai/miniconda3/envs/picrust2/lib/python3.8/site-packages/picrust2/default_files/prokaryotic/pro_ref/pro_ref.raxml_info -t /tmp/sepp/output.5zp54_ek/root/P_9/pplacer.tree.lo8ki89o.tre --groups 10 /tmp/sepp/output.5zp54_ek/root/P_9/pplacer.extended.0.sscnv87n.fasta
No error messages available
"""
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/home/kalai/miniconda3/envs/picrust2/bin/run_sepp.py", line 26, in
ExhaustiveAlgorithm().run()
File "/home/kalai/miniconda3/envs/picrust2/lib/python3.8/site-packages/sepp/algorithm.py", line 174, in run
if (not JobPool().wait_for_all_jobs()):
File "/home/kalai/miniconda3/envs/picrust2/lib/python3.8/site-packages/sepp/scheduler.py", line 365, in wait_for_all_jobs
result.get()
File "/home/kalai/miniconda3/envs/picrust2/lib/python3.8/multiprocessing/pool.py", line 771, in get
raise self._value
sepp.scheduler.JobError: The following execution failed:
/home/kalai/miniconda3/envs/picrust2/bin/pplacer --out-dir /tmp/sepp/output.5zp54_ek/root/P_9 -j 1 -r /tmp/sepp/output.5zp54_ek/root/P_9/pplacer.backbone.iudu1qy8.fasta -s /home/kalai/miniconda3/envs/picrust2/lib/python3.8/site-packages/picrust2/default_files/prokaryotic/pro_ref/pro_ref.raxml_info -t /tmp/sepp/output.5zp54_ek/root/P_9/pplacer.tree.lo8ki89o.tre --groups 10 /tmp/sepp/output.5zp54_ek/root/P_9/pplacer.extended.0.sscnv87n.fasta
No error messages available

Hi @Zathzk
Could you try running this a second time and see if you're able to reproduce the error? With multiprocessing, there are a broader range of factors that make it possible for errors to occur transiently.
Have you tried opening an issue on the sepp issue tracker? Given that you already repinned DendroPy for sepp compatibility and the error message does not have attribution it seems more likely to be an issue with sepp itself then DendroPy.
Let me know what you think.

Closing this as inactive. Happy to reopen if still an issue


⚠ Samsung has degraded performance

In afcafd3, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2736 ms

Resolved: Samsung performance has improved in c70ac98.


SMPL & Rendering Error

The following error occurred during SMPL & Rendering.
Tested in a Linux Docker container environment.
Could you help me? please.

Try this if using Ubuntu
apt-get install libglfw3-dev libgles2-mesa-dev


How to use dataclasses in Codon

Hi there -- could you provide some examples of how to use dataclasses in Codon? I checked the documentation, but didn't find any. My apologies if I missed them.
It's not clear to me if I should do from dataclasses import dataclass, not use a decorator, or use the @dataclass decorator even though it's not explicitly imported.

Hi @matthew-parrott
Just use @dataclass without the import. Note that all classes in Codon are Python dataclasses. Some dynamic features, however, are not yet supported.


Oracle WebLogic Domain 12.2.1 with ORDS configured and deployed on the AdminServer

Image based on oracle/weblogic:12.2.1-developer. It creates a "Basic Server Domain" with the Oracle REST Data Services configured and deployed on the AdminServer.
The database used for this example is <IP_ADDRESS>.0 standard edition.
The README.md provides instructions on how to run and verify this image.
Signed-off-by: Luis Rodriguez Fernandez<EMAIL_ADDRESS>

@gvenzl how this one compares to the upcoming ORDS image?

You are right, @brunoborges, from the point of view of the functionality (expose REST services from Oracle DB) it does not make any difference from the OracleRestDataServices . However, for us (CERN), an image like this is useful to debug.

Thanks for clarifying that @lurodrig. My conclusion is that while this is a great image for CERN's use, I am concerned that we will not be able to maintain two Dockerfiles with the same purpose.
If you decide to maintain thta Dockerfile on GitHub, we will be happy to link to it from our README.

Thanks @brunoborges! Sure, it makes sense: please feel free to add https://github.com/cerndb/oracle-weblogic-1221-domain-ords-autodeploy to your README.


Update sdk according to the Open API  20230104's version

Open API has been updated in 20230104. https://docs.pingcap.com/tidbcloud/api/v1beta#section/API-Changelog
I download the newest swagger and generated the go SDK again. The key change of the SDK is:

support modify the node_size of a dedicated cluster

PTAL @c4pt0r

Thank you!


Direct integration with no extension

This is such a great product. Thank you!
I would be interested to implement in LiveCodes direct integration without the need to install the extension like the recently announced integration with CodeSandbox. https://github.com/Exafunction/codeium-chrome/issues/9#issuecomment-1823434399
Can you please guide?
Thank you

For first party integrations you can email your request to<EMAIL_ADDRESS>and we can consider it on a case by case basis.


Updated sender blocking action

Sender block leads to quarantine instead of SCL:9

@Dansimp could you please merge this PR?


Fix README and create a operator.yaml

Update readme and operator deployment.yaml

/cc @sjenning

/retest


Telemetry complete Training  Event does not calculate the actual training time correctly at random

Model Builder Version:
Visual Studio Version

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

select scenario
select data
Upload data
select train tab
6 set train time
7.click start training button

Expected behavior
Screenshots

System Information (please complete the following information):
Additional context
Add any other context about the problem here.

Please fill out the bug template (add more details, repro steps, and a GIF or images to this bug)

@briacht   could you confirm what is really actual training duration mean, is that the duration from process start to stop ? or to the end of traning time

Currently the time to generate the Visual Studio project is not included in the time.
Most runtimes should be longer than 10 seconds (aim at ~150 model created). Hence I wouldn't be worried about the missing six seconds.

It would be from when the user selects "Start training" to when the Evaluate screen is available to them

I think  this is what the current one is working, from user selects start training till evaluate tab is activated   . @JakeRadMSFT   what is your feedback?

By design


Unable to retrieve input data

Description of bug
I'm trying to get written data from my Input, but It doesn't return me anything. It looks like everything is right, but It doesn't return the expected data.
To Reproduce
You can check my code at Expo Snack: https://snack.expo.io/nokjkxDeo
Expected behavior
The Input component must return the received data from the user. But instead of it, I made a rule to return an Alert() with a message when it doesn't return the expected data.
Environment:
Windows 10/Android
Additional context
Screenshots
Input file

Entry file

React Native 0.62 reimplemented the ref on TextInput, so we need to store the input value manually inside the ref. I will update the docs soon, but for now i have a working example:
import React, {
  useEffect,
  useRef,
  useState,
  useCallback,
} from 'react';

import { TextInput } from 'react-native';
import { useField } from '@unform/core';

function Input({ name, icon, style, ...rest }) {
  const inputRef = useRef(null);

  const { fieldName, registerField, defaultValue, error } = useField(name);

  useEffect(() => {
    inputRef.current.value = defaultValue;
  }, [defaultValue]);

  useEffect(() => {
    registerField({
      name: fieldName,
      ref: inputRef.current,
      path: 'value',
      clearValue(ref) {
        ref.value = '';
        ref.clear();
      },
      setValue(ref, value) {
        ref.setNativeProps({ text: value });
        inputRef.current.value = value;
      },
      getValue(ref) {
        return ref.value;
      },
    });
  }, [fieldName, registerField]);

  return (
    <TextInput
      ref={inputRef}
      keyboardAppearance="dark"
      defaultValue={defaultValue}
      placeholderTextColor="#666360"
      onChangeText={value => {
        if (inputRef.current) {
          inputRef.current.value = value;
        }
      }}
      {...rest}
    />
  );
};

export default Input;


Uptime Kuma show blank screen

⚠ Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

📝 Describe your problem
UptimeKuma did not show anything just plain blank screen from dashboard and status. Reinstall uptimekuma wont help since setup also shown blank. How could I fixed this?
🐻 Uptime-Kuma Version
1.10.2
💻 Operating System and Arch
Debian 11
🌐 Browser
Google Chrome 96.0.4664.45
🐋 Docker Version
20.10.9
🟩 NodeJS Version
No response

Are you using a reverse proxy?
If yes, search "reverse proxy" in this repo.
Otherwise, you may need to provide more info that show how you set up it.


Needed firebase integration

Hi,
I checked this starter app is really cool and i am new to react native. In this app really helpful for me to learn react native. I already worked on ionic framework in firebase integration is really simple but in react native redux strcture i can't figure out firebase integration. If you integrate firebase, then it would be really helpful for me. I can sure about that lot of them looking best way of integrating firebase into react native because out there to find a way to efficient integration of firebase in react native redux is not a simple task.
I am really looking for you guys. Thanks for the app.

Thanks @neosekar
I don't have any plans on switching this boilerplate to Firebase. In saying that, it still provides all the tools necessary to do a fairly simple switch to Firebase (or any other API for that matter).
From a quick Google, I found this article which will help to get you going.


Skipping builds (for markdown changes) prevents submission

I merged #168 to disable Build and Test checks for changes that only affect markdown files.
That's fine, but it's running afoul of our branch protection rules that require a passing result from Build and Test in order to merge a change:

Since the build gets skipped it never succeeds, which prevents the submission of markdown-only changes like #170.
This specific issue is covered in this FAQ: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/troubleshooting-required-status-checks#handling-skipped-but-required-checks where the recommended solution is to create a dummy check that only runs on skipped files and emits success: "fix this by creating a generic workflow, with the same name, that will return true in any case"

Thanks for getting this all buttoned up @CodingCanuck!
I have one request and one suggestion.
Request: can we add a comment into each nobuild.yml that explains that the name of the job has to be "Build and Test", e.g., this line, since it must match the GitHub branch protection rule? That seems like a nasty little penguin that would be good to document for posterity. In fact, I think adding a link to the FAQ at the top of each nobuild.yml would also be helpful explaining why we're creating a "dummy".
Suggestion: I can see putting nobuild.yml into 3rdparty/dev-tools so that it can be shared across repos. Want to add a GitHub issue in 3rdparty/dev-tools? I think we've also thought about moving macos.yml, ubuntu.yml, etc, into 3rdparty/dev-tools and making sure all of our repos have a bazel build :build and a bazel test :test so that we can have generic workflows.

Addressing both items in https://github.com/3rdparty/dev-tools/pull/20, but if we want to reject that PR then I can send out a bunch of individual PRS to address your request.

This will be rendered obsolete by https://github.com/3rdparty/eventuals/pull/309 which removes our build-skipping logic (similar changes in other repos: https://github.com/reboot-dev/respect/pull/294 and https://github.com/3rdparty/stout/pull/25 )

I think that all of our build-skipping logic has been removed: closing this out.


add REN & SNX assets and information to TomoChain

you cannot update verifylist.json

you cannot update verifylist.json


DASHBUILDE-36: BS3 Upgrade fine tunning & bug fixing

Boolean Switch Editor - Refactor for using Toggle Switch BS3 (extras) component
File Upload Editor - fixings for BS3 upgrade
Data Set Editor

Refactor to BS3 grid system
Review tooltips (visibility and texts)
Columns and filter widgets fixings
Refactored disclosure panel for columns/filter panel
Column type updates reload the data set with new given column types (bug fixing)
Block an empty columns selection, at least one column must be selected

Data Set Explorer

Some fixings and BS3 refactor upgrades

Metric displayer

Visualization fixings

New dashboard - Fixed bug for new perspective's menu entires (not visible)
Displayer Editor

Refactor to BS3 grid system
Bug fixings

Clean unused constants in dashbuilder-widgets

Timeframe function: combo year out of panel, month combo small, the text should not be trimmed.

Expense reports=>Columns=>click en type selector arrow (column amount)=>layout gets crazy.
Can also be reproduced just by zooming out using  "Ctrl+mouse central wheel"

CSV data set creation, click on upload icon without specifying a file. The loading icon never stops.

Same as before with a file selected from local. UI shows error in file field and the "c:\fakepath..." filename is shown as well.

If columns names are large enough then overlap among them. This belongs to UFext table component, so we should file a JIRA there plus a JIRA in dashbuilder with t alink to the first one to keep track.

Advanced tab

Zoom out=>layout turns into a bad state. I guess is due to BS3 layout system. It doesn't look well anyway.
Orange color OFF? I'm not sure, white text on grey background may be?

Left panel, too much empty space. Previous impl was 220 px wifth. We need to figure out how to remove such empty space. The popup height is not fixed which causes the height to change depending on the popup content. Not sure if this looks well, I liked more the fixed height approach.

Both point 4 and 5 are reported as JIRA in UF. See:

https://issues.jboss.org/browse/UF-222
https://issues.jboss.org/browse/UF-223

Working on the other issues. Will update the PR when finished. Thx

All issues have been fixed. Try again please.

Reviewed & merged on master.
Great job Roger!


[CI] Notification to "update mesheryctl Command Tracker spreadsheet" if PRs and Issues are tagged with "component/mesheryctl"

Current Behavior

Pull Requests and Issues related to mesheryctl are tagged with the "component/mesheryctl" label.
The mesheryctl Command Tracker spreadsheet tracks the progress of the mesheryctl commands and contributors are sometimes unaware of updating it.
Desired Behavior

An automated action that comments on the PR and Issue tagging the user to update the mesheryctl Command Tracker spreadsheet.
Reference:

Meshery Build & Release Strategy

@navendu-pottekkat I would like to take up this.

Sure @muskankhedia

@muskankhedia Any updates on this issue?

@navendu-pottekkat Yes, I am working on it.

@navendu-pottekkat if suppose this issue is open, can I take up this?

@muskankhedia if you are working on anything else, @alphaX86 can take it up.

@alphaX86 I am on it. Can you please take up some other issues?

@muskankhedia just checking on activity actually, don't worry I won't take it 😂. Oh and here's a tip, for this issue, you need to look the file named label-commenter-config.yml and make the changes

@navendu-pottekkat since this issue is open for long time, I will fix this

@alphaX86 I am already looking into this issue. Can you please take up some other issues?

(Sigh) alright but make sure it's being fixed

Your PR seems good. I was looking for an option to automate the task to update in the spreadsheet but yes informing contributors also works.

Oh ok I thought it's this way... If it's such the case, then this issue is all yours then to work on 👍

It's completely fine. I guess I over estimated the issue.


toolbox outputs

Currently we make all our toolboxes inherit from one of the derived types of medToolBox because they have a getOutput function or similar, whereas medToolBox does not. Without this, we have no way of directly getting the output of some toolboxes (like reformat) in the pipelines. An alternative is to take the output from the view, like we do for cropping.
I suggest we clean this up a bit and make the dependencies more logical. This means that for toolboxes that should not naturally inherit from medSegmentationAbstractToolBox, medFilteringAbstractToolBox etc., we make them inherit directly from medToolBox like before, and use the alternative method.

Does the current refactoring meets your expectations on this ?

No, the current refactoring does not address this problem.

Really?
If I take the example of Cropping, it's now a medSelectableToolBox which has its getOutput() method.
Or maybe I don't understand.

I looked at the wrong code, so yes it has been addressed.


fix: login link in the navbar

Changes proposed

Fix login link in the navbar.

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Screenshots
I don't think this applies here.
Note to reviewers
None.

There doesn't seem to be an issue associated with this PR? On this occasion we will review without an issue being opened.
In future, to ensure we have consistency and to help with the smooth running of the project could you please raise an issue and wait for the necessary steps as reflected in the Contributing Guide.


create separate server / network config structs

NetworkConfig contains information describing the helper network as a whole. The intent is that this can be the same on all three servers. ServerConfig is for a single server and has information unique to the local server (e.g. where to find private keys).
Fix use of kernel-selected free ports for tests (#508).
Removed specification of identities when creating a Processor. The association of helper identites 1/2/3 with discovery information is established in NetworkConfig.

merging as I want to get #532 and #522 in. No critical feedback here, we can push separate PRs if we need


[jvm-packages] Update jackson-databind to 2.12.6

Continue #7773, to address a security advisory.
https://github.com/advisories/GHSA-57j2-w4cx-62h2
@trivialfis @wbo4958

I will check the build issue.

Ah, the dependency has been removed entirely, my bad.


Port over new endpoint to support optimal indexing

A new endpoint has been created that will be used by the Search API to speed up indexing times. See relevant commit: https://github.com/hubmapconsortium/entity-api/commit/e824932e6dd33684bcc2977102e72a0124988387
*Note: This has not been implemented by the Search API yet on HM

This is not fully complete on the HuBMAP side yet. Waiting for them to merge into main.

Zhou mentioned these changes might not be needed in SenNet. This is to specifically address a problem in HuBMAP.

With the amount of entities currently in SenNet (and growing) we will need it sooner rather than later

Related to card https://github.com/sennetconsortium/search-api/issues/192 we should add an additional modification to our Entity API to specify if a property should exist on the ancestors/descendants of an entity. In the Search API issue linked above we want pipeline_message to exist on the dataset but it is not necessary when the dataset is listed under ancestors or descendants.
@libpitt


nessie system test fails on GCS

time="2021-01-26T19:36:49Z" level=warning msg="Failed to delete multipart upload part while compose" func="block/gs.(*Adapter).composeMultipartUploadParts.func1" file="build/block/gs/adapter.go:464" bucket=nessie-system-testing error="googleapi: Error 403: Object 'nessie-system-testing/2481-rocks/testmultipartupload/006079c429d543949cfe7788cf4fc739.part_00002' is subject to bucket's retention policy and cannot be deleted, overwritten or archived until 2021-02-05T11:36:47.70576-08:00, forbidden" parts="[2481-

I think I need to fix a retention policy :-)  Which means something else on GS than it does elsewhere (the "G" stands for "Google").

Retention policy
Prevents the deletion or modification of the bucket's objects for a specified minimum period of time after they're uploaded. The optional step of locking a retention policy ensures that no one (including you) can shorten or remove the retention period. Learn more
Retention period    10 days
Effective date    September 7, 2020 at 4:44:10 PM GMT+3
Lock status    Unlocked
Tip: You can save on storage costs by adding a complementary lifecycle rule to delete objects when they reach the end of their retention period.

I think I need to fix a retention policy :-)  Which means something else on GS than it does elsewhere (the "G" stands for "Google").

Retention policy
Prevents the deletion or modification of the bucket's objects for a specified minimum period of time after they're uploaded. The optional step of locking a retention policy ensures that no one (including you) can shorten or remove the retention period. Learn more
Retention period    10 days
Effective date    September 7, 2020 at 4:44:10 PM GMT+3
Lock status    Unlocked
Tip: You can save on storage costs by adding a complementary lifecycle rule to delete objects when they reach the end of their retention period.

Done!
Later on we should create a more accurate policy, presumably the intent was to delete objects after 10 days.  That's a "lifecycle policy" (the "cyc" stands for "psych").

Done!
Later on we should create a more accurate policy, presumably the intent was to delete objects after 10 days.  That's a "lifecycle policy" (the "cyc" stands for "psych").

And added a lifecycle rule to delete after 20 days:

Action | Object condition |   |   |
-- | -- | -- | -- | --
Delete object | 20+ days since object was updated

And added a lifecycle rule to delete after 20 days:

Action | Object condition |   |   |
-- | -- | -- | -- | --
Delete object | 20+ days since object was updated

https://github.com/treeverse/lakeFS/runs/1772008843?check_suite_focus=true passed, looks like the above fixed it. :-)

https://github.com/treeverse/lakeFS/runs/1772008843?check_suite_focus=true passed, looks like the above fixed it. :-)

@itaiad200 can you review the above makes sense?

@itaiad200 can you review the above makes sense?

Every thing makes sense, perhaps except why did it start failing now?

Every thing makes sense, perhaps except why did it start failing now?


Line 1272/1274, algorithms.jl gives type of Array{Any} leading to garbage Image while saving

Need to use convert(Array{Colors.base_colorant_type(eltype(img)){dtype}}, img)

Same in Line 1319.

@timholy This seems to be occurring in many places. Wherever I am using [convert(type) for x in img] it creates an array of type Any instead of type. Is this meant to happen or is this a bug?

Again, it occurs in line 1321. Doesnt occur in Line 1302 though.

This is the thing I mentioned about "type instability" due to your use of a dtype string to encode type information. Julia needs to know the type of a comprehension in order to allocate the correct type.
If you don't mind, I'll just rewrite that code to illustrate how to solve this problem; you can then follow that pattern in future work. OK? I'll post it as a PR and you can comment on it and make me make it better, just like I do for yours :stuck_out_tongue: .
Also a nice github trick: click on the source file you want to refer to, press the 'y' key on your keyboard, then select the line(s) you want to describe, then copy the URL up in the location bar of your browser. Then paste in the lines like this. (You can see what I did by clicking on the "pencil" icon for this comment, it will show you the raw ASCII.)
The reason for hitting 'y' is that it will include the commit SHA in the URL, and thus is a "permalink" to that particular line. If you don't do that, it will always refer to whatever is the current master, and that's very likely to get out of sync.

Oh, wait, I see that #505 seems like the right way to fix it, so let's go with that.

@timholy This seems to be occurring in many places. Wherever I am using [convert(type) for x in img] it creates an array of type Any instead of type. Is this meant to happen or is this a bug?

It's type-instability. Use @code_warntype on your functions and look for red. Once you eliminate the red, then you won't have that problem anymore.


Add support for passing context.Context

Please add support for passing context.Context to database funcs to allow cancellation of long running queries.

what would be the use-case for this? As a SQL builder, I'm currently passing context through the usual chain... HTTP, GraphQL handlers, etc... rather than the builder itself.
I'm new to this lib, so genuinely curious where you might find a need for context, so I can understand what some of the current limitations might be.

When calling Exec without Context, the call chain will hang until the database connection is allowed to execute the query, even if the client cancels context. This can clog the database with waiting processes.

wouldn't it just be a case of checking that Context hasn't been canceled before running Exec?

That would be okay, but after you call (sql.DB*).Exec the process can enter several states such as waiting for a table lock (the most common). Sometimes, if the table is locked by another process then your query may wait for an extended period of time. Often times this is longer than the client has anticipated. Once the client has canceled then the DB transaction should exit as well. Right now, if the client cancels the database will continue to wait until the query is able to execute. If you have many connections in and out then database will get backed up with queries that clients have already disconnected from.

gotcha, that makes sense. Thanks for the explanation @blockloop.

We are starting to investigate adding Context support. Today we use goqu to generate the sql and sqlx (with context) to actually execute the query. It would be far cleaner to just use goqu for the execution part as well. We have been protected by context in the past when users introduce new data that isn't yet performant. Our queries will stop executing after a defined time limit. Not allowing these queries to run effectively forever prevents the app from slowing to a crawl or exhausting memory.

Opened #64 which adds context support.

Can this issue be closed with the release of 5.0.0 which includes context support?


[Spark] Add type widening tests for data skipping

Description
Adds test covering stats and data skipping when a type change is applied to a Delta table.
Covers:

A combination of disabling/enabling storing JSON stats in checkpoint files and the impact on data skipping.
Parsed partition values stored as part of the checkpoint file when the type of the partition column is changed.

How was this patch tested?
See above.

Do we have any tests for OptimizeMetadataOnlyDeltaQuery + Type Widening? If not, do you think we need it?
https://github.com/delta-io/delta/blob/master/spark/src/main/scala/org/apache/spark/sql/delta/perf/OptimizeMetadataOnlyDeltaQuery.scala


Implement our own spatial lookup data structure

#12 introduced aabb_quadtree as a mechanism for doing lookups based on location (i.e. "which items are within 5mm of P?"), but its API doesn't really line up with how we'd like to use it.
At some point in time we should implement our own quadtree (or N-tree or whatever).
This issue can be used as a list of useful links for implementation, and a wish list based on arcs' needs.

I really like some of the algorithms explored in A dive into spatial search algorithms
By far one of the most common operations is to ask "which points are within X distance from P?" and get a sorted iterator which yields the closest points objects first.
I'm imagining an API somewhat like this:
/// A `Space` maps from a `BoundingBox` to some type, `K`.
struct Space<K> { ... }

impl<K> Space<K> {
  fn insert(&mut self, key: K, bounds: BoundingBox) { ... }

  /// Does a spatial lookup based purely on the `BoundingBox` inserted with the key, `K`.
  fn query_unsorted(
    &self,
    location: Point,
    maximum_distance: f64) -> impl Iterator<Item = &K> + '_ { ... }
}

impl Space<Entity> {
    /// Finds all the items within `maximum_distance` of `location`, with the items
    /// closest to `location` being yielded first.
    ///
    /// The `closest_point` callback is used to invoke the `ClosestPoint` algorithm
    /// and find the closest point between an `Entity` and `location`.
    fn query_sorted<F>(
        &self,
        location: Point,
        maximum_distance: f64,
        closest_point: F,
    ) -> impl Iterator<Item = &K> + '_
    where
        F: Fn(Entity, Point) -> Closest,
    {
      ...
    }
}


Simple Angular/BFF sample

Just basic login/logout/show user session for Angular using the MS Angular template as a starting point.

I believe this pull request that was closed actually had this completed....I'm not the author of this, but it fully worked when I tested it... the author is @marleypowell
https://github.com/marleypowell/DuendeSamples/tree/marley/angular-sample/IdentityServer/v6/BFF/AngularBffSample

See: #63

Yes - thanks for that!
But as we said earlier - the reality of today's software industry is that we cannot take responsibility of code originating outside of our organization. That's why we need our own sample.

That makes sense, thanks for adding one 🙂


error: command '/usr/bin/gcc' failed with exit code 1

Hi, I get this error when I try to install pyzmq 17.1.2 (I need this specific version)
...
/Library/Frameworks/Python.framework/Versions/3.9/include/python3.9/pyport.h:508:54: note: expanded from macro 'Py_DEPRECATED'
#define Py_DEPRECATED(VERSION_UNUSED) attribute((deprecated))
^
12 warnings and 1 error generated.
error: command '/usr/bin/gcc' failed with exit code 1
My system:
macos Catalina 10.15.7
python 3.9.7 in newly created virtualenv
pip 21.3.1
zeromq 4.3.4 installed with brew
when I do pip install pyzmq==17.1.2 in virtualenv, it fails. Any suggestions please?

From the changelog, compatibility with Python 3.9 was added in 19.0.2. So the only officially supported options are to upgrade pyzmq or downgrade Python to mutually compatible versions.
You can try checking out the source for 17.1.2 and regenerating the Cython sources with more recent Cython (python setup.py cython && pip install -vv .), but I'm not sure if that will be enough.
Can I ask why you are required to pin-down pyzmq to a version from 2018, but also need to use a version of Python itself from 2020, which can't reasonably be supported by extension packages from before it came out? Partially pinned environments are a recipe for incompatibility.


Add emr-6.15.0 release

Issue #, if available:
Description of changes:
Update support to emr-6.15.0 release
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tested end to end for emr-6.15.0:
Amazon EMR on EKS - Custom Image CLI
Version: 1.06
... Checking if docker cli is installed
... Checking Image Manifest
[INFO] Image ID: e3c6ac0839ccfe22f207e829089bacb9de0f90b63d3c5f3d285fc7af966ec17c
[INFO] Created On: 2024-01-09T05:43:08.645625466Z
[INFO] Default User Set to hadoop:hadoop : PASS
[INFO] Working Directory Set to /home/hadoop : PASS
[INFO] Entrypoint Set to /usr/bin/entrypoint.sh : PASS
[INFO] JAVA_HOME is set with value: /etc/alternatives/jre : PASS
[INFO] SPARK_HOME is set with value: /usr/lib/spark : PASS
[INFO] File Structure Test for spark-jars-6-12 in /usr/lib/spark/jars: PASS
[INFO] File Structure Test for spark-jars-6-13 in /usr/lib/spark/jars: PASS
[INFO] File Structure Test for spark-jars-6-15 in /usr/lib/spark/jars: PASS
[INFO] File Structure Test for hadoop-jars-6-15 in /usr/lib/hadoop/lib: PASS
[ERROR] hadoop-openstack MUST be in /usr/lib/hadoop : FAIL
... Start Running Sample Spark Job
[INFO] File Structure Test for hadoop-files-6-15 in /usr/lib/hadoop: PASS
[INFO] Sample Spark Job Test with local:///usr/lib/spark/examples/jars/spark-examples.jar : PASS
-----------------------------------------------------------------
Custom Image Validation Failed. Please see individual test results above for detailed information.
-----------------------------------------------------------------

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bkahloon Please review, many thanks.

@amazon-auto @zhuyulin27
Please review, many thanks.