Large number of transient memory allocations during Eager test run

Just run an analysis of 1M Eager run to see malloc profile - can see a number of nice multiples of 1M small allocations, adding this issue as a placeholder for digging into if some could be eliminated (even though it is just transient allocations, they seems to be the root cause holding back performance).
Attaching screenshot from run.

Retaining the capacity of the caches in the generated code made a noticeable improvement and improved encoding performance a further 25%.
12562 ms encode --> 10072 ms encode
I just manually made the following change in clearCaches throughout, but would need to be fixed in the codegen:
	static func clearCaches(){
		cache.removeAll(keepCapacity: true)
		inProgress.removeAll(keepCapacity: true)
		deferedBindings.removeAll(keepCapacity: true)
	}

keepCapacity is a good catch.
I thought that the caches will make encoding slower, I implemented them for #14
Right now I create them for every table. I will implement an analyser in the code generator so it is only generated for tables which are actually recursive. E.g. the bench should have no caching because there are no recursive definitions.
Hm I just realised that I also should clear objectPool as it affects repeated reading.

The other issue with statics are thread safety of the caches... It'd be nice to be able to encode/decode in multiple threads in parallel.

I think parallelisation of encoding is not useful, because buffer writing to buffer is the main bottleneck and can be done only in serial manner, as we need to now the current cursor value. But if you have multiple object graphs you need to encode this can totally be done on multiple threads. Same for decoding. I already thought about that the key of the caches has to be tuple of offset and the objectId of reader/builder. This way it is still not thread safe but you can have parallelisation for distinguished graphs even if they use same tables. What do you think?

I was thinking about parallelization of independent object graphs only. The current code would not allow for threading as the type property (static) caches would not be thread safe (would need to synchronize over a dispatch queue for those). It would probably be better to move the caches to the respective builder/reader object to avoid the need for synchronization instead (and adjust the keys as needed) and be clear that a given object graph can only be serialized/deserialized form a single thread (which makes sense).

Hm, I will meditate on that :)

(or drop the statics completely... I don't know exactly how much improvement they bring though.)

They are not for performance optimisation but for being able to recreate a graph. For example in my find city project I have table with two arrays. those arrays reference the same objects. If we don't have objectPool we would duplicated every entry on eager decoding. As a matter of fact if you would convert this flat buffer to a JSON all entries would be double, as JSON is a tree. FlatBuffers lets us serialise real object graphs because everything is reference based. cache, inProgress, deferedBindings where introduced to being able to encode a cyclical graph. For example:
table Friend {
	name : string;
	friends : [Friend];
	father : Friend;
	mother : Friend;
}
root_type Friend;

Than we can do something like:
let f1 = Friend()
f1.name = "Maxim"

let f2 = Friend()
f2.name = "Joakim"

f1.friends = [f2]
f2.friends = [f1]

f1.toByteArray

This would not be possible without deferedBindings because when we encode f1, we see that we have to encode f2 first, but when we encode f2, we see that we need to encode f1 first.  The inProgress set tells us that f1 is already in progress so encode f2 and put 0 as a reference for now. Than when everything is done in performLateBindings we can fill the 0 references with real offsets.
This feature is actually not even possible in the original flatc as far as I know, however I fill like it is a very powerful one and it reflects how amazing FlatBuffers is. :)
I guess we could put the caches in the reader and builder, I remember why I didn't do it in the first place. Because reader and builder have no idea about the types, but I guess we could use AnyObject and cast it in the table classes.

Could just define a protocol and type the caches on that instead of AnyObject?

Yeah we could have a ghost protocol Table

Pushed the new code generator which does not add all the recursion overhead if table definitions are not recursive. Also removed static fields, they are on the builder and reader now. I guess this issue can be closed than.

It still does try to access the pools from the non-recursive benchmark and there are code generated like:
public extension Foo {
	private static func create(reader : FlatBufferReader, objectOffset : Offset?) -> Foo? {
		guard let objectOffset = objectOffset else {
			return nil
		}
-->		if let o = reader.objectPool[objectOffset]{
			return o as? Foo
		}
		let _result = Foo()
-->		reader.objectPool[objectOffset] = _result
		_result.id = reader.get(objectOffset, propertyIndex: 0, defaultValue: 0)
		_result.count = reader.get(objectOffset, propertyIndex: 1, defaultValue: 0)
		_result.prefix = reader.get(objectOffset, propertyIndex: 2, defaultValue: 0)
		_result.length = reader.get(objectOffset, propertyIndex: 3, defaultValue: 0)
		return _result
	}
}

Also, as I link with the library, that code can't actually access the properties as they are in a different module, created https://github.com/mzaks/FlatBuffersSwift/pull/26 to fix that.

(on a side note just FYI - running with the code generated inline rather than linking with the framework lets the optimizer do its magic - encoding becomes almost 2x faster...)

Also:
public extension Foo {
	private func addToByteArray(builder : FlatBufferBuilder) -> Offset {
-->		if let myOffset = builder.cache[ObjectIdentifier(self)] {
			return myOffset
		}
		try! builder.openObject(4)
		try! builder.addPropertyToOpenObject(3, value : length, defaultValue : 0)
		try! builder.addPropertyToOpenObject(2, value : prefix, defaultValue : 0)
		try! builder.addPropertyToOpenObject(1, value : count, defaultValue : 0)
		try! builder.addPropertyToOpenObject(0, value : id, defaultValue : 0)
		let myOffset =  try! builder.closeObject()
-->		builder.cache[ObjectIdentifier(self)] = myOffset
		return myOffset
	}
}

I tried manually removing them just to see what the cache overhead was, quite significant:
Eager run
=================================
8605 ms encode
6966 ms decode
1037 ms use
1504 ms dealloc
9507 ms decode+use+dealloc
=================================

—>

=================================
6239 ms encode
4282 ms decode
994 ms use
1449 ms dealloc
6725 ms decode+use+dealloc
=================================

Roughly 64M instead of 38M allocations. Did a test run removing the "stringCache", which removed 4M allocations and improved eager decoding performance ~30% (4447->3038) - did you see better results by adding it initially?

stringCache wa always slowing down the performance tests, I even removed it for some time. It slows it down because with randomly generated string you always have cache misses. With real world scenario however it helped and made the size of the resulting binary much smaller. I think it was about 25% less. Repeating strings is a very common thing in real world scenarios. This cache makes sure that you encode the string once and everyone reference only this one string.
builder.cache serves the same purpose but for tables. If you have same table referred from different places, this table will be encoded only once. This is also why I kept it, it is very important for directed cyclic graph, but also for directed acyclic graph, as you can have one node referenced from multiple other nodes. And again in performance test we end up with only cache misses.
So I gutes it is time for the ConfigObject. It will have all the caches turned on per default, but user can turn it off when s/he knows that they are doing more harm than good in a special use case. It will also contain the initial capacity. However I am not sure if I will be able to work on it today. Let's see.

Ok, but in this benchmark the strings used are not randomly generated, there are only two constant strings, so then likely something is not working as expected?
I guess I am primarily focusing on simple object graphs without cross references, so tuning it in a config would be good enough for practical purposes.
One concern with the config object though is that the reader/builder instance variables still causes 10M allocations just by their existence (tried removing them as well, gave a nice speedup of 10%).
Thinking about it, wouldn't it make sense to be able to reset builder/readers and reuse them instead? Then we could live with a small amount of instances of those and it would essentially be a non-issue with those variables.

And the configs are in, give it a try. I set uniqueStrings to false in you can try to turn them on. I also saw that the builder was lacking the stringCache which was a dumb mistake.

Ok, will give it a spin - what do you think about trying to reuse builers/readers ?

Using the string cache shifted time from decode to build as expected, but overall nice option I think:
String cache OFF:
Lazy run
=================================
7295 ms encode
386 ms decode
5246 ms use
1013 ms dealloc
6645 ms decode+use+dealloc
=================================

Eager run
=================================
7515 ms encode
3667 ms decode
1176 ms use
1675 ms dealloc
6518 ms decode+use+dealloc
=================================

String cache turned ON:
Lazy run
=================================
8194 ms encode
364 ms decode
4701 ms use
1108 ms dealloc
6173 ms decode+use+dealloc
=================================

Eager run
=================================
8121 ms encode
3209 ms decode
1047 ms use
1335 ms dealloc
5591 ms decode+use+dealloc
=================================

FYI, I just did hack in a reuse of the reader (manually added):
    public static func fromReader(r : FlatBufferReader) -> FooBarContainer {
        let reader = r
        let objectOffset = reader.rootObjectOffset
        return create(reader, objectOffset : objectOffset)!
    }

and just manually reset the buffer pointer between runs as a prototype (should have a nice reset method of course), which gave a significant boost really:
Eager run
=================================
7576 ms encode
3299 ms decode
1029 ms use
1468 ms dealloc
5796 ms decode+use+dealloc
=================================

—>

Eager run
=================================
8040 ms encode
1207 ms decode
1089 ms use
1200 ms dealloc
3496 ms decode+use+dealloc
=================================

Decode time was cut to 1/3 or so :)

Tried the same for builders, reduced total allocations down to 40M (down from 60+) and gave a similar boost on encode performance:
Eager run
=================================
5377 ms encode
1112 ms decode
998 ms use
1095 ms dealloc
3205 ms decode+use+dealloc
=================================

So seems worthwhile to consider to allow reusing builders/readers. 40M allocations is also much more reasonable vs the workload.

Interesting!
I thought that builder and reader reuse is not significant in real life scenario, but this is the FrontEnd developer in me talking :)
If a BackEnd has to consume and produce slightly different buffers this is indeed useful.
#17 goes kind of in the same direction, but it is much more limited because there it is only possible to exchange scalar values, and there is also a complication with default values btw.
#13 should also speed up encoding, but on cost of nice API.
I created a new issue :) #27

In my experience (mostly doing backend stuff) every allocation counts - really why I added this issue to be able to ensure that the foundation is doing a reasonable job there so it can be used on the backend side (as a bonus it would work nicer on mobile devices also :) ).
Looking at the test run, there is an object graph of 10 objects with 2 strings and one vector (13 objects total), so ~13+13M=26M allocations as a floor for the test run would not be unreasonable - if reusing the reader/builder (#27) we have a surplus of ~14M unaccounted for which still would be nice to sort out if possible. I would hope that building/reading performance could come close to the reference C++ implementation and while the gap is closing, there is bit to go.
#17 was created with the idea that the backend store could be kept around for Lazy access, perhaps that would clash with the idea of reuse somewhat.
Not sure how #13 would look like, but I do like the current API (modulo #27 ;-)
I think the major question is - do one have a transient object graph, or a persisted one that is updated and sent repeatedly - I can see uses for both for different scenarios that are useful.

See https://github.com/mzaks/FlatBuffersSwift/issues/28 for one more cheap win.

And one more in https://github.com/mzaks/FlatBuffersSwift/pull/29

It seems one major issue is the withUnsafePointer closure in public func put(value : T), not sure what could be done there though.

That seems to have been a red herring, it seems to be the vtable vectors in the builder that is the major culprit. Lets close this case and I'll open separate ones when nailing down concrete suggestions.


Having multiple portals (3-4+) in FOV causes significant drop in framerate.

I have a hallway lined with doors (8 of which are portals) and a connector portal (1) to extend the length of the hallway. When I'm looking a just one or no portal(s), framerate is around 60 fps. When looking at 3 the framerate drops to about 40 fps. Looking down the hallway at all 9 portals causes a noticeable drop to 30 fps. Portal density also seems to affect framerate slightly.
(Hallway in question for reference)

The text shows that it's rendering 10 portals. Portal-in-portal is also accounted for.


Add ColorPicker control

I have not added alpha channel and I don't think it's necessary (but it can be implemented simply through current structure). It uses shader to provided the best performance but may exist some potential logic defects.

Thanks for the pull. I'll soon check it out. I need to finish other stuff first.


Database ResponseTime not data

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ ] Question or discussion
[x] Bug
[ ] Requirement
[ ] Feature or performance improvement

Bug

Which version of SkyWalking, OS and JRE?
docker-6.6-es7

What happen?
If possible, provide a way for reproducing the error. e.g. demo application, component version.
Database ResponseTime and not data in ui. but Database SLA and Database TopN Records have data

I'm in the same situation
Which version of SkyWalking, OS and JRE?
docker-6.6-es7
What happen?
Database ResponseTime and not data in ui.


Forecasting/modelling notebook

Proposed changes
Proposing to add a vegetation forecasting/modelling notebook to the Real_world_examples folder, ported over from DE Africa repo.
In draft form until this issue is resolved

Hey @cbur24! Just checking on on this one - was this previously blocked by issues with the NCI environment?

@robbibt This PR was in draft form as the Sandbox image needed to be updated due a conflict between scipy and statsmodel.
I've rerun the notebook and can confirm it works now.   I'll label it as ready-for-review and leave it up to DEA team to decide if its something they want in the repo.

@uchchwhash @robbibt
Thanks guys. I had a look at this notebook again last week during some down time which is why I pushed the re-merge with develop. I'll implement the changes requested next time I've got an hour or two free.

Hey @cbur24, would love to merge this - I'm happy to write up a sentence or two for the intro if you're busy - I just wanted to add a tiny bit extra to emphasise the importance/usefulness of the use case. 🙂


Update dependecies.

maybe install @greenkeeper for this project?

bithound marks it as OUTDATED but as I linked in the second commit there is a potential bug with tslint 5.0.0.
Greenkeeper looks as a good addition to the DevOps.

From Travis-CI Status:

Investigating - We're investigating build delays affecting all public repositories running at travis-ci.org.
Apr 3, 17:12 UTC

Shall we wait for it?

Mandatory. It's a Required task.

travis is back in service.


Docs request: clarify how to change the configuration file for a given linter

I'm not seeing clearly laid out in the documentation how I should go about tweaking the global lint rules for a given linter (say to have yamllint ignore document-start globally or use a different default line-length)?

Can you override global configuration per git repo?

@olivierlefloch hey, sorry for not answer this earlier.
For pretty every single linter, all you have to do is following the linter's configuration. In this case (yamllint), you need to create a .yamllint.yml or .yamllint.yml file at the project's root directory.


Add Portfolio Value and Available Funds

we should consider using "frozen funds"....this will make it easier for a user to track their trading success....For example a user starts with 50k worth of dai....Market 1 they escrow $4200, market 2 they escrow $3550, market 3 they escrow $2200....currently we would show them having an eth balance of 40050....say they made $50 profit on market 2 after it resolved and claimed proceeds...we currently show them having a balance of $43650(the user doesnt really know if they are up or down $ by seeing this number).........If we showed a Portfolio Balance and available trading funds instead the user would see $50050 for Portfolio Balance and $43650 for Available Funds....makes it a lot more clear that they user is up money from their starting balance.

This was closed by PR and that automation didn't catch it.


Admin can add multiple signups for the same Instructor at the same workshop

An Instructor can only sign up to help at a workshop once. However, an admin can add more signups for that same Instructor. This has potential to create confusion if the states are changed for both signups.
Trying to confirm both causes a database error (#2449), but accepting one and declining the other means different emails will be sent and different status will be shown to the Instructor depending on the order of those actions.
The correct action would be to delete the duplicate, but we should make it harder to run into this problem in the first place.

Thanks for catching this @elichad. I agree that the fix should be to prevent the admin from creating duplicate signups.

Some other questions/notes:

In addition to different emails being sent out if the admin accepts one and declines the other, what happens to the instructor task that gets created?
Can an admin create a signup if the Instructor has already created their own signup? If so, this should be prevented as well.
If the signup was created by the admin and not the instructor, can we have some way of indicating that in the view?

If the signup was created by the admin and not the instructor, can we have some way of indicating that in the view?

Eli: Not sure if we track who creates the signup.  Could have admin add this to notes (but relies on the human)

Eli: This should be relatively easy to do, with a unique constraint or a check when signup is created.


Roll engine e54bc4ea1832..00d7069677dd (7 commits)

https://github.com/flutter/engine/compare/e54bc4ea1832...00d7069677dd
git log e54bc4ea1832..00d7069677dd --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-10<EMAIL_ADDRESS>Roll src/third_party/skia 6ed63968a391..a9660ec89bc7 (14 commits) (flutter/engine#5993)
2018-08-10<EMAIL_ADDRESS>Reference platform_strong.dill, not platform.dill (flutter/engine#5992)
2018-08-10<EMAIL_ADDRESS>Update to FreeType 2.9.1 (flutter/engine#5991)
2018-08-10<EMAIL_ADDRESS>Roll src/third_party/skia 5b5d84cc1f37..6ed63968a391 (4 commits) (flutter/engine#5989)
2018-08-10<EMAIL_ADDRESS>Roll src/third_party/skia 0d5d0659a684..5b5d84cc1f37 (39 commits) (flutter/engine#5988)
2018-08-10<EMAIL_ADDRESS>Roll Dart to version be6309690fd60284a87f3258a740c7c30efb1092 (flutter/engine#5987)
2018-08-09<EMAIL_ADDRESS>Roll Dart to version 1be785ae2ddb1754a184cd638ab719e94d86b4e9 (flutter/engine#5985)
The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

@rmistry @liyuqian : New roll has been created by https://flutter-engine-flutter-roll.skia.org

Trybots failed. These were the failed builds: https://flutter-dashboard.appspot.com/build.html

Commit queue failed; closing this roll.


Clean unregistered featured from registration requests

For some reasons, if the server sends a capability registration batch to the client and one feature is not registered on the client, all registration after it in the list won't be registered (see https://github.com/microsoft/vscode-languageserver-node/blob/a6f0d22d2c6842337ad135c13d2f945e53b1a6e4/client/src/common/client.ts#L1741)
Do you have a better idea?

The only other way is to create a PR on the vscode-languageserver-node itself, I'll try to have a look :+1:


Setting password in every transaction - node.js

Description
Using node.js binding i would like to see it possible to ask the wallet password for every transaction the user try to do and get the OK or NOT OK to proceed with the transaction based on the input accuracy.
Motivation
The node.js binding as it is now doesn't allow the developer to assert the password input after a successful attempt since once the correct password is given the local wallet remains accessible for all transactions. It seems even given a wrong password it's not blocking the transaction to go through.

const manager = new AccountManager({
        storagePath: `${userData}/${walletName}`,
    });

manager.setStrongholdPassword(data.pin);`

Requirements
Write a list of what you want this feature to do.

The node.js library should be able to return a wrong password error even if the correct password was once given in the same session.

Are you planning to do it yourself in a pull request?
No.
I believe this feature is already available in the Rust library but not it the Node.js binding.

Which version of the Node.js binding did you use?

@Thoralf-M it's the 1.0.16

@andreaxe a new version with this included got released to npm

@andreaxe a new version with this included got released to npm

Thanks!

@Thoralf-M thanks!


Dynamic (sync) resolvable added in onEnter hook not available in onSuccess

This is a:

[x] Bug Report
[ ] Feature Request
[ ] General Query

My version of UI-Router is: 1.x
Bug Report
Current Behavior:
http://plnkr.co/edit/u0JKQCIabRCixHJLmBbB?p=preview
See console log. The app errors with:
Error: Resolvable async .get() not complete:"bar"
Expected Behavior:
For bar to be available in the onSuccess hook, just like foo, because it's not async and there is no reason why it should not be available/complete.
Expected behaviour is for it to work, just as it works in the onBefore hook.
(FYI the reason I need it in the onEnter hook is because I'm relying on another global resolvable to create the new resolvable, which is only available in the onEnter hook.)

@christopherthielen this issue is quite a big blocker for us, could you please have a look at what's happening or maybe provide some suggestions for a work around?

In fact, it's also happening in the onBefore hook when browsing away from the state, and then going back to it. The addResolvable is called fine, but then in the subsequent onSuccess the resolvable is not available in the injector.

You can test this by defining the resolvable (sync) and calling the injector on the same transition right after; that shouldn't error right?
const module = {foo: 'bar'};
transition.addResolvable({
      token: 'module',
      resolveFn: () => module,
    });
transition.injector().get('module');

==> Error: Resolvable async .get() not complete:"module"

When using {when: 'EAGER'} policy, the module is available in onSuccess and doesn't error. However, according to https://github.com/angular-ui/ui-router/issues/3060#issuecomment-252124772, LAZY resolves should also be available in onSuccess hooks.

This does look like a bug.  The added resolve should be available in any (currently unentered) child states.  I have a unit test for something similar but it's not catching this scenario.

A few things to note:

You can add a resolvable with pre-resolved data (not async) using the data property:

add pre-resolved values
const module = {foo: 'bar'};
transition.addResolvable({
      token: 'module',
      resolveFn: () => module,
      data: module,
    });
transition.injector().get('module');

The Injector has a getAsync() method which will return a promise for the resolve.

using async/await
    const injector = transition.injector();
    const foo = await injector.getAsync('foo');
    console.log(foo);
    const bar = await injector.getAsync('bar');
    console.log(bar);

using promises
    const injector = transition.injector();
    Promise.all([injector.getAsync('foo'), injector.getAsync('bar')])
      .then(results => { console.log(results[0]); console.log(results[1]) })

Resolves are assumed to be async by default.

by defining the resolvable (sync) and calling the injector on the same transition right after; that shouldn't error right?

You can't do this unless you explicitly provide the data property to create a sync resolvable.

EAGER resolves are fetched when the transition starts.  LAZY resolves are fetched when the state they belong to is entered.

By adding the resolvable in bar's onEnter, there is no further triggers to process the newly added resolvable (all states have been entered already).  This is essentially where the bug lies.  To prove the point, if we added another nested state foo.bar then the resolve is indeed processed and ready in onSuccess (also change the criteria objects from to: 'foo' to entering: 'foo'

Thanks for looking into it and finding the bug, and also for pointing out data instead of resolveFn, I was looking for a simple property like that for sync data but must have missed it.
I've tried to change resolveFn to data in the (plunkr)[http://plnkr.co/edit/u0JKQCIabRCixHJLmBbB?p=preview] but that errors with:

Not sure if this is related to the bug you fixed or not.

Unless I'm expected to use both? But that doesn't make sense to me.

Although it doesn't make much sense, use both.  Maybe we can fix this in a future release.


align-items: flex-start; being removed

I have some css that's run through Autoprefixer (grunt-autoprefixer) then Clean CSS (grunt-contrib-cssmin). align-items: flex-start is being removed from the final minified output.
Original:
.panel--top {
  align-items: flex-start; }

Autoprefixer:
.panel--top {
  -webkit-box-align: start;
  -webkit-align-items: flex-start;
      -ms-flex-align: start;
          align-items: flex-start; }

End result (missing align-items: flex-start):
.panel--top{-webkit-box-align:start;-webkit-align-items:flex-start;-ms-flex-align:start}

Using v3.1.7. Checking back older versions appears that it broke from v3.0.10 to v3.1.0.

@bostondv Thanks for an informative bug report! I guess you have more than one rule with align-items: flex-start, because minifying just this selector works fine:
.panel--top{-webkit-box-align:start;-webkit-align-items:flex-start;-ms-flex-align:start;align-items:flex-start}

You can fix it using restructuring: false switch until it's fixed.

@bostondv Would you be able to share your file after autoprefixer with me? My email is in package.json. I have a fix locally but would prefer not to rush into releasing it before I know if it works or not.

Definitely, will email it to you shortly.
On Mar 17, 2015 4:28 AM, "Jakub Pawlowicz"<EMAIL_ADDRESS>wrote:

@bostondv https://github.com/bostondv Would you be able to share your
file after autoprefixer with me? My email is in package.json. I have a
fix locally but would prefer not to rush into releasing it before I know if
it works or not.
--
Reply to this email directly or view it on GitHub
https://github.com/jakubpawlowicz/clean-css/issues/498#issuecomment-82198648
.

Should be fine in 3.1.8.


Logging with origami.

I was thinking that we can provide origami-lib with a logger functionality which will set up the logger for the demo. So a single method will bootstrap the python logging library which can then be used by demo user.
This will help us when we are deploying demos to our server too, suppose user want to check the logs for his demo the logger will store them in a file which can then be provided to demo owner.
Thoughts on this?
@deshraj @uttu357 @AvaisP @dexter1691  @vpn1997

@fristonio Are you thinking of adding something on the lines of https://github.com/Cloud-CV/origami-daemon/pull/4?

Yeah, mostly like this. This way we can log better logs without needing the user to configure anything.

Yeah sounds good. Also origami-lib should send logs with a certain label to the Origami web application for display to the user of the demo.

Yeah, I have it in the todo list for origami-lib, but the thing is I didn't wanna mangle too much with the code that's already there in the frontend. We can do this easily once we have a basic working app with us.

Sounds good! :+1:


CF Release

Updates
Added

cf-typography: [patch] Automatically add em dash to pull quote citation.

Changed

cf-forms: [patch] Fixed checkbox/radio borders on hover
cf-pagination: [patch] Fixed outdated a-btn__icon-on-left
and a-btn__icon-on-right classes referenced in docs to correct
a-btn_icon__on-left and a-btn_icon__on-right classes.
cf-forms: [patch] Changed label heading from 5 to 4, per design manual.
cf-typography: [patch] Remove bottom margin from m-slug-header.

Removed

cf-core: [minor] Remove IE7 and below support.
cf-buttons: [minor] Remove IE7 and below support.
cf-grid: [minor] Remove IE7 and below support.
cf-layout: [minor] Remove IE7 and below support.
cf-typography: [patch] Remove unused a-heading__padded variables and docs.

Review

@cfpb/front-end-team-admin

I am a bot
After this PR is merged, I will instruct Travis to automagically perform the following steps:

Increment Capital Framework's version per our guidelines.
Add a timestamped entry to the changelog with the new version and its changes.
Tag the release and push it to GitHub.
Publish both capital-framework and any individually updated components to npm.
Update both canary, our development branch, and master, our release branch.

If I do something wrong, blame a human.

🚀


manually copy english content from main repo to chinese repo

Manually overwrote everything in:
-building-scenes/introduction
-building-scenes/mvp-guidelines
-general/glossary
-everything in  marketplace/...
-everything in releases/...
-almost everything in sdk-reference/...   except scene-content-guide
I didn't touch-scene-content-guide because I know that one is translated already, even though what was in the english page is out of date

I also moved the content in building-scenes/sample-scenes to examples/sample-scenes

Added missing images

Added info about new examples section

Added vs settings for auto-format

Added new tracking data

I created this merge so that the content that's not translated yet can at least be up to date. This also includes a couple of pages that didn't yet exist when we forked to the chinese version.
@eordano , @menduz, @abarmat   please merge this branch


Nokogiri update bonnie prior

Update nokogiri due to security vulnerability
move old gem reference to gemspec (commented out because we are pointing at branch now)

[x] ❗ change Gemfile to point to mongoid5 branch for health-data-standards once https://github.com/projectcypress/health-data-standards/pull/591 is merged.

Pull requests into Bonnie Bundler require the following. Submitter and reviewer should :white_check_mark: when done. For items that are not-applicable, note it's not-applicable ("N/A") and :white_check_mark:.
Submitter:

[x] This pull request describes why these changes were made.
[x] This PR is into the correct branch.
[x] JIRA ticket for this PR: https://jira.mitre.org/browse/BONNIE-1620
[x] JIRA ticket links to this PR
[x] Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
[x] Tests are included and test edge cases
[x] Tests have been run locally and pass (remember to update Gemfile when applicable)
[x] Code coverage has not gone down and all code touched or added is covered. NA
[x] Automated regression test(s) pass (N/A bonnie-prior)

Reviewer 1:
Name: @hossenlopp

[ ] Gem version update sanity check

Still needs hqmf2js update after https://github.com/projecttacoma/hqmf2js/pull/56 is merged.


Hotfix pilight switch

Description:
Hotfix
Related issue (if applicable): fixes #4272

Just in time.


BulkSMSBD

App\Http\Controllers\BulkSMSBD not found
Please provide what is need to write in the begining of controller for use Bulksmsbd::send

I'm sorry to say I couldn't update the package. Because I didn't get any help from bulksmsbd.  So I stopped working on this package. However, I think I need to update my package, but since my exam is running, I can't update this package until my exam is over. Until then, I am sorry I couldn't give any support.
I'm sorry for that

Thank you for your response.
I solved the problem comparing other service providers documentation..

If you currently want to use my package.
Use this class at the top of the controller
use iqbalhasandev \ bulksmsbd \ Classes \ BulkSMSBD;
Example:
<?php

namespace App\Http\Controllers;

use Illuminate\Http\Request;
use iqbalhasandev\bulksmsbd\Classes\BulkSMSBD;

class HomeController extends Controller
{
    /**
     * Create a new controller instance.
     *
     * @return void
     */
    public function __construct()
    {
        $this->middleware('auth');
    }

    /**
     * Show the application dashboard.
     *
     * @return \Illuminate\Contracts\Support\Renderable
     */
    public function index()
    {

        $number =<PHONE_NUMBER>8;
        $message = 'this is a demo Example form Laravel bulksmsBD Package.';
        BulkSMSBD::send($number, $message);

        return view('home');
    }
}


Add a header and contacts

Add basic content (avatar, name, job, contacts, intro, etc.)
move the photo


issue is on  latest Version of sdkVersion : 7.4.0   Error Massage in dev mode Screen :- The Dev Mode Session has timed out. Restart the device and turn on the Dev mode again

modelName : 32LQ635BPSA
sdkVersion : 7.4.0
firmwareVersion : 04.40.91
boardType : K8AP_DVB_AJ
otaId : HE_DTV_W22L_AFAAATAA
[Appium] Attempting to find matching driver for automationName 'webos' and platformName 'lgtv'
[Appium] The 'webos' driver was installed and matched caps.
[Appium] Will require it at /Users/ifocus/node_modules/appium-lg-webos-driver
[Appium] Requiring driver at /Users/ifocus/node_modules/appium-lg-webos-driver/index.js
[AppiumDriver@69d1] Appium v2.5.1 creating new WebOSDriver (v0.3.0) session
[AppiumDriver@69d1] Checking BaseDriver versions for Appium and WebOSDriver
[AppiumDriver@69d1] Appium's BaseDriver version is 9.5.2
[AppiumDriver@69d1] WebOSDriver's BaseDriver version is 9.5.2
[WebOSDriver@19f6] Creating session with W3C capabilities: {
[WebOSDriver@19f6]   "alwaysMatch": {
[WebOSDriver@19f6]     "appium:debuggerPort": 9998,
[WebOSDriver@19f6]     "appium:websocketPort": 3000,
[WebOSDriver@19f6]     "appium:websocketPortSecure": 3001,
[WebOSDriver@19f6]     "appium:useSecureWebsocket": false,
[WebOSDriver@19f6]     "appium:autoExtendDevMode": true,
[WebOSDriver@19f6]     "appium:appLaunchCooldown": 3000,
[WebOSDriver@19f6]     "appium:keyCooldown": 750,
[WebOSDriver@19f6]     "appium:rcMode": "rc",
[WebOSDriver@19f6]     "platformName": "lgtv",
[WebOSDriver@19f6]     "appium:automationName": "webos",
[WebOSDriver@19f6]     "appium:deviceName": "LGWEBOS23",
[WebOSDriver@19f6]     "appium:deviceHost": "<IP_ADDRESS>",
[WebOSDriver@19f6]     "appium:appId": "mediacorp.prod",
[WebOSDriver@19f6]     "appium:chromedriverExecutable": "/Users/ifocus/Downloads/chromedriver",
[WebOSDriver@19f6]     "appium:newCommandTimeout": 1440000
[WebOSDriver@19f6]   },
[WebOSDriver@19f6]   "firstMatch": [
[WebOSDriver@19f6]     {}
[WebOSDriver@19f6]   ]
[WebOSDriver@19f6] }
[WebOSDriver@19f6 (bf37603a)] Session created with session id: bf37603a-e12c-4521-92ec-10031f06710f
[WebOSDriver] Extending dev mode on device
[WebOSDriver] Running command: /Applications/webOS_TV_SDK/CLI/bin/ares-extend-dev --device LGWEBOS23
[WebOSDriver] Getting device info
[WebOSDriver] Running command: /Applications/webOS_TV_SDK/CLI/bin/ares-device-info --device LGWEBOS23
[WebOSDriver] Connecting remote; address any prompts on screen now!
[AppiumDriver@69d1] Event 'newSessionStarted' logged at<PHONE_NUMBER>643 (11:20:44 GMT+0530 (India Standard Time))
[AppiumDriver@69d1] Encountered internal error running command: Error: socket hang up
[AppiumDriver@69d1]     at connResetException (node:internal/errors:705:14)
[AppiumDriver@69d1]     at Socket.socketOnEnd (node:_http_client:518:23)
[AppiumDriver@69d1]     at Socket.emit (node:events:525:35)
[AppiumDriver@69d1]     at endReadableNT (node:internal/streams/readable:1358:12)
[AppiumDriver@69d1]     at processTicksAndRejections (node:internal/process/task_queues:83:21)
[HTTP] <-- POST /session 500 1937 ms - 528
but lower version of sdkVersion : 4.10.0 is working

It looks like dev mode timed out? Also, why do you have useSecureWebsocket set to false?

It looks like dev mode timed out? Also, why do you have useSecureWebsocket set to false?

In the development mode, the session has timed out, and there are 997 hours remaining. I have attached a screenshot as well. The useSecureWebsocket capability's default value is false, and we are not passing any capabilities for useSecureWebsocket


Question:

Can I use bw_plex to download theme.mp3 files and store them with the corresponding media files, without using the other functionalities? I would like to do that, to have my Kodi media player pick up the tunes to play when browsing.

You can make a script that does for you, this isn’t something that’s built in.


Full Fledged E-Commerce with most of Functionalities

Title and Issue number

Title : E-commerce Website
Issue No. : #193
Code Stack :
1.) ReactJS
2.) HTML, CSS and JS
3.) Bootstrap 5
4.) API (GET, PUT, POST, PATCH, DELETE)
Close: #193
Video (mandatory)
https://github.com/apu52/METAVERSE/assets/114601400/f9087653-694e-42f6-b34e-722e5f5a6399
Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md
[x] I have updated the projectData.json file for my contribution
[x] I have added the img of my project in the assets/img section
Additional context (Mandatory )

Full Fledged website for Ecommerce.
It is website which gives a good descritption of how a Ecommerce website should look like. It is working website having so many E-commerce facilities like Adding a **Product, Updating a Product, Showing Description of Product, Deleting.
Home Page

Contact Page

Product Page

Client Views

Footer

Are you contributing under any Open-source programme?
CodePeak'23

@singhcoder694  Great project! Thanks for contributing we will try to make this project viewable from the website as this is a complex one.

@5h0ov my pleasure😊😊

@5h0ov my pleasure 😊😊, if you may provide me bonus points for this it would be great of you

@singhcoder694 Really appreciable project. I think your project is correctly reviewed & labeled


Unable to change the Soap Client?

Using the following code results in the default \SoapClient being used, despite an alternative being passed in the constructor.
        $service = new <snip>([
            AbstractSoapClientBase::WSDL_URL => <snip>,
            AbstractSoapClientBase::WSDL_CLASSMAP => ClassMap::get(),
	    AbstractSoapClientBase::DEFAULT_SOAP_CLIENT_CLASS => <snip>::class
        ], true);

I added some additional code to getSoapClientClassName to see if it was being set correctly but it does not seem to be.
[DEBUG] $class is set to \SoapClient
[DEBUG] $soapClientClassName is empty

Do i need to override the class that is extending AbstractSoapClientBase or is there something else that I'm missing?

The best sample I can give you is from the PackageEws365 project which uses its proper SoapClient,
Let me know if it's not sufficient,

Ah! That explains it, thanks :-)


output number of files created

give the user an indication something was done

:-1: I'm lukewarm on this. The unix practise is to be silent on success and loud on failure. If you want to see what's happening there's always the `--verbose

This just puts it more in line with the contrib plugins

This just puts it more in line with the contrib plugins

:(

6 months later and I still think I'm right on this one:

Without some kind of output, it looks like this task failed compared to the other grunt tasks. While the unix way is to be silent, the grunt way is to give some kind of confirmation


Question: What to do when Orchestrator reports an error?

Hello,
I am quite new to Orchestrator and MySQL cluster management.
In my test environment I am noticing this error on the Orchestrator UI.
I am assuming I need to take some action to resolve this error (not replicating)?
However, I am not able to find any documentation indicating what needs to be done here.

This is more of a MySQL thing: your primary, aka master, seems to have replication configuration. If it shouldn't, then you should probably reset slave all on that server, or use orchestrator's reset replication button on the instance dialog. Or, this isn't the primary after all, and the server should be replicating from somewhere? Only you would know, orchestrator just makes you aware.


Implement mobileauth update

@tschbc , your branch is not based on the tip of master. Can you do a git fetch && git rebase master?

@f-w is it fine to use the "Rebase and merge" option in this PR?

@f-w is it fine to use the "Rebase and merge" option in this PR? It looks like it does the same thing without needing to create a new PR.

@tschbc, No need to create a new PR. Just commit the change to branch implement-mobileauth-update.


docs: adding placeholder for future documentation

Coverage remained the same at 93.913% when pulling d0dfe8c3ed9a96ff67653076e9c3a7c1f6672f90 on next into d70eb61abf1ff29fd135e79c2ae89c0f99cb5e28 on master.


[Feature Request] Save score & Money

Save kills,deaths (score) and money of a player if they somehow logged out of the server. (CS:GO Style)
Example Amxx Reapi plugin: https://dev-cs.ru/resources/752/
Pastebin code: https://pastebin.com/24nb5SXA
Makes it possible to recover kills, deaths, and money for a player if they somehow logged out of the server. Data is saved by SteamID and only to the current map.

I will do a match medic to store match status and restore on server crash. Also for players 👍


Incompatible with stemcell range 3541

The 3541 range includes a change to the default umask to be 077. This means that, at least on our old crufty 203.0.0 logsearch, the config file can't be read:
Exception in thread "main" SettingsException[Failed to open stream for url [/var/vcap/packages/elasticsearch/config/elasticsearch.yml]]; nested: AccessDeniedException[/var/vcap/packages/elasticsearch/config/elasticsearch.yml];
Likely root cause: java.nio.file.AccessDeniedException: /var/vcap/packages/elasticsearch/config/elasticsearch.yml
        at sun.nio.fs.UnixException.translateToIOException(UnixException.java:84)
        at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
        at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
        at sun.nio.fs.UnixFileSystemProvider.newByteChannel(UnixFileSystemProvider.java:214)
        at java.nio.file.Files.newByteChannel(Files.java:361)
        at java.nio.file.Files.newByteChannel(Files.java:407)
        at java.nio.file.spi.FileSystemProvider.newInputStream(FileSystemProvider.java:384)
        at java.nio.file.Files.newInputStream(Files.java:152)
        at org.elasticsearch.common.settings.Settings$Builder.loadFromPath(Settings.java:1061)
        at org.elasticsearch.node.internal.InternalSettingsPreparer.prepareEnvironment(InternalSettingsPreparer.java:88)
        at org.elasticsearch.common.cli.CliTool.<init>(CliTool.java:107)
        at org.elasticsearch.common.cli.CliTool.<init>(CliTool.java:100)
        at org.elasticsearch.bootstrap.BootstrapCLIParser.<init>(BootstrapCLIParser.java:48)
        at org.elasticsearch.bootstrap.Bootstrap.init(Bootstrap.java:241)
        at org.elasticsearch.bootstrap.Elasticsearch.main(Elasticsearch.java:35)
Refer to the log for complete error details.

Haven't reproduced on latest release yet. Thought it'd be worth recording here, though.

We also experience the same issue on 203.0.0 for the new version of the stemcell 3531.4 with the rolled back umask changes.

@camelpunch @FlorianNachtigall Since release v207.0.0 elasticsearch job is using path.conf property to read config file from /var/vcap/jobs/elasticsearch/config folder. Latest v209.0.0 release works as expected with 3541.latest stemcell version.
https://github.com/cloudfoundry-community/logsearch-boshrelease/commit/4508d9acab0dfe3a43af57cfa4fe3d885f70e47b#diff-df08e431dda0ea301e3e3081a57ec33dR58


Make standard assertions entry point class extend AssertJ Assertions

The generated standard assertions entry point class now extends
org.assertj.core.api.Assertions which allows for an easier importing of
assertions. This pattern is recommended here:
http://joel-costigliola.github.io/assertj/assertj-core-custom-assertions.html#single-assertion-entry-point
I know that it is only a template change and users could change this themselves easily. However, I am a big fan of useful default configurations. As far as I can tell, the change does not break anything for users and it is a big plus because now, you only ever have to import one Assertions class.

Hmm, I just read the second paragraph in the docs about the issue with the base class. That would be a breaking change then.


Introduce a Result error object.

Introduce a Result object to carry an abstract error with a corresponding message. We already had config_parse_error, but this is slightly more general. I primarily added this because of the unhelpful error message you get when storage.config fails to load.

Linux build successful! See https://ci.trafficserver.apache.org/job/linux-github/1480/ for details.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/freebsd-github/1587/ for details.

Intel CC build successful! See https://ci.trafficserver.apache.org/job/icc-github/20/ for details.

clang-analyzer build successful! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/152/ for details.


vascular leaf primordium abaxial side (PO:0004725)

Propose term and definition revision:
vascular leaf primordium abaxial side (PO:0004725): A portion of vascular leaf primordium (PO:0000017) that faces away from the shoot apical meristem (PO:0020148) and develops into the abaxial (lower) side of the leaf lamina (PO:0020039).
Related term: [plant-ontology-po-term-requests:#570]
Reported by: atkinsob
Original Ticket: obo/plant-ontology-po-term-requests/571

Accepted, closing


VS2017, VS2019, VSCode

On your extension page it says 'Added Support for the VS2015 and now VS2017 (sorry for the delay) however I am unable to upload it as the VS Gallery gives an error.'
It doesn't seem like the VS2017 update was ever published here though, and VS2019 (which is quite good, surprisingly) is out now.

Oh, and I'm also curious if you'd be willing to port this to VSCode. It's a much lighter tool based off the VS design, and it's platform-independent. I use it as my primary text editor on Linux these days.

How do I change the colours?


Penlight 1.4.0 breaks build

Hi there!
Just thought I'd leave you a heads-up as a warning that Busted's next CI build is going to fail. I actually just ran into this problem myself on my own project, caused by a new version of Penlight that was pushed to Luarocks about 3 hours ago. Luarocks will use the new version (1.4.0-1) by default since it falls within the >=1.3.2-2 rule in Busted's rockspec files, and something's changed in pl.path that's causing problems. I'm not actually sure the direct cause of the problem, but when I run busted spec with the latest version of Penlight, Busted is no longer able to find the test files.
smhxx@Development:~/GitHub/busted$ sudo luarocks make busted-2.0.rc12-1.rockspec
Updating manifest for /usr/local/lib/luarocks/rocks
busted 2.0.rc12-1 is now built and installed in /usr/local (license: MIT <http://opensource.org/licenses/MIT>)

smhxx@Development:~/GitHub/busted$ busted spec

0 successes / 0 failures / 1 error / 0 pending : 0.000033 seconds

Error → No test files found matching Lua pattern: _spec

smhxx@Development:~/GitHub/busted$ sudo luarocks make busted-scm-0.rockspec
Updating manifest for /usr/local/lib/luarocks/rocks
busted scm-0 is now built and installed in /usr/local (license: MIT <http://opensource.org/licenses/MIT>)

Checking stability of dependencies on the absence of
busted 2.0.rc12-1...

Removing busted 2.0.rc12-1...
Removal successful.
smhxx@Development:~/GitHub/busted$ busted spec

0 successes / 0 failures / 1 error / 0 pending : 0.000022 seconds

Error → No test files found matching Lua pattern: _spec

Anyway, I'm just updating my .travis.yml for now to use the older version of Penlight, just thought I'd help out and bring this to your attention so that it doesn't come as a surprise the next time you commit. Cheers!

To clarify, I've done some digging and determined that this is a bug in Penlight's dir.getallfiles() method. I'm pretty sure Busted should be fine once it is resolved. I'm working on a PR now and will submit it to Penlight tonight.

FWIW, this issue manifests itself as the following when running with TAP support:
/Users/jszakmeister/projects/neovim/neovim/.deps/usr/bin/luajit: ...im/.deps/usr/share/lua/5.1/busted/outputHandlers/TAP.lua:33: attempt to concatenate field 'currentline' (a nil value)
stack traceback:
       	...im/.deps/usr/share/lua/5.1/busted/outputHandlers/TAP.lua:33: in function 'showFailure'
       	...im/.deps/usr/share/lua/5.1/busted/outputHandlers/TAP.lua:72: in function 'fn'
       	...jects/neovim/neovim/.deps/usr/share/lua/5.1/mediator.lua:103: in function 'publish'
       	...ps/usr/share/lua/5.1/busted/modules/test_file_loader.lua:93: in function 'testFileLoader'
       	.../neovim/neovim/.deps/usr/share/lua/5.1/busted/runner.lua:158: in function <.../neovim/neovim/.deps/usr/share/lua/5.1/busted/runner.lua:11>
       	...deps/usr/lib/luarocks/rocks/busted/2.0.rc12-1/bin/busted:3: in main chunk
       	[C]: at 0x01000010c0

CMake Error at /Users/jszakmeister/projects/neovim/neovim/cmake/RunTests.cmake:39 (message):
  Running unit tests failed with error: 1.

Update: The bugfix is now merged into Penlight/master, so the next time they push to Luarocks it should fix everything. I guess it's up to the maintainer whether they're going to do a 1.4.0-2 version right away (I would hope so) or wait to see if any new problems crop up. All in all, it's been a year since the last update to Penlight, so something was pretty much guaranteed to be off... good thing it was literally a one-character fix! (Smallest PR ever?)

I'll point to 1.4.0-2 (or whatever they choose) once it goes live - thanks!

Penlight 1.4.1 has been released with a fix for this issue.

Cool, thanks @mpeterv!


[Drivers] Add an optional configuration to skip ib drivers installation.

Coverage increased (+0.01%) to 52.943% when pulling 3d2d4e338dcd773c7c0ed3ff999aca07e9244247 on yuye/ib-patch into 02f4a4980d635704c2ab459b01085c396d4108f1 on master.


Feat: Too small buffer size for data transmission and rdb read-write

Bugs

func (r *syncStandaloneReader) receiveRDB() string pass a writer  instead of a BufferWriter when call receiveRDBWithoutDiskless
func (r *syncStandaloneReader) receiveRDBWithoutDiskless(marker string, wt io.Writer) use 32MB buf to buffer tcp data before every write to file, and hoping to call Write function once every 32M cycles.
But the default buffer size of bufio.Reader is 4096, so each call of r.rd.Read(buf[:readOnce]) can only return up to 4k data, and then will call Write function and write to File

Fix

use BufferWriter when calling func (r *syncStandaloneReader) receiveRDBWithoutDiskless(marker string, wt io.Writer)
Add reader/writer buffer size options for both tcp for scenarios of data transmission and rdb read-write

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.yinhang.sun seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

I have a few questions:
The RDB reception uses a 4096-byte bufReader. After reviewing the bufio source code, if the length of the []byte passed to the Read method exceeds the buffer size, the actual read operation will use the passed length directly. Therefore, the statement that "if the underlying network returns data exceeding 4096 bytes, it will be read in batches" is inaccurate. Additionally, saying that the length written to the file is only 4096 bytes is also incorrect. Furthermore, file descriptors at the operating system level have their own caching mechanisms. Unless File.Sync is manually called, forced disk writes will not occur, so disk usage is unlikely to be high.
Adding these configurations to the configuration file will significantly increase the learning and understanding cost for users. Is there a specific need that requires such special configurations?
我有几个疑问：
1、接收RDB使用了4096个字节的bufReader。看了一下bufio的源码，如果传入Read方法的[]byte长度大于buffer的长度，那么会直接使用传入的长度读取，那么这里“如果底层网络返回数据超过4096将分批读取”的说法不准确。那么将其写入到文件的长度只有4096更是不对，而且文件fd在操作系统层面还有缓存，只要不手动执行File.Sync则不会触发强制落盘，对硬盘的占用也不会很高。
2、在配置文件中增加这些配置将大幅增加用户的学习理解成本，这里是否有什么一定需要特殊配置的吗？

hi EquentR, you're correct. I failed to locate the optimization in bufio.Read. Sorry for taking your time


Update locking-behavior.md

Typo (DVM --> DMV)

@charlesfeddersen

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@Jak-MS This can be signed off, thanks.


Help Wanted: Writing Documentation

We need a well written documentation for the project along with some draw.io graphs about how the project works.

i can help you out

Hey! Thanks for the reply, if you could join our Slack at https://join.slack.com/t/fosspush/shared_invite/enQtNDU3MzAzNTEwMTEzLWFhNzVjYWUxNTE5MjZkYzYzZWNjYzdmZDM4ZTc5ZGJjYjYyYTVmYmZkYzgwNTA4NmE4YzMwNjNlNjFjMzY0ZjI that would be appreciated. If not, i can get someone there who works on the API server to give you some starting points.

@shivanidesai14 one of the simplest things to contribute is to help convert our README.md's to meet the new standards on http://push.fish/repository-standards/


Is there any private instance available for Orbit DB. If there, then please provide more information regarding its installation.

Please provide more installation details regarding orbit DB private instance for Ethereum Blockchain applications.

Hi @kottackalthulasi, thanks for asking this. This will soon be included in the Field Manual but for now I can type out an answer here, and then others can also chime in with techiques that work for them.
For starters, I believe there's two main routes you can go, and you can do both of them:

Run a private IPFS network. I wrote a blog post about how to do it here: https://mrh.io/ipfs-private-networks/ Essentially the IPFS nodes that are running share a swarm key, and cannot connect to any other nodes that don't have the same swarm key. Other public nodes don't swarm with your nodes either.

Encrypt-at-rest all persisted data with user keys. you can use metamask keys for this by way of the identity-provider. There's an implementation here: https://github.com/orbitdb/orbit-db-identity-provider/blob/master/src/ethereum-identity-provider.js  Essentially the metamask keys are cross-signed with the orbitdb keys proving ownership of both and then you have full write-protection via Metamask

@aphelionz Thanks for the reply. I have already set up my IPFS as private network. But I don't understand how the step-2 can be implemented. Can you please explain it in more detail.

@aphelionz Let me know if there is a private IPFS network, then the initiating orbitdb will also use private instance? Sorry if it's wrong.

@kottackalthulasi That's correct. Orbitdb relies on ipfs for all of its network IO, so if ipfs is in private swarm mode, then orbitdb will be unable to connect to anything outside the private ipfs swarm.

@phillmac thanks for the response

@kottackalthulasi 	Closing this as answered. Thank you. :)


[SPARK-50077][SQL] Introduce a new pattern object for LogicalRelation to help avoiding default full params pattern

What changes were proposed in this pull request?
This PR proposes to introduce a new pattern object to extract BaseRelation and CatalogTable from LogicalRelation, and update existing pattern matches with LogicalRelation with the new pattern.
This PR also adds the information of pattern object and encourage devs to use it.
Why are the changes needed?
I found it very difficult to add a param into LogicalRelation, because a bunch of places use pattern matching with LogicalRelation, and all of them are using default pattern with specifying all params (despite wildcards).
I looked into the patterns and realized most of the patterns just need relation and catalog table inside the LogicalRelation. output and isStreaming are used infrequently. That said, introducing a new pattern object extracting BaseRelation and CatalogTable from LogicalRelation would cover most of the patterns we have for LogicalRelation, and this would help a lot to introduce a new param into LogicalRelation in future.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
N/A (Existing tests would cover it)
Was this patch authored or co-authored using generative AI tooling?
No.

cc. @cloud-fan Would you mind taking a look? Please cc. to others if you are busy with other stuff. Thanks!

Thanks @cloud-fan for your review! I've addressed your comments. PTAL.

I've addressed the latest comments. Thanks! Merging to master.


Feature/fbp 133 multiselect inside subprocess

Codecov Report

Merging #158 into master will increase coverage by 0.13%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##             master     #158      +/-   ##
============================================
+ Coverage     62.84%   62.97%   +0.13%
- Complexity      833      841       +8
============================================
  Files            85       85
  Lines          3666     3679      +13
  Branches        680      683       +3
============================================
+ Hits           2304     2317      +13
+ Misses         1118     1116       -2
- Partials        244      246       +2

Flag
Coverage Δ
Complexity Δ

#unittests
62.97% <83.33%> (+0.13%)
841.00 <0.00> (+8.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ
Complexity Δ

...n/com/valb3r/bpmn/intellij/plugin/render/Canvas.kt
70.98% <66.66%> (+0.46%)
92.00 <0.00> (+7.00)

...tellij/plugin/render/DefaultBpmnProcessRenderer.kt
60.12% <100.00%> (+1.68%)
25.00 <0.00> (ø)

...lugin/render/elements/shapes/ShapeRenderElement.kt
79.66% <0.00%> (ø)
48.00% <0.00%> (ø%)

...gin/render/elements/edges/BaseEdgeRenderElement.kt
76.19% <0.00%> (+1.58%)
37.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2101cc2...b6f92a6. Read the comment docs.


Cannot override attributes after upgrading from Chef Client 13.7.16 to 13.8.0

Description
Cannot override attributes after upgrading from Chef Client 13.7.16 to 13.8.0.
Chef Version
13.8.0
Platform Version
Debian 9
Replication Case

I'm using the resolver cookbook version 2.0.1 (latest).
I've set node.normal['resolver']['search'] = nil in one of my cookbooks.
After upgrading, this line is no longer respecting my nil value and instead is picking up node['domain'] as per https://github.com/chef-cookbooks/resolver/blob/master/attributes/default.rb#L19 (same issue when I use override instead of normal).

Setting nil has never worked to override attributes.  The deep merge cache code uses nil for "not present" rather than being an actual nil value to merge.  This has been consistent behavior since at least Chef-11.0
The use of node.normal is also highly discouraged since it persists on the node object in the database rather than being wiped at the start of every run like default and override are.  This probably does not have anything to do with whatever issue you're seeing though.
node.rm_default("resolver", "search") can be used to remove the default level setting from the cookbook.

Thank you. This happened on an odd setup using chef-client -z. Changing node.normal to node.default fixed the issue. Closing.


vcpkg install libyuv:x64-windows in win10 x64, and ./vcpkg install libyuv-x64-linux failed in centos7

anybody has the same trouble?

Hello @chris-shenzhen-china ! Please send your report to upstream project. This repo is just a personal mirror.
https://chromium.googlesource.com/libyuv/libyuv


Call to undefined method Illuminate\Database\Query\Builder::findSimilarSlugs()

Hey there!
I am having an issue while using this library inside a factory. Basically I am trying to use the createSlug service method but it's returning an error of:
Call to undefined method Illuminate\Database\Query\Builder::findSimilarSlugs()
Should I include anything else? In the documentation I don't see other things getting included :)
My code is the following:
use Faker\Generator as Faker;
use \Cviebrock\EloquentSluggable\Services\SlugService;
use App\Category;

$factory->define(App\Category::class, function (Faker $faker) {

    return [
        'name' => $faker->name,
        'cover' => $faker->image($dir = '/tmp'),
        'slug' => SlugService::createSlug(Category::class, 'slug', $faker->name)
    ];

});

Thanks guys for the assistance!

Does App\Category use the Sluggable trait?
(You probably also want to do $name = $faker->name outside of the return array.  Otherwise I think you will get a slug that doesn't match the name ... if that matters to you.)

Closing due to no response.  Feel free to re-open or comment if you are still having issues.

Just to add, I had the same issue and Use Sluggable; healped me here.
But just to let you know, it's not in the documentation.
Other than that - thank you, nice library.


WIP: to_database new fields

Pull Request Test Coverage Report for Build 1005

44 of 44 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.6%) to 58.702%

Totals

Change from base Build 1001:
1.6%

Covered Lines:
995

Relevant Lines:
1695

💛  - Coveralls


frontend: k8s: Adding docs, improving types

Improve some of the docs and types in lib/k8s. For https://github.com/headlamp-k8s/headlamp/issues/1295

frontend: cluster: Add docs and some missing fields
frontend: cluster: Add auth_type to Cluster interface
frontend: helpers: Add docs for getRecentClusters, getVersion, getProductName
frontend: helpers: Add docs for setRecentCluster
frontend: apiProxy: Improve docs for drainNodeStatus
frontend: apiProxy: Improve docs for drainNode
frontend: apiProxy: Add docs for listPortForward
frontend: apiProxy: Add docs for stopOrDeletePortForward
frontend: apiProxy: Add docs for startPortForward
frontend: apiProxy: Add docs for metrics
frontend: apiProxy: Add docs for apply
frontend: apiProxy: Add docs for combinePath
frontend: apiProxy: Add docs for connectStream
frontend: apiProxy: Improve docs for streamResult
frontend: apiProxy: Add notes about apiFactoryWithNamespace, simpleApiFactoryWithNamespace
frontend: apiProxy: Add docs for singleApiFactory
frontend: apiProxy: Add docs for multipleApiFactory
frontend: apiProxy: Add docs for apiFactory
frontend: apiProxy: Add docs for repeatFactoryMethod
frontend: apiProxy: Add docs for repeatStreamFunc
frontend: apiProxy: Add some docs for StreamResultsCb StreamErrCb
frontend: apiProxy: Improve docs for ClusterRequestParams and clusterRequest
frontend: apiProxy: Add docs for getClusterAuthType
frontend: apiProxy: Add docs for refreshToken
frontend: apiProxy: Add more fields to QueryParams and document
frontend: apiProxy: Add docs for RequestParams, improve types

I addressed the notes by @joaquimrocha  (thanks!).

Fixed a conflict.

rebased against main

Thanks @joaquimrocha
(I've addressed all the notes.)

That rebase oopsie should be fixed now.


Introduce an option to mangle compilation results

tl; dr: I propose to add an option that would compile this
.photos
  .photo
    .description

to
.photos {}
  .photos-photo {}
    .photos-photo-description {}

What
In the most of today's heavy webapps, styles are very unstructured.
Dynamic CSS-like languages (less, sass, stylus) allow selector nesting, like:
.users
  padding: 2px
  .user
    padding: 10px
    .avatar
      padding: 16px

Cost
It is an awesome and very structured way to describe styles.
Although, that approach has one major issue: the descendant selector is the most expensive selector in CSS. Really, it is dreadfully expensive.
In my webapps, I usually use five and more indented levels. Comprehensive example: paulmillr/vk-contest-2011/css/style.css#L450.
Idea
To deal with performance issues in big webapps, user would be able to use some new compilation option, like --mangle, that would mangle all descendant selectors with some symbol, that would be used for namespace resolution. Like _ or -.
So, instead of this
.wall {
  border: 1px solid #696; }
  .wall-posts {
    padding-top: 7px; }
    .wall-post {
      padding: 12px 0 6px 1px;
      border-top: 1px solid #ededed; }
      .wall-post-avatar {
        position: absolute;
        display: block;
        width: 50px;
        height: 50px; }
      .wall-post-content {
        margin-left: 50px;
        padding-left: 13px; }
        .wall-post-initials {
          font-weight: bold;
          color: #4f6b8d; }
          .wall-post-initials:hover {
            text-decoration: underline; }
        .wall-post-text {
          padding: 3px 0; }
        .wall-post-attachment {
          padding: 5px 0; }
          .wall-post-attachment-type-photo {
            float: left;
            padding-right: 15px; }
          .wall-post-attachment-label {
            font-weight: bold;
            color: #888; }
          .wall-post-attachment-photo {
            margin: 0; }
          .wall-post-article-photo {
            position: absolute;
            padding-top: 5px; }
            .wall-post-article-photo-image {
              width: 75px;
              max-height: 98px; }
          .wall-post-attachment-info {
            margin-left: 85px; }
            .wall-post-attachment-info.no-attachment-photo {
              margin-left: 0; }
            .wall-post-attachment-title {
              font-weight: bold; }
            .wall-post-attachment-title:hover {
              text-decoration: underline; }
        .wall-post-footer {
          padding-bottom: 3px;
          line-height: 20px; }
          .wall-post-date {
            color: #aaa; }
            .wall-post-date:hover {
              text-decoration: underline; }

it would be much more comroftable to write something like this:
.wall {
  border: 1px solid #696; }
  .posts {
    padding-top: 7px; }
    .post {
      padding: 12px 0 6px 1px;
      border-top: 1px solid #ededed; }
      .avatar {
        position: absolute;
        display: block;
        width: 50px;
        height: 50px; }
      .content {
        margin-left: 50px;
        padding-left: 13px; }
        .initials {
          font-weight: bold;
          color: #4f6b8d; }
          .initials:hover {
            text-decoration: underline; }
        .text {
          padding: 3px 0; }
        .attachment {
          padding: 5px 0; }
          .type-photo {
            float: left;
            padding-right: 15px; }
          .label {
            font-weight: bold;
            color: #888; }
          .photo {
            margin: 0; }
          .article-photo {
            position: absolute;
            padding-top: 5px; }
            .image {
              width: 75px;
              max-height: 98px; }
          .info {
            margin-left: 85px; }
            .info.no-attachment-photo {
              margin-left: 0; }
            .title {
              font-weight: bold; }
              &:hover {
                text-decoration: underline; }
        .footer {
          padding-bottom: 3px;
          line-height: 20px; }
          .date {
            color: #aaa; }
            &:hover {
              text-decoration: underline; }

I couldn't find in the docs, nor confirm in other comipilers (tested only in less.app and less.php online demo) but I was able to achieve this with pain old & that seems to work like a string, so:
.photos {
    &-photo {
        &-description {}
    }
}

should compile to
.photos {}
.photos-photo {}
.photos-photo-description {}


Updating kelp (and general particles things) to simplify API and make it much easier to get it working on GPU

I think before I had tried to make to generalise the active particles stuff too much making the api really over complicated. Now to make a model with kelp all you should need todo is:
using OceanBioME, Oceananigans

grid = RectilinearGrid(; topology = (Periodic, Periodic, Bounded), size = (1, 1, 16, ), extent = (20, 20, 100, ))

particles = SLatissima()

biogeochemistry = LOBSTER(; grid, particles)

model = NonhydrostaticModel(; grid, biogeochemistry)

(I've not got it working fully yet)

To do

[ ] Test on GPU
[ ] Docs
[ ] Output writer

Its now doing the thing where it can't compile on GPU and just grows and grows in memory

I'm still having problems using the kelp particles on GPU because although they appear to be working when I run time_step!(model, 1.0) the memory (not video memory) goes up until slurm kills the process.
I'm going to merge this anyway for the API and docs changes and open a new issue for this.


If the 5000 port JSONRPC is blocked or in use, it should keep incrementing by 1 until it finds a free port

thread 'tokio-runtime-worker15:43 [tari_validator_node::http_ui::server] ' panicked at 'INFOerror binding to <IP_ADDRESS>:18200: error creating server listener: Only one usage of each socket address (protocol/n
etwork address/port) is normally permitted. (os error 10048)  🌐 HTTP UI started at <IP_ADDRESS>:5000
', C:\Users\mikedesk.cargo\registry\src\github.com-1ecc6299db9ec823\hyper-0.14.20\src\server\server


⚠ Text Filter API Endpoint has degraded performance

In 326e081, Text Filter API Endpoint (http://textfilter.roblox.com/) experienced degraded performance:

HTTP code: 200
Response time: 1176 ms

Resolved: Text Filter API Endpoint performance has improved in 98d11de.


fix: warn on relative link without trailing slash in markdown

Preview Deployment has these Lighthouse Audit scores:


Plans to release to supermarket?

This is a great cookbook. I can't find it on the supermarket though, so I end up having to do the following in my wrapper cookbook berksfile.
source "https://supermarket.getchef.com"

metadata

cookbook 'kafka', github: "mthssdrbrg/kafka-cookbook", tag: "v0.8.0"
cookbook 'cron'

Any plans to upload to the supermarket?

Hm, haven't really thought about it to be honest, but maybe. It would however require a renaming as kafka is already taken (and names on the supermarket are global...). I'm generally not fond of cookbook names with a hyphen (thinking to rename it to kafka-cookbook), and it causes problems with LWRPs (can be avoided by not using LWRPs).
I'll think about it for the v1.0.0 release that I'm planning for the beginning of next year.


Remove support for JVM metrics agent

DO NOT MERGE: until the heroku/jvm buildpack has been released.
This PR removes the Java Metrics agent installation. It leaves the hatchet test framework in place, but removes the JVM test. Thus, the hatchet suite is a no-op for now (we can remove it in another PR if desired).

/cc @apg @Xe @murphybytes

Presumably, this means that @eablack and @mimen can no longer rely on the buildpack for detection of JVM metrics? I think that's OK. Otherwise, this looks fine to me.

This is ready to merge. JVM buildpack changes have been deployed.


Theme instructions don't work.

Using Xamarin Live Player and the snippets provided:
 <?xml version="1.0" encoding="utf-8" ?>
 <Application xmlns="http://xamarin.com/schemas/2014/forms"
              xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
              xmlns:light="clr-namespace:Xamarin.Forms.Themes;assembly=Xamarin.Forms.Theme.Light"
              x:Class="MyApp.App">
     <Application.Resources>
         <ResourceDictionary MergedWith="light:LightThemeResources" />
     </Application.Resources>
 </Application>

 ...
        LoadApplication(new App());

        var x = typeof(Xamarin.Forms.Themes.LightThemeResources);
        x = typeof(Xamarin.Forms.Themes.LightThemeResources);
        x = typeof(Xamarin.Forms.Themes.Android.UnderlineEffect);

I get the following error. It crashes and never loads the theme.
Visualization Error
MergedWith should inherit from ResourceDictionary (ArgumentException)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0b0ba04e-c96b-4c0d-fac5-e449fd7adeb1
Version Independent ID: 614b2e82-816c-5675-705e-daa302b1a175
Content: Light Theme - Xamarin
Content Source: docs/xamarin-forms/user-interface/themes/light.md
Service: unspecified
Product: xamarin
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Hey @smchughinfo, Xamarin Live Player is still in preview, and has many limitations. For real-world app building and debugging it is best to use a stable emulator or device.
When you encounter bugs, issues, or have a feature request, please use the Developer Community site. Thanks!


About 'SharedWriter.Reserve' parameter 'count'

I found in your example benchmark-disruptor 'ReserveMany' that Reserve's parameter used a value of 16. Whether or not to use ReserveMany, its parameters 'count' must be a power of 2?

@XieXiaomei-ptr No. Reserve can be any number you want up to the size of the buffer.


How to make a ViewModel KodeinAware

Android architecture viewModel is bound as:
bind<ViewModel>() with singleton { ViewModelProviders.of(this@BaseActivity).get(ViewModel::class.java) }
There is no constructor to pass a kodein instance. How should I approach this so that ViewModel can receive kodein dependencies?
Thanks for any help, your library is great!

I just initialized it after I bound it.

class ViewModel : ViewModel() {

    lateinit var repository: Repository

    fun init(kodein: Kodein) {
        repository = Repository(kodein)
    }

}

viewModel.init(kodein)

You actually can use AndroidViewModel instead of ViewModel.
class AwesomeViewModel(app: Application): AndroidViewModel(app), KodeinAware{
    override val kodein: Kodein by closestKodein(getApplication<App>())
    private val repository: AwesomeRepository by instance()
}


Preserving whitespace

I've had some unexpected behaviour minifying an unordered list. Let's say you have the following HTML:
`

 Item 1 Item 2

`
This will display as:
Item 1 Item2
After being minimized using html_press it changes to:
Item1Item2
I'm trying to find the balance between rendering the original HTML file vs squeezing out minimal HTML. In my case I've forked html_press and commented out process_block_elements.
From the library's point of view it's not clear if you can make the same decision because whitespace should have no effect block level elements unless you mess with them in CSS.
It's something for you to ponder anyway.

project is deprecated https://github.com/stereobooster/html_press/issues/21


added error logging for uncaught exceptions from workers

i was setting up ternjs for a new project that i inherited at work, but it was having trouble parsing
some of my webpack config for the webpack plugin because of some ESnext syntax that is unsupported by acorn. i had no idea what was actually failing, so i added some logging for the uncaught exception stacktrace from a worker. this helped me pinpoint what the unsupported configuration was so that i figure out what actually to do with the "bad" code.

closing due to inactivity


Fix typos in readme template

Fixes a couple of typos in readme (template), and updates 2 places that refer to the hosts file as a 'folder'.

Excellent @someonefamous.  Merging.


MemKgStore: search on include = source facet not working

Exclude works, but Lucene has odd handling of "include" facets.

See KgSearchQueryStoreBehaviors, commented out test with TODO.


Restart subgraph from a certain block number

Feature request

It sounds like you want https://github.com/graphprotocol/graph-cli/issues/218.

This is covered by the experimental grafting feature.


Develop

As a next challenge, you can introduce a relationship between the user and the todos. This way only the authorized user can change his/her todos


_audio_backends platform independent

🐛 Bug
The constant _audio_backends is referenced by BACKENDS in the common utilities of the test folder. test_batch_mfcc is skipped if the 'sox' key is not present in that constant, but it always is. That means this test will be executed in environments where the package may not exist.
(base) PS C:\Users\chris\dev\audio> python .\test\test_batch_consistency.py TestTransforms.test_batch_mfcc
E
======================================================================
ERROR: test_batch_mfcc (__main__.TestTransforms)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\tools\Anaconda3\lib\contextlib.py", line 74, in inner
    return func(*args, **kwds)
  File ".\test\test_batch_consistency.py", line 185, in test_batch_mfcc
    waveform, _ = torchaudio.load(test_filepath)
  File "c:\users\chris\dev\audio\torchaudio\__init__.py", line 87, in load
    filetype=filetype,
  File "c:\users\chris\dev\audio\torchaudio\_sox_backend.py", line 38, in load
    import _torch_sox
ModuleNotFoundError: No module named '_torch_sox'

----------------------------------------------------------------------
Ran 1 test in 0.001s

FAILED (errors=1)

To Reproduce
Steps to reproduce the behavior:

Remove sox from your environment
Run python test/test_batch_consistency.py TestTransform.test_batch_mfcc

I can provide more detailed information if required.
Expected behavior
The test should be skipped if sox is not available.
Environment
(base) PS C:\Users\chris\dev\audio> python .\collect_env_1.py
Collecting environment information...
PyTorch version: 1.6.0a0+8a60d8b
Is debug build: No
CUDA used to build PyTorch: None

OS: Microsoft Windows 10 Home
GCC version: Could not collect
CMake version: version 3.14.0

Python version: 3.7
Is CUDA available: No
CUDA runtime version: No CUDA
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA

Versions of relevant libraries:
[pip] numpy==1.18.1
[pip] numpydoc==0.9.2
[pip] torch==1.6.0a0+8a60d8b
[pip] torchaudio==0.5.0a0+5a75b63
[conda] blas                      1.0                         mkl
[conda] mkl                       2020.0                      166
[conda] mkl-include               2020.0                      166
[conda] mkl-service               2.3.0            py37hb782905_0
[conda] mkl_fft                   1.0.15           py37h14836fe_0
[conda] mkl_random                1.1.0            py37h675688f_0
[conda] numpy                     1.18.1           py37h93ca92e_0
[conda] numpy-base                1.18.1           py37hc3f5095_1
[conda] numpydoc                  0.9.2                      py_0
[conda] torch                     1.6.0a0+8a60d8b           dev_0    <develop>
[conda] torchaudio                0.5.0a0+5a75b63           dev_0    <develop>

Additional context

A simple fix would be to make _audio_backends also depend on platform here.
#561 fixed the particular error you saw.

It would be nice if it can detect which backend is available at run time.
Also we need to document which one is the default backend.
soundfile seems to be a good default as it's available on Windows too, but looking at setup.py, it expects SoX.

It would be nice if it can detect which backend is available at run time.

Yes. In some sense and depending on the definition of run time, this is already the case, see here and here.
There's also a partial discussion of backend dispatch in #425.

Also we need to document which one is the default backend.
soundfile seems to be a reasonable default as it's available on Windows too (also it is easy to install), but looking at setup.py, it expects SoX.

The default backend for torchaudio has been sox. torchaudio only officially support macos and linux. We do not officially support windows, but there the default is soundfile, see #425 for discussion.


Rami/checking grades

Im pulling from the checking-grade  branch into the main branch

I reviewed the pull request and approved the commit.


Enable FSDP Test in CI

Repeat of https://github.com/pytorch/ao/pull/206 but against main instead of my own branch 🤦

i had the same issue of not finding hqq before. curious of the solution

Taking a look

Ok it worked just needed better import skips - waiting for @jerryzh168's ship it work to land before landing this


CLI?

This is great, but it would be awesome to have a command line version and output the data in a text format operated from the command line.

Thank you for your feedback.
A CLI and a GUI are 2 different things. This repo is aimed for a user friendly GUI, because end users are usually not developers.
I could make a pure CLI tool if needed but it won't be here.
I will add export features for example in CSV.

Thanks. I guess I can take a look at https://github.com/Tazeg/browserhistory/tree/main/electron/app/js if I want an idea of how you are getting the data. (wow I didn't know chrome is storing in SQL)


Feat: update readme

PR to update the readme file (supersedes PR https://github.com/OpenBioML/chemnlp/pull/1 which can be closed after this PR is merged).

@kjappelbaum I added the contributing guide and closed the older readme PR.
We can merge if you are fine with it. :-)


WSL2 + Docker CE Inside Install Script: (after several attempts) Temporary failure resolving   'download.docker.com', 'archive.ubuntu.com' but ping works but not for 'pkg.ddev.com'

Is there an existing issue for this?

[X] I have searched the existing issues

Output of ddev debug test
Can't provide this because the issue is before ddev is installed, i.e. a problem with the ddev installation script, see details below.
Expected Behavior
To be able to run the installation script successfully at:
https://ddev.readthedocs.io/en/latest/users/install/ddev-installation/#windows
Actual Behavior
The installation script at: https://ddev.readthedocs.io/en/latest/users/install/ddev-installation/#windows
Failed due to "Temporary failure resolving  'download.docker.com', 'archive.ubuntu.com'" and "pkg.ddev.com" - after several attempts.
I am giving the output of install script ( https://ddev.readthedocs.io/en/latest/users/install/ddev-installation/#windows ) - i.e. the output of the 2nd command:
iex ((New-Object System.Net.WebClient).DownloadString('https://raw.githubusercontent.com/ddev/ddev/master/scripts/install_ddev_wsl2_docker_inside.ps1'))

The output is here: https://gist.github.com/therobyouknow/4b9094983bedeccc1b6ccb1d298aa140
Because this install seems to fail, I don't get as far as ddev to show the output of the usual diagnostics requested.  The problem is installing ddev itself, with the install script.
I ran the iex command as part of the steps.  It failed with the "temporary failure resolving  'download.docker.com', 'archive.ubuntu.com'  'pkg.ddev.com' " as per title of this issue.
I did a ping of the above failed addresses and this failed.
But then I connected to my organisation's VPN using GlobalProtect app.
The ping then worked for  'download.docker.com', 'archive.ubuntu.com' but not for 'pkg.ddev.com'
Also, I can visit all of these addresses in my web browser.
But the script still failed with the same issue.
So given that,  why would connecting to those addresses not work in the install script?
Is there a specific firewall rule I can set on Windows to resolve this issue? Or something else?
Steps To Reproduce
Attempt to follow the steps at: https://ddev.readthedocs.io/en/latest/users/install/ddev-installation/#windows
"I have searched the existing issues": https://github.com/ddev/ddev/issues?q=is%3Aissue+is%3Aopen+temporary
Anything else?
No response

I have looked at trying changing nameservers / DNS of my machine:
https://stackoverflow.com/questions/60269422/windows10-wsl2-ubuntu-debian-no-network
and here: https://www.tenforums.com/tutorials/77444-change-ipv4-ipv6-dns-server-address-windows.html but this didn't resolve the issue.  But it did mean I was changing some IP addresses set by my organisation so not an ideal solution as I am thinking this might cause issues elsewhere. So I have now set them back to what they were.

I think this is a WSL2 issue rather than ddev. Therefore I will look for advice on their github and if necessary raise an issue there.

This is in fact an issue with your network or your computer, has nothing to do with DDEV. Closing for now, happy to continue the conversation.
I recommend using <IP_ADDRESS> as your DNS server on your computer or your local network.

Given that it is related to networking and wsl2, I've seen something similar before whereby wsl2 can't connect out to anything:
https://stackoverflow.com/questions/66444822/wsl-2-dns-is-not-working-with-vpn-connection-on-win-10 which relates to https://github.com/microsoft/WSL/issues/1350
So I will look at that solution.


Submit Form ( POST ) after confirmation

Hi,
I have a bootstrap form with a submit button as below;
<button type="submit" class="btn btn-primary" name="button_deluser"  > Delete Selected User </button>
When the button is clicked - the form is submitted. I would like a confirmation box (Yes - Delete, No ).
I dont understand how to incorporate jConfirm into the button above from the documentation provided.
Any ideas ? Alert - Jquery newbie here.

Bump

Wow. Over a year ago and I'm just seeing this. I'm sure by now you're a jQuery genius. How's it going?

I completely rebuilt the plugin FYI. You should really check it out: https://github.com/HTMLGuyLLC/jConfirm


multi services share one build config

Signed-off-by: fansi<EMAIL_ADDRESS>

This change is

@lilianzhu review ok 后再 merge


Pool machine creation hangs, session is not returned

Virtual environment:
Linux machine (RedHat based), a new pool machine is being created (non existed before).
Test code (just a piece):
--- 8< ---
pool = virtualbox.pool.MachinePool("Some Linux Machine")
session = pool.acquire("john", "john1234", "gui")
--- 8< ---
Problem is that it will timeout on this operation and never return a session object, problem seem to be in:
guest.py -> IGuest -> create_session -> line: "session.file_query_info(test_file)" (test for "/bin/sh" file)
It keeps raising exception with error message something like: "object exists but it not a file", the problem is that "/bin/sh" is a link to "bash".

This is fixed in 1.0.0 of pyvbox.


Questionable value override in compute_risk_distribution

https://github.com/rte-france/challenge-roadef-2020/blob/d9a599f2440aca4fefa76e7cf72358ba92ec719a/RTE_ChallengeROADEF2020_checker.py#L137
The current code replaces the risk at time with the risk induced by the current intervention instead of adding the intervention's risk to the total risk. Hence, risk[time] is simply the risk of most recent intervention considered running at time.
I suggest the following change:
        for time in range(start_time_idx, start_time_idx + delta):
            for i, additional_risk in enumerate(intervention_risk[str(time + 1)][str(start_time)]):
                risk[time][i] += additional_risk

Hi Benjamin,
Thank you for having checked this part!


Report eth2-package v0.70

cannot running on latest version 0.70.0
error msg:
here was an error interpreting Starlark code
Evaluation error: ExecRecipe: unexpected keyword argument "service_name"
	at [github.com/kurtosis-tech/eth2-package:33:88]: run
	at [github.com/kurtosis-tech/eth2-package/src/participant_network/participant_network.star:50:76]: launch_participant_network
	at [github.com/kurtosis-tech/eth2-package/src/participant_network/prelaunch_data_generator/cl_validator_keystores/cl_validator_keystore_generator.star:69:39]: generate_cl_validator_keystores
	at [0:0]: ExecRecipe

Error encountered running Starlark code.

Screenshot Running on v0.70.0 :

Screenshot Running on v0.68.0 :

And please update the package running on cloud vm :

Hey @avenbreaks !
Good catch, we merged this PR earlier today to fix this issue. Can you retry with the latest version? This should hopefully unblock you.
Let me know if you hit any other blocker

i will try

yea is return :
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean

Hmm, this is definitely weird, I just tried it locally and it works as expected.
My first question is why are you on the master branch? Default branch is main for this repo. Are you on a custom branch or something?
Can we maybe start from a fresh clone?

Upgrade your kurtosis to latest, which is 0.71.0

> kurtosis version
CLI Version:              0.71.0
Running Engine Version:   0.71.0

clone this as a fresh repo

> git clone git@github.com:kurtosis-tech/eth2-package.git eth2-package-fresh-clone
Cloning into 'eth2-package-fresh-clone'...
remote: Enumerating objects: 2761, done.
remote: Counting objects: 100% (1194/1194), done.
remote: Compressing objects: 100% (462/462), done.
remote: Total 2761 (delta 642), reused 1063 (delta 591), pack-reused 1567
Receiving objects: 100% (2761/2761), 539.29 KiB | 1.38 MiB/s, done.
Resolving deltas: 100% (1533/1533), done.

Run it:

> cd eth2-package-fresh-clone
> kurtosis run main.star
INFO[2023-03-29T18:44:14+02:00] Creating a new enclave for Starlark to run inside...
INFO[2023-03-29T18:44:18+02:00] Enclave 'howling-crag' created successfully
INFO[2023-03-29T18:44:18+02:00] Executing Starlark package at '/Users/gbouvignies/git/eth2-package-fresh-clone' as the passed argument '.' looks like a directory
INFO[2023-03-29T18:44:18+02:00] Compressing package 'github.com/kurtosis-tech/eth2-package' at '.' for upload
INFO[2023-03-29T18:44:18+02:00] Uploading and executing package 'github.com/kurtosis-tech/eth2-package'
.....

Let me know how that goes. I'm trying to narrow down the issue here to better understand what's going on, as I can't repro it easily

Closing as stale. Feel free to re-open if this is still an issue.


Rectify the import paths of boost::function_output_iterator

Rectify the import paths of boost/iterator as suggested by compiler warnings
High Level Overview of Change
MSVC 19.x reports a warning about import paths in boost for function_output_iterator class. This commit aims to eliminate that warning by updating the import paths.

[ X ] Refactor (non-breaking change that only restructures code)

LGTM

@ckeshava: At your convenience, please comment here to confirm that, from your perspective, this PR is ready to merge.

@intelliot  Hello, it looks okay to me.
I don't have the toolchain to unit-test this change with the most recent version of develop. If the unit tests are working correctly, then it can be merged. I'm hoping there haven't been any changes to boost or rippled's compatibility.


remove_post_data_parameters throws None has no split

I use requests oauth lib to auth to a service. I would like to remove the credentials added in the form. Its about the third or so request. This is possible if a simple if request.body is set before the for loop for k, sep, v in (p.partition(b'=') for p in request.body.split(b'&')):
def remove_post_data_parameters(request, post_data_parameters_to_remove):
    if request.method == 'POST' and not isinstance(request.body, BytesIO):
        if request.headers.get('Content-Type') == 'application/json':
            json_data = json.loads(request.body.decode('utf-8'))
            for k in list(json_data.keys()):
                if k in post_data_parameters_to_remove:
                    del json_data[k]
            request.body = json.dumps(json_data).encode('utf-8')
        else:
            post_data = collections.OrderedDict()
            if isinstance(request.body, text_type):
                request.body = request.body.encode('utf-8')

            if request.body:
                for k, sep, v in (p.partition(b'=') for p in request.body.split(b'&')):
                    if k in post_data:
                        post_data[k].append(v)
                    elif len(k) > 0 and k.decode('utf-8') not in post_data_parameters_to_remove:
                        post_data[k] = [v]
                request.body = b'&'.join(
                    b'='.join([k, v])
                    for k, vals in post_data.items() for v in vals)
    return request

Any reason you can't just use the builtin post parameter filtering? https://vcrpy.readthedocs.io/en/latest/advanced.html#filter-information-from-http-post-data

I'm using it. [1] But as i mentioned above its the third request in a library which contains the credentials. The request before that a some GET, GET ...
[1]
@my_vcr.use_cassette(filter_post_data_parameters=["j_password", "j_username"])
    def test_get_object_by_id(self):
        ....

A lot of changes have happened to VCRpy since this ticket was opened. As this ticket has become stale and we have a lot of old tickets that need to be groomed, I'm closing this for now to make it easier to see what is still relevant.
However if it is still needed, please feel free to re-open or create a new ticket.
Thanks! 🙏


mobile/ci: Remove the Swift async app CI job

This app runs on CI and sends a 5MB POST request to httpbin.org. The app is flaky on CI due to sending requests to httpbin.org, and the app itself doesn't add much value to CI, as there are already hello world apps that test iOS app functionality on CI.
Fixes #37485

/assign @phlax

This PR needs to go in before we can delete the app in https://github.com/envoyproxy/envoy/pull/37489, as CI changes don't take effect within the PR


Graphics State Summary chapter

The "Graphics State Summary" page (https://docs.microsoft.com/en-us/typography/opentype/spec/tt_graphics_state) mentions the following TrueType instructions that do not exist:
SHE, SCE0, SCE1, SCE3, SCES
Probably the following instructions are meant instead: SHZ, SZP0, SZP1, SZP2, SZPS
Furthermore, zone pointers are called "gep0", "gep1", and "gep2", whereas in the "TrueType Instruction Set" chapter, zone pointers are called "zp0", "zp1", and "zp2".

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b8f3ce77-c18f-1036-ccc3-0de8c9354055
Version Independent ID: 60e1d2a3-664c-ebc9-e6f2-4d7f201c0bed
Content: Graphics State Summary (OpenType 1.8.4) - Typography
Content Source: typographydocs/opentype/spec/tt_graphics_state.md
Product: typography
GitHub Login: @v-nihar
Microsoft Alias: alib

Thanks. Fixing for OT 1.9.

Addressed in OpenType 1.9. Closing.