Refactor: make repo classes more focused

Follows discussion in #2096
Opinion: repo_base knows too much about other code and should be abstracted from external logic like:

UI (and progress indication)
persistence
code_inspector
repo deletion
and repo_srv

More concrete proposals

[ ] (A) GET_FILES_LOCAL shows progress -> implement as an event and show the progress elsewhere in UI classes
[X] (B) persistence: remove direct persistent calls from set. This is more complex. Maybe also an event on_config_change handled by repo serv
[X] (C) repo deletion -> move to repo srv (repo server is the manager of repos so it adds/deletes/etc)
[X] (D) remove global friends with zcl_abapgit_repo_srv
[ ] (E) RUN_CODE_INSPECTOR - move to services. Also probably implement as an action in router and not direct call in ZCL_ABAPGIT_GUI_PAGE_CODE_INSP

A: I think this is not important for now, there are other places which need more attention. But ideally, yes, this should be refactored, but it is low benefit and high effort. Something like #1331 is more important regarding UI decoupling
B: This is important, havent looked into the details, suggestions welcome
C: Think we need to add a description of the responsibilities for the SRV class, something like method SWITCH_REPO_TYPE does not fit there?
D: yeah
E: yeah, just take note of the MV_CODE_INSPECTOR_SUCCESSFUL

BTW, speaking about B, does SET HANDLER ... FOR ALL saves an object from garbage collector ?

garbage collector: not sure
I've not used events very much, the scenario for using events is (IMHO) when the handler is unknown and there might be multiple. In the above case there will always be 1 handler, and we know exactly which class it should be

hmm, its difficult, currently I dont have a suggestion, but I agree that it looks like it should be somewhere else
RUN_CODE_INSPECTOR changes internal state, so moving it to ZCL_ABAPGIT_SERVICES_REPO will require a new method anyhow
Perhaps some of the other methods are easier to begin with,

FIND_REMOTE_DOT_ABAPGIT should be private somehow
GET_UNNECESSARY_LOCAL_OBJS only use public methods, but is called from GIT class, this is a candidate to be moved to ZCL_ABAPGIT_SERVICES_REPO or perhaps some file logic class

I think enough time has passed in order to delete ZCL_ABAPGIT_MIGRATIONS=>REBUILD_LOCAL_CHECKSUMS_161112, this will make it possible to make method GET_LOCAL_CHECKSUMS private,

Some of the methods can be logically grouped together,

DESERIALIZE
DESERIALIZE_CHECKS

and

GET_LOCAL_CHECKSUMS
GET_LOCAL_CHECKSUMS_PER_FILE
REBUILD_LOCAL_CHECKSUMS
UPDATE_LOCAL_CHECKSUMS

perhaps it is possible somehow to extract these groups into a new object/class

Method SET_FILES_REMOTE should not be public IMHO, perhaps IMPORT should be a method on ZCL_ABAPGIT_REPO_OFFLINE

RUN_CODE_INSPECTOR changes internal state, so moving it to ZCL_ABAPGIT_SERVICES_REPO will require a new method anyhow

Yes, some kind of set_ci_status. Imho OK. Alternative is to keep the status in some  ZCL_CI_CACHE? Probably too heavy. Or running CI every time before commit.

GET_UNNECESSARY_LOCAL_OBJS

Semantically it does not look bad, imho

REBUILD_LOCAL_CHECKSUMS_161112

Yeah, can be droped
Agree for the rest (deserialize, checksums, import).
P.S. btw why move SERVICES to UI ? They were intended to be kind of controllers/api layer, e.g. to call them from another "frontend" (at least such was my thought :). Well, they contain some dialogs which is wrong but it is fixable.

SERVICES to UI: all(?) involved popups, so I guessed it was for UI

Considerations:

Delete method HAS_REMOTE_SOURCE, it is typically used in the UI for when there are remote files, already exposed via GET_FILES_REMOTE?
Delete or move checksums feature out of the REPO object
Move RUN_CODE_INSPECTOR method to somewhere else, mv_code_inspector_successful does not have to be part of repo
Delete feature SWITCH_REPO_TYPE #2244
Move STATUS to its own class, currently its just a call to zcl_abapgit_file_status=>status

starting work on PR for RUN_CODE_INSPECTOR

#2216 - a subtask imho

Suggest:
A: delete interface ZIF_ABAPGIT_GIT_OPERATIONS by moving the methods to ZIF_ABAPGIT_REPO_ONLINE, this will make one less moving part
B: method REBUILD_LOCAL_CHECKSUMS in ZCL_ABAPGIT_REPO_ONLINE has a "todo" to unify this into the ZCL_ABAPGIT_REPO method, this will make one less moving part
C: get rid of these 3 places where repos are instantiated,

I hope it sometime will be possible to end with a composition setup instead of inheritance

I'm starting "A" from https://github.com/abapGit/abapGit/issues/2127#issuecomment-732262897

todo:
B: method REBUILD_LOCAL_CHECKSUMS in ZCL_ABAPGIT_REPO_ONLINE has a "todo" to unify this into the ZCL_ABAPGIT_REPO method, this will make one less moving part

todo:
B: method REBUILD_LOCAL_CHECKSUMS in ZCL_ABAPGIT_REPO_ONLINE has a "todo" to unify this into the ZCL_ABAPGIT_REPO method, this will make one less moving part

I will start on this.

I'll remove/refactor these two,

general task todo: look through the code and find places where the repository object is not needed, eg. the /git/ package should not need any references to a repo instance

method ZIF_ABAPGIT_REPO_ONLINE->GET_OBJECTS can be changed to private

@PeregrinTooc are you on Slack? https://abapgit-slackinviter.herokuapp.com/ , let us know a bit more about what you are trying to accomplish? Perhaps there are some easy workarounds

I had a look at ZCL_ABAPGIT_REPO_OFFLINE and there are barely 20 lines of code. There should be just one repo class (with an attribute and a few ifs to distinguish online/offline).
Should we "start over" creating ZIF_ABAPGIT_REPOSITORY and ZCL_ABAPGIT_REPOSITORY on the side?
Maybe there's a way to phase in the new class changing type ref to zcl_abapgit_repo to zcl_abapgit_repository.

Sorry Marc, but I completely disagree. Polymorphism is the way to go, not “a few ifs”.
From: Marc Bernard @.>
Date: Wednesday, 29. September 2021 at 16:51
To: abapGit/abapGit @.>
Cc: Philipp R @.>, Mention @.>
Subject: Re: [abapGit/abapGit] Refactor: make repo classes more focused (#2127)
I had a look at ZCL_ABAPGIT_REPO_OFFLINE and there are barely 20 lines of code. There should be just one repo class (with an attribute and a few ifs to distinguish online/offline).
Should we "start over" creating ZIF_ABAPGIT_REPOSITORY and ZCL_ABAPGIT_REPOSITORY on the side?
Maybe there's a way to phase in the new class changing type ref to zcl_abapgit_repo to zcl_abapgit_repository.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/abapGit/abapGit/issues/2127#issuecomment-930251655, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AN5H6UG4CJ5JROTV2O7GPV3UEMRWBANCNFSM4GFYCJBA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Well, that's a philosophical question. Just because you can use inheritance, does not mean you have to. For me, it's like "red car" and "blue car".

Whenever you have more than one if for the same attribute, it’s polymorphism from my point of view… however, the base class should then be abstract.
I don’t see why having a very small class is a problem?
From: Marc Bernard @.>
Date: Wednesday, 29. September 2021 at 20:13
To: abapGit/abapGit @.>
Cc: Philipp R @.>, Mention @.>
Subject: Re: [abapGit/abapGit] Refactor: make repo classes more focused (#2127)
Well, that's a philosophical question. Just because you can use inheritance, does not mean you have to. For me, it's like "red car" and "blue car".
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/abapGit/abapGit/issues/2127#issuecomment-930424165, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AN5H6UADJUHDRPQM2JMVMBLUENJKZANCNFSM4GFYCJBA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Polymorphism is the way to go...

I'd disagree. Polymorphism makes it very difficult to change the code. It is a very strong coupling. Some even claim that Polymorphism is the worst invention in programming :) I actually tried to break down these classes some time ago (#1757, #2221, #2216) but somehow didn't find support. Also now I think the "connectors" (strategies) are not the best option because offline and online strats do have different abilities. So instead of making repo and macro class, that can adopt different strategies, I'd probably suggest a vice versa approach - repo as a container and several classes around it to manipulate the content (e.g. on/offline connectors). This should decouple the code well.

Hi Alexander,
I think we're having  a misunderstanding between polymorphism and
inheritance here :-) I used polymorphism in the way that the client does
not know which implementation they call, they just know the interface -
however that is defined and implemented is open. Having Composition instead
of inheritance mostly is a good idea, I think...
Regards,
Philipp
Am Sa., 2. Okt. 2021 um 20:32 Uhr schrieb Alexander Tsybulsky <
@.***>:

Polymorphism is the way to go...
I'd disagree. Polymorphism makes it very difficult to change the code. It
is a very strong coupling. Some even claim that Polymorphism is the worst
invention in programming :) I actually tried to break down these classes
some time ago (#1757 https://github.com/abapGit/abapGit/issues/1757,
#2221 https://github.com/abapGit/abapGit/pull/2221, #2216
https://github.com/abapGit/abapGit/issues/2216) but somehow didn't find
support. Also now I think the "connectors" (strategies) are not the best
option because offline and online strats do have different abilities. So
instead of making repo and macro class, that can adopt different
strategies, I'd probably suggest a vice versa approach - repo as a
container and several classes around it to manipulate the content (e.g.
on/offline connectors). This should decouple the code well.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/abapGit/abapGit/issues/2127#issuecomment-932799867,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AN5H6UGOCYWZTKKGNWT5BJ3UE5F47ANCNFSM4GFYCJBA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Agree. Repo is a container. It should not have different capabilities for online vs offline. A repo should hold a reference to a "remote source" (or connector). As of today, we have online and offline (zip) sources. I could imagine "local file system" as another source in the future.
It's a bigger change to do this right: abapGit 2.0 ;-)

continued in #2216


binning=1 Bug

If binning is set to 1 (binning=1), python throws an error. Need to clean this up.

Just had to add one addition if statement


feat: get neuron

Motivation
getNeuron function.
Changes

add and expose getNeuron function as implemented in project ts

LGTM


Changed the default mode for the PlaneRenderer.

PlaneRenderMode.RENDER_ALL was set as the default mode but the doc states clearly that this mode is very expensive. A short check on the Profile verified this statement with 500ms spikes. The default mode is now set to PlaneRenderMode.RENDER_TOP_MOST.

Great found @RGregat !!!
I couldn't figure out why was the last Model Viewer laggy after some planes detected.
We definitely have to move the PlaneVisualizer to kotlin. It can easily be a PlaneNode and ShadowPlaneNode.
@RGregat Would you mind doing it just like in the answer you made there https://github.com/SceneView/sceneview-android/issues/30#issuecomment-1065927190 ?
I think that because glTF is at the end not so consuming comparing to programmatic mesh, maybe it could be a lot cleaner and customizable for users to use a Plane.glb and ShadowPlane.glb choice here.
I don't know if it's an with ARCore polygons @grassydragon ?

It can easily be a PlaneNode and ShadowPlaneNode.

Won't adding and removing many Nodes create a lot of objects for garbage collection?

I don't know if it's an issue with ARCore polygons @grassydragon?

I think we can only generate the polygons at runtime.

Is the topMostPlane actually the top most here?
https://github.com/SceneView/sceneview-android/blob/7ad2ec401649fa45031d84a28140eb58d2dda7e6/arsceneview/src/main/kotlin/io/github/sceneview/ar/scene/PlaneRenderer.kt#L156

Before moving the PlaneVisualizer to Kotlin let's decide what to do with the Renderable and RenderableInstance classes: https://github.com/SceneView/sceneview-android/issues/40

Is the topMostPlane actually the top most here?
https://github.com/SceneView/sceneview-android/blob/7ad2ec401649fa45031d84a28140eb58d2dda7e6/arsceneview/src/main/kotlin/io/github/sceneview/ar/scene/PlaneRenderer.kt#L156

Yes it should
There is definetly something to do to clean this part:
https://github.com/SceneView/sceneview-android/blob/3140b34c66cc6c5306f5e79a978df04013cfdf33/arsceneview/src/main/kotlin/io/github/sceneview/ar/scene/PlaneRenderer.kt#L134-L162

It can easily be a PlaneNode and ShadowPlaneNode.

Won't adding and removing many Nodes create a lot of objects for garbage collection?

You are probably right even if it would bring some great Node features we can use directly here.

I don't know if it's an issue with ARCore polygons @grassydragon?

I think we can only generate the polygons at runtime.

Would you mind doing the move from RenderableDefinittion to Filament direct mesh creation?
I definetly don't feel confortable with the mesh creation.

Before moving the PlaneVisualizer to Kotlin let's decide what to do with the Renderable and RenderableInstance classes: #40

Big subject here even if I'm conviced that most of the Renderable and RenderableInstance with the old sfb managed can be cleaned quite quickly. Resulting in a quite simple class.

Would you mind doing the move from RenderableDefinittion to Filament direct mesh creation?

We just need to make sure that we aren't missing any important features that the Sceneform provided for mesh creation. I actually only used the direct Filament approach.

Is this an example for the filament way to create a mesh? https://github.com/google/filament/blob/main/samples/hellotriangle.cpp

Is this an example for the filament way to create a mesh? https://github.com/google/filament/blob/main/samples/hellotriangle.cpp

This is the C++ version.
In created an Issue for each points of this conversation.
Answer here: https://github.com/SceneView/sceneview-android/issues/43


Add comments functionality

Add ability to take in comment tokens, ignore them, and continue parsing.

Added in commit ae4d09ef9c608f8700741f2fc22f0d5ae3f2f59f


decouple from the narayana parent

@tomjenkinson It is from https://github.com/web-servers/narayana-tomcat/blob/master/tomcat-jta/pom.xml#L33 and I remember that @rsynek change this version maybe related to the JWS 5.

Thanks, feel free to merge


Neo4iService not being injected into the UserNodeModelService

Issue
When calling the run() method on an instance of Neo4jNodeModelService, the internal neo4jService is not being injected correctly and returns undefined which results in the later call to this.neo4jService.run() to fail. Attached are some logs and screenshots for further reference.
Screenshots / Logs

In this image, the first undefined comes from a custom check() function that simply logs the value of this.neo4jService. futher logs are from the this.userNodeModel.run() call which is basically the NodeModelService.run() method.

This is the UserNodeModelService for reference.
Thanks a lot for assistance and for this great project.

Apologies
My bad, I complete ignored the fact that the service needs to be injectable.
Thanks for the project and would love to work on this soon.


Check if directory already exists in graph init when directory is entered

Following walk through:
graph init
 ›   Warning: In next major version, this flag will be removed. By default we will
 ›   stop initializing a Git repository.
✔ Network · Base Mainnet · base · https://base.blockscout.com
✔ Source · Smart Contract · ethereum
✔ Subgraph slug · blonde-subgraph
✔ Directory to create the subgraph in · blonde-subgraph
✔ Contract address · 0x28BC44F9754f590DA1564C1A7bA35F8E1d1B134A
✔ Fetching ABI from contract API...
✔ Fetching start block from contract API...
✔ Fetching contract name from contract API...
✔ Start block · 22855106
✔ Contract name · Blonde
✔ Index contract events as entities (Y/n) · true
✖ Directory already exists, do you want to initialize the subgraph here (files will be overwritten) ? (y/N) · false

n ›   Error: no error?

I'd expect that in step "Directory to create the subgraph in" it would check if that directory exists and give a warning, not at the end.
Also, the "Error: no error?" is a bit a weird ending.

@schmidsi can you think of a use case where you would answer "yes"  to that question?
I think I would prefer to just disallow using existing directory and accept only the one that doesn't exist.


Dashboard Activite´s

Hi, where can I edit the amount of the activities in the Dashboard

It's not configurable through the user interface. It's defined directly in the source code, here: https://github.com/fguillot/kanboard/blob/master/app/Controller/App.php#L61


[BUG] RKE2 cluster in pending state with harvester node driver

Describe the bug
When I was testing the new harvester node driver with rancher 2.6 in this issue, the process failed when the rancher server tried to deploy a RKE2 cluster on top of Harvester.

2 nodes keep pending on "Waiting on probes: calico"
However, all looks good from the cluster (named rke2) view:

I opened a kubectl shell and looked at the pods status, all looks good too:
> kubectl get pods -A
NAMESPACE             NAME                                                              READY   STATUS      RESTARTS   AGE
calico-system         calico-kube-controllers-5f8b57fc77-742vd                          1/1     Running     0          82m
calico-system         calico-node-2hkq6                                                 1/1     Running     0          82m
calico-system         calico-node-l7bwz                                                 1/1     Running     0          78m
calico-system         calico-node-v25gw                                                 1/1     Running     0          76m
calico-system         calico-typha-66b479cdf8-b57mj                                     1/1     Running     0          82m
calico-system         calico-typha-66b479cdf8-nt9xd                                     1/1     Running     1          76m
calico-system         calico-typha-66b479cdf8-xdnkj                                     1/1     Running     1          78m
cattle-fleet-system   fleet-agent-84ccfd47b-6mjn5                                       1/1     Running     0          79m
cattle-system         apply-system-agent-upgrader-on-rke2-pool1-gw6nk-with-3b7f-l5wzm   1/1     Running     0          76m
cattle-system         apply-system-agent-upgrader-on-rke2-pool1-nkjbq-with-3b7f-hg2q8   1/1     Running     0          78m
cattle-system         apply-system-agent-upgrader-on-rke2-pool1-qmtm2-with-3b7f-nrb8b   1/1     Running     0          78m
cattle-system         cattle-cluster-agent-55bbb75957-c92cz                             1/1     Running     0          77m
cattle-system         dashboard-shell-zz8sz                                             2/2     Running     0          48s
cattle-system         system-upgrade-controller-8bbcd68fb-24w2l                         1/1     Running     0          79m
kube-system           etcd-rke2-pool1-gw6nk                                             1/1     Running     0          76m
kube-system           etcd-rke2-pool1-nkjbq                                             1/1     Running     0          77m
kube-system           etcd-rke2-pool1-qmtm2                                             1/1     Running     0          84m
kube-system           helm-install-rke2-calico-crd-fvpw5                                0/1     Completed   0          84m
kube-system           helm-install-rke2-calico-kbf7h                                    0/1     Completed   1          84m
kube-system           helm-install-rke2-coredns-jlcp9                                   0/1     Completed   0          84m
kube-system           helm-install-rke2-ingress-nginx-z5mn8                             0/1     Completed   0          84m
kube-system           helm-install-rke2-kube-proxy-vzcvs                                0/1     Completed   0          84m
kube-system           helm-install-rke2-metrics-server-q9l46                            0/1     Completed   0          84m
kube-system           kube-apiserver-rke2-pool1-gw6nk                                   1/1     Running     0          76m
kube-system           kube-apiserver-rke2-pool1-nkjbq                                   1/1     Running     0          76m
kube-system           kube-apiserver-rke2-pool1-qmtm2                                   1/1     Running     0          84m
kube-system           kube-controller-manager-rke2-pool1-gw6nk                          1/1     Running     0          76m
kube-system           kube-controller-manager-rke2-pool1-nkjbq                          1/1     Running     0          77m
kube-system           kube-controller-manager-rke2-pool1-qmtm2                          1/1     Running     0          84m
kube-system           kube-proxy-r27b6                                                  1/1     Running     0          78m
kube-system           kube-proxy-tx5fd                                                  1/1     Running     0          76m
kube-system           kube-proxy-vxqff                                                  1/1     Running     0          83m
kube-system           kube-scheduler-rke2-pool1-gw6nk                                   1/1     Running     0          76m
kube-system           kube-scheduler-rke2-pool1-nkjbq                                   1/1     Running     0          77m
kube-system           kube-scheduler-rke2-pool1-qmtm2                                   1/1     Running     0          84m
kube-system           rke2-coredns-rke2-coredns-65d668ddf9-g89rh                        1/1     Running     0          83m
kube-system           rke2-ingress-nginx-controller-8gwkl                               1/1     Running     0          80m
kube-system           rke2-ingress-nginx-controller-pxhqz                               1/1     Running     0          76m
kube-system           rke2-ingress-nginx-controller-vfq6s                               1/1     Running     0          75m
kube-system           rke2-metrics-server-6647ffc866-89wx4                              1/1     Running     0          81m
tigera-operator       tigera-operator-db8446457-btmqs                                   1/1     Running     0          83m

To Reproduce
Steps to reproduce the behavior:

launch a new rancher server using the master-head image https://rancher.com/docs/rancher/v2.x/en/quick-start-guide/deployment/quickstart-manual-setup/#2-install-rancher
importing the downstream Harvester cluster(use master-head ISO) to the rancher server through the rancher dashboard UI

ClickImport Existing and choose Generic
fill in an arbitrary cluster name and click Create
wait a few seconds(and refresh the page), you will see a Registration tab on the cluster detail page
copy the registration command(The second curl --insecure ...|kubectl apply, basically it is for deploying the agent to the downstream harvester cluster), run it against the harvester cluster
wait a few seconds and the harvester cluster should be imported and managed by the external Rancher.

Go to the global settings via the hamburger menu and replace the rancher ui-index and ui-dashboard-index respectively (Note: this is not required for the official Rancher 2.6 release, currently the dashboard UI PR is not merged yet)

ui-index: https://rancher-harvester.s3.ap-southeast-1.amazonaws.com/harvester-node-driver/latest2/index.html
ui-dashboard-index:  https://rancher-harvester.s3.ap-southeast-1.amazonaws.com/harvester-node-driver/harvester-node-driver/index.html

verify the user is able to spin up the guest k8s cluster with Harvester node driver with RKE2.

select create Harvester cluster and add a cloud credential by choosing one of the imported Harvester clusters.

config the VM instance options(only cloud image is supported, and VLAN network is required), u specify the k8s config or you can add more node-pools if needed.

Click create to spin up the guest k8s cluster and check the status, it should stay in the provisioning state.

Expected behavior
The cluster should be ready as well as all the nodes.
Support bundle
harvester-supportbundle_54a7b4d6-cc17-44c6-9fb4-c7d5f2ed53bd_2021-07-20T12-25-55Z.zip
Environment:

Harvester ISO version: master-bc40fc79-head
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): 5 nodes cluster DL360G9

Additional context
Add any other context about the problem here.

Today, I've tried to reproduce the issue to give more logs but this time, all worked as expected.
The 3 nodes RKE2 cluster is up and running as well as all the pods.

RKE2 is not marked as GA yet and that's part of the Rancher dependency, let's investigate if this can be stably reproduced, otherwise feel free to close it (let's get more env to test this to see if we can reproduce it).

I did a second try and everything worked well again.


chore: Revert banner for Kong Gateway user survey

This reverts commit d53fbc1287d6af0e5bd4ca0e3a2404f38cb6bd99.
Description

Testing instructions
Preview link:
Checklist

[x] Review label added
[ ] Conditional version tags added, if applicable.

Closing in favor of https://github.com/Kong/docs.konghq.com/pull/7401, as we can't do a straight revert here.


Does this library restrict the version of Django?

I added django_multitenant to the requirements.txt on an existing Django 1.11 project. However running pip install -r requirements.txt then uninstalls Django and downgrades it to 1.10:
Installing collected packages: Django, django-multitenant
  Found existing installation: Django 1.11
    Uninstalling Django-1.11:
      Successfully uninstalled Django-1.11
  Running setup.py install for django-multitenant ... done
Successfully installed Django-1.10 django-multitenant-0.3

Not sure if the dependencies of this library caused that to happen, and recording an issue just in case.

@jasonmp85 Any thoughts on why the above is happening.  Could it be because of the find_packages() in the setup.py

Gah, I swore we debugged and figured this out a while back; I don't remember anymore, though…

Hey @begriffs, just FYI, I tested this with the latest library release and couldn't reproduce this issue.
#Did this with django 1.11 already installed.
pip install django-multitenant
Collecting django-multitenant
Installing collected packages: django-multitenant
Successfully installed django-multitenant-1.0.1

Could it be because of your apps requirements.txt rather than the django-multitenant library restricting the django version?

Tested and hence closing the issue.


refactor: Rename ActorContext create

          The name for this method seems to be outdated. Also, is `ActorContext::create` only supposed to be used by tests?

Originally posted by @BugenZhao in https://github.com/risingwavelabs/risingwave/pull/14655#discussion_r1462695084

Maybe we can rename the create to for_test and rename the create_with_metrics to create in the future.


native plugin multiproject build failing to find dependencies from rootdir to subdir

When using the native plugin to build native multiproject builds it seems i need to have both current module and submodule atleast one level down in hieracy.
(think the tree like this:) Layout A
. ModuleB (rootDir)
├── build.gradle
├── inc
├── settings.gradle
├── src
└── submodules
    └── ModuleC (git cloned)
        ├── build.gradle
        ├── inc
        ├── settings.gradle
        └── src

now i set ModuleC with correct path in settings.gradle
include 'ModuleC'
project(':ModuleC').projectDir = new File('submodules/ModuleC')

Layout A - gradle build (even though gradle finds all the build.gradle files will get a dependency failed error, cant find the library it just read the build.gradle file for...
if i put the layout like this (half stolen from your example native multiproject)
Layout B
. (rootDir)
├── build.gradle (dummy with allprojects to redirect build output)
├── settings.gradle (includes both subprojects)
└── submodules
    ├── ModuleB (this module is the one this "repo" is handling)
    │   ├── build.gradle
    │   ├── inc
    │   ├── settings.gradle
    │   └── src
    └── ModuleC (git cloned dependency)
        ├── build.gradle
        ├── inc
        ├── settings.gradle
        └── src

settings.gradle:
include 'ModuleB'
project(':ModuleB').projectDir = new File('submodules/ModuleB')
include 'ModuleC'
project(':ModuleC').projectDir = new File('submodules/ModuleC')

Layout B builds just fine with gradle build..
is this something we will get fixed or do i have to learn to live with it?
the fact that it works this way, makes it possible with just one skeleton instead of three (top, middle, bottom) which would mess stuff up if the bottom becomes a middle..
o well maybe not the biggest problem in the world, but after debugging the same error a few times and comming to the conclusion its allways the layout thats the problem...
well i guess soon i have changed all the submodules layouts so its a non problem until i make a new project and fall back on the waggon..
Expected Behavior

Current Behavior

Context

Steps to Reproduce (for bugs)

Your Environment

Build scan URL:

we can close this as i'm probably blind..
works just fine it was a typo i settings.gradle that made it not work..


pallet-mmr: could not prune: no entry in pruning map for block

Could not canonicalize elem at pos 73901 using key [12, 109, 109, 114, 173, 32, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]

I'm see a lot of these errors on Versi nodes after upgrading to a PR in which I merged recent master.
CC @acatangiu

thanks for the report! this is being already tracked in https://github.com/paritytech/substrate/issues/12531 (and will come in with https://github.com/paritytech/substrate/issues/12508)


Provide better documentation for API?

I can't seem to, no matter how hard I dig inside of the files, find what data I need to send to the websocket. Such as the parameters to record (what do I even send with it?). Can we get some documentation?

Nevermind, after a little more looking around, I did manage to find the solutions in the original websocket source. Mark this issue as closed, I'm so embarassed.

No worries, I'll update the readme to have a prominent link to that.
https://github.com/Palakis/obs-websocket/blob/master/docs/generated/protocol.md


Short assistance: Error received :"Could not create TestRail run for project P10: 0 No response from TestRail >> No response from TestRail"

Done the "cypress-testrail" install and config with my testrail credentials and map the proper testcase in order to have results posted in testrail.
Cypress version: 11.2.0

It seems that the projectID is not read.
This is my cypress.config.js

Do I need to put the config into e2e.js?
I cannot figure out what I am doing wrong!
Thanks in advanced,
Casian

Hi
thank you for reporting this
so yesterday there was a release for a better error output (because there was an unknown error from the API where the integration crashed).
I did add that generic error in that case
so according to your screenshot of the terminal, the project ID is read
either there is a bug in the integration with the new version (but very unlikely...because an error happens...and only this way has been adjusted)....OR your user might not have permissions to create runs....that could also be the error I was looking for
there is an easy way to figure this out
can you log the error in lin 156 from here? https://github.com/boxblinkracer/cypress-testrail/blob/master/src/components/TestRail/ApiClient.js
i think console.log isnt working in the terminal with RUN, but a "throw error" should work..i think thats how i debugged it.
and maybe we get a permissions denied error there
let me know what happens,
would love to figure out this problem
thanks

Hi
thank you for reporting this so yesterday there was a release for a better error output (because there was an unknown error from the API where the integration crashed). I did add that generic error in that case
so according to your screenshot of the terminal, the project ID is read
either there is a bug in the integration with the new version (but very unlikely...because an error happens...and only this way has been adjusted)....OR your user might not have permissions to create runs....that could also be the error I was looking for
there is an easy way to figure this out
can you log the error in lin 156 from here? https://github.com/boxblinkracer/cypress-testrail/blob/master/src/components/TestRail/ApiClient.js
i think console.log isnt working in the terminal with RUN, but a "throw error" should work..i think thats how i debugged it. and maybe we get a permissions denied error there
let me know what happens, would love to figure out this problem
thanks

Hi Christian,
Thanks for your response , I will take a look , but I am using my account into another project ruby with selenium and testrail integration and on that project I can send the report to testrail after test spec run.

Hi
thank you for reporting this so yesterday there was a release for a better error output (because there was an unknown error from the API where the integration crashed). I did add that generic error in that case
so according to your screenshot of the terminal, the project ID is read
either there is a bug in the integration with the new version (but very unlikely...because an error happens...and only this way has been adjusted)....OR your user might not have permissions to create runs....that could also be the error I was looking for
there is an easy way to figure this out
can you log the error in lin 156 from here? https://github.com/boxblinkracer/cypress-testrail/blob/master/src/components/TestRail/ApiClient.js
i think console.log isnt working in the terminal with RUN, but a "throw error" should work..i think thats how i debugged it. and maybe we get a permissions denied error there
let me know what happens, would love to figure out this problem
thanks

Hi Christian, Thanks for your response , I will take a look , but I am using my account into another project ruby with selenium and testrail integration and on that project I can send the report to testrail after test spec run.

So I check via postman my user role so here what i got:
"role": "Tester"
Via debug where you have mentioned i add the console.error(apiError) and the results are:
ApiError {
_statusCode: 0,
_statusText: 'No response from TestRail',
_errorText: 'No response from TestRail'
}

Hi
so i've also double checked in the meantime
and the new version still works for me.
I guess its indeed a permission thing (would need to re-run my tests, but i'm a bit busy the next days)
so adding results is indeed a tester thing.....but creating runs requires different permissions.
what I see in your images is, that you have the "create test run mode", which would first create a new run, and then add results to it.
this is why i really think its a thing with your role.
can you try it with more privileges just to see if it works?

I think this will be a problem on my side in order to request more permission on testrail, I will need to make some request to the IT side.
Do you think it will be possible to adapt the code in order even a user with role "Tester" to be able to add the results in testrail?

Hi
no thats not possible. I dont even expect or consider role "Tester".
role "Tester" is nothing but a default role in TestRail...you could just rename it to "abc".
what is important is the checkboxes inside that role "xyz"....(screenshot above)...it needs to have the create and update Test Runs privilege so that the API allows such a thing for a user.
so nothing one (or I) could do in a client, just casual ACL in an API on the API side
I hope this explains it :)
but please let me know if it was really a matter of permissions in the end

Hi there
ask them to send you the permissions of that role and not just the name of the role.
like in the screenshot above :) thank you

Do you have admin role on your user? because they provide me on project as you suggested from above picture and as testrail user

i have an admin, but its also working on non-admin users.
so what is important as far as it makes sense to me is the permission "add/edit runs and plans"
because that allows to create runs and plans which is done with the mode you are using.
if you e.g. would also use the "close" mode, to also automatically close runs from cypress, then that additional permission is also required in TestRail

I have manage to receive a print screen with my entire user roles but it seems on my side still not working

I run a debug from src/components/TestRail/ApiClient.js and you can find in the attachments the logs @boxblinkracer
log_error_from_testrail_apiClient.txt

Hi there
you already got email from me
but thanks for this
I think you accidentally provided the https in the config :)
it cannot connect to this one
url: 'https://https://xxx.testrail.net/index.php?/api/v2/add_run/10',

so double https
if that is the case, just let me know and I'll also add a "check" inside the client to remove it automatically

Hi,
From what I saw if I take out the https from domain like in the picture
below, then in the debug the url is with only one https, but then I receive
the (Could not add TestRail test cases to run R: 401 Unauthorized >>
Authentication failed: invalid or missing user/password or session cookie)
[image: image.png]
maybe we can schedule a short zoom call If it possible in order to see
exactly what is happening.
Thanks,
Casian
On Tue, Dec 20, 2022 at 1:41 PM Christian @.***> wrote:

Hi there
you already got email from me
but thanks for this
I think you accidentally provided the https in the config :)
it cannot connect to this one
url: 'https://https://xxx.testrail.net/index.php?/api/v2/add_run/10',
so double https
if that is the case, just let me know and I'll also add a "check" inside
the client to remove it automatically
—
Reply to this email directly, view it on GitHub
https://github.com/boxblinkracer/cypress-testrail/issues/10#issuecomment-1359235687,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEZGS5BU26U53Y73BYSLFWTWOGLPVANCNFSM6AAAAAASXPKZY4
.
You are receiving this because you authored the thread.Message ID:
@.***>

I took out the https from the domain and now it seems that the url has only one https:

now the authentication is working properly after the above step, but it seems that the suite_id is a require field

hi there
ok good to hear perfect (with the connection itself)
aehm suite_id is required? thats from the API itself
so besides this, your screenshot looks wrong, plan_id doesnt even exist.. please see the README (just to let you know...also not rund_id but runId)
because you wrote rund_id and not runId, the integration tries to create a new run in TestRail (which you wanted anyway)
according to the TestRail API, https://support.gurock.com/hc/en-us/articles/7077874763156-Runs#addrun
this suite_id is optional...except if you have a project operating in non-single suite mode :)
so this means the integration cannot yet handle it, and I need to add it
i guess you cannot change the project for now until I have it ready, right?
but besides this, it finally seems to be working technically :)

Yes I saw that I put the wrong one :) and yes I cannot change the project because it's an old one and yeah....
Finally after long try's with user roles and so on I have something that will work after you will add the suiteId.
Thank you very much for your time and  support!
Best regards,
Casian

Hi @colcherica
i've just added the suiteId parameter
i have to be honest, i havent tested it myself in TestRail yet..but it's plain forward as with the milestoneId, so I'm quite sure its working.
this means, you could already test the dev-master, and I think it works
before the official release, I would of course test it myself...but probably after the holidays...just taking a bit time off to relax :)

Great news then :), until the official release Merry Christmas and Happy New Year.
Thanks for the updates.

:)
thank you
also to you Merry Christmas and a Happy new year :)


Update Golang version to 1.17

PR summary

Fixes: #242
Note: An existing issue is required before opening a PR.
PR Checklist
Please make sure that your PR fulfills the following requirements:

[x] The commit message follows the
Angular Commit Message Guidelines.
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] New tests
[x] Build/CI related changes
[ ] Documentation content changes
[ ] Other (please describe)

What is the current behavior?
Golang minimum version is 1.16

What is the new behavior?
Update minimum supported Golang version to 1.17

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Technically this works, but let's wait with merging till 1.18 officially released https://tip.golang.org/doc/go1.18


Add more workload and infrastructure metrics

/kind enhancement
What happened:
We should expose more workload and infrastructure metric in order to detect infrastructure problems earlier.
What you expected to happen:
Ability to detect infrastructure issues issues
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:

Implement a metric for virtual machine instance migration convergence time - A Migration metric, to track how long it takes for a virtual machine instance to migarte.
Implement metric to expose VMI phases
Implement a metric for number of virtual machine failures -
Implement virtual machine instance age metric - A VMI metric, providing a number (seconds?) reflecting the runtime/age of the VMI

Hello ! I would like to take up this issue. Please provide me some pointers on where and how to start 😊

Hi @danielBelenky @fabiand
I am Animesh Kumar a junior year student at NITK, Surathkal, India.
Thank you so much for providing this project idea. I would be interested in working on this as a part of Community Bridge.
Since the tool is new to me I am currently exploring the demo. Please help me in getting started with this idea. Also, if possible point me to some suitable issues which can help me in understanding the work and the code-base.
Let me know if you prefer some other medium of communication(e.g slack, irc, mail) with respect to this discussion.

@xprxprx   I have applied on community bridge and messaged you on slack for more information. You can check my portfolio here at https://dhiraj240.github.io/


Workarounds for "unsupported features" experiments

Description of changes:
Commits a couple of workarounds for the "unsupported features" experiment that I've had to use for some weeks now:

Use /tmp/remote-repos as the work directory (to avoid #1890)
Use --legacy-linker so the results aren't empty.

Testing:

How is this change tested? Manually, running the experiment.

Is this a refactor change? No.

Checklist

[x] Each commit message has a non-empty body, explaining why the change was made
[ ] Methods or procedures are documented
[ ] Regression or unit tests are included, or existing tests cover the modified code
[ ] My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

Hopefully we can start using cargo-kani asses soon. Do we have an issue tracking what is missing for that?

#1819 if I'm not mistaken.


Support skip comment markup like # noqa

Awesome, extremely useful project, thank you!! (Just noticed I'm signed in using a GH account I created strictly for teaching purposes .. doh! My normal handle is @gavinhuttley).
Describe the feature you'd like
I have cases where we use decorators to extend docstrings from other methods / classes, etc.. Rather than try to catch such a special case, perhaps adding support for a comment annotation (like # noqa, as used by linters) that indicates a method / function to be ignored?
Is your feature request related to a problem?
Only in that methods documented in this way are not recognised as such.
Your Environment

interrogate version(s) (interrogate --version): 1.2.0
Operating System(s): All
Python version(s): 3.6+

Additional context
None.

hey @profgav (cc @gavinhuttley) - I definitely like this idea. In investigating this idea, it seems like this is will take a bit of work. interrogate just uses the ast which doesn't include comments, so I'll have to tokenize source files (and then have the joy of aligning tokenized files with ast parsed files 😆 ). I'll try to slate this for 1.4.0 release.
Thanks for the idea!

If no one is working on it I can try my hands around it. @econchick 😃

@Pradhvan 💯! this issue is yours if you want it! Very much appreciated - thank you!

Great! I Will try my best 🙌🏾

I tried going through the code base but felt a bit overwhelmed. @econchick if it's not too much of a trouble, can you give out some pointers on where to start and what would be have been your approach. Even as small as a tl'dr type short text would help a lot.

Hey @Pradhvan, sure!
So interrogate uses the ast library in stdlib (in src/interrogate/visit.py). It uses ast to traverse a code base, (via visit_<Noun>Def methods), and with each object we care about (classes, methods/functions, modules, etc), we call get_docstring to see if the object we care about has a docstring.
The idea for this PR is to be able to comment on an object for interrogate to ignore, something like:
def my_undocumented_function():  # nodocqa
    return "foo"

However, the ast library doesn't include/preserve comments, so there's no way to detect that # nodocqa comment for an object (see stack overflow post). So in order to do this, we have to either (1) add another library to find those comments to use in conjunction with how we traverse a code base using ast, or (2) replace our use ast with another library (not sure what exists out there) that does all that we want. Both sound like a bit of an undertaking 😬
The aforementioned stack overflow post has answers suggesting the use of the tokenize library in the stdlib along with ast, so I might start to figure out when to use ast and when to use tokenize; for instance, when the ast visitor visits a class, would it be easiest to tokenize it and find someway to see if there's a nodocqa comment? Or maybe we have to tokenize an entire file/module (looks like it, as we do with ast parsing), so how do we zip the results together?
We could also take a look at how black handles comments, since it supports # fmt: off / # fmt: skip/# fmt: off. Or how coverage supports # pragma: no cover and flake8 with # noqa - do they use tokenize? something else?
In general, I'm not exactly sure how to approach this without digging further. It seems like changes would need to be in src/interrogate/visit.py somewhere, with an additional library (stdlib or otherwise) to help pull out comments.
Once something is implemented, I would then time it against the code base itself, maybe the test fixtures, and other code bases I have access to (i.e. whatever's local). I would be very cautious because we wouldn't want to add too much more overhead and take a performance hit since there's a possibility that there can be a lot of duplicate processing. Something like +15% longer may be fine, but not like 100% longer for interrogate to run against a code base.
Hope this helps!

@econchick thank you for the detailed explanation. This definitely helped make more sense of what I need to do. 🙌🏾

FYI, in case this is still open for input, pdoc3 uses the special variable __pdoc__ instead of comments.

Is there any workaround related to this? Whilst waiting for @override support, we need to skip several methods so they don't get counted


Add basic art information search functionality

This adds the !art command which can either be used without any parameters to get a full list of all the art pieces, or with parameters to get information about how to distinguish fakes.

Codecov Report

Merging #92 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
+ Coverage   99.56%   99.57%   +0.01%
==========================================
  Files           1        1
  Lines         691      712      +21
  Branches      133      138       +5
==========================================
+ Hits          688      709      +21
  Misses          1        1
  Partials        2        2

Impacted Files
Coverage Δ

turbot/__init__.py
99.57% <100.00%> (+0.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb3dd91...155ff03. Read the comment docs.


[Bug] Tizen Sample App is giving a warning when loaded

Description
I got a message from someone stating that the warning that the Tizen sample could not be loaded is big and scary for people just starting to look into it. I never thought about it that way and just mindlessly closing it, but I can totally see their point. I've never seen this warning on the Forms repo, so I guess there is a way around this?
Steps to Reproduce

Clone this repo
Open the Sample solution
A warning is shown Tizen project could not be loaded

Expected Behavior
No warning, project is simply not loaded
Actual Behavior
Big scary warning that might scare new-ish ccontributors or people looking into this

@jfversluis Looks like it is fixed. I updated sdk version.

@jfversluis I don't see any messages on VS for Mac. Can you please confirm that you don't see it on Win?

Seems gone for now! Thanks!


Lwjgl3 FPS oddities

Issue Details
I'm using the LWJGL3 backend.
Previously, when using the LWJGL2 backend, I experienced similar experiences to #1386  and #3405. However, when in fullscreen, these issues would go away and I'd have a beautiful, smooth game. This was a constant bug over the course of time.
One of the above issues suggests moving to the LWJGL 3 backend. So I did, and have been testing it over the past week.
Instead of the odd stuttering, this time around I have FPS / delta time that goes wild, and stays below 60fps, even though my computer (a recent, expensive gaming laptop) is more than capable of hitting 60 fps. It's not only my game doing this, though, it seems all the LWJGL3 games running on my machine experience the same issue. HOWEVER, once again, in fullscreen, the issue doesn't exist at all, for all the games I've tried.
Here's an interesting gif showing some stats
https://i.imgur.com/9y9e1ZT.gifv
And another of someone else's game in LWJGL3 (same game in lwjgl2 gets smooth 60fps)
https://i.imgur.com/ftbOJ1R.gifv
Here is another of a LWJGL2 game, which shows the normal, expected behaviour
https://i.imgur.com/U0QzL5t.gifv
Here's a paste of a bit of deltaTime printout to show the variation
https://pastebin.com/tcxvSt5k
And heres the same printing out of deltaTime in fullscreen:
https://pastebin.com/eFiF3J51
When in fullscreen with vsync disabled and fps unlimited, I get over 2400 FPS, which is just something to show that my machine is more than capable of 60fps windowed.
We have tried vsync on, vsync off, Display.sync stuff from lwjgl2, manually setting vsync, profiling, and other countless efforts.
Is there any information you could possibly supply me on this topic?
Expected results
A smooth, consistent FPS in the range of 58-62
Version of LibGDX
1.9.11-SNAPSHOT, LWJGL3 backend
Platforms tested on
Windows
Yes i have the latest drivers.

I want to add that @Ktar5 had found there's a sharp framerate difference between LWJGL2 and LWJGL3 on their machine when running my game/demo CaveCops, with no code changes other than adding a desktop/LWJGL2 module (core is unchanged). Even on integrated graphics, CaveCops can get over 200 FPS, so the LWJGL3 code running at 54 FPS on a high-end gaming machine is concerning to me. I think @Ktar5 can test with vsync enabled on a machine with a 144Hz monitor; if that goes from 144 FPS on LWJGL2 to 54FPS on LWJGL3, that sounds like a significant bug.

In response to @tommyettinger I have tested before on my 144hz monitor and got fps ranging from 80-130 so it seems like a very interesting bug that could be going on

possible duplicate of #4274

There is a possibility that the root cause could be the same as #4274 but I believe that my issue is a more focused and accurate description of a single bug, whereas the aforementioned issue seems to talk about fullscreen vsync issues, multi-window issues, and fps issues, whereas I am experiencing single-window fps issues (seemingly) regardless of vsync enabling or disabling and only in windowed mode.

It seems now that this bug only happens when I activate my second monitor and move the window onto that second, external monitor.

Can confirm that this is not a problem with LibGDX but with LWJGL3, I'll continue to post updates here as I learn more.
Here's a gif of a strictly LWJGL3 game running poorly with vsync enabled. https://i.imgur.com/J7hJq8n.gifv

@Ktar5 interestingly this did not seem to resolve the issue for me. I'll give it a more diligent try/test over the weekend.


RuntimeNullables breaks source link

Stepping into source code of libraries that use source link and RuntimeNullables does not work.

Can you please elaborate with a complete description of the configuration and relationship between the various projects and packages?

Is it something like this:

LibraryProject: references RuntimeNullables and  Source Link, creates a nuget package
AppProject: references LibraryProject nuget package and stepping into source no longer works here?

Is it something like this:

LibraryProject: references RuntimeNullables and  Source Link nuget packages, creates a library nuget package
AppProject: references LibraryProject nuget package and stepping into LibraryProject source no longer works here?

yes

I'll have a look shortly and let you know. Thanks for the report!

What are the target frameworks for the library and app projects?

net461 and netstandard2.0

Is that page coming up anytime you try to step into any source code at all or only when it attempts to break at an exception thrown by RuntimeNullables?

Is the repo with the app where this is happening public so I can clone it and debug?

The repo is openmod/openmod. You can reference OpenMod.Core from a project via NuGet. Keep in mind that you need to use the 3.0.0 pre-release version.

This was a tricky one. Closed via https://github.com/Singulink/RuntimeNullables/commit/7c33cc98a8023a40c0d5736e7a730b3474859824
Posting v0.9.8 to nuget now, give it a try and let me know if you have any more issues but it should be fixed.


Add support for prepending or appending Webpack plugins

I was having issues when converting from react-app-rewired to craco due to previously our changes / additions to the Webpack config would append plugins, but adding plugins in craco always prepends them.
This caused an issue where HTMLWebpackPlugin would not work as expected due to the ordering, and in webpack the plugin order does matter
This introduces an API change while preserving the existing behaviour too if desired (and by default).
The change allows you to pass in an array containing a plugin and a string to specify prepend or append.
Updated the docs I could see, and added tests to test the changes with the legacy behaviour.
Happy to hear any thoughts or make any changes.

Hi @Codex-
Thansk for the PR. It looks good to me.
@alexasselin008 I think we talked about something like this a while ago? I would like your input on this, what do you think about adding this feature to CRACO?

At the time, we decided that the webpack.configure method was sufficient if we wanted to preprend plugins.
Now that its here i don't really mind.

Yeah currently I'm using the configure method to achieve this, feels a bit clunky though as it only contains the plugins that need to be appended versus the default method of adding plugins that prepend.

Sounds good, merging, thanks!
I will release the package tonight.

Released in<EMAIL_ADDRESS>

Awesome, thank you!


Universal zk-VM circuit & instance data

Make Valida into a universal zk-VM circuit by making the following changes:

Program goes in the main trace of the program chip, not the preprocessed trace
Program and static data are exposed as part of the instance data

I'm noting that it doesn't appear that Valida has any notion of instance data currently. We'll need to implement instance data and include in the instance data the contents of the input tape, the output tape, and the program.

Here are my current thoughts on instance data. I'm basing my answer on the way that instance data works in PLONK.
In PLONK, you let T(x) be the trace polynomial and v(x) the instance data polynomial, and you let the domain of the instance data be {ω^(-i) | i ∈ {0, ..., |I|}}, where |I| is the size of the instance data and ω is the generator of the domain of the trace polynomial. You use a zero test to check that T(x) - v(x) vanishes on the domain of the instance data.
In Valida, the traces are row major matrices, which means that values in the same row are close together. This means we can't just group all of the instance data at the end of the trace domain like we do in PLONK. What I'm proposing a slight generalization of the PLONK solution to instance data which accounts for the instance data being non-consecutive in the trace domain.
Here's what I'm proposing. Let D be the domain of the instance data: a subset of the domain of the main trace. Let I(x) be the zerofier polynomial of D, the lowest degree polynomial which vanishes on D and is non-zero everywhere else. Let T(x) be the main trace polynomial. Let v(x) be the instance data polynomial. Use a zero test to verify that I(x) * (P(x) - S(x)) vanishes over the main trace domain.


google oauth redirect_uri_mismatch

When running from local, log in normally.
but when deploy on eks then got error 400 redirect_uri_mismatch
my container endpoint is...
EXPOSE 8000

ENTRYPOINT ["chainlit", "run", "app.py", "--host", "<IP_ADDRESS>", "-d"]

#app.py , chainlit  version is 1.1.306
@cl.oauth_callback
def oauth_callback(
  provider_id: str,
  token: str,
  raw_user_data: Dict[str, str],
  default_user: cl.User,
) -> Optional[cl.User]:
  print("In callback ")
  return default_user

env in pod ....
$ env
CHAINLIT_URL=https://mydomain
OAUTH_GOOGLE_CLIENT_ID=my_id
OAUTH_GOOGLE_CLIENT_SECRET=my_secret
CHAINLIT_AUTH_SECRET=xxx

I've done the gcp auth setup countless times include streamlit apps, so I'm pretty sure it's error free.
aprroved redirect url list...

http://localhost:8000/auth/oauth/google/callback
https://mydomain/auth/oauth/google/callback

logs in pod
INFO:     <IP_ADDRESS>:24014 - "GET / HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:24002 - "GET /auth/config HTTP/1.1" 200 OK
2024-07-23 09:05:30 - Translation file for ko not found. Using default translation en-US.
INFO:     <IP_ADDRESS>:46458 - "GET /project/translations?language=ko HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:24002 - "GET /login HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:24002 - "GET /auth/oauth/google HTTP/1.1" 307 Temporary Redirect
INFO:     <IP_ADDRESS>:24002 - "GET /auth/oauth/google HTTP/1.1" 307 Temporary Redirect
INFO:     <IP_ADDRESS>:24002 - "GET /auth/oauth/google HTTP/1.1" 307 Temporary Redirect
INFO:     <IP_ADDRESS>:33444 - "GET / HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:34620 - "GET / HTTP/1.1" 200 OK

How can I fix this?

provisioning logs is
INFO:     Started server process [1]
INFO:     Waiting for application startup.
2024-07-24 01:14:10 - Your app is available at http://localhost:8000
INFO:     Application startup complete.
INFO:     Uvicorn running on http://<IP_ADDRESS>:8000 (Press CTRL+C to quit)
INFO:     <IP_ADDRESS>:37134 - "GET / HTTP/1.1" 200 OK

Could this be the problem?
http://localhost:8000

i've changed oauth url https to http in Google Oauth App.
http://mydomain/
http://mydoamin/auth/oauth/google/callback
then worked...
(when i access to https://mydoamin/, then redirect to login normallly using https.)
to be sure, i remove https domain in Google Oauth
so weird...


Offline tests

Would be possible to have a cut down version of the test suite which uses offline data.
I'm packaging this for openSUSE https://build.opensuse.org/package/show/home:jayvdb:ros/python-vcstool , and the rpm build environment is isolated from the internet.
I can add tarballs of other repos from the tests repo.list to the build environment, and manually import them.
Ideally the test runner would recognise that the repo is already imported, and not try to update it, and then run the tests.

I am not sure how valuable a cut down version of the test suite would be? I would guess a reduced set will inevitably reduce coverage.
Please feel free to propose patches which would help with your use case. The only precondition I would have is that it shouldn't negatively affect the tests when run through the current CI as well as locally for a developer.

@jayvdb Are you interested to work on this? If yes, I am happy to keep this ticket open.

My plate is extremely full, especially at the moment due to GSoC duties, so I can not commit to doing it in the near future, but it does need to get done for distro packaging.  It is also blocking packaging of the tools which use vcstool as a dependency, generally the "future" ROS toolkit being developed.  As this package rises in importance, the need for this will increase, and people willing and able to do it also increases.
The proposed changes would not alter the existing CI.  They would only add support for the existing test suite to work correctly in distro packaging isolated VM environments, provided a limited smoke test.  Without it, distro packages bitrot because the packaging is not maintained, e.g. dependency changes are not noticed during version bumps.

@jayvdb Friendly ping.

Agreed. I'm trying to make tests for https://github.com/dirk-thomas/vcstool/pull/123 without adding remote web requests. I think this can be done by simply spinning up a http.server.HTTPServer on localhost in a parallel thread.

I am going to close this ticket since I don't plan to spend any time on this.
If someone would like to contribute a pull request I am more than happy to review it.


Ingest FAO 2024 data

There appeared to be missing species with the data test run during the close out meeting with Rahul. However, it appears this was run with the 2023 release, not the 2024 release.
Note: There have been updates to Fishbase and Sealife base (e.g., to some scientific names and common names), so we will want these integrated as part of the new run.

Mostly all in clean_inpusts portion of the model. Fairly sure new HS code list comes from API subscription from Comtrade
To-do
UN Comtrade

[ ] @jagephart create new Comtrade API account with new email

FAO Data

[ ]  column names make sense in new data
[ ] See ways to structure code (separate script) to run on new FAO data. Look for differences between old and new raw data. e.g. column name matching, species dropped, species added, countries dropped, countries added. Create summary of what is different before going into code to modify.
[ ] make sure all scinames are matching to hs codes and all hs codes have scinames matching

Sciname

[ ] list of scientific names get appropriately cleaned and matched to SLB FLB and HS6

2024-12-16 Update & Questions

[ ] Why is are these species being corrected here? https://github.com/Seafood-Globalization-Lab/artis-model/blob/045adecdcbfa06b7a738e29e0383e6d2c78648ab/01-clean-input-data.R#L67C1-L76C5

2024-12-18 Comments & Questions

@jagephart In testing 01-clean-input-data.R with the new rebuild_fao_2024() function. Does this chunk of column renaming and cleaning belong in classify_prod_dat() or the rebuild_fao_2024() function run just before that restructures the FAO data? https://github.com/Seafood-Globalization-Lab/artis-model/blob/079bc38e38da43eb8ba48a72a2f4104b26ff913f/R/classify_prod_dat.R#L26


Is reactnavigation.org down?

Can't seem to access the site using my Surface or Mac?

It's working now

down


Constructing a string from a large XML literal throws "RangeError: Maximum call stack size exceeded"

The error:

hni-annotate-fastopt.js:10127 Uncaught RangeError: Maximum call stack size exceeded
at new $c_sc_Iterator$ConcatIterator (hni-annotate-fastopt.js:10127)
at $f_sc_Iterator__$$plus$plus__F0__sc_Iterator (hni-annotate-fastopt.js:7250)
at $f_s_xml_MetaData__iterator__sc_Iterator (hni-annotate-fastopt.js:18386)
at $c_s_xml_UnprefixedAttribute.foreach__F1__V (hni-annotate-fastopt.js:19139)
at $f_sc_TraversableOnce__addString__scm_StringBuilder__T__T__T__scm_StringBuilder (hni-annotate-fastopt.js:5179)
at $c_s_xml_UnprefixedAttribute.addString__scm_StringBuilder__T__T__T__scm_StringBuilder (hni-annotate-fastopt.js:19180)
at $f_sc_TraversableOnce__mkString__T__T__T__T (hni-annotate-fastopt.js:5163)
at $c_s_xml_UnprefixedAttribute.mkString__T__T__T__T (hni-annotate-fastopt.js:19127)
at $f_sc_TraversableLike__toString__T (hni-annotate-fastopt.js:14366)
at $c_s_xml_UnprefixedAttribute.toString__T (hni-annotate-fastopt.js:19133)

This appears to be a similar issue to #2553 (Same error for byte arrays), with the 125 000 argument limit for JS breaking the toString/mkString methods. Therefore a similar fix could be implemented.
To replicate, construct XML with a huge number of elements (I suspect around 125 000 because of the above).
This is really annoying for XML construction, forcing you to resort to string interpolation, implementing your own toString method.

Hum ... wrong repo? Shouldn't this be reported to https://github.com/scala/scala-xml?

I don't think this is related to #2553. That issue was caused by calling the JS function String.fromCharCode() with a variable number of arguments (using : _*), which blows up when the given argument array is too large. The fix was to build JS strings incrementally using string concatenation instead.
mkString and collection's toString methods are already built on top of Scala's StringBuilder, which is built on j.l.StringBuilder, which uses string concatenation (and not a variadic number of arguments to JS functions), so this is definitely not the same thing.
AFAICT the error you observe looks like a plain old Stack Overflow.

I see! Thanks for taking a look at it, at any rate.


fix: properly set compiler options defaults

In #108, the defaults of CompilerOptions were changes so we would stop emitting with inline source maps by default. This works when providing an empty object for compilerOptions, but not when not providing compilerOptions.  This is because we used to fallback to deno_ast's defaults for EmitOptions when compilerOptions was not provided.
This PR fixes it; not providing compilerOptions is now equivalent to providing an empty object.

@dsherret It's ready.


"send email" to nominess

Description
It would be nice to be able to filter the nominees, for example, picking all accepted IAB nominations via https://datatracker.ietf.org/nomcom/2022/private/?state=accepted&position=109&submit=, and be able to send them a short email.  It could be a text box, or perhaps like #4618 to allow an upload. The textbox is probably good enough.
Code of Conduct

[X] I agree to follow the IETF's Code of Conduct

Is it important that the datatracker send the message? Would it be sufficient (or better?) if the datatracker gave you an easy way to gather the set of addresses to use to send from your own email client of choice?
Points to consider (these could be both pluses and minuses)

the datatracker keeps a record of what message is sent to who and when
sending from the ietf servers has well-explored (but not always well-working) properties wrt successful smtp delivery to community members

Maybe the answer to the above question should be "why not both?"

I didn't think of just "give me these addresses" as a way of doing it.  And yes, that would be fine.

I think this and #4893 are closely related, perhaps even duplicates :)

Closing as a duplicate of #4893 which is fixed.


Extra blank line inserted above index item if item is forced to break

If an item in the index is forced to break, the converter adds an extra blank line above the item.
For example:
flags

    FLAG_THAT_IS_SO_LONG_IT_MUST_BE
    _BROKEN

It should appear as:
flags
  FLAG_THAT_IS_SO_LONG_IT_MUST_BE
    _BROKEN

The solution for now is to eliminate the line height normalization for index terms. But the cause of the problem (line height normalization) will show up elsewhere and still needs to be addressed in those places.


Feat: timerpicker can't find second #2398

Added seconds select in time picker and updated the testing to be in format
fixes: https://github.com/h2oai/wave/issues/2398
The PR fulfills these requirements: (check all the apply)

[x] It's submitted to the main branch.
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
[x] When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
[x] If changes were made to ui folder, unit tests (make test) still pass.
[x] New/updated tests are included

@mturoci double-checked the files submitted for this PR and everything looks right. Did changes to the ui/src/time_picker.test.tsx and ui/src/time_picker.tsx files only and the rest were automatically generated after rebuilding. Would upload the video before day's end


[Bug]fix bug which cause writebatch too small

Signed-off-by: Little-Wallace<EMAIL_ADDRESS>
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
I made a mistake that is judging whether a WriteBatchVec should be written into RocksDB by the size of its vec. But I did not clear it vec to reduce allocate new object every time after writing into RocksDB. This bug will make TiKV writes WriteBatchVec into RocksDB at once even if there is only one key in it. And it will greatly reduce the performance of TiKV.
What is changed and how it works?
Use index instead. It will judge by the real size of vector.
Related changes
Check List
Tests

Unit test

Release note

/bench

why QPS even drops with this fix

why QPS even drops with this fix

Because this bug is hidden by other bug...

/bench

/run-all-tests

/bench

/bench

/bench

/run-all-tests


feat: Use RoutesBuilder API

It had all the routes for the different users, also the ones that are not applicable for the user.
So the Flow view is there for user, which leads to a Reason: Access is denied by annotations on the view..
And Hilla User is there for admin which leads to the login view, even though you are already logged in.

Yeah, I'll try to change that by editing the main layout impl.


Make name of version.json endpoint configurable

In order to allow various methods of handling multiple catalog version endpoints. E.g. production.json and staging.json at the root of the S3 bucket. We can add a command line flag to control the name of the filename.
We may also want to consider renaming the default of version.json to latest.json, production.json or stable.json.

My vote is for latest.json

latest seems to match the convention in the Docker community? I'm for whatever is the most conventional.

@jamesdphillips if we all agree on this, should I go ahead and make an issue in sensu/sensu-enterprise-go to make this configurable via web/v1.WebConfig?

I updated https://github.com/sensu/sensu-enterprise-go/issues/2071 to incorporate the URL and release/version.

Closed by https://github.com/sensu/catalog/pull/159.


Error when using in props inputRef instead just ref attribute

Warning: React does not recognize the inputRef prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase inputref instead. If you accidentally passed it from a parent component, remove it from the DOM element.

version will be 2.0.4 for correct work

it seems like this issue is relevant again in version 3.0.0-alpha.2
getting Warning: React does not recognize the inputRef prop on a DOM element.


Feature/enable integration tests

Erroneously opened a PR here. Was meant for my own fork of this repo. My bad.


Gradle test task not work

I use spring-test-dbunit 1.3.0, JUnit5, Eclipse and Gradle5.6.4.
The junit test works in Eclipse.
However, tests in Gradle do not work.
Gradle says no tests can be found.
If I run without writing a TransactionDbUnitTestExecutionListener OR DbUnitTestExecutionListener, the test works.

I have the same configuration but intellij idea instead of eclipse, and I have the same problem.
Idea can run tests but gradle doesn't see them.


What should we do with the Oracle sample?

My concern is that the cost of keeping the Oracle sample up-to-date with every change during the 3.0 milestone is not worth the value it would provide. Should we remove the sample from master for now, and (if needed) bring it back up-to-date later?

Triage: Let's remove it for now and bring it back before 3.0 RTM to validate 3.0 changes.


does v2ray-plugin client support a v2ray server on shadowsock+websocket mode?

it doesn't work in my case. i'm sure 'password' and 'method' are configured correctly, and here are my configurations and logs:
server side (using caddy for reverse proxy):
{
    "protocol": "shadowsocks",
    "port": 1000,
    "settings": {
        "method": "chacha20-ietf-poly1305",
        "password": "password",
        "network": "tcp"
    },
    "streamSettings": {
        "network": "ws",
        "wsSettings": {
            "path": "/path"
        }
    }
}

client side:
path=/path;host=domain.com;tls
server side log:
2019/08/05 10:50:43 [Info] [2245403664] v2ray.com/core/app/proxyman/inbound: connection ends > v2ray.com/core/proxy/shadowsocks: failed to create request from: ip:37234 > v2ray.com/core/proxy/shadowsocks: failed to read address > chacha20poly1305: message authentication failed
2019/08/05 10:50:43 ip:37234 rejected  v2ray.com/core/proxy/shadowsocks: failed to read address > chacha20poly1305: message authentication failed

client side log (no error message shows):
[2019-08-05 18:51:20] connect to mtalk.google.com:5228
[2019-08-05 18:51:20] Socket connected to ss server: domain.com:443

v2ray version: 4.20.0
shadowsocks-windows version: <IP_ADDRESS>
v2ray-plugin version: 1.1.0

i found this and the issue was solved.


How do I use smart select fields and preload function together?

Your Question

I want to select specific fields of User, so I defined a smaller struct called APIUser which can select specific fields automatically. Also I want preload Orders when find users.
type User struct {
  gorm.Model
  Name   string
  Age    int
  Gender string
  Orders []Order
}

type Order struct {
  gorm.Model
  UserID uint
  Price  float64
}

type APIUser struct {
  ID     uint
  Name   string
  Orders []Order
}

db.Model(&User{}).Preload("Orders").Find(&APIUser{})

When I run the above code, I get the following error.
[error] invalid field found for struct main.APIUser's field Orders, need to define a valid foreign key for relations or it need to implement the Valuer/Scanner interface
panic: reflect: call of reflect.Value.Field on uint Value

Is it impossible to use it this way?
The document you expected this should be explained

Expected answer

db.Model(&User{}).Preload("Orders", func(tx *gorm.DB) *gorm.DB {
return tx.Select("Name")
}).Find(&APIUser{})

db.Model(&User{}).Preload("Orders", func(tx *gorm.DB) *gorm.DB {
return tx.Select("Name")
}).Find(&APIUser{})

@jinzhu
Your answer still gives the same error. My question was, I don't want to select a field when preloading, but whether it is possible to preload in a small struct for smart select.
Out of curiosity, I found out that preload didn't work even when I ran the following code. Can't I select a field if I want to use preload?
db.Preload("Orders").Find(&User{}) // it works
db.Select("name, age").Preload("Orders").Find(&User{}) // it doesn't works

@jinzhu
Your answer still gives the same error. My question was, I don't want to select a field when preloading, but whether it is possible to preload in a small struct for smart select.
Out of curiosity, I found out that preload didn't work even when I ran the following code. Can't I select a field if I want to use preload?
db.Preload("Orders").Find(&User{}) // it works
db.Select("name, age").Preload("Orders").Find(&User{}) // it doesn't works

@jinzhu
My question was not whether I can select fields when calling the Preload function, but how to use Preload on smaller struct for smart select fields.
After this and that experiment, the following results were obtained.
type User struct {
  gorm.Model
  Name   string
  Age    int
  Gender string
  Orders []Order
}

type Order struct {
  gorm.Model
  UserID uint
  Price  float64
}

type APIUser struct {
  ID     uint
  Name   string
  Orders []Order `gorm:"foreignKey:UserID"`
}

db.Model(&User{}).Preload("Orders").Find(&APIUser{}) // panic!
db.Table("users").Preload("Orders").Find(&APIUser{}) // it works, but smart select is not working!

Instead of using the Model function, I found that specifying the table name works. But smart select didn't work. I have confirmed that the following query is executed.
SELECT * FROM `orders` WHERE `orders`.`user_id` = 1 AND `orders`.`deleted_at` IS NULL
SELECT * FROM `users`

Since the APIUser structure only has an ID and a Name, the following query should be executed.
SELECT `users`.`id`,`users`.`name` FROM `users` WHERE `users`.`deleted_at` IS NULL

@jinzhu
My question was not whether I can select fields when calling the Preload function, but how to use Preload on smaller struct for smart select fields.
After this and that experiment, the following results were obtained.
type User struct {
  gorm.Model
  Name   string
  Age    int
  Gender string
  Orders []Order
}

type Order struct {
  gorm.Model
  UserID uint
  Price  float64
}

type APIUser struct {
  ID     uint
  Name   string
  Orders []Order `gorm:"foreignKey:UserID"`
}

db.Model(&User{}).Preload("Orders").Find(&APIUser{}) // panic!
db.Table("users").Preload("Orders").Find(&APIUser{}) // it works, but smart select is not working!

Instead of using the Model function, I found that specifying the table name works. But smart select didn't work. I have confirmed that the following query is executed.
SELECT * FROM `orders` WHERE `orders`.`user_id` = 1 AND `orders`.`deleted_at` IS NULL
SELECT * FROM `users`

Since the APIUser structure only has an ID and a Name, the following query should be executed.
SELECT `users`.`id`,`users`.`name` FROM `users` WHERE `users`.`deleted_at` IS NULL

I ran into the same problem, I think this is a bug

I can confirm I have the exact same problem, panic and everything. Smart select works on anything that does not have associations, but if I try to preload and do associations there is a panic. This issue should be re-opened.

@jinzhu

I met this problem too. When I using with the smart select field(like struct APIUser other mention above), I will panic. But when using with the model struct( like struct User above) the preload works well.

I think there is something not defined. Because when I change to using embedded, it works well.
I only change the APIUser to this.
type APIUser struct {
  gorm.Model
  Name   string
  Orders []Order
}

And the preload words well.
db.Preload("Orders").Model(&User{}).Find(&APIUser{})

@fnsne
Have you tried testing even when data actually exists in the users table and the orders table? When there is no data, the panic does not occur as you said, but if there is data, it still panics.

@wolfapple
I don't know how to execute the Find(&APIUser{}) with no data in the two tables.
But I used the command above I wrote, it works with data in two tables.
There is no panic.
Maybe the version I'm using?  I use v1.20.7.

This is amazing @jinzhu
db.Model(&User{}).Preload("Orders", func(tx *gorm.DB) *gorm.DB {
return tx.Select("Name")
}).Find(&APIUser{})

But how to do that with Joins?


Add spec to show fetching a collection with options could failed

Hi,
Before coding a patch, I prefer to show you my case and tell me if I forget to configure something or if there is a workaround.
The problem is when a collection is fetched with options and that collection model has a 1:M relation, those options are propagate. The side effect is an error when backbone-associations define the relation.
So should I explore further and create a patch?

Someone here?

Sorry. Will do in this week.

Thanks @jdkanani :+1:

up?

Is this repo dead ?


Where to download the binary files for 1.13.10?

EKS 1.13.10 is officially announced with AMI, but there is no binary files under s3 bucket.
The latest binary files are under 1.13.8.
aws s3 ls s3://amazon-eks/1.13.8/2019-08-14/bin/linux/amd64/
Can you please upload the new files to S3?

Hi, we just released the latest binaries to:

amazon-eks/1.14.7/2019-09-27
amazon-eks/1.13.11/2019-09-27
amazon-eks/1.12.10/2019-09-27
amazon-eks/1.11.10/2019-09-27
We'll setup some automated process to release these binaries.


Why Choose Rollz Ice Cream Pints?

At Rollz Ice Cream, we make every pint with care, using fresh ingredients and exciting flavors. Our ice cream pints near me are the perfect way to enjoy your favorite rolled ice cream creations at home, whether you're relaxing solo or sharing with family and friends.


revert ATMI path when rocr runtime fixes arrive in ROCm release

Background: Rome systems present themselves as NUMA cpu nodes. If all the physical memory slots are NOT filled , our ATMI runtime attempts to use a memory pool that has no memory and causes an insufficient resource failures.
This means nobody can use AOMP on a Rome system which is not fully populated with memory. ROCM 3.1 AOMP (and previous) cant build executables that run on Rome, neither can our AOMP releases past and present, and no one but us with the specific patch can build an AOMP that is usable on Rome.
Again we believe this applies only to Rome systems with some empty memory slots on the motherboard.
I don’t know when the appropriate rocr-runtime patches will make it into a ROCM release.
We need to get ahead of this one with the ROCm teams to get whatever the rocr-runtime patch is, into a ROCm release.
From Ashwin{
the ideal solution is to wait/push ROCr/ROCt teams to prioritize the below two JIRA tickets ASAP.
http://ontrack-internal.amd.com/browse/SWDEV-202188
http://ontrack-internal.amd.com/browse/SWDEV-201817
ATMI just uses the memory pool provided by ROCr, and the above tickets indicate that ROCr is returning more memory pool objects than it should, some of which point to empty memory slots.
As a workaround, I have provided Ethan with the patch in case we want to jump ahead, but we should revert the patch once the ROCr/ROCt teams fix the above tickets. @Stewart, Ethan/@Lieberman, Ron: can one of you then track this TODO (to revert the workaround) at a later time? Perhaps as a GitHub issue?

This was fixed in an earlier ROCm release.  Closing it


Move API Status Indicator to right of header text

Closes #1112
Changes

move API Status Indicator to right of header text

Looks really nice, do you agree @Nazarah ? I think we could merge this.


[N7 Account Settings] Create Date of Birth page

Tracking issue: https://github.com/Expensify/Expensify/issues/182122
Detailed section of doc: https://docs.google.com/document/d/17akqrbC-w8FqEoDLvcLmrX6iw4uaVrT_xlwAl-IhEzE/edit#heading=h.76axa86bvakz
Note: This can not be completely implemented until the UpdateDateOfBirth command has been implemented - see https://github.com/Expensify/Expensify/issues/231916

On hold for WhatsApp Quality

Still on hold for now, might pick this up next week as discussions from here (https://github.com/Expensify/App/issues/11795) are indicating this could be useful to implement sooner rather than later

Unassigning since k2 is not liking that i have so many issues assigned to me on hold, will get back to this once N7 Account Settings if off hold

Monthly is fine, still waiting for WAQ to wrap up

Picking this back up!

App PR is still in review

⚠ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Looks like something related to react-navigation may have been mentioned in this issue discussion.
As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.
Feel free to drop a note in #expensify-open-source with any questions.

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.67-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/14290

If no regressions arise, payment will be issued on 2023-02-15. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

Closing in favor of doing payment in https://github.com/Expensify/App/issues/11578
Also @fedirjh please report any bugs you find in #expensify-bugs, and just so you know that missing page title is not a big, it was a design decision (we may change later)


DynamicInputModel does not work with inputType:"file"

After I choose the file to upload, I print out the FormGroup object, but there's nothing related to the file I chose.

@buhichan Thanks for your contribution. You're right. At the moment files are not connected to the DynamicInputModel. I'll try to solve this.

@buhichan Will probably resolved in RC.3 by adding a new property files to DynamicInputModel


Raku / Cro / PostgreSQL - Backend Application

Hi,
I'm putting together a real world api app here:
https://github.com/camstuart/raku-cro-realworld-example-api-app
Raku (formerly known as Perl6) is a member of the Perl family.
The library Cro I am using (ok, so kind-of a framework) is fast becoming the de facto standard in the Raku community for distributed systems. So it can do HTTP rest API's very well, but also full stack (server rendered html) also.
This project will provide the rest interface only. Once completed, I will use it as a basis for a full stack demo app that responds with HTML.

Please label backend & wip

Hello we are currently moving all work in progress to Github Discussions.
I'll close this issue by now, you can find instruction to open a discussion there : https://github.com/gothinkster/realworld/discussions/633
Thanks for your contribution !


Add the possibility to provide metadata in transactionEventReport mutation

Problem
Payment apps cannot update TransactionItem metadata in transactionEventReport mutation. This causes the app to use separate updateMetadata mutation, which prolongs the execution time of sync webhook, which is limited to 20s.
Related: https://github.com/saleor/saleor/issues/14772

1. General Assumptions
Add metadata parameter to transactionEventReport which will update the metadata of Transaction the same way as, updateMetadata (i.e. it will merge existing metadata with new one, not replace everything).
Acceptance Criteria

[ ] transactionEventReport has metadata parameter

[ ] it merges existing metadata with new one

2. API changes
Mutations
  """
  Report the event for the transaction.

  Added in Saleor 3.13.

  Note: this API is currently in Feature Preview and can be subject to changes at later point.

  Requires the following permissions: OWNER and HANDLE_PAYMENTS for apps, HANDLE_PAYMENTS for staff users. Staff user cannot update a transaction that is owned by the app.
  """
  transactionEventReport(
    # ...

    """
    The ID of the transaction.
    """
    id: ID!

    # New:
    """
    Metadata to update on the `TransactionItem` object

    Added in Saleor 3.xx
    """
    metadata: [MetadataInput!]
  ): TransactionEventReport @doc(category: "Payments")

5. To Do list

### Tasks
- [ ] Add a draft title or issue reference here

6. To Test

[ ]
[ ]

Released in 3.20.34


DXA - XPM - non-mandatory fields

In the case when component has non-mandatory and empty field, there is no appropriate XPM comment which will indicate that field can be editable by XPM.
This is scenario:

Schema has mandatory and non-mandatory fields, lets take just text fields as examples.
Rendering is OK in the case of mandatory field or non-mandatory field which has some text and source of the page is like

If the field is non-mandatory and without value, output is different and looks like this

As it can be noticed there is no XPM comment which will give the information about which field should be editable with XPM. - Code in View used to render non-mandatory fields is

WebRequestContext.IsPreview is always true for our current development environment so that part is ok. Model.TipText is null in that case, and maybe this is causing the issue.
Problem is related to the output because there is XPM related comment in the source of the page, so XPM does not recognize there is field without value which should be allowed for editing. Without this comment there is no placeholder "<< add text >>" when XPM is active.
Also it is tried with different approach and placing first div as it is on the following image, but same issue is there

Link to the conversation on StackExchange http://tridion.stackexchange.com/questions/13391/tridion-2013-dxa-xpm-non-mandatory-fields

What's the status of this? Seems to me this is pretty basic behaviour. We allow this already on our current Tridion 2013 XPM implementations.
What's the suggested workaround if there isn't a solution just yet?

The status of this is that it is an enhancement request, something we will consider for a next release, but no milestone has been set for it yet. Feel free to submit a pull request if you have already implemented it in your own DXA.

TSI-1946 (internal issue ID for tracking purposes)

Fixed in DXA 1.7: XpmPropertyMetadata is now also available for fields without values (which makes @Html.DxaPropertyMarkup work for such fields).


meta: Starring the Pull source code for org repos

Does starring the app's source code affect priority on org repositories? Do you check who commited it before doing any other checks?

Not at this time. However, at this time deprioritization only occurs during times of high server load.

Not at this time. However, at this time deprioritization only occurs during times of high server load.


config: add @types/node to project tsconfig

This PR attempts to fix a build issue introduced in #35
Current solution:

Includes @types/node definitions as a peer dependency of the package. This allows us to require the package.json in order to extract out the package version number. While this works, it is likely not the solution we want as per this comment.

Other solution:

Replace the require with import which may circumvent the aforementioned issue. Reference: https://stackoverflow.com/a/48869478/10366522
This currently results in a different issue with TS not being able to locate package.json under the rootDir. Reference: https://stackoverflow.com/a/61467483/10366522

Closing this PR in favor of a less painful way of doing this.


[FLINK-4116] Metrics documentation

Good first draft of the metrics documentation @zentol. I think the documentation should be a bit more verbose containing more explanations and code examples. This will help the user to quickly get started and understanding the metrics system.

I've addressed all comments, except the config page.

also missing: specific reporter naming

The documentation has reached a really good state. I had only some minor comments left.

Good job Chesnay! Reads very well. I like the way the text and code examples are mixed. I had some minor inline comments.
My biggest concern (not reflected in the inline comments) is the Scope section, which is too dense in my opinion. Do you think we can improve it somehow?
Maybe add sub sections System Scope, User Scope, Examples, Variables for starters. The hierarchical orders stuff I did not get.

I've made the following changes:

rewritte scope section
removed ... from examples
FIX ALL THE TYPOS
better line breaking
added dependency&example for DWHWrapper
replaced hard-coded dependency versions


Remove --xla_gpu_enable_triton_gemm false

Now XLA autotune betwen triton and cublas. So the default should be faster (or not slower) then disabling triton gemm.

Should we first confirm the effect of adding/removing this flag with perf tracking?

Should we first confirm the effect of adding/removing this flag with perf tracking?

Always verify ;)


#199 reach-a11y-anchors

A11y rules for anchors covering:

Link text should be as least four 4 characters long. (http://oaa-accessibility.org/wcag20/rule/38/)
Links with the same HREF should have the same link text. (http://oaa-accessibility.org/wcag20/rule/39/)
Links that point to different HREFs should have different link text. (http://oaa-accessibility.org/wcag20/rule/41/)
Links with images and text content, the alt attribute should be unique to the text content or empty. (http://oaa-accessibility.org/wcag20/rule/43/)
Enforce an anchor element's href prop value is not just #.

Hi @MogensFogh, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Mogens Fogh). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Follow up task: #231
Follow up task: #232

Please i need learn and understand english becouse i don't know what i can do correct so i lost and hurts my self to pass in my brain i am inútil to me and others becouse i told i need medication can i express and put my ideias to other and learn more learn can teacher i am a little just one guy who imagination and pensaments go very far and distace and curious to


Build dicts in a Python 2.6 compatible way

The dict comprehensions don't work on Python 2.6.
So in case dropping 2.6 wasn't intended, this PR should restore compatibility.

Hello! Excuse me but why this is not merged yet? While Py 2.7 is more used than Py 2.6 these days we need that for Py 2.6.

please merge :+1:

Closed by #45.


Error in building bosfs while running build_dev.sh

Describe the bug
The build_dev.sh script uses a number of install scripts.  The script install_bosfs.sh downloads the bosfs-<IP_ADDRESS>.tar.gz and runs its build.sh but fails in two places:

The autogen.sh script calls aclocal which had not yet been installed in the container
undefined reference to uuid-dev

bce_request.cpp:36: undefined reference to `uuid_generate'

To Reproduce
Steps to reproduce the behavior:

Remove any old docker images to start fresh
run ./build_dev.sh ./dev.x86_64.dockerfile from docker/build

Screenshots
Screenshot of first error due to missing aclocal

Screenshot of second error due to missing uuid-dev

Desktop (please complete the following information):

OS: Ubuntu 18.04

Additional context
I created a pull request to fix this issue

Seems like this issue has been resolved. @aboarya thank you very much for the pull request!