[FEATURE] Allow Axis ticks to render inside chart bounds e.g. ticksInside

My request is relevant to line charts. I wonder if there could be an option to render ticks inside the chart area?
Here's an xAxis example of how things layout without the xAxis shown:

As you can see, when I hide the xAxis scales the chart displays full-width perfectly, edge to edge.
However, when I enable the xAxis I get padding left and right of the chart to facilitate the tick label sitting centrally with the first and last data point:

Request
Would you consider adding an option that spaces the tick labels inside the chart bounds? To illustrate, the feature would allow a layout like this with ticks in either Axis rendered within the chart bounds:

Environment
Chart js 2.6.0

@benfrain there is a mirror option on the vertical axes that might solve this for you
axisOptions = {
  ticks: {
    mirror: true
  }
}

@etimberg I have this config currently for the yAxis (as discussed, the xAxis mirror doesn't work yet) which lets the yAxis ticks sit inside, is that what you meant?
{
    yAxisID: "y-axis-0",
    ticks: {
        beginAtZero: false,
        mirror: true,
        fontColor: "rgb(74, 207, 165)",
    },
    gridLines: {
        display: true,
        borderDash: [4, 4],
        drawTicks: false,
        color: "rgba(64,64,64,100)",
    },
},
{
    position: "right",
    id: "y-axis-1",
    ticks: {
        beginAtZero: false,
        mirror: true,
        fontColor: "rgb(187, 187, 187)",
    },
    gridLines: {
        display: false,
        borderDash: [4, 4],
        drawTicks: false,
        color: "rgba(64,64,64,100)",
    },
},

That places the Y axis ticks inside nicely but padding appears either side of the canvas currently due to the X axis ticks rendering to the side of the main graph bounds.

That is what I meant. I see you've already tried that. One generic solution to this is to allow different tick alignments. As you noticed, the tick is center aligned to the value. We could add something that allows different alignments: 'left'|'center'|'right'|'auto' and 'auto' would put left for the first tick, center for the middle ticks and right for the last tick. I think I tried implementing this about a year ago and ran into issues. I can't recall what they exactly were.

@etimberg that sounds ideal! Would certainly fix my problem :)

Is this still being worked on? Would love to see this feature.

+1

+1 Any updates?

Hello everyone!! Today I have been crazy about this issue, and I think I found a solution!:
xAxes: [{ticks: {
padding: -25,
z: 1,
}}]
I hope it helps!


Error Output

I encountered an error that displays the following code:
Sending SOL from account 1: 6rNqnAQ84AUfyr38xwR9F9ZCnENrq4X5BiMSb8qk8LxB
Failed to send SOL to A5aC9bzpTXfQWuAEbdRcXfr2ktRZ5QPTtsibzQia7XVt: SendTransactionError: Simulation failed.
Message: Transaction simulation failed: Attempt to debit an account but found no record of a prior credit..
Logs:
[].
Catch the SendTransactionError and call getLogs() on it for full details.
at Connection.sendEncodedTransaction (F:\CryptoCurrency Data\Bot\Testnet\SONIC\2\node_modules@solana\web3.js\lib\index.cjs.js:8134:13)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async Connection.sendRawTransaction (F:\CryptoCurrency Data\Bot\Testnet\SONIC\2\node_modules@solana\web3.js\lib\index.cjs.js:8099:20)
at async Connection.sendTransaction (F:\CryptoCurrency Data\Bot\Testnet\SONIC\2\node_modules@solana\web3.js\lib\index.cjs.js:8090:12)
at async sendAndConfirmTransaction (F:\CryptoCurrency Data\Bot\Testnet\SONIC\2\node_modules@solana\web3.js\lib\index.cjs.js:2273:21)
at async sendSol (F:\CryptoCurrency Data\Bot\Testnet\SONIC\2\src\solanaUtils.js:27:21)
at async F:\CryptoCurrency Data\Bot\Testnet\SONIC\2\index.js:131:9 {
signature: '',
transactionMessage: 'Transaction simulation failed: Attempt to debit an account but found no record of a prior credit.',
transactionLogs: []
balance on 2 SOL accounts and that's from Sonic's own faucet... but this bot still has an error. is there any solution?

I encountered an error that displays the following code:
Sending SOL from account 1: 6rNqnAQ84AUfyr38xwR9F9ZCnENrq4X5BiMSb8qk8LxB Failed to send SOL to A5aC9bzpTXfQWuAEbdRcXfr2ktRZ5QPTtsibzQia7XVt: SendTransactionError: Simulation failed. Message: Transaction simulation failed: Attempt to debit an account but found no record of a prior credit.. Logs: []. Catch the SendTransactionError and call getLogs() on it for full details. at Connection.sendEncodedTransaction (F:\CryptoCurrency Data\Bot\Testnet\SONIC\2\node_modules@solana\web3.js\lib\index.cjs.js:8134:13) at process.processTicksAndRejections (node:internal/process/task_queues:95:5) at async Connection.sendRawTransaction (F:\CryptoCurrency Data\Bot\Testnet\SONIC\2\node_modules@solana\web3.js\lib\index.cjs.js:8099:20) at async Connection.sendTransaction (F:\CryptoCurrency Data\Bot\Testnet\SONIC\2\node_modules@solana\web3.js\lib\index.cjs.js:8090:12) at async sendAndConfirmTransaction (F:\CryptoCurrency Data\Bot\Testnet\SONIC\2\node_modules@solana\web3.js\lib\index.cjs.js:2273:21) at async sendSol (F:\CryptoCurrency Data\Bot\Testnet\SONIC\2\src\solanaUtils.js:27:21) at async F:\CryptoCurrency Data\Bot\Testnet\SONIC\2\index.js:131:9 { signature: '', transactionMessage: 'Transaction simulation failed: Attempt to debit an account but found no record of a prior credit.', transactionLogs: []
balance on 2 SOL accounts and that's from Sonic's own faucet... but this bot still has an error. is there any solution?

I think it's an RPC problem, not an issue with the code. Since it's accessed by tons of transactions and is still on devnet, I think it can't handle the load yet. Just try again, and use another wallet if possible, since I and most of my subscribers are mostly fine.


Cacheless Data Download

Overview:
Adds a cacheless data grabbing by passing only the locations of the file on the filesystem and not downloading it to the local cache first.
Adds:

New class ColumnBytesFileReader that reads the data directly from the column bytes file location
Moves common logic into this class
Existing ColumnBytesFileCache inherits and overwrites the read to copy the file to local system first
Changes the Visitor to the data row to take a reading callable instead of the class, that callable now take the column byte location object and reads and returns

Testing:

Done here in the CI
Will add more internal testing to the internal docs

@isaak-willett I added one comment - please take a look. Then, do your best to test local storage both with and without the cache data download.
Once we are ready to merge, I think the best thing is that we merge this PR into your branch feature/isaak/local_fs_dataset from your last PR and then merge your last PR into master.

@convexquad I added a test that ensures that the cache isn't being written to when there is no prefix passed. Check the test_datasets file and look at the cached vs non-cached FileSystemDataset tests. There is now a check on the dir size of the COLUMN_CONCATENATED_FILE dir for both the cache and the original dir.
In the non cache the test asserts that folder is 0 bytes and the cached asserts that the col files copied there are identical to the original written dir.

Going to merge this one in to the other


Feature: sort-object-types add support for newlines-between

What rule do you want to change?
sort-object-types
Describe the problem
There is no support for newlines-between, so it's not possible to automatically add newlines between custom groups.
Code example
For example, we have a type like this:
type Person = {
  onBirthday: () => void;
  name: string;
  onAgeChange: (age: number) => void;
  age?: number;
  surname: string;
  birthday?: Date;
}

I expect it to be sorted like this using custom groups:
type Person = {
  name: string;
  surname: string;

  age?: number;
  birthday?: Date;

  onAgeChange: (age: number) => void;
  onBirthday: () => void;
}

Additional comments
No response
Validations

[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.

Added in 69b643e.
Released in v3.7.0.

Thanks! However, I still can't figure out how to set up the plugin for my original example.
Even this type is marked as correct:
export type Person = {
  name: string;
  age?: number;
};

with this configuration:
{
  type: 'natural',
  newlinesBetween: 'always',
  groupKind: 'required-first',
  groups: [['unknown', 'multiline'], 'method'],
}

But if I add a method, it will divide into groups:
export type Person = {
  name: string;

  onAgeChange: (age: number) => void;

  age?: number;
};

I was trying to set up customGroups for ['requiredType', 'optionalType', 'requiredMethod', 'optionalMethod'], but it didn't work either.

@olegafx That's right, that's how it should work. Can you show your full ESLint config?

I was using the configuration from the previous message and some versions with custom groups, but I didn't save them.
But how to make it to turn this:
type Person = {
  onBirthday: () => void;
  name: string;
  onAgeChange: (age: number) => void;
  age?: number;
  surname: string;
  onBirthdayChange?: (birthday: Date) => void;
  birthday?: Date;
}

Into this:
type Person = {
  name: string;
  surname: string;

  age?: number;
  birthday?: Date;

  onAgeChange: (age: number) => void;
  onBirthday: () => void;

  onBirthdayChange?: (birthday: Date) => void;
}

?

This is related for me to #395 and #217: the drawback of having a groupKind option distinct from groups is that you have to choose between:

Sorting by groups then groupKind.
Sorting by groupKind then groups.

Currently, we sort by groups then groupKind: you will either have all optional attributes above required attributes, or the opposite.
What you are trying to do is impossible with groupKind.

I was trying to set up customGroups for ['requiredType', 'optionalType', 'requiredMethod', 'optionalMethod'], but it didn't work either.

There is a proposal to handle something like this in #395 (https://github.com/azat-io/eslint-plugin-perfectionist/issues/395#issuecomment-2496248187) with a system similar to sort-classes, but this is not yet implemented.
As of today, you can use newlinesBetween to separate groups yourself with a newline, but that's obviously not ideal.

Implemented in 8407bae.
Released in v4.2.0.


fresh helm install from 1.5 with installCRDs error

Describe the bug:
When installing cert-manager with helm in namespace "ingress", the install borks with errors about CRDs:
Error: UPGRADE FAILED: rendered manifests contain a resource that already exists. Unable to continue with update: CustomResourceDefinition "certificaterequests.cert-manager.io" in namespace "" exists and cannot be imported into the current release: invalid ownership metadata; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "cert-manager"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "ingress"

Expected behaviour:
No errors.
Steps to reproduce the bug:
helm fetch jetstack/cert-manager --version v0.15.0 --untar --untardir=charts
helm upgrade --install --reset-values cert-manager charts/cert-manager --wait --timeout 1200s --atomic --cleanup-on-fail --create-namespace --namespace ingress --set installCRDs=true

Anything else we need to know?:
Non default namespace used.
Environment details::

Kubernetes version (e.g. v1.10.2):
v1.15.7
Cloud-provider/provisioner (e.g. GKE, kops AWS, etc):
GKE
cert-manager version (e.g. v0.4.0):
v0.15.0
Install method (e.g. helm or static manifests):
helm

/kind bug

nevermind, targeted an old cluster, not the newly created one...

I'm actually having the exact same issue while trying to do an upgrade with the new version 0.15.1 with:
helm repo add jetstack https://charts.jetstack.io
helm repo update
helm upgrade \
    cert-manager \
    jetstack/cert-manager \
    --install \
    -n cert-manager \
    --create-namespace \
    --version 0.15.1 \
    --set installCRDs=true

I previously ran this exact same command with --version 0.15.0.
The error I have is:
failed to upgrade chart for release [cert-manager]: rendered manifests contain a new resource that already exists. Una
ble to continue with update: existing resource conflict: kind: CustomResourceDefinition, namespace: , name: issuers.cert-manager.io"

Is there any know issue with the --set installCRDs=true while upgrading the helm chart?


[Fix] Fix the discontiguous output feature map of ConvNeXt.

Motivation
The output feature map of ConvNeXt may be not contiguous, which may cause training problem in downstream tasks.
Modification
Make the output feature map be contiguous.
Checklist
Before PR:

[x] Pre-commit or other linting tools are used to fix the potential lint issues.
[x] Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
[x] The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
[x] The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

[x] If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
[x] CLA has been signed and all committers have signed the CLA in this PR.

@hhaAndroid
Should fixed the training problem in MMDetection, please have a look.


Revert "Revert "fix border style without borderRadius""

By analyzing the blame information on this pull request, we identified @bestander and @trave7er to be potential reviewers.

@skv-headless updated the pull request.

@bestander take a look please. revert of revert of #6789 😄

revert of revert of #6789

Yay!

@facebook-github-bot shipit

The bot might have been down.
@facebook-github-bot shipit

Thanks for importing. If you are an FB employee go to Phabricator to review.


Carbon for ibm.com June 2021 Release Plan (v1.20.0)

June 2, 2021: PR submission date
June 4, 2021: Code freeze
June 7 - 14, 2021: Release Candidate(s) and testing
June 15, 2021: Full Release

Web Components
Features

content-block-card-static

created component (#6198)

card

introducing static variant with tag-group (#6133)

image

adding loading="lazy" to images in web-components (#6164)

imports

simplification of web component imports (#6156)

tag-group

create new component (#6107)

footer

add specific link title to legal link data-autoids (#6137)

content-item

restrict footer to text-cta and button-cta (#6094)

tag-link

create new component (#6038)

Fixes

card-group

optional border for card group default (#6152)

lightbox-video-player

add check for video cta specific modal to open and prevent multiple modals from opening (#6260)
update videoid and only open if playing mode is lightbox (#6226)

leadspace

fixes gradient and adds new leadspace image (#6259)
breadcrumb style import (#6239)
wrap breadcrumb after full row (#6216)
add super variation and tag group (#6154)

masthead

apply global styles updates based on unified cloud masthead project (#5922)
menu options blocking items when active (#6168)
remove focus search toggle and fix console error (#6108)

masthead-search

delay position for cursor focus (#6208)

dotcom-shell

add checks if toc exist (#6257)

utilities

use util package for deprecate instead of relative path (#6235)

logo-grid

styles and functionality fixes (#6097)

tabs-extended

label wraps 2 lines then truncates with tooltip (#6155)

content-block

heading spacing fix (#6103)

content-group-simple

multiple storybook fixes (#6092)

horizontal-rule

update grid layout (#6037)

link-list

vertical focus styles (#6080)

content-block-simple

storybook cleanup (#5943)

Housekeeping

cloud-foundry

updating manifest configs to force https (#6238)

feature-card

refactored block large and medium into component (#5950)

upgrade

upgrade to carbon 10.36.0 (#6214)
upgrade to carbon 10.35.0 (#6093)

codesandbox

clean up examples (#6204)
update examples (#6165)

deps

update caniuse-lite (#6189)
bump hosted-git-info from 2.8.4 to 2.8.9 (#6007)

carousel

fix carousel imports in react-wrapper readme instance (#6151)

leadspace

add documentation on using video cta within leadspace (#6113)

akamai

switching url for artifacts to akamai domain (#6067)

footer

remove console log (#6057)

deps-dev

bump postcss from 7.0.17 to 8.2.10 (#6045)

React
Features

tag-group

create new component (#6107)

footer

add specific link title to legal link data-autoids (#6137)

tag-link

create new component (#6038)

Fixes

card-group

optional border for card group default (#6221)

leadspace

added deprecation warning and sync with web-components version (#6166)

logo-grid

styles and functionality fixes (#6097)

tabs-extended

label wraps 2 lines then truncates with tooltip (#6155)

content-group-simple

multiple storybook fixes (#6092)

content-block-simple

storybook cleanup (#5943)

masthead

prevent enter key search when search field is empty (#6082)

storybook

remove megamenu from l1 custom data storybook (#6019)

Housekeeping

cloud-foundry

updating manifest configs to force https (#6238)

feature-card

refactored block large and medium into component (#5950)

upgrade

upgrade to carbon 10.36.0 (#6214)
upgrade to carbon 10.35.0 (#6093)

codesandbox

update examples (#6165)

yarn

removing unnecessary yarn.lock file

akamai

switching url for artifacts to akamai domain (#6067)

Styles
Features

content-block-card-static

created component (#6198)

card

introducing static variant with tag-group (#6133)

tag-group

create new component (#6107)

tag-link

create new component (#6038)

Fixes

card-group

optional border for card group default (#6221)
optional border for card group default (#6152)

leadspace

fixes gradient and adds new leadspace image (#6259)
added deprecation warning and sync with web-components version (#6166)
breadcrumb style import (#6239)
wrap breadcrumb after full row (#6216)
add super variation and tag group (#6154)

masthead

apply global styles updates based on unified cloud masthead project (#5922)

card-static

change background color on hover (#6213)

linklist

video heading link style is broken (#6184)

logo-grid

styles and functionality fixes (#6097)

code-snippet

expressive code snippet carbon 10.31.0 update adjustments (#6171)

tabs-extended

label wraps 2 lines then truncates with tooltip (#6155)

content-block

heading spacing fix (#6103)

content-group-simple

multiple storybook fixes (#6092)

horizontal-rule

update grid layout (#6037)

content-block-simple

storybook cleanup (#5943)

Housekeeping

cloud-foundry

updating manifest configs to force https (#6238)

feature-card

refactored block large and medium into component (#5950)

upgrade

upgrade to carbon 10.36.0 (#6214)
upgrade to carbon 10.35.0 (#6093)

codesandbox

update examples (#6165)

Services
Housekeeping

cloud-foundry

updating manifest configs to force https (#6238)

Utilities
Housekeeping

settings

update settings to v1.20.0
update settings to v1.19.1
update settings to v1.19.1

cloud-foundry

updating manifest configs to force https (#6238)

feature-card

refactored block large and medium into component (#5950)

upgrade

upgrade to carbon 10.36.0 (#6214)
upgrade to carbon 10.35.0 (#6093)

@RobertaJHahn release completed: https://github.com/carbon-design-system/carbon-for-ibm-dotcom/releases/tag/v1.20.0


him/onb fixes2

open button in inventory
cmd l should check if selection is empty or not
linting
liniting
improvements
improvements
fixes

bet


[Feature request] Liferay support for SAML pac4j

I think it's easy to use spring webmvc integration for saml-pac4j in Liferay portlet.
Now Liferay provide SAML plugin but for Enterprice Edition only: https://web.liferay.com/marketplace/-/mp/application/15188711

I'm not sure to understand if you can already use Spring MVC and pac4j-saml in SAML what do you expect?

@leleuj thanks for you comment! I think that sample usage project (like pac4j-liferay-demo) will safe so much time.. and will be very usefull for Liferay users.
Liferay 7 uses the OSGi standard but pac4j and it's transitive dependencies are not OSGI bundles (with some exceptions like guava). If we want to use this library in Liferay it's need to build a service to encapsulate the services the dependency jar provides. That way we can have a separate API module that bundles can depend on and use, and also get an implementation module that has the embedded jar. This way embed the jar, but only in a single module.
I have try this but Liferay's compileOnly and compileInclude Gradle tasks failed to deals with transitive dependencies.. in generated manifest file its have:
Import-Package: com.sun.msv.grammar,com.sun.msv.grammar.trex,com.sun.msv.grammar.xmlschema,com.sun.msv.rea
 der,com.sun.msv.reader.trex.ng,com.sun.msv.reader.util,com.sun.msv.re
 ader.xmlschema,com.sun.msv.util,com.sun.msv.verifier,com.sun.msv.veri
 fier.regexp,com.sun.msv.verifier.regexp.xmlschema

maybe jaxb dependency? but I cant find it in transitive.. and if I try to deploy bundle service:
2019-06-03 17:51:04.268 ERROR [fileinstall-/opt/liferay/osgi/modules][org_apache_felix_fileinstall:97] Error while starting bundle: file:/opt/liferay/osgi/modules/de.kv.pac4j.services.saml.impl-1.0.0.jar
org.osgi.framework.BundleException: Could not resolve module: de.kv.pac4j.services.saml.impl [999]_  Unresolved requirement: Import-Package: com.sun.msv.grammar_ [Sanitized]

We have no plans to build such a thing. If you are interested, a pull request would be very welcome.


Question: Can you use go-dnsmasq as a sidecar in a pod in Kubernetes?

I'd like to configure an nginx resolver to point to go-dnsmasq, my nginx config looks like this:
location ~ ^/(.+)$ {
        resolver <IP_ADDRESS>:53;
        set $backend "http://$1:80";
        proxy_pass $backend;
}

and my Kubernetes pod specification looks like this:
spec:
  containers:
    - name: nginx
      image: "nginx:1.10.0"
      ports:
        - containerPort: 8080
          name: "external"
          protocol: "TCP"
    - name: dnsmasq
      image: "janeczku/go-dnsmasq:release-1.0.5"
      args:
        - --listen
        - "<IP_ADDRESS>:53"

But I run into this error:
[error] 9#9: *734 myservice could not be resolved (2: Server failure), client: <IP_ADDRESS>, server: nginx-proxy, request: "GET /myservice HTTP/1.1", host: "localhost:8080"
<IP_ADDRESS> - xxx [30/May/2016:10:34:23 +0000] "GET /myservice HTTP/1.1" 502 173 "-" "curl/7.38.0" "-"

But I can see that go-dnsmasq is up and running:
PORT     STATE SERVICE
53/tcp   open  domain
8080/tcp open  http-proxy
53/udp   open  domain

Is this suppose to work or do I have to manually derive an nginx image based on for example alpine-kubernetes? I think "my" approach would be more simple and it would allow me to use the vanilla nginx image. Do you know if this should work or what I could be doing wrong (if you think it's correctly configured then it might be an nginx issue and I'm of course not implying that you should help me out with that)?
I've also posted this question on stackoverflow.

Hi @johanhaleby,
Your pod spec should work the way you intended. Go-dnsmasq seems to return a SERVFAIL response. Can you add the --verbose flag to go-dnsmasq args in your spec and post the log?

@janeczku Thanks for your reply. I've now change the pod spec to:
- name: dnsmasq
  image: "janeczku/go-dnsmasq:release-1.0.5"
  args:
    - --listen
    - "<IP_ADDRESS>:53"
    - --default-resolver
    - --append-search-domains
    - --hostsfile=/etc/hosts
    - --verbose

since I tracked this down in a run script in alpine-kubernetes but it still won't work. Here's the log:
level=debug msg="Received DNS query for \"my-service.\" from \"<IP_ADDRESS>:45314\" with type 1"
level=debug msg="Querying nameserver <IP_ADDRESS>:53 question my-service.default.svc.cluster.local."
level=debug msg="Querying nameserver <IP_ADDRESS>:53 question my-service.svc.cluster.local."
level=debug msg="Querying nameserver <IP_ADDRESS>:53 question my-service.cluster.local."
level=debug msg="Querying nameserver <IP_ADDRESS>:53 question my-service.c.my-cluster.internal."
level=debug msg="Querying nameserver <IP_ADDRESS>:53 question my-service.google.internal."

Does this look ok?

I managed to solve this (with the new kubernetes pod specification) and when I disabled the ipv6 as resolver: resolver <IP_ADDRESS>:53 ipv6=off;
Thanks for your help!


Stop call to Get&rvl=reportStuff with reportID = undefined

Details
Weird thing I came across on dev that should be fixed. Noticed a 2 second call to Get&returnValueList=reportStuff that was being called with a  reportID of undefined and traced it to the IOU code. When we do not find an IOU reportID for any reason we are continuing to fetch the report. Which makes no sense + takes a significant amount of time to process.
Basically, we log this:
GetIOUReport returned a reportID of 0, not fetching IOU report data
And then go ahead and fetch it anyway which takes 2 seconds for some reason (production web server used)...

Fixed Issues
No issue. Just noticed on dev that this should be cleaned up.
Tests
QA Steps
Test IOU features for any possible regressions.
Tested On

[x] Web
[ ] Mobile Web
[ ] Desktop
[ ] iOS
[ ] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging         in version: 1.0.79-5🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production         in version: 1.0.80-2🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Add cfg illlumos in addition to solaris

I initially noticed this was broken when trying to install fd-find on OmniOS via cargo install fd-find.
illumos is its own distinct rust target now.  Building with rust-users on a platform such as OmniOS or SmartOS that uses the illumos target via rustup is currently broken.  Adding the proper cfg parameters fixes this.  Note I chose to ignore the lint warning as it's not related to this change.
Test output:
link - rustdev ~/src/rust-users (git:illumos) $ cargo t
warning: trivial numeric cast: `u32` as `u32`
   --> src/base.rs:805:46
    |
805 |             .filter_map(|i| get_group_by_gid(i as gid_t))
    |                                              ^^^^^^^^^^
    |
note: the lint level is defined here
   --> src/lib.rs:4:9
    |
4   | #![warn(trivial_numeric_casts)]
    |         ^^^^^^^^^^^^^^^^^^^^^
    = help: cast can be replaced by coercion; this might require a temporary variable

warning: `users` (lib) generated 1 warning
warning: `users` (lib test) generated 1 warning (1 duplicate)
    Finished test [unoptimized + debuginfo] target(s) in 0.01s
     Running unittests (target/debug/deps/users-3fb7ce1dfa6464a5)

running 18 tests
test base::test::uid ... ok
test base::test::username ... ok
test base::test::username_for_uid_for_username ... ok
test mock::test::gid ... ok
test mock::test::group_name ... ok
test base::test::group_by_name ... ok
test mock::test::current_username ... ok
test base::test::uid_for_username ... ok
test base::test::user_by_name ... ok
test mock::test::no_current_username ... ok
test base::test::user_info ... ok
test mock::test::no_gid ... ok
test mock::test::no_group_name ... ok
test mock::test::no_uid ... ok
test mock::test::no_username ... ok
test mock::test::uid ... ok
test base::test::user_get_groups ... ok
test mock::test::username ... ok

test result: ok. 18 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests users

running 39 tests
test src/base.rs - base::User::groups (line 135) - compile ... ok
test src/base.rs - base::get_user_groups (line 768) - compile ... ok
test src/cache.rs - cache (line 47) - compile ... ok
test src/base.rs - base::group_access_list (line 731) - compile ... ok
test src/lib.rs - (line 102) - compile ... ok
test src/cache.rs - cache (line 11) - compile ... ok
test src/switch.rs - switch::set_both_gid (line 189) - compile ... ok
test src/switch.rs - switch::set_both_uid (line 158) - compile ... ok
test src/switch.rs - switch::set_current_gid (line 65) - compile ... ok
test src/switch.rs - switch::set_current_uid (line 34) - compile ... ok
test src/switch.rs - switch::set_effective_gid (line 127) - compile ... ok
test src/switch.rs - switch::set_effective_uid (line 96) - compile ... ok
test src/switch.rs - switch::switch_user_group (line 245) - compile ... ok
test src/base.rs - base::Group::new (line 185) ... ok
test src/base.rs - base::User::new (line 71) ... ok
test src/base.rs - base::all_users (line 845) ... ok
test src/base.rs - base::User::primary_group_id (line 116) ... ok
test src/base.rs - base::Group::gid (line 201) ... ok
test src/base.rs - base::get_current_gid (line 638) ... ok
test src/base.rs - base::User::name (line 101) ... ok
test src/base.rs - base::get_effective_uid (line 594) ... ok
test src/cache.rs - cache::UsersCache::with_all_users (line 174) ... ok
test src/base.rs - base::get_current_uid (line 547) ... ok
test src/base.rs - base::Group::name (line 215) ... ok
test src/base.rs - base::User::uid (line 87) ... ok
test src/cache.rs - cache::UsersCache::new (line 155) ... ok
test src/base.rs - base::get_current_username (line 571) ... ok
test src/base.rs - base::get_group_by_gid (line 433) ... ok
test src/base.rs - base::get_effective_username (line 615) ... ok
test src/base.rs - base::get_effective_gid (line 682) ... ok
test src/base.rs - base::get_current_groupname (line 659) ... ok
test src/lib.rs - (line 77) ... ok
test src/base.rs - base::get_user_by_uid (line 318) ... ok
test src/mock.rs - mock (line 19) ... ok
test src/lib.rs - (line 43) ... ok
test src/base.rs - base::get_effective_groupname (line 703) ... ok
test src/base.rs - base::get_user_by_name (line 371) ... ok
test src/base.rs - base::get_group_by_name (line 486) ... ok
test src/mock.rs - mock (line 41) ... ok

test result: ok. 39 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.84s

@ogham is it possible to get this merged in so we no longer need to have a patched rust-users for fd-find?

Ping here for my metadata agent work @ogham

This now block the installation of cargo-make

Hi @ogham, could we get this pull requested integrated and a new version released?  Various downstream crates depend on it, and we'd really really like to get it working on illumos systems.  Thanks!

Since this project is unmaintained, I forked to https://github.com/gierens/uzers-rs where I for example merged this PR and maintain it from now on. It's also available in v0.11.1 on https://crates.io/crates/uzers

@gierens Thank you I'll have a go at bringing it to projects that I get build errors from.


JIRA review

Readiness

[ ] Merge (pending reviews)
[ ] Merge after date or event
[ ] Draft

Overview
This includes information for imx8mn, customer feedback and general improvements.
Checklist
Optional. Add a 'x' to steps taken.
You can fill this out after opening the PR. "Did I..."

[ ] Run spelling and grammar check, preferably with linter.
[ ] Avoid changing any header associated with a link/reference.
[ ] Step through instructions (or ask someone to do so).
[ ] Review for wordiness
[ ] Match tone and style of page/section.
[ ] Run make linkcheck.
[ ] View HTML in a browser to check rendering.
[ ] Use semantic newlines.
[ ] follow best practices for commits.

[ ] Descriptive title written in the imperative.
[ ] Include brief overview of QA steps taken.
[ ] Mention any related issues numbers.
[ ] End message with sign off/DCO line (-s, --signoff).
[ ] Sign commit with your gpg key (-S, --gpg-sign).
[ ] Squash commits if needed.

[ ] Request PR review by a technical writer and at least one peer.

Comments
Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

Docs for fb308be61b1ffceb19de49aa31c2145b67efec7e are browsable at: https://ci.foundries.io/projects/fio-docs/builds/1691/docs/artifacts/html/index.html

We can ignore the link-check error, it's due to an external link not being available, which I will be investigating and likely patching.

@vanmaegima, can you provide more information on what this PR addresses? And is it to be merged pending reviews? Thank you in advance and sorry for any trouble.

@kprosise this covers some open items we had on jira. I've applied your suggestions.

Docs for 120361fac55b1e108b987d14cb0727d1a36d93c3 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/1695/docs/artifacts/html/index.html

After the remaining conversation is resolved, we can go ahead and merge.

@vanmaegima, are we ready to merge? It looks like we are still waiting on another review, but all seems good on my end.

@kprosise let's go ahead and merge, thanks for the reminder


Expose assert.not_error to tests

assert.not_error is documented as an available assertion and is implemented, it just hasn't been exposed to the testing context. This exposes it and adds a test.
Thank you!

Just noticed https://github.com/ysugimoto/falco/pull/368 was merged so I must have had a stale branch. Keeping it open in case you'd like to merge the test, otherwise fine to close.


IdentityServer4.AccessTokenValidation - Access token not propagating via JwtBearerEvents::OnTokenValidated

We have been successfully using IdentityServer4.AccessTokenValidation 2.1.0 with our .NET Core 2.0 web api.  New requirement was recently added to store the validated access token as a claim on the current ClaimsIdentity so API1 can call API2 under the same jwt user context.  Added the following code to the identity server options to handle this but doesn't seem to work as the ClaimsIdentity does not have a "access_token" claim.   Please let me know if I wired this up incorrectly in API code:
 // Register Authentication
            services.AddAuthentication("Bearer")
                //From https://github.com/IdentityServer/IdentityServer4.AccessTokenValidation (nuget)
                .AddIdentityServerAuthentication(options =>
                {
                    options.Authority = Configuration["IdentityServer:Authority"];
                    options.RequireHttpsMetadata = false;
                    options.ApiName = "API1";

                    //We need to be able to retreive the authenticated token so we can use it to call api2
                    //https://www.jerriepelser.com/blog/aspnetcore-jwt-saving-bearer-token-as-claim/
                    options.Events = new JwtBearerEvents()
                    {
                        OnTokenValidated = tvContext =>
                        {
                            Console.WriteLine("*** OnTokenValidated callback.");
                            // Add the access_token as a claim
                            var accessToken = tvContext.SecurityToken as JwtSecurityToken;
                            if (accessToken != null)
                            {
                                ClaimsIdentity identity = tvContext.Principal.Identity as ClaimsIdentity;
                                if (identity != null)
                                {
                                    identity.AddClaim(new Claim("access_token", accessToken.RawData));
                                }
                            }

                            return Task.CompletedTask;
                        }
                    };
                });

Think I may have figured this out (at least in IdentityServer4.AccessTokenValidation 2.1.0).
Looks like you have to set options.JwtBearerEvents rather than options.Events...
  options.JwtBearerEvents = new JwtBearerEvents()

I came across this issue a couple of times but my OnTokenValidated method was never called. My solution was not use JwtBearerEvents but OAuth2IntrospectionEvents because I use token introspection. Took me a couple of hours to figure this out so thought to leave my solution here for someone else.


Update upgrade.md

Proposed changes

Unreleased project version (optional)

Related issues (optional)

Can you give a bit more context into what you're trying to achieve?
Are you adding this note because previous versions of UCP allowed the TLS connection to be downgraded to TLS 1.1, and you want to make sure users know that they can configure UCP to never downgrade the UCP connection?
If that's the case why did you chose to add that information as a note that's part of the upgrade process? Is it because when you upgrade from a previous version, UCP won't use the new default (force TLS connections to a 1.2)?

Ping @lenestopage for a reply, otherwise we'll close this contribution due to inactivity.

I'm closing this one due to inactivity 😢


display human readable PlayerID

Is your feature request related to a problem? Please describe.
The new queue functions assigns a uuid to the player. It is unique but hard to read. Therefore identification of the player can be difficult.
Describe the solution you'd like
Instead of showing the uuid of the player in the user interfaces (driver ui, staff ui), these uuids could be mapped to simple player numbers (Player 1, Player 2, ...) as an alias attribute in the vehicle object, when a player leaves and a new one joins, he get the smallest available player number.
Describe alternatives you've considered
Alternative to numbers (funny) generative player names could be displayed.
Additional context

To be defined with stakeholder if player numbers or funny generic names as alias.

not completed in Release_v2.1.0 -> has to be planed -> set to 'no milestone'

Change Information popup to "You are currently ..."


Set initial sort order of DataTable based on initialSortColumn and initialSortDirection props

Closes #3951
Note
I spotted the above issue and thought I'd take a look at the implementation. This is my first contribution to this repo and I hope I'm not treading on any toes by picking this up and raising a PR! I was keen to have a look at how the design system was structured, as well as how the tooling worked, and I thought picking up an issue would be a good way to dig into that. Again, hope you don't mind this PR out of the blue! 🙂

Changelog
This PR modifies the behaviour of the initialSortColumn and initialSortDirection props of the DataTable component. Previously, I believe they were only used to describe the sorting of the intial data provided by the implementor. Now, they can be used to set how the initial data should be sorted.
Eg, if the DataTable is rendered as follows:
<DataTable
  data={[
    { id: 1, fieldOne: 'a', fieldTwo: 'c' },
    { id: 2, fieldOne: 'b', fieldTwo: 'b' },
    { id: 3, fieldOne: 'c', fieldTwo: 'a' },
  ]}
  columns={[
    {
      header: 'Field One',
      field: 'fieldOne',
      sortBy: true
    },
    {
      header: 'Field Two',
      field: 'fieldTwo'
    },
  ]}
  initialSortColumn="fieldOne"
  initialSortDirection="DESC"
/>

Then the rendered table will now be sorted like this:

Field One ↓
Field Two

c
a

b
b

a
c

Note that the sorting of the resulting table is different to the sorting of the provided data, as the sorting is now defined by the initialSortColumn and initialSortDirection props. Previously, the table would be sorted in the same way as the initial data regardless of what initialSortColumn and initialSortDirection were set to.
Since I've modified the implementation and removed the manual tracking of rowOrder and prevData in favour of recalculating the sorted data any time the data, columns, and sortByColumns props change, I'd recommend that the implementor memoizes columns and data before passing them into the DataTable component. This could be seen as best practise anyway, but it might be worth documenting it explicitly. How/where would you recommend documenting this?
This may not be the direction you want to go with these props (in which case let me know what the desired behaviour should be and I'll modify the PR appropriately) however this seemed to match the desired functionality described in #3951
Changed

initialSortColumn and initialSortDirection props now set the initial sort state of the DataTable component.

Rollout strategy

[ ] Patch release
[x] Minor release
[ ] Major release; if selected, include a written rollout or migration plan

Testing & Reviewing
Modify the initialSortColumn and initialSortDirection props in the DataTable component's Playground story and hit the remount button in the top left. Note that when the table mounts, the sort order should match the specified column and direction.
Merge checklist

[x] Added/updated tests
[x] Added/updated documentation
[x] Added/updated previews (Storybook)
[x] Changes are SSR compatible
[x] Tested in Chrome
[x] Tested in Firefox
[x] Tested in Safari
[x] Tested in Edge
[ ] Integration tests pass at github/github (Learn more about how to run integration tests)

⬆ This isn't something I have access to.
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Hey @joshfarrant! 👋 Just wanted to say thanks so much for taking the time to make this Pull Request 🙌 We appreciate it so much.
When looking at the proposed changes and the description you wrote out, one thing that stood out is that I do think we want to preserve the existing behavior where folks have the option to memoize, or not, when passing in props like data and columns. Additionally, if folks only provided a stable reference for one of these (like data) then a goal was to not cause a re-render if the other prop, in this case columns, did not have a stable reference.
This is where the existing setup came from to try and satisfy these scenarios and it'd be great if we could continue to support those, if possible 👀 Would love to hear what you think, and just wanted to say thanks again for taking the time to do this!


Select by value

Hello,
Thank you very much for your great work!
How can we select an item of a listbox ?
I previously used SeleniumBasic https://github.com/florentbr/SeleniumBasic that implemented a WebElement's method AsSelect.SelectByValue for this usage.
Thanks for your help.

I would do something like
driver.FindElement(By.TagName, "[value='my_val']").Click

Hello,
Thank you very much.
Finally I used the method SendKeys with the expected value and it works.


unify approach to Power On

Use Power Supply keywords from osfv_cli libs
Unify Power On keywords in include/default.robot in a for of "Power On Default" keyword, as most of them looked more or less identical
Platfom configs can choose to use this keyword as Powe On, or define platform-specific one as before

Tested following platforms via the
BPS001.001 from util/basic-platform-setup.robot:

protectli-vp2410
protectli-vp2420
protectli-vp4630
protectli-vp4670
protectli-vp6670
pcengines-apu2
msi-pro-z690-a-ddr5
odroid-h4-plus
minnowboard-turbot
optiplex-7010

Generally looks good. Also looked at changes on the osfv-scripts side.
Finally proper use of DEFAULT_POWER_STATE_AFTER_FAIL :) Just one thing that bothers me a little is this Telnet buffer clearing.


simplify syntax

instead inventing new blocks, use the code fence language:
$$
    x = {-b \pm \sqrt{b^2-4ac} \over 2a}.
$$

    ```math
        x = {-b \pm \sqrt{b^2-4ac} \over 2a}.
    ```

%%
sequenceDiagram
    participant Alice
    participant Bob
    Alice->>John: Hello John, how are you?
    loop Healthcheck
        John->>John: Fight against hypochondria
    end
    Note right of John: Rational thoughts<br/>prevail...
    John-->>Alice: Great!
    John->>Bob: How about you?
    Bob-->>John: Jolly good!
%%

    ```mermaid
    sequenceDiagram
        participant Alice
        participant Bob
        Alice->>John: Hello John, how are you?
        loop Healthcheck
            John->>John: Fight against hypochondria
        end
        Note right of John: Rational thoughts<br/>prevail...
        John-->>Alice: Great!
        John->>Bob: How about you?
        Bob-->>John: Jolly good!
    ```

I do correctly working on change mermaid support to use the example you given. When it comes to LaTeX I will soon update it to use MatchJax standard


How to make the templates.npy for 133joints?

I have one question about the './data_extra/bone_length_npy/hm36s15678_bl_templates.npy'.
The shape of ndarry is [5,15]. what's the meaning of it? why the row is 5?
Another question, i want to apply PoseAug on coco-wholebody dataset (133 keypoints).
Do you have some suggestions about this?
Thanks in advance and look forward for your suggestion.

Hi, thank you for the interest.

I have one question about the './data_extra/bone_length_npy/hm36s15678_bl_templates.npy'.
The shape of ndarry is [5,15]. what's the meaning of it? why the row is 5?

5 means 5 subject(person), S1 S5 S6 S7 S8,

Another question, i want to apply PoseAug on coco-wholebody dataset (133 keypoints).
Do you have some suggestions about this?

If coco-wholebody dataset 2D or 3D? if 2D, you can extract the 2D keypoint convert into same definiation as H36M as 2D target dominain.


feat: Make sure asyncapi: 2.5.0 is mentioned in all docs

Description

I have changed the asyncAPI version from 2.4.0 to 2.5.0 at all the possible places in docs in the form of text files, yaml files or reference links. Please request the changes if required. Thank you.

Related issue(s)
Resolves #998

@toukirkhan please have a look at message from bot and improve PR title accordingly -> https://github.com/asyncapi/website/pull/999#issuecomment-1265737897

@derberg Lint PR title is failing please help me.

@derberg thanks I made the changes.

@derberg can you please get my PR merged?

rtm

@toukirkhan, patience 😄 we need the approval of @alequetzalli that is a codeowner for markdown files

@derberg okay sirrr!!! :))

Thank you so much @alequetzalli would be making more contributions further. Is my PR about to get merged?

@all-contributors please add @toukirkhan for docs

@derberg thank you so much for this it feels so great!

@toukirkhan no worries. Feel free to lemme know if you want link to more good first issues. Also feel free to join community for longer here -> https://asyncapi.com/slack-invite

@toukirkhan no worries. Feel free to lemme know if you want link to more good first issues. Also feel free to join community for longer here -> https://asyncapi.com/slack-invite

For sure @derberg


feat(pre-commit): add pre-commit

Codecov Report
Patch and project coverage have no change.

Comparison is base (7f27d25) 90.76% compared to head (c32c23f) 90.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #44   +/-   ##
=======================================
  Coverage   90.76%   90.76%
=======================================
  Files          31       31
  Lines        2188     2188
=======================================
  Hits         1986     1986
  Misses        202      202

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


class Mix_ImageEncoderViT BUG

Hello, thank you very much for your open source code, but during the running process, I found whether there are bugs in class Mix_ImageEncoderViT, that is, med_attn_matrix will only have block 3, 6, 9, but not 5, 8, 11, 4, 7, 10 through your code. This problem causes the code to not train properly, can you solve it?
        # med_feature_indexes=[2,5,8,11],
        # med_attn_matrix_indexes=[2,5,8,11],
        # attn_weight_indexes=[3,6,9],

        for i,blk in enumerate(self.blocks):
            x,attn_matrix = blk(x)
            if i in self.med_feature_indexes:
                # [B,C,H,W]
                self.med_features["block_"+str(i)] = x.permute(0, 3, 1, 2)
            if i in self.attn_weight_indexes:
                # [B*N,K,K]
                self.med_attn_matrix["block_"+str(i)] = attn_matrix

        # ====Mutil Matrix to Token Weight====
        device = x.device
        batch_size = x.shape[0]
        attn_weight_11= torch.ones((batch_size,1,32,32),device=device)                 # [B,1,32,32]
        self.token_weight_dict["block_11"] = attn_weight_11
        attn_matrix_8 = (self.med_attn_matrix["block_11"].to(device) @ self.med_attn_matrix["block_10"].to(device)) @ self.med_attn_matrix["block_9"].to(device)
        self.token_weight_dict["block_8"] = self.matirx_to_weight(attn_matrix_8)     # [B,1,32,32]
        attn_matrix_5 = (self.med_attn_matrix["block_8"].to(device) @ self.med_attn_matrix["block_7"].to(device)) @ self.med_attn_matrix["block_6"].to(device)
        self.token_weight_dict["block_5"] = self.matirx_to_weight(attn_matrix_5)     # [B,1,32,32]
        attn_matrix_2 = (self.med_attn_matrix["block_5"].to(device) @ self.med_attn_matrix["block_4"].to(device)) @ self.med_attn_matrix["block_3"].to(device)
        self.token_weight_dict["block_2"] = self.matirx_to_weight(attn_matrix_2)     # [B,1,32,32]

        return self.med_features, self.token_weight_dict

These code bugs have been addressed.


Hydration Mismacth from NextThemesProvider: Warning Extra attributes form the server: class, style...

From kirimase created by gaurangrshah: nicoalbanese/kirimase#168
Config File
{
  "hasSrc": false,
  "packages": [
    "shadcn-ui"
  ],
  "preferredPackageManager": "pnpm",
  "t3": false,
  "alias": "@",
  "analytics": true,
  "rootPath": "",
  "componentLib": "shadcn-ui",
  "auth": null
}

Describe the bug
I am not sure if this is true for others, but I've seen this hydration warning in every project I've scaffolded with kirimase so far. I've been meaning to track down the bug and finally got some time.
Seems the NextThemesProvider is causing the hydration mismatch. The fix I found for it was to dynamically import the component and seems to work on my end. Wanted to share the solution for anyone else facing the same issue. Here's my the commit from my repo where I made the change.
Expected behavior
Should not cause hydration issues on a new scaffold.
Screenshots

Desktop (please complete the following information):

OS: [MacOS Sonoma]
Browser [arc, safari]

As per this convo I dug a bit deeper.

From what I understand this is try this does opt the entire tree below this point which is the entire application. So this made me look for a diff solution, which I found on the next-themes github issue.
Simply adding the suppressHydrationWarning prop at least disables the message. The prop gets added to the html element in layout.tsx:
export default function RootLayout({
  children,
}: Readonly<{
  children: React.ReactNode;
}>) {
  return (
    <html lang="en" suppressHydrationWarning> {/* add the prop here */}
      <body className={GeistSans.className}>
        <Providers>
          <ThemeProvider
            attribute="class"
            defaultTheme="system"
            enableSystem
            disableTransitionOnChange
          >
            {children}
          </ThemeProvider>
        </Providers>
      </body>
    </html>
  );
}

An alternative to suppressing the hydration mismatch warning: the ThemeProvider can be loaded using next/dynamic.
const ThemeProvider = dynamic(
  () => import("@/components/ThemeProvider").then((mod) => mod.ThemeProvider),
  { ssr: false }
);

Reference: https://github.com/vercel/next.js/discussions/22388#discussioncomment-6329930


Performance is dramatically decreased After #1610

Current bug behaviour
I was very looked forward to #1605 and I upgraded flame to this.
But I found the performance Is Very slow after upgrade. (see videos at the end).
Android can check the performance at least but IOS cannot even see the app launches because it shutting down immediately after launched due to memory issue.
So I bisected what commit went wrong.
After some reverts, I found #1610  is the problem.
It is very normal at #1596 (commit hash 60df3b9f60f538fbad7a3d806f5d38262ab6d66c)
But after #1610 (b4ad498fe5488795deb2c2e098fcde357b448bf), It has dramatically slown performance.
I carefully assume that it has some memory leak and GCs constantly.
Expected behaviour
Fix the performance issue.
Flutter doctor output

[✓] Flutter (Channel stable, 2.10.5, on macOS 12.1 21C52 darwin-arm, locale ko-KR)
    • Flutter version 2.10.5 at /Users/lafity101/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5464c5bac7 (3 weeks ago), 2022-04-18 09:55:37 -0700
    • Engine revision 57d3bac3dd
    • Dart version 2.16.2
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
    • Android SDK at /Users/lafity101/Library/Android/sdk
    • Platform android-32, build-tools 32.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[✓] IntelliJ IDEA Ultimate Edition (version 2021.3)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.67.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.40.0

[✓] Connected device (3 available)
    • SM G977N (mobile)           •                • android-arm64  • Android 11 (API 30)
    • iPhone 12mini (mobile) •  • ios            • iOS 14.8 18H17

[✓] HTTP Host Availability
    • All required HTTP hosts are available

More environment information

Explained at the beginning

More information
Before #1610
https://user-images.githubusercontent.com/38072762/167560363-d8694ad2-ba53-4834-a860-847f6d0faf74.mp4
After #1610 - I didn't manipulated video speed
https://user-images.githubusercontent.com/38072762/167560356-07333277-31c1-4165-ad43-e73f4635fc09.mp4

@nathanaelneveux must be the PictureRecorder that is being created?

@nathanaelneveux must be the PictureRecorder that is being created?

That does seem to be the case - I was able to replicate this by loading my test map x30 and then turning off and on the _generateAtlas code and there is a fps drop with it on.
I'm not sure the PictureRecorder can be made reusable since it's suppose to invalidate itself and the canvas it's attached to on endRecording() so it will probably need to be replaced?
At worse this shouldn't be too difficult to remake with a round trip through image.toByteData(). I had also looked at the image package when first working on this but didn't know how you all felt about adding another package?

https://github.com/flutter/flutter/issues/28912

But _generateAtlas only runs once, when the SpriteBatch is loaded -- how can it affect the performance? Unless it generates the image in some kind of inefficient format that needs to be recoded on the fly on every game tick...

But _generateAtlas only runs once, when the SpriteBatch is loaded -- how can it affect the performance? Unless it generates the image in some kind of inefficient format that needs to be recoded on the fly on every game tick...

It produces an Image but it doesn't currently cache it in Images

Just to put some numbers behind it - using test map x30:
• on 60df3b - FPS 21-23
• on b4ad49 - FPS 4-5
• with _generateAtlas reduced to
static Future<Image> _generateAtlas(Images? images, String path) async {
    final _images = images ?? Flame.images;
    final image = await _images.load(path);
    return image;
  }

FPS 20-24

In all cases once the spriteBatch has been loaded images are not recreated - _generateAtlas is not called again after the initial load.

Ok so I have a proof of concept _generateAltas that creates the new image with byte operations instead of a PictureRecorder and FPS on my test file is back over 20. I'll package this up into a PR tomorrow.
I'd like to add caching to this final atlas image since I could see situations where a tileset would be reused and so shouldn't be re-generated as a flipped image but I think I'll need some kind of Images.exists function as well since the image key wouldn't be based solely on the file path. I'll try tackling that in the PR as well.
I did rely heavily on this project for converting the raw image bytes back into a Image but I don't think adding that package will be an issue :)

I'd like to add caching to this final atlas image since I could see situations where a tileset would be reused and so shouldn't be re-generated as a flipped image but I think I'll need some kind of Images.exists function as well since the image key wouldn't be based solely on the file path. I'll try tackling that in the PR as well.

Coincidentally I think I fixed what you need in #1624?

I'd like to add caching to this final atlas image since I could see situations where a tileset would be reused and so shouldn't be re-generated as a flipped image but I think I'll need some kind of Images.exists function as well since the image key wouldn't be based solely on the file path. I'll try tackling that in the PR as well.

Coincidentally I think I fixed what you need in #1624?

Nice! That should work perfect

Can you test the updated PR @Hwan-seok?
It should be solved now. :)

My app shows blank game widget in the main branch. Edit: Removing FPSCounter solved this.

This sounds disturbing... What if you replace FPSCounter with FpsComponent or FpsTextComponent?

@st-pasha
It works after replacing it


new / try_new / new_unchecked

It's misleading to have new() call try_new().unwrap() since it obscures the lack of safety.
I'd propose we have a new_unchecked and new() Result<...> where unchecked can be used as an optimisation, otherwise the caller can explicitly call new().unwrap() and therefore it's obvious that it can panic.

We have mostly got rid of try_new.unwrap. I think we should enforce no random unwraps


3.1 release for Fedora

As you can see in the link below, there isn't yet a package for 3.1 for Fedora Linux.
https://bodhi.fedoraproject.org/updates/?search=godot
I offer to help in this stuff, but as the building package scripts are already done, It's likely to need just an update change for version and source files and rebuild it.
@akien-mga

I have a WIP but not finished yet, it's a bit more involved than a simple version bump as dependencies changed. I'd also like to use LTO if Bodhi won't run out of memory, and do a better server/headless split.

Fedora 31 has Godot 3.1.1: https://repology.org/project/godot/versions

For the reference, I now pushed Godot 3.1.2 to Fedora Rawhide (32), and 3.1.2 update candidates:

Fedora 30: https://bodhi.fedoraproject.org/updates/FEDORA-2020-bf7d3dce66
Fedora 31: https://bodhi.fedoraproject.org/updates/FEDORA-2020-908750ee0a
EPEL 7: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-036932ab82

They're currently pending, should be available for testing within ~24 hours at most, and eventually validated within a week or two. If you can test them on one of the above platforms and report back on Bodhi, this should help speed up the QA validation process.

Already made to updates repository.


Missing optional features

The project has not implemented two of the required optional features:

allow the user to specify the model to use with the --model or -m flag

allow the user to specify an output filename using --output or -o:

# output to stdout
tool-name ./file.js

# output is written to file1-modified.js
tool-name file1.js -o file1-modified.js

allow the user to optionally specify their API key using --api-key or -a and the base URL using --base-url or -u:

allow the user to create an [.env file] in the current directory and have your tool automatically use it to set the API Key, Base URL, and any other config options you want.

pick a few of the optional parameters you can set for chat completions (e.g., temperature) and allow the user to set them via command-line args or .env file

support streaming responses when writing to stdout.

come up with your own idea. If you have an idea not listed above, talk to your professor and see if it's OK to implement that (it probably is). #

added output and model option.


Update default to reflect new chromium enlistment layout

The default layout of a chromium enlistement has changed quite since the last time the defaults were updated.
See https://github.com/chromium/vs-chromium/issues/31#issuecomment-319760455

Looking at that file I can see other changes which should be made. Now that gn has replaced gyp the explicit references to Debug and Release directories don't make sense. It would be better to replace:
out/Debug/gen/webkit/bindings/
out/Release/gen/webkit/bindings/
with:
out/*/gen/webkit/bindings
except that that directory doesn't exist anymore so that I think what is actually wanted is:
out/*/gen/blink/bindings

Note: Source files containing defaults are:

ChromiumExplorer.ignore
SearchableFiles.include
SearchableFiles.ignore

Fixed


[Bug] [Gtk] MauiGtkApplication Application life cycle not working

Description
src/Core/src/Platform/Linux/MauiGtkApplication.cs
Gdk.Application life cycle broken
Expected Behavior
fire MauiGtkApplication.OnStartup(object sender, EventArgs args)
Actual Behavior
never fired
Basic Information

Platform Target Frameworks:

Linux mono .net48
Linux .net5

Nuget Packages:
"GtkSharp" Version="<IP_ADDRESS>"

Reproduction Link
https://github.com/GtkSharp/GtkSharp/issues/242

fired now, but Applikation.Quit() doesn't quit
message: (Controls.Sample.Linux:241132): Gtk-CRITICAL **: 05:27:28.990: gtk_main_quit: assertion 'main_loops != NULL' failed

works


[GLUTEN-2723][CH] Improve Broadcast Join performance -- Part 2

What changes were proposed in this pull request?
This is follow up of  #2725.  What I  found is that calling java method in c++ thread is quite slow, Let's move such call in jni thread.
(Fixes: #2723)
How was this patch tested?
Using Existed UT

While micro benchmark shows there is significant improvement, the end-to-end power test only reveals a slight improvement.

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_2986_time.csv
log/native_master_09_03_2023_bfa0d89f2_time.csv
difference
percentage

q1
43.66
43.51
-0.155
99.65%

q2
24.61
24.52
-0.090
99.63%

q3
36.89
36.96
0.072
100.19%

q4
41.45
41.79
0.344
100.83%

q5
68.30
69.61
1.303
101.91%

q6
6.34
6.64
0.301
104.75%

q7
84.44
83.68
-0.761
99.10%

q8
78.03
80.40
2.367
103.03%

q9
116.94
117.81
0.869
100.74%

q10
48.72
45.77
-2.950
93.95%

q11
19.06
19.08
0.022
100.11%

q12
23.36
25.00
1.635
107.00%

q13
51.35
49.28
-2.066
95.98%

q14
20.07
19.60
-0.472
97.65%

q15
29.60
30.68
1.084
103.66%

q16
15.49
16.03
0.547
103.53%

q17
121.25
119.63
-1.627
98.66%

q18
164.83
164.99
0.164
100.10%

q19
12.54
13.93
1.383
111.03%

q20
31.34
38.74
7.395
123.60%

q21
241.92
249.00
7.073
102.92%

q22
15.51
15.62
0.104
100.67%

total
1295.70
1312.25
16.543
101.28%


Add a clang-format style file.

Here is a draft of a clang-format style based on WebKit.
I propose to agree on a style and merge the .clang-format file without changing every single file immediately.
People editing with clang-format-capable editors will automatically check in formatted code when they work on a file.
After a while, when we are happy with the style it imposes, we can write a loop over all files and create a commit.
Four files have already been formatted using the draft style, see:

debug/debug.cpp and solution
or valgrind/debug.cpp and solution

In my experience (in both acceptations of the terms actually), this is more tricky than it seems, as the indentation will vary with versions of clang... Thus if you have locally a different version than I do, we'll fight about indentation. The consequence is that the indentation can only be enforced in the gitlab CI, which means that it should fail when indentation is not fine and give a URL where to download the diff that people will apply by hand locally before they force push... Really heavy, but the way we work in LHCb
Another possibility is of course to share a common version of clang, but then we have to take it e.g. from cvmfs which means that you lose the ability to work offline.
As I said, no so easy... Any strong feeling in which direction we should go ?

the indentation can only be enforced in the gitlab CI, which means that it should fail when indentation is not fine and give a URL where to download the diff that people will apply by hand locally before they force push...

Wow, this is exactly how LLAMA CI works :D :D I also implemented it the same way for alpaka and a few other projects. What does not work great is to push the clang-format changes to the branch from the CI. That fails sometimes.

Another possibility is of course to share a common version of clang, but then we have to take it e.g. from cvmfs which means that you lose the ability to work offline.

Hmm. I get my clang from LLVM's apt, so I have the newest version a day after it was released :) I have seen active projects at CERN still on clang-format 3.x something, because they agreed on a common version. So maybe let's not go there :)

As I said, no so easy... Any strong feeling in which direction we should go ?

For now I would do like @hageboeck said. Don't enforce it, but have a style file for new code or when we modify exercises. We can then fix the style at some point in the future and add a CI run. It's not too hard. And clang-format is mostly stable across versions now. I see like 1 of a few 1000 lines change whenever I upgrade. I think we can tolerate that.

And clang-format is mostly stable across versions now. I see like 1 of a few 1000 lines change whenever I upgrade. I think we can tolerate that.

You indeed have a point here. I see the same, which is clearly a drama with a project containing > 10M lines of code. but of course we are not in that case, so here it should not be too bad indeed. Let's try.


How to place buy/sell order for Ethereum?

Hi,
I was wondering how to place a buy/sell order for Ether. The docs say I can use this:
use Coinbase\Wallet\Resource\Buy;

$buy = new Buy([
    'bitcoinAmount' => 1
]);

$client->createAccountBuy($account, $buy);

What are the parameters I should put into the Buy object to buy Ether? And how can I pass more arguments into the call like in the API docs? https://developers.coinbase.com/api/v2?python#place-buy-order
Hope someone can help me out! :)

I think something like that
    $buy = new Buy();
    $buy->setAmount(new Money(0.05, 'ETH'));
    $buy->setPaymentMethod($paymentMethod);

bitcoinAmount is just a shorthand for
public function setBitcoinAmount($amount)
{
    $this->amount = new Money($amount, CurrencyCode::BTC);
}

Support for new currencies was added in version 2.6.0. Ensure you're running that version or newer, and if you're still seeing issues feel free to open a new issue. Thanks!


Notification error logging

When my notification service got unexpected error as result of handling Adyen request I got following error:
{
  "name": "ctp-adyen-integration-notifications",
  "hostname": "...",
  "pid": ...,
  "level": ...,
  "notification": [
    {
      "eventCode": "AUTHORISATION",
      "eventDate": "2021-09-02T14:36:37+02:00",
      "pspReference": "...",
      "success": "true"
    }
  ],
  "cause": {},
  "msg": "Unexpected exception occurred.",
  "time": "2021-09-02T12:36:37.592Z",
  "v": 0
}

What is easy to spot here is that I have almost no info what goes wrong.
The cause is {}.
https://github.com/commercetools/commercetools-adyen-integration/blob/fdb6c149b8007ef138cff7089e492a822e7fa64a/notification/src/utils/error-utils.js#L23-L26
I believe it's because the getErrorCause return entire error object instead of error.message or at least String(error).
When parsing the Error object is just parsed to {}.
Here the error is throwed:
https://github.com/commercetools/commercetools-adyen-integration/blob/master/notification/src/api/notification/notification.controller.js#L34
The issue here is to improve error handling, not to solve my specific case.

Hey @wiktor-obrebski  this is already in our backlog and we are working on it, thanks for reporting the issue to us.

Thank you.

Thanks again for reporting the issue, it is fixed on the latest release: https://github.com/commercetools/commercetools-adyen-integration/releases/tag/v9.0.3


Feature/fix bsd buidlot

Don't run recently merged mkl example if SVMLight is not available (as on the bsd build)

gnaaaaa

Ok, let's see what the buildbot says


Updated paired result datasets and reflow logic to maintain consistency

Summary

Updated paired result graph config objects, datasets and reflow logic in examples to maintain consistency.

Closes #211
Deployment Link

https://terra-graphs-deployed-pr-#.herokuapp.com/

Thank you for contributing to Terra.
@cerner/terra
@cerner/carbon

nit:

1-5: add pairedResult prefix for to the filenames for consistency
6: update disable to disabled

nit:

1-5: add pairedResult prefix for to the filenames for consistency
6: update disable to disabled

Updated here.


Social bookmarks and clickthrough

Pull Request Test Coverage Report for Build 75

24 of 27 (88.89%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.2%) to 87.45%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

browse/routes/ui.py
5
8
62.5%

Totals

Change from base Build 71:
1.2%

Covered Lines:
1763

Relevant Lines:
2016

💛  - Coveralls


Bump minio-go to latest version

Current minio-go version has issues with S3 compatible storages like Backblaze or Wasabi. This was fixed in https://github.com/minio/minio-go/pull/1980 .

I was unable to create a backport for 1.22. @manvalls, please send one manually. :tea:
go run ./contrib/backport 32156
...  // fix git conflicts if any
go run ./contrib/backport --continue


AngularJS, JSLint => block-comment spaces

JSlint has a problem with bock comments without spaces. So how about adding a trailing/leading space to thecomment chars?!
// defaults to C based comments
let commentStart = '/* ';
let commentEnd = ' */';

Hi @iGadget73, sorry about the delay...
I tried JSLint and didn't have any problem. And I didn't find reference to this in their documentation. Maybe the problem has been fixed on the JSLint side since you posted? Do you still use the package and have the problem?
Thanks.

Hello @whoisthecoon, I think this has to do with the specific JSLint config that @iGadget73 is using.
I have the same problem, a linter configuration which requires newlines.
I propose a configuration parameter to let the users choose their commenting style, would that be possible?
Thanks!

Hi @caesarsol thanks for replying.
I fixed @iGadget73's problem by adding a checkbox in the package settings to tell whether you want to add spaces. But then I noticed you need new lines...
So I changed the config param to a selectbox, you can now choose between spaces, new lines or nothing (which is the default value).
I hope it solves the problem.

Hey @whoisthecoon that is wonderful! I'll try it when I upgrade.
Thanks a lot!!


No '/' in numeric keyboard for date_range_picker_dialog in Android Samsung S9 device

Steps to Reproduce

Use the date_range_picker_dialog (code below)
Install the app in Samsung S9 device.
Open the date picker in the app and switch to the manual entry type view.
You will notice that there is no '/' key in the keyboard to enter the character which is required for putting the date. Also, this character does not show up automatically on entering characters.

showDateRangePicker(
                context: context,
                initialDateRange: DateTimeRange(start: DateTime.now().subtract(Duration(days: 7)), end: DateTime.now()),
                firstDate: DateTime.now().subtract(Duration(days: 396)), //13 months
                lastDate: DateTime.now(),
                saveText: 'Done',
                helpText: 'Selected Range',
              )

Expected results:
The numeric keyboard should have '/' key.
Actual results:
The numeric keyboard does not have '/' key.

Hi @deviserRahul
Can you please provide:

flutter doctor -v

flutter run --verbose

This issue was reproducible with latest stable channel on a Samsung S10 device and not reproducible with Pixel 3a API 30.

 flutter doctor -v
Flutter 1.20.2 • channel stable • https://github.com/flutter/flutter.git
Framework • revision bbfbf1770c (15 hours ago) • 2020-08-13 08:33:09 -0700
Engine • revision 9d5b21729f
Tools • Dart 2.9.1
Running flutter doctor...
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 1.20.2, on Mac OS X 10.15.2 19C57, locale en-US)
[!] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    ✗ Android license status unknown.
      Try re-installing or updating your Android SDK Manager.
      See https://developer.android.com/studio/#downloads or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions.
[✓] Xcode - develop for iOS and macOS (Xcode 11.6)
[✓] Android Studio (version 3.6)
[✓] Connected device (1 available)

CC @darrenaustin

This a duplicate of #62401. Closing this issue as we will track it on the other. Thanks for the report!


Error message should throw if "To" time is less than "From".

Bug report
Title
Error message should throw if "To" time is less than "From".
Issue Description
Error message should throw if "To" time is less than "From".
Preconditions
1. framework Version.-master

Steps to reproduce
1. step1- Create a booking product and add To time less than from.
2. step2- Check the added time in frontend.

Expected result
Error message should throw on saving the product.
Actual result
Product gets saved but on frontend customer not able to select date

Hi,
Instead of reload the same page again, when "To" time is less than "from", we should show the warning while click on save button.
https://prnt.sc/rmcth7


bug(MatDialogRef): updatePosition is not consistent for previously dragged dialog

Reproduction
The updatePosition() doesn't seem to be consistent if the dialog is previously dragged.
It is my understanding, according to the documentation that updatePosition({bottom: '5px', right: '0px'}) will place my dialog at the bottom right of its container (cdk-overlay-container if I'm right ?).
Here is a forked StackBlitz from the documentation with, of course, minor changes.
With it, please:

open the dialog
click on the "minimize" button next to the title (dialog goes to the bottom right of the screen as expected : 👍 nice).
click on the "maximize" button next to the title to get the dialog back to it initial place. Also 👍 nice.

so far so good !

drag the dialog downwards (or in any direction you want) generously and minimize it again.

Expected Behavior
The dialog should be at the exact same place as it was after step 2.
Actual Behavior
The dialog's position has been updated, but with an additionnal translation.
(That additionnal translation seems to be of the same length as the previous drag.)
Worst : you can get the dialog outside of the screen if your drag was too generous, preventing you from dragging it back on visual.
Environment

Angular: 9.1.7 (but discovered and reproduced in 7.3.4)
CDK/Material: 9.2.4 (but discovered and reproduced in 6.4.1)
Chrome 83.0.4103.61 64bits
Windows 10 64bits

I think the problem here is that drag&drop and the dialog don't know about each other so updatePosition won't know to clear the previous position and the dragging directive won't know that the position was cleared. You could tell the dragging directive that the position is being cleared through the cdkDragFreeDragPosition input, although that's not super convenient.

Ok thanks for the tips, I'll try that.
If it can bring me a work around I'll take it !
Do you think it would be safe to handle the drag as it is in my stackblitz but minimize and maximize with only pure CSS and DOM manipulation ?

HI
I also have a similar problem.
How did you manage in the end?

HI I also have a similar problem. How did you manage in the end?

I quit the job, but technically, we had to figure out an other UX way to do what we wanted.
I didn't code in Angular anymore. So I unfortunately have no insight if a newer version correct the issue, sorry.

The solution/suggestion provided by @crisbeto was insightful. There definitely is an issue with managing position of dialogs that utilize the drag-drop module. I tried applying position updates via the position strategy (specifically, using a GlobalPositionStrategy and the DialogRef.updatePosition() method), however, that did not work - it resulted in my dialog jumping across the screen after being dragged again. I then tried several other combinations of methods with no avail.
My only success came after stumbling across this issue and seeing the suggestion to use the cdkDragFreeDragPosition input. This worked pretty nicely, although not ideal. Here is a StackBlitz of my working solution. In the example, the dialog remembers it's last position and is prevented from being dragged off screen.


Update README.md

Add Windows to the CI list.  This is different in that it is hosted on Azure, but, we can at least monitor the build status.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

CC: @shahmishal @Rostepher @tkremenek

@swift-ci please smoke test

@compnerd We would like to use this list for nodes on ci-external.swift.org. Can you add a node to ci-external.swift.org?

@shahmishal - I think that its still going to be a while (as that requires moving over build-script-impl into python.  In the mean time, it would be nice to make it easier for others to see the current state.

@compnerd We can setup the job by converting yml file into Jenkins job. So, we are not blocked on build-script-imple.
I can help create a new script which would handle this build.

That sounds great to me @shahmishal!  How would we setup the connection?  AIUI, these agents wouldn't be able to accept the SSH connection as they are Windows hosted.  @drodriguez would be able to help get the machines into the cluster though.

To be clear, the SSH connection should be possible, but I might need a little more time to figure out the setup and it will be a trial and error. I found a way to install an SSH server and direct it to cmd.exe some months ago. But I don’t know if the SSH plugin being used will like cmd.exe.

@drodriguez If it makes it easier, we can meet up (online or in person) and get this working.

@shahmishal: glad to meet up. Let's move this conversation to better medium, though. I will send you an email explaining the setup. Cheers!

This is now merged.


Fix Bazel build instructions

See https://groups.google.com/d/msg/grpc-io/ljBk9Z_QyuQ/3i-obzb3CAAJ

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.
After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

User @kerrick-lyft isn't covered by a CLA. They will need to complete the form at https://identity.linuxfoundation.org/projects/cncf

Regards,
CLA GitHub bot

@ncteisen @hcaseyal @carl-mastrangelo @mehrdada could I get a review on this?

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences


Add styles to the clear button

Design is nice. But, I find it very hard to locate it.
Try be make it bigger and show it like a button.

May be reduce the opacity when hover over it.
May be add a tooltip showing "Clear Log Messages" or similar.

I'll close this for now. I thought there'll be more buttons around there.

Okay.


Curl cookies

Parse curl Set-Cookie header to enable verification of cookie attributes. This should address issue #101

Looks good to me. Do we need to change any tests?

lgtm

I don't believe any tests need to change. Running rake test and cucumber both appear to be green.

@blischalk yeah was just thinking if we need to update any of the curl-based tests


Error in 0.4.7 relase

tiny error in the 0.4.7 released!  you forgot to update "run.sh" and "run.bat" to 0.4.7 !-)
Thanks for all the hard work!

thanks for the hint, fixed it.


Issue with miot_mccgq02hl

I  got issue with integrating binary sensor miot_mccgq02hl:
 File ".esphome\external_components\d5822579\components\miot_mccgq02hl\binary_sensor.py", line 10, in <module>
    from .. import miot  # pylint: disable=relative-beyond-top-level
  File ".esphome\external_components\d5822579\components\miot\__init__.py", line 23, in <module>
    from .. import xiaomi_account  # pylint: disable=relative-beyond-top-level
  File ".esphome\external_components\d5822579\components\xiaomi_account\__init__.py", line 13, in <module>
    from .xiaomi_account import XiaomiAccount
  File ".esphome\external_components\d5822579\components\xiaomi_account\xiaomi_account.py", line 12, in <module>
    class XiaomiAccount:
  File ".esphome\external_components\d5822579\components\xiaomi_account\xiaomi_account.py", line 17, in XiaomiAccount
    servers: list[str],
TypeError: 'type' object is not subscriptable←[0m

(esphome 2022.8.3)

Look like something wring with python environment. Please provide the config and environment in which you are building it. At this moment all components are tested with 2022.9.x and Python 3.9.2

Thank you for giving me a pointer to update my Python from 3.8 to latest 3.10.2 - now it works again!


Confirmed validator bug

Versions:

VueJs: 2.3.3
Vee-Validate: 2.0.0-rc.5 & 2.0.0-rc.3
Vuetify: 0.12.1

Description:
When enable the blur for validate, required error will show when the confirmed field lose focus.
Steps To Reproduce:

add a field 'password', the v-validate='required '
add a field 'repassword', the v-validate='required|confirmed:password'
other code related added....
run and input password: 123456
input repassword: 123456, no problem here
[Bug#1 for all versions]: change password to 1234567, the repassword shows required error message.
[Bug#2 in 2.0.0-rc.3 and 2.0.0-rc.5, no problem in 2.0.0-beta.25]: anytime password lose focus, the repassword required error message will be shown

codepen test for it: https://codepen.io/iwilsonwu/pen/mmZJoo

vuetify-veevalidate.zip

I suspect because it either can't resolve the component's value or because data-vv-value-path is not specified, or both.
I will investigate and report back when I can.

Thanks for your reply, I think the 2nd bug you can fix now, because in the 2.0.0-beta.25 no such bug and rc version has.

@wilsonwu Can you confirm if this issue is closed by RC.6 It seems fixed in the example given.

@logaretm
I just installed RC.6 and validation is not working, but it is working in 2.0.0-beta.25

@jernejrostan Can you create a separate fiddle for it?


Keyboard control of dropdown with input is not working

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
If you wrap an input with dropdown, the UP/DOWN control of dropdown-items is no longer working.
It was working fine on 5.1.3.
Reduced test cases
https://waetie.stackblitz.io
What operating system(s) are you seeing the problem on?
macOS
What browser(s) are you seeing the problem on?
Chrome, Safari, Microsoft Edge
What version of Bootstrap are you using?
5.2

Found out that you have a unit test "Dropdown data-api should ignore keyboard events for s and s within dropdown-menu, except for escape key FAILED".
What is the reason for that? Why do you ignore UP/DOWN for inputs?

Talking about this line... https://github.com/twbs/bootstrap/blob/337068f8b1044004f4b9abfffbb433694ae87993/js/src/dropdown.js#L391

They won't fix this https://github.com/twbs/bootstrap/issues/36598


Fixed broken link

R for Data science link for lists was updated

xref https://github.com/galaxyproject/training-material/issues/2078


Urdu translations can be cleared

I had been putting translations in the "Undetermined" locale while I was waiting for the Punjabi (Pakistan) locale to become available on Weblate. As of today, it is available, and I have copied over all my translations from Urdu to the correct code.
Sorry if I caused any confusion by not explaining this, I was just excited to get a head start. A lot of Urdu speakers also speak Punjabi so it wasn't a bad idea to put them there. Now that the proper locale is available though, Urdu should be cleared so someone who  knows Urdu can do that translation

Thank you, removed the Urdu language.


wanted: io_grpc_grpc_java

Module location
https://github.com/grpc/grpc-java
Link to bzlmod issue in the module's repository
https://github.com/grpc/grpc-java/issues/9559

Do we really need grpc-java as a Bazel module, or should Bazel users just fetch the jar dependencies via rules_jvm_external?

It has the java_grpc_library rule which exposes a protoc plugin in that repo.

Another resolution for this is to relocate the java_grpc_library rule to somewhere like rules_java or contrib_rules_jvm - it doesn't seem like maintainers on grpc/grpc-java are excited to continue providing Bazel rules from there, and I think they probably shouldn't be maintaining any. @shs96c will know what to do :)

Yes, I would also like to see the Bazel APIs to be moved out of grpc-java if they are not getting well maintained there.

Do you have a recommendation of which one? None of them are canonical and last time the SIG touched this in https://bazel-contrib.github.io/SIG-rules-authors/proto-grpc.html we just made a spreadsheet because things were so confusing.

it doesn't seem like maintainers on grpc/grpc-java are excited to continue providing Bazel rules from there

I am currently keeping the rules roughly in-sync with those inside Google for Blaze. The story may be different for other languages, but for Java there's been no change to the rule support.
Bzlmod is a different discussion. It looks invasive and a repeated cost as we make releases. So it would take some concerted effort to figure out what the heck is going on and what will be necessary going forward. We accept PRs for new stuff, and maintain what is there already. A PR isn't a sure win, but it generally does make things more clear as to what is going on. I don't see the point of forking if you haven't tried a PR upstream yet.

Do we really need grpc-java as a Bazel module, or should Bazel users just fetch the jar dependencies via rules_jvm_external?

Given you would still need the protoc plugin, which is a native C++ binary, I don't think rules_jvm_external is much of a solution. You would still need the cc_binary from the grpc-java repository.

Do we really need grpc-java as a Bazel module, or should Bazel users just fetch the jar dependencies via rules_jvm_external?

I've been maintaining a private fork implementing pretty much this concept. I had a completely different reason to do this: the WORKSPACE idioms recommended by grpc-java include overriding certain Maven dependencies with built-from-source versions (IO_GRPC_GRPC_JAVA_OVERRIDE_TARGETS). It seems these overrides do not participate in coursier's version resolution but override whatever version does get resolved (even if newer), which can lead to incompatible JARs being used. By plumbing grpc-java version information down into coursier, I was able to convert what had been a recurring, difficult to diagnose, runtime error into a much clearer pinner-execution-time error. Or often, it just selected compatible versions and there were no errors. The information necessary to do proper version resolution is also sufficient to pull the JARs from Maven Central, so there was not much point continuing to build them from source after that.
A few subtle things I learned from this exercise:

Public build targets under @io_grpc_grpc_java need to be maintained. Other code expects to reference into it (e.g. grpc-kotlin does). This can be achieved by setting up alias rules.
It is likely best to continue adding all grpc-java artifacts to the maven_install call rather than just those strictly necessary at runtime by generated code; grpc-java JARs have exact-version constraints among themselves and coursier is not always smart enough to pick the same version for all of them (e.g. if it wasn't told about certain packages explicitly).

While not a bzlmod module today, I think it would be pretty trivial to convert what I have into one - aside from the ruleset it just references prebuilt assets from Maven Central.

Given you would still need the protoc plugin, which is a native C++ binary, I don't think rules_jvm_external is much of a solution. You would still need the cc_binary from the grpc-java repository.

There are prebuilt versions of the protoc plugin on Maven Central; I believe the Maven protobuf plugin uses them. I've been pulling them in my WORKSPACE file using http_file:
http_file(
    name = "protoc-gen-grpc-java-{platform}".format(platform = platform),
    executable = True,
    sha256 = sha256,
    urls = [
        "https://repo1.maven.org/maven2/io/grpc/protoc-gen-grpc-java/{version}/protoc-gen-grpc-java-{version}-{platform}.exe".format(
            version = version,
            platform = platform,
        ),
    ],
)

Bzlmod is a different discussion. It looks invasive and a repeated cost as we make releases. So it would take some concerted effort to figure out what the heck is going on and what will be necessary going forward. We accept PRs for new stuff, and maintain what is there already. A PR isn't a sure win, but it generally does make things more clear as to what is going on. I don't see the point of forking if you haven't tried a PR upstream yet.

I'm interested in making grpc-java work for bzlmod consumers, and I'd prefer to do that in coordination with upstream. But as I see it, because of issues relating to version resolution mentioned above, having the ruleset live in the same repository as the sourcecode for the JARs is a net negative; an easy protection against aliasing between from-source and Maven-published artifacts is to just not make the sources available in the first place. For that reason, I'd like to see this hosted in a new repo rather than having it be a PR against the existing grpc/grpc-java repo. Could/should that repo live under the gRPC org (and if so what's the protocol to set that up?) or should it live elsewhere?
I am also somewhat concerned about the toil associated with releases; my current workflow is partially manual. It takes a few minutes to do now that I've figured out what needs doing, which is fine for the couple times a year my project updates its version of this dependency, but is a bit much for the couple times a month grpc-java cuts a release. I believe this is a scriptable task, and I've been tinkering on one although I don't have anything working so far.

https://github.com/bazelbuild/bazel-central-registry/pull/1699


Add plug that shows list of emails in SentEmail

Great for viewing sent emails in dev

This might be best to add to a bamboo-plug library so there is no requirement to use Plug. Not sure though


Update Configuration files of iCubGenova04

This PR update the configuration files of iCubGenova04. In details:

Update dragonfly configurations to improve image colors from cameras (same commit of #81)
Update left_arm-calib.xml and right_arm-calib.xml files
Update the head-inertial.xml file after the replacement of the head IMU https://github.com/robotology/icub-support/issues/734

cc @Nicogene @valegagge @DanielePucci  @S-Dafarra

LGTM

LGTM!

Thanks! Let's merge.

@S-Dafarra I had not merge because I was checking if the branch has been rebased on devel, so the next time please verify the branch to merge has been rebased on top of devel in order to mantain the history clean.
@GiulioRomualdi please check the the author of commit. you used icubGenova04, instead of yours. If you are on robot you can use --author parameter.
thanks a lot!

Now @drdanz and I created a rule in this repo in order to verify if a pr is rebased on top of devel/master. If not,  github writes a message in the box where is of merge button. So the next time  we can check it without bothering to perform  this check by hand (hoping this rule works well :) )

Ah nice. Was it already active before I merged?

no, we were working on it


I have a question for your "Movie Guide" application!

Hello! I'm university student from Korea.
I have a few question about your application, named "Movie Guide".
First, where do you get reviews for movies from?
Second, what do you think about letting people, users of "Movie Guide" application, write their own reviews for each movies.
Think about my questions and look forward to your thoughtful response.
Thank you for taking the time to read my question!

Go through this link - https://www.themoviedb.org/documentation/api
The answer to your question is in this link.

Thanks @Rajnish23


test: improve coverage for array/fixedarray_sort_by.mbt

Disclaimer: This PR was generated by an LLM agent as part of an experiment.
Summary
coverage of `array/fixedarray_sort_by.mbt`: 88.5% -> 94.2%

Pull Request Test Coverage Report for Build 4237
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.3%) to 81.333%

Totals

Change from base Build 4231:
1.3%

Covered Lines:
4540

Relevant Lines:
5582

💛  - Coveralls


Pubsub notifications

Expose Storage methods

storage.notifications.delete
storage.notifications.list
storage.notifications.insert
storage.projects.serviceAccounts.get

Introduce a new google-cloud-notification module that depends on

google-cloud-storage for all the RPC methods
google-cloud-pubsub for testing (a notification must be set on a Topic, which is exposed in Pubsub API) and for TopicName, which makes it easy for a user to correctly format the topic

PTAL

PTAL

Addressed all comments. PTAL

Responded to your question about AutoValue.
Apart from that and Garrett's concern about relationship with storage, LGTM.

Hmm, that's strange. If you want to submit this as is. It's fine. Easy to convert later if we feel like it.
Please add a todo to investigate AutoValue, but LGTM.

PTAL

@garrettjonesgoogle PTAL


Scrolling is weird

What's the Problem?
This app is fantastic but why is scrolling different that in Windows Explorer or other Windows apps? You should use scrolling set in Windows, not override with your smooth scrolling. This is bad, otherwise your app is fantastic.
Solution/Idea
Use scrolling type as defined in user's settings in Windows 10 when there are more files in windows and you scroll with mouse wheel, scrolling in your app is smooth although my settings are set NOT to smooth.
Alternatives
Windows Explorer - I like the scrolling there more
Priorities

Capability
Priority

This proposal will allow developers to accomplish W
Must

This proposal will allow end users to accomplish X
Should

This proposal will allow developers to accomplish Y
Could

This proposal will allow end users to accomplish Z
Won't

Files Version
<IP_ADDRESS>
Windows Version
Windows 10
Comments
No response

Tracked in #7764


ui: boards 2: electric boogaloo

What type of PR is this? (check all applicable)

[x] Refactor
[ ] Feature
[ ] Bug Fix
[ ] Optimization
[ ] Documentation Update
[ ] Community Node Submission

Have you discussed this change with the InvokeAI team?

[x] Yes
[ ] No, because:

Description
Revised boards logic and UI
Related Tickets & Documents

Related Issue # discord convos
Closes #

QA Instructions, Screenshots, Recordings

Added/updated tests?

[ ] Yes
[x] No : n/a

[optional] Are there any post deployment tasks we need to perform?

@lstein Sorry this isn't ready to be merged...


Enable CLI tests in CI

[ ] [Question] Make CLI unit tests work (somehow they are not run in GHA but locally); check missing lines in cli.py
[ ] [Question]  Unit tests for CLI: capture the standard output (if there's any) and check that it contains substrings that are only present in a successful execution (and in reverse) > How to do this?

Done in #51.