Functions exposed in the libgemma.a?

Forgive my weak C++-fu. I've compiled gemma into libgemma.a to call from my C++ application.  Is there documentation that details the function calls available in the library?

This is a great question.
There's two big TODOs that will make using gemma.cpp as a library much better:

We have some example demo applications in the works. They're pretty trivial but are meant to illustrate swapping in your own applications calling into the API in place of the interactive TUI. One is a silly message of the day app, another basically does the "what does this code do?" RAG task of the README demo, but as a program. Once some of the P0s are cleared (like https://github.com/google/gemma.cpp/issues/11) this is high up there.

There's some aspects of gemma.h and gemma.cc that are a little too coupled to run.cc, so there are some changes to the API interface that will happen once that gets decoupled a bit.

So if you don't want to deal with the sharper edges, you might wait for the above updates. That said, here's a few notes to get started. First, have a look at DEVERLOPERS.md for some high level notes (will be adding more detial to it as well.
Unless you are doing lower level research, form an application standpoint you can think of gemma.h and gemma.cc as the "core" of the library. You can think of run.cc as an example application that your application is substituting for, so the invocations into gemma.h and gemma.cc you see in run.cc are probably the functions you'll be invoking.
Keep in mind gemma.cpp is oriented at more experimental / prototype / research applications. If you're targeting production, there's more standard paths via jax / pytorch / keras for NN deployments.
Gemma struct contains all the state of the inference engine - tokenizer, weights, and activations
Gemma(...) - constructor (called here https://github.com/google/gemma.cpp/blob/b6aaf6bbb8a7f0b99330df8710765123ab330766/run.cc#L237) creates a gemma model object, which is a wrapper around 3 things - the tokenizer object, weights, activations, and KV Cache (https://github.com/google/gemma.cpp/blob/b6aaf6bbb8a7f0b99330df8710765123ab330766/gemma.cc#L267)
In a vanilla LLM app, you'll probably use a Gemma object directly, in more exotic data processing or research applications, you might decompose working with weights, kv cache and activations (e.g. you might have multiple kv caches and activations for a single set of weights) more directly rather than only using a Gemma object.
Use the tokenizer in the Gemma object (or interact with the Tokenizer object directly)
You pretty much only do things with the tokenizer, call Encode() to go from string prompts to token id vectors, or Decode() to go from token id vector outputs from the model back to strings.
The main entrypoint for generation is GenerateGemma()
Calling into GenerateGemma (as is done here https://github.com/google/gemma.cpp/blob/b6aaf6bbb8a7f0b99330df8710765123ab330766/run.cc#L207) with a tokenized prompt will 1) mutate the activation values in model and 2) invoke StreamFunc - a lambda callback for each generated token.
Your application defines its own StreamFunc as a lambda callback to do something everytime a token string is streamed from the engine (eg print to the screen, write data to the disk, send the string to a server, etc.). You can see in run.cc the StreamFunc lambda takes care of printing each token to the screen as it arrives (https://github.com/google/gemma.cpp/blob/b6aaf6bbb8a7f0b99330df8710765123ab330766/run.cc#L117)
Optionally you can define accept_token as another lambda - this is mostly for constrained decoding type of use cases where you want to force the generation to fit a grammar. If you're not doing this, you can send an empty lambda as a no-op which is what run.cc does.
If you want to invoke the neural network forward function directly call the Transformer() function
For high-level applications, you might only call GenerateGemma() and never interact directly with the neural network, but if you're doing something a bit more custom you can call transformer which performs a single inference operation on a single token and mutates the Activations and the KVCache through the neural network computation.
For low level operations, call ops.h functions directly
You use ops.h if you're writing other NN architectures or modifying the inference path of the Gemma model.
If you have additional questions or this is unclear, feel free to follow-up! We're also trying out a discord server for discussion here - https://discord.gg/H5jCBAWxAe

I'm working on adding an example of using libgemma here: https://github.com/google/gemma.cpp/pull/82 in addition to refactoring library usage.
Still a bit more work before merging, but if you're interested in libgemma, might be worth tracking the implementation there. Closing this issue for now but feel free to chime in if you're blocked on something.


Upgrade Linux Kernel for flatcar-3033 from 5.10.193 to 5.10.195

Subject says it all.

See instead https://github.com/flatcar/scripts/pull/1167


[AIRFLOW-5869] BugFix: Creating DagRuns fails for Deserialized tasks …

…with no start_date
Make sure you have checked all steps below.
Jira

https://issues.apache.org/jira/browse/AIRFLOW-5869

Description

[x] Here are some details about my PR, including screenshots of any UI changes:
Deserialized operators do not always have start_date set.

That, for instance, breaks triggering dags.
See the code from DAG.create_dagrun():
        run = DagRun(...)
        session.add(run)
        session.commit()

        run.dag = self
        run.verify_integrity(session=session) # this validation fails because run assumes that all operators have start_date set
        run.refresh_from_db()

One of the optimisation  we did as part of DAG Serialization was to not store dates in tasks if they have a matching date (start_date or end_date) in DAG. Unfortunately, when triggering DAG containing such tasks, it fails on DagRun.run.verify_integrity.
The fix is to add the start_date when deserializing the operator.
Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

test_deserialization_start_date
test_deserialization_end_date

Commits

[x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[x] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain docstrings that explain what it does
If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

We should cherry-pick this to https://github.com/astronomer/airflow/tree/v1-10-5 too


feat: on policy init, check the dependencies with git ingester

This is a follow-up to the vulnerability checking web hook-based flow. In order to support policy init and periodical reconcile, let's consume the whole package manifest (e.g. the whole go.mod or the whole package.json) using the git ingester and check its contents against a database like OSV.
The remediation in this case might be an issue or a PR.

This is a larger problem than an issue -- this would fit into the "drift detection" epic.

We have an epic tracking this, it will need more design before we can implement.
https://github.com/stacklok/epics/issues/157


chore: release main

:robot: I have created a release beep boop
accesskit_c: 0.5.1
Dependencies

The following workspace dependencies were updated

dependencies

accesskit_windows bumped from 0.14.2 to 0.14.3

accesskit_windows: 0.14.3
0.14.3 (2023-08-08)
Bug Fixes

Update windows crate to v0.48 (#257) (cc703ed)

accesskit_winit: 0.14.4
Dependencies

The following workspace dependencies were updated

dependencies

accesskit_windows bumped from 0.14.2 to 0.14.3

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/AccessKit/accesskit/releases/tag/accesskit_windows-v0.14.3 :sunflower:

:robot: Release is at https://github.com/AccessKit/accesskit/releases/tag/accesskit_winit-v0.14.4 :sunflower:

:robot: Release is at https://github.com/AccessKit/accesskit/releases/tag/accesskit_c-v0.5.1 :sunflower:


Update containerd/cgroups to<PHONE_NUMBER>f9b0ae

As the title says

Apparently this managed to break completely-unrelated images tests?

Filter before image is broken in master

Changes LGTM, but tests aren't hip @mheon, I'm not sure if it's related or not.

Rebased, should go green now

/lgtm

OK, in case this was not clear. Please do not put things into the merge queue until all of your statuses are successful, or the automation just thrashes trying to merge.
/hold

Tests green now
/hold cancel


Sort out (fully) use of Blueprints

Blueprints feel like the right way for us to plug in multiple endpoints for the Flask API.  We've got a start of an implementation, but it's likely that "the most Flask-y way" might be different in some ways...

each major endpoint (blueprint) in its own folder with its own resources
name of blueprints being used in the prefixing of the handler functions @simple_page.route('/', defaults={'page': 'index'}) etc

I'm just going to close this; I think we are way, way past when this was relevant.  @charparr @kyleredilla close if you agree, or we can discuss more!

Fine with me - I actually never really understood what this meant :D


Suggested API doc change to fix #581

Not tested, but looks OK to me. I cribbed the response stuff from other delete sections, let me know if any tweaks are required.

Thanks


one file in data analysis added

Pull Request Description

This pull request was created when I added one file in the data analysis folder in which I performed data visualization techniques over the Titanic dataset, during my learning period.
Changes Made

Added DataVisualization_perforned_on_Titanic_Dataset.ipynb file
performed some techniques on Titanic dataset
practiced and tried to learn something new.

Screenshots (if applicable)

Related Issues

Checklist

[x] I have read and followed the contribution guidelines.
[x] I have tested my changes.
[x] My code follows the project's coding standards.

I have resolved all these issues, have a look and let me know if there is any other.
Thanks


Styling Issues specifity

The colours for optgroups are specified via "#tokenizer option, optgroup" which can lead to unwanted style issues with unrelated modules or systems. For consistency it should probably be "#tokenizer option, #tokenizer optgroup"

I'm not sure I fully follow the issue here, can you look at the CSS https://github.com/MrPrimate/tokenizer/blob/e72f85038db16735083c5461793a85e1851041e1/css and pull out an example for me? Happy to correct, just not sure where the problem is.

Thanks, fixed in next release


Update prediction interface to provide additional feedback to a predictor plugin

PR Summary
Update prediction interface to provide additional feedback to a predictor plugin.
The changes are:

Introduce PredictionClient to represent a client. It provides additional information about the type of the client: terminal, editor.
Update ICommandPredictor interface to replace the properties SupportEarlyProcessing and AcceptFeedback with the method AcceptFeedback(PredictionClient client, PredictorFeedback feedback). So a predictor implementation can be specific about whether it accept each feedback.
Add the feedback event OnCommandLineExecuted. It provides a predictor the information about the execution result (success or failure) of the last accepted user input.
Update how delegate is created in CommandPrediction, to minimize the allocation of the delegate helper object.
Add more tests and fix the fragile test.

PR Context

The Az.Predictor team asked for the new feedback OnCommandExecuted, which provides the execution status (success or failure) of the last accepted user input.
A predictor implementation will need the information about the client type (terminal, editor) to properly serve those 2 different scenarios, so we need to use a type to represent the client.

PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[ ] None
OR
[x] Experimental feature(s) needed

[x] Experimental feature name(s): PSSubsystemPluginModel

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[x] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.

@rjmholt Thanks for your review! I've addressed your feedback, please take another look when you get a chance.


[DEV-3493] userData in transaction

Release Checklist
Pre-Release

[ ] Check migrations

No database related infos (sqldb-xxx)
Impact on GS (new/removed columns)

[ ] Check for linter errors (in PR)
[ ] Test basic user operations (on DFX services)

Login/logout
Buy/sell payment request
KYC page

Post-Release

Test basic user operations
Monitor application insights log

[ ] add migration
[ ] set userData with GET refund request
[ ] check userData in PUT refund request


Copier update fails if git gpg commit signing is enabled globally

Describe the problem
If signing git commits is enabled globally for a user using git config --global commit.gpgsign true, then running copier update fails with the error "error: gpg failed to sign data". This is caused by copier/main.py in lines 917-928, where user name and email are set and then a commit is attempted. Since there is no GPG key for the given e-mail address GPG cannot sign the commit and the update process fails in line 926.
Template
Error is template-agnostic.
To Reproduce

Run git config --local commit.gpgsign true
In a project created using copier copy run copier update
Update fails with error: gpg failed to sign the data

Logs
No response
Expected behavior
The update is applied
Screenshots/screencasts/logs
No response
Operating system
Linux
Operating system distribution and version
Ubuntu 23.04
Copier version
8.0.0
Python version
CPython 3.11
Installation method
pipx+pypi
Additional context
No response

I believe #856 is related but abandoned. It would be great to finish that work.

Looking at #856, that definitely looks as if that would fix my bug, as that is essentially the workaround I'm currently applying.

Great! Would you be interested in working on a PR that finishes what was started in #856?

What is there that remains to be done? As far as I can see there is just one failing check, but I can't see why it failed anymore.

It looks like it was complete but didn't get merged for some reason. Since then, the code base has evolved, there are merge conflicts and probably new tests that need this extra Git config command as well. It should be quite straightforward to replicate #856 for the current state of the project.

I am happy to pitch in, but I currently can't make any promises as to when I will find time for it.

I've been thinking about this issue and #856 a little more and dislike the many added Git config lines in the tests of #856. So why were they added? Because the test suite fails for developers with GPG commit signing enabled, and that's because the repo/global/system Git config affects Copier's internal usage of git, e.g. in the update algorithm. I believe we should differentiate between two Git usage scenarios in Copier:

Programmatic usage of git respecting user's configs. This is needed for cloning a template, e.g. when the Git project is private and the user has configured credentials or an SSH key.
Internal usage of git, e.g. the update algorithm.

For 2., we should make git ignore any config files and, thus, run it in full isolation of the user's environment. I think this is possible, see e.g. https://stackoverflow.com/a/67512433.
WDYT, @copier-org/maintainers?

It looks like this would be quite straightforward to do if we raised the minimum required git version to v2.32.0 two new environment variables GIT_CONFIG_SYSTEM and GIT_CONFIG_GLOBAL were introduced in this release (https://github.com/git/git/commit/4179b4897f2de28858acaebd6382c06c91532e98). Before, running in git in a sanitized environment requires unsetting HOME and XDG_CONFIG_HOME which is likely to have negative side effects, e.g. when pre-commit hooks are registered that (for some reason) use those environment variables.

If I remember correctly, the code already tries to run the git commands with --no-verify, so that shouldn't be a problem.

Only the second commit but not the first, which is intended to run Git hooks:
https://github.com/copier-org/copier/blob/34daebbd7cedf142af60468eb118909eefbae16f/copier/main.py#L923-L926

Yes, but if I understand how plumbum works correctly, then the first command can fail and will not throw an exception (due to the retcode=None). I don't understand the code well enough to determine if it is an issue, if the first commit fails, but the second succeeds.

El sáb., 1 jul. 2023 16:50, Sigurd Spieckermann @.***>
escribió:

For 2., we should make git ignore any config files and, thus, run it in
full isolation of the user's environment. I think this is possible, see
e.g. https://stackoverflow.com/a/67512433.
WDYT, @copier-org/maintainers
https://github.com/orgs/copier-org/teams/maintainers?

Good idea!

@yajo I realized this would need git v2.32.0+. https://github.com/copier-org/copier/issues/1224#issuecomment-1624221904

I don't think this is a requirement, but a recommendation. Older Git won't react to that env variable, and that's totally fine. If you don't have gpg enabled, you can still work as normal.
Another option is forget about that and just add the --no-gpg-sign flag wherever needed. I don't think this would be too complicated honestly.


Inconsistent warning raising

Some parts of the codebase use warnings.warn and some use logger.warning. Due to this, some warnings ignore the set logging verbosity level.
E.g.
dataset = load_dataset("huggan/smithsonian_butterflies_subset", split="train")

Will give a user warning
warnings.warn("Repo card metadata block was not found. Setting CardData to empty.")

Should we just use logger.warning everywhere?

I tend to make a difference between logger.warn and warnings.warn. From Python official documentation:

warnings.warn() in library code if the issue is avoidable and the client application should be modified to eliminate the warning
logging.warning() if there is nothing the client application can do about the situation, but the event should still be noted

We are most likely not 100% consistent with this rule in the codebase but I think we should aim for it.

warnings.warn("Repo card metadata block was not found. Setting CardData to empty.")

I agree that for this specific example, we should use logger.warn instead :+1:


[CI][Packaging] Add nightly test that pip-installs nightly wheels

This would catch issues with wheels that we only encountered during release verification.
Reporter: Neal Richardson / @nealrichardson
Note: This issue was originally created as ARROW-7853. Please see the migration documentation for further details.

Our wheel jobs now pip-install the generated wheels, closing as stale.


Update controlled-folders.md

Updated section ## What is controlled folder access? with all supported OS versions
Fixes#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/10393

@JohanFreelancer9 Please copy review

Learn Build status updates of commit aeaa215:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/security/defender-endpoint/controlled-folders.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Fresh install results in error in config/environment.js

Steps to reproduce

Install ember-cli v0.2.2
ember new bugapp
cd bugapp
ember install:addon ember-cli-materialize
ember s
visit http://localhost:4200 , open your javascript console and refresh

You will now see this error

isnt there a way to fix this permanently???

yep i have a fix in #51  :)


Adding support for multi statement queries

fixes #8

I see that name and encoder is used by Query (query.ts), should i also remove this if it is not used?

I see that name and encoder is used by Query (query.ts), should i also remove this if it is not used?

@bartlomieju ^

I see that name and encoder is used by Query (query.ts), should i also remove this if it is not used?

@bartlomieju ^

Yes, sounds good to me

@bartlomieju It is merged and ready now 👍

@bartlomieju Quick question, should I resolve the conversations? Also, is there anything else we should include here, or can we merge it? 😄


Add QOL changes to Parse Server Example

Adds:

Example GitHub workflow
Testing utility that imports index.js and boots up a temporary DB, and destroys after tests are complete
Example unit test
Example code linting

Closes #383
Feel free to let me know your thoughts / what can be improved.
@mtrezza @davimacedo @Moumouls

@dblythy it looks the action is failing after merged. Would you take a look?

@dblythy it looks the action is failing after merged. Would you take a look?

Yes sorry, I added a failing test as an example of what happens when a test fails. Is this a bad idea?

Yes sorry, I added a failing test as an example of what happens when a test fails. Is this a bad idea?

Yes, I think so. I haven't noticed that as well. But only passing tests would be better.

Yes, I think so. I haven't noticed that as well. But only passing tests would be better.

🎉 This change has been released in version 1.2.0


Creation of docker fails with missing cudnn file

Following the example of docker setup, creation of docker fails due to missing cudnn header file:
In file included from NNTypes.cpp:13:0:
GpuTypes.h:23:19: fatal error: cudnn.h: No such file or directory
#include <cudnn.h>
^
compilation terminated.
make[1]: Leaving directory `/opt/amazon/dsstne/src/amazon/dsstne/engine'
make[1]: *** [NNTypes.o] Error 1
make: *** [lib/libdsstne.a] Error 2

Yeah, you guys still need to come to some sort of resolution w/r to
licensing cuDNN: Convolution, MaxPooling, LRN, Batch Normalizartion, and
RNNs either do or will rely on it.
On Sat, Nov 12, 2016 at 3:52 PM, Matias Benitez<EMAIL_ADDRESS>wrote:

Following the example of docker setup, creation of docker fails due to
missing cudnn header file:
In file included from NNTypes.cpp:13:0:
GpuTypes.h:23:19: fatal error: cudnn.h: No such file or directory
#include <cudnn.h>
^
compilation terminated.
make[1]: Leaving directory `/opt/amazon/dsstne/src/amazon/dsstne/engine'
make[1]: *** [NNTypes.o] Error 1
make: *** [lib/libdsstne.a] Error 2
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/amznlabs/amazon-dsstne/issues/96, or mute the thread
https://github.com/notifications/unsubscribe-auth/ARNK9s8K3JxXnPZiG6SD5GYoOjRWVv3-ks5q9lEngaJpZM4Kwj-U
.

My recent changes to the Dockerfile included in this repo should address the cuDNN-related compiler errors. The new Dockerfile inherits from one of NVIDIA's public Docker images, which has CUDA 7.5 + cuDNN 5.1 installed. You'll have to build the Docker image yourself, as it the end user's responsibility to accept the NVIDIA's EULA.
The Makefile has also been updated to remove some compiler flags that assumed CUDA 8 would be available.


Tain-toy.sh

Hello,
Please when i execute train-toy.sh i have this error:
[Warning] failed to open results/patterns.csv under parameters = r
Could you help me please?

Yeah sure I can help you with this issue.


"Description" discrepancy on /projects/:id

After creating a new project, with a project Description, the first line of the Details box - entitled "Description"- on /project/:id is blank.

If you scroll down though, and look see the "Project Description" of the Project Questions, the description is included there.
Are these different descriptions or are they the same? Why is one filled in and the other not?

There's some demo project question that asks for the description.
However the real issue here is that the columns for the project-questions table need to be defined with maximum widths. The question and answers columns shouldn't force others to squish.

this has since been resolved, closing.


Fix typo in package.json

This tiny pull request changes licenses to license in package.json, to bring the file within npm's guidelines.
This should make it that much easier for automated tools to confirm the MIT license.

Thank you!

Thank you, @dylang. Super important package!


How to animate layout

I want to animate a layout like this
ViewAnimator
.animate(layout)
.translationY(-1000, 0)
.alpha(0,1)
.start();
But unfortunately this doesn't work. How to Make it work

@danielpassos any layout , like RelativeLayout etc


Implement About Menu and Version Dialog

What does this PR do?

Adds an Excalidraw Menu Item and About Dialog (https://github.com/excalidraw/excalidraw-desktop/issues/44)
Adds a metadata store
Adds a preload script, for exposing main process apis to renderer.
Converts node requires to typescript style imports.
Adds a constants file

Another thing:

In the built distro version the dialog throws some errors and is not displayed. Seems like we have to store some stuff in the distro

@pinussilvestrus I've fixed the electron-builder. Also added a .center to the about window panel, so it should ideally fix it on mac. If it doesn't we can consider making the AboutWindow separate, and not as a child of the mainBrowserWindow.

Still not showing correctly:

I believe the way Menu items are ordered, is quite different based on OS

That's the case, yeah. But +1 do discuss that in a separate issue to have it in an orderly manner.

I'm starting to think the position issue is because the about window is bound to actual one. I think we can make it a separate window.

Let's try it out 🚀

@pinussilvestrus I think the centering issue should be fixed.

That's good!
Another thing I experienced, is that it seems to add a new menu every time I open it, which resolves in a lot of new Menu entries.

Weirdly, I cannot reproduce both the bugs mentioned above on linux, but I made a change to call setupMenu once when the app's main window loads.

It seems to be Mac related to creating the application menu twice. Maybe I can have a look at the weekend.

@pinussilvestrus I think I know why the bug on mac is happening. So I've made a fix for the menu-items specific to mac and as mentioned above, I have moved the About section to Help for other platforms. Let me know if you still reproduce it.

@lipis would it be possible to add @Shriram-Balaji to the desktop-team?


Shotgun damage

Add method to handle shotgun damage.

Let me do some research on this as well. There is also Basic rules and those in High-Tech as well as Pyramid Magazine that has some alternate rules I know people are using.

Good idea.


Restriction for Event's body

Event's body must return async object

It's not a bug, it's practically bad restriction. #29


Update tdr-metadata-validation to 0.0.48 in scala-steward-dependencies

About this PR
📦 Updates uk.gov.nationalarchives:tdr-metadata-validation from 0.0.42 to 0.0.48
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "uk.gov.nationalarchives", artifactId = "tdr-metadata-validation" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "uk.gov.nationalarchives", artifactId = "tdr-metadata-validation" }
}]

labels: library-update, early-semver-major, semver-spec-patch, commit-count:1

Superseded by #4110.


Rewrite Ruby tests & scripts to Node.js

Rewrote the tests and build scripts into node.js
Fixed APIv1 generating API files into the wrong directory :sweat_smile:
Split 'Repository' GitHub workflow into two workflows
Replaced CircleCI tests with Cloudflare Worker tests
Made APIv1 fetch entries from 2FA Directory:
All entries from the 2FA Directory will now show up as not supporting Passkeys unless they support 'u2f' as a 2FA method.
Added API file JSON schema validation

Merging myself to fix API outage.


Remove Legacy reference to extends on example page.

These still exist: https://github.com/thoughtbot/bitters/blob/master/app/assets/stylesheets/_lists.scss

Gasp! mind blown

@tysongach Should this be opened again, due to #199?
It doesn't need to happen yet, because they exist in the latest release (1.10), but before the next release would be great!

awe yea~~ :+1:


perf: Stack faster log paths first

Folder 1 should only use tags as filter conditions
Folder 2 should use host/ip via vendor_product_by_source
Folder 5 when message or program must be parsed
Folder 9 for last change behavior
Other numbers for future use

:tada: This PR is included in version 1.46.2-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.46.2-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add active connection limit

Please review these changes.

Will limit the number of active/created connections. So, when you hit the limit Get() will block until there is an available/idle connection in the pool.
Add a new function TryGet() to return an error instead of blocking when you hit the limit.
Update README with example code
Update Read/Write methods to MarkUnusable() on errors.

I had the issue of  limiting max connections, due to destination limitation, Good job.

I'm archiving and closing this project. It's not going to be maintained anymore. Thanks all for their valuable feedback and contributions. If you have questions, feel free to reach me from https://twitter.com/fatih


[BUG] Following MRTK Documentation for Cloned Examples Results in Unity Crash

Describe the bug
I'm following the MRTK3 documentation hub pre-requisites checklists and cloning the main branch (or most recent release branch) of MRTK3 from this repository. I open the project in Unity Hub and attempt to run the scenes provided, but Unity crashes on start.
The template projects setup instructions are vague, instead recommending configuring a new project to use the toolkit. However I would like to drop into a demo environment first.
I would like to incorporate MRTK3 into our current project, but until I've interfaced with some examples and know how it works better, I am hesitant to do so. I would like to use the example scenes for reference which means being able to run the example project.
To reproduce
Steps to reproduce the behavior:

Follow this checklist: https://learn.microsoft.com/en-us/windows/mixed-reality/develop/install-the-tools?tabs=unity
Install the correct version of Unity editor with the support modules for UWP https://learn.microsoft.com/en-us/windows/mixed-reality/mrtk-unity/mrtk3-overview/getting-started/setting-up/setup-dev-env
Check this page, which recommends cloning from a branch which no longer exists: https://learn.microsoft.com/en-us/windows/mixed-reality/mrtk-unity/mrtk3-overview/getting-started/setting-up/setup-template
Instead clone from the main branch of this repo.
Open project in Unity
Switch to UWP Build Target
Open the Empty Demo Scene
Run, Unity Crashes

Expected behavior

Follow this checklist: https://learn.microsoft.com/en-us/windows/mixed-reality/develop/install-the-tools?tabs=unity
Install the correct version of Unity editor with the support modules for UWP https://learn.microsoft.com/en-us/windows/mixed-reality/mrtk-unity/mrtk3-overview/getting-started/setting-up/setup-dev-env
Clone the main or a release tagged MRTK3 source
Open the demo project
Set build target to UWP
Run a demo scene
the demo scene opens with either the MRTK Input Simulator or Holographic Remoting (Hololens2)

Your setup (please complete the following information)

Unity Version 2021.3.21f1
MRTK Version 3.0.1 and main commit 694fa6c

Target platform (please complete the following information)

HoloLens 2

Hello @xrezdev08 thank you for reaching out.
I tried to reproduce this issue but didn't experience the crash you mentioned.  What I did was a fresh install of Unity Editor 2021.3.21f1 > Cloned MRTK3 main branch > Open the project located in \MixedRealityToolkit-Unity\UnityProjects\MRTKDevTemplate and then opened the scene located in  \MixedRealityToolkit-Unity\UnityProjects\MRTKDevTemplate\Assets\Scenes\EmptyScene ... I also opened the CanvasExample and HandInteractionExamples scenes but didn't experience a crash either.
I would suggest you to:

Check if the OS has any updates queued and install them.
Check if your GPU has driver updates and install them.
Do a fresh install of your Unity Editor by uninstalling it via Unity Hub, remove it, and wipe out its folder content.
Please let us know if any of the above helped you.

Also, thank you for letting us know of our outdated documentation, we are in the process of updating it.

Thank you for getting back to me. I will try your suggestions and let you know if any of them help.

Check if the OS has any updates queued and install them.
Check if your GPU has driver updates and install them.
Do a fresh install of your Unity Editor by uninstalling it via Unity Hub, remove it, and wipe out its folder content.

I have tried the above recommendations with no changes.
Unity Editor Version: 2021.2.21f1, freshly installed as suggested
OS: WIndows 10 Version	10.0.19045 Build 19045, No Pending Updates
Graphics:  RTX 3090Ti, Nvidia Driver Version 546.65, No Available Updates
I am still experiencing a Unity Editor crash when attempting to run SampleEmptyMRTKScene. I have tried after the above steps, both with and without installing the UWP build support as detailed in the "Setting up A Development Environment" section of the documentation. I have also tried and with and without switching to UWP as the target platform before running the demo scene.
Is there another dependency that might be missing or in conflict.

Thank you for your update.  The issue could be related to some missing dependencies.  May I suggest you try setting up MRTK3 packages with Mixed Reality Feature Tool as described here?

Following this suggestion, it appears the following packages were not labeled as "installed" by the Mixed Reality Feature tool on opening the demo project.

After installing these packages, attempting to open the project results in the following compilation error in Assets\SampleSceneHandMenu.cs.

Assets\Scripts\SampleSceneHandMenu.cs(57,39): error CS0103: The name 'FindObjectUtility' does not exist in the current context

The offending code:
SimpleProfiler profiler = FindObjectUtility.FindFirstObjectByType<SimpleProfiler>(true);
I was able to get the error to go away by changing it to:
SimpleProfiler profiler = FindFirstObjectByType<SimpleProfiler>(FindObjectsInactive.Include);
However I am unsure this accomplishes the same goal. I can't seem to find any documentation for the FindObjectUtility mentioned in the original script.

Double checking the installation checklist again. I installed the HoloLens 2 emulator, but it appears the HoloLens 1 emulator was not installed. Would not having the HoloLens 1 emulator installed cause an editor crash? I tried installing the HoloLens 1 emulator, but at the end I get an installation rollback and the error:

MSI (s) (68!58) [13:22:51:849]: Product: Windows Mixed Reality Templates for Visual Studio -- Error 1608. This product requires Microsoft Visual Studio 2015 or newer. It also requires the Universal Windows Platform tools optional feature of Visual Studio.
Please install Visual Studio with the Universal Windows Platform tools optional feature and try again.

I have attached the installation logs as much of the information there means next to nothing to me. Hoping someone there might have some insight as to how I might fix or whether I need to bother to move forward troubleshooting.
HoloLens_Emulator___Windows_10.0.17763.134_20240123132012_004_package_WindowsMixedRealityTemplatesforVisualStudio.log
This is a bit odd, because I definitely have a valid installation of VS 2022 with the UWP features installed, as it's a pre-requisite of our other project. I was able to install the HoloLens 2 emulator just fine. For posterity I checked anyway, and I do definitely have VS2022 with UWP installed, with everything enabled in the features for UWP support except Copilot.

Thank you for the follow-up and additional information.  I think the issue may be related to the Unity Editor version you are using.  The failing code was introduced in Unity 2021.3.18 but I noticed you are using 2021.2.21f1 as per:

Could you please try upgrading your editor to 2021.3.21f1 and let us know if the compilation error still appears?

Thank you for the follow-up and additional information. I think the issue may be related to the Unity Editor version you are using. The failing code was introduced in Unity 2021.3.18 but I noticed you are using 2021.2.21f1 as per:  Could you please try upgrading your editor to 2021.3.21f1 and let us know if the compilation error still appears?

Sorry about that, that's actually just a typo. Thank you for pointing it out!
I am on 2021.3.21f1.

Ok, thx for the clarification.  The next thing I would check would is having "Visual Studio Tools for Unity" installed.  If you run Visual Studio Installer then go to "Individual components" tab and then scroll down until "Games and Graphics" section.  Check that "Visual Studio Tools for Unity" is checked, for example:

If it is already checked then I would suggest to uncheck, reboot, check it again to force its re-install.

@xrezdev08 , unfortunately at this time we can't reproduce the issue.   We can continue investigate, however we need more information.   Can you provide 1 or more of the following?

Your exact copy of the sample Unity Project that is reproducing the issue.  We can't repro using the sample project in the MRTK3 repository.
A crash dump contain the Unity crash
Your Unity Log file from the Unity crash
The compile error before changing MRTK3 code.

Also @xrezdev08 , MRTK3 will not work with HoloLens 1, so the HoloLens 1 emulator is not needed.
You should be able to build the MRTK samples with no HoloLens emulator installed.

Noted, Thank you for clarifying. I wasn't entirely certain I needed it.
Been out sick, but when I get back into the lab I will try to set aside some time to reproduce the crash with minimum steps listed in my original ticket and then send something over.

Hi,
I am also experiencing problems when opening the MRTKDevTemplate project.
I have installed all the MRTK packages using the MRFTool (BTW, the org.mixedrealitytoolkit.data package was missing in the MRFTool and I had to install it from local disc using the corresponding json file of the cloned project).
After installing the packages and opening the  MRTKDevTemplate project I get the following compilation errors

I have a W11 system, Unity 2021.3.21f1 and the following versions of MRTK3 packages:
org.mixedrealitytoolkit.accessibility: 1.0.1-pre.19
org.mixedrealitytoolkit.audio: 3.0.1
org.mixedrealitytoolkit.core: 3.1.1
org.mixedrealitytoolkit.data: 1.0.1-development
org.mixedrealitytoolkit.diagnostics: 3.0.1
org.mixedrealitytoolkit.extendedassets: 3.0.1
org.mixedrealitytoolkit.input: 3.1.0
org.mixedrealitytoolkit.spatialmanipulation: 3.1.0
org.mixedrealitytoolkit.standardassets: 3.0.1
org.mixedrealitytoolkit.tools: 3.0.1
org.mixedrealitytoolkit.uxcomponents: 3.1.1
org.mixedrealitytoolkit.uxcomponents.noncanvas: 3.1.1
org.mixedrealitytoolkit.uxcore: 3.1.1
org.mixedrealitytoolkit.windowsspeech: 3.0.1
Thanks for your help

Attempted a reproduction in Unity 2021.3.21f1 with MRTK3 commit https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity/commit/f279218d1e1f0856ebb32c6122b0b22a273a15d6, unable to reproduce, closing this issue.


Generated CSS contains wrong font-family

Hey there. Nice tool!
I think I found a small bug: if you choose another Google Font the generated CSS still contains Poppins.

Hi Johnathon, thats not actually a bug, the font poppins is actually for the elements on the left side of body, these elements display the size and pixels
Eg: on the left of side of the "A visual  type scale", we see size as 3.052em and(54.93 px) and look at that font.
Its Poppins, i hope you get it.
The quick fix for you here is after copying css from here, you can change the body font-family  to font of your choice.
meanwhile i will try to fix that issue.
Thanks

Correct, this is intentional, so header and body font can be unique and independent of the other. However, there are many times when only one font is needed for both, so I'll probably address that at some point.
Closing this issue for now. Thanks for your input.

@grubersjoe Hey. I just deployed an update (#33) that changes how things work, and fixes the url issue you noticed. The main font field now updates both the headers and body font, unless you manually select a body font. Probably how it should have worked to begin with. Thanks again for your feedback.

Great, thank you!


Create reportStructure.json

moved the proposal to https://github.com/International-Data-Spaces-Association/ids3c-co/tree/master/evaluation_report
since that is a better place for the overall evaluation report which will be written by an evaluation facility during assessment in Assurance Level 2 and 3.


Toggle view (or set view) for invite links to participants

Is your feature request related to a problem? Please describe.
Folks have issues with understanding the invite page where they pick availability, the need to scroll on a narrower browser page (think half of a laptop screen) with small boxes to make selections is a bit unintuitive for them. They mentioned they preferred seeing a calendar view as is used when the creator of the poll/event.
Describe the solution you'd like
A button to view in a 'calendar' mode or 'list' mode. The selections in calendar mode would look one way when unselected, then another when selected. There would be a legend perhaps which could also denote selected vs unselected options as is used in Ticketmaster or other venue/seat based things.
Describe alternatives you've considered
I have taken a screenshot and sent the users the calendar view I see when creating the poll/event, after they determine which would work they seek the date in the invite link and select it.
Additional context
N/A

Good idea @javentous.


collate tagging

and minor UG change

Pull Request Test Coverage Report for Build 376

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 48.95%

Totals

Change from base Build 371:
0.04%

Covered Lines:
1632

Relevant Lines:
3334

💛  - Coveralls


[MM-57409] Notify error sharing on iOS

Ticket: MM-57409
Approach to solve it:

a local notification for failure is scheduled.
the device tries to share

If the share action succeeds, the notification is removed from the queue
if the share action is known to fail, we remove the notification and launch a new one immediately
if the share action takes too long, notification kicks in and next time we remove attempts to keep trying.

Why such a complex approach:

iOS might kill the share action process, by having this queued notification we'll ensure the user doesn't expect it to be shared
iOS waits for up to 9 days for the user to come online to try and do the sharing action, while this might be fine for other apps, it goes a bit against the timing expected by our users. I set up a 5 min deadline, but we can change it to something else (bigger/smaller)
we don't have control on when the share action is executing

Context:

This is only for iOS. Since the code path is very different we can process this and I'll tackle Android as soon as possible, depending on other priorities.
Timeout needs to be defined.
The message should be reviewed. I kept a vague message for the scheduled notification since there could be a number of issues at play, but it can definitely be improved.

Pending:

There are no tests for this part and I'm not sure how to do them, so any pointers would be great.
Localization, since this is not part of the regular app, I haven't yet done any localization.
Android.
Unit testing.
allow users to specify their own timeout within some sensible range. This could be discussed if it makes sense.

Checklist

[ ] Added or updated unit tests (required for all new features)
[ ] Has UI changes
[ ] Includes text changes and localization file updates
[ ] Have tested against the 5 core themes to ensure consistency between them.
[ ] Have run E2E tests by adding label E2E iOS tests for PR.

Device Information
iOS simulator
Screenshots

Release Note
Improved error notification when sharing on iOS

Additionally, what happens when:

The use taps on the notification that was presented.
The user has the application opened when the notification triggers
Tap on the notification inside the app as shown in 2.

for 1 and 3, it opens the app.
2 is not showing, seems I need to also handle the local notification within the app, right? I'll work on that next as well as the translations and update the PR.


Add some explanation of the template file in the Example.

In the “Example” on README.md, it is not clear how to get the exact template file, and where to put it. I guessed, which worked, but another line could help the general user.
https://github.com/openjournals/joss-reviews/issues/4942

Thank you for noticing that some information was missing. I have included in the README.md further details of where to get the template, and where to put it after downloading.


New Features to be added

Waiting for contributers to add new ideas for this website

we can use NASA Open Apis to implement other useful information in the website like we can use picture of the day Api apod to include that image in landing page of our webiste

we can use NASA Open Apis to implement other useful information in the website like we can use picture of the day Api apod to include that image in landing page of our webiste

we can use NASA Open Apis to implement other useful information in the website like we can use picture of the day Api apod to include that image in landing page of our webiste

Yes! that's a great idea. It will be suitable one for landing page.

@mohittk  can you assign it to me?

@mohittk can you assign it to me?

Yes! Go for it, but before that! just inform me what changes you are planning to make here only.

Please create a discord server so that I(and other contributors) can talk to you else this comment section will be messy!

Please create a discord server so that I(and other contributors) can talk to you else this comment section will be messy!

Yeah! For sure. Join with this link. https://discord.gg/YU8H62rS

I was thinking about adding a different route for a list of all the comets

You mean to say for comets API?

Yes


Excellent work, do you have the plan to release the train code?

Sorry, recently we do not have any plan to release the training code, but maybe in the future.


Version 5.0 Elasticsearch supported?

Hello,
Would it be possible to document which versions of elastic search are supported? I have a client running version 5.0, and want to understand if the version is supported by the plugin, or if we need to run it with another version

5.0 supported.
The filtered query is replaced by the bool query.

Thanks for the answer. @wbytebier, here is your response.


Support non-UTC timezone for casting from date type to timestamp type [databricks]

closes #11461
Only support non-DST(daylight saving time) time zones.
Signed-off-by: Chong Gao<EMAIL_ADDRESS>

build

non-DST timezone
passed:
TZ=Asia/Shanghai ./integration_tests/run_pyspark_from_build.sh -s -k test_date_to_timestamp

For DST timezone:
Report not supporting prompt:
TZ=America/Los_Angeles ./integration_tests/run_pyspark_from_build.sh -s -k test_date_to_timestamp

!Expression <Cast> cast(a#4 as timestamp)
cannot run on GPU because Timezone America/Los_Angeles is not supported yet.
Only Non DST (daylight saving time) timezone is supported.

build

premerge failed

build

Spark 400 building failure is related to https://github.com/NVIDIA/spark-rapids/issues/11479

build

build

build


No Internet

Hi,
I just setup wg for the first time, everything is green on the app and I even get this but on my iPhone when i try to load a webpage it still doesn't work. It's as if I had no network on my phone but when I deactivate the VPN, it all loads perfectly.

Any idea how to fix this ?

I had the same issue. It was my port forwarding. The IOS client shows like it is connected, but I guess the way Wireguard works, it wasn't actually connected.
I looked at the logs on the IOS client and everything was timing out.

I had the same issue. It was my port forwarding. The IOS client shows like it is connected, but I guess the way Wireguard works, it wasn't actually connected. I looked at the logs on the IOS client and everything was timing out.

How did you fix it exactly ? On my router i added the right port forward (51500 udp in this case)


Importing Components that import other Components

mdx-bundler version: 9.2.1
node version: 16.19.0
npm version: 8.19.3

What you did:
I am importing a component into my mdx blog post:
import Imper from "./Imper";

Hello!

<Imper />

When Imper does not rely on any other components from my own project, this works. However, when I import other components inside Imper (that are not provided as globals), I get this error:
Server Error
SyntaxError: Unexpected token '<'

This error happened while generating the page. Any console logs will be displayed in the terminal window.

I am not sure whether this is intended or what I am doing wrong here exactly? I would've expected mdx-bundler to automatically import all other components that my Imper component relies on?
I do know that providing those components as globals fixes this problem, but I do not want to have a ton of globals that I might not re-use a lot.

Did you solve it?

Adding my +1 here, I'm facing the same issue.


feature(requirements)! : allow to work with php 8

BREAKING CHANGE : Set php .8 as minimum version

Wrong push

Why the close?

Why the close?

I made a PR to the wrong repository : I did a quick fork to try to fix thing but didn't add any tests


Complete support for dynamic container names

This is my attempt to solve the same #205 issue.
In Swarm Mode and Docker Cloud, container names are dynamic. #181 solved this partially with a label on jwilder/nginx-proxy but not if they're separate containers. #126 tries a different approach, but I think using a label is a better one.
This PR simply adds a com.github.jrcs.letsencrypt_nginx_proxy_companion.docker_gen=true label to the docker-gen container.
It also moves the label related detection to runtime (functions.sh: nginx-reload) instead of startup time (entrypoint.sh), because the nginx and docker-gen containers could be redeployed during the lifecycle of the letsencrypt companion, and thus, getting different ids.
There's also a new assumption in that I think it's simpler to just recommend using the label instead of volumes-from to detect the nginx-proxy container. The reason is that in some environments (like mine), you can't use volumes-from, but I think you can always use labels.
Note: If you're wandering why I've chosen not to set the variables NGINX_DOCKER_GEN_CONTAINER and NGINX_PROXY_CONTAINER, that's because we can use them to make sure an explicitly set container name takes precedence over a label.
Now I'm running a successful separate containers deployment in Swarm Mode, here's my stack:
version: '3.2'
services:
  nginx:
    image: nginx:alpine
    ports:
      - 80:80
      - 443:443
    volumes:
      - ./nginx/conf.d:/etc/nginx/conf.d
      - ./nginx/vhost.d:/etc/nginx/vhost.d
      - ./nginx/certs:/etc/nginx/certs
      - ./nginx/letsencrypt:/usr/share/nginx/html
    labels:
      - com.github.jrcs.letsencrypt_nginx_proxy_companion.nginx_proxy=true
    deploy:
      placement:
        constraints:
          - node.role == manager

  dockergen:
    image: helder/docker-gen
    command: -notify "docker-label-sighup com.github.jrcs.letsencrypt_nginx_proxy_companion.nginx_proxy" -watch /etc/docker-gen/templates/nginx.tmpl /etc/nginx/conf.d/default.conf
    volumes:
      - /var/run/docker.sock:/tmp/docker.sock:ro
      - ./nginx.tmpl:/etc/docker-gen/templates/nginx.tmpl
      - ./nginx/conf.d:/etc/nginx/conf.d
      - ./nginx/vhost.d:/etc/nginx/vhost.d
      - ./nginx/certs:/etc/nginx/certs
    labels:
      - com.github.jrcs.letsencrypt_nginx_proxy_companion.docker_gen=true
    deploy:
      placement:
        constraints:
          - node.role == manager

  letsencrypt:
    image: helder/letsencrypt-nginx-proxy-companion:latest
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock:ro
      - ./nginx/conf.d:/etc/nginx/conf.d
      - ./nginx/vhost.d:/etc/nginx/vhost.d
      - ./nginx/certs:/etc/nginx/certs
      - ./nginx/letsencrypt:/usr/share/nginx/html
    deploy:
      placement:
        constraints:
          - node.role == manager

As you can see, I'm also using a custom helder/docker-gen image which simply adds a docker-label-sighup script that allows me to reload the nginx container from a label, because... well, dynamic names. jwilder/docker-gen doesn't support reloading containers with dynamic names (yet).

Wrong repo 🤦♂


Update our README.md

A lot of open source repos have beautiful & meaningful READMEs, unfortunately this does not apply to our repo (yet!).
This will be more of an open-ended project for anyone willing to take it. Let's try to make our README as nice as possible, while at the same time having the relevant info it needs.
Suggestions that I have:

perhaps a link to our Q&A section on how to create a PR.
Explain that you have to go to the issues page and find issues to work on.
only one issue per pr.

Etc etc. Nothing corny or cheesy please

Hey, I am working on this.


Fix null pointer crash in quest marker renderer

active_quest is null when the current mission's description is selected in the quest log.

good find, but now the question is whether you can have quests in the log, but not an active one?
if that's the case, we should still draw all quests, regardless of whether there is an active one

Could get messy, the ui is reactive but ours is immediate - we may have to hook the compass function or frame to find out the actual value and then it’s not worth the feature

good find, but now the question is whether you can have quests in the log, but not an active one?

Good call, and the answer is yes. I managed to get this to happen by making a new character in Pre-Searing, taking Message from a Friend and Warrior Test, then selecting Message from a Friend in the quest log and completing that quest.  Warrior Test was left in the log but not active.

yep agreed, just don't do the check with the active quest if it's null

There's also a null pointer crash in the filter lambda, where quest is somehow null despite being a reference.   Still working on this.

Done.  Turns out the active quest id for the current mission is -1 so the comparison to QuestID::None  was insufficient.


Images from players etc are already loaded on start and not really cached

Use data-src instead of src there - this is not relevant with new version anymore
In new version we should check, that caching headers are set properly for images.

this is outdated


Cache data endpoint

Issue Reference
This PR addresses the Issue : Fixes #361
Summarize
Cache data endpoint for 5 minutes

Duplicate of #397


Mentions, Whispers, Live tabs stop working on restart

Describe your issue
When starting Chatterino, previous tabs are properly restored, however "/mentions", "/whispers", and "/live" tabs are empty, not fetching their data from the last use (which might be by design), but they also don't "connect" to start functioning from that point forward. The only way to get them working is closing and recreating them as new tabs.
As for the previous data retrieval, it would be useful if this could also be logged/retrieved, since sometimes Chatterino crashes, taking with it an unread tab of mentions/whispers that doesn't get restored.
OS and Chatterino Version
Windows 10 Pro
Chatterino Nightly 2.3.2 (e352d7b31)

but they also don't "connect" to start functioning from that point forward. The only way to get them working is closing and recreating them as new tabs.

Can you elaborate on this part? I'm not sure I understand it correctly

As for the first part, this is a duplicate of #2572, excluding /live that didn't exist before, and I'm unsure if restoring messages makes sense in that split regardless.

As mentioned above the core of your issue is a duplicate, as we pull recent-messages from an external service.
As for the bug part of your issue, I'm unable to replicate it on 97b9bfb, win10, https://i.imgur.com/kI7VCnW.gif
My mentions tab works immediately without any need for the tab to be re-opened.
(Though I did test this on a portable instance)

they also don't "connect" to start functioning from that point forward. The only way to get them working is closing and recreating them as new tabs.

Can't replicate on e352d7b31 - although only tested with whisper and mentions "channels", they seem to work fine after restart. Of course, no history is preserved to reasons alluded to above.

@Coldblackice this might be most likely due to behavoir described in #779, can you confirm? I also sometimes run into this issue myself on rare occasions. A "fix" when this happens is to hold Ctrl and use resize handles between splits to change size of a split with either of those special channels to minimum and messages magically appear there. I'll make sure to post a video / gif next time this happens.

Assigning myself, so I won't lose the track of the issue ;)

this might be most likely due to behavoir described in #779,

can replicate with "smooth scrolling on new messages" on

Closing in favour of #779 as that's the underlying bug - fixing that will fix this


Figure out the reproducible research lunches schedule for Fall 2019

This thread is to build up a schedule for September - December 2019.

Date
Room
Topic & Speaker

30 September
Lovelace
Hacktoberfest by @radka-j

14 October
David Blackwell
Docker for reproducible research by @edwardchalstrey1

28 October
David Blackwell
Good first issues: Project management using GitHub issues by @KirstieJane

11 November
David Blackwell
Data management - maybe @Biostew

25 November
Lovelace
Continuous integration

30 September: HacktoberFest
What on earth is Hacktoberfest? Radka Jersakova will lead a discussion on how to make your first contributions to open source projects....and get a free t-shirt in the process. You don't need to have any experience in open source to join this conversation. Everyone is welcome!
14 October: Docker for reproducible research
Have you ever wondered how to share a reproducible computational environment along with your latest data science project? In our next reproducible research lunch, Ed Chalstrey will give us an introduction to Docker and show us how he used it to run identical analyses on different machines in the TuringBench project.
28 October: Good first issues
Contributing to open source projects is really hard. Even when you find the time it is often hard to know where to start. Kirstie Whitaker will lead a discussion on how to manage your project using GitHub issues, including helpful templates to make sure you have all the information that your collaborators need. It will be helpful for both private and public projects. Everyone is welcome!

I'd love to have another session on continuous integration (travis, appveyor, etc) and more automised ways of deploying packages (compiled files, pypi, conda, etc) and one on docker (or other container-based virtualisations).

What on earth is Hacktoberfest? I will lead a discussion on how to make your first contributions to open source projects....and get a free t-shirt in the process. You don't need to have any experience in open source to join this conversation. Everyone is welcome!

I think a hacktober fest chat would be a perfect kick off! And I would love for you to lead it @radka-j!! Thank you!
@mloning - I'll start sourcing good people to cover CI and docker! (If anyone is reading along please let me know if you can present!) Might be a 2 parter I think - I'd love for CI to be a thing that people get more comfortable with, and docker is really valuable - no point in doing both in a rush 😄

@edwardchalstrey1 has volunteered to give a talk on Docker and its applications in a benchmarking project on the 14th October - thanks Ed! 🚀
@KirstieJane, did you want to lead the session about writing good issues for open source projects that we discussed on Monday? Could put that on the 28th if you're free?

Added a bio! @edwardchalstrey1 - are you able to write 2 sentences about what you'll cover so we can put it in the bulletin for this week?

Closing this issue as we've finished with this round of talks. We're developing a schedule for the next set of talks in #22 - please add ideas and comments there 🙂


Should I be storing intermediate results in redux?

Hi all,
I'm looking for some guidance on this topic, after looking around and can't seem to find any best practices for this.  I have an example of the title question.
Search results from autocomplete/typeahead components.
I have used downshift (an autocomplete component) and intergrated it with redux. The flow is as follows:

On keydown (with some debounce), I raise an action and an api call is made to get the results.
The results are stored in an array in the store
This results array is referenced in the autocomplete component as a prop and the list is rendered.
When a selection is made, another action is raised.
The selected item is used to update the variable representing the selected item in store and the results list is cleared.

The advantage as I see it doing this way is the ability to extract the api call/network request from the component and centralise it at the action creator level. This will make testing my component easier as it's alot dumber.
I have arrived here after doing the api calls inside the component and after reading the myriad of patterns on the web. To me this pattern seems like the state that should be internal to the component is leaking out, but I'm new to this.
Is this an accepted pattern? Am I off base? Are there some practices to keep this tidy?
Thanks,
Prabu

Since they're so ephemeral and generally have no impact on other areas of the application, I generally don't put typeahead results into the store. I treat them like form elements: it's a temporary value that will be committed later, at which point I will put that in the store.

It's always up to you what data you put into the Redux store, and how often you update it.  There's nothing wrong with putting stuff like typeahead data into the store, but as Tim said, there may not be a lot of actual benefit for doing so.

Thanks for the input @timdorr @markerikson.


Research SEP-31 for custom fees on MYKOBO

Context
In order to provide the Vortex user with custom fees agreed with MYKOBO, we need to research the SEP-31 if its possible with this standard to do that
ToDo

[ ] Research if Vortex txn can be authenticated for ex. sharing the client domain id
[ ] Research if custom fees can be applied

@TorstenStueber Please fill in anything more needs to be researched

Hey team! Please add your planning poker estimate with Zenhub @b-yap @ebma @gianfra-t @TorstenStueber

I think the first requirement/todo is not necessary as we already know that this can be done with SEP-10. The other requirement is a little ambiguous. How about we phrase them:

Research if SEP-31 can be used for offramping tokens with Mykobo
Research if SEP-31 allows negotiating custom fees per client_domain

or similar.


Strange zooming behaviour with vector (extended L.geoJson) layers on 1.0.0

I have extended L.geoJson for my own purposes. This extended class takes care of querying the backend with a bbox amongst other tasks. Upon upgrading from 0.7.7 to 1.0.0 I have encountered a strange zooming problem where the vector layers get moved out of sync from the base tile layer. See below:

I'm a bit at a loss for what is causing this. Have you encountered anything similar? Any ideas?
Setting zoomAnimation to false on the map prevents this issue (obviously with a lack of animation).

Seems the same as my problem here
I haven't found a solution yet. Went back to 0.7

@grantHarris can you set up a minimal test case (e.g. on JSFiddle) that reproduces the issue?

@mourner Will do. Might take me a couple days before I have the time, but I'll post back here.

@mourner Not the original poster, but I was able to replicate the issue and trace it down (in my case) to having mapbox.js loaded in after leaflet 1.0.0. See fiddle here
The zoom behavior is normal with 0.7.7, and I haven't delved too deeply into mapbox.js and what may be causing the issue there.

@kdhenry mapbox.js needs some adjustments for 1.0.0, and the released version is tailored for 0.7.7, so this does not appear to be a Leaflet issue.

I just updated my leaflet JS from an older 1.0-dev version to 1.0.0-rc1, and I noticed this behavior occurring when I was using my old css.  Once I updated my leaflet css this behavior was fixed.

Having the same issue (1.0.1), anybody find a solution?

Hi @MarioDabrowski,
The described symptoms are very similar to https://github.com/Leaflet/Leaflet/issues/4774
MuellerMatthew's finding about CSS version mismatch is the same as in the above linked issue.

@MarioDabrowski I can confirm the issue (in my case) was a CSS version mismatch as mentioned by @ghybs

I have the same css version and this issue is still happening sometimes.

@kofronpi please post a minimal example illustrating the issue if you believe this is a problem in Leaflet. With the current information, it is impossible for us to take this further.


ARM64 support at official docker library

rocketchat doesn't have ARM64v8 as a supported architecture in Docker Hub. I have successfully built/tested Rocket.Chat.Embedded.arm64 on an ARM64 platform and it is running successfully.
Also, I have explored to add support for ARM64v8 in the docker hub at the official docker library as mentioned in https://github.com/docker-library/official-images/blob/master/library/rocket.chat#L1 it gets generated through generate-stackbrew-library.sh file present in https://github.com/RocketChat/Docker.Official.Image.
generate-stackbrew-library.sh file needs to be updated to add ARM64v8 arch at the official docker library.
Please share your opinion on this.

I am trying to run Rocket.Chat on armv8 (Raspberry Pi 4). Although there is a snap for it, I would like to use Docker. Using this repository I could build the Docker image, but is the replica database really mandatory? Is it something that the official image uses? Because I believe the official Docker image for Rocket.Chat uses a completely different build process, but I definitely would love to see official support for this.
@odidev May I ask, what were the steps required for you to build the official Docker image? Is it the same build procedure used for x86?

@odidev May I ask, what were the steps required for you to build the official Docker image? Is it the same build procedure used for x86?

@UnleavenedEagle I used the steps mentioned in the README.md of this repository to build the docker image for arm64.
For reference: https://github.com/RocketChat/Rocket.Chat.Embedded.arm64/blob/develop/docker/README.md

@Sing-Li Please share your opinion on this.

@odidev  I'm 100% for making an official arm64 image available if it is now feasible.
Ideally we'd want it to tie in with our regular CI  https://github.com/RocketChat/Rocket.Chat/tree/develop/.docker
But it was not possible even for the amd64 image, unfortuntely.

@Sing-Li we will be happy to support this for arm64, but need your opinion regarding, how can we help if it is not even working on amd64?

@odidev was hoping you might be able to contribute your expertise on making it work 🙂

@Sing-Li I Tried to build the docker image for arm64 and faced some complexities with dependency 'meteor'.
On x86 platform:

Ran the following commands to create the bundle before building the docker image. On x86 platform rocket.chat ran successfully.

meteor build --directory /tmp/build
cp .docker/Dockerfile /tmp/build
cd /tmp/build/
docker build -t rocketchat .

On aarch64 platform:

Ran the same commands to create the bundle for aarch64, got the below error, It looks like meteor doesn't have support for aarch64.

Unsupported Architecture: aarch64
Meteor only supports x86_64

Worked on building the official meteor repository and after modifying a few scripts was able to create dev_bundle for arm64 but while running the same getting Unsupported architecture: aarch64 error for another dependency meteor-promise.

Please share your thoughts on this?

@odidev can you share your compilation steps? I've manage to build the image but when I run it I've get the error Error: /app/bundle/programs/server/npm/node_modules/meteor/accounts-password/node_modules/bcrypt/lib/binding/napi-v3/bcrypt_lib.node: cannot open shared object file: No such file or directory and I am not being able to solve it

Looks like there is still no arm64 docker image for rocket.chat.  :(


[BUG]wrong description of work flow copy tips

version:
dev
i think the tips should be "work flow copy"

if anybody who want to fix this issue ,please leave message, thx

I wiil fix it


Fix: Have githubwebhook monitor a single namespace

When using scope.singleNamespace: true in Helm, expected behaviour is
that the github webhook server behaves the same way as the controller.
The current behaviour is that the webhook server monitors all the
namespaces.

Could you update the docs as well please https://github.com/actions-runner-controller/actions-runner-controller/blob/master/charts/actions-runner-controller/README.md:

The docs need updating as these settings talk about impacting the controller only, this change will mean it impacts the controller and webhook server
Probably worth amending scope.watchNamespace to say that if this is not provided the release namespace is used by default

Good shout @callum-tait-pbx, didn't notice that in the doc.

@mumoshu not sure if you got the chance to review this?

hi @sledigabel, this PR isn't lost, we want to resolve some outstanding issues from the most recent release before merging in more features

@callum-tait-pbx thanks for the quick reply!


[DS-330] Simplify import of css files for components

This adds these imports directly in the built index.css of the components package.
@import url("@hopper-ui/icons/index.css");
@import url("@hopper-ui/tokens/fonts.css");
@import url("@hopper-ui/styled-system/index.css");

Not completely sure this is what we wanted.


Allow changing the anisotropic filter level at run-time per Viewport

Fixes https://github.com/godotengine/godot-proposals/issues/4673
Changes to anisotropic filtering on project settings are real time now and don't need an engine restart, also adds anisotropic_filtering_level property to viewports and can be changed separately.
Added the additional lines do the docs on viewports as well, I'm not sure what to do on the ProjectSettings.xml though besides removing the note about not being able to change at run-time.
A new enum had to be added though similar to MSAA
enum AnisotropicFiltering {
      ANISOTROPY_DISABLED,
      ANISOTROPY_2X,
      ANISOTROPY_4X,
      ANISOTROPY_8X,
      ANISOTROPY_16X,
      ANISOTROPY_MAX
};

I can't speak for the GLES3 changes but the RD ones look good to me, glad to see the effort of splitting the samplers into being per-viewport was continued like this. The change makes sense to me.

Please clean up your commit message, you don't need all the original messages, just a short message describing what's done

Should be good to go now!

You'll need to run godot --doctool, or apply the diff from https://github.com/godotengine/godot/actions/runs/7906991378/job/21584760683?pr=88313 manually, to have the new properties and methods alphabetically sorted in the docs.

@akien-mga never dealt with docs before, thanks for the help

There are possible reasons to avoid using AF on other viewports, say if you're making camera feeds or planar reflections you may not benefit from the filtering due to how they're presented while you'd be paying the cost (albeit slight on today's hardware)

There are possible reasons to avoid using AF on other viewports, say if you're making camera feeds or planar reflections you may not benefit from the filtering due to how they're presented while you'd be paying the cost (albeit slight on today's hardware)

Drawing a real-time satellite minimap with a viewport will also not benefit from anisotropic filtering, since textures will always be viewed head-on in this situation.

I concur with Calinou. Ideally there should be an option to inherit the level from the project setting. Most users would not be willing to change this setting for every Viewport to suit their needs.

The code -as is- right now inherits the value from the project settings when the subviewport is added, so loading a project that had no settings on it prior to this PR would set all viewports to current project value just fine.
I -could- add an extra enum along with the anisotropy levels and make it default that would make subviewports default to project settings, should work out of the box and prevent breaking compatibility.
Would be nice to have a concrete decision and direction about this feature though as it's been almost a whole year and I don't really have the same free time I had early this year.

IMO what Calinou said this should be done for other parameters like MSAA, so is outside of the scope of this PR

Good point, then this could still use a rebase given the conflict.

Should be up to date now!

Thanks!

Thanks! And congrats for your first merged Godot contribution :tada:


Creating new groups on Nodejs

I want to create new uws groups on Nodejs to use them as rooms for broadcast purposes. I was looking for the source code for Nodejs binding to find out if custom groups are supported, but could not find it. I know they are supported in C++ by creating new groups and adding websockets to it. Nodejs uws documentation covers only simple cases.
So, is it possible to create new groups in Nodejs? If yes, how? If no, is source code for Nodejs binding available online, so that I can consider adding that feature to it? I have implemented rooms in Nodejs, but it is not as efficient, as it is not taking advantage of native prepared messages.

Groups are not the same as rooms (as in pubsub). Groups are essentially a palette of callbacks which are shared between all sockets in the group. It's a way to specify a shared behavior without attaching the same callbacks over and over again to every socket.
This does not apply to Node.js since nobody wants it there. You can prepare messages for broadcast without groups, even in Node.js.

I have implemented a stripped down version of socketio api on top of uws and I am happy with the results. I guess prepared messages is all I need. How can I prepare messages from Nodejs? Is it uws specific or Nodejs specific? Can you point me to the right direction?
Big thanks.

Where did you learn about prepared messages and why did you not find how to use them from that source? I don't remember how they look like but uws.js contains them, you just have to open the file and look for them. There are also many other issues about this, you just have to search.


Initial INI backend implementation

Here's a first draft of the INI backend. It's very basic, but it will convert a simple JSON-like configuration AST into INI format and the reverse as well. I included a few basic tests to ensure proper behavior. Please let me know your thoughts.

Can we test error conditions? For example:

key===value
=value
key=

And some weird spacings:

key=   value
  key  =value

Also, I believe this implementation doesn't support nested sections, right?
For example:
[top_section]
foo = bar

[top_section.nested_section]
bar = baz

This should be parsed as:
{
    top_section: {
        foo: 'bar'
        nested_section: {
            bar: 'baz'
        }
    }
}

An idea (doesn't need be done in this PR): can we write a test runner that scans for certain files in tests/ that follow @cmr 's bi-directional format, so we can write INI content and its corresponding JSON and test serializing and de-serializing them?

Hmm, I guess I wasn't aware of the nested section syntax. I'll be sure to implement that.

The INI serialization/deserialization part is quite generic functionality and probably should live in a separate crate. This will avoid code bloat in the reconfix library and will make the code cleaner, since the crate should cover the Rust API guidelines and abstractions will not leak.
I do not see any corresponding spec issues linked to the PR and all CI checks are failing, which gives me the impression that some important steps were skipped.

What is needed for this PR to be completed/approved/merged?

@jviotti I'm working on some more improvements, including the nested section syntax and better error handling. Should this be done in a separate PR or should we merge the current version of this?

@abrodersen Let's do various small PRs that get reviewed and merged fast rather than adding a lot of work in a single big hard-to-merge PR whenever possible!

Ok, I'm going to tidy things up and add a few more test cases. Is that enough to call this complete?

I think so, but I'm not a Rust expert, so probably worth pinging @majorz and @cmr for a Rust-wise approval?

I just checked this branch and the base branch and it looks like they differ in structure too much. That makes the CI tools fail as well. Let's rebase things properly and get the CI tools running again. Then we will have the tests and clippy running there - I am pretty certain that clippy will report things for improvement, since it is quite thorough. Please, ping me on Flowdock in case help is needed with any of that.

Ok, I'll rebase.

I checked why Travis is failing now after the rebase and it looks like the rustfmt check is failing. Can you please copy https://github.com/resin-io-modules/network_manager/blob/master/rustfmt.toml next to Cargo.toml, then run cargo install rustfmt and cargo fmt. That will reformat the files. It is not the optimal formatting, but this is what we got as a current best scenario with Corey (it will get better once rustfmt releases a new version). Then commit all the changed files together with the copied rustfmt.toml and Travis will mark the build as passed.

I checked the code earlier on and it looks good and clean, so I think this is ready for merging now as the CI tools are happy as well.


feat: add navigation state support to routes

in short: this PR is related to #316
Details
Currently in wouter navigation state feature is not available,
that's why we can't pass state to routes like react-router-dom . so I have added this feature.
Examples:
import { Link , useLocation } from "wouter";

// pass state using Link component
<Link href="/foo" state={{ msg: "hello" }} className="active">Hello!</Link>

// get & set state using useLocation hooks
const [location, setLocation, state] = useLocation();

navigate("/user", { state: { msg: "hello" } });

Hi @molefrog can you please let me know what should I need to do to work this in SSR ? I tested it works on browser but according to the test case it showing error on SSR !

@redwanul10 Thank you for your help! I am closing this per https://github.com/molefrog/wouter/issues/316#issuecomment-1822264860.


REF: Split optimal combination input to bold_t1_trans_wf

Closes #2238
Changes proposed in this pull request
For ME-EPI data, splits optimal combination time series before passing to bold_t1_trans_wf. Previously the 4D time series was passed directly, although the workflow assumes a list of 3D files.
Documentation that should be reviewed
N/A

Could you rebase onto maint/20.1.x? As a bug-fix, this should patch smoothly. (If it does not, I can change back to master.)

Seems like the multi-echo smoke test is smoking... Looks like the split node is hanging.

Do we need to reset a Circle cache?

Hmm. It looks like we're getting caught on a bold_split inside bold_t1_trans_wf:
200812-03:15:04,302 nipype.workflow INFO:
	 [MultiProc] Running 1 tasks, and 0 jobs ready. Free memory (GB): 4.09/4.10, Free processors: 1/2.
                     Currently running:
                       * fmriprep_wf.single_subject_02_wf.func_preproc_task_cuedSGT_run_01_echo_1_wf.bold_t1_trans_wf.bold_split

https://github.com/poldracklab/fmriprep/blob/c717c6b216886be5de75627c067018700f0efd75/fmriprep/workflows/bold/registration.py#L349-L358

Hello @emdupre! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file fmriprep/workflows/bold/registration.py:

Line 333:29: E127 continuation line over-indented for visual indent

Did a little cleaning up. If you haven't already pushed forward, could you fetch my remote and cherry-pick bbdb59645548f510458ee4d11ac3c34b94edf4f6?
Otherwise, I'll rebase on whatever you've done.

OK, so it seems that the merge_xforms node in bold_t1_trans_wf is correctly merging the transforms for ds210:
> from nipype.utils.filemanip import loadpkl

> res = loadpkl('result_merge_xforms.pklz')
> res.outputs
out = ['/scratch/fmriprep_wf/single_subject_02_wf/func_preproc_task_cuedSGT_run_01_echo_1_wf/bold_reg_wf/fsl_bbr_wf/fsl2itk_fwd/affine.txt', 'identity', 'identity']

the problem is that the workflow can't actually apply this merged transform:
nipype.workflow CRITICAL:
    fMRIPrep failed: /scratch/fmriprep_wf/single_subject_02_wf/func_preproc_task_cuedSGT_run_01_echo_1_wf/bold_t1_trans_wf/bold_to_t1w_transform/result_bold_to_t1w_transform.pklz

Will this involve an update to MultiApplyTransforms ?

Lol, yup.

@emdupre Hope you don't mind, but I pushed to your branch to get nipreps/niworkflows#554 in here.
I'm unlikely to get a local test environment set up until the morning, so feel free to take over that PR, if you've got the time. I'll make sure you're a maintainer so can push to my PR branches.

I have a couple more commits that I think could address #2236 (https://github.com/poldracklab/fmriprep/compare/25ad6a4...4be67c2) but I don't want to derail this if you want to keep it focused. Though, if you agree with them and want to use them, feel free to pull them in, once we at least see the CI results from this.

Hey, we're passing...

Woohoo, that's great ! :tada:  I was going to leave #2236 as a "good first issue" since it's easy to template after this one, but I think it'd be better to pull the fix into this PR. I'll grab your commits now, thank you !

I think this is ready to go. Since I contributed, a separate reviewer would be good.

The code changes look good (as mentioned in my review), but I did notice that the reports don't seem to have improved. If I look at the ds210 report from this PR and compare it to the one from #2185, the SDC and coregistration sections look exactly the same. Does that make sense?

It should only be once. We're now passing identity transforms if multi-echo is enabled.
What should be changing in the reports?

Sorry, I mean that I thought the xforms were being applied three times before this fix. Once before T2* estimation, then again in the bold_to_T1w workflow, and then again in the bold_to_std workflow.
I just realized that the bold_to_T1w workflow doesn't feed into the bold_to_std workflow, but the HMC and SDC xforms should still have been applied twice before this fix, right (once before T2* estimation and once after)? I assumed that the reports would show less distortion correction after the fix, possibly solving #2230 (see https://github.com/poldracklab/fmriprep/issues/2230#issuecomment-672339997).

The data in the reports don't have any fieldmaps collected. I wonder if it's more visible if we compared reports from ME data with fieldmaps ?

@emdupre Possibly, but shouldn't the SyN warp, when applied twice, result in exaggerated distortion correction?

For the reports, it looks like we show the BOLD reference before and after. Both images are generated pre bold_bold_trans_wf, and so won't reflect any changes to the inputs of any of the *_trans_wfs.

Oh okay. That makes sense. Instead of looking at the reports, then, we need to look at the preprocessed data to see if it's better. I downloaded the MNI-space preproc data from both runs and I think the difference is substantial (although not very easy to see without being able to toggle between them in fslview).
Before fix

After fix

Agreed. I downloaded them, and I would say the new one looks noticeably less distorted. I'm going to merge, and we can ask @JulioAPeraza to rerun with :unstable once the CI completes.

@JulioAPeraza, it looks like nipreps/niworkflows#556 is preventing the DockerHub build from passing, so you may need to wait until that's fixed before you can test this change.


Why is there no sound in the rendered videos in the vocaset/output?

Why is there no sound in the rendered videos in the vocaset/output?

You can use ffmpeg to attach the audio.

I also recommend getting familiar with using the ffmpeg tool

You can use ffmpeg to attach the audio.

It's easy... Just like


Column type checkbox / radio should fire onedition* event

If you have an oneditionend callback, clicking a checkbox or radio button does not fire the assigned callback event.  For now you have to handle it separately.

You must use onchange. Checkbox/Radio do not open or close an editor since are inline web elements.


First test

What's the motivation for moving these into master instead of leaving them in the first-test branch?


Indexing bytes with slice returns int

 Environment data

Language Server version: 2022.3.1
OS and version: win32 x64
Python version (and distribution if applicable, e.g. Anaconda):
python.analysis.indexing: null
python.analysis.typeCheckingMode: off

 Expected behaviour
x = bytes(4)
z = x[1:3]

type of x is bytes (class)
 Actual behaviour
type of x is int

I'm not able to repro the problem as reported.
x = bytes(4)
reveal_type(x) # bytes
z = x[1:3]
reveal_type(z) # bytes

If you index a bytes with an integer rather than a slice, you will get an integer:
a = x[1]
reveal_type(a) # int

I discovered the problem.
I had installed grpc-stub files using pip install grpc-stubs
For some reason, pylance did nothing with them, so I added C:\Python310\Lib\site-packages to Python: stub path in my config:

This caused the stubs to work, but it broke typings of bytes, because if I remove the path, the typings of bytes work again.

Yeah, setting the stub path to point to your site-packages will likely cause lots of problems. Stub packages that are installed in the site-packages directory should be picked up automatically by type checkers. However, some versions of the google stub packages (including the grpc-stubs) use overlapping namespaces and do not properly mark the stubs as "partial", so the presence of multiple google stub packages can cause problems. Make sure you have the latest versions of any google stub packages installed in your environment, and that will hopefully clear up the problem you've hit with grpc-stubs.

Ok, thanks you for your prompt responses @erictraut


Possibility to change the duration and start time of running entry

This should be done in dropdown timer.
For example if you forgot to start the timer. Can be actually only one field. Either start or duration. Duration seems to make more sense.

Duration can in fact now be changed 🎉 , closing


ConditionalDiagonalNormal sampling doesn't work when model is on GPU

Hello,
I am trying to implement a conditional flow model and I use ConditionalDiagonalNormal as the base distribution. The problem I encountered was that when I tried to sample when the model was on gpu I got 'expected device cuda:0 but got device cpu' error. This is because the noise generated by torch.randn is not on gpu. On cpu, it works fine.
https://github.com/bayesiains/nflows/blob/a712b111d152822d6f8caee47ae173dd51320fea/nflows/distributions/normal.py#L116

Thank you for filing an issue, @arashabzd. For ConditionalDiagonalNormal the fix is simple, actually: we have means and log_stds to infer parameters from. Same with DiagonalNormal which has parameters. I'll push a fix for both.
However, things are more complex with StandardNormal, which has neither parameters nor a context model to infer device from. As discussed with @arashabzd over e-mail, I thing the following could work:

Update DiagonalNormal to allow providing mean and std 1D tensors, plus a trainable flag to decide whether register those as parameters or buffers.
Re-implement StandardNormal as DiagonalNormal with mean=0, std=1 (broadcast so we don't actually need to store repeated values), and trainable=False.

Unless there is a better solution.

As people have started to use the library, I'd vote against breaking code by removing StandardNormal. If you think there's a neater default, perhaps we could deprecate it instead?
Couldn't we just give StandardNormal an optional device argument? If the user has another Tensor called foo kicking around, they could pass device=foo.device. If what they really want is a standard normal, that doesn't seem any less neat than forcing them to create a 0 or 1 on the correct device to pass in as mean or std. A device argument is more explicit about what we actually need from the caller, so they're more likely to work out what to fix when their code crashes.
It would be nice if we could fit in with a standard mechanism for a PyTorch user to specify a default device for a block of code, such as a context manager. Unfortunately, I don't think PyTorch provides one(?). There is a context manager for the cuda device, but not for setting cpu vs gpu(?).

As people have started to use the library, I'd vote against breaking code by removing StandardNormal. If you think there's a neater default, perhaps we could deprecate it instead?

Sorry, I haven't explained this well: I am not suggesting to remove StandardNormal, only to implement it via DiagonalNormal internally by pre-setting some parameters. Basically:
class StandardNormal(DiagonalNormal):
    def __init__(self):
        super().__init__(mean=0, std=1, trainable=False)

This shouldn't break any existing code that uses StandardNormal. The right device could be inferred in DiagonalNormal based on parameters/buffers, and would be changed as a part of flow.to(device).

Couldn't we just give StandardNormal an optional device argument? If the user has another Tensor called foo kicking around, they could pass device=foo.device. If what they really want is a standard normal, that doesn't seem any less neat than forcing them to create a 0 or 1 on the correct device to pass in as mean or std. A device argument is more explicit about what we actually need from the caller, so they're more likely to work out what to fix when their code crashes.

Yes, that's an option (although see above for passing 0 and 1 manually: I also think that's unnecessary). A disadvantage is that this is something to do in addition to flow.to(device), and would be unique to StandardNormal.

It would be nice if we could fit in with a standard mechanism for a PyTorch user to specify a default device for a block of code, such as a context manager. Unfortunately, I don't think PyTorch provides one(?). There is a context manager for the cuda device, but not for setting cpu vs gpu(?).

Yes, I am not aware of a context manager for setting a default device, which is unfortunate. One hacky way (which could trivially be turned into a context manager):
torch.set_default_tensor_type('torch.cuda.FloatTensor')

We've done this in NSF experiments, which is why these issues keep popping up. If you're careful and use tensor.new_* functions (e.g. inputs.new_zeros instead of torch.zeros) everywhere things typically work out, but then you have corner-cases like this one.

All makes sense; thanks for your patience :-). Could we give the StandardNormal a dummy parameter (possibly even empty) and pass its .device to torch.randn? If not, what you're proposing makes sense.

All makes sense; thanks for your patience :-).

No worries. :-) Thanks for probing!

Could we give the StandardNormal a dummy parameter (possibly even empty) and pass its .device to torch.randn? If not, what you're proposing makes sense.

Yep, that makes sense, I've toyed with this idea as well. Maybe that's a better immediate fix, with less potential for breaking something. We can then re-consider at a later date if re-implementing as DiagonalNormal makes sense conceptually/practically.

#9 has been merged now, which should hopefully have solved most of GPU-related issues. Feel free to re-open if your particular issue hasn't been resolved by this, letting us know what transform you're using exactly. Cheers.


Configure Netlify to use GOV.UK branded 404 pages

What
In anticipation of moving the Design System to Netlify, configure Netlify to use our custom error page for 404s.
For example, visiting https://govuk-design-system-preview.netlify.app/foo should display the same GOV.UK branded 404 page as seen at https://design-system.service.gov.uk/foo.
Leave the existing nginx config for error pages on PaaS, as it's still needed until we've finished the migration.
Further reading

Existing nginx config for error pages
Netlify's docs on configuring custom 404 pages

Why
So that anyone encountering a broken link or attempting to access a non-existent page sees a GOV.UK branded page that reassures them they are on the right site, and directs them somewhere useful.
Who needs to know about this
Developers
Done when

[x] https://govuk-design-system-preview.netlify.app/foo displays a GOV.UK branded 404 page

Looking good: https://govuk-design-system-preview.netlify.app/foo


Stage 3 tracking

This proposal achieved stage 2 at the May 2018 meeting. This is a tracking issue for getting stage 3.

[x] Complete spec text
[ ] Designated reviewers sign-off:

[ ] @michaelficarra
[x] @mattijs

[x] Editor sign-off (1 required)

[x] @bmeck
@bterlson
@ljharb as a proposal champion, can not perform editor review

@bakkot Out of curiosity, is it expected that stage 3 will be discussed in July?

@bathos Not sure yet; it depends on how much time various committee members have. I'll update when I know.

FYI, this page still says "stage 0 draft":
https://tc39.github.io/proposal-object-from-entries/
Happy to see that this reached stage 2!

@mbrowne thanks, updated in 59f51ca9ee916f26ba9ce5c77d38db67ee5d5b7f

Reviewed the spec text, LGTM

Spec text looks good.

I don't like the fact that 4.d. has a single sub-step (i). This can be removed. Otherwise LGTM.

Hmm, it seems a little long, and hiding the fact that it returns early, if it’s inlined. Why don’t you like the single substep?

@ljharb if X, return has precedence and is used elsewhere in this algorithm so I tend to agree with @michaelficarra that it'd be preferable stylistically.
The only other comment I'd make is that the note at the end could probably just be prose at the top ala how e.g. parseFloat contains a normative description before the algorithm steps.

Otherwise LGTM!

@bathos, update as promised: looks like we're going to try for stage 3 at the July meeting.

This achieved stage 3 at the July 2018 meeting!


create a workflow using Git Actions

Feature Description
We can create a workflow using Git Actions, this workflow will check Lint errors and Type errors in the changes of Pull request. Checking of Lint and Type errors are already implemented in repo and can be run by below command.
pnpm lint && pnpm type-check
Use Case
This feature would check lint errors in the changes of pull request
Benefits
Will benefit the contributors of open source as well the maintainer of the repo in checking the issues of the pull request
Priority
High
Record
-->I agree to follow this project's Code of Conduct
-->I'm a GSSOC'24 contributor
-->I'm willing to provide further clarification or assistance if needed.

Sure @mansi104-ai. Could you address the current linting errors in the codebase through this ticket as well?

Sure ,@dvjsharma
Also, should I configure it for running manually or through REST API endpoints?

By running manually , you can see the workflows under Github actions
through REST API , it will be visible in CLI

I don’t think REST APIs would be feasible for lint checks. Instead I’ll suggest a workflow yml file to have trigger dispatch (for manual trigger) and run on any new pushes. Also, if you are using any external tool (which requires installation) you can configure that in codebase.

Okay, I'll make a yml file in workflows folder in .github .
It will have the workflow for lint and type errors checking
Please assign this issue to me

Go ahead @mansi104-ai

@dvjsharma  i have experice with MERN stack + TS + nextjs  , is there any issue i should work on

Hey @gopalepic, sorry for late response. There are a lot of high priority issues available currently, please take a look.

@dvjsharma thankyou so much , it gives me a ray for contribution in your project
I requested issue #135
Would you pls assign that