error running npm install

just cloned and followed the steps but it seems that npm install is not working out of the box
../../nan/nan_implementation_12_inl.h:103:42: error: no viable conversion from 'v8::Isolate *' to 'Local<v8::Context>'
  return scope.Escape(v8::Function::New( isolate
                                         ^~~~~~~
/Users/mohitg/.node-gyp/12.4.0/include/node/v8.h:183:7: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'v8::Isolate *' to 'const v8::Local<v8::Context> &' for 1st argument
class Local {
      ^
/Users/mohitg/.node-gyp/12.4.0/include/node/v8.h:183:7: note: candidate constructor (the implicit move constructor) not viable: no known conversion from 'v8::Isolate *' to 'v8::Local<v8::Context> &&' for 1st argument
/Users/mohitg/.node-gyp/12.4.0/include/node/v8.h:187:13: note: candidate template ignored: could not match 'Local<type-parameter-0-0>' against 'v8::Isolate *'
  V8_INLINE Local(Local<S> that)
            ^
/Users/mohitg/.node-gyp/12.4.0/include/node/v8.h:4126:22: note: passing argument to parameter 'context' here
      Local<Context> context, FunctionCallback callback,
                     ^
In file included from ../src/binding.cpp:1:
In file included from ../../nan/nan.h:203:
In file included from ../../nan/nan_new.h:189:
../../nan/nan_implementation_12_inl.h:337:37: error: too few arguments to function call, expected 2, have 1
  return v8::StringObject::New(value).As<v8::StringObject>();
         ~~~~~~~~~~~~~~~~~~~~~      ^
/Users/mohitg/.node-gyp/12.4.0/include/node/v8.h:5380:3: note: 'New' declared here
  static Local<Value> New(Isolate* isolate, Local<String> value);
  ^
In file included from ../src/binding.cpp:1:
In file included from ../../nan/nan.h:203:
In file included from ../../nan/nan_new.h:189:
../../nan/nan_implementation_12_inl.h:337:58: error: expected '(' for function-style cast or type construction
  return v8::StringObject::New(value).As<v8::StringObject>();
                                         ~~~~~~~~~~~~~~~~^
../../nan/nan_implementation_12_inl.h:337:60: error: expected expression
  return v8::StringObject::New(value).As<v8::StringObject>();
                                                           ^
In file included from ../src/binding.cpp:1:
../../nan/nan.h:1034:44: error: no matching member function for call to 'ToString'
      v8::Local<v8::String> string = from->ToString();
                                     ~~~~~~^~~~~~~~
/Users/mohitg/.node-gyp/12.4.0/include/node/v8.h:2528:44: note: candidate function not viable: requires single argument 'context', but no arguments were provided
  V8_WARN_UNUSED_RESULT MaybeLocal<String> ToString(
                                           ^
/Users/mohitg/.node-gyp/12.4.0/include/node/v8.h:2544:35: note: candidate function not viable: requires single argument 'isolate', but no arguments were provided
                    Local<String> ToString(Isolate* isolate) const);
                                  ^
In file included from ../src/binding.cpp:1:
../../nan/nan.h:1044:37: error: cannot initialize a parameter of type 'v8::Isolate *' with an lvalue of type 'char *'
        length_ = string->WriteUtf8(str_, static_cast<int>(len), 0, flags);
                                    ^~~~
/Users/mohitg/.node-gyp/12.4.0/include/node/v8.h:2738:26: note: passing argument to parameter 'isolate' here
  int WriteUtf8(Isolate* isolate, char* buffer, int length = -1,
                         ^
In file included from ../src/binding.cpp:1:
../../nan/nan.h:1818:28: warning: 'Set' is deprecated: Use maybe version [-Wdeprecated-declarations]
    New(persistentHandle)->Set(New(key).ToLocalChecked(), value);
                           ^
/Users/mohitg/.node-gyp/12.4.0/include/node/v8.h:3358:3: note: 'Set' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version",
  ^
/Users/mohitg/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
In file included from ../src/binding.cpp:1:
../../nan/nan.h:1824:28: warning: 'Set' is deprecated: Use maybe version [-Wdeprecated-declarations]
    New(persistentHandle)->Set(key, value);
                           ^
/Users/mohitg/.node-gyp/12.4.0/include/node/v8.h:3358:3: note: 'Set' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version",
  ^
/Users/mohitg/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
In file included from ../src/binding.cpp:1:
../../nan/nan.h:1830:28: warning: 'Set' is deprecated: Use maybe version [-Wdeprecated-declarations]
    New(persistentHandle)->Set(index, value);
                           ^
/Users/mohitg/.node-gyp/12.4.0/include/node/v8.h:3367:3: note: 'Set' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version",
  ^
/Users/mohitg/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
In file included from ../src/binding.cpp:1:
../../nan/nan.h:1836:32: warning: 'Get' is deprecated: Use maybe version [-Wdeprecated-declarations]
        New(persistentHandle)->Get(New(key).ToLocalChecked()));
                               ^
/Users/mohitg/.node-gyp/12.4.0/include/node/v8.h:3412:3: note: 'Get' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version", Local<Value> Get(Local<Value> key));
  ^
/Users/mohitg/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
In file included from ../src/binding.cpp:1:
../../nan/nan.h:1842:48: warning: 'Get' is deprecated: Use maybe version [-Wdeprecated-declarations]
    return scope.Escape(New(persistentHandle)->Get(key));
                                               ^
/Users/mohitg/.node-gyp/12.4.0/include/node/v8.h:3412:3: note: 'Get' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version", Local<Value> Get(Local<Value> key));
  ^
/Users/mohitg/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
In file included from ../src/binding.cpp:1:
../../nan/nan.h:1847:48: warning: 'Get' is deprecated: Use maybe version [-Wdeprecated-declarations]
    return scope.Escape(New(persistentHandle)->Get(index));
                                               ^
/Users/mohitg/.node-gyp/12.4.0/include/node/v8.h:3416:3: note: 'Get' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version", Local<Value> Get(uint32_t index));
  ^
/Users/mohitg/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
In file included from ../src/binding.cpp:1:
In file included from ../../nan/nan.h:2657:
../../nan/nan_object_wrap.h:24:25: error: no member named 'IsNearDeath' in 'Nan::Persistent<v8::Object, v8::NonCopyablePersistentTraits<v8::Object> >'
    assert(persistent().IsNearDeath());
           ~~~~~~~~~~~~ ^
/Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/assert.h:93:25: note: expanded from macro 'assert'
    (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __FILE__, __LINE__, #e) : (void)0)
                        ^
In file included from ../src/binding.cpp:1:
In file included from ../../nan/nan.h:2657:
../../nan/nan_object_wrap.h:67:18: warning: 'MarkIndependent' is deprecated: Weak objects are always considered independent. Use TracedGlobal when trying to use EmbedderHeapTracer. Use a strong handle when trying to keep an object alive.
      [-Wdeprecated-declarations]
    persistent().MarkIndependent();
                 ^
/Users/mohitg/.node-gyp/12.4.0/include/node/v8.h:563:3: note: 'MarkIndependent' has been explicitly marked deprecated here
  V8_DEPRECATED(
  ^
/Users/mohitg/.node-gyp/12.4.0/include/node/v8config.h:307:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated(message)))
                            ^
In file included from ../src/binding.cpp:1:
In file included from ../../nan/nan.h:2657:
../../nan/nan_object_wrap.h:124:26: error: no member named 'IsNearDeath' in 'Nan::Persistent<v8::Object, v8::NonCopyablePersistentTraits<v8::Object> >'
    assert(wrap->handle_.IsNearDeath());
           ~~~~~~~~~~~~~ ^
/Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/assert.h:93:25: note: expanded from macro 'assert'
    (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __FILE__, __LINE__, #e) : (void)0)
                        ^
In file included from ../src/binding.cpp:1:
../../nan/nan.h:2337:9: warning: 'Set' is deprecated: Use maybe version [-Wdeprecated-declarations]
  recv->Set(name, GetFunction(tpl).ToLocalChecked());
        ^
../../nan/nan.h:2353:8: note: in instantiation of function template specialization 'Nan::imp::SetMethodAux<v8::Local<v8::Object> >' requested here
  imp::SetMethodAux(recv, fn_name, t, static_cast<T*>(0));
       ^
../src/binding.cpp:350:8: note: in instantiation of function template specialization 'Nan::SetMethod<v8::Object, Local>' requested here
  Nan::SetMethod(target, "render", render);
       ^
/Users/mohitg/.node-gyp/12.4.0/include/node/v8.h:3358:3: note: 'Set' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version",
  ^
/Users/mohitg/.node-gyp/12.4.0/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
10 warnings and 8 errors generated.
make: *** [Release/obj.target/binding/src/binding.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Users/mohitg/Projects/react-laravel-boilerplate/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack     at ChildProcess.emit (events.js:200:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12)
gyp ERR! System Darwin 18.6.0
gyp ERR! command "/Users/mohitg/.nvm/versions/node/v12.4.0/bin/node" "/Users/mohitg/Projects/react-laravel-boilerplate/node_modules/node-gyp/bin/node-gyp.js" "rebuild" "--verbose" "--libsass_ext=" "--libsass_cflags=" "--libsass_ldflags=" "--libsass_library="
gyp ERR! cwd /Users/mohitg/Projects/react-laravel-boilerplate/node_modules/node-sass
gyp ERR! node -v v12.4.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
Build failed with error code: 1
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed.  Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:

This is weird - node-sass seems to have trouble building on your system. What platform are you installing the project on? If it's windows, try installing in a terminal with admin priviliges.

Just running it on MacOS Mojave

Fixed with https://github.com/huwcarwyn/react-laravel-boilerplate/commit/ee2b7b7a61ea438c55a6511357d1edd04c8b4761
I'll leave this issue open, could you confirm the fix for me?

Closing this, managed to replicate and fix


Cailiri (body) renders a strange not recognized letter when using bold typeface.

When typing in Armenian, Calibri renders a strange non-Armenian letter instead of և. It only happens with Calibri (body) bold typeface, the thinner Calibri (header) doesn't have that problem.
I sent this feedback to Microsoft through the Insider channel six months ago but that bug hasn't been fixed yet.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 72c7cadc-6eb0-3a3a-b325-de0aa45e4852
Version Independent ID: 65e39cbd-0456-87d9-2446-d46dd39dce71
Content: Calibri font family - Typography
Content Source: typographydocs/font-list/calibri.md
Product: typography
GitHub Login: @alib-ms
Microsoft Alias: alib

When typing in Armenian, Calibri renders a strange non-Armenian letter instead of և. It only happens with Calibri (body) bold typeface, the thinner Calibri (header) doesn't have that problem.

Calibri does not have that character in the fonts, and does not support Armenian.
So what you are dealing with is a fallback to a different font(s).
You can see which actual font is being substituted by exporting to PDF and then using your PDF reader/editor to check the actual font used on that text.

Calibri does not have that character in the fonts, and does not support Armenian.

Recent versions of Calibri that ship with Windows do include Armenian support. Older versions that may ship with some versions of Office or older versions of Windows do not.
I’ve not had a chance to investigate this issue yet.

Please look into that pretty annoying problem John, because that frequently used letter makes the entire font useless in Armenian.
Many thanks,
Hrachia
Sent from my Galaxy
-------- Original message --------
From: John Hudson @.>
Date: 09/08/2021 04:29 (GMT+04:00)
To: MicrosoftDocs/typography-issues @.>
Cc: hrachia @.>, Author @.>
Subject: Re: [MicrosoftDocs/typography-issues] Cailiri (body) renders a strange not recognized letter when using bold typeface. (#813)
Calibri does not have that character in the fonts, and does not support Armenian.
Recent versions of Calibri that ship with Windows do include Armenian support. Older versions that may ship with some versions of Office or older versions of Windows do not.
I’ve not had a chance to investigate this issue yet.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Ftypography-issues%2Fissues%2F813%23issuecomment-894882492&data=04|01||640590322cbb40f414d208d95accc564|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637640657795924622|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=X%2BSHuyKQUmuxhF3wOEpgsgSjkCpihdjIBEJH6TAqNeg%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAVDZLDSYPDBW4YSCHSVHVXDT34OPBANCNFSM5BXGVIUA&data=04|01||640590322cbb40f414d208d95accc564|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637640657795934608|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=b1TRMvfNn2E%2B0je9r3sJR3JiIlg49cUL519%2BswaQ33Q%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01||640590322cbb40f414d208d95accc564|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637640657795934608|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=ySEryrdYe1xhYtW4qx6rDKlGcMOayngqp%2BIGWMXT6TQ%3D&reserved=0 or Androidhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26utm_campaign%3Dnotification-email&data=04|01||640590322cbb40f414d208d95accc564|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637640657795934608|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=flABNCKRBVVOc3yrRAxpwdzYxzDnSqz3naCpVu3UMa0%3D&reserved=0.

There is definitely something wrong with the font for Armenian. Regular and Bold have characters encoded at U+058B and U+058C (and nothing is encoded there in Unicode) with different glyphs. The glyph in Bold that is desired is at U+058B rather than U+0587 as it should be.

Many thanks Lorna, the issue has been around since the introduction of the new font, hope it won't take long to fix.
With best wishes
Hrachia
Sent from my Galaxy
-------- Original message --------
From: Lorna Evans @.>
Date: 09/08/2021 18:29 (GMT+04:00)
To: MicrosoftDocs/typography-issues @.>
Cc: hrachia @.>, Author @.>
Subject: Re: [MicrosoftDocs/typography-issues] Cailiri (body) renders a strange not recognized letter when using bold typeface. (#813)
There is definitely something wrong with the font for Armenian. Regular and Bold have characters encoded at U+058B and U+058C (and nothing is encoded there in Unicode) with different glyphs. The glyph in Bold that is desired is at U+058B rather than U+0587 as it should be.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Ftypography-issues%2Fissues%2F813%23issuecomment-895272302&data=04|01||f392decc96f64c0778b008d95b4212f8|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637641161605166096|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=Z5HTkax0FVfjw6lcXV2ytOhfGpTXaJ%2FvK7IKTtdc%2Ba0%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAVDZLDV7SNSXE3SJS5XCWJTT37Q37ANCNFSM5BXGVIUA&data=04|01||f392decc96f64c0778b008d95b4212f8|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637641161605176087|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=18J3J5hX1RR%2BfVwd5bfp35nScYUxLMWonq7fLbBJ7HI%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01||f392decc96f64c0778b008d95b4212f8|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637641161605176087|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=iUqLWwG%2F%2Fbk5AAWsBqI9MjfRqtFiZfCGaqr6Pddnu04%3D&reserved=0 or Androidhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26utm_campaign%3Dnotification-email&data=04|01||f392decc96f64c0778b008d95b4212f8|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637641161605186083|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=UPfS%2FBo1jdnCN32pyDx%2BKGv0KJxBoct3tMtvPEWB%2BGo%3D&reserved=0.

Thank you for reporting the issue. We have added Arabic, Hebrew, Armenian and Georgian support in the Calibri font family. I will have this fixed.

It looks like Calibri Bold had three Armenian characters incorrectly encoded.
և, ֋, ֌
Issue has been fixed. Updated fonts checked-in.

Thank you very much! When do you think it will be possible to download the corrected fonts?

From: Basit Ali @.>
Sent: 12 August 2021 19:41
To: MicrosoftDocs/typography-issues @.>
Cc: hrachia @.>; Author @.>
Subject: Re: [MicrosoftDocs/typography-issues] Cailiri (body) renders a strange not recognized letter when using bold typeface. (#813)
It looks like Calibri Bold had three Armenian characters incorrectly encoded.
և, ֋, ֌
Issue has been fixed. Updated fonts checked-in.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Ftypography-issues%2Fissues%2F813%23issuecomment-897794140&data=04|01||0ab8ec470ca24dbe5aab08d95daffd53|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637643832714203479|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=PhC9EX97XoWp1afp%2BRVmTuClDUSXcU2NTtvv9CNEmqE%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAVDZLDR4Y5QXR7OPAOGX2UTT4P2SLANCNFSM5BXGVIUA&data=04|01||0ab8ec470ca24dbe5aab08d95daffd53|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637643832714213469|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=VpCqPQ72bmOSW324Gn%2FwkAdGEFMMxbI8jwB46hu41us%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01||0ab8ec470ca24dbe5aab08d95daffd53|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637643832714213469|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=pSuft%2BXeR1y%2Br3GsN%2ByopNxRaQ7gns4YPhZXb3Zgv6Q%3D&reserved=0 or Androidhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26utm_campaign%3Dnotification-email&data=04|01||0ab8ec470ca24dbe5aab08d95daffd53|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637643832714223467|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=GL1Iq%2BZuW9DX1w%2BUV%2B4pFXdqdpPLLv%2BBEGM6YbeTaGQ%3D&reserved=0.

I have notified the Office team. We are hoping the updated fonts will be shipped sometime in October-November time frame.

Hello,
I have used the Feedback Hub highlighting this problem many times for more than two years now, with no progress and no reply whatsoever, so, in a sense, the Feedback Hub proved just a waste of time. Unfortunately, the issue persists, even with updated Windows 11 and it seems that nobody in Microsoft realizes that that frequent Armenian letter renders Calibri - the default Office font - useless for Armenians..
Many thanks
Hrachia
From: Basit Ali @.>
Sent: 26 October 2021 1:46
To: MicrosoftDocs/typography-issues @.>
Cc: hrachia @.>; Author @.>
Subject: Re: [MicrosoftDocs/typography-issues] Cailiri (body) renders a strange not recognized letter when using bold typeface. (#813)
Windows: The updated Calibri font family will be shipped with the next update of Windows 11.
Office: The updated Calibri font family will be available in the next Cloud font service refresh.
Please note, Office on Windows will always use the local font, and Windows 10 users would not get the updated font unless the servicing team updates the font on the down level. The "Feedback Hub" app (Click Start and type Feedback Hub) is a great way to get more visibility for the issues you care about.

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Ftypography-issues%2Fissues%2F813%23issuecomment-951356603&data=04|01||3f9bcd6f154e409fde9208d99800c5bf|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637707951346508583|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=gp35EpRI9ytrFIrP5nYrVE%2B%2F4f3bXEwH0Pi0XtZ4SHs%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAVDZLDQYYIW7YFNG2EYEZXDUIXFX3ANCNFSM5BXGVIUA&data=04|01||3f9bcd6f154e409fde9208d99800c5bf|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637707951346518574|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=GFpLjXytB%2BWW9Lhzk25hH22BJDQ8dEZX2obxu4OURvk%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01||3f9bcd6f154e409fde9208d99800c5bf|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637707951346528570|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=bfcWV7Zqyp7J30g4B6QEyOhZekahDq90x%2BXksrq5otY%3D&reserved=0 or Androidhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01||3f9bcd6f154e409fde9208d99800c5bf|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637707951346538559|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=P%2BbcT0Xm0ueD%2BEFrpxG%2Br62Rh5SQh4HhUHCSQMgKlzE%3D&reserved=0.

Dear Ali
Thank you, I installed the 22H2 yesterday, and the long-awaited fix was there.
With best wishes
Hrachia
From: Hrachia Kazhoyan
Sent: Friday, 11 March 2022 16:35
To: MicrosoftDocs/typography-issues @.>; MicrosoftDocs/typography-issues @.>
Cc: Author @.***>
Subject: RE: [MicrosoftDocs/typography-issues] Cailiri (body) renders a strange not recognized letter when using bold typeface. (#813)
Hello,
I have used the Feedback Hub highlighting this problem many times for more than two years now, with no progress and no reply whatsoever, so, in a sense, the Feedback Hub proved just a waste of time. Unfortunately, the issue persists, even with updated Windows 11 and it seems that nobody in Microsoft realizes that that frequent Armenian letter renders Calibri - the default Office font - useless for Armenians..
Many thanks
Hrachia
From: Basit Ali<EMAIL_ADDRESS>Sent: 26 October 2021 1:46
To: MicrosoftDocs/typography-issues<EMAIL_ADDRESS>Cc: hrachia<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/typography-issues] Cailiri (body) renders a strange not recognized letter when using bold typeface. (#813)
Windows: The updated Calibri font family will be shipped with the next update of Windows 11.
Office: The updated Calibri font family will be available in the next Cloud font service refresh.
Please note, Office on Windows will always use the local font, and Windows 10 users would not get the updated font unless the servicing team updates the font on the down level. The "Feedback Hub" app (Click Start and type Feedback Hub) is a great way to get more visibility for the issues you care about.

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Ftypography-issues%2Fissues%2F813%23issuecomment-951356603&data=04|01||3f9bcd6f154e409fde9208d99800c5bf|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637707951346508583|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=gp35EpRI9ytrFIrP5nYrVE%2B%2F4f3bXEwH0Pi0XtZ4SHs%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAVDZLDQYYIW7YFNG2EYEZXDUIXFX3ANCNFSM5BXGVIUA&data=04|01||3f9bcd6f154e409fde9208d99800c5bf|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637707951346518574|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=GFpLjXytB%2BWW9Lhzk25hH22BJDQ8dEZX2obxu4OURvk%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01||3f9bcd6f154e409fde9208d99800c5bf|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637707951346528570|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=bfcWV7Zqyp7J30g4B6QEyOhZekahDq90x%2BXksrq5otY%3D&reserved=0 or Androidhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01||3f9bcd6f154e409fde9208d99800c5bf|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637707951346538559|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=P%2BbcT0Xm0ueD%2BEFrpxG%2Br62Rh5SQh4HhUHCSQMgKlzE%3D&reserved=0.

Thank you for reporting the issue and confirming the fix. Sorry that it took so long. I will report your concerns to the Feedback Hub team.
Thanks,
Ali


Reduce maxAge for some README badges

Fixes https://github.com/mcarton/rust-derivative/issues/31.

Spurious error on Apple beta job, I guess?


Allow extension services to be discovered

Description
Druid provides extensive extension support. Extension can define new services, but those services cannot yet be discovered. This PR ensures that they operate like native services. See this ticket for details.
The current code has a static list of node roles. This PR moves the list into a Guice multi-binder so that extensions can add to the list.
Next, the SQL system servers table code is revised to use the Guice-provided list of node roles rather than the hard-coded list.
Then, the /druid/coordinator/v1/cluster is added to include extension roles after the Druid-defined roles. The code imposed a specific order on the roles; those rules are preserved.
Finally, a new endpoint /druid/router/v1/cluster is added. The logic here is that clients start with the router endpoint. To get the list of services, they must first get the list of services to get the coordinator. But, they can't get the list of services without first haven gotten that list. To avoid this Catch-22, the new endpoint provides the list of services from the router itself.
Of course, the SQL servers system table also provides the list of services. The Catch-22 in this case is that if the cluster is broken, SQL is unavailable to help figure out which services are down. Having the native endpoint provides a reliable fallback: as long as the Router and ZK are up, we can learn about other services and see what is missing.
The PR includes some refactoring to make bits of role-related code usable in multiple contexts. Most of the code is not unit testable (we can't run servers in unit tests), but where it is testable, tests are added or modified.

Key changed/added classes in this PR

NodeRoles - A Guice multi-binder to hold the list of Druid- and extension-defined node roles.

This PR has:

[X] been self-reviewed.
[X] added documentation for new or modified features or behaviors.
[X] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[X] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[X] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[X] been tested in a test Druid cluster, in the context of the actual extension service which this PR supports.

Tests mostly pass. There is one IT failure, but it looks like a flake rather than an actual failure. Would some committer please rerun that one test?

Applied requested changes. Added integration tests. These are quite hard to test, so let's wait for the build to tell us what fixes may be needed before doing another review.

Having fun with ITs. In the previous commit, the one I added passed, multiple others failed. When restarted, the one I added failed, all others passed. Trying to find the cause of the intermittent failure. As it turns out, our auto-retry loop does not seem to provide the actual TestNG error so I'm flying blind. Will add logging and try the whole build again.

Converting to draft. Hard to debug the IT failures. Will return later when the ITs are more usable.

Rebased on latest master.

Just wanted to make sure you saw this comment too, on the docs: https://github.com/apache/druid/pull/12222#discussion_r896236263

Failed in an ARM 64 supervisor test which appears to be flaky.

BTW: the change in this PR should be tested in an IT. At present, adding such an IT is quite a chore. Waiting for the IT revision PR to pass tests and merge, then it will be easy to add the required test.

No good deed goes unpunished: the changes from review comments broke something that shows up only in ITs (or an IT is flaky). Am investigating the failure.

Closing for now; too difficult to alter the ITs.


Update the assembly and package version generation

This will generate assembly, file and package versions based on the build id instead of hard coding it in the project file (to current 1.0.5).
The package version will look something like this: Microsoft.Diagnostics.Runtime.1.0.35103.nupkg.  The file and assembly versions will have something similar.
Removed the preview label to generate stable versioning.

/azp run

/azp run

/azp run


Samples

Please provide more samples on how to use the Proxy middleware; dynamic routing and/or selective routing of URIs to backend services etc.

@grahamehorner I strongly agree. I will try to add some samples in my free time to avoid further confusion.

much appreciated; looking around the middleware trying to figure out how to use it; with a few examples I would be happy to document this; looks cool BTW 👍

For dynamic routing please see HttpContext.ProxyRequest extension method. Added in #46

This issue was moved to aspnet/Home#2487


Early failure for HIDDEN root nodes.

Currently if a DAG consists of exactly one node that is a HIDDEN node it passes all validation until finally failing during evaluation. This commit causes this case to fail right away.
Fixes #155

Confirmed that this now matches the Rust code in this case.


feat: Add support for YScope format string.

Description
Adds a new Yscope Formatter based on design in notion.
The format string is parsed once in the formatter class constructor. For each placeholder, we create
an object and store it in a class-level list. The object contains the field name, and a formatter for that field name.
Each field formatter type has its own class. For now, we just have timestamp and round.
Afterwards, when log events are decoded, we iterate through array of placeholders to format the log event fields
Future Work
(1) We will need a way for users to see docs for new format string syntax in another PR.
(2) Add support for default format string
Validation performed
Tested with test event in notion.
{"@timestamp":<PHONE_NUMBER>942,"level": "INFO","thread": 0,"latency_secs": 56.4,"a.bad.key{name}": "org.apache.hadoop.metrics2.impl.MetricsConfig: loaded properties from hadoop-metrics2.properties"}

Summary by CodeRabbit

New Features

Introduced RoundFormatter for rounding numerical values.
Added TimestampFormatter for formatting timestamps with specified patterns.
Launched YScopeFormatter for formatting log events using YScope format strings.
Implemented getNestedJsonValue utility function for retrieving nested JSON values.

Improvements

Updated configuration defaults for log formatting.
Enhanced helper text in the SettingsDialog for better user guidance.

Bug Fixes

Removed deprecated LogbackFormatter to streamline formatting processes.

Reminder to mention this fixes #86.


7.0.5 breaks logging when launched as a cronjob

Thank you for adding logging options in 7.0.5.
It works as expected when FedFetcher is run as a bash job on Debian 11. The same options (or none) do not produce logs when run from a crontab. The paths are all absolute and the same job ran successfully on 7.0.4. I suspect there may be a now be a relative link within FediFetcher.

Hm, I cannot reproduce this. Personally I do run FediFetcher as a cronjob, and I do continue to get my logs.
Can you please share your crontab setup, as well as your FediFetcher config?

Hm. There is nothing in that script that would lead to output being saved to the disk.
The behaviour of the offer hasn’t changed in that log output goes to stdout. So you’d need to redirect it to the log file.

closing this now as stale. feel free to re-open if this is still an issue


getting 403 error every time it tries to comment

same here.

I think this happens if your zeit-team-id is incorrect @linkurzweg

I think this happens if your zeit-team-id is incorrect @linkurzweg

You're right, my mistake, I put in the wrong team ID.


Wiki is incorrect about Fedora

The wiki says images can be found at https://lxrunoffline.apphb.com/download/Fedora, defaulting to rawhide, but this gives a 404. Either the wiki or  lxrunoffline.apphb.com should be updated.

It seems that the repo it relies on no longer provides the image named "rawhide". I just updated the website to use the latest version number, which should be the current development version. Could you please check if it works now?

https://lxrunoffline.apphb.com/download/Fedora does now get me to Fedora 33, i.e. what you wrote. The mention of rawhide should also be removed from the wiki. Thanks.

Well, they're generally the same thing. Rawhide is "the name given to the current development version of Fedora", according Fedora's official wiki. If you take a look at the file you downloaded, you'll find that it does use the rawhide repository (/etc/yum.repos.d/fedora-rawhide.repo). And on Docker Hub, the Fedora's official images also has its 33 and rawhide tags point to exactly the same image. So I don't see any problems calling the image you got "rawhide".

Oh, sorry, I didn’t notice that https://lxrunoffline.apphb.com/download/Fedora/rawhide works again! That was my point. Ok, so everything back in order. Thanks for maintaining those redirections: very time saving.


fix: aspnet/web-api/overview/advanced/configuring-aspnet-web-api.md

setttings -> settings
configuation -> configuration

@nschonni  sorry this repo is being migrated to https://github.com/aspnet/AspNetDocs


OP-1902 - fixed multiple switch to versioned

Describe the bug
If multiple loaded hero version are selected in the scene manager inside maya and user tries to switch all of them to explicit equivalent versions. The change only happens for the first one selected
To Reproduce

load multiple models into scene
open scene manager and change all to hero version
select all again and try changing them to versioned

Task linked: OP-1902 Maya switch to versioned doesn't work with multiple selection


Wrong Data

I use your website all the time to compare my score to the top 20 world Orianna players. But I noticed one player "Back To Paradise (NA)" on the top 20 list has a mastery of 405,762 when in reality on his profile (I also checked him through league client) he only has a mastery of 210,355. He does not deserve to be on the top 20 list and not sure why the data on the high-score 20 is wrong

It looks like that player changed their name and somebody else took their old name. I've fixed this occurrence of the problem and will look into automating the fix. Thanks for the report!

Thanks for being on top of everything and taking care of all of these so quickly. I like the new layout and new features also! Keep up the good work!


[e2e]: nodejs push branch1 default slsa3

Repo: https://github.com/slsa-framework/example-package/tree/branch1
Run: https://github.com/slsa-framework/example-package/actions/runs/10536298452
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.nodejs.push.branch1.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.nodejs.push.branch1.default.slsa3.yml
Trigger: push
Branch: branch1
Date: Sat Aug 24 06:14:31 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/branch1
Run: https://github.com/slsa-framework/example-package/actions/runs/10544650064
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.nodejs.push.branch1.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.nodejs.push.branch1.default.slsa3.yml
Trigger: push
Branch: branch1
Date: Sun Aug 25 06:11:47 UTC 2024
Tests are passing now. Closing this issue.


feat: #2169 - new simple input page for "Stores"

New files:

simple_input_page.dart: Simple input page: we have a list of labels, we add, we remove, we save.
simple_input_page_helpers.dart: Helpers for Simple Input Page.

Impacted files:

category_picker_page.dart: refactored
edit_ingredients_page.dart: refactored
edit_product_page.dart: added an "edit store" button; refactored
nutrition_page_loaded.dart: refactored
product_query.dart: added field for stores
product_refresher.dart: now we return the saved and refreshed product instead of a mere bool

What

This is the first implementation of the new "simple input page".
In that kind of page, we retrieve a list of labels from the product (in this case, the stores).
Labels can be added and removed.
When the end-user Bob exits the page, Bob is being asked to save (or not) the data to the back-end and local database.
I'm glad to say that it works(I had doubt about just adding "Monoprix").
Special message for @teolemon (I know you won't like that) - stores were not part of the data we retrieved from the server. As the refresh is not automatic, you have to refresh manually the products (or start from an empty list of stores).

Screenshot
Added a "Stores" button in the detailed edit page:

landing page
adding...
added

Exiting the page after changes:

Part of

#2169

Codecov Report

Merging #2195 (eef8b51) into develop (2ea0da3) will decrease coverage by 0.99%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #2195      +/-   ##
==========================================
- Coverage     8.86%   7.86%   -1.00%
==========================================
  Files          161     180      +19
  Lines         6623    8837    +2214
==========================================
+ Hits           587     695     +108
- Misses        6036    8142    +2106

Impacted Files
Coverage Δ

...kages/smooth_app/lib/widgets/attribute_button.dart
0.00% <0.00%> (-92.00%)
:arrow_down:

packages/smooth_app/lib/themes/smooth_theme.dart
54.54% <0.00%> (-28.44%)
:arrow_down:

...s/smooth_app/lib/data_models/user_preferences.dart
10.46% <0.00%> (-21.85%)
:arrow_down:

...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart
19.23% <0.00%> (-14.98%)
:arrow_down:

...mooth_app/lib/data_models/product_preferences.dart
26.47% <0.00%> (-4.96%)
:arrow_down:

.../smooth_app/lib/pages/onboarding/welcome_page.dart
0.00% <0.00%> (-3.13%)
:arrow_down:

.../smooth_app/lib/pages/onboarding/scan_example.dart
0.00% <0.00%> (-2.28%)
:arrow_down:

packages/smooth_app/lib/main.dart
15.74% <0.00%> (-2.16%)
:arrow_down:

...s/smooth_app/lib/pages/onboarding/next_button.dart
2.22% <0.00%> (-1.78%)
:arrow_down:

...p/lib/pages/onboarding/consent_analytics_page.dart
0.00% <0.00%> (-1.57%)
:arrow_down:

... and 166 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae54d77...eef8b51. Read the comment docs.

The very strong next candidates are labels since they are paramount for Eco-Score

@teolemon Labels and tags both already have a meaning in off-dart. "terms" instead of "labels"?
About "your" labels, isn't there a limited list of labels we could play with instead of typing them (which made sense for stores). I remember 2 different things:

some endless list of random "terms" like "Médaille d'or Concours 2020 de la Tripe"
a very restricted list of icons cf. #524

Which list should we implement?


Files - is a good name (dupe I know), re-consider a rename.

What feature or improvement do you think would benefit Files?
I know this is a dupe of closed https://github.com/files-community/Files/issues/13619. But...
Bite the bullet and change the name.
You will lose a lot of potential users because the product cannot be found by name. The obscurity of the product's name limits its discoverability, potentially deterring countless potential users. If our intention is to maintain exclusivity, the status quo may suffice. However, if our goal is widespread adoption and market penetration, we must reconsider.
There's too much ambiguity around "Files". There is already a thing called "files" on computers.

"Show me this in Files" -- huh
"Open this in Files" -- what
"Open Files and delete the files"
etc..

Of course, what to call it...
Sticking with something with "Files" in the name might be less dramatic but also limits name options. Some options (that I don't really think are that great, but here they are)

"With its sleek and intuitive design..."  --> "Power Files"
"With its combination of powerful features and ease of use..." (user-friendly)  -->

"Friendly Files"
"Easy Files"
"Effortless Files"

Also, though it claims to be a "file manager app", clearly a name with "file manager" would also make sense. And "Files" works with more than files. Directories are just as important as files.

"FileSysPro"
"File Navigator"
"FF Explorer" (Files and Folders Explorer)
"Easy Files & Folders"
"Ideal Files & Folders"
other stuff...

Let's not forget the precedent set by industry giants. "Google" famously rebranded from "BackRub," demonstrating the transformative potential of a well-executed name change. In our case, such a change could be a catalyst for increased visibility, brand recognition, and ultimately, user adoption.
I say change it big and change it soon. That's my two cents.
Requirements
Change the name...
Files Version
<IP_ADDRESS>
Windows Version
11
Comments
No response

Thank you for your feedback, we saw your comment and we'll keep it in mind👍


[Feature Req] Scheduled maintenance - No outgoing email

Is your feature request related to a problem? Please describe.
For some really low impact maintenance, it could be interesting to indicate them on the status page for transparency reasons but may not be enough to send emails to subscribers. It could help reduce "spam" and catch attention of subscribers as not to receive too much emails.
Describe the solution you'd like
Adding a "Send email notifications" to the schedule maintenance form. By default checked. If unchecked, no email about the new scheduled maintenance will be sent.
Describe alternatives you've considered
Maybe someone have better idea, I don't see any alternative yet.

+1


[5.4] Ability to check if messages exist in any named MessageBag

We quite often use named message bags and for various reasons, the message bags can contain messages with the same keys across multiple form submissions.
Currently in our templates, we have to do something like this...
{if $errors->has('cv_file') || $errors->register->has('cv_file') || $errors->login->has('cv_file')}

{/if}

This PR would allow us to do this...
{if $errors->anyBagHas('cv_file')}

{/if}

I added the anyBagHasAny() method as well to be consistent with the MessageBag functionality.

anyBagHasAny is pretty gnarly. I'm not sure what that name means just glancing at it.

@taylorotwell Yeah, i agree it's a bit of an awful method name, struggling to come up with a better one though.
Verbosely, it means anyMessageBagHasAnyOfTheSpecifiedErrorKeys()
Suggestions welcome from anyone 😕

@JayBizzle Maybe new up a class in a bags() method and have a more fluent interface?
$errors->bags()->has('cv_file')

Went with the suggestion by @BrandonSurowiec

Why not just makes bags() return a simple collection and you could do:
$errors->bags()->contains->hasAny(['foo', 'bar'])

Yes, that would work, but there would be really no need to add even a bags() method as we could simply do this without any of this PR...
$errors->getBags()->contains->hasAny(['foo', 'bar']);

The $errors->bags()->haveAny(['cv_file', 'covering_letter']); is obviously a little more fluent, but I am happy either way as long as I don't have to do those horrible || statements like in my original post. I never thought to use the contains() method like that.

I like ->bags() more than ->getBags()

Closing pending inactivity.


Pluralization code in Verbalizer moved into Pluralizer

@CodiumAI-Agent /describe

Title
Pluralization code in Verbalizer moved into Pluralizer

User description
@CodiumAI-Agent /describe

PR Type
enhancement, tests

Description

Moved pluralization logic from Verbalizer to Pluralizer by introducing MakePluralName method.
Enhanced Pluralizer with additional overloads for GetPluralName.
Updated StringBuilderExtensions and StringExtensions to use Pluralizer for pluralization.
Removed MakePlural method and related dictionary from Verbalizer.
Added new test cases for Pluralizer.MakePluralName.
Removed obsolete test cases for Verbalizer.MakePlural.

Changes walkthrough 📝
Relevant filesEnhancement

StringBuilderExtensions.csUse Pluralizer for pluralization in StringBuilderExtensions

MiKo.Analyzer.Shared/Extensions/StringBuilderExtensions.cs

Replaced Verbalizer.MakePlural with Pluralizer.MakePluralName.

+1/-1

StringExtensions.csUse Pluralizer for pluralization in StringExtensions

MiKo.Analyzer.Shared/Extensions/StringExtensions.cs

Replaced Verbalizer.MakePlural with Pluralizer.MakePluralName.

+1/-1

Pluralizer.csAdd and enhance pluralization methods in Pluralizer

MiKo.Analyzer.Shared/Linguistics/Pluralizer.cs
Added MakePluralName method.  Enhanced GetPluralName method with additional overloads.

+53/-0

Verbalizer.csRemove pluralization logic from Verbalizer

MiKo.Analyzer.Shared/Linguistics/Verbalizer.cs

Removed MakePlural method.
Removed Plurals dictionary.

+0/-27

Tests

PluralizerTests.csAdd tests for Pluralizer's MakePluralName method

MiKo.Analyzer.Tests/Linguistics/PluralizerTests.cs

Added new test cases for MakePluralName.

+9/-0

VerbalizerTests.csRemove tests for Verbalizer's MakePlural method

MiKo.Analyzer.Tests/Linguistics/VerbalizerTests.cs

Removed test cases for MakePlural.

+0/-6

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information


visualfsharp crashes on Visual Studio load (similar to #2917)

I am subscribed to the nightly updates and VS2017 stopped loading suddenly (not necessarily related to the nightly update) with the error message (shown from activity log below).   Oddly uninstalling F# language support doesn't seem to remove the Visual F#tools, but leaves it disabled.  I've tried uninstalling the extension or trying to install the nightly update which is now available and both fail to perturb it.  Have tried uninstalling F# language support and reinstalling and visual studio remains in the same state.  I tried the solution mentioned in issue 2917 but the component cache folder doesn't seem to be present on my machine.

I've included the log at the time of crash in case it's useful.  I have had this happen a couple of times over the last few months.  Last time I repaired VS2017 which fixed the problem but basically blew everything away.   The only other major plugin I run is VsVim
  <entry>
    <record>486</record>
    <time>2017/06/30 03:24:19.929</time>
    <type>Error</type>
    <source>VisualStudio</source>
    <description>LegacySitePackage failed for package [FSharpPackage]Source: 'Microsoft.VisualStudio.Composition' Description: Expected 1 export(s) with contract name "Microsoft.VisualStudio.FSharp.Editor.SettingsPersistence+ISettings" but found 0 after applying applicable constraints.
Microsoft.VisualStudio.Composition.CompositionFailedException: Expected 1 export(s) with contract name "Microsoft.VisualStudio.FSharp.Editor.SettingsPersistence+ISettings" but found 0 after applying applicable constraints.
   at Microsoft.VisualStudio.Composition.ExportProvider.GetExports(ImportDefinition importDefinition)
   at Microsoft.VisualStudio.Composition.ExportProvider.GetExports[T,TMetadataView](String contractName, ImportCardinality cardinality)
   at Microsoft.VisualStudio.Composition.ExportProvider.GetExport[T,TMetadataView](String contractName)
   at Microsoft.VisualStudio.Composition.ExportProvider.GetExport[T](String contractName)
   at Microsoft.VisualStudio.Composition.ExportProvider.GetExport[T]()
   at Microsoft.VisualStudio.Composition.ExportProvider.GetExportedValue[T]()
   at Microsoft.VisualStudio.ComponentModelHost.ComponentModel.GetService[T]()
   at Microsoft.VisualStudio.FSharp.Editor.FSharpPackage.Initialize()
   at Microsoft.VisualStudio.Shell.Package.Microsoft.VisualStudio.Shell.Interop.IVsPackage.SetSite(IServiceProvider sp)</description>
    <guid>{871D2A70-12A2-4E42-9440-425DD92A4116}</guid>

80131500

    <errorinfo></errorinfo>
  </entry>
  <entry>

Related information
Provide any related information

Operating system  win10
Branch  nightly
.NET Runtime, CoreCLR or Mono Version  4.6.1 and lower versions installed
Editing Tools (e.g. VS2017 pro )
Indications of severity - effectively cripples all in editor support for F# until I reinstall visual studio

+1
Provide any related information
Operating system win10
Branch nightly 20170630
Editing Tools (e.g. VS2017 15.2 latest )

This is the error listed above.  Please, we need an MEF expert to look at this @srivatsn @brettfo @Pilchie
<description>LegacySitePackage failed for package [FSharpPackage]Source: '

Microsoft.VisualStudio.Composition'
Description: Expected 1 export(s) with contract name "
Microsoft.VisualStudio.FSharp.Editor.SettingsPersistence+ISettings" but found 0 after applying applicable constraints.
Microsoft.VisualStudio.Composition.CompositionFailedException: Expected 1 export(s) with contract name "
Microsoft.VisualStudio.FSharp.Editor.SettingsPersistence+ISettings" but found 0 after applying applicable constraints.

at Microsoft.VisualStudio.Composition.ExportProvider.GetExports(ImportDefinition importDefinition)

at Microsoft.VisualStudio.Composition.ExportProvider.GetExports[T,TMetadataView](String contractName, ImportCardinality cardinality)

at Microsoft.VisualStudio.Composition.ExportProvider.GetExport[T,TMetadataView](String contractName)
   at Microsoft.VisualStudio.Composition.ExportProvider.GetExport[T](String contractName)

at Microsoft.VisualStudio.Composition.ExportProvider.GetExportT

at Microsoft.VisualStudio.Composition.ExportProvider.GetExportedValueT

at Microsoft.VisualStudio.ComponentModelHost.ComponentModel.GetServiceT
   at Microsoft.VisualStudio.FSharp.Editor.FSharpPackage.Initialize()

at Microsoft.VisualStudio.Shell.Package.Microsoft.VisualStudio.Shell.Interop.IVsPackage.SetSite(IServiceProvider sp)

It sounds like the nightly is in a strange, half-installed state.  I would try getting rid of it manually to get back to a clean state:

Open %LocalAppData%\Microsoft\VisualStudio\15.0_xxxxx\Extensions and either delete it all, or find the directory that contains the F# nightly extension.
Delete %LocalAppData%\Microsoft\VisualStudio\15.0_xxxxx\devenv.exe.config
Delete %LocalAppData%\Microrost\VisualStudio\15.0_xxxxx\ComponentModelCache
Start a VS Command prompt and run devenv /updateconfiguration
Run VS and verify that things work as expected.
[Optional] Install the nightly again.

Thanks! - when I first went in I couldn't find the extensions folder.   I ended up doing a repair on VS and it now starts up correctly (lost all my other extensions and settings but it's functional).  I've subscribed to the nightly updates again so let's see what happens.  Will keep the info above in case it happens again.

I'll close, please reopen if it happens again

Time to reopen this.
Got the same after installing Visual Studio 2017 15.5 Preview 2 and checking on the F# Package. I didn't use the nightly build, just the package displayed in the VS Installer
Now I get the typical Visual Studio error dialog box :
---------------------------
Microsoft Visual Studio
---------------------------
The 'FSharpPackage' package did not load correctly.

And ActivityLog.xml contains :
LegacySitePackage failed for package [FSharpPackage]Source: 'Microsoft.VisualStudio.Composition' Description: Expected 1 export(s) with contract name "Microsoft.VisualStudio.FSharp.Editor.SettingsPersistence+ISettings" but found 0 after applying applicable constraints.
Microsoft.VisualStudio.Composition.CompositionFailedException: Expected 1 export(s) with contract name "Microsoft.VisualStudio.FSharp.Editor.SettingsPersistence+ISettings" but found 0 after applying applicable constraints.
   at Microsoft.VisualStudio.Composition.ExportProvider.GetExports(ImportDefinition importDefinition)
   at Microsoft.VisualStudio.Composition.ExportProvider.GetExports[T,TMetadataView](String contractName, ImportCardinality cardinality)
   at Microsoft.VisualStudio.Composition.ExportProvider.GetExport[T,TMetadataView](String contractName)
   at Microsoft.VisualStudio.Composition.ExportProvider.GetExport[T](String contractName)
   at Microsoft.VisualStudio.Composition.ExportProvider.GetExport[T]()
   at Microsoft.VisualStudio.Composition.ExportProvider.GetExportedValue[T]()
   at Microsoft.VisualStudio.ComponentModelHost.ComponentModel.GetService[T]()
   at Microsoft.VisualStudio.FSharp.Editor.FSharpPackage.Initialize()
   at Microsoft.VisualStudio.Shell.Package.Microsoft.VisualStudio.Shell.Interop.IVsPackage.SetSite(IServiceProvider sp)

F# projects load and build, but the editor is almost unusable. The Enter key doesn't work, syntax colouring doesn't work.
I'll try to remove the package

Had the exact same problem this week (VS2017 15.4.5) with the latest F# Tools nightly. I think the problem
was triggered by updating VS to the latest version.
I've attached the ActivityLog.xml.
ActivityLog.txt

@reijerh Now that 15.5 is released, you should use any nightly build atop that (should you continue to use nightlies).  They won't work for any previous version.

Alright, the 15.5 update just became available it seems here, nice.
(BTW I was able to get it in a working state using these instructions: https://github.com/Microsoft/visualfsharp/issues/3287#issuecomment-312515611 )


yaml variables in azure-pipelines.yml file

I am directly updating an azure-pipelines.yml file to add the docker build step. The docs show the yaml that I'd need to add but they don't explain the variables and how they tie up to the acr registry.
For example where do I get the values for these yaml variables:

$(imageRepository)
$(dockerRegistryServiceConnection)

I thought I could guess these but my builds keep failing as it seems the docker build is trying to tag the image with an invalid tag name.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 45ba2ebe-27c4-111b-18b4-0192d8c3fb3a
Version Independent ID: f48fdf00-e04f-b406-93f3-20b7fad568be
Content: Build and push to Azure Container Registry - Azure Pipelines
Content Source: docs/pipelines/ecosystems/containers/acr-template.md
Product: devops
Technology: devops-cicd
GitHub Login: @shashankbarsin
Microsoft Alias: shasb

And the failing build output is:

invalid argument "//uniun:'0.2.0-feature.docker.246'" for "-t, --tag" flag: invalid reference format

@dazinator this particular document is an end-to-end walkthrough. Take any repository containing a Dockerfile as the starting point, create a new pipeline, and in the template recommendations choose the template corresponding to building and pushing images to Azure Container Registry. If these steps are followed, the $(imageRepository) and $(dockerRegistryServiceConnection) variables should get auto-populated.
Closing this issue for now as this is a question and not an issue with the documentation in this particular end-to-end guide.
For guidance on how to add to your pipeline after the end of this how-to guide, please refer to Docker task and Docker registry service connection.


REQUEST-900-EXCLUSION-RULES-BEFORE-CRS.conf.example: fix old url link

fix old url link from https://blog.spiderlab.com
to https://www.trustwave.com/

Thanks, merging!


Workload with id --source is not recognized.

When running 0.6.7 version of maui-check it fails to install any of the workloads with various error messages about Workload with id --source is not recognized.
Doing a quick check shows that I have .Net 6.0 - Preview 6 installed
The documentation at dotnet workload install says
-s|--source <SOURCE>

Specifies the URI of the NuGet package source to use.
This setting overrides all of the sources specified in the nuget.config files.
Multiple sources can be provided by specifying this option multiple times.
Available starting in .NET 6 Preview 7 SDK.

I could not find a download link for preview 7 and maui-check does not detect this is out of date...

Fixed in 0.7 using 6.0 preview 7


fix: LLVM dependencies issue

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@f1b9a0f). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #114   +/-   ##
=========================================
  Coverage          ?   73.46%
=========================================
  Files             ?        5
  Lines             ?      196
  Branches          ?        0
=========================================
  Hits              ?      144
  Misses            ?       52
  Partials          ?        0

Impacted Files
Coverage Δ

codegen/codegen.go
63.04% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1b9a0f...c62855d. Read the comment docs.


Why use multiple packages rather than just one package with the methods inside like ReactJS or other doe ?

I have seen your page https://github.com/nossas/slate-editor/tree/develop/packages and I wonder by pure curiosity why you haven't merge all the package in the main package, I assume it's for performance but at the end of the day the gain is minimal for the boilerplate IMHO ?  So just a basic question,
thanks for your awesome work

I have "splitted" the slate-editor plugins into multiple packages to permit other developers that already have its own implementation of slate, instead of use slate-editor itself, can use which plugin he desire... without having to "download" the whole slate-editor package in its project. The "fuse" that take me to decide to split plugins into separated packages was this issue.


Update gulpfile.mjs

update current app versions

@Ein-Tim
I am already seeing CWA Android updated to 3.0.2 on my phone.

@MikeMcC399 Yes, same here, but I'm missing the GitHub release. 🥲
But it's probably better to open an issue in the cwa-android repo reg. this.

@Ein-Tim

But it's probably better to open an issue in the cwa-android repo reg. this.

There is no action for the website. If you have concerns, then you should bring them up over there. You might however just wait until Monday for that.


To my staging - Proxy (proxification) support

Adds support for proxies (Google Go does not support it out-of-the-box, so I utilized) rapid7/go-get-proxied

https://github.com/rapid7/go-get-proxied was therefore added to dependencies.

Add new flag - noProxy - to ignore proxies and connect directly

LGTM. Confict fixed


Add macOS pre-compiled binaries to 3.3 release

Adding pre-compiled binaries for macOS (and Linux if possible) would make it easier for new users to test and adopt GLFW. I think it's important to allow users to compile from the source, but it shouldn't be the only way. A lot of work goes into creating GLFW working properly on macOS and Linux. This extra bit would help the framework reach more users.
(Sorry for all the changes. I accidentally submitted before I finished the issue.)

Agreed, this makes much more sense now that nearly all macOS specific options have been moved to run-time.

+1 would defo love official Linux and Mac binaries

Static and dynamic macOS binaries have been added to the 3.3 release and may even work! Future releases will include macOS binaries. Thank you for getting this started!

Sorry for all the changes. I accidentally submitted before I finished the issue

@RustyMoyher No worries!

+1 would defo love official Linux and Mac binaries

Linux binaries would require a lot more work, but package systems are upgrading to 3.3.

Out of curiosity, what's stopping you from providing Linux binaries? We built them ourselves and it's wasn't too much work, so what's stopping you setting up a nice CI/CD for GLFW and just using that to build binaries on all platforms?

@Perksey It would be significantly more work than Windows or macOS because of the many combinations of options, architectures and distributions involved, while compiling it for one's own system isn't a lot of work.


Feature/shared model allqrs

Same as #751.

Codecov Report

Merging #756 into trunk/shared_model will decrease coverage by 0.85%.
The diff coverage is 17.6%.

@@                  Coverage Diff                   @@
##           trunk/shared_model     #756      +/-   ##
======================================================
- Coverage               42.07%   41.22%   -0.86%
======================================================
  Files                     396      430      +34
  Lines                   13513    13877     +364
  Branches                 7299     7458     +159
======================================================
+ Hits                     5686     5721      +35
- Misses                   1289     1577     +288
- Partials                 6538     6579      +41

Impacted Files
Coverage Δ

...f/query_responses/proto_account_asset_response.hpp
33.33% <ø> (ø)

...el/interfaces/query_responses/role_permissions.hpp
0% <ø> (ø)

...el/interfaces/query_responses/account_response.hpp
0% <ø> (ø)

.../protobuf/query_responses/proto_query_response.hpp
83.33% <ø> (ø)

...nterfaces/query_responses/signatories_response.hpp
0% <ø> (ø)

...nterfaces/query_responses/error_query_response.hpp
0% <ø> (ø)

...odel/interfaces/query_responses/query_response.hpp
0% <ø> (ø)

...odel/interfaces/query_responses/roles_response.hpp
0% <ø> (ø)

shared_model/interfaces/transaction.hpp
0% <ø> (ø)
:arrow_up:

..._model/backend/protobuf/common_objects/account.hpp
0% <0%> (ø)

... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eba47e...3e3c567. Read the comment docs.


Consider Phase Event as a parallel non-interruptive event

We should consider the possibility of executing a non-inerruptive parallel event. For an even X and a scenario:
A-> B -> C
The Phase event X should happen:
A(X) -> B -> C
A -> B(X) -> C
A -> B -> C(X)

Introduce phase chaos

We can have three modes of execution.

in between (between steps)
during (during a step)
both
Where do we define this?

The event to be executed is either on test level or suite level

Examples

A scenario that allows for a specific Non-interruptive class / method. If set it overrides the passed non-interruptive events:

Class InterruptiveEvents {
  public void restartProductServer() {
  }

  public void restartDatabaseServer() {
  }
}

@PhasedTest(canShuffle = true,  interruptedBy=InterruptiveEvents.class)
@Test
public void class MyPhasedTest {
}

When run the standard phase groups are multiplie by the number of event types.

Ok we have the following cases:

Phase
Execution Mode
Split
Shuffle

PRODUCER/CONSUMER
SHUFFLED
true
true

PRODUCER/CONSUMER
Single
true
false

NON_PHASED
N/A
false
false

ASYNCHRONOUS
Single
false
false

ASYNCHRONOUS
SHUFFLED
false
true


Fixing a bug where all workers would reset a task on timeout

...regardless of whether another worker had
Possible fix for #48

Coverage decreased (-0.2%) to 99.804% when pulling eb9ff4b26120a80ced197213cf82b2c4dac0712c on cr-timeout into 83fba00feef9f0dcadb288040163025832c1337e on master.

Coverage decreased (-0.2%) to 99.804% when pulling eb9ff4b26120a80ced197213cf82b2c4dac0712c on cr-timeout into 83fba00feef9f0dcadb288040163025832c1337e on master.

Coverage decreased (-0.2%) to 99.804% when pulling eb9ff4b26120a80ced197213cf82b2c4dac0712c on cr-timeout into 83fba00feef9f0dcadb288040163025832c1337e on master.

Coverage remained the same at 100.0% when pulling d07e2136b3017ea19fe9d974e6eaa10922ec152e on cr-timeout into 83fba00feef9f0dcadb288040163025832c1337e on master.

Coverage remained the same at 100.0% when pulling fa084a29e0b7e1b1bfc58a3df13f5717fccf3887 on cr-timeout into 83fba00feef9f0dcadb288040163025832c1337e on master.


Update DNSCrypt to 1.0.5

Upstream Release Notes

Updated DNSCrypt proxy to version 1.4.3 (from 1.4.1)
Updated libsodium to 1.0.1-minimal (from 0.7.0-minimal)

Derp. Fixed that.

@colstrom Can you squash your commits?

Squashed. Out of habit, I tend to not rebase anything that's been pushed. Forgot that pull requests handle that sanely. ^_^

@colstrom Thanks


4K 60FPS download, please?

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.05.01. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[X] I've verified and I assure that I'm running youtube-dl 2017.05.01

Before submitting an issue make sure you have:

[X] At least skimmed through README and most notably FAQ and BUGS sections
[X] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[X] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add -v flag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
$ youtube-dl -v <your command line>
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2017.05.01
[debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4
[debug] Proxy map: {}
...
<end of log>

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://www.youtube.com/watch?v=XNz-CLzEcCs

Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.

Description of your issue, suggested solution and other information
Explanation of your issue in arbitrary form goes here. Please make sure the description is worded well enough to be understood. Provide as much context and examples as possible.
If work on your issue requires account credentials please provide them or explain how one can obtain them.

4K 60FPS download, please?

-f 'bestvideo[fps=60]+bestaudio/best'.

Meant 8K60FPS :<


Issues on mobile

I've had such fun playing this game! Thank you! I mentioned it on MetaFilter and people mentioned having trouble playing it on iPads and other mobile devices. I did try on my phone and had a little trouble.
Are you interested in ensuring the game works well on mobile? If it's really meant to be desktop-only then please feel free to close this; if you'd like to hear about issues on mobile devices, maybe just with specific browsers, I can make a proper bug report.

Yeah ideally it should work on mobile fine too. It should work already though. Dragging is a little more fiddly - you have to long press for a few hundred ms before dragging, which at the moment is not something that can be avoided.


iOS 9 warnings about unnecessary check for 'iOS'

Thank you for wonderful cocoapod!
Our project minimum deploy target is iOS9. We use Alamofire as cocoapod, required by Moya pod.
Compiler gives us a lot of warnings such as:

⚠  project/Pods/Alamofire/Source/ParameterEncoding.swift:240:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 8.3, OSX 10.10, *) {
           ^
⚠  project/Pods/Alamofire/Source/NetworkReachabilityManager.swift:124:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 9.0, OSX 10.10, *) {
           ^
▸ Compiling Download.swift
⚠  project/Pods/Alamofire/Source/ParameterEncoding.swift:240:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 8.3, OSX 10.10, *) {
           ^
⚠  project/Pods/Alamofire/Source/NetworkReachabilityManager.swift:124:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 9.0, OSX 10.10, *) {
           ^
▸ Compiling Error.swift
⚠  project/Pods/Alamofire/Source/NetworkReachabilityManager.swift:124:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 9.0, OSX 10.10, *) {
           ^
⚠  project/Pods/Alamofire/Source/ParameterEncoding.swift:240:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 8.3, OSX 10.10, *) {
           ^
▸ Compiling Manager.swift
⚠  project/Pods/Alamofire/Source/ParameterEncoding.swift:240:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 8.3, OSX 10.10, *) {
           ^
⚠  project/Pods/Alamofire/Source/NetworkReachabilityManager.swift:124:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 9.0, OSX 10.10, *) {
           ^
▸ Compiling MultipartFormData.swift
⚠  project/Pods/Alamofire/Source/NetworkReachabilityManager.swift:124:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 9.0, OSX 10.10, *) {
           ^
⚠  project/Pods/Alamofire/Source/ParameterEncoding.swift:240:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 8.3, OSX 10.10, *) {
           ^
▸ Compiling NetworkReachabilityManager.swift
⚠  project/Pods/Alamofire/Source/NetworkReachabilityManager.swift:124:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 9.0, OSX 10.10, *) {
           ^
⚠  project/Pods/Alamofire/Source/ParameterEncoding.swift:240:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 8.3, OSX 10.10, *) {
           ^
▸ Compiling Notifications.swift
⚠  project/Pods/Alamofire/Source/NetworkReachabilityManager.swift:124:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 9.0, OSX 10.10, *) {
           ^
⚠  project/Pods/Alamofire/Source/ParameterEncoding.swift:240:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 8.3, OSX 10.10, *) {
           ^
▸ Compiling ParameterEncoding.swift
⚠  project/Pods/Alamofire/Source/ParameterEncoding.swift:240:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 8.3, OSX 10.10, *) {
           ^
⚠  project/Pods/Alamofire/Source/NetworkReachabilityManager.swift:124:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 9.0, OSX 10.10, *) {
           ^
▸ Compiling Request.swift
⚠  project/Pods/Alamofire/Source/NetworkReachabilityManager.swift:124:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 9.0, OSX 10.10, *) {
           ^
⚠  project/Pods/Alamofire/Source/ParameterEncoding.swift:240:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 8.3, OSX 10.10, *) {
           ^
▸ Compiling Response.swift
⚠  project/Pods/Alamofire/Source/NetworkReachabilityManager.swift:124:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 9.0, OSX 10.10, *) {
           ^
⚠  project/Pods/Alamofire/Source/ParameterEncoding.swift:240:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 8.3, OSX 10.10, *) {
           ^
▸ Compiling ResponseSerialization.swift
⚠  project/Pods/Alamofire/Source/NetworkReachabilityManager.swift:124:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 9.0, OSX 10.10, *) {
           ^
⚠  project/Pods/Alamofire/Source/ParameterEncoding.swift:240:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 8.3, OSX 10.10, *) {
           ^
▸ Compiling Result.swift
⚠  project/Pods/Alamofire/Source/NetworkReachabilityManager.swift:124:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 9.0, OSX 10.10, *) {
           ^
⚠  project/Pods/Alamofire/Source/ParameterEncoding.swift:240:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 8.3, OSX 10.10, *) {
           ^
▸ Compiling ServerTrustPolicy.swift
⚠  project/Pods/Alamofire/Source/NetworkReachabilityManager.swift:124:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 9.0, OSX 10.10, *) {
           ^
⚠  project/Pods/Alamofire/Source/ParameterEncoding.swift:240:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 8.3, OSX 10.10, *) {
           ^
▸ Compiling Stream.swift
⚠  project/Pods/Alamofire/Source/NetworkReachabilityManager.swift:124:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 9.0, OSX 10.10, *) {
           ^
⚠  project/Pods/Alamofire/Source/ParameterEncoding.swift:240:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 8.3, OSX 10.10, *) {
           ^
▸ Compiling Timeline.swift
⚠  project/Pods/Alamofire/Source/NetworkReachabilityManager.swift:124:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 9.0, OSX 10.10, *) {
           ^
⚠  project/Pods/Alamofire/Source/ParameterEncoding.swift:240:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 8.3, OSX 10.10, *) {
           ^
▸ Compiling Upload.swift
⚠  project/Pods/Alamofire/Source/ParameterEncoding.swift:240:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 8.3, OSX 10.10, *) {
           ^
⚠  project/Pods/Alamofire/Source/NetworkReachabilityManager.swift:124:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 9.0, OSX 10.10, *) {
           ^
▸ Compiling Validation.swift
⚠  project/Pods/Alamofire/Source/NetworkReachabilityManager.swift:124:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 9.0, OSX 10.10, *) {
           ^
⚠  project/Pods/Alamofire/Source/ParameterEncoding.swift:240:12: unnecessary check for 'iOS'; minimum deployment target ensures guard will always be true
        if #available(iOS 8.3, OSX 10.10, *) {
           ^

Those warnings unfortunately show up even when we set :inhibit_warnings => true in our Podfile.
Would it be possible to have a version of Alamofire for iOS9? Or would it be possible to start version 4.0 with minimum requirements of iOS9?

If you update to the latest version of CocoaPods, you'll no longer see this issue. The latest version of CocoaPods builds Alamofire with the deployment target specified in the podspec.
Cheers. 🍻


chore(deps): update ci dependencies

This PR contains the following updates:

Package
Type
Update
Change

common-dev-assets

digest
793d782 -> 2520c3d

github.com/gruntwork-io/terratest
require
patch
v0.46.0 -> v0.46.1

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
patch
v1.23.7 -> v1.23.10

Release Notes

gruntwork-io/terratest (github.com/gruntwork-io/terratest)
v0.46.1
Compare Source

Description

Updated dependency golang.org/x/net from 0.8.0 to 0.17.0

Related links

https://github.com/gruntwork-io/terratest/pull/1356

terraform-ibm-modules/ibmcloud-terratest-wrapper (github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper)
v1.23.10
Compare Source
Bug Fixes

deps: update module github.com/gruntwork-io/terratest to v0.46.1 (#682) (dec9602)

v1.23.9
Compare Source
Bug Fixes

deps: update gomod (#680) (f4dbcb9)

v1.23.8
Compare Source
Bug Fixes

add extra validation to parsing diffs and prevent panics(#681) (ebe00fe)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

:tada: This PR is included in version 3.0.0 :tada:
The release is available on:

GitHub release
v3.0.0

Your semantic-release bot :package::rocket:


Slim 4.0 Road Map

Here are some intiial thoughts:

[BC break] Extract Slim\Http into separate PSR-7 component (ONLY PSR-7 methods)
[BC break] Create custom decorator classes to hold Slim-specific additions to PSR-7
Accommodate additional media type parsers in request
Address issues reported by Phan
Improve test coverage

Additional ideas:

[BC break] Remove Request, Response and Env from container (@akrabat)
[BC break] Don't set content-length by default. Provide a middleware for people to use if they want to. (@akrabat)
Make it faster (or at least don't slow it down!) (@Cyrille37)
[BC break] Removing Method-Override and providing a middleware (@geggleto)
[BC break] Decide if we need subRequest at all (@codeguy/@silentworks/@geggleto)
Lazy resolve route middlewares (#1635) We already do this with route callable(only resolve the matched one). (@mathmarques)
Look at __invoke and run on App and see if we can consolidate functionality and make them easier to unit test. (@geggleto)
[BC break] Consolidate error handlers for exceptions and PHP 7 errors (@akrabat)
Can we avoid statics in Slim\Http? See #1850 (@Raistlfiren)
[BC break] Look at pathFor()'s parameters? see #1800 (@akrabat)
[BC break] Do something about basePath from Request. Maybe middleware solution instead? (@akrabat)
[BC break] Remove determineRouteBeforeDispatch and make routing a middleware that can be placed where you want it to be. If you don't add it yourself, we would add it immediately before dispatch. (@akrabat)
Use getallheaders() to get the Authorisation header. (irc channel)
Move documentation into main repo and publish to website on each new release. That way we can insist on documentation with the PR.
[BC break] Either rename Slim\Exception\SlimException or remove it.

Please add additional thoughts below.

Removing Method-Override and providing a middleware

subRequest needs to use the request object from the container and not instantiate its own.

Lazy resolve route middlewares (https://github.com/slimphp/Slim/pull/1635)
We already do this with route callable(only resolve the matched one).

This might seem with a gripe, but I really want to look at cleaning up the __invoke and ->run process on the App class. It is extremely challenging to unit test. Ideally my way of thinking both of those methods should be quite similar in execution.

Factory methods for Requests #1688

@silentworks Is subRequest even worth keeping?

@codeguy probably not

@codeguy I have never used it, but others might have and removing it now would be a major BC break which I think we can only do in 4.0 in order to keep semver.

I'd like to see something like a ModelResponseInterface with the following definition:
interface ModelResponseInterface {
    /**
     * @return mixed
    */
    public function getModel();
}

Right now because the framework requires a Response to be returned from middleware it makes it difficult to do things like writing content-type middlewares that marshal models into json/xml/etc. Officially supporting a response type that provides a container to pass models/objects back to middlewares for processing would be really nice. This could be it's own package too. I just think there should be recommended package at least. That way we will hopefully start seeing HAL rendering middlewares and similar things pop up.

I'd like to see something like a ModelResponseInterface with the following definition:
interface ModelResponseInterface {
    /**
     * @return mixed
    */
    public function getModel();
}

Right now because the framework requires a Response to be returned from middleware it makes it difficult to do things like writing content-type middlewares that marshal models into json/xml/etc. Officially supporting a response type that provides a container to pass models/objects back to middlewares for processing would be really nice. This could be it's own package too. I just think there should be recommended package at least. That way we will hopefully start seeing HAL rendering middlewares and similar things pop up.

#1770 Just dropping this here for future reference

Please, for the Slim roadmap, keep the velocity in priority one. It exists several really greats light frameworks like Lumen and Silex. In my mean Slim is the fastest and should keep the lead.
If one like Lumen or Silex is light and fast as Slim, it will be easier to use them because switching between larger (Laravel, Symfony) would be natural.
Cheers

Don't set content-length by default. Provide a middleware for people to use if they want to.

Remove Request, Response and Env from container

@codeguy @akrabat @silentworks ... we should look at Groups again.

With route in a separate middleware and http's classes in a separate repository it seems that Slim's core will not have anything to do with http.
It could be good to define the issue this library want to solve.
it will look like a middleware stack with a container.
On my point of view it could manage any kind of request with the appropriate trinity request/response/router ( http, cli, ... )

Remove the VERSION constant from App? It's fallen behind. See #1886

What about a setting to change the middleware stack(execution) order?
We use the "Last In First Executed" by default, but we could add a setting to change this behaviour to "First In First Executed" like others frameworks.

Either document slim.files option for Route::createFromEnvironment and add tests or remove the Environment argument and rename the function to Route::createFromGlobals [BC break] (see #1899)

Hi, suggestion: allow us to set our own \Slim\Route impl . See #1906 . By now (3.4.2), it is possible, but at risk to break something (since we need to alter part of the Slim\Router::map function to point to our own Route impl)

Better documentation of internals, notably describing the call-stack for an execution of a route action.

Make it possible to initialize the error handlers with an optional PSR 3 logger. The current situation forces you to extend the error handlers to work around the error_log function.

I would like to see subRequest or at least some way to check a uri for a route match and then dispatch that request though the router.

@kwhat I am thinking about dropping subRequest entirely for 4.0 ...

@geggleto I dug through the router code (Slim + FastRoute) and it looks like subRequest can be completely replaced in least in my use case.  +1 for deleting it and also +1 for removing SlimException ;)

Fix error 500 bubble to top on when using unsupported HTTP method https://github.com/slimphp/Slim/issues/2005
Implement missing shortcuts for paths ($app->get, post etc.). HEAD, at least, is missing. https://github.com/slimphp/Slim/issues/2033

Move documentation into main repo and publish to website on each new release. That way we can insist on documentation with the PR.

Recommend adding PHPDoc requirements to the coding standard for this. It would make it much more enforceable.

Try to have a look to https://blackfire.io to add performance in quality build chain.

@Cyrille37 Could you expand some more on wha you mean please?

Move error handling out of core and into middleware?

@akrabat 👍 What about exceptions though... are we catching Exceptions in an application middleware? If so are we adding it by default but allowing users to remove it?

@akrabat 👍 What about exceptions though... are we catching Exceptions in an application middleware? If so are we adding it by default but allowing users to remove it?

Not sure yet. Gut feeling is to provide Middleware\ErrorHandling, but not add it by default, so the migration docs would say:
"Add $app->add('Slim\Middleware\ErrorHandling'); immediately after $app = new Slim\App()"
or something.

My only problem is that there's no way to check in the App and provide users a notification about it. It could technically silently fail which is bad.

Support http-interop (PSR-15). This will change the signature of middleware to:
function (RequestInterface $request, DelegateInterface $next);

Hence add will change to support callables of the format:
$app->add(function($request, $next) {} ):

Which means we need to support the current middleware format.
There are two choices:
$app->add(new DoublePassWrapper(function($request, $response, $next) {} )):

or:
$app->addDoublePassMiddleware(function($request, $response, $next) {} ):

i.e. we either wrap the middleware before calling add or provide a new method for middleware of this format.

Thanks for all the great feedback. I'll organize  these thoughts over the weekend and get them added to our issue tracker.

Need route strategies to be per-route-callable so we have a migration path.

@codeguy we have an issue tracker? 👍

FWIW personally I like the wrapper approach.
$app->add(new DoublePassWrapper(function($request, $response, $next) {} )):

+1 for DoublePassWrapper

Just a thought: Is it possible to distinct middleware type by it's signature and implement some kind of autowiring to preserve compatibility?

It would be great If we could run the whole application through cli .
In my opinion application is separate from how it is going to be called.
In most cases the initiator is a http request from a web server, but each action and each route should be callable though cli commands.
so I think actions shouldn't receive Http Request and Http Response as argument at all.

It would like to define Controller actions like a native callable. This would make the action methods compatible with the PhpStorm autocomplete and refactor functionality.
Example
Instead of this...
$app->get('/user', \App\Controller\UserController::class . ':indexAction);

I would like to define a route like this:
$app->get('/user', ['App\Controller\UserController', 'indexAction]);

@odan I don't think there is currently anything stopping you from doing this.

@silentworks Ah ok, I saw this feature in PHI-DI and thought it would be nice to have it directly in Slim 4.

Additionally you can call:

name of invokable classes: $container->call('My\CallableClass')
object methods (give the class name, not an object): $container->call(['MyClass', 'someMethod'])

In both case, 'My\CallableClass' and 'MyClass' will be resolved by the container using $container->get().

But anyway, this special kind of callable (non-static method as callable) has been deprecated since PHP 7  https://3v4l.org/ORMQ3. My question can therefore be considered closed. Thanks :-)

Some of these things might just be middleware or documentation opportunities but I would like to see.  I also agree with one of the previous posters that slims "Unique selling proposal" is performance and minimalism so take all of this with a grain of salt.

Access to subdomain patterns in routing. e.g. {workspace}.myproject.com
Route binding, I end up writing a lot of boiler plate to get objects/variables from routes, php-di-slim bridge does some things here, would like something like laravel explicit route model binding which should be model/orm agnostic
I would to add data to a route that can be accessed in middleware, for example,  $route->addData(["required_scopes" => ["user"], "name" => "myroute"], then you could write middleware that uses scopes for auth or checks against the name for something.
Document an example or recommended async pattern for slim.  Async is just not optional anymore, it can definitely tip the scales in a framework decision if one framework has robust documented async pattern and another does not.

A big :+1:  on the last point from @michaeldnelson.

Any plan to bump the minimal PHP version to 7.x+ and add scalar type hinting for everything?
5.6 should reach EOL when Slim 4 been released.

@edsgerlin #2421

@edsgerlin @danopz #2175

@mhndev this is where you should use something like https://github.com/php-pm/php-pm/blob/master/bin/ppm and your Slim app works with PSR messages.

native domains and subdomains patterns in routing with easy caching would be nice i think..
thanks for your work guys)

When will stable Slim 4.x be released?

When will stable Slim 4.x be released?

We do not have a date.

Public Announcement
All of the roadmap has been implemented. I feel like we are in a good place to do some alpha testing so we can get some feedback for a beta release.
Before doing anything read the docs
I just finished the first draft of the docs for Slim 4 which are available here. I need feedback please:
http://slim-website.lgse.com
Download an test the 4.x Branch
You may also play around with the 4.x branch and create a simple app with it to test things out.
composer require slim/slim:4.x-dev
Install a PSR-7 Implementation
You will also need to install a PSR-7 implementation and ServerRequestCreator combo. You can use Slim's PSR-7 Implementation or choose one of the ones described on the 4.x branch README: https://github.com/slimphp/Slim/blob/4.x/README.md
composer slim/psr-7:dev-master
Slim 4 DDD API Skeleton Prototype
I also just created a Slim4 Skeleton with a DDD style directory structure and example files and test coverage for everything. I'm not sure if it's the right fit yet as it may be a bit too opinionated but I'd love some feedback:
https://github.com/l0gicgate/Slim-Skeleton/tree/4.x
If you have any questions don't hesitate to ping me, I'm available to help!


[Question] How do you use this?

I'm sorry for appearing inexperienced, I have no clue what to do with all these pipes and streams.
Right now, I'm trying to see if I can take data from the 'lame' library and have it encode and output with this 'opus' library. However, I'm running into issue after issue and I'm sure it's just because I don't understand how this works. I've looked at the example provided and it looks like I need to get a buffer from somewhere, I've also looked at the examples folder and none of them really help.
var mp3File = fs.createReadStream('moon.mp3');
var opusFile = fs.createWriteStream('test.opus');

var mp3Decoder = new Lame.Decoder();
mp3Decoder.on('format', function(format) {
	var rate = 48000;
	var channels = 2;
	var frame_size = rate / 100;

	var opusEncoder = new Opus.OpusEncoder( rate );
	var encoded = opusEncoder.encode( format, frame_size );
});

mp3File.pipe(mp3Decoder);

Throws a C++ error:
node: ../src/node_buffer.cc:103: char* node::Buffer::Data(v8::Handle<v8::Object>): Assertion `obj->HasIndexedPropertiesInExternalArrayData()' failed.
Aborted

I assume because the format isn't an array.
var mp3File = fs.createReadStream('moon.mp3');
var opusFile = fs.createWriteStream('test.opus');

var mp3Decoder = new Lame.Decoder();
mp3Decoder.on('format', function(format) {
	var rate = 48000;
	var channels = 2;
	var frame_size = rate / 100;
	var opusEncodeStream = new Opus.Encoder(rate, channels, frame_size);

	mp3Decoder.pipe(opusEncodeStream).pipe(opusFile);
});

mp3File.pipe(mp3Decoder);

Throws this
events.js:85
      throw er; // Unhandled 'error' event
            ^
TypeError: Invalid non-string/buffer chunk

I guess that means I did that incorrectly.
var mp3File = fs.createReadStream('moon.mp3');
var opusFile = fs.createWriteStream('test.opus');

var mp3Decoder = new Lame.Decoder();
mp3Decoder.on('format', function(format) {
	var rate = 48000;
	var channels = 2;
	var frame_size = rate / 100;

	var opusEncoder = new Opus.OpusEncoder( rate );

	mp3Decoder.pipe(opusEncoder).pipe(opusFile);
});

mp3File.pipe(mp3Decoder);

Throws an undefined error
js:516
  dest.on('unpipe', onunpipe);
       ^
TypeError: undefined is not a function

I have tons of other failed examples, but I figure instead of posting them all, maybe someone who's done this can help me.

Not really sure of what you're trying to do. The following code might be helpful. Note that opus doesn't define a binary encoding for the stream so trying to write it to a file as such is probably not something you want.
"use strict";

var lame = require( 'lame' );
var opus = require( 'opus' );

var mp3Decoder = new lame.Decoder();
var opusEncoder = new opus.Encoder( 48000, 2 );

var output = process.stdin.pipe( mp3Decoder ).pipe( opusEncoder );

output.on( 'data', function( packet ) {
    console.log( console.log( packet ) );
});

Ah, well right now I'm attempting to package opus data into an RTP packet, but I'm just trying to get the data from an mp3 file to the opus encoder first, and oh my god thank you. I think this is exactly what I needed.

Ah, good. Yes. For that the above code should work. The audio data for each opus frame can be read from the output-data packets.

I'm sorry, it all seems to be working now, but I get very distorted audio on the server.  I'm told I'm supposed to be using 20ms frames and I think that might be the issue because I can't find anywhere that I can define that. I tried typing 20 within the frame_size argument area, but apparently that's meant for something different? Do I handle this on my part or is there something I'm missing?


"X-" headers must be ignored for the cache keys

X-headers must be ignored for generate the cache keys.

:+1:

:+1:

v1.7.0