Reactflow bundling error in storybook

Describe the Bug
When I install reactflow (v11.3.2) and use it in a story, the storybook server fails to start with the following errors:
ERROR in ./node_modules/.pnpm/registry.npmjs.org+@reactflow+minimap<EMAIL_ADDRESS>41:31
Module parse failed: Unexpected token (41:31)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
|     const svg = useRef(null);
|     const { boundingRect, viewBB, nodes, rfId, nodeOrigin } = useStore(selector, shallow);
>     const elementWidth = style?.width ?? defaultWidth;
|     const elementHeight = style?.height ?? defaultHeight;
|     const nodeColorFunc = getAttrFunction(nodeColor);
...

ERROR in ./node_modules/.pnpm/registry.npmjs.org+@reactflow+controls<EMAIL_ADDRESS>43:17
Module parse failed: Unexpected token (43:17)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
|     const onZoomInHandler = () => {
|         zoomIn();
>         onZoomIn?.();
|     };
|     const onZoomOutHandler = () => {
...

ERROR in ./node_modules/.pnpm/registry.npmjs.org+@reactflow+core<EMAIL_ADDRESS>43:19
Module parse failed: Unexpected token (43:19)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
|
| function Attribution({ proOptions, position = 'bottom-right' }) {
>     if (proOptions?.hideAttribution) {
|         return null;
|     }
...

ERROR in ./node_modules/.pnpm/registry.npmjs.org+@reactflow+node-toolbar<EMAIL_ADDRESS>8:42
Module parse failed: Unexpected token (8:42)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
| import { createPortal } from 'react-dom';
|
> const selector = (state) => state.domNode?.querySelector('.react-flow__renderer');
| function NodeToolbarPortal({ children }) {
|     const wrapperRef = useStore(selector);
...

Your Example Website or App
No response
Steps to Reproduce the Bug or Issue

Install React Flow
Create a simple flow
Install storybook
Create a story that renders the react component with the simple flow
Run the storybook server

Expected behavior
I expected storybook to be able to bundle reactflow dependencies in my story
Screenshots or Videos

Platform

OS: Windows
Browser: Not Relevant
Version: 11.3.2

Additional context
Note that a similar issue has also been reported by others on stackoverflow here:
https://stackoverflow.com/questions/74423572/importing-reactflow-v11-causes-error-module-parse-failed-unexpected-token
Also note that we've had our storybook server running for almost a year now (meaning various other libraries and stories have been created so far). This error occurred after we started using reactflow, and if we comment out the <ReactFlow> component, the storybook server compiles successfully.

I had a similar problem.
I solved it this way
install npm install --save --save-exact<EMAIL_ADDRESS>Then I deleted the nodeModule folders, and did the installation again.
npm install

yep, with react-scripts@5 it should work.

It's also happened to me; Installing react-script didn't help.

@moklick why does reactflow requires react-script, after adding react-script to my library project its throwing bunch of errors at the time of its build like the following:
[webpack-cli] TypeError: The 'compilation' argument must be an instance of Compilation
at Function.getCompilationHooks (C:\Dev\Git\spa\thumb-components\node_modules\webpack\lib\NormalModule.js:227:10)
at getCompilationHooks (C:\Dev\Git\spa\thumb-components\node_modules@ckeditor\ckeditor5-dev-webpack-plugin\lib\servetranslations.js:207:22)
at C:\Dev\Git\spa\thumb-components\node_modules@ckeditor\ckeditor5-dev-webpack-plugin\lib\servetranslations.js:97:3
at Hook.eval [as call] (eval at create (C:\Dev\Git\spa\thumb-components\node_modules\tapable\lib\HookCodeFactory.js:19:10), :100:1)
at Hook.CALL_DELEGATE [as _call] (C:\Dev\Git\spa\thumb-components\node_modules\tapable\lib\Hook.js:14:14)
at Compiler.newCompilation (C:\Dev\Git\spa\thumb-components\packages\thumb-richtexteditor\node_modules\webpack\lib\Compiler.js:1031:26)
at C:\Dev\Git\spa\thumb-components\packages\thumb-richtexteditor\node_modules\webpack\lib\Compiler.js:1073:29
at Hook.eval [as callAsync] (eval at create (C:\Dev\Git\spa\thumb-components\node_modules\tapable\lib\HookCodeFactory.js:33:10), :6:1)
at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (C:\Dev\Git\spa\thumb-components\node_modules\tapable\lib\Hook.js:18:14)
at Compiler.compile (C:\Dev\Git\spa\thumb-components\packages\thumb-richtexteditor\node_modules\webpack\lib\Compiler.js:1068:28)

I think i have fixed that, ckeditor/ckeditor5-dev-webpack-plugin is deprecated
But i'm getting new error, it seems webpack5 have removed this module 'webpack/lib/MultiEntryPlugin', does anyone know how to fix this ?
info @storybook/react v6.5.13
info
ERR! Error: Cannot find module 'webpack/lib/MultiEntryPlugin'
ERR! Require stack:
ERR! - C:\Dev\Git\spa\plex-react-components\node_modules\globalize-webpack-plugin\ProductionModePlugin.js
ERR! - C:\Dev\Git\spa\plex-react-components\node_modules\globalize-webpack-plugin\index.js
ERR! - C:\Dev\Git\spa\plex-react-components.storybook\webpack-extend.js
ERR! - C:\Dev\Git\spa\plex-react-components.storybook\main.js
ERR! -<EMAIL_ADDRESS>ERR! -<EMAIL_ADDRESS>ERR! -<EMAIL_ADDRESS>ERR! -<EMAIL_ADDRESS>ERR! -<EMAIL_ADDRESS>ERR! -<EMAIL_ADDRESS>ERR! -<EMAIL_ADDRESS>ERR! -<EMAIL_ADDRESS>ERR! -<EMAIL_ADDRESS>ERR!     at Function.Module._resolveFilename (node:internal/modules/cjs/loader:995:15)
ERR!     at Function.Module._load (node:internal/modules/cjs/loader:841:27)
ERR!     at Module.require (node:internal/modules/cjs/loader:1067:19)
ERR!     at require (node:internal/modules/cjs/helpers:103:18)
ERR!     at Object. (C:\Dev\Git\spa\plex-react-components\node_modules\globalize-webpack-plugin\ProductionModePlugin.js:5:26)
ERR!     at Module._compile (node:internal/modules/cjs/loader:1165:14)
ERR!     at Object.Module._extensions..js (node:internal/modules/cjs/loader:1219:10)
ERR!     at Module.load (node:internal/modules/cjs/loader:1043:32)
ERR!     at Function.Module._load (node:internal/modules/cjs/loader:878:12)
ERR!     at Module.require (node:internal/modules/cjs/loader:1067:19)
ERR!     at require (node:internal/modules/cjs/helpers:103:18)
ERR!     at Object. (C:\Dev\Git\spa\plex-react-components\node_modules\globalize-webpack-plugin\index.js:4:30)
ERR!     at Module._compile (node:internal/modules/cjs/loader:1165:14)
ERR!     at Object.Module._extensions..js (node:internal/modules/cjs/loader:1219:10)
ERR!     at Module.load (node:internal/modules/cjs/loader:1043:32)
ERR!     at Function.Module._load (node:internal/modules/cjs/loader:878:12)
ERR!  Error: Cannot find module 'webpack/lib/MultiEntryPlugin'
ERR! Require stack:
ERR! - C:\Dev\Git\spa\plex-react-components\node_modules\globalize-webpack-plugin\ProductionModePlugin.js
ERR! - C:\Dev\Git\spa\plex-react-components\node_modules\globalize-webpack-plugin\index.js
ERR! - C:\Dev\Git\spa\plex-react-components.storybook\webpack-extend.js
ERR! - C:\Dev\Git\spa\plex-react-components.storybook\main.js
ERR! -<EMAIL_ADDRESS>ERR! -<EMAIL_ADDRESS>ERR! -<EMAIL_ADDRESS>ERR! -<EMAIL_ADDRESS>ERR! -<EMAIL_ADDRESS>ERR! -<EMAIL_ADDRESS>ERR! -<EMAIL_ADDRESS>ERR! -<EMAIL_ADDRESS>ERR! -<EMAIL_ADDRESS>ERR!     at Function.Module._resolveFilename (node:internal/modules/cjs/loader:995:15)
ERR!     at Function.Module._load (node:internal/modules/cjs/loader:841:27)
ERR!     at Module.require (node:internal/modules/cjs/loader:1067:19)
ERR!     at require (node:internal/modules/cjs/helpers:103:18)
ERR!     at Object. (C:\Dev\Git\spa\plex-react-components\node_modules\globalize-webpack-plugin\ProductionModePlugin.js:5:26)
ERR!     at Module._compile (node:internal/modules/cjs/loader:1165:14)
ERR!     at Object.Module._extensions..js (node:internal/modules/cjs/loader:1219:10)
ERR!     at Module.load (node:internal/modules/cjs/loader:1043:32)
ERR!     at Function.Module._load (node:internal/modules/cjs/loader:878:12)
ERR!     at Module.require (node:internal/modules/cjs/loader:1067:19)
ERR!     at require (node:internal/modules/cjs/helpers:103:18)
ERR!     at Object. (C:\Dev\Git\spa\plex-react-components\node_modules\globalize-webpack-plugin\index.js:4:30)
ERR!     at Module._compile (node:internal/modules/cjs/loader:1165:14)
ERR!     at Object.Module._extensions..js (node:internal/modules/cjs/loader:1219:10)
ERR!     at Module.load (node:internal/modules/cjs/loader:1043:32)
ERR!     at Function.Module._load (node:internal/modules/cjs/loader:878:12) {
ERR!   code: 'MODULE_NOT_FOUND',
ERR!   requireStack: [
ERR!     'C:\Dev\Git\spa\plex-react-components\node_modules\globalize-webpack-plugin\ProductionModePlugin.js',
ERR!     'C:\Dev\Git\spa\plex-react-components\node_modules\globalize-webpack-plugin\index.js',
ERR!     'C:\Dev\Git\spa\plex-react-components\.storybook\webpack-extend.js',
ERR!     'C:\Dev\Git\spa\plex-react-components\.storybook\main.js',
ERR<EMAIL_ADDRESS>ERR<EMAIL_ADDRESS>ERR<EMAIL_ADDRESS>ERR<EMAIL_ADDRESS>ERR<EMAIL_ADDRESS>ERR<EMAIL_ADDRESS>ERR<EMAIL_ADDRESS>ERR<EMAIL_ADDRESS>ERR<EMAIL_ADDRESS>ERR!   ]
ERR! }
WARN Broken build, fix the error above.
WARN You may need to refresh the browser.
node:internal/modules/cjs/loader:995
const err = new Error(message);
^
Error: Cannot find module 'webpack/lib/MultiEntryPlugin'
Require stack:

C:\Dev\Git\spa\plex-react-components\node_modules\globalize-webpack-plugin\ProductionModePlugin.js
C:\Dev\Git\spa\plex-react-components\node_modules\globalize-webpack-plugin\index.js
C:\Dev\Git\spa\plex-react-components.storybook\webpack-extend.js
C:\Dev\Git\spa\plex-react-components.storybook\main.js
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>at Function.Module._resolveFilename (node:internal/modules/cjs/loader:995:15)
at Function.Module._load (node:internal/modules/cjs/loader:841:27)
at Module.require (node:internal/modules/cjs/loader:1067:19)
at require (node:internal/modules/cjs/helpers:103:18)
at Object. (C:\Dev\Git\spa\plex-react-components\node_modules\globalize-webpack-plugin\ProductionModePlugin.js:5:26)
at Module._compile (node:internal/modules/cjs/loader:1165:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1219:10)
at Module.load (node:internal/modules/cjs/loader:1043:32)
at Function.Module._load (node:internal/modules/cjs/loader:878:12)
at Module.require (node:internal/modules/cjs/loader:1067:19)
at require (node:internal/modules/cjs/helpers:103:18)
at Object. (C:\Dev\Git\spa\plex-react-components\node_modules\globalize-webpack-plugin\index.js:4:30)
at Module._compile (node:internal/modules/cjs/loader:1165:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1219:10)
at Module.load (node:internal/modules/cjs/loader:1043:32)
at Function.Module._load (node:internal/modules/cjs/loader:878:12) {
code: 'MODULE_NOT_FOUND',
requireStack: [
'C:\Dev\Git\spa\plex-react-components\node_modules\globalize-webpack-plugin\ProductionModePlugin.js',
'C:\Dev\Git\spa\plex-react-components\node_modules\globalize-webpack-plugin\index.js',
'C:\Dev\Git\spa\plex-react-components\.storybook\webpack-extend.js',
'C:\Dev\Git\spa\plex-react-components\.storybook\main.js',
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

It doesn't require react-scripts but you need to transpile it. That depends on your setup.

@moklick I would like to know that
since i'm using storybook 6.3.3 which requires webpack 4, does react-flow requires webpack, if yes what would be the compatible version w.r.t webpack 4, since i'm also using ckeditor with webpack 4

@moklick did you got a chance to look over the error on my earlier comment ?

Hey there 👋 i had the same exact issue earlier. What does your ./storybook/main.js look like?

@JanuZz
Matter of fact i did i added @storybook/preset-create-react-app dependency, and it's throwing the same error
ERROR in<EMAIL_ADDRESS>41:31
Module parse failed: Unexpected token (41:31)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
|     const svg = useRef(null);
|     const { boundingRect, viewBB, nodes, rfId, nodeOrigin } = useStore(selector, shallow);

const elementWidth = style?.width ?? defaultWidth;

|     const elementHeight = style?.height ?? defaultHeight;
|     const nodeColorFunc = getAttrFunction(nodeColor);
@ ./node_modules/reactflow/dist/esm/index.js 3:0-35 3:0-35
@ ./packages/thumb-react-flows/src/FlowCanvas.tsx
@ ./packages/thumb-react-flows/src/FlowCanvas.stories.tsx
@ ./packages sync ^.(?:(?:^|[\/]|(?:(?:(?!(?:^|[\/]).).)?)[\/])(?!.)(?=.)[^\/]?.stories.(tsx|js|mdx))$
@ ./generated-stories-entry.js
@ multi<EMAIL_ADDRESS><EMAIL_ADDRESS>(webpack)-hot-middleware/client.js?reload=true&quiet=false&noInfo=undefined ./storybook-init-framework-entry.js<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>./.storybook/preview.js-generated-config-entry.js ./generated-stories-entry.js
However when i hit yarn start, i saw one of the error saying failed to resolve react-script, but i did an clean install(rimraf node_module followed by install)
info @storybook/react v6.5.13
info
info => Loading presets
info => Loading custom manager config
attention => Storybook now collects completely anonymous telemetry regarding usage.
This information is used to shape Storybook's roadmap and prioritize features.
You can learn more, including how to opt-out if you'd not like to participate in this anonymous program, by visiting the following URL:
https://storybook.js.org/telemetry
info Addon-docs: using MDX1
info => Using PostCSS preset with<EMAIL_ADDRESS>ERR! Failed to resolve a react-scripts package.
info => Loading custom manager config
info => Using default Webpack4 setup
10% building 3/9 modules 6 active<EMAIL_ADDRESS>caniuse-lite is outdated. Please run next command yarn upgrade
Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db
This is how my ./storybook/.main.js looks alike
const prettierConfig = require("../.prettierrc");
const extendWebpack = require("./webpack-extend");

module.exports = {
  stories: ["../packages/**/*.stories.@(tsx|js|mdx)"],
  addons: [
    // toolbar
    { name: "@storybook/addon-docs", sourceLoaderOptions: { prettierConfig } },
    "@storybook/addon-viewport",
    "@storybook/addon-controls",

    // panels
    "../packages/storybook-state/src/preset.js",
    "@storybook/addon-actions",
    "@storybook/addon-toolbars",

    // presets
    "@storybook/addon-postcss",
    "@storybook/preset-create-react-app"
  ],
  framework: "@storybook/react",
  webpackFinal: extendWebpack
};

@avishwakarmaplex that's odd, I can run it fine with the same ./storybook/main.js as you. My best guess would be to find some way to upgrade to the latest version of storybook. As I understand it, they changed quite a bit about how they transpile stuff

@JanuZz so problem is i'm using storybook v6.3.3 and using webpack 4,  and since i'm also using ckeditor, it seems like webpack 4 doesn't works well with react-script latest version, it complains a lot and even storybook version also requires webpack4 for the version currently i'm using.
I had heard that storybook is gonna release a new version which won't require webpack, but i don't know when !!!!!!

@avishwakarmaplex and there's no way to get ckeditor to work with storybook v6.5.15? Or are there other things limiting your storybook version?
The only real suggestion I have to solve your problem is to update storybook

@JanuZz There is one thing that is kind of blocking me to upgrade to latest storybook is globalize-webpack-plugin it only works with webpack 4 and below and doesn't work with webpack 5, since i have to remove all my localization code it would be cumbersome which is right now functional
// webpack-extend.js
const { resolve } = require("path");
**const GlobalizePlugin = require("globalize-webpack-plugin");**
const { locales } = require("@locales/culture-locales");
const merge = require("webpack-merge");
const { styles } = require("@ckeditor/ckeditor5-dev-utils");
const CKEditorWebpackPlugin = require("@ckeditor/ckeditor5-dev-webpack-plugin");

const sassModuleRegex = /\.module\.s[ac]ss$/;

module.exports = async (config, { configType }) => {
  // alter storybook config to support CKEditor
  config.module.rules = config.module.rules.map(rule => {
    if (rule.test && rule.test.test("/ckeditor5-/theme/anything.css")) {
      rule.exclude = [...(rule.exclude || []), /ckeditor5-[^/\\]+[/\\]theme[/\\].+\.css$/];
    } else if (rule.test && rule.test.test("/ckeditor5-/theme/anything.svg")) {
      rule.exclude = [
        ...(rule.exclude || []),
        /ckeditor5-[^/\\]+[/\\]theme[/\\]icons[/\\][^/\\]+\.svg$/,
        /ckeditor5-[^/\\]+[/\\]theme[/\\].+\.css$/
      ];
    }
    return rule;
  });

  return merge(config, {
    module: {
      rules: [
        {
          test: /\.s[ac]ss$/,
          exclude: sassModuleRegex,
          loaders: ["style-loader", "css-loader", "postcss-loader", "sass-loader"],
          include: resolve(__dirname, "../packages")
        },
        {
          test: sassModuleRegex,
          include: resolve(__dirname, "../packages"),
          loaders: [
            "style-loader",
            {
              loader: "css-loader",
              options: {
                importLoaders: 1,
                modules: true,
                camelCase: true,
                localIdentName: "[name]__[local]___[hash:base64:5]"
              }
            },
            "postcss-loader",
            "sass-loader"
          ]
        },
        {
          test: /ckeditor5-[^/\\]+[/\\]theme[/\\]icons[/\\][^/\\]+\.svg$/,
          use: ["raw-loader"]
        },
        {
          test: /ckeditor5-[^/\\]+[/\\]theme[/\\].+\.css/,
          use: [
            {
              loader: "style-loader",
              options: {
                injectType: "singletonStyleTag"
              }
            },
            {
              loader: "postcss-loader",
              options: styles.getPostCssConfig({
                themeImporter: {
                  themePath: require.resolve("@ckeditor/ckeditor5-theme-lark")
                },
                minify: true,
                sourceMap: true
              })
            }
          ]
        }
      ]
    },
    plugins: [
      new GlobalizePlugin({
        production: false,
        developmentLocale: "en-US",
        supportedLocales: Object.keys(locales),
        output: "i18n/[locale].[chunkhash].js",
        cldr: locale => locales[locale]
      }),
      new CKEditorWebpackPlugin({ language: "en", buildAllTranslationsToSeparateFiles: true })
    ],
    resolve: {
      alias: {
        "@thumb/culture-timezone": resolve(
          __dirname,
<EMAIL_ADDRESS>        ),
        "@utils": resolve(__dirname, "../packages/thumb-components/src/utils"),
        "@hooks": resolve(__dirname, "../packages/thumb-components/src/hooks"),
        "@arrays-immutable": resolve(__dirname, "../packages/thumb-components/src/arrays-immutable"),
        "@components": resolve(__dirname, "../packages/thumb-components/src/components")
      },
      modules: [
        resolve(__dirname, "../packages/thumb-charts/src"),
        resolve(__dirname, "../packages/thumb-components/src"),
        resolve(__dirname, "../packages/thumb-richtexteditor/src")
      ]
    }
  });
};

any tips ?

@avishwakarmaplex Not really, it's not anything I've delt with before, but my best guess is look for a way to get the plug-ins to work with storybook 6.5.15 or at least above 6.5

I tried to add storybook to our next-js example app and it works fine: https://github.com/wbkd/react-flow-example-apps/blob/storybook/reactflow-nextjs/src/stories/Flow.stories.tsx
Please update to the latest storybook version and feel free to re-open if the issue still occurs.

@moklick / @JanuZz
I was able to build reactflow with my library project
but i ended up with this error

Do you know what could have gone wrong?

My best bet is that it might be related to https://github.com/d3/d3-zoom/issues/167, but its not something I've seen before
TLDR; You might have multiple versions of d3-selection installed, check your package-lock.json

@JanuZz
Yeah i kind of do
so in my package.json it has
//package.json
"devDependencies":  {
"c3": "^0.7.13",
"d3": "^5.8.0"
// More packages
}
I don't know what version of d3 does reactflow requires
So i'm using yarn, so when i installed reactflow it did updated yarn.lock file
`	"<EMAIL_ADDRESS>version "11.1.2"
resolved<EMAIL_ADDRESS>integrity sha512-A/Hfah+l9C7mzZ4IG2Kw9phOTLUPIie2zRFE59EXEwHUmSS91SPaFE464ydclj1Y4+OEYZb7cTiaHiKEzp3OkA==
dependencies:
"@reactflow/core" "11.4.2"
classcat "^5.0.3"
zustand "^4.3.1"
"<EMAIL_ADDRESS>  version "11.1.2"
  resolved<EMAIL_ADDRESS>  integrity sha512-XyZuMOxSmqYnH+MpRxMiZS8uCdPqaWg4Ju4Sv4B1WW6ae5YsgqG9MGgHF1mOc63BhK6gchRtxV9mW+EJoB+6Pg==
  dependencies:
	"@reactflow/core" "11.4.2"
	classcat "^5.0.3"

"<EMAIL_ADDRESS>  version "11.4.2"
  resolved<EMAIL_ADDRESS>  integrity sha512-JVKFNJ3LTVyQXkZCnk5X5bGo01k4uCyYLlenkCEHL7HZ65v9k6WjD+tY4mdO/t1LIZ18t3j7wlhEhvTrjupN9Q==
  dependencies:
	"@types/d3" "^7.4.0"
	"@types/d3-drag" "^3.0.1"
	"@types/d3-selection" "^3.0.3"
	"@types/d3-zoom" "^3.0.1"
	classcat "^5.0.3"
	d3-drag "^3.0.0"
	d3-selection "^3.0.0"
	d3-zoom "^3.0.0"
	zustand "^4.3.1"

"<EMAIL_ADDRESS>  version "11.3.2"
  resolved<EMAIL_ADDRESS>  integrity sha512-tdzV+pJqNxfEdLMZIgIBOhdIxM04PWsWUKx9RdZlZBmo+28RV/lVNh77Qu4L74eNuDTn9CrKH3UmRPy9H0LlfQ==
  dependencies:
	"@reactflow/core" "11.4.2"
	"@types/d3-selection" "^3.0.3"
	"@types/d3-zoom" "^3.0.1"
	classcat "^5.0.3"
	d3-selection "^3.0.0"
	d3-zoom "^3.0.0"
	zustand "^4.3.1"

"<EMAIL_ADDRESS>  version "1.1.2"
  resolved<EMAIL_ADDRESS>  integrity sha512-zzG+s5jY9F1VbBh0na71AuarlQi8BHnkbd6mUCWJf50DPnmk05sEdurky7C9oNccm7wxEYBirBLyW4+1vnn4Nw==
  dependencies:
	"@reactflow/core" "11.4.2"
	classcat "^5.0.3"
	zustand "^4.3.1"

"@types/d3-array@*":
  version "3.0.4"
  resolved<EMAIL_ADDRESS>  integrity sha512-nwvEkG9vYOc0Ic7G7kwgviY4AQlTfYGIZ0fqB7CQHXGyYM6nO7kJh5EguSNA3jfh4rq7Sb7eMVq8isuvg2/miQ==

"@types/d3-contour@*":
  version "3.0.2"
  resolved<EMAIL_ADDRESS>  integrity sha512-k6/bGDoAGJZnZWaKzeB+9glgXCYGvh6YlluxzBREiVo8f/X2vpTEdgPy9DN7Z2i42PZOZ4JDhVdlTSTSkLDPlQ==
  dependencies:
	"@types/d3-array" "*"
	"@types/geojson" "*"

"@types/d3-delaunay@*":
  version "6.0.1"
  resolved<EMAIL_ADDRESS>  integrity sha512-tLxQ2sfT0p6sxdG75c6f/ekqxjyYR0+LwPrsO1mbC9YDBzPJhs2HbJJRrn8Ez1DBoHRo2yx7YEATI+8V1nGMnQ==

"<EMAIL_ADDRESS>  version "3.0.2"
  resolved<EMAIL_ADDRESS>  integrity sha512-qmODKEDvyKWVHcWWCOVcuVcOwikLVsyc4q4EBJMREsoQnR2Qoc2cZQUyFUPgO9q4S3qdSqJKBsuefv+h0Qy+tw==
  dependencies:
	"@types/d3-selection" "*"

"@types/d3-fetch@*":
  version "3.0.2"
  resolved<EMAIL_ADDRESS>  integrity sha512-gllwYWozWfbep16N9fByNBDTkJW/SyhH6SGRlXloR7WdtAaBui4plTP+gbUgiEot7vGw/ZZop1yDZlgXXSuzjA==
  dependencies:
	"@types/d3-dsv" "*"

"@types/d3-scale-chromatic@*":
  version "3.0.0"
  resolved<EMAIL_ADDRESS>  integrity sha512-dsoJGEIShosKVRBZB0Vo3C8nqSDqVGujJU6tPznsBJxNJNwMF8utmS83nvCBKQYPpjCzaaHcrf66iTRpZosLPw==

"@types/d3-scale@*":
  version "4.0.3"
  resolved<EMAIL_ADDRESS>  integrity sha512-PATBiMCpvHJSMtZAMEhc2WyL+hnzarKzI6wAHYjhsonjWJYGq5BXTzQjv4l8m2jO183/4wZ90rKvSeT7o72xNQ==
  dependencies:
	"@types/d3-time" "*"

"<EMAIL_ADDRESS>  version "3.0.4"
  resolved<EMAIL_ADDRESS>  integrity sha512-ZeykX7286BCyMg9sH5fIAORyCB6hcATPSRQpN47jwBA2bMbAT0s+EvtDP5r1FZYJ95R8QoEE1CKJX+n0/M5Vhg==

"<EMAIL_ADDRESS>  version "3.0.2"
  resolved<EMAIL_ADDRESS>  integrity sha512-t09DDJVBI6AkM7N8kuPsnq/3d/ehtRKBN1xSiYjjMCgbiw6HM6Ged5VhvswmhprfKyGvzeTEL/4WBaK9llWvlA==
  dependencies:
	"@types/d3-interpolate" "*"
	"@types/d3-selection" "*"

"<EMAIL_ADDRESS>  version "7.4.0"
  resolved<EMAIL_ADDRESS>  integrity sha512-jIfNVK0ZlxcuRDKtRS/SypEyOQ6UHaFQBKv032X45VvxSJ6Yi5G9behy9h6tNTHTDGh5Vq+KbmBjUWLgY4meCA==
  dependencies:
	"@types/d3-array" "*"
	"@types/d3-axis" "*"
	"@types/d3-brush" "*"
	"@types/d3-chord" "*"
	"@types/d3-color" "*"
	"@types/d3-contour" "*"
	"@types/d3-delaunay" "*"
	"@types/d3-dispatch" "*"
	"@types/d3-drag" "*"
	"@types/d3-dsv" "*"
	"@types/d3-ease" "*"
	"@types/d3-fetch" "*"
	"@types/d3-force" "*"
	"@types/d3-format" "*"
	"@types/d3-geo" "*"
	"@types/d3-hierarchy" "*"
	"@types/d3-interpolate" "*"
	"@types/d3-path" "*"
	"@types/d3-polygon" "*"
	"@types/d3-quadtree" "*"
	"@types/d3-random" "*"
	"@types/d3-scale" "*"
	"@types/d3-scale-chromatic" "*"
	"@types/d3-selection" "*"
	"@types/d3-shape" "*"
	"@types/d3-time" "*"
	"@types/d3-time-format" "*"
	"@types/d3-timer" "*"
	"@types/d3-transition" "*"
	"@types/d3-zoom" "*"

<EMAIL_ADDRESS>  version "5.0.4"
  resolved "https://registry.npmjs.org/classcat/-/classcat-5.0.4.tgz#e12d1dfe6df6427f260f03b80dc63571a5107ba6"
  integrity sha512-sbpkOw6z413p+HDGcBENe498WM9woqWHiJxCq7nvmxe9WmrUmqfAcxpIwAiMtM5Q3AhYkzXcNQHqsWq0mND51g==

"d3-color@1 - 3":
  version "3.1.0"
  resolved "https://registry.npmjs.org/d3-color/-/d3-color-3.1.0.tgz#395b2833dfac71507f12ac2f7af23bf819de24e2"
  integrity sha512-zg/chbXyeBtMQ1LbD/WSoW2DpC3I0mpmPdW+ynRTj/x2DAWYrIY7qeZIHidozwV24m4iavr15lNwIwLxRmOxhA==

"d3-dispatch@1 - 3":
  version "3.0.1"
  resolved "https://registry.npmjs.org/d3-dispatch/-/d3-dispatch-3.0.1.tgz#5fc75284e9c2375c36c839411a0cf550cbfc4d5e"
  integrity sha512-rzUyPU/S7rwUflMyLc1ETDeBj0NRuHKKAcvukozwhshr6g6c5d8zh4c2gQjY2bZ0dXeGLWc1PF174P2tVvKhfg==

"d3-drag@2 - 3"<EMAIL_ADDRESS>  version "3.0.0"
  resolved "https://registry.npmjs.org/d3-drag/-/d3-drag-3.0.0.tgz#994aae9cd23c719f53b5e10e3a0a6108c69607ba"
  integrity sha512-pWbUJLdETVA8lQNJecMxoXfH6x+mO2UQo8rSmZ+QqxcbyA3hfeprFgIT//HW2nlHChWeIIMwS2Fq+gEARkhTkg==
  dependencies:
	d3-dispatch "1 - 3"
	d3-selection "3"

"d3-ease@1 - 3":
  version "3.0.1"
  resolved "https://registry.npmjs.org/d3-ease/-/d3-ease-3.0.1.tgz#9658ac38a2140d59d346160f1f6c30fda0bd12f4"
  integrity sha512-wR/XK3D3XcLIZwpbvQwQ5fK+8Ykds1ip7A2Txe0yxncXSdq1L9skcG7blcedkOX+ZcgxGAmLX1FrRGbADwzi0w==

"d3-interpolate@1 - 3":
  version "3.0.1"
  resolved "https://registry.npmjs.org/d3-interpolate/-/d3-interpolate-3.0.1.tgz#3c47aa5b32c5b3dfb56ef3fd4342078a632b400d"
  integrity sha512-3bYs1rOD33uo8aqJfKP3JWPAibgw8Zm2+L9vBKEHJ2Rg+viTR7o5Mmv5mZcieN+FRYaAOWX5SJATX6k1PWz72g==
  dependencies:
	d3-color "1 - 3"

"d3-selection@2 - 3", d3-selection@3, <EMAIL_ADDRESS>  version "3.0.0"
  resolved "https://registry.npmjs.org/d3-selection/-/d3-selection-3.0.0.tgz#c25338207efa72cc5b9bd1458a1a41901f1e1b31"
  integrity sha512-fmTRWbNMmsmWq6xJV8D19U/gw/bwrHfNXxrIN+HfZgnzqTHp9jOmKMhsTUjXOJnZOdZY9Q28y4yebKzqDKlxlQ==

"d3-timer@1 - 3":
  version "3.0.1"
  resolved "https://registry.npmjs.org/d3-timer/-/d3-timer-3.0.1.tgz#6284d2a2708285b1abb7e201eda4380af35e63b0"
  integrity sha512-ndfJ/JxxMd3nw31uyKoY2naivF+r29V+Lc0svZxe1JvvIRmi8hUsrMvdOwgS1o6uBHmiz91geQ0ylPP0aj1VUA==

"d3-transition@2 - 3":
  version "3.0.1"
  resolved "https://registry.npmjs.org/d3-transition/-/d3-transition-3.0.1.tgz#6869fdde1448868077fdd5989200cb61b2a1645f"
  integrity sha512-ApKvfjsSR6tg06xrL434C0WydLr7JewBB3V+/39RMHsaXTOG0zmt/OAXeng5M5LBm0ojmxJrpomQVZ1aPvBL4w==
  dependencies:
	d3-color "1 - 3"
	d3-dispatch "1 - 3"
	d3-ease "1 - 3"
	d3-interpolate "1 - 3"
	d3-timer "1 - 3"

<EMAIL_ADDRESS>  version "3.0.0"
  resolved "https://registry.npmjs.org/d3-zoom/-/d3-zoom-3.0.0.tgz#d13f4165c73217ffeaa54295cd6969b3e7aee8f3"
  integrity sha512-b8AmV3kfQaqWAuacbPuNbL6vahnOJflOhexLzMMNLga62+/nh0JzvJ0aO/5a5MVgUFGS7Hu1P9P03o3fJkDCyw==
  dependencies:
	d3-dispatch "1 - 3"
	d3-drag "2 - 3"
	d3-interpolate "1 - 3"
	d3-selection "2 - 3"
	d3-transition "2 - 3"

<EMAIL_ADDRESS>  version "11.4.2"
  resolved "https://registry.npmjs.org/reactflow/-/reactflow-11.4.2.tgz#8aeee24baf53bb7938ad41e57a6bbb4d84ca7261"
  integrity sha512-kedccI6S/+/Fj+MFqEqb5bUncyTsr5DTxeAG5TZ6QB6wwNEE6KG3UFsqRaa1wbOtKnEWwOOupq0fDPE1ePUAZQ==
  dependencies:
	"@reactflow/background" "11.1.2"
	"@reactflow/controls" "11.1.2"
	"@reactflow/core" "11.4.2"
	"@reactflow/minimap" "11.3.2"
	"@reactflow/node-toolbar" "1.1.2"

<EMAIL_ADDRESS>  version "1.2.0"
  resolved "https://registry.npmjs.org/use-sync-external-store/-/use-sync-external-store-1.2.0.tgz#7dbefd6ef3fe4e767a0cf5d7287aacfb5846928a"
  integrity sha512-eEgnFxGQ1Ife9bzYs6VLi8/4X6CObHMw9Qr9tPY43iKwsPw8xE8+EFsf/2cFZ5S3esXgpWgtSCtLNS41F+sKPA==

<EMAIL_ADDRESS>  version "1.2.0"
  resolved "https://registry.npmjs.org/use-sync-external-store/-/use-sync-external-store-1.2.0.tgz#7dbefd6ef3fe4e767a0cf5d7287aacfb5846928a"
  integrity sha512-eEgnFxGQ1Ife9bzYs6VLi8/4X6CObHMw9Qr9tPY43iKwsPw8xE8+EFsf/2cFZ5S3esXgpWgtSCtLNS41F+sKPA==

<EMAIL_ADDRESS>  version "4.3.2"
  resolved "https://registry.npmjs.org/zustand/-/zustand-4.3.2.tgz#bb121fcad84c5a569e94bd1a2695e1a93ba85d39"
  integrity sha512-rd4haDmlwMTVWVqwvgy00ny8rtti/klRoZjFbL/MAcDnmD5qSw/RZc+Vddstdv90M5Lv6RPgWvm1Hivyn0QgJw==
  dependencies:
	use-sync-external-store "1.2.0"

`

It seems like updating d3 version to 7.8.2, solved the problem

but unfortunately, it did broke my other components like charts and etc which had written in my library project

FYI inorder to incorporate reactflow to my library project which uses webpack4, storybook 6.3.3 and didn't required @storybook/preset-create-react-app
I just had to add a rule
// webpack-extend.js
config.module.rules.unshift({
test: /.js$/,
include: /node_modules[\/]@?reactflow/,
use: {
loader: "babel-loader"
}
});

It seems like updating d3 version to 7.8.2, solved the problem

FYI inorder to incorporate reactflow to my library project which uses webpack4, storybook 6.3.3 and didn't required @storybook/preset-create-react-app
I just had to add a rule for transpile reactflow using babel-loader i believe // webpack-extend.js
  config.module.rules.unshift({
    test: /\.js$/,
    include: /node_modules[\\\/]@?reactflow/,
    use: {
      loader: "babel-loader"
    }
  });

On my case, similar to this response i fixed up mine with the specific babel-loader for reactflow on webpack 4:
{                 test: /\.js$/,                 include: [                     path.resolve(__dirname, 'src'),                     /node_modules[\/]@?reactflow/                 ],                 use: {                     loader: 'babel-loader',                     options: {                         presets: [['@babel/preset-env', { 'modules': false }], '@babel/preset-react'],                         plugins: [ "@babel/plugin-proposal-class-properties" ]                     },                 },             },

SB still doesn't work with the latest version 11.5.1 even with the proposed solutions

while upgrading to the latest version of the reactflow I've the same probleme and the workaround here doesn't seem to work

I had the exact same problem and managed to fix it.
During compilation, I think more modern JS features such as the Nullish Coalescing Operator and Optional Chaining cause a bit of a commotion.
There are Babel plugins for dealing with them though, so I installed them:
npm install --save-dev @babel/plugin-proposal-optional-chaining @babel/plugin-proposal-nullish-coalescing-operator
Then I declared them in a babel.config.rc file:
{
  "plugins": [
    "@babel/plugin-proposal-optional-chaining",
    "@babel/plugin-proposal-nullish-coalescing-operator"
  ]
}

Then in the .storybook/main.js file, I added the rule @avishwakarmaplex prescribed earlier under webpack.
So ultimately my storybook main file looks like this:
module.exports = {
  stories: [
    '../src/**/*.stories.mdx',
    '../src/**/*.stories.@(js|jsx|ts|tsx)',
  ],
  addons: [
    '@storybook/addon-links',
    '@storybook/addon-essentials',
    '@storybook/addon-interactions',
  ],
  webpack: async (config) => {
    config.module.rules.unshift({
      test: /\.js$/,
      include: /node_modules[\\\/]@?reactflow/,
      use: {
        loader: 'babel-loader',
      }
    });

    return config;
  },
  framework: '@storybook/react',
  core: {
    builder: 'webpack4',
  }
};

I hope this helps.

I had the exact same problem when adding react-flow to an existing project that uses Webpack 4. This added webpack rule solved it for me:
      {
        test: /\.js$/,
        include: /node_modules[\\\/]@?reactflow/,
        use: {
          loader: 'babel-loader',
          options: {
            presets: [['@babel/preset-env'], '@babel/preset-react']
          }
        }
      },

@AdamGerthel
Thanks this got me almost and after adding plugins this worked for me:
    {
      test: /\.js$/,
      include: /node_modules[\\\/]@?reactflow/,
      use: {
        loader: 'babel-loader',
        options: {
          presets: ['@babel/preset-env', '@babel/preset-react'],
          plugins: ['@babel/plugin-proposal-optional-chaining', '@babel/plugin-proposal-nullish-coalescing-operator']
        }
      }
    }

@expspace That's odd - those plugins are part of preset-env so that shouldn't be needed, at least for ES2020. I added them as well first, but removed them, and it still worked. I'm currently not using them, without issues.
See https://babeljs.io/docs/babel-plugin-proposal-optional-chaining

@AdamGerthel Yeah it is strange it should be included with preset-env, but when I remove those plugins I get errors related to nullish coalescing and optional chaining. I am using the latest version of @babel/preset-env.

I tried for 2 days to solve the problem, finally it worked.

npm i @babel/preset-env
npm i @babel/preset-react
npm i --save-dev @babel/plugin-proposal-optional-chaining
npm i --save-dev @babel/plugin-proposal-nullish-coalescing-operator

Add this code to .storybook/main.js
config.module.rules.push({             test: /\.js$/,             include: /node_modules[\\\/]@?reactflow/,             use: {                 loader: 'babel-loader',                 options: {                     presets: ['@babel/preset-env', '@babel/preset-react'],                     plugins: ['@babel/plugin-proposal-optional-chaining', '@babel/plugin-proposal-nullish-coalescing-operator']                 }             }         });


package-lock.json is missing some resolved and integrity values

Your Question
There are two cases in the package-lock.json where the resolved and integrity values are missing:
https://github.com/corona-warn-app/cwa-website/blob/4142215c9b3b742480ba5f3446cbedd7843d7833/package-lock.json#L4372
https://github.com/corona-warn-app/cwa-website/blob/4142215c9b3b742480ba5f3446cbedd7843d7833/package-lock.json#L13274
It appears #1499 made this change, but I could not find any explanation for this. Is there a reason why this was done?
When I run npm install it fills these missing values, but the build succeeds without any (noticable) issues.

@Marcono1234
It seems that
npm audit fix
can cause this change.
I've tended to use
npm ci
on a clone of the repository instead of
npm install
and then if there are any issues with package.json I've requested the Open Source Team in the past to update and test, so that we're are synced.
Do you think that the differences you noticed will have any negative effect? I'm using npm 6.14.13. What about you?
https://github.com/corona-warn-app/cwa-website/pull/1499 came from @chrisenitan and it was merged by @svengabr.
In that PR "cypress": "^4.12.1" changed to "cypress": "^7.6.0" and I imagine that any other changes to package-lock.json would have been incidental and unintended.

Do you think that the differences you noticed will have any negative effect?

I am not completely sure if resolved is actually still used, see this StackOverflow answer.
I assume integrity might help with detecting corrupted downloads and maybe also prevent attackers from forging packages, though this is rather unlikely since it would require them to perform a MITM attack on a HTTPS connection or take over the npm registry.
Note though that I am not very familiar with npm.

I'm using npm 6.14.13. What about you?

I am using 6.14.8.

Thanks for the clarification, I will close this issue then.


Not allowed to execute on .enable dns or istio

Please run microk8s.inspect and attach the generated tarball to this issue.
Can't inspect doesn't work either:
microk8s.inspect
Sorry, user vromerocarrasco is not allowed to execute '/snap/microk8s/340/inspect.sh' as root on vromerocarr-ltl.

lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 18.04.1 LTS
Release:	18.04
Codename:	bionic

microk8s.enable istio
Enabling Istio
Enabling DNS
Applying manifest
service/kube-dns unchanged
serviceaccount/kube-dns unchanged
configmap/kube-dns unchanged
deployment.extensions/kube-dns configured
Restarting kubelet
Sorry, user vromerocarrasco is not allowed to execute '/snap/microk8s/340/bin/sed -i $ a --cluster-domain=cluster.local /var/snap/microk8s/340/args/kubelet' as root on vromerocarr-ltl.
Failed to enable dns
Failed to enable istio

Hi @vromero
Thank you for opening this issue. Can you make sure you are a sudoer https://askubuntu.com/questions/7477/how-can-i-add-a-new-user-as-sudoer-using-the-command-line , https://forums.linuxmint.com/viewtopic.php?t=217505 ?
MicroK8s includes a number of systemd services. Commands such as microk8s.enable dns need to configure and restart those systemd services. For this you need elevated privileges. As soon as you become a sudoer the failing commands will prompt you for your password.

You are definitely right, I tried this in a vanilla ubuntu (as opposed to a corporate computer) at worked great. Thanks.


Fixes #5070 - Fixed and replaced Intersector intersectSegmentCircleDisplace

Fixes #5070
intersectSegmentCircleDisplace has been replaced by an overloaded method of intersectSegmentCircle that now accepts a MinimumTranslationVector as optional parameter.
Some design choices justifications

Use Vector2 instead of Vector3. This has required creating some static Vector2 instances for temporary use similar to Vector3 ones. To keep simple naming prefix v2 + letter seems the more compact/readable. These instances can be used by any other method in the class that needs temporary Vector2.
Use Vector2 operations when possible for readability
Use Circle as argument (the old one didn't use it as Circle class was created later in time)

Even if the new intersectSegmentCircle that accepts an MTV parameter could also replace the old one, it has been left for backwards compatibility (up for discussion, in my opinion we should remove it)
I will squash all the changes when I get confirmation on what to do with the old method + code review.

As you're using static fields as temp variables, I would write down in the function description that it is not thread-safe

From libGDX docs https://github.com/libgdx/libgdx/wiki/Threading

No class in libgdx is thread-safe unless explicitly marked as thread-safe in the class documentation.


Add support for more Sentinel 3 data products

Is your feature request related to a problem? Please describe.
Some providers (like SARA) allow for more product types than described in the default product_types.yml.
As far as I can tell these are mostly just Sentinel 3 product types, eg Water products (OLCI_WFR etc, LSTR WST), SLSTR_AOD, SLSTR_FRP, and SYNERGY products (eg SYN Surface reflectance, AOD, Vegetation V10 & Vg1.
When adding one of these providers, it's a bit more of a headache otherwise, needing to specify an external cfg file with EODAG_EXT_PRODUCT_TYPES_CFG_FILE
Describe the solution you'd like
Add these product types into the product_types.yml default config. eg compare the current file to one I've changed here (NB: S3 products are also sorted by instrument in the new one, & remove the erroneous "L2" tag from S3_ERR)
Describe alternatives you've considered
Could just leave it to the user, unless issue #14 is considered.
Additional context
This is mostly related to adding SARA to EODAG, a related issue is https://github.com/CS-SI/eodag/issues/14

Hello @catchSheep , and many thanks for these suggestions!
Would you mind opening a Pull Request from your fork to add both product types update and SARA provider? https://github.com/CS-SI/eodag/compare/develop...AustralianSDAF:eodag-Australia:develop
That would be a great input.
Thanks
Also related to #168

No worries. Pull request is: https://github.com/CS-SI/eodag/pull/578


Kusama sync exception

kagome --chain kusama.json --base-path kusama-node-1 --port 50541 --rpc-port 9933 --ws-port 9944
21.11.11 15:12:18.070550  Info      AppConfiguration  Automatically added IPv6 listen address /ip6/::/tcp/50541
21.11.11 15:12:18.071145  Info      AppConfiguration  Automatically added IPv4 listen address /ip4/<IP_ADDRESS>/tcp/50541
21.11.11 15:12:18.071243  Info      AppConfiguration  Listen addresses are set. The p2p port value would be ignored then.
21.11.11 15:12:18.139312  Warning   chain_spec  Field 'chainType' was not specified in the chain spec
21.11.11 15:12:18.139928  Warning   chain_spec  A non-empty set of 'badBlocks' encountered! They might not be taken into account!
21.11.11 15:12:18.173558  Warning   chain_spec  Unsupported multiaddress '/dns/kusama-bootnode-0.paritytech.net/tcp/30334/ws/p2p/12D3KooWSueCPH3puP2PcvqPJdNaDNF3jMZjtJtDiSy35pWrbt5h'. Ignoring that boot node
21.11.11 15:12:18.381395  Warning   Injector  Can not obtain a libp2p keypair from crypto storage. A unique one will be generated for the current session
21.11.11 15:12:18.393380  Info      Application  Start as KagomeApplicationImpl with PID 55470 named as 09bbc09f-d4aa-4eb0-a828-7b8bb5d4d902
21.11.11 15:12:18.394541  Info      RouterLibp2p  Started with peer id: 12D3KooWCegERPZKCc1cmdc16Aky5yxvnSV4f2jzBYyudFSKihe7
21.11.11 15:12:18.394553  Info      RouterLibp2p  Started listening on address: /ip4/<IP_ADDRESS>/tcp/50541/p2p/12D3KooWCegERPZKCc1cmdc16Aky5yxvnSV4f2jzBYyudFSKihe7
21.11.11 15:12:18.394557  Info      RouterLibp2p  Started listening on address: /ip6/::/tcp/50541/p2p/12D3KooWCegERPZKCc1cmdc16Aky5yxvnSV4f2jzBYyudFSKihe7
21.11.11 15:12:18.394578  Info      OpenMetrics  Started successfully on host: <IP_ADDRESS>, port: 9615
Stack trace (most recent call last):
#7    Object "kagome", at 0x1057ed4bf, in main + 1199
#6    Object "kagome", at 0x1058156d6, in kagome::application::KagomeApplicationImpl::run() + 406
#5    Object "kagome", at 0x1085f6e39, in kagome::application::AppStateManagerImpl::run() + 121
#4    Object "kagome", at 0x1085f6888, in kagome::application::AppStateManagerImpl::doLaunch() + 216
#3    Object "kagome", at 0x108678e72, in kagome::consensus::grandpa::GrandpaImpl::start() + 738
#2    Object "kagome", at 0x108679abc, in kagome::consensus::grandpa::GrandpaImpl::makeInitialRound(kagome::consensus::grandpa::MovableRoundState const&, std::__1::shared_ptr<kagome::consensus::grandpa::VoterSet>) + 828
#1    Object "kagome", at 0x1086897d7, in kagome::consensus::grandpa::VotingRoundImpl::VotingRoundImpl(std::__1::shared_ptr<kagome::consensus::grandpa::Grandpa> const&, kagome::consensus::grandpa::GrandpaConfig const&, std::__1::shared_ptr<kagome::authority::AuthorityManager>, std::__1::shared_ptr<kagome::consensus::grandpa::Environment> const&, std::__1::shared_ptr<kagome::consensus::grandpa::VoteCryptoProvider> const&, std::__1::shared_ptr<kagome::consensus::grandpa::VoteTracker> const&, std::__1::shared_ptr<kagome::consensus::grandpa::VoteTracker> const&, std::__1::shared_ptr<kagome::consensus::grandpa::VoteGraph> const&, std::__1::shared_ptr<kagome::consensus::grandpa::VoteGraph> const&, std::__1::shared_ptr<kagome::clock::Clock<std::__1::chrono::steady_clock> > const&, std::__1::shared_ptr<boost::asio::io_context> const&, kagome::consensus::grandpa::MovableRoundState const&) + 375
#0    Object "kagome", at 0x108687e10, in kagome::consensus::grandpa::VotingRoundImpl::VotingRoundImpl(std::__1::shared_ptr<kagome::consensus::grandpa::Grandpa> const&, kagome::consensus::grandpa::GrandpaConfig const&, std::__1::shared_ptr<kagome::authority::AuthorityManager>, std::__1::shared_ptr<kagome::consensus::grandpa::Environment>, std::__1::shared_ptr<kagome::consensus::grandpa::VoteCryptoProvider>, std::__1::shared_ptr<kagome::consensus::grandpa::VoteTracker>, std::__1::shared_ptr<kagome::consensus::grandpa::VoteTracker>, std::__1::shared_ptr<kagome::consensus::grandpa::VoteGraph>, std::__1::shared_ptr<kagome::consensus::grandpa::VoteGraph>, std::__1::shared_ptr<kagome::clock::Clock<std::__1::chrono::steady_clock> >, std::__1::shared_ptr<boost::asio::io_context>) + 1376
[1]    55470 floating point exception  ../kagome/cmake-build-release/node/kagome --chain kusama.json --base-path

kusama-node-1.zip

the issue caused by starting the application with the corrupted state, nothing to fix


Support nbest for ModernMT 4.x

As briefly discussed in #515 with @nicolabertoldi , nbest is not supported in ModernMT 4.x.
While I can see the purposes of this not always being obvious, I will give an explanation of what made me want this feature.
My goal/hope is basically for the nbest to provide meaningful alternatives to be used in PEMT. I had initially thought of two usecases:

This can be used to implement a sophisticated autocompletion mechanism, that will search for options in the alternate translations, when a translator is post-editing a segment. It can also be used to simply present as a list of options.

Reweighing based on customer specific terminology (eg. from .tbx-files). While some of this functionality in a sense exists in the form of 'Context Memories', I think it would be nice to be able to play around with the effects of deciding translations based on customer specific properties, as a postprocessing step.

@nicolabertoldi doesn't seem like I can add the 'feature-requests' label myself, so feel free to add it.


How can I use envoy with consul for service discovery

Title: Envoy with consul for service discovery
Description:
I would like to know how I can make envoy work with consul. We use hashicorp products and services are exposed to consul service discovery. Please share if there is any example I can refer to.
Thanks

To achieve this, it's necessary for xDS server to bridge the consul. This may be as a ref https://github.com/istio-ecosystem/consul-mcp


Default Delimiter Should be "_"

This allows for dot notation after the flatten. Simple fix. Thanks for a great utility!

The generally accepted notation for object graphs is . - using underscore is incongruous with the majority of other libraries and utilities.

I agree with @antony here. If you want to use a custom delimiter you can pass the delimiter option.


auto-positioning of content

This is just a random idea; take it FWIW. I also realize now it's very similar to #7. Feel free to close.
In looking at the example index.html file, I really like that one can just layout the content in sequence. But one notable limitation seems to be the requirement (?) to specify placement.
Would it not be possible to have the content laid out on the page automatically, using javascript, perhaps with configurable layout algorithms?
So, for sake of argument, perhaps one algorithm might say:

the first "slide" gets centered on the page in somewhat larger or otherwise more prominent fonts
other slides get organized around that center, and rendering can be tweaked with class attributes

On the second point, more structure to the actual source file (say using nested sections) could make this even more powerful. E.g. maybe sections get grouped first, and then subsections organized in relation to those groups.
A strawman example:

My Presentation Title

Introduction

My Presentation Title

some content

Closing as duplicate of #7.
We have similar discussion there.
Thanks!


General questions

Hi Li,
I have some general questions about the usage and output. I would appreciate it if you could clarify them.

Difference between using FASTQ or BAM files: Are there any significant differences when using FASTQ or BAM files for quantification? I have a set of BAM files aligned by minimap2 with the -Y (soft clipping) option, but I noticed your script did not include this parameter for FASTQ input. Do you have any thoughts or suggestions on this matter?

About the output:

Which output files (repeat_size.txt, phased_reads.txt, summary.txt, and output.tsv) should we consider first? I noticed the summary.txt and output.tsv are quite similar. I encountered a situation where only repeat_size.txt was generated, and I guess this might be due to an insufficient number of reads to support phasing.
Are low phasing confidence reads removed when generating the summary report?

Thank you for your assistance.
Best regards,
Hsin

Hello Hsin,
There is no much difference between FASTQ and BAM input. NanoRepeat will realign the reads during analysis.
The output.tsv include repeat quantification of multiple repeat regions.
The summary.txt file for a specific repeat. If you have multiple repeat regions, there will be one summary.txt file for each repeat.
The repeat_size.txt is the raw result for each read.
Yes. When generating the summary report, some reads with low phasing confidence are removed.

Hi Li,
Thank for your clear clarification!
Best,
Hsin


Insufficient dev setup instructions

I was able to run ODK Central BE and FE locally for development purposes. I went to localhost:8989 and saw this:

I don't recall setting any email+password user anywhere. Is there a default one?

We've released our latest version, v0.4 Beta! I'm going to go ahead and close this issue, but feel free to open a new one if anything else arises as you get set up.


Add ES (Spanish) Translation

Hello, I share my translation into Spanish.
Create a 'Translations' folder that contains a 'Versions' folder, inside it is the version of the validator that I translated into Spanish. In the future it would be good to simplify to a single file that contains the translations so as not to have to copy all the code.
A greeting!

This is a good one! I hope they think the same.

This is a good one!
That's a horrible bad solution.

¡Este es bueno!

Esa es una "solución" horriblemente mala.

At no time did I say that it was the solution. I only share my translation into Spanish. Better interpret the text for the next one.
Greetings.


Provide external tomcat configuration via local file

External tomcat config can be provided via $BP_TOMCAT_EXT_CONF_URI. I believe this only supports http currently.
A way to provide this config from the local file system would enable a simpler workflow; we have no reason to publish this config as an HTTP resource (or separate git repo) other than to use this buildpack.

cc @cloudfoundry/cf-uaa

Additionally, while github has functionality to download a repo as a tarball, the directory structure inside of it is incompatible with the $BP_TOMCAT_EXT_CONF_URI since the directory is a built up from the repo owner, name, and an abbreviated shasum.

@nebhale Do you have any thoughts on whether supporting local files as the configuration bundle is feasible?


make project property optional

when setting vs boot straper to disable is convenient to run resharper only once in the solution instead if defining modules manually. this can be easily done by just not setting /project.
this means also that we dont need to define modules and all the files will be indexed easily.
can you please consider this enhancement please.
Style cop already supports this if instead of defining the project we choose the solution than stylecop runs in all project. resharper should behave similiar.
Fxcop works, but might need some enahcment to support definition of several assemblies to be checked.

This PR relates to the deprecated mode in which R# inspectcode.exe was being executed by the SonarQube R# Plugin.
It is now expected that users invoke inspectcode.exe themselves and only pass a report to the plugin.


Adapt to Coq PR #19301: unify the syntax of definition and theorem

In particular, VernacStartTheoremProof and VernacDefinition are now only one common entry and we adapt document.ml to it (hoping I'm not doing something wrong).
To be merged synchronously with coq/coq#19301 when the latter is ready.

Could you please add directives for ppx_optcomp?

Could you please add directives for ppx_optcomp?

Looks ok now. Thanks for telling.


Making an HSeparator invisible causes an assertion failure

Making an HSeparator invisible causes an assertion failure. VSeparator seems OK.
For example, run ph-sale in Studio, and change phScale.microScreen.view.beakerControlPanel.separator.visibleProperty to false. This will cause assertion failure:
Assertion failed:  reentry detected, value=true, oldValue=false
assert.js:28 Uncaught Error: Assertion failed: reentry detected, value=true, oldValue=false
    at window.assertions.assertFunction (assert.js:28:13)
    at BooleanProperty._notifyListeners (ReadOnlyProperty.ts:308:15)
    at BooleanProperty.unguardedSet (ReadOnlyProperty.ts:262:14)
    at BooleanProperty.set (ReadOnlyProperty.ts:246:12)
    at BooleanProperty.set (Property.ts:65:11)
    at TinyForwardingProperty.set (TinyForwardingProperty.ts:136:27)
    at HSeparator.setVisible (Node.ts:3849:26)
    at set visible [as visible] (Node.ts:3858:10)
    at FlowConstraint.layout (FlowConstraint.ts:114:9)
    at FlowConstraint.updateLayout (LayoutConstraint.ts:185:14)

Blocks publication ph-scale, and presumably any PhET-iO sim that uses HSeparator.

This is potentially blocking many PhET-iO sims, so I added it to the board.

Just a note -- In discussion with @samreid and @zepumph, it sounds like a new feature of HSeparator is that it knows when to hide itself. From a design perspective, I don't see a reason to instrument separators if they know when to hide themselves.

Just clarifying, I'll uninstrument the *Separator visibleProperties, and leave the issue assigned to @jonathanolson to work on the potential layout problems.

Just a note -- In discussion with @samreid and @zepumph, it sounds like a new feature of HSeparator is that it knows when to hide itself. From a design perspective, I don't see a reason to instrument separators if they know when to hide themselves.

Good to know. Would have been even better to know before I did this for every single separator in every single one of my sims.  Now I have to uninstrument them.
Add some documentation please?
gravity-and-orbits has instrumented separators, btw.  GravityAndOrbitsControls.ts:
    // top separator rectangle for the gravity control section
    const topSeparator = new HSeparatorDeprecated( 0, merge( { tandem: options.tandem.createTandem( 'separator1' ) }, SEPARATOR_OPTIONS ) );
    const bottomSeparator = new HSeparatorDeprecated( 0, merge( { tandem: options.tandem.createTandem( 'separator2' ) }, SEPARATOR_OPTIONS ) );

Hmm... I'm confused by https://github.com/phetsims/scenery/issues/1480#issuecomment-1286170972.  Are we uninstrumenting separators, or doing something in common code to uninstrument their visibleProperty, or both?

I also StrictOmitted tandem from Separator  so it will catch accidental instrumentations.

Since Separators can no longer be hidden via phet-io, this issue does not seem blocking for the upcoming PhET-iO release, but should still be investigated with @jonathanolson and @marlitas as part of the dynamic layout project.

Not blocking for PhET-iO releases, but should be taken care of. Thanks @jonathanolson! This is part of dynamic layout work.

I've tried to reproduce various ways and can't.
Basically, don't pass a non-reentrant visibleProperty to separators.
@zepumph thoughts?

apply this patch
ignore the type error
go to studio
search for phScale.microScreen.view.beakerControlPanel.separator.visibleProperty
toggle visibility in studio

Index: js/common/view/BeakerControlPanel.ts
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/js/common/view/BeakerControlPanel.ts b/js/common/view/BeakerControlPanel.ts
--- a/js/common/view/BeakerControlPanel.ts	(revision a8c5a0afe167da3f0e20c507adc97660779c8018)
+++ b/js/common/view/BeakerControlPanel.ts	(date<PHONE_NUMBER>675)
@@ -56,7 +56,9 @@
     const content = new VBox( {
       children: [
         ratioCheckbox,
-        new HSeparator(),
+        new HSeparator({
+          tandem: options.tandem.createTandem( 'separator' )
+        }),
         moleculeCountCheckbox
       ],
       align: 'left',

I was able to trigger the error in the top comment via the patch @zepumph described. It seems the visibility of separators is under control of the layout engine and cannot be independently specified. If that's true, that seems reasonable, and we could change the API of separators so they cannot have their visibility changed. This does not seem like a high priority problem.

Yes let's remove it. We have gotten rid of instrumention for much less, just make sure to look at featured, overrides,and client guides to see if anything need be changed with this.

PhET-iO instrumentation was already removed in https://github.com/phetsims/scenery/commit/06e612b46563b1f81e2bc769712faa507f0c6400, I believe the proposal was to remove the setVisible core API, but that doesn't seem easy to do since HSeparator extends Node, and the layout engine still needs to use it (if it isn't using add/remove child).  Likewise, it doesn't seem important since if a client tries to change the visibility it would likely cause an assertion failure.  So I don't think there's anything else to be done here, closing.


Trunk

This is a helper tool to construct avro schema json objects. It currently constructs both primitive types and complex types, such as enum, fixed, map, array, record, and union. Feedback about the builder and if it is worth to be included in the main repo is appreciated.

Please file an issue on the project tracker: https://issues.apache.org/jira/browse/AVRO/

Hi Sean,
I originally opened a ticket https://issues.apache.org/jira/browse/AVRO-1690
a while back. Do I need to create another one or do I need to update the
ticket?
Thanks very much,
Chia-chi
On Tue, Jul 7, 2015 at 5:47 AM, Sean Busbey<EMAIL_ADDRESS>wrote:

Please file an issue on the project tracker:
https://issues.apache.org/jira/browse/AVRO/
—
Reply to this email directly or view it on GitHub
https://github.com/apache/avro/pull/35#issuecomment-119193444.


ImportError: cannot import name 'ForwardRef' from 'typing_extensions' (/usr/local/lib/python3.10/dist-packages/typing_extensions.py)

Describe the bug
Import error in ns-train splatfacto
To Reproduce
Steps to reproduce the behavior:

Install the latest version

# make sure you uninstall the previous gsplat and nerfstudio
pip uninstall gsplat nerfstudio -y

# install it from pip
pip install<EMAIL_ADDRESS>pip install<EMAIL_ADDRESS>

Run this command

ns-train splatfacto --logging.steps-per-log 200 --vis viewer+wandb --viewer.websocket-port 7007 \
    --pipeline.model.resolution-schedule 3000 \
    --pipeline.model.num-downscales 2 \
    nerfstudio-data \
    --data path/to/scene --downscale-factor 1

Error message:

Traceback (most recent call last):
  File "/usr/local/bin/ns-train", line 5, in <module>
    from nerfstudio.scripts.train import entrypoint
  File "/usr/local/lib/python3.10/dist-packages/nerfstudio/scripts/train.py", line 58, in <module>
    import tyro
  File "/usr/local/lib/python3.10/dist-packages/tyro/__init__.py", line 3, in <module>
    from . import conf as conf
  File "/usr/local/lib/python3.10/dist-packages/tyro/conf/__init__.py", line 11, in <module>
    from ._confstruct import arg as arg
  File "/usr/local/lib/python3.10/dist-packages/tyro/conf/_confstruct.py", line 4, in <module>
    from .._fields import MISSING_NONPROP
  File "/usr/local/lib/python3.10/dist-packages/tyro/_fields.py", line 45, in <module>
    from . import (
  File "/usr/local/lib/python3.10/dist-packages/tyro/_docstrings.py", line 15, in <module>
    from . import _resolver, _strings, _unsafe_cache
  File "/usr/local/lib/python3.10/dist-packages/tyro/_resolver.py", line 25, in <module>
    from typing_extensions import (
ImportError: cannot import name 'ForwardRef' from 'typing_extensions' (/usr/local/lib/python3.10/dist-packages/typing_extensions.py)

Expected behavior
Runs training smoothly without problem
How to solve it
Revert back to previous version
pip uninstall nerfstudio gsplat -y
pip install<EMAIL_ADDRESS>pip install git+https://github.com/nerfstudio-project/nerfstudio.git@ae6c46cfeaebbe28f9cd48fa986755e27b5f0ae2

Additional context
Python 3.10
Pytorch 2.0.1+cu118
Ubuntu 22.04 LTS
typing_extensions 4.40.0

Thanks for reporting! It looks like this is from an old version of typing_extensions: if you pip install --upgrade typing_extensions the error should go away.
I can fix this by bumping the minimum typing_extensions version in tyro.

Thanks for reporting! It looks like this is from an old version of typing_extensions: if you pip install --upgrade typing_extensions the error should go away.
I can fix this by bumping the minimum typing_extensions version in tyro.

Here is my experiment
the version which works with nerfstudio v1.0.2 and gsplat 0.1.8 => tyro 0.7.3
the version which do Not works with nerfstudio v1.0.3 and gsplat 0.1.10 => tyro 0.8.1

Yeah, the problem is because I import typing_extensions.ForwardRef in tyro>=0.8.0, but that's only available in typing_extensions>=4.7.0 (from November 2023). We were requiring typing_extensions>=4.3.0 (from July 2022).
I just pushed version 0.8.2 of tyro, which will have this fixed.

This solved my problem
pip install tyro==0.8.2 typing-extensions==4.11.0


Open MongoDb Data API, Add ObjectID Scalar & Filtering

Opens MongoDB Data API for extensions
Adds ObjectId Scalar
Adds ObjectId Filters

Closes #2534

@tobias-tengler
I run into issues with the analyzer
Error

Repeating warnings and errors:
Check failed: Could not complete checking build configurations within 500 milliseconds.
Check failed: GitVersion does not support fetching SSH endpoints. Enable NoFetch to skip fetching.
Warnings were encountered while loading the workspace. Set the verbosity option to the 'diagnostic' level to log warnings.
Unhandled exception: System.NotSupportedException: Adding additional documents is not supported.
   at Microsoft.CodeAnalysis.Workspace.CheckAllowedProjectChanges(ProjectChanges projectChanges)
   at Microsoft.CodeAnalysis.Workspace.CheckAllowedSolutionChanges(SolutionChanges solutionChanges)
   at Microsoft.CodeAnalysis.Workspace.TryApplyChanges(Solution newSolution, IProgressTracker progressTracker)
   at Microsoft.CodeAnalysis.MSBuild.MSBuildWorkspace.TryApplyChanges(Solution newSolution, IProgressTracker progressTracker)
   at Microsoft.CodeAnalysis.MSBuild.MSBuildWorkspace.TryApplyChanges(Solution newSolution)
   at Microsoft.CodeAnalysis.Tools.CodeFormatter.FormatWorkspaceAsync(FormatOptions formatOptions, ILogger logger, CancellationToken cancellationToken, String binaryLogPath) in /_/src/CodeFormatter.cs:line 99
   at Microsoft.CodeAnalysis.Tools.Program.Run(String workspace, Boolean noRestore, Boolean folder, Boolean fixWhitespace, String fixStyle, String fixAnalyzers, String[] diagnostics, String verbosity, Boolean check, String[] include, String[] exclude, String report, Boolean includeGenerated, String binarylog, IConsole console) in /_/src/Program.cs:line 185
   at System.CommandLine.Invocation.CommandHandler.GetExitCodeAsync(Object value, InvocationContext context)
   at System.CommandLine.Invocation.ModelBindingCommandHandler.InvokeAsync(InvocationContext context)
   at System.CommandLine.Invocation.InvocationPipeline.<>c__DisplayClass4_0.<<BuildInvocationChain>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass23_0.<<UseParseErrorReporting>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass16_0.<<UseHelp>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass27_0.<<UseVersionOption>b__1>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass25_0.<<UseTypoCorrections>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<<UseSuggestDirective>b__24_0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass22_0.<<UseParseDirective>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass11_0.<<UseDebugDirective>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<<RegisterWithDotnetSuggest>b__10_0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass14_0.<<UseExceptionHandler>b__0>d.MoveNext()
ProcessException: Process 'dotnet' exited with code 1.
   > /usr/local/share/dotnet/dotnet format "/Users/pascalsenn/kot/hotchocolate/src/Build.CheckApi.sln" --fix-analyzers warn --diagnostics RS0016
   @ /Users/pascalsenn/kot/hotchocolate
Error output:
   Warnings were encountered while loading the workspace. Set the verbosity option to the 'diagnostic' level to log warnings.
   Unhandled exception: System.NotSupportedException: Adding additional documents is not supported.
      at Microsoft.CodeAnalysis.Workspace.CheckAllowedProjectChanges(ProjectChanges projectChanges)
      at Microsoft.CodeAnalysis.Workspace.CheckAllowedSolutionChanges(SolutionChanges solutionChanges)
      at Microsoft.CodeAnalysis.Workspace.TryApplyChanges(Solution newSolution, IProgressTracker progressTracker)
      at Microsoft.CodeAnalysis.MSBuild.MSBuildWorkspace.TryApplyChanges(Solution newSolution, IProgressTracker progressTracker)
      at Microsoft.CodeAnalysis.MSBuild.MSBuildWorkspace.TryApplyChanges(Solution newSolution)
      at Microsoft.CodeAnalysis.Tools.CodeFormatter.FormatWorkspaceAsync(FormatOptions formatOptions, ILogger logger, CancellationToken cancellationToken, String binaryLogPath) in /_/src/CodeFormatter.cs:line 99
      at Microsoft.CodeAnalysis.Tools.Program.Run(String workspace, Boolean noRestore, Boolean folder, Boolean fixWhitespace, String fixStyle, String fixAnalyzers, String[] diagnostics, String verbosity, Boolean check, String[] include, String[] exclude, String report, Boolean includeGenerated, String binarylog, IConsole console) in /_/src/Program.cs:line 185
      at System.CommandLine.Invocation.CommandHandler.GetExitCodeAsync(Object value, InvocationContext context)
      at System.CommandLine.Invocation.ModelBindingCommandHandler.InvokeAsync(InvocationContext context)
      at System.CommandLine.Invocation.InvocationPipeline.<>c__DisplayClass4_0.<<BuildInvocationChain>b__0>d.MoveNext()
   --- End of stack trace from previous location ---
      at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass23_0.<<UseParseErrorReporting>b__0>d.MoveNext()
   --- End of stack trace from previous location ---
      at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass16_0.<<UseHelp>b__0>d.MoveNext()
   --- End of stack trace from previous location ---
      at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass27_0.<<UseVersionOption>b__1>d.MoveNext()
   --- End of stack trace from previous location ---
      at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass25_0.<<UseTypoCorrections>b__0>d.MoveNext()
   --- End of stack trace from previous location ---
      at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<<UseSuggestDirective>b__24_0>d.MoveNext()
   --- End of stack trace from previous location ---
      at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass22_0.<<UseParseDirective>b__0>d.MoveNext()
   --- End of stack trace from previous location ---
      at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass11_0.<<UseDebugDirective>b__0>d.MoveNext()
   --- End of stack trace from previous location ---
      at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<<RegisterWithDotnetSuggest>b__10_0>d.MoveNext()
   --- End of stack trace from previous location ---
      at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass14_0.<<UseExceptionHandler>b__0>d.MoveNext()

Do i have to do more than just nuke AddUnshippedAPI?

Yes, you added a new project MongoDB.Types, but didn't copy over the PubliAPI.empty.txt file. So PublicAPI.Shipped.txt and PublicAPI.Unshipped.txt were missing.
I'll add them + the unshipped APIs.

@tobias-tengler  Thanks tobias :)

/AzurePipelines run

Drop Scalar


Please add LICENSE file

Hello,
I'm looking to fork this library for work, but its missing a LICENSE file. Would you mind adding one?

Done: https://github.com/s12v/graphql-devtools/commit/3326c97542b59f9682ded1efcd473648f89564f5


From private repo

@v-alje : Thanks for your contribution to the Azure documentation! The author, @cawa, has been notified to review your proposed change.


Try to catch panics

I was just here to say the same.  I did
eval: &"☃☃"[1..]

to try to demo str slicing errors, but got
08:49:19 -eval/#rust-beginners-     Finished dev [unoptimized + debuginfo] target(s) in 0.69s
08:49:19 -eval/#rust-beginners- ~~~ Full output: https://play.rust-lang.org/?gist=4ad9029434347b91e46f70db039b578e&version=stable&mode=debug

instead of the one-line error I wanted,
panicked at 'byte index 1 is not a char boundary; it is inside '☃' (bytes 0..3) of `☃☃`', libcore/str/mod.rs:2266:5

This is not what this issue is for. This is about catching panics in playbot/eval itself.
Your issues is more related to #5


Replace the bottom viewing window of the profile page

Users no longer need to see Published, Downloads, and Compute Jobs on their profile page. Instead, only have two sections:

My Medical Records
People with Access

Create ~5 different medical records using the publish feature of the Vizer personal healthcare wallet website. These medical records (not in chronological order) should be....

Blood Work 03/10/2022
Blood Work 03/14/2023
Covid Test 04/14/2023
Annual Checkup Results 04/10/2023
Insurance Form 01/20/2016


Fix user switching in E2E tests and ensure general robustness

Context

As we've discovered, the non-admin e2e tests were not actually running as expected.
Besides the users not actually having been created initially, there was also an issue with not the right user being logged in and not detecting that in the tests.
Summary

I went down the rabbit hole of debugging these tests for the better part of my day, trying to strengthen them piece by piece.
The main area I found to be fragile is how the @wordpress/e2e-test-utils utils like visitAdminPage tried to log in as the current user. They were not really made for how we want to switch users constantly between tests.
Relevant Technical Choices

On top of #7803, this implements the following changes:
Do not lock stories if experiment is disabled
This adds a check in \Google\Web_Stories\Admin\Editor::setup_lock() to see whether the experiment is enabled. Without this, one could edit a story, and on "All Stories" it would have been shown as locked, but the locked modal was not shown in the editor.
The whole post locking should only work if the experiment is enabled.
publishStory util
This makes some repeated code a bit more DRY by moving the statements to publish a story and dismissing dialogs into a shared util.
withPlugin util
Just a small util that activates a plugin before tests & deactivates it afterwards.
withUser util
Just a small util that logs in as a user before tests and switches back to admin afterwards.
This is done with withUser('admin', 'password') in bootstrap.js, but also at the top of every test for extra safety.
(Doing withUser('admin', 'password') when already logged in as admin is a no-op)
Consolidates Site Kit e2e tests
Just to keep this a bit more dry and have them in one place.
Improve cleanup in publisherLogo.js
Moving the file deletion to afterEach ensures it happens even if a test fails.
Improve trashAllPosts
Copies the util from Gutenberg, but removes an XPath query to reduce flakiness.
Improve visitAdminPage
Copies the util from Gutenberg, but removes any user login logic from it.
New setCurrentUser util
This is used by withUser and other utils to switch the current user in a robust way.
Improve loginUser
Fixes typing into the login form input fields to prevent errors and making login more robust.
Puppeteer appears to sometimes have issues with typing,  where the first 1-2 characters are simply not typed. This will of course make the login fail.
Hence not using page.type() anymore.  Should be OK since there are no event listeners on the login form.
See https://github.com/puppeteer/puppeteer/issues/1648
To-do

Maybe implement activatePlugin and deactivatePlugin ourselves as well, because these Gutenberg utils use switchUserToAdmin/switchUserToTest, which might break with our setup.

User-facing changes

None
Testing Instructions

QA

[x] This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

UAT

[x] UAT should use the same steps as above.

This PR can be tested by following these steps:

Reviews
Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

[ ] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[x] I have tested this code to the best of my abilities
[x] I have verified accessibility to the best of my abilities (docs)
[x] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[x] This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
[x] I have added documentation where necessary
[x] I have added a matching Type: XYZ label to the PR

Fixes #7790

Seems like we are following a with* pattern. Should we also add withRTL.

Maybe implement activatePlugin and deactivatePlugin ourselves as well, because these Gutenberg utils use switchUserToAdmin/switchUserToTest, which might break with our setup.

I agree, let's do this.

Seems like we are following a with* pattern. Should we also add withRTL.

Good idea 👍

I also wonder. We are now only using @wordpress/e2e-test-utils in 4 places in the e2e tests. The utils that are used are

activatePlugin
deactivatePlugin
getEditedPostContent
visitAdminPage
createNewPost
setPostContent

/**
 * WordPress dependencies
 */
import {
  activatePlugin,
  deactivatePlugin,
  visitAdminPage,
} from '@wordpress/e2e-test-utils';

This should be changed to use our new visitAdminPage.
Wondering, as we are only using a couple of utils for WordPress, we just expose those via @web-stories-wp/e2e-test-utils and remove then package from e2e package.json

I think we will need to implement our own version of createNewPost as this use gutenberg / WordPress version uses visitAdminPage.

@swissspidy Should we merge this into my PR and I can look at the rest of the tweaks?

@swissspidy Should we merge this into my PR and I can look at the rest of the tweaks?

Since tests are passing and seem stable now, let's merge this PR & your PR already and do the tweaks in a new PR. Sounds good?


Fix model.py for distributed_spec runs

Please move the line:
global_variables = list(set(global_variables)) (models.py:444)
(https://github.com/reinforceio/tensorforce/blob/f1c49de35633ad5b6866834200df75bd2b2dfc1c/tensorforce/models/model.py#L444)
out of the if-else block (move two lines lower + unindent it). That will fix an error message coming from tf.train.Saver when running with distributed-spec != None.

Thanks for raisin it, will do on the weekend

Done, should be fine now


Crash when pluggin/unplugging/while connected on charger.

Has anyone noticed anything like it. Its a rare crash and seems to be happening while plugging or unplugging the charger and the phone tries to wake up to notify you that you plugged/unplugged. Or maybe when it reaches the 100% level and tries to wake up.
And to be more specific by crash i mean an unresponsive phone that requires a reboot.

I have not noticed anything like that on XZ3, usually I charge the device around ~85%, although few times I forgot it and charged up to 100% without any issues. Since 3.3 upgrade, and apart from the camera, the device is very stable, saying that I had few times kuri/laufhelden sports app failing to start, but I think it's an app related issue.

Not here either. But I am usually using wireless charging and it is in a bit different mode then (CPU sleep is inhibited, for example).

Hmmmm. Ok. I'll leave this open for a bit more and see if it happens again. If not i'll close it myself.
Thanks guys. :)

The first crash I had with SFOS since at least a year has happened a few days ago while the XZ2C was charging and an SMS came in and I was speedy enough to touch the notification and the phone just became black with the LED blinking red at which point I had to press power and volume up to restart the phone.

I'll close this since we moved to a newer base and open a new one in case i see any crash.


node_modules/gulp-typescript/typings/tsd.d.ts not found.

I'm using Typescript 2, to install types I just run @types/LIBRARY_NAME, I no longer have a typings folder, which is specially not needed since this library exports its types data.
However, this line in release/main.d.ts(1,1) is giving me an issue:
/// <reference path="../typings/tsd.d.ts" />
The module no longer has a typings folder when I install it with npm so this is referencing an inexistent folder. I get rid of that line and the error goes away. This is the error I'm seeing:
release/main.d.ts(1,1): error TS6053: File '/Users/gabriel/work/project_one/node_modules/gulp-typescript/typings/tsd.d.ts' not found.

Hi,
I do have the same issue.
The bundled definitions should not rely on any external source. I just started to write typings definitions for the dependencies instead of tsd ones to bring scoped modules (TSD is based on globals).
It would still be great if it was possible to fix it in the meantime until the typings definitions are published.

+1

Hi, I almost finished converting the project from tsd to typings, this should solve this issue.
The main issue was the missing definition for gulp-util so I wrote it, but it relies on the typings of vinyl. The definition in the registry describes an older version of vinyl but the update should be merged soon and I'll be able to finish the conversion.
Here are some references:
https://github.com/demurgos/typed-gulp-util
https://github.com/types/npm-vinyl/pull/1
https://github.com/typings/registry/pull/832

I'd prefer to use @types on npm, that would make it easier to use the type declarations. But I guess that it won't take long to switch to @types once you have updated all type declarations.

Hi @ivogabe, @types is the way to go looking forward. @demurgos If it's possible to rely on this rather it would be awesome.

I am also interested in @types so I'll take a look at it. I'll submit a PR fixing this issue in the meantime, but I'll check the state of of @types.

That would be great! @types packages are genereated from the types-2.0 branch of Definitely Typed, so you should send PRs there if some definition file of a dependency is outdated.

I just submitted a PR to fix the issue using typings. I am starting to try to use @types. It still seems like it might not be that stable yet. My main issue is that it does not support "decentralized" repositories yet (https://github.com/Microsoft/types-publisher/issues/4) and leads to very long delays before PR are accepted and difficulties with maintenance.
I'll let you know how it does work out.

From a user perspective, @types is really great: I could update it really quickly and submit a new PR to use @types instead of typings.
Even if typings has more accurate definitions, it compiles fine with the ones from DefinitelyTyped (@types) so I'll just leave like this for the moment. From a definition maintainer perspective, DefinitelyTyped is still pretty painful...

+1 for using typings until @types supports decentralized repositories.

I don't think that decentralised repositories are necessary to use @types here. I took the types branch of @demurgos and got it working after some small changes. See #448. Can someone confirm that that solves all issues related to the type definitions of gulp-typescript?

Hi,
I could successfully run your branch, looks like I just made a mistake in my branch, unfortunately I wasn't then able to import it: I'm taking a look at it to give you more information.
About the decentralized repositories, I think you are right that "it works" to use @types as is right now. But it's a real pain to work with this. You just need to be aware that until decentralized repositories are supported, typings will often have better definitions because they are tested and regularly updated and reviewed: this is just impossible with the current situation of definitely-typed.
I mostly care about your module not emitting errors and keeping it "contained" (it should not mess with global variables) so in the end you can choose whatever you prefer: I'm just happy that this issue is on the way to be solved.

Version 3.1.0 now uses @types, so this issue is now fixed!


Calendar hardcoded to US stock market

Hi fellow maintainers,
I've been trying to ingest non-USA CSV bundles with Zipline, but it proved much harder than I calculated.
Turns out that there are some hardcoded variables that bind the process to only NYSE and UTC data.
Follow some lines I had to change in order to have a successful (without crashes) bundle ingestion:
https://github.com/quantopian/zipline/blob/05a6080eed951f80da3b6f7ee4962101884f328e/zipline/data/bundles/csvdir.py#L161
https://github.com/quantopian/zipline/blob/05a6080eed951f80da3b6f7ee4962101884f328e/zipline/data/bundles/csvdir.py#L227
When I tried to fix the values, I've got an error here:
File "zipline/data/bundles/csvdir.py", line 161, in csvdir_bundle
    metadata['exchange'] = calendar_name

NameError: name 'calendar_name' is not defined

It looked weird but I didn't have time to follow up and debug it.
My current state is simply change the hardcoded values from 'NYSE' to 'BVMF' and it works.
Any suggestions on how to fix it for the long term?

what you have made to get it work? @willianpaixao

Instead of setting an exchange of CSVDIR, we should have an environment variable that can be set at ingest time where users can set the calendar. Maybe something like CSVDIR_EXCHANGE=XNYS or something. The string would need to be a name that trading_calendars can parse. We can preserve the default calendar of XNYS (which NYSE is an alias of) if a user doesn't provide a value.
I think the code changes needed to make this work are:

Change line 161 to: metadata['exchange'] = os.environ.get('CSVDIR_EXCHANGE', 'XNYS')
Remove line 227

@llllllllll Thanks very much. It works.

@llllllllll I've followed your suggestion then tested #2674 locally and it works.


Add an empty table for Model Store as well when there's no data

UI Comments :-  As the field of model store will be dynamic, due to which we can not show it in empty table

Use common empty placeholder at both place @Ashish8689


Clear the situation about 2FA

Hello my friends, the new system is now up, i decided to not care too much until today to see what really came out. I have to say i'm a bit lost. This is used for people that has the steam guard mobile enable so they have to confirm their trade only by phone.
But personnaly, i never use my phone so nothing really changed. What about the bots ? I heard a story that items will be blocked for 3 days in the steam void, but that concerns only the ones that uses mobile steam guard right ?
So why all of this movement for something that doesn't hit us ? Or i'm maybe totally wrong, and in this case, please clear the situation ! :(

https://www.reddit.com/r/SteamBot/comments/3udhkd/everything_related_to_escrow/


act dead is impossible to shutdown

acd dead is initiated as expected. however, power button does not allow to reboot into full os. for that, have to unplug first, wait for shutdown, and then start full os

Looks like its a bug in checking conditions at
https://git.sailfishos.org/mer-core/dsme/blob/master/modules/state.c#L368 .
I presume that in my case shutdown_requested=true, charger_state != CHARGER_DISCONNECTED, reboot_requested=false leading to the following sequence in logs
 Sailfish DSME[3236]: pwrkeymonitor: Timer triggered, initiating shutdown
 Sailfish DSME[3236]: state: shutdown request received from dsme
 Sailfish DSME[3236]: state: Actdead (charger: on, alarm: not set)

will have to report upstream

For shutdown, press power shortly to activate display and then power again to start rebooting to the full OS. Considered 'normal' in SFOS. If it is too confusing, open an issue at
https://bugs.merproject.org -> mer-core -> dsme (though if this were a bug it would be in mce, not dsme)
Discussion at http://www.merproject.org/logs/%23sailfishos-porters/%23sailfishos-porters.2019-12-04.log.html#t2019-12-04T21:23:22 and see the next day morning as well
Closing


Update IDIM endpoints

Update the BC Wallet to use the proper TEST (SIT) invironemtn for local development and TestFlight / Google Play releases.

[x] Invitation Credential from TEST environment, unlocks VP from TEST environment

Marcos notes that for local development and testing we should be using the IDIM test URLs. The dev URL is really only for that team to work with.


Wrapping an Svgr icon with Tooltip component does not show the tooltip

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

When I wrap an Svgr icon with the Tooltip component like below the tooltip does not show up.

<Tooltip title="something">
 <SvgIcon width={10} height={10} />
</Tooltip>

If I wrap the icon in a span inside the Tootip like this then it works:

<Tooltip title="something">
  <span>
    <SvgIcon width={10} height={10} />
  </span>
</Tooltip>

Looks like something to do with forwardRef.

Expected Behavior 🤔

It is supposed to show up the tooltip when I hover over the Svgr Icon.

Steps to Reproduce 🕹

Steps:

Use Svgr to & import SVG icon into your component
Wrap the icon in the Tooltip component.
When rendered, hover over the icon & the tooltip does not show up.
Codesandbox link: https://codesandbox.io/s/tooltip-issue-1skht?file=/src/Demo.js

Context 🔦
Trying to show a tooltip when hovering over an SVG icon. Don't want to unnecessarily wrap the icon inside a span or div tag.

Your Environment 🌎

`npx @material-ui/envinfo`
System:
    OS: macOS 11.1
  Binaries:
    Node: 10.20.1 - ~/.nvm/versions/node/v10.20.1/bin/node
    Yarn: 1.16.0 - /usr/local/bin/yarn
    npm: 6.14.9 - ~/.nvm/versions/node/v10.20.1/bin/npm
  Browsers:
    Chrome: 87.0.4280.88
    Firefox: 83.0
  npmPackages:
    @material-ui/core: 4.11.0 => 4.11.0
    @material-ui/lab:  4.0.0-alpha.55
    @material-ui/styles:  4.11.1
    @material-ui/system:  4.9.14
    @material-ui/types:  5.1.0
    @material-ui/utils:  4.9.6
    @types/react: 16.9.2 => 16.9.2
    react: 16.12.0 => 16.12.0
    react-dom: 16.12.0 => 16.12.0
    typescript: 3.8.3 => 3.8.3

@rajatkantinandi the problem with your codesandbox is that you are trying to use directly svg inside the Tooltip. If you see the errors in the console, you will see that the problem is that, the children of the tooltip have to be component that can hold a ref. You can use the createSvgIcon from @material-ui/core/utils to create an svg icon component. Here is an example of it - https://codesandbox.io/s/tooltip-issue-forked-tk9mu?file=/src/Demo.js
Hope this help you understand the issue


best xr tool

Your attention is appreciated. I'm gonna close this issue for now. Feel free to reopen it.


Files UWP crashes when I connect my Zune HD to my PC

Describe the bug
When I connect my Zune HD to my PC, Files UWP will crash.
To Reproduce
These are the steps I did to test this:

Opened Files UWP
I connected my OnePlus phone
Then I connected my Zune HD
FIles UWP Crashed

Expected behavior
Zune HD does not present filesystem access by default in Windows, but is recognised as a device by the Zune software and in Device Manager, and it can open the Zune software on connection.
Desktop (please complete the following information):

OS Version: Version 2004 (OS Build 19041.487)
App version: [v<IP_ADDRESS>]

Additional context
If the Zune HD is already connected, Files UWP launches on first run.
Log file
debug.txt
2020-08-30 07:25:12.6372|INFO|Files.App|App launched|
2020-08-30 07:25:12.7782|INFO|Files.Filesystem.DrivesManager|Drive added: K:\, Removable|
2020-08-30 07:25:12.8533|INFO|Files.Filesystem.DrivesManager|Drive added: C:\, Fixed|
2020-08-30 07:25:12.9082|INFO|Files.Filesystem.DrivesManager|Drive added: D:\, CDRom|
2020-08-30 07:25:12.9442|INFO|Files.Filesystem.DrivesManager|Drive added: E:\, Fixed|
2020-08-30 07:25:12.9782|INFO|Files.Filesystem.DrivesManager|Drive added: F:\, Fixed|
2020-08-30 07:25:13.0132|INFO|Files.Filesystem.DrivesManager|Drive added: G:\, Fixed|
2020-08-30 07:25:13.0512|INFO|Files.Filesystem.DrivesManager|Drive added: H:\, Removable|
2020-08-30 07:25:13.0892|INFO|Files.Filesystem.DrivesManager|Drive added: I:\, Removable|
2020-08-30 07:25:13.1282|INFO|Files.Filesystem.DrivesManager|Drive added: J:\, Removable|
2020-08-30 07:25:13.1722|INFO|Files.Filesystem.DrivesManager|Drive added: K:\, Removable|
2020-08-30 07:25:13.2092|INFO|Files.Filesystem.DrivesManager|Drive added: W:\, Fixed|
2020-08-30 07:25:13.2452|INFO|Files.Filesystem.DrivesManager|Drive added: Y:\, Fixed|
2020-08-30 07:25:20.4005|INFO|Files.Filesystem.DrivesManager|Drive added: \\?\Martin's OnePlus 7T\, Removable|
2020-08-30 07:25:20.4255|INFO|Files.Filesystem.DrivesManager|Drive added: M:\, Removable|
2020-08-30 07:25:36.5815|ERROR|Files.App|Value does not fall within the expected range.|System.ArgumentException: Value does not fall within the expected range.
   at System.Runtime.InteropServices.McgMarshal.ThrowOnExternalCallFailed(Int32, RuntimeTypeHandle) + 0x21
   at __Interop.ComCallHelpers.Call(__ComObject, RuntimeTypeHandle, Int32, HSTRING, Void*) + 0xc2
   at __Interop.ForwardComStubs.Stub_33[TThis, TResult](__ComObject, String, Int32) + 0xa1
   at Windows.Devices.Portable.StorageDevice.FromId(String) + 0x33
   at Files.Filesystem.DrivesManager.<DeviceAdded>d__16.MoveNext() + 0x8a
   at System.Runtime.InteropServices.McgMarshal.ThrowOnExternalCallFailed(Int32, RuntimeTypeHandle) + 0x21
   at __Interop.ComCallHelpers.Call(__ComObject, RuntimeTypeHandle, Int32) + 0xb8
   at __Interop.ForwardComStubs.Stub_11[TThis](__ComObject, Int32) + 0x24
   at Microsoft.AppCenter.Utils.ApplicationLifecycleHelper.<.ctor>b__17_1(Object, UnhandledErrorDetectedEventArgs) + 0x3d
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x21
   at Microsoft.AppCenter.Utils.ApplicationLifecycleHelper.<.ctor>b__17_1(Object, UnhandledErrorDetectedEventArgs) + 0x75
   at System.EventHandler`1.Invoke(Object, TEventArgs) + 0x2e
   at __Interop.Intrinsics.HasThisCall__23[TArg0](Object, IntPtr, Object, TArg0) + 0x36
   at Files!<BaseAddress>+0x133d6f0

Version 0.13.6  is working now, so thanks!


Remove usage of proxy on local connections

I don't think we are supposed to use proxy for tasks with local connection.
I think it even causes errors like this:

TASK [digger-installer/configure-buildfarm : Fetch required plugin]
failed: [osm4-oscp-5node-master1.skunkhenry.com] (item={u'version': u'2.15.4', u'name': u'config-file-provider', u'archive': u'https://updates.jenkins-ci.org/download/plugins/config-file-provider/2.15.4/config-file-provider.hpi'}) => {"failed": true, "item": {"archive": "https://updates.jenkins-ci.org/download/plugins/config-file-provider/2.15.4/config-file-provider.hpi", "name": "config-file-provider", "version": "2.15.4"}, "msg": "Failed to connect to updates.jenkins-ci.org at port 443: [Errno 110] Connection timed out"}

In the case of running the playbook on the master node which would be behind the proxy then the proxy values would be required for the environment in these tasks. I think we should leave the values in as they can be allowed to default to empty values in the case of playbooks being running from a node outside of the proxied network.
I think the error you've described there is created by trying to run the playbook locally with the proxy_url specified. Perhaps it would be better to remove the connection: local from this task. @PhilipGough wdyt?

I think the best way to deal with this is to add some additional logic for a "local_proxy"  since digger-installer could be run from a server that is behind a proxy (which includes nightly tests on a jenkins instance that can use a proxy as well).

@laurafitzgerald Good point. I agree with removing connection: local for "Fetch required plugin" task.
But in second case, in configure_buildfarm_node.yml, there is no need for proxy - even if it is executed on master.
@odra Maybe there are some setting in Ansible for local proxies. Or just setting a proxy on system level could be sufficient.

@matskiv yes agreed on configure_buildfarm_node.yml. The proxy is outbound. In this case the executing node (whether master/admin server or external host) will be making an inbound request to the jenkins url.

Updated as per comments.

If we want to remove connection: local from "Fetch required plugin" task, we need to make more changes. We would have to execute next task ("Install plugins and restart Jenkins server") remotely as well + fetch jenkins-cli.jar on remote machine, etc.

@matskiv Sorry, getting to this late but yes your last comment is the reason for the current implementation

Verification Steps
Run:
ansible-playbook -i <osm4-inventory> sample-build-playbook.yml -e "project_name=proxy-digger-test" --skip-tags=configure-millicore,preflight-checks,deploy-jenkins,gluster-fs,android-sdk --ask-vault-pass

@PhilipGough @wei-lee
could you guys take a look at this one.

@matskiv @laurafitzgerald Bit confused about this. What is the problem here? From my understanding, if we remove the local part, Ansible will use ssh connection (not sure to where).
Given that we do want to run the jenkins tasks on the control machine, I don't see a problem with using the local connection?

@wei-lee Problem with "Fetch required plugin" task is this:
Besides local there also is proxy configuration on this command. If we run it locally it will fail because it can't use proxy. If we remove proxy config from this command it will fail if installation is started from machine behind outbound proxy.

@matskiv yes, I understand now. I had a discussion with @laurafitzgerald and @PhilipGough and we have agreed to remove the local connection, and keep the proxy.


New embed always set vector parameter as true

STR

Just check any new embed url.
Open the source code and check at the end of the html that vector is true, no matter if the param is defined or not in the url.

Maybe related with https://github.com/CartoDB/cartodb/pull/7017.

I'm checking (in local) with master, both with old and new visualizations and I can't reproduce it, embed (http://juanignaciosl.localhost.lan:3000/editor/577394ca-fb66-11e5-b236-080027880ca6/embed) has vector: false :-. Could you give more detail, please?

@xavijam: ok, I spotted the problem. The caching is not working properly. You were seeing a cached version, with vector: true. Just opening the map cleared the cache and worked. I'll dig deeper to avoid this though.


change warn to print

warn is i guess deprecated now?

I kept it as warn because that's what the command outputs - this needs an upstream fix instead


Rotation handle is wrongly placed for non-zero rotation

Bug Description
Rotation handle is wrongly placed for non-zero rotation.
Expected Behaviour

Rotation handle should stick to the element frame.

Steps to Reproduce

Add an image to a page
Rotate it
Observe that the rotation handle is suddenly not connected to the element bug moving away from it.

Issue observed both locally and confirmed on QA environment.
Screenshots

Additional Context

Plugin Version:
WordPress Version:
Operating System:
Browser:

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

Verified in QA


PF Suggestions

This thread is related toPowerForum suggestions.

I think we should take advantage of using AngularJS for this project.