Docker: /root/dlang/ldc-1.27.0/bin/ldc2 failed with exit code 1

For the docker image to load, this will need to be addressed. This may be related to the newest fixed in dhtslib, since the hts_log references were extensively referred to in the latest fixes. Also went up to 1.13 instead of what was used in dev as 1.12.
(ldc-1.27.0)# dub build
Fetching dhtslib ~develop (getting selected version)...
Fetching pyd 0.14.1 (getting selected version)...
WARNING: A deprecated branch based version specification is used for the dependency dhtslib. Please use numbered versions instead. Also note that you can still use the dub.selections.json file to override a certain dependency to use a branch instead.
Performing "debug" build using /root/dlang/ldc-1.27.0/bin/ldc2 for x86_64.
dhtslib ~develop: building configuration "unittest"...
recontig 1.1.1: building configuration "standard"...
source/recontig/bam.d(141,26): Deprecation: constructor `dhtslib.sam.record.SAMRecord.this` is deprecated - Construct with sam_hdr_t* for mapped contig (tid) name support
Linking...
/usr/bin/ld.gold: error: cannot find -lhts
source/recontig/vcf.d:24: error: undefined reference to 'bcf_hdr_dup'
source/recontig/vcf.d:26: error: undefined reference to 'bcf_hdr_remove'
//root/.dub/packages/dhtslib-develop/dhtslib/source/htslib/hts_log.d:92: error: undefined reference to 'hts_log'
source/recontig/vcf.d:37: error: undefined reference to 'bcf_hdr_get_hrec'
source/recontig/vcf.d:37: error: undefined reference to 'bcf_hrec_dup'
source/recontig/vcf.d:40: error: undefined reference to 'bcf_hrec_find_key'
source/recontig/vcf.d:42: error: undefined reference to 'bcf_hrec_set_val'
source/recontig/vcf.d:46: error: undefined reference to 'bcf_hdr_add_hrec'
//root/.dub/packages/dhtslib-develop/dhtslib/source/htslib/hts_log.d:81: error: undefined reference to 'hts_log'
source/recontig/vcf.d:57: error: undefined reference to 'bcf_hdr_sync'
//root/.dub/packages/dhtslib-develop/dhtslib/source/htslib/hts_log.d:116: error: undefined reference to 'hts_log'
//root/.dub/packages/dhtslib-develop/dhtslib/source/htslib/hts_log.d:92: error: undefined reference to 'hts_log'
//root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/vcf/writer.d:59: error: undefined reference to 'hts_open'
//root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/vcf/writer.d:62: error: undefined reference to 'bcf_hdr_dup'
//root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/faidx.d:157: error: undefined reference to 'faidx_fetch_seq64'
source/recontig/mapping.d:0: error: undefined reference to 'seq_nt16_table'
source/recontig/mapping.d:0: error: undefined reference to 'seq_nt16_int'
source/recontig/bam.d:39: error: undefined reference to 'sam_hdr_remove_line_id'
source/recontig/bam.d:39: error: undefined reference to 'sam_hdr_remove_line_id'
//root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/sam/reader.d:77: error: undefined reference to 'hts_open'
//root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/sam/reader.d:96: error: undefined reference to 'hts_set_threads'
//root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/sam/reader.d:103: error: undefined reference to 'hts_set_threads'
//root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/sam/reader.d:115: error: undefined reference to 'sam_hdr_read'
//root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/sam/reader.d:116: error: undefined reference to 'sam_index_load'
//root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/sam/header.d:189: error: undefined reference to 'sam_hdr_add_line'
//root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/sam/writer.d:88: error: undefined reference to 'hts_open'
//root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/sam/writer.d:108: error: undefined reference to 'hts_set_threads'
//root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/sam/writer.d:115: error: undefined reference to 'hts_set_threads'
//root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/sam/writer.d:128: error: undefined reference to 'sam_hdr_write'
//root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/sam/header.d:189: error: undefined reference to 'sam_hdr_add_line'
source/app.d:139: error: undefined reference to 'hts_set_log_level'
source/app.d:140: error: undefined reference to 'hts_set_log_level'
source/app.d:141: error: undefined reference to 'hts_set_log_level'
source/app.d:142: error: undefined reference to 'hts_set_log_level'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/bgzf.d:56: error: undefined reference to 'bgzf_open'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/bgzf.d:63: error: undefined reference to 'bgzf_mt'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/bgzf.d:81: error: undefined reference to 'bgzf_close'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/bgzf.d:152: error: undefined reference to 'hseek'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/bgzf.d:142: error: undefined reference to 'bgzf_getline'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/faidx.d:69: error: undefined reference to 'fai_load3'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/faidx.d:73: error: undefined reference to 'fai_load3'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/faidx.d:81: error: undefined reference to 'fai_destroy'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/faidx.d:179: error: undefined reference to 'faidx_nseq'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/faidx.d:189: error: undefined reference to 'faidx_iseq'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/faidx.d:198: error: undefined reference to 'faidx_seq_len'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/sam/header.d:58: error: undefined reference to 'sam_hdr_destroy'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/sam/header.d:67: error: undefined reference to 'sam_hdr_dup'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/sam/header.d:106: error: undefined reference to 'sam_hdr_name2tid'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/sam/reader.d:143: error: undefined reference to 'hts_close'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/sam/reader.d:423: error: undefined reference to 'sam_itr_queryi'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/sam/reader.d:513: error: undefined reference to 'bam_init1'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/sam/reader.d:516: error: undefined reference to 'hseek'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/sam/reader.d:446: error: undefined reference to 'bam_init1'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/sam/reader.d:449: error: undefined reference to 'bgzf_seek'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/sam/reader.d:581: error: undefined reference to 'bam_init1'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/sam/reader.d:478: error: undefined reference to 'sam_read1'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/sam/reader.d:485: error: undefined reference to 'bam_dup1'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/sam/reader.d:490: error: undefined reference to 'bam_dup1'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/sam/reader.d:545: error: undefined reference to 'sam_read1'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/sam/reader.d:552: error: undefined reference to 'bam_dup1'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/sam/reader.d:557: error: undefined reference to 'bam_dup1'
root/.dub/packages/dhtslib-develop/dhtslib/source/htslib/sam.d:1463: error: undefined reference to 'hts_itr_multi_next'
root/.dub/packages/dhtslib-develop/dhtslib/source/htslib/sam.d:1465: error: undefined reference to 'hts_itr_next'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/sam/record.d:76: error: undefined reference to 'bam_destroy1'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/sam/writer.d:149: error: undefined reference to 'sam_write1'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/vcf/header.d:30: error: undefined reference to 'bcf_hdr_destroy'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/vcf/header.d:46: error: undefined reference to 'bcf_hdr_seqnames'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/vcf/reader.d:79: error: undefined reference to 'hts_open'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/vcf/reader.d:84: error: undefined reference to 'bcf_hdr_read'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/vcf/reader.d:86: error: undefined reference to 'bcf_init'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/vcf/reader.d:101: error: undefined reference to 'hts_close'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/vcf/reader.d:109: error: undefined reference to 'bcf_destroy'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/vcf/reader.d:174: error: undefined reference to 'bcf_read'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/vcf/reader.d:204: error: undefined reference to 'bcf_dup'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/vcf/record.d:149: error: undefined reference to 'bcf_destroy'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/vcf/record.d:160: error: undefined reference to 'bcf_unpack'
root/.dub/packages/dhtslib-develop/dhtslib/source/htslib/vcf.d:1178: error: undefined reference to 'bcf_hdr_id2int'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/vcf/record.d:95: error: undefined reference to 'bcf_unpack'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/vcf/writer.d:68: error: undefined reference to 'hts_close'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/vcf/writer.d:124: error: undefined reference to 'bcf_hdr_append'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/vcf/writer.d:125: error: undefined reference to 'bcf_hdr_sync'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/vcf/writer.d:329: error: undefined reference to 'bcf_hdr_write'
root/.dub/packages/dhtslib-develop/dhtslib/source/dhtslib/vcf/writer.d:334: error: undefined reference to 'bcf_write'
collect2: error: ld returned 1 exit status
Error: /usr/bin/cc failed with status: 1
/root/dlang/ldc-1.27.0/bin/ldc2 failed with exit code 1.

So /usr/bin/ld.gold: error: cannot find -lhts basically just means the linker can't find the htslib shared library. So this is a linker issue.
Looking at your docker branch, I don't think this is the correct way to set environment variables in docker. In docker each line is run in a shell so these variables disappear right after this line:
RUN LD_LIBRARY_PATH=usr/local/htslib-1.13 LIBRARY_PATH=usr/local/htslib-1.13
You will need to use export or maybe the ENV keyword.
Though to avoid all this, you could just base the image off miniconda and install via conda.

If the conda is broken though then both would be broken so maybe we want them to be independent? That would be the quickest way though I agree.
RUN LD_LIBRARY_PATH=usr/local/htslib-1.13 LIBRARY_PATH=usr/local/htslib-1.13 dub build was run internally before to see and test. Even with setting the RUN LD_LIBRARY_PATH=usr/local/htslib-1.13 LIBRARY_PATH=usr/local/htslib-1.13 or with ARG LD_LIBRARY_PATH=usr/local/htslib-1.13 LIBRARY_PATH=usr/local/htslib-1.13 or by setting it internally and then straight running build dub. Haven't tried dmd yet.
For tonight I'm going to leave this.

Though to avoid all this, you could just base the image off miniconda and install via conda.

agree with Kat, would not make it dependent on Conda version functioning

You will need to use export or maybe the ENV keyword.

ENV is correct and export is incorrect (export will work to fix the linking problem (LD_LIBRARY_PATH) but does not persist in the final container; the resulting binary when run in the container won't see the value of the export; thus the LIBRARY_PATH requires ENV)

RUN LD_LIBRARY_PATH=usr/local/htslib-1.13 LIBRARY_PATH=usr/local/htslib-1.13 dub build was run internally before to see and test. Even with setting the RUN LD_LIBRARY_PATH=usr/local/htslib-1.13 LIBRARY_PATH=usr/local/htslib-1.13 or with ARG LD_LIBRARY_PATH=usr/local/htslib-1.13 LIBRARY_PATH=usr/local/htslib-1.13 or by setting it internally and then straight running build dub. Haven't tried dmd yet.

ARG is definitely wrong.
Use ENV as above, and absolute paths. This will solve all your problems. generally try to avoid relative paths unless you have a specific reason to use them

Yes, the absolute paths clear up this error. Had to end up building with the path directly in the build command since it wasn't picking it up as an ENV either for me. Since that was the case, I may have to play around in getting it to actually find the libhts.so.3 library when executing since it's now throwing the below.
/usr/local/recontig/recontig: error while loading shared libraries: libhts.so.3: cannot open shared object file: No such file or directory

We've run into this before, so I can play around with it.

It is not working because you did not follow my instructions.
In this commit you removed the ENV lines. Please go back and re-read my comment

Unless I'm doing something off or completely misreading your instructions it's not actually building an executable, though it completes and builds fine, with just setting the ENV.
Compiling
docker build . -t recontig
[+] Building 0.3s (13/13) FINISHED
 => [internal] load build definition from Dockerfile                                             0.0s
 => => transferring dockerfile: 37B                                                              0.0s
 => [internal] load .dockerignore                                                                0.0s
 => => transferring context: 2B                                                                  0.0s
 => [internal] load metadata for docker.io/library/ubuntu:20.04                                  0.2s
 => [1/9] FROM docker.io/library/ubuntu:20.04@sha256:82becede498899ec668628e7cb0ad87b6e1c371cb8  0.0s
 => CACHED [2/9] RUN apt-get update                                                              0.0s
 => CACHED [3/9] RUN apt-get install -y autoconf automake make gcc     perl zlib1g-dev libbz2-d  0.0s
 => CACHED [4/9] RUN wget https://github.com/samtools/htslib/releases/download/1.13/htslib-1.13  0.0s
 => CACHED [5/9] RUN cd /usr/local/ && tar -xvf /usr/local/htslib-1.13.tar.bz2 &&     cd htslib  0.0s
 => CACHED [6/9] RUN pip install cython pyd                                                      0.0s
 => CACHED [7/9] RUN curl https://dlang.org/install.sh | bash -s ldc                             0.0s
 => CACHED [8/9] RUN cd /usr/local/ && git clone --recurse-submodules https://github.com/blachl  0.0s
 => CACHED [9/9] RUN . ~/dlang/ldc-1.27.0/activate && cd /usr/local/recontig     && python3 set  0.0s
 => exporting to image                                                                           0.0s
 => => exporting layers                                                                          0.0s
 => => writing image sha256:7db1b57083cf2ed13cee6694f77bab135c7af9bd88b3cd2e14f32dc3c5810f16     0.0s
 => => naming to docker.io/library/recontigv13

But when one looks inside nothing is made.
b940d01ecd69 /bin/sh
# cd usr/local/recontig
# ls
INSTALL.md  README.md  dhtslib	 pyrecontig.py	source
LICENSE     build      dub.json  setup.py

The way I wiggled around it was by the updated docker which compiles a binary but is not linking fully either,libhts.so.3.

It wasn't building an executable because it didn't have a dub build line.

/usr/local/recontig/recontig: error while loading shared libraries: libhts.so.3: cannot open shared object file: No such file or directory

So this means the executable cannot find the libhts.so.3. This almost always means libhts.so.3 is not on the LD_LIBRARY_PATH. LIBRARY_PATH is just specific to the ldc compiler and its use of ld.gold for linking but is similar.
Since htslib installs into /usr/local/lib by default with make install.
Adding these lines to the docker file fixes both issues:
ENV LD_LIBRARY_PATH /usr/local/lib
ENV LIBRARY_PATH /usr/local/lib

I have pushed a commit that makes these changes and some additional ones:

Good coding practice is to make environment variables (or constants) completely capitalized
Recontig's version is set as we don't want the docker building from master
moved the recontig binary from its folder to /usr/local/bin as this is on the linux PATH so you can run it without specifying the full path
You should use WORKDIR to change directories in a docker file as otherwise many steps are one line. Other than being hard to read this doesn't allow docker to create a intermediate step for each actual step.

This is working now with the /usr/local/lib adjustments to the htslib paths. Many thanks, both.


NullPointerException:  computeBounds in RenderableShadowNode

Hi,
I have an issue with the rendering of a Path component, it crashes the app in some rare occasions, and the stack trace I found for the crash is as follows:
https://hastebin.com/majabuyayu.php
As seen by the stack trace it happens at:
https://hastebin.com/opucugegus.cpp
That gets called by the function hitTest, but checks if the mPath object is null before continuing.
if (mRegion == null) {             mRegion = getRegion(mPath);         }
If anyone has any solution to this issue, it would be greatly appreciated.
Best Regards

I opened a pull request that fixed the issues I had.
Is it possible to get these pulled as soon as possible?

@ExoMemphiz is it possible to see svg code that you were trying to render?

Sure, the part that was causing the crashes was when drawing an elliptical arc path, using this code:
https://hastebin.com/nemiserize.js
If you need more details feel free to ask, I will try to respond as soon as possible.
Best Regards

@ExoMemphiz could you please provide svg snippet with exact values for all parameters you have so we can copy/paste it into playground and test?
Also it would be great if you could set up demo project and post a reference here.

Closing because of inactivity.


Reduce consumption of entropy source

The whole CI infrastructure on docker/docker is suffering from entropy exhaustion. As pointed out by @ewindisch, the UUID generation code here is wasting some entropy bytes. That may not be a sufficient fix, but still seems like an improvement.
The UUID generation retries multiple times to read a full UUID, but preserves any bytes of entropy he successfully managed to read between retries.
Ping @jfrazelle @crosbymichael @calavera.

Updated.

LGTM

LGTM

LGTM
I am not sure if this will help with the CI issues. This code is not the root cause and it only ever runs once for the client code.
Don't merge until CI is fixed.

@icecrime Could you rebase to current master? I think this branch is missing a fix.

bump that shiz in docker ;)


Immutable.js support?

Currently, diffing process uses just triple equality. It is not suitable in using Immutable#List, because triple equality always returns true even between two different Lists. I would like to get a support of is method from Immutable.js for a right diffing.
ref: https://facebook.github.io/immutable-js/docs/#/is
For further understanding, here is the app on playground using Undux + Immutable.js
https://codesandbox.io/s/kw1vvv5mp5
The point I mentioned in this issue is happening in these lines in todoActions trying updating store but I can't.
    markTodoDone(index: number) {
      const currentTodos = store.get("todos");
      const updatedTodos = currentTodos.update(index, (todo: Todo) => {
        const updatedTodo = todo;
        updatedTodo.markDone();
        return updatedTodo;
      });
      store.set("todos")(updatedTodos);
    }

Excellent idea! I’m happy to do this one.

Done in 3.2.0 - let me know how it works for you @IzumiSy!

Thank you very much!!


Create a automatic carousel slider

One need to make this component using HTML and Tailwind CSS. I would suggest to use Tailwind Playgrounds to make things faster and quicker.
Here is a reference to the component.

After building the component please raise a PR with a screenshot of the component and add the component in path of the file.
If you need to use any icon please use it from Hero Icons
Good luck.

Will it be purely with HTML and Tailwind CSS? @Tushar98644

Yeah make it. Add it to Others folder as well. As of now. @Tushar98644


GSSoC: Enhancement-Redesigning the cards of home section

Description
I want to enhance the style of cards of home page to improve the overall look.
Please assign this task to me.
Changes You need to make
I will change the style of cards and buttons
Screenshots

Checklist
Before submitting your pull request, ensure that you have completed the following tasks:

[x] Gone through the rules and guidelines of the project.
[ ] When you are creating PR, your PR should title follows the specified format: [Feature/Enhancement/Bug Fix]: Brief description of the change.
[x] Attached OSSI or GSSoC in the heading of the Issue.
[x] I have checked this issue is not already covered in another issue.

Expected Time to Complete
Provide an estimate of the time required to complete the changes proposed in this issue. This could be a rough estimate or a specific timeframe based on your availability and the complexity of the task.
Additional Notes
Add any additional information, concerns, or considerations that may be relevant to your pull request. This could include performance implications, future enhancements, or potential risks associated with the changes.

Please attach the screenshot what you want to develop.

Please attach the screenshot what you want to develop.

I want to redesign these cards

@Swarnendu0123 can i make cool cards for it?

@Swarnendu0123 can i make cool cards for it?

Please share the new design!


Add extern only when a c project has c++ fuzz targets

Almost all regressions in https://github.com/google/oss-fuzz-gen/pull/382#issuecomment-2190303945 are due to C projects using C++ fuzz targets.
This PR resolves that.

/gcbrun exp -n dg

/gcbrun exp -n dg

/gcbrun exp -n dg -f

/gcbrun exp -n dg -f

/gcbrun exp -f -n dg

Seeing more buildable benchmarks with the fix:

/gcbrun skip


metadata: token price

anon role doesn't have read access to unit_name in the table token_price can you add it to the metadata in case you do any updates

*i've already update the privilege in the console


Image links in ConversionToAddressables.md broken

Seems none of the images referenced in the following article are accessible or working.
https://github.com/oculus-samples/Unity-AssetStreaming/blob/main/ConversionToAddressables.md

Thanks for raising this issue. We fixed the images on the page.

Thanks for responding so quickly @AlexThiv  :D


Double counting of primes for some ranges?

Steps to Replicate
lastNumber = 10
sliceSize = 5

expected Output: 4
Actual Output: 5

I suspect this is happening because when to is a primeNumber, it is double counting it in the current block and then in the next block as well when it becomes from

Sorry, didn't see you were multiplying the sliceSize by 2. Closing the issue.


Extended car  movements

As a player, I would like to move the car in a more flexible way combining diagonal movement with basic directions, so that I can react rapidly to race conditions.
Acceptance criteria: The car executes the appropriate diagonal movement.
The car can have 8 orientation,where the car head points to 8 angles: 0,45,90,135,180,225,270,315.

This issues updates #7 makes sure to add it to the description

Both this pull request are improving the car movements and are related to this issue as well as #7.


T3S removed from Package Control

I was running my latest dotfiles repo and it appears that T3S has been removed from Package Control in Sublime Text 3.

This has been resolved.


creating too many EMFs

Currently, we appear to be recreating the EMF for every repository we instantiate or something like that.
This is a problem, because test data population is tied to the EMF lifecycle.
I'm not sure whose fault this is, the TCK, or this project.

See if the last commits resolves this. The EMF should be coming from an ApplicationScoped producer value.

Yup, I guess that fixed  it.
Merge https://github.com/jakartaredhat/hibernate-data-tck/pull/7, and then we're down to:
 [ERROR] Tests run: 73, Failures: 5, Errors: 0, Skipped: 0, Time elapsed: 55.023

Though, I'm a bit confused. I had expected that fixing the scoping issue would also fix EntityTests.testUpdateQueryWithoutWhereClause(). I'm surprised it's still failing.

Also moving the resizeAll() method from MultipleEntityRepo to Boxes fixes the test failure.
So it's definitely something to do with having multiple repos.

I now strongly suspect that this is because when we have multiple repos, we get a separate StatelessSession for each one. And, because we're not using a JTA DataSource, and also because there's anyway no JTA transaction in progress, each StatelessSession gets its own JDBC Connection.
I'm not really sure what to say about that. I guess we need to inject the StatelessSession instead of the EntityManagerFactory to make this work.

Solved by setting hibernate.connection.autocommit=true.


Fix firefox endless spinner in stream

fix a firefox bug where the spinner would not disappear, apparently when
the user would see a stream.
The reason seems to be ngparticles in combination with firefox, where
firefox would be stuck in never-stable when ngparticles was loaded
before the browser was ready

also: fix a regression where the steeam window would not enlarge to the correct size


Update readme

Overview
Currently if following README it not worked, so I'm just adjust it to make it the same as Example

Thank you! I forgot to update the README with the new changes


raidboss: Fix some triggers using matches.duration instead of matches.castTime

Noticed when testing performance in alliance raids, there were some triggers using matches.duration instead of matches.castTime. Checked with this regex and found another case:
NetRegexes.startsUsing.*?\n(?:      [^ ].*\n)*      delaySeconds.*duration

I checked any other cases of \.duration[^a-zA-Z] in triggers and it looks like these are the only cases?

There are some other places where triggers are using matches.duration without passing them through parseFloat, but I'm guessing those can be cleaned up as those triggers are converted to typescript.


Support SCS Vulnerabilities in json report when Agent is VSCode/AST-CLI (AST-63907)

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
Added full support for SCS engine results when scanning from the CLI.
Added partial support (only Secret Detection results) when scanning is done from VS Code
No other case SCS results are supported
References
https://checkmarx.atlassian.net/browse/AST-63907
Testing
Adding unit tests to test the following scenarios:
Scan from CLI - expect to receive all SCS engine results.
Scan from VS Code - expect to get only Secret Detection results.
Scan from another engine - expect to get no results from the SCS engine.
Scan without results from SCS.
Scan with NULL results.
Checklist

[ ] I have added documentation for new/changed functionality in this PR (if applicable).
[ ] I have updated the CLI help for new/changed functionality in this PR (if applicable).
[ ] All active GitHub checks for tests, formatting, and security are passing
[ ] The correct base branch is being used

Nice job!


Add Markup representation for defining planes

Subtask of https://github.com/PerkLab/BwhNeuroImagingCollab/issues/4
There is currently no widget in Slicer for placing and modifying an arbitrary plane.
The new plane representation will be implemented within the Markups module.

Plane representations have been added to Slicer core (vtkMRMLMarkupsPlaneNode).


Fix spdlog leakage

Close #2.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

@jakirkham Should I point RMM_BINARY_DIR to $PREFIX/lib? Otherwise rmm insists on putting some cmake files in $PREFIX/lib64/.

Would add -DCMAKE_INSTALL_LIBDIR="lib" to the cmake configuration in build.sh. This should ensure it uses lib instead of lib64

Oops I just pushed. Would an absolute path work? (-DCMAKE_INSTALL_LIBDIR="$PREFIX/lib")

Oops I just pushed. Would an absolute path work? (-DCMAKE_INSTALL_LIBDIR="$PREFIX/lib")

Looks like it worked!

@kkraus14 @jakirkham @rlratzel PTAL.
btw @rlratzel a friendly reminder: You need to accept the invitations sent by GitHub so that you can join the Conda-Forge org and that we can ping you as a maintainer in a feedstock. 🙂

Oops I just pushed. Would an absolute path work? (-DCMAKE_INSTALL_LIBDIR="$PREFIX/lib")

Looks like it worked!

It use to matter, but it sounds like they fixed it

btw @rlratzel a friendly reminder: You need to accept the invitations sent by GitHub so that you can join the Conda-Forge org and that we can ping you as a maintainer in a feedstock. 🙂

Sorry about that! I just accepted the invite.

No worries, thanks Rick!


Search SDK: Add missing analyzer names

...and bump package version to 1.1.1.

Fix for https://github.com/Azure/azure-sdk-for-net/issues/1842


Add QuPath viewing notebook

In a similar spirit as #67, this adds a notebook that walks through the basics of how to use QuPath to open WSI data, in particular DICOM and converted OME-TIFF.
There is no code in this notebook, it is only text, images, and video. The videos were too large to embed, so are separate files that are referenced within the notebook. If something other than a notebook would be more useful to represent this information, I can certainly switch to markdown or something else.
Note that if viewing the notebook directly in GitHub, it may not display correctly. Checking out this pull request's branch and running the notebook should work as intended.
cc @fedorov, @dclunie, @erindiel

Hi Melissa,
I am Daniela, also part of the IDC team and Andrey asked me to check out your notebook and let you know my feedback!
I think, this notebook is very helpful for users that are interested in IDC data, but are loyal users of QuPath and don't want to switch tools or just do some of their normal stuff they use to do with QuPath on IDC data. As you said yourself, this could maybe - instead of a notebook - be presented in a different form and I thought about a subpage in IDC documentation or a folder in Github with a README and your videos. But I am not sure, if it is worth the effort right now or we can just stay with the notebook. For some reason, in Github, I can not display the notebook completely and had to download it to see the rest (see attached screenshot). Not sure, if the problem here is on my side or on Github's (see below).
One more thought that I had: it might be nice (as this notebook is for beginners) to go one more step back and refer to documentation on how to download the images in the first place.

I also think that since this tutorial does not have any code, it is best to maintain it in a dedicated documentation page. Python notebook is suboptimal and unnecessary here, and also putting large video files into the code repository is generally not a good idea. To make it easier for you @melissalinkert I will make a page under IDC docs and transfer the content there. I will then point you to that page and give you instructions how to update the content, if you need to do so.

Thank you for the comments, @DanielaSchacherer and @fedorov.

For some reason, in Github, I can not display the notebook completely and had to download it to see the rest (see attached screenshot). Not sure, if the problem here is on my side or on Github's (see below).

This is unfortunately a general issue with displaying more complex notebooks in Github, and is something @erindiel and I saw when initially looking at this as well.

One more thought that I had: it might be nice (as this notebook is for beginners) to go one more step back and refer to documentation on how to download the images in the first place.

That makes complete sense. Is there an existing page we should link to, or just copy the instructions similar to what is noted in https://github.com/ImagingDataCommons/IDC-Tutorials/pull/67/files#r1744114094?
I also agree that a documentation page instead of a notebook makes sense here. @fedorov, if you would prefer I move the text/videos to a documentation page, I am happy to do so, just let me know where to edit or open a new pull request.

This is unfortunately a general issue with displaying more complex notebooks in Github, and is something @erindiel and I saw when initially looking at this as well.

Ok, another argument for moving this notebook to IDC documentation :)

That makes complete sense. Is there an existing page we should link to, or just copy the instructions similar to what is noted in https://github.com/ImagingDataCommons/IDC-Tutorials/pull/67/files#r1744114094?
I also agree that a documentation page instead of a notebook makes sense here. @fedorov, if you would prefer I move the text/videos to a documentation page, I am happy to do so, just let me know where to edit or open a new pull request.

If it's going to be a page in the IDC documentation, we could just link here in my opinion: https://learn.canceridc.dev/data/downloading-data.

I now created a dedicated "Tutorials" section in the docs, a subsection dedicated to slide microscopy, and added the content of this notebook there: https://learn.canceridc.dev/tutorials/slide-microscopy/qpath-for-sm-visualization.
To update the content, this is the file to change: https://github.com/ImagingDataCommons/IDC-Docs/blob/prod/tutorials/slide-microscopy/qpath-for-sm-visualization.md.
I placed mp4 files into Google Drive and embedded as Google Slides, since I do not want to commit such large files into a GitHub repo. This is the directory with the content (I can share if you would like to add content).


Webpack resolver: Support webpack.config.babel.js filename

If you rename your file to webpack.config.babel then webpack will transpile it with babel on the fly.
However doing this makes the webpack resolver fail to load the webpack config.
Right now, my workaround is:
// webpack.config.js
/*
 * This file is here until this gets supported:
 */
require('babel-register')
module.exports = require('./webpack.config.babel').default

Would love this to be supported in core. But looking at the code I wasn't certain how you'd want it implemented. I was thinking of extracting this into a function. But feedback is appreciated.
Thanks!

Makes sense. That is cool, didn't realize that was possible.
Reminds me of #182. I'd like to avoid slowly rewriting Webpack. This seems like a simple enough thing to fix without biting off integration with enhanced-resolve, though.
Does #164 seem like a workable solution? I didn't really understand what it was doing until reading the SO post you linked.

Looks like #164 is using interpret, but not to load the config file (which is what concerns this issue). I've never used interpret myself.

Hmm, I read it as "if the config file has an extension that interpret understands, register the compiler for all files with that extension". Which makes sense, no knowing what other non-JS files the config might require.
I've not used it either, but I can imagine it working in such a way.
I'll try it out, and see if I can add some tests.
Or if you've got a different idea you want to try, I'm up for that. Sounds like interpret is a good place to start, though.

interpret is what webpack uses to do it!

I believe this was fixed by #164.


WIP slack

This is what I have so far for adding slack support to runbld. Let me know what you think.
Next is to write a good template.

Left some comments but generally looks good to me! I can only comment on the Clojure-y parts and not the runbld as a whole parts though :)

runbld seems to hang if the slack API returns an error, need to figure out how to mitigate that.

This is really good @joehillen!  My only question is why make the slack API payload a template?  The JSON should probably be generated from code.  Or were you just trying to match the behavior of the email notifier?

@drewr The reason for making it a template is so that different tests/rooms can have different slack messages if they want. I didn't feel comfortable deciding what was best for every project.

Totally agree with the motivation, just not sure that's the right place for the template.  We may want to put it in the config file.  Let me think about it some more.

I fixed that last issue that made runbld hang. This is no longer WIP.

@drewr done

Great.  Have you tested it on a local Jenkins yet?  We don't have any opt handling yet, for example, to say that the default template is templates/slack.mustache.json.

We don't have any opt handling yet, for example, to say that the default template is templates/slack.mustache.json

My bad. I meant to, but I forgot.

Have you tested it on a local Jenkins yet?

I have now.

Awesome, I think this LGTM.  So the next step after merging would be to also merge to 0.99 branch, and then generate a release for deployment.
% ./release.hs 0.99.32 packages.elasticsearch.org/infra/


Enable TypeScript type coverage for PRs and master

Improvements
Investigate integrating with type coverage in Paragon CI.
E.g., see https://github.com/plantain-00/type-coverage.

How to setup:

Log into our web application using Github.
Click the "Add new project" button.
You will be redirected back to the GitHub interface where you need to select the appropriate repositories.
Once done you should be able to see all repositories within our app (if not please refresh). Note that in the right top corner, you can switch between orgs.
Copy the secret using the "copy" button and paste it as the secret environment inside your CI interface: CC_SECRET=COPIED SECRET
Install @codechecks/client and typecov packages.
Let's create codechecks.yml file which is used to declaratively configure multiple checks.

Code example
Get started
Typecov

@PKulkoRaccoonGang Thanks for providing this info. I will reach out to Axim engineering to see if they'd entertain the idea of authorizing this GitHub application.

@adamstankiewicz Reach out to Axim about bundlesize CI checks as this CI check may be able to do bundlesize as well (no duplicate efforts).


Pubsub doc doesn't have the require statement

Looking at http://googlecloudplatform.github.io/gcloud-ruby/docs/master/Gcloud/Pubsub.html
# require 'gcloud/pubsub' would be here?
pubsub = Gcloud::Pubsub.project "my-todo-project",
                                "/path/to/keyfile.json"
topic = pubsub.topic "my-topic"
msg = topic.publish "task completed"

This is fixed in the updated documentation.
See http://googlecloudplatform.github.io/gcloud-ruby/docs/master/Gcloud/Pubsub.html


Question about calling the 'gym.make' function and associated file for 'myoElbowPose1D6MRandom-v0'

Hello,
I have a question regarding the following code snippet:
import myosuite
import gym
env = gym.make('myoElbowPose1D6MRandom-v0')
env.reset()
for _ in range(1000):
env.sim.render(mode='window')
env.step(env.action_space.sample()) # take a random action
env.close()
In this code, I noticed the usage of the gym.make function with the argument 'myoElbowPose1D6MRandom-v0'. I'm curious about how this function call is handled and if there is a specific file that controls the environment with the name 'myoElbowPose1D6MRandom-v0'.
Could you please provide some insight into the internal workings of gym.make and how it retrieves and initializes the specified environment? Additionally, I would appreciate any information on the file structure or configuration associated with the environment named 'myoElbowPose1D6MRandom-v0'.
Thank you in advance for your assistance!
Best regards,
Abdul haq Ayantayo

Hey!
Gym contains by default a list of available environments that you can construct by using:
env = gym.make('environment_name-v0')
When you import the myosuite, new environments are registered in that list. This makes them available to be used.
Let's look at this init file to see how this works in your example.
We can see in line 103:
register_env_with_variants(id='myoElbowPose1D6MRandom-v0',
        entry_point='myosuite.envs.myo.pose_v0:PoseEnvV0',
        max_episode_steps=100,
        kwargs={
            'model_path': curr_dir+'/assets/arm/myo_elbow_1dof6muscles.xml',
            'target_jnt_range': {'r_elbow_flex':(0, 2.27),},
            'viz_site_targets': ('wrist',),
            'normalize_act': True,
            'pose_thd': .175,
            'reset_type': 'random'
        }
    )

This means that an environment with the name 'myoElbowPose1D6MRandom-v0' is registered as a gym environment. Afterwards, you can call gym.make('myoElbowPose1D6MRandom-v0') to create it.
You will also see in this code snippet that an entry_point is used, namely 'myosuite.envs.myo.pose_v0:PoseEnvV0'. This describes where the actual code of the environment lives. In our case, the environment 'myoElbowPose1D6MRandom-v0' is created by constructing the class  'myosuite.envs.myo.pose_v0:PoseEnvV0', which is from this file.
The remaining arguments that are given in the register_env function will get passed to PoseEnvV0 and determine its properties, like the xml file or target ranges. In this case, the 'model_path': curr_dir+'/assets/arm/myo_elbow_1dof6muscles.xml' xml file is loaded and the reset type is random, among other things.
Feel free to ask more questions!
Best,
Pierre


Fix problem when filtering a root array

This PR fixes an issue(#20) when root object is an array and filtering via child map field values is applied and nothing is returned. Tests are also included.

Also fixes #18

@oliveagle could you check on PRs I made last week?

bump

bump ?


Mounting fails when rendering a component with  element

When defining a test like this:
const formField = mount(<SvgIcon id="alert" />);
Where the SvgIcon component returns:
<svg className={classes}><use xlinkHref={#${iconId}}></use></svg>
The enzyme mount fails, as discovered when trying to run .find('.className') on the mounted component and getting this output:
    TypeError: classes.replace is not a function
        at instHasClassName (c:/Projects/dls/tests/components/forms/withValidationMessage.spec.js:25749:22 <- webpack:///~/enzyme/build/MountedTraversal.js?0c5a
*:69:0)
        at c:/Projects/dls/tests/components/forms/withValidationMessage.spec.js:25904:21 <- webpack:///~/enzyme/build/MountedTraversal.js?0c5a*:224:0
        at findAllInRenderedTreeInternal (c:/Projects/dls/tests/components/forms/withValidationMessage.spec.js:25962:14 <- webpack:///~/enzyme/build/MountedTrav
ersal.js?0c5a*:282:0)
        at findAllInRenderedTreeInternal (c:/Projects/dls/tests/components/forms/withValidationMessage.spec.js:25977:23 <- webpack:///~/enzyme/build/MountedTrav
ersal.js?0c5a*:297:0)
        at findAllInRenderedTreeInternal (c:/Projects/dls/tests/components/forms/withValidationMessage.spec.js:25974:25 <- webpack:///~/enzyme/build/MountedTrav
ersal.js?0c5a*:294:0)
        at findAllInRenderedTreeInternal (c:/Projects/dls/tests/components/forms/withValidationMessage.spec.js:25977:23 <- webpack:///~/enzyme/build/MountedTrav
ersal.js?0c5a*:297:0)
        at findAllInRenderedTreeInternal (c:/Projects/dls/tests/components/forms/withValidationMessage.spec.js:25974:25 <- webpack:///~/enzyme/build/MountedTrav
ersal.js?0c5a*:294:0)
        at findAllInRenderedTreeInternal (c:/Projects/dls/tests/components/forms/withValidationMessage.spec.js:25977:23 <- webpack:///~/enzyme/build/MountedTrav
ersal.js?0c5a*:297:0)
        at treeFilter (c:/Projects/dls/tests/components/forms/withValidationMessage.spec.js:25987:11 <- webpack:///~/enzyme/build/MountedTraversal.js?0c5a*:307:
0)
        at ReactWrapper.<anonymous> (c:/Projects/dls/tests/components/forms/withValidationMessage.spec.js:21278:13 <- webpack:///~/enzyme/build/ReactWrapper.js?
f480*:62:0)

Likely a duplicate of https://github.com/airbnb/enzyme/issues/375. Are you using jsdom or testing in a real browser environment?

Yup, that looks like exactly the issue I'm having. We're running the tests in Chrome.

I'm going to close this in favor of #375 and reopen it so we can discuss implementing SVG support where we can.


feat: eslint, cspell, prettier

add eslint, cspell, prettier
npm run test

also check linting, formatting and spelling
This PR cause a massive changes due to follow linting, formatting and spelling best practice

Sorry, I'm not interested in having these things in the project

Why not? eslint, cspell and prettier are must to have in large project with multiple contributors. ESLint enables developers to discover problems with their code without actually executing their code. Prettier enforces a consistent code style across your entire codebase.

Ok, I undestand. I have also added extensions for VSCode that help and a "fix" command for autofix. Try It. It's not invasive and help a lot.


I have a problem signing up on my site

no matter how many times i press the setup profile button on the sign up page, it does not move on

Hi, It should be showing either an error for Invalid/Empty Email or Invalid Password thats why the screen must not be moving forward. For me the page is moving forward.

Turns out the Email API had expired. Should be running now


[SPARK-13751] [SQL] generate better code for Filter

What changes were proposed in this pull request?
This PR improve the codegen of Filter by:

filter out the rows early if it have null value in it that will cause the condition result in null or false. After this, we could simplify the condition, because the input are not nullable anymore.

Split the condition as conjunctive predicates, then check them one by one.

Here is a piece of generated code for Filter in TPCDS Q55:
/* 109 */       /*** CONSUME: Filter ((((isnotnull(d_moy#149) && isnotnull(d_year#147)) && (d_moy#149 = 11)) && (d_year#147 = 1999)) && isnotnull(d_date_sk#141)) */
/* 110 */       /* input[0, int] */
/* 111 */       boolean project_isNull2 = rdd_row.isNullAt(0);
/* 112 */       int project_value2 = project_isNull2 ? -1 : (rdd_row.getInt(0));
/* 113 */       /* input[1, int] */
/* 114 */       boolean project_isNull3 = rdd_row.isNullAt(1);
/* 115 */       int project_value3 = project_isNull3 ? -1 : (rdd_row.getInt(1));
/* 116 */       /* input[2, int] */
/* 117 */       boolean project_isNull4 = rdd_row.isNullAt(2);
/* 118 */       int project_value4 = project_isNull4 ? -1 : (rdd_row.getInt(2));
/* 119 */
/* 120 */       if (project_isNull3) continue;
/* 121 */       if (project_isNull4) continue;
/* 122 */       if (project_isNull2) continue;
/* 123 */
/* 124 */       /* (input[1, int] = 11) */
/* 125 */       boolean filter_value6 = false;
/* 126 */       filter_value6 = project_value3 == 11;
/* 127 */       if (!filter_value6) continue;
/* 128 */
/* 129 */       /* (input[2, int] = 1999) */
/* 130 */       boolean filter_value9 = false;
/* 131 */       filter_value9 = project_value4 == 1999;
/* 132 */       if (!filter_value9) continue;
/* 133 */
/* 134 */       filter_metricValue1.add(1);
/* 135 */
/* 136 */       /*** CONSUME: Project [d_date_sk#141] */
/* 137 */
/* 138 */       project_rowWriter1.write(0, project_value2);
/* 139 */       append(project_result1.copy());

How was this patch tested?
Existing tests.

Test build #52686 has started for PR 11585 at commit edc934f.

Test build #52686 has finished for PR 11585 at commit edc934f.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Filter(condition: Expression, child: SparkPlan)

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52686/
Test PASSed.

Merged build finished. Test PASSed.

@sameeragarwal how does this relate to what you are working on?

@nongli It seems that once we have this, we don't need #11511 anymore, right?

@nongli @davies I think part of the rationale for having https://github.com/apache/spark/pull/11511 was to avoid having the extract the operator's (and its child's) constraints during the physical planning/ codegen phase. Could we not just rewrite the code generated by filter such that all isNotNull attributes are converted to ${input(i).isNull`? Along with https://github.com/apache/spark/pull/11372, https://github.com/apache/spark/pull/11511 would help us achieve the same goal.

Also @davies, if you prefer your current approach, we then need to propagate the constraints in the physical plan as well (currently they are only propagated in the logical plan).

After offline discussion with @sameeragarwal , we agreed that 1) the constraints should only used in logical plan 2) we should use the IsNotNull() inserted by #11372, 3) we do need to re-order the conditions anymore, just do that in Filter. 4) The IsNotNull from join ares pushed down into it's children, join requires nullability propagated from it's children, that's another story.
I will update this PR based on these, and revert #11511
cc @yhuai @nongli

Test build #52757 has started for PR 11585 at commit 4317853.

Test build #52757 has finished for PR 11585 at commit 4317853.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52757/
Test FAILed.

Test build #52780 has started for PR 11585 at commit 2ec7f5e.

Test build #52780 has finished for PR 11585 at commit 2ec7f5e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52780/
Test FAILed.

Merged build finished. Test FAILed.

Test build #52858 has started for PR 11585 at commit b2906e6.

Test build #52858 has finished for PR 11585 at commit b2906e6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52858/
Test PASSed.

Merged build finished. Test PASSed.

LGTM

Merged into master


Typo

Hi @vitorfariatomaz, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@vitorfariatomaz : Thanks for your contribution to the Azure documentation! The author, @ddove, has been notified to review your proposed change.

@ddove

#sign-off

#sign-off
@JennieHubbard
@CarlRabeler

#sign-off

The ready-to-merge label could not be added to this pull request. Only the author of the article can use the sign off comment to add the ready-to-merge label.

#sign-off

@cjgronlund ready to merge

Only the author of the article can use the sign off comment to add the ready-to-merge label.

@tysonn Please Merge


Bug: Cannot cast some of the UWP activation arguments using dotnet as operator

Description
This is related to https://github.com/microsoft/microsoft-ui-xaml/discussions/9983#discussioncomment-10708446
When publishing a UWP project using the preview .net 9 support with AOT, I noticed a crash when an appservice from a win32 helper tries to connect. It turns out that casting the argument (args.TaskInstance.TriggerDetails) in the BackgroundActivated(BackgroundActivatedEventArgs args) activation method to AppServiceTriggerDetails fails using the dotnet as operator. However, it works using args.TaskInstance.TriggerDetails.As<AppServiceTriggerDetails>().
Steps To Reproduce
A project that uses background activation through an appservice with a win32 helper is needed. The project also has to be published with AOT in release mode by creating an msix package (it sometimes worked in Debug configuration).
Expected Behavior
Casting using dotnet operator should work
Version Info
cswinrt 2.1.16
dotnet 9 rc2
Additional Context
No response

Does (AppServiceTriggerDetails)args.TaskInstance.TriggerDetails work?

No, I get an InvalidCastException in this case.

Can you try to check if the type of TriggerDetails is WinRT.IInspectable?

Using GetType().FullName indeed returns WinRT.IInspectable when publishing the msix with AOT and AppServiceTriggerDetails otherwise.

I've found the issue with the as operator. Since C#/WinRT could not reason what the actual type is in AOT mode (since it doesn't support dynamic code), it fallbacks to the IDynamicInterfaceCastable implementation. That implementation then checks the helper type of AppServiceTriggerDetails, which it expects an interface. However, the helper type of AppServiceTriggerDetails is a struct, not an interface, hence it fails.
I haven't managed to see why As<TInterface>() works though, since from my initial look it seems to also be going through IDynamicInterfaceCastable?

Given this is a class type with just an WinRT exclusive interface, there isn't any IDynamicInterfaceCastable interface today.  I assume As<> works because it is making sure the type doesn't get trimmed whereas with just a cast, .NET is deciding it can trim it as it only seen it used with the cast especially given the API that it is returning this says it returns an Object.


Just upgraded to 2.4.2 lots of errors in profiles page

Just performed the upgrade to 2.4.2 from 2.3.0 and profile reporting appears to be working, but when I go to the 'Profile' listing page it displays the following like 15 times.
Warning: gzinflate(): data error in /usr/share/nginx/html/report/system/kissmvc_core.php on line 630
If I view any individual machine's 'Profile' section I see the following:
Notice: Undefined variable: profiles in /usr/share/nginx/html/report/system/kissmvc_core.php(316) : eval()'d code on line 20
The profiles are visible and I can view the payload, but I have those errors in MunkiReportPHP. Not sure if this is a bug or if I messed something up.

Oww, I missed that one. I fixed it a month ago, but apparently failed to add it to the master branch. Could you check out the current master branch and see if it fixes your issue? You might have to drop the profiles table.

Thanks for responding and acting on this so quickly! I am not longer seeing the gzipinflate() warning, but I do still see
Notice: Undefined variable: profiles in /usr/share/nginx/html/report/system/kissmvc_core.php(316) : eval()'d code on line 20 when I go to view an individual machines profile listing. I did drop the profile table as well. Should I drop the machine table as well?

Works as expected now!


add some params for more flexibility

Add below params :
'ftps' => true, // use ftps:// with implicit TLS or ftp:// with explicit TLS
'passive' => true, // default use PASV mode
'skipPasvIp' => true, // ignore the IP address in the PASV response
'verbose' => false // set verbose mode on/off

I don't know why can't pass travis-ci check, but in my environment is test OK.
Maybe could you please check it, thanks

good work!

@vyuldashev  Could you please merge this request? I need the ftps config option.

@chinlung Thank you. I hope @vyuldashev can merge this soon.


docs: add PR template

The doc must have:
Summary, Changes Made, Related Issues, Checklist with brief description on each one or bullet points.
Example:

I'd love to work on this! I am a front end dev, i am familiar with ci workflows, please allow me to work on tnis.

Hello, I'm Diego a software engineer from Costa Rica and  member of Dojo Coding ⛩ I've created some documentation for projects like KaizenNodeLabs, ByteBeasts and Dipdup, I would love to contribute to this issue
You can see my OnlyDust profile here

Can I work on this, please?

Hi, I'm currently a software enginner student. I am confident of completing this task successfully.
I would do the following to solve the task:

Create a new folder named '.github' and then in this folder I would create a new folder named 'PR_Template'.
Then add a new file named 'pr_template.md'.
Write the template content given (Summary, Changes made, Related Issues, etc).
Test the template and fix it if there are any suggestions.

Hi, I'm Josué Brenes and I'll be working on issue.
I'm Dojo Coding member. ⛩
I estimate this will take 1 day to complete.
Solution Plan
Step 1: Document Structure
I'll start by creating a structured document that includes sections for Summary, Changes Made, Related Issues, Other Information, and Checklist.
Step 2: Detailed Sections

Summary: I'll provide a concise explanation of the purpose of the changes.
Changes Made: I will list specific updates or modifications in bullet points.
Related Issues: I'll link the relevant issue numbers or titles to provide context.
Other Information: I'll add any additional context or dependencies that are relevant.
Checklist: I'll implement a checklist with tasks like adhering to style guidelines, performing a self-review, and running tests.

Step 3: Markdown Format
I'll format each section in GitHub Markdown to ensure clarity and easy reading. This includes adding checkboxes for each item in the checklist.
Step 4: Save as Template
Finally, I'll save the document as a reusable template to maintain consistency across future issues.
Expected Outcome
A structured, reusable template for documenting issue resolutions, with a clear checklist and all necessary information for reviewers.


Have you all tried building with the pretty new net5.0 stuff?

Ask your question here

There's some discussion on the topic here: https://github.com/dapr/dotnet-sdk/issues/429
We haven't rushed out and make the 5.0 SDK a requirement for building the repo yet, but we plan to before 1.0

We are now building and testing with .net 5

We are now building and testing with .net 5


added Khanh's info under section B

see title

misspelled traveling

Well it's British English :)) https://www.teachingtraveling.com/traveling-or-travelling/

misspelled traveling

Well it's British English :)) https://www.teachingtraveling.com/traveling-or-travelling/

ahhh that would make sense lol


pilot tests: vm only validates hitting headless service in local-cluster

On top of #27332, we need this to get a "green" baseline to fix these tests from.
#27343 will likely need to re-break some tests for CI to produce valuable debugging info.
https://prow.istio.io/?pull=27344&job=integ-pilot-multicluster-tests_istio
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[X] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[X] Does not have any changes that may affect Istio users.

/retest

/test integ-pilot-multicluster-tests_istio

/test integ-pilot-multicluster-tests_istio

/test integ-pilot-multicluster-tests_istio

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
3cbae3c53361a898febb6cd33b8a91c2bd681108
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


corrected input parameters

The input parameters: csmfilelink and csmparametersfilelink are incorrect

@pvdwerf : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@pvdwerf - thank you for your comments.  I think the article is fine.  It depends on the value of templateLocation. You must chose 'Linked artificts' for templateLocation.


[SPARK-32767][SQL][3.0] Bucket join should work if spark.sql.shuffle.partitions larger than bucket number

This backports #29612 to branch-3.0. Original PR description:
What changes were proposed in this pull request?
Bucket join should work if spark.sql.shuffle.partitions larger than bucket number, such as:
spark.range(1000).write.bucketBy(432, "id").saveAsTable("t1")
spark.range(1000).write.bucketBy(34, "id").saveAsTable("t2")
sql("set spark.sql.shuffle.partitions=600")
sql("set spark.sql.autoBroadcastJoinThreshold=-1")
sql("select * from t1 join t2 on t1.id = t2.id").explain()

Before this pr:
== Physical Plan ==
*(5) SortMergeJoin [id#26L], [id#27L], Inner
:- *(2) Sort [id#26L ASC NULLS FIRST], false, 0
:  +- Exchange hashpartitioning(id#26L, 600), true
:     +- *(1) Filter isnotnull(id#26L)
:        +- *(1) ColumnarToRow
:           +- FileScan parquet default.t1[id#26L] Batched: true, DataFilters: [isnotnull(id#26L)], Format: Parquet, PartitionFilters: [], PushedFilters: [IsNotNull(id)], ReadSchema: struct<id:bigint>, SelectedBucketsCount: 432 out of 432
+- *(4) Sort [id#27L ASC NULLS FIRST], false, 0
   +- Exchange hashpartitioning(id#27L, 600), true
      +- *(3) Filter isnotnull(id#27L)
         +- *(3) ColumnarToRow
            +- FileScan parquet default.t2[id#27L] Batched: true, DataFilters: [isnotnull(id#27L)], Format: Parquet, PartitionFilters: [], PushedFilters: [IsNotNull(id)], ReadSchema: struct<id:bigint>, SelectedBucketsCount: 34 out of 34

After this pr:
== Physical Plan ==
*(4) SortMergeJoin [id#26L], [id#27L], Inner
:- *(1) Sort [id#26L ASC NULLS FIRST], false, 0
:  +- *(1) Filter isnotnull(id#26L)
:     +- *(1) ColumnarToRow
:        +- FileScan parquet default.t1[id#26L] Batched: true, DataFilters: [isnotnull(id#26L)], Format: Parquet, PartitionFilters: [], PushedFilters: [IsNotNull(id)], ReadSchema: struct<id:bigint>, SelectedBucketsCount: 432 out of 432
+- *(3) Sort [id#27L ASC NULLS FIRST], false, 0
   +- Exchange hashpartitioning(id#27L, 432), true
      +- *(2) Filter isnotnull(id#27L)
         +- *(2) ColumnarToRow
            +- FileScan parquet default.t2[id#27L] Batched: true, DataFilters: [isnotnull(id#27L)], Format: Parquet, PartitionFilters: [], PushedFilters: [IsNotNull(id)], ReadSchema: struct<id:bigint>, SelectedBucketsCount: 34 out of 34

Why are the changes needed?
Spark 2.4 support this.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit test.

Test build #128182 has started for PR 29624 at commit 7273824.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32807/
Test PASSed.

Test build #128182 has finished for PR 29624 at commit 7273824.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128182/
Test FAILed.

retest this please

Test build #128191 has started for PR 29624 at commit 7273824.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32816/
Test PASSed.

Test build #128191 has finished for PR 29624 at commit 7273824.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128191/
Test PASSed.

cc @cloud-fan

Merged to branch-3.0.


Add model docs: time fields are epoch time in seconds

To avoid confusion with milliseconds, which is also a common timestamp unit.

@ok300 this broke CI, because the flutter bindings need updating


Manual Alarm Control Panel with MQTT Support does not work manually

Home Assistant release with the issue: 0.83.3
Last working Home Assistant release (if known): unknown
Operating environment (Hass.io/Docker/Windows/etc.): Virtual Env
Component/platform:
https://www.home-assistant.io/components/alarm_control_panel.manual_mqtt/
Description of problem:
Arming or disarming with NIP code using the component in main screen will fail with:
Invalid code given for armed_away
18:08 components/alarm_control_panel/manual_mqtt.py (WARNING)

Invalid code given for disarmed
18:09 components/alarm_control_panel/manual_mqtt.py (WARNING)

Arming/Disarming from MQTT works fine
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
alarm_control_panel:
  - platform: manual_mqtt
    name: Home Alarm
    state_topic: home/alarm
    command_topic: home/alarm/set
    code: 0406
    pending_time: 30
    delay_time: 20
    trigger_time: 4
    disarmed:
      trigger_time: 0
    armed_home:
      pending_time: 0
      delay_time: 0

try wrapping ur code with quotes:
code: "0406"


SkyBell info API no longer returns serial number or version details

Hi,
I upgraded to iOS 13.2, and since, the Skybell devices are not showing to pair anymore.
Also, when I try to pair one that I never paired before (and is historically showing up, I think) - in any case, part of my Skybell devices but offline for years now), then I get the error:
"Couldn't add -C516
Home couldn't connect to this accessory
Dismiss"
Would you kindly verify the software still works for the latest version of iOS Home app?
I can confirm in the log files from Homebridge, everything looks good, it receives alerts from Skybell (movement events etc) and so on. But the bells are unable to be added to the Home app....
Thank you for your kind support! :)
Diederik

Edit: I removed the Skybells from the 'persist' cache. This made them show up again to pair. But adding the Skybell accessory yields in :
"Couldn't add Name-95B0
Home couldn't connect to this accessory
Dismiss"
Thanks :)

server is :
$ uname -r
18.7.0,
$ node -v
node v12.11.1
$ FFmpeg
ffmpeg version 4.2.1 Copyright (c) 2000-2019 the FFmpeg developers
built with Apple LLVM version 10.0.1 (clang-1<IP_ADDRESS>)
configuration: --prefix=/usr/local/Cellar/ffmpeg/4.2.1 --enable-shared --enable-pthreads --enable-version3 --enable-avresample --cc=clang --host-cflags='-I/Library/Java/JavaVirtualMachines/adoptopenjdk-12.0.1.jdk/Contents/Home/include -I/Library/Java/JavaVirtualMachines/adoptopenjdk-12.0.1.jdk/Contents/Home/include/darwin' --host-ldflags= --enable-ffplay --enable-gnutls --enable-gpl --enable-libaom --enable-libbluray --enable-libmp3lame --enable-libopus --enable-librubberband --enable-libsnappy --enable-libtesseract --enable-libtheora --enable-libvidstab --enable-libvorbis --enable-libvpx --enable-libx264 --enable-libx265 --enable-libxvid --enable-lzma --enable-libfontconfig --enable-libfreetype --enable-frei0r --enable-libass --enable-libopencore-amrnb --enable-libopencore-amrwb --enable-libopenjpeg --enable-librtmp --enable-libspeex --enable-videotoolbox --disable-libjack --disable-indev=jack --enable-libaom --enable-libsoxr
libavutil      56. 31.100 / 56. 31.100
libavcodec     58. 54.100 / 58. 54.100
libavformat    58. 29.100 / 58. 29.100
libavdevice    58.  8.100 / 58.  8.100
libavfilter     7. 57.100 /  7. 57.100
libavresample   4.  0.  0 /  4.  0.  0
libswscale      5.  5.100 /  5.  5.100
libswresample   3.  5.100 /  3.  5.100
libpostproc    55.  5.100 / 55.  5.100
Hyper fast Audio and Video encoder
<EMAIL_ADDRESS>

I get the same "Home couldn't connect to this accessory" error if I try to add a new SkyBell accessory.
Thank you for reporting the problem, especially with a clear explanation of what you tried and details of your platform.
Checking the homebridge logs shows some suspicious entries:
[SkyBell] SkyBell 'Front Door' Wi-Fi status:  Quality=unknown, SSID='undefined', RSSI=undefineddBm, Noise=undefineddBm, SNR=undefineddB, Quality=undefined%, Rate=undefinedMbps)
[SkyBell] updateInfo 'Front Door': serial=undefined, firmware=undefined, hardware=undefined

Additional logging reveals that the GET https://cloud.myskybell.com/api/v3/devices/<Device_ID>/info/ API is now returning:
{ status: { wifiLink: 'unknown' } }

instead of the expected information.
These undefined values are being written to the accessory's characteristics, which HomeKit almost certainly won't like, and probably explains why adding a new accessory fails. (Homebridge implements some checks to prevent this sort of thing but they don't appear to be very effective...)
A quick hack to ignore the result of this API call appears to fix the problem. The only minor downside  is that the accessory's serial number, firmware revision, and hardware revision are not set. If you want to try this then insert a return statement at the start of the updateInfo function on accessory.js line 222:
    updateInfo(info) {
        return;

When I have a bit more time I will investigate further and release a proper fix...

Amazing how swift you replied to my comment, for which I am very grateful to you.
I can report that indeed, the small change above restored the connection to the Skybells.
Impressive how fast you found that :)
Thank you so much for your kind reply!
Have a wonderful Halloween :)
Diederik

It looks like SkyBell have fixed their API. This plugin should now work unmodified.
From my logs the only time that this error existed was between approximately 4:35am and 8:20pm GMT on 31st October 2019. Hence, I do not intend to make any changes unless this problem recurs. Defensively coding all SkyBell API calls to cope with every possible way that they could fail is not worth the effort for something that has only occurred once.

Evidently, couldn't agree more.
Thank you so much for the effort. Happy SkyBell fixed that :)
Diederik

Version 2.1.4 now checks whether the info and settings API results include all expected fields.


update contribution

This fixes #258

Coverage remained the same at 91.85% when pulling cdb35cb5ba3ce5ecdcf833fc03cd8bdb0143891c on update-contribution into 569970a5d2217a6db328175f42e8f639c584f713 on master.


fluidplayer.min.js CDN bug

In CDN link https://cdn.fluidplayer.com/3.0.0/fluidplayer.min.js
(r.style.display="none"),a&&(a.style.display="none"),l&&(l.style.display="none"),d&&(d.style.display="none")}
Hier must be display block to show the skip ad button when VAST video is playing.

moving the ticket to Done since there is no feedback from the user


[MRG] Add docstring to vtki backend

What does this implement/fix?
This PR updates the docstring/license/authors of the vtki backend and fix parameters.

Thanks @GuillaumeFavelier !


CTC Office - Iteration 3 Progress - Green & Red Lines

This adds red and green lines + multiple things support for SystemMap. This is mostly for Caleb G/Track Model to embed SystemMap.jsx into for track viewing purposes and/or modelling the track itself.

actually just gonna send it


"Private key does not match" It worked before (v0.1.5?), Now it does not (v0.3.3).

My private key WAS working with an early version of eos-voter app, now it is not working with the new version of eos-voter. It is the EXACT SAME and CORRECT Private Key (worked with the 1st install of eos-voter). I am not hacked. My funds are safe in the mainnet... for now. As viewed on eosflare.io (detailed below).
Here are the details that got me here...
Mainnet launches
I downloaded greymass eos-voter app a few days later to vote.
Created an account and got an account name, used my one and only private key.
Private key worked- All of my EOS was there and staked in wallet.
When the vote was over, I then unstaked, waited over 3 days.
Logged back into eos-voter app to check and everything was where it should be.
Also checked eosflare.io for my funds and that was looking correct as well, along with some airdrops.
Since I noticed the airdrops, I went to the wallet to add tokens BUT the version I had did not have that feature (to add a Token) so I had to download the latest version...

After installing the new version of eos-voter, it refuses to take my EXACT SAME private key that was used before. I never changed it. I tried connected and disconnected. This has to be a bug or something!?
Here is my public key where you can see my funds. It's all there, all transactions reported perfectly...
https://eosflare.io/account/gu3tcnrxhege
EOS5e7o9VCJYo4hch5KxDA69Mh48J1KZFNUuDfSQ4f5n6DuHc8krh
I still have my ERC20 keys that I used to register my EOS pre-mainnet.
What should I do next? Thank you so much for your time to read this.
-Alex

From the screenshot above - it doesn't look like the private key you are entering matches the private key on record.
I'd recommend trying a secondary tool, like:
https://github.com/eoscafe/eos-key
To validate that your keys actually resolve to:
EOS5e7o9VCJYo4hch5KxDA69Mh48J1KZFNUuDfSQ4f5n6DuHc8krh

@aaroncox Thanks Arron! I'll check it out.

Closing issue, can reopen if the problem surfaces again.


Add security.txt to Design System website

What
Following the guidance in the GDS Way, add a security.txt file to the Design System, telling researchers how to get in contact with us.
Note that it's not recommended we host the security.txt file ourselves, but instead proxy or redirect to the centrally hosted version.
Why
In the Cabinet Office, including GDS, the CDIO Cyber Security team run a vulnerability disclosure programme with HackerOne and NCC Group to triage reports from security researchers.
A security.txt file is a way of telling researchers how to get in contact with us via that programme.
Who needs to know about this
Developers, Cyber security, GaaP Head of Technology?
Done when

[ ] Centrally hosted security policy can be accessed by visiting https://design-system.service.gov.uk/.well-known/security.txt

We've done this for the current DS website, however are keeping this issue open so that it can be looked at again when we've transitioned off PaaS hosting.


Recompiling specific applications breaks them?

Using:
Windows 7 SP1 64-bit
JRE 1.7
Apktool v2.0.0 RC4
APK + framework:
https://mega.co.nz/#!HM4BwYIb!pdOZ5vOX4Hn4Yp-nKiE2WeXFSAkDZ84vtpQ-m7V32ww
Replacing original APK in system/priv-app after...

Only re-sign & zipalign the APK --- Works [proves this isn't a signature-related issue]
Decompile and recompile the APK (original signature) --- ActivityNotFoundException
Decompile and recompile the APK + sign + zipalign --- ActivityNotFoundException

Trying to install as normal APK after...

Decompile and recompile the APK + sign + zipalign --- Package manager shows "Parse error: There was a problem parsing the package."

Logcat:
http://www.iagucool.com/socialphonebook_error.txt
NOTE: The application disappears from the drawer, so to get this exception I used a home-screen icon on Nova Launcher, which doesn't disappear when you uninstall an application. When clicking the icon, a toast notification shows "App isn't installed".

So I haven't tested things yet, just did a preliminary check. I decoded the apk, rebuilt it, then decoded the rebuilt app. I then compared those two folders to check for differences.
A couple of values in public.xml got order changed, but resID stayed the same so that isn't yet. The only other thing missing is two files in META-INF called

SONY-ERICSSON-E-SHARED-SIGNING-LIVE-864F-4.RSA
SONY-ERICSSON-E-SHARED-SIGNING-LIVE-864F-4.SF

Is it possible those files are dependent on the installation? Not entirely sure. I also think the problem could be related to #636 which I almost have fixed. So hold tight, I will do some more testing.

No, those are the original Sony signatures. When you only re-sign the APK, those signatures are replaced, and the APK works perfectly. It's only when you decompile and recompile that the APK fails to even be parsed by Android. Like you, I have recompiled and decompiled again to compare what might have been broken, and haven't found anything of an issue, that's why I'm here XD
I've the feeling that you are right about the #636 issue, hope it gets fixed. If there's anything I could do to help I'd be glad to, even though I know basic Java while pretty good at C#.

Okay I'm 1-2 days away from fixing #636, so let me do that. Then I will test this against that fix.]
It has a <provider> in the manifest that fits the exact description of the mentioned bug. So this could be it.
        <provider android:authorities="@string/fileprovider_authority" android:exported="false" android:grantUriPermissions="true" android:name="android.support.v4.content.FileProvider">
            <meta-data android:name="android.support.FILE_PROVIDER_PATHS" android:resource="@xml/file_paths"/>
        </provider>

Hmm very possible... by the way, decompiling, moding and recompiling SystemUI.apk from the same ROM worked smoothly. So yeah, this must be some kind of referencing problem. (SystemUI doesn't have any "android:authorities" attributes)

Changing android:authorities="@string/fileprovider_authority" to its literal android:authorities="com.sonyericsson.android.socialphonebook.fileprovider" and recompiling seem to make the APK installable again.

Sweet! So it was related to 636. Good thing I have that fixed here: https://github.com/iBotPeaches/Apktool/pull/911
Just needs a bit more testing.

Anywhere to get the fixed apktool.jar? I tried to download the ZIP of the project and build it myself, but it seems the fix isn't implemented there.


Add scripting

Scripting needs to be added so that future games are scripts rather than hard coded classes.

Explored a few possibilities, it's getting away from the core of what ktaf is about and will be hard to implement while maintaining flexibility. DSL in kotlin is a better mid term bet.

Closing.


[Frontend] Navigation bar and menu

The navigation bar has to support large screens and mobile devices.
need to cover scenario of:

user has an account or not logged in
user is first time user

figma: https://www.figma.com/file/BPaDYx9xn4OFejQlUwpF4g?node-id=328:1354#424371062

Design update:
added sub-text under submit url and add tag, please see figma.

Close #45 (completed with PR)


Update the sdk agent to nodejs

Do not merge until this change is coordinated with back end changes.


Declarative command parameter type

The sender type param should be moved into the runs function, allowing for a fresher look of the DSL, as well as different executions for different sender types if wanted.
Currently
("foo" /
    listOf(
        ("fizz" / someArg)<CommandSender> {
            runs { reply(!someArg()) }
        },
        ("bar" / someArg)<CommandSender> {
            runs { reply(!someArg()) }
        }
    )
)<CommandSender> {
    runs { reply(!"Foo") }
}

Proposed Change
("foo" /
    listOf(
        ("fizz" / someArg) {
            runs<Player> { reply(!"&cHi player: &r${someArg()}") }
            runs<CommandSender> { reply(!someArg()) }
        },
        ("bar" / someArg) {
            runs<CommandSender> { reply(!someArg()) }
        }
    )
) {
    runs<CommandSender> { reply(!"Foo") }
}

Implemented in dev branch


insufficient user rights in lolminer?

Hello,
thank you for your work!
My issue:
lolminer starts and works fine without any special arguments, but when I want to change my overclocking settings I get the following error code:
Applying overclock settings...
GPU 0: core clock offset 100 not applied (insufficient user rights).
GPU 0: locked core clock not applied.
GPU 0: locked memory clock not applied.
GPU 0: power limit 170 not applied.
GPU 0: fan percentage 60 not applied.
How can I solve the problem?
I`m running docker as root.
Tahnk you!

One thing you could try is running the container itself in privileged mode (otherwise I think it restricts the containers abilities even when you are running docker itself as root): https://docs.docker.com/engine/reference/run/#runtime-privilege-and-linux-capabilities
Are you running the nvidia or amd container? I might also need to investigate whether we need a root user on the container itself if that doesn't work.

You are my hero!!!
Its working with '--privileged'

Great, I'll close the issue then - reopen if you have any other issues!


[WIP-Code Review Requested] bs-carousel using contextual components

A bs-carousel using Ember contextual components:
(A carousel route has been added to the dummy app on this branch for proof of concept purposes)
{{#bs-carousel
  showIndicators=true
  animate=true
  interval=5
  showIndicators=true
  slideChanged=(action "slideChanged") as |c|
}}

{{#c.slide imgsrc="http://somedomain.com/image1.jpg"}}

CAPTION TITLE 1

Caption 1

{{/c.slide}}

{{#c.slide imgsrc="http://somedomain.com/image2.jpg"}}

CAPTION TITLE TWO

cap 2

{{/c.slide}}

{{#c.slide imgsrc="http://somedomain.com/image3.jpg"}}

CAPTION TITLE III

{{/c.slide}}
{{/bs-carousel}}

Thanks @RyanNerd for your effort!
Unfortunately I see a number of issues here. You tend to do a lot of DOM-related things with jQuery in the component itself rather than in the template. Things like adding classes, but also the indicators. The latter should rather be separate (private) components.
It does not follow the style I would like to see, and will certainly not work in Fastboot (which ember-bootstrap must support).
I am not sure if it makes sense to proceed on this code base, at least for getting this merged into ember-bootstrap. I have an (incomplete) implementation lying around, that still needs to be refactored (make use of contextual components) and finished, but will probably favor doing that. Sorry!

No problem @simonihmig I'll delete this PR. Let me know if I can assist in other ways.
Cheers.


error: Illegal return statement

running lambda-view against https://github.com/patriksimek/vm2/blob/master/lib/sandbox.js#L13
got following error:
[10/2/2016 8:29:05 PM] INFO read file from "~~~~~~~~~/vm2/lib/sandbox.js"...
[10/2/2016 8:29:05 PM] INFO parsing javascript source code and generating html content...
[10/2/2016 8:29:05 PM] ERROR Line 13: Illegal return statement
~

There is a return statement at line 13 in file https://github.com/patriksimek/vm2/blob/master/lib/sandbox.js#L13:
return ((vm, host) => {
    // ...
})

Because return statement is only valid in function body, however there isn't any function body surrounded it.
Actually https://github.com/patriksimek/vm2/blob/master/lib/main.js will load this file as plain text and generate a new string base on it before running:
const sb = fs.readFileSync (`${__dirname}/sandbox.js`, "utf8") ;
vm.runInContext (`(function (vm, host, Contextify, Decontextify, Buffer) { ${sb} \n})`, ...)

So, this is not a bug of lambda-view.
:)

@Jianru-Lin got it working now! thanks for the explanation. 👍


setup resource limits for the manifests -- also consider making them customizable using Kustomize

Resource limits will vary on “many” things.
I’ve added some comments on the YAML manifests as “guidelines”; however, hardcoding resource limits or creating custom configurations do not seem to be a feasible option.
The user should measure the resource utilization on a production-like system, and set their limits accordingly.

Closing this issue.


Scores and probability calcuations

https://github.com/uclaml/SPPO/blob/e524519cc87e9e48cd4da30588f7aa566638df4c/scripts/compute_prob.py#L39
From my understanding of the code, the score list here is the output from the blender.rank(*, return_scores=True) which should output the average relative score of the response in the index being better than other responses. Please correct me if wrong.
For example, given three responses, {y1, y2, y3}, the first element of the scores output by the blender model (s1, s2, 3) is, s1 = P(y1 > y2) + P(y1 > y3), disregarding the constant coefficient and P is general preference score function, not probability. [references from blender code and their paper]
Thus, subtracting two scores, i.e., s1 - s2, is also dependent on the third response y3 as well, which seems a bit different from what is described in the paper.
In summary, I feel it is more appropriate to use the score output from the blender with just two responses (although, I don't think this would make a significant difference in the performance), e.g.,
score = blender.rank([x], [[yj, yi]], return_scores=True)[0, 0]
prb[i][j] = 1 / (1 + np.exp(score))

(sorry for the badly coded example)

I don't understand the calcs yet, I don't know why, during my tests, the calculated probabilities are all coming as 0.5. Is this right?

I don't understand the calcs yet, I don't know why, during my tests, the calculated probabilities are all coming as 0.5. Is this right?

Sorry. It was my bad.

I have the same problem as @namdw.
It seems that LLM Blender uses its pair-wise RM to create the relative score table for all pairs (i, j) based on the logits of choosing "i" and "j" as the output. Since SPPO's code sets the "return_scores" param as True, LLM Blender will continue to do the Agg using "max_logits" strategy by default, which gives a single score for each candidate indicating the average relative score of that candidate being better than other responses.
So the returned score list of "rank" is related to the prompt, the chosen candidate, and all the candidates in the list, instead of the prompt and a pair of candidates which is presented as $s(y, y'; x)$ in the paper.

I think the code from @namdw goes the right way, but to be aligned with the paper, should we also put $e^{score(i,j)}$ instead of $1$ on the top when calculating $prb(i, j)$.

Hi @namdw @xukp20
I'm sorry for not getting back to you sooner. You are right. The correct implementation should be to calculate the win-rate matrix first and then take the mean over the row. The current implementation is taking the mean over the score matrix (the logistic of it is the win rate) and then feeding that into a BT model.
We will fix this and re-run experiments asap. The performance difference is expected to be negligible as the numerical difference in the win rate between these two methods is expected to be rather small.


Opacity fix

Relands https://github.com/flutter/flutter/pull/89264
This will break goldens internally
New test added to make sure we do not incorrectly push an Offset or Opacity layer to the engine when there is no child.

Correct


All-green images in the segmentation class folder when dumping annotations

I got all-green images in the SegmentationClass folder while correct colors for background and instances in SegmentationObject folder. When I check the labelmap.txt, I found it was:
label:color_rgb:parts:actions
leaf:48,112,32::
background:0,0,0::
While it was supposed to be following to get the correct masks in the SegmentationClass folder:
label:color_rgb:parts:actions
background:0,0,0::
leaf:48,112,32::
Could you please tell me how to make the SegmentationClass and labelmap.txt work?

Do you have background class in the task?

No, I don't have a separate

Do you have background class in the task?

No. I have only one class, leaf.

I think I figured it out. I set one of the instances as foreground manually and then all masks worked. It seems that it will regard the annotated instances as background by default ...

Should be fixed already.


Rename HPX_MPI_WITH_FUTURES option

Especially after #4689, but also otherwise, the HPX_MPI_WITH_FUTURES option doesn't really fit other naming schemes. It's written as if it's an option for the (old) mpi module, but what it does is enable the whole module.
I would rename it as a "top-level" option: HPX_WITH_MPI_FUTURES or HPX_WITH_ASYNC_MPI to decouple it a bit from the module itself (just like the CUDA options). If someone likes to have it be tied to whether or not the module itself is enabled I would go for maybe HPX_WITH_MODULE_ASYNC_MPI, but I don't like this since we wouldn't have it for every module.

I have to admit that initially I asked for this variable to be named as if it was a module-specific configuration option. I start to like HPX_WITH_ASYNC_MPI more than HPX_ASYNC_MPI_WITH_FUTURES.

I will be renaming the mpi futures module to async_mpi in #4385 so I shall take care of this in that PR.
I prefer HPX_WITH_ASYNC_MPI

Please ignore that comment, the module is already renamed, I'm rebasing onto it and fixing all the other cmake problems, but I will take care of this cmake option too

Should we go with HPX_WITH_ASYNC_MPI? @biddisco will you be changing this in #4663?

This has been fixed by #4663.


Feature request-Crop Yeild Prediction

For a Crop Yield Prediction feature in ML Nexus, I propose to create an end-to-end solution that predicts agricultural crop yields based on historical and environmental data. The pipeline includes data preprocessing (handling missing values, encoding categorical variables, and outlier removal), feature engineering, and training models like Linear Regression, Decision Trees, or Random Forest for accurate yield predictions. The feature would also support dataset uploads for customized, region-specific predictions, with evaluation metrics (e.g., Mean Squared Error) built-in for model assessment. This tool will enhance agricultural planning by offering reliable, data-driven insights directly within ML Nexus.
please assign this to me.

It will be completed at the end of the day.