Default map provider doesn't show nature reserves and custom map provider default not remembered

I thought this plugin looked interesting to use for recording notes on nature reserve and national parks that I have visited. However, unlike openstreetmap.org the map view in this plugin is incredibly sparse in what it shows. Things that are missing include:

Borders of national parks and nature reserves (at least in Sweden, which is what I care about)
Hiking trails
Minor roads, tracks, etc.

This makes the map view largely useless to me.

I figured out how to add another tile source (using openstreetmap.org itself), but I cannot figure out how to make that the default when opening the map view. I don't see an option for that.

I eventually found where to change the default. It wasn't very obvious, you need to expand "Presets" in the map view and save a new default. Hopefully this is useful to someone else in the future.

Unfortunately it doesn't seem to remember the default map provider across obsidian restarts, so I'm reopening this.

To make sure I understand, you do the following:

Set your view with a custom map provider (chosen in the View dropdown),
Click "Save as Default"

And then when you close & reopen Map View, or restart Obsidian, it shows you the default again?
When you reopen Map View and the original default is shown, does it say "Default" in the preset dropdown?
If you manage to capture a video of the process it may help me recreate it.

You are incidentally using a configuration quite similar to mine.
One thing that's unclear from the video, is whether the 'Default' preset is actually saved when you click "save as default". Would you mind after clicking it, to move the map a little so the preset name would be cleared, and then choose 'Default' again from the dropdown, and see what happens?
Also, I'm happy to know that you're a very technical user, because now I can ask you for the most important detail. Would you mind checking the plugin's data file VAULT_PATH/.obsidian/plugins/obsidian-map-view/data.json and copy the value of the defaultState key?

One thing that's unclear from the video, is whether the 'Default' preset is actually saved when you click "save as default". Would you mind after clicking it, to move the map a little so the preset name would be cleared, and then choose 'Default' again from the dropdown, and see what happens?

The preset is cleared. When I select default, it moves back but always chooses CartoDB. I tried saving a separate preset (named OSM). There the choice of tile provider seems to stick (I selected "Include chosen map source" in the save dialog box). However I don't get that option for default, nor can I set to use my custom preset as default from what I can tell.

I would appreciate if you could check plugin's data file VAULT_PATH/.obsidian/plugins/obsidian-map-view/data.json and copy the value of the defaultState key. It's likely that this will provide all I need to understand the issue.

data.json.txt is the data file. One immediate strange thing I notice is that there still seem to be references to the default #trip, #trip-water etc in there. The only rule I thought I had (and I can see in the settings) is for #natur.

Thank you for this. That's a much more serious bug than the simple symptom may suggest, and is very important to fix ASAP since it messes up users' settings. Will give it the highest priority.

So indeed, there was a major issue with the way presets are handled and saved, and it required a thorough fix.
I made the required changes in the just-released version 4.0.0 and tested them to the best of my ability, hoping it didn't break anything unexpected.


doc: contribute guidelines: Explain when not to use clang-format

Is your enhancement proposal related to a problem? Please describe.
Running clang-format on a file with old code that doesn't follow the current coding style makes a substantial code change unreviewable, unless clang-format is performed beforehand and put in a separate commit that can be skipped faster by
the reviewers. The change (new code) can now easily be reformatted by clang-format too before committing.
With https://github.com/zephyrproject-rtos/zephyr/pull/73360 I experienced this is actually not desired.
Describe the solution you'd like
Update https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format to explain why reformatting old code before adding the changes is not desired and add what to do in this situation. The new code should adhere to the current coding style, even if it deviates from the style used in the c file?
Perhaps some small examples can be added.

The new code should adhere to the current coding style, even if it deviates from the style used in the c file?

FYI, I'm not sure that .clang-format actually defines the project coding style. From https://github.com/zephyrproject-rtos/zephyr/issues/52712#issuecomment-1333955406:

clang-format does not define project coding style, it is up to you to post-fix the code formatted by clang-format

I'd love to have some guidance/examples about how/when to use clang-format with Zephyr given that it conflicts with the formatting done by checkpatch.

This looks related to the issue: https://github.com/zephyrproject-rtos/zephyr/pull/75403#issuecomment-2527985758


SCons: Optimize generation of help text for speed

The SConscripts are skipped for subdirectories which don't provide any options nor generate help text, saving the time it takes to generate the text with scons --help.
Modules are not skipped as some of them may append to help text generation while parsing the scripts (as seen in mono module #37112). This also applies to any custom module which is not part of Godot.
Platform-specific options are not skipped because they are not collected via SConscript calls (see detect.get_opts() method calls for each platform).
This is described as a typical optimization use case in the SCons user guide for the GetOption function.
Perfomance gains
Without this PR: ~8 seconds.
With this PR: ~6 seconds.
So this saves 1-2 seconds on my machine for scons --help to print. If we skip modules, the gains are even more noticeable (additional 2 second gains). But in order to remain correctness, modules have to be parsed anyway, so we can't really optimize it here, and we also need to take into account that custom modules can define options in their SCsubs too.
Principles
Correctness and Performance are part of SCons Principles which state that:

Given that the build is correct, we try to make SCons build software as quickly as possible. In particular, wherever we may have needed to slow down the default SCons behavior to guarantee a correct build, we also try to make it easy to speed up SCons through optimization options that let you trade off guaranteed correctness in all end cases for a speedier build in the usual cases.

So, if you feel like the correctness is more important, I don't really mind. The risk is that someone refactors the build system and the options get ignored (like if we move platform specific detect.get_opts() methods to each platform's SCsub or similar).

So, if you feel like the correctness is more important, I don't really mind. The risk is that someone refactors the build system and the options get ignored (like if we move platform specific detect.get_opts() methods to each platform's SCsub or similar).

Indeed, I'm not sure it's worth it to gain 1-2 s on a command that is rarely used (if it was shaving off 2 seconds of build times, I'd definitely be up for it, but how often to you need to print the help and how much do 2 seconds matter in that case?).
And I'm also not sure that only modules register help text, what about platform? e.g. platform/linuxbsd/SCsub registers various build options like udev or pulseaudio.

And I'm also not sure that only modules register help text, what about platform? e.g. platform/linuxbsd/SCsub registers various build options like udev or pulseaudio.

Those are actually collected via detect.py which is handled outside of SCsub stuff, so they are not ignored currently.

but how often to you need to print the help

For new contributors I think that's important, with 8-10 seconds just to print the help text I'd imagine people could likely start thinking that their terminal is frozen. :)
I also have a bunch of other C++ custom modules which append their own help text (which are not typically known to people using those modules). Just like I've figured the way to know about mono specific options (but those are documented too). Parsing all those external modules takes time too.
To your discretion. :)

For new contributors I think that's important, with 8-10 seconds just to print the help text I'd imagine people could likely start thinking that their terminal is frozen. :)

I can't reproduce that though:
$ time scons --help
real    0m1,964s
user    0m1,779s
sys     0m0,166s

And this is on a laptop (arguably a relatively fast one with an i7, but still).
If someone has a slow CPU for which generating the help output takes 8 seconds, reducing it to 6 is nice but won't do much for the feeling that it's slow.

I'm on Windows so maybe that's a problem. 😛
I have i7 CPU as well.
Perhaps it has something to do with the way it detects available platforms. Or the slowness of VSCode integrated terminal. :eyes:

I'm on Windows so maybe that's a problem.

Right, Python File I/O on Windows is a horror show, so opening all those SCsubs can likely take a few seconds indeed.

Well I'm OK with the change for the sake of Windows users plagued with the worst I/O of all OSes ;)
But then instead of hacking it here, I'd prefer to avoid the whole logic of this code block and of most of the SConstruct to simply parse SConstruct and modules/SCsub with querying help.
Then instead of gaining 1 s you might gain 5 and the code should be clearer.

I don't think I correctly understand what you suggest.

modules/SCsub must be parsed in either case, either for build or help text.
We must retain build order.

Do you suggest that GetOption("help") shall be handled in their own SCsub? But then it has to read the file anyway. I don't see a clear way.

Upon further thought, I don't think this is worth it. If any changes are needed it simply suggests that it's not that critical and micro-optimizations like that are not worth the added complexity, so closing. The changes can be made in successive PR if there's really a need for it, and I'd like to avoid resolving merge conflicts in my other PRs. Thanks for shedding some insights on this though.


Improve (or remove) "mobile clients" VPN page

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Is your feature request related to a problem? Please describe.
Per comments on #6602 a feature request to clarify the use of the "mobile clients" page. Particular pain point is RADIUS servers not appearing on this page if there are any legacy connections using RADIUS.
Describe the solution you like
I think the best solution would be eliminating this page altogether for new connections, and moving into a tab in the legacy connections section. For new connections, wouldn't it make more sense to have these settings in a place related to how they're used?

Authentication servers: should be configured in local/remote auth, based on authentication selected
IP address pool and DNS servers: are already given in the child SA configuration
Network list, split DNS, and WINS servers: are all related and could all be configured in the pool as well
PFS group: already configured in child SA (it never made sense to me why this was a separate setting?)

There may be back-end considerations for isolating some of these settings that I'm not aware of, but it does seem like there are obvious areas of overlap.
Describe alternatives you considered
If this is too big a change to consider at the moment, at least a warning should be provided if a user tries selecting RADIUS authentication on both new and legacy connections.

This page will probably live as long as the legacy ipsec is available. Maybe we can annotate it as legacy in the menu as well?

@miken32 most of the settings are used in both, but the radius selection needs some work. I'll take a look.

The. "mobile" page is actually the generic strongswan.conf payload (charon settings)
https://github.com/opnsense/core/blob/3ca3bc5c8a5076586d8a2fc0ce991859678683ac/src/etc/inc/plugins.inc.d/ipsec.inc#L978-L1059
see also https://docs.strongswan.org/docs/5.9/config/strongswanConf.html
This https://github.com/opnsense/core/commit/b76c13be6040633a9d3b35058f0d655aac14170d should help making the a little bit twisted radius configuration more obvious (you can only define a single set of servers).


arguments incompatible with signature in test/index.js

test does not makes sense as in line https://github.com/arnaudbenard/redux-mock-store/blob/82aba88c2e9d74af49d0fff8b3aea55db6070e4a/test/index.js#L100
mockStore accepts just one argument so expectedActions wont't be modified anyway

Thats a good spot! Thats a lot, we'll fix it!

@ciekawy You are looking at the tests of the old redux-mock-store where it used to accept an array of actions.

yea, I just noticed the same call in my project and was investigating the source of it :)


Parallelize coverage workflow

Parallelize coverage Workflow
Checklist

[ ] Linked to Github Issue
[ ] Unit tests added
[ ] Integration tests added.
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.18%. Comparing base (8f3cc78) to head (f60957f).

Additional details and impacted files
@@                   Coverage Diff                    @@
##           cairo-lang2.7.0-rc.3     #765      +/-   ##
========================================================
- Coverage                 91.79%   88.18%   -3.62%
========================================================
  Files                       118      118
  Lines                     34156    34156
========================================================
- Hits                      31355    30120    -1235
- Misses                     2801     4036    +1235

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


i18n(fr): update errors references

Description (required)

Update Actions errors (see #9236)
Add deprecated notice on some errors (see #9157)

Related issues & labels (optional)

Suggested label: i18n

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

fr
reference/error-reference.mdx
Localization changed, will be marked as complete.

fr
reference/errors/action-called-from-server-error.mdx
Localization changed, will be marked as complete.

fr
reference/errors/action-not-found-error.mdx
Localization added, will be marked as complete.

fr
reference/errors/action-query-string-invalid-error.mdx
Localization changed, will be marked as complete.

fr
reference/errors/actions-returned-invalid-data-error.mdx
Localization changed, will be marked as complete.

fr
reference/errors/env-invalid-variable.mdx
Localization changed, will be marked as complete.

fr
reference/errors/invalid-rewrite404.mdx
Localization changed, will be marked as complete.

fr
reference/errors/locals-not-serializable.mdx
Localization changed, will be marked as complete.

fr
reference/errors/markdown-content-schema-validation-error.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


TypeScript type definition file

There is any plan to support TypeScript type definition file for typescript in the future or if any one already created support file.

We personally do not use TypeScript but there are definition files available in the DefinitelyTyped
repository: https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/tus-js-client

Thank you

You're welcome :)

Thanks for letting us know, I opened a pull request to add the missing definitions: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/30384

@nbonavia The definitions in DefinitelyTyped have been updated.

@Acconut hello, are you planning to update the typings for v2, or should I resort to 1.8 for now?

@freiondrej I added the definitions directly to tus-js-client in https://github.com/tus/tus-js-client/commit/3774a74b187ac1764ad83ec2bedc1f0fd23d68aa. Please install the latest version of tus-js-client directly from github and see if they work before I do a real release.

@Acconut thank you. Unfortunately when trying this, I'm getting Can't resolve 'tus-js-client' (I'm using webpack). It surely can be something on my end. But for now I'll stick to the 1.8.0 version which ran just fine for me.

Version 2.1.0 has been released with the definition file included. Maybe you want to give it another try. I would recommend using the latest version since the 1.x branch won't receive updates in the future.

@Acconut I just installed 2.1.1 and it seems to be working perfectly. Thank you very much!

Can anyone post minimalistic example of using tus-js-client with TypeScript? I am trying to use "tus-js-client": "^2.2.0"
I am getting file from event
const file = e.currentTarget.files && e.currentTarget.files[0]
First I got this error Argument of type 'File | null' is not assignable to parameter of type 'File | Blob | Pick<ReadableStreamDefaultReader, "read">'. In the line below
var upload = new tus.Upload(file, {
to fix it I used
var upload = new tus.Upload(file as File, {
and now I am having Object is possibly 'null'.ts(2531)  in
          metadata: {               filename: file.name,               filetype: file.type           },
I am new to TypeScript, but looks like something is missing in variable definitions. So if somebody can show me the way of implementing example from https://www.npmjs.com/package/tus-js-client that would be super awesome!

@brootle You are on the right way. The file variable has the type File | null but tus-js-client does not accept null values in the constructor. So that's not a missing definition on our end.
I would recommend you to add a check before calling tus-js-client to make sure that file is not null and you only pass File instances to tus-js-client.

@Acconut you are absolutely right, adding file !== null check before calling new tus.Upload(...) fixes all TypeScript errors and example from npm now runs as it is without any modifications


Calculate intersection weights of line and grid

This feature should implement the grid intersection code from pycomlink that calculates the weights from CML paths over a radar grid. It also should return the radar-along-CML time series calculated from the intersection weights.
There should be a function to get the grid intersection weights, one to calculate the radar_along_CML time series as well as simple options/functions to save or load intersection weights.
It could be discussed if similar code doing the same with point and grid e.g. from wradlib should be implemented along with this feature.

It could be discussed if similar code doing the same with point and grid e.g. from wradlib should be implemented along with this feature.

I think this should come later. For sensor-merging code we would need on common approach (API) to get grid values at the sensors location. But I would implement that as a higher level function that calls the actual grid intersection code (or the code that gets grid values at or close to points).

There was (maybe) a problem when I did a quick implementation (using the code from pycomlink) in the ragali_prototpy and used it in this notebook.
See this code snippet with my comment.
# TODO: Needs more thought...
# Either there is an error in my code or it has to do with the fact
# that I have to transpose the grids here when using grid_point_location='lower_left'
# because otherwise I get an error "y values must be ascending along axis 0".
#
# For many CMLs the grid intersections are empty, even though the grid lon-lat
# and the CML lon-lat seem to fit when viewed on a map...

intersect_weights = rgl.grid_intersection.calc_sparse_intersect_weights_for_several_cmls(
    ds_cmls=ds_cmls,
    x_grid=ds_radar.lon.values,
    y_grid=ds_radar.lat.values,
    #grid_point_location='lower_left',
    grid_point_location='center',
)

# Use grid intersection weights to calculate radar-CML path-averages
radar_along_cml = rgl.grid_intersection.get_grid_time_series_at_intersections(
    #grid_data=ds_radar.rainfall.transpose('time', 'x', 'y').values, # only needed if we have to transpose in the function above
    grid_data=ds_radar.rainfall.values,
    intersect_weights=intersect_weights,
)

We should check again the logic in the existing code in pycomlink and make sure that the reason for the issue that I found is that the grid coordinate values are ascending or descending. If ascending vs descending is the problem we should raise an error or automatically transpose or flip. Since there are tests for the grid intersection code, we could also try to make the code more general. But that might be harder than just checking the input grid.

The error that is raised when using grid_point_location='lower_left' is actually an error the results from checking that values are ascending:
    280 if (np.diff(grid[:, :, 1], axis=0) < 0).any():
--> 281     raise ValueError("y values must be ascending along axis 0")
    283 # Upper right
    284 ur_grid = np.zeros_like(grid)

ValueError: y values must be ascending along axis 0

It is not yet clear how to deal with descending coordinate values.


[BAEL-4173] Set JWT token with Spring Boot & Swagger UI

There a few things to adjust. Also, if it's possible for this code to coexist in the existing spring-boot-swagger module, then we should move it there instead of creating a new module.

Hello Kevin, not sure its possible to coexist with the existing module since I will change some of the configurations and its not possible to have two swagger configurations in the same project.


flatMap/chain

Any interest in adding some like flatMap/chain?
// in terms of reduce
const flatMap = (fn, xs) => xs.reduce((acc, x) => acc.concat(fn(x)), []);
// in terms of map
const flatMap = (fn, xs) => [].concat.apply([], xs.map(fn));

didnt see it on this list https://github.com/1-liners/1-liners/issues/107

Sure, would be cool! Are you interested in making a PR?

sounds good, do you have a name preference? and which would you prefer in terms of reduce or map ?

flatMap sgtm and I would prefer map
Any other opinions @1-liners/owners?

:+1:

all set let me know #139


Full Page Redactions on multiple pages shows the section name twice on the redaction box

Describe the bug in current situation
Whenever full Page redactions are applied on multiple pages, some pages shows the section name twice on the redaction box. But it will go away after refreshing the page.
Link bug to the User Story
Impact of this bug
Describe the impact, i.e. what the impact is, and number of users impacted.
Chance of Occurring (high/medium/low/very low)
High
Pre Conditions: which Env, any pre-requesites or assumptions to execute steps?
Steps to Reproduce
Steps to reproduce the behavior:

Go to the redaction app
Click on the Redact pages icon on the top.
Specify multiple page numbers for eg: 3-6 and choose the section.
See error

Actual/ observed behaviour/ results
You can see the section name showing twice on some of the pages(not all).
Expected behaviour
The section name should be shown just once. (You can be seen expected behavior when u refresh)
Screenshots/ Visual Reference/ Source
If applicable, add screenshots to help explain your problem. You an use screengrab.
Private Zenhub Image
Private Zenhub Image

Fixed as part of my task : #4385.

Working as expected on test-marshal. So closing


http2 push headers - should be a function

What problem does this feature solve?
Now there is no configuration to decide what resources we want to push to the client.
So if it is returning client we are pushing all the resources even if he has it.
If the http2: push will be a function we could decide if we want to push and what.
It will be huge client optimalization.
Now we have something similar in shouldPrefetch and shouldPreload
What does the proposed changes look like?
Besides file and type we need request to check for cookies or some other headers and response to set some output.
This is just example how we could use new implementation.
(isReturningVisitor is some custom logic that check for client cookies)
render: {
    http2: (req, res, file, type) => {
       return isReturningVisitor(req) === false && type === 'script'
    }
  },

Than for example nginx can read the push headers and push the resources.

This feature request is available on Nuxt community (#c7870)

Nuxt can do even better out of the box.
New visitor

Add push headers to all resources.
Set Cookie with resources hashes.

Returning Visitor

Read cookie
Compare the hashes from cookie.
Add push headers only to resources that changes.
Update to cookie.

Of course it could be great if developer could overwrite default behavior or disable it.

This would also allow pushing assets based on user agent 👍🏻

@awronski Hey! How is it going? :relaxed:

@manniL Still experimenting, need more time. Will give you know.

Sounds good! Please make sure to not introduce breaking changes for it (even though it's not documented 🙈)

@manniL It is not possible, because shouldPush accept only single file and I need to pass req, res and the array of all push assets.
The present signature is:
shouldPush(fileWithoutQuery, asType)
I need something like this:
shouldPush(req, res, publicPath, preloadFiles)
I can introduce one more option to http2 to make it backward compatible.
What do you suggest?

@awronski Thank you for the good idea.
I want to know a bit further what's the reason for using a batched shouldPush instead of current one ?
If it's really necessary, I suggest you add a new method pushAssets which is more semantic and won't break the compatibility and may add a deprecated log info in shouldPush.

Using the existing shouldPush function wouldn't allow for much flexibility. Passing all assets to a http2.push function would be great and it avoids breaking changes.

@tillkruss Agree

Using the existing shouldPush function wouldn't allow for much flexibility. Passing all assets to a http2.push function would be great and it avoids breaking changes.

@clarkdo Now you can only filter the assets that you want to push but you don't know the user state.
If we add a third parameter, which is a function pushAssets(req, res, publicPath, preloadFiles) we can conditionally push assets to the user (based on the cookie value, user type etc)
If the user has already some assets why to push them again. It will make the app faster.
If you agree, I will push the changes. I will leave the shouldPush as it is and and new option and document it.


[Feature Request] Support avif as output format

Any news on this @SoraKumo001 ?

avif support for cloudflare file size extended to 3MB


Replace issue id by issue number in the doc

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

No fast optimizing though

Codecov Report

Merging #114 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #114   +/-   ##
=======================================
  Coverage   87.79%   87.79%
=======================================
  Files          36       36
  Lines         516      516
  Branches        3        3
=======================================
  Hits          453      453
  Misses         63       63

Impacted Files
Coverage Δ

...4s/shared/src/main/scala/github4s/api/Issues.scala
70% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3266d96...b5e0ef6. Read the comment docs.


Crash on unplugging tablet

Hi,
I own a Huion 420 tablet. Occasionally, removing it causes sway to segfault.
While debugging an XWayland crash on sway that seems to be related to same tablet as well, the maintainer there also reproduced this issue (see for backtrace). That thread may contain relevant information to this ticket, like evemu-describe output of all the tablet event devices.
Seemingly related, I can trigger a consistent crash in Firefox by plugging in the tablet, hovering over an open Firefox-on-Wayland window with the pen, then while Firefox continues to have focus, unplugging the tablet. I haven't dug into this particular problem yet, but I can probably get some traces if they'd be helpful and relevant.

A trace of Firefox Developer Edition (75, MOZ_ENABLE_WAYLAND=1) shows:
Thread 1 (Thread 0x7ffff7a9a780 (LWP 5683)):
#0  0x00007ffff56329f1 in g_list_remove () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#1  0x00007ffff65a6df3 in  () at /lib/x86_64-linux-gnu/libgdk-3.so.0
#2  0x00007ffff4ae88ee in ffi_call_unix64 () at /lib/x86_64-linux-gnu/libffi.so.6
#3  0x00007ffff4ae82bf in ffi_call () at /lib/x86_64-linux-gnu/libffi.so.6
#4  0x00007ffff5bb528d in  () at /lib/x86_64-linux-gnu/libwayland-client.so.0
#5  0x00007ffff5bb1ac9 in  () at /lib/x86_64-linux-gnu/libwayland-client.so.0
#6  0x00007ffff5bb2f94 in wl_display_dispatch_queue_pending () at /lib/x86_64-linux-gnu/libwayland-client.so.0
#7  0x00007ffff65b1884 in  () at /lib/x86_64-linux-gnu/libgdk-3.so.0
#8  0x00007ffff6551940 in gdk_display_get_event () at /lib/x86_64-linux-gnu/libgdk-3.so.0
#9  0x00007ffff65b15a2 in  () at /lib/x86_64-linux-gnu/libgdk-3.so.0
#10 0x00007ffff5636f2e in g_main_context_dispatch () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#11 0x00007ffff56371c8 in  () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#12 0x00007ffff563725c in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#13 0x00007fffefd0646e in  () at /opt/firefox/libxul.so
#14 0x00007fffefd065dd in  () at /opt/firefox/libxul.so
#15 0x00007ffff0196ce2 in  () at /opt/firefox/libxul.so
#16 0x00007fffefbce3a6 in  () at /opt/firefox/libxul.so
#17 0x00007fffefbf8155 in  () at /opt/firefox/libxul.so
#18 0x00007ffff039225f in  () at /opt/firefox/libxul.so
#19 0x00007ffff109bd34 in  () at /opt/firefox/libxul.so
#20 0x00007fffef0e53f3 in  () at /opt/firefox/libxul.so
#21 0x00007ffff168e1fe in  () at /opt/firefox/libxul.so
#22 0x00007ffff169091c in  () at /opt/firefox/libxul.so
#23 0x00007fffef1632af in  () at /opt/firefox/libxul.so
#24 0x00005555555b87a5 in _start ()

Not too much information since I don't have debug symbols, but the place where things break down seems to be libgdk-3.


How to install a new magento 1.9.3 on a fresh php7 with this

I've tried with downloader but got errors like
Package community/Interface_Frontend_Rwd_Default <IP_ADDRESS>: requires PHP version >= 5.2.0 and <= 6.0.0 current is: 7.0.8-0ubuntu<IP_ADDRESS>
Thanks in advance

Manually, without downloader, goes something like this:

download whole Magento 1.9.3 from Magento download Archive, unpack to proper server folder
download this extension, unpack, copy/paste to Magento root folder (merge with Magento)
run Magento through browser, installer should open and work

With downloader, since it's fetching packages from Magento, I think the only way would be to patch downloader itself, to remove version check, but this isn't covered with this module.
Hope it helps ..

Thx
Le 28 nov. 2016 14:00, "Ivan Weiler"<EMAIL_ADDRESS>a écrit :

Manually, without downloader, goes something like this:

download whole Magento 1.9.3 from Magento download Archive, unpack
to proper server folder
download this extension, unpack, copy/paste to Magento root folder
(merge with Magento)
run Magento through browser, installer should open and work

With downloader, since it's fetching packages from Magento, I think the
only way would be to patch downloader itself, to remove version check, but
this isn't covered with this module.
Hope it helps ..
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Inchoo/Inchoo_PHP7/issues/92#issuecomment-263265465,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAnw3Fby9P5Q3UCeZSA2nAFmjCQsq47Kks5rCtCFgaJpZM4K74TO
.


Revision datasets.kitti_dataset.KittiDataset

What does this PR do?

Related to #839

Update docstring for KittiDataset
Remove void_labels in argument and set it related to valid_labels
Add test for KittiDataset with random image

Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes?
[x] Did you write any new necessary tests? [not needed for typos/docs]
[x] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

[ ] Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Hi, I've reviewed KittiDataset and added test for it, but I'm not really sure about the test. I wanted to test KittiDataset with original KITTI segmentation dataset, but it should be downloaded manually with signin. At first, I tried to download dataset manually in the data_dir and set to skip<EMAIL_ADDRESS>if downloaded KITTI dataset is not found in data_dir, but it seems not a proper way to test. So I added code to create randomly generated image and mask with same directory, name, and classes as the original dataset, and tested KittiDataset with this image. Is it ok to do so, or is there any proper way to test KittiDataset without manual downloading? Thanks 😀

That's a tricky one, but I'd say that the way you tested is just fine - KITTI dataset is quite old, so it has very fixed structure, so generating random things inside that well-known structure is just fine.


In progress: Add start to Coursera stuffs

Purpose/implementation Section
What changes are being implemented in this Pull Request?
This isn't quite working yet. It doesn't like the footer for some reason and the image file paths aren't what it wants either. Presumably it doesn't like the leanbuild::set_knitr_image_path() and I will need to adjust
Edit: Nope it wasn't this, it was that the css file I was referencing had file paths that were not relevant because the coursera renders have no TOC.
Describe your approach:
I borrowed a script I wrote for https://github.com/AlexsLemonade/refinebio-examples/blob/staging/scripts/render-notebooks.R
But adapted it to our needs in this repo.
The goal of the two scripts here is to output rendered htmls docs/coursera that can be linked from the github pages in Coursera.
Usage:
All that needs to happen is this command:
Rscript --vanilla scripts/render_all_coursera.R

This is related to #123

Only problem left to resolve (that I know of) is that the darn videos aren't rendering properly.

coursera.zip
Here's a preview of the output.

Not bad, seems like a good start. :)  I wonder why the videos aren't rendering...

if it helps we could have these rendered in the leanpub repo - to avoid messing up the bookdown version, although I see that it seems to be ok

if it helps we could have these rendered in the leanpub repo - to avoid messing up the bookdown version, although I see that it seems to be ok

I thought about that but I think it's easier to do it here since.

if it helps we could have these rendered in the leanpub repo - to avoid messing up the bookdown version, although I see that it seems to be ok

I thought about that but I think it's easier to do it here since we already set up GitHub pages.

I think I need to add a youtube conversion step so the url is the youtube "watch" url just like we do in leanbuild.

I think I need to add a youtube conversion step so the url is the youtube "watch" url just like we do in leanbuild.

I might just functionalize this step in leanbuild and then use it here.

So the watch links make it take forever to load. As in I clicked on the html locally and it still is trying to load. 😱  5 minutes later.

So I think the solution here is figure out what renders reliably in an html link and just have the converting function do that.

So in the html output files from Bookdown (which youtube works) vs the Coursera script one (which youtube doesn't) they look very different.
Whereas Coursera script output has something super long and jumbly:

Bookdown render has something that is more intelligible:
<iframe src="https://www.youtube.com/embed/VOCYL-FNbr0" width="672" height="400px">
</iframe>

Just have to figure out what quirky thing is happening to make the coursera script output so jumbly.

I've tried working with the bookdown render voodoo to just make a duplicate bookdown that doesn't have a TOC but they make it very hard to not have a TOC:

There are a few arguments of html_document() that have been hard-coded in gitbook() and you cannot change them: toc = TRUE (there must be a table of contents),
From: https://bookdown.org/yihui/bookdown/html.html

And I don't know enough CSS and Java to have it edit the end product myself. Seems like it should be simple but it is not so far.

This is as good as it will get until #174 is resolved but I've spent so much time on this that the bandaid fix from #175 will have to do for now.


Add SieveToFindAllPrimesTillN.cpp

Added a Number Theory folder containing a function to find all primes numbers till n

great please give this repo a star and follow me for follow back😊


finding neighbor countries using region or geo location

not sure if its possible or not but I think it would be really nice to have something like this:
let country = keshvar::find_by_code(98);

let neighbors: Vec<Country> =  keshvar::near_countries(country);

I think it's doable if we stick with coutries' geo information.


Thoughts about lib

Hey, pals, thanks for lib!
I've been using your project to work with GTM and I ran into bugs like twice mounting or cannot push to undefined (https://github.com/elgorditosalsero/react-gtm-hook/issues/16 https://github.com/elgorditosalsero/react-gtm-hook/issues/13)
So I was thinking, maybe there is a way to make it better.
Firstly, because the init function is called twice sometimes it causes some troubles, so what if we pass the initial state directly into the GTM Provider Params?
    <GTMProvider state={gtmParams}>
        <SomeComponentHere />
    </GTMProvider>

And secondly, why not separate sendGTMData (dispatchGTMEvent) hook and UseGTMHookProvider (GTMProvider)? So we would just initialize it only one time and after that, we would be able to set the data directly through the dispatchGTMEvent hook?
/**
 * Contexts
 */
export const GTMContext = createContext<ISnippetsParams | undefined>(initialState)
export const GTMContextDispatch = createContext<any | undefined>(undefined)

function dataReducer(state: ISnippetsParams, data: any) {
  sendToGTM({ data, dataLayerName: state?.dataLayerName! })
  return state
}

/**
 * The Google Tag Manager Provider
 */
function GTMProvider({ state, children }: GTMHookProviderProps): JSX.Element {
  const [store, dispatch] = useReducer(dataReducer, { ...initialState, ...state })

  useEffect(() => {
    initGTM({
      dataLayer: state.dataLayer,
      dataLayerName: state.dataLayerName,
      environment: state.environment,
      id: state.id
    })
  }, [state])

  return (
    <GTMContext.Provider value={store}>
      <GTMContextDispatch.Provider value={dispatch}>{children}</GTMContextDispatch.Provider>
    </GTMContext.Provider>
  )
}

function dispatchGTMEvent() {
  const context = useContext(GTMContextDispatch)
  if (context === undefined) {
    throw new Error('dispatchGTMEvent must be used within a GTMProvider')
  }

  return context
}

export { GTMProvider, dispatchGTMEvent }

Would be really pleased to hear your thoughts about it!

Hey @shtelzerartem,
will look into it as soon as possible 😄
Feel free to open a PR!

Hi @shtelzerartem,
sorry for the late update.
I've done a new branch feature/memo  wrapping the provider with React.memo.
Could you test it?
Thx

@elgorditosalsero I'm still experiencing this issue.
Have made a pull request with steps to reproduce in description (#18), so you can check it. I don't wrapping with react memo will help.


Clarifications on Refine Net and it's short comings?

Hi @YoungminBaek
Thank you for publishing your work. I was trying to replicate your work with some modifications. First I used ResNet18 instead of VGG16 as the backbone. I was successfully able to reproduce the CRAFT architecture and Refine Net also.
One key observation I made is that I was able to reproduce Refine Net's output without the additional layers that you have used in the original paper. So in my version,
Refine Net output is obtained along with CRAFT outputs as extra feature map along with character and word maps.
Clarification 1: I was wondering if you have any insights from your experiments about the significance of having the extra conv layers for Refine Net.
The shortcoming of Refine Net is that the network doesn't seem to consider words that are seprated by large number of spaces as one single line.
To fix this, I went one step further and tried to create a new(4th) output feature map.
So in the new variant, the final convolution layer, has the following 4 different outputs:
1. character map
2. word map
3. Refine Net like line map(I call this sub-line map)
4. line map, which works when there are large space between two words in same line(I call this full line map)

4th one is proving to be quite difficult to achieve and the model doesn't seem to be fitting well to the training data.
 If so it would be great if you can provide insights to this particular issue.

I met some problems when training refiner net. How you trained LinkRefiner network? How you generate the GTs of link score, what's  the ratio of the width of refine link and the distance of paired points and what's the loss function when training? Also, would you mind open-sourcing your training codes? I would appreciate it to have your reply.


Upgrade VisIt to the latest and greatest Conduit

Eventually, we must upgrade Conduit to the next version (likely 0.8.5) so we can take advantage of wedge and pyramid support.
When we do so, we must leave an additional note in the release notes for https://github.com/visit-dav/visit/pull/18224
"Added read and write support for wedge and pyramid topologies to the Blueprint plugin."

I came here to report this exact issue. VisIt 3.3.1 doesn't read my Blueprint files that contain wedges and pyramids.

We need to upgrade Conduit to what will likely be 0.9.2 which will include species set infrastructure.


Ed25519 support

Move C++ PrivateKey/PublicKey to TW::secp256k1 namespace
Append Secp256k1 to all C symbols related to ECDSA asymmetric crypto
Add TW::ed25519 namespaces and classes
Add TWPrivateKeyEd25519 and TWPublicKeyEd25519 classes
Update JNI/Swift bindings

Looks good so far. Missing Swift and Android changes.

@terorie You may forget to commit TWPublicKeyEd25519.cpp?

Swift part is fixed

@hewigovens Yes, I didn't commit TWPublicKeyEd25519.cpp because I didn't find the verify function. Why is it named ed25519_sign_open 😅

@terorie you probably not read the readme :)

@hewigovens You got me 👀
Should I rebase this PR on newest master?

I think it's already merged with master

Rebased, first commit contains human changes. Second is code gen


Enable test cases

Integration tests were failing because there is an extra line in the outputs of all the test cases:
error: module not found for: ballerinai/transaction:1.0.0_java11
Because of this, the actual number of lines is always greater than expected number of lines by 1. Therefore the assertion fails. Hence, test cases were temporarily disabled in the build. Need to fix this and re-enable the test cases.

Related PR: https://github.com/ballerina-platform/ballerina-lang/pull/26875

@MadhukaHarith92 We have merged the https://github.com/ballerina-platform/ballerina-lang/pull/26875

@MadhukaHarith92 We have merged the ballerina-platform/ballerina-lang#26875

Verified the fix and re-enabled the test cases. Therefore closing this issue.


Added AmazingBubbles by @GlebRadchenko

Project URL
https://github.com/GlebRadchenko/AmazingBubbles
Description
AmazingBubbles – Apple Music like Bubble Picker using Dynamic Animation
Why it should be included to awesome-ios (optional)
AmazingBubbles use UIKit Dynamics, which is more lightweight than SpriteKit (using in previous library – Magnetic)
Checklist

[x] Only one project/change is in this pull request
[x] Addition in chronological order (bottom of category)
[x] Supports iOS 9 / tvOS 10 or later
[x] Supports Swift 3
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

          1 Error

:no_entry_sign:
Found 1 link issue

Link issue by awesome_bot

Line
Status
Link

2291
301
https://github.com/cookiecutter-swift/FrameworkTemplate redirects tohttps://github.com/JetpackSwift/FrameworkTemplate

  Generated by :no_entry_sign: Danger

Hey @fiveze thanks for contributing to awesome-ios🎉🎉🎉


Cell format is ignored in formulas

Scope: Setup + linelist
To Reproduce
I created a formula that was:
CASE_WHEN(
AND(vacci_yes = "Yes", vacci_doses = "1"), "1 dose",
AND(vacci_yes = "Yes", vacci_doses = "2"), "2 doses")

The important thing here is that the vacci_doses column is defined as text (takes values 1,2,3, 4 or more).
Expected behavior
The content of the column in the expected linelist is in text format, and thus should be treated as text in conditions (vacci_doses = "1" and not vacci_doses = 1).
Actual behaviour

In the generated linelist, the vacci_dose column has the format "text" (can be seen either in the format field, or by the fact that the content of the cells is left aligned) => good
The formula is parsed correctly => good

= SI(ESTVIDE($CA9);"";
SI(ET($CB9="Yes";$CD9="1");"1 dose";
SI(ET($CB9="Yes";$CD9="2");"2 doses";"")))

The condition is not triggered. To make the condition work correctly, I needed to make the condition with naked numbers, as if they were numerics. => bad

= SI(ESTVIDE($CA9);"";
SI(ET($CB9="Yes";$CD9=1);"1 dose";
SI(ET($CB9="Yes";$CD9=2);"2 doses";"")))

I am afraid it's an Excel problem, because as far i can see your CASE_WHEN was translated properly in the linelist. But do you have an explanation or a fix or even a roundabout?
**Desktop:

OS: Windows
Excel version: 365

This is a trickier one, but I got a temptative of answer.
In excel, if I type in  a numeric value, says 1 in cell A1 and then convert it to number, the test =(A1="1") in B1 returns FALSE. It is considered as a numeric value somehow.
On the other hand, if I  convert A1 to text BEFORE entering the numeric value, then the test `=(A1="1") returns TRUE.
Seems like the "type" of the input value in the cell is somehow kept fixed even if you change the formatting afterwards. So this might be related to the order in which formatting vs setting values is applied in the designer (which is a little bit tricky as changing the order might have other side effects I can not detect right now).
I have one more question to investigate: Is vacci_doses a dropdown?


Decide default flavours based on requested Vespa version

@hmusum @bratseth @freva please review

Ah, this didn't run a PR build at all? 😆


Embedded web analytics (metrics) for IC customers

Understand and assess the requirement to implement. Contact IC's development team to determine which output (CSV vice MySQL) would better satisfy their needs, build the capability, test (internally), deploy and test (internally and externally) before declare FOC.

@clarkjefcoat


ValueError: Attempted relative import in non-package

Hello,
I am trying to try KiCost but I get the following error.
$ pwd
.../KiCost/kicost
$  python2.7 kicost.py
Traceback (most recent call last):
File "kicost.py", line 105, in
from .altium.altium import get_part_groups_altium
ValueError: Attempted relative import in non-package
I have installed the dependencies so in ubuntu xenial:
sudo apt-get install python-xlsxwriter
sudo pip install yattag
sudo pip install tqdm

Is another dependency necessary?
Regards,
Javier

I'm using Python 2.7.12 on Windows 7 and not seeing any problem with importing.

I had the same problem on OS X 10.11.6, KiCost 0.1.35. For me it was fixed by running python -m kicost ....
It's been a while since I've used KiCost, but I don't remember having this problem before, on a much older version of KiCost (and on a different OS X machine). I'm sorry I can't help you with more details right now, I'd have to dig up the old machine to check versions and so on.

I had the same problem on OS X 10.11.6, KiCost 0.1.35. For me it was fixed by running python -m kicost ....
It's been a while since I've used KiCost, but I don't remember having this problem before, on a much older version of KiCost (and on a different OS X machine). I'm sorry I can't help you with more details right now, I'd have to dig up the old machine to check versions and so on.

I installed KiCost by pip in Python3 and had no problem
pip3 install --user kicost To install to local user.
sudo pip3 install kicost To install to all users.
The maximum that a had to do before (one computer) was sudo pip3 install --upgrade pip3, all the other dependences was downloaded automatically.


Fix #733: Use pathlib.Path consistently

Fixes #733

@jpopelka, Please check!

Thank you for your contribution.
Please

read Testing and Checkers/linters/formatters & pre-commit
squash commits

@lachmanfrantisek, PTAL!

@RafayGhafoor please, try to squash your commits so we have cleaner git history.
You can use ammend or rebase to make your branch clear so that it contains only reasonable commits. (Another page about rewriting the git history.)

@lachmanfrantisec, PTAL!

@lachmanfrantisec, PTAL!

It would be nice to get rid of the merge commit as well.

It would be nice to get rid of the merge commit as well. You probably need to do:
1. interactive rebase and drop that commit (`git rebase -i 7014b693a15379a1bf71ce1d641c56927aaf9fc5~1` and mark that commit to be dropped)

2. update the local `master` branch (`git checkout master && git pull upstream master`)

3. switch back to the branch (`git checkout -`)

4. rebase your commits on top of master (`git rebase master`)

rebasing against upstream master should drop the merge commit - it's definitely a good exercise to please with rebase -i though

@lachmanfrantisec, PTAL!

recheck

@jpopelka, PTAL!

Hi @RafayGhafoor
do you think you'll continue with this or should someone else finish it? (we'd leave your commits there so you'd get credit)

@jpopelka, Sorry, have been busy lately. I can continue working on it if it's not of high priority as I might be busy for a few days but if you think this needs to be done earlier, you can assign someone else :-)

It's quite a low priority so take your time. I was just checking. Thanks!

Thank you for your contribution! Since this is inactive for such a long time, I am going to close - the code base evolved over time and I'd say it would be really hard to rebase. Feel free to reach out in case of any questions or comments.


Tune networking code for a larger network

The networking code, as written, works very well for small networks. It was developed on 2 machines, and the main concern was to have as much connectivity between nodes as possible.
Yesterday I saw ~100 nodes. If we keep growing, we may need to reconsider some of the base assumptions. In particular: at some point we'll need to limit the amount of peers any peer connects to, and the rates of traffic with those peers might need an update also.

One important change we can make is to add UDP connectivity and to prefer UDP over TCP. i.e. Attempt a UDP handshake before initiating a TCP connection, and only fallback to TCP if UDP fails.  UDP has many scalability advantages over TCP, and hugely simplifies the code. For instance, a single socket selector call can receive data from all peers, instead of maintaining a separate connection for each one.
The downside is that UDP will only work with peers that are fully connected to the network. Outgoing-only connections will still have to use TCP for bi-directional communication. The silver lining here is that the number of TCP connections will be naturally limited (due to system bottlenecks, like the 64-selector limit on Windows), creating a stronger incentive for nodes to be fully connected.


Trait: Add TraitDefinition for PVC

What this PR does / why we need it:
Adds TraitDefinition for Persistent Volume Claim and adds an example yaml file using this trait definition
Which issue(s) this PR fixes:

Fixes #2057
Special notes for your reviewer:

@Somefive FYI

tested the trait by deploying it and creating an application which uses this trait
[reetasingh vela-templates (master)]% vela def apply definitions/internal/pvc.cue
TraitDefinition pvc in namespace vela-system updated.
[reetasingh vela-templates (master)]% k create -f definitions/usage-examples/application-with-pvc.yaml
application.core.oam.dev/application-with-pvc created
[reetasingh vela-templates (master)]%
[reetasingh vela-templates (master)]%
[reetasingh vela-templates (master)]% k get  pvc
NAME          STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS   AGE
busybox-pvc   Bound    pvc-2907d6d8-4eda-4c02-ac0a-7c29be955d42   2Gi        RWO            standard       14s
[reetasingh vela-templates (master)]%
[reetasingh vela-templates (master)]%
[reetasingh vela-templates (master)]% k get pod
NAME                              READY   STATUS    RESTARTS   AGE
busybox-runner-7b976c4cd8-hmw9w   1/1     Running   0          18s
[reetasingh vela-templates (master)]% k get pv
NAME                                       CAPACITY   ACCESS MODES   RECLAIM POLICY   STATUS   CLAIM                 STORAGECLASS   REASON   AGE
pvc-2907d6d8-4eda-4c02-ac0a-7c29be955d42   2Gi        RWO            Delete           Bound    default/busybox-pvc   standard                24s


Don't modify preferences automatically

Modifying preferences will trigger a recompilation on the next load. This can cause unexpected problems when combined with MPI runs or when done while precompiling. Personal opinion: we should never change a preference automatically, but we can warn/error when a misconfiguration is detected.

Should be fine now.


Fix DownloadIcon in WebComponent Sidepanel

The download.svg that's used for buttons is too small for the Sidebar panel menu.
It's currently been wrapped in a DownloadIcon component that allows its width and height to be set so that it can be resized for both buttons and the Sidebar.
The sizing still appears incorrect in the Sidebar menu.
Notes

It may be better to scale the SVG rather than change the width and height (eg see CloseIcon)
The size of the SVG affects its surrounding elements. In the Sidebar Menu. The boxes that surround the selected DownloadPanel should be the same size as those for the other menu options (in the image below, the boxes are too small)

The initial download.svg was incorrectly imported without whitespace. The new svg replaces the wrapper


OidcUserInfo Change PhoneNumberVerified Field to Boolean

Describe the bug
When setting the phoneNumberVerified field, it accept a String instead of a boolean.
To Reproduce
OidcUserInfo userInfo = OidcUserInfo.builder().phoneNumberVerified(String.valueOf(true)).build();
Expected behavior
OidcUserInfo userInfo = OidcUserInfo.builder().phoneNumberVerified(true).build();

Thanks for the report @ramonmalcolm10. This is now resolved via 629e220c2f39e9512abab642a178d87b28d69b6d.


Update guide-changelog.md

The changelog is displayed only if the repository contains a class which implements ZIF_APACK_MANIFEST, whose constructor initializes the current version in attribute zif_apack_manifest~descriptor-version.

hmm, abapGit doesnt use apack, and it shows the changelog?

I created changelog.txt in my test repository/branch and it didn't work. I did a little debug on abapGit class and I saw that it takes the version from the APACK class if implemented.
I think abapGit goes to line 127 here:
https://github.com/abapGit/abapGit/blob/0d957aac171bc1b2d9af16f4eecdf564b38330b5/src/zcl_abapgit_news.clas.abap#L126-L137

hmm, yea, ok, it uses the version to know if it was shown before

Maybe add "abapGit itself does not use APACK and gets the current version from zif_abapgit_version=>c_abap_version. The version is then used to determine if the changelog was updated and should be shown to the user."

The most important part was about APACK, for the rest I let you complete as you wish 😉


fix/creat_file_api: update create file api to stream content

Upload file content using create file api of NFS with streaming support

This change is

r? @ustulation
(maidsafe_highfive has picked a reviewer for you, use r? to override)


PASS1B-06 data file download

Implement the capability for users to download PASS1B-06 data as smaller subsets of files per their interests, such as by a selected number of tissues, assays, or omics.
The core functionality of this file download implementation had been developed and tested along with the development of the portal search feature. Due to a few remaining UX/UI issues, this functionality was omitted from the deployment of the portal search in production.
Remaining UX/UI issues to be addressed:

Create a manifest file that lists all the files of interest with their full paths to help users to organize the downloaded files.
A revised/rewritten README document describing the downloadable PASS1B-06 data.
A clear message explaining that raw PASS1B-06 data files are not available for download, but available via command-line access for internal users, or via access requests for external users.

The preview version of the PASS1B-06 data download feature has been completed and deployed, with the exception of a revised/rewritten README document more suitable for the practice of making data accessible via the data hub portal going forward.


feat: Relative Url

Sorry for the delay. :smile: :laughing: Fixes #3

https://github.com/hello-rust/lychee/pull/15/files#diff-9bfca03419915f4d4c69bb43d30e158a84c63d0f68c35c4991fd659d8b158f1cR10-R12
pulldown-cmark library is splitting http://[::1] into four parts (http://,[,::1,]) when the URL is not in a URL section.

Looks great!
Only thing I'd add is a unit test for extract_links with a some base_url (on top of the integration test you already added). Other than that it's ready to merge from my perspective. Code is very readable.

Thanks for adding the unit tests and for your contribution in general @whizsid. LGTM. 😊


Packaging: include all dlls for net461 and netstandard2.0 targets

Note: Added 3 missing SocketTaskExtensions for the JsonRpcSharp.UnixIpcClient on net461

@mfkl interesting thing I found while digging my past commits is that I fixed the SocketTaskExtensions already in the past, but with a different technique, and in a different project (I fixed it in the IpcClient project, you fixed in the UnixIpcClient project): https://github.com/Nethereum/Nethereum/commit/9c116902d247eb85d52d58558a005bb138d5bab7
And now I see that in this PR you're actually eliminating the NET461 constant from the IpcClient project (essentially reverting my fix from Feb2018), so... this makes me wonder, how is it possible that you didn't face the same build issue for IpcClient?
PS: side-note unrelated to the above: I'm wondering if we actually can downgrade JsonRpcSharp from net461 to net460.

you're actually eliminating the NET461 constant

Ops... Yeah didn't think about it twice.

how is it possible that you didn't face the same build issue for IpcClient?

Because the code that uses these extension methods and gives build error was once in IpcClient but now has moved to UnixIpcClient. https://github.com/Nethereum/Nethereum/blob/9c116902d247eb85d52d58558a005bb138d5bab7/src/Nethereum.JsonRpc.IpcClient/UnixIpcClient.cs

https://github.com/Nethereum/Nethereum/blob/9c116902d247eb85d52d58558a005bb138d5bab7/src/Nethereum.JsonRpc.IpcClient/UnixIpcClient.cs that link points to the IpcClient project ;) I'm talking about projects here, not files :)

I'm barely waking up now, let me look into this better in a bit when I dig a bit more.

That link points to the IpcClient project ;) I'm talking about projects here, not files :)

Regardless. As of this writing, the only project that has code calling the SocketTaskExtensions methods is the JsonRpcSharp.UnixIpcClient project. Which is why only this project failed to build in net461.
Looking at https://github.com/Nethereum/Nethereum/blob/9c116902d247eb85d52d58558a005bb138d5bab7/src/Nethereum.JsonRpc.IpcClient/UnixIpcClient.cs, it seems that the previous solution was to #ifdef net461 and use the regular socket APIs in that case.


Make dependency tree more simple

Currently the dependency tree of the consumer is a bit vague. Consumer requires a command bus. The problem is that when an event middleware is passed to the command bus and one of the listeners is used, the listener requires the consumer. This circular-like dependency is bad.
The proposed solution:
use League\Tactician\Bernard\Consumer;
use League\Tactician\CommandBus;
use League\Tactician\CommandEvents\EventMiddleware;
use League\Tactician\CommandEvents\Event\CommandLimit;

$consumer = new Consumer();
$eventMiddleware = new EventMiddleware();

$eventMiddleware->addListener(new CommandLimit($consumer, 1));

$commandBus = new CommandBus([$eventMiddleware]);

$consumer->consume($queue, $commandBus);

This way the tree becomes linear as the command bus can be the last initiated class:

See #8


Docs are including protocol twice in links

https://https://login.alpha.linode.com/oauth/authorize?client_id=client_id

found on https://developers.alpha.linode.com/access
Looks like we are adding the protocol on links twice, https//login.alpha.linode.com/apps points to https://https//login.alpha.linode.com/apps

fixed in #1792


Victory Column data sequence problem

Hi
Thanks for your great work.
I just tried to run the code using the Victory Column data sequence and the output is quite strange.
Seems that there are some problems with this data sequence, it is too small compared with others.

Thank you for pointing out my mistake and sorry for my late response.
I uploaded the wrong rosbag files for the "Victory Column", "Square Center" and "Square Side" scenes before, so that their time lengths did not agree to the paper and the github page. I have uploaded the correct files. You are welcome to try the new rosbags out.


fix: view in room crashed on second modal spawn

This PR resolves []
Description
The issue was that the modal presentation was not happening on main thread. fixed.
also a couple of tiny things for xcode 14 to work, since i debugged it there.

QA Test Case(s)

Test Case
Feature
Environment
Acceptance Criteria
Setup Instructions/Link

PR Checklist

[ ] I tested my changes on iOS / Android.
[ ] I added screenshots or videos to illustrate my changes.
[ ] I added Tests and Stories for my changes.
[ ] I added an app state migration.
[ ] I hid my changes behind a feature flag.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

perfect


Spam section of the battle configuration

Preparation

[X] I read the Troubleshooting Guide
[X] My question isn't answered in any other issues (even the closed ones)

Your question
Is it a feature or a bug that in this section, for the np there is no waves 3 and for the skil there is no waves 2 and 3?

I'm seeing all the settings on my end in landscape.  Can't test in portrait (emulator).
Is it a bug with portrait mode?

Ok so its a bug with the portrait mode on my device, rip.


Fetching configuration information from decoupled client install

Trying to create pseduo clients using commcell.clients.create_pseudo_client(client_name)
There is no flag to have the configuration information read from the client using a specific cvd port. This is the case when the client has already been installed in decoupled mode.
What needs to be done next to have the client registered with the commcell?

Hi @asshutossh ,
create_pseudo_client() is used to create a new client and hence cannot be used to register a decoupled client.
We have introduced a new API to register decoupled clients. Can you please try using that?
https://github.com/Commvault/cvpysdk/blob/dev/cvpysdk/client.py#L818


The engine "node" is incompatible with this module

I got an error:
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version ">=14.19.1 <= 18.x.x". Got "20.9.0" error Found incompatible module.
will the plugin be updated?

Yes, update due soon (this week)

Fixed, sorry for the delay


Why is CsvReader forward only?

More of a question, initially thought it was a bug.
I need to know how many lines are in my csv file.
So I did a myCsvReader.Count() (Linq) to get it. Of course, this moves the cursor forward to the end as it has to iterate it. But then I called myCsvReader.GetEnumerator().Reset() or even myCsvReader.MoveTo(-1) and they have no effect.
I found this line of code in MoveTo:
   if (record < _currentRecordIndex)                     return false;
which confirm my thoughts that this is a forward only reader.
This msdn page (https://msdn.microsoft.com/en-us/library/65zzykke(v=vs.100).aspx) says that

Iterators do not support the IEnumerator.Reset method. To re-iterate from the beginning, you must obtain a new iterator.

But I've tried to do var en2 = myCsvReader.GetEnumerator(); and that doesn't return a new iterator. It returns the existing iterator which points to the end.
Why? Why can't I go back to the begining?

I didn't do the original design but I would guess its about two things

Parsing forwards is relatively easy, backwards less so,
Keeping all the data on the of chance you need it is expensive (think files in the 1 GB+ range)

Also,, most typical processing for CSV files is...

Read a row
Process a row
Next

Bear in mind there is a class included called CachedCsvReader which does allow you to go backwards, but you have to take the memory hit

Just to give a real-world scenario for this. For my use I dont need to process a CSV line by line as all Im doing is loading a CSV file into a SQLserver table using SQLBulkCopy.
For large CSV files with millions of rows I really need the rowcount in advance so I can update a progressbar as the upload progresses. For larger files an upload might take 30 mins so having a progressbar is really essential IMO.
But because its a large file I would like if possible to minimize the memory footprint so prefer not to use CachedCSVReader if possible.
So its frustrating that the basic CSVReader which would have otherwise been ideal doesnt have the record count.

@hugobyrne Same reasons as before, parsing is (potentially) tough, but you could do a couple of things.

Do a quick first pass that counts "\r\n" which would give you a row count if the data is not complex
Re-work this idea as part of CsvReader so we can have it as an option e.g. NaiveCount or EstimatedCount

Slightly related point, have you looked at this http://sqlblog.com/blogs/alberto_ferrari/archive/2009/11/30/sqlbulkcopy-performance-analysis.aspx, relatively old, but gives a lot of performance analysis/ideas on SqlBulkCopy

Thankyou very much Paul for the fast reply. III see what I can work out based on your advice.
And that sqlbulkcopy performance analysis is indeed very useful. There is some excellent tips in there which III be following up on.

Just use a second reader instance to go through the file a second time.


Typhoeus version bump request

Hi,
I ran into this issue on certain websites:
https://github.com/curl/curl/issues/3750
Seeing typhoeus 1.3.1 is from 2018, can we bump it to 1.4.0?
Thanks!

Hmm actually Ruby 2.6 is EOL and maybe we should update to 2.7 instead?

Actually I just realized it's simply a wrapper around libcurl. I guess that means we need to update the base image to something like ubuntu:22.04?

Yes, please.


Consider creating a gem so that this package can be required in sass/compass

This is not a real issue, but since it's built in sass, you should build a gem so that we (users) can install it via ruby and require it in our sass file

Sorry I don't know how to create one, I stopped using Ruby and Compass few years ago. If you know of any tutorial I can follow I can try adding it, but only if it is not too time consuming.

I am closing this for now, let me know if you have a easy solution to integrate this in a gem.

As soon as I have some spare time I will!
Il 01 set 2017 11:50, "Salvatore Tedde"<EMAIL_ADDRESS>ha
scritto:

I am closing this for now, let me know if you have a easy solution to
integrate this in a gem.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microcipcip/gridy/issues/3#issuecomment-326539742,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGfpMz9H0Lx72XQ3WINc7DZ2l0M9X-iFks5sd9NmgaJpZM4O0gcz
.

Grazie ;)


False Validation of Syft/Grype SBOM

I created an SBOM using Syft/Grype and it should have created a valid CycloneDX 1.4 SBOM. The SBOM did not adhere to the CycloneDX 1.4 schema, however the CycloneDX CLI validated it successfully regardless.
To reproduce:
https://github.com/anchore/syft
https://github.com/anchore/grype
syft nodered/node-red -o cyclonedx-xml --file bom.xml
grype sbom:bom.xml -o cyclonedx --file grype-bom.xml
cyclonedx validate --input-file grype-bom.xml
Result: Validated successfully
Expected result: Not valid

@pkiesslingsonatype Can you please specify how it violates the schema?
Maybe I missed the obvious... but it is a bit hard with a 19k lines document. (By now it produced a version 1.5 schema, but I'm not sure whether this matters.)
As a side note, all that the cli does at the moment is to validate the xml schema.

Related local issue here: https://github.com/CycloneDX/cyclonedx-cli/issues/344
Related syft issue where we did the investigation: https://github.com/anchore/syft/issues/2268
For the images supplied we found that the schema should be updated with the latest SPDX license list.

@andreas-hilti It seems the URLs within the SBOM do not comply with the schema:
xmllint --noout --schema ~/Downloads/bom-1.4.xsd grype-bom.xml
grype-bom.xml:3612: element url: Schemas validity error : Element '{[http://cyclonedx.org/schema/bom/1.4}url](http://cyclonedx.org/schema/bom/1.4%7Durl)': 'git@github.com:colorjs/color-name.git' is not a valid value of the atomic type 'xs:anyURI'.
grype-bom.xml:5946: element url: Schemas validity error : Element '{[http://cyclonedx.org/schema/bom/1.4}url](http://cyclonedx.org/schema/bom/1.4%7Durl)': 'git@github.com:follow-redirects/follow-redirects.git' is not a valid value of the atomic type 'xs:anyURI'.
grype-bom.xml:8857: element url: Schemas validity error : Element '{[http://cyclonedx.org/schema/bom/1.4}url](http://cyclonedx.org/schema/bom/1.4%7Durl)': 'git@github.com:jprichardson/node-jsonfile.git' is not a valid value of the atomic type 'xs:anyURI'.
grype-bom.xml:14669: element url: Schemas validity error : Element '{[http://cyclonedx.org/schema/bom/1.4}url](http://cyclonedx.org/schema/bom/1.4%7Durl)': 'git@github.com:lupomontero/psl.git' is not a valid value of the atomic type 'xs:anyURI'.
grype-bom.xml fails to validate

I have attached the SBOM that is causing the issue.
Hopefully that helps.
grype-bom.xml.zip

Oh! Thanks for the extra info @pkiesslingsonatype - I can probably get a fix in grype that updates those URL to be correct

@pkiesslingsonatype When I produced the SBOM myself, it contained none of these<EMAIL_ADDRESS>urls.


Imports from Alembic are treated as first-party

seed-isort-config is used to keep isort's list of known third-party imports up-to-date.  This should be fixed.

This seems to be because the migrations directory is named alembic. I'm guessing that seed-isort-config is seeing this and thinking that it's a local package rather than a collection of scripts. seed-isort-config has some configuration options that may help here, but renaming the directory to migrations or something similar is probably the easiest fix.

That makes a lot of sense. Good thinking!


Assignment parameters, allow for specifying effects differently per assigned Policy or Policy Set in a definitionsEntryList

Applies to CSV and maybe JSON

Adding to backlog


Open Weather API key incorrect during setup

During intergation setup we receive the error: Open Weather API key incorrect
Within the HA log we see:
2020-05-20 00:01:21 ERROR (MainThread) [custom_components.smart_irrigation.config_flow] Cannot talk to OWM API, check API key.
2020-05-20 00:03:29 WARNING (MainThread) [homeassistant.util.async_] Detected I/O inside the event loop. This is causing stability issues. Please report issue to the custom component author for smart_irrigation doing I/O at custom_components/smart_irrigation/OWMClient.py, line 24: r = requests.get(self.url)
2020-05-20 00:03:29 ERROR (MainThread) [custom_components.smart_irrigation.OWMClient] Failed to get OWM URL {"cod":401, "message": "Invalid API key. Please see http://openweathermap.org/faq#error401 for more info."}
2020-05-20 00:03:29 ERROR (MainThread) [custom_components.smart_irrigation.OWMClient] Cannot talk to OWM API, check API key.
2020-05-20 00:03:29 ERROR (MainThread) [custom_components.smart_irrigation.config_flow] Cannot talk to OWM API, check API key.
This is a new OWM account with validated emailaddress, created a new API Key named it HASS.IO

Ok got an email the API key will be activated during the next hours. So i think i'm being impatient here.. Close it for now

yeah, some times activating the API key takes a while. I'll add a note to the readme. thanks for checking this out and let me know if you need any more help!


Using tests as filters is deprecated

Using tests as filter will be removed in Ansible 2.9.

Did not know this was deprecated! Thanks!


Update main.sw

Updated documentation for B512

Renamed Bits512 to B512 to better align with the wider ecosystem.

Added documentation on how to form a B512 from two B256.

Improved examples to reflect more complex use cases.

Closes #3241

Release notes
In this release, we:

Updated the documentation for B512 to enhance clarity and usability.

Summary
This PR updates the documentation for B512 to improve understanding and usability. The changes include renaming Bits512 to B512, adding missing information on how to form a B512 from two B256, and enhancing examples to illustrate more complex use cases.
Breaking Changes
Checklist

[x] All changes are covered by tests (or not applicable)
[x] All changes are documented (or not applicable)
[x] I reviewed the entire PR myself (preferably, on GH UI)
[x] I described all Breaking Changes (or there's none)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

If you have any questions or need clarification about the changes, please don't hesitate to ask. I'm happy to help you !

@digorithm Hey ! please tell me what's wrong, this is the second time I've corrected a mistake on your colleague's advice, but again there's no reaction, what's wrong?)


Hardcode the base dir as it's not properly computed with delegate_to

As a pull request owner and reviewers, I checked that:

[ ] Appropriate testing is done and actually running
[ ] Appropriate documentation exists and/or is up-to-date:

[ ] README in the role
[ ] Content of the docs/source is reflecting the changes

/approve
/lgtm
ahhh, delegate_to... that old friend you'd rather throw away, right? ;)


Admin Events: Prepare table for data

Populate data table with events data. Pagination displayed but not set
up.
https://patina-dev.nyc3.digitaloceanspaces.com/screenshot/Screenshot-2024-11-11T19:15:13-MartinM-EditEventsTable.png
TEST=manual
Ran page locally to verify feature works.
Change-Id: I355044bc56a07ec857075e41bcb3a2be863e6df5

Code Review comments can be found at https://gerrithub.io/q/I355044bc56a07ec857075e41bcb3a2be863e6df5


ci: change build-rpms to run on PRs

Add 'pull_request' to 'on'
Add condition to installing/testing RPMS to exclude 'pull_request'

Signed-off-by: Rodrigo Rojo<EMAIL_ADDRESS>

Coverage remained the same at 66.011% when pulling a347bdc5faa8cb67d219131449a1a568b9a9102c on rrojo/build_rpms_on_pr into 6eddf58c91c29d5f68225f61910d354010d828c7 on master.


Multiple error messages when initially importing Flat kit.

Hi, when importing and unpacking flat kit I receive 45 error messages and am unable to drag and drop the package into the render pipeline settings. I have used Unity 2020.2.1, 2020.1.6, 2019.4.1 and have even booted up a brand new project to try get it working.
When using the Built-In pipeline I do not get the error messages but, I am still unable to drag and drop the package into the render pipeline settings.
Do you know why this could be? I assume I'm missing something that may be obvious to someone else, any help is greatly appreciated!

Hi,
Could you please copy at least a few of the errors? A screenshot of the Console or a copied text would be useful.
Before dragging the settings file into Graphics and Quality tabs, please make sure you have unpacked the unitypackage you downloaded from Package Manager, described in the installation guide on the step 2 here
In Built-In Rendering Pipeline you don't have to drag and drop the settings files as you would do in URP. But you'll need to unpack Built-In RP files, just like in URP. It is described in the manual's quick start guide. You choose your RP version on the step 2.
Looking forward to your reply.

Hi,
Could you please copy at least a few of the errors? A screenshot of the Console or a copied text would be useful.
Before dragging the settings file into Graphics and Quality tabs, please make sure you have unpacked the unitypackage you downloaded from Package Manager, described in the installation guide on the step 2 here
In Built-In Rendering Pipeline you don't have to drag and drop the settings files as you would do in URP. But you'll need to unpack Built-In RP files, just like in URP. It is described in the manual's quick start guide. You choose your RP version on the step 2.
Looking forward to your reply.

Hi,
Could you please copy at least a few of the errors? A screenshot of the Console or a copied text would be useful.
Before dragging the settings file into Graphics and Quality tabs, please make sure you have unpacked the unitypackage you downloaded from Package Manager, described in the installation guide on the step 2 here
In Built-In Rendering Pipeline you don't have to drag and drop the settings files as you would do in URP. But you'll need to unpack Built-In RP files, just like in URP. It is described in the manual's quick start guide. You choose your RP version on the step 2.
Looking forward to your reply.

Here's a screenshot of the errors I receive when using the URP, thanks for the quick response!
(https://user-images.githubusercontent.com/44914416/104893715-bc1b0100-59ae-11eb-9819-87d93d904dbf.PNG)

Hi,
Could you please copy at least a few of the errors? A screenshot of the Console or a copied text would be useful.
Before dragging the settings file into Graphics and Quality tabs, please make sure you have unpacked the unitypackage you downloaded from Package Manager, described in the installation guide on the step 2 here
In Built-In Rendering Pipeline you don't have to drag and drop the settings files as you would do in URP. But you'll need to unpack Built-In RP files, just like in URP. It is described in the manual's quick start guide. You choose your RP version on the step 2.
Looking forward to your reply.

Here's a screenshot of the errors I receive when using the URP, thanks for the quick response!
(https://user-images.githubusercontent.com/44914416/104893715-bc1b0100-59ae-11eb-9819-87d93d904dbf.PNG)

Thank you for the screenshot.
To confirm, you are trying to import Flat Kit into a freshly created URP project in Unity (various versions), correct?
Like this

If so then:

Could you please let me know what version of Universal RP you are using? You can check it in Window -> Package Manager
Have you unpacked [Render Pipeline] Universal (URP).unitypackage?
Please confirm you have tried importing Flat Kit according to the guide here.

If you are creating the Built-In project (known as '3D') like here:

...then you'll need to import the Built-In version of Flat Kit, not the URP version. It is also described in the guide here.

Thank you for the screenshot.
To confirm, you are trying to import Flat Kit into a freshly created URP project in Unity (various versions), correct?
Like this

If so then:

Could you please let me know what version of Universal RP you are using? You can check it in Window -> Package Manager
Have you unpacked [Render Pipeline] Universal (URP).unitypackage?
Please confirm you have tried importing Flat Kit according to the guide here.

If you are creating the Built-In project (known as '3D') like here:

...then you'll need to import the Built-In version of Flat Kit, not the URP version. It is also described in the guide here.

Alright, turns out my project wasnt in URP, this has fixed it for me! Thank's heaps for helping out with it!

Alright, turns out my project wasnt in URP, this has fixed it for me! Thank's heaps for helping out with it!


53 edit remaining holidays

changes since last PR:

added gem 'whenever' that fires every January 1st and updates remaining leave (remaining_leave_last_year = remaining_leave; remaining_leave = 28)
added warning label that exists from Jan 1st to March 31st and tells the user that remaining leave from last year will expire on April 1st
fixed Datepicker appearance
added translations

In den Dev soll das ja auch nicht, sorry :/ -> https://github.com/hpi-swt2/wimi-portal/pull/95


meeting notes for the db meeting

Basics

[ ] Details of what you changed are in commit messages
(first line should have module: short statement syntax)
[ ] References to issues, e.g. close #X, are in the commit messages.
[ ] The buildserver is happy.
[ ] The PR is rebased with current master.

Checklist

[ ] I added unit tests for my code
[ ] I fully described what my PR does in the documentation
(not in the PR description)
[ ] I fixed all affected documentation
[ ] I fixed all affected decisions
[ ] I added code comments, logging, and assertions as appropriate
[ ] I mentioned every code or binary not directly written or done by me in reuse syntax

Review

[ ] Documentation is conforming to our Documentation Guidelines
[ ] Examples are well chosen and understandable
[ ] Code is conforming to our Coding Guidelines
[ ] Code is consistent to our Design Decisions

Closing since the meeting notes are already contained in #227


Automatic reconnect

Sometimes we have long-running jobs and then we get some errors.
fwrite(): Send of 8 bytes failed with errno=32 Broken pipe
Maybe it is better that the client can detect when the connection is broken and do a reconnect.
#2 /code/vendor/stefanak-michal/bolt/src/connection/StreamSocket.php(76): fwrite()
#3 /code/vendor/stefanak-michal/bolt/src/protocol/AProtocol.php(70): Bolt\connection\StreamSocket->write()
#4 /code/vendor/stefanak-michal/bolt/src/protocol/v3/RunMessage.php(20): Bolt\protocol\AProtocol->write()
#5 /code/vendor/laudis/neo4j-php-client/src/Bolt/BoltConnection.php(225): Bolt\protocol\V4_4->run()
#6 /code/vendor/laudis/neo4j-php-client/src/Bolt/BoltUnmanagedTransaction.php(138): Laudis\Neo4j\Bolt\BoltConnection->run()
#7 /code/vendor/laudis/neo4j-php-client/src/Bolt/Session.php(70): Laudis\Neo4j\Bolt\BoltUnmanagedTransaction->runStatement()
#8 /code/vendor/laudis/neo4j-php-client/src/Client.php(110): Laudis\Neo4j\Bolt\Session->runStatements()
#9 /code/vendor/laudis/neo4j-php-client/src/Client.php(80): Laudis\Neo4j\Client->runStatements()
#10 /code/vendor/laudis/neo4j-php-client/src/Client.php(75): Laudis\Neo4j\Client->runStatement()
#11 /code/app/Models/Api5/Guide.php(48): Laudis\Neo4j\Client->run()

Hey @tomswinkels. Sorry for the late response. I'd like some more information about what caused this issue. Are you running a single long running query or multiple smaller queries?

Hey @exaby73 no problem!
This issue has nothing to do with the runtime of a query.
It's a long-running job that do more than only execute some queries.
When we do before every query again a client connect than the problem will be solved, but we think that it's better that the client check if the connection is active or not.


DOC: 404 Error https://docs.scipy.org/doc/scipy/reference/objects.inv

Hello. We noticed broken link (404) for https://docs.scipy.org/doc/scipy/reference/objects.inv , which resulted in broken intersphinx downstream.
xref astropy/astropy#12000

Let me try to compare the placement of that file with the current release vs. previous release on the docs server. I had to do some manual fixing just to get the docs to display at all so maybe another tweak or two is needed (what could go wrong?).

I tried to replicate the SciPy 1.7.0 placement of that file on the server and did the copy below--maybe check again to see if it is better now?
cp scipy-1.7.1/objects.inv scipy-1.7.1/reference/objects.inv

Works for the NumPy docs - thanks!

Thanks Melissa

I'll try it out downstream and report back. Thanks for the quick response!

Yes, it works again. Thank you!

I tried to replicate the SciPy 1.7.0 placement of that file on the server and did the copy below--maybe check again to see if it is better now?
cp scipy-1.7.1/objects.inv scipy-1.7.1/reference/objects.inv

Hello from MetPy! In this placement, reference/objects.inv still refers to reference/ from its new home,
py:attribute
	scipy.integrate.BDF.TOO_SMALL_STEP       reference/generated/scipy.integrate.BDF.TOO_SMALL_STEP.html#scipy.integrate.BDF.TOO_SMALL_STEP

and so now even though our intersphinx errors are gone (thanks!), our generated URLs from intersphinx attempt to point to reference/reference/. Can see this on linkchecker on this check (Unidata/MetPy#2002) and I can reproduce locally from MetPy main. Astropy's latest docs are doing the same (Notes section).

Ops, good catch, @dcamron !

Ok, I tried to copy some more datafiles around to better replicate what 1.7.0 looks like on the server--let me know--I see that astropy Notes section seems better now at least.
Even if this does "fix" the apparent issue, we'll need a way for this to happen correctly automatically, so I'd just leave this issue open for now, but do let me know if problems persist/arise.

A few other server documentation issues that I just noticed:
I think the API Reference landing page is even missing some internal references?
https://docs.scipy.org/doc/scipy/reference/reference/index.html
That page doesn't render any CSS for me, but all other pages appear normal.

The 1.7.0 release notes also 404 for me, but all other versions seem to link correctly.
https://docs.scipy.org/doc/scipy/reference/release.1.7.0.html

"Getting Started" page also seems to be broken. When I click on "To the getting started guides" on https://docs.scipy.org/doc/scipy/reference/, it just shows me this:

@tupui I'm open to suggestions re: the new doc theme asset deployment--for some of the more recent issues above I can probably try hacking the locations of some assets again, but that's not really sustainable of course.

@tupui I'm open to suggestions re: the new doc theme asset deployment--for some of the more recent issues above I can probably try hacking the locations of some assets again, but that's not really sustainable of course.

@tylerjereddy I am not sure I can help. If I understand correctly, you are using pavement.py which I never opened.
In general, it would be better to use the same process as the CI to push the dev documentation. Ideally we should be able to have a workflow for pushing a release (which would also allow more frequent releases). I am not sure what extra steps you are doing to release, but since we build wheels and the doc, I would think that we could also go the last mile and push to PyPi/update the doc.


Fixes #1

Pull Request Test Coverage Report for Build 0027c6ef6062cad55f082fcc33fe385cbec18a2c-PR-4

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 3085b1df7b318a07db5ce38a215568a0ec2f7072:
0.0%

Covered Lines:
47

Relevant Lines:
47

💛  - Coveralls


Icon request

Excuseme can please add icon for this app?
Fkm
Apex Legenda
Tachiyomi/Tachi J2K

Added all 3 👍

Hello! It would appear that this icon request doesnʼt include the package names of some or all of the apps for which icons have been requested. In addition, we are switching to a new system for icon requests. The apps for which package names have been provided (if such apps exist in this icon request) have been added to the new icon request database, meaning no action is required. For the apps for which package names havenʼt been provided, please submit an icon request via the new icon request form: https://forms.gle/Fx8vZAiWdW1Tyjo57.


made Person and Address API self-consistent

Please feel free to suggest any changes/enhancements.
Thanks for providing jfairy. :)

Hi! We had long discussion about get prefix and we're aware there are inconsistencies here. The argument for using get* is that it allows you to write just address.street in Groovy, which is often used in tests.

Hi,
from groovy you can use address.street anyway as groovy allows access to private members. (I already use things like address.streetNumber in my Groovy code ;).)
But from Java using address.postalCode() is more convenient than using address.getPostalCode(). Furthermore it's confusing when most of API uses getters without the "get" prefix and a few methods require the prefix.
Of course it's your project, so you decide. :) Feel free to reject my pull request.

maybe we can both type of methods without deprecation?

I am fine with having both type of methods. I can updated the pull request if everyone is fine with this solution. No  need to hurry, I can wait if you require further time to discuss/decided.

There are some problems with access to private fields from groovy, IDE warns about this kind of access and this is not working with compile static.
In my opion we have two options:

make private fields public
add getFoo() and foo()

About groovy and private...

it looks like this was a bug in groovy from the beginning, but nobody bothered to fix it because for such a dynamically and reflectively capable language private is just a documentation anyways.
http://www.gmarwaha.com/blog/2009/02/02/groovy-private-is-not-private/

I do not know jfairy good enough, but if everything field is final anyway making them public would not hurt and make access from java read even nicer. Eclipse does not emit any warning for this, but maybe other IDEs do.

Hi @jkubrynski @mariuszs
any updates?
I updated the pull request and removed the deprecation from the getX methods.

:+1:

@szpak What do you think? Maybe we should use public fields instead?

@PascalSchumacher sorry for delay from our side, but it's pretty general change and it's hard to make a decision. I personally think we should choose single convention and stick to it. In Java world name() is something which looks better, but in Groovy (which is major usecase in tests) developers usually prefer just name. IMHO that drives us to get* convention. So I vote for getters

+1 for getters

+1 for consistency

I would say that in java get... does look better if the object is a pojo. Which is actually the case for the Person and Address objects.

Ok, I think it makes sense. Could you improve the coverage? I will merge it then.

I'll could do a separate PR where I refactor all pojos to use getters. This PR does actually the opposite and removes the current getters in the address object.

@andidev No sure what you mean, the pull request does not remove anything it just adds.

Oh yes you are right Pascal. @OlgaMaciaszek So is both getters and and non getter methods wanted for all pojos or is it only getters or only non getters? Not sure what you ment.
I ment only getters in my comment since that is the java style of doing it and since this is a java library.

Sorry, I had to delete the comment above - I've written it under the wrong PR.
When it comes to this one, I agree with @jkubrynski


Enabled does not work as expected

Hi there,
I use enabled property in case of autofocus of an input in a modal context. I do it to prevent the keyboard opening competing with the modal height transition which leads to broken animation.
I delay the activation of KeyboardAwareScrollView using enabled: false and then true after 1 second of delay.
The animation works but the KeyboardAwareScrollView is not working until I blur the input (keyboard collapse) and reopen it.
Hope it helps :)
To Reproduce
Steps to reproduce the behavior:

wrap a form with KeyboardAwareScrollView (enabled: false)
set autofocus on first field
set enabled true after 1 second

For the delay I use this hook:
const useDelayed = (enabled: boolean) => {
  const [value, setValue] = useState(false);
  useEffect(() => {
    if (!enabled) {
      setValue(false);
      return;
    }
    if (value) return;
    setTimeout(() => setValue(true), 1000);
  }, [enabled]);
  return value;
};

Expected behavior
After enabled turns on, it should work as usual.
Smartphone (please complete the following information):

Device: iPhone 15
OS: IOS
RN version: [e.g. 0.73.6]
RN architecture: old
JS engine: Hermes
Library version: 1.11.6

Hi @flodlc 👋

After enabled turns on, it should work as usual.

May I ask you to provide more input here? What is the exact scenario which is not working? When KeyboardAwareScrollView is disabled the keyboard overlaps a focused input and when you make it enabled it's not avoiding a focused input? Or when it becomes enabled and you change focus - it's not reacting on focus changes?

Hi @kirillzyusko, sure I recorded 2 videos to show you 2 cases of behavior that I have.
On this video, I wrap my form with KeyboardAwareScrollView. It competes with the modal animation and leads to a broken modal animation animation (the scroll gets crazy).
https://github.com/kirillzyusko/react-native-keyboard-controller/assets/3781663/7b27f1f2-afc3-484f-958c-1741887b3254
To manage it, I set the KeyboardAwareScrollView enabled=false on mount and set enabled=true only after 1 second.
I expected the KeyboardAwareScrollView to work then, but set enabled is not enough, I have to press out of the input to hide the keyboard and focus again. Then everything work normally.
https://github.com/kirillzyusko/react-native-keyboard-controller/assets/3781663/54cf4b16-58c6-4d86-9121-b7024b732915
Here is how I use it:
const delayedTrue = useDelayed(1000);

return
  (<KeyboardAwareScrollView
    enabled={delayedTrue}
    bottomOffset={10}
    keyboardShouldPersistTaps="handled"
  >
    {...}
  </KeyboardAwareScrollView>
);

So to resume, the problem is that setting enabled after 1 second does not enables the KeyboardAwareScrollView untill the keyboard hide/show again.
In a perfect world, I would like to achieve to have a modal animation without having to disable KeyboardAwareScrollView.
Maybe @gorhom has thought on this usecase ?

@flodlc cool, I understand the second problem now, thanks for sharing videos ❤
This is a definetely bug - I'll try to fix it. I think a fix may be similar to https://github.com/kirillzyusko/react-native-keyboard-controller/pull/399 but may need to adjust code in KeyboardAwareScrollView as well 👍
Thank you for reporting this problem! I'll try to fix it next week 👍

Maybe @gorhom has thought on this usecase ?

I'm always open for discussions and any suggestions for the code changes in my library 👀 Though i think a problem is a bit tricky to solve (because you are animating a view + change a size of this view). But yeah, anyway, I'm open for discussions and potential ways to resolve the problem 👀

Nice, if you need more details feel free to ask.
Good to here that the react-native-keyboard-controller is well maintained and keep improving 💪

@flodlc may I ask you to test https://github.com/kirillzyusko/react-native-keyboard-controller/pull/417 and let me know whether it fixes a problem or not?

It works absolutely how it should !
Thanks a lot for your reactivity 👍

@flodlc thanks, glad to hear it works!
I may release a new library version next week, but if it's blocking you -> you can apply changes from this PR using a patch-package or consume a version directly from main branch 😊

Published in 1.11.7


Fix small grammatical typo in README.md

Just a tiny missing word that I noticed. Thanks for making this library, I'm really excited to start using it!

Thanks! I have no idea how I missed that...