compinit/completions for omz plugins

I believe completions are loaded a bit differently with OMZ and other frameworks.
When adding the following plugin:
ohmyzsh/ohmyzsh path:plugins/macos
I receive the following error:
/Users/jvanhecke/Library/Caches/antidote/https-COLON--SLASH--SLASH-github.com-SLASH-ohmyzsh-SLASH-ohmyzsh/plugins/macos/macos.plugin.zsh:232: command not found: compdef
/Users/jvanhecke/Library/Caches/antidote/https-COLON--SLASH--SLASH-github.com-SLASH-ohmyzsh-SLASH-ohmyzsh/plugins/macos/macos.plugin.zsh:264: command not found: compdef
/Users/jvanhecke/Library/Caches/antidote/https-COLON--SLASH--SLASH-github.com-SLASH-ohmyzsh-SLASH-ohmyzsh/plugins/macos/music:170: command not found: compdef

This also happens with other omz plugins such as git,rails, rake, chruby but also lib/directories.
I know load these plugins after loading the belak/zsh-utils path:completion but I'm not sure if this is correct.

Completions are complicated. Let's talk compinit... compinit works by finding _completion files in your fpath. That means fpath has to be fully populated prior to calling compinit. If you use oh-my-zsh, if populates fpath and runs compinit prior to loading plugins. This is only problematic if you expect to be able to add to fpath later. Conversely, if you wait to run compinit until the end of your config, then functions like compdef aren't available earlier in your config, and oh-my-zsh uses compdef in plugins like the ones you name: git, rails, etc.
TLDR; I just released a big update to my completions plugin in Zephyr that addresses all of this. If you are using antidote, just load this plugin first:
# .zsh_plugins.txt
mattmc3/zephyr path:plugins/completion

@mattmc3 Zephyr pulls completions from zsh-users/zsh-completions, but the one in zephyr's repo is pretty outdated by now.
In zdotdir you mention the following:
### Completions
#
# You may want to add some additional completions to Zsh. Completions look in your fpath
# for completion functions, which are functions named with a leading underscore
# (eg: _git). You need to add all supplemental completions to your fpath prior to
# running `compinit` to use completions functionality properly. You will want to find
# a completion plugin that runs `compinit` for you, or you can run it yourself in
# your .zshrc after antidote loads like this:
#
#   autoload -Uz compinit && compinit
#
###

# With antidote, using Zephyr's completion plugin is recommended. This plugin is meant
# to be run near the TOP of your .zsh_plugins.txt file.
mattmc3/zephyr path:plugins/completion

# zsh-users/zsh-completions is a popular plugin for adding supplemental completions.
# We combine the `path:` and `kind:fpath` annotations here:
# zsh-users/zsh-completions path:src kind:fpath

# Most other compinit plugins should be near the END of .zsh_plugins.txt so that $fpath
# has been fully populated. One such plugin is zsh-utils and its completion subplugin.
# belak/zsh-utils path:completion

If using antidote, why is it preferred to use zephyr's? Can I use only zsh-users/zsh-completions instead? Can I also use the zsh-utils one together with either?

If using antidote, why is it preferred to use zephyr's?

It's not. You can use any completion plugin you want, or none at all. Can you tell me where you found that reference to Zephyr in a .zsh_plugins.txt? I thought I had removed all references to Zephyr in this repo.

Can I use only zsh-users/zsh-completions instead?

I know this can be crazy confusing, so let me state this as clearly as I know how. When we talk about completions, there's two different parts to it.

The first is adding all directories with _mycompletion files to your fpath. That is what plugins like zsh-users/zsh-completions do - makes more completions available.
The second is actually initializing your completions. That's what compinit does. It examines your fpath and initializes the completions. You can do this yourself by autoload -Uz compinit && compinit, or with a plugin like belak/zsh-utils path:completion.

Also would there be any issues if using these too: https://github.com/Aloxaf/fzf-tab, https://github.com/lincheney/fzf-tab-completion and https://github.com/marlonrichert/zsh-autocomplete. Perhaps you could let me know what combination would work best

antidote is plugin agnostic. Use whatever you like. My only recommendation is if you are using Oh-My-Zsh plugins or Prezto modules, you might want to consider using use-omz or use-prezto respectively, as those frameworks have some dependencies that you have to deal with yourself if you don't include those helper plugins.

Can you tell me where you found that reference to Zephyr in a .zsh_plugins.txt? I thought I had removed all references to Zephyr in this repo.

I've already linked this before, but it's on Line 34:
With antidote, using Zephyr's completion plugin is recommended. This plugin is meant
to be run near the TOP of your .zsh_plugins.txt file.
mattmc3/zephyr path:plugins/completion
Ok, so it is indeed preferred to use both zsh-users/zsh-completions and belak/zsh-utils path:completion, in order to make sure the former even initializes, or just do it manually. As for the fzf-tab, fzf-tab-compleition and zsh-autocomplete by Marlon, I actually wanted to ask if they have any interference with the completion plugins that I've spoken above, or it has nothing to do with those.
Thanks for notifying me on use-omz. Is there anything I need to care about when using it? Btw, how does OMZ check the security of a directory, by what method? You mention it here on the use-omz readme:

Oh-My-Zsh by default checks the security of directories in fpath when running compinit.

Ok, so it is indeed preferred to use both zsh-users/zsh-completions and belak/zsh-utils path:completion, in order to make sure the former even initializes, or just do it manually

Whichever way you prefer, but yes - I recommend using both.

As for the fzf-tab, fzf-tab-compleition and zsh-autocomplete by Marlon, I actually wanted to ask if they have any interference with the completion plugins that I've spoken above, or it has nothing to do with those?

I'm familiar with Marlon's excellent Zsh plugins, but have not used any of those myself. If there's interference with using them, I recommend opening an issue with Marlon.

Thanks for notifying me on use-omz. Is there anything I need to care about when using it?

Not really. The docs are pretty clear, in my (not so) humble opinion.

Btw, how does OMZ check the security of a directory, by what method? You mention it here on the use-omz readme:

You can see OMZ's compaudit code here:

https://github.com/ohmyzsh/ohmyzsh/blob/608d62b2a5ee7f3af62dd8f31d47c167bf04547f/oh-my-zsh.sh#L124C1-L133C3
https://github.com/ohmyzsh/ohmyzsh/blob/master/lib/compfix.zsh

One more thing @mattmc3, since you mentioned that use-omz handles completions through compinit, and I don't need to use zsh-utils path:completion at all, what happens if I want to install a plugin like: https://github.com/marlonrichert/zsh-autocomplete where he specifically mentions?
In your .zshrc file:
    Remove any calls to compinit.
    Add near the top, before any calls to compdef

use-omz by default wraps compinit and compdef calls and defers them until the very end of your .zshrc, but it does it in such a way that if you (or a plugin like marlonrichert/zsh-autocomplete) decide you want to make those calls yourself, use-omz will gracefully unwrap those functions and let those calls happen whenever you do them in your config. So basically, while I cannot vouch for how other plugins behave (ie: I am not a user of zsh-autocomplete), it should work just fine and be none-the-wiser that use-omz is adding those wrappers at all.
So, in summary, If you don't include a plugin that handles compinit and forget to call compinit yourself, use-omz will helpfully ensure that call actually happens as a failsafe, and it does it in such a way as to mimic OMZ's behavior where possible. By deciding to include use-omz, the assumption is that's the behavior you want, so it's not a customizable thing. Customizing that would mean crafting your own plugin.

Oh, I see. Thanks for the clear up!

@mattmc3 I noticed a few things and I would still ask for your help since you're really knowledgable on it and it might help out the repo since it's a starter config.
I was adding this plugin https://github.com/Aloxaf/fzf-tab, and it mentioned the following:

make sure fzf is installed

fzf-tab needs to be loaded after compinit, but before plugins which will wrap widgets, such as zsh-autosuggestions or fast-syntax-highlighting

Completions should be configured before compinit, as stated in the zsh-completions manual installation guide.

So this means that I can't rely on use-omz for loading compinit since it will load compinit the very last (before the deferred item), and I need to load fzf-tab after few plugins like fast-syntax-highlighting (which is deferred with antidote, and I believe it will load the last in any case, so no issues there as the position doesn't matter in the plugins txt file), but also autosuggestions, which is at the very bottom in the file, but it will still load before compinit. So what I had to do is enable and rely on belak/zsh-utils path:completion for compinit, in order to perserve required order, let me know if that's correct in the zdotdir config, here's the latest commit: https://github.com/matru/zdotdir/commit/c9f83434d76cf5006bbd4bd132e322a9937c1a45
But one more thing I am struggling with is the following, https://github.com/marlonrichert/zsh-autocomplete mentioned that I should omit compinit from my config:

In your .zshrc file:
Remove any calls to compinit.
Add near the top, before any calls to compdef:

source /path/to/zsh-autocomplete/zsh-autocomplete.plugin.zsh

I believe autocomplete loads compinit itself, does this mean that I should be swapping belak/zsh-utils path:completion with marlonrichert/zsh-autocomplete? and even if it says near the top, it's no issue in the zdotdir config to put it down below, where belak/zsh-utils path:completion now resides, since there will be no one calling compinit or compdef anyways?

Based on what you've described, it sounds like your load order might need to look something like this:
#.zsh_plugins.txt

# Some OMZ plugins
getantidote/use-omz
ohmyzsh/ohmyzsh path:plugins/git
ohmyzsh/ohmyzsh path:plugins/magic-enter
ohmyzsh/ohmyzsh path:plugins/extract

# Plugins before compinit
zsh-users/zsh-completions

# Plugins that claim to run compinit (meaning use-omz won't)
marlonrichert/zsh-autocomplete
# belak/zsh-utils path:completion  # No need to load this if zsh-autocomplete ran compinit

# Plugins that say to load them after compinit
Aloxaf/fzf-tab

# Other stuff that doesn't affect completions
zsh-users/zsh-autosuggestions
zdharma-continuum/fast-syntax-highlighting

This is more support than I'm likely to keep providing in the future because my knowledge of what specific plugins do is out of scope for antidote support. I would generally suggest trying out your config and seeing what works, and tweaking as necessary.

@mattmc3 thanks, I totally understand it, I know I pushed with all the questions. Hopefully someone else also finds our discussion useful.


hystrix-network-auditor-agent should provide both a fatjar and standard dependency

This dependency is used in projects that can provide the javassist dependency, and this will cause issues at runtime:
warning   duplicate-dependency-class         com.netflix.hystrix:hystrix-network-auditor-agent:1.5.9 in configuration 'compile' has 398 classes duplicated by org.javassist:javassist:3.20.0-GA (no auto-fix available)

If a fatjar is required, an -all variant of dependency would be a better solution for providing a library vs standalone jar.

Will take a look at getting this addressed.

I think I correctly got the fatjar working (via shadow plugin and uberJar task) here: https://github.com/mattrjacobs/Hystrix/tree/unbundle-javassist.
Would you be willing to review that @DanielThomas ?  I'm also not sure how to get Gradle to do a release of both the library and standalone jars.  Do you have any insight into that?


can you add image cropping?

Image cropping for qr code image

images_picker includes crop
该邮件从移动设备发送
--------------原始邮件--------------
发件人："bibekmakaju @.>;
发送时间：2021年4月27日(星期二) 下午5:52
收件人："flutter-package/flutter_scan" @.>;
抄送："Subscribed @.***>;
主题：[flutter-package/flutter_scan] can you add image cropping? (#11)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Add out of the box TypeScript support with @babel/preset-typescript

Hi !
I would like to propose to add support for TypeScript by default using @babel/preset-typescript.
I believe this can be done by adding the preset to the babel config and adding .ts in the .test of the babel-loader.
I can make a PR 😉

@etienne-dldc, can you do it, please? Lol Fixing to use this library for work and I'm shocked it doesn't have TS already

Hi @NotoriousGOR, sorry but I'm not using backpack (since quite a long time actually, I opened this issue 3 years ago) and I believe it is not maintain anymore...
If you need to run TS I recommend you to take a look at esbuild-kit/tsx
✌


callback not get called when detect nfc

callback not getting called, when nfc detected. the device play the sound but nothing is happening ...
`
import { Injectable } from "@angular/core";
import { Nfc, NfcNdefData, NfcTagData } from "nativescript-nfc";
import { Subject } from "rxjs";
@Injectable({
providedIn: 'root'
})
export class NfcReaderService {
nfcData = new Subject();
private nfc: Nfc = new Nfc();

constructor() {
    this.nfc.available().then((avail) => {
        this.nfc.enabled().then((on) => {
            if (on) {
                console.log("NFC Enabled!!!");
                this.readNFC();
                this.onTagDiscoverd();
            } else {
                console.log("NFC Not Enabled");
            }
        });
    });
}

public readNFC() {
    this.nfc.setOnNdefDiscoveredListener((data: NfcNdefData) => {
        console.log("Nfc Data: ", data);
        this.nfcData.next(data);
        if (data.message) {
            for (let m in data.message) {
                let record = data.message[m];
                console.log("Ndef discovered! Message record: " + record.payloadAsString);
            }
        }
    }, {
            stopAfterFirstRead: false,
            scanHint: "Scan a tag, baby!"
        }).then(() => {
            console.log("OnNdefDiscovered listener added");
        });
}

public onTagDiscoverd() {
    this.nfc.setOnTagDiscoveredListener((data: NfcTagData) => {
        console.log("Discovered a tag with ID " + data.id);
    }).then(() => {
        console.log("OnTagDiscovered listener added");
    });
}

}
`

I have actually the same problem

Please share a repo instead of a snippet and I'll take a look. Also, please post steps to reproduce this issue.

@EddyVerbruggen
Thank you so much to see you here ! :)
I did a repo just for you <3
https://github.com/Ravaniss/nfcprob
Here is what i have did :

create a project with vue init nativescript-vue/vue-cli-template <project-name>

https://nativescript-vue.org/en/docs/getting-started/quick-start/

Install typescript and nfc package.

copy / paste my vue code.

Use tns run --no-hmr to run the app

pass the phone on the card : I get only the ID from my doStartTagListener function. My doStartNDefListener is not call at all. ^^"

thank you !

@Ravaniss This problem is on Android I guess?
What I'm seeing is when I scan an Nfc tag with your demo (after pressing all buttons) is when a tag was written to, it calls the ndef listener with all data, and if it's blank it calls the other callback.

Yes, it's on Android.
How did you get all data from the thing you scan ? O_O
Am i missing something ? Are you with IOS ?
Don't tell me i've missing something ... xD

I'm testing on Android as well. Perhaps it depends on the type of tag you're scanning.. there are so many of them. But I don't see anything out of order..

Here is what i get with another app, and it's exactly these informations i need like, platform, type of tag and disponible technology
https://ibb.co/0ftrYfW

Looks what I'm getting in the ndef listener. Perhaps try only setting that listener (not the tag listener).

What should i do ?

What should i do ? Because for me, my code is okay. Can you please give me an example ?

Your code is fine for Android. Like I said, when only setting the ndef listener in your demo my testtags read out correctly.

Like this ? https://gist.github.com/Ravaniss/c0f7343a5b9c6978b1be01dcde5d9b39
I get this :
Tag discovered, but no listener was set via setOnTagDiscoveredListener. Ndef: {"id":[4,16,-114,58,41,94,-127],"techList":["android.nfc.tech.NfcA","android.nfc.tech.MifareUltralight","android.nfc.tech.NdefFormatable"]}

I have the same problem here described. Do you discover the solution?

Nope.

I am trying to use this plugin and when I run the demo code to read a tag (using my Samsung S8) I get the following error:
Tag discovered, but no listener was set via setOnTagDiscoveredListener. Ndef: {"id":[4,25,31,-126,-39,91,-128],"techList":["android.nfc.tech.IsoDep","android.nfc.tech.NfcA","android.nfc.tech.NdefFormatable"]}
I added a console.log in the first line of the callback function and it not appears on the logs. It seems the callback function is not called.
Any help?

[UPDATE]
If I set a listener using"setOnTagDiscoveredListener" it will be called correctly when I scan a tag. For example:
OnTagDiscovered Listener set
ENTER TAG LISTENER!!!!!!!!!!!!!!!!!!!!!!!!
Tag discovered! 4,25,31,-126,-39,91,-128 android.nfc.tech.IsoDep, android.nfc.tech.NfcA, android.nfc.tech.NdefFormatable

Then I stopped this listener with "setOnTagDiscoveredListener(null)" and tested to set the listener for "setOnNdefDiscoveredListener". Then when I scan the tag again and I had the following output message:
doStartNdefListener Listener set
Tag discovered, but no listener was set via setOnTagDiscoveredListener.
Ndef: {"id":[4,25,31,-126,-39,91,-128],"techList":["android.nfc.tech.IsoDep","android.nfc.tech.NfcA","android.nfc.tech.NdefFormatable"]}

I am trying to use the setOnNdefDiscoveredListener because it seems to have more information.
Am I using this module the wrong away?


commit and release note naming conventions

What to document
We have no definite naming conventions for either commits or release notes (I don't think we have release notes at all).
In Falco, we have a naming convention for release notes touching rulesets (see: https://github.com/falcosecurity/.github/blob/main/CONTRIBUTING.md#rule-type), but although this repository is the official place for all our plugin rulesets, we haven't something like this here.
At the same time, our changelog generation tool looks for commit messages following conventional commits specifications. For a given plugin, the changelog will filter commit messages in the form of xxx(plugins): ... or xxx(plugins/<plugin_name>): .... However, there is nothing enforcing this at the CI level, not even with a warning, which ends up potentially missing valuable commits in the changelogs.
*Proposals/Idea

Add a CI job checking that:

If a file changes in a plugin/<plugin_name> path, then the commit must follow the xxx(plugins/<plugin_name>): ... message pattern
If a file changes in more than one plugin/<plugin_name> path, then the commit must follow the xxx(plugins): ... message pattern

Check or enforce than the rule(xxx):... commit message format is respected, even in a looser form than what we have in Falco

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten

/remove-lifecycle stale

/remove-lifecycle rotten
/reopen

@jasondellaluce: Reopened this issue.

In response to this:

/remove-lifecycle rotten
/reopen

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

/remove-lifecycle stale

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

@poiana: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/reopen

@Andreagit97: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/remove-lifecycle rotten

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

@poiana: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Building cordova ios causes linker errors

When running:
cordova build ios --verbose --simulator
returns a linker error:
...
duplicate symbol _zipOpenNewFileInZip64 in:
    /Users/timk/repo/phonegap-app-developer/platforms/ios/build/PhoneGap.build/Debug-iphonesimulator/PhoneGap.build/Objects-normal/i386/zip.o
    /Users/timk/repo/phonegap-app-developer/platforms/ios/PhoneGap/Plugins/com.wikitude.phonegap.WikitudePlugin/libWikitudeSDK-simulator.a(libCommonLibrary.a-i386-master.o)
duplicate symbol _zipRemoveExtraInfoBlock in:
    /Users/timk/repo/phonegap-app-developer/platforms/ios/build/PhoneGap.build/Debug-iphonesimulator/PhoneGap.build/Objects-normal/i386/zip.o
    /Users/timk/repo/phonegap-app-developer/platforms/ios/PhoneGap/Plugins/com.wikitude.phonegap.WikitudePlugin/libWikitudeSDK-simulator.a(libCommonLibrary.a-i386-master.o)
duplicate symbol _zipWriteInFileInZip in:
    /Users/timk/repo/phonegap-app-developer/platforms/ios/build/PhoneGap.build/Debug-iphonesimulator/PhoneGap.build/Objects-normal/i386/zip.o
    /Users/timk/repo/phonegap-app-developer/platforms/ios/PhoneGap/Plugins/com.wikitude.phonegap.WikitudePlugin/libWikitudeSDK-simulator.a(libCommonLibrary.a-i386-master.o)
duplicate symbol _zip_copyright in:
    /Users/timk/repo/phonegap-app-developer/platforms/ios/build/PhoneGap.build/Debug-iphonesimulator/PhoneGap.build/Objects-normal/i386/zip.o
    /Users/timk/repo/phonegap-app-developer/platforms/ios/PhoneGap/Plugins/com.wikitude.phonegap.WikitudePlugin/libWikitudeSDK-simulator.a(libCommonLibrary.a-i386-master.o)
ld: 66 duplicate symbols for architecture i386
clang: error: linker command failed with exit code 1 (use -v to see invocation)

** BUILD FAILED **

The following build commands failed:
    Ld build/emulator/PhoneGap.app/PhoneGap normal i386
(1 failure)
Error: Error code 65 for command: xcodebuild with args: -xcconfig,/Users/timk/repo/phonegap-app-developer/platforms/ios/cordova/build-debug.xcconfig,-project,PhoneGap.xcodeproj,ARCHS=i386,-target,PhoneGap,-configuration,Debug,-sdk,iphonesimulator,build,VALID_ARCHS=i386,CONFIGURATION_BUILD_DIR=/Users/timk/repo/phonegap-app-developer/platforms/ios/build/emulator,SHARED_PRECOMPS_DIR=/Users/timk/repo/phonegap-app-developer/platforms/ios/build/sharedpch

It appears that having the zip lib in the content sync plugin and the wikitude simulator is the main source of error.

@timkim Hi Tim, did you find a way around this? I'm having this exact issue with Wikitude and ionic-plugin-deploy.

Hi @fetimo
I'm afraid I don't have a good way around this particular issue. I don't do simulator builds so that's how I've been avoiding this particular problem. I believe you can fix the linker errors within xcode by manually removing the references, but I haven't gotten that to work for me.
I did chat with the wikitude developers about removing the zip references in their simulator but they don't seem to have a fix for that yet.

Closing for inactivity. I expect this will be resolved with more current releases as the wikitude plugin is not included in the master build.


docs: fix link url

Description
The previous link was invalid, causing a 404 - page not found, and I thought a quick fix was needed.

Thanks!


Fix broken doc comments.

@praeclarum Can you take a look please?  Thanks!

@praeclarum Can you take a look please? Thanks!

Thanks you very much!


Echoing option for the Exec task

Expected Behavior
Tasks of type Exec would have a configuration option that makes the build always print out the command to be executed just before executing it.
Current Behavior
Command line printing is available with the --info option, but this:

must be set outside the build script.
applies to all commands executed by the build script.

Context
In my case, I am invoking a compiler via a Command line interface. The compiler takes many options, and takes quite a while to complete. The echo would be useful in two ways:

tell the developer what is happening
allow to reproduce the compilation by hand, if necessary

This use case was previously discussed in the gradle-dev group.

I made a small toy repository to explore the proposed API addition.
My personal favorite for the of the option would be printCmd
https://github.com/eaaltonen/gradle-exec-task/blob/master/build.gradle
, which would accept any "truthy" value.
The feature could also provide quoting or escaping for whitespace, something I was too lazy to make for the toy repository.
https://github.com/eaaltonen/gradle-exec-task/blob/master/buildSrc/src/main/groovy/PrintExec.groovy

Concerning Bash set trace
Bash has long had a tracing feature enabled with set -x. It would be possible to display a consistent trace level co-operatively with bash if the gradle and gradlew executables pass the PS4 (trace level) variable on to the java process.

There were good proposals on how to solve this on the dev list. One is to write a small task and plugin wrapping your tool (which is probably a good idea anyway, because it makes your build scripts more readable). Inside that task you can then log whatever you'd like at any level.
Alternatively, you can add your vote to #1010 so you could get the --info logging for just that one task.
I'm closing this request, as it is very unlikely we'd add another option to Exec with these good alternatives.


High contrast for colors

Hey! Is there an option for color to specify a high contrast color? If not, what is the best way to do it?

Unfortunately, no. This is very rarely used in iOS apps.

It is, a good practice to make the interface more accessible.
WCAG has recommendations on this.
It seems to be cool if the utility has this feature.

Do you work on a project that support high contrast colors?

We are now moving to a new palette of colors in which this support will be)

Can you please show or tell me how your designers will support high contrast color palette in Figma?
For example, there is a button_primary color. Will it be represented in the list of color styles in four variants?

button_primary
button_primary_high_contrast
button_primary_dark
button_primary_dark_high_contrast

Or will each color palette be in a separate Figma file?

Each color palette will be in a separate Figma file:
 light
 dark
 light_high_contrast
 dark_high_contrast

I think, we need to add 2 optional parameters, identifiers of the file containing  light_high_contrast color palette and dark_high_contrast color palette.

I think, we need to add 2 optional parameters, identifiers of the file containing light_high_contrast color palette and dark_high_contrast color palette.

Yes. Do you want to implement it by yourself? ☺

yep, i think i can do it

Closed in #157


Passwordless sudo not working on ubuntu-latest

Description
We have recently encountered issues with passwordless sudo on the ubuntu-latest runner image.
We leverage sudo on ubuntu-latest in quite a few of our workflows, but we are only experiencing this issue in a single workflow.
Our workflow did not change between the previous successful runs, and the recent failed runs. The only changes I see are to the image and version used by the runner.
Platforms affected

[ ] Azure DevOps
[x] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[X] Ubuntu 20.04
[X] Ubuntu 22.04
[ ] macOS 11
[ ] macOS 12
[ ] macOS 13
[ ] macOS 13 Arm64
[ ] macOS 14
[ ] macOS 14 Arm64
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
Latest Successful Run:

https://github.com/deepjavalibrary/djl/actions/runs/7457259653
Image: ubuntu-22.04
Version: 20231217.2.0

Sample Failed Run:

https://github.com/deepjavalibrary/djl/actions/runs/7470948230/job/20330430308
Image: ubuntu-22.04
Version: 20240107.1.0

Is it regression?
yes
Expected behavior
Passwordless sudo should work.
Actual behavior
Passwordless sudo does not work (though we have other workflows where it does work using the same ubuntu-latest runner image)
Repro steps
This is the workflow that we are seeing the issue in https://github.com/deepjavalibrary/djl/blob/master/.github/workflows/native_jni_s3_pytorch_android.yml#L29.
To reproduce, I think one could create a new workflow that runs the steps through the "Install NDK" step (nothing prior to that relies on the repo or custom resources/permissions)

@siddvenk hey, does the path you try to call with sudo really exist?

That may be the issue, did the location of the Android SDK manager change between the runner versions I linked above?
It seems like it may have based on what I can parse from https://github.com/actions/runner-images/issues/8952.
I will test that and report back.

It might be a combination of non-existing path + sudo bug described here

Yes, that was exactly the issue. Thanks for the quick response!


Ordered names by alphabetical order

So that it is easier to see whether the names are in order or not #53

Good call!

Thanks.


Add update highlights docs

Resolves: #1404

I suppose as an example this works. Thanks.

You're welcome 🎉


Originally posted by @nguoithichkhampha in https://github.com/Emotiv/cortex-v2-example/issues/85#issuecomment-616342815
I useed my license key but it didn't  work!

pls show me the error and can you send me the details including your license key via my email<EMAIL_ADDRESS>

pls show me the error and can you send me the details including your license key via my email<EMAIL_ADDRESS>

thank you , i will send you the required info.

@areejhameed , I don't see any email from you. So, I will close this ticket.

hi..
Please, is there an eeg logger example in python to record the eeg signals
to matrix form instead of recording them on an external excel file ?
thanks
best regards
في الثلاثاء، 7 يوليو 2020 في 6:37 م تمت كتابة ما يلي بواسطة Cuong Trinh
Manh @.***>:

Closed #87 https://github.com/Emotiv/cortex-v2-example/issues/87.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Emotiv/cortex-v2-example/issues/87#event-3521059897,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALQJV7BXQCBMNLYCR3FUXQLR2M6MRANCNFSM4MMN7PXA
.

--


ImportError in cuda 12

Hi, ImportError happened when I import TE.
 File "/usr/local/lib/python3.10/dist-packages/transformer_engine/pytorch/__init__.py", line 29, in _load_library
    solib = importlib.util.module_from_spec(spec)
ImportError: /usr/local/lib/python3.10/dist-packages/transformer_engine/transformer_engine_torch.cpython-310-x86_64-linux-gnu.so: undefined symbol: _ZN5torch7LibraryC1ENS0_4KindESsSt8optionalIN3c1011DispatchKeyEEPKcj

The environ is

torch 2.3.0a0+40ec155e58.nv24.03
cuda 12.4
cudnn 90000

I have found this symbol in https://github.com/vllm-project/vllm/issues/5501.
This symbol is defined in  libtorch_cpu.so https://github.com/vllm-project/vllm/issues/5501#issuecomment-2167338928
Could you help me with this? Thanks.

Thank you very much. I've got the source of bug.
To clarify, the test machine is cuda 12.4, torch=2.3.0. And in the beginning, torch is from nvcr:23.10, which is 2.3.0, build TE is built on another machine cuda 12.1, torch=2.2.2, and got this bug.
I've tried to build TE from source, but got another bug cicc is not found.
I've checkout that cicc is in the folder of nvvm in cuda and tried to add the folder of cicc into $PATH, but still got cicc is not found. Do you have any suggestion for this?

Strange that you need to go into the CUDA internals. Can you try setting CUDA_PATH in your environment? Here's a list of common problems when building TE: https://github.com/NVIDIA/TransformerEngine/issues/355#issuecomment-2394353816.

CUDA and cicc is both in my path, I guess this is the machine's problem.
Thank you very much

Hi, thank you very much.
I build TE from source in the exactly same environment. This problem disappears.
Thanks you, again.


LUCENE-10560: Reduce the number of bytes compared while constructing an OrdinalMap.

This changes OrdinalMap construction to work on windows of 4096 terms at a time
and identify shared prefixes within the window, so that the PriorityQueue can
ignore these shared prefixes when comparing its entries.
On the OrdinalMapBenchmark, this made things slightly slower because shared
prefixes within a window are only in the order of 2 bytes, so there are not
enough savings to amortize the additional overhead introduced by the seeks that
try to estimate shared prefixed within the next window.

I tried to run this against a dataset of random byte[16] that all share the same 12-bytes prefix, to simulate the case of IPv6-mapped IPv4 addresses, but unfortunately, this did not speed up the construction of global ordinals even though I'm seeing that it often detects 13-bytes prefixes.

If I hack this further to add the same optimization as #875 on top of the shared-prefix idea, I get a ~25% speedup for the case described above, while neither this nor #875 make this case faster on their own.

Superseded by #1052.


Added comments and slurm job script for convenience during the training.

replicated the comments in c/Makefile to fortran/Makefile
Added some SLURM job script to run each darts version for both c and fortran, respectively in their directories.

c/darts-hybrid.slurm

Jobscript is 24 tasks and 1 thread, is that the intention?  Plus, there’s no -d to aprun, or OMP_NUM_THREADS.
If it is the intention that they modify the script, then please add that to the comment.

c/darts-omp.slurm

Comment says this is the serial version.

fortran/darts-hybrid.slurm

Same comment as c version

fortran/darts-imp.slurm

Same comment as c version


Installation instructions

Hi,
Bups lacks installation instructions.
How would one go about getting dependancies for bups using debian?
A pip package would be nice too.

BTW, a Debian package is now available. See https://github.com/emersion/bups/releases ;-)

BTW, a Debian package is now available. See https://github.com/emersion/bups/releases ;-)


feat: config node email service

Checklist

[ ] make test passes
[ ] tests and/or benchmarks are included
[ ] documentation is changed or added

Affected core subsystem(s)

Description of change

pushed by part to limit number of lines to review at a same time


Some more hardcoded fonts

https://github.com/atom/one-dark-ui/pull/98 is awesome, but there are still hardcoded fonts left here and here. These should use the system font as well.

I've been wondering if having the keybindings in Helvetica Neue was intentional?
Do all (most) fonts support characters like ⌥⌘ :

@simurai If you would inspect that tooltip (or the keybinding examples in the style guide), you would see that it isn't rendered in Helvetica Neue at all. Apparently it doesn't contain the glyphs for those characters and Chrome falls back (at least on my Mac) to a combination of Lucida Grande and Arial. If you change the font-family to system it doesn't change anything, so my guess is SF doesn't have them either. In any case, you don't need to worry about special characters, Chrome will take care of that for you.

@braver Thanks for looking into it.
Ok, let's remove it. I guess Helvetica Neue just got added to override Bootstrap's <kbd> styling in select lists, but I'll change it to just inherit the font family.


pull request for e2e test at 11/10/2016 10:26:10

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Pilot

Disable EVE logging by default in Suricata configs.
Added yaml file for Suricata 4.1

Rust support not added since it is not compatible with DNS logging.


delay between step/pod completion and workflow completion

Pre-requisites

[X] I have double-checked my configuration
[ ] I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
[X] I have searched existing issues and could not find a match for this bug
[ ] I'd like to contribute the fix myself (see contributing guide)

What happened? What did you expect to happen?
UI shows the single step/pod completed successfully at 2024-09-27T04:31:36
but then UI shows big gap to when overall workflow completed successfully at 2024-09-27T04:36:09
Version(s)
3.4.11
Paste a minimal workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
n/a

Logs from the workflow controller
kubectl logs -n argo deploy/workflow-controller | grep ${workflow}

time=\"2024-09-27T04:29:15.202Z\" level=info msg=\"Processing workflow\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:29:15.234Z\" level=info msg=\"Updated phase  -> Running\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:29:15.236Z\" level=info msg=\"Retry node aredactwf initialized Running\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:29:15.237Z\" level=info msg=\"Pod node aredactwf-3720301757 initialized Pending\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:29:15.324Z\" level=info msg=\"Created pod: aredactwf(0) (aredactwf-mystep-3720301757)\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:29:15.324Z\" level=info msg=\"TaskSet Reconciliation\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:29:15.324Z\" level=info msg=reconcileAgentPod namespace=myns workflow=aredactwf
time=\"2024-09-27T04:29:15.370Z\" level=info msg=\"Workflow update successful\" namespace=myns phase=Running resourceVersion=426512752 workflow=aredactwf
time=\"2024-09-27T04:29:25.202Z\" level=info msg=\"Processing workflow\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:29:25.205Z\" level=info msg=\"Task-result reconciliation\" namespace=myns numObjs=0 workflow=aredactwf
time=\"2024-09-27T04:29:25.205Z\" level=info msg=\"node changed\" namespace=myns new.message= new.phase=Running new.progress=0/1 nodeID=aredactwf-3720301757 old.message= old.phase=Pending old.progress=0/1 workflow=aredactwf
time=\"2024-09-27T04:29:25.207Z\" level=info msg=\"node aredactwf message: retryStrategy.expression evaluated to false\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:29:25.207Z\" level=info msg=\"TaskSet Reconciliation\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:29:25.207Z\" level=info msg=reconcileAgentPod namespace=myns workflow=aredactwf
time=\"2024-09-27T04:29:25.230Z\" level=info msg=\"Workflow update successful\" namespace=myns phase=Running resourceVersion=426512956 workflow=aredactwf
time=\"2024-09-27T04:29:35.230Z\" level=info msg=\"Processing workflow\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:29:35.233Z\" level=info msg=\"Task-result reconciliation\" namespace=myns numObjs=0 workflow=aredactwf
time=\"2024-09-27T04:29:35.233Z\" level=info msg=\"node unchanged\" namespace=myns nodeID=aredactwf-3720301757 workflow=aredactwf
time=\"2024-09-27T04:29:35.235Z\" level=info msg=\"TaskSet Reconciliation\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:29:35.235Z\" level=info msg=reconcileAgentPod namespace=myns workflow=aredactwf
time=\"2024-09-27T04:31:39.661Z\" level=info msg=\"Processing workflow\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:31:39.663Z\" level=info msg=\"Task-result reconciliation\" namespace=myns numObjs=1 workflow=aredactwf
time=\"2024-09-27T04:31:39.663Z\" level=info msg=\"task-result changed\" namespace=myns nodeID=aredactwf-3720301757 workflow=aredactwf
time=\"2024-09-27T04:31:39.663Z\" level=info msg=\"node unchanged\" namespace=myns nodeID=aredactwf-3720301757 workflow=aredactwf
time=\"2024-09-27T04:31:39.665Z\" level=info msg=\"TaskSet Reconciliation\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:31:39.665Z\" level=info msg=reconcileAgentPod namespace=myns workflow=aredactwf
time=\"2024-09-27T04:31:39.682Z\" level=info msg=\"Workflow update successful\" namespace=myns phase=Running resourceVersion=426514616 workflow=aredactwf
time=\"2024-09-27T04:31:49.683Z\" level=info msg=\"Processing workflow\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:31:49.686Z\" level=info msg=\"Task-result reconciliation\" namespace=myns numObjs=1 workflow=aredactwf
time=\"2024-09-27T04:31:49.686Z\" level=info msg=\"task-result changed\" namespace=myns nodeID=aredactwf-3720301757 workflow=aredactwf
time=\"2024-09-27T04:31:49.686Z\" level=info msg=\"node unchanged\" namespace=myns nodeID=aredactwf-3720301757 workflow=aredactwf
time=\"2024-09-27T04:31:49.688Z\" level=info msg=\"TaskSet Reconciliation\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:31:49.688Z\" level=info msg=reconcileAgentPod namespace=myns workflow=aredactwf
time=\"2024-09-27T04:31:49.707Z\" level=info msg=\"Workflow update successful\" namespace=myns phase=Running resourceVersion=426514616 workflow=aredactwf
time=\"2024-09-27T04:36:09.656Z\" level=info msg=\"Processing workflow\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:36:09.658Z\" level=info msg=\"Task-result reconciliation\" namespace=myns numObjs=1 workflow=aredactwf
time=\"2024-09-27T04:36:09.658Z\" level=info msg=\"task-result changed\" namespace=myns nodeID=aredactwf-3720301757 workflow=aredactwf
time=\"2024-09-27T04:36:09.658Z\" level=info msg=\"node changed\" namespace=myns new.message= new.phase=Succeeded new.progress=0/1 nodeID=aredactwf-3720301757 old.message= old.phase=Running old.progress=0/1 workflow=aredactwf
time=\"2024-09-27T04:36:09.660Z\" level=info msg=\"node aredactwf phase Running -> Succeeded\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:36:09.660Z\" level=info msg=\"node aredactwf finished: 2024-09-27 04:36:09.66063598 +0000 UTC\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:36:09.660Z\" level=info msg=\"TaskSet Reconciliation\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:36:09.660Z\" level=info msg=reconcileAgentPod namespace=myns workflow=aredactwf
time=\"2024-09-27T04:36:09.660Z\" level=info msg=\"Running OnExit handler: exit-handler\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:36:09.661Z\" level=info msg=\"Retry node aredactwf-1656388105 initialized Running\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:36:09.661Z\" level=info msg=\"Steps node aredactwf-3191187056 initialized Running\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:36:09.661Z\" level=info msg=\"StepGroup node aredactwf-202582218 initialized Running\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:36:09.661Z\" level=info msg=\"Skipping aredactwf.onExit(0)[0].notifyError: when 'Succeeded != Succeeded' evaluated false\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:36:09.661Z\" level=info msg=\"Skipped node aredactwf-2734285361 initialized Skipped (message: when 'Succeeded != Succeeded' evaluated false)\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:36:09.661Z\" level=info msg=\"Step group node aredactwf-202582218 successful\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:36:09.661Z\" level=info msg=\"node aredactwf-202582218 phase Running -> Succeeded\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:36:09.661Z\" level=info msg=\"node aredactwf-202582218 finished: 2024-09-27 04:36:09.661610081 +0000 UTC\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:36:09.661Z\" level=info msg=\"Outbound nodes of aredactwf-2734285361 is [aredactwf-2734285361]\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:36:09.661Z\" level=info msg=\"Outbound nodes of aredactwf-3191187056 is [aredactwf-2734285361]\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:36:09.661Z\" level=info msg=\"node aredactwf-3191187056 phase Running -> Succeeded\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:36:09.661Z\" level=info msg=\"node aredactwf-3191187056 finished: 2024-09-27 04:36:09.661709572 +0000 UTC\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:36:09.662Z\" level=info msg=\"node aredactwf-1656388105 phase Running -> Succeeded\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:36:09.662Z\" level=info msg=\"node aredactwf-1656388105 message: retryStrategy.expression evaluated to false\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:36:09.662Z\" level=info msg=\"node aredactwf-1656388105 finished: 2024-09-27 04:36:09.662286778 +0000 UTC\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:36:09.662Z\" level=info msg=\"Updated phase Running -> Succeeded\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:36:09.662Z\" level=info msg=\"Marking workflow completed\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:36:09.662Z\" level=info msg=\"Marking workflow as pending archiving\" namespace=myns workflow=aredactwf
time=\"2024-09-27T04:36:09.668Z\" level=info msg=\"cleaning up pod\" action=deletePod key=myns/aredactwf-1340600742-agent/deletePod
time=\"2024-09-27T04:36:09.720Z\" level=info msg=\"Workflow update successful\" namespace=myns phase=Succeeded resourceVersion=426517669 workflow=aredactwf
time=\"2024-09-27T04:36:10.372Z\" level=info msg=\"archiving workflow\" namespace=myns uid=d4ea0321-a659-43d7-8ed9-eb839650b452 workflow=aredactwf
time=\"2024-09-27T04:36:10.466Z\" level=info msg=\"Queueing Succeeded workflow myns/aredactwf for delete in 1m4s due to TTL\"
time=\"2024-09-27T04:36:14.745Z\" level=info msg=\"cleaning up pod\" action=deletePod key=myns/aredactwf-mystep-3720301757/deletePod

Logs from in your workflow's wait container
kubectl logs -n argo -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded

\"2024-09-27T04:29:18.477Z\" level=info msg=\"Starting Workflow Executor\" version=v3.4.11
\"2024-09-27T04:29:18.482Z\" level=info msg=\"Using executor retry strategy\" Duration=1s Factor=1.6 Jitter=0.5 Steps=5
\"2024-09-27T04:29:18.482Z\" level=info msg=\"monitoring progress disabled\" annotationPatchTickDuration=0s readProgressFileTickDuration=0s
\"2024-09-27T04:29:18.483Z\" level=info msg=\"Starting deadline monitor\"
\"2024-09-27T04:31:29.504Z\" level=info msg=\"Main container completed\" error=\"<nil>\"
\"2024-09-27T04:31:29.504Z\" level=info msg=\"No Script output reference in workflow. Capturing script output ignored\"
\"2024-09-27T04:31:29.504Z\" level=info msg=\"No output parameters\"
\"2024-09-27T04:31:29.504Z\" level=info msg=\"No output artifacts\"
\"2024-09-27T04:31:29.524Z\" level=info msg=\"S3 Save path: /tmp/argo/outputs/logs/main.log, key: argo_wf_logs/2024/09/27/04/29/aredactwf/aredactwf-mystep-3720301757/main.log\"
\"2024-09-27T04:31:29.525Z\" level=info msg=\"Creating minio client using AWS SDK credentials\"
\"2024-09-27T04:31:29.565Z\" level=info msg=\"Saving file to s3\" bucket=redactbuc endpoint=s3.amazonaws.com key=argo_wf_logs/2024/09/27/04/29/aredactwf/aredactwf-mystep-3720301757/main.log path=/tmp/argo/outputs/logs/main.log
\"2024-09-27T04:31:29.641Z\" level=info msg=\"Save artifact\" artifactName=main-logs duration=116.831623ms error=\"<nil>\" key=argo_wf_logs/2024/09/27/04/29/aredactwf/aredactwf-mystep-3720301757/main.log
\"2024-09-27T04:31:29.641Z\" level=info msg=\"not deleting local artifact\" localArtPath=/tmp/argo/outputs/logs/main.log
\"2024-09-27T04:31:29.641Z\" level=info msg=\"Successfully saved file: /tmp/argo/outputs/logs/main.log\"
\"2024-09-27T04:31:29.659Z\" level=info msg=\"Alloc=11298 TotalAlloc=18244 Sys=33917 NumGC=5 Goroutines=11\"
\"2024-09-27T04:31:29.659Z\" level=info msg=\"Deadline monitor stopped\"

Are there many workflows in the cluster?

@shuangkun
there were 31 running workflows at the time.
note the workflow i ran is not a cronworkflow (just a normal workflow). i'm not overriding defaults for --workflow-workers or any other workers related args, i noticed the queue depth of cron_wf_queue was 35 at the same time as the workflow started but then went to 0 a minute later. all other queue depths were constantly 0. time objects spent waiting in queue was 13s for cron_wf_queue. argo_workflows_operation_duration_seconds_bucket showed 3s at p95. argo_workflows_queue_adds_count was 257 for cron_wf_queue, 95 for workflow_queue, 16 for pod_cleanup_queue

increasing --qps   --burst  --pod-cleanup-workers --cron-workflow-workers --workflow-workers did NOT help

@tooptoop4  As you found at 13690, it is 20 minutes.
Maybe we need to find out where the root problem is. Is your time difference about 5 minutes? Can it be reproduced stably? Is there a simple example?

@shuangkun it can be reproduced stably, have a constant flow of short (ie finishes in 1min) 1 step workflows running. ie at 12.03pm submit 200 wfs, at 12.04pm those prior 200 would have finished so submit another 200, at 12.05pm those prior 200 would have finished so submit another 200, at 12.06pm those prior 200 would have finished so submit another 200, at 12.07pm those prior 200 would have finished so submit another 200....continue that so u have a throughput of 12000 per hour (200 per min). then look at the finished time of the step vs finish time of the wf, time difference i have seen is 10s in best case but around 11mins in worst case

@tooptoop4 Have you tried the 13690 adjustment to alleviate this problem?

@shuangkun the bad news is lowering wf and pod resync periods to around 1-2mins did not help, i still had a case where the delay between step end time and wf end time is around 269 seconds. BUT the good news is i think i've stumbled upon the root cause, read below:
the main container logs show it actually finished doing work (ie my pod running python code) at 21:32:50 (this also aligns with END TIME of the pod step in argo ui)
both main and wait containers switch from kube_pod_container_status_running=1/kube_pod_container_status_terminated=0 to kube_pod_container_status_running=0/kube_pod_container_status_terminated=1 at 21:33:00
BUT kube_pod_status_phase shows running until 21:37:00
workflow finish time in UI shows as 21:37:19
wfcontroller logs (containing 'cleaning up pod') for this pod (so it tried several times, first time is around when i expect workflow should have finished, last time is around when it actually finished!):
{"time":"2024-10-02T21:33:02.331549949Z","stream":"stdout","_p":"F","log":"time=\"2024-10-02T21:33:00.413Z\" level=info msg=\"cleaning up pod\" action=terminateContainers key=myns/mypod/terminateContainers
{"time":"2024-10-02T21:33:27.204261129Z","stream":"stdout","_p":"F","log":"time=\"2024-10-02T21:33:27.202Z\" level=info msg=\"cleaning up pod\" action=terminateContainers key=myns/mypod/terminateContainers
{"time":"2024-10-02T21:33:42.01999347Z","stream":"stdout","_p":"F","log":"time=\"2024-10-02T21:33:30.414Z\" level=info msg=\"cleaning up pod\" action=killContainers key=myns/mypod/killContainers
{"time":"2024-10-02T21:33:57.207610446Z","stream":"stdout","_p":"F","log":"time=\"2024-10-02T21:33:57.205Z\" level=info msg=\"cleaning up pod\" action=terminateContainers key=myns/mypod/terminateContainers
{"time":"2024-10-02T21:34:27.206083759Z","stream":"stdout","_p":"F","log":"time=\"2024-10-02T21:34:27.205Z\" level=info msg=\"cleaning up pod\" action=killContainers key=myns/mypod/killContainers
{"time":"2024-10-02T21:34:27.206088869Z","stream":"stdout","_p":"F","log":"time=\"2024-10-02T21:34:27.205Z\" level=info msg=\"cleaning up pod\" action=terminateContainers key=myns/mypod/terminateContainers
{"time":"2024-10-02T21:34:57.214838677Z","stream":"stdout","_p":"F","log":"time=\"2024-10-02T21:34:57.207Z\" level=info msg=\"cleaning up pod\" action=killContainers key=myns/mypod/killContainers
{"time":"2024-10-02T21:34:57.217688507Z","stream":"stdout","_p":"F","log":"time=\"2024-10-02T21:34:57.217Z\" level=info msg=\"cleaning up pod\" action=terminateContainers key=myns/mypod/terminateContainers
{"time":"2024-10-02T21:35:27.218840968Z","stream":"stdout","_p":"F","log":"time=\"2024-10-02T21:35:27.210Z\" level=info msg=\"cleaning up pod\" action=terminateContainers key=myns/mypod/terminateContainers
{"time":"2024-10-02T21:35:27.21899863Z","stream":"stdout","_p":"F","log":"time=\"2024-10-02T21:35:27.217Z\" level=info msg=\"cleaning up pod\" action=killContainers key=myns/mypod/killContainers
{"time":"2024-10-02T21:35:57.219513886Z","stream":"stdout","_p":"F","log":"time=\"2024-10-02T21:35:57.211Z\" level=info msg=\"cleaning up pod\" action=terminateContainers key=myns/mypod/terminateContainers
{"time":"2024-10-02T21:36:27.215534417Z","stream":"stdout","_p":"F","log":"time=\"2024-10-02T21:36:27.211Z\" level=info msg=\"cleaning up pod\" action=killContainers key=myns/mypod/killContainers
{"time":"2024-10-02T21:36:27.215548187Z","stream":"stdout","_p":"F","log":"time=\"2024-10-02T21:36:27.213Z\" level=info msg=\"cleaning up pod\" action=terminateContainers key=myns/mypod/terminateContainers
{"time":"2024-10-02T21:36:57.217225673Z","stream":"stdout","_p":"F","log":"time=\"2024-10-02T21:36:57.213Z\" level=info msg=\"cleaning up pod\" action=killContainers key=myns/mypod/killContainers
{"time":"2024-10-02T21:36:57.217234973Z","stream":"stdout","_p":"F","log":"time=\"2024-10-02T21:36:57.214Z\" level=info msg=\"cleaning up pod\" action=terminateContainers key=myns/mypod/terminateContainers
{"time":"2024-10-02T21:37:26.49104221Z","stream":"stdout","_p":"F","log":"time=\"2024-10-02T21:37:24.478Z\" level=info msg=\"cleaning up pod\" action=deletePod key=myns/mypod/deletePod
{"time":"2024-10-02T21:37:27.240338159Z","stream":"stdout","_p":"F","log":"time=\"2024-10-02T21:37:27.215Z\" level=info msg=\"cleaning up pod\" action=killContainers key=myns/mypod/killContainers

kubelet logs groaning with things like this:
21:34:29.809574   37233 eviction_manager.go:395] \"Eviction manager: pods ranked for eviction\" pods=[...there are several here including the one im interested in...i redacted...]"}
21:34:39.810514   37233 eviction_manager.go:614] \"Eviction manager: pod failed to evict\" err=\"timeout waiting to kill pod\" pod=\"myns/mypod\""}
21:34:39.810611   37233 eviction_manager.go:205] \"Eviction manager: pods evicted, waiting for pod to be cleaned up\" pods=[\"myns/mypod\"]"}
21:36:30.289954   37233 eviction_manager.go:439] \"Eviction manager: timed out waiting for pods to be cleaned up\" pods=[\"myns/mypod\"]"}
21:36:30.489498   37233 eviction_manager.go:395] \"Eviction manager: pods ranked for eviction\" pods=[...there are several here including the one im interested in...i redacted...]"}
21:36:40.490431   37233 eviction_manager.go:614] \"Eviction manager: pod failed to evict\" err=\"timeout waiting to kill pod\" pod=\"myns/mypod\""}

kubectl events shows:
 8m34s       Warning   Evicted                 pod/mypod                           kubelet, myhost   The node was low on resource: ephemeral-storage.  Threshold quantity:<PHONE_NUMBER>6, available: 5765816Ki.
 7m13s       Warning   Evicted                 pod/mypod                           kubelet, myhost   The node was low on resource: ephemeral-storage. Threshold quantity:<PHONE_NUMBER>6, available: 1525016Ki.
 6m33s       Warning   Evicted                 pod/mypod                           kubelet, myhost   The node was low on resource: ephemeral-storage. Threshold quantity:<PHONE_NUMBER>6, available: 3357484Ki.

so to summarise seems like kubelet was very slow to actually delete the pod, but from my point of view argo should be able to consider the workflow complete once it has sent instruction to terminate the pod (not when it actually detects that the pod was removed)

increasing --qps --burst --pod-cleanup-workers --cron-workflow-workers --workflow-workers did NOT help. one thing that is strange is pod storage fluctuates up to around 29MB and then down to 13MB, and around same time a large dag with 42 pods ran. also around same time argo_workflows_queue_adds_count metric (for workflow_queue added 500 in 5mins, for pod_cleanup_queue went to 75) but the depth never went up, the busy workers never went above 5 and there were never more than 45 workflows across all states in that time!
i'm thinking the wfinformer is incomplete, is there some setting to say just look at all workflows every x seconds even if not in the informer? @shuangkun
@fyp711 do u think my issue could be related to informer missing things like u raised with #13466 ?

@tooptoop4 It looks different from #13466.

I have two suggestions, you can check if the informer listandwatch has failed(timeout), and you can check if the apiserver load is high.

@shuangkun didn't realize there is another informer in https://github.com/argoproj/argo-workflows/blob/54621cc60117cf68183be24322119d85a80bb650/workflow/controller/taskresult.go#L29 will tweak this and report back

Does this only happen when it is large-scale?

no, it happens everyday even if less than 100 (with single node each) workflows are running. have you looked at your argo_archived_workflows table? perhaps u can also see long seconds gap between node end time and workflow end time

It feels like there is a missing call to woc.requeue() in this scenario, so we're having to wait for a relist...? Perhaps in the scenario that all Pods are complete, but all workflowTaskResults are not we don't requeue?

It feels like there is a missing call to woc.requeue() in this scenario, so we're having to wait for a relist...? Perhaps in the scenario that all Pods are complete, but all workflowTaskResults are not we don't requeue?

any idea @jswxstw

I initially suspected it might be the reason mentioned by @Joibel, but in v3.4.11, the workflow does not need to wait for WorkflowTaskResults to complete.
There should be other situations causing the controller to wait for a relist, but I can't think of any possible reasons for now.

Ah, yes... that is true, it isn't about WFTaskResults, but I still think we should have called requeue and didn't.


kv-client(cdc): correct conditions of canceling grpc streams  (#10237)

What problem does this PR solve?

Issue Number: close #xxx
What is changed and how it works?
Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

/retest


ValueError: GEOSGeom_createLinearRing_r returned a NULL pointer  while opening in geopandas

I am using Shapily in verion 1.7.1 and geopandas in version 0.8.1.  Want to open a file in geopandas, a esri shape file in geopandas, but an error message from File "shapely\speedups_speedups.pyx", line 408, in shapely.speedups._speedups.geos_linearring_from_py
is returned:
ValueError: GEOSGeom_createLinearRing_r returned a NULL pointer
Expected behavior and actual behavior.
I was able to open the file before (infact today and did not update any package), only restarted the jupyter kernel. Because of some problems with my raster files (ram usage). The same error message is returned for code in jupyter and in script.
Operating system
OS: Windows 10
Environment: Virtualenv
Installation of shaply via pip (from PyPi)
Version:
Shapily 1.7.1
geopandas 0.8.1
Edit: when installalling the packages new with conda in an conda environment, everythink works just fine.

Hi @Meresmata, that typically means there is something wrong with the GEOS installation / or the version of GEOS that Shapely is finding.
See eg https://github.com/geopandas/geopandas/issues/1652 (note the title about pygeos turned out not to be the issue) and https://github.com/Toblerity/Shapely/issues/919 for recent similar issues.
A workaround (but not really solving the underlying issue of course) is to disable the speedups: import shapely; shapely.speedups.disable().
Can you show the output of geopandas.show_versions() ?
Do you get the same issue if you create a new virtual environment and install shapely and geopandas in it?

Installing everything anew, didn't help.
What seamed to work, was switching shapely form PyPI to https://www.lfd.uci.edu/~gohlke/pythonlibs/#shapely.

I agree with @jorisvandenbossche. Nasty problems like this can happen if you have multiple incompatible installations of GEOS installed on the system. The only solution we have right now is to make sure you get all your packages from the same source, or build from source.

I encounter the same problem today. Using the following codes suggested by @jorisvandenbossche solves the problem! Thank you~
import geopandas as gpd
import shapely
shapely.speedups.disable()

My geopandas version is 0.9.0 and my shapely version is 1.7.1

Hi @Meresmata, that typically means there is something wrong with the GEOS installation / or the version of GEOS that Shapely is finding. See eg geopandas/geopandas#1652 (note the title about pygeos turned out not to be the issue) and #919 for recent similar issues.
A workaround (but not really solving the underlying issue of course) is to disable the speedups: import shapely; shapely.speedups.disable().

Thanks a lot. It does work. But may I ask you why it can be useful, and what's the function of shapely.speedups? And after using disable(), what's the influence on the code, and what will happen using 'shapely.speedups.disable()'? Does the code run slower after using that?


[HierarchyList] Prevent onSelect when defaultSelectedId changed

What package is this for?

[x] React
[ ] Angular

Summary
Currently, when defaultSelectedId is changed or initially set, onSelected is called. However, as the name applies, onSelected should only be triggered by an user. This can cause issues for example when ´defaultSelectedIdofHierarchyListis updated and thus triggeringonSelected` which causes the need to catch such non-user triggered calls.

:tada: This issue has been resolved in version 2.141.0-next.49 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 2.141.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


hotfix isort on logprobs ranks pr

There were some merge ordering issue made the main branch breaking lint. This PR reruns isort and fixes it.

I will merge this as soon as there's a green lint build


Add Slickspaces

[x] Company name
[x] Industry
[x] Company location
[x] Company description
[x] How Elixir is used
[x] GitHub / blog links
[x] Job listings

Thank you @ryanwinchester!


feat: evaluate nested variables

Imagine the following:
a := 'x'
b: = 'y'
c: = '{{a}} & {{b}}`

Expectation:
x & y
Actual:
{{a}} & {{b}}
Test case:
test! {
  name:     evaluate_nested,
  justfile: "
    a := 'x'
    b := 'y'
    c := '{{a}} & {{b}}'
  ",
  args:   ("--evaluate", "c"),
  stdout: "x & y",
}

Is there some technical limitation preventing evaluating nested variables?
Given some pointers would be happy to take a crack at it.

Closing as a duplicate of #11.
There's no technical limitation, it just hasn't been implemented yet. And you can see by the issue number, it's a longstanding request!
I think the best way to implement this is with a special syntax that turns on interpolations inside strings, probably just python's f-string syntax, i.e. f"{{foo}}". This would make it a backwards compatible change, whereas just starting to interpret variables within strings would be a breaking change.
 You might be able to use it as a basis, or at least get some inspiration.


LaTeX syntax highlighting broken with minted and escapeinside

When using minted with LaTeX with its escapeinside feature (see pages 22/23 in the docs), this breaks VS Code's syntax highlighting, and the rest of the file is (mostly) rendered in red.
A minimal example to reproduce the issue
\documentclass{article}
\usepackage{minted}

\begin{document}
\begin{minted}[escapeinside=||]{python}
    print(|\emph{test}|)
\end{minted}

\textbf{\textrightarrow{} Syntax highlighting broken for the rest of the file!}
\end{document}

Outcome on stock config without extensions:

VS Code Version: Code 1.77.1 (b7886d7461186a5eac768481578c1d7ca80e2d21, 2023-04-04T23:20:37.202Z); 1.77.3 (704ed70d4fd1c6bd6342c436f1ede30d1cff4710)
OS Version: Linux x64 6.2.11-arch1-1
LaTeX-Workshop version if you use it:

Originally from @The-Compiler in https://github.com/microsoft/vscode/issues/180692

Also moving this comment over as it hopefully provides additional context:

The "Inspect editor tokens and scopes" feature reveals that VS Code still assumes Python inside the escape:

and then gets stuck in that even past the \end{minted}:

Personally I wouldn't mind much if the syntax highlighting for LaTeX inside the |...| was broken somehow (though that being LaTeX again would be a nice bonus, of course). But the rest if the file being all red (with no way to add some clever comment or something to make it "re-sync", at least I couldn't find anything) makes it very hard to edit things unfortunately. Agreed however that this seems rather tricky.

This issue arises because the Python grammar finds some invalid syntax and gets stuck inside a function call. To manually get out of the trap add
\if 0
)
\end{minted}
\fi

I am afraid we cannot do much to solve the root cause of the issue. It would basically require to duplicate all possibly embedded grammars to add a bail out rule. See the discussion in https://github.com/James-Yu/LaTeX-Workshop/issues/1689 for the C++ grammar. This is of course far beyond the scope of this basic vscode built-in extension to  provide bailed out grammars and language definitions for over a dozen external languages.
@alexr00 A smart solution would be that VS Code implements a bail out rule when embedding a language inside an other grammar.

@jlelong that makes sense, I didn't think that this issue would be solvable from the latex grammar.  However, I don't think we would know when to do the bail out. Sometimes users do write code that should be scoped as invalid or illegal, so we cannot know when to bail out. I'm not sure this issue can be nicely solved with textmate.

@alexr00 What I had in mind is the ability to define a bail out pattern when embedding a language. When this pattern is encountered, we leave the embedded grammar and we go back to the calling one.

@jlelong would this be something that you would define in your textmate grammar at the point that you embed the grammar?

@jlelong Thanks for that manual escape, that's a life-saver for me! :sparkles:
Here was a particularly spicy one:
    \begin{minted}[autogobble,escapeinside=||]{python}
        @pytest.mark.parametrize("a, b, op, expected", [
            pytest.param(1, 2, '+', 3, |\highlightbox{id=}|"add"),
            pytest.param(3, 1, '-', 5, |\highlightbox{id=}|"sub"),
            # ... some more lines ...
        ])
        def test_calc(a, b, op, expected):
            assert calc(a, b, op) == expected
    \end{minted}

    % VS Code workaround
    \if 0
    )))))])
    \end{minted}\fi

@jlelong would this be something that you would define in your textmate grammar at the point that you embed the grammar?

@alexr00 yes exactly. For instance, embedding the Python language typically looks like
{
	"begin": "some_begin_pattern",
	"end": "some_end_pattern",
	"contentName": "source.python",
	"patterns": [
		{
			"include": "source.python"
		}
	]
}

It would be nice if the top level grammar could escape from the Python one when the end pattern is reached. I originally thought a new pattern was needed to trigger the bail out but I believe it will always be the same as the end pattern.
Currently, we provide a modified C++ grammar which includes the bail out pattern. This approach would make it useless. Embedding a grammar would much more robust.

@jlelong I have opened https://github.com/microsoft/vscode-textmate/issues/207 for this. Feel free to close and we can continue discussion there.


请问我应该如何使用struct_pb，将protobuf数据序列化成相应结构体数据

Search before asking

[x] I searched the issues and found no similar issues.

What happened + What you expected to happen
请问我应该如何使用struct_pb，将protobuf数据序列化成相应结构体数据
Reproduction way
Anything else
Are you willing to submit a PR?

[x] Yes I am willing to submit a PR!

已解决


Change base build presets to use libswift=hosttools

This is intended to resolve some condfail issues we've been experiencing from the default bootstrapping-with-hostlibs setting due to module mismatches.

@swift-ci please smoke test

The build issues should be fixed with https://github.com/apple/swift/pull/40285


Add link to documentation in delegationTargetPage

Purpose
Add link to documentation when choosing delegation target.
Checklist

[x] My code follows the style of this project.
[x] The code compiles without warnings.
[x] I have performed a self-review of the changes.
[x] I have documented my code, in particular the intent of the
hard-to-understand areas.
[ ] (If necessary) I have updated the CHANGELOG.

Please add the change to the changelog.


Allow collection or array object on item attribute of foreach element

Fixes gh-1074
Please review this.

Hi @harawata , I withdraw this PR because i found more considerations are need.

OK. Thank you for your work!


If Contact's Account is Organization Account, Campaign Member functionality does not work

Even though our best practice model is that all Contacts have a Household Account and Organizations are through Affiliation, the Campaign Member functionality should still work regardless of Account Record Type (if not, we should explicitly say this in documentation).
Steps to reproduce:

Create Organization Account. Create Contact directly in that Account.
NPSP Settings set to defaults with Campaign Member functionality enabled
Add Contact to Campaign, Status = Sent
Create Opportunity from Contact, Associate to same Campaign
Result: Campaign Member Status remains at Sent instead of updating to Responded as expected

If Contact not already member of Campaign, they are not added.

**lurch: add

Tracking W-009536

Included in beta release version 3.71 (Beta 1) and higher

Included in production release version 3.71


Build to ES module / enable tree shaking

The current dist/browser.js is a monolithic minified CJS bundle.
It is my understanding that this format is only preferable if including SecretJS through a <script> tag -- but when using most forms of frontend build systems (Webpack, etc.) it prevents dead code elimination, considerably inflating the final bundle downloaded by the browser. In my case<EMAIL_ADDRESS>(and the similarly packaged<EMAIL_ADDRESS>account for nearly half the total bundle size - and we use just a few methods from the the bank and compute APIs...
I suggest it would be beneficial if the browser field in package.json pointed to an unminified and/or sourcemapped ESM build instead. That way the library users could do their own optimization.

Would love any contribution you can offer!


core/internal/requestlist: Fix test

This pull request fixes unit test of core/internal/requestlist package.

I'm not sure why you have to extend visibility of fields in internal structure here. Is that to fix any specific issue on testing?

Sorry, I should have clarified that in the commit message. I noticed this when trying to rework unit test of viewstate package in similar manner. The issue is that yaml.Unmarshal cannot set unexported fields. Moreover, it silently ignores any field it cannot match against the input, so the fields are left unchanged. That is why I also changed to use yaml.UnmarshalStrict which returns error in such case.

Summary of changes: rebase with conflict resolution


figure out cors, sessions, cookies, csrf

https://github.com/rs/cors
https://github.com/gorilla/mux/blob/3cf0d013e53d62a96c096366d300c84489c26dd5/middleware.go#L35-L39
https://github.com/gorilla/sessions
https://github.com/gorilla/csrf
https://github.com/gorilla/securecookie
https://github.com/gofiber/fiber/tree/v2.20.1/middleware
https://github.com/gofiber/fiber/tree/v2.20.1/middleware/cors
https://github.com/gofiber/fiber/tree/v2.20.1/middleware/csrf
https://github.com/gofiber/fiber/tree/v2.20.1/middleware/session
https://github.com/unrolled/secure

created issue for csrf: https://github.com/komuw/goweb/issues/28

issue for sessions: https://github.com/komuw/goweb/issues/29

secure cookies: https://github.com/komuw/goweb/issues/31

cookies is already done; https://github.com/komuw/goweb/pull/27


Fission Controller not updating redstone comparator correctly (through block)

Redstone comparator not updating correctly, state change in controller should 'carry' through block. (You can see that mechanics if you put vanilla chest on the one side of a block and comparator on the other, as seen in second screenshot)

Looks like this is working fine: the comparator is reading through the block correctly. The comparator reads the heat level of an unstable build or the energy storage of a stable one ;)


Footer Legal Link: Privacy and Data policy pointing to same page

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Prerequisites

[X] I'm using the latest version of Docusaurus.
[ ] I have tried the npm run clear or yarn clear command.
[ ] I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
[ ] I have tried creating a repro with https://new.docusaurus.io.
[ ] I have read the console error message carefully (if applicable).

Description
In Footer , The Links for Privacy and Data policy  in Legal Section Pointing to Same Page which Privacy policy pointing to!
Privacy  url in code: "https://opensource.fb.com/legal/privacy/"
Data policy url in code: "https://opensource.fb.com/legal/data-policy/"
Here, when I click the Data policy, it's getting redirected to Privacy page.
it's better Have on Link like Privacy and Data policy : "https://opensource.fb.com/legal/privacy/"
User will understand, both are in same page.
if they were different, Data policy link redirection is wrong
Reproducible demo
No response
Steps to reproduce
Go to Footer,
Check Legal Section
Click Privacy
Click Data policy
check their urls, they were pointing to same page Privacy
Expected behavior
If both were really same,
Remove Privacy and Data policy and make it a single link "Privacy and Data policy"
if not same,
No to redirect the Data policy to privacy page, redirect the data-policy to its correct page
Actual behavior
Privacy and Data policy both were pointing to Privacy page,
Data-policy redirected to Privacy page
Your environment

Self-service

[X] I'd be willing to fix this bug myself.

I am willing to contribute,
But need confirmation,
i) whether , if both Privacy and Data policy were same, will make it a single option
ii) if different, need Data policy's url! to add in code

Thanks for reporting.
Asked @zpao to see what we should do

if Any decision Taken, please let me know!, I will contribute in this!
Thanks for the Response

I haven't gotten to update any sites (or fix the fb template) but the data policy is gone and the important non-redundant parts rolled into the privacy policy in the latest update last month. The old url redirects to the privacy policy.
Content was all prescribed by legal teams so we won't be changing any page titles, but on the docusaurus site we can just remove data policy from the footer.

Thanks @zpao
FYI I was about to remove the FB template for Docusaurus v3. I think @antonk52 told me its usage had been discouraged internally for a while in favor of another internal solution.

@KarthickSakthi you can remove the data policy link 👍

Thanks for the response @slorber , I will remove and give a PR


Remove aria-live="polite" when slider is not focused

.slick-list has aria-live="polite" on it, which tells screen readers to speak the content inside whenever it changes. This is great for the most part, but not ideal when you're not interacting with the slider.
For example, imagine a screen reader scrolling down the page, past the slider, and still having the slide content read to them because aria-live exists on the element. It would be confusing to say the least.
I propose removing the aria attribute unless an element inside the slider is focused.

I second the need for this; it is very annoying to have your actions constantly interrupted by the carousel if you are a screen reader user.

+1
agreed this is very annoying for anyone using a screenreader

FYI, I have arrived at a workaround that I am pretty happy with. If you disable autoPlay and then set initialSlide to a random number, then you avoid the problem of the carousel interrupting the screen readers, you still some the variety for revisits, and the users can cycle through the other pictures if they like. The tradeoff of course, is that if you really want the users to see the other slides then they may not see those. However, it is probably better to place that information elsewhere on the page anyway rather than hiding it inside a carousel. For my purposes, it works perfectly, as the slides are more of a background feature (just rotating pictures).
To implement this, just set initialSlide to "Math.floor(Math.random() * (n + 1))", where n is the number of slides.
Hope that helps!

I agree that aria-live should be removed.
I tried the following to remove the attribute, then re-add it when the list has focus. Once focused on the slick list I waited until all slides had been rotated through. The attribute was added and removed appropriately, but the screen reader I use (VoiceOver) didn't read each slide as it changed. Since the live region isn't registered when added via JS the live-region can't be re-enabled on focus.
`			$slickList.removeAttr('aria-live');
		$slickList.on('focus', function() {
			$slickList.attr('aria-live', 'polite');
		});
		$slickList.on('blur').removeAttr('aria-live');`

+1 My client has four (!) Slick sliders on the page, so things are very noisy for us here. ;-)

+1 On Chrome with VO for Mac, as a user tabs through each slide they receive audio feedback telling them the alt attribute of the slide image. However, on Firefox VO is not reading out the slides as they come through.

PR to remove aria live #2843

👍 for total removal of aria-live on the parent, configuration option to kill it.
The W3C has recommendations on accessible carousels which comes pretty close and I'd use that to help drive structure to support a wider audience. Notice the lack of fancy aria roles trying to force inappropriate tab or listbox roles. aria-live is only used to indicate which slide is active (I'd argue is overkill).. also super clean semantic markup is present :)

Closed by https://github.com/kenwheeler/slick/pull/2843


[Feature] Support audio_buffer_size

Allow tweaking this parameter.
Default is 4 MB.
Reference here

Available in 2023-01-30


Remove unused code

cc @zhengbli @mhegazy
@SaschaNaz You may be able to also remove this code in your pr.

👍


Migrate https://kubernetes.io/docs/reference/using-api/api-concepts/ to Concepts section

This is a Feature Request

What would you like to be added
Migrate https://kubernetes.io/docs/reference/using-api/api-concepts/ to Concepts section (possibly to more than one page)
Why is this needed
https://kubernetes.io/docs/reference/using-api/api-concepts/ is describing concepts; they're a little out of place in the reference documentation.
Replace https://kubernetes.io/docs/reference/using-api/api-concepts/ with links to the new pages.
Comments
This is my view of what needs to happen.
Before anyone starts on the changes, I recommend discussing them (eg at a SIG Docs weekly meeting).

/priority important-longterm

/remove-lifecycle stale

/remove-lifecycle stale
Also see https://github.com/kubernetes/website/issues/20075

/remove-lifecycle rotten

Still makes sense to do this
/remove-lifecycle rotten


Fixes

Got error when I received a server pairing notification, it was due to the properties Logo and Img being an int and the Logo of the server being a string with the URL to it - changed those types to string.

Subscribed to the OnServerPairing event, and noticed that PlayerId and PlayerToken wasn't in the properties of ServerFullEventArg - added them since I think that they're necessary there as that's what the event will be used for, for getting that information.

Changes already planned


fix: use hidden directly on paper-item

Codecov Report
Patch and project coverage have no change.

Comparison is base (4514544) 45.89% compared to head (2faace8) 45.89%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1587   +/-   ##
=======================================
  Coverage   45.89%   45.89%
=======================================
  Files          40       40
  Lines        1935     1935
  Branches      308      308
=======================================
  Hits          888      888
  Misses       1047     1047

Flag
Coverage Δ

unittests
45.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/www/ui_components/app-root.js
4.83% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


New Feature: Can you implement mock based on this framework

I thinks the advantage of LEST is that there is no need to compile a lib/dll before using it (compared to gtest, boost.test etc). But the google mock gives an elegant way to implement stubs for testers. Can you add mock feature into the next version?
Another project that implements UT and mock is http://cpputest.github.com. But this project also need to pre-buid a lib/dll before using it. This would make trouble when a project has to support various compilers/os. (e.g., I have found that a gtest lib compiled from VS2010 was not supported by VS2013)

Up to now, I've not been doing mockist testing and I don't think it's likeky I'll add support for mocks to lest itself. However, perhaps someone likes to contribute it as an extension.

Thanks for the pointer to cpputest b.t.w.. It's always good to look at others' approaches.


add annotation for STS support

Added an annotation to odf-operator CSV for STS support.
Ref: https://issues.redhat.com/browse/RHSTOR-5097

@iamniting updated the PR to only add a new annotation to the CSV

/override ci/prow/odf-operator-e2e-aws


Support for "INSERT OR REPLACE"

Hi,
Is there a way to produce "INSERT OR REPLACE INTO" statements with this library?
Ref. https://sqlite.org/lang_insert.html

You'll need to write a custom block for this.

My actual hotfix is:
squel.insert().into("LocalCache").setFields(item).toString().replace(/^INSERT/, "REPLACE");


Can not Connect in iOS

i can not Connect in iOS but it Work in Android. Does anyone fix ít. Thank u vẻ mục

BluetoothEscposPrinter.printQRCode : imageref passed is nốt a CGImageref. New issue


Vulnerability roundup 83: parallel-<IP_ADDRESS>: 2 advisories

search, files

[ ] CVE-2015-4155 (nixos-unstable)
[ ] CVE-2015-4156 (nixos-unstable)

Scanned versions: nixos-unstable: 8130f3c1c2b. May contain false positives.

These have been fixed in versions 20150422 resp. 20150522. Unstable is currently at 20200422.
@ckauhaus I think this can be closed.

Given the versioning scheme and https://github.com/NixOS/nixpkgs/issues/79728 - is this related to a Haskell package? The CVEs refer to GNU parallel.


Can't easily call up help menus from dictation mode

I advocate allowing the help menus to be visible in any mode.
Cases where I wished the help menus were easily accessible:

in dication mode.  Right now, I have to switch out of dictation mode to command mode to be able to bring up the dictation mode context help.  By the time I get there, I've lost my train of thought.

In sleep mode, so that I can look at them while all other commands are being ignored.

This seems like it could be fixed by putting mode:all at the top of the help commands.

Adding 'help dictation' or 'help context dictation mode' sounds good to me. 'help next' and 'help close' are bound while the window is open, even in dictation mode.
I don't know about binding them in sleep mode though, I think the intention there is for Talon to be unresponsive except for the wake command. What would be the reason to want to disable all commands except the help ones? If one wanted to practice the commands while Talon was otherwise ignoring them it looks like that could be achieved by opening the help popup before entering sleep mode. Incidentally "help next" and "help close" etc. seem to work (probably inadvertently) in sleep mode in this case.


SRM relese notes 78619

Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.
What Type of PR is This?

[ ] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screen Shoot.

Preview environment: https://hdh.pr.harness.io/pr-900

Preview environment: https://hdh.pr.harness.io/pr-900


Some call types display no examples

When classifying call types some display examples as expected while others do not. An example is "LAU - Larceny Under $250" from the Worcester dataset.

PR created: https://github.com/codeforamerica/classifyr/pull/96


Make Result.Interface() return an empty string, as is.

What this PR does / why we need it:

Removing the old handling code that converts an empty string to
nil.
Bolster stringmap lookup & or tests (i.e. ar["c"] | "foo").

With this, the semantics for expression: ar["c"] | "foo" are:
bag {} => "foo"
bag {"ar": {} } => "foo"
bag {"ar": { "c":"b" } => "b"
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
https://github.com/istio/old_mixer_repo/issues/934
Special notes for your reviewer:
Release note:

NONE

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-auth.sh
4fe4b462611c72e34231d5565b8782fb22c3e27e
link
/test e2e-suite-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/assign ozevren@

/retest all

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
1bfe9701693ef17bf0a46fa7ffa48c28be63b152
link
/test e2e-cluster_wide-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-cluster_wide-auth

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
1bfe9701693ef17bf0a46fa7ffa48c28be63b152
link
/test e2e-cluster_wide-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/assign @guptasu

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/auto-merge_master.sh
3d91a6fbc56b7824d1be054ea9efae6de72d3e3f
link
/test auto-merge_master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/auto-merge_master.sh
3d91a6fbc56b7824d1be054ea9efae6de72d3e3f
link
/test auto-merge_master

prow/e2e-cluster_wide-auth.sh
3d91a6fbc56b7824d1be054ea9efae6de72d3e3f
link
/test e2e-cluster_wide-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/cc @guptasu

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/auto-merge_master.sh
3d91a6fbc56b7824d1be054ea9efae6de72d3e3f
link
/test auto-merge_master

prow/e2e-cluster_wide-auth.sh
3d91a6fbc56b7824d1be054ea9efae6de72d3e3f
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
ab1bc390378b30bed03709dc71e729ffa6646c64
link
/test e2e-suite-rbac-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/auto-merge_master.sh
3d91a6fbc56b7824d1be054ea9efae6de72d3e3f
link
/test auto-merge_master

prow/e2e-cluster_wide-auth.sh
3d91a6fbc56b7824d1be054ea9efae6de72d3e3f
link
/test e2e-cluster_wide-auth

prow/e2e-suite-rbac-no_auth.sh
ab1bc390378b30bed03709dc71e729ffa6646c64
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
ab1bc390378b30bed03709dc71e729ffa6646c64
link
/test e2e-suite-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/auto-merge_master.sh
3d91a6fbc56b7824d1be054ea9efae6de72d3e3f
link
/test auto-merge_master

prow/e2e-suite-rbac-no_auth.sh
ab1bc390378b30bed03709dc71e729ffa6646c64
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
ab1bc390378b30bed03709dc71e729ffa6646c64
link
/test e2e-suite-rbac-auth

prow/istio-presubmit.sh
20c9df7adbf8c4092b82494f1a8cc3977c19fcf4
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/auto-merge_master.sh
3d91a6fbc56b7824d1be054ea9efae6de72d3e3f
link
/test auto-merge_master

prow/e2e-suite-rbac-no_auth.sh
ab1bc390378b30bed03709dc71e729ffa6646c64
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
ab1bc390378b30bed03709dc71e729ffa6646c64
link
/test e2e-suite-rbac-auth

prow/istio-presubmit.sh
8a6ed91ed80c79415dd9f5bd18e3b507cd96c54b
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/auto-merge_master.sh
3d91a6fbc56b7824d1be054ea9efae6de72d3e3f
link
/test auto-merge_master

prow/e2e-cluster_wide-auth.sh
e7183b74754b18cf9366c5a3962a988d002b7b6d
link
/test e2e-cluster_wide-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Integration Test - Release - 2022/01/26 11:28:11

Auto create for integration test. IssueCommandFlow

@sharanya-rao : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Docs Build status updates of commit ea8ffb7:
:warning: Validation status: warnings

File
Status
Preview URL
Details

csidevdocs-public/IntegrationTest/BuildIntegrationTestFiles/ChangeSentToAuthor.md
:warning:Warning

Details

csidevdocs-public/IntegrationTest/BuildIntegrationTestFiles/ChangeSentToAuthor.md

Line 4, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.
Line 4, Column 8: [Warning: duplicate-titles - See documentation] Title 'VS Code Authoring Extension' is duplicated in: 'Demo/demo.md(4,8), Demo/v-caxian/AuthorNotification.md(4,8), Demo/v-caxian/auto-merge.md(4,8), Demo/v-caxian/auto-merger.md(4,8), IntegrationTest/BuildIntegrationTestFiles/ChangeSentToAuthor.md(4,8)'. Titles must be unique within a docset.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel