Revisiting div class/id shorthand

As of #137 (which as far as I can tell fixes the ambiguity issue outlined in #35 and #28) I don't see any reason why the shorthand syntax for classes and ids can't be expanded to allow the case with no element tag such as .awesome-class#unique-id instead of div.awesome-class#unique-id.
I'd be happy to look into making a PR to add this functionality if you wouldn't be apposed to this syntax now.

Good idea!
The only issue would be the interaction with named attributes. Currently class/id shorthands and named attributes can be interleaved in an arbitrary way, so e.g.
div contenteditable? #unique-id dir="rtl" .awesome-class {}

is valid syntax.
If we do the obvious thing and allow omitting the element name everywhere, then
contenteditable? #unique-id dir="rtl" .awesome-class {}

would be valid syntax. That's not ambiguous but it could be confusing.
I think an easy solution would be to say that any classes/ids must come before named attributes. That eliminates the confusing example I gave above, and I think it was an accident that the interleaving was allowed in the first place.
What do you think @zth0? If you're happy with this tweak then I'm happy to take a PR :slightly_smiling_face:

The way I was planning to go about it would have been to only allow omitting element name if only if the first attribute of the element is a class or id shorthand such that
.awesome-class contenteditable? dir="rtl" #unique-id {}
#unique-id contenteditable? dir="rtl" .awesome-class {}

is valid syntaax (still allowing any order of class and id attrs beyond the implicit div) but
contenteditable? #unique-id dir="rtl" .awesome-class {}

isn't (which prevents it from being confusing.)
I'm not sure if you meant allowing omitting element name even without any attrs but I'd prefer not to go about it this way as I think this causes more breakage than is necessary.
For example blocks with no element name would instead be wrapped in a div https://github.com/lfairy/maud/blob/f652784adbdd57d1510e83fd17ed2a888655eb8b/maud/tests/basic_syntax.rs#L30-L39 would generate the html hello<div> ducks geese</div> swans
I'm not sure if this matches what you were thinking but I think that going about it this way instead would prevent this from breaking any old code and should be simpler to implement.

Opened PR #173 with my suggested implementation, let me know what you think and if I missed anything or you would rather your idea.

Oh I forgot about plain blocks. That makes sense to me!

BTW, issues should stay open until the PR has been merged.


Replace Guzzle with Requests

We're 2 major versions behind on Guzzle (#289) and we can have a simpler interface and greater compatibility with Requests library: http://requests.ryanmccue.info/docs/why-requests.html

We should also clean up the simple_request method (and swap it out with the request method that has realm/etc).


docs: Ignore Helm values, update spelling list

It's a pain for devlopers to have to update the spelling list each time they add a new Helm value. Let's ignore these when running the spell-checker. Then we can also update (trim down) the list of exceptions.

docs: Ignore Helm value names for spellcheck
docs: Trim down spelling list

I'm struggling to backport this to v1.13. It seems our tooling on that branch does not understand this new directive. Running make -C Documentation on the first commit yields the following error: helm-values.rst:8: ERROR: Unknown interpreted text role "spelling:ignore"

Running make -C Documentation on the first commit yields the following error: helm-values.rst:8: ERROR: Unknown interpreted text role "spelling:ignore"

This should be addressed by the change in this PR on Documentation/check-build.sh. Unless the rstcheck version in 1.13 is too old? I'll look into it and backport.

Turns out this was more complex than I thought; but backports to 1.12, 1.13, 1.14 are now all done.


CPU spinning on windows

Describe the bug
Process is spinning forever in https://github.com/dotnet/interactive/blob/0e90328dd36e15ea60f8c3959f93369fde9db670/src/Microsoft.DotNet.Interactive/Connection/KernelCommandAndEventReceiver.cs#L80
Please complete the following:
Which version of .NET Interactive are you using? (In a notebook, run the #!about magic command. ):

OS

[x] Windows 11
[ ] Windows 10
[ ] macOS
[ ] Linux (Please specify distro)
[ ] iOS
[ ] Android

Browser

[ ] Chrome
[ ] Edge
[ ] Firefox
[ ] Safari
[ ] None

Frontend

[ ] Jupyter Notebook
[ ] Jupyter Lab
[ ] nteract
[ ] Visual Studio Code
[ ] Visual Studio Code Insiders
[x] Visual Studio
[ ] Other (please specify)

Memory Dump
Available offline ping me on Teams, file is 541MB and GitHub only allows 25MB.

Well one issue is that you're ignoring null values from ReadLine and continuing the loop. A null value means the stream has reaching EOF.
https://source.dot.net/#System.Private.CoreLib/src/libraries/System.Private.CoreLib/src/System/IO/StreamReader.cs,793


Flux Demo References sandbox

https://github.com/keptn/lifecycle-controller/blob/3708cb31dca6d8fb179bf8e46aa422ced3b877ff/examples/flux/config/flux-config.yaml#L9
Should be updated to new URLs

Would you mind opening a pr for that?


[TW#13516] Wifi Disconnect Loop

Lately after a few hours of running the esp32 goes into a disconnect loop.
A crash used to occur on:

I (22425788) wifi: ap_probe_send over, resett wifi status to disassoc

See log
Ever since esp-idf 058eb26574a41d0be7fcbae554b1236ec6147854, the esp32 is going into a wifi disconnect loop instead of a crash.
See log. The last 10 lines in this log file repeat until a reset happens.
We have tested esp_wifi_disconnect(), which properly disconnects and reconnects.
See log
Except on those wifi: ap_probe_send over, resett wifi status to disassoc
This problem occurs on a DOIT board with the esp-wroom32, Pycom LoPy and SiPy. We also tested this on 4 different routers.
Another disconnect loop on both a DOIT and LoPy log where wifi log level is set to verbose. This happend after we updated esp-idf to 7ed8c665471200613552e113fd0c1e2d017ea8f7
What can we do about this problem? We would like to recover from this disconnect. A crash is less problematic because after a restart the esp32 functions again.
The same issue is posted on esp32.com

I was also getting SYSTEM_EVENT_STA_DISCONNECTED events from WiFi with the following start sequence. Basically, WiFi would almost never connect; very few exceptions (1 out of thousands of attempts).

esp_wifi_init(...)
esp_wifi_set_mode(WIFI_MODE_STA)
esp_wifi_set_storage(WIFI_STORAGE_RAM)
esp_wifi_set_auto_connect(false)
esp_wifi_set_config(ESP_IF_WIFI_STA, ...)
esp_wifi_start()
esp_wifi_connect()

Then I changed to esp_wifi_set_auto_connect(true) and while it does not auto connect (the connect call is stell required), this works without problems as far as I can see....

...and BTW, it also works without the autoconnect call.

We added a wifi deinit to try and circumvent the disconnect loop.
static void reinit_wifi(void *param)
{
	ESP_LOGD(TAG, "Stop, Deinit Wifi");
	ESP_ERROR_CHECK(esp_wifi_stop());
	ESP_ERROR_CHECK(esp_wifi_deinit());

	ESP_LOGD(TAG, "Init, Start Wifi");
	ESP_ERROR_CHECK(esp_wifi_init(&cfg));
	ESP_ERROR_CHECK(esp_wifi_set_storage(WIFI_STORAGE_FLASH));
	ESP_ERROR_CHECK(esp_wifi_set_mode(WIFI_MODE_STA));
	ESP_ERROR_CHECK(esp_wifi_set_config(WIFI_IF_STA, &wifi_config));
	ESP_ERROR_CHECK(esp_wifi_start());

	esp_wifi_set_ps(WIFI_PS_NONE); // Disable powersave

	ESP_LOGD(TAG, "Restart Wifi Done");
	vTaskDelete(NULL);
}

This function is started as a task, after 10 consecutive disconnects.
We tested this function by restarting the router. This caused 10 consecutive disconnects and then the ESP32 reconnected to the router and the internet. See log
It seems I (81906) wifi: ap_probe_send over, resett wifi status to disassoc also occurs when resetting the router.
This build ran from 21-6-2017 17:30 till 23-6-2017 on a DOIT and a LoPy
The disconnect loop occurred three times on both devices.
LoPy: log
DOIT: log
The disconnect loops and subsequent crashes occurred on 6 different times. These are the last time marks in the log files before the crash:
DOIT
I (14567551) Statistics: [21-06-17 20:06:56Z] Uptime: 000.04:02:38	IPv4: <IP_ADDRESS>	Free Heap: 17140	Temperature: 75
I (9736161) Statistics: [22-06-17 16:21:57Z] Uptime: 000.02:42:07	IPv4: <IP_ADDRESS>	Free Heap: 75276	Temperature: 76
I (7312241) Statistics: [22-06-17 18:25:33Z] Uptime: 000.02:01:43	IPv4: <IP_ADDRESS>	Free Heap: 75948	Temperature: 75

LoPy
I (23643342) Statistics: [21-06-17 22:09:54Z] Uptime: 000.06:33:54	IPv4: <IP_ADDRESS>	Free Heap: 55524	Temperature: 41
I (4682685) Statistics: [22-06-17 01:18:33Z] Uptime: 000.01:17:53	IPv4: <IP_ADDRESS>	Free Heap: 62288	Temperature: 41
I (12137265) Statistics: [22-06-17 23:27:11Z] Uptime: 000.03:22:07	IPv4: <IP_ADDRESS>	Free Heap: 75264	Temperature: 41

My code has a control flow aus outlined below: I can confirm that the connect calls yield a disconnect event with reason 201 very often. It takes e.g. 5 or 8 attempts to successfully connect. However, the first connect attempt after a reset via button appears to be always successful -- but not necessarily after the "hard reset" which make flash announces.
ESP32 Rev 0 here.

startup:
  tcpip_adapter_init()
  esp_wifi_init()
  esp_wifi_set_storage()
  esp_wifi_set_mode()
  esp_wifi_set_config()
ondemand:
  WAIT_FOR_DEMAND
  esp_wifi_start()
  esp_wifi_connect()
active:
  PROCESS_DEMAND
  CHECK_DEMAND_OR_TIMEOUT
  IF (demand) GOTO active
  esp_wifi_disconnect()
  esp_wifi_stop()
  GOTO ondemand

@HubbyGitter We have no trouble connecting to the AP. There are certain situations where calling esp_wifi_connect() is not enough. Our Wifi event handler can successfully recover from a disconnect, even the reinit_wifi() has successfully run. mentioned in our previous post:

See log

We enabled CONFIG_SW_COEXIST_ENABLE, this does not have a effect on the occurrence of the disconnect loop.
Our system ran this weekend on the DOIT and LoPy. 9 Disconnect loops occurred
I (2339213) Statistics: [24-06-17 17:56:45Z] Uptime: 000.00:38:50	IPv4: <IP_ADDRESS>	Free Heap: 139816	Temperature: 74
I (32786244) Statistics: [25-06-17 03:04:19Z] Uptime: 000.09:06:17	IPv4: <IP_ADDRESS>	Free Heap: 74476	Temperature: 74
I (10469024) Statistics: [25-06-17 06:00:27Z] Uptime: 000.02:53:36	IPv4: <IP_ADDRESS>	Free Heap: 38792	Temperature: 73
I (69754) Statistics: [25-06-17 06:08:20Z] Uptime: 000.00:01:00	IPv4: <IP_ADDRESS>	Free Heap: 78924	Temperature: 74

I (38835507) Statistics: [25-06-17 10:28:41Z] Uptime: 000.10:47:07	IPv4: <IP_ADDRESS>	Free Heap: 66060	Temperature: 41
I (11640467) Statistics: [25-06-17 14:45:12Z] Uptime: 000.03:13:51	IPv4: <IP_ADDRESS>	Free Heap: 34316	Temperature: 40
I (674877) Statistics: [25-06-17 14:58:18Z] Uptime: 000.00:11:05	IPv4: <IP_ADDRESS>	Free Heap: 79044	Temperature: 40
I (1662877) Statistics: [25-06-17 20:40:20Z] Uptime: 000.00:27:34	IPv4: <IP_ADDRESS>	Free Heap: 78648	Temperature: 41
I (8036827) Statistics: [25-06-17 23:17:55Z] Uptime: 000.02:13:47	IPv4: <IP_ADDRESS>	Free Heap: 78080	Temperature: 41

These lines from reinit_wifi are never reached (log)
	ESP_LOGD(TAG, "Restart Wifi Done");
	vTaskDelete(NULL);

@Resultfactory I'd appreciate if you elaborated a bit. When is calling esp_wifi_connect()` not enough?
Maybe I should have mentioned that the control flow stops the WiFi and starts from there when an event occurs which does not lead in the right direction.

@HubbyGitter that is our question as well. Our Wifi works fine, until this Disconnect loop happens Log. On every disconnect event, esp_wifi_connect() is called. After 10 consecutive disconnects we try to restart the wifi with reinit_wifi() which ends up triggering the WDT.
This weekend for example, the system was online for 10hours 48minutes (Log.

@Resultfactory If disconnect event happens, do not need to reinit WiFi, just call esp_wifi_connect() to reconnect.

@rojer For me, it does not matter why a reconnect takes place -- lost connection or intended disconnect. The first connect after system boot works well, and after that, I'm running into (finite) 201 loops, which do succeed eventually (e.g. as I write this, on the fourth attempt). I'm stopping WiFI but not reinitialising it in my FSM if something goes wrong and also, there'll be a short delay. The latest updates as of now have not changed the behaviour substantially.

FWIW, we're aware of this bug and we're trying hard to get this fixed before the 2.1 release. - ESP_Sprite on esp32.com

@FHFS Thank you for sharing this piece of critical information.

@HubbyGitter We tested your workaround for reconnecting to the Wifi AP. You call a esp_wifi_stop & esp_wifi_start. We have tried doing the same. For the record we scan BLE advertisements. When a 201 disconnect loop starts we start counting to 10, when 10 is reached we call esp_wifi_stop & esp_wifi_start. The call to esp_wifi_start never returns and a WDT is generated.
We also preformed this test over the weekend with BLE turned off. The same 201 disconnect loop occurs, but we are able to recover by calling esp_wifi_stop & esp_wifi_start.

@Resultfactory I don't see it as a workaround to stop the WiFI if it delivers an unexpected event. It doesn't come with too much extra costs (the most expensive stuff happens on wifi init), saves a case distinction or two, and gets you back to a consolidated state (with reasonable likelihood).
I have no idea what "count to ten" means (not an empty loop from 1 to 10, hopefully) and no, I'm delaying between wifi stop and wifi start, not between error and wifi stop -- wifi stop delivers an asynchronous event, for which I first wait (with a generous timeout). Still, there's a delay before the retry. Aggressive retries are rarely helpful, especially since a retry's justification is the hope that something changed in the meantime.
Yes, I'm in the robust code fan club :registered:... :white_check_mark:

@HubbyGitter Thanks for the suggestion, we will test adding one second delay between the stop and start. Although the test we did without BLE recovered nicely without delay from a 201 disconnect loop with stop start.

Hi @Resultfactory I think this issue already fixed in release 2.1

Any update? Is this problem solved now?

@FayeY
Today we encountered our first disconnect loop in a few weeks. Our code had changed alot(we don't continuously scan ble advertisements anymore), this is why we could not be certain if esp-idf v2.1 fixed this issue.
See line 336 of our log
The last message came in on

9-8-2017 14:17:59> Device: [dev01], Data:[{"Uptime":"000.00:47:00", "Connects":1, "Disconnects":0, "KeysReceived":0, "OpenDoors":0, "InvalidKeys":0, "FreeHeap":56420, "Temperature":41, "IPv4":"<IP_ADDRESS>"}]

The disconnect loop keeps repeating, sometimes it finds the AP and the state is set to run. But then disconnects.

W (3668260) BEAST: restartWifi -> done
E (3668260) BEAST: Unhandled event 3
W (3668270) BEAST: network_status_changed: esp_wifi_connect on SYSTEM_EVENT_STA_START
I (3668400) wifi: n:4 0, o:1 0, ap:255 255, sta:4 0, prof:1
I (3668400) wifi: state: init -> auth (b0)
I (3668400) wifi: state: auth -> assoc (0)
I (3668410) wifi: state: assoc -> run (10)
I (3669470) wifi: connected with linksysTest, channel 4
D (3669470) BEAST: WiFi RSSI: -61
I (3672460) wifi: state: run -> auth (2c0)
I (3672460) wifi: n:4 0, o:4 0, ap:255 255, sta:4 0, prof:1
E (3672460) BEA*ST: SYSTEM_EVENT_STA_DISCONNECTED (107), Reason 2

Hi is there any update on this? any workarounds? this seems to be a critical bug in our project.. restarting the esp wifi during mid transmission is a big bummer!!

HI @ricksondpenha is this issue easy to reproduce or not? According to the log line88, the RSSI is -71, it means the WiFi signal is week, I guess the AP (the router) is far aways from the device (esp32). It disconnects in 336 because esp32 receives a de-auth packet from AP, then the esp32 can't find the AP. So could you help to check the following things:

How far is the AP from ESP32?
Is the mobile easy to connect the AP?
If the issue is easy to reproduce, check whether the mobile phone can find the AP when ESP32 fails to find the AP (when the reason code is 201).

Closing due to lack of response. Please feel free to reopen it if the issue persists and you can supply more details.


Add linux-arm tarball package to release build

PR Summary
Create linux-arm tarball package in our release build.
Also moved the Linux-x64 tarball creation to Ubutntu 14.04, because Start-PSBuild adds additional symbolic link files when running on Red Hat Family distros.
Note that linux-arm can only be built on Ubuntu, so the tar-arm package will also be generated from the Ubuntu 14.04.
PR Checklist
Note: Please mark anything not applicable to this PR NA.

[x] PR has a meaningful title

[x] Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[NA] User facing Documentation needed

[NA] Issue filed - Issue link:

[x] Change is not breaking
[NA] Make sure you've added a new test if existing tests do not effectively test the code changed

[NA] Add [feature] if the change is significant or affectes feature tests

"linux-arm can only be built on Ubuntu" - why?

@anmenaga It's from build.psm1: https://github.com/PowerShell/PowerShell/blob/master/build.psm1#L288
I don't know if that has been changed now.

@TravisEz13 Your comment has been addressed. Can you please take another look? Thanks!


[Bug] Does not generate matching functions correctly

rng.hpp, in /include/ folder:

File generated in /src/ folder:

(This issue also occurs when choosing other definition-generating commands when the files are in different folders)

Nevermind just tried to generate in the same folder it also fails. Can't figure out the reason.

Same issue. This was working correctly for me until maybe 1-2 months ago, but now it's doing this.

This is strange.  The behavior happens when I access a remote workspace from my Mac, but NOT when I connect from Windows.  Could it be confused by a path internally?

Just to add more information, this is happening to me on a local machine running Ubuntu 22.04

For me it was happening on a Windows 10 local machine

Okay, this is nuts.  Today it works just fine with absolutely no changes to my workspace or versions.  I wonder if it's actually some sort of state issue.

This behaviour just appeared on my Linux machine, after working correctly just seconds ago.

https://github.com/microsoft/vscode-cpptools/issues/1162
CPPtools can move functions to the corresponding cpp file by right clicking a function -> refactor now. Can't do batching though.


Develop/Integrate kube-rbac-proxy

Reference: https://github.com/brancz/kube-rbac-proxy

We have two different options：

using kube-rbac-proxy
developing a simple authentication middleware.

@Abirdcfly before we really fork and update kube-rbac-proxy, maybe implement core functionalities in this bc-explorer via middleware ?

Because we may deploy bc-explorer in other non-kubernetes environments in the future, we should adopt option 2 and write our own middleware for authentication to facilitate expansion.


assert_path doesn't work with live navigation

I've run into a few places where I've tried to use assert_path and it hasn't produced the results I've expected.
I can try to put together a reproducible example if that would help, but I think you'd be able to reproduce these results using a generated LiveView. Basically, anywhere the generated tests use assert_patch are places where assert_path would fail.
A few examples:

I have a <.link patch={~p"/thingy/new"}> in my app. If I click_link on that link and then try to assert_path(~p"/thingy/new"), the assertion fails because the path is still the original ~p"/thingy".
I have a form where you enter a value. If the value is valid, we to a push_patch to the same route, but with the value included as a query param (i.e., push_patch(socket, to: ~p"/my/current/path?value=42")). If I try to assert_path(session, ~p"/my/current/path", query_params: "value=42"), I get an error because the query params are not present.
I show an edit form in a modal (like the liveview generator produces). After saving the changes, the code does a push_navigate back to the original route. However, in the test, after clicking the Save button, assert_path fails because the path is still the edit path. Every other assertion I make shows that the modal was closed and I'm back on the original page with updated values, but the path is wrong.

It looks like assert_path is using conn.request_path, but PhoenixTest's follow_redirect isn't actually updating and returning the conn, so the request_path doesn't change. Given that, I'm not sure what the best solution for this problem is, but it makes it so that assert_path is not usable with live navigation.

Thanks @randycoulman! Yes, this makes sense. We're just relying on conn.request_path to get the "current" path. We'll have to update that to handle patches.


Could you share the WEI dataset and the training code for the network that simulates OSN's noise?

I admire your experiment very much, but I have encountered some troubles when trying to implement the algorithm.

Thank you for your admiration. We will upload the code for training simulated OSN network and the WEI dataset ASAP.

The WEI dataset can be downloaded from this link: https://pan.baidu.com/s/1GYL3Zaom9r2TjzPhkVOjwQ?pwd=fdww

Thank you for sharing your code! But I'm still confused about parts of the code.

osn about wechat, weibo, whatsapp train detail and datasets downdloade link.
The description of the adversarial sample algorithm used in adversarial training in the source code seems inconsistent with the original text.


Design - Compiled output size

Hi @tinganho
I just reviewed I10ns for my needs, I love it and I considered using it until I realized that the compiled translation function was huge for each key, and makes it a deal-breaker for client-side projects with many translations.
Have you considered not pre-compiling the json and use it directly at runtime?

@bbenezech I try to keep it as compact as possible. for example a string with no complex translation (i.e. pluralization, date formatting etc.). It is just a string getter.
function () {
   var str = '';
   str += 'hello world';
   return str;
}

It can however store some localization data on the output, that can be rather large. Though it would be large even if you only used JSON. Some way or another the localization data must be there :wink:.
For perf reasons I would not use the JSON directly. It compiles the MessageFormat strings and I wouldn't during runtime wan't to parse the MessageFormat strings. That would be a perf hit.
I recommend to use all.js file in your server. And all individual language files en-US.js etc if you are on a client.


Improve test coverage for DiscoverFederation

DiscoverFederation is a core function in our server components but we have 0% test coverage for it. We should fully test that function just to make sure things work expected.

This is solved by both #744 and #860


arrow key support

being on a laptop makes it hard to use h,j,k,l keys without the touchpad getting in the way, so arrow keys are preferable for me. would it be possible to allow cursor to move with arrow keys instead?

Hey! I added these lines in the cursor.gd file, under the _input(event) function on line 87. It seems to be working. I didn't get any issues but I have not tested it that much.
	if Input.is_key_pressed(KEY_UP):
		move_line(-1)
		accept_event()
	if Input.is_key_pressed(KEY_DOWN):
		move_line(+1)
		accept_event()
	if Input.is_key_pressed(KEY_LEFT):
		move_column(-1)
		accept_event()
	if Input.is_key_pressed(KEY_RIGHT):
		move_column(+1)
		accept_event()


Augment raw_entry API for indexing use case

I'm writing a string-interning data structure in a memory-constrained environment.  The strings effectively have 'static lifetime, so I don't need to support deallocation.  Therefore, I just append null-terminated strings to a Vec<u8> buffer and identify a string by its (u32) offset into this buffer.
Then, we can query a string by its identifier by starting at the given offset and finding the null byte.  But, we'd also like to see if a string is already in the buffer and get its offset if so.  I'd like to use hashbrown for maintaining this relation from String to u32 without duplicating each string in memory twice.
The raw entry API is almost there for supporting this.  When looking up a string, we can compute its hash and then use RawEntryBuilder::from_hash.
struct Offset(u32);

impl Hash for Offset {
     fn hash<H: Hasher>(&self, h: &mut H) {
         panic!("We shouldn't be hashing the offsets directly!");
     }
}

struct InternedTable {
    buf: Vec<u8>,
    index: HashMap<Offset, ()>,
}

impl InternedTable {
    fn lookup(&self, key: &str) -> Option<u32> {
        let key_hash = ...;
        let result = self.index.raw_entry().from_hash(key_hash, |offset| {
            let offset = offset.0 as usize;
            key.as_bytes() == &self.buf[offset...min(offset + key.len(), buf.len())]
        });
        result.map(|(k, v)| k)
    }
}

However, doing the same for insertions doesn't quite work.  The essential issue is that the raw entry API only lets us control the hash of a single key, and inserting may require recomputing hashes of other keys when resizing.
impl InternedTable {
    fn insert(&mut self, key: &str) -> u32 {
        let key_hash = ...;
        let entry = self.index.raw_entry_mut().from_hash(key_hash, |offset| { ... });
        let vacant_entry = match entry {
            // String is already in the table, so return its existing offset.
            RawEntryMut::Occupied(entry) => return *entry.key(),
            RawEntryMut::Vacant(entry) => entry,
        };

        let offset = self.buf.len() as u32;
        self.buf.extend(key.as_bytes());
        self.buf.append(0u8);

        // Panics here from `Hash` implementation called from `RawTable::resize`
        vacant_entry.insert_hashed_nocheck(key_hash, Offset(offset), ());
        offset
    }
}

Today, I get around this by sneaking in a pointer to buf via a thread-local to the Hash implementation.  I could also stash a Rc<RefCell<...>> to the buffer on the hash builder for the same effect.  However, both of these solutions are ugly, and given how close it is, it feels to me like the RawEntry API should support this use case.
Let me know if accommodating this is acceptable and I can submit a PR.  It looks like it should be pretty easy since RawTable already takes in a hasher: impl Fn(&T) -> u64 for many of its methods.

That sounds good, I would be happy to accept a PR which adds a new method to RawVacantEntryMut that allows passing in a hasher function like RawTable does.
You should be able to make it so that the dummy Hash implementation is not required at all.

I've run into a hitch with insert_with_hasher: I would still like access to the hasher of the map, so I can hash with the configured hasher.
Specifically, I'd like an adjustment from
pub fn RawVacantEntryMut::insert_with_hasher<H>(
    self,
    hash: u64,
    key: K,
    value: V,
    hasher: H,
) -> (&'a mut K, &'a mut V)
where
    H: Fn(&K) -> u64,

to
pub fn RawVacantEntryMut::insert_with_hasher<H>(
    self,
    hash: u64,
    key: K,
    value: V,
    hasher: H,
) -> (&'a mut K, &'a mut V)
where
    H: Fn(&K, &S) -> u64,

The impl I'm doing is an interner that requires information outside of the hashmap to properly hash the keys. [gist]
(While we're (potentially) touching the function API, is there a reason for it to take Fn rather than FnMut?)

You can keep the hasher outside the map and use () as the hasher in the map.


Check if layout is really enabled

https://github.com/Planning-nl/flexbox.js/blob/213dff8d788229e42b60bfbb6f89784c8965ed4b/src/FlexTarget.ts#L90
It could have been updated and then disabled

Is already checked in layoutFlexTree


Add CommandException to Mark and unmark command

Coverage increased (+0.6%) to 86.274% when pulling 3a583691b6468c9882686b764be7088bf8ac8053 on luishengjie:master into fbf8cdf3b739e07105831df84f7a3ef95df20d43 on CS2103JUN2017-T4:master.


Bump async-http-client to 3.0.1

Description
Bump async-http-client to 3.0.1 to resolve CVE-2024-53990.
Release note

General Changes

Bump async-http-client to 3.0.1 to resolve CVE-2024-53990.

This PR has:

[X] been self-reviewed.
[] added documentation for new or modified features or behaviors.
[X] a release note entry in the PR description.
[] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[] added or updated version, license, or notice information in licenses.yaml
[] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[ ] been tested in a test Druid cluster.

@cryptoe hello, could I please get a review?

Hi @kfaraz , could you please take a look at this PR? thank you


Generate new sql client form swagger containing instance pools and usages changes.

Generated new sql client which adds new instance pool and usages changes.
Tests have been recorded showing its end to end usage.
An instance pool is a “resource container” or a set pre-allocated virtual machines organized in an isolated private cluster.
Azure SQL managed instances will be able to be provisioned and deployed within an instance pool and consume it’s allocated capacity.

@johnpaulkee

Please follow step 8 in instruction. It will really help us a lot to review your PR if it contains sdk_metadata<rpName>.txt which is generated by generate.ps1

Please update Version and PackageReleaseNotes in your csproj file

Sure thing @erich-wang. Thanks for providing links to instructions.
I’ll go ahead and make those updates when possible.

Hi @erich-wang, I've gone ahead and updated the review based on your feedback.
Thank you.

Thanks @erich-wang !


[Feature] limit a notification method's use by time of day.

⚠ Please verify that this feature request has NOT been suggested before.

[X] I checked and didn't find similar feature request

🏷 Feature Request Type
UI Feature
🔖 Feature description
it would be great to be able to change and/or limit a notification method by time of day.   In my specific case I would like to specify notifications by telegram during business hours but switch to another, less invasive, notification outside of business hours. Telegram doesn't allow me to mute a specific  bot for specific hours and I can't mute the telegram app because I get notifications I want to be interrupted for outside of business hours from a different bot.
✔ Solution
per notification method time limits and ability to specifify alternative notification method, or per monitor notification method scheduling (this would probably be better).
❓ Alternatives
limiting notification disturbance at the end point (my phone)
📝 Additional Context
No response

Going to cross reference #233, and I think time of day settings have been requested specifically before, but I was unable to find it.

The most flexible way to handle this would be by specifying timeperiods and assign these to notifications of monitors. Thats the way nagios handles this kind of request.
For ease of use a timeperiod 24x7 could be defined and assigned to each notification of each monitor.
It would make sense to have different notification timeperiod per monitor and/or notification channel.


Add gitleaks cli command

Proposed changes:

add gitleaks bin from zricethezav/gitleaks:v7.6.1 to Dockerfile image
add gitleaks command to firewatch cli
add GitleaksConfig to handle setup and teardown of gitleaks detect scans:

add default paths for expected secrets, scan results, and scan source paths
fetch latest detection patterns and remove during teardown
remove firewatch report scan downloads during teardown

Supports LPTOCPCI-175

@amp-rh if this is a work in progress, can you add "WIP" to the title?

I receive a Cloudflare blocked message when trying to view the details of the failed sonarqube scan:

I think the code looks good so far, I would like to see the docs (README and docs/*) updated in this PR to describe how to use this and what results from it. This will help the review process and will be needed in the long run anyway.

Just pushed, so just let me know if it needs any changes.

/retest sonarqube


Getting Authentication Error

Hi, I am getting 401 error. I have tried both APIs information from App Store Connect API and In-App Purchase. Both didn't worked for me. I got key id, issuer id and bundle id correctly. Not sure if I am loading p8 file correctly having Developer Permissions. Check this out:
def read_private_key(file_path):
    with open(file_path, "rb") as key_file:
        signing_key = key_file.read()
    return signing_key

The error I get is while verifying receipt data:
Traceback (most recent call last):
  File "d:\Bots\sandrastone763\test7.py", line 41, in <module>
    response = client.get_transaction_history(transaction_id, revision, request)
  File "C:\Users\hp\AppData\Local\Programs\Python\Python310\lib\site-packages\appstoreserverlibrary\api_client.py", line 635, in get_transaction_history
    return self._make_request("/inApps/v1/history/" + transaction_id, "GET", queryParameters, None, HistoryResponse)
  File "C:\Users\hp\AppData\Local\Programs\Python\Python310\lib\site-packages\appstoreserverlibrary\api_client.py", line 490, in _make_request
    raise APIException(response.status_code)
appstoreserverlibrary.api_client.APIException: 401

The App Store Server API uses the key under In-App Purchase. Is this in the Sandbox environment?

In-App Purchase Key worked. Wasn't working on Windows while development but worked on Linux server.

In-App Purchase Key worked. Wasn't working on Windows while development but worked on Linux server.

Hi did you do anything before it worked on your Linux server? I'm facing the same problem and i'm testing on Ubuntu server, but always get 401


From private repo

@Taojunshen : Thanks for your contribution to the Azure documentation! The author, @andredm7, has been notified to review your proposed change.


[bounty] automating official brew update

/bounty 80
basically update https://github.com/mediar-ai/screenpipe/blob/main/.github/workflows/release-cli.yml to properly automate official brew too when ran
(if linux is too hard just skip for now, focus on macos)
@Anshgrover23 want to give a shot?

@louis030195 I can do this - but I need to know what permissions the PAT token in the GitHub CI has.

/attempt #692

@krushnarout can you re open a PR to actually make this work?
this does not work https://github.com/mediar-ai/screenpipe/actions/runs/11958669798

Sure, I'll reopen it.

@louis030195 I found the solution after opening a discussion https://github.com/orgs/Homebrew/discussions/5753. They explained that the duplicate PR happened because someone else also created a PR, so there's not much you can do about that.
They mentioned that the code is correct, but you should remove the entire brew setup. GitHub Actions runners already have Homebrew installed, so there's no need to manually specify the URL or SHA checksum.
https://github.com/orgs/Homebrew/discussions/5753#discussioncomment-11346494
Should I open a new pull request?

@louis030195 I found the solution after opening a discussion https://github.com/orgs/Homebrew/discussions/5753. They explained that the duplicate PR https://github.com/mediar-ai/screenpipe/actions/runs/11958669798 happened because someone else also created a PR, so there's not much you can do about that.
They mentioned that the code is correct, but you should remove the entire brew setup. GitHub Actions runners already have Homebrew installed, so there's no need to manually specify the URL or SHA checksum.
https://github.com/orgs/Homebrew/discussions/5753#discussioncomment-11346494
Should I open a new pull request?

sure

@krushnarout fyi fixed it https://github.com/mediar-ai/screenpipe/commit/02e3e9fc7de6ca98aacdd5040b1483f5e00de188

@krushnarout fyi fixed it 02e3e9f

Great! Nice to see this working 🚀


Update inProgress observable and MsalGuard in msal-angular

Previously, when (a) using path routing, and (b) when the user attempts to access a protected route upon first using the app, the MsalGuard is run before any eventCallbacks are registered with msal-browser. This meant that events in MsalGuard were not being captured by the eventCallback or the inProgress$ observable, which in turn meant that components dependent on the inProgress$ observable did not have access to all updates. This did not appear to be an issue with hash routing.
This PR:

Updates the MsalGuard to subscribe to the inProgress$ observable, allowing events in the MsalGuard to be captured
Changes the _inProgress Subject to a BehaviorSubject, allowing the most recent InteractionType to be available upon subscription

Future work:

Investigate whether the msalSubject$ requires to be changed also

Coverage decreased (-1.2%) to 81.366% when pulling 2f29cb3f2b9cd36e8503ea45f9cf2a4c1a263801 on angular-interaction-fix into 2e6ee2df66baa47d4ad77cb29c94454680d668b0 on dev.


Cannot switch to EE using bash m-switch-to-ee

I'm downloading EE from a private repo. Here's what the repo section of my config.yaml looks like.
repository_url:
  # [To apply changes: init-project -fc]
  ce: "https://github.com/magento/magento2.git "
  ee: "https://github.com/LCind/magento2ee.git"

From my host machine, executing bash m-switch-to-ee returns the following:
C:\Projects\vagrant-magento>bash m-switch-to-ee
+ [[ -f /c/Projects/vagrant-magento/lib/php/php.exe ]]
+ php_executable=php
+ echo php
+ [[ ! -f /c/Projects/vagrant-magento/magento2ce/magento2ee/app/etc/aliases_to_classes_map.json ]]
+ set +x
EE codebase is not available

@LCIJJ Do you have this file /c/Projects/vagrant-magento/magento2ce/magento2ee/app/etc/aliases_to_classes_map.json ? This is indirect check to make sure that EE codebase is available, feel free to change this condition to any other file that exists in your EE repo.

This work. Thanks.

Magento CE codebase should be  in /var/www/magento2ce
Magento EE codebase should be in /var/www/magento2ce/magento2ee
Then try to run suggested command m-switch-to-ee -f

From "magento2ce" directory I downloaded and installed EE via composer:
composer create-project --repository-url=https://repo.magento.com/ magento/project-enterprise-edition magento2ee
After installation completed, I ran m-switch-to-ee -f command and the following error displays accessing Admin area via browser.

The problem is that if Magento EE codebase is checked out via composer, it does not contain tools necessary for linking/unlinking so it is impossible to switch to EE and back.
Current vagrant project is created for developers and it is assumed that developers will work with git repositories.
If you just need to get composer-based EE installation running, then go to <vagrant_project_root> and execute omposer create-project --repository-url=https://repo.magento.com/ magento/project-enterprise-edition magento2ce (note, that directory name should be magento2ce, not magento2ee).

This worked.


Canvas element not successfully cloned

When the clone is appended to the <body> it doesn't draw the old canvas image onto a new canvas.

This seems to be because the Node.cloneNode doesn't retain the canvas contents.  Kind of a bummer.
It'd be possible to work-around this by cloning it so that we copy the rendered shapes into an image and then blit that image into the new canvas element.  Found some jquery code to do that here: https://gist.github.com/adouglas/5266778
I'd need this in my project too.

Here's how the canvas misbehaves in the react-sortable-hoc main example (the one at the project root):

I found a way to fix this.  I'll post a PR here soon.
Here's how it works after my fix:

https://github.com/nurpax/react-sortable-hoc/tree/canvas-drawimage

My PR is ready.  Just seems like PRs are not going anywhere.
See https://github.com/clauderic/react-sortable-hoc/pull/421#issuecomment-416328346
I'm using my own fork of react-sortable-hoc in my project as I really needed this fix.


Unit testing and refactoring of object pool loading

Started to create some unit testing for loading iop. I am starting to refactor the Object Pool Reader implementation to assign the unit tests more direct to the different object types. More results will follow soon as I am in vacation.

Also I suggest having a look at the failed pipelines, they seems to have some suggestions as well

Yep, completely agree. Keep in mind it's still under work. Forgot to remove that debug stuff. But as you mentioned with injecting the hex into single functions, I'm refactoring right now @Thom-de-Jong "read" function into single object type readings to be able to do it. So stay tuned. This was more or less a progress commit rather than a merge request (still draft).

This was more or less a progress commit rather than a merge request (still draft).

Hahah no worries, you requested my review twice so I thought maybe you were in a hurry and wanted some feedback 😄. Other than that sounds good, looking forward to the changes!

Ah lol hahah, yep. I got confused to assign reviewers with #28 .  So I was wondering why you are assigned. Later I found out it was this PR and I confused the tabs in chrome and I reassigned you. But thank you for your review!


/update does not respond to a slash command upon relaunch

Either remove the slash version or add case for this

fixed as of version fa36036


Added space between TitleBlock and a logo

[x]  added a space-between between the Title text block and an icon, so it matches a Figma design.

Before:

With applied changes:

✅


WebSubmit: Set_Embargo optional and functional

websubmit: Set_Embargo optional and functional

Check if file for date exists. This allows to not meet
IOError exception if the field creating the file is
optional and has not been filled.

Fix a bug where the status was set to an incorrect value.

Signed-off-by: Guillaume Lastecoueres<EMAIL_ADDRESS>

@tiborsimko @kaplun, I would like to ask you, if you could tell me, if this function is working or not. I am not familiar with the concept of the "status". And I would appreciate if you could confirm me that I didn't break anything. Thanks in advance.

I think the code is good to go :+1:

@kaplun, Thank you for the review :smile:

Thanks, added @kaplun as reviewer, amended commit log message, and merged as 9cbca888671824968984d995141991b8ad11ff13.


M5Stack core gray random behaviour reading SD using latest SDUpdater with Latest esp32 for Ardunio

Updated to the latest build of esp32 for Ardunio last week, web site says 2.0.3 but the platforms.txt file says its 2.0.4. Updated to your latest Updater today. Compiled the menu.bin program and flashed to m5stack. First time it worked, hitting the power reset it sort of worked and after each reset I will see the main menu with no files, or some files without the icons but selecting them won't load.  Diving in deeper I'm seeing a bunch of sd card read warnings and errors. see output from console below. Looking at esp32 github for SD issues I cant seen to find many but I did see your name appear in a couple of issues that seem to be related. Are you seeing the same issues or is there a workaround available that you know of? I've checked that the sd cards are not corrupted and tried different types. Pretty sure is a SD library or SPI issue.  I'm using Visual Studio with VMicro...Thanks Iain
rst:0x1 (POWERON_RESET),boot:0x17 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:1
load:0x3fff0030,len:1344
load:0x40078000,len:13732
ho 0 tail 12 room 4
load:0x40080400,len:3608
entry 0x400805f0
[     1][D][Button.cpp:42] Button(): Button on pin 39, invert=1, debounce=10ms
[     1][D][Button.cpp:42] Button(): Button on pin 38, invert=1, debounce=10ms
[     4][D][Button.cpp:42] Button(): Button on ��� 37, invert=1, debounce=10ms
[    12][D][esp32-hal-cpu.c:214] setCpuFrequencyMhz(): PLL: 480 / 2 = 240 Mhz, APB: 80000000 Hz
ESP32-Chimera-Core initializing [Board=M5Stack_Core_ESP32] [Variant=m5stack_core_esp32]
[    86][D][ESP32-Chimera-Core.cpp:93] begin(): Enabling LCD
[   100][W][LGFX_AutoDetect_ESP32.hpp:415] _read_panel_id(): [LovyanGFX] [Autodetect] read cmd:04 = 000000e3
[   101][W][LGFX_AutoDetect_ESP32.hpp:1237] autodetect(): [LovyanGFX] [Autodetect] M5Stack
[   257][D][ESP32-Chimera-Core.cpp:276] sd_begin(): Enabling SD from TFCARD_CS_PIN #4 at 25000000 Hz from core #1
ESP32-Chimera-Core started
[   290][D][M5StackUpdater.h:211] _fsBegin():  Checking for SD Support (pin #4)
[   291][D][M5StackUpdater.h:217] _fsBegin(): SD Successfully mounted (pin #4)
[   296][I][esp32-hal-i2c-slave.c:234] i2cSlaveInit(): Initialising I2C Slave: sda=22 scl=22 freq=100000, addr=0x15
[   306][D][esp32-hal-i2c-slave.c:498] i2c_slave_set_frequency(): Fifo thresholds: rx_fifo_full = 28, tx_fifo_empty = 4
[   316][E][Wire.cpp:260] getClock(): Bus is in Slave Mode
[   321][E][Wire.cpp:308] beginTransmission(): Bus is in Slave Mode
[   327][E][Wire.cpp:331] endTransmission(): Bus is in Slave Mode
[   333][E][Wire.cpp:260] getClock(): Bus is in Slave Mode
Welcome to the M5Stack SD Menu Loader!
M5Stack SD Updater initializing...
M5StackSam loaded with 8 labels per page, max 96 items
Has PSRam: false
[   359][I][menu.h:148] heapState():
RAM SIZE:	333.84 KB
FREE RAM:	264.15 KB
MAX ALLOC:	107.99 KB
[   403][W][menu.h:658] checkMenuTimeStamp(): Menu.bin has an obsolete time set (2022-06-03 11:14:12), will use this sketch build date to set the clock
[Hobo style] Clock set to an obsolete source (this sketch build): June 03 2022 13:36:24 (Friday)
[   454][I][menu.h:386] listDir(): Listing directory: /
[   455][D][menu.h:399] listDir():   DIR :  /cert
[   455][D][menu.h:399] listDir():   DIR :  /data
[   457][D][menu.h:399] listDir():   DIR :  /.registry
[   462][D][menu.h:399] listDir():   DIR :  /bmp
[   467][D][menu.h:399] listDir():   DIR :  /mod
[   471][D][menu.h:399] listDir():   DIR :  /System Volume Information
[   477][D][menu.h:399] listDir():   DIR :  /mp3
[   482][D][menu.h:425] listDir():   IGNORED FILE:  /tetris.jpg
[   487][D][menu.h:399] listDir():   DIR :  /jpg
[   492][D][menu.h:399] listDir():   DIR :  /json
[   496][D][menu.h:425] listDir():   IGNORED FILE:  /buddies.txt
[  1001][W][sd_diskio.cpp:174] sdCommand(): no token received
[  1100][W][sd_diskio.cpp:180] sdCommand(): crc error
[  1200][W][sd_diskio.cpp:180] sdCommand(): crc error
[  1300][W][sd_diskio.cpp:180] sdCommand(): crc error
[  1400][W][sd_diskio.cpp:180] sdCommand(): crc error
[  1501][W][sd_diskio.cpp:180] sdCommand(): crc error
[  1600][W][sd_diskio.cpp:180] sdCommand(): crc error
[  1700][W][sd_diskio.cpp:180] sdCommand(): crc error
[  1800][W][sd_diskio.cpp:186] sdCommand(): token error [17] 0x54
[  1801][W][sd_diskio.cpp:180] sdCommand(): crc error
[  1900][W][sd_diskio.cpp:180] sdCommand(): crc error
[  2000][W][sd_diskio.cpp:180] sdCommand(): crc error
[  2100][W][sd_diskio.cpp:180] sdCommand(): crc error
[  2200][W][sd_diskio.cpp:180] sdCommand(): crc error
[  2300][W][menu.h:444] listDir(): [WARNING] No /menu.bin file found
[  2301][W][sd_diskio.cpp:180] sdCommand(): crc error
[  2400][W][sd_diskio.cpp:186] sdCommand(): token error [13] 0x76
[  2400][E][sd_diskio.cpp:621] ff_sd_status(): Check status failed
[  2406][I][menu.h:386] listDir(): Listing directory: /
[  2406][W][sd_diskio.cpp:186] sdCommand(): token error [13] 0x17
[  2412][E][sd_diskio.cpp:621] ff_sd_status(): Check status failed
[  2418][W][sd_diskio.cpp:180] sdCommand(): crc error
[  2522][E][vfs_api.cpp:293] VFSFileImpl(): opendir(/sd/) failed
[  2522][E][menu.h:389] listDir(): Failed to open directory
[  2583][W][sd_diskio.cpp:180] sdCommand(): crc error
[  2683][D][fsformat.h:165] hasMeta(): [JSON]: no currentMetaFile /json/.json
[  2683][I][menu.h:148] heapState():
RAM SIZE:	333.70 KB
FREE RAM:	262.97 KB
MAX ALLOC:	107.99 KB

hey @ifrew thanks for your feedback
I just did a test using 2.0.3-RC1 (which is known to have problems with SD) and 2.0.3 (which fixes SD problems) on my old M5Stack Classic (the one with 4MB flash) and I get a correct file listing in both situations.
These are the settings I've used to flash the sketch:

I'll need mode information on your configuration in order to reproduce the issue you're describing.
However, in the logs you provided, the init sequence claims the SD Card is correctly mounted:
[ 257][D][ESP32-Chimera-Core.cpp:276] sd_begin(): Enabling SD from TFCARD_CS_PIN 4 at 25000000 Hz from core 1
ESP32-Chimera-Core started
[ 290][D][M5StackUpdater.h:211] _fsBegin(): Checking for SD Support (pin 4)
[ 291][D][M5StackUpdater.h:217] _fsBegin(): SD Successfully mounted (pin 4)

Here's a checklist:

Remove the M5 bottom and any attached sensor, only keep the USB cable, and try again, does it still fail ?
Scandisk/repair the SD Card from a PC/Mac
Try with a different model of SD Card

if none of those work, then I'll need much more information about the situation e.g. exact model of m5stack, OS version, arduino version, all librarires versions, sd card model, partition size, files count, etc, etc

Some random observations I've made during the bug hunt with SD driver:
Firmwares compiled with a different version of the SD driver may no play well together.
e.g. flashing a binary compiled with espressif package 1.0.6 from a launcher compiled with espressif package 2.0.3 will cause problems with partition size and incomplete SPI init sequence.
There's also an edge case with platformio+espressif package 2.0.1 that bricks the M5 when any pre-1.0.6 binary is loaded, the resulting crash loop is so fast that even flashing becomes a challenge :-)
Fortunately this version isn't referenced anymore by plaformio so it doens't have to be supported, but the situation still exists.
Troubleshooting
Whenever something odd happens, you should always power-cycle the M5 + eject/reinsert the SD Card, to confirm that the issue is persistent and not a consequence of a previous bootloader conflict between mismatched espressif packages.
The reason of this behaviour is because at some stage of the recent SPI changes, the SD Driver adopted an inverted logic towards the CS pin.
As a consequence when sd-updating from a binary compiled with 1.0.6 to a binary compiled with a more recent version, the loaded binary will keep the pin state from the previous runtime.
Moreover, if a sd-loadable application needs to write on the SD Card after this type of error, corruption may occur.
So every test made right after a scandisk/repair should exclude any sd-loaded application that writes on the SD-Card in order to be valid!
This is why ejecting / power-cycling / reinserting is sometimes necessary to confirm the issue is in the code and not a consequence of a cold-boot conflict.
Custom boards URLs
Make sure you're using the official package URL in Arduino preferences (Additional Boards Manager URLs) and not the one from M5Stack which appears to lag behind and may be bundled with an old version of the SD Driver.

Thanks for the quick reply! It's early here in Seattle but I followed your troubleshooting tips. I had already made a couple of changes to my esp32 core to try and fix it after finding and reading issues related to the SD driver in github namely bug numbers 6103 and commenting out the 2 lines referenced in 6081 but they didn't help. When the device is first flashed it always works. However, if you reset the power button a few times, after the 3rd time things start going wrong. My application that uses the SD card and another spi device sensor as well as the display works fine reading and writing to the SD card so I had assumed it was a problem with the latest builds for esp32 for Arduino and your code. However, I hadn't thought to try your code without my spi sensor. So I flashed another device I have here without the sensor and your code works perfectly even loading my code and subsequently using the A button to restart and load your code. I did it multiple times . So my issue with your code is due to conflicts of using another spi device in the mix. Interestingly though, I haven't had any issues reading or writing to the SD card from my app, at least yet. If I erase the m5stack completely and reflash my app, without first flashing yours, and then install yours from my app using the A button and loading menu.bin that's when things go wrong when I have the other spi device attached. Without the other spi device it works a treat. My other spi device uses the HSPI bus so seems I have an SPI issue with persistency issues. Hmm... going to have to think about this. If you want, I'll leave this open for now in case other people have similar issues until I find the problem. If you want me to close it let me know. Thanks!

sorry I edited your comment for readability :-)
If I understand correctly, the SD-Updater functionality is unaffected by this situation, and only the SD-Launcher shows problems listing the content of the SD Card when the SPI has been shared before a soft reset ?
One thing you may experiment with is to add this macro before #include <ESP32-Chimera-Core.h>:
#define TFCARD_USE_WIRE1
#define TFCARD_SPI_HOST SPI_HOST // or VSPI_HOST

this will attach the SPI from SD to the M5 object and expose it after M5.begin() as:
  (SPIClass *) M5.SD_SPI;

so you can eventually share it with your external SPI device, provided they have separate CS pins.

Yes, the SD-Launcher shows problems listing the content. I edited the M5STACk-SD-MENU source to put in the lines above in the core.h file. I'm assuming you mean for me to edit your example as I don't use the ESP32_Chimera_core library. That causes an exception when flashed to a stand alone m5stack module either using SPi or VSPI. I erased the device completely before flashing. The esp-decoder funnily enough doesn't seem to show the full stack. See below. Could you explain your thought process here. I'm not quite clear on why I'm having an SPI sharing issue when having my code and your code flashed to the device after a soft reset.
Rebooting...
ets Jul 29 2019 12:21:46
rst:0xc (SW_CPU_RESET),boot:0x17 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:1
load:0x3fff0030,len:1344
load:0x40078000,len:13732
ho 0 tail 12 room 4
load:0x40080400,len:3608
entry 0x400805f0
[     1][D][Button.cpp:42] Button(): Button on pin 39, invert=1, debounce=10ms
[     1][D][Button.cpp:42] Button(): Button on pin 38, invert=1, debounce=10ms
[     4][D][Button.cpp:42] Button(): Button on ��� 37, invert=1, debounce=10ms
[    12][D][esp32-hal-cpu.c:214] setCpuFrequencyMhz(): PLL: 480 / 2 = 240 MESP32-Chimera-Core initializing [Board=M5Stack_Core_ESP32] [Variant=m5stack_core_esp32]
[    79][D][ESP32-Chimera-Core.cpp:93] begin(): Enabling LCD
[    93][W][LGFX_AutoDetect_ESP32.hpp:415] _read_panel_id(): [LovyanGFX] [Autodetect] read cmd:04 = 000000e3
[    94][W][LGFX_AutoDetect_ESP32.hpp:1237] autodetect(): [LovyanGFX] [Autodetect] M5Stack
[   250][D][ESP32-Chimera-Core.cpp:276] sd_begin(): Enabling SD from TFCARD_CS_PIN #4 at 25000000 Hz from core #1
ESP32-Chimera-Core started
ESP-IDF version is: v4.4.1-1-gb8050b365e
[   269][D][M5StackUpdater.h:211] _fsBegin():  Checking for SD Support (pin #4)
[   269][D][M5StackUpdater.h:217] _fsBegin(): SD Successfully mounted (pin #4)
[   275][I][esp32-hal-i2c-slave.c:234] i2cSlaveInit(): Initialising I2C Slave: sda=22 scl=22 freq=100000, addr=0x15
[   286][D][esp32-hal-i2c-slave.c:498] i2c_slave_set_frequency(): Fifo thresholds: rx_fifo_full = 28, tx_fifo_empty = 4
[   296][E][Wire.cpp:260] getClock(): Bus is in Slave Mode
[   301][E][Wire.cpp:308] beginTransmission(): Bus is in Slave Mode
[   307][E][Wire.cpp:331] endTransmission(): Bus is in Slave Mode
[   313][E][Wire.cpp:260] getClock(): Bus is in Slave Mode
Guru Meditation Error: Core  1 panic'ed (LoadProhibited). Exception was unhandled.
Core  1 register dump:
PC      : 0x400d66d6  PS      : 0x00060a30  A0      : 0x800d9829  A1      : 0x3ffb2760
A2      : 0x3ffc237c  A3      : 0x00000000  A4      : 0x3ffc1a80  A5      : 0x3ffc32c4
A6      : 0x3f4002e4  A7      : 0x3ffbdc0c  A8      : 0x800d66c6  A9      : 0x3ffb2740
A10     : 0x3ffb28b8  A11     : 0x3f4008f6  A12     : 0x0000003f  A13     : 0x00000051
A14     : 0x3f400381  A15     : 0x00000004  SAR     : 0x00000004  EXCCAUSE: 0x0000001c
EXCVADDR: 0x00000010  LBEG    : 0x40088f51  LEND    : 0x40088f61  LCOUNT  : 0xfffffffe
Backtrace:0x400d66d3:0x3ffb27600x400d9826:0x3ffb27c0 0x400f2f12:0x3ffb2820
and the decoding
Decoding stack results
0x400d6831: UISetup() at d:\documents\arduino\libraries\lovyangfx-master\src\lgfx\v1/panel.hpp line 101
0x400d9be6: setup() at C:\Users\Ifrew\AppData\Local\Temp\VMBuilds\M5Stack-SD-Menu\espressif_m5stack-core-esp32\Release\main/main.cpp line 14
0x400f4b92: loopTask(void*) at D:\Documents\Arduino\hardware\espressif\esp32\cores\esp32\main.cpp line 42

found this in an unrelated sketch:
    SD.end(); // If not Bluetooth doesn't work !!!

although you're obviously not concerned by bluetooth, this is still an interesting lead to follow up on
SDUpdater doesn't perform a SD.end() since the SD driver is supposed to reset the SPI and CS pin state when the bootloader is called, but maybe it should
one way to check that (provided you're using updateFromFS()) is to insert SD.end() in your LoRa sketch between updateFromFS() and  ESP.restart()
another way to check that (choose one but don't test both together) is to start SD twice on boot from the SD-Menu app:
M5.begin();
SD.end();
M5.sd_begin();

(sorry about the spam)
found a SO post somehow related because it demonstrates how to properly share the SPI bus between LoRa and SD
https://arduino.stackexchange.com/questions/69927/sd-card-and-lora-module-arduino-uno
apparently all spi-based M5 LoRa modules are sharing the SPI bus with the SD module, so it becomes a fromage ou dessert situation where you can talk to either module but not both, plus you need to make that as a transaction.
this is roughly what should happen:
void loop()
{

  digitalWrite( LORA_CS_PIN, LOW );    //  SELECT LoRa SPI
  SPI.begin();
  // talk to the LoRa module
  SPI.end();
  digitalWrite( LORA_CS_PIN, HIGH );   //  DESELECT LoRa SPI

  digitalWrite( TFCARD_CS_PIN, LOW );  //  SELECT SD Card SPI
  SPI.begin();  // or SD.begin()
  // talk to the SD module
  SPI.end();  // or SD.end()
  digitalWrite( TFCARD_CS_PIN, HIGH ); //  DESELECT SD Card SPI

  delay(500);
}

also note that both should be deselected before the ESP restarts, since SD-Menu isn't LoRa aware it can't guess what CS pins to reset, and this may leave your LoRa module in the last state it was before the restart, thus sending unsollicited data across the SPI bus.
in order to prevent this you need to take care of it from your LoRa sketch.
void setup()
{
    // before calling M5.begin()
    digitalWrite( LORA_CS_PIN, HIGH );   //  DESELECT LoRa SPI
    M5.Begin();
    // checkSDUpdater( ... params ... ); // before enabling LoRa
    LoRa.begin();
    // ( ... )
}

// if you sdupdater implementation uses a UI option rather than button push at boot
void onLoadMenuBin()
{
  digitalWrite( LORA_CS_PIN, HIGH );   //  DESELECT LoRa SPI
  SD.begin(TFCARD_CS_PIN);
  updateFromFS(SD);
  SD.end();
  ESP.restart();
}

Thanks for that info! I've spent all day trying to get it working, but unsuccessful. However, I'm pretty sure I know what the problem is but my skills unravelling inherited classes and debugging is getting rusty these days,!. I tried for a few hours and things got a little better and a little worse enabling and disabling  the control signal for lora module I use before accessing the sd card. It occurred to me that my own app that reads and writes to the SD card and also updates the M5stack display and talks to Lora was having no issue. So I started looking at your example m5stack-sd-menu code. The difference is between your example and my code is that I use the TFT_ESPI library and you use the LGFX library. You have autodetect set and looking into the library code for that it tries to detect a whole bunch of different boards before finding the m5stack. During that search, some of the boards are using the same Pin I use for the Lora control signal on the SPI bus and the library has its own low level way of talking to the SPI bus. i tried to change the library by moving my board to the top so it was found first but that didn't fix the problem. However there is quite a lot of low level code in there. I tried to then change your example to use the TFT_ESPI graphics library but I got myself into a real mess. I still had the original copy of your sdupdate and examples that used the M5STACK library and I've started to try and get that version working again. Its pretty old though and I am sure has some bugs in it. Currently it is reading the sd card no problem when connected to my lora board., but having problems loading the binary...looking into that now. Anyway, wanted to get back to you with some more info, on the issue. I don't know how easy it would be for you to create an example using the m5stack graphic library, but I'm sure it would be quicker than me!!! :-)

thanks for your research, very interesting.
I have notified @lovyan03 about the pin conflict LGFX_AUTODETECT is possibly creating.
There are a few different M5 LoRa modules out there, and not all of them use the same pinout,
Can you speficy what exact model you're using? (or the pinout if you have built your own shield)

still researching, so far I found your post from two years ago and I will assume this is the hardware you're using unless you say otherwise.
also after speaking with lovyan03, we haven't been able to confirm the issue is coming from the auto detect routine, this means ESP32-Chimera-Core, M5StackUpdater, and the SD-Menu itself are still in the scope of the bug hunt.
meanwhile @kongduino (thanks!) has shared this two years old M5_LoRa_GeoLoc project where SD and LoRa coexist without conflicts.
M5_LoRa_GeoLoc uses chimera-core, so adding checkSDUpdater() in the setup should be enough to reproduce the same error-conditions you get in the SD-Menu after hot-loading menu.bin from your LoRa sketch.
it needs a GPS module on the grove port and a registered mapquest key to work though, if you have such module it would be interesting to observe the results.

Thanks for the additional info on sdupdater working with chimera code. I'll have a look at that! Yes I use the the M5stack lora 868 module.

I'm not sure it's propagated yet, but I pushed a fix on Chimera-Core and released a new version.
The I2C was improperly started in slave mode, so it should at least solve the  sda=22 scl=22 WTF in the boot log (although it probably won't affect this issue):
[ 296][I][esp32-hal-i2c-slave.c:234] i2cSlaveInit(): Initialising I2C Slave: sda=22 scl=22 freq=100000, addr=0x15
[ 306][D][esp32-hal-i2c-slave.c:498] i2c_slave_set_frequency(): Fifo thresholds: rx_fifo_full = 28, tx_fifo_empty = 4
[ 316][E][Wire.cpp:260] getClock(): Bus is in Slave Mode
[ 321][E][Wire.cpp:308] beginTransmission(): Bus is in Slave Mode
[ 327][E][Wire.cpp:331] endTransmission(): Bus is in Slave Mode
[ 333][E][Wire.cpp:260] getClock(): Bus is in Slave Mode

Ok folks. Finally put to bed this issue I'm sure. As I said, adding the pinMode(5,Output) for my board made a big difference but it would still fail eventually after a number of soft resets. I don't have an oscilloscope only a digital multi meter but I could see the voltages vary between each reset going up to around 3v +/- 0.2v and then turn off with capacitor discharge down to millivolts. However sometime it wouldn't quite reach 3v and then it started doing the wierd things. Normally you don't need pullup resistors on outputs since the bus is driving but it seems with the CS control line setting it High doesn't always set it high. So I added a weak pullup resistor of 470 Ohms between pin 5 and the 3.3V line on the M5stack bus with the Lora module attached and supplied voltage with 5v via USB C cable. I reset the device 50 times with no issues always reading the SD card! I pulled out the resistor and got to 7 resets before it failed. I repeated this test twice and same results both times. So it seems the internal pullup resistors of the M6 are quiet weak.
In summary, you need to use pinMode(pin number, OUTPUT) before M5.Begin() when using SDUpdater with multiple SPI devices on the M5Stack, and for additional security, also have a 470 Ohm resistor between the CS Pin of your SPI devices and the 3.3v line.
Thanks folks...normal service returns! I'll let you close this one out @tobozo !
Cheers
Iain


End vorpal.ui.redraw loop on keypress?

I have a command like:
.action(function (args, next) {
  const drawInterval = setInterval(() => {
    // ...
    vorpal.ui.redraw(stuffToDraw);
  }, 10);
})

How would I listen to a keypress, say q, and then run vorpal.ui.redraw.done()?
I have tried using
process.stdin.on('readable', () => {
  const chunk = process.stdin.read();
  if (chunk === 'q') {
    vorpal.ui.redraw.done();
  }
});

However the chunk doesn't come out with just the q character. Is there a built-in way of doing this? The only option so far is to press Ctrl+C and exit the whole of vorpal.

I've found a solution for this. My primary problem was that I was forgetting to call the callback next().
This allowed me to read process.stdin.on('keypress', ...) correctly and listen for Ctrl+C.
.action(function (args, next) {
  const drawInterval = setInterval(() => {
    draw();
  }, 10);

  next();

  process.stdin.on('keypress', (letter, key) => {
    if (key.sequence && key.sequence === '\u0003') {
      clearInterval(drawInterval);
      vorpal.ui.redraw.done();
    }
  });

  function draw() {
    // vorpal.ui.redraw(...)
  }
})

Smart! Thanks for sharing the solution. :+1:
--
BTW the closest thing I've done to this is vorpal-less:
https://github.com/vorpaljs/vorpal-less/blob/master/src/less.js


enh(#199): Enhance skinGenerate and add documentation.

Checklist

[x] the individual contributor license agreement is signed
[x] commit message follows commit guidelines
[x] documentation is changed or added

Description of change

Resolves #199.

📓 Conventional Commits 4. notes that docs is a type often recommended for documentation
ref: https://conventionalcommits.org/


gv300 configure on traccar

Hello,
sorry for my english, but I am Italian, and I do not speak very well.
I have a gv300 and not working with traccar installed on W10.
My configurarzione is Java 7, firewall disabled, configured port 8082 on the device with a private IP static public, but does not work.
I'm confused.
My log file of traccar is:
2016-06-17 20:01:26  INFO: Operating system name: Windows 10 version: 10.0 architecture: x86
2016-06-17 20:01:26  INFO: Java runtime name: Java HotSpot(TM) Client VM vendor: Oracle Corporation version: 25.91-b15
2016-06-17 20:01:26  INFO: Memory limit heap: 247mb non-heap: 0mb
2016-06-17 20:01:26  INFO: Character encoding: UTF-8 charset: UTF-8
2016-06-17 20:01:26  INFO: Version: 3.5-SNAPSHOT
2016-06-17 20:01:30  INFO: Starting server...
2016-06-17 20:07:12  INFO: Shutting down server...
2016-06-17 20:07:16  INFO: Operating system name: Windows 10 version: 10.0 architecture: x86
2016-06-17 20:07:16  INFO: Java runtime name: Java HotSpot(TM) Client VM vendor: Oracle Corporation version: 25.91-b15
2016-06-17 20:07:16  INFO: Memory limit heap: 247mb non-heap: 0mb
2016-06-17 20:07:16  INFO: Character encoding: UTF-8 charset: UTF-8
2016-06-17 20:07:16  INFO: Version: 3.5-SNAPSHOT
2016-06-17 20:07:18  INFO: Starting server...

there is a guide?
Where am I wrong?
Thank.

Port 8082 is definitely wrong one. Check following page:
https://www.traccar.org/identify-protocol/

thanks for the quick reply, but this means I have to change also port about traccar? eg: localhost:8082 - localhost:5051
If so, how?

You don't need to change any ports in Traccar.

Thank tananaev, but not work.
The spia gps is blu.
what else should I do?

Check following page:
https://www.traccar.org/troubleshooting/


vulkano test/build fails -- error: pub(restricted) syntax is experimental (see issue #32409)

I am unable to build the vulkano, either using cargo test --all:
...
error: `pub(restricted)` syntax is experimental (see issue #32409)
    --> vulkano/src/command_buffer/sys.rs:1003:9
     |
1003 |     pub(crate) fn to_vk_bits(&self) -> vk::ImageAspectFlagBits {
     |         ^^^^^

error: `pub(restricted)` syntax is experimental (see issue #32409)
   --> vulkano/src/device.rs:304:9
    |
304 |     pub(crate) fn pointers(&self) -> &vk::DevicePointers {
    |         ^^^^^

error: `pub(restricted)` syntax is experimental (see issue #32409)
   --> vulkano/src/instance/instance.rs:363:9
    |
363 |     pub(crate) fn pointers(&self) -> &vk::InstancePointers {
    |         ^^^^^

error: `pub(restricted)` syntax is experimental (see issue #32409)
  --> vulkano/src/pipeline/graphics_pipeline/builder.rs:79:9
   |
79 |     pub(super) fn new() -> Self {
   |         ^^^^^

error: aborting due to 4 previous errors

error: `pub(restricted)` syntax is experimental (see issue #32409)
    --> vulkano/src/command_buffer/sys.rs:1003:9
     |
1003 |     pub(crate) fn to_vk_bits(&self) -> vk::ImageAspectFlagBits {
     |         ^^^^^

error: Could not compile `vulkano`.
Build failed, waiting for other jobs to finish...
error: `pub(restricted)` syntax is experimental (see issue #32409)
   --> vulkano/src/device.rs:304:9
    |
304 |     pub(crate) fn pointers(&self) -> &vk::DevicePointers {
    |         ^^^^^

error: `pub(restricted)` syntax is experimental (see issue #32409)
   --> vulkano/src/instance/instance.rs:363:9
    |
363 |     pub(crate) fn pointers(&self) -> &vk::InstancePointers {
    |         ^^^^^

error: `pub(restricted)` syntax is experimental (see issue #32409)
  --> vulkano/src/pipeline/graphics_pipeline/builder.rs:79:9
   |
79 |     pub(super) fn new() -> Self {
   |         ^^^^^

error: aborting due to 4 previous errors

error: Could not compile `vulkano`.
Build failed, waiting for other jobs to finish...
error: build failed

or cargo build --all:
...
error: `pub(restricted)` syntax is experimental (see issue #32409)
    --> vulkano/src/command_buffer/sys.rs:1003:9
     |
1003 |     pub(crate) fn to_vk_bits(&self) -> vk::ImageAspectFlagBits {
     |         ^^^^^

error: `pub(restricted)` syntax is experimental (see issue #32409)
   --> vulkano/src/device.rs:304:9
    |
304 |     pub(crate) fn pointers(&self) -> &vk::DevicePointers {
    |         ^^^^^

error: `pub(restricted)` syntax is experimental (see issue #32409)
   --> vulkano/src/instance/instance.rs:363:9
    |
363 |     pub(crate) fn pointers(&self) -> &vk::InstancePointers {
    |         ^^^^^

error: `pub(restricted)` syntax is experimental (see issue #32409)
  --> vulkano/src/pipeline/graphics_pipeline/builder.rs:79:9
   |
79 |     pub(super) fn new() -> Self {
   |         ^^^^^

error: aborting due to 4 previous errors

error: Could not compile `vulkano`.
Build failed, waiting for other jobs to finish...
error: build failed

$ rustc --version
rustc 1.17.0

$ pacman -Q | grep vulkan
vulkan-headers 1:1.0.51-1
vulkan-icd-loader <IP_ADDRESS>-1
vulkan-intel 17.1.2-1

You need to upgrade to rustc 1.18 and it should work.


Isort add extend_skip_glob

I'm testing if we (astropy) can switch our isort to ruff's but we have an extend_skip_glob which I don't think is supported by ruff. Is there an alternative, or can extend_skip_glob be added? Thanks.

Ok. Solved. Thanks!

Thanks :)


set project_urls in setup.py

see https://github.com/numpy/numpy/blob/068074f4acab87b0fabf194517b7dfb0f038af5a/setup.py#L397

https://github.com/telekom/HPOflow/commit/d357025bb314439945249184e1d2ffa30ebcb205


NuProj not setting dependencies correctly

I am working on switching over from manual nuspec files to NuProj for one of the open frameworks I help support.  This one in particular leverages Xamarin Forms and I recently found an issue where the dependencies do not seem to be set correctly during the nuspec generation.
If you take a look at this nuproj file
It references XLabs.Forms.WinUniversal.csproj which in turn references Xamarin.Forms.Platform.WinRT (line 102).
The issue is -- there is no reference to Xamarin.Forms in several of the "group dependencies" that are in the generated nuspec.
Specifically

portable-net45+win80+wp80+wpa81
wp80
portable-net45+win+wpa81+wp80+MonoAndroid10+xamarinios10+MonoTouch10

Any idea why?

Any thoughts on this one?

Bump


issues with equality with scientific notation

2100 == 2.1e3
true
MapDiff.diff(%{a: 2100}, %{a: 2.1e3})
%{added: %{a: 2.1e3}, changed: :map_change, removed: %{a: 2100},
value: %{a: %{added: 2.1e3, changed: :primitive_change, removed: 2100}}}

Thank you for posting this issue!
MapDiff is working as expected in this situation: The problem here, is that 2100 is an integer, while 2.1e3 is a floating point number. While they are equal (which you can check for using ==), they are not identical (which you can check for using ===).
If you want all numbers to be the same and are using some floating point numbers, I'd suggest you cast all your input numbers to float before running MapDiff on it.
And if you need more precision than provided by floats, you might want to use the decimal library instead.

Feel free to let me know if there are any other questions :-)


Modify the run_from_cli branch to allow for longer runs

Can be cherry-picked from one of the scenarios

Resolved, can now run for 2.58 myr


Documentation for proxy support

Is this a new chart
No
What this PR does / why we need it:
We are documenting our support for proxy
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] Chart Version bumped
[ ] Variables are documented in the README.md
[ ] Title of the PR starts with chart name (e.g. [mychartname])

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.tparanhos seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Add Web Content to Your Portal Site and Set the Layout

Tutorial URL: https://developers.sap.com/tutorials/cp-portal-cloud-foundry-add-webcontent.html
All the options seems posible but I can't complete the last question. I have tested all the combinations with the 4 answers.

I am able to complete the tutorial -- can you try again and provide screenshot?

i'm actually able to complete the tutorial too, and the result it's really
cool, but in the last step (Step 6: Review your site) i'm not able to
answer the question correctly, all the options look correct to me.
On Tue, 15 Oct 2019 at 06:48, Daniel Wroblewski<EMAIL_ADDRESS>wrote:

I am able to complete the tutorial -- can you try again and provide
screenshot?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SAPDocuments/Tutorials/issues/4061?email_source=notifications&email_token=ANN46NZGLTP5L5CCR4A6BYLQOVDQDA5CNFSM4JARNFO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBHMWGY#issuecomment-542034715,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANN46N5FWVTHQ5AAATXJNTDQOVDQDANCNFSM4JARNFOQ
.

I'm saying I can answer the question. Not all the items can you set in a page section settings area.
There are 16 combinations of possible answers. Did you try all of them?

Thank you for your feedback. We haven't heard from you in a while, so we are closing the issue.
If you still have questions, feel free to reopen the issue.


[repl] unable to bot.say on longer code.

Using just
bot.say('message')
yields the correct results but doing stuff like
for x in server.emojis:     bot.say(x.name)
does not seem to work.
A slight workaround is using print() instead but print() does not allow for embeds

This is because the repl only automatically awaits single line expressions.
bot.say is a coroutine.
If you want to do anything more complicated with coros, I'd recommend putting them into their own functions first.
here's an example I use often when I'm debugging with repl
async def getm(id):
    global m
    m = await bot.get_message(channel, id)

then as a single expression: getm(id)


Feature/#23 typescript

Summary of changes:

added typescript, @types/node, @types/react, @types/react-dom
added tsconfig.json following the gatsby minimal ts example
renamed gatsby-browser.js & gatsby-config.js to gatsby-browser.ts & gatsby-config.ts
added globals.d.ts. It's a declaration of types file to handle imports (svg, images, etc) following the create react app example

And with that, typescript has been successfully integrated 😃.
That took 10% of the time, the remaining 90% was on figuring out how to add eslint typescript. The hardest part was making eslint work on react js, jsx files while using typescript linting only on ts and tsx files. I've annoted the changes but please tell me if you have any questions. Here are the edits I did on eslintrc:

added "plugin:@typescript-eslint/recommended" to "extends"
added "parser": "@typescript-eslint/parser"
added "@typescript-eslint" to "plugins"
added "react/prop-types": "off" since we can handle type check with ts
to fix imports unresolved error:

added "plugin:import/errors", "plugin:import/warnings" to "extends"
added "import/resolver" to "settings"

to fix imports extension error:

added "import/extensions" to "rules"

to allow jsx in tsx files:

added "react/jsx-filename-extension" to "rules"

And with that, we've got linting on both javascript and typescript files!

I'm closing this PR for now to fix the error in Netlify Preview: error: Your "gatsby-config.ts" file failed to compile to "gatsby-config.js". Please run "gatsby clean" and try again.


Suggest object id creates duplicates in vsix CU5 + CU6

When I suggest the id of a codeunit using Ctrl+Space in CU5 and 6 it suggests an id that's already been used.

Hi @reiniroosh, this looks like a bug. I have a few question to understand how it reproduces: After using IntelliSense, do you get a diagnostic for duplicate id in VS Code or do you get an error from the server when trying to publish your extension? If the error happens in VS Code, do you have any other dependencies on other extensions which may use this id?

It's happening as a "problem" which I think is VS Code compiling the code as it watches for changes.
It's the duplicate of another file in my own extension.
However I think we can close the issue... I think I was accidentally using an old vsix.


[feature request] add proxy settings

Many Chinese user may need this feature. For the open web behind the wall.

Duplicate of #478


Add node count override for testing CA

Can now specify a target number of nodes, to force autoscaling.
Note that, right now, we don't have resource requests on our pods, so the scaling is forced by hitting up against the max pods per node setting in Azure CNI.  That could be easily changed by also adding resource requests to our pods, so that a certain number of pods would fit on a node.

@jackfrancis I re-created this PR to avoid merge issues.  It's ready for review now.


combine inferences into a full pipeline

Hi,
I have trained my own custom model with synthetic data and would like to test it on my own real data. As far as I guess there is currently no code snippet that combines data loading, detection, gdrn and refinement algorithms.
I see that there is a TODO in the core/gdrn_modeling/demo/demo_gdrn.py file. When do you expect this script to be ready? Maybe there is already a code snippet that I could start from to build the pipeline that would load the rgb and depth image and get the transformation matrices as output?
Thanks for your answers.

Sorry, we haven't made such a pipeline. Welcome to finish the code snippet and make a pull request :)

Hi,
if you are working on that kind of pipeline I would  be very interested in your progress/results, since I am trying  to integrate this into a bin-picking process for a bachelors thesis.

Hi,
Yes, I managed to connect the individual elements into a complete pipeline. When I have some time, I will refactor some things on my code and make a pull request.

If you already have a python file to build a pipeline, maybe you can  just share that on its own  on your github or something? I'm sure it would be a great help and something that I could build from.


encryptedresource-controller crashing with >1 resource listed

While testing the use of EncryptedResources in our CD workflow we encountered issues where the resource was not applied to the cluster. After investigating, we discovered that the encryptedresource-controller was in a CrashLoopBackOff with OOMKilled listed as last status.
None of these issues were encountered during local development on a kind cluster.
The underlying resource(s) being applied are mostly cluster image pull secrets in various namespaces. Currently, we have it structured that each Secret is wrapped by a single EncryptedResource. With that structure we noticed the crashes occurring if we tried to apply more than one. Even with one, we encountered the infrequent crash.
We then tried to include multiple resources in the resources: array field of the EncryptedResource CR. The same behavior was observed, i.e. a single secret seemed to be ok, but more than that and the controller crashed with an OOMKilled status.
We increased the memory requests/limits to 200Mi/500Mi, respectively, and have not observed any other crashes even with about a dozen or so separate EncryptedResources being managed.
Expected behavior:

For the controller to run in a stable fashion when multiple EncryptedResources are being managed.

Example:
Containers:
  encryptedresource-controller:
    Container ID:   containerd://c6d34612f2fc2414405a5d73767589c6934845d2cb1468cb03b05d038a0f55f8
    Image:          us.icr.io/armada-master/encryptedresource:0.2.3_da66c79
    Image ID:       us.icr.io/armada-master/encryptedresource@sha256:be3096e8f17b0385b36014990f74417f2cefe46ed4d9d63a3d8382ffe8d32289
    Port:           <none>
    Host Port:      <none>
    State:          Terminated
      Reason:       OOMKilled
      Exit Code:    137
      Started:      Thu, 12 Aug 2021 11:02:44 -0400
      Finished:     Thu, 12 Aug 2021 11:03:09 -0400
    Last State:     Terminated
      Reason:       OOMKilled
      Exit Code:    137
      Started:      Thu, 12 Aug 2021 11:01:48 -0400
      Finished:     Thu, 12 Aug 2021 11:02:28 -0400
    Ready:          False
    Restart Count:  2
    Limits:
      cpu:     100m
      memory:  200Mi
    Requests:
      cpu:     40m
      memory:  75Mi

Disregard "Restart Count: 2" as this was after a restart of the controller deployment. We began this process witnessing ~167 restarts over 11h.
All seems well with the following (arbitrary) req/limits:
 resources:
          limits:
            cpu: 100m
            memory: 500Mi
          requests:
            cpu: 40m
            memory: 200Mi

Closing -- repo being archived.


onInputValidated called many times

Hey, Thanks for creating this package.
Describe the bug
I am using stateful widget I have wrap InternationalPhoneNumberInput with Form.
But when the user comes to this screen or opens the keyboard for entering a number.
InternationalPhoneNumberInput constantly called onInputValidated (many times like 200-500) and It doesn't stop even if the user enters the number.
Package version
intl_phone_number_input: ^0.5.2+2
Flutter version
Flutter 1.22.2 • channel stable
To Reproduce
Steps to reproduce the behavior:

Code is below

Widget countryDropDown() {
  return Form(
    key: formKey,
    child: InternationalPhoneNumberInput(
      onInputChanged: onNumberChanges,
      onInputValidated: (bool value) {
        print(value);
      },
      autoValidateMode: AutovalidateMode.disabled,
      initialValue: number,
      textFieldController: phoneController,
      inputBorder: OutlineInputBorder(),
      selectorConfig: SelectorConfig(
          selectorType: PhoneInputSelectorType.DIALOG,
          backgroundColor: Colors.white,
          useEmoji: false),
      inputDecoration: new InputDecoration(
        border: new OutlineInputBorder(
            borderRadius: BorderRadius.all(Radius.circular(20)),
            borderSide: BorderSide(color: Colors.white)),
        contentPadding: EdgeInsets.all(25),
        focusedBorder: OutlineInputBorder(
          borderRadius: BorderRadius.all(Radius.circular(20)),
          borderSide: BorderSide(color: Colors.white, width: 5.0),
        ),
        enabledBorder: OutlineInputBorder(
          borderRadius: BorderRadius.all(Radius.circular(20)),
          borderSide: BorderSide(color: Colors.white, width: 5.0),
        ),
      ),
    ),
  );
}

Expected behavior
I think onInputValidated should call only when the user updated anything unless this doesn't need to call onInputValidated.
And Making the screen performance very leggy and slow
Screenshots

** Targeted platforms (please complete the following information):**
Android, IOS

Check if the behavior is the same in a stateless widget. If not, then on each state update of the page the widget tree redraw happens and the validation is fired as well.

Hey @illuminated
I have checked that is not happing in the stateless widget. but The question is why onInputValidated is fired in setState.
Now let's assume that I have setState in onInputChanged so when the number changes tree rebuild. But what if the user has already entered the number It's still calling both methods. (user is not entering anything )
Check below image

What I think is onInputChanged&onInputValidated should call only when there are any changes in the number or the user changes anything.


Add additional support for searching in project/branch history

It might make searching through project histories more user-friendly if a search bar was provided for searching the history. In particular, the ability to search for fragments of commit messages or for commit hashes may help with finding specific commits that are needed for reversion but were not explicitly tagged at the time due to lack of foresight.
To be more clear on why commit hash searching may be helpful, I found that trial-and-error has often been my only tool for finding commits where specific changes were made. After I have found the appropriate commit, I have to return to the branch history and manually find that same commit again if I want to tag it or create a new branch. Alternatively, an additional option on the dropdown for intermediary commits in the header (currently there is only the option to export the commit) could be added that allows creating a branch from the current commit or tagging the current commit.

This might be better to post on webgme. Since the project history search function in deepforge is used directly from webgme(I think).


Update version: OpenJS.NodeJS version 20.6.1

Pull request has been created with WinGet Automation :rocket:
Microsoft Reviewers: Open in CodeFlow

Manifest Error: Duplicate installer entry found.


How to improve clarity  256x256

The image size is  128x128。 I want to train a 256x256，what should I do？thank you？

You can try an image super-resolution module and change the architecture of our image encoder.


[WIP] Add warning when a loader is called more than one time for the same module

What kind of change does this PR introduce?

Feature. Fixes #3359

Did you add tests for your changes?

Yes, but the integration tests are failing because I don't know how I can catch webpack errors.

If relevant, link to documentation update:

N/A

Summary
I wanted to start contribuiting to webpack and decided to challenge me with #3359.

Does this PR introduce a breaking change?

No.

Other information
Thank you again @TheLarkInn for your time! 😄

I didn't pull anything related to options, because I didn't finish it, and I wanted to know if it's really necessary to check if they are the same. For example:
 require("any-loader?query1!any-loader?query2")

If query1 !== query2, must fail?

@TheLarkInn @sokra I don't know if exists, but to be able to compare the options, I have to transform the ones who are strings, to objects. Because of this:
"some-loader?foo=something&bar=somethingElse" !== "some-loader?bar=somethingElse&foo=something"

For the moment, I will write a function next to the plugin.

New changes:

Updated Plugin's name.
Updated the error message.
Added a function for compare options.
Added a warning if options are diff.
Added two new Unit Tests for the new options check.

I don't know if it's OK to compare options, but I was already doing it.
Known problems:

A lot of integration tests are failing. I don't know what I have to do.
It is possible to use the same loader more than two times for the same module 🤕 , but with different options. I always compare against with the second. If I need to compare more than two loaders' options, this will need changes.
I still didn't find a way to catch webpack's crash for the integration test.

Looking into this! :-D

This is not a big problem


This one weird trick to avoid merge conflicts

@tragiclifestories @paprikati @isaacseymour: After our discussion in Slack I thought I'd have a go at this.
Explanation of what's going on is in a big comment above the relevant test.
Rubocop is sad in CI, and wants us to remove Ruby 2.4 as we no longer support it. Given it's run out of security support I'm in favour of totally removing it in a separate PR (from the Circle build matrix too).
Don't think this needs a major version bump. Nothing will actually break. People using the library will get one PR where the ordering changes, so we should changelog it.

Don't think this needs a major version bump. Nothing will actually break. People using the library will get one PR where the ordering changes, so we should changelog it.

Sure, but if we remove support for 2.4 in a follow-up that will need a major bump.


Update README.md

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[x] Docs
[ ] New Binding issue #___
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes, and the changes were approved in issue #___
[ ] No

Checklist

[ ] When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
[ ] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
[ ] I have added a convincing reason for adding this feature, if necessary

Other information

Added a few more changes, I'll put in a PR against the main repo for these as well


feat(module:pipes): make the css-unit pipe support more units

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
CSS 规范一直在更新，支持的单位也越来越多，我们不应该枚举这些单位。
What is the new behavior?
不再限制 CSS 单位。同时取消弃用这个 Pipe，因为我发现了它有处理数字为带单位的字符串的能力，它仍然有使用价值。
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

LGTM


Bump version to 3.0.2

This shouldn't be merged until all pending Pull Requests have been merged.

Coverage decreased (-3.5%) to 88.252% when pulling b1aa6339677ba9a433f67b7b843990063af817a7 on kk/302 into bcd9c9174b3ee7ddaece46c212f4e91ff5601e05 on master.

Coverage remained the same at 91.797% when pulling 9fb91e2c07ac2e57938f96e357535b085a02420d on kk/302 into c8eea2d1cbcf91cbe6973dc5222fba8d2dee8430 on master.


ssh/knownhosts: knownhost to support io.reader

add NewFromReader(r io.Reader) (ssh.HostKeyCallback, error) to knownhosts
fixed #62656

Ok

Good


About project roadmap

I really like this repository, and I was wondering what the future maintenance plans are? Are there any plans to implement a demo similar to the blueprints in Unreal, with effects similar to egui_node_graph or imgui-node-editor?

Hey @xdestiny110 ! Thanks for the interest.
I do not think that going to deep into the support of unreal blueprints style usecases will be the priority.
The middle term goal for the project is to serve as a base platform for arbitrary graph visualization. For the moment I am doing a side project which is based on this lib where I can test it usability. After we all the needed features for the basic usecases and wait some time for stabilizations I will release v1.0.0.
But making an example demonstrating custom node and edge drawing functions capabilities surely can be done.


INTEGRATION_video_encoder fails on arm64, armhf debbuilds

Environment

OS Version: Ubuntu 18.04, 20.04 and Debian Buster
Source or binary build?

debbuild of 3.11.0
Description

Expected behavior: debbuild succeeds
Actual behavior: debbuild fails due to failure of INTEGRATION_video_encoder test added in https://github.com/ignitionrobotics/ign-common/pull/125

The following tests FAILED:
	 43 - INTEGRATION_video_encoder (Failed)
Errors while running CTest

43/93 Test #43: INTEGRATION_video_encoder ...................***Failed    4.55 sec
Running main() from /var/lib/jenkins/workspace/ign-common3-debbuilder/build/ignition-common-3.11.0/test/gtest/src/gtest_main.cc
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from EncoderDecoderTest
[ RUN      ] EncoderDecoderTest.DecodeEncodeDecode
[Msg] Compatible SW encoder: libx264
[Msg] Using encoder libx264
[Msg] FPS: 42.2372
[Msg] FPS: 40.6361
/var/lib/jenkins/workspace/ign-common3-debbuilder/build/ignition-common-3.11.0/test/integration/video_encoder.cc:135: Failure
The difference between avgIntensity2 and avgIntensity is 1.8609066972724975, which exceeds 1.0, where
avgIntensity2 evaluates to<PHONE_NUMBER>9026915,
avgIntensity evaluates to<PHONE_NUMBER>8754165, and
1.0 evaluates to 1.
[  FAILED  ] EncoderDecoderTest.DecodeEncodeDecode (3003 ms)
[----------] 1 test from EncoderDecoderTest (3004 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (3008 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] EncoderDecoderTest.DecodeEncodeDecode

 1 FAILED TEST

Steps to reproduce

Build on arm64 or armhf system
Run ctest

Output

 https://build.osrfoundation.org/job/ign-common3-debbuilder/896/
 https://build.osrfoundation.org/job/ign-common3-debbuilder/898/
 https://build.osrfoundation.org/job/ign-common3-debbuilder/901/
 https://build.osrfoundation.org/job/ign-common3-debbuilder/907/
 https://build.osrfoundation.org/job/ign-common3-debbuilder/908/

Hmm... I wonder if doubling the intensity limit would be a non-flaky solution? The intensity tests were added mainly to prevent cases when the encoded video is completely wrong (all black, greenish film, stripes caused by wrong memory alignment)... so I think even raising the limit to 5 or 10 is okay (if I remember correctly, intensity here goes 0...255).