New landing page, basic version one

Can try to run make local-homepage but I think it doesn't work without fastapi[standard] as a dev dependency in the root directory.
There's minimal to no styling at the moment. I'd like to at least get some basic colors and really make the CTA eye-catching before publishing a basic version.

Nice first pass!! :fire: :fire: <!subteam^S07SKMS37QU> please work with andy to improve. My thoughts

feels unbalanced (maybe the "who are we?" and the text after is a little smaller
yellow github link is ugly

The solution I had for your fastapi[standard] problem was to stick a pyproject.toml into webapp/, and then add webapp as as a workspace member. Then, add fastapi[standard] to common webapp deps.
The expectation then, is that all webapps share a common webapp project, and they can add whatever they want to their own deps. This requires updating a ton of docker images ( which I have done on my jaime branch).
Alternatively, you can add webapp/homepage to your root workspace members, and update the webapp/homepage/pyproject.toml to use fastapi[standard] instead of raw fastapi.

I don't see a github link - but I agree that yellow is ugly
IMO the slogan "ushering in the age...." is too aspirational and incongruous with the rawdogged static html and css.
Contact Us linking to email directly is a cool touch
Slack File: image.png

Do you guys think the yellow would still be ugly if the background was purple/violet?

could you post a ss?

Idk about messing with other people's logos personally. I think if it's coherent, like a lot of things are gonna be yellow it could be ok. Please ignore my feelings tho if desired

Slack File: image.png

yellow on purple looks okay, but i'm not sure that I like purple as a background color in general. maybe if it were more of a regal purple?

Slack File: image.png

final decision is up to you, but I'm personally not a fan

just not a fan of purple in general?

yeah, it doesn't feel very professional

how about this color
Slack File: image.png

I think I'm just boring and prefer white/gray/black.
But I also don't have a single creative bone, so if you see the vision, go for it.

Hmmmm I'll cook up one primarily grayscale version and one primarily colored version then

I'll leave it alone here then and if there are problems with the flow after jaime is merged then we can fix it

Sounds good. This is the solution that I settled on in jaime
https://abstractoperators.slack.com/archives/C07E3HJJQFK/p1734020659844309

Slack File: Screen Recording 2024-12-13 at 15.52.14.mov

oh, hover effect..??

yeah

thoughts?

I liked it haha

Slack File: Screen Recording 2024-12-13 at 15.58.35.mov

Looks really good!
My version is still blue/yellow, not sure why I don't see the new gray/purple.
I'm beginning to see the color scheme vision.
There's still some dissonance between yellow github and the purple/orange contact us. I feel that they are too vibrant as well.
The color changing when you hover is a really cool touch.
Potential idea: Glimmering gray background.
I think the nav bar should probably be fixed as you scroll.
Have you considered how this looks on a phone? I think Kent will potentially be sharing this homepage with people at networking events, so phone viewing might be important. @kgang can you confirm?

Thanks for the ping, yes phone is important for practical purposes. The flow usually goes

Rando asks what I do or they know I'm a founder
They ask what I'm working on/how it's been going
If they're interested, they'll ask to see the website
So people who are looking at our website are already inclined to be on our side. The need the website should fill is
show that we can have a cool/aesthetic website
describe what we do and what we've done
give a place for someone to look at in the future to contact us or learn more about us
Additionally, I'll be sending this as part of a cold outbound (maybe in my email signature too?) so less friendly randos will also look at it wondering how legit we are

I haven't taken a look at phone yet, but good catch. The gray/purple wasn't pushed, I just did a quick switcheroo for the screencap. Do you prefer that color scheme <!subteam^S07SKMS37QU>?
Will fix the nav bar and change up the colors for github/contact us

i do prefer it

I wonder if we really even need people to contact us lol. Wondering also if they do need to contact us if my calendly is better. Sorry, this isn't the most helpful lol

What's the alternative? Are you saying that in all realistic cases we'd be the ones initiating contact anyways?

I guess we should just grab people's emails + company to reach out to them later if they want to work with us

I think three clients could carry us quite far

That makes sense. Idk if that means we don't include a way to contact us on the landing page though

yeah you know ig it'd be fine for now to manage all inbound manually until it becomes too much

Calendly is a good idea though

calendly.com/kentgang/30min

Aw dang I was hoping you could write a message with calendly too

Jk you can

Nice

yeah there's a spot to add additional context

I could create different calendly links for different meeting types too if I pay for calendly but probably not for now

Yeah just the one is fine

lmk if you need any help with deploying it :+1:

probably will

Forgot to open contact us, but it goes to calendly now
Slack File: Screen Recording 2024-12-17 at 14.42.38.mov

i think the top text should be centered not left justified

looks good tho

How about this?
Slack File: Screen Recording 2024-12-17 at 14.54.48.mov

yeah I think that looks better

kk i need to run an errand rq but if you wanna approve i can be back in 30 to merge/deploy

I'll probably won't be around in 30, GL

I rebased the entire branch onto main because it original branched off of the project api branches

:eyes:

if you wanna approve i believe i addressed the changes

Let's wait til Michael is on tmw. Request change should mean that you'd like to be blocking

I'll ask him though if that was necessary

sg

I'll check PR descriptions from now on


[BUG]: Navbar not visible clearly

The navbar in home screen is not visible clearly. I make it look clear . Pls assign this issue to me @Vignesh025

Hey @Gaurav075 , Someone is already working on this.


How to install dotnet new templates from MyGet?

I want to install
https://www.myget.org/feed/timewarp-enterprises/package/nuget/TimeWarp.AspNetCore.Blazor.Templates
I try the following command but it doesn't list the template.
dotnet new --install TimeWarp.AspNetCore.Blazor.Templates::0.1.0-beta-229  --nuget-source https://www.myget.org/F/timewarp-enterprises/api/v3/index.json

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0b952f8a-18e1-4843-0741-6ca877fb303a
Version Independent ID: d80dfb96-bc86-a960-abec-255dd907d04d
Content: dotnet new command - .NET Core CLI
Content Source: docs/core/tools/dotnet-new.md
Product: dotnet-core
GitHub Login: @mairaw
Microsoft Alias: mairaw

λ  dotnet --version
2.1.402

@danroth27 @scottaddie can you guys help with this question?

@StevenTCramer Did you create a .template.config/template.json file? More details here: https://docs.microsoft.com/dotnet/core/tutorials/create-custom-template#create-a-template-from-a-project. The aforementioned JSON file stores the metadata which displays in the dotnet new experience.

@scottaddie Yes I created those and installing it locally works fine.  The issue is I can't install the template from MyGet.

@scottaddie   I went ahead and pushed to nuget and it works fine from there with
 dotnet new --install TimeWarp.AspNetCore.Blazor.Templates

but I would perfer to test stuff from MyGet before pushing to Nuget.

@mlorbetske

@mlorbetske @seancpeters Does the directory containing template.json have to be named .template.config? Our docs reference that name; however, Steven's project uses a directory name of .template.config.src. See https://github.com/TimeWarpEngineering/blazor-state/tree/master/source/TimeWarp.AspNetCore.Blazor.Templates/content/TimeWarp.BlazorHosted-CSharp/.template.config.src.

Could you post the output of the first install command you tried please?
As a possible workaround, try adding the MyGet feed to your global NuGet config and try the first install command but without specifying --nuget-source

Here's what I get:
C:\Users\user>dotnet new --install TimeWarp.AspNetCore.Blazor.Templates::0.1.0-beta-229  --nuget-source https://www.myget.org/F/timewarp-enterprises/api/v3/index.json
  Restoring packages for C:\Users\user\.templateengine\dotnetcli\v2.2.100-preview2-009404\scratch\restore.csproj...
  Installing TimeWarp.AspNetCore.Blazor.Templates 0.1.0-beta-229.
  Generating MSBuild file C:\Users\user\.templateengine\dotnetcli\v2.2.100-preview2-009404\scratch\obj\restore.csproj.nuget.g.props.
  Generating MSBuild file C:\Users\user\.templateengine\dotnetcli\v2.2.100-preview2-009404\scratch\obj\restore.csproj.nuget.g.targets.
  Restore completed in 4.47 sec for C:\Users\user\.templateengine\dotnetcli\v2.2.100-preview2-009404\scratch\restore.csproj.

Usage: new [options]

Options:
  -h, --help          Displays help for this command.
  -l, --list          Lists templates containing the specified name. If no name is specified, lists all templates.
  -n, --name          The name for the output being created. If no name is specified, the name of the current directory is used.
  -o, --output        Location to place the generated output.
  -i, --install       Installs a source or a template pack.
  -u, --uninstall     Uninstalls a source or a template pack.
  --nuget-source      Specifies a NuGet source to use during install.
  --type              Filters templates based on available types. Predefined values are "project", "item" or "other".
  --dry-run           Displays a summary of what would happen if the given command line were run if it would result in a template creation.
  --force             Forces content to be generated even if it would change existing files.
  -lang, --language   Filters templates based on language and specifies the language of the template to create.

Templates                                         Short Name            Language          Tags
-------------------------------------------------------------------------------------------------------------------------------
Console Application                               console               [C#], F#, VB      Common/Console
Class library                                     classlib              [C#], F#, VB      Common/Library
Unit Test Project                                 mstest                [C#], F#, VB      Test/MSTest
NUnit 3 Test Project                              nunit                 [C#], F#, VB      Test/NUnit
NUnit 3 Test Item                                 nunit-test            [C#], F#, VB      Test/NUnit
xUnit Test Project                                xunit                 [C#], F#, VB      Test/xUnit
Razor Page                                        page                  [C#]              Web/ASP.NET
MVC ViewImports                                   viewimports           [C#]              Web/ASP.NET
MVC ViewStart                                     viewstart             [C#]              Web/ASP.NET
Blazor (hosted in ASP.NET server)                 blazorhosted          [C#]              Web/Blazor/Hosted
Blazor Library                                    blazorlib             [C#]              Web/Blazor/Library
Blazor (Server-side in ASP.NET Core)              blazorserverside      [C#]              Web/Blazor/ServerSide
Blazor (standalone)                               blazor                [C#]              Web/Blazor/Standalone
ASP.NET Core Empty                                web                   [C#], F#          Web/Empty
ASP.NET Core Web App (Model-View-Controller)      mvc                   [C#], F#          Web/MVC
ASP.NET Core Web App                              razor                 [C#]              Web/MVC/Razor Pages
ASP.NET Core with Angular                         angular               [C#]              Web/MVC/SPA
ASP.NET Core with React.js                        react                 [C#]              Web/MVC/SPA
ASP.NET Core with React.js and Redux              reactredux            [C#]              Web/MVC/SPA
Razor Class Library                               razorclasslib         [C#]              Web/Razor/Library/Razor Class Library
ASP.NET Core Web API                              webapi                [C#], F#          Web/WebAPI
global.json file                                  globaljson                              Config
NuGet Config                                      nugetconfig                             Config
Web Config                                        webconfig                               Config
Solution File                                     sln                                     Solution

Examples:
    dotnet new mvc --auth Individual
    dotnet new razor --auth Individual
    dotnet new --help

From the look of the output from @danroth27, it seems to have been successful - the output from @StevenTCramer will likely shed more light on the situation.

@mlorbetske Well, I don't see any new templates in the list and when I try to uninstall the templates it says that the templates were not installed.
C:\Users\user>dotnet new -u TimeWarp.AspNetCore.Blazor.Templates
Could not find something to uninstall called 'TimeWarp.AspNetCore.Blazor.Templates'.

Are these different than the Blazor templates that appeared in your list above? Also, what does dotnet new -u list as the installed template packs?

Downloading and extracting the package, it doesn't appear that there are any template.json files at all. My guess is that there's something wrong with the build process that produces that package.

@mlorbetske The Blazor templates are unrelated to this issue. It's a separate template pack.
C:\Users\user>dotnet new -u
Template Instantiation Commands for .NET Core CLI

Currently installed items:
  Microsoft.DotNet.Common.ItemTemplates
    Templates:
      global.json file (globaljson)
      NuGet Config (nugetconfig)
      Solution File (sln)
      Web Config (webconfig)
  Microsoft.DotNet.Common.ProjectTemplates.2.2
    Templates:
      Class library (classlib) C#
      Class library (classlib) F#
      Class library (classlib) VB
      Console Application (console) C#
      Console Application (console) F#
      Console Application (console) VB
  Microsoft.DotNet.Test.ProjectTemplates.2.2
    Templates:
      Unit Test Project (mstest) C#
      Unit Test Project (mstest) F#
      Unit Test Project (mstest) VB
      xUnit Test Project (xunit) C#
      xUnit Test Project (xunit) F#
      xUnit Test Project (xunit) VB
  Microsoft.DotNet.Web.ItemTemplates
    Templates:
      Razor Page (page) C#
      MVC ViewImports (viewimports) C#
      MVC ViewStart (viewstart) C#
  Microsoft.DotNet.Web.ProjectTemplates.2.2
    Templates:
      ASP.NET Core Empty (web) C#
      ASP.NET Core Empty (web) F#
      Razor Class Library (razorclasslib) C#
      ASP.NET Core Web App (razor) C#
      ASP.NET Core Web App (Model-View-Controller) (mvc) C#
      ASP.NET Core Web App (Model-View-Controller) (mvc) F#
      ASP.NET Core Web API (webapi) C#
      ASP.NET Core Web API (webapi) F#
  Microsoft.DotNet.Web.Spa.ProjectTemplates
    Templates:
      ASP.NET Core with Angular (angular) C#
      ASP.NET Core with React.js (react) C#
      ASP.NET Core with React.js and Redux (reactredux) C#
  NUnit3.DotNetNew.Template
    Templates:
      NUnit 3 Test Project (nunit) C#
      NUnit 3 Test Item (nunit-test) C#
      NUnit 3 Test Project (nunit) F#
      NUnit 3 Test Item (nunit-test) F#
      NUnit 3 Test Project (nunit) VB
      NUnit 3 Test Item (nunit-test) VB
  Microsoft.AspNetCore.Blazor.Templates
    Templates:
      Blazor (hosted in ASP.NET server) (blazorhosted) C#
      Blazor Library (blazorlib) C#
      Blazor (Server-side in ASP.NET Core) (blazorserverside) C#
      Blazor (standalone) (blazor) C#

@danroth27 per my comment after the one asking for the output with -u, the nupkg in question doesn't contain any template.json files - so no new templates would appear from installing that package. The second command line that the original poster used did not include the version, which would install the latest stable from the feed, not the latest pre-release, so my assumption is that there is a stable version of that package on NuGet that does have the template.json files included. At a guess, I'd say something has changed in whatever build process produces that package.

@mlorbetske @danroth27  I added a global.js to control the sdk version.
It seems to work for dotnet 2.1.401
C:\git\temp
λ  dotnet --version
2.1.401
C:\git\temp
λ  dotnet new -u
Template Instantiation Commands for .NET Core CLI

Currently installed items:
 Microsoft.DotNet.Common.ItemTemplates
 Microsoft.DotNet.Common.ProjectTemplates.2.1
 Microsoft.DotNet.Test.ProjectTemplates.2.1
 Microsoft.DotNet.Web.ItemTemplates
 Microsoft.DotNet.Web.ProjectTemplates.2.1
 Microsoft.DotNet.Web.Spa.ProjectTemplates
 NUnit3.DotNetNew.Template
 TimeWarp.AspNetCore.Blazor.Templates
C:\git\temp

But switching to 2.1.402 and it goes away.
C:\git\temp
λ  dotnet --version
2.1.402
C:\git\temp
λ  dotnet new -u
Template Instantiation Commands for .NET Core CLI

Currently installed items:
 Microsoft.DotNet.Common.ItemTemplates
 Microsoft.DotNet.Common.ProjectTemplates.2.1
 Microsoft.DotNet.Test.ProjectTemplates.2.1
 Microsoft.DotNet.Web.ItemTemplates
 Microsoft.DotNet.Web.ProjectTemplates.2.1
 Microsoft.DotNet.Web.Spa.ProjectTemplates
 NUnit3.DotNetNew.Template
 Microsoft.AspNetCore.Blazor.Templates
C:\git\temp

@mlorbetske Ok I see my problem now.  And yes it is a yaml CI problem.  I was copying the structure of blazor itself and using .template.config.src but CI wasn't copying that to .template.config
The installation that I thought was working was a manual local build.  dotnet new -l doesn't tell us anything about the version or location so I didn't realize.
Now I gotta fix my CI yaml.
Thx much for the help.

Ok I have it working now on both nuget and MyGet.
Thanks to @mlorbetske and @danroth27
If anyone wants to review the source feel free https://github.com/TimeWarpEngineering/blazor-state/


fixes for flaky tests!

Using the latest commit 29ecb72845997402dbbe898ec7be48143ab198ed, There are 2 tests that flaky-fixes were made to

Test 1 : uk.gov.gchq.gaffer.commonutil.OneOrMoreTest.shouldAddItemsWithDeduplicate
Test 2: uk.gov.gchq.gaffer.commonutil.OneOrMoreTest.shouldAddAllItemsWithDeduplicate

Lets Dive deeper into these Tests and the fix provided for the issue:
Flakiness:
To check the flakiness of the test, I used a tool called nondex.
You can reproduce the tests using the commands below:
Test 1:
mvn install -pl core/common-util -am -DskipTests
mvn -pl core/common-util test -Dtest=uk.gov.gchq.gaffer.commonutil.OneOrMoreTest#shouldAddAllItemsWithDeduplicate
mvn -pl core/common-util edu.illinois:nondex-maven-plugin:2.1.1:nondex -Dtest=uk.gov.gchq.gaffer.commonutil.OneOrMoreTest#shouldAddAllItemsWithDeduplicate

Test 2:
mvn install -pl core/common-util -am -DskipTests
mvn -pl core/common-util test -Dtest=uk.gov.gchq.gaffer.commonutil.OneOrMoreTest#shouldAddItemsWithDeduplicate
mvn -pl core/common-util edu.illinois:nondex-maven-plugin:2.1.1:nondex -Dtest=uk.gov.gchq.gaffer.commonutil.OneOrMoreTest#shouldAddItemsWithDeduplicate

Using the tool above, I determined the tests to be flaky.
Why Nondex:
Flaky tests can be a source of frustration and uncertainty in any software project, often stemming from nondeterministic behaviors that are difficult to spot in traditional testing. Nondex provides a systematic and controlled approach to revealing these flaky tests by introducing random inputs, allowing maintainers and contributors to address them effectively.

By using Nondex, I aim to ensure the reliability of the project's test suite, making it more robust and resilient to unpredictable conditions. In doing so, I hope to contribute to the project's overall stability and the confidence of its users, while fostering a collaborative environment where code contributions can be made with greater certainty.

Issues related to Tests
In both tests, the  deduplicate is set to True  which implies that, there must not contain any duplicates in the collection which is basically a HashSet data structure.
According to the assertion, for both tests, assertThat(collection).containsExactlyElementsOf(expectedItems). Collection must contain exactly the same elements as expectedItems as well as maintain the order.
Although, HashSet data structure ensures that duplication does not occur, it cannot guarantee to maintain the initial order of the HashSet.
Fixes for both Tests
For both tests, I believe, the assertions are too strict and the order of the HashSet is not being required or mentioned in the javadoc of tests.
Hence, to fix the tests, I made changes using the assertion containsExactlyInAnyOrderElementsOf() which ensures the existence of the elements and does not consider the order of the elements in the HashSet
Please do let me know if you have any questions, I have added the permalinks to the tests for your perusal.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@kevin952 Thanks for the contribution! The CI is failing because the copyright header in the test you fixed is now out of date. If you run mvn spotless:apply it should fix this for you automatically, then you can recommit

@kevin952 Thanks for the contribution! The CI is failing because the copyright header in the test you fixed is now out of date. If you run mvn spotless:apply it should fix this for you automatically, then you can recommit

Hi. thanks for the update. I ran and made a recommit!

Hi @kevin952, the last commit (0f5bfb8c60cd21e211414d6430c068d2311dd3f7) is not associated with a GitHub account, but you can fix this with a force push. That is why the cla step in the CI is failing.


Custom Cache and ImageDownloader + Floating View

How can I use a custom cache and downloader? I use Kingfisher as my MainImageManager, so when loading a new image from url, both SKPhotoBrowser and Kingfisher downloading the photo.
P.S:
I had one other problem: I have a floating view (like FAB button), when dismissing a photo by swipe, it's animation covers the floating view till it's fit in the source rect. How can I manage this? (I've tried to send the animating view to back of the floating view, but in another view I have two floating buttons that this workaround won't work.)
Also when a photo is dismissed by swipe where source rect is not in view, the animation is weird (flickering till disappears), I've managed it by manipulating the SKPhotoBrowser class, but I just wanted to know do you have any straight solution for that?
Thanks! 😊

+1 for custom cache configuration. I'm going to try to work on a fork later today or tomorrow.

Hi @peymayesh. I've submitted a pull request with my custom cache solution.  In the mean time, if you're interested in testing, you can play with it on my fork:
https://github.com/kevinwo/SKPhotoBrowser

@peymayesh @suzuki-0000 has merged my pull request, so you should be able to use a custom cache now.

Sounds great, @kevinwo! How would you go about using a custom cache manager such as Kingfisher using your code?

@kevinwo Thanks! Did great! 👍


stream privacy [change] link UI update

If you are an organization administrator and you change the privacy level of a stream to be a private stream, and then immediately unsubscribe, the stream interface makes it look like you can still change the privacy level of the stream. You can't, but the other "I'm subscribed" controls (ie the notification controls) disappear, and the '[change]' link does not. It does disappear if you refresh the page.

@YJDave

@zulipbot claim


blueprint.route methods argument typo throws unclear exception

route method takes **options which catches all keyword arguments and passes it further to url_rule_class which -- in case of typo like 'method' instead of 'methods' -- leads to misleading exception:
[..]
File "/[..]/python2.7/site-packages/flask/app.py", line 943, in add_url_rule
  rule = self.url_rule_class(rule, methods=methods, **options)
TypeError: __init__() got an unexpected keyword argument 'method'

I don't see a practical way to do this sort of typo checking in a general way, and don't think it's useful enough to justify the complexity.  PyCharm, and possibly other IDEs, detect the correct kwargs.  If you're not using the IDE, you're in the same situation here as you would be with any other code that uses this pattern.  If anyone has a good argument and suggestion for why and how this should work, please open a new issue.

@Ceasar  ,I'm new to the flask
'''
TypeError: init() got an unexpected keyword argument 'method'
'''
change method to methods works

It's methods, not method.

3 years later and I had the same misspelling! I have been using Flask for more than a year and this have never happened to me hehe. Thanks @Ceasar

6 years later my friend also had the same error . Thanks @Ceasar for saving us from hours of debugging.


Ion Python's documentation needs to be improved

Some customers found that the lack of documentation makes them really hard to onboard Ion. This GH issue will be used for discussing a long-term solution.

https://github.com/amazon-ion/ion-python/pull/294#issuecomment-1791674096


rijndael-256 support

Hi there,
I know this will likely be out of scope, but how hard do you think it would be to support rijndael-256, which is the grand-father of AES, with just one difference in the block size I believe, which can be 256-bits while AES limit it to 128 iirc.
If you feel this isn't right, could you advice on how to write a tiny-rijndael-256, I hope the changes are small. Thanks !
https://web.archive.org/web/20130305143117/http://csrc.nist.gov/archive/aes/rijndael/Rijndael-ammended.pdf#page=1

Hi @bsergean and thanks for your interest in the project! :)
See this issue for a discussion of the same question https://github.com/kokke/tiny-AES-c/issues/171
Very quickly: Rijndael has variable key, block + round-number. AES has "hard-coded" round-number + block-size and this code has been "optimized" slighty for this case, i.e. loops have been unrolled etc.
You would be better off with an earlier version of this project, before optimizations. Then you'd probably be able to "configure" it to pure Rijdael or rewrite it. I don't have the energy myself unfortunately.
Best of luck :) :+1:


Add back Get-Counter cmdlet for Windows

PR Summary
Reviewed the APIs being used.  Get-Counter can work with just public APIs published in pdh.h.  Import-Counter and Export-Counter rely on undocumented APIs so those are removed.  The PDH apis are really old so I don't believe there's any chance to get those APIs or the binary log format documented so removed that code.
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[ ] Not Applicable
OR
[x] Documentation needed

[x] Issue filed: https://github.com/MicrosoftDocs/PowerShell-Docs/issues/5020

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[x] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:

Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

@SteveL-MSFT https://go.microsoft.com/fwlink/?linkid=2109647

@iSazonov nice find, seems that Tx is using a different set of APIs to read the log, not sure if there is a different public api to write the binary log.  I suggest we defer this for now.

@iSazonov created https://github.com/PowerShell/PowerShell/issues/10946

@SteveL-MSFT Can you run a coordinated package build and send me a Direct Message with the build information?  Let's verify this doesn't cause any new compliance issues.


compiler,runtime: panic in case of Scriggo type as map key when calling builtin 'delete'

cannot delete from a map when the key is a complex type.
Consider the following snippet:
package main

type key struct {
        X int
        Y int
}

func main() {
        println("starting population")
        mpbasic := map[int]int{}
        mpcomplex := map[key]int{}
        for i := 0; i < 256; i++ {
                mpbasic[i] = i * 2
                mpcomplex[key{X: i, Y: i + 1}] = i * 2
        }
        println("starting delete simple")
        for k := range mpbasic {
                delete(mpbasic, k)
        }
        println("starting delete complex")
        for k := range mpcomplex {
                if mpcomplex[k] > 2 {
                        delete(mpcomplex, k)
                }
        }
        println("done")
}

When run using the GC we get the following output (runs to completion):
starting population
starting delete simple
starting delete complex
done

When run using scriggo we get the following output with a panic:
panic: reflect.Value.SetMapIndex: value of type types.emptyInterfaceProxy is not assignable to type struct { X int; Y int }

goroutine 1 [running]:
github.com/open2b/scriggo/internal/runtime.(*VM).Run(0xc0000e4240, 0xc0000a5520, 0xc00009e970, 0x0, 0x0, 0x0, 0x0, 0x0)
	/home/kris/mygo/pkg/mod/github.com/open2b/scriggo@v0.53.2-0.20211019155432-8c493a4aa1f8/internal/runtime/vm.go:161 +0x169
github.com/open2b/scriggo.(*Program).Run(0xc0000a1380, 0x0, 0x0, 0xc0000a1380)
	/home/kris/mygo/pkg/mod/github.com/open2b/scriggo@v0.53.2-0.20211019155432-8c493a4aa1f8/programs.go:143 +0xd6
main.main()
	/tmp/scriggo_test/main.go:19 +0x13f

I am building off of the tip of master (commit 8c493a4aa1f8014e3f10a9e447b3ab45ab71967f)
It appears that the range iterator on a map hands back some sort of pointer when using complex map key types, but the delete function cannot handle that pointer.  Using native types for the key this completes fine.
Complete test program
package main

import (
        "fmt"

        "github.com/open2b/scriggo"
)

func main() {
        // Create a file system with the file of the program to run.
        fsys := scriggo.Files{"main.go": []byte(src)}

        // Build the program.
        program, err := scriggo.Build(fsys, nil)
        if err != nil {
                panic(err)
        }
        // Run the program.
        err = program.Run(nil)
        if err != nil {
                fmt.Println("RUN ERROR", err)
        }
        fmt.Println("DONE")
}

const src = `
        package main

        type key struct {
                X int
                Y int
        }

        func main() {
            println("starting population")
            mpbasic := map[int]int{}
            mpcomplex := map[key]int{}
            for i := 0; i < 256; i++ {
                mpbasic[i] = i*2
                mpcomplex[key{X: i, Y: i+1}] = i*2
            }
            println("starting delete simple")
            for k := range mpbasic {
                delete(mpbasic, k)
            }
            println("starting delete complex")
            for k := range mpcomplex {
                if mpcomplex[k] > 2 {
                        delete(mpcomplex, k)
                }
            }
            println("done")
        }

`

wow, great work guys!  Thank you very much.


Add ESP32 port

Simple port for ESP32
https://github.com/happyme531/TinyMaix-espidf_test
For sipeed2022_autumn_competition/sw_beginner

thank you for you test! I notice the speed is significantly slower than same freq's other chip, maybe it is caused by flash speed. Can you try put model content in ram (remove "const") and run again? esp32's ram is enough to put mnist,cifar,vww model.

config
mnist
cifar
vww96
mbnet128
Note

O0 CPU
2.29
167.8
480.48
865.04
Model in Flash

O1 CPU
1.92
132.1
476.45
754.54
Model in Flash

O0 CPU
2.15
126.4
------
------
Model in RAM

O1 CPU
1.79
91.38
------
------
Model in RAM

Note: ESP32's RAM is segmented. The largest segment is only ~110KB so it can't hold the vww96 model.


Duplicated library references in 5.151.1

Description
After patching Paket to 5.151.1 (from 5.150.0) resolution behavior changed for some reason for package System.Net.Http - it is now referenced through Paket, even though it should not be.
Repro steps

Create .Net Framework 4.6 project.

(potentially optional) Make sure, that System.Net.Http is in packet.lock file (as a depedency to something else, for example .NetStandard 2.0. Make sure that System.Net.Http is NOT inside paket.dependencies or paket.reference

Reference System.Net.Http through assemblies project reference (reference .net framework library version 4.0.0).

run paket.exe install

Expected behavior
Only 1 reference, through <Reference Include="System.Net.Http" /> should be present in *.csproj file - this basically references System.Net.Http 4.0.0 from .Net Framework.
Actual behavior
Reference in expected behavior exists, however, additional one is added from packages in form of:
<Choose>
    <When Condition="$(TargetFrameworkIdentifier) == '.NETFramework' And $(TargetFrameworkVersion) == 'v4.6'">
      <ItemGroup>
        <Reference Include="System.Net.Http">
          <HintPath>..\packages\System.Net.Http\lib\net46\System.Net.Http.dll</HintPath>
          <Private>True</Private>
          <Paket>True</Paket>
        </Reference>
      </ItemGroup>
    </When>
  </Choose>

References version is slightly newer, so compilation fails because 2 libraries with same types are references.
Known workarounds
Downgrade to packet version 5.150.0.

this was done in https://github.com/fsprojects/Paket/pull/3107
@0x53A @matthid I knew this would only take couple of hours to pop up

Hi,
I read through conversion in #3107 as it looked relevant. However, I don't get I think the extent of changes based on the conversation. From what I understood from "after" section - it should be ok to have duplicate references (compiler will take higher version - not working in my case) and this should be relevant to people who had referenced .net framework library and then added same reference through Paket (which I am explicitly not doing - hence not having anything in dependencies or references files which touches System.Net.Http).
I am probably mis understanding what has changed from conversation in #3107?

ok reverting for now since I have to sign off for today.
@0x53A can you please look at the case? I can then merge again tomorrow

@0x53A @matthid I knew this would only take couple of hours to pop up

This is what I meant with it was an active decision to do it as it was before, we just didn't search for the old issue ;)
@Ravadre what errors do you get? Can you post for reference?

I can confirm that with reverted changes (5.151.3) it works fine.
@matthid We noticed the problem on our CI server, where we're running new paket with every build. Problem can be pinpointed to basically System.Net.Http package added to references in csproj (the choose section in actual behavior in OP was basically added between what we have after paket.exe install with older version (locally) and CI version (newer paket.exe). This as a result made compiler errors, which can be pinpointed to this one error:
Currencies\FixerApiClient.cs(16, 33): error CS0433: The type 'HttpClient' exists in both 'System.Net.Http, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'System.Net.Http, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'

Multiplicated many times for every usage of a type from System.Net.Http.
I can try to create a small repro project if it will help you.

@matthid I thought it might be useful anyway :) :
https://github.com/Ravadre/paket-151_1-repro
If you will download paket.exe 5.151.1 with .paket\paket.bootstrapper.exe 5.151.1 it should fail to build the project.
There are probably smaller number of packages which can trigger this behavior added to paket.dependencies (I took this list from our smallest project which broke on CI) - I cannot dive into it more, altough list is small enough I think. I guess the problem can be somewhere in paket.lock with  NETStandard.Library (2.0.1) - which references few packages, System.Net.Http (4.3.2) being one of it.
With paket 5.151.1, after paket install command you will see double references in csproj as described in OP.
I hope that helps :)

@Ravadre sorry, for breaking you.
Please note that the "old" behavior is really dangerous - you (implicitly) reference the nuget package System.Net.Http, which contains a dll ....

But that Dll is missing from /bin!

I thought that MSBuild would resolve these duplicated references to warnings, but apparently that was wrong.
@forki @matthid I would suggest to do the same as nuget, and just remove the FW-Reference. What do you think?

Hi @0x53A .
I think that the library is missing from bin, because if it references as a GAC library (the 4.0.0) version. The one that is included by Paket in 5.151.1 version is newer (4.1.XX) and would be put into bin as a package - but what I think matters here is, as you said "implicitly".
An user could implicitly target such problematic library (Net.Http or similar) without knowing it and Paket would assume that it need to copy it. If the reference would be explicit (in paket.references) I would just remove the GAC reference.
To be honest, solving this issue is pretty simple: once I knew what is going on (implicit reference included problematic library in project) I could have just included it explicitly and then removing GAC reference, which would (probably) work. - I posted a ticket because I knew that for some people this implicit include would be a mystery and I wanted you guys to know about it ASAP before more people would start banging on the doors ;-).
I guess the 5.151.1 behavior is not that wrong, but it's kind of "hidden". Out of 2 solutions (remove GAC by Paket or not include implicitly targeted libraries (instead, force them to be explicitly targeted in references) I would probably lean towards 2nd one (as 1st one will change people's GAC references without letting them know) - it for for you guys to decide though.

It is not related to whether the reference is implicit or explicit. Rather the deciding factor currently is just whether the project file already contains a GAC reference or not (<Reference Include="System.Net.Http" />). So you would get the same bug with an explicit reference.
Yes, the "fix" is to remove the GAC-Reference and rerun paket install. Then it will add the correct reference to the nuget version. You don't need to add it explicitly to the paket.references.
5.151.1 is definitely wrong, because twice referenced causes an error, I thought it would just cause a warning.
Imo the behavior of paket < 5.151.1 (and now after the revert) is also wrong, but the question is how it can be remedied without causing too much breakage. Maybe wait for the next major version?

Just to clarify - I didn't mean that explicit / implicit would behave differently. I just meant that if I (or more broadly - any user) would explicitly reference the problematic library, I would know in case of compilation error what I did wrong (reference same library through GAC and through Paket), in case of implicit reference - one can be surprised and don't know from where the error came.
Btw, is possible to inject a compiler error through Paket.targets? Maybe a solution would be to, in case of seeing both GAC referenced library and a different version referenced by Paket to include both - reference newer package (which will break compilation), but also include some tag, for example <DuplicateReference packageName="System.NetHttp"></DuplicateReference> which would add compiler error with a message to signal user what's wrong? Something like "One of your packages included {packageName} implicitly, you have however referenced older version through GAC. Consider adding explicit reference to {packageName} in paket.references and remove GAC reference to include only newer version of the library". - Just a thought, if possible to achieve?

Maybe wait for the next major version?

We either have removing existing references, leave it as is or break (but then a better error message is needed).
It is unlikely that we remember this issue when we decide to release a new major version.

Btw, is possible to inject a compiler error through Paket.targets?

We can emit an error on paket install time.


Game is running (DO NOT CLOSE LAUNCHER) taking forever and not launching Genshin Impact

Describe the bug
The launcher has been up for a good hour yet it still hasn't launched Genshin Impact.
Screenshots

System Information (please complete the following information):

macOS: 13.3 Ventura
Device: iMac 24inch 2021
CPU: Apple M1
RAM: 8gb

Additional context
Add any other context about the problem here.
Logs (if any)

If it's related to the launcher, upload neutralinojs.log in Yaagl Data Directory

If it's related to the game, upload `logs/game_{timestamp}.log in Yaagl Data Directory

Describe the bug The launcher has been up for a good hour yet it still hasn't launched Genshin Impact.
Screenshots
System Information (please complete the following information):

macOS: 13.3 Ventura
Device: iMac 24inch 2021
CPU: Apple M1
RAM: 8gb

Additional context Add any other context about the problem here.
Logs (if any)

If it's related to the launcher, upload neutralinojs.log in Yaagl Data Directory

If it's related to the game, upload `logs/game_{timestamp}.log in Yaagl Data Directory


Can't run on React.js

The error:
TypeError: google_translate_api_x__WEBPACK_IMPORTED_MODULE_1__ is not a function
I've tried using this library on vanilla js and it works just fine. But when I tried it on React it keeps getting error like in the above even I use the simpliest method to use this library. Is there any settings that I have to apply first in my React project before using this library?
Sorry for my english and I'm new to React and JavaScript, so it will be so kind of you if you can give me an assistance.
Btw, thanks for providing this library

This library isn't compatible with web react, generally, because of CORS.  But that shouldn't make this error.  What version of this package are you using?  Also, what version of node are you using?  And, can you post your babel configuration?

Inactive


@ngtools/webpack 1.7.3.TypeError: ts.createModuleResolutionCache is not a function

hello I used angular-cli to build my project
I can build succeed three days ago. But I get wrong today. I saw ngtools/webpack is updated.
use angular-cli: 1.0.0-beta.28.3
use ngtools/webpack 1.7.3
I got error 。
ts.createModuleResolutionCache is not a function
TypeError: ts.createModuleResolutionCache is not a function
at AotPlugin._setupOptions (/workspace/angularjs/node_modules/.1.7.3@@ngtools/webpack/src/plugin.js:146:42)
at new AotPlugin (/workspace/angularjs/node_modules/.1.7.3@@ngtools/webpack/src/plugin.js:30:14)
at Object.exports.getNonAotConfig (/workspace/angularjs/node_modules/.1.0.0-beta.28.3@angular-cli/models/webpack-configs/typescript.js:26:13)
at new NgCliWebpackConfig (/workspace/angularjs/node_modules/.1.0.0-beta.28.3@angular-cli/models/webpack-config.js:24:37)
at Class.run (/workspace/angularjs/node_modules/.1.0.0-beta.28.3@angular-cli/tasks/build.js:16:29)
at Class.buildRun (/workspace/angularjs/node_modules/.1.0.0-beta.28.3@angular-cli/commands/build.run.js:12:22)
at Class.run (/workspace/angularjs/node_modules/.1.0.0-beta.28.3@angular-cli/commands/build.js:40:47)
at Class. (/workspace/angularjs/node_modules/.1.0.0-beta.28.3@angular-cli/ember-cli/lib/models/command.js:134:17)
at
at process._tickCallback (internal/process/next_tick.js:188:7)
I changed the ngtools/webpack to 1.7.1 is right.

The CLI version used is quite outdated.  The current stable version is 1.4.6.  Note also that the package name changed during the 1.0-beta phase to @angular/cli.

i have a error but  donno how fix it,  delete so many times "node_modules" and reinstall nothing change always same error.

ERROR in TypeError: Cannot use 'in' operator to search for 'providers' in null
    at C:\Users\iii\WebstormProjects\iii\node_modules\@angular\compiler-cli\src\ngtools_impl.js:111:73
    at Array.filter (native)
    at _extractLazyRoutesFromStaticModule (C:\Users\iii\WebstormProjects\iii\node_modules\@angular\compiler-cli\src\ngtools_impl.js:111:29)
    at C:\Users\iii\WebstormProjects\iii\node_modules\@angular\compiler-cli\src\ngtools_impl.js:129:27
    at Array.reduce (native)
    at _extractLazyRoutesFromStaticModule (C:\Users\iii\WebstormProjects\iii\node_modules\@angular\compiler-cli\src\ngtools_impl.js:128:10)
    at includeLazyRouteAndSubRoutes (C:\Users\iii\WebstormProjects\iii\node_modules\@angular\compiler-cli\src\ngtools_impl.js:66:25)
    at Array.reduce (native)
    at includeLazyRouteAndSubRoutes (C:\Users\iii\WebstormProjects\iii\node_modules\@angular\compiler-cli\src\ngtools_impl.js:67:26)
    at Array.reduce (native)
    at Object.listLazyRoutesOfModule (C:\Users\iii\WebstormProjects\iii\node_modules\@angular\compiler-cli\src\ngtools_impl.js:54:36)
    at Function.NgTools_InternalApi_NG_2.listLazyRoutes (C:\Users\iii\WebstormProjects\iii\node_modules\@angular\compiler-cli\src\ngtools_api.js:91:39)
    at AotPlugin._getLazyRoutesFromNgtools (C:\Users\iii\WebstormProjects\iii\node_modules\@angular\cli\node_modules\@ngtools\webpack\src\plugin.js:207:44)
    at _donePromise.Promise.resolve.then.then.then.then.then (C:\Users\iii\WebstormProjects\iii\node_modules\@angular\cli\node_modules\@ngtools\webpack\src\plugin.js:443:24)
    at process._tickCallback (internal/process/next_tick.js:109:7)

@istiti that seems like a different problem. Can you open a new issue and include all details in the issue template please?

done https://github.com/angular/angular-cli/issues/8025
cc @filipesilva

same issue here ..

Can you provide the TypeScript version used with the project?

have to say I'm not too happy about this....
using angular cli 1.0.0-beta.25.5
angular 2.4.3
typescript 2.0.3
and now a breaking change in webpack causes all my builds to fail.

@TylerDev6 can you try updating typescript to 2.1 please?

@filipesilva will do.

@filipesilva did the trick.

Glad to hear it. That's the workaround for now, we're looking at our options to address this.

@filipesilva correction.... moving straight to 2.1.0 fails with
AppModule is not an NgModule
moving to ~2.0.3 fixed it though

For those who have the same issue but running the latest angular cli (1.4.6), just update your typescript version (I installed ~2.5.3, and worked correctly). Maybe after typescript update you have to make a few changes on your code, because of type errors that the older typescript version did not check or notice about.

step:1
Update your angular CLI using this sudo npm install --save-dev @angular/cli@latest
step:2
In Mac, press Shift+Command+H then select the Home option. Now select package.json,package-lock.json file and delete both the files.
step:3
Restart your terminal and then it will work.

@ngtools/webpack 1.7.4 has been released with a fix that handles the lack of certain functionality in TS versions less than 2.1.5.
@RanjithRana just a quick comment that running npm with sudo is dangerous and should not be necessary.  (check out nvm for managing node installations).

This has been fixed in #8028 .


Conv1D module

PR Implements a Conv1D module
pub struct Conv1D<
    const CHANNELS_IN: usize,
    const CHANNELS_OUT: usize,
    const KERNEL: usize,
    const STRIDE: usize,
    const DILATION: usize,
    const DIM_OUT: usize,
    const POOL_OUT: usize,
> {
    pub weight: GraphTensor<R3<CHANNELS_IN, CHANNELS_OUT, KERNEL>>,
}

Looking at how dfdx does it, they require nightly for conv: https://github.com/coreylowman/dfdx/blob/4615ac105a16f45e45d6ccfd403099daf437a944/dfdx/src/nn/layers/conv2d.rs#L154C1-L154C1
I don't want to, so perhaps it makes sense to just not implement Module, and instead implement a custom forward function with a shape generic so the user can provide the output shape.

Ok, pushed some of the generics to the custom forward method
impl<
        const CHANNELS_IN: usize,
        const CHANNELS_OUT: usize,
        const KERNEL: usize,
        const STRIDE: usize,
        const DILATION: usize,
        const CHANNELS_IN_TIMES_KERNEL: usize,
    > Conv1D<CHANNELS_IN, CHANNELS_OUT, KERNEL, STRIDE, DILATION, CHANNELS_IN_TIMES_KERNEL>
{
    fn forward<const DIM_IN: usize, const DIM_OUT: usize>(
        &self,
        input: GraphTensor<R2<CHANNELS_IN, DIM_IN>>,
    ) -> GraphTensor<R2<CHANNELS_OUT, DIM_OUT>> {
        input
            .pool_last_dim::<R3<CHANNELS_IN, DIM_OUT, KERNEL>>(
                KERNEL.into(),
                STRIDE.into(),
                DILATION,
            )
            .permute::<_, Axes3<1, 0, 2>>()
            .reshape::<R2<DIM_OUT, CHANNELS_IN_TIMES_KERNEL>>()
            .matmul(
                self.weight
                    .permute::<_, Axes3<2, 1, 0>>()
                    .reshape::<R2<CHANNELS_IN_TIMES_KERNEL, CHANNELS_OUT>>(),
            )
            .permute::<_, Axes2<1, 0>>()
    }
}

Added a new test which doesn't pass yet. Will need to debug to figure out the issue

Now test passes, this is where the design has landed after the bug fixes
pub struct Conv1D<
    const CHANNELS_IN: usize,
    const CHANNELS_OUT: usize,
    const KERNEL: usize,
    const STRIDE: usize,
    const DILATION: usize,
    const CHANNELS_IN_TIMES_KERNEL: usize,
> {
    pub weight: GraphTensor<R2<CHANNELS_OUT, CHANNELS_IN_TIMES_KERNEL>>,
}

impl<
        const CHANNELS_IN: usize,
        const CHANNELS_OUT: usize,
        const KERNEL: usize,
        const STRIDE: usize,
        const DILATION: usize,
        const CHANNELS_IN_TIMES_KERNEL: usize,
    > Conv1D<CHANNELS_IN, CHANNELS_OUT, KERNEL, STRIDE, DILATION, CHANNELS_IN_TIMES_KERNEL>
{
    fn forward<const DIM_IN: usize, const DIM_OUT: usize>(
        &self,
        input: GraphTensor<R2<CHANNELS_IN, DIM_IN>>,
    ) -> GraphTensor<R2<CHANNELS_OUT, DIM_OUT>> {
        self.weight.matmul(
            input
                .pool_last_dim::<R3<CHANNELS_IN, DIM_OUT, KERNEL>>(
                    KERNEL.into(),
                    STRIDE.into(),
                    DILATION,
                )
                .permute::<_, Axes3<0, 2, 1>>()
                .reshape::<R2<CHANNELS_IN_TIMES_KERNEL, DIM_OUT>>(),
        )
    }
}


The connected server(s) does not support method textDocument/hover

lsp-julia 20210530.2152
Julia 1.5
Windows 10
Emacs 27.2
I am using the bundled LanguageServer, i.e. lsp-julia-package-dir is ~/.emacs.d/elpa/27.2/develop/lsp-julia-20210530.2152/languageserver.
When in a Julia file, since I get no help on a function under point, I explicitly call lsp-ui-doc-show and get the error:
helm-M-x-execute-command: The connected server(s) does not support method textDocument/hover.
To find out what capabilities support your server use ‘M-x lsp-describe-session’
and expand the capabilities section

When I do lsp-describe-session I get the relevant section
 `-[-] julia-ls:11476/starting
    |-[-] Buffers
    |  `-[+] pendulum.jl
    `-[+] Capabilities

and Capabilities section is empty. Any hints for debugging further?

Sorry for the noise, it was right there: julia-ls:11476/starting ... after a while the /starting part disappears and everything works smoothly.

I guess this was precompilation...


Bump development release 1.28

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

/approve
/unhold


feat: script to count english strings changes

Description
An utility script the Globalization WS uses to count the English strings and words which were added/modified since a certain commit. Usually to find out the monthly count of words that have been requested for translation to our translators working for bounties over a period of time.

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[x] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

N/A
Risk
None.

Testing
None needed. If you want to observe the results you can test by entering this commit for example: 207ad7b99e2661e3202ffbccc8496032b87a41d9
The output will vary based on your current working copy state.

Engineering

Operations

Screenshots (if applicable)

Thanks for the review, suggestions applied and fixed so the script works again ;)


[REQUEST] "Show full log" in a .txt file and opened by default textEditor

Hello
As the title of this, say !
I had to chance to try OB in different winOS
And i am afraid to say that there is always this problem when i am trying to show the full log of a hit in the runner.
this problem cause:
=> the bots status to freeze until OB create a console window with the full log
so it would be good if OB write that log to a .txt file and open with the default textEditor
thanks for reading until here

also an option to have to stacker's debug log in a text file is good, because now openbullet can't handle huge sources
or an option to disable RichTextBox and use another shit temporary


Typo fix

successfull -> successful

@matmair any hints on the playwright tests failing here?

Might be a change in capitalisation, trying to fix it on #5301


LibGdx Class Ray : setting a new direction does not normalize the vector

When creating a ray, the direction vector is normalized as it should
public Ray (Vector3 origin, Vector3 direction) {
	this.origin.set(origin);
	this.direction.set(direction).nor();
}

but when a new direction is set, the vector is NOT normalized, which is an error
public Ray set (Vector3 origin, Vector3 direction) {
	this.origin.set(origin);
	this.direction.set(direction);
	return this;
}

these codes are extracted from LibGdx 1.9.11-SNAPSHOT but applies probably to all previous versions.
An obvious consequence is that Ray#getEndPoint(final Vector3 out, final float distance) may return a wrong distance because of a direction vector not normalized.
Laurent Crenier (gquark)

This needs further discussion. See discord.

Happy to see that my little inconsistency bug report generates so much debate ;-)

It shows how much LibGDX is active.


Fix issue where DEFAULT_CIPHERS is not supported in urrlib3>=2

Thanks, it helped me.

Great it worked Thank you

Can we merge and release this ?


Feature Request: Site Config with Auto-Menu

Sites have a versioned config file that gets sent when the user's version is behind. When a user visits a site, it checks if there is a config-version header and matches it against their config version, and re-caches if the version changes.
The site config may contain other valuable data, but the primary focus of this request is the the auto-menu. An example config file may contain something like this:
<menu>
#HomePage @/home
#Blog @/blog
##2024 Stuff @/blog/2024
##2023 Stuff @/blog/2023
##2022 Stuff @/blog/2022
#Projects
##My Cool Guitar Solos @/music/guitar
##My Artwork @/art-and-stuff

All you need to define is the links, then the browser automatically templates it with the browser's theme. It handles responsiveness so that the user doesn't have to do anything to make it look good.
This can pull directly from the #38 Auto Pages request. For example, one way to implement it would be to have the browser automatically insert a menu tag, e.g.  and then the user could overwrite the CSS if they wanted to, or insert it directly and overwrite its placement entirely.
Advantages:

Webmasters can effortlessly include a fully responsive menu. No hassle. No coding.
Cached menus. No need to resend unless expiration is set. Saves on bandwidth.
No additional CSS is required (but can be optionally overwritten).
Much faster to implement sites, and entries will be far less likely to appear low effort.

I feel like this is a pretty niche feature so it's not currently planned
A Lua function to get the browser version may be implemented


#114 Rotating Phone Restarts Application fixed

Sorry I haven't got around to testing that this PR fixes the problem. I'll have a look when I'm next able.

Hi, thank you, I'll be waiting. I also added some unit tests for class FileItemHelper.


Inconsistent .sf config file locations

Summary
My sf config files are located in ~<username>/.sf which includes a file called config.json, sf.json, and others. sf also has files in ~<username>/.local/share/sf.
The latest release notes for 2.37.4 say to put the plugin allowlist file into $HOME/.config/sf
However, there is no folder for me in that location, and it seems like a mistake to spread sf config files across multiple directories. Of note, sf items are also in .local/share/sf - maybe this is where the allowlist file should go, since it's where the plugins are listed?
Is this a bug in the documentation? Or is it a "bug" in the execution and a poor design choice?
If I'm totally wrong and $HOME is not my user directory in MacOS, then why are sf files being stored outside my user directory? So I'm assuming that this .sf/config folder doesn't exist.
Steps To Reproduce
Look in your own sf configuration files and find a folder (hidden in MacOS) called .sf in your user directory. Also find plugin configuration in .local/share/sf.
Expected result
The allowList should be placed in the .sf folder or the .local/share/sf folder. (Probably the latter, as it contains the plugins JSON.)
Actual result
The documentation says to put it in config/.sf (a folder that does not exist).
Should the documentation or the CLI be changed? That's up to you!
System Information

(Installed VSCode and sf cli today on fresh machine - this is as pure as it gets.)
MacOS
zsh in VSCode
{
  "architecture": "darwin-arm64",
  "cliVersion"<EMAIL_ADDRESS>  "nodeVersion": "node-v20.11.1",
  "osVersion": "Darwin 23.4.0",
  "rootPath": "/Users/<username>/.local/share/sf/client/2.36.8-fa01960",
  "shell": "zsh",
  "pluginVersions": [
    "@oclif/plugin-autocomplete 3.0.13 (core)",
    "@oclif/plugin-commands 3.2.2 (core)",
    "@oclif/plugin-help 6.0.20 (core)",
    "@oclif/plugin-not-found 3.1.1 (core)",
    "@oclif/plugin-plugins 5.0.5 (core)",
    "@oclif/plugin-search 1.0.20 (core)",
    "@oclif/plugin-update 4.2.3 (core)",
    "@oclif/plugin-version 2.0.16 (core)",
    "@oclif/plugin-warn-if-update-available 3.0.15 (core)",
    "@oclif/plugin-which 3.1.7 (core)",
    "@salesforce/cli 2.36.8 (core)",
    "apex 3.1.3 (core)",
    "auth 3.5.1 (core)",
    "data 3.2.4 (core)",
    "deploy-retrieve 3.5.3 (core)",
    "info 3.1.2 (core)",
    "limits 3.2.1 (core)",
    "marketplace 1.1.0 (core)",
    "org 3.6.3 (core)",
    "packaging 2.3.0 (core)",
    "schema 3.2.0 (core)",
    "settings 2.1.2 (core)",
    "sobject 1.2.1 (core)",
    "source 3.2.2 (core)",
    "telemetry 3.1.17 (core)",
    "templates 56.1.0 (core)",
    "trust 3.5.1 (core)",
    "user 3.4.3 (core)"
  ]
}

Additional information
If the new release will create this .config/sf folder, then that's interesting - is that part of a longer-term plan?

Hi @dschach  - There's different config files for different purposes. This config file is an OCLIF level config file for the CLI as a whole. This is the correct place for it. It's alright if it doesn't exist, you can create one, and then when installing plugins, OCLIF will look in that location, for the sf cli config file, and use it correctly


RMD KNITR EDIT

Greetings from the git world! First issue, very exciting.
How would I edit the Rscript chunk from lines 10-14? It relates back to pulling a different file name than what I have saved on my laptop (ended up renaming the file).
Any ideas? @kristenpeck

Might be a quick fix - basically the rmd file is pulling objects from the SmallLakesDB.R script through source(SmallLakesDB.R). All that does is run the whole R script and store all of the objects in the environment, which are then called in the rmd script. If you want to change the excel file, you'll need to go to the SmallLakesDB.R script and edit the read_excel() in the R script for effort, catch and env objects. Try it, let me know if it works!

@fishandwildlifejames did that fix work?


Reworks probe record version manipulation

The dusty binary now mmaps the target file, rather than reading the whole thing in. This trades a bit of speed in the form of page faults, for laziness, and only reads the required portions of the file.
Reworks how we read and potentially update the probe record version stored in the target file. First, adds an argument to the process_section function controlling whether we want to bother updating the version. dusty does not set this, whereas the code that registers the probes does. Second, makes the bytes in which the probe records are stored mutable everywhere, which properly communicates the intent that these may be updated. Lastly, we avoid further inline assembly and some portability issues by using an atomic rather than a lock xchg instruction. That currently works by transmuting the byte storing the probe record version, but may work with no unsafe code when the AtomicU8::from_mut method is stabilized. In either case, the code should be sound at this point, since writing to that data is now done through an exclusive reference.

This should also fix #66, by removing the asm! invocation that referred to an x86 register. By using AtomicU8, there's no dependency on the target arch at all.

Friendly ping on this @ahl

This should resolve the following:

#58 We're now passing a mutable array of bytes all the way down to the point of an atomic CAS, so this no longer applies
#59 We mmap the file now, which has the benefit of being slightly lazier. It turns out we usually need to read the bulk of the file to find the probe records anyway, but in some circumstances it will result in less IO. Note that this comes at the expense of speed, since we trade reading the whole file up front for the faults we take when needing to read in the next chunk of the file.
#64 is obsoleted by this. Many thanks to the author of that PR for bringing this up and proposing solutions. We've adopted some of them here.
#66 We've removed the inline assembly the previously implemented the probe version atomic CAS. That means we don't rely on the target arch, and so should compile on aarch64 just fine.


Update react and react-dom peer dependency to ^18.2.0

Description
Updated the react and react-dom peer dependency in package.json to "^18.2.0" to allow installation of later versions while maintaining compatibility with the package.
Related Issue
Fixes #423
Motivation and Context
This change is necessary to address the issue of restricting the installation of later versions of React due to the exact version requirement in the peer dependency configuration of beautiful-react-hooks.
How Has This Been Tested?
Conducted basic tests by running npm test and npm build to ensure that the package can still be built and tested successfully after updating the React peer dependency.

thank you @fakkio
hero! :)


input/inpututils: fix non-64-bit aligmment of atomic variables

On 32-bits platforms, atomically accessing a 64-bit variable
which is not 64-bit aligned panics, since these accesses are
not guaranteed to effectively be performed atomically.
hint: in Go, a global variable, as well as the first field of
a struct, is guaranteed to be 64-bit aligned, even on 32-bit
platforms.

Codecov Report

Merging #188 (ffb9552) into main (40a57bc) will increase coverage by 1.90%.
The diff coverage is 81.39%.

@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
+ Coverage   53.95%   55.86%   +1.90%
==========================================
  Files          60       62       +2
  Lines        4003     4615     +612
==========================================
+ Hits         2160     2578     +418
- Misses       1646     1837     +191
- Partials      197      200       +3

Impacted Files
Coverage Δ

api.go
100.00% <ø> (ø)

filter/clausefilter.go
73.50% <0.00%> (+1.18%)
:arrow_up:

filter/clear_fields.go
75.00% <0.00%> (+10.71%)
:arrow_up:

filter/concatenate.go
81.81% <0.00%> (+5.15%)
:arrow_up:

filter/dedup.go
90.32% <0.00%> (+1.86%)
:arrow_up:

filter/expand_json.go
96.61% <0.00%> (+0.45%)
:arrow_up:

filter/format_time.go
97.91% <0.00%> (+0.11%)
:arrow_up:

filter/hash.go
77.55% <0.00%> (+0.46%)
:arrow_up:

filter/metadata_lastmodified.go
89.47% <0.00%> (+0.58%)
:arrow_up:

filter/metadata_url.go
92.59% <0.00%> (+0.28%)
:arrow_up:

... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb947b6...ffb9552. Read the comment docs.


apt.repo fails to recognise already present repository

Describe the bug
Running a deploy with an apt.repo operation results in that repository being added despite being already present from a previous run.
To Reproduce
This is part of the deploy to an Ubuntu 20.04 server:
apt.repo(
    name="Add Docker apt repository",
    src=f"deb [arch=amd64 signed-by=/usr/share/keyrings/docker-archive-keyring.gpg] https://download.docker.com/linux/ubuntu {host.get_fact(LsbRelease)['codename']} stable",
    sudo=True,
)

Running the deploy multiple times results in identical lines being added:
deb [arch=amd64 signed-by=/usr/share/keyrings/docker-archive-keyring.gpg] https://download.docker.com/linux/ubuntu focal stable
deb [arch=amd64 signed-by=/usr/share/keyrings/docker-archive-keyring.gpg] https://download.docker.com/linux/ubuntu focal stable

Expected behavior
It should be recognised that the repo is already present and nothing needs to be done.
Meta

Include output of pyinfra --support.

--> Support information:

    If you are having issues with pyinfra or wish to make feature requests, please
    check out the GitHub issues at https://github.com/Fizzadar/pyinfra/issues .
    When adding an issue, be sure to include the following:

    System: FreeBSD
      Platform: FreeBSD-13.0-RELEASE-p4-amd64-64bit-ELF
      Release: 13.0-RELEASE-p4
      Machine: amd64
    pyinfra: v1.4.18
    Executable: /home/yggdrasil/.local/bin/pyinfra
    Python: 3.8.12 (CPython, Clang 11.0.1 (git@github.com:llvm/llvm-project.git llvmorg-11.0.1-0-g43ff75f2c)

How was pyinfra installed (source/pip)?
pipx

+ Include pyinfra-debug.log (if one was created)

Consider including output with -vv and --debug.

pyinfra --debug -vv inventories/gfnwtestbed.py install_executor_apt.py
    [pyinfra_cli.main] Checking potential directory:
    [pyinfra_cli.main] Setting directory to:
--> Loading config...
--> Loading inventory...
    [pyinfra_cli.inventory] Creating fake inventory...
    [pyinfra_cli.inventory] Looking for group data in: group_data/executor.py
    [pyinfra_cli.inventory] Looking for group data in: group_data/all.py

--> Connecting to hosts...
    [pyinfra.api.connectors.ssh] Connecting to: executor.gfnw ({'allow_agent': True, 'look_for_keys': True, 'hostname': 'executor.gfnw', 'username': 'infrastructure', 'timeout': 10})
    No host key for fd4b:5320:4954:6464:4::<IP_ADDRESS> found in known_hosts
    [executor.gfnw] Connected
    [pyinfra.api.state] Activating host: executor.gfnw

--> Preparing operations...
    Loading: install_executor_apt.py
    [pyinfra.api.facts] Getting fact: lsb_release () (ensure_hosts: (Host(executor.gfnw),))
    [pyinfra.api.connectors.ssh] Running command on executor.gfnw: (pty=False) sh -c '! command -v lsb_release >/dev/null || lsb_release -ca'
[executor.gfnw] >>> sh -c '! command -v lsb_release >/dev/null || lsb_release -ca'
    [pyinfra.api.connectors.ssh] Waiting for exit status...
    [pyinfra.api.connectors.ssh] Command exit status: 0
    Loaded fact lsb_release ()
    [pyinfra.api.operation] Adding operation, {'Add Docker apt repository'}, opOrder=(5,), opHash=e7bd4757a271fd0d45eb5671af07ea672a855973
    [pyinfra.api.facts] Getting fact: apt_sources () (ensure_hosts: (Host(executor.gfnw),))
    [pyinfra.api.connectors.ssh] Running command on executor.gfnw: (pty=False) sudo -H -n sh -c '! command -v apt >/dev/null || (! test -f /etc/apt/sources.list || cat /etc/apt/sources.list) && (cat /etc/apt/sources.list.d/*.list || true)'
[executor.gfnw] >>> sudo -H -n sh -c '! command -v apt >/dev/null || (! test -f /etc/apt/sources.list || cat /etc/apt/sources.list) && (cat /etc/apt/sources.list.d/*.list || true)'
    [pyinfra.api.connectors.ssh] Waiting for exit status...
    [pyinfra.api.connectors.ssh] Command exit status: 0
    Loaded fact apt_sources ()
    [pyinfra.api.facts] Getting fact: find_in_file (path=/etc/apt/sources.list, pattern=^.*deb [arch=amd64 signed-by=/usr/share/keyrings/docker-archive-keyring.gpg] https://download.docker.com/linux/ubuntu focal stable.*$, interpolate_variables=False) (ensure_hosts: (Hos
t(executor.gfnw),))
    [pyinfra.api.connectors.ssh] Running command on executor.gfnw: (pty=False) sudo -H -n sh -c 'grep -e '"'"'^.*deb [arch=amd64 signed-by=/usr/share/keyrings/docker-archive-keyring.gpg] https://download.docker.com/linux/ubuntu focal stable.*$'"'"' /etc/apt/sources.list
2> /dev/null || ( find /etc/apt/sources.list -type f > /dev/null && echo __pyinfra_exists_/etc/apt/sources.list || true )'
[executor.gfnw] >>> sudo -H -n sh -c 'grep -e '"'"'^.*deb [arch=amd64 signed-by=/usr/share/keyrings/docker-archive-keyring.gpg] https://download.docker.com/linux/ubuntu focal stable.*$'"'"' /etc/apt/sources.list 2> /dev/null || ( find /etc/apt/sources.list -type f > /dev
/null && echo __pyinfra_exists_/etc/apt/sources.list || true )'
    [pyinfra.api.connectors.ssh] Waiting for exit status...
    [pyinfra.api.connectors.ssh] Command exit status: 0
    Loaded fact find_in_file (path=/etc/apt/sources.list, pattern=^.*deb [arch=amd64 signed-by=/usr/share/keyrings/docker-archive-keyring.gpg] https://download.docker.com/linux/ubuntu focal stable.*$, interpolate_variables=False)
    [executor.gfnw] Ready: install_executor_apt.py

--> Proposed changes:
    Groups: executor / gfnwtestbed
    [executor.gfnw]   Operations: 1   Commands: 1

--> Beginning operation run...
--> Starting operation: Add Docker apt repository
    [pyinfra.api.operations] Starting operation Add Docker apt repository on executor.gfnw
    [pyinfra.api.connectors.ssh] Running command on executor.gfnw: (pty=None) sudo -H -n sh -c 'echo '"'"'deb [arch=amd64 signed-by=/usr/share/keyrings/docker-archive-keyring.gpg] https://download.docker.com/linux/ubuntu focal stable'"'"' >> /etc/apt/sources.list'
[executor.gfnw] >>> sudo -H -n sh -c 'echo '"'"'deb [arch=amd64 signed-by=/usr/share/keyrings/docker-archive-keyring.gpg] https://download.docker.com/linux/ubuntu focal stable'"'"' >> /etc/apt/sources.list'
    [pyinfra.api.connectors.ssh] Waiting for exit status...
    [pyinfra.api.connectors.ssh] Command exit status: 0
    [executor.gfnw] Success

--> Results:
    Groups: executor / gfnwtestbed
    [executor.gfnw]   Successful: 1   Errors: 0   Commands: 1/1

Thank you for reporting this @yggdr; I've just pushed two fixes related to this (https://github.com/Fizzadar/pyinfra/commit/0abfd55fe0e33d570f6cf3251fcba315967b4dde & https://github.com/Fizzadar/pyinfra/commit/c10ddc50dcbaa82a253c87ce35cd5a77f6356bec) that will be released shortly.

Now released in v1.4.19.


Migrate qiskit_algorithms following end-of-support #811

What should we add?
Mirror of https://github.com/qiskit-community/qiskit-machine-learning/issues/811

Linked PR: https://github.com/qiskit-community/qiskit-machine-learning/pull/817


prevent "nvim Undefined global vim."

when create new lua-file:
…
vim.fn.…● nvim Undefined global vim.

This is already handled by lua_ls and neodev in Lazyvim. Do you happen to have changed the default configuration in your config and needed to add this? I don't believe there's a need for this in the default Lazyvim configuration.

This is already handled by lua_ls and neodev in Lazyvim. Do you happen to have changed the default configuration in your config and needed to add this? I don't believe there's a need for this in the default Lazyvim configuration. Or if you mean a file outside of neovim config directory, then you just need to add a .neoconf file with the same configuration as the one that comes with Lazyvim.

And then why 'lua_ls =' in the default config at all? This is already handled by lua_ls and neodev.
I would add more:
              telemetry = {
                -- Do not send telemetry data containing a randomized but unique identifier
                enable = false,
              },

to be turned off by default

Neodev handles that.
telemetry is disabled by default, so does not need to be set.


Added Microsoft Edge Beta version 116.0.1938.36.

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/114356&drop=dogfoodAlpha

@wingetbot run


Make SSR work perfectly in Athena

Stop SSR from doing 2 requests

Moved graphql client to apollo from urql and its now working correctly on ssr


Address changes to task menu

Merging to get it into Insiders but can take feedback from @dbaeumer tomorrow. Sounds like a new telemetry approach is still tbd.


[TableBody] Add clickAsSelect prop

Add clickAsSelect for TableBody component, to let the user decide how to select a table row and make the checkbox on the left of the row do the real job.
Closes #3453

@louis-sherren Thanks for the PR!
You mentioned selecting text in your original post.  Is this the bug you were talking about?
(it seems that you can select text for multiple cells, but if you try select one cell to copy/paste the text or something it does not let you, it instantly deselects)

Hi @nathanhere ,
Yes, that bothers me, because I want the user to have the ability to copy some text from the table or have some other operations.And I noticed that the material-ui just do this on purpose according to the following,
// Prevent text selection while selecting rows.
window.getSelection().removeAllRanges();

So I just add a prop to table-body to let the developer decide how to select one table row.
By default it is just like what it was: click on anywhere of that table row will select that row,
But if the clickAsSelect is set to false, a table row will only be selected by click the checkbox on the left, not anywhere anymore.

@louis-sherren The frustrating thing -- if you look at my gif is that it lets you select multiple columns, but not one, check this out: https://i.gyazo.com/6b814ad0e35fc0b77fff90acb36a91c3.gif
I would like this to be consistent, regardless of the clickAsSelect option. Being able to select 2 columns but not 1 column of text is strange.
@newoga To make this consistent, do you think text selection should always be possible? (Not being able to select text and copy/paste it seems like a seriously usability issue to me, regardless of whether the row is clickable or not.... if I want to click I click, not select text). However, I don't know the history behind this decision

@newoga To make this consistent, do you think text selection should always be possible?

@nathanmarks Yeah I agree, I'd say remove the prop and make the text selectable. I'm not too sure about the history behind the decision either. It's possible it wasn't an explicit decision and the implications of that code were overlooked.
I think the way this should work from a user standpoint is that the text should be selectable anywhere (without needing a prop). And we should still look into a way to prevent selecting the row when selecting text.
Thoughts?

@newoga Yeah, it's weird to have a table that you can't select the text on a single cell, but you can select the text on multiple cells (as a default behaviour).
@louis-sherren Is it possible for you to make this the default behaviour? We'd like to get rid of this inconsistency alltogether and have a single cell selectable.

@nathanhere Yes of course, and two more things should be noticed for making this default behaviour:

This will make the table row selected only by click the checkbox on the left side.
I will still leave an option(prop) to make the user decide how to select it ( by clicking checkbox or the whole row ), and maybe code following will be removed

window.getSelection().removeAllRanges();

@louis-sherren we need to still be able to support click to select functionality.
Do you know why it allows me to select 2 cells without selecting but not one? is it because of window.getSelection().removeAllRanges(); ?

I have made a new commit with the following changes,

remove window.getSelection().removeAllRanges() so users can copy any contents from table.
change onChange to onClick of checkbox for capturing the key pressed (event object of onChange has no shiftKey property etc).
set default value of clickAsSelect as false.

Now if <TableBody selectAsClick={false}> or just not set that property
Then table will act like this

If  <TableBody selectAsClick={true}> , then

I may know that why the original version has the window.getSelection().removeAllRanges(), this prevents from selecting a row when tried to select text, but what it lose is that users can no longer select text. I think this prop can make things right.

Hi @nathanmarks , about

why it allows to select 2 cells without selecting but not one?

The window.getSelection().removeAllRanges(); is in the function _onRowClick, this _onRowClick function is not the click event handler of table row, it is call by this
  _onCellClick(event, columnIndex) {
    if (this.props.selectable && this.props.onCellClick) {
      this.props.onCellClick(event, this.props.rowNumber, columnIndex);
    }
    event.ctrlKey = true;
    this._onRowClick(event);
  },

you can see that it is actually a event handler by table cell, so if you press down you mouse on one cell then release it on another cell, it will not trigger a click event, so that _onRowClick and window.getSelection().removeAllRanges() will not get called.

What a maze, going to have to review this in detail.

@louis-she there's a bunch of table issues that need looking at holistically and it all comes back to the event handlers...
@mbrookes I feel like this is a losing battle until we rewrite the component..

I haven't followed this PR closely, but knowing what I do about Table, I can't disagree!

@mbrookes @louis-she I'm closing this because it's a band-aid and not a permanent solution. The entire component needs revisiting as there are numerous issues related to the event handling system.

feel free to re-open/comment if you disagree

Although it may be a bandaid until this component is rewritten, this fix is quite necessary for anyone using links, input fields, etc in a selectable table. I believe it should be added for now and will be wiped out once the component is rewritten.

any updates about this?¿


ValidationOptions has no property skipMissingProperties?

I am using routing-controllers with typescript.
I  want to use skipMissingProperties when I use createExpressServer method.
But, skipMissingProperties  does not in  ValidationOptions ，as fllows.
/**
 * Options used to pass to validation decorators.
 */
export interface ValidationOptions {
    /**
     * Specifies if validated value is an array and each of its item must be validated.
     */
    each?: boolean;
    /**
     * Error message used to be used on validation fail.
     * You can use "$value" to use value that was failed by validation.
     * You can use "$constraint1" and "$constraint2" keys in the message string,
     * and they will be replaced with constraint values if they exist.
     * Message can be either string, either a function that returns a string.
     * Second option allows to use values and custom messages depend of them.
     */
    message?: string | ((value?: any, constraint1?: any, constraint2?: any) => string);
    /**
     * Validation groups used for this validation.
     */
    groups?: string[];
    /**
     * Indicates if validation must be performed always, no matter of validation groups used.
     */
    always?: boolean;
}

How to solve this problem ?  thanks

  useExpressServer(this.app, {
      defaultErrorHandler: true,
      enableValidation: true,
      useClassTransformer: true,
      controllers: [__dirname + '/controllers/**/*.js'],
      middlewares: [__dirname + '/middlewares/**/*.js'],
      interceptors: [__dirname + '/interceptors/**/*.js'],
      validationOptions: { skipMissingProperties: true } as any
    })

It still validates (when I didn't pass the property)  and cause error.

asking @19majkel94

I just forgot to make a PR 😆 Sorry guys!

thank you all

good


Enable RegistryInputDialog to work standalone and use with iBioSim

Should be used with both SBOLAssociation and as a new Import -> SynBioHub menu item.

I've added this to SBOLAssociationPanel2.  It currently only works with the "Working Document" (I think).  I've updated SBOLDesigner's RegistryInputDialog to work better standalone, but am having a hard time updating iBioSim's reference of SBOLDesigner due to not being able to build SBOLDesigner into a jar.
I remember you were having problems with this as well a while ago.  Did you figure out what was going wrong?

Hmm, I really need to write these things down.  I will take a look on my flight and see if I can get it to work.

On Mar 20, 2017, at 3:25 AM, Michael Zhang<EMAIL_ADDRESS>wrote:
I've added this to SBOLAssociationPanel2. It currently only works with the "Working Document" (I think). I've updated SBOLDesigner's RegistryInputDialog to work better standalone, but am having a hard time updating iBioSim's reference of SBOLDesigner due to not being able to build SBOLDesigner into a jar.
I remember you were having problems with this as well a while ago. Did you figure out what was going wrong?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/SynBioDex/SBOLDesigner/issues/148#issuecomment-287672434, or mute the thread https://github.com/notifications/unsubscribe-auth/ADWD9-ikLIPN8_odIh5cHaduCx1eWL9aks5rnfGogaJpZM4MYWQS.

I've updated SBOLDesigner to include a new interface for RegistryInputDialog.  iBioSim now uses this new interface to select parts from the working document (which is now passed in) as well as any other registry.  Everything seems to be working correctly as of now.  Closing issue.

Should use recursive copy instead, so sub-structure comes in.

This wasn't actually a bug, and there was different bug with not adding just the root, but I've fixed this.  Closing again.


ENOENT: no such file or directory

WARNING in ./node_modules/react-credit-cards-2/dist/es/index.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/Users/user/project/node_modules/react-credit-cards-2/src/ReactCreditCards.tsx' file: Error: ENOENT: no such file or directory, open '/Users/user/project/node_modules/react-credit-cards-2/src/ReactCreditCards.tsx'

WARNING in ./node_modules/react-credit-cards-2/dist/es/index.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/Users/user/project/node_modules/react-credit-cards-2/src/utils/cardHelpers.ts' file: Error: ENOENT: no such file or directory, open '/Users/user/project/node_modules/react-credit-cards-2/src/utils/cardHelpers.ts'

WARNING in ./node_modules/react-credit-cards-2/dist/es/index.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/Users/user/project/node_modules/react-credit-cards-2/src/utils/cardTypes.ts' file: Error: ENOENT: no such file or directory, open '/Users/user/project/node_modules/react-credit-cards-2/src/utils/cardTypes.ts'

Does anyone else have this problem?

https://www.npmjs.com/package/react-credit-cards-2?activeTab=code
You can check it out with the link.

You can test it here (https://github.com/omtanke/react-credit-cards-2-test). New and empty project created for this.

Any update? I have the same problem

@felquis is there any update?

Any fixes for this problem?
I'm going through the same situation!

Hey @semihraifgurel I'm around, Thank you for this link https://github.com/felquis/react-credit-cards-2/issues/15#issuecomment-1521724546
Looks like your repo works, but it can't find sourcemaps. We should doublecheck we are shipping the lib with sourcemaps enabled and try again.

still facing it, it's trying to find it inside "src" folder of library, but there is no "src"

Still facing the issue

Although this doesn't seem to be effecting functionality is it possible to get a fix for this warning?

Is there any fix for it? I'm also facing the issue

@kevin-kuhn can you try<EMAIL_ADDRESS>and let me know if this error still happens?


Add CaipChainId

Add CaipChainId

See: https://github.com/MetaMask/core/pull/1489
See: https://github.com/MetaMask/metamask-extension/pull/19991

@jiexi Do you mind renaming the title of this PR so that it will be easier to understand at-a-glance in the commit history later on?

What's the motivation behind re-doing the work that already exists in @metamask/snaps-utils? https://github.com/MetaMask/snaps/blob/main/packages/snaps-utils/src/namespace.ts

Nice, @hmalik88 ! Didn't know that this was already done. Looks wonderful! I feel like the term "Chain ID" is pretty overloaded now. I don't believe Namespace nor Reference are very clear terms either even though they are the terms used in the CAIP specs. What are your thoughts on this? I think renaming the types to include a Caip prefix would help make this less ambiguous. Moving the Caip types from @metamask/snap-utils to @metamask/utils might make more sense as well given this will be more applicable to entirety of metamask as we shift towards multichain

@jiexi You're right, it is an overloaded term. We're releasing the name resolver API soon and I was going to make some type changes. Perhaps you're right that we may want to prefix with Caip, but that also means we're making a distinction internally. In what contexts are we using Chain ID? Seems sensible to move to utils, these types were mostly added when our team was doing keyrings work ~ 10 months ago.

@hmalik88 I'm currently trying to replace our usage of Eth chain id with CAIP chain id. I'm in the process of replacing chainId (eth, decimal or hex) with caipChainId in all of core and extension, so soon all contexts will include CAIP chain id.
Do you happen to know if there is an estimate for when these changes will be available?

I've scrapped my types and brought in Caip types from @metamask/snaps-utils. The plan is to make this the new home for these types and to update all usage of @snap-utils to caip types to this new one

Okay. pretty happy with this now

@metamaskbot publish-preview

LGTM, however I defer to @hmalik88 and @mcmire if they have any outstanding concerns


[ospec] Spies reflect wrapped function's name & length

Sniffing function length isn't all that uncommon in library code.

I'd like to mention this will throw in ES5, because func.length is a
nonconfigurable, own property. This was only changed in ES6 for the above
use case (and similar). It'll work in Chrome, Firefox, and other modern, up
to date browsers, but it may likely fail in Safari and IE.
You can always create several wrapper functions for smaller lengths, which
will work as a stopgap until then.
On Fri, Sep 2, 2016, 10:34 Leo Horie<EMAIL_ADDRESS>wrote:

Merged #1287 https://github.com/lhorie/mithril.js/pull/1287.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/lhorie/mithril.js/pull/1287#event-776652122, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AERrBBV6m-TK4bo5wSpcR7OJMqQ5wEuaks5qmDP9gaJpZM4Jxe1y
.

@isiahmeadows good catch! Guess I'll have to bite the bullet and write off that horrible case by case function substitution :/


Add Berlin specific holidays. Fixes #340

closes #340

[X] Tests with a significant number of years to be tested for your calendar.
[X] Changelog amended with a mention describing your changes.

Thank you for this great contribution. I'll make a quick release.


[BUG] supportedAggregationTypes field in the MetricDefinition is always null

Describe the bug
com.azure.monitor.query.MetricsQueryClient#listMetricDefinitions(java.lang.String) returns list of MetricDefinition objects with supportedAggregationTypes null in each definition
Exception or Stack Trace
There's no stack trace or error during execution
To Reproduce
val metricsQueryClient = MetricsQueryClientBuilder()
        .credential(clientSecretCredential)
        .buildClient()

val metricDefinitions = metricsQueryClient.listMetricDefinitions("resourceName")
        .filter { it.supportedAggregationTypes != null }
        .toList()

assertThat(metricDefinitions).isEmpty()

Code Snippet
Added above 👆🏻
Expected behavior
Metric Definition list API documentation states it should return a list of supported aggregations in response:
https://learn.microsoft.com/en-us/rest/api/monitor/metric-definitions/list?tabs=HTTP
I expect to receive it in mentioned object.
Screenshots
I've debugged the code and it looks like internal definition response contains the desired list.
However there is a bug in line 183.

You can see the evaluation results under the code in screenshot:
definition.supportedAggregationTypes.size -> 1
and CoreUtils.isNullOrEmpty(definition.getSupportedAggregationTypes()) -> false
Setup (please complete the following information):

OS: MacOS
IDE: IntelliJ
Library/Libraries: com.azure:azure-monitor-query:1.3.0-beta.1
Java version: 8
App Server/Environment: local environment
Frameworks: none

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Bug Description Added
[x] Repro Steps Added
[x] Setup information Added

@jairmyree PTAL

@jairmyree any updates on this? I've opened a Pull Requests with a fix. I will appreciate your feedback 🙁

@matvey-mtn Thank you for reaching out. I was out-of-office for a few days, sorry for the delay in response. I'll take a look at the issue and get back to your shortly.

@matvey-mtn I've assigned myself to your PR and I'll review it soon.

@matvey-mtn I've reviewed your PR. Please see and review the CLA agreement notice on your PR.


check datetime and int input types

Check that int field are inputted as int.
Also check that  datetimes are converted to string before calling snipeit api.

Think that makes sense


[tflite] Tests for the operator PACK quantization

There is a bug in the current implementation of the operator PACK.
The multiple inputs should be requantized.
The current PR fixes this bug and adds a test for the quantization of the PACK operator.

Hi, I believe the aribitrary_inputs and rescrict_same_input_output_scale params are sufficient, the tests are welcome additions though! Thanks!

Hi Suharsh,
Yes, it makes sense. We kept this variable to be consistent with our solution to the maximum/minimum bug PR.
I edited PR and left only C++ test.
Could you please review it ?
Thanks!

Hi @suharshs, could you please take a look again ? The same problem with this PR - small complaint from the buildifier, that I have fixed.
Thanks!

@suharshs Could you please review again ? I resolved merge conflicts and this dismissed PR approval. Thanks


Velox parquet scan fail when select row index column before data column

Bug description
below query
select _tmp_row_index_column,  a, b from table

would fail if _tmp_row_index_column be marked to kRowIndex column.
In summary, all scan would fail if kRowIndex type column is selected before data column.

@Yuhta FYI

It seems this issue has been fixed by https://github.com/facebookincubator/velox/pull/9866. Closing for now.


LICENSE

Hi authors,
Thanks for your work.
Do you mind putting in a license for this dataset? Thanks!

Hi,
Thanks for your kindly reminder. We have added it.


Better radio defaults

Fixes #781. Defaults to having simple description text separate from the key for radio buttons, moves the hint text to the help, and adds a simpler hint text (which isn't really great UX anyway since it disappears, but eh).

Does this still work with the edit/add custom field button?

Good prompt; I checked with a few manual changes, so it still should. However, that button seems to be broken right now anyway, for unrelated reasons that I'll patch now.

It still works fine, but I'm realizing that there's a whole lot of duplicate stuff that I never realized was here; the interview.all_fields[i].edit_field screen duplicates a lot of the DAField.user_ask_about_field function, and I only now realized the former is a separate thing, so the hint / help changes made here aren't reflected in the edit screen. IMO that should be a refactor, but I'll patch it really quick.


Enhancement: favicon

Is your feature request related to a problem? Please describe.
I haven't found a documented way of setting the favicon.
Describe the solution you'd like
An easy builtin way to set favicon.ico in the HTML head section
Describe alternatives you've considered
modify base.html template manually
Additional context
.

I have opened a PR. Hope it helps !


change HIP header file inclusions to system include

@david-salinas,
Is this PR still needed?
If yes, then please change the status from "Draft" to "Open".


⚠ ClamAV has degraded performance

In 5483615, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 106 ms

Resolved: ClamAV performance has improved in ff40ef0.


⚠ Avatar API Endpoint has degraded performance

In cdd0a5d, Avatar API Endpoint (https://avatar.roblox.com/v1/avatar-rules) experienced degraded performance:

HTTP code: 200
Response time: 1141 ms

Resolved: Avatar API Endpoint performance has improved in 38c07ff after 11 minutes.


Configuration via one settings file

Hey,
Thnaks for this great project. It is a really nice use of the RPis and offers many different possibilities.
I am playing around with the RPi Jukebox a lot and try to find a soutions where everything is done more or less with GPIO pins.
In order to have an overview over all this pins and the configurations options, I would be great to use a single configuration file for all such settings, by only changingf this file it would be much easier to "switch" between configurations.
Almost every handler uses python and with the ConfigParser there is already a module which is really powerful and would probably simplify many things. For example one could easily generate different settignsfile for the different suggested GPIO configurations.
What do you think about such a change. I am already using it more or less for my version and I am happy to share it if there is interest.
cheers

hi @veloxidSchweiz
I like the idea. I am already parsing bash config files when running parts in php. So I am sure that there could be "one file to rule them all".
My only concern: depending on the hardware used (dial, buttons) combined with the use of soundcards that require GPIO pins, there have been many different flavours of Phoniebox UIs - and therefore configs. But please show me what you got :)

@veloxidSchweiz, this is being implemented in #763, right?

At least the GPIO settings...
at the moment i would suggest to go for one config file for each matter of concern.
If we use the ~/.config/phonniebox folder we have them all at one point....
The version I have in my fork at the moment seems to work pretty good.
I planned to also add the 'special' Buttons as shutdown button etc. and the change from config to yaml files isn't done it. Otherwise it seems to work quite good: I tested rotary-switches, Two-Buttons and normal buttons already and i added a simple install script..
But due to time constrains in the current times I do not find the time I would need ;(
I
At the moment I am using cfg files and no yaml yet as I

Config file for each area is fine for me.
Moving content and config files to dedicated folders is already being addressed in #797.

This was implemented in future3.


E2E: go release main SLSA3 config-ldflags assets

Repo: https://github.com/slsa-framework/example-package/tree/v16.0.7
Run: https://github.com/slsa-framework/example-package/actions/runs/6569700250
Workflow name: go release main SLSA3 config-ldflags assets
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.release.main.config-ldflags-assets.slsa3.yml
Trigger: release
Branch: v16.0.7
Date: Thu Oct 19 04:09:10 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/v16.0.8
Run: https://github.com/slsa-framework/example-package/actions/runs/6595114586
Workflow name: go release main SLSA3 config-ldflags assets
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.release.main.config-ldflags-assets.slsa3.yml
Trigger: release
Branch: v16.0.8
Date: Sat Oct 21 04:07:15 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/v16.0.8
Run: https://github.com/slsa-framework/example-package/actions/runs/6601562113
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.release.main.config-ldflags-assets.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.release.main.config-ldflags-assets.slsa3.yml
Trigger: release
Branch: v16.0.8
Date: Sun Oct 22 04:13:37 UTC 2023
Tests are passing now. Closing this issue.