Calling setState inside onChange callback causes view reload and keyboard will not open

Has the title if I call setState like your example:
@override
void initState() {
  super.initState();

  _readCredentials();

  _keyboardVisible = _keyboardVisibility.isKeyboardVisible;

  _keyboardVisibilitySubscriberId = _keyboardVisibility.addNewListener(
    onChange: (bool visible) {
      setState(() {
        _keyboardVisible = visible;
      });
    },
  );
}

It cause the view reload and is keyboard immediatly closed.
I'm using the _keyboardVisible flat to show/hide a view.
How could I solve?

is this documented somewhere?, this issue caused me strife for a while


fix(indexer-alt): connection timeout default

Description
Using stringify!(DEFAULT...) doesn't work, because it stringifies the constant name, not its contents. This change uses const_str::format to achieve what was originally intended.
Test plan
Run the indexer without supplying a connection timeout. Before this change it would fail with a parse int error, because it tried to interpret the string DEFAULT_CONNECTION_TIMEOUT_SECS as an integer.

Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

[ ] Protocol:
[ ] Nodes (Validators and Full nodes):
[ ] Indexer:
[ ] JSON-RPC:
[ ] GraphQL:
[ ] CLI:
[ ] Rust SDK:
[ ] REST API:

I'll land this to fix the binary (it will panic if you don't provide it a connection timeout at the moment), but will return to remove the dependency as part of the file-based config work.


[UIExplorer] Add defaultSource / loadingIndicatorSource

Wanted to test #5017 but there was no example in UIExplorer
Also re-order a bit and limit ImageSizeExample to iOS (was causing UIExplorer to redbox on Android)
defaultSource and loadingIndicatorSource appear to be broken as reported in #5017

@facebook-github-bot shipit

@facebook-github-bot shipit

@nicklockwood is comandeering the revision manually

@brentvatne it turns out that loadingIndicatorSource is something that was added hastily for an internal use case, and it's not something we want to support as it has really weird semantics that are very specific to how Fresco works internally.
I'm still considering whether we want to keep defaultSource. It's potentially useful, but only if it can be ported to Android, I think.

Ah great to know, thanks for the follow up @nicklockwood! I created an issue for that at #5158 :) No need to keep this one open.


CockroachDB in Comparison Doc Update

Re: CockroachDB in Comparison
Issue Description
When we compare ourselves against DynamoDB we state that they need an external transaction library for Distributed Transactions and say they only provide ACID semantics. As of November of 2018 DynamoDB does provide these features: https://aws.amazon.com/blogs/aws/new-amazon-dynamodb-transactions/
Suggested Resolution
Update to reflect the current comparison between CockroachDB and DynamoDB.

cc @jaymce


feat: add Step Function based rosbag-image-pipeline module

Checklist

[x] Deployment successful
[x] State machine execution successful
[ ] Unit tests
[x] Documentation

State Machine Design

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Merged with #403


ToggleButton System elements on taskbar (windows and search buttons) cause a crash

When the Windows taskbar element is being pressed, programmatically or not, the program fails to execute function GetGlobalTaskbar in TaskbarElements.cs, which causes an Exception. To replecate this behaviour, open Windows element with the program (aa) or just manually and then try to run CTRL + SHIFT + ALT + T to open taskbar mode. The icon will be red with a message "SHELL_TrayWnd" not found.
After further investigation, I found out that Child Elements from the root element are the existing windows and frameworks (Windows, WPF, SHELL_TrayWnd, etc.) And under normal circumstances the element SHELL_TrayWnd should be the [0] element. But after interracting with Windows buggon this element disappears from child elements completely.
a) It is hidden and we need to find offscreen elements (despite for the taskbar being on the screen)
b) the Windows element being a toggle button type which produces a strange bug
Needs further investigation.

No way to fix this, so I will just ignore it completely. For now, at least


Upgrade plugin for OR 23.09

This PR upgrades the plugin for use with OpenRocket version 23.09. I must admit I have no idea how to use this plugin, so I only did some basic testing (verify that nothing crashes and run some simulations to check that the plugin did something).
Here is a JAR file of the plugin.

Can someone please merge this PR? We've had numerous users complain to us that the plugin no longer works with the latest version of OR. Fixes #6.


Fix compilation with Swift 5.7 release

I'm not sure if we need to do anything with the path remapper yet, thus Draft state.

Don't think we need to, but we probably could and it might make something nicer


[RELEASE-1.11] Use ubi8/ubi-minimal as base and re-generate CI images

What this PR does / why we need it:
Similar to https://github.com/openshift-knative/serverless-operator/pull/2452
ubi-minimal is much smaller in size, it's multiarch, and it's used by product images built in Brew anyway. CI can use the same.
Which issue(s) this PR fixes:
Related to https://issues.redhat.com/browse/SRVKS-1024 but doesn't fully fix it.
Does this PR needs for other branches:
release-v1.12 and main

Does this PR (patch) needs to update/drop in the future?:

JIRA:

@ReToCode @skonto Hmm. The error says:
 [1/2] STEP 6/6: RUN go build -o /tmp/operator ${BASE}/openshift-knative-operator/cmd/operator
go: errors parsing go.mod:
/go/src/github.com/openshift-knative/serverless-operator/go.mod:5: unknown directive: toolchain
error: build error: error building at STEP "RUN go build -o /tmp/operator ${BASE}/openshift-knative-operator/cmd/operator": error while running runtime: exit status 1

I think it's related to bumping Golang in https://github.com/openshift-knative/serving/commit/f2b8975664b309e299edd216780b90216cd4fd4a , the images were not re-generated there.

Oh. I know what's happening. This change takes effect only after merging, so it hit my PR now.
It changes golang to 1.21 and apparently we run "go mod tidy" which adds this directive to go.mod:
toolchain go1.21.0

And then we build the s-o images using Golang 1.19 as this is the base image for the operators right now.

/retest-required


[Event Request] page 31175 "Advance Letter Appl. Edit CZZ" (Czech)

Describe the request
Hello,
we need an event in OnLookup trigger for "Advance Letter No." field in this page:
field("Advance Letter No."; Rec."Advance Letter No.")
                {
                    ApplicationArea = Basic, Suite;
                    ToolTip = 'Specifies advance letter no.';
                    NotBlank = true;

                    trigger OnValidate()
                    begin
                        if Rec."Advance Letter No." <> '' then begin
                            TempAdvanceLetterApplication.Get(Rec."Advance Letter Type", Rec."Advance Letter No.", Rec."Document Type", Rec."Document No.");
                            Rec.CopyFrom(TempAdvanceLetterApplication);
                        end
                    end;

                    trigger OnLookup(var Text: Text): Boolean
                    begin
                        OnBeforeOnLookupAdvanceLetterNo(Rec, TempAdvanceLetterApplication);

                        if Page.RunModal(Page::"Advance Letter Application CZZ", TempAdvanceLetterApplication) = Action::LookupOK then
                      // START
                      begin
                      //STOP
                            Rec.CopyFrom(TempAdvanceLetterApplication);
                      // START
                      OnAfterOnLookupAdvanceLetterNo(Rec);
                      end
                      //STOP
                    end;
                }

[IntegrationEvent(false, false)]
local procedure OnAfterOnLookupAdvanceLetterNo(var AdvanceLetterApplicationCZZ: Record "Advance Letter Application CZZ")
begin
end;

Additional context
User wants to get a warning after entering a Advance letter number if the Advance letter would be without VAT

Hi @JesperSchulz, please look on this.
thank you, Petr

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: .


docs(french): translation in french (last part)

What: Translation in french (second part)

Why: Documentation in several languages is better

How: Several tranlations:

Integrations
Updates from the original

cc @Macxim and @etiennetalbot 😄

LGTM too 👍

I declare that the French translation is 100% up to date ✌
Thank you to all those who helped me in this task.

Wow, thank you @forresst @Macxim and @bulby97! (And everyone else who helped with this!)

Wahoo! Thank you so much. We all really appreciate it. Would be great if you could watch the repo for changes to content to keep things updated. Feel free to recruit others to help as well!


@ToNativeClass/Interface do not work on expected/actual declarations

hmm, should @ToNativeInterface work on actual or expected declarations?

On expected I get “Expected interface ‘ViewModelNativeProtocol’ has no actual declaration in module <…> for Native”
Same if expected and actual are annotated.
Annotating only actual in iosMain seems to do nothing

If this is fixed, it would be great if it would be documented, which part of expected/actual to annotate.

Just to clarify, you have expect abstract class ViewModel in shared module, on Android it's a typealias to the Google ViewModel and on ios module what it is and what functions / properties does it have? Are any of them suspend functions or Flows? What do you use the ViewModel in Swift code for?

I have same problem.
Added @ToNativeClass annotation to the class. But A wrapper was not generated.

Did you use ksp or kapt?
The class you annotated was in common code or a different source set?
I will assume that you tried ksp and ios source set. By design this library analyses the common soirce and generates ios code. If you would like to use it differently, can you explain your use case to me? I'm trying to understand different ways people are using the library.

Did you use ksp or kapt?

ksp.

The class you annotated was in common code or a different source set?

common code.

Hmmm, I'm going to need more details then. Can you maybe post some code and the gradle config that you tried?

v0.10.0 (use kapt, Kotlin v1.6.20) is work.
But v0.11.1 (use ksp Kotrlin v1.7.0) is not work.
For now, I think use v0.10.0.

Can you maybe post some code and the gradle config that you tried?

If I can show the code, I will show it tomorrow. 🙏

@uluckas I think I might have fixed your usecase. I'm missing code details, so it's just my understanding how you would use it, but still, should work. Please take a look at 0.12.0-SNAPSHOT and let me know if it works for you. Here's how to use it.
https://github.com/FutureMind/koru-example/compare/master...fix/%2349-expect-actual
@yamakentoc if you can show your gradle config, that would be welcome, in the meantime, I think the problem might b that you set this
koru {
    nativeSourceSetNames = listOf("iosMain")
}

and your ios source set is named differently, e.g. appleMain. I'm gonna add a warning for that in the build process.

@micHar
Sorry for replying so late.
↓ This is gradle config.
// HogeHogeHoge/shared/build.gradle.kts
// kotlin version: 1.7,0

val ktorVersion = "2.0.1"
val kotlinCoroutineVersion = "1.6.3"

plugins {
    kotlin("multiplatform")
    id("com.android.library")
    id("com.google.devtools.ksp") version "1.7.0-1.0.6"
    id("com.futuremind.koru").version("0.11.0")
    kotlin("plugin.serialization")
}

kotlin {
    android()

    listOf(
        iosX64(),
        iosArm64(),
        iosSimulatorArm64()
    ).forEach {
        it.binaries.framework {
            baseName = "HogeHogeHoge"
        }
    }

    sourceSets {
        val commonMain by getting {
            dependencies {
                //Coroutines
                implementation("org.jetbrains.kotlinx:kotlinx-coroutines-core:$kotlinCoroutineVersion-native-mt")
                //Network
                implementation("io.ktor:ktor-client-core:$ktorVersion")
                implementation("io.ktor:ktor-client-serialization:$ktorVersion")
                // JSON Serialization
                implementation("io.ktor:ktor-client-content-negotiation:$ktorVersion")
                implementation("io.ktor:ktor-serialization-kotlinx-json:$ktorVersion")
                // client mock
                implementation("io.ktor:ktor-client-mock:$ktorVersion")
                // koru
                implementation("com.futuremind:koru:0.11.1")
                // firebase
                implementation("dev.gitlive:firebase-auth:1.6.1")
            }
        }

        val androidMain by getting {
            dependencies {
                //Network
                implementation("io.ktor:ktor-client-okhttp:$ktorVersion")
            }
        }
        val commonTest by getting {
            dependencies {
                implementation(kotlin("test-common"))
                implementation(kotlin("test-annotations-common"))
            }
        }

        val iosX64Main by getting
        val iosArm64Main by getting
        val iosSimulatorArm64Main by getting
        val iosMain by creating {
            dependsOn(commonMain)
            iosX64Main.dependsOn(this)
            iosArm64Main.dependsOn(this)
            iosSimulatorArm64Main.dependsOn(this)
            dependencies {
                //Network
                implementation("io.ktor:ktor-client-darwin:$ktorVersion")
            }
        }
    }
}

android {
    compileSdk = 31
    sourceSets["main"].manifest.srcFile("src/androidMain/AndroidManifest.xml")
    defaultConfig {
        minSdk = 27
        targetSdk = 31
    }
}

koru {
    nativeSourceSetNames = listOf("iosMain")
}

your ios source set is named differently, e.g. appleMain

My project's ios source is iosMain.

One thing that I can see here is that you have 0.11.0 for gradle plugin and 0.11.1 for the library. Both should be 0.11.1. I'm not sure if it's gonna fix the issue though.

@micHar
0.11.0 and 0.11.1 is written in README. so I wrote like that.
https://github.com/FutureMind/koru#download
I changed 0.11.0 but did not fix

I moved the issue to #50, because it's not related to the original one. Let's continue there.

One thing to not is that this will apparently only work with KSP. KAPT ignores expect classes during annotation processing - in both tests and production code. Probably completely incompatible.

Released 0.12.0 which handles expect actual and also added an example of handling KaMPKit like shared viewmodels in the example repo.


Question: Is it possible to somehow access the replica in which the app instance running in via SDK?

Hello,
I am trying to implement Azure Container Apps cluster provider for Proto.Actor framework. I am using the Azure container apps .NET SDK to access the resources. I came to a point in the code where I need to update the tags on the replica in which the app instance is running.
I thought of a couple of solutions but none of them seem possible. I could use Environment.MachineName to access pod name but none of the properties in replica data states the pod name.
Then I thought maybe it would be possible to pass the replica name to the app as an env variable but that also didn't seem possible.
Is there something I am missing? Is it possible to include the pod name as a property in the replica data class? Or do you have any other suggestions for my use case?

I'm closing this issue as I found out that in the environment variables of a running instance, you can find all the info related to the container app, revision, and replica.


[5.3][Index] Fast path for getting value member

Cherry-pick of #32748 into release/5.3

Explanation: Avoid solving constraint system if there's only one viable overload. This should fix a crash we are seeing in candidates.size() == 1 branch in the constraint system because the patch avoid the crashing code path.
Scope: Index while building, module interface printing
Risk: Very low. Just adding a fast path in obvious cases
Testing: Passes current regression test cases. No tests added because we don't have a reproducer of the crash
Issue: rdar://problem/64636688
Reviewer: Pavel Yaskevich (@xedin)

@swift-ci Please test

@swift-ci Please nominate


Android application stuks  when run "flutter run --target=test_driver/app.dart --start-paused --no-resident"

When I run command
flutter run -d "$deviceId" --target=test_driver/app.dart --start-paused --no-resident --vmservice-out-file="$deviceId_folder"
and then tried to connect like
flutter drive  --driver=test_driver/app_test.dart --use-existing-app="$(cat "$deviceId_folder")"
for Android device it can't connect and shows message VMServiceFlutterDriver: It is taking an unusually long time to connect to the VM...  but for ios it works fine
Flutter doctor
`Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 1.22.3, on Mac OS X 10.15.7 19H15, locale en-UA)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 12.0.1)
[!] Android Studio (version 4.1)
✗ Flutter plugin not installed; this adds Flutter specific functionality.
✗ Dart plugin not installed; this adds Dart specific functionality.
[!] IntelliJ IDEA Ultimate Edition (version 2019.3.3)
✗ Flutter plugin not installed; this adds Flutter specific functionality.
✗ Dart plugin not installed; this adds Dart specific functionality.
[✓] IntelliJ IDEA Community Edition (version 2019.2.4)
[✓] Connected device (1 available)
! Doctor found issues in 2 categories.
`

Hi @ManoyloK
Does this issue reproduces on latest stable version of Flutter?
If so, can you please provide your flutter doctor -v and a minimal complete reproducible code sample?
Thank you

Hi @pedromassangocode it still not work on flutter 1.22.4

To reproduce that, you can use any flutter driver tests for example like this https://flutter.dev/docs/cookbook/testing/integration/introduction.
Here is flutter doctor -v
[✓] Flutter (Channel stable, 1.22.4, on Mac OS X 10.15.7 19H15 darwin-x64, locale en-UA)
• Flutter version 1.22.4 at /Users/k.manoilo/development/flutter
• Framework revision 1aafb3a8b9 (4 weeks ago), 2020-11-13 09:59:28 -0800
• Engine revision 2c956a31c0
• Dart version 2.10.4
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at /Users/k.manoilo/Library/Android/sdk
• Platform android-30, build-tools 29.0.2
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 12.0.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 12.0.1, Build version 12A7300
• CocoaPods version 1.10.0
[!] Android Studio (version 4.1)
• Android Studio at /Applications/Android Studio.app/Contents
✗ Flutter plugin not installed; this adds Flutter specific functionality.
✗ Dart plugin not installed; this adds Dart specific functionality.
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
[!] IntelliJ IDEA Ultimate Edition (version 2019.3.3)
• IntelliJ at /Applications/IntelliJ IDEA.app
✗ Flutter plugin not installed; this adds Flutter specific functionality.
✗ Dart plugin not installed; this adds Dart specific functionality.
• For information about installing plugins, see
https://flutter.dev/intellij-setup/#installing-the-plugins
[✓] IntelliJ IDEA Community Edition (version 2019.2.4)
• IntelliJ at /Applications/IntelliJ IDEA CE.app
• Flutter plugin version 42.2.2
• Dart plugin version 192.7761
[✓] Connected device (1 available)
• sdk gphone x86 (mobile) • emulator-5554 • android-x86 • Android 10 (API 29) (emulator)
! Doctor found issues in 2 categories.

Logs
VMServiceFlutterDriver: It is taking an unusually long time to connect to the VM...
VMServiceFlutterDriver: It is taking an unusually long time to connect to the VM...
VMServiceFlutterDriver: It is taking an unusually long time to connect to the VM...
VMServiceFlutterDriver: It is taking an unusually long time to connect to the VM...
VMServiceFlutterDriver: It is taking an unusually long time to connect to the VM...
VMServiceFlutterDriver: It is taking an unusually long time to connect to the VM...
VMServiceFlutterDriver: It is taking an unusually long time to connect to the VM...
VMServiceFlutterDriver: It is taking an unusually long time to connect to the VM...

flutter doctor
[✓] Flutter (Channel stable, 1.22.4, on Mac OS X 10.15.7 19H2 darwin-x64, locale en)
    • Flutter version 1.22.4 at /Users/pedromassango/dev/SDKs/flutter_stable
    • Framework revision 1aafb3a8b9 (4 weeks ago), 2020-11-13 09:59:28 -0800
    • Engine revision 2c956a31c0
    • Dart version 2.10.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/pedromassango/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.1, Build version 12A7403
    • CocoaPods version 1.9.3

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] IntelliJ IDEA Community Edition (version 2020.2.4)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin installed
    • Dart plugin version 202.8070

[✓] VS Code (version 1.51.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (1 available)
    • sdk gphone x86 arm (mobile) • emulator-5554 • android-x86 • Android 11 (API 30) (emulator)

! Doctor found issues in 1 category.
Process finished with exit code 0

@ManoyloK
Coming back to this issue, can you try using the latest version of the framework (stable or master) and use integration_test updated example instead of flutter_driver and see if using it, you still get same behavior or not ?
https://github.com/flutter/flutter/tree/master/packages/integration_test/example


Uncaught TypeError: Cannot read property 'mainModule' of undefined

C:\Users*.atom\packages\open-in-browsers\lib\open-in-browsers-view.coffee:78
TypeError: Cannot read property 'mainModule' of undefined
at OpenInBrowsersView.open (file:///C:/Users//.atom/packages/open-in-browsers/lib/open-in-browsers-view.coffee:78:9)
at OpenInBrowsersView.openBrowser (file:///C:/Users//.atom/packages/open-in-browsers/lib/open-in-browsers-view.coffee:54:8)
at HTMLSpanElement. (C:\Users*.atom\packages\open-in-browsers\node_modules\space-pen\lib\space-pen.js:220:36)
at HTMLSpanElement.dispatch (C:\Users*.atom\packages\open-in-browsers\node_modules\jquery\dist\jquery.js:4435:9)
at HTMLSpanElement.elemData.handle (C:\Users*.atom\packages\open-in-browsers\node_modules\jquery\dist\jquery.js:4121:28)
It is happening, when I click

What should I do?
ATOM v.1.12.7

``

Assinatura Badran

</table>

That icon opens Skandasoft's Browser-Plus which gets installed when you install his Browser-Plus Atom package.  You're most likely getting the error because Browser-Plus couldn't be found (not installed).

check the latest patch


Interoperability of Live Share with other IDEs

Have a good day.

We want to have a tool for collaborative development for all IDE.
The live share could be such a tool, but now while not support IntelliJ Idea family products and others IDE.
I think what open source can help all in the current difficult time when because of COVID-19 all engineers community forced to work from home.

Hi thanks for reaching out. Adding @fubaduba to follow up

I've added a +1 here after being directed here through inquiry about this. I'd like to work on an IntelliJ plugin to help my team collaborate remotely during this time (and beyond - it looks like our remote work is here to stay). Screen sharing tools like TeamViewer or AnyDesk are great for quickly helping someone but lack the finesse of LiveShare. Online collaboration tools like CodeTogether are cool, but push people out of their personally-tailored dev environments.
For me, one of the greatest features of LiveShare is that I can collaborate with my setup (fonts, colors, plugins (like vim)) without demanding that someone else give up their environment or being slowed by having to give up mine.
Please consider opening the API and, if possible, sharing an sdk. I'm excited to work on this.

I've added a +1 here after being directed here through inquiry about this. I'd like to work on an IntelliJ plugin to help my team collaborate remotely during this time (and beyond - it looks like our remote work is here to stay). Screen sharing tools like TeamViewer or AnyDesk are great for quickly helping someone but lack the finesse of LiveShare. Online collaboration tools like CodeTogether are cool, but push people out of their personally-tailored dev environments.
For me, one of the greatest features of LiveShare is that I can collaborate with my setup (fonts, colors, plugins (like vim)) without demanding that someone else give up their environment or being slowed by having to give up mine.
Please consider opening the API and, if possible, sharing an sdk. I'm excited to work on this.

I agree. If you have a diversified team which is mainly using Rider, Vs Code, and Visual Studio that is an organic choice. I think it is ignored in both side from Microsoft and Jetbrains

I don't think JetBrains ignores heterogeneous environments, tbh. I've had licensing for their products for quite a few years now, both through their open-source initiatives and, for the last 2+ years, commercial licenses that my workplace has provided. None of their products are specifically anti-competitive or exclusionary, at least, not to my knowledge. The LiveShare binaries that are used by VSCode specifically prohibit reverse-engineering or re-use without authorisation -- I know, because I looked into piggy-backing of of them!
Opening the API (or at least removing the prohibitions and simply allowing free reverse-engineering) could potentially pave the way for amazing collaboration! I see this as a way for everyone to continue using the IDE of their choice, but able to work with each other.
And I must admit that I don't understand the restriction anyway: LiveShare is free in a free product (VSCode), so what does Microsoft stand to lose by opening the API? I can't see a rational reason not to open it up.

In 2021, having  a collaborative tool and choosing to make it non-interoperable, that does not reflect very positively on your dev philosophy.

When JetBrains finally gets CodeWithMe working in Rider as well as it does in WebStorm and other IntelliJ-based IDEs, this will no longer be a big issue. CodeWithMe already downloads a client for guests so even if the guest doesn't have the required IDE, it will Just Work. Perhaps someone will figure out interop from CodeWithMe to Visual Studio environments - I really hope so because the wall between remote developers based on IDE choice seems a little arbitrary, especially in the light of Visual Studio and VSCode both providing free versions of the product which both provide this collaboration experience.
I guess I'm just not smart enough to see how this is a competitive advantage for Microsoft. And I'm quite disappointed, to be honest. It's not what I'd expect from a modern Microsoft. Perhaps a decade or more ago, when chair-throwing was more in-vogue and open-source was a "cancer".

It's quite ridicolous to me that Live Share, a feature about collaboration, is locked away to a certain set of IDEs, and that way limiting what it can be used for, and how often it gets used.
I would love to see some sort of cross platform support.

@mikkelens There is already a cross-platform product where everyone can use the tools they already love to collaborate.
You can already live share your IDE between IDEs based on VS Code, IntelliJ, or Eclipse with CodeTogether.
Here's a 4-min video that looks like magic and will redefine reality.
Except for Rider -- sorry folks, but that one isn't supported as it has some architectural issues, detailed in this CodeTogether GitHub issue.
ACKNOWLEDGEMENT: I'm an employee of Genuitec and CodeTogether is our product.

Except for Rider
That's unfortunate since other jetbrains IDEs support something called (iirc) Code With Me, which is specfically something Rider is missing and I was looking for.

We're looking at how collaboration with Live Share works as a native concept in both VS Code and Visual Studio. The lack of interoperability is definitely a valid concern for people, and I will bring this to our strategic discussions in the upcoming quarter.

Any updates on this?

up

Hi - Just to provide some clarity and set expectations here, we’re not actively looking into this today. However, rest assured that we value your input. We will keep this issue open just to ensure we can continue to gather feedback. Thanks.

If the live share finally got into Rider, it will gonna be a revolutionary update for Rider developers to be honest

Maybe 2024 is the year for IDE agnostic live share??

Maybe 2024 is the year for IDE agnostic live share??

your optimism is refreshing, but I think Microsoft has made their position quite clear here: they'd rather screw the competition than advocate for developer diversity

Maybe 2024 is the year for IDE agnostic live share??

your optimism is refreshing, but I think Microsoft has made their position quite clear here: they'd rather screw the competition than advocate for developer diversity

Completely agree.

MS will never support other products for Live Share.
There is always CodeTogether Live that'd does and which I highlighted here

MS is full of great ideas and garbage implementation. To be fair Ms didn't solve VS issues and every good developer is switching to Rider. If you wait for a couple of weeks, you can get a functional one in Rider too 😄
Sent from Outlook for iOShttps://aka.ms/o0ukef

From: Todd Williams @.>
Sent: Tuesday, March 5, 2024 7:54:46 PM
To: microsoft/live-share @.>
Cc: Mohammad Moattar @.>; Comment @.>
Subject: Re: [microsoft/live-share] Interoperability of Live Share with other IDEs (#3299)
MS will never support other products for Live Share.
There is always CodeTogether Live that'd does and which I highlighted herehttps://github.com/microsoft/live-share/issues/3299#issuecomment-1100280393
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/live-share/issues/3299#issuecomment-1979524209, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAL5CZ6G255ITXYZWL2HSDDYWYPINAVCNFSM4LSYE5V2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJXHE2TENBSGA4Q.
You are receiving this because you commented.Message ID: @.***>

MS will never support other products for Live Share.
There is always CodeTogether Live that'd does and which I highlighted here

It still hasn't support rider yet

as pointed out, CWM doesn't work in Rider yet - they have architectural issues that they've been wrangling for, what, 2 years now? but they're expecting a release sometime "real soon now" 😆
CWM talks to CWM, so the original point of this inquiry still isn't met: the ability to collaborate cross-IDE. And unless someone opens up their api, it won't happen 😞  I'll be asking JetBrains for their stance once CWM is actually in Rider. If the ubiquitous collaboration protocol has to be CWM because MS is too stagnant to be the leader, so be it.

State of the live collaboration tools space:
Jetbrains CodeWithMe works only  with Jetbrains' tools (except Rider).
Microsoft Live Share works only with Microsoft's tools.
CodeTogether Live works with Microsoft's tools, Jetbrains's tools (except Rider), and Eclipse tools.
Rider's architectural issues are no joke. That's why CodeTogether gave up trying to support it. Only large changes by Jetbrains will enable collaboration with that tool.
Disclaimer: CodeTogether Live is a product of CodeTogether Inc which I helped to create.

I wanted to add that Neovim users can already enjoy remote collaboration using the live-share.nvim plugin. It would be fantastic if, in the future, we could see interoperability between Neovim and VSCode Live Share sessions. This integration would greatly enhance collaborative development across different editors, fostering a more inclusive and versatile environment for developers.


[react-native] Rename data file to .js extension

The main benefit of this PR is that it ensures Hanzi works in react native (RN) out of the box.
RN strongly encourages using the create-react-native-app toolkit to run your app. This setup comes with a predetermined webpack configuration and build system that discards many non .js file types. This was causing hanzi to fail as seen in @Dans-io issue: https://github.com/nieldlr/Hanzi/issues/38. I changed all of the data files to make sure they have a .js extension. Note that the require() calls did not have to change because a .js extension is added by default.
On the downside, we now would have large (megabytes-big) JS files in the repo which could slow down (or maybe crash) tooling we use in this project including linting, prettier formatting, Babel transpiling, and npm publishing.
This fix seems to work though from this issue https://github.com/nieldlr/Hanzi/issues/38. Therefore, I would support merging this change into master.
@nieldlr I would love your thoughts on this change.
CC @Dans-io

Travis-ci failed because PR #37 isn't merged in yet

Heya @zurawiki,
firstly. Hugely thanks for jumping on this for @Dans-io.
I ran some tests locally and it seems like these changes didn't quite impact performance for me (I have 2017 MacBook Pro, so not sure if that might bias things for me). So I think it's save to go ahead with this change for now. If things crop up due to performance we can take a look at this again.


Negative Value

The article mentions: "This threshold can be disabled completely by setting it to -1"
[Enter feedback here]
AFAIK, you cannot insert negative numbers in the registry as a DWORD. If you mean that we should use a HEX value larger than 7FFFFFFF you should mention that.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6fe81add-b285-ff8e-f383-2df80332e722
Version Independent ID: 4e96ec10-8088-0d77-bc8b-d2197aebf9d9
Content: Troubleshoot Cache and Memory Manager Performance Issues
Content Source: WindowsServerDocs/administration/performance-tuning/subsystem/cache-memory-management/troubleshoot.md
Product: windows-server
Technology: administration
GitHub Login: @phstee
Microsoft Alias: pavel

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


operator [CI] koku-metrics-operator (3.0.0)

Thanks for submitting your Operator. Please check the below list before you create your Pull Request.
New Submissions

[x] Are you familiar with our contribution guidelines?
[x] Have you packaged and deployed your Operator for Operator Framework?

[x] Have you considered whether you want to use semantic versioning order?
[x] Is your submission signed?
[x] Is operator icon set?

Updates to existing Operators

[x] Did you create a ci.yaml file according to the update instructions?
[x] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[x] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[x] Have you tested an update to your Operator when deployed via OLM?
[x] Is your submission signed?

Your submission should not

[x] Modify more than one operator
[x] Modify an Operator you don't own
[x] Rename an operator - please remove and add with a different name instead
[x] Modify any files outside the above mentioned folders
[x] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[x] Description of the managed Application and where to find more information
[x] Features and capabilities of your Operator and how to use it
[x] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[x] Human readable name and 1-liner description about your Operator
[x] Valid category name1
[x] One of the pre-defined capability levels2
[x] Links to the maintainer, source code and documentation
[x] Example templates for all Custom Resource Definitions intended to be used
[x] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

/lgtm

/approve

/merge possible

/retest

/merge possible

/retest-required

/merge possible

/merge possible

/hold

closing in favor of https://github.com/redhat-openshift-ecosystem/community-operators-prod/pull/3224


Specifying parameters to update during inference

KL_QP-like algorithms currently have the args model_fixed=False and guide_fixed=False to control whether their parameters are fixed during inference (KL_QP.step()). This is restrictive for compositional inferences where you might establish two KL_QP algorithms, each of which handles parameter updates of a different latent variable.
It would be nice if the arg is more locally at the parameter level, where the user might pass in a list of trainable variables. One question is how to handle the dynamic case when the list of trainable variables grows at runtime so the user can't specify the list a priori. model_fixed and guide_fixed do handle this case, so maybe a hybrid of these two approaches?
I ran into this issue when playing with probabilistic PCA in https://github.com/uber/pyro/issues/112 and following Edward's approach of 5 local updates per 1 global update.

what's the status of this proposal? seemed like everyone was on board... plan for 0.2?

This should be easier to implement if we switch from .backward() to torch.autograd.grad() #628 , which in turn should be easier once PyTorch optimizers support torch.autograd.grad() https://github.com/pytorch/pytorch/issues/4179 .

I believe #1060 resolves the original issue, and we can discuss scoping elsewhere


Add a way to check if struct has any content

Sorry for not responding earlier, I didn't have this repo watched for some reason, I'll take a look tonight.

no problem ;) please also check this one https://github.com/obrok/closed_struct/pull/2 - currently rspec is failing on travis because test code is outdated

@mpraglowski if you merge master CI should pass and I can merge

@obrok done

Released, have fun


Support numpy.hstack and numpy.vstack

As a side effect, improve support for numpy.concatenate.

@pbrunet : I'm still working on this one!

@pbrunet ready for review now

@pbrunet updated, I took into account all your comment but the one on sets. We actually cannot create set of ndarray in pythran (because we use std::set and std::set rely on operator< that does not return a bool for ndarray)

@pbrunet : green is the color


Cant create  release .jar

It seems like Im not able to create a release build. Everytime i run the grade script (other -> release), I get the error:

What went wrong:
A problem was found with the configuration of task ':applyRangeMap'.

File 'C:\Users\user\Desktop\DrehCraft\1.14\build\extractRangeMap\output.txt' specified for property 'rangeMap' does not exist.

Additionally, how am I able to get an obfuscated .jar/the obfuscated classes? After running other -> reobfJar, the only thing in the build/reobfJar folder is an output.jar, which is what it seems just the original .jar from minecraft. When i look into the log.txt it says that the folders where my mod should be got filtered

Filtered: io/pfuenzle/

Also, when running build -> jar, only the edited minecraft classes are placed in build/classes. It creates (sub)folders for my package name but doesnt place anything in them, but the mod works fine when Im just running it with IntelliJ

Run Build task not release

Thanks, now I got a jar with my code.
But is there a way to reobfuscate it so I can drop the modified classes in a vanilla .jar?

You're not distributing this are you?

Is this forbidden? I understood

WARNING: You CAN'T publish any code generated by this tool

as the code that is generated by it, not the compiled classes

Oh, I get what you mean now, that is fine.

I'm not home right now, so I can't check, but I think there is a task to reobfusticate.

Will find it when home.

Did you find it? Or did reobfJar work for you?

Sorry rly busy, maybe this afternoon. I'm gonna close this because you created the jar and that's what the issue was about.


对日历组件的value属性功能进行修正，新增了month和year。

对日历组件的value属性功能进行修正，新增了month和year。
对应issue：https://github.com/Tencent/tdesign-vue/issues/763

Codecov Report

Merging #813 (3f59bd8) into develop (a0db0df) will increase coverage by 3.89%.
The diff coverage is 63.71%.

@@             Coverage Diff             @@
##           develop     #813      +/-   ##
===========================================
+ Coverage    57.56%   61.45%   +3.89%
===========================================
  Files          346      355       +9
  Lines        12828    13434     +606
  Branches      2405     2547     +142
===========================================
+ Hits          7384     8256     +872
+ Misses        5200     4920     -280
- Partials       244      258      +14

Impacted Files
Coverage Δ

src/avatar/group.tsx
97.14% <ø> (ø)

src/breadcrumb/breadcrumb-item-props.ts
100.00% <ø> (ø)

src/calendar/props.ts
70.00% <0.00%> (-30.00%)
:arrow_down:

src/cascader/props.ts
91.66% <ø> (ø)

src/cascader/utils/inputContent.ts
59.45% <0.00%> (+6.68%)
:arrow_up:

src/date-picker/date-picker.tsx
46.57% <0.00%> (+0.72%)
:arrow_up:

src/date-picker/panel/date-range.tsx
7.48% <0.00%> (+0.29%)
:arrow_up:

src/dialog/props.ts
70.00% <0.00%> (-30.00%)
:arrow_down:

src/hooks/useVirtualScroll.ts
24.51% <ø> (ø)

src/input/index.ts
100.00% <ø> (ø)

... and 128 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 723095e...3f59bd8. Read the comment docs.


Add settings for Database options

Summary
Adding settings to change some behaviors and assumptions about how to translate Salesforce fields.
Please describe the problem you are trying to solve.
Depending on the use case some standard SF fields might be useful in a couple different forms.  Having settings to controls those could be helpful.  For example, the main record ID field might be more useful in some settings as an auto number, or plain integer than as an SFID. Another example would be RecordTypeIDs being set as the record type name on the assumption it would be translated during later processing.
Proposed Solution
Add the following settings to the preferences:

[x] Allow Picklists to be Varchar(255) instead of Enums.
[x] Make Picklist to string when the Salesforce value is unrestricted.
[x] Include a blank option in all Enums (instead of just null).
[x] Default lookups fields to indexed.
[x] Default to make picklists indexed.
[x] Allow lookups to default to: char(18), varchar(255) (or text when varchars are too numerous).
[x] Allow setting of default value to field default.
[x] Default all text values to empty string instead of null.

Additionally:

[x] #34
[ ] #57
[ ] #58

PRs for any individual piece happily considered. Please do not comment that prs that fix a piece will fix or close this issue.

My default values aren't being set properly. Defaults for Varchar(255)s are set without being enclosed in single quotes, so they aren't quite working in practice.


AMI run returns no results for 200k reads containing viruses

I ran SURPI to test it on a small sample comprising 200k already prefiltered Illumina reads (93MB fastq). I know there are viruses in there... Kraken spots perfect 31mer matches for a handful of RefSeq viruses. I was hoping to get some taxonomic assignments, but SURPI doesn't seem to have generated any useful information in its output, with most of the output files being empty.
I deployed the AMI to a m4.2xlarge instance and rsynced the reads across and then ran SURPI.sh in the default comprehensive mode. The fastq is 60MB after cutadapt, which seems reasonable. I get a SAM file from SNAP, but don't get any taxonomic information, nor a de novo assembly.
Can anyone suggest what might be going wrong here? I'd love to be able to use and cite SURPI.
Here is a screenshot of the output file listing:
https://www.dropbox.com/s/1a80v3raf03nem9/Screen Shot 2015-08-10 at 12.03.44.png?dl=0

Hi Bede,
Thank you for your comment, and screenshot - and apologies for the delay.
It looks like all of your files within the output folder are of 0 length, indicating that the run failed at some early point. If you still have the SURPI files, can you attach or send me the 2 files below:
SURPI.1.inc_orphans.clean.dedup.fq.err
SURPI.1.inc_orphans.clean.dedup.fq.log
Along with the first few reads from your file:
1.inc_orphans.clean.dedup.fq
Thanks - I'll try to troubleshoot with these files.
-Scot

@sfederman
SURPI also failed to generate counttables and in our test. You can find the log & err files here: https://www.dropbox.com/sh/xi1j5z292mqhiw9/AADlFB0GlM0BGLnrAntISeG2a?dl=0

@voutcn
You're also likely getting empty coverage plots due to your installed version of matplotlib, which looks to be at least v1.3.1. This issue should be able to be fixed by using the latest version of coveragePlot.py from the repository. (matplotlib v1.3.1 deprecated the load command).
As for the empty countable, it's hard to say what is happening. It looks like SURPI ran properly for you at least through the alignment to NT.
Also - would you mind starting a new thread with this topic? The original thread is regarding issues on the AMI, which you do not appear to be using here. I'll move my response if you can do so.
Thanks,
-Scot

Hi @sfederman, thanks for your reply. I'm afraid this was time-sensitive, and after receiving no reply for a month either on here or from the corresponding author, I gave up and deleted the run. I suppose that was silly of me.
I gather others have reported similar issues with the AMI not returning results for their reads. I may look to SURPI in the future but can't justify trying it again for now.
Thanks again,
Bede


LayerNorm error: TypeError: missing a required argument: 'num_warps'

🐛 Describe the bug
running the test/transformers/test_layer_norm.py yields TypeError: missing a required argument: 'num_warps'
Reproduce
No response
Versions
Environment Report:
Operating System: Linux-5.10.0-<IP_ADDRESS>-x86_64-with-glibc2.27
Python version: 3.9.19
PyTorch version: 2.3.1+cu121
CUDA version: 12.1
Triton version: 2.3.1
Transformers version: 4.45.0.dev0

Are you checked on a correct branch/commit? I'm not able to reproduce it myself. However I'm using triton 3.0

@S1ro1 I'm using the main branch, i.e., 0.2.1.dev20240905032819. I just cloned the latest clone from the main branch and run again and the error occurs. I'm using triton 2.3.1 as torch2.3.1 requires it.
To reproduce:
In [1]: import torch
   ...:
   ...: from liger_kernel.ops.layer_norm import LigerLayerNormFunction
   ...: from liger_kernel.transformers.functional import liger_layer_norm
   ...: from liger_kernel.transformers.layer_norm import LigerLayerNorm
In [2]: x = torch.randn(1, 128, 1024, dtype=torch.bfloat16, device='cuda:0', requires_grad=True)
In [3]: liger_ln = LigerLayerNorm(1024, eps=1e-6).to(torch.bfloat16).cuda()
In [6]: liger_ln(x)

git log -q:
commit a307eac8b05582ee110bfd02e6dc6819a029af1c (HEAD -> main, origin/main, origin/HEAD)
Author: S1ro<EMAIL_ADDRESS>Date:   Thu Sep 5 05:27:59 2024 +0200

you are right, if I upgrade triton to 3.0.0, the error disappears. But I need trition2.3.1
Installing collected packages: triton
  Attempting uninstall: triton
    Found existing installation: triton 2.3.1
    Uninstalling triton-2.3.1:
      Successfully uninstalled triton-2.3.1
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
lmdeploy 0.5.3 requires triton<=2.3.1,>=2.1.0; sys_platform == "linux", but you have triton 3.0.0 which is incompatible.
torch 2.3.1 requires triton==2.3.1; platform_system == "Linux" and platform_machine == "x86_64" and python_version < "3.12", but you have triton 3.0.0 which is incompatible.
torchtext 0.14.1 requires torch==1.13.1, but you have torch 2.3.1 which is incompatible.

Ok, installing triton 2.3.1 broke all of my installs, so can't really help you w this unless I figure this out.

@wizyoung There's a quick fix for triton 2.3.1. Check #219

good fix!


OLS-496: API version is parametrized for Azure OpenAI

Description
OLS-496: API version is parametrized for Azure OpenAI
Updated tests as well
Type of change

[ ] Refactor
[x] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library

Related Tickets & Documents

Related Issue #OLS-496

Checklist before requesting a review

[x] I have performed a self-review of my code.
[x] PR has passed all pre-merge test jobs.
[ ] If it is a core feature, I have added thorough tests.

/retest

/retest

/lgtm

/retest


How could I get 'wc_min_max.json' file?

Thanks for your repo, I tried to retrain model, but i meet an miss error about file named 'wc_min_max.json'.
How could I get it?
What dose the values mean?
Please, let me know how to solve this problem.

Yes, it is in my dataset. It is included to each of the downloadable dataset chunks.
The file specifies the minimum and maximum values for the World Coordinates (WC) within Inv3D, which are used for normalization.
You can create the file wc_min_max.json yourself with the following content:
{
    "min": [
        -0.6768526434898376,
        -1.2293856143951416,
        -1.2427754402160645
    ],
    "max": [
        0.6351865530014038,
        1.2340245246887207,
        1.2491472959518433
    ]
}


118 poc start that engine

@antw The backend is not yet finished and there is a lot of technical debt introduced in this issue to make sure we have at least some integration between all parts.
With this in mind, can you please take a look at the frontend code and add your review?


Run on macOS failed: "ld: library 'onnxruntime.1.15.1' not found"

Run on Android & iOS and it works fine. But macOS failed as it says:
Launching lib/main.dart on macOS in debug mode...
Building macOS application...
--- xcodebuild: WARNING: Using the first of multiple matching destinations:
{ platform:macOS, arch:arm64, id:00006000-001429982229801E }
{ platform:macOS, arch:x86_64, id:00006000-001429982229801E }
ld: library 'onnxruntime.1.15.1' not found
clang: error: linker command failed with exit code 1 (use -v to see invocation)
** BUILD FAILED **

Exception: Build process failed

@gtbluesky Needs help.

Find libonnxruntime.1.15.1.dylib under macos folder and put it in blobs under my project, rerun on mac and it worked!


BUG: Some fields getting hidden when switched to bright mode.

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
When we switch to bright mode some fields on the dashboard page are getting hidden.

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Need a good fix of it @PranotiPD . Go ahead . All the best
Join the whatsapp group for further discussion. I will look forward to your PR

Also check the Contributors.md file


Need looping statment support in YAML

Feature description
Need YAML support for looping statment( for ) in YAML.
Effected tests:
TC_ACT_2_1
TC_BR_1
TC_BR_2
TC_BR_4

Platform
all
Platform Version(s)
No response
Anything else?

Duplicate of #17739


Problem with the "Next" button

Description

The "Next" button in the "Generate Keys" page of "Subscribe to New Application" doesn't work.

When hitting the button an error log is logged saying that "Keys already generated for the application".

fixed in latest build


fix: SemiJoinLogicalJoinTranspose shouldn't throw error when eliminate outer failed

Proposed changes
when eliminate outer failed, there will be some failed case.
We shouldn't throw error.
Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Enhance Styling and Add Animations to "Catch the Ball" Game

Description
This pull request introduces improvements to the "Catch the Ball" game:

Animations: Added smooth animations for the background gradients, paddle movements, ball bounce, and scoreboard
updates.
Styling: Enhanced the overall game design with vibrant gradients, shadow effects, and cleaner transitions to improve user
experience.
Scoreboard Styling: Moved the scoreboard inside the game board for better visibility and improved styling consistency.

What does this PR do?

Enhances game visuals with modern animations and transitions.
Improves user experience through better interface design.
Updates the scoreboard position to be more intuitive for players.

Test Plan

Launch the game and observe the smooth animations for the paddle, ball, and background.
Verify the scoreboard updates correctly during gameplay and reflects changes in real time.
Ensure the game design and layout look consistent across various screen sizes.

Related PRs and Issues
N/A
Have you read the Contributing Guidelines on issues?
Yes, I Have you read the Contributing Guidelines on issues

Hey @ghostmkg , Thanks a lot for accepting my pull request! Super excited to see it merged. Looking forward to contributing more soon!


Some changes for better Nginx compatibility

The three patches are independent, but I couldn’t find how to make three distinct pull requests in github…
Unit tests: Nginx doesn't accept PUT requests without request body. Because of that, some tests doesn't pass (all tests involving PUT requests). a4d61ad fixes that.
base_uri: In nginx, url rewriting using match/replace (^(.*)$ index.php/$1) is hard and not widely used. The best way to achieve pretty-urls is to use :
try_files $uri $uri/ index.php

Which is equivalent to the (growing popular) apache rule
 RewriteCond %{REQUEST_FILENAME} !-f
 RewriteRule ^(.*)$ index.php [QSA,L]

However, this is not compatible with the current request_uri() implementation. 12955a3 fixes that.
Patch 5eaebb7 : $query_string is used in preference to $request_uri in request_uri(). This raises an important issue : assuming that the desired method by the webmaster/web developer to determine routing is request_uri (which is always the case in the example above), route http://example.com/app/route will work fine whereas http://example.com/app/route?foo=bar will not work. This is really bad IMO. We try to avoid this by not considering query_string being a valid route if it doesn't starts with '/'.

Thanks all for those good patches (I love Nginx!). Before I merge your pull request, can you confirm that tests are still passing ? Is there some changes/side effects that require a note in the README ?

Yes, the tests are still passing, at least on Nginx (no apache on my server ;))
Obviously no side effect for a4d61ad, or I think we have a serious problem ;)
For 5eaebb7 : prior to the patch, index.php?myroute was a synonym to index.php?/myroute. This is not the case anymore, only the index.php?/myroute form will be accepted as a valid route.
The description of the patch is bad, however. The issue it addresses is not that the query string is consumed, but that in the presence of a non-routing query string, the next part of the code is never called, which make the next patch (routing with request uri + base_uri option) pretty much useless.
For 12955a3  : since, if my understanding is right, this part of the code is rarely used (it just try to determine query_string/path_info from request_uri if the web server doesn't set them, but if that’s the case 1. that’s likely a configuration error, and php may have trouble running 2. php will try to build them itself if cgi.fix_pathinfo is on, which is the case by default), so it shouldn’t have any side-effect :)
For this last patch, note that I ran into an issue a few days ago : since query string is part of request uri, for /foo?bar the route is '/foo?bar' and not '/foo', which obviously leads to a 404 error when the request has a query string. I’ll probably push a fix for this at the begining of next week.


Handle more errors internally

The Wrong* constructors of LifxError mostly shouldn't be user-facing errors. For example, we should maintain a queue within the monadic state, so that we can wait for the message with the matching counter.

I have just seen a WrongSender in the wild for the first time. I wasn't doing anything weird - just trying to GetColor of several devices in quick succession, shortly after scanning for devices.

Closed by 081457df44318a2146d9862e1c6826144a85d6a4. I think it's fair to throw WrongPacketType and WrongSender once we know the counter matches.


To Do:  Light control and night day time config

This one needs someone to find the POST api endpoint.

https://github.com/cdnninja/yoto_api/discussions/5#discussioncomment-9448567

Thank you!   Time sensors now show up but I haven't got to the set part just yet.   Color will also take a bit since I think I should add those as a "light" entity for both on off and color control.

For the set part, note a PUT request should be sent, not POST.

So turns out these devices support any color.  Not just those few in the app!

Time set for modes is now in master and functional. The config set function is build for the 8 items I think will be most in demand.  Easy to add others too.   My next focus will be adding the light control and those other items, max volume settings, brightness etc.

Few more config control items just added.  Including day and night max volume and brightness.   Auto brightness needs to be added still.

Looks good! Just updated to latest master and had a quick play. Didn't realise my partner was putting our son to bed and she wondered what was happening as I was changing volume in a different room!
It would be good to have different icons for the values rather than the default slider ones to help differentiate them. I'm happy to work on that.

Great thank you!

Here you go. These seemed like sensible choices for the icons, but happy to change them: https://github.com/cdnninja/yoto_ha/pull/76

Auto brightness switch now added.  I didn't do icons but have the switch working.

I didn't do icons

More than happy to help where I can - https://github.com/cdnninja/yoto_ha/pull/79

Appreciated!!
Last few items I plan to do for control are the night light color and sleep timer.  After that I think all the key control features are done.
Browse media is probably the other, that looks complicated in home assistant code though.

It's amazing how quickly this integration has come out of nothing. Great work to all involved!
Personally, I wouldn't get a huge amount of value from Browse Media, but it would be good to play a card/track from a service call.

Play media works today. You can't input a track. I hard coded it to the first track to get it working.
If you go to service call and enter the card id it will work.

Ah excellent. I'll have a play tomorrow and update the readme with more details.

Light control for day/night was this weeks config item.   As a note works for all colors not just the short list in app.   I am going to close this out now since key control items are complete.  Alarms may make sense in the future but will wait for interest first.


Meross Cloud profile api login error

When requesting the merross key, the following error message appears after entering the user name and password :
404, message='Not Found', url=URL('https://iot.meross.com/v1/Auth/Login')
Originally posted by @helebrant in https://github.com/krahabb/meross_lan/issues/365#issuecomment-1879590581

+1 Seems like they changes something on the cloud side ?

I have the same error.
I have received an email that says the following:
Dear user,
We have recently noticed that login attempts to your account have been unsuccessful. We regret to inform you that we have discontinued services for specific versions of our application and have provided a new, more secure and improved version. To restore normal functionality, please read the following update information and guide.

Reason for discontinuation:

Due to technical improvements and security requirements, we have discontinued previous versions of our application. This step has been taken to ensure that our users can enjoy a better experience and greater data security.

Versions that are discontinued:

Android: V2.26.0 and earlier.
iOS: V2.22.0 and earlier.

Scope of impact:

Discontinuing these app versions will prevent you from being able to log in and use our services. Certain features and modules may not function properly or be accessible.

Actions required:

If you are using one of the affected versions, please update to the latest version of the app immediately. You can download the latest version from your app store (such as App Store or Google Play).
If you are already using the latest version of the app, no further action is required.
If you are using third-party platforms not authorized by Meross to manage our devices, we cannot guarantee their compatibility with our new cloud interfaces or the security of your devices and data. Please return to our official services, as set out in our terms of service, to ensure proper operation.

Technical support:

If you encounter any problems during the update process or have any questions about the new version, please contact our technical support team. You can contact us at<EMAIL_ADDRESS>We understand that this may cause some inconvenience, but it is done in order to offer a better service and protect your data. Thank you for your understanding and cooperation.
We wish you a pleasant experience!
[Meross Cloud Team]

@krahabb
Still can't log in.
Authentication error
int([x]) -> integerint(x, base=10) -> integerConvert a number or string to an integer, or return 0 if no argumentsare given.  If x is a number, return x.int().  For floating pointnumbers, this truncates towards zero.If x is not a number or if base is given, then x must be a string,bytes, or bytearray instance representing an integer literal in thegiven base.  The literal can be preceded by '+' or '-' and be surroundedby whitespace.  The base defaults to 10.  Valid bases are 0 and 2-36.Base 0 means to interpret the base from the string as an integer literal.>>> int('0b100', base=0)4

Hello @JaKubinaa,
I cannot really figure out where this error comes from. the 'Authentication error' is effectively only reported when trying to login to the Meross cloud but the details about it (all the stuff about converting to an integer number) are really unexpected to me in that phase :(
which version are you on? I've checked the latest published v4.5.3 (Cloudy.5.3) and can't see a reason for that error

I am having the same issue. Would an additional log of use? How can I forward that to you?

@krahabb Still can't log in.
Authentication error
int([x]) -> integerint(x, base=10) -> integerConvert a number or string to an integer, or return 0 if no argumentsare given. If x is a number, return x.int(). For floating pointnumbers, this truncates towards zero.If x is not a number or if base is given, then x must be a string,bytes, or bytearray instance representing an integer literal in thegiven base. The literal can be preceded by '+' or '-' and be surroundedby whitespace. The base defaults to 10. Valid bases are 0 and 2-36.Base 0 means to interpret the base from the string as an integer literal.>>> int('0b100', base=0)4

@JaKubinaa Hey mate, I had a similar issue that was due to the wrong password being used to sign in. Maybe it's a similar case for you.

Error comes from two-factor authentication, when I disabled it then I could log in.

Thank you for sharing,
I now remember incurring in some issues while developing the new signin interface and an error likely similar was due to the server responding with an error at the http level (the verbose message you get is probably related to the json decoding of the server response which is not json in that case)
I'll setup a 2-factor and test the flow for that case too since it looks like someone uses it ;)

The MFA support code is now published in pre-release. The 'cryoptic' error to be honest was due to a bug in error processing which was collecting that garbage instead of the correct error message.
Now the authorization flow will proceed as before with email/password and in case the account is configured for MFA the flow will then ask for the corresponding authenticator code and finalize the login

I just tried setting-up a new MSG100 garage door opener and am receiving this same 404 error. I don’t have any special characters in my password and 2FA is not enabled. I get this error when I visit https://iot.meross.com/v1/Auth/Login in a web browser too.

The Meross cloud api changed a bit some time ago (maybe 1 year or so...) and the repository you pasted looks like still using the old endpoint(s)
You can find hints for the cloudapi endpoints and updated api calls here


There is a way to revoke token on logout?

Could someone figure out how it possible to mark exisiting token as invalid? I know that it possible if user object will be changed.
Any ideas?
P.S. And we talking about BE side, not about simple token  removal on FE side

thanks for your opinion! Let's close this issue


Navigation TOC Animation

Hey. I may have found a bug.
If the site page is in English, then when you click on the navigation TOC, the page scrolls smoothly.
If the site page is in Russian, then when you click on the navigation TOC, the page scrolls abruptly (no animation).

Minimal Mistakes version: 4.20.1

Ruby gem or remote theme version: 2.6.6

Jekyll version: 4.1.1

Operating system: win 10

Doesn't look right to me.

Doesn't look right to me.

Yes, it works on a clean theme as intended. I checked. I don't understand what could have broken the animation...

@mmistakes, please tell me which files are responsible for animation in TOC navigation?

@blogi-kriptovalyut There isn't any animation specific to the TOC navigation. The site uses a smooth scroll JavaScript that smoothly scrolls to internal page links.
My guess is you added something that broke that script when customizing things.


Could not create instance problem after AGP upgrade

FAILURE: Build failed with an exception.

What went wrong:
A problem occurred configuring project ':flutter_barcode_scanner'.

Could not create an instance of type com.android.build.api.variant.impl.LibraryVariantBuilderImpl.
Namespace not specified. Specify a namespace in the module's build file: C:\Users\akali\AppData\Local\Pub\Cache\hosted\pub.dev\flutter_barcode_scanner-2.0.0\android\build.gradle. See https://d.android.com/r/tools/upgrade-assistant/set-namespace for information about setting the namespace.

 If you've specified the package attribute in the source AndroidManifest.xml, you can use the AGP Upgrade Assistant to migrate to the namespace value in the build file. Refer to https://d.android.com/r/tools/upgrade-assistant/agp-upgrade-assistant for general information about using the AGP Upgrade Assistant.

could you please share me the flutter and package version you are using. I have tested in android sk upto 35 and seems fine.

Dart SDK 3.5.3
Flutter SDK 3.24.3
simple_barcode_scanner: ^0.1.2

I also have the same problem. i'm using simple_barcode_scanner: ^0.1.2.
Strangely my other project with the same configuration (on the same laptop) having no problem at all (I just create the appbundle for that project).
problem:
FAILURE: Build failed with an exception.

What went wrong:
A problem occurred configuring project ':flutter_barcode_scanner'.

Could not create an instance of type com.android.build.api.variant.impl.LibraryVariantBuilderImpl.
Namespace not specified. Specify a namespace in the module's build file. See https://d.android.com/r/tools/upgrade-assistant/set-namespace for information about setting the namespace.

flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.24.3, on Microsoft Windows [Version 10.0.22631.4169], locale en-US)
[✓] Windows Version (Installed version of Windows is version 10 or higher)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Chrome - develop for the web
[✓] Visual Studio - develop Windows apps (Visual Studio Build Tools 2022 17.8.3)
[✓] Android Studio (version 2021.3)
[✓] Android Studio (version 2023.2)
[✓] VS Code, 64-bit edition (version 1.87.1)
[✓] Connected device (4 available)
[✓] Network resources
• No issues found!

I see, issue caused by flutter_barcode_scanner underlying package that we use, please use simple_barcode_scanner: ^0.1.1  for now.
I will figure out and update the issue in next release.

Fixed https://pub.dev/packages/simple_barcode_scanner/versions/0.1.3

It worked. You are so quick. Thanks a lot!

Thank you for your quick solution


[WIP] tests: kernel: timer_api fails with CONFIG_STM32_LPTIM_TIMER

Ttesting kerenl/timer/timer_API with LPTIM on stm32L4R5 with nucleo_l4r5zi board,
the test_timer_duration_period fails w"
test_timer_duration_period: tdata.expire_cnt == 4 is false"

changed z_timer_cycle_get_32() function to have better value returned in nb of HW cycles
changed the calculation for next timeout in case of short delay
source LPTIM with  LSE clock for better accuracy
reduce tick freq to 1000 per sec

Fix https://github.com/zephyrproject-rtos/zephyr/issues/20991
Signed-off-by: Francois Ramu<EMAIL_ADDRESS>

If the irq has not yet been handled but the counter just resets after the roll-over we must add thi roll-ove value in the actual counter position

Changed the calculation of the nb of hw cycles which is returned by the z_timer_cycle_get_32() function in case of LSE clock.
In case of LSI clock the both methods works.
Remaining work:  set a timeout close to the current counter.

This version passed kernel test on nulceo_l4r5zi board with LPTIM timer running on LSI clock
Device testing on:
nucleo_l4r5zi (None) on /dev/ttyACM0
Adding tasks to the queue...
total complete:   82/  82  100%  skipped:    8, failed:    0
74 of 82 tests passed (100.00%), 0 failed, 8 skipped with 0 warnings in 2287.16 seconds
In total 93 test cases were executed on 1 out of total 213 platforms (0.47%)

as nucleo_wb55rg board has CONFIG_SYS_CLOCK_HW_CYCLES_PER_SEC=32000000
a LPTIM clock source of LSI=32000 gives better accuracy in lptimer calculations

on nucleo_wb55rg and nucleo_l4r5zi boards:
test passed with  west build -b nucleo_wb55rg tests/kernel/fatal
test passed with  west build -b nucleo_wb55rg tests/kernel/sched/schedule_api
test passed with  west build -b nucleo_wb55rg tests/kernel/timer/

add change for nucleo_wb55rg board

in the tests/kernel/critical, the test case regression_thread  is calling k_sched_time_slice_set()
TC_PRINT("Enable timeslicing at %u\n", k_uptime_get_32());
k_sched_time_slice_set(10, 10);
However in case of CONFIG_TIMESLICING=n the k_sched_time_slice_set  is not defined.
by the kernel/sched.c
Is it correct ?

test with dummy k_sched_time_slice_set() function

removed useless constant definition in dts_fixup.h

fix checkpatch issues

changing the testcases tests/kernel/timer for , nucleo_l4r5zi and nucleo_wb55rg boards
with a special config taht enables the LPTIM
TICKS_PER_SEC is set to 1000 and LSE is selected as LPTIM clock source for this tests

update after erwango's review

Add the PR  https://github.com/zephyrproject-rtos/zephyr/pull/25126 to help fixing the issue https://github.com/zephyrproject-rtos/zephyr/issues/20991

When the LPTIM is needed, the
CONFIG_STM32_LPTIM_TIMER=y
must be set

Takes the https://github.com/zephyrproject-rtos/zephyr/pull/25126
Configures some tests/kernel   testcases to include the LPTIM feature
Add a DT for the stm32-lptim yaml

Testing on nucleo_wb55rg with CONFIG_STM32_LPTIM_CLOCK_LSE and CONFIG_SYS_CLOCK_TICKS_PER_SEC=4096
--> tests/kernel/timer and tests/kernel/early_sleep PASSED
--> tests/kernel/sched/schedule_api/ still fails if CONFIG_TIMESLICING=y

@jdascenzio would you mind review this PR ?
If you agree your commits would be merged as part of this PR.

running testcases  kernel/tests on nucleo_l4r5zi with
CONFIG_STM32_LPTIM_TIMER=y1
CONFIG_SYS_CLOCK_TICKS_PER_SEC=32768

adding the https://github.com/zephyrproject-rtos/zephyr/pull/25412  in case of tests with CONFIG_TICKLESS_KERNEL=n
Test with nucleo_l4r5zi with LPTIM sourced by LSE and TICKS_PER_SEC=4096

@erwango could you take a look at this one?

Note that test/kernel/interrupt
still few tests fail on l4r5zi with LSE clock source and TICKS_PER_SEC=4096
tests/kernel/common/kernel.common
tests/kernel/sleep/
tests/kernel/fifo/fifo_timeout/kernel.fifo.timeout
Note that tests/kernel/interrupt  could fail due to the irq pemption on lptim irq itself

@erwango @jdascenzio can we move this forward so we can get the fix in in time for 2.3.0? Thanks!

@erwango can you take another look at the PR after @FRASTM pushed an update?

@jdascenzio, are you fine with the last changes ?

change after @erwango 's review

rebase

Another comment: when setting SYS_CLOCK_TICKS_PER_SEC=32768 (instead of 4096) with a LSI OSC, test_timer_remaining fails.
This seems to be a math issue in k_busy_wait and setting both CONFIG_SYS_CLOCK_HW_CYCLES_PER_SEC and SYS_CLOCK_TICKS_PER_SEC to 32768 (like done on the nRF52 series) just makes the issue to disappear.

@erwango please re-review

include lptim in  the stm32wbx series


impossible to use it

Which API Provider are you using?
Anthropic
Which Model are you using?
Sonnet 20241022
What happened?
its impossible to use it , its does not finish the operations properly also the output limit is not enough to finish not even one task and also is so annoying the to stay pressing a button because it looses connection with the api , for what we are pay for the services thats not working , for God sake unfortunately this company it wont give my money back ,because at least for the service they say the provide its only lies on the midia
Steps to reproduce

Relevant API REQUEST output
No response
Additional context
No response

It seems like Anthropic is having server issues. I suggest using OpenRouter in the meantime.


Automated Contour version update 1.24.3

Automated changes by the cron-contour-update GitHub action
Adds [Contour add-on](https://kurl.sh/docs/add-ons/contour) version 1.24.3.

Blocked by https://github.com/replicatedhq/kURL/pull/4305


Fix overlay node

This commit changes the overlay node to match the overlay operation in the Adobe PDF spec.
Overlay(cb, cs) = { 2 * cs * cb                 [if cb <= 0.5]
                    1 - 2 * (1 - cs) * (1 - cb) [if cb > 0.5]

(cb = B, cs = F in MaterialX specification notation)
It also changes the implementation to graph based instead of code snippets.

Before the fix:

After the fix:

before.pdf
after.pdf

Great work, @rasmusbonnedal, and I really like the decision to implement this node as a language-independent graph.  I don't see any issues that concern me in this change, though I'd like to run this through local tests before merging.


Switching ships in the same fleet won't update ship portrait

When switching the positions of two ships in the same fleet, only the original position's portrait will be refreshed
Steps to recreate the bug, assuming you have Yamato as your Flagship and Musashi in the second position:
1- Enter the fleet management screen
2- Click on Yamato, in order to replace her with another kanmusu
3- Select Musashi from the ship list
4- Yamato will switch positions with Musashi. The Flagship's portrait will change to Musashi, but the 2nd position's portrait won't refresh, remaining as Musashi as well

Similar: Issue #3

ah, sorry for the duplicate. I tried to search for "portrait" before I posted but nothing came up

np~


Add address cleaning using the SmartyStreets API

Adds separate fields to Household
Creates a thor task

Gonna merge this since we have a deadline to transfer data.


Admin add signature modal

Admin add signature modal
Make a place for campaign manager to upload photo in campaign portal

Collect: first, last, email, comment
Visible: to public to first, last and comment


fix(db): coerce async snapshot subscriptions with debounce operator

Checklist

Issue number for this PR: #1583
Docs included?: n/a
Test units included?: yes
In a clean directory, yarn install, yarn test run successfully? yes

Description

Swaps delay(0) in favor of debounceTime(0) to coerce async fromRef() database snapshot subscriptions. This prevents async listChanges() scans from burst emitting multiple copies of the same ref['on']('value') events.
@jamesdaniels Is this an acceptable / desirable change? It works well for me, but may have implications I'm not thinking of outside of standard RTDB use cases.
An alternative might be to revisit how listChanges() is implemented, perhaps by augmenting distinctUntilChanged() to debounce objects / arrays as well as immutable primitives.
Code sample

src/database/observable/fromRef.ts
export function fromRef(ref: DatabaseQuery, event: ListenEvent, listenType = 'on'): Observable<AngularFireAction<DatabaseSnapshot>> {
   ...
   // Ensures subscribe on observable is async. This handles
   // a quirk in the SDK where on/once callbacks can happen
   // synchronously.
-  .delay(0)
+  .debounceTime(0)
   .share();
 }

I have a suspicion on both this and the root cause of your slow down now; I'm going to close this while I think on it more + come up with an ultimate fix.
I think the .share got moved to a different place, leading to multiple listeners being created w/your usage patterns. While it's not changing the data it's leading to unnecessary change detection since we're slicing the array. distinctUntilChanged() is thinking in the right direction, but I think ultimately the correct thing to do is be more careful about using slice and creating a new array (which trips change detection, since === is false) when the snapshotChange is a no-op.


(BUG) [RN] User is able to log in via Google without previous registration

Precondition:
The start page is opened
Steps to reproduce:

Click the "Already Have a Wallet? Log In >" button
Click the "Log in with Google" button and select a mailbox that you  never been used for gooddollar before
Pay attention to the wallet that automatically created without registration

Actual result: User is able to log in via Google without previous registration
Expected result: User isn't able to log in via Google without previous registration
Note: reproduced for QA
Checked on native/QA 1.3.1-1
Desktop: Windows 10 // Google Chrome 86.0.4240.75
Video: https://www.screencast.com/t/5P3qWYrZh

@sirpy I've tested after you pushed small fixes and that looks that I can't log in at all https://www.screencast.com/t/CtkpGOsIhz
I have on this mailboxes the wallets but every trying to log in is unsuccessful/ the login screen appears again

@sirpy Issue isn't reproduced anymore but we have another issue
I've created a new wallet and I couldn't get into the wallet via login after logging out.   separated #2707


[docs] Add cryptography examples

Add encrypt and decrypt examples to the go client doc
Remove empty headers that still need examples someday :)

@hhunter-ms please make CI happy then we can make it land.


fix: hack around libsysroot instead of libtest

What does this PR try to resolve?
This is a fix in response to rust-lang/rust#108865.
Cargo -Zbuild-std now use sysroot crate to resolve cargo features instead
of the old hack around libtest. sysroot is just a dummy crate depending on
other standard library crates.

:pushpin: Commit 3df35edca7c92fd3590c688bb7eed0b478794c92 has been approved by epage
It is now in the queue for this repository.

:hourglass: Testing commit 3df35edca7c92fd3590c688bb7eed0b478794c92 with merge b0f118f4f3b3b3483b3e0691ca00c07b121ff950...

:sunny: Test successful - checks-actions
Approved by: epage
Pushing b0f118f4f3b3b3483b3e0691ca00c07b121ff950 to master...

Why not drop all of cargo/tests/testsuite/mock-std/library/test?

Why not drop all of cargo/tests/testsuite/mock-std/library/test?

Why drop? We're trying to mock std here, and it makes the build depends on panic_unwind.


Update test to include new functionalites

Codecov Report

Merging #263 (53f78b9) into master (fc671a3) will increase coverage by 0.85%.
The diff coverage is 42.85%.

@@             Coverage Diff              @@
##             master     #263      +/-   ##
============================================
+ Coverage     55.09%   55.95%   +0.85%
- Complexity      612      624      +12
============================================
  Files           106      106
  Lines          2817     2822       +5
  Branches        384      385       +1
============================================
+ Hits           1552     1579      +27
+ Misses         1111     1079      -32
- Partials        154      164      +10

Impacted Files
Coverage Δ

.../seedu/address/logic/parser/ViewCommandParser.java
32.85% <ø> (+17.14%)
:arrow_up:

...java/seedu/address/logic/commands/ViewCommand.java
64.70% <42.85%> (-0.52%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc671a3...53f78b9. Read the comment docs.


Fix promote charm usage

Applicable spec: NA
Overview
Update the promote_charm.yaml usage of operator-workflow to use the main branch.
Rationale
The promote_charm.yaml is merged into main branch. The reference to the original branch is not needed anymore.
Checklist

[x] The charm style guide was applied
[x] The contributing guide was applied
[x] The changes are compliant with ISD054 - Managing Charm Complexity
[x] The documentation is generated using src-docs
[x] The documentation for charmhub is updated.
[x] The PR is tagged with appropriate label (urgent, trivial, complex)

@yhaliaw you might have missed labelling the PR


Medications

Relevant Issue
N/A
Description

Reworked Medications page to have a UI and display values pulled from the backend.

I don't know if it's 100% necessary to show a start date and end date for medication. Maybe something for if a prescription is about to expire (so end date?), but I was also thinking of having an active/inactive distinction.
This particular task was just for patient, but we do need to add some way for physician to add medication to a patient.