No LICENSE

Hi there! I came across this code from looking at a stackexchange post that linked to it. I'd like to use this code, but there's no license, so I don't think I can legally do so. What license did you intend for this code?
Thanks,
Shawn

Howdy. Happy for you to use it as you will. Just added a MIT license.

Thanks!
On Thu, Aug 31, 2023 at 5:58 AM hawkjo @.***> wrote:

Howdy. Happy for you to use it as you will. Just added a MIT license.
—
Reply to this email directly, view it on GitHub
https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhawkjo%2FConstantMarginalIterator%2Fissues%2F1%23issuecomment-1700901752&data=05|01|Shawn.Geller%40Colorado.EDU|a62da2e2fbf64aa7f9e308dbaa198c0a|3ded8b1b070d462982e4c0b019f46057|1|0|638290798947304505|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=yVRpmWeMEy0s76RTZfE7wGfN9b25DAYSMvkHUA1cJ4I%3D&reserved=0,
or unsubscribe
https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAIZX7PG2QAFQRG7TNB5G33DXYB35FANCNFSM6AAAAAA4B5MEF4&data=05|01|Shawn.Geller%40Colorado.EDU|a62da2e2fbf64aa7f9e308dbaa198c0a|3ded8b1b070d462982e4c0b019f46057|1|0|638290798947304505|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=gpTeSlcE0ZbEk6YjJrGUG%2BcsgPMtw6yVMQlPGwyDNVE%3D&reserved=0
.
You are receiving this because you authored the thread.Message ID:
@.***>


[WIP] Android N Support

Android N built applications have a 56 byte configuration. Unknown purpose of extra bytes.

References #1223

[ ] Identify purpose of 4 additional bytes

[x] Update internal manifest to Android N framework

[x] Rebuilt binary appts for mac / windows / unix using new android_frameworks_base during release of Android N

[ ] Add unit tests for new qualifiers to prevent regression

[x] Hackily patch Decoder to allow decode

[x] AAPT Bundle Format

[x] Investigate App Signature v2

[x] Don't compress mkv or webm

[x] Add support for TYPE_DYNAMIC_ATTRIBUTE

https://github.com/android/platform_frameworks_base/commit/8ac51d14b614ba6a12df2ba90d50a01f50d548aa - new TYPE_DYNAMIC_ATTRIBUTE - 0x08
https://github.com/android/platform_frameworks_base/commit/6e452f9e8a42f0f1217d25c9cf6017abdd5be08a - Don't compress MKVs
https://github.com/android/platform_frameworks_base/commit/90d5052bd71b4b58069fd830834daf8dad339ef0 - Don't compress webm
AAPT Bundle Format - https://github.com/android/platform_frameworks_base/commit/07dfd2d8642f8a3630ca6429f740865a0c0bfdf7
https://developer.android.com/about/versions/nougat/android-7.0.html#apk_signature_v2 - App Signature v2 breaks -c (deprecate for removal, I think)

Broke the tests, so guess the aapt binaries aren't ready.

New aapt binary has a few more restrictive checks (probably shouldn't have done this in the first place)
W: /tmp/BRUT4777876962906765638.tmp/testapp-orig/res/drawable-xxhdpi/ic_launcher.png: error: Duplicate file.
W: /tmp/BRUT4777876962906765638.tmp/testapp-orig/res/drawable-xxhdpi-v4/ic_launcher.png: Original is here. The version qualifier may be implied.

Ok, no idea what the new 4 bytes are in ConfigFlags, but we just skip them. This is ready to merge post final checks.


Central view of the release metrics in the website

Description
Coming from the initial PR https://github.com/opensearch-project/project-website/pull/3254 the central view for the release metrics are onboarded. This PR targets adding more functionality and making this page more robust central release dashboard. For UI mocks please check the comment here https://github.com/opensearch-project/opensearch-metrics/issues/69#issuecomment-2330433245.
Issues Resolved
Part of https://github.com/opensearch-project/opensearch-metrics/issues/69 and https://github.com/opensearch-project/opensearch-metrics/issues/51
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

Adding @nateynateynate to please take a look.
Thanks


Add Java goody for traversing a binary tree in level order

Can draw inspiration from the TypeScript goodies in #189.

I would like to try to take this one on.

That'd be great, thank you!

@SysCoder, I'm releasing this for now, feel free to reclaim it if you plan to work on it.


The file has too many nested expressions or statements

model多了之后，if-else过多，导致无法使用，报错如下：
lib/generated/json/base/json_convert_content.dart:3828:4: Error: The file has too many nested expressions or statements.
lib/generated/json/base/json_convert_content.dart:3829:10: Error: The file has too many nested expressions or statements.
lib/generated/json/base/json_convert_content.dart:5104:4: Error: The file has too many nested expressions or statements.
lib/generated/json/base/json_convert_content.dart:5105:10: Error: The file has too many nested expressions or statements.

加群聊吧

新版本已修复


Unable to add a conference after last commit

This is what I get whenever I try to add a conference. Though 1 record was added previously.
Please check and update.

Resolved


Fix for App crash while navigating back from Contacts

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/11091
PROPOSAL: https://github.com/Expensify/App/issues/11091#issuecomment-1259709504
Tests

Click on + icon > new chat.
Press the back button to go back to home page before keyboard opens.
Observe that no crash occurs.

[x] Verify that no errors appear in the JS console

PR Review Checklist

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

QA Steps

Click on + icon > new chat.
Press the back button to go back to home page before keyboard opens.
Observe that no crash occurs.

[ ] Verify that no errors appear in the JS console

Screenshots

Web

https://user-images.githubusercontent.com/11609254/194713397-0dcf0100-cc03-48a2-b66f-8d69823ff047.mov
Mobile Web - Chrome

https://user-images.githubusercontent.com/11609254/194713416-858c39e9-0b16-4f4e-8ffb-5bfc08c9aca4.mp4
Mobile Web - Safari

Desktop

iOS

https://user-images.githubusercontent.com/11609254/194713447-8ee19f54-2b42-4f09-b92b-7601e93888aa.mp4
Android

https://user-images.githubusercontent.com/11609254/194713458-5432beee-4d52-482d-967a-740ddda8c65c.mp4

@parasharrajat Can you please add videos for all platforms that verify the app no longer crashes? Thanks!

Here are the videos

WEB

https://user-images.githubusercontent.com/24370807/195370208-7e2ea693-b30d-4911-a610-49afbf07d3ef.mp4

Android

https://user-images.githubusercontent.com/24370807/195370241-defbad29-aee1-46e2-bdb3-5235c0456758.mp4

Mweb- Chrome

https://user-images.githubusercontent.com/24370807/195370256-a8aab59a-f3d3-4751-82bf-de3454fb2efc.mp4

Mweb - safari

https://user-images.githubusercontent.com/24370807/195377088-f0b9b821-212e-4204-ae70-e4354b440fee.mp4

Desktop

https://user-images.githubusercontent.com/24370807/195376308-9e3191b7-dc98-41e7-b502-b11ab36a7663.mp4

iOS

https://user-images.githubusercontent.com/24370807/195376333-1eed8a8e-f302-45c7-aa05-2bba6c3fc5c9.mp4

Seems like the Checklist action are however failing. We may need to update them with the latest here:
https://raw.githubusercontent.com/Expensify/App/main/.github/PULL_REQUEST_TEMPLATE.md
@parasharrajat @Ollyws can you please do this?
Also, the CLA Assistant appears to be failing, but I see @Ollyws has signed it 🤔

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @mountiny in version: 1.2.15-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @yuwenmemon in version: 1.2.15-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


az grafana api-key create is broken

Describe the bug
Creating an api-key for Grafana is broken via az cli.
Related command
az grafana api-key create
Errors
The command failed with an unexpected error. Here is the traceback:
No module named 'azure.mgmt.dashboard'
Traceback (most recent call last):
File "/opt/homebrew/Cellar/azure-cli/2.58.0/libexec/lib/python3.11/site-packages/knack/cli.py", line 233, in invoke
cmd_result = self.invocation.execute(args)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/homebrew/Cellar/azure-cli/2.58.0/libexec/lib/python3.11/site-packages/azure/cli/core/commands/init.py", line 562, in execute
self.commands_loader.load_arguments(command)
File "/opt/homebrew/Cellar/azure-cli/2.58.0/libexec/lib/python3.11/site-packages/azure/cli/core/init.py", line 522, in load_arguments
loader.load_arguments(command)  # this adds entries to the argument registries
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/a.eimer/.azure/cliextensions/amg/azext_amg/init.py", line 28, in load_arguments
load_arguments(self, command)
File "/Users/a.eimer/.azure/cliextensions/amg/azext_amg/_params.py", line 14, in load_arguments
from azure.mgmt.dashboard.models import ZoneRedundancy
ModuleNotFoundError: No module named 'azure.mgmt.dashboard'
To check existing issues, please visit: https://github.com/Azure/azure-cli/issues
Issue script & Debug output
cli.knack.cli: Command arguments: ['grafana', 'api-key', 'create', '--key', 'keyname', '--name', 'foo', '--resource-group', 'bar', '--role', 'editor', '--output', 'json', '--debug']
cli.knack.cli: init debug log:
Enable color in terminal.
cli.knack.cli: Event: Cli.PreExecute []
cli.knack.cli: Event: CommandParser.OnGlobalArgumentsCreate [<function CLILogging.on_global_arguments at 0x101a451c0>, <function OutputProducer.on_global_arguments at 0x101af4360>, <function CLIQuery.on_global_arguments at 0x101b21e40>]
cli.knack.cli: Event: CommandInvoker.OnPreCommandTableCreate []
cli.azure.cli.core: Modules found from index for 'grafana': ['azext_amg']
cli.azure.cli.core: Loading command modules:
cli.azure.cli.core: Name                  Load Time    Groups  Commands
cli.azure.cli.core: Total (0)                 0.000         0         0
cli.azure.cli.core: These extensions are not installed and will be skipped: ['azext_ai_examples', 'azext_next']
cli.azure.cli.core: Loading extensions:
cli.azure.cli.core: Name                  Load Time    Groups  Commands  Directory
cli.azure.cli.core: amg                       0.080         9        45  /Users/a.eimer/.azure/cliextensions/amg
cli.azure.cli.core: Total (1)                 0.080         9        45
cli.azure.cli.core: Loaded 9 groups, 45 commands.
cli.azure.cli.core: Found a match in the command table.
cli.azure.cli.core: Raw command  : grafana api-key create
cli.azure.cli.core: Command table: grafana api-key create
cli.knack.cli: Event: CommandInvoker.OnPreCommandTableTruncate [<function AzCliLogging.init_command_file_logging at 0x10285eac0>]
cli.azure.cli.core.azlogging: metadata file logging enabled - writing logs to '/Users/a.eimer/.azure/commands/2024-03-19.16-09-19.grafana_api-key_create.51836.log'.
az_command_data_logger: command args: grafana api-key create --key {} --name {} --resource-group {} --role {} --output {} --debug
cli.knack.cli: Event: CommandInvoker.OnPreArgumentLoad [<function register_global_subscription_argument..add_subscription_parameter at 0x10288d580>]
cli.azure.cli.core.azclierror: Traceback (most recent call last):
File "/opt/homebrew/Cellar/azure-cli/2.58.0/libexec/lib/python3.11/site-packages/knack/cli.py", line 233, in invoke
cmd_result = self.invocation.execute(args)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/homebrew/Cellar/azure-cli/2.58.0/libexec/lib/python3.11/site-packages/azure/cli/core/commands/init.py", line 562, in execute
self.commands_loader.load_arguments(command)
File "/opt/homebrew/Cellar/azure-cli/2.58.0/libexec/lib/python3.11/site-packages/azure/cli/core/init.py", line 522, in load_arguments
loader.load_arguments(command)  # this adds entries to the argument registries
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/a.eimer/.azure/cliextensions/amg/azext_amg/init.py", line 28, in load_arguments
load_arguments(self, command)
File "/Users/a.eimer/.azure/cliextensions/amg/azext_amg/_params.py", line 14, in load_arguments
from azure.mgmt.dashboard.models import ZoneRedundancy
ModuleNotFoundError: No module named 'azure.mgmt.dashboard'
cli.azure.cli.core.azclierror: The command failed with an unexpected error. Here is the traceback:
az_command_data_logger: The command failed with an unexpected error. Here is the traceback:
cli.azure.cli.core.azclierror: No module named 'azure.mgmt.dashboard'
Traceback (most recent call last):
File "/opt/homebrew/Cellar/azure-cli/2.58.0/libexec/lib/python3.11/site-packages/knack/cli.py", line 233, in invoke
cmd_result = self.invocation.execute(args)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/homebrew/Cellar/azure-cli/2.58.0/libexec/lib/python3.11/site-packages/azure/cli/core/commands/init.py", line 562, in execute
self.commands_loader.load_arguments(command)
File "/opt/homebrew/Cellar/azure-cli/2.58.0/libexec/lib/python3.11/site-packages/azure/cli/core/init.py", line 522, in load_arguments
loader.load_arguments(command)  # this adds entries to the argument registries
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/a.eimer/.azure/cliextensions/amg/azext_amg/init.py", line 28, in load_arguments
load_arguments(self, command)
File "/Users/a.eimer/.azure/cliextensions/amg/azext_amg/_params.py", line 14, in load_arguments
from azure.mgmt.dashboard.models import ZoneRedundancy
ModuleNotFoundError: No module named 'azure.mgmt.dashboard'
az_command_data_logger: No module named 'azure.mgmt.dashboard'
Traceback (most recent call last):
File "/opt/homebrew/Cellar/azure-cli/2.58.0/libexec/lib/python3.11/site-packages/knack/cli.py", line 233, in invoke
cmd_result = self.invocation.execute(args)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/homebrew/Cellar/azure-cli/2.58.0/libexec/lib/python3.11/site-packages/azure/cli/core/commands/init.py", line 562, in execute
self.commands_loader.load_arguments(command)
File "/opt/homebrew/Cellar/azure-cli/2.58.0/libexec/lib/python3.11/site-packages/azure/cli/core/init.py", line 522, in load_arguments
loader.load_arguments(command)  # this adds entries to the argument registries
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/a.eimer/.azure/cliextensions/amg/azext_amg/init.py", line 28, in load_arguments
load_arguments(self, command)
File "/Users/a.eimer/.azure/cliextensions/amg/azext_amg/_params.py", line 14, in load_arguments
from azure.mgmt.dashboard.models import ZoneRedundancy
ModuleNotFoundError: No module named 'azure.mgmt.dashboard'
To check existing issues, please visit: https://github.com/Azure/azure-cli/issues
cli.knack.cli: Event: Cli.PostExecute [<function AzCliLogging.deinit_cmd_metadata_logging at 0x10285ed40>]
az_command_data_logger: exit code: 1
cli.main: Command ran in 0.198 seconds (init: 0.091, invoke: 0.107)
telemetry.main: Begin splitting cli events and extra events, total events: 1
telemetry.client: Accumulated 0 events. Flush the clients.
telemetry.main: Finish splitting cli events and extra events, cli events: 1
telemetry.save: Save telemetry record of length 7578 in cache
telemetry.main: Begin creating telemetry upload process.
telemetry.process: Creating upload process: "/opt/homebrew/Cellar/azure-cli/2.58.0/libexec/bin/python /opt/homebrew/Cellar/azure-cli/2.58.0/libexec/lib/python3.11/site-packages/azure/cli/telemetry/init.py /Users/a.eimer/.azure"
telemetry.process: Return from creating process
telemetry.main: Finish creating telemetry upload process.

Environment Summary
az --version
azure-cli                         2.58.0
core                              2.58.0
telemetry                          1.1.0
Extensions:
account                            0.2.5
amg                                1.3.1
Dependencies:
msal                              1.26.0
azure-mgmt-resource             23.1.0b2
Python location '/opt/homebrew/Cellar/azure-cli/2.58.0/libexec/bin/python'
Extensions directory '/Users/a.eimer/.azure/cliextensions'
Python (Darwin) 3.11.8 (main, Feb  6 2024, 21:21:21) [Clang 15.0.0 (clang-15<IP_ADDRESS>.5)]
Legal docs and information: aka.ms/AzureCliLegal
Your CLI is up-to-date.
Additional context
No response

Looking into this now, appears to be a package import problem with Mac/homebrew.

Hi @aeimer, I've found the root cause - it's a dependency problem that's specific to Homebrew, and I'm working on getting the fix out now. In the meantime, if needed, you can unblock by not using Homebrew. I'll let you know once the fix is in.

@aeimer the newest version of the Azure CLI AMG extension (1.3.2) should fix the issue you're running into.


Add support for cursor methods

Is your feature request related to a problem? Please describe.
Allowing cursor methods like limit
Describe the solution you'd like
Changing the API signatures to support passing cursor options. For eg, changing to find method to look like this find(query, projection, options, callback)
Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Related commit: https://github.com/dappkit/aviondb/commit/8dd5f00815d67e70b80f53901479769ec303351f


Changed import from rxjs/rx to rxjs/Rx

I have changed the import to use case sensitive files. This closes #13. As there is no tests in project, I cannot say for sure, that it works, so please test it.

It works. Please update this change in npm.

Thanks for this 👍 - I'll be back on the project that I've been using this for in the next few days so I'll actually put some polish on it (tests etc.)


Feature to Download All Checked Elements at Once

Need Of Feature

Description: Currently only single element/component design could be downloaded, A download All button would provision ease of use to users.
Problem it would solve:  Downloading/ Copy pasting each files contents manually is required
Suggested Solution/ Changes: Create a Download All functionality that:

Include a Checkbox functionality that updates state of each element. (Selected or not)
Tracks Selected Items/ Elements in an array
Download Button functionality that merges all HTML, CSS & JS files of selected elements respectively.

Additional context
Array of Checked Elements to be cleared on every reload.

Features Implemented:

Maintain an Array(set) named "selected_set" that contains IDs of all the items/elements checked

Merge All HTML Codes by getting body content (via ExtractBody Method in utils dir)

Merging All HTML, CSS, JS codes seperately and storing it in "merged_strings" object(in utils/buildAll ) & called onClick of Merge Button in Elements Page

Make a single HTML file (out of merged HTML, CSS, JS) & called onClick of DownloadAll Button in Elements Page


uninitialized constant Session

I created a sample application.
Added devise in it, it works fine.
Then added cancan gem into it.
Created an ability class. define some permissions.
Then added line
load_and_authorize_resource
to the Application Controller, after that when i go to the page
http://localhost:3000/users/sign_in  it gave the following error,
NameError in Devise/sessionsController#new
uninitialized constant Session

You need to give us more information on how to reproduce this issue, otherwise there is nothing we can do. Please read CONTRIBUTING.md file for more information about creating bug reports. Thanks!

I am new in ROR , i just have 2 month of experience so i dont understand what exactly you saying to me,
but i can show you my code. is it ok for you.

@Gauravdhandre
I meet the same problem now, do you solved the problem?

heyy, how do you solved the problem???


webpack example

Hi,
thanks for this package, we've been using it a lot.
I am currently refactoring a project switching dependency management to webpack.
I see there's a whole lot of webpacking going on in the dist.
However, I cannot get this to work with require('angular-formly-material') using the latest release (0.14.1).
Error: [$injector:modulerr] Failed to instantiate module {"default":"formlyMaterial"} due to:
Error: [ng:areq] Argument 'module' is not a function, got Object

Can you help me out here and provide webpack usage instructions? Thank you.

+1

Thanks, I'm going to check it

Thanks for looking into this. Any more info I can provide?

@creimers I think that it's not commonjs compatible.
If you're using it like this:
angular.module('app', [
    require('angular-formly-material')
]);

I believe that require('angular-formly-material').default will work for you.

@kamilkisiela You are very right. Thank you! Dobranoc.

@kamilkisiela You are very right. Thank you! Dobranoc.

That's nice! :zzz: Gute Nacht
I'm going to keep it open to be aware of that commonjs issue

This works for me:
import angular from 'angular';
import formly from 'angular-formly';
import formlyMaterial from 'angular-formly-material';

angular.module('app', [
    formly,
    formlyMaterial
]);

VM17006 angular.js:68Uncaught Error: [$injector:modulerr] Failed to instantiate module app due to: Error: [$injector:modulerr] Failed to instantiate module formlyMaterial due to: Error: [$injector:modulerr] Failed to instantiate module ngMessages due to: Error: [$injector:nomod] Module 'ngMessages' is not available! You either misspelled the module name or forgot to load it. If registering a module ensure that you specify the dependencies as the second argument.
It had worked after I installed angular-message:
import angularMessages from 'angular-messages';


Update mapping.json

Docs Build status updates of commit 4a1c804:
:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Environment Variables are not sent to dependency containers

Hello
Just checking the behaviour of the plugin v4.14.0 and see if that is something that could be changed.
I have 2 docker compose files.
  config:
    - docker-compose-dependencies.yaml
    - docker-compose-test.yaml

The docker-compose-dependencies.yaml contains 2 containers that are required for the test to run. Let's call it container api and container db. These two containers will require specific environment variables. These containers are using healthchecks to make sure containers are correctly working before accessing them.
The docker-compose-test.yaml contains only the container with the test framework (let's call it tests) to test the container api. This tests container also requires specific environment variables.
It looks like the plugin kicks off the dependencies on the file docker-compose-dependencies.yaml first (containers api and db), if the flag run_dependencies is set to true, then those containers are started with a command similar to the following:
docker-compose -f docker-compose-dependencies.yaml -f docker-compose-test.yaml  -p buildkite0123... up -d --scale tests=0 tests

Later, the plugin runs the testing container in the file docker-compose-test.yaml specified in the run property. It looks like the environment variables are only passed to the container specified in the run command, similar to the following:
docker-compose -f docker-compose-dependencies.yaml -f docker-compose-test.yaml  -p buildkite0123... run --name buildkite123.... -e ENV1 -ENV2 ... --rm tests

I wonder if the environment variables cannot be propagated to the command that triggers the dependencies also. When using multiple configuration files, other containers need also configuration fed via environment variables. However, if those environment variables are not passed to the command shown above, then those container will not start correctly as some environment variables are missing, hence healthchecks fail and then the whole testing suite will fail. It would be nice if the dependencies are also fed with a command similar to the following:
docker-compose -f docker-compose-dependencies.yaml -f docker-compose-test.yaml  -p buildkite0123... -e ENV1 -e ENV2 ... up -d --scale tests=0 tests

I have tried to use the different flags to propagate environment variables, but it doesn't propagate the environment variables that I have set in the env attribute of the plugin or in the env attribute of the buildkite step command.
I have also set the property run_dependencies as false. In this case, the plugin starts all containers at the same time but only feed the environments to the container specified in the run property.
Is this the correct or expected behaviour ?
Thanks for any advice.
Tagging @toote @pzeballos as most recent contributors.

@memotoro sorry for the delay in getting back to you!
I don't think that it would be easy to add to the plugin a way to specify what environment variables should be shared with each container. Luckily, docker compose has a way to do that. Have you tried adding environment stanzas to the services themselves? That way, if the variables are available in the context they will be used by docker compose and would not need any modification of the plugin. It would also serve as documentation on your services and dependencies as to what each need :)

Hi @toote , thanks for the reply. I had the other docker-compose files with environment section per service. I also have the env section in buildkite with the definition of the ENV and values. However, that doesn't work either. It looks like with the plugin is kicking off the docker compose -f ..... up -d --scale tests=0 tests doesn't resolve ENVs defined in the env from buildkite, it only works if the environment section in the docker-compose file are hardcoded, but that defeat the purpose on some ENVs. I tried to propagate with buildkite flags but that doesn't work either. I'm using docker directly on bash for the time being, but wondering why the plugin is not passing the envs when doing the scale to 0.

@memotoro sorry for the time it took me to get back to you but unfortunately I have not been able to duplicate your issue.
I used the following composefile:
services:
  db:
    image: bash:4.2
    command: bash -c 'env; sleep 60'
    environment:
      - TEST_VARIABLE2
      - TEST_VARIABLE3
  app:
    image: ruby
    depends_on:
      - db
    environment:
      - TEST_VARIABLE

And the following step in the pipeline:
steps:
  - label: test
    command: env
    plugins:
      - docker-compose#v4.14.0:
          run: app
          config: compose.yaml
          shell: false
          upload-container-logs: always

If the agent (or pipeline) I defined the variables TEST_VARIABLE and TEST_VARIABLE3 and the output of the step was:
$ docker-compose -f compose.yaml -p buildkite018d80c7a0374967a1aaf7f14effa393 up -d --scale app=0 app
Creating network "buildkite018d80c7a0374967a1aaf7f14effa393_default" with the default driver
Creating buildkite018d80c7a0374967a1aaf7f14effa393_db_1 ... done

:docker: Running 'env' in service app
$ docker-compose -f compose.yaml -p buildkite018d80c7a0374967a1aaf7f14effa393 run --name buildkite018d80c7a0374967a1aaf7f14effa393_app_build_31 [SNIP] --rm app env
Creating buildkite018d80c7a0374967a1aaf7f14effa393_app_run ... done
PATH=/usr/local/bundle/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
HOSTNAME=b6ee35d65eb2
TERM=xterm
TEST_VARIABLE=testvalue
LANG=C.UTF-8
RUBY_MAJOR=3.2
RUBY_VERSION=3.2.2
RUBY_DOWNLOAD_SHA256=4b352d0f7ec384e332e3e44cdbfdcd5ff2d594af3c8296b5636c710975149e23
GEM_HOME=/usr/local/bundle
BUNDLE_SILENCE_ROOT_WARNING=1
BUNDLE_APP_CONFIG=/usr/local/bundle
HOME=/root

And the step had an artifact with the logs for the db dependency:
2024-02-06T23:36:31.561956162Z HOSTNAME=8d57b4ee6d15
2024-02-06T23:36:31.561987242Z _BASH_BASELINE=4.2.53
2024-02-06T23:36:31.561991873Z TEST_VARIABLE3=testvalue3
2024-02-06T23:36:31.561995257Z _BASH_BASELINE_PATCH=53
2024-02-06T23:36:31.561998408Z PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
2024-02-06T23:36:31.562002152Z PWD=/
2024-02-06T23:36:31.562005214Z _BASH_VERSION=4.2.53
2024-02-06T23:36:31.562008198Z HOME=/root
2024-02-06T23:36:31.562011533Z SHLVL=1
2024-02-06T23:36:31.562014557Z _BASH_LATEST_PATCH=53
2024-02-06T23:36:31.562017612Z _=/usr/bin/env

As you can see TEST_VARIABLE is available and correctly defined in the main container being run and TEST_VARIABLE3 in the dependency container (but not TEST_VARIABLE2 because it was not defined) despite the plugin being run with no modifications. So I am not sure why a similar setup is not working for you :(


Save as png cuts off tall images

Only as much as seen when hitting the button is saved

PNGs are scaled larger than the svg appears on screen to make the text more sharp. This can cause large blobs. Too large I guess?


fix(batcher): exceptions in unaryCaller bubble up

fixes #1826. When the BatcherImpl's unary caller throws an exception, this will bubble up to response.get()

@igorbernstein2 a friendly ping to take a look at this fix

Closing this in favor of https://github.com/googleapis/gapic-generator-java/pull/1166


latest "stable" release? Chromedriver 73 vs 74

webdrivers README says:

If you would like to use a specific (older or beta) version, you can specify it for each driver. Otherwise, the latest (stable) driver will be downloaded and passed to Selenium.

The Chromedriver home page currently says:

Latest stable release: ChromeDriver 73.0.3683.68
Latest beta release: ChromeDriver 74.0.3729.6

I can't explain how ChromeDriver versioning works, but for whatever reason they are suggesting 74.0 is "beta", and 73.0 is "latest stable".
However, in the error message I have for a failing capybara test on travis, it's telling me:

Driver info: chromedriver=74.0.3729.6

Could webdrivers be downloading 74 instead of 73? Ought it to be downloading 73 instead?
If I hadn't had that version printed out in an error... I'm not sure how to tell what version of chromedriver is being used, after being pulled by webdrivers.

Nevermind. After more research, I see webdrivers will download a chromedriver version that matches the chrome version.
My chrome version is being installed/provided by travis. And sometime today it switched from 73.0 to 74.0. And indeed there's a chrome blog post saying 74.0 was promoted to "stable" today.
So that happened. I guess chromedrivers web page just isn't up to date.
Now to figure out, though, how the heck to get 74 on my MacOS desktop so I can duplicate the failures on travis, hmm.


Lg/contract pallet tutorial fixes

[X] Are the audience and objective of the document clear? E.g. a document for developers that should teach them about transaction fees.
[x] Is the writing: (it's a step in the right direction

[-] Clear: No jargon.
[-] Precise: No ambiguous meanings.
[-] Concise: Free of superfluous detail.

[-] Does it follow our style guide?
[ N/A] If this is a new page, does the PR include the appropriate infrastructure, e.g. adding the page to a sidebar?
[-] Build the page ($ cd website && yarn start). Does it render properly? E.g. no funny lists or formatting.
[ ] Do links go to rustdocs or devhub articles rather than code? (I didn't test all of the links)
[X] If this PR addresses errors reported on Element

Sorry @sacha-l I snuck in #1131 and accidentally reverted your FRAME v2 stuff. I will open a new PR to patch that

Oh no.. You should be able to cherry pick my commit. 😬 🙏🏻


unable to load bundled gems from github

Any gems referred to in your Rails Gemfile that are located using git://<gitpath> will prevent your app from loading via Pow.    bundle install run in app directory succeeds without errors.
Bundler::GitError: git://<gitpath> is not checked out.  Pow looks so simple and when it comes to use it with ruby192/rvm, some kinda depends on your luck. Something always comes up!! Phew!!!

Reminding Sam about #236


fix(subscriber): don't unsubscribe self

Description:
This PR fixes a problem that was introduced in #3963 and was partially fixed in #4072.
The problem was introduced with this change - to Subscriber - in #3963 where a parent subscription is unsubscribed upon a complete notification:
complete(): void {
  if (!this.isStopped) {
    this.isStopped = true;
    this._complete();
+   this._unsubscribeParentSubscription();
  }
}

The parent subscription is added to the subscriber in Observable.subscribe:
const sink = toSubscriber(observerOrNext, error, complete);

if (operator) {
  operator.call(sink, this.source);
} else {
  sink._addParentTeardownLogic(
    this.source || (config.useDeprecatedSynchronousErrorHandling && !sink.syncErrorThrowable) ?
    this._subscribe(sink) :
    this._trySubscribe(sink)
  );
}

In numerous situations, the subscription passed to _addParentTeardownLogic will be the same subscriber. That is, it will be sink.
Adding sink to itself, as a parent, introduces a bug, as sink will be unsubscribed from within the complete method - which differs from the pre-#3963 mechanism.
#4072 introduced a check to ensure that a specific subscriber isn't added to itself as a parent. However, it's still possible for a subscriber that is a child of the specific subscriber to be added as a parent. And doing so will see the specific subscriber's unsubscribe called within its complete method - which can effect unwanted behaviour. See the failing test that's included in this PR.
This PR solves the problem by adding a _keepAliveCount that's incremented before unsubscribing the parent subscription and is decremented afterwards. In Subscription.unsubscribe, if _keepAliveCount is greater than zero, the subscription is not unsubscribed.
Related issue (if exists): #4095

Thank you for bringing this issue to my attention. Taking a step back, I think that _addParentTeardownLogic is probably a smell, and we likely just wanted to this.add(trustedSubscriber) on this line

@benlesh This PR is now a WIP, as I've made some changes to make things simpler, but the changes need to be applied to many of the operator-specific subscribers and I've only changed MergeMapSubscriber, so far.
I've removed all of the parent-teardown business and the _keepAliveCount.
The _addParentTeardownLogic function is still there - as a noop - as its used in isTrustedSubscriber and I'm not sure that you'll want to do with that if _addParentTeardownLogic is no longer needed.
Anyway, the important parts are in MergeMapSubscriber's _innerSub function, where the inner subscription is added to the destination (which should always be a trusted subscriber). And in its _complete function, where this.unsubscribe() is called.
To me this is simpler than dealing with children, parents and destinations. In the original implementation - that preceded the PR that sought to address the not-unsubscribing-from-source problem - a subscription was added to its destination so that unsubscribing the destination unsubscribes the subscription. That behaviour is now restored. And because the subscription's destination is not added to the subscription, calling this.unsubscribe() in _complete does not unsubscribe the destination - or any inner observables that were added to it.
If you think this approach is a better way to go, I can apply similar changes to the other subscribers. (It's not just the flattening subscribers. E.g. the subscribers for delay and delayWhen will need to be changed, too.)
We would need to decide the best way of adding subscriptions to the destination, as the type assertions are rather ugly:
const destination = this.destination as any as Subscription;

@benlesh This should be done, now.

@cartant I think we should schedule a time to walk through this one.

What follows are notes on the history of changes made in this PR.
#3963 (which was a refactoring of #2457) made changes to the way in which subscribers were wired up. The changes were made so that teardown logic for sources was called as soon as sources completed or errored.
Its changes were:

Instead of just adding a subscriber to its destination, it was added using a new method: _addParentTeardownLogic.
In Observable.prototype.subscribe, the result from _trySubscribe was also added using _addParentTeardownLogic.
When complete or error notifications occurred, subscribers would unsubscribe the teardown login added via _addParentTeardownLogic.

The major problem with this approach was that a subscriber could be added to itself, as _trySubscribe can return the subscriber that's passed to it.
This PR added a test that included this code:
const wrapped = new Observable<number>(subscriber => {
    const subscription = timer(0, asapScheduler).subscribe(subscriber);
    return () => subscription.unsubscribe();
});
wrapped.pipe(
  mergeMap(() => timer(0, asapScheduler))
).subscribe({
  next(value) { results.push(value); },
  complete() { results.push('done'); }
});

When run with the changes in #3963, the sequence of subscribers/subscriptions was:
construct Subscription@1
construct Subscriber@2
construct SafeSubscriber@3
construct MergeMapSubscriber@4
add MergeMapSubscriber@4 to Subscriber@2
construct AsapAction@5
add AsapAction@1 to MergeMapSubscriber@4
construct Subscription@6
add Subscription@6 to MergeMapSubscriber@4
next MergeMapSubscriber@4
construct InnerSubscriber@7
add InnerSubscriber@7 to MergeMapSubscriber@4 <--
construct AsapAction@8
add AsapAction@2 to InnerSubscriber@7
complete MergeMapSubscriber@4
unsubscribe Subscription@6
unsubscribe MergeMapSubscriber@4
unsubscribe AsapAction@1
unsubscribe InnerSubscriber@7
unsubscribe AsapAction@2

Note that the InnerSubscriber was added to the MergeMapSubscriber. That means that the InnerSubscriber was unsubscribed when the MergeMapSubscriber was unsubscribed. And that was happen when the source - the wrapped observable - completed.
This PR reverted the changes in #3963 and made the following changes to a number of operators:

Inner subscribers are now added to the destination subscriber.
Outer subscribers now unsubscribe upon complete and error, with their inner subscribers remaining subscribed due to their having been added to the destination.

With these changes, the test now passes and the sequence of subscribers/subscriptions is:
construct Subscription@1
construct Subscriber@2
construct SafeSubscriber@3
construct MergeMapSubscriber@4
add MergeMapSubscriber@4 to Subscriber@2
construct AsapAction@5
add AsapAction@1 to MergeMapSubscriber@4
construct Subscription@6
add Subscription@6 to MergeMapSubscriber@4
next MergeMapSubscriber@4
construct InnerSubscriber@7
add InnerSubscriber@7 to Subscriber@2 <--
construct AsapAction@8
add AsapAction@2 to InnerSubscriber@7
complete MergeMapSubscriber@4
unsubscribe MergeMapSubscriber@4
unsubscribe AsapAction@1
unsubscribe Subscription@6
next InnerSubscriber@7
next Subscriber@2
complete InnerSubscriber@7
complete Subscriber@2
unsubscribe SafeSubscriber@3
unsubscribe Subscriber@2
unsubscribe InnerSubscriber@7
unsubscribe AsapAction@2

Note that the InnerSubscriber is now added to the destination Subscriber and the is not unsubscribed upon completion of the source. And is able to next its value, etc.
The changes in this PR affected a number of behaviour tests in observeOn-spec.ts and in switch-spec.ts because adding the inner subscibers to the destination changed the subscription counts that those tests were checking.


[NavigationExperimental] Scene remonted at route change

I'm currently using:

Android 6.0.1
RN 0.26.1
react-native-router-flux 3.26.1

This issue has already been signaled in several places (https://github.com/aksonov/react-native-router-flux/issues/489, https://github.com/lelandrichardson/react-native-maps/issues/207).
It seems that scenes are remounted on top of each other when navigating back to them. In my app, it's especially visible on a Scene where I have a fullscreen MapView (see screenshot bellow).
It's obviously very heavy, my component resubscribes to eventListners etc...

@ericvicenti: hi Eric! Sorry for bringing this up, but is it a known issue on your side? It really breaks my app by flooding the memory. Also, I'm not sure why the behavior is different with the MapView. It's like the animation stops too soon, leaving the component above the previous one. And if I try to pan, the gesture is handled by the "most behind" component only.

See the discussion here. These issues were addressed in ericvicenti/navigation-rfc#61. You should upgrade to v0.28.0-rc.0.

@jmurzy Thanks a lot! Great to have some news about that.

@facebook-github-bot answered


new: fsconfig support

What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area driver-kmod
/area driver-bpf
/area driver-modern-bpf
/area libscap
/area tests
Does this PR require a change in the driver versions?
/version driver-SCHEMA-version-minor
That was already bumped since last release.
What this PR does / why we need it:
See #605
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
In both 3 drivers implementation, it was chosen to return empty params for user-provided pointers in case of failure, to avoid reading out of bounds data.
Moreover, we chose to split up 4th param in 2:

value_bytebuf
value_charbuf

because it has different meaning in different situation (see https://elixir.bootlin.com/linux/latest/source/fs/fsopen.c#L314).
There is no need for any userspace parser, because at the moment we haven't got support for filesystem related FD flags/informations.
Does this PR introduce a user-facing change?:
new: add support for fsconfig syscall

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/milestone 3.0.0+driver

I also wonder if this event is (or should be) compatible with extraction fields such as: evt.buffer, evt.buflen, evt.is_io, evt.res, fd.*

@jasondellaluce
evt.is_io and evt.res  filterchecks should work out of the box.
I am currently investigating evt.buf*" ones ;)   Regarding fd.ones, i am not sure we are able to extract anything considering that we are not yet catchingfsopenorfspick` syscalls, that actually generate the FileSystem FD.

So, to make it work with evt.buffer we'd need to rename value_bytebuf param to data:
const char* resolved_argstr;
const char* argstr;
argstr = evt->get_param_value_str("data", &resolved_argstr, m_inspector->get_buffer_format());
*len = evt->m_rawbuf_str_len;
return (uint8_t*)argstr;

TBH i don't think we really need it, because one can just use evt.arg[3] at that point.
Moreover, buflen instead needs an fdinfo:
if(evt->m_fdinfo && evt->get_category() & EC_IO_BASE)
{
	return extract_buflen(evt, len);
}

that we won't have, as said before, until we do not support fsopen or fspick.

Note: i'd love to push for fspick and fsopen syscalls too, but given the time constraints for the release, i'd avoid adding more new low-level driver code now.

TBH i don't think we really need it, because one can just use evt.arg[3] at that point.
Sounds good then!

LGTM label has been added.  Git tree hash: 5e9cf7f54a728cbfda52bca41cfe68a886fa6136

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, leogr, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,LucaGuerra,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 95f68d6de10c3c1df0474a81f28b33a0193e6f70

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, leogr, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,LucaGuerra,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 72c1606334d100fe50ce89a973f3d12bcc99963f

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Remove GENERATE_SOURCEMAP=false after issue is merged

Remove the mentioned variable from package.json when the issue https://github.com/facebook/create-react-app/pull/11752 is merged and released.

Closing because I did not upgrade react-scripts to 5.0 yet


Hello, I would like to know the equipment and time required to reproduce this code

Hello, I would like to know the equipment and time required to reproduce this code

Hi @PanYuQi66666666,
Our experiments have been conducted on 4x Nvidia custom Ampere A100 GPU 64GB. Using our pre-extracted features, the XE training phase takes less than 24 hours, while SCST lasts approximately 1.5/2 days.

@marcellacornia Hello, I want to know whether the offline test results are from a single model or ensemble of four models.


LSP middleware is referencing VS code types.

In order for the pylance team to reuse this:
https://github.com/microsoft/vscode-jupyter-lsp-middleware/blob/main/src/notebookConcatDocument.ts#L45
It cannot reference any VS code types.
Instead it should just use protocol types.

Partially complete. Going to chat with @heejaechang and @bschnurr about using the submission made.
Plan is to:

Fixup lsp-middleware to be direct copyable by pylance
Move that piece to a separate npm module
Have lsp-middleware and pylance just use that separate module

Completed this yesterday with:

https://github.com/microsoft/vscode-jupyter-lsp-middleware/commit/a9a4e7b0a25edab2cab106133cc121eb6462c1d3
https://github.com/microsoft/lsp-notebook-concat/commit/d9bdf6af3960cda22e155f822a90649c1b58a403
https://github.com/microsoft/lsp-notebook-concat/commit/d9bdf6af3960cda22e155f822a90649c1b58a403

To verify:

Open notebooks and ensure colorization works
Ensure autocomplete and hover work
Open Interactive window and ensure completion works in input box
Ensure hover works in expanded code (if you expand cells after they're run)


Fixes #15 in HHEU/hexbin with some JS hack

https://github.com/HHEU/hexbin/issues/15
Resolving this as it has to be done via this repo. Would have preferred to do it with just CSS, but not aware of a way of doing it. This trick only works if the hexbin and wiki are hosted on the same domain.

Ok, this currently doesn't fix it as the whole iframe needs to load before the height is correct.

Found http://davidjbradshaw.github.io/iframe-resizer
which is probably the best way of getting around this issue.
Need to go add one dependency to the stickers for this to work.

Ok, this should be working now.
Tested with caching disabled + with the slow 3G connection in chrome dev tools, so reasonably confident in it.

Seems to work on an emulated iPhone 6/7/8 screen size


[Bug]: Phone widget throws an undefined message when valid property field is configured

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When valid property is configured for a phone widget then the widget displays undefined text that cannot be cleared from view mode - this is not the same behaviour on other input widgets
Steps To Reproduce

Public Sample App
No response
Environment
Deploy Preview
Severity
High (Blocker to building or releasing)
Issue video log
No response
Version
cloud

@ramsaptami I am not able to repro this issue. Can you check if it is still happening? Please share reproducible steps.

I can't seem to repro this either, I'm going to close this issue @jsartisan


Fixed warnings not being logged to console

Warnings were not being logged unless there was an error in the css linting.
Fixes #23

Coverage decreased (-0.4%) to 86.111% when pulling c0c36d2f2da0736abbfb5aafaccf14c59ccb6b04 on iblack10:master into 9328ddca289577f39c97d1739b9f9d356fdafa0c on vieron:master.

Thanks for the PR @iblack10, it looks reasonable to me :) would you mind adding a fixture that would provide a warning and a test that ensures the warnings are printed?

Hope that's OK - seemed that the plugin wasn't actually carrying any warnings through from stylelint.

This will need to be rebased before merging :)

Looking at this further I think there are some problems with the tests. Test 8 should actually have zero errors but it's reporting 1. Seems like the .map function means that even if there are no errors or warnings it will return the source of the file being tested resulting in the length of the error/warning array never being zero. I'll take another look tomorrow.

I'm hopeful that's everything sorted now. Sorry there are so many commits inside of this pull request - pretty new to Github!

Thanks @iblack10 this is great so far. If there are other cases you could add with other fixtures, could you add them or let me know otherwise? I'll merge after that :)

Great, I think that's all for now - it's working well for me!

Thanks again @iblack10, I'll have the 0.3.1 release out tomorrow. Feel free to npm install stylelint-webpack-plugin#master for now, I just have a big project due tonight.
cc @vieron


Only destroy the Popper instance if it has been created

With ember-ref-modifier v1, the ref modifier operates asynchronously, so our test suite started erroring with calling destroy() on undefined because the willDestroyElement lifecycle hook makes the assumption that the Popper instance got created synchronously when the component was rendered.
I'm assuming our test suite was rendering and destroying Popper instances quickly enough in some cases where the ref modifier hadn't yet registered the popper element.
I added a similar check to what is called within the _updatePopper() method to make sure the popper instance exists before attempting to destroy it.

Published as v0.11.1!


Redis class not found in sail installation

Sail Version
1.0.1
Laravel Version
10.0.0
PHP Version
8.2
Operating System
Windows (WSL)
OS Version
Ubuntu 22.04
Description
I discovered an issue with our Laravel project during a fresh installation. When I cloned the entire project and created the env file, I proceeded to install Sail containers and the existing Composer package file by executing the following command as per the official Sail documentation:
docker run --rm \
    -u "$(id -u):$(id -g)" \
    -v "$(pwd):/var/www/html" \
    -w /var/www/html \
    laravelsail/php82-composer:latest \
    composer install --ignore-platform-reqs

After running the above command, I encountered this error message:
Generating optimized autoload files
 Illuminate\Foundation\ComposerScripts::postAutoloadDump
@php artisan package:discover --ansi

   Error

  Class "Redis" not found

  at vendor/laravel/framework/src/Illuminate/Redis/Connectors/PhpRedisConnector.php:81
     77▕      * @throws \LogicException
     78▕      */
     79▕     protected function createClient(array $config)
     80▕     {
  ➜  81▕         return tap(new Redis, function ($client) use ($config) {
     82▕             if ($client instanceof RedisFacade) {
     83▕                 throw new LogicException(
     84▕                     extension_loaded('redis')
     85▕                         ? 'Please remove or rename the Redis facade alias in your "app" configuration file in order to avoid collision with the PHP Redis extension.'

      +19 vendor frames

  20  [internal]:0
      Illuminate\Foundation\Application::Illuminate\Foundation\{closure}(Object(Laravel\Telescope\TelescopeServiceProvider))
      +5 vendor frames

  26  artisan:35
      Illuminate\Foundation\Console\Kernel::handle(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))

Script @php artisan package:discover --ansi handling the post-autoload-dump event returned with error code 1

I suspect that laravelsail/phpxx-composer image does not have the Redis extension installed, but I'm unsure how to address this issue.
This is very similar to this issue #302 but as you can see no problem with my php version or something..
Steps To Reproduce
It is just a regular Laravel project with Queue and Cache enabled, using the phpredis driver.
The config file:
https://gist.github.com/DavoodGhanbarpour/3dae9bba1459ca9692f743290bc0c970

Seems you're running a very old version of Sail. Please upgrade and try from a fresh install/image.


⚠ pan-serv00 has degraded performance

In 6ba8449, pan-serv00 (https://cloud.010702.xyz/) experienced degraded performance:

HTTP code: 200
Response time: 14240 ms

Resolved: pan-serv00 performance has improved in 532d1c0 after 8 minutes.


Update starknet_getEvents to conform spec v0.3.0

Fixes #804

I think the tests need to have pointers turned into values as well (per the last commit).

I believe I did that wherever necessary. Can you point out which ones I missed?

Also, should we update RegisterMethod to check for pointers? Could be done in a separate PR as well.

I think the tests need to have pointers turned into values as well (per the last commit).

I believe I did that wherever necessary. Can you point out which ones I missed?

I think there are some in server_test.go.

Also, should we update RegisterMethod to check for pointers? Could be done in a separate PR as well.

We are not deprecating pointer arguments, they are still useful for optional arguments.

Rebased

IIUC, the purpose of the second commit is to ensure the args passed to param field in JSON-RPC request are not pointers. So that nobody can pass null which we would unmarshal to nil that can lead to a panic?

IIUC, the purpose of the second commit is to ensure the args passed to param field in JSON-RPC request are not pointers. So that nobody can pass null which we would unmarshal to nil that can lead to a panic?

Yes, anything that is not optional should be a value type.


Cookie not refreshing properly

Hi,
I've recently installed this API onto a VPS for myself to listen for promotion requests. The system works fine after I input my cookie for about 12 hours, but afterwards it seems to refresh the cookie or something and that breaks the server, with the only way for me to fix it being grabbing an entire new cookie from the Roblox website. This is not preferable. I am currently using an incognito window to grab the cookie from my bot account, so no secondary logins or anything should be happening. Here's some screenshots of my dilemma.
Logging in initially:

It handles promotions for a few hours, then randomly breaks:

I need a new cookie:

How are you running the bot on your server? Are you using node server.js to keep the process running or pm2 start?

I am using a screen instance on my ubuntu machine to keep it running, using node server.js. In the final screenshot you can see an example of my setup running. The first time I ran node server.js to start the program, it works fine off that for a few hours, but then I need to go back in to the screen instance and restart it with a new cookie, even though the process is still running persistently. Should I try to install the specific software you recommended to see if that makes any difference?

You can definitely try, but it seems like a problem with your setup. I'm currently running an instance of this and have been doing so for several days. I tried a random POST method that requires authentication and it worked fine for me. Once you get the cookie from Incognito mode, you should try going ahead and closing that Incognito window.

Yeah I close it immediately after copying the cookie before even running any code. I'll try using the process manager you recommended and see if that improves the situation. Thank you for the responses!

Hi, it appears the same behavior is occurring with the process manager you recommended. Here's a screenshot of my promotion failing to complete this morning.

I'm out of ideas. :(

Hi, small update on the ongoing problem. It appears it isn't just tied to my VPS. I've been able to reproduce the same issue by cloning the repository to glitch.com and setting it all up there. Here's a screenshot.

Something that I find odd about this is that I have another API running to create developer products, and it appears to use noblox.js as a means to interact with Roblox as well. That one has been working properly for a couple weeks now. Is it possible these two APIs would somehow conflict with each other, since they are coming from the same account? Here's a link to the repo: https://github.com/GeneralScripter/Custom-Developer-Products
I'll try using a separate account and seeing if that solves anything.

It seems using a separate account for each API was the solution, for whatever reason. Thank you for your replies!


CLI: New F# app fails to run locally

Repro steps
Provide the steps required to reproduce the problem

Install generator and CLI:

npm i -g generator-azurefunctions azurefunctions

Create new F# project:

mkdir foo
cd foo
func init
func new (Pick HttpTrigger-FSharp)

Try to run function

func run MyAzureFunction
Expected behavior
Function runes without any problem
Actual behavior
Functions crashes we "nice" exception:

Stacktrace
Function had errors. See Azure WebJobs SDK dashboard for details. Instance ID is '30dccf5b-ed00-4278-afd9-c62fe17a4021'
Microsoft.Azure.WebJobs.Host.FunctionInvocationException: Exception while executing function: Functions.MyAzureFunction ---> Microsoft.CodeAnalysis.Scripting.CompilationErrorException: Script compilation failed. unknown(2,1): error FS1225: File 'C:\Users\Krzysztof\AppData\Roaming\npm\node_modules\azurefunctions\bin\FSharp.Core.optdata' not found alongside FSharp.Coreunknown(2,1): error FS229: Error opening binary file 'C:\Users\Krzysztof\AppData\Roaming\npm\node_modules\azurefunctions\bin\FSharp.Core.dll': File 'C:\Users\Krzysztof\AppData\Roaming\npm\node_modules\azurefunctions\bin\FSharp.Core.optdata' not found alongside FSharp.Coreunknown(2,1): error FS3160: Problem reading assembly 'FSharp.Core, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a': Error opening binary file 'C:\Users\Krzysztof\AppData\Roaming\npm\node_modules\azurefunctions\bin\FSharp.Core.dll': File 'C:\Users\Krzysztof\AppData\Roaming\npm\node_modules\azurefunctions\bin\FSharp.Core.optdata' not found alongside FSharp.Coreunknown(2,1): error FS73: internal error: BuildFrameworkTcImports: no successful import of C:\Users\Krzysztof\AppData\Roaming\npm\node_modules\azurefunctions\bin\FSharp.Core.dll
   at Microsoft.Azure.WebJobs.Script.Description.FSharpCompilation.EnsureAssemblyOption()
   at Microsoft.Azure.WebJobs.Script.Description.FSharpCompilation.GetEntryPointSignature(IFunctionEntryPointResolver entryPointResolver)
   at Microsoft.Azure.WebJobs.Script.Description.DotNetFunctionInvoker.<CreateFunctionTarget>d__26.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at Microsoft.Azure.WebJobs.Script.Description.DotNetFunctionInvoker.<GetFunctionTargetAsync>d__25.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at Microsoft.Azure.WebJobs.Script.Description.DotNetFunctionInvoker.<InvokeCore>d__23.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
   at Microsoft.Azure.WebJobs.Script.Description.FunctionInvokerBase.<Invoke>d__23.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Azure.WebJobs.Host.Executors.FunctionInvoker`1.<InvokeAsync>d__0.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Azure.WebJobs.Host.Executors.FunctionExecutor.<InvokeAsync>d__52.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Azure.WebJobs.Host.Executors.FunctionExecutor.<ExecuteWithWatchersAsync>d__3a.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Azure.WebJobs.Host.Executors.FunctionExecutor.<ExecuteWithLoggingAsync>d__35.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)
   at Microsoft.Azure.WebJobs.Host.Executors.FunctionExecutor.<ExecuteWithLoggingAsync>d__1a.MoveNext()
   --- End of inner exception stack trace ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.Azure.WebJobs.Host.Executors.FunctionExecutor.<ExecuteWithLoggingAsync>d__1a.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Azure.WebJobs.Host.Executors.FunctionExecutor.<TryExecuteAsync>d__2.MoveNext()

Most important part:
 FS1225: File 'C:\Users\Krzysztof\AppData\Roaming\npm\node_modules\azurefunctions\bin\FSharp.Core.optdata' not found alongside FSharp.Coreunknown(2,1): error FS229: Error opening binary file 'C:\Users\Krzysztof\AppData\Roaming\npm\node_modules\azurefunctions\bin\FSharp.Core.dll': File 'C:\Users\Krzysztof\AppData\Roaming\npm\node_modules\azurefunctions\bin\FSharp.Core.optdata' not found alongside FSharp.Core

Known workarounds
Copy sigdata and optdata manually from global system F# installation

/cc @dsyme

cc @sylvanc

I'm afraid I'm not familiar with the azurefunctions or azure-functions-cli projects.
@ahmelsayed , are you the maintainer of those projects? I ask because npm thinks you are the last one to publish them :) It looks like they need to include .optdata and .sig files for FSharp.Core.dll.

Other solution would be creating by default project.json with FSharp.Core <IP_ADDRESS>.... I think

Anyone know where the source for the azure-functions-cli  project is?  A quick search didn't find it

I didn't find either azurefunctions or azure-functions-cli. The npm link points back here.

I think there are on cli and cli2 branches....

The CLI is on the rename-cli branch. The templates are in a separate location however: https://github.com/projectkudu/generator-azurefunctions

As @lindydonna mentioned, the CLI code is here: https://github.com/Azure/azure-webjobs-sdk-script/tree/rename-cli
We're just missing what was done with the runtime to include those files and make sure they're deployed.

Got it, it's not a templates issue. I think this issue in general will be address when we automate the CLI build: https://github.com/Azure/azure-webjobs-sdk-script/issues/877

Verified this is fixed by rebasing on latest dev. Closing.


Need to tap the touchpad thrice for double click action when using combined clickable. However, Button clicks are only required to clicked twice.

Bug Description
I have a device with a touchpad (windows laptop's trackpad) along with two real buttons for left and right mouse click. I noticed that when I tried to implement double click behaviour, I actually need to tap thrice on touchpad. I can perform double click just by clicking twice the hardware buttons, but not the tap gesture on tap pad.
            .combinedClickable(
                onClick = { /* Do nothing */ },
                onDoubleClick = { toggleMaximizeRestore() },
                // Default parameter to not show ripple
                indication = null, // No ripple effect
                interactionSource = remember { MutableInteractionSource() } // Ensures no interaction feedback
            )

Initially I thought that click timing is problem but now I know it's not the time gap, rather It's just that I need to tap thrice instead of twice. In my case, when I tap thrice it works fine.
Affected platforms

Desktop (Windows)

Versions

Libraries:

Compose Multiplatform version: 1.6.0

Kotlin version: 1.9.22
OS version(s) (required for Desktop and iOS issues): Windows 11 Home
OS architecture: 64-bit
Device (model or simulator for iOS issues): Asus Tuf Gaming A15 (RTX 3060)
JDK (for desktop issues): 18 (java version 17.0.11)

To Reproduce
Steps to reproduce the behavior:

Run this code snippet:@Composable
fun BugReproduction() {
     Row(
         modifier = Modifier
             .shadow(
                 elevation = 12.dp,
                 spotColor = Color(0x40000000),
                 ambientColor = Color(0x40000000)
             )
             .fillMaxWidth()
             .height(32.dp)
             .background(color = Color(0xFFD0E3FF)) // Static background color
             .padding(start = 6.dp)
             .pointerInput(Unit) {
                 detectDragGestures { change, dragAmount ->
                     change.consume() // Consume the gesture event
                     //Do something

                 }
             }
             .combinedClickable(
                 onClick = { /* Do nothing */ },
                 onDoubleClick = { toggleMaximizeRestore() },
                 // Default parameter to not show ripple
                 indication = null, // No ripple effect
                 interactionSource = remember { MutableInteractionSource() } // Ensures no interaction feedback
             ),
      )
}
fun toggleMaximizeRestore() {
    if (isMaximized) {
        isMaximized = !isMaximized
        window.setSize(screenWidth, adjustedHeight)
        window.setLocation(0, 0)
    } else {
        isMaximized = true
        currentWindowX = startWindowLocX
        currentWindowY = startWindowLocY
        window.setSize((screenWidth / 1.125f).toInt(), (screenWidth * 9 / (16*1.125f).toInt())) // Default size when restoring
        window.setLocation(currentWindowX.value.toInt(), currentWindowY.value.toInt())
    }
}

Try double tapping on the light blue color bar, first with touchpad and then with buttons.
Just like step 2, try tapping thrice.

Expected behavior
It should be consistent for both, double tapping touchpad and clicking hardware buttons.

Hello, @Akhil-Hothi!
Have you tried to run your app on another physical device with a touchpad?
And does this issue happen in other apps on your machine as well?

Yes, I have tried it on a different Asus Laptop. Despite the laptop model being different, issue remains same as mentioned earlier in the initial post.
In this laptop model, the touchpad is little different, it doesn't have separate visible buttons/keys from outside but from inside it also has two pressable buttons for left and right click at the bottom part of the touchpad.

@igordmn most likely it's about https://github.com/JetBrains/compose-multiplatform-core/pull/1341

@igordmn most likely it's about https://github.com/JetBrains/compose-multiplatform-core/pull/1341

I investigated this, and this is just about unsuitable ViewConfiguration for touchpad.
I am experimenting with different values with different devices/OS'es now. The Android ported implementation doesn't always suit them.

How can I know when the issue is fixed?

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


add wisesight_sentiment

Add wisesight_sentiment Social media messages in Thai language with sentiment label (positive, neutral, negative, question)
Model Card:
YAML tags:
annotations_creators:

expert-generated
language_creators:
found
languages:
th
licenses:
cc0-1.0
multilinguality:
monolingual
size_categories:
10K<n<100K
source_datasets:
original
task_categories:
text-classification
task_ids:
sentiment-classification

Dataset Card for wisesight_sentiment
Table of Contents

Dataset Description

Dataset Summary
Supported Tasks
Languages

Dataset Structure

Data Instances
Data Fields
Data Splits

Dataset Creation

Curation Rationale
Source Data
Annotations
Personal and Sensitive Information

Considerations for Using the Data

Social Impact of Dataset
Discussion of Biases
Other Known Limitations

Additional Information

Dataset Curators
Licensing Information
Citation Information

Dataset Description

Homepage: https://github.com/PyThaiNLP/wisesight-sentiment
Repository: https://github.com/PyThaiNLP/wisesight-sentiment
Paper:
Leaderboard: https://www.kaggle.com/c/wisesight-sentiment/
Point of Contact: https://github.com/PyThaiNLP/

Dataset Summary
Wisesight Sentiment Corpus: Social media messages in Thai language with sentiment label (positive, neutral, negative, question)

Released to public domain under Creative Commons Zero v1.0 Universal license.
Labels: {"pos": 0, "neu": 1, "neg": 2, "q": 3}
Size: 26,737 messages
Language: Central Thai
Style: Informal and conversational. With some news headlines and advertisement.
Time period: Around 2016 to early 2019. With small amount from other period.
Domains: Mixed. Majority are consumer products and services (restaurants, cosmetics, drinks, car, hotels), with some current affairs.
Privacy:

Only messages that made available to the public on the internet (websites, blogs, social network sites).
For Facebook, this means the public comments (everyone can see) that made on a public page.
Private/protected messages and messages in groups, chat, and inbox are not included.

Alternations and modifications:

Keep in mind that this corpus does not statistically represent anything in the language register.
Large amount of messages are not in their original form. Personal data are removed or masked.
Duplicated, leading, and trailing whitespaces are removed. Other punctuations, symbols, and emojis are kept intact.
(Mis)spellings are kept intact.
Messages longer than 2,000 characters are removed.
Long non-Thai messages are removed. Duplicated message (exact match) are removed.

More characteristics of the data can be explore this notebook

Supported Tasks and Leaderboards
Sentiment analysis / Kaggle Leaderboard
Languages
Thai
Dataset Structure
Data Instances
{'category': 'pos', 'texts': 'น่าสนนน'}
{'category': 'neu', 'texts': 'ครับ #phithanbkk'}
{'category': 'neg', 'texts': 'ซื้อแต่ผ้าอนามัยแบบเย็นมาค่ะ แบบว่าอีห่ากูนอนไม่ได้'}
{'category': 'q', 'texts': 'มีแอลกอฮอลมั้ยคะ'}

Data Fields

texts: texts
category: sentiment of texts ranging from pos (positive; 0), neu (neutral; 1), neg (negative; 2) and q (question; 3)

Data Splits

train
valid
test

# samples
21628
2404
2671

# neu
11795
1291
1453

# neg
5491
637
683

# pos
3866
434
478

# q
476
42
57

avg words
27.21
27.18
27.12

avg chars
89.82
89.50
90.36

Dataset Creation
Curation Rationale
Originally, the dataset was conceived for the In-class Kaggle Competition at Chulalongkorn university by Ekapol Chuangsuwanich (Faculty of Engineering, Chulalongkorn University). It has since become one of the  benchmarks for sentiment analysis in Thai.
Source Data
Initial Data Collection and Normalization

Style: Informal and conversational. With some news headlines and advertisement.
Time period: Around 2016 to early 2019. With small amount from other period.
Domains: Mixed. Majority are consumer products and services (restaurants, cosmetics, drinks, car, hotels), with some current affairs.
Privacy:

Only messages that made available to the public on the internet (websites, blogs, social network sites).
For Facebook, this means the public comments (everyone can see) that made on a public page.
Private/protected messages and messages in groups, chat, and inbox are not included.
Usernames and non-public figure names are removed
Phone numbers are masked (e.g.<PHONE_NUMBER>, 09-9999-9999, 0-2222-2222)
If you see any personal data still remain in the set, please tell us - so we can remove them.

Alternations and modifications:

Keep in mind that this corpus does not statistically represent anything in the language register.
Large amount of messages are not in their original form. Personal data are removed or masked.
Duplicated, leading, and trailing whitespaces are removed. Other punctuations, symbols, and emojis are kept intact.
(Mis)spellings are kept intact.
Messages longer than 2,000 characters are removed.
Long non-Thai messages are removed. Duplicated message (exact match) are removed.

Who are the source language producers?
Social media users in Thailand
Annotations
Annotation process

Sentiment values are assigned by human annotators.
A human annotator put his/her best effort to assign just one label, out of four, to a message.
Agreement, enjoyment, and satisfaction are positive. Disagreement, sadness, and disappointment are negative.
Showing interest in a topic or in a product is counted as positive. In this sense, a question about a particular product could has a positive sentiment value, if it shows the interest in the product.
Saying that other product or service is better is counted as negative.
General information or news title tend to be counted as neutral.

Who are the annotators?
Outsourced annotators hired by Wisesight (Thailand) Co., Ltd.
Personal and Sensitive Information

We trying to exclude any known personally identifiable information from this data set.
Usernames and non-public figure names are removed
Phone numbers are masked (e.g.<PHONE_NUMBER>, 09-9999-9999, 0-2222-2222)
If you see any personal data still remain in the set, please tell us - so we can remove them.

Considerations for Using the Data
Social Impact of Dataset

wisesight_sentiment is the first and one of the few open datasets for sentiment analysis of social media data in Thai
There are risks of personal information that escape the anonymization process

Discussion of Biases

A message can be ambiguous. When possible, the judgement will be based solely on the text itself.

In some situation, like when the context is missing, the annotator may have to rely on his/her own world knowledge and just guess.
In some cases, the human annotator may have an access to the message's context, like an image. These additional information are not included as part of this corpus.

Other Known Limitations

The labels are imbalanced; over half of the texts are neu (neutral) whereas there are very few q (question).
Misspellings in social media texts make word tokenization process for Thai difficult, thus impacting the model performance

Additional Information
Dataset Curators
Thanks PyThaiNLP community, Kitsuchart Pasupa (Faculty of Information Technology, King Mongkut's Institute of Technology Ladkrabang), and Ekapol Chuangsuwanich (Faculty of Engineering, Chulalongkorn University) for advice. The original Kaggle competition, using the first version of this corpus, can be found at https://www.kaggle.com/c/wisesight-sentiment/
Licensing Information

If applicable, copyright of each message content belongs to the original poster.
Annotation data (labels) are released to public domain.
Wisesight (Thailand) Co., Ltd. helps facilitate the annotation, but does not necessarily agree upon the labels made by the human annotators. This annotation is for research purpose and does not reflect the professional work that Wisesight has been done for its customers.
The human annotator does not necessarily agree or disagree with the message. Likewise, the label he/she made to the message does not necessarily reflect his/her personal view towards the message.

Citation Information
Please cite the following if you make use of the dataset:
Arthit Suriyawongkul, Ekapol Chuangsuwanich, Pattarawat Chormai, and Charin Polpanumas. 2019. PyThaiNLP/wisesight-sentiment: First release. September.
BibTeX:
@software{bact_2019_3457447,
  author       = {Suriyawongkul, Arthit and
                  Chuangsuwanich, Ekapol and
                  Chormai, Pattarawat and
                  Polpanumas, Charin},
  title        = {PyThaiNLP/wisesight-sentiment: First release},
  month        = sep,
  year         = 2019,
  publisher    = {Zenodo},
  version      = {v1.0},
  doi          = {10.5281/zenodo.3457447},
  url          = {https://doi.org/10.5281/zenodo.3457447}
}

@lhoestq Thanks, Quentin. Removed the .ipynb_checkpoints and edited the README.md. The tests are failing because of other dataets. I'm figuring out why since the commits only have changes on wisesight_sentiment
FAILED tests/test_dataset_common.py::RemoteDatasetTest::test_builder_class_flue
FAILED tests/test_dataset_common.py::RemoteDatasetTest::test_builder_class_norwegian_ner
FAILED tests/test_dataset_common.py::RemoteDatasetTest::test_builder_configs_flue
FAILED tests/test_dataset_common.py::RemoteDatasetTest::test_builder_configs_norwegian_ner
FAILED tests/test_dataset_common.py::RemoteDatasetTest::test_load_dataset_flue
FAILED tests/test_dataset_common.py::RemoteDatasetTest::test_load_dataset_norwegian_ner
FAILED tests/test_dataset_common.py::RemoteDatasetTest::test_load_dataset_xglue

@cstorm125 I really like the dataset and dataset card but there seems to have been a rebase issue at some point since it's now changing 140 files :D
Could you rebase from master?

I think it might be faster to close and reopen.

To be continued on: https://github.com/huggingface/datasets/pull/981


Is there anyway to get which completion item is chosen by the user?

Hello, I am developing an auto-completion extension. I want to get some statistics for my completion extension. For example, when the user chooses a completion item, an event is fired with recording the index of chosen completion item. Does vscode's api provide anyway to record this?
Thank you!

@jrieken Can you take a look of this?

Yes - check out CompletionItem#command which is executed whenever a completion is inserted


fix zero division error

Fix zero division error on Gibbs sampling from learned network:
Traceback (most recent call last):
  File "../scripts/infer_network.py", line 57, in <module>
    "class": "tea"})
  File "../scripts/infer_network.py", line 49, in infer
    result = agg.aggregate(cpd.gibbssample(evidence, self.sample_num)[burn_in:])
  File "/usr/local/lib/python2.7/dist-packages/libpgm/tablecpdfactorization.py", line 432, in gibbssample
    seq.append(next(copy))
  File "/usr/local/lib/python2.7/dist-packages/libpgm/tablecpdfactorization.py", line 407, in next
    relevantfactors[0].vals[x] /= summ
ZeroDivisionError: float division by zero

@furushchev - Can you explain the rationale behind silently ignoring a divisor of zero rather than allowing the code to throw an exception?


new chart specifies image that requires auth to access (or does not exist)

Describe the bug
new chart default values pull from a repo that requires auth
To Reproduce
Steps to reproduce the behavior:

Install default chart.
note image uri for action controller:
actions-runner-controller/actions-runner-controller:v0.19.0
vs old
summerwind/actions-runner-controller:v0.19.0
note:

❯ kubectl get pods -n actions-runner-system
NAME                                        READY   STATUS             RESTARTS   AGE
actions-runner-controller-746b956bd-8ghxp   1/2     ImagePullBackOff   0          25m

and from describe:
  Warning  Failed       25m (x3 over 26m)    kubelet            Failed to pull image "actions-runner-controller/actions-runner-controller:v0.19.0": rpc error: code = Unknown desc = Error response from daemon: pull access denied for actions-runner-controller/actions-runner-controller, repository does not exist or may require 'docker login': denied: requested access to the resource is denied

attempt to pull new image actions-runner-controller/actions-runner-controller:v0.19.0 without credentials

❯ docker pull actions-runner-controller/actions-runner-controller:v0.19.0

Error response from daemon: pull access denied for actions-runner-controller/actions-runner-controller, repository does not exist or may require 'docker login': denied: requested access to the resource is denied

Older location works as expected:
❯ docker pull summerwind/actions-runner-controller:v0.19.0

v0.19.0: Pulling from summerwind/actions-runner-controller
5dea5ec2316d: Already exists
3f8f197f898e: Pull complete
0058164f90d9: Pull complete
Digest: sha256:46f7d937168de71bbee9767fe20296e5a569e64a7926661d7ea59423c500a5d2
Status: Downloaded newer image for summerwind/actions-runner-controller:v0.19.0
docker.io/summerwind/actions-runner-controller:v0.19.0

Expected behavior
pulling image should not require credentials
Environment (please complete the following information):

Controller Version https://github.com/actions-runner-controller/actions-runner-controller/releases/tag/actions-runner-controller-0.12.3.
Image version: 0.19
Deployment Method: Helm (via in cluster helm-controller, but behavior is not specific to that)
Helm Chart Version: 0.12.3

Workaround
explicitly specify legacy image location

@oneubauer Thanks for reporting! I'm fixing it in https://github.com/actions-runner-controller/actions-runner-controller/issues/662


Allow for multi-document processing in evaluator

Processes all PDFs within default-dataset directory rather than a specifically listed one.
Could potentially be leveraged to allow for the same on the Function App, should that be a direction be taken in the future.

@pohlchri Could you please review this when you get the chance and let me know if this is something your team would consider merging? Change shouldn't affect single document processing either, as it's just referencing the parent folder now instead of the document itself.

@audols thanks for this PR and for improving the evaluation component!


Question, can this be repurposed for other Unity games?

Just wondering if I could change some values in the source to get it to affect a different unity project.

yes it should be possible

It's probably not going to work out of the box for other games.
You would have to do some reverse engineering on the new game, find the static address of the fps limit, then modify this program to use it.


fix compilation errors in tests

With this command line:
cargo test --features="source,loader-freetype-default"

Then these errors are produced:
error[E0428]: the name `get_vertically_hinted_glyph_outline` is defined multiple times
   --> tests/tests.rs:270:1
    |
226 | pub fn get_vertically_hinted_glyph_outline() {
    | -------------------------------------------- previous definition of the value `get_vertically_hinted_glyph_outline` here
...
270 | pub fn get_vertically_hinted_glyph_outline() {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `get_vertically_hinted_glyph_outline` redefined here
    |
    = note: `get_vertically_hinted_glyph_outline` must be defined only once in the value namespace of this module

error[E0428]: the name `get_fully_hinted_glyph_outline` is defined multiple times
   --> tests/tests.rs:360:1
    |
316 | pub fn get_fully_hinted_glyph_outline() {
    | --------------------------------------- previous definition of the value `get_fully_hinted_glyph_outline` here
...
360 | pub fn get_fully_hinted_glyph_outline() {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `get_fully_hinted_glyph_outline` redefined here
    |
    = note: `get_fully_hinted_glyph_outline` must be defined only once in the value namespace of this module

This PR fixes those by adding a conditional config, so that the two compiles are exclusive to each other.

@bors-servo r+

:pushpin: Commit 0893ab9 has been approved by jdm

:hourglass: Testing commit 0893ab936326885e75ef40b8eb1ea4c715df98bb with merge 75b37025b48d9e5f778607f478c650b82e34312f...

:sunny: Test successful - checks-github
Approved by: jdm
Pushing 75b37025b48d9e5f778607f478c650b82e34312f to master...