add a new IO named DataLakeIO (#23074)

We developed  a new IO named DataLakeIO, which support beam to read data from data lake (delta, iceberg, hudi), and write data to data lake(delta, icberg, hudi).
Because delta , iceberg and hudi does not provide enough java api to read and write, so we use spark datasouce api to read and write data in DataLakeIO. Therefore, the spark dependencies is needed.
BeamDeltaTest, BeamIcebergTest and BeamHudiTest show how to use the above features.

@kileys
@Abacn
@johnjcasey

waiting on author

First of all - thanks for your contribution!
Before proceeding to review from my side, I'd like to know if there is a design doc or similar for this IO connector? It would be very helpful to understand the goals and the implementation of this connector in advance.
Also, several notes that are worth to mention:

Please, create a new github issue for this feature.
Please, avoid merging a master branch into your feature branch. Use git rebase instead.
Run ./gradlew :sdks:java:io:datalake:check locally before pushing your changes to origin.

You can find a Beam contribution guide here: https://beam.apache.org/contribute/get-started-contributing/

First of all - thanks for your contribution!
Before proceeding to review from my side, I'd like to know if there is a design doc or similar for this IO connector? It would be very helpful to understand the goals and the implementation of this connector in advance.
Also, several notes that are worth to mention:

Please, create a new github issue for this feature.
Please, avoid merging a master branch into your feature branch. Use git rebase instead.
Run ./gradlew :sdks:java:io:datalake:check locally before pushing your changes to origin.

You can find a Beam contribution guide here: https://beam.apache.org/contribute/get-started-contributing/

Thank you for your reply! I will make my changes, and create a new github issue later.

Was there any progress on getting this IO into Beam?


PowerRename tests failing locally and on CI on master

The following PowerRename unit tests are failing locally and on CI on master.

@enricogior @muratakburak any insights on this?

Tests are passing on my machine atm.
I have first encountered such a problem a week ago. Like here, a test was failing both locally and on CI but after rerunning tests and rerunning build on CI, tests were passing on both. Did you try rerunning tests, maybe after rebuilding?
Only thing that makes me think that test results can be time dependent is the sleep(1000) call. And since this happens rarely maybe we can increase the number and see if this happens again.

@muratakburak the tests are failing far more frequently than before

Idea: files are basically named the same, lets either put them in new dir that is a GUID or name the files new GUIDs so they don't conflict

Current failures for me:

and:


How to set the cut-in, rated, cut-out wind speed in openfast

Hi. I want to do the calculation according to the parameters in the literature, but I don't know where the cut-in, rated and cut-out wind speeds are set. I think it's in the ServoDyn module, but I don't know which parameter? Would you please to tell me how to set this?

Thank you so much!

Dear @L-Ethan,
The cut-in, rated, and cut-out wind speeds are not input parameters in ServoDyn.  They may be parameters of a user-specified controller, but the baseline controller of the NREL 5-MW turbine does not make use of these values either (at least directly).  The values do determine which wind speeds you should simulate when running design load cases involving the rotor operating.
Best regards,


thread 'tpcds_logical_q64' has overflowed its stack

Describe the bug
Running cargo test fails due to:
thread 'tpcds_logical_q64' has overflowed its stack

To Reproduce
Run cargo test
Expected behavior
Test should pass
Additional context
No response

I upgraded Rust from 1.68 to 1.69 and the problem went away


Delete empty directories

Implemented the git way of handling directories which are no longer
(implicitly) referenced: Attempt to remove the directory, since we no
longer need it, but if that fails (because the directory contains
files), we leave the directory alone.
The above is done by optimistically calling rmdir(), and ignoring
the potential ENOTEMPTY (or the platform equivalent).

Thanks for the review.


Unable to create VM from shared image gallery

Azure documentation issue guidance
Thanks for opening an issue in the Azure technical documentation repository.
We use GitHub issues as the primary channel for customer and community feedback about the Azure documentation.
Creating an issue
We prefer that you create documentation feedback issues using the Feedback link on the published article - the feedback control on the doc page creates an issue that contains all the article details so you can focus on the feedback part.
You can also create a feedback issue here in the repo. If you do this, please make sure your issue lists:

[ ] The relevant Azure service or technology.
[ ] A link to the published documentation article that you have feedback about.
[ ] Clear, specific feedback that the author can act on.

Pull requests and article contributions
If you know the change that is needed in an article, we encourage you to submit the changes directly using a pull request. If the change is large, or if you want to contribute an entire article, follow these guidelines:

[ ] Don't surprise us with a big pull request or a pull request with a new article! Submit an issue that describes the details of the proposed large change or new article.
[ ] Include the service or technology area.

We'll route the issue to the appropriate content team for review and discussion.
Tech support and product feedback
If you would like to contact Microsoft about other things, such as product feedback or tech support, please review these guidelines:

If you need technical support using Azure, the paid and free support options are described here: https://azure.microsoft.com/support/options/.

Each article in the Azure technical documentation contains a product feedback button - it's best to submit product feedback directly from a relevant article. Otherwise, you can submit product feedback for most Azure products in the following product feedback forum: https://feedback.azure.com/forums/34192--general-feedback.

@bkalmanj, Thanks for leveraging Azure docs feedback channel to raise this question.
Since you have closed this thread, I presume the issue is resolved. If you have any feedback with the Azure docs' steps or suggesting some enhancements, please do share the Azure doc for which this feedback is applicable to.
From your question, it looks like you're following the steps from this doc  -
Create an Azure Shared Image Gallery using the portal, please do confirm on this.
This channel is reserved for ‘Azure docs’ feedback- for sharing doc feedback and suggesting content improvements.
For any technical questions, please post the question on Microsoft Q&A.


Fix overlap of characters' sprites over walls

Would require a more elaborate method of collision detection than one used currently.

Yea
On Mon, Dec 3, 2018, 19:28 Arnav Tiwari<EMAIL_ADDRESS>wrote:

Would require a more elaborate method of collision detection than one used
currently.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/arnav-t/Shooting-Game/issues/37, or mute the thread
https://github.com/notifications/unsubscribe-auth/ArdA7q5FRgxA6ilT3tI7dfubh621c04Fks5u1S4GgaJpZM4Y-oxd
.


test lio sam with carla with no noise pointcloud  and no imu noise

I am trying to test LIO-SAM with carla simulator https://carla.readthedocs.io/en/latest/start_introduction/ without noise point cloud and noise imu. I am trying to see the performance of LIO_SAM by adding noise and comparing the results to the basic truth.
The expected output results are to have a trajectory and a map with almost zero noise in the best case, and gradually increase the noise to see the performance of the algorithm.
Results with zero noise seem to degrade in z even with no noise presence, also when I include noise at almost zero imu there are integration problems
imuAccNoise: 1.0e-07
imuGyrNoise: 1.0e-07
imuAccBiasN: 1.0e-07
imuGyrBiasN: 1.0e-07
imuGravity: 9.80511
imuRPYWeight: 0.01
some results can be visualized here

Do your mind sharing your data and your config?


fix(Modal): modal scrollbar overflow style issue fixed

Description
Flowbite modal removes the scroll bar forever if I toggle it from Flowbite footer component.
Fixes # 761
Type of change
Please delete options that are not relevant.

[ x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
I tested this change by running the documentation site locally and toggling the Modal from the bottom works fine from my end the scrollbar doesn't remain hidden when I close the Modal
Checklist:

[x] My code follows the style guidelines of this project

My pleasure.
When we will be releasing this fix to the production ?
On Sat, 27 May 2023, 1:45 am Conner Davis, @.***> wrote:

@.**** approved this pull request.
Thank you!
—
Reply to this email directly, view it on GitHub
https://github.com/themesberg/flowbite-react/pull/769#pullrequestreview-1446931364,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMWPISEJR3JIRI4Z5EUEVF3XIEI7PANCNFSM6AAAAAAYQBPKJQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

@Alreadywinner You can use this now on<EMAIL_ADDRESS>


[Diag] Refactor DiagnosticEngine to use YAML files - Reopen

The last PR #32239 got reverted because it was causing build failures on the Windows bot.
I fixed the issue with files organization and I also fixed the issue mentioned in this comment https://github.com/apple/swift/pull/32239#issuecomment-645929646
ref #32239, #32460
cc @xedin, @compnerd, @davezarzycki

@swift-ci please test

@swift-ci please asan test

Build failed
Swift Test OS X Platform
Git Sha - 967594b8b8b77e88ae0f7eff9cc2c48c7098c011

Build failed
Swift Test Linux Platform
Git Sha - 967594b8b8b77e88ae0f7eff9cc2c48c7098c011

@swift-ci please test

@swift-ci please asan test

Build failed
Swift Test Linux Platform
Git Sha - 967594b8b8b77e88ae0f7eff9cc2c48c7098c011

Build failed
Swift Test OS X Platform
Git Sha - 967594b8b8b77e88ae0f7eff9cc2c48c7098c011

@swift-ci please smoke test Windows platform

@xedin  sorry about that. Please run tests again.

@swift-ci please test

@swift-ci please asan test

@LucianoPAlmeida Thank you! :)

Build failed
Swift Test Linux Platform
Git Sha - 559f27b05be2602bbbdf444226a285325c40ac02

Build failed
Swift Test OS X Platform
Git Sha - 559f27b05be2602bbbdf444226a285325c40ac02

@LucianoPAlmeida Can you run Windows tests too?

@swift-ci please smoke test Windows platform

It should be triggered automatically though (/cc @shahmishal)...

It did but had not updated the GitHub UI yet - https://ci-external.swift.org/job/swift-PR-windows/4488/

@swift-ci please test source compatibility release


adjust ifort floating point options

remove unknown flag "-mp"
replace by recommended flag "-fp-model"

What changes does this PR introduce?
Small update/bug fix of specific build options file
What is the current behaviour?
plenty of warnings, because "-mp" is unknown to ollie's ifort compiler
What is the new behaviour
no more warnings, proper use of -fp-model instead
Does this PR introduce a breaking change?
No
Other information:
Suggested addition to tag-index

adjust compile flags for ifort on ollie

I think we can safely merge this, as it only affects users of ollie at awi.de. Should I do it myself?

I think we can safely merge this, as it only affects users of ollie at awi.de. Should I do it myself?


don't accept transport parameters in the NewSessionTicket message

This was recently removed from the WG draft: https://github.com/quicwg/base-drafts/pull/1058.

Codecov Report

Merging #1177 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1177      +/-   ##
==========================================
- Coverage   91.09%   91.09%   -<.01%
==========================================
  Files         114      114
  Lines        7712     7710       -2
==========================================
- Hits         7025     7023       -2
  Misses        460      460
  Partials      227      227

Impacted Files
Coverage Δ

internal/handshake/tls_extension_handler_client.go
89.83% <100%> (-0.33%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d71850e...f0eb5a6. Read the comment docs.


Tutorial code example (hello-ionic.ts)

Following the tutorial, I've notice some differences.

Can you resolve the merge conflicts

Going to close since this has been addressed


Updated Xcode Extension 1.2.0 | Added "Search Developer Documentation" command

Description
An update to the Xcode Extension to version 1.2.0:

Small code cleanups and improvements
Added README.md
Added new "Search Developer Documentation" command
Updated "Manage Simulators" command: Added accessory icons for Simulator states

Type of change

Bug fix / improvement for my extension

Screencast
New "Search Developer Documentation" command

Added accessory icons to "Manage Simulators" command

Checklist

[x] I read the documentation about publishing
[x] I read the extension guidelines
[x] I checked that extension's icon has size of 512x512

Thanks for the helpful comments and merge @mattisssa ✌


bugfix: global status inconsistent when rollback and branch register …

…are concurrent on db mode

Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?

fixes #1812
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #1825 into develop will decrease coverage by <.01%.
The diff coverage is 58.33%.

@@              Coverage Diff              @@
##             develop    #1825      +/-   ##
=============================================
- Coverage      55.06%   55.05%   -0.01%
+ Complexity      2355     2353       -2
=============================================
  Files            421      421
  Lines          14264    14269       +5
  Branches        1710     1712       +2
=============================================
+ Hits            7854     7856       +2
- Misses          5682     5683       +1
- Partials         728      730       +2

Impacted Files
Coverage Δ
Complexity Δ

...rver/store/db/DatabaseTransactionStoreManager.java
67.44% <100%> (-0.26%)
22 <0> (ø)

.../java/io/seata/server/coordinator/DefaultCore.java
42.08% <16.66%> (-0.61%)
26 <0> (ø)

...in/java/io/seata/server/session/GlobalSession.java
84.54% <0%> (-0.49%)
67% <0%> (-1%)

...o/seata/server/coordinator/DefaultCoordinator.java
49.59% <0%> (-0.41%)
27% <0%> (-1%)

...server/store/file/FileTransactionStoreManager.java
60.19% <0%> (+1.31%)
29% <0%> (ø)
:arrow_down:

Dose doGlobalCommit have the same problem?


Bancontact issue when the order is partailly paid with giftcard

We are experiencing an issue with the Bancontact payment when we do a partial payment using a generic giftcard.
During the checkout, when we pay the order partially with a giftcard, and we pay the rest of the order amount using Bancontact, we are redirected to the 3DS HPP page where we have to put the user and password.

When we submit the form, it is invoked the request /Adyen-ShowConfirmation with some query string params, but with a POST method. This is throwing an internal server error because the Adyen.js controller is expecting a GET

Also the redirectResult is not in the query string which is needed to complete this type of payment

It was a problem with the merchant account configuration, I close this case.


Crash when opening Video Settings.

(1.21) [Fabric] Reese's Sodium Options 1.8.0-beta.4
crash-2024-09-23_17.30.23-client.txt
Modpack:
Mod Menu [11.0.2]
Placeholder API [2.4.1+1.21]
EntityCulling [1.7.0]
Nature's Compass [1.21-2.2.6-fabric]
FabricSkyBoxes [0.7.4+mc1.21]
Dynamic Lights [1.8.3+mod]
Searchables [1.0.5]
Polymorph [1.0.6+1.21.1]
CIT Resewn [1.2.1+1.21]
Artifacts [12.0.6]
Fabric API [0.102.0+1.21]
FallingTree [<IP_ADDRESS>]
libIPN [6.0.2]
Visuality [0.7.7+1.21]
More Culling [0.27.1]
Controlling [18.0.4]
Clumps [<IP_ADDRESS>]
Towns and Towers [1.13.2]
No Chat Reports [1.21-v2.8.0]
Coordinate List [1.7.1-1.21]
Concurrent Chunk Management Engine [0.2.0+alpha.11.109+1.21]
Nullscape [1.2.7]
Controlify [2.0.0-beta.14+1.21-fabric]
YetAnotherConfigLib [3.5.0+1.21-fabric]
Chunks Fade In [1.0.3-1.21]
ClientSort [1.0.0]
WaveyCapes [1.4.9]
Farmer's Delight [1.21-2.1.9+refabricated]
Lithium [0.13.1]
Model Gap Fix [1.21-1.6]
Nvidium [0.3.1]
Sorted Enchantments [2.0.0+1.21+fabric]
Colored Bundles [<IP_ADDRESS>]
Chunky [1.4.16]
FabricSkyBoxes Interop [1.4.0+mc1.21-build.54]
ThreadTweak [0.1.4+mc1.21]
NotEnoughAnimations [1.7.6]
Explorer's Compass [1.21-2.2.5-fabric]
Cloth Config [15.0.140]
Eating Animation [1.21+1.9.72]
FerriteCore [7.0.0]
Better Bundle [1.4.1+1.21]
Do a Barrel Roll [3.6.2+1.21]
e4mc [5.2.1]
Leather Bundles [2.1.0]
Tectonic [2.4.1a]
Entity Texture Features [6.2.5]
Architectury [13.0.6]
Continuity [3.0.0-beta.5+1.21]
Geophilic [3.1.2]
Dynamic FPS [3.7.3]
Cristel Lib [1.2.8]
Noisium [2.3.0+mc1.21-1.21.1]
Collective [7.84]
Enhanced Block Entities [0.10.2+1.21]
Sodium [0.6.0-beta.2+mc1.21.1]
CICADA [0.8.3+1.21-and-above]
ModernFix [5.19.1+mc1.21]
Sodium Extra [0.6.0-beta.3+mc1.21.1]
Polytone [1.21-2.4.15]
Villager Names [8.1]
BadOptimizations [2.1.4]
Skin Layers [1.6.7]
Falling Leaves [1.16.2]
Debugify [1.21+1.0]
Cave Dust [3.0.0]
Entity Model Features [2.2.6]
Make Bubbles Pop [0.3.0-fabric]
EpheroLib [1.2.0-1.20.6]
CreativeCore [2.12.9]
Fabric Language Kotlin [1.12.2+kotlin.2.0.20]
Just Enough Items [<IP_ADDRESS>]
Reese's Sodium Options [1.8.0-beta.4+mc1.21.1]
Animatica [0.6.1+1.21]
Very Many Players [0.2.0+beta.7.165+1.21]
Mouse Tweaks [2.26]
AppleSkin [3.0.5+mc1.21]
Trinkets [3.10.0]
ImmediatelyFast [1.2.21+1.21.1]

See https://github.com/FlashyReese/reeses-sodium-options/issues/102

thanks


make flash fails on OSX due to hwcrypto/aes.h: No such file or directory

Describe the bug
While running make flash monitor from the tutorial the procedure fails.
System information

Which hardware board or part numbers?
ESP32 WROOM-32
Operating System
OSX
Version of Amazon FreeRTOS
v1.4.7-39-ge1c0f7f7
Project
MQTT

Expected behavior
Procedure of make flash monitor show proceed.
Additional context
amazon-freertos/demos/espressif/esp32_devkitc_esp_wrover_kit/common/application_code/espressif_code/mbedtls/port/include/aes_alt.h:31:26: fatal error: hwcrypto/aes.h: No such file or directory
compilation terminated.
make[1]: *** [lib/tls/aws_tls.o] Error 1
make: *** [component-amazon-freertos-common-build] Error 2

Thank you!

Hello @mluis ,
The file should be part of your repo. Can you please verify that you have aes.h your repository here  :
lib/third_party/mcu_vendor/espressif/esp-idf/components/esp32/include/hwcrypto/aes.h ?
Thanks!

Hello @abhidixi11 ,
The file is part of the repo.
$ file lib/third_party/mcu_vendor/espressif/esp-idf/components/esp32/include/hwcrypto/aes.h
lib/third_party/mcu_vendor/espressif/esp-idf/components/esp32/include/hwcrypto/aes.h: c program text, ASCII text

Hello @mluis,
Have you tried building with the latest master branch ?
Also can you please try 'make all' and see if the build goes through.
Thanks!

Hi @abhidixi11 ,
Yes, just tried it.
[mluis@macb0x:~/research/aws/amazon-freertos/demos/espressif/esp32_devkitc_esp_wrover_kit/make]$ git pull
Already up to date.
[mluis@macb0x:~/research/aws/amazon-freertos/demos/espressif/esp32_devkitc_esp_wrover_kit/make]$ make all
Toolchain path: /Users/miguelluis/research/esp/xtensa-esp32-elf/bin/xtensa-esp32-elf-gcc
Toolchain version: crosstool-ng-1.22.0-80-g6c4433a
Compiler version: 5.2.0
Python requirements from /Users/miguelluis/research/esp/esp-idf/requirements.txt are satisfied.

CC build/amazon-freertos-common/lib/tls/aws_tls.o
In file included from /Users/miguelluis/research/aws/amazon-freertos/demos/espressif/esp32_devkitc_esp_wrover_kit/common/config_files/FreeRTOSConfig.h:40:0,
                 from /Users/miguelluis/research/aws/amazon-freertos/lib/include/FreeRTOS.h:56,
                 from /Users/miguelluis/research/aws/amazon-freertos/lib/tls/aws_tls.c:27:
/Users/miguelluis/research/esp/esp-idf/components/esp32/include/rom/ets_sys.h:1:2: warning: #warning rom/ets_sys.h is deprecated, please use esp32/rom/ets_sys.h instead [-Wcpp]
 #warning rom/ets_sys.h is deprecated, please use esp32/rom/ets_sys.h instead
  ^
In file included from /Users/miguelluis/research/aws/amazon-freertos/lib/third_party/mbedtls/include/mbedtls/aes.h:111:0,
                 from /Users/miguelluis/research/aws/amazon-freertos/lib/third_party/mbedtls/include/mbedtls/ctr_drbg.h:36,
                 from /Users/miguelluis/research/aws/amazon-freertos/lib/tls/aws_tls.c:40:
/Users/miguelluis/research/aws/amazon-freertos/demos/espressif/esp32_devkitc_esp_wrover_kit/common/application_code/espressif_code/mbedtls/port/include/aes_alt.h:31:26: fatal error: hwcrypto/aes.h: No such file or directory
compilation terminated.
make[1]: *** [lib/tls/aws_tls.o] Error 1
make: *** [component-amazon-freertos-common-build] Error 2
[mluis@macb0x:~/research/aws/amazon-freertos/demos/espressif/esp32_devkitc_esp_wrover_kit/make]$

Just tried on Linux and the problem persists...

Under linux this is my tree:
mluis@vub0x:~/esp$ tree -L 2
.
├── amazon-freertos
│   ├── CHANGELOG.md
│   ├── LICENSE
│   ├── README.md
│   ├── checksums.json
│   ├── demos
│   ├── directories.txt
│   ├── lib
│   ├── tests
│   └── tools
├── esp-idf
│   ├── CMakeLists.txt
│   ├── CONTRIBUTING.rst
│   ├── Kconfig
│   ├── LICENSE
│   ├── README.md
│   ├── add_path.sh
│   ├── components
│   ├── docs
│   ├── examples
│   ├── make
│   ├── requirements.txt
│   └── tools
└── xtensa-esp32-elf
    ├── bin
    ├── include
    ├── lib
    ├── libexec
    ├── share
    └── xtensa-esp32-elf

mluis@vub0x:~/esp$ printenv IDF_PATH
/home/mluis/esp/esp-idf

And I'm also exporting correctly, I think..
export PATH="$HOME/esp/xtensa-esp32-elf/bin:$PATH"

Hello @mluis,
OK. Can please try following commands and let me know if it builds ?
make -C /<your_root>/demos/espressif/esp32_devkitc_esp_wrover_kit/make clean
make -j4 -C /<your_root>/demos/espressif/esp32_devkitc_esp_wrover_kit/make V=1
Thanks.

Hi @abhidixi11 ,
Yes, it builds without a problem.

Cool !
Now can you please try flash ?

I'm sorry, something went wrong on the -j4... I couldn't see it at first.
$ make -j4 -C demos/espressif/esp32_devkitc_esp_wrover_kit/make V=1
......
/Users/miguelluis/research/aws/amazon-freertos/demos/espressif/esp32_devkitc_esp_wrover_kit/common/application_code/espressif_code/mbedtls/port/include/aes_alt.h:31:26: fatal error: hwcrypto/aes.h: No such file or directory
compilation terminated.
make[1]: *** [lib/tls/aws_tls.o] Error 1
make: *** [component-amazon-freertos-common-build] Error 2
make: *** Waiting for unfinished jobs....

OK then, it looks like the same problem:
aes_alt.h:31:26: fatal error: hwcrypto/aes.h: No such file or directory
Have you followed the the Getting Started Guide?
https://docs.aws.amazon.com/freertos/latest/userguide/getting_started_espressif.html
I tried it here on our build machine, and the build goes through.
If the problem persists for you,  we will investigate it  next week.
Thanks.

Yes, that's the guide I'm following.
I'm on the make flash monitor part.

OK.  We'll try to see what's going wrong on Monday.
Thanks for your patience!

Wich esp-idf git repo hash are you using? Currently I'm on latest master.

Hello @mluis ,
Can you please check if IDF_PATH is set somewhere in your source tree?  If it is, it will not point to lib/third_party/mcu_vendor/espressif/esp-idf
In makefile for demos: (demos/espressif/esp32_devkitc_esp_wrover_kit/make/Makefile) we define IDF_PATH as follows:

ifndef IDF_PATH
export IDF_PATH := $(AMAZON_FREERTOS_PATH)/lib/third_party/mcu_vendor/espressif/esp-idf
endif

So if you have IDF_PATH defined somewhere else, you will start seeing compilation problems.
We are using latest master to make sure build works.
Thanks.

It seems that I had previously set the IDF_PATH so it was making the error happening.
Thank you for your support.
Best Regards


New article: added the hidden control flow

I have made a partial improvement with the help of ChatGPT and moved the company info to the author page. cc. @xtang

@Folyd Thanks for polishing!


Uploaded Lucky Emblem data table

Was there any other work to getting these working in-game? Or as simple as adding to this table?


another language

How can I translate it into another language in the game?

The language is handled by game client, which is independent of the launcher.
There is nothing that the launcher can do, since it is working as intended.


[BUG] In mobile view the community links cards are not looking good

Describe the bug
🔨Installation Guide
In each card the text and icon should be in a row but they are in a column. I think we should fix them as soon as we can.
Kindly assign this issue to me so that I can fix this.
To Reproduce
Set the display to flex
Expected Behavior
The text and icon should be in a row
Screenshot/ Video

Code of Conduct

[x] I agree to follow this project's Code of Conduct

@hustlerZzZ hey are you working on this issue?

@hustlerZzZ hey are you working on this issue?

It's causing some errors I am fixing them. It's showing white screen only. I will try to fix it otherwise I will let you know.
Thanks and regards

@hustlerZzZ hey are you working on this issue?

It's causing some errors I am fixing them. It's showing white screen only. I will try to fix it otherwise I will let you know. Thanks and regards

try different browser

Hey @hustlerZzZ, are u working on this issue

Hey @hustlerZzZ, are u working on this issue

Sorry, something is wrong I am not able to work on this. Feel free to assign someone else

can I work on this issue? @kabir0x23

Worked on the issue and is fixed, have a look once at my pull request #497
@kabir0x23

Worked on the issue and is fixed, have a look once at my pull request #497 @kabir0x23

Yeah will merge it soom , just thinking about the design for mobile view


Print suggestions when requesting a nonexistent InputMap action

This should make debugging input actions a bit easier. In the future, we can extend this to get_node() errors, signal connection errors and much more. If no action name is close enough to the requested action, no suggestion will be made.
Preview
ERROR: event_get_action_status: The InputMap action "move_forwards" doesn't exist. Did you mean "move_forward"?
   At: core/input_map.cpp:241.

Note that this method is fairly slow (taking 2-5 ms to run in a debug build). Thankfully, it's only called in debug builds when the input action doesn't exist, so the impact should be minimal in a release build.
@Zylann Is there a way to optimize this? I'm not sure if putting the Comparator struct outside the function would improve the performance (to avoid creating it every time).
Edit: The method has been optimized, it takes about 100-150 µs to run now.

@Calinou Is there any update on this? This looks like it would be a great help for beginners and anyone prone to typos.

Needs a rebase, otherwise should be fine to merge.
To be fair I'm not convinced that adding such contextual info to runtime errors is really a good UX, but I guess it's better than nothing.

What if this was inside of #ifdef DEBUG_ENABLED or maybe #ifdef TOOLS_ENABLED?

To be fair I'm not convinced that adding such contextual info to runtime errors is really a good UX, but I guess it's better than nothing.

I remember someone asking on reddit why their Input.is_action_pressed("ui-left") call was not working.
I definitely think that this PR would have helped there, especially because I think such runtime errors are sometimes hard to fix.

What if this was inside of #ifdef DEBUG_ENABLED or maybe #ifdef TOOLS_ENABLED?

That shouldn't be necessary, the error macros already ignore the message if DEBUG_ENABLED is not defined. (See DEBUG_STR define.)

To be fair I'm not convinced that adding such contextual info to runtime errors is really a good UX, but I guess it's better than nothing.

I remember someone asking on reddit why their Input.is_action_pressed("ui-left") call was not working.
I definitely think that this PR would have helped there, especially because I think such runtime errors are sometimes hard to fix.
Edit: see:
https://www.reddit.com/r/godot/comments/81nnwn/having_problems_with_inputis_action_pressed/
https://www.reddit.com/r/godot/comments/ld0frp/get_action_strength_not_working/

Yeah, it's just that from those two threads it doesn't appear like those users even looked at the debugger/console, so whether the error says Request for nonexistent InputMap action 'ul_right'. or Request for nonexistent InputMap action "ul_right". Did you mean "ui_right"? will maybe not make much difference.
To me, it's clear enough if you're told that a given action name doesn't exist, that you might indeed be using an action that doesn't exist - so you check the InputMap and your code to make sure it's correct. If those two users failed to do that, they likely did not even see the error, which is a different UX problem.
All that being said, I'm fine with the change if it can help some users at least.

Yeah, it's just that from those two threads it doesn't appear like those users even looked at the errors in the debugger/console, so whether the error says Request for nonexistent InputMap action 'ul_right'. or Request for nonexistent InputMap action "ul_right". Did you mean "ui_right"? will maybe not make much difference.

I think this is the kind of error that should pause project execution and raise the editor window, similar to get_node() calls with invalid paths.

Rebased.
PS: I noticed that no error message is printed at all when using Input.is_action_pressed (it's only printed when using event.is_action_pressed). This should be addressed in a future PR.

Rebased and tested on the latest master branch.
Since the 3.x version of this PR has been merged, we should merge this one as well so I can keep working on this to make it more universal :slightly_smiling_face:

Thanks!


Allow shell style environment variable access for paths.

Is there an existing issue for this?

[X] I have searched the existing issues.

Please describe the feature you have in mind and explain what the current shortcomings are?
Currently I would like to add this path within my executables inside ayon+settings://applications/applications/blender/variants/3/executables/linux/0:
/home/$USER/opt/blender_launcher/custom/Blender_Sandbox/blender
The AYON launcher does not seem to support that.
It naturally does support this:
/home/hannah/opt/blender_launcher/custom/Blender_Sandbox/blender
How would you imagine the implementation of the feature?
I would like to be able to use environment variables in OSes that have folders on user-level to ensure the path towards the directory of the executable can be developed based per individual.
I was considering f strings but that is too risky, tokens were given as an advice instead by my mentor:
/home/{$USER}/opt/blender_launcher/custom/Blender_Sandbox/blender
That would mean the instructions given are in the back-end. Leaving it still as easy for adaptation in the current situation.
Are there any labels you wish to add?

[X] I have added the relevant labels to the enhancement request.

Describe alternatives you've considered:
No response
Additional context:
No response

@iLLiCiTiT
Should this issue be transferred to ayon-core since it has ayon_core.lib.find_executable which doesn't support template keys, e.g. {username}  ?

This is https://github.com/ynput/ayon-applications.


Document what gets resolved from a QueryBuilder

The docs could be more explicit about the value/object that gets resolved when mehods likeinsert, insertGraph, upsertGraph are called.

When we add these docs, let's make sure the typings subsequently agree with the Fine Manual.


✨ Add 'create branch from {branch}' to add to repo button

Description
Add create branch from {branch} as an option in the 'add to repo' button on writable repos.

With a little mockup, I quickly created what I thought this feature should look like:

After clicking 'create new branch', Refined GitHub should open this UI:
 and if possible, the branch should automatically be based on the branch the user was on (difficult; unnecessary)
Perhaps also change the aria-label from Add file to Add new.. or similar
Example URLs
the feature should be here:

e.g. https://github.com/RiversideValley/Emerald for me, as I have write access and can see the add files button, but for you perhaps this repo, https://github.com/refined-github/refined-github as you most likely have write access to the repo.

This is already possible with the native branch selector. Just open the selector and start typing the new name.


Feature cicd

Issue #, if available: CICD feature addition
Description of changes:

Add CI/CD pipeline cloudformation + associated buildspec file
Add .env file to manage parameters
Modify standup.sh to include deploying CICD infra & s3 bucket creation
Modify delete_resources.sh to include CICD stack
Readme - still modifying

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

+1 for merging :)


Minor clean up

Some general code improvements:

commented code removed
code alignment improved
replaced element-wise array copy with std::copy

@dvrogozh I think I addressed your requests


Consistent signposting of access offer across website and venue

Accessible iconography project

Link to feature: https://wellcomecollection.productboard.com/feature-board/planning/features/19468665


Fix: onPress Event Handling for DropdownItem

Closes #2743
Closes #2751

📝 Description
Fixed a bug that onPress was not called.
You can check it at the following link.
https://nextui-storybook-v2-79k1jdwm7-nextui-org.vercel.app/?path=/story/components-dropdown--default
https://github.com/nextui-org/nextui/assets/76232929/692dbf24-33d3-4532-89f9-8ce37d698f86
⛳ Current behavior (updates)
onPress is not working.
🚀 New behavior
onPress is work.
💣 Is this a breaking change (Yes/No):

No.
📝 Additional Information

Summary by CodeRabbit

New Features

Enhanced Dropdown Menu with multiple event handlers for better interaction feedback.

Refactor

Updated Dropdown Menu components to handle press events more explicitly and efficiently.

Chores

Cleaned up unnecessary code and imports in menu handling functions.

Fixed here https://github.com/nextui-org/nextui/pull/2746


feat: Post-processing

Details

There are two main ways to apply postprocessing.
First way is using Post-processing of built-in three.js.
Second way is using Post-processing of library
Since each has its pros and cons, I decided it would be better for the user's can be choose one of two theyself.
(Of course, can't be use mixed it.)

Built-in three.js
Post-processing of Library

SSR
v
Not yet

Bloom
v But have a background issue (https://github.com/mrdoob/three.js/issues/14104)
v

Variety
Normal
Have a variety effects

Perfomance
Normal
Expect good performance by optimizing itself

Documentation
Only basic examples exist
Have a detailed document page.

Community
A lot of discussion is taking place on its own community site.
-

And bundle sizes result. (Before / After)
 (Before)
 (After)

Thank you for your reply despite your busy :)
I agree with your opinion as have to be used more efficiently for users.
Looking back, It seems customizable for post-processing but is hard to use.
I will more think about the between Performance (by low bundle size), Easy to use and Customizable although It is hard to achieve all of them perfectly.
So I will get find the best balance through various experiments in work such as It is easy to use, It is customizable for effects, bundle size has not been stretched too big, etc...

@WoodNeck
I thought about that...
How about offing 2 APIs for users? one is only basic post-processing in View3D and the other offers customizable post-processing API.
First Api is like this as you said:
import View3D, { SSRPass, BloomPass, DoFPass } from "View3D";

view3D.addPass(new SSRPass(optionsForSSR), new DoFPass(optionsForDoF), new BloomPass(optionsForBloom));

In this case of important is, Users do not need to install THREE.JS. because of offered basic post-processing in View3D, Users be easily use post-processing.
Also, the bundle size will not get bigger because only basic post-processing is provided.
The second API is like this:
import { EffectComposer, SSRPass } from "three/~~"

or

import { EffectComposer } from "post-processing"

view3d.setEffectComposer(new EffectComposer());
view3d.setPass(({renderer, camera, scene, effectComposer, model, ...})=>{

 // This callback function is offered params that need to make for post-processing or custom post-processing.
 // So users can customize even not know inside view3D.

 const ssr = new SSRPass({renderer, scene, camera, selects: model.meshes, groundReflector: null});
 const customEffect = new ???(...);

 effectComposer.addPass(ssr, customEffect);

})

In this case, Users have to install THREE.JS or post-processing library.
Summary

Only offer basic post-processing. (SSR, DoF, Bloom, SSAO, ... ). Basic post-processing will be provided with modifications to make it easier to use.
Another is it, Provides API which allows users to freely add post-processing with post-processing library or custom post-processing. But in this case, Users have to install THREE.JS or library.
Users can use either or both as they want.

Thinking of good balance for usability, scalability, and bundle size, I came to the above conclusion.
Is there anything I missed or do you have a better idea? If not, I will work on that :)

@RudyBlack
That looks promising, you can keep up with that!
One concern is, model can be changed at any time, so the post-processing pass won't work on the new model load.
So, please add something that can refresh the selects field of the effect for the second approach.

@WoodNeck
I found some issues while I was working.
Post-processing that built-in ThreeJS is not working or something issue on using each other. For example, can't use SSR and SSAO together. and have to apply tone mapping but If using bloom together, is to appear issue. and DoF has to be the last pass index. and etc... I am worried that offering basic post-processing to users is given to confusion.
So how about just providing only an interface that can use post-processing? ( Not provide basic post-processing )
or do you have some idea?

@RudyBlack
If it's not available, I think it would be helpful enough to establish an interface for using post-processing as you say. Specifically, I don't think you need to feel like you need to support all effects at this point.
However, for the issues you mentioned, it would be good to check these things out.

Are things like not being able to use multiple effects at the same time, not being able to use tone mapping, etc. officially unsupported? If there's something that's not working well with the View3D implementation, I could look into that.
Why don't you try implementing some simple post-processing effects of your own that aren't provided by three.js, that might help us get a better idea of what's causing the issues you're describing.

@WoodNeck

Why don't you try implementing some simple post-processing effects of your own that aren't provided by three.js, that might help us get a better idea of what's causing the issues you're describing.

I have a plan to implement simple post-processing effects myself. But it looks need knowledge of custom shader, glsl, math, etc. (I am studying hard for this...) and I think it will take a long time. so It's better to go step-by-step rather than implement it all at once. I'm sorry for the confusion.
Therefore, I will only make an interface to use post-processing and then implement the basic effects in the future.

@RudyBlack

It's better to go step-by-step rather than implement it all at once.

I completely agree with that.
Just, I would like you to check two things.
First, for libraries, it's not easy to change the interface.
View3D follows Semantic Versioning, so any interface changes that might affect users would require a major version update, which we try to avoid if possible.
So you have to be very careful when writing the interface. I like your approach, so go ahead and try it out, I'll keep reviewing it.
Secondly, I think it would be difficult to use if you don't provide basic effects at the library level.
It will be difficult for users to configure their own effects, because they will have the same issues you are having now.
So if possible, it would be great if you could include at least the ones that are working now, so that I can check them out and fix the ones that aren't :)

@WoodNeck
It's kind of you to say that. Thank you very much.
It was a little hard at the same time as the company work, but I'll try as much as I can and ask for help if it really doesn't work.
So I'll keep going :)

Keep up the great work!


Yandex Browser <IP_ADDRESS>0

Hey like what you did there I was wondering about the alsa gpt3 plugin. Also do mind changing the picture of the snap?

There are still some issues with the audio, I will work on it soon and fix them. As for the snap icon, I am currently using the official image.


Show release history and allow rollback to previous revision

It would be very useful to be able to get the deployment history for a SAM application from the command line. Right now, a developer relies on git to track to know about the code history, but without full CI/CD, he/she does not have insight into SAM's release history. It would be extremely useful to have that that history. In the spirit of SAM, this should be readily accessible from the command line.
Additionally, it would be very useful to be able to roll back to a previous release as it was deployed previously. This is different than rolling back to a previous version of the code and redeploying. Rolling back would provide confidence that the roll back is to a prior working state as it was in the environment previously.

This looks really compelling. Let's see if we can hash out the details to come up a clear set of requirements and make a it a feature request :)
Can you explain your SAM usage a bit more (num Lambda functions, num repositories, frequency of deployment, num regions etc)? I know the CI/CD workflow pretty well but looks like you don't use CI/CD systems. How do you deploy to production otherwise?

I think I am in the same situation here
Basically, I have one sam template that I manually package + deploy after a build (I am in the early stage of the project, not any CI configured yet)
This template has a Stage parameter that is either Dev or Prod and which creates 2 different stacks.
For example,
Environment:
    Variables:
      DB_NAME:
        Fn::ImportValue: !Sub "${Stage}RDSInstanceDBName"
      DB_HOST:
        Fn::ImportValue: !Sub "${Stage}RDSInstanceAddress"

What I'd like is to be able to rollback to previous state of each stack (not necessarily function by function) if I see too much errors happening (the stack contains only lambda+API GW + cron)
Any idea how I can achieve that ?

@christopheblin
I've just wrapped up a project where we implemented CI/CD using SAM tooling. I recommend part of the build process (whether manual or automated) include a step to publish your build artifacts into an artifact repository. Each time you package, you can package up the lambda code into a different versioned S3 bucket, and then push the package.yml file itself up into the S3 bucket. That way, those S3 files can be reused to do sam deploy for any versioned artifact that exist in your S3 bucket.
For example, here's a snippet from a Jenkinsfile groovy script:
                // We deploy to a different folder scheme depending on master/feature. Let's logic.
                base_folder     = "release-build-artifacts/${serviceName}/${releaseVersion}"
                lambda_folder  = "${base_folder}/lambda"
                cfn_folder      = "${base_folder}/cfn"

                // SAM Package
                sh "sam package --template-file ${service_name}.sam.yml \
                --s3-bucket ${s3_bucket} \
                --s3-prefix ${lambda_folder} \
                --output-template-file build/${service_name}.package.yml"
                sh "aws s3 cp build/${service_name}.package.yml s3://${s3_bucket}/${cfn_folder}"

You'll have to fill in the parameters for "${serviceName}", "${releaseVersion}", and "${s3_bucket}"

@michaelj-smith This makes a lot of sense, IMO -- use existing CI/CD for managing things like deploys and rollbacks. It would be great if there was some guidance in either a tutorial or in SAM's examples (https://github.com/awslabs/serverless-application-model/tree/develop/examples). This could serve as good advertisement for AWS' CI/CD tools as well 😉


local-notifications-with-ios-10

As we know, notify count limit 64
The new framwork in ios 10, how to repeat 5s,
source:
https://useyourloaf.com/blog/local-notifications-with-ios-10/

There's really no reliable way to get around the limitations. The only advice I can offer is to file a feedback report to Apple describing the use case you want. I wouldn't hold my breath for a response but you never know...


Capacity dashboard

To address Issue #89 @etsauer @raffaelespazzoli @sabre1041

@etsauer @raffaelespazzoli Updated dashboards as discussed. Please review


Updated text on 'Your Organisations' page to be less terse

Context
Text on the 'Your Organisations' page was seen as being too terse.
Changes proposed in this pull request
Apply updated text
Guidance to review
https://ghwt-prototype.herokuapp.com/your-organisations

 Update content on 'Your organisations'


Feature request: find specific types of references (e.g., instantiations)

struct S {
    pub x: usize,
}

fn print_s(s: S) {
    println!("{}", s.x)
}

fn main() {
    let s = S { x: 42 };
    print_s(s);
}

"find references" on S in the above program will find both the usage of S in the type of the parameter to print_s, as well as the use of S in the instantiation of s in main. However, I often want to see all the places where a struct is created, without having to hunt through the list of all references for those specific ones.

We actually already have this, though rather obsure(and possibly not really documented).
If you invoke reference search with $0 being the cursor like
struct S$0 {
    pub x: usize,
}

fn print_s(s: S) {
    println!("{}", s.x)
}

fn main() {
    let s = S { x: 42 };
    print_s(s);
}

you will get all constructor usages returned. The UX is obviously not really that great but we are somewhat limited by the language server protocol in this regard here.
Nevertheless we should document this behaviour better, assuming we don't yet.

The UX is obviously not really that great but we are somewhat limited by the language server protocol in this regard here.

Doesn't rust-analyzer have many extensions to the LSP already?
I could imagine r-a decides to supports thi, and then upstreams a proposal to the folks maintaining LSP (I guess Microsoft). Is this not a good model for how the process works?
In the meantime, thanks for the workaround.

The main problem here is the question how to even expose this, we could make an extension out of this but that would require each client to somehow expose this special rename as well. And in VSCode for example I don't think there is a decent way to offer more "kinds" of renames than the default.

The workaround doesn't work for me on version 04f03a360 2021-11-02 dev. It still finds all the references. Relevant parts of the server/client communication below:
[Trace - 12:37:12 PM] Sending request 'textDocument/references - (1396)'.
Params: {
  "textDocument": {
    "uri": "file:///Users/brennan/test_rust/src/main.rs"
  },
  "position": {
    "line": 0,
    "character": 8
  },
  "context": {
    "includeDeclaration": false
  }
}

[Trace - 12:37:12 PM] Received response 'textDocument/references - (1396)' in 1ms.
Result: [
  {
    "range": {
      "end": {
        "character": 15,
        "line": 4
      },
      "start": {
        "character": 14,
        "line": 4
      }
    },
    "uri": "file:///Users/brennan/test_rust/src/main.rs"
  },
  {
    "range": {
      "end": {
        "character": 13,
        "line": 9
      },
      "start": {
        "character": 12,
        "line": 9
      }
    },
    "uri": "file:///Users/brennan/test_rust/src/main.rs"
  }
]

The main problem here is the question how to even expose this, we could make an extension out of this but that would require each client to somehow expose this special rename as well. And in VSCode for example I don't think there is a decent way to offer more "kinds" of renames than the default.

Did you mean to leave this comment on my other issue, #10713 ?

Ah my bad, I meant after the last character, not on the last(So in this case the whitespace char after the identifier).

Did you mean to leave this comment on my other issue, #10713 ?

Ah I typed rename by accident, meant reference search of course.

Wrong again, its on the { char apparently(I rarely used this myself and with no docs I actually had to go check 😅)

Thanks, that works.


Related links focus state fix

What

The line height has been reduced from 1.5 to 1.28 to remove the half overlap when a link ran over two lines.
Why

When a link stretched over two lines, the yellow background of the lower line partially covered the black underline of the upper line. After discussion with @soniaturcotte it was decided that it would be better to reduce the line height to overlap the upper black line completely - increasing the line height to show both the upper and lower underlines led to a set of links with too much space between them.
Visual Changes

Before:

After:

🙌


Refactor engagement listing backend

-small refactor for engagement listing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

Codecov Report

Merging #1500 (02fb761) into main (a5a94d9) will increase coverage by 0.00%.
The diff coverage is 57.14%.

@@           Coverage Diff           @@
##             main    #1500   +/-   ##
=======================================
  Coverage   71.97%   71.98%
=======================================
  Files         331      331
  Lines        9771     9767    -4
  Branches      714      714
=======================================
- Hits         7033     7031    -2
+ Misses       2621     2619    -2
  Partials      117      117

Flag
Coverage Δ

metapi
79.28% <57.14%> (+0.02%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

met-api/src/met_api/models/engagement.py
70.98% <57.14%> (+0.50%)
:arrow_up:

... and 2 files with indirect coverage changes


Unable to finish authorization flow

Describe Your Problem:
I get an error when navigating the redirect URI and consequently I can never finish the setup of the plugin
Thanks for your help :)
Logs (with debug mode enabled):
see attached extract
homebridge-daikin-cloud.log.txt
Plugin Config:
see attached file, added some XXXX in a dresses and secrets
config - copie.txt
Screenshots:

Daikin Environment:

Daikin model: BRP069C4x
Daikin firmware version: 1_31_0

Homebridge Environment:

Plugin Version: v2.7.0-beta.5
Homebridge Version: v1.8.5
Node.js Version: v20.9.0
NPM Version:
Operating System: macOS 14.5

closing as I could find my answer on another case: Changing to <IP_ADDRESS> solved the issue.


Shared: Adds IsTrueOrEmpty and IsFalseOrEmpty

This allows us to more clearly check for an explicit boolean scenario in a string value (that may be able to support other values that are not boolean), and clearly indicate what the default empty value represents.

Unfortunately this PR solves one use case by breaking another :)

Some commits missing Signed-off-by


Outdated default value for Durable Functions Core Tools

According to the Task Hubs docs the default task hub name is TestHubName for Durable Functions v2. The docs for instance management should mention that you have to specify this if you use Durable functions v2, because for the Functions Core Tools DurableFunctionsHub is the default.
Or even better, change the default to TestHubName

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6c17b738-aa32-4cbb-3d82-bda2bc032487
Version Independent ID: a34e246c-7c65-461f-4417-3c47eb4672e2
Content: Manage instances in Durable Functions - Azure
Content Source: articles/azure-functions/durable/durable-functions-instance-management.md
Service: azure-functions
GitHub Login: @cgillum
Microsoft Alias: azfuncdf

@estensen, Thank you for your feedback! We have assigned this issue to the author to review further and take the next course of action.


Error when running application Zone.assertZonePatched

[X] bug report

What is the current behavior?

Running npm run server:dev runs correctly but when I try to access the app while its starting I get
main.browser.ts:25TypeError: Zone.assertZonePatched is not a function
    at new NgZone (http://localhost:3000/vendor.bundle.js:35588:14)
    at PlatformRef_._bootstrapModuleFactoryWithZone (http://localhost:3000/vendor.bundle.js:26047:22)
    at http://localhost:3000/vendor.bundle.js:26089:59
    at ZoneDelegate.invoke (http://localhost:3000/polyfills.bundle.js:15420:29)
    at Zone.run (http://localhost:3000/polyfills.bundle.js:15313:44)
    at http://localhost:3000/polyfills.bundle.js:15679:58
    at ZoneDelegate.invokeTask (http://localhost:3000/polyfills.bundle.js:15453:38)
    at Zone.runTask (http://localhost:3000/polyfills.bundle.js:15353:48)
    at drainMicroTaskQueue (http://localhost:3000/polyfills.bundle.js:15585:36)
    at HTMLDocument.ZoneTask.ZoneTask.cancelFn.invoke (http://localhost:3000/polyfills.bundle.js:15525:26)

What is the expected behavior?
App start correctly

Please tell us about your environment:

Recently upgraded my respository with all the commits made here from October

Angular version: 2.1.1
Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Fixed issue by upgrading zone.js to version ~0.6.23
"zone.js": "~0.6.23"

Even when this fixed the issue why does the version on the repo still has version 0.6.17 and it works


superlu update to 7.0.0

Library name
superlu
New version number
7.0.0
Other information that may be useful (release notes, etc...)
No response

website: https://portal.nersc.gov/project/sparse/superlu/
Version: 7.0.0(https://github.com/xiaoyeli/superlu/releases/tag/v7.0.0)
Release Date: August 17, 2024
Info:

API change: "complex" to "singlecomplex"

Many other fixesx


fix(typo): percison -> precision

Describe the PR
Fixes typo in "precision".
Small replication
N/A
PR checklist

What kind of change does this PR introduce? (check at least one)

[x] Bugfix :bug: - fix(...)
[ ] Feature - feat(...)
[ ] ARIA accessibility - fix(...)
[ ] Documentation update - docs(...)
[ ] Other (please describe)

The PR fulfills these requirements:

[x] Pull request title and all commits follow the Conventional Commits convention or has an override in this pull request body This is very important, as the CHANGELOG is generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied

Should we remove this actually? This utility function is not used anywhere.

Remove this util

Should we remove this actually? This utility function is not used anywhere.

Deleted this util please


Add demo

As requested in Leaflet/Leaflet#2214, please add a demo webpage to showcase the plugin.

Using gh-pages may help.

Added demo examples via gh-pages https://github.com/teastman/Leaflet.pattern/commit/6898228b78fa10e5cdb1c57ce7322980fe5f8401


Nils are values too!

When the exposure block returns a nil, that value should be returned
instead of re-running the exposure block when the method is re-invoked.
If the exposure encapsulates a long-running operation, you don't want
that to run multiple times.
expose(:foo) { sleep 10; nil }
Bechmark.realtime { foo; foo} = 20 secs, instead of 10 seconds

Sandro,
Thanks for this pull request. This is actually already the default behavior for what will become decent_exposure 2.0: the "nunu" branch. That said, this is probably safe to be pulled in for master. What do you think, @voxdolo?

Yeah, looks good for master. I'll pull it in. Also: I now know that Enumerable#fetch takes a block.


remove scrollbar styling on filter-panels

Description
This PR removes the hacked-together styling of Scrollbars in the filter Panel.
Why is this necessary?

Scrollbar stylings for IE are almost impossible to reset
They only look "kinda" nice in the default theme
It's in the _hacks.less because, yes, it is a hack

If you insist on doing this, please consider using a flag for this and spare us developers from working around this.
We want default scrollbars.

Questions
Answers

BC breaks?
no

Tests pass?
yes

How to test?
Test filter panels

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/#/issues/SW-17246.
Please use this issue to track the state of your pull request.

Thanks @screeny05
We'll not merge this PR into 5.2 but we're looking forward to merge this into 5.3.

Merged into 5.3.


License

Hello. Under what license is this code? If still unlicensed, would you accept a pull request to add a 0BSD license?

Hi! Thanks for your interest! I've just added an MIT license, as most of open source projects does. Please let me know, if it's not permissive enough for your use case!

MIT works well. Thank you! 🙏


Drag and select multiple torrents with the mouse

Please add the ability to select multiple torrents by dragging and selecting with the mouse. Since it is now possible to select only using the keys on the keyboard Ctrl or Shift.
This is what I am talking about:

GIF

I'll see if this could be added easy enough, but I'm not sure. The torrent list will select the items on mouse down (as it should) and I don't think a selection rectangle would work well in that kind of list (report style). The Control and Shift modifiers when clicking are standard Windows modifiers for doing exactly what you're describing.

@vktr I don’t know why I didn’t notice earlier that the function described by me is present. It’s just that when selecting, a translucent selection rectangle does not appear.
Then you can close my issue if it is difficult to implement a translucent selection rectangle (yes, I myself do not see this as a special need).

@vktr It looks like this function stopped working after switching to wxWidgets.


Clear clientlib inclusion state in Error Page Handler

As discussed in http://adobe-consulting-services.github.io/acs-aem-commons/features/errorpagehandler.html#comment-2304492383
I was able to clear the clientlib inclusion state by adding the additional line to com.adobe.acs.commons.errorpagehandler.impl.ErrorPageHandlerImpl:
request.setAttribute(com.adobe.granite.ui.clientlibs.HtmlLibraryManager.class.getName() + ".included", new HashSet<String>());

I'm running AEM 6.2 and the CSS client libs in the  of the error page were not getting rendered at all. The JS clientlibs in the footer were. It seems that on top of clearing the com.day.cq.widget.HtmlLibraryManager.included attribute, you have to clear com.adobe.granite.ui.clientlibs.HtmlLibraryManager.included as well.

@jollyrubber Thanks for the fix. Ill update.

@davidjgonzalez is this fixed now?

Fixed via https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/791


Allow deprecated-copy for now

Workaround for #295 . Only a temporary fix until https://github.com/facebook/rocksdb/pull/5426 is resolved.

Posting a workaround on linked issue.


TTF fonts in app bundles should be added to list of available fonts for the app

@ms-jihua Is this covered by #1386?

No, #1386 gets us about halfway there.


looging for an acme.sh dns api example

I am looking for an example use the acme.sh in dns api mode as mentioned here:
https://github.com/acmesh-official/acme.sh/wiki/dnsapi
export CF_Token="sdfsdfsdfljlbjkljlkjsdfoiwje"
export CF_Account_ID="xxxxxxxxxxxxx"
export CF_Zone_ID="xxxxxxxxxxxxx"
./acme.sh --issue --dns dns_cf -d example.com -d www.example.com

Can this be done in acme-companion? Is someone willing to share an example?
Thx.

This is not yet supported, see #319


(OUI Docs) Writing Guidelines

[x] Remove page - this will be moved out of OUI and into the OpenSearch Design System guidance documentation website.

Blocking this issue for now, since at this point we are getting so close to our editorial redesign collaboration that we might just want to focus on the edits that come out of those prescribed changes.

Closing https://github.com/opensearch-project/oui/pull/503


startActivity method is not available in .net driver

startActivity() method is not available in .net driver.
Version : <IP_ADDRESS>

@pranavswaroopg do you mean (AndroidDriver) driver.StartActivity()? Because it exists.


Bring back JWT OAuth2 module (as deprecated)

As the latest update of jsforce (beta25), which includes removal of JwtOAuth2 #1341 , sfdx-cli is failing for the absence of jsforce_1.JwtOAuth2. This will be fixed in the sfdx-core, but the fix is not yet merged and it requires all sfdx-cli users to update its version because the sfdx-core is depending jsforce in caret versioning (^2.0.0-beta.24), which automatically select the latest beta version.
Considering the impact of this disfunction, I would like to bring back the JwtOAuth2 module, but with deprecated warning.

Hi @stomita 👋🏼
I see you published a beta release last week, do you know if that also changed the latest dist tag? I see it points to latest v2 beta instead of v1:
➜  ~ npm show jsforce dist-tags
{
  latest: '2.0.0-beta.27',
  alpha: '2.0.0-alpha.13',
  beta: '2.0.0-beta.25'
}

Also, we added a manual release workflow a few weeks ago that can be used to trigger a release.
We'll add a doc for this once all actions are added, but this is how it works:

merge change into 2.0 branch, don't modify version field in package.json, the action will do it at release time
go to https://github.com/jsforce/jsforce/actions/workflows/manualRelease.yml, click Run workflow -> Use workflow from  and select the 2.0 branch -> Run workflow.
This will create a GH release that triggers the npm-publish job.


RDKCOM-2087, RDKCOM-1978, RDKCOM-2090: WiFiManager added new getSavedSSID method for retrieving saved SSID, Introducing Amlogic STB specific flag for Network plugin fixes.

There is no get/set pair for SaveSSID method in WiFiManager plugin.
Bringing in a method for retrieving getSavedSSID.
Logic is: Utilize PersistentStore plugin to save and read saved credentials.

Discarding this change as it increases security vulnerabilities and also Comcast's LostAndFound feature does not require this. But community does not have that.
Since same logic can be implemented in UI; if needed UI can do.


[AMBARI-23718] Update repoinfo latest with the link from repository (dsen)

What changes were proposed in this pull request?
Update latest tag value in all stacks repoinfo with the value from ambari.repo
How was this patch tested?
manual + UT

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/2038/
Test PASSed.


Community Group

mullwar than you.
You wrapper is great.
What do you think about create telegram group when developers can talk with each other?

Great idea 👍
Here is a new public group chat link: https://t.me/joinchat/AAAAAEF1Ivern8XS4DKn-A
Everyone is welcome! 🎈


Route Cache Caches the underlying API calls as well!

Hi @dulnan
I'm encountering an issue with version 3.3.0.
When using the Route Cache for the route ~/pages/product/[id].vue, it caches the underlying API calls as well. When rendering the page, I use two API calls: one to get content (/api/cms/product) and the actual product data (/api/productInfo?id=productId), using Redis as the cache base.

I can see three entries in the cache: one for the actual page and two for /api/cms/product and /api/productInfo.
I would like only the page to be cached. Is there any way to achieve this? It worked as expected in version 3.2.0.
Thanks in advance; any help would be greatly appreciated.

That sounds very weird and unexpected. I will look into this now.

Thank you @dulnan
To add to the above I have tried to avoid caching the api calls using the enabledForRequest but does not helped.

I am unable to reproduce this behaviour. I have created a new API route that does not call useRouteCache() at all, meaning it should not be cached. I then call this API using useFetch() on a page that calls useRouteCache() with isCacheable(). I only have one entry in the route cache, the page. Only when I explicitly call isCacheable() inside the API event handler do I see that its response has been cached.
If you say thatenabledForRequest does not work, then something super fishy must be going on: This method is called very early on in the request life cycle and if its returns false, then the cache is completely unavailable for any subsequent code... This makes no sense :thinking:
Do you have other places where you use useRouteCache()? e.g. inside a server middleware?

Okay just as I sent it, I was able to reproduce it. And... it's VERY weird what I'm seeing. This is impossible.

Yeah, I found the problem, look:
Page component
<script lang="ts" setup>
import { useFetch, useRequestEvent } from '#imports'

const event = useRequestEvent()

if (event) {
  event.context.foobar = 'TEST'
}

const { data } = await useFetch('/api/uncacheableApi')
</script>

API route
import { defineEventHandler } from 'h3'

export default defineEventHandler<{ data: number }>((event) => {
  console.log('Test: ' + event.context.foobar)
  return {
    data: Date.now(),
  }
})

This logs Test: TEST to the console. Apparently the context is shared (?!) for the entire request, including any API calls that are made during server side rendering. One of the things I did change in the latest release was using this exact event.context to add the cache helper, instead of putting it on the event directly. This explains why enabledForRequest does not work: The first time it's called, your method returns true, because that path is not starting with /api. But at that point it is now set in event.context and thus available for any and all API routes. Crazy.
I will do a fix now and release it asap.

Thank you so much @dulnan. Understood whats happening :)

I have just released 3.3.1, would you like to give it a try?
Also thank you very much for bringing this issue to my attention! I would probably not have noticed this for some time and seeing as this bug could result in very unexpected runtime behaviour, I'm glad I was able to fix it now.

@dulnan Thank you so much!!! that worked :) the quickest response I have ever got!
you are doing great help by writing this module, we understand how important the cache is, providing the Nuxt's performance.
However, I encountered the below error. while serving the cached response.
Serving cached route for path: /product/A-23958 {
  fullKey: '/product/A-23958'
}

[nuxt] [request error] [unhandled] [500] Cannot set headers after they are sent to the client
  at new NodeError (node:internal/errors:405:5)
  at ServerResponse.setHeader (node:_http_outgoing:652:11)
  at setResponseHeaders (./.output/server/chunks/runtime.mjs:2559:20)
  at Object.handler (./.output/server/chunks/runtime.mjs:5423:7)
  at ./.output/server/chunks/runtime.mjs:3063:31
  at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
  at async Object.callAsync (./.output/server/chunks/runtime.mjs:5544:16)
  at async Server.toNodeHandle (./.output/server/chunks/runtime.mjs:3329:7)

Kindly let me know if I can avoid this error?

Sure, could you show me which other modules you have installed or nitro/h3 related libraries you use? I know for example that the h3-compression library is not compatible with this module due to the way the response is compressed.

Surely,

and nitro config

Could you try (if easily possible) to disable nuxt-security to see if it would resolve the issue?

@dulnan tried to removing them but no luck. not sure whats happening, shall check if any of the code that we wrote causing this issue and come back here. If I need further help..

@dulnan while serving the cache in serveCacheRoute, we set the headers using setResponseHeaders as well as we are iterating headers and set the headers using response.headers.set!
Not sure which is causing the issue, just thought of sharing it here!

Oh I see. I did not think of this scenario. Generally I would advise against using route cache + route rules together, but in this case it would be a valid use case to add headers. I will check to see if it's possible.

Thanks @dulnan

I looked into it and once again it's such an annoying problem with the way h3/nitro are setup. For some context: As an author of a module like nuxt-multi-cache, it's very hard to implement route caching. There are only so many ways one can hook into the life cycle of the request. The problem now is that the part where I cache the response happens at the very end of the request. This is why the module is able to also cache the headers applied by your route rule initially and also stores them in the cache. However, in the second request, when the module wants to serve something from cache, the only "sane" way to achieve that is inside the onRequest hook. There I load it from cache and immediately return the response. However: Nitro will still go through the entire rest of the request, calling hooks, applying route rules, etc. As of now I have not found a way to prevent that reliably.
That was also the case pre 3.3.0, however there it worked because "serving from cache" was implemented as an "event handler", because nitro did not provide a hook at that time. But in order to implement "stale if error" and "stale while revalidate", I could no longer implement it as an event handler.
Anyway, as a temporary workaround, I suggest to not use routeRules to apply headers but instead apply them in a server middleware using setResponseHeader. In the meantime I will continue to explore options to make route rules work with route cache.

Thank you for the detailed explanation @dulnan. For now I shall write the no-cache to the routes that I am not caching at all and I'll see if I need them in the routes I am caching and add them as necessary...
I need to understand more on h3/nitro implementation.
Thank you once again for the prompt replies :) helped me a lot..

I may have found a workaround which I've already implemented in #66, but I still need to do some more testing. You may not need to apply the workaround for long, if it turns out to work properly!

Great to hear! Hope all will be good (y) in the new PR and works well!!

@sathishzakapps I just merged the change that should hopefully fix this issue. I will do some more testing (together with other fixes pushed today) and if all works, create a new release today.

@dulnan Thank you for the update, I shall get the latest and test them and let you know in case of any issues? Once again thank you!!!


i18n: How to add new language to this repository

Let's pretend we want to add the French: fr language as a supported language to the repository.

Modify package.json and add the French langugage in to the list of langugages.

---   "config": {"languages": ["en", "de", "tr"]},
+++   "config": {"languages": ["en", "de", "tr", "fr"]},

Pull French language file from Transifex
tx pull -l fr

Run convert command
npm run i18n-conv-po-all

update i18next instance, to add the new language.
modify i18next.js file to add the new language.

import the new translation file.
import TRANSLATIONS_FR from './translations/fr/translations.json';

update resources and add the new language.

    resources: {
       ....
      fr: {
        translation: TRANSLATIONS_FR,
      },
    },

Translation with interpolation https://www.i18next.com/translation-function/interpolation


[Proposal] Add Azure Event Grid for Pub-Sub

Describe the proposal
Using custom topics as event source and WebHooks as event handlers

Yeah that's a good proposal, only question is which IP do you give Event Grid when running on Kubernetes/local dev machine?

Local
not nice, but in line with other docs - using ngrok as tunnel.
Look at Event Grid Trigger Local Debugging
K8s
Is adding auth to service invocation on the roadmap?
If, this would be something we can also leverage for securing the sub endpoints?
Using a pubsub (or binding) broker which is outside of K8s (or only available in the cloud) is a common scenario and not specific to Event Grid, thus we need an overall design for this.

Is adding auth to service invocation on the roadmap?

Yes, but I don't want to tie it to this particular issue..
Authentication with cloud pub-sub infrastructure is tied to the specific implementation, whether its certificate/token based.

For reference - PR for EventGrid as Binding: https://github.com/dapr/components-contrib/pull/290
I think the same questions apply here too:

Yeah that's a good proposal, only question is which IP do you give Event Grid when running on Kubernetes/local dev machine?

https://github.com/dapr/components-contrib/pull/290

Would love to have Event Grid as well - Either in-cluster or custom topic!

Looks like this was merged and done but not documented on https://github.com/dapr/components-contrib/blob/master/pubsub/Readme.md, is that correct?

There's an Event Grid binding, not Pub/Sub.

I too would love to have this.


no session in home.php file

i am going to fix this problem

issue is fixed now

issue is closed


gitattributes recognizes pdfs as binary

Honestly, PDFs should not be in the repo.. but if they are
put in there, they should not be fiddled with.

I just ran into this

Thanks.


Implement reusable CITAtions by using pointers to new CITA structure

Currently the definition is:
SOURCE_CITATION :=
n SOUR @<XREF:SOUR>@ {1:1} g7:SOUR
+1 PAGE <Text> {0:1} g7:PAGE
+1 DATA {0:1} g7:SOUR-DATA
+2 <<DATE_VALUE>> {0:1}
+2 TEXT <Text> {0:M} g7:TEXT
+3 MIME <MediaType> {0:1} g7:MIME
+3 LANG <Language> {0:1} g7:LANG
+1 EVEN <Enum> {0:1} g7:SOUR-EVEN
+2 PHRASE <Text> {0:1} g7:PHRASE
+2 ROLE <Enum> {0:1} g7:ROLE
+3 PHRASE <Text> {0:1} g7:PHRASE
+1 QUAY <Enum> {0:1} g7:QUAY
+1 <<MULTIMEDIA_LINK>> {0:M}
+1 <<NOTE_STRUCTURE>> {0:M}

When citing a marriage record from an old church book I prefer to record the complete text - sometimes even translate it - and put it into +2 TEXT <Text> {0:M} g7:TEXT. Because marriage records often mention 6 or even more individuals (bride, groom, bride's parents, grooms's parents, witnesses) with information about birth date, birth place, age, religion, occupation, place of residence, etc. I have to copy all the details from one SOURCE_CITATION to the other. This may lead to up of 20 or more copies of identical information. If I later find out that I misread some of the old handwriting I have to go through all these copies and correct them which is not only a pain but error prone.
I'd like to use reusable citations by using pointers to a new GEDCOM level 0 structure e.g. CITA that would then point to the SOUR record which points to the REPO record.
Instead of
1 OCCU butcher
2 DATE ABT 1850
2 PLAC New York City, New York, USA
2 SOUR @S123@
3 PAGE 456
3 DATA
4 TEXT ... butcher ...
5 CONT ... New York City ...

use something like
1 OCCU butcher
2 DATE ABT 1850
2 PLAC New York City, New York, USA
2 CITA @789@

and
0 @C789@ CITA
1 SOUR @S123@
2 PAGE 456
2 DATA
3 TEXT ... butcher ...
4 CONT ... New York City ...

Hope this makles sense.

It makes sense! Good idea. However, it is not in line with the GEDCOM standards. So, I would not use it.

A complete redesign and “Normalization” of GEDCOM has been discussed.  This can’t happen until GEDCOM v8 or later!

However, it is not in line with the GEDCOM standards.

I am suggesting to add it to the GEDCOM standard.

Instead of a new record type I would prefer a more general solution.
In GEDCOM 5.5.1, reference was made to a future concept that makes substructures of records addressable.
Quote from GEDCOM 5.5.1:
The pointer represents the association between two objects that usually reside in different records. Objects within a logical record can be associated. If this need exists, the pointer record composition contains an exclamation point (!) that separates the parent record's cross-reference ID from the specific substructure's cross-reference ID, which is at some subordinate level to the logical record at level zero. The cross-reference ID of the substructure subordinate to a zero level record, for inter-record associations is always composed of the Record ID number and the Substructure ID number, such as<EMAIL_ADDRESS>Including the Record ID number in the pointer that associates objects within a record will allow the GEDCOM processors to build the index only at the record level and then search sequentially for the appropriate substructure cross-reference ID. The parent record ID is assumed when the cross-reference ID begins with a exclamation point (!) signifying an intra-record association.
Applied to Sir Peter's case presented here, the structure would look as follows:
0 @I132@ INDI
….
1 OCCU butcher
2 DATE ABT 1850
2 PLAC New York City, New York, USA
2 @I132!1@ SOUR @S123@
3 PAGE 456
3 DATA
4 TEXT ... butcher ...
5 CONT ... New York City ...

0 @456@ INDI
….
1 OCCU butcher
2 DATE ABT 1850
2 PLAC New York City, New York, USA
2 SOUR @I132!1@

Instead of a new record type I would prefer a more general solution.
In GEDCOM 5.5.1, reference was made to a future concept that makes substructures of records addressable.
Quote from GEDCOM 5.5.1: The pointer represents the association between two objects that usually reside in different records. Objects within a logical record can be associated. If this need exists, the pointer record composition contains an exclamation point (!) that separates the parent record's cross-reference ID from the specific substructure's cross-reference ID, which is at some subordinate level to the logical record at level zero. The cross-reference ID of the substructure subordinate to a zero level record, for inter-record associations is always composed of the Record ID number and the Substructure ID number, such as<EMAIL_ADDRESS>Including the Record ID number in the pointer that associates objects within a record will allow the GEDCOM processors to build the index only at the record level and then search sequentially for the appropriate substructure cross-reference ID. The parent record ID is assumed when the cross-reference ID begins with an exclamation point (!) signifying an intra-record association.

This is and will always be a bad design.  Pointers within and to record instances was discussed before as well.  “Normalization” should be part of the design!

Maybe I'm missing something; why not include this text from the source in the SOURCE_RECORD.TEXT instead of the SOURCE_CITATION.TEXT?

Maybe I'm missing something; why not include this text from the source in the SOURCE_RECORD.TEXT instead of the SOURCE_CITATION.TEXT?

For something like a parish register, each entry would be a separate citation.
e.g.  "Peter, son of Martin and Mary Smith, farmer of this parish, was baptized on 28th February 1753".
Each of these citations would be the source of many facts (OCCU of father, BAPM of child, MARR of parent) - and would only consist of the text from that single entry.

A single parish register (the source!) could include many hundred events from more than two decades. In situations where a family (or clan) lived in that parish for decades their events may show up on almost every page so that dozens of citations from the the same source need to be documented.
I cannot think of any effective and efficient solution other than reusable citations.

This is and will always be a bad design. Pointers within and to record instances was discussed before as well. “Normalization” should be part of the design!

Can you give me a link to this discussion?

This is and will always be a bad design. Pointers within and to record instances was discussed before as well. “Normalization” should be part of the design!

Can you give me a link to this discussion?

https://github.com/FamilySearch/GEDCOM/discussions/328
Note there's not unanimity of opinion here; I like pointers to substructures because I work with object and graph databases, but they are not appreciated by those who've weighed in who work with relational databases.

reteP-riS proposed, and fisharebest commented:

Each of these citations would be the source of many facts (OCCU of father, BAPM of child, MARR of parent) - and would only consist of the text from that single entry - not the entire register.

I support this idea, and already had implemented it in the internal data structure of my application.
However, there is a substructure which should not be integrated into the citation record: ROLE. Different individuals mentioned in the source entry will have the same citation text, but different roles. Another substructure is NOTE, which may be specific to one role.
So my solution is like this:
2 SOUR @S1@
3 _CIT @C1@
3 ROLE FATH
3 NOTE note specific for the father

with
0 _CIT @C1@
1 PAGE Page: 17, Line 4
1 DATA
2 TEXT Peter, son of Martin and Mary Smith, farmer of this parish, was baptized on 28th February 1753
1 SNOTE @N1@

0 @N1@ note for all roles mentioned in the entry

This structure enables the user to edit the citation record, and automatically updating it for every individual where it is used.
As for GEDCOM 7.0 at GEDCOM export I have to convert this structure replacing the _CIT @C1@ everywhere to the full text transcribed from the entry in the source. GEDCOM files' size is increased by this a lot, and even worse, after editing the data in other applications users in most cases are not able to edit a citation text at all callings in the same way. By this the original structure is destroyed.
I would be totally happy with the structure proposed by reteP-riS, putting the SOUR line within the citation record. Not doing so is only because the _CIT part will not be imported by most applications so far, so in case another application tries to interpret my internal code I want to preserve the SOUR @S1@ as minimum...
I hope the SOURCES team will help a structure like this to come in future GEDCOM versions!

My belief is that if you include a so-called “citation record” in a future version of GEDCOM, this record should actually be the citation, not parts of the citation.  Because each type of citation requires different components and varies based on which style is used, a companion “Template Record” would need to be created that outlines what the citation should contain, and where the data is found in the GEDCOM.  At some point the Source_Record and the Citation _Structure would go away, with the template controlling and defining the fields being used to store the components of the citation in the Citation_Record for each citation type and style.

@albertemmerich

However, there is a substructure which should not be integrated into the citation record: ROLE. Different individuals mentioned in the source entry will have the same citation text, but different roles.

I admit you make a point by indicating that the ROLE tag might require a specific treatment. I missed that because I never used it.
In GEDCOM 5.5.1 the SOURCE_CITATION can appear in PERSONAL_NAME_PIECES, in a FAM_RECORD, in an INDIVIDUAL_RECORD, in a MULTIMEDIA_RECORD, in a NOTE_RECORD, in an ASSOCIATION_STRUCTURE and in all individual's and family's EVENTs and FACTs and I wonder how the ROLE subtag should be used for a MULTIMEDIA_RECORD, a NOTE_RECORD, a FAMILY_EVENT or a FACT. These use cases don't really make sense for me.
A closer look at the ROLE tag reveals that - at least in GEDCOM 5.5.1 - it is a subtag of the EVENT subtag itself. So we are talking about SOUR:EVEN:ROLE which makes ROLE in fact a subsubtag of the SOUR tag. And it should be related to an EVENt which at least to me confirms that the above use cases for MULTIMEDIA_RECORD, NOTE_RECORD and FACT don't make much sense. And for a FAMILY_EVENT like MARR or DIV I wouldn't know what to put into the SOUR:EVEN:ROLE tag because you have 2 individuals with 2 different roles - husband and wife - but only one ROLE tag is permitted. Just use SPOU for spouses (plural)? I'm afraid this whole ROLE tag thing has not been thought through entirely when it was introduced.
With regard to your example

2 SOUR @S1@
3 _CIT @C1@
3 ROLE FATH
3 NOTE note specific for the father

it seems to be incorrect for two reasons.

As mentioned before it needs to be SOUR:EVEN:ROLE, not simply SOUR:ROLE.
2 SOUR @S1@
3 _CIT @C1@
permits an n:m relation for sources to citations while it should be a 1:m relation. In words: while a single source can hold multiple citations a single citation MUST be tied to a single source, not to multiple sources. There must be clear one-way connections, i. e. pointers CITA > SOUR > REPO.

With regard to backwards compatibility I think GEDCOM 7 should introduce reusable level 0 CITAtions while still permitting the GEDCOM 5.5.1 conventions for a SOURCE_CITATION, but it needs to be an EITHER ... OR, not both in the same record. But both solutions could of course exist in the same GEDCOM file. And yes, the ROLE tag thing should be resolved, too, but that's a different story and certainly requires more thoughts. Maybe permitting multiple ROLE tags would help. Or getting rid of EVEN:ROLE completely.

Good point. However, role is very important for me, and I very often use it. Citing a marriage, there is no ROLE line in the family record, however the bride has a ROLE, and the bridegroom has a ROLE, and the witnesses have their ROLE. In their records _CIT comes with a _CIT.ROLE substructure.
My example was a short version. As in all these records EVEN is the same (it is MARR), I put it into the citiation record. However ROLE differs and therefore cannot be in the citation record.
The proposed structure is a braking change anyway, and we have to wait for a major new version of GEDCOM standard. So I do not see a big problem in rearranging the ROLE position within the citations.
Another point: I am not a friend of "either ... or" solutions. We have to many applications in the wild which only support one of the possible solutions, but not the alternate solution. Users see data loss at data transfer. We can avoid this by clearly define the structure to be used, and not open the way for different representations of same data.

I add a file with my proposal using citation records CITA. (It is txt as ged I am not allowed to upload)
sample_citation_records_8.txt
In my application I already implemented that solution to enable the users to edit the citation for all events / individuals / families in one step for all records where it is used. Exporting to GEDCOM 7.0 the full source citation replaces every call of CITA, and the ROLE is moved to DATA.EVEN.ROLE. When importing GEDCOM 5.5.1 / 7.0 files the CITA structure is build automatically for internal use.
Data coming back from other applications often have damaged citations, as they are modified differently at the various places in the file. This results in different CITA records which have to be merged again... Therefore it would be much better to have the CITA records in GEDCOM spec.
Would like to see alternatives discussed by citation group using this example.

Regarding "Would like to see alternatives discussed by citation group using this example."
This issue is also tracked by https://github.com/dthaler/gedcom-citations/issues/11


[5.7] Add missing code-signing steps in two dist actor tests.

This should resolve rdar://99714807

@swift-ci please test

@swift-ci please smoke test


Active users web component

A highly customizable web component to display active users data. This will close #5.
Wasn't 100% sure on the file structure that should be taken but I've also included a test page "index.html" that can be opened straight in the browser for viewing the web component.
Also threw some css on the component but it could definitely use some polish.

Super interesting @Technickel-Dev.
So in this case the responsibility of doing the calculations would be outside of the component or we would structure it so that the view of the ruby component is the web component?
I think the state of including JS from gems is also a mess (without sprockets), maybe @caitmich can weigh in with the best path forward to have .js loaded from a gem.

I left it flexible for what we want to do. You can include a view component that handles all the data and calculations using the web component in the gem or we can just ship the web component separately. The first option is what I find when I search online for Rails working with web components but the second leaves more flexibility in the end user's hands, though flexibility isn't always nice for UX of the gem's consumers
It handles both attributes or slots so it's really up to how we want to run with it. We could get fancy with it and extract it out to make an entire component library with storybooks and if we really wanted :P

@krsyoung If we are going with ViewComponents, what should we do about Bradley's push?


[FEATURE] conditional.mask should be a proper eve function.

I think this makes sense.
The code is duplicated between different conditionals.
There is limited testing.
A proper function that just operates on the concept is needed.

This can just be an overload of bit_mask that do a similar tasks for regular wide

Wait, bit_mask returns a bit for each element.
conditional.mask - returns a logical.
We have to_logical for top_bits, that is similar:
https://github.com/jfalcou/eve/blob/ac503f6a0378e2bc9f01d634ed13f04865a1dd92/include/eve/detail/top_bits.hpp#L327
This can be a to_logical, the eve one.

We discussed the fact cond.mask( as<T>() ) is enough as interface but that the non used parts of it must be cleaned up.


tests pass when 'run tests', but fail when click on submit

My solutions to the digital_root problem on your JavaScript section passes all tests when I click on 'run tests', but it fails when I click on 'submit'. What's the catch?

Yeah we have tried phrasing it so many different ways but its still never really clear to people that "Run Tests" is for the example tests that you can see and edit, and submit runs a different set of tests that you can't see, which usually contain a more full featured test suite.
The idea is that you are supposed to be doing TDD so authors don't provide all of the tests for you.

Why don't you setup the UI so that it shows the failing tests.

Right now, you're just told that test suit fails, and as program writer you cannot see which test from the suit is failing. I get TDD, I do TDD, I usually have my right panel with the test(s) and my left panel with the actual class/module/function I'm writing. I think most developers on your site are on the same page, and are used the same UI behavior as I described.

Please provide a screenshot. Unless the kata author wrote vague tests or is intentionally trying to keep them opaque, you should see test output results for failures the same as normal test runners output

Was there a resolution to this or is it just how things are and that's why it was closed?  Even if I write my own tests, I'm still having to  take a guess at what the failing tests are in the Kata suite, which is a touch frustrating.

The output is based on the test cases that the authors wrote. Many authors writes tests so that the failure output is informative. You can also try inspecting the inputs by writing to stdout (e.g., console.log,print). If it's still unclear, try asking questions to the authors (each kata has its own discussion thread).

Ideally, the test and submit would be the same.

The sample tests are intended for you to modify it as needed to help writing the solution according to the description. Many will provide examples there to get started, but it's not meant to be complete.
For advanced kata, it's helpful to write your own tests there that's almost equivalent to the authors' tests used on submission. In other words, it's part of the challenge to write your own tests so that "the test and submit would be the same.".

This is not representative of a real world problem.  If my program fails I want to know why it failed so it can be debugged.

What @spiro01939 said.
For example, I'm trying to do a fairly simple kata. My code passes all the tests but one, and I get this message on the one that is failing Expected: [], instead got: [0, 0]
I'd love to know what was returning [0, 0] so I can make my code better and pass the test.

Like I wrote above, we don't control what's in the test output.

The output is based on the test cases that the authors wrote. Many authors writes tests so that the failure output is informative. You can also try inspecting the inputs by writing to stdout (e.g., console.log,print). If it's still unclear, try asking questions to the authors (each kata has its own discussion thread).

The authors choose to name the test case "test #1" (not helpful) or "given a = 1, b = 1" and that's what gets displayed. But even if the author didn't provide descriptive test name, you can usually figure out the inputs by printing them.
Once you find the inputs, you can add that to the sample tests section and change your code until it passes. It exists so you can write your own tests.
Just to be clear, I agree some authors writes unhelpful tests and those can be improved. Or a kata have hidden requirements that's not in the description. For those cases, open an issue for that kata and let the author know so they can improve it. This is not the right place to handle kata issues.

@kazk Thanks, I'll open issues with the kata instead. I didn't realise it was upto the author to write more descriptive test cases.

Cannot view which test failed.

@KarmaBlackshaw  I am having the same issue

@sanchocreativo Please see if this FAQ helps: https://github.com/codewars/codewars.com/wiki/Troubleshooting-your-solution#print-input


Improve convergence for symmetrical functions for Nelder Mead Simplex

As discussing in #632 this is a pull request to solve #501 in the way suggested by @EricScottSalem.
Test taken from #501 by @MMAvanEnkhuizen

@eriove Any idea whats wrong with the build here?

Not sure, seems very unlikely that it is related to changes in this request.

It looks like in both cases the build server was unable to use the required .NET Core version.  Perhaps just rerunning the build will solve this?  I dont see how to do that, though.
@cdrnet  ?

Yes, the failing builds are unrelated - neither TravisCI nor Azure Pipelines seem to support .Net Core 2.2.4 (SDK 2.2.106) yet. AppVeyor is what counts for now. Sorry for the confusion.

Are we waiting for the build servers to catch up to approve this PR or can we do so without Travis and Azure?

Looks good to me as well. Thanks again!


phpcd move cursor to split below instead of autocompleting

I'm using master version (currently<PHONE_NUMBER>97)
if I have two "splits" opened (by using :sp ) and the cursor editing the split at the top with a code like this :  (| is where my cursor is , not an actual character in my code)
$user->|($password);

as soon as i put i to enter in edition mode,  my cursor now jumped to the split below (in edition mode, so now the text i'm typing is erronously written in the split below)
note that if i have no split below opened (having split opened on the left/top etc. does not produce the issue) the autocompletion works correctly
if the code is something like that:
$user->set|($password);

same problem
it looks similar to this https://github.com/lvht/phpcd.vim/pull/128  (except that there's no exception being thrown, my code has no syntax error in it)

may be not exists anymore, please try the latest master branch, if you still use phpcd.