Update Landsat pull code/workflow

Katie, since you are most recently in the weeds of GEE, I'm tagging you as primary reviewer here.
This looks pretty large, but some of it is misleading - just consolidation of code without changes from one script to another (or few changes that I will point out, check comments on documents before getting into the weeds).
Big thing here is a re-run of the poi pull now that we have established workflows (that you've already reviewed), streamlining naming conventions (consistent use of yml instead of yaml, use of pathrow instead of tile). I'd say look into the logic of new R scripts more than anything else. LMK if something is not clear!
Closes #20: specifically, see the additional masks in b_pull_Landsat_SRST_poi/py/run_GEE_per_pathrow.py lines 316-435
Closes #4: Technically, I'm still running it, but this code completes this issue.
If you want to run this, I'd suggest just grabbing a subset of the target b_WRS_tiles_poi because the entire run takes... DAYS. Here's what I'd replace the current lines 76-91 in b_pull_Landsat_SRST_poi.R with if you want to run this as a trial. Similar to previous asks, if you run this, please do it on your own account and you'll need to edit the config_poi.yml file to reflect that. I don't think this is 100% necessary, but could be nice to do? You're choice here.
  # subset the pathrows to fewer to map over
  tar_target(
     name = b_subset,
     command = b_WRS_pathrow_poi[1:5]
  ),

  # run the Landsat pull as function per tile - this is the longest step and can
  # not be run by multiple crew workers because the bottleneck is on the end of
  # GEE, not local compute.
  tar_target(
    name = b_eeRun_poi,
    command = {
      run_GEE_per_pathrow(WRS_pathrow = b_subset)
      },
    pattern = map(b_subset),
    packages = "reticulate",
    # note, this can not/should not be used in mulitcore processing mode - the
    # bottleneck here is at GEE, not local processing, and the way the {targets}
    # and python workflow work together requires only a single `run_GEE_per_tile`
    # at a time.
    deployment = "main"
  ),

Eep, just found an issue, closing, but will fix and reopen tomorrow!


Add option to skip unpacking the same layer in parallel

With the way things work right now, there's nothing stopping a parallel unpack of the exact
same layer to a snapshot. The first one to get committed will live on while the other(s) get garbage collected
so in the end things work out, but regardless of this it's wasted work. The real issue is that while unpack
should be pretty cheap on Linux, the opposite is true for the Windows and lcow formats. Kicking off
10 parallel pulls of the same image brings my 6 core machine to a halt and pushes 100% cpu utilization.
What all of this ends up causing is exponentially slower parallel pull times for images that either share layers,
or just pulling the same image.
I'm not sure if this is a "sound" way to approach this, or if there's possibly a much easier way to go about this change. I tried
to model it in a way that wouldn't disrupt things from a clients perspective, so the logic lives in the metadata snapshotter
layer. The gist of this change is if a new RemoteContext option is specified, the snapshotter now keeps track of what active
snapshots are "in progress". Any other snapshots that call Prepare with the same key as a snapshot that is already in progress
will now simply wait for one of two things to occur.

The first active snapshot it's waiting on gets removed via Remove (so it was never committed). For this case there
was likely an error during setup for the first snapshot/unpack, so any waiters continue as normal for this branch and create a new snapshot.
First active snapshot gets committed and will notify any snapshots currently waiting that commit has succeeded and
we can simply exit (as the layer now exists, so no need to create a new snapshot+unpack again). ErrAlreadyExists is returned from
all of the snapshots waiting to let the client know that there's already a snapshot that exists with this content.

Below are some numbers from testing this fix vs. Containerd built from main.:
Single Pull With This Commit
PS C:\Users\dcanter\Desktop\ctrd> $a=1..1 | %{start-job {C:\Users\dcanter\Desktop\ctrd\crictl.exe pull cplatpublic.azurecr.io/nanoserver_many_layers:latest}}; $a | wait-job | receive-job; $a | %{$.psendtime-$.psbegintime} | % totalseconds
Image is up to date for sha256:f86afbf779d83cf5aa2cc8377ea0b9f1cea140de22e1189270634d3a8ca4cf0e
23.2647532
PS C:\Users\dcanter\Desktop\ctrd> .\crictl.exe rmi cplatpublic.azurecr.io/nanoserver_many_layers:latest
Deleted: cplatpublic.azurecr.io/nanoserver_many_layers:latest
10 Parallel Pulls With This Commit
PS C:\Users\dcanter\Desktop\ctrd> $a=1..10 | %{start-job {C:\Users\dcanter\Desktop\ctrd\crictl.exe pull cplatpublic.azurecr.io/nanoserver_many_layers:latest}}; $a | wait-job | receive-job; $a | %{$.psendtime-$.psbegintime} | % totalseconds
Image is up to date for sha256:f86afbf779d83cf5aa2cc8377ea0b9f1cea140de22e1189270634d3a8ca4cf0e
Image is up to date for sha256:f86afbf779d83cf5aa2cc8377ea0b9f1cea140de22e1189270634d3a8ca4cf0e
Image is up to date for sha256:f86afbf779d83cf5aa2cc8377ea0b9f1cea140de22e1189270634d3a8ca4cf0e
Image is up to date for sha256:f86afbf779d83cf5aa2cc8377ea0b9f1cea140de22e1189270634d3a8ca4cf0e
Image is up to date for sha256:f86afbf779d83cf5aa2cc8377ea0b9f1cea140de22e1189270634d3a8ca4cf0e
Image is up to date for sha256:f86afbf779d83cf5aa2cc8377ea0b9f1cea140de22e1189270634d3a8ca4cf0e
Image is up to date for sha256:f86afbf779d83cf5aa2cc8377ea0b9f1cea140de22e1189270634d3a8ca4cf0e
Image is up to date for sha256:f86afbf779d83cf5aa2cc8377ea0b9f1cea140de22e1189270634d3a8ca4cf0e
Image is up to date for sha256:f86afbf779d83cf5aa2cc8377ea0b9f1cea140de22e1189270634d3a8ca4cf0e
Image is up to date for sha256:f86afbf779d83cf5aa2cc8377ea0b9f1cea140de22e1189270634d3a8ca4cf0e
25.3406896
25.1486873
25.0266887
24.8586885
24.7116929
24.5726943
24.4816912
24.375693
24.250694
24.1176895
PS C:\Users\dcanter\Desktop\ctrd> .\crictl.exe rmi cplatpublic.azurecr.io/nanoserver_many_layers:latest
Deleted: cplatpublic.azurecr.io/nanoserver_many_layers:latest
10 Parallel Pulls With Containerd Built Off Main (No Windows defender exclusion on data directory):
PS C:\Users\dcanter\Desktop\ctrd> $a=1..10 | %{start-job {C:\Users\dcanter\Desktop\ctrd\crictl.exe pull cplatpublic.azurecr.io/nanoserver_many_layers:latest}}; $a | wait-job | receive-job; $a | %{$.psendtime-$.psbegintime} | % totalseconds
Image is up to date for sha256:f86afbf779d83cf5aa2cc8377ea0b9f1cea140de22e1189270634d3a8ca4cf0e
Image is up to date for sha256:f86afbf779d83cf5aa2cc8377ea0b9f1cea140de22e1189270634d3a8ca4cf0e
Image is up to date for sha256:f86afbf779d83cf5aa2cc8377ea0b9f1cea140de22e1189270634d3a8ca4cf0e
Image is up to date for sha256:f86afbf779d83cf5aa2cc8377ea0b9f1cea140de22e1189270634d3a8ca4cf0e
Image is up to date for sha256:f86afbf779d83cf5aa2cc8377ea0b9f1cea140de22e1189270634d3a8ca4cf0e
Image is up to date for sha256:f86afbf779d83cf5aa2cc8377ea0b9f1cea140de22e1189270634d3a8ca4cf0e
Image is up to date for sha256:f86afbf779d83cf5aa2cc8377ea0b9f1cea140de22e1189270634d3a8ca4cf0e
Image is up to date for sha256:f86afbf779d83cf5aa2cc8377ea0b9f1cea140de22e1189270634d3a8ca4cf0e
Image is up to date for sha256:f86afbf779d83cf5aa2cc8377ea0b9f1cea140de22e1189270634d3a8ca4cf0e
Image is up to date for sha256:f86afbf779d83cf5aa2cc8377ea0b9f1cea140de22e1189270634d3a8ca4cf0e
134.416318
134.2893209
134.1643238
134.027323
133.8813211
133.7333303
133.5593271
133.4253269
133.2963282
133.1643288
10 Parallel Pulls With Containerd Built Off Main (With Windows defender exclusion on data directory):
PS C:\Users\dcanter\Desktop\ctrd> $a=1..10 | %{start-job {C:\Users\dcanter\Desktop\ctrd\crictl.exe pull cplatpublic.azurecr.io/nanoserver_many_layers:latest}}; $a | wait-job | receive-job; $a | %{$.psendtime-$.psbegintime} | % totalseconds
Image is up to date for sha256:f86afbf779d83cf5aa2cc8377ea0b9f1cea140de22e1189270634d3a8ca4cf0e
Image is up to date for sha256:f86afbf779d83cf5aa2cc8377ea0b9f1cea140de22e1189270634d3a8ca4cf0e
Image is up to date for sha256:f86afbf779d83cf5aa2cc8377ea0b9f1cea140de22e1189270634d3a8ca4cf0e
Image is up to date for sha256:f86afbf779d83cf5aa2cc8377ea0b9f1cea140de22e1189270634d3a8ca4cf0e
Image is up to date for sha256:f86afbf779d83cf5aa2cc8377ea0b9f1cea140de22e1189270634d3a8ca4cf0e
Image is up to date for sha256:f86afbf779d83cf5aa2cc8377ea0b9f1cea140de22e1189270634d3a8ca4cf0e
Image is up to date for sha256:f86afbf779d83cf5aa2cc8377ea0b9f1cea140de22e1189270634d3a8ca4cf0e
Image is up to date for sha256:f86afbf779d83cf5aa2cc8377ea0b9f1cea140de22e1189270634d3a8ca4cf0e
Image is up to date for sha256:f86afbf779d83cf5aa2cc8377ea0b9f1cea140de22e1189270634d3a8ca4cf0e
Image is up to date for sha256:f86afbf779d83cf5aa2cc8377ea0b9f1cea140de22e1189270634d3a8ca4cf0e
69.4417718
69.2987744
69.1677747
69.0297754
68.8907764
68.7397799
68.5937793
68.4547814
68.3187812
68.1597841
Signed-off-by: Daniel Canter<EMAIL_ADDRESS>

I was setting this option in cri/exposing a cri containerd config file option for this but when cherry-picking from my branch off of containerd main it obviously edits the files in the vendor folder, so those will have to be against our cri fork.
https://github.com/dcantah/containerd/commit/6afa1f44faa4c293817e342d46505c25367e698d#diff-aa93a573c4370577a5f289e1ea286f3c0bab4f880d6a00657023b49b34a3bc31R139
For where it's being set ^.

@ambarve @katiewasnothere @msscotb @anmaxvl @kevpar


Minor fixes on doc of function csr_tocsc

Reference issue

What does this implement/fix?

Function csr_tocsc has parameter Bi, which is listed as Bj in the doc. Fixing it so it's constant.
Additional information

@seraphalo  Thanks for your first SciPy contribution!


Add rule to complain about list comprehension in call to list()

I wrote this change anticipating it will need to be rebased on #55.

Yeah, I agree. That phrasing is better. I have updated the commit with suggested changes.

Thanks for the review. I have tweaked the phrasing as recommended.

Merged in 71498f1fb165970b5e71b9d66f387bf31d4ef97d, thanks!

Released as 1.4.0: https://pypi.python.org/pypi/flake8-comprehensions


Remove dashboard json header

[ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
[ ] Update the CHANGES log.

@smartboy37597 I have asked @kezhenxu94 to check what happens on the CI, most likely due to volume space issues.
Your PR should be good once that geta fixed.


Authorization broken?

The code in this repository no longer seems to work, perhaps because of recent fixes to the way it authenticates. When I run it and try a barcode in the web form, I get this error :
<IP_ADDRESS>:38020 [500]: /inc/fetch_labels.php - Uncaught InvalidArgumentException: Required option not passed: "access_token" in /home/ldeck/newlabeltest/WMS-Labeling/vendor/league/oauth2-client/src/Token/AccessToken.php:62
Stack trace:
#0 /home/ldeck/newlabeltest/WMS-Labeling/vendor/league/oauth2-client/src/Provider/AbstractProvider.php(746): League\OAuth2\Client\Token\AccessToken->__construct(Array)
#1 /home/ldeck/newlabeltest/WMS-Labeling/vendor/league/oauth2-client/src/Provider/AbstractProvider.php(544): League\OAuth2\Client\Provider\AbstractProvider->createAccessToken(Array, Object(League\OAuth2\Client\Grant\ClientCredentials))
#2 /home/ldeck/newlabeltest/WMS-Labeling/inc/fetch_labels.php(89): League\OAuth2\Client\Provider\AbstractProvider->getAccessToken(Object(League\OAuth2\Client\Grant\ClientCredentials), Array)
#3 {main}
thrown in /home/ldeck/newlabeltest/WMS-Labeling/vendor/league/oauth2-client/src/Token/AccessToken.php on line 62

Hi Larry.
Unfortunately I am not able to replicate this problem. Can you please verify that you have valid settings (WSKEY, secret, etc.) in the config.php file?
Thanks
Jonahlyn

Thanks for responding. I do have WSKEY and secret set in config.php.
I notice that config no longer has pricipalID/principalIDNS. which I thought were necessary for using those APIs. Is that deliberate?

Did not intend to close, sorry.

Yes the removal of the principleID/principalIDNS was deliberate.
Can you compare the contents of the config.php.template with your config.php and make sure you have all the required settings in there?
You may also want to log in to OCLC's developer site and check that the WSKEY isn't expired.

The WSKEY is okay -- API explorer and Postman both work find with the key, as does an earlier version of your app that we have had running since September. Apart from the principalID/principalIDNS absent from the new one, there doesn't seem to be any difference.
The API explorer for WMS Collection Management API still asks for principalID/principalIDNS if you use "my credentials". Maybe this has yet to be updated? Maybe older keys require it but not newer ones? I'm a loss.

Unfortunately, I am also at a loss. I changed our config.php on a test system to an invalid WSKEY and did receive the same error message you are seeing. It sounds like you have a valid key though. I'm not sure. You may have to open a ticket with OCLC if you haven't already. Good luck.

Thanks for your attention, I'm having the same problem with OCLC's new "gists", so I'll open a ticket with them and see if they can figure it out.

We got the very same problem. I opened a ticket with OCLC and got that answer :

"Your WSkey did not have a default user associated with it. I've added this so it should work with the Label application now"

It solved our problem.

Okay, thanks.

Thank you. I am having this same issue. Will follow @nicalico 's steps above.


Copy of UCBVI from rlberry_research to rlberry_scool and misc changes to doc

add quick starts in user guide
add UCBVI in scool
Update quick start accordingly. Objective user guide rlberry-research-free.
Checklist

[x] My code follows the style guideline
To check :
black --check examples rlberry *py
flake8 --select F401,F405,D410,D411,D412 --exclude=rlberry/check_packages.py --per-file-ignores="init.py:F401",
[ ] I have commented my code, particularly in hard-to-understand areas,
[x] I have made corresponding changes to the documentation,
[ ] I have added tests that prove my fix is effective or that my feature works,
[x] New and existing unit tests pass locally with my changes,
[x] If updated the changelog if necessary,
[x] I have set the label "ready for review" and the checks are all green.

Just a styling comment: maybe you could use toctrees instead of markdown links for user guide. Example:
```{toctree}
examples/content_child1.md
examples/content_child2.md

LGTM for most of it. I did not review the quick start @AdrienneTuynman can you review this?
The idea is to make comments either here or using the "Files changed" tab of the PR, based on what you see in the preview of the documentation that can be found here: https://rlberry-py.github.io/rlberry/preview_pr


HOL 4  students are running out of disk quota

students are running out of quota when performing the LABs.
Changing the App Service plan to B1 solves it..

It may be instructional to have them upgrade it to a standard instance (which we would need in the instructions), or maybe we should just provision shared or standard instances.  Unfortunately we won't know when they'll run out of quota.

Updated to B1 rather than Free, will update ARM Template today


Don't import classes that are not visible from the bootstrap classloader.

Just cosmetics.

Coverage remained the same at 80.207% when pulling f63bdaf1eedbc55bab91423c3ee16eb1bbc94e54 on ubschmidt2:imports into 2b145b3d37549c37b6846fe6f3a736cb4e11c669 on census-instrumentation:master.

Codecov Report

Merging #782 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #782      +/-   ##
============================================
- Coverage     78.26%   78.24%   -0.03%
  Complexity      825      825
============================================
  Files           151      151
  Lines          3663     3663
  Branches        346      346
============================================
- Hits           2867     2866       -1
  Misses          725      725
- Partials         71       72       +1

Impacted Files
Coverage Δ
Complexity Δ

...census/implcore/trace/export/SpanExporterImpl.java
96.66% <0%> (-1.67%)
7% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b145b3...f63bdaf. Read the comment docs.


[stable/rabbitmq-ha] feature: nginx ingress api version compatibility

@steven-sheehy
What this PR does / why we need it:
It brings api version capabilities detection for ingress in order to make the chart compatible with kubernetes 1.17+.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

This chart has been deprecated and is no longer maintained. It is recommended to use the Bitnami maintained RabbitMQ chart which has a similar feature set, including high availability. Thanks!

/close


Improve readme

Description
Make small improvements to readme with a demo gif.

For contributor use:

[ ] Targeted PR against master branch
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work
[ ] Code follows the standards mentioned here
[ ] Updated relevant documentation
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Added appropriate labels

Codecov Report

Merging #343 (6363996) into master (af649fd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #343   +/-   ##
=======================================
  Coverage   52.99%   52.99%
=======================================
  Files          36       36
  Lines        1802     1802
=======================================
  Hits          955      955
  Misses        729      729
  Partials      118      118

Flag
Coverage Δ

unittests
52.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af649fd...6363996. Read the comment docs.


How would you debug in vscode?

Just wondering what is the best approach to debug using vscode?
Should I just run npm run build https://github.com/preboot/angular2-webpack/issues/93  and debug dist by running live-server or something or there is a better way?

What you mean with debug in here? Because build will create your production build and with debug I think about development.

Ah OK my bad so how would you debug anyway.

Wrong person to ask, I survive with console.logs and that is definitely not the way to go :/
Better if you ask in SO or other sites, because I cannot be of any help.

Get bored by console.log..
Was trying to use this thing https://github.com/Microsoft/vscode-chrome-debug but no look I think because of webpack. Haven't dig much in to that after all.
Then looked in to this one http://schempy.com/2016/01/19/angular2_webpack_typescript/ but not working for me when trying to set breakpoints in chrome as mentioned in article.

Will take a peek at both and if I get something interesting, I could update the README here.

Cool. Checkout my update above.


fix(cache/in-memory): add hoisted_role field to CachedMember

this isn't sent in GuildMemberUpdate and I was wondering if we should be self calculating there because a member's roles can be changed there

We should probably not store this field, and instead calculate it on-demand through an InMemoryCache::member_hoisted_role method. It's not incredibly useful if it may be inaccurate, IMO.

alright, will update this in accordance to that. thanks :)

is this ready for review?


Can't link current branch to the PR

Type: Bug

Fork a repo.
Create issue in fork.
Use Development secion in Issue Web UI to create branch.
Apply provided git commands locally.
Make changs and commit.
Recieve comments on PR https://github.com/partcad/pre-commit/pull/12#pullrequestreview-2499027883
Use pr.checkoutByNumber
Check Output > GitHub Pull Request for errors.

Extension version: 0.100.3
VS Code version: Code 1.95.3 (f1a4fb101478ce6ec82fe9627c43efbf9e98c813, 2024-11-13T14:50:04.152Z)
OS version: Windows_NT x64 10.0.19045
Modes:
Remote OS version: Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2
Remote OS version: Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

System Info

Item
Value

CPUs
AMD Ryzen 9 3900X 12-Core Processor             (24 x 3793)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabledwebnn: disabled_off

Load (avg)
undefined

Memory (System)
15.91GB (1.92GB free)

Process Argv
--crash-reporter-id 828c2b46-e47b-405a-9312-09a86750d998

Screen Reader
no

VM
0%

Item
Value

Remote
Dev Container: Skyline CLI Dev Container @ desktop-linux

OS
Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

CPUs
AMD Ryzen 9 3900X 12-Core Processor (24 x 0)

Memory (System)
7.71GB (2.90GB free)

VM
0%

Item
Value

Remote
Dev Container: Python 3 @ desktop-linux

OS
Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

CPUs
AMD Ryzen 9 3900X 12-Core Processor (24 x 0)

Memory (System)
7.71GB (2.90GB free)

VM
0%

A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805:30301674
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
962ge761:30959799
pythonnoceb:30805159
pythonmypyd1:30879173
h48ei257:31000450
pythontbext0:30879054
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
dvdeprecation:31068756
dwnewjupyter:31046869
nativerepl2:31139839
pythonrstrctxt:31112756
nativeloc2:31192216
cf971741:31144450
iacca1:31171482
notype1cf:31157160
5fd0e150:31155592
dwcopilot:31170013
stablechunks:31184530

I still can see PR comments in Read Only mode, but it does not help much:

⬢ [Docker] ❯ git remote --verbose
origin  https://github.com/partcad/pre-commit.git (fetch)
origin  https://github.com/partcad/pre-commit.git (push)
upstream        https://github.com/mrgoonie/cmai.git (fetch)
upstream        https://github.com/mrgoonie/cmai.git (push)

My initial guess is that it's because the branch is deleted.
Can you set the default log level of GitHub Pull Request to trace (command: "Developer: Set Log Level", choose GitHub Pull Request, then use the double checkmark to set the default log level)

And try to reproduce the issue again?

Thanks for suggestion. It happens only with one project so far, I work on it once in week, will provide more details next time I work on it.


how should major releases of polkadot affect semantic capi releases?

Currently we target polkadot version 0.9.31 with the expectation that capi will always support the latest release of polkadot. What is the impact of upgrading polkadot in Capi wrt to semantic releases.
For example if I as a user am using Capi 1.0.0 and we are targeting polkadot 0.9.31, and we upgrade polkadot to 0.10, would this trigger a major release of Capi since users on the 1.x.x semantic release have "locked in" polkadot version 0.9.x?

Capi tries to be as chain-independent as possible. Right now our tests are pinned to polkadot version 0.9.31, but there's no reason that capi itself can't be used with polkadot 0.9.36, or 0.9.30.

The main reason we pin our tests is that we snapshot various things like metadata etc. and we don't want that changing arbitrarily when capi devs happen to install new versions of polkadot.

right makes sense we don't have a dependency on polkadot anywhere except the example/test code.


Incremental build for validator docker image

This diff changes build time from 40 to few minutes for incremental change, which is incredibly valuable during triage

@bors-libra r=kphfb
cc @sausagee I think this change should be safe for nightly build CI, but just in case letting you know its there

:pushpin: Commit 243f535 has been approved by kphfb

:hourglass: Testing commit 243f535e0c0b2ff2a3f23e64e516524ff4a3b609 with merge 78cebe8f79341d4b92bde932f6e77952eee29d42...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: kphfb
Pushing 78cebe8f79341d4b92bde932f6e77952eee29d42 to master...

@andll: This breaks CI, and is not the right way to do docker images (as was previously discussed a few months ago). Please revert this and we can discuss the options for this specific use case.

@sausagee fixed CI build.
What is specific concern you currently have?

CI is only fixed because it's using copies of the old docker files in libra-ops for now. It needs to be switched back and will break again at that point. My objections are the same as the last time this was discussed. Please revert and we can discuss how to approach this.

I agree we need to reuse same docker files in ci - will need to find a way to achieve that
Having incremental build was crucial in last investigation, I am not comfortable reverting this diff on the grounds of “this is not proper way of doing things” without having concrete solution to incremental build problem
On Oct 14, 2019, at 12:16 PM, Michael Gorven<EMAIL_ADDRESS>wrote:

CI is only fixed because it's using copies of the old docker files in libra-ops for now. It needs to be switched back and will break again at that point. My objections are the same as the last time this was discussed. Please revert and we can discuss how to approach this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/libra/libra/pull/1296?email_source=notifications&email_token=AAWVVQK2C3ZUDD7BMVNLNLDQOTAPFA5CNFSM4I76VLAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBGDYMY#issuecomment-541867059, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAWVVQKAQ2YWSGRF6TZ6FI3QOTAPFANCNFSM4I76VLAA.


Add capacity to reuse matrix for other nlin prob.

This PR adds the capacity to reuse the matrix on a subsequent non-linear
problem as long as the matrix is considered to be sufficiently valid. This greatly speeds-up time-stepping scheme that have multiple stages such as the SDIRK ones.

It looks good to me! Why is the CI not working for dealii:master? Why was it suddenly cancelled?

Good question, I will re-run it


Bump Dependencies #5740486391

Bumps dependencies for product-is. Link : https://github.com/wso2/product-is/actions/runs/5740486391

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jenkins-is-staging seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


[Bug]: Significant scalability bottlenecks at high throughput due to coarse-grained locking

What happened?
There are several spots in the critical (streaming) bundle execution path that serialize execution of all threads.  Importantly are:

ExecutionStateSampler.add/removeTracker
ProxyInvocationHandler.as
DoFnSignatures.getSignature
ByteBuddyDoFnInvokerFactory.getByteBuddyInvokerConstructor

A JFR recording of a typical streaming load shows this:

These functions should be optimized to not require a coarse-grained lock when executing.
Issue Priority
Priority: 2
Issue Component
Component: runner-core

.take-issue
.remove-labels 'awaiting-triage'

.take-issue

I think the above two PRs handled this, should we close this now?

.close-issue


RDO-2121: Bootstrap process requires yum to have proxy defined early

This makes sure the proxy is configured in /etc/yum.conf before packages get installed using yum


Fix pool registration rollback

Issue Number

#1200
Overview

commit 18852c0d1aadbd9e4c47dadad2043f516aba3a55
modify rollback property to capture the rollback in-within epoch problem. It now fails

commit 3a4d4fd317b9a8813613ee5491408285d340e4d2
store registration with full slot and not only epoch to allow correct rollback!
This is however a DB breaking change which requires migration...
Yet, there's no way to migrate from an existing database to this new
schema. Since however this is a preferable solution and, re-syncing
the pools data is cheap, we'll simply discards any existing database
that has an invalid format and, resync from scratch :)

commit f21f4e3bc39606e5be6d8cf7dc2f30057968d192
add a regression test to show that migration from an old database doesn't work out of the box
Currently fails with:
PersistError
Database migration: manual intervention required.
The unsafe actions are prefixed by '***' below:
CREATE TEMP TABLE \"pool_registration_backup\"(\"pool_id\" VARCHAR NOT NULL,\"slot\" INTEGER NOT NULL,\"margin\" INTEGER NOT NULL,\"cost\" INTEGER NOT NULL, PRIMARY KEY (\"pool_id\"));
INSERT INTO \"pool_registration_backup\"(\"pool_id\",\"margin\",\"cost\") SELECT \"pool_id\",\"margin\",\"cost\" FROM \"pool_registration\";
*** DROP TABLE \"pool_registration\";
CREATE TABLE \"pool_registration\"(\"pool_id\" VARCHAR NOT NULL,\"slot\" INTEGER NOT NULL,\"margin\" INTEGER NOT NULL,\"cost\" INTEGER NOT NULL, PRIMARY KEY (\"pool_id\"));
INSERT INTO \"pool_registration\" SELECT \"pool_id\",\"slot\",\"margin\",\"cost\" FROM \"pool_registration_backup\";
DROP TABLE \"pool_registration_backup\";"

commit 440e09930daa229264aead7236e46ca5f34bda71
handle migration error in stake pool db layer
As described in the previous commit.

commit 112927be39e03376707b1b3ed0a9b9d61ce64535
better assertions on logs message for db migration tests

Comments

bors r+

bors r+

Nix failed on stylish haskell job :man_shrugging: ... re-running manually...


Update semver dependnecy

https://github.com/Meteor-Community-Packages/check-npm-versions/blob/82d1f751533dcc5a3b564b22ea170b92d2ecd303/package.js#L10
Now that IE is no longer an issue we can update semver.

Hey there, I'd like to work on this issue!
Just to clarify, do I need to remove this line, or do I need to update it with the latest version of IE?

@Akshu-on-github please read the OP again, it looks like you don't understand what I'm talking about here.
semver can be updated because Internet Explorer is no longer supported and hence a blocker for update.
@Akshu-on-github do you know Meteor?

@StorytellerCZ https://github.com/Meteor-Community-Packages/check-npm-versions/pull/53


How to register Hive with GetIt?

Question
Please explain the problem you are running into.
Code sample
Provide a few simple lines of code to show your problem.

Version

Platform: iOS, Android, Mac, Windows, Linux, Web
Flutter version: [e.g. 1.5.4]
Hive version: [e.g. 0.5.0]

You can use the method registerSingletonAsync, like in this example
getIt.registerSingletonAsync<ConfigService>(() async {
    final configService = ConfigService();
    await configService.init();
    return configService;
  });

Providing support for integration with other packages is out of scope of hive project. Please try posting your question on Q&A forms or communities like stackoverflow or local flutter communities.


typescript error: Property '_id' is optional in type '' but required in type 'BaseSchema'

I'm trying to use papr with typescript but I'm getting a weird error that does not make any sense to me!
Just to make sure I wasn't doing anything wrong, I just tried the example in the home page:
import { MongoClient } from 'mongodb';
import Papr, { schema, types } from 'papr';

const papr = new Papr();

const connection = await MongoClient.connect('mongodb://localhost:27017');
papr.initialize(connection.db('test'));

const User = papr.model('users', schema({
  age: types.number(),
  firstName: types.string({ required: true }),
  lastName: types.string({ required: true }),
}));

await papr.updateSchemas();

const johnWick = await User.find({ firstName: 'John', lastName: 'Wick' });

But when I type-check this code, I get:

Argument of type '[{ age?: number; _id?: ObjectId; firstName?: string; lastName?: string; }, SchemaOptions<{ age: number; firstName: string; lastName: string; }>]' is not assignable to parameter of type '[BaseSchema, SchemaOptions]'.
Type at position 0 in source is not compatible with type at position 0 in target.
Type '{ age?: number; _id?: ObjectId; firstName?: string; lastName?: string; }' is not assignable to type 'BaseSchema'.
Property '_id' is optional in type '{ age?: number; _id?: ObjectId; firstName?: string; lastName?: string; }' but required in type 'BaseSchema'.

Which is weird, because when I looked at the code for the schema function, it's actually adding the _id field to the schema. But I added _id: types.objectId({ required: true }) to the schema anyway and this time I got:

Argument of type '[{ age?: number; _id?: ObjectId; firstName?: string; lastName?: string; }, SchemaOptions<{ _id: ObjectId; age: number; firstName: string; lastName: string; }>]' is not assignable to parameter of type '[BaseSchema, SchemaOptions<{ _id: ObjectId; age: number; firstName: string; lastName: string; }>]'.
Type at position 0 in source is not compatible with type at position 0 in target.
Type '{ age?: number; _id?: ObjectId; firstName?: string; lastName?: string; }' is not assignable to type 'BaseSchema'.
Property '_id' is optional in type '{ age?: number; _id?: ObjectId; firstName?: string; lastName?: string; }' but required in type 'BaseSchema'.

So even when I explicitly added a required _id field, I still got the typescript error.
what should I do?
thanks

Hi!
Have you enabled strictNullChecks option in the TypeScript configuration?

I just enabled it and the issue was totally fixed. Thanks.


issues/1188: support for multiple User-Agents per layout provider

Fixes #1188

Thank you very much, @sbespalov ! :)

Hi @sbespalov,
This PR should have included an automated test. I have the feeling that it's not working as expected.


Generate mavlink.h header file

From home dir:
git clone --recursive https://github.com/mavlink/mavlink.git
cd mavlink
sudo apt install python-pip
pip2 install future
export PYTHONPATH=/usr/local/lib/python2.7/dist-packages:/home/rohan/mavlink
Run command
rohan@penguin:~/mavlink$ python -m pymavlink.tools.mavgen
usage: mavgen.py [-h] [-o OUTPUT]
[--lang {C,CS,JavaScript,Python,WLua,ObjC,Swift,Java,C++11}]
[--wire-protocol {0.9,1.0,2.0}] [--no-validate]
[--error-limit ERROR_LIMIT]
XML [XML ...]
mavgen.py: error: too few arguments

What are the steps and where are the generated files installed ?
Thanks

This is not related to mavlink-router... but you are missing some arguments, run pymavlink/tools/mavgen.py --help but you should use something like this:
pymavlink/tools/mavgen.py -o generated/ --lang C --wire-protocol 2.0 message_definitions/v1.0/standard.xml


cache isn't working via npm install behind proxy

Hi, I'm trying to setup npm_lazy on corporate server ( runs on centOS ) but without any luck.
I've configured the proxy settings in config file.
When I run npm_lazy:
[root@ITAP11 ~] npm_lazy -c ./npm_lazy.config.js
app info npm_lazy at <IP_ADDRESS> port 9000
app info npm_lazy cache directory: /root/.npm_lazy
app info Using http://<IP_ADDRESS>:3128 to proxy http requests.
app info Using https://<IP_ADDRESS>:3128 to proxy https requests.

now when i run npm install --registry http://localhost:9000 lodash
this is what I get:
npm http 502 http://localhost:9000/lodash
npm ERR! registry error parsing json
npm ERR! SyntaxError: Unexpected token <
npm ERR! <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">
npm ERR! <html><head>
npm ERR! <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
npm ERR! <title>ERROR: The requested URL could not be retrieved</title>
npm ERR! <style type="text/css"><!--
npm ERR!  /*
npm ERR!  Stylesheet for Squid Error pages
npm ERR!  Adapted from design by Free CSS Templates
npm ERR!  http://www.freecsstemplates.org
npm ERR!  Released for free under a Creative Commons Attribution 2.5 License
npm ERR! */
...
...
npm ERR! System Linux 2.6.32-431.5.1.el6.centos.plus.x86_64
npm ERR! command "node" "/usr/bin/npm" "i" "--registry" "http://localhost:9000/" "lodash"
npm ERR! cwd /root/tmp
npm ERR! node -v v0.10.25
npm ERR! npm -v 1.4.6
npm ERR! type unexpected_token
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     /root/tmp/npm-debug.log
npm ERR! not ok code 0

but when I run request via wget, it works and correctly saves package to ~/.npm_lazy/
wget http://localhost:9000/lodash
any ideas?
thanks in advance

This is all well and good until you install a package like imagemin. Which brings in pngquant, which goes to github via https and cannot download stuff.
⚠ connect ETIMEDOUT
⚠ jpegtran pre-build test failed
ℹ compiling from source
⚠ connect ETIMEDOUT
⚠ optipng pre-build test failed
ℹ compiling from source
⚠ Request to https://raw.github.com/imagemin/pngquant-bin/v3.0.0/vendor/linux/x64/pngquant failed
⚠ pngquant pre-build test failed
ℹ compiling from source
⚠ connect ETIMEDOUT
⚠ gifsicle pre-build test failed
ℹ compiling from source
✖ Error: connect ETIMEDOUT
at errnoException (net.js:904:11)
at Object.afterConnect [as oncomplete] (net.js:895:19)
✖ Error: connect ETIMEDOUT
at errnoException (net.js:904:11)
at Object.afterConnect [as oncomplete] (net.js:895:19)
✖ Error: connect ETIMEDOUT
at errnoException (net.js:904:11)
at Object.afterConnect [as oncomplete] (net.js:895:19)
✖ Error: connect ETIMEDOUT
at errnoException (net.js:904:11)
at Object.afterConnect [as oncomplete] (net.js:895:19)
I am afraid it is not possible to run npm_lazy on localhost because of the utterly stupid way npm handles requests to localhost. There is not a single use-case in this quadrant of our galaxy where requests to localhost aka <IP_ADDRESS> is supposed to be sent off to a proxy.


Run sbws with all supported python versions

As we commented by email, i will run sbws with python 3.4, 3.5, 3.6 to check possible errors.

i will note the versions running in https://github.com/pastly/simple-bw-scanner/wiki/Existing-sbws-infrastructure

Done


Update Chinese translation

Well, I'm glad I finally understand the "LoadErrorMajorVersionMismatch"......

Maybe it's helpful if you join our chat? I mean, if changes keep coming you keep updating the translation files which is kind of tedious. It would be much better to just to it at the end no?

也许如果你加入我们的聊天会有帮助吗？我的意思是，如果不断变化，你会不断更新翻译文件，这有点乏味。到最后没有它会好得多吗？

Yup, but I don't know what to do. Pull request is the quickest way I can think of.

Maybe it's helpful if you join our chat? I mean, if changes keep coming you keep updating the translation files which is kind of tedious. It would be much better to just to it at the end no?

Yup, but I don't know what to do. Pull request is the quickest way I can think of.

Thanks again for being very diligent with this.

Yup, but I don't know what to do. Pull request is the quickest way I can think of.

What I meant is, waiting before translating because we keep adding new strings

What I meant is, waiting before translating because we keep adding new strings

Well, no problem. Just notify me before the new version is released.


Improve the Supported Operating Systems Documentation

[ ] Disclaimer that Linux is the primary targeted system.

Obsolete.


Fifa 19 crashes during loading with an error message

Fifa 19 crashes during loading with this error message:

System specifications:
GPU: AMD HD 8750M 2gb vram
Driver: Mesa 21.1.4 - AMDVLK v-2021.Q3.1
OS: Linux Mint 20.2 Cinnamon
Linux Kernel: 5.11.0-22
vkd3d-proton 2.4

I changed the title because the game crashes the same way if I use DX11 or DX12.

AMDVLK is not even being used, because you dropped support for my GPU.


SAA-2104 BCI and LTI preprod

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.02%. Comparing base (3b45e26) to head (6656c4c).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1091   +/-   ##
=========================================
  Coverage     83.02%   83.02%
  Complexity     3698     3698
=========================================
  Files           385      385
  Lines         12694    12694
  Branches       1084     1084
=========================================
  Hits          10539    10539
  Misses         1671     1671
  Partials        484      484

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Replace int and addr by num_bigint

For several reasons, the use of num_bigint over i64 (int) and usize (addr) should be considered in Tokay. This should bypass any memory limitations and concentrate on Tokay's main topic, parsing and working with parsed data. Python uses a similar approach for its int values, and Tokay is considered as a toolbox on parsing, not an incredibly fast parsing method.

Fixed by #55


Provide default child_spec/1 for Raft.StateMachine

Provides sane default for child_spec/1, but overridable
Ensures default config for state machine uses a data_dir which is
unique per-node, and per-name

This was one of the things that caught my eye when I was reimplementing a distributed process registry like Swarm on top of raft - when running multiple nodes via iex, the same default data_dir is used for all nodes and all state machines. In addition, I needed to provide a child_spec for the process, even though there is only one way to run it (start_peer). I implemented more or less this child_spec in my own application, but there is really nothing special about it at all, it should probably be the default and only overridden in those cases where one has a good reason to, rather than forcing everyone to implement the same child_spec in every state machine.
This provides an easy way to add state machines to a supervisor, it's just {MyModule, []} and it will automatically be started as a peer under the supervisor on boot. It also ensures that there is no friction with running multiple nodes locally for testing and development, and supports multiple state machines in the same project as well.
I probably should update the docs as part of this PR, but wanted to get your feedback first.

All of this looks really reasonable to me. I had originally not done this because I wasn't sure what api we wanted to use. I wasn't sure if it made more sense to use start_link instead of start_peer.
Right now we're starting the raft peers (the log process and the raft fsm process) under the PeerSupervisor. The PeerSupervisor is a child of the raft dynamic supervisor. I've wondered if it makes more sense to start the PeerSupervisor in the users supervision tree. We could accommodate that with our child_spec. My thinking is that it would give users more control over how they structure their supervision trees, but maybe thats not necessary.

You know what, I had completely overlooked PeerSupervisor. In any case, my personal preference would be to have the user manage where in their own supervisor tree to put this stuff, since they may want to deal with failure in their own way, start things conditionally, etc. Not that you can't do that with just calling Raft.start_peer wherever, but it's not as clear to me where that would happen, and it loses the benefit of being explicit about how and when things are started and what happens if things crash.
If more than one thing need to be started in concert (as you mentioned, the FSM and the log process), then perhaps the solution is to direct users to do something like so under their own supervisor tree:
children = [
  {Raft.PeerSupervisor, [peer: MyRaftFSM, peer_args: args | opts]},
]

The assumption is that PeerSupervisor in this case isn't a DynamicSupervisor, but a standard :one_for_one or :one_for_all supervisor. So one starts a supervisor for the pair (and by pair I mean log/FSM processes), passes in the callback module for the state machine, arguments for that state machine, and any other options for the supervisor (if needed). That spec is just a rough draft, but hopefully you get what I'm going for there.
You get the benefit then of knowing exactly where in your supervisor tree this stuff lives, and how it will deal with failure, and removes that responsibility from raft. We could still use the child_spec I've defined here, it would just be used now by Raft.PeerSupervisor when it constructs the child spec for the FSM process.

I agree that it would be nice for users to define their own supervision strategies.
What if we provided a start_link and child_spec in the state machine use macro that defaulted to the Raft.PeerSupervisor? If a user had something like:
defmodule MyApp.Stack do
  use Raft.StateMachine
end

Then they would only need to do:
children = [
  MyApp.Stack,
]

In their own supervision tree. Under the hood it can start the Raft.PeerSupervisor with any arguments that they need to pass in. What do you think? Are we saying the same thing?

Even better, we're on the same page :) - I'll push an update to this that makes that change

I've updated the PR with the changes we discussed. I think this is nicer for sure. I also added a bit to the README to describe how to set it up under supervision. The only piece there that may need some clarification would be where to introduce Raft.set_configuration/2 in that setup, but I know configuration is still a bit up in the air.

This looks great :tada:
I'm looking at the specific test failure and I think I see the bug. I'll open a separate issue for it.

Thanks! Sorry I disappeared for a few days, been a busy week :)


[WIP][Layer] add "add layer"

added "add layer", and it supports calc-derivative and calc-gradient
func with "weight layer".
added a "model unit test" for add layer, but "model unit test" were
disabled for a long time in NNTrainer. Enabling it causes some errors
now, so I need further debugging(So it's still in WIP)

Self evaluation:

Build test:   [ ]Passed [X]Failed [ ]Skipped
Run test:     [ ]Passed [X]Failed [ ]Skipped

Signed-off-by: Seungbaek Hong<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2709. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2709-202408161553130.91382193565369-5b48e779156b8fefe59e453faec470e4e29654a0/report/.

Sorry, I'll verify it and make a new commit..


[v4] new data on the first page will result in the last element disappearing from the list on revalidate*

Describe the bug
For starters - this is maybe a feature request / maybe a bug.
It was certainly unexpected behaviour when starting using the library, but it makes sense looking at the internals.
This bug will results on: When an API orders from most recent, to last. Using fixed page size pagination. After a revalidate. If a new resource is created. an Element will be lost from the list even though it may still be present on the database / server.
Scenario:
I have an API starting ordering from newest to most recent "0".
GET /resources?pageSize=20
(Give records: 2021, 2021, 2020, 2019, ...etc)
I'm using useInfiniteQuery starting from page 0. I compute the cursor for the next page using the last valid result:
Cursor is computed as: 2001
GET /resources?pageSize=20&afterCursor=2001
this will give me: 2000, 1999, etc..., 1981
When a new entry is generated - the revalidation checks the first page first:
GET /resources?pageSize=20
Which will now start on 2022, 2021, 2020... 2002
Next cursor is now 2002 instead of 2001 so the API will cut-off at 1982
If the user was looking at the record: 1981 - this will no longer be on the list.
This seems to be occurring because the revalidate process finishes at (what I think is arbitrarily) the same number of pages as what we had before.
It would be useful to have a configuration to control the process beyond just turning it on/off- allowing me to - say - ensure I stop at on, or after the first page including 1981..
Your minimal, reproducible example
https://codesandbox.io/s/strange-sea-j67vbs
Steps to reproduce

Load the initial data set
Load more (using the "load older" button)
Click "Add newer content to store"
Click away from the iframe (unfocus)
Refocus.

Actual: The last element on the list will dissappear / is no longer visible
Expected behavior
I should still have the last element on the list
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform
All
react-query version
3.39.2
TypeScript version
No response
Additional context
I believe all the necessary context was added.

I think you didn't save the sandbox because there is no Add newer content to store button, but I think I get the problem.
I don't think that refetching should add new pages, and I also don't think that the cutoff is arbitrary. The problem is more around an api using fixed-sized pagination together with dynamic cursors. I am not sure how we would technically solve this problem in react-query. What would be your proposal on how to customize this?

Hey Tk - thanks - sorry I've updated the link.
The problem will also occur with numbered pagination provided the page size is fixed and the underlying data results are ordered newest => latest.
I can create another example with number pagination if it helps demonstrate that.
Adding some suggested fixes on the next comment:

Allowing me to control the condition that decides when to stop fetching pages.
For instance converting this for loop into a while loop - with a dynamic condition that defaults to the existing default.

Current:
From: https://github.com/TanStack/query/blob/main/packages/query-core/src/infiniteQueryBehavior.ts:130
Proposed (idea) - rather than chaining promises in a for loop - you could have promises that fired up new promises internally based on whether you should fetch the next page.
That way you could then check all the oldPages data and newPages data, as well as currentPage index on a user-configurable function that will determine the ending point.
By default - that function would resolve when the currentPage index is the last index (to match the existing behaviour)

(...more proposals being added)

Making the whole revalidate a user configurable option (granted - this is probably too much to require from consumer developers).

Default to always keeping the last value on re-validation: This will require users to provide a comparison function that would determine if the results are before or after the last element.
For example: hasReachedElement(page, oldLastElement): boolean  - if configured - this would automatically keep revalidating until the function is true (in my example code- the hasReachedElement would compare the last element of the revalidated apge, with the numerical value of the oldLastElement with a >= indicator - and check the page length being empty.

I think this is would be awesome for me - but is likely too opinionated for this framework.
Alternatively, I totally understand if this doesn't seem like a problem you'd rather tackle.

We already have something similar for imperative refetches like queryClient.refetchQueries. You can pass a refetchPage filter to decide if a certain page should be refetched or not:
// only refetch the first page
queryClient.refetchQueries({
  refetchPage: (_page, index) => index === 0,
})

We don't have this for automatically triggered refetches like window focus because it would be difficult to customize (it would need to go on useInfiniteQuery or something).
But again, the hard cutoff here is the current amount of pages. Adding another, similar way to determine when refetching should stop seems kinda complicated and we'd have two ways to configure this then?
However, I'm not totally in love with the current api. refetchQueries et al have this refetchPage filter, but it only works on infinite queries, which is not nice, api wise. Also, as stated, it doesn't work for window focus refetching.
So long story short: If we can come up with an api that we can maybe pass as new option to useInfiniteQuery that would:

keep the same default behaviour (refetch all currently existing pages)
still allow me to easily say things like "only fetch the first page"
allows for better control of when to stop refetching, potentially based on previous results so that we could also fetch more pages than we previously had

we could think about adding this to the next major in favour of the refetchPage filter option. Thoughts?

@myxoh what do you think about my proposal? If you'd want something like that, can you provide ideas on how the api could look? We are currently thinking about the next major version and if we should do something in this regard - now would be the time to discuss it. Otherwise, I'll likely close this issue. Thanks.

@myxoh we've started working on v5, so if we'd want to change something api wise - now would be the time.

Hi @TkDodo appreciate - not sure if I should close but I've sort of dropped cognitive load from this given we've ended up going with a different solution.
I do think a new option for useInfiniteQuery that allows for better control seems like a good way of solving this particular problem!
I'm sorry I've not been of much help here

yeah, not sure either. we've removed refetchPage in v5 for a maxPage option. Maybe this can help in this case as well.


Add bot.reply

Within a callback you can use this.reply which will send the message to either the room or the person depending on the type of event.
For instance, if the callback is triggered by onMessage, this.reply('test') will send the message to the room.
If the callback is triggered by onPrivateMessage, this.reply('test') will send the message to the person.

This can be re-opened when we find a better solution.


ci: set up mdbook deployments

There should be CI-driven mdbook deployments to https://uips.penumbra.zone ; the Celestia configs for github actions will be a useful reference https://github.com/celestiaorg/CIPs/tree/main

Resolved by #7, site is now serving: https://uips.penumbra.zone.


fix(provider): fix working with opensearch

Signed-off-by: serge-r<EMAIL_ADDRESS>fix(dashboard): change default index to .kibana
fix(index): fix defaults
fix(indextemplate): fix depracated functions, fix tests
fix(ism_policy): fix path to ism_policy
Description
By https://github.com/opensearch-project/terraform-provider-opensearch/pull/16 - reduce amount of changes
PRs Related
https://github.com/opensearch-project/terraform-provider-opensearch/pull/16
Issues Related
https://github.com/opensearch-project/terraform-provider-opensearch/issues/39
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Anyone looking at these merge requests? I would like to add this in for OS 2.x.x myself

@phillbaker @prudhvigodithi @peterzhuamazon @jackson-theisen Any chance moving this forward to allow 2.x support?

Hey thanks @serge-r and everyone for the patience, I will look at this PR and will sure give an update by end of this week, meanwhile @serge-r the CI unit tests fail with this PR can you please take a look?
Thank you

adding these changes would break the 1.x OpenSearch compatibility (as you can already see the CI tests fail)

Agreed that main should target compatibility with 2.x opensearch and we can cut a branch for 1.x updates. We can tag and release updates to 1.x from that branch if necessary. Was the 1.3.x mention for something specific, or was that just an example?

does this short PR enough for 2.x.x compatibility?

Let's please add tests for 2.x to the test matrix so that we can answer this question using the test suite.

fix(dashboard): change default index to .kibana

This actually seems like a bug in 1.x from https://github.com/opensearch-project/terraform-provider-opensearch/pull/17, the internal index name is still .kibana and not .dashboard.

PR released to repo branching https://github.com/opensearch-project/terraform-provider-opensearch/pull/43, once merged I will proceed to create a 1.x branch.
@phillbaker @serge-r @bbarani @peterzhuamazon please check.
Thank you

PR related to repo branching #43, once merged I will proceed to create a 1.x branch. @phillbaker @serge-r @bbarani @peterzhuamazon please check. Thank you

Merged the PR and created a new 1.x branch https://github.com/opensearch-project/terraform-provider-opensearch/tree/1.x. This PR even though it breaks 1.x should be fine as merging to main should be good with 2.x releases. WDYT @phillbaker @serge-r ?

No. Please do not merge this PR - the tests are not passing. Even if it breaks API compatibility, every PR should pass the test suite.

Closing this PR, please check the latest PR that has all the support for 2.x https://github.com/opensearch-project/terraform-provider-opensearch/pull/62.
Thank you


AMME complex

Hi,
I can't locate this  term, or the ticket.  I searched on various combinations of  AMMECR1/ AMME etc. I think somebody called Lionel submitted the ticket? and I know you @dosumis  handled it.
It must have been called something else in the end, but I can't think what?
Any ideas?

Midori found it for me.  She's amazing :)


Enable MCUX_PIT with multiple pit channels

Enable MCUX_PIT with multiple pit channels

@EmilioCBen, please update west.yml to pull the latest changes for this PR.

@EmilioCBen, please update west.yml to pull the latest changes for this PR.

Updated!

another minor thing is the migration guide info about the changes to the binding/kconfig should probably be in the same commit as the changes

another minor thing is the migration guide info about the changes to the binding/kconfig should probably be in the same commit as the changes

Updated

Needs converting to hwmv2

Should be resolved now

@henrikbrixandersen please revisit

@nordic-krch can you please visit this PR, you're assignee

Merging as @nordic-krch +1 was removed when we updated the manifest to point to the merged HAL side.


maybe use of virtual dom will improve $digest performance

https://github.com/teropa/angular-virtual-dom
this is the lib I found, will try to evaluate it and if possible use it with this lib, but because this is your project, could you take a look if possible to use your lib with virtual dom.

From the author's readme:

angular-virtual-dom supports extensibility using directives - though only with directives that are Virtual DOM aware. That means angular-virtual-dom is not a drop-in substitute for the AngularJS directive compiler, and is meant to be used in limited contexts.

That makes it unusable in a general scenario. vs-repeat is a drop-in plugin (in most cases) and should stay that way


DOI: connect with DataCite API to allow for minting of DOI when item is deposited or PURL is reserved

Design Doc: https://docs.google.com/document/d/16zGrIpRgGkq8d4VDUjEstoB2p8xFEuiAmKJopcT1CaQ/edit#heading=h.qx3okipoxiy5
DOIs will be minted at the following times, depending on collection-level settings and Depositor selections (see below):

when the user clicks "Deposit" for the standard workflow or
when the user clicks "Submit" on the "Reserve a PURL" modal.

All minted DOIs should use the following:

prefix: 10.25740
suffix: [item druid]

DOI states

For the standard workflow, DOIs will be minted with complete metadata and the state "Findable."
For the "Reserve a PURL" workflow, DOIs will be minted using only the PURL address and the state "Draft." Once the deposit is completed, the DOI will be updated with the complete metadata and the state "Findable."
We will not be using the "Registered" state option.

Consider the possibility that if we follow the scheme of always using the same prefix and always using the druid as the suffix, we can tell people what the DOI will be without any actual interaction with DataCite, and save all contact with DataCite until the deposit is complete. That would make this step much simpler.


Version of GitBash is not detected correctly

Shell version detection did not work if BASH_VERSION included syntactically relevant symbols, e.g. parenthesis:
/bin/bash: -c: line 0: syntax error near unexpected token `('
/bin/bash: -c: line 0: `echo 5.0.17(1)-release'

I do not know how to replicate the bug, really. You would have to trick Bash into spitting out a problematic version string. Mine does that of its own accord.
It should detect the version as major=5 and minor=0.
Environment:

Python version: irrelevant
Click version: 8.0.3

Duplicate of #2461


Flair support

A configurable option to force the link to have a Flair must be in place. In our case we need this set by default to true.
This means, that if a user wants to post a Link MUST use one of the valid flair available in the reddit channel.

A command to list all the available flairs on the subreddit should be added too, otherwise users will be unaware of them.

In our case we need this set by default to true.

We can deal with this kind of conditions through the configuration file.

Sure thing, feel free to add the command you prefer in order to list them. You may return an initial list when you start to use the bot ( basically before you login ).
This may also speed up the user to actually post them.
Would also be nice that the bot does not post, if the Flair is not in the list.


db.Query does not always expand the parameter

What version of Go are you using (go version)?

$ go version
go version go1.14 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
+:( $ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/wolf/.cache/go-build"
GOENV="/home/wolf/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY="go.showmax.cc"
GONOSUMDB="go.showmax.cc"
GOOS="linux"
GOPATH="/home/wolf/go"
GOPRIVATE="go.showmax.cc"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/wolf/tmp/trigger_test/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build944301925=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Using the pq adapter (github.com/lib/pq) and database/sql I've tried dropping a table:
_, err := db.Query("DROP TABLE $1", "test")
if err != nil {
panic(err)
}

Documentation ( https://godoc.org/database/sql#DB.Query ) does not suggested that this should not work.
What did you expect to see?
panic: pq: table "test" does not exist

What did you see instead?
panic: pq: syntax error at or near "$"

it seems better report to github.com/lib/pq ~_~

Maybe you should  try
db.Query(DROP TABLE $1, "test")
and it seems better report to  github.com/lib/pq

Maybe you should try
db.Query(DROP TABLE $1, "test")
and it seems better report to github.com/lib/pq

`DROP..

Ok, I did not know how this exactly works and who is responsible for it. I'll open bug report on lib/pq instead.


Authentication on headless setups

Would be nice if API-token could be provided as argument to "cvemap -auth". Would simplify headless or unattended scenarios.

would be nice if auth token could be provided as argument instead/as well

Does use an environment variable like export PDCP_API_KEY=xxx satisfy your needs?

I'm actually using the Windows binary. but can only run non-interactive scripts remotely.
Can probably set a environment variable, but it would be way easier with cvemap -auth <token>

Does use an environment variable like export PDCP_API_KEY=xxx satisfy your needs?

@Co5mos Yes, this also lets you use cvemap without 401 error.

I was able to utilize psexec to get into the right securitycontext interactively, closing this, but the environment variable didnt seem to work for Windows anyhow


Implement a Social Sign On/Social Login solution

Hey guys,
Do you think it's a good idea to implement a Social Login alternative?
I'm keen to work on this if you agree it worthwhile to be added to the project.
To avoid being just another complexity we could add it as optional. If the keys (for the integration) were provided it will be enabled. By default it will be disabled.

In my opinion, it's not a good idea to implement a "Social Login" feature because in Symfony apps it's much more complicated than it should be. It's not something to be proud and it's not something we should show.
But let's wait to hear more opinions about this.

Social login should have its own demo.

@bocharsky-bw Registering an OAuth application requires providing a callback URL. So we cannot create one valid for all people running the demo.
Thus, we should not provide the application secret in the repo (this would go against the goal of the demo of showing best practices), making it hard to enable it out of the box

@stof What about OAuth callback URL, bin/console server:run always runs on http://<IP_ADDRESS>:8000 by default, but you're right, we probably can't rely on users hoping they won't change this URL. And agree about application secret.

In my humble opinion this is not a good idea because the purpose of the demo is only to present the good practices with simple basics.

Could not find package symfony/symfony-demo with stability stable in a version installable using your PHP version 7.0.21.
Could you update it to the latest php 7.0.XX

@XPanel You can tweak this version in composer.json manually, see config.platform.php value, but this project should be compatible with5.5.9. Or are you trying to install symfony/symfony-demo as a dependency with composer require?

Let's close this as "won't fix" because of its technical complications and because this feature is not the strongest suit of Symfony. Thanks!


Update actions with dependabot

Configure @dependabot to update actions.
https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot
Refs: #340

Fixed by #342


harbor_project proxy_cache

Allow creation of proxy_cache project. For now this option is not available through terraform provider.
Sample :
resource "harbor_project" "project" {
  name                   = var.project_name
  public                 = false
  vulnerability_scanning = true
  proxy_cache_endpoint = "https://<IP_ADDRESS>"
}

Hello @HSoulat,
did you try : https://github.com/goharbor/terraform-provider-harbor/blob/main/docs/resources/project.md#harbor-project-example-as-proxy-cache ?


studio.asyncapi.com only supports version 2.2.0

Describe the bug
I am trying to edit an older async api yaml file that is based on Version 2.0.0 of the specification
this is failing because the editor only allows 2.2.0 to be used.
How to Reproduce
Open any file that is not based on the 2.2.0 specification

Expected behavior
The editor should either support older standards, clearly define that it doesn't and (if that's the route to go) provide hints on what to do in these situations.

@DJGummikuh Hello! We have bug with that info about unsupported 2.0.0 version but it's still supported, trust me :)
As I see in the "file preview" on the right side of the editor you have errors in your spec (check that red section at the bottom of your spec). You should click on the terminal section (at the bottom of the editor) to see errors and fix them:

We should definitely not underline 2.0.0 with yellow saying Value is not accepted as it is misleading. It already prevented me from digging further for what are the other reasons to not render my document, cause if the version is not supported, why bother

Also, leaving this comment from @DJGummikuh for the record: https://twitter.com/DJGummikuh/status/1488110968508928000. Looks like two different bugs? 🤔

@fmvilas If you have broken 2.0.0 spec you cannot make conversion. Converting 2.0.0 -> 2.2.0 is just a version change but still, it is not good to make conversion invalid spec and even if we will make it 2.2.0 will be still invalid.

My issue is that the entire Document is simply red
I have no clue what exactly causes it and the marker at the bottom is also kinda unspecific :D

Why does this error (about unsupported 2.0.0) occur? A single instance of the Editor (Monaco editor) can accept a single JSON Scheme for validation. We can say that we have two validations (on the side of the editor itself to show the description of each fields, autocomplete etc) and on the side of our ParserJS. The problem is that the user can change the spec version in the editor at any time and how to check such a change? Of course we can transform raw input to the JSON and check "asyncapi" field but it will worsen the optimization of the whole validation process - for small specs no but for some big ones yes. Therefore, currently the JSON Scheme change for the editor only happens when the spec is valid. This is not a perfect solution but it is a faster solution. The best solution would be to pass the JSON Scheme to the editor with all supported specs, using oneOf, but we need to change the paths for #/definitions because each spec version has a separate definitions (we can't merge them). I will try handle that in this week.

nah the first spec is only parts, I was copying around to findout what's causing it. The red element was because I had a ref to the lower part of the document (which I didn't copy in). The issue is somewhere in the payload I guess..
I de-corporated (stupid NDAs..) the file and will provide it her:
`asyncapi: '2.0.0'
info:
title: Some software transmission results API
version: '1.0.0'
description: |
Some software publishes messages containing status information for each individual file that is processed. There is one virtual topic for every job in Some software. The topic names follow the pattern: VirtualTopic.Somesoftware.transmissionresults. where 'job-id' is the id of one specific job.
contact:
name: "Some software Team"
email: "mailgroupSome software@Some Company.de"
servers:
mosquitto:
url: https://en-Somesoftware-demo.SomeCompany.de:8800
protocol: JMS
description: Some software demo system (AcitveMQ Port - 8800 is not exposed yet)
channels:
VirtualTopic.Somesoftware.transmissionresults.job-id:
publish:
description: "On this topic Some software publishes status information for each individual file that is processed by the job with the id 'job-id'."
message:
$ref: "#/components/messages/statusMessage"
components:
messages:
statusMessage:
summary: "Data transfer object of the status message"
description: "JSON deserialized dto containing status information of one processed file."
payload:
type: object
properties:
status:
type: string
description: "The status of the processed file."
enum:
- FAILURE
- SUCCESS
fileName:
type: string
description: "The name of the processed file."
examples:
- "file1.txt"
traceId:
type: string
description: "Unique Id for logging purposes."
examples:
- "424c2d6c-f04b-441a-add8-bed071f6b27b"
detectionTime:
type: long
description: "The time the file was detected by Some software (format: UNIX Epoch time in ms)."
examples:
-<PHONE_NUMBER>000
eventTime:
type: long
description: "The time when the message was sent (format: UNIX Epoch time in ms)."
examples:
-<PHONE_NUMBER>000
targetLocationId:
type: string
description: "The id of the target location the file should be transmitted to."
examples:
- "Location 1"
failureType:
type: string
description: "Type of failure. Only available if the status is 'FAILURE'."
enum:
- reception-failure
- internal-failure
- transmission-failure
remainingRetries:
type: integer
description: "Number of remaining retries. A value of 0 means that there are no more retry attempts and the file is moved to the 'failed' directory of the job. Only available if the status is 'FAILURE'."
minimum: 0`

@DJGummikuh Thanks very much! Yeah, it's weird that you have invalid two schemas and whole spec is marked as invalid. I will check that, because probably it's not a problem on the Studio side but on the ParserJS side - studio only consumes the output from ParserJS () and marks that sections which are invalid by info from parser.
I updated your spec. First of all, you have invalid format of the info.contact.email field. You should fix it and also you used long type in two schemas. In JSON Schema we have only types: string, boolean, number, integer (you can use it for long), array, object and also null - others are invalid:
There is a valid spec:
asyncapi: '2.0.0'
info:
  title: Some software transmission results API
  version: '1.0.0'
  description: |
    Some software publishes messages containing status information for each individual file that is processed. There is one virtual topic for every job in Some software. The topic names follow the pattern: VirtualTopic.Somesoftware.transmissionresults.<job-id> where 'job-id' is the id of one specific job.
  contact:
    name: "Some software Team"
    email<EMAIL_ADDRESS>
servers:
  mosquitto:
    url: https://en-Somesoftware-demo.SomeCompany.de:8800
    protocol: JMS
    description: Some software demo system (AcitveMQ Port - 8800 is not exposed yet)

channels:
  VirtualTopic.Somesoftware.transmissionresults.job-id:
    publish:
      description: "On this topic Some software publishes status information for each individual file that is processed by the job with the id 'job-id'."
      message:
        $ref: "#/components/messages/statusMessage"

components:
  messages:
    statusMessage:
        summary: "Data transfer object of the status message"
        description: "JSON deserialized dto containing status information of one processed file."
        payload:
          type: object
          properties:
            status:
              type: string
              description: "The status of the processed file."
              enum:
                - FAILURE
                - SUCCESS
            fileName:
              type: string
              description: "The name of the processed file."
              examples:
                - "file1.txt"
            traceId:
              type: string
              description: "Unique Id for logging purposes."
              examples:
                - "424c2d6c-f04b-441a-add8-bed071f6b27b"
            detectionTime:
              type: integer
              description: "The time the file was detected by Some software (format: UNIX Epoch time in ms)."
              examples:
                -<PHONE_NUMBER>000
            eventTime:
              type: integer
              description: "The time when the message was sent (format: UNIX Epoch time in ms)."
              examples:
                -<PHONE_NUMBER>000
            targetLocationId:
              type: string
              description: "The id of the target location the file should be transmitted to."
              examples:
                - "Location 1"
            failureType:
              type: string
              description: "Type of failure. Only available if the status is 'FAILURE'."
              enum:
                - reception-failure
                - internal-failure
                - transmission-failure
            remainingRetries:
              type: integer
              description: "Number of remaining retries. A value of 0 means that there are no more retry attempts and the file is moved to the 'failed' directory of the job. Only available if the status is 'FAILURE'."
              minimum: 0

We originally built this file using this editor so it must have worked some time in the past.
Yeah the e-mail error was because I Search and replaced our company and product name ^^ the original was a valid e-mail :D
Thanks for cleaning this up though, will give it a thorough look and try to figure out what went wrong!

@DJGummikuh No problem :) That issue will be closed when we fix that strange behaviour of unsupported 2.0.0 spec

@DJGummikuh the left one is your version of spec.
I guess, replacing long with integer worked

Yes I can confirm. I used a fresh copy, replaced long with integer and now it's working. However, the object type we use actually IS supposed to be long (ok in the json that we generate it makes no difference, but for java which is parsing it this is relevant). So while it's working now I wonder whether it is ok the way it is :thinking:


[New-Feature] Add 3rd party module support.

We should allow 3rd party applications to integrate with Mycontroller as modules.

Here is a tutorial of the whole idea.
http://www.javaworld.com/article/2077837/java-se/hello--osgi--part-1--bundles-for-beginners.html
Unfortunately i don't have so much experience in programming . If you could have a look and discuss afterwords would be nice.

@S0rc3r3r looks interesting...

@S0rc3r3r we are not going to support plugin type, as it leads huge memory consumption. But we can add new plugins with core module


Add C# editor and a mechanism to compile patches

This PR implementes a couple of things:

Integration with AvalonEdit (together with C#'s TextMate grammar for syntax highlighting)
Integration with Roslyn Workspaces (compilation of patches)
Added templating service for quick preparation of a "hello-world" like patch that user can immediately compile and add some logic. It should add most of the logic required by Harmony to correctly use / apply the patch.
Errors list / output view (displays diagnostics from compilation)

There are some failing tests. But I think this is due to fact that it seems Harmony does not work well with .NET Standard 2.0. For example, I am getting weird binding issues on .NET Framework. Might need to rework the managed part of the hook but overall it works, at least for .NET Core it seems OK.

We decided to skip .NET Framework support for now in favor of milestone 4 and Linux support


switch to fahrenheit?

Is not possible at the moment switch to fahrenheit mode for TH10/16 sensors, but it seems to be possible from mobile apps, so probably there's a param that could be added to get back temperature in fahrenheit instead of celsius?

I wasn't able to see a connection from the app to ewelink servers when switching from C to F.
So, my guess is that the temp units setting just converts celsius to fahrenheit at app level.
Would be possible to create a method who just reads the sensor in C and converts to F.


Stream search should use fuzzy search, not prefix-based search

From what I can tell, the stream search/filter functionality (accessed via the q key) uses a prefix-based search technique. However, this is frustrating because you have to make sure to type out the whole beginning of the stream name, which gets especially frustrating when streams have prefixes. Perhaps it could be changed to a fuzzy-match search?
An example: If you have these streams:

general
t-compiler
t-lang

then you should be able to find t-compiler by typing compiler, t-lang by typing lang (or just ang), and general by typing gnrl. Even if it only did fuzzy search at the level of "segments" (delineated by -, /, etc.), that would be a huge usability improvement for the Rust Zulip.

I will like to work on this issue.

Duplicate issue #19700 has been solved via #22253, which implements the strategy suggested in the issue description:

Even if it only did fuzzy search at the level of "segments" (delineated by -, /, etc.), that would be a huge usability improvement for the Rust Zulip.

Wonderful, thank you!


Sync fails when replica url has port

Describe the bug
When a port is added to the replica URL, the system breaks with an "invalid IP is not an IPv4 address". See below.
To Reproduce
Steps to reproduce the behavior:

What version of AdGuardHome sync used? v0.4.13 (2023-03-07T17:28:45Z)
What version of AdGuardHome us used? v0.107.27
How does the configuration look?

---
services:
  adguardhome-sync:
    image: ghcr.io/bakito/adguardhome-sync
    container_name: adguardhome-sync
    command: run
    environment:
      LOG_LEVEL: 'info'
      ORIGIN_URL: 'http://<IP_ADDRESS>:8800'
      ORIGIN_USERNAME: '*******'
      ORIGIN_PASSWORD: '*******'
      REPLICA_URL: 'http://<IP_ADDRESS>:8800'
      REPLICA_USERNAME: '*******'
      REPLICA_PASSWORD: '*******'
      CRON: '*/10 * * * *' # run every 10 minutes
      RUNONSTART: true
      API_PORT: 8080
    ports:
      - 8080:8080
    restart: unless-stopped

What is the error message?

adguardhome-sync  | 2023-04-12T16:24:31.404Z	INFO	sync	sync/sync.go:29	AdGuardHome sync	{"version": "v0.4.13", "build": "2023-03-07T17:28:45Z"}
adguardhome-sync  | 2023-04-12T16:24:31.404Z	INFO	sync	sync/sync.go:55	Setup cronjob	{"cron": "*/10 * * * *", "next-execution": "2023-04-12T16:30:00.000Z"}
adguardhome-sync  | 2023-04-12T16:24:31.404Z	INFO	sync	sync/http.go:52	Starting API server	{"port": 8080}
adguardhome-sync  | 2023-04-12T16:24:31.405Z	INFO	sync	sync/sync.go:65	Running sync on startup
adguardhome-sync  | 2023-04-12T16:24:31.564Z	INFO	sync	sync/sync.go:113	Connected to origin	{"from": "<IP_ADDRESS>:8800", "version": "v0.107.27"}
adguardhome-sync  | 2023-04-12T16:24:33.369Z	INFO	sync	sync/sync.go:198	Start sync	{"from": "<IP_ADDRESS>:8800", "to": "<IP_ADDRESS>:8800"}
adguardhome-sync  | 2023-04-12T16:24:33.497Z	INFO	sync	sync/sync.go:206	Connected to replica	{"from": "<IP_ADDRESS>:8800", "to": "<IP_ADDRESS>:8800", "version": "v0.107.27"}
adguardhome-sync  | 2023-04-12T16:24:35.056Z	INFO	client	client/client.go:472	Set dhcp server config	{"host": "<IP_ADDRESS>:8800"}
adguardhome-sync  | 2023-04-12T16:24:35.184Z	ERROR	sync	sync/sync.go:263	Error syncing dns	{"from": "<IP_ADDRESS>:8800", "to": "<IP_ADDRESS>:8800", "error": "400 Bad Request(bad dhcpv4 configuration: dhcpv4: invalid IP is not an IPv4 address\n)"}
adguardhome-sync  | github.com/bakito/adguardhome-sync/pkg/sync.(*worker).syncTo
adguardhome-sync  | 	/go/src/app/pkg/sync/sync.go:263
adguardhome-sync  | github.com/bakito/adguardhome-sync/pkg/sync.(*worker).sync
adguardhome-sync  | 	/go/src/app/pkg/sync/sync.go:186
adguardhome-sync  | github.com/bakito/adguardhome-sync/pkg/sync.Sync.func3
adguardhome-sync  | 	/go/src/app/pkg/sync/sync.go:66

Expected behavior
I expected a successful sync.

@mvdkleijn this has noting to do with the port in the replica URL.
It is caused by the dhcp sync feature, that is trying to sync dhcp config that is not configured.
this is fixed in https://github.com/bakito/adguardhome-sync/releases/tag/v0.4.14

Just to confirm (for others finding this): upgraded and works like a charm
Thanks!


Consider including browser files in NPM.

Would like to be able to use with npmcdn. You can set a browser field in package.json to point to your browser build. Currently, pointing to the index<EMAIL_ADDRESS>

I feel like I'm missing something on npmcdn.. With the default https://npmcdn.com/aframe-extras, or if I force it to https://npmcdn.com/aframe-extras/browser.js, it doesn't roll up the dependencies.. But if I try https://npmcdn.com/aframe-extras/dist/aframe-extras.js nothing is found. How does this work?

Oh, sorry didn't see. It doesn't find anything because it only has access to what is deployed on npm. Because the dists aren't currently being published, it won't find anything.

@ngokevin Hm, this doesn't seem feasible. The browser field is used by bundlers like Browserify too, at higher precedence than main, so if I set it to a minified build Browserify breaks. That appears to be intended behavior: https://github.com/defunctzombie/package-browser-field-spec
To do something like this, I think we'd probably need an A-Frame convention for special fields in package.json, or a convention for always naming output dist/npmcdn.min.js the same way.

I was able to tell Browserify to ignore it: https://github.com/ngokevin/aframe-component-boilerplate/blob/master/package.json#L9

Nice, but still what if someone wants to do npm install --save aframe aframe-extras? Can't really justify the change if it means broken or nonstandard Browserify/Webpack support.


Tutorial for “Download Any BAM File” vignette

There is a tutorial (on or pointed to from our “Guides” portal section) that a researcher can follow that will show them how to search and download data and perform some basic analysis. A great candidate for this is leveraging the “Download Any BAM File” vignette in a tutorial on our Data Portal site and including a very basic analysis example given some BAMs downloaded from HCA.

@natanlao Can you add this ticket to the Epic https://app.zenhub.com/workspaces/dcp-5ac7bcf9465cb172b77760d9/issues/humancellatlas/dcp/337.
I don't have permissions..

@theathorn Done!

We need content for a guide to this vignette added here: https://data.humancellatlas.org/guides/consumer-vignettes


RangeError when calling Bitmap.open with IO object

I'm attempting to open an image from an IO stream (File object in this case), but I get the following error:
RangeError: integer<PHONE_NUMBER>9240 too big to convert to int' 	from /Users/tomwardrop/.rvm/gems/ruby-2.1.5/gems/free-image-0.6.2/lib/free-image/sources/io.rb:78:in put_int32'
The cause is that a Ruby fixnum (which Ruby's Object#object_id returns) can be up to 62 bits, where as a C integer has a maximum length of 32 bits. I believe the following line needs to be changed to use a long instead of an int: https://github.com/cfis/free-image-ruby/blob/master/lib/free-image/sources/io.rb#L77

I made pull request #10 with a fix that works for me.

Fixed via your pull request.  Thanks!


Fix qemu-img segmentation fault error in tests

What this PR does / why we need it:
One of the tests was setting the memory limit for image verification to
a low value without restoring it afterwards. Therefore all the tests
executed later on were failing because of insufficient memory for
qemu-img.
There was a call to restore the test environemnt in the BeforeEach()
section. Though it needs to be called after the test.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
The offending test is disk verification should fail when the memory limit is too low:
https://github.com/kubevirt/kubevirt/blob/c9e87c4cb6292af33ccad8faa5fb9bf269c0fbf4/tests/container_disk_test.go#L150-L151
Probably it is the reason of regular failures in cgroupsv2 periodic:
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/periodic-kubevirt-e2e-k8s-1.20-cgroupsv2/1432267065804197888
https://github.com/kubevirt/project-infra/pull/1526
The test has [Serial] label and so all the other failed tests do. I assume that they were executed sequentaly with the modified memory limit.
The cgroupsv2 periodic was supposed to run all the tests therefore [sig-network] were mixed with [sig-compute] tests.
Release note:

NONE

@fgimenez , @vladikr , @iholder-redhat , FYI. Not yet 100% sure, but this seems to be the reason of memory issues with qemu-img in tests.

/test pull-kubevirt-e2e-k8s-1.20-cgroupsv2
Lets see.

Seems there are not more qemu-img segfaults in cgroupv2 lane.
/retest

@fgimenez , @vladikr , @iholder-redhat , FYI. Not yet 100% sure, but this seems to be the reason of memory issues with qemu-img in tests.

awesome great catch! I'll prepare an execution of the cgroupsv2 periodic from this branch and get back to you with the results.

Thanks @vasiliy-ul! Great work!
There was a call to restore the test environemnt in the BeforeEach()
section. Though it needs to be called after the test.

Can you explain this statement? Why does it matter if the cleaning is done before or after the test?
Also - is there a way to configure that cleaning will occur after EVERY test? Is there a reason not to perform cleaning after a test runs?

Yeah, that is a big problem. Probably some framework can be implemented to minimize potential issues but still Its always possible to make mistakes in tests. Unfortunately no silver boolet :(

The problem is that there exist still tests which use BeforeAll. Unless they are removed we can't just configure a global restore handler. See https://github.com/kubevirt/kubevirt/issues/6123.

/lgtm

I'll prepare an execution of the cgroupsv2 periodic from this branch and get back to you with the results.

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/periodic-kubevirt-e2e-k8s-1.20-cgroupsv2/1433336606130966528 no more qemu-img segmentation faults :+1: I'll prepare a PR to bring back the cgroupsv2 periodic once this one lands.

/lgtm

I'll prepare an execution of the cgroupsv2 periodic from this branch and get back to you with the results.

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/periodic-kubevirt-e2e-k8s-1.20-cgroupsv2/1433336606130966528 no more qemu-img segmentation faults  I'll prepare a PR to bring back the cgroupsv2 periodic once this one lands.

Awesome :) I still see two tests failing quite regularly. The one with Mediated device should probably be skipped. The other one - not sure yet... I noticed failures in other PRs as well. But probably I will take a look at it as well.

/lgtm

I'll prepare an execution of the cgroupsv2 periodic from this branch and get back to you with the results.

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/periodic-kubevirt-e2e-k8s-1.20-cgroupsv2/1433336606130966528 no more qemu-img segmentation faults  I'll prepare a PR to bring back the cgroupsv2 periodic once this one lands.

Awesome :) I still see two tests failing quite regularly. The one with Mediated device should probably be skipped. The other one - not sure yet... I noticed failures in other PRs as well. But probably I will take a look at it as well.

Let's skip the mediated devices test. Not sure why is it running there...

Let's skip the mediated devices test. Not sure why is it running there...

Added to skip-list in the presubmit https://github.com/kubevirt/project-infra/pull/1542 . Same will be needed for the periodic.

/approve
/hold
@vasiliy-ul I think we need to bring in #6350 together with this PR. Otherwise we have the issue that failed tests are collecting artifacts after the cleanup took place.

/unhold
I changed my mind.  We have other tests which do not collect in an optimal way. Let's fix the tests. The other PR will anyway land soon.

Just in case the change here (calling BeforeTestCleanup in AfterEach) causes any issue, its enough to restore only the KubeVirt config after the mentioned test. So it can be easily fixed. But lets try like it is now.

I'll prepare a PR to bring back the cgroupsv2 periodic once this one lands.

Proposed here https://github.com/kubevirt/project-infra/pull/1550


How to use class inheritance correctly

I am trying to create some modules that contains code that is reusable and I am trying to use class inheritance to do so.
for example
class Device:
    def __init__(self, device_id, **args):
      self._device_id = device_id
      self._name = args.get("name", device_id)
      self._domain = device_id.split(".")[0]
      self._friendly_name = args.get("friendly_name", self._name)
      self._brightness = args.get("brightness", 0)
      self._color_temp = args.get("color_temp", 0)
      self._group = args.get("group", None)

    def info(self):
        return f"Name: {self.name()}\nID: {self.device_id()}\nArgs: {self._args}"

class TestLight(Device):
    def __init__(self, device_id, **args):
        # super().__init__(device_id, **args)
        log.info(f"Creating TestLight with {args}")
        self._automation_device_id = None

    def turn_on(self, **kwargs):
        if self._domain == "light" or self._domain == "switch":
            self.call_service("turn_on", **kwargs)
            return True
        return False

    def turn_off(self, **kwargs):
        if self._domain == "light" or self._domain == "switch":
            self.call_service("turn_off", **kwargs)
            return True
        return False

    def call_service(self, action, **kwargs):
        # Placeholder for service call logic
        print(f"Calling service {action} with {kwargs}")

this then creates an error as the super seems to not work properly
Is there any way I can bypass this?

My workaround:
https://github.com/ALERTua/ha_pyscript_modules/blob/main/entities/switch.py#L5
its super:
https://github.com/ALERTua/ha_pyscript_modules/blob/main/entities/entity.py#L74

@ALERTua Yes I did something similar yesterday,
class TestLight(Device):
    def __init__(self, device_id: str, **args):
        Device.init(self, device_id, **args)
        if self.is_debug_enabled():
            log.debug(f"Creating light {device_id} with {args}")
        clean_args = self.clean_args(**args)
        self.set_args(**clean_args)
        self._attributes = LightAttributes(device_id)
        self._tiggers = []
        self.init(**args)

This is my approach, very similar
thanks

As you discovered, certain class features don't work properly in pyscript.  One specific challenge is that all functions in pyscript are async, including class methods you create.  That means that things like creating magic methods (eg, operator overloading) won't work, since python will expect those methods to be regular functions.  One workaround is to create the class using regular python with @pyscript_compile.

I would pin this issue for future generations and close it. Glad I helped.

I agree, I am satisfied with the solution I found and all works really well for me


interactivemap POI is not showing anything anymore

I was trying to update a room, and now the POI isn't showing anything and I can't see my room.

you're right! Rooms are there, but PoI list is empty..  Adam is working on the interactive map.. I've assigned to him. ;)

Fixed! =)


Compatibility with Nuke 7?

Since Nuke ~7 the example from the documentation (README.md; see below) doesn't work anymore since Nuke.Loader and Nuke.Manager are deprecated?
How to set the Alamofire loader with Nuke v7?
Thx
let loader = Nuke.Loader(loader: NukeAlamofirePlugin.AlamofireDataLoader())
let manager = Nuke.Manager(loader: loader, cache: Cache.shared)

manager.loadImage(with: url, into: imageView)

From reading Nuke's Documentation I unterstand what you need to do is the following:
`let pipeline = ImagePipeline {
$0.dataLoader = NukeAlamofirePlugin.AlamofireDataLoader()
$0.imageCache = ImageCache.shared
}
    ImagePipeline.shared = pipeline`

Thank you, @pkurzok. I updated the README.


Unhandled Runtime Error Error: Cannot find module '@chakra-ui/system'

Running into an error;
Call Stack
webpackMissingModule
<EMAIL_ADDRESS>(15:50)
eval
<EMAIL_ADDRESS>(15:142)
<EMAIL_ADDRESS>amongst other similar issues.
Is this common and is there an easy fix?
Thank you!

Did you install chakra?
https://chakra-ui.com/getting-started

Did you install chakra?
https://chakra-ui.com/getting-started

Installing Chakra via npm i @chakra-ui/react @emotion/react @emotion/styled framer-motion gives the same error.
Looks like Chakra needs React v18 but this project is using v17? May be completely wrong, I'm still trying to debug what is going on.

@oryan same issue here. Did you find a fix?

Looks like the following works:
npm config set legacy-peer-deps true
npm i


Storage Migration Services not showing up

Currently on the just released eval (1-22-19)  The extension itself is installed but I never get the storage migration services icon in admin center.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6614c040-d1c5-efb2-e29e-7cd93b3c9e55
Version Independent ID: f268e6ad-a69a-174d-0630-ad41aae0a9f1
Content: Migrate a file server by using Storage Migration Service
Content Source: WindowsServerDocs/storage/storage-migration-service/migrate-data.md
Product: windows-server-threshold
GitHub Login: @JasonGerend
Microsoft Alias: jgerend

So they don't make it clear.

Thanks for your dedication to our documentation. If we have been unable to review your issue in a timely manner, we sincerely apologize for the delayed response. We have captured the informtion you have provided for review. We are closing this issue for now, but if you feel that it's still a concern, please respond and let us know. If you determine another possible update to our documentation, please don't hesitate to reach out again. #please-close

#assign:IngridAtMicrosoft
gh issue comment 2252 -b #assign:IngridAtMicrosoft


Citation for the 2015-11-29 license update

Hey! great project!!
on your readme you mention Matthew Wickline updated the license to CC4-BY-SA on 2015-11-29, but the only mention of this I can find on the internet is right here on this repository!
Do you happen to have an original source for this update? we'd love to use this algorithm in a project of ours, and CC4-BY-SA is very doable but contacting a defunct resource network is not !!

http://colorlab.wickline.org/colorblind/colorlab/engine.js

Thank you so much, @michelf !!


Added Fullscreen image slider!

Simple but useful Full-Screen Image Slider
Poke @rafibomb

The preview image is too big. On the site, I can't tell that it's a slider :/ Can you adjust the image so it's more obvious that it's a slider? Other than that, this Building Block is looking good!

@IamManchanda Actually, I can update the image. Merging this now!

Just for reference this inspires from the below thing ( but with latest css (vh) and normal image tags instead of background fill hack )
=> https://blackrockdigital.github.io/startbootstrap-full-slider/
Now my question for you guys ( @rafibomb @kball @canterberrie )
Will it make sense to make an another slider that inspires from here
=> https://blackrockdigital.github.io/startbootstrap-half-slider/


Support customizing action label style in toastOptions

When I try to change my toaster's background color to this, the action label background will be too similar

Is there any options to customize action label background color?
If there is a plan for it, I would like to work on that!

Added in #214


Please add a LICENSE

I would like to use this library but it doesn't specify a license so maybe you can add one?
There is a good tutorial how to do this quickly on github: https://help.github.com/articles/adding-a-license-to-a-repository
Personally I prefer the BSD-3-Clause license for my projects but obviously thats up to you to decide :)

It's here: https://github.com/dchest/siphash#public-domain-dedication
I guess I should put it in LICENSE so that it would be easier to find, but I don't think GitHub recognizes CC0.