sudo crouton -u -n xenial failed to update

Please paste the output of the following command here: sudo edit-chroot -all
name: xenial
encrypted: yes, locked
Unmounting /mnt/stateful_partition/crouton/chroots/xenial
Here is the error statement: from sudo crouton -u -n xenial:
Extracting templates from packages: 100%
(Reading database ... 96993 files and directories currently installed.)
Preparing to unpack .../archives/apt_1.2.31_amd64.deb ...
Unpacking apt (1.2.31) over (1.2.29ubuntu0.1) ...
dpkg: error processing archive /var/cache/apt/archives/apt_1.2.31_amd64.deb (--unpack):
unable to stat './usr/bin/apt' (which I was about to install): Structure needs cleaning
dpkg-deb: error: subprocess paste was killed by signal (Broken pipe)
Processing triggers for libc-bin (2.23-0ubuntu11) ...
/sbin/ldconfig.real: /usr/lib/x86_64-linux-gnu/libapt-inst.so.2.0.0 is not an ELF file - it has the wrong magic bytes at the start.
Errors were encountered while processing:
/var/cache/apt/archives/apt_1.2.31_amd64.deb
E: Sub-process /usr/bin/dpkg returned an error code (1)
Failed to complete chroot setup.
Unmounting /mnt/stateful_partition/crouton/chroots/xenial..
Please describe your issue:
Can't update the xenial chroot.
First I downloaded the latest crouton and ran:
sudo install -Dt /usr/local/bin -m 755 ~/Downloads/crouton
If known, describe the steps to reproduce the issue:
Here are my system specs:
cat /etc/lsb-release
CHROMEOS_AUSERVER=https://tools.google.com/service/update2
CHROMEOS_BOARD_APPID={BABC2E82-8F7D-26E5-EE66-4C60A2B41DBC}
CHROMEOS_CANARY_APPID={90F229CE-83E2-4FAF-8479-E368A34938B1}
CHROMEOS_DEVSERVER=
CHROMEOS_RELEASE_APPID={BABC2E82-8F7D-26E5-EE66-4C60A2B41DBC}
CHROMEOS_RELEASE_BOARD=candy-signed-mp-v2keys
CHROMEOS_RELEASE_BRANCH_NUMBER=165
CHROMEOS_RELEASE_BUILDER_PATH=candy-release/R72-11316.165.0
CHROMEOS_RELEASE_BUILD_NUMBER=11316
CHROMEOS_RELEASE_BUILD_TYPE=Official Build
CHROMEOS_RELEASE_CHROME_MILESTONE=72
CHROMEOS_RELEASE_DESCRIPTION=11316.165.0 (Official Build) stable-channel candy
CHROMEOS_RELEASE_KEYSET=mp-v2
CHROMEOS_RELEASE_NAME=Chrome OS
CHROMEOS_RELEASE_PATCH_NUMBER=0
CHROMEOS_RELEASE_TRACK=stable-channel
CHROMEOS_RELEASE_VERSION=11316.165.0
DEVICETYPE=CHROMEBOOK
GOOGLE_RELEASE=11316.165.0

@mdwy62,
Haven't seen that myself but here are some suggestions:

reboot
Get into the chroot with enter-chroot and if it asks if you want to finish the setup let it try to do that.
Get into the chroot as root with enter-chroot -u root and run apt update then apt upgrade
Try updating your chroot again with sudo crouton -u -n xenial

Hope this helps,
-DennisLfromGA

Thanks Dennis. I tried all of these steps and at each one, I get the same error with apt_1.2.31_amd64.deb (below).
I had to use apt-get instead of apt for step 3.
Is there a way to delete this downloaded deb file to force it to retrieve it again? If it is corrupted in some way, it seems to keep trying to install the local copy.
dpkg: error processing archive /var/cache/apt/archives/apt_1.2.31_amd64.deb (--unpack):
unable to stat './usr/bin/apt' (which I was about to install): Structure needs cleaning
dpkg-deb: error: subprocess paste was killed by signal (Broken pipe)
Processing triggers for libc-bin (2.23-0ubuntu11) ...
/sbin/ldconfig.real: Cannot mmap file /usr/lib/x86_64-linux-gnu/libapt-inst.so.2.0.0.
Errors were encountered while processing:
/var/cache/apt/archives/apt_1.2.31_amd64.deb
E: Sub-process /usr/bin/dpkg returned an error code (1)

There is some problem with /usr/bin/apt:
xenial)root@localhost:/usr/bin# cd ./apt
-su: cd: ./apt: Structure needs cleaning

Just documenting that there are earlier errors after sudo crouton -u -n xenial, about "no such file or directory"
After this operation, 155 kB of additional disk space will be used.
apt-extracttemplates: error while loading shared libraries: libapt-inst.so.2.0: cannot open shared object file: No such file or directory
debconf: apt-extracttemplates failed: No such file or directory
Extracting templates from packages: 32%apt-extracttemplates: error while loading shared libraries: libapt-inst.so.2.0: cannot open shared object file: No such file or directory
debconf: apt-extracttemplates failed: No such file or directory
Extracting templates from packages: 65%apt-extracttemplates: error while loading shared libraries: libapt-inst.so.2.0: cannot open shared object file: No such file or directory
debconf: apt-extracttemplates failed: No such file or directory
Extracting templates from packages: 98%apt-extracttemplates: error while loading shared libraries: libapt-inst.so.2.0: cannot open shared object file: No such file or directory
debconf: apt-extracttemplates failed: No such file or directory
Extracting templates from packages: 100%
(Reading database ... 96993 files and directories currently installed.)
Preparing to unpack .../archives/apt_1.2.31_amd64.deb ...
Unpacking apt (1.2.31) over (1.2.29ubuntu0.1) ...
dpkg: error processing archive /var/cache/apt/archives/apt_1.2.31_amd64.deb (--unpack):
unable to stat './usr/bin/apt' (which I was about to install): Structure needs cleaning
dpkg-deb: error: subprocess paste was killed by signal (Broken pipe)
Processing triggers for libc-bin (2.23-0ubuntu11) ...
/sbin/ldconfig.real: Cannot mmap file /usr/lib/x86_64-linux-gnu/libapt-inst.so.2.0.0.

@mdwy62,

Is there a way to delete this downloaded deb file to force it to retrieve it again? If it is corrupted in some way, it seems to keep trying to install the local copy.

You may be able to remove it from: /var/cache/apt/archives/apt_1.2.31_amd64.deb
But that may leave you out on a limb.
I think I would first rename /var/cache/apt/archives/apt_1.2.31_amd64.deb to something else then download it from here:

http://mirrors.kernel.org/ubuntu/pool/main/a/apt/apt_1.2.31_amd64.deb

And install it with dpkg -i apt_1.2.31_amd64.deb
Also, if you can install aptitude (with sudo apt-get install aptitude) try updating & upgrading with it instead.
If you can't get it that way then maybe download it from here:

http://mirrors.kernel.org/ubuntu/pool/main/a/aptitude/aptitude_0.7.4-2ubuntu2_amd64.deb

and install it with dpkg per above.

That 'Structure needs cleaning' error looks pretty serious. Hopefully re-installing apt will remedy it, otherwise, you may have to remove or rename /usr/bin/apt before you can move forward.
Hope this helps,
-DennisLfromGA

Thanks again, Dennis.
I think it is a file structure problem. So my understanding is that the "Structure that needs cleaning"  is  within the chroot (xenial) itself, which is unmounted every time I log out of ubuntu. I am not aware though that crouton (or ChromeOS) offers any tools like e2fsck or gparted for me to try to repair the chroot from outside, when it is unmounted. Do you know of any? Also do you know where the (default) location for chroot is, when it is unmounted? Without repair tools, I will revert to a backup and see if the problem persists there.
Regards,
Mark

sudo edit-chroot -d xenial doesn't work either. Without being able to delete the chroot I cannot use my backup.
Does anyone know if there a powerwash option that preserves developer mode or will I have to reset that as well?

Yes, Ctl-Alt-Shft-R from login will restore and one can remain in developer mode. Was able to restore backup and everything is running fine. Crouton is amazing!

@mdwy62,
Glad you got it going again, good job. 👍
For future reference, you can powerwash and even do a full recovery while in Developer mode, the device will stay there until you explicitly leave Developer mode at the 'scary boot screen' by pressing the spacebar and following the prompts.

I am not aware though that crouton (or ChromeOS) offers any tools like e2fsck or gparted for me to try to repair the chroot from outside, when it is unmounted. Do you know of any?

CrOS does come with e2fsck and a probably a few other repair tools.

Also do you know where the (default) location for chroot is, when it is unmounted?

If you installed your chroot in the default location on internal storage your xenial chroot will be under -

/usr/local/chroots/xenial

You can access it directly while unmounted and not running.
Hope this helps,
-DennisLfromGA


msbuild-sonarscanner-begin 0.9.1

Step description
This step allows running SonarScanner for MSBuild against Xamarin projects.
Because of the specifics of the CLI, there are actually two Bitrsie steps developed:

to run begin command
to run end command

Having two Bitrise steps allows using other Bitrise steps in between to run tests, compile, archive, etc. This is the main difference from the already existing Bitrise step developed by tbrushwyler: SonarQube MSBuild Scanner
New Pull Request Checklist
Please mark the points which you did / accept.

[ x] I will not move an already shared step version's tag to another commit
[x ] I read the Step Development Guideline
[ x] I have a test for my Step, which can be run with bitrise run test (in the step's repository)
[ x] I did run bitrise run audit-this-step (in the step's repository - note, if you don't have this workflow in your bitrise.yml, you can copy it from the step template.)
[ x] I read and accept the Abandoned Step policy

Hi @alexshikov !
How this and -end step differs from these already shared steps?

@trapacska
In the existent sonarqube-scanner step the begin and end CLI commands wrap a single msbuild command where you as a developer may specify a bash command to build Xamarin project. That is useful for a simple build process. But we want to use the whole power of Bitrise and allow to use Bitrise steps in between the begin and end, like:

Xamarin archive
NUnit Runner
etc.

So using these new steps the Bitrise flow can look like this:

MSBuild Sonar Scanner (Begin)
NUnit Runner
Xamarin Archive
MSBuild Sonar Scanner (End)

@trapacska does the described reason make sense?

@trapacska  Here is an example of the same approach of two steps for Azure DevOps:

@alexshikov thanks for the new step. The described use-case definitely makes sense.

@godrei could you please remind, when these steps will be available for use on bitrise.io?


ArabicHotelReviews-AraBERT, ERROR: tokenize() takes 2 positional arguments but 3 were given

Hello, I am trying to run the ArabicHotelReviews-AraBERT in this
Every thing is correctly running before the line: val = t.preprocess_test(df_test.review.values, df_test.rating.values)
Error:
TypeError                                 Traceback (most recent call last)
<ipython-input-23-dd26c7ff9ce5> in <module>()
----> 1 val = t.preprocess_test(df_test.review.values, df_test.rating.values)
      2 model = t.get_classifier()
      3 learner = ktrain.get_learner(model, train_data=trn, val_data=val, batch_size=32)
      4 learner.fit_onecycle(5e-5, 1)

3 frames
/usr/local/lib/python3.6/dist-packages/ktrain/text/preprocessor.py in preprocess_test(self, texts, y, verbose)
   1196         """
   1197         self.check_trained()
-> 1198         return self.preprocess_train(texts, y=y, mode='test', verbose=verbose)
   1199
   1200

/usr/local/lib/python3.6/dist-packages/ktrain/text/preprocessor.py in preprocess_train(self, texts, y, mode, verbose)
   1166           TransformerDataset if self.use_with_learner = True else tf.Dataset
   1167         """
-> 1168         tseq = super().preprocess_train(texts, y=y, mode=mode, verbose=verbose)
   1169         if self.use_with_learner: return tseq
   1170         tseq.batch_size = self.batch_size

/usr/local/lib/python3.6/dist-packages/ktrain/text/preprocessor.py in preprocess_train(self, texts, y, mode, verbose)
    941                                       pad_token_segment_id=4 if self.name in ['xlnet'] else 0,
    942                                       use_dynamic_shape=False if mode == 'train' else True,
--> 943                                       verbose=verbose)
    944         self.set_multilabel(dataset, mode, verbose=verbose)
    945         if mode == 'train':  self.preprocess_train_called = True

/usr/local/lib/python3.6/dist-packages/ktrain/text/preprocessor.py in hf_convert_examples(texts, y, tokenizer, max_length, pad_on_left, pad_token, pad_token_segment_id, mask_padding_with_zero, use_dynamic_shape, verbose)
    341                 text_a = text
    342                 text_b = None
--> 343             sentences.append(tokenizer.tokenize(text_a, text_b))
    344         maxlen = len(max([tokens for tokens in sentences], key=len,)) + 2
    345         if maxlen < max_length: max_length = maxlen

TypeError: tokenize() takes 2 positional arguments but 3 were given

It would be very grateful if you help me to solve it. Thank You!!

Hello:  Thanks for reporting this issue.  This is a bug.  It should be fixed in the develop branch and will be included in an updated release soon.
If you'd like try the fix now, you can install the develop branch with:   pip3 install git+https://github.com/amaiya/ktrain@develop
Thanks again.

This is fixed in ktrain>=0.25.2. Thanks.

Thank You!
It's working now.


Compatibility with Electron

I'm very new to electron, so might just have something badly set up, but I can't get the basic 'hello world' of editable-grid to display properly. So far I've:

Set up and got electron hello world working OK
Installed editable-grid via npm
Made sure jQuery is working within electron (so I could use el: $('body'))

From what I can see, the app's content is correct, grid.css (not using LESS) is being included, and the empty <body> tag ends up with the correct table contents. But the display just doesn't look right - see screenshot.
Have I missed something obvious? Or is there something about editable-grid that means it wouldn't work with electron? I'm sure there's other info you might need - please let me know...
electron app source:
awsmanager.html:
<html style="background: #fff">
	<head>
		<link rel="stylesheet" href="./grid.css">
		<script>window.$ = window.jQuery = require('jquery');</script>
		<script src='./awsmanager.js'></script>
	</head>
	<body>
	</body>
</html>

awsmanager.js:
var Grid = require('editable-grid');

$(function() {
	console.log('Loaded');
	var grid = new Grid({
		el: $('body'),
		columns: [
			{
				id: 'a',
				title: 'a',
				width: '33.3%'
			},
			{
				id: 'b',
				title: 'b',
				width: '33.3%',
				alignment: 'right',
				titleAlignment: 'center'
			},
			{
				id: 'c',
				title: 'c',
				width: '33.3%',
				alignment: 'center',
				titleAlignment: 'right'
			}
		],
		data: [
			{
				id: 'id-1',
				a: 'a',
				b: 'b',
				c: 'c'
			},
			{
				id: 'id-2',
				a: 'a',
				b: 'b',
				c: 'c'
			}
		]
	});

	grid.render();
});

resulting app:

Just missing bootstrap css. Needs to be before grid.css link
`

`

Ah, OK. I was looking at this page and it didn't list bootstrap as a dependency - presumably it's only possible to put npm packages in that section...
Anyway, many thanks.


Control flow

WIP; DO NOT MERGE;
This PR addes required ops/logic to match TF control flow for cond/while/etc in graphs.

Do not delete branch.


Cannot add Dynamic Texture as texture to TileSprite

Version

Phaser Version: 3.60.0-beta.18

Operating system: Windows 11

Browser: Firefox

Description

Creating Tile Sprite with Dynamic Texture key breaks the game. Generating image or spite with the same texture works fine.
Example Test Code

This generates error:
let _image = this.add.image(10, 10, 'test_image').setOrigin(0);
let _texture = this.textures.addDynamicTexture('abcd', 400, 400);
_texture.draw(_image );
this.add.tileSprite(100, 0, 500, 500, 'abcd').setOrigin(0);

but sprite works fine:
this.add.sprite(100, 0, 'abcd');

Additional Information

the snippet of the error that appears
batchTexture http://<IP_ADDRESS>:5500/src/js/phaser.min.js:1
    exports http://<IP_ADDRESS>:5500/src/js/phaser.min.js:1
    render http://<IP_ADDRESS>:5500/src/js/phaser.min.js:1
    render http://<IP_ADDRESS>:5500/src/js/phaser.min.js:1
    render http://<IP_ADDRESS>:5500/src/js/phaser.min.js:1
    render http://<IP_ADDRESS>:5500/src/js/phaser.min.js:1
    step http://<IP_ADDRESS>:5500/src/js/phaser.min.js:1
    step http://<IP_ADDRESS>:5500/src/js/phaser.min.js:1
    e http://<IP_ADDRESS>:5500/src/js/phaser.min.js:1
    setTimeout handler*e http://<IP_ADDRESS>:5500/src/js/phaser.min.js:1

There's no way to make this work as TileSprite uses a canvas internally and DT uses a frame buffer. It should probably throw a warning for you though. It would work in canvas mode as then DT uses a canvas but not in webgl.

Thank you for submitting this issue. We have fixed this and the fix has been pushed to the master branch. It will be part of the next release. If you get time to build and test it for yourself we would appreciate that.

Now throws a console warning if you try to do this instead of crashing the game.


nodes.Const class AttributeError

Expected Behavior
No exception rising.
Actual Behavior
I encountered problem with current jinja2 library while using it in few of my projects.
In version 2.9.5 of jinja2.nodes.Const.as_const() method, exception is rising:
AttributeError: 'NoneType' object has no attribute 'policies' in line 484.
Patch in attachment.
nodes.txt

Closing as there's not enough information to reproduce the issue. Either this was fixed at some point, or you're doing something custom, but currently all nodes have environment set by the time they get compiled. If this is still an issue for you, please provide a minimal example or a PR with tests.


Added C-style pointers

Added C-style pointer types, the "address of" operator and the "pointer dereference" operator. Also started stracking custom type data for each AST node and variable.

Is this ready to be merged? :)

It depends on how we decide to handle pointer syntax. This only implements C-style pointers, but if we want another syntax I can also add that in another PR

Okay. I will leave this open for a little bit longer then so no other PR needs to be opened.

This can be merged now, because we are going to use C-style pointer syntax, and then later add references as a more elegant and safe approach.


Readme updated for token samples

Signed-off-by: Rajat Sharma<EMAIL_ADDRESS>

@denyeart @fraVlaca,
The following changes are made in this -

ERC721- If a user copies and pastes the command then an error will be obtained.
ERC1155- The environment variable had to be updated based on the sample.


Large indel not included in RUNNER analysis

Hi
I have a 38 base pair heterozygous deletion in my input VCF file which is not showing up in either the flt.xlsx or gene.mutationburden.case files once RUNNER completes so it seems to have been filtered out. As far as I can tell, the variant should be retained after applying all my filters.
I would like to ask whether RUNNER includes all indels or is there a size limit?
Thanks,
Melissa

As far as I know, KGGSeq has no additional length control for Indels, and RUNNER can take Indels into account. Please check you did not add the --ignore-indel in parameter settings. Please also notice that KGGSeq have some default QC setting, see more details in the KGGSeq online manual (http://pmglab.top/kggseq/doc10/UserManual.html).

As far as I know, KGGSeq has no additional length control for Indels, and RUNNER can take Indels into account. Please check you did not add the --ignore-indel in parameter settings. Please also notice that KGGSeq have some default QC setting, see more details in the KGGSeq online manual (http://pmglab.top/kggseq/doc10/UserManual.html).


Make use of the new cluster join API in lxd init

This changes the format of the YAML, but the code handling the old format is
still there so it will continue to work (although we now print the new format
when you dump the YAML config at the end of interactive mode).
Fixes #4830.
Signed-off-by: Free Ekanayaka<EMAIL_ADDRESS>

@freeekanayaka the CEPH failures look relevant

@stgraber ceph failures fixed


tests: boards: update to new ztest APIs.

Closing PR to make it directly to Zephyr

Closing PR to make it directly to Zephyr


Fixes #370

Corrections/suggestions after proofreading.

I have removed the Code of Conduct text from this document and provided a link to the Code of Conduct document so the project has a single version of this text.

@Snooz82 please review and merge this PR, thanks.

Done!

@all-contribuors please add adrianyork for documentation


update go version to 1.19.2 for github CI pipeline

Signed-off-by: yoza<EMAIL_ADDRESS>Description of PR
Update go version for CI pipeline
Fixes #318
Checklist (required)

[x] I have reviewed and followed the contribution guidelines
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation if needed
[x] I have checked that my changes pass all tests

/lgtm


[compiler] toString(), hashCode() & Reloadable

If Config-interface is not Reloadable - object is immutable.
And, in this case, it have no sense to calculate hashCode and build toString every time: they can be pre-calculated/pre-generated in the local varibales.
If Config-interface is Reloadable - object is mutable, but it is again have no sense to calculate hashCode and build toString every time. They can be be pre-calculated/pre-generated only in the reload() method.

Done.


Incorrectly Labeled Smooth Dullstone Pressure Plates

Not very important rn, but should def be fixed sooner than later

Not incorrectly labeled, it's supposed to glow up when stepped on

ah, makes sense


Replace Guava API calls with Java 8 API

More of it....

Defer this PR to 0.5 release.

are there any modules where we can take guava out of reactor?

👍

This is ready to merge now - removed guava from a few modules


Ulyanov image stylization RuntimeError

As described in #294, a RuntimeError currently occurs for images with a height or width that are not multiples of 64. This PR solves this problem by using an additional TopLeftCropToMultiple  for the case with impl_params=False.

The problem is that the authors do not specify in their paper (impl_params=False) how the images are preprocessed. They only show images in different sizes, with a height and width that are multiples of 64.

Could you have a look what the author is doing in the implementation?

In the implementation, only a resize to the required image size is used. For the example images, the image size is 256x256. This results in a deformation of the image.

I'm not sure I understand. Could you link the parts you refer to?


Help Button not Obvious

Describe the Issue
The new Ask For Help button is not obvious. We have users on the forum frequently not understanding how to find the Ask For Help button.
https://forum.freecodecamp.org/t/new-help-button-not-obvious/571552
Affected Page
All RWD
Steps to Reproduce

Go to any RWD page
Click on 'Check Your Code' a few time
See question mark

Expected behavior
As suggested by @lasjorg, we could include a one word description along with the symbol, for clarity: https://forum.freecodecamp.org/t/new-help-button-not-obvious/571552/7
Screenshots
No response
System
All
Additional context
No response

@naomi-lgbt you said you wanted to circle back to this?

I'm all for adding "Reset" and "Help" to those icon buttons. If we did this then we would need to remove the aria-label from these buttons as the added text inside those buttons should be the accessible name for each button.

@jeremylt I see, may I work on it?

@Sboonny Would like to have your thoughts here as well ❤

@ahmadabdolsaheb wanted the removal of the text, because it allows extra spacing for the future buttons, and we are moving the new RWD to look similar to the mobile version.
But we don't have the future buttons, and after reviewing https://github.com/freeCodeCamp/freeCodeCamp/pull/48586, we really need to clean the technical debt first.
I am happy with adding this back, maybe only for wide screens 🤔. I don't mind adding them for both either, and changing all of them when the future buttons are added.

@Sboonny True, like you can remove the buttons itself for mobile versions as it already have it in the bottom.

I'm not sure if/how complicated it is to implement, but only adding the text for a one word description if the window is wide enough sounds reasonable to me.

I'm not sure if/how complicated it is to implement, but only adding the text for a one word description if the window is wide enough sounds reasonable to me.

Yes, that could be done. Like showing the text for wide screens and removing for the small ones.

Hello @Vansh-Baghel,
So you will like to raise PR and close the ticket ?

@BalanaguYashwanth Yes sure, ill do it if its needed.

I'm not sure if/how complicated it is to implement, but only adding the text for a one word description if the window is wide enough sounds reasonable to me.

There are values in the curriculum for tablat width, and we have Media component for this, not the bootstrap react one.
But to be honest, I think it's for the best to use text in the mobile and desktop for, and when we need to change it later, we will have a better solution then.

I think tackling this in multiple steps is perfectly reasonable.
That is, adding the one word text now and adjusting as needed in the future for mobile.

Yes, the user must have the flexibility to solve the question.

I don't understand what that means?

This seems to be a first timer issue, here is the file https://github.com/freeCodeCamp/freeCodeCamp/blob/main/client/src/templates/Challenges/classic/lower-jaw.tsx
to solve this, add Reset and Help text to their corresponding buttons.

If you would like to fix this issue, please make sure you read our guidelines for contributing, we prioritize contributors following the instructions in our guides. Join us in our chat room or the forum if you need help contributing, our moderators will guide you through this.

I don't understand what that means?

Nah, you got my intent perfectly fine 👍, I shouldn't have diverged the issue.

Nah, you got my intent perfectly fine +1, I shouldn't have diverged the issue.

You're good - there was another reply in there that got deleted

there was another reply in there

Apologies, I commented in the wrong commit. (*￣3￣)╭

This seems to be a first timer issue, here is the file https://github.com/freeCodeCamp/freeCodeCamp/blob/main/client/src/templates/Challenges/classic/lower-jaw.tsx
to solve this, add Reset and Help text to their corresponding buttons. Don't worry about hiding it for mobile, this issue isn't about it.
If you would like to fix this issue, please make sure you read our guidelines for contributing, we prioritize contributors following the instructions in our guides. Join us in our chat room or the forum if you need help contributing, our moderators will guide you through this.

I have already fixed it, may I raise a PR?

I would leave it for first timers, it's rare that there is an open issue for them

Doesn't the text need to be translatable? Do they use the t function with the text? Pretty annoying function name BTW, good luck doing a search for that identifier in the code.
One thing that might also communicate the ask for help button purpose a bit better is if the circle was a speech bubble. But it clashes a bit with the design and when I tried doing a mock it didn't look very good. I tried it with both a round and square bubble. The buttons might just be too small for such an icon.

As an aside.
What would be really slick is having an onboarding step. I'm sure it would be a lot of work, especially with internationalization and accessibility in mind (and depending on the implementation).

Doesn't the text need to be translatable? Do they use the t function with the text? Pretty annoying function name BTW, good luck doing a search for that identifier in the code.

oh god, you are right, I wanted to forget it 🤣.

One thing that might also communicate the ask for help button purpose a bit better is if the circle was a speech bubble. But it clashes a bit with the design and when I tried doing a mock it didn't look very good. I tried it with both a round and square bubble. The buttons might just be too small for such an icon.

👍🤔 Maybe we redesign it entirely, let me open issue after this one about making the buttons bigger and then we can implement the image.

the alignment I had to create the icon from two icons and I didn't bother doing a very good job.

Didn't notice 😅, as long as the icons don't have role and label, I am happy, I think they look good 👍

Well, it was just an example. But I do think it communicates its purpose a bit better. Just to be clear, I would still suggest we add the text.
We should probably clue in @ahmadabdolsaheb and hear what they have to say.

Replacing texts with icons was an experiment to minimize space used for those buttons and have a predictable ui in regards to localization.
The issue with adding and removing the text based on screen size is that editor pane itself changes size regardless of the viewport width.  As a result, a user could be using a desktop and have a narrow editor (lower jaw).
Using icons for buttons is common practice for mobile, but require some getting used to in Desktops.
I don't know if a best.
Having the icon with the text could work. Since the width of translated texts have different widths, we need to make sure that the overflown row is scrollable vertically.
Youtube uses a similar pattern even for small screens on their web app.
Screen Shot 2023-02-16 at 4.32.19 PM

I think the issue is that while the reset button is somewhat ubiquitous, the help button isn't super obvious. That symbol doesn't intuitively mean "click this button to go to the forum to ask questions"

On a side note, I don't think the YouTube button example above is the best example of accessibility and I think it probably fails SC 1.4.10. I know it seems strange that a site like YouTube would have obvious WCAG failures, but this is not the only one. Make your browser approximately 1280px wide and try zooming in 400% while watching a video (be sure to read the comments). I think you will find that you need a lot of horizontal scrolling.
Moral of the story: Big sites that should be able to do better can still have accessibility issues.

@jeremylt, I am open to replacing the icon to see if that helps resolve the issue.

What would be really slick is having an onboarding step. I'm sure it would be a lot of work, especially with internationalization and accessibility in mind (and depending on the implementation).

I have been wanting such a thing especially for translated content because of the added confusion of not having the correct keyboard settings by default (people from certain European countries use  keyboards for example that don't have backslashes).
The issue I opened though has been  closed #48943.

A button for requesting help should not require an onboarding step to understand.

No, onboarding shouldn't be required to understand what the main buttons do.
But it's also not uncommon to have an onboarding step that quickly goes through the UI. Lots of sites have onboarding, even when the UI is/should be self-explanatory.
It is a "nice to have", not a "need to have", which is why I called it slick. It can also help improve initial engagement and communicate an overall tone of the site.
Anyways, I made a PR for the button just so we have something.

If the issue continues after the icon change, we could re-add the one word descriptions.
Additionally, we could have the button light up when the button appears to add more emphasis.

I thought that we agreed that adding a single word would be a good idea above?
I don't understand why using a word to communicate is a bad thing here. Icons aren't a universal replacement for words.

Let's do single word and show the buttons in multiple lines based on the width of the instructions pane.

I am interested to make this issue my stepping stone in the journey of Open Source contribution. Can someone please brief me up what has to be done finally after the discussion?

Action items:
Replace the icons with descriptive words (reset, help)for the buttons in lower-jaw-icon-bar.
Replace 'lower-jaw-icon-bar' with a more descriptive class name.
Make sure 'lower-jaw-icon-bar' contents wrap when the pane is too small.

Okay. I'll do that

Action items: Replace the icons with descriptive words (reset, help)for the buttons in lower-jaw-icon-bar. Replace 'lower-jaw-icon-bar' with a more descriptive class name. Make sure 'lower-jaw-icon-bar' contents wrap when the pane is too small.

@DEVelooper29, I just updated the spec. Let's have both the icon and the word next to one another for this iteration.

Can I work on this?

@anubhav1206 there is an attached pr that is being reviewed for this issue.


add metadata center project #MetaDataCenter-phase-2

Changes proposed in this pull request:

add metadata center sub project
integrate center repository
persist metadata to center repository
optimize proxy bootstrap to process metadata

Pull Request Test Coverage Report for Build 10871

10 of 42 (23.81%)  changed or added relevant lines in 6 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.01%) to 57.317%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-metadatacenter/src/main/java/org/apache/shardingsphere/orchestration/core/metadatacenter/MetaDataCenterNode.java
0
1
0.0%

sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/LogicSchema.java
0
3
0.0%

sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-common/src/main/java/org/apache/shardingsphere/orchestration/core/common/CenterType.java
0
4
0.0%

sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-metadatacenter/src/main/java/org/apache/shardingsphere/orchestration/core/metadatacenter/MetaDataCenter.java
0
7
0.0%

sharding-proxy/sharding-proxy-bootstrap/src/main/java/org/apache/shardingsphere/shardingproxy/Bootstrap.java
0
17
0.0%

Files with Coverage Reduction
New Missed Lines
%

sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/LogicSchema.java
1
0%

sharding-proxy/sharding-proxy-bootstrap/src/main/java/org/apache/shardingsphere/shardingproxy/Bootstrap.java
1
0%

Totals

Change from base Build 10867:
-0.01%

Covered Lines:
11668

Relevant Lines:
20357

💛  - Coveralls

I have squash 10 commits to 1 commits.
It's clean now.


Consider removing ag.

Starting from 2020-09-06, I have installed ivy-searcher with a pure elisp searcher powered by searcher.
ag can be replaced by these tools. So consider to remove this.
Related packages are,

[ ] ag
[ ] wgrep
[ ] wgrep-ag

ag and it's related packages are removed after version 6.2.4.


Can I use LightGBM with pre-trained model like Keras?

I want to use LightGBM with the pre-trained model like fine-tuning, interactive change for new dataset and the number of target label.
I thought the refit method is able to use like fine-tuning.
Here, I tried to use the refit method with the pre-trained model.
model = lgb_model.booster_.refit(X_train, y_train)
lgb_model is "LGBMClassifier(boosting_type='gbdt', class_weight=None, colsample_bytree=1.0,
device='gpu', importance_type='split', learning_rate=0.1,
max_bin=255, max_depth=7, min_child_samples=20,
min_child_weight=0.001, min_data_in_leaf=15, min_split_gain=0.0,
n_estimators=100, n_jobs=-1, num_iterations=10000, num_leaves=90,
objective='multiclass', random_state=None, reg_alpha=0.0,
reg_lambda=0.0, silent=True, subsample=1.0,
subsample_for_bin=200000, subsample_freq=0)"
The pre-trained model's classes_ is 34 and new y_train's unique number is 20.
Therefore, I wanted the new model's class to change the classes from 34 to 20.
Previous issue, #1473 , said 'It is just faster than retrain'.
So I can't use LightGBM with the pre-trained model like fine-tuning, right?

yes, I think the fine-tuned does not suit your case, for the number of classes changes.

I see.
Thanks!


Bug on /sidebar reload

Hello,
me again :p
(I compile the current github version, so it's just for your information, not a big deal)
Concerning ASkyBlock variables:
Could you add a variable to count how many times all challenges were made ?
In ASkyBlock, challenges could be made severals times ;)
like %challenge_total%
Concerning reload:
[23:07:54] [Server thread/INFO]: iCrea issued server command: /sidebar reload
[23:07:54] [Server thread/INFO]: [ScoreboardStats] Path not fond disabled-worlds-whitelist
[23:07:54] [Server thread/INFO]: [ScoreboardStats] Registered replacers: [PlayerPingVariable, BungeeCordVariables, BukkitGlobalVariables, GeneralVariables, BukkitVariables, VaultVariables, ASkyBlockVariables]
[23:07:54] [Server thread/INFO]: SubClassFactory parent ClassLoader [com.github.games647.scoreboardstats.ReloadFixLoader]
[23:07:54] [Server thread/INFO]: Entities enhanced[0] subclassed[1]
[23:07:54] [Server thread/INFO]: runScript
[23:07:54] [Server thread/INFO]: executing 1 of 1 create table IF NOT EXISTS player_stats ( id                        integer prim...
[23:07:54] [Server thread/INFO]: ... end of script
[23:07:54] [ScoreboardStats-Database/ERROR]: [ScoreboardStats] null
java.lang.NullPointerException: The bean is null?
	at com.avaje.ebeaninternal.server.persist.DefaultPersister.saveRecurse(DefaultPersister.java:304) ~[spigot-1.10.2.jar:git-Spigot-078e2f8-21e3b05]
	at com.avaje.ebeaninternal.server.persist.DefaultPersister.save(DefaultPersister.java:282) ~[spigot-1.10.2.jar:git-Spigot-078e2f8-21e3b05]
	at com.avaje.ebeaninternal.server.core.DefaultServer.save(DefaultServer.java:1820) ~[spigot-1.10.2.jar:git-Spigot-078e2f8-21e3b05]
	at com.avaje.ebeaninternal.server.core.DefaultServer.save(DefaultServer.java:1806) ~[spigot-1.10.2.jar:git-Spigot-078e2f8-21e3b05]
	at com.github.games647.scoreboardstats.pvpstats.Database.lambda$setupDatabase$3(Database.java:227) ~[?:?]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_72]
	at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) [?:1.8.0_72]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180) [?:1.8.0_72]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294) [?:1.8.0_72]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [?:1.8.0_72]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [?:1.8.0_72]
	at java.lang.Thread.run(Thread.java:745) [?:1.8.0_72]

Issue with bukkit's class loading. I cannot fix it.


OSMPbfLoader fails on Windows 10/11

When running OSMPbfLoader on Windows,  the code fails with the following error message, seemingly due to trying to copy the pbf file from a temporary folder that doesnt exist. This is regardless of whether the download_directory parameter is set or not (which should fix the error in theory). A sort of hot-fix is to first run the command with download_directory="." (current working dir), and then after it has downloaded and failed then set the pbf_file to the name of the file downloaded:
`KeyError                                  Traceback (most recent call last)
File ~\anaconda3\envs\srai\lib\site-packages\srai\loaders\osm_loaders\pbf_file_downloader.py:278, in PbfFileDownloader._download_pbf_file_for_polygon_from_protomaps(self, polygon, region_id, polygon_id)
277 try:
--> 278     extraction_uuid = start_extract_result["uuid"]
279     status_check_url = start_extract_result["url"]
KeyError: 'uuid'
The above exception was the direct cause of the following exception:
RuntimeError                              Traceback (most recent call last)
File ~\anaconda3\envs\srai\lib\site-packages\srai\loaders\osm_loaders\pbf_file_downloader.py:146, in PbfFileDownloader.download_pbf_files_for_regions_gdf(self, regions_gdf)
145 if self.download_source == "protomaps":
--> 146     regions_mapping = self._download_pbf_files_for_polygons_from_protomaps(regions_gdf)
147 elif self.download_source in PbfSourceExtractsFunctions:
File ~\anaconda3\envs\srai\lib\site-packages\srai\loaders\osm_loaders\pbf_file_downloader.py:212, in PbfFileDownloader._download_pbf_files_for_polygons_from_protomaps(self, regions_gdf)
211     polygons = flatten_geometry(row.geometry)
--> 212     regions_mapping[region_id] = [
213         self._download_pbf_file_for_polygon_from_protomaps(
214             polygon, region_id, polygon_id + 1
215         )
216         for polygon_id, polygon in enumerate(polygons)
217     ]
219 return regions_mapping
File ~\anaconda3\envs\srai\lib\site-packages\srai\loaders\osm_loaders\pbf_file_downloader.py:213, in (.0)
211     polygons = flatten_geometry(row.geometry)
212     regions_mapping[region_id] = [
--> 213         self._download_pbf_file_for_polygon_from_protomaps(
214             polygon, region_id, polygon_id + 1
215         )
216         for polygon_id, polygon in enumerate(polygons)
217     ]
219 return regions_mapping
File ~\anaconda3\envs\srai\lib\site-packages\srai\loaders\osm_loaders\pbf_file_downloader.py:284, in PbfFileDownloader._download_pbf_file_for_polygon_from_protomaps(self, polygon, region_id, polygon_id)
281     error_message = (
282         f"Error from the 'Protomaps' service: {json.dumps(start_extract_result)}."
283     )
--> 284     raise RuntimeError(error_message) from err
286 with tqdm() as pbar:
RuntimeError: Error from the 'Protomaps' service: {"errors": "Please wait a bit - you are rate limited to 18 extracts per hour."}.
During handling of the above exception, another exception occurred:
FileNotFoundError                         Traceback (most recent call last)
Cell In[16], line 21
17 # loader = OSMPbfLoader(pbf_file="denmark.osm.pbf")
19 loader = OSMPbfLoader(download_directory=".")
---> 21 features = loader.load(area, tags, )
23 features.head(3)
File ~\anaconda3\envs\srai\lib\site-packages\srai\loaders\osm_loaders\osm_pbf_loader.py:111, in OSMPbfLoader.load(self, area, tags)
109     downloaded_pbf_files = {Path(self.pbf_file).name: [self.pbf_file]}
110 else:
--> 111     downloaded_pbf_files = PbfFileDownloader(
112         download_source=self.download_source,
113         download_directory=self.download_directory,
114         switch_to_geofabrik_on_error=self.switch_to_geofabrik_on_error,
115     ).download_pbf_files_for_regions_gdf(regions_gdf=area_wgs84)
117 merged_tags = self._merge_osm_tags_filter(tags)
119 pbf_handler = PbfFileHandler(tags=merged_tags)
File ~\anaconda3\envs\srai\lib\site-packages\srai\loaders\osm_loaders\pbf_file_downloader.py:157, in PbfFileDownloader.download_pbf_files_for_regions_gdf(self, regions_gdf)
152 if self.download_source != "geofabrik" and self.switch_to_geofabrik_on_error:
153     warnings.warn(
154         f"Error occured ({err}). Auto-switching to 'geofabrik' download source.",
155         stacklevel=1,
156     )
--> 157     regions_mapping = self._download_pbf_files_for_polygons_from_existing_extracts(
158         regions_gdf, override_to_geofabrik=True
159     )
160 else:
161     error_message = str(err)
File ~\anaconda3\envs\srai\lib\site-packages\srai\loaders\osm_loaders\pbf_file_downloader.py:199, in PbfFileDownloader._download_pbf_files_for_polygons_from_existing_extracts(self, regions_gdf, override_to_geofabrik)
197 for region_id, row in regions_gdf.iterrows():
198     polygons = flatten_geometry(row.geometry)
--> 199     regions_mapping[region_id] = [
200         self.clipper.clip_pbf_file(polygon, downloaded_pbf_files) for polygon in polygons
201     ]
203 return regions_mapping
File ~\anaconda3\envs\srai\lib\site-packages\srai\loaders\osm_loaders\pbf_file_downloader.py:200, in (.0)
197 for region_id, row in regions_gdf.iterrows():
198     polygons = flatten_geometry(row.geometry)
199     regions_mapping[region_id] = [
--> 200         self.clipper.clip_pbf_file(polygon, downloaded_pbf_files) for polygon in polygons
201     ]
203 return regions_mapping
File ~\anaconda3\envs\srai\lib\site-packages\srai\loaders\osm_loaders\pbf_file_clipper.py:138, in PbfFileClipper.clip_pbf_file(self, geometry, pbf_files)
136         self._convert_o5m_to_pbf(clipped_pbf_files_list[0], final_osm_path)
137     else:
--> 138         shutil.copy(clipped_pbf_files_list[0], final_osm_path)
139 # merge all of the files and copy it
140 else:
141     merge_function(clipped_pbf_files_list, final_osm_path_alphanumeric_safe)
File ~\anaconda3\envs\srai\lib\shutil.py:417, in copy(src, dst, follow_symlinks)
415 if os.path.isdir(dst):
416     dst = os.path.join(dst, os.path.basename(src))
--> 417 copyfile(src, dst, follow_symlinks=follow_symlinks)
418 copymode(src, dst, follow_symlinks=follow_symlinks)
419 return dst
File ~\anaconda3\envs\srai\lib\shutil.py:254, in copyfile(src, dst, follow_symlinks)
252     os.symlink(os.readlink(src), dst)
253 else:
--> 254     with open(src, 'rb') as fsrc:
255         try:
256             with open(dst, 'wb') as fdst:
257                 # macOS
FileNotFoundError: [Errno 2] No such file or directory: 'C:/Users/user/AppData/Local/Temp/tmpyney0pr_/pbf_files/denmark_b40f02fb6ddb14cd92ceea1b5bd27c2a7fbeb4c37c818338f760f8f34a293528.osm.pbf'`

Thanks for submitting this issue and providing a full stack trace!
I think the issue is a permissions error while executing code. In one operation, where PBF file clipping is executed, we work in a temporary directory using tempfile.TemporaryDirectory. By default, it looks for the temporary directory in the OS (/tmp for UNIX and the equivalent for Windows). To mitigate it, we changed the TemporaryDirectory to be created in the same working directory as the executed code to hopefully allow the code to work without jumping between disks or partitions.
You can see full changes in this PR #391 and we released a 0.5.2 version with this fix.

After some investigation, it seems that the sequence of events that leads to the error is:

Protomaps rate limit - RuntimeError: Error from the 'Protomaps' service: {"errors": "Please wait a bit - you are rate limited to 18 extracts per hour."}.
Fallback to geofabrik - Error occured ({err}). Auto-switching to 'geofabrik' download source."
clip_pbf_file method of PbfFileClipper used with Osmosis
Osmosis failing silently due to not finding the Java runtime which is required [source].
The expected output file of Osmosis not being there - it failed, didn't produce the output so it's not there.

I would say the course of actions should be:
Decide if this part is necessary for delivering the functionality (downloading pbfs for areas),

Yes - are there any alternatives to osmosis?
1.1 Yes - use them instead.
1.2 No (I really don't like this tree branch)
- Make sure the error is not silent - capture the output from osmosis, notify the user what the actual problem is.
- Tell the users that in this specific case (MacOS, Windows, protomaps failing etc.) they might need the java runtime to support the functionality
No - great, remove it. Problem solved, possibly at some cost.

If we used pyogrio or other library for reading pbfs, maybe this wouldn't be needed at all, as you can filter the records by geometry - example in pyogrio

This should be resolved as of 0.7.0 as we are not using protomaps anymore


Implement missing sheets in dataread

Some sheets have been added to the input file and can be read in from there:
Par_FuelToSubsets
Par_TagTechnologyToSubsets
(Par_TagRegionToSubsets, used in branch dev_offshore but not otherwise. it can still be useful to add to define region specific constraints)
Par_TagTimeIndependentFuel
Par_GeneralDiscountRate
Par_SocialDiscountRate
Par_TechnologyDiscountRate

Fixed in an earlier commit


"bool" type fields are not editable

Unless I'm missing something under my nose, it seems that fields of a Resource which are of type "bool" are not editable, unlike other fields which are of other types.

It's editable, just with a keyboard. Key press toggles it if it's selected - just not a click as one would expect.
There's a bunch of these, actually - enums, arrays, dictionaries and resources aren't editable either!
Related: #43


Handle params after hash, format example: #details?id=1

I am doing development with a popular framework KendoUI which uses this format for Single Page Application (SPA) on mobile, eg:
theurl = "http://localhost:8080/index.html#details?id=1";
I really like this library, currently using: window.url( '#details?id', theurl); which returns 1.
It would be great to handle the case window.url( '?id', url); and return 1 in my example or if that conflicts with another case just add this example to the tests.js to save others time trying combinations to get this case working.  Cheers!

That works already.
On Nov 27, 2015 12:38 AM, "Steve Seeger"<EMAIL_ADDRESS>wrote:

I am doing development with a popular framework KendoUI which uses this
format for Single Page Application (SPA) on mobile, eg:
theurl = "http://localhost:8080/index.html#details?id=1";
I really like this library, currently using: window.url( '#details?id',
theurl); which returns 1.
It would be great to handle the case window.url( '?id', url); and return 1
in my example or if that conflicts with another case just add this example
to the tests.js to save others time trying combinations to get this case
working. Cheers!
—
Reply to this email directly or view it on GitHub
https://github.com/websanova/js-url/issues/41.


Add Fantasy Land Compliance for Associated Predicates

Fantasy All the THINGS!!

As a first step to this issue we need to get the Fantasy Land Methods/Function specific predicates to respect the fantasy-land spec. This PR adds the following to all fantasy-land predicates:

Check for method on passed object (Constructor/Instance), favoring the fantasy-land prefix over non-decorated.

Check for method on constructor for methods specific to the TypeRep. crocks provides these functions on the instance as well as the TypeRep, but not all libs do that, so we need to check the TypeRep of the instance.

Check for @@implements method. There are functions in crocks that can take a TypeRep as arguments and need to use that TypeRep for typeclass validation. For instance isFunctor(Identity) would return true. This is a sole feature of crocks and is not part of the fantasy-land spec. As a result only crocks or outside types that implement the @@implements method will return true when checked against a given TypeRep

Coverage remained the same at 100.0% when pulling 55711c1db56f0468232e029a3f253d29b5ea347a on fl/predicates into 7bd3e4ca7c3eded34882604b6b01dc3826e09092 on master.


Multi Control Plane: do not prune other control planes with operator

Today, I cannot install two control planes with istioctl, because it will prune the other one every time I try to. I am not certain if the controller behaves the same, but it likely does.
We need some way to prevent this from happening. Likely this would just be some additional label that identifies the control plane, and only prune resources with that label.
One thing we need to be cautious of is shared/cluster wide resources - we don't want to prune CRDs, cluster roles, etc

My initial thoughts on this would be to add a label to all resources which have the value of the parent ICP CR namespace-name, and prune only on selected label values.

With istioctl you don't have a CR though, but I agree in principal. We could have a flag --identifier or something to istioctl I guess? And make it have a default so only people with multiple control planes need to worry about it

Would it be reasonable to use a CR in the istioctl case?  cf. https://github.com/istio/istio/issues/20000

I think we just need to annotate all resources with the revision and then
set up the pruning to take that into account. I had this working locally at
one point but got distracted by some 1.5 tasks
On Mon, Mar 2, 2020 at 8:35 AM Ed Snible<EMAIL_ADDRESS>wrote:

Would it be reasonable to use a CR in the istioctl case? cf. #20000
https://github.com/istio/istio/issues/20000
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/19741?email_source=notifications&email_token=AAEYGXNJX4AX3PIPQ3RQZFTRFPN4HA5CNFSM4J6MVKU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENP7ZVY#issuecomment-593493207,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXIUB3HTTNGOIRZF7CDRFPN4HANCNFSM4J6MVKUQ
.


fix: the sample pages

Sample pages were not loading, as result of importing haml needs to be cast to a string when not passed through the translation helper.
This is due to the the default export of the haml–loader not being recognised as a string by the HTML Storybook App (it's an augmented string object but it's still a string deep down inside!)

👍 Cool beans, although I think we can remove this from the changelog (as it doesn't affect the published package) and instead run npm run docs:build and commit those changes here. We only need to fix the github pages build right?

I guess so... cool beans.


python311Packages.yalexs-ble: 2.3.0 -> 2.3.1

Diff: https://github.com/bdraco/yalexs-ble/compare/refs/tags/v2.3.0...v2.3.1
Changelog: https://github.com/bdraco/yalexs-ble/blob/v2.3.1/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 263121 run on x86_64-linux 1

6 packages built:

home-assistant-component-tests.august
home-assistant-component-tests.yalexs_ble
python310Packages.yalexs-ble
python310Packages.yalexs-ble.dist
python311Packages.yalexs-ble
python311Packages.yalexs-ble.dist


scope is empty object

Hi there.
I am using vue breakpoint and I like it much so far.
Unfortunately I realized that recently i stopped working. I experience that scope is an empty object on init and is not reactively updated.
Maybe this is linked to #8 ...
I have this code:
<template>

    <v-breakpoint>

 800">
          <FloatingElement v-for="(image) in images" :key="image.url" :src="image.url">
            <ColoredImage :src-set="image.srcset" :alt="'megahex'" />
          </FloatingElement>

          <ColoredImage v-for="(image, index) in images" :key="index" :src-set="image.srcset" :alt="'megahex'" />

    </v-breakpoint>

</template>

The problem is, that scope is always empty:

Only on window resize it is updated and then things start to work.
I am not sure, what I changed, I only worked on other components, but at some point my code stopped working. Unfortunately I can't really go back, because I made some changes to the backend as well, so I can't fetch the data like I used to.
Any idea, why it is not initiated properly?
if it helps:
https://github.com/Jones-S/radio-megahex
The project is public anyway.

Oh 🖐 !
I realized that it stopped working, because another component also imports VBreakpoint.
If I only have it once in the whole project it works, if it is there twice it stops working...
Instead of installing it globally, I would rather use it in a cherry-picking-mode, where I just use it when needed, because there are some views which don't.
Is there a way?
Thanks for your input.

Thanks for your issue, I'll investigate asap. I should note however, that I plan to rewrite it, because it goes around in a bit of a hacky way, which possibly created this bug.

Thanks. Much appreciated 👍
If we could find a quick fix for this I would be super happy for now :). It kinda broke a project that is live 😅

I'll give it ago, hopefully with some resolve tomorrow. Also, if you can, correct your code snippets. For multiline snippets use three backticks (to open/close) and paste your code in between. You can also suffix the snippet with extension, so it will highlight the code correctly. For Vue templates use "html", for JavaScript use "js". I also suggest formatting the code and removing unnecessary bits.

I added the extension and removed some of the code. 👍
Thx for the effort.
(I thought about using v-breakpoint within a wrapper component and storing the information about the current breakpoint in my vuex store. That could also be a solution, what do you think?

Did you make any progress by any chance?

Not yet. Can you please provide a quick repro? I read your snippets, but it'll help tremendously if you are able to provide a repro. Also, what version do you use? is it latest? upgrade to latest in case it isn't and report back if the issue persists.

I use the latest that is true. Unfortunately I don't have a quicker repro than: https://github.com/Jones-S/radio-megahex
You can try to get it to run if you want to.
Anyway, I think the main thing, and also how you could try this is having a vue app and including import { VBreakpoint } from 'vue-breakpoint-component' and using vue breakpoint in two different components, which are both loaded in the same view/parent component.
Right now I have quite a few things to do, so I wont' have time to reduce this down into a simple reproduction – I'd rather use the time to fix things on the live page with saving the current breaktpoint in vuex I guess... Sorry
I will be available for questions though.
thanks anyway, if you don't manage to find time, no worries.
Cheers

For me it was easier to fix this issue by just using the v-breakpoint component in a component that appears on every page and then commit a mutation to save the current breakpoint in my vuex store.

Sounds good. I'll get back to this asap.


Add context managers for AgentProcess

Perhaps context managers could help us with the problems we are having in #59 .
The problem is that as of now, we need to join the process so as for it to get removed from the process table, as it can be seen in test_agent_shutdown under test_agent.py.
Maybe the use of a context manager could replace at some point the run_agent function.
I'm in the process of further investigating the issue, so do not merge this branch yet, please.

I don't think it is very important right now to get this included, so we may postpone this for a 1.0.0+ release (unless it is necessary for #59).

Closing this since I think it makes no sense (if at all, we could in the future add context managers for agents and not agent processes).


Improve in our emoticons/Colors

The attractiveness of our emoticons could be improved.

Great job @aktasfatih

@adriancleung Thanks


Chat sometimes swallows messages.

I've seen this 3 or 4 times now. It seems to happen when multiple people are chatting at once, so it might be a race condition?

I've seen this several times.  I'm trying to remember to copy each message to the clipboard before I send it.

We believe this will be fixed when we redeploy the system after today's events finish.  Please let us know if you notice any more misbehavior tomorrow.

Closing as the new UI has been developed after this issue was opened and this issue relates only to the old UI.
(For the new UI, we've had no reports of anything like this during CSCW nor seen it during testing, so I'm assuming it's not an issue).


udiskie: 1.4.8 -> 1.5.1

Motivation for this change
Version bump and use of GApps wrapper and icon hooks. Unfortunately, despite the use of gapps wrapper I still get some missing icons in the tray menu.
Things done

[X] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] OS X
[ ] Linux

[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

CC @AndersonTorres

Thanks for the review!


[FLINK-24966] [docs] Fix spelling errors in the project

What is the purpose of the change
This pull request fix many typo, and it can avoid more PR to repair typo one by one in the future
Brief change log

Fix typo

Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)

According to the guidance, I should wait for the Jira ticket.
If I get it, I will continue finding more typo as much as possible and fix in one PR.
If I cannot get a ticket for some reason, I will close this PR at that time.

The pr is a trivial work. Thanks for you review.

The compile is failed. Please have a check @jackwener .

The compile is failed. Please have a check @jackwener .

After fix  typo (testChoicesWithInvalidDefautlValue),  there are same name function.
I found that they test same logic, so I remove this unit test.

@flinkbot run azure

@hililiwei please help me take a look.


Sync tagging in rummager with content-tagger

Follows the approach used to blacklist applications that are not yet
migrated, as seen in content-tagger
Part of:
https://trello.com/c/tZd23gW5/568-allow-tagging-in-content-tagger-for-apps-that-can-t-be-tagged-yet-s

:+1: very nice!


HACS not loading

I had a fully working install of HACS till about a week ago, I had to restart my machine and when it came back up I no longer have the ingress menu and I receive the "Invalid config" message in HA, I've reinstalled HACS from fresh and also had multiple HA upgrades this week and still no luck.
Also a few of our guys in our group have had similar issues, but the error shows as below so this could be further issue and not just a single install error:
This is with HA 0.95 then 0.96 with multiple patches this week (.1 to .5) and HACS 12.1 (previous version was 12 I believe)
Fri Jul 26 2019 11:06:37 GMT+0100 (British Summer Time)
Error during setup of component hacs
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/setup.py", line 153, in _async_setup_component
hass, processed_config)
File "/config/custom_components/hacs/init.py", line 69, in async_setup
await configure_hacs(hass, config[DOMAIN], config_dir)
File "/config/custom_components/hacs/init.py", line 171, in configure_hacs
hacs.store.restore_values()
File "/config/custom_components/hacs/hacsbase/data.py", line 102, in restore_values
store = self.read()
File "/config/custom_components/hacs/hacsbase/data.py", line 41, in read
content = json.loads(content)
File "/usr/local/lib/python3.7/json/init.py", line 348, in loads
return _default_decoder.decode(s)
File "/usr/local/lib/python3.7/json/decoder.py", line 337, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/usr/local/lib/python3.7/json/decoder.py", line 353, in raw_decode
obj, end = self.scan_once(s, idx)
json.decoder.JSONDecodeError: Unterminated string starting at: line 3426 column 13 (char 122870)
So far I've tried:
Reinstall HACS
Recreate API in Github
Updated HA

The .storage/hacs file have corrupted, you need to delete that and restart HA after that, after deletion you will need to "install" all installed elements to re-register them.

That's fixed it, thank you for the assistance.


chore: deps

:tada: This PR is included in version 0.15.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[AspireDeployment] Initializing an Aspire project without 'Subscription', 'Location' will send an incorrect Prompt request on RefreshEnvironment

After running azd init on a brand new Aspire Application, executing RefreshEnvironmentAsync() on it will cause azd vs-sever to send a Prompt request -asking for missing 'Subscription' and 'Location'- though its content is not correct, as it does not adhere to VS IDE Prompt request JSON definition.
From debugging the code, the request sent from azd vs-server has the form of:
{ 	"type":"select", 	"options":{ 		"message":"Select an Azure Subscription to use:", 		"help":"", 		"choices":[ 			{"value":" 1. <Sub_Name> (<Sub_ID>)"}, 			{"value":" 2. ...} 			.... 		] 	} }
But VS IDE defines another schema. Look at https://devdiv.visualstudio.com/DevDiv/_git/WebTools?path=/docs/Aspire/AzdHttpPrompting.md&version=GBmain&_a=contents.
{             "id": "myId",             "kind": "select",             "displayName": "MyLabel",             "description": "My help description",             "defaultValue": "Value1",             "required": true,             "choices": [             {                 "value": "Value1",                 "description": "Value1 description"             },             {                 "value": "Value2"             },             {                 "value": "Value3"             }             ]
For starters, there is no type field, but kind.
Repro steps:

Launch VS and create a new Aspire starter Application project.
Create a new environment with azd command for the project.

Right-click solution/AppHost project > Open folder in file explorer
In the opened folder, right-click any place > open in terminal
Runing 'azd init', select 'Use code in the current directory' > Confirm and continue initializing my app, type a new environment name, and press Enter

Right click on the AppHost project -> Publish.
Prompt request is sent, but VS IDE cannot parse it correctly, presenting an empty dialog.

Original Bug: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2057823

I'll take a look - I suspect this is in an issue with when we initialize the bicep provider - but it does seem bad that we are sending an incorrect shape in our API request.
Thanks for the detailed repo steps here, @anvillan!


feat: neutron big dipper [web-neutron]

Description
Closes: BDU-831

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[x] ran linting via yarn lint
[x] wrote tests where necessary
[x] included the correct type prefix in the PR title
[x] targeted the correct branch
[x] provided a link to the relevant issue or specification
[x] reviewed "Files changed" and left comments if necessary
[x] confirmed all CI checks have passed
[x] added a changeset via yarn && yarn changeset

Closing as this is now replaced with https://github.com/forbole/big-dipper-2.0-cosmos/pull/1309


App Config releases are not getting git tags

Currently, there are no git tags for the app config preview packages that we have been releasing

cc @mikeharder, @weshaggard

Interestingly, they do show up if you run git tag -l locally. I noticed the same is true for amqp-common...they just aren't showing up in the GitHub UI.

This is a github bug they don't show up most tags in that UI. I've never figured out exactly why though. As @chradek said though the tags are there, you can get them through the command line:
> git tag -l @azure/app-*
@azure/app-configuration_1.0.0-preview.1
@azure/app-configuration_1.0.0-preview.2
@azure/app-configuration_1.0.0-preview.3
@azure/app-configuration_1.0.0-preview.4
@azure/app-configuration_1.0.0-preview.5
@azure/app-configuration_1.0.0-preview.6
@azure/app-configuration_1.0.0-preview.7
@azure/app-configuration_1.0.0-preview.8
@azure/app-configuration_1.0.0-preview.9

You can also page through them at https://github.com/Azure/azure-sdk-for-js/tags but I honestly think the command line is the better experience.


Document wedeploy.json command field

It has the same effect as CMD on dockerfile.  It overwrites the value of the dockerfile CMD when executing a container.

Thanks @pragmaticivan! Can you provide an example?

Closed by https://github.com/wedeploy/wedeploy.com/pull/584


x/tools/gopls: fix global @item test namespace

Currently the gopls completion tests use a global namespace for the @item marks. This is annoying because when adding a new testdata package you have to be careful to use globally unique names for all your test completion items. @ianthehat has a plan to transition to package (or file?) local namespaces.

We also just ran into the issue that the framework does not complain about markers with the same name.

Pretty sure this isn't an issue anymore.


How does UpdateModel know what to update?

I was looking at the Edit method and it's only posting back the ID of the object.  How does the TryUpdateModelAsync method get the values of the posted form?  Is this coming from FormCollection?
Also, what if the model has many properties?  It seems tedious to have to type out several properties in the TryUpdateModelAsync.  I'm used to the old method of _context.Update(model).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 938b178b-5f78-e673-df41-0409ad4412e1
Version Independent ID: c06d8343-1407-aa05-de96-c1aca71ba232
Content: Tutorial: Update related data - ASP.NET MVC with EF Core
Content Source: aspnetcore/data/ef-mvc/update-related-data.md
Product: aspnet-core
GitHub Login: @Rick-Anderson
Microsoft Alias: tdykstra

Hello! Thanks for contacting us. This sounds like a general question about using ASP.NET Core. While we try to look at and respond to all issues, for questions like this we recommend posting to a community support group like Stack Overflow with the asp.net-core tag.


Documentation does not specify compile target names for cross compilation

Neva supports cross compilation but it is incredibly un-obvious how to do it. If you type "Neva build -h" it tells you you can use "--target" to specify the compile target but there appears to be nowhere to find out what the various compile targets are. It would be helpful to contain information about how to do cross compilation in the documentation.

@othd06 very good point, we'll fix that 👍


generate bails when overwriting files

Please provide us with the following information:

OS?

Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)

macOS El Capitan
Versions.

Please run ng --version. If there's nothing outputted, please run in a Terminal: node --version and paste the result here:

@angular/cli: 1.0.0-beta.31
node: 6.9.5
os: darwin x64
@angular/common: 2.4.7
@angular/compiler: 2.4.7
@angular/core: 2.4.7
@angular/forms: 2.4.7
@angular/http: 2.4.7
@angular/platform-browser: 2.4.7
@angular/platform-browser-dynamic: 2.4.7
@angular/router: 3.4.7
@angular/cli: 1.0.0-beta.31
@angular/compiler-cli: 2.4.7

Repro steps.

Was this an app that wasn't created using the CLI? What change did you do on your code? etc.

ng new foo
ng g m bar
ng g m bar --routing

The log given by the failure.

Normally this include a stack trace and some more information.

foo (master*) » ng g m bar
installing module
  create src/app/bar/bar.module.ts
foo (master*) » ng g m bar --routing
installing module
? Overwrite src/app/bar/bar.module.ts? Yes, overwrite

Mention any other details that might be useful.
I would expect the file to be overwrote to enable routing. I would also expect to have other files to be generated that would have been generated using ng g m bar --routing.

Thanks! We'll be in touch soon.

I believe I am running into something similar when I updated to @angular/cli: 1.0.0-beta.31. It "seems" the cli thinks it is install globally, ie: if i create a new empty folder on my desktop and run "ng new testapp": I get the message "You cannot use the new command inside an Angular CLI project.". Now this is a brand new empty folder.
When I go back to my previously working angular app, run the angular-cli upgrade and I run "ng update" I get:
ng update
installing ng2
? Overwrite README.md? (yndH)

When I hit any of the buttons, nothing happens and the process just seems to fail silently. No error messages.


Support for Working Days in contracts

many contracts make reference to 'Working Days', this can be important for calculating penalties and service level agreements etc. While this may be difficult to implement as each country has its own definition of what is a working day and also moveable public holidays, this would be a very welcome feature enhancement to support.

Hi @niallroche, I wonder if it's too restrictive for Cicero to make an assumption about what a working day is. Even if we could reliably determine the normal working week by locale, I suspect that there will always be exceptions.
For example, where the agreement defines non-standard working days (e.g. Tuesday to Saturday), or exceptional public holidays (e.g. a royal wedding).
Instead, perhaps we could fulfil this requirement by permitting template authors to specify explicitly what working day and public holiday schedule they wish to use?
This library has some useful primitives, https://www.npmjs.com/package/moment-business-days

Maybe QuantLib would be useful? https://www.quantlib.org/quantlibxl/func_calendar.html.
There is a JS version - https://www.npmjs.com/package/quantlib


customizable password requirements and enforcement?

I may have missed something in the documentation but where and how is this feature implemented?
I guess I could validate passwords myself before but I see there is a catch for InvalidPasswordException, however I didn't see where to customize password requirements or where the default requirements are defined.
Any help would be appreciated as I'm trying to use this authentication system for a website.
Thanks.

Thanks! That aspect has absolutely been thought of but we decided that letting everyone wrap their own checks for custom requirements around the usage of this library is probably the easiest solution.
Do you see any specific problem with that solution? Or did you just want to check whether your approach is indeed the recommended one? In the first case, please let us know about situations where an alternative solution could be more convenient. In the latter case, please go ahead and just implement your own checks, wrapped around the calls to this library. That's what we're doing as well.

Thanks for the quick answer.
I have no problem with that solution and I actually like the fact that this project stays focused on its core parts. I was merely concerned about the possibility that there might already be password requirements checks that I missed in the source code.
It would maybe clear up any misunderstanding if the 'features' part of the documentation rephrased that point about password requirements customization.

No, there aren't any built-in checks for password requirements, apart from the basic check of whether a password has actually been entered. So what you wanted to do is the correct way to do it, just wrap your own checks around the calls to register, changePassword and resetPassword.
Regarding the README, you're right, that was indeed misleading. Thus, the "Features" section has been removed in https://github.com/delight-im/PHP-Auth/commit/dc233d9d46a8519fefd7264a18e48b2ed2d03ed2 and a new section "Custom password requirements" has been added in https://github.com/delight-im/PHP-Auth/commit/0fb653d6e08fb99b1106089283799281af244b63 which should be more clear now.
Thank you!


Corrected xml-comment for the User-property

Removed comment about setting the User. User property only supports get.

Removed "or sets" in the xml-comment.

@HenrikWM,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Looks good. 👍


Regexp matching needs more documentation / expected match fails

Hey,
I have a URL like this
http://localhost:3000/venue/4d6e756a922f8cfad1f449fe
and try marking it active with
{{isActiveRoute regex='venue\/[a-z0-9]*$'}}
This fails, however. I'm unclear on to what the regex actually tries to match against or if it even takes the whole path or only the last bit.
The documentation should either be more explicit on what works, or we should have a look why this example does not trigger. :)
Great package otherwise, just what I needed :+1:

Want to back this issue? Place a bounty on it! We accept bounties via Bountysource.

isActiveRoute matches against the current route name. You'll need to use isActivePath to match against the path part of the url. In your case venue/4d6e756a922f8cfad1f449fe
But most likely you have named the route that handles this url path to something like showVenue and I would match against that with isActiveRoute instead.
<li class={{isActiveRoute regex='showVenue'}}>
  {{linkTo route='showVentue'}}
</li>

But if you had trouble understanding the readme I'll take a look at it and see if I can't make it more excplicit.

I must have just skimmed over the readme too quickly. I can try send you a PR with a more extensive readme documentation of this difference within the next few days. Maybe show one sample router setup with a named route and a matching isActiveRoute expression?

:+1:

See https://github.com/zimme/meteor-iron-router-active/pull/16 for now.
When testing some routes I was wondering about the regex interpretation here. I tried to match route names with a dot in them and got unexpected results. Some expressions didn't match, and when trying to escape the dot with . like so regex='post\.edit' meteor will crash. I suppose this is a separate issue, but maybe you have an idea what's going on?

Regex in javascript is a bit different It seems. I've had this issue but with escaping a ? and we came to the conclusion that you need to escape with \\. or use a character class [.]
I'm looking at #16 now and it's a great start. I'll put some work into my packages tonight... I need to redo some documentation to make things more obvious in all of them.

Ok when you try and escape special chars in javascript strings you need to also escape the \ symbol and that's why you need to use 'a\\.b' for it to work. However if you use /a\.b/ format you don't need to escape the \ char

I'll add RegExp literals to the list of possible arguments tonight.

:+1: I'll close this original issue then when PR is merged ;)

This is being fixed with #22. Closing this issue.


Adding Labels from cpr command

Motivation
Every time we develop new features, we need to set some labels on GitHub web after creating PRs from Sherpa CLI. Then, it would be a very insteresting skill for teams because they would use it from the first moment
Examples:
gh sherpa cpr -i XXXX -labels autodeploy
gh sherpa cpr -i XXXX -labels autopublish/snapshot-binaries
Acceptance criteria

[ ] Create PR with expected labels assigned automatically.

Hi @tomasmrtempe ! Thank you for opening this issue.
We will discuss internally about the implementation of the flag you mention. Currently you can do it with gh pr edit --add-label command after creating the pull request with Sherpa. E.g.:
# Create the pull request with Sherpa
gh sherpa cpr -i XXXX

# Add `autodeploy` and `autopublish/snapshot-binaries` labels to the pull request
gh pr edit --add-label autodeploy,autopublish/snapshot-binaries

Hope this helps you in the mean time.
Thanks!

Hi @hielfx. Thanks for your advice. Bear in mind, if we want to create PRs with autodeploy flag, we'll need a commit after label editing in order to generate snapshot for example,
Thanks!


Moving gcloud.bigtable.happybase into third_party/

Towards #1762
This technically works, but some things to note:

python setup.py develop and by extension pip install -e do not respect the package_dir argument to setup, as such, gcloud.bigtable.happybase will not be available if it's installed that way.
Not sure how the tests/docs will react to this, @dhermes, let me know your thoughts.

Don't merge until we get confirmation from OSPO that this is the correct thing to do.

The only alternative I can think of is symlinking, and I'm not sure how I feel about that.

Another alternative is just making this a separate, optional package gcloud-happybase, which might be cleaner.

/cc @jgeewax @tseaver

Thanks for taking this on. Both test failures seem to indicate that the imports fail. I'm also curious about the contents of the zip created for the distribution.

Both test failures seem to indicate that the imports fail.

Yeah this is weird. I pip installed this locally and I can import, but as I meanted setup.py develop doesn't work so it may be how tox handles installing the package.
I'm starting to think that moving this into a separate library is the best way to go.

I'm fine with gcloud-happybase. @jgeewax WDYT?

FWIW, the code this PR moves into third_party/happybase is not really "third-party" code (i.e., as if we had vendored in happybase):  it is (or is claimed to be) a derived work from third-party code, and hence we need to mention that code's license.
I'm not sure that moving it does anything to help the legalities, compared to just having the header comments mention the separate license (which could just be tacked onto the current LICENSE file with a note).

@jonparrott Why the close?

Because this approach won't work.

OK


[Question] Does this lib support prevent cross site tracking feature in safari iframe?

Regarding, This is just a question
Does this lib support prevent cross site tracking feature in safari iframe?

This lib should have no effect on cross site tracking prevention in Safari.

@davidjbradshaw
Super response!
Thank you!
I closed this thread.


Update the regions used during catalog validation of DAs

Description
We are hitting quota issues in our account, so splitting out regions so each DA deploys to different region in catalog validation pipeline
Release required?

[x] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

When merging, use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author. The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).
Merge by using "Squash and merge".

/run pipeline

:tada: This PR is included in version 4.12.3 :tada:
The release is available on:

GitHub release
v4.12.3

Your semantic-release bot :package::rocket:


generate dependencies before tests

fixes ci failure like: https://ci.keyba.se/job/client/job/PR-16103/1/execution/node/372/log/ introduced in https://github.com/keybase/client/pull/16088

I think you forgot to revert this too, so now we gen deps twice.


use snapshot=false

Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #238 (cf85154) into 1.1 (9e82779) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                1.1     #238   +/-   ##
=========================================
  Coverage     64.15%   64.15%
  Complexity      309      309
=========================================
  Files           102      102
  Lines          4383     4383
  Branches        658      658
=========================================
  Hits           2812     2812
  Misses         1403     1403
  Partials        168      168

Flag
Coverage Δ

dashboards-reports
77.81% <ø> (ø)

reports-scheduler
53.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e82779...cf85154. Read the comment docs.


[maps] consider using FusionTables

reading on the internet, FusionTables seems to be a good way to handle thousands of markers and a lot of data, as is the case when a user has thousands of followers and followings.
check the tool and consider using it

major problem right now is that the table which we fetch the data from must be public


Fix readme typo; fix retrieval tensor not serializable

Fix README.md: change the $GTR to $GTR_EMB
Fix the TypeError: Object of type Tensor is not JSON serializable error when writing the score to the json file in retrieval.py

@howard-yen Can you check if the PR is correct?