The path to 1.0

Now that neomerx/json-api is at 1.0 we want to get this library to 1.0 as soon as possible - to give people confidence that the API is stable.
The recent routing refactor and reducing the number of units per resource type (currently on develop - will be released as 0.8) puts in a lot of pre-1.0 changes that we wanted to do to simplify the package.
Required 1.0 Features

[ ] Full support for filtering, paging etc for relationship endpoints - including test helpers. See #22, #23, #27
[ ] Support with when retrieving single records. See #62
[ ] Hydrator simplification. See #69
[ ] Hydrate Eloquent polymorphic relationships. See #35
[ ] Generic authorizer that hands off to Laravel policies. See #45
[ ] Refactor JsonApiController so that it has the majority of the workflow that currently exists within EloquentController. Extend the Eloquent controller from this new controller.
[x] Add a broadcast helper trait. See #36
[x] Add a blade template helper to encode JSON API data into a HTML page. See #36
[ ] Add json-api:cache and json-api:clear commands to cache the ApiInterface object. This will give a performance benefit to HTTP requests along the lines of route:cache.
[ ] Convert tests to Laravel 5.4 style - i.e. remove dependency on laravel/browser-kit-testing.
[ ] Drop support for Laravel 5.3 and ensure support for 5.4 and 5.5 at 1.0.
[ ] Unit tests in this package rather than relying on the demo app to test package is working.
[ ] Full documentation!!!!!

Required Internal Changes

[x] Rename the Resource class as it is a reserved word in PHP 7.0
[x] Extract StandardObjectInterface and related generic classes to a separate utility library.
[x] Single ValidatorErrorFactoryInterface in the cloudcreativity/json-api package rather than extending that interface in laravel-json-api.
[x] Ideally stop injecting HttpServiceInterface and instead inject the ApiInterface and RequestInterface directly. This is possible as long as no services are created post the JSON-API middleware running.

Opening this issue so that people can comment on any features that they think are needed for 1.0.

v0.9 released with:

Above internal changes
Blade template helpers
Broadcasting trait

Hi Chris,
Awesome to see how the road towards v1.0 is getting closer and closer!
I'm up for working on converting/modernizing the tests. But may I suggest using orchestral/testbench? I used it when I developed the dixieio/eloquent-model-future and it just made writing tests using laravel facades and configs a breeze and super reliable.
If like the approach I'm up for throwing a PR tonight. 😄

Hi @jstoone
Your help with the tests would be super appreciated and would definitely speed up getting to 1.0.
I'd be happy to use testbench where it is not possible to write unit tests. Generally I'm trying to write the majority of units so that they are unit testable - i.e. their dependencies are Illuminate contracts. E.g. the LinkFactory takes a UrlGenerator dependency, which is a contract so should be unit tested as such.
There are however some parts of the package where that's not possible - and the part the really jumps to mind is anything to do with Eloquent models.
So what I'd suggest is we create two sub directories in the tests folder - Unit and Integration. The Integration folder can hold any tests that need testbench. And then maybe if you started with those, seeing as I've never used testbench before, and concentrate on the Eloquent stuff?
If that sounds like a plan, I'll push a commit to the develop branch with the new test structure and then you can fork off that commit. (I was also planning to drop support for Laravel 5.3 on develop, so will do that at the same time.)

@jstoone I've restructured the tests on develop. I'm heading off now so will be back online tomorrow morning (UK time)

Sounds great, and the Unit and Integration split seems very obvious. I'll get started on the migration to testbench sometime tomorrow afternoon, and hopefully reach a point where I can submit a WIP PR, which we can use as a base for discussion.
Exciting times! 🔥

@jstoone great tip on the testbench repo - just used that in a package at work and it makes things a lot simpler.
i was going to start setting up the tests this evening unless you'd already started?

@lindyhopchris it is really a gem when it comes to testing features that are more tightly coupled to Laravel. Also great that you've had the opportunity to play around with it. 👍
I have started setting them up, but then life entered the door and denied me access to my spare time. I was planning on finishing it around Saturday or Sunday, but with that said if you want to get it done tonight feel free to take over. I'll pick something else on the checklist for the weekend json-api hackathon. 🎉

@jstoone didn't do any on it last night as I didn't want to cross over with anything you were doing (and only just seen your message now this morning). So if you want to carry on with the test stuff this weekend that will really help.
Thanks for offer of help re: code reviews. Will take you up on that!

@lindyhopchris alright! Awesome to finally get the PR pushed out and merged! 🎉
Is there anything that you would find handy, that I'd start working on now?

Thanks for your PR. Definitely some help with writing tests for the Eloquent classes. I'm doing some work on this package tonight so will let you know which class you could take once I've had a look over things this evening.

@lindyhopchris you're very welcome, it's great to be able to contribute.
Just throw me a bone when you're readny, and I'll figure out what to do with it once it's there. 😁

@jstoone was thinking if it's possible to test the make:json-api:resource command, then that might be something you could do considering that you wrote the generator originally?

Just as an update, the latest changes on 1.x-dev involve removing the hydrator and splitting adapters into resource and relationship adapters. This gives a lot simpler approach while giving much better opportunities to fully support relationships properly.
Here's what an adapter now looks like:
https://github.com/cloudcreativity/laravel-json-api/blob/jj-abrams/tests/JsonApi/Posts/Adapter.php
And this one supports has-many polymorphic relationships:
https://github.com/cloudcreativity/laravel-json-api/blob/jj-abrams/tests/JsonApi/Tags/Adapter.php#L32-L35

@lindyhopchris This is awesome news. A lot simpler indeed. Then I guess "full support for filtering, paging etc for relationship endpoints" is next on the list. This is the one thing that prevents me from updating my project. I guess there's not an easy workaround I could implement on my own? Anyway, great work, as always.

Then I guess "full support for filtering, paging etc for relationship endpoints" is next on the list.

Yes, plan is to do that next then tag as v1.0.0-alpha.1. You'll be able to do filtering, paging etc for relationship endpoints in that release.
The only thing is that'll be in January as I'm away for 3 weeks from 26 December and work is too busy between now and Christmas to get it done before then.

@lindyhopchris I know you are more than super busy, and work should always come before hobby, but just to try and get an update on those two first items in the path to 1.0 list (filtering and with on single). Not to rush you, but to know what can be reasonably expected.

@JeanLucEsser no problem with you asking!!
So I've been working on the 1.0 release recently - it's on the develop branch. The relationship stuff is now refactored and I've got all the different types of relationships supported for reading/writing. I need to add in the filtering/paging of to-many relationships, that's next on my list to do. Then I'll tag as 1.0.0-alpha.1
The with for single records is actually pretty minor so I'll aim to get that into the same release.
I'm thinking that'll probably be tagged in the next couple of weeks. I'm using the develop branch for some work stuff and will be forced to do a tagged version soon for a product release in work. So I'm confident there will be a tag in the next couple of weeks because work deadlines will force it to happen!

@lindyhopchris thanx for this update!
I think the filtering/paging of the many relationships is not that trivial. Even in the spec I can't find a clear answer as to how it is supposed to work, when including a to-many relation, do you use the global page[size] to determine the number of relations you bring before asking for more on the relationships endpoint? I'm curious as to which approach you decided on, but I guess I'll soon see.
Good luck on you deadlines!
Best

@JeanLucEsser
actually I interpreted this as straightforward. If your relationship needs to be paginated, it should never be serialized as resource identifiers in the primary resource. You should use a link for the relationship and then paginate when using that link.
For example, lets say there's a posts resource with a comments relationship. Realistically you're going to need to paginate the comments because there could be hundreds of them for one post.
Your post resource would look like this:
{
	"type": "posts",
	"id": "1",
	"attributes": {
		"title": "My First Post"
	},
	"relationships": {
		"comments": {
			"links": {
				"related": "/api/posts/1/comments"
			}
		}
	}
}

Then to get the first page of comments for that post you would do:
GET /api/posts/1/comments?page[number]=1&page[size]=20 HTTP/1.1
Accept: application/vnd.api+json

The version 1.0 branch will handle that relationship pagination automatically. It also handles filtering on the relationship so you could also do this:
GET /api/posts/1/comments?filter[author]=123 HTTP/1.1
Accept: application/vnd.api+json

To get all comments created by the author with id 123.

@lindyhopchris,
This sounds like a really elegant and clean way of dealing with the pagination and filtering of the subresources! I have been thinking about it and only got the idea of something like page[comments][size]&page[comments][number] on the main resource endpoint, which is quite cumbersome for use and even more so for implementation. Using the sub-resource endpoint to begin with, is genial in its simplicity. I am wondering however, how would one specify in the Schema that the respective sub-resource identifiers should not be serialized. Would there be some standard callbacks in the library to provide for the 'showData' and 'showRelated' attributes of a linkage? Wouldn't it require a potentially expensive count of the sub-resources to know when they are too many to serialize as identifiers or would it be a default setting to hide data and show links for all to-many relationships?
One more thing - do you plan on adding support as well for the dot syntax for filtering of a resource based on sub-resources, i.e.
GET /api/posts?filter[comments.author]=123 HTTP/1.1
Accept: application/vnd.api+json

(that should return all posts where the author with ID=123 has commented)?

So I'd never recommend variably including the resource identifiers... because otherwise the client doesn't know what it's getting. So in the posts comments relationship example, comments would always be retrieved from the related endpoint and never have comment identifiers in the posts relationship, regardless of how many comments there actually were. The client then always knows it needs to get them from that endpoint.
In terms of only providing the links and not data, you can already do that in your schema by not returning anything for data. You can see an example of that here:
https://github.com/cloudcreativity/laravel-json-api/blob/develop/tests/dummy/app/JsonApi/Posts/Schema.php#L40-L42
The filtering logic is totally up to the application as this package just provides the hook for it and then each application can implement its own filtering logic. For the example you give, this would already be possible in the posts adapter filter method as follows:
if ($author = $filters->get('comments.author')) {
    $builder->whereHas('comments', function ($query) use ($author) {
        $query->where('author_id', $author);
    });
}

Have moved the caching of API config to the 1.1.0 milestone as it is not blocking the path to 1.0.

Good idea! Anything that can speed up official release of 1.0!
I'd even argue that full documentation could be a work in progress not tied to the release. Let's not forget that you maintain a full demo application, that's the best doc we can get.

@JeanLucEsser good point, I'll take that off for now as you're right that it doesn't stop me from tagging 1.0.0.
Just as an update for all on where I'm at with this...

alpha.1 is now tagged.
alpha.2 will make Authorization more Laravel friendly.
alpha.3 will deal with some of the remaining small issues.
beta.1 will remove all classes currently marked as @deprecated
beta.2 will update the validation to sort out the remaining issues with it. As it's the oldest bit of the code, I'm going to write this from scratch but behind different interfaces. I'll deprecate the existing interfaces but they'll continue to work during the 1.x series (although they will not be supported or documented).
beta.3 deal with any remaining issues, hopefully only small changes at this point.
1.0.0 will remove anything marked as deprecated during the beta with the exception of the old validation.

1.0.0 will be Laravel 5.4-5.6 so will continue to support PHP 5.6. Although I'd love to drop it, we've got a production app that we just cannot update to PHP 7 until late this year.
I'll time 2.0.0 for the Laravel 5.7 release, upgrading to min PHP 7.1 and that'll also mean I can update the underlying neomerx/json-api package to 2.0 at the same time.

I'm really curious about what alpha 2 will bring to the table. I'll take a look at Laravel Authorization and how it is currently implemented. All in all, that's a great roadmap. Thanx ^^

@JeanLucEsser the Authorization thing is mainly:

Change the interfaces to take the Laravel request object rather than the JSON API objects that it currently does... this is because authorization typically takes place before validation, so those JSON API objects shouldn't exist at that point. As I'm no longer using the generic cloudcreativity/json-api packages I can type-hint Laravel classes so that'll be an improvement.
At the moment the package assumes one authorizer per resource type. but actually in a lot of cases you're going to have an authorizer that could be used against multiple resource types. So I want to support reusable Authorizers not just resource-specific ones (i.e. it will support both).
Add an Authorizer generator (that can generate a generic or a specific one).
Add tests as none of the Authorizer stuff is tested in the current code base.
Add to the demo app as it's not demonstrated at the moment.

Awsome. Just to be sure, should we require dev-release/1.0.0-alpha.2, dev-develop or dev-master#1.0.0-alpha.2?

Require the tag:
$ composer require cloudcreativity/laravel-json-api:1.0.0-alpha.2

Closing this in favour of the mileston
The only remaining issues relate to validation. We're planning to put in a new validation implementation as the current one was one of the first things we wrote and there's a number of improvements we can do now that the validation does not need to be framework-agnostic.
Our plan however is to leave the existing validation implementation for 1.0.0 so that people can upgrade in their own time during the 1.0 cycle. The current implementation will be marked as deprecated and removed for 2.0.


expose-ores

What
Finish the implementation of expose-ores
Why
Because it is an awesome program to have!

finished & renamed to "digger"


Further reorganization of build process

This PR will do the following:

Move the node stuff from the AE folder to the root folder. This allows us to leverage node in the future in pther parts of the project without creating confusion about its location and avoid creation of multiple node_modules folders.
New build script to create a local website using the "ResetDevSite" target in Cake
Add local settings for the above
Reorganize all MSBuild scripts to use the same variables (in Dnn_Platform.build) and the ability to override the value of the website path there using a local file. This allows debug building to the debug website.

I did a build of this branch and release/9.4.x and compared them.  The only difference that sticks out is that the reorg2 branch includes an extra package in the Install/Library folder, DNNCE_Website.Deprecated_09.04.02_install.zip.  Does anyone know anything about that package.
It also appears that the /Install/Module/DNNCE_01_Web.Deporecated_09.02.04_Install.zip package was moved to /Install/Library/DNNCE_Web.Deporecated_09.02.04_Install.zip, but I wouldn't expect that to cause an issue.

After installing, the reorg2 site has DotNetNuke.Website.Deprecated.dll in its bin and release/9.4.x did not have that DLL in the bin.  So it looks like this either fixed an oversight, or missed a special case exemption.
Also, reorg2 includes DotNetNuke.DependencyInjection.deps.json in the bin, which release/9.4.x doesn't have (but they both have DotNetNuke.Abstractions.deps.json).  These JSON files being included in the bin isn't going to cause a problem, but it also doesn't do anything AFAIK, and should probably be excluded.

I did a build of this branch and release/9.4.x and compared them. The only difference that sticks out is that the reorg2 branch includes an extra package in the Install/Library folder, DNNCE_Website.Deprecated_09.04.02_install.zip. Does anyone know anything about that package?
It also appears that the /Install/Module/DNNCE_01_Web.Deporecated_09.02.04_Install.zip package was moved to /Install/Library/DNNCE_Web.Deporecated_09.02.04_Install.zip, but I wouldn't expect that to cause an issue.

It used to be in "Modules" despite being a library because the logic that ensures a proper install order was faulty. I fixed this bug and moved this package back to the Library folder where it belongs.

As for the DNNCE_Website.Deprecated_09.04.02_install.zip package, if I am not mistaken this was code to be removed but still needed in order to be able to migrate from the control panel to the persona bar.  This was done in order to still have access to the old codebehind logic on the older webforms based controls because the upgrade removes those files but the upgrade logic still needed some methods from there to perform it's thing.
If I am not mistaken this can be removed in any version as long as people follow the suggested upgrade path that has a step at 9.1.1 before moving forward to the latest version. This being said I don't know if we should keep it there "in case" for people not reading the suggested upgrade path and would try upgrading directly from 8.0.4 (or older) directly to 9.4.x or some such.
See https://dnntracker.atlassian.net/browse/DNN-9552 also...
I think we could keep this in the upgrade package only and get rid of it in 10 ??? Opinions? We could also include a cleanup in 10 to remove it ?

Deprecated is 100% required currently

@mitchelsellers Deprecated.Web is currently included, not issue there.  Deprecated.Website is not currently getting installed (just checked it's not present in 9.3.2), so it can't be 100% required.

Weird, I was 99.9% sure that was required for the FileManager, I'll have to look deeper in my notes.
I did an NDepend Chart on all of this a while back

For things that have been removed or need changed or fixed up due to changes is there a place anywhere where we can look at these.   It would also be nice to categorize if it is a developer change needed or an administrative change.  Just a thought to have this list possibly a file in the upgrade package or a referenced webpage for things to double check have been done.  It is hard to read release notes to find these all the time for every single release it would be convenient to get these all in one location.  dnndocs maybe...


Add Jobs to ServiceAnsiblePlaybook

The SUI needs to be able to access the jobs on a ServiceAnsiblePlaybook and know the action they are for. This returns them in the format:
{"Provision"=>
  #<ManageIQ::Providers::AnsibleTower::AutomationManager::Job:0x007fe6608789c8
   id: 371,
   name: "miq-playbook-demo_provision_hd2g8j13",
   type: "ManageIQ::Providers::AnsibleTower::AutomationManager::Job",
   description: nil,
   status: "successful",
   ems_ref: "114",
   ancestry: nil,
   ems_id: 10,
   orchestration_template_id: 516,
   created_at: Tue, 14 Feb 2017 19:20:42 UTC +00:00,
   updated_at: Fri, 24 Feb 2017 16:45:02 UTC +00:00,
   retired: nil,
   retires_on: nil,
   retirement_warn: nil,
   retirement_last_warn: nil,
   retirement_state: nil,
   retirement_requester: nil,
   status_reason: nil,
   cloud_tenant_id: nil,
   resource_group: nil,
   start_time: Tue, 14 Feb 2017 20:20:55 UTC +00:00,
   finish_time: Tue, 14 Feb 2017 20:20:58 UTC +00:00,
   configuration_script_base_id: 488,
   verbosity: 0,
   hosts: ["localhost"]>,
 "Retirement"=>{},
 "Reconfigure"=>{}}

cc: @AllenBW
thoughts @bzwei ?
@miq-bot add_label enhancement, services

Well put @jntullo SUI NEEDS :taco: :dancer:

@miq-bot assign @gmcculloug

@jntullo Please update the description to reflect the updated return format.
Looks like we lose the action with the recent change.  Not sure if that is required information to retain here.  cc @bzwei

@gmcculloug done 👍

while it would be nice to retain the action, the action can be retrieved from the service resource

OH GLORIOUS DAY!!!! :taco: :dancer:


Code example works only with English language

Please provide a code example that would work with every client language, and remove a space sign after the = '
Correction:
if Format(DateFormulaVariable) = '' then
  Evaluate(DateFormulaVariable, '<1W>');

Please also explain in the article the usage of <> .

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9b659a96-ac9d-4c56-4e7d-b85abc8eb465
Version Independent ID: 050cf5d3-4c38-4b3a-cc0f-e56891d7249b
Content: DateFormula Data Type - Business Central
Content Source: dev-itpro/developer/methods-auto/dateformula/dateformula-data-type.md
Service: dynamics365-business-central
GitHub Login: @SusanneWindfeldPedersen
Microsoft Alias: solsen

Hello, thanks for the feedback. This topic has been updated.


Enable LLVM JIT lit tests

These were turned off at some point as part of enabling dynamic shapes (https://github.com/google/iree/pull/1249) and then never turned back on... They all pass.

Feel free to submit your pending changes for these files first and I'll handle the merge conflicts


DIP #14- Spoof Assets

What is a spoof asset?
A spoof asset is an authenticated asset that has no intrinsic value and is meant to deceive the community and protocol in order to generate rewards. For example, currently, a "creator" could generate npmjs repos with one line of code and become an authenticated asset on Stakes Social.
Why are spoof assets bad?

Create artificial minting
Take away from other creators

Potential solution for spoof assets?
A potential solution to mitigate spoof assets is to implement Kleros Curate. Kleros Curate uses the Kleros protocol to organize information. Other uses cases for this product are exchange listings, fake news, or marketplace products. For more information on how it works click here --->: Kleros Curate blog post. Verified assets/creators will receive a badge once Kleros' network of jurors approve the submission.
Potential Issues?

Kleros requires submitters to deposit ETH for the submission. If they are accepted then they will get the ETH back. If they lose then the ETH is used as a fee to pay for the jurors. If creators apply then this decreases the UX experience and creates more gas prices. If the Dev Protocol paid for the ETH then this could open an attack vector to drain company finances.

Submitters will have to interact with the Kleros protocol to submit evidence

All assets must get approved in Curate before being listed on Dev Protocol which will increase the time to launch for creators.

Unpopular Solution?
Admin keys.

First of all, I think this issue should be solved.
Second, we need more ideas because the specification that requires curation in the asset listing process involves complicated UX.
How about stopping reward withdrawal until fulfilled certain conditions?
For example, until passed the curate - In this case, it becomes can be applied for curate when DEV equivalent to ETH to be deposited to list has accumulated.

Yes, I agree that this process you suggest may offer the lowest possible pain for creators since the incentive to withdraw your rewards is greater than the UX complexity. The solution you propose is similar to a centralized exchange which requires KYC before withdrawing large amounts of assets.
We should coordinate a meeting with Kleros to see how else we could structure this.
Ideally, the user should not interact with the Kleros protocol.

Dev Protocol takes fee from creator during creation process. This fee is deposited to Kleros which then submits asset to be assessed by Kleros jurors.
If submission is accepted then creator gets deposit back.
If Kleros jurors decide to challenge/arbitrate then creator is prompted to submit evidence through Dev Protocol.

Hi,
Dev users wouldn't need to interact with a Kleros interface. They could submit/challenge/appeal in a Dev interface.
You can see a curate interface here. It allows to interact with curate TCRs, but you can perfectly have your own specific frontend allowing Dev users to interact without leaving the Dev frontend.
By being displayed both in a Dev frontend and a Kleros one, we could expect members of both communities to interact with it.

While I do believe that we need to move forward with DIP 9 and remove rewards for unverified assets. I think at the current time Kleros brings a bigger barrier to entry and will hurt initial user growth. We dont know the extent of spoofed assets at this current time and the amount of gas cost to create a property cuts into the profitability of spoofing assets. Our goal at the current time is onboarding new users and asking them to not only pay the gas fees for a new property, but also put down a deposit, will deter many potential users from joining. I think the best plan of action for the moment is push forward dip 9 but hold off on any third party protocols until our user base is larger.

Hi @clesaege, thanks for the information! It's nice to have a seamless experience available.
I'm still exploring ideas because barriers as a mandatory requirement make it difficult for newcomers.
@calaber24p I agree with you. Ideally, it's an algorithm where creators get paid appropriately, whether they're lying or telling the truth.
For reference, a lesser-known concept, the concept of authentication fee is built-in. In the current Policy, the authentication fee is zero until the total number of assets exceeds 10000. The authentication fee is paid by burning DEV, and discounted for properties that already have a sufficient amount of staking.

"Ideally, it's an algorithm where creators get paid appropriately, whether they're lying or telling the truth."
Comment from DIP #9 on using Web 2.0 Metrics in an algorithm to determine spoof assets:
There's a flaw with using downloads x staking as a weighted average. Staking and downloads are highly correlated since users have a bias to support large projects. This ultimately becomes a network effect on Dev Protocol as seen by Chalk. Therefore, successful attackers could have a lot of DEV staked from unknowing stakers which will get them approved in your formula. The proposal put forward would allow effective bad actors to be accepted and non effective bad actors to be rejected.

@defi-er Yes, I think using Web 2.0 metrics is a bad idea.  The ideal is to be optimized with tokenomics instead of relying on oracle.

Second, we need more ideas because the specification that requires curation in the asset listing process involves complicated UX.

In addition, curate has an SDK for interacting from the dev UI -> https://gtcr-sdk.readthedocs.io/en/latest/. For now it is only for reading data but we can add more features to ease development.

Second, we need more ideas because the specification that requires curation in the asset listing process involves complicated UX.

In addition, curate has an SDK for interacting from the dev UI -> https://gtcr-sdk.readthedocs.io/en/latest/. For now it is only for reading data but we can add more features to ease development.

Another solution would be for the team to handpick which projects join, stake for them, and allow the projects' creators to authenticate to redeem rewards. Upon authentication the general community will be allowed to stake for these projects.


Dial tcp i/o timeout while install helm ingress controller or list its releases

Kubernetes cluster is created and while trying to install ingress-controller (nginx-ingress) using helm
"helm install stable/nginx-ingress --namespace kube-system --set rbac.create=false"
or trying to list the release,
"helm list"
getting the following error,
"Error: Get https://XXXXXXX.hcp.westeurope.azmk8s.io:443/api/v1/namespaces/kube-system/configmaps?labelSelector=OWNER%!D(MISSING)TILLER: dial tcp: i/o timeout"
Stuck with this error for two days and any suggestion to overcome this error would be much helpful.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 12009c1f-282d-2632-fac0-64b09c432833
Version Independent ID: 6052d3d4-d295-9340-b16d-4c200e34cd73
Content: Create an HTTP ingress controller with a static IP address in Azure Kubernetes Service (AKS)
Content Source: articles/aks/ingress-static-ip.md
Service: container-service
GitHub Login: @iainfoulds
Microsoft Alias: iainfou

@snaveekumar Looks like your issue is same as this GitHub issue. Check it out and let me know if it solves your problem. Thanks.

@snaveekumar Any update?

@Karishma-Tiwari-MSFT sorry for the delay.
This issue is resolved on its own before I do anything. I don't know what happened in between these days, when I check today it is resolved and started working.
I can able to install and list helm releases without any issues...
Thanks for your time to help me on this.

@snaveekumar Thanks for the update.
We will now close this issue. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.

I have the exact same issue, i have done
helm install stable/nginx-ingress --name nginx and it fails with error
Error: Get https://xxx..xxx.xxx/version?timeout=32s: dial tcp: i/o timeout
Earlier, I got this working by connecting to a different network and it worked.
I have hit the same issue again, can any one please explain why this happens?

I'm also seeing this error, does anyone have a suggestion?


Fix ip with mask in pod status

Fixes: #252
Ref: https://github.com/hyperhq/hyperd/issues/671
cc @bergwolf

This change is

LGTM!


Add TTY console support

Add console functions to inc/ext and src/ext
Add stb_printf
Add console sample
Update doxyfile
Update libmd.a and libmd_debug.a

Actually, there is one more thing I forgot: stb_sprintf.h also provides vsnprintf(), which checks the buffer size. At the moment SGDK only provides vsprintf() which could result in buffer overflows, so we would need a large string buffer to minimize the risk.
I realize that stb_sprintf.h is quite big, but it would only be linked if the console is used. For final game builds (if no console functions are called) the linker would take care that it is not added to the binary.


bugfix for update statement

Fixes #4993.

Codecov Report

Merging #4994 into master will decrease coverage by 0.17%.
The diff coverage is 0.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fec78b9...9858249. Read the comment docs.

Pull Request Test Coverage Report for Build 10687

0 of 19 (0.0%)  changed or added relevant lines in 5 files are covered.
5 unchanged lines in 5 files lost coverage.
Overall coverage decreased (-0.05%) to 57.34%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/oracle/visitor/OracleVisitor.java
0
3
0.0%

shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/PostgreSQLVisitor.java
0
3
0.0%

shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/sqlserver/visitor/SQLServerVisitor.java
0
3
0.0%

shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/MySQLVisitor.java
0
5
0.0%

shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/sql92/visitor/SQL92Visitor.java
0
5
0.0%

Files with Coverage Reduction
New Missed Lines
%

shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/MySQLVisitor.java
1
0%

shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/oracle/visitor/OracleVisitor.java
1
0%

shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/PostgreSQLVisitor.java
1
0%

shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/sql92/visitor/SQL92Visitor.java
1
0%

shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/sqlserver/visitor/SQLServerVisitor.java
1
0%

Totals

Change from base Build 10686:
-0.05%

Covered Lines:
11737

Relevant Lines:
20469

💛  - Coveralls

This PR needs any committer merging, thx.


Blockly Issue #1246

https://github.com/google/blockly-samples/issues/1246

https://github.com/team-vibe-labs/blockly-samples/tree/carl/json-tritanopia-theme


1.10 - Recipient changes

We need to make a change to the 1.10 form, regarding how the “Recipient” section is handled.  For LDB, we would like it left as-is, as LDB staff generally know who to send their complaint to. In the case of PSA, some Complainants are sending the form to the wrong person, thereby creating more work for PSA staff, as well as possible privacy breaches.  As such, we would like the following changes, for PSA submissions only:
o  Allow the Complainant to specify who they want to send the form to (the Recipient) but do not automatically email the Recipient a copy of the complaint when they hit submit.
o  Change the wording in the Recipient section (PSA-only version of the form):
From: (Current PSA Wording on 1.10 Designated Form)

Recipient of written complaint – contact information
The person to whom you are submitting this written complaint. This complaint should be directed to your supervisor or first level of excluded manager (unless the complaint is about them), in which case give the contact information for the first level of excluded manager not involved in the complaint.

To: (Proposed PSA Wording on 1.10 Designated Form)

Recipient of written complaint – contact information
The person who you want to help resolve this complaint. This would normally be your supervisor or first level of excluded manager (unless the complaint is about them), in which case give the contact information for the first level of excluded manager not involved in the complaint. The Public Service Agency will confirm this is an appropriate Recipient and will provide them a copy of your complaint, so resolution discussions can begin.

AC

[ ] Automatic emails to recipients after submission are stopped
[ ] Copy for "Recipient of written complaint – contact information" is updated as described above

Hey @Andrew-Vargas-bcgov
For a LDB complaint, the text should remain the same as it is:
“When you submit your complaint, it will be automatically sent to you, to the recipient, and to the Director of Investigations & Intake, Public Service Agency (PSA), who will provide a copy of your complaint to your union within 10 days”
For a PSA complaint, the text should be changed to:
“When you submit your complaint, it will be automatically sent to you and to the Director of Investigations & Intake, Public Service Agency (PSA), who will provide a copy of your complaint to the recipient and to your union within 10 days”

Looking good!

Works well, will share with Don

this has been resolved and is Live - Closing tix


macos/README.md  bug error during execution of pip install docker==5.0.0 ...

Environment details:
Mac was used, but this applies to ANY OS.
Steps to reproduce the issue:
Follow all (mac) instructions to prepare the system.
When you execute the last command to install the prerequisite:
"pip install docker==5.0.0 ansible==4.1.0 jinja2==3.0.1 couchdb==1.2 httplib2==0.19.1 requests==2.25.1 six=1.16.0"
the terminal answer with the following error:
ERROR: Invalid requirement: 'six=1.16.0'.
Provide the expected results and outputs:
command pip install finished successfully.

Likely you can skip six at this point. Thanks for the bug report. If you've corrected the problem and want to submit a PR to update the doc, that'll be welcomed.

Of course, I can do that.


build: remove outdated tslint rule

At some point in tslint the no-unused-variable rule has been deprecated in favor of noUnusedLocals and noUnusedParameters. Since we don't want to have compilation errors for unused variables we re-implemented the no-unused-variable rule ourself and used it as a custom rule.

Recently we switched to a newer version of TSLint and TypeScript and the custom tslint rule won't ever work again. (tslint now requires a type-checker to be enabled). The custom rule fails currently and causes TSLint to not work with some editors (e.g Webstorm).

Note: TSLint un-deprecated the no-unused-variable rule again and it now requires the type-checker (and an according TypeScript project).
We are holding off with updating to the "new" no-unused-variable rule because:

It incorrectly adds failures: https://github.com/palantir/tslint/issues/2470
It would be easier to use when https://github.com/angular/material2/pull/4111 is merged (module.id fix)
There is no good approach yet. We have multiple tsconfig.json files inside of the whole repository.

@DevVersion just needs rebase

@jelbourn Done.


Bentley's Hackpack™ [PCSF00251]

App summary

App name: Bentley's Hackpack™
App serial: PCSF00251
App version: 1.00

Vita3K summary

Version: v0.1.8
Build number: 3271
Commit hash: https://github.com/vita3k/vita3k/commit/37e334b3
CPU backend: Dynarmic
GPU backend: OpenGL

Test environment summary

Tested by: guimi the tomo
OS: Windows 10/macOS/Linux Distro, Kernel Version?
CPU: AMD/Intel?
GPU: AMD/NVIDIA/Intel?
RAM: 6 GB

Issues

Game works, but you need to accept the EULA, so you're technically stuck in paris.
Screenshots

Log
vita3k.log~
Recommended labels

Ingame -
Menu
C?

how do I insert labels?

Version 3277
Same problem as before

Version 3278
Still in Paris

ugh, do I have to update this myself
App summary

App name: Bentley's Hackpack™
App serial: PCSF00251
App version: 1.00

Vita3K summary

Version: v0.20
Build number: 3568
Commit hash: idk lol
CPU backend: Dynarmic
GPU backend: OpenGL

Test environment summary

Tested by: guimi the tomo returns after hiatus
OS: Windows 10/macOS/Linux Distro, Kernel Version?
CPU: AMD/Intel?
GPU: AMD/NVIDIA/Intel?
RAM: 6 GB

Issues

After the Sly mask disappears, game loops into a black screen.
Screenshots
none
Log
i forgor 💀
Recommended labels

black screen

Well, it seems we got to arcade, you just need to be connected to PSN. Welcome to the arcade!

test for vita3k bot

Vita3K summary

Version: v0.2.0
Build number: 3685
Commit hash: https://github.com/vita3k/vita3k/commit/5857acd8
CPU backend: Dynarmic
GPU backend: Vulkan

Test environment summary

Tested by: Slade
OS: Microsoft Windows 10 Professional (build 19045)
CPU: Intel(R) Core(TM) i7-3770K CPU @ 3.50GHz
GPU: NVIDIA GeForce GTX 1060 6GB
RAM: 16 GB

Issues

Graphics glitches are evident when you select a game.
You may have to be "Signed in PSN" under Settings -> Network for the game to proceed correctly.
Some games require motion controls.

Screenshots

Log
vita3k.log
Recommended labels

Ingame +
graphics bug
motion missing


UserMessageCount is not correct

I've noticed that since a pull request of today, UserMessageCount (and, obviously, UserMostTalkative) is not correct. I'm trying to find a solution.

@pvdsp Investigating, think I've got the same issue in my test Slack.

@david1983 Any idea what could've gone wrong? I think the code broke since implementing it with fetch.

@pvdsp Can you make an example ?
I've tried to checkout the commit before the pull request and it shows the same data of the latest version
git checkout b60e5066a998457e61741efc93995e351abbcbe3
This is the screen of the b60e5066a998457e61741efc93995e351abbcbe3

This is the screen of the latest version

I'll let you know when I can replicate it. The issue was that the number of messages for each user didn't add up. The most talkative user of my slack team had well over a hundred messages, but Slack Statistics chose another user as most talkative, and printed that he had 20 messages (he, also, had over a hundred messages)

@david1983

As noted here, I'm unable to compile the Bower add-in components on my local build to test this. I'm not very experienced with Bower so probably missing a key step! Please can you assist @david1983?

@pvdsp Bower issues resolved and userMessageCount now appears to be correct! Latest updates close issue #24.

We unfortunately still have the issue that userMessageCount is incorrect. Slack Statistics displays 20 messages for the most talkative user, but in reality he has 132.

As far as I'm concerned, this bug is fixed. I will close the issue. Be free to re-open if the bug isn't completely fixed.

Great to hear @pvdsp @david1983 – thanks for the update!


Use new URL in README.md

Codecov Report

Merging #26 into master will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff          @@
##           master   #26   +/-   ##
====================================
  Coverage      24%   24%
====================================
  Files           5     5
  Lines         450   450
====================================
  Hits          108   108
  Misses        342   342

Impacted Files
Coverage Δ

Sources/PostgreSQLProvider/Error.swift
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9816437...9716be7. Read the comment docs.


Difference between queries using HTTP API and AQL when key is url encoded

My Environment

ArangoDB Version:      e.g. 3.3.10
Settings vanilla using docker image

When making a request to a table when the key contains '%' of a urlencode string (_key == 'www.moshe.com%2Fbbb' , using direct AQL thru the console will properly find the document, but using HTTP API will give a 404
Steps to reproduce
AQL (Works perfectly):
FOR doc IN Url
FILTER doc._key == 'www.moshe.com%2Fbbb'
RETURN doc
Result:
[
{
"_key": "www.moshe.com%2Fbbb",
"_id": "Url/www.moshe.com%2Fbbb",
"_rev": "XHxz80K--"
}
]
Using HTTP API:
curl -vv --header Content-Type: --compressed --user "root:" --header "Connection: keep-alive" --user-agent "python-requests/2.19.1" --data-binary "{}" --request PUT http://<IP_ADDRESS>:8529/_db/labdbTest/_api/document/Url/www.moshe.com%2Fbbb?collection=Url&waitForSync=False
*Note about the CURL: the curl was created from a pcap capture between the client and DB and seems ok, so the problem is not on the client side, but with how the server parses the request

Hi @omerzohar,
thanks for reporting this issue and providing a detailed description.
In order to use curl with '%' included in the document key, '%' has to be escaped to '%25', which is the two-digit hexadecimal of its byte value. Therefore you have to use your curl command with www.moshe.com%252Fbbb instead of www.moshe.com%2Fbbb.
Any other special character can be encoded the same way (see HTML codes table - Hex column).

@omerzohar
Has the previous suggestion solved your problem?

As explained by @maxkernbach a double escape is required since the / has 3 meanings here:

separator in the HTTP Uri
separator <collection/key> (in document IDs)
string inside the document ID.

Closing this as solved with the availability of ArangoDB 3.7 .


Create helper function for FilterInstance + getting State from Presenter

Inside CompositePresenters we have a pattern of filtering events then pushing them to a presenter to extract the state as follows:
val rememberPetListFilterEventFlow = remember {
      events.filterIsInstance<HomeScreen.Event.PetListFilterEvent>().map { it.event }
    }
val petListFilterState = petListFilterPresenter.present(rememberPetListFilterEventFlow)

Let's create a helper function for this.

This was merged


Unhelpful error when "execute" fails

When an execute call fails, an unhelpful error is thrown, that makes it difficult to debug:
Error: ERROR processing /deploy/deployment.js:
ProviderError: The execution failed due to an exception.
    at HttpProvider.request (node_modules/hardhat/src/internal/core/providers/http.ts:46:19)
    at HDWalletProvider.request (node_modules/hardhat/src/internal/core/providers/accounts.ts:131:34)
    at process._tickCallback (internal/process/next_tick.js:68:7)
    at DeploymentsManager.executeDeployScripts (node_modules/hardhat-deploy/src/DeploymentsManager.ts:991:19)
    at process._tickCallback (internal/process/next_tick.js:68:7)

I wonder if it's possible to pre-generate an error, so that the stack trace points to the failing call in the deployment script

I agree, I would like to improve that.
Need to look into it. If you have ideas, feel free to make a PR or propose some outline

I agree, I would like to improve that.
Need to look into it. If you have ideas, feel free to make a PR or propose some outline

I have run into the same issue.

+1 no idea what is going on. Error message is way too vague


Update Runtime Versions to Latest Available

Description
Updates runtime dependencies to the latest version available, except Jackson and Reactor dependencies. Additionally, this removes external dependencies that aren't used anywhere.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.


Bonfire: Return Largest Numbers in Arrays

I wrote a correct solution which did all that was required and I think better than it was asked.
This works. However, it does not let me pass.
var myArr = [];
function largestOfFour(arr) {
// You can do this!
for (var i = 0; i < arr.length; i++) {
myArr.push(Math.max.apply(null, arr[i]));
}
return myArr;
}

thorgall, which exercise was this?

It's because myArr is a global variable and doesn't get cleared upon subsequent function calls.

@sludge256 is correct.
Thanks and Happy Coding!


[BugFix] Fix incorrect result for date formatting

What type of PR is this：

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：
When the job is in some time zones, Date type data will be converted to the previous day at 00:00 ~ 08:00. e.g. 2024-06-12 will be converted to 2024-06-11
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)
[ ] I have added documentation for my new feature or new function

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.dusukang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

When SimpleDateFormat formats the date and time, it uses the default time zone of the JVM by default. If the default time zone of the JVM does not match the actual requirements, it will cause deviations in the time display.


toMatchObject doesn't work well with Proxy objects

Describe the bug
It seems like toMatchObject doesn't work well with proxy objects, and won't call the handler to check equality.
Reproduction
  const proxyObj = new Proxy(
    { foo: "bar" },
    {
      get(target, prop, receiver) {
        if (prop === "bar") {
          return "foo";
        }
      },
    },
  );

  // this is equivalent object without proxy
  const obj = { foo: "bar", bar: "foo" };

  // passes correctly
  expect(obj).toMatchObject({ bar: "foo" });
  // passes correctly
  expect(proxyObj.bar).toBe("foo");
  // fails incorrectly
  expect(proxyObj).toMatchObject({ bar: "foo" });

AssertionError: expected { foo: undefined } to match object { bar: 'foo' }
(1 matching property omitted from actual)

- Expected
+ Received

  Object {
-   "bar": "foo",
+   "foo": undefined,
  }

System Info
System:
    OS: macOS 15.0.1
    CPU: (8) arm64 Apple M1
    Memory: 65.80 MB / 16.00 GB
    Shell: 3.7.1 - /opt/homebrew/bin/fish
  Binaries:
    Node: 20.11.0 - ~/.local/state/fnm_multishells/83610_1728461619670/bin/node
    Yarn: 4.1.0 - ~/.local/state/fnm_multishells/83610_1728461619670/bin/yarn
    npm: 10.2.4 - ~/.local/state/fnm_multishells/83610_1728461619670/bin/npm
  Browsers:
    Chrome: 129.0.6668.100
    Firefox: 130.0.1
    Safari: 18.0.1
  npmPackages:
    vitest: ^2.1.1 => 2.1.1

Used Package Manager
yarn
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Probably this is because toMatchObject is checking hasOwnProperty
https://github.com/vitest-dev/vitest/blob/a8299df2140d2a1a62bec704514fd7e2163c9b18/packages/expect/src/jest-utils.ts#L527-L527
It looks like proxy intercepting more things. For example, something like this can make "more equivalent" object as plain one and toMatchObject and error diff work https://stackblitz.com/edit/vitest-dev-vitest-kuacmv?file=test%2Frepro.test.ts
const proxyObj = new Proxy(
  {},
  {
    get(target, prop, receiver) {
      if (prop === 'bar') {
        return 'foo';
      }
    },
    getOwnPropertyDescriptor(target, prop) {
      if (prop === 'bar') {
        return { configurable: true, enumerable: true };
      }
      return Reflect.getOwnPropertyDescriptor(target, prop);
    },
    ownKeys() {
      return ['bar'];
    },
  }
);

// pass
expect(proxyObj).toMatchObject({ bar: 'foo' })

// error diff
//   Object {
// -   "bar": "not-foo",
// +   "bar": "foo",
//   }
expect(proxyObj).toMatchObject({ bar: 'not-foo' })

Though this seems technically possible, I don' think people usually go this far for proxy implementation, so it might make sense to loosen toMatchObject (or specifically subsetEquality) to skip hasOwnProperty check:
https://github.com/vitest-dev/vitest/blob/a8299df2140d2a1a62bec704514fd7e2163c9b18/packages/expect/src/jest-utils.ts#L567-L573

expect.objectContaining({ bar: "foo" }) also requires hasOwnProperty. So, if we change toMatchObject, then we probably should change this too.
https://stackblitz.com/edit/vitest-dev-vitest-dr5jfq?file=test%2Frepro.test.ts
https://github.com/vitest-dev/vitest/blob/2a50464d58e98f58fed513971a570a952081bfef/packages/expect/src/jest-asymmetric-matchers.ts#L148-L156

@jimmycallin Btw, can you explain your actual use case? We think either behavior seems fine (current one or https://github.com/vitest-dev/vitest/pull/6675), but knowing a concrete use case would help decisions. For example, is proxy coming from some well-known library or your specific implementation?

@jimmycallin Btw, can you explain your actual use case? We think either behavior seems fine (current one or #6675), but knowing a concrete use case would help decisions. For example, is proxy coming from some well-known library or your specific implementation?

Sure! It may be a bit esoteric, but using we are using react-query which has a concept of tracked queries, which checks which properties you actually use to reduce rerenders in react. We have a wrapper around a useQuery function that adds a few properties, which naively would look something like this:
function useWrapper() {
    const query = useQuery(...);
    return {...query, additionalProperty: true }
}

Unfortunately the rest spread causes it to "trigger" each property, which nullifies the optimization. So we use a proxy to get around it:
function useWrapper() {
  const query = useQuery({...});
  return new Proxy(query, {
    get(target, prop, receiver) {
      if (prop === "additionalProp") {
        return true;
      }
      return Reflect.get(target, prop, receiver);
    },
  });
}

Then we use react-testing-library to test the result of the hook.
Hope this makes sense!

Interesting, wrapping useQuery sounds like a sensible use case.
How about defining getOwnPropertyDescriptor / ownKeys? I guess it would be too tedious? (honestly I didn't even know such proxy handler exists :smile:)

Interesting, wrapping useQuery sounds like a sensible use case. How about defining getOwnPropertyDescriptor / ownKeys? I guess it would be too tedious? (honestly I didn't even know such proxy handler exists 😄)

We had that previously, but just changed to Proxy after I saw this discussion that Proxy was a lot more performant: https://github.com/TanStack/query/discussions/8091
Which is what triggered this issue. :)

What I was suggesting is to implement getOwnPropertyDescriptor and ownKeys of proxy:
function useWrapper() {
  const query = useQuery({...});
  return new Proxy(query, {
    get(target, prop, receiver) {
      if (prop === "additionalProp") {
        return true;
      }
      return Reflect.get(target, prop, receiver);
    },
    getOwnPropertyDescriptor(target, prop) {
      if (prop === 'additionalProp') {
        return { configurable: true, enumerable: true };
      }
      return Reflect.getOwnPropertyDescriptor(target, prop);
    },
    ownKeys(target) {
      return [...Reflect.ownKeys(target, prop), 'additionalProp']
    },
  });
}

But, I think https://github.com/TanStack/query/pull/8092 proves the point. If useQuery implements only Proxy.get, then Reflect.getOwnPropertyDescriptor won't probably work for downstream proxy.

After discussing with the team, we decided to not remove hasOwnProperty check on our side.
Since proxy can be implemented properly to imitate an object, it's not good for test framework to go loose about this.
Here is an alternative if users need to implement proxy for Vitest assertions to work.
const obj = { foo: "bar", bar: "foo" };

const proxyBad = new Proxy(
  { foo: "bar" },
  {
    get(target, prop, receiver) {
      if (prop === "bar") {
        return "foo";
      }
    },
  },
);

const proxyGood1 = new Proxy(
  // 👇 define key on base object
  { foo: "bar", bar: undefined },
  {
    get(target, prop, receiver) {
      if (prop === "bar") {
        return "foo";
      }
    },
  },
);

const proxyGood2 = new Proxy(
  { foo: "bar" },
  {
    get(target, prop, receiver) {
      if (prop === "bar") {
        return "foo";
      }
      return Reflect.get(target, prop, receiver)
    },
    // 👇 define custom handler
    getOwnPropertyDescriptor(target, prop) {
      if (prop === 'bar') {
        return { configurable: true, enumerable: true };
      }
      return Reflect.getOwnPropertyDescriptor(target, prop);
    }
  },
);

Object.hasOwn(obj, 'bar') // true
Object.hasOwn(proxyBad, 'bar') // false
Object.hasOwn(proxyGood1, 'bar') // true
Object.hasOwn(proxyGood2, 'bar') // true


Dir

Making dir correct:
dir on type: list attributes of type (including parents)
dir on instance: list attributes of instance, type, and parents.
dir on module: list names in module (and nothing else).
Implemented via dir so it can be customised, and each obj* only inspects its own payload.

Codecov Report

Merging #614 into master will increase coverage by 0.12%.
The diff coverage is 64.28%.

@@            Coverage Diff             @@
##           master     #614      +/-   ##
==========================================
+ Coverage   40.83%   40.95%   +0.12%
==========================================
  Files          75       76       +1
  Lines       17192    17252      +60
  Branches     4518     4523       +5
==========================================
+ Hits         7020     7066      +46
- Misses       8177     8179       +2
- Partials     1995     2007      +12

Impacted Files
Coverage Δ

vm/src/builtins.rs
36.95% <33.33%> (+0.19%)
:arrow_up:

vm/src/obj/objtype.rs
41.61% <50%> (+0.1%)
:arrow_up:

vm/src/obj/objobject.rs
39.23% <57.89%> (+0.81%)
:arrow_up:

vm/src/pyobject.rs
59.37% <80%> (+0.04%)
:arrow_up:

vm/src/obj/objmodule.rs
82.35% <82.35%> (ø)

wasm/lib/src/browser_module.rs
0% <0%> (ø)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5ead87...d769fa9. Read the comment docs.


[FEAT] PAM Duress Passwords

Describe the benefit this feature would provide to the project
We put a lot of effort into security. We require strong password, and more often than we used to we add two-factor/multi-factor authentication to the mix. That’s on top of the firewalls, proxies, and the VPN, and maybe intrusion detection and some others too.
That makes me wonder if it’s time to borrow an idea from the world of physical security – duress codes. Many alarm systems are configured so that if the duress code is entered the alarm appears to be deactivated but still signals the monitoring center. We could do the same thing for the passwords for key personnel, letting them configure a second password that would be a minor variation of the first – maybe one letter switched from lower to upper case. When activated not only could it send the secret alert, it could activate additional defensive measures.
Describe the solution you'd like
The PAM Duress is a module designed to allow users to generate 'duress' passwords that when used in place of their normal password will execute arbitrary scripts. For quickly wiping all hardware keystore keys including keys used as part of deriving the key encryption keys for disk encryption to make all OS data unrecoverable.
Since this project borrows some features from GrapheneOS, and graphene itself is now using duress passwords, I belive it would be a good add.
Describe alternatives you've considered
The alternative would be a "local fail2ban" but not scope of this feature.
Basically this suggest an alternative to mitigate, and give yourself alternatives for the infamous "$5 wrench attack".
Declaration

[ x] I declare that I have read the README and my feature request is in-scope.

I am not sure how to do this safely, but here is an idea:

Cause corruption to the LUKS header
Run trim
Reboot the computer

But this strategy is just praying that the SSD controller actually trims the old LUKS header. And I am not sure how this even shows up in the UI.

The other approach is to use TPM unlock for disk encryption, and just wiping the TPM when the duress password is entered.
The problem with this is that, this puts complete trust into the TPM, and is vulnerable to stuff like faultpm. It is not a safe implementation like on Android.

@DimSystem
I'll summarize the discussion I had with Tommy about this on discord in #dev. On the surface, it seems simple, the login manager just needs to trigger a pam module right? Unfortunately, for several reasons, this is not the case:

Since this would only provide duress passwords at the display manager, which is loaded well after the drive is unlocked, an attacker with physical access would still be able to do a cold boot attack on systems without memory encryption, which would be the vast majority of them.
Invoking a command to wipe the LUKS header would require detecting the drive type the OS is on (including SATA vs NVMe SDDs vs HDDs, querying for the drive capabilities, and then determining which secure erasure functionality would suffice (e.g. ATA Secure Erase). And even then, on some drives this would be a slow process.

For both of these reasons, implementing duress passwords at the display manager level would provide the illusion of security and serve only to mislead users.
Given this, the logical next step would be to move the duress functionality to the disk unlock screen. However, systemd has no support for this as far as I know. Until and unless that changes, there won't be a way to properly implement this.

Since this project borrows some features from GrapheneOS, and graphene itself is now using duress passwords, I belive it would be a good add.

On GrapheneOS the OS itself is separate from the encrypted user data, so the OS can be loaded and show the initial unlock screen before any user data is decrypted. This is not the case on desktop linux systems, where the OS itself is in the same encrypted volume as the user's data.
Please reopen this if you encounter any information about systemd/crypsetup implementing duress password support.


[SC] Send transactions using unconfirmed outputs

Closes #2801 and #2800

I know CoinViewRule is notoriously hard to test... but is there a way we could create an integration test to demonstrate #2801?

Good call @rowandh did so and realised the controllers weren't allowing it properly.


[SPARK-35417][BUILD] Upgrade SBT to 1.5.2

What changes were proposed in this pull request?
This PR aims to upgrade SBT to 1.5.2 for better Scala 2.13.x support.
Why are the changes needed?
SBT 1.5.2 Release Note: https://github.com/sbt/sbt/releases/tag/v1.5.2

Fixes ConcurrentModificationException while compiling Scala 2.13.4 and Java sources zinc
Uses -Duser.home instead of $HOME to download launcher JAR
Fixes -client by making it the same as --client
Fixes metabuild ClassLoader missing util-interface
Fixes sbt new leaving behind target directory
Fixes "zip END header not found" error during pushRemoteCache

Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.

Test build #138592 has started for PR 32565 at commit e05dad0.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43113/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43113/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43113/

Test build #138592 has finished for PR 32565 at commit e05dad0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged to master.

Thank you, @HyukjinKwon .

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138592/


Syncing from upstream zalando/patroni (master)

bt_gitbot

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

32 of 32 (100.0%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.858%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
12685

Relevant Lines:
12703

💛  - Coveralls


Lazy conversion causes issues with null values

This is really an issue with downstream logic probably, but it would still be nice to turn off lazy-conversion. It seems PDI's Select Values (and other) steps have trouble dealing with null binary-string data and cause an exception.

Scratch that, it seems that many steps downstream from this Input step have issues dealing with the Binary-String types that are resulting from the Input step.


Blocked in deploy status

My staging app is blocked with deploy status. Looks like deploy never ends. Could you help me ? Thanks
Here's my domain :
https://www.alacaza.dev

@gsohn what's your appid? Also what error are you getting in deploy?

My gatsby client generates 10K pages. It seems this is too much for the deployment process as it takes more than two hours to copy all files. So I deleted my amplify applications. Do you have any coming action to improve deploy process ?
Thanks for your help

@gsohn in general yes but it's difficult to speculate what issue you're hitting without more data, if you can provide us with an example app id / region / build number and any error messages you're seeing we can better understand what's happening with your particular deploys.

I don't have any log as I deleted the applications, sorry. But this happened during the deploy phase, when copying files, and generally around 25K copy. But you can close the issue as I don't use amplify any more. Thanks

Closing this issue, please feel free to re-open if you are still facing issues.


Hiring Panel for Platform Admin(s) - Jon

Describe the issue
Cloud Pathfinder requires Platform Admins to help the team with operationally manage Azure, GCP and AWS
Additional context
Add any other context, attachments or screenshots
Definition of done

Work with PO to review existing JD and TA position
3 hours of interview meetings
Panel review, documented and stored on LAN

Shared the material, brought Jon up to speed, reviewed the submissions verbally, pulled him in to the scoring review meeting this afternoon

Closing ticket, Jon helped me with this


Add path length check on root path on Windows (for serapi).

Serapi compilation produces rather long paths, which can conflict with the 256 char limit on Windows. Implement a check that the cygwin root install path and user folder path are not too long.

Triage note: it currently works with the reduced and more reproducible path lengths. This is still nice to have but low prio.


Add tracking for Aurora BIFI/WETH

we merge master into prod locally without PR to keep git history same


Added info on make install-docs

See https://github.com/samuelcolvin/pydantic/pull/4231#issuecomment-1188846944

Change Summary
Mentioned the need to run make install-docs
Related issue number
#4231

Checklist

[ ] Unit tests for the changes exist
[ ] Tests pass on CI and coverage remains at 100%
[ ] Documentation reflects the changes where applicable
[ ] changes/<pull request or issue id>-<github username>.md file added describing change
(see changes/README.md for details)
[x] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

please review

Thanks @drorata for this patch :+1:
I think install-docs is already included in make install
https://github.com/samuelcolvin/pydantic/blob/50bc758495f5e22f3ad86d03bcf6c645a7d029cf/Makefile#L25
Maybe @samuelcolvin meant to include it on make docs :thinking:

Probably my bad interpretation. But if it's in the make install, why would it need to be run again separately?

That's my question as well. as it is in make install I think we don't need to run it again.
but let's wait for @samuelcolvin. maybe he meant including it in the make docs target.

I think you're right, this is not required since it's installed by make install.
Unless we remove proxy and touch files to prevent repeat make calls (which I guess we could start doing? It's slightly different conversation), we don't want to include this in make docs since that's called often when working on docs.

Sorry about the mistake, the original issue was pipenv, not missing docs, I was just trying to help while on my phone.


Short paths

Works for VS Code but not when you npm start :trollface:

Tested again today - no success, same problems as before see writeup :trollface:
🤷♂  I think the service worker causes some problems I wouldn't otherwise have 🤔

Tested again today (Angular updated several times since before), still doesn't work :trollface:


feat: attest avatar and name in identity kit

What changed? Why?

add attestation to Avatar and Name components using EAS attestation

Name
Avatar

Notes to reviewers
This PR is not in an ideal state but let's use this PR to discuss bunch of stuff...
How has it been tested?
locally

That's dope, and we can merge this and do a quick follow up to get into what is a more flexible API for those components.
Like expand the config to support
type OnchainKitProviderProps = {
  identity: {
    address: Address;
    attestationList: {
      schemaId: EASSchemaUid;
      chain: Chain;
    }[];
    attestationDefaultId: EASSchemaUid;
  };
  children: ReactNode;
};

which will allow us to have a default experience like
<OnchainKitProvider identity={}>
  <Avatar displayBadge />
  <Name displayBadge />
</OnchainKitProvider>

and more custom experience like
<OnchainKitProvider identity={}>
  <Avatar address={address} displayBadge />
  <Name address={address} displayBadge />
</OnchainKitProvider>

and
<OnchainKitProvider identity={}>
  <Avatar address={address} attestationId={attestationId} displayBadge />
  <Name address={address} attestationId={attestationId} displayBadge />
</OnchainKitProvider>

Great job @kyhyco 👏


can responder served by waitress？

Hi @sylvoslee . No, responder can not be served with Waitress. Waitress is a WSGI server, while Responder is an ASGI app/service.

Maybe there can be an ASGI-equivalent of it somwhere, or you can mount waitress

@sylvoslee the most known asgi servers are

Hypercorn
Uvicorn
Daphne

@sylvoslee I successfully run responder via waitress in https://github.com/the-benchmarker/web-frameworks/pull/3958


Fixed a few more warnings

Thank you @ammachado, its a good PR -- I've just made a couple of notes on lines above. Its a touch more effort but definitely worth it for those who follow

I think overall code looks great. I enjoy the push for consistency in formatting and the usage of 'readonly' as well as protected ctors on abstract classes.

Hey @ammachado, This PR has been silent for almost two weeks, any progress on some of these requested changes?

Sorry guys, I was on vacation.  I'll make the changes ASAP.

No worries mate! Thanks!

Great changes @ammachado, I'm going to merge this in now, as we make more changes here it gets harder for me to review each time. Thanks!

I merged this change in and then had to undo it because it caused an issue.  It seemed like the data wasn't being pushed to the bridges properly. In the future please try to keep pull requests focused on a particular issue or area of the code to make reviewing the changes easier.


close #26

added TCP throughput benchmark.
Results on my machine (4 core intel I7 Asus G7 gaming laptop)
Helios TCP Message Throughput Test
How quickly can we send messages along the following route?
Client Send --> Server Receive --> Server Send --> Client Receive
Testing for 10000 200b messages
00:00:00.0860000
Testing for 100000 200b messages
00:00:00.8800000
Testing for 1000000 200b messages
00:00:05.5360000
Testing for 10000000 200b messages

Minimal impact on memory and CPU utilization, although if I turn the benchmark up to 10 million messages

Doing about 125,000 messages per second - but bear in mind that a single Helios server can do this for multiple TCP clients at once with minimal throughput. Bottleneck here was the 1:1 client server relationship.

This benchmark is really all over the place - in order for it to be official it really needs to be done on a build agent.


datapath: Clarify loader interfaces

Split the EndpointConfiguration datapath interface into
CompileTimeConfiguration and LoadTimeConfiguration. This makes it
clearer to developers how the settings must be applied, and also allows
us to ensure that the template structure is correctly updated to
templatize global data (because extending LoadTimeConfiguration forces
developers to also extend the templateCfg structure).

test-me-please

Coverage remained the same at 45.519% when pulling 96250658fc966afd6ff0828039c968b60e844b30 on joestringer:submit/clarify-loader-cfg-interface into d933cfe08b55037ee980b608de20a4746f4da465 on cilium:master.


Fixes lint job

It seems that there are some issues when using the 6.0.0 pylint, resulting in the following errors:
...
    self._current_group.add_argument(*option_args, **option_kwargs)
  File "/usr/lib/python3.8/argparse.py", line 1385, in add_argument
    raise ValueError('%r is not callable' % (type_func,))
ValueError: 'int' is not callable

Puting an upper constraint fixes the issue.

Lint job now passes.


Update project readme

Update project readme:

Add the links to Edge store listing.
Replace all the screenshots
Remove repeating information in the "debugging" section.

The updated readme can be viewed at https://github.com/makkoncept/ccsearch-browser-extension/tree/update_readme
Checklist:

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the master branch of the repository.
[x] My commit messages follow best practices.
[ ] I added tests for the changes I made (if applicable).
[x] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

@aldenstpage , @kgodey Please review.


/setblock does not light custom portals

Describe the bug
With normal portals, using /setblock ~ ~ ~ fire will light them. However, the custom portals from Teak's Tweaks can only be lit using a flint and steel or fire charge.
To Reproduce
Steps to reproduce the behavior:

Build a custom portal
Stand in it and run /setblock ~ ~ ~ fire
It does not light. You can try this with a regular portal and it lights.

Paste
PasteBook
Expected behavior
The portal should light, just the same as a normal portal.

Thanks for the report! Looking into this, it seems that /setblock isn’t really exposed to spigot’s api, and while it would theoretically be possible, from every way i’ve found it would way overcomplicate it, and end up with more bugs than it’s worth.
Will continue looking into the feasibility of this, but for now marking it as Won’t Fix.

Sorry to continue this, but I've found an event that seems to be able to detect setblock and even fill. The only problem is that it triggers for every updated block, not including the main fire block. You can still find the coordinates of the fire, but it triggers more than once.
@EventHandler
public void onIgnite(BlockPhysicsEvent event) {
    if (event.getChangedType() == Material.AIR) {
        if (event.getSourceBlock().getWorld().getBlockAt(event.getSourceBlock().getLocation()).getType() == Material.FIRE) {
            broadcast(Component.text(event.getSourceBlock().getLocation().toString(), NamedTextColor.AQUA));
        }
    }
}

I’ll see how the performance would be with this, but I do know this event often triggers hundreds of times per second, so for such a niche issue i don’t know if it would be worth the performance hit


Update README.md

Updates few lines

Description

Checklist

[ ] This pull request was tested on both of:

[X] PowerShell 5.1 (Windows)
[ ] PowerShell 6.x
[ ] PowerShell 7.x (Latest PowerShell)

[X] Scripts do not contain static passwords or other secret tokens.
[X] All Azure resource identifiers which must be universally unique are guaranteed to be so.

Testing information

Platform and PowerShell version: [pscustomobject]$PSVersionTable | Select-Object OS, BuildVersion, PSVersion
Az version: (Get-InstalledModule -Name Az).Version

@mikefrobbins - Sending teh updated readme.md file. I had checked in the wrong version by mistake earlier

sign-off


WOM Enchanted Staff not applying -1 CN after renaming Active Effect with the Proper Lore name

WOM Enchanted Staff not applying -1 CN after renaming Active Effect with the Proper Lore name
Renamed the Enchanted Staff Active effect from Staff of "<>" to "Staff of <>" (Metal) and it fails to apply the -1 CN to Metal spells.
Foundry 10.291, WFRP 6.4.0, WOM 3.0.0
The JSON script to identify the Lore doesn't seem to work:
let lore = this.effect.label.split(" ")[2].toLowerCase();
I made a temp fix to use the Standard Robes JSON to identify the lore "type" and Separated the Active Effect Lore name by "()" bracers insead of "<>" bracers for the Enchanted staff and that seemed to work:
let lore = this.effect.label.split("(")[1].split(")")[0].toLowerCase();
Foundry:
wfrp4e:
wfrp4e-core:
wfrp4e-starter-set:
wfrp4e-rnhd:
wfrp4e-eis:
wfrp4e-ua1:
wfrp4e-dotr:
wfrp4e-archives1:
wfrp4e-middenheim:
wfrp4e-archives1:
wfrp4e-pbtt:
wfrp4e-altdorf:
wfrp4e-ua2:
wfrp4e-owb1:
wfrp4e-horned-rat:
wfrp4e-empire-ruins:

Staff of "<>" to "Staff of <>" (Metal)

This isn't the proper format. If you follow the instructions in the description, it should work correctly.


[NDM][NDMII-2634] move the snmp_listener config under network_devices

What does this PR do?
Move the snmp_listener under the network_devices while making sure that the old config is still working
The new config should be preferred if both are given, a test has been added
Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

LGTM

@rtrieu I added a release note since your comment so you can recheck

/merge


Mpfs icicle qspi support

This patch adds driver support for Microchip's Polarfire SOC MSS QSPI peripheral.
Tested this patch on Microchip's ICICLE kit which has MT25QL256 Micron SPI NOR
flash on it. This is tested using generic spi-nor flash driver.
This patch also adds the spi-nor flash node to mpfs-icicle.dts.

Hi @con-pax! Thanks for your contribution.
It looks like a lot of build failures in the CI can be linked to the mss_qspi* symbols being declared, but not being used anywhere. Could you fix this?

Hi @con-pax! Thanks for your contribution.
It looks like a lot of build failures in the CI can be linked to the mss_qspi* symbols being declared, but not being used anywhere. Could you fix this?

Hi @fkokosinski, Thanks for checking this out. Yes, we are in the process of fixing and rebasing.

Can we ignore this error? As this warning is treated as error in this test. The other SPI drivers are also modeled in the same manner. Can you please let me know, if I need to correct something here?
Thanks, Suresh.

Sorry, unfortunately this PR won't be merged if CI isn't green. Are you sure that the MSS_QSPI_INIT is used at all? I.e., how does this file look like after preprocessing. Because it looks like the DT_INST_FOREACH_STATUS_OKAY doesn't call it at all, and that's why we get these unused symbols. Could you check that?

Can we ignore this error? As this warning is treated as error in this test. The other SPI drivers are also modeled in the same manner. Can you please let me know, if I need to correct something here?
Thanks, Suresh.

Sorry, unfortunately this PR won't be merged if CI isn't green. Are you sure that the MSS_QSPI_INIT is used at all? I.e., how does this file look like after preprocessing. Because it looks like the DT_INST_FOREACH_STATUS_OKAY doesn't call it at all, and that's why we get these unused symbols. Could you check that?

Hi @fkokosinski ,
I will check and get back to you.
We have tested it on Polarfire SOC Icicle board and we are able to see that "DT_INST_FOREACH_STATUS_OKAY" is getting called.
Thanks for your time.

Can we ignore this error? As this warning is treated as error in this test. The other SPI drivers are also modeled in the same manner. Can you please let me know, if I need to correct something here?
Thanks, Suresh.

Sorry, unfortunately this PR won't be merged if CI isn't green. Are you sure that the MSS_QSPI_INIT is used at all? I.e., how does this file look like after preprocessing. Because it looks like the DT_INST_FOREACH_STATUS_OKAY doesn't call it at all, and that's why we get these unused symbols. Could you check that?

Hi @fkokosinski , I will check and get back to you. We have tested it on Polarfire SOC Icicle board and we are able to see that "DT_INST_FOREACH_STATUS_OKAY" is getting called. Thanks for your time.

Hi @fkokosinski ,
It seems that this (spi_mpfs_mss_qspi.c) driver is getting compiled for other architectures.
As the device tree files is not getting included but the driver is compiled, hence this error
I have to update the spi driver Kconfig file ( Kconfig.mchp_mss_qspi) to depend on SOC_MPFS, so that it will get compiled only for SOC_MPFS.
In my local setup I will only compile it for SOC_MPFS, hence I didn't see this warning.
I will update it.
Thanks,
Suresh


Idea: Change logic for actions with checked rows

Sometimes (in my cases as a rule) it is necessary to make action with filtered rows (i.e. status='active'), but not for only selected rows.
I offer:

rename With selected to Actions
if user check rows - action will be executed for selected rows
if user apply filters and doesn't check anything - action will be executed for filtered rows
in other cases action will be executed for all rows

For any case developer can add own JS alert message, i.e.:

Do you want to apply action for selected rows?
Do you want to apply action to filtered rows?
Do you want to apply action to all rows?

Also developer can disable action for filters or | and all rows case.
If you ok with this idea - I'm ready to do it.
Thanks!

Closing this now, but please re-open if it's still relevant.


Update azure-cosmosdb-ads-extension version to 0.1.4

This PR fixes updates azure-cosmosdb-ads-extension to version 0.1.4 and fixes its Engine dependencies.
Please find the signed VSIX build here.

@languy how about the stable gallery file?

@languy The file size was pretty large so I took a look at the contents, it turns out it contains a lot of files that shouldn't be there. Please fix the script and at least remove item 3 from the package.

mongoshell - should be downloaded at runtime, for offline environment, you can provide platform specific vsix files.

a large JSON file - is this really needed?

ADS binaries - these should definitely not be here.

@languy The file size was pretty large so I took a look at the contents, it turns out it contains a lot of files that shouldn't be there. Please fix the script and at least remove item 3 from the package.

mongoshell - should be downloaded at runtime, for offline environment, you can provide platform specific vsix files.

a large JSON file - is this really needed?

ADS binaries - these should definitely not be here.

My original design was indeeed to download these binaries from the ADS storage just like how other extensions do it with their binaries, but our security team added two items to address:  a/ DOS prevention for the storage hosting the mongo binaries b/ Update mechanism for the mongo binaries.
What was recommended to me at the time to alleviate b/ and get past the review was to ship the extension with the binary and rely on ADS/Vscode version extension mechanism to update these shipped binaries (if the user doesn't prevent extension updates).
Let me revisit these tickets with our (new) security. I'll challenge c/ as a non-issue, since the extensions itself along with all other extensions live on the same storage. And forcing an update of the extension may update the zip files that ship, but not the unzipped files. Downloading the zip and deleting the local unzipped files upon activation/installation should be sufficient.

This is the sample data (we have a "Sample Data" button that creates a collection and imports the sample data. Can definitely be downloaded from storage.

Will work on removing: this was accidentally introduced when I fixed the unit tests in CI (which now download ads instead of vscode to perform the tests).

0.1.4 is a hotfix for a customer issue. So I would like to ship 0.1.4 asap with 1. and 2. (without 3.) and create a 0.2.0 version without 1. and 2. subsequently if that's ok with you guys.

@languy sounds good to me.

I updated the download link in the description.


Add NearestCentroid Classifier

Add NearestCentroid Classifier model into the library.
Primary File to Change: https://github.com/blobcity/autoai/blob/main/blobcity/config/classifier_config.py
Reference NearestCentroid Classifier Implementation:
https://github.com/blobcity/ai-seed/blob/main/Classification/Nearest Centroid/NearestCentroidClassifier.ipynb
Dependencies if any, must be appropriately added. Test run of the train function on a classification problem must pass, and the function must attempt to train a NearestCentroid Classifier as a potential best fit model.

Please assign me this issue, I will do the best possible.
Btw, can I test the model on any publicly accessible data set right?

Done, assigned to you @Tanuj2552. Yes, try on any public classification dataset. We are also setting up some test scripts. If those get done before, you can use them.

Commit with PR #78 added to solve this

New commit with PR #88 added to solve this issue after a discussion on PR #78


chore(deps): bump @nrwl/* from 12.5.7 to 12.6.2

`nx-dotnet' doesn't work with lastest nx(12.6.2), issue is described here: https://github.com/nx-dotnet/nx-dotnet/issues/73
I am having issues when running tests. so feel free to drop this PR if it introduces new issues.

Actually, this looks like some stuff went wrong with the Nx migration. There may have been some undocumented breaking changes facing nx-plugin that did not have migrations. I'll add a commit onto this and get it merged 😄

@all-contributors please add @jimsleon for  code


Creation of readme, now in more suitable directory

Hope the formatting is OK?
I aimed to put in useful and relevant links, but without cluttering too much.

Very nice, thank you!


New section for node operators

First version will just have information on how to update to the latest version but eventually this section will house guides on how to set up a data node & validating node, etc.

[x] Create new section
[ ] Add migration guide for 0.50.x to 0.51.x (@jeremyletang)
[ ] add to Key Rotation for ethereum (@karlem)
[ ] Set up a data node guide (@pscott31)

Closed automatically by accident - @gordsport this'll be back on the boards now

Moved the 2 open items into separate tickets, as the section is live so the original intent of this ticket is completed.
https://github.com/vegaprotocol/documentation/issues/163
https://github.com/vegaprotocol/documentation/issues/163


feat(NiFi): NiFi deployment ansible-playbooks

Which issue(s) this PR fixes:
Fixes #34
Additional comments:
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004 and that you give permission to TOSIT,
you have to acknowledge this by using the following check-box.

[x] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
[x] I hereby agree to grant TOSIT a copyright license to use my contributions.

Related Issues:

https://github.com/TOSIT-IO/TDP/issues/15
https://github.com/TOSIT-IO/tdp-getting-started/issues/108

@pm-McFly can you please open a new discussion about Nifi integration in TDP ?
Thank you again for your contribution to TDP.

Close as stale.


Oblivious LRU with delete -- addressed pull request comments, added LRUMapWithDelete

This PR is all to the credit of @trivikr's PR #162 ; in order to help accelerate its inclusion in the proper release I've added commits that address the PR comments, and also added LRUMapWithDelete using the analogous strategy.
It wasn't clear to me what ObliviousLRUCache meant -- perhaps it's a term of art I haven't met yet -- but I took the liberty of renaming it to the homely but very clear LRUCacheWithDelete / LRUMapWithDelete. (Also, putting the adjective last grouped them together in the tests / indexes / etc where things are alphabetized). I'm glad to redo the commit history if ObliviousLRUCache is the proper name for this widget.
Last point -- in the comments on 162 @Yomguithereal recommended "a rolling test ... add 2 remove 1, in a loop of ~10 items for a cache of ~4-5 capacity." I tried to think of a way to give it a workout with a nice clean loop and still test it meaningfully -- like a fizzbuzz kind of thing -- but bringing in a pattern seemed too artificial and I think there'd be a lot of logic lying around. Instead, I just spammed in a whole bunch of inserts and deletes and asserted the state of the cache at various rest stops. To my mind this proved the same point that a loop would but more clearly demonstrated there was nothing up my sleeve mathematically. Does this do the trick for you?

One other change from 162 -- at the cost of one extra array reference op, the delete method returns the dead item. If that cost is meaningful I can add a ¿deletePop? method to parallel set / setPop.

Thanks for your PR @mrflip. I have opened a small review with some comments. The unit tests look good to me.

Pushed a new commit addressing your comments. Remove lets you supply a singleton -- eg Symbol('missing') -- to indicate absence, permitting one to have undefined be in range.

Looks good to me @mrflip. I am trying to find a less conspicuous name for the structure but I don't suceed, so I guess explicit is nice. @trivikr any remark before I merge and release?

I merged the PR just now. Will release a new version in the evening I think (I need to batch up some SparseSet improvements along with it).

v0.39 is now live


ImportError: cannot import name 'Asset'

bigchaindb-driver version: bigchaindb_driver-0.2.0
Python version: 3.5.2
Operating System:  Ubuntu 16.04 LTS

Description
When I installed the bigchaindb driver here, then after I runed python:
from bigchaindb_driver import BigchainDB
bdb = BigchainDB('http://localhost:9984/api/v1')
The console shows ：
File "/home/zzjs/test.py", line 2, in
from bigchaindb_driver import BigchainDB
File "/usr/local/lib/python3.5/dist-packages/bigchaindb_driver-0.2.0.dev0-py3.5.egg/bigchaindb_driver/init.py", line 1, in
from .driver import BigchainDB   # noqa
File "/usr/local/lib/python3.5/dist-packages/bigchaindb_driver-0.2.0.dev0-py3.5.egg/bigchaindb_driver/driver.py", line 2, in
from .offchain import prepare_transaction, fulfill_transaction
File "/usr/local/lib/python3.5/dist-packages/bigchaindb_driver-0.2.0.dev0-py3.5.egg/bigchaindb_driver/offchain.py", line 18, in
from .utils import (
File "/usr/local/lib/python3.5/dist-packages/bigchaindb_driver-0.2.0.dev0-py3.5.egg/bigchaindb_driver/utils.py", line 9, in
from bigchaindb.common.transaction import Asset
ImportError: cannot import name 'Asset'
then I open the transaction.py , I found there is no Asset in it.
What should I do to solve the problem?
What I Did
Paste the command(s) you ran and the output.
If there was a crash, please include the traceback here.

Hi,
thanks for checking out the Python driver.
It's master branch is currently not synched with BigchainDB server's master branch.
To fix your problem:

Install BigchainDB-driver as outlined here using pip
Install BigchainDB-server as outlined here using pip

Tell me if this fixes your problem so that we can close this issue.

Thank you for  your response.
When I pip  uninstall bigchaindb_driver.
then I  pip install bigchaindb_driver
It shows:
Successfully built bigchaindb-driver bigchaindb rethinkdb pysha3 cryptoconditions python-rapidjson logstats multipipes pyyaml PyNaCl itsdangerous aniso8601 MarkupSafe pycparser
Installing collected packages: requests, rethinkdb, pysha3, base58, six, pycparser, cffi, PyNaCl, cryptoconditions, statsd, python-rapidjson, logstats, Werkzeug, MarkupSafe, Jinja2, itsdangerous, click, flask, python-dateutil, aniso8601, pytz, flask-restful, gunicorn, multipipes, jsonschema, pyyaml, bigchaindb, bigchaindb-driver
Successfully installed Jinja2-2.8 MarkupSafe-0.23 PyNaCl-1.0.1 Werkzeug-0.11.15 aniso8601-0.92 base58-0.2.2 bigchaindb-0.9.0.dev0 bigchaindb-driver cffi-1.9.1 click-6.7 cryptoconditions-0.5.1 flask-0.12 flask-restful-0.3.5 gunicorn-19.6.0 itsdangerous-0.24 jsonschema-2.5.1 logstats-0.2.1 multipipes-0.1.0 pycparser-2.17 pysha3-1.0.0 python-dateutil python-rapidjson-0.0.8 pytz-2016.10 pyyaml-3.12 requests-2.12.4 rethinkdb-2.3.0.post6 six-1.10.0 statsd-3.2.1
You are using pip version 8.1.1, however version 9.0.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
then I  do : from bigchaindb_driver import BigchainDB
the console show me:
from bigchaindb_driver import BigchainDB
File "/home/zzjs/.local/lib/python3.5/site-packages/bigchaindb_driver/init.py", line 1, in
from .driver import BigchainDB   # noqa
File "/home/zzjs/.local/lib/python3.5/site-packages/bigchaindb_driver/driver.py", line 2, in
from .offchain import prepare_transaction, fulfill_transaction
File "/home/zzjs/.local/lib/python3.5/site-packages/bigchaindb_driver/offchain.py", line 18, in
from .utils import (
File "/home/zzjs/.local/lib/python3.5/site-packages/bigchaindb_driver/utils.py", line 9, in
from bigchaindb.common.transaction import Asset
ImportError: cannot import name 'Asset'
So what should I do ? Can you help me?  Thank you very much.

Hi,
it seems like you're still using the latest master branch of the driver for some reason.
pip uninstall probably doesn't remove the incompatible version of the driver you've installed in the first place.
I suggest to delete or re-create a virtual environment and install pip install bigchaindb_driver again.
Since this seems to be a problem related to your setup I'd recommend that you join our gitter channel and we work it out there. To do so, follow this link: https://gitter.im/bigchaindb/bigchaindb

Thank you very much for your help.


Pose Estimation

There is no script in Pose Estimation.

Assigning you with the same @Tushar-ml.

PR Generated #64

Is this issue still open? @geekquad

@geekquad , Can I work on this issue under GSSoC'21?

@geekquad , Can I work on this issue under GSSoC'21?

I think this one is not required at the current time!


Docs: Dropdown's not toggling

Path --> /components/dropdowns/#single-button-dropdowns
The Dropdowns with default button ( btn-secondary ) ones are not toggling ( closing )
Rest buttons are working fine for toggle functionality

This is intentional. I'll revisit and perhaps clarify in the docs copy or update the example.