Generic erc20 approve

Added subparser for ERC20 approve method
Closes https://github.com/shapeshift/lib/issues/658

re @kaladinlight

This has become a little more of a grey area now with the inclusion of unchained-client in lib and essentially providing what we consider a good human readable representation of a tx. I could see the case being made at this point to just use the unchained-client types directly (or we can always create a type alias in chain-adapters if we still want the possible flexibility to change in the future without requiring the unchained-client to change as well). We can then reduce the somewhat confusing duplication of types across packages and make our lives a bit easier.

After some experimentations I ended up just casting TxMetadata in web and then use type narrowing. I decided to not make any breaking changes in chain-adapters because it's way out of scope of this issue.

The only annoyance is having to add to the TxMetadata union and the exclude list for each new specific tx metadata type. I think it is a place to start though and we can always try to incorporate more typescript magic to make it dynamically driven off a given set of standard and specific tx parsers. I wasn't able to figure out a way easily at first take

Yes and also you have to explicitly set StandardTxMetadata in other parsers, which is annoying. I actually just moved TxMetadata to ethereum/types (like in cosmos) and it works just fine.

web https://github.com/shapeshift/web/pull/1921

re @kaladinlight

This has become a little more of a grey area now with the inclusion of unchained-client in lib and essentially providing what we consider a good human readable representation of a tx. I could see the case being made at this point to just use the unchained-client types directly (or we can always create a type alias in chain-adapters if we still want the possible flexibility to change in the future without requiring the unchained-client to change as well). We can then reduce the somewhat confusing duplication of types across packages and make our lives a bit easier.

After some experimentations I ended up just casting TxMetadata in web and then use type narrowing. I decided to not make any breaking changes in chain-adapters because it's way out of scope of this issue.

The only annoyance is having to add to the TxMetadata union and the exclude list for each new specific tx metadata type. I think it is a place to start though and we can always try to incorporate more typescript magic to make it dynamically driven off a given set of standard and specific tx parsers. I wasn't able to figure out a way easily at first take

Yes and also you have to explicitly set StandardTxMetadata in other parsers, which is annoying. I actually just moved TxMetadata to ethereum/types (like in cosmos) and it works just fine. I created new EthereumTxParser enum (named it so to avoid confusion with TxParser) which can be used for new specific parsers

This all looks and sounds great. Thanks and sorry for the delay in review!


include/wil/result_macros.h: Cast from byte to wide char

assign_to_opt_param(ppszBufferString, reinterpret_cast<TString>(pStart));
Casting the byte pointer pStart to a wide char type might yield strings that are not correctly terminated, and could lead to buffer overrun.

There is no buffer overrun in this code.

The pointers really are wchar_t* pointers. They are merely cast to unsigned char* to simplify the byte calculations.
The strings are properly null terminated. ResultStringSize includes the null terminator.


Is there some API for node to take '.ts' to '.js'? Not the bin for shell

Search Terms
node ; api;
Suggestion
Need some api for nodejs to take '.ts' to '.js'， and return the '.js' content in string,  so I can use the to do STH.
But I don't want to use the shell bin.
Use Cases
I want to take a ts preview , so I can see the '.js' file in moment , I think it's good for the ts-leaner.

@JakeTunaley @DanielRosenwasser
THX. 😁


Make docstring convention a global setting

Pydocstyle has a setting to specify the used docstring convention:
[tool.ruff.lint.pydocstyle]
convention = "google"

Pylint also has rules for docstrings and profits from setting the used convention. #8843 introduces one of those rules and adds a convention setting specific to Pylint.
I think that having two different settings for the convention is not very intuitive as a user and might hinder efforts to unify settings and rules later on if someone actually selects two different conventions for Pydocstyle and Pylint checks (no idea why someone would do that but there's always someone out there).
I propose to turn Pydocstyle's convention setting into a global setting to make it usable by the Pylint rules and to keep settings consistent. A strategy could look like the following:

Add a docstring-convention setting under [tool.ruff.lint]
Deprecate the Pydocstyle setting (and Pylint's if #8843 gets merged in its current form)  in favor of the new setting
Only mention the global setting in the docs
Remove the original setting at some point in the future (is Ruff's deprecation process based on time or releases?)

That makes sense to me. I wonder if it even should become a global (tool agnostic) setting, so that a docstring formatter could pick it up in the future.

Probably related to this (let me know if this is a separate issue), but pydocstyle allows for specifying convention using it's own config:
[tool.pydocstyle]
convention = "google"
match = '((?!_test).)*\.py'

There is some inconsistently currently because (at least from what I can tell), ruff would in this case appropriately use the pydocstyle config for match but disregards the convention config. Instead, we need to also set convention in a ruff-specific config
[tool.ruff.lint.pydocstyle]
convention = "google"

Without knowing too much on ruff's philosophy towards configs, it feels like the path of least complexity would be to rely on and respect the pydocstyle configs where applicable, since that allows single-sourcing configs between the two tools. Right now the mix of some configs being respected and others not feels like it could lead to confusion.

Generally our philosophy is that we will read Python standards i.e. [project] but not other tool's configuration formats.

It makes sense, I just ran into this reading another issue regarding e.g. pip.conf and I see where you're coming from. But this philosophy is not without downsides, unfortunately, which are duplication and possible confusing configs.
It feels like it could be worth issuing a warning from ruff if other/conflicting configs are detected in pyproject.toml. Even something like "this warning is just a heads up that what happens might be different than what you expected", just to get people used to this paradigm, since you'd have to do some issue diving to understand this nuance.

That said, there does seem to be some inconsistency - it's been a bit, but when I wrote that comment it appeared that ruff does use some of the configs from these other sections (match in this case), just not all of them.

Yeah unfortunately there are trade-offs in both directions.
I'd be more willing to support a hint / warning if we detect the other configuration since then we're not as firmly on the hook for changes to the format.

it appeared that ruff does use some of the configs from these other sections (match in this case), just not all of them.

I'm honestly not familiar if it does. If you know where we read that could you link to the code? Our philosophy around these things is ever-evolving of course.

... but when I wrote that comment it appeared that ruff does use some of the configs from these other sections (match in this case), just not all of them.

I'm very confident that we don't read match or anything from tool.pydocstyle -- I think it's ~impossible` since that's not encoded in our deserializer. Maybe there was something else going on?

Apologies -  you're correct. I had a separate config for ruff that was basically doing the same thing:
[tool.ruff.lint.per-file-ignores]
"test/*" = [
  "D"
]

Adding a global setting is open for contribution.

What would be the steps needed to implement this?

@EwoutH

Add a global configuration option for the docstring convention
Define and implement a merging logic that respects both the pydocstyle local and the global configuration
Possibly: Make it a preview only change.


bump e2e vm count

Description
bumps e2e vm count. E2e sometimes runs out of node space on current setup.

/ok-to-test sha=ae838da


Example phi with cuda and model phi-hermes gives 404 error

When trying out phi example with the model phi-hermes it returns a 404 error
To reproduce:
cargo run --example phi --release --features cuda -- --model phi-hermes --prompt 'Hallo'

Error:
https://huggingface.co/lmz/candle-quantized-phi/resolve/main/model-phi-hermes-1_3B.safetensors: status code 404

Indeed looking at https://huggingface.co/lmz/candle-quantized-phi/tree/main it is not there.

Ah thanks for pointing this out, somehow I forgot to upload these weights when creating the model. These should be available now.

No problem, thank you for uploading

@thomas9911  I am not able to run cargo with "cuda" as feature, it's throwing following error
thread 'main' panicked at 'Could not get Cuda compute cap: no gpu codes parsed from nvcc', /home/azureuser/.cargo/git/checkouts/candle-0c2b4fa9e5801351/8d8f48c/candle-kernels/build.rs:106:41

warning: build failed, waiting for other jobs to finish...

Here Compute capability is 7.0 , nvidia-smi prints 12.1 cuda version and nvcc prints 9.1 cuda compilation tools.
If you can tell me what cuda and nvidia driver version you are using, then also it may help.
Thanks

It looks like Cuda is not configured correctly (but I'm no expert on it) do any other example work? @yugaljain1999
In the end my graphics card did not work with the hermes model because its too old (I have a GTX 1080ti) and it is using some new data format


[proposal] Support process type autoscaling

Developers should be able to define an autoscaling policy per application process type. Under the covers, Workflow should use HorizontalPodAutoscaling.
Pre-req: Kubernetes Deployments
Examples:

deis autoscale:set web --min=2 --max=10 --cpu-percent=80
deis autoscale:unset web
deis autoscale:list

If an operator users deis scale web=5 when the application is set to autoscale, the replica count for the deployment should be set to that value and  the HPA should be left alone.
When recovering from a backup or controller restart the HPA should be set with known values and initial replica count should default to the last user-provided value.  Commands like deis ps should use Kubernetes as the source of truth for pods, rather than the postgres database.

👍

Commands like deis ps should use Kubernetes as the source of truth for pods, rather than the postgres database.

I believe this is already true as of https://github.com/deis/controller/pull/359. :)

Yeah, no database interaction for Pod listing

Yeah I know.

Quick clarification on a few conversations. In the first pass, we should keep the scale factor for an application and the autoscaling configuration decoupled.
If, for example, autoscaling is set to min=5, max=10 and the operator runs scale web=20, we should update the replica count for the deployment, but not update the autoscaling configuration.
Same on the other side, if autoscaling is set to min=5, max=10 and the operator runs scale web=2 we would set the replica count to 2 and not update the autoscaling configuration.
From a UX perspective, the CLI may warn about these commands disagreeing but we shouldn't reject the scale API call.

yes, autoscaling should not touch replicasets set by scale web=2.
but we should keep the same functionality there as in k8s, autoscaling set takes priority vs scale

Just to provide more information then here is my example setup
HPA is 2-5, deployment is at 3 (set via scale)
k get hpa,deployments
NAME                            REFERENCE                     TARGET    CURRENT      MINPODS     MAXPODS   AGE
scale-thing                     Deployment/nginx-deployment   50%       <waiting>    2           5         45m
NAME                            DESIRED                       CURRENT   UP-TO-DATE   AVAILABLE   AGE
nginx-deployment                3                             3         3            3           57d

I scale deployment to 1
k scale --replicas 1 deployment/nginx-deployment
For a while the deployment stays at 1 but with enough time passed it will be kicked back up to 2, due to HPA.
Same thing if I scale the deployment up to 8, confirm 8 replicas are created, wait a little while then HPA will bring it down to 5 (as configured).
I understand the decoupling nature as running the various Kubernetes API calls do not auto-correct for one another except HPA will eventually course correct upwards and downwards.


ImportError: cannot import name gen_checkpoint_ops

System information

Have I written custom code: No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 16.04
TensorFlow installed from (source or binary): via pip
TensorFlow version (use command below): 1.3.0
Python version: 2.7.12
Exact command to reproduce: from tensorflow.contrib.tensorboard.plugins import projector

Describe the problem
Been following this tuturial from TF website to visualize embeddings using Tensorboard. When running the code to add metadata, the following error log returns:
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
<ipython-input-39-40557054c972> in <module>()
----> 1 from tensorflow.contrib.tensorboard.plugins import projector
      2
      3 # Use the same LOG_DIR where you stored your checkpoint.
      4 summary_writer = tf.train.SummaryWriter(LOG_DIR)
      5

/usr/local/lib/python2.7/dist-packages/tensorflow/contrib/__init__.py in <module>()
     20
     21 # Add projects here, they will show up under tf.contrib.
---> 22 from tensorflow.contrib import bayesflow
     23 from tensorflow.contrib import cloud
     24 from tensorflow.contrib import compiler

/usr/local/lib/python2.7/dist-packages/tensorflow/contrib/bayesflow/__init__.py in <module>()
     22
     23 # pylint: disable=unused-import,line-too-long
---> 24 from tensorflow.contrib.bayesflow.python.ops import csiszar_divergence
     25 from tensorflow.contrib.bayesflow.python.ops import entropy
     26 from tensorflow.contrib.bayesflow.python.ops import monte_carlo

/usr/local/lib/python2.7/dist-packages/tensorflow/contrib/bayesflow/python/ops/csiszar_divergence.py in <module>()
     24 # go/tf-wildcard-import
     25 # pylint: disable=wildcard-import
---> 26 from tensorflow.contrib.bayesflow.python.ops.csiszar_divergence_impl import *
     27 # pylint: enable=wildcard-import
     28 from tensorflow.python.util.all_util import remove_undocumented

/usr/local/lib/python2.7/dist-packages/tensorflow/contrib/bayesflow/python/ops/csiszar_divergence_impl.py in <module>()
     40 import numpy as np
     41
---> 42 from tensorflow.contrib import framework as contrib_framework
     43 from tensorflow.contrib.bayesflow.python.ops import monte_carlo_impl as monte_carlo
     44 from tensorflow.python.framework import ops

/usr/local/lib/python2.7/dist-packages/tensorflow/contrib/framework/__init__.py in <module>()
     87 # pylint: disable=unused-import,wildcard-import
     88 from tensorflow.contrib.framework.python.framework import *
---> 89 from tensorflow.contrib.framework.python.ops import *
     90 # pylint: enable=unused-import,wildcard-import
     91

/usr/local/lib/python2.7/dist-packages/tensorflow/contrib/framework/python/ops/__init__.py in <module>()
     22 # pylint: disable=wildcard-import
     23 from tensorflow.contrib.framework.python.ops.arg_scope import *
---> 24 from tensorflow.contrib.framework.python.ops.checkpoint_ops import *
     25 from tensorflow.contrib.framework.python.ops.ops import *
     26 from tensorflow.contrib.framework.python.ops.prettyprint_ops import *

/usr/local/lib/python2.7/dist-packages/tensorflow/contrib/framework/python/ops/checkpoint_ops.py in <module>()
     20 import math
     21
---> 22 from tensorflow.contrib.framework.python.ops import gen_checkpoint_ops
     23 from tensorflow.contrib.util import loader
     24 from tensorflow.python.framework import dtypes

ImportError: cannot import name gen_checkpoint_ops

The files gen_checkpoint_ops.py and gen_checkpoint_ops.pyc exist in the specified directory.
Would appreciate any hint.

Restarted the session and suddenly it worked :)

me too get the same error how do you fix it?


[BEAM-846] Add WindowMappingFn, WindowMappingFns

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[ ] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[ ] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[ ] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

WindowMappingFn maps from a main input window to a side input window,
and provides a maximum amount of lookback that is possible to generate
using the MappingFn. This separates the logic of assigning windows from
the logic of mapping main and side inputs. Additionally, it permits
pipeline runners to garbage collect side inputs when they are no longer
accessible.
This is currently unused.
See BEAM-846 and BEAM-260 for additional context.

R: @kennknowles @robertwb

Coverage increased (+0.03%) to 69.948% when pulling 688d6480c96b690d08b07e1cc96dcf4519d129e9 on tgroh:window_mapping_fn into 7e97820c5eeabaa919216b9f770dd7d2eabed623 on apache:master.

Coverage increased (+0.02%) to 69.924% when pulling f8334250cd267c68bcf52934c8bc2a3070664e5a on tgroh:window_mapping_fn into e1dc7a861bc53432430e65d962241bb1ed7098ca on apache:master.

Can you tag with multiple JIRAs? I was just browsing my assigned issues and was surprised that BEAM-260 was not linked.

I'm going to add both the input and target types everywhere. Watch this space.
(As an aside, I'm also going to expect that the target type everywhere except the actual declaration to always be ? and the input type to be BoundedWindow or ? everywhere.)

Actually, just the target window type. I forgot how much of a nightmare using that sort of wildcard for inputs is in Java.

Done. PTAL.

Coverage increased (+0.01%) to 70.171% when pulling abf129e3998b3879c0f21c85afa5f6fe3fa971fd on tgroh:window_mapping_fn into ddc75958cdd2a88ff5606b06dff57dd43a61dda2 on apache:master.

Jenkins failures is a coveralls flake. Still worth reviewing.


Update to final release version v0.33.0, release notes

Description
Update release v0.33.0 with final release version and release notes

@willtsai, @Reshrahim , @jasonviviano : pls review/update Release Notes (highlights sections etc)


No support for MIME charset?

Is this an issue with the underlying spec? Trying to a save a blob of type: 'text/csv;charset=UTF-8' results in Failed to execute 'showSaveFilePicker' on 'Window': Invalid type: text/csv;charset=utf-8.

First, I doubt that the file pickers in operating systems will meaningfully allow you to filter by MIME type parameters like the charset, but that being said, the spec states explicitly that…

If parsedType’s parameters are not empty, then throw a TypeError.

…so that's working as per the spec algorithm. You need to remove MIME type parameters from your code.


Widget Preview & Menu Items

Is there no in app widget preview for this dashboard? Also how do I go about adding extra stuff to the menu like a area for social links?

CandyBar doesn't support any 3rd party widget app. If you want to edit, you need to figure it out by yourself.

Can you not implement widgets into the dashboard, a lot of icon pack designers like having that feature. With yours not having it it's kind of boring no offense. It's a very nice dashboard though the best I've seen. I just really think you need to implement 3rd party widget stuff for Zooper & Kustom.

Also can you not tell me what file I need to edit to add to the side menu?

menu_navigation_view.xml
CandyBarMainActivity.java

@Technologx Were you able to implement the widget support?
Which file should I edit to implement the widget previews?

@SanchithHegde No because I have no idea how to go about doing it.

@Technologx Oh okay. Thank you!

I have asked many people to help me, but none were able to. Dani sir, please add widget support. I'm unable to do it by myself. At least Kustom support would be good enough.
Than you ahead of time!

I tried to add and remove items on side menu, but no changes were made in layout. WTF?


Using layered environments

Hi,
I try to use layered requirements for a development environment as instructed in the documentation, but either I understood it wrong or there's some error in it.
I created a test environment and installed pip-tools there. Next I created a small and easy setup.py which requires PyYAML for my package. pip-compile recognizes this requirement accordingly and creates a correct requirements.txt. Next I created a dev-requirements.in with -c requirements.txt at the very top of that file plus flake8. Result is that I have now a file called dev-requirements.txt containing only those python packages as dependency as of flake8.
Environment Versions

OS Type: Debian Focal Fossa (20.04)
Python version: 3.8.5
pip version:  20.2.3
pip-tools version: 5.3.1

Steps to replicate

create virtual environment (i.e. with virtualenv using virtualenvwrapper)
create setup.py/setup.cfg) having "install_requires=PyYAML"
pip-compile
create dev-requirements.in with lines "-c requirements.txt" and "flake8"
pip-compile dev-requirements.in

Expected result
#
# This file is autogenerated by pip-compile
# To update, run:
#
#    pip-compile dev-requirements.in
#
flake8==3.8.4             # via -r dev-requirements.in
pyyaml==5.3.1             # via -c requirements.txt
mccabe==0.6.1             # via flake8
pycodestyle==2.6.0        # via flake8
pyflakes==2.2.0           # via flake8

Actual result

# This file is autogenerated by pip-compile
# To update, run:
#
#    pip-compile dev-requirements.in
#
flake8==3.8.4             # via -r dev-requirements.in
mccabe==0.6.1             # via flake8
pycodestyle==2.6.0        # via flake8
pyflakes==2.2.0           # via flake8

The README has this example:

To sync multiple *.txt dependency lists, just pass them in via command line arguments, e.g.
$ pip-sync dev-requirements.txt requirements.txt

So I think you can run that if you want to install both sets of requirements. The -c option is just used to ensure your dev file doesn't violate the other file's constraints, but it doesn't automatically add other dependencies to its output.

Did you try using -r requirements.txt instead of -c requirements.txt in dev-requirements.in?

I'll close this based on the above correct solution from @DBCerigo, but please let us know if it doesn't resolve your issue. Thanks!


adding the serialization tutorial

Updated the tutorial based on tour comments. Let me know what you think @masci @annthurium 🙏


Filtering the options list in custom select component

Description
Very inefficient cause it's just manipulating DOM, but since there are plans to rewrite this I think it will do for now. Also, fixed aria a little, but it is far from perfect.

Issue ticket number and link
https://trello.com/c/HIn6aagy/368-allow-to-type-to-filter-displayed-options-in-selects-with-many-options-for-example-work-location-graduation-year-etc
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my code
[ ] I have made corresponding changes to the documentation
[ ] Any dependent changes have been merged and published in downstream modules

@z-x Maybe we don't need the map files .....

@piotrze - Removed the maps.

@z-x looks like there are a lot of conflicts :)


🐛(backends) fix startup hang when ClickHouse is down

Purpose
During Ralph startup, when ClickHouse was not running Ralph would fail to connect and hang, never recovering. This change allows Ralph to start even without ClickHouse running and connect whenever it can.

@wilbrdt and @jmaupetit hi there! This issue has been a painful one on the Tutor side of things, where ClickHouse can take longer to start up once it's got a lot of data in it. Can you take a look when you get a chance?

You can rebase your branch and merge on master anytime!

Thanks @wilbrdt ! I've rebased but don't have permissions to merge. 😄

Released under 3.5.1 :smiley:


Remove YT link from hub page.

Docs Build status updates of commit 4210b5e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/index.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Tenant Address Entry

As a tenant, I would like to be able to enter my address so that I can determine if my building is already in the system.

(add screenshot or URL)

Address should be populated in existing building database (as well as petitions already started.

database, app that writes DB, front end that talks to backend.

As a tenant I would like to know that my address is being populated in the DB.  I would also like to see other addresses

STORY CLOSED - pending permissions to move


Add to package-sets

If this is added to package-sets, then it can be installed via psc-package.
I don't think it's hard to do. All the dependencies are in package-sets and can be installed with psc-package, so then someone would just need to follow this.
Hope you folks get a chance to do so! Let me know if I can help

Closed in https://github.com/purescript/package-sets/commit/3061562ec856ed0f5528bf094190b5d63e75c4d7


T-485 retry logic

Unit Test Coverage / Review Requirements

Are the changes in this PR covered by unit tests?

yes

Does this PR create or modify code without tests?  If so, please explain.
*

How to Test
make a request that fails for a retry-able reason. Request gets retried.
Changelog

added retry logic
config now has retryHook, maxRetry (default 3), retrySleepTime (default 500)

Notes

Only that small fix.


Docs site down due to react version not on cloudflare

Looks like the docs site is down because it's pointing to a reactjs version 15.4.1 that isn't on cloudflare yet.  Seeing 404's for that file.

Yeah, the most recent version on cloudflare is 15.4.0. It looks like Greenkeeper.io updated everything automatically before cloudflare got a new version up. I would have thought the tests would have failed and stopped the process but I guess not. Commit #923 and #924 are the ones causing it.

Thanks guys. The publishing process for cdnjs is automated, so I assume it will update timely.  However, I'll roll that back to get us by for now.

Fixed in 4471d3dec1988724dbf6ac18686fc6d976079fec.  Will go live when this build finishes:
https://circleci.com/gh/Semantic-Org/Semantic-UI-React/1026

Sorry folks, I failed to remove the ^ from the version bump, so 15.4.1 was installed anyway.  I've just locked in the exact version and redeployed:
https://circleci.com/gh/Semantic-Org/Semantic-UI-React/1030

Thanks @levithomason - your efforts are certainly appreciated :) Great work on this library!

💥
http://react.semantic-ui.com


Fixing sampleCount bug

convertCounters is wrongly invoking withCount for setting sampleCount. As a result, all count values are getting overridden to the sampleCount values which is incorrect.
#452 has additional commits that probably should be made because sampleCount field in CounterRollup class is an int, but that is probably insufficient precision that has gone unnoticed because of this bug.

+1


Fix selected message in message list being out of view.

Fixes https://github.com/zulip/zulip/issues/27489
Opened #27632, first commit is the main fix, second commit is just something I think is an improvement.
Best way to test locally is to run ./manage.py -n 3000 --max-topics=2 and scroll up high in stream so that selected message can be offscreen like in czo stream in czo.

I merged the first commit as 757675db808f203b0d1d7fcc6ce022aa7f9c0ddb. It might be better to do a separate PR for the other one so it have a description focused on the remaining issue?

Okay.


cover ExtendedMethodReflection by bc-promise

relates to https://github.com/phpstan/phpstan-src/pull/1913

Thank you!


Add composition rule matching support

Add ability to test for the presence of multiple rules as a set for an evaluation to be considered a match e.g.
1: Rule 1 + Rule 2 + Rule 3
2: Rule 1 + Rule 2 + !Rule3

This capability exists now based on the OAT subrule engine.  For now there is not a need for a given set of rules to be defined for composition but the engine itself can support it.


Add Darglint linting

Check docstrings are consistent with function definition
Fix some of our docstrings :)

Note https://github.com/terrencepreilly/darglint/issues/132 is causing false-positives in src/seals/testing/envs.py so I've masked those errors for now.

Oh, I was surprised that darglint automatically attached itself to flake8 like that. Usually there's a secondary package flake8-* that does that.


Python generator implementation

I just finished work on a pure python stub generator. Right now  it's somewhat crude and quality of generated code can be improved upon but it's more or less fully functional. Wondering if you're interested in a PR. It's based on the Csharp generator, so it follows the single stub with multiple methods wrap_encode, wrap_decode instead of  2 classes as per the reference Java impl. It also has a couple of neat things like  full type hints and usage of https://docs.python.org/3/c-api/buffer.html#bufferobjects , however they're somewhat muted  because python has to cast most memory objects to int or str anyways, so heavy on allocations, a Cython impl should be trivial based on the current code though.

We would be happy to discuss a PR. However we have seen partial implementations in the past go nowhere so we are only really interested in languages that will be completed and supported longer term.
We have learned over time that separating the encoding and decoding into separate classes is more appealing and results in safer code.

Let me know if I can  clarify or tidy it up in some ways

Any eta on python support?
Is this supported https://github.com/tfgm/sbedecoder ?

@samratbatth To be honest I haven't had time to put towards it, but if you want feel free to clone it and clean it up, it's mostly code cleanup not functional issues.
Although if im to write it up again, I would likely just wrap the C++ codecs with pybind or something like that. The struct library is slow so if we can reuse the buffers and cast to numpy types directly that will likely give you C like speed in Python.

Any suggestions on implementing SBE decoder in Python for CME MDP 3.0 market data?


No apps can perform this action

when I use this on a tablet and attempt to open the camera it states it can't find the camera app to take the needed picture.

Yeah that's wanted, if there's no camera on that tablet.


[Bug] - Stage areas code don't detection change record.

function isModify() {
    // Check temporary and staging area modifications
    const resultUnstaged = execSync('git diff --name-only').toString();
    const resultStaged = execSync('git diff --cached --name-only').toString();

    // List of modified files merging temporary and staging areas
    const filesModified = (resultUnstaged + '\n' + resultStaged)
        .split('\n')
        .map(line => line.trim())
        .filter(file => file);

    return filesModified.length > 0;
}

Fixed，to See #8


iOS WebKit kills session on app switch

On iOS, every app-store-available web browser (using WebKit) is very likely to reload the active web page when the user switches to another app. This kills our Caffeine session without warning, losing our work, with no opportunity to prepare.
Help?

Craig, I've just test https://caffeine.js.org/a-frame on my iPhone in Safari browser, and it does not reload  the active web page after switching apps. That's strange, may the problem with preferences on the device you are using?

It takes varying amounts of time, depending on device memory usage. Also try leaving Safari in the background for a while with the iPhone locked.

I tried it on Google Chrome on iOS 11.4. Left the browser sitting for a half hour or so and came back to it and it was still running. Then I waited some more, went to Safari and loaded page and it got stuck on ‘starting a-frame live coding demo’. So I went back to Chrome, and then it reloaded the page and also hung on ’starting a-frame live coding demo’. Is web kit non-reentrant?

I tried the a-frame demo on google chrome on android 8.1.0 and it has a terrible case of vertigo, but it does seem to survive without reloading the page.

Thanks for testing! Yeah, every web browser you can get from the Apple app store, even Chrome and Firefox, is some form of WebKit. Apple doesn't allow other engines on iOS. That's why I'm hoping there's something else available from one of the sideloading app stores (like Cydia).

So the only way would be to persist our state constantly. For a smaller object memory that may be possible in IndexedDB. Might need a rewrite to use "dumb" data structures instead of our own Object instances, because then saving/loading should be instantaneous.

In the XCode console I see that the iOS 12 kernel has a memory limit of 840 MB for MobileSafari WebKit processes. I was able to get a non-VR Caffeine session (https://caffeine.js.org) to last a bit longer, through several suspends, app switches, and screen locks. It was killed when I went to fullscreen.
I guess the best place to put effort is in making the object memory smaller. There doesn't seem to be a way of making the memory limit larger, short of building or patching the iOS kernel.


CLOB, ora.Lob and multiple lines oracle error

Hi !
I obtain this Oracle error when I try to query CLOBs in a table :
Env.ociErrorNL ORA-24804: Lob read/write functions called while another OCI LOB read/write streaming is in progress
I may have missed something in how to use the Lobs here.
The fact is that I use the Close() function on ora.Lob, but I had a quick look at how the ora.Lob is created, and there's no Closer set before it's returned to me, so Close is unefficient and I think this is why I get my error.
Here is my code :
func GetTable(db *sql.DB) (res []string, err error) {

rs, err := db.Query("select CLOB_VAL from CLOB_TABLE")
if err != nil {
	logger.Error.Printf("SELECT: %v", err)
	return
}
defer rs.Close()

for rs.Next() {
	var Xml ora.Lob
	err = rs.Scan(&Xml)
	if err != nil {
		logger.Error.Printf("Scan: %v", err)
		continue
	}

	s, err := readLob(&Xml)
	if err != nil {
		logger.Error.Printf("readLob: %v", err)
		continue
	}
	res = append(res, strings.TrimSpace(s))
}
if rs.Err() != nil {
	err = rs.Err()
	logger.Error.Println(err.Error())
}

return
}

func readLob(Xml *ora.Lob) (string, error) {
defer func() {
	if e := Xml.Close(); e != nil {
		logger.Error.Printf("Xml.Close(): %v", e)
	}
}()
b, err := Xml.Bytes()
if err != nil {
	logger.Error.Printf("readLob: %v", err)
	return "", err
}
return string(b), nil

}
I finally only get the first line of the table, not all of them.

You're very possibly right, I'll try to fix it - till that Scan into an io.ReadCloser, not an ora.Lob.

And please, I want your opinion: would it be better to have LOBs be read as string/[]byte by default, and make the current default (io.ReadCloser) the optional?

I think it would indeed be better that by default we get a []byte/string than a ReadCloser.
Even if LOBs theorically would be better handled with a ReadCloser due to memory issues loading the whole of it at once, in fact in my experience in most cases where I've met CLOBs, they were used because there was a little more data than a VARCHAR could handle.

Thanks for your fix, I pulled it and I made it working.


Editorconfig

Update everything!

This change is

(About halfway through - I'll resume in a bit). Thank you for doing this John! Once the configuration is squared away, this will be very helpful.

src/SIL.Machine/FiniteState/DeterministicFstTraversalInstance.cs line 37 at r1 (raw file):
Previously, Enkidu93 (Eli C. Lowry) wrote…
There are a few of these throughout: To me, the type is not perfectly clear, so I wouldn't use var here. How exactly does it decide when it's clear/unclear?

The ones I don't like as much are when you say "ToDictionary" or similar, it says the type is clear, but when the type is used as a type passed to the member, it's not clear.  I disagree with both.  The alternative is to not use the system...

src/SIL.Machine/Tokenization/LatinWordTokenizer.cs line 134 at r1 (raw file):
Previously, Enkidu93 (Eli C. Lowry) wrote…
This isn't an issue, really, but we should have some standard of what abbreviations in variable names are acceptable. Not worth switching it back, but I do think ctx or ctxt are very standard, unambiguous names; similarly, stddev elsewhere for standard deviation. It seems to me that as long as you have a clear name, shorter is better (e.g. col is better than column and num than number). Is the plan to just avoid abbreviations altogether?

It was hard to think about this one as well.  There is a time for abbreviation - but it should be limited and likely common to all the code.  context is used many times and should likely be spelled out each time.  For stddev, having it shorter is probably fine (didn't need to be changed).  I don't know if we should be changing every min, max, ave, etc.  In general, longer names for clarity usually appears to be preferred.

src/SIL.Machine/Translation/EcmScoreInfo.cs line 36 at r1 (raw file):
Previously, Enkidu93 (Eli C. Lowry) wrote…
Odd that the type is required here - like I said before, how exactly does it decide?

csharp_style_var_for_built_in_types = false
Again, I don't fully like it but I don't know a better alternative.  Let's talk about these issues and see if we can come up with the best path forward.

src/SIL.Machine/Tokenization/LatinWordTokenizer.cs line 134 at r1 (raw file):
Previously, johnml1135 (John Lambert) wrote…
It was hard to think about this one as well.  There is a time for abbreviation - but it should be limited and likely common to all the code.  context is used many times and should likely be spelled out each time.  For stddev, having it shorter is probably fine (didn't need to be changed).  I don't know if we should be changing every min, max, ave, etc.  In general, longer names for clarity usually appears to be preferred.

We could use this guide: https://github.com/abbrcode/abbreviations-in-code

I will start a new one


Google and Facebook auth working in debug mode but not in release mode.

I use:

google_sign_in: ^4.1.4
flutter_facebook_login: ^3.0.0

to authenticate my users.
Everything works perfect on my emulator, no errors.
I built my app using "flutter build apk".
When I tap the facebook or the google button on my built app, on a physical device, to run the methods that are handling the auth, nothing happens. It's like those buttons have no onTap method.
I found the same issue here: https://stackoverflow.com/questions/60682173/flutter-facebook-login-popup-or-webview-is-not-opening-on-released-apk-on-androi

did you add the SHA-1 fingerprint of the release-apk to firebase and facebook?

exactly. Check your app store adminboard and extract the sha-fingerprint and add it to your facebook and google auth admin pages

@AlexGFX
does it solve the problem?

@AlexGFX
I hope it's solved. Closing since long time without an response

I solved adding

outside the application tag in your AndroidManifest.xml

I solved adding

outside the application tag in your AndroidManifest.xml

What about flutter web applications?


Transfer managers for icosahedral sphere mesh

The block solves for the non-linear shallow water equations example needs a bespoke transfer manager for the icosahedral sphere mesh.
This manager deals with the fact that refinements of the icosahedral sphere are not nested, so the fine mesh coordinates need to be projected down onto the surface of the coarse mesh to carry out the transfers.
This is probably general enough that it could/should be supported by Firedrake directly. If this happens, we can remove the file in the examples directory that currently defines this transfer manager.

This functionality has now been moved to the utils library in utils.mg
See pull request #35


Support typeahead

A possible typeahead system could display possible autocomplete suggestions while typing, without using any special controls. This is not to be confused with (tab-)autocompletion (#1)

I still think that this feature makes perfect sense :+1: However, there are currently no immediate plans to build this from my end (no demand at the moment and more important outstanding issues currently), but I would be really happy to accept PRs :+1:
(If you need this for a commercial project and want to sponsor this feature and you want a quote, please check out my profile and send me an email)
I'd like to focus on getting the next release out and believe this has been answered already, so I'm closing this for now. :shipit:


[GPU] Fix offsets calculation formula in MultiMmaOp distribution.

It was
vtid: virtual thread id
tid: lane id
vtid = (tid floordiv stride_i) mod size_i

However, it does not take element into account. Each thread grabs element contiguous data, so the vtid needs to be multiplied by element to get the next bunch of data. I.e., it becomes
vtid: virtual thread id
tid: lane id
vtid = ((tid floordiv stride_i) mod size_i) * element_i

Fixes https://github.com/iree-org/iree/issues/17973

I am pretty confident that this is good based on out discussions and the correctness results, but let's wait for @Groverkss review anyway.


metasploit: 6.2.24 -> 6.2.25

Description of changes
Update to latest upstream release 6.2.25

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

The "Checking EditorConfig / tests" check indicates trailing whitespace:

pkgs/tools/security/metasploit/gemset.nix:
1346: Trailing whitespace
1 errors found
Error: Process completed with exit code 123.


Problems using pheval

Hi Pheval authors
Recently I've seen your paper in Researchgate and I'm very interested so I gave a try. Following the instructions here https://monarch-initiative.github.io/pheval/exomiser_pipeline (I use a previous exomiser  version installed in my cluster) I've have the following problems:

Tutorial saids in "5. Set PhEval Config YAML File" that exomiser directory program key is "exomiser" but it must be "exomiser-USED VERSION". If not set, it breaks with a dict key error.
The dependency to j2cli to make j2 command works is not defined in poetry files so I have a j2 command not installed error. Maybe the snap version that you use contains jinja2 and j2 cli but I suggest to add "j2cli" to your depencies so all it's handled by python dependency manager
pheval-utils create-spiked-vcfs gives the following error:  "Error: No such option: --template-vcf-path (Possible options: --hg19-template-vcf, --hg38-template-vcf)". Downgrading pheval to 0.3.1 fix this error
When I execute "make pheval run" the directory configurations/exomiser-13.1.0-default is created but later breaks because the file configurations/exomiser-13.1.0-default/config.yaml not exists. I think that this is counterintuitive, if the folder is created by pheval, I cannot create the config file in a folder that not exists. The same occurs for the preset-exome-analysis.yml file
The pheval system make symlinks to exomiser configuration files but there is a stage that the file "application.properties" is accessed in write mode. As I work in a cluster and it's no sense install exomiser twice, I referenced the cluster installation that it's write protected so I have a Permission Error. If you simlink this file to write in it (that is not a good practice as the program is also used in other contexts), why not copy it? If you execute exomiser from configurations directory, it will access the copied file instead the original one, so the symlink is not necessary. In fact, I  fixed this problem removing the symlink and copying the original  "application.properties" file to the exomiser folder within configurations directory.
Exomiser gives me file errors when with configurations/exomiser-13.1.0-default/2302_hg19/2302_hg19_transcripts_ensembl.ser and configurations/exomiser-13.1.0-default/2302_hg38/2302_hg38_transcripts_ensembl.ser. Pheval do NOT simlink these files or give any error about not finding them when simlinking. Simlink manually 2302_hg19 and 2302_hg38 folders from original exomiser installation fixed the problem.
File errors with phenotype files. Pheval simlinks each file of phenotype folder instead simlink the folder. Simlink manually the phenotype folder within exomiser folder in configuration directory fixed the problem.
Due to previous errors I've had several results folders with corrupted exomiser executions. If I execute "make pheval run", make execute and exits from pheval folder instead of resume exomiser execution. To do so, I have to remove manually the results folder. I think that the corresponding rule has to check if exomiser has generated the results files and if not, launch exomiser.

Once I've succesfully executed the pipeline, what is the next step to obtain the performance figures shown in the paper?
Thank you very  much in advance
Pedro Seoane

@seoanezonjic Thank you for your message, the whole team is OOO at the moment, but someone will come back to you when they are back!

Thank you @matentzn and @yaseminbridges , I''ll wait to the team and in the meantime I'm playing with the platform. In fact, another problem that I faced is that I'm executing in my university cluster but the computing nodes has not access to internet and the script create_noisy_phenopackets.py fails in the following line:
resource = OntologyResource(slug="hp.obo", local=False)
I think that the script should have an option to set "local" attribute to True and used  a cached version of the ontology files in this computing environments (and I think that it will speeds up the execution avoiding repeated queries to servers)
Thank you in advance
Pedro Seoane

Hi, @seoanezonjic!
Thank you for documenting these problems in detail!
I think a lot of these issues may be due to the MakeFile pipeline needing to be updated to what we use in the paper. @souzadevinicius can you confirm?

Hello, @seoanezonjic,
Thank you for your message. I acknowledge that the PhEval pipeline documentation is outdated. I am currently working on updating it.
In the meantime, you can utilize a pipeline described in this repository: https://github.com/monarch-initiative/monarch_pheval. The repository contains different types of experiments, which can be edited by modifying the PhEval Config YAML File.
To execute all experiments outlined in the config file, please follow two steps provided in the pipeline documentation:

Run bash ./resources/generatemakefile.sh
Execute make pheval

I apologize for any inconvenience caused by the outdated documentation. If you happen to have any other issues, please feel free to reach out to me.
Thank you.

@souzadevinicius is the pheval Makefile needed any more if the monarch-pheval repo exists?

@souzadevinicius is the pheval Makefile needed any more if the monarch-pheval repo exists?

No, it's not, @julesjacobsen. I'm updating the PhEval pipeline documentation and removing these unnecessary files.

Hi, @seoanezonjic! Just a brief update:

I have implemented an option to specify a local cached ontology file to the scramble-phenopackets command, allowing you to run in the computing environment you are using.
There is now a docs page on how to execute a benchmark, this is a guide for how to produce performance figures shown in the paper.

Hi @seoanezonjic
Apologies, just to clarify, did you face these errors when executing the pipeline here: https://github.com/monarch-initiative/monarch_pheval?
For the time being, you should use the instructions outlined in that repo and tailor it to the experiments that you want to run and ignore the docs regarding the MakeFile pipeline in this repo.
@souzadevinicius is OOO but he will be able to advise you further on your issues with the MakeFile once he returns

Hi @yaseminbridges
I started in that repo BUT when you answered me with your message about pheval 0.4.0 and the new features I removed all files. From zero, I followed the instructions in https://monarch-initiative.github.io/pheval/executing_a_benchmark/ and I ended with the errors enumerated in my previous post and I expected a successful run. I do NOT mixed instructions or files from both repos.
Thank you in advance
Pedro Seoane

Hi @yaseminbridges
Now I'm understand and I apologize for my misunderstanding, I've a lot in my head the last weeks.
I'll explain my steps with the aim of get a operational pheval in my cluster to benchmark my prioritizer. First, I need to get a working example with exomiser al least. My steps were:

As you tell me that the  pheval v0.4.0 has the option to use a  local cached ontology file, I'm started from zero. I deleted all my work with https://github.com/monarch-initiative/monarch_pheval and I followed this guide: https://monarch-initiative.github.io/pheval/exomiser_pipeline/
The errors listed in https://github.com/monarch-initiative/pheval/issues/347#issuecomment-2399813523 are from this fresh install and execution.
I can't execute the instructions on https://monarch-initiative.github.io/pheval/executing_a_benchmark/  guide because the problems I've got with the Makefile

I hope that now it's clear my problem and I'm very sorry for the confusion
Thank you in advance
Pedro Seoane

Hi, @seoanezonjic.
I hope you have successfully run the PhEval pipeline. In any case, the https://monarch-initiative.github.io/pheval/executing_a_benchmark/ has been updated.
If you want to explore the pipeline process further, we have a dedicated repository available at https://github.com/monarch-initiative/monarch_pheval.
This pipeline includes ready-to-use "recipes" structured with Makefile and YAML configuration files, designed to simplify each step.
There is a branch specifically for PhEval paper experiments (the pheval-paper branch). We are actively updating the documentation to enhance usability, and your feedback is essential to this process.
Thank you!

Hi @souzadevinicius Thank you for the update but I've waiting a recommendation or fix for my problems listed in #347 (comment) when I followed this guide: https://monarch-initiative.github.io/pheval/exomiser_pipeline. I'm stuck with this and I can't continue to the benchmark. If you want, you can point me to a guide for a Exomiser execution with pheval and another to make the benchmark to start from zero again. In this way, we all stay in the same page an we could debug together the bug origin. Thank you in advance Pedro Seoane

Hello, Pedro.
You're completely right about your suggestion of adding j2cli as a dependency and we did it.
However, as I mentioned, we moved all pipeline code to a new repository to decouple this core PhEval repository from the pipeline code.
Additionally, in the updated documentation we don't mention j2 anymore because everything is encapsulated in Monarch PhEval repository. The Makefile generation is also fixed.
If you have any other questions or issues, let us know.

Hi @souzadevinicius
I've solved the j2cli and the yaml errors but the following it's blocking me (I write the text from the previous message):

Finally, the makefile has some problem because this error: Makefile:149  *** target pattern contains no '%'. Stop.. The mentioned makefile line contains:

prepare-corpora: corpora/small_test/scrambled-0.5/corpus.ymlcorpora/small_test/scrambled-0.7/corpus.yml: corpora/small_test/default/corpus.yml $(ROOT_DIR)/testdata/template_vcf/template_exome_hg19.vcf.gz
        test -d $(ROOT_DIR)/corpora/small_test/scrambled-0.7/ || mkdir -p $(ROOT_DIR)/corpora/small_test/scrambled-0.7/
        test -L $(ROOT_DIR)/corpora/small_test/scrambled-0.7/template_exome_hg19.vcf.gz || ln -s $(ROOT_DIR)/testdata/template_vcf/template_exome_hg19.vcf.gz $(ROOT_DIR)/corpora/small_test/scrambled-0.7/template_exome_hg19.vcf.gz

This error I'm unable to resolve it. Any suggestion?
Thank you in advance
Pedro Seoane

Hi @souzadevinicius I've solved the j2cli and the yaml errors but the following it's blocking me (I write the text from the previous message):

Finally, the makefile has some problem because this error: Makefile:149  *** target pattern contains no '%'. Stop.. The mentioned makefile line contains:

prepare-corpora: corpora/small_test/scrambled-0.5/corpus.ymlcorpora/small_test/scrambled-0.7/corpus.yml: corpora/small_test/default/corpus.yml $(ROOT_DIR)/testdata/template_vcf/template_exome_hg19.vcf.gz
        test -d $(ROOT_DIR)/corpora/small_test/scrambled-0.7/ || mkdir -p $(ROOT_DIR)/corpora/small_test/scrambled-0.7/
        test -L $(ROOT_DIR)/corpora/small_test/scrambled-0.7/template_exome_hg19.vcf.gz || ln -s $(ROOT_DIR)/testdata/template_vcf/template_exome_hg19.vcf.gz $(ROOT_DIR)/corpora/small_test/scrambled-0.7/template_exome_hg19.vcf.gz

This error I'm unable to resolve it. Any suggestion? Thank you in advance Pedro Seoane

Hello, @seoanezonjic.
My suggestion is to generate a new Makefile.
You can do it by cloning the monarch_pheval repository and regenerating the Makefile.
Just do these simple steps:

git clone -b new-paper-2025 https://github.com/monarch-initiative/monarch_pheval.git
fill the ./resources/pheval-config.yaml file with your experiment descriptions
execute the script ./resources/generatemakefile.sh
type make pheval

Hi @souzadevinicius
I've installed pheval.exomiser and then I've obtained the following errors:
	pheval run \
 --input-dir /mnt/home/users/pab_001_uma/pedro/proyectos/pheval/PIPELINE/monarch_pheval/configurations/exomiser-14.0.0-2402_phenotype \
 --testdata-dir /mnt/home/users/pab_001_uma/pedro/proyectos/pheval/PIPELINE/monarch_pheval/corpora/lirical/default \
 --runner exomiserphevalrunner \
 --tmp-dir data/tmp/ \
 --version 14.0.0 \
 --output-dir /mnt/home/users/pab_001_uma/pedro/proyectos/pheval/PIPELINE/monarch_pheval/results/exomiser-14.0.0-2402_phenotype
preparing
Traceback (most recent call last):
  File "/mnt/home/users/pab_001_uma/pedro/proyectos/pheval/PIPELINE/monarch_pheval/.venv/bin/pheval", line 8, in <module>
    sys.exit(pheval())
  File "/mnt/home/users/pab_001_uma/pedro/proyectos/pheval/PIPELINE/monarch_pheval/.venv/lib/python3.10/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/mnt/home/users/pab_001_uma/pedro/proyectos/pheval/PIPELINE/monarch_pheval/.venv/lib/python3.10/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/mnt/home/users/pab_001_uma/pedro/proyectos/pheval/PIPELINE/monarch_pheval/.venv/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/mnt/home/users/pab_001_uma/pedro/proyectos/pheval/PIPELINE/monarch_pheval/.venv/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/mnt/home/users/pab_001_uma/pedro/proyectos/pheval/PIPELINE/monarch_pheval/.venv/lib/python3.10/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/mnt/home/users/pab_001_uma/pedro/proyectos/pheval/PIPELINE/monarch_pheval/.venv/lib/python3.10/site-packages/pheval/cli_pheval.py", line 90, in run
    runner_instance.prepare()
  File "/mnt/home/users/pab_001_uma/pedro/proyectos/pheval/PIPELINE/monarch_pheval/.venv/lib/python3.10/site-packages/pheval_exomiser/runner.py", line 30, in prepare
    configurations=ExomiserConfigurations.parse_obj(
  File "/mnt/home/users/pab_001_uma/pedro/proyectos/pheval/PIPELINE/monarch_pheval/.venv/lib/python3.10/site-packages/pydantic/main.py", line 1162, in parse_obj
    return cls.model_validate(obj)
  File "/mnt/home/users/pab_001_uma/pedro/proyectos/pheval/PIPELINE/monarch_pheval/.venv/lib/python3.10/site-packages/pydantic/main.py", line 596, in model_validate
    return cls.__pydantic_validator__.validate_python(
pydantic_core._pydantic_core.ValidationError: 3 validation errors for ExomiserConfigurations
application_properties.hg19_data_version
  Input should be a valid string [type=string_type, input_value=2402, input_type=int]
    For further information visit https://errors.pydantic.dev/2.9/v/string_type
application_properties.hg38_data_version
  Input should be a valid string [type=string_type, input_value=2402, input_type=int]
    For further information visit https://errors.pydantic.dev/2.9/v/string_type
application_properties.phenotype_data_version
  Input should be a valid string [type=string_type, input_value=2402, input_type=int]
    For further information visit https://errors.pydantic.dev/2.9/v/string_type
make: *** [Makefile:69: /mnt/home/users/pab_001_uma/pedro/proyectos/pheval/PIPELINE/monarch_pheval/results/exomiser-14.0.0-2402_phenotype/results.yml] Error 1

This I 've fixed editing runners/configurations/exomiser-14.0.0-2402_phenotype.config.yaml and change 2402 to "2402" but then  the following error arises:
Traceback (most recent call last):
  File "/mnt/home/users/pab_001_uma/pedro/proyectos/pheval/PIPELINE/monarch_pheval/.venv/bin/pheval", line 8, in <module>
    sys.exit(pheval())
  File "/mnt/home/users/pab_001_uma/pedro/proyectos/pheval/PIPELINE/monarch_pheval/.venv/lib/python3.10/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/mnt/home/users/pab_001_uma/pedro/proyectos/pheval/PIPELINE/monarch_pheval/.venv/lib/python3.10/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/mnt/home/users/pab_001_uma/pedro/proyectos/pheval/PIPELINE/monarch_pheval/.venv/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/mnt/home/users/pab_001_uma/pedro/proyectos/pheval/PIPELINE/monarch_pheval/.venv/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/mnt/home/users/pab_001_uma/pedro/proyectos/pheval/PIPELINE/monarch_pheval/.venv/lib/python3.10/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/mnt/home/users/pab_001_uma/pedro/proyectos/pheval/PIPELINE/monarch_pheval/.venv/lib/python3.10/site-packages/pheval/cli_pheval.py", line 91, in run
    runner_instance.run()
  File "/mnt/home/users/pab_001_uma/pedro/proyectos/pheval/PIPELINE/monarch_pheval/.venv/lib/python3.10/site-packages/pheval_exomiser/runner.py", line 49, in run
    run_exomiser(
  File "/mnt/home/users/pab_001_uma/pedro/proyectos/pheval/PIPELINE/monarch_pheval/.venv/lib/python3.10/site-packages/pheval_exomiser/run/run.py", line 208, in run_exomiser
    run_exomiser_local(
  File "/mnt/home/users/pab_001_uma/pedro/proyectos/pheval/PIPELINE/monarch_pheval/.venv/lib/python3.10/site-packages/pheval_exomiser/run/run.py", line 120, in run_exomiser_local
    exomiser_jar_file = [
IndexError: list index out of range

I've debugged line 117 from pheval_exomiser/run/run.py and a simple print as following:
    print(f"_{config.exomiser_software_directory}_", file=sys.stderr)
    print(f"_{input_dir.joinpath(config.exomiser_software_directory)}_", file=sys.stderr)

Shows this:
_._
_/mnt/home/users/pab_001_uma/pedro/proyectos/pheval/PIPELINE/monarch_pheval/configurations/exomiser-14.0.0-2402_phenotype_

This is a path error because exomiser is installed in the runners folder as I can see in my local installation of the monarch-pheval. Maybe is a misconfiguration in my yaml file?
Thank you in advance
Pedro Seoane

Yes maybe it is, please share your config.yaml file.

Here it is:
directories:
  data: data
  tmp: data/tmp

corpora:
  - id: lirical
    custom_variants:
      - id: no_phenotype

configs:
  - tool: exomiser
    id: exomiser-14.0.0-2402_phenotype
    version: 14.0.0

runs:
  - tool: exomiser
    corpus: lirical
    corpusvariant: default
    version: 14.0.0
    phenotype: "2402"
    configuration: exomiser-14.0.0-2402_phenotype

The problem is in config.yaml file inside the exomiser configuration folder.
_/mnt/home/users/pab_001_uma/pedro/proyectos/pheval/PIPELINE/monarch_pheval/configurations/exomiser-14.0.0-2402_phenotype_/config.yaml
You need to specify where the exomiser is located by this
exomiser_software_directory:
I have the exomiser installation inside the config folder in my local example.
If you don't follow the same structure, specify where your exomiser installation is.
My current local structure in the configurations folder:
📦configurations
┗ 📂exomiser-14.0.0
┃ ┣ 📂2402_hg19
┃ ┣ 📂2402_hg38
┃ ┣ 📂2402_phenotype
┃ ┣ 📂examples
┃ ┣ 📂lib
┃ ┣ 📂results
┃ ┣ 📜application.properties
┃ ┣ 📜config.yaml
┃ ┣ 📜exomiser-cli-14.0.0.jar
┃ ┗ 📜preset-exome-analysis.yml
The Exomiser content is located in the configurations folder, so the exomiser_software_directory: in the config.yaml file is set to ".", indicating that Exomiser is in the current directory.

Hi @souzadevinicius
I'll try your suggestion but I expect that if the Makefile download and install the software in its own (in this case, it installed exomiser into de runners folder at the same level that configurations folder)), the system should be able to take into account the installation path that was used in configuration steps. Now that I know the exomiser_software_directory:
directive even I could use previous system installations.
I suggest you to think and check that monarch_pheval repository will make a download, installation and execution steps in one Makefile at least with exomiser but with no user configuration (all automatized). Once the user is able to check that the system works in his/her environment, he/she could toy with the configuration to adapt to his/her needs.
Currently its a bit frustrating to work with the workflow.
Thank you in advance
Pedro Seoane


Automatically generate markdown pages for each author

This automatically produces markdown files associated with each author, to solve #4

this is so great!! thanks @mbjoseph - one less thing for me to do.
One small change -- the RMD needs to produce a MD file that looks like this:
----
layout: post-by-author
author: Matt Oakley
permalink: /authors/matt-oakley/
title: 'Matt Oakley'
author_profile: false
site-map: true
----

From what i can tell, the md pages now are missing the --- at the beginning and and which designates the content as front matter . If i am missing something, please let me know.
Also - we should briefly chat about listing authors by friendly name (with spaces) vs the slug in the front matter. Programmatically do you think it's ok to use Matt Oakley vs matt-oakley ? i think i've used the friendly name (with spaces) on other sites but just wanted to see what you thought. sometimes it's a bit more fool prof to not allow spaces and such when coding.

Ok the yaml is now fenced in above and below with 4 hyphens. I think listing authors by friendly names is probably fine.


bump syn to v1

to reduce the chance of compiling several instances of it

bors r+

bors r-

bors r+

bors r+


authgear

Gateway

Remove gateway code

Asset Gear

Move its code to a new repository
Remove the dependency on tenant config
Introduce master key as an env var
Introduce secret as an env var
Extract the upload code as a recipe (instead of making a new SDK)

Auth Gear

API changes

Rename /_auth/session/resolve to something else
Remove skygear_user in ID token claims
Add the new claim in full URL form to indicate is_anonymous
Add the new claim in full URL form to indicate metadata
Remove session in hook context
Remove the feature disable user
Remove the feature verification
Remove master key

Internal changes

Remove asset gear loader in template engine
Remove the dependency on libvips
Fix last login at
Remove master key from tenant config
Remove irrelevant files from the repository
Migrate CI/CD to GitHub Actions

Database schema

Consolidate migrations
Rename _core_user to _auth_user
Merge _auth_user_profile into _auth_user
Consider switch to a migration tool that keeps full history of executed migrations, not just the latest version.

Relocation

Move it to authgear/authgear

Documentation

Move skygeario/features to /features
Move skygeario/guides to authgear/docs
Rewrite authgear/docs to be more relevant

SDK

Rename the packages
Move it to authgear/authgear-sdk-js
Delete generation of IIFE bundle
Delete examples
Delete observer
Delete asset gear container
Delete node client
Delete the existing docs site
DocFX v3 supports versioning but it is not released yet
Revamp the current API
Emit onAccessTokenExpired (single handler)
Emit onRefreshTokenExpired (single handler)
Register default onAccessTokenExpired handler to refresh access token

Future works

Support k8s CRD config backend
Introduce authgear/helm-chart
Write an example app and use authgear/helm-chart to deploy
Secret Management (Needs design)
Multi-tenant by hostname
Move database connection URI to envvar?
Integrate OpenTelemetry

Do we want to cleanup the core packages and remove irrelevant stuff/merge into auth package/new repo?
Do we want to do #1433 as part of refactor? (i.e. use library instead of hand-rolled OAuth implementation)
We may also want to cleanup the configuration.
I suppose we can drop access key entirely now.

Do we want to cleanup the core packages and remove irrelevant stuff/merge into auth package/new repo?

Sure!

Do we want to do #1433 as part of refactor? (i.e. use library instead of hand-rolled OAuth implementation)

As long as we have time. So this is not of our first priority.

We may also want to cleanup the configuration.

For example?

I suppose we can drop access key entirely now.

We still have the concept of client ID

We may also want to cleanup the configuration.

double api_version in app_config?
app_id should not be needed.
flatten app_config?
template configuration need rework?
do we refactor the secrets out of config now?

We still have the concept of client ID

Yes we do have it, but we can stop accepting it through the access key header, thus removing the concept of access key entirely.

double api_version in app_config?

Can remove them entirely.

app_id should not be needed.

Should be OK.

flatten app_config?
template configuration need rework?

I am fine with it.

do we refactor the secrets out of config now?

Good idea. But we may not have time to do secret management in this sprint. What temporary solution do we have? Load another file?

Maybe just start a new one instead of moving skygeario/guides to authgear/docs?

web UI remove webappstep & state, expose interaction.StepState directly
merge web UI state with interaction flow state
move web UI request decoding/redirection to handlers

so add route is copy/paste a single file and change relevant places.

use static singleton validator per handler

directly use global variable in handler.

remove msgpack
delete app_id, use constant in single tenant mode, use tenant key in multi-tenant mode
move translation to a file in handlers/webapp

share by all handlers

refactor render provider: a set of helper functions
all form should novalidate, don't use html5 validation
request validation is moved to interaction flow, use JSON schema, inject context (details) into error in flows.

webapp static asset self-host (no CDN provided)
static asset pack into output binary (packr?)
development workflow: use parcel to watch & compile assets?


Updated Cloudflare solution for bugs

Required items, please complete
Change(s):

Updated AR description, azure storage link and name

Reason for Change(s):

Considering the inconsistency/discrepancy

Version Updated:

Yes, solution version updated

Testing Completed:

See guidance below

Checked that the validations are passing and have addressed any issues that are present:

See guidance below

Guidance <- remove section before submitting

Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:
Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR.  Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process.  Providing associated Issues that this resolves also easily connects the reason.

Change(s):

Updated syntax for XYZ.yaml

Reason for Change(s):

New schema used for XYZ.yaml
Resolves ISSUE #1234

Version updated:

Yes
Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly.  If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:

Guidance for Detection checks
General contribution guidance
PR validation troubleshooting

@v-dvedak, the changes are good, but as discussed should it be merged with the given solutionid?

Hello @v-dvedak do not Merge need to make some changes


SocketException: Connection failed (OS Error: Machine is not on the network, errno = 64)

I am trying to connect to an IoT device that has no connection and then doing some http requests. but the device doesn't recognise the method get, and I got the error on the title, any ideas what is happening here ?

@imrikim
IoT device that has no connection since the device you are targeting has no connection, the error being thrown seems to be correct as it says Machine is not on the network,.
You can try to ask this on support channels like Stackoverflow to get solutions. Closing from here. If you disagree or think this is a Flutter issue, write in comments and I'll reopen it.

Okay 👍
let's close the issue then since the error is correct and nothing weird here.


feat: add support for v19

For the first time since the release, this one would be breaking because we're cutting the angular version to only support v19 and higher, since standalone is true and we removed allowSignalWrites from utilties.


Mapping same entity to different slots

rasa_core: 0.11.4
python: 3.6.6
OS: macOS 10.14
I am building a flight information retrieval system. I have an entity type: location and two slots, origin and destination. The system can ask the user about the city of origin: utter_ask_origin and also ask about the city of destination: utter_ask_destination. In both cases, the user might give a simple answer like Los Angeles or New York. The intent of this message is inform_location with location entity: Los Angeles or New York. In the first case, I need it to be mapped to slot: origin and in the second case I need it to be mapped to slot: destination. What is the best way to do that?
domain.yml
intents:
  - greet
  - goodbye
  - ask_flights
  - inform_origin
  - inform_dest
  - inform_location
  - inform_date
  - inform_airline
  - easter_egg
  - affirm
  - negate

slots:
  origin:
    type: text
  destination:
    type: text
  date:
    type: text
  airline:
    type: text

entities:
  - origin
  - destination
  - location
  - date
  - airline

templates:
  utter_greet:
    - "Hello! How can I help you?"
    - "Welcome! What can I do for you?"
  utter_goodbye:
    - "Bye!"
    - "Goodbye!"
  utter_ask_origin:
    - "What is your origin city?"
    - "Where do you want to travel from?"
    - "Name the city from where you want to start?"
  utter_ask_destination:
    - "What is your destination city?"
    - "Where do you want to travel to?"
    - "Name the city you want to reach?"
  utter_ask_date:
    - "What is your date of journey?"
    - "When do you want to travel?"
  utter_ask_airline:
    - "Which airline do you want to travel with?"
  utter_easter_egg:
    - "Fight on for ol’ SC!"

actions:
  - utter_greet
  - utter_goodbye
  - utter_ask_origin
  - utter_ask_dest
  - utter_ask_date
  - utter_ask_airline
  - utter_easter_egg
  - action_time

Please ask these kind of questions in our forum


Backport: Check cert expiration and regenerate

https://github.com/rancher/rancher/issues/19156

LGTM


Call expression

This change is

Current dependencies on/for this PR:

main

PR #3083

PR #3084

PR #3093   👈

This comment was auto-generated by Graphite.


Incorrect highlighting when using backslashes for line continuation in TypeScript

version 0.10.10-insider

bug demo.zip

This issue was moved to Microsoft/TypeScript-TmLanguage#104


change all len(QuerySet) to QuerySet.count()

Where it makes sense, much more memory efficient for large counts.

Did not find many, closing.


Update

Created optional --fullname parameter to add folder names to playlists. And added a description to readme file.
Created a condition for formatting on MacOS (lines 102-105), had to add sys module for it to work properly. This was done as removal of the root path (lines 106-108) does not have any effect on MacOS.
I suggest pretesting on Windows just to make sure everything runs smoothly.

Seems to work. Thank you :)


Fatal error on incorrect usage

Description
On swift-macro-testing 0.2.0 and main, the following error in assertMacro usage results in a crash:
    assertMacro {
      """
      @MemberwiseInit
      public struct Pedometer {
        var stepsToday = 0
      }
      """
    } expansion: {
      """
      @MemberwiseInit
      public struct Pedometer {
        var stepsToday = 0
            ┬─────────────
            ╰─ 🛑 @MemberwiseInit requires explicit type declarations for `var` stored properties.
      }
      """
    }

My user error was to use the label expansion: instead of diagnostics:. The crash happens deep into the SyntaxVisitor.walk due to an unsafe unwrap. Every one of my tests exercising a diagnostic had this user error and resulted in the same crash.
I discovered this while updating my tests to 0.2.0, using an overly naive find/replace from "matches" to "expansion", having eschewed the given "re-record" advice.
This strikes me as a Swift Syntax issue: I don't think Swift Syntax's RawSyntaxChildren is ever intended to ever fatal error, even on bad input. Thoughts?
Checklist

[X] If possible, I've reproduced the issue using the main branch of this package.
[X] This issue hasn't been addressed in an existing GitHub issue or discussion.

Expected behavior
No response
Actual behavior
No response
Steps to reproduce
No response
swift-macro-testing version information
0.2.0, main (3c9424a)
Destination operating system
No response
Xcode version information
Xcode Version 15.0 (15A240d)
Swift Compiler version information
No response

Thanks so much for the report! Can you give #7 a try and see if the experience is somewhat improved?


Add backgroundColor to Checkbox and CheckboxThemeData

Use case
When a checkbox is unchecked, the background color/fill color is transparent.
It would be nice to have a way to have a parameter to change it and be able to set it in the theme.
Right now, I have to use a ColoredBox around the Checkbox in addition to a SizedBox to remove the padding of the Checkbox.
See this Stack Overflow question

I would like to set the background color of a Checkbox, like this image (unchecked check box)

Here is my code to achieve this at the moment:
class Home extends StatefulWidget {
  const Home({super.key});

  @override
  State<Home> createState() => _HomeState();
}

class _HomeState extends State<Home> {
  var _value = false;
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: SizedBox(
          height: 16,
          width: 16,
          child: ColoredBox(
            color: Colors.green,
            child: Checkbox(
              value: _value,
              onChanged: (value) {
                setState(() {
                  _value = value!;
                });
              },
            ),
          ),
        ),
      ),
    );
  }
}

Proposal
Add a parameter backgroundColor to Checkbox and a property backgroundColor to the CheckboxThemeData.

CC @danagbemava-nc
It should possible to set the Checkbox fillColor property (which serves all states) in individual check boxes or with the CheckboxTheme.

Hi @HansMuller, I took a look at that example but it didn't seem to work how @ValentinVignal wanted it to. I tried making the fillColor for all possible states using MaterialStateProperty.all any color but if the checkbox was not checked, only the border was drawn. I also looked at the source code for the _CheckBoxPainter and it seemed like it only painted the background if the value is not checked.
https://github.com/flutter/flutter/blob/bd4c792ba4ed945d97a11dd36bb9a520987b6659/packages/flutter/lib/src/material/checkbox.dart#L739-L755


Self Hosting Inference API

Hello, great cli app!
Would it be possible to release the inference API source code if not already done, to be able to self host the inference API?
Regards.

Hey @Extremys Thank you for you kind words and yes indeed.
 We have a hosted inference, that you can hit.
response = openai.ChatCompletion.create(
                api_base = "http://<IP_ADDRESS>:8000/v1",
                model='gorilla-bash-v0',
                temperature=0.1,
                messages=messages,
)

Hope this helps. Let me know if you have any other questions!

No He means he wants the model to host it on his own environment

No He means he wants the model + API implementation of it, to host it on his own environment

Yes exactly :) with the API service


Autostart

How do I autostart a tunnel on system startup and run it in the background?

Take a looking at autossh for running tunnels. You can then use the system supervisor (launchd, systemd, upstart, etc). Here's an example, https://github.com/antoniomika/sish/issues/70#issuecomment-585520286. Gonna close this since it's out of scope for this repo.


demo

Hey guys,
looks pretty cool. Is there a demo of an app running on it anywhere? Plus, what's SSC?
Best

Hey!
For now, you can check web folder. Website landing itself uses SSC for components separation. But, to be honest, it's not so good example in terms of using all available features. I had old demo project, which was a bit outdated and not entirely clear. I'm working on providing better documentation and demo now.
SSC - Server Side Components, is a way to use components approach with old-fashioned templates. It ships with set of features, like asynchronous operations, methods, etc.
Main idea - use server side as much as possible, with minimal JS payload.
For now, main consumer of a library is BrokerOne team: https://mybrokerone.com.
Most of the fronend was done using this library.
So, I'll leave this issue as a requirement for good demo project :)

mybrokerone.one is a great example. would be great to see how it's implemented in the backend, but I can wait :)
great potential, and very ambitious, really looking forward to seeing where this is going!

Unfortunately, I can't share BrokerOne project parts. I'll talk with my team, maybe I'll release a few articles with interesting usage examples. Instead, I've provided basic demo project with using of components approach and some library features. It can be found here: https://github.com/yuriizinets/ssceng/tree/master/demo
Also, I've improved Quick Start section in documentation, so it would be easier to start.
Closing this issue for now. If you need more detailed demo, please, re-open this issue with details, or contact me directly. I understand that not all features are covered by demo page. I'll improve it during writing documentation.


Initialize

In this Milestone, The following has been done:

Initialized React app.
Added React-Redux.
Structured the application files using a "feature folder" approach.
Added React Router and set two s and s for the app's navigation

Hi @Lichapa
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
Linters are not setup on your project. Kindly ensure to setup the recommended linters for this project via this link
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Invalid Code Review Request Does not count into the code reviews limit.


NullReferenceException when logging as Trace and an argument is null

System.NullReferenceException: Object reference not set to an instance of an object.
   at System.Object.GetType()
   at Microsoft.AspNetCore.SignalR.Client.Internal.SignalRClientLoggerExtensions.<>c.<IssueInvocation>b__33_0(Object a)
   at System.Linq.Enumerable.SelectArrayIterator`2.MoveNext()
   at System.String.Join(String separator, IEnumerable`1 values)
   at Microsoft.AspNetCore.SignalR.Client.Internal.SignalRClientLoggerExtensions.IssueInvocation(ILogger logger, String invocationId, String returnType, String methodName, Object[] args)
   at Microsoft.AspNetCore.SignalR.Client.HubConnection.InvokeCore(String methodName, InvocationRequest irq, Object[] args, Boolean nonBlocking)
   at Microsoft.AspNetCore.SignalR.Client.HubConnection.SendAsyncCore(String methodName, Object[] args, CancellationToken cancellationToken)
   at Microsoft.AspNetCore.SignalR.Client.HubConnection.<SendAsync>d__28.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at ChatClient.ChatClient.<SendMessage>d__6.MoveNext() in C:\source\SignalR-Samples\ChatSample\ChatClient\ChatClient.cs:line 56

apparently here.
This might be some kind of an internal race. The code used to send messages looks like this:
            try
            {
                await _hubConnection.SendAsync("Send", _name, message);
            }
            catch (Exception ex)
            {
                Console.WriteLine($"Message not sent due to {ex.Message}");
            }

and it works just fine most of the time. But sometimes it throws. I hit it when trying to implement reconnects:
Message not sent due to Connection has been terminated.
> trce: Microsoft.AspNetCore.SignalR.Client.InvocationRequest.NonStreaming[0]
      Invocation 22 created.
fail: Microsoft.AspNetCore.SignalR.Client.HubConnection[19]
      Invoke for Invocation '22' was called after the connection was terminated.
dbug: Microsoft.AspNetCore.Sockets.Client.HttpConnection[2]
      10/10/2017 12:28:23: Connection Id 95844461-ca7f-4395-ae8d-44b5238fce9f: Starting transport 'LongPollingTransport' with Url: http://localhost:5000/chat?id=95844461-ca7f-4395-ae8d-44b5238fce9f.
info: Microsoft.AspNetCore.Sockets.Client.LongPollingTransport[0]
      10/10/2017 12:28:23: Connection Id 95844461-ca7f-4395-ae8d-44b5238fce9f: Starting transport. Transfer mode: Text.
dbug: Microsoft.AspNetCore.Sockets.Client.LongPollingTransport[2]
      10/10/2017 12:28:23: Connection Id 95844461-ca7f-4395-ae8d-44b5238fce9f: Starting receive loop.
dbug: Microsoft.AspNetCore.Sockets.Client.LongPollingTransport[6]
      10/10/2017 12:28:23: Connection Id 95844461-ca7f-4395-ae8d-44b5238fce9f: Starting the send loop.
trce: Microsoft.AspNetCore.Sockets.Client.HttpConnection[10]
      10/10/2017 12:28:23: Connection Id 95844461-ca7f-4395-ae8d-44b5238fce9f: Beginning receive loop.
info: Microsoft.AspNetCore.SignalR.Client.HubConnection[22]
      Using HubProtocol 'json'.
dbug: Microsoft.AspNetCore.Sockets.Client.HttpConnection[17]
      10/10/2017 12:28:23: Connection Id 95844461-ca7f-4395-ae8d-44b5238fce9f: Sending message.
dbug: Microsoft.AspNetCore.Sockets.Client.HttpConnection[3]
      10/10/2017 12:28:23: Connection Id 95844461-ca7f-4395-ae8d-44b5238fce9f: Raising Connected event.
dbug: Microsoft.AspNetCore.Sockets.Client.LongPollingTransport[9]
      10/10/2017 12:28:23: Connection Id 95844461-ca7f-4395-ae8d-44b5238fce9f: Sending 1 message(s) to the server using url: http://localhost:5000/chat?id=95844461-ca7f-4395-ae8d-44b5238fce9f.

Message not sent due to Object reference not set to an instance of an object.

Nice, so we should probably handle null arguments

Yes. I did not notice but when I pressed Ctrl+C Console.ReadLine() returned null which I tried to send and got the exception. I think we should review logging since I think I saw the same pattern in at least one more place.

Fixed in 8f770e


Add link to Zulip blog.

@hackerkid unfortunately the navigation part of zulip.org is manually repeated on all the pages, so to make this work correctly you need to add it on all of them.

@timabbott Fixed. Added link in all 5 pages.

Merged, thanks @hackerkid!