non-passive event listeners

New Chrome prints the following warnings in verbose mode (which is related to this new feature: https://github.com/WICG/EventListenerOptions/blob/gh-pages/explainer.md):
[Violation] Added non-passive event listener to a scroll-blocking 'wheel' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952
Is there any chance to expose this configuration option to be setup by developers, or to hardcode it according to new standards?

I think it is hardcoded
https://github.com/openseadragon/openseadragon/blob/eafdc452c9e312f1f69a44bbb0db0023826da92d/src/mousetracker.js#L1343-L1348
I tried replaced the hardcoded false with {passive: true} and the warning disappeared

Coincidentally, I'm working on a MouseTracker update right now and that will be addressed!

@msalsbery Wonderful!
I imagine we want to use { passive: false }, since we can indeed cancel the default scrolling behavior, right?

I imagine we want to use { passive: false }, since we can indeed cancel the default scrolling behavior, right?

@iangilman Yes sir! :)

...and word on the street is Apple is FINALLY working on implementing the W3C pointer events model, which is great news after all these years!

Sweet! I'm excited!

Coincidentally, I'm working on a MouseTracker update right now and that will be addressed!
Thank you for the heads-up!

When will this enhancement be released?

Hi @NEXCO-WestUSA
Finally getting real close, and just remembered this issue when I turned on verbose console mode on the new Chromium-based Edge (love that browser!)
Will update very soon...We will need to set passive false so I’m not sure the warnings will go away, but we’ll  see...

@iangilman Thinking out loud, I'm not sure how to address that. One fix is to mark it passive to eliminate the warning, but that affects the out-of-the-box behavior of OpenSeadragon viewers, and could mean a (possibly breaking) API change...
I don't know....I know it's not crucial -the warning was added so wheel event handlers on window, document, and document.body wouldn't have their handling burdened, none of which applies to us...

Yeah, we want to keep the functionality. There's no way to tell the browser, "No we really mean it, don't worry about it"?
I suppose we could add a flag to turn it off for people who care more about the warnings than the functionality, but I'm concerned that's just adding more noise to the API. I kind of think maybe if you ask for verbose warnings this is part of what you get? Anyway, I don't feel strongly either way, so long as we keep the functionality.

@iangilman  Agreed. For sure the functionality isn’t going to change, it’s just a strange warning for the browsers to add. It’s strictly informational, and if one sets the handler as passive and still calls preventDefault then the result is just another warning. So either way, our gesture handling is going to generate a warning.
I’m not real concerned about it, but I do intend to dig for discussions by the implementors on the rationale and at least update our documentation accordingly

@iangilman ...so now that I think about it, I misspoke when I stated it would change the functionality...only the warning would change.
Anyway, mostly just tracking my thoughts here for reference when I get to that part of the patch I’m currently working on...there’s already too much machinery to try to keep straight in my head  ;-)

Our wheel event handling is correct in its need to call preventDefault so can't be passive. Not anything we can do about the warning.
OpenSeadragon.addEvent() now supports the EventTarget.addEventListener() options parameter on user agents that support it. We don't use it internally as we have no hard-coded passive event handling.
Closing this...feel free to re-open if it's still an issue!

Re @iangilman's comment about telling the browser "we meant to do that" — I've only played around with this a little bit, but it seems like if you explicitly pass passive: false this silences the warning, e.g.
canvas.addEventListener('wheel', listener, { passive: false, capture: true })

@dmolesUC great! Seems worth doing :)
@msalsbery sound good? Do you want to take care of this?

@iangilman @dmolesUC
Yes seems like it's worth doing. I'll handle it

Fixed by #2043
@dmolesUC Thank you for the great suggestion!


Add Google Analytics

We need to track:
First Priority:

number of total page session
number of visits per dataset
which Census Categories users are selecting (ie: Age, Income, Race, etc)
which Filter Types are being selected (County Name or County Type)
number of downloads (and which dataset)
if people are changing adequacy method (Haversine vs Driving Time)

Second Priority:

time per session
time for RPs to load (between dataset selection and client receiving RPs)
time for analysis to load (between dataset selection and adequacy loaded)

[ ] Create Google Analytics account
[ ] Hook up the GA Tracking Code (typically in our analytics_lib.js file)
[ ] Set up relevant Goals and Funnels
[ ] Set up Google Webmaster Tools
[ ] Verify site in Webmaster Tools with DNS TXT record
[ ] Link Webmaster Tools to Google Analytics

will update this comment as i add things
~number of total page session~ covered
~number of visits per dataset~ number of times each dataset is selected covered
which Census Categories users are selecting (ie: Age, Income, Race, etc)
which Filter Types are being selected (County Name or County Type)
number of downloads (and which dataset)
if people are changing adequacy method (Haversine vs Driving Time)

Ok, events are flowing in. Need to wait for them to show outside of the real-time view to verify that the attributes are all correct though.


metrics: extract metrics rest api handler from daemon

Currently, the metrics rest api handler is implemented as part of the daemon itself.
To further minimize the number of dependencies on the daemon, this commit extracts the metrics rest api handler into the metrics hive cell.
The bootstrapStatistics remain in the daemon package and are renamed to boostrap_statistics.go accordingly (Will be removed eventually once the daemon startup is fully modularized).

/test

rebased to main to resolve conflicts

/test


[ServiceBus] Add large message support to SBAdministrationClient

addressing issue: https://github.com/Azure/azure-sdk-for-python/issues/20668
swagger update PR: https://github.com/Azure/azure-rest-api-specs/pull/16125

/azp run python - servicebus - tests

/azp run python - servicebus - tests

/azp run python - servicebus - tests


Feature/store data

OOP school library: preserve data
Project requirements

On exit from the app save all the data (books, people, and rentals) into JSON files.
One per type of data we are storing and named accordingly (e.g. rentals.json)
On startup of our app load all data from files.

General requirements

There are no linter errors.
Used correct Gitflow.
Documented work in a professional way.
Follow list of best practices for Ruby.

@franclobo those two commits from my partner. Unfortunately, I don't know why that not showing.

@franclobo those two commits from my partner. Unfortunately, I don't know why that not showing.

I'm sorry @shahadat3669 I didn't notice the blanks.


Increment versions for mobilenetwork releases

Increment package versions for mobilenetwork releases

API change check
API changes are not detected in this pull request.


Delighter: ability to search the debug view

Due to how ... involved the layout of debug is, I went old school. Search the HTML and add a yellow highlight to what we find. Scroll to the first find.

bors merge


Add hotkeys and async action web component examples.

Now that the child components issue has been fixed (https://github.com/google/mesop/issues/449), the hotkeys web component that I was working on a few weeks ago is working now.
Also adding the async action web component example.

Those are great questions. I definitely think the hot key thing would be nice to support natively in mesop. I think we already have a Github issue for it. And I think to do "async actions" in a more full featured way, we'd probably need native support. I think the FastAPI middleware integration could potentially help with this since long running API calls could potentially be sent to a FastAPI endpoint. Something like celery integration would be nice (or whatever is better than celery nowadays). Does GCP have anyway to implement LRO APIs? Maybe revisit Websockets.
But I do like starting off with a web components since it's a cheap way to test out the behavior and usage in the short term. I definitely think the mesop add foo-component can be useful as well in general to improve sharing of components (granted we don't have much of an ecosystem yet).
So I think both ideas are useful.


Fails to use esp-exception-decoder with Arduino IDE 2.1.1 on Windows

Description:
I can find the esp exception decoder in Arduino IDE, but cannot use it, any suggestion would be appreciated.

Hi @ceerqingtingml. The support for the extension was added after the time of the Arduino IDE 2.1.1 release. It is expected that you will get this error when using the extension with an incompatible version of Arduino IDE.
Please try again with the latest nightly build of Arduino IDE. The download links for the nightly build are listed here:
https://www.arduino.cc/en/software#nightly-builds

Alternatively, if you prefer not to use the nightly build of Arduino IDE, you can just wait until the next IDE release comes out (e.g., Arduino IDE 2.1.2). The support for the extension will be included in that upcoming release.


Revise termination section in pod lifecycle concept

Revise the existing docs about Pod termination.

Fix a formatting issue
Overall, have fewer notes
Make sidecar containers more prominent; they are on by default in Kubernetes v1.30

Original | Preview
Fixes #46524
/sig node

/retitle Revise termination section in pod lifecycle concept

/cc @SergeyKanzhelev

/label tide/merge-method-squash

/remove-label tide/merge-method-squash
Each commit in this PR represents a separate unit of work


Deployment requirements incorrectly links to creation of free Azure subscription

The list under the deployment requirements header has a link to create a free Azure subscription -> https://azure.microsoft.com/free/?b=17.06
But Azure Stack customers must use a CSP or EA subscription, not a free one, so think link doesn't seem relevant to Azure Stack customers. I think they should be linked to the AzsReadinessChecker tool instead, to validate their existing subscription- https://docs.microsoft.com/azure-stack/operator/azure-stack-validate-registration

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6facccd9-e7e3-4d83-6797-79a8e6381a37
Version Independent ID: 32429d7e-d806-e9cb-0a28-de2d6ae51113
Content: Azure Stack deployment network traffic
Content Source: azure-stack/operator/deployment-networking.md
Service: azure-stack
GitHub Login: @mattbriggs
Microsoft Alias: mabrigg

Thanks for your feedback, @alexsmithMSFT. This makes sense to me. I've updated the topic. https://github.com/MicrosoftDocs/azure-stack-docs-pr/pull/1911

#please-close


[WIP] Test redux

Codecov Report

Merging #11 into master will increase coverage by 29.66%.
The diff coverage is 95.34%.

@@            Coverage Diff             @@
##           master     #11       +/-   ##
==========================================
+ Coverage   45.14%   74.8%   +29.66%
==========================================
  Files          15      23        +8
  Lines         175     393      +218
  Branches        0       6        +6
==========================================
+ Hits           79     294      +215
- Misses         96      99        +3

Impacted Files
Coverage Δ

Reducers/AppReducerSpec.swift
100% <100%> (ø)

Foursquare Clone/State/AppState.swift
81.81% <81.81%> (ø)

Models/Place.swift
0% <0%> (ø)
:arrow_up:

Models/Category.swift
0% <0%> (ø)
:arrow_up:

Models/Group.swift
0% <0%> (ø)
:arrow_up:

Models/PhotoItem.swift
0% <0%> (ø)
:arrow_up:

Models/PhotoGroup.swift
0% <0%> (ø)
:arrow_up:

Foursquare Clone/Networking/PlacesApi.swift
0% <0%> (ø)
:arrow_up:

Foursquare Clone/Injector/Injector.swift
100% <0%> (ø)
:arrow_up:

Models/PlaceTip.swift
0% <0%> (ø)
:arrow_up:

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af17089...8c5dd3a. Read the comment docs.


Verify ID

On the new person page, when you attach a person by ID, it's good to check the ID that you're entering. This gets the profile and shows a few details.

With the recent changes to how features are registered, there is a conflict. Could you pull the latest development version and make sure your code still works as you intended?

It was a bit too complicated to fix this, so I'll do it again.


[Test Framework] Cleanup logic for cluster types

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[x] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

@nmittler: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
dbc05c4e3ab713429c5d96fe76989326c26f158a
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test release-notes_istio

lint_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test release-notes_istio

lint_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test lint_istio

integ-operator-controller-tests_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test release-notes_istio

lint_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test lint_istio

integ-operator-controller-tests_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test release-notes_istio

lint_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test lint_istio

integ-operator-controller-tests_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test integ-ipv6-k8s-tests_istio

analyze-tests_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test release-notes_istio

lint_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test lint_istio

integ-operator-controller-tests_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test integ-ipv6-k8s-tests_istio

analyze-tests_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test analyze-tests_istio

integ-distroless-k8s-tests_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test release-notes_istio

lint_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test lint_istio

integ-operator-controller-tests_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test integ-ipv6-k8s-tests_istio

analyze-tests_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test analyze-tests_istio

integ-distroless-k8s-tests_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test lint_istio

integ-operator-controller-tests_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test integ-ipv6-k8s-tests_istio

analyze-tests_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test analyze-tests_istio

integ-distroless-k8s-tests_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test integ-pilot-k8s-tests_istio

release-notes_istio
cb3e4c32b2b025ef8ba2111034b147f6f015df2b
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test integ-ipv6-k8s-tests_istio

analyze-tests_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test analyze-tests_istio

integ-distroless-k8s-tests_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test integ-pilot-k8s-tests_istio

release-notes_istio
cb3e4c32b2b025ef8ba2111034b147f6f015df2b
link
/test release-notes_istio

lint_istio
cb3e4c32b2b025ef8ba2111034b147f6f015df2b
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test integ-ipv6-k8s-tests_istio

analyze-tests_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test analyze-tests_istio

integ-distroless-k8s-tests_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test integ-pilot-k8s-tests_istio

release-notes_istio
cb3e4c32b2b025ef8ba2111034b147f6f015df2b
link
/test release-notes_istio

lint_istio
cb3e4c32b2b025ef8ba2111034b147f6f015df2b
link
/test lint_istio

integ-operator-controller-tests_istio
cb3e4c32b2b025ef8ba2111034b147f6f015df2b
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test integ-distroless-k8s-tests_istio

integ-pilot-k8s-tests_istio
bb7172937ed3388d86846a5e42932d886c94853c
link
/test integ-pilot-k8s-tests_istio

release-notes_istio
cb3e4c32b2b025ef8ba2111034b147f6f015df2b
link
/test release-notes_istio

lint_istio
cb3e4c32b2b025ef8ba2111034b147f6f015df2b
link
/test lint_istio

integ-operator-controller-tests_istio
cb3e4c32b2b025ef8ba2111034b147f6f015df2b
link
/test integ-operator-controller-tests_istio

analyze-tests_istio
cb3e4c32b2b025ef8ba2111034b147f6f015df2b
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
cb3e4c32b2b025ef8ba2111034b147f6f015df2b
link
/test release-notes_istio

lint_istio
cb3e4c32b2b025ef8ba2111034b147f6f015df2b
link
/test lint_istio

integ-operator-controller-tests_istio
cb3e4c32b2b025ef8ba2111034b147f6f015df2b
link
/test integ-operator-controller-tests_istio

analyze-tests_istio
cb3e4c32b2b025ef8ba2111034b147f6f015df2b
link
/test analyze-tests_istio

integ-pilot-k8s-tests_istio
cb3e4c32b2b025ef8ba2111034b147f6f015df2b
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
cb3e4c32b2b025ef8ba2111034b147f6f015df2b
link
/test integ-operator-controller-tests_istio

analyze-tests_istio
cb3e4c32b2b025ef8ba2111034b147f6f015df2b
link
/test analyze-tests_istio

integ-pilot-k8s-tests_istio
cb3e4c32b2b025ef8ba2111034b147f6f015df2b
link
/test integ-pilot-k8s-tests_istio

lint_istio
cc00ebb41f28973da251820cc5021982737d9d96
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
cb3e4c32b2b025ef8ba2111034b147f6f015df2b
link
/test integ-operator-controller-tests_istio

analyze-tests_istio
cb3e4c32b2b025ef8ba2111034b147f6f015df2b
link
/test analyze-tests_istio

integ-pilot-k8s-tests_istio
cb3e4c32b2b025ef8ba2111034b147f6f015df2b
link
/test integ-pilot-k8s-tests_istio

lint_istio
cc00ebb41f28973da251820cc5021982737d9d96
link
/test lint_istio

unit-tests_istio
cc00ebb41f28973da251820cc5021982737d9d96
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
cb3e4c32b2b025ef8ba2111034b147f6f015df2b
link
/test integ-operator-controller-tests_istio

integ-pilot-k8s-tests_istio
cb3e4c32b2b025ef8ba2111034b147f6f015df2b
link
/test integ-pilot-k8s-tests_istio

lint_istio
cc00ebb41f28973da251820cc5021982737d9d96
link
/test lint_istio

unit-tests_istio
cc00ebb41f28973da251820cc5021982737d9d96
link
/test unit-tests_istio

analyze-tests_istio
cc00ebb41f28973da251820cc5021982737d9d96
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
cb3e4c32b2b025ef8ba2111034b147f6f015df2b
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
cc00ebb41f28973da251820cc5021982737d9d96
link
/test unit-tests_istio

analyze-tests_istio
cc00ebb41f28973da251820cc5021982737d9d96
link
/test analyze-tests_istio

lint_istio
57a673f36dd70a06cf1ba58bc924e3dd4c00c0f0
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
cb3e4c32b2b025ef8ba2111034b147f6f015df2b
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
25c89a4a211a45e828194afad9bed9a5785bec3d
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
25c89a4a211a45e828194afad9bed9a5785bec3d
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
25c89a4a211a45e828194afad9bed9a5785bec3d
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
25c89a4a211a45e828194afad9bed9a5785bec3d
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
25c89a4a211a45e828194afad9bed9a5785bec3d
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
25c89a4a211a45e828194afad9bed9a5785bec3d
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
25c89a4a211a45e828194afad9bed9a5785bec3d
link
/test integ-multicluster-k8s-tests_istio

lint_istio
800f690e8e3721b31fb28449641e0d763bac5cef
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
25c89a4a211a45e828194afad9bed9a5785bec3d
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
25c89a4a211a45e828194afad9bed9a5785bec3d
link
/test integ-multicluster-k8s-tests_istio

lint_istio
800f690e8e3721b31fb28449641e0d763bac5cef
link
/test lint_istio

gencheck_istio
800f690e8e3721b31fb28449641e0d763bac5cef
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
25c89a4a211a45e828194afad9bed9a5785bec3d
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
25c89a4a211a45e828194afad9bed9a5785bec3d
link
/test integ-multicluster-k8s-tests_istio

lint_istio
823ba72439106081887d8f58c3ade5a43638a66e
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
e9678364221fb9d99798a2e46384649dbfb37e8d
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-multicluster-k8s-tests_istio

@nmittler: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
e9678364221fb9d99798a2e46384649dbfb37e8d
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
e6c9f20901807037db095fb4429bcb9959ead104
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
cdd9d6d3d7cc485ab5f1eb94b1ad8304ebf44ce6
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
cdd9d6d3d7cc485ab5f1eb94b1ad8304ebf44ce6
link
/test integ-multicluster-k8s-tests_istio

release-test_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
cdd9d6d3d7cc485ab5f1eb94b1ad8304ebf44ce6
link
/test integ-multicluster-k8s-tests_istio

release-test_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
cdd9d6d3d7cc485ab5f1eb94b1ad8304ebf44ce6
link
/test integ-multicluster-k8s-tests_istio

release-test_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
cdd9d6d3d7cc485ab5f1eb94b1ad8304ebf44ce6
link
/test integ-multicluster-k8s-tests_istio

release-test_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
cdd9d6d3d7cc485ab5f1eb94b1ad8304ebf44ce6
link
/test integ-multicluster-k8s-tests_istio

release-test_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test unit-tests_istio

integ-security-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
cdd9d6d3d7cc485ab5f1eb94b1ad8304ebf44ce6
link
/test integ-multicluster-k8s-tests_istio

release-test_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test unit-tests_istio

integ-security-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
cdd9d6d3d7cc485ab5f1eb94b1ad8304ebf44ce6
link
/test integ-multicluster-k8s-tests_istio

release-test_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test unit-tests_istio

integ-security-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-operator-controller-tests_istio

integ-pilot-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test unit-tests_istio

integ-security-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-operator-controller-tests_istio

integ-pilot-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test unit-tests_istio

integ-security-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-operator-controller-tests_istio

integ-pilot-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test unit-tests_istio

integ-security-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-operator-controller-tests_istio

integ-pilot-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-distroless-k8s-tests_istio

lint_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test unit-tests_istio

integ-security-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-operator-controller-tests_istio

integ-pilot-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-distroless-k8s-tests_istio

lint_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test lint_istio

integ-helm-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-helm-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test unit-tests_istio

integ-security-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-operator-controller-tests_istio

integ-pilot-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-distroless-k8s-tests_istio

lint_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test lint_istio

integ-helm-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-helm-tests_istio

analyze-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-telemetry-k8s-tests_istio

integ-ipv6-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test unit-tests_istio

integ-security-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-operator-controller-tests_istio

integ-pilot-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-distroless-k8s-tests_istio

lint_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test lint_istio

integ-helm-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-helm-tests_istio

analyze-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test analyze-tests_istio

release-notes_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
d1081b24fb3762da9d3b63121c020cda8c8213c3
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
dde2542c6b3e15271b2cfcff5d4ec7dea64b32da
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@nmittler: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
dde2542c6b3e15271b2cfcff5d4ec7dea64b32da
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
ba0ff9c1d12c033759035ecb92c54e60c20b93a0
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
ba0ff9c1d12c033759035ecb92c54e60c20b93a0
link
/test integ-multicluster-k8s-tests_istio

lint_istio
33ca6bbc6bf30c78be5d4e9992ea80bdb0c6fcc1
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
edcfc22649ea4e062d66ad503b0904f1b97020f3
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
edcfc22649ea4e062d66ad503b0904f1b97020f3
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
70689ee6fe7ece4f7c7eb2c59c0cc3645db2d7b4
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
edcfc22649ea4e062d66ad503b0904f1b97020f3
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
70689ee6fe7ece4f7c7eb2c59c0cc3645db2d7b4
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
70689ee6fe7ece4f7c7eb2c59c0cc3645db2d7b4
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
edcfc22649ea4e062d66ad503b0904f1b97020f3
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
70689ee6fe7ece4f7c7eb2c59c0cc3645db2d7b4
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
70689ee6fe7ece4f7c7eb2c59c0cc3645db2d7b4
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
70689ee6fe7ece4f7c7eb2c59c0cc3645db2d7b4
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
edcfc22649ea4e062d66ad503b0904f1b97020f3
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
70689ee6fe7ece4f7c7eb2c59c0cc3645db2d7b4
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
70689ee6fe7ece4f7c7eb2c59c0cc3645db2d7b4
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
70689ee6fe7ece4f7c7eb2c59c0cc3645db2d7b4
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
70689ee6fe7ece4f7c7eb2c59c0cc3645db2d7b4
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
edcfc22649ea4e062d66ad503b0904f1b97020f3
link
/test integ-multicluster-k8s-tests_istio

integ-ipv6-k8s-tests_istio
70689ee6fe7ece4f7c7eb2c59c0cc3645db2d7b4
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
70689ee6fe7ece4f7c7eb2c59c0cc3645db2d7b4
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
70689ee6fe7ece4f7c7eb2c59c0cc3645db2d7b4
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
70689ee6fe7ece4f7c7eb2c59c0cc3645db2d7b4
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
70689ee6fe7ece4f7c7eb2c59c0cc3645db2d7b4
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

In response to a cherrypick label: #28593 failed to apply on top of branch "release-1.8":
Applying: Cleanup logic for cluster types
Using index info to reconstruct a base tree...
M	pkg/test/framework/components/istio/operator.go
M	tests/integration/helm/install_test.go
M	tests/integration/pilot/cni/cni_test.go
A	tests/integration/security/file_mounted_certs/main_test.go
M	tests/integration/security/sds_ingress/util/util.go
M	tests/integration/telemetry/dashboard_test.go
Falling back to patching base and 3-way merge...
Auto-merging tests/integration/telemetry/dashboard_test.go
Auto-merging tests/integration/security/sds_ingress/util/util.go
CONFLICT (modify/delete): tests/integration/security/file_mounted_certs/main_test.go deleted in HEAD and modified in Cleanup logic for cluster types. Version Cleanup logic for cluster types of tests/integration/security/file_mounted_certs/main_test.go left in tree.
Auto-merging tests/integration/pilot/cni/cni_test.go
Auto-merging tests/integration/helm/install_test.go
Auto-merging pkg/test/framework/components/istio/operator.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Cleanup logic for cluster types
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to a cherrypick label: new issue created for failed cherrypick: #28934


HBASE-28314 Generate source artifacts from mvn install for  every module containing sources

Change-Id: I981e7edb2e5550437d15d716f880656745e94b66

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 26s
master passed

+1 :green_heart:
compile
3m 19s
master passed

+1 :green_heart:
spotless
0m 48s
branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 21s
the patch passed

+1 :green_heart:
compile
3m 24s
the patch passed

+1 :green_heart:
javac
3m 24s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
5m 53s
Patch does not cause any errors with Hadoop 3.3.6.

+1 :green_heart:
spotless
1m 16s
patch has no errors when running spotless:check.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 15s
master passed

+1 :green_heart:
compile
6m  0s
master passed

+1 :green_heart:
spotless
0m 46s
branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 27s
the patch passed

+1 :green_heart:
compile
6m 12s
the patch passed

+1 :green_heart:
javac
6m 12s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m 15s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
6m  4s
Patch does not cause any errors with Hadoop 3.3.6.

+1 :green_heart:
spotless
0m 57s
patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
2m  3s
The patch does not generate ASF License warnings.

38m 36s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5630/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5630

Optional Tests
dupname asflicense javac hadoopcheck spotless xml compile

uname
Linux 7700f84d2c93 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3cfc92fa42

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
77 (vs. ulimit of 30000)

modules
C: hbase-annotations hbase-zookeeper hbase-server hbase-testing-util hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5630/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 38s
master passed

+1 :green_heart:
compile
2m 47s
master passed

+1 :green_heart:
shadedjars
5m  7s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m  6s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 31s
the patch passed

+1 :green_heart:
compile
2m 46s
the patch passed

+1 :green_heart:
javac
2m 46s
the patch passed

+1 :green_heart:
shadedjars
5m  5s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m  5s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 10s
hbase-annotations in the patch passed.

+1 :green_heart:
unit
0m 37s
hbase-zookeeper in the patch passed.

-1 :x:
unit
235m 35s
hbase-server in the patch failed.

+1 :green_heart:
unit
2m 15s
hbase-testing-util in the patch passed.

+1 :green_heart:
unit
1m  3s
hbase-compression-aircompressor in the patch passed.

+1 :green_heart:
unit
0m 51s
hbase-compression-brotli in the patch passed.

+1 :green_heart:
unit
0m 43s
hbase-compression-lz4 in the patch passed.

+1 :green_heart:
unit
0m 45s
hbase-compression-snappy in the patch passed.

+1 :green_heart:
unit
1m 11s
hbase-compression-xz in the patch passed.

+1 :green_heart:
unit
7m 38s
hbase-compression-zstd in the patch passed.

282m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5630/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5630

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3151f6c84231 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3cfc92fa42

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5630/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5630/2/testReport/

Max. process+thread count
4867 (vs. ulimit of 30000)

modules
C: hbase-annotations hbase-zookeeper hbase-server hbase-testing-util hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5630/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

This is the original patch.
Compared to master, this generates source jars in the following modules:
hbase-annotations
hbase-compression-*
hbase-it
hbase-server
hbase-testing-util
hbase-zookeeper
These all have java sources.

I have also uploaded the centralized version as #5635 .
The centralized version also generates sources in the following modules:
hbase-client-project
hbase-shaded-*
hbase-checkstyle
hbase-openssl
hbase-resource-bundle
hbase-client-project SHOULD have sources, it's just missing from the current base patch.
The rest don't have any java sources, and the source jars don't contain anything useful, only the pom, and some license files.

I can see three options:

Use the base patch (also adding hbase-client-project)
Use the centralized project, but define the maven-source-plugin in them with the skip option
Use the centralized project, and ignore the spurious source jars generated

What is your take @

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 47s
master passed

+1 :green_heart:
compile
3m 22s
master passed

+1 :green_heart:
shadedjars
5m  9s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 31s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 49s
the patch passed

+1 :green_heart:
compile
3m 21s
the patch passed

+1 :green_heart:
javac
3m 21s
the patch passed

+1 :green_heart:
shadedjars
5m 15s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 29s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 10s
hbase-annotations in the patch passed.

+1 :green_heart:
unit
0m 40s
hbase-zookeeper in the patch passed.

-1 :x:
unit
231m 23s
hbase-server in the patch failed.

+1 :green_heart:
unit
2m 16s
hbase-testing-util in the patch passed.

+1 :green_heart:
unit
0m 48s
hbase-it in the patch passed.

+1 :green_heart:
unit
1m  2s
hbase-compression-aircompressor in the patch passed.

+1 :green_heart:
unit
0m 50s
hbase-compression-brotli in the patch passed.

+1 :green_heart:
unit
0m 45s
hbase-compression-lz4 in the patch passed.

+1 :green_heart:
unit
0m 45s
hbase-compression-snappy in the patch passed.

+1 :green_heart:
unit
1m 12s
hbase-compression-xz in the patch passed.

+1 :green_heart:
unit
6m  7s
hbase-compression-zstd in the patch passed.

280m 41s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5630/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5630

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b16e5cf26bd7 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 6b0ce08c82

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5630/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5630/3/testReport/

Max. process+thread count
5074 (vs. ulimit of 30000)

modules
C: hbase-annotations hbase-zookeeper hbase-server hbase-testing-util hbase-it hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5630/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 24s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 42s
master passed

+1 :green_heart:
compile
2m 22s
master passed

+1 :green_heart:
shadedjars
5m 38s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 47s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 24s
the patch passed

+1 :green_heart:
compile
2m 27s
the patch passed

+1 :green_heart:
javac
2m 27s
the patch passed

+1 :green_heart:
shadedjars
5m 29s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 47s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m  8s
hbase-annotations in the patch passed.

+1 :green_heart:
unit
0m 36s
hbase-zookeeper in the patch passed.

+1 :green_heart:
unit
236m  2s
hbase-server in the patch passed.

+1 :green_heart:
unit
2m 45s
hbase-testing-util in the patch passed.

+1 :green_heart:
unit
1m 14s
hbase-compression-aircompressor in the patch passed.

+1 :green_heart:
unit
0m 50s
hbase-compression-brotli in the patch passed.

+1 :green_heart:
unit
0m 41s
hbase-compression-lz4 in the patch passed.

+1 :green_heart:
unit
0m 44s
hbase-compression-snappy in the patch passed.

+1 :green_heart:
unit
1m 27s
hbase-compression-xz in the patch passed.

+1 :green_heart:
unit
6m 54s
hbase-compression-zstd in the patch passed.

282m  5s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5630/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5630

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 30cbfe6fb29f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 6b0ce08c82

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5630/3/testReport/

Max. process+thread count
5424 (vs. ulimit of 30000)

modules
C: hbase-annotations hbase-zookeeper hbase-server hbase-testing-util hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5630/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


rename 'JVM Memory Used' to 'Time spent in GC' in connect dashboard

Thanks for the PR @Courouge !


Suggestion: Event about Module Builded

What do you think if we add event for each layer about Module Builded
For example:
Each layer implement protocol ViperLayer
with func onModuleBuilded event
we call this after all layers is connected in build
this helps us with initalization for each layer when dependecies are connceted
For example:
in this event we can call presenter from interactor after init
P.S. Now if we override standard init we can't call presenter from interactor

Hi @EvsenevDev, I don't think that's a good idea, at least for viper. The only entry point for a module should be always its router. Any further action should be triggered by the router to the presenter, then from the presenter to the view/interactor, and so on.
But we could add more functions for the developer to override to simplify things. For now, we have these methods only:
    func setupView(data: Any)
    func viewHasLoaded()
    func viewIsAboutToAppear()
    func viewHasAppeared()
    func viewIsAboutToDisappear()
    func viewHasDisappeared()

We can sure think about what methods we'd need to make our life easier :-)


Test suite optimization / return 404 for catalog not found

This pull requests enables registry to execute its test suite faster. Previously, registry was creating and deleting records and indexing into elasticsearch for each test. With this pr, two transactions are executed.Tests time were reduced from ~ 2 min to ~ 1 min.
Also, the status code was modified for not existent catalogs when deleting from 200 to 404

Coverage remained the same at 99.63% when pulling 6883b2fcda06f7811a2b7b17a4b13c07fa26f013 on JorgeMartinezG:master into 73e092a1917e2032aa161c671f7a3a301f8e110b on boundlessgeo:master.

Coverage remained the same at 99.63% when pulling 6883b2fcda06f7811a2b7b17a4b13c07fa26f013 on JorgeMartinezG:master into 73e092a1917e2032aa161c671f7a3a301f8e110b on boundlessgeo:master.

Coverage remained the same at 99.63% when pulling b20cef0dad66ea116c66d3101b2ba29cc8df67d6 on JorgeMartinezG:master into 73e092a1917e2032aa161c671f7a3a301f8e110b on boundlessgeo:master.

Coverage remained the same at 99.63% when pulling b20cef0dad66ea116c66d3101b2ba29cc8df67d6 on JorgeMartinezG:master into 73e092a1917e2032aa161c671f7a3a301f8e110b on boundlessgeo:master.

Coverage remained the same at 99.63% when pulling d214f6d9794d4d52190b7c042c04b5336588e66a on JorgeMartinezG:master into 73e092a1917e2032aa161c671f7a3a301f8e110b on boundlessgeo:master.

Coverage remained the same at 99.63% when pulling 25dd4dd38a09d370b013a0c85bcd382fe30404e4 on JorgeMartinezG:master into 73e092a1917e2032aa161c671f7a3a301f8e110b on boundlessgeo:master.

Coverage remained the same at 99.63% when pulling 25dd4dd38a09d370b013a0c85bcd382fe30404e4 on JorgeMartinezG:master into 73e092a1917e2032aa161c671f7a3a301f8e110b on boundlessgeo:master.

Coverage remained the same at 99.63% when pulling 25dd4dd38a09d370b013a0c85bcd382fe30404e4 on JorgeMartinezG:master into 73e092a1917e2032aa161c671f7a3a301f8e110b on boundlessgeo:master.


Better ux for chatList

This are some visual hints for the chatlist to differentiate between sent messages, seen+received messages and not-seen+received messages

thank you!


Loop time

Hello, how can stop it the autoplay slide? or slide times settings..

Hi, yes, just set autoplay: false & animationDuration": 1000, animationInterval: 1200.
http://vinayakjadhav.github.io/jR3DCarousel/ when you visit this page , on left you can choose whatever settings you want & from right side you can get the generated code, simple.

Thanks. But i would like to stop after third loop. I create a google banner. It is necessary to stop after 30 seconds or third 3 loop.

Ohh okk.. got the issue you are facing.. Here try below code;
setTimeout( function(){console.log("Pausing after 7s"); myjR3DCarousel.pauseCarousel();}, 7000)
myjR3DCarousel is instance of your carousel.

Perfect. Thank you. 👍

You are welcome..


feat(kafka-broker): add consumer concurrency (experimental)

Codecov Report

Merging #38 (af68695) into master (0eeb2d8) will increase coverage by 0.03%.
The diff coverage is 87.17%.

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   84.07%   84.10%   +0.03%
==========================================
  Files          22       22
  Lines         339      365      +26
  Branches       52       58       +6
==========================================
+ Hits          285      307      +22
  Misses          3        3
- Partials       51       55       +4

Flag
Coverage Δ

express-api-key-auth
100.00% <ø> (ø)

geojson
∅ <ø> (∅)

kafka-broker
83.54% <87.17%> (+0.09%)
:arrow_up:

rest-client
83.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

packages/kafka-broker/src/types.ts
85.71% <ø> (ø)

packages/kafka-broker/src/Subscription.ts
82.02% <87.17%> (+1.07%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


PeoplePicker Control - Shows wrong value in Dynamic Form when null is provided

Category
[ ] Enhancement
[X] Bug
[X] Question
Version
3.11.0
Expected / Desired Behavior / Question
When a list item has a people field empty, when same listItemId is provided to Dynamic form, peoplepicker control should be empty.
Observed Behavior
Since Dynamic form uses people picker control for user fields and if a list item has a Person field which is empty, in Dynamic form when same list item id is provided, the people picker control is prepopulated with a person "Null, Melissa". This happens because, empty person field returns field value as null but the peoplepicker control converts null to "null" (string). Which then prepopulates the field with Null, Melissa.

Here you can see, even though in list its empty, but it shows up in Form.
Steps to Reproduce
Create a list item with People field as empty, then provide same ListItemId to dynamic form.
I feel this happens because the control converts everything that sharepoint returns to String, hence null becomes "null", because i tried giving null to defaultSelectedUser of peoplePicker field and it behaves correctly.
@AJIXuMuK, @wobba, @joelfmrodrigues Can anyone look into this.
Thanks.

From IM conversation: seems like the issue appears when user's name contains Null (as on the screenshot in the description).
@S1mpleLim3 - would you be able to implement a fix and create a PR?
Thanks!

@S1mpleLim3 I have created a PR for this.
//Nishkalank

The PR to fix this issue has been merged and the fix should be in the beta release in a few minutes

New release just published, closing


Export a hash for state of the world

One of the issues I've found through various service mesh technologies is it can be difficult to determine what the current state is for service discovery. Imagine the scenario where you are running multiple Rotor instances for availability purposes. A bug manifests itself in one of the plugins (i.e kubernetes), and let's say the state is now stale (oops we lost the watch and never recovered!). If you are trying to debug a complex service mesh, how would you know? I think it would be extremely valuable to export over the stats backends a deterministic hash of the state of the world. That way when you are monitoring your rotor instances, you can have the confidence that they are sharing the same information across instances to envoy.
My experience is that this is really missing in the service mesh world to help provide debugging when bugs manifest.

Hi @chrisgoffinet
we're actively working on adding some extra rotor-based stats to the stats backend, and we have a version hash derived from the underlying object state, so I think this is workable.

@chrisgoffinet I'd like to dig into this use-case a little more.  Since each of those rotors might have different internal state, getting them serving the same hash would be difficult.
If you're looking for an export of a hash of what the rotor itself is serving, that's a little simpler. This is basically what is handed out to the Envoys already for Ack/Nack.
When rotor is backed by the TL API, it serves multiple proxy configurations, and each of these has its own hash.

What rotor itself is serving. I currently have Rotor behind a service in Kubernetes. If i scale the replicas to 3 for availability purposes, I want to make sure those 3 replicas are serving the exact same state out to Envoy. The hash would become important here so that I have confidence there isn't a mismatch. I didn't need to try to compare states across Rotor + Consul, and Rotor + Kubernetes.

Got it. Should be doable.


Add travis_ci tests

this recipe may help:
https://github.com/korfuri/bazel-travis

@damienmg I don't think I can turn on travis-ci for the repo (I don't think I have rights). If you turn this on, I'll follow the above steps so we can keep the build green.

Added Travis to the organization and as a service to the repository. I still miss somethings, apparently getting to see the organization authorization in Travis take some time. I will retry later today.
Travis CI is definitely a better idea for PR, you don't need the complex setup needed for Bazel. Jenkins can helps us detect failures caused by Bazel (as well as mac and soon to be windows).
(yes sorry, we cannot give you more that write access to the repo per Google policy)


math basic tutorial

what kind of mathematics is needed in our field ans some examples of tasks?

In our field matrix, percent, area calculation are used quite often.
Example of matrix would be handling many Coordinate points and get specific point from there. Percent is used often on shop applications and area calculation is used in frontend coding to calculate wanted width/height for some element.
The mathematics in our field has lot of variety (really much) it depends what you are doing.


remove clickhouse.com from list

The domain clickhouse.com is associated with the Clickhouse Database: https://en.wikipedia.org/wiki/ClickHouse
This website contains documentation etc. and i had to add it to my explicit whitelist.
https://clickhouse.com/docs/en/intro
I think this should be removed.

Thank you for this Georg @D3luxee.
Unfortunately the file you edited is re-fetched from source each time we build a new release. This is all explained in the readme.
Please submit this request for change to<EMAIL_ADDRESS>the contact email for the MVPs hosts file list.
Closing.


kernel/sched: fix xcc complaining about ALWAYS_INLINE

The first complain of xcc about the use of ALWAYS_INLINE in scheduler:
kernel/sched.c:395: warning: C99 inline functions are not supported; using GNU89
kernel/sched.c:395: warning: to disable this warning use -fgnu89-inline or the gnu_inline function attribute
This is fixed by following xcc's suggestion of using the gnu_inline
function attribute, and re-defining ALWAYS_INLINE.
The second complain:
kernel/include/ksched.h:53: warning: ‘_find_first_thread_to_unpend’ declared inline after being called
kernel/include/ksched.h:53: warning: previous declaration of ‘_find_first_thread_to_unpend’ was here
This is due to the mismatched signatures between function prototypes
and their implementations. So fix by making them identical.
Signed-off-by: Daniel Leung<EMAIL_ADDRESS>

Throwing in the towel... this is more involved as I first thought... XCC is based on GCC 4.2 and the inline semantic is different than the GCC in SDK, which makes it difficult to reconcile the two.


[object_store - AmazonS3Builder] incorrect metadata_endpoint set in from_env in an ECS environment

AmazonS3Builder::from_env sets the metadata_endpoint with a postfix from the AWS_CONTAINER_CREDENTIALS_RELATIVE_URI env var (provided by the ECS environment):
https://github.com/apache/arrow-rs/blob/17ca4d51d0490f9c65f5adde144f677dbc8300e7/object_store/src/aws/mod.rs#L610
However, this line uses the static METADATA_ENDPOINT which is hard-coded to "http://<IP_ADDRESS>" .
This is incorrect according to AWS docs; the correct METADATA_ENDPOINT in this case should be "http://<IP_ADDRESS>". (see the docs)
I'd be happy to submit a PR for this once you confirm this is an issue.

That seems correct to me, would be happy to review a PR making the proposed change

label_issue.py automatically added labels {'object-store'} from #4288


Added --no-check-certificate to wget

Description of changes:
archive.ics.uci.edu's certificate has expired, added --no-check-certificate to be able to download the file
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Looks like they renewed their cert, so this change isn't needed anymore. Please reopen if you don't agree. Thanks for the contribution.


Replace suggestLoiTaskType with DataCollectionStrategy

Fixes #2097

This is now working, modulo:

[ ] https://github.com/google/ground-platform/issues/1349
[ ] https://github.com/google/ground-platform/issues/1213

Will mark Ready for review once those are fixed and/or out for review. @rfontanarosa FYI.

Codecov Report
Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (1912a28) 51.53% compared to head (f05e604) 51.46%.
 Consider uploading reports for the commit ff6e479 to get more accurate results

Files
Patch %
Lines

...nd/domain/usecases/submission/SubmitDataUseCase.kt
30.00%
6 Missing and 1 partial :warning:

...ersistence/remote/firebase/schema/TaskConverter.kt
0.00%
4 Missing :warning:

...in/java/com/google/android/ground/model/job/Job.kt
66.66%
2 Missing :warning:

...istence/remote/firebase/schema/TaskNestedObject.kt
0.00%
2 Missing :warning:

...persistence/remote/firebase/schema/JobConverter.kt
0.00%
1 Missing :warning:

...sistence/remote/firebase/schema/JobNestedObject.kt
0.00%
1 Missing :warning:

...i/datacollection/DataCollectionViewPagerAdapter.kt
0.00%
1 Missing :warning:

...ome/mapcontainer/HomeScreenMapContainerFragment.kt
0.00%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2108      +/-   ##
============================================
- Coverage     51.53%   51.46%   -0.07%
+ Complexity     1196     1195       -1
============================================
  Files           311      312       +1
  Lines          6056     6056
  Branches        634      629       -5
============================================
- Hits           3121     3117       -4
- Misses         2599     2608       +9
+ Partials        336      331       -5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@scolsen PTAL


Fix git integration

Git is working from the unit tests but not from the jobscheduler

exception in thread "Thread-1" org.eclipse.jgit.api.errors.InvalidRemoteException: Invalid remote: origin
	at org.eclipse.jgit.api.CloneCommand.call(CloneCommand.java:148)

Fixed by tim


Fix GPU-CI

-Remove non-tested acoustic for openacc
-CUDA drivers reinstalled and fixed
-print pgaccelinfo to logs
-Add DEVITO_LANGUAGE=openmp to offloading tests
-Added $err for traping errors

Closed as superseded by #1228.


dtype checking only mode[Feature Request]

Support for dtype checking alone would be useful.
e.g.
Dataset[int, str, str]

Hi @qiuwei,
Thank you for the suggestion.
What would be the use case for this? This library was developed with mainly Data Science use cases in mind, where you systematically give names to your columns anyway. Happy to hear your perspective.


Update test to take ASVS into account

When https://github.com/OWASP/Maturity-Models/pull/230 is merged there will be 3 projects, updated test to reflect this change.

@DinisCruz Would be nice if you could merge this, as this will make all tests pass in https://github.com/OWASP/Maturity-Models


Overwrite speaker in multi speaker model

Hi!
I am currently working with an English multi-speaker model that includes 29 speakers, all of which are female voices.
I would like to add a male voice to this model while keeping the remaining 28 female voices for future use.
I have already prepared a dataset for a single male voice.
Could anyone please guide me on how to overwrite one of the speaker embeddings with this new male voice?
Thank you for your assistance in advance!

Sure, you just need to add a speaker id to your dataset (probably 0 for the first speaker or 28 for the last), then fine-tune from the multi-speaker model.

Thank you for the response.
I understand how to add a new voice by assigning a speaker ID and fine-tuning. However, my concern is preserving the existing voices in a multi-speaker model without overlap.
Also, I agree with the approach in #333, where overwriting an existing speaker may be faster or more efficient than fine-tuning for a single new voice.
Is there any alternative to fine-tuning and overwriting a voice, or is this the only option?
Thank you for your help!

Is there any alternative to fine-tuning and overwriting a voice, or is this the only option?

Unfortunately, no unless there were extra speaker ids added in the original model that weren't used. The size of the model layers depends on the number of speakers, so you can't just extend it (at least I don't know how).

Nice, thanks @nshmyrev!

import torch
from torch import nn

from vits.lightning import VitsModel

model = VitsModel.load_from_checkpoint("../model/en_final/epoch=999-step=354000.ckpt", dataset=None)
model_g = model.model_g

with torch.no_grad():
    new_embedding = nn.Embedding(30, 512)
    nn.init.normal_(new_embedding.weight, 0.0, 512 ** -0.5)
    for i in range(29):
        new_embedding.weight[i] = model_g.emb_g.weight[torch.LongTensor([i])]
    new_embedding.weight[29] = new_speaker_embedding.weight[torch.LongTensor([0])]
    model_g.emb_g = new_embedding
    model_g.n_speakers = 30

state_dict = model_g.state_dict()

I added new speaker embeddings and performed inference as shown in the code above, but the voice sounded similar to that of speaker 0.

but the voice sounded similar to that of speaker 0.

Right, now you need to finetune the model on new speaker data, either just embedding or the full model.

Right, now you need to finetune the model on new speaker data, either just embedding or the full model.

Ahh right. I got it. It is how to extend speakers.
So, the only way to change voices is to update your training dataset and fine-tune the model.


direct pay failed payment showing as paid to sender

So as the send when the payment failed and we saw this error on the node KEYSEND ERROR: FAILURE_REASON_TIMEOUT
I'm thinking on the client side it's assuming it went through even though it could have failed
Sender view

This is what it looks like to everyone else
Receiver view

@kevkevinpal @mouawiahammo  I think this ticket should be moved to sphinx-relay repo. The client will think the pmt went through if relay return success to the sendMessage request. It has no other way to know about the pmt status.
Same happens with normal text messages. Relay is not waiting for the pmt to go through and it's returning to the app before that.
For the case of a tribe pmt it is even worse, because the relay of the sender will send the pmt to the tribe admin, and then the tribe admin will forward it to the pmt destination. It could fail from sender to admin, or from admin to destination and client will never know.

"reversal" payment (where a direct_payment or a boost fails to be forwarded by tribe admin) already sends a socket message here: https://github.com/stakwork/sphinx-relay/blob/master/src/utils/reversal.ts#L37
The type is either direct_payment or boost, and the response is the Message object with the errorMessage on it
@tomastiminskas

@Evanfeenstra along with the error_message, will the status of the message be "failed"?


Provider migration mechanism

Overview
The provider for operator resources can be changed only on resources which don't have a provider stored in their state.
The migration of previously created resources therefore currently necessitates a manual deletion of the resource prior to migration.
In order to simplify migration, a migration mechanism should be provided which takes this steps in the background without further user interaction.
Notes:

on KFP (and VAI) Pipelines can be deleted even if a RC exists. The Run will then fail at runtime

Process for simple resources without dependencies or dependants:

resource created with Provider p1
provider change requested to p2
the operator deletes the resource from p1
the operator continues with the resource like a newly created resource

Process for fixed dependencies (RC to Pipeline)

Option 1: as the lifecycle is meant to be tracked by the user we expect the RunConfiguration to be updated (it will fail until this is done due to the Pipeline being deleted from p1)
~Option 2: always check existence of Pipeline. Fail RC (and potentially delete from provider) if Pipeline doesn't exist or if providers don't match (unmanaged versions of pipelines in KFP no longer supported)~

Process for dependent resources:

Pipeline and RC created with Provider p1, RC tracks Pipeline

RC is changed first

provider change of RC requested to p2
the operator fails RC because the providers no longer match

The Pipeline is changed first

provider change of Pipeline requested to p2
the operator deletes the Pipeline from p1
the operator continues with the resource like a newly created resource
if providers match: RC will now get updated. RC will fail otherwise

Question: should we track deletions (in general)

Closing as not currently a priority.


Using ESP32 as PPPOE server possible?

Hi! I have come across your project after reading Wiznet W5500 pppoe docs...
I have an ESP32 and a W5500 lite module.
Is it possible to create a PPPOE server?
I know that this project is 8 years old but wondering if u can help me.

Technically perfectly possible.
But there might better Ethernet options for ESP32 than W5500:
eg something like this https://www.olimex.com/Products/IoT/ESP32/ESP32-GATEWAY/
Looking at RFC2516, it looks like you need to process these EtherTypes:

0x8863 (Discovery Stage)
0x8864 (PPP Session Stage)

But then you either need to implement PPPoE yourself or glue in an existing library.
And then I guess route the IP packets over normal Ethernet?
I did have some success with implementing PPP for IPv6:
https://github.com/njh/tinyppp6

But then you either need to implement PPPoE yourself or glue in an existing library.

the only library i could find that mentions pppoe is this.
but it says "PPPOE_SERVER is not yet supported under lwIP!" even if i see some server function (like pppoe_send_pado)...


Certificate errors on website

https://svelte-native.technology/
Currently getting the "connection not private" warning before the page loads in Chrome and Firefox.

Thanks, LetsEncrypt update got jammed. Restarted and should be all good.


reducer on client.query options does not appear to be fired

Using the withApollo HOC I'm doing a query per below (the documentation suggests it's possible http://dev.apollodata.com/core/apollo-client-api.html#ApolloClient.query)
this.props.client.query({
  query: doc,
  reducer: someReducer,
  variables: ...
});

I would expect someReducer to be fired with arguments however that does not appear to be the case; it is not fired at all.

<EMAIL_ADDRESS><EMAIL_ADDRESS>

➤ stale[bot] commented:
This issue has been automatically labled because it has not had recent activity. If you have not received a response from anyone, please mention the repository maintainer (most likely @jbaxleyiii). It will be closed if no further activity occurs. Thank you for your contributions to React Apollo!

➤ Jof Arnold commented:
Bumping to stop auto close.


Skeleton server

Set up skeleton-server: index.js, middlewares, routes and controllers. Missing authMiddleware and two functions for usersController

We like package-lock.json XXDD


fixed how authors show on post preview

fixes #9598
The handlebar being used for posts with a single author was using the author helper. This was causing an issue when previewing a post as it wasn’t showing any author info. I’ve changed this to use authors.

Hey @CriticalRespawn 👋 This was a bug in Ghost and not related to Casper, it was fixed in version 1.22.4


Update scripts/deploy_release.sh

Fix the deploy script to upload statically-linked binary to GitHub and crates.io.
To upload a new release, bump up the version first, and run:
make release

This change is ready for review. please check it out!


job #10046 updated dev vm instructions

Having a hard-coded BridgePoint version number is going cause this file to be changed with each new VM image. Might need to consider a better way to do this, like BP version in image name, a markdown preprocessor, or just put it in the commit message for the image.

Personally, I think it is not a big deal for this file to change with each VM image update. It is an infrequent task (maybe once a year) and the relative effort to change this file is small. Every time the VM is updated I think this file needs to be reviewed anyway to make sure that it is still accurate. Also, the name of the image must remain consistent since there is a link to it on the xtuml.org website. We could come up with something clever but I don't know that it would really be worth it.


AttributeError: module 'deepspeed' has no attribute 'init_inference'

Doing basic inference on a Windows Azure VM with CUDA. Not sure if this is a Windows issue (?)
Deepspeed version 0.3.16
This code below throws error...
ds_engine = deepspeed.init_inference(model,
mp_size=2,
dtype=torch.half,
checkpoint=None,
replace_method='auto')
The library is installed correctly, but using Intellisence in VSCode...you can't see the init_inference method. What is the issue?

I double checked this and this method is on the Linux version of the Python deepspeed package. So, the question is why is this inference not enabled on Windows?

Hi @bartczernicki
Thanks for mentioning this issue. Can I ask how you install deepspeed on Windows?
We have an instruction here under the installation section. Is this what you've tried?
Thanks,
Reza

Hi @bartczernicki - hopefully you were able to work past this, but if you're still having issues with this, could you make a new issue and link this one and we can take a look?  Thanks!

Did you guys find a solution yet?


Umbrella header now imports Foundation instead of UIKit.

OS X framework now actually works.

Coverage remained the same at 20.662% when pulling 0f1854c7dc7f00265246653ce0b38484bfd0a6ca on pfandrade:master into abb11c3679c00f72568b4c80374e0056be7e5406 on mattt:master.

Thank you, Paulo 👍