Generated DTOs shouldn't hide base class properties

I have a Swagger document that contains schemas that use allOf to include the base class schema (I used Swashbuckle.AspNetCore.Polymorphism):
  "allOf": [
    {
      "$ref": "#/definitions/<BaseClass>"
    },
    {
      "type": "object",
      "properties": {

While I cannot get a proper example right now, the base class properties are included in both the base class schema and the actual schema.
While Swagger UI handles duplicate properties just fine, NSwag does not. Using Poco for generated DTOs, this results in properties that hide the inherited properties, which causes the base class properties to be null. I tried using Record instead, but the generated constructor contains duplicate parameters, causing compilation errors.
I resolved my issue by filtering out the duplicate properties while generating the Swagger document, but I think NSwag could improve on this area as well. I'm not too familiar with the intricacies of Swagger so I don't know what would be most appropriate, but I suggest simply skipping properties declared in the base class.

I think/hope this is fixed with this PR: https://github.com/RSuter/NJsonSchema/pull/733

Update: Ready for retest in next nswag release (with updated NJS)


CloudBuild Trigger import

Steps to reproduce

Using all the variants provided on the Pulumi doc page for import a previous trigger created outside Pulimi project
Import CloudBuild Trigger

pulumi import gcp:cloudbuild/trigger:Trigger ad-qa-dev ad-qa-dev

Expected:
Code to import on my project
Actual:
Diagnostics:
pulumi:pulumi:Stack (bw-gcp-tscryp-cloudbuild-dev):
error: preview failed
gcp:cloudbuild:Trigger (ad-qa-dev):
error: gcp:cloudbuild/trigger:Trigger resource 'ad-qa-dev' has a problem: ExactlyOne: "filename": one of build,filename must be specified. Examine values at 'Trigger.Filename'.
error: gcp:cloudbuild/trigger:Trigger resource 'ad-qa-dev' has a problem: ExactlyOne: "pubsub_config": one of github,pubsub_config,trigger_template,webhook_config must be specified. Examine values at 'Trigger.PubsubConfig'.
error: gcp:cloudbuild/trigger:Trigger resource 'ad-qa-dev' has a problem: ExactlyOne: "github": one of github,pubsub_config,trigger_template,webhook_config must be specified. Examine values at 'Trigger.Github'.
error: gcp:cloudbuild/trigger:Trigger resource 'ad-qa-dev' has a problem: ExactlyOne: "webhook_config": one of github,pubsub_config,trigger_template,webhook_config must be specified. Examine values at 'Trigger.WebhookConfig'.
error: gcp:cloudbuild/trigger:Trigger resource 'ad-qa-dev' has a problem: ExactlyOne: "build": one of build,filename must be specified. Examine values at 'Trigger.Build'.
error: gcp:cloudbuild/trigger:Trigger resource 'ad-qa-dev' has a problem: ExactlyOne: "trigger_template": one of github,pubsub_config,trigger_template,webhook_config must be specified. Examine values at 'Trigger.TriggerTemplate'.
error: Preview failed: one or more inputs failed to validate

Sorry for the trouble. In some cases, the import command heuristics don't always work in determining the correct set of inputs. I'm curious if you're able to this resource programmatically via the resource option? https://www.pulumi.com/docs/guides/adopting/import/#pulumi-import-resource-operation

Using your suggestion also not work
let comp_vm_dev_calculo_aclme = new gcp.cloudbuild.Trigger("comp-vm-dev-calculo-aclme",{
    build: {
        steps: []
    },
    filename: ""
},
{ import: "28621667-5f12-4e67-827c-c7842ee0c1bc" }
);

Execution Pulumi Up
pulumi up
Previewing update (dev)

View Live: https://app.pulumi.com/WebMago/bw-gcp-tscryp-cloudbuild/dev/previews/119e52d6-d0c5-48d0-a41a-67b142c0d226

     Type                       Name                          Plan       Info
     pulumi:pulumi:Stack        bw-gcp-tscryp-cloudbuild-dev             1 error
 =   └─ gcp:cloudbuild:Trigger  comp-vm-dev-calculo-aclme     import     7 errors

Diagnostics:
  pulumi:pulumi:Stack (bw-gcp-tscryp-cloudbuild-dev):
    error: preview failed

  gcp:cloudbuild:Trigger (comp-vm-dev-calculo-aclme):
    error: gcp:cloudbuild/trigger:Trigger resource 'comp-vm-dev-calculo-aclme' has a problem: ExactlyOne: "filename": only one of `build,filename` can be specified, but `build,filename` were specified.. Examine values at 'Trigger.Filename'.
    error: gcp:cloudbuild/trigger:Trigger resource 'comp-vm-dev-calculo-aclme' has a problem: ExactlyOne: "github": one of `github,pubsub_config,trigger_template,webhook_config` must be specified. Examine values at 'Trigger.Github'.
    error: gcp:cloudbuild/trigger:Trigger resource 'comp-vm-dev-calculo-aclme' has a problem: ExactlyOne: "trigger_template": one of `github,pubsub_config,trigger_template,webhook_config` must be specified. Examine values at 'Trigger.TriggerTemplate'.
    error: gcp:cloudbuild/trigger:Trigger resource 'comp-vm-dev-calculo-aclme' has a problem: ExactlyOne: "pubsub_config": one of `github,pubsub_config,trigger_template,webhook_config` must be specified. Examine values at 'Trigger.PubsubConfig'.
    error: gcp:cloudbuild/trigger:Trigger resource 'comp-vm-dev-calculo-aclme' has a problem: ExactlyOne: "build": only one of `build,filename` can be specified, but `build,filename` were specified.. Examine values at 'Trigger.Build'.
    error: gcp:cloudbuild/trigger:Trigger resource 'comp-vm-dev-calculo-aclme' has a problem: ExactlyOne: "webhook_config": one of `github,pubsub_config,trigger_template,webhook_config` must be specified. Examine values at 'Trigger.WebhookConfig'.
    error: Preview failed: one or more inputs failed to validate

We've changed the way pulumi import works since this issue has been opened. Now you may get those warnings but we will proceed anyway, import the state, generate the code, and then you may need to adjust that code if necessary.
I've imported a trigger and it generated the following code snippet for me:
const test_deleteme = new gcp.cloudbuild.Trigger("test-deleteme", {
    build: {
        steps: [{
            args: [
                "echo",
                "hello world",
            ],
            name: "ubuntu",
        }],
        timeout: "",
    },
    name: "test-deleteme",
    project: "pulumi-development",
}, {
    protect: true,
});

I'll go ahead and close the issue. If you still have import blockers, please open a new issue with a repro.


Fix untyped typing checks

This PR adds -> None return types to all functions without (typed) parameters, to enable type checking by mypy. Also fixes occuring errors

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

119 of 119 (100.0%)  changed or added relevant lines in 15 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 90.539%

Files with Coverage Reduction
New Missed Lines
%

sed/binning/numba_bin.py
2
87.74%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
5627

Relevant Lines:
6215

💛  - Coveralls


Update readme.html

Plexguide link change to the new one PGblitz.com

Please can you update readme.md as well?
Also, I usually just generate the HTML version with a plugin for Sublime Text.

Yes I can do it.

add website learninglcom.com

sorry... i was busy .. now its finish . Readme and this onw updatet
thanks for share the links ;-)


Fix examine threading issues

It just kept goin

lgtm
I'd merge this but I'm afraid of my legs getting blown up


How to deal with user that do not have Facebook account but only Messenger account???

Hi,
I am trying to manage the case when a user do not have Facebook account but only Messenger account.
Is the gem able to detect this distinction and how can I handle it?
Is there a way to grab user information such as profile picture, first_name, last_name, etc....
Indeed, the classical API Graph request to get User Profile information does not wordk:
curl -X GET "https://graph.facebook.com/v2.6/<PSID>?fields=first_name,last_name,profile_pic&access_token=<PAGE_ACCESS_TOKEN>"

It answers with:
{
  "error": {
  "message": "(#100) No profile available for this user.",
  "type": "OAuthException",
  "code": 100,
  "error_subcode": 2018218,
  "fbtrace_id": "G2oz2QE++k1"
  }
}

thanks for your help
Guillaume

Hi @Guillaumejfrt! I haven't run into this before, but judging from the documentation it looks like you're out of luck.


Document/solve reasonfmt to the same file

Low pri for now and feel free to close, because this isn't reasonfmt's fault. I tried doing reasonfmt -parse re -print re test.re > test.re but because of how shell redirection works this erases test.re first before trying to read from it.
Kinda dangerous for newbs (ahem me), but also, I was wondering if the production ready version of reasonfmt shouldn't default to reasonfmt test.re to read as re, and write to the same file as re. That'll be used much more than outputting binary.

Done!


OpenGraph

Even if I set og_title or og_desc, it will not be reflected in X or Discord.
Is there any solution?

**Hi 👽 ! If you are interested in ⚙Advanced Phishing⚙ and the ✨Evilginx3✨ tool then I offer you Google Gmail and Custom Phishlets with a ✅Free Tutorial✅ which arrives if the 📈Telegram reaches 50 Subscribers📈
⏳ GOOGLE GMAIL PHISHLET 2024 WITH PROOF ⏳
->
⛔https://www.youtube.com/watch?v=nA47UknIE6A⛔
🔓 Ask your questions and a free tutorial from 50 subs on telegram !!!
->
📩https://t.me/Noremorse1011📩**


kinetic version breaks rqt_graph

command ran: rosrun rqt_graph rqt_graph
error:
 File "/opt/ros/kinetic/lib/python2.7/dist-packages/rqt_gui/ros_plugin_provider.py", line 83, in load     raise e ImportError: cannot import name QGraphicsPathItem
error originates from here:
File "/opt/ros/kinetic/lib/python2.7/dist-packages/qt_dotgraph/edge_item.py", line 32, in <module>     from python_qt_binding.QtGui import QBrush, QGraphicsPathItem, QGraphicsPolygonItem, QGraphicsSimpleTextItem, QPainterPath, QPen, QPolygonF ImportError: cannot import name QGraphicsPathItem

It seems like you are using an older version of qt_dotgraph. Version 0.3.2 imports that class from QWidgets: https://github.com/ros-visualization/qt_gui_core/blob/kinetic-devel/qt_dotgraph/src/qt_dotgraph/edge_item.py#L33

I am using the version that gets installed automatically from the kinetic binaries, so perhaps the repository binaries need to be changed to reflect this?

Please state the exact version number of  qt_dotgraph as well as rqt_graph you are using.

@harvcode The versions available from binary have changed recently. That's why we need to confirm the version on your system.

ros-kinetic-qt-dotgraph/xenial,now 0.3.2-0xenial-20160428-192006-0700 amd64
ros-kinetic-rqt-graph/xenial,now 0.4.0-1xenial-20160429-165937-0700 amd64

The code in the error message in your original comment (edge_item.py, line 32) does not match the code available in these versions.
Version 0.3.0 has the line you quoted above: https://github.com/ros-visualization/qt_gui_core/blob/0.3.0/qt_dotgraph/src/qt_dotgraph/edge_item.py#L32
Version 0.3.1 as well as 0.3.2 have this instead which should work:

https://github.com/ros-visualization/qt_gui_core/blob/0.3.1/qt_dotgraph/src/qt_dotgraph/edge_item.py#L32
https://github.com/ros-visualization/qt_gui_core/blob/0.3.2/qt_dotgraph/src/qt_dotgraph/edge_item.py#L32

Just tried it again and I still get "ImportError: cannot import name QFormLayout".
Apt says I am up to date on both of those packages and lists those versions.

Since the error is different then what you reported above please post the complete error message and steps you did to reproduce.

From command line: rqt
From menu: Plugins > Robot Tools > Controller Manager
Error appears in console.

Please post the full error message.

`
PluginManager._load_plugin() could not load plugin "rqt_controller_manager/ControllerManager":
Traceback (most recent call last):
File "/opt/ros/kinetic/lib/python2.7/dist-packages/qt_gui/plugin_handler.py", line 99, in load
self._load()
File "/opt/ros/kinetic/lib/python2.7/dist-packages/qt_gui/plugin_handler_direct.py", line 54, in _load
self._plugin = self._plugin_provider.load(self._instance_id.plugin_id, self._context)
File "/opt/ros/kinetic/lib/python2.7/dist-packages/qt_gui/composite_plugin_provider.py", line 71, in load
instance = plugin_provider.load(plugin_id, plugin_context)
File "/opt/ros/kinetic/lib/python2.7/dist-packages/qt_gui/composite_plugin_provider.py", line 71, in load
instance = plugin_provider.load(plugin_id, plugin_context)
File "/opt/ros/kinetic/lib/python2.7/dist-packages/rqt_gui_py/ros_py_plugin_provider.py", line 60, in load
return super(RosPyPluginProvider, self).load(plugin_id, plugin_context)
File "/opt/ros/kinetic/lib/python2.7/dist-packages/qt_gui/composite_plugin_provider.py", line 71, in load
instance = plugin_provider.load(plugin_id, plugin_context)
File "/opt/ros/kinetic/lib/python2.7/dist-packages/rqt_gui/ros_plugin_provider.py", line 83, in load
raise e
ImportError: cannot import name QFormLayout
RosPluginProvider.load(rqt_controller_manager/ControllerManager) exception raised in builtin.import(rqt_controller_manager.controller_manager, [ControllerManager]):
Traceback (most recent call last):
File "/opt/ros/kinetic/lib/python2.7/dist-packages/rqt_gui/ros_plugin_provider.py", line 77, in load
module = builtin.import(attributes['module_name'], fromlist=[attributes['class_from_class_type']], level=0)
File "/root/catkin_ws/src/ros_control/rqt_controller_manager/src/rqt_controller_manager/controller_manager.py", line 35, in
from python_qt_binding.QtGui import QCursor, QFont, QFormLayout, QHeaderView,
ImportError: cannot import name QFormLayout`

The stack trace indicates that the problem is in the package rqt_controller_manager which is in your local workspace (I assume it hasn't been released into Kinetic yet?). You might want to fill a ticket in the repository which contains that package: https://github.com/ros-controls/ros_control/issues


[Serverless] Add region, projectID and containerID tags

What does this PR do?
Ad region + projectID + containerID tags to logs/metrics/traces for CloudRun
Don't tag containerID for metrics (cardinality)
Add tests
Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the config template has been updated.

Would it make sense to mark cmd/serverless-init as owned by the serverless team?

Definitely! I'll add this to this PR


195 upload file validation

@hyi Please review this code.

I have reviewed the code and the code looks good to me. I am switching the assignee from myself to @mjstealey since Michael is in charge of merging pull request.

As Pabitra suggested, I am copying our email exchange here for later reference:
From Hong:
Your code all looks good to me. The only comment I have is whether you have tried “accept” attribute on the html file browser to only show those files with those extensions set up in “accept” attribute when browsing files. This accept attribute may not work across all web browsers, though. The JavaScript code you wrote to check for extensions and alert users when not matching certainly will work as well.
Reply from Pabitra:
It seems it is not easy to get the file type ‘accept’ attribute set correctly. Sometimes you have to set it to mime type for certain file types and in other cases just the file extension. On top of that there is no certainty that will work with all the popular browsers.
I was looking at this  stackoverflow thread (http://stackoverflow.com/questions/11832930/html-input-file-accept-attribute-file-type-csv) and tried to see if I set accept=”.csv” as it suggests for csv file, the file open dialog did not do the filtering for me. I was still able to select any file type.
However, if we use a third-party file upload JS component we may be able to achieve this. I will probably leave that for Mauriel for a later iteration of this functionality.


Add PHP and Apache Visual C++ dependency

Apache and PHP both depend on having Visual C++ 2014 installed, so this dependency is added to those manifests, along with a manifest for Visual C++ 2014 itself.
Also includes a minor change to the hashes for Apache, to explicitly label it as sha256 for verbosity and future-proofing.
Note that the Visual C++ manifest makes use of functionality added in #754 (specifically, the keep flag), but the manifest will still work even if that pull request is not merged, since the added functionality will simply be ignored.

As far as I know, people have been able to install PHP and Apache fine so far—maybe they have the VC redist already installed? I'm concerned that adding this as a dependency may prevent people from installing/updating PHP and Apache, because scoop will try to install the VC redist that's already installed.
So:
Can you confirm that this will work if VC redist is already installed?

I can confirm that both Apache and PHP work when the Visual C++ Redistributable is already installed. Of course, scoop also installs its own version; however, since the installer runs in quiet mode, it appears to either silently fail or silently overwrite the existing installation. Either way, both programs function as expected, and it means that the dependency will get installed when people who don't have it (like me, running on an essentially fresh Windows VM) attempt to install the apps that need it.

Okay. It's a bit of a bummer that these 2 apps now pop up elevation prompts because of the installer where they didn't before. But if we get negative feedback from the PHP/Apache users we can address that.
To follow naming conventions and make it a bit clearer that this isn't visualc, do you mind renaming visual-c-14.json to vcredist14?

Would you mind if it's vc-redist-14? I prefer some spacing so someone (or more likely, me after a long night) doesn't read it as "VCR edist" and wonder what the heck it is. I'm fine with it either way, but my vote would be for having the dashes.

Yeah, we usually only use dashes if it's a variant on an app, and never for versions. So I'll have to be a pedant and insist that it's vcredist14, sorry!

Wait, I would accept vc-redist14.

That works perfectly for me. I've added the changes to the pull request.

Thanks :smile:

In relation to the comment about requiring administrator access, the main thing that bugs me is that the prompt tends to come up in the background. The ideal situation would be for it to come up in the foreground, but I'm not familiar enough with PowerShell to know if there's an easy way to do that.
If there's not a way of coercing start-process into prompting in the foreground, could a sudo flag be added to the manifest under the installer directive? The flag would simply run sudo start-process ... if true. It means every app that needs administrator rights to install would need sudo as a dependency, but, from the few quick experiments I've done, it would at least trigger the prompt in the foreground rather than have it sit in the task bar until I notice it.

There's no way to control where the elevation prompt pops up, as far as I know. Even if we did sudo start-process ..., that would require an elevation prompt for sudo.
In testing these changes, the prompts did come up in the foreground for me. When I was working on sudo, I think the system would get into a state where all the prompts would start showing up without focus, but then it would kick back to foreground again (maybe after restarting powershell or the OS). So it might not be too much to worry about.
Even if it doesn't go away, I can't see much way around it besides trying as much as possible to do things that require elevation.

I may have found a slightly better solution that fits scoop's "self-contained" ideology a little better. I located the DLLs installed by the installers, and uploaded them to my scoop-experimental repo. From there, they can be directly downloaded and included in the app's folder as an additional url in the manifest, eliminating the administrator prompt altogether.
This solves the administrator-prompt issue, but means that the dependency is no longer shared. I'm assuming this is the preferred way of doing it, so should I make a pull request for this?

That's great! Yes, please make a PR.


Only keep the most recent build log

With this commit we continously override a potentially existing
Elasticsearch build log. Keeping a history of build logs is not
necessary as it is only relevant to investigate on failures. Thus a
history only adds complexity (e.g. log rotation setup) for little value.
Relates #818

Thanks for the review! :)


Integration test for multiple OS

Description
Integration tests for multiple OS - including windows, macos and fixes https://github.com/Azure/draft/issues/211
Fixes # (issue)
Feature # (details)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a  breaking change which will impact consuming tool(s).

[x] Test A
[x] Test B

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Oh, ☕💡 The merge is blocked because commits require signing https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification
cc: @hsubramanianaks

Oh, ☕💡 The merge is blocked because commits require signing https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification
cc: @hsubramanianaks thanks heaps and fyi - @davidgamero thanks.

Done updated to signed commits :)


Possibly enable a way to prioritize substrings over fuzzy matching

for example:

I would expect the 21 to be highlighted in 2021-7-21.md not the 2 and then the 1 at the end.

Hey, I would like to assist on this issue, can someone point me at the code lines to get started?

I've added "quotes" support in #131292 and am planning on it releasing in stable as "experimental".
Now in the file picker cmd+p or ctrl+p you can wrap a word in quotes and it will search in a non-fuzzy way.
However, I want to experiment with another way to do this next iteration.


Type casting on an unit256 array

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[ ] Foundryup

What version of Foundry are you on?
forge 0.1.0 (77882ab 2022-03-22T00:12:56.848059114+00:00)
What command(s) is the bug in?
forge build
Operating System
Linux
Describe the bug
Breaks
    function testBatchCall() public {
        // arrange
        uint256[2] memory values = [0, 0];
    }

Seems to try optimise and cast 0 to a unit8
Works
    function testBatchCall() public {
        // arrange
        uint256[2] memory values = [uint256(0), uint256(0)];
    }

This has nothing to do with foundry; It's a "feature" of solidity. You can put the following code in Remix:
pragma solidity 0.8.10;
contract Test {
    function testBatchCall() public {
        uint256[2] memory values = [0, 0];
    }
}

and it won't compile.

As mentioned above, not a Foundry bug :)

@onbjerg oops!  Sorry for that and the tip!


Error module 'pandas.core.computation' has no attribute 'expressions' when import malaya

I got this error AttributeError: module 'pandas.core.computation' has no attribute 'expressions' when import malaya in my code.
Version :
Pandas 0.23.4
Malaya <IP_ADDRESS>
How to fix this issue?
Machine specs : https://imgur.com/a/PgaE4kD

I guess this is Dask issue, solved when following this issue.


Python3 part2

Pull Request Description
What issue does this change request address?
#71
What are the significant changes in functionality due to this change request?
Improves Python 3 support.

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[ ] 1. Review all computer code.
[ ] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[ ] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[ ] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[ ] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True.
[ ] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[ ] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[ ] 8. If an analytic test is changed/added is the the analytic documentation updated/added?

This is a work in progress that I am using to check that I haven't broken Python 2 compatibility.

Job Test Fedora 27 on 3d71c5c : invalidated by @joshua-cogliati-inl

Note: Do not squash and merge (we need to keep the parallel python original and changes separate.

Note: This probably should not be squashed, since that would lose some of the information in which commits go with with comment.

This is ready to check.  I recommend not squashing the merge.

Job Test mac on 7891791 : invalidated by @alfoa

Approved...


Approval needed: Server information

Title of ticket:
Description
Approval of WALTZ server
Dependencies
Are there any dependencies?
DOD

[ ] Determine name
[ ] Matt to get approval from Kris
[ ]
[ ]
[ ]

this is done


Hotstar extractor give error

$ youtube-dl -F https://www.hotstar.com/in/movies/junglee/1000235906/watch?utm_source=gwa
[hotstar]<PHONE_NUMBER>: Downloading webpage
ERROR: Unable to download webpage: <urlopen error [Errno 104] Connection reset by peer> (caused by URLError(ConnectionResetError(104, 'Connection reset by peer')))

Network issue on your side.


Fix jumping composer when entering emojis or markdown text

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/39267
PROPOSAL:
Tests

Go to staging.new.expensify.com/
2 .Go to any chat
Enter an emoji and verify composer layout
Verify the same when entering other markdown text, pasting text or when expanding composer

[X] Verify that no errors appear in the JS console

Offline tests

Same as tests
QA Steps

Same as tests

[X] Verify that no errors appear in the JS console

PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android: Native
[X] Android: mWeb Chrome
[X] iOS: Native
[X] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[X] MacOS: Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[X] I verified that all the inputs inside a form are aligned with each other.
[X] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/39538890/4cdaba3c-13b1-47a8-9be8-14cd731c8e19

MacOS: Desktop

https://github.com/Expensify/App/assets/39538890/d1639f78-a309-4132-a295-47e122aa4c4d

@fedirjh thanks for the review. This PR is changing only Composer component for web. Both of the bugs you found are also present on main.

Bug : Emoji is cropped on the top ...

This one is already reported, https://github.com/Expensify/App/issues/15734

... Emoji is displayed as large when the comment includes only emojis.

This is a feature that was implemented in https://github.com/Expensify/App/pull/39597

@fedirjh bump

@fedirjh The problem with composer padding was fixed. Also, I removed some height calculations that were based on number of lines, since every line can have different lineHeight

It looks like the emojis are cut off just slightly at the top?

It looks like the emojis are cut off just slightly at the top?

@shawnborton I can't reproduce it, emojis seems to have correct size. However the issue with cutting off emojis at the top is known and reported here

Ah looks like we have some conflicts to resolve now

I resolved the conflicts

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.4.67-7 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.4.67-7 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.68-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


White Screen when accessing /mod/view/1

Hosting using XAMPP, using latest solder version. Happens when managing mods!

We do not support windows installs in any way.

Allocate more ram in php.ini.


IE11 fires an input event when an input with placeholder is focused

I'd suggest putting this under "bugs" instead. Numbered notes is more for explaining missing/partial support. In fact, you can probably just copy the second bug on the placeholder entry which lists the same thing.

In fact, you can probably just copy the second bug on the placeholder entry which lists the same thing.

Why list the same bug twice? Even the link is the same.

@cvrebert This one would be for the "input" event, the other for the placeholder one. The bug applies to both, so it would be useful to include it in both places.

Ah. Derp.

Went ahead and implemented my suggestion manually, so closing.


solve n+1 via batch/unbatch function

option 1:
query planner detects n+1 problem and rewrites query plan to do the batch requests automatically
option 2:
data source could implement batching itself and batch requests implicitly within a configured time window

Hi @jensneuse qq: what if the same type appear on different layers, will the typer fetcher get batched?


Added BlockService.

Adds a Service class for Blocks and the Block model class, along with a small test class.
Works similar to the other services.

+5 Thank you for your contribution. Do you want to add some other changes/ tasks - that are still open. PM me @chris on slack. @chbta

@chbta can you give me your ARK Address ( you can also contact me on Slack) ?


Terrain dissappears if it's being dropped on itself

When a terrain is being dragged and then dropped at the position at which it's already at, the terrain will disappear until it's being deselected with a mouse click.
https://user-images.githubusercontent.com/1705157/119090820-61e98580-ba0c-11eb-8665-ca7761a2df22.mp4

That was really weird.
Should be fixed with the latest version.
Also thanks for the video, that was really helpful to see what was happening.


Solving the Missing plugin Exception by using package image_picker instead of the current channels

The current channels cause expectation:
Missing plugin Exception #3
I added a dependency to package image_picker and solved the issue.
I test it on Android and IOS

@bizz84 Cloud you please review it and merge it to the master.


THORN-2122: add a HowTo for metrics with MP Metrics and Prometheus

[x] Have you followed the guidelines in our Contributing document?
[x] [v2] Have you created a JIRA and used it in the commit message?
[ ] [v4] Have you created a GitHub Issue and used it in the commit message?
[x] Have you checked to ensure there aren't other open Pull Requests for the same issue?
[ ] Have you built the project locally prior to submission with mvn clean install?

CC @tradej @jclingan

Good point @kenfinnigan!

Fixed.

I've merged @tradej's PR, so the changes are now present in this PR.

Rebased to resolve conflicts.


Cannot install on Ubuntu 16.10 (Yakkety - not released) from repo

The following packages have unmet dependencies:
 clickhouse-client : Depends: libc6 (< 2.24) but 2.24-0ubuntu1 is to be installed
 clickhouse-server-common : Depends: clickhouse-server-base (= 1.1.54022) but it is not going to be installed
E: Unable to correct problems, you have held broken packages.

I understand that Yakkety is not released, but will be soon.

Yes, we currently have no automatic builds on 16.10.
By the way, there are two possibilities for us:

add 16.10 to auto-builds;
to experiment further with GLIBC_COMPATIBILITY build option (it removed dependency of specific version of libc): maybe we should enable it by default.

And you could either:

build on 16.10;
build on any other Ubuntu version with GLIBC_COMPATIBILITY option enabled and install anywhere.

Just a side note : If GLIBC_COMPATIBILITY is changed to be the default, I hope it can still be disabled, since it makes the build fail for me on RHEL7 with glibc 2.17 and gcc 6.2.1 (it builds fine without) :
[mockbuild@r2d2 build]$ make
[  0%] Built target cityhash
[  1%] Built target lz4
[  2%] Built target double-conversion
[  2%] Built target zstd
[  2%] Built target farmhash
[  2%] Built target metrohash
[ 18%] Built target PocoFoundation
[ 24%] Built target PocoXML
[ 25%] Built target PocoJSON
[ 33%] Built target PocoNet
[ 35%] Built target PocoMongoDB
[ 37%] Built target PocoUtil
[ 38%] Built target PocoCrypto
[ 41%] Built target PocoNetSSL
[ 44%] Built target PocoData
[ 44%] Building C object contrib/libpoco/Data/SQLite/CMakeFiles/PocoDataSQLite.dir/src/sqlite3.c.o
/builddir/build/BUILD/ClickHouse-1.1.54022-stable/contrib/libpoco/Data/SQLite/src/sqlite3.c:26418:42: error: 'mremap' undeclared here (not in a function)
   { "mremap",       (sqlite3_syscall_ptr)mremap,          0 },
                                          ^~~~~~
/builddir/build/BUILD/ClickHouse-1.1.54022-stable/contrib/libpoco/Data/SQLite/src/sqlite3.c: In function 'unixRemapfile':
/builddir/build/BUILD/ClickHouse-1.1.54022-stable/contrib/libpoco/Data/SQLite/src/sqlite3.c:30750:42: error: 'MREMAP_MAYMOVE' undeclared (first use in this function)
     pNew = osMremap(pOrig, nReuse, nNew, MREMAP_MAYMOVE);
                                          ^~~~~~~~~~~~~~
/builddir/build/BUILD/ClickHouse-1.1.54022-stable/contrib/libpoco/Data/SQLite/src/sqlite3.c:30750:42: note: each undeclared identifier is reported only once for each function it appears in
/builddir/build/BUILD/ClickHouse-1.1.54022-stable/contrib/libpoco/Data/SQLite/src/sqlite3.c:30750:42: error: passing argument 4 of '(void * (*)(void *, size_t,  size_t,  int))aSyscall[23].pCurrent' makes integer from pointer without a cast [-Werror=int-conversion]
/builddir/build/BUILD/ClickHouse-1.1.54022-stable/contrib/libpoco/Data/SQLite/src/sqlite3.c:30750:42: note: expected 'int' but argument is of type 'struct unix_syscall *'
cc1: all warnings being treated as errors
make[2]: *** [contrib/libpoco/Data/SQLite/CMakeFiles/PocoDataSQLite.dir/src/sqlite3.c.o] Error 1
make[1]: *** [contrib/libpoco/Data/SQLite/CMakeFiles/PocoDataSQLite.dir/all] Error 2
make: *** [all] Error 2

Thanks, I will remove SQLite from build. It is not used, and it is just an optional part of Poco/Data library.
(Probably it could be used as source for external dictionaries, if we will have request for it.)

Hello,
any update on it?
Same problem on 17.04 :)

We have no builds fot 17.04
But you can build manually as described here:
https://github.com/yandex/ClickHouse/blob/master/doc/build_debian.sh
Or make package by running this script (dont forget install all depends):
https://github.com/yandex/ClickHouse/blob/master/release


GROOVY-7813: Calling a non-static outer class method from a static cl…

…ass should fail STC

This fix is incorrect, closing for now.


[Feature] Retry on specific request methods

I want to specify on which request methods (GET, PUT, POST, etc.) the retry should happen.

See: https://github.com/rodion-m/dio_smart_retry/issues/19#issuecomment-1364720607


Include existing macros

[ ] Obligation macro
[ ] Random cantina NPC macro

Here are my copies of the macros:

https://pastebin.com/9VLZKd9p
https://pastebin.com/hwnPmtcp
https://pastebin.com/jjiyrLFu
https://pastebin.com/pyqtnWxE
https://pastebin.com/pszYNuTT

[ ] Obligation
[ ] Random cantina NPC
[ ] Critical - https://pastebin.com/9VLZKd9p
[ ] Boost/Setback to Actor - https://pastebin.com/hwnPmtcp
[ ] Boost to next combat slot - https://pastebin.com/jjiyrLFu
[ ] Configure Encounter - https://pastebin.com/pyqtnWxE
[ ] Configure Tokens with Consistent Displays - https://pastebin.com/pszYNuTT

Perhaps also https://github.com/StarWarsFoundryVTT/StarWarsFFG/wiki/helpful-macros#set-the-token-default-status-bars

done


BUG: list_match crashes when an RSS entry contains two years

Expected behaviour:
When in a RSS task parse an entry of a movie uses imdb_lookup if found an coincidence from
list_match add task to transmissionrcp
It's work with different RSS providers with same config.
Actual behaviour:

When one entry of RSS contains two year list_match and imdb_lookup plugins make flexget crashes.

RSS have a format like this:
[MicroHD] Some title (estreno 2018)(2016/MHD/1080P/AC3 5.1/DUAL/SUB) [SEEDERS (29)/LEECHERS (2)]

It's fail with internal and guessit parser. If title only contain one year it's work ok with guessit parser. If contains two years fail.

Steps to reproduce:

Step 1: Create task including an RSS source with two years in the title

Config:
web_server:
  run_v2: true

templates:
  global:
    torrent_alive: no #number of seeders needed to accept

  transmit-movies:
    transmission:
      host: 192.X.X.X
      port: 9091
      username: admin
      password: password
      path: /var/lib/transmission-daemon/downloads/movies
    metainfo_movie: yes
    set:
      rename_like_files: yes
      content_filename: "{{ movie_name }} ({{ movie_year }})"

schedules:
  - tasks: '*'
    interval:
      minutes: 10

  mov_xbytes task:
    priority: 3
    rss: http://domain.com/advanced_rss.php?cats=16&tpc=5&auth=AUTH-PERSONAL-CODE
    parsing:
      movie: guessit
    imdb_lookup: yes
    list_match:
      from:
        - movie_list: movies
      action: accept
    template: transmit-movies

Log:

(click to expand)
2018-11-10 13:01 DEBUG    manager                       Config file /config/config.yml selected
2018-11-10 13:02 INFO     scheduler                     Starting scheduler
2018-11-10 13:02 INFO     web_server_daemon                 Running web server at IP <IP_ADDRESS>:5050
2018-11-10 13:02 INFO     web_server_daemon                 Initiating API
2018-11-10 13:02 INFO     web_server_daemon                 Registering WebUI v2
2018-11-10 13:02 INFO     web_server_daemon                 Registering WebUI v1
2018-11-10 13:02 INFO     web_server                    Web interface available at http://<IP_ADDRESS>:5050
2018-11-10 13:03 WARNING  imdb_lookup   mov_xbytes task IMDB lookup failed for [MicroHD] Persecucion al limite (estreno 2018)(2016/MHD/1080P/AC3 5.1/DUAL/SUB) [SEEDERS (29)/LEECHERS (2)]
2018-11-10 13:03 INFO     imdb_lookup   mov_xbytes task Title `[microhd] persecucion al limite (estreno 2018)(2016/mhd/1080p/ac3 5.1/dual/sub) [seeders (29)/leechers (2)]` lookup failed
2018-11-10 13:03 CRITICAL task          mov_xbytes task BUG: Unhandled error in plugin list_match: (sqlite3.InterfaceError) Error binding parameter 2 - probably unsupported type. [SQL: u'SELECT movie_list_movies.id AS movie_list_movies_id, movie_list_movies.added AS movie_list_movies_added, movie_list_movies.title AS movie_list_movies_title, movie_list_movies.year AS movie_list_movies_year, movie_list_movies.list_id AS movie_list_movies_list_id \nFROM movie_list_movies \nWHERE ? = movie_list_movies.list_id AND lower(movie_list_movies.title) = ? AND movie_list_movies.year = ?\n LIMIT ? OFFSET ?'] [parameters: (3, u'persecucion al limite', [2018, 2016], 1, 0)] (Background on this error at: http://sqlalche.me/e/rvf5)
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/flexget/task.py", line 486, in __run_plugin
    return method(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/flexget/event.py", line 23, in __call__
    return self.func(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/flexget/plugins/filter/list_match.py", line 41, in on_task_filter
    result = thelist.get(entry)
  File "/usr/lib/python2.7/site-packages/flexget/utils/database.py", line 34, in wrapper
    return func(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/flexget/plugins/list/movie_list.py", line 228, in get
    match = self._find_entry(entry=entry, session=session)
  File "/usr/lib/python2.7/site-packages/flexget/utils/database.py", line 31, in wrapper
    return func(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/flexget/plugins/list/movie_list.py", line 202, in _find_entry
    .filter(MovieListMovie.year == year).first())
  File "/usr/lib/python2.7/site-packages/sqlalchemy/orm/query.py", line 2789, in first
    ret = list(self[0:1])
  File "/usr/lib/python2.7/site-packages/sqlalchemy/orm/query.py", line 2581, in __getitem__
    return list(res)
  File "/usr/lib/python2.7/site-packages/sqlalchemy/orm/query.py", line 2889, in __iter__
    return self._execute_and_instances(context)
  File "/usr/lib/python2.7/site-packages/sqlalchemy/orm/query.py", line 2912, in _execute_and_instances
    result = conn.execute(querycontext.statement, self._params)
  File "/usr/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 948, in execute
    return meth(self, multiparams, params)
  File "/usr/lib/python2.7/site-packages/sqlalchemy/sql/elements.py", line 269, in _execute_on_connection
    return connection._execute_clauseelement(self, multiparams, params)
  File "/usr/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 1060, in _execute_clauseelement
    compiled_sql, distilled_params
  File "/usr/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 1200, in _execute_context
    context)
  File "/usr/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 1413, in _handle_dbapi_exception
    exc_info
  File "/usr/lib/python2.7/site-packages/sqlalchemy/util/compat.py", line 203, in raise_from_cause
    reraise(type(exception), exception, tb=exc_tb, cause=cause)
  File "/usr/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 1193, in _execute_context
    context)
  File "/usr/lib/python2.7/site-packages/sqlalchemy/engine/default.py", line 507, in do_execute
    cursor.execute(statement, parameters)
InterfaceError: (sqlite3.InterfaceError) Error binding parameter 2 - probably unsupported type. [SQL: u'SELECT movie_list_movies.id AS movie_list_movies_id, movie_list_movies.added AS movie_list_movies_added, movie_list_movies.title AS movie_list_movies_title, movie_list_movies.year AS movie_list_movies_year, movie_list_movies.list_id AS movie_list_movies_list_id \nFROM movie_list_movies \nWHERE ? = movie_list_movies.list_id AND lower(movie_list_movies.title) = ? AND movie_list_movies.year = ?\n LIMIT ? OFFSET ?'] [parameters: (3, u'persecucion al limite', [2018, 2016], 1, 0)] (Background on this error at: http://sqlalche.me/e/rvf5)

Additional information:

FlexGet version: 2.17.9
Python version: 2.7
Installation method: pip
Using daemon (yes/no): yes
OS and version: Linux Alpine 3.8
Link to crash log:

This smells more like a Guessit parser problem. The parser spits out two years in a list and no plugin expects that.


SocketCluster + LiveQuery

Hi ,
Currently i am working on adding real time chat capabilities to my app. The requirement is that users will be able to chat with each other in real time and also see the chat history. At the beginning i was thinking about Firebase which provide "real time database" that do exactly this but i have 2 issues with it:

It require Firebase user (because i really don't want to use anonymous)
It's stored on a different DB which not under my control and in the future it can make life really hard. (e.g. changing tech stack, replication etc.)

Since i am a big fan of parse-server and NodeJS technologies I was looking for some NodeJS real time messaging server and  then i found SocketCluster which seems to be very powerful especially for solutions which require high performance & easy scale
My current solution is based on LiveQuery which is very close to what i want because you can implement "Real time database" capabilities easily with LiveQuery since all events are emitted after one or more objects were saved in the database. The problem is the other part of Real time messaging: User Presence (when user is online/offline), user is typing , message was read by the user etc.
I tried to implement all of that with LiveQuery but it is not simple at all and require a lot of DB work in order to make this work (since LiveQuery raise the events only after objects has been saved)
So I was thinking maybe we can leverage SocketCluster capabilities and use them in parse-server and maybe (but only maybe) SocketCluster can replace the WebSocket layer of Parse LiveQuery which currently use only the official WebSocket npm module under the hood.

SocketCluster uses uws instead of ws. What would be the benefit of depending upon SocketCluster?

Hi @flovilmart
uws is only one of the advantage (BTW. you can use also ws there if you want..)
Other advantages are:
From their website

Vertical scaling (more CPU cores and more workers) and Horizontal scaling (more hosts)
Support both pub/sub channel and direct communications
Sockets automatically reconnect in case of failure
Optimized to run and autoscale on Kubernetes (Good for us and to all other users who use k8s)
High Performance (http://socketcluster.io/#!/performance)

From what i have tested

Client libraries for most of the languages (both client and server technologies)
Easy to use and integrate
Allow users to subscribe and publish to channels (without being dependant on Database commit) so it's very good for real time scenarios
I managed to deploy it to k8s and run it in HTTPS very fast ( if we will decide to use it we can provide a user guide for parse-server users)

What i am thinking is one of the following:

Replace the current websocket layer of LiveQuery to use SocketCluster
Create adapter that will allow users to use SocketCluster instead of the current solution
Integrate it in cloud code (afterSave and afterDelete) so each time object is being saved or deleted we can show how to emit events to SocketCluster server.

I'm not a big fan of introducing a major dependency like that project into parse-server, because that forces to keep up with upstream changes as well as fully supporting the upstream project. However, I believe there is a possible middle ground that's possible, after all you can probably replace the PubSubAdapters for publish / subscribe with your own implementation based on SocketCluster no?

Actually the Pub/Sub adapter should runs on top of SocketCluster. SocketCluster should replace the WebSockets implementation and not the Pub/Sub adapter. In our case (parse-server) SocketCluster should replace the LiveQueryServer. BTW SocketCluster also introduce Pub/Sub integration (Redis, RabbitMQ).
What i was thinking is maybe not to replace the ws layer of parse-server but create WebSocketAdapter that will allow users to replace the core of the implementation with SocketCluster.
Another option can be to not use LiveQuery at all and to emit events to the SocketCluster server from cloud code using SocketCluster client libraries for NodeJS.
BTW! I am also not a big fan of introducing dependencies and that's the reason why i think that the integration should be done via external module and not as internal module in parse-server. Also i think that all the auth adapters (e.g. google, github, facebook, twitter etc.) should be added as external modules but this is related to another thread.

Also i think that all the auth adapters

We encourage additional auth adapters to be added externally.

Another option can be to not use LiveQuery at all and to emit events to the SocketCluster server from cloud code using SocketCluster client libraries for NodeJS.

That would work perfectly, this is actually what I would recommend. Maybe there is some refactor that can be done in order to swap part of the live query implementation, and keep the buisiness logic in parse-server (determine wether or not a trigger should be send).
Remember also that there are other platforms that 'need' the liveQuery client.
Not sure how much faster is SocketCluster, if we use uws instead of ws this seems to me that the main benefit would be the automatic k8s deployment. (which is also something we can work on for parse-server with proper configuration generation)

Agree. But think about it that with the current solution you must save something into the DB in order to receive the events but what is missing is the ability to send events from client to one or more clients without being depended on the DB layer. I found myself looking for cloud services like PubNub or Pusher (which are quite expensive..) and then i was thinking why not use an open source solution and then i found SocketCluster, tested it and really liked it and the next thing that i was thinking is how we can bring it to the parse-server platform. I think that it can be great to have it.
I think that at the first phase we can start with documentation or blog on how it can be done only via cloud code events (without really changing parse-server core) and then we can think about how we can take it to the next stage.
BTW. You can see here a benchmarks table about uws and it looks like uws is more lightweight with high performance especially for high throughput .

As you can see I added uWS as an optional dependency, so everyone benefits the performance upgrade.

you must save something into the DB in order to receive the events

Yeah, that's the whole point of parse-server. I'm not sure, if we start adding more feature that it would not be a dis-advantage.
In that sense, parse-server integrates very well through cloud code, and express, I don't believe the open source project should be doing everything. What you're describing is a very specific use case, with a project that's sole dedication is to run on k8s scalable WS. parse-server's mission is not about scalable websockets but a secure, simple to use, backend as a service that abstracts the need to use a custom ORM.
I believe both can live together but that bending parse-server to accommodate SocketCluster's architecture is not something I want to pursue.

What I did was use firebase but with parse user system. Make the login procedure through cloud code. In the cloud code you can use firebase auth system to generate a token for the user's object id. And return the session code for both parse and firebase. In this way we can use the real-time capabilities of firebase with security and also have a single auth system


dl: Suppress remaining warnings

TIL about a Souffle pragma to suppress warnings on a per-relation basis:
.pragma "suppress-warnings" "relation_name"

We should use this pragma to suppress warnings that can't/shouldn't be fixed (i.e., all the warnings that fire on v0.3). That way, warnings that are printed will be relevant.

Arg, it looks like you can only have one .pragma "supress-warnings" per program, which conflicts with the modular/multi-project style we have in cclyzer++. Also, it would be best if you were able to suppress individual warnings rather than all warnings for a given relation... We should just suffer through with the few warnings we can't get rid of.


test with java 21

Description
A description of the PR, should include a decent explanation as to why this change was needed and a decent explanation as to what this change does
Review Instructions
Describe if this ticket needs review and if so, how one may go about it in qa and/or staging environments.
For example, a ticket based on Security Hub, Snyk, or Dependabot may not need review since those services
will generate new warnings if the issue has not been resolved properly. On the other hand, an infrastructure
ticket that results in visible changes to the end-user will definitely require review.
Many tickets will likely be between these two extremes, so some judgement may be required.
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6612
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!

[ ] Check that your code compiles by running npm run build
[ ] Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
[ ] If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
[ ] Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
[ ] If displaying markdown, use the markdown-wrapper component, which does extra sanitization
[ ] Do not use cookies, although this may change in the future
[ ] Run npm audit and ensure you are not introducing new vulnerabilities
[ ] Do due diligence on new 3rd party libraries, checking for CVEs
[ ] Don't allow user-uploaded images to be served from the Dockstore domain
[ ] If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
[ ] Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

accessibility test seems like false positive and not a java thing

Oops, needs longer look

Something  dies in Java 19. https://gist.github.com/denis-yuen/b6af4e9ffcdf43f227a24ed0dbb78e77
Could be the Ubuntu 22, or something super minor with wget, curl, node, maven?

Note for self:
Java 18 is using Nginx 1.18.0
Java 19 with a fixed signing key is using Nginx 1.18.0

Sigh, ruled out the node version I guess.


select_hetero_snp_for_phasing breaks for contigs where no variants are found

VCFs are not generated for contigs where no variants are found,  which breaks select_hetero_snp_for_phasing.
clairs_output/vcf contains these files:

chr1.vcf  chr16.vcf  chr21.vcf  chr22.vcf  chr4.vcf  chr5.vcf

Errors pasted from some of 1_select_hetero_snp_for_phasing.log:

[INFO] Total HET SNP calls selected: chr22: 119, not found:27, not match:0, low_qual_count:0. Total normal:57 Total tumor:146, pro: 0.815068493150685
Traceback (most recent call last):
File "/opt/bin/clairs.py", line 120, in
main()
File "/opt/bin/clairs.py", line 114, in main
submodule.main()
File "/opt/bin/src/select_hetero_snp_for_phasing.py", line 157, in main
select_hetero_snp_for_phasing(args)
File "/opt/bin/src/select_hetero_snp_for_phasing.py", line 118, in select_hetero_snp_for_phasing
pro = len(pass_variant_dict) / len(tumor_qual_dict)
ZeroDivisionError: division by zero
Traceback (most recent call last):
File "/opt/bin/clairs.py", line 120, in
main()
File "/opt/bin/clairs.py", line 114, in main
submodule.main()
File "/opt/bin/src/select_hetero_snp_for_phasing.py", line 157, in main
select_hetero_snp_for_phasing(args)
File "/opt/bin/src/select_hetero_snp_for_phasing.py", line 118, in select_hetero_snp_for_phasing
pro = len(pass_variant_dict) / len(tumor_qual_dict)
ZeroDivisionError: division by zero
[INFO] Total HET SNP calls selected: chr1: 220, not found:66, not match:0, low_qual_count:0. Total normal:73 Total tumor:286, pro: 0.7692307692307693
[INFO] Total HET SNP calls selected: chr21: 1, not found:1, not match:0, low_qual_count:0. Total normal:31 Total tumor:2, pro: 0.5
Traceback (most recent call last):
File "/opt/bin/clairs.py", line 120, in
main()
File "/opt/bin/clairs.py", line 114, in main
submodule.main()
File "/opt/bin/src/select_hetero_snp_for_phasing.py", line 157, in main
select_hetero_snp_for_phasing(args)
File "/opt/bin/src/select_hetero_snp_for_phasing.py", line 118, in select_hetero_snp_for_phasing
pro = len(pass_variant_dict) / len(tumor_qual_dict)
ZeroDivisionError: division by zero

Hi,
Seems no germline variants output found, could you send the ${OUTPUT_DIR}/run_clairs.log to my email<EMAIL_ADDRESS>for us to pinpoint the error?

Hi,
Thanks for the response! To give you a bit of context, I am testing ClairS on a random subset of split bams (30/3000 from each tumor and normal, then I merge the bam subset and pass it into ClairS). This is probably why very few variants are being found for both germline and somatic. I have attached the log file as requested.
Best,
Xingyao
Xingyao Chen
AI Research Engineer
Lawrence J. Ellison Institute for
Transformative Medicine
phone:<PHONE_NUMBER>
eitm.orghttps://www.eitm.org
12414 Exposition Boulevard
Los Angeles, CA 90064
[cid:twitter_811371cb-d398-43e3-ab55-106c5a204612.png]https://www.twitter.com/ellisoninst/ [cid:instagram_248432e4-4f93-459c-8eaf-a92ede359460.png] https://www.instagram.com/ellisonInstitute/  [cid:facebook_12eb95f3-35a2-44b4-851e-5cd0c58ca1d9.png] https://www.facebook.com/ellisonInstitute/
[cid:ellisonlogosig119x45_dc413443-6eba-4f7e-97c2-53d21937878d.png]https://www.eitm.org
From: zhenxian @.>
Date: Sunday, March 19, 2023 at 11:07 PM
To: HKU-BAL/ClairS @.>
Cc: Xingyao Chen @.>, Author @.>
Subject: Re: [HKU-BAL/ClairS] select_hetero_snp_for_phasing breaks for contigs where no variants are found (Issue #5)
Hi,
Seems no germline variants output found, could you send the ${OUTPUT_DIR}/run_clairs.log to my email<EMAIL_ADDRESS>for us to pinpoint the error?
—
Reply to this email directly, view it on GitHubhttps://github.com/HKU-BAL/ClairS/issues/5#issuecomment-1475673828, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AWFUOYNGFMOSESJGVQ7YNYLW47XYJANCNFSM6AAAAAAWAMEEKU.
You are receiving this because you authored the thread.Message ID: @.***>

Hi,Xingyao,
Thanks for the logs. Some contigs did have no SNPs output owing to the small BAM size. We have fixed the error and please try to re-pull the docker image(You might need to remove your local image first using dcoker rmi hkubal/clairs:latest )
Zhenxian


Allow multilingual fields

Is your feature request related to a problem? Please describe.
One of the presses seeking to use Thoth, L'Harmattan Open Access, has publications in a variety of European languages (incl. Hungarian, English, Slovakian, etc.). Their existing metadata catalogue includes records that also store metadata in multiple languages (e.g. Hungarian- next to English-language metadata sets for a book published in Hungarian)
Describe the solution you'd like
Extend Thoth's data model to enable the recording of parallel versions of metadata in x number of languages.
Additional context
Also relevant to other presses and our collaboration with PKP - Alec Smecher noted that OMP encourages the use e.g. of multilingual titles, abstracts, etc.
Partial links to
a) #96
b) Recommendation 61 of the Scoping Report, and preceding paragraph noting

There is also a requirement to look at linguistic diversity and metadata. The English language (unsurprisingly) dominates. Many software packages assume English is the first language both as language of the software interface, and as input language. However, many OA monograph publishers exist to publish in other languages. OPERAS is looking into translation software and this could be extended to metadata . However, there may be problems with characters outside the standard Latin character set, as well as RTL scripts (Hebrew, Arabic), TTB scripts (Mongolian), context-sensitive scripts (Arabic), and abigudas (most South Asian scripts, Ethiopian, Inuit).  Source

So far we've identified title and abstracts – we need to clarify wether other fields would need multilingualism

related #435

Consider including a regional language variant in the metadata model. For example: en-BR, en-PT, es-ES, es-CO...


Force git cleanup

What this does:

adds an optional force flag for git locations
when the flag is missing or false, there is no change from current behavior
when the flag is true, we add a WIP commit and push changes to remote

NOTE: the forever there will stop when it reaches mzero so it should never get stuck in an infinite loop.
Changes, in chronological order of commits:

LocationSpec's ignoredFiles type was previously Maybe [Text] which wasn't necessary; changed it to [Text]
Using ignoredFiles on a GitLoc would result in a runtime error, so I added an extra indirection/type to make things safer
The BIG one, this adds all of the functionality; this is probably what you want to review
The following two commits are both very minor refactors
The last commit adds documentation to the README

Really great job. Thanks for separating everything into easily comprehensible commits. Going to merge right now.


When the new Redis will be released to be compatible with Grafana v8.2.1 ?

@ermalbaj Let me know if you have any questions.
I am finishing version 2.0 and release it later this week.

Tested and everything is working fine.
Thank you for the release.

@ermalbaj, thank you for confirming.
Please let me know if there is anything else.


ci: Enforce lock file when retrieving dependencies

For reproducibility, we should always use the lock file when
retrieving dependencies and fail otherwise.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

main

PR #45

PR #42

PR #43

PR #44

PR #46

PR #47   👈

This stack of pull requests is managed by Graphite.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

main

PR #45

PR #42

PR #43

PR #44

PR #46

PR #47   👈

This stack of pull requests is managed by Graphite.

Merge activity

Jan 9, 12:39 PM: @Mr-Pepe started a stack merge that includes this pull request via Graphite.


Azure Stack Hub - VPN Gateway - Clarify if P2S - Point to Site is supported

To help avoid user confusion, please clarify in the article if the Gateway SKUs supports point to site VPN connections. Hyperscale Azure from the same SKUs supports P2S.
Consider also adding the same clarification note to the following page: https://docs.microsoft.com/en-us/azure-stack/user/azure-stack-vpn-gateway-settings?view=azs-2108

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f780e2ad-c126-43e9-2596-848115d09fa7
Version Independent ID: 7e6afc9e-2803-5831-14b5-44d6fdbdb952
Content: Create VPN gateways for Azure Stack Hub - Azure Stack Hub
Content Source: azure-stack/user/azure-stack-vpn-gateway-about-vpn-gateways.md
Service: azure-stack
Sub-service: azure-stack-hub
GitHub Login: @sethmanheim
Microsoft Alias: sethm

Hi Chase,
Thank you for your feedback.  the following network considerations article covers the differences between Azure and Azure Stack Hub Networking. https://docs.microsoft.com/en-us/azure-stack/user/azure-stack-network-differences?view=azs-2108. The first row of the VPN section explains that P2S VPNs are not supported in Hub.

@CHDAFNI-MSFT We will now close this issue. If there are further questions regarding this matter, please tag me in a comment. I will reopen it and we will gladly continue the discussion.


Troubleshooting advice?

Thank you very much for building and sharing this integration.  I've done everything per the instructions, but I can't find evidence that Uptime Robot invoked the webhook (but it did send me an email for each of the down and up events).  Do you have any suggestions (perhaps for the README.md file) on how one can troubleshoot the integration?  Are webhooks a free Uptime Robot feature (everything I've seen suggests it is free.)
I can succeed with the example curl command given at the bottom of Rocket.Chat -> Administration -> Integrations -> Incoming Webhook Integration.  I see nothing related in the Rocket.Chat admin log.
Thanks again for building this bridge!

@watou As it's said in the official documentation, you can debug incoming webhooks using console in javascript. For example in my script, you can insert the following line to have debug logging in the view-logs interface in Rocket.Chat :

Btw, have you checked that the Alert Contact in the Uptime Robot settings is enabled ?

Thank you very much for the thoughtful advice, @crazy-max.  I've check that the alert contact is enabled, the incoming webhook is enabled, the JSON payload and URL are correct, and I added the console.log to the script per your example.   If I have any useful follow-up I will append it here for others.  Now I wait for downtime events.... 🙂

@watou you're welcome ;)
Keep me in touch, I'll close the issue for now.

@crazy-max Hi, I am having a similar issue, I tested the webhook using curl successfuly but I don't receive the alerts from uptime-robot. I followed every step as suggested.

@franckadil Hi, Your settings look like this right ? :

Have you added ? at the end of the RocketChat URL ?

@crazy-max  Yes that's exact.

@crazy-max I found the issue, I had to edit every site and activate the new contact:

I hope this wll help others !

@franckadil Yeah that's it :upside_down_face:

@crazy-max do you know Helpscout ? I tried to write a webhook like you did, but I am really new at this, It would be awesome if you could build an integration for RocketChat, I know It would benefit many users! 😸

@franckadil Leave an issue on my AMA. I'll see if I have time to process this :dart:

@crazy-max Thank you :) D'ont hesitate pm me if you need anything! I would be glad to help!


get app_displayname in token claims for client credential flow

I have register 2 different apps with azure app registration. App "A" expose apis and role, App  "B" has permission to read app "A" APIs. I am able to get token successfully with expected Rols.
Now i want to get app_display in token claims. i see app_display name with V2 when scope="micrsoft graph". When i change scope to app "A" URI, i get token successfully but no displayname.
How can i have display in claim.
This documentation does mention that app_display name is required claim but does not state how to get it in token
https://docs.microsoft.com/en-us/azure/active-directory/develop/active-directory-claims-mapping#claims-mapping-policy-properties

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 195c79a3-ccc5-8c6a-233e-95e344a9b4df
Version Independent ID: 401c7557-5817-bbd3-5bd8-8c97ef5a28cc
Content: Customize Azure AD tenant app claims (PowerShell) - Microsoft identity platform
Content Source: articles/active-directory/develop/active-directory-claims-mapping.md
Service: active-directory
Sub-service: develop
GitHub Login: @rwike77
Microsoft Alias: ryanwi

@hashimsingh
Thanks for your feedback! We will investigate and update as appropriate.

Thanks for your comment. The feedback has been shared with the content owner for further review. Thanks for your patience.

You have to use optional claims for this, not claims mapping.

Please confirm that setting acceptMappedClaims to true in the application manifest is a recommended practice for internal-only/single tenant applications as noted in https://github.com/MicrosoftDocs/azure-docs/issues/5111.

@paulgarn can comment on this better.

@paulgarn Also wondering this.

is there any update on this?

Yes, only if custom claims mapping is required though.

#assign:@paulgarn

#reassign:@paulgarn

#reassign:@paulgarn

@paulgarn Bump. I am searching for this EXACT answer, and am hoping that this is just a simple configuration on the resource server side of the call.  If the answer is "this is not possible" that is great, but can we update this ticket to explicitly state this is not possible? Thanks!

@cadethacker @hashimsingh Apologies for the (long) delay on a final answer on this, but I've now heard back from the product team that this is in fact not possible.
#please-close
#label:product-question
@MarileeTurscak-MSFT can you remove the doc-enhancement label from this one?

#label:"product-question"


feat(taskrun): add rerun for test plr

Fixes

https://issues.redhat.com/browse/HAC-5508
Description

Adds rerun button for Test Pipeline Run
Patchs the snapshot with correct scenario as run label

Type of change

[x] Feature
[ ] Bugfix
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Screen shots / Gifs for design review

How to test or reproduce?

Browser conformance:

[x] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge

/retest

/retest

@abhinandan13jan  unit tests are failing

/retest

/retest

UI is breaking while opening the pipeline run list page

Updated & tested...looks to work fine


update README

Codecov Report
Patch and project coverage have no change.

Comparison is base (82ece68) 92.88% compared to head (f547b33) 92.88%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #102   +/-   ##
=======================================
  Coverage   92.88%   92.88%
=======================================
  Files           4        4
  Lines         253      253
=======================================
  Hits          235      235
  Misses         18       18

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


'fMRIPrep failed' error in output logs.

Hi everyone,
I am running fMRIPrep in a singularity container and have noticed this error in the output logs for more than half of the subjects (around 500) after the pipeline is completed:
210323-09:26:04,193 nipype.workflow CRITICAL:
 fMRIPrep failed: Extra data: line 1 column 10838903 - line 1 column 10841390 (char 10838902 - 10841389)

The html files, confounds lists, and preprocessed data files all seem to be created appropriately for the subjects with this error. When opening the .nii files with Connectome Workbench, the registration and normalization also all seem to have been accurately executed for the subjects.
I am wondering if this error is interfering with the proper processes in the pipeline and if there is a way to fix this!
Any help would be greatly appreciated!
Thank you!
 The "extra data" error seems to be a JSON decode error. Unfortunately, it's unclear what file is causing it.
I would try parsing all of the JSON files, and looking for errors. Something like:
find $BIDS_DIR -name "*.json" -exec jq . "{}" ";" > /dev/null
find $SCRATCH_DIR -name "*.json" -exec jq . "{}" ";" > /dev/null
find $OUTPUT_DIR -name "*.json" -exec jq . "{}" ";" > /dev/null


Faster XYZMap

Replaces the current open hashmap implementation of XYZMap with a hash map of doubly-linked nodes. This allows for a number of optimizations:

hashes can be cached and compared quickly before comparison of coordinates
buckets don't begin to intersect as the map fills up, preventing needlessly long searches

In theory, this should be quite a bit faster, but in practice the results seem to be rather inconsistent between runs. More benchmarking is needed.
Due to the nature of this implementation, iteration becomes quite a bit slower, and random iteration becomes nearly impossible. However, normal iteration is only done when unloading cubes, and randomWrappedIterator is referenced only by PlayerCubeMap#getRandomWrappedCubeWatcherIterator, which is never used.

@DaMatrix, what's the status on this one?

Ah, i discussed this with Barteks on Discord but never closed this PR. This ended up being more or less the same as the existing implementation outside of benchmark conditions and some very obscure edge cases, yielding on average about the same results when actually used. Probably not worth keeping this around.


HTTPRequest node documentation POST request example is outdated or incorrect.

Godot version
3.4 beta 4
System information
Windows 10
Issue description
HTTPRequest node documentation outdated.
The example shows:
    var body = {"name": "Godette"}
    error = http_request.request("https://httpbin.org/post", [], true, HTTPClient.METHOD_POST, body)

However, the signature of the function is:
Error request(url: String, custom_headers: PoolStringArray = PoolStringArray(  ), ssl_validate_domain: bool = true, method: Method = 0, request_data: String = "")
Steps to reproduce
Simply copy/paste the POST example in the HTTPRequest documentation and note the error: "Invalid type in function 'request' in base 'HTTPRequest'. Cannot convert argument 5 from Dictionary to String."
Minimal reproduction project
(just copy the example)

@Chaosus
I just have to make the changes in the Documentation right?
Can you assign this issue to me?

Yes, class docs are .rst files in the main repo, tutorials and the like live in the godot-docs repo.
In general we don't assign issues in such cases, you can just work on it and submit a PR :)

Sure Thanks.

@jitspoe Could you direct me to the correct file for these changes??

@jitspoe Could you direct me to the correct file for these changes??

Should be under doc/classes/HTTPRequest.xml


[ADDON] - FSX CSI Driver

Started working on this add-on to show the examples for users to leverage Fsx for Luster for Spark workloads

closed in #722


Problems with encoding for column width calculation

The following table could not be compiled:
---
caption: 'Áreas ...'
alignment: LLL
table-width: 2/3
markdown: True
---
Código,Áreas,N.Horas
DS, Discrete Structures, 43

Solution: force UTF8 encoding. Add in line 60 of "pantable.py" the following lines:
reload(sys)
sys.setdefaultencoding('utf8')

@fidelaznar, which Python version were you using?

Python 2.7.13

It is a problem of the CSV module in Python2. Are you sure your fix would fix the unicode problem in Pyhton2?
I'm considering using another CSV writer/reader such as Pandas (for various reasons including performance and this). But it's a big dependency. Let me know your opinion on this.

With this lines I've compiled a lot of tables without a problem using Unicode Chars. If the input is Unicode It should work.

Also see #21

@fidelaznar, please check pantable v0.11 if #25 fixes your problem. Thanks.


Add nkoro joseph to Contributors List

This is my first lesson on making a contribution to open source. Hope this would be accepted.

Hi  @nkorojoseph, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.


Missing "editRoles" permission when editing/creating new user!

Version information

Laravel: v5.6.29
Voyager: v1.1.3
PHP: 7.2.8
Database: MySQL 5.7.21

Description
cannot add/edit Roles for admin user missing editRoles permission!
file: vendor/tcg/voyager/resources/views/users/edit-add.blade.php
line: 63
code: @can('editRoles', $dataTypeContent)
Steps To Reproduce
Steps to reproduce the behavior:

Login as Admin
Go to edit user page
cannot edit or add any role.

Expected behavior
admin user should have the ability to edit role!
Screenshots

Additional context
cannot find any permission that was mentioned in the users.edit-add.blade.php

Its here.
And its wanted that a user can not edit his own roles.

@emptynick maybe edit his own role OK but creating new user should be the option to chose a role for him.

Solved it by adding "TCG\Voyager\Policies\UserPolicy" to the BREAD for the Users as its policy.
it couldn't find a default policy to use when was left empty.

Then your own role (from the user creating another user) does not have the permission to edit_users (only add_users maybe)

Thats the default policy by the way. Maybe dont change it.

@emptynick I know it is the default policy, apparently voyager couldn't find the default policy when this field was left empty.
I had to manually insert this value to the input in order to solve this.

If you upgraded from an older version, that field may have been blank, but a new install should have it set: https://github.com/the-control-group/voyager/blob/1.1/publishable/database/seeds/DataTypesTableSeeder.php#L21

@emptynick

And its wanted that a user can not edit his own roles.

Let's be more clear: a user can edit it's own role, the choice is only hidden.
I think it's important that people know this so they can fix it on their own if it's a problem on their implementation.

We are working on this, and we know that there are a few open PRs which will resolve this.
Its just a "bad time" as we are all on vacation and (me for myself) very very busy at work,
but it will be solved soon.

@emptynick
Thanks for your reply, I'm just trying to keep the issue alive and of course I'll try to help as I can.

I'll reopen this issue then...

The issue is solved. The discussion was a bit off-topic

that user has been created by manual. So that, you should create new user w/ full acess to your site:
php artisan voyager:admin<EMAIL_ADDRESS>


[WIP] Check for user verifying platform authenticator

This introduces a hitherto unused check for "user-verifying platform authenticator".

This is branched off #74 so it has that work in it too, hence the WIP in the title.
Also I want more time to look at this, I just did it today and I'm getting sleepy.

@type1fool I am considering renaming check_user_verifying_platform_authenticator_available to check_uvpa_available throughout. What do you think? Since it gets its own section in the docs, the acronym is easily found.

I am considering renaming check_user_verifying_platform_authenticator_available to check_uvpa_available throughout.

That seems like a good use of an acronym.


Proposal: ":terminal" option about winpty/conpty

I propose to change current "++winpty" and "++conpty" option of ":terminal" command to "++mode={pty}" style.
:term ++mode=conpty

Reasons:

"++winpty" and "++conpty" are mutually exclusive and coordinate values, so better to treat them as values of one option.

"term_start()" has "term_mode" option to specify pty. I think nice to be consistency with this style for usability.

If an another new pty is added in future, add "++newpty" option...?

I propose to change current "++winpty" and "++conpty" option of
":terminal" command to "++mode={pty}" style.
:term ++mode=conpty

Reasons:

"++winpty" and "++conpty" are mutually exclusive and coordinate
values, so better to treat them as values of one option.

"term_start()" has "term_mode" option to specify pty. I think nice
to be consistency with this style for usability.

If an another new pty is added in future, add "++newpty" option...?

I'm actually not so happy with the word "mode".  It's hard to think of
something better (that is still short).  "type" comes closer, because
you can see it as the type of terminal.  "mode" sounds too much like
it's  a free choice, and we also use the term "Terminal mode" and
"Terminal-Job mode".
I also think that the choice is something you make once, and depends on
your setup.  If ConPTY works, you probably want to use it, I don't see
why one would switch back and forth.  Doesn't ConPTY support everything
that winpty does?
--
ROBIN:  (warily) And if you get a question wrong?
ARTHUR: You are cast into the Gorge of Eternal Peril.
ROBIN:  Oh ... wacho!
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Doesn't ConPTY support everything that winpty does?

Currently, there is a problem in ConPTY.
Quoting from :help ConPTY:

When ConPTY is in use, there may be rendering artifacts regarding ambiguous-width
characters. If you encounter any such issues, set 'termmode' to winpty (which
you then must have instlled).

This will be fixed in the next release of Windows. See https://github.com/Microsoft/console/issues/347 for detail.

"type" comes closer

👍
Similarly, we should also change the name of the 'termmode' option.
How about 'ptytype'?

Similarly, we should also change the name of the 'termmode' option.
How about 'ptytype'?

All options related to the Terminal Window should have been prefixed "termwin" (e.g. 'termwinkey', 'termwinsize').
So, I think 'termmode' should be renamed to 'termwintype'.

surely.
Rather than the type of the Terminal window,
I think that it is the type of pty used in the Terminal window.
How about 'termwinptytype'? too long?

Ah, it cause confusion as it contains the word winpty...

In the first design it was termwinmode. I thought it was long.
clipty and cuipty seemed different in a non-Windows environment, so I avoided it.
There is an abyss mystery in termwinterm.

Simply, does not it increase the amount of hitting the keyboard?
I thought of ++w and ++c.

Ken Takata wrote:

Doesn't ConPTY support everything that winpty does?

Currently, there is a problem in ConPTY.
Quoting from :help ConPTY:

When ConPTY is in use, there may be rendering artifacts regarding
ambiguous-width
characters. If you encounter any such issues, set 'termmode' to winpty (which
you then must have instlled).

This will be fixed in the next release of Windows. See
https://github.com/Microsoft/console/issues/347 for detail.

OK, but doesn't this still mean that most users will pick either ConPTY
or winpty, and are very unlikely to open some terminals with one and
other terminals with the other?
--
BRIDGEKEEPER: What is your favorite colour?
LAUNCELOT:    Blue.
BRIDGEKEEPER: Right.  Off you go.
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

I did not notice until I finished writing the code, so that they work in parallel.
Since I can not choose one, I made it both available.
The ambiwidth of ConPTY can not be used because there is a problem in the CJK environment.
In other words, it is the same as not being for the user.
The current ConPTY is the same as nothing.
It is desirable for everyone to type ":terminal" and the terminal will be displayed.
Changing the type is an emergency measure.
I do not think that the right side of the setting not explicitly shown to the user is undesirable.
Equal signs are assignments, not orders. The order is a word. Words are ++winpty or ++conpty.
Considering the third terminal is to worry about GUID collision. It is religious and attracts programmers. However, it is not a reality.
The ++mode approach is a two choice, the most important, default value can not be set. ++mode=default? Well.

@brammool
This is proposal specification.

Make the 'termwintype' (Current name 'termmode') option global.
Above option affects the behavior when ":terminal" or "term_start()" is executed.
If change above option in terminal window, it will not change a current using virtual console.
When ":terminal" is executed, we can specify the virtual console to be used with "++type=".
(term_start() is specified by "term_type")
Add "termtype" to job_info().
To get term_type of terminal window, do as follows:
let term_type = job_info(term_getjob("")).term_type

Note:
Various names are provisional.
The original idea is from @ichizok .
--
Best regards,
Hirohito Higashi (h_east)

Bram's comment is not forwarded here.
https://groups.google.com/d/msg/vim_dev/ECENAhHr8tw/s8X29CBBGwAJ

I think most of users will not use ++wincon or ++mode=conpty. This is feature for callback of Windows console. No user intentionally switch console type. What we need is a way to know which type is used on environment of bug reporter. Additional functions are NOT required.

Let's remove:

++XXX in :term
option for term_start()
But keep job_info (This is useful to know which type is used)

Codecov Report

Merging #3905 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3905      +/-   ##
==========================================
+ Coverage   78.84%   78.85%   +<.01%
==========================================
  Files         105      105
  Lines      142065   142052      -13
==========================================
- Hits       112016   112011       -5
+ Misses      30049    30041       -8

Impacted Files
Coverage Δ

src/channel.c
83.46% <ø> (+0.29%)
:arrow_up:

src/terminal.c
75.16% <100%> (ø)
:arrow_up:

src/version.c
85.39% <0%> (-0.89%)
:arrow_down:

src/gui_gtk_x11.c
48.32% <0%> (-0.1%)
:arrow_down:

src/window.c
83.44% <0%> (-0.1%)
:arrow_down:

src/screen.c
80.12% <0%> (+0.02%)
:arrow_up:

src/ui.c
50% <0%> (+0.07%)
:arrow_up:

src/gui.c
58.1% <0%> (+0.1%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6ddce3...941e879. Read the comment docs.

Updated patch (rebased on v8.1.0880): Applied the following
https://github.com/vim/vim/pull/3905#issuecomment-461671409

Let's remove:

++XXX in :term
option for term_start()
But
keep job_info (This is useful to know which type is used)

Looks like all relevant changes were made, closing this PR.
If changes are still needed, please open a new issue.


Unable to extract video_title - Crunchyroll

Checklist

[x] I'm reporting a broken site support
[x] I've verified that I'm running youtube-dl version 2020.03.24
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--merge-output-format', 'mkv', '--ffmpeg-location', 'ffmpeg\\bin', '--cache-dir', 'cache', '--fixup', 'warn', '--add-metadata', '--no-call-home', '--sub-lang', 'enUS', '--write-sub', '-o', '%%(uploader)s/%%(title)s.%%(ext)s', 'https://www.crunchyroll.com/black-clover/episode-131-a-new-resolve-794726', '-v']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2020.03.24
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.18362
[debug] exe versions: ffmpeg 3.4.2, ffprobe 3.4.2, rtmpdump 2.3
[debug] Proxy map: {}
[crunchyroll] 794726: Downloading webpage
ERROR: Unable to extract video_title; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpjwbwqymm\build\youtube_dl\YoutubeDL.py", line 797, in extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpjwbwqymm\build\youtube_dl\extractor\common.py", line 530, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpjwbwqymm\build\youtube_dl\extractor\crunchyroll.py", line 446, in _real_extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpjwbwqymm\build\youtube_dl\extractor\common.py", line 1014, in _html_search_regex
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpjwbwqymm\build\youtube_dl\extractor\common.py", line 1005, in _search_regex
youtube_dl.utils.RegexNotFoundError: Unable to extract video_title; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Description
When attempting to download pretty much any new video from Crunchyroll, it is unable to find the video_title.  I wish I could provide more, but I'm not privy to the details of how this all works.

https://github.com/ytdl-org/youtube-dl/pull/25060

Nice!  Glad there's a pull request already.  Didn't think to search there.


Slightly highlighted color for selected elements

Highlight selected elements slightly, both light and dark themes.

This is more useful when we show bounding outline  (#40) and there are some unselected elements in the bounding box. Also applicable in grouping #18


Error: deadline 2020-05-20T11:41:56.763 exceeded by 43977us

I have set up an EOS node and now trying to create an account using RPC API. But every time I am getting
Error: deadline 2020-05-20T11:41:56.763 exceeded by 43977us

Increase your http-max-response-time-ms setting.

So if I make the changes in the config file does the block sync start again? As the block is still syncing


Logging shows password

Hi,
the logging of the adapter shows the password in readable form. Maybe this can be changed to increase security.

I just realized the same today as I got my Landroid and configured it in iobroker.
IMPORTANT: Please remove password from Log.


Feature standardize exceptions

Coverage increased (+0.03%) to 98.5% when pulling d68031a85b38d8e96b9c90989dd140de6c546ccb on feature-standardize-exceptions into a3a4397af0d954568bda22d7fed9048d09b83585 on develop.


exec: Failed to execute process '(null)': An argument exceeds the OS argument length limit.

Describe the bug
Receiving an error when using to complete pacman -S arguments.
To Reproduce

install fifc
type pacman -S , hit shortcut to invoke fifc

Expected behavior
Package name(s) should appear
Actual behavior
pacman -S exec: Failed to execute process '(null)': An argument exceeds the OS argument length limit.
exec: Failed to execute process '(null)': An argument exceeds the OS argument length limit.
exec: Failed to execute process '(null)': An argument exceeds the OS argument length limit.
exec: Failed to execute process '(null)': An argument exceeds the OS argument length limit.
exec: Failed to execute process '(null)': An argument exceeds the OS argument length limit.
exec: Failed to execute process '(null)': An argument exceeds the OS argument length limit.
exec: Failed to execute process '(null)': An argument exceeds the OS argument length limit.

System (please complete the following information):

fish version 3.4.1
Arch Linux x86_64 rolling

Additional context
If I specify a more narrow search, like pacman -S firef no error appears - instead a list of packages starting with firef are shown.

Hi @jose1711!
This seems related to #3. It's due to the fact that when completion is triggered, we run complete -C first, to determine the suggestion group and store the results in a list, which can leads to big OS argument size.
#4 was a quick fix, only solving the special case of empty commandline, which is likely to produce large number of results, but we need a more robust solution.