Presence of build.rs breaks build with cargo chef: generated files not present

Hi, I realise the README says

cargo-chef has not yet been tested extensively with projects leveraging build files.

...this issue is an attempt to change that. :)
I have created a minimal example crate leveraging build.rs file: https://github.com/strohel/cargo-chef-build-rs
The build using cargo-chef fails with the following error:
Step 16/20 : RUN cargo build --release --bin cargo-chef-build-rs
 ---> Running in 53c5f9739b5f
   Compiling cargo-chef-build-rs v0.1.0 (/app)
error: couldn't read /app/target/release/build/cargo-chef-build-rs-087b5874e2eb29d7/out/built.rs: No such file or directory (os error 2)
 --> src/main.rs:1:1
  |
1 | include!(concat!(env!("OUT_DIR"), "/built.rs"));

i.e. the file that is generated by build.rs is not present. It is kinda strange, because at this point, cargo chef is no longer involved (beyond files generated by it being present in /target). Maybe that somehow fools cargo to think that build.rs was already run, while it actually wasn't?
I'll be happy to help to resolve this.

Maybe that somehow fools cargo to think that build.rs was already run, while it actually wasn't?

I'd bet that this is indeed the case - there is a clean up step after cargo chef cook to remove the artifacts generated for local crates that were replaced with dummies - it's possible that we are not cleaning up some of the artifacts related to build scripts.
If you are willing to work on it, go ahead!

Maybe that somehow fools cargo to think that build.rs was already run, while it actually wasn't?

I'd bet that this is indeed the case - there is a clean up step after cargo chef cook to remove the artifacts generated for local crates that were replaced with dummies - it's possible that we are not cleaning up some of the artifacts related to build scripts.
If you are willing to work on it, go ahead!

Thanks for the hint, I think it has steered me into the right direction.
For reference: this is a difference of files generated by cargo chef cook in the same project with/without build.rs (manually edited slightly to suppress differences caused by hash of files changing):
strohel@mat480s ~/projekty $ diff -u --color <(cd cacher-without-build-rs/; find . | sort) <(cd cacher-with-build-rs/; find . | sort)
--- /dev/fd/63  2021-01-18 13:00:23.899484920 +0100
+++ /dev/fd/62  2021-01-18 13:00:23.900484918 +0100
@@ -1,4 +1,5 @@
 .
+./build.rs
 ./Cargo.lock
 ./Cargo.toml
 ./files.txt
@@ -19,6 +20,16 @@
 ./target/debug/build/bitflags-4a5ac15c6e640b31/build-script-build
 ./target/debug/build/bitflags-4a5ac15c6e640b31/build_script_build-4a5ac15c6e640b31
 ./target/debug/build/bitflags-4a5ac15c6e640b31/build_script_build-4a5ac15c6e640b31.d
+./target/debug/build/cargo-chef-build-rs-dde62fe5df47908a
+./target/debug/build/cargo-chef-build-rs-dde62fe5df47908a/invoked.timestamp
+./target/debug/build/cargo-chef-build-rs-dde62fe5df47908a/out
+./target/debug/build/cargo-chef-build-rs-dde62fe5df47908a/output
+./target/debug/build/cargo-chef-build-rs-dde62fe5df47908a/root-output
+./target/debug/build/cargo-chef-build-rs-dde62fe5df47908a/stderr
+./target/debug/build/cargo-chef-build-rs-4beca2ab97d7a610
+./target/debug/build/cargo-chef-build-rs-4beca2ab97d7a610/build-script-build
+./target/debug/build/cargo-chef-build-rs-4beca2ab97d7a610/build_script_build-4beca2ab97d7a610
+./target/debug/build/cargo-chef-build-rs-4beca2ab97d7a610/build_script_build-4beca2ab97d7a610.d
 ./target/debug/build/libc-b475d1d8bc448daa
 ./target/debug/build/libc-b475d1d8bc448daa/build-script-build
 ./target/debug/build/libc-b475d1d8bc448daa/build_script_build-b475d1d8bc448daa
@@ -87,11 +98,19 @@
 ./target/debug/.fingerprint/bitflags-56eca94422237621/invoked.timestamp
 ./target/debug/.fingerprint/bitflags-56eca94422237621/lib-bitflags
 ./target/debug/.fingerprint/bitflags-56eca94422237621/lib-bitflags.json
+./target/debug/.fingerprint/cargo-chef-build-rs-dde62fe5df47908a
+./target/debug/.fingerprint/cargo-chef-build-rs-dde62fe5df47908a/run-build-script-build-script-build
+./target/debug/.fingerprint/cargo-chef-build-rs-dde62fe5df47908a/run-build-script-build-script-build.json
 ./target/debug/.fingerprint/cargo-chef-build-rs-HASH
 ./target/debug/.fingerprint/cargo-chef-build-rs-HASH/bin-cargo-chef-build-rs
 ./target/debug/.fingerprint/cargo-chef-build-rs-HASH/bin-cargo-chef-build-rs.json
 ./target/debug/.fingerprint/cargo-chef-build-rs-HASH/dep-bin-cargo-chef-build-rs
 ./target/debug/.fingerprint/cargo-chef-build-rs-HASH/invoked.timestamp
+./target/debug/.fingerprint/cargo-chef-build-rs-4beca2ab97d7a610
+./target/debug/.fingerprint/cargo-chef-build-rs-4beca2ab97d7a610/build-script-build-script-build
+./target/debug/.fingerprint/cargo-chef-build-rs-4beca2ab97d7a610/build-script-build-script-build.json
+./target/debug/.fingerprint/cargo-chef-build-rs-4beca2ab97d7a610/dep-build-script-build-script-build
+./target/debug/.fingerprint/cargo-chef-build-rs-4beca2ab97d7a610/invoked.timestamp
 ./target/debug/.fingerprint/clap-e91cacf9737a9a98
 ./target/debug/.fingerprint/clap-e91cacf9737a9a98/dep-lib-clap
 ./target/debug/.fingerprint/clap-e91cacf9737a9a98/invoked.timestamp
@@ -131,17 +150,30 @@
 ./target/debug/.fingerprint/vec_map-afdbc8d9b39dae03/lib-vec_map
 ./target/debug/.fingerprint/vec_map-afdbc8d9b39dae03/lib-vec_map.json
 ./target/debug/incremental
 ./target/debug/incremental/cargo_chef_build_rs-2vlf5bnbx0alw (different hash change suppressed)
 ./target/debug/incremental/cargo_chef_build_rs-2vlf5bnbx0alw/s-fv1hic1535-1me0zxq.lock (different hash change suppressed)
 ./target/debug/incremental/cargo_chef_build_rs-2vlf5bnbx0alw/s-fv1hic1535-1me0zxq-1v7udim5lpnaq (different hash change suppressed)
 ./target/debug/incremental/cargo_chef_build_rs-2vlf5bnbx0alw/s-fv1hic1535-1me0zxq-1v7udim5lpnaq/dep-graph.bin (different hash change suppressed)
 ./target/debug/incremental/cargo_chef_build_rs-2vlf5bnbx0alw/s-fv1hic1535-1me0zxq-1v7udim5lpnaq/query-cache.bin (different hash change suppressed)
 ./target/debug/incremental/cargo_chef_build_rs-2vlf5bnbx0alw/s-fv1hic1535-1me0zxq-1v7udim5lpnaq/work-products.bin (different hash change suppressed)
 ./target/debug/incremental/cargo_chef_build_rs-2vlf5bnbx0alw/s-fv1hic1535-1me0zxq-1v7udim5lpnaq/1a2a2co6g69fwkoe.o (different hash change suppressed)
 ./target/debug/incremental/cargo_chef_build_rs-2vlf5bnbx0alw/s-fv1hic1535-1me0zxq-1v7udim5lpnaq/1ehr43tf2eme69hl.o (different hash change suppressed)
 ./target/debug/incremental/cargo_chef_build_rs-2vlf5bnbx0alw/s-fv1hic1535-1me0zxq-1v7udim5lpnaq/2k01npnnw4g8fuhx.o (different hash change suppressed)
 ./target/debug/incremental/cargo_chef_build_rs-2vlf5bnbx0alw/s-fv1hic1535-1me0zxq-1v7udim5lpnaq/4hxq9v6ujrc2lnfh.o (different hash change suppressed)
 ./target/debug/incremental/cargo_chef_build_rs-2vlf5bnbx0alw/s-fv1hic1535-1me0zxq-1v7udim5lpnaq/4uupj05z4896dqcs.o (different hash change suppressed)
 ./target/debug/incremental/cargo_chef_build_rs-2vlf5bnbx0alw/s-fv1hic1535-1me0zxq-1v7udim5lpnaq/5ftd5e3blaqx1nxx.o (different hash change suppressed)
 ./target/debug/incremental/cargo_chef_build_rs-2vlf5bnbx0alw/s-fv1hic1535-1me0zxq-1v7udim5lpnaq/57ajcdm0nmqjkakv.o (different hash change suppressed)
+./target/debug/incremental/build_script_build-1dg36y1peirj1
+./target/debug/incremental/build_script_build-1dg36y1peirj1/s-fv1hhq0s0g-mgocdp.lock
+./target/debug/incremental/build_script_build-1dg36y1peirj1/s-fv1hhq0s0g-mgocdp-252s9dav2g7yb
+./target/debug/incremental/build_script_build-1dg36y1peirj1/s-fv1hhq0s0g-mgocdp-252s9dav2g7yb/dep-graph.bin
+./target/debug/incremental/build_script_build-1dg36y1peirj1/s-fv1hhq0s0g-mgocdp-252s9dav2g7yb/query-cache.bin
+./target/debug/incremental/build_script_build-1dg36y1peirj1/s-fv1hhq0s0g-mgocdp-252s9dav2g7yb/work-products.bin
+./target/debug/incremental/build_script_build-1dg36y1peirj1/s-fv1hhq0s0g-mgocdp-252s9dav2g7yb/1alu3igwgjpty83h.o
+./target/debug/incremental/build_script_build-1dg36y1peirj1/s-fv1hhq0s0g-mgocdp-252s9dav2g7yb/15cnaap0nusqru3d.o
+./target/debug/incremental/build_script_build-1dg36y1peirj1/s-fv1hhq0s0g-mgocdp-252s9dav2g7yb/3kfifkj8wdxdkh6c.o
+./target/debug/incremental/build_script_build-1dg36y1peirj1/s-fv1hhq0s0g-mgocdp-252s9dav2g7yb/3mflj5waub27s7xb.o
+./target/debug/incremental/build_script_build-1dg36y1peirj1/s-fv1hhq0s0g-mgocdp-252s9dav2g7yb/3wc23r6xbtgdruc9.o
+./target/debug/incremental/build_script_build-1dg36y1peirj1/s-fv1hhq0s0g-mgocdp-252s9dav2g7yb/3xt72xavmlqcan9z.o
+./target/debug/incremental/build_script_build-1dg36y1peirj1/s-fv1hhq0s0g-mgocdp-252s9dav2g7yb/34h79aup2rc9ipsk.o
 ./target/.rustc_info.json

That can be categorised as 2 * 2 + 1 sets of files that exist only in a build with build.rs:

Under <target_directory>/build/
a) cargo-chef-build-rs-dde62fe5df47908a/ directory from the run-build-script - build-script-build step
b) cargo-chef-build-rs-4beca2ab97d7a610/ directory from the build-script - build-script-build step
Under <target_directory>/.fingerprint/
a) cargo-chef-build-rs-dde62fe5df47908a/ with run-build-script-build-script-build{,.json}
b) cargo-chef-build-rs-4beca2ab97d7a610/ with build-script-build-script-build{,.json} + 2 files
Under <target_directory>/incremental/

build_script_build-1dg36y1peirj1/ (different -/_ convention and different hash) directory with a hashed subdir with .o and .bin files.

I think we need to re-run both run-build-script and build-script "jobs" of the build-script-build "phase" in the final build (I'm inventing my own terminology here, I would need to study cargo to use the correct one).
It could be actually possible to remove all the added files with a pattern like <target_directory>/**build[-_]script[-_]build**, but that seems a bit crude: it would match also files in {build,.fingerprint}/{libc,bitflags}-*/ which we probably don't want.
So different patterns for the sets 1., 2, and 3. would be needed. Do you know which of these sets the the important ones? If not, I can also find out by trial & error.

Thanks for the hint, I think it has steered me into the right direction.
For reference: this is a difference of files generated by cargo chef cook in the same project with/without build.rs (manually edited slightly to suppress differences caused by hash of files changing):
strohel@mat480s ~/projekty $ diff -u --color <(cd cacher-without-build-rs/; find . | sort) <(cd cacher-with-build-rs/; find . | sort)
--- /dev/fd/63  2021-01-18 13:00:23.899484920 +0100
+++ /dev/fd/62  2021-01-18 13:00:23.900484918 +0100
@@ -1,4 +1,5 @@
 .
+./build.rs
 ./Cargo.lock
 ./Cargo.toml
 ./files.txt
@@ -19,6 +20,16 @@
 ./target/debug/build/bitflags-4a5ac15c6e640b31/build-script-build
 ./target/debug/build/bitflags-4a5ac15c6e640b31/build_script_build-4a5ac15c6e640b31
 ./target/debug/build/bitflags-4a5ac15c6e640b31/build_script_build-4a5ac15c6e640b31.d
+./target/debug/build/cargo-chef-build-rs-dde62fe5df47908a
+./target/debug/build/cargo-chef-build-rs-dde62fe5df47908a/invoked.timestamp
+./target/debug/build/cargo-chef-build-rs-dde62fe5df47908a/out
+./target/debug/build/cargo-chef-build-rs-dde62fe5df47908a/output
+./target/debug/build/cargo-chef-build-rs-dde62fe5df47908a/root-output
+./target/debug/build/cargo-chef-build-rs-dde62fe5df47908a/stderr
+./target/debug/build/cargo-chef-build-rs-4beca2ab97d7a610
+./target/debug/build/cargo-chef-build-rs-4beca2ab97d7a610/build-script-build
+./target/debug/build/cargo-chef-build-rs-4beca2ab97d7a610/build_script_build-4beca2ab97d7a610
+./target/debug/build/cargo-chef-build-rs-4beca2ab97d7a610/build_script_build-4beca2ab97d7a610.d
 ./target/debug/build/libc-b475d1d8bc448daa
 ./target/debug/build/libc-b475d1d8bc448daa/build-script-build
 ./target/debug/build/libc-b475d1d8bc448daa/build_script_build-b475d1d8bc448daa
@@ -87,11 +98,19 @@
 ./target/debug/.fingerprint/bitflags-56eca94422237621/invoked.timestamp
 ./target/debug/.fingerprint/bitflags-56eca94422237621/lib-bitflags
 ./target/debug/.fingerprint/bitflags-56eca94422237621/lib-bitflags.json
+./target/debug/.fingerprint/cargo-chef-build-rs-dde62fe5df47908a
+./target/debug/.fingerprint/cargo-chef-build-rs-dde62fe5df47908a/run-build-script-build-script-build
+./target/debug/.fingerprint/cargo-chef-build-rs-dde62fe5df47908a/run-build-script-build-script-build.json
 ./target/debug/.fingerprint/cargo-chef-build-rs-HASH
 ./target/debug/.fingerprint/cargo-chef-build-rs-HASH/bin-cargo-chef-build-rs
 ./target/debug/.fingerprint/cargo-chef-build-rs-HASH/bin-cargo-chef-build-rs.json
 ./target/debug/.fingerprint/cargo-chef-build-rs-HASH/dep-bin-cargo-chef-build-rs
 ./target/debug/.fingerprint/cargo-chef-build-rs-HASH/invoked.timestamp
+./target/debug/.fingerprint/cargo-chef-build-rs-4beca2ab97d7a610
+./target/debug/.fingerprint/cargo-chef-build-rs-4beca2ab97d7a610/build-script-build-script-build
+./target/debug/.fingerprint/cargo-chef-build-rs-4beca2ab97d7a610/build-script-build-script-build.json
+./target/debug/.fingerprint/cargo-chef-build-rs-4beca2ab97d7a610/dep-build-script-build-script-build
+./target/debug/.fingerprint/cargo-chef-build-rs-4beca2ab97d7a610/invoked.timestamp
 ./target/debug/.fingerprint/clap-e91cacf9737a9a98
 ./target/debug/.fingerprint/clap-e91cacf9737a9a98/dep-lib-clap
 ./target/debug/.fingerprint/clap-e91cacf9737a9a98/invoked.timestamp
@@ -131,17 +150,30 @@
 ./target/debug/.fingerprint/vec_map-afdbc8d9b39dae03/lib-vec_map
 ./target/debug/.fingerprint/vec_map-afdbc8d9b39dae03/lib-vec_map.json
 ./target/debug/incremental
 ./target/debug/incremental/cargo_chef_build_rs-2vlf5bnbx0alw (different hash change suppressed)
 ./target/debug/incremental/cargo_chef_build_rs-2vlf5bnbx0alw/s-fv1hic1535-1me0zxq.lock (different hash change suppressed)
 ./target/debug/incremental/cargo_chef_build_rs-2vlf5bnbx0alw/s-fv1hic1535-1me0zxq-1v7udim5lpnaq (different hash change suppressed)
 ./target/debug/incremental/cargo_chef_build_rs-2vlf5bnbx0alw/s-fv1hic1535-1me0zxq-1v7udim5lpnaq/dep-graph.bin (different hash change suppressed)
 ./target/debug/incremental/cargo_chef_build_rs-2vlf5bnbx0alw/s-fv1hic1535-1me0zxq-1v7udim5lpnaq/query-cache.bin (different hash change suppressed)
 ./target/debug/incremental/cargo_chef_build_rs-2vlf5bnbx0alw/s-fv1hic1535-1me0zxq-1v7udim5lpnaq/work-products.bin (different hash change suppressed)
 ./target/debug/incremental/cargo_chef_build_rs-2vlf5bnbx0alw/s-fv1hic1535-1me0zxq-1v7udim5lpnaq/1a2a2co6g69fwkoe.o (different hash change suppressed)
 ./target/debug/incremental/cargo_chef_build_rs-2vlf5bnbx0alw/s-fv1hic1535-1me0zxq-1v7udim5lpnaq/1ehr43tf2eme69hl.o (different hash change suppressed)
 ./target/debug/incremental/cargo_chef_build_rs-2vlf5bnbx0alw/s-fv1hic1535-1me0zxq-1v7udim5lpnaq/2k01npnnw4g8fuhx.o (different hash change suppressed)
 ./target/debug/incremental/cargo_chef_build_rs-2vlf5bnbx0alw/s-fv1hic1535-1me0zxq-1v7udim5lpnaq/4hxq9v6ujrc2lnfh.o (different hash change suppressed)
 ./target/debug/incremental/cargo_chef_build_rs-2vlf5bnbx0alw/s-fv1hic1535-1me0zxq-1v7udim5lpnaq/4uupj05z4896dqcs.o (different hash change suppressed)
 ./target/debug/incremental/cargo_chef_build_rs-2vlf5bnbx0alw/s-fv1hic1535-1me0zxq-1v7udim5lpnaq/5ftd5e3blaqx1nxx.o (different hash change suppressed)
 ./target/debug/incremental/cargo_chef_build_rs-2vlf5bnbx0alw/s-fv1hic1535-1me0zxq-1v7udim5lpnaq/57ajcdm0nmqjkakv.o (different hash change suppressed)
+./target/debug/incremental/build_script_build-1dg36y1peirj1
+./target/debug/incremental/build_script_build-1dg36y1peirj1/s-fv1hhq0s0g-mgocdp.lock
+./target/debug/incremental/build_script_build-1dg36y1peirj1/s-fv1hhq0s0g-mgocdp-252s9dav2g7yb
+./target/debug/incremental/build_script_build-1dg36y1peirj1/s-fv1hhq0s0g-mgocdp-252s9dav2g7yb/dep-graph.bin
+./target/debug/incremental/build_script_build-1dg36y1peirj1/s-fv1hhq0s0g-mgocdp-252s9dav2g7yb/query-cache.bin
+./target/debug/incremental/build_script_build-1dg36y1peirj1/s-fv1hhq0s0g-mgocdp-252s9dav2g7yb/work-products.bin
+./target/debug/incremental/build_script_build-1dg36y1peirj1/s-fv1hhq0s0g-mgocdp-252s9dav2g7yb/1alu3igwgjpty83h.o
+./target/debug/incremental/build_script_build-1dg36y1peirj1/s-fv1hhq0s0g-mgocdp-252s9dav2g7yb/15cnaap0nusqru3d.o
+./target/debug/incremental/build_script_build-1dg36y1peirj1/s-fv1hhq0s0g-mgocdp-252s9dav2g7yb/3kfifkj8wdxdkh6c.o
+./target/debug/incremental/build_script_build-1dg36y1peirj1/s-fv1hhq0s0g-mgocdp-252s9dav2g7yb/3mflj5waub27s7xb.o
+./target/debug/incremental/build_script_build-1dg36y1peirj1/s-fv1hhq0s0g-mgocdp-252s9dav2g7yb/3wc23r6xbtgdruc9.o
+./target/debug/incremental/build_script_build-1dg36y1peirj1/s-fv1hhq0s0g-mgocdp-252s9dav2g7yb/3xt72xavmlqcan9z.o
+./target/debug/incremental/build_script_build-1dg36y1peirj1/s-fv1hhq0s0g-mgocdp-252s9dav2g7yb/34h79aup2rc9ipsk.o
 ./target/.rustc_info.json

That can be categorised as 2 * 2 + 1 sets of files that exist only in a build with build.rs:

Under <target_directory>/build/
a) cargo-chef-build-rs-dde62fe5df47908a/ directory from the run-build-script - build-script-build step
b) cargo-chef-build-rs-4beca2ab97d7a610/ directory from the build-script - build-script-build step
Under <target_directory>/.fingerprint/
a) cargo-chef-build-rs-dde62fe5df47908a/ with run-build-script-build-script-build{,.json}
b) cargo-chef-build-rs-4beca2ab97d7a610/ with build-script-build-script-build{,.json} + 2 files
Under <target_directory>/incremental/

build_script_build-1dg36y1peirj1/ (different -/_ convention and different hash) directory with a hashed subdir with .o and .bin files.

I think we need to re-run both run-build-script and build-script "jobs" of the build-script-build "phase" in the final build (I'm inventing my own terminology here, I would need to study cargo to use the correct one).
It could be actually possible to remove all the added files with a pattern like <target_directory>/**build[-_]script[-_]build**, but that seems a bit crude: it would match also files in {build,.fingerprint}/{libc,bitflags}-*/ which we probably don't want.
So different patterns for the sets 1., 2, and 3. would be needed. Do you know which of these sets the the important ones? If not, I can also find out by trial & error.

I think you can safely ignore the incremental ones, but it's more of a guess than proven knowledge 😅

I think you can safely ignore the incremental ones, but it's more of a guess than proven knowledge 😅

While working on a fix (imminent), I've realized there is a work-around: remove build = "build.rs" mention from Cargo.toml. Cargo auto-detects build.rs is a build script, while cargo chef not. This still needs a proper fix, because that also hurts caching, but at least a build is possible.

While working on a fix (imminent), I've realized there is a work-around: remove build = "build.rs" mention from Cargo.toml. Cargo auto-detects build.rs is a build script, while cargo chef not. This still needs a proper fix, because that also hurts caching, but at least a build is possible.

I seem to be having this issue again with the latest version of cargo-chef. When running on a project that uses a build.rs to generate custom files in the OUT_DIR and then bring them into the project with the include! macro, the compiler is unable to find them. Is there a way around this?


Document that transparent StyleBoxes/textures should be used for UI focus

See https://github.com/godotengine/godot/issues/55146#issuecomment-974675212. The description is fairly lengthy and had to be copy-pasted around, but at least it's exhaustive :slightly_smiling_face:

Have you checked how it looks in the built-in help? We show it inline, and that might be too much for such formatting 😬

We show it inline, and that might be too much for such formatting

If that's the case then maybe the info added in this PR could be added as a note in a separate line/block (e.g. like in Node.name's description). Many properties have such descriptions and I think they are more readable than if they would be shown in a one big block of text (and it looks fine e.g. in the tooltips).

This needs to be rebased.

Have you checked how it looks in the built-in help? We show it inline, and that might be too much for such formatting 😬

btw my concern here is no longer valid, theme item descriptions have been moved to a new line. So should be good.

Thanks!


Some rules complain due to prefix semicolon

Bug Report

TSLint version: 5.8.0
TypeScript version: 2.7.0
Running TSLint via: (pick one) CLI / Node.js API / VSCode / grunt-tslint / Atom / Visual Studio / etc

TypeScript code being linted
let a, b
if (true) 0
;[a, b] = [1, 2]

with tslint.json configuration:
"rules": {
		"semicolon": [true, "never"],
		"align": [true, "statements"],
		"curly": [true, "ignore-same-line"],
		"whitespace": [true, "check-separator"]
}

Actual behavior
ERROR: src/timer.ts[2, 1]: if statements must be braced
ERROR: src/timer.ts[3, 2]: statements are not aligned
ERROR: src/timer.ts[3, 2]: missing whitespace
Expected behavior
No error

A statement spans from its begin until the semicolon or a newline if there is a semicolon inserted by ASI.
0 // this statement ends on the next line after the semicolon
; [a, b] // therefore this statement is not aligned with the other one

This is working as intended, because the rules currently don't support this code style.
Closing as a duplicate of #3201

@ajafff  Is it possible to support prefix semicolon style? Or should I open a separate issue for this?

@hax It would be possible to support this code style for the rules mentioned above. But someone has to submit a PR with the necessary changes.
Since the other issue linked above already describes this problem, I don't think we need another issue to track this.

@ajafff I read the source code of the tests, it already include prefix style (see https://github.com/palantir/tslint/blob/master/test/rules/semicolon/never/test.ts.lint#L135-L145 ), so I'm confused.

@hax That's just the semicolon rule. It doesn't care about your code style. It just looks for unnecessary / required semicolons.
The rules you mentioned above need to be updated to support this specific code style.

@hax There is a workaround:
let a, b
if (true) 0
;
[a, b] = [1, 2]


GUI-Nodes-only branch

Was this branch mentioned in the README.md removed?

Yeah it was pretty much obsolete. I'll have to go back an update the readme.


执行 ./dump.py -l ModuleNotFoundError: No module named 'frida'

python3 dump.py

Hello i also have a same issue and after so many failure i try to use python3 and it works for me.
so please use below command :
python3 dump.py com.test.app


Grant type problem

After I installed the module and applied all the things what was writen in the in the documentation, I recevive "The grant type was not specified in the request" error when I pass the username/password to "/oauth2/token"

Hi,
what error you get when using migration?

Look this issue https://github.com/Filsh/yii2-oauth2-server/issues/7


question: why isn't it tslib distributed together with tsc?

It was a surprise for me I was using tslib indirectly, due to an dependency of another package. When I removed this package, the compilation ceased to build my solution and it took me some time to understand what was going on.
I would expect tslib to be installed together with tsc. On the case this separation makes sense, though, I think tsc could declare it as a peerDependencies, so this would be clearer.

tslib is a "reimplementation" of the helper functions used by TS.
It is used if you do use the tsc option importHelpers.
Or you use noEmitHelpers with manual adding this code.
In all other cases typescript compiler will not use the tslib code but add them on top of each js file when needed.

hey, @HolgerJeromin, you are obviously correct.
My point is that I only understood what was going on after re-reading the documentation for importHelpers. Unfortunately, the problem started after removing a package unrelated to tsc and it took me some time to find the error was being caused by this specific compiler option.
As Npm provides a standard way to ensure packages are present on runtime, using documentation to state "You will need to ensure that the tslib module is able to be imported at runtime" , instead, looks not the best idea to me. It declares what actually should be a dependency in a very fragile way.
Again, I'd expect all code related to TS-JS transpiling to be injected by tsc without implicit dependencies. We all use TypeScript to provide an automated way to describe and verify the correct way to use code; this wouldn't be necessary if we'd preferred to consult documentation ;)

I think this is related to https://github.com/microsoft/TypeScript/issues/37991


Flutter 3 support (Fix Here)

readmore:
    git:
      url: https://github.com/masreplay/readmore.git

readmore:
    git:
      url: https://github.com/masreplay/readmore.git

Support for html tag ?

Fixed in 3.0.0


reconciler and eventhandler framework for service objects

reconciler and eventhandler for service objects
port finalizer utils from aws-app-mesh-controller-for-k8s

/assign m00nf1sh

/lgtm


Add FAB (Floating Action Button) component

props can be position, size, icon, disability.

@saimaheshtaduri add prop type too - similar to this


[BUG]

Release version
v4.1.2
Describe the bug
Extractor pipeline fails with error Setting D:\a_temp\artifacts-from-portal\Artifacts to contents of D:\a\1\artifacts-from-portal\Artifacts failed, Kindly help if im missing something here
Expected behavior
Create pull request should be successful
Actual behavior
Create pull request fails
Reproduction Steps
API_MANAGEMENT_SERVICE_OUTPUT_FOLDER_PATH is set to $(System.DefaultworkingDirectory)/Artifacts, the folder is created over there

2023/04/07 05:53:14 ERROR 2 (0x00000002) Accessing Source Directory D:\a\1\artifacts-from-portal\Artifacts
The system cannot find the file specified.

This looks like an issue specific to your own Devops environment as you're passing incorrect paths. Please do me a favor and look at the closed issues as some people had similar problems in the past and you would find suggestive solutions there.

Managed to sort that issue, now its different
remote:<PHONE_NUMBER>aaTF401027: You need the Git 'GenericContribute' permission to perform this action. Details: identity 'Build\3592ee94-d221-475c-851a-95b62d14b40f', scope 'repository'.
remote: TF401027: You need the Git 'GenericContribute' permission to perform this action. Details: identity 'Build\3592ee94-d221-475c-851a-95b62d14b40f', scope 'repository'.
I have all permissions to contribute to the repo and also manual PR is working, does it have something else to do with? please help

Can  someone please help me on this :( stuck with deliverables

We will try to take a look and get back to you later this week. Please be patient as this is an open source project and we try our best to get to issues when we can.

I tried by seeing the issue #226 the issue not yet solved. Sorry for this silly question here, in publisher.yaml
vmImage: ubuntu-latest        steps:          - template: run-publisher-with-env.yaml            parameters:              API_MANAGEMENT_SERVICE_OUTPUT_FOLDER_PATH: ${{ parameters.API_MANAGEMENT_SERVICE_OUTPUT_FOLDER_PATH }}              RESOURCE_GROUP_NAME : $(RESOURCE_GROUP_NAME)              API_MANAGEMENT_SERVICE_NAME : $(APIM_NAME)              ENVIRONMENT: "Dev"              COMMIT_ID: ${{ parameters.COMMIT_ID }}
What is APIM_NAME here, in variable group we defined source APIM service as  $(API_MANAGEMENT_SERVICE_NAME), this $(APIM_NAME) we defined no where rt? it should be source rt?

Its not printing the app PROD app service name in the configuration, will it be the issue? the Only place I have passed the target app service name is PROD Configuration file

I tried almost everything, fresh commit and then publish even that didnt work. Im not sure about PROD APIM instance configuration, in publisher.yaml/run_publisher_with_Env.yaml. Could you please help configuration.prod.yaml.txt Publisher.yaml.txt run-publisher-with-env.yaml (2).txt Here Soure: azieam1wqi957 Target: azusam1thi518 Its not with commit for sure, it with source and target configuration sommewhere. The documentation is not helping :(

What's not working? What error message are you getting?

That's a fresh commit which has artifacts folder with API, I doubt on Source and target configuration in yaml file. Could you please help to check that.  Extractor uses /home/vsts/work/1/a/artifacts to extract where in publisher root directory is /home/vsts/work/1/s
Now the question is how to fix it? I tried deleting API_MANAGEMENT_SERVICE_OUTPUT_FOLDER_PATH from variable group, ran extractor and publisher pipeline still the behavior is same. :( please see if you help here

Hi, Please see if you get sometime to see this @guythetechie

@guythetechie @waelkdouh waiting for your reply on this please

Ofcourse I understand. I just wanted to let you guys that m waiting for your help!!

We are always aware of the open issues at all times. But when it comes to issues that are not specifically related to the APIiOS tool implementation, but rather it's an issue that is related to the environment of the user that is using the tool then we would have to address it in a best efforts basis when we have capacity. Unfortunately, we do not have any capacity for the next five days or so.

OMG, however thank you for letting me know

##[debug]STDIO streams have closed for tool '/usr/bin/pwsh'
##[debug]task result: Failed
##[error]PowerShell exited with code '1'.
##[debug]Processed: ##vso[task.issue type=error;]PowerShell exited with code '1'.
##[debug]Processed: ##vso[task.complete result=Failed;]PowerShell exited with code '1'.
##[debug]task result: Failed
##[error]PowerShell wrote one or more lines to the standard error stream.
##[debug]Processed: ##vso[task.issue type=error;]PowerShell wrote one or more lines to the standard error stream.
##[debug]Processed: ##vso[task.complete result=Failed;]PowerShell wrote one or more lines to the standard error stream.
##[error]Exception: /home/vsts/work/_temp/69e1c8c3-5fd9-4a35-8b9b-cb683198fde4.ps1:8
Line |
8 |  if ($LASTEXITCODE -ne 0) { throw "Running publisher failed."}
|                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| Running publisher failed.
Think, im in correct stage now. Its searching for the files in /home/vsts/work/1/a/Artifacts. I have deleted the variable from the variable group still facing same issue

Its wired seeing this now. In my publisher pipeline, the write config file name and write apim service name gets printed however publisher pipeline picks source resource group and apim  pubishes once again ther. Am I missing something here?


Improve error message in pip install dbt

Starting in v1.0.0, pip install dbt will raise an explicit error:
As of v1.0.0, `pip install dbt` is no longer supported.
  Instead, please use either:
    - `pip install dbt-core`, for core functionality
    - `pip install dbt-<adapter>`, to use dbt with your database, platform, or query engine
  See full list: https://docs.getdbt.com/docs/available-adapters

The goal here is clarity for what users should do as a next step. In https://github.com/dbt-labs/dbt-core/pull/4133#issuecomment-962730765, @joellabes rightly pointed out that the first line is confusing. We expect that >95% of users will want to use the second.
Let's reorder and alter the wording in this error to something like:
As of v1.0.0, `pip install dbt` is no longer supported.
Instead, please use one of the following:

**To use dbt with your specific database, platform, or query engine:**

    pip install dbt-<adapter>

    See full list: https://docs.getdbt.com/docs/available-adapters

**For developers of integrations with dbt Core:**

    pip install dbt-core

    Be advised, dbt Core's python API is not yet stable or documented
    https://docs.getdbt.com/docs/running-a-dbt-project/dbt-api

**For the previous behavior of `pip install dbt`:**

    pip install dbt-core dbt-postgres dbt-redshift dbt-snowflake dbt-bigquery

I think we should feel comfortable taking up more screen real estate, since this is the only real thing folks will see when they run pip install dbt.

@joellabes What do you think of the proposed message above? Open to any/all wordsmithing suggestions!

Yep I'm 100% happy with this! I was originally going to suggest swapping pip install dbt-adapter to pole position, but it wouldn't have made sense with the old layout.


Simplify error strings file

Simplify various small things in the error strings file.
Part of work on #165.

@bkutil

+1


mitosis & react-gtk

Hi all! I was thinking of including react-gtk in mitosis for this. So... What do you all think of this idea? Is it possible to write with mitosis - gtk visual components to facilitate the creation of mockups, prototypes, webapps in a linux environment natively?
example
import React, { Component } from 'react';
import { render, Button, Box } from '@react-gtk/binding';

class App extends Component {
  render() {
    return (
      <Box>
        <Button label="One" />
        <Button label="Two" />
      </Box>
    );
  }
}

render(<App />, 'My App');

Our docs on generators are not perfect yet, but take a look here: https://github.com/BuilderIO/mitosis/blob/main/developer/generators.md
I doubt we would add this to the codebase at this moment, but you're free to build your own custom react-gtk generator for your use-case!


[4.0] "Cannot assign a new value to a constant" referring to a variable in another script

Godot version: Godot Engine v4.0.dev.custom_build. db5ea78b7
OS/device including version: N/A for this issue
Issue description: After correcting the issues causing the crashes in #41597 the project was able to be imported into Godot 4.
However, attempting to run the project causes a Cannot assign a new value to a constant error message in scn_preload, line 12: helper_functions._whocares = helper_functions.change_scene ("res://Scenes/testing_world.tscn")
_whocares is defined in helper_functions.gd.
I'm uncertain if this is a bug or an intended change.
(Uncertain if this is related, but I've also noticed Godot giving SCRIPT ERROR: Parse Error: Cannot get member "bus_index" from "[AudioStreamPlayer:144871264621]" in jingle_player.gd line 43; probably similar errors with music_player.gd and sound_player.gd.)
Steps to reproduce: Import and try to run the project.
Minimal reproduction project:
41618_Demonstrator.zip

I could not reproduce this, it might have been fixed in the latest batch.


support more date inferences in the csv reader

Is your feature request related to a problem or challenge?
given a csv
mm/dd/yyyy,mm-dd-yyyy,dd/mm/yyyy,dd-mm-yyyy,yyyy/mm/dd,yyyy-mm-dd
01/01/2012,01-01-2012,01/01/2012,01-01-2012,2012/01/01,2012-01-01
02/02/2013,02-02-2013,02/02/2013,02-02-2013,2013/02/02,2013-02-02
03/03/2014,03-03-2014,03/03/2014,03-03-2014,2014/03/03,2014-03-03
04/04/2015,04-04-2015,04/04/2015,04-04-2015,2015/04/04,2015-04-04
05/05/2016,05-05-2016,05/05/2016,05-05-2016,2016/05/05,2016-05-05
06/06/2017,06-06-2017,06/06/2017,06-06-2017,2017/06/06,2017-06-06
07/07/2018,07-07-2018,07/07/2018,07-07-2018,2018/07/07,2018-07-07

currently only the last column will get converted to a Date32
❯ SELECT
  arrow_typeof("mm/dd/yyyy") AS "mm/dd/yyyy",
  arrow_typeof("mm-dd-yyyy") AS "mm-dd-yyyy",
  arrow_typeof("dd/mm/yyyy") AS "dd/mm/yyyy",
  arrow_typeof("dd-mm-yyyy") AS "dd-mm-yyyy",
  arrow_typeof("yyyy/mm/dd") AS "yyyy/mm/dd",
  arrow_typeof("yyyy-mm-dd") AS "yyyy-mm-dd"
from 'testdata/csv/dates.csv' limit 1;
+------------+------------+------------+------------+------------+------------+
| mm/dd/yyyy | mm-dd-yyyy | dd/mm/yyyy | dd-mm-yyyy | yyyy/mm/dd | yyyy-mm-dd |
+------------+------------+------------+------------+------------+------------+
| Utf8       | Utf8       | Utf8       | Utf8       | Utf8       | Date32     |
+------------+------------+------------+------------+------------+------------+

Describe the solution you'd like
it'd be nice to auto detect more of these formats. I thought at the very least YYYY/MM/DD or DD/MM/YYYY would be valid as they are both extremely common.
Describe alternatives you've considered
there really arent any good alternatives as there aren't any ergonomic ways to cast the utf8 field to date32 through the sql interface.
Additional context
No response

take

This has better to be done in arrow-rs, I would open a PR there

filed https://github.com/apache/arrow-rs/pull/5444#issue-2160169292 to solve it.


Double flip data enhancement in voxelnext not working.

Hi, @yukang2017. thanks for the great work you do. I have a question for you.
I want to add double flip in voxelnext, so I use the configuration file "cbgs_voxel0075_voxelnext_doubleflip.yaml" in openpcdet, but at this point the program reports an error. The number of 'hm' in predict and target are not consistent. Can you please tell me how to solve this problem.

More specific information about the error reported is as follows:
File "/home/VoxelNext4Allen/tools/train.py", line 231, in
main()
File "/home/VoxelNext4Allen/tools/train.py", line 177, in main
train_model(
File "/home/VoxelNext4Allen/tools/train_utils/train_utils.py", line 276, in train_model
accumulated_iter = train_one_epoch(
File "/home/VoxelNext4Allen/tools/train_utils/train_utils.py", line 116, in train_one_epoch
loss, tb_dict, disp_dict = model_func(model, batch)
File "../pcdet/models/init.py", line 42, in model_func
ret_dict, tb_dict, disp_dict = model(batch_dict)
File "/home/anaconda3/envs/pcdet/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1102, in _call_impl
return forward_call(*input, **kwargs)
File "../pcdet/models/detectors/voxelnext.py", line 16, in forward
loss, tb_dict, disp_dict = self.get_training_loss()
File "../pcdet/models/detectors/voxelnext.py", line 28, in get_training_loss
loss, tb_dict = self.dense_head.get_loss()
File "../pcdet/models/dense_heads/voxelnext_head.py", line 263, in get_loss
hm_loss = self.hm_loss_func(pred_dict['hm'], target_dicts['heatmaps'][idx])
File "/home/anaconda3/envs/pcdet/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1102, in _call_impl
return forward_call(*input, **kwargs)
File "../pcdet/utils/loss_utils.py", line 462, in forward
return self.neg_loss(out, target)
File "../pcdet/utils/loss_utils.py", line 319, in neg_loss_sparse
pos_loss = torch.log(pred) * torch.pow(1 - pred, 2) * pos_inds
RuntimeError: The size of tensor a (227324) must match the size of tensor b (63320) at non-singleton dimension 0


Fix variable substitution

Add pretty back in to give us variable substitution.
This is really overkill, but I don’t want to fix all the substitution
methods yet.

@jabubake FYI / PTAL


[Feature request] Tests that incorporate multiple rules, to make sure they don't conflict

It might be nice if the html-eslint repo included tests that supported multiple rules, or a whole .eslintrc. This would help us make sure rules don't conflict with each other.
It would also be nice if these tests could be run against a separate .html file, as opposed to needing to paste the code as { code: "" } inside a .test.js file.
For example, as part of html-eslint's test suite, I'd love to be able to test the complete HTML of a sample webpage with a specific .eslintrc configuration and make sure that it throws the expected linting errors.
I'm more than happy to contribute some of these tests myself, just first want @yeonjuan's guidance on where in the repo to put them and how to structure them so that it aligns with his vision. Thanks! :)

Hi @RobertAKARobin Thanks for the suggestion! 👍 👍
What do you think about creating a new directory in the root for the tests?
/
 |- /tests
     |- /[test-name]
        |-  /.eslintrc
        |-  /.source.html

If you already have a structure in mind, we'd love to hear about it!

@yeonjuan Sounds fine by me. I just noticed /integration-test-projects. Is that intended for something like this?

@RobertAKARobin
/integration-test-projects is a directory for testing compatibility with eslint versions. You can use this as it is or create a new directory. 👍


Command blocks & Structure blocks not working

When I do one of the following things I get this error:

Changing a commandblock between Impulse/Chain/Repeat:
http://pastebin.com/raw/Hjvny3KK

Changing a commandblock between Unconditional/Conditional:
http://pastebin.com/raw/C23qvbQi

Changing a structure block between Save/Load/Data/Corner mode:
http://pastebin.com/raw/QpW4tUBe

Spawning in a repeating command block works, and changing a commandblock between Needs redstone/Always active works too. When an error is thrown the command block does not actually change type.
Sponge version: https://gyazo.com/d9feae3b0b65bcb30e58ca655a8598b7

Closed in https://github.com/SpongePowered/SpongeCommon/commit/8591dea193446ddd4f57607d1f7e440779c37e42.


Two groups of radio buttons explicitly grouped by GroupName have scrollbars

Describe the bug

Two groups of radio buttons explicitly grouped by GroupName have scrollbars that cannot be scrolled and so shouldn't be there.
Steps to reproduce the bug

Steps to reproduce the behavior:

Disable automatically hide scroll bars in Windows
Go to RadioButton control

Expected behavior

No scrollbars
Actual behavior

There are scrollbars
Screenshots

Version Info

Gallery version (found on Settings page):

<IP_ADDRESS>
Windows 10 version:

[ ] Insider Build (xxxxx)
[x] May 2020 Update
[x] November 2019 Update (18363)
[ ] May 2019 Update (18362)
[ ] October 2018 Update (17763)
[ ] April 2018 Update (17134)
[ ] Fall Creators Update (16299)
[ ] Creators Update (15063)
[ ] Anniversary Update (14393)

Device form factor:

[x] Desktop
[ ] Mobile
[ ] Xbox
[ ] Surface Hub
[ ] IoT

Additional context

@stmoy RadioButtons does not have ScrollViewer in its template. I believe we are seeing the ScrollViewer from the app. VerticalScrollbarVisibility can be set to hidden.
https://github.com/microsoft/Xaml-Controls-Gallery/blob/b68f65f64be67eff7c139149a3f7181b2cb5ac59/XamlControlsGallery/ControlPages/RadioButtonPage.xaml#L49


Add docs support for sa and note tags

This adds support see also tags (sa) and note tags. The sa tag groups all marked lines as bullet points under a heading See Also as requested by #180
The notes render as a gitbook note (ie > **Note** Some text). The problem is that you can only have single line notes - multi-line notes render as separate notes.
It may be better to render these JUST like see also (under their own heading). Thoughts?

Coverage remained the same at 17.476% when pulling a787828f3743247c71fbd9639a8466310c02d9f5 on hamishwillee:docs_enhancements into 61dce08ea9a20945fced580736dc7f72c0ed90ea on dronecore:develop.

Modified so that notes render like see alsos - as bulleted list under a "Notes" heading. This is more robust in terms of the input it can handle.
Complicated notes could still break this, because the bulleting is markdown, not html.

Coverage remained the same at 17.476% when pulling 27d0e508d2cac891793e22fa47dd4c3872c18cdc on hamishwillee:docs_enhancements into 91b1f665ca4530f1dc4384e9900629aefa414238 on dronecore:develop.


GitLog page should show names of remote branches

Currently only local branches are listed.
List remote branches and update each node with the branch names.
Also show remotes with an icon to differentiate their type, remotes or heads.
Show each branch with their respective color as well, the same color as the log tree nodes.
After #9 a new ToggleButton is added which could be used to toggle if remotes should be visible or not in the tree. Add a ToggleButton in the toolbar which toggles this if applicable.

Fixed in #50


fix user view style (broken)

based on the repos search style view adapt it to users search

file to change :  result_user_search.js  and maybe check files in the folder styles


add .explain() to supported statements & ExplainPlugin.

EXPLAIN statement is supported in all 3 base dialects (postgres, mysql, sqlite). Helpful when working on new designs and queries, or optimizing existing ones.
When we abstract away our queries with query builders, such as Kysely, we are distancing ourselves from being able to debug and tinker with our designs and queries with ease. It suddenly requires us to either:

copy-paste our Kysely code, replace .execute() with .compile().
add query logging in Kysely constructor, execute for real, copy-paste logged query.

and then add explain stuff manually, execute raw sql with sql component OR copy-paste logged sql into database client. Go back to migration code and modify or add stuff like indexes OR go back to query code and improve the query. And back and forth..
Feels like DX could be improved here.
What if we could just quickly comment out .execute() and replace it with .explain() whenever we want to have a look at the execution plan?
(while working on this, for a very long time .explain() was not an alternative to .execute(), but a part of the method chain before executing, but the typescript changes required to make its return type bubble up until the execute call, regardless of chain order [e.g. selectAll would extend it unless there's some generics flag telling it not to], are not worth it at all).

tldr
This PR adds the ability to add explain statement right before select/insert/update/delete/replace keywords.
This can be done by adding .explain() to your query (instead of .execute()):
const explained = await db
    .selectFrom('person')
    .selectAll()
    .where('gender', '=', 'female')
    .explain('json')

explain format=json select * from `person` where `gender` = ?

You can also pass the expected row type .explain<MysqlExplainJsonResult>()

This is a nice feature and a good addition. Thank you once again!
Ther separate explain method as an alternative to execute was a great design choice 💯
I don't think the plugin is a good idea though. It only makes sense to use the plugin to globally enable explaining, but you can't actually run the code as all queries now return the explain data and not the actual data. Also all output types will be wrong.

Thanks! 😃


[feature idea] inherits, class inheritance assertion operator

Suggestion
🔍 Search Terms
N/A
✅ Viability Checklist

My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion
This would allow authors to make class types that inherit from other types. This is similar to extends, but has no runtime effect, and serves for the purpose of asserting that a class does inherit certain members that are not explicitly defined.
The effect is very similar to implements, but the difference is implementation is not required. Another difference is that with inherits it can accept class types (so the class that has inherits will inherit accessibility and other class features).
📃 Motivating Example
This allows us to create type definitions for certain JavaScript patterns that are too dynamic for TypeScript. For example:
import {methods} from 'some-plain-JS-project'

function copyMethods(obj: object, methods: Record<string, Function>): void {
  for (const prop in methods) {
    if (typeof methods[prop] !== 'function') continue
    obj[prop] = methods[prop]
  }
}

declare class SomeMethods {
  spaces(n: number): string
  protected isSomething(o: HTMLElement): boolean
}

class MyClass extends HTMLElement inherits SomeMethods {
  connectedCallback() {
    this.spaces(5) // ok
    this.isSomething(document.body) // ok
  }
}

copyMethods(MyClass.prototype, methods)

const m = new MyClass

m.spaces(5) // ok
m.isSomething(m) // Type error, isSomething is protected.

💻 Use Cases
Various times when type defs can not be made for dynamic plain JS patterns.
Caveat
The only problem is, this is not type safe. It's a type assertion basically. But it is not necessarily worse than declareing a class and using it in extends, which also will give a runtime error.

This already exists; write
class MyClass extends HTMLElement {
  connectedCallback() {
    this.spaces(5) // ok
    this.isSomething(document.body) // ok
  }
}
interface MyClass extends SomeMethods { }

This already exists; write
class MyClass extends HTMLElement {
  connectedCallback() {
    this.spaces(5) // ok
    this.isSomething(document.body) // ok
  }
}
interface MyClass extends SomeMethods { }


zed-editor: 0.146.3 -> 0.146.4

Description of changes
Changelog: https://github.com/zed-industries/zed/releases/tag/v0.146.4

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.


Update release readme to match the current process

What type of PR is this?
/kind documentation
What this PR does / why we need it:
This updates the image promotion process to utlize the cip-mm helper.
We also now promote the manifest as well as all available architectures,
which is now reflected within the docs, too.
Which issue(s) this PR fixes:

Refers to #353
Does this PR have test?
None

Special notes for your reviewer:
/hold for v0.3.0
Does this PR introduce a user-facing change?

None

Codecov Report

Merging #416 (3c9eae4) into master (69231ca) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #416   +/-   ##
=======================================
  Coverage   38.00%   38.00%
=======================================
  Files          20       20
  Lines         950      950
=======================================
  Hits          361      361
  Misses        574      574
  Partials       15       15

/hold cancel


Add support for jQuery themes

What is about the support of jQuery Themeroller? I think this pull request did it https://github.com/select2/select2/pull/2519
Popular web libraries uses jQuery Themeroller for styling components / widgets, ...

By the way, I would split one big CSS file in two smaller: one for layout and one for theming settings. Maybe select2.layout.css and select2.skin.css or select2.css and select2.skin.css?

In theory this should be possible in Select2 4.0, because it brings in direct support for custom themes. It won't happen in the core though, but we would entertain the idea of endorsing a third-party theme (like we did with the Bootstrap theme).


Workcell msgs

added workcell messages

added some comments on dispenser messages

considering to use workcell-type state messages in the templates as well

made it more obvious that the workcell-type state, request and result messages have common fields
added some more comments

We may want to consider just putting the rmf_dispenser_msgs into the rmf_workcell_msgs package.
I can't think of any particular reason to keep them separate.

cool, that's true, I didn't want to flood message packages like how rmf_msgs turned out, but this seems well-contained for it. I'll make the fixes.


Basic BLS-12-381-pk-in-g1 verify

I think we should have two different BLS sig scheme structs for the two G1/G2 options for readability and avoid any misuse.

@kchalkias Do you mean to duplicate all the structs we have there now? The reason I chose not to do that was that we do not plan to use this variant of BLS anywhere besides Move, so I'd prefer not to maintain lots of code unless needed. Once we need this variant in our protocols, we could obviously add it and switch.

@huitseeker - it doesn't change the current behavior, it just renames the module name used by the existing code.
@kchalkias - sure, I'll add the other structs tomorrow.

@benr-ml oh, yes! 🤦 sorry, I read too fast and thought you were testing min_pk here.


Add Picture-in-picture

will add a picture in the picture js project

I am a GSSOC'22 participant, I want to work on this issue.

sir, I would like to work on this issue.
Please assign this to me.

its already there


Allow listing of HA users via admin CLI

CLI support for https://github.com/home-assistant/supervisor/pull/4912

The order of fields is somewhat unfortunate, but it is just alphabetical :man_shrugging:
users:
- group_ids:
  - system-admin
  is_active: true
  is_owner: true
  local_only: false
  name: test
  username: test

LGTM!


Terminal printing issues on OS X

The attached screenshot shows example output printed to the screen when launching Gallium (in Terminal not iTerm) and executing a few commands at an LLDB prompt.  The active line in the window on the right hand side within that screenshot is the julia> prompt after the first two LLDB> prompts:

I get the same thing


Should the additional_users output match the order of the additional_users input?

TL;DR
My input looks like this
  additional_users = [
    {
      name            = "admin"
      password        = null
      random_password = true
    },
    {
      name            = "sales"
      password        = null
      random_password = true
    },
    {
      name            = "marketing"
      password        = null
      random_password = true
    }
  ]
}

The output looks like this:
[
  { "name": "admin", "password": "<redacted>" },
  { "name": "marketing", "password": "<redacted>" },
  { "name": "sales", "password": "<redacted>" }
]

I would expect the ordering here to match up. That way in other terraform resources I can use the index of the outputs as values to other inputs. For example, if I want to create a google_bigquery_connection for the sales user I could use
    credential {
      username = module.sql-db.additional_users[1].name
      password = module.sql-db.additional_users[1].password
    }

but additional_users[1] ends up as the marketing user.
Terraform Resources
As noted above, I'm also using https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/bigquery_connection

Detailed design
No response
Additional information
No response

My guess is that this functionality is dictated by this line, which to my (limited) understanding of Terraform creates a map from the ordered list of additional_users.
https://github.com/terraform-google-modules/terraform-google-sql-db/blob/ca9cf76ec2fa57f8410b09ea88cdfb5f3a2b1ab6/modules/postgresql/main.tf#L28
Given that the map is keyed by name, is it safe to say that the ordering will be alphabetical by name?

@kdeggelman thats the nature of maps. You can retrieve them using keys.

I may have made my original question too confusing. Here's my current understanding:

The additional_users input is an array
The additional_users output is an array
The output array is sorted by alphabetical order of the  name attribute.
Unless the input array happens to be sorted this way as well, the ordering of the input and output will be different.

Is that all correct?


[Content] Show how to view the diff when already (accidentially) staged

We should introduce git diff --staged to see changes which are already staged.

We are using tig, so this is just another way to view the diffs. Nevertheless this is documented in the man page of git-diff and does not block ones workflow, as it is already shown how to unstage files.


apt-secure(8)

Hi, I recently flashed debian onto a Snapdragon and RPi4, while doing an apt-get update I received the following error:
N: This must be accepted explicitly before updates for this repository can be applied. See apt-secure(8) manpage for detials..
That's where I stand now, I checked out the error via a quick search and found this... please help.

You’re in the wrong place. This repository is about a program that generates manual pages.
Please see https://www.debian.org/support instead

Thanks for the direction, much appreciated.


Fix #3349 that ccomplete can not handle array cases well.

Codecov Report

Merging #3350 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3350      +/-   ##
==========================================
+ Coverage   76.61%   76.62%   +<.01%
==========================================
  Files          93       93
  Lines      137154   137155       +1
==========================================
+ Hits       105079   105093      +14
+ Misses      32075    32062      -13

Impacted Files
Coverage Δ

src/if_xcmdsrv.c
84.17% <0%> (-0.36%)
:arrow_down:

src/os_unix.c
57.14% <0%> (-0.05%)
:arrow_down:

src/if_py_both.h
76.31% <0%> (ø)
:arrow_up:

src/window.c
81.9% <0%> (+0.03%)
:arrow_up:

src/getchar.c
75.16% <0%> (+0.04%)
:arrow_up:

src/normal.c
74.42% <0%> (+0.07%)
:arrow_up:

src/ex_cmds2.c
82.72% <0%> (+0.09%)
:arrow_up:

src/gui_gtk_x11.c
48.04% <0%> (+0.44%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f6a16f...649e517. Read the comment docs.


log_dict to support ClasswiseWrapper

🚀 Feature
I want to be able to call:
self.my_metrics(y_hat, y)
self.log_dict(self.my_metrics)

where my_metrics is a MetricCollection that includes ClasswiseWrapper metrics. Currently this will fail with an error like:
ValueError: The `.compute()` return of the metric logged as 'val_Accuracy' must be a tensor. Found {'multiclassaccuracy_background': tensor(0.9754, device='cuda:0'),`

An example of how to generate metrics that will currently fail from this PR:
        metric_classes = {
            'Accuracy': Accuracy,
            'F1Score': FBetaScore,
            'JaccardIndex': JaccardIndex,
            'Precision': Precision,
            'Recall': Recall,
        }

        metrics_dict = {}

        # Loop through the types of averaging
        for average in ['micro', 'macro']:
            for metric_name, metric_class in metric_classes.items():
                name = (
                    f'Overall{metric_name}'
                    if average == 'micro'
                    else f'Average{metric_name}'
                )
                params = {
                    'task': 'multiclass',
                    'num_classes': num_classes,
                    'average': average,
                    'ignore_index': ignore_index,
                }
                if metric_name in ['Accuracy', 'F1Score', 'Precision', 'Recall']:
                    params['multidim_average'] = 'global'
                if metric_name == 'F1Score':
                    params['beta'] = 1.0
                metrics_dict[name] = metric_class(**params)

        # Loop through the classwise metrics
        for metric_name, metric_class in metric_classes.items():
            if metric_name != 'JaccardIndex':
                metrics_dict[metric_name] = ClasswiseWrapper(
                    metric_class(
                        task='multiclass',
                        num_classes=num_classes,
                        average='none',
                        multidim_average='global',
                        ignore_index=ignore_index,
                    ),
                    labels=labels,
                )
            else:
                metrics_dict[metric_name] = ClasswiseWrapper(
                    metric_class(
                        task='multiclass',
                        num_classes=num_classes,
                        average='none',
                        ignore_index=ignore_index,
                    ),
                    labels=labels,
                )

        self.train_metrics = MetricCollection(metrics_dict, prefix='train_')

Hi @robmarkcole, thanks for raising this issue, I finally had some time to tackle it.
I have some bad and good news. The bad news is that I do not think it will be possible to directly integrate log_dict with ClasswiseWrapper and MetricCollection in the way you are envision. The good news is that there is still a official way to get it working, but it require some code changes on your side.
Why integrating ClasswiseWrapper with log_dict is not possible
I try to explain my reasoning here to the best of my ability. First of, self.log_dict method is nothing more than a wrapper around the log method:
def log_dict(self, dictionary):
    for k,v in dictionary.items():
        self.log(k,v)

the exact code is here: https://github.com/Lightning-AI/pytorch-lightning/blob/f3f10d460338ca8b2901d5cd43456992131767ec/src/lightning/pytorch/core/module.py#L547-L625
dictionary can either be a standard python dictionary or a MetricCollection. Secondly, self.log only support logging of scalar-tensors, python floats and torchmetric Metrics that return a scalar tensor. It is really the last part that is the blocker here. As an example self.log cannot be used to log the output of ConfusionMatrix because it returns a [num_classes, num_classes] tensor. So when self.log_dict is called on a MetricCollection the individually metrics in the collection needs to be compatible with self.log
Since ClasswiseWrapper converts the output of a metric into a dictionary it is not compatible with self.log. A solution to solve this would be to make self.log compatible with dictionaries, but that would defeat the purpose of self.log_dict. In general I think the self.log/self.log_dict API is considered stable so we cannot really touch that.
How to work around this then
If you take a look at the documentation for logging of torchmetrics in Pytorch lightning there are two official ways:
https://lightning.ai/docs/torchmetrics/stable/pages/lightning.html#logging-torchmetrics

Either call self.log/self.log_dict directly on the metric objects and lightning internally takes care of calling the compute method at the right time. We can call this automatic logging.
Call self.log/self.log_dict on the result computed by calling compute method yourself, similar to any other thing you may want to log. We can call this manual logging.

Currently, this issue is about getting the automatic logging to work with ClasswiseWrapper and self.log_dict. The good news is that it already works in the manual logging way. I tried it out in this PR #2720 and it works because MetricCollection has the feature of unpacking nested dictionaries returned by compute method. Thus, if we have a metric collection like this:
train_metrics = MetricCollection(
    {
        "macro_accuracy": MulticlassAccuracy(num_classes=3, average="macro"),
        "classwise_accuracy": ClasswiseWrapper(MulticlassAccuracy(num_classes=3, average=None)),
    }
)

calling compute does not result in this dictionary nested
{"macro_accuracy": ..., {"multiclassaccuracy_0": ..., "multiclassaccuracy_1": ..., "multiclassaccuracy_2": ...} }

instead it will return a flattened dictionary
{"macro_accuracy": ..., "multiclassaccuracy_0": ..., "multiclassaccuracy_1": ..., "multiclassaccuracy_2": ...}

which can be directly logged using self.log_dict. You can checkout this integration test:
https://github.com/Lightning-AI/torchmetrics/blob/1ba2c85c9f01ce540dd93c5a4539e15422443143/tests/integrations/test_lightning.py#L516-L554
for an example of how this manual logging would look like in Pytorch Lightning using MetricCollection and ClasswiseWrapper.
I hope this is enough feedback on this issue. Else feel free to reopen the issue.

@SkafteNicki thanks for the explanation!
Can you also confirm that if I do not implement _epoch_end hooks I can achieve the same result with
     def validation_step(self, batch, batch_idx):
         preds = torch.randint(0, 5, (100,), device=batch.device)
         target = torch.randint(0, 5, (100,), device=batch.device)

         self.val_metrics.update(preds, target)
         self.log_dict(self.val_metrics.compute(), on_step=False, on_epoch=True) # Only called on_epoch end, and reset is called after

@robmarkcole i am pretty sure you will need the _epoch_end sadly. Reason being that when self.log_dict/self.log receives a metric object it will automatically do aggregation and reset correctly. For the manually logging, when you just provide the scalar tensor values lightning do not know how these "correctly" should be aggregated and thus will take a mean over the logged values, which in some cases is the correct aggregation but in most is not.
The correct way is therefore (for manually logging):
def validation_step(self, batch, batch_idx):
     preds = torch.randint(0, 5, (100,), device=batch.device)
     target = torch.randint(0, 5, (100,), device=batch.device)

     self.val_metrics.update(preds, target)

def on_validation_step_epoch_end(self):
     self.log_dict(self.val_metrics.compute())
     self.val_metrics.reset()

(I actually missed the reset in the integration test because I forgot to test for more than one epoch. If this is not done, values will keep aggregating)

Sorry to jump in, but what about self.log_dict(self.metrics(input, target))?


Support French, Russian, Arabic and Japanese program category names

Describe the solution presented in this issue.
We need to include French, Russian, Arabic and Japanese translations for the default program categories.  As a bonus, we can use this issue to define an easy way to do this if we add more languages in the future.
Additional Context
We will need to get the translation files from Google.
Done when:
What criteria need to be met for the issue to be finished?

[ ] Program categories can be viewed in French
[ ] Russian and Japanese translations are available
[ ] We have defined a process for adding other translations in the future

@melanie-exygy let me know if I can help with this!

@melanie-exygy let me know if I can help with this!

Thanks @dkatzz !  I've already sent the category strings to @avaleske for translation, but I'd love to either work together on this issue or hand it over to you so that I can get back to the North Star.  Let me know if that's a possibility.

We need to include French, Russian, Arabic and Japanese translations for the default program categories. As a bonus, we can use this issue to define an easy way to do this if we add more languages in the future.

Sure, happy to take it!

We need to include French, Russian, Arabic and Japanese translations for the default program categories. As a bonus, we can use this issue to define an easy way to do this if we add more languages in the future.

Sure, happy to take it!

Yay, thanks @dkatzz!  A few thoughts:

It might be easiest to work on this issue in tandem with #8485.
Right now, we're using the database seed tasks (DevDatabaseSeedTask.java and DatabaseSeedTask.java, but I've been wondering if a one-time job might be better suited.  We didn't have the setup for one-time jobs when I was designing this, but now we do.  Just an idea.


about compute dnf

Thank you for your work. I reviewed the training code and found that it seems to be independent of the code for calculating dnf. Is it not necessary to calculate dnf during the training process? Is dnf directly processed on the training set and then used for training? In that case, do we also need to process the test set and validation set in advance? Also, I would like to ask about the training set provided by dire, such as lsun_bedroom, which includes a real set and multiple fake sets. Should these fake sets be trained together or should we only select one?Could you please provide guidance?

Hello，

Precomputing images into DNF during training and validation helps reduce unnecessary inference time, as DNF may be used multiple times throughout the process. It is also necessary to convert them to DNF before validation and testing.
Please use the entire training set.

thanks for your quick reply


Review

fPIC removed when windows
packaged license

Ouch, CI failing hard. I'll take a look.

I don't understand what you mean by "local method not allowed yet". Can you explain?
cmake.configure() is not supposed to be rooted in self.source_subfolder, it's supposed to be rooted in the source folder, which is where the wrapper CMakeLists.txt should be.

Forget it. I thought that there was something bad. But I was wrong. The pure local flow is not supported because of the exports_sources not copied automatically to the source. There is already an issue and a pet implementation to achieve it.

Oh, wow, great to know!


Incorrect margin display in 2D editor viewport

Godot Engine v3.0.alpha.custom_build:
Margins for controls will display incorrectly in the 2D editor viewport. They will run as designed when the game is run, the only problem is in the editor.
Steps to reproduce:

Create an empty project and create a new scene.
Make the root node a Panel and set it's anchor to "Full Rect"
Set the margin for each side of the panel to 0

You should be able to see that, in the display, the panel will not go all of the way to the sides of the camera box but will form a shape in the same aspect ratio of the 2D viewport. Changing the shape of the viewport, by showing or hiding the output panel for example, will change the aspect ratio of the panel in the viewport. Running the game displays the panel as expected.
Link to minimal example project:
IncorrectMargins.zip

im unable to reproduce this.

I could reproduce this once, but it seems to have been fixed indeed.
Closing as fixed.


Add example

Hello.
I have created two jutul decks based on mrst examples. I can add those to this repository.  Examples are available at:
https://github.com/ajikmr/geosx_mrst
Thanks.

Hi, that's great! I think those examples would be a good addition. Would you like to make a pull request?

I have made pull request. Thanks.


removes PrepareOptimizerMixin, moves functionality to ParametersSplitsMixin

Codecov Report

Merging #36 into master will decrease coverage by 0.82%.
The diff coverage is 27.27%.

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
- Coverage   55.20%   54.37%   -0.83%
==========================================
  Files          67       66       -1
  Lines        1846     1795      -51
==========================================
- Hits         1019      976      -43
+ Misses        827      819       -8

Flag
Coverage Δ

#unittests
54.37% <27.27%> (-0.83%)
:arrow_down:

Impacted Files
Coverage Δ

mantisshrimp/models/__init__.py
100.00% <ø> (ø)

...tisshrimp/models/parameters_splits_module_mixin.py
66.66% <20.00%> (-27.78%)
:arrow_down:

mantisshrimp/models/mantis_module.py
100.00% <100.00%> (ø)

mantisshrimp/core/bbox.py
51.35% <0.00%> (-6.79%)
:arrow_down:

mantisshrimp/metrics/metric.py
53.33% <0.00%> (-2.92%)
:arrow_down:

mantisshrimp/core/mask.py
72.22% <0.00%> (-2.78%)
:arrow_down:

...antisshrimp/metrics/coco_metric/reference_utils.py
19.28% <0.00%> (-2.00%)
:arrow_down:

mantisshrimp/metrics/coco_metric/coco_metric.py
25.80% <0.00%> (-1.18%)
:arrow_down:

mantisshrimp/core/record.py
92.68% <0.00%> (-0.66%)
:arrow_down:

mantisshrimp/core/category.py
90.00% <0.00%> (-0.48%)
:arrow_down:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ac2427...a1004af. Read the comment docs.


Variant annotations

closing epic because it isn't tightly scoped enough (should replace with better defined scope)

re-opening and transferring to gnomad_production. This is the epic for gnomad v4 variant annotations (the next epic I'm starting on).


Due-date detection fails with daily notes organized in sub-folders

I'm doing something unusual with Daily Notes's configuration. :)
I'm creating directory structure for my Daily Notes by adding additional elements in the Date Format setting of the Daily Notes plugin. Notice the "current syntax" commentary from Daily Notes…

This ends up creating nested sub-directories by year and month…

Card Board finds my todos in the various files within the current month's directory; those files are in the same sub-directory as today's daily note.
But todos in other sub-directories (eg, in the previous month's 2023-08 which is a sibling to the current month's 2023-09) don't have due-dates set based on their filename. All the todos in the "Undated" column are coming from Daily Notes in my 2023-08 directory…

Possible change?
I'm thinking Card Board is examining the full path for today's daily note. And treating only todos in files in that one directory as having due dates based on the filename. (Which would work fine in the usual situation where the full path to today's daily note is where all daily notes are found.)
Instead, I think Card Board should look only at the Daily Notes's "New File Location" setting to decide if todos due dates get decided by filenames.

Hi and thanks for this.  I've just been trying to replicate and am not having any joy as things seem to be working as I would expect so I am not seeing the issue:

I have the following setup for Daily Notes which looks in line with yours...

I don't suppose you would be able to prepare me a small sample vault which shows the behaviour, zip it up and attach it to the issue so I can see if I can work out what is happening.
Many thanks again

Thanks for the followup. Unfortunately, I've moved on from using this, so I'm not sure I can reproduce it. ¯\_(ツ)_/¯

Thanks for letting me know and no prob at all.  I'll leave the issue open in case someone else has the same or similar issue and can help!
Thank you again and all the best

Hi - I'm getting a similar issue - when I have a task in a daily note, it assigns the due date to be that of the daily note, even the due date is removed.  When you move the task out a file with date title the issue stops.  So, CardBoard seems to be referencing the date in the path even if there's no task emoji.  I realize that this could be helpful for some (a task in a daily note would have the due date of the daily note - but then when you want to assign due dates it is problematic.  An image of my date syntax is below.
Thank you for your help.

Hi @dubyasqrd - Many thanks, I think what you are describing is the intended default behaviour for using CardBoard with daily notes.  It is possible to disable this behaviour so tasks on daily note pages are treated in the same way as tasks on other pages in the vault using this Global Setting:

If you want to keep the default behaviour for most of your tasks (so that they are given the due date of the note), but have the occaistional task you wish to not have a due date when it is on a daily note page, you can remove the due date from individual tasks by including @due(none) on the line of the task.
The latest release (just released today) has added the ability to set the due date of a task by right clicking on a card and either clearing the date to remove the due date or setting whatver date you wish, which makes it easier to do this direct from the CardBaord view.
Hope this helps!

I over looked this in the Global Settings - thank you for the clarification - very helpful.


Run integration tests on travis

@ofrobots PTAL. I've excluded node 4 from the express and restify tests as they do not pass even with our instrumentation. In a follow on PR, i can check failing tests with and without instrumentation and ensure that they are equal allowing us to run on all versions.

I've excluded node 4 from the express and restify tests as they do not pass even with our instrumentation.

Did you mean 'without our instrumentation'?

Yes. Fixed above.

LGTM.


fix: allow to pass single batch number to pipeline_job.sh (#327)

Coverage: 84.309% (-0.01%) from 84.322% when pulling 6773556d9a40f3381e85f3b0a6cd958c3840c5ba on 327-revert-batch-change-for-pipeline_jobsh into 4cd1531c17041d6c843ab55201ec54b1d2b2297c on main.


Switch from PGFPlots.jl to PGFPlotsX.jl

Doesn't need to happen any time soon, but eventually I think we'll make this transition.

PGFPlots.jl is currently at version 2.2. In comparison, PGFPlotsX.jl is currently at version 0.2, which means that the API is not yet stable and changes are not necessarily backwards compatible. I'd like to wait until PGFPlotsX.jl releases 1.0.

I’ll keep an eye on the PGFPlotsX.jl releases: https://github.com/KristofferC/PGFPlotsX.jl/releases
Sent with GitHawk


Add support for Github Enterprise

This PR adds basic support for Github Enterprise through a GITHUB_URL environment variable.

I'll fix up a few things based on your comments but I'm not a go programmer (I'm not a programmer at all, I'm a sysadmin!). This is my first time touching go. :-)

Pretty impressive that you jumped right into a new language!

@nathanleiby it would be great if the support for git enterprise can be merged. This tool can be used widely only if supports enterprise

I started to use this and eventually realized, that there is no support for enterprise :-(

@nathanleiby @Line-Noise any chance this work will be picked up again?

@Line-Noise thanks for starting this so long ago and apologies we weren't able to make it happen at the time.
I'm revisiting this now and have created two new PRs

refactoring the provider: https://github.com/Clever/microplane/pull/73
then adding support for Github enterprise: https://github.com/Clever/microplane/pull/74

I'll close this PR for now, given that the same work lives on in those. Thank you again!
cc @gtorre @VasuBhaskar


game

can you assign me this issue of puzzle game created by html css js.

Sir,
I will send you pr in today evening.
On Thu, 5 Oct, 2023, 1:24 pm Adwait Dash, @.***> wrote:

Done @NaMiKA0305 https://github.com/NaMiKA0305 you can start working
right away
—
Reply to this email directly, view it on GitHub
https://github.com/DhanushNehru/Ultimate-Web-Development-Resources/issues/143#issuecomment-1748313789,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXNWPLYMMTJOTXH2KDCPCZ3X5ZRU7AVCNFSM6AAAAAA5TEBVIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBYGMYTGNZYHE
.
You are receiving this because you were mentioned.Message ID:
<DhanushNehru/Ultimate-Web-Development-Resources/issues/143/1748313789@
github.com>

Sir,
at the time of sending pull request i am facing these issues. plzz help me
to resolve it.
[[remote: Permission to DhanushNehru/Ultimate-Web-Development-Resources.git
denied to NaMiKA0305.
fatal: unable to access '
https://github.com/DhanushNehru/Ultimate-Web-Development-Resources.git/':
The requested URL returned error: 403]]
On Thu, 5 Oct 2023 at 13:24, Adwait Dash @.***> wrote:

Done @NaMiKA0305 https://github.com/NaMiKA0305 you can start working
right away
—
Reply to this email directly, view it on GitHub
https://github.com/DhanushNehru/Ultimate-Web-Development-Resources/issues/143#issuecomment-1748313789,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXNWPLYMMTJOTXH2KDCPCZ3X5ZRU7AVCNFSM6AAAAAA5TEBVIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBYGMYTGNZYHE
.
You are receiving this because you were mentioned.Message ID:
<DhanushNehru/Ultimate-Web-Development-Resources/issues/143/1748313789@
github.com>

sir, i sent you my pr. but it is saying for your review. plzz pass it.
On Thu, 5 Oct 2023 at 15:03, ANAMIKA SHUKLA @.***>
wrote:

Sir,
at the time of sending pull request i am facing these issues. plzz help me
to resolve it.
[[remote: Permission to
DhanushNehru/Ultimate-Web-Development-Resources.git denied to NaMiKA0305.
fatal: unable to access '
https://github.com/DhanushNehru/Ultimate-Web-Development-Resources.git/':
The requested URL returned error: 403]]
On Thu, 5 Oct 2023 at 13:24, Adwait Dash @.***> wrote:

Done @NaMiKA0305 https://github.com/NaMiKA0305 you can start working
right away
—
Reply to this email directly, view it on GitHub
https://github.com/DhanushNehru/Ultimate-Web-Development-Resources/issues/143#issuecomment-1748313789,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXNWPLYMMTJOTXH2KDCPCZ3X5ZRU7AVCNFSM6AAAAAA5TEBVIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBYGMYTGNZYHE
.
You are receiving this because you were mentioned.Message ID:
<DhanushNehru/Ultimate-Web-Development-Resources/issues/143/1748313789@
github.com>

Can you please mention the PR no. @NaMiKA0305 ??
And send me a screenshot of your result ?
And are all issues solved??

Yes, all issues are resolved.
On Thu, 5 Oct, 2023, 6:22 pm Adwait Dash, @.***> wrote:

Can you please mention the PR no. @NaMiKA0305
https://github.com/NaMiKA0305 ??
And send me a screenshot of your result ?
And are all issues solved??
—
Reply to this email directly, view it on GitHub
https://github.com/DhanushNehru/Ultimate-Web-Development-Resources/issues/143#issuecomment-1748839530,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXNWPL6YL23VCLT67TGIVNLX52URFAVCNFSM6AAAAAA5TEBVIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBYHAZTSNJTGA
.
You are receiving this because you were mentioned.Message ID:
<DhanushNehru/Ultimate-Web-Development-Resources/issues/143/1748839530@
github.com>

can you assign me the issue of tic tae toe game using java

@Mansi782 done

@epicadidash can you please review and merge my tictactoe using java and please pass it

I also want to make a game and contribute in this repo. Please ASSIGN me


Theme Updates

Reference Issues or PRs
N/A
What does this implement/fix?
Put a x in the boxes that apply

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds a feature)
[ ] Breaking change (fix or feature that would cause existing features not to work as expected)
[ ] Documentation Update
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[x] Other (please describe):

Testing

[x] Did you test the pull request locally?
[ ] Did you add new tests?

Documentation
N/A
Screenshots

Any other comments?

This is a temporary update to the jhub-apps theme

No longer needed, updates made to nebari to better support theming


[GSSoC'23]chore: project addition by Bhumica

Add a new project to the list
I have added CodePen clone. CodePen is an online community for testing and showcasing user-created HTML, CSS and JavaScript code snippets. It functions as an online code editor and open-source learning environment, where developers can create code snippets, called pens and test them.
It provides the users, to test their codes using 3 different Languages, namely, HTML, CSS, JAVASCRIPT.

Record

[X] I agree to follow this project's Code of Conduct
[X] I want to work on this issue

We are not providing any labels for project additions as they are not associated with solving any issues. @BhumicaPG


docs: Icon Documentation

Closes #24

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

GitHub release
v1.0.0

Your semantic-release bot :package::rocket:


Misc fixes to README

This makes a few changes to the README:

Changes from MSDN to MDN as more universally used. The one exception is X-Download-Options which is not on MDN as MS specific.
Adds note about X-XSS-Protection support.
Removes note about >=IE9 for x-Content-Type-Options as not just IE
Removed X-Download-Options from default config as this is not correct as per #43
Fixes Feature Policy link
Adds some more info about Feature Policy as not just Chrome and Safari now, and also looks like this has been renamed Permission Policy (though browsers don't support this yet so this extension shouldn't either).

Coverage remained the same at 100.0% when pulling a0832efa42361ff4bf3fb44173cd0abb629ba1db on bazzadp:docs_update into 9564be7d1c2e9cef9c7b62d72abffe758eb6e69e on GoogleCloudPlatform:master.


Show Password Toggle Icon is not displaying correctly

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have read the contributing guidelines

Describe the issue

Reduced test cases
https://modus-web-components.trimble.com/?path=/story/user-inputs-text-input--default&args=type:password
What operating system(s) are you seeing the problem on?
Windows
What browser(s) are you seeing the problem on?
Microsoft Edge
What is the issue regarding ?
Modus Web Components Website (Storybook)
What version of npm package are you using ?
n/a
Priority
Medium
What product/project are you using Modus Components for ?
Modus
What is your team/division name ?
Modus
Are you willing to contribute ?
Yes
Are you using Modus Web Components in production ?
https://modus-web-components.trimble.com/

Fixed now - thanks Sam!


issue-#215 - fix the step validator

it is caused by a precision error when substracting.

Thanks, @codisart!


python3Packages.aiogram: 3.8.0 → 3.10.0

Description of changes
https://github.com/aiogram/aiogram/releases
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 325660 run on x86_64-darwin 1

4 packages built:

python311Packages.aiogram
python311Packages.aiogram.dist
python312Packages.aiogram
python312Packages.aiogram.dist

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4234


Fixes #62

Line continuation operators weren't working in type definition statements inside derived type definition constructs when no variable names were given. This commit fixes this issue bringing derived type type definitions in line with those in other scopes.

Thanks, once again :)
Le jeu. 22 oct. 2015 03:02, David Parkinson<EMAIL_ADDRESS>a
écrit :

Merged #63 https://github.com/dparkins/language-fortran/pull/63.
—
Reply to this email directly or view it on GitHub
https://github.com/dparkins/language-fortran/pull/63#event-442156386.


[HTTP] When Apache Http Client is missing in classpath then JDK built-in one is silently selected.

Describe the bug
Http client provider is silently fallback to URL Connection client from JDK.
Steps to reproduce

Create application without apache http client dependency
Run application and connect to CH cloud
Execute "select hostname()" with same client several times consequently.
If apache http client is used - then host name in most times will be the same.

Expected behavior

user should be notified if failover to not selected http client happens
log warning should be printed if no apache http client is present in classpath while it is selected as client provider

I actually see a warning in my logs:
2024-05-02T15:49:54.336Z 4cc66bdf97da WARN [com.clickhouse.client.http.ClickHouseHttpConnectionFactory:164] - Error when creating APACHE_HTTP_CLIENT, fall back to HTTP_URL_CONNECTION
                                                       java.lang.Thread.run                           Thread.java:  829
                         java.util.concurrent.ThreadPoolExecutor$Worker.run               ThreadPoolExecutor.java:  628
                          java.util.concurrent.ThreadPoolExecutor.runWorker               ThreadPoolExecutor.java: 1128
                     java.util.concurrent.CompletableFuture$AsyncSupply.run                CompletableFuture.java: 1700
                      com.clickhouse.client.AbstractClient.lambda$execute$0                   AbstractClient.java:  273
                             com.clickhouse.client.AbstractClient.sendAsync                   AbstractClient.java:  161
                       com.clickhouse.client.http.ClickHouseHttpClient.send             ClickHouseHttpClient.java:   90
                         com.clickhouse.client.AbstractClient.getConnection                   AbstractClient.java:  198
              com.clickhouse.client.http.ClickHouseHttpClient.newConnection             ClickHouseHttpClient.java:   26
              com.clickhouse.client.http.ClickHouseHttpClient.newConnection             ClickHouseHttpClient.java:   56
com.clickhouse.client.http.ClickHouseHttpConnectionFactory.createConnection  ClickHouseHttpConnectionFactory.java:   22
                                            java.lang.ClassLoader.loadClass                      ClassLoader.java:  527
                  jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass                     ClassLoaders.java:  178
                           jdk.internal.loader.BuiltinClassLoader.loadClass               BuiltinClassLoader.java:  581
java.lang.ClassNotFoundException: org.apache.hc.core5.http.ClassicHttpRequest
  java.lang.NoClassDefFoundError: org/apache/hc/core5/http/ClassicHttpRequest


Pair phone with computer once for all with a USB cable, and then always use wireless, even after reboot

Hi,
The procedure https://github.com/Genymobile/scrcpy#wireless works very well. However I noticed that after a computer reboot / phone reboot, just doing:
adb connect <IP_ADDRESS>:5555
scrcpy

doesn't work anymore.
The solution is to connect by USB cable again, and re-do the adb devices,
adb tcpip 5555 process.
Question: is it possible to pair phone and computer forever, such that it's no longer needed to connect them via USB first each time, and always use Wifi connection instead?
PS: my phone IP is fixed (router setting).

Check your developer settings for ADB over Network setting

I have same question.  Could you explain what to look for "developer settings for ADB over Network setting" ?
Thanks so much.

@srevinsaju can you give more details? Where to find these settings, and what to do?

Sorry about that, I couldn't get the screenshot from mobile, I have got a stackoverflow answer, scroll to the bottom,
https://stackoverflow.com/questions/4893953/run-install-debug-android-applications-over-wi-fi

I don't have this option like on the screenshot of the main answer (see the
comment, many people have the same issue).
The only problem is that after a reboot, I have to reuse USB cable again...

Is your android rooted?

Not rooted

You might have to use third party apps to do so. If you were rooted, you could have used scheduling apps to run the command to enable ADB over WiFi without a PC over the root terminal.

I am able to connect to my phone via wifi after shutting down and/or restarting my iMac without plugging in a USB.
I use the following commands:
adb start-server
* daemon not running; starting now at tcp:5037
* daemon started successfully
adb -s <DEVICE_NAME> connect <YOUR_IP>:5555
you should receive the following msg.
connected to <YOUR_IP>:5555
sometimes, on the first few attempts, it times out and you may see a message like this:
failed to connect to '<YOUR_IP>:5555': Operation timed out
but it should connect after a couple of tries, if not the first
to get your device name. Use adb devices when you phone is plugged through USB and it will show in listed devices.

Would you have any idea @rom1v about how to make the pairing computer <--> android phone permanent, and not have to re-connect them by cable after each reboot?
Thanks in advance!

Without root, I think it's not possible. Maybe in Android 11? https://www.xda-developers.com/android-11-native-wireless-adb/

Thanks for your feedback Romain @rom1v !

Would you have any idea @rom1v about how to make the pairing computer <--> android phone permanent, and not have to re-connect them by cable after each reboot?
Thanks in advance!

as a temporary solution you can use this app https://play.google.com/store/apps/details?id=com.ttxapps.wifiadb&hl=en_IN (works only with rooted android device)


Pusher state gets stuck on disconnecting

Steps to reproduce
This happens every so often, usually when I connect and then disconnect rapidly. Normally, from the changedConnectionState(from old: ConnectionState, to new: ConnectionState) function, this gets printed:
Connection changed: ConnectionState(rawValue: 1) -> ConnectionState(rawValue: 2) /// connected to disconnecting
Connection changed: ConnectionState(rawValue: 2) -> ConnectionState(rawValue: 3) /// disconnecting to disconnected

Both lines get printed right after each other. However sometimes Pusher gets stuck on this:
Connection changed: ConnectionState(rawValue: 1) -> ConnectionState(rawValue: 2) /// connected to disconnecting

Later, when I try reconnecting again, the pusher's state is still at ConnectionState(rawValue: 2) (.disconnecting). If I try to call connect nevertheless, I get the Invalid signature: Expected HMAC SHA256 error.
Expected behavior
The changedConnectionState method should be called 2 times after attempting to disconnect (connected → disconnecting, then disconnecting → disconnected). The calls usually happen pretty quickly.
Actual behavior
The second changedConnectionState call never happened.

Hi, we have a known issue 364 where disconnecting and reconnecting repeatedly cases a HMAC SHA256 error. In there I reproduced this by switching between LTE and Wifi while the app's in the background, but you've mentioned just connect and disconnecting. Are you rapidly calling the disconnect() and connect() methods?


Add confound identification/removal

This is a holdover from the 2017 overhaul but needs to be completed. Here are some design objectives:

What confounds do we want?

Motion parameters (we have these, but might want to do derivative/power expansion)
FD (in addition to/instead of the motion parameters? Check what is recommended)
DVars?
aCompCor: terminology for time series consisting of projection onto top spatial PCs across anatomically masks of (deep) white matter and/or CSF
tCompCor: terminology for high variance subcortical voxels?
nCompCor: (my) terminology for the same idea as aCompCor, but using the voxels identified as "locally noisy". These can be gray matter voxels, but likely are corrupted by large vessels.
global signal (whole brain? just gray matter? have both?)

When do we want to extract them?

It would be convenient to get them during preprocessing and then have a text file sitting around that can be used elsewhere. But -- we now do high-pass filtering during the model workflow, and ideally the components derived from the time series data should reflect that filtering.

What kind of visual QC should we do?

This should be fairly straightforward, just a plot of (standardized?) values over time with some common legend for different components. Should we show everything or just what is used in cleanup? (The latter will end up in the design matrix plot, too).

How to parameterize what gets used?

This should be model-level information, and we need to specify both a) what to include and b) confound specific parameters (e.g., derivatives and/or transformations of the motion parameters, number of components for the PCA-baed methods)

How do we make the useful outside the context of the nipype workflows?

i.e. it would be useful to have access to these for ROI analyses. Should happen in the big model fitting node, but should happen via a function that can take images and operate on them.

Useful sources to consider in development:

Nipype confound tools
Methods for detecting resting-state fMRI confounds (Power)
Insight and inference for DVARS (Nichols)
Methods for cleaning the BOLD signal
Neuroimage fMRI denoising special issue


flow-ui online

flow-ui online #113
In order to facilitate everyone to understand and use flow, I wrote a demo with vue.js+element+vue-element-extends+beego and put it on tencent cloud. It is just a preliminary one,at present it has the function of adding, but cant delete and modify.

@3xxx 👍
Thanks so much for this!


Not able to install on macOs ventura 13.0

I followed all the steps in the instruction (install .Net 6 and etc.), but in the end, it shows me this message:

Hi @aliqaryan2
I tried it on my Mac with macOs ventura 13.0, and it worked fine.
Which version of .NET6 did you install? Is it .NET Runtime or .NET SDK ?

I'm having a similar issue on macOS Monterey 12.1:

Works for me on macOS 13.1 using the latest release build.
I had to go to System Settings > Privacy & Security and grant permission to open application and also for all the libraries required by botnet to load. It was a bit of a pain. I believe it can be avoided if the builds were signed by the developer.

Easiest way I've found it to just clone the repo and run manually. A Homebrew solution would be ideal
dotnet run -p ./PurpleExplorer/PurpleExplorer.csproj

Latest release should work with macOS 13+.
Can you guys test it and let me know to close this issue for now.
I'll start a conversation about signing as well.

I hit the same error, I can't run it by policy because the binaries are not signed.


Implement RSpec.current_scope (in 4.0, to switch rspec-rails to it painlessly)

This is a reproduction of #2895 on 4-0-dev branch.
The plan:

Add the method to rspec-core 4.0.0.pre
Update rspec-rails's main branch to use RSpec.current_scope (main depends on 4.0.0.pre of rspec-*)
Merge #2895 (deprecates currently_executing_a_context_hook? and introduces RSpec.current_scope) to rspec-core 3.10-maintenance (will become part of 3.11/3.99)
Send a PR to remove currently_executing_a_context_hook? from 4-0-dev

Is this PR needed? Normally we just cherry-pick the merge commits across?

Cherry-picking is an option, and surely a simpler one.
At least it served its goal to demonstrate that https://github.com/rspec/rspec-rails/pull/2511 is green.

Cherry-picked #2895 to 4-0-dev.