Register

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/37724
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" e70a3f66f83e45c606e27032e594c216b6677fcd
git push origin v0.1.0

@JuliaRegistrator register

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/38260
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.2 -m "<description of version>" dc222919098dbd6930c9c30c856324c740253bb7
git push origin v0.1.2

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/43013
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.0 -m "<description of version>" 0ff4085e86664cd2576b7528b7c3974d58d6e324
git push origin v0.2.0

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/43911
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.1 -m "<description of version>" 818053ab6750722f9ea683fb52d12ed2fab5c16c
git push origin v0.2.1

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/44360
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.3.0 -m "<description of version>" 243eab3c458d81ae23727819a45d768fd9dab714
git push origin v0.3.0

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/44439
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.3.1 -m "<description of version>" a571340f576dc9068ec535934d7f954efb30d170
git push origin v0.3.1

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/44549
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.3.2 -m "<description of version>" e9c03aa29dbf0b4bb5ccf763033dafaa3bf14250
git push origin v0.3.2

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/44895
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.4.0 -m "<description of version>" 8f10171a3dd9068c11610d44da7f2b825434c92a
git push origin v0.4.0

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/44909
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.4.1 -m "<description of version>" 64926f17e3ceee78fb3b11aa8f1fecea79e56bc6
git push origin v0.4.1

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/45138
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.4.2 -m "<description of version>" cdf7cf2654c4bd86023341d369625cdef7ab5538
git push origin v0.4.2

Error while trying to register: Register Failed
@GiggleLiu, it looks like you are not a publicly listed member/owner in the parent organization (TensorBFS).
If you are a member/owner, you will need to change your membership to public. See GitHub Help

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/48822
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.5.1 -m "<description of version>" 81786f150e28f06bdb8735d97d652b7d0d982273
git push origin v0.5.1

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/49579
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.5.2 -m "<description of version>" a8b7b11e76a36c0b16c1e0b1c4abb01b0b916cc4
git push origin v0.5.2

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/49660
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.5.3 -m "<description of version>" 3edc0f864bade0d939a9d19df227e4ba9848946d
git push origin v0.5.3

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/49993
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.6.0 -m "<description of version>" 98120cb8a1603464788860d54f1ddf7ca8582955
git push origin v0.6.0

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/50335
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.6.1 -m "<description of version>" c4fd56cec1b9e51b09822e335d50eb5eee429092
git push origin v0.6.1

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/50772
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.6.2 -m "<description of version>" b3351066cdce35aecbd1fd6a86291688e332bdc0
git push origin v0.6.2

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/51228
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.6.3 -m "<description of version>" 7bf779b8ea86016231e4d7dd1ce5f250707addd8
git push origin v0.6.3

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/51538
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.6.4 -m "<description of version>" 78ba1e7ccb749894eee169e915124ceb51d9e890
git push origin v0.6.4

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/54316
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.6.5 -m "<description of version>" 97e772a84847d359783eb8cb0700a4dfa1d500a2
git push origin v0.6.5

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/55601
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.6.6 -m "<description of version>" ee0fdc14383fba8f5d893edca42fe7ec4f3fc5b9
git push origin v0.6.6

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/59558
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.6.7 -m "<description of version>" f2ce659877b78800bb8ac7a470ce22b3efaca1c3
git push origin v0.6.7

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/59561
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.6.8 -m "<description of version>" e9ba78096245938218c88bff5f3c365e47454a89
git push origin v0.6.8

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/62203
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.6.9 -m "<description of version>" 8ef86dbdfc645380f5f43cc9aae75ac58c0c7bfa
git push origin v0.6.9

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/63978
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.7.0 -m "<description of version>" 75b52008e0d1d8c77306e72b7d8b084a494cc6de
git push origin v0.7.0

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/64071
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.7.1 -m "<description of version>" feb8f2b2e54accee9a019ca40b752d5afef35f83
git push origin v0.7.1

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/67570
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.8.0 -m "<description of version>" cdb5f5da2fd067665798d52bebde700a36fb71ba
git push origin v0.8.0

@JuliaRegistrator register

Registration pull request updated: JuliaRegistries/General/67570
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.8.0 -m "<description of version>" cdb5f5da2fd067665798d52bebde700a36fb71ba
git push origin v0.8.0

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/67580
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.8.1 -m "<description of version>" 27a358c5e47cfde7c72a2765b7c4249b442672b6
git push origin v0.8.1

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/88674
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.8.2 -m "<description of version>" 57923b1a67f8afed313b4ba52b123bda1d36a1f1
git push origin v0.8.2

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/92064
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.8.3 -m "<description of version>" cc2295faae60f813f17d6dfdbf539ced8d138942
git push origin v0.8.3

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/112375
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.9.0 -m "<description of version>" 6f0de4808d961c02766d85b2460491142b5b24c8
git push origin v0.9.0

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/112591
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.9.1 -m "<description of version>" 954fc10861ff9888a0af1a93fcca1d0d6d8aa76f
git push origin v0.9.1

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/113223
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.9.2 -m "<description of version>" 3713c9b623843dc6e39669bfef30c86a4efa9512
git push origin v0.9.2

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/117642
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.9.3 -m "<description of version>" 855d98a72eb96b9145fdb07cc49191749718648a
git push origin v0.9.3


Request: Plotly support in gallery examples

Sphinx-gallery support it:  https://sphinx-gallery.github.io/stable/auto_plotly_examples/plot_0_plotly.html#sphx-glr-auto-plotly-examples-plot-0-plotly-py
PyData them support it: https://pydata-sphinx-theme.readthedocs.io/en/stable/examples/pydata.html#plotly
But for some reason we dont: https://github.com/ansys/pymapdl/pull/2346
Failed attemps: https://github.com/ansys/ansys-sphinx-theme/pull/76

Pinging @ansys/pyansys-core for feedback, ideas, suggestions

Update October 2024: https://github.com/ansys/pymapdl/pull/2346#issuecomment-2413402216


Fix cp -c issue with other volumes

Fixes #1746.

@arrizer can you confirm this fixes your issue?

@brentleyjones just tested with the branch and I did not encounter any errors. Thanks for the quick fix!


Missing property creditorAgentName in single payment

In the table which describes all properties for each payment type there is a property creditorAgentName which is missing in the model paymentInitiation_json (it is commented, why?). According to the description of this property, it is a property which should be around.
We should add (uncomment) this property to the single payment model.

Yes, property will be uncommented.


(WIP) CASSANDRA-16855: Remove json-simple library, use; add a test for StatsPrinter

Fixes https://issues.apache.org/jira/browse/CASSANDRA-16855 (remove "json-simple" use, dependency)
Replaces existing uses of "json-simple" library with that of Jackson which is used for most of json handling already, as well as json-simple dependency; adds a test case for StatsPrinter which had no test coverage

Looks like there's been activity in trunk: some json-lib usage removed (from StatsPrinter), but some added (SASIIndexTest.java). Need to see how to fix, trim.


[Feature-7349] [Python]Add workflow as code task type datax

Purpose of the pull request
close #7349

Brief change log

Delete database task
Extract get database info to core/database and adjust related operations of sql task and produre task
Add datax task and custom datax task

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Hi @devosend I notice that you move class database from task to core, is there any reason or benefit about that?

BTW, please solve the conflicts, Thanks

Could you please add some example about how to use this task type in directory examples? I think this task is a litter complex. WDYT?

i think database is not a kind of task.  In the datax task, it needs two data sources, datasource and datatarget, and the keys in their parameters are also different. Inherited Database class can't meet the demand.

Do you have any other suggestions?

i think database is not a kind of task. In the datax task, it needs two data sources, datasource and datatarget, and the keys in their parameters are also different. Inherited Database class can't meet the demand.

You are right! for now, database do not define any task in DS, and just a base class to get database information from java gateway.

You make a good change 👍

Codecov Report

Merging #7437 (e168fe6) into dev (6cad119) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #7437      +/-   ##
============================================
- Coverage     41.30%   41.29%   -0.01%
- Complexity     3667     3668       +1
============================================
  Files           634      634
  Lines         26411    26411
  Branches       2959     2959
============================================
- Hits          10908    10907       -1
  Misses        14475    14475
- Partials       1028     1029       +1

Impacted Files
Coverage Δ

...r/plugin/registry/zookeeper/ZookeeperRegistry.java
48.64% <0.00%> (-7.21%)
:arrow_down:

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

...inscheduler/common/task/sqoop/SqoopParameters.java
74.00% <0.00%> (ø)

...he/dolphinscheduler/common/enums/SqoopJobType.java
88.88% <0.00%> (+88.88%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cad119...e168fe6. Read the comment docs.


Train model with custom data

Hello there,
I tried this model with SQA_large checkpoints and fine tune the model with SQA after this  I want to train the model with my own custom data. I am curious to know how do I pass my own training data into it. After exploring issue #7 solution I found that first the dataset is converted into tsv file then from tsv to interaction, interaction to tf examples then from tf examples to tf records. I didn't found the solution for converting interaction to tf examples containing training data. Do I need to create my own conversion code or is there any predefined way to do this? Any suggestions? It will be more helpful if you update the colab file with conversion code for dealing custom data.
Thanks
Sparsh Bhawsar

Hi,
There is a function "_create_examples" which converts interaction protos to TF examples:
https://github.com/google-research/tapas/blob/a46b7902866f39eca94e49d9b0f71a5e20ee6c1f/tapas/run_task_main.py#L193
It is called by run_task_main with --mode="create_data" (here) but that also runs the TSV -> interaction which I'm guessing you don't want. The easiest way might be to just import that function and run it from a notebook or a python script:
from tapas import run_task_main

run_task_main._create_examples(
  interaction_dir=INPUT_INTERACTION_DIR,
  example_dir=OUTPUT_EXAMPLE_DIR,
  vocab_file=VOCAB_FILE,
  filename="train",
  batch_size=None,
  test_mode=False)
run_task_main._create_examples(
  interaction_dir=INPUT_INTERACTION_DIR,
  example_dir=OUTPUT_EXAMPLE_DIR,
  vocab_file=VOCAB_FILE,
  filename="dev",
  batch_size=EVAL_BATCH_SIZE,
  test_mode=False)
run_task_main._create_examples(
  interaction_dir=INPUT_INTERACTION_DIR,
  example_dir=OUTPUT_EXAMPLE_DIR,
  vocab_file=VOCAB_FILE,
  filename="eval",
  batch_size=EVAL_BATCH_SIZE,
  test_mode=False)

This needs the interactions to be in a TFRecords files "${INPUT_INTERACTION_DIR}/train", "${INPUT_INTERACTION_DIR}/dev" and "${INPUT_INTERACTION_DIR}/eval" and outputs TF examples to "${OUTPUT_EXAMPLE_DIR}".

I tried this code
I tried this code ! python tapas/run_task_main.py
--task="SQA"
--input_dir="${training_data_dir}"
--output_dir="${output_dir}"
--bert_vocab_file="${tapas_data_dir}/vocab.txt"
--mode="create_data"

I tried this code :

TSV file format :
> nt-1	1   1	Give me value of last date?	table_csv/205_100.csv	['(1052, 1)']   ['1.27E-05']
> nt-1	1   2	Give me value of first date?    table_csv/205_100.csv   ['(0, 1)']   [ '-0.01']
> nt-1  1   3   Show the value of 1/8/2019?     table_csv/205_100.csv   ['(89, 1)', '(90, 1)']  ['-621269.14', '244151.77']
> nt-1  2   0   Show value of 2/8/2019?         table_csv/205_100.csv   ['(93, 1)', '(94, 1)', '(95, 1)'] ['-4330359.93', '-629355.21', '261021.99']

Great to hear! Thanks!

Hi, The questions in SQA are not tagged with None (when answers are directly from the table) or when they aren't. How is it distinguished?

Can you please tell me exact way of passing the answer coordinates, because I am also facing the same issue.


Disable running locally installed executables

Some linters (such as htmlhint) are run from a local (node_modules/.bin) directory close to the file being read. (I didn’t check exactly but I think that’s also the case for python checkers in virtualenv). This makes it dangerous to explore untrusted directories with ALE enabled.
I only ever want to run binaries from trusted directories in my $PATH.
I’m not sure what could be the best way to tackle this issue. This comes to mind:

an option unsafe which must be true to run any local binary, but that’s a bit coarse grain,
an option containing a list of trusted directories (maybe with notification when a potential linter is found which is not in a directory of that list),
a suggestion on how to fix $PATH on the fly (if I used that type of linters, I suppose I would add some autocmd in my .vimrc to add this path in $PATH when I edit a file in the project).

My preference would go to the second option, with the list of trusted directories.

You can configure each linter to only run global variables of executables with the use_global options, like g:ale_javascript_eslint_use_global. Perhaps an option could be added for making this the default for all linters at once.

Running executables and node_modules is the default, as it lets people use the plugin for eslint and so on without any configuration.

Yes, a global use_global option would be nice.

I think I'll support this by changing the default for those options from 0 to get(g:, 'ale_use_global_executables', 0), which will require minimal changes to code, but only be configurable from vimrc. That should make it easy to support this without making the code too complicated.

Now you can disable running locally installed executables by default by setting g:ale_use_global_executables to 1 in vimrc, before Vim is loaded. Future linters will have to respect this option.


Has the comparison algorithm been retrained?

You compared DIM and FBA algorithms. Have you retrained them on the VideoMatte240K, PhotoMatte13K, and Distinctions-646 data sets. Or directly use the pre-trained model provided by the original author to test.

No. Only BackgroundMattingV1 were retrained for comparison

No. Only BackgroundMattingV1 were retrained for comparison
Thank you for your reply. If the training sets are different, might it be unfair? What do you think

No didn't have time to train every methods. Additionally, FBA uses trimap, we already acknowledged with get trimap, then method does better. It was a different category of method and not the focus of our study.

I have an idea, if DIM is jointly trained on three data sets. Can its indicators be better? DIM may also exceed your indicators. In other words, adding a background image can't exceed the existing trimap-based algorithm?
Anyway, BGV2 is still a great job.


fix: Show tooltip on defined widget

Description
Changes proposed in this pull request:

Show tooltip on widget specified in extensibility form
Show tooltip on not specified widget in form

Related issue(s)
https://github.com/kyma-project/busola/issues/2893
Definition of done

[x] The PR's title starts with one of the following prefixes:

feat: A new feature
fix: A bug fix
docs: Documentation only changes
refactor: A code change that neither fixes a bug nor adds a feature
test: Adding tests
chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.

[x] Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
[x] Explain clearly why you created the PR and what changes it introduces
[x] All necessary steps are delivered, for example, tests, documentation, merging

/retest

[ ] add displaying tooltips from CRDs in "normal" views (example: Deployments, CronJobs)
[ ] checks id's to open only one tooltip
[ ] Try to have the link working (stretch)
[ ] add information in docs about overriding description, and information about default description taken from CRD


ENH: enable stats.shapiro() to take n-dimension input, handle nan and assign axis

Reference issue
What does this implement/fix?
Very often scipy is used with Pandas and users might want to verify the normality of multiple columns.
A function that accepts only 1d input and not able to omit np.nan is cumbersome.
Such interface is not consistent with other API like stats.ttest_ind() either.
An improvement is proposed here to handle np.nan according to the given nan_policy.
Operation on a multi-dimension array is possible and can compute along a given axis.
The default behavior remains the same as the old implementation.
Only assigning axis and nan_policy options cause different behavior when handling input array.
Any comment is welcome :D
Additional information

The nightly build fails doesn't seem to have anything to do with my code.
I only change comments and test_matrix_io.py is not modified since the last successful build.
Could you trigger again the build process? @tylerjereddy

scipy/sparse/tests/test_csc.py ......                                    [ 77%]
scipy/sparse/tests/test_csr.py ........                                  [ 77%]
scipy/sparse/tests/test_extract.py ..                                    [ 77%]
scipy/sparse/tests/test_matrix_io.py ......                              [ 77%]
Fatal Python error: Segmentation fault
Current thread 0x00007feccf69d740 (most recent call first):
File "/home/runner/.local/lib/python3.9/site-packages/numpy/core/numeric.py", line 2276 in within_tol
File "/home/runner/.local/lib/python3.9/site-packages/numpy/core/numeric.py", line 2290 in disclose
.....

Thank you

Usually to retrigger the CI we close a PR, wait about 30-60 seconds and then reopen. Doing so should retrigger CI.
Sincerely,
-Lucas Roberts

On Oct 11, 2020, at 4:16 AM, Po-Wen Kao<EMAIL_ADDRESS>wrote:

The nightly build fails doesn't seem to have anything to do with my code.
I only change comments and test_matrix_io.py is not modified since the last successful build.
Could you trigger again the build process? @tylerjereddy
scipy/sparse/tests/test_csc.py ...... [ 77%]
scipy/sparse/tests/test_csr.py ........ [ 77%]
scipy/sparse/tests/test_extract.py .. [ 77%]
scipy/sparse/tests/test_matrix_io.py ...... [ 77%]
Fatal Python error: Segmentation fault
Current thread 0x00007feccf69d740 (most recent call first):
File "/home/runner/.local/lib/python3.9/site-packages/numpy/core/numeric.py", line 2276 in within_tol
File "/home/runner/.local/lib/python3.9/site-packages/numpy/core/numeric.py", line 2290 in disclose
.....
Thank you
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Did scipy.stats switch to axis=None as the default?
In the old times, the statistics/stats default was always axis=0 (for csv/dataframe like data). I haven't paid much attention in a while.

Did scipy.stats switch to axis=None as the default?
In the old times, the statistics/stats default was always axis=0 (for csv/dataframe like data). I haven't paid much attention in a while.

You are right.
But I notice that if I set the default as axis=0, the old code which input 2D-array will not be flattened and cause a compatibility problem.
So two options for default value:

If axis=0, then will cause the compatibility problem
If axis=None, the API interface is not consistent

I didn't look carefully enough to see that there was a ravel.
It sneaked in 5 years ago "Improve implementation details"

@josef-pkt @rlucas7  Do you have a preference for either options or better ideas? :D

Did scipy.stats switch to axis=None as the default?
In the old times, the statistics/stats default was always axis=0 (for csv/dataframe like data). I haven't paid much attention in a while.

You are right.
But I notice that if I set the default as axis=0, the old code which input 2D-array expects the array to be flattened. However, this is not the case in the new API. Only when axis=None, the input array will be flattened.
So two options for default value:

If axis=0, then will cause the compatibility problem
If axis=None, the API is not consistent

I leave backwards compatibility decisions to current maintainers.
I strongly prefer the consistent axis=0 as default, which is also the main application in the original motivation in first comment.

I didn't look carefully enough to see that there was a ravel.
It sneaked in 5 years ago "Improve implementation details"

Hmm, preference here is to go through a round of deprecation warnings even though it is inconsistent behavior. Reasoning is that it's been around in the codebase for 5 years, so someone might have code that relies on the existing behavior. If there had only been 1 or 2 releases since the behavior was added the perspective might be different. Even though it is a non-consistent default behavior that we want to change we'll need to notify consumers of the package in advance that we'll no longer support he current behavior.  I'll add some comments inline of the PR to indicate the changes to accommodate what I'm proposing.

@hp5588 Thanks for submitting this. I wonder what you think of a different approach.
Since this ends up calling np.apply_along_axis rather than vectorizing the computation at a lower level, I think we could achieve the same thing by taking the core of what you have and creating a decorator out of it:
from functools import wraps  # so that wrapper preserves docstring

def _vectorize_1s_hypotest_factory(result_creator):
    def vectorize_hypotest_decorator(hypotest_fun_in):
        @wraps(hypotest_fun_in)
        def vectorize_hypotest_wrapper(x, *args, axis=0,
                                       nan_policy='propagate', **kwds):

            x = np.atleast_1d(x)

            # Addresses nan_policy="raise"
            _, nan_policy = scipy.stats.stats._contains_nan(x, nan_policy)

            # Addresses nan_policy="omit"
            if nan_policy == 'omit':
                def hypotest_fun(x, *args, **kwds):
                    x = x[~np.isnan(x)]
                    return hypotest_fun_in(x, *args, **kwds)
            else:
                hypotest_fun = hypotest_fun_in

            x = np.moveaxis(x, axis, -1)
            res = np.apply_along_axis(hypotest_fun, axis=-1, arr=x)
            return result_creator(res)

        return vectorize_hypotest_wrapper
    return vectorize_hypotest_decorator

Then the decorator could be applied to the shapiro function, which doesn't have to be modified at all:
def _shapiro_result_creator(res):
    return ShapiroResult(res[..., 0], res[..., 1])

@_vectorize_1s_hypotest_factory(_shapiro_result_creator)
def shapiro(x):
   ...

One advantage is that because we are not modifying the shapiro function, it is less likely for us to make a mistake that would change the way shapiro works on a 1d input. That makes it easier to review, IMO.  Another advantage is that the same decorator can be applied to other 1 sample tests, such as jacque_bera, or some other one sample statistics functions without modification. Of course, once we've reviewed the decorator code once, it makes reviewing the application of the decorator to other functions very easy (compared to reviewing the modification of each function separately).
What do you think? I have a PR that proposes a strategy like this for n-sample tests (well, just two right now, but it generalizes) in gh-13312, but I think it would make sense to have something special for 1d.

@hp5588 Thanks for submitting this. I wonder what you think of a different approach.
Since this ends up calling np.apply_along_axis rather than vectorizing the computation at a lower level, I think we could achieve the same thing by taking the core of what you have and creating a decorator out of it:
from functools import wraps  # so that wrapper preserves docstring

def _vectorize_1s_hypotest_factory(result_creator):
    def vectorize_hypotest_decorator(hypotest_fun_in):
        @wraps(hypotest_fun_in)
        def vectorize_hypotest_wrapper(x, *args, axis=0,
                                       nan_policy='propagate', **kwds):

            x = np.atleast_1d(x)

            # Addresses nan_policy="raise"
            _, nan_policy = scipy.stats.stats._contains_nan(x, nan_policy)

            # Addresses nan_policy="omit"
            if nan_policy == 'omit':
                def hypotest_fun(x, *args, **kwds):
                    x = x[~np.isnan(x)]
                    return hypotest_fun_in(x, *args, **kwds)
            else:
                hypotest_fun = hypotest_fun_in

            x = np.moveaxis(x, axis, -1)
            res = np.apply_along_axis(hypotest_fun, axis=-1, arr=x)
            return result_creator(res)

        return vectorize_hypotest_wrapper
    return vectorize_hypotest_decorator

Then the decorator could be applied to the shapiro function, which doesn't have to be modified at all:
def _shapiro_result_creator(res):
    return ShapiroResult(res[..., 0], res[..., 1])

@_vectorize_1s_hypotest_factory(_shapiro_result_creator)
def shapiro(x):
   ...

One advantage is that because we are not modifying the shapiro function, it is less likely for us to make a mistake that would change the way shapiro works on a 1d input. That makes it easier to review, IMO.  Another advantage is that the same decorator can be applied to other 1 sample tests, such as jacque_bera, or some other one sample statistics functions without modification. Of course, once we've reviewed the decorator code once, it makes reviewing the application of the decorator to other functions very easy (compared to reviewing the modification of each function separately).
What do you think? I have a PR that proposes a strategy like this for n-sample tests (well, just two right now, but it generalizes) in gh-13312, but I think it would make sense to have something special for 1d.

Hi @mdhaber,
Thanks for your comments. I am sorry for the late reply since I have been a bit busy recently.
The decorator approach sounds like a good idea wrapping all the existing functions. The only concern is that are we going to modify the functions (e.g remove policy parameter stats.ttest_ind() ) that already has part of the proposed features and apply the decorator instead to achieve code consistency?

Hi @mdhaber,
Thanks for your comments. I am sorry for the late reply since I have been a bit busy recently.
The decorator approach sounds like a good idea wrapping all the existing functions. The only concern is that are we going to modify the functions (e.g remove policy parameter stats.ttest_ind() ) that already has part of the proposed features and apply the decorator instead to achieve code consistency?

are we going to modify the functions (e.g remove policy parameter stats.ttest_ind() ) that already has part of the proposed features

No, I didn't plan to do that, not unless there are problems with their current behavior.
We can separate the two parts - vectorization from nan_policy if desired in the future, but initially I'd apply both in one wrapper to the functions that have neither. Any other changes can wait.

are we going to modify the functions (e.g remove policy parameter stats.ttest_ind() ) that already has part of the proposed features

No, I didn't plan to do that, not unless there are problems with their current behavior.
We can separate the two parts - vectorization from nan_policy if desired in the future, but initially I'd apply both in one wrapper to the functions that have neither. Any other changes can wait.

Ok, then I will first try to wrap my PR using the decorator and then we can open another PR to update other functions.
By the way, do you think the IDE (e.g. Pycharm)  can recognize the decorator and thus activate the autocomplete?

Ok, then I will first try to wrap my PR using the decorator and then we can open another PR to update other functions.
By the way, do you think the IDE (e.g. Pycharm)  can recognize the decorator and thus activate the autocomplete?

Ok, then I will first try to wrap my PR using the decorator and then we can open another PR to update other functions.

Since I've already written the decorator and applied it to Shapiro in gh-13312, I'm not sure that is needed. It would be very helpful if you would review that PR instead.

By the way, do you think the IDE (e.g. Pycharm) can recognize the decorator and thus activate the autocomplete?

This is exactly the sort of thing that would be great to check. I used functools.wraps so i hope so? Please take a look!

Ok, then I will first try to wrap my PR using the decorator and then we can open another PR to update other functions.

Since I've already written the decorator and applied it to Shapiro in gh-13312, I'm not sure that is needed. It would be very helpful if you would review that PR instead.

By the way, do you think the IDE (e.g. Pycharm) can recognize the decorator and thus activate the autocomplete?

This is exactly the sort of thing that would be great to check. I used functools.wraps so i hope so? Please take a look!

We'll take care of this as part of gh-14651. Thanks @hp5558!


SPEC0/NEP29: Add Python 3.12, drop Python 3.9

Both SPEC0 and NEP29 currently recommend supporting Python versions 3.10, 3.11, and 3.12. Tests here hadn't started on 3.12 and still tested 3.9. This PR just changes the testing matrix.

Also required fixing an error that apparently was silently passing in a misuse of mock until Python 3.12? (Or maybe based on older versions of mock?)
This is ready for review and comment. Without review, I will merge this after at least 24 hours, no sooner than Tue 11 Jun 01:00 GMT (Mon 10 Jun 20:00 my local).


Syntax error on an ignored file

When running flakehell, I get the below error as it tries to process an encrypted file despite this being in the exclude list. The error doesn't occur when running flake8 without flakehell being installed.
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/astroid/manager.py", line 229, in file_from_module_name
    value = self._mod_file_cache[(modname, contextfile)]
KeyError: ('secrets_vault.production', None)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.7/tokenize.py", line 385, in find_cookie
    line_string = line.decode('utf-8')
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xbb in position 10: invalid start byte

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/bin/flakehell", line 8, in <module>
    sys.exit(entrypoint())
  File "/usr/local/lib/python3.7/site-packages/flakehell/_cli.py", line 39, in entrypoint
    exit_code, msg = main(argv)
  File "/usr/local/lib/python3.7/site-packages/flakehell/_cli.py", line 31, in main
    return COMMANDS[command_name](argv=argv[1:])
  File "/usr/local/lib/python3.7/site-packages/flakehell/commands/_lint.py", line 11, in lint_command
    app.run(argv)
  File "/usr/local/lib/python3.7/site-packages/flake8/main/application.py", line 393, in run
    self._run(argv)
  File "/usr/local/lib/python3.7/site-packages/flake8/main/application.py", line 381, in _run
    self.run_checks()
  File "/usr/local/lib/python3.7/site-packages/flake8/main/application.py", line 300, in run_checks
    self.file_checker_manager.run()
  File "/usr/local/lib/python3.7/site-packages/flake8/checker.py", line 331, in run
    self.run_serial()
  File "/usr/local/lib/python3.7/site-packages/flake8/checker.py", line 315, in run_serial
    checker.run_checks()
  File "/usr/local/lib/python3.7/site-packages/flakehell/_patched/_checkers.py", line 193, in run_checks
    super().run_checks()
  File "/usr/local/lib/python3.7/site-packages/flake8/checker.py", line 598, in run_checks
    self.run_ast_checks()
  File "/usr/local/lib/python3.7/site-packages/flake8/checker.py", line 502, in run_ast_checks
    for (line_number, offset, text, check) in runner:
  File "/usr/local/lib/python3.7/site-packages/flakehell/plugins/_pylint.py", line 40, in run
    Run([self.filename], reporter=reporter, do_exit=False)
  File "/usr/local/lib/python3.7/site-packages/pylint/lint/run.py", line 344, in __init__
    linter.check(args)
  File "/usr/local/lib/python3.7/site-packages/pylint/lint/pylinter.py", line 871, in check
    self.get_ast, self._iterate_file_descrs(files_or_modules)
  File "/usr/local/lib/python3.7/site-packages/pylint/lint/pylinter.py", line 904, in _check_files
    self._check_file(get_ast, check_astroid_module, name, filepath, modname)
  File "/usr/local/lib/python3.7/site-packages/pylint/lint/pylinter.py", line 930, in _check_file
    check_astroid_module(ast_node)
  File "/usr/local/lib/python3.7/site-packages/pylint/lint/pylinter.py", line 1063, in check_astroid_module
    ast_node, walker, rawcheckers, tokencheckers
  File "/usr/local/lib/python3.7/site-packages/pylint/lint/pylinter.py", line 1107, in _check_astroid_module
    walker.walk(ast_node)
  File "/usr/local/lib/python3.7/site-packages/pylint/utils/ast_walker.py", line 75, in walk
    self.walk(child)
  File "/usr/local/lib/python3.7/site-packages/pylint/utils/ast_walker.py", line 72, in walk
    callback(astroid)
  File "/usr/local/lib/python3.7/site-packages/pylint/checkers/variables.py", line 1177, in visit_import
    module = next(_infer_name_module(node, parts[0]))
  File "/usr/local/lib/python3.7/site-packages/astroid/util.py", line 160, in limit_inference
    yield from islice(iterator, size)
  File "/usr/local/lib/python3.7/site-packages/astroid/context.py", line 113, in cache_generator
    for result in generator:
  File "/usr/local/lib/python3.7/site-packages/astroid/decorators.py", line 132, in raise_if_nothing_inferred
    yield next(generator)
  File "/usr/local/lib/python3.7/site-packages/astroid/decorators.py", line 96, in wrapped
    res = next(generator)
  File "/usr/local/lib/python3.7/site-packages/astroid/inference.py", line 254, in infer_import
    yield self.do_import_module(name)
  File "/usr/local/lib/python3.7/site-packages/astroid/mixins.py", line 100, in do_import_module
    modname, level=level, relative_only=level and level >= 1
  File "/usr/local/lib/python3.7/site-packages/astroid/scoped_nodes.py", line 642, in import_module
    return MANAGER.ast_from_module_name(absmodname)
  File "/usr/local/lib/python3.7/site-packages/astroid/manager.py", line 189, in ast_from_module_name
    return self.ast_from_file(found_spec.location, modname, fallback=False)
  File "/usr/local/lib/python3.7/site-packages/astroid/manager.py", line 98, in ast_from_file
    return AstroidBuilder(self).file_build(filepath, modname)
  File "/usr/local/lib/python3.7/site-packages/astroid/builder.py", line 138, in file_build
    return self._post_build(module, encoding)
  File "/usr/local/lib/python3.7/site-packages/astroid/builder.py", line 155, in _post_build
    self.add_from_names_to_locals(from_node)
  File "/usr/local/lib/python3.7/site-packages/astroid/builder.py", line 209, in add_from_names_to_locals
    imported = node.do_import_module()
  File "/usr/local/lib/python3.7/site-packages/astroid/mixins.py", line 100, in do_import_module
    modname, level=level, relative_only=level and level >= 1
  File "/usr/local/lib/python3.7/site-packages/astroid/scoped_nodes.py", line 642, in import_module
    return MANAGER.ast_from_module_name(absmodname)
  File "/usr/local/lib/python3.7/site-packages/astroid/manager.py", line 145, in ast_from_module_name
    found_spec = self.file_from_module_name(modname, context_file)
  File "/usr/local/lib/python3.7/site-packages/astroid/manager.py", line 233, in file_from_module_name
    modname.split("."), context_file=contextfile
  File "/usr/local/lib/python3.7/site-packages/astroid/modutils.py", line 423, in file_info_from_modpath
    return _spec_from_modpath(modpath, path, context)
  File "/usr/local/lib/python3.7/site-packages/astroid/modutils.py", line 648, in _spec_from_modpath
    found_spec = spec.find_spec(modpath, path)
  File "/usr/local/lib/python3.7/site-packages/astroid/interpreter/_import/spec.py", line 337, in find_spec
    _path, modname, module_parts, processed, submodule_path or path
  File "/usr/local/lib/python3.7/site-packages/astroid/interpreter/_import/spec.py", line 300, in _find_spec_with_path
    spec = finder.find_module(modname, module_parts, processed, submodule_path)
  File "/usr/local/lib/python3.7/site-packages/astroid/interpreter/_import/spec.py", line 124, in find_module
    stream, mp_filename, mp_desc = imp.find_module(modname, submodule_path)
  File "/usr/local/lib/python3.7/imp.py", line 301, in find_module
    encoding = tokenize.detect_encoding(file.readline)[0]
  File "/usr/local/lib/python3.7/tokenize.py", line 426, in detect_encoding
    encoding = find_cookie(first)
  File "/usr/local/lib/python3.7/tokenize.py", line 390, in find_cookie
    raise SyntaxError(msg)
SyntaxError: invalid or missing encoding declaration for '/src/secrets_vault/production.py'

Also seems to only happen if the pylint plugin is enabled as well.

How it is excluded? Please, attach the config and the command.

I've tried both exclude and extend-exclude in both .flake8 and pyproject.toml, and neither works.  Please, check the latest version


Increase swipe sensitivity on web

Hi,
Thanks for creating this wonderful library.
I just noticed on the web demo you need to perform a very big swipe in order for the gesture to be accepted.
It feels like velocity/momentum listeners aren't firing which makes the swiping feel unnatural, but I could be wrong.
Wondering if you could share any insight on this?

In fact, I did not adapt more to the Web. Do you have any good suggestions? Welcome PR


added mclighting

RE-CHECK!

Automated adapter checker
ioBroker.mclighting

:thumbsup: No errors found

[ ] :eyes: [W505] setTimeout found in "main.js", but no clearTimeout detected

Add comment "RE-CHECK!" to start check anew

Please create a new version after the PR is merged


Fix #211

Correct, that.will should be replaced by a local copy.
Met vriendelijke groet,
Martijn Verbakel

@nguyenthenguyen commented on this pull request.
In lib/client.js:

     that.broker.persistence.delWill({

       id: that.id,

       brokerId: that.broker.id

     }, nop)

     that.broker.publish(that.will, that, done)

   } else {

     done()

   }

   function done (err) {

     if (!err) {

       that.broker.persistence.delWill({

         id: that.id,

         brokerId: that.broker.id

       }, nop)

     }
   }
 })
 that.will = null // this function might be called twice

Huhm! authorizePublish is async function. Server will crash when that.broker.publish(that.will, that, done) called because that.will is null
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@mhverbakel @mcollina  Should we authorization will package when client connect?

I thought so too, but @mcollina thinks it should be on send (https://github.com/mcollina/aedes/issues/211#issuecomment-410800575)


Standardise 'not' operator usage

Regardless of the result, I'd like to request that a CodeSniffer check is written and implemented. If we want consistency, let's have consistency. Should be one that can be autofixed.
Grab me if you need help writing the check.

Agree. Will do.

I'd imagine a sniff for that already exists?

Just had a look, apparently not.
(Squizlab's coding style is horrible)

@john-n-smith should we merge this? Or wait for the code sniff?


Fix attestation manufacture bug in old yubikeys

This changeset works around a manufacture bug in some 4C Nano yubikeys from the 853#### range. The PIV attestation on these yubikeys doesn't work as expected because the PIV device certificate was certified using the U2F root CA (instead of the PIV root CA). Yubico has acknowledged this issue recently in [0]. Thanks to Chris Halos from Yubico for helping root cause this.
This changeset adds the U2F root CA as an additional CA to work around this. After this PR, go-piv attestation works with both yubikeys from the lucky batch and more recent yubikeys that don't exhibit the bug.
Since testing this without a Yubikey from this series is difficult, I've added new positive and negative tests for both attestation chains.
[0] https://github.com/Yubico/developers.yubico.com/pull/392/commits/a58f1003f003e04fc9baf09cad9f64f0c284fd47
This is a snippet of a device cert. Notice the root U2F CA certifying a PIV attestation cert
    Data:
        Version: 3 (0x2)
        Serial Number:<PHONE_NUMBER>7556493093 (0xbbf06450c44b0325)
    Signature Algorithm: sha256WithRSAEncryption
        Issuer: CN=Yubico U2F Root CA Serial 457200631
        Validity
            Not Before: Aug  1 00:00:00 2014 GMT
            Not After : Sep  4 00:00:00 2050 GMT
        Subject: CN=Yubico PIV Attestation

Address your comments and squashed. Thanks for the detailed review!


feat(app): add long-press modal to ODD ProtocolDashboard page

Overview
When a user long presses (see the useLongPress hook) on a protocol (inside of the ProtocolDashboard component), a full screen menu takeover should render in the center of the screen.
There should be three menu items:

Run protocol

when pressing this button, it should create a run, and push you to the /protocols/${runId}/setup route after a run has been successfully created

Pin protocol

this should be accomplished by leveraging the app’s config module

Delete protocol

this wont be able to be implemented yet. For now just render the button with a click handler that console.logs “deleted protocol with id ${id}“
Closes RCORE-599
Test Plan
The changes were thoroughly manually tested. Unit tests were added to test the short click redirect and the appearance of the modal after a long press. There are not yet tests for the individual actions in the modal.
Changelog

Add long press detection to protocol row
Add new icons
Set global longPress threshold to one second
Add longPress modal to protocol row
Enabled the run button
Stub out protocol deletion that just logs to the console
Added protocols.pinnedProtocolIds to config
Added pin and unpin to long press actions
Added basic render tests to the protocol row

Review requests
The tests are especially sparse. I need to learn how to a) call a long press without waiting a second and b) toggle and test config changes without mocking that code
Risk assessment
There is no risk to other pages of the ODD, and it as a whole is isolated from the desktop app.

https://user-images.githubusercontent.com/2960/219460862-59b30509-7706-4436-adcd-64277c19e211.mov

Just noticed that the first movie didn't show running a protocol but it works too (though I made this before pinning/unpinning did).
https://user-images.githubusercontent.com/2960/219464144-b3a112d7-890a-4db9-86ad-1aaac91f2576.mov

@ewagoner I just updated the reviewers. (devs who have opened the PR for the ODD)


Document what happens to managed identity during a swap

In the "What happens during a swap" section of the page it is ambiguous what happens to an application that uses the Managed Identity app service feature during a slot swap.
Please add Managed Identity to either the "Settings that are swapped" list or "Settings that aren't swapped" list.
This is useful because during app start apps may use managed identity to call out to other services such as Key Vault to aquire credentials - will they do so using the identity of the source or target slot?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f6e09089-1ae2-8943-5ce2-9d48f458c81f
Version Independent ID: ba780cba-f604-b0a4-a81a-23c7d2384762
Content: Set up staging environments - Azure App Service
Content Source: articles/app-service/deploy-staging-slots.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

@alastairtree Thanks for the feedback! We are currently investigating and will update you shortly.

@alastairtree Thanks for the valuable feedback! I have assigned the issue to the content author to review further and update the document as appropriate.


Validator issue

[x] compare all variables in ariadne/exported_variables_full.xlsx, report deviations and if these cross a certain threshold post the corresponding plot from ariadne_all to the PR
[x] somehow record the output from the log files and make it available if a job fails.
[ ] Separate CI for every release: Runs with higher resolution and makes the results persistent, e.g. uploading them to a cloud folder
[ ] Snakemake benchmarks
[ ] Handle changed environments

Moved to https://github.com/lkstrp/pypsa-validator/issues/10


use comma-separation for tzng values

Change the tzng value representation to use comma separation instead of semi-colon termination. This will allow us to unify the escaping rules for the tzng type syntax and value syntax where enum values are embedded in tzng types and field names in record types can be an arbitrary string (in this case ":" needs to be escaped). We will also allow whitespace between comma-separated elements requiring the first character of an element to be escaped when it is whitespace.
This involves an update to the spec as well as the code changes and simplification.

Closing as this has been subsumed by ZSON.


Create LICENSE

Optimistic lock on #370
Based on my knowledge of the people involved, it might take a while, but I don't think anybody will be against licensing under MIT.
Meanwhile, this allows the clarification of new contributions under the license.

Meanwhile, this allows the clarification of new contributions under the license.

Unfortunately it also implies that the contents of the repo are MIT licensed, which they currently aren't (at least not completely). So NAK on merging this before we have collected approvals.
I get your intention though - but I don't think it's necessary. People with direct access to the repo have all already approved or are already in the list, and in the eventuality of a PR from a new contributor we can ask them in the PR.

Everybody approved now


Added insert comment option in visual script

Closes #28079
You can also double click on comment nodes to update the bounds.
I am making this two commits because they are kinda two separate features.

Will take a build and look.

Will review on Monday. Going to take the weekend to rest and recuperate.

Sorry, but I think this isn't quite working right now. I tried it on a clean build and the sizes of the comments are slightly off. Will look into it, but I wouldn't try to merge it just yet.

Turns out it was something to do with the editor scale. Fixed it now, ready to merge!

Could you squash commits together?

Reviewing now.

Is it expected that double clicking an empty comment will make it disappear?

I'm interested in designing a grouping PR for VS. This allows the ability to move every single node in the comment box, but that's a more complicated design I've sketched in the proposals repository.

I was expecting double clicking an comment enclosing nothing should do nothing.

I was expecting double clicking an comment enclosing nothing should do nothing.

Fixed. (Hopefully)

@swarnimarun Can you review this?

Could you squash commits together?

Done.

Will review when I have more bandwidth.

Can you rebase to latest?

Can you rebase to latest?

Done.

@Jummit Is this still desired? If so, it needs to be rebased on the latest master branch.
If not, abandoned pull requests will be closed in the future as announced here.

I think I won't port it to master.


Basic auth in P2P replication

In Photo Drop, the receiver url has a username/password.
So the url looks like: http://<username>:<password>@<ip>:<port>/<dbname>/
When testing a push replication from iOS device to iOS simulator with basic auth each request is sent twice.
For example, the headers for the request /_local/a6f66bd447a08e64dca0137c81a4ffc9b9d1ce59:

Requests with Authorization: Basic ... return a 401 Unauthorized.

Requests with Authorization: Digest ... are successful.
When replicating from an Android device to iOS simulator, the first request is sent with Authorization: Basic ... which returns a 401 but the subsequent request with the Digest is not sent.
Message in ADB: Authentication error: basic authorization challenge expected, but not found
ADB logs:
04-23 12:18:19.903  21954-21954/android.jamiltz.com.photodrop V/scanner﹕ http://XOvkhXb5gqkgM%252FbW2l1i4GfXT7yiAK+Qw4ZZcxxhp0g=:hlziML23WUy%252FQX5J9FsWtn5BOW92sotjJ6hDUZ%252FDgX4=@<IP_ADDRESS>:62791/db
04-23 12:18:19.903  21954-21954/android.jamiltz.com.photodrop V/scanner﹕ QRCODE
04-23 12:18:21.026  21954-23894/android.jamiltz.com.photodrop W/DefaultRequestDirector﹕ Authentication error: basic authorization challenge expected, but not found
04-23 12:18:21.026  21954-23894/android.jamiltz.com.photodrop W/Sync﹕ com.couchbase.lite.replicator.ReplicationInternal$9@b68f880: error getting remote checkpoint
04-23 12:18:21.026  21954-23894/android.jamiltz.com.photodrop E/Sync﹕ com.couchbase.lite.replicator.PusherInternal@a68feb9: Progress: set error = org.apache.http.client.HttpResponseException: Unauthorized
04-23 12:18:21.030  21954-23896/android.jamiltz.com.photodrop E/Sync﹕ PusherInternal stopGraceful.run() finished

Closing this issue as it belongs in the couchbase-lite-java-listener repo.
See https://github.com/couchbase/couchbase-lite-java-listener/issues/56

Reopen the issue. iOS CouchbaseLite Listener uses Digest for authentication instead of Basic. So to get P2P with authentication between iOS and Android working, we will need to add Digest authentication support to Android. Also CBL iOS supports both Basic and Digest.

Based on my test which works both basic and digest auth, instead of using request interceptor to set user credentials, we can use the following:
if (httpClient instanceof DefaultHttpClient) {
  DefaultHttpClient dhc = (DefaultHttpClient) httpClient;
  dhc.getCredentialsProvider().setCredentials(
    new AuthScope(AuthScope.ANY_HOST, AuthScope.ANY_PORT),
    new UsernamePasswordCredentials(username, password));
}

I tested it with PhotoDrop iOS, and the Digest authentication works.
https://github.com/couchbase/couchbase-lite-java-core/commit/689ff4b5562c5dab1fcb967a9c9961c12ef544dd

@hideki What is plan for Android? Pls confirm..

CBL android should support Digest Authentication, and we have planed to implement this for 1.5.0.


Add path support in custom domain

Description:
Currently, the custom domain name in the API gateway only maps the API stages.  This is requesting support to map the API path in custom domain name so the path can be hidden from end users.  Not sure if this is an issue for SAM or API gateway.

Could you provide the current syntax you're using as well as the syntax you want to use and the resulting output?

For example, if an API uses /member as path.  If I create a custom domain name of api.example.com/member, the current API URL becomes api.example.com/member/member. You can see member is duplicated.  The URL I want to see is api.example.com/member without the duplication of the path.  Thank you.

You should be able to achieve this with https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-apigateway-basepathmapping.html.


Uncaught ReferenceError: process is not defined

npm install
npm start
Uncaught ReferenceError: process is not defined
at ./node_modules/jsonwebtoken/lib/psSupported.js (psSupported.js:3:1)
at options.factory (react refresh:6:1)
at webpack_require (bootstrap:24:1)
at fn (hot module replacement:62:1)
at ./node_modules/jsonwebtoken/verify.js (verify.js:6:1)
at options.factory (react refresh:6:1)
at webpack_require (bootstrap:24:1)
at fn (hot module replacement:62:1)
at ./node_modules/jsonwebtoken/index.js (index.js:3:1)
at options.factory (react refresh:6:1)

Resolved.


feat: gen kcl config from go value

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[x] N
[ ] Y

feat: gen kcl config from go value

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

134 of 162 (82.72%)  changed or added relevant lines in 3 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.5%) to 64.322%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/tools/gen/genkcl.go
0
1
0.0%

pkg/tools/gen/template.go
9
10
90.0%

pkg/tools/gen/genkcl_value.go
125
151
82.78%

Files with Coverage Reduction
New Missed Lines
%

pkg/tools/gen/genkcl.go
2
43.22%

Totals

Change from base Build<PHONE_NUMBER>:
0.5%

Covered Lines:
3539

Relevant Lines:
5502

💛  - Coveralls


test: Break handlers out of test code

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (3efec17) to head (d0bb042).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #18   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines          122       122
=========================================
  Hits           122       122

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update to GDB 10.1

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

Note that GDB 10.1 is kind of broken on macOS:  https://sourceware.org/bugzilla/show_bug.cgi?id=26861. We should still be able to build it and run our test since we do not add a break point but just run the hello.c executable under GDB control (adding a breakpoint seems to trigger the internal GDB assertion failure).

@conda-forge-admin, please rerender

Note that GDB 10.1 is kind of broken on macOS: https://sourceware.org/bugzilla/show_bug.cgi?id=26861. We should still be able to build it and run our test since we do not add a break point but just run the hello.c executable under GDB control (adding a breakpoint seems to trigger the internal GDB assertion failure).

@phil-blain this bug was fixed in gdb 10.2 that was released in the meantime, maybe makes sense to bump to that directly?

Closing as #43 supersedes this one.


Initial viewport in spatial has changed

Describe the bug
The initial viewport on Spatial has changed... We now just see the upper edge of the cortex. I'd guess the semantics of zoom numbers changed in Deck.gl between versions, and we just need to update our props.
Environment:

Release or git hash: branch=master | hash=ff8a33c | date=2019-06-07
Browser: FF + Chrome

v7 changed the OrthographicView view state's offset to be called target. It also notes that zooming is now on a log scale but I do not see any issues with our zoom states after the version change. https://deck.gl/#/documentation/overview/upgrade-guide?section=views


Consolidate externalsecret_status_condition

Describe the solution you'd like
Only have one externalsecret_status_condition{status="False"} instead of externalsecret_status_condition{status="True"} and externalsecret_status_condition{status="False"}
What is the added value?
Less confusion.
Give us examples of the outcome
Like described in #1174, there are two metrics that are the exact opposite of each other. One metric should be enough and confuses others less.
cert-manager uses certmanager_certificate_ready_status{condition="False"}. See: https://github.com/cert-manager/cert-manager/blob/master/pkg/metrics/metrics.go#L121-L128

Not sure if that's a feature or a bug, even though I tagged as a feature though.

Bump

I am unable to get the ExternalSecret_operator custom metrics out of the controller. I can see the implementation does seems to use the right labels and dimensions but still no custom metrics are exposed via /metrics default path for metrics. https://github.com/external-secrets/external-secrets/blob/main/pkg/controllers/externalsecret/metrics.go#L27-L30 .
Controller Reconcile function does use them but they are not coming up in /metrics https://github.com/external-secrets/external-secrets/blob/main/pkg/controllers/externalsecret/externalsecret_controller.go#L102 .
Does anyone know why is this the case or am I missing something ?

@vineetguptadev your problem is unrelated to the improvement described in this issue.
Could you please open an issue on your own? Or, what seems more promising, reach out to the devs or other users via a different channel?
Thank you!


Clarify rabbitmq path scrape endpoint translation

The final path of the endpoint for metrics gets prefixed with the RabbitMQ management plugin path prefix.
It took me a lot of time to figure this out. Making it clear in the documentation will help the community.

Thanks!


Consider sending the entities array to the dataProvider arrow function of remult middleware

That way we can control in the endpoint which entities may be created in the create data provider

Done - solved with ensure schema


Add postgres notes to restore & import command help

Add db restore notice:

WARNING: postgres restore will fail if any users are connected to the database. Before proceeding please close all open consoles and database connections. If needed, please contact Datica Support at https://datica.com/support to stop the "%s" service.

and db import notice:

WARNING: Import cannot DROP DATABASE "catalyzeDB". Ensure your import individually removes any necessary "catalyzeDB" objects, or import only into newly created postgres services where the "catalyzeDB" database is already empty.

LGTM


Update README.md

updated discussion link
Summary
A clear and concise description of what the problem or opportunity is. Link to an issue if relevant.
Changes
Describe the changes this pull request introduces.
Task list

[ ] For workflow changes, I have verified the Actions workflows function as expected.
[ ] For content changes, I have reviewed the style guide.

cmwilson21-patch-1

my name is Felix from Nigeria, am eleven years old, pls can you teach me how to use git hub.


Split classify

I put all the modules of Classify.ecl into the folder ML.classify. Then deleted Classify.ecl. I tests the following algorithms in the classify folder in regular and legacy modes: Logistic, DecisionTree, RandomForest, NaiveBayes, and SoftMax.

Why would you want to break ALL existing code that uses classify and invalidate all the documentation/examples?

Tim,
Did you test this without change to the current test clients (ML.Tests.Explanatory.Classify and Classify2?
I am surprised that you elected to change the case of Classify and that a reference to ML.Classify.NaiveBayes (for example) would still work with the case of the folder name being incorrect.

This approach is wrong because it breaks other peoples code.  there are alternatives that don't commit this sin, and so this needs to be re-done.  I'd be happy to help you figure out a better approach.

John, I still don't see how the changes I made could break other peoples code. But, I'd like to accept your offer to help me figure out a better approach.

Firstly - we should only make changes/pull requests against existing issues. What problem are you solving here? The pattern needs to be
Enter Issue -> People COmment -> Someone takes work --> Pull request --> Code reivewed against issue
Having classify (and all first approach) modules at a top level was a concious decision. Splitting out pieces BEHIND the classify module into a directory could happen without breaking existing code.


Download error: decompression get wrong: no output data

I was sent over from https://github.com/jurplel/install-qt-action/issues/50 with an install problem:
I'm currently having issues with the Qt 5.7  installation on Windows (some still are using Windows XP) with win32_mingw53.
Config: https://github.com/pbek/QOwnNotes/blob/48f5b73e1b0a200b88c93d82ef6192f7d80fbe03/.github/workflows/build.yml#L61-L69
Build log: https://github.com/pbek/QOwnNotes/runs/880829548?check_suite_focus=true
I always get the error Download error: decompression get wrong: no output data. for all packages:
2020-07-17 06:56:23,560 - aqt - INFO - Downloading qtsvg...
2020-07-17 06:56:23,560 - aqt - DEBUG - Download URL: http://mirrors.ocf.berkeley.edu/qt//online/qtsdkrepository/windows_x86/desktop/qt5_57/qt.57.win32_mingw53/5.7.1-0qtsvg-Windows-Windows_7-Mingw53-Windows-Windows_7-X86.7z
2020-07-17 06:56:24,064 - aqt - ERROR - Download error: decompression get wrong: no output data.

I tried with and without mirror
Qt 5.14.2 works great, only Qt 5.7 doesn't seem to work
When I download the file on my computer it decompresses fine

Has anyone seen something like that?

This caused by dependency project py7zr's fixed bug
https://github.com/miurahr/py7zr/issues/178
https://github.com/miurahr/py7zr/releases/tag/v0.9.0b1
Could you specify py7zr version py7zrversion as v0.9.0b3 in install-qt-action?

Could you specify py7zr version py7zrversion as v0.9.0b3 in install-qt-action?

Thank you for your quick answer, I'll ask back!

py7zr 0.9 was installed: https://github.com/pbek/QOwnNotes/runs/930611080?check_suite_focus=true#step:4:29
But I still get the same error: https://github.com/pbek/QOwnNotes/runs/930611080?check_suite_focus=true#step:4:80

py7zr v0.9 was installed,  but uninstalled and intalled again v0.7 later.
Installing collected packages: six, pyparsing, packaging, certifi, urllib3, idna, chardet, requests, py7zr, aqtinstall
  Attempting uninstall: py7zr
    Found existing installation: py7zr 0.9.0b3
    Uninstalling py7zr-0.9.0b3:
      Successfully uninstalled py7zr-0.9.0b3
Successfully installed aqtinstall-0.9.0 certifi-2020.6.20 chardet-3.0.4 idna-2.10 packaging-20.4 py7zr-0.7.4 pyparsing-2.4.7 requests-2.24.0 six-1.15.0 urllib3-1.25.10

aqtinstall has a version dependency configuration as     py7zr>=0.7.0,<0.8.0 so it happend.
It is aqtinstall issue.

Thank you for your concern and your fix! So should I wait until the fix is released?

Fix released.

@miurahr, great, thank you! Which version is it released under? The release said 0.9.3, but pip didn't find that one (and 0.9.0b3 still will be downgraded like before).

(Sorry, about the 0.9.3, that is aptinstall). I tried py7zrversion: '==0.9.0', but still got Download error: decompression get wrong: no output data.on https://github.com/pbek/QOwnNotes/runs/934552523?check_suite_focus=true#step:4:84.

Of course I also need to set aqtversion: '==0.9.3', now Qt downloads for Qt 5.7 under Windows. Thank you very much!

Oh, but now I get errors like Download error: CRC32 error on archived file 5.7/mingw53_32/bin/qmake.exe.. 😬
https://github.com/pbek/QOwnNotes/runs/934564323?check_suite_focus=true#step:4:154

There seems to be three issues on Qt5.7 installation on windows.

no output data - this is fixed with py7zr v0.9.0
CRC32 error
Unfinished extraction

The latter  2 and 3 errors are also related to py7zr. These errors are new for py7zr project and very difficult to fix.
We need to take another way to escape it.
Could you please use external command to extract  Qt 5.7 installation?
aqtinstall has a command line option: [-E | --external <7zip command>]
For windows, adding option such as -E "c:\Program Files\7-zip\bin\7z.exe"

Fix is pushed as aqtinstall v0.9.4

Does your problem resolved? @pbek

Thank you very much! The installation now went through! 🥳


chore(release): 2.53.0

See CHANGELOG

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 3efaa49177bd1c5cd417c5218aff777d556c4377
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: c1a111db3000294f38a44076b63ae7904f04af6e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


xdg-desktop-portal-gnome: add missing nautilus dependency

https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome/-/blob/main/NEWS?ref_type=heads#L19
https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome/-/merge_requests/173
https://gitlab.gnome.org/GNOME/nautilus/-/issues/3401
xdg-desktop-portal-gnome now uses nautilus for the file chooser portal, so it needs to be added as a dependency.
Add nautilus to the propagatedUserEnvPkgs to ensure that the dbus services provided by nautilus are loaded properly.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Thanks for the PR.
Do you have an example of situation where the portal does not work? xdg-desktop-portal-gnome is only relevant in GNOME Shell, where Nautilus will be installed by the NixOS module out of the box (unless excluded by the user).
We do not generally like propagatedUserEnvPkgs because it is too broad on one hand, while not really working in many contexts. Instead, we prefer to use NixOS modules as the form of late binding.

When xdg-desktop-portal-gnome is installed and xdg.portal is enabled, if there is no Nautilus in the environment, GTK4 applications will default to opening the FileChooser through the portal, even if GTK_USE_PORTAL is not set. This will result in the FileChooser being unable to open.
For GNOME users, Nautilus is typically installed, so this issue will not arise. Adding the propagatedUserEnvPkgs will not have any negative side effects for GNOME users either.
For non-GNOME users who are using xdg-desktop-portal-gnome, such as myself using Niri, I encountered this issue because Nautilus was not installed. Adding Nautilus as a dependency for xdg-desktop-portal-gnome will allow users who do not using GNOME to use the FileChooser properly.

in my experience the other portal implementations provided by xdg-desktop-portal-gnome (e.g. org.freedesktop.impl.portal.Access) also don't work in DEs like sway. i don't think it's expected for x-d-p-gnome to work outside of gnome.
if all you need is the FileChooser portal, however, you don't actually need x-d-p-gnome for that: Nautilus already provides the dbus org.freedesktop.impl.portal.FileChooser, x-d-p just needs a way to know that:
nautilus.overrideAttrs (super: {
  postInstall = (super.postInstall or "") + ''
    mkdir -p $out/share/xdg-desktop-portal/portals
     cat > $out/share/xdg-desktop-portal/portals/nautilus.portal <<EOF
     [portal]
     DBusName=org.gnome.Nautilus
     Interfaces=org.freedesktop.impl.portal.FileChooser
     EOF
  '';
})

put that on environment.systemPackages and then tell x-d-p to use the nautilus portal:
xdg.portal.config = {
  niri = {
    "org.freedesktop.impl.portal.FileChooser" = "nautilus";
  };
};

if this would meet your needs i wonder if we should ask Nautilus devs to provide a nautilus.portal file like that (and if this isn't what you need, then sorry for the noise!). i don't track the project enough to know if Nautilus implementing org.freedesktop.impl.portal.FileChooser is temporary, or something to rely on.


Add meaningful OpenCV use case example

This intermediate level example's main contribution is a use case for:

Downloading 1000 images from s3 and processing them
How to build native opencv algorithm for pachyderm pipelines

It is to find the top 5 dominant colors of the 1000 images. Analyzing the results and/or performance comparisons will be done in separate PRs.

Example has been merged!!


[Performance]: Empirical Measurement of how to broadcast python object in vLLM

Proposal to improve performance
When we use tensor parallel in vLLM, the driver worker need to broadcast some metadata to all workers, such as the input, the lora requests, etc. This functionality is currently implemented in:
https://github.com/vllm-project/vllm/blob/9c7306ac114da3e31a5ff040a76f6c640354cce8/vllm/distributed/communication_op.py#L143
In essence, it uses torch.distributed.broadcast_object_list to broadcast a Python object. This function has many overhead. The overall procedure is:

There are three layers of overhead:

device memory move: pickle works only for cpu memory. so we need to move data from cpu to device back and forth.
pickled data of multiple objects are concated, leading to one memory copy
two broadcast operation is needed, one for broadcasting the size of each pickled object, and the other for broadcasting data.

Current vLLM implementation packs the data in a list of size one, thus overhead 2 is eliminated:
https://github.com/vllm-project/vllm/blob/9c7306ac114da3e31a5ff040a76f6c640354cce8/vllm/distributed/communication_op.py#L173-L175
To remove overhead 1, we can use CPU operation to broadcast this kind of metadata.
In addition, if we can know the rough size of picked object, we can remove overhead 3 as well. Only one broadcast is required, which is the optimal case for broadcasting a Python object.
I have wrote some benchmark code in https://gist.github.com/youkaichao/b33fcd70286eb45a4a2d5a6dc32d096b and the result is in https://docs.google.com/spreadsheets/d/1c9xgR0fGvm6SROfk7vrjwOZdYnKQk9oOafWK4_KgOyo/edit?usp=sharing .
The short conclusion is:

using cpu (gloo) to broadcast the data indeed works better than nccl (gpu). For small size metadata, the broadcast time reduces from 400us to 300us.
if we can estimate the rough size, the broadcast time can be reduced to 100us. That requires us to design the object to be broadcast.

Report of performance regression
No response
Misc discussion on performance
No response
Your current environment (if you think it is necessary)
The output of `python collect_env.py`

If we can figure out the limit of object size (including inside tensors), we can even pickle the whole object into a pre-allocated buffer, without creating buffer to hold broadcast data again and again, using the out-of-band pickle technology in Python: https://docs.python.org/3/library/pickle.html#pickle-oob .

Note: the memory alignment feature depends on the fact that pickle format is self-ended:
s = [1] * 5
import pickle
d = pickle.dumps(s)
d = d + b"whatever"
import pickletools
pickletools.dis(d)

Output:
    0: \x80 PROTO      4
    2: \x95 FRAME      15
   11: ]    EMPTY_LIST
   12: \x94 MEMOIZE    (as 0)
   13: (    MARK
   14: K        BININT1    1
   16: K        BININT1    1
   18: K        BININT1    1
   20: K        BININT1    1
   22: K        BININT1    1
   24: e        APPENDS    (MARK at 13)
   25: .    STOP
highest protocol among opcodes = 4

There is a STOP code in the end. Therefore it is safe to pad/align the pickled data.

Note: the memory alignment feature depends on the fact that pickle format is self-ended:
s = [1] * 5
import pickle
d = pickle.dumps(s)
d = d + b"whatever"
import pickletools
pickletools.dis(d)

Output:
    0: \x80 PROTO      4
    2: \x95 FRAME      15
   11: ]    EMPTY_LIST
   12: \x94 MEMOIZE    (as 0)
   13: (    MARK
   14: K        BININT1    1
   16: K        BININT1    1
   18: K        BININT1    1
   20: K        BININT1    1
   22: K        BININT1    1
   24: e        APPENDS    (MARK at 13)
   25: .    STOP
highest protocol among opcodes = 4

There is a STOP code in the end. Therefore it is safe to pad/align the pickled data.

s = ['s'] * 5
import pickle
d = pickle.dumps(s)
d = d + b"whatever"
import pickletools
pickletools.dis(d)

    0: \x80 PROTO      4
    2: \x95 FRAME      17
   11: ]    EMPTY_LIST
   12: \x94 MEMOIZE    (as 0)
   13: (    MARK
   14: \x8c     SHORT_BINUNICODE 's'
   17: \x94     MEMOIZE    (as 1)
   18: h        BINGET     1
   20: h        BINGET     1
   22: h        BINGET     1
   24: h        BINGET     1
   26: e        APPENDS    (MARK at 13)
   27: .    STOP
highest protocol among opcodes = 4

The result of pickle.dump does not always seem to be aligned to 4 bytes.

The result of pickle.dump does not always seem to be aligned to 4 bytes.

It does not matter though. The point is it is self-ended, so we can pad with arbitary bytes. Padding does not affect unpickle.

There are two broadcast_tensor_dict in vllm, one to broadcast blocks for copy/swap, the other for broadcasting input data (tokens, block tables, etc). The former takes about 0.4 ms, the latter takes more time. But I don't have a detailed measurement yet.

the performance of broadcasting python object is largely resolved by https://github.com/vllm-project/vllm/pull/5399 , in single node case.


patch @before last{n} n从10开始有问题

从patch说明页面学习的
需求是在最后一项前面插入若干项，不知道是否我语法有问题，目前认为可能是bug
  engine/segmentors/@before last: "A"
  engine/segmentors/@before last1: "B"
  engine/segmentors/@before last2: "C"
  engine/segmentors/@before last3: "D"
  engine/segmentors/@before last4: "E"
  engine/segmentors/@before last5: "F"
  engine/segmentors/@before last6: "G"
  engine/segmentors/@before last7: "H"
  engine/segmentors/@before last8: "I"
  engine/segmentors/@before last9: "J"
  engine/segmentors/@before last10: "K" #K 会乱跑

结果是
  segmentors:
    - A
    - B
    - K #看这里
    - C
    - D
    - E
    - F
    - G
    - H
    - I
    - J
    - fallback_segmentor

基于以上问题，我希望先删除最后一项，再用/+添加所有项到末尾
  engine/segmentors/@last: #希望先删除最后一项，再添加
  engine/segmentors/+:
    - A
    - B
    - C
    - D
    - E
    - F
    - G
    - H
    - I
    - J
    - K

结果却是先执行了 /+，再删除最后一项
    - fallback_segmentor
    - A
    - B
    - C
    - D
    - E
    - F
    - G
    - H
    - I
    - J

这就有点懵了，到底应该用什么语法呢？

解决方案，用01-99这种方式就能解决此问题，代码是用字符串反序的方式添加的，不是用数字
  engine/segmentors/@before last01: "A"
  engine/segmentors/@before last02: "B"
  engine/segmentors/@before last03: "C"
  engine/segmentors/@before last04: "D"
  engine/segmentors/@before las05: "E"
  engine/segmentors/@before last06: "F"
  engine/segmentors/@before last07: "G"
  engine/segmentors/@before last08: "H"
  engine/segmentors/@before last09: "I"
  engine/segmentors/@before last10: "J"
  engine/segmentors/@before last11: "K"


Help cursor did not lock

make sure your code is correct there should be a part of code that says the mouse should lock. Re-paste the movement code


Fix Theme Metadata Duplication and Add Missing Properties for Recent Pull Requests

Fixed an issue where tags could be added multiple times when rebuilding themes.
Fixed an issue where createdAt property was not being added for pull requests created prior to introduction of new properties.
Fixed an issue where tags property was not being added for pull requests created prior to introduction of new properties.
Updated the affected theme.json files for themes merged today.

After merging, please manually run the Submit PR action so that themes.json can be rebuilt

@mauro-balades

Thanks!


Wording error in the documentation

In think there is an error in the documentation (https://offalynne.github.io/Input/#/6.1/Functions-(Players)?id=players_get_status) of the function input_players_get_status().
It is written:
var _old_player = _status.new_connections[_i];
Which sould be:
var _old_player = _status.new_disconnections[_i];
Thanks :)

Thank you - fixed.


Revert "Simulator: Better VR Redundant Status Behaviour"

Reverts apache/cloudstack#3313
@richardlawley it seems your PR gives unexpected CI problems, we have to revert. can you investigate and re-submit?

PR Travis job has passed, this can be merged after a review @andrijapanicsb @DaanHoogland cc @PaulAngus @borisstoyanov .


cast::Error does not implement Error trait

Hello! I'm using the cast library in some production code, and it's great! I like the way that casts only return Result if they might fail.
I'm also using the error-chain crate, which provides support for converting many different error types into my library's "official" error type. But for this to work, all error types need to implement the Display and Error traits. Would you be interested in a pull request adding support for this to your cast library?
Thank you for considering this!

As a workaround, people using error-chain can add something like the following their errors module:
impl From<cast::Error> for Error {
    fn from(err: cast::Error) -> Error {
        format!("numeric cast error: {:?}", err).into()
    }
}

Would you be interested in a pull request adding support for this to your cast library?

Sure! :shipit:

Could you please assign this to me using the Issues interface so that I don't lose track of it? Thank you! I'm juggling a bunch of Rust PRs the next couple of days.

@emk Done!

OK, I've submitted the PR #9, which should provide Error (and several other useful impls). There's an interesting complication because Error requires std and not core, but I provided a way to build the library either with or without core. See the PR for details.
Thank you for your quick response the other day! This is a very useful crate, and I'm going to encourage my coworkers at Faraday to make this part of our standard coding style!


The LIMIT clause and OFFSET clause in SHOW MEASUREMENTS command are not working

Describe the bug（Bug 描述）
As the document SHOW MEASUREMENT said, the LIMIT clause and OFFSET clause in SHOW MEASUREMENTS command are supported, but these two clause are not working. The database always return all the rows even if the LIMIT or OFFSET clause is specified.
By reviewing the code, I found the logic of processing offset and limit are missed:
https://github.com/openGemini/openGemini/blob/b3a161de2e8735997abb927182ab9fd651d9d9d2/lib/util/lifted/influx/coordinator/statement_executor.go#L1374-L1403
To Reproduce（Bug 复现步骤）
No response
Expected behavior（期望结果）
No response
Screenshots（屏幕截图）
> show measurements
name: measurements
+------+
| name |
+------+
| cpu  |
| mst  |
+------+
1 columns, 2 rows in set

> show measurements limit 1
name: measurements
+------+
| name |
+------+
| cpu  |
| mst  |
+------+
1 columns, 2 rows in set

> show measurements offset 1
name: measurements
+------+
| name |
+------+
| cpu  |
| mst  |
+------+
1 columns, 2 rows in set

Logs（完整的错误日志）
No response
Additional context（其他的一些补充内容）
No response

Yes, it is not implemented. Would you like to try it?

I'd love to.


osm2pgsql imported planet slow queries

I imported a full planet via osm2pgsql.
For example "SELECT way, way_area AS area, COALESCE(landuse, leisure, "natural", highway, amenity, tourism) AS type
FROM planet_osm_polygon
WHERE way_area > 100000
ORDER BY way_area DESC
) AS data" query
and
SELECT ST_AsBinary("way") AS geom,"area","name","type" from ( SELECT COALESCE(landuse, leisure, "natural", highway, amenity, tourism) AS type,
name, way_area AS area,
ST_PointOnSurface(way) AS way
FROM planet_osm_polygon
WHERE name IS NOT NULL
AND ST_SetSRID(way,900913) && ST_SetSRID('BOX3D(242458.2537205777 5068997.967759746,243681.2461731433 5070220.960212312)'::box3d, 900913)
AND ST_IsValid(way)
 UNION ALL
SELECT 'building' AS type, name, way_area AS area,
    ST_PointOnSurface(way) AS way
  FROM planet_osm_polygon
  WHERE name IS NOT NULL
    AND building NOT IN ('', 'no', '0', 'false')
    AND ST_SetSRID(way,900913) && ST_SetSRID('BOX3D(242458.2537205777 5068997.967759746,243681.2461731433 5070220.960212312)'::box3d, 900913)
    AND ST_IsValid(way)
  ORDER BY area DESC
) AS data
hangs forever. Does anyone encounter this problem?
When I import only my city rendering also takes reasonable time.

Thanks! It started working for small areas like cities. But it still hangs for large areas like a whole continent with 4 zoom level.
SELECT ST_AsBinary("way") AS geom,"admin_level" from ( SELECT way, admin_level +
FROM planet_osm_line +
WHERE boundary = 'administrative' +
AND admin_level IN ('2','3','4') +
) AS data WHERE "way" && ST_SetSRID('BOX3D(-6261721.35712164 -1252344.271424328,1252344.271424328 6261721.35712164)'::box3d, 900913)

Have you still getting this result after using the indexing?


Configure RTW to use config-user.yml from checked out version of ESMValTool

Part of https://github.com/ESMValGroup/ESMValTool/issues/2786.
The configuration for the Recipe Test Workflow (RTW) currently copies and modifies the locally available copy of config-user-example.yml.
This should be updated so that the config-user-example.yml from the latest checked out version of esmvaltool is used. This is checked out in the install_cold task of the workflow.

Closing this issue in favour of #3168.


serviceaccount kboom-sa and ImagePullBackOff

Thanks for the nice work Michael!
After creating a service account named kboom-sa (whic is missing), I'm getting:
$ k logs kboom-trd2r
Error from server (BadRequest): container "kboom" in pod "kboom-trd2r" is waiting to start: trying and failing to pull image

seems ecr needs proper auth :-)
$ k describe pod kboom-trd2r
Failed to pull image "661776721573.dkr.ecr.us-east-2.amazonaws.com/kboom:latest": rpc

error: code = Unknown desc = Error response from daemon: Get

https://661776721573.dkr.ecr.us-east-2.amazonaws.com/v2/kboom/manifests/latest: no basic auth credentials

And
k create -f permissions.yaml

is needed.

Thanks a lot @arashkaffamanesh and yeah, doh, need to fix ECR access. The permissions setup is explained in install though ;)

Should work now (a temporary fix, but …) so can you please try again @arashkaffamanesh?

It works like a charm! Thanks again for the brilliant work!
$ ./kubectl-kboom results
Server Version: v1.13.5
Running a scale test, launching 10 pod(s) with a 14s timeout ...

-------- Results --------
Overall pods successful: 6 out of 10
Total runtime: 14.229769666s
Fastest pod: 6.009329057s
Slowest pod: 13.011650419s
p50 pods: 10.06318941s
p95 pods: 13.011650419s

Coolio and thanks again for the alpha testing, much appreciated :)

Only a minor issue in README:
kubectl kboom generate
kubectl kboom results

should be (dash is missing)

kubectl-kboom generate ...
kubectl-kboom results

Actually, both is valid :)
Unless you're using a very old kubectl version that doesn't support the binary plugins, see also https://kubernetes.io/docs/tasks/extend-kubectl/kubectl-plugins/

Yes, my issue was, I missed to move kubectl-kboom to /usr/local/bin on my path and it's clear kubectl kboom results can't work. Thanks again!


Use bicep function for storage account name

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Provisioning


Error when publishing to storybook

Hi there!
Here its the details:

Code Connect CLI version 1.1.3
Operating system macOs
Code Connect file, Figma design and/or relevant code snippet that could help us get more context

{   "codeConnect": {     "parser": "react",     "include": ["src/**"],     "exclude": ["docs", "pages"],     "importPaths": {       "src/components/*": "@ui/component*"     },     "paths": {       "@ui/*": "src/*"     }   } }
Storybook Meta
const meta: Meta<typeof Checkbox> = {    component: Checkbox,    parameters:{xxxx},  };
When running connect publish, it will throw this error
ParserError
Error parsing story /Users/xx/src/components/Checkbox/tests/Checkbox.stories.tsx: undefined: Unexpected shape of property parameters, got node type: CallExpression
-> /Users/xx/src/components/Checkbox/tests/Checkbox.stories.tsx:11:14
the error states in the error msg its pointing to  component: Checkbox,
May I know are there any ideas regarding this?

Hi @HJZzzzz , can you share the story file please? If you prefer, it can be shared via customer support as well

sure~ i shared screenshots via the link