Horizon instead of Damping

Is your feature request related to a problem? Please describe.
Instead of updating the damping values every day it would be much easier to set only values for the horizon. This only needs to get set once.
Describe the solution you'd like
I would suggest an input field to put in a comma separated values for the horizon. See Forecast Solar
Additional context
https://doc.forecast.solar/horizon
https://pypi.org/project/forecast-solar/

In my opinion, to apply dampening based on horizon data and sun position calculations is an interesting, but near impossible prospect.
I think it hard to pull off given we receive a combined direct and diffuse irradiation value for each interval from the Solcast API. I believe the way PVGIS works is that the local horizon data is provided to the PVGIS API and it adjusts the direct component then supplies the outcome. We don't have a mechanism to supply like data to the Solcast API.
Horizon shading mostly affects the direct component, and we do not have a direct/diffuse breakdown to adjust in the integration. The proportion of direct and diffuse at any given time with respect to an horizon model will also vary greatly making an assumed proportion useless. Example: A tall dense tree located close to a PV array shading mid-morning, vs. a neighbor's house up-slope of the current location shading late afternoon. These assumed proportions would need to be provided along with horizon data.
Happy to be contradicted.

Instead of updating the damping values every day it would be much easier to set only values for the horizon. This only needs to get set once.

Yeah, nah.
I think what you want is the best of both worlds - you want the horizon-based forecasts from PVGIS, and the weather-based forecasts from Solcast.
What I'd suggest, if you want that, is to run both forecasts, and use the horizon-based forecasts to produce damping values by comparing them and using them to automatically produce damping for the Solcast forecasts.  Then you get the horizon-based shading reducing the cloud-based model that Solcast provides.
But as @autoSteve said, this seems like it is going much further than just setting up some damping factors - you don't have to adjust them each day.  Sure, sunrise / sunset times do change a little bit each day, but if you have a significant, unmoving horizon that shades your installation, the impact isn't that great that static damping isn't going to provide you with an adequate forecast for your needs.
The purpose of this integration is to provide free home users with adequate forecasts for home use; if you want accurate commercial forecasting, Solcast has a product for you :)
If you want super-accurate home forecasting for your own purposes, then utilise both sources, and use an approach such as that described in https://github.com/BJReplay/ha-solcast-solar/discussions/120 (specifically starting https://github.com/BJReplay/ha-solcast-solar/discussions/120#discussioncomment-10623338) by @Nilogax to automate damping changes.

Would that be the "terrain_shading" feature of Solcast? (https://solcast.com/blog/whoa-terrain-shading-is-now-live-in-the-solcast-api)

Yeah, but not available on the free home subscription, which is why I said it has a product (implying paid).
Solcast also has the ability for paid services to feedback actual production (without terrain shading) so that it learns about degradation and other factors that impact production locally (e.g. a chimney, for example).
There's only so much work we (and that realistically means @autoSteve) is going to do re-creating paid features of a product in the free integration.
There's only so much accuracy people need at home.  If you need more, you need to be paying for it, or you don't need it.


[deps] Bump native assets dependencies

Roll of a bunch of breaking changes from the native_assets_builder and native_assets_cli upstream. Most notably:

https://github.com/dart-lang/native/pull/946
https://github.com/dart-lang/native/pull/1018
https://github.com/dart-lang/native/pull/1019

This PR also updates the template in flutter create --template=package_ffi to use the rewritten API.
This PR does not change any functionality in Flutter.
For reference, the same roll in the Dart SDK:

https://dart-review.googlesource.com/c/sdk/+/357605
https://dart-review.googlesource.com/c/sdk/+/357623

Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

A few questions, mostly out of curiosity, but this LGTM once CI passes.

Thanks @christopherfujino!


TiCDC handles API crash silently, it's difficult to debug and confusing

As title.

/assign @sdojjy


Conflict between  guzzlehttp/guzzle ~6.0 and 7.0

our requirements could not be resolved to an installable set of packages.
Problem 1
- jobapis/jobs-common[2.0.0-beta, ..., 2.1.2] require guzzlehttp/guzzle ~6.0 -> found guzzlehttp/guzzle[6.0.0, ..., 6.5.x-dev] but it conflicts with your root composer.json require (^7.0.1).
- jobapis/jobs-careerjet 0.1.0 requires jobapis/jobs-common ^2.0.0 -> satisfiable by jobapis/jobs-common[2.0.0-beta, ..., 2.1.2].
- Root composer.json requires jobapis/jobs-careerjet ^0.1.0 -> satisfiable by jobapis/jobs-careerjet[0.1.0].
Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.
Installation failed, reverting ./composer.json and ./composer.lock to their original content.
How I can install both version to solve the problem

You cannot install them both. jobapis/jobs-common needs to upgrade to Guzzle 7.


Column width change does not work in Main Window

Describe the bug
Main window columns width cannot be changed.
Steps To Reproduce
Steps to reproduce the behavior:

Open Mobiflight Connector
Load any mcc file
Try to change the column width of the Description column
Note the width does not change

Expected behavior
Column width can be changed
Actual behavior
Column width does not change
Details

MobiFlight Version: <IP_ADDRESS>
FlightSim: irrelevant
AddOn: irrelevant

Additional context
none

This is by design, it was removed when auto-size columns was addded.


Remove code deprecated in 0.20 (released on March 31, 2022)

There is code released 16 month ago that needs to be removed.

qiskit/visualization/circuit/latex.py:52 (__init__)
qiskit/visualization/circuit/latex.py:53 (__init__)
qiskit/visualization/circuit/latex.py:54 (__init__)
qiskit/visualization/circuit/latex.py:55 (__init__)
qiskit/transpiler/coupling.py:128 (subgraph)
qiskit/dagcircuit/dagcircuit.py:612 (_copy_circuit_metadata)
qiskit/synthesis/evolution/suzuki_trotter.py:54 (__init__)

This includes:

[ ] Remove deprecated code and tests (if they only check the deprecation raise)
[ ] tag the PR as Changelog: Removal
[ ] create a release note in the category upgrade:. If you can include an example with an alternative for user to migrate to the new code, as this change might break users code.

@1ucian0 Please assign this issue to me.


can't install by npm

I am having a issue with npm install. Please see after run the command 'npm install swint-pipe'
C:\Users\user\callback>npm install swint-pipe
npm WARN install Couldn't install optional dependency: Unsupported
C:\Users\user
└──<EMAIL_ADDRESS>

Hello,
It seems to be the problem with npm. Which version of node.js and npm are you using?
swint-pipe supports node version from 4.0.0.

how about v5.40. which i am using currently..
On 15 March 2016 at 15:43, KnowRe<EMAIL_ADDRESS>wrote:

Hello,
It seems to be the problem with npm. Which version of node.js and npm are
you using?
swint-pipe supports node version from 4.0.0.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/KnowRe/swint-pipe/issues/4#issuecomment-196704836


Fix SQLite resetSequence inconsistencies

Q
A

Is bugfix?
no

New feature?
no

Breaks BC?
no

Tests pass?
yes

Fixed issues
Addition to #13630

No changelog update needed, as it is an improvement of #13630

I added the key quoting as in #13582

Merged. Thanks!


Add the lines svg as a generated test

OK this is going to need some back and forth to figure out what the right way of doing this is going to be. I've constructed the recorded module which will be included in pdfout's source code here recorder.zip you will see the template section which defines where the generated code should go.
In this merge request you can see an example test (not a proper python test) and it generates the lines pdf file that I attached to the previous MR.

Dunno how much of this is makes sense for you but looking at the output it seems to me that limiting float precision to something like three decimals should be enough and also it would be great to get it to use push_gstate instead of manual q and Q commands.

Fixed

Any particular reason why you are doing:
with capypdf.StateContextManager(ctx0) as state0:

as opposed to
with ctx0.push_gstate():

The StateContextManager is an internal class. Users should not even know that it exists. There is also no need to store the result in a named variable because there are no methods you can call on it (as opposed to ctx, which you always need to access).
Anyway, I edited this a bit by hand and put in master as a test.

It says not to edit it :wink:
The StateContextManager is being used as a base class, it's very useful as a class and not a function call. I would like to promote it to first class part of the API, especially since it's pure python so shouldn't effect the capi at all.
The variables are because it's generating this, so it doesn't know for sure if something is going to be used while it's printing it out.
Want to close this MR?

I would like to promote it to first class part of the API, especially since it's pure python so shouldn't effect the capi at all.

What advantage would that bring? Currently it is just a much longer way of typing the same thing.

You can't inherit from a function.

But what problem are you solving by inheriting from the context manager class?

Further context management.

Not in general, but specific. As specific as you can possibly get. As in "I want to achieve X, so I want to do Y with Z".

Best to see the api being used in the wild: https://gitlab.com/inkscape/extras/extension-pdf/-/blob/main/pdfout.py#L534
I think it'll be easier to just copy the code into my own codebase then attempt to argue about it, the cost of this conversation is way higher than the code involved.

I may have been operating under the assumption that you were already looking at my python code, if this isn't the case, then I apologise for being annoyed about something you couldn't have done anything more reasonable about.

I hadn't read that before, sorry. That's why I asked.
That seems like a reasonable use case, so we could indeed provide something for it. But on the other hand, as you say, that is a very small amount of code, so having downstream reimplement it is not that big of a deal. The real question is how common would this requirement be, but unfortunately we can't know that until after the library has been adopted by several projects. :(

I tried to have a look and see if there's PEP advice on context managers. There's no strong opinion between the two forms. Classes are the default, are slightly more obvious and self-documenting when introspection. Functions can have embedded context and can make bespoke classes (that's what the contextmanager decorator is doing)
The capypdf API contains many root class uses, i.e. the API doesn't all hang off of the generator class in a big tree of in-context calls (Color, Options, PageProperties). But it sometimes does hang off of the generator (draw_context, load_font, load_image, etc). So the existing design isn't instructive about which would be used.
I'm a proponent of "why not both", if the API for one is actually just a wrapper for the other. Of course if you choose to just have a class, you should move it into the def so it's private.

the API doesn't all hang off of the generator class in a big tree of in-context calls (Color, Options, PageProperties). But it sometimes does hang off of the generator

My original idea was that "data only" classes like page properties object can be created and used freely as they are not tied to any particular generator. More heavy duty classes like DrawingContext are generated inside the generator object as they are strongly tied to it.
Then after a while I realized that does not really work as Color is tied to the generator when using ICC colors (but not when using other colors). So I don't have a particularly good answer here.


Renaming multiple files and automatically Updating Imports doesn't work properly

VS Code version: Code 1.44.2 (ff915844119ce9485abfe8aa9076ec76b5300ddd, 2020-04-16T17:50:03.709Z)
OS version: Linux x64 4.4.0-142-generic
Steps to Reproduce:

Open a project that uses file imports (mine was ReactJS)
Rename a file that gets imported by other files with F2
When the "Update imports for 'NEW_FILE_NAME'?" pops up, click "Yes"
Without saving the opened files, rename another file using F2
Again, click "Yes" for the "Update imports..." dialog
Import renaming will mix lines won't work properly at all, creating syntax errors in the process.

Can you please share a specific project that causes this
Also, does this reproduce in the latest VS Code insiders build?


Add static dataset delete

🚀 🚀 Pull Request
Checklist:

[x]  My code follows the style guidelines of this project and the Contributing document
[x]  I have commented my code, particularly in hard-to-understand areas
[x]  I have kept the coverage-rate up
[x]  I have performed a self-review of my own code and resolved any problems
[x]  I have checked to ensure there aren't any other open Pull Requests for the same change
[ ]  I have described and made corresponding changes to the relevant documentation
[x]  New and existing unit tests pass locally with my changes

Changes
Implements static method for dataset deletion, with the required flags. Large data tests are still very slow, so the section of the test for large_ok is commented out. Passes locally.

The decided api was Dataset.delete and ds.delete. (Yes, these can be "overloaded").

@farizrahman4u I am facing difficulty implementing this. What is wrong with the following example?
>>> class X:
...     def f(self):
...         return 1
...     @staticmethod
...     def f():
...         return 2
...
>>> X.f()
2
>>> X().f()
2

@benchislett Try this:
class Dataset:
    @staticmethod
    def _delete_at(path: str):
        # Your "delete at" logic here
        print(f"Static call Datatset.delete({path}).")

    def _delete(self):
        # Move current ds.delete() here
        print(f"Object member call: delete() method of object {self}.")

    def delete(ds: Union[str, "Dataset"]):
        if isinstance(ds, str):
            return Dataset._delete_at(ds)
        elif isinstance(ds, Dataset):
            return ds._delete()
        else:
            raise TypeError(f"Expected str or Dataset instance. Received {type(ds)}.")

#######

Dataset.delete("abcd")

ds = Dataset()
ds.delete()

Dataset.delete(ds)

@farizrahman4u
I don't like how that would look with the other parameters to Dataset.delete. I think it's best if we keep it temporarily like this until we split it to hub.dataset.delete where the conflict will no longer exist. I'm fine to keep this PR in limbo until that happens if you want.


[MemoryLeak] medLogger TeeStreams, TeeDevices and d -- master

Same as medLogger commits from https://github.com/medInria/medInria-public/pull/1117
Solves several memory leaks in medLogger from teestreams, teedevices and d.
:m:

I switched this PR from master to dev


implement debug_traceTransaction / debug_storageRangeAt

Would be nice to be able to debug transactions in remix using testrpc

@yann300 do you know if there is any specification of these two endpoints?

@yann300 we can use this to generate the relevant information from typical rpc calls
https://github.com/kumavis/eth-tx-summary

this could be added to testrpc to provide support for the methods or simply added to remix to work against any client

There is no real spec but we basically follow the geth implementation
https://github.com/ethereum/go-ethereum/wiki/Management-APIs#debug_tracetransaction
note that https://github.com/ethereum/go-ethereum/wiki/Management-APIs#javascript-based-tracing is not yet implemented in the cpp client.
I'll post the doc of storageRangeAt when I'll find it.
@kumavis your tool copy the state of the targeted client to the JavaScript VM right and execute the tx, right?

@kumavis your tool copy the state of the targeted client to the JavaScript VM right and execute the tx, right?

The state is looked up lazily via rpc against the previous block and then "shadowed" if written to. Handles subcall OOG reverts correctly and all. Since we can't load medstate over RPC we have to run all txs in the block before the tx we actually want to replay - which can be quite slow due to the serial network lookups.

https://github.com/ethereum/go-ethereum/pull/14350 the doc on debug_storageRangeAt

FYI: debug_traceTransaction is mostly finished on a separate branch. Will take a look at debug_storageRangeAt. Thanks all.

@tcoulter goof news!

What is the current status of debug_traceTransaction? Since it is listed in README.md I thought it was fully implemented, but the storage field seems to always be empty in my case (both with fullStorage=True and fullStorage=False).
It works normally with geth (i.e. the output is similar to https://github.com/ethereum/go-ethereum/wiki/Management-APIs#debug_tracetransaction)

What is the current status of debug_traceTransaction? Since it is listed in README.md I thought it was fully implemented, but the storage field seems to always be empty in my case (both with fullStorage=True and fullStorage=False).
It works normally with geth (i.e. the output is similar to https://github.com/ethereum/go-ethereum/wiki/Management-APIs#debug_tracetransaction).

It seems TestRPC (now GanacheCLI/TestRPC) https://github.com/trufflesuite/ganache-cli  is implemented.
However, when trying to use the remix library, I get 'Number can only safely store up to 53 bits' after running  TraceTransaction. Anyone on here might know why that's happening?

+1

+1

+1

Is there any update for debug_traceTransaction.
I found it is listed in the README, but up to now, I still can not use it.
> web3.debug
undefined

@mrssource the debug_traceTransaction RPC method is (mostly) implemented. Here are some examples (via our test suite) showing how it should be used: https://github.com/trufflesuite/ganache-core/blob/develop/test/debug/debug.js

also it would awesome to implement debug_storageRangeAt
https://github.com/ethereum/go-ethereum/pull/14350

Any chance to see "Parity trances" implemented?

To me, it seems that debug_traceTransaction does not return all the storage contents, even though I have 'fullStorage' set to True and 'disableStorage' set to False. Moreso, it seems to only return storage elements that are accessed or about to be accessed by an opcode, but not other storage contents. Has anyone encountered a similar issue?


Use "vertices" instead of "points" in CheckCollisionPointPoly

Cosmetic code change. Having variables point and points as a single function parameters is a bit confusing, as for me. Especially when the comment refers to "array of vertices" :)

I agree the naming could be a bit confusing but it is aligned with other functions:
DrawLineStrip(Vector2 *points, int pointCount, Color color);
DrawTriangleFan(Vector2 *points, int pointCount, Color color);
DrawTriangleStrip(Vector2 *points, int pointCount, Color color);

No function refers to 2d screen points as vertices. Also note that vertices could refer to multiple different data attributes: position, texcoords, normals, tangents...
I know it's a tricky one, no easy to find a proper naming...

Fair point, thanks for fast response!

This will not break any code, because it is about the naming of signature variables.
However, it is vertexCount, just as it was pointCount.  Replacing points[] with vertices[] is OK, apart from Ramon's consistency objection.
This is always a place where C Language is a bit clumsy.  We tend to speak of vertex[i] and point[i] and don't have a clean concept for array names apart from member-pointing names.
In documentation I finesse this using vertex[] and point[].  That's a big change to prototypes though.


Unable to use via cocoapods

I added this to my podfile and ran install and it says "Using NVActivityIndicatorView (3.6.1)".  Your README seems to imply it should be a 4.x version.
When I open the workspace I get errors about functions being marked as final.

@grosch: Which Swift version are you using?

Not sure what happened but the next time i ran an install it put in a version that worked.

Hey @grosch,
Sometimes dependencies aren't always up-to-date with the latest standards, some stuff may have changed in Swift 4.1 -> 4.2
You can assign the Swift Build Version in CocoaPods by setting the build version in the post_installation hook. Here's an example:
post_install do |installer|
  installer.pods_project.targets.each do |target|
    if['NVActivityIndicatorView', 'MyOtherAwesomePod'].include? t.name
      t.build_configurations.each do |config|
        config.build_settings['SWIFT_VERSION'] = '4.0'
      end
    end
end

Look out for my upcoming article explaining the how/why on CodeMentor! :)


feat: OverlayFS -> AUFS whiteout conversion

Allow OverlayFS whiteouts to be converted to AUFS, by filtering a tar stream.
In this direction the conversion is a single pass, single operation. There is no requirement to pre-scan the tar.
Close https://github.com/sylabs/oci-tools/issues/53

LGTM. Just one observation, the round trip exposes that some of the TAR entries end up getting Cleaned, while others do not. I'm not aware of any specific issue this causes, but thought I'd raise it just in case you can think of any?

Right - they are equivalent, but yeah.. it would be nicer for comparison purposes if the ./ is preserver. Let me look at that.

@tri-adam - please take a look at 6498921
09:36 am $ gunzip -c test/images/aufs-docker-v2-manifest/blobs/sha256/da55812559dec81445c289c3832cee4a2f725b15aeb258791640185c3126b2bf | tar tf -
./
./dir/
./dir/.wh..wh..opq
./.wh.file

09:36 am $ tar tf pkg/mutate/testdata/Test_WhiteoutRoundTrip/overlayfs.golden
./
./dir/
./file

09:36 am $ tar tf pkg/mutate/testdata/Test_WhiteoutRoundTrip/aufs.golden
./
./dir/
./dir/.wh..wh..opq
./.wh.file


feature/custom-margins

Fix the issue of signature for page without margins default

Could you merge this PR into your branch? So I will be able to merge your branch into dev.


Duckdb will support data type blob like sqlite?

Duckdb will support data type blob like sqlite?  Blob type is very useful in some scenarios.

Yes, this will be supported eventually. See #72


I can't download OpenXml Packges,how can I Dot

image

@qinmeigui : I'm pretty confident that you have downloaded wrong package; this package is hosted on myget and not on nugget. As taylor suggested; follow 'The Latest Builds' section in readme (https://github.com/OfficeDev/Open-XML-SDK#how-to-install-the-nuget-package) to get correct package.

@qinmeigui Since the directions are on the README and there are other issues with examples, I'm going to close this. Please reopen with more details if you feel your issue has not been addressed.


consider switching to lz4 bundles instead of rsync

see: https://github.com/lz4/lz4
rsync has to much overhead and storing uncompressed node modules fills up disk pretty fast

Example use:
tar cf - .cache public | lz4 -v > gatsby-caches.tar.lz4
lz4 -d -v -c gatsby-caches.tar.lz4 | tar xf - -C ./extracted/


Is it possible to use the schema of our own dataset, generated by SQLite in json format, with SmBop code in google colab?

I have my own dataset. I can generate its schema in json format using SQLite DB's export option. I want to convert natural questions to SQL format using SmBop for querying on my own database. Is it possible to do this using the pretrained SmBop model on google colab?

Sure, you can look at how Spider formats the schema and just adapt your own DB to that structure.

Are you aware of any scripts that can help in doing that?
And once the schema is ready, will SmBop perform well on it, without training the network again on my own dataset?

Not really.
Yeah! Actually, any model that does well on Spider will be able to generalise to a new schema.

How to fine-tune the model on our own dataset, without needing to retrain it again? Can the pretrained model you provided be used for this?
Yes. You can use the pre-trained model.
If the new data is in the same format as Spider, you can use the original dataset reader. And modify the defaults.jsonnet such that the model is initialized from the as pretrained model as described  here

How to fine-tune the model on our own dataset, without needing to retrain it again? Can the pretrained model you provided be used for this?

Yes. You can use the pre-trained model.
If the new data is in the same format as Spider, you can use the original dataset reader. And modify the defaults.jsonnet such that the model is initialized from the pretrained model as described here.

I am new to jsonnet format. Where should I put
[".*",
{
"type": "pretrained",
"weights_file_path": "best.th",
"parameter_name_overrides": {}
}
]
in the jsonnet file?
I have already converted the dataset in spider format

I think instead of initializerapplicator it should be initializer

It's still giving the same error on changing it to "initializer"
Have you found any alternatives?

It's still giving the same error on changing it to "initializer"
Have you found any alternatives?

Hi! Seems like I found the solution: try to replace the whole "model": {...} block in the jsonnet file with just
"model": {
  "type": "from_archive",
  "archive_file": "<your_path>/model.tar.gz",
},

Hey thanks for the solution. It works now.
Although I am wondering,, with the above modification,  if it's retraining the model or fine-tuning it? If it's retraining then the information learnt from the Spider dataset might be lost.
Any insights on this?

It's still giving the same error on changing it to "initializer"
Have you found any alternatives?

Hi! Seems like I found the solution: try to replace the whole "model": {...} block in the jsonnet file with just
"model": {
  "type": "from_archive",
  "archive_file": "<your_path>/model.tar.gz",
},

UPD: note that you'll need to modify the config.json after training finishes, because the reference to pretrained model archive won't go anywhere and it will prevent the proper loading of the finetuned model.

Hey thanks for the solution. It works now.
Although I am wondering,, with the above modification,  if it's retraining the model or fine-tuning it? If it's retraining then the information learnt from the Spider dataset might be lost.
Any insights on this?

Hey thanks for the solution. It works now.
Although I am wondering,, with the above modification, if it's retraining the model or fine-tuning it? If it's retraining then the information learnt from the Spider dataset might be lost.
Any insights on this?

I'd say that if you take a pretrained model and then train it on a completely different dataset, it is a retraining but with a very very good weights initialization. ;D Still, the weights will obviously shift towards the new data, just as expected. I would assume you have to add your data to the Spider data instead of replacing it if you want to keep the performance, but no guarantee that the model will generalize well to that union.
In my case, I started finetuning retraining with 74,6% (according to the evaluation script) overall exact matching accuracy on Spider and 0% on my data, and ended with 67,1% and 63,6% accuracy, respectively. Now, I don't really care about model performance on Spider since I want to use it on my data, not on Spider. ;)

Hey thanks for the solution. It works now.
Although I am wondering,, with the above modification, if it's retraining the model or fine-tuning it? If it's retraining then the information learnt from the Spider dataset might be lost.
Any insights on this?

I'd say that if you take a pretrained model and then train it on a completely different dataset, it is a retraining but with a very very good weights initialization. ;D Still, the weights will obviously shift towards the new data, just as expected. I would assume you have to add your data to the Spider data instead of replacing it if you want to keep the performance, but no guarantee that the model will generalize well to that union.
In my case, I started ~finetuning~ retraining with 74,6% (according to the evaluation script) overall exact matching accuracy on Spider and 0% on my data, and ended with 67,1% and 63,6% accuracy, respectively. Now, I don't really care about model performance on Spider since I want to use it on my data, not on Spider. ;)

Hi Thanks for that answer! Really helpful.
But seems like I ran into another issue. The Inference pipeline of SMBop hosted on google colab, runs out of RAM(25 gigs) as it keeps on connecting and loading trees for my own finetuned model. Whereas using the pretrained model provided by the authors, only loads and connects the trees once, and works fine on google colab.
Any insights on this?

Hey, can you provide a MWE?
Specifically, What is the error message?

Hey, can you provide a MWE?
Specifically, What is the error message?

I don't get an error message. It just keeps on running "before load_trees, before connecting" until it runs out of ram(25GB GPU RAM) for my pretrained model. Whereas for your pretrained model, it only loads a couple of times and runs fine.

Can you share the code?

Can you share the code?

I think there was a problem with google colab's GPU. It's working fine now. Thanks for all of your help!

@varunpandya2004  Hi, can you please tell me how you prepared your custom dataset, and share the script or colab notebook

I have my own dataset. I can generate its schema in json format using SQLite DB's export option. I want to convert natural questions to SQL format using SmBop for querying on my own database. Is it possible to do this using the pretrained SmBop model on google colab?

@varunpandya2004  can you tell me how you created the schema, like when i'm trying to export with export option in sqlite studio , there is no options for the schema to export, there is only options for tables, database, query. Please help
thanks

Can you share the code?

I think there was a problem with google colab's GPU. It's working fine now. Thanks for all of your help!

facing same issue, how did you solved?


[Bug] Missing order in false_positive_analysis.py

Hello, Thank you for your useful tools!
But I find that, when you upgrade your code from Python2 to Python3, you missed some code in false_positive_analysis.py, which will result in wrong error type order:
https://github.com/HumamAlwassel/DETAD/commit/def334f6cd385aff860adfb7bbe9db8d3b2c3ec2#diff-00dcae1f1ee99cb43ee648309d01c68705cb589f0177073fb6995cce721568adL152-L154
It results in wrong results on THUMOS14.
Could you verify that bug?

Hello @tzzcl,
Thank you for your interest in our work.
The line you refer to is deleted on purpose to allow the correct order when switching to python 3. The resulting output of the code is correct. Can you make sure that we are able to reproduce the same output of the example shared on the repo? you should be able to attain the same output using the updated conda env.
Let me know (by replying on this issue) if you are still having problems.
Cheers,
Humam

Hello, Thank you for your quick reply!
I'm experiencing this issue when I'm using a prediction on THUMOS14 dataset, not the provided ActivityNet examples. I can also get correct results on the provided examples.
Maybe there are some issues there?
Regards,
Chenlin

Hello Chenlin,
Thanks for clarifying.
You are indeed right - I was able to reproduce the bug on my side for THUMOS14.
I just made the fix with the most recent commit. I also added a sample output for a method on the THUMOS14 testing subset.
Please make sure that you can reproduce the same sample output if you still have issues.
Cheers!


[url_launcher] iOS Safari cannot open the page because the address is invalid

Steps to reproduce
1- Create a basic Flutter app (Counter)
2- Add url_launcher package (any version)
3- Add the corresponding configuration for iOS following the official doc
4- Try to launch a Facebook page like: launchUrl(Uri.parse('https://facebook.com/ebonymag'));
5- Run the app on iOS
Expected results
The page should be opened in Safari without issues
Actual results

Code sample
Code sample
launchUrl(Uri.parse('https://facebook.com/ebonymag'));

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.24.3, on macOS 14.2 23C64 darwin-arm64, locale en-UY)
    • Flutter version 3.24.3 on channel stable at /Users/haironchaviano/fvm/versions/3.24.3
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 2663184aa7 (5 weeks ago), 2024-09-11 16:27:48 -0500
    • Engine revision 36335019a8
    • Dart version 3.5.3
    • DevTools version 2.37.3

[✓] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
    • Android SDK at /Users/haironchaviano/Library/Android/sdk
    • Platform android-35, build-tools 35.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15F31d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2024.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)

[✓] VS Code (version 1.94.2)
    • VS Code at /Users/haironchaviano/Downloads/Visual Studio Code.app/Contents
    • Flutter extension version 3.98.0

[✓] Connected device (4 available)
    • Hairon’s iPhone (mobile)        • 00008130-001260E82E04001C • ios            • iOS 18.0.1 22A3370
    • macOS (desktop)                 • macos                     • darwin-arm64   • macOS 14.2 23C64 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad     • darwin         • macOS 14.2 23C64 darwin-arm64
    • Chrome (web)                    • chrome                    • web-javascript • Google Chrome 129.0.6668.101

[✓] Network resources
    • All expected network resources are available.

Duplicate of https://github.com/flutter/flutter/issues/89949 and https://github.com/flutter/flutter/issues/83243.


SES should be split into proposal and shim repositories

I have now renamed tc39/proposal-frozen-realms to tc39/proposal-ses , as discussed at tc39. We should move SES documentation there, update or remove stale documentation there, and rename this repository to emphasize that what remains is just the ses-shim. We should parallel exactly the split we just did between proposal-realms and realms-shim.

This was done a while back:

Proposal: https://github.com/tc39/proposal-ses
Shim (this repo): https://github.com/Agoric/SES-shim/issues/129

Closing, complete.


Custom loader icon

How can I define custom icon instead default spiner for Loader module?

@netstuff, for any usage related questions, kindly post them on our gitter channel or discord server


Sub Query and Pagination throws an error

It seems that I'm encountering an issue with Blaze Persistence related to a query that involves a join with a subquery and pagination. When pagination is applied, it throws the following error:
 An exception occurred while filtering products
java.lang.IllegalArgumentException: org.hibernate.query.SyntaxException: At 1:2216 and token 'entity_function', no viable alternative at input 'SELECT product.id'

However, when I remove pagination, the query works as expected. I've spent the last two days debugging and searching for a solution without success. Could you please assist me in resolving this?
Here is the code I'm trying to execute:
final CriteriaBuilder<Product> criteriaBuilder = this.criteriaBuilderFactory.create(this.entityManager, Product.class, "product");

final var entityViewSetting = EntityViewSetting.create(ProductCardView.class);
final var productViewCriteriaBuilder = this.entityViewManager.applySetting(entityViewSetting, criteriaBuilder);

productViewCriteriaBuilder.with(ProductViewHistoryCTE.class)
        .from(ProductViewHistory.class, "ProductViewCTE")
        .bind("productId").select("product.id")
        .bind("viewsCount").select("count(id)")
        .end();

productViewCriteriaBuilder.innerJoinOn(ProductViewHistoryCTE.class, "ProductViewCTE")
.on("ProductViewCTE.productId").eq("id")
.end();

final Sort sort = pageable.getSort();
if (sort.isSorted()) {
    EntityViewSortUtil.applySort(this.entityViewManager, ProductCardView.class, productViewCriteriaBuilder, sort);
}

return productViewCriteriaBuilder
        .page((int) pageable.getOffset(), pageable.getPageSize())
        .orderByAsc(Product_.ID)
        .withCountQuery(false)
        .withInlineCountQuery(false)
        .getResultList();

Hi and sorry it took so long for me to respond. This looks like a bug, but to be able to look into it more deeply, I'd need a reproducer. Could you please try to create one e.g. based on one of our quickstarts?


feat: add zod runtime validation for ethers adapter provider

Pull Request Checklist

[ ] Did you add new tests and confirm existing tests pass? (yarn test)
[ ] Did you update relevant docs? (docs are found in the site folder, see guidleines below)
[ ] Do your commits follow the Conventional Commits standard?
[ ] Does your PR title also follow the Conventional Commits standard?
[ ] If you have a breaking change, is it [correctly reflected in your commit message](https://www.conventionalcommits.org/en/v1.0.0/#examples? (e.g. feat!: breaking change)
[ ] Did you run lint (yarn lint:check) and fix any issues? (yarn lint:fix)
[ ] Is the base branch you're merging into development and not main?

PR-Codex overview
Focus of the PR:
This PR focuses on adding runtime validation for entryPointAddress in EthersProviderAdapterOpts and updating the schema in types.ts to support the validation.
Detailed summary:

Added runtime validation for entryPointAddress in EthersProviderAdapterOpts in provider-adapter.ts.
Updated the schema in types.ts to support the validation.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Current dependencies on/for this PR:

development

PR #185

PR #186

PR #187

PR #188   👈

PR #189

This stack of pull requests is managed by Graphite.


Fixed malformed code block

Codecov Report

Merging #5494 into 1.1 will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                1.1    #5494      +/-   ##
============================================
+ Coverage     82.45%   82.48%   +0.02%
- Complexity    11042    11048       +6
============================================
  Files          1334     1334
  Lines         45152    45152
  Branches       5682     5682
============================================
+ Hits          37229    37242      +13
+ Misses         5270     5261       -9
+ Partials       2653     2649       -4

Impacted Files
Coverage Δ
Complexity Δ

...in/java/io/crate/data/CollectingBatchConsumer.java
69.23% <0%> (-15.39%)
4% <0%> (-1%)

...te/executor/transport/SubSelectSymbolReplacer.java
68.88% <0%> (-11.12%)
3% <0%> (ø)

...ration/collect/collectors/OrderedDocCollector.java
90% <0%> (-10%)
5% <0%> (-1%)

...rate/action/sql/BatchConsumerToResultReceiver.java
87.5% <0%> (-6.25%)
16% <0%> (-1%)

...rc/main/java/io/crate/analyze/UnboundAnalyzer.java
80% <0%> (-5%)
2% <0%> (ø)

.../collect/collectors/LuceneOrderedDocCollector.java
90.12% <0%> (-3.71%)
25% <0%> (-1%)

...o/crate/planner/node/dql/join/NestedLoopPhase.java
74.69% <0%> (-3.62%)
20% <0%> (-2%)

...or/transport/distributed/DistributingConsumer.java
76.04% <0%> (-3.13%)
20% <0%> (ø)

...ava/io/crate/data/AsyncOperationBatchIterator.java
85.91% <0%> (-2.82%)
23% <0%> (ø)

...ql/src/main/java/io/crate/metadata/TableIdent.java
89.28% <0%> (-1.79%)
28% <0%> (-1%)

... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 688920e...5a86cea. Read the comment docs.


Use Doctest to test code-examples in the documentation

https://github.com/davidchambers/doctest

I believe this to be an impossibility. Doctest asserts the return values, whereas most of my code examples require console output (or rather, arguments given to continuations) to be asserted.

You're right. Doctests are really only suitable for straightforward input–output functions.


Event Request Page 10009 "Customer Order Header Status" OnBeforeOnAfterGetRecord

Hello, could you please add the event to page 10009?
trigger OnAfterGetRecord()
begin
    OnBeforeOnAfterGetRecord(Rec)

    GetLastShipmentInvoice;
    AfterGetCurrentRecord;
end;

[IntegrationEvent(false, false)]
local procedure OnBeforeOnAfterGetRecord(var SalesHeader: Record "Sales Header")
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


export filter actions

I wonder if we should export everything like we do in jsadmin-x projects

Codecov Report

Merging #399 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master    #399   +/-   ##
======================================
  Coverage    99.8%   99.8%
======================================
  Files         155     155
  Lines        3676    3676
  Branches      878     878
======================================
  Hits         3669    3669
  Misses          7       7

Impacted Files
Coverage Δ

src/Index.ts
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49018e6...b94a4ed. Read the comment docs.


raft: separate compact and createsnap in memory storage

Fix https://github.com/coreos/etcd/issues/2085
/cc @yichengq @bdarnell
We want to separate the compact and createSnap operations, since the application might not want to compact ALL in memory entries upto snapshot point.
Keeping some entries would help to send entries to followers who falls behind the snapshot point without reloading them from disk or requiring a snapshot.

@yichengq @bdarnell If you agree on this approach, I will add tests.

LGTM


allow readonly property to change

I propose a little change to allow the readOnly attribute to be an expression and to eventually changing over time.

Why do you use a function and watcher instead of using the two-way data-binding via the usage of ordinary scope-variable declared in the directive scope with =? ?

cause i need an expression to be there, but a 2 way binding could be sufficient, i can manage it in the upper controller.

Correclty and it would be faster because you save a watcher
Am 17.07.2015 17:19 schrieb "Jonathan Gotti"<EMAIL_ADDRESS>
cause i need an expression to be there, but a 2 way binding could be
sufficient, i can manage it in the upper controller.
—
Reply to this email directly or view it on GitHub
https://github.com/KillerCodeMonkey/ngQuill/pull/14#issuecomment-122309213
.

thinking about it again, we will have something like that with a =?:
                  if ($scope.readOnly) {
                        $scope.$watch('readOnly', function (readOnly) {
                            editor.editor[readOnly ? 'disable' : 'enable']();
                        });
                    }

So the watcher will still be needed and we don't really need a two way data binding in this case.
Actually using 2 way data binding will add one more watcher than expression.
Using an expression is basically how ng-readonly works.
What do you think?

it is okay.
But keep in mind you could do the whole thing without that whole stuff.
If the editor is created you can get the instance via the editorCreated-event -> you can manipulate the editor directly in your instance.
I added the readonly flag only if you know you do not need to enable the editor later.
Like you have different authorization roles and some can edit the whole thing, or after you have saved some stuff you are not able to edit it again.
So your last word, before i merge ;) ????

In our application the editable state changes over time and it seems more practical to do it that way.
So our last word is Yeah ;)

check

new release tag 1.0.9 --> available over bower

thanks

Can someone please clarify why readOnly should be a function and not simply a scope variable?
BTW, the readOnly change broke my application on live environment. Could you please consider a minor version bump instead of patch in case of breaking changes?

The ordinary readonly Attribute takes an expression to evaluate. Making
minor releases is a good approach.
Like i wrote in earlier comment. For me it is the same if the Attribute is
ordinary two way data binding or function call or boolean string.


example on how to export c++ class?

only find way to export function.

Thanks for the report! This is not really a concern of this crate since it's about importing code and this crate largely just tries to build code. C++ class cannot be directly imported by Rust but rather they need to have a wrapper exposed which can be imported, typically with the C ABI.


Remove typo "and and"

Just fixing a small typo on README.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Thanks!


Add ability to exclude specific branches from navigation tree

Search Terms
large number of interfaces and/or classes
slow documentation generation
Problem
The generation of the navigation tree takes a very long time when there are a large number of interfaces/classes in one file.  A tsc compilation takes <15secs... yet the rendering of the doco is taking ~35min.  The vast majority of this time is taken by the rendering of the navigation tree for every page (makes every page about 2mb).  We have a d.ts file that contains just shy of 9000 interfaces (~85k lines... essentially different database record layouts).
We did notice that if we split those interfaces across multiple files (1.25k lines each) then we can get the doco generation time down to ~2min.  Though this splitting causes many more files to be listed on the navigation tree making it less useful.  This does also raise the question why there is such a huge time difference when generating the doco for the same number of interfaces across multiple files versus all the interfaces in one file.
We know there is a typedoc.json 'navigation' property called 'fullTree' which can be set to false (and we have done this)... in the end this did not make the generation time any faster.
Suggested Solution
In typedoc.json add a 'navigation' property called something like 'excludeBranches' (string array) that will enable the developer to enter filenames (without the extension) to be interrogated in navigation.tsx ('navigation->links' method... property mod.name) to exclude child branches for the specified file.  The file name still appears in the navigation and is selectable... it just cannot be expanded in the navigation pane.  For us this cuts the page sizes from ~2mb per page to ~20k and the doco generation time reduced from ~35min to ~35secs.

Yikes, that's a lot of interfaces... I think this makes sense to do, even with upcoming efficiency improvements for navigation, as that many navigation elements probably makes the tree not very useful to begin with.

I just published version 0.25.1, I'm curious if the navigation changes in that release solves the performance issue before doing this

I just published version 0.25.1, I'm curious if the navigation changes in that release solves the performance issue before doing this

hi @Gerrit0
The dynamic build of the navigation is good... large reduction of time... ~35min -> ~45 seconds... thank you :)
The new "excludeCategories" (for us) does not address the enhancement request.  It appears that the excluded categories are excluded from the typescript compilation (which as you may guess causes compilation errors).  The enhancement request was to exclude from the navigation only... we also would like to exclude categories 'by file' from the navigation... not just individual components.  As it currently stands we'd need to list all ~8800 entries in typedoc.json under "excludeCategories" ... and this causes the same number of warnings to be written to the console about "not included in the documentation"... so another ~8800 entries to typedoc.json under "intentionallyNotExported" to suppress the warnings.

excludeCategories was for a completely different feature request - #1407 :)
I was mainly curious if this was still useful with the dynamically loaded navigation, it seems like it is, so will likely be included in the next release


(docs) add a note to epp about loading any file with absolute path

Add a short note about absolute paths.

CLA signed by all contributors.


Error when creating a OpenStack VM without setting the default key

Error when creating a OpenStack VM without setting the default key.
The command is:
ansible-playbook playbook/openstack/openstack_vm_create_passwordstore.yml -e k8s_type=masters -e k8s_version=123 -e '{"openstack": {"vm": {"network": "provider_net_shared","image": "Fedora-Cloud-Base-35", "flavor": "m1.medium"}}}' -e key_name=test-adm-key -e vm_name=${VM_NAME}

The error is:
TASK [openstack/vm : Create VM instance] *********************************************************************************************************************************************************************************************
Thursday 15 June 2023  10:06:52 +0200 (0:00:00.088)       0:00:37.426 *********
fatal: [localhost]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'openstack_keypairs'. 'dict object' has no attribute 'openstack_keypairs'\n\nThe error appears to be in '/home/ajc102/docs/redhat/forks-github/k8s-infra/ansible/roles/openstack/vm/tasks/vm_create.yml': line 95, column 5, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n  - name: \"Create VM instance\"\n    ^ here\n"}

The problem might be related with upgrading the openstacksdk version as some variable has changed name.


Migrate positionals types and definitions from core/jobs to data to better support layering.

These lint failures are from WHM changes, unrelated to this change.

Migrated MNK potency definitions to data so they can also all be layered, I wrote two potency utility functions and slapped them into action/index but I'm also open to those living in a better place. In terms of expression it would be most convenient if they were defined on the interface itself, but I think it's best to just have external utilities.

I think there may be some value to circle back on this, with respect to ayyaruq's comments on the naming and I'm not 100% sold on why separate modifier types for COMBO & POSITIONAL vs buffs/traits like Lance Mastery or Leaden Fist.  But this does what it says on the tin and provides a good improvement to get positional data into the layers structure, so I'm going to merge it as is and request some additional consideration of the naming for a follow-up PR.


Changes to remove errors in dsl and api tests .fsx

I'll let Don review this.
For the most part it looks fine to me.

Thank you!
We really need to set up the tests project to start including systematic content :)


how to process a block of text instead of a line by line processing?

First of all, thank you for the good work.
The example in the read me demonstrates how to use easybatch and process files in a line by line basis.
Job job = new JobBuilder()
         .reader(new FlatFileRecordReader("tweets.csv"))
         .filter(new HeaderRecordFilter())
         .mapper(new DelimitedRecordMapper(Tweet.class, "id", "user", "message"))
         .marshaller(new XmlRecordMarshaller(Tweet.class))
         .writer(new FileRecordWriter("tweets.xml"))
         .batchSize(10)
         .build();

JobReport report = new JobExecutor().execute(job);

I have an input file with blocks of text:
#    batch
    00001
              test10 test11
              test20 test21
              test30 test31
     end

     #junk data

    batch
    00002
             test40 test41
     end

and I would like to input the result as a csv file like this:
00001;test10;test11
00001;test20;test21
00001;test30;test31
00002;test40;test41

So I need to store data (eg. batch number), then use them to create the subsequent lines until I hit another relevent data, and so on.
Before I dive any further in the code, I would like to know whether this is actually possible?
Also, my input files are quite massive, is there a way to output progress whenever I hit, say for my example, a new batch number?
Thank you again.
Majid

Hi Majid,

First of all, thank you for the good work.

Thank you!

I would like to know whether this is actually possible?

Yes, you can do it with a custom reader. There is a tutorial here that may help you. It reads records that are on multiple lines as in your use case.

Also, my input files are quite massive, is there a way to output progress whenever I hit, say for my example, a new batch number?

A PipelineListener is the way to go. It's a callback that allows you to execute custom code before/after each record. There is an example here that may inspire you. You can find more details on listeners in the documentation.
Please let me know if this helps.
Kind regards
Mahmoud

Hi,
Does this helped?
Kr
Mahmoud

I'm closing this issue.
If you have any other question, you can reopen this issue.


Fix AccessEnforcementOpts in debug builds.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci smoke test and merge.

@atrick why was this broken? You aren't specific in the commit message.

Debug builds leave in static markers, which none of this stuff cares about, and there was an assert to check that the analysis covered all the markers.

Thanks!


Fix SCP writer to always write complete revolutions.

There were a couple of problems that needed to be fixed:

Fluxmaps can be produced with zero index pulses by encoders.
This is somewhat ambiguous but it's assumed that this means there
is exactly one revolution.

The SCP unindexed mode wasn't properly supported, as it should
create equal-length revolutions not aligned to indexes. However,
fluxmaps don't contain any information on rotation speed. Therefore,
drop the ability to create unindexed SCPs and slightly change the
meaning of the option to not include pre-index data.

Real flux reads can potentially produce duplicate index pulses.
Avoid creating zero-length revs.

Fix off-by-one error for rev count.

You'll probably be unthrilled to hear that I recently added a F_DESYNC event to the bytecode stream (which is represented as a zero, which used to be EOF) to represent an arbitrary gap. This is used for combining flux from multiple reads, as maintaining multiple flux streams made things too complicated.
I think you'll need to discard any revolutions containing any of these so that you're left with known complete revolutions. This probably wants something like a FluxMap::trim() which does the work, returning a new fluxmap, as it'd be useful elsewhere.

I think that's actually broken for all the flux sinks right now, as I don't think any of them really support multiple flux streams (A2R does, for when I add it). I can open a separate PR to edit them all to only use the last segment in the stream.

Merged; thanks!


Implement FIFO audio channels

There are two "easy" channels of audio to implement that could be my first ones.
Each channel selects one of timer 0 or timer 1, then whenever that timer overflows an 8 bit sample is transferred from the FIFO buffer to the audio device.
If after transferring a byte to audio device there is only 16 bytes left in the FIFO buffer then trigger a DMA from the requested DMA channel (0 or 1) which will move 4 words across and pause the cpu.
I'm not really 100% sure what to do with that 8 bit sample after it gets moved out of the FIFO buffer but I could write all of this without actually doing anything with that to start with.

There's a simple test called SoundPCMMono which Peter Lemon wrote and uses a single DMA channel to play some instrumental music. The code for it is:
Start:
  PlaySoundA SOUND, 48000 ; Play Sound Channel A Data

  imm16 r0,557 ; R0 = Number Of 1/16 Seconds To Wait
  Loop:
    TimerWait TM2CNT, Second16th ; Wait On Timer 2 For 1/16 Second
    subs r0,1 ; Number Of 1/16 Seconds To Wait--
    bne Loop ; IF (Number Of 1/16 Seconds To Wait != 0) Loop

  StopSoundA ; Stop Sound Channel A Data

  b Start ; Repeat Sound Playback

and that then refers to a PlaySoundA routine which is:
macro PlaySoundA Source, Frequency {
  mov r11,IO ; GBA I/O Base Offset
  imm32 r12,Source
  str r12,[r11,DMA1SAD] ; Sound A Sample Source To DMA1 Source Address
  imm16 r12,SOUNDA_FIFO_RESET or SOUNDA_LEFT or SOUNDA_RIGHT or SOUNDA_VOL_100
  strh r12,[r11,SOUNDCNT_H] ; Sound A FIFO Reset, Sound A Timer 0, Right & Left Enable, 100% Volume
  mov r12,SOUND_ENABLE
  strb r12,[r11,SOUNDCNT_X] ; PSG/FIFO Master Enable
  orr r12,r11,FIFO_A
  str r12,[r11,DMA1DAD] ; Sound A FIFO To DMA1 Destination Address
  imm32 r12,DMA_ENABLE or DMA_32 or DMA_SPECIAL or DMA_REPEAT or DMA_DST_FIXED
  str r12,[r11,DMA1CNT] ; DMA1 Control
  mov r12,TM_ENABLE ; Timer 0 Enable, Sound Frequency
  orr r12,(65536 - (16777216 / Frequency)) and $FF
  orr r12,(65536 - (16777216 / Frequency)) and $FF00
  str r12,[r11,TM0CNT] ; Play Sound A
}

My understanding was that on each channel running low on samples a new DMA was requested and that the source address was reset, that doesn't make sense here though because the sound starts at 0x0800015C and goes on for lots more than 4 words.

Timer 0 is used here and is set to F_1 (count on each master clock cycle) with a reload value of 65536 - (16777216 / 48000) which is ~65187 (my emulator agrees thats the reload value)
So every 65535 - 65187~=350 cycles a new sample is going to be moved from FIFO to the current sample.
However, how often does the gba actually sample the channel? If it's at 16777216/32768 then we'll get a sample every 512cycles which means we'll miss nearly 1 in two samples.


zip AWS S3 files to a new location in S3 bucket

Hi Sir,
I couldn't find a way to zip my files in S3 bucket and save the zip to a new location at s3 itself.
Please suggest on this.
Thanks,
Prashan

This feature request already is open for a while but we didn't receive any PR or had time to work on. We will close it until we had more concrete plains to evolve it.

This feature request already is open for a while but we didn't receive any PR or had time to work on. We will close it until we had more concrete plains to evolve it.


Error: Cannot find module ../juice-shop/build/app

Hi, when i run Juice-shop in linux, I get the following error:

<EMAIL_ADDRESS>start
node build/app

node:internal/modules/cjs/loader:959
throw err;
^
Error: Cannot find module '/home/Kali/Documents/juice-shop/build/app'
at Function.Module._resolveFilename (node:internal/modules/cjs/loader:956:15)
at Function.Module._load (node:internal/modules/cjs/loader:804:27)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
at node:internal/main/run_main_module:17:47 {
code: 'MODULE_NOT_FOUND',
requireStack: []
}
Please help me.
Thank you.

Did npm install fail with any errors before you ran npm start?


Make book example code compile

This example code doesn't work since it calls build_ui rather than passing it directly. Removing the parentheses fixes the problem. Note that this is my first interaction with druid, so my fix may not be idiomatic? Would love to hear of a better solution if that's the case.

I believe both the book and the README are intended to talk about 0.7 rather than the master branch.

I'm using druid 0.7.0, rustc 1.52.1, windows 10. Is this api changing in druid 0.8?

Yes the book is targeting the git version

I'm using druid 0.7.0, rustc 1.52.1, windows 10. Is this api changing in druid 0.8?

Yes See #1559

Cool, my bad then. I'll close the pr


Looks Admob Pro not working well with new XDK 2496

Crosswalk Android Build failed to load dependency.

How do you reproduce the error? And, can you paste the log?

What went wrong:
A problem occurred configuring root project 'android'.

Could not resolve all dependencies for configuration ':_armv7DebugCompile'.
Could not find any version that matches
com.google.android.gms:play-services-ads:+.
Searched in the following locations:
https://repo1.maven.org/maven2/com/google/android/gms/play-services-ads/maven-metadata.xml
https://repo1.maven.org/maven2/com/google/android/gms/play-services-ads/
https://download.01.org/crosswalk/releases/crosswalk/android/maven2/com/google/android/gms/play-services-ads/maven-metadata.xml
https://download.01.org/crosswalk/releases/crosswalk/android/maven2/com/google/android/gms/play-services-ads/
Required by:
:android:unspecified

Switch back to 2.9.6 and worked
On Fri, Oct 2, 2015 at 12:09 AM, Raymond Xie<EMAIL_ADDRESS>wrote:

How do you reproduce the error? And, can you paste the log?
—
Reply to this email directly or view it on GitHub
https://github.com/floatinghotpot/cordova-admob-pro/issues/232#issuecomment-144940175
.

That's because Intel XDK does not support build with gradle.
See:
https://github.com/floatinghotpot/cordova-admob-pro/wiki/Difference-of-Plugin-IDs

I tried with both versions and sadly getting the same error for both:
Error: Plugin "" failed to install.
Error: Could not retrieve plugin dependencies for AdMob Plugin Pro'.
Error: Plugin AdMob Plugin Pro failed to install.
Plugin "org.apache.cordova.device" (0.2.13) installed.
Plugin "org.apache.cordova.vibration" (0.3.12) installed.
Plugin "com.adobe.plugins.GAPlugin" (2.4.0) installed.
Plugin "cordova-plugin-x-socialsharing" (5.0.3) installed.
Plugin "com.rjfun.cordova.extension" (1.1.4) installed.
Plugin "cordova-plugin-googleplayservices" (19.0.3) installed.
Plugin "org.apache.cordova.inappbrowser" (0.6.0) installed.

That's using cordova-plugin-admob v2.9.7
Looks like com.google.cordova.admob won't install anymore either due to an id mismatch with the google play library. Pretty sure I used to have it working with that.
Going to keep trying different combinations and will update once something works with latest XDK.

Here's that google play services error btw:
Expected plugin to have ID "com.google.playservices" but got "cordova-plugin-googleplayservices".

Success! Just got it working with latest (2496) XDK.. here's how:

Explicitly install 3rd party plugin com.google.playservices
Explicitly install 3rd party plugin com.google.cordova.admob

Build should work then. I tried all the other combinations of the other plugin ids and no luck.. sounds like due to the lack of Gradle support. Anyway, this is working fine for me now - just tested on a banner ad. Thanks @floatinghotpot for this awesome plugin!

Please be aware that, Intel XDK is loading plugin from cordova plugin registry. But the registry is being deprecated, the official cordova CLI loads plugin from npm. The cordova plugin registry is now read-only and not allowed to update, I am not sure when the registry will be closed.
As Intel XDK does not load plugin from npm yet. You can try another workaround:

download the following plugins to local folder by run npm install <plugin_name>:
cordova-plugin-extension
cordova-plugin-googleplayservices
cordova-plugin-admob

Using Intel XDK to load the plugin from local folder.

Thanks for the quick response! It works now.

Hi @floatinghotpot I'm trying to get the npm install working for the facebook and iad mediation adapters since I plan on using those two networks, but I'm getting 404 not found. Do you know if there's another way to get those installed using XDK by chance?
cordova-plugin-admob-facebook
cordova-plugin-admob-iad
Just to make sure, those two plugins are required to use admob mediation right?

Oh weird! Sorry please ignore that last post. I don't know what I was doing wrong yesterday, but I ran
$ npm i cordova-plugin-admob-iad
and it's installing just fine now for everything. However I found a much better fix for this XDK issue.
@zhao0057 @floatinghotpot It turns out that XDK (v2548) can move up to Cordova CLI v5.1.1 and install this plugin by just adding cordova-plugin-admob without doing any special. In Build Settings for the XDK project, just look in there for the drop-down to select which Crodova version to use. It took a little finagling, but I was finally able to get everything working now and see AdMob test ads working.
Hope that helps!

The only thing to be aware of before rolling up your Cordova version is that there is currently a bug with XDK for some cordova plugins:
https://software.intel.com/en-us/forums/intel-xdk/topic/595059
I'm not seeing that with the iad mediation adapter, but I am seeing that with the facebook adapter.
That Intel post was from today, so hopefully they will have a fix for this issue sometime soon. In the mean time I will just stick with iad mediation and deal with facebook later.

hello guys i build my app and i wanna add cordova admob but i don t know how to do it i have the plugin already added to my app so where should i put the code to rune admob into my app please help me
thx


[Hub Generated] Review request for Microsoft.ContainerService/aks to add version stable/2023-06-01

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM (Control Plane) API Specification Update Pull Request
Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!

[x] New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix swagger quality issues in S360.
[ ] Other, please clarify:

edit this with your clarification

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[x] I have reviewed the general guidance on the spec PR review process: https://aka.ms/specprreview.
[x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data-plane related specifications.
[x] I commit to follow the Breaking Change Policy.
[x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can request review from an ARM API Review board.

ARM API changes review

If you want for the ARM team to review this PR, you must add the ARMReview label.
The automation may automatically add the ARMReview label, if appropriate.
If this happens, proceed according to guidance given in GitHub comments also added by the automation.

Breaking change review
If you have any breaking changes as defined in the Breaking Change Policy,
follow the process outlined in the High-level Breaking Change Process doc.
Getting help

For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For additional help, see https://aka.ms/azsdk/support/spectools.

@FumingZhang There are so many breaking changes in Python SDK for new api version. Are  they expected?

Hi @msyyc, it seems that the breaking change is about to have all models/operations exclusive to the preview API removed.

The reasonable part is that starting from this API release, we will first merge the PR of the stable API, so the current python readme does not contain the tag of the 06 preview API.
But the unreasonable part is that the python SDK supports multiple APIs, and the previous preview APIs are still included, so compared with the released version 24.0.0 (latest stable 05-01 (default), latest preview 05-02-preview), these two API versions are still included (I could confirm this with the draft PR), just add a new stable API 06-01 (new default).

I guess there is something wrong with the detection?

Operation ManagedClustersOperations.begin_delete no longer has parameter ignore_pod_disruption_budget

Some breaking like Operation ManagedClustersOperations.begin_delete no longer has parameter ignore_pod_disruption_budget is caused by comparing 2023-06-01 with 2023-05-02-preview. Maybe I could optimize changelog to make sure comparision between stable api-version. By the way, when will you add the parameter of preview api version to stable api version?

Operation ManagedClustersOperations.begin_delete no longer has parameter ignore_pod_disruption_budget

Some breaking like Operation ManagedClustersOperations.begin_delete no longer has parameter ignore_pod_disruption_budget is caused by comparing 2023-06-01 with 2023-05-02-preview. Maybe I could optimize changelog to make sure comparision between stable api-version. By the way, when will you add the parameter of preview api version to stable api version?

I've updated the python readme to include preview API tag in a sibling branch FumingZhang-containerservice-Microsoft.ContainerService-2023-06-02-preview. I'll rebase from main once this PR is merged to resolve the conflict on readme and have both stable (2023-06-01) and preview (2023-06-02-preview) API included.

      "type": "boolean",

Please consider moving to string enum for these kinds of properties. ARM review prefers enum over booleans for many reasons. Booleans are convenient for API developers, but enums are more convenient for API clients. You could use something similar to verticalPodScaleBehavior: { Auto, Manual }. Ref: https://eng.ms/docs/products/arm/rp_onboarding/process/api_review_best_practices.

Refers to: specification/containerservice/resource-manager/Microsoft.ContainerService/aks/stable/2023-06-01/managedClusters.json:6242 in f88cf2c. [](commit_id = f88cf2c76f497645634dafa7d14534f24c69aec7, deletion_comment = False)

      "type": "boolean",

Please consider moving to string enum for these kinds of properties. ARM review prefers enum over booleans for many reasons. Booleans are convenient for API developers, but enums are more convenient for API clients. You could use something similar to verticalPodScaleBehavior: { Auto, Manual }. Ref: https://eng.ms/docs/products/arm/rp_onboarding/process/api_review_best_practices.
Refers to: specification/containerservice/resource-manager/Microsoft.ContainerService/aks/stable/2023-06-01/managedClusters.json:6242 in f88cf2c. [](commit_id = f88cf2c, deletion_comment = False)

@mentat9 - AKS uses enabled booleans all over for enabling optional features (sometimes called Addons) and keeping this a boolean matches the pattern used in the rest of the API. Here are a few examples: #1, #2, #3.
We're in agreement that enum > boolean, but there is also value in consistency of user experience and we have a ton of this pattern elsewhere in the API and tend to value providing consistency of user experience even if it means that our ability to expand these values capabilities is reduced. In general (and you can see in this instance as well) these enabled flags are in a complex type, so if we needed to say expand and offer different modes, we can do so by adding an additional enum at that time: enabled: true|false and mode: A|B.

      "type": "boolean",

Please consider moving to string enum for these kinds of properties. ARM review prefers enum over booleans for many reasons. Booleans are convenient for API developers, but enums are more convenient for API clients. You could use something similar to verticalPodScaleBehavior: { Auto, Manual }. Ref: https://eng.ms/docs/products/arm/rp_onboarding/process/api_review_best_practices.
Refers to: specification/containerservice/resource-manager/Microsoft.ContainerService/aks/stable/2023-06-01/managedClusters.json:6242 in f88cf2c. [](commit_id = f88cf2c, deletion_comment = False)

@mentat9 - AKS uses enabled booleans all over for enabling optional features (sometimes called Addons) and keeping this a boolean matches the pattern used in the rest of the API. Here are a few examples: #1, #2, #3.
We're in agreement that enum > boolean, but there is also value in consistency of user experience and we have a ton of this pattern elsewhere in the API and tend to value providing consistency of user experience even if it means that our ability to expand these values capabilities is reduced. In general (and you can see in this instance as well) these enabled flags are in a complex type, so if we needed to say expand and offer different modes, we can do so by adding an additional enum at that time: enabled: true|false and mode: A|B.

@matthchr - Thank-you for considering this request. Please keep the idea in mind for future evolution of your RPs APIs. I've signed off for ARM.

Hey @rkmanda, the PR has been signed off by ARM, and there's no required CI failing. Does this mean it meets the bar to be merged? If so, I would like to submit the SDK release request first and keep it open until the service is ready. Please DO NOT merge the PR at this moment, thanks!

The service is ready in public cloud, please help merge the PR ASAP @rkmanda