Check FreeRTOS timer status before disabling it

I am not sure if this is really needed - it means that we try to stop some timer (callout) which was not initialized before so this possibly just hides some other issue.
did you encounter any problems without this fix?

In the function ble_hs_start, the timer ble_hs_timer is stopped before initializing it. In my case, the FreeRTOS will assert for the timer is NULL.

can we merge?

I highly recommend it.

I'd really prefer that we fix mentioned NimBLE code which clearly does stop before init which looks just weird in code. I'm not sure yet how to do this since I do not know why this was needed there (apparently something with unittests).

In my opinion, ble_npl_callout_stop is trying to stop a item no matter whether it is running. If it is not running, do nothing.

agree but it should be initialized before it's used - in this case it clearly is stopped before it's initialized which does not seem right

So what shall we do next? Do you have a internal discussion?

We are also seeing the same issue

imo what is needed is to fix stop-before-init code instead of working this around in NPL.
feel free to provide fix, I may not have spare time in the next few days to look into this.

@andrzej-kaczmarek @sterlinghughes @yang325 It looks like this was added with commit 65d827c5938ccf644e9845bbd56063dc1a630142, to fix the unit tests?
If you see the code, in ble_hs_start it stops/resets before doing init. See here: https://github.com/apache/mynewt-nimble/blob/a1bfe3a6ae4adabbac9c9da7de8c7966569ae6dd/nimble/host/src/ble_hs.c#L647
Let me know, if it is okay to remove this. It should solve the problem in this case.

@sterlinghughes @andrzej-kaczmarek What else shall I do before this PR is accepted ?

@yang325 @dhrishi I think I explained this already, but let me clarify once more: in my opinion there is no issue in FreeRTOS NPL which assumes that callout which we try to stop was previously initialized (otherwise we need to modify every single NPL API to make checks if objects are valid to be consistent here). This is apparently not the case due to change made in mentioned commit so proper solution is to rework that fix so it will not try to stop callout before it was initialized. Simply removing that code is not a proper solution since it will most likely cause new regression.
I do not know what is the proper fix in the code here since I did not have time to analyze this. Feel free to do this and provide fix which resolves mentioned issue and will not cause regression. Also, in case you disagree with my analysis please simply provide a reasonable arguments and I'll reconsider the workaround for sure.

Got it. There should be a better solution. Maybe I should have posed an issue.

@andrzej-kaczmarek Thanks for your response.

proper solution is to rework that fix so it will not try to stop callout before it was initialized.

I agree to this partially. I mean, this will help us fix this issue, no doubt. But this will be specific to this scenario only. If tomorrow someone calls these APIs in sequence from somewhere else then that will have to be fixed again.
May be that is the same reason why implementation of ble_npl_callout_stop in NPL for Linux has a check to see if it was inited before stopping it. So, I think the change in this pull request should be good.
Although, the check can be made through an API (just like the Linux implementation does), which can be used from other places going ahead, if required.
Let me know if you feel this is not the right approach or if I am missing something.

@dhrishi calling any other API on an unitialized callout should be simply considered invalid so of course someone can do this in future, but it will need to be fixed.
I believe this PR should fix the issue without breaking unit tests: https://github.com/apache/mynewt-nimble/pull/279


FEAT: Deploy storybook to gh pages

Changes

Deploy Storybook to GitHub Pages.

For some reason https://lifeomic.github.io/chroma-react/ isn't working for me, but https://lifeomic.github.io/chroma-react/index.html is...?  I'm going to wait to see if it's a delay in the deploy, as I've seen that before.  Otherwise, I'll file an issue somewhere.  If anyone has any clues here, would be much appreciated 🙏

For some reason https://lifeomic.github.io/chroma-react/ isn't working for me, but https://lifeomic.github.io/chroma-react/index.html is...? I'm going to wait to see if it's a delay in the deploy, as I've seen that before. Otherwise, I'll file an issue somewhere. If anyone has any clues here, would be much appreciated 🙏

Sounds like it's just a caching issue for me and is working for others, so ignore! We should be good! 🚀


Delete unnecessary spaces

Delete unnecessary spaces: When copying from the web page, there is an unnecessary space after the code.
Fix indent: Indentation is misaligned.

@changeworld : Thanks for your contribution! The author, @dkkapur, has been notified to review your proposed change.

@changeworld : Thanks for your contribution! The author, @dkkapur, has been notified to review your proposed change.

Verified the updates; merging.


Cherry pick "Fix post_install_workaround downgrading development targets" to 0.66-stable

Summary

ℹ This is a cherry-pick of #32633 to 0.66-stable
The __apply_Xcode_12_5_M1_post_install_workaround script changes the IPHONEOS_DEPLOYMENT_TARGET to 11.0 for all pods. This causes problems if the pods were targetting 12.0 or higher. Many expo modules are targetting 12.0.
I fixed this issue by checking the existing version and only bumping the target if it is lower than 11.0.
See also: this discussion post by @mikehardy https://github.com/reactwg/react-native-releases/discussions/1#discussioncomment-1619523
Changelog

[iOS] [Fixed] - __apply_Xcode_12_5_M1_post_install_workaround causing pods targetting iOS 12 and above to fail
Test Plan

Test (failing before this patch, passing after this patch)

pick an iOS Pod that has a minimum deployment target of iOS 12 or higher, I chose the Braintree package
npx react-native init myrnapp
Open ios/Podfile and add the pod as a dependency: pod 'Braintree', '~> 5' (and upgrade the Podfile target to 12 (platform :ios, '12.0'))
Compile the app.

Before applying this patch: ❌ Build fails because Braintree uses iOS 12 features and was downgraded to target 11.0
After applying this patch: ✅ Build succeeds

Not sure of the process but I think the release management folks just command line these @lunaleaps ?
Not to take away from the fix itself being helpful 🙂

@mikehardy I'm looking to change the process so the work is placed on the pick requester -- really the "work" here is figuring out merge conflicts and also triggering our CircleCI tests. Granted, our CircleCI tests don't really provide much coverage yet but I think building the habit won't hurt.


Check a single application for status instead of all

Fixes #95

:+1: LGTM

@gambol99 did you forget to merge after your LGTM? Or is anything still holding us back?

@timoreimann .. just my forgetful self :-) ... merging now ..

awesomely quick response. appreciated! 👌


Annotation isn't dismissed clicking an empty space, covered by the native selection range ⚠

Background
While handling the pointerup event, checking the document.getSelection().isCollapsed property can behave in 2 ways:

You made a selection and clicked on it. Then, the isCollapsed is false even though the native highlight disappears! ⚠
You made a selection and clicked somewhere else. Then, the isCollapsed is expectedly true, matching the native highlight disappearance.

https://github.com/user-attachments/assets/919f9e25-0852-4aec-85fa-983532243060
Issue
In the SelectionHander the annotation selection gets dismissed only when the pointerdown + pointerup combination is recognized as the "click" and there's nothing "hovered" (lines 152-155 & 144-146):
https://github.com/recogito/text-annotator-js/blob/e6d3f33339ab1f4cd2ccb6b77624c20f12841ee4/packages/text-annotator/src/SelectionHandler.ts#L149-L157
https://github.com/recogito/text-annotator-js/blob/e6d3f33339ab1f4cd2ccb6b77624c20f12841ee4/packages/text-annotator/src/SelectionHandler.ts#L134-L147
However, as the document.getSelection().isCollapsed is false when you click over the native selection range, the annotation selection sometimes doesn't get dismissed!
Instead, the annotation gets selected another time, because the currentTarget is still present!
Alternatively, we expect that the annotation selection will behave like the native selection highlight in all cases. When you click on an empty space - it should be dismissed.
Issue Examples
https://github.com/user-attachments/assets/aee59f76-890b-4571-9614-03ca3bb051e2
https://github.com/user-attachments/assets/2997c3f1-5da3-4b15-935c-b9dad0cfd587
Suggested Changes
The root of the issue is the document.getSelection().isCollapsed that is "lagging behind" on the pointerup event handling.
After I added a 0ms. timeout for the reading, I started getting more adequate value consistently. It's always true either when you click on the selected range or some other content.
https://github.com/user-attachments/assets/35ef211b-06cb-4669-a50f-d6e0764aec68
In that way, the "click" will always get processed consistently and the annotation selection will get dismissed when you didn't click on the highlight explicitly.

Just adding that this should now also work in the revised-selection-behavior branch.

Hello @rsimon 👋🏻
Unfortunately, I noticed that the "lagging behind isCollapsed property" is still a thing for touch devices! When I tap somewhere around the selection - the isCollapsed is still true when the onPointerUp gets handled, even within the setTimeout


AWS JS SDK Fails with this dependency

Some how the AWS JS SDK uses this package and in rng.js which I don't seem to find anymore in this source code creates an undefined variable  for _global which we fixed with this:
var_global = this || window || {};
You can find more issues related to this package here:

https://github.com/aws/aws-sdk-js/issues/1512
https://github.com/aws/aws-sdk-js/issues/1566

Where the full source for this package so I can write a patch for this fix?

the error is in randombytes but the real issue is that this was written for browserify/webpack with the assumption that there will be a variable named 'global' and thus bundling this with certain webpack configurations will break that assumption

@calvinmetcalf we could || window it.  Though,  it does sound like a problem with their build process, not us.

ok I just went and looked at the actual library, and we don't use the rng.js file anymore so this is almost certainly an issue with a really out of date version of this library

Where can I find the latest version of the library, I think I'll need to create an issue with the AWS sdk people to update the libary.

they have said in the issue that they don't rely on the this anymore so the
only reason you'd be getting it is an out of date version of aws
On Wed, Sep 19, 2018 at 11:50 AM Nyah Check<EMAIL_ADDRESS>wrote:

Where can I find the latest version of the library, I think I'll need to
create an issue with the AWS sdk people to update the libary.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/crypto-browserify/crypto-browserify/issues/180#issuecomment-422855338,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABE4n8NsIOzogK-eNQwGU1-gXrCoOO46ks5ucme0gaJpZM4WuX30
.

that's weird because I just installed the latest version from yarn except it doesn't have the latest version. However, I just filed some issues with them to see if they can get this resolved.

what are you using to bundle the library and have you tried removing your yarn.lock

I'm using webpack and I've reinstalled all the packages, and the currently supported crypto-browserify version is 1.0.9  seems like this needs to be updated. I don't really know the current version now.

3.12.0

I've added a PR to the amazon-identity package.


Implement azure maps weather

Implementation of Azure.Maps.Weather

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Maps.Weather

We should also hide all GeoJsonxxx classes (Make them internal classes), for example: GeoJsonPoint, GeoJsonMultiPoint, GeoJsonLineString, GeoJsonMultiLineString, GeoJsonPolygon, GeoJsonMultiPolygon, GeoJsonGeometryCollection, GeoJsonFeature, GeoJsonFeatureCollection

Overall it looks good! I'll approve it when all the comments are resolved. Thanks for the great effrot, @zhz0704 !

Done :)


Version 3.0 of ryanmulligan.dev

Work in progress: A rebuild from the ground up using webc and 11ty 🎉

Deployment testing completed. Closing this until fully ready for launch


High CPU usage when playing audio

While listening today, I noticed a stutter every so often in playback, and traced that to very high CPU usage from black candy when playing in Safari

It is a large file encoded in ALAC, and while I have "Allow transcode lossless" switched on, I'm seeing AAC listed in the safari network pane, so perhaps the transcode is happening on my local machine which is causing the high CPU.

I don't have this same issue in Jellyfin, my current primary player which I'd like to switch away from, so seems specific to BlackCandy, and when playing in Jellyfin, it looks like it is transcoding to m4a:

ALAC encoded file can stored within an mp4 container with  .m4a filename extension. You know .m4a filename extension can also be used as lossy formate. Black candy just simple use filename extension to check if the formate is lossless or not. So like ALAC encoded file, black candy just treat it as a lossy formate. So there is no transcoding when playing ALAC encoded file. I am not quite   sure why playing ALAC encoded file cause high CPU usage.  This need deeper investigation. It would be great if you can send me the sample file that cause high CPU usage.

This one causes it:
https://ln5.sync.com/dl/05b929890#4zzsf9cn-un6mcbsg-e8cdxsba-r3xs88gf

I got the file. Thanks

Hi,  I have founded the reason why the high CPU usage when playing audio on safari. It's not because the issue of transcoding. When I was playing  mp3 I still got high CPU usage on safari. On my laptop it's about 50% usage on CPU. Then I've founded that's because I update the DOM of  song playback timer on window.requestAnimationFrame, that will cause a lot of repaint on safari therefore high CPU usage.
But on this issue there is another problem need to be solved. The problem is black candy can not check if the formate is lossless or no when the formate use general container, like mp4 container. And I will create another issue for this problem.


Adds missing error in db package

Fixes: #1913

@mcollina @marcopiraccini While adding a test I discovered that that line is unreachable because an error is thrown already here in case the protocol is not valid.
I updated the PR


HLS 4 - Crossdomain support?

I have a video split to HLS version 4.
Mejs play well in same domain. But with cross domain (was set Access-Control-Allow-Origin "*" in header) Mejs not playing....

All GET XHR request replace to OPTIONS XHR request. This caused error.
I don't known about this. On HLS version 3 Crossdomain is not issue.
Please help me!!

You may need to post this on hls.js project since it has nothing to do with the player

You have to set CORS in the server because even in the main website I'm using an HLS from a different domain

But post your question in HLS for more guidance on your case


Module gives hints about security config of accounts.

I configured the pam module in conjuction with sshd and it works great.
Yet I see a pattern which seems to 'leak' information about the chosen security config.
On my server I have NOT set the nullok because I want all accounts to have the OTP.
When someone does ssh<EMAIL_ADDRESS>the system will simply ask for the password because there is no user called foo. Doing the same for a user account that does exist then the prompt for the OTP code is presented before presenting the password (I have configured it this way).
This difference leaks information about the accounts and how they have been configured:

If it asks for a code: account exists and OTP has been configured.
If it does NOT ask for a code: either account does not exist and/or OTP has not been configured.

I think that when this module has been configured without 'nullok' that the system must always ask for an OTP code, even though any code you enter will be wrong (as it has not been configured and/or the account simply does not exist).

Could you share your PAM setup?

But yeah this seems likely, and it's a consequence of the conditional of doom that should be split up.

Yes.I have quick test implementation on my machine. I'll see if I can put up a pull request later this week.

The config of the separate CentOS7 VM I created to test my changes:
/etc/pam.d/sshd
I simply added the top line
#%PAM-1.0
auth       required     /usr/local/lib/security/pam_google_authenticator.so secret=/var/lib/google-authenticator/${USER} [authtok_prompt=Give me the code: ] echo_verification_code user=root  debug
auth	   required	pam_sepermit.so
auth       substack     password-auth
auth       include      postlogin
# Used with polkit to reauthorize users in remote sessions
-auth      optional     pam_reauthorize.so prepare
account    required     pam_nologin.so
account    include      password-auth
password   include      password-auth
# pam_selinux.so close should be the first session rule
session    required     pam_selinux.so close
session    required     pam_loginuid.so
# pam_selinux.so open should only be followed by sessions to be executed in the user context
session    required     pam_selinux.so open env_params
session    required     pam_namespace.so
session    optional     pam_keyinit.so force revoke
session    include      password-auth
session    include      postlogin
# Used with polkit to reauthorize users in remote sessions
-session   optional     pam_reauthorize.so prepare

I only changed the ChallengeResponseAuthentication yes
cat /etc/ssh/sshd_config | grep -v '^#' | grep .
HostKey /etc/ssh/ssh_host_rsa_key
HostKey /etc/ssh/ssh_host_ecdsa_key
HostKey /etc/ssh/ssh_host_ed25519_key
SyslogFacility AUTHPRIV
AuthorizedKeysFile	.ssh/authorized_keys
PasswordAuthentication yes
ChallengeResponseAuthentication yes
GSSAPIAuthentication yes
GSSAPICleanupCredentials no
UsePAM yes
X11Forwarding yes
UsePrivilegeSeparation sandbox		# Default for new installations.

Note that I have not updated the tests at this time.

Something like that, yeah.
I think the tests are broken because of unrelated issues on CentOS

Oh yeah, no that's not it, it failed on travis-ci.
But if you're testing on CentOS, be aware that there is that outstanding issue with the tests.

I updated based on your comments.
I'll have a look at the tests later.

Cool. I'll merge once tests pass.

I just tried my latest version and the tests all pass on both my Ubuntu 16.04 and my CentOS 7 systems.

I just installed this version on my test VM (CentOS 7) with Selinux enabled and it works as I had in mind.

I added a more forceful privilege dropping. Could you verify that I didn't break it for you?

I installed the latest master on my test machine and it behaves as I expect it to.
Also your code change seems ok.
Small remark:
There is the comment "// Don't allow to continue as root."
Yet I have it configured as  user=root and this works fine.

Right. That feature. Comment updated.


Warn about /proc/sys/vm/max_map_count in SortPairs' documentation

you are the Windows expert

Why does that feel like an insult... 😉
Anyway, AFAIK Windows does not enforce a hard cap on the number of mmaps so this should be a problem only for Linux systems

No no, you're actually the only one who could possibly know.


Fix maps again

Seems like refactoring. Should this fix any thing? Am I missing something?

Reverting back to my orginal approach - class -> id 👍
With extra cool additions.
Thanks @maxammann

Seems like refactoring. Should this fix any thing? Am I missing something?
I have the same impression that this pull request does not change the behavior. Is this correct @maxammann ?


Networking died with latest update

Windows Version
10.0.22635.2915
WSL Version
2.1.0
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>-microsoft-standard-WSL2
Distro Version
Ubuntu 20.04
Other Software
GlobalProtect VPN
Repro Steps
ping google.com
Expected Behavior
successful ping
Actual Behavior
temporary failure in domain resolution (not temporary). I was able to fix it by using
dnsTunneling=false
I have already filed a separate issue for networkmode = mirrored also killing my network connection
Diagnostic Logs
No response

Can you follow the instructions here to collect networking logs and post the logs to this issue? Please have DNSTunneling turned on when doing so. Thanks!

@craigloewen-msft
@chanpreetdhanjal
could you please share if mirrored networking is even possible with the windows version stated in the initial issue information ?
Most issues here have a build starting with 22xxx
same here #11038

Mirrored mode, DNS tunneling and the firewall feature are available on Windows 11 version 22H2 and higher. So build 22621 and higher!

Thanks.
Maybe the devblog should refer to build numbers in the future to avoid confusion
https://devblogs.microsoft.com/commandline/windows-subsystem-for-linux-september-2023-update/


Define a second shape of the way to execute Try

The way to Try the function depending on the Error returned adds some complexity. Just imagine that we want to throw the wrapper Try and leave only the function's body. We then must change the shape of the errors. My intention behind this commit is to show the idea above, that I took from Breaker

This is just an idea... still in progress.


Add missing exercises

Adds the Identify Conflicts and Critical path exercises which existed on the Playbook but not here.
Also fixes some broken links on the group critique page.
Found while working on https://github.com/thoughtbot/design-sprint-guide/issues/46

@cpytel ok this should be all updated!


Split bash bench into two processes

Codecov Report
Attention: Patch coverage is 64.76015% with 191 lines in your changes missing coverage. Please review.

Project coverage is 75.67%. Comparing base (f458a98) to head (e05de2c).

Files
Patch %
Lines

...riment/torch_bench/_bash_bench_benchmark_runner.py
64.76%
191 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
+ Coverage   75.58%   75.67%   +0.09%
==========================================
  Files         137      137
  Lines       17406    17442      +36
==========================================
+ Hits        13156    13199      +43
+ Misses       4250     4243       -7

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[release-1.6] Fix operator remove

This is an automated cherry-pick of #23321

Wait for https://github.com/istio/istio/pull/23385 to merge first.


Fix two instances of integer-assignment to string.

o In cover.cc, the int-result of mkstemps() was assigned to a string
and silently interpreted as a single-character filename with a funny
value. Fix with the intent: assign the filename.
o in libparse.cc, an int was assigned to a string, but depending on
visible constructors, this is ambiguous. Explicitly cast this to
a char.

jfyi, because I just saw it: f67ec1b


[Feature] Local Storage Provider

It would be great to have a default storage provider similar to what Minikube provides. This allows to deploy and develop Kubernetes pods requiring storage.
Scope of your request
Additional addon to deploy to single node clusters.
Describe the solution you'd like
I got it working by using the storage provisioner of Minikube by creating following resources:
---
apiVersion: v1
kind: ServiceAccount
metadata:
  name: storage-provisioner
  namespace: kube-system
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
  name: storage-provisioner
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: ClusterRole
  name: system:persistent-volume-provisioner
subjects:
  - kind: ServiceAccount
    name: storage-provisioner
    namespace: kube-system
---
apiVersion: v1
kind: Pod
metadata:
  name: storage-provisioner
  namespace: kube-system
spec:
  serviceAccountName: storage-provisioner
  tolerations:
  - effect: NoExecute
    key: node.kubernetes.io/not-ready
    operator: Exists
    tolerationSeconds: 300
  - effect: NoExecute
    key: node.kubernetes.io/unreachable
    operator: Exists
    tolerationSeconds: 300
  hostNetwork: true
  containers:
  - name: storage-provisioner
    image: gcr.io/k8s-minikube/storage-provisioner:v1.8.1
    command: ["/storage-provisioner"]
    imagePullPolicy: IfNotPresent
    volumeMounts:
    - mountPath: /tmp
      name: tmp
  volumes:
  - name: tmp
    hostPath:
      path: /tmp
      type: Directory
---
kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
  name: standard
  namespace: kube-system
  annotations:
    storageclass.kubernetes.io/is-default-class: "true"
  labels:
    addonmanager.kubernetes.io/mode: EnsureExists
provisioner: k8s.io/minikube-hostpath

Describe alternatives you've considered
An alternative might be local persistent volumes but the Minikube solution looks simpler. With the local persistent volumes it could work even with multiple nodes.
I'm not sure if the addon should be integrated into k3s directly. On the other hand I think it's more a feature required for local development and therefore probably fits better to k3d.

Hey, thanks for creating this issue and providing your solution :+1:
I confirmed that the provisioner you posted is working, by saving it to prov.yaml and then creating it upon creation time by mounting it like this: k3d create -v $(pwd)/prov.yaml:/var/lib/rancher/k3s/server/manifests/prov.yaml.
However, one should note that the hostPath /tmp is not persisted on disk when we shutdown the cluster, if we don't declare it as a docker volume/bind.

I am using https://github.com/rancher/local-path-provisioner for this in https://github.com/IQSS/dataverse-kubernetes/blob/master/docs/k3s.md
Obviously, you need to patch your PVCs. I did that via Kustomization (kubectl apply -k).

I also just tested the Local Persistent Volumes which are GA since Kubernetes v1.14.
Here's what I did:

k3d create -n test --workers 2
kubectl apply -f storageclass.yaml where storageclass.yaml:

apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  name: local-storage
provisioner: kubernetes.io/no-provisioner
volumeBindingMode: WaitForFirstConsumer

docker exec k3d-test-worker-0 mkdir /tmp/test-pv (the path we're accessing has to exist)
kubectl apply -f deploy.yaml, where deploy.yaml:

apiVersion: apps/v1beta2
kind: Deployment
metadata:
  name: test-deploy
  labels:
    app: test-deploy
spec:
  replicas: 1
  strategy:
    type: Recreate
  selector:
    matchLabels:
      app: test-deploy
  template:
    metadata:
      name: test-deploy
      labels:
        app: test-deploy
    spec:
      containers:
        - name: main
          image: postgres
          imagePullPolicy: IfNotPresent
          volumeMounts:
            - mountPath: /test
              name: test-mount
      volumes:
        - name: test-mount
          persistentVolumeClaim:
            claimName: test-mount
---
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: test-mount
spec:
  volumeName: example-pv
  storageClassName: local-storage
  accessModes:
    - ReadWriteOnce
  resources:
    requests:
      storage: 1Gi

---
apiVersion: v1
kind: PersistentVolume
metadata:
  name: example-pv
spec:
  capacity:
    storage: 1Gi
  # volumeMode field requires BlockVolume Alpha feature gate to be enabled.
  volumeMode: Filesystem
  accessModes:
  - ReadWriteOnce
  persistentVolumeReclaimPolicy: Retain
  storageClassName: local-storage
  local:
    path: /tmp/test-pv
  nodeAffinity:
    required:
      nodeSelectorTerms:
      - matchExpressions:
        - key: kubernetes.io/hostname
          operator: In
          values:
          - k3d-test-worker-0

kubectl exec test-deploy-76cbfc4c94-v2q8s touch /test/test.txt
docker exec k3d-test-worker-0 ls /tmp/test-pv

This was just a test, to see that the thing is working :+1:

Cool @iwilltry42! :+1:
Let me emphasize a bit on an IMHO important aspect: local storage provider in K8s 1.14 is promising, but (as you noted) does not yet support dynamic provisioning.
This is my only reason to favor rancher/local-path-provisioner over K8s local storage.
Following kubernetes-sigs/sig-storage-local-static-provisioner#51, it's going to take a while...

k3s built-in local storage provider coming: https://twitter.com/ibuildthecloud/status/1167511203108638720

k8s local dynamic provisioning issue:
https://github.com/kubernetes-sigs/sig-storage-local-static-provisioner/issues/51

k3s has the local-storage storage class built in now: https://rancher.com/docs/k3s/latest/en/storage/

@iwilltry42
I noticed that example (https://rancher.com/docs/k3s/latest/en/storage/#pvc-yaml) uses capacity, but according to the docs (https://github.com/rancher/local-path-provisioner#cons), its not possible yet.

k3s has the local-storage storage class built in now: https://rancher.com/docs/k3s/latest/en/storage/

That seems to work well with k3d create --volume "<local-path>:/var/lib/rancher/k3s/storage" for persistence. The only issue I'm seeing is that k3d delete doesn't allow the local path provisioner to clean up existing PVC folders and they don't seem to be cleaned up when creating a new cluster using the same storage folder either.

Hi @deiwin, k3d delete doesn't do any kind of "graceful" shutdown of the managed k3s instances, it simply removes the containers. What would be required to allow for a proper cleanup and what would be the use case for this?

What would be required to allow for a proper cleanup

If it'd delete all deployments/statefulsets/daemonsets using PVCs and then all PVCs, then I think local-path-provisioner would do the cleanup. It'd have to have some way of knowing that that cleanup's done, though.

what would be the use case for this?

You write above, that "However, one should note that the hostPath /tmp is not persisted on disk when we shutdown the cluster, if we don't declare it as a docker volume/bind." I haven't verified it, but I was thinking that doing k3d create --volume "<local-path>:/var/lib/rancher/k3s/storage" as I mentioned above would help with that persistence.
I'm working on a cluster setup that supports two different use cases: 1) start and stop the same long-running cluster with persistent storage (for a DB) and 2) recreate whole clusters from scratch fairly often.
As I said, I haven't verified this, but I think case (1) requires persistence, but case (2) currently leaves behind data from PVCs that don't exist anymore in new clusters.
As a workaround, I'm currently pairing k3d delete with rm -rf <local-path-for-storage>. That's fairly simple, but I don't know if other users would think to do that.

Hey :wave: Is there any more need or input for this feature?

What I am missing at least in the documentation is where the data is stored locally.
does docker map the /var/lib/rancher/k3s/storage to /tmp ?
Here it is documented to point to opt:
https://github.com/rancher/local-path-provisioner/blob/master/README.md#usage
A clarification / documentation of this is greatly appreciated, as is the option to add a PV to point to a local folder for storage in an existing k3d cluster.

I also think clean up is not needed from k3d when it comes to a mapped local file. a PV could be mapped to multiple clusters and otherwise the cleanup logic has to check for all that.
The pvc could be cleaned, but doesn't that just get removed when the whole cluster is removed?
I noticed one can add a volume but not a mapping to a file system after the cluster is created (unless I missed this and should run a docker command).
If that can be considered a feature of k3d then there could be a delete option too, which would do what @deiwin suggest in a more or less complete way. just my thoughts :)


Module dependency upgrade

The module badgerious-windows_env has been migrated to puppet/windows_env. Please upgrade the dependencies
https://forge.puppet.com/badgerious/windows_env

Thanks! You may have seen puppetlabs/chocolatey as a better options as it is an in place upgrade of the approved Chocolatey provider and it is supported by Puppet.

Thanks for the suggestion. I've upgraded to puppetlabs-chocolatey.


Exclude

This is a naive approach to exclude script tags from getting checked. The reason is that the tag leads to a lot of false-positives (e.g. //unpkg.com/docsify-edit-on-github@1 within a script block gets detected as an e-mail address).
A more thorough approach would be the use of a tree-builder in html5gum and html5ever, but this could have a negative performance impact.
I also did not want to add a new flag (e.g. --include-scripts) for this setting because the current set of flags around exclusion/inclusion is already quite long.
Fixes #821.

Hmm, on the other hand, scr attributes in script tags are mandatory to work to not break the page or certain of its features, even more important than some random link on the page, I'd say? And I'm not aware of a case where the script tags contain expectedly invalid URLs, like svg tags and similar do.
Isn't a skipped scheme as well as contained @ generally still a valid URL and should be hence treated as such on a general basis, as also any other link may contain a @ character? Not sure how to best differentiate between URL and email address in this case. Are slashes allowed in email addresses? Also the leading double slash and in case scheme of course could be used as indicator that it is no email address.

Are slashes allowed in email addresses?

alpha-numeric letters and
! # $ % & ‘ * + – / = ? ^ _ ` . { | } ~

are allowed. (period should not be the first or last character of the local part and cannot have consecutive periods.)

Also the leading double slash and in case scheme of course could be used as indicator that it is no email address.

the email scheme is mailto: but most of time people do not include the scheme.

Okay, that makes differentiating between an URL and an email address difficult indeed, if an @ sign is included.

the email scheme is mailto: but most of time people do not include the scheme.

At least lychee does not require this scheme to be present to detect an email address as such. This is generally good, as in free text it is nearly never included, but causes the issue this PR was about.
I need to look into the detection code again. Generally in URLs, the part before the @ sign must begin with (a scheme and) a valid hostname, in emails, the part after the @ sign must be a valid domain name. If there is a scheme, we are safe anyway, if there is just //, I think we can safely assume it is an URL where the scheme of the current request is to be pretended.
I think there are cases possible with can be generally both, so we cannot rule out interpreting it falsely, but with the above things respected, and taking something as an URL if unsure, we should be able to reduce false interpretation to practically zero.

the good thing is, although URL allows @, a valid URL doesn't have username and password so @ should not exist.

What do you mean by this? There does not need to be a username or password for @ to exist in URLs. The above example is a valid URL, also the final redirect is<EMAIL_ADDRESS>But the part behind the @ is no valid domain name (right?), also in OP example it is not. However, @1.0.3 or @index.js are generally possible as well, in which case only scheme and/or // could be the indication of this being still an URL and no email address.

@MichaIng
Oh I was talking about the authority part of the url and forgot that path could contain @.
this indeed would be a problem for relative url such as<EMAIL_ADDRESS>

And I was not thinking about username:pasword@ to be true 😄. Not sure if/how this is handled currently already. But yeah, should be very rare, or even good to fail on that, to being it to any admin's attention, as it is a very bad practice, respectively renders the authentication useless.


Blazor Hybrid Export Callbacks

In certain Blazor Hybrid scenarios, such as MAUI on Android, downloading files via JavaScript is either not possible or not easy. This means the Export to SVG, PNG, and CSV options may not work.
My suggestion is to add a custom exporter callback that simply has a JavaScript invoked function that will relay the export information back to C# so the user can handle the export. In the case of .NET MAUI this could easily be linked to something such as FileSaver from the .NET MAUI Community Toolkit.
Getting the data should be possible as per this GitHub Issue.
Just opening for discussion and reference right now; I will create a PR in about one month.

Hi,
Sounds good, looking forward for the PR.


Configure Stage and Prod Deployment Automation

Purpose and background context
We are close enough to launch that it's time to prepare for automated deploys to Stage and Prod.

Create stage deploy workflow (from TfCloud outputs from the mitlib-tf-workloads-libraries-website repo)
Create prod deploy workflow (from TfCloud outputs from the mitlib-tf-workloads-libraries-website repo)

How can a reviewer manually see the effects of these changes?
Since these are GitHub Actions, there really isn't a way to do any testing before these are in the main branch of the repository. That said, these files come from templates generated by Terraform and equivalent versions have been fully tested in another CDN-related app (cf-lambda-custom-domain).
Includes new or updated dependencies?
NO
Changes expectations for external applications?
NO
What are the relevant tickets?

https://mitlibraries.atlassian.net/browse/GDT-100

Developer

[x] The Dev CF Lambda@Edge Full Deploy workflow has been run to update CloudFront in Dev1
[x] All related Jira tickets are linked in commit message(s)
[x] Stakeholder approval has been confirmed (or is not needed)

Code Reviewer(s)

[ ] The commit message is clear and follows our guidelines (not just this PR message)
[ ] There are appropriate tests covering any new functionality
[ ] The provided documentation is sufficient for understanding any new functionality introduced
[ ] Any manual tests have been performed and verified
[ ] New dependencies are appropriate or there were no change

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
8

Relevant Lines:
8

💛  - Coveralls


Improve first run experience

Specifically around location permission requests. The app pretty much needs the user to authorize location permissions to be useful, so we should be far more careful about messaging this to the user before popping up a permissions dialog.

Dupe of #862 ?

@sethfri yes, thank you


#566: Cgroup metrics from generic platform crate

Part 1 of 2. Closes #566. I've created a platform crate for abstracting any direct platform/OS stuff we eventually do (there will be quite a bit over time). Initially, I've added just functionality to retrieve some metrics from the kernel for our control group. The next pull request will be to expose those to Prometheus.
This doesn't block alphanet, but doesn't touch any of the protocol code, passes clippy, and gives us some data to start working with while running alphanet, as well as giving the storage and compute agents something to stay running for.

Summary by CodeRabbit

New Feature: Added a new module platform_stats to the platform crate for retrieving CPU and memory stats from the control cgroup of the current process and its tree.
New Feature: Integrated Prometheus exporter functionality into the compute_agent crate. This allows for serving platform stats/metrics requests.
New Feature: Extended ServiceConfig struct in service_config crate to include exporter_address and exporter_port fields.
New Feature: Added find_service function to the Config implementation in service_config crate, enabling service configuration retrieval based on service_name and service_type.

Added part 2, which closes #565 . For betanet, I'll move all of the prometheus stuff out to a separate crate that all services can use, but for now I just want something that will get us stats for alphanet.


Ruby - Support New Synthetics Header

Description
Support Q3 Major Launch for Automated Testing.
Ruby team will deliver the CDD, Agent Spec update, and Ruby agent implementation in Q2 to pave the way for agent teams to deliver in Q3 to support the launch.

Additional tech convos/details : https://issues.newrelic.com/browse/NR-121367


testAdd the cases of upgrade and downgrade of mtmv

Proposed changes
testAdd the cases of upgrade and downgrade of mtmv

run buildall

run buildall

run buildall


Integration Tests with Emulators

[Testcontainers project[(https://github.com/testcontainers/testcontainers-java) allows to use services running in containers to be used during testing. It will be great to add such tests for available emulators using google/cloud-sdk container.
I have a proof of concept here that shows how to run such tests in Travis.
If this idea look good to everyone I can try to add some simple tests after https://github.com/GoogleCloudPlatform/google-cloud-java/issues/1973 is fixed.

I don't think google-cloud-java contains any source code of gcloud emulators.

Right, @shinfan. But wouldn't it be great to verify google-cloud-java works properly with emulators to catch problems like #1973?

Oh I sorry I misunderstood. I think it makes sense to make sure gcloud work with emulators.

It's not clear what this request is for currently. Our current stance is for users of google-cloud-java to start emulators themselves, and then customize the API clients in google-cloud-java to use the running emulator instead of the real service. What else is needed?

The problem I've seen before that google-cloud-java stopped working with emulators. It will be nice to make sure changes to google-cloud-java are not breaking it ability to talk to emulators.

It might be fine to not have them since google-cloud-java is getting more and more stable. 🤷♂

We intend on continuing to support the special functionality necessary for emulators (plain text, no credentials). With that, I don't think emulators would generally break. It's a challenge to verify emulators in google-cloud-java because that requires extra dependencies that are problematic (either the python-based gcloud utility, or downloading the emulator from the internet). I think I'll close this out - feel free to open a new issue if emulators break in the future.


Make normalizing flow sampler share the same interface with the LocalSampler

Currently the normalizing proposal stands on itself, which may cause some issues and confusion. It would be nice to tidy up the interface

Closing this issue since it was done in #129


etcd profile out of sync, doesn't seem to get fixed

Ran an FV run on the bobcat rig

using my smc-multi-pids branch, which supports multiple neutron workers,
bobcat rig was patched with calico master commit d649e65
running 8 API workers on the control node

The FV run failed: http://calicobobcat-jenkins.gulfstream:8080/job/fv-tests/791/.  The test_security_group failures seem to be genuine ping failures.
I manually ran the I ran test_security_group from the command line and paused the test when pings started to fail.
It looks like horizon's picture of the group2 SG differs from that in etcd.  In horizon, it has an allow rule from the default group; in etcd that is missing.  I'm not sure how that got out of sync but the periodic resync doesn't seem to fix it.

Re-ran that same test and it looked like it was working before I left the office.  Still, pretty worrying to get two failures in a row.

From code reading, it looks like that test should re-add the rule at the start of the test so I'm not sure how it could fail twice in a row if that re-add was giving us a kick to re-write the profile.

Periodic resync won't fix this at the moment, it's a known problem.
What's on the smc-multi-pids branch?

Also, when testing this, make sure to watch the relevant key in etcd. I wonder if we're having a write ordering problem.

@Lukasa - what do you think the known problem is?

We don't update existing keys during re sync, we either write missing ones or delete extra ones.

On 20 May 2015, at 10:42, Matt Dupre<EMAIL_ADDRESS>wrote:
@Lukasa - what do you think the known problem is?
—
Reply to this email directly or view it on GitHub.

OK, understood - am I right in inferring that you don't know what the original cause of this is (other than potentially writes overtaking each other)?

Correct.

My branch is in calico-test. It fixes some tests that were asserting that there was only one neutron process.

I've been running with 8 workers

@Lukasa This is currently with you.  Are you actively thinking about how we could modify our resync strategy to catch cases where the keys are present, but incorrect?

Depends what you mean by actively. I have a number of ways to fix this, but I don't know what the urgency on them is. We should discuss on Monday.

Indeed...

The original cause of this could perhaps be issue #635?
There's still the question of improving the resync to actually refresh the security groups though.

Please note this is still not fixed, but the cause of this specific instance of the issue is fixed.

The fix for this is now merged.


wavebender in PyPI

Hi,
Thanks for creating this efficient and easy to use library. I was hoping to install it via pip, but it looks like it isn't in PyPI.
I can do this for you if you wish, and am happy to relinquish control to you at any stage.

+1 for a PyPi package

+1
for PyPi


[iphone] Mark iOS15 devices as supported

Seems like Apple is exclusively pushing fixes there still
Ref for 15.7.2: https://support.apple.com/en-us/HT213531

@captn3m0, my previous statement regards the support status was correct then.


x/build: create windows-386-2012 builder

The Go1.18 release will require a supported version of Windows to be released on. While Windows Server 2012 does not have native i386 support, Microsoft Windows-32-on-Windows-64 (WOW64) allows you to run 32 bit software on an x64 system.
@golang/release

I think that CL went a bit too far. Adding a newer builder is good. But removing 2008 from trybots is maybe less good. That will surely bitrot Windows 7 support after some time.


Add eunit_test_failure_ignore option

It is pretty common to have such option and quite convenient on
occasion.

Isn't rebar -k eunit sufficient?

cc @vladdu

Option -k also returns non-zero exit code. And it doesn't distinguish between eunit failure and test failure.

My feeling is that options in rebar.config should be for more permanent settings. I would ignore test results only in special cases, when a command line parameter works better. It's too easy to forget the option enabled and think all is well when the tests are failing all over the place.
And as a smaller issue, I think I might want to know that some test have failed, that is I'd like "One or more eunit tests failed." to get printed anyway.

Still pondering about this.
I agree with @vladdu that if this in rebar.config, rebar_eunit better report ignored test results, or else it's easy to forget about. IIRC, ct and ts have the concept of okay-to-fail tests. Doesn't EUnit have something similar?

@richcarl

cc @richcarl

@tuncer I don't know about such an option in EUnit.
The information about failing/passing tests is printed out by EUnit. The rebar doesn't have to do it yourself.

I don't know about such an option in EUnit.

Me neither, but I asked just in case it's hard to find :).

I'm wondering whether it wouldn't make more sense to add the option to eunit, rather than having rebar absorb all of the fixes people want for the actual tools. Not that I'm opposed to merging it here, but it appears counter-productive in the long run to encode rules for a test framework across multiple codebases.

@ferd I see problem in rebar because of it is interpreting EUnit results.

So am I understanding right, from this bit: https://github.com/rebar/rebar/pull/486/files#diff-bfec549e6963d4adb6816dec0113d00bR193 that this PR does not only ignore failures, it entirely ignores test results and reports nothing when there's a failure?
How is this different from, you know, not running the tests? It seems to be it should at the very least still output the message, just not make it an ABORT.

Why run the tests if you don't care that about the result?

@ferd @tsloughter We process and interpret EUnit output on our own. This is messed by rebar aborting (so we have to examine reason of such abort).

It sounds like you want your own eunit plugin to use instead of the one that comes with rebar

@tsloughter No, I just want rebar not to abort when everything works well.

But your definition of "everything works well" appears to be even when tests fail?

@tsloughter Yes. EUnit, rebar, erlang - everything works well and I have EUnit output on stderr.

Might be legit to have in rebar, but in eunit, an option to ignore failures
seems quite pointless.
    /Richard

On Wed, Apr 29, 2015 at 8:26 PM, Vojtech Rylko<EMAIL_ADDRESS>wrote:

@tsloughter https://github.com/tsloughter Yes. EUnit, rebar, erlang -
everything works well and I have EUnit output on stderr.
—
Reply to this email directly or view it on GitHub
https://github.com/rebar/rebar/pull/486#issuecomment-97532176.

Might be legit to have in rebar, but in eunit, an option to ignore failures seems quite pointless.

My impression was that @vojtarylko was looking for something like ct's ignore-test-case feature, and that's what I thought would make sense in eunit.

For ignoring individual tests, you mean? Yes, that would be useful.

On Tue, May 5, 2015 at 11:43 AM, Richard Carlsson wrote:

For ignoring individual tests, you mean? Yes, that would be useful.

Yes, individual tests.

I'm looking for general "do not abort rebar if some tests fails" so I can distinguish between rebar (or eunit) failing and some tests failing.

On Tue, May 5, 2015 at 1:11 PM, Vojtech Rylko wrote:

I'm looking for general "do not abort rebar if some tests fails" so I can distinguish between rebar (or eunit) failing and some tests failing.

You said that rebar -k eunit other_cmd terminating with a non-zero
exit code doesn't work for you.
You also wrote

And it doesn't distinguish between eunit failure and test failure.

but I'm not sure what "and test failure" refers to. Are you saying
test==one_unit_test and eunit=rebar_eunit?
While we can add something EUnit-specific to rebar, I'm not entirely
sure what the use case is. So let me ask some more questions:

You want to run EUnit tests but always ignore the result and check
the logs for success/failure, right?
Wouldn't running rebar eunit separately from other other rebar
commands solve your use case?
Are you sure it's just rebar eunit, or how likely are you to
require the same exit(0) rebar -k behavior for other commands?
How about {keep_going_exit_code, int()} in rebar.config?

On Tue, May 5, 2015 at 1:11 PM, Vojtech Rylko wrote:

I'm looking for general "do not abort rebar if some tests fails" so I can distinguish between rebar (or eunit) failing and some tests failing.

You said that rebar -k eunit other_cmd terminating with a non-zero exit code doesn't work for you.
You also wrote

And it doesn't distinguish between eunit failure and test failure.

but I'm not sure what "and test failure" refers to. Are you saying test==one_unit_test and eunit=rebar_eunit?
While we can add something EUnit-specific to rebar, I'm not entirely sure what the use case is. So let me ask some more questions:

You want to run EUnit tests but always ignore the result and check the logs for success/failure, right?

Wouldn't running rebar eunit separately from other other rebar commands solve your use case?

Are you sure it's just rebar eunit, or how likely are you to require the same exit(0) rebar -k behavior for other commands?

How about {keep_going_exit_code, int()} in rebar.config?

"eunit failure and test failure" - The eunit test generator can fail and thus not outputting all the tests into the XML. In such case you could have incomplete output of passed tests and a non-zero return code from rebar, and if you ignore the code, you generate all-ok test results, but they're incomplete. The test failure I mean just failing test (eg. ?assert( false )).

I think we are not really interested in supporting this at the time. The case where eunit fails to run tests properly to be distinguished from tests running fine but having one fail is minor and no matter which happens, it can be figured out from the output with or without the varying error codes.
Ideally if we were to have a patch for this, I'd say to do something like return 0 when all passes, return 1 when tests fail but ran, and 2 when tests failed and didn't compile right. But no things like "force to return a 0 status when stuff broke."


[Feature/extensions] Migrates Delete Detector action to extension

Description
Migrates the DeleteAnomalyDetectorTransportAction, their Rest Handlers, and other supporting classes from plugin to extension.
Tested:

[x] Was able to delete a detector

{
    "_index": ".opendistro-anomaly-detectors",
    "_id": "mBf6TYcB3uvsiIoyKYrD",
    "_version": 2,
    "result": "deleted",
    "forced_refresh": true,
    "_shards": {
        "total": 2,
        "successful": 1,
        "failed": 0
    },
    "_seq_no": 10,
    "_primary_term": 3
}

[x] Created a detector of the name test-detector, was able to delete it and then create it back.

Issues Resolved
Fixes https://github.com/opensearch-project/opensearch-sdk-java/issues/374
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #829 (964e4f0) into feature/extensions (fa46964) will decrease coverage by 0.28%.
The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@                   Coverage Diff                    @@
##             feature/extensions     #829      +/-   ##
========================================================
- Coverage                 39.90%   39.62%   -0.28%
  Complexity                 2111     2111
========================================================
  Files                       297      298       +1
  Lines                     17094    17212     +118
  Branches                   1843     1847       +4
========================================================
  Hits                       6821     6821
- Misses                     9786     9904     +118
  Partials                    487      487

Flag
Coverage Δ

plugin
39.62% <0.00%> (-0.28%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...va/org/opensearch/ad/AnomalyDetectorExtension.java
0.00% <0.00%> (ø)

...earch/ad/rest/RestDeleteAnomalyDetectorAction.java
0.00% <0.00%> (ø)

...ransport/DeleteAnomalyDetectorTransportAction.java
0.00% <0.00%> (ø)

Approving but noting the routeHandlers are adding to the pile of routes we will have to change later!

I have removed the legacy route for Delete detector as of now. We will have to take care of all the legacy routes for BWC in while implementing ReplaceRoutes https://github.com/opensearch-project/opensearch-sdk-java/issues/355


[ur] Localize 'distributed-system' in Urdu

Need to localize distributed-system.md in Urdu

Closing Issue PR Merged


Please report this issue with the "1690327295451-base.js" file on https://github.com/distubejs/ytdl-core/issues.

This may be related to an issue I've been having the past few days: https://github.com/CombustibleToast/CAROLINE/issues/7

Duplicated #5


[6.4.x] Bug 1316224 - User can not create projects in any other repository than master

(cherry picked from commit 9c941475edcf8ae713302b2d4782dbb601d01b4c)
https://github.com/droolsjbpm/guvnor/pull/287
https://github.com/droolsjbpm/kie-wb-common/pull/311
https://github.com/droolsjbpm/drools-wb/pull/145
https://github.com/droolsjbpm/jbpm-console-ng/pull/368
https://github.com/droolsjbpm/optaplanner-wb/pull/47
https://github.com/droolsjbpm/kie-wb-distributions/pull/230

+1 to merge.

6.4.x:0877d6b45c28dd99f1a75aa00657db717e3d8883


Config for max disk usage in MB

Don't we have this already with Format.diskCapacity?

correct me if I'm wrong but if you use the the UIImage extension you have the shared cache and you can't set the diskCapacity @hpique

You can set a custom format via hnk_format, with a custom disk capacity.
On Thu, 7 Jan 2016 at 22:31, dcharbonnier<EMAIL_ADDRESS>wrote:

correct me if I'm wrong but if you use the the UIImage extension you have
the shared cache and you can't set the diskCapacity @hpique
https://github.com/hpique
—
Reply to this email directly or view it on GitHub
https://github.com/Haneke/HanekeSwift/issues/180#issuecomment-169827808.

How can you access to the diskCapacity when formats are invisible from public interface?


How to remove unnecessary permissions

I've tried to upload my app to the app store to start the TestFlight and it got rejected and got this message

Missing Info.plist key - This app attempts to access privacy-sensitive data without a usage description. The app's Info.plist must contain an NSContactsUsageDescription key with a string value explaining to the user how the app uses this data.
Missing Info.plist key - This app attempts to access privacy-sensitive data without a usage description. The app's Info.plist must contain an NSPhotoLibraryUsageDescription key with a string value explaining to the user how the app uses this data.

I figure that your library has some calls to these functionalities since I do not use them. Is there a way to fix it, I do not want to request this access to my users

@PedroCavaleiro Any solution to this?

You have two solutions, add the permissions to the Info.plist, the permissions are made on demand, or comment the whole classes that you don’t need
I ended up commenting the whole classes that I didn’t need, it’s not the ideal solution.
As long as they’re there it does not matter if you use them or not, Apple will still see them and reject the app if said permissions are not in the Info.plist


How do I configure ObjectMapper?

What are you trying to achieve? Here's an example using object mapper https://docs.dapr.io/developing-applications/sdks/java/

I need to use a custom date format, but ObjectMapper(Jackson) that DAPR uses cannot be configured.

You can use Jackson annotation into our domain objects or bring your own serializer as pass it in the builder for DaprClient.

Thanks!


While running demo application on real android device Exception: Gradle task assembleDebug failed with exit code 1

bug-report.md

@TejasAghade
This seems to be an issue with intellij. See this similar issue for your reference : https://github.com/flutter/flutter-intellij/issues/4233
If required, you may open a new issue in that repo.
Closing from here.


Feature/small fix

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (3d6bb90) 95.13% compared to head (4b8e030) 95.13%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #41   +/-   ##
========================================
  Coverage    95.13%   95.13%
========================================
  Files           38       38
  Lines         2405     2405
========================================
  Hits          2288     2288
  Misses         117      117

Impacted Files
Coverage Δ

polytope/datacube/xarray.py
98.88% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Alternative emoji set support

What
Adds support to have alternative emoji sets. The set must be selected when starting up the app via a system property. Two system properties are supported:
com.vdurmont.emoji.EmojiManager.SET
Defines which emoji set should be loaded. This is an enum that accepts any of the following values:

EMOJI_JAVA: the default emoji set
UNICODEY: the emoji set from https://unicodey.com/emoji-data/table.htm
CUSTOM: a custom emoji set that will be passed in a file

com.vdurmont.emoji.EmojiManager.PATH
A string containing the path of the cutom emoji set.
In addition, a script was added to import the json from unicodey and convert it to the same format as emoji-java, so the EmojiLoader remains unchanged
Why
Many projects (including Slack) use the data from unicodey and this change allows to interop propertly with emoji-java

Coverage decreased (-0.8%) to 92.442% when pulling ae71e61af670a58dfd93a5d012ce893b8242b28e on julman99:unicodey into 8cf5fbe0d7c1020b926791f2b342a263ed07bb0f on vdurmont:master.

Coverage decreased (-0.8%) to 92.442% when pulling ae71e61af670a58dfd93a5d012ce893b8242b28e on julman99:unicodey into 8cf5fbe0d7c1020b926791f2b342a263ed07bb0f on vdurmont:master.

Looks great! I think it's interesting to import different emoji sets.
I have some questions:

Do you know what's the difference between our current DB and the unicodey one? Maybe we can just update ours to match unicodey's.
The PATH and SET variables are a good way to define custom databases. I'm wondering if we should have several emoji-java artefacts, one for each set. It's less efficient but much easier for the end user. emoji-java-common could have all the common stuff, emoji-java-unicodey could require the common artefact and add the unicodey DB, ... What do you think?

I don't know all the differences, but I do know about some ambiguities, for example :hug: is :hugging_face: in Slack, and  :thinking: is :thinking_face: So the real issue is not that this library is missing emojis, is that there are conflicts between the emoji aliases: we could encode :hug: when the decoder is expecting :hugging_face:. Maybe one option is to always support decoding from all emoji sets but have the developer pick one of the sets as the preferred encoding?

I like the artifact approach, I agree is a much more intuitive way of using the right emoji set, as well as extensible. I will do the change tomorrow to "see how it feels", ok?

Hi @vdurmont, just pushed a set of commits to split the project into a multi-module structure. There is still some cleanup that needs to be done, but I wanted to get your early feedback. From a developer point of view, there are two artifacts they can use: emoji-java and emoji-java-unicodey. The only thing those modules do is to include a different emojis.json as resource

Coverage decreased (-0.8%) to 92.442% when pulling d8c5f626ee5ed32cd9090a27ca1fc58d5cdd3b4e on julman99:unicodey into 8cf5fbe0d7c1020b926791f2b342a263ed07bb0f on vdurmont:master.

Hi @vdurmont , just checking if you had time to review the approach I committed. I still need to cleanup many things from the first implementation but I want to get your feedback before I keep working on the PR
Thanks

Hey, I'm very interested in getting support for Slack emoji done. My team is using this library on Android but a different one on iOS, which is leading to discrepancies between emoji parsing across platforms 🙁

Hey I'm sorry I didn't take the time to look into this before. I didn't look into the DB from unicodey but is it possible to update the DB we already have to also support unicodey's aliases instead of selecting a different set?


VirusTotal infinite captcha loop

Often times when I try uploading a file to VirusTotal, I ended up stuck in a captcha loop. I will do captcha after captcha after captcha infinitely without succeeding. I have tried different browsers, I have tried disabling adblock and I have tried VPNs, however, none of those approaches seem to work.

Same problem here.

same problem

My workaround ist using another browser for Virustotal. For me Firefox uses long CAPTCHA quests while Chrome doesn't ask at all.

I've started using a VPN and bizarrely it works 🤦

Same. Can only click so many pedestrian crossings to keep my sanity. Maybe implement a smarter captcha control?

Same. Sometimes it seems the file is successfully uploaded and it doesn't tell me??? I'm not sure. I keeps me stuck in the captcha loop for a while, but when trying to upload the file again a while later, it goes straight to the summary instead of asking to upload again.

for me switching to https://www.virustotal.com/old-browsers/ helped

https://github.com/google/recaptcha/issues/296

#296

I'm stuck even with cookies.
This Website doesn't help when I can't use it…


PLT-989 Improve behaviour of duplicated MustSpend

Throw errors if we try to use different redeemer or different reference script in different MustSpend, ignore all but one constraint otherwise.

Pre-submit checklist:

Branch

[x] Tests are provided (if possible)
[x] Commit sequence broadly makes sense
[x] Key commits have useful messages
[ ] Formatting, PNG optimization, etc. are updated

PR

[x] Self-reviewed the diff
[x] Useful pull request description
[ ] Reference the ADR in the PR and reference the PR in the ADR (if revelant)
[x] Reviewer requested

Did you think of the alternative of "simply" ignoring all  but one mustSpendScriptOutput call instead of throwing errors?

Did you think of the alternative of "simply" ignoring all but one mustSpendScriptOutput call instead of throwing errors?

Yes. As discussed in JIRA, I'll move back to this behaviour instead, it sounds more consistent with the lookup behaviour.

Or, I keep it as-is (@james-iohk sounds ok with it) but in any case, I need to document the mustSpend constraints, which is no done yet.

I think that's a bad idea. You might have used the wrong variable somewhere. A missing lookup is quickly found out, but a duplicate mustSpendScriptOutput could go unnoticed.

Ok, let's keep it as is then. I'll add documentation to the smart builders and ship it.


Basic info on pointer-events property

Property, possible values and link to more information

[ ] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[ ] None of my changes are plagiarized from another source without proper attribution.
[ ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

@barrettfett Please check the boxes and carefully check your PR next time.


FEAT: App Management

Mockup of general idea for the new screen (subsection of projects)

Mockup of new App card

Would be amazing to show the app icon for the project as well, but i don't know how feasible that is.

It can probably be added manually, or at least it will be visible in the assets. Otherwise, we can check the manifest or the plist and get it from there


docs: 📚 Add token README and Color Swatches to storybooks package

Pull Request
📖 Description
This PR adds back available color swatches in storybook. It includes all tokens in dark and light mode and the ability to display and copy the values for the following variants of the tokens:

Raw (e.g. css hex value)
CSS Variable
SCSS Variable
JS Variable

🎫 Issues
Closes #218
👩💻 Reviewer Notes

Check out this branch
After updating/building, move to packages/docs and start storybook
Navigate to Tokens -> Colors and play around with it.
Click on one of the table cells to copy the value.
The dark mode is currently not working, as the branch for dark mode is not merged yet. Classes and definitions are fine however, so it should be easily be reintegrated after dark mode support has landed.

The copy functionality is provided as a preview. I am aware that it does not give any status information about the obtained copy. Maybe we can later adapt it to use Storybooks messaging system.

✅ DoD

[x] I have tested my changes manually.
[x] I have added automatic tests for my changes (unit- and visual regression tests).
[x] I have updated the project documentation to reflect my changes (e.g. CHANGELOG, Storybook, ...).
[x] I have made sure to follow the projects coding and contribution guides.
[x] I have made sure that the bundle size has changed appropriately.
[ ] I have validated that there are no accessibility errors.
[x] I have used design tokens instead of fix css values

Just one thing that I noticed: For every color we have hex values except for --syn-color-neutral-0: white; and --syn-color-neutral-1000: black; Do we want it like this or should we use hex values for everything (therefore we would need to update those tokens)?

Its drawn from the tokens where the value is set as string. It also appears like this in the Figma Documentation, so for me it is fine, through I find it kind of inconsequent, too. Maybe we should create a follow up ticket for @LeaLeRose?
As it will automatically update when design updates it, I do not think that this is a blocker.

Just one thing that I noticed: For every color we have hex values except for --syn-color-neutral-0: white; and --syn-color-neutral-1000: black; Do we want it like this or should we use hex values for everything (therefore we would need to update those tokens)?

Its drawn from the tokens where the value is set as string. It also appears like this in the Figma Documentation, so for me it is fine, through I find it kind of inconsequent, too. Maybe we should create a follow up ticket for @LeaLeRose?
As it will automatically update when design updates it, I do not think that this is a blocker.

Yes, saw that it comes from our tokens / figma. I don`t know if we directly need a ticket. Maybe it is enough for now pointing it out and discuss it in the group?
But I agree with you, that this PR can be merged for now


actions-runner secret

Hello,
We are also experiencing similar to issues #105 #122 #166

2021-03-04T12:03:01.119Z        ERROR   controller-runtime.manager.controller.githubactionrunner        Reconciler error  {
"reconciler group": "garo.tietoevry.com", "reconciler kind": "GithubActionRunner", "name": "runner-pool", "namespace": "act
ions-runner", "error": "Secret "actions-runner" not found"}
github.com/go-logr/zapr.(*zapLogger).Error

Unlike all the other reporters though, we have setup the Operator App as a github app, rather then PAT.
Our runners yaml file is literal copy of your sample file. Except we update the org value in line 12 & 52
The setup:

namespace: github-actions-runner-operator has the github-runner-app secret which was created with the below and referenced in the operator deployment file.

kubectl create secret generic github-runner-app --from-literal=GITHUB_APP_INTEGRATION_ID=<app_id> --from-file=GITHUB_APP_PRIVATE_KEY=<private_key>
The second namespace is: actions-runner and this is where the runners yaml sample file has been deployed.
image version is:
pullPolicy: IfNotPresent
tag: v0.8.6
Any pointers would be much appreciated.

Say we create the "missing secret" like so:
kubectl create secret generic actions-runner --from-literal=GITHUB_APP_INTEGRATION_ID=<app_id> --from-file=GITHUB_APP_PRIVATE_KEY=<private_key> we then see this error:

r": "actions-runner/runner-pool"}
2021-03-04T12:31:03.446Z        DEBUG   controller-runtime.manager.events       Warning {"object": {"kind":"GithubActionRun
ner","namespace":"actions-runner","name":"runner-pool","uid":"4dcd5363-4de7-4dce-8297-dae48b0ce19f","apiVersion":"garo.tiet
oevry.com/v1alpha1","resourceVersion":"104280116"}, "reason": "ProcessingError", "message": "could not parse private key: I
nvalid Key: Key must be PEM encoded PKCS1 or PKCS8 private key"}
2021-03-04T12:31:03.462Z        ERROR   controller-runtime.manager.controller.githubactionrunner        Reconciler error  {
"reconciler group": "garo.tietoevry.com", "reconciler kind": "GithubActionRunner", "name": "runner-pool", "namespace": "act
ions-runner", "error": "could not parse private key: Invalid Key: Key must be PEM encoded PKCS1 or PKCS8 private key"}
github.com/go-logr/zapr.(*zapLogger).Error

Say we create the "missing secret" like so:
kubectl create secret generic actions-runner --from-literal=GITHUB_APP_INTEGRATION_ID=<app_id> --from-file=GITHUB_APP_PRIVATE_KEY=<private_key>
we then see this error:

r": "actions-runner/runner-pool"}
2021-03-04T12:31:03.446Z        DEBUG   controller-runtime.manager.events       Warning {"object": {"kind":"GithubActionRun
ner","namespace":"actions-runner","name":"runner-pool","uid":"4dcd5363-4de7-4dce-8297-dae48b0ce19f","apiVersion":"garo.tiet
oevry.com/v1alpha1","resourceVersion":"104280116"}, "reason": "ProcessingError", "message": "could not parse private key: I
nvalid Key: Key must be PEM encoded PKCS1 or PKCS8 private key"}
2021-03-04T12:31:03.462Z        ERROR   controller-runtime.manager.controller.githubactionrunner        Reconciler error  {
"reconciler group": "garo.tietoevry.com", "reconciler kind": "GithubActionRunner", "name": "runner-pool", "namespace": "act
ions-runner", "error": "could not parse private key: Invalid Key: Key must be PEM encoded PKCS1 or PKCS8 private key"}
github.com/go-logr/zapr.(*zapLogger).Error

Going through setup myself as well. I ended up provisioning that secret through Terraform, outside of the chart to keep the PEM out of TF.
When creating the secret the way you mentioned, was the GitHub App's PEM file base64 encoded? It should be :) @lifeofmoo

Hi @BastianM3,
It wasn't

Hi @BastianM3 ,
The PEM file in the command wasn't base64 encoded as I assumed it becomes base64 encoded when created as an Opaque object.
A few questions around this:

The --from-file=GITHUB_APP_PRIVATE_KEY=pem.file, are you saying this pem file should be the BASE64 version?

so a format like:
xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
aaEJrRm1xTlU3bllOckV2Q2FQV2JDVlFGMgpJSE9WaEdyMmVnK2pMbEZJanRmTS9JdVRLeDRJ
IFJTQSBQUklWQVRFIEtFWS0tLS0tCg==

As apposed to the 'raw' format?
-----BEGIN RSA PRIVATE KEY-----
xxxxxxxxx
-----END RSA PRIVATE KEY----

The "PEM" for both secrets, are they the same but just created in two different namespaces?

For what is worth I am seeing the same issue Invalid Key: Key must be PEM encoded PKCS1 or PKCS8 private key
GH enterprise, using GH app and the Helm chart.

I got over the error by adding the private key to the last section of the values.yaml for the operator helm chart
nodeSelector:
  NodeType: devops

github:
  # If you run github-enterprise, then change the endpoint as appropriate
  apiEndpoint: https://github.company.com/api/v3

envFrom:
- secretRef:
    name: github-runner-app

githubapp:
  enabled: true
  integrationId: "10"
  privateKey: |
    -----BEGIN RSA PRIVATE KEY-----
    MIIEowIBAAKCAQEAsRWgIfRfhHQ1ycwIb4++ZcR4p2lWt0Gr6nyH
    ..........
    VaxFiyL5SOiAa6PSKyGmpfYgJS5Rn2xpXKVN3UMP0At9rfXAGC3w
    -----END RSA PRIVATE KEY-----
  existingSecret: ""

Now I have different error no installation found for "ORG" but this I believe is due to the way I have setup the GH app.

For everyone who is having issues in this thread, I have managed to resolve all of my similar issues.
Secret "actions-runner" not found
The readme is missing the fact that the secret needs to be created in the same namespace that the operator is installed in.
So add -n github-actions-runner-operator to the create secret command.
are you saying this pem file should be the BASE64 version
The pem file should not be in base64 format.
Invalid Key: Key must be PEM encoded PKCS1 or PKCS8 private key
This happens because the readme is missing two things that need to be set when installing the helm chart for the operator:
helm upgrade --install github-actions-runner-operator evryfs-oss/github-actions-runner-operator --namespace github-actions-runner-operator --set githubapp.existingSecret=github-runner-app --set githubapp.enabled=true

no installation found for "ORG"
This issue happens because the readme is missing an important instruction after creating the github app.
You need to install the app. (it can be done from the github app in the developer section after creating it.

I've ditched this from my clusters now in favour of: https://github.com/actions-runner-controller/actions-runner-controller.
All the best.


Disabling  the debugInfo and quiet  in the config is throwing an error.

Disabling  the debugInfo and quiet  in the config is throwing an error. using the latest version of gulp-ruby-sass and sass v 3.5.5
InvalidOption: invalid option: --no-debug-info
{
	debugInfo: false,
    quiet: false
}

Hey, sorry, this project is now deprecated because Ruby Sass is deprecated.
See: https://github.com/sindresorhus/gulp-ruby-sass#deprecated


"base" Security Group issue.

The below error message is occurring due to the security group.
{"code":400,"description":"CODE: InvalidGroup.NotFound,  MESSAGE: You have specified two resources that belong to different networks."}
By default, the cartel API is adding a "base" security group while creating EC2 instances.  Suppose I add a "base" security group in the "security_groups" group variable. This error message is occurring. I am thinking that the carte API is treating this as a new security group and try to add. It is failing.
The Example: security_groups = ["XXXX", "base"]

@rsankaranarayanan I will move this ticket to https://github.com/philips-software/terraform-provider-hsdp/issues


[CI] Always build latest images for integration tests

Motivation
We have some CIs that are not using the latest image for running integration
tests. We should always build the latest image using the current code
to run the integration tests.
Modifications

Add build docker steps in the ci files

/pulsarbot run-failure-checks


poloniex

can you add poloniex exchange?

sorry, for I haven't the account and didn't trade on poloniex exchange, development and testing is a little bit difficult for me.


Share screen with state

Added an InfoBanner to be displayed when a user comes in contact with somebody reporting COVID.
Biggest change: I renamed Share to Home and added a rudimentary struct
struct UserState {
    var firstTimeUser: Bool
    var hasBeenInContact: Bool
    var hasBeenTestedInLast14Days: Bool
}

This struct should eventually be represented by the global stage manager, but for now it's here so that I can work on the state logic for the Home screen. The logic is a bit complex, though I've tried to keep it as straightforward as I can.
I also spun a function in Button to make it simpler to place buttons centered between two vertical pixels
func drawBetween(parentVC: UIViewController,
                 top: CGFloat,
                 bottom: CGFloat,
                 centerX: CGFloat)

I figure that even if we end up rewriting everything with storyboards and constraints, this function will come in handy because it accounts for the optional button subtext, which I imagine is tricky to do from the storyboards.

@jeffctown Any ideas for what I should about these long string literals that are breaking our line length linter rules?

@ibeckermayer to get rid of the long string SwiftLint warnings you could put them in a storyboard (preferred), try a one line multiline literal, or just disable the warnings.

This is behind dev, could you merge and submit a new PR? The reason I ask this is because I used UIColor extensions to update the color of buttons to v1.6 design. The use of UIColor fixed colors rather than hardcoding hex values helps with future design updates as well.


example does not work

Hey,
I tried the example from the docs, but unfortunately it does not work:
windows server 2012
Python 3.7
snake.py
import time
SNAKE = r"""
                          ____
 ________________________/ O  \___/
<_____________________________/   \
"""

if __name__ == "__main__":
    print(SNAKE)
    time.sleep(10)

installer.py

from pathlib import Path
import condansis

if __name__ == "__main__":
    this_dir = Path(__file__).parent

    # instantiate Installer
    installer = condansis.Installer(
        package_name="snake-simulator",
        package_root=this_dir,
        package_version="1.0",
        include=["resources"],
        icon=Path("resources", "snake.ico"),
    )

    # Create a shortcut in the snake.exe entrypoint
    # In the target computer, entrypoints can be found at
    # $INSTDIR\$ENV\Scripts
    installer.add_shortcut(
        shortcut_name=Path("$INSTDIR", "snake.lnk"),
        target_file=Path("$INSTDIR", "$ENV", "Scripts", "snake.exe"),
        icon_file=Path("$INSTDIR", "resources", "snake.ico"),
    )

    # Create the installer
    installer.create()

File "...\installer example\installer.py", line 34, in
installer.create()
File "...\lib\site-packages\condansis\installer.py", line 354, in create
self.create_temp_env(env_prefix)
File "...\lib\site-packages\condansis\installer.py", line 221, in create_temp_env
check=True,
File "...\lib\subprocess.py", line 488, in run
with Popen(*popenargs, **kwargs) as process:
File "...\lib\subprocess.py", line 800, in init
restore_signals, start_new_session)
File "...\lib\subprocess.py", line 1148, in _execute_child
args = list2cmdline(args)
File "...\lib\subprocess.py", line 555, in list2cmdline
needquote = (" " in arg) or ("\t" in arg) or not arg
TypeError: argument of type 'WindowsPath' is not iterable
Thanks for your help!

Hello,
Thanks a lot for raising this issue. CondaNSIS is only compatible with python>=3.8. The README and the environment to reflect that. It is also important to say that, despite CondaNSIS requiring python>=3.8, it can build python apps that use older python versions.
Also a clarification, the installer.py file you posted creates the installer for the example  package, it does not work with the example snake.py script .

I ran into the same problem. And readme and docs does not seem to reflect this issue.
I fixed it locally by editing the condansis source code. In the condansis/installer.py, I found all references to subprocess (4 in total) and wrapped all parts of the args list in str(...). Example:
        subprocess.run(
            [self.makensis_exe, script_name], check=True,
        )

to
        subprocess.run(
            [str(self.makensis_exe), str(script_name)], check=True,
        )

Hi Peter, thanks for the suggestion. I have just pushed the changes you suggested (https://github.com/guilhermebs/CondaNSIS/pull/3)  as they seem to be more stable approach, even though I can't reproduce the error.

Thank you! That's awesome!


Improve interact.ts

Describe the problem

Use fee from deployment configuration.
We also should log the error within the else block.

Describe the proposed solution
...
Alternatives considered
No response
Importance
would make my life easier
Additional Information
No response

Completed with #424


PDHG current solution bugfix

The base algorithm class calls update() followed by update_previous_solution()
With PDHG this sets self.x_old to the current solution and self.x to the previous solution.
This PR changes self.get_output and update_objective to return the current solution, previously they were referring to the previous solution.

@epapoutsellis @paskino nudge :)


Uncaught Error: dlopen(~/Downloads/AP Computer Science A/Atom.app/Contents/Resources/app.asar.unp...

Prerequisites

[ ] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: <https://github.com/issues?q=is%3Aissue user%3Aatom>
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

Steps to Reproduce

Expected behavior:

Actual behavior:

Versions
Atom: 1.60.0 x64
Electron: 9.4.4
OS: macOS 12.4
Thrown From: Atom Core
Stack Trace
Uncaught Error: dlopen(/Users/HuiWen/Downloads/AP Computer Science A/Atom.app/Contents/Resources/app.asar.unpacked/node_modules/keyboard-layout/build/Release/keyboard-layout-manager.node, 0x0001): tried: '/Users/HuiWen/Downloads/AP Computer Science A/Atom.app/Contents/Resources/app.asar.unpacked/node_modules/keyboard-layout/build/Release/keyboard-layout-manager.node' (no such file)
At electron/js2c/asar.js:140

Error: dlopen(/Users/HuiWen/Downloads/AP Computer Science A/Atom.app/Contents/Resources/app.asar.unpacked/node_modules/keyboard-layout/build/Release/keyboard-layout-manager.node, 0x0001): tried: '/Users/HuiWen/Downloads/AP Computer Science A/Atom.app/Contents/Resources/app.asar.unpacked/node_modules/keyboard-layout/build/Release/keyboard-layout-manager.node' (no such file)
    at process.func [as dlopen] (electron/js2c/asar.js:140:31)
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:1034:18)
    at Object.func [as .node] (electron/js2c/asar.js:149:18)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Module.require (/app.asar/static/index.js:72:46)
    at require (internal/modules/cjs/helpers.js:74:18)
    at customRequire (/Users/HuiWen/Downloads/AP Computer Science A/Atom.app/Contents/Resources/app/static/<embedded>:1:756278)
    at get_KeyboardLayoutManager (/Users/HuiWen/Downloads/AP Computer Science A/Atom.app/Contents/Resources/app/static/<embedded>:14:2873999)
    at get_manager (/Users/HuiWen/Downloads/AP Computer Science A/Atom.app/Contents/Resources/app/static/<embedded>:14:2874101)
    at Object.getCurrentKeyboardLayout (/Users/HuiWen/Downloads/AP Computer Science A/Atom.app/Contents/Resources/app/static/<embedded>:14:2874227)
    at e.keystrokeForKeyboardEvent (/Users/HuiWen/Downloads/AP Computer Science A/Atom.app/Contents/Resources/app/static/<embedded>:14:1121316)
    at KeymapManager.keystrokeForKeyboardEvent (/Users/HuiWen/Downloads/AP Computer Science A/Atom.app/Contents/Resources/app/static/<embedded>:11:1225566)
    at KeymapManager.handleKeyboardEvent (/Users/HuiWen/Downloads/AP Computer Science A/Atom.app/Contents/Resources/app/static/<embedded>:11:1223551)
    at WindowEventHandler.handleDocumentKeyEvent (/Users/HuiWen/Downloads/AP Computer Science A/Atom.app/Contents/Resources/app/static/<embedded>:11:286682)

Commands
  2x -0:35.7.0 tree-view:add-file (span.name.icon.icon-file-directory)

Non-Core Packages

Additional Information

Thanks for taking the time to contribute!
We noticed that this is a duplicate of https://github.com/atom/atom/issues/21285. You may want to subscribe there for updates.
Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.


HW Submission

PR Description

Well done!
Please open a new PR after correcting the broken link.
Thanks!


CPP: Speed up startsWithIfndef.

This in turn speeds up 'AV Rule 35.ql' on large snapshots, though the effect is usually much less significant than https://github.com/Semmle/ql/pull/313.

@rdmarsh2 please review?


Adding Configuration for appveyor ci

A while I was having a lot of trouble in running sbt test on windows machine. Reasons are still unknown why that was happening(may be jsdom or may be wrong version of npm). So I thought adding a appveyor ci config to give some love to windows users :)

This seems to be congfigured specifically for your system, with all those absolute paths etc. Probably not very useful for users with different paths?

I think that should not be a problem. Not sure what absolute paths you are referring to.

For example SBT path and JAVA_HOME.
Besides, this is quite a bit outside the scope of the SPA tutorial anyway :)

Agreed. Closing this one. Thanks.


return real errors rather than integers

created the error type GoogleVoiceError
created the function getError which returns a GoogleVoiceError when given a status code
regex replaced in vim :%s/\(STATUSES\.\w\+\)/getError(\1)/gc which wraps all STATUSES\.\w+ with getError()
tested that the code parses correctly
tested a hard-coded throw getError(STATUSES.GOOGLE_CLIENTLOGIN_ERROR) - works
tried to get a real authentication error, but there was an xml parse error in googleclientlogin, so it didn't get that far.

Thank you for these great additions, AJ!


AVRO-3591: start with commons schemas

First try for AVRO-3591

@martin-g  I added readme.md files, i hope it matches what you expected.


Remove MV2_ENABLE_TOPO_AWARE_COLLECTIVES=0 from custom launcher

We should remove SETENV("MV2_ENABLE_TOPO_AWARE_COLLECTIVES", 0) from customlauncher now that LC has added this to the default SLURM environment.

Fixed on 3.4RC for 3.4.2 with #19970
Fixed on develop with #19974


hello world

say this is a test

say again.

what is the title of this issue?

What is the issue number?

What is my user name?

What git service are we on?

But, it should say git*** issue number: 22 or something right?

Are we on github, gitlab, gerrit, or gitqube?


need more demo to show how this engine can reach to

This is on our Todo list.  Stay tuned :)

boardgame fan!


Add option to disable touch on the invisible track

It would be nice to have some kind of option to disable touch on the invisible track
Sometimes users touch it accidentally without knowing that it would actually move to that position.

@tom5079 Let's add reference this issue in #32 by amending the last commit message

just comment out trackView.setOnTouchListener(touchListener) at https://github.com/quiph/RecyclerView-FastScroller/blob/0ba9c9a4ac37c0041e7941865a9a822c42f631a9/recyclerviewfastscroller/src/main/java/com/qtalk/recyclerviewfastscroller/RecyclerViewFastScroller.kt#L498 for it. Do not be confused by it not working in the sample app, the recyclerView actually has side margins and it doesn't to below the track. Pretty bad UX I'd say :)


Preparing release v2.2

Merges the latest minor branch up into master to prepare the upcoming 2.2 release.

Exciting!


Upgrade Netty version to 4.1.60.final

Upgrade netty to resolve security issues in the current version.

https://nvd.nist.gov/vuln/detail/CVE-2021-21295
https://nvd.nist.gov/vuln/detail/CVE-2021-21290

Fixes #10071

I can see that this fix has been backported to branch-2.7 . Is there anything that prevents upgrading Netty in branch-2.6 ?


Add strategic resources into converted games

https://forum.paradoxplaza.com/forum/index.php?threads/v2-to-hoi3-converter-mod.582798/page-49#post-21003822

There are too many of these to resolve, and so they will not be included.


Time reactive ui #9

created a night_time.html with a moon which when u hover over, winks at you
redirects to this page between 2am-5am and back to index.html after 5am
@vansh-codes

@vansh-codes i made some changes, is it possible to revert the merge?
i think it'll be better if i change the website to the moon winking when someone clicks the contact button during a given time
or do you like the way it is now? the whole website will change during the given time in the current code

Would be better if you create new PR


Fix the crop_from_location ratio bug and a unit test.

scene_cropper.cc Line 147 - 156.

Let's go ahead and retract this since we have this fixed in google3 now.


Playground is not defined.

I keep getting this error anytime I run the api-admin.
I've added the playground workspace version but the error is still there.

@iamonuwa this an apollo server issue and should be created in apollo server repo. Best use an older version of apollo for now


Can't spawn builtin actions from a rule implementation

I'd like to be able to use the builtin version of the C++ compilation action in a custom rule. Right now it seems like this is impossible and the only thing I'm able to do is cons up a string to pass to the shell, maybe referring to $(CC) and friends, and explicitly walking through ctx.targets.deps to figure out my includes and copts.

Supposing you're writing this in Skylark, does creating native.cc_binary help?

Are you writing a "macro" (a function that expands at BUILD loading time and emits existing rules), or a native rule? If the latter, can you post a snippet or a more detailed explanation of what you are trying to do?

The macro and rule we're using is https://github.com/google/kythe/blob/master/tools/build_rules/genproto.bzl ; for Java, this is based on genproto from Bazel's build_rules. Since we started the latter has grown a java_compile_command--why doesn't/shouldn't this use the builtin Java compile action?

Java genproto is a bit of a special case. Since the output file names depend on the contents of the .proto file, it can't easily be fitted in as a normal Java compile (for normal Java compiles, you have to specify file names upfront.)

I'm going to mark this as WAI.
If you want to depend on C++ artifacts, use a macro. If you want to interoperate with C++ code in rules,
https://github.com/google/bazel/issues/146 is the right bug.


The ctx. _matchedRoute is not the route I requested!

node.js version: 12.12.0
npm/yarn and version: 6.11.3
koa-router version: 7.4.0
koa version: 2.10.0
hi,I have some problems. I use koa tag 2.7.0 .
Now I have two routes, one is "/api/order/list" and another is "/api/order/:orderId" .
I want to log each request. When I request the second interface with params, I want the url I am recording to be the url of my own defined api, not the url directly with params.For example, when I request "http://<IP_ADDRESS>:3000/api/order/57d52c52403f2ee865738ec7", I want to record that the url is "/api/order/:orderId" instead of "/api/order/57d52c52403f2ee865738ec7".
But ctx.url ctx. originalUrl is not what I want, and ctx. _matchedRoute is what I want.However, I have a new problem. When I request "/api/order/list", the value of ctx._matchedRoute is still "apr/order/:orderId" instead of "/api/order/list" and ctx.matched is an array of two object elements.
Why the _matchedRoute is not the route I requested?
Code sample:
http:<IP_ADDRESS>:3000/api/order/list

http:<IP_ADDRESS>:3000/api/order/:orderId

I ran into the same problem. The issue is, that matchedLayers contains - as the name suggests - all matched layers, that will be put in the middleware-chain (because the regex matches).
In the case above, it's because :orderId could also be list. So, if the orderId-Middleware decides, it doesn't want to handle the request, it can call next() and the list-route will be called.
With that being said, the ctx._matchedRoute is probably a bug - or at least misleadingly named.
I've created PR #524, which would populate ctx.routerPath

@schwarmco this is the official one from koa org https://github.com/koajs/router , a fork of this repo

@tuananh thanks - i opened a pull-request there... just landed here, because i searched for this exact same issue :)

Thanks very much, I have some things I did not pay attention to this issue in time, sorry!

Already got help：https://github.com/koajs/router/releases/tag/v9.1.0     Thx!!!!!