Finally tasks not triggered in case of task failing due to missing results

Expected Behavior
I have a pipeline with two tasks - first one producing a result, second one using the result and finally task not using the result at all. Finally task should always run.
Actual Behavior
When first task doesn't produce the result, second one correctly fails. Finally task is skipped.
Steps to Reproduce the Problem

Run the below pipeline

apiVersion: tekton.dev/v1beta1
kind: Pipeline
metadata:
  name: finally-pipeline
spec:
  tasks:
  - name: task-a
    taskSpec:
      steps:
      - name: hello
        image: registry.access.redhat.com/ubi8/ubi-minimal
        script: |
          #!/usr/bin/env bash
          echo "Hello from task A"
          # uncomment to fix the issue
          #echo "foo" > $(results.foo.path)
          sleep 5
      results:
        - name: foo
  - name: task-b
    params:
      - name: input
        value: $(tasks.task-a.results.foo)
    taskSpec:
      params:
        - name: input
      steps:
      - name: hello
        image: registry.access.redhat.com/ubi8/ubi-minimal
        script: |
          #!/usr/bin/env bash
          echo "Hello from task B"
          echo "Content of param: $(params.input)"
          sleep 5
  finally:
  - name: final-task
    taskSpec:
      steps:
      - name: finally
        image: registry.access.redhat.com/ubi8/ubi-minimal
        script: |
          #!/usr/bin/env bash
          echo "Hello from finally"
          sleep 5

Additional Info

Kubernetes version:
Output of kubectl version:

Client Version: version.Info{Major:"1", Minor:"26", GitVersion:"v1.26.9", GitCommit:"d1483fdf7a0578c83523bc1e2212a606a44fd71d", GitTreeState:"archive", BuildDate:"2023-09-16T00:00:00Z", GoVersion:"go1.20.8", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v4.5.7
Server Version: version.Info{Major:"1", Minor:"26", GitVersion:"v1.26.9+636f2be", GitCommit:"e782f8ba0e57d260867ea108b671c94844780ef2", GitTreeState:"clean", BuildDate:"2023-10-20T19:28:29Z", GoVersion:"go1.19.13 X:strictfipsruntime", Compiler:"gc", Platform:"linux/arm64"}

Tekton Pipeline version:
Output of tkn version or kubectl get pods -n tekton-pipelines -l app=tekton-pipelines-controller -o=jsonpath='{.items[0].metadata.labels.version}'

Client version: 0.32.2
Chains version: v0.17.1
Pipeline version: v0.50.3
Triggers version: v0.25.2
Operator version: v0.68.1

Similar to  https://github.com/tektoncd/pipeline/issues/4438

Thanks! I will take a look

I think this is caused by this pr https://github.com/tektoncd/pipeline/pull/6792

Same issue. In my case failed task had no image digest pushed in the result, because the build failed. Pipelinerun finished on the build-buildpack task.
buildpack-pipeline-build-buildpack-pod   0/3     Init:0/3            0          2s
buildpack-pipeline-build-buildpack-pod   0/3     Init:1/3            0          3s
buildpack-pipeline-build-buildpack-pod   0/3     Init:2/3            0          4s
buildpack-pipeline-build-buildpack-pod   0/3     PodInitializing     0          5s
buildpack-pipeline-build-buildpack-pod   3/3     Running             0          6s
buildpack-pipeline-build-buildpack-pod   3/3     Running             0          6s
buildpack-pipeline-build-buildpack-pod   2/3     NotReady            0          8s
buildpack-pipeline-build-buildpack-pod   0/3     Error               0          46s
affinity-assistant-a5f6edee78-0          1/1     Terminating         0          65s
affinity-assistant-a5f6edee78-0          0/1     Terminating         0          66s
affinity-assistant-a5f6edee78-0          0/1     Terminating         0          66s
affinity-assistant-a5f6edee78-0          0/1     Terminating         0          66s
affinity-assistant-a5f6edee78-0          0/1     Terminating         0          66s
buildpack-pipeline-build-buildpack-pod   0/3     Error               0          47s
buildpack-pipeline-build-buildpack-pod   0/3     Error               0          48s

output of the build-buildpack task:
[build-buildpack : build] Adding label 'org.opencontainers.image.source'
[build-buildpack : build] Adding label 'org.opencontainers.image.vendor'
[build-buildpack : build] Adding label 'org.opencontainers.image.version'
[build-buildpack : build] Setting default process type 'web'
[build-buildpack : build] Saving 11111111.dkr.ecr.us-east-1.amazonaws.com/project/prod/backend:fca18e...
[build-buildpack : build] *** Images (sha256:3a8aac28491b40f6709be20995013ec4dd2647643ec51d7116b54424326f4d01):
[build-buildpack : build]       11111111.dkr.ecr.us-east-1.amazonaws.com/project/prod/backend:fca18e - PUT https://11111111.dkr.ecr.us-east-1.amazonaws.com/v2/project/prod/backend/manifests/fca18e: TAG_INVALID: The image tag 'fca18e' already exists in the 'project/prod/backend' repository and cannot be overwritten because the repository is immutable.
[build-buildpack : build] ERROR: failed to export: failed to write image to the following tags: [11111111.dkr.ecr.us-east-1.amazonaws.com/project/prod/backend:fca18e: PUT https://11111111.dkr.ecr.us-east-1.amazonaws.com/v2/project/prod/backend/manifests/fca18e: TAG_INVALID: The image tag 'fca18e' already exists in the 'project/prod/backend' repository and cannot be overwritten because the repository is immutable.]

[build-buildpack : results] 2023/12/29 01:29:14 Skipping step because a previous step failed

the final task is not executed
  finally:
    # ┌─────────────────────────────────────────────────────────────────────
    # │ ⚫ Final Notify
    # └─────────────────────────────────────────────────────────────────────
    - name: notify
      displayName: "Notification from $(context.pipeline.name)"
      when:
        - input: $(params.workflow.notify)
          operator: in
          values: ['true']
      taskRef:
        name: notify
      workspaces:
        - name: source
          workspace: source
      params:
        - name:  working_directory
          value: $(params.git.checkout_directory)
        - name:  environment
          value: $(params.environment)
        - name:  application
          value:
            project:           $(params.application.project)
            component:         $(params.application.component)
            url:               $(params.application.url)
            argocd_app:        $(params.application.argocd_app)
            argocd_url:        $(params.application.argocd_url)
            tekton_url:        $(params.application.tekton_url)
            jira_url:          $(params.application.jira_url)
            jira_prefix:       $(params.application.jira_prefix)
            grafana_url:       $(params.application.grafana_url)
            karma_url:         $(params.application.karma_url)
            alertmanager_url:  $(params.application.alertmanager_url)
            sentry_url:        $(params.application.sentry_url)
            documentation_url: $(params.application.documentation_url)
            devops_team:       $(params.application.devops_team)
            pm_team:           $(params.application.pm_team)
            tm_team:           $(params.application.tm_team)
            lead_developers:   $(params.application.lead_developers)
        - name:  git
          value:
            repository_url:      $(params.git.repository_url)
            checkout_branch:     $(params.git.checkout_branch)
            checkout_revision:   $(params.git.checkout_revision)
            commit_author:       $(params.git.commit_author)
            commit_author_url:   $(params.git.commit_author_url)
            commit_message:      $(params.git.commit_message)
        - name:  status
          value: $(tasks.status)
        - name:  pipelinerun
          value:
            name:      $(context.pipelineRun.name)
            namespace: $(context.pipelineRun.namespace)
            uid:       $(context.pipelineRun.uid)
        - name: image_digest
          value: $(tasks.build-$(params.build.use).results.app_image_digest)

Thanks! Just come back from holidays, will work on this issue

@Yongxuanzhang any updates?

@Yongxuanzhang any updates?

Sorry I'm kinda busy recently, 😢 , don't have enough time to come up with a solution yet.

Is there any chance that anybody would work on this?

@Yongxuanzhang is on leave for now so please go ahead @divyansh42. I don't think he will mind 😄

Does anybody plan to work on this?

/assign
I will work on this

I attempted to solve this bug but I think this is not actually a bug but more of design enhancement, therefore I would need others opinion as well.
With reference to the above pipeline example, taskrun for  task-b is not getting created as task-b is failing at the validation level where it is trying to verify the result references. Looking at the code, we can't define the status of a task (even if it is failed at the validation step). We can only have the status (Success, Failure or Skip) when taskrun is created and in this case, taskrun is not getting created.
For finally to execute, DAG needs to be completed but it is not getting into the case where DAG is completed as task-b doesn't have any status.
So, I am considering this as more of a design enhancement where we want to know what should be the status when taskrun is not created and the task fails at the runtime validation.
To deal with this, the solution that I can think of is to create another status in parallel to Skipped, Failure, and Success. It can be named something like validationFailed where it will store the number of all the tasks which is failed at the runtime validation. We will mark these kinds of tasks as validation failed and check this condition when we are checking whether DAG is complete or not.
@pritidesai @afrittoli @vdemeester please let me know your thoughts on this. Also, please suggest if you think any other approach is feasible. Thanks.

We can only have the status (Success, Failure or Skip) when taskrun is created and in this case, taskrun is not getting created.
For finally to execute, DAG needs to be completed but it is not getting into the case where DAG is completed as task-b doesn't have any status.

How is this different from tasks that are skipped because of when expressions?

We can only have the status (Success, Failure or Skip) when taskrun is created and in this case, taskrun is not getting created.
For finally to execute, DAG needs to be completed but it is not getting into the case where DAG is completed as task-b doesn't have any status.

How is this different from tasks that are skipped because of when expressions?

@ppitonak In the case of the when expression we are marking the respective task as skipped and not failing the pipelinerun.
But we can't skip the task in this case as it is a failure.

@divyansh42 thanks for looking into this. Regarding your comment:

With reference to the above pipeline example, taskrun for task-b is not getting created as task-b is failing at the validation level where it is trying to verify the result references. Looking at the code, we can't define the status of a task (even if it is failed at the validation step). We can only have the status (Success, Failure or Skip) when taskrun is created and in this case, taskrun is not getting created.

How Tekton is representing internally the inability to execute task-b should not affect the behaviour of the pipeline orchestration. The Tekton controller has reconciled all tasks: task-a has been executed, task-b has been evaluated but not executed because of the missing result, thus the DAG is complete and the finally task should be executed.
This definitely seems to me like a bug in Tekton, which we should address.
The only documented case where a finally task is not executed, is when it depends directly on a result which was not produced. Changing that would require implementing TEP-0048.

Thank you @afrittoli  for taking a look at this.
Initially, I had the same conclusion that task-b has been evaluated so DAG should be complete.
According to the implementation, DAG will be marked as complete if all the task under DAG is marked as Success, Failed, or Skipped. In the case of task-b, it is not marked as failed or Skipped.
By looking at the implementation it seems we can only mark this as failed when the corresponding Taskrun is created. In this case, taskrun is not getting created.

Thank you @afrittoli for taking a look at this.
Initially, I had the same conclusion that task-b has been evaluated so DAG should be complete. According to the implementation, DAG will be marked as complete if all the task under DAG is marked as Success, Failed, or Skipped. In the case of task-b, it is not marked as failed or Skipped.
By looking at the implementation it seems we can only mark this as failed when the corresponding Taskrun is created. In this case, taskrun is not getting created.

There are two options to solve this that I see:

Mark task-b as skipped instead of failed. This is user-facing, since the status will change, but I think it would be more precise than the current validation failure
Keep the validation failure, and change the implementation so that the DAG may complete in that scenario

My preferred would be (1), although I have not checked the code to see what it would take to implement it.

If we mark that task-b as skipped then as per the current logic PipelineRun will be marked as success.
I am not sure if we want to do this way, as there is some error due to which result was not produced and if we mark the pipeline as success then from the user perspective this might get hard to track the exact problem.


Runs the processors before finishing the span

Hi 👋🏼
This Pull Request simply moves the processors call to the beginning of the finish() method.
Why?
Otherwise, you can't modify the span getting finished. Processors are run AFTER the span @ended variable
gets updated to true. Thus, the span is locked for changes.
Real use case
Suppose you want to add extra attributes to you spans on the way out the door.
Therefore, you can create a custom processor by implementing a child class of
OpenTelemetry::SDK::Trace::SpanProcessor and overriding the method on_finish().
This method receives the span getting finished and you can then add new attributes, right?
Not exactly, cause by calling add_attributes you receive an error: Calling add_attributes on an ended Span.
Whit that, my personal assumption is that you can not do anything useful inside on_finish() method
of a custom Processor cause the span will always be @ended when this method is called.
The changes
This PR makes the span finish() method to iterate calling every Processor BEFORE actually ending
the span. It will allow processors to modify spans before actually finishing it.
Other argument: on_start method
If you look at the way this Span class calls on_start method, you will see it being the last thing in the
initialize() method. That makes sense, we first create the span, then we call each processor for that particular span.
The on_finish() method should do the opposite: run processors FIRST, then finish the span. Does it make sense?
Considerations
Please, let me know in case you folks think I should do something else for this PR.

Heavy 👎
This change does not conform to the specification. Modifying the span in the onEnd/on_finish method is not permitted.
See https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#onendspan
There is a new OnEnding option that SDKs can implement which runs before OnEnd, and which allows spans to be modified. This is what should be implemented in the Ruby SDK to achieve your need.
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#onending

Just quickly chiming in, tldr this is a limitation of the spec. You bring up valid practical considerations (which I agree with the spirit of!) but we are beholden to the specification that states spans have to be ended before being passed into onend
https://opentelemetry.io/docs/specs/otel/trace/sdk/#onendspan
Looks like there's the concept of "onending" that sortve is what you're looking for, but it's in "development" within the spec https://opentelemetry.io/docs/specs/otel/trace/sdk/#onending
, so I'm not sure what the path forward is there for Ruby.
Some of the more knowledgable folks and maintainers here can provide better context with the precise language on why this is working as intended, and suggested workarounds (monkeypatch the sdk itself, some sort of cloning of spans, etc) or path forward.

"in development" means the spec is brand new and may still change, in which case the SDKs would have to change too.
Nothing prevents ruby from adopting this part of the spec right now.

Thank you @dmathieu for all the clarifications. I totally agree with everything you have mentioned.
And thankfully, the new Spec seems to solve the issue I have tried to report.
Do you folks mind if I try to implement the new Spec? Is there anyone working in such thing already?

Hi @pantuza! We'd love to have you work on it! I created https://github.com/open-telemetry/opentelemetry-ruby/issues/1695 to track this work. Please comment on the issue so I can assign it to you.
We've talked about this new feature in the SIG, but no one is working on it AFAIK. Let us know if you need any help 🙂

I am closing this PR since, based on the suggestion made here, I have opened another Pull Request (#1713) addressing the Open Telemetry Spec.


Make elements test no longer hang at cost of possible false negative

See this conversation for context.

Thanks! I had forgotten about this PR.


Support RDS replica promotion

Is your feature request related to a problem?
We currently use ACK to provision PostgreSQL RDS instances, and sometimes need to create a cross-region replica for disaster recovery purposes. This can be accomplished by setting sourceDBInstanceIdentifier on the DBInstance resource. However, there is no way to promote it to a primary instance if the primary region fails.
Describe the solution you'd like
One possibility would be to detect the removal of the sourceDBInstanceIdentifier field, and then issue a PromoteReadReplicaRequest to complete the failover process.

Hi @mmanes thank you for raising this issue. So if understand well we're looking into adding a new spec field that allows you to promote a db instance to primary? My worry here is, what if 3 instances have this field set to true? we'll have 3 instances trying to compete to become primary and there will never reach final state where only one of them is primary. I'm trying to think if there is a better way to do this.

Hi @a-hilaly. I was suggesting to use the the existing sourceDBInstanceIdentifier field. When it is set, the instance is created as a replica, so removing that field value could cause it to be promoted to a primary. I'm sure there are other implementation options as well.
I see how having multiple replicas complicates this. When you promote a replica, it leaves the original cluster and becomes a new, non-clustered primary instance. It does not become the primary of the original cluster.
Using this solution, if you cleared out the field of 3 replicas, they would likely all eventually reconcile to be promoted to their own primaries.


Frond and tumbnails not working on build 385

The tumbnail is multiple times created first one is in good size the other is not and that one is displayed on the page.

Could you please be more precise. What exactly did you try to do, what is the code you used... otherwise I will not be able to help.

Hey,
I tried to create a thumbnail with you plugin on multiple locations inside my project.
because first it works and now it doesnt i dont know what goes wrong. I've updated october several times.
A sample of the implementation.
product.image|mediathumb_resize('weight', 380)

a little bit more of your code would maybe help, but "weight" ist not an option, only "height".

or "width", for example.

Hey, I wanted to let you know that it was a mistake on my part.
I replace the weight with width
thanks again

OK, glad it worked out.


ENH: run models on fastest device automatically

We should try to run models on the fastest device available. Take Apple M1 as an example, we should leverage the power of metal as much as possible.

#98


Testing models 9

Assignee Tasks

[ ] added unit tests (or none needed)
[ ] written relevant docs (or none needed)
[ ] referenced any relevant issues (or none exist)

Guidelines
Please add a description of this Pull Request's motivation, scope, outstanding issues or potential alternatives, reasoning behind the current solution, and any other relevant information for posterity.

Your PR Notes Here

All models tested


No support for ALTER table

Can you please advice on when the Support for Alter table will be provided. The idea is to be able to update CQL table based on the difference of the Actual table schema and the current columns set of phantom Cassandra Table.
Thank you

@arkady60 Hi, support for ALTER table will be included in either 1.6.0 or 1.7.0.We have already begun work on a new Query builder written in Scala to superseed the Datastax variant in phantom. This new builder will fully support all CQL options and the entire protocol, including ALTER queries.
The 1.6.0 release is scheduled for end of February, but the likely odds are the new querybuilder will reach a stable variant somewhere around end of March 2015. Hope this helps and we will keep everyone posted.


orjson dependency missing

Hi,
I think 'orjson' is missing as a dependency.
Seen in degiro-connector 3.0.6.
Thanks! Great package.

Hello @nickvanc,
fixed the issues the new version.
Thanks for letting me know !
I am currently refactoring the library to replace:

protbuf with pydantic
pandas with polars

There might be few bugs coming with this.
Some improvements were made:

helper charts into DataFrame
fixing the favourite list methods
models simpler to use

@Chavithra  thank!
If I run into new bugs I’ll report them.
Thanks for sharing and Happy New Year ✌


Terminal GUIs Display Issue

For example using something like "sudo apt-get install ttf-mscorefonts-installer" cause the border of the EULA Yes/No Window to become control characters and resizing the window makes it significantly worse.
True Fonts WSL
True Fonts Normal
You can still control the GUI and accept the EULA.

=)
Were you trying to run WINE on Ubuntu on Windows?

@fpqc Internally we jokingly refer to this as "Inception"

It is quite possible I was trying to install wine. Wasn't successful though.

This looks like funky UTF-8 support problems. Out of curiosity, which language/keyboard are you using?
You should be seeing line drawing characters there ('\u2518', '\u2510', '\u250c', '\u2514', '\u2530', '\u23ba', '\u23bb', etc), but I'd like to find out why those are getting translated to other unicode characters.

English / US QWERTY keyboard.

Thanks for the discussion.
Closing this issue since:

This issue is very old and has likely been fixed in recent Win10 builds
This is the WSL issues repo, but this is an issue in Console which has its own Console GitHub Repo
GitHub doesn't allow issues to be moved between repos, preserving posters' identity :(

If you have further asks/issues, please file new issues on our Console GitHub Repo.


Add CONTRIBUTING.md

Hey,
Just wanted to mention that you should add a CONTRIBUTING.md file to help people know if they should contribute, style info, suggestions, what to contribute on, etc.
Github should offer some templates for default, so it shouldn't be that hard

I'll see about expanding this section https://github.com/MarcoWorms/learn.js#contribute and then move it to CONTRIBUTING.md, makes sense to me, thanks!!

Sorry if the project is still not contribution friendly, I hope to fix this after I release the next batch of content!

done!


Feature: Use self hosted subgraph

Thank you for contributing to Open Format! Please follow this template to ensure a smooth pull request process. Make sure you have read and followed the guidelines in CONTRIBUTING.md before submitting your pull request.
Summary
Please provide a brief summary of your changes, including the issue or bounty (if applicable) you're addressing.
Example: This pull request adds a new feature to handle new token types (Issue #123).
Description
Provide a detailed description of the changes you've made, explaining the rationale behind your changes and how they improve the project
Related Issue/Bounty
Link to the related issue or bounty on GitHub.
Example: Fixes #123 or Implements Bounty #456
Type of Change
Please check the boxes that apply to your pull request:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation update (changes to documentation only)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes)
[ ] Other (please describe):

Testing
Please describe the tests you've added or updated to cover your changes, and provide instructions on how to run the tests.
Checklist

[ ] I have read the CONTRIBUTING.md document
[ ] I have followed the project's style guide
[ ] I have added or updated tests to cover my changes
[ ] All new and existing tests passed
[ ] My changes generate no new warnings or errors
[ ] I have made corresponding changes to the documentation
[ ] I have checked that my changes do not introduce any new security vulnerabilities
[ ] I have provided a clear and concise description of my changes
[ ] I have linked to the related issue or bounty, if applicable

Additional Information

Once again, thank you for your contribution! We appreciate your effort and dedication to improving the Open Format.

/release-pr

/release-pr


invalid logging about file that doesn't exist

Summary
Short summary of what is going on or to provide context.
Steps To Reproduce:
Repository to reproduce: dreamhouse-lwc

DEBUG=* sfdx force:org:beta:create -f config/project-scratch-def.json -d 1 -s

Expected result
don't warn about non-existing file
Actual result
sf:SfProjectJson INFO Reading config file: /Users/shane.mclaughlin/.sfdx/sfdx-project.json +32ms
  sf:SfProjectJson INFO Reading config file: /Users/shane.mclaughlin/eng/repros/forcedotcom-issue-scratchOrg-objectSettings/sfdx-project.json +0ms
  sf:SfProjectJson TRACE Setup child 'SchemaValidator' logger instance +3ms
  sf:SchemaValidator DEBUG Schema loaded for<EMAIL_ADDRESS>+35ms
  sf:SfProjectJson WARN The config file "/Users/shane.mclaughlin/.sfdx/sfdx-project.json" is not schema valid.
  sf:SfProjectJson Due to: Validation errors:
  sf:SfProjectJson #/required: must have required property 'packageDirectories' +11ms
  sf:SfProjectJson TRACE Setup child 'SchemaValidator' logger instance +7ms
  sf:SchemaValidator DEBUG Schema loaded for<EMAIL_ADDRESS>+19ms
  sf:SfProjectJson TRACE Setup child 'SchemaValidator' logger instance +13ms
  sf:SchemaValidator DEBUG Schema loaded for<EMAIL_ADDRESS>+13ms
  sf:SfProjectJson TRACE Setup child 'SchemaValidator' logger instance +10ms
  sf:SchemaValidator DEBUG Schema loaded for<EMAIL_ADDRESS>+9ms
  sf:SfProjectJson WARN The config file "/Users/shane.mclaughlin/.sfdx/sfdx-project.json" is not schema valid.
  sf:SfProjectJson Due to: Validation errors:
  sf:SfProjectJson #/required: must have required property 'packageDirectories' +10ms

System Information

zsh
{
"cliVersion": "sfdx-cli/7.158.1",
"architecture": "darwin-x64",
"nodeVersion": "node-v16.15.1",
"pluginVersions": [
"@mshanemc/sfdx-migration-automatic 0.3.1",
"@oclif/plugin-autocomplete 0.3.0 (core)",
"@oclif/plugin-commands 1.3.0 (core)",
"@oclif/plugin-help 3.3.1 (core)",
"@oclif/plugin-not-found 1.2.6 (core)",
"@oclif/plugin-plugins 1.10.11 (core)",
"@oclif/plugin-update 1.5.0 (core)",
"@oclif/plugin-warn-if-update-available 2.0.4 (core)",
"@oclif/plugin-which 1.0.4 (core)",
"@salesforce/sfdx-plugin-lwc-test 1.0.0 (core)",
"alias 2.1.0 (core)",
"apex 0.13.0 (core)",
"auth 2.2.2 (core)",
"community 2.0.0 (core)",
"config 1.4.12 (core)",
"custom-metadata 2.0.0 (core)",
"data 2.0.4 (core)",
"generator 2.0.2 (core)",
"info 2.0.1 (core)",
"limits 2.0.1 (core)",
"org 2.0.1 (core)",
"release-management 2.13.0",
"└─ trust 1.1.0",
"salesforce-alm 54.6.2 (core)",
"schema 2.1.1 (core)",
"sfdx-cli 7.158.1 (core)",
"shane-sfdx-plugins 4.43.0",
"├─ @mshanemc/plugin-streaming 1.1.7",
"└─ @mshanemc/sfdx-sosl 1.1.0",
"signups 1.2.0 (core)",
"source 2.0.3 (core)",
"telemetry 2.0.0 (core)",
"templates 55.0.0 (core)",
"user 2.1.0 (core)"
],
"osVersion": "Darwin 21.5.0"
}

@mshanemc is this a feature request or a bug ?


README.md Markdown link typo fix

This commit fixes a Markdown link typo and includes link checking for references.

github provider 2.9.0 seems to be broken as token is required now...

github provider 2.9.0 seems to be broken as token is required now...

The token was always required by the provider? It doesn't make much sense without the token anyways, does it ?
But yeah, pre-commit fails because of the missing token: https://mineiros.semaphoreci.com/jobs/9157e276-7ff7-4e3f-abbe-86eb16549329

https://github.com/terraform-providers/terraform-provider-github/pull/464#issuecomment-651187596

we specify the token vie environment so this was fine before..

we specify the token vie environment so this was fine before..

Yeah, we are providing it through the environment variable GITHUB_TOKEN

The token was always required by the provider? It doesn't make much sense without the token anyways, does it ?

See https://github.com/terraform-providers/terraform-provider-github/pull/464#issuecomment-651254293
As the provider was refactored to not only support organizations, the token went back to the required state. Setting the GITHUB_TOKEN environment variable to any string will fix terraform validate. tested and confirmed it with 2.8.0 and 2.9.0 of the provider.
We should also check out what this refactoring means for the features of our GitHub modules.. maybe we can add some awesome stuff...maybe we can't ;)
The fix you applied for providing the variable needs to be integrated into the other two repositories. I can create PRs for this. thanks.

I raised the issue upstream: https://github.com/terraform-providers/terraform-provider-github/issues/503
don't think we need further steps on our side as this is fixed now by providing the token.
It still breaks local pre-commits when no token is set, but it can be set to a random value.


Added support for EC2 Fleet, eu-west-3 & sa-east-1 regions and defaul…

…t Spark Cluster version

/do-e2e-tests

/do-e2e-tests

@ddubeau There was an error related to a parameter misconfigured in the test template and I corrected it, This resolved the initial error however the build failed with this error...
Received response status [FAILED] from custom resource. Message returned: Conflict InputData: {'workspace_name': 'qsdeploy-workspace', 'aws_region': 'us-west-2', 'credentials_id': 'XXXXXXXXXXXXXXXXXXXX', 'storage_configuration_id': 'XXXXXXXXXXXXXXXXXXX', 'network_id': 'XXXXXXXXXXXXXXXXX', 'deployment_name': 'qsdeploy'}

Hi Tony,
Can you share the logs. I’ve never seen this error message before or did you obfuscated the resources names with XXXX’s?
It might be best to jump on a quick call as well.

On Jan 10, 2024, at 2:00 PM, Tony Bulding @.***> wrote:
@ddubeau https://github.com/ddubeau There was an error related to a parameter misconfigured in the test template and I corrected it, This resolved the initial error however the build failed with this error...
Received response status [FAILED] from custom resource. Message returned: Conflict InputData: {'workspace_name': 'qsdeploy-workspace', 'aws_region': 'us-west-2', 'credentials_id': 'XXXXXXXXXXXXXXXXXXXX', 'storage_configuration_id': 'XXXXXXXXXXXXXXXXXXX', 'network_id': 'XXXXXXXXXXXXXXXXX', 'deployment_name': 'qsdeploy'}
—
Reply to this email directly, view it on GitHub https://github.com/aws-ia/cfn-ps-databricks-unified-data-analytics-platform/pull/15#issuecomment-1885806477, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFRPVWZKTJ6VB7L3Q34NM2LYN4FOXAVCNFSM6AAAAAA6W3DXFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBVHAYDMNBXG4.
You are receiving this because you were mentioned.

Hi Tony,
Can you share the logs? I’m not able to replicate this issue at my end.
Thanks,
Denis

On Jan 10, 2024, at 2:00 PM, Tony Bulding @.***> wrote:
@ddubeau https://github.com/ddubeau There was an error related to a parameter misconfigured in the test template and I corrected it, This resolved the initial error however the build failed with this error...
Received response status [FAILED] from custom resource. Message returned: Conflict InputData: {'workspace_name': 'qsdeploy-workspace', 'aws_region': 'us-west-2', 'credentials_id': 'XXXXXXXXXXXXXXXXXXXX', 'storage_configuration_id': 'XXXXXXXXXXXXXXXXXXX', 'network_id': 'XXXXXXXXXXXXXXXXX', 'deployment_name': 'qsdeploy'}
—
Reply to this email directly, view it on GitHub https://github.com/aws-ia/cfn-ps-databricks-unified-data-analytics-platform/pull/15#issuecomment-1885806477, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFRPVWZKTJ6VB7L3Q34NM2LYN4FOXAVCNFSM6AAAAAA6W3DXFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBVHAYDMNBXG4.
You are receiving this because you were mentioned.


Improve usability on mobile

The red stuff takes too much screen space:

It is possible to focus on the text but it takes twiddling , and the big red button is still there.

In contrast, ar5iv displays just the content, eg https://ar5iv.labs.arxiv.org/html/2404.07198v1 .
Can you reduce visual clutter on mobile?

"Twiddling" means zoom and pan with two fingers, and be careful to keep the same position when you scroll.


Undeploy war when shutdown

Hi,
I am using the goal wildfly:run to deploy and start an application, is there a way to undeploy the war application during the shutdown of the server?
I have a huge war application so once it has been deployed the first time is fine, but when I run again the command mvn wildfly:run the server starts along with the application, then a new packed war of the same application is redeployed and started. Everything works correctly but it takes a quite good amount of time.
Any solution is appreciated ;-)

The run goal is meant for development and managing a server. I don't see a reason to skip a deployment operation from this goal when it's run. If you don't want it redeployed it's best to not use the run goal and deploy it once to a running instance of WildFly.

May be I can explain my scenario during the development:

I do some modification to code I want to test
I run wildfly:run so the war is generated and deployed
I stop via Ctrl + c or a button if I am in Intellij Idea
I do some other modifications and I run again wildfly:run
A new war file is generated, the server starts along with the old application, then the new war is deployed.

the problem is that we have a huge war and it takes a while for the deployment phase, so it would be good for instance having the opportunity to undeploy during the shutdown so next time when the server starts again the new artifact can be deployed immediately without waiting too much time.
I hope I have better explained our scenario.

So why not manage and start your own WildFly instance which you leave running.
Then you can use the plugin to redeploy every time you make changes to your application with mvn wildlfy:deploy.
Also, if you're using IntelliJ. You can deploy applications to WildFly from the IDE.

Basically the idea is to replace the Jetty plugin and having something more or less similar, we are in an heterogeneous environment with different backgrounds and I try to minimize the deployment step.
About the plugin I guess you have checked that is for the Ultimate version, so not all of us have that version and we have to keep using Idea.
On my side I use the ultimate and that plugin does the undeploy during the shutdown, for me it is fine but I need to provide something even for other people.
I do not want to explain all the details because I guess it is out of scope.

You could do mvn clean wildfly:run which would give you a clean instance of WildFly. As far as undeploying there's no real good way to do that. Using CTRL+C kills the process which means there's not place where an undeploy could be run.

I agree but I think your command works well when you do not specify an already installed instance of WildFly, in my case I specify a JbossHome so the mvn clean I think does not affect the server.
I understand the point about CTRL+C, may be it is possible to do something at beginning, just say may be because I do not know the WildFly source code, thus by a specific boolean tag I can specify if the already deploy application named ${project.build.fileName} should be undeployed or removed before redeploying it.
It is just an idea for an improvement, I guess other people could get into the same situation, I do not know if it is feasible according to the API you deal with.
In any case thanks a lot for your help, it is really appreciated :wink:


best way to write a bias_add operation?

I don't see bias_add in the documentation and adding higher shape with a 1d tensor doesn't work,
What's the best way to do the operation?

dl.add(a,b) should be sufficient, unless I'm missing something?  dl.add supports broadcasting.
const a = dl.tensor1d([10, 20, 30, 40]);
const b = dl.tensor2d([[5,5,5,5],[5,5,5,5]])
a.add(b).print();


Linebreaks in translation is broken

__("Hello\nWorld", 'test') becomes
msgid "HellonWorld"
instead of
msgid "Hello\n"
"World"

in pot-file

Fixed in 2.0


ob thunk, caching, and worktrees

It would be super nice if all unpacked thunks use the same object store to speed things up. .git/objects/info/alternates and git clone --shared (and --reference and --dissociate) facilitate this. In addition, sometimes it is nice to also share branch/ref state (say one has an experimental branch of some upstream project and wishes to locally try it in two downstream projects). Worktrees are nice for that latter case.
Worktrees are far more user friendly and safer, --shared and friends mean one must GC very carefully. It is a pity there is just two and not a spectrum of options here.

Only if it doesn't have the perf issues that nix's builtins.fetchgit has
On Fri, Oct 26, 2018, 14:54 John Ericson<EMAIL_ADDRESS>wrote:

It would be super nice if all unpacked thunks use the same object store to
speed things up. .git/objects/info/alternates and git clone --shared
https://git-scm.com/docs/git-clone#git-clone---shared (and --reference
and --dissociate) facilitate this. In addition, sometimes it is nice to
also share branch/ref state (say one has an experimental branch of some
upstream project and wishes to locally try it in two downstream projects).
Worktrees are nice for that latter case.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/obsidiansystems/obelisk/issues/281, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABGlYITZUtXUVI8h9eciVZEaPJiW4o8nks5uo1pHgaJpZM4X8yYW
.

@ryantrinkle Yeah I'd want this to be per-remote for that reason.

Perhaps the ideal thing would be if a worktree would work on some subtree of the reference namespace (e.g. refs/foo/heads/my_branch) so as to be completely isolated from the other worktrees.


Move to spring-boot 3.2.0

Is your feature request related to a problem? Please describe.
Have latest spring-boot release.
Describe the solution you'd like
Support 3.2.x
Describe alternatives you've considered
N/A
Additional context
N/A

https://github.com/spring-cloud/spring-cloud-release/milestones


feat: serve assets from plugin - nutmeg support

Pre-Flight checklist

[x] Screenshots and design review for any changes that affect layout or styling

[x] Desktop screenshots
[ ] Mobile width screenshots

[ ] Migrations

[ ] Migration is backwards-compatible with current production code

[ ] Testing

[ ] Code is tested
[x] Changes have been manually tested

What are the relevant tickets?
#13
What's this PR do?

Integrations the context api
Adds the assets within the plugin
adds configurations to serve the assets from the plugin
will add configurations for pants build

How should this be manually tested?

Setup edx-platform on nutmeg release
cherry-pick the commit (A shortened version of the commit will be added once the PR is finalized because the current cherry-pick mentioned in this plugin's readme has all the things that won't be needed after this migration but some will still be there)
Install the plugin

Where should the reviewer start?

Setting up edx-platform on Nutmeg

RELEASE NOTE:

We might need to compile assets(make lms-static) once this plugin is released and installed on the platform. Otherwise we might notice assets issues like we used to face in past.

Any background context you want to provide?
When we added this plugin in the first place, edX won't support serving the assets right from within the plugin. That support was added in the recent Nutmeg release so it's the right time to migrate this plugin and reduce it's cherry-picking to minimum
Screenshots (if appropriate)

This looks good to me :+1:
I ran the pants package and verified that the JS and HTML assets are included.


Document Firefox's table UI controls problem

This is essentially the same commit as https://github.com/ProseMirror/prosemirror-schema-table/commit/57c170f2c39e2e7b75d6d72bf766409cf867ffc4 by @marijnh
The rationale behind this is discussed in ProseMirror/prosemirror#432
This closes #22

Thanks!


More test cases to leshan-integration-tests project

In leshan-integration-tests project, there could be more test cases like below. Is the number of test cases intentionally limited or shall I submit a pull request with more test cases ?

ExecuteTest::can_execute_resource_with_parameters
ObserveTest::cannot_observe_executable
RegistrationTest::registerd_device_timer_expired
and so on

Hi @kiranpradeep,
test cases are always welcome and there is no intentional limit for them (at least not any that I am aware of). Thus, I'd say: keep 'em comin' :-)


Delete ignored key from config.json

Since the exercise implementations are all in the exercises directory
we no longer need to ignore any non-exercise directories in the root
of the track.
See https://github.com/exercism/meta/issues/3 for context.

I've created another PR, #73, which normalizes all of the whitespace in the config.json so
that the change in this PR is minimized and easier to see.
If you merge the other PR first, I'll go ahead and rebase this one onto master.
Sorry about the noise!

Sounds good. I merged #73.


switching the command Faraday::Error::TimeoutError

the command Faraday::Error::TimeoutError doesn't exist anymore, was replaced for this command Faraday::TimeoutError

Would be nice to have this PR merged. 😃

@DWonnink it's already fixed in v0.12

@DWonnink it's already fixed in v0.12

@atipugin thanks for the info. Apparently I didn't update the gem properly. Now it's working without the error. 👍


Algebraic parser type

Define Parser as an enum parameterized by a type to recur through.

Hopefully faster type inference.
Hopefully better errors.
Can vary Recur in Parser<Collection, Tree, Recur> to represent other interesting data (e.g. Parser<Collection, Tree, (Collection.Index, String)> for errors).

Not sure if this is going to be super useful given #85.


Add mutation, subscription for the frontend

Adding of mutation, subscription, and set up for the subscription. Moreover, generated-types.tsx is updated.
Finally, some minor adjustments for server debugging are added.

/rebase

/merge


Included the message part to the body of :delete request

While RFC does not explicitly suggest that, there are services like CloudFlare that utilize the data part of DELETE request as well. It actually does not execute the requests with out it making Chef http_request unsuitable for executing actions like purge requests. I added the message part to the body of :delete.

absolutely can't merge this without fixes

@gorazdzagar thanks for your pull request. We'd be interested in taking this but it needs a fair bit of work around API compatibility and tests. Please feel free to reopen if you'd like.


default value for user_masjid_subscription for user_id column is NULL instead of auth.uid()

this is causing 403 when trying to subscribe to a masjid


the test-suite branch fail in CI, why?

Seems to fail on action 'ubuntu-latest, 3.11' due to a deprecation issue; see link for more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/


IJ-152 User Goals

User can now set short-term and long-term goals on the platform and these goals can belong to any number of goal types (currently set to Aspiration, Hope and Meaning) to better facilitate the 'aim' of the goal.
Users can also mark the goal as achieved by clicking on it which will mark the goal green and trigger a confetti animation.

Really liking this so far Ieuan!
I have a worry that this page will become extremely bloated over time.
Do we have any functionality yet to delete goals which may have changed,or archive old completed goals?

I have a worry that this page will become extremely bloated over time.
Do we have any functionality yet to delete goals which may have changed,or archive old completed goals?

There's no requirement specified for that anywhere so no there isn't functionality to archive or delete goals. If you want new functionality you need to raise a new ticket, these things can't keep getting established at the point a pull-request exists as by that point hours of work have already been put in and by having the goalposts move after those hours are put in they become redundant.
The flow needs to be: establish criterion --> implement --> PR, where PR is about engineering concerns i.e. is there a bug introduced? Is there non-performant/sub-optimal code? Are there minor improvements that can be handled now?

I have a worry that this page will become extremely bloated over time.
Do we have any functionality yet to delete goals which may have changed,or archive old completed goals?

There's no requirement specified for that anywhere so no there isn't functionality to archive or delete goals. If you want new functionality you need to raise a new ticket, these things can't keep getting established at the point a pull-request exists as by that point hours of work have already been put in and by having the goalposts move after those hours are put in they become redundant.
The flow needs to be: establish criterion --> implement --> PR, where PR is about engineering concerns i.e. is there a bug introduced? Is there non-performant/sub-optimal code? Are there minor improvements that can be handled now?

I understand what you're saying about feature suggestions on PRs, its not best-practice or ideal.
In an ideal world, a lot more time and consideration would be given to fleshing out tickets before they are worked on, but also in an ideal world we'd have a designer and a PM or BA to do that! We are a small team and we all have ownership over what we build, from the small details to the bigger picture. We all need to be working collaboratively as architect, engineer, designer, product and project manager.
When we start working on a ticket, we should be considering what the feature is and whether the ticket covers everything that's really needed for it to be a complete feature. If anything else comes to mind as we're working on it we can add it in as we go, or create a new ticket for it to be adding further down the line.
There are going to be times when features get suggested in PRs because they've just been missed when the ticket was being written up, or when while exploring the new work something comes to mind. I don't mind whether this gets tagged on to the end of that particular PR if it feels right to do so or gets spun out into another ticket.
This does not make the hours already put in redundant. It is rare that the work put in will be wasted, I'll always make efforts to ensure that this isn't the case.
So, for this, do you want to write up a new ticket or would your rather add the extra functionality as part of IJ-152?


Filter operator fix

Fix for the filter ratio threshold logic. Documentation stated that samples where less than 10% of reads were kept after filtering were flagged and not assembled. However the code was flagging samples that met this criteria:
(af_total_reads / bf_total_reads) <= params.filter_ratio_threshold
It was discarding samples where the proportion of passed reads was less than 90%. I've changed the filter threshold in the config to 10% to flag only the samples with less than 10% of the reads retained. I've also updated the description in the workflow and the README.
We haven't yet modified the tests affected by this change.
PR checklist

[X] This comment contains a description of changes (with reason).
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
[ ] Make sure your code lints (nf-core lint).
[ ] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
[ ] Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
[X] README.md is updated (including new tool citations and authors/contributors).

This is great, thank you for spotting and fixing the issue @jmattock5.
There is one extra file that needs to be modified -> https://github.com/EBI-Metagenomics/miassembler/blob/main/nextflow_schema.json#L165. This schema json file is used by the nf-schema plugin, which is sort of a argparse for nextflow


Implement Minimum Iteration Duration as a Consensus property

Temp branch for evaluating recent consensus changes

Codecov Report

Merging #1171 (acd6b4e) into master (828364b) will decrease coverage by 0.74%.
The diff coverage is 58.14%.

@@            Coverage Diff             @@
##           master    #1171      +/-   ##
==========================================
- Coverage   50.51%   49.77%   -0.75%
==========================================
  Files         145      150       +5
  Lines        7544     9001    +1457
==========================================
+ Hits         3811     4480     +669
- Misses       3066     3874     +808
+ Partials      667      647      -20

Impacted Files
Coverage Δ

pkg/config/consts.go
0.00% <ø> (ø)

pkg/config/genesis/config.go
0.00% <0.00%> (ø)

pkg/core/candidate/validator.go
64.00% <ø> (+6.85%)
:arrow_up:

pkg/core/chain/legacy.go
0.00% <0.00%> (-28.58%)
:arrow_down:

pkg/core/chain/mock.go
9.09% <ø> (+0.75%)
:arrow_up:

...kg/core/consensus/blockgenerator/candidate/mock.go
0.00% <0.00%> (ø)

pkg/core/consensus/comms.go
0.00% <0.00%> (ø)

pkg/core/consensus/fixtures.go
0.00% <0.00%> (ø)

pkg/core/consensus/header/header.go
24.50% <0.00%> (+2.41%)
:arrow_up:

pkg/core/consensus/publisher.go
0.00% <0.00%> (ø)

... and 176 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5bd8bb...acd6b4e. Read the comment docs.


Video game object can't setDisplaySize

Version

Phaser Version: 3.60.0

Operating system: win11

Browser: chrome/firefox

Description

Video game object does not have frame property, thus it can't get video.frame.realWidth for setDisplaySize method
Example Test Code

From this test code,
Replace line 15 to
const intro = this.add.video(640, 360, 'spaceace').setDisplaySize(200, 200);

And it will show error message
caught TypeError: Cannot read properties of null (reading 'realWidth')
    at Video.set [as displayWidth] (Size.js:73:1)
    at Video.setDisplaySize (Size.js:181:1)
    ...

BTW, how to preload video coss-origin?
Previously, asBlob parameter seems can be used for coss-origin.
Additional Information

LoadURL method has crossOrigin parameter now.

Facing the same issue in Phaser 3.60.0 with the video game object does not have frame property. I am using rex's UI plugin (v1.60.2) as well, and for example if I try to add a video object into a UI sizer, same error Cannot read properties of null (reading 'realWidth') at Video.get [as displayWidth] will be shown.
A temporary solution I found is to assign a random placeholder texture to the video. For example, from the same test code, add an image load to the preloader
this.load.image('placeholder', 'assets/textures/grass.png');

then replace line 15 to
const intro = this.add.video(640, 360, 'spaceace').setTexture('placeholder').setDisplaySize(200, 200);

will result in no error and the size is changed, although the size seems to be dependent to the placeholder's texture size

Thank you for submitting this issue. We have fixed this and the fix has been pushed to the master branch. It will be part of the next release. If you get time to build and test it for yourself we would appreciate that.


Add key binding to pin current editor

It'd be nice to have a way to pin current editor without using the mouse. What's the policy for allocating key bindings or chords?

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: ironyman sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

The existing command workbench.action.keepEditor (Cmd+K => Enter) does this.


Build and publish the kafka chart

The CI should build and publish the kafka chart

This issue has gone stale, we're on Knative now! Please reopen if still relevant.


Modal ASMS step command example not working

The modal ASMS step command example is not running. The execution is interrupted with the following message:
[2024-02-14T18:57:42Z INFO  gmt_dos_clients_arrow::arrow] Arrow logger:
     - data:
       - FaceSheetFigure#1: 500
     - steps #: 1000/0/0
[2024-02-14T18:57:42Z INFO  gmt_dos_clients_arrow::arrow] Arrow data saved to "./model-data_1.parquet"
Error: error in Task implementation

Caused by:
    0: error in Task from Model
    1: failed to join the task
    2: task 8 panicked

The default mount controller corresponds to the FDR design. As the model considered in the example has the mount PDR design, one has to run the example using:
cargo run --release --example modal-step-servo --features s8000d002ze30 --no-default-features

Directions to run the example were placed in the example source code.


add reverse funcion in javascript November Day 1

Nicely written with JS utility methods, will encourage you to use more comments


Doesn't support RECURRENCE-ID or EXDATE

The basic RRULE command is implemented, but not the companion RECURRENCE-ID or EXDATE commands:
https://nylas.com/blog/rrules/
If you have an ics file that looks like this:
BEGIN:VEVENT
UID:0000001
RRULE:FREQ=DAILY;COUNT=5
SUMMARY:Treasure Hunting
DTSTART;TZID=America/Los_Angeles:20150706T120000
DTEND;TZID=America/Los_Angeles:20150706T130000
END:VEVENT
BEGIN:VEVENT
UID:0000001
SUMMARY:Treasure Hunting
LOCATION:The other island
DTSTART;TZID=America/Los_Angeles:20150707T120000
DTEND;TZID=America/Los_Angeles:20150707T130000
RECURRENCE-ID;TZID=America/Los_Angeles:20150707T120000
END:VEVENT
Right now, ical.js will silently replace the recurring event with the single instance.  This happens where the code does this:
if (curr.uid)
par[curr.uid] = curr
This should probably look something more like this:
if (curr.uid)
{
if (par[curr.uid] === undefined)
{
par[curr.uid] = curr
}
else
{
// TODO: Add support for RECURRENCE-ID
}
}
Neither the old behaviour or this one is correct, but if you added error-handling code at the TODO area, you could warn users when the calendar is being parsed incorrectly.

It seems this should have been resolved by #64. Can this issue be closed?


Feat/menu redo

Re-working how the menu works

Pull Request Test Coverage Report for Build 315

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 61.217%

Totals

Change from base Build 301:
0.0%

Covered Lines:
115

Relevant Lines:
161

💛  - Coveralls


fix(connector): don't skip message without key and payload

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
CDC connector could emit heartbeat message to the Source, for example when we create a shared cdc source.
The Source can use heartbeat to update or init its internal offset.
related:
https://github.com/risingwavelabs/risingwave/pull/14524/files#diff-d20a701c6d209a35e84545b11ccd13ab2f332a68aa175eb4bf73edf67184e8bcL644-L648
Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

The pr may introduce a behavior that yielding an all-empty row, including the PK column. @hzxa21 please help confirm the storage can ignore the row as expected.

This quick only work for share cdc source. It fails for dedicated source, because payload is empty. Any idea to transfer previous implementation? @tabVersion
2024-03-14T06:17:40.878162627Z  INFO risingwave_connector_node: Searching for WAL resume position thread="debezium-postgresconnector-RW_CDC_2-change-event-source-coordinator" class="io.debezium.connector.postgresql.PostgresStreamingChangeEventSource"
thread 'rw-streaming' panicked at src/connector/src/parser/unified/debezium.rs:93:9:
assertion failed: key_accessor.is_some() || value_accessor.is_some()
stack backtrace:
   0: rust_begin_unwind
             at /rustc/e4c626dd9a17a23270bf8e7158e59cf2b9c04840/library/std/src/panicking.rs:645:5
   1: core::panicking::panic_fmt
             at /rustc/e4c626dd9a17a23270bf8e7158e59cf2b9c04840/library/core/src/panicking.rs:72:14
   2: core::panicking::panic
             at /rustc/e4c626dd9a17a23270bf8e7158e59cf2b9c04840/library/core/src/panicking.rs:144:5
   3: risingwave_connector::parser::unified::debezium::DebeziumChangeEvent<A>::new
             at ./src/connector/src/parser/unified/debezium.rs:93:9
   4: {async_fn#0}
             at ./src/connector/src/parser/debezium/debezium_parser.rs:136:22
   5: {async_fn#0}
             at ./src/connector/src/parser/debezium/debezium_parser.rs:184:48
   6: {coroutine#0}<risingwave_connector::parser::debezium::debezium_parser::DebeziumParser>
             at ./src/connector/src/parser/mod.rs:687:18


[ Document ] Add RELEASE.md

Add release.md to specify release policy.
Self evaluation:

Build test:	 [X]Passed [ ]Failed [ ]Skipped
Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: jijoong.moon<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.4.20191203. Thank you for submitting PR #970. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://nnsuite.mooo.com/nntrainer/ci/repo-workers/pr-checker/970-202103031429400.42035698890686-2aab0ebe849f2137effd969c6b0361a0122ea721/report/misspelling_result.txt.

:octocat: cibot: @jijoongmoon, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnsuite.mooo.com/nntrainer/ci/repo-workers/pr-checker/970-202103031429400.42035698890686-2aab0ebe849f2137effd969c6b0361a0122ea721/.

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://nnsuite.mooo.com/nntrainer/ci/repo-workers/pr-checker/970-202103031443310.84109997749329-9fada474a4ccf39ee268741e530300c029ce5b7c/report/misspelling_result.txt.


Slice Support

When trying to Insert a struct containing a slice, I get this error:
sql: converting argument #1's type: unsupported type []float64, a slice

The struct field is []float64 and the type of the column in Postgres is real[].
Does gorp support slices and this error is particular to my program or is this yet unimplemented?

Any update on this? Am I missing something. Is there a way to register a custom mapper to convert to value string, otherwise? Or any other workaround?

We'll have to pick this up in v2-phase3 (see #270). @siliconsenthil

I am new to Go and programming in general but could we, instead of defining an array column type, create a related table and include a reference key from the parent table. For example:
`Parent struct {
Id int
Name String
Children []Child
}
Child struct {
Id int
Name String
}
dbMap.AddTableWithName(Parent{}, "parent").SetKeys(true, "Id")
`
I dont know anything about the bolts underpinning gorp, but using reflection to retreive the field names of the Parent structure, and upon finding a slice type just create a new table called ChildofParent with a column that has the Id of Parent. Whenever select parent is called gorp knows that the []child is fulfilled from the table ChildofParent.
Or, optionally, because that would require each Child entry to be directly related to one Parent, including a matching parameter that pulls all children that have a value that matches in a particular column and fill the internal slice with that.
Not sure how gorp would implement that idiomatically, just spit balling. Not very hard to write a helper to do that for me and just SetTransient(true) on the parent structure.
schmorrison

@schmorrison That's a different issue.  This issue is specifically about slices of database-supported values, which are generally accepted as SQL arrays.
The issue of supporting first-class joins is something I've implemented in a fork, but the code is very complex, and I don't trust directly merging it in.  I need to find some time to really sit down and work on it to make sure it's fully tested.


Markdown HMR sometimes does not work

[x] I have read the troubleshooting section before opening an issue.
[x] I have tried upgrading iles and vite.

Description 📖
When the Markdown <slot> is after some kind (I'm not sure which) of island, its HMR does not work.
Reproduction 🐞
https://github.com/ouuan/iles-issue-232-reproduction
Run pnpm dev and edit src/pages/index.mdx, only the random number changes, and the Markdown content does not change.
If the island and the <slot> are in a reversed order, or client:load is removed, or the prop is a fixed number, the HMR will work.
The real issue is that the HMR in my blog does not work after https://github.com/ouuan/iles-blog/commit/863909c49d4b0948ddc894ade4e2bdb2019fd74d, and I managed to get the above minimal reproduction.

Thanks for the report, I'll try to look into it when I have some time.


Genome table bug

Woah, each time you download a genome table the fields change!
The first image is the list of  representative and reference genomes.  It starts with sequencing depth:

The second image is representative genomes only and starts with plasmids

This is a huge pain.

This is applicable to ALL table downloads. We need properly arrange all columns in ALL table downloads throughout the site. Without that, the downloaded files look like garbage!!!

There was code in here to do this already, but we were encountering a bug where that code was being skipped in the case of a streamed download.  That has been fixed and will be pushed to alpha soon.  However, I need some help for the rest of this ticket.
There is a middleware function that defines what the default fields (and order) are for both genome and genome_feature data types.  I need the same list for the rest of the data types.  Keep in mind that if a query specifically includes a field list  ( select() in rql or &fl= in solr ), that will be used for both the field selection and order of data in the download files.  However, the cases we have been talking about are the default case where no specific field list is given to the api.
The definitions can be seen here: https://github.com/PATRIC3/p3_api/blob/master/middleware/ExtractCustomFields.js#L14-L37
Please add additional data types/fieldSelections to this function or give me a list for the other data types and then I can add them.

@hyoo is going to update the field definitions.

we have added column definitions for

genome
feature
sequence
transcriptomics experiments
transcriptomics comparisons
specialty genes

and also added client level grid download for all three sub-tabs in pathways.

Checked downloads from all the pages listed above and they now seems well formatted and as expected.


Better Colour for deprecated features as well as spelling mistake fix

Coral instead of yellow for "OK" deprecation levels, which improves contrast on the new white background.
Spelling mistake is self explanatory.

Ive made a complete mess of the repo with all these commits lol, but it should be good now.
I've added a clear button as seen here:

As well as fixing the regex issues.

Yeah, you were right about compileExcludePattern. For any people having issues with it, this is the syntax:
. for package names
.* to match a package's contents
.** to recursively match a package's contents
Examples
com.backdoored.mixin.**
club.minnced.discord.rpc.**
com.sun.jna.**
com.sun.jna.win32.**
com.sun.jna.ptr.**
javassist.**
net.jodah.typetools.**
org.**


?actionBarTheme for Toolbar seems not correct before change the theme

In the demo-main module, we can see that the DrawerActivity includes a Toolbar.
But when first run it (Don't change theme), the toolbar's text color seems not correct. Here are the screenshots:

It's okay, MainActivity don't use Toolbar.

The title text color of Toolbar and other menu icons color is black rather than white.
Devices:

Genymotion Android 8.0
Xiaomi mix2s MIUI 10 Android 9.0

Have same problem.
Launch demo-simple-java. Go to settings. Choose primary color - yellow. Go Back.
And here we go:

How i can fix this??


Animations: Add some animation getter helpers

I need them for my PoC!

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/14344/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14344/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14344/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/14344/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14344/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14344/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14344/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/14344/merge#BCU1XR#0


black screen playing stream on https://b.siobud.com/(key here)

Sent video from obs, it didn't show any errors, showed connected and bitrate and everything looked good. I can record to file and it works. What is a good next step to figure out what went wrong? Run broadcast-box myself?

Hey @ian-kelling
Are you able to broadcast from your browser? https://b.siobud.com/publish/(key here)
What browser are you using? Do you know if H264 support is enabled/working? Might be worth trying temporarily a stock Google Chrome/FireFox

Opening chrome://webrtc-internals is your best debugging tool. It shows how many video packets are flowing in etc...

I am going to resolve @ian-kelling if you are still having issues I would love to help!
thanks

I'm encountering the same issue, both with OBS and publishing via the site. Interestingly, OBS2Browser also stopped working...
I'm using Arch Linux, latest Firefox (also tested Chrome), latest broadcast-box docker container
docker run -e NETWORK_TEST_ON_START=false -e UDP_MUX_PORT=8080 -e NAT_1_TO_1_IP=<IP_ADDRESS> -p 8080:8080 -p 8080:8080/udp --name broadcast-box --rm seaduboi/broadcast-box
about:webrtc-internals in Chrome shows that packets are received, yet the media player is completely empty.
I have no idea what changed, everything worked before...
I commented here because this seems like the same issue to me. If needed, I can create a new one


added fire badges

420 nice

420 nice

cool

Why do you do every file individually, this pains me.

Why do you do every file individually, this pains me.

wdym

There is no need to make a commit for each file, just use a couple commits

There is no need to make a commit for each file, just use a couple commits

wdym its not each file

There is no need to make a commit for each file, just use a couple commits

wdym its not each file

Okay but it is still a lot of commits

There is no need to make a commit for each file, just use a couple commits

wdym its not each file

Okay but it is still a lot of commits

and where is the problem?

There is no need to make a commit for each file, just use a couple commits

wdym its not each file

Okay but it is still a lot of commits

that looks cooler :D

There is no need to make a commit for each file, just use a couple commits

wdym its not each file

Okay but it is still a lot of commits

and where is the problem?

I said it pains me, I never said there is a problem

There is no need to make a commit for each file, just use a couple commits

wdym its not each file

Okay but it is still a lot of commits

and where is the problem?

I said it pains me, I never said there is a problem

Okay it pains me that you not give me my rainbow name. Sadge


Mcloud logger dest

What does this PR do?
Logs metrics to MCLI

TODO:

mock mapi and unit tests
glob filter

What issue(s) does this change relate to?
CO-1985

Nice. All my feedback was addressed. LGTM

Oh wait. Tests?


Add Fault Injections to the policies page

I've added Fault Injections to the Policies page and linked to where the page will eventually be in the docs once the PR is merged.

@bloqhead this should be against next branch


Estimation of second-order statistics conditional law g_{ij}(t) in tick

Hi,
How to use functions in tick to estimate the second-order statistics, i.e, conditional law g_{ij}(t)? It seems that tick.hawkes.HawkesConditionalLaw can only output the estimation of the kernels, i.e., \phi_{ij}(t).
Thanks!

Hi,
Sadly, this code was adapted from another codebase and I don't remember much about it. But maybe you could find what you are looking for in the private attributes or methods of the class, such as hawkes._G function ?
def _G(self, i, j, l, t):
    """Returns the value of a claw at a point
    Used to fill V and M with 'gauss' method
    """
    if t < 0:
        warnings.warn("G(): should not be called for t < 0")
    index = self._ijl2index[i][j][l]
    return HawkesConditionalLaw._lin0(self._int_claw[index], t)

Hi,
Sadly, this code was adapted from another codebase and I don't remember much about it. But maybe you could find what you are looking for in the private attributes or methods of the class, such as hawkes._G function ?
def _G(self, i, j, l, t):
    """Returns the value of a claw at a point
    Used to fill V and M with 'gauss' method
    """
    if t < 0:
        warnings.warn("G(): should not be called for t < 0")
    index = self._ijl2index[i][j][l]
    return HawkesConditionalLaw._lin0(self._int_claw[index], t)

Thanks for your reply!


Steal focus when interacting with the slider

A div can't get focus, at least in Chrome, but it makes sense for e.g. an input box to lose focus when a user starts to interact with the slider.
This is necessary for my app, where the slider and the text box tightly interact, and is also consistent with jQueryUI Slider.

Seems to be a good idea

Thanks!


Complete a UX study of the Preview 1 SDK libraries

[x] Document Preview 1 champion scenarios
[x] Document hypotheses for Preview 1 APIs
[x] Construct sample applications to test champion scenarios and hypotheses
[x] Write script(s) for UX study
[x] Complete UX study

UX study results will be incorporated in a future preview.

This done. :)


Improve handler() reference docs

Description (required)
This PR improves the defineAction() reference docs to better describe the signature of the handler() option and mention the context argument.
Also took the liberty of removing the extra <Since> components on handler and input sections — felt excessive to add those when they are properties of defineAction(), which means they were added at the same time.

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

en
reference/api-reference.mdx
Source changed, localizations will be marked as outdated.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Thanks @ArmandPhilippot — nitpicking and quibbling are both correct! (You could even do both simultaneously 😁)


channel disappears although tx has > 100 confirmations, possibly because peer disconnected before tx was confirmed

See https://github.com/lightningnetwork/lnd/issues/6717 for more info.
Opening issue here because it seems lndmanage openchannels sent funds to the address even though lnd logged unable to open channel to NodeKey...

Sure, here it is , didn't know lndmanage had its own logs. The lnd logs are in the linked lnd issue.

[2022-07-09 16:24:26 DEBUG] Using selector: EpollSelector
[2022-07-09 16:24:26 DEBUG] Node interface starting.
[2022-07-09 16:24:27 DEBUG] Connecting async rpcs.
[2022-07-09 16:24:27 DEBUG] Using AsyncIOEngine.POLLER as I/O engine
[2022-07-09 16:24:27 INFO] Cached graph is too old. Fetching new one.
[2022-07-09 16:24:46 DEBUG] Network.set_graph_and_edges 18.2389 s
[2022-07-09 16:24:51 DEBUG] Network.load_graph 23.8341 s
[2022-07-09 16:24:51 DEBUG] Network.load_liquidity_hints 0.0004 s
[2022-07-09 16:24:54 INFO] >>> Checking node pubkeys and address information.
[2022-07-09 16:24:54 INFO] >>> Connecting to channel peer candidates.
[2022-07-09 16:24:54 INFO]     trying to connect to 021cc722c97eaaeb7649e2a88301b2b0826060f3ebbd008bcd2d23ba2798dcc850@zul6k2zgi5tprvrk3kx3qo6lfch5ohir3ogg2henzvk3zq3znqkossyd.onion:9735
[2022-07-09 16:24:54 INFO]     > already connected
[2022-07-09 16:24:54 INFO] >>> Available UTXOs:
[2022-07-09 16:24:54 DEBUG]     d26aa7514db96f5ef90413d8cdadf11c1811a5fc7e0904d401197f33a24a7d12:0 9872936 sat
[2022-07-09 16:24:54 DEBUG]     Transaction size calculation for 1 (p2wkh) + 0 (np2wkh) inputs, 1channels, change False: 153 vbytes
[2022-07-09 16:24:54 INFO] >>> Used UTXOs:
[2022-07-09 16:24:54 INFO]     d26aa7514db96f5ef90413d8cdadf11c1811a5fc7e0904d401197f33a24a7d12:0 9872936 sat
[2022-07-09 16:24:54 INFO] >>> Channels will be public.
[2022-07-09 16:24:54 INFO]     Channel capacities: [9870476] sat (9870476 sat total).
[2022-07-09 16:24:54 INFO]     Fees: 2460 sat (16 sat/vbyte).
[2022-07-09 16:24:54 INFO]     Change: 0 sat.
[2022-07-09 16:24:54 INFO] >>> Asking peers for channel opening.
[2022-07-09 16:28:56 DEBUG]    > peer 021cc722c9...: got address: bc1q6chtu402x9yhj4upkussry4vy5vxhcu8rhncsarmdg0cajh3ndvsw57kvr
[2022-07-09 16:28:56 INFO] >>> Funding PSBT.
[2022-07-09 16:28:56 DEBUG]     given inputs: [UTXO(txid='d26aa7514db96f5ef90413d8cdadf11c1811a5fc7e0904d401197f33a24a7d12', output_index=0, amount_sat=9872936, transaction_type=<AddressType.WITNESS_PUBKEY_HASH
: 0>)]
[2022-07-09 16:28:56 DEBUG]     inputs (psbt): 1
[2022-07-09 16:28:56 DEBUG]     outputs (psbt): 1
[2022-07-09 16:28:56 DEBUG]     amounts (psbt): [9870476]
[2022-07-09 16:28:56 INFO] >>> WARNING: this is a relatively new feature, so please check the generated PSBT by the following command:
[2022-07-09 16:28:56 INFO] bitcoin-cli decodepsbt "cHNidP8BAF4CAAAAARJ9SqIzfxkB1AQJfvylERgc8a3N2BME+V5vuU1Rp2rSAAAAAAAAAAAAAYyclgAAAAAAIgAg1i6+VeoxSXlXgbchAZKsJRhr44cd54h0e2ofjsrxm1kAAAAAAAEA7AIAAAAAAQG8tvNRy39
zyQfwWFXaPcLCLWupt6xjVIfd8B59sxYCAgEAAAAAsQQAAAEoppYAAAAAABYAFLeKaqyyQc6J2uqITJW2+dU/4eVOA0cwRAIgeuLZ1nF0u1Ou5RqOALpX7lHjKAV6xsRzH90g4Clp9sQCIBMRT5mL5cnNm3scNMyxFexzEsj2PNYUCuBYrGoraY0bAQBNYyEDygsVzi/1jOyGyHc26
kETAJGxTNE7y2snUt29NP+Jj7tnArEEsnUhA0Pcgdn7Vb2P1dXf0m/xzxt+cqWBhksmgYROa9JcDfAnaKziVgsAAQEfKKaWAAAAAAAWABS3imqsskHOidrqiEyVtvnVP+HlTgEDBAEAAAAiBgMPR4Flxt2YfbazgdYDujepOCSygJJJ5BpFQrg7kNRjQxgAAAAAVAAAgAAAAIAAAAC
AAAAAAAwKAAAAAA=="
[2022-07-09 16:28:56 INFO] >>> You have 8 minutes from now to decide.

[2022-07-09 16:28:56 INFO]
>>> Do you want to open the channel(s) (y/n)?
[2022-07-09 16:31:01 INFO] >>> Verifying PSBT.
[2022-07-09 16:31:02 INFO] >>> Signing PSBT.
[2022-07-09 16:31:02 INFO]     Signed transaction:
<PHONE_NUMBER>0101127d4aa2337f1901d404097efca511181cf1adcdd81304f95e6fb94d51a76ad2000000000000000000018c9c960000000000220020d62ebe55ea3149795781b7210192ac25186be3871de788747b6a1f8ecaf19b590247304402204108c15be67552ad6acb12651c472e3e03c9c839fad0e348d438b072e29df6bb022031755c5509b31b99bf515df02e198804ecbe6f2b1fae004e1ddb1383c2de44080121030f478165c6dd987db6b381d603ba37a93824b2809249e41a4542b83b90d4634300000000
[2022-07-09 16:31:02 INFO]     Signed psbt:
    cHNidP8BAF4CAAAAARJ9SqIzfxkB1AQJfvylERgc8a3N2BME+V5vuU1Rp2rSAAAAAAAAAAAAAYyclgAAAAAAIgAg1i6+VeoxSXlXgbchAZKsJRhr44cd54h0e2ofjsrxm1kAAAAAAAEA7AIAAAAAAQG8tvNRy39zyQfwWFXaPcLCLWupt6xjVIfd8B59sxYCAgEAAAAAsQQAAAEoppYAAAAAABYAFLeKaqyyQc6J2uqITJW2+dU/4eVOA0cwRAIgeuLZ1nF0u1Ou5RqOALpX7lHjKAV6xsRzH90g4Clp9sQCIBMRT5mL5cnNm3scNMyxFexzEsj2PNYUCuBYrGoraY0bAQBNYyEDygsVzi/1jOyGyHc26kETAJGxTNE7y2snUt29NP+Jj7tnArEEsnUhA0Pcgdn7Vb2P1dXf0m/xzxt+cqWBhksmgYROa9JcDfAnaKziVgsAAQEfKKaWAAAAAAAWABS3imqsskHOidrqiEyVtvnVP+HlTgEIawJHMEQCIEEIwVvmdVKtassSZRxHLj4Dycg5+tDjSNQ4sHLinfa7AiAxdVxVCbMbmb9RXfAuGYgE7L5vKx+uAE4d2xODwt5ECAEhAw9HgWXG3Zh9trOB1gO6N6k4JLKAkknkGkVCuDuQ1GNDAAA=
[2022-07-09 16:31:02 INFO]     Final transaction size: 203 bytes
[2022-07-09 16:31:02 INFO] >>> Publishing transaction.
[2022-07-09 16:31:03 DEBUG] Disconnecting rpcs.
[2022-07-09 16:24:27 DEBUG] Using AsyncIOEngine.POLLER as I/O engine
[2022-07-09 16:24:27 INFO] Cached graph is too old. Fetching new one.
[2022-07-09 16:24:46 DEBUG] Network.set_graph_and_edges 18.2389 s
[2022-07-09 16:24:51 DEBUG] Network.load_graph 23.8341 s
[2022-07-09 16:24:51 DEBUG] Network.load_liquidity_hints 0.0004 s
[2022-07-09 16:24:54 INFO] >>> Checking node pubkeys and address information.
[2022-07-09 16:24:54 INFO] >>> Connecting to channel peer candidates.
[2022-07-09 16:24:54 INFO]     trying to connect to 021cc722c97eaaeb7649e2a88301b2b0826060f3ebbd008bcd2d23ba2798dcc850@zul6k2zgi5tprvrk3kx3qo6lfch5ohir3ogg2henzvk3zq3znqkossyd.onion:9735
[2022-07-09 16:24:54 INFO]     > already connected
[2022-07-09 16:24:54 INFO] >>> Available UTXOs:
[2022-07-09 16:24:54 DEBUG]     d26aa7514db96f5ef90413d8cdadf11c1811a5fc7e0904d401197f33a24a7d12:0 9872936 sat
[2022-07-09 16:24:54 DEBUG]     Transaction size calculation for 1 (p2wkh) + 0 (np2wkh) inputs, 1channels, change False: 153 vbytes
[2022-07-09 16:24:54 INFO] >>> Used UTXOs:
[2022-07-09 16:24:54 INFO]     d26aa7514db96f5ef90413d8cdadf11c1811a5fc7e0904d401197f33a24a7d12:0 9872936 sat
[2022-07-09 16:24:54 INFO] >>> Channels will be public.
[2022-07-09 16:24:54 INFO]     Channel capacities: [9870476] sat (9870476 sat total).
[2022-07-09 16:24:54 INFO]     Fees: 2460 sat (16 sat/vbyte).
[2022-07-09 16:24:54 INFO]     Change: 0 sat.
[2022-07-09 16:24:54 INFO] >>> Asking peers for channel opening.
[2022-07-09 16:28:56 DEBUG]    > peer 021cc722c9...: got address: bc1q6chtu402x9yhj4upkussry4vy5vxhcu8rhncsarmdg0cajh3ndvsw57kvr
[2022-07-09 16:28:56 INFO] >>> Funding PSBT.
[2022-07-09 16:28:56 DEBUG]     given inputs: [UTXO(txid='d26aa7514db96f5ef90413d8cdadf11c1811a5fc7e0904d401197f33a24a7d12', output_index=0, amount_sat=9872936, transaction_type=<AddressType.WITNESS_PUBKEY_HASH
: 0>)]
[2022-07-09 16:28:56 DEBUG]     inputs (psbt): 1
[2022-07-09 16:28:56 DEBUG]     outputs (psbt): 1
[2022-07-09 16:28:56 DEBUG]     amounts (psbt): [9870476]
[2022-07-09 16:28:56 INFO] >>> WARNING: this is a relatively new feature, so please check the generated PSBT by the following command:
[2022-07-09 16:28:56 INFO] bitcoin-cli decodepsbt "cHNidP8BAF4CAAAAARJ9SqIzfxkB1AQJfvylERgc8a3N2BME+V5vuU1Rp2rSAAAAAAAAAAAAAYyclgAAAAAAIgAg1i6+VeoxSXlXgbchAZKsJRhr44cd54h0e2ofjsrxm1kAAAAAAAEA7AIAAAAAAQG8tvNRy39
zyQfwWFXaPcLCLWupt6xjVIfd8B59sxYCAgEAAAAAsQQAAAEoppYAAAAAABYAFLeKaqyyQc6J2uqITJW2+dU/4eVOA0cwRAIgeuLZ1nF0u1Ou5RqOALpX7lHjKAV6xsRzH90g4Clp9sQCIBMRT5mL5cnNm3scNMyxFexzEsj2PNYUCuBYrGoraY0bAQBNYyEDygsVzi/1jOyGyHc26
kETAJGxTNE7y2snUt29NP+Jj7tnArEEsnUhA0Pcgdn7Vb2P1dXf0m/xzxt+cqWBhksmgYROa9JcDfAnaKziVgsAAQEfKKaWAAAAAAAWABS3imqsskHOidrqiEyVtvnVP+HlTgEDBAEAAAAiBgMPR4Flxt2YfbazgdYDujepOCSygJJJ5BpFQrg7kNRjQxgAAAAAVAAAgAAAAIAAAAC
AAAAAAAwKAAAAAA=="
[2022-07-09 16:28:56 INFO] >>> You have 8 minutes from now to decide.

[2022-07-09 16:28:56 INFO]
>>> Do you want to open the channel(s) (y/n)?
[2022-07-09 16:31:01 INFO] >>> Verifying PSBT.
[2022-07-09 16:31:02 INFO] >>> Signing PSBT.
[2022-07-09 16:31:02 INFO]     Signed transaction:
<PHONE_NUMBER>0101127d4aa2337f1901d404097efca511181cf1adcdd81304f95e6fb94d51a76ad2000000000000000000018c9c960000000000220020d62ebe55ea3149795781b7210192ac25186be3871de788747b6a1f8ecaf19b590247304402204108c15be67552ad6acb12651c472e3e03c9c839fad0e348d438b072e29df6bb022031755c5509b31b99bf515df02e198804ecbe6f2b1fae004e1ddb1383c2de44080121030f478165c6dd987db6b381d603ba37a93824b2809249e41a4542b83b90d4634300000000
[2022-07-09 16:31:02 INFO]     Signed psbt:
    cHNidP8BAF4CAAAAARJ9SqIzfxkB1AQJfvylERgc8a3N2BME+V5vuU1Rp2rSAAAAAAAAAAAAAYyclgAAAAAAIgAg1i6+VeoxSXlXgbchAZKsJRhr44cd54h0e2ofjsrxm1kAAAAAAAEA7AIAAAAAAQG8tvNRy39zyQfwWFXaPcLCLWupt6xjVIfd8B59sxYCAgEAAAAAsQQAAAEoppYAAAAAABYAFLeKaqyyQc6J2uqITJW2+dU/4eVOA0cwRAIgeuLZ1nF0u1Ou5RqOALpX7lHjKAV6xsRzH90g4Clp9sQCIBMRT5mL5cnNm3scNMyxFexzEsj2PNYUCuBYrGoraY0bAQBNYyEDygsVzi/1jOyGyHc26kETAJGxTNE7y2snUt29NP+Jj7tnArEEsnUhA0Pcgdn7Vb2P1dXf0m/xzxt+cqWBhksmgYROa9JcDfAnaKziVgsAAQEfKKaWAAAAAAAWABS3imqsskHOidrqiEyVtvnVP+HlTgEIawJHMEQCIEEIwVvmdVKtassSZRxHLj4Dycg5+tDjSNQ4sHLinfa7AiAxdVxVCbMbmb9RXfAuGYgE7L5vKx+uAE4d2xODwt5ECAEhAw9HgWXG3Zh9trOB1gO6N6k4JLKAkknkGkVCuDuQ1GNDAAA=
[2022-07-09 16:31:02 INFO]     Final transaction size: 203 bytes
[2022-07-09 16:31:02 INFO] >>> Publishing transaction.
[2022-07-09 16:31:03 DEBUG] Disconnecting rpcs.

But now it seems it is lnd issue, note that lnd fails to open the channel at 16:38:28, when lndmanage already ended.  (Or perhaps lndmanage should wait for some acknowledgement from lnd, but this doesn't sound workable, what is lndmanage supposed to do?)

Thank you, the issue seems to be that the peer disconnected during the funding flow and that was not caught. I am replacing the internal channel funding of lndmanage with a wrapper around the batchopen api of lnd in #137.

Fixed by #137.


Error when using recursive (-r) option

I was trying to use the recursive option to upload a directory to Bee and I get an error (see below). Interestingly if I am not using the recursive option the upload of a directory is still successful.
~/Projects/swarm-cli (feat/identity*) % node dist/index.js upload -r ../swarm-cli/dist
index.js upload <path>

- Upload file to Swarm

Positionals:
  path  Path of the file (even directory)                             [required]

Options:
      --help                Show help                                  [boolean]
      --version             Show version number                        [boolean]
      --bee-api-url         URL of the Bee-client API
                                     [string] [default: "http://localhost:1633"]
      --config-folder       Path of the configuration files that the CLI uses
                                                                        [string]
      --pin                 Persist the uploaded data on the gateway node
                                                                       [boolean]
  -r, --recursive           Upload directory            [string] [default: true]
      --tag-polling-time    Waiting time in ms between tag pollings
                                                         [string] [default: 500]
      --tag-polling-trials  After the given trials the tag polling will stop
                                                          [string] [default: 15]
      --index-document      Default retrieval file on bzz request without
                            provided filepath   [string] [default: "index.html"]
      --error-document      Default error file on bzz request without with wrong
                            filepath                                    [string]

Not enough non-option arguments: got 0, need at least 1

as the help print says upload <path> has to be the format of the command. If you want to provide options it has to be after this formula.
In case of parent options, you can provide even before the command e.g.  swarm-cli --bee-api-url http://localhost:11633 upload ../swarm-cli/dist  -r or also after swarm-cli upload ../swarm-cli/dist  -r --bee-api-url http://localhost:11633

Reopening because the help says nothing about where the options are supposed to be.
It is highly unusual for CLI tools that the options can come only after the arguments. Usually it's either before the arguments (for example see node, curl, tsc, all unix tools, or for a similar multi-level command line tool docker) or the the position of the options doesn't matter (much less common, for example npm)


Add Visual studio code's .vscode/ folder.

Reasons for making this change:
Add Visual Studio Code's .vscode/ folder, that's useless for many people who don't use vscode.
Links to documentation supporting these rule changes:
TODO
If this is a new template:

Link to application or project’s homepage: TODO

Thanks, but these rules are covered by existing templates, and I recommend merging them into your project-specific templates:

Global/VisualStudioCode.gitignore
Global/macOS.gitignore

Thanks!
On Sun, Oct 28, 2018 at 5:55 PM Brendan Forster<EMAIL_ADDRESS>wrote:

Closed #2858 https://github.com/github/gitignore/pull/2858.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/github/gitignore/pull/2858#event-1930737235, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AH5awvTvtHaS5ZQlnSeydI3SLoqqPSlxks5upZskgaJpZM4X927M
.

--
[image: photo]
Yaakov Azat
Biryol Inc. & KazNU
+7<PHONE_NUMBER> <+7%207081962952> | +86<PHONE_NUMBER>4 <+86%2013240156994> |
<EMAIL_ADDRESS>http://yaakovazat.com
Al-Farabi Kazakh National University
http://facebook.com/yaakovazat http://us.linkedin.com/in/yaakovazat
http://twitter.com/yaakovazat http://github.com/yaakovazat
http://soundcloud.com/yaakovazat
"Only as high as I reach can I grow, only as far as I seek can I go, only
as deep as I look can I see, only as much as I dream can I be." - Karen Ravn


how to generate vocab file that BERT model was trained on?

I was weird how to generate the vocab file when specified --vocab_file to create_pretraining_data.py?
I noticed the released BERT model indeed include the vocab file? so, how's you guy generate it via for instance, enlish Wikipedia dump file? as I am going to do the pre-training from scratch.  Appreciate your help!
Thanks,
Allen Zhang

We couldn't include that code, see this section of the README for alternatives.

@allenzhang010 have you work out the solution on this?

you can use this to create your vocabulary
https://github.com/kwonmha/bert-vocab-builder


Add more logging for ldap login, refactor some authentication code

Trying to debug and resolve the China Ldap login issue.

Coverage remained the same at 0.0% when pulling e2eb2f198506bab54233698aacb138e7c376b43a on alyiwang:linkedin into bcb8f1528e8560073bccb9379fcefa03967dfbad on linkedin:linkedin.


Add support for manifests in Arweave File Data Sources

Context:
What are Arweave manifests?
Bundlr docs
This may be supported but would be valuable to verify

https://github.com/graphprotocol/graph-node/pull/4865

Updated docs https://github.com/graphprotocol/docs/pull/514


feat: Refactor issue template. ✨

Closes
Closes #1324
Description
I have created an issue template in  **.github/ISSUE_Templeate**
Screenshots

Note to reviewers

Checklist:

[x] I have linked the PR to the correct issue.
[x] I have read the Contribution Guidelines
[x] I have built and tested the changes, and they do not break or show any errors.

Hey @Vaishnavi-Patil2211  Please review the Pr and merge it ✨


Add BCP-003-02 as prerequisite

I think BCP-003-02 should also be mentioned in section 2.0 - it adds additional information and limitations on IS-10 that the implementor will need to be aware of

Added BCP-003-02 into the prerequisite section


Feat contact

@brandonetter The only thing that I'm stuck on here is getting the radius on the rectangles to the right of the button on the mobile contact card.

@austinmargarone OH I see!

            <Image
              className="rounded-br-3xl"
              src="/Rectangle1.svg"
              width={50}
              height={154}
              alt="Rectangle"
            />

            <Image
              className="rounded-br-3xl"
              src="/Rectangle2.svg"
              width={50}
              height={154}
              alt="Rectangle"
            />

You can use rounded on specific corners with rounded-br- and the like.
See reference here:
https://tailwindcss.com/docs/border-radius

@brandonetter It's not applying any effect on the image.

@austinmargarone the issue with the code you just tried was that you put the border radius on the div not the image like I did

@brandonetter Good to know! That would have been way easier.

Please integrate my suggestion of not using duplicate images overlaying each other to accomplish this. Use one image and just adjust the opacity. @austinmargarone

@brandonetter Implemented. I'm having two issues though:
Mobile the bottom right does not look like the design
Desktop looks to be skewed down a bit from the top

I'm merging this so I can fix all the conflicts and get a PR ready for my next branch. Please still take a look at the following when you get a chance from what you asked me to do with the group photos.
two issue:
Mobile the bottom right does not look like the design
Desktop looks to be skewed down a bit from the top


[TEP-0115] Support Artifact Hub in Hub Resolver

Changes
Part of issues/667.
This commit adds support to resolve catalog from the Artifact Hub and keep current functionality of fetching catalog from the Tekton Hub.

Change 1:

The commit adds a new field type to the hub resolver indicating the type of the Hub to pull the resource from. The value can be set to tekton or artifact. By default, the resolver fetches resources from https://artifacthub.io/ when setting type to  artifact.

Change 2:

Prior to this change, the hub resolver only supports pulling resources from the Tekton Hub. This commit updates the default hub type to artifact since the Artifact Hub will be the main entrypoint for Tekton Catalogs in the future.

Change 3:

Prior to this change, the default Tekton Hub URL is: https://api.hub.tekton.dev. This commit removes the default value of the Tekton Hub URL and enforces users to configure their own instance of Tekton Hub since the public instance https://api.hub.tekton.dev will be deprecated after the migration to Artifact Hub is done.
/kind feature
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[x] Has Docs included if any changes are user facing
[x] Has Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[x] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
The Hub Resolver will have a new `type` field to indicate the type of Hub from where to pull the resource. The default hub type is updated from the Tekton Hub to the Artifact Hub. Please see more details in TEP-0115

/kind feature

/test all

/test all

/test all

Nice!

/retest

/retest

please add examples e.g. https://github.com/tektoncd/pipeline/blob/main/examples/v1beta1/taskruns/hub-resolver.yaml (ensure that we cover the minimal and full versions of resources)
@tektoncd/core-maintainers added this to the v0.41 milestone so that the first release of hub resolver will support artifact hub (and don't have to deal with deprecation/migration of default behavior)

Thanks @jerop ! Will add the example.
To confirm my understanding, I have this code to deal with backward compatibility for users who specifically set Catalog to "Tekton" for example (without such code, the resolver will try to find the Catalog named "Tekton" in the Artifact Hub which does not exist).
If we don't need to deal the migration/deprecation of the default behavior, I can drop the code?

/retest

known flake: https://github.com/tektoncd/pipeline/issues/4643
/retest

🤔

@jerop @abayer @wlynch @chuangw6 . Could you please review the code again. Thanks 😁

/approve
cc @abayer

Would it be worth adding docs around configuring the different hub impls and the differences between them?


test, integ: do not restore static routes for dynamic ifaces

Nmstate does not support static routes for interfaces configured with
dynamic IP. In some environments like CI gating and NMCI there are
interfaces configured like that.
In order to fix that, nmstate is not restoring the static routes of the
interfaces configured with dynamic ip.
Signed-off-by: Fernando Fernandez Mancera<EMAIL_ADDRESS>

I dislike this approach.
We are not restoring thing up, but give user a modified original state.
If we cannot restore to certain state, neither we support it or ask the test starter script to do change before and after our test.

I agree with this but that is not possible in some limited scenarios like CI gating machine. I will try to investigate why are we reporting an static IP address because according to the system the IP address is dynamic and not static but nmstate is not reporting that.

I am closing this PR because the solution proposed is not good. I am working in a better one.