adding in benchmem to tests

Mentioned this one in the exercism mentors track, would be nice to add some extra verbosity to user tests when they run the suite.
The example below is trivial, but for other challenges with benchmarks it would be helpful to understand how performant the solution is.
[sborza@icebox]:~/.../mentorcism/go/hello-world (master %):$ go test -v --bench .
=== RUN   TestHelloWorld
--- PASS: TestHelloWorld (0.00s)
goos: linux
goarch: amd64
pkg: github.com/sebito91/challenges/mentorcism/go/hello-world
BenchmarkHelloWorld-8<PHONE_NUMBER>               0.55 ns/op
PASS
ok      github.com/sebito91/challenges/mentorcism/go/hello-world        1.174s
[sborza@icebox]:~/.../mentorcism/go/hello-world (master %):$ go test -v --bench . --benchmem
=== RUN   TestHelloWorld
--- PASS: TestHelloWorld (0.00s)
goos: linux
goarch: amd64
pkg: github.com/sebito91/challenges/mentorcism/go/hello-world
BenchmarkHelloWorld-8<PHONE_NUMBER>               0.55 ns/op            0 B/op          0 allocs/op
PASS
ok      github.com/sebito91/challenges/mentorcism/go/hello-world        1.165s

No, I did a massive sed across the repo. Should I just update the config/exercise_readme.go.tmpl?

No, I did a massive sed across the repo. Should I just update the config/exercise_readme.go.tmpl?

Yes. I think the .tmpl change should be enough for starters.  Then running configlet generate will take care of the README.md files. We still commit all the REAME.md files just the same after running configlet.
Use ./bin/fetch-configlet to get the up to date configlet.
Then use ./bin/configlet  generate --help.  I think the default is to generate all the README.md files.
Compare resulting README.md to the changes made with sed.  If all changes match, all ok.

OK, on it now!

Tests aren't passing for same reasons as #1124, just FYI.
[sborza@icebox]:~/src/github.com/exercism/go (benchmem):$ ./bin/test-without-stubs fmt
moving stub exercises/acronym//acronym.go
moving stub exercises/bob//bob.go
moving stub exercises/gigasecond//gigasecond.go
moving stub exercises/hamming//hamming.go
moving stub exercises/hello-world//hello_world.go
moving stub exercises/leap//leap.go
moving stub exercises/ledger//ledger.go
moving stub exercises/markdown//markdown.go
moving stub exercises/nucleotide-count//nucleotide_count.go
moving stub exercises/proverb//proverb.go
moving stub exercises/rna-transcription//rna_transcription.go
moving stub exercises/tree-building//tree_building.go
moving stub exercises/triangle//triangle.go
moving stub exercises/two-fer//two_fer.go
moving stub files back

With #1125 I corrected the travis-cii problem.  I think this PR will need a rebase to upstream/master and then a push --force. The PR might auto close and then need re-opening; try it and see. Thanks.


Add support for WashTower

Which device do you want to add? Please describe:
LG WashTower Model #WKGX201HBSS (Spec sheet attached)
Describe the solution you'd like:
Monitor operational cycles for washer and dryer as two separate devices.
Device Data:

[5/30/2021, 8:07:03 AM] [LGThinQ] Found device:  769328ba-01d9-1b11-815c-f8b95a3561c0: Washer (undefined F3S1CWK__)
[5/30/2021, 8:07:03 AM] [LGThinQ] data:  {"deviceId":"769328ba-01d9-1b11-815c-f8b95a3561c0","deviceType":221,"modelName":"F3S1CWK__","subModelNm":null,"sensorType":null,"alias":"Washer","deviceCode":"LA07","networkType":"02","tftYn":"N","guideTypeYn":"Y","guideType":"TYPE1","pccModelYn":"Y","autoOrderYn":"N","drServiceYn":"N","ssid":"Pergola","timezoneCode":"America/New_York","timezoneCodeAlias":"USA/New_York","sdsGuide":"","newRegYn":"N","remoteControlType":null,"fareTarget":null,"area":"334505","sleep":null,"deviceState":"E","rmsClientId":null,"regDtUtc":"20210416191928000","regIndex":0,"blackboxYn":"Y","groupableYn":"Y","controllableYn":"N","combinedProductYn":"Y","masterYn":"N","snapshot":{"washerDryer":{"rinseDefault":"AUTODETECT_MANUAL","smartCare_onOff":"SMARTCARE_BUTTON_OFF","initialTimeMinute":0,"preState":"INITIAL","dnn_temp":"20","drumLight":"DRUMLIGHT_OFF","washTime":"NO_WASHTIME","addGarment":"ADDGARMENT_OFF","dnn_precipitationProbability":"40","dnn_washingIndex":"75","autoSoak":"AUTOSOAK_OFF","dnnReady":"DNNREADY_OFF","preWash":"PREWASH_OFF","state":"POWEROFF","ezCSSoftenerSetVal":"EZCSSO_OFF","intensive":"INTENSIVE_OFF","wrinkleCare":"WRINKLECARE_OFF","downloadCourse":"RINSESPIN","smallUE":"SMALLUE_OFF","buzzer":"BUZZER_4","AIDDLed":"AIDDLed_OFF","cloudCourse":"NOT_SELECTED","dnn_humidity":"87","freshCare":"FRESHCARE_OFF","extraRinse":"EXTRARINSE_OFF","medicRinse":"MEDICRINSE_OFF","ezDispenseNotation":"ezDisNotation_ml","turboWash":"TURBOWASH_OFF","remainTimeMinute":1,"steamSoftener":"STEAMSOFTENER_OFF","warmWater":"WARMWATERT_OFF","delay":"DELAY_OFF","soak":"NO_SOAK","childLock":"CHILDLOCK_OFF","remoteStart":"REMOTE_START_OFF","rinseHold":"RINSE_HOLD_OFF","audibleSDS":"AUDIBLE_SDS_OFF","ezDispenseDrawerState":"ezDisDrawer_CLOSE","favorite":"FAVORITE_OFF","rinseSpin":"RINSE_SPIN_OFF","courseSpendWater":0,"autoDetection":"AUTO_DETECTION_OFF","laundryTexture":0,"standby":"STANDBY_OFF","timeSave":"TIMESAVE_OFF","speechRecognitionMode":"SPEECH_RECOGNITION_MODE_OFF","courseSpendPower":0,"error":"ERROR_NO","dryLevel":"NO_DRYLEVEL","ezDetergentState":"EZCSDT_NOT_EMPTY","washLoadDisplay":"WASHLOAD_DISPLAY_OFF","creaseCare":"CREASECARE_OFF","ezSoftenerAmount":0,"rinseCount":"NO_RINSE","course":"NOT_SELECTED","protocolVersion":0,"steam":"STEAM_OFF","sterilize":"STERILIZE_OFF","multiStain":"MULTISTAIN_OFF","rinse":"RINSE_NORMAL","temp":"NO_TEMP","doorLock":"DOORLOCK_OFF","reserveTimeMinute":0,"ezCSDetergentSetVal":"EZCSDT_OFF","loadItem":"LOADITEM_OFF","washingIndex":"75","baseDownloadCourseData":"NOT_SELECTED","TCLCount":8,"waterPlus":"WATERPLUS_OFF","smartGridEnable":"SMARTGRIDENABLE_OFF","fabricSoftener":"FABRIC_SOFTENER_OFF","saveEnergy":"SAVE_ENERGY_OFF","wifiSDS":"WIFI_SDS_OFF","ezSoftenerState":"EZCSSO_NOT_EMPTY","coolDown":"COOLDOWN_OFF","dnn_dust":"-","ecoHybrid":"ECOHYBRID_OFF","voiceState":"VOICESTATE_OFF","doorClose":"DOORCLOSE_OFF","spin":"NO_SPIN","ezDetergentAmount":0,"waterLevel":"WATERLEVEL_0","soilWash":"NO_SOILWASH","activeStandbyEnable":"AUTO_STANDBY_OFF","coldWash":"COLDWASH_OFF","loadLevel":"LOAD_AUTO_DETECT"},"mid":287202642,"online":true,"static":{"deviceType":"221","countryCode":"US"},"meta":{"allDeviceInfoUpdate":true,"messageId":"39lPipYtT4-hjajUtoCfyQ"},"timestamp":1622377577189},"manufacture":null,"online":true,"platformType":"thinq2","homeDeviceOrder":-1,"roomDeviceOrder":-1,"ownershipYn":"Y","modelJsonVer":"9.4","modelJsonUri":"https://objectcontent.lgthinq.com/b6e6e5f8-6289-4b09-873c-c007cea50288?hdnts=exp=1673490225~hmac=62b97250d0476e4bfdaf3785b08d53e1c7622bb0c35eb363d4f05c295c5a7c7b","appModuleVer":"3.51","appModuleUri":"https://objectcontent.lgthinq.com/62b9bb3d-f174-458a-b4b3-e30c7ba14a31?hdnts=exp=1684561803~hmac=4bffa2e0617b8faa0635532676e9e0b55277ccc841a5f2d65a3dbd476738f721","appRestartYn":"Y","appModuleSize":"5258056","langPackProductTypeVer":"80.5","langPackProductTypeUri":"https://objectcontent.lgthinq.com/a7e610e1-1ca3-4545-bc04-5c61ad83254b?hdnts=exp=1685083049~hmac=b366db5d6f9c4e01219e8303d6ebdaf71ecc0e9dad83d2afc087202caf378a18","langPackModelVer":"0.3","langPackModelUri":"https://objectstore.lgthinq.com/28fdac4b-755d-4c78-b901-54e5e521d7ff?Expires=1661645814&Signature=W1wGgOPcQ4vvjdTreBMNwHSfGC7QT92muGntFxi~XkNzUuI5PCyYSmcyI2nO27~A9FagJ9veaSF1dTkUcbUQlFEAqTlKcgkoxi5Zm9kZsXMNkFUb2XYNkiwUem4UCywIfKUG681jCEunzkfXGu9sh4yIyrLqKVb3NupEVo67-q1Y7uFzWbjdz~hQSov5~UKOFAMnJd5zUE4ks~PTXRyLLGvk6dnWT0HtGftYwKo88Pwjdjcr2xNJwk4G5jI7LJfYNdnEmIGq3t92nmbi-iHt3jamZC6U8AdehQRH-DHZ585uE~5yy5AKCzOr-4fRgHpZcecHgAtSZUdGEhjZew~MWA__&Key-Pair-Id=APKAI74R6YENXPGRIWLQ","roomId":"161859762791865546","fwInfoList":[{"checksum":"0000585A","partNumber":"SAA42102401","order":2},{"checksum":"0000A415","partNumber":"SAA42102301","order":1}],"modemInfo":{"modelName":"F3S1CWK__","appVersion":"clip_hna_v1.9.080","modemType":"QCOM_QCA4010","ruleEngine":"y"},"existsEntryPopup":"N","fwVer":null,"modemVer":null,"subDeviceCount":0,"firebaseLogKey":"T:LC-S:LC-U:4.5-P:KEPLER"}
[5/30/2021, 8:07:03 AM] [LGThinQ] Device not supported: 769328ba-01d9-1b11-815c-f8b95a3561c0: Washer (undefined F3S1CWK__)
[5/30/2021, 8:07:03 AM] [LGThinQ] Found device:  83f7c886-e876-125f-b299-f8b95a356217: WashTower (undefined W3S1CVK2EVS_D_US)
[5/30/2021, 8:07:03 AM] [LGThinQ] data:  {"deviceId":"83f7c886-e876-125f-b299-f8b95a356217","deviceType":222,"modelName":"W3S1CVK2EVS_D_US","subModelNm":null,"sensorType":null,"alias":"WashTower","deviceCode":"LA06","networkType":"02","tftYn":"N","guideTypeYn":"Y","guideType":"TYPE1","pccModelYn":"Y","autoOrderYn":"N","drServiceYn":"N","ssid":"Pergola","timezoneCode":"America/New_York","timezoneCodeAlias":"USA/New_York","sdsGuide":"","newRegYn":"N","remoteControlType":null,"fareTarget":null,"area":"334505","sleep":null,"deviceState":"E","rmsClientId":null,"regDtUtc":"20210416191928000","regIndex":0,"blackboxYn":"Y","groupableYn":"Y","controllableYn":"N","combinedProductYn":"Y","masterYn":"Y","snapshot":{"washerDryer":{"initialBit":"INITIAL_BIT_OFF","smartCare_onOff":"SMARTCARE_BUTTON_OFF","initialTimeMinute":1,"preState":"INITIAL","downloadedCourseDryer27inchBase":"PERMPRESS","energySaver":"ENERGYSAVER_OFF","error":"ERROR_NO","dryLevel":"NO_DRYLEVEL","moreLessTime":0,"dnnReady":"DNNREADY_OFF","smartCourseDryer27inchBase":"NOT_SELECTED","remainTimeHour":0,"state":"POWEROFF","reduceStatic":"REDUCESTATIC_OFF","wrinkleCare":"WRINKLECARE_OFF","temp":"NO_TEMP","antiBacterial":"ANTIBACTERIAL_OFF","loadItem":"LOADITEM_OFF","AIDDLed":"AIDDLed_OFF","cloudCourse":"NOT_SELECTED","dampDrySignal":"DAMPDRYSIGNAL_OFF","timeDry":"TIMEDRY_OFF","remainTimeMinute":1,"courseDryer27inchBase":"NOT_SELECTED","easyIron":"EASYIRON_OFF","childLock":"CHILDLOCK_OFF","remoteStart":"REMOTE_START_OFF","turboSteam":"TURBOSTEAM_OFF","initialTimeHour":0},"mid":350167405,"online":true,"static":{"deviceType":"222","countryCode":"US"},"meta":{"allDeviceInfoUpdate":true,"messageId":"eCidgBMhT7ycrhGVp6yA7g"},"timestamp":1622377634350},"manufacture":null,"online":true,"platformType":"thinq2","homeDeviceOrder":-1,"roomDeviceOrder":-1,"ownershipYn":"Y","modelJsonVer":"3.0","modelJsonUri":"https://objectcontent.lgthinq.com/d3b8a3d0-3019-4229-a4ff-122ecf948a6f?hdnts=exp=1675409957~hmac=202ba30119caa4f769151e24abccc3b5ee52d3cd554b00d8042607ffb2adcccf","appModuleVer":"3.51","appModuleUri":"https://objectcontent.lgthinq.com/62b9bb3d-f174-458a-b4b3-e30c7ba14a31?hdnts=exp=1684561803~hmac=4bffa2e0617b8faa0635532676e9e0b55277ccc841a5f2d65a3dbd476738f721","appRestartYn":"Y","appModuleSize":"5258056","langPackProductTypeVer":"80.5","langPackProductTypeUri":"https://objectcontent.lgthinq.com/a7e610e1-1ca3-4545-bc04-5c61ad83254b?hdnts=exp=1685083049~hmac=b366db5d6f9c4e01219e8303d6ebdaf71ecc0e9dad83d2afc087202caf378a18","langPackModelVer":"0.4","langPackModelUri":"https://objectstore.lgthinq.com/ae5670c7-4c73-4f81-a05a-cbd06cc841cc?Expires=1661646940&Signature=KY~vyBNY-RKA9ICugMCdG3qNw1LuxmKmen3UU7~VHTrfZErUp9R6xPz~mZO0gyoCw22rl00cgbeM9oS9pfCl0cLlcE33~KK4eMj4Jh5hB0LKs6nBrgXZrU1Dff1v63HljKQRpyiGwOUIdIecOwkgI4EU7u0cvqWxcYjTHI9MVcIsSgbrhV1d5kiBkPrxGZcHixtDMuuV4oXVEHwiquo-xt-f5ykafVkkgBrdSmn1dINoxHhtULZSNL-3jaatHHlvXuVtAT8ruyk7nGdVUAN8yGvoviLqw2je8dLs3MZ03Uq86x0TQjHmHKKjOFh6bT8WJlBt6LmgdbfFoVQZovOkLw__&Key-Pair-Id=APKAI74R6YENXPGRIWLQ","roomId":"161859762791865546","fwInfoList":[{"checksum":"0000B7B2","partNumber":"SAA38964419","order":2},{"checksum":"0000FFDB","partNumber":"SAA38964313","order":1}],"modemInfo":{"modelName":"W3S1CVK2EVS_D_US","appVersion":"clip_hna_v1.9.080","modemType":"QCOM_QCA4010","ruleEngine":"y"},"existsEntryPopup":"N","fwVer":null,"modemVer":null,"subDeviceCount":0,"firebaseLogKey":"T:LC-S:LC-U:4.5-P:KEPLER"}
[5/30/2021, 8:07:03 AM] [LGThinQ] Device not supported: 83f7c886-e876-125f-b299-f8b95a356217: WashTower (undefined W3S1CVK2EVS_D_US)
WashTower Spec Sheet.pdf

I already added, it's work for you ?

Hi!
Just after I posted the request, the WashTower started leaking from the main feed valve. The retailer took it away, and we just received the replacement the other day. We ran a few loads through it to make sure it works, and I monitored the plug in. I’ll send you logs and screen caps next week after I do some controlled testing. So far it seems to work well. There are a few labels that might be changed, and I’ll let you know what they are.
Thank you for all your hard work on this!
Michael

On 08 Jul 2021, at 03:26, nVuln @.***> wrote:
I already added, it's work for you ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/nVuln/homebridge-lg-thinq/issues/18#issuecomment-876240547, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFMCFYOYKK4ZLB35HMLT75DTWVOLXANCNFSM47CDGJAA.


New PR to test SignCLA at 2018-03-07 10:45:28.359218733 -0800 PST m=+6.210666386

Body of PR

indiv-pass-staging: test succeeded


refactor!: Updated secret path to secret name

BREAKING CHANGE: Updated secret path to secret name

If your build fails  due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:

[ ] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
[ ] I am not introducing a new dependency (add notes below if you are)
[ ] I have added unit tests for the new feature or bug fix (if not, why?)
[x] I have fully tested (add details below) this the new feature or bug fix (if not, why?)
[ ] I have opened a PR for the related docs change (if not, why?)

Testing Instructions
make test
make docker
New Dependency Instructions (If applicable)

Codecov Report

Merging #4435 (e869783) into main (da675bb) will not change coverage.
The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main    #4435   +/-   ##
=======================================
  Coverage   41.73%   41.73%
=======================================
  Files         106      106
  Lines        9749     9749
=======================================
  Hits         4069     4069
  Misses       5333     5333
  Partials      347      347

Impacted Files
Coverage Δ

internal/security/secretstore/init.go
14.35% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Preserve workflow layout in UI when user leaves page

Currently if a user leaves the workflow ui page and comes back the system redraws the layout overwriting any formatting that the user did.

It's currently unclear how the layout can be preserved.

@gtarcea I think that the best way  to do this is to add a user properties table. Then a layout type doc could have experiment id and x y coordinates for each process.


fix(input): inherit font from above

This will inherit the font family etc. from the main styling, to be styled with the correct font. Safari for example has font-family: -apple-system on inputs by default

Thank you 😃 !!

I'd to work on some style issues earlier...but with this PR and 3.4.0, we have resolved the issues.

Also let us know how you are using terminal-in-react 😄

I just opened the demo because I was looking through your projects actually @nitin42

Let me know if you have any 😉


adapt rcverify to check for executables without relying on file name filters

rcverify scans a RC for executables by checking files for +x. This can lead to false positives and negatives (the former because there are exemptions for .sh files for example that are expected to be shell scripts).
arguably, it is better for the verifier to check that the file type is not binary.
cc @dgrove-oss

Fixed in #270


Implement Input without the red background on error

Related Changes :

Implement Input without the red background on error

Before
After

Related Issue
Please use one of the well-known github fixes keywords to reference
the issues fixed with this PR (eg Fixes #). If an issue doesn't yet exist please create one if reasonable to aid
in issue tracking.
NOTE: For multiple issues resolved by this PR use the corresponding keywords every time in a comma-delimited list per the reference
page above.
Description
Create a descriptive title and provide all of the relevant details in the description.
This information lives with the code and will help future readers (including yourself) and will serve as documentation.
At the very least please describe the issue you are addressing, and what your fix entails.
Sample Card
If appropriate, please include a link to a card in one of the samples directories that can be used to validate this change. This can be an existing card or a card added with this PR.
How Verified
How you verified the fix, including one or all of the following:

New unit tests that were added if any. If none were added please add a quick line explaining why not.
Existing relevant unit/regression tests that you ran
Manual scenario verification if any; Do include .gif's or screenshots of the testing you performed here if you think that it
will aid in code reviews or corresponding fixes on other platforms for eg.

You also need to remove the value backgroundcolor from the struct errorStateConfig since we don't need it anymore

Ok


Integration test are failing

What happened?
Integration tests are failing for me:

@davidatwhiletrue could you trigger "Integration testing" workflow in order to verify this?
Reproduction steps

Build the latest v2.0.0:

$ git describe
v2.0.0
$ dotnet build
MSBuild version 17.4.8+6918b863a for .NET
  Determining projects to restore...
  All projects are up-to-date for restore.
  Casper.Network.SDK -> /home/andrew/casper-net-sdk/Casper.Network.SDK/bin/Debug/net7.0/Casper.Network.SDK.dll
  Casper.Network.SDK.Test -> /home/andrew/casper-net-sdk/Casper.Network.SDK.Test/bin/Debug/net7.0/Casper.Network.SDK.Test.dll

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:00.61

Run local network:

$ docker run --rm -it --name casper-nctl -d -p 11101:11101 -p 14101:14101 -p 18101:18101 -p 25101:25101 -e DEPLOY_DELAY="5sec" makesoftware/casper-nctl:latest
$ while [ "`docker inspect -f {{.State.Health.Status}} casper-nctl`" != "healthy" ]; do sleep 1; done

Configure PEM keys:

$ docker exec -t casper-nctl cat /home/casper/casper-node/utils/nctl/assets/net-1/faucet/secret_key.pem > Casper.Network.SDK.Test/TestData/faucetact.pem

Run tests:

$ dotnet test --no-build --verbosity normal --settings Casper.Network.SDK.Test/test.runsettings --filter="TestCategory=NCTL"
...
Failed!  - Failed:    26, Passed:    15, Skipped:     0, Total:    41, Duration: 614 ms
...

26 failed tests :fearful:
Let us try again, this time using NCTL launched with -e PREDEFINED_ACCOUNTS="true":
Build started 8/30/2023 12:09:02PM.
     1>Project "/home/andrew/casper-net-sdk/Casper.Network.SDK.sln" on node 1 (VSTest target(s)).
     1>ValidateSolutionConfiguration:
         Building solution configuration "Debug|Any CPU".
Test run for /home/andrew/casper-net-sdk/Casper.Network.SDK.Test/bin/Debug/net7.0/Casper.Network.SDK.Test.dll (.NETCoreApp,Version=v7.0)
Microsoft (R) Test Execution Command Line Tool Version 17.4.1+79d56b02b69a582cd90428878a5e9411ab7538f5 (x64)
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
  Failed GetEraSummaryTest [25 ms]
  Error Message:
     Expected: True
  But was:  False

  Stack Trace:
     at NetCasperTest.NctlGetXTest.GetEraSummaryTest() in /home/andrew/casper-net-sdk/Casper.Network.SDK.Test/NctlGetXTest.cs:line 225
   at NUnit.Framework.Internal.TaskAwaitAdapter.GenericAdapter`1.BlockUntilCompleted()
   at NUnit.Framework.Internal.MessagePumpStrategy.NoMessagePumpStrategy.WaitForCompletion(AwaitAdapter awaiter)
   at NUnit.Framework.Internal.AsyncToSyncAdapter.Await(Func`1 invoke)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.RunTestMethod(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.Execute(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__0()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)

1)    at NetCasperTest.NctlGetXTest.GetEraSummaryTest() in /home/andrew/casper-net-sdk/Casper.Network.SDK.Test/NctlGetXTest.cs:line 225

Failed!  - Failed:     1, Passed:    40, Skipped:     0, Total:    41, Duration: 1 m 40 s - Casper.Network.SDK.Test.dll (net7.0)
     1>Done Building Project "/home/andrew/casper-net-sdk/Casper.Network.SDK.sln" (VSTest target(s)) -- FAILED.

Build FAILED.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:01:42.54

Only 1 failed test! This is much better, but still needs to be fixed.

Hmm, issue is not reproducible with CI/CD: https://github.com/make-software/casper-net-sdk/actions/runs/6023639426/job/16340766970.

After waiting few minutes, all tests passed successfully :tada:
Seems that some time is required for the network initialization.

hi @andrzej-casper. thanks for reporting. As discussed separately, you local tests failed because the NCTL haven't completed the initialization when you triggered the tests. On the CI/CD pipeline this doesn't happen because the builld process takes time enough for NCTL to start signing blocks.
In any case, we'll consider to add a clear error message in this situation.


documentation update for "pre-used classes"

It would be nice to see some documentation about pre-used classes which i cannot use to name the dropdown.
I called it select2-dropdown, but this one is pre-used and messed the whole design up... after hours of searching i finally found it.

This is a duplicate of #2809.


add isSwitchTab prop to Timer object

sometime we need to use timer in keeplive component

Hi, thanks for your PR ;)


I can not understand the source code.

Dear author:
Can you give me some advices for me? I need do research , but I can not understand the source code

Actually, the codebase mainly consists  of two parts. The first part is the management of timeseries (indexes and in-memory data samples), and they are in folders except for leveldb. The second part is the management of the persistent data samples (I derive time-partitioned lsm tree based on LevelDB), which is contained in folder leveldb. For each folder, the main contents are as follows:

base: basic helper functions for the codebase
block: interfaces for chunk reader/writer, and index reader/writer
chunk: compression of a set of data points into a chunk
cloud: the AWS S3 wrapper for file operations on S3
db: the tsdb object (in charge of everything)
head: management of in-memory data (indexes and in-memory data samples), this is important
index: mainly are different kinds of posting lists
label: tags
leveldb: time-partitioned LSM tree
querier: the querier for all data, which has a global view (this is deprecated), the current querier is in leveldb/db/db_querier.h


Potential type improvement for deleteFrom and executeTakeFirst return result

👋
Quick question/potential feature request about the following:
const result = await db
    .deleteFrom("Log")
    .where("expiresAt", "<=", date)
    .executeTakeFirst();

const count = result.numDeletedRows ? Number(result.numDeletedRows) : 0;

Running the example above, result is always an object with type DeleteResult, but if 0 rows are deleted, result.numDeletedRows returns undefined and result is empty, but the type of numDeletedRows according to typescript is always bigint. If 1 or more rows are deleted, result.numDeletedRows returns an accurate count as type bigint as expected.
I am not sure if this is the intended behavior, a bug on my end, if I am overlooking something, or if there is something I can change, but as a suggestion I feel that if the undefined return value behavior is correct, then the return type for result.numDeletedRows should represent that correctly as bigint | undefined, otherwise if it is not intended behavior, return 0 if 0 rows are deleted.
I am using the planetscale dialect for reference, and generating types using kysely-codegen
{
  "kysely": "^0.23.4",
  "kysely-planetscale": "^1.2.1",
  "kysely-codegen": "^0.9.0"
}

Thanks!

You should open this issue in kysely-planetscale repo. We have no control over this.


Fix acceptance tests

add acceptance as a project module
fix code evolutions
change keywords in order not to have to specify --pythonpath parameter
add requirements file
update documentation

close #217

Coverage remained the same at 94.108% when pulling ab6c8c2db587e810c6f8014b114234c5390220ae on fix/acceptance into 4b978c83d328f1a9db88df11e79f43ea324d0c37 on develop.

Coverage remained the same at 94.108% when pulling ab6c8c2db587e810c6f8014b114234c5390220ae on fix/acceptance into 4b978c83d328f1a9db88df11e79f43ea324d0c37 on develop.

Coverage remained the same at 94.108% when pulling 5b30e9f629d2474d108281a419ac876d23acfaf4 on fix/acceptance into 4b978c83d328f1a9db88df11e79f43ea324d0c37 on develop.

Coverage remained the same at 94.108% when pulling 5b30e9f629d2474d108281a419ac876d23acfaf4 on fix/acceptance into 4b978c83d328f1a9db88df11e79f43ea324d0c37 on develop.

Coverage remained the same at 94.108% when pulling 20e5588d1cd98c9a17ef1faf16d46cdb0c136b55 on fix/acceptance into 4b978c83d328f1a9db88df11e79f43ea324d0c37 on develop.

Coverage remained the same at 94.108% when pulling cd451c3e63af50d07482b13b869dcdd88869e3c5 on fix/acceptance into 029d7865b490703c2d41f001fa442cc154ed3f25 on develop.

Coverage remained the same at 94.108% when pulling 5c0c39fd231945d6889a25fed113d188abe0ff4f on fix/acceptance into 029d7865b490703c2d41f001fa442cc154ed3f25 on develop.

Coverage remained the same at 94.108% when pulling 5c0c39fd231945d6889a25fed113d188abe0ff4f on fix/acceptance into 029d7865b490703c2d41f001fa442cc154ed3f25 on develop.


Gem does not exist in RubyGems

source 'https://rubygems.org'

gem 'select2-rails'
gem 'select2-foundation'

Running bundle install yields the following error

Could not find gem 'select2-foundation' in any of the gem sources listed in your Gemfile.

@Yanchek99 I have not published this gem on RubyGems so you can specify the gem location with at git option
source 'https://rubygems.org

gem 'select2-rails'
gem 'select2-foundation', :git => 'https://github.com/zflat/select2-foundation'

Would be great if a gem release could be made :)

@pmackay Released it now: https://rubygems.org/gems/select2-foundation

Much obliged @zflat :-)

@zflat slight problem here. If I try to use the gem, I'm stuck because I'm using foundation-rails 6.4, but this gem has s.add_dependency "foundation-rails", "~> 5". That suggests it wont go up to 6. Is Foundation 6 not supported? I'm not really sure what ~> 5 means because I thought the ~> was for allowing different minor/patch versions under a major version.

@pmackay sorry about that. Should be fixed in b4ef957ffba00f514f44fcb78b01a194215ad173


Update Docs to reflect appState capabilities

Add api.getAppState()
Add example usage of appState to/from files to login()

Addresses issue #88.  Thanks.
@bsansouci this looks good to me but you're the most familiar with appState. Can you double-check these docs and merge if they're accurate?

Looks good to me :dancer:


Service Fabric REST API specification version 6.2 RTO

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[X] The title of the PR is clear and informative.
[X] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[X] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[X] If applicable, the PR references the bug/issue that it fixes. (Not Applicable)
[X] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[X ] I have read the contribution guidelines.
[ X] My spec meets the review criteria:

[X] The spec conforms to the Swagger 2.0 specification.
[X] The spec follows the guidelines described in the Swagger checklist document.
[X] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Automation for azure-sdk-for-node
A PR has been created for you:
https://github.com/Azure/azure-sdk-for-node/pull/2720

Automation for azure-sdk-for-go

@annatisch - the issue should be resolved now. This should have been caught with our internal CI/build process on the Service Fabric swagger specification repo. We will improve this. @salameer

Thanks @VipulM-MSFT.
There are a number of errors in both the model and linter PR_ONLY=true CI jobs, for example there are many properties with this:
"Property named: 'PackageSharingPolicy', for definition: 'DeployServicePackageToNodeDescription' must follow camelCase style. Example: 'packageSharingPolicy'.",

And many of the models:
Found errors in validating the response with statusCode "200" for x-ms-example "Get Correlated events" in operation "GetCorrelatedEventList".:

Could you take a look?

@annatisch - this is not an Azure API specifications so the naming suppressions are already part of the README.MD and approved @salameer .

We also suppress the example validations due to issues in the validation tooling. Once they are fixed we can re-enable the checks and those failures should turn in to blocking failures. @salameer has the context on the issues.

@VipulM-MSFT I believe the supressions need to be in the README.md at the root of all the versions, the same one that contains the tags for generation. Take a look at this pr that added supressions.

#hold-off
There are genuine failures in the example validation, we will fix and update the PR with those and ensure that the suppressions are added at the root. Let's wait on merging this PR for now, until I and @samedder sign off again.

@salameer and @annatisch this is ready to go. All issues should be fixed now. #signoff

Ping - @salameer and @annatisch

@VipulM-MSFT
I can't leave comments on the diff itself because it's too large for Github to load it.
Can you please remove the newline characters from the end of descriptions, for example:
    "BackupSuspensionInfo": {
      "type": "object",
      "description": "Describes the backup suspension details.\n",
      "properties": {
        "IsSuspended": {
          "type": "boolean",
          "description": "Indicates whether periodic backup is suspended at this level or not."
        },
        "SuspensionInheritedFrom": {
          "$ref": "#/definitions/BackupSuspensionScope",
          "description": "Specifies the scope at which the backup suspension was applied.\n"
        }
      }
    },

This creates strange formatting in the generated SDKs for example:
class BackupSuspensionInfo(Model):
    """Describes the backup suspension details.
    .

@annatisch - the SDK generators should trim before generating the descriptions. I have removed the newlines. If there are no other issues, please publish the specification.


Change log dir config

Change configuration for log directory in order to simplify changes and deployment.
List of commits:
@mrandi
simplify with value annotations
mrandi authored 26 seconds ago
133f084
@mrandi
add docs in readme
mrandi authored 10 minutes ago
7544c6a
@mrandi
use env variable for logging dir
mrandi authored 13 minutes ago
773456c
@Gregsen
fixed value for download dir
Gregsen authored 18 minutes ago
4085581
@ljaeckel
Merge pull request #65 from zalando-stups/logdirectory …
ljaeckel authored 34 minutes ago
170f5a0
@Gregsen
directory now set via env variable
Gregsen authored 40 minutes ago
7c58ca2

the same:
create directory on startup
mrandi authored 19 seconds ago
c28663b

the same:
use tmp dir
mrandi authored 2 minutes ago
76bed16


refactor(NodesTable): tasks column

Add old column tasks functionality to new refactored table.
Closes DCOS-38821

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?


File sizes

I noticed that file sizes were not shown in the file-explorer. I made a couple of changes to display this feature.

Thanks! Merged in https://github.com/Kloudless/file-explorer/commit/d6f15f244ae159a813d7e6b25edf30e1b9c848a4.


Post URL is returning 404 after publishing

Issue Summary
The issue occurs after publishing a post. After clicking on "Published! View post" link it leads to 404 page.
To Reproduce

Create a post
Publish the post
Click on the link in 'Published' popup in down left corner
Link opens a page with 404

Clicking on the link should lead to published post instead.
Additionally the response that comes back from the server when publishing a post contains a field with wrong URL:
url: "http://ghost.local/404/"

Technical details:

Ghost Version: 2.10.1
Node Version: 8.11.4
Browser/OS: Chrome 71 / Ubuntu 18.04
Database: MySQL 5.7.24

Hi,
I'm still having this bug with this configuration:
Debug Information:
    OS: Mac OS X, v10.14.4
    Node Version: v10.15.2
    Ghost-CLI Version: 1.9.9
    Environment: production

After publishing my page, I can find it in blog post but when trying to access it, it returns a 404.
From the blog list, the url is: http://localhost:2368/p/f3e44130-b8cb-45fa-b90d-0d4e38e7515f/ instead of http://localhost:2368/test-de-post
Any idea ?

I still had this issue after deleting a tag. All the posts containing such tag (although never as primary and never alone) had their links set to /404.
Republishing a second time didn't help. Republishing after removing every tag and adding again also didn't. What worked was:

Open the post in the editor
Remove every tag
Publish. The link remains /404.
Re-add the tags.
Publish. Now the link works.

I have this exact issue after messing around with tags :/

Met this issue with ghost5.22 too. I think  this is related to nginx, because the issue only occurs when deploying with nginx. But I have no idea how to fix this :(

are U using k8s to deploy ghost and created several pods?

The issue still persists

@sronald01 yes it does.


Handle skipLevelOfDetail and backface commands in ModelFeatureTable

Cesium3DTileBatchTable has code for handling tileset._skipLevelOfDetail, which determines whether backface commands are generated for tiles in the tileset. The equivalent class in ModelExperimental ModelFeatureTable, does not handle this yet.
When done, this should be tested by the "create duplicate backface commands" test in Cesium3DTilesetSpec

This came up on the forum: https://community.cesium.com/t/modelexperimental-rendering-3dtileset-failed/19759/3

I started to address that here: https://github.com/CesiumGS/cesium/tree/skip-lods-experimental
The ModelExperimentalDrawCommand refactor was pretty far along and I was about to change how commands are pushed to the command lists to avoid array allocations. If someone else would like to pick that up go ahead!


Fix streaming of .gif files

I'm currently working on this, think it should be solved no, just needs testing

Solved with commit daf6661


level(deps): Deps and tests update

Updates deps and tests

Codecov Report

Merging #2 (ecfe93e) into master (e8a0af6) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master        #2   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            9         9
  Lines          554       546    -8
  Branches       111       109    -2
=========================================
- Hits           554       546    -8

Impacted Files
Coverage Δ

src/lib/iterator.ts
100.00% <100.00%> (ø)

src/lib/serialize.ts
100.00% <100.00%> (ø)

src/lib/utils.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8a0af6...ecfe93e. Read the comment docs.


user12986714: Blacklist 90\W*+98

user12986714 requests the blacklist of the username 90\W*+98. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

90\W*+98 has been seen in 20 true positives, 2 false positives, and 0 NAAs.

Approved by Daniil in Charcoal HQ


Can't setup perspective layout at startup

Perspective works fine for me with a simple configuration like:
  (use-package perspective
      :custom
      (persp-mode-prefix-key (kbd "C-c x"))
      :config
      (persp-mode)
      )

The error arises when I try to create from my init file a new perspective with a given window and buffer layout:
  (defun my/startup-window-layout ()
    (split-window-horizontally)
    (other-window 1)
    (split-window-below)
    (other-window 2)
    )

  (defun my/config-startup-perspective ()
    (persp-switch "project")
    (my/startup-window-layout)
    (switch-to-buffer "*dashboard*")
    (other-window 1)
    (shell (generate-new-buffer-name "*shell*"))
    (other-window 1)
    (switch-to-buffer "*scratch*")
    )

  (use-package perspective
      :demand t
      :custom
      (persp-mode-prefix-key (kbd "C-c x"))
      :config
      (persp-mode)
      (my/config-startup-perspective)
      )

With this config the "project" perspective is not created, only the buffers are visible but not attached to the main perspective and the project perspective as I mentioned doesn't exist.
I have tried a few things:

without :demand t the perspective gets created but the buffers and window layout only appear after running persp-counsel-switch-buffer.
trying to run the my/config-startup-perspective with the persp-mode-hook gives the same result that with :demand t.

Also for some reason the function seems to be executed twice (I get two shell buffers created), meaning that persp-mode would be activated twice also.

Try using :init instead of :config in your use-package forms. I recently changed the documentation to do that to avoid all kinds of subtle lazy loading problems, which is what I suspect is happening here. Also, maybe change to (persp-mode 1). Maybe I should change the README to do that, too.
For your use case, maybe look into persp-state-save and persp-state-load? You can set everything up exactly the way you want, save to a well-known file (instead of the default), and load from it.

Changed to init, and I don't get anymore the double shell buffer, thus I suppose that it is loading just one time.
What I'm still not able to do is to run from elisp the layout function my/config-startup-perspective. I tried to use the persp-mode-hook, after-init-hook, emacs-startup-hook, and also using from use-package the :demand and :config keywords.
On the other hand, I'm able to run interactively with M-x the function once everything is loaded.
Is there a way to run this from elisp with a hook or :config?

The following works for me using emacs -Q -l /path/to/perspective-autoloads.el -l /path/to/use-package-autoloads.el:
(defun my/startup-window-layout ()
  (split-window-horizontally)
  (other-window 1)
  (split-window-below)
  (other-window 2)
  )

(defun my/config-startup-perspective ()
  (persp-switch "project")
  (my/startup-window-layout)
  (switch-to-buffer "*dashboard*")
  (other-window 1)
  (shell (generate-new-buffer-name "*shell*"))
  (other-window 1)
  (switch-to-buffer "*scratch*")
  )

(use-package perspective
  :custom
  (persp-mode-prefix-key (kbd "C-c x"))
  :init
  (persp-mode 1)
  (my/config-startup-perspective)
  )

It's the same thing you posted originally, except :config is replaced with :init. Note that you switch to *scratch* in my/config-startup-perspective rather than *scratch* (project), but I assume that's intentional.
Please try this with emacs -Q and similar -l flags to mine.

It works!
I had tried this kind of setups and they were not working for me. After a bit of tinkering I think I found the problem:

Opening from shell works with emacs -Q -l and also emacs.
Opening from app icon in favorite apps bar doesn't work.

The app icon in favorite bar was emacsclient.desktop. There is also another app icon in emacs folder /usr/local/share/emacs/28.1.50/etc/ called emacs.desktop.

emacsclient.desktop executes the following: sh -c "if [ -n \\"\\$*\\" ]; then exec emacsclient --alternate-editor= --display=\\"\\$DISPLAY\\" \\"\\$@\\"; else exec emacsclient --alternate-editor= --create-frame; fi" placeholder %F
emacs.desktop simply executes: emacs %F

Don't really know if one of the flags or the command emacsclient is breaking the elisp code execution.
Thanks for the help! (just changing .desktop file to fix my problem)


8344.2 Add PUT /systemConfigs route

https://github.com/Shippable/pm/issues/8344
Add a route to update systemConfigs. Use the logic from api.

complete. closing.


Fix inconsistent behaviour across adapters with read types and "create" command

During the investigation for #423 I discovered that for SQLite and MySQL (or basically for everything aside from PostgreSQL) the read types are applied twice. This works well if the read type allows it, but if it does not, it fails for these adapters, making behaviour between adapter inconsistent.
The solution here is to use relation.dataset.where instead of relation.where in default implementation of insert method of Create command. relation.where already applies the read types on materialization, while relation.dataset.where does not. This is also consistent with how Update command behaves.
With that in place, we always call finalize on "raw" data from the database, avoiding double application of a read type.
The PR consists of two commits. First one just adds tests replicating the problem. The second one just changes the code.

These CI failures look weird. Did my changes cause them?


Change React.PropTypes to prop-types to support React 15.5+

Thanks for your work on this component!
I am wondering if there is anyone who is planning on changing the imports to remove the warnings in React 15.5+, or can submit a merge request.
Codemod:
https://github.com/reactjs/react-codemod#react-proptypes-to-prop-types

yapp. we need to do that. do you feel like sending a pull request? I would be happy to review and merge it.

Hey! I ran the codemod and pushed out 0.14.2 which uses prop-types. Thanks for bringing up the topic! 👍

thanks @mariusandra great

thank you @mariusandra for the quick turnaround!


mmctl: 9.11.3 -> 9.11.5

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for mmctl is: Remote CLI tool for Mattermost
meta.homepage for mmctl is: https://www.mattermost.org
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 9.11.5 with grep in /nix/store/0zi74p9dscc1ym207qd9a2ic5s8p57w6-mmctl-9.11.5
found 9.11.5 in filename of file in /nix/store/0zi74p9dscc1ym207qd9a2ic5s8p57w6-mmctl-9.11.5

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath

mattermost
mmctl

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/0zi74p9dscc1ym207qd9a2ic5s8p57w6-mmctl-9.11.5 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A mmctl https://github.com/r-ryantm/nixpkgs/archive/ad8bc49473d0d165850c969d5ff1d374eaf2673c.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/ad8bc49473d0d165850c969d5ff1d374eaf2673c#mmctl

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/0zi74p9dscc1ym207qd9a2ic5s8p57w6-mmctl-9.11.5
ls -la /nix/store/0zi74p9dscc1ym207qd9a2ic5s8p57w6-mmctl-9.11.5/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 2 packages built:

mattermost
mmctl

Maintainer pings
cc @ryantm @numinit @Kranzes @mgdelacroix for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Fixes: MMSA-2024-00392 MMSA-2024-00388 MMSA-2024-00386
https://mattermost.com/security-updates/

Result of nixpkgs-review pr 356586 run on x86_64-linux 1

2 packages built:

mattermost
mmctl

@NixOS/nixpkgs-merge-bot merge


Detect a run within Docker

This PR detects whether the running test is running in a Docker container and acts accordingly:

If the test is not in a Docker container, assume that it is running on the host. Then the usual process takes place: use localhost and the mapped port to connect to the container.
If the test is in a Docker container, assume it is running as a sibling container and that the docker command manages the same Docker engine (that's on the user to configure the container properly). Find and use the gateway IP address (which should represent the Docker host) and use the mapped port.

This is required as some CI engine may choose to (or be configured to) run the test in a container. As such, localhost won't be usable to connect to the container as it would represent the test container itself.

Sorry, forgot to export containerGateway 😅

Thanks!


⬆ 🤖 - Let us endeavor so to live that when we come to die even the undertaker will be

Auto Release

This is a benchmark review for experiment review_of_100_reviews_20240409.
Run ID: review_of_100_reviews_20240409/benchmark_2024-04-10T11-21-00_v1-16-0-100-g20a786d41-dirty.
This pull request was cloned from https://github.com/mraniki/tt/pull/1425. (Note: the URL is not a link to avoid triggering a notification on the original pull request.)

Experiment configuration
review_config:
  # User configuration for the review
  # - benchmark - use the user config from the benchmark reviews
  # - <value> - use the value directly
  user_config:
    enable_ai_review: true
    enable_rule_comments: false

    enable_complexity_comments: benchmark
    enable_docstring_comments: benchmark
    enable_security_comments: benchmark
    enable_tests_comments: benchmark
    enable_comment_suggestions: benchmark

    enable_approvals: true

  ai_review_config:
    # The model responses to use for the experiment
    # - benchmark - use the model responses from the benchmark reviews
    # - llm - call the language model to generate responses
    model_responses:
      comments_model: benchmark
      comment_validation_model: benchmark
      comment_suggestion_model: benchmark
      complexity_model: benchmark
      docstrings_model: benchmark
      security_model: benchmark
      tests_model: benchmark

# The pull request dataset to run the experiment on
pull_request_dataset:
- https://github.com/mraniki/iamlistening/pull/294
- https://github.com/gdsfactory/gplugins/pull/373
- https://github.com/Anush008/fastembed-rs/pull/48
- https://github.com/mraniki/tt/pull/1435
- https://github.com/kloudlite/operator/pull/172
- https://github.com/mraniki/iamlistening/pull/293
- https://github.com/mraniki/iamlistening/pull/292
- https://github.com/mraniki/cefi/pull/434
- https://github.com/kloudlite/operator/pull/171
- https://github.com/usama-maxenius/image-editor/pull/62
- https://github.com/mraniki/tt/pull/1434
- https://github.com/mraniki/dxsp/pull/614
- https://github.com/albumentations-team/albumentations/pull/1637
- https://github.com/erxes/erxes/pull/5119
- https://github.com/mraniki/cefi/pull/433
- https://github.com/Quarticai/QuarticSDK/pull/358
- https://github.com/mraniki/cefi/pull/432
- https://github.com/tpaviot/pythonocc-core/pull/1311
- https://github.com/lightning-bot/Lightning/pull/144
- https://github.com/ignition-api/8.1/pull/265
- https://github.com/fairdataihub/fairdataihub.org/pull/616
- https://github.com/suttacentral/suttacentral/pull/3122
- https://github.com/jquagga/ttt/pull/30
- https://github.com/jquagga/ttt/pull/29
- https://github.com/Harrytimbog/Peer-Pal/pull/22
- https://github.com/bengosney/cerberus/pull/790
- https://github.com/Harrytimbog/Peer-Pal/pull/21
- https://github.com/mraniki/cefi/pull/431
- https://github.com/bengosney/cerberus/pull/789
- https://github.com/bengosney/cerberus/pull/788
- https://github.com/jmcerrejon/PiKISS/pull/214
- https://github.com/mraniki/dxsp/pull/613
- https://github.com/mraniki/cefi/pull/430
- https://github.com/mraniki/cefi/pull/429
- https://github.com/gdsfactory/gdsfactory/pull/2658
- https://github.com/Bilbottom/sql-learning-materials/pull/7
- https://github.com/mraniki/cefi/pull/428
- https://github.com/KonScanner/synthr-farming/pull/1
- https://github.com/rtk-rnjn/algorithms/pull/78
- https://github.com/malayilneil/lab04/pull/1
- https://github.com/nbhirud/system_update/pull/6
- https://github.com/mraniki/cefi/pull/427
- https://github.com/Kilo59/ruff-sync/pull/16
- https://github.com/jquagga/ttt/pull/27
- https://github.com/alexiusstrauss/CryptoTrendAnalyzer/pull/10
- https://github.com/jquagga/ttt/pull/25
- https://github.com/mraniki/tt/pull/1425
- https://github.com/albumentations-team/albumentations_stats/pull/1
- https://github.com/jquagga/ttt/pull/24
- https://github.com/jsugg/retry-on/pull/1
- https://github.com/strawberry-graphql/strawberry/pull/3442
- https://github.com/jquagga/ttt/pull/23
- https://github.com/jquagga/ttt/pull/22
- https://github.com/jquagga/ttt/pull/21
- https://github.com/jquagga/ttt/pull/20
- https://github.com/Kilo59/ruff-sync/pull/14
- https://github.com/jquagga/ttt/pull/19
- https://github.com/jquagga/ttt/pull/18
- https://github.com/jquagga/ttt/pull/17
- https://github.com/brendancsmith/diffbot-kg/pull/3
- https://github.com/2lambda123/StenaIT-stenajs-webui/pull/1
- https://github.com/jkool702/openwrt/pull/24
- https://github.com/KevinNitroG/VNULIB-Downloader/pull/28
- https://github.com/CPUT-DEVS/devpost-hackathon/pull/15
- https://github.com/code-Harsh247/FRSS-project/pull/34
- https://github.com/code-Harsh247/FRSS-project/pull/33
- https://github.com/kurianbenoy/samam-ml-verification/pull/1
- https://github.com/alexiusstrauss/CryptoTrendAnalyzer/pull/8
- https://github.com/mraniki/dxsp/pull/612
- https://github.com/alexiusstrauss/CryptoTrendAnalyzer/pull/7
- https://github.com/alexiusstrauss/CryptoTrendAnalyzer/pull/6
- https://github.com/neurodatascience/cohort_creator/pull/207
- https://github.com/albumentations-team/albumentations-demo/pull/12
- https://github.com/mraniki/cefi/pull/426
- https://github.com/alexiusstrauss/CryptoTrendAnalyzer/pull/5
- https://github.com/jkool702/openwrt/pull/23
- https://github.com/jkool702/openwrt/pull/22
- https://github.com/ynvtlmr/intergenerational-family-code/pull/108
- https://github.com/PythonFreeCourse/lms/pull/390
- https://github.com/jquagga/ttt/pull/16
- https://github.com/PythonFreeCourse/lms/pull/389
- https://github.com/PythonFreeCourse/lms/pull/389
- https://github.com/PythonFreeCourse/lms/pull/389
- https://github.com/jquagga/ttt/pull/13
- https://github.com/Speccy-Rom/Leetcode_aka_speccy-rom/pull/293
- https://github.com/Bilbottom/sql-learning-materials/pull/5
- https://github.com/mraniki/cefi/pull/425
- https://github.com/approvals/Approvals.NodeJS/pull/173
- https://github.com/gdsfactory/gdsfactory/pull/2657
- https://github.com/mraniki/tt/pull/1420
- https://github.com/vibikerski/trackingtasks/pull/2
- https://github.com/yaitoo/sqle/pull/30
- https://github.com/jquagga/ttt/pull/12
- https://github.com/Mesteriis/test-repo/pull/4
- https://github.com/Mesteriis/test-repo/pull/3
- https://github.com/Mesteriis/test-repo/pull/2
- https://github.com/Mesteriis/test-repo/pull/1
- https://github.com/letsdoitnowus/planium-backend/pull/34
- https://github.com/code-Harsh247/FRSS-project/pull/32
- https://github.com/letsdoitnowus/planium-backend/pull/33

# Questions to ask to label the review comments
review_comment_labels:
- label: correct
  question: Is this comment correct?
- label: helpful
  question: Is this comment helpful?
- label: comment-type
  question: Is the comment type correct?
- label: comment-area
  question: Is the comment area correct?

# Benchmark reviews generated by running
#   python -m scripts.experiment benchmark <experiment_name>
benchmark_reviews:
- dataset_pull_request: https://github.com/mraniki/iamlistening/pull/294
  review_pull_request: https://github.com/sourcery-ai-experiments/gplugins/pull/6
- dataset_pull_request: https://github.com/gdsfactory/gplugins/pull/373
  review_pull_request: https://github.com/sourcery-ai-experiments/fastembed-rs/pull/6
- dataset_pull_request: https://github.com/Anush008/fastembed-rs/pull/48
  review_pull_request: https://github.com/sourcery-ai-experiments/tt/pull/8
- dataset_pull_request: https://github.com/mraniki/tt/pull/1435
  review_pull_request: https://github.com/sourcery-ai-experiments/operator/pull/6
- dataset_pull_request: https://github.com/kloudlite/operator/pull/172
  review_pull_request: https://github.com/sourcery-ai-experiments/iamlistening/pull/17
- dataset_pull_request: https://github.com/mraniki/iamlistening/pull/293
  review_pull_request: https://github.com/sourcery-ai-experiments/iamlistening/pull/18
- dataset_pull_request: https://github.com/mraniki/iamlistening/pull/292
  review_pull_request: https://github.com/sourcery-ai-experiments/operator/pull/7
- dataset_pull_request: https://github.com/mraniki/cefi/pull/434
  review_pull_request: https://github.com/sourcery-ai-experiments/image-editor/pull/3
- dataset_pull_request: https://github.com/kloudlite/operator/pull/171
  review_pull_request: https://github.com/sourcery-ai-experiments/tt/pull/9
- dataset_pull_request: https://github.com/usama-maxenius/image-editor/pull/62
  review_pull_request: https://github.com/sourcery-ai-experiments/erxes/pull/29
- dataset_pull_request: https://github.com/mraniki/tt/pull/1434
  review_pull_request: https://github.com/sourcery-ai-experiments/cefi/pull/9
- dataset_pull_request: https://github.com/mraniki/dxsp/pull/614
  review_pull_request: https://github.com/sourcery-ai-experiments/QuarticSDK/pull/3
- dataset_pull_request: https://github.com/albumentations-team/albumentations/pull/1637
  review_pull_request: https://github.com/sourcery-ai-experiments/cefi/pull/10
- dataset_pull_request: https://github.com/erxes/erxes/pull/5119
  review_pull_request: https://github.com/sourcery-ai-experiments/pythonocc-core/pull/4
- dataset_pull_request: https://github.com/mraniki/cefi/pull/433
  review_pull_request: https://github.com/sourcery-ai-experiments/8.1/pull/4
- dataset_pull_request: https://github.com/Quarticai/QuarticSDK/pull/358
  review_pull_request: https://github.com/sourcery-ai-experiments/fairdataihub.org/pull/9
- dataset_pull_request: https://github.com/mraniki/cefi/pull/432
  review_pull_request: https://github.com/sourcery-ai-experiments/suttacentral/pull/3
- dataset_pull_request: https://github.com/tpaviot/pythonocc-core/pull/1311
  review_pull_request: https://github.com/sourcery-ai-experiments/ttt/pull/8
- dataset_pull_request: https://github.com/lightning-bot/Lightning/pull/144
  review_pull_request: https://github.com/sourcery-ai-experiments/cerberus/pull/2
- dataset_pull_request: https://github.com/ignition-api/8.1/pull/265
  review_pull_request: https://github.com/sourcery-ai-experiments/cefi/pull/11
- dataset_pull_request: https://github.com/fairdataihub/fairdataihub.org/pull/616
  review_pull_request: https://github.com/sourcery-ai-experiments/cerberus/pull/3
- dataset_pull_request: https://github.com/suttacentral/suttacentral/pull/3122
  review_pull_request: https://github.com/sourcery-ai-experiments/PiKISS/pull/2
- dataset_pull_request: https://github.com/jquagga/ttt/pull/30
  review_pull_request: https://github.com/sourcery-ai-experiments/dxsp/pull/6
- dataset_pull_request: https://github.com/jquagga/ttt/pull/29
  review_pull_request: https://github.com/sourcery-ai-experiments/cefi/pull/12
- dataset_pull_request: https://github.com/Harrytimbog/Peer-Pal/pull/22
  review_pull_request: https://github.com/sourcery-ai-experiments/Peer-Pal/pull/8
- dataset_pull_request: https://github.com/bengosney/cerberus/pull/790
  review_pull_request: https://github.com/sourcery-ai-experiments/cerberus/pull/5
- dataset_pull_request: https://github.com/Harrytimbog/Peer-Pal/pull/21
  review_pull_request: https://github.com/sourcery-ai-experiments/Peer-Pal/pull/9
- dataset_pull_request: https://github.com/mraniki/cefi/pull/431
  review_pull_request: https://github.com/sourcery-ai-experiments/cefi/pull/16
- dataset_pull_request: https://github.com/bengosney/cerberus/pull/789
  review_pull_request: https://github.com/sourcery-ai-experiments/cerberus/pull/6
- dataset_pull_request: https://github.com/bengosney/cerberus/pull/788
  review_pull_request: https://github.com/sourcery-ai-experiments/cerberus/pull/7
- dataset_pull_request: https://github.com/jmcerrejon/PiKISS/pull/214
  review_pull_request: https://github.com/sourcery-ai-experiments/PiKISS/pull/3
- dataset_pull_request: https://github.com/mraniki/dxsp/pull/613
  review_pull_request: https://github.com/sourcery-ai-experiments/dxsp/pull/7
- dataset_pull_request: https://github.com/mraniki/cefi/pull/430
  review_pull_request: https://github.com/sourcery-ai-experiments/cefi/pull/17
- dataset_pull_request: https://github.com/mraniki/cefi/pull/429
  review_pull_request: https://github.com/sourcery-ai-experiments/cefi/pull/18
- dataset_pull_request: https://github.com/gdsfactory/gdsfactory/pull/2658
  review_pull_request: https://github.com/sourcery-ai-experiments/gdsfactory/pull/2
- dataset_pull_request: https://github.com/Bilbottom/sql-learning-materials/pull/7
  review_pull_request: https://github.com/sourcery-ai-experiments/sql-learning-materials/pull/2
- dataset_pull_request: https://github.com/mraniki/cefi/pull/428
  review_pull_request: https://github.com/sourcery-ai-experiments/cefi/pull/19
- dataset_pull_request: https://github.com/KonScanner/synthr-farming/pull/1
  review_pull_request: https://github.com/sourcery-ai-experiments/synthr-farming/pull/2
- dataset_pull_request: https://github.com/rtk-rnjn/algorithms/pull/78
  review_pull_request: https://github.com/sourcery-ai-experiments/algorithms/pull/2
- dataset_pull_request: https://github.com/malayilneil/lab04/pull/1
  review_pull_request: https://github.com/sourcery-ai-experiments/lab04/pull/2
- dataset_pull_request: https://github.com/nbhirud/system_update/pull/6
  review_pull_request: https://github.com/sourcery-ai-experiments/system_update/pull/2
- dataset_pull_request: https://github.com/mraniki/cefi/pull/427
  review_pull_request: https://github.com/sourcery-ai-experiments/cefi/pull/20
- dataset_pull_request: https://github.com/Kilo59/ruff-sync/pull/16
  review_pull_request: https://github.com/sourcery-ai-experiments/ruff-sync/pull/4
- dataset_pull_request: https://github.com/jquagga/ttt/pull/27
  review_pull_request: https://github.com/sourcery-ai-experiments/ttt/pull/12


Update Webfont info

When we updated the web fonts, we forgot to update the README.md text.
Mentioned in https://github.com/google/roboto/issues/284#issue-294493813

Any reason why this hasn't been merged? Got confused by it myself

Thanks for the ping


Stronger fix for VsDevCmd

Use the environment variable, based on the suggestion from https://github.com/Microsoft/msbuild/pull/2938#issuecomment-362132587

@dotnet-bot test ci please

@dotnet-bot test ci please


chore: set headless: "new" to puppeteer

  Puppeteer old Headless deprecation warning:
    In the near feature `headless: true` will default to the new Headless mode
    for Chrome instead of the old Headless implementation. For more
    information, please see https://developer.chrome.com/articles/new-headless/.
    Consider opting in early by passing `headless: "new"` to `puppeteer.launch()`
    If you encounter any bugs, please report them to https://github.com/puppeteer/puppeteer/issues/new/choose.

https://developer.chrome.com/docs/chromium/new-headless?hl=ja

This report was generated by comparing d18bf51 with 7f8fb1f.
If you would like to check difference, please check here.

ArtifactName: reg

item
count

pass
3

change
3

new
0

delete
0

📝 Report
Differences
BlogPostSample-1-chromium-linux.png

actual

expected

difference

BlogPostSample-1-firefox-linux.png

actual

expected

difference

BlogPostSample-1-webkit-linux.png

actual

expected

difference


get a "500 Internal Server Error" after Update to 1.2.18

Hi, get a "500 Internal Server Error" and blank page after Update to 1.2.18 following the rules  on https://typemill.net/getting-started/update
My page: https://hotdocs.carsten-nichte.de
All Folders are 775 or 774...
??? No idea how to get rid of this. Any Idea?
vg Carsten

You can activate the error reporting. Open the settings.yaml file in settings folder (or create it if it does not exist) and add this line:
displayErrorDetails: true
Then go to the page and post the error message here.
You could also check the error logs on your server.

Hi, "displayErrorDetails: true" displays nothing - all I got is a blank page an the "500 Internal Server Error", unfortunately I have no access to the server logs at my provider, and php logging is disabled either.
I created an info.php in the root folder, and the phpinfo showed up... don't know if this is a good sign.
Tomorrow I will set up typemill on my local apache, to test the stuff, perhaps that gives me a hint what's going wrong...

on my local server I got an error:
Warning: require_once(/Users/cnichte/Apache2-www/typemill web/system/vendor/composer/autoload_real.php): failed to open stream: No such file or directory in /Users/cnichte/Apache2-www/typemill-web/system/vendor/autoload.php on line 5
he missed the composer folder.  So I followed the manual-path:
git clone "https://github.com/trendschau/typemill.git" composer` update
All folders appear. Copied my content, media an setting folders.... and all worked fine on my local server.
I copied the whole stuff to my domain, and all I get is a blank site :-/
My Webseite: https://hotdocs.carsten-nichte.de
even with https://hotdocs.carsten-nichte.de/setup/ or with https://hotdocs.carsten-nichte.de/index.php
The virtual host is connected to the webspace, so info.php shows up:
https://docs.carsten-nichte.de/info.php
I am a  little clueless at the moment - localhost works - webspace don't work... any ideas?

If it works locally, then the reason is your live environment.
Please follow the documentation on typemill.net (system requirements and installation hints), make sure that you meet the system requirements and that you set the correct rights to the folders and files as described there.
From the first view, I cannot find any module in your phpinfo on your live server, looks like you do not have mod_rewrite enabled, you also have to allow htaccess on your server.
In case of trouble you should contact your hoster and ask him how to enable it.
I hope this helps...


Unknow reference system for GPS data

Good day!
I am trying out Ahmed's algorithm using example data from your repository and some other data from other sources. However, I cannot identify which spatial reference system is used in, for example, tracks in Athens example. Due to it, I cannot visualize it correctly.
I have also tried the algorithm on GPS data from Saint Petersburg, converted into UTM 35N reference system. But then I try to visualize resulted graph in the same reference system, it is hugely misplaced.
Could you please give me some insight on which SRID I should use in order to get valid road graph?

I did not look into the algorithms, but for anyone like me who wants to use the data and needs the coordinate reference systems, it looks like they are:
crss = {
"berlin": "EPSG:32633",    # WGS 84 / UTM zone 33N
"athen": "EPSG:2100",      # GGRS87 / Greek Grid
"chicago": "EPSG:26716", # NAD27 / UTM zone 16N
}


Disable GPU on ARM builds

Apparently in Electron >0.13, the test is not correctly rendered on ARM.
One thing that seems to work around this issue is disabling the GPU but we should verify whether a recent electron update also solves it.

Fixed by #999


Add support twitter preview link

meta_image is a good option for link preview, it could be better if preview link support twitter
twitter has particular meta tags for it
I think socialsharepreview could be helpful
thanks :+1:

Ok, I'll check about it👍

Wow, the social share preview is a good tool to test with.
I added some twitter meta tags. Check if it is what you expected

nice, preview ink improved.:1st_place_medal:
thank you so much


Cobalt Storage v3

more for cobalt.storage

[ ] add cobalt.sessionStorage or expiry to keys
[ ] use a real bdd for iOS
[ ] enable storage access from Android
[ ] enable storage access from iOS
[ ] possibility to use your own database system on Android
[ ] possibility to use your own database system on iOS
[ ] update documentation Android
[ ] update documentation iOS
[ ] update documentation Web

Will not be implemented


canDeactivate executes while routing to routes guarded with canActivateChild

Hi all the below is my route
export const ROUTES: Routes = [   { path: '',  redirectTo:'signin' ,pathMatch: 'full' },   { path: 'signin', component: SigninComponent ,canDeactivate: [AuthGuard] },   { path: 'dashboard',      canActivateChild: [AuthGuard],     component: DashboardComponent,     children: [       { path: 'category/:id', component: CategoryViewComponent },       { path: 'category', component: CategoryListComponent },       { path: '',redirectTo:'category', component: CategoryListComponent }     ]    } ];
whenever i navigate to /dashboard the canDeactivate executes executes , it should not execute right ? because i am navigating to different route unrelated to signin

This repository is for Angular 1.x. The Angular 2 repo is over there.


Minify_HTML + IE8 "Internet Explorer cannot display the webpage"

Minify version: 2.1.2
PHP version: 5.2.6

What steps will reproduce the problem?
1. Copy source code from http://www.deafzone.ch/
2. Minify it with the HTML minifier only.
3. Load it in Internet Explorer 8.0 et volià the message "Internet Explorer
cannot display the webpage".

When commenting out these lines in the class Minify_HTML
Line 65: $this->_html = str_replace("\r\n", "\n", trim($html));
Line 123: $this->_html = preg_replace('/^\\s+|\\s+$/m', '', $this->_html);

Then it'll works.

By the way, you aren't trimming tabulators, please also add the \t in your
logic.

Thanks.

Michael H.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 1 May 2009 at 3:26

Oh, for the tab problem, I used another source code, from
www.bonauer-architekten.ch:
The part for the SWFObject beginning with var flashvars=false; contains tabs
which
aren't removed.

Thanks for the examination!

Michael

Original comment by<EMAIL_ADDRESS>on 2 May 2009 at 2:18

Michael, Can you still verify this bug exists in Minify 2.1.3? The lines you
commented
out just remove whitespace and convert line endings.

Original comment by<EMAIL_ADDRESS>on 9 May 2010 at 3:43

Changed state: NeedInfo
Added labels: Priority-Low
Removed labels: Priority-Critical

I just added in R326 a tool to test Minify_HTML output in the browser. At first
inspection, Minify_HTML output of your home page source validates and displays
in
Opera, but I'll test this in very IE8 soon.

Re: tabs, can you give me a specific piece of markup from which tabs aren't
removed?

Original comment by<EMAIL_ADDRESS>on 1 May 2009 at 5:21

Changed title: Minify_HTML + IE8 "Internet Explorer cannot display the webpage"
Changed state: Accepted
Added labels: Priority-Critical
Removed labels: Priority-Medium

Thanks for asking but I am afraid I reported the bug 1 year ago. A lot has
changed
since then, i.E. we're using something else and now I am unable to reproduce
that.

But you can copy the HTML code of www.deafzone.ch and test this yourself.

Cheers

Michael

Original comment by<EMAIL_ADDRESS>on 10 May 2010 at 3:34


fix: define lib export

Summary

Add /lib/* export filed in package.json.
This exists in webpack and there are hundred of projects import from there.
Checklist

[ ] Tests updated (or not required).
[ ] Documentation updated (or not required).

Yes, I know it is recommended to use the provided webpack instance, but if then rspack is not theoretically 100% compatible with the original webpack.
I was trying out the Nuxt rspack builder, and the fork-ts-checker-webpack-plugin package, which import from webpack directly, throw a module not found error. I tried to fix it by adding "webpack": "npm:@rspack/core@latest", and the error this time is  subpath ./lib/RequestShortener not defined in the exports field in package.json.

Rspack does not provide dist/lib/* files and we have no plans to be compatible with it.
The lib folder contains a lot of private webpack modules that should not be used. Plugin authors should use webpack.* instead.

For fork-ts-checker-webpack-plugin:

https://rspack.dev/guide/migration/webpack#installing-rspack

As for what you say, it is true that importing and using private modules isn't good, but there are lots of plugins working that way so fixing each one is impossible.
As for installing webpack as a workaround, it does solve the issue but it's quite inconvenient for users imo.

Although Rspack is committed to maintaining compatibility with the webpack ecosystem, it is obviously not possible to support all webpack plugins. For plugins that use internal webpack paths, we will work with the community to refactor the code for these plugins.
This PR will be closed, thank you.


TFServing docs needed to be updated for 0.6

The docs here
https://www.kubeflow.org/docs/components/serving/tfserving_new/
Still reference ksonnet.
The updated docs should just include sample YAML for a Deployment using TFServing that people can copy and paste.
/cc @ellis-bigelow @lluunn

/project ksonnet-turndown

/assign @lluunn

@lluunn Any plans to pick this up this week?


Doctrine 2.4.8: AbstractManagerRegistry::resetManager() not working as expected

When an entity manager is closed I am supposed to get a new working entity manager by calling AbstractManagerRegistry::resetManager() (according to the documentation of ManagerRegistry::resetManager()). However, this does not seem to work.
Example (run out of a container aware Symfony command):
$doctrine = $this->getContainer()->get('doctrine');
$em = $doctrine->getManager();
$em->close();
$em = $doctrine->resetManager();
if (!$em->isOpen()) {
  echo "Entity Manger is still closed\n";
}

This will always print out: "Entity Manger is still closed".
This was tested using PHP 7.0, MySQL 5.7 using doctrine/orm 2.4.8, doctrine/dbal 2.4.5, pdo_mysql and Symfony 2.8.14.

@sandrinr is this an ORM issue, or a doctrine/common or doctrine/doctrine-bundle issue?

@Ocramius I actually don't know exactly. The AbstractManagerRegistry class is part of doctrine/common. The used doctrine/common version during the test above is 2.7.1.

The AbstractManagerRegistry#resetManager basically calls the resetService method and retrieves the manager with the same name after that.
The resetService method is implemented in the doctrine bridge of Symfony, so it seems to be a Symfony issue, so it seems to be a problem with Symfony.


Can this code also include downloading the json files?

What exactly do you mean, the json file? Do you mean the JSON surrounding each individual NFT?

Yea. The individual json files associated with each images.

I mean evey image will have an associated json like what you have described above. Can that also be downloaded?

All done. The program will now create a subfolder called image_data. Inside this, it will create numbered json files (i.e. 5620.json) corresponding to its respective NFT.

Thanks


ttyd client/server

ttyd should have two additional modes of operation:
ttyd client:
redirects the terminal TO a remote websocket
ttyd server:
serves the htmp of the terminal and listens for websocket connections
so on Machine A:
[ttyd] --server https://remotemachine/randomnumber bash -c "echo hello world"
on Machine B
[ttyd] --broker
And finally Machine C: browser: https://machineB/randomnuberOfBefore

At the moment the same can be done using ltunnel but ltunnel is heavy and the server source code is horrible.

probably socat can be used too or even websocat but it would be great if everything was in the neat code of ttyd

To better clarify what I meant, I made a proof of concept in nodejs (but the terminal is pretty dumb and lacks many functions).
This works pretty well but I would rather have the same solution in C language like ttyd is and with a better terminal support.
Try it out: https://tjs-1.zibri.repl.co/

Improved version, encrypted and with a shell client too:
https://wshell.zibri.repl.co

Why not just using a web server like nginx on Machine B to proxy ttyd's traffic to Machine A?

Why not just using a web server like nginx on Machine B to proxy ttyd's traffic to Machine A?

care to show an example configuration? I never tried it.
anyway now I am rewriting wshell to use socket.io which seems more solid.
P.S.
I remind you that both machine A and machine C,D;E;F can't be reached and only machine B can be reached by all of them and can't reach any of them.

@tsl0922 just fyi I finished the rewrite. now the code is even simpler.
You can check it here: https://github.com/Zibri/wshell2
Or directly use it here: https://wshell2.zibri.repl.co
P.S.
if you uncomment the last line of "server.js" it will behave similarly to ttyd (offering a local shell).
on the github page there is a button that allows you to automatically deploy it on replit.

@tsl0922 what I meant is that a solution like mine uses almost the same CPU as ttyd but it also uses about 10 times the RAM and anyway relies on node. It would be great to have the same functionality in ttyd. If you like to chat about it I can give you some quick hints, I tried to look at ttyd code to implement it myself and the suggest it but it's a little too complicated for me to do that at this moment.

@Zibri You may want to try https://github.com/zhaojh329/rtty

@Zibri You may want to try https://github.com/zhaojh329/rtty

I know it. Yes, the concept is similar, but please, check my "example" code: https://github.com/Zibri/wshell2
It's lighter and simpler and uses a single port on the server.
I will soon add a few more options but the core is there.
I always preferred ttyd to any other because of it's monolithic nature and very light (on memory and cpu) server.
I am just suggesting you to add a "server" mode to ttyd so that it can be used like wshell2 without any other proxy/middleware or bloated package which usually needs resources and ports.

I'm looking the same function and to solve this issue, I use configurable-http-proxy (CHP) on the public server and ttyd on the internal server. If B has public access and A, C, D and, E are internal server, then :

On Machine B, you creates a route (in CHP) machineA -> ws:IP_MachineA:5000 (curl -X POST http://localhost:8001/api/routes/machineA -d '{"target":"ws://IP_MachineA:5000/"}')
On Machine A, ttyd -b /machineA -p 5000 bash -c "echo hello world"

So, in a navigator, http://IP_MachineB/machineA will be redirect to the ttyd of machineA
And so on, for each machine C, D, E


Add reinstall_cluster playbook

Since the get_ocp role refreshes ignitions already, the clean_ocp_rhcos_inst_files role is not needed.
And since the reinstall_nodes playbook that Klaus added didn't refresh the ignitions, as would be needed if the cluster was over 24 hours old, I combined these two ideas into a new playbook reinstall_cluster.yaml.
I also updated the docs. I think having the 5.1 playbook in the middle of the required playbooks for installation is a bit confusing, so I created a new section for additional playbooks and added this and the other playbooks there.
I hope this all makes sense and is ok by you @AmadeusPodvratnik! This capability was needed, and this was a great way to re-visit it.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add time_limit to presolve

I have only implemented a time_limit for the presolve() methods for now. In the future we might also want to add it to the apply() methods.
Closes https://github.com/dwavesystems/dwave-preprocessing/issues/79

Right now tests show the time_limit is quite loose. I am working on some changes to improve it, but those don't change this implementation.

Just noticed I need to update the .pyi file, will do


Improve installation documentation

Hi,
I wanted to try this project and run it locally to test it.
However, the docs could be improved.
I see mentions of Docker, but I could not find the docker container for this project, other than the docker-compose, and running composer inside some docker container, but that didn't contain the docker container for the personal-management-system. Does a docker container for this project exist?
Also, it is unclear if only Linux is supported. I don't see anything about windows/mac. Is it not supported? Perhaps it's good to say that in the docs that only Linux is supported.
On what port does the project run after installing? Perhaps it's also worth mentioning in the docs/readme.
Also, perhaps it would be nice to use the GitHub wiki with short URLs to installation, removal, security etc...

Hello,
There is a docker-compose which works with windows composer and under Linux (I've tested this in both cases).

Improving installation documentation: this needs to wait as I got other priority for now,

also I have a plan to create just one-time docker script which will trigger all the things needed to do with docker but again it has to wait,

Installation: this is also in plan (installer like WordPress has step-by-step via GUI)
Support for windows: partially (it generally works) but there is a problem with file upload/management which I'm aware of (someone reported it for me) - like above no time for now,

else other modules work fine on windows,
on Linux it works without issues (this is how i use it),

Github Wiki - not doing it, this is why I created a documentation,

So pretty much the installation improvement / bugs for windows - I'm aware of them all, but I need to prioritize things as I'm working on this on my own.

If You have an issue with installation - then let me know where / on which step.

Closing due to missing information regarding the:

If You have an issue with installation - then let me know where / on which step.


Request: .to and .not_to in Ruby

Hi,
When editing tests one quite often needs to flip between .to and .not_to (or .to_not) in RSpec tests (ft=ruby).
Also be_truthy and be_falsey similar to true and false.
Can this be added? Thanks.

This makes a lot of sense, although I'm not sure if we should switch to .not_to or .to_not :). Maybe I'll add an option or something, seems like something that's likely to be a global preference.

Oh come on, that's not important, just choose what you like best and stick with it.

Maybe :).
Seems like there's a different problem, though. I've already made a pattern for expect(foo).to eq bar. If you switch on the expect, it'll work just fine. I think it's a problem with the "tap" pattern taking precedence... Thinking about it, that one has pretty much never been really useful for me, so I'm wondering if I shouldn't just drop it from the plugin.
I'll think about it for a bit and figure something out.

I tried to do it many times, but it never occurred to me to try it on expect, especially considering that expect can easily span multiple lines. I was always trying it on .to, .not_to and .to_not.

Yeah, and that makes sense -- the expect variant is actually just the simple one-line form, so I should probably consider just doing something for to and to_not instead.

I've implemented this in master. I've settled on not_to, since it feels more readable to me :). Of course, switching on a to_not also works, turns it into to.
Could you try it out and let me know how it works?

Yep, looks like it. Thanks!