Add improved morphology metrics to default output

Is your feature request related to a problem? Please describe.
The current cell_data file contains only a subset of the features we've found to be useful.
Describe the solution you'd like
There are two things that need to be accomplished.

The first, relatively easy one, is to change the default properties passed to regionprops so that all of them are included in the final csv. These should include the following:

props = ['label', 'area',   'major_axis_length', 'minor_axis_length',
             'perimeter', 'centroid', 'convex_area',
             'equivalent_diameter']

In addition, there are some custom values which can be computed from the regionprops values which we also want present in the final csv. This will require a couple lines of code once the regionprops values have been computed. These are the following:
cell_data['major_minor_axis_ratio'] = cell_data['major_axis_length'] / cell_data['minor_axis_length']
cell_data['perim_square_over_area'] = np.square(cell_data['perimeter']) / cell_data['area']
cell_data['major_axis_equiv_diam_ratio'] = cell_data['major_axis_length'] / cluster_df_selected['equivalent_diameter']
cell_data['convex_hull_resid'] = (cell_data['convex_area'] - cell_data['area']) / cell_data['convex_area']
cell_data['nc_ratio'] = cell_data['area_nuclear'] / cell_data['area']

The second thing that needs to be accomplished is adding in additional morphology metrics which are not simple combinations of skimage functions. The way I currently have this set up is that I run a separate skimage.regionprops call, and iterate over each object returned to compute these metrics. However, this for loop isn't super fast. It looks like the newest version of skimage includes an "extra_properties" argument to regionprops, which allows user-defined functions to be passed in and evaluated. This doesn't speed up the actual function I wrote, which is still slow, but it does help with the for loop aspect. However, this new version isn't compatible with some of our other packages I think.

concavity_count = []
centroid_dif = []
updated_id = []

for fov in np.unique(cell_data['point']):
    current_label = segmentation_labels_selected.loc[fov, :, :, 'whole_cell'].values

    current_props = regionprops(current_label)

    for prop in current_props:
        # cell centroid shift
        cell_image = prop.image
        convex_image = prop.convex_image
        cell_M = skimage.measure.moments(cell_image)
        cell_centroid = cell_M[1, 0] / cell_M[0, 0], cell_M[0, 1] / cell_M[0, 0]

        convex_M = skimage.measure.moments(convex_image)
        convex_centroid = convex_M[1, 0] / convex_M[0, 0], convex_M[0, 1] / convex_M[0, 0]

        centroid_dist = np.sqrt((cell_centroid[1] - convex_centroid[1]) ** 2 +
                                (cell_centroid[0] - convex_centroid[0]) ** 2)

        centroid_dist /= np.sqrt(prop.area)

        # number of concavities
        diff_img = convex_image ^ cell_image
        if np.sum(diff_img) > 0:
            labeled_diff_img = label(diff_img)
            hull_prop_df = pd.DataFrame(regionprops_table(labeled_diff_img, properties=['area', 'perimeter']))
            hull_prop_df['compactness'] = np.square(hull_prop_df['perimeter']) / hull_prop_df['area']
            small_idx = np.logical_and(hull_prop_df['area'] > 10,
                                       hull_prop_df['compactness'] < 60)
            large_idx = hull_prop_df['area'] > 150
            combined_idx = np.logical_or(small_idx, large_idx)

            concavities = np.sum(combined_idx)
        else:
            concavities = 0

        concavity_count.append(concavities)
        centroid_dif.append(centroid_dist)
        updated_id.append(fov + '_' + str(prop.label))

new_df = pd.DataFrame({'unique_id': updated_id,
                       'concavity_count': concavity_count,
                       'centroid_dif': centroid_dif})

cell_data = cell_data.merge(new_df)

In addition, we should update the description of the cell table to include all of the column names and what they represent

In addition, we should update the description of the cell table to include all of the column names and what they represent

@ngreenwald about the second point, are cell centroid shift and # concavities the only metrics we need for now, or will there be others Dunja will require?

@ngreenwald about the second point, are cell centroid shift and # concavities the only metrics we need for now, or will there be others Dunja will require?

Right now these are the only ones Mike and I have thought about. In the future, we might want to add more. Either way, further modularizing the code to support future metrics would be good.

Right now these are the only ones Mike and I have thought about. In the future, we might want to add more. Either way, further modularizing the code to support future metrics would be good.


nginx - proxy_set_header analysis - AI

Use these corrections suggested by chatgpt -
proxy_set_header Upgrade $http_upgrade;
proxy_set_header Connection "upgrade";
proxy_set_header Host $host;
proxy_cache_bypass $http_upgrade;


update FieldnameBehaviorTest.ts:35 to use a binary writer

Binary writer now has sufficient usage in test suite; this issue is no longer relevant


AndroidSdkUpdate 1.0.0

AndroidSdkUpdate step

Thanks @guitcastro - as this is a new step we'll have a more thorough look tomorrow, after the first look it looks good ;)

First of all thank you for the PR & contribution, we really value it a lot! There are just a couple of things which should be changed, and other which we thought would be a nice addition / revision.
Suggested changes:

you should change the step ID from AndroidSdkUpdate to a lowercase ID, like android-sdk-update, as that's how the other step IDs look like, and for someone who works with the bitrise.yml directly following another ID naming convention will be confusing
there's a typo here in the default value: https://github.com/guitcastro/steps-update-sdk/blob/master/step.yml#L42 - lasted should be latest
your README is for the old StepLib, you should use a newer text like the one here: https://github.com/bitrise-io/bitrise/blob/master/_step_template/README.md - especially because the Step sharing works differently now than it did for the old StepLib
If possible you should check the parameters individually, whether a given filter is already installed. The problem with not checking it is that even if it's already installed, Android will try to re-install it, which might take a long time. There's an additional issue related to Docker: if a tool is already installed Android will try to create a backup copy with a symlink type which is not supported by docker, and so it'll always fail.

Other notes & comments:

you can remove the bash_utils folder as you don't use it
what does the tools  input do? ( https://github.com/guitcastro/steps-update-sdk/blob/master/step.yml#L23 ) turning it off could be the same as not providing any build_tools, just change is_required: true to false ( https://github.com/guitcastro/steps-update-sdk/blob/master/step.yml#L49 ) and handle this case in the code, and you should be able to remove the tools input. Less input is always preferred :)
similarly you could change the system_images: "none" input to is_required: false and handle the empty input the way you handle "none" right now. Less typing, smaller chance for typos ;)

Most of these are just minor things, but please consider all of the points, as it would improve the experience of using your step!
Happy building! 😊

Ohh, there's another minor typo here: https://github.com/guitcastro/steps-update-sdk/blob/master/step.yml#L37 - version if Android should be version of Android

Hi viktorbenei,
Thanks for the feedback! I made all the possible changes that you suggested.
Here are some notes about the ones I couldn't do:
"If possible you should check the parameters individually, whether a given filter is already installed. The problem with not checking it is that even if it's already installed, Android will try to re-install it, which might take a long time. There's an additional issue related to Docker: if a tool is already installed Android will try to create a backup copy with a symlink type which is not supported by docker, and so it'll always fail."

I agree with you, check if the package is already installed will be awesome, but I couldn't find out how to check this.

"what does the tools input do?"

The tools input is to update the Android SDK Manager itself. Not related to any version of the Android, the executables locate in the tools folder in the SDK.

hi @guitcastro - just a heads up, we didn't forget about your PR but we're searching for a solution to either check whether a tool is already installed, and/or to solve the Docker file system issue.
So far it seems that there's no built in way to get all the pre-installed tools; the best solution seems to be to just check the related directories in the Android SDK directory.

Did you try to look at se souce code of the Android Studio or the SDK Manager ? They do that.
I will try to look at it, I Just need some free time.

Based on what we found Googling around the web it seems that the SDK Manager does exactly that, it just parses the Android SDK home directories. It's mentioned that you can even install new packages just by downloading the package an placing it to the appropriate directory, and the SDK Manager will detect it correctly.

Sorry for the long delay, we just wanted to get this right.
So, it seems that the only way you can check whether a tool is installed is indeed to check the related folder. You can implement this logic, as it'll speed up the whole process/step in case the package is already installed.
That said we switched the filesystem driver from the Docker's default Aufs to btrfs, which will not fail the way aufs does when an android package is already installed. We're still testing the new setup, so far it seems that it'll solve the issue reliably.
We'll keep testing the system during the weekend, and if everything's ok we'll merge your step on Monday.

Bit of info about the Android SDK folder structure:
On OS X the SDK "root" is ~/~/Library/Android/sdk, on Linux there's no canonical place, you just uncompress it somewhere. As a best practice, on bitrise.io images/VMs this location is stored in the $ANDROID_HOME environment. Your should add an input, with a default value $ANDROID_HOME, to get this location.
Once you have the root path the subfolder structure is the same on Linux & OS X:
$ tree -L 1 $ANDROID_HOME

/opt/android-sdk-linux
├── add-ons
├── build-tools
├── extras
├── platforms
├── platform-tools
├── SDK Readme.txt
├── system-images
├── temp
└── tools

If you want to check whether a build tool version is installed you can just check the directories in  $ANDROID_HOME/build-tools, it looks like this:
$ tree -L 1 $ANDROID_HOME/build-tools

/opt/android-sdk-linux/build-tools
├── 17.0.0
├── 19.1.0
├── 20.0.0
├── 21.1.2
├── 22.0.1
└── 23.0.2

So, if you want to check whether the 22.0.1 build-tool is installed you can just check whether the path $ANDROID_HOME/build-tools/22.0.1 exists / is directory.
Other packages might be a bit more complicated, but the basics are the same. For example, if you want to check whether a system image is installed you can check the $ANDROID_HOME/system-images/android-VERSION/default/IMAGE-NAME directory.
This is how a system image directory looks like (in this case for android-15):
$ tree -L 3 $ANDROID_HOME/system-images/android-15/

/opt/android-sdk-linux/system-images/android-15/
└── default
    └── armeabi-v7a
        ├── build.prop
        ├── kernel-qemu
        ├── NOTICE.txt
        ├── ramdisk.img
        ├── source.properties
        ├── system.img
        └── userdata.img

tree can be a really useful tool to quickly scan through the structure on your own Mac/PC. With the -L flag you can control the maximum level of dirs it prints, and tree can be installed with brew install tree or on Ubuntu/Debian apt-get install tree.
For reference this is how the whole system-images directory is structured (these are the pre-installed version on bitrise.io at the moment):
tree -L 3 $ANDROID_HOME/system-images
/opt/android-sdk-linux/system-images
├── android-15
│   └── default
│       └── armeabi-v7a
├── android-17
│   └── default
│       └── armeabi-v7a
├── android-19
│   └── default
│       └── armeabi-v7a
├── android-21
│   └── default
│       └── armeabi-v7a
├── android-22
│   └── default
│       └── armeabi-v7a
└── android-23
    └── default
        └── armeabi-v7a

That's wonderful Viktor,
I am a bit out of time until nov 30 (to finish my dissertation), but I will try to update the step ASAP with your solution ;)

Sure, no problem at all, we'll keep testing the Android system too, so far everything seems to be working so there's nothing to stop us from accepting the step in it's current state; we just have to wait for the final results, whether we can keep using the current solutions (file system).


App is not installing due certificate issue

Hello! I've downloaded latest release of the app, but there a certificate issue. Certificate is outdated. Please re-create a package with a valid certificate.

Have a new build created just having internet problems that should be resolved by tomorrow

Can you release it?

@BaRRaKudaRain   Released new version(1.2.5 i acccidentallly put in the incorrect version numbers) I  will leave this ticket open until you confirm it allows you to install

Installed. All works. No more certificate issue. Thank you!


what exactly does SQLALCHEMY_TRACK_MODIFICATIONS do?

what exactly does SQLALCHEMY_TRACK_MODIFICATIONS do i'm a bit confused as to why this is needed to be set inside my configuration?
is this tracking sqlalchemy? or flask sqlalchemy?

http://flask-sqlalchemy.pocoo.org/2.1/signals/

For future searchers:
http://stackoverflow.com/questions/33738467/sqlalchemy-who-needs-sqlalchemy-track-modifications/33790196#33790196
@davidism You understand this issue better than I do, so if I'm incorrect on anything, feel free to edit my answer.

Is there a way for us to detect which 3rd party packages are affected because of this change?
So far I think one of these is Flask-WhooshAlchemy

thanks


[Feature Request]: Add hcf calculator

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
a calculator to find hcf of two numbers .
Use Case
we can find hcf of 2 numbers
Benefits
we can find hcf of 2 numbers
Add ScreenShots

Priority
Medium
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[ ] I'm a SSOC'24 contributor
[X] I have starred the repository

@heysagnik @apu52 @anuragverma108 please assign me this issue

@ANKeshri you can't add new projects, rather contribute to existing projects

@ANKeshri you can't add new projects, rather contribute to existing projects

sure thank you


Add additional recorded device samples

Actually I forgot about https://github.com/etingof/snmpsim-data and I see you have added some of these already.

Hey @timlegge,
i merged the pull request on inexio/snmpsim the fork where we try to maintain the snmpsim for the community as much as we can, so as you got any questions write me or open an issue on this forked Repo.
Whether you want to get to the snmplabs docu that is sadly not available anymore on the original site you can look at our website, we tried to recover what we could recover. Link is here.

Thanks @Lostboi any idea what happened to @etingof

@timlegge no we´ve heart nothing from him for a long time, since he has no activity on his github. We´ve tried to contact him very often and sadly he didnt answer.
We are hoping that he´s coming back one day, that he could finish what he has started with the whole snmpsim community, but as long as he is inactive we are trying to maintain snmpsim and the dependent projects.

Unfortunately it looks like @etingof has passed away https://twitter.com/ChristianHeimes/status/1561680873551970311


Databus service name

Databus service container name is still "ie_databus" this imho deprecated.

Thanks for the feedback, where exactly did you found the legacy databus service name, could you please provide the section/ link.

My fault, I forgot to mention, where...
https://github.com/industrial-edge/Developer-Guide-Hands-on-App/blob/3d8c1bced13c486ddf80bbd926145b75d2ba84a2/src/solution/mqtt_broker_mosquitto/docker-compose.yml#L11
I think this should be "ie-databus " otherwise the connection to mqtt service fails somwhere here:
https://github.com/industrial-edge/Developer-Guide-Hands-on-App/blob/3d8c1bced13c486ddf80bbd926145b75d2ba84a2/src/solution/my_edge_app/data-analytics/program/data_analytics.py#L123


Uncaught TypeError: Cannot read property 'position' of undefined

[Enter steps to reproduce below:]

...
...

Atom Version: 0.176.0
System: Mac OS X 10.9.5
Thrown From: git-log package, v0.2.0
Stack Trace
Uncaught TypeError: Cannot read property 'position' of undefined
At /Users/yriveiro/.atom/packages/git-log/lib/gitgraph.js:185

TypeError: Cannot read property 'position' of undefined
  at GitGraph.lines (/Users/yriveiro/.atom/packages/git-log/lib/gitgraph.js:185:27)
  at GitGraph.render (/Users/yriveiro/.atom/packages/git-log/lib/gitgraph.js:214:27)
  at new GitGraph (/Users/yriveiro/.atom/packages/git-log/lib/gitgraph.js:17:20)
  at GitLogView.parser (/Users/yriveiro/.atom/packages/git-log/lib/git-log-view.js:82:17)
  at GitLogView.log_callback (/Users/yriveiro/.atom/packages/git-log/lib/git-log-view.js:63:10)
  at /Users/yriveiro/.atom/packages/git-log/lib/git-log-view.js:45:18
  at BufferedProcess.triggerExitCallback (/Applications/Atom.app/Contents/Resources/app/src/buffered-process.js:63:47)
  at ChildProcess.<anonymous> (/Applications/Atom.app/Contents/Resources/app/src/buffered-process.js:85:18)
  at ChildProcess.emit (events.js:110:17)
  at Process.ChildProcess._handle.onexit (child_process.js:1068:12)

Commands
  3x -1:04.8 core:backspace (atom-text-editor.editor.mini)
     -1:04.0 core:move-down (atom-text-editor.editor.mini)
     -1:03.5 core:confirm (atom-text-editor.editor.mini)
     -1:03.2 git-history:show-file-history (ol.tree-view.full-menu.list-tree.has-collapsable-children.focusable-panel)
  2x -0:57.6 core:move-down (ol.tree-view.full-menu.list-tree.has-collapsable-children.focusable-panel)
  2x -0:57.0 core:move-up (ol.tree-view.full-menu.list-tree.has-collapsable-children.focusable-panel)
     -0:54.3 command-palette:toggle (atom-text-editor.editor.vim-mode.command-mode.is-focused)
     -0:50.8 core:confirm (atom-text-editor.editor.mini)
     -0:50.8 git-log:show (atom-text-editor.editor.vim-mode.command-mode.is-focused)
     -0:42.4 command-palette:toggle (atom-text-editor.editor.vim-mode.command-mode.is-focused)
     -0:40.7 core:backspace (atom-text-editor.editor.mini)
  5x -0:38.4 core:move-down (atom-text-editor.editor.mini)
     -0:37.2 core:confirm (atom-text-editor.editor.mini)
     -0:37.1 git-history:show-file-history (atom-text-editor.editor.vim-mode.command-mode.is-focused)
  2x -0:35.1 core:move-down (atom-text-editor.editor.mini)
     -0:34.3 core:confirm (atom-text-editor.editor.mini)

Config
{
  "core": {
    "followSymlinks": true,
    "disabledPackages": [
      "emmet",
      "autocomplete",
      "go-plus",
      "Zen",
      "autocomplete-plus"
    ],
    "themes": [
      "atom-dark-ui",
      "seti-syntax"
    ],
    "projectHome": "/Users/yriveiro/Development/github"
  }
}

Installed Packages
# User
Atom-Syntax-highlighting-for-Sass, v0.5.0
atom-cli-diff, v0.6.4
atom-jshint, v1.5.0
atom-lint, v0.20.1
autocomplete-paths, v0.9.1
autocomplete-plus, v1.1.0
autocomplete-plus-async, v0.22.0
autocomplete-snippets, v0.3.2
color-picker, v1.4.4
docblockr, v0.5.8
editor-stats, v0.16.0
file-icons, v1.4.8
git-history, v1.2.0
git-log, v0.2.0
git-tab-status, v1.5.3
language-jade, v0.3.0
linter, v0.10.1
linter-php, v0.0.11
minimap, v3.5.6
minimap-find-and-replace, v3.1.0
minimap-git-diff, v3.1.1
omni-ruler, v0.3.1
phpunit, v1.0.9
phpunit-snippets, v0.1.0
pretty-json, v0.3.2
script, v2.16.0
seti-syntax, v0.2.1
space-tab, v0.1.0
travis-ci-status, v0.11.2
vim-mode, v0.30.0
zentabs, v0.6.1

# Dev
No dev packages

/cc @atom/core

Hey,
I would like to know if there were some updates about this ticket ?
Still have same issue on Linux Ubuntu.
thank you.

@Apokly My pull request fixes this issue, it's related to color codes in the output from the git log command.

have same issue


Godot Engine has stopped working

Godot version
Godot_v3.3.4-stable_mono_win64
System information
Windows 10
Issue description
After I reset my laptop I have not been able to run Godot
every time I try to run Godot it badly runs the program before it stops immediately and comes up with a text box that says  "A problem caused the program to stop working correctly.  Windows will close the program and notify you if a solution is available"
I do not know what is wrong and it usually works before I reset my laptop...
I do not know if it may be because I also updated my driver and the update maybe have deleted some older versions of OpenGL and if that's the problem, how can I install them again?
Steps to reproduce

Minimal reproduction project
No response

@Calinou Wow it's working angain! Thanks I thought I might not be able to run it again... :-) But I think it's still a good idea to get it fixed so you do not have to manually go into settings every time and manually choose which graphics card it should run on...

This sounds like an issue with your graphics driver. Try installing the latest NVIDIA drivers from NVIDIA's website (not your laptop OEM or Windows Update).


ReferenceError: Can't find variable: state

Using React-native: 0.60.4. I am getting the above error when I redirect from my newpassword screen to login screen. The login screen works fine if loaded normally or when directed post logout. But whenever user uses forgotpassword and changes password using OTP and he is redirected to login the above error is thrown and the app crashes.
fixed: http://facebook.github.io/react-native/docs/upgrading.html

React Native version: 0.60.4

Describe what you expected to happen:
The login page should have worked the way it works normally.
I am not very sure if this is an issue with RN so i have also posted on Stackoverflow.
https://stackoverflow.com/questions/57553509/referenceerror-cant-find-variable-state-in-react-native-0-60-4

Please look for variable state and make sure it's declared before use.


adds edges coverage

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (2867613) 89.13% compared to head (a29a3c5) 100.00%.
Report is 4 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##             main       #13       +/-   ##
============================================
+ Coverage   89.13%   100.00%   +10.86%
============================================
  Files           7         7
  Lines         184       184
  Branches        6         6
============================================
+ Hits          164       184       +20
+ Misses         20         0       -20

Files
Coverage Δ

src/edges.ts
100.00% <100.00%> (+31.74%)
:arrow_up:

src/qvi.ts
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add support for playing custom sounds

Custom sounds from ZSounds should be able to be played back in the content manager. The settings page should contain an option to control the playback volume. When a sound the played, the "Play" button should change to a "Stop" button and stop the sound if clicked again.

A basic version of this was added in 813e636c46dfc940e20f9d9c7c55e477a5286438. Closing this to track improvements in another issue.


Clap does not work after updating it on gvim(windows)

Environment (please complete the following information):

OS: Windows 11
(Neo)Vim version: vim9.0 (gvim)
vim-clap version: Latest(May 27th)
Have you reproduced with a minimal vimrc: yes
Have you updated to the latest plugin version: yes
Have you upgraded to/compiled the latest Rust binary: tried, but failed, it shows Error detected while processing function clap#[9]..clap#installer#install[10]..<SNR>48_do_download: line 4: E282 Cannot read from "C:\Users\ADMINI~1\AppData\Local\Temp\VZ73EC3.tmp"
Describe the bug
After running :PlugUpdate in Vim-Plug to update Clap, I got nothing when I type :Clap files, :Clap blines in my gvim.

I have tried to install binary but it reports error(the infomation is above).
Clap debug

            has ctags: Exuberant Ctags 5.8 (-json)
            has cargo: 0
            has maple: C:\Program Files (x86)\Vim\vimfiles\plugged\vim-clap/bin/maple.exe
           maple info: version 0.1.44 (git v0.44), compiled at: 2023-05-27 04:06:48.432734300 +00:00, built for x86_64-pc-windows-msvc by rustc 1.69.0 (84c898d65 2023-04-16).

     Current FileType:
Third Party Providers: []
       Global Options:
    let g:clap#autoload_dir = 'C:\Program Files (x86)\Vim\vimfiles\plugged\vim-clap\autoload'
    let g:clap#popup#display = {'shrink': function('61'), 'open': function('<SNR>38_create_display'), 'width': 32, 'shrink_if_undersize': function('60')}
    let g:clap#popup#preview = {'line_count': function('<SNR>37__line_count'), 'show': function('62'), 'hide': function('63'), 'clear': function('64'), 'add_highlight': function('66'), 'get_lines': function('<SNR>37__get_lines'), 'getbufvar': function('<SNR>37__getbufvar'), 'setbufvar_batch': function('<SNR>37__setbufvar_batch'), 'bufnr': 3, 'setbufvar': function('<SNR>37__setbufvar'), 'winid': 1002, 'win_is_valid': function('<SNR>37__win_is_valid'), 'goto_win': function('<SNR>37__goto_win'), 'set_syntax': function('65')}
    let g:clap#provider_alias = {'gfiles': 'git_files', 'hist:': 'command_history', 'hist/': 'search_history'}
    let g:clap_background_shadow_blend = 50
    let g:clap_disable_bottom_top = 0
    let g:clap_disable_matches_indicator = v:false
    let g:clap_disable_run_rooter = v:false
    let g:clap_enable_background_shadow = v:false
    let g:clap_enable_debug = v:false
    let g:clap_enable_icon = 0
    let g:clap_forerunner_status_sign = {'done': '•', 'running': '!', 'using_cache': '*'}
    let g:clap_indicator_winid = 1003
    let g:clap_insert_mode_only = v:false
    let g:clap_multi_selection_warning_silent = 0
    let g:clap_no_matches_msg = 'NO MATCHES FOUND'
    let g:clap_open_action = {'ctrl-v': 'vsplit', 'ctrl-x': 'split', 'ctrl-t': 'tab split'}
    let g:clap_open_preview = 'always'
    let g:clap_popup_border = 'rounded'
    let g:clap_preview_direction = 'AUTO'
    let g:clap_preview_size = 5
    let g:clap_providers_relaunch_code = '@@'
    let g:clap_search_box_border_style = 'nil'
    let g:clap_search_box_border_symbols = {'nil': ['', ''], 'curve': ['', ''], 'arrow': ['', '']}
    let g:clap_spinner_winid = 1005
  Provider Variables:
                     []

To Reproduce
Steps to reproduce the behavior:

Create the minimal vimrc min.vim:

let $VIMCONFIG='C:/Program Files (x86)/Vim/vimfiles'

set nocompatible
set runtimepath^=$VIMCONFIG/plugged/vim-clap
syntax on
filetype plugin indent on

Start (neo)vim with command: gvim -u min.vim

Type :Clap files

See error

Expected behavior
If there's a file called example.cpp in the current directory, type :Clap files and then type example.cpp, nothing was on the screen.
Screenshots

Additional context
Add any other context about the problem here.

I guess the problem is that the Rust binary is lost, but I could not install it :(

Should be a duplicate as https://github.com/liuchengxu/vim-clap/issues/967, the prebuilt binary for Windows is somehow problematic, you have these options for now:

Roll back to the last release (v0.43), note the binary and repo should both switch to v0.43.
Compile the Rust binary yourself before the next release.

Thanks! I have tried to rollback to v0.43, and it works.


Strava - API authorization

GETTING INTO THE FOLLOWING ISSUE, BROWSER ERROR:
Access to fetch at
'https://www.strava.com/oauth/authorize?client_id101485&redirect_uri=localhost&response_type=&approval_prompt=auto&scope=read,activity:read' from origin 'null'
has been blocked by CORS policy:
No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.
POSSIBLE RESOLUTION, located at
https://stackoverflow.com/questions/43262121/trying-to-use-fetch-and-pass-in-mode-no-cors
mode: 'no-cors' won’t magically make things work. In fact it makes things worse, because one effect it has is to tell browsers, “Block my frontend JavaScript code from seeing contents of the response body and headers under all circumstances.” Of course you never want that.
What happens with cross-origin requests from frontend JavaScript is that browsers by default block frontend code from accessing resources cross-origin. If Access-Control-Allow-Origin is in a response, then browsers relax that blocking and allow your code to access the response.
But if a site sends no Access-Control-Allow-Origin in its responses, your frontend code can’t directly access responses from that site. In particular, you can’t fix it by specifying mode: 'no-cors' (in fact that’ll ensure your frontend code can’t access the response contents).
However, one thing that will work: if you send your request through a CORS proxy.
You can also easily deploy your own proxy to Heroku in just 2-3 minutes, with 5 commands:
git clone https://github.com/Rob--W/cors-anywhere.git
cd cors-anywhere/
npm install
heroku create
git push heroku master
After running those commands, you’ll end up with your own CORS Anywhere server running at, for example, https://cryptic-headland-94862.herokuapp.com/.
Prefix your request URL with your proxy URL; for example:
https://cryptic-headland-94862.herokuapp.com/https://example.com
Adding the proxy URL as a prefix causes the request to get made through your proxy, which:
Forwards the request to https://example.com.
Receives the response from https://example.com.
Adds the Access-Control-Allow-Origin header to the response.
Passes that response, with that added header, back to the requesting frontend code.
The browser then allows the frontend code to access the response, because that response with the Access-Control-Allow-Origin response header is what the browser sees.
This works even if the request is one that triggers browsers to do a CORS preflight OPTIONS request, because in that case, the proxy also sends back the Access-Control-Allow-Headers and Access-Control-Allow-Methods headers needed to make the preflight successful.


not receiving alerts over email and slack.

I configured the email and slack webhook settings but not receiving any alerts.

Make sure you have your E-Mail agent configured on the host properly


Filters: --async and --function and --class and various typing ones

The --signatures option turns out to be a pretty great way to start navigating a new codebase.
It might be useful to be able to filter by types of content. Potentially the following:

--async - return async function (and method) definitions
--function - just functions
--class - just classes
--method - just class methods

These would be additive, so the following:
symbex --signatures --method --function

Would return all methods and all functions.
But... what would this do?
symbex -s --async

Would it return all async functions AND async methods? If so, would combining it with --function or --method not make a difference?
Or should there be a --async-method filter that's different from --async (which only gets async functions)?

I'll prototype it and play with it and see how it feels.

This is a pretty fun prototype:
% symbex --async -d ../datasette -s | head -n 20
# File: /Users/simon/Dropbox/Development/datasette/test-plugins/register_output_renderer.py Line: 6
async def can_render(datasette, columns, rows, sql, query_name, database, table, request, view_name)

# File: /Users/simon/Dropbox/Development/datasette/test-plugins/register_output_renderer.py Line: 26
async def render_test_all_parameters(datasette, columns, rows, sql, query_name, database, table, request, view_name, data)

# File: /Users/simon/Dropbox/Development/datasette/pugins-older/register_output_renderer.py Line: 6
async def can_render(datasette, columns, rows, sql, query_name, database, table, request, view_name)

# File: /Users/simon/Dropbox/Development/datasette/pugins-older/register_output_renderer.py Line: 26
async def render_test_all_parameters(datasette, columns, rows, sql, query_name, database, table, request, view_name, data)

# File: /Users/simon/Dropbox/Development/datasette/pugins-older/register_output_renderer.py Line: 60
async def render_response(request)

# File: /Users/simon/Dropbox/Development/datasette/pugins-older/memory_name.py Line: 6
async def startup(datasette)

# File: /Users/simon/Dropbox/Development/datasette/pugins-older/show_open_files.py Line: 6
async def show_open_files()

Needs a bit more thought, then tests and docs.

I didn't implement --method yet, not completely convinced it is necessary.

A --typed filter that just returns things that have type signatures - and a --untyped one that returns things without type signatures - might be neat too.

Maybe this:

--typed - any function with at least one of its arguments or return using type annotations
--untyped - not a single type annotation
--fully-typed - all arguments plus the return value have type annotations (a subset of --typed)
--partially-typed - some but not all of the arguments and return value have annotations

If you are working on a project and trying to add types to every single function, you can iterate on it using this to find the functions that still need some work:
symbex --untyped --partially-typed -a

Maybe --method isn't necessary because you can use a '*.*' selector instead?
Or maybe --method is a shortcut that adds the '*' selector?
It would be slightly surprising that while most of these filter options add together, --method --async would filter methods to just the async ones.
For that reason I think using *.* to filter methods may be more consistent.

Confirmed, this works already to get all async methods:
symbex -d ../datasette -s --async '*.*'

I built a messy prototype of the typing ones and I like them a lot:
symbex --typed -s

# File: tests/example_symbols.py Line: 50
def func_type_annotations(a: int, b: str) -> bool

# File: tests/example_symbols.py Line: 94
def function_with_non_pep_0484_annotation(x: ?, xx: ?, yy: ?, y: ?, zz: float) -> ?

# File: tests/example_symbols.py Line: 104
def complex_annotations(code: str, symbols: Iterable[str]) -> List[Tuple[(AST, Optional[str])]]

# File: symbex/lib.py Line: 11
def find_symbol_nodes(code: str, filename: str, symbols: Iterable[str]) -> List[Tuple[(AST, Optional[str])]]

# File: symbex/lib.py Line: 35
def code_for_node(code: str, node: AST, class_name: str, signatures: bool) -> Tuple[(str, int)]

# File: symbex/lib.py Line: 66
def match(name: str, symbols: Iterable[str]) -> bool

# File: symbex/lib.py Line: 91
def function_definition(function_node: AST)

# File: symbex/lib.py Line: 193
def annotation_definition(annotation: AST) -> str

# File: symbex/lib.py Line: 241
def annotation_summary(node: AST) -> AnnotationSummary

symbex --untyped -s

# File: tests/example_symbols.py Line: 10
def func_positional_args(a, b, c)

# File: tests/example_symbols.py Line: 15
async def async_func(a, b, c)

# File: tests/example_symbols.py Line: 20
def func_default_args(a, b=2, c=3)

...

Am I right that these should always be OR and not AND?
I just tried this and it didn't give me what I expected:
symbex --async --typed -s

Turns out I expected just typed async functions, but I got back ALL async functions and then ALL typed functions.

I'm going to try these as AND rather than OR and see how that feels.

Yes, AND for filters feels better. Switching to that.

This method is failing the test for --fully-typed:
class ClassForTypedTests:
    def method_fully_typed(self, a: int, b: str) -> bool:
        pass

Because self has no type. So I need a special case check for class methods.

I'm going to refactor AnnotationSummary - it looks like this:
AnnotationSummary = namedtuple(
    "Summary", ["num_arguments", "num_typed", "return_is_typed"]
)

I'm going to change it to this:
class TypeSummary:
    fully: bool
    partially: bool
)

Because self has no type. So I need a special case check for class methods.

That caused another problem: now --typed is returning any method with a self argument because I wrote code that says "treat that as typed" - even though there are no type annotations on anything else.

Here's a fun trick:
 llm --system 'Suggest several ways to refactor this' '    if (
        not symbols
        and not signatures
        and not async_
        and not function
        and not class_
        and not typed
        and not untyped
        and not partially_typed
        and not fully_typed
    ):
        ctx = click.get_current_context()
        click.echo(ctx.get_help())
        ctx.exit()'

Output:

There are several ways to refactor this code:

Consolidate all the boolean checks into a list and use all() to check if all items are False:

checks = [
    not symbols, not signatures, not async_,
    not function, not class_, not typed,
    not untyped, not partially_typed,
    not fully_typed
]

if all(checks):
    ctx = click.get_current_context()
    click.echo(ctx.get_help())
    ctx.exit()

Use De Morgan's Law to simplify the boolean checks:

if (
    symbols or signatures or async_ or function or
    class_ or typed or untyped or partially_typed or
    fully_typed
):
    pass
else:
    ctx = click.get_current_context()
    click.echo(ctx.get_help())
    ctx.exit()

Use any() with the negation of the boolean checks:

if not any([
    symbols, signatures, async_, function,
    class_, typed, untyped, partially_typed,
    fully_typed
]):
    ctx = click.get_current_context()
    click.echo(ctx.get_help())
    ctx.exit()

All three options achieve the same result, so it's up to personal preference on which one to choose.

One last thought: an __init__() method should not need a return type annotation to qualify as not breaing the fully typed rule.


Implement "Ordered Initializer" for Scene Instancing.

Godot version: 3.2
The _init function which can take arguments can only be used on script, not scene instantiation whereas _ready can't take parameter`s, which wouldn't be clear.
This presents bit of a problem when using setget that utilize tree nodes.
var title setget set_title
onready var label = $Label

func set_title(string):
	label.text = string

If we use .new and pass in the title string, the setter will trigger but the label has yet to been readied.
If we use .ready, we have to make additional calls.
var example = scene.instance()
example.initialize("Godot")

My suggestion is to implement a special ordered constructor, which first instances a scene, sets its data, and then returns the complete scene. This would only be called explicitly by the user, unlike ready, which should hopefully avoid more issues.
This is how I'm implementing it currently in my project:
var title setget set_title
var label = $Label

set_title(string):
    label.text = string

class Initializer
    static func initialize(title):
        var scene = scene.instance()
        scene.title = title
        return scene

Instantiation from elsewhere:
self.add_child(scene.Initialize.initialize("Godot"))

I've seen a few people run into this issue so I think it would serve well as a built-in method.

If we use .new and pass in the title string, the setter will trigger but the label has yet to been readied.

I've just realized using setget will run into an issue either way. I still believe there is merit in a single place for ordered scene instancing though.

From a glance, looks related too https://github.com/godotengine/godot-proposals/issues/325
Closing, because we are removing proposals from this repository. Also OP is a ghost 👻👻


Why my check not become effective?

Your Question
Why my check not become effective?

The document you expected this should be explained
https://gorm.io/zh_CN/docs/constraints.html
Expected answer
I want check string not ''

Postgres

Postgres

Don't get your question, if there are any issue, please create a playground PR.

Don't get your question, if there are any issue, please create a playground PR.

The constraints I set did not take effect. When I created the table using automatic migration, the constraints I set were not created

The constraints I set did not take effect. When I created the table using automatic migration, the constraints I set were not created

type Category struct {
commonModel.Model
Name     string    gorm:"type:varchar(20);not null;index;check:name_checker,name <> ''" json:"name"
Pid      int64     gorm:"index;default:0" json:"pid"
Sort     int       gorm:"default:100" json:"sort"
Products []Product gorm:"ForeignKey:CateId" json:"products,omitempty"
}
func (Category) TableName() string {
return "css_category"
}
我想创建一个约束，让name不能为空，但是一直不生效，想请问一下是什么原因？用的postgres

type Category struct {
commonModel.Model
Name     string    gorm:"type:varchar(20);not null;index;check:name_checker,name <> ''" json:"name"
Pid      int64     gorm:"index;default:0" json:"pid"
Sort     int       gorm:"default:100" json:"sort"
Products []Product gorm:"ForeignKey:CateId" json:"products,omitempty"
}
func (Category) TableName() string {
return "css_category"
}
我想创建一个约束，让name不能为空，但是一直不生效，想请问一下是什么原因？用的postgres

the doc is for gorm v2

the doc is for gorm v2


setting  let g:airline_powerline_fonts = 1 crashes MacVim

setting  let g:airline_powerline_fonts = 1 in .vimrc crashes MacVim. iTerm2 vim starts fine with this setting.
➜  ~  vim --version
VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Dec 28 2015 12:57:24)
MacOS X (unix) version
Included patches: 1-936
Compiled by Homebrew
MacVim version
Custom Version 7.4 (88)

Can you get a backtrace of the crash? This might be a bug in MacVim or Vim in general...

please report back to MacVim or  vim/vim. This is no airline issue.


Traverse all Vertices without removing duplicates

I wasn't sure if a issue was raised to implement this feature, so raising one. This will be a very highly desirable feature to have. The current work arounds are ugly an inefficient( iterating and querying again within a loop from the java/javascript layer). Would be great to have the traverse query having the ability to return results without taking the dupes out.
Posting a thread from the google groups.
Luigi Dell'Aquila
01/06/2015
Hi Emil,
Traverse was implemented this way to avoid infinite loops, but now we know it's a limitation and we are thinking about a finer strategy, where the user can define (per single query) how traversed nodes have to be considered:

skip traversed nodes globally
skip traversed nodes in current path
never skip
other...

This feature is not tracked yet in the issue tracker, could you please open an issue about this?
Thanks
Luigi
Emin Agassi
01/06/2015
Hello All
I am traversing a Graph that has some common Vertices. When I execute traverse, I only see one instance of the common Vertix versus several.
For example,
A -> B
C -> B
After traverse, I only see the following result:
A
C
B (common and pointed to by A and C)
I would like to see the duplicate Vertix in the result as follows:
A
B (Common to A and C)
C
B (Common to A and C)
Is there a method to achieve this or Traverse always returns Distinct Vertices?
Thank you
Emin

Hi @sivan123
Thank you very much, I think there was no other issue open about this.
Luigi

Hi @luigidellaquila any plans to get this prioritized for an upcoming release?

hi @sivan123
We are re-writing the query executor for 3.0, so probably something will be done at that stage.
In the meantime you can use the MATCH statement with the WHILE condition for that, it's much more flexible
http://orientdb.com/docs/2.2.x/SQL-Match.html#deep-traversal
Thanks
Luigi

@luigidellaquila How does it look like currently? Is there any possibility to traverse all edges without cycle? I believe it's the same issue as this one: https://github.com/orientechnologies/orientdb/issues/6943

Hi @jgrabowski
In v 3.0 we are extending the MATCH statement to also return the full path traversed on a WHILE condition and the depth, so you can use it for the same purpose of a TRAVERSE, but with more expression power.
Probably the TRAVERSE will remain as it is, but it should not be a big problem when you have a valid alternative.
Thanks
Luigi

Thanks @luigidellaquila. Is it available right now in 3.0 M2? I can do some testing in this area.

Hi @jgrabowski
I suggest you to try latest snapshot
https://oss.sonatype.org/content/repositories/snapshots/com/orientechnologies/orientdb-community/3.0.0-SNAPSHOT/
The new additions are depthAlias and pathAlias (See http://orientdb.com/docs/3.0.x/sql/SQL-Match.html)
Thanks
Luigi

Hi @jgrabowski
This was released long time ago.
I'm closing this issue, please feel free to re-open if you need further info
Thanks
Luigi


Unpin meld's swig version to unbreak from conda update

Partially addresses #675
Still need to find a proactive way to catch these

Sorry for the confusion...
The error was not due to the recent update of conda in the last few days. It was due to a previous update to conda 2.0, which happened in September.
The swig version for the meld openmm plugin was pinned at 3.0.7. This version of swig was built with an old version of conda-build. I have since unpinned the version of swig, so it now grabs 3.0.8, which was built with conda-build 2.0.1 and works fine.

@Lnaden No, not yet. Sorry for the confusion.
We actually build the release version of MELD here, but we have automated builds for testing every time there is a commit over in /maccallumlab/meld. That's what I've been working on. Once I have that fixed up, I'll update the build here.
You can probably close this PR.

Not a problem, thanks for clarifying!


"Error: no messages found" when converting demo PCAP file

I was trying to recreate the demo by setting up a LightFtp server and capturing the messages. For this I followed the demo transcript, but when i tried to convert it to replay format, the script keeps running into the error: "No messages found".
Here you can find the ftp.zip pcap. When inspecting this with Wireshark, it is clear that the pcap only contains 1 message flow as can be seen on the picture below:

For the conversion I used: python3 convert-pcap-replay-format.py --input ftp.pcap --server-port 2200 --client-port 55450 --output ftp.replay --ignore-multiple-clients
Thanks in advance!

Dear Thibault
I am unable to reproduce your problem. The script can correctly identify FTP requests and generate a replay file.
Find below the output and the resulting file
$ python3 convert-pcap-replay-format.py --input ../ftp.pcap --server-port 2200 --client-port 55450 --output ftp.replay --ignore-multiple-clients
Writing 15 bytes...
Writing 14 bytes...
Writing 6 bytes...
Writing 5 bytes...
Writing 10 bytes...
Writing 10 bytes...
Writing 5 bytes...
Writing 6 bytes...
Converted PCAP saved to ftp.replay

ftp.replay.zip

After some debugging, I found that len(request_msg) > 0 always return 0 in the final if-statement of the last try catch.
This means that the request_msg is never extended because the packets do not have an attribute data.
When printing these packets they indeed did not contain a data field, but some did include a DATA field shown in the picture below.

Changing the line request_msg.extend(pkt.data.data.binary_value) to request_msg.extend(pkt.DATA.data.binary_value) did the trick. Now it converts the pcap file correctly.


[docs] updated docs for min_delta parameter in early stopping callback

What does this PR do?

Fixes #9297
updated docs for min_delta parameter in early stopping callback
Does your PR introduce any breaking changes? If yes, please list them.
None

Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[x] Did you list all the breaking changes introduced by this pull request?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

@awaelchli take a look and let me know if anything needs to be changed.


Consider removing or simplifying fall meetings

It is hard to have meetings while the students are working on activities. Ideally, I'd like the students to focus on the activities and get them done with all of the instructors helping them in the process. Additionally, the time is tight to have any substantial meeting with the teams.

This is done. We're doing a closing 1 hr of "open office hours" seems to be working fine.


zef: 0.18.2 -> 0.18.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/ugexe/zef/releases.
meta.description for zef is: Raku / Perl6 Module Management
meta.homepage for zef is: https://github.com/ugexe/zef
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.18.3 with grep in /nix/store/s0csppcvs0fiz9y8z2l9nv9nb7vmqn9g-zef-0.18.3
found 0.18.3 in filename of file in /nix/store/s0csppcvs0fiz9y8z2l9nv9nb7vmqn9g-zef-0.18.3

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
zef

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/s0csppcvs0fiz9y8z2l9nv9nb7vmqn9g-zef-0.18.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A zef https://github.com/r-ryantm/nixpkgs/archive/80dcf0e37bd2e8f168e32149f24183f48c5e68d6.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/s0csppcvs0fiz9y8z2l9nv9nb7vmqn9g-zef-0.18.3
ls -la /nix/store/s0csppcvs0fiz9y8z2l9nv9nb7vmqn9g-zef-0.18.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

zef

Maintainer pings
cc @stigtsp for testing.

@GrahamcOfBorg build zef

Builds for me on aarch64-darwin:
[nix-shell:~/.cache/nixpkgs-review/pr-249370-12]$ cat report.md
Result of `nixpkgs-review pr 249370` run on aarch64-darwin [1](https://github.com/Mic92/nixpkgs-review)

  1 package built:

zef

The failure on x86_64 darwin seems related to nqp, not zef.


fixed kbd

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hello @urjaacharya
Back in issue #7 concerns were raised about duplicating the Hugo Documentation in this sample repo.
There used to be another content file with tips from the Documentation but it went out of date since Hugo is under constant development.
In the past year, the content of this repo was modified to be generic while at the same time offering an overview of Markdown syntax and Hugo features.
So I am afraid that I am going to close this Pull Request.
If you feel that the Hugo Documentation can be improved you are more than welcome to send Pull Requests at the dedicated repo: https://github.com/gohugoio/hugoDocs
Again thank you for taking the time to do this.
cc: @bep @digitalcraftsman

@onedrawingperday, thank you.
I noticed that pretty much all demos have "Markdown Syntax Guide" as one of the example content and in it, they all have same issue (for example, the nested list is not a nested list). That's what I was hoping this would fix.

@urjaacharya
Can you please sent a separate Pull Request with the nested list commit only?
I will gladly merge that.
This commit also contained a goldmark configuration setting.


New MBundle_IncrementMod.F90 has unintended consequences and interaction with bundleParser.py

@sdrabenh @amdasilva @amolod @wmputman @atrayano @mathomp4 @tclune
I'm putting this issue here as I don't know where else to put it since it involves source code or input files in at least 3 different repos and I apologize as this might be long and for all the people I tagged but I'm pretty sure every in the list either chimed in on this or is affected. Don't know where to start, this is related to the work Atanas did before he left for PTO.
The problem was that there were some increments, some sort of wet scavenging mumbo jumbo being computed in moist but @wputman removed these in his grand refactoring of moist. Apparently however, @sdrabenh count not release a tag  without these increments being output as somebody said so is all I know.
Anyway, these moist increments were something from gocart before and after moist and History needed to write  compute 2D column-summed results because that is what our file spec says, but the fields coming from gocart were either 4D (multiple bins) or there were multiple 3D fields from gocart that needed to be aggregated along the bins and vertical, but the problem is that some of these variables need to be aggregated but are not as a single variable with bins! This was previously done directly in moist which is only saw the 3D variables used hard coded logic about what to add together.
Atanas was instructed to make a new routine bundle routine to handle MTRI to aggregate these 3D or 4D fields into the 2D diagnostics needed and output in the MTRI bundle outside of moist which he did and is working (MBundle_IncrementMod.F90). That required adding this to AGCM.rc to tell it to aggregate these separate variables into 1 variable if that was needed which is was for the Nitrates:
# Enable wet scavenging
MTRI_increments::
DU::DU default
SS::SS default
SU::SO4 default
CA.bc::CA.bcphilic default
CA.br::CA.brphilic default
CA.oc::CA.ocphilic default
NI::NO3an1 "NI::NO3an2,NI::NO3an3"
::

and then this was added to History
                               'MTRI%DU::DUIM'             , 'PHYSICS' , 'DUSV' ,
                               'MTRI%SS::SSIM'             , 'PHYSICS' , 'SSSV' ,
                               'MTRI%CA.oc::CA.ocphilicIM' , 'PHYSICS' , 'OCSV' ,
                               'MTRI%CA.bc::CA.bcphilicIM' , 'PHYSICS' , 'BCSV' ,
                               'MTRI%CA.br::CA.brphilicIM' , 'PHYSICS' , 'BRSV' ,
                               'MTRI%SU::SO4IM'            , 'PHYSICS' , 'SUSV' ,
                               'MTRI%NI::NO3an1IM'         , 'PHYSICS' , 'NISV' ,

in the tavg2d_aer collection.
So far so good, in my and Scott's testing it worked, but @pcolarco reported in issue #579  he tried GOCART2G.data with the tag that had this and it failed unsurprisingly since these variables are not export from GOCART2D with those names when GOCART2G is run as the data version, so I looked into it.
I said, I'll just remove the MTRI_increment stuff from AGCM.rc but to my surprise, it still fails and not only that I saw in the AGCM.rc in scratch it had this in it how in addition to the above:
MTRI_increments::
DU::DU
SS::SS
CA.oc::CA.ocphilic
CA.bc::CA.bcphilic
CA.br::CA.brphilic
SU::SO4
NI::NO3an1

it took a while but I remembered that there is this bundleParser.py business run in gcm_run.j
That looks for anything in History.rc that starts with either
TRADVI%, CHEMTRI%,H2ORTRI%, TRI% or MTRI%
If it finds those, suppose it finds TRADVI%foo it add this to the AGCM.rc
TRADVI_increment:
foo
::

which then triggers various places in code to go compute the bundle increment.
With this new thing now, either bundleParser.py can't add these lines for MTRI as there is no way it can know from History.rc that it needs to add the new thing that was added for the MTRI bundle for nitrates or I have to hard code this in bundleParser.py and have it add the MTRI bundle.
But either way, we can't have this hard coded in AGCM.rc.tmpl and have bundleParser.py add this as it would appear 2x in the AGCM.rc file!
But wait, it gets worse. I was looking in the DAS Histories and saw stuff like this:
'MTRI%PCHEM::OXIM'  , 'PHYSICS'     , 'DOXDTMST'  , in the tavg_3d_odt collection.
Now I have to assume this will break the above since now MTRI is handled by MBundle_IncrementMod.F90 which wants to aggregate everything to 2D but this field in MTRI needs to be 3D. So now two different routines are going to do something to the MTRI bundle.
I will check on the consequences of all this.
In any event this is quite a mess. I will do my best to come up with the least kludgy solution to the already kludgy solution.

Note, one option would be to just call the bundle that gets passed to the new MBundle_IncrementMod.F90 something other than MTRI. Then the other fields the DAS needs that are also in MTRI will not be affected?
Anyone have any options? That's what I would recommend until a better solution to this mess can be done in the long run.

For the record, this implementation that specifically names GOCART species is very GOCART specific and violates the abstraction of the aerosol state.  I didn't like when it was first implemented, I like it even less now given that this is a refactoring exercise. It is probably OK as a place holder to honor the file spec, but a more general solution is needed. The general principle is that service providers must export the tendencies associated with each service provided,  in this case vertical transport and scavenging. However, the variable names in these exports should be derived, abstractly, from the variable names in the bundle. to be serviced. Here an exchange I had with Tom recently:
TOM: Going forward we will of course want to split this into at least two separate calculations.    1st, as we have discussed,  any component that provides a service would also provide tendencies related to that service._
ARLINDO: Precisely. Both 3D and vertically averaged – the vertical average is the most common use case, the 3D tendencies are needed only occasionally for debugging.
TOM: Presumably in MOIST this would then be
(delp_(t+1) * X_(t+1)) – (delp_t * X_t)) / (g * dt)
rather than a simple raw delta.
ARLINDO: I am not sure if I’d multiply by delp/g here. We must have an option for vertical average. Thinking of it, MAPL should be smart enough to compute vertical averages without any explicit code in the components. We need to design how this would be done but it could have a large payoff in terms of fewer lines of code in component code.  Suppose a component export a variable called ‘QV’. The vertical average of ‘QV’, named ‘TQV’, could be added to the export spec with the indication that if is a vertical average of ‘QV’:
     call MAPL_AddExportSpec(GC,                                                 &
                             LONG_NAME             = 'Total Precipitable Water', &
                             UNITS                 = 'kg s-1',                   &
                             SHORT_NAME            = 'TQV',                      &
                             VERTICAL_INTEGRAL_OF  = ‘QV’                        &
                             DIMS                  = MAPL_DimsHorzOnly,          &
                             VLOCATION             = MAPL_VLocationNone,         &
                             __RC__ )

(Would also implement VERTICAL_AVERAGE_OF, VERTICAL_SUM_OF, with INTEGRAL implying mass weighted). In this case, QV must be one of the exports, and it must be automatically allocated if one selects TQV.   One may need a call to MAPL at the end of the run method to finish these housekeeping chores.  Can you think of something better?
TOM: The component would also choose its own convention for how to decorate the short names to produce short names for these tendencies.
ARLINDO: I don’t think this is necessary. History already provides a device for renaming variables and having a standard convention for denoting tendencies from services would not be a bad thing.
TOM: Then, some other layer would do further reductions on these tendencies to produce the required diagnostics.
ARLINDO: Agreed.  The service provider should not know anything about summing over bins or species – this is so component specific.  Again, history has an expression parser already, although it requires that only variables appearing in the file can enter the expression.  In the very least we need to introduce the notion of “virtual variables” which are “defined” in history.rc but are never written to file – the purpose of virtual variables is to enter the expression parser. A virtual variable could be named with ~ in the beginning:  ~DUEXT …
TOM:  This could be some other parent GC, or HIST using the expression parser.   The current expression parser is not quite powerful enough for this case, but we will improve this.
ARLINDO: Agreed, making the expression parser in history smarter will reduce the number of lines of code in component code. Reusability of code is not a bad thing.

I ended up just making new bundle in physics that these wet scavenging things can be stored in so as to not conflict with MTRI and so Scott can release a tag. That's the only short term solution.


HBASE-24446 Use EnvironmentEdgeManager to compute clock skew in Master

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
12m 26s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
9m 58s
branch-1 passed

+1 :green_heart:
compile
0m 42s
branch-1 passed with JDK v1.8.0_252

+1 :green_heart:
compile
0m 47s
branch-1 passed with JDK v1.7.0_262

+1 :green_heart:
checkstyle
1m 57s
branch-1 passed

+1 :green_heart:
shadedjars
3m 18s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 48s
branch-1 passed with JDK v1.8.0_252

+1 :green_heart:
javadoc
0m 43s
branch-1 passed with JDK v1.7.0_262

+0 :ok:
spotbugs
3m 14s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 10s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m  2s
the patch passed

+1 :green_heart:
compile
0m 42s
the patch passed with JDK v1.8.0_252

+1 :green_heart:
javac
0m 42s
the patch passed

+1 :green_heart:
compile
0m 48s
the patch passed with JDK v1.7.0_262

+1 :green_heart:
javac
0m 48s
the patch passed

-1 :x:
checkstyle
1m 45s
hbase-server: The patch generated 1 new + 39 unchanged - 2 fixed = 40 total (was 41)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
3m  7s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
4m 52s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 32s
the patch passed with JDK v1.8.0_252

+1 :green_heart:
javadoc
0m 45s
the patch passed with JDK v1.7.0_262

+1 :green_heart:
findbugs
3m  5s
the patch passed

_ Other Tests _

-1 :x:
unit
159m 41s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 31s
The patch does not generate ASF License warnings.

215m 23s

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestAdmin2

hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1886/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1886

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 573c9b57bfd6 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1886/out/precommit/personality/provided.sh

git revision
branch-1 / f74d181

Default Java
1.7.0_262

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:1.8.0_252 /usr/lib/jvm/zulu-7-amd64:1.7.0_262

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1886/1/artifact/out/diff-checkstyle-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1886/1/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1886/1/testReport/

Max. process+thread count
4056 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1886/1/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@apurtell @virajjasani  Can you please review the change ?


4.2.dev1 export templates missing, 404 error on template manager download

Godot version
4.2dev1
System information
macOS 13.4.1
Issue description
The templates are missing again, I guess a similar issue as https://github.com/godotengine/godot/issues/79410

EDIT: I think the new correct templates are located at https://github.com/godotengine/godot-builds/releases/download/4.2-dev1/Godot_v4.2-dev1_export_templates.tpz
Steps to reproduce
Open Export template manager
Click "Download and install"
Minimal reproduction project
not project specific

See the comments on that, seems to still be in progress

Done: https://github.com/GodotBuilder/godot-builds/releases/tag/4.2-prerelease-templates


Telemetry: measure per-hop gossip latency

Into the Message.msg type, include a list of timestamps/peerid and track how long the block took the propagate and the path it took.

#4461 implements the RPC part of this.

Currently massively increases gossip traffic, need to talk about this with the Telemetry gang to see if there is a better solution

Let's take this after the open tracing work is done so it can be utilized here


NBitcoin.uint256.Comparison throws exception

Seem to randomly happen, and a restart of the FullNode continue normally.
Any idea?
FullNode[0]
      Consensus loop unhandled exception (Tip:81653)
System.NullReferenceException: Object reference not set to an instance of an object.
   at NBitcoin.uint256.Comparison(uint256 a, uint256 b)
   at NBitcoin.BlockHeader.CheckProofOfWork()
   at Stratis.Bitcoin.Consensus.ConsensusValidator.CheckBlockHeader(BlockHeader header) in C:\Users\Dan\Documents\GitHub\StratisBitcoinFullNode\Stratis.Bitcoin\Consensus\ConsensusValidator.cs:line 61
   at Stratis.Bitcoin.Consensus.ConsensusLoop.AcceptBlock(BlockResult result) in C:\Users\Dan\Documents\GitHub\StratisBitcoinFullNode\Stratis.Bitcoin\Consensus\ConsensusLoop.cs:line 189
   at Stratis.Bitcoin.Consensus.ConsensusLoop.ExecuteNextBlock(CancellationToken cancellationToken) in C:\Users\Dan\Documents\GitHub\StratisBitcoinFullNode\Stratis.Bitcoin\Consensus\ConsensusLoop.cs:line 176
   at Stratis.Bitcoin.Consensus.ConsensusLoop.<Execute>d__24.MoveNext() in C:\Users\Dan\Documents\GitHub\StratisBitcoinFullNode\Stratis.Bitcoin\Consensus\ConsensusLoop.cs:line 133
   at Stratis.Bitcoin.FullNode.RunLoop() in C:\Users\Dan\Documents\GitHub\StratisBitcoinFullNode\Stratis.Bitcoin\FullNode.cs:line 292

wow. This is very very very strange. I will try to push a new version on NBitcoin I have an idea why.

try to update to <IP_ADDRESS> and let me know.

Ok I will try thanks

Looks like this is fixed, I will let the node run over night and reopen if any issues.


Remove CRDs from tigera-operator.yaml

Description

Trying this out. It removes the CRDs from tigera-operator.yaml to reduce the size of the manifest.
Instead, it configures the operator pod itself to create these CRDs on startup.
The main consequences I can see are:

operator-init container in OCP will try to create resources before CRDs exist. May need to adjust the code.
users will need to wait for operator pod to be running before applying custom-resources.yaml

But I think this is probably worth trying out.
Related issues/PRs
Fixes https://github.com/projectcalico/calico/issues/9517
Requires: https://github.com/tigera/operator/pull/3610

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

To reduce manifest size, tigera-operator.yaml no longer includes CustomResourceDefinitions. Instead, the tigera-operator pod will deploy these resources on startup.

Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one docs-* label.

docs-pr-required: This change requires a change to the documentation that has not been completed yet.
docs-completed: This change has all necessary documentation completed.
docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

release-note-required: This PR has user-facing changes. Most PRs should have this label.
release-note-not-required: This PR has no user-facing changes.

Other optional labels:

cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

Actually looking at it, I think this doesn't impact OCP since we install CRDs as distinct manifests in that env.

@lwr20 I think there is mileage in that, although I'd need to think about what work is required on our end to make that happen. Not obvious how we get our generation code to do that nicely.
There's a part of me that says "Let's just roll this out and see how it fares" - it's still possible that even including our operator CRDs can exceed maximum sizes in some cases (if not now, then eventually)

LGTM, one question about manifests/ocp/policy.networking.k8s.io_adminnetworkpolicies.yaml: that's not a calico CRD per se, but it might be nice to have the operator take care of it and to remove the yaml from here as well, what do you think?


Class 'Kirby' not found in kirby-twig/config.php

Hey, I tried to install this module on a clean Kirby 3 Beta 6 installation with PHP 7.1
Steps

I installed it with composer, as written in the documentation.
Changed home.php to home.twig an modified the snippets to .twig
Reload of the page

Error:
Fatal error: Uncaught Error: Class 'Kirby' not found in /Users/.../Sites/.../vendor/mgfagency/kirby-twig/config.php on line 5
Have I missed something? #

Hey @MathiasGmeiner, your steps were right.
I think it only currently works with the composer based kirby install. (devkit) This is not intended.
Will fix this.

Thanks! In the meantime I try to change my installation to the devkit.

Anything new on how to use this in a non-devkit setup?
I'm really interested in this plugin

The problem is this issue: https://github.com/k-next/kirby/issues/762
A workaround is using the devkit for now or with the starterkit manually downloading the repo to the plugin folder and installing composer dependencies inside the plugin.
I will fix this, as soon as there is an official way to go for plugins.

This should be fixed in 1.0.7


[[FEAT]] nobom option to disallow BOM sequences

Closes #2284

PTAL ---it's a lot of code (mostly to deal with the array input case :(
It probably needs a more "e2e"-style test with a fixture too, to make sure it works with utf8 as well as utf16 (unit tests only deal with utf16, since that's JS for you). But I'm not sure how hard it will be to keep the file from being mysteriously re-encoded or mysteriously have its BOM removed

Coverage decreased (-0.15%) to 96.17% when pulling 835f488cfd2bffb454dc2cf2d79e927c96cdb4b1 on caitp:issue-2284 into 12811e797a264f323b920b314db965b8adcb207e on jshint:master.

Coverage decreased (-0.15%) to 96.17% when pulling 33592c8685699071462bceb69c426b0ee6800afd on caitp:issue-2284 into 12811e797a264f323b920b314db965b8adcb207e on jshint:master.

Coverage decreased (-0.15%) to 96.17% when pulling 33592c8685699071462bceb69c426b0ee6800afd on caitp:issue-2284 into 12811e797a264f323b920b314db965b8adcb207e on jshint:master.

Coverage increased (+0.0%) to 96.33% when pulling 09b7f13ee3baeb6249a5c8f489b4254d67ffe149 on caitp:issue-2284 into 12811e797a264f323b920b314db965b8adcb207e on jshint:master.

Coverage increased (+0.0%) to 96.33% when pulling 09b7f13ee3baeb6249a5c8f489b4254d67ffe149 on caitp:issue-2284 into 12811e797a264f323b920b314db965b8adcb207e on jshint:master.

Coverage increased (+0.01%) to 96.33% when pulling 1c6362111e013265f50d62a4e8c07eae864fb529 on caitp:issue-2284 into 12811e797a264f323b920b314db965b8adcb207e on jshint:master.

The lexer currently calls its scanUnsafeChars method which executes a regular expression search for a set of characters that includes both \uFEFF and \uFFFE. This is done unconditionally for all input, regardless of configuration options or source code input method (i.e. string or array).
As far as I can tell (and preliminary tests confirm), JSHint already warns about BOM sequences. This contradicts the assumption of the original feature request, so I suspect I'm missing something important here. @caitp / @Krinkle: could you help me understand?

@caitp @krinkle any follow up?

I test, I created a file in Sublime Text 3 and used "Save with Encoding > UTF-8 with BOM" (verified with cat test.js | wc in bash that the file did in fact grew 3 bytes after this operation).
Passing it to jshint v2.8.0 didn't produce any warnings.

Based on the discussion so far, I would expect the test case that @caitp provided to fail without the patch. Since they do not (as I mentioned above), I think we are still missing some part of the problem. @Krinkle could you upload that file somewhere? That will help make the failing test case.

@jugglinmike I've committed the file to git, and pushed here as pull #2478. It seems it is failing already actually, though it could certainly do with a more descriptive warning.

[bold]{Line 1, Char 0} This character may get silently deleted by one or more browsers.

@Krinkle Your explicit test (along with your original report) has helped me to identify the issue. The unit test already fails on master not because we recently resolved it, but because the unit tests are run against the JSHINT function directly. The behavior your originally reported is limited to the CLI:
  buffer.push(code);
  buffer = buffer.join("\n");
  buffer = buffer.replace(/^\uFEFF/, ""); // Remove potential Unicode BOM.

There are not tests or documentation for this, but I've traced its introduction to a pull request against the long-deprecated node-jshint project.
Although the proposed nobom option could address your use-case, I think the real issue here is the inconsistency between the API and the CLI. If our confused, months-long conversation is any indication, the inconsistency causes more trouble than it is worth.
I think it would be better to remove the offending line from the CLI code. Users who aren't concerned about the issue can suppress the W100 warning. I've opened gh-2486 to track that. This would be a breaking change, though, so we'll plan for the next major release.
Thanks for following through on this!


Node security group and route table accessibility

Is your request related to a new offering from AWS?
No - This is an existing feature of the module that is obstructed from direct access
Is your request related to a problem? Please describe.
I'm creating a new k8s cluster in a secondary VPC and would like to peer it with the primary VPC. There's no direct access via the EKS module to update the security groups of the nodes.
Describe the solution you'd like.
Allow access to security groups assigned to node instances by eks module or allow for a direct security group assignment to nodes via LT, not indirect like remote_access or other group rules. Remote access is useless for this because it assigns a port 22 ssh rule to the new SG not the SG itself to the Node instance via LT.
Describe alternatives you've considered.
Manually making the updates via AWS console and executing terraform apply -refresh-only to ignore but this is not ideal
Additional context
I'm using the VPC module (See https://github.com/terraform-aws-modules/terraform-aws-vpc) provided by you to create the VPC but I don't see any way there either to update the route tables of NAT gateway or public/private subnets. In a VPC peering connection you need to update both route tables and security groups to allow for bi-directional comms.
I understand for the route table this is out of the context since it's in a different module but I wanted to give the overall context of the use case.
eks=18.15.0
vpc=3.13.0

I'm not quite following what you are trying to achieve - do you have an example configuration? Have you read through https://github.com/terraform-aws-modules/terraform-aws-eks#security-groups - the security groups are quite extensible and configurable

@bryantbiggs thanks for responding so fast. I've read the security-groups section and the issue is that I can't attach a custom security group to the nodes.
For example let's say this is my security group that allows another VPC to communicate with the nodes:
resource "aws_security_group" "vpc_peering" {
  name_prefix = "${local.name}-vpc-peering"
  description = "Allow VPC peer access"
  vpc_id      = module.vpc.vpc_id

  ingress {
    description = "VPC peering"
    from_port   = 0
    to_port     = 65535
    protocol    = "tcp"
    cidr_blocks = ["<IP_ADDRESS>/16"]
  }

  egress {
    from_port        = 0
    to_port          = 0
    protocol         = "-1"
    cidr_blocks      = ["<IP_ADDRESS>/0"]
  }

  tags = local.tags
}

When I add it to vpc_security_group_ids
  eks_managed_node_group_defaults = {
    ami_type       = "AL2_x86_64"
    disk_size      = 20
    instance_types = ["t3.micro", "t3.small"]
    vpc_security_group_ids = [aws_security_group.vpc_peering.id]
  }

I expect it to be listed as a security group in the node_group instances but it's not and I can't modify the default groups because they're hidden. Is this an artifact of the EKS managed node groups because it does show up in the self managed node group.

I see, so then this would have to be set to true.
  eks_managed_node_groups = {
    green = {
      **create_launch_template = true**
      ...
    }
  }

it is true by default, users have to disable by setting it to false like https://github.com/terraform-aws-modules/terraform-aws-eks/blob/6d7245621f97bb8e38642a9e40ddce3a32ff9efb/examples/eks_managed_node_group/main.tf#L109-L113

Thanks @bryantbiggs that resolved the issue. I'll close this ticket.


pin cosmwasm-typescript-gen version and add --frozen-lockfile

Can you update to the latest version while you are at it? 0.3.6?

Codecov Report

Merging #380 (3647b9b) into main (3636c7c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #380   +/-   ##
=======================================
  Coverage   96.94%   96.94%
=======================================
  Files          39       39
  Lines        8760     8760
=======================================
  Hits         8492     8492
  Misses        268      268

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3636c7c...3647b9b. Read the comment docs.


Wind and solar energy are not renewable fuels

Description of the issue
Currently, both the classes wind energy and solar energy have the axioms 'has disposition' some 'renewable fuel' attached. But  that is logically incorrect as an energy cannot have the disposition to be a fuel.
Ideas of solution
If you already have ideas for the solution describe them here
Workflow checklist

[ ] I discussed the issue with someone else than me before working on a solution
[ ] I already read the latest version of the workflow for this repository
[ ] The goal of this ontology is clear to me

I am aware that

[ ] every entry in the ontology should have a definition
[ ] classes should arise from concepts rather than from words

Yes, this shouldn't be the case. Also, this issue already came up some while ago: https://github.com/OpenEnergyPlatform/ontology/issues/515
There, we found a solution and implemented it (the new class renewable energy carrier, connected to air and photon). It just seems like we forgot to delete the axioms about renewable fuel, so we should catch up on that. Also, we should add the energy carrier disposition to photon so that it gets classified as a renewable energy carrier.

There, we found a solution and implemented it (the new class renewable energy carrier, connected to air and photon). It just seems like we forgot to delete the axioms about renewable fuel, so we should catch up on that. Also, we should add the energy carrier disposition to photon so that it gets classified as a renewable energy carrier.

I agree. Can you implement this?


Support VSCode's indentation setting

Actual Behavior
With the extension installed, the "Format Document" command indents with tabs even when VSCode is configured to use spaces.
Expected Behavior
The "Format Document" command follows the VSCode setting on tabs vs spaces, and number of spaces:

Steps to Reproduce the Problem Or Description

Open a document in GraphQL language mode
Run the "Format Document" command.

Specifications

GraphQL for VSCode Extension Version: v0.2.35
VSCode Version: 1.49.0-insider
OS Name: Windows 10
OS Version: Version 1903 (OS Build 18362.1016)

thanks for reporting! this is a much less than ideal bug.
so, this extension does not implement code formatting. so you might have better luck over at the prettier-vscode repository. it could be an issue in their implementation, or an issue with the actual @prettier/parser-graphql or whaever it's called. We use that in our official monaco mode, but not in the language server or in this extension. hope this helps!

Oh, thank you. I'll report to prettier-vscode.


Create JobsPageBreadcrumbs component

Release Type: Non-breaking changes
Fixes https://x-team-internal.atlassian.net/browse/XP-3375
Description
Create JobsPageBreadcrumbs component
Checklist

[x] set yourself as an assignee
[x] set appropriate labels for a PR (In Review or In Progress depending on its status)
[x] move respective JIRA issue to the IN REVIEW column
[x] make sure your code lints (npm run lint)
[x] Flow typechecks passed (npm run flow)
[x] Snapshots tests passed (npm run jest)
[x] component's documentation (.stories.js file) is changed or added accordingly to reflect any new or updated use cases or variants usage
[x] if any snapshots have been changed, verify that component still works and looks as expected and update the changed snapshot
[x] manually tested the app by running it in several different browsers (Firefox, Chrome, Opera, Safari, MS IE/Edge, etc.) and checked nothing is broken and operates as expected!

Steps to Test or Reproduce

Run npm start
Go to http://localhost:9001/?path=/story/ui-components-xp-registration-jobspagebreadcrumbs--default

Impacted Areas in Application

New JobsPageBreadcrumbs was created

Screenshots

Added new story to show case the JobsPageLayout composed with JobsPageBreadcrumbs:

Please ignore how JobsGrid looks in this screenshot, it's changed in the scope of https://github.com/x-team/xp-ui/pull/453

Rebuild the app to resolve conflicts.

While playing around with use cases, I noticed that while on a small screen, sidebar sticks to the context area so wondering if that's smth we can improve as well by giving it some room at the bottom?

I understand your concern, but this is not responsibility of the sidebar area, that margin should belong to the ProTipCard that we are going to develop https://x-team-internal.atlassian.net/browse/XP-3368 :)

While playing around with use cases, I noticed that while on a small screen, sidebar sticks to the context area so wondering if that's smth we can improve as well by giving it some room at the bottom?

@nicksp I'll make the change as you suggested. Not entirely sure which would be better, but as long design keeps spacing consistent, we should be safe to make this way.

I'll make the change as you suggested.

@bernardodiasc Where do you think will be an appropriate task to make this change? So we can add an AC to keep track of that.

@nicksp I added here https://github.com/x-team/xp-ui/pull/455/commits/6ad5112578e7c843e71506f19605525dba2ef1ae, I think it's not a problem. My worry with this is that we are assuming this space globally no matter which component goes in the sidebar. I think again, and as said, if design keeps consistency in the spacing, this should be alright. But if they require different spacing depending on the components that goes in the sidebar, then we need to go for the other approach. For now this should work. :+1:

But if they require different spacing depending on the components that goes in the sidebar, then we need to go for the other approach. For now this should work.

Got you. I didn't have a better approach in mind, I just wanted to share my observations, but the point you made about consistency makes sense to me. Let's keep it like it is and we'll refine as we develop further.


FixFix partition external table query bug.

Proposed changes
Issue Number: close #xxx
Problem summary
The index for external table columns from path is incorrect in new scanner. This is a fix for it.
e.g. In the next query, nation and city columns are from path
mysql> select nation, city, count(*) from parquet_two_part group by nation, city;
+--------+------------+----------+
| nation | city       | count(*) |
+--------+------------+----------+
| cn     | beijing    |  1199969 |
| cn     | shanghai   |  1199771 |
| jp     | tokyo      |   599715 |
| rus    | moscow     |   600659 |
| us     | chicago    |  1199805 |
| us     | washington |  1201296 |
+--------+------------+----------+
6 rows in set (0.39 sec)

Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 40.27 seconds
load time: 588 seconds
storage size:<PHONE_NUMBER>2 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221021164706_clickbench_pr_32457.html

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 40.4 seconds
load time: 590 seconds
storage size:<PHONE_NUMBER>4 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221022014117_clickbench_pr_32662.html

Please rebase to merge with #13515

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 40.24 seconds
load time: 585 seconds
storage size:<PHONE_NUMBER>5 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221023224013_clickbench_pr_32866.html

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 41.05 seconds
load time: 584 seconds
storage size:<PHONE_NUMBER>5 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221023151451_clickbench_pr_32868.html

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 38.57 seconds
load time: 571 seconds
storage size:<PHONE_NUMBER>2 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221026103404_clickbench_pr_34023.html


Open ticker API

Price ticker API for X-XLM, X-USD, and X-Y trading pairs.
24H price ticker format:
{
  "symbol": "ETH-GBSTRH4QOTWNSVA6E4HFERETX4ZLSR3CIUBLK7AXYII277PFJC4BBYOG_XLM",
  "priceChangePercent": "-2.85",
  "peviosClosePrice": "1538.4614265",
  "lastPrice": "1538.4614265",
  "openPrice": "1583.52866645",
  "highPrice": "1593.11773144",
  "lowPrice": "1412.7217514",
  "baseVolume": "2891.6262647108364143311200529473",
  "quoteVolume": "4448655.4681119",
  "openTime":<PHONE_NUMBER>000,
  "closeTime":<PHONE_NUMBER>000,
  "tradesCount": 4797
}

Add "bidPrice" and "askPrice" values once #99 is ready.
Ref https://github.com/stellar/go/issues/855

Irrelevant as SDF introduced a more feature-rich ticker (https://github.com/stellar/go/tree/master/services/ticker).


fix(risedev): cmd do-apply-planner-test should print backtrace, not just error

Currently, it prints just the error. Let's print the entire backtrace to make it easier to investigate issues in frontend.

Oops, turns out we seem to need async backtrace.


Column batch tests

It's WIP, but please check it now, so if I make any fundamental mistakes, I can avoid making them when continuing with the PR

(except for the failed tests and missing newlines and maybe a few more things :) )

Thank you @gdynusa, I consider this to be ready and I will merge this when appropriate.


voxelgrid_sampling_omp twice reduces point count

Describe the bug
When voxelgrid_samping_omp is first run with cloud A as input and cloud B as output, a second run with cloud B as input and cloud C as output results in cloud C having a lower point count than cloud B, even though leaf_size has the same value at both executions.
To Reproduce
Steps to reproduce the behavior:

add the following lines below line 16 in src/example/02_basic_registration_pcl.cpp

std::cout << raw_target->size() << std::endl;
std::cout << target->size() << std::endl;
target = voxelgrid_sampling_omp(*target, 0.25);
std::cout << target->size() << std::endl;
target = voxelgrid_sampling_omp(*target, 0.25);
std::cout << target->size() << std::endl;

Build the package
Run '02_basic_registration_pcl'. The output is:

69088
6206
6147
6147
...

The first number is the size of the raw cloud, the second one after the first filter application and so on. Expected behaviour is that the last three numbers are the same.
Expected behavior
Cloud C shall have the same size (point count) as cloud B.
Environment (please complete the following information):

OS: Ubuntu
Version 22.04
Language C++

voxelgrid_sampling_omp uses a slight approximation for parallel processing efficiency that causes minor run-by-run non-determinism. If it is important that the method returns exactly the same number of points every time, we can consider changing the scheduling method at the following line from (guided, 4) to (static) (that may cause very slight performance degradation for a large point cloud).
https://github.com/koide3/small_gicp/blob/f48faf079051a92bfdb201bb08a67d35179fbd67/include/small_gicp/util/downsampling_omp.hpp#L63

Thank you @koide3 for your response. This approximation is perfectly fine for me, I just was not aware of it. Those use-cases where I want the filter to return exactly the same number of points every time are not so time-critical, I can use a different method in these cases.


Install and Getting Started pages have selectable console prompts, making it difficult to quickly copy instructions

We saw this as a recent workshop. Some of our pages have instructions like this:
$ git clone -b alpha https://github.com/flutter/flutter.git
$ export PATH=`pwd`/flutter/bin:$PATH

However, the $ is only there to indicate "command prompt"... and that's not obvious to everyone. Some people copy the entire line and paste it in their console. And the $ isn't meant to be copied and pasted.

Proposed solution: set user-select: none on $ .

PR is up at https://github.com/flutter/website/pull/669


Electricity Consumption Forecasting

Pull Request for ML-Crate 💡
Issue Title :

Info about the related issue (Aim of the project) :
Name:
GitHub ID:
Idenitfy yourself:

Closes: #issue number that will be closed through this PR
Describe the add-ons or changes you've made 📃
Give a clear description of what have you added or modifications made
Type of change ☑
What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested? ⚙
Describe how it has been tested
Describe how have you verified the changes made
Checklist: ☑

[ ] My code follows the guidelines of this project.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly wherever it was hard to understand.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.
[ ] I have added things that prove my fix is effective or that my feature works.
[ ] Any dependent changes have been merged and published in downstream modules.

Ok I will make changes:)
On Wed, 19 Oct 2022, 7:49 pm Abhishek Sharma, @.***>
wrote:

Assigned #370 https://github.com/abhisheks008/ML-Crate/pull/370 to
@Karanshelke https://github.com/Karanshelke.
—
Reply to this email directly, view it on GitHub
https://github.com/abhisheks008/ML-Crate/pull/370#event-7622112755, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AOUAUJ3DNG7P2VT5NXU6EHLWD77PLANCNFSM6AAAAAARIYYDZM
.
You are receiving this because you were assigned.Message ID:
@.***>

Ok got it
On Wed, 26 Oct 2022, 6:36 pm Abhishek Sharma, @.***>
wrote:

@.**** requested changes on this pull request.

Remove the Datasets/README.md file, as it is an empty file.
Please do some EDA with the dataset and find out some aspects of
the dataset given to you. This will showcase the depth of your data
analysis skills. And put those visualization images inside the Images
folder. The file that you have put inside the Images folder is not
acceptable, it's not having any extension for being an image object.
Add requirements.txt file, which consists the required
libraries/packages along with their versions, which you have used while
developing this project.

@Karanshelke https://github.com/Karanshelke
—
Reply to this email directly, view it on GitHub
https://github.com/abhisheks008/ML-Crate/pull/370#pullrequestreview-1156470421,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOUAUJ63OBC53YQXCYCN3DLWFEUGRANCNFSM6AAAAAARIYYDZM
.
You are receiving this because you were mentioned.Message ID:
@.***>


refactor: make the CompiledRouter pickleable

The CompiledRouter is not pickle-able because the default responder uses
function within functions. As a result, the CompiledRouter cannot be
shared between processes using IPC mechanisms, which utilize pickles
internally. Replace the function within functions with partials of
module level functions so that the CompiledRouter can be pickled. Also,
change the traverse method to use the function wrapped by the partial to
preserve existing functionality.
All tests passed for Python 3.6 and 2.7. No breaking changes found.

Thanks so much!


Compliance-rules/ripple circles: they shouldn't disappear after navigation

The ripple circles disappear after navigation/zooming or after adding a css class. Similar behavior as in #2

To reproduce:

click on show compliance rules
ripple circles appear
move the diagram

code for adding ripple circles in compliance-rules.js, function addRipleCircles()

https://github.com/process-analytics/bpmn-visualization-js/pull/2199 may fix this issue and #2
https://user-images.githubusercontent.com/27200110/186952139-685be0a7-bb8c-481b-9fb0-2037661657e7.mp4
How to reproduce

build bpmn-visualization PR 2199 bundles: npm run build-bundles
link the local bpmn-visualization npm package: npm link ../bpmn-visualization-js (here, the command assumes that the 2 folders are stored in the same root directory)
clear the vite cache (in node_modules/.vite/deps)
restart the dev server