HDFS-17601. [ARR] RouterRpcServer supports asynchronous rpc.

Description of PR
RouterRpcServer supports asynchronous RPC, the following methods need to be transformed to asynchronous versions:

invokeOnNsAsync
invokeAtAvailableNsAsync
getExistingLocationAsync
getDatanodeReportAsync
getDatanodeStorageReportMapAsync
getSlowDatanodeReportAsync
getCreateLocationAsync

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
7m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ HDFS-17531 Compile Tests _

+1 :green_heart:
mvninstall
34m 47s

HDFS-17531 passed

+1 :green_heart:
compile
0m 26s

HDFS-17531 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
0m 23s

HDFS-17531 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
0m 23s

HDFS-17531 passed

+1 :green_heart:
mvnsite
0m 32s

HDFS-17531 passed

+1 :green_heart:
javadoc
0m 30s

HDFS-17531 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 21s

HDFS-17531 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
1m  0s

HDFS-17531 passed

+1 :green_heart:
shadedclient
23m  5s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 24s

the patch passed

+1 :green_heart:
compile
0m 26s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
0m 26s

the patch passed

+1 :green_heart:
compile
0m 22s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
0m 22s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 4 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
checkstyle
0m 14s

the patch passed

+1 :green_heart:
mvnsite
0m 24s

the patch passed

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 18s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
0m 57s

the patch passed

+1 :green_heart:
shadedclient
23m 27s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
27m 26s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 27s

The patch does not generate ASF License warnings.

125m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7108/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7108

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 478c09646912 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
HDFS-17531 / 915f8d3992781cca6c4821e017c4e1e4e319c66b

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7108/1/testReport/

Max. process+thread count
4040 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7108/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Will add UTs these days.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 20s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ HDFS-17531 Compile Tests _

+1 :green_heart:
mvninstall
33m  1s

HDFS-17531 passed

+1 :green_heart:
compile
0m 30s

HDFS-17531 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
0m 22s

HDFS-17531 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
0m 20s

HDFS-17531 passed

+1 :green_heart:
mvnsite
0m 31s

HDFS-17531 passed

+1 :green_heart:
javadoc
0m 31s

HDFS-17531 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 21s

HDFS-17531 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
0m 58s

HDFS-17531 passed

+1 :green_heart:
shadedclient
20m 35s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 21s

the patch passed

+1 :green_heart:
compile
0m 23s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
0m 23s

the patch passed

+1 :green_heart:
compile
0m 18s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
0m 18s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 4 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
checkstyle
0m 12s

the patch passed

+1 :green_heart:
mvnsite
0m 21s

the patch passed

+1 :green_heart:
javadoc
0m 21s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 18s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
0m 52s

the patch passed

+1 :green_heart:
shadedclient
20m 40s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
27m 22s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 28s

The patch does not generate ASF License warnings.

110m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7108/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7108

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux c6da30ecfecc 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
HDFS-17531 / 49d758770a01e77bc4009a130ecc0f602e58f17a

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7108/2/testReport/

Max. process+thread count
4200 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7108/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Will add UTs these days.

Hi @hfutatzhanghb And fix the blanks.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 20s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ HDFS-17531 Compile Tests _

+1 :green_heart:
mvninstall
33m 16s

HDFS-17531 passed

+1 :green_heart:
compile
0m 26s

HDFS-17531 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
0m 22s

HDFS-17531 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
0m 19s

HDFS-17531 passed

+1 :green_heart:
mvnsite
0m 25s

HDFS-17531 passed

+1 :green_heart:
javadoc
0m 26s

HDFS-17531 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 19s

HDFS-17531 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
0m 51s

HDFS-17531 passed

+1 :green_heart:
shadedclient
21m 36s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 19s

the patch passed

+1 :green_heart:
compile
0m 22s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
0m 22s

the patch passed

+1 :green_heart:
compile
0m 18s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
0m 18s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 11s

the patch passed

+1 :green_heart:
mvnsite
0m 20s

the patch passed

+1 :green_heart:
javadoc
0m 17s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 17s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
0m 55s

the patch passed

+1 :green_heart:
shadedclient
21m 56s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
26m  8s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 20s

The patch does not generate ASF License warnings.

110m 53s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7108/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7108

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux f8dde2ba4f95 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
HDFS-17531 / 7d6bff243ca8443bc27a19d142549c025460f04e

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7108/3/testReport/

Max. process+thread count
3906 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7108/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 19s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ HDFS-17531 Compile Tests _

+1 :green_heart:
mvninstall
34m 17s

HDFS-17531 passed

+1 :green_heart:
compile
0m 33s

HDFS-17531 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
0m 22s

HDFS-17531 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
0m 21s

HDFS-17531 passed

+1 :green_heart:
mvnsite
0m 25s

HDFS-17531 passed

+1 :green_heart:
javadoc
0m 27s

HDFS-17531 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 19s

HDFS-17531 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
0m 53s

HDFS-17531 passed

+1 :green_heart:
shadedclient
21m 53s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 21s

the patch passed

+1 :green_heart:
compile
0m 24s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
0m 24s

the patch passed

+1 :green_heart:
compile
0m 19s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
0m 19s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 14s

the patch passed

+1 :green_heart:
mvnsite
0m 25s

the patch passed

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 18s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
0m 58s

the patch passed

+1 :green_heart:
shadedclient
24m 24s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
27m  2s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 27s

The patch does not generate ASF License warnings.

116m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7108/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7108

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 9999e40218b7 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
HDFS-17531 / c5f26e25549ba4ba3c16ea228927b7679b37a969

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7108/4/testReport/

Max. process+thread count
4094 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7108/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 19s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ HDFS-17531 Compile Tests _

+1 :green_heart:
mvninstall
36m 34s

HDFS-17531 passed

+1 :green_heart:
compile
0m 31s

HDFS-17531 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
0m 23s

HDFS-17531 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
0m 24s

HDFS-17531 passed

+1 :green_heart:
mvnsite
0m 31s

HDFS-17531 passed

+1 :green_heart:
javadoc
0m 30s

HDFS-17531 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 23s

HDFS-17531 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
0m 59s

HDFS-17531 passed

+1 :green_heart:
shadedclient
20m 55s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 19s

the patch passed

+1 :green_heart:
compile
0m 23s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
0m 23s

the patch passed

+1 :green_heart:
compile
0m 18s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
0m 18s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 13s

the patch passed

+1 :green_heart:
mvnsite
0m 23s

the patch passed

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 17s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
0m 53s

the patch passed

+1 :green_heart:
shadedclient
20m 27s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
27m 21s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 25s

The patch does not generate ASF License warnings.

114m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7108/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7108

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 9927b7053920 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
HDFS-17531 / 5123f66cbbb10667892b7816763efe082c1f2c60

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7108/5/testReport/

Max. process+thread count
4034 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7108/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 21s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ HDFS-17531 Compile Tests _

+1 :green_heart:
mvninstall
33m 13s

HDFS-17531 passed

+1 :green_heart:
compile
0m 28s

HDFS-17531 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
0m 24s

HDFS-17531 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
0m 21s

HDFS-17531 passed

+1 :green_heart:
mvnsite
0m 30s

HDFS-17531 passed

+1 :green_heart:
javadoc
0m 27s

HDFS-17531 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 19s

HDFS-17531 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
0m 56s

HDFS-17531 passed

+1 :green_heart:
shadedclient
21m 46s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 19s

the patch passed

+1 :green_heart:
compile
0m 22s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
0m 22s

the patch passed

+1 :green_heart:
compile
0m 18s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
0m 18s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 11s

the patch passed

+1 :green_heart:
mvnsite
0m 20s

the patch passed

+1 :green_heart:
javadoc
0m 17s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 15s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
0m 49s

the patch passed

+1 :green_heart:
shadedclient
22m 10s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
25m 55s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 22s

The patch does not generate ASF License warnings.

111m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7108/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7108

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 2ea3b4a1a943 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
HDFS-17531 / cb4d99a8f0727ece662a62208c43e22f313e4063

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7108/6/testReport/

Max. process+thread count
4303 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7108/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hfutatzhanghb LGTM. @Hexiaoqiao If you have time, please take a look.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 20s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ HDFS-17531 Compile Tests _

+1 :green_heart:
mvninstall
35m 23s

HDFS-17531 passed

+1 :green_heart:
compile
0m 28s

HDFS-17531 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
0m 23s

HDFS-17531 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
0m 19s

HDFS-17531 passed

+1 :green_heart:
mvnsite
0m 26s

HDFS-17531 passed

+1 :green_heart:
javadoc
0m 29s

HDFS-17531 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 20s

HDFS-17531 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
0m 51s

HDFS-17531 passed

+1 :green_heart:
shadedclient
22m 33s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 19s

the patch passed

+1 :green_heart:
compile
0m 21s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
0m 21s

the patch passed

+1 :green_heart:
compile
0m 18s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
0m 18s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m  9s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)

+1 :green_heart:
mvnsite
0m 19s

the patch passed

+1 :green_heart:
javadoc
0m 17s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 16s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
0m 54s

the patch passed

+1 :green_heart:
shadedclient
22m 14s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
26m 22s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 23s

The patch does not generate ASF License warnings.

114m 21s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7108/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7108

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux e7d0786dee65 5.15.0-124-generic #134-Ubuntu SMP Fri Sep 27 20:20:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
HDFS-17531 / ee52b3cb56fabcc8aef74fa2718e54bcf47a60e4

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7108/7/testReport/

Max. process+thread count
3802 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7108/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hfutatzhanghb @KeeProMise Thanks for your works. It's better to add another unit test to cover it and please fix checkstyle first. Thanks.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 19s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ HDFS-17531 Compile Tests _

+1 :green_heart:
mvninstall
33m 41s

HDFS-17531 passed

+1 :green_heart:
compile
0m 29s

HDFS-17531 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
0m 23s

HDFS-17531 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
0m 23s

HDFS-17531 passed

+1 :green_heart:
mvnsite
0m 28s

HDFS-17531 passed

+1 :green_heart:
javadoc
0m 29s

HDFS-17531 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 18s

HDFS-17531 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
0m 54s

HDFS-17531 passed

+1 :green_heart:
shadedclient
20m 22s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 22s

the patch passed

+1 :green_heart:
compile
0m 24s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
0m 24s

the patch passed

+1 :green_heart:
compile
0m 18s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
0m 18s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 12s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)

+1 :green_heart:
mvnsite
0m 22s

the patch passed

+1 :green_heart:
javadoc
0m 17s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 18s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
0m 53s

the patch passed

+1 :green_heart:
shadedclient
20m 25s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
27m 38s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 26s

The patch does not generate ASF License warnings.

110m 18s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.federation.router.TestRouterClientRejectOverload

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7108/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7108

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux feb2cb6409e2 5.15.0-124-generic #134-Ubuntu SMP Fri Sep 27 20:20:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
HDFS-17531 / e0ca34bcbd126566bbff2f1f1c641b95e949beda

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7108/8/testReport/

Max. process+thread count
3801 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7108/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Hi @hfutatzhanghb Please check the checkstyle and there is one unused import - org.apache.hadoop.hdfs.server.federation.router.RouterRpcClient.isExpectedClass. Thanks.

Hi @hfutatzhanghb Please check the checkstyle and there is one unused import - org.apache.hadoop.hdfs.server.federation.router.RouterRpcClient.isExpectedClass. Thanks.

@Hexiaoqiao Thanks sir. have fixed.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
7m  1s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ HDFS-17531 Compile Tests _

+1 :green_heart:
mvninstall
35m 57s

HDFS-17531 passed

+1 :green_heart:
compile
0m 28s

HDFS-17531 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
0m 25s

HDFS-17531 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
0m 22s

HDFS-17531 passed

+1 :green_heart:
mvnsite
0m 27s

HDFS-17531 passed

+1 :green_heart:
javadoc
0m 29s

HDFS-17531 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 22s

HDFS-17531 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
0m 58s

HDFS-17531 passed

+1 :green_heart:
shadedclient
20m 27s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 21s

the patch passed

+1 :green_heart:
compile
0m 23s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
0m 23s

the patch passed

+1 :green_heart:
compile
0m 17s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
0m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 11s

the patch passed

+1 :green_heart:
mvnsite
0m 22s

the patch passed

+1 :green_heart:
javadoc
0m 21s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 18s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
0m 50s

the patch passed

+1 :green_heart:
shadedclient
20m 28s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
27m 43s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 25s

The patch does not generate ASF License warnings.

119m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7108/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7108

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 39fdc3f83013 5.15.0-124-generic #134-Ubuntu SMP Fri Sep 27 20:20:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
HDFS-17531 / a703b8956784a56eedf73274458a273a9a70a3cc

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7108/9/testReport/

Max. process+thread count
3746 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7108/9/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
6m 41s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ HDFS-17531 Compile Tests _

+1 :green_heart:
mvninstall
33m 48s

HDFS-17531 passed

+1 :green_heart:
compile
0m 24s

HDFS-17531 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
0m 24s

HDFS-17531 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
0m 22s

HDFS-17531 passed

+1 :green_heart:
mvnsite
0m 31s

HDFS-17531 passed

+1 :green_heart:
javadoc
0m 31s

HDFS-17531 passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 22s

HDFS-17531 passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
0m 57s

HDFS-17531 passed

+1 :green_heart:
shadedclient
20m 39s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 19s

the patch passed

+1 :green_heart:
compile
0m 22s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
0m 22s

the patch passed

+1 :green_heart:
compile
0m 18s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
0m 18s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 13s

the patch passed

+1 :green_heart:
mvnsite
0m 22s

the patch passed

+1 :green_heart:
javadoc
0m 19s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 18s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
0m 51s

the patch passed

+1 :green_heart:
shadedclient
20m 38s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
27m 47s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 27s

The patch does not generate ASF License warnings.

117m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7108/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7108

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 7916db7af11f 5.15.0-124-generic #134-Ubuntu SMP Fri Sep 27 20:20:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
HDFS-17531 / bee8a8d1f98794ef8cb81d4bccdad0ac223e72a9

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7108/10/testReport/

Max. process+thread count
4491 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7108/10/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hfutatzhanghb Thanks for your contribution, and @Hexiaoqiao thanks for your review.


Update Sinon to latest version

Closing this PR in favor of a single one that updates all dependencies.


Added redis PUBSUB and Post processing scripts

As discussed, to keep all the python files at 1 place i.e. snafu , I am adding the redis pubsub python scripts here.
In addition to that, I am also adding a wrapper for smallfile to post process the data generated by smallfile.

Code for redis is removed.

Title is misleading -- this is for smallfile, right?

@chawlanikhil24 ?

@jtaleric is there any AI on me for this, else can we get it merged ?

rebased

Can we change the directory and file name to smallfile_wrapper, it would cut down on future changes to change all dashes to underscores.

@acalhounRH Can you please point me to the line of code, where you are suggesting the changes ?

@chawlanikhil24 I am working with Alex Calhoun to leverage run_snafu.py with smallfile and fs-drift, so that we don't have to copy-and-paste all the Elasticsearch-related code in every benchmark.    See run_snafu.py in development branch of snafu repo.   I'll try to take what you did here and incorporate it.  My branch (not yet a PR) is off the development branch, and is called smallfile-run-snafu.   I'll add one for fs-drift also.

Closing this as changes have been merged through #41


[BUG] Windows depthai=2.0.0 is not finding the module

Once I updated depthai to 2.0  to run the depthai-python examples I run into issues not being able to import the module.
To Reproduce
Steps to reproduce the behavior:

pip install depthai==2.0
python -c "import depthai"
error : "module depthai not found"
This seems to happen only in Windows. In my mac machine seems to be working fine.

Thanks for the report.  Will investigate.

Hi @piperod ,
So I just heard back.  So 2.0 actually had a bug specific to Windows that made it not install/work on Windows.  This was hotfixed to make <IP_ADDRESS>, so anything <IP_ADDRESS>+ should not have this problem.
Thoughts?
Thanks,
Brandon


Fixes errors when building on GPU.

The main programming issue was calling deep_copy() on GPU.  There was also an unknown linker issue related to our use of RDC.  Its nature is not fully understood, but can be fixed by using smaller kernels.
Linking still fails on solver.cpp, so this commit is just the first round of fixes.

I'm creating this as a PR to test on CPU rather than rebuilding my Kokkos stack (which is currently built for CUDA)

Note: Remaining build failure is the same as in target branch.  Feel free to merge


Use time from input and send it to backend

This works now, but there is a little problem. The backend is returning a non-json on this endpoint but documenting the response as application/json.
There are 2 things that can be done on the backend.
1- return an actual json
2- update the API to return text
I'll put together a PR in the backend repo to deal with this issue


protobuf 3.0 (byteswap) issue on macOS

https://github.com/dashpay/dash/commit/8c64c0a7cfcc96572abc1548529f6d6f8061f31e

only file that needs to be done is src/compat/byteswap.h
But the whole commit should be cherry picked.
Bounty: 500 CRW


Document more clearly the expectation that templates all live in a project directory

I've used cookiecutter a fair amount but was just for the first time experimenting with building my own.  In the process I ran into a NonTemplatedInputDirException when doing this simple layout:
test-cookie.py <-- includes a templated value
cookiecutter.json

While the name of the exception makes it pretty clear what the problem was, it doesn't make clear the solution, nor is there any clear reference to it in the docs. Eventually I came upon https://github.com/audreyr/cookiecutter/issues/1068#issuecomment-406096641 by @pydanny, which was extremely helpful in clearing things up.  However, I wouldn't have had to go hunting through the issue tracker if this rule/philosophy was somewhere in the documentation.
So the question is: should this be in the documentation?  And if so, where? (I thought perhaps Troubleshooting, but it really would have been more helpful to see it before I hit the exception, perhaps in one of the examples?)  If someone points me in the direction I'm happy to submit a PR on this, just would appreciate some guidance (which could also be "we don't really care where it goes, use your judgement").

I think this would be beneficial. I'm a first time user of cookiecutter and I found my way here by virtue of working this out the hard way.


Add XP to profile

This is a duplicate of #318 , to be merged into a new 'xp' branch.
TODO

[ ] Create XP branch

Features

XP and grade values are 0 by default (less dependence on undefined values)
Betcha button is enabled
Progress bar is enabled

Issues fixes

#316 (partial)
Fixes #300

Pull Request Test Coverage Report for Build 696

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
14 unchanged lines in 3 files lost coverage.
Overall coverage remained the same at 26.065%

Files with Coverage Reduction
New Missed Lines
%

src/components/dropdown/Profile.tsx
1
76.92%

src/reducers/states.ts
2
89.19%

src/components/assessment/index.tsx
11
80.0%

Totals

Change from base Build 689:
0.0%

Covered Lines:
885

Relevant Lines:
2890

💛  - Coveralls


Port binding fails silently on macOS 13.1

Bug Description
When the TCP port (e.g. 3306) is already in use (in my case by an unrelated Docker container) there is nothing in the output of the cloud_sql_proxy to suggest that anything is amiss. This led to quite a bit of confusion until I finally realized what was going on.
Example code (or command)
cloud_sql_proxy -instances=my-gcp-proxy:us-central1:my-instance-name=tcp:3306 -credential_file my-key-filejson

Stacktrace
2023/03/14 14:27:47 current FDs rlimit set to 245760, wanted limit is 8500. Nothing to do here.
2023/03/14 14:27:47 using credential file for authentication<EMAIL_ADDRESS>2023/03/14 14:27:47 Listening on <IP_ADDRESS>:3306 for my-gcp-proxy:us-central1:my-instance-name
2023/03/14 14:27:47 Ready for new connections
2023/03/14 14:27:47 Generated RSA key in 67.019489ms

### Steps to reproduce?

1. Have another process bind to port 3306 (in my case an unrelated Docker container)
2. Start the cloud_sql_proxy and tell it to use the same port
3. Observe that no error is present in the logs
4. Think that you're talking on 3306 to your Cloud SQL instance
5. Realize that you aren't... you're connected to whatever previously had 3306 (in my case a random Docker container)

### Environment

1. OS type and version: macOS 13.1 (build 22C65)
2. Cloud SQL Proxy version (`./cloud-sql-proxy --version`): 1.33.2+darwin.amd64
3. Proxy invocation command: cloud_sql_proxy -instances=my-gcp-proxy:us-central1:my-instance-name=tcp:3306 -credential_file my-key-filejson

### Additional Details

_No response_

Have you tried this on v2?

@enocom I just tested on v2 and it appears to actually override the port-binding from Docker and work as expected (or more closely to what is expected: connecting the the Cloud SQL instance). Not sure why it is able to hijack a port-binding from Docker but that's probably a matter for Docker not Cloud SQL Proxy. Thanks for pointing me to the existence of v2.

That's encouraging. We'll investigate what's going on with the v1 Proxy in the meantime. Either way, we strongly recommend upgrading to v2 -- it has better stability, a more configurable CLI interface, and support for metrics/tracing/Prometheus.

I can't reproduce this. Here's what I did. First in one shell:
nc -l <IP_ADDRESS> 3306

And then in another shell:
./cloud_sql_proxy -instances <INSTANCE_CONNECTION_NAME>=tcp:3306
2023/05/11 12:58:17 current FDs rlimit set to 61440, wanted limit is 8500. Nothing to do here.
2023/05/11 12:58:18 listen tcp <IP_ADDRESS>:3306: bind: address already in use

Since you're working with v2, I'm going to close this. If for whatever reason you still need v1, let's talk further here.


Create the slides for the workshop

The script should be something like:

A newcomer sharing his experience
What are video games?
Video games workflow
Game Engines: frameworks for games creation
Godot Engine basic concepts

All in Godot are Nodes
Nodes are organized in hierarchies
Nodes are added to Scenes
Complex scenes are built composing simpler reusable and configurable scenes
The logic is implemented in GDScript, similar to Python but with better threading support

Creating a 2D video game
Godot editor

Your first project
Your first Scene
Adding Nodes to the Scene
Timers: adding nodes, score ...

Physics
First steps with GDScript
Completing the 2D Game
Debugging
Next steps

Video Games

Games based on Computer Graphics (CG)
A story with animated graphics (video), sounds (music) and interactive
The main goal is to enjoy the experience
Challenges
Different categories: strategy, platforms, puzzles, educative, ...

Modern games:

Network, multiplayer
3D
Interactive movies

Workflow

Screenplay in which the game will be based

Design it based on scenes/levels/....

Assets creation

Images for the elements of the game: player, enemies, environment, backgrounds ...
Music and sounds

Scenes design
Scenes implementation

Newcomer experience

Long experience developing in different lanaguages: C, C++, Perl, Java, Python, Javascript, Scala ...
Experience in design and architecture of software systems
Experience playing and testing different technologies
Love to learn new things
Interest in computer design tools: GIMP, Blender ...
I have never created a video game before this 6 months experience
I like strategy and simulation games, but until my kids, I have not played games for many years
McThings 3D creation tool for Minecraft was my launch in this new 3D games world (motivated becuase my kids love Minecraft): https://github.com/Voxelers/mcthings/
Collaborating in Voxelers project: the world is based of voxels. Let's implement it like that in computers!

https://docs.google.com/presentation/d/1GOt6_FWRoXFm3WaLyj7P2h24ZCK5WqHVG6FI8nAExPs/edit#slide=id.g970a49b173_0_2

Probably in 2-3h I can complete the slides and to have the workshop ready.

Mostly completed. Just missing some final touches for the 30 slides presentation.
Next step is to test it recording a video with the full experience. During the recording I will adjust the slides.

Ok, OBS tested and all ready to record the workshop. I will try to do it around 1h in order to have some margin. With the 15 min extra, we can decide in which to invest more time.

Video recorded: 1h38m in Spanish. and without covering 3D or voxels. I need to go directly to the workshop activities in order to make it in 1h15m.

Final steps:

Add reference to this workshop: https://www.juntosdesdecasa.com/index.php/project/crea-tu-primer-videojuego-de-plataformas-con-godot/
Add an initial video about 3D current status to motivate people


Windows build is broken when optimization is turned off

(And has been for quite a while.) Building the stag1 stdlib segfaults.

Would be super nice to have this for 0.1

Seems to have worked itself out!


Add contributors

@all-contributorsrc please add @fraxken for code, bug, doc, security

@all-contributors please add @fraxken for code, bug, doc, security


fix: header actions collapsing section header

[x] Changes have been thoroughly tested to not break existing functionality.
[ ] New functionality has been documented or existing documentation has been updated to reflect changes.
[ ] Visual changes are explained in the PR description using a screenshot/recording of before and after.

Currently using ->headerActions with collapsible causes the click on the action to toggle de section collapsed state.
Before:
https://github.com/filamentphp/filament/assets/14329460/a2573ad8-1c39-4ca9-a0a2-b36b8edd7213
After: (the modal is outside the captured portion of the screen)
https://github.com/filamentphp/filament/assets/14329460/483aba5a-12a7-4c12-a00c-e81df0f11c54

@zepfietje i've opted to use a click listener on the actions to not nest the section icon, heading and description inside another div. But that would work also.

Thanks for fixing this, @saade.
Kinda tricky to have the entire header clickable while containing actions...
(I didn't notice this when the header actions PR got merged.)
I guess this PR implements a nice solution, but let's ask @danharrin for a final opinion.


Add skip_download get parameter

This PR adds the ability to skip downloading the file on a get. Useful for skipping the implicit get after a put, or for triggering a job that doesn't actually use the file.
Regards,
Dave

We need this too.

in the s3 resource, the skip_download is a string instead of bool. do you want to keep consistent with s3 resource? @davewalter

Hi @syslxg,
I think skip_download is defined as a string in the get params because it also exists as a source configuration. It is defined as a bool in the source, but as a string in the get so that they can tell if it has been set there at all. Defining it as a bool in the get would default it to false, and then it wouldn't be possible to determine if this was intentional or just the default value.
I could add support for the source definition if you think it would be good to match the s3-resource. Let me know what you think.
Regards,
Dave

Now this works great in our pipelines. Thanks for making this PR, @davewalter

This would help with our work. 👍

Thanks @davewalter


Create a Storybook entry with data from POZO

Håvard and I have the intersection.json file to try this out.
Note that the file cannot be published because the data is confidential, we would have to create an analogous file for showing this in the public storybook

Still tbd discussed how the data is supposed to look like ("mangled") when put to the storybook. Start with testing on locally stored data.

Closing. Will be requested again if the documentation for this is still relevant.


gpuCI broken

This has been raised on https://github.com/dask/dask/pull/11242 already but I always have difficulties finding that draft PR and the failures are not related to a version update from what I can tell.
gpuCI has been pretty consistently failing for a while now.
Logs show something like (from https://github.com/dask/dask/pull/11310 // https://gpuci.gpuopenanalytics.com/job/dask/job/dask/job/prb/job/dask-prb/6185/console)
15:05:47 GitHub pull request #11310 of commit 355b76fc0632708894cfc1c17ce55b80cef8bbbb, no merge conflicts.
15:05:47 Running as SYSTEM
15:05:47 Setting status of 355b76fc0632708894cfc1c17ce55b80cef8bbbb to PENDING with url https://gpuci.gpuopenanalytics.com/job/dask/job/dask/job/prb/job/dask-prb/6185/ and message: 'Running'
15:05:47 Using context: gpuCI/dask/pr-builder
15:10:13 FATAL: java.io.IOException: Unexpected EOF
15:10:13 java.io.IOException: Unexpected EOF
15:10:13 	at hudson.remoting.ChunkedInputStream.readUntilBreak(ChunkedInputStream.java:101)
15:10:13 	at hudson.remoting.ChunkedCommandTransport.readBlock(ChunkedCommandTransport.java:39)
15:10:13 	at hudson.remoting.AbstractSynchronousByteArrayCommandTransport.read(AbstractSynchronousByteArrayCommandTransport.java:34)
15:10:13 	at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:61)
15:10:13 Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to EC2 (aws-b) - runner-m5d2xl (i-00c57ce783f1c62db)
15:10:13 		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1787)
15:10:13 		at hudson.remoting.Request.call(Request.java:199)
15:10:13 		at hudson.remoting.Channel.call(Channel.java:1002)
15:10:13 		at hudson.Launcher$RemoteLauncher.launch(Launcher.java:1121)
15:10:13 		at hudson.Launcher$ProcStarter.start(Launcher.java:506)
15:10:13 		at hudson.Launcher$ProcStarter.join(Launcher.java:517)
15:10:13 		at com.gpuopenanalytics.jenkins.remotedocker.AbstractDockerLauncher.parseVersion(AbstractDockerLauncher.java:193)
15:10:13 		at com.gpuopenanalytics.jenkins.remotedocker.AbstractDockerLauncher.<init>(AbstractDockerLauncher.java:54)
15:10:13 		at com.gpuopenanalytics.jenkins.remotedocker.DockerLauncher.<init>(DockerLauncher.java:54)
15:10:13 		at com.gpuopenanalytics.jenkins.remotedocker.RemoteDockerBuildWrapper.decorateLauncher(RemoteDockerBuildWrapper.java:164)
15:10:13 		at hudson.model.AbstractBuild$AbstractBuildExecution.createLauncher(AbstractBuild.java:613)
15:10:13 		at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:485)
15:10:13 		at hudson.model.Run.execute(Run.java:1894)
15:10:13 		at hudson.matrix.MatrixBuild.run(MatrixBuild.java:323)
15:10:13 		at hudson.model.ResourceController.execute(ResourceController.java:101)
15:10:13 		at hudson.model.Executor.run(Executor.java:442)
15:10:13 Caused: hudson.remoting.RequestAbortedException
15:10:13 	at hudson.remoting.Request.abort(Request.java:346)
15:10:13 	at hudson.remoting.Channel.terminate(Channel.java:1083)
15:10:13 	at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:90)
15:10:13 Setting status of 355b76fc0632708894cfc1c17ce55b80cef8bbbb to FAILURE with url https://gpuci.gpuopenanalytics.com/job/dask/job/dask/job/prb/job/dask-prb/6185/ and message: 'Build failure
15:10:13  '
15:10:13 Using context: gpuCI/dask/pr-builder
15:10:13 Finished: FAILURE

cc @dask/gpu

Thanks for raising an issue @fjetter - I'll definitely work on getting gpuCI back in a passing state today.
I'm not sure what is causing the build failure, but I do know some recent dask/array work has definitely broken cupy support.

I'm really sorry there has been so much unwanted gpuCI noise lately. It looks like gpuCI is now "fixed" in the sense that the pytests should all pass. However, the java.io.IOException described at the top of this issue does still happen intermittently for some reason.
We have not figured out how to fix this intermittent failure yet. However, it you do happen to see this failure in the wild, members of the dask org can re-run the gpuCI check (and only that check) by commenting: Rerun tests (e.g. https://github.com/dask/dask/pull/11294#issuecomment-2307391540)
cc @fjetter @phofl @jrbourbeau @hendrikmakait (just to make sure you know about Rerun tests)

@dask/gpu gpuCI appears to be broken again. One example https://github.com/dask/dask/pull/11354 but there are other failures and it looks quite intermittent. Looking at Jenkins this almost feels like a gpuCI internal problem.

Looking at Jenkins this almost feels like a gpuCI internal problem.

Right, the failures are intermittent, and can always be re-run with a Rerun tests comment (typically takes a few minutes for gpuCI to turn green after you make the comment).
Our ops team is working on a replacement to our current Jenkins infrastructure at the moment. I'm sorry again for the noise.

How long will it take to replace the Jenkins infra? I currently feel gpuCI is not delivering a lot of value and is just noise. Would you mind if we disabled this until it is reliable again?

How long will it take to replace the Jenkins infra? I currently feel gpuCI is not delivering a lot of value and is just noise. Would you mind if we disabled this until it is reliable again?

We are discussing this internally to figure out the best way to proceed, but I do have a strong preference to keep gpuCI turned on for now if you/others are willing.
Our team obviously finds gpuCI valuable, but I do understand why you would see things a different way. When gpuCI was actually broken a few weeks ago (not just flaky the way it is now), changes were merged into main that broke cupy support. In theory, gpuCI is a convenient way for contributors/maintainers to know right away if a new change is likely to break GPU compatibility.
The alternative is of course that we (RAPIDS) run our own nightly tests against main, and raise an issue when something breaks. In some cases, the fix will be simple. In others, the change could be a nightmare to roll back or fix. What would be an ideal developer experience on your end? I'm hoping we can work toward something that makes everyone "happy enough".

Roughly a year ago we had proposed moving Dask to a GitHub Actions based system for GPU CI in issue: https://github.com/dask/community/issues/348
We didn't hear much from other maintainers there (admittedly there could have been offline discussion I'm unaware of)
Perhaps it is worth reading that issue and sharing your thoughts on that approach? 🙂


add deps.rs security tracker tag to README

helps remind us to update dependencies regularly to patch security issues

Thanks for the PR!
I do think it'd be a good idea to add an audit step to CI, to make sure new CI runs don't download dependencies that need fixing.
However, I don't want to add a badge about it. Rust and Cargo allows libraries to state the minimum version of a dependency they need, but they don't need to be constantly updating that minimum version. Any new projects will automatically use the newest allowed version of all the dependencies, and existing projects can run cargo audit and then cargo update -p whatever to update. For example, the deps.rs page linked suggests hyper is depending on vulnerable code in futures-util, but it isn't. hyper just sets 0.3.x as a valid dependency, and any user can update in their own project.

So I'm going to close this, to not add a badge. I still think it'd be good to add an audit step in CI.


Feature/php recipes

We have been using these chef recipes internally at AppFog to deploy our PHP environment and wanted to share.
Other points of interest:

Gems built by staging's Rakefile are gitignored
Removed an errant PHP staging spec from the cloud_controller tree
Cloud Controller's welcome message and database adapter are configurable
Some DEA configuration values are now configurable by chef (defaults are preserved)

pulled with a few fixes.. thanks


Add --xctestrun-file for iOS

#365

Codecov Report

Merging #424 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #424      +/-   ##
============================================
+ Coverage     79.17%   79.18%   +0.01%
- Complexity      603      605       +2
============================================
  Files            69       69
  Lines          1762     1763       +1
  Branches        267      267
============================================
+ Hits           1395     1396       +1
  Misses          196      196
  Partials        171      171


Configurable Mutalyzer EMAIL setting

Probably use the same value for mail_service_status_address from mail-service-status and base_server_admin_email from base-server.

We also have mutalyzer_batch_notification_email now.


⚠ Bofrost.lu has degraded performance

In 0c1f115, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1700 ms

Resolved: Bofrost.lu performance has improved in 59f154c after 7 minutes.


Added starting of fuzzer tool

Please note that for legal reasons we require you to sign the
Contributor Agreement
before we can accept your pull requests.
Code changes and contributions in the VelocyPack library should use
the "Google" style and conventions as used by clang-format.

Coverage remained the same at 96.714% when pulling 0dcf970660cc240cf63425eb202c69b93baf3963 on feature/velocypack-fuzz-tool into 0f2aa825f08de5e160a8282430e5c52adf1c2a68 on main.


How to use micro with two routes?

How would I design a service with more then one route?
For example I have a event-trace-api service where I trace all transactions in my app and expose a api where I can search for these events,
So basically I have 2 routes:
POST /v1/events
GET /v1/events/search
Following micro design I would have 2 separate servers, one for create and other for search, that looks too much for me,
Thanks

I think you should use search as a query param instead of part of the url, then you can just check request.query.search and if it's undefined return the full list.
If you want to use search as part of the url then I'm sure you should to use 2 separate servers, one for the complete list and other one for the searched list.

Hi @sergiodxa thx for your reply,
That's not very intuitive to have one route to deal with POST and GET
Looks like micro is a nano-service lib and that's totally fine I think

Micro is just to create HTTP services using async/await and thinking in microservices, it's a wrapper for the http Node.js native module. But it not give you a router handler, you can use other router handlers which can receive the request object.
Thinking in how made that what about something like this?
import micro, {
  json,
  send,
  sendError,
} from 'micro';

/**
 * handle POST requests
 */
async function postHandler(request) { /* ... */ }
/**
 * handle GET requests
 */
async function getHandler(request) { /* ... */ }

/**
 * Check the request method and use postHandler or getHandler (or other method handlers)
 */
async function methodHandler(request, response) {
  try {
    switch (request.method) {
    case 'POST':
      return await postHandler(request);
    case 'GET':
      return await getHandler(request);
    default:
      send(response, 405, 'Invalid method');
      break;
    }
  } catch (error) {
    throw error;
  }
}

/**
 * our micro service, run methodHandler and send result as a response (or an error)
 */
const server = micro(async (request, response) => {
  try {
    send(response, 200, await methodHandler(request));
  } catch (error) {
    sendError(request, response, error);
  }
});

server.listen(process.env.PORT);

This way you have a function for each valid method.

@sergiodxa thank you very much for your explanation,
I thought doing this would go against micro principals design,
And this design totally fit into my trace-events-api service that I have running in production now,
Cheers

@sergiodxa that's a beautiful example. Thank you for contributing it.
If you want routes, you can write another micro service that maps routes to backends, or use something like Nginx. You would host each of your services under a subdomain or port independently.
We're running 20+ microservices already in production. We had to use routing once, and we simply matched req.url and a simple string comparison.
If you need a sophisticated routing mechanism, you're probably doing too much in one Node process. You'll pay in the form of more complicated debugging, conflated logging and lack of error isolation.

Based on your example, in fact, I see that you want to do versioning. Not having routing built in is great for this.
Let's say /v2/events/search is the same, but /v2/events POST changed. You basically can bump versions by simply forwarding all v2 traffic to the existing v1 backends, and only add one exception, for /v2/events to go to add-event-2.0.0.yourhost.com. URLs are just labels!

Great explanation @rauchg
I'll think on how to design this on Heroku, I don't have nginx right there,
Are you doing in your production servers "one server for one route"?
Cheers

Indeed. I have no experience with Heroku.

But hey I'm going to remove koajs form some microservices in production and use micro right now \o

@sergiodxa I'm not sure we have request.query in micro's request object. Or I'm wrong?

@diorahman yes, I just tried it and in the request object we don't have request.query, but it's possible to use url and querystring to get it in one line.
import qs from 'querystring';
import url from 'url';

async function requestHandler(request, response) {
  const query = qs.parse(url.parse(request.url).query);
  // do something
}

What about resources? E.g. the user with ID 1 would usually be /users/1. What would this look like in micro?

I think you should do that yourself (I suppose with a RegEx), but I will quote @rauchg here:

If you need a sophisticated routing mechanism, you're probably doing too much in one Node process. You'll pay in the form of more complicated debugging, conflated logging and lack of error isolation.

A simple match utility would be nice for that. Not sure if it exists but:
const { id } = match('/users/:id', url);

would return {} for no match (eg: '/user'), { id: 1 } for /users/1 etc. Kind of saves you the trouble of checking that the regexp returns null, looking for the index of the capture group, etc.

@sergiodxa I don't think that quote applies here. I mean, you wouldn't want a micro service just for getting single users, and then a microservice for getting a list of users, would you?
@rauchg Sure, I guess that'd work.

@sergiodxa You can simplify your one-liner by adding true to url.parse():
const parsed = url.parse(request.url, true);
console.log(parsed.query);

Related:

https://github.com/gnoesiboe/route-match
https://github.com/polmiro/url-match

Great resources, thanks @TooTallNate!
@rauchg Any plans on adding wiki pages with this content? I'm thinking of examples and/or resources. I think it would be beneficial.

@onbjerg that sound fantastic. It'd be cool to index the Wiki pages on the README for quick reference as well. PRs welcome

@rauchg Cool! You just need to enable the wiki first 👍

@rauchg Any updates on the wiki? 💃

@rauchg I went ahead and created a little utility based on your idea for matching urls.
https://github.com/nblackburn/micro-match

Just wanted you guys to know that I have worked a tiny router and architecture suggestions that work great with micro :) https://github.com/domachine/http-service-router

When your intention is boilerplating, but it is ended up putting to much sugar https://github.com/diorahman/mcrsvc LOL!

@diorahman To be honest, routes shouldn't really be in a micro-service if possible. Limiting for HTTP method is alright.

@onbjerg true, yeah. I'm still struggle on how to get the best workflow on building set of services, without sacrificing start time. Still think on deployment, api gateway seems the best way, but how about the development phase?


Add Create to Order

Update OrderService to have Create
Update Order-related fields to omitempty since Shopify can accept minimal order information
Update NoteAttributes to Marshal from lowercase
Add MetafieldsService to Order

Oh my, I misspelled the merge commit message 😂


fix: upload dataset stale download

RDEV: https://thuang-stale-download-frontend.rdev.single-cell.czi.technology/?rc=true&curator=true
Reviewers
Functional:
@seve

Changes

modify
Looks like CXG is now part of dataset.dataset_assets, so we no longer need to rely on dataset.dataset_deployments to infer CXG has been converted. This is the root cause of the off by one issue that causes the bug!

Definition of Done (from ticket)
QA steps (optional)

Upload a dataset
Wait till the process completes
Click download icon to see if all three formats are available (should be)
Upload another dataset
Wait till the process completes
Click download icon to see if all three formats are available <--- this is where the bug was. But now all 3 formats should  be available!

Known Issues
N/A

Thanks for the quick review, Seve! Merging 🚀 !!


ImportError: libpcl_visualization.so.1.8: cannot open shared object file: No such file or directory

Hi Dear
I tried to run the code but I got this sort of error
ImportError: libpcl_visualization.so.1.8: cannot open shared object file: No such file or directory
I have tried to install the pcl module but I face the same problem!!!
may I got a help to settle this issue
I would appreciate your help

I think the best solution for problems related to environment or libraries is to search in google or other forums. Really hope to help you, but this kind of problem is really dependent to each situation.. If you paste the full error msg, maybe I can find something.

I think the best solution for problems related to environment or libraries is to search in google or other forums. Really hope to help you, but this kind of problem is really dependent to each situation.. If you paste the full error msg, maybe I can find something.

Thanks for your reply
Here is the the massage
(marwan2) marwan@marwan:~/Downloads/zib file/Active-Perception-release/DQN$ python main.py --is_train=True Traceback (most recent call last):   File "main.py", line 11, in <module>     from dqn.agent_8 import Agent   File "/home/marwan/Downloads/zib file/Active-Perception-release/DQN/dqn/agent_8.py", line 16, in <module>     from .replay_memory import ReplayMemory   File "/home/marwan/Downloads/zib file/Active-Perception-release/DQN/dqn/replay_memory.py", line 8, in <module>     from util.utils import *   File "/home/marwan/Downloads/zib file/Active-Perception-release/DQN/util/utils.py", line 6, in <module>     import pcl   File "/home/marwan/anaconda2/envs/marwan2/lib/python3.6/site-packages/pcl/__init__.py", line 2, in <module>     from ._pcl import * ImportError: libpcl_visualization.so.1.8: cannot open shared object file: No such file or directory
I appreciate your help

Thanks for your reply
Here is the the massage
(marwan2) marwan@marwan:~/Downloads/zib file/Active-Perception-release/DQN$ python main.py --is_train=True Traceback (most recent call last):   File "main.py", line 11, in <module>     from dqn.agent_8 import Agent   File "/home/marwan/Downloads/zib file/Active-Perception-release/DQN/dqn/agent_8.py", line 16, in <module>     from .replay_memory import ReplayMemory   File "/home/marwan/Downloads/zib file/Active-Perception-release/DQN/dqn/replay_memory.py", line 8, in <module>     from util.utils import *   File "/home/marwan/Downloads/zib file/Active-Perception-release/DQN/util/utils.py", line 6, in <module>     import pcl   File "/home/marwan/anaconda2/envs/marwan2/lib/python3.6/site-packages/pcl/__init__.py", line 2, in <module>     from ._pcl import * ImportError: libpcl_visualization.so.1.8: cannot open shared object file: No such file or directory
I appreciate your help

It seems that the pcl module is broken in your environment: (you lost the link or the file of libpcl_visualization.so.1.8). You can paste this(from ._pcl import * ImportError: libpcl_visualization.so.1.8: cannot open shared object file: No such file or directory) and search in google. Here is what I found: https://github.com/strawlab/python-pcl/issues/158, and you can try it.

It seems that the pcl module is broken in your environment: (you lost the link or the file of libpcl_visualization.so.1.8). You can paste this(from ._pcl import * ImportError: libpcl_visualization.so.1.8: cannot open shared object file: No such file or directory) and search in google. Here is what I found: https://github.com/strawlab/python-pcl/issues/158, and you can try it.


Valkyrie and other apps hang on direct acknowledger call

Describe the bug
Periodically valkyrie will stop reading from kafka for a dataset and never restart until valkyrie is restarted completely. It looks like it gets hung up while sending an acknowledgement to kafka.
To Reproduce
Steps to reproduce the behavior:

Wait a few weeks and valkyrie will do this

Expected behavior
It doesn't do this.
Tech notes
We are several versions behind on Elsa, which valkyrie uses to talk to kafka. There have been several brod and Elsa updates related to the acknowledger so it would be good to just roll that in and watch valkyrie with it for awhile

An elsa upgrade "should" fix this


Who can cancel a subscription?

1st table says only account admin can cancel a subscription (and subscription admin/co-admin can not).
However, 2nd table says subscription admin/co-admin are equivalent to Owner. And https://docs.microsoft.com/en-us/azure/billing/billing-how-to-cancel-azure-subscription says Owners can cancel subscriptions.
That appears to be a contradiction.
Please can you clarify if subscription admins / co-admins are able to cancel a subscription?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3deb77d4-07ed-feeb-2a80-cb5fe5a39b9d
Version Independent ID: 4a292cfd-6d08-5e22-8900-843b9347187e
Content: Classic subscription administrator roles, Azure RBAC roles, and Azure AD administrator roles
Content Source: articles/role-based-access-control/rbac-and-directory-admin-roles.md
Service: role-based-access-control
GitHub Login: @rolyon
Microsoft Alias: rolyon

@jtuliani
Thanks for your feedback! We will investigate and update as appropriate.

Hi @jtuliani
I did a test with a Co-Administrator and it appears they can cancel a subscription. So I think both a Service Administrator or a Co-Administrator can cancel a subscription.

Hi @jtuliani
We updated the document to include a line about cancelling the subscription.
https://docs.microsoft.com/en-us/azure/role-based-access-control/rbac-and-directory-admin-roles#classic-subscription-administrator-roles
Let us know if you have any additional feedback.
thanks

#please-close


Clear the start and end times for derivative calls

Derivatives rely on the underlying iterator to handle start and end
times. They do not perform them or organize points into groups. In
certain circumstances, the start time or end time that got implicitly
passed could be on an uneven interval with the first point returned by
the aggregate, which caused the entire iterator not to be read.
This fixes #5571.

:+1:


First two sections translated into German

Too many merge commits for my opinion. Any suggestions on how to handle branching/merging with multiple remotes would be greatly appreciated.

@greasan Thanks for the awesome work. You could try doing an interactive rebase and squash all the commits into one. https://www.atlassian.com/git/tutorials/rewriting-history/git-rebase-i
Another thing you could do on long running feature branches is to do git pull --rebase when there are changes to the main branch you want in your commit.

I'm going ahead and merging this anyway. It's fine to have multiple commits. @BerkeleyTrue is right, though, squashing commits is a best practice for the clarity of the reflog (though I honestly don't get around to doing this myself).

Thanks a lot. Great tips.


www.nixos.org: serve an SSL certificate

Currently https://www.nixos.org/ is an SSL certificate CN mismatch error page. :(

Maybe we should just remove the DNS entry for www.nixos.org instead?

I think that will hurt us more than fixing the redirect. Many people (even people like us) still expect a www unfortunately.


Use new IP for apple.com

Apple.com now has a new IP. The old IP cannot be used. The new IP is found by HE DNS.

Thanks for the PR.


Actions cheatsheet

Overview
TL;DR

Questions
<If relevant, write a list of questions that you would like to discuss related to the changes that you have made.>
Next Steps
<If incomplete, create a task list of items that are still being worked on within the Pull Request.>
Review
<If complete, or ready for :eyes:, use @mentions for quick questions, specific feedback, and progress updates.>
lemme get dat!!!

I am going to close this PR. The actions-cheatsheet work has been moved to https://github.com/github/actions-cheat-sheet


Key '0xAAA...' has not been registered by any identity, and a separate 'author' was not supplied

When sending a POST to /messages/private using a resolved signing key, I get the following result:
Payload:
{
  "header": {
    "tag": "TestingNewSigningKey",
    "key":"0x53b7680df9b0644e3bd6490a09ba07768839d47f"
  },
  "data": [
    {
      "value": "Data"
    }
  ]
}

Request:
{
    "error": "FF10206: Invalid author specified: FF10356: Key '0x53b7680df9b0644e3bd6490a09ba07768839d47f' has not been registered by any identity, and a separate 'author' was not supplied"
}

chainwall.log

firefly.log

evmconnect.log

I think this is behaving as designed. If you use a signing key that isn't registered to a FireFly identity, you have to also specify an "author" (in the form of a DID).

Yes, @awrichar this is working as intended. Meant to close this earlier.


nullptr->shared_ptr typecast for gcc 4.4

Had to extend our nullptr imitator to account for recently-introduced uses of shared_ptr

LGTM. Merging once green.

Green!


Crash with potted plants

Game crashes everytime i try to place a plant from this mod in a flower pot
crash-2023-03-13_05.23.54-client.txt

Thanks for the report, not sure how I didn't catch this. Fixed in version 2.0.1.


Add syahmi file

this file is for tutorial and for further class

great tutorial with easy to understand session

great tutorial with easy to understand session


The frozen column doesn't follow the hover color on DataGrid

The frozen column doesn't follow the hover colour on the DataGrid
What package(s) are you using?

[X] Carbon for IBM Products (or Carbon for IBM Cloud & Cognitive)
[ ] Legacy/CDAI
[ ] Legacy/Security

Detailed description

Describe in detail the issue you're having.
When the user hovers a row, the frozen column doesn't follow the hover color on the DataGrid. This is from this fix

Is this issue related to a specific component?
DataGrid

What did you expect to happen? What happened instead? What would you like to
see changed?
Should remain the same as other columns

What browser are you working in?
Chrome

What version of the @carbon/ibm-products (or @carbon/ibm-cloud-cognitive)
package are you using?
v2.26.0

What offering/product do you work on? Any pressing ship or release dates we
should be aware of?

Steps to reproduce the issue

Step one
Step two
Step three
etc.

Please create a reduced test case in CodeSandbox
https://codesandbox.io/s/github/carbon-design-system/ibm-products/tree/main/examples/carbon-for-ibm-products/SidePanel

Additional information

Screenshots or code
Notes

Just adding another note to this defect, this is also true when a row is selected. The rest of the row is highlighted expect the sticky action column.


Send LobbyExit message when a lobby exits without actually starting a game

The message to the tracker should include the same information as the lobby start packet.

Hmmm, this should already be doing this.  @arbruijn did the work back in 2019.  Did we break something? 🤔


Refactor patient registration

Created patientWizard and step components in common.patient module
Changed controllerAs on patientDetails
Moved tabManager to common.patient module
Moved addressFields template to patient-details module
Throw Error on getPatientConfiguration if appService not initialized
Deleted PatientCommonController, UpdatePatientController
Deleted unnused views

Coverage increased (+0.9%) to 66.667% when pulling ff26c1e277a600846cc8cf40a54b4b28eb11e37a on ynurmahomed:refactor-registration into fb84b6cc534c525aedf03aec072fa4f61d7c66c5 on esaude:master.