Buttons Dont Work?

I am having issues with the PowerPoint Create a PowerPoint task pane add-in tutorial and getting the code to run. Any help would be much appreciated!
https://learn.microsoft.com/en-us/office/dev/add-ins/tutorials/powerpoint-tutorial

@alison-mk Can you take a look?
@spags09 Sorry to hear that you're hitting issues.
Can you provide as many details as you can to help us repro and debug?
Your Environment
Include as many relevant details about the environment so we can triage your issue

Platform [PC desktop, Mac, iOS, Office on the web]: ______
Host [Excel, Word, PowerPoint, etc.]: ______
Office version number: ______
Operating System: ______
Browser (if using Office on the web): ______

Expected behavior
Tell us what you expected to happen

Current behavior
Tell us what happens instead of the expected behavior

Steps to reproduce
If we cannot reproduce the issue, we cannot triage

Useful logs
Please include any of the following logs that may help us debugging your issue

[ ] Console errors
[ ] Screenshots
[ ] Test file (if only happens on a particular file)

Thanks.

Platform [PC desktop, Mac, iOS, Office on the web]: PC Desktop
Host [Excel, Word, PowerPoint, etc.]: PowerPoint
Office version number: Microsoft® PowerPoint® for Microsoft 365 MSO (Version 2208 Build 16.0.15601.20540) 64-bit
Operating System: WIN10
Browser (if using Office on the web): Edge Dev
I am expecting to click the Image Button and have it populate Bing Image of the day onto the ppt slide. But when I click the button nothing happens. When I add the other buttons, as outlined in the tutorial, nothing happens with each of them when clicked. Im sure it is user error at this point since I am new to this and trying to teach myself with this tutorial. I just dont understand why its not working at this point - not sure how to troubleshoot.
Thanks for the quick response and help!! :)

Hi @spags09, thanks for submitting an issue. Which version of Visual Studio are you using to build the project? Please check whether it's Visual Studio 2019 or 2022, and then provide the version number within. This will help us test properly.
In my preliminary testing in Visual Studio 2019, I noticed that the Home.html file is referencing a version of jQuery that isn't present in the project files. Line 7 in Home.html should read:
<script src="Scripts/jquery-3.6.4.js" type="text/javascript"></script>
I'm working on a solution for this discrepancy. Let me know if this jQuery fix resolves your issue.
If your add-in still isn't working, try exploring our debugging docs for Visual Studio: Debug an Excel, PowerPoint, or Word add-in project to see if the add-in is returning console errors. In particular, start the add-in and then use the personality menu to attach a debugger:

If you're seeing console errors, please report back with those.
Thanks,
Alison

Alison -
Thanks for the quick response! That definitely made the difference. I am now just receiving a console error when clicking "Insert Image". Below is the concole error. How do I provide access?
[cid:67aa8914-4a74-4c67-b7a5-6f312fb1dda9]

Ryan

From: Alison McKay @.>
Sent: Friday, March 17, 2023 3:53 PM
To: OfficeDev/office-js-docs-pr @.>
Cc: spags09 @.>; Mention @.>
Subject: Re: [OfficeDev/office-js-docs-pr] Buttons Dont Work? (Issue #3921)
Hi @spags09https://github.com/spags09, thanks for submitting an issue. Which version of Visual Studio are you using to build the project? Please check whether it's Visual Studio 2019 or 2022, and then provide the version number within. This will help us test properly.
In my preliminary testing in Visual Studio 2019, I noticed that the Home.html file is referencing a version of jQuery that isn't present in the project files. Line 7 in Home.html should read:

I'm working on a solution for this discrepancy. Let me know if this jQuery fix resolves your issue.
If your add-in still isn't working, try exploring our debugging docs for Visual Studio: Debug an Excel, PowerPoint, or Word add-in projecthttps://learn.microsoft.com/en-us/office/dev/add-ins/develop/debug-office-add-ins-in-visual-studio#debug-an-excel-powerpoint-or-word-add-in-project to see if the add-in is returning console errors. In particular, start the add-in and then use the personality menu to attach a debugger:
[image]https://user-images.githubusercontent.com/7977793/226015496-19091e20-df40-4757-8ece-37c970e3d9fe.png
If you're seeing console errors, please report back with those.
Thanks,
Alison
—
Reply to this email directly, view it on GitHubhttps://github.com/OfficeDev/office-js-docs-pr/issues/3921#issuecomment-1474342299, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKKQHZMEKIP7PASYYRVHMADW4S6LNANCNFSM6AAAAAAV6RTZFY.
You are receiving this because you were mentioned.Message ID: @.***>

@spags09 It looks like the image you tried to include didn't make it through the system. Could you type out the error, or paste the image into the GitHub issue?
Thanks,
Alison

@alison-mk here is the text file from the console.
Bing Image Console Error.log

Hi @spags09, I can replicate this bug with the image — selecting Insert Image in Test the add-in step 3 returns a 404 error in the console — but unfortunately I don't have a solution for it yet. I'm researching the issue internally.
Regarding the jQuery version, I'm updating my guidance. The jQuery version installed with the Visual Studio solution matches the jQuery call within the solution files, and it should not be updated. I suspect that when you used the NuGet Package Manager to install the required packages, you also ran the suggested updates (which is what I did initially, too) and that's why jQuery initially threw an error. I've added a note to the tutorial to clarify this point.
I'll leave this issue open while we work to resolve the 404 error.
Thank you,
Alison

@RyanSpagnuolo We're working on a fix for this. Please do try out the updated instructions in the related PR and let us know if you're still facing issues.
Thanks.


Fix requests asyncio if input data is async gen

Can be viewed with the autorest test "test_file_body_upload_generator" if we pass an async gen with requests on asyncio.

(message created by the CI based on PR content)

For some reason status got not updated to Github, but build green....


"Don't pad in imfilter_fft if size(kernel)==size(img)"

Here is a (perhaps too simplistic) « fix ».

Looks good. Seems like we didn't have any tests for "circular", so I won't make you add one :smile:

Thanks for the contribution!

Tests added in #401


std::ostringstream vs. fmt::MemoryWriter for simple string concatation

I would like to know if there are any notable differences in speed.

I don't have any specific numbers, but with fmt::MemoryWriter you can avoid dynamic memory allocation if the resulting string size is less than INLINE_BUFFER_SIZE which is currently set to 500. You can also avoid construction of std::string and access the buffer directly. On integer formatting, MemoryWriter is about 8 times faster than std::ostringstream (http://zverovich.net/2013/09/07/integer-to-string-conversion-in-cplusplus.html), but on string formatting the difference is likely to be smaller.


why xcode8 error?

xcode8 with  HGCircularSlider 1.0.2
what can i do ?

resolved

but how can i do this like your dome?

Hi @CoderYLZhang,
If your project is in Swift 3 and you use Xcode 8, normally you don't need to do any change.
Where you find "Unsupported Version 3.0"? why you need to have this in your project ? your project build successfully after changing "Use Legacy Swift Language Version" to 'No' ?
Thanks a lot


[Bug Report] dprint_tensix_dest_reg on Grayskull

Describe the bug
dprint_tensix_dest_reg does not work properly on Grayskull.
It prints the first 8 columns of each face correctly, then repeats these for the last 8 columns (rather than printing the values actually in those columns).
 Also include '#include "tt_metal/hw/inc/debug/dprint_tensix.h"'.
Run 'TT_METAL_DPRINT_CORES=0,0 pytest -svv tests/ttnn/unit_tests/operations/test_max_pool2d.py' maxpool test
See error in printed Dst outputs.
Note: occurs when running other tests as well, this is just one example.

Expected behavior
I expect that the debug print should print the last 8 columns of each Dst face, rather than repeating the first 8 in their place.
Please complete the following environment information:

OS: Ubuntu 20.04
On main

Waiting on repo permissions. This is the fix:
diff --git a/common/inc/ckernel_debug.h b/common/inc/ckernel_debug.h
index efae256..c6f1237 100644
--- a/common/inc/ckernel_debug.h
+++ b/common/inc/ckernel_debug.h
@@ -211,6 +211,7 @@ inline void dbg_get_array_row(const uint32_t array_id, const uint32_t row_addr,
     dbg_bus_cntl.f.en = 1;

     for (uint32_t i=0; i<8; i++) {
+       dbg_bus_cntl.f.sig_sel = i >> 2;
        dbg_bus_cntl.f.rd_sel = i<<1; // Sel 16-bit
        reg_write(RISCV_DEBUG_REG_DBG_BUS_CNTL_REG, dbg_bus_cntl.val);
        wait (5); // Wait for value to get stable

Waiting on repo permissions. This is the fix:
diff --git a/common/inc/ckernel_debug.h b/common/inc/ckernel_debug.h
index efae256..c6f1237 100644
--- a/common/inc/ckernel_debug.h
+++ b/common/inc/ckernel_debug.h
@@ -211,6 +211,7 @@ inline void dbg_get_array_row(const uint32_t array_id, const uint32_t row_addr,
     dbg_bus_cntl.f.en = 1;

     for (uint32_t i=0; i<8; i++) {
+       dbg_bus_cntl.f.sig_sel = i >> 2;
        dbg_bus_cntl.f.rd_sel = i<<1; // Sel 16-bit
        reg_write(RISCV_DEBUG_REG_DBG_BUS_CNTL_REG, dbg_bus_cntl.val);
        wait (5); // Wait for value to get stable

This fix was implemented and tested in: https://github.com/tenstorrent/tt-metal/pull/8317


Update styles after added/removed nodes

Make the child observer invoke styles update after any child is either added or removed.
Fixes #117

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


SHOW MEASUREMENTS ON databasename-with--

Display error if database name contains the character -  example:  pfsense-ipsec
SHOW MEASUREMENTS ON pfsense-3cx-openvpn
400: Bad Request
Error details
You should probably look at "response" key
Error {config: Object, request: XMLHttpRequest, response: Object, isAxiosError: true, toJSON: ƒ ()}
config: Object
url: "http://<IP_ADDRESS>:8086/query"
method: "post"
params: Object
data: "q=SHOW%20MEASUREMENTS%20ON%20pfsense-3cx-openvpn"
headers: Object
auth: Object
transformRequest: Array(1)
transformResponse: Array(1)
timeout: 0
adapter: ƒ ()
xsrfCookieName: "XSRF-TOKEN"
xsrfHeaderName: "X-XSRF-TOKEN"
maxContentLength: -1
validateStatus: ƒ validateStatus()
unsafeSsl: ""
__typename: "FormData"

request: XMLHttpRequest
response: Object
data: "error "error parsing query: found -, expected ; at line 1, char 29" "
status: 400
statusText: "Bad Request"
headers: Object
config: Object
request: XMLHttpRequest

isAxiosError: true
toJSON: ƒ ()

Hi @netbix,
Thanks for reporting that issue. Please check newest version https://github.com/timeseriesadmin/timeseriesadmin/releases/tag/v0.1.11

Perfect ! I have test windows and docker !

thank you


Should group unreleased changes together and avoid version number for it

Updated the changelog slightly to make it clear what is released and not:

Grouped unreleased changes under a single [Unreleased] section
Removed version numbers to avoid confusion (as the versions do not actually exist)

I am happy with that.

Sweet, next PR, would you mind simply approving?
In case I realize something last minute that have to be changed before merge.

Sure, no problem. I have to get used to this way of working ;-)


Blockquote component

#219
Hi,
1.I created the Blockquote component according to the code layout of the project.
2.I made it according to the examples and style scheme on the Flowbite and React-Flowbite sites.
3.I created the doc page for Blockquote and added it to the navigation.
4.I created sample components for the doc page and added their usage as well.
5.I did not add all the description content on the Flowbite site, I just created examples for size, align and type and added them to the doc page.
I hope the component turned out the way you wanted. I worked hard for this and I would be very happy if you accept my PR.
I will be waiting for your feedback.
@Sqrcz @cogor @zoltanszogyenyi @robert1508

Summary by CodeRabbit

New Features

Introduced a comprehensive documentation file for blockquote components, enhancing usability and navigation.
Added several new Vue.js components demonstrating various styles and configurations of blockquotes, including alignment and size options.
Implemented a new customizable blockquote component to provide flexible usage in applications.

Bug Fixes

No bug fixes were included in this release.

Documentation

Enhanced documentation with detailed examples and usage instructions for blockquote components, facilitating easier integration for developers.

I put the FwbBlockquote component under typograpy.
I removed the props for size and alignment.
I edited the example files and updated the doc page as well.
I implemented the lint rules (finally)

I hope it turned out the way you wanted.
@Sqrcz


Fixing problems with 1) the KKT formulation, 2) discretizer - [merged]

In GitLab by @cmastalli on Dec 6, 2018, 17:47
Merges topic/unittest -> devel
In this PR, I did two main task:

Fixing a problem in the formulation of the KKT problem.
Describing the Euler discretizer as simpletic one.

Additionally, I included few other unit-tests:

Checking the integration values for a linear system.
Checking the Vx against the KKT Lagrangian multipliers.

The unit-test (2) tackles fully the point 2 from #36.

In GitLab by @cmastalli on Dec 6, 2018, 17:47
merged

In GitLab by @cmastalli on Dec 6, 2018, 17:47
mentioned in commit a15080c7868a2f8c9ec92c1982471af9426a3039


SIGTERM Not Forwarded to Component Process for bin/pulsar Script, Preventing Clean Shutdown

I am deploying a pulsar cluster on Kubernetes using the apachepulsar/pulsar-all:2.6.2 docker image. I start each of the component containers using the bin/pulsar script. This is the same method used by the pulsar helm chart.
I've noticed that when stopping any of the component pods (Zookeeper, Broker, Bookkeeper), they do not run their shutdown hooks, but are instead killed forcefully after the configured grace period. In looking at the bin/pulsar script, I can see that the script ends by running exec on the java process without trapping the SIGTERM sent to the container and forwarding it to the process's pid. For example, here is the script that starts a bookie pod:
https://github.com/apache/pulsar/blob/411bf71006039af661be13c54dda4ce074f97679/bin/pulsar#L312
Because we don't forward it, the java process never receives the SIGTERM notification. I'd like to propose modifying the bin/pulsar script to properly trap the SIGTERM and pass it to the process.
I'm happy to submit a PR if there is support for this idea.
Additionally, I noticed that there is a bin/pulsar-daemon script that starts a component process and writes the pid to a file in an attempt to properly manage the communicate the SIGTERM. However, the way that script is written, it exits after dispatching the component process, which leads the container to exit. It seems like this script would have a different use case than running in a container. Further, I don't see a use case where someone would want to run any of the components using bin/pulsar without being able to cleanly shut them down.

The same improvement could be made to the bin/bookkeeper script in the bookkeeper project.

@michaeljmarshall  It might be an issue in the deployment too. I recently fixed a related problem in the helm charts with https://github.com/apache/pulsar-helm-chart/pull/59 . Please check that your deployment doesn't block the signals.
What is the problem in using exec? I'd assume that it's the best practice.

@lhotari - thanks for your quick comment. You're right that the issue was with my deployment, and that by changing bin/pulsar bookie to exec bin/pulsar bookie, the sigterm is properly handled by the component process.
In case anyone else runs across this, I started with this:
    spec:
      containers:
      - args:
        - bin/apply-config-from-env.py conf/broker.conf && bin/apply-config-from-env.py
          conf/pulsar_env.sh && bin/gen-yml-from-env.py conf/functions_worker.yml
          && bin/pulsar broker
        command:
        - sh
        - -c

and changed it to this:
    spec:
      containers:
      - args:
        - bin/apply-config-from-env.py conf/broker.conf && bin/apply-config-from-env.py
          conf/pulsar_env.sh && bin/gen-yml-from-env.py conf/functions_worker.yml
          && exec bin/pulsar broker
        command:
        - sh
        - -c

and now it works.


Build Single File for Distribution

I'm building a small app that will need to act as a library for a client. They will need to pull a single JS and CSS file from me and then initialize my code using their own JS files. Therefore, I need to find a way to build my project into a single JS and a single CSS file. Is there a way to build with this in mind?
Example:
index.html

<link rel="stylesheet" type="text/css" href="my_app.com/my_library_style.css"></link>

index.js
// after page loaded
my_library.init({
  //options here
});

I am not worried about giving these files pleasant names, I am only concerned with building them into single files or automating the pulling of the other files of a build from my server.

Isn't npm run build providing you with a single file?

I was under the impression that npm run build would commonly split the build into multiple files in order to give your code the "Just in time" code feel (pulling in code only if/when it is necessary to enable certainly functionality)? If I'm wrong, then this is a non-issue. :)

No, by default it bundles everything into a single JS file. You do have an option of code splitting (by calling require.ensure), but it's not the default.

When there is a custom stylesheet specified in the index.html file, it's not included in the bundle built for production.
Just import it from the src/index.css file (make sure you import index.css before App like here: #2470)


Dark mode

https://hellodash.pythonanywhere.com/

@AnnMarieW gave some recommandations here. Thanks a lot!

This seems to be the solution! https://community.plotly.com/t/how-to-make-themeswitchaio-change-the-css-class/68647/4?u=remidm


Setup coveralls support

Can an admin for the project setup coveralls (https://coveralls.io) support? That way we can have  badge for code coverage and the service will also comment on PRs.

@ianobermiller -- Almost done with this. I've noticed we've got:
    "collectCoverageOnlyFrom": {
      "modules/get-state.js": true,
      "modules/resolve-styles.js": true,
      "modules/wrap.js": true
    },

Should we open up coverage reports for all of modules/*?

Probably, I'm sure we can properly test Style.
On Fri, May 8, 2015, 8:27 AM Ryan Roemer<EMAIL_ADDRESS>wrote:

@ianobermiller https://github.com/ianobermiller -- Almost done with
this. I've noticed we've got:
"collectCoverageOnlyFrom": {
  "modules/get-state.js": true,
  "modules/resolve-styles.js": true,
  "modules/wrap.js": true
},

Should we open up coverage reports for all of modules/*?
—
Reply to this email directly or view it on GitHub
https://github.com/FormidableLabs/radium/issues/136#issuecomment-100272918
.


Fixing param sets link

https://github.com/MicrosoftDocs/office-docs-powershell/issues/5535

Docs Build status updates of commit 997dd9f:
:clock10: Full build: the average full build time is 17 min(s) 10 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 997dd9f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Remove-SPOGeoAdministrator.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 9a907e7:
:clock10: Full build: the average full build time is 17 min(s) 10 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 9a907e7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Remove-SPOGeoAdministrator.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


search: move @backstage/plugin-search-backend-node to @backstage/plugin-search-node

Hey, I just made a Pull Request!
Replaces #25877. Updates the name of search-backend-node to match our naming scheme by removing the backend component of the name.
There might be more to do here still, but getting the PR up to see what CI has to say.
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[ ] All your commits have a Signed-off-by line in the message. (more info)

Given that it turned out #25877 was mergeable, I'm inclined to drop this. Kinda nice to have some example cases that don't match the convention! Happy to discuss more though @Rugvip @benjdlambert


Ruler track text is fuzzy

Closed with commit b103bcbb

Still fuzzy for me

Hmmm ... Text is very sharp on my display. Are you using an old monitor or old OS? Blurry text is indeed a known issue with Canvas. There is ways of try and achieve sharp text that I have not looked into yet: https://www.html5rocks.com/en/tutorials/canvas/hidpi/

A new iMac
On Mon, Mar 6, 2017 at 2:26 PM, Douglass Turner<EMAIL_ADDRESS>wrote:

Hmmm ... Text is very sharp on my display. Are you using an old monitor or
old OS? Blurry text is indeed a known issue with Canvas. There is ways of
try and achieve sharp text that I have not looked into yet:
https://www.html5rocks.com/en/tutorials/canvas/hidpi/
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/igvteam/juicebox.js/issues/11#issuecomment-284554307,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA49HPocHRaAw3mWoP4pxb1aJdZzrG8Hks5rjIgFgaJpZM4MS9zI
.

Text is blurry on my high DPI devices (iMac, MacBook).   Its sharp on my
"old" Dell monitor.
On Mon, Mar 6, 2017 at 2:40 PM, James Robinson<EMAIL_ADDRESS>wrote:

A new iMac
On Mon, Mar 6, 2017 at 2:26 PM, Douglass Turner<EMAIL_ADDRESS>wrote:

Hmmm ... Text is very sharp on my display. Are you using an old monitor
or old OS? Blurry text is indeed a known issue with Canvas. There is ways
of try and achieve sharp text that I have not looked into yet:
https://www.html5rocks.com/en/tutorials/canvas/hidpi/
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/igvteam/juicebox.js/issues/11#issuecomment-284554307,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA49HPocHRaAw3mWoP4pxb1aJdZzrG8Hks5rjIgFgaJpZM4MS9zI
.


ILauncher launch events and intercept

Is your feature request related to a problem? Please describe.
It's great that we now have a cross-platform URI/file launcher (ILauncher) in Avalonia. However, I would like to add the ability

to be notified by an event about the URI/file launch and
to intercept the call and handle the URI/file myself

Use cases are situations where you want to either a) redirect an external Uri (e.g. to you app's website) to a view within your app or b) your app uses Uri-based navigation (to perform UI actions based on the user invoking a Uri path).
In principle, it would even allow rewriting the URI (before launching a platform browser).
Describe the solution you'd like
I would like to introduce a new event on ILauncher implementations that gets invoked when a Uri/file launch happens. The event arguments should carry information about the Uri/file and have a property to cancel the default invocation.
Describe alternatives you've considered
Previously I had a custom Hyperlink(button) and URI launcher implementation. Having the launcher in Avalonia directly means that there will be third-party controls using ILauncher. So it would be great to have some flexibility to intercept, rewrite or handle Uri/file launch calls.
Additional context
No response

Sorry, but we don't plan on adding this API to the framework.
As it was discussed in the PR #15674, Avalonia providers a lower-level service implementation that interacts directly with the platform. It's a single responsibility of ILauncher interface - to call platform API.
It's also likely, that user might want to redefine behavior of HyperlinkButton, for example. For what they should handle ClickEvent (likely with Tunnel strategy) allowing them to handle button click in their own way. Optionally calling platform specific ILauncher if needed.
Example on how to do so:
public MainWindow()
{
    InitializeComponent();

    var button = MyHyperlinkButton;  // defined in XAML
    // RoutingStrategies.Tunnel is important, when it's required to handle event before any default behavior.
    button.AddHandler(HyperlinkButton.ClickEvent, MyButton_OnClick, RoutingStrategies.Tunnel);
}

private void MyButton_OnClick(object sender, RoutedEventArgs e)
{
    e.Handled = true; // marking Handled = true will cancel any other hanlers coming after.
    var button = (HyperlinkButton)sender;

    if (button.NavigateUri?.Scheme == "my-scheme")
    {
        // custom handler if necessary, under some condition (in this case, I used a `Scheme` check.
    }
    else if (button.NavigateUri is not null)
    {
        // Fall back to platform ILauncher
        _ = TopLevel.GetTopLevel(this)!.Launcher.LaunchUriAsync(button.NavigateUri);
    }
}


Landing app update

Overview
This update will include all style/feature/copy changes/additions that will be applied to the landing app for LIGHT.  This will also include adding both the Tailwind and Daisy UI packages.  The updated Legal agreement will include a new Legal checklist component as the intro portion of the onboarding process will be largely composed of existing components from the game app.  This components will be rendered piecemeal as the user completes specific scripted commands presented to them in the chat display.

[x] Tailwind and Daisy UI and updated assets - The updated styling library and component libraries.

[x] Login Copy and Display - This includes the login feature that allows users to use their FB account to get their login cookie and navigate to either the game or the intro depending on whether or not it is their first time logging in.  If it is their first time they will have to complete the intro in order to proceed to the game.

[x] Legal Checklist Component - This component will consist of lines of legal agreements with check boxes next to each term.  This component will track the user's answers to each term and only allow them to proceed if they consent to all of the terms proposed.  The copy will be placeholder for now and be provided by legal closer to launch.

[x] Intro Display - The Intro feature will consist of the elements of the the in-game UI being gradually introduced as the user  completes scripted requests.  The will be the following:

The Message Display - The Message Display component is where agent and user messages appear.
The Chat Input - The Chat Input component is a text input where users can type messages they wish to send.  Both Say and Do Actions can be completed from here.  Initially however the user will only be able to say.  The "say/do" button and toggle feature will appear after the user sends their first greeting.
The Say/Do Button - The Say/Do Button component allows users to toggle between said and done actions by either clicking or pressing the ` key.  The User will be prompted to do something before being allow to move on to the next step.
Feedback buttons - The Feedback buttons components allow users to give both positive and negative feedback on another character's said/done messages.  If the user so chooses they can report a message they dislike or offer "star experience" to a message they like.  The user will be prompted to offer feedback on a message in order to progress to the end of the intro.
SideBar - Sidebar component will be revealed last; it contains information about the user's current environment.  This information will be hard coded to match the information in the tutorial they will enter after completing the intro to allow for a smooth transition between the landing app and the game app.  This component being revealed will mark the end of the intro.

Updated Todos

[ ] Add Custom block caret to to terminal style input.

[ ] Confirm final styling on components.

[ ] Add Larger Checkbox.

[ ] Add sidebar with co### Overview
This update will include all style/feature/copy changes/additions that will be applied to the landing app for LIGHT.  This will also include adding both the Tailwind and Daisy UI packages.  The updated Legal agreement will include a new Legal checklist component as the intro portion of the onboarding process will be largely composed of existing components from the game app.  This components will be rendered piecemeal as the user completes specific scripted commands presented to them in the chat display.

[x] Tailwind and Daisy UI and updated assets - The updated styling library and component libraries.

[x] Login Copy and Display - This includes the login feature that allows users to use their FB account to get their login cookie and navigate to either the game or the intro depending on whether or not it is their first time logging in.  If it is their first time they will have to complete the intro in order to proceed to the game.

[x] Legal Checklist Component - This component will consist of lines of legal agreements with check boxes next to each term.  This component will track the user's answers to each term and only allow them to proceed if they consent to all of the terms proposed.  The copy will be placeholder for now and be provided by legal closer to launch.

[x] Intro Display - The Intro feature will consist of the elements of the the in-game UI being gradually introduced as the user  completes scripted requests.  The will be the following:

The Message Display - The Message Display component is where agent and user messages appear.
The Chat Input - The Chat Input component is a text input where users can type messages they wish to send.  Both Say and Do Actions can be completed from here.  Initially however the user will only be able to say.  The "say/do" button and toggle feature will appear after the user sends their first greeting.
The Say/Do Button - The Say/Do Button component allows users to toggle between said and done actions by either clicking or pressing the ` key.  The User will be prompted to do something before being allow to move on to the next step.
Feedback buttons - The Feedback buttons components allow users to give both positive and negative feedback on another character's said/done messages.  If the user so chooses they can report a message they dislike or offer "star experience" to a message they like.  The user will be prompted to offer feedback on a message in order to progress to the end of the intro.
SideBar - Sidebar component will be revealed last; it contains information about the user's current environment.  This information will be hard coded to match the information in the tutorial they will enter after completing the intro to allow for a smooth transition between the landing app and the game app.  This component being revealed will mark the end of the intro.

Updated Todos

[ ] Add Custom block caret to to terminal style input.
[ ] Confirm final styling on components.
[ ] Add Larger Checkbox.
[ ] Add sidebar with context matching tutorial after final step of intro is completed.
[ ] Add type out animation effect to terminal style text and input.ntext matching tutorial after final step of intro is completed.
[ ] Add type out animation effect to terminal style text and input.

UPDATE
Baseline styles have been applied to all displays in landing app.

Welcome Display

Flow Step 1

Flow Step 2

User Rejects agreement

Pre Login Display

Flow Step 1

Flow Step 2

-### Post Login Legal Agreement
Flow Step 1

Flow Step 2

Intro Display
Flow Step 1

Flow Step 2

Flow Step 3

Flow Step 4

Additional Features/Fixes

Fixed Welcome flow.  Each input will be populated with preset text and autofocus upon each step being completed.
Welcome flows final input will allow user to say yes or no with entry starting with y or n at any case.
If user rejects term rejection text along with their last entry will render but the page will be static from that point on.
Login conditionally renders login button after user agrees to condition.
Post Login Legal Conditions now longer progress stepper upon agreeing to all terms but renders a submit agreement button upon checking each box.
Fixed bug where unchecking a box would leave submit button rendered but disabled.
Intro Display no longer has earn xp text under each agent bubble
Intro Display no longer renders star or flag upon user liking or disliking message.
Intro Display no longer has tooltips with information that does not apply.

Additional Notes
Currently all of the display works with a stepper but it can easily be configured to navigate between displays using react router.  Will Break each display into their own page as needed to match the needs of the flow.  Current Pre Login Links and text pairings are as follows:

LIGHT Supplemental Terms of Service and Meta Platform => https://docs.google.com/document/d/1RR5vo-ith7lBX--Pk7ErgD0gyjaktY-DR_SSsdLWEuc/edit#

Data Policy => https://www.facebook.com/about/privacy/update

here => https://www.facebook.com/policies/cookies/

Remaining Todos

[ ] Confirm Styling is as desired
[ ] Add typing animation to terminal text and inputs
[ ] Test flow with wiring to backend
[ ] Add links properly to copy using helper function.
[ ] Add Sidebar that matches tutorial upon completion of intro.


Handling errors inside stream of streams

Hey guys,
I'm trying to figure out how to properly catch errors that are emitted from a stream that I return from a flatMap, so the new stream the flatMap returns, will retrieve the error.
How would one do this?
Here's a code example show casing the issue I'm facing, which is I never reach the .errors handler with the error I emitted from the inside stream.
        var nodeStreamInsideStreams = _([1]);
        setTimeout(function(){
            nodeStreamInsideStreams.emit('error', new Error('Error inside stream of streams'));
        }, 1);
        _([10])
        .flatMap(function(value) {
            return _(nodeStreamInsideStreams);
        })
        .errors(function(err){
            console.log('we dont reach this place :()');
        })

Thanks

Generally, you can catch errors from flatMap the way you would expect. It's just that your example makes a couple of wrong assumptions.
First, Highland streams aren't the same as Node streams, so nodeStreamInsideStreams is misnamed. Furthermore, while the emit method exists on Highland streams, you practically never want to use it, since it doesn't play well with the rest of the API. You probably wanted a real node stream.
const nodeStreamInsideStreams = new stream.Transform({
  transform(data, encoding, callback) {
    callback(null, data);
  }
});

Second, Highland streams are lazy. Nothing happens until you consume them by calling one of the Consumption methods. In your example, you didn't consume the Highland stream that you created, so your handler would never have run. Here, you can just add each to consume the stream.
_([10])
    .flatMap((value) => _(nodeStreamInsideStreams))
    .errors((err) => console.log('We should see this.', err))
    .each((x) => console.log('Value: ', x));

The following should work
const stream = require('stream');
const _ = require('highland');

const nodeStreamInsideStreams = new stream.Transform({
  transform(data, encoding, callback) {
    callback(null, data);
  }
});

setTimeout(function(){
    nodeStreamInsideStreams.emit('error', new Error('Error inside stream of streams'));
}, 1);

_([10])
    .flatMap((value) => _(nodeStreamInsideStreams))
    .errors((err) => console.log('We should see this now.', err))
    .each((x) => console.log('Value: ', x));

That said, when interoping with Node streams, you want to wrap them in Highland streams as soon as possible (usually when the Node stream is created), since you don't know when an event may come through. Wrapping them in a Highland stream will make sure that the correct listeners are registered before any events are sent; otherwise, you risk losing data.
Furthermore, since Highland streams are lazy, you typically want to construct thing exactly when you need them and not before. In this case, that means you should construct the node stream inside the flatMap function and not outside.
So in actual code, you'll want something more like this
_([10])
    .flatMap((value) => {
      const nodeStreamInsideStreams = new stream.Transform({
        transform(data, encoding, callback) {
          callback(null, data);
        }
      });

      setTimeout(function(){
        nodeStreamInsideStreams.emit('error', new Error('Error inside stream of streams'));
      }, 1);

      return _(nodeStreamInsideStreams);
    })
    .errors((err) => console.log('We should see this now.', err))
    .each((x) => console.log('Value: ', x));

Thanks for the great reply.

Oops I forgot in the example to thunk :)
Yeah I changed it from a node stream to highland since I had the same issue in both cases, but I think that's because I didn't thunk.
I found a solution what your help:

const nodeStreamInsideStreams = _(streamify([1])).through(through())

This seems to propagate the error properly.


hls plyr.io not playing on computer

I am using hls plyr.io. I am trying to play a m3u8 but it only plays on mobile device. On my computer when I open same player it is not playing. Below is my js code. Can any one please help me to add user agent or something like that so that I can play on computer too. Please note that other m3u8 is playing on computer but only one m3u8 is not playing on pc but it plays on mobile fine. So I want to change something so that it can play on all devices.
<script src="https://cdn.jsdelivr.net/npm/hls.js@latest"></script>
<script src="https://cdn.plyr.io/3.6.8/plyr.polyfilled.js"></script>
                            <video controls preload="metadata" poster="https://i.imgur.com/zPslOur.jpg" id="player" class="plyr">
                              </video>
                              <script>document.addEventListener('DOMContentLoaded', () => {
  const source = 'https://example.com/hls/stream.m3u8';
  const video = document.querySelector('video');

  // For more options see: https://github.com/sampotts/plyr/#options
  // captions.update is required for captions to work with hls.js
  const player = new Plyr(video, { captions: { active: true, update: true, language: 'en' } });

  if (!Hls.isSupported()) {
    video.src = source;
  } else {
    // For more Hls.js options, see https://github.com/dailymotion/hls.js
    const hls = new Hls();
    hls.loadSource(source);
    hls.attachMedia(video);
    window.hls = hls;

    // Handle changing captions
    player.on('languagechange', () => {
      // Caption support is still flaky. See: https://github.com/sampotts/plyr/issues/994
      setTimeout(() => hls.subtitleTrack = player.currentTrack, 50);
    });
  }

  // Expose player so it can be used from the console
  window.player = player;
});</script>
<style>

Getting same Error but Not Get any solution


ci: remove --locked from check-runtime-migration script

Closes https://github.com/paritytech/pipeline-scripts/issues/104

bot merge


Prep for 0.9 Release

Add test for #50 - note that we cannot test on GitHub Actions because docker is not available on Windows
Update changelog
Dropped support for Python 3.4

Kicking CI to make sure we're all green


chore: set git identity on backport (#484)

Backport
This will backport the following commits from 2.x to 1.x:

chore: set git identity on backport (#484)

Questions ?
Please refer to the Backport tool documentation

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 485

Questions ?
Please refer to the Backport tool documentation


Unused imports are not reported in 2.13.2

Works great with Scala 2.13.1, tried with last version 0.1.12.
Is this something known ?
I see that on the README, it's tested only with 2.13.1

it appears from https://github.com/DavidGregory084/sbt-tpolecat/blob/master/src/main/scala/io/github/davidgregory084/TpolecatPlugin.scala that the plugin does enable -Wunused:imports
Not sure, but perhaps it's something specific to your code (and perhaps ultimately there's a scalac bug involved). Attempting to isolate the problem would resolve the question one way or the other.

Thanks for the response, I managed to reproduce the problem with a simple project https://github.com/GuillaumeSaintRaymondSonos/sbt-tpolecat-circe/
By default, unused warning reporting is working well with Scala 2.13.2 but when I add circe dependency and after adding a scalac option for @JsonCodec. This is where the behaviour is different between 2.13.1/2.13.2

sounds like not a problem in this repo, then. sounds to me like you should try circe issue tracker next, if the problem isn't reproducible without circe.
I wonder if it's related to https://github.com/scala/scala/pull/8799 . if you're really determined to track this down, one path forward would be to use git bisect or https://github.com/adriaanm/binfu/blob/master/bisect.sh to pinpoint the exact scala/scala PR when this regressed (and/or just browse all the merged 2.13.2 PRs yourself)

Scala 2.13.3 fixed the issue !


static routes give exception on dir listing

Hi folks! Just playing around with the library (nice work @kennethreitz !). Ran into a small issue in the docs and in code.
From the docs: It's not clear how to setup a static route to a folder of resources. The only mention is mapping '/' statically for SPAs. Not a major deal but something I noticed.
The error hower is probably worth looking at. If you have a folder structure such as:
├── static
│   └── css
│       ├── docs.css
│       └── theme.css

And map to this folder to serve up the CSS files as:
api.add_route("/static", static=True)
Then requests for the files work fine (e.g. http://<IP_ADDRESS>:5042/static/css/docs.css). But when requesting http://<IP_ADDRESS>:5042/static/ I was expecting 404 or dir listing not allowed or something. But rather got 500 internal server error.
TypeError: 'NoneType' object is not iterable
INFO: ('<IP_ADDRESS>', 58711) - "GET /static/ HTTP/1.1" 500

We probably don't want 404's to appear as 500 server errors for our logs or the users.

Hey,
Just to make things clear, static files serving is always enabled, by default it uses static_dir="static" and static_route="/static", you can set custom values when you first init responder.API.
api = responder.API(..., static_dir="my_static_dir", static_route="/my_route")

The api.add_route("/route", static=True) is for SPA, by default it looks for an "index.html" in the static dir.
So if you wanna serve static files (css, js,...), you don't need to to use api.add_route("/", static=True)

Hi,
I think you missed the problem here because I was screwing around with explicit static routes.
The problem is if you run responder, the visit the URL http://localhost:5000/static you will get a server 500. That is not the right response.
I was trying to reproduce this but cannot get Responder to run at all now. See #300 for another bug that is preventing it from running.

@mikeckennedy I'm aware of the bug and I was just trying to make things clear.
I've also made a quick fix #297, it's working but didn't want to merge it for now.

Thanks so much. Sorry I misunderstood you. Much appreciated!

You're welcome dude, no problem :D


Others link not working

The others link leads to an error page.

Thank you very much, the issue has been resolved!


using api to send email with template

Is it possible to send email using template with api? We use to do this in mailchimp and now we have a client that uses active campaign.

Same question for me


Peer Review - Add Diagram for System Boundaries and Components in Hazard analysis doc (optional)

Artifact Under Review
Hazard analysis - section 3
Team Number for Team Doing the Review
Team 2
Description of Issue
Add Diagram for System Boundaries and Components. This can be in the form of a UML diagram for example and serves as an aid for readers to understand better.
Note: this is not part of the rubric but is a good addition!

As discussed with our TA, we will not proceed with this issue. Thank you for the review!


Newsletter feature not working at all

Test

profile
indiv components
api

Hi,
Is this the mailchimp integration or rather integration with magento 2?
Maybe we can provide generic components and do the integration with either magento2 or maichimp in vue-storefront-api?
I'm actually working right now on mailchimp but also looking at replacing mailchimp with standard magento 2 functionality.

Related to #2754

@patzick  @mdesmet hello guys, I tested newsletter on develop branch, but unfortunately it doesn't work..
When I try update my preferences I have errors in dev console.

Also when I use "Subscribe" button.

@alinadivante: I will have a look tonight.

hi @mdesmet @patzick I tested changes on develop branch and an error appears when I try to subscribe newsletter from the footer or by changing preferences in my account (link to localhost)

@GabiDivante this feature requies the latest / develop version of vue-storefront-api deployed - which is not currently available on any public demo instance. SO the question is if You're using the local api in order to test it out?

@GabiDivante, @pkarw : i'll retest this one. To be honest, i didn't retest the frontpage newsletter subscription with last changes.

@pkarw  I wasn't using the local API so probably that's the cause.  @mdesmet that would be great, subscription from the front page for logged in users should work in the same way as changing subscriptions status in my account.

@mdesmet can You Please update us with the status?

Hi, it's working for me. I'm able to subscribe from the front page, so probably indeed it was not linking to the new api.


Add ControllerLeadershipManager as single place to check controller leadership changes

Step 1 of https://github.com/apache/incubator-pinot/issues/3600

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@6a6c175). Click here to learn what that means.
The diff coverage is 62.96%.

@@            Coverage Diff            @@
##             master    #3604   +/-   ##
=========================================
  Coverage          ?   70.77%
  Complexity        ?        4
=========================================
  Files             ?     1010
  Lines             ?    46311
  Branches          ?     6211
=========================================
  Hits              ?    32778
  Misses            ?    11373
  Partials          ?     2160

Impacted Files
Coverage Δ
Complexity Δ

...ntroller/helix/core/PinotHelixResourceManager.java
59.81% <ø> (ø)
0 <0> (?)

...not/controller/validation/StorageQuotaChecker.java
73.33% <0%> (ø)
0 <0> (?)

.../core/realtime/PinotLLCRealtimeSegmentManager.java
71.57% <100%> (ø)
0 <0> (?)

...elix/core/periodictask/ControllerPeriodicTask.java
97.22% <100%> (ø)
0 <0> (?)

...m/linkedin/pinot/controller/ControllerStarter.java
62.28% <100%> (ø)
0 <0> (?)

.../helix/core/realtime/SegmentCompletionManager.java
69.12% <33.33%> (ø)
0 <0> (?)

...lix/core/realtime/PinotRealtimeSegmentManager.java
71.35% <42.85%> (ø)
0 <0> (?)

.../pinot/controller/ControllerLeadershipManager.java
70.58% <70.58%> (ø)
0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a6c175...1de62ec. Read the comment docs.

Eventually, we do plan to distribute the load across controllers. Right now, each periodic task relies on running on  the controler  when it becomes leader (and stopping when it loses leadership).

Agree that the subscribers should not really know "leader" or "not leader", eventually, when we get to a distributed load model. As of now, the periodic tasks do check for leader before executing, and this is one way to get them to start/stop on leadership changes.
Even in the distributed model, the periodic tasks would have to start/stop and switch between the controller responsible for it.


irbuilderbpf.cpp, bpforc.h: Fix compilation with LLVM 11

Fixes: #1384
Fix the following build errors when compiling with LLVM 11:
#1
/llvm/include/llvm/ExecutionEngine/Orc/Legacy.h:118:35: error: no match for call to ‘(bpftrace::BpfOrc::BpfOrc(llvm::TargetMachine*)::<lambda(const string&)>) (llvm::StringRef)’
118 |     if (JITSymbol Sym = FindSymbol(S)) {
|                         ~~~~~~~~^~
/llvm/include/llvm/ExecutionEngine/Orc/Legacy.h:118:35: note: candidate: ‘llvm::JITSymbol ()(const string&)’ {aka ‘llvm::JITSymbol ()(const std::__cxx11::basic_string&)’}
/llvm/include/llvm/ExecutionEngine/Orc/Legacy.h:118:35: note:   candidate expects 2 arguments, 2 provided
In file included from /work/src/github.com/iovisor/bpftrace/src/ast/codegen_llvm.cpp:5:
/work/src/github.com/iovisor/bpftrace/src/bpforc.h:99:13: note: candidate: ‘bpftrace::BpfOrc::BpfOrc(llvm::TargetMachine)::<lambda(const string&)>’
99 |             [](const std::string &Name attribute((unused))) -> JITSymbol {
|             ^
/work/src/github.com/iovisor/bpftrace/src/bpforc.h:99:13: note:   no known conversion for argument 1 from ‘llvm::StringRef’ to ‘const string&’ {aka ‘const std::__cxx11::basic_string&’}
In file included from /llvm/include/llvm/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.h:23,
#2
| /src/ast/irbuilderbpf.cpp: In member function 'llvm::CallInst* bpftrace::ast::IRBuilderBPF::createMapLookup(int, llvm::AllocaInst*)':
| /src/ast/irbuilderbpf.cpp:230:65: error: no matching function for call to 'bpftrace::ast::IRBuilderBPF::CreateCall(llvm::Constant*&, , const char [12])'
|   230 |   return CreateCall(lookup_func, { map_ptr, key }, "lookup_elem");
|       |                                                                 ^
| In file included from /src/ast/irbuilderbpf.h:9,
|                  from /src/ast/async_event_types.h:3,
|                  from /src/ast/irbuilderbpf.cpp:5:
| /usr/include/llvm/IR/IRBuilder.h:2324:13: note: candidate: 'llvm::CallInst* llvm::IRBuilderBase::CreateCall(llvm::FunctionType*, llvm::Value*, llvm::ArrayRefllvm::Value*, const llvm::Twine&, llvm::MDNode*)'
|  2324 |   CallInst *CreateCall(FunctionType FTy, Value Callee,
|       |             ^~~~~~~~~~
| /usr/include/llvm/IR/IRBuilder.h:2324:38: note:   no known conversion for argument 1 from 'llvm::Constant' to 'llvm::FunctionType'
|  2324 |   CallInst *CreateCall(FunctionType *FTy, Value *Callee,
|       |                        ~~~~~~~~~~~~^
The CreateCall part is based on the llvm 11 fix from bcc:
https://github.com/iovisor/bcc/commit/45e63f2b316cdce2d8cc925f6f14a8726ade9ff6
Signed-off-by: Ovidiu Panait<EMAIL_ADDRESS>
Checklist

[ ] Language changes are updated in docs/reference_guide.md
[ ] User-visible and non-trivial changes updated in CHANGELOG.md

nice!.
Does this fully fix the llvm build or does it still have test issues?

Hi,
I tested it in a cross-compilation environment (using Yocto), and I am not aware of any test issues using the following cmake configure line:
cmake \
-G 'Ninja' -DCMAKE_MAKE_PROGRAM=ninja
$oecmake_sitefile
/buildarea/raid0/ovidiu/Builds/Yocto/yocto-latest/yoe/poky/build-clang/tmp/work/core2-64-poky-linux/bpftrace/0.11.0-r0/git
-DCMAKE_INSTALL_PREFIX:PATH=/usr
-DCMAKE_INSTALL_BINDIR:PATH=bin
-DCMAKE_INSTALL_SBINDIR:PATH=sbin
-DCMAKE_INSTALL_LIBEXECDIR:PATH=libexec
-DCMAKE_INSTALL_SYSCONFDIR:PATH=/etc
-DCMAKE_INSTALL_SHAREDSTATEDIR:PATH=../com
-DCMAKE_INSTALL_LOCALSTATEDIR:PATH=/var
-DCMAKE_INSTALL_LIBDIR:PATH=lib
-DCMAKE_INSTALL_INCLUDEDIR:PATH=include
-DCMAKE_INSTALL_DATAROOTDIR:PATH=share
-DPYTHON_EXECUTABLE:PATH=/usr/bin/python3
-DPython_EXECUTABLE:PATH=/usr/bin/python3
-DPython3_EXECUTABLE:PATH=/usr/bin/python3
-DLIB_SUFFIX=
-DCMAKE_INSTALL_SO_NO_EXE=0
-DCMAKE_TOOLCHAIN_FILE=/buildarea/raid0/ovidiu/Builds/Yocto/yocto-latest/yoe/poky/build-clang/tmp/work/core2-64-poky-linux/bpftrace/0.11.0-r0/toolchain.cmake
-DCMAKE_NO_SYSTEM_FROM_IMPORTED=1
-DCMAKE_ENABLE_EXPORTS=1
-DCMAKE_BUILD_TYPE=Release
-Wno-dev
I am willing to test more configurations, if required.

I meant, do the tests pass too or is this just compilation.
If the tests pass we can add 11 to the test suite :)


MSC3032: Thoughts on updating presence

Rendered

IMHO the status message should be decoupled from the user's presence state. E.g. if I set an "I'm away from x till y" status message, it should be valid regardless of my presence state and if I a have any active sessions or not.
Why not take it one step further and abstract it to any kind of data, storable at the account level? There is already a  /user/{userId}/account_data/{type}/ resource for private data. What about /user/{userId}/public_account_data/{type}/ for storing data, which can be read by others? "status_msg" could be the type of the stored status message. You can even store a whole calendar information or whatever you think other users may be interested in.


Fix editor language dropdown incomplete in some locales

In the editor language dropdown, when the host locale matches one entry exactly, the rest of the list is missing.
e.g. The dropdown list has only two entires if your LANG is ar:

This PR removes the early break because that loop is used for both determining the default locale and generating the locale list.

For the record we have the same code in a few other core locations, but I expect those should be kept as it's to select the best match:
core/io/resource_loader.cpp
829:                                    break; // Exact match, skip the rest.

core/string/translation.cpp
560:                            break; // Exact match, skip the rest.
638:                            break; // Exact match, skip the rest.

For the record we have the same code in a few other core locations, but I expect those should be kept as it's to select the best match

The rest are only selecting something, so after an exact match is found, it's OK to break. This one is also filling lang_hint with all locales.

Thanks!


Comprehensive solution for $include, and $import

Feature Request
Desired behaviour
Follow-up for #1150
As of 1.3.4, we'll have partial support for $mixin, $import, and $include. This works for launching, refreshing to pick up secondary files, and for harvesting descriptions.
A more comprehensive implementation will need to be done in 1.4.0 to make sure it works in other situations like authorship.
┆Issue is synchronized with this Jira Story
┆Fix Versions: Dockstore 2.X
┆Issue Number: DOCK-312
┆Sprint: Backlog
┆Issue Type: Story

See also #953

Also consider https://github.com/ga4gh/dockstore/blob/1.4.0/dockstore-webservice/src/main/java/io/dockstore/webservice/languages/CWLHandler.java#L271 DAG handling will need to consider this

No more mixin in CWL 1.1 apparently
https://gitter.im/common-workflow-language/common-workflow-language?at=5d812a6362bfc95112069e1a

@svonworl FYI


something wrong with running the blackbird

Is this how blackbird works?
JUST creating a log file?
I run blackbird in an ubuntu VPS on vultr.com
Blackbird Bitcoin Arbitrage
DISCLAIMER: USE THE SOFTWARE AT YOUR OWN RISK
Log file generated: output/blackbird_log_20171002_104107.log
Blackbird is running... (pid 29451)

Yes, it doesn't print anything to stdout besides the initial message. Most of the events and status of the bot is recorded in the log instead. You can track it to a terminal output using something like the tail command though.


Unicode characters are double encoded in store description

Description:
Unicode characters are double encoded in store description

Duplicated https://github.com/wso2/product-apim/issues/3778


Docs overhaul + document all available attributes

Have had many people ask what is and isn't supported.

My incoherent thoughts while riding my bike about how docs should be done (among other random things):
Typing untyped types

PeerId transparent
Using as
Override to TS string

Build crate on Specta - How rspc works with Specta basically
Terminology inline vs definition vs reference
Build binary size and compile time impact
Specta SID should be affected by generics???
Type aliases work?
Examples folder in Specta

HTTP backend
Export feature

I do wonder if using any Serde overrides for serialisation or deserialisation should force the type to any unless explicitly override by the user with the type attribute.
I explain type alias handling and its rationale.
Lints to remove panics
Show off ORM support
Why does DataTypeFrom return a tuple not enum. Tuple should be [...] while enum is ... | ... but it's being exported the other way round?
- Document how (T) == T so it’s actually a tuple of one variant where the variant is an enum


BUG Security/logout doesn't log out properly if using basic auth

https://stackoverflow.com/questions/449788/http-authentication-logout-via-php
If a user logs in with basic auth, going to Security/logout won't log them out, as the Authorization header re-authenticates them.

Assuming this issue already existed in 3.x, I'm downgrading the criticality

@tractorcow Chris said you might've addressed this already?

No, I've only fixed basic-auth not logging users in at all.
Once that was fixed, the above issue surfaced.

Right. I think this can wait until 4.1.0


BoM and lenses

Hello, :) It would be great if the project had a BoM (Bill of Materials), with links (to the recommended items), and specifications. This would help, and make it easier for people to buy the required items and do the project. Regarding the lenses, what other options do you recommend (high-quality ones) besides the TREEYE 15.3mm lens M12? What other lens do you recommend for the HQ-camera? Cheers!

Hi. Thanks for the suggestion. I have a detailed BoM with the weblinks but it was in the long instruction manual, page #71 https://github.com/IBM/MicroscoPy/blob/master/Instructions.pdf
I just added it to the main page  as well. https://github.com/IBM/MicroscoPy/blob/master/Bill of Materials (BOM).pdf
I did not test any other lens with this microscope. Thorlabs  for example have good microscope lenses but they could be too heavy for the tilting stage. Or you could try something like this, the HQ camera has a C mount adapter, so you should be able to connect directly.

@thalesfsp have you tried any better lens? I have exactly the same as in the description of this project and I would like to achieve even higher magnification. I wonder how would this one work - https://www.aliexpress.com/item/32818045696.html - but I'm afraid that 2 megapixel resolution might be a problem.

@thalesfsp have you tried any better lens? I have exactly the same as in the description of this project and I would like to achieve even higher magnification. I wonder how would this one work - https://www.aliexpress.com/item/32818045696.html - but I'm afraid that 2 megapixel resolution might be a problem.

Hi, thank you for your reply :)) the Thorlabs and Edmund Optics lenses looks so good but a bit over budget 😄 I will probably try some lens as I posted before. If I get any results I will share it here.

Hi, thank you for your reply :)) the Thorlabs and Edmund Optics lenses looks so good but a bit over budget 😄 I will probably try some lens as I posted before. If I get any results I will share it here.

@hucik14 did you try any of the lenses above? Could you update us with the results? :)

I haven't tried anything different so far, but I still plan to... hopefully I will have time during Christmas holidays. If I have any (even bad) results, I will share it here.

Hi, can you provide me the references for your optical system? Or an explanation for why did we take the Raspberry Pi camera's lens out?

You remove the original lens and add put an external one in bigger distance. Read more on extension tubes in macro photography, for example here:
https://shuttermuse.com/ultimate-guide-to-extension-tubes/

I haven't tried anything different so far, but I still plan to... hopefully I will have time during Christmas holidays. If I have any (even bad) results, I will share it here.

Sorry I forgot to comment on this - I tried a better lenses, the quality of the images improved a bit, but I was not able to get higher zoom.

Thanks for your help :)

Hi. I am the designer of the microscope, but I left IBM a few years ago, so the repository is not maintained anymore.
Regarding the question about the lens, I agree with the previous user's reply.
I will do my best to answer other questions but it's been a while, I may not remember all the details :-)

Thank you for your return. I think the instructions are very enough to actualize the project, with all my respect. I am just having a hard time about recreating an alternative version of the optical part, specifically about enough magnification for medical histology.

Thanks. Achieving higher magnification with this single lens configuration can be difficult, and anyway, the resolution will be limited by diffraction. I founded my own company on microscopy, please feel free to check and contact me to learn more: https://www.microqubic.com/ Best regards.


Update dependencies with semver-compat version

Just a standard update

r? @matklad
(rust_highfive has picked a reviewer for you, use r? to override)

@bors: r+

:pushpin: Commit f490635 has been approved by alexcrichton

:hourglass: Testing commit f490635e0fbd652d35dc706b30a6c548a8083d0e with merge 9e664bd25ecbd296523ac020bf5806fde8aea2ae...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 9e664bd25ecbd296523ac020bf5806fde8aea2ae to master...


Add update command for local .erg

Once .erg is created in local, the contents are not updated
.erg must be removed and re-installed
If this can be automated with commands, it is easier to manage

I think it will be updated

The only way to update erg installed by ergup is to delete the .erg directory and reinstall it.
If you installed erg using cargo, the library will be updated along with the installation of the new version. Also, they are updated every time with debug builds.

I think it would be better to put the overwrite process in ergup.

There is also a way to add a subcommand to update erg itself, but this is premature at this time because it involves the package installation feature.


Update log command in the user guide

Follow-up for #610, I've extended the user guide with the new log command's documentation.

Yes, the "help" has been copied from the output verbatim.


Update grpc-netty to 1.51.1

Updates io.grpc:grpc-netty from 1.51.0 to 1.51.1.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.grpc", artifactId = "grpc-netty" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "io.grpc", artifactId = "grpc-netty" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Codecov Report

Merging #2323 (1b58ad6) into main (e286f92) will decrease coverage by 0.01%.
The diff coverage is n/a.

:exclamation: Current head 1b58ad6 differs from pull request most recent head 68e6ad1. Consider uploading reports for the commit 68e6ad1 to get more accurate results

@@            Coverage Diff             @@
##             main    #2323      +/-   ##
==========================================
- Coverage   78.16%   78.14%   -0.02%
==========================================
  Files         439      439
  Lines       14997    14997
  Branches     2062     2062
==========================================
- Hits        11722    11720       -2
- Misses       3275     3277       +2

Impacted Files
Coverage Δ

...a/at/forsyte/apalache/tla/lir/TlaLevelFinder.scala
93.75% <0.00%> (-2.09%)
:arrow_down:

...he/io/annotations/parser/CommentPreprocessor.scala
96.70% <0.00%> (-1.10%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Can Python2 be supported?

I'm on CentOS 8.1.x ThunderX and see:

[ 14%] Built target scopmath
[ 15%] Generating kinderiv.h by inspecting MOD files
/bin/sh: python: command not found
make[2]: *** [coreneuron/CMakeFiles/kin_deriv_header.dir/build.make:88: coreneuron/_kinderiv.h] Error 127
make[1]: *** [CMakeFiles/Makefile2:1046: coreneuron/CMakeFiles/kin_deriv_header.dir/all] Error 2
make: *** [Makefile:183: all] Error 2

yum info python2 tells me it is there.

I "thought" we have fixed this. We will fix this.

Sysadmin created a sym link to python2 and now it builds ok.


Can't use top in an exec pipe - "TERM not set"

top works on all the alpine containers I have. execing or attaching to containers just running sh.

I think you need to do it on a container that wasn't started with -ti, such as the scope container.

The question is how to inject TERM on docker exec... One way would be to run /usr/bin/env TERM=xterm /bin/sh -l instead of /bin/sh (as we are currently doing).

top works fine on the scope container for me...

But not on the elasticsearch one. Seems like it could be an issue specifically with ubuntu?

Caused by this bug in docker: https://github.com/docker/docker/issues/9299


Temporarily disable garbage collection

Description
Disabling GC for now so we can do a patch release to stop LSP from crashing.
This should be re-enabled asap as soon as #5698 is resolved.
Checklist

[ ] I have linked to any relevant issues.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book).
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
[ ] I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
[ ] I have requested a review from the relevant team or maintainers.

Superseded by fix in https://github.com/FuelLabs/sway/pull/5704


[enhancement] [Request] Split Brackets

#55
Interested in doing split brackets with the same number of teams on each side.

I'm interested in this also do you have any update on this or suggestions on how to make it work?

+1 for this feature! march madness is coming up.

I just don't know how to get the css setup right the functionality for 64 teams works but it should split and start with 32 teams on each side.

might I suggest instead of setting up the bracket like
.bracket({ init: [leftBracket, 'lr'], init: [rightBracket, 'rl'] })
that we do something like
.bracket({ init: [fullBracket, 'split'] })

The API should be something that clearly shows the intention. I would perhaps go with something like this:
$("#selector").bracket({
  init: bracketData,
  layout: "split"
});

There is also already the dir parameter that is used to adjust the direction of the bracket. Another option would be to expand it with split or something more descriptive (regarding direction). It currently supports lr and rl.

After looking at the code it seems like there will need to be a bunch of functional changes and not just a new set of css stylings.
Correct me if i'm wrong?

Yea...
I tried my hand at starting the refactor but quickly stopped.  I stopped because I was only thinking through the one use case for March Madness in particular but it seemed there should be more initializing data passed in like "region list" and the like to help determine the bracket output and have the appropriate regions grouped, etc.

Any update on this or when it might be looked at?

Any suggestions on modifications to get split brackets to work? I'm not good with styling.

I think it'll require considerable code modifications too.
As a hack, you could maybe combine two bracket instances and fetch the final teams from each side for the grand final.


Fetch requests to web app accessed on localhost gets stuck in pending state

Version
Windows 11 Pro 21H2 (10.0.22000.469)
WSL Version

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>
Distro Version
Ubuntu 20.04
Other Software
Node web app using any of the following:

Express JS
Next.js
Remix

Repro Steps
I've experienced the issue describe below using a few Node frameworks but the quickest way to reproduce is to do one of the following
Next.js Blog Example

Open a Terminal into WSL2 within which Node is installed.
Get the IP address for WSL2 ip addr | grep eth0 for use later
Create a directory to use for our app and cd into it.
Create the Next.js app using the blog template npx create-next-app -e blog .
Run npm run dev to start the app on port 3000 (default port)
In Windows open any browser and open the Dev Tools on the Networking tab
Access the app on http://localhost:3000
Wait over 5 seconds and click on "Posts" link
Note the fetch request in the Network tab is stuck in a pending state.  The Timing section of the fetch request in the Network tab shows it stuck in the Initial Connection phase.
Now access the site against the IP address on port 3000 and you'll see the fetch requests always work

Express-based Hello World

Open a Terminal into WSL2 within which Node is installed
Get the IP address for WSL2 ip addr | grep eth0 for use later
Create a directory to use for our app and cd into it.
Initialise a new Node app npm init -y.
Install Express npm install --save express
Create app.js with the following Hello World code

const express = require('express')
const app = express()
const port = 3000

app.get('/', (req, res) => {
  res.send('Hello World!')
})

const server = app.listen(port, () => {
  console.log(`Example app listening on port ${port}`)
})

Run the app node app.js
In Windows open any browser and open the Dev Tools on the Networking tab
Access the app on http://localhost:3000
Refresh the app a few times and you'll notice the fetch request eventually gets stuck in a Pending state.  The Timing section of the fetch request in the Network tab shows it stuck in the Initial Connection phase.
Now access the site against the IP address on port 3000 and you'll see the fetch requests always work
Close the app (Ctrl + C) and edit the app.js and add the following as the last line in the app

server.keepAliveTimeout = 0;

Rerun the app node app.js and you'll find the app no longer gets stuck in a pending state against http://localhost:3000.

Expected Behavior
Browsing a node-based web app running in WSL2 should not have network issues when accessed on localhost.
Actual Behavior
If I access a Node application running inside of WSL2 in the browser on localhost, the Network tab will show that some fetch requests get stuck in a pending state. The Network details shows that it gets stuck in the Initial Connection stage. This is corroborated by there being no hits in the app logs if logging is implemented in the app.
This only happens if I try to access the app from Windows using http://localhost against the relevant port (usually 3000 or 8000 depending on the app I'm running). If I access the site using the IP address for WSL2 then the GET requests are never stuck in the pending state.
I have had the issue since the last update - everything was running perfectly against localhost prior to the update.
The common thread is Node's HTTP library which has a default keep-alive timeout of 5 seconds. I have experienced the issue using Express, Next.js, and Remix - Gatsby was unaffected.
I confirmed this by creating the Hello World Express app, verified the issue still occurred under this simplest of apps, then explicitly set the http server's keepAliveTimeout setting to 0. The issue went away completely.
To reiterate, the issue only showed up since the last update and was working as expected prior to that allowing localhost to be used without issue.
Diagnostic Logs
No response

I've started seeing the same issue since yesterday as well, this completely broke my current web dev workflow.

Same here. It's really breaking productivity there days.

network packet capture: https://github.com/microsoft/WSL/issues/7979

Same issue, Windows 11 Insider Preview Dev from week ago.

Same issue, it works ok only under VPN

Uninstalling the store version of WSL fixed it for me.

try accessing via eth0 wsl ip

Uninstalling "Windows Subsystem for Linux Preview" and running wsl --update in PS did the trick for me.

I can also confirm this and that uninstalling the store version fixed the problem. Probably the most interesting thing is that this is only affecting Chromium based browsers (Chrome, Edge). Firefox is working fine.

Uninstalling "Windows Subsystem for Linux Preview" and running wsl --update in PS did the trick for me.

If I uninstall the store version, will I lose all the distro with my data as well?

@Dozorengel - My data was fine after uninstalling the store version, both on my desktop and laptop. Just to be safe though, you might want to do an export of your distro.

Reinstalled to Windows 11 release version and no longer seeing the issue.

Release 0.51.3 is in testing and has a fix for this issue.

Fixed in https://github.com/microsoft/WSL/releases/tag/0.51.3. Should be available via the Microsoft Store in a few hours.

@benhillis I'm on 0.56.2 (<IP_ADDRESS>) and it's still dropping. Although it seems lees frequent.

This is still happening to me :(

Same


Add scrollDownBy etc. API's to detox-native

Description

This pull request is associated with issue #2678

In this pull request, I have Added Detox' scrolling API's to detox-native (Android).

In addition, I've updated the publishing.gradle script such that a forceLocal could be accepted in order to force publishing the .aar even when the coreNative build-flavour is specified:
(~copied from #2672)

detox/android/gradlew publish -Dversion=1.2.3 => publish the full, legacy artifact onto /Detox-android, as always
detox/android/gradlew publish -Dversion=1.2.3 -DbuildFlavour=coreNative => Publish the lean, native-only artifact onto maven-central (account details are stored in a local gradle.properties file.

(Added here)

detox/android/gradlew publish -Dversion=1.2.3 -DbuildFlavour=coreNative -DforceLocal=true => Publish the native-only artifact onto /Detox-android instead of maven-central

For features/enhancements:

[ ] I have added/updated the relevant references in the documentation files.

For API changes:

[ ] I have made the necessary changes in the types index file.

Failed due to technical issues with Genymotion. All tests passed.


Fix "method_lines" issue in src/index.js

Function render has 54 lines of code (exceeds 25 allowed). Consider refactoring.
https://codeclimate.com/github/gilbarbara/react-tooltips/src/index.js#issue_5a7cfe17db15950001000024

WOA, too fast!


Perfect shuffle without buffer of size len(dataset)

Please make sure that this is a feature request. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:feature_template
System information

TensorFlow version (you are using): 2.7.0
Are you willing to contribute it (Yes/No): Yes

Describe the feature and the current behavior/state.
The new feature will allow perfect shuffle without using a buffer of size len(dataset). When using tf.data.Dataset object for data pipeline, to faster the data process during model training, we use tf.data.Dataset.cache method. But, with large dataset or/and limited RAM capacity, we cannot use perfect shuffle method because it need the same amount of RAM capacity and can cause an Out of Memory error.
Exemple of actual behaviour
ds = tf.data.Dataset.range(100000)  # large dataset
ds = ds.map(SomeTransformation)
ds = ds.cache() # RAM is 70% use
ds = ds.map(SomeTransformationThatUseRandomBehavior)
ds = ds.shuffle(buffer_size=len(ds))  # (Perfect) shuffle cannot be done because of an OOM Error

...

model.fit(ds)

Exemple of the new feature
ds = tf.data.Dataset.range(100000)  # large dataset
ds = ds.map(SomeTransformation)
ds = ds.cache() # RAM is 70% use
ds = ds.map(SomeTransformationThatUseRandomBehavior)
ds = ds.shuffle(buffer_size=None)  # (Perfect) shuffle will not cause an OOM Error because
                                   # it will no longer need a buffer to work

...

model.fit(ds)

Current solution but not perfect
ds = tf.data.Dataset.range(100000)  # large dataset
ds = ds.map(SomeTransformation)
ds = ds.cache("path/to/file") # RAM is no longer use
ds = ds.map(SomeTransformationThatUseRandomBehavior)
ds = ds.shuffle(buffer_size=len(ds))  # (Perfect) shuffle work but take more time
                                      # to read from a cache file than read from a cache  in RAM

...

model.fit(ds)

Will this change the current api? How?
tf.data.Dataset.shuffle now allow buffer_size to be set to None
Who will benefit with this feature?
Anyone who are using large datasets and those who are limited with RAM capacity (can only fit once the data in RAM)
Other Info
An another shuffle option, if perfect shuffle cannot be done due to some technical constraint, can be to randomly select an element of the dataset. that's mean 2 elements can be draw.

@DUPASYoann,
Can you please elaborate you feature request by adding more details and also can you provide an example if possible? Thanks!

@DUPASYoann,
Can you please elaborate you feature request by adding more details and also can you provide an example if possible? Thanks!

Edit done !

It is normally suggested not to use cache for large dataset since it occupies your RAM usage, you can still proceed without using cache and then use shuffle which can be performed since your RAM usage will be less.
If you are concerned about the speed, you can do it in other ways, either you can shuffle the dataset at source(OS level) and then create tf.data and cache or to shuffle in other ways you can split the source data into multiple files and read them in the random order during training using tf.data.Dataset.list_files

It is normally suggested not to use cache for large dataset since it occupies your RAM usage, you can still proceed without using cache and then use shuffle which can be performed since your RAM usage will be less.

Yeah, I agree, and that what I do with tf.data.Dataset.cache(filename=filepath). In this way, i can use perfect shuffle with reshuffle_each_iteration=True since cache is no longer on RAM. But perfect shuffle can be only ensure if you can store all your dataset in RAM since you have to set the shuffle buffer to len(dataset).

you can shuffle the dataset at source(OS level) and then create tf.data and cache

For me it's not an ideal solution, because when you use cache operation on your dataset, the order will be "frozen" and so you will only benefit the shuffle once. (When i say the order will be "frozen", I mean that in every epoch (If I consider one epoch equal one entire loop over my dataset) I will have the same order).

split the source data into multiple files and read them in the random order during training using tf.data.Dataset.list_files

This is the best solution right now. But consider this case :
Actual situation
ds = tf.data.Dataset.list_files("path/to/files")  # few elements but each element are large image
ds = ds.map(SomeTransformation)
ds = ds.cache() # cache the dataset because the transformation before take long time
                # and we don't have to do it multiple time since the result are the same
ds = ds.map(SomeTransformationThatUseRandomBehaviorLikeRandomCropOnImage)
ds = ds.shuffle(buffer_size=len(ds))  # Perfect shuffle can only be ensure if we have enough RAM to store all elements

...

model.fit(ds) # It's important that we have random order every epoch

Solution when RAM is not enough
ds = tf.data.Dataset.list_files("path/to/files")  # few elements but elements are large image
ds = ds.map(SomeTransformation)

for data in ds:
    pickle.dump(data, "path/for/element{i}") # cache data with our own method

new_ds = tf.data.Dataset.list_files("path/off/all/elements/*", shuffle=True) # we don't need to use tf.data.Dataset.shuffle anymore
new_ds = new_ds.map(lambda x: tf.numpy_function(read_data_with_pickle_load, [x], [ds.elements_spec.dtype])
new_ds = new_ds.map(SomeTransformationThatUseRandomBehaviorLikeRandomCropOnImage)

...

model.fit(ds) # We still have a random order every epoch

On further consideration, the new feature can be a shuffle argument on tf.data.Dataset.cache like the argument on tf.data.Dataset.list_files. When True, It would allow random shuffle of the cached dataset (file or RAM).
With the new feature
ds = tf.data.Dataset.list_files("path/to/files")  # few elements but elements are large image
ds = ds.map(SomeTransformation)
ds = ds.cache(shuffle=True) # we can now easily have perfect shuffle, and if the dataset is cached in RAM,
                            # it's now only store once
ds = ds.map(SomeTransformationThatUseRandomBehaviorLikeRandomCropOnImage)

...

model.fit(ds) # we would still have our random order every epoch
̀```

Hi,
Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.


myethervallet.com

Blocking all sites where rn replaces m,  vv replaces w and v replaces w might be prudent ;)

It could give a lot of false positives, plus we have Levenshtien edit distance on domain myetherwallet.com that @sogoiii implemented in v1.3.7 that will catch them.
I forgot to mention that MetaMask (who are the only other people using the blacklist) now implement the Levenshtien distance https://github.com/MetaMask/metamask-extension/pull/1837 so it shouldn't be a problem not listing all rn = m, vv = w, v = w variants of a domain name as they'll be caught.
You can confirm with the test script here: https://repl.it/JZQ5/6 (a response of true will mean it's blacklisted)

Pretty much covered with the Levenshtein logic that @sogoiii did.


Battery storage cost constant version 2

This new code adds a battery storage cost constant. Note that this is version 2 and there is another branch called "storage-cost-constants." An error was made in creating that feature branch, so a second version was created.

@toddleif  in general this is looking good! In addition to my in-line comments above, just a few high-level notes:

Can you add tests to test/test_with_xpress.jl and runtests.jl that check that things are working as expected with your new addition? This could check, for example, some expected financial outputs, that you have manually calculated in Excel.
I think we need to reconfigure the constraint to not be an indicator constraint, if possible. I suspect this is why so many of the hightests are failing. We'll want all tests to be passing before we merge.

@toddleif could you please update the CHANGELOG.md file with a description of these changes? You can see other entries in there for examples.

@toddleif I think this is looking good! I left a few comments throughout, and have noticed just two more places where changes may need to be made:

It looks like you'll need to make a few changes to proforma.jl. See e.g. line 71 "# calculate Storage o+m costs, incentives, and depreciation" (there may be other places in there that require updates too)
outage_constraints.jl line 80 where I think the cost constant should be added to the "bigM" value being subtracted from the capital costs

@constraint(m,
            m[:dvMGStorageUpgradeCost] >= p.s.financial.microgrid_upgrade_cost_fraction * m[:TotalStorageCapCosts] - (
                p.s.financial.microgrid_upgrade_cost_fraction * p.third_party_factor * (
                    sum( p.s.storage.attr[b].net_present_cost_per_kw * p.s.storage.attr[b].max_kw for b in p.s.storage.types.elec) +
                    sum( p.s.storage.attr[b].net_present_cost_per_kwh * p.s.storage.attr[b].max_kwh for b in p.s.storage.types.all )
                ) * (1-m[:binMGStorageUsed])  # Big-M is capital cost of battery with max size kw and kwh
            )
        )

Also noting that the tests did fail previously (looks like they may have timed out) so I re-ran them on Tucker's last commit. The commit that I made was just a change to the Changelog, so only the documentation tests passed, which is misleading :)

@toddleif I think this is looking good! I left a few comments throughout, and have noticed just two more places where changes may need to be made:

It looks like you'll need to make a few changes to proforma.jl. See e.g. line 71 "# calculate Storage o+m costs, incentives, and depreciation" (there may be other places in there that require updates too)
outage_constraints.jl line 80 where I think the cost constant should be added to the "bigM" value being subtracted from the capital costs

@constraint(m,
            m[:dvMGStorageUpgradeCost] >= p.s.financial.microgrid_upgrade_cost_fraction * m[:TotalStorageCapCosts] - (
                p.s.financial.microgrid_upgrade_cost_fraction * p.third_party_factor * (
                    sum( p.s.storage.attr[b].net_present_cost_per_kw * p.s.storage.attr[b].max_kw for b in p.s.storage.types.elec) +
                    sum( p.s.storage.attr[b].net_present_cost_per_kwh * p.s.storage.attr[b].max_kwh for b in p.s.storage.types.all )
                ) * (1-m[:binMGStorageUsed])  # Big-M is capital cost of battery with max size kw and kwh
            )
        )

@adfarth    I addressed these edits too, thanks for catching these as well!


Typing for record became too loose after addition of Partial

This issue is related to: https://github.com/colinhacks/zod/issues/751
After updating zod version from v3.12.0 to v3.13.3 we started to receive the following TS error: error TS2322: Type 'Partial<Record<string, string>>' is not assignable to type 'Record<string, string>'.   'string' index signatures are incompatible.     Type 'string | undefined' is not assignable to type 'string'.       Type 'undefined' is not assignable to type 'string'.
We are using zod record with string keys and values. I think that returning Partial for string records is a bug, because we are sure, that all keys that record has are checked by zod and contain non-undefined value, but TS says that they can contain undefined that forces us to do extra checks in the later code to convince TS that all values are strings.
I've created a repo with simple reproduction to illustrate such use case better:
https://github.com/hsarokina-ita/zod-partial-record
safeParse returned success: false for object with undefined values, this means that zod checked for it to be defined. But at the same time I can assign record with undefined value to typing returned by parser.

I have a similar issue with a string key, but my value is not a string but a z.union of some objects. I don't want my record value to be optional, this seems to be contradictionay to the "everything is required until .optional() is called".

This was changes to more accurately reflect the type Zod actually validates. Zod can't do exhaustiveness checking - for instance it doesn't/can't verify that all elements of the enum show up as keys:
z.record(z.enum(['a', 'b', 'c']), z.string());
// => Record<'a' | 'b' | 'c', string>

This is inaccurate - Zod merely validates each key against the key schema, but can't guarantee that all three keys exist in the object. So a more accurate type is Partial<Record<'a' | 'b' | 'c', string>>.
But your right that wrapping in Partial was too permissive. Just updated the typings:
z.record(z.string, z.string);
// Record<string,string>;

z.record(z.enum(['a', 'b', 'c']), z.string());
// => Partial<Record<'a' | 'b' | 'c', string>>

Merged in 3.13.3.

This still seems to be happening when using custom string literal types.
export const UUIDSchema = z.string().uuid() as z.ZodType<UUID>;

When defining a record with UUIDSchema as key, it will be Partial.

@alexanderhorner Looking at the source code, you should put UUID in a Brand to prevent Partial.


CookieAuthenticationHandler IsPersistent with UTC dates

Hi Guys,
Just stumbled across a small bug I think.
Line 243 in CookieAuthenticationHandler.
if (signInContext.Properties.IsPersistent)
{
      var expiresUtc = signInContext.Properties.ExpiresUtc ?? issuedUtc.Add(Options.ExpireTimeSpan);
      signInContext.CookieOptions.Expires = expiresUtc.ToUniversalTime().DateTime;
}

The date signInContext.CookieOptions.Expires has the correct value, but it's kind is Unspecified, so when added to the cookie it gets converted to UTC again.
I've got a local copy of this class and just changed that line to
signInContext.CookieOptions.Expires = DateTime.SpecifyKind(expiresUtc.ToUniversalTime().DateTime, DateTimeKind.Utc);
and it's all good.
Thanks.

Can we look into why we aren't using DateTimeOffset? That might help resolve some of this.


Register derived from3

Merge all merges.
cc @therealprof
How about such variant?

r? @therealprof
(rust_highfive has picked a reviewer for you, use r? to override)

bors try

Let's give it a spin, I'll still wait for @jamesmunns to say something because IIRC there's also a story behind the story...


Scalability Issue

Hi team,
I have tried your snefy model with high-dimension multivariate gaussian data (d=5/10), with mean = 0 and PSD covariance, using SquaredNN("Rd", "gauss", "snake", "ident") with three layers of feature_net. However, the resulting NLL seems a bit too high (~15).
I was wondering if SNEFY can be applied to high dimensional data.

Hi again!
I would think it should be ok for d=5 or d=5. Which data are you using? Have you tried any other methods (e.g. mixture model or normalising flow), and if so, what kind of NLL are they getting?

If you can share code here, I'm happy to take a look.

Hi Russell,
Thanks for the reply!
For generating data, the following code is used, which generates 5000 multivariate gaussian (mean=0, PSD covariance) data with d=5:
seed = 42
np.random.seed(seed)
torch.manual_seed(seed)

# Generate complete dataset
num_samples = 5000

A = np.random.rand(5, 5)

def generate_well_conditioned_cov_matrix(dim, min_eigenvalue=1, max_eigenvalue=10):
    # Generate random eigenvalues within the specified range
    eigenvalues = np.random.uniform(min_eigenvalue, max_eigenvalue, dim)
    # Generate a random orthogonal matrix
    Q, _ = np.linalg.qr(np.random.randn(dim, dim))
    # Construct the covariance matrix
    cov_matrix = Q @ np.diag(eigenvalues) @ Q.T
    return cov_matrix

dim = 5  # dimension of the covariance matrix
cov_matrix = generate_well_conditioned_cov_matrix(dim)
print("Well-Conditioned Covariance Matrix:")
print(cov_matrix)

# cov_matrix = np.dot(A, A.T)
mean = np.zeros(5)

data = np.random.multivariate_normal(mean, cov_matrix, num_samples)

And for SNEFY model, the following code is used, where we added a 3-layer neural network and slightly modified the original Density class to accept the feature net parameter as in Conditional Density class:
n = 8
d = 5
m = n

squared_nn = SquaredNN(
    "Rd", "gauss", "snake", "ident", d=d, n=n, m=n, num_mix_components=1
).to(device)
feat_net = Mlp([5, 128, 64, 8])
snf = Density(squared_nn, feat_net).to(device)

We haven't tried other models but will be working on it, and it would be great if you could help check if any of the setting above has caused any problem in calculating the NLL. We would greatly appreciate any comment :)

Hi @ericquan99
I copied your code and ran it using the original SNEFY code. I didn't use your slightly modified Density class, which accepts a feature net parameter. (I am actually not even sure what this means, or what modifications have been made to make use of a feature extractor. This is unconditional density estimation, so not sure what a feature extractor would be required for).
Note that in your example, the eigenvalues of the covariance matrix range from between 1 and 10. This means that the variance of the density you are modelling is quite large. This is certainly easy to be modelled by SNEFY by changing the hyperparameters of SNEFY, however it is easier to accommodate this change of scale in the data by preprocessing the data, which I have done on line 39.
The attached code easily obtains -1.9 as a NLL, and could do much better I'm sure with tweaking. For example, n=m=8 is almost definitely a sub-optimal choice, and the learning rate can probably be bumped up a fair bit.
gaussian.zip
I will close this issue for now, but as always, I'm always very happy to help and answer any questions you have! Feel free to keep posting them here or in a separate issue. Thanks again for checking out our work!


Use the manager client in the parser

What this PR does / why we need it:
This is a PoC to strip the store package out of the parser. Instead of using the store, the parser will List() resources directly from the manager client.
This WIP only does so for Ingress v1 resources. It does not yet attempt to filter these resources by class. It disables parser unit tests because Build() (which every parser unit invokes) now needs a manager client, and I didn't want to deal with converting a ton of test cases to https://pkg.go.dev/sigs.k8s.io/controller-runtime/pkg/client/fake for the PoC.
Special notes for your reviewer:
The relationship between UpdateKongAdminSimple, the KongUpdater function type, and things that use them remain confusing and somewhat annoying to refactor around. IDK if we have actual intent to implement alternative updaters (AFAIK, the original rationale for how this is structured), but we haven't so far. We may want to consider simplifying it.

Remaining failures should be resolved by https://github.com/Kong/kubernetes-ingress-controller/pull/2253
DB-less passed, and this change should be the same across both deployment types, so the PoC should be good to go.

It seems we've left this one for a while, given our current state and that we have a follow up issue are we OK to close this?

Copied to my fork in case we ever want to review the old POC


FIPS mode

consider adding enable/disable FIPS mode as a user-configurable option

To address discovery of a bad ciphersuite, consider adding administrative control to configure ciphersuites and/or enable/disable browser vendor push of ciphersuite updates.
Note:
FCS_TLSC_EXT.1 in the App PP addresses mandatory and optional (selectable) ciphersuites for TLS.  Also in the App PP, ALC_TSU_EXT.1.1D addresses timely security updates to fix security vulnerabilities.


⚠ Samsung has degraded performance

In 806c8b5, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2367 ms

Resolved: Samsung performance has improved in 29306cd.


In eval_result TypeError: boolean value of NA is ambiguous and in data.append_test_result_to_sheets InvalidJsonError

Expected Behavior
currently these values are processed [None, "", "NaN", "nan"] but not NA
Current Behavior

@krishnapadm this is a duplicate of #230
The fix is being applied in #250


Impossible to force the alias list updating/sync scrolling down

As in the title.
STR:

open the app and go to the "Aliases" section
scroll down the list from the drop

There is no forced sync.
Workaround: switch to the active or inactive tab, go back to the All on and you'll able to trigger the manual sync, scrolling down the list.
Note: appeared only after iOS update to v16.
iOS 16.0 (20A362)
Client: 2.2.0 (build 22000).

Hi, thanks for reporting. I'll investigate and try to fix this.

Updated STR:

open the app
Go back too home screen
go to the "Aliases" section if you've left the app from a different section
4.scroll down the list from the top

Hello, sorry for the delay. It should be fix with the new version 2.3.0.

Hello, sorry for the delay. It should be fixed with the new version 2.3.0.

It is, thanks!