Add pool id to list of available filename tags

Is your feature request related to a problem? Please describe
On some websites, such as Gelbooru and E621, users regularly add related images (such as the pages of a comic) to the same pool. Currently, there does not seem to be any way for a user of Grabber to group their downloaded files by these pools.
Describe the solution you'd like
It would be useful to have the following two tokens be made available for the filename string.
%pool%, which would be replaced with the pool's name if available, or blank if not part of a pool.
%pool_id%, which would be replaced with the pool's id if available, or blank if not part of a pool.
Additional context
Example pools (SFW images on NSFW websites):
https://e621.net/posts/2090773 - A post in multiple pools
https://e621.net/pools/20323 - One of the pools the above post is present in
https://gelbooru.com/index.php?page=post&s=view&id=552217 - A post in a single pool
https://gelbooru.com/index.php?page=pool&s=show&id=45162 - The pool the above post is present in
I am not sure whether the responses of different websites handle their pools differently.

I did some quick test and at least pool id works, seems like it's not documented but %pool% spits out the pool id, but yeah name would be hugely useful as well.

Any update on this. I just tried setting it in the filename and it doesn't seem to work.

I can confirm that %pool% works for me, but I would love to see something like %pool.name%. That would be really great.


Build Expat and GLM statically as dependencies from 3rdparty submodules

#253 will need GLM and we'll need an XML parser to implement a mitsuba loader for #303 .
We can achieve some tranquility as the mission to statically link CEGUI and its dependencies will be 40% accomplished (only Freetype2, GLEW and PCRE will hold us up).
Expat
CEGUI uses: https://github.com/libexpat/libexpat/releases/tag/R_2_0_1
But see if we can bump to https://github.com/libexpat/libexpat/releases/tag/R_2_1_1 or even https://github.com/libexpat/libexpat/releases/tag/R_2_2_6 without upsetting CEGUI
We should grab just the ./expat subdirectory from the repo (if possible) as the rest is travisCI crap.
It appears to have a working CMakeLists.txt
Obviously don't build expat if irr::ext::cegui nor irr::ext::mistubaloader is not being built (default bahviour with dependencies I guess?).
GLM
Use https://github.com/g-truc/glm/releases/tag/<IP_ADDRESS>
Unless CEGUI or GLI moan.
I guess glm will build by default to support the built-in loading of DDS and KTX.
@manhnt9 , @Crisspl , @Florastamine any takers?

expat 2.2.6 looks fine

committing a work-around for CEGUI's build system of death


Update pytype check_diff.sh script paths.

These paths no longer exist. Looks like pytype hasn't been running on integrations/ for a while?
Also pruned the set of files that the script runs on so 'all' works when you have a build directory or venv.

Wait, your example output has an error xargs: argument list too long. Windows?

Nope, Linux :(
(standard mode is to just check diffs for changed files, that's when I run with "all")

Wait, your example output has an error xargs: argument list too long. Windows?

Nope, Linux :(
(standard mode is to just check diffs for changed files, that's when I run with "all")

Oh, RIP. That's maybe why that was split into separate calls? I'm also not sure the comment about having xargs not make multiple calls makes as much sense in this context. That originates from a script invoking Bazel, which we really didn't want to invoke multiple times. Here if for some reason you've got more files than pytype can handle, invoking it multiple times should be fine. I double-checked the xargs man page and it will exit with 123 if any invocation fails, so multiple invocations should be fine. So, in short, remove --exit and it should work

Ack. I can fiddle with the script to see if I can get it working again on "all". That could be separate from this PR (stop trying to run on deleted paths, run on paths that actually exist) or I could keep the changes together.

Wait, your example output has an error xargs: argument list too long. Windows?

Also, Windows isn't supported by pytype >_> https://github.com/google/pytype#requirements


Add a Issue & PR Template

If anyone wants to contribute under Hacktoberfest 2024 then do comment, I will assign it to you.

I want to contribute  on issue #35 which is raised by me under Hacktoberfest 2024 .

@Sthorat22 The issue has been assigned to you.
Before you start working on your PR, please make sure to:

⭐ Star the repository if you haven't already.
Pull the latest changes to avoid any merge conflicts.
Attach before & after screenshots in your PR for clarity.
Include the issue number in your PR description for better tracking.

I'm excited to see your contribution as part of Hacktoberfest 2024! 🎉
Don't forget to follow me on GitHub for more updates.
Happy open-source contributing! 🚀

@anuragverma108 can i add the issue template and the pr template . pls assign this to me under hacktoberfest

I want to contribute for Hacktoberfest 2024 .


The Network tracer collects all of Capybara's webdriver commands

Hello,
Just wanted to report that I noticed that all of Capybara's webdriver HTTP calls are listed in Buildkite's test execution UI (see screenshot). I was unable to find a way to blocklist these, and they are both cluttering the Analytics results, and putting strain on Buildkite's servers.

Thanks @psbordjukov. This is definitely something we would like to improve but at present this work hasn't been scheduled.


Deprecate and remove the Clustering Plugin

Spinning this ticket off of what I mentioned in https://github.com/mapbox/mapbox-plugins-android/issues/518. The Cluster Plugin offers no advantage of GeoJSON runtime clustering and IMO only promotes usage of GLMarkers which don't nearly have the same extensive API set as symbol layers (as we've discussed in great lengths in the past).
cc: @tobrun @zugaldia

After some discussion internally with @tobrun, we have decided the best path forward will be deprecating and removing this plugin. There are several different cases which you might be using clustering for but all the use cases for this plugin can be done using runtime styling as mentioned above. If you have any questions migrating over to runtime styling, please feel free to reach out on this ticket or through our support page.

The Demo app contains a few examples of how to implement clustering using runtime styling. Some good reference activities include:

GeoJsonClusteringActivity
CreateHotspotsActivity
SymbolLayerMapillaryActivity

The whole is app open source and available for download in the Play Store.


generateJitteredKeyBetween doesn't work when the first arg is null

Hello, thanks for the great tool.
I came across unexpected behavior of generateJitteredKeyBetween. I'd appreciate if there's any idea or help for it.
This works and returns b0U.
generateJitteredKeyBetween("b0T46n", null);

But, this doesn't work.
generateJitteredKeyBetween(null, "b0T46n");

Error logs.
Error: invalid order key length: bS
 ❯ getIntegerPart node_modules/fractional-indexing-jittered/lib/index.js:256:11
    254|   const integerPartLength = integerLength(head, charSet);
    255|   if (integerPartLength > orderKey.length) {
    256|     throw new Error("invalid order key length: " + orderKey);
       |           ^
    257|   }
    258|   return orderKey.slice(0, integerPartLength);
 ❯ paddingNeededForJitter node_modules/fractional-indexing-jittered/lib/index.js:353:19
 ❯ Module.generateJitteredKeyBetween node_modules/fractional-indexing-jittered/lib/index.js:417:25
 ❯ src/utils/findex.spec.ts:47:27

The function without jittered works and returns bS.
console.log(generateKeyBetween(null, "b0T46n"));

Thanks!

It seems tweaking this part would solve this case though, not sure how it affects other parts.
while (result.length > 2 && result[0] === charSet.byCode[0]) {

https://github.com/TMeerhof/fractional-indexing-jittered/blob/8077c3090ab497c39d89f7b478b7abcc1fd897c0/src/keyAsNumber.ts#L109


document xsuspender's autostart capability

... when used with desktop environments.

Lgtm, thanks!

Lgtm, thanks!

Thanks @kernc !


Deno compatible local client

Hey I was very interested in learning how to use Turso on my most recent Deno project.
I resorted to making a Deno compatible client for local development as Deno only had support for the web version. This has allowed me to have a consistent API to use through our local and deployment stages & feel as though I'd like to have other Deno developers interested in using LibSql have the same experience.
What would be the recommended way that we could get something going? I am not sure if it would make more sense as a 3rd party module or one that could be integrated with the official repo but I'd be keen to help contribute if possible.
Thank you

@adoublef How different is the code from this repository? Is there a way to make this package work both on Node and Deno? If your code is open source, please share a link.

The only difference is the removal of better-sqlite3 dependency. Everything else is is designed the same. There are two Deno packages both can work but with caveats:

Denodrivers seem to be the officially supported one but makes use of ffi's meaning that as of today, can't be used on Deno Deploy (I am unsure if this restriction will exist on other cloud platforms)
Dyedgreen's version uses WASM and so doesn't have the same deployment restrictions but as of today they don't  have the ability to check it the db connection is open (which is needed here) though I may have another look at that.

My code is open but it is just linked inside a hobby project as I originally just wanted it to work for local development. Hadn't thought of moving it into a different package. The code can be viewed here. Most of the implementation imports directly from esm.sh which is great. It was only the ResultSetImpl that I needed to change to use a Deno compatible base64 encoder

With regards to the second package they do have a private property here so may just be something I can ask the maintainers to expose.
I also was not able to get this test to pass, looks like it should be a string representation but I keep getting a number value. Something that isn't an issue for me but I'd imagine this needs to work if it is to be something others will want to use.

@adoublef Thanks for the information! How useful is local development option if you can't use it in Deno Deploy? From libsql perspective, perhaps a better integration strategy is to have the Deno runtime use the Rust crate and then expose via a TypeScript API? We're currently working on a Rust crate that could be used for this: https://github.com/libsql/libsql/tree/main/crates/core It's still work in progress, but will support local files, embedded replicas, and HTTP remote access.

@penberg great question. I would say the benefit most definitely comes from consistent API. Both current SQLite packages are incomplete, although if the Dyedgreen's version would be the closest to being usable quickly as they only need to expose the this.#close property to allow me to implement the Transactions. I
I think I also started working on this prior to learning the plans of a Rust crate so I suspect will have better support so will be eager to watch out for that.
Currently my use case is still hobbyist and so I have a separate main.ts and dev_main.ts file for local and deployment. Likely not the best solution for everyone but works for me. I am still looking to see if it's possible to not do this but I'm just learning about how Rust bindings, FFIs and Deno all work together.

EDIT: I asked the question in the discord and apparently this is true
As long as you do not call Deno.dlopen it should be fine, even if there's a code path that could call it.

So this is my aim at the minute to see if this is true. If so then may additionally help when it comes to calling code written in external languages

I just wanted to update that this may have resolved things for both local & public deployment, meaning can use the one entrypoint and not need to mantain separate main and dev_main entrypoint files, leading to better DX.
Here is a deployed application that just selects the number 42 from turso. I am using the deno-sqlite library, I just need to push a PR for that library.

entrypoint link - playground/cmd/libsql/main.tsx at main · adoublef-js/playground (github.com)
library link - playground/lib/libsql/dyedgreen/create_client.ts at main · adoublef-js/playground (github.com)

Just wanted to bump this by saying I moved the example over to my main project as it's a bit cleaner.
Here is the application on Deno Deploy, just querying 42 from the Turso database. Here is the code to show that there is just one implementation now which works both in local dev and in deploy
@honzasp @penberg

gentle bump

I am experiencing this issue now


[Feature Request]: Update Dependencies for `llama-index-llms-gemini

Feature Description
I am encountering a dependency conflict when attempting to add the llama-index-llms-gemini package to my project and I think some developers might have this problem too. The current version constraints for llama-index-llms-gemini are incompatible with the latest versions of llama-index-core and google-generativeai that some projects might rely on.

Current Issue:
When running the command:
uv add llama-index-llms-gemini

I receive the following error:
No solution found when resolving dependencies for split (python_full_version == '3.10.*' and platform_python_implementation != 'PyPy' and platform_system == 'Darwin' and sys_platform != 'linux'):
  ...
  And because your project depends on llama-index-core>=0.11.14 and llama-index-llms-gemini, we can conclude that your project's requirements are unsatisfiable.

Root Cause:

llama-index-llms-gemini Versions:
Available versions (0.0.1 to 0.3.5) have dependencies that conflict with:

llama-index-core >=0.11.14
google-generativeai >=0.8.2

Dependency Constraints:

llama-index-llms-gemini <0.3.0 depends on llama-index-core <0.11.0.
llama-index-llms-gemini >=0.1.9 depends on google-generativeai >=0.5.2,<0.6.0.
My project requires llama-index-core >=0.11.14 and google-generativeai >=0.8.2.

These constraints make it impossible to satisfy all dependencies simultaneously, preventing the successful addition of llama-index-llms-gemini.

Proposed Enhancement:
Update the llama-index-llms-gemini package to support higher versions of its dependencies, specifically:

llama-index-core:

Current Constraint: <0.11.0
Proposed Update: >=0.11.0 to align with projects using llama-index-core >=0.11.14.

google-generativeai:

Current Constraint: >=0.5.2,<0.6.0
Proposed Update: Expand the upper limit to accommodate >=0.8.2, such as >=0.5.2,<1.0.0.

Benefits:

Improved Compatibility: Allows projects using newer versions of llama-index-core and google-generativeai to integrate llama-index-llms-gemini without dependency conflicts.
Enhanced Flexibility: Facilitates smoother upgrades and maintenance for projects relying on these packages.
Broader Adoption: Reduces barriers for developers to use llama-index-llms-gemini in modern environments.

Additional Context:
I have verified that other dependencies in my project are compatible with the proposed updates. Ensuring that llama-index-llms-gemini supports these higher versions will greatly enhance its usability and integration within contemporary Python projects.

Possible Solutions:

Update Dependency Specifications:
Modify the setup.py or equivalent configuration to relax the version constraints for llama-index-core and google-generativeai.

Semantic Versioning:
Ensure that the updates follow semantic versioning to indicate compatibility and prevent breaking changes for existing users.

Testing:
Provide comprehensive tests to verify that llama-index-llms-gemini functions correctly with the updated dependency versions.

Thank You:
Thank you for your continued efforts in maintaining and improving the llamaindex project. Your work is greatly appreciated by the developer community!
Reason
No response
Value of Feature
No response

@arthurbrenno here's the current deps for the gemini llm
It already specifies llama-index-core  = "^0.11.0"
Probably can loosen the generative-ai dependency, assuming that google hasn't made many breaking changes

Oops, forgot the link
https://github.com/run-llama/llama_index/blob/main/llama-index-integrations/llms/llama-index-llms-gemini/pyproject.toml

Thanks, Logan.


home button added

Pull Request Template
Thank you for your contribution to CodeBase! Please provide the following information to help us review your pull request.
Description

Language Used: HTML, Tailwind CSS
Approach Used: Added a static "Home" button styled using Tailwind CSS.
Question(s) Solved: N/A
Issue(s) related: N/A

This pull request adds a visually styled "Home" button using the <button> tag. The button is styled with Tailwind CSS for a clean appearance, with hover and focus effects for enhanced user experience. The button currently has no functionality and is intended as a static UI element.

What does this PR fix or add? Adds a styled static "Home" button to the UI.
Are there any dependencies or related issues? No dependencies.
Any special instructions for testing? Ensure the Tailwind CSS framework is properly configured to view styles.

Type of Change
Please select the appropriate option by putting x (example- [x]):

[x] New feature

Checklist

[x] I have tested my changes locally.
[x] I have followed the coding style of the project.
[x] My code is ready for review.

Screenshots

We will review your changes and get back to you soon. Thank you for contributing to CodeBase!

Keep the Codebase logo as it is and add a Home button between the Filter button and the Login button.

Okay

Keep the Codebase logo as it is and add a Home button between the Filter button and the Login button.

I updated those changes as requested

Share your updated screenshot.


Binding the IsVisible-property does not seem to work

I have a carousel view with an ObservableCollection as ItemSource.
This is my code in the xaml-file:
HomePage:
<carousel:CarouselViewControl Grid.Row="2"
                              x:Name="Carousel"
                              IsVisible="{Binding ShowCarouselView}"
                              Orientation="Horizontal"
                              InterPageSpacing="0"
                              ShowIndicators="True"
                              ShowArrows="False"
                              IndicatorsTintColor="{StaticResource colorDetail40}"
                              CurrentPageIndicatorTintColor="{StaticResource colorAccent100}"
                              ItemsSource="{Binding CarouselListItems, Mode=OneWay}"
                              HorizontalOptions="FillAndExpand"
                              VerticalOptions="FillAndExpand">
  <carousel:CarouselViewControl.ItemTemplate>
    <DataTemplate>
      <ContentView Content="{Binding .}" />
    </DataTemplate>
  </carousel:CarouselViewControl.ItemTemplate>
</carousel:CarouselViewControl>

In the code-behind HomePage.xaml.cs:
protected override async void OnAppearing()
{
  base.OnAppearing();

  await UpdatePage();
}

async Task UpdatePage() => await ViewModel.LoadDataAsync();

HomeViewModel.cs
public override async Task LoadDataAsync()
{
  if (IsBusy) {
    return;
  }

  try {
    IsBusy = true;
    ShowCarouselView = false;
    IsLoadingData = true;

    CreateCarouselItems();

    await GetDataFromStoreAsync();

    IsLoadingData = false;
    ShowCarouselView = true;
  }
  finally {
    IsBusy = false;
  }
}

bool CreateCarouselItems()
{
  bool success = false;
  CarouselListItems.Clear();
  CarouselListItems.Add(new WeatherInfoSection() { Location = CurrentLocation });
  CarouselListItems.Add(new MapInfoSection() { Location = CurrentLocation });
  CarouselListItems.Add(new FishingTripInfoSection()); // Die letzten drei Angelausflüge
  CarouselListItems.Add(new CatchInfoSection());
  success = true;
  return success;
}

The data is loaded and the property ShowCarouselView is set to true, but there is no display.
If I set the property ShowCarouselView to true before the CreateCarouselItems();, then it will be displayed

This control has been merged into Xamarin.Forms master branch. Please, wait for it to be released as part of Xamarin.Forms and submit any issues there https://github.com/xamarin/xamarin.forms/tree/feature-carouselview. Thanks

Is this working now?

I am also having this issue.


Compute the osm places shape

cosmogony.world still has a lot of missing cities. This is mainly due to the cities shape not being in osm.
But in osm, when cities are missing, there are often nodes with type=city or type=town.
In this PR we try to compute rough shape for those nodes.
In order to do this, we compute a voronoi diagrams for each "parent" zone.
the algorithm is roughly:
for each parent:

take all nodes [type=city or type=town] in it and compute a voronoi from it
for each each take its voronoi and subtract:

the parent's shape
all nicely bounded cities in this parent.

This PR is a work in progress. There are still lots a TODOs and it depends on:

[x] https://github.com/georust/wkt/pull/38
[x] https://github.com/QwantResearch/osm_boundaries_utils_rs/pull/7
[x] https://github.com/georust/geos/pull/22

This should fix #19

Replaced with #84


Indexer stack prefixes can collide in stats

Issue raised by @thepsalmist in slack-  Stats namespaces in grafana/statsd for story-indexer are determined by the stack-type prefix of a deployment ("csv-", "rss-", etc) - if more than one of a given stack type is deployed at a time (in the context of historical re-ingest for example) the stats will be collected in the same statsd location, making observation of both stacks difficult.
Would it be simple to introduce a unique infix (ie rss-1-*, per @kilemensi) to prevent this in the future?

Would it be simple to introduce a unique infix (ie rss-1-*, per @kilemensi) to prevent this in the future?

IMO: No. Since stacks of the same name/type would be, by definition, deployed on different swarm clusters, there is no automagic way to determine if there are others of the same name/type active, nor a way to deterministically enumerate them (other than to include the name of the current cluster leader).
At some point I did consider adding a command line option to deploy.sh to allow a manual override for some additional parameter (I forget if it was stats reporting name, or archive file name), but it struck me as "too many knobs" and adding clutter for situations that are (or should be) to say the least "out of the ordinary" and "to be avoided"
I've stated that I think I could improve tqfetcher's rates, which would have the long-term benefit/defense of dealing better of being better able to catch up from downtime, as well as speed up the 2022 rss ingest, but that didn't seem to get any traction.
And while I'm not a fan of running THREE tqfetchers (production and two rss stacks), if that's determined to be acceptable in this instance, my suggestion is to make a copy of deploy.sh (editing it in place will trigger it's test that the repo be "clean" -- checked in and pushed), and crock it for the hopefully RARE occasions when more than one stack of the same type/name is run.

Ok, heard! Just planning to avoid this circumstance sounds a lot more straightforward than trying to address this. Thanks for the feedback!


How to handle code snippets can be highlighted with css

Sorry, my english is noob . I want to implement the following features.
markdown -> html
i will be
```java
void render(N node, NodeFormatterContext context, MarkdownWriter markdown);
```

convert to

  void
  render
  (
  N
  node
  ,
  NodeFormatterContext
  context
  ,
  MarkdownWriter
   markdown);

Like github, i want use the style to achieve highlighting, please tell me how to do.
(Sorry , It seems that my English expression is terrible.)

@vsch

@Jack1477, you need to provide a custom node renderer for fenced code blocks where based on the fenced code info string (the language string) you will have to parse the text content and generate the HTML.
GitLab extension module adds custom fenced code handling so it is the best place to look: flexmark-ext-gitlab
You can also see #205, How create wrapper for PlantUML in markdown?
This library does not parse contents of fenced code or do any syntax highlighting. This is left to JavaScript libraries which can be added to the rendered HTML to handle.

Thank you for your prompt reply, this is very helpful to me.


proposal: Go 2:

hello, does Go generics support using constant values as params ?
in C++
template<class TT,TT init>
class class2
{
public:
TT data;
class2()
{
data = init;
}
};
class2<int,100> col;
the "100" is the constant value as template param

Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.
For questions please refer to https://github.com/golang/go/wiki/Questions


Trajectory planning for long vehicles not working properly

Checklist

[X] I've read the contribution guidelines.
[X] I've searched other issues and no duplicate issues were found.
[X] I'm convinced that this is not my fault but a bug.

Description
While testing of ITRI Bus on ITRI campus in AWSIM, I've discovered that the planner does not work properly for planning of turns for long vehicles. As can be noticed on the screenshot below, the bus is trying to "cut" the right turn by driving on the sidewalk. I know that there were seperate issues/discussions about expanding drivable area, but in this case we should think about different trajectory planning algorithm considering the dimensions of the vehicle. In reality, long vehicles like buses drive more to the outer part of the road, to avoid driving on the sidewalk.

The same behavior was observed in the planning_simulator, so it's not related to AWSIM:

Used vehicle model :
https://github.com/autowarefoundation/cbus_vehicle_launch
Location of the observed problem:

EDIT:
After more investigation, it looks like the problem can be solved by modifying drivable area (https://github.com/orgs/autowarefoundation/discussions/2851). Anyway, I believe that to make it possible for longer vehicles to behave properly, in some cases the drivable area should be even moved away from inner turn radius (in current logic the negative value of bound_offset)
Expected behavior
Bus properly driving on the entire map of ITRI campus.
Actual behavior
Bus gets stuck on the right turns.
Steps to reproduce

Run planning simulator with ITRI map and cbus_vehicle
Set the goal poses to follow demo route 2 defined for ITRI project : link

Versions
No response
Possible causes
No response
Additional context
No response

I think the current solution was to extend the drivable area to the opposite lane.
@satoshi-ota Can you explain the details?

Hi @WJaworskiRobotec
As @yukkysaito said, we have to expand the drivable for large vehicles, such as buses and trailers, to make turns at small intersections. In fact, the discussions is in progress here about the feature to dynamically expand the drivable area, but this has not yet been implemented.
On the other hand, the feature to expand the drivable area statically already exists. The feature expands the width of the drivable area in module behavior_path_planner (e.g. LaneFollowing) by a specified amount, which can be changed with the following parameters.
https://github.com/autowarefoundation/autoware.universe/blob/f1efcc2e163164ef40f4d1691aa6bc4e5cc9938d/planning/behavior_path_planner/config/drivable_area_expansion.yaml#L1-L20
FYI:

https://github.com/autowarefoundation/autoware.universe/pull/1973
https://github.com/autowarefoundation/autoware.universe/issues/1854

Paths to cover as the first step are defined here : https://github.com/autowarefoundation/autoware-projects/issues/45

@WJaworskiRobotec
Here are my inputs/thoughts about the issue if this temp solution is used for this turn:

(out of context) First of all when I use this vehicle model and itri_bus_sensor_kit I got the results as below. It seems like sensor kit-base_link-3D mesh are not properly aligned. If it is needed @kaancolak can give more detailed info about this and offer his help. For now I won't be using the 3D vehicle model to show the results.

Idk if I alone encountered this but the 3D vehicle model shown in rviz seems to have an offset wrt base_link.
When I visualize the footprint of the vehicle /planning/scenario_planning/lane_driving/motion_planning/surround_obstacle_checker/debug/footprint calculated with given vehicle parameters this is the result:

https://user-images.githubusercontent.com/48479081/201646903-f96c4e15-b631-4186-abbc-4650cfe36668.mp4
@WJaworskiRobotec If these are not my mistake I guess an issue should be created about it.

To add road_border tag  here is a way of how it can be done with vector_map_builder:

Simply click on a linestring and choose road_border as type.
Optionally you can select multiple linestrings by holding SHIFT key and clicking on the ones whose type you wanna change then type road_border.

https://user-images.githubusercontent.com/48479081/201650423-de235eb1-06b8-4ef4-acc6-52e9a8d50ebb.mp4

When we start the autoware with drivable_area_expansion parameters (lets say 1.5 m for all -right&left-) still you wont see that it is not expanded on the road_border sides.
The reason is that; when using the expandLanelets function you can specify the types you would like to skip. And it is road_border type as default. But only in avoidance_module it is given. So you have to add road_border type in lane_following module as an argument as well for this demo as it is done in avoidance_module.

@maxime-clem Is this done intentionally? If not shall we create a PR where all the modules use road_border arg as default to skip the expansion?

Then we will have and expanded lanelet only on sides we want it to be:

https://user-images.githubusercontent.com/48479081/201657417-6be2bff3-a4a2-43e1-9252-6256ed324837.mp4
In the video you will see that side of the vehicle is outside of drivable_area, yet it doesn't stop. It is because in obstacle_avoidance_module only the corners are checked if they are out or not. This issue is known and worked on in #1999 and will be merged soon hopefully.
However it possible to handle the turns better since there is lots of space available yet we are not able to turn safely. It can be accomplished by enabling the parameter kinematics.optimization_center_offset and assigning 0 to it. Which it will make it possible that base_link will be optimization center and yields more realistic optimization results. Here is more info about it. To me for long vehicles such as buses optimization center should be base_link. Idk also as default if we should change it or not @mitsudome-r @maxime-clem? On isuzu bus but we use base_link as optimization center.
Results after changing the optimization center:
https://user-images.githubusercontent.com/48479081/201664436-b1ab0fee-c341-4a1e-86e7-3a5015e4cf47.mp4

@mehmetdogru

To me for long vehicles such as buses, optimization center should be base_link

I agree with this idea.
The default tuning of kinematics.optimization_center_offset is for a normal car. Therefore, I think it's good to set 0 for buses.
If you have further question about tuning of obstacle_avoidance_planner package, feel free to ask me.

@maxime-clem Is this done intentionally? If not shall we create a PR where all the modules use road_border arg as default to skip the expansion?

You are right and this is something I overlooked in my previous PR. I will prepare a new PR to fix this.


go get of istio.io repos seems to be having some issues intermittently

Bug Description
Occasionally a go get will return an error:
> go get istio.io/api@d4c0b38fb0027dc3540c21e7f849ece8414509fa
go: istio.io/api@d4c0b38fb0027dc3540c21e7f849ece8414509fa: unrecognized import path "istio.io/api": reading https://istio.io/api?go-get=1: 404 Not Found

other times it may not grab the commit you are expecting.
a go get istio.io/istio@master may not return the latest commit, but an earlier one.
I'm not sure if this is a caching issue, something to do with the returned "go-import" meta name content, or something else.
I have noticed that sometime when this happens, but not all the time, one curl seems to work:
> curl  "https://istio.io/client-go/?go-get=1"
<html><head>
    <meta name="go-import" content="istio.io/client-go git https://github.com/istio/client-go">
    <meta name="go-source" content="istio.io/client-go     https://github.com/istio/client-go https://github.com/istio/client-go/tree/master{/dir} https://github.com/istio/client-go/blob/master{/dir}/{file}#L{line}">
</head></html>

but removing the trailing /, does not:
> curl  "https://istio.io/client-go?go-get=1"
<!doctype html><html lang=en itemscope itemtype=https://schema.org/WebPage><head><meta charset=utf-8><meta http-equiv=x-ua-compatible content="IE=edge"><meta name=viewport content="width=device-width,initial-scale=1,shrink-to-fit=no"><meta name=theme-color content="#466BB0"><meta name=title content="404 Page not found"><meta name=description content="Connect, secure, control, and observe services."><meta name=keywords content="microservices,services,mesh"><meta property="og:title" content="404 Page not found"><meta property="og:type" content="website"><meta property="og:description" content="Connect, secure, control, and observe services."><meta property="og:url" content="/latest/404.html"><meta property="og:image" content="https://raw.githubusercontent.com/istio/istio.io/master/static/img/istio-social.svg"><meta property="og:image:alt" content="Istio Logo"><meta property="og:image:width" content="1200"><meta property="og:image:height" content="600"><meta property="og:site_name" content="Istio"><meta name=twitter:card content="summary"><meta name=twitter:site content="@IstioMesh"><title>Istio / 404 Page not found</title><script async
...

Version
N/A

Additional Information
No response
Affected product area

[ ] Ambient
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[X] Test and Release
[X] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Control Plane Revisions

Some more data from some exploration yesterday:
> go get -x istio.io/client-go@f27e09ad6e63c39b7dd057f3073e3ba09e191f6f
# get<EMAIL_ADDRESS># get<EMAIL_ADDRESS># get<EMAIL_ADDRESS>404 Not Found (0.310s)
# get<EMAIL_ADDRESS>404 Not Found (0.311s)
# get https://istio.io/?go-get=1
# get https://istio.io/client-go?go-get=1
# get https://istio.io/client-go?go-get=1: 404 Not Found (0.355s)
# get https://istio.io/?go-get=1: 200 OK (0.356s)
go: istio.io/client-go@f27e09ad6e63c39b7dd057f3073e3ba09e191f6f: unrecognized import path "istio.io/client-go": reading https://istio.io/client-go?go-get=1: 404 Not Found

I haven't seen go get failures recently. Maybe the issue is fixed or we are just having fewer pipeline jobs doing go gets.

Closing as I haven't seen this recently.


Implement #loadProgram ByteArray

Part of : https://github.com/runtimeverification/firefly/issues/1150

@anvacaru please check through driver.md and state-loader.md and check for any other places that touch the <program> cell, to see if they need to be made to go through #loadProgram instead.

@anvacaru please check through driver.md and state-loader.md and check for any other places that touch the <program> cell, to see if they need to be made to go through #loadProgram instead.

@anvacaru please check through driver.md and state-loader.md and check for any other places that touch the <program> cell, to see if they need to be made to go through #loadProgram instead.

There are two loadCallState functions which alter the <program> cell in those files.
https://github.com/kframework/evm-semantics/blob/master/driver.md#261 @ line 261
https://github.com/kframework/evm-semantics/blob/master/state-loader.md @ line 148

@anvacaru please check through driver.md and state-loader.md and check for any other places that touch the <program> cell, to see if they need to be made to go through #loadProgram instead.

There are two loadCallState functions which alter the <program> cell in those files.
https://github.com/kframework/evm-semantics/blob/master/driver.md#261 @ line 261
https://github.com/kframework/evm-semantics/blob/master/state-loader.md @ line 148

@anvacaru it looks like both of those locations should also use the new #loadProgram primitive.

@anvacaru it looks like both of those locations should also use the new #loadProgram primitive.


Connect testing to new code

Summary of what happens in this PR:

Tests now only test the new code (against old reference numbers so functionality is preserved)
Test time got shorter
Added the Becke-Johnson damping also to the new code
Renamed dftd3 to dftd3_old
Did not remove any code in dftd3_old
There is no command line interface in the new code (see follow-up below)

Follow-up steps for later:

Decide whether to re-introduce a command line interface in front of the library
Update README
Maybe disconnect fork-relation to avoid sending PRs accidentally to upstream
Remove examples since they are not relevant for this code?
Maybe introduce wrapper functions to simplify the calls when differentiating

More follow-up:

The parameters.csv location is a bit hardcoded and the loading of coefficients and parameters is not elegant

We can disconnect the fork relation. You rewrote the whole thing and there's not much relation anymore anyway 😄

I mean I don't mind the fork relation but for a moment I got very confused when after opening the PR form I saw dozens of commits which I didn't do until I noticed that it automatically takes upstream as the destination.


Switch to the classic Mbed TLS ChangeLog format

Instead of working with Markdown format, keep the classic Mbed TLS ChangeLog format, with the classic category names. Keep the classic file name as well. This way there's no risk of breaking third-party scripts that may copy or even parse the changelog file.
I also added some guidance on writing a changelog entry.

this regex-and-index style is also readable

I actually find the regex style more readable for the parsing itself. But keeping track of line numbers for error messages negates the improvement by infecting a large part of the code. A good parsing library should make this more transparent, but I don't want to add a dependency on a third-party library.


cicd: add test and release GH actions

Changes Made

Add test and release GH actions for safe release to Charmhub

Closing as addressed in Add release pipeline #12


build

$ docker build -t ords:$ORDS_VERSION .
Sending build context to Docker daemon  60.36MB
Step 1/11 : FROM openjdk:8-jre-alpine
---> ce8477c7d086
Step 2/11 : MAINTAINER Martin DSouza<EMAIL_ADDRESS>---> Using cache
---> 06666e07acb0
Step 3/11 : ENV TZ="GMT"   APEX_CONFIG_DIR="/opt"   TOMCAT_HOME="/usr/local/tomcat"   APEX_PUBLIC_USER_NAME="APEX_PUBLIC_USER"   PLSQL_GATEWAY="true"   REST_SERVICES_APEX="false"   REST_SERVICES_ORDS="true"   MIGRATE_APEX_REST="true"   ORDS_DIR="/ords"
---> Using cache
---> 51cdfe925ba0
Step 4/11 : WORKDIR ${ORDS_DIR}
---> Using cache
---> 6f1a50a5b933
Step 5/11 : COPY ["ords.war", "scripts/*", "/tmp/"]
---> Using cache
---> 6278b12600c5
Step 6/11 : RUN chmod +x /tmp/docker-run.sh &&   /tmp/docker-run.sh
---> Running in 8d84c782653c
/bin/sh: /tmp/docker-run.sh: not found
The command '/bin/sh -c chmod +x /tmp/docker-run.sh &&   /tmp/docker-run.sh' returned a non-zero code: 127

hello martin,
i experience the same issue
Step 5/11 : COPY ["ords.war", "scripts/*", "/tmp/"]
 ---> 5c02f6b71e59
Step 6/11 : RUN chmod +x /tmp/docker-run.sh &&   /tmp/docker-run.sh
 ---> Running in ad25a1c849d6
/bin/sh: /tmp/docker-run.sh: not found
The command '/bin/sh -c chmod +x /tmp/docker-run.sh &&   /tmp/docker-run.sh' returned a non-zero code: 127

Best Hansjörg

Hi, I had similar problem, but I found solution.
Make sure that all off the scripts are saved in correct format line break.
I download git repo on Windows, send it to Linux and have same error. After changing line break to linux in Notepad++ Docker scripts run fine.

All: Please use latest files for this project and see if it's still giving the same errors.

Closing since haven't hear any responses.


Limit by library

I have several libraries, all quite large.  Two are manga, others are comics, novels, etc.  I want to be able to limit it to only scan one library when I run it.
Describe the solution you'd like
Either a library selection list, or a setting in the config.py that would allow library limiting.

Found a workaround - create regular user, limit libraries, then make admin.  Can only see those libraries.

sounds good


Contract test suites

What:
The tests are now divided into suites. This is reflected in two ways:

When the tests are run using SpecmaticJUnitSupport, the tests are now grouped by suite instead of being in one long list.
The test names now have a prefix against the name reflecting the suite that they're in.

Why:
It became necessary to be able to tell a team, just pay attention to the "within-bounds" tests for now. It would be more convenient if we could give them a switch to avoid the noise.
How:
We've updated added a --suite parameter. It takes 'W' for Within-bounds tests, WG for Within-bounds generated tests, and O for Outside-bounds tests.
The test names show the suite name as a prefix to the test name if running from the terminal.
Checklist:

[ ] Documentation added to the README.md OR link to PR on https://github.com/specmatic/specmatic-documentation
[ ] Tests
[ ] Sonar Quality Gate

Issue ID:
Closes: #123

Will redo this PR later


more GPUs and visualization

@hyhieu Hi,thank you for you work,and I have worked out the question how to get 24 cells with you help last time .Now，I have another two questions.First,how to run this code with 2 or more GPUs on one computer? Second , which file are the  architectures from the  "./scripts/cifar10_micro_search.sh"  file  saved in  and  would you support a method  to visualize them?
the information  after I run the  ./scripts/cifar10_micro_search.sh file  as following:
output:
checkpoint
model.ckpt-108769.data-00000-of-00001  model.ckpt-109120.data-00000-of-00001
stdout
events.out.tfevents.1523973322.sugon-W580-G20  model.ckpt-108769.index
model.ckpt-109120.index
graph.pbtxt
model.ckpt-108769.meta
model.ckpt-109120.meta

Thank you very much,I will have a try.


Add Device page warning for empty fields.

#157
We need to check if any of the fields are empty, and display a warning if they are and ask the user if they want to continue.

updated assignment/sprint after SCRUM discussion


Confusion about the calculation of gradient

Hi! Thank you for your fantastic work. When calculating the gradient of SDF flow (normal) at every timestamp, why did not you use torch.autograd function?

thank you for you interests. The main purpose is to save some time.


Show image manifest for containers

Show image manifest for containers, so users can know exactly which
image they are running. This will be helpful if you are using
images with latest tag.

Manifest Schema https://docs.docker.com/registry/spec/manifest-v2-2/

Tools that can extract image information without needing docker
https://github.com/containers/skopeo


Reproduction

Hi!
I reproduced some of your results:
https://github.com/TropComplique/associative-domain-adaptation
Also I managed to train a MNIST to SVHN domain adaptation.
Trick I used: random color augmentation on MNIST digits and backgrounds.

Thank you for the update!
On Sun 23. Dec 2018 at 21:03, Dan Antoshchenko<EMAIL_ADDRESS>wrote:

Hi!
I reproduced some of your results:
https://github.com/TropComplique/associative-domain-adaptation
Also I managed to train a MNIST to SVHN domain adaptation.
Trick I used: random color augmentation on MNIST digits and backgrounds.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/haeusser/learning_by_association/issues/17, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFshmA-hyGOcS_AFvY88EUYBUC8lto5Zks5u7-GZgaJpZM4Zf-LG
.


UI hangs completely when the highchart export is called

Describe the bug
A blank screen covers the entire UI and there is no way to do any action when the highcharts default export is invoked.
To Reproduce
Steps to reproduce the behavior:

Go to Hello World page
Click on export menu on the chart
Click on 'Download PNG'

The UI hangs completely while the file is being saved.
Expected behavior
UI should not hang.
Screenshots
Screenshot, screen recording, and sample app attached to reproduce it
Environment (please complete the following information):
Lens: 5.4.6-latest.20220428.1
Electron: 14.2.4
Chrome: 93.0.4577.82
Node: 14.17.0
© 2021 Mirantis, Inc.

MacOS: 12.3.1

https://user-images.githubusercontent.com/38350
helloworld-sample.zip
997/169162907-e37ea11a-e427-4a6c-a485-47e03e2aed38.mov

Where did you get that sample code from? That entire component does not appear in https://github.com/lensapp/lens-extension-samples/tree/master/helloworld-sample at all

Hi Sebastian,
I am using the same sample app
https://github.com/lensapp/lens-extension-samples/tree/master/helloworld-sample
with little changes to include highcharts.
I have attached the patch of changes on git also here.
lens-patch-highcharts.patch.zip
Thanks,
Tashi

We have run into a similar symptom a few times. Maybe it is related to a CSS rule that is "display: none".
Though further request for debugging help about extensions, please use the public slack.


Parse multiple cookies in single string?

HTTP clients must send a single Cookie: header with all the cookies separated by a ;  according to RFC 6265.
If I attempt to parse such a header, I only get the first cookie:
let cookie_str = "__Secure-A=AAA; __Secure-B=BBB";

// Only returns first cookie, '__Secure-A'.
cookie::Cookie::parse(cookie_str).unwrap();

Currently I manually split the header value by ';' and parse each cookie. It would be nice to have a method eg. parse_multiple that returns a Vec<Cookie>

See #156 and #137.


Particle trails not working with attractor

Godot version
4.0beta5
System information
PopOS 22.04, 6.0.3-76060003-generic kernel, Ryzen 6800h, Radeon 6700m, amdgpu, Vulkan
Issue description
When utilizing particle trails (via shader, dont mind the error because I'm not using godot material) and attractors, it doesn't seem to work.
Changing the settings on the attractor do not work
Steps to reproduce

Add a ribbon trail particle
Add an attractor

https://user-images.githubusercontent.com/15805689/202323038-95c617bf-9373-46ee-ad0b-9b42464b23f4.mp4
Minimal reproduction project
No response

Can you please upload an MRP that reproduces the bug so that contributors can try to reproduce and fix this?

@clayjohn https://github.com/Mikeysax/example-project-for-godot-bug-gpu-particle-attractor-68756


Replace npx with node in README

npx does not work with paths
In Node 14.x CLI documentation it's unclear that it's valid to pass a path to a package, however I've tested it and it seems to work as documented by Node 16.x documentation:
https://nodejs.org/docs/latest-v16.x/api/cli.html#command-line-api

I have read the CLA Document and I hereby sign the CLA


Input type text vs button

Hi.
It would be much better if the input would be button, because on mobile while you have input type text, when you focus on it the keyboard appears.

Hi,
moment-range is a JS library to extend the capabilities of http://momentjs.com with regards to date ranges.
What library/framework are you using for your UI? We may be able to point you in the right direction.


Media references not resolved when adding additionalParams

Hello everyone,
Currently I'm facing the problem that when I add the additionalParams parameter to my fetchByFilter request that the response is not resolved correctly. For example I want to resolve for alt and resolutions from an image.
In the CaaS docs I found an entry to resolveRefs under https://docs.e-spirit.com/module/caas-platform/CaaS_Platform_Documentation_EN.html#ref-resolving. But how can I use this feature in this type of request?
My current request looks like this:
const res = await remoteApi.fetchByFilter({
  filters: [
    {
      field: 'fsType',
      operator: ComparisonQueryOperatorEnum.EQUALS,
      value: 'PageRef',
    },
    ...
  ],
  locale,
  page: 1,
  pagesize: 100,
  additionalParams: {
    keys: {
      ...
      'page.formData.image': 1,
      ...
    },
  },
});

My response from res.items[0]['page'].formData['image']:
{
  fsType: 'FS_REFERENCE',
  name: 'image',
  value: {
    fsType: 'Media',
    name: '...',
    identifier: '...',
    uid: '...',
    uidType: 'MEDIASTORE_LEAF',
    mediaType: 'PICTURE',
    url: '...'
  }
}

In the request without additionalParams the response of the image contains meta.alt and resolutions.
 image: {
    type: 'Image',
    id: '...',
    previewId: '...',
    meta: {
      alt: '...',
    },
    description: '...',
    resolutions: {
      ORIGINAL: [Object],
      large: [Object],
      retina: [Object],
      medium: [Object],
      retina: [Object],
      ...
    },
    ...
  },

We need to use the additionalParams because the response would be too big from CaaS if we don't filter the keys. This would lead into strong performance issues.
Thank you for your help!

I'm not sure how your questions relates to the query parameter resolveRef - I don't see this in your fetchByFiltercall.
What I can say is that if you filter attributes out from the response (what is done by your addition of keys) then it is expected that attributes in the response are missing. See here for an explanation for what keys is doing: Projection

Regarding your comment for the response size: You are requesting the first 100 documents of type PageRef without additional filter (with an unspecified definition of first). That looks strange.

What's causing the different data formats is the keys attribute in your additional Parameters.
For a normal request, the fsxa API resolves Media References by requesting them from CaaS. Also, it maps the data format from CaaS to a custom fsxa-api Format
If you use the keys param, that reference resolving and data mapping is explicitly skipped, and the unresolved raw data is returned

Regarding your comment for the response size: You are requesting the first 100 documents of type PageRef without additional filter (with an unspecified definition of first). That looks strange.

This was intentionally hidden in my example request here. We have additional filters in our original request for type PageRef.

What's causing the different data formats is the keys attribute in your additional Parameters.
For a normal request, the fsxa API resolves Media References by requesting them from CaaS. Also, it maps the data format from CaaS to a custom fsxa-api Format
If you use the keys param, that reference resolving and data mapping is explicitly skipped, and the unresolved raw data is returned

Thank you for explaining!
But how is it possible to make the response smaller filtering by keys and at the same time resolving the image information without making another request to CaaS?
Making another request for each image wouldn't speed up the performance of my service.

Doing that with the initial request to CaaS won't be possible when relying on the fsxa resolving process.
What you could do, is manipulate your elements on the server in the remote api after they have been resolved, by hooking into the caasItemFilter and then send the trimmed data back to the client.
You find the documentation about that in the (deprecated) fsxa-nuxt-module, though it's actually a feature offered by the (not-deprecated) javascript-content-api. Hence i would deem it safe for usage.
https://github.com/e-Spirit/fsxa-nuxt-module/blob/master/docs/HOW_TO_ACCESS_CONTROL.md
While the idea of this feature is to filter out items that should not be sent to the client, you could manipulate the contents of images as well and trim the content down to your needs.
If you want to trim the actual responses from the CaaS, you would need to implement your own reference resolving and not use the content api for that.


DS-2809 Set default search operator to AND

Setting Solr's default search operator to AND for the Discovery index leads to
search behaviour that's closer to what our users expect -- "do what Google
does". There is a configuration option for the search operator in dspace.cfg.
However, that setting is used only by the legacy DSQuery class for the now
deprecated Lucene-based search.

As discussed on DS-2699 and https://github.com/DSpace/DSpace/pull/1045, here is a separate PR (against master) of the default search operator change.

Was approved during PR review today in #dspace. Plus this idea gained general approval in last week's developers meeting.


Added Buffer property to buffer module

https://github.com/facebook/flow/issues/5133

Signed.

Looks like this has been addressed in #6179


Is the supervision of losses_pts_refine necessary?

I remove the losses_pts_refine in the loss_dict_all, and want to supervise the bbox regression only by the losses_pts_init, but find that in the training process, loss go to NaN after several hundread iters.
Is the loss_pts_refine necessary?

sorry i made a mistake


Reference tag 2.0 in build 2.0

re https://github.com/SBU-BMI/quip_distro/issues/281

we'll need to tag this as 2.0 after


No source file

in the main_csfda.py file, with "from source import train_source_domain", I received an error with "ModuleNotFoundError: No module named 'source'".

I have the same problem. Have you solved it?

I have the same problem too. Have you solved it?

Uploaded the source.py file

In the office-home dataset, there are no artlist, clipart, productlist and realworld files,and the other datasets are also.


Function aliases broken when installed by sh/alias.

(sh/alias "foo" (fn [&args] (print "foo"))) should work. Currently it doesn't due to excessive stringification.
The current work around is to manually add entries to the aliases table.
(put sh/*aliases* "ls" [(fn [&args] ...)] )

It is uncertain how useful this is in practice, since a function alias can't do more than just writing a file to disk.


x/net/trace: add Trace.String()

Currently, the only way to view a trace is to visit the /debug/requests endpoint. This is nice, though impermanent. An application might want to log a trace for a slow request for a more permanent record. I'd like to add Trace.String() as a mechanism for doing this along with Trace.SensitiveString(). Alternately, a single Trace.LogString(sensitive bool) could suffice.

CC @dsymonds

It's not obvious that this is useful. Traces are a sizable object; note that net/http.Request doesn't have a String method either. A trace also collapses the data stored in it when too many events are recorded on it, so it's already somewhat impermanent.

An alternate way of looking at this issue: the x/net/trace package is designed for observing a running server. It is not designed as a mechanism for permanent logging. That should be something separate, with its own considerations and trade-offs.
I think I've convinced myself that there isn't something useful to do here, so I'm going to close this feature request. I'm open to counter-arguments.

Perhaps I'm misremembering, but I thought the traces displayed on requestz were the same traces written to BINARY_TRACE logs and consumed by dapper for analysis. Maybe a String method is not the appropriate way to expose the trace data for external consumption. I'm pretty sure traces inside Google have an associated proto. I was initially thinking a String method would be simpler and more palatable, but I'd also be happy with a Proto method which serialized the trace to a protobuf.
I could have sworn that C++ traces (at Google) allowed outputting the trace to a string. My mind might be playing tricks on me. It's been years. I'm mildly surprised that you jumped to the conclusion so quickly that there is nothing useful to do here as right now the trace info seems entirely locked up within the x/net/trace package with no way to access other than through an http endpoint. Tying the trace data to the lifetime of a process severely limits its utility. For example, I can't easily run a nightly benchmark and collect traces for later analysis. (Yes, I can crawl the http endpoint at the end of the benchmark, but that is not what I would call easy).

No, requestz and the binary logs contained substantial overlap, but they're different code paths and have different purposes. It's also different across languages.
A Proto method to generate a proto might be okay, though that should be decided across languages too. There might be something suitable for gRPC traces, but note that x/net/trace isn't RPC-specific either.
I didn't jump to a quick conclusion. I've been thinking about this code for several years. I just revised my previous thinking on the matter. I don't think there's much in the way of trace-specific information in the trace; all its content comes from outside the package, so those places can simply record the information in a different place too.

Yes, all of the trace content comes from outside of the trace package, but x/net/trace is a synchronization point. Outputting the trace content to two (or more) systems seems wasteful and burdensome. Already grpc has to create a new context to store the trace in. If there is some other tracing mechanism for outputting to a log would grpc have to create another context (using context.WithValue) for that trace? And every grpc user would have to know to output their trace info to both places?
How do I (as a user of grpc and x/net/trace) get access to the trace content that grpc has stored in a trace? Punting the problem to grpc feels like a non-starter to me so I didn't even consider it. Do you think the Go grpc folks would be open to adding instrumentation points for gathering trace content?

Like I said, x/net/trace is not RPC-specific, so if you're after RPC-specific information then you're already looking at the wrong part of the puzzle.
grpc-go is indeed weighing up hooks for per-RPC monitoring and instrumentation. See grpc/grpc-go#240 or grpc/grpc-go#335.

I get that x/net/trace is not RPC-specific, and yet certain traces are RPC-specific as they are created by the RPC system. How do I get the information from RPC-specific traces with information potentially recorded outside of gRPC? Right now x/net/trace is both the recording and reporting mechanism.
I'll read the issues you pointed to in more detail tomorrow.

grpc/grpc-go#240 is asking for instrumentation hooks in gRPC for metrics monitoring. That's not what I'm after. grpc/grpc-go#335 is asking for something akin to BINARY_INFO logs. Again, not what I'm after.
I'm looking for something like BINARY_TRACE logs (though perhaps not binary). That is, output of RPC trace info and application-level annotations added to traces (created via LazyLog and LazyPrintf). A Trace.String method might not be the appropriate way to expose this data, but I think it deserves to be exposed. Along with whatever mechanism there is to serialize a trace, there would also need to be a hook or some mechanism to know when a trace is finished. Since I'm interested in traces finished by gRPC, that hook or mechanism potentially lives there, but I think the serialize of Traces has to live in x/net/trace.
Btw, in case it isn't clear, I'm willing to implement this if you give guidance on what you find palatable.

Even though x/net/trace was thought as a reporting mechanism, traces are indeed being generated by the implementation.
We are after binary logging as well so we can collect and analyze traces.
Our first naive approach was:
func() {
  tr := trace.New("Helper", "Call")
  // ...
  defer func() {
    tr.Finish()
    traces <- tr
  }()
}

// ...
go func() {
  for {
    tr := <-traces
    sample(tr) // samples and logs
  }
}

However this approach wouldn't work as all the interesting data is within the private trace struct.


Move Packit into Fedora infrastructure

Because we are not completely happy with the MP+ cluster, we would like to research the Fedora Openshift offerings since we can freely run in public and Fedora is our primary target.
These are the current issues with MP+:

internal network instability
every external hostname we want to interact with (i.e. when downloading package sources for our users) needs to be added to the firewall (this can pause the onboarding for a week which gives a bad impression).

Here's an example of how Situ does this for OpenScanHub: https://pagure.io/fedora-infra/ansible/pull-requests?author=svashisht&status=Merged&order_key=date_created&order=asc

What needs to be done in this epic:

[ ] collaborate with CPE team to know about the requirements from their side
[ ] research the required changes in the scripts/related code based on that
[ ] do the move


add proxy option

Thanks Pierre.

You're welcome, small contribution, but I won so much time using Dockefile to deploy an instance of Jobe 👍


fix sgx_urts  undefined reference to t_signal_handler_ecall error

Use signal feature to control compilation of sgx_urts::signal. #234

How can I use this with v1.1.2?

@assafmo, you can use it right now with the v1.1.2 tag. I believe @dingelish re-taged the v1.1.2 to the current master.
BTW, I think it's better to come up with a better tagging/versioning strategy. I'll bring up this issue later.

 Just tag it as v1.1.3 and say on the changelog that it's a bug fix.

@assafmo It is not just simple do a version bump. You have to bump all versions also for ported crates. Otherwise, you will see multiple std when using cargo. I have created a mono repo for SGX crates and have a details versioning instructions (https://github.com/universal-secure-computing-community/crates-sgx). Once this is ready, version bump for SDK will be very easy and there is minimal effort to update all ported SGX crates.


[WIP] Docker image Caching

Manage Docker image meta data by storing it in the mongo database. This allows for the rest endpoints to be generated upon startup quickly by not requiring docker container executions to get cli information for each image. This PR also provides a rest endpoint to add or remove docker images

@manthey @cdeepakroy @zachmullen
PTAL

Current coverage is 56.35% (diff: 82.58%)

Merging #172 into master will increase coverage by 20.02%

@@             master       #172   diff @@
==========================================
  Files            22         24     +2
  Lines          1437       1606   +169
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            522        905   +383
+ Misses          915        701   -214
  Partials          0          0

Powered by Codecov. Last update f91230f...48199e7

Some notes:
The slicer-xmlspec is not being checked for structural validity due to a problem in the schema for slicer cli modules, I will make an issue on the slicer_module issue once I confirm it is not my usage of lxml
The DockerImage schema allows additional properties to permit dictionaries containing the _id element from the mongo client.
Currently it is assumed that the cli names provided are safe to use as part of the restroute, will add a regex to only accept alpha numeric names only, or I can strip the cli name of bad characters and use the massaged cli name for the rest route

In general, I'd rather log exceptions and errors than just print them.  We can use girder's logging methods: either from girder import logger, or the brand new from girder import logprint if you want to also print to stdout.  Then, instead of print(foo), either use logger.error(foo) or logprint.error(foo), depending on what you chose.  Exceptions can get reported automatically: instead of code like:
   except Exception as e:
        print('Failed to create REST endpoints for %s: %s' % (cliRelPath, e))

you can use
    except Exception:
        logprint.exception('Failed to create REST endpoints for %s' % cliRelPath)

and the exception will be formatted and included in the log.
Logging has the virtual that we can poll the logs through the swagger interface rather than having to log in to the actual machine and find Girder's stdout.

@salamb Few comments. Rest LGTM!

To increase test coverage I can attempt to add an image that is not histomicstk related (docker hello world) just to verify graceful and informative termination of the girder job

@manthey Can we merge this?
Me and bilal are working on moving this functionality into girder/slicer_cli so other projects have access to it.

LGTM.  I'll add an issue to convert print statements to send information to logs.

Ok!


refactor printer-legacy

Description
Refactor module printer-legacy for easier maintenance.
Checklist

[x] My changes follow the contributing guidelines of this project.
[x] I have performed a self-review of my code.
[ ] I have made corresponding changes to the documentation.
[x] I have added tests that prove my fix is effective or that my changes work.
[x] New and existing unit tests pass locally with my changes.

Coverage: 89.384% (-1.3%) from 90.714% when pulling 64e9e388c5c7951e8bcd81d911cb3506666a306b on chore/refactor-printer-legacy into 924b0d7223e498574430392e5f909bb81f6aab94 on main.


docs: ambiguous service word

The wording did not give a hint whether we're talking about EmberJS services or Invoking Services section of the xstate guides

thanks!


Update Dockerfile source, because it wouldn't compile with the old SDL2 version

Wouldn't build the docker image otherwise. Say's the version is outdated.
[ 85%] Building C object CMakeFiles/FAudio.dir/src/FAudio_platform_sdl2.c.o
/root/faudio/FAudio/src/FAudio_platform_sdl2.c:34:2: error: #error "SDL version older than 2.24.0"
 #error "SDL version older than 2.24.0"
  ^~~~~
/root/faudio/FAudio/src/FAudio_platform_sdl2.c: In function 'FAudio_PlatformGetDeviceDetails':
/root/faudio/FAudio/src/FAudio_platform_sdl2.c:286:7: warning: implicit declaration of function 'SDL_GetDefaultAudioInfo' [-Wimplicit-function-declaration]
   if (SDL_GetDefaultAudioInfo(NULL, &spec, 0) < 0)
       ^~~~~~~~~~~~~~~~~~~~~~~
/root/faudio/FAudio/src/FAudio_platform_sdl2.c:293:3: warning: implicit declaration of function 'SDL_GetAudioDeviceSpec' [-Wimplicit-function-declaration]
   SDL_GetAudioDeviceSpec(index - 1, 0, &spec);
   ^~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [CMakeFiles/FAudio.dir/src/FAudio_platform_sdl2.c.o] Error 1
CMakeFiles/FAudio.dir/build.make:446: recipe for target 'CMakeFiles/FAudio.dir/src/FAudio_platform_sdl2.c.o' failed
CMakeFiles/Makefile2:67: recipe for target 'CMakeFiles/FAudio.dir/all' failed
make[1]: *** [CMakeFiles/FAudio.dir/all] Error 2
Makefile:127: recipe for target 'all' failed
make: *** [all] Error 2
The command '/bin/sh -c make' returned a non-zero code: 2

I also tried to:

update the codeweavers wine version to 22.0.1, but i didn't get the office products to intall that way.
mount the dir of the docker as you did, but it didn't work (My docker knowledge isn't that big). In the end i just copied it out with
sudo docker container cp [YourContainerId]:/mnt/build/cx-22.0.1 ./
The installation of the fonts worked, up until the fc-cache stuff. Something about a scanning error. Doing it with sudo worked but now my user doesn't have permission to use the fonts ^^.
I would like to help with a translation to bottles, as PlayOnLinux isn't the most user friendly tool out there.

Thanks! Regarding some of your other concerns:

I also never had much luck with newer winecx versions, even the currently used 21.2.0 still occasionally causes problems for me. I don't see much of a reason to use a newer version, unless it allows for newer Office versions to run (see https://github.com/DonutsBl/office365-pol/issues/18).
How fonts should be installed does vary depending on your distribution. You should be able to look up a guide for your distro, as the TTF files the documentation has you extract are just standard font files that work almost anywhere.
I would also like to move away from PlayOfLinux, mostly because it can't handle installing a non-standard Wine version, and there being extra steps in addition to running an installer script is just dumb. But I don't think Bottles has that capability either, its installer files look quite primitive at first glance. So the most likely solution is probably a Batch or Python script that completely handles the installation without requiring anything like POL or Bottles.

👍Thanks for the response. https://www.codeweavers.com/crossover/changelog mentions bugfixes for office 365 with newer versions, which is why I attempted to use it.
I have tried the word installation of crossover and this repo. In my very unsientific test of loading a large Word file and checking how long it takes for the spell checker to finish, moving images around and writing, this repo is noticeably faster. My best bet would be the compilation, but otherwise i am not sure where the performance gains stem from.
I know little about wine and bottles, but let me know if you need help with something. I can always take a look.


Implemented changes regarding #94

modified both templates regarding #94

Could you add some more text for the description? Is this PR linked to the story in the kanban board?

Is there additional effort required to directly identify and conditionally select frontend behavviour based on this user team?

Could you rebase this PR-branch onto the latest 'main' branch? That would be reasonable before I try to add something to this PR.

This story only requires a backend implementation, so this PR can be fast forwarded quite well and don't has to be rebased.
And I also don't want to delete the branches until I'm sure, that there is nothing missing in the main branch.
But I will add some more text to the readme if you want

There is a second ticket for the frontend part -> #132

There is a second ticket for the frontend part -> #132

Alles klar. Ich hätte zumindest schon eine Vorstellung, wie diese Story erfüllt wird.


fix(form-field): update peerDeps to the correct package name

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] The commit message follows our
guidelines: https://github.com/goetzrobin/spartan/blob/main/CONTRIBUTING.md#-commit-message-guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Which package are you modifying?

[ ] accordion
[ ] alert
[ ] alert-dialog
[ ] aspect-ratio
[ ] avatar
[ ] badge
[ ] button
[ ] calendar
[ ] card
[ ] checkbox
[ ] collapsible
[ ] combobox
[ ] command
[ ] context-menu
[ ] data-table
[ ] date-picker
[ ] dialog
[ ] dropdown-menu
[ ] hover-card
[ ] icon
[ ] input
[ ] label
[ ] menubar
[ ] navigation-menu
[ ] pagination
[ ] popover
[ ] progress
[ ] radio-group
[ ] scroll-area
[ ] select
[ ] separator
[ ] sheet
[ ] skeleton
[ ] slider
[ ] sonner
[ ] spinner
[ ] switch
[ ] table
[ ] tabs
[ ] textarea
[ ] toast
[ ] toggle
[ ] tooltip
[ ] typography

What is the current behavior?

Select has a peer dependencies to "@spartan-ng/ui-form-field-brain": "0.0.1-alpha.355", but the last version is 0.0.1-alpha.354. With 0.0.1-alpha.355 the package name changed to @spartan-ng/ui-formfield-brain
What is the new behavior?
Changing peer dependency name to @spartan-ng/ui-formfield-brain
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@goetzrobin I think we need a new version published of @spartan-ng/ui-select-brain to be able to use the fix


Clear cmdbufs and prior fences after processed in decrement.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

cherry-picked and pushed to master


Add Windows error message support to cd_mkdir rule

Add the Windows error message 'the system cannot find the path specified'
to the list of recognized messages for cd_mkdir.

I see I failed the build for Python 2.7, but not 3.x. I'm still new to Python so any help is greatly appreciated. Thanks!

It should be OK in python 2.7 too and the error seems TIMEOUT-related in some unrelated part of the code. Re-run the tests just in case (don't know if travis will let you, but a git commit --amend && git push -f should do it).

Thanks!


International sites need to be able to customize phone number format placeholder

Validation for the phone number field (such as on user login) currently validates any domestic or international number with any country code. The placeholder<PHONE_NUMBER> that we give to users, however, is not always country-appropriate.
We need a way for each site to use country-appropriate date placeholders, either through translation (which is what we're doing on the UK site through the "UK English" translations), based on the site region settings, or through the admin panel.
/cc @aaronschachter @sergii-tkachenko

@barryclark Can we close this?

Hells yea. Thanks for putting the string overrides in place!


HLS manifest version 7 is not playing in Shaka Player

Have you read the FAQ and checked for duplicate open issues?: yes
What version of Shaka Player are you using?: latest
Can you reproduce the issue with our latest release version?: yes
Can you reproduce the issue with the latest code from master?: yes
Are you using the demo app or your own custom app?: demo
If custom app, can you reproduce the issue using our demo app?: yes
What browser and OS are you using?: Chrome
What are the manifest and license server URIs?:
https://timesmmdod-mmd-cust.lldns.net/v1/gaana/mp4/26/1836026/21206608/stream.ismd/master.m3u8?stream=21206608_128;21206608_16

What did you do?
I played this manifest under custom asset
What did you expect to happen?
Mp3 file should render and play the song
What actually happened?
Getting the below error:
main.js:695 Player error shaka.util.Error {severity: 2, category: 4, code: 4023, data: Array(1), handled: false, …}category: 4code: 4023data: ["URI"]handled: falsemessage: "Shaka Error MANIFEST.HLS_REQUIRED_ATTRIBUTE_MISSING (URI)"severity: 2stack: "Error: Shaka Error MANIFEST.HLS_REQUIRED_ATTRIBUTE_MISSING (URI)↵    at new shaka.util.Error (https://shaka-player-demo.appspot.com/lib/util/error.js:89:13)↵    at Function.shaka.hls.HlsParser.getRequiredAttributeValue_ (https://shaka-player-demo.appspot.com/lib/hls/hls_parser.js:1781:11)↵    at shaka.hls.HlsParser.createStreamInfoFromMediaTag_ (https://shaka-player-demo.appspot.com/lib/hls/hls_parser.js:808:23)↵    at shaka.hls.HlsParser. (https://shaka-player-demo.appspot.com/lib/hls/hls_parser.js:545:17)↵    at Array.map ()↵    at shaka.hls.HlsParser.createVariantsForTag_ (https://shaka-player-demo.appspot.com/lib/hls/hls_parser.js:544:28)↵    at shaka.hls.HlsParser. (https://shaka-player-demo.appspot.com/lib/hls/hls_parser.js:452:19)↵    at Array.map ()↵    at shaka.hls.HlsParser. (https://shaka-player-demo.appspot.com/lib/hls/hls_parser.js:451:40)"proto: Object
shakaDemo.onError_ @ main.js:695
(anonymous) @ asset_section.js:370
Promise.then (async)
shakaDemo.load @ asset_section.js:339
Error Code : 4023

HLS_REQUIRED_ATTRIBUTE_MISSING
4023
number
One of the required attributes was not provided, so the HLS manifest is invalid. error.data[0] is the missing attribute's name.

Looks like we are treating uri attribute of the media tag as required, which is wrong unless the tag describes subtitles.
From the HLS spec:

The URI attribute of the EXT-X-MEDIA tag is REQUIRED if the media
type is SUBTITLES, but OPTIONAL if the media type is VIDEO or AUDIO.
If the media type is VIDEO or AUDIO, a missing URI attribute
indicates that the media data for this Rendition is included in the
Media Playlist of any EXT-X-STREAM-INF tag referencing this
EXT-X-MEDIA tag.  If the media TYPE is AUDIO and the URI attribute is
missing, clients MUST assume that the audio data for this Rendition
is present in every video Rendition specified by the EXT-X-STREAM-INF
tag.

@ismena - I have a fix for this, which branch label should I use in my pull request?
Thanks,
Rob

@rgc feel free to use master.

@ismena See: https://github.com/google/shaka-player/pull/1732
Thanks,
Rob


WAFv2 AndStatement and OrStatement incorrect validation

Hi guys,
https://github.com/cloudtools/troposphere/blob/f287fa8999ef2a5f5e301ba5c0af6421471e230b/troposphere/validators/wafv2.py#L32-L33
In the validator for WAFv2 statements, there is a check to see if the number of statements if exactly 2 when it should be looking to see if there are at least 2 statements given.

"You provide more than one Statement within the AndStatement."
Source

AWS requires there to be more than one statement, but does not restrict them to only pairs.
A small change in the logic of the if statement and the TypeError message is all that is needed.
Thank you

Apology for the regression. As you pointed out it is an easy fix. Can you verify this change fixes it for you?

And...really fixed this time with a force push. Teach me to multi-task.

Yep! That would do it.  Thank you!

I'll likely do a quick release this weekend with this, a few other PRs and any latest spec changes over the weekend. BTW, were you ok with the WAFv2 breaking changes done for 4.0.0? I hope it was an improvement.

Had to rework the pieces on our end around the creation of the resources, but definitely nice to have all of the features available now.
Not specific to WAFv2, but one thing that did strike me as odd was that resource objects can be successfully initialized without all of the required properties being given.  I thought I remembered it erroring out in situations like that, or am I missing something. ?
I thought with a property defined as
class SomeProperty(AWSProperty):
    props: PropsDictType = {
        "Prop1": (TYPE, True),
        "Prop2": (TYPE, False),
    }

if you tried to initialize without defining Prop1, it would throw some kind of exception.  It seems like you can initialize resource objects without including all of the required properties, or with none at all.
Was this always the case, or did something change?  If not, could that potentially be a feature request?
Thank you man

Fixed in Release 4.0.1


annoying crash

Describe your bug here. Mind you, if you are modding, please try testing your bug in a clean version of the engine instead, this ensures the bug is actually caused by the engine itself. Also, if you're using an older version of JSE, please try the latest action build in the Actions tab or the latest release build. The issue has probably been fixed since that version. Oh yeah, and also be sure to check the pinned 'JS Engine: Known Issues' issue, to double check if your issue hasn't already been found!
PlayState.hx (Line 5324)
PlayState.hx (Line 6229)
PlayState.hx (Line 5772)
openfl/events/EventDispatcher.hx (Line 426)
openfl/display/DisplayObject.hx (Line 1398)
Uncaught Error: Null Object Reference
Please report this error to the GitHub page: https://github.com/JordanSantiagoYT/FNF-PsychEngine-NoBotplayLag

Crash Handler written by: sqirra-rng
The engine has saved a crash log inside the crash folder, If you're making a GitHub issue you might want to send that!

Command Prompt/Terminal/Crash logs (if existing)
No response
Have you identified any steps to reproduce the bug? If so, please describe them below in as much detail as possible. Use images if possible.
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
No
If you use 1.12.0 or earlier, did you have Optimized Chart Loading turned on?
No
Did you check for any similar issues to what you're reporting? Check, then come back here. If there is a similar issue, then do not report the issue, otherwise it will be marked as a duplicate.
Yes

erm, try the current action builds cause the issue's already been fixed

erm, try the current action builds cause the issue's already been fixed

what he said

erm, try the current action builds cause the issue's already been fixed

how i do dat

erm, try the current action builds cause the issue's already been fixed

how i do dat

https://github.com/JordanSantiagoYT/FNF-PsychEngine-NoBotplayLag/actions

erm, try the current action builds cause the issue's already been fixed

how i do dat

https://github.com/JordanSantiagoYT/FNF-PsychEngine-NoBotplayLag/actions

all i see is a bunch of code what do i do with it

erm, try the current action builds cause the issue's already been fixed

how i do dat

https://github.com/JordanSantiagoYT/FNF-PsychEngine-NoBotplayLag/actions

all i see is a bunch of code what do i do with it

you just click on the latest action and scroll down to artifacts


[Language Text] Dynamic Classification output doesn't match swagger

The property should be named class instead of classifications.

Once this issue is addressed, https://github.com/Azure/azure-sdk-for-js/issues/23617 should be addressed too.

The swagger has been updated.


Add method to unmarshal certificates with a limit

This removes a DOS vector for services that use this method. Otherwise,
a client can provide a large PEM block to cause the service to do a
significant amount of work.
Signed-off-by: Hayden Blauzvern<EMAIL_ADDRESS>
Summary

Ticket Link

Fixes
Release Note

Added method to unmarshal certificates from a PEM block with a limit

cc @dlorenc @bobcallaway


Add native registry login e2e test for EKS

It introduces a new package tftestenv. It is similar to testenv but uses
terraform to create test environment. It provides helpers to run terraform
apply and destroy in the test context.
tftestenv is used to create tests similar to the controller tests but with
EKS cluster provisioned using terraform. The test setup is written
similar to the usual controller test suite_test.go, providing
flexibility in the test setup and execution. The structure tries to keep
the infrastructure code separate from the test code such that the
infrastructure provisioning tool can be easily replaced, without the
need to change the actual tests.
The go tests are also written similar to the usual controller tests,
with a kube client from the tftestenv environment global variable.
Terraform is automatically downloaded using the terraform-exec package.
The test container images are generated using the go-containerregistry
package and pushed to the test ECR repository.
tests/aws/README.md contains more details about the test setup and workflow.
The terraform configurations for EKS is based on https://github.com/terraform-aws-modules/terraform-aws-eks/tree/6bb73bbdd469797cb067e9aa22ce2f31a7fb22be/examples/self_managed_node_group .
It takes about 25-30 minutes for the whole provisioning, testing and cleanup to finish.

Closing for #275 .


⚠ Bofrost.de has degraded performance

In c1e5523, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 2025 ms

Resolved: Bofrost.de performance has improved in 6e6b29e after 24 minutes.


Attack container shell enhancements

run ssh-keyscan on attack nodes to avoid prompting user for key identification
modify prompt to include status code of last command
do not require an argument if only one target to choose from in attack_master/node
add bash-completion and man pages to attack container
add .inputrc and bash_aliases from simulator container
enable bash completion
add docs for testing

Tested via the mechanism described in contributing.md, taken from the PR content in #43
This has been tested using the exact instructions in contributing.md, e.g. CONTAINER_TAG=super-cool-feature make docker-push and simulator infra create --attack-container-tag=super-cool-feature

Andy,
Can you look at the contributing section at the end of the current README.  Probably better to have this in a standalone file anyway, as this is too hidden within the README, and would follow GitHub's recommendations.  Was gonna do this next week, but as you are ahead :)
You'd either need to modify the generate-docs-from-templates.sh script, or just make it a static file, which I'd recommend tbh - see my comment on issue 51
Cheers,
Jon

@jondkent I didn't really want to get into fixing #51 in this PR, but I have moved the contributing sections into contibuting.md and edited README.md.
There's a warning about doing this at the top of README.md so I'm a bit nervous -- will I break workflows with this approach? Change made in https://github.com/kubernetes-simulator/simulator/pull/57/commits/0fde580e0b9556ecf592f887ee245f53b96cf761 and I'll roll it back if it's breaking.

Yup I think we can deal with #51 ourselves next week.  @pi-unnerup is creating documentation for contributing scenarios and we have a protocol meeting so we can make sure we're all aligned and agree on the contributing guidelines then

I think this looks good to merge.  I'm just going to clone and test it first now

I just spotted we don't continuously run the attack container tests  can we add a step in the root Makefile to cd into the attack folder and run make docker-test there please?

Addressed in https://github.com/kubernetes-simulator/simulator/pull/57/commits/cd40ae6c8a2fe687e45cd480c049e4ee0f60f941

@sublimino don't worry, wasn't expecting you to fix anything, more thinking about what did exists already in README, issue 51 pointed out for static contrib potentials
Jon


Support streaming LLM Generation

Hi,
the Error is thrown in line 61 litellm.py:

results.append(result["choices"][0]["message"]["content"])
'CustomStreamWrapper' object is not subscriptable

Call is
from txtai.pipeline import LLM
MODEL_NAME = "huggingface/TheBloke/leo-hessianai-70B-chat-GPTQ"
llm = LLM(path=MODEL_NAME,method="litellm", api_base=api_base,stream=True)

This works fine:
import litellm
from litellm import completion
MODEL_NAME = "huggingface/TheBloke/leo-hessianai-70B-chat-GPTQ"
messages = [{"content": "C", "role": "user"}] # LiteLLM follows the OpenAI format
api_base = "http://<IP_ADDRESS>:8080"
CALLING ENDPOINT
response=completion(model=MODEL_NAME, messages=messages, api_base=api_base,stream=True)
for part in response:
print(part.choices[0].delta.content or "")

Thank you for the issue. I'll see if streaming support can be added in.

It's been a while on this but streaming will be added shortly.


Abort faults are not accurate due to the default retry policy

By default Istio sets a 2 retries policy. This interferes with the settings in fault.abort.
If user sets a fault rate of, say 50%, in practice it has no effect because the retry setting will request the service again.
Some solutions:

Document this behavior
Remove this automatic retry policy
Or have it automatically applied only if there's no abort fault set.

what does"automatic retry policy" mean?

what does"automatic retry policy" mean?

I guess @jwendell refers to the default retry behavior for HTTP requests is to retry twice before returning the error.
I only experienced this behavior when traffic flows through multiple services. For example: we have service serviceA and serviceB. ServiceA acts as an api gateway that calls serviceB. In case of error in serviceB, serviceA propagates the error, which means that aborted requests in serviceB will also be aborted by serviceA.
Then, we tell serviceB to abort 50% of requests. If we make requests directly to serviceB, the percentage of aborted requests will be ~50%. So far so good.
Now, we send traffic to serviceA. Every aborted request in serviceB will make serviceA to also abort the request. However, in this case, we won't see a ~50% of aborts, but a much lower percentage. This is because serviceA retries each request twice by default. So I wonder... is this the intended behavior?

@jwendell that is interesting since we cannot actually define retry and abort in the same VS: https://github.com/istio/istio/issues/13705. is the default retry policy different in some way?


Feature request: preselect the alternative buffer

Some details in #4
Maybe add an option for that.

I just added the feature. Please check that it works correctly. Once you confirm that everything works as expected, I will close the issue.


Fix test_quantization to unblock CD

This PR fixes 2 quantization gpu tests: test_quantize_model and test_quantize_sym_with_calib. Those tests was not marked as xfail in the locale fix in #18097
Tested in a EC2 and it should unblock CD as CD pipeline fails on those 2 tests
This PR is not integrating test_quantization into Centos CI pipeline, and we should work on it in another PR

@mxnet-bot run ci [unix-cpu]


Can't access RPi PWM0, without overwriting PWM1

Hello,
I know there are already issues that come close to this issue. Still, I'd like to start a new discussion, to figure this problem out together.
My issue is that, when I use this library with PWM channel 0, it seems to screw over PWM channel 1. (on a Raspberry Pi Compute Module 4 (8GB eMMC, 4GB RAM, No Wifi)).
I am using the rpi-ws281x-python lib to control PWM channel 0, and using rpi-hardware-pwm 0.1.4 to control PWM channel 1.
The rpi-hardware-pwm 0.1.4 lib, reads and writes to the PWM buffers directly. (So in my case, in /sys/class/pwm/pwmchip0/pwm1)
This seems to work perfectly, if I run my test application before starting rpi-ws281x-python application. My oscilloscope shows me the expected PWM signal. After I start the rpi-ws281x-python application, the PWM signal on channel one, starts oscillating between 0 and 3.3v very rapidly.
So my guess is, that the rpi-ws281x-python library seems to always initialize BOTH PWM channels. I looked at the source code, and yeah. There is quite a lot of code that mentions PWM channel 1, even when only PWM channel 0 is selected. So I decided to change the library, and remove all mentions off PWM 1. I also added in a couple of printf() calls, to check if channel 1 is never called.
I am no hero in C, so it could be that I am missing some references here. After removing all references to channel 1, the library still seems to work on channel 0 as expected. But it still messes with channel 1. My next theory is that I am missing some other assignments, so that channel 1 is still overriden in some way. Maybe a DMA call that reserves memory for channel 1, or something alike?
If someone finds a clue to solve this problem, I would be glad to test it out.
I have uploaded my source files and binaries here (I mostly edited ws2811.c, ws2811.h, pwm.c, pwm.h and  rpi_ws281x/rpi_ws281x.py):
rpi-ws281x-python_NeusAapBuild_v6.zip
Any help would be greatly appreciated, since I can't think of any other fixes to try :)
Thanks in advance!
Mats de Waard
P.S, If anybody knows a library that can control PWM1 in combination with rpi-ws281x-python being in control of PWM 0, that would also be a great solution. I am a bit too deep into my application to find a replacement for rpi-ws281x-python. But I would survive if I'd have to change out the rpi-hardware-pwm 0.1.4 lib. I've seen the RPi.GPIO lib being mentioned as a 'workaround', but this lib uses software PWM. My use case requires a cleaner, more precise hardware PWM signal.

Issues with the underlying rpi_ws281x (https://github.com/jgarff/rpi_ws281x/) are outside the scope of this wrapper library and cannot be fixed here.


Clear UI for DM to take player role

Is your feature request related to a problem? Please describe.
If a DM wants to be a player of their own run, they have to send themselves an invitation to play and accept it.
Describe the solution you'd like
With the new permissions system, DM will only need to tick a box for the "Player" role in the run settings modal (which pops up just after run creation).

Describe alternatives you've considered

Making the DM a player by default
In the pop-up to write the run title, add a mandatory selector to choose whether DM will also be a player or not

Fixed in v1.0


Telerik Dock Tab Reorder on Retina Display

On Apple's Retina display, there is a known issue with the dock tabs.  The bug is that if you click, hold, and even drag the mouse a tiny bit, the tab will undock and center.
The desired behavior is to allow for lateral movement that reorders tab without undocking them.  According to the vendor, this is an issue for any monitor with "more than 100% DPI".  In practice, I've found the Apple Retina display the main culprit.  The control does work as expected on most other monitors.

http://feedback.telerik.com/Project/143/Feedback/Details/125861-moving-a-toolwindow-when-the-dpi-of-the-os-is-higher-then-100-causes-incorrect-o
http://www.telerik.com/account/support-tickets/view-ticket.aspx?threadid=895746

Telerik apparently fixed this issue, tabs reorder correctly on retina following the upgrade to 2015.2.623.45 assemblies.


[DO NOT MERGE][WIP] Add new Save page box

T B C

thank you @AlanGabbianelli I've made some changes:

renamed the placeholders to contain the word "placeholder" to make it clearer as you suggested
moved the placeholders and some of the conditional logic to a helper to declutter the partial a bit (not 💯 sure I did it right though)

Will be adding some description text for this PR too, before I un-draft it.


BREAKING CHANGE: xSQLServerDatabasePermissions: Rename resource

Details of the scenario you try and problem that is occurring:
This resource has the wrong name compared to the other resources. This resource uses plural in it's name and the other resources are using singular in their name.
I suggest we rename this resource to 'xSQLServerDatabasePermission'.
The DSC configuration that is using the resource (as detailed as possible):
n/a
Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a
Version of the DSC module you're using, or 'dev' if you're using current dev branch:
'dev'

I can add this issue in PR #140.
Just tell me 😃

Yes you you wouldn't mind, since your change in PR #140 already is a breaking change this change would be suitable there as well.
This is yours @luigilink 😄


Color fonts getting different appearance in Firefox and Chrome

I have a color font with two layers, each layer having a gradient. Chrome and Firefox used to give expected result, but recently noticed that Chrome applies the same gradient to both layers. The issue is illustrated below:
Font file:
https://smc.gitlab.io/fonts/Nupuram/fonts/Nupuram-Color/ttf-color/Nupuram-Color.colrv1.ttf
Firefox version 108(Correct rendering):

Chrome version 108(Broken rendering)

Both can be tested by using https://smc.gitlab.io/fonts/Nupuram/tests/, select Nupuram Color from drop down
The code that use fontTools.colorLib builder  is at https://github.com/santhoshtr/nupuram/blob/master/tools/build_color_v1.py
I would like to know if this is a chrome bug or my incorrect usage of colorlib builder?

I just tried blackrenderer and it is giving output same as Firefox(ie, correct rendering).

HarfBuzz gets the right rendering also, except that it's clipped, perhaps because the font has wrong clipbox.

cc @drott

the font has no clipboxes at all, so we just get the extents of T, ignoring T.shadow

I can confirm that adding a dummy clipbox like this resolves the issue for Chrome:
-font["COLR"] = builder.buildCOLR(colrv1_map)
+font["COLR"] = builder.buildCOLR(colrv1_map,  clipBoxes={
+                "a": (0, -500, 1024, 1024)
+            },)

But this is a dummy clipbox just for a single glyph. If that can change the whole behavior of chrome, I suspect it is an implementation issue in Chrome? From the documentation, I see clipbox is optional.

https://smc.gitlab.io/fonts/Nupuram/fonts/Nupuram-Color/ttf-color/Nupuram-Color.colrv1.ttf

Using the font from this URL, not reproducible in Chrome 108.0.5359.125 (Official Build) (64-bit) (cohort: Stable)
and test content:

സംഘർഷം

Is this the font with the ClipBoxes added? If yes, and the issue persists when the ClipBox is removed, please file an issue at crbug.com and attach the font and ideally html test content with which you see the undesired behavior.

@drott , I had added clibpoxes to latest version. I will file a bug with the previous version that has the issue

Closing this ticket as it is tracked in Chromium

I'd like to leave this open to see if we can find some workaround to this Chrome bug.
In that bug, @drott wrote

The reason seems to ben an incorrect bounds check at the end of the font file where the ColorLine objects are stored. If ClipBoxes are used, they may be placed after the ColorLines in the font file - which avoids things getting blocked by the bounds check.

Maybe fontTools.colorLib.builder could add an empty ClipList at the end of the COLR table with the numClips count set to 0, even when no clipBoxes are provided in the input data. But I need to check if this actually works around this or not.

Does a short-lived bug like this one worth the trouble?

Does a short-lived bug like this one worth the trouble?

Good question - maybe we shouldn't cast this bug into an implemented workaround elsewhere.

Adding an empty ClipList doesn't fix this

Using for example the otexplorer binary, did you check what's exactly at the end of the COLR table? The bug is in reading the ColorLine while at the same time checking that the reading cursor does not cross the end of the table. But the error in calculating that might have been the size of one (Var)ColorStop - 1. That would be in line with your observation, that there has to be something a bit larger there, like a dummy ClipBox. But yes, up to y'all on whether that's worth implementing a work around. Another workaround could be not place ColorLines at the end but something else, if there is anything else that can be placed variably.

all COLRv1 fonts generated with fontmake (that use glyphsLib to convert Glyphs.app's specific color gradient definitions to fontTools-compatible paint definitions) will display this bug, because glyphsLib currently does not compute clipboxes and leaves them omitted. Blaka Ink is one of them, for example: https://fonts.google.com/specimen/Blaka+Ink
I am leaning towards just changing glyphsLib to always compute the ClipBoxes, like nanoemoji does..


Masculine and feminine usage

I noticed that some of the words use masculine and others use feminine. It might be some work but, you would probably want to have both masculine or feminine where applicable to ensure no compiler errors occur.

Do you have any examples?