My game stops loading and crashed at building terrain

I only have a few mods installed, but as soon as I get endercore 1.12.2-0.5.22 and enderio 1.12.2-5.0.24, I run into a problem in which my game freezes after building terrain and the game has to close before I can enter a world. Here are some crash reports, I'm not sure if they help. Is me using forge+optifine+enderio  to blame? Because forge+optifine work for applied energistics
---- Minecraft Crash Report ----
WARNING: coremods are present:
EnderCorePlugin (EnderCore-1.12.2-0.5.22.jar)
Contact their authors BEFORE contacting forge
// I feel sad now :(
Time: 5/25/18 8:49 PM
Description: Exception ticking world
java.lang.OutOfMemoryError: Java heap space
at net.minecraft.network.play.server.SPacketChunkData.(SourceFile:39)
at net.minecraft.server.management.PlayerChunkMapEntry.func_187272_b(PlayerChunkMapEntry.java:157)
at net.minecraft.server.management.PlayerChunkMap.func_72693_b(PlayerChunkMap.java:255)
at net.minecraft.world.WorldServer.func_72835_b(WorldServer.java:227)
at WorldServerOF.func_72835_b(WorldServerOF.java:37)
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:756)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:668)
at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:252)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:526)
at java.lang.Thread.run(Thread.java:745)
A detailed walkthrough of the error, its code path and all known details is as follows:
-- Head --
Thread: Server thread
Stacktrace:
at net.minecraft.network.play.server.SPacketChunkData.(SourceFile:39)
at net.minecraft.server.management.PlayerChunkMapEntry.func_187272_b(PlayerChunkMapEntry.java:157)
at net.minecraft.server.management.PlayerChunkMap.func_72693_b(PlayerChunkMap.java:255)
at net.minecraft.world.WorldServer.func_72835_b(WorldServer.java:227)
at WorldServerOF.func_72835_b(WorldServerOF.java:37)
-- Affected level --
Details:
Level name: nam jac
All players: 1 total; [EntityPlayerMP['justmyname122'/312, l='nam jac', x=-223.86, y=67.00, z=166.20]]
Chunk stats: ServerChunkCache: 743 Drop: 0
Level seed:<PHONE_NUMBER>166569860
Level generator: ID 00 - default, ver 1. Features enabled: true
Level generator options:
Level spawn location: World: (-249,64,230), Chunk: (at 7,4,6 in -16,14; contains blocks -256,0,224 to -241,255,239), Region: (-1,0; contains chunks -32,0 to -1,31, blocks -512,0,0 to -1,255,511)
Level time: 1319421 game time, 463306 day time
Level dimension: 0
Level storage version: 0x04ABD - Anvil
Level weather: Rain time: 133860 (now: false), thunder time: 53467 (now: false)
Level game mode: Game mode: survival (ID 0). Hardcore: false. Cheats: true
Stacktrace:
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:756)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:668)
at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:252)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:526)
at java.lang.Thread.run(Thread.java:745)
-- System Details --
Details:
Minecraft Version: 1.12.2
Operating System: Windows 10 (amd64) version 10.0
Java Version: 1.8.0_25, Oracle Corporation
Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
Memory: 32066944 bytes (30 MB) /<PHONE_NUMBER> bytes (1024 MB) up to<PHONE_NUMBER> bytes (1024 MB)
JVM Flags: 8 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xmx1G -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=16M
IntCache: cache: 0, tcache: 0, allocated: 12, tallocated: 94
FML: MCP 9.42 Powered by Forge <IP_ADDRESS>98 Optifine OptiFine_1.12.2_HD_U_D3 18 mods loaded, 18 mods active
States: 'U' = Unloaded 'L' = Loaded 'C' = Constructed 'H' = Pre-initialized 'I' = Initialized 'J' = Post-initialized 'A' = Available 'D' = Disabled 'E' = Errored
| State     | ID                         | Version                | Source                                | Signature                                |
|:--------- |:-------------------------- |:---------------------- |:------------------------------------- |:---------------------------------------- |
| UCHIJAAAA | minecraft                  | 1.12.2                 | minecraft.jar                         | None                                     |
| UCHIJAAAA | mcp                        | 9.42                   | minecraft.jar                         | None                                     |
| UCHIJAAAA | FML                        | <IP_ADDRESS>              | forge-1.12.2-<IP_ADDRESS>98.jar         | e3c3d50c7c986df74c645c0ac54639741c90a557 |
| UCHIJAAAA | forge                      | <IP_ADDRESS>98           | forge-1.12.2-<IP_ADDRESS>98.jar         | e3c3d50c7c986df74c645c0ac54639741c90a557 |
| UCHIJAAAA | appliedenergistics2        | rv5-stable-11          | appliedenergistics2-rv5-stable-11.jar | None                                     |
| UCHIJAAAA | endercore                  | 1.12.2-0.5.22          | EnderCore-1.12.2-0.5.22.jar           | None                                     |
| UCHIJAAAA | jei                        | <IP_ADDRESS>              | jei_1.12.2-<IP_ADDRESS>.jar              | None                                     |
| UCHIJAAAA | enderio                    | 5.0.24                 | EnderIO-1.12.2-5.0.24.jar             | None                                     |
| UCHIJAAAA | enderiointegrationtic      | 5.0.24                 | EnderIO-1.12.2-5.0.24.jar             | None                                     |
| UCHIJAAAA | enderiobase                | 5.0.24                 | EnderIO-1.12.2-5.0.24.jar             | None                                     |
| UCHIJAAAA | enderioconduits            | 5.0.24                 | EnderIO-1.12.2-5.0.24.jar             | None                                     |
| UCHIJAAAA | enderiointegrationforestry | 5.0.24                 | EnderIO-1.12.2-5.0.24.jar             | None                                     |
| UCHIJAAAA | mantle                     | 1.12-<IP_ADDRESS>          | Mantle-1.12-<IP_ADDRESS>.jar              | None                                     |
| UCHIJAAAA | tconstruct                 | 1.12.2-<IP_ADDRESS>        | TConstruct-1.12.jar                   | None                                     |
| UCHIJAAAA | enderiointegrationticlate  | 5.0.24                 | EnderIO-1.12.2-5.0.24.jar             | None                                     |
| UCHIJAAAA | enderiomachines            | 5.0.24                 | EnderIO-1.12.2-5.0.24.jar             | None                                     |
| UCHIJAAAA | enderiopowertools          | 5.0.24                 | EnderIO-1.12.2-5.0.24.jar             | None                                     |
| UCHIJAAAA | tinkertoolleveling         | 1.12-1.0.4.DEV.5d716b9 | TinkerToolLeveling-1.12-1.0.4.jar     | None                                     |

Loaded coremods (and transformers):

EnderCorePlugin (EnderCore-1.12.2-0.5.22.jar)
com.enderio.core.common.transform.EnderCoreTransformer
GL info: ERROR RuntimeException: No OpenGL context found in the current thread.
AE2 Version: stable rv5-stable-11 for Forge <IP_ADDRESS>4
Pulsar/tconstruct loaded Pulses:
- TinkerCommons (Enabled/Forced)
- TinkerWorld (Enabled/Not Forced)
- TinkerTools (Enabled/Not Forced)
- TinkerHarvestTools (Enabled/Forced)
- TinkerMeleeWeapons (Enabled/Forced)
- TinkerRangedWeapons (Enabled/Forced)
- TinkerModifiers (Enabled/Forced)
- TinkerSmeltery (Enabled/Not Forced)
- TinkerGadgets (Enabled/Not Forced)
- TinkerOredict (Enabled/Forced)
- TinkerIntegration (Enabled/Forced)
- TinkerFluids (Enabled/Forced)
- TinkerMaterials (Enabled/Forced)
- TinkerModelRegister (Enabled/Forced)
Ender IO: Found the following problem(s) with your installation (That does NOT mean that Ender IO caused the crash or was involved in it in any way. We add this information to help finding common problems, not as an invitation to post any crash you encounter to Ender IO's issue tracker. Always check the stack trace above to see which mod is most likely failing.):
              * Optifine is installed. This is NOT supported.
             This may (look up the meaning of 'may' in the dictionary if you're not sure what it means) have caused the error. Try reproducing the crash WITHOUT this/these mod(s) before reporting it.

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!!!You are looking at the diagnostics information, not at the crash.       !!!
!!!Scroll up until you see the line with '---- Minecraft Crash Report ----'!!!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

AE2 Integration: IC2:OFF, RC:OFF, MFR:OFF, Waila:OFF, InvTweaks:OFF, JEI:ON, Mekanism:OFF, OpenComputers:OFF, THE_ONE_PROBE:OFF, TESLA:OFF, CRAFTTWEAKER:OFF
Profiler Position: N/A (disabled)
Player Count: 1 / 8; [EntityPlayerMP['justmyname122'/312, l='nam jac', x=-223.86, y=67.00, z=166.20]]
Type: Integrated Server (map_client.txt)
Is Modded: Definitely; Client brand changed to 'fml,forge'
OptiFine Version: OptiFine_1.12.2_HD_U_D3
OptiFine Build: 20180515-125031
Render Distance Chunks: 15
Mipmaps: 4
Anisotropic Filtering: 1
Antialiasing: 0
Multitexture: false
Shaders: KUDA-Shaders v6.1 Legacy
OpenGlVersion: 4.6.0 NVIDIA 388.13
OpenGlRenderer: GeForce GTX TITAN/PCIe/SSE2
OpenGlVendor: NVIDIA Corporation
CpuCount: 8

You have run out of memory on your computer. You need to either assign more RAM or buy more memory if you don't have enough. This is not Ender IO's fault

What launcher are you using? You need to put -Xmx 4G -Xms 4G into the jvm arguments. A simple google search can explain it further.

Closing this since it isn't Enderio's fault


Move testing back to Ray 1.4.0 using conda-forge

Ray 1.4.0 is now available in conda-forge, so we should switch testing back to that channel from pip for consistency.

@vnlitvinov can we do it now?


Go Version 1.23 Compatibility Issue

Encountered a build error indicating that certain packages require a newer Go version than the one currently being used. The project is designed to work with Go version 1.22 but fails when using Go version 1.23. Below are the generalized error messages:
smrcptr: internal error: error "package requires newer Go version go1.23" (*errors.errorString) without position
auth.pb.go:7:1: package requires newer Go version go1.23
-: This application uses version go1.22 of the source-processing packages but runs version go1.23 of 'go list'. It may fail to process source files that rely on newer language features. If so, rebuild the application using a newer version of Go.

Steps to Reproduce:
Attempt to build the project using Go version 1.23.
Expected Behavior:
The project should compile successfully with Go version 1.22.
Actual Behavior:
Compilation fails with Go version 1.23 due to version incompatibility.
Proposed Solution:
Ensure that all packages and dependencies are compatible with Go version 1.22, and investigate any specific features or dependencies that require Go version 1.23.
Environment:
Go version: 1.22 (working), 1.23 (not working)

generally, there is no compatibility guarantee for this tool. use at own risk.
however, if someone can look into fixing this (or I will do sometime later), then great!
what it looks from error message, the CLI tool smrcptr is using go 1.22 but source code is using 1.23
we might need to bump this tool to 1.23

Ensure that all packages and dependencies are compatible with Go version 1.22,

the only dependency here is. golang.org/x/tools

Compilation fails

compilation of this tool or target source code you are analysing?
I can compile.
$ go version
go version go1.23.0 darwin/arm64
$ go build .
$ ./smrcptr -h
smrcptr: detect mixing pointer and value method receivers for the same type

Usage: smrcptr [-flag] [package]

Flags:
  -V    print version and exit
  -all
...

I tried, it still works for me. can you submit any open-source example that will fail?


[SPARK-46940][CORE] Remove unused updateSparkConfigFromProperties and isAbsoluteURI in o.a.s.u.Utils

What changes were proposed in this pull request?
The pr aims to remove unused updateSparkConfigFromProperties and isAbsoluteURI in o.a.s.u.Utils.
Why are the changes needed?
Keep the code cleanly.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.
Was this patch authored or co-authored using generative AI tooling?
No.

Merged to master for Apache Spark 4.0.0. Thank you, @panbingkun .


Simple baseline sampler for foreground patches

closes https://github.com/kaiko-ai/eva/issues/393

Looks great! Maybe @ioangatop could have a last look before we merge?

sorry saw this only after merging. But feel free to comment in this pr and i'll open a new issue

Looks great! Maybe @ioangatop could have a last look before we merge?
sorry saw this only after merging. But feel free to comment in this pr and i'll open a new issue

no problem, yes lets do that


ci: lint often fails due to timeout being exceeded

CI often fails due to lint timeout exceeded, like here: https://github.com/celestiaorg/celestia-node/pull/52/checks?check_run_id=3554301525#step:3:73
We already merged a pr (#49) to increase the timeout by 1 minute, but that didn't fix it.

In optimint I set limit to 5min, and it works most of the time ;)

Will close this once I see lint stops failing due to timeout. PR #54 attempts to resolve this.

Closing as this issue seems resolved on master


Error if 'files' property is not an array

I wrote this
{
	"files": "tests.ts",
	"compilerOptions": {
		"module": "commonjs",
		"noImplicitAny": true
	}
}

and spent a long time trying to figure out what went wrong

:+1:

:+1:

:+1:

The error text is confusing. Files is not a compiler option.

I guess I think of the whole thing as compiler options (I don't even understand why we put 'files' in a different nesting level from everything else). Would be happy to take a PR with a better error message.


Width on desktop 750px for Accordion Title

Can I take this issue?
Also, how do I get these active / Pending accordions?
When I run the dev build it shows nothing.

On changing the maximum width to 750px it will look like this :

Is this ok?


[RFC] Dockerfiles: Use busybox:glibc as base image for default image.

In general, I am fine with switching to busybox if it works.
It removes socat from the image (apt-get install -y util-linux socat line 49), so this PR needs to be on hold until we have an alternative solution to socat.
Current error:

time="2023-09-25T09:21:11Z" level=warning msg="connecting to gadget service on node "minikube-containerd-m02": Internal error occurred: error executing command in container: failed to exec in container: failed to start exec "1258a9ac460cc719019e70954fcfd4968008c378b325706f9154594cd659dd3e": OCI runtime exec failed: exec failed: unable to start container process: exec: "/usr/bin/socat": stat /usr/bin/socat: no such file or directory: unknown"


ceph-validate: avoid "list index out of range" error

Be sure that error.path has more than one members before using them.
Signed-off-by: Rishabh Dave<EMAIL_ADDRESS>

Fixes the following error -
 [ERROR]: [ceph-osd0] Validation failed for variable: bluestore_wal_devices

The full traceback is:
Traceback (most recent call last):
  File "/home/rishabh/.local/lib/python2.7/site-packages/ansible/executor/task_executor.py", line 139, in run
    res = self._execute()
  File "/home/rishabh/.local/lib/python2.7/site-packages/ansible/executor/task_executor.py", line 598, in _execute
    result = self._handler.run(task_vars=variables)
  File "/home/rishabh/repos/ceph-ansible/plugins/actions/validate.py", line 99, in run
    given = "[{}] Given value for {}: {}".format(host, error.path[0], error.path[1])
IndexError: list index out of range

fatal: [ceph-osd0]: FAILED! => {}

MSG:

Unexpected failure during module execution.

 [ERROR]: [ceph-osd1] Validation failed for variable: bluestore_wal_devices

The full traceback is:
Traceback (most recent call last):
  File "/home/rishabh/.local/lib/python2.7/site-packages/ansible/executor/task_executor.py", line 139, in run
    res = self._execute()
  File "/home/rishabh/.local/lib/python2.7/site-packages/ansible/executor/task_executor.py", line 598, in _execute
    result = self._handler.run(task_vars=variables)
  File "/home/rishabh/repos/ceph-ansible/plugins/actions/validate.py", line 99, in run
    given = "[{}] Given value for {}: {}".format(host, error.path[0], error.path[1])
IndexError: list index out of range

fatal: [ceph-osd1]: FAILED! => {}

MSG:

Unexpected failure during module execution.

@guits @leseb can you please review this PR?

@andrewschoen ?

jenkins test pipeline


can't clone due to dependencies on non-public eigen repository

When trying to do:
git clone --recursive https://github.com/AndreiBarsan/DynSLAM
It fails to download because the eigen submodule on github is either private or no longer exists:
fatal: Authentication failed for 'https://github.com/RLovelett/eigen/'
Is there something special about this eigen repository? Can we just replace it with any eigen mirror on github?

No. I don't think there's anything special about that mirror. No idea why it's there..
I'll update the repo, but in the meantime could you try, e.g.: https://github.com/eigenteam/eigen-git-mirror/releases/tag/3.3.7 ?

Seems like this was due to someone making their repo private. I fixed the dependency to a public mirror!


count() value is correct, but get() returns less or no items in the collection

The $model->search('dummy')....->count() returns a count which matches with what is returned as hits in Kibana. But when I replace 'count' by 'get' the Collection items is empty.
(more info - searchRules and Filter is being used too)

Please provide more information so we can try to reproduce it here.
The ... part of your code IS relevant.

Filter is
$r = $model::search('dummy')->whereIn('district', request('d'));
SearchRule is
return [             'should' => [                 [                     'match_phrase_prefix' => [                         'surname' => [                             'query' =>  request('ln') ? request('ln') : '',                         ],                     ],                 ],                 [                     'match_phrase_prefix' => [                         'forename1' => [                             'query' => request('fn') ? request('fn') : '',                         ],                     ],                 ],                       [                     'match_phrase_prefix' => [                         'forename2' => [                             'query' => request('fn') ? request('fn') : '',                         ],                     ],                 ],                 [                     'match_phrase_prefix' => [                         'forename3' => [                             'query' => request('fn') ? request('fn') : '',                         ],                     ],                 ],                 [                     'match_phrase_prefix' => [                         'mothersmaiden' => [                             'query' => request('mn') ? request('mn') : '',                         ],                     ],                 ]             ]         ];
Mapping in model is
protected $mapping = [         "include_type_name" => true,         "properties"=> [             "surname"=>    [ "type"=> "text", "fielddata"=> true ],              "forename1"=>     [ "type"=> "text", "fielddata"=> true  ],              "forename2"=>      [ "type"=> "text", "fielddata"=> true ],             "forename3"=>      [ "type"=> "text", "fielddata"=> true ],             "mothersmaiden"=>      [ "type"=> "text", "fielddata"=> true ],             "mothersmaiden2"=>      [ "type"=> "text", "fielddata"=> true ],             "district"=>      [ "type"=> "text", "fielddata"=> true ],             "page"=>      [ "type"=> "integer" ],             "event"=>      [ "type"=> "text" ],             "quarter"=>      [ "type"=> "integer" ],             "year"=>      [ "type"=> "integer" ],             "pagenumber"=>      [ "type"=> "integer" ],             "letter"=>      [ "type"=> "text" ],             "imgref"=>      [ "type"=> "text" ],             "lsurname"=>      [ "type"=> "text" ],             "lforename1"=>      [ "type"=> "text" ],             "lforename2"=>      [ "type"=> "text" ],             "lforename3"=>      [ "type"=> "text" ],             "ldistrictvolumeno"=>      [ "type"=> "text" ],             "lpage"=>      [ "type"=> "integer" ],             "linktoimages"=>      [ "type"=> "text" ]         ]     ];

I'm having the same issue:
Institution::search($request->term)->get()

returns an empty array, but counts works, and I tried the raw method and the query is returning data, it seems that what is failing is when building the Eloquent models..

@alvarezmario @rudolphp what version gives you incorrect result?

@babenkoivan version 4.0

@babenkoivan using the latest version ^4.0

it seems that what is failing is when building the Eloquent models..
@alvarezmario @rudolphp I've got bunch of questions:

Are you using custom Scout key for models (Model::getScoutKeyName or Model::getScoutKey)?
Are you using Builder::select method? (Model::search('foo')->select(['field1', 'field2']))?
Are soft deletes enabled in the Scout config?
What type of indexer do you use (single or bulk)?
Are you using Model::toSearchbleArray? If so, what is the content?

Are you using custom Scout key for models (Model::getScoutKeyName or Model::getScoutKey)?

No

Are you using Builder::select method? (Model::search('foo')->select(['field1', 'field2']))?

No

Are soft deletes enabled in the Scout config?

No

What type of indexer do you use (single or bulk)?

I indexed using logstash. I am not using this config, so it must be default 'single'

Are you using Model::toSearchbleArray? If so, what is the content?

No

I meet the same problem.
I try to find the where the problem is, I find that $results['hits']['total']['value'] is unset.

I had same issue but fixed after I upgrade elasticsearch to version 7.1

I had same issue but fixed after I upgrade elasticsearch to version 7.1

Yeah, I have fixed by this way. I think it is a compatibility problem. The package author has noted in readme.md

I am running ES 7.3 and running into this problem.  If I use a ->raw() instead of ->get() I properly get my results.

I am having this issue too. On ES 7.3 as well. Is there a way to fix this?

Actually I figured out how to fix this for me. I had to run php artisan scout:import "App\MyEvent" and it worked for me

I try to find the where the problem is, I find that $results['hits']['total']['value'] is unset.

Interesting finding. I tried to reproduce the issue again using different versions of ES, but no luck. It looks like the issue is related to some specific version of ES or configuration as not many people complain about it.

The package gets the models from ElasticSearch, those models are then loaded by Laravel to serialize them in output. For example, if elastic search returns model ID 1, 2, and 3 from the database and you return that in a JSON array. Then models 1, 2, and 3 are loaded from the DB and serialized. If one or more of those models cannot be loaded from the DB (due to an error, incorrect id, permission issue, ect.) then they are excluded from the output.
If you have out of date data or corrupted data in ES (say after an update) then its possible to have nothing load with a silent error.

Same issue with ES 7.1.0 & 7.4.0 and package ^4.0.
->raw() returns expected result but ->get() returns empty.

Faced with the same problem. I downgraded to v3.12.0 and it's solve the problem.

I have a similar issue , It's due to records in your database has been deleted.But somehow it doesn't update this delete action to ES. when u perform search , ES return records that doesn't exsit in database, hence it's showing less items in collections.

I have a similar issue , It's due to records in your database has been deleted.But somehow it doesn't update this delete action to ES. when u perform search , ES return records that doesn't exsit in database, hence it's showing less items in collections.

This 100%

The $model->search('dummy')....->count() returns a count which matches with what is returned as hits in Kibana. But when I replace 'count' by 'get' the Collection items is empty.
(more info - searchRules and Filter is being used too)

Can you please tell me how u solved this issue?


hnix-0.5.2 incompatible with dhall-1.18.0

hnix-0.5.2 has an upper bound of megaparsec < 0.7.0, whereas dhall-1.18.0 has a lower bound of 0.7.0 <= megaparsec
This means that we need to fix https://github.com/haskell-nix/hnix/issues/368 before we can cut a new release of dhall-nix that is compatible with dhall-1.18.0

hnix-0.6.0 has been released and uses megaparsec-0.7. Are there plans to update dhall-nix to the latest dhall in the near future?

@dhess: Yes, definitely.  I've been dying to cut a new release of dhall-nix once hnix supported a recent megaparsec

OK, great news! I'm starting to use dhall-nix in my devops pipelines, and I'm happy to hear that it'll be around in the future!

I'm closing out issues because I'm migrating dhall-nix as a sub-project of the dhall-haskell project and archiving this project.
So this is pretty close to being Hackage-ready.  dhall-nix now builds against the latest dhall, but it requires a version of hnix from GitHub since there are still issues with the latest hnix on Hackage.  Once hnix is readdy on Hackage then I'll upload a new dhall-nix release, which should fix this.  In the meantime, though, I do plan to at least publish the dhall-nix binaries built by CI with each release which you can use in your pipelines.


Allow use of Regional domain names

Context

https://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-basic-concept.html
api-gateway allows "API endpoints" to be either "edge-optimized" or "regional". Edge-optimized is the default, and currently there is no way for zappa to change this behaviour.
Expected Behavior

When doing certify, I should be able to end up with a regional endpoint:

Actual Behavior

Zappa only creates edge-optimized endpoints because it is the default
Possible Fix

add use_regional_endpoint boolean parameter, if True, deploy with regional.
PR coming.

@aarcro, thank you for working on this. I know that this feature has not yet been added to Zappa. I'm wondering if it's possible for me to deploy a Zappa application to the default "edge optimized" API gateway endpoint and then convert that to a regional endpoint. If so, would this prevent me from using zappa update thereafter? I could try it, but I figured that if you already know the answer is "it won't work [without a fight]," then I'd rather save myself the aggravation. :)

Actually it works converting in both directions and I have tried it. The only hitch is you might have to manually delete a route53 entry because the existing behaviour used a CNAME and I preferred A - Alias records for regional endpoints. If we replace the CNAME with Alias, conversion won't be a problem, but upgrading users will have issues with the existing CNAME record.

Thank you!
On Tue, Apr 10, 2018 at 9:36 AM Aaron McMillin<EMAIL_ADDRESS>wrote:

Actually it works converting in both directions and I have tried it. The
only hitch is you might have to manually delete a route53 entry because the
existing behaviour used a CNAME and I preferred A - Alias records for
regional endpoints. If we replace the CNAME with Alias, conversion won't be
a problem, but upgrading users will have issues with the existing CNAME
record.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Miserlou/Zappa/issues/1465#issuecomment-380100319,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEPgn5vPhK4rjHzFPgIQSHb5u_86uF_cks5tnLVNgaJpZM4TA-di
.

--
Sent from Gmail Mobile

@aarcro - just curious - why did you prefer A - Alias to CNAME records in Route 53?

@borenstein You shouldn't need to setup your own CloudFront - zappa certify will do that (for edge optimized), and it uses the AWS owned CloudFront that is controlled by API gateway. Regional optimized gateways are most suitable for being called from other endpoints in the same region, and call the gateway directly.
I'd try it with non-prod first. But if you've changed the pre-existing edge optimized CNAME to an A-Alias, you should be OK to change your settings to use_regional_endpoint: True and do an update. The alias record should change from pointing at CloudFront to pointing at the regional gateway address, so you're looking at a lag of your DNS TTL (probably 60 seconds) before the new pointer is globally available.

There are other considerations:

https://forums.aws.amazon.com/thread.jspa?threadID=84588&start=0&tstart=0
It is impossible to manage your own Cloudfront distro without using Edge Lambda functions (which are much more expensive).  Absent Edge Lambda, you must use API Gateway managed Cloudfront distros, which cannot be user configured.  The gotcha here is that non-Edge Lambda functions lack the required header control to POST (X-Forwarded-For is not passed unmodified).

The last bit is relevant because, for instance, Wagtail has the option to automatically manage Cloudfront as a cache, which of course would be greatly beneficial for read-heavy and write-light sites.    If you're using a Cloudfront distro that's managed by API Gateway there's no way for the user's code to control it.

With these in mind it "might" (based on what I can find) be possible to use regional Cloudfront distro on a regional API endpoint and get around these artificial hindrances that try to force people to pay 3x the price for Edge Lambda functions.  AWS employees on the dev support forum are suggesting this to people as a solution.
I haven't tried yet but will do so shortly.

Will this pull request be making it in? I've just spent the day unwinding this and doing the steps manually after a Zappa deploy. It just ain't pretty at all and the use case of REGIONAL setting on the custom domain seems pretty common.
If it isn't going in.


Update class diagram

Things to check and take note of

interfaces that would be used by other control
arrow head and direction
notation if there is an arrow head

Discussed in 9/3 LAB:
identified Single Responsibility Principle in Class Diagram (volunteer & volunteerwork)
identified Strategy behavioral pattern (permission)

identified singleton (database) & factory (different user accounts)

edited the class diagrams to the correct type interfaces -> boundary

Kenneth - Volunteer
Tennyson - Permission Managment
Joan - Expenses
Janice - Approval
Michael - Reports
Chun Guan - Employees

Updated expense entity to apply single responsibility  principle

For SOLID principles, we will be using single responsibility principle and interface segregation principle
For design pattern, we will be using singleton and template method

SOLID "I" principle added into the class diagram

template pattern shown in class diagram

update minor changes to volunteerworkcontrol

update report control, controller, repoOut

removed reportrepositoryin

class diagram shared with class for integration


Infinite entries iteration on error

There is a regression with the current 0.4 version. If, during the entries iteration an error occurs, the iteration goes on forever, returning always Some(Err(_)).
I've attached a
test file demonstrating the issue.
Minimal snippet to reproduce:
let file = File::open("loop.tar");
let mut tar = Archive::new(file);
for _entry in tar.entries() { }

The error is caused by the last entry in the tar, (which is a non-UTF8 path, but I don't think it matters). With this test:
    let file = File::open("loop.tar").unwrap();
    let mut tar = Archive::new(file);
    for entry in tar.entries().unwrap() {
        match entry {
            Ok(e) => {
                println!("{:?}", e.path());
            }
            Err(e) => {
                println!("{:?}", e);
            }
        }
    }

I can say that the paths are correctly iterated, but at the end, the error is reported forever:
...
Ok("snapshot/two_hardlinked_files1")
Ok("snapshot/two_hardlinked_files2")
Ok("snapshot/\u{62b}\u{fffd}Wb\u{fffd}\u{fffd}]\u{fffd}\u{fffd}\u{15}v*\u{fffd}\u{f}!\u{fffd}>\u{fffd}Y\u{fffd}\u{fffd}\u{fffd}\u{fffd}p\u{fffd}\u{fffd}\u{13}k\u{1d}\u{fffd}\u{fffd}\u{fffd}e\u{fffd}U\u{fffd}\u{fffd}UV\u{fffd}\u{fffd}\u{fffd}4\u{fffd}\u{fffd}X\u{3}\u{fffd}\u{7}s\u{39e}\u{fffd}\u{fffd}4\u{4}\u{fffd}\u{17} \u{fffd}\u{fffd}\u{fffd}\u{fffd}\u{62c}\u{685}\u{fffd}KvC\u{fffd}#\u{fffd}\u{fffd}\u{fffd}\u{277}\u{fffd}_\u{f}\u{fffd}g\u{fffd}B\u{11}<=^\u{fffd}M\u{13}\u{fffd}c\u{fffd}\u{fffd}|*\"/\'^$@#!(){}?+ ~` ")
Error { repr: Custom(Custom { kind: Other, error: StringError("failed to read entire block") }) }
Error { repr: Custom(Custom { kind: Other, error: StringError("failed to read entire block") }) }
...

I've done some preliminary analysis and it seems that some done flag is missing, because next_entry_raw continuously returns an Ok(Error(_)) when it is not able to read data from the header, at archive.rs: 220.

Gah oops, forgot to indeed set a done flag.
Out of curiosity, are you sure this is a valid archive? It looks like it's OK except for that it doesn't end with the standard 1 kilobyte of nul bytes. I'm curious if this was created by a tool and if so if that's actually an accepted archive format.

It seems a valid tar, since tar -tf loop.tar > /dev/null exits with a 0 code. The file is taken from a valid duplicity backup. So it has been generated by python tarfile library!

Hm interesting... The tar format requires that archives are terminated with two blocks of all 0s (a block is 512 bytes), and the python tarfile library has a function for doing this, so it looks like it may be a bug in duplicity that this isn't done.
In that case it may be best to handle those kinds of archives and just return None saying that we're at the end of the archive.

It seems like a bug indeed! I don't know if it's better to return an error or to simply terminate the iteration. Maybe the latter solution is more ergonomic, since who cares about those ending blocks? :) In any case it's your option. Both ways are fine for me!
----- Messaggio originale -----
Da: "Alex Crichton"<EMAIL_ADDRESS>Inviato: 22/01/2016 21:35
A: "alexcrichton/tar-rs"<EMAIL_ADDRESS>Cc: "Michele Bertasi"<EMAIL_ADDRESS>Oggetto: Re: [tar-rs] Infinite entries iteration on error (#53)
Hm interesting... The tar format requires that archives are terminated with two blocks of all 0s (a block is 512 bytes), and the python tarfile library has a function for doing this, so it looks like it may be a bug in duplicity that this isn't done.
In that case it may be best to handle those kinds of archives and just return None saying that we're at the end of the archive.
—
Reply to this email directly or view it on GitHub.

Hm ok for now I think I'll continue to emit an error (in an effort to be "more standard compliant"), but if you would like a better error value or something like that to be returned please just let me know!


Hygieia Core collector

Why do we need Core collector ? I m running JIRA,Bitbucket,AWS&Jenkins collector for creating new Dashboard
Is this really required to build the jar and deploy the server ? in that case how this will be helpful ?

It's not really a collector, it's a jar that all the collectors and api consume.  So it does need to be built, but not actually ran.  The pom's should probably be reorganized a bit so the core project doesn't look like a spring boot app.

@RameshMuthuraj - Please reopen if you have anymore questions.


Update templates.md

Added two new templates and updated others.

:books: Documentation preview :books:: https://civicactions-handbook--1072.org.readthedocs.build/en/1072/

Closing PR (and wanting to learn what happened here also, for future reference!)


Support streaming local device, like microphone in / aux in?

Hi!
I would love to be able to 'cast' audio from a line in. I want to try to get this working - do you have any ideas on how I could hook this up? Where is the binary data sent from the audio files currently?

Hey - you could potentially do this - you'd need a webserver serving up an audio stream of the data on an http url, and then you can start the cast playing from this by doing cast --name Chromecast media play http://streamurl/. It'd play wav, mp3, etc.
As to serving up a microphone as a stream - fmpeg/ffserver might be able to (not tested):
https://ubuntuforums.org/showthread.php?t=1544946

There are many ways to do this using a PC as an intermediary.

https://github.com/acidhax/chromecast-audio-stream/
https://www.addictivetips.com/windows-tips/how-to-stream-audio-from-your-pc-or-mac-to-chromecast/
BubbleUPNP can create a DLNA endpoint on your PC (or Android) that can forward to the Chromecast Audio and you can use that to direct a microphone to your chromecast.
On Linux there is a configuration for pulseaudio to do it as well, but I've not done it.
As far as forwarding a recording from the line-in or mic input on your PC you should be able to do that once you get the PC's audio streaming to the the Chromecast.  Then set the microphone/input properties to "listen" in control panel.  On my Windows 10 it is Settings > Sound > Input > Device Properties > Listen > Check the "Listen to this device" button.

Interesting... I'm basically working with a line-in aux cable, and I currently have a couple different Raspberry Pi's (and a macbook if I need) to work with.
I'll look into hosting the ffmpeg server, otherwise it looks like maybe I could hook up to the input device in alsa?

Yeah, for RPi you can use http://mkchromecast.com/ and Alsa but you'll need a USB soundcard that has an input since the basic RPi hardware doesn't have audio-in.  There are lots of options but nothing is a perfectly simple solution AFAIK.

Hm - I'm going to try to use https://fe-pi.com/products/fe-pi-audio-z-v2

mkchromecast seems like overkill (python + node.js + ...!) given it's just running ffmpeg underneath. Run ffmpeg, and the cast command above. 1 binary solution for the pi :-)


Ensure CRS download works in JS

Problem
The current CRS downloading function is based on reqwest, which may or may not work in JS. We need a download function that works even when the JS feature is enabled.
Proposed solution
Check if the reqwest wasm_bindgen version works; otherwise, implement a version using fetch.
Alternatives considered
No response
Additional context
No response
Submission Checklist

[X] Once I hit submit, I will assign this issue to the Project Board with the appropriate tags.

Won't do since acvm-backend-barretenberg will be decomissioned.


Lift polynomials over finite fields to polynomials over big numbers.

As part of homomorphic multiplication algorithm, we need to lift polynomials whose coefficients are taken modulo a prime q, to polynomials over the integers, such that we can do a few operations there, and then convert back to the arithmetic modulo q.
A simple solution is to use another prime that is big enough (no coefficient actually needs to be reduced after the operations). In particular, we could do something like:
// Sage commands:
// size_q = 79
// size_n = 11
// size = 2*size_q + size_n + 1
// q = random_prime(2**(2*79 + 11 + 1))
// ff = GF(q)
// ff.multiplicative_generator()
// 10
#[derive(MontConfig)]
#[modulus = "292599365471450699889605790713940231423010469055097"]
#[generator = "10"]
pub struct Fq79bnConfig;
pub type Fq79bn = Fp128<MontBackend<Fq79bnConfig, 3>>;

[ ] Create a new Fq79bn that is big enough.
[ ] Implement a function to convert from Poly over Fq79 to Poly over Fq79bn (no reduction needed).
[ ] Implement a function to convert back, after reducing modulo q.

On the other hand, this solution is specific to 79 bits. If there is solution to convert from and to big numbers, then even better.

If there is solution to convert from and to big numbers, then even better.

I don't think there's a generic way of creating a new modular integer type, or having a polynomial with big numbers. I tried a few times, and it's pretty tricky to re-implement the PrimeField trait ourselves.

Implement a function to convert from Poly over Fq79 to Poly over Fq79bn (no reduction needed).
Implement a function to convert back, after reducing modulo q.

These functions can be generic though, via conversion to BigUint.
And we can put the MUL_NUM type in the config trait, so that will be generic as well.
So the only thing we'd need to do manually for each polynomial scheme is the #[derive(MontConfig)], modulus & generator calculations, and number of u64 limbs.


Reorganize the docs sidebar

Why this PR?
Just some more spring cleaning for the docs. This one is in prep for merging #561, which is a nice beginners' intro to the diffusion theory. The idea moving forward would be that each topic gets this type of intro and builds up the theory to the most advanced stuff so we can address the needs of all levels of users
Docs build here
Pulled the theory link out of the User Guide section and made it its own section called Fundamentals (suggestions for a better name definitely welcome)

Also took the 2 theory pages we have currently and split them up into separate files. I think this is a bit nicer because everything is now split in more digestible chunks rather than being assaulted by a wall of text and equations.

Hi Ray, the reshuffling definitely makes it better, now the docs have a more logical structure with smaller pieces of information per section.
Some suggestions:

The 'overview' section feels a bit redundant. It barely gives more information than when you click on 'Diffusion' and watch the section headings. Under 'User Guide' we also don't have an 'Overview' section.
An alternative name for 'Fundamentals' would be 'Learn more'


Add aText Legacy which provides aText 2 for those with older licenses.

The link used for "atext" was updated a few months ago to include aText 3 which drastically changed their licensing model to be subscription based and does not accept aText 2 licenses. aText 2 is still supported until further notice, but is now called "aText Legacy" and available through a different link.

Next time, please branch your PR from main branch, not dev and create a new file for the label in fragments/labels/ not in the root Installomator.sh. See CONTRIBUTING
That said, thanks for contributing!


Update Settings “general”

Automatically generated by Netlify CMS

👷 Deploy Preview for kidskingdom processing.

Name
Link

🔨 Latest commit
dee2a6c20ed755d6e4a07af59b1ca8455743e11f

🔍 Latest deploy log
https://app.netlify.com/sites/kidskingdom/deploys/63aea40244a3b00008e0887f


No way of enabling IGNORE_DUP_KEY for unique indexes via code first

I've searched around regarding this and unless I'm mistaken there is no way to do this.
I have a service which receives a lot of data from multiple origins, however it is often that some of the data in each post is duplicated. Multiple records get added at the same time but if a duplicate exists none of them are saved (as an exception is thrown). I could break apart the record adds and save individually but that would become massively inefficient.
Most responses I've read regarding this issue say to check the incoming data first before adding but even the most optimal solution will quickly cause problems due to the eventual size of the table.
If there is a way to do this, I'd love to know. If there isn't, then I'd love to see this get added (and also have a decent suggestion on how to get around it in the meantime).

I assume you are using migrations to create the database? If so, there is no default support baked in, but you could use the Sql(string) method in a migration to run the raw SQL statement to set this option for the index.


Implement SaveAs button on collect tab

This is for Pro and ArcMap
Mostly copied code from Distance and Direction addin

@kgonzago please review and merge


feat(dto): refactor dto.factory.

Thanks for the PR, there's a lot to like in there!
I've copied the bulk of the logical changes you included in dto.dto() into dto.factory() to centralize logic as there was a fair bit of repetition.
Still yet to write tests.

Thanks @peterschutt!
Will merge this so PR is up-to-date


Split gzutils into functional pieces

GzUtils has gotten unmaintainably large.  This splits the functions into separate files.

GzUtils has gotten unmaintainably large. This splits the functions into separate files.

+1 . Side effects of merging this:

it's going to be hard to do forward/backward ports from/to the gz-cmake2 branch. Is there anything stopping us of sending this to the gz-cmake2 branch?
The current open PRs will need to rebase and probably adapt new code to this change.

it's going to be hard to do forward/backward ports from/to the gz-cmake2 branch. Is there anything stopping us of sending this to the gz-cmake2 branch?

Hmm, good call.  I don't think there is anything stopping us from doing that here.  I may re-open this against cmake2, we can land it with Ign file names and then apply the renaming?

The current open PRs will need to rebase and probably adapt new code to this change.

I think git should track the split/renaming without too much issue, but let me try it on one PR first.

it's going to be hard to do forward/backward ports from/to the gz-cmake2 branch. Is there anything stopping us of sending this to the gz-cmake2 branch?

Hmm, good call. I don't think there is anything stopping us from doing that here. I may re-open this against cmake2, we can land it with Ign file names and then apply the renaming?

Yep, a bit of extra-work sorry but probably will make things easier for the future and reorganize the things on gz-cmake2 as well.

The current open PRs will need to rebase and probably adapt new code to this change.

I think git should track the split/renaming without too much issue, but let me try it on one PR first.

Thanks, anyway we can work on solving the problems that appear.

it's going to be hard to do forward/backward ports from/to the gz-cmake2 branch. Is there anything stopping us of sending this to the gz-cmake2 branch?

Hmm, good call. I don't think there is anything stopping us from doing that here. I may re-open this against cmake2, we can land it with Ign file names and then apply the renaming?

The current open PRs will need to rebase and probably adapt new code to this change.

I think git should track the split/renaming without too much issue, but let me try it on one PR first.

I think it would be easier to resolve the conflicts when merging forward if the change has been applied separately to each branch. I would be fine with merging to gz-cmake3 first and then backporting to ign-cmake2. There's already a conflict on gz-cmake3 though

conflicts

conflicts

I've tried to resolve them. Mostly applied #326 in 7ceb5f6 and #334 in cbf5249

Good for me. @mjcarroll I leave it open until you or @scpeters give a last view on this.

I double-checked the changes using meld and noticed a few small differences: see https://github.com/gazebosim/gz-cmake/pull/349. I'll be ready to approve if we merge that into this branch.

I double-checked the changes using meld and noticed a few small differences: see #349. I'll be ready to approve if we merge that into this branch.

Good catch, merged!

Thanks Steve, I think we are all good here!


See what happens in Travis

then see how it could be fixed

I have no idea of the history of this. For somebody who knows what bits go with what in which versions of PHP, phpunit, webdrivers... is getting the tests to pass likely to be a "short" exercise?
Or is there some architectural issue between all the components that is somehow extremely difficult to fix?
The next official release has been waiting for a long time. Other than me hacking around and not knowing what to do next, is there something that can be done to help get the tests to pass and a new release out? Is it a human resource issue, or some deep technical (read almost unfixable) issue?

Well, the main reason is human resource.
I actually have a branch locally with some changes to help regarding tests (I started doing this work a few days ago, but without having the time to finish it)

I am happy to contribute time, but the problem is that my time is useless because I am starting from scratch and having to dig around by myself in every message I see in the Travis log.
e.g. in PHP 5.* jobs:
PHP Fatal error:  Call to a member function window_handles() on a non-object in /home/travis/build/minkphp/MinkSelenium2Driver/src/Selenium2Driver.php on line 492

It seems that wdSession never gets set, and I guess there is some problem in getting the webdriver started, connected or...
In PHP 7.* jobs:
Fatal error: Uncaught Error: Class 'PHPUnit_Runner_Version' not found in /home/travis/build/minkphp/MinkSelenium2Driver/vendor/mink/driver-testsuite/tests/SkippingUnsupportedTestCase.php on line 7

I guess I need to set MINK_PHP_BIN or something in the environment?
So it is not practical to bring in someone new to do this sort of job.


Typo: multiply instead of multiplied?

In "The size of the buffer is proportional to the event input rate multiply by the out of order window size. The default window size is 0. ", shouldn't it say "multiplied"?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: da35754e-933e-c93f-96e4-415c89cd3dca
Version Independent ID: 375300d6-9bed-ad51-307c-5c2e5de92ee8
Content: Streaming Units in Azure Stream Analytics
Content Source: articles/stream-analytics/stream-analytics-streaming-unit-consumption.md
Service: stream-analytics
GitHub Login: @JSeb225
Microsoft Alias: jeanb

@abdale Thanks for the feedback and bringing this to our notice. At this time we are reviewing the feedback and will provide an update as appropriate.

@abdale The PR for the fix has been created and it will be merged soon. Thanks again for pointing this out, I am closing the issue based on this update, please let us know if there is something else that we can help you with.
PR Details: https://github.com/MicrosoftDocs/azure-docs-pr/pull/95652
Thank you.


Handling Corrupt Demos

I'm having trouble on a particular small set of demos that are making the entire python script exit due to some exceptions with the parser unable to read the entities as they get returned Null.
Example demo URL

Example of errors (lot's of them, this is a snippet)
ec 31 03:45:06 ip-10-0-0-217.ec2.internal python3[31301]: Exception ignored in: 'demoparser.demofile.DemoFile.handle_packet_entities'
Dec 31 03:45:06 ip-10-0-0-217.ec2.internal python3[31301]: Traceback (most recent call last):
Dec 31 03:45:06 ip-10-0-0-217.ec2.internal python3[31301]: File "/usr/local/lib64/python3.7/site-packages/demoparser/entities/entity_list.py", line 26, in __getitem__
Dec 31 03:45:06 ip-10-0-0-217.ec2.internal python3[31301]: return self._entities.__getitem__(index)
Dec 31 03:45:06 ip-10-0-0-217.ec2.internal python3[31301]: IndexError: list index out of range
Dec 31 03:45:06 ip-10-0-0-217.ec2.internal python3[31301]: AttributeError: 'NoneType' object has no attribute 'class_id'
Dec 31 03:45:06 ip-10-0-0-217.ec2.internal python3[31301]: Exception ignored in: 'demoparser.demofile.DemoFile.read_new_entity'
Dec 31 03:45:06 ip-10-0-0-217.ec2.internal python3[31301]: AttributeError: 'NoneType' object has no attribute 'class_id'
Dec 31 03:45:06 ip-10-0-0-217.ec2.internal python3[31301]: Traceback (most recent call last):
Dec 31 03:45:06 ip-10-0-0-217.ec2.internal python3[31301]: File "/usr/local/lib64/python3.7/site-packages/demoparser/entities/entity_list.py", line 26, in __getitem__

Normally in some cases when these errors pop up, the exceptions are ignored and the demo parses fine, however a small set of these are creating so many errors that eventually the script will exit.  Is there something we can write in the code to either handle these errors or allow it to raise an exception in the python interpreter rather than ignoring it?
Thanks

Just noticed that this started happening to all demos after Danger zone came out


Player.Money only accesses Michael's account

When playing as Franklin or Trevor and modifying the Player.Money variable, it only accesses the value stored in Michael's account.
e.g., I was playing as Trevor, who had about $180,000 in his account, while Michael had about $940,000. When I added $100 to Player.Money, Trevor's account jumped to $940,100.

Yeah, it currenly always returns Michaels value and when modifying the value it applies it to all. Not how it should be.

but we could simulate that by checking the model
Native trainer can't add money if you are using different skin. Can assume that it checks player model.


Button text not checked

Challenge http://freecodecamp.com/challenges/waypoint-add-a-submit-button-to-a-form has an issue.
Specified:Your submit button should have the text "submit"
edit:check for this
this button submits the form
it is checking for substring 'submit' probably

@smarshy thanks for posting this issue!
I've just tried <button type="submit">hello</button> and didn't pass the test.
Please review the Guidelines for Contributing, thank you!.

@smarshy What exactly is the issue you are having?

@smarshy <button type="submit">this button submits the form</button> passed the test. Test description says that "Your submit button should have the text "submit"." so it doesn't say exactly or I'm wrong? Notice that I'm not a native English speaker so I can simply mix up the meaning of word "should". Thanks.
Please review the Guidelines for Contributing, thank you!.

The test is lenient. It only test for the existence of submit in the text of the button and the test text does not specify that it should only be submit. Not sure if this is an issue. Does this confuse users?


Sanitize debug log

What does this PR change? What problem does it solve?
The debug log currently contains authentication credentials which can cause them to leak accidentally. This PR redacts the two most obvious leaks:

The dumped http request headers often contain a secret Authorization header.
The backend config often contains the secret part of an access token.

Quite likely neither information is required for debugging, so just replace these with **redacted**.
Was the change previously discussed in an issue or on the forum?
No. But it was prompted by #3450.
Checklist

[x] I have read the contribution guidelines.
[x] I have enabled maintainer edits.
[x] I have added tests for all code changes.
[ ] I have added documentation for relevant changes (in the manual).
[ ] There's a new file in changelog/unreleased/ that describes the changes for our users (see template). Not visible for normal users.
[x] I have run gofmt on the code in all commits.
[x] All commit messages are formatted in the same style as the other commits in the repo.
[x] I'm done! This pull request is ready for review.

I've rewritten the SecretString implementation to be much more robust. And now the X-Auth-Token and X-Auth-Key used by Swift are also redacted in the http debug log.

LGTM. This will also fix a part of #1123.


Missing Header mcpwm_bdc_speed_control (IDFGH-7325)

Development Kit:       FireBeetle V2ESP32-WROOM-32E
Module or chip used:  ESP32-WROOM-32E
IDF version: framework-espidf 3.40302.0 (4.3.2)
Build System:        idf.py
Compiler version: toolchain-xtensa-esp32 8.4.0+2021r2-patch3
Operating System:  Windows
Using an IDE?:  VSCode
Power Supply:     USB 5V

Problem Description
Attempting to build the example
https://github.com/espressif/esp-idf/tree/a82e6e63d9/examples/peripherals/mcpwm/mcpwm_bdc_speed_control
I get an error
src/main.cpp:14:10: fatal error: driver/pulse_cnt.h: No such file or directory
The code to reproduce is the same as in the GitRepo
I tried manually searching the installed libs but I cant see any instances of these files?
C:\Users\PMagee.platformio\packages\framework-espidf\components
Debug Log:
> Executing task in folder ESPIDF_mcpwm_test: C:\Users\PMagee\.platformio\penv\Scripts\platformio.exe run <

Processing firebeetle32 (platform: espressif32; board: firebeetle32; framework: espidf)
----------------------------------------------------------------------------------------------------------------------------------------------------------------Verbose mode can be enabled via `-v, --verbose` option
CONFIGURATION: https://docs.platformio.org/page/boards/espressif32/firebeetle32.html
PLATFORM: Espressif 32 (4.2.0) > FireBeetle-ESP32
HARDWARE: ESP32 240MHz, 320KB RAM, 4MB Flash
DEBUG: Current (esp-prog) External (cmsis-dap, esp-prog, iot-bus-jtag, jlink, minimodule, olimex-arm-usb-ocd, olimex-arm-usb-ocd-h, olimex-arm-usb-tiny-h, olimex-jtag-tiny, tumpa)
PACKAGES:
 - framework-espidf 3.40302.0 (4.3.2)
 - tool-cmake 3.16.4
 - tool-esptoolpy 1.30300.0 (3.3.0)
 - tool-idf 1.0.1
 - tool-mconf 1.4060000.20190628 (406.0.0)
 - tool-ninja 1.9.0
 - tool-openocd-esp32 2.1100.20220411 (11.0)
 - toolchain-esp32ulp 1.22851.191205 (2.28.51)
 - toolchain-xtensa-esp32 8.4.0+2021r2-patch3
Reading CMake configuration...
LDF: Library Dependency Finder -> https://bit.ly/configure-pio-ldf
LDF Modes: Finder ~ chain, Compatibility ~ soft
Found 0 compatible libraries
Scanning dependencies...
No dependencies
Building in release mode
Compiling .pio\build\firebeetle32\src\main.o
src/main.cpp:13:10: fatal error: driver/gptimer.h: No such file or directory
 #include "driver/gptimer.h"
          ^~~~~~~~~~~~~~~~~~
compilation terminated.

Other items if possible
Cmake and sdkconfig attached.

Hi @patrickmagee,
It looks like you are trying to build an example from master branch of this repository with an older version of ESP-IDF (4.3.2).
Please check the examples from the same version of ESP-IDF as the one you are using locally, i.e. https://github.com/espressif/esp-idf/tree/release/v4.3/examples/peripherals/mcpwm/

Hi Igrr,
Yes you are correct, I'm using VScode Platformio and their latest available version is 4.3.2, it always lags behind I believe.
I got the functionality working with the example you linked.
Thanks very much for your assistance.

Thanks for reporting, feel free to reopen.


gl_engine: support cross compile GL backend into WASM

This PR support cross compile the GL backend code into WASM. The code needs WebGL 2.0 API so, the compile flags contains MAX_WEBGL_VERSION and FULL_ES3 Also add binding code to initialize the WebGL context and GLCanvas.
With this PR, the wasm binary contains WebGL backend rendering, the rest of the work will need to be supported by the thorvg.web project.
issue: #2837

Browser Compatibility Testing Result
I've proceeded browser level testing with WebGL. cc. @hermet
Lottie
I noticed some rendering compatibility issues in WebGL. Others in example folder appear to work fine.

abstract_circle.json

anubis.json

card_hover.json

cat_loader.json

kote.json

swinging.json

SVG
I manually tested all the svg files in the example folder, and they all look good.

@RuiwenTang @tinyjin Thanks for this. let's address the rendering issue separately -> https://github.com/thorvg/thorvg/issues/2997


fix(deps): update dependency @google-cloud/common to ^0.23.0

This Pull Request updates dependency @google-cloud/common (source) from ^0.21.0 to ^0.23.0.
Fixes https://github.com/googleapis/nodejs-storage/pull/340

Feel free to ignore kokoro failures for now. We haven't set it up for storage just yet.


unread: Extract old_unreads_missing.

This avoids post-initialization access to page_params inside unread.js.
A follow-up to #23352

Screenshots and screen captures:
Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Merged, thanks @PIG208!


Revert "Made grpc_core::Mutex compatible to absl::Mutex"

Reverts grpc/grpc#25325

@markdroth It's unclear this PR caused the issue but I couldn't import it because of existing flaky tests and deflaky & submit didn't help. I'll retry this while keeping the regular import train running.


Add compute nodes as SGE submit hosts

We have at least one use case where SGE jobs make qsub calls to submit additional jobs to the cluster. This PR adds the "submit host" capability to cfncluster compute nodes.

This has been pulled into the latest develop branch.


CB-18569 using cdp gateway everywhere

I have to test UI locally before merge

changes made to make it work with UI too

@sodre90 I am merging this before I forget it completely :D I have tested UI with and without remote UMS, looked good, pls let me know if it is not working and we can revert it/fix it


Delete unnecessary spaces

When copying from the web page, there is an unnecessary space after the code.

@changeworld : Thanks for your contribution! The author, @mikejo5000, has been notified to review your proposed change.

@changeworld Thank you for your changes. I've reviewed these and will merge now.


FF: when double-clicking right of a paragraph the DOM selection does not mapped correctly

Not critical. Will be done in beta 5.


very very minor spelling correction in the readme

Not trying to be a grammer nazi, just thought this would help!

Hi @AhanR,
Thank you for your contribution


figures and captions

Updates CSS for figure captions, also adds rules for sidebar captions:
https://147-244496643-gh.circle-artifacts.com/0/html/reference/limits.html#common-publishing-items

@najuzilu I've sent an invite to add you as a maintainer on this repository, in case you'd like to give this a merge when you're happy with it. Otherwise I'll merge a bit later unless you have comments

Nicely done! I think aligning figures should be kept at a theme level. Should I remove the PR about aligning figures from MyST-NB then?

Also, is there a :target: equivalent in MyST-NB? Just wandering because I'm compiling a list of all parameters supported for figures.

Hmmm, I am not sure what target is :-)  so...maybe?

Actually the target is set by default. I didn't realize that figures were "clickable".


🚀 Feature: Surfacing error for entities committed by Incremental Entity Providers

🔖 Feature description
One of the benefits of using a kind: Location is that we can attach errors to the location of an entity previously emitted from that location. This is especially helpful when the location points to a YAML file which can become improperly formatted. In this case, the parsing error can be attached to the location and shown on the entity page. Similar functionality is missing on Incremental Entity Providers; furthermore, it exposes a limitation of Incremental Entity Providers that may lead to missing data in the catalog.
We need a way to show that an entity previously ingested can not be updated because of an error. Imagine these use cases,

An incremental entity provider finds a YAML file and parses it on the first ingestion. This will make the entity available in the catalog as expected.
A user edited the YAML file with incorrect formatting.
The incremental entity provider runs ingestion again, it finds the file, but it can not parse the YAML document because it's malformed.
Since we can not extract the entity from this location, it'll disappear from the catalog.

Instead, the entity should remain in the catalog, and we should be able to report an error on this entity.
🎤 Context
We're building a GitHub Enterprise ingestion system for one of our clients, which uses direct ingestion without intermediate locations. We're using incremental entity providers to ingest repositories. We want users to be able to take over the management of component metadata by adding a catalog-info.yaml file to the repository. Once the file is in the repository, the component becomes managed by that file instead of metadata extracted from the repository.
I want to ensure that we don't lose the entity from the catalog if the user mistakes editing the file.
✌ Possible Implementation
One option may be to provide a way to signal to the ingestion backend that it should reuse previously ingested entities for a given location. We currently return { done, cursor, entities} from an ingestion burst.
We could include errors with that payload: { done, cursor, entities, errors }. The interface for errors could be something like this,
interface IngestionError extends Error {
  location: string
  ref?: string
}

type IngestionErrors = IngestionError[]

The ingestion backend could use location to look up what entities were successfully returned previously for this location. We can filter by the ref if we want to attach errors to only a specific entity at the location. The error would be attached to the previous entity data and committed by the entity provider.
👀 Have you spent some time checking if this feature request has been raised before?

[X] I checked and didn't find a similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
Frontside can implement this improvement once we agree on the approach.

I like this. Since a location can contain multiple entities, we'd need to make sure this mechanism can differentiate between entities that failed (reusing the existing ones) and entities that succeeded.
You should see #14904 - I think the redesign for the ingestion_mark_entities table has a good synergy with this proposal.

Being able to return errors in a structured way sounds sensible. This way it's easily to exclude them from the final remove delta. We'd probably address them by ref for the exclusion purpose, but the location is valuable contextual information.
The problem is that we can't really transmit that error state meaningfully right now. I don't believe you can add an errors array to the input entities, and besides, re-submitting with errors would require reading from the catalog again which is a place where we don't want to be because of consistency concerns.
To be able to place these errors on the final entities, we'd have to invent a way for providers to emit error information across the connection.

We'd probably address them by ref for the exclusion purpose, but the location is valuable contextual information.

We might not know the refs of the entities that have errors. For example, if you have a catalog-info.yaml file that has 3 documents in it and we can't parse the document because it's malformed. We only know the location of this document, but not the documents that were in it previously.

The problem is that we can't really transmit that error state meaningfully right now.

What if we transmitted errors as kind: IngestionError? We could attach error entities as relationships to entities.

To be able to place these errors on the final entities, we'd have to invent a way for providers to emit error information across the connection.

How about the following,

We store location and initial entities returned from a location in Ingestion Backend database table.
We allow to return error entities either via errors or entities
When Ingestion Backend encounters an error entity

It checks what entities were discovered previously at that location
It retrieves the previously discovered entity's initial value
It attaches the error to the initial entity via a relationship
It commits both the ingestion error entity and previously ingested entity

The initial entity will go through the processing pipeline with errors attached as relationships
The UI can show the error attached to the entity


dirext: Add ensure_dir_with() API

There's create_dir_all() but in some cases in ostree/rpm-ostree
we want to be more careful and not automatically create the parent
directories.

OK while thinking about your comments I wondered about the behavior with an existing file there, and we actually just returned Ok(true) for that and not an error, which seems wrong.    It seems like there's actually no way to do mkdirat(O_NOFOLLOW) - if true this seems a bit surprising.

Tangentially also find myself wondering if it'd be more "cap friendly" to actually have the create_dir_all() function and this one also open the directory too.  (The use case for creating a directory, but not opening it seems actually quite obscure, and the performance cost of the extra open() is probably similar to stat() anyways)

mkdirat never follow symlinks; it fails with EEXIST if there's something in the way, including a dangling symlink.
I've thought about having create_dir return a handle in cap-std, however decided against it because it wouldn't be able to be atomic. For example, in a situation like eg. /tmp with a tmp cleaner that might race with you, it wouldn't be able to be sure that the directory you got a handle to is the same one that you just created, because OS APIs don't give us that ability. Obliging the user to do the open separately, we make it clear that it's the user's responsibility to think about what might happen between the creation and the open.

OK right, I see where I got confused.  We need to use symlink_metadata() here in our double check path.

I've thought about having create_dir return a handle in cap-std, however decided against it because it wouldn't be able to be atomic.

True.  I wonder if anyone's ever tried to make O_DIRECTORY | O_CREAT work.  The fact that it's unlinkat("path", AT_REMOVE_DIR) is an argument that the rmdir syscall was wrong.


Updates to civic_hackers.yml

PR 3 of 3
This aligns to PR 625 in https://github.com/github/government.github.com/pulls.

I added this as a submodule, but something seems to have gotten messed up. This would just bring it up to date with the github/government.github.com repo, right? If so, I'll just fix the submodule so that it can be kept current.

Right, the submodule should be fixed to stay current with github/government.github.com.  I was fixing in two places because my updates are more recent than theirs.  But safer to stay in sync with what they have.

Ok, submodule relationship should be working now. Hopefully they'll accept your PR soon.

@jcastle I didn't set this up to gather timeseries type data (org/repo activity over time, growth of orgs, growth of relationships). Seemed not worth it then, because gathering the data takes forever with rate-limiting and I figured issues with the data would compound over time. But maybe of interest for sets of organizations with similar governance/dev protocols? Or for certain data elements? Haven't given it too much thought.

@jcastle -- you might want to look at what @LRWeber and I did over in https://github.com/LLNL/llnl.github.io/blob/master/explore/scripts/MASTER.sh to pull data from GitHub. Now uses the GraphQL API and is significantly faster w.r.t. to rate limiting and number of requests used.
If you're using the REST API (v3) instead of the GraphQL API (v4) I definitely recommend giving it a look.

Thanks @IanLee1521!  Might look at this in the future for code.gov.  Have what I need for right now.

@IanLee1521 that's neat, thanks! Didn't realize that had come about since I wrote this.


Undocumented version requirements for python, tensorflow, and keras

It's unclear what compatible versions of tensorflow, keras, and python this works with. Please document in readme so we can make sure we are using the right versions if we want to leverage your algorithms.
Please make sure that the boxes below are checked before you submit your issue. If your issue is an implementation question, please ask your question in the Keras-RL Google group or join the Keras-RL Gitter channel and ask there instead of filing a GitHub issue.
Thank you!

[ x] Check that you are up-to-date with the master branch of Keras-RL. You can update with:
pip install git+git://github.com/keras-rl/keras-rl.git --upgrade --no-deps

[ x] Check that you are up-to-date with the master branch of Keras. You can update with:
pip install git+git://github.com/fchollet/keras.git --upgrade --no-deps

[n/a ] Provide a link to a GitHub Gist of a Python script that can reproduce your issue (or just copy the script here if it is short). If you report an error, please include the error message and the backtrace.

actually, i was looking through the code and the code uses keras library not the tensorflow.keras which might lead to problems. I think one simple (yet which can be exhausting easily) is to shift this code to tensorflow.keras otherwise it wont work with any new keras version

one more thing Keras officially has started to add algorithms. but the list still seems short
I think we can simply shift the documentation and the implemented algorithms from here to there?


fix locking calls for local file cache save and read

All calls to json.load(s) and json dump are not async/awaited, so this has ticking time bombs @sh00t2kill.
Aside from that I've already PRd #21.

I might have c&p it wrong, oops!
The spaces annoyed me so much. I'll pull your changes into my branch


run weave for the pod network in ansible phase2

until kubenet is ready to go.

this is probably done with kube-weave


Use classes & decorators for a code-first Prisma Schema SDK

Description
We've explored this area in the past and came to the conclusion that classes aren't a great fit to do data-modeling in general, and more especially in Javascript for the following reasons:

(JS specific) Poor support for classes (eg: lack of multi-inheritance) + poor type-safety with TS
(JS specific) Decorators are still experimental, so is reflection
Database types can’t all be expressed by the language primitives. Meaning types need to be defined twice (eg: like TypeORM)
OO encourages to mix two different abstractions in one: Data-modeling and domain model concepts. Lots of ORMs mixes them/allow to mix them for convenience under the concept of “Entities” or “Models” classes. We think this only works for small/simple applications, and we should encourage for better modularity from the start.

“But gluing data persistence and model logic together comes at a cost. When it comes to managing the growth of Rails applications, particularly those that have intricate business logic spread over a large set of features and capabilities, the framework defaults suffer from a kind of metaphor shear where the concept of ‘models’ directly mapping to database tables is overshadowed by the variety and complexity of business logic and domain model concepts.” - Rise and fall of ORM

(JS specific) Pure objects are more idiomatic to JS + functional paradigm is becoming more popular (eg: react-hooks)
(JS specific) Easier API for higher level frameworks: Building dynamic objects is simpler than classes

If you still think classes and decorators are a great fit, feel free to leave your opinion here 🙌

(JS specific) Decorators are still experimental, so is reflection

That's why Angular 2+ uses them for over 3 years, as well as many apps deployed to productions :confused:

Database types can’t all be expressed by the language primitives. Meaning types need to be defined twice (eg: like TypeORM)

Fixable by simple transform plugin:
https://github.com/MichalLytek/typegraphql-reflection-poc

lack of multi-inheritance

Use class mixins and prefer composition over inheritance?
https://github.com/MichalLytek/type-graphql/tree/9af3077c94f11723615973838320285272634c2f/examples/mixin-classes

poor type-safety with TS

What do you mean?

We think this only works for small/simple applications, and we should encourage for better modularity from the start.

So Prisma2 is designed only for large teams with big enterprise apps? If there are people and teams that uses the TypeORM and TypeGraphQL pattern sucesfully, we should just skip them because they can't be right?

Pure objects are more idiomatic to JS + functional paradigm is becoming more popular

So why Photon is returning Promises instead of RXJS observables? :P

Easier API for higher level frameworks: Building dynamic objects is simpler than classes

Why not both? Have a simple API for building prisma2 from object and then allow for creating decorator API on top of that?

4 yaers later...
I'm using typeorm and I want to switch to prisma but I can't because there is no support for decorators :(


Minutes updated

Adding meeting minutes from previous meetings (originally tracked in Whatsapp) -- now converted to .md files in the documentation folder

looks good and everything works fine in my system.


feat(#112): Handle annotations correctly

We skipped annotations during parsing java code. Now we handle them the same way as usual classes.
Issue related: #112

@rultor merge

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 3min)

@rultor release, tag is 0.1.13

@rultor release, tag is 0.1.13

@volodya-lombrozo OK, I will release it now. Please check the progress here

@rultor release, tag is 0.1.13

@volodya-lombrozo Done! FYI, the full log is here (took me 3min)


Missing renameFile function

Dropzone.js support renameFile which is not added on this project. The change is very easy.
I'm using version 0.8.6 and it's not present and checking the latest (1.0.1) version I see that it's not present either

I have created a branch in order to fix version 0.8.6
https://github.com/deivinsontejeda/ember-cli-dropzonejs/tree/fix/add-missing-function-renamefile

Thanks! Could not merge your branch because it was an old version.

Yes, How we can create a new version from 0.8.6 and another from last one?

Just fork the latest version


TN-983 fix locale selection for i18next config

fix default locale selection for i18next
linting some JS issues (e.g. unnecessary comma, etc., single quotes)
move document ready block to bottom
for this release

Thanks! May leave some review comments later but want to try this out before our call if I can :)


UI: Add more complex GKE Options

UI for https://github.com/rancher/rancher/issues/14634

Compared to older release, this and a few related UI issues adds the following to GKE cluster options and node options:
Cluster options new features:

Node options new features:

Version: Master 2.2 (2/14/19)
Tested the following per linked issue. This comment will be updated once get more info in that linked issue.

basic authentication
? What is this?

client certificate
? I don't see an option to enter client cert in UI ?

labels
Confirmed. You can set node labels now. Validated this and confirmed this is seen on Google Cloud console.
When you set cluster label first a cluster is brought up with the name we set in UI then it's torn down and we bring up one with the cluster label we specified. This seems odd.

vpc-native
? What is this ?

Automatically create secondary ranges
? What is this ? Subnetwork?

  ipPolicyCreateSubnetwork: true

Master authorized networks
Confirmed. You can set Master authorized network.

  enablePrivateEndpoint: false
  enablePrivateNodes: true
  masterAuthorizedNetworkCidrBlocks: ["<IP_ADDRESS>/8"]
    0: "<IP_ADDRESS>/8"
  masterIpv4CidrBlock: "<IP_ADDRESS>/17"

maximum number of nodes per pool
Confirmed. This was already validated in another issue: #17992

  maxNodeCount: null
  minNodeCount: null

network policy config (GKE appears to ignore this value and always sets disabled to true)
? What is this? Is this just Network and Node Subnet options? if so already validated in #17992

  network: "default"
  subNetwork: null  ???????

Diff below shows list of all new options when submit create GKE cluster form via UI compared to previous. I know many are not related to this specific issue.
  diskType: "pd-standard"
  displayName: ""
  driverName: "googlekubernetesengine"
  enableAutoRepair: false
  enableAutoUpgrade: false
  enableMasterAuthorizedNetwork: true
  enableNodepoolAutoscaling: false
  enablePrivateEndpoint: false
  enablePrivateNodes: true
  gkeCredentialPath: ""
  imageType: "UBUNTU"
  ipPolicyClusterIpv4CidrBlock: "<IP_ADDRESS>/11"
  ipPolicyClusterSecondaryRangeName: null
  ipPolicyCreateSubnetwork: true
  ipPolicyNodeIpv4CidrBlock: ""
  ipPolicyServicesIpv4CidrBlock: "<IP_ADDRESS>/18"
  ipPolicyServicesSecondaryRangeName: null
  ipPolicySubnetworkName: ""
  issueClientCertificate: true
  kubernetesDashboard: false
  labels: []
  legacyAuthorization: false
  localSsdCount: 0
  maintenanceWindow: ""
  masterAuthorizedNetworkCidrBlocks: ["<IP_ADDRESS>/8"]
    0: "<IP_ADDRESS>/8"
  masterIpv4CidrBlock: "<IP_ADDRESS>/17"
  maxNodeCount: null
  minNodeCount: null
  name: ""
  network: "default"
 nodePool: ""
  nodeVersion: ""
  oauthScopes: ["https://www.googleapis.com/auth/devstorage.read_only",…]
    0: "https://www.googleapis.com/auth/devstorage.read_only"
    1: "https://www.googleapis.com/auth/logging.write"
    2: "https://www.googleapis.com/auth/monitoring"
    3: "https://www.googleapis.com/auth/servicecontrol"
    4: "https://www.googleapis.com/auth/service.management.readonly"
    5: "https://www.googleapis.com/auth/trace.append"
  preemptible: false
  resourceLabels: ["clusterlabelkey=labelvalue"]
    0: "clusterlabelkey=labelvalue"
  serviceAccount: "secret"
  subNetwork: null
  taints: []
  useIpAliases: true
  zone: "us-central1-f"
  id: "c-c5sz8"
  internal: false

@loganhz I don't see anything in UI for issueClientCertificate is this expected? Is it a hidden/unconfigurable field?
cc: @fyery-chen
otherwise I believe I have validated everything from UI perspective.

@davidnuzik It is a hidden field, always be true.
https://github.com/rancher/ui/blob/bdc2f2d324b99b0ec324e47b4f67baf547b37462/lib/shared/addon/components/cluster-driver/driver-googlegke/component.js#L679

Thanks everyone for your help.
Closing per my comment above https://github.com/rancher/rancher/issues/17993#issuecomment-463744885 which has details outlining the testing done. Some further testing is also continuing in this area as we test other related issues. Validated http/API.


Caching of systems built with kwargs does not always work

Calling build_system with the same arguments should always produce the same system, regardless of whether the system as been cached. It does not in some cases.
Steps to reproduce:

Build a system with single time series and forecasts, ensuring it is built from scratch.

julia> sys = build_system(PSITestSystems, "c_sys5_uc"; add_single_time_series = true, add_forecasts = true, force_build = true)
       counts = get_time_series_counts(sys)
       @show counts.static_time_series_count counts.forecast_count
┌ Info: Building new system c_sys5_uc from raw data
└   sys_descriptor.raw_data = "/Users/dthom/.julia/artifacts/5d4238c516a97bf1a5c6d09af6717e2b14e9738d/PowerSystemsTestData-3.0-alpha/psy_data/data_5bus_pu.jl”
[ Info: Serialized time series data to /Users/dthom/repos/sienna/PowerSystemCaseBuilder.jl/data/serialized_system/ForecastOnly/c_sys5_uc_time_series_storage.h5.
[ Info: Serialized System to /Users/dthom/repos/sienna/PowerSystemCaseBuilder.jl/data/serialized_system/ForecastOnly/c_sys5_uc.json
[ Info: Serialized System metadata to /Users/dthom/repos/sienna/PowerSystemCaseBuilder.jl/data/serialized_system/ForecastOnly/c_sys5_uc_metadata.json
counts.static_time_series_count = 3
counts.forecast_count = 3

Build the same system, but without single time series. It will deserialize the above system, which is incorrect.

julia>   sys = build_system(PSITestSystems, "c_sys5_uc"; add_single_time_series = false, add_forecasts = true, force_build = false)
       counts = get_time_series_counts(sys)
       @show counts.static_time_series_count counts.forecast_count
[ Info: Deserializing with InMemoryTimeSeriesStorage is currently not supported. Using HDF
[ Info: Loaded time series from storage file existing=/Users/dthom/repos/sienna/PowerSystemCaseBuilder.jl/data/serialized_system/ForecastOnly/c_sys5_uc_time_series_storage.h5 new=/var/folders/pb/k6nlfrfj7n75gnl_6z880y50sf8tpd/T/jl_rvVMIu compression=CompressionSettings(false, CompressionTypes.DEFLATE = 1, 3, true)
counts.static_time_series_count = 3
counts.forecast_count = 3

Repeat 2 but force a build from scratch. It will build the correct system.

julia>   sys = build_system(PSITestSystems, "c_sys5_uc"; add_single_time_series = false, add_forecasts = true, force_build = true)
       counts = get_time_series_counts(sys)
       @show counts.static_time_series_count counts.forecast_count
┌ Info: Building new system c_sys5_uc from raw data
└   sys_descriptor.raw_data = "/Users/dthom/.julia/artifacts/5d4238c516a97bf1a5c6d09af6717e2b14e9738d/PowerSystemsTestData-3.0-alpha/psy_data/data_5bus_pu.jl”
[ Info: Serialized time series data to /Users/dthom/repos/sienna/PowerSystemCaseBuilder.jl/data/serialized_system/ForecastOnly/c_sys5_uc_time_series_storage.h5.
[ Info: Serialized System to /Users/dthom/repos/sienna/PowerSystemCaseBuilder.jl/data/serialized_system/ForecastOnly/c_sys5_uc.json
[ Info: Serialized System metadata to /Users/dthom/repos/sienna/PowerSystemCaseBuilder.jl/data/serialized_system/ForecastOnly/c_sys5_uc_metadata.json
counts.static_time_series_count = 0
counts.forecast_count = 3

Proposal to fix this issue:

Add the field supported_arguments::Dict{String, Any} to SystemDescriptor. Defaults to empty Dict. Keys are argument names and values are default values.
When the main code processes build(system; kwargs…), it checks for allowed arguments and forwards them along as positional arguments. If the user passes unsupported kwargs, the main code must throw an exception.
Each case’s build function must define its custom arguments as positional arguments. Currently, they are collected in a kwargs… parameter.
When the main code serializes the system, it must record the names and values of the custom parameters. This could be in the name of the directory, a hash, a JSON file in the directory, or some combination of those.
When the main code checks for the existence of a cached system, it reverses the process.


How to use LIKE?

Is it possible to select data with LIKE condition?
What I've tried so far:
var_dump($User->query("SELECT * FROM `users` WHERE `username` LIKE '% ? %'", [1 => "Kota"]));

You can try something like this:
$result = $spot->mapper('Entity\User')
    ->where(['username :like' => '%Kota%'])
;

Great, why this isn't in documentation :(, thank you so much.


docs: typo in building.md (changing image's java base)

https://github.com/itzg/docker-minecraft-server/blob/6359b5ce4232c33cd79ccf3fab2a649cff671480/docs/misc/contributing/building.md?plain=1#LL7C31-L7C32
docker build --build-arg BASE_IMG=ghcr.io/graalvm/graalvm-ce:ol8-java11 -t IMG_PREFIX/minecraft-server:java11-graalvm .

The example line given (above) to change the base image for the minecraft-server image has an error as the line contains BASE_IMG.
It should be BASE_IMAGE, I got caught up on it for around 30 mins and I didn't want anyone else to as well. I tried changing the image to the GraavlVM enterprise edition, so that's why. Thank you!

Thanks, that is indeed the wrong variable.


⚠ Bofrost.nl has degraded performance

In d6d1c83, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1134 ms

Resolved: Bofrost.nl performance has improved in 8cbfafb.


option to reduce noisy Lua_LS's missing-fields warnings

wommy, I would recommend squashing the two commits into one since one is fixing the other and making a force push

I agree that would be fantastic.

I just squash merged it myself. Thanks for the contribution!


Experimental - filtering items based on query string filter

Motivation
Related to #191
Checklist

[ ] Code follows coding conventions held in this repo
[ ] Automated tests have been added
[ ] Tests are passing
[ ] Docs have been updated (if applicable)
[ ] Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test
If manual testing is required, what are the steps?

The tests are failing because the default behavior has changed for v 1.1.12 of gatsby-plugin-image - https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-plugin-image/CHANGELOG.md#120-2021-03-30

This pull request introduced the change: https://github.com/gatsbyjs/gatsby/pull/30328


Implement semantic tokens refresh

Summary of the changes

Start publishing workspace\semanticTokens\refresh events when the Razor workspace changes.
Use the ProjectSnapshotChangeTrigger infrastructure to make sure this happens on each change.

Part of https://github.com/dotnet/razor-tooling/issues/6214.
This does NOT solve:

Updating after changes to C#. Once Roslyn adds their workspace/semanticTokens/refresh we'll start intercepting it and use that to trigger a refresh from Razor.
Debouncing. Though the overhead here is small (no payload) it might be wise to add some kind of a debounce/delay/de-duplication since this could happen very fast (especially at project-start). The client will surely do some of that themselves, but it'd be a good idea to avoid the back and forth regardless.
No tests. Tests to be added when this leaves draft. Mostly just curious if people think this is the right drift.

Moving this out of draft. Full reviews appreciated.


[RFC] Make the TorchData Library Standalone from PyTorch Core Library

🚀 The feature
Note that this is a request for comment; currently, there is no plan to make TorchData a standalone library. We would like to solicit feedback from the community.
Proposal: Make the TorchData library standalone with little to no dependency on the PyTorch Core library (i.e. torch).
Motivation, pitch
An argument for a standalone library is that, it will allow users to use all the data loading functionalities in this library without installing/using PyTorch. Datasets implemented using TorchData may become usable by other frameworks.
An argument against this change is - in order to certain DataLoader functionalities backward compatible with DataPipes, the torch library may need to become dependent on TorchData instead.
The list of arguments here is not comprehensive, feel free to leave a comment about potential use cases and how they will be impacted.
Alternatives
Leave the library as it is with dependency on torch.
Additional context
Please feel free to leave any comment/reaction to this proposal whether you are for or against this change. We'd like to hear from you!
cc: @VitalyFedyunin @ejguan @NivekT

I would really like this on my end. I'm writing a RL framework and part of the goal is to pickle a model and deploy it on a robotic system. I may or may not want torch actually installed there (maybe im using onnx?), but still have a pipeline for generically executing code.

Another feedback from our a downstream library (ray):
They previously provided an interface for users to transform ray.Dataset into IterableDataset. As we plan to collaborate to switch it to IterDataPipe, they would have a hard requirement to use torch=1.11.0. In order to provide a flexible requirements, they need to figure out how to fall back to use IterableDataset if torch doesn't meet the condition and torchdata doesn't exist in the environment.
If we make torchdata out-of-tree where DataLoader2 and related utility all go into torchdata, we potentially could set a loose requirements over the version of torch.

I'm working on a downstream library (composer) that has the exact same issue -- we would love to allow users to build datasets with torchdata without hard requirements on the torch version.

I almost forget one of the most important benefits by making TorchData standalone. If we have some changes landed into PyTorch Core that, a dependent changes in TorchData have to wait until the nightly release is updated for PyTorch Core.
On the other hand, if we have BC breaking changes in PyTorch Core, we have to open another PR in TorchData to incorporate such BC breaking then make sure the nightly release shipped for both repos. Otherwise, there is a risk that our downstream libraries like TorchVision/TorchText have red CI for a while.

Want to track the list of features we are currently depending on PyTorch Core:

Dataset/IterableDataset
Profiler
default_collate_fn
Sampler

The features that can be moved to TorchData easily:

typing -> It basically being disabled for now
MapDataPipe/IterDataPipe  -> functional_datapipe
graph utils

In order to make TD standalone, we may need to reverse a few dependencies from TD -> PyTorch to PyTorch -> TD.

For BC, let DataLoader being able to handle DataPipe

Just for record, when decoupled, expecttest can be removed from our test dependency.

100% support this. I primarily use torch but dang is the data loading library useful

I would love if TorchData becomes standalone. It could be the go to place for PyTorch Ecosystem libraries, since it essentially is along the same concept as torch.Dataset.
All in all it would be genuinely amazing if TorchData becomes standalone.
Rooting for this :)

Hey there, any plans to make it as a separate python package w/o torch deps?

I like the concept of the data pipes and could imagine using it more generally. Pytorch is a big enough project so that with support from it, a stand-alone library could get a lot of community usage also in other projects. As it is, with the heavy pytorch dependency, it is impossible to use it in other projects - meaning the whole datapipes concept will be useful only for pytorch.
So yes - I think making it stand-alone would be a great idea. And the few functions that do require pytorch could be optional dependencies.

I support the library removing dependencies with Torch. Then it would be better if there was a shared memory method to pass the numpy array. Because the spawn process consumes a lot of memory when using pytorch and multiprocess.
The abstraction of the library is good, and it would be better if it was generic enough.

I support this endeavor.
Instead of completely removing torch as dependency, I would welcome it already, if all parts of trochdata were contained in this package instead of being split between torchdata and torch.util.data.

Hi, I would also be in favour of this
As @VIVelev above says, this would be exceptionally useful for the JAX ecosystem which has made an active choice not to support dataloading, e.g. their getting started tutorials use either:

PT dataloaders: https://jax.readthedocs.io/en/latest/notebooks/Neural_Network_and_Data_Loading.html
TF datasets: https://jax.readthedocs.io/en/latest/notebooks/neural_network_with_tfds_data.html

I really need torchdata as a standalone library! Can you please consider doing this?

Just throwing my two cents here - I'm also using TorchData for projects that do not use Torch so not having to import a huge package like Torch would be very helpful.


Setting board doesn't seem to work

I tried changing the method to the following:
robot.respond(/set board to [\\"\\'](.+)[\\"\\']$/i, function (msg) {
        ensureConfig(msg.send);
        msg.send("I've ensured your config");
        var room = findRoom(msg);
        msg.send("I think your room is: " + room);
        var boardName = msg.match[1];
        msg.send("I think your board name is: " + boardName);
        saveBoard(room, boardName);
        msg.send("Ok, from now on this room is connected to the trello board: " + boardName);
    });

I never get any of those messages so that leads me to believe that the problem is either in ensureConfig or the regex used in this respond.
I can have it list boards (although it crashes hubot #2 some times) so I don't think it's the ensureConfig method.  Here are the messages I tried to get it to set the board for the room:
hubot set board to “DevOps"
hubot set board to ‘DevOps'
hubot set board to ‘devops
hubot set board to “devops"
hubot set board to “‘DevOps’"

None of these work for me.  Thoughts?

Had the same error here @nwalke, and it's the regex. I just changed it and tested it like this:
robot.respond(/set board to (.+)/i, function (msg) {
And it works. (my fork)


Fixed symlink and modified Popen command to use magick command

This is to fix the issue #2, where in ImageMagick version 7, the convert command is deprecated in favor of just magick. Additionally, the symlink was fixed to no longer have a \n suffix.

thanks - now merged


[5.0 beta] Unclear cause of CJS deprecation warning

Describe the bug
I am seeing a The CJS build of Vite's Node API is deprecated. warning, but without giving any kind of trace, it's hard to know for sure what's causing it.  I found it, but I could see others being confused by it, especially if it's being triggered by a tool that is requiring vite, not the user.  Maybe it would be possible to add at least a filename that triggered the warning?
Reproduction
N/A
Steps to reproduce
No response
System Info
sh: envinfo: command not found

Used Package Manager
pnpm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

You can get the trace with VITE_CJS_TRACE=true
https://main.vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated

Thanks, I guess I should have read the documentation. 😳


Refactoring and cmd parsing changes

Move command line parsing and help/usage to library
Move common elements of tools to OSSGadget (partial)
Make OutputBuilder extensible for possibly add other formats

My comments were on an older version of the code. It doesn't update the references so that the comments still make sense.
Sent from ProtonMail mobile
-------- Original Message --------
On Jun 15, 2020, 1:35 PM, Suraj Jacob wrote:

@jacobmsft commented on this pull request.

In src/oss-health/HealthTool.cs:

     {

       if (args == null)

       var healthTool = new HealthTool();

       await healthTool.ParseOptions<Options>(args).WithParsedAsync(healthTool.RunAsync);

   }

   private void AppendOutput(IOutputBuilder? outputBuilder, PackageURL purl, HealthMetrics? healthMetrics)

not nullable locally, not sure why PR is showing nullable...checking
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or unsubscribe.