Include span for Events, not just BrokenLinks

Rustdoc currently has code that looks like this (yes, it's awful): https://github.com/rust-lang/rust/blob/6f2e1c65933702186cc681a3772862afa77dd632/src/librustdoc/html/markdown.rs#L1076-L1088
Originally I was hoping I could get rid of it now that BrokenLinks have spans. But the spans are only for the broken links, and rustdoc doesn't get them for [parenthesized](links). Is it possible to add that info to Event? I think that would allow removing it from BrokenLink too, but I'm not 100% sure about that.
As a side note, it looks like pulldown includes the [] in the span - is that intentional? Rustdoc only wants the URL itself, which isn't currently possible: consider [inline][link]. The - in the diff is rustdoc's hacky generated span, the + is pulldown's span.
 LL | /// docs [label][with#anchor#error]
-   |                  ^^^^^^^^^^^^^^^^^ contains invalid anchor
+   |          ^^^^^^^^^^^^^^^^^^^^^^^^^^ contains invalid anchor

I believe into_offset_iter gives the Range for each Event. Rustdoc uses that in a few places already.

Oh look at that! Thanks, I just didn't read the docs carefully enough :)


When use relative path for embedding Image files.

I run into the issue , when embedding images with relative path it does not displayed.
Ex. embed html:
embed('attachment/page1.html', 'text/plain', 'first_page_HTML')

Works just fine in report
embed('attachment/page1.png', 'image/png', 'first_page_PNG')

does NOT work,
embed('/home/user/test/attachment/page1.png', 'image/png', 'first_page_PNG')

I thing embed method should convert it to the full path as it's adding "data:image/png;base64" to srs description

same as #775


Remove now-cd from dev deps

401 Access denied.

Make sure you have added the required API tokens to travis settings: https://github.com/siddharthkp/now-cd#install

Can you create an issue to remind me to handle infinite retries 🙈

Hmmm apparently the problem right know is that the project is not public, even I'm passing --public flag
$ npx now-cd --public --alias "master=changes.now.sh"
 NOW CD  Deployment started
unhandledRejection { Error: Command failed: /bin/sh -c /home/travis/.npm/_npx/3183/lib/node_modules/now-cd/node_modules/.bin/now -t [secure]  -e NODE_ENV=production
> Error! Unexpected error. Please try again later. (
You are on the OSS plan. Your code and logs will be made public. If you agree with that, please run again with --public.)

https://travis-ci.org/Kikobeats/changelog.now.sh/jobs/366467647#L3399

I think now-cd not support ---public yet 🤔

Oh yeah, it doesn't!
If you'd like this is the right place to add it: https://github.com/siddharthkp/now-cd/blob/master/command.js


is ccmValidateBlockForm still working ?

I am having some hard time to figure out, but it seems that ccmValidateBlockForm is gone too, the only remaining I found in the 5.7 code seems to be legacy code (that needs update), and nowhere else in the core …
What is the new way to call some js on block edit/add form submit event?

FYI We have another issue on this one that could use some discussion. https://github.com/concrete5/concrete5-5.7.0/issues/1099#issuecomment-59118512


Identify and accuse double proposal accusation using the monitoring system

As a validator I want to have the system accuse validator who double propose automatically.
A double proposal during consensus is an attempt to fork the network. This is never a valid action for a validator to take. The currently code for this accusation can be found here:
bridge/AccusationMultipleProposalFacet.t.sol at main · MadBase/bridge
Acceptance Criteria:
All created unit tests pass. Double proposals are caught in a running system. No legitimate proposals are incorrectly flagged, leading to an accusation.

Blocked on #373


docker-compose version parsing is very naïve

The code that parses the docker-compose file version https://github.com/buildkite-plugins/docker-compose-buildkite-plugin/blob/7a84e183ef16722671dc7a2889f2bb983ce25356/lib/shared.bash#L78-L81 will break if, for instance, the user adds an extra space before the version string. It’ll also fail if the version is not specified as a string, and has no protections against matching a string specified in any key ending in version.
It also lacks any sort of fallback or error message if it fails to find a version number.

#68 fixes these, and I've added a Readme item on how to run the tests too.


Add initial GKE Nodes Tab

Tasks

[x] Show node pools
[x] Node Pool Name CTA to GCloud console
[x] Show Nodes
[x] Node Name CTA to GCloud console

@pastuxso I'm getting a large stack trace and no rendered output. Not sure what I'm doing wrong. Ideas?
Uncaught TypeError TypeError: Cannot destructure property 'clusterBasics' of 'this._clusterDetails' as it is undefined.
    at renderClusterBasics (/Users/sourishkrout/Projects/stateful/oss/vscode-runme/src/client/components/gcp/gke/cluster.ts:101:13)
    at renderCluster (/Users/sourishkrout/Projects/stateful/oss/vscode-runme/src/client/components/gcp/gke/cluster.ts:526:22)
    at render (/Users/sourishkrout/Projects/stateful/oss/vscode-runme/src/client/components/gcp/gke/cluster.ts:559:19)
    at update (/Users/sourishkrout/Projects/stateful/oss/vscode-runme/node_modules/lit-element/development/lit-element.js:117:1)
    at performUpdate (/Users/sourishkrout/Projects/stateful/oss/vscode-runme/node_modules/@lit/reactive-element/development/reactive-element.js:854:1)
    at scheduleUpdate (/Users/sourishkrout/Projects/stateful/oss/vscode-runme/node_modules/@lit/reactive-element/development/reactive-element.js:765:1)
    at __enqueueUpdate (/Users/sourishkrout/Projects/stateful/oss/vscode-runme/node_modules/@lit/reactive-element/development/reactive-element.js:738:1)
    --- await ---
    at requestUpdate (/Users/sourishkrout/Projects/stateful/oss/vscode-runme/node_modules/@lit/reactive-element/development/reactive-element.js:701:1)
    at __initialize (/Users/sourishkrout/Projects/stateful/oss/vscode-runme/node_modules/@lit/reactive-element/development/reactive-element.js:495:1)
    at ReactiveElement (/Users/sourishkrout/Projects/stateful/oss/vscode-runme/node_modules/@lit/reactive-element/development/reactive-element.js:481:1)
    at LitElement (/Users/sourishkrout/Projects/stateful/oss/vscode-runme/node_modules/lit-element/development/lit-element.js:86:1)
    at Clusters (/Users/sourishkrout/Projects/stateful/oss/vscode-runme/out/client.js:8033:9)
    at _clone (/Users/sourishkrout/Projects/stateful/oss/vscode-runme/node_modules/lit-html/development/lit-html.js:692:1)
    at _commitTemplateResult (/Users/sourishkrout/Projects/stateful/oss/vscode-runme/node_modules/lit-html/development/lit-html.js:997:1)
    at _$setValue (/Users/sourishkrout/Projects/stateful/oss/vscode-runme/node_modules/lit-html/development/lit-html.js:853:1)
    at render (/Users/sourishkrout/Projects/stateful/oss/vscode-runme/node_modules/lit-html/development/lit-html.js:1459:1)
    at update (/Users/sourishkrout/Projects/stateful/oss/vscode-runme/node_modules/lit-element/development/lit-element.js:122:34)
    at performUpdate (/Users/sourishkrout/Projects/stateful/oss/vscode-runme/node_modules/@lit/reactive-element/development/reactive-element.js:854:1)
    at scheduleUpdate (/Users/sourishkrout/Projects/stateful/oss/vscode-runme/node_modules/@lit/reactive-element/development/reactive-element.js:765:1)
    at __enqueueUpdate (/Users/sourishkrout/Projects/stateful/oss/vscode-runme/node_modules/@lit/reactive-element/development/reactive-element.js:738:1)
    --- await ---
    at requestUpdate (/Users/sourishkrout/Projects/stateful/oss/vscode-runme/node_modules/@lit/reactive-element/development/reactive-element.js:701:1)
    at __initialize (/Users/sourishkrout/Projects/stateful/oss/vscode-runme/node_modules/@lit/reactive-element/development/reactive-element.js:495:1)
    at ReactiveElement (/Users/sourishkrout/Projects/stateful/oss/vscode-runme/node_modules/@lit/reactive-element/development/reactive-element.js:481:1)
    at LitElement (/Users/sourishkrout/Projects/stateful/oss/vscode-runme/node_modules/lit-element/development/lit-element.js:86:1)
    at GCPViews (/Users/sourishkrout/Projects/stateful/oss/vscode-runme/src/client/components/gcp/index.ts:15:8)
    at renderOutputItem (/Users/sourishkrout/Projects/stateful/oss/vscode-runme/src/client/index.ts:141:39)
    at renderOutputItem (09886e3b9dn7h1l5r9dnqvvhbqre5rq3lddngc44i9aspp77gjcp/notebookWebviewPreloads.js:3:24303)
    --- await ---
    at h (09886e3b9dn7h1l5r9dnqvvhbqre5rq3lddngc44i9aspp77gjcp/notebookWebviewPreloads.js:3:28884)
    at render (09886e3b9dn7h1l5r9dnqvvhbqre5rq3lddngc44i9aspp77gjcp/notebookWebviewPreloads.js:3:28448)
    at render (09886e3b9dn7h1l5r9dnqvvhbqre5rq3lddngc44i9aspp77gjcp/notebookWebviewPreloads.js:3:39555)
    at renderOutputElement (09886e3b9dn7h1l5r9dnqvvhbqre5rq3lddngc44i9aspp77gjcp/notebookWebviewPreloads.js:3:36290)
    at renderOutputCell (09886e3b9dn7h1l5r9dnqvvhbqre5rq3lddngc44i9aspp77gjcp/notebookWebviewPreloads.js:3:31222)
    --- await ---
    at <anonymous> (09886e3b9dn7h1l5r9dnqvvhbqre5rq3lddngc44i9aspp77gjcp/notebookWebviewPreloads.js:3:21209)
    at c.set.queue (09886e3b9dn7h1l5r9dnqvvhbqre5rq3lddngc44i9aspp77gjcp/notebookWebviewPreloads.js:3:27015)
    at enqueue (09886e3b9dn7h1l5r9dnqvvhbqre5rq3lddngc44i9aspp77gjcp/notebookWebviewPreloads.js:3:26996)
    at <anonymous> (09886e3b9dn7h1l5r9dnqvvhbqre5rq3lddngc44i9aspp77gjcp/notebookWebviewPreloads.js:3:21182)
    --- postMessage ---
    at <anonymous> (09886e3b9dn7h1l5r9dnqvvhbqre5rq3lddngc44i9aspp77gjcp/index.html?id=6cb0e3f0-1164-4d88-8e15-db6137fa0768&origin=fcd78bff-f7d9-4cc8-b1ad-e1dab4026fe3&swVersion=4&extensionId=&platform=electron&vscode-resource-base-authority=vscode-resource.vscode-cdn.net&parentOrigin=vscode-file%3A%2F%2Fvscode-app&purpose=notebookRenderer꞉18:30:1213:45)
    at HostMessaging.channel.port1.onmessage (09886e3b9dn7h1l5r9dnqvvhbqre5rq3lddngc44i9aspp77gjcp/index.html?id=6cb0e3f0-1164-4d88-8e15-db6137fa0768&origin=fcd78bff-f7d9-4cc8-b1ad-e1dab4026fe3&swVersion=4&extensionId=&platform=electron&vscode-resource-base-authority=vscode-resource.vscode-cdn.net&parentOrigin=vscode-file%3A%2F%2Fvscode-app&purpose=notebookRenderer꞉18:30:323:8)

@sourishkrout Thank you for reviewing. I've just pushed a change to infer the Kubectl context. It should solve the reported issue.


Error: The subscription '{id}' could not be found.

Our subscription is in the Azure Government environment, specifically GCC High.
My account is an Owner on the subscription.
Other VS Code extensions for Azure work fine, e.g. API Management and Resources.

@uRsIoNceNEdO, can you please at which step this error occurs while loading subscriptions or loading automation accounts under tree?
There can be error in authentication with Gov Cloud.
Thanks

@uRsIoNceNEdO  This issue has been resolved in beta version: can be installed as pre-release from marketplace. Do share feedback on marketplace or reopen issue if problem persists. The beta version be pushed as default by next week.

This is fixed in newer versions.
Thanks


UI needs to store collectionClassName somewhere in the mapping definition

With a quick look it seems UI doesn't persist collectionClassName in the mapping definition. It seems it looks as if working by instantiating java.util.LinkedList anyway at target side (#430), but it would fail even with java.util.ArrayList.

Not really, DocumentJavaFieldWriter should resolve it via getter/setter signature or field type.


sql: add crdb_internal.show_create_all_tables builtin

PR: https://github.com/cockroachdb/cockroach/pull/60154
From release notes:

Add the builtin crdb_internal.show_create_all_tables, which takes in a database name (STRING) and returns a flat log of all the CREATE TABLE statements in the database followed by ALTER statements to add constraints. The output can be used to recreate a database. This builtin was added to replace old dump logic. [#60154][#60154] {% comment %}doc{% endcomment %}

Fixed by https://github.com/cockroachdb/docs/pull/9907.


Shutdown on interrupt signal to be configurable

Is your feature request related to a problem? Please describe.
I would like to be able to continue proccessing requests for some time after receving an interrupt, and decide in my application when to shutdown the server.
Currently as soon as an interrupt signal is fired, I cannot override the behavior of gnet to prevent a shutdown.
Describe the solution you'd like
A new field in the options when calling the Serve function, just a boolean to turn off this default behaviour
Describe alternatives you've considered
Couldn't find any workarounds, because my application still needs to listen for the interrupt signal, to eventually shutdown the server, just not immediately.

I believe #148 is what you were looking for, please try it out.

I can't find anything in that PR regarding this feature request.
I mean specfically this code block, should be made optional because a user cannot override this behavior. Also don't think it makes sense for a library to be listening to interrupts to the application, its better that the application handles interrupts on its own.
https://github.com/panjf2000/gnet/blob/36258e289be2ed37ef11181a99ef385920eed98c/server_unix.go#L259-L268

You may get a point here, I'll consider removing this signal handling part.

Another vote for this. I use uberfx as my 'app server' framework. I run gnet within it. uberfx handles the signal events for me and provides me with a standard lifecycle for all the modules in my app. All I need is the ability to call something like EventServer.Stop().
There is probably some twist in this which is the ability to wait for pending connections to be processed before shutting down or to 'force' shutdown.

@panjf2000 Fantastic. Thanks.

@panjf2000 "2020-11-17T18:56:43.105-0800	INFO	gnet@v1.3.2-0.20201117173319-c1245fb4b43f/reactor_bsd.go:40	Main reactor is exiting due to error: server is going to be shutdown"
It isn't really an error. =)

Also... not the end of the world, but the API still feels a little funny with this gnet singleton. It seems like if you had gnet.Serve() return some object, then I would call .Stop() on that object.... instead of passing in the protoAddr to .Stop().... not the end of the world though.

Also... not the end of the world, but the API still feels a little funny with this gnet singleton. It seems like if you had gnet.Serve() return some object, then I would call .Stop() on that object.... instead of passing in the protoAddr to .Stop().... not the end of the world though.

That's indeed the conventional way, but only for the Server instance that is external and contains exported fields, while the gnet server instance is internal and there are no exported fields for users to manipulate for safety. So it's unnecessary to return a gnet internal server instance from gnet.Serve(), then the protoAddr becomes the only identifier for each gnet server.

Yup, up to you. Thanks for the explanation. I'm just not a huge fan of singletons... makes writing tests harder and tends to make code more brittle.

Why would you say singleton? I don't quite get it, care to explain a bit?

https://en.wikipedia.org/wiki/Singleton_pattern
gnet.Serve() keeps state 'serverFarm' in a 'global' gnet object. You've basically got a globally namespaced object.
This is why you have to have a 'serverFarm' managed internally within a serve object.
For example, what if I wanted my own implementation of a serverFarm that wasn't stored in a slow sync.Map or I wanted to store other data with each 'server'? How would I do that?
Again, it all falls into the configurability of your library. You could make things a lot more flexible with a different API design.


TCPSocket connect_nonblock sometimes not working.

Getting the following error:
Errno::EALREADY: Operation already in progress - connect(2) for <IP_ADDRESS>:53
	/Users/samuel/.rvm/gems/ruby-2.1.2/gems/celluloid-io-0.15.0/lib/celluloid/io/tcp_socket.rb:85:in `connect_nonblock'
	/Users/samuel/.rvm/gems/ruby-2.1.2/gems/celluloid-io-0.15.0/lib/celluloid/io/tcp_socket.rb:85:in `initialize'

Perhaps we need to handle Errno::EALREADY in a similar manor to Errno::EINPROGRESS in tcp_socket.rb?

@ioquatix you've released RubyDNS, so is this no longer an issue?

Please reopen if this is unresolved, but if it is not resolved, it seems like Celluloid::IO and not Celluloid

Yes this is still an issue.

@ioquatix right on -- seems Celluloid::IO related?

Yeah, I don't know why I originally put it here.

I believe the 2nd comment I made was an appropriate fix but it's been such a long time and it was one of the first bugs I reported, it then lead into the "ArgumentError: this IO is already registered with selector" which is a bug which spanned celluloid, celluloid-io and nio4r - a huge rabbit hole. This bug is relatively simple. It should be fixed. I didn't have the experience at the time to feel confident in making a PR because I didn't know if there were any side effects of my change.

Perhaps the first step is to write a failing spec. I wonder if the JRuby behaviour/hack is still required?

It's required for older versions of JRuby

Do we know what version it was fixed in?
Sometimes when I had bugs in older versions I'd have a separate file which would monkey patch the fix. Then, at an appropriate time in the future you'd just remove the file and the corresponding require. It means the main code path is fast for modern implementations and a fix is available for older implementations but the modern code path isn't messed up with lots of different hacks and it's easy to remove the hacks without spending a lot of time testing the code.
The only downside is really having a separate file in terms of maintenance but I actually see that as a plus because it makes the buggy functionality obvious.


rs2_pipeline_start config error

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
{  D400 }

Firmware Version
(<IP_ADDRESS>)

Operating System & Version
Linux (Ubuntu 16.04)

Kernel Version (Linux Only)
(4.4.38-tegra)

Platform
Jetson TX2

SDK Version
{ 2.0 }

Language
{C++/opencv}

Segment
{Robot}

Issue Description
<Trying to implement left and right IR images for stereo vision. I am implementing the same code as the thread in #1140.
int width = 480;
int height = 270;
int fps = 6;
rs2::config config;

config.enable_stream(RS2_STREAM_INFRARED, 1, width, height, RS2_FORMAT_Y8, fps);
config.enable_stream(RS2_STREAM_INFRARED, 2, width, height, RS2_FORMAT_Y8, fps);

// start pipeline
rs2::pipeline pipeline;
rs2::pipeline_profile pipeline_profile = pipeline.start(config);

Running it I encounter an error on the line with pipeline.start(config);
RealSense error calling rs2_pipeline_start_with_config(pipe:0x51cbf0, config:0x4675f0):
Failed to resolve request. No device found that satisfies all requirements
Looking into the error I tried commenting out one of IR cameras and the pipeline worked. Error happens specifically when I have left and right IR cameras in my config.

I experience the same issue, on Windows 10, D435, SDK 2.0.
With the following code:
rs2::context ctx;
auto list = ctx.query_devices();
if (list.size() == 0)
throw std::runtime_error("No device detected. Is it plugged in?");
rs2::pipeline pipe;
rs2::config cfg;
cfg.enable_stream(RS2_STREAM_COLOR, 1920, 1080, RS2_FORMAT_BGR8, 15);
cfg.enable_stream(RS2_STREAM_DEPTH, 1280, 720, RS2_FORMAT_Z16, 15);
rs2::pipeline_profile profile = pipe.start(cfg);
I got the following error message:
"RealSense error calling rs2_pipeline_start_with_config(pipe:000001F6332C9860, config:000001F6332C9620):
Couldn't resolve requests."
The same code works fine in Ubuntu 16.10.

[Realsense Customer Engineering Team Comment]
Hi arikyueh,
We tested your configuration off SDK 2.15, by using rs-capture example and modifying to be with your settings.
There is NO issue.
Can you please test it with RealSense Viewer and configure to be streaming 2 infrared streams w/ the configuration, and see if there is any issue there?
Thanks!

[Realsense Customer Engineering Team Comment]
Hi ywjia,
Guess you missed some digits in the SDK information that you posted here.
Not sure which SDK version you used.
Can you please download the same version of RealSense View executable file from the github, and test it out with the same configuration with the viewer?
I don't have issue here with various RealSenseViewer versions.
Also can you try to separate depth and color, and test one by one to see which causes the issue? Please let us know.
Thanks!

[Realsense Customer Engineering Team Comment]
Hi ywjia,
Thanks for the update. Glad to hear that the problem is solved after your upgrade.
Thanks!

[Realsense Customer Engineering Team Comment]
Hi arikyueh,
Do you still need help on this one?
Thanks!

It should be noted that I had the camera or driver get into a bad state which cased an unknown exception to be thrown every time I called pipe.start. The RealSense viewer would freeze when trying to connect to the camera in this state.  I re-started (not power cycled) windows, pulled the USB cable out of the camera several times and could not get it to work. The solution was pulling the USB cable out of the computer itself (as strange as that may seem). I suspect a real power cycle on the PC would have fixed it too. I have seen other instances where a dangling USB cable caused problems on other devices.


Unknown PostProcessor type: Sequence

It seems that the following post-processor block in tokenizer.json is not supported:
  "post_processor": {
    "type": "Sequence",
    "processors": [
      {
        "type": "ByteLevel",
        "add_prefix_space": true,
        "trim_offsets": false,
        "use_regex": true
      },
      {
        "type": "TemplateProcessing",
        "single": [
          {
            "SpecialToken": {
              "id": "<|begin_of_text|>",
              "type_id": 0
            }
          },
          {
            "Sequence": {
              "id": "A",
              "type_id": 0
            }
          }
        ],
        "pair": [
          {
            "SpecialToken": {
              "id": "<|begin_of_text|>",
              "type_id": 0
            }
          },

It throws the following error:
Unknown PostProcessor type: Sequence
You can find the specific pain point here, at Tokenizers/PostProcessor.swift:39
struct PostProcessorFactory {
    static func fromConfig(config: Config?) -> PostProcessor? {
        guard let config = config else { return nil }
        guard let typeName = config.type?.stringValue else { return nil }
        let type = PostProcessorType(rawValue: typeName)
        switch type {
          case .TemplateProcessing: return TemplateProcessing(config: config)
          case .ByteLevel         : return ByteLevelPostProcessor(config: config)
          case .RobertaProcessing : return RobertaProcessing(config: config)
          default                 : fatalError("Unsupported PostProcessor type: \(typeName)")
        }
    }
}

The original implementation in Rust can be found here: https://github.com/huggingface/tokenizers/blob/25aee8b88c8de3c5a52e2f9cb6281d6df00ad516/tokenizers/src/processors/sequence.rs#L18-L36
Should be something simple and I will look for a solution over the weekend, but maybe it's something you've already found.
You can assign it to me and I will have it ready as soon as possible.

Checking hf transformers I have seen that BertProcessing should also be added.

This is needed for the Llama 3.2 models that were released today. It looks like this isn't a huge thing, so I'll see if I can port the Rust implementation from tokenizers to Swift.

https://github.com/huggingface/swift-transformers/pull/129


A couple of questions about colums

Im working on a project wi6h tbe library and i have hit a few issues.

Im using SetState and GetState to serialize the report config to a database, but it is not saving the state of the filters set on the filter box accessible from the little arrow on the dragable column.  If that is not avilable is there anyway to enumerate all the columns and get/set both the filter options and sort options so i can save them seperatly.

Can I disable the dropdown filter box on specific columns, high cardinality numeric values in particular its a problem with. Its probably wasting a lot of time  generating unique value lists for a filter, for example a flag in the dataSchema definition that turns it off for that column.

Can i style the column buttons differently if they have a fllter set, ie not all values are checked. So i can embolden them, add a wider border or change colour.

is it possible to sort the column labels in the drop souce box to stop them dancing around when touching them with a mouse.

I found answers  to 3 and 4 , still stumped on 1 and 2.


Nan test case average

Hello,
I am trying to evaluate my model's generated codes using scripts in eval. However, for a particular problem, results[index] turns out to be an empty array as a result of which calculating mean in print_results() gives nan. How should I handle this case?

Curious what your results array looks like or at least the relevant portion.
Here's the example results that the code gives us: https://github.com/hendrycks/apps/blob/main/eval/test_one_solution.py#L19

This is my results array: {4530: [[False, False, True]], 4531: [[False, True, False]], 4532: [[False, True, False]], 4533: [[-2]], 4534: [[]]}

Since I'm not sure how that was generated the easiest thing would be to post process your results and just convert any of the [[]] to [[-2]].

Any updates on this issue? Otherwise I'll close it soon.

I just did what you suggested, no more updates.


#short-training-materials-for-offa-r-users-group

The files are materials used for short training in R at Offa-R-Users-Group (ORUG) meetings.
The files are

DATA-SCIENCE-AN-OVERVIEW-IN-R
INTRODUCTION-TO-PROBABILITY-USING-R
INTRODUCTION-TO-R-FOR-DATA-SCIENCE-PART-I
SELECTED-DESCRIPTIVE-AND-INFERENTIAL-STATISTICS-IN-R-FOR-UNDERGRADUATE-PROJECT
Test-for-the-Assumptions-of-Linear-Regression-Using-R

Short training materials in R at Offa-R-Users-Group (ORUG) meetings.


Add support for the PostgreSQL citext type

This PR adds support for postgres citext type.

Thanks for the PR. I'll review it when I have some time.

Applied upstream, thanks


PHP FPM , drupal module extlink, and target="_blank"

Background:
When I switched from using mod_php (apache) to php fpm I noticed all of my a tags had an attribute of target="_blank". This was not directly caused by DrupalVM it was caused by the contrib module extlink.
Questions:
Does something related to the proxy pass in the apache configuration make extlink think that every link is external?
Should this be fixed by DrupalVM or the contrib module?
Temporary Solution:
Disable the contrib module and links are normal again
I posted the question additionally in the contrib module issue queue:
https://www.drupal.org/node/2679977

Doesn't seem likely. For debugging purposes what domain do you use and what does the following return if you run in the browser console:
var pattern = /^(([^\/:]+?\.)*)([^\.:]{4,})((\.[a-z]{1,4})*)(:[0-9]{1,5})?$/;
console.log(window.location.host.replace(pattern, '$3$4'));
console.log(window.location.host.replace(pattern, '$1'));

@oxyc : The above code returned the exact same domain (with extlink disabled):
drupalvm.dev
drupalvm.dev
Do you think I need to reenable the broken module or it shouldn't matter?

the exact same? That's odd, the first one should be drupalvm.dev while the second should be empty (or www).

"drupalvm.dev"

I am using google chrome

Well that's just very strange. If i'm on http://drupalvm.dev and run
var pattern = /^(([^\/:]+?\.)*)([^\.:]{4,})((\.[a-z]{1,4})*)(:[0-9]{1,5})?$/;
console.log("host: " + window.location.host.replace(pattern, '$3$4'));
console.log("sub: " + window.location.host.replace(pattern, '$1'));

It returns
host: drupalvm.dev                                                     VM730:3
sub:                                                                   VM730:4

Earlier did the second console.log return drupalvm.dev or did you mean the domain you were using?
If that's what you meant the only way I can see this happening based on the code is if right-hand condition (extInclude && url.match(extInclude) evaluates to true at http://cgit.drupalcode.org/extlink/tree/extlink.js#n69.
This only evaluates to true if you've set a regex value for 'Include links matching the pattern' in the settings.

var pattern = /^(([^/:]+?.))([^.:]{4,})((.[a-z]{1,4}))(:[0-9]{1,5})?$/;
console.log("host: " + window.location.host.replace(pattern, '$3$4'));
console.log("sub: " + window.location.host.replace(pattern, '$1'));
VM16165:3 host: drupalvm.dev
VM16165:4 sub: drupalvm.dev

How about
var pattern = /^(([^\/:]+?\.)*)([^\.:]{4,})((\.[a-z]{1,4}))(:[0-9]{1,5})?$/;
console.log("host: " + window.location.host.replace(pattern, '$3$4'));
console.log("sub: " + window.location.host.replace(pattern, '$1'));

var pattern = /^(([^\/:]+?\.)*)([^\.:]{4,})((\.[a-z]{1,4}))(:[0-9]{1,5})?$/;
console.log("host: " + window.location.host.replace(pattern, '$3$4'));
console.log("sub: " + window.location.host.replace(pattern, '$1'));
VM16250:3 host: drupalvm.dev
VM16250:4 sub: drupalvm.dev

So the issue is that the regex match fails and replaces nothing. Why this is the case I do not know :/ Looks correct to me.

@oxyc Thanks for your help, seems we know something about the issue now.

Which operating system and chrome version are you using? I could test it in browserstack.

OSX Version 10.9.5
Chrome Version 48.0.2564.116 (64-bit) - Which is actively updating itself as we speak

Test on Mavericks with Chrome 48 and still unable to reproduce :/ You might try disabling extensions or trying some other browser. I'm out of ideas otherwise. Sorry, hope you get it working.

@oxyc Thanks again for your help.  To give further information I don't think it is the browser or the JS or the regex.  Here is a test from the same OS and browser against www.google.com and another test against drushcommands.com
var pattern = /^(([^/:]+?.))([^.:]{4,})((.[a-z]{1,4}))(:[0-9]{1,5})?$/;
console.log(window.location.host.replace(pattern, '$3$4'));
console.log(window.location.host.replace(pattern, '$1'));
VM192:3 google.com
VM192:4 www.
var pattern = /^(([^/:]+?.)*)([^.:]{4,})((.[a-z]{1,4}))(:[0-9]{1,5})?$/;
console.log("host: " + window.location.host.replace(pattern, '$3$4'));
console.log("sub: " + window.location.host.replace(pattern, '$1'));
VM121:3 host: drushcommands.com
VM121:4 sub:
I am thinking there is something that changed in the configuration of the server causing this because this site wasn't having any problems with DrupalVM before.  The only change that I can isolate is mod_php versus php fpm.

I don't know if it helps diagnose the problem but when I go to the local IP address (versus the domain name) of the VM I am getting a plain text return of index.php
My guess is the problem is here:
ProxyPassMatch ^/(..php(/.)?)$ "fcgi://<IP_ADDRESS>:9000{{ drupal_core_path }}"

Because I'm bored of regular work and miss regexes I wanted to walk through it :)
// Assuming
var pattern = /^(([^\/:]+?\.)*)([^\.:]{4,})((\.[a-z]{1,4})*)(:[0-9]{1,5})?$/;
console.log("full host: " + window.location.host); // drupalvm.dev
console.log("host: " + window.location.host.replace(pattern, '$3$4')); // drupalvm.dev
console.log("sub: " + window.location.host.replace(pattern, '$1')); // drupalvm.dev

// Which is equal to:
var pattern = /^(([^\/:]+?\.)*)([^\.:]{4,})((\.[a-z]{1,4})*)(:[0-9]{1,5})?$/;
console.log("full host: drupalvm.dev"); // drupalvm.dev
console.log("host: " + "drupalvm.dev".replace(pattern, '$3$4')); // drupalvm.dev
console.log("sub: " + "drupalvm.dev".replace(pattern, '$1')); // drupalvm.dev

// As `drupalvm.dev".replace(pattern, '$3$4')` and `"drupalvm.dev".replace(pattern, '$1')`
// return the same even with the different subgroups, it means the regex failed to match
// and no replacement has been done.

// Breaking down the regex:
^ // beginning of string
(([^\/:]+?\.)*) // arbitrary amount of subdomains, optional
([^\.:]{4,}) // domain without TLD
((\.[a-z]{1,4})*) // arbitrary amount of TLDs, optional
(:[0-9]{1,5})? // optional port
$ // end of string

// Because regexes are greedy this will be read from right to left
// So let's begin
$6. (:[0-9]{1,5})? // Optional port, Matches nothing

// The inner group, a set of characters between 1-4 chars, prefixed by a dot and
// limited to a-z. Required.
$5. (\.[a-z]{1,4}) // Matches `.dev`

// The combination of all inner groups, will try to match as much as possible, but
// limits itself to a successful regex. As there's only one `.` character in the host it
// only matches one inner group.
$4. ((\.[a-z]{1,4})*) // Matches: `.dev`

// A character set of 4 or more characters prefixed by `.` or `:`
// Sidenote this is a bug in their regex. My own domain has 3 chars :P
$3. ([^\.:]{4,}) // Matches: `drupalvm`

// The inner group, any set of characters more than 1 that's not `.` or `:` and then
// ends with a `.`. Optional and non-greedy.
$2. ([^\/:]+?\.) // Matches: nothing
// Combination of all inner groups, will try to match as much as possible, but limits itself to a successful regex. Optional.
$1. (([^\/:]+?\.)*) // Matches: nothing

$6 === ''
$5 === '.dev'
$4 === '.dev'
$3 === 'drupalvm'
$2 === ''
$1 === ''

Why this fails in your case is not part of this exercise. No clue. Maybe some weird character encoding?
I'm probably entirely incorrect about all my assumptions here, and the problem is probably something entirely else as you say. But to humour me could you paste the result of:
window.location.host.split('').reduce(function(a, b) {
 return a + '\\' + b.charCodeAt(0);
}, '');

@oxyc Congratulations, you found the bug!!!  Nothing to do with DrupalVM so we can close the issue here.
Sidenote this is a bug in their regex. My own domain has 3 chars
I am so sorry for failing to mention this sooner but I was replacing the client's 3 character domain name with drupalvm when posting it here publicly (for privacy reasons - didn't think it made a difference but it does).  You are amazing for finding it!
Are you going to post a patch to the contrib module?

Woohoo awesome! Do you mind posting it?

Posted a proposed patch to fix this in the extlink issue queue:
https://www.drupal.org/node/2679977

@ccjjmartin - Awesome!


Ctrl Shift O not working

VSCode Version: 1.21.0
OS Version: Windows 10

Ctrl Shift O for the Go To Symbol bind used to work for me in VSCode, but now it does nothing. My friend is having the same issue (with no extensions installed). This appears to be similar to https://github.com/Microsoft/vscode/issues/40470
I'm using default bindings:

Nothing showing in the console either.

It depends on the language mode of the editor that is currently open. Not all language support Go To Symbol out of the box. You might need an extension.
What's the language mode of the editor you have open?

Javascript

Does this repo when all extensions are disabled?
Does the Go to Symbol in file command work?

Also, please provide repo steps and some example code

Still occurs with all disabled
Yep, works fine

Actually I think I've just found something interesting. Using http://en.key-test.ru/, when I do Ctrl + Shift + I or Ctrl + Shift + P, the letter keys light up onInputDown but with Ctrl + Shift + O it only detects onInputUp. Same issue with Ctrl + Shift + K and Ctrl + Shift + L but most others seem to be fine.
Running Windows 10.0.14393

@alexandrudima Looks like this is keybinding related? Can you please take a look

I'm having the same issue in Windows 10 10.0.16299 with javascript and typescript files.
I have tested it on a Ubuntu VM and it works fine there.
I don't have any extensions installed.

@Jazcash @jeanp413
Can you please check:

That there are no other keybindings for "ctrl+shift+o" (ctrl+k ctrl+s and search for "ctrl+shift+o"):

What happens when you use the on-screen keyboard:

What does VS Code detect when you press "ctrl+shift+o":

@alexandrudima

Go to symbol in file is the only command bound to "ctrl+shift+o".
Using the on-screen keyboard doesn't get recognized either.
Pressing "ctrl+shift+o" on the Define Keybinding popup just detects "ctrl+shift+" using either the keyboard or the on-screen keyboard.

PS. "ctrl+shift+l" isn't being detected either.

@jeanp413 If "ctrl+shift+o" shows "ctrl+shift+" in the keybinding input, it means that the keypress is not reaching VSCode. Most likely, something installed at the level of the OS is capturing this keybinding.
Are you able to use this keybinding successfully in other software on the same machine?

@alexandrudima you were right.
It was my amd gpu software (Radeon Settings) that was capturing those keybinding.
Thanks.

@Jazcash do you also have an AMD gpu capturing ctrl+shift+o ?

Yep, seems like that's the issue!


Fix incomplete wp core files

Description
Fix failures that happened on WP 6+ due to the fact that the wordpress-develop repo doesn't have all the WordPress core files inside its source folder.
Also added a new --force parameter to force a download of the new WordPress development and core
Types of changes
Improvement and bugfixes
Checklist:

[x] My code is tested.
[x] My code follows the code style set by the project.
[x] I've included documentation for the changes.

Codecov Report

Merging #21 (ac5033e) into develop (0dae29a) will decrease coverage by 4.45%.
The diff coverage is 86.15%.

@@              Coverage Diff              @@
##             develop      #21      +/-   ##
=============================================
- Coverage      90.07%   85.62%   -4.46%
- Complexity        38       45       +7
=============================================
  Files              1        1
  Lines            131      160      +29
=============================================
+ Hits             118      137      +19
- Misses            13       23      +10

Flag
Coverage Δ

unittests
85.62% <86.15%> (-4.46%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/Command/InitCommand.php
85.62% <86.15%> (-4.46%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add editable TLFontFamily style preview, fix typo.

After this change Text in TLLineEdit isn't first property and Base font is.


Update on Payment card number

Hello,
An update on Payment card number was released the 2022-09-26T03:56:01Z. Check for any new Issuer identification number edit. Link to the diff. Here is the summary:

← Previous revision
Revision as of 03:56, 26 September 2022

Line 265:
Line 265:

| 56

| 56

| 16 digits

| 16 digits

|}

== Security measures ==

== Security measures ==

If this Wikipedia's edit does not affect us, just ask for this issue to be close.
In case of trouble, ask for @aloisdg

Same as usual, text update


Unable to write contract exception

Trying the below command throws an exception, Unable to write Contract.

Any reasons why this could happen? How do I troubleshoot?

Hey @fuadop :) It's hard to tell without seeing the full code. 400 seems to be an error on Arweave side not linked to our implementation but of course we will try to help :)  Is it possible for you to share github repo? Maybe sth is wrong with the object you pass as an argument.

Hey @asiaziola, Thanks for the feedback.
Sure I can, It's on this draft PR - https://github.com/CommunityXYZ/community-js/pull/16/files
The line is here - https://github.com/CommunityXYZ/community-js/blob/c006774af0a744463ad411b8c5d91141228365a6/src/community.ts#L312-L321

this is an example of the contract state (initState) being passed to the warp.createContract.deployFromSourceTx method -
 {
      name: 'xxtestxx',
      ticker: 'xtx',
      balances: { QxH3kuDDlkjRqnH4vrFOkyiLbkuvg_2OdklTeRnZojc: 100 },
      vault: {},
      votes: [],
      roles: {},
      settings: [
        [ 'quorum', 0.5 ],
        [ 'support', 0.5 ],
        [ 'voteLength', 2000 ],
        [ 'lockMinLength', 720 ],
        [ 'lockMaxLength', 10000 ]
      ]
    }

Just figured it out @asiaziola , The issue is from the quantity field of the transaction. it was integer instead of string.  See gateway validation for quantity field here - https://github.com/ar-io/arweave-gateway/blob/385ac37feca16e16af6d8095acaa3a90babc59bf/src/gateway/routes/new-tx/index.ts#L47-L51

I'll just go ahead and stringify the quantity field of the transfer object being passed to the deployContractFromSourceTx method. Thanks for your help @asiaziola :heart:

i didn't do too much but I'm glad you figured it out :)


Forward all parameters to aerender #452

As discussed in https://github.com/inlife/nexrender/issues/446.

Looks good so far!
How do you think @brassel is that something worker can benefit from as well?

@inlife I have not used the worker so far. We only use the cli. Is there another file you would like me to edit in the same spirit? I could gladly do that but would ask you to do the testing for that. Ok with you?

Yep, since both cli and worker use the core, you already did most of the job. Only thing left is to pass parameters same way you did in the cli. Take a look at this: https://github.com/inlife/nexrender/blob/master/packages/nexrender-worker/src/bin.js

I have added the requested functionality and will open a new pull request.


Drag tab will cause freeze

version: 1.58.1 (system setup) - 1.59.0-insider
commit: 2aeda6b18e13c4f4f9edf6667158a6b8d408874b
date: 2021-07-13T06:58:28.115Z
Electron: 12.0.13
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 6.1.7601
Tried:

--disable-gpu
disabe all extensions
create data folder make vscode run in portable mode

Drag Welcome tab and Untitled-x tab no problem, but file tab freeze.

/gifPlease
Just to confirm you are using the zip package to use the portable mode right ? Portable mode is not supported with system or user installation.

@deepak1556 Thanks for response. I do use zip with data folder make portable mode. zip from here.

Also got this issue, tried to start vscode with --disable-gpu option and uninstall all extensions, just open one local file and welcome page in vscode, when draging an editor tab to another, vscode just freezes and end up with 'not responding'
Here's my run env:
Version: 1.58.2
Commit: c3f126316369cd610563c75b1b1725e0679adfb3
Date: 2021-07-14T22:10:15.214Z
Electron: 12.0.13
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19041


Support bodies in mvc ProxyExchange delete requests

Calling delete on the ProxyExchange object does not forward the body, even if a body is added to the ProxyExchange.

Are you using the MVC or webflux module?

MVC

That may be a limitation of RestTemplate. I'm not sure.

I have a mapping like
@DeleteMapping("/test")
public ResponseEntity<?> proxy(ProxyExchange<Object> proxy) throws Exception {
    return proxy.uri("someuri").delete();
}

but with a body that I'd like passed along. The delete method isn't adding the body to the RequestEntity like post/put/patch does

Yup, it's missing:
https://github.com/spring-cloud/spring-cloud-gateway/blob/eb950389527b7902ae117b0ad65adbfcf2e25a86/spring-cloud-gateway-mvc/src/main/java/org/springframework/cloud/gateway/mvc/ProxyExchange.java#L304-L319


ClrMD should stop using HResult as a PInvoke return

From https://github.com/dotnet/runtime/issues/70099.  .Net Core apparently runs on x86 for Linux which means that the HResult struct we use to make life easier in handling HRESULT from the dac's COM interfaces breaks when used as a return value in place of int.
We need to change all usages of HResult to not be directly in a PInvoke/reverse PInvoke signature.  E.G. vtable->QueryInterface = (delegate* unmanaged[Stdcall]<IntPtr, in Guid, out IntPtr, HResult>)Marshal.GetFunctionPointerForDelegate(qi); needs to be int> instead of HResult>.
This will be a breaking change, so we'll need to version bump to 2.2.  It shouldn't effect most people though, since very few people use the *.DacInterface namespace.
@t-mustafin I've ported the issue you reported here.  Note that even if ClrMD changes this behavior we still need to check the CLR diagnostics codebase for the same pattern.  I think @mikem8361 uses HResult in a few places in SOS...but I'm not sure whether he directly uses it as a return value for a pinvoke.

@t-mustafin I have completed the work in ClrMD to stop using HResult as a return from PInvoke.  We still use it inside the library itself, but that shouldn't cause problems.
Can you please sync the repository this week and test this out by using ClrMD on x86 Linux?  Unfortunately SOS won't work until CLR Diagnostics has a chance to update SOS, but it should be straight forward to run something like this and see if it blows up:
using DataTarget dt = DataTarget.LoadDump("/path/to/coredump");
using ClrRuntime runtime = dt.ClrVersions.Single().CreateRuntime();
runtime.Heap.EnumerateObjects.ToArray();

@t-mustafin I have completed the work in ClrMD to stop using HResult as a return from PInvoke.  We still use it inside the library itself, but that shouldn't cause problems.
Can you please sync the repository this week and test this out by using ClrMD on x86 Linux?  Unfortunately SOS won't work until CLR Diagnostics has a chance to update SOS, but it should be straight forward to run something like this and see if it blows up:
using DataTarget dt = DataTarget.LoadDump("/path/to/coredump");
using ClrRuntime runtime = dt.ClrVersions.Single().CreateRuntime();
runtime.Heap.EnumerateObjects.ToArray();

I would check it next week.

This changes + patch to diagnostics work for me.


Base install of py-evm actually has pytest dependency

What is wrong?
Traceback (most recent call last):
  File "/home/ubuntu/py-evm/venv/bin/trinity", line 11, in <module>
    load_entry_point('py-evm', 'console_scripts', 'trinity')()
  File "/home/ubuntu/py-evm/venv/lib/python3.6/site-packages/pkg_resources/__init__.py", line 542, in load_entry_point
    return get_distribution(dist).load_entry_point(group, name)
  File "/home/ubuntu/py-evm/venv/lib/python3.6/site-packages/pkg_resources/__init__.py", line 2569, in load_entry_point
    return ep.load()
  File "/home/ubuntu/py-evm/venv/lib/python3.6/site-packages/pkg_resources/__init__.py", line 2229, in load
    return self.resolve()
  File "/home/ubuntu/py-evm/venv/lib/python3.6/site-packages/pkg_resources/__init__.py", line 2235, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
  File "/home/ubuntu/py-evm/trinity/__init__.py", line 10, in <module>
    from .main import (  # noqa: F401
  File "/home/ubuntu/py-evm/trinity/main.py", line 29, in <module>
    from trinity.chains import (
  File "/home/ubuntu/py-evm/trinity/chains/__init__.py", line 30, in <module>
    from trinity.config import (
  File "/home/ubuntu/py-evm/trinity/config.py", line 26, in <module>
    from trinity.nodes.base import (
  File "/home/ubuntu/py-evm/trinity/nodes/base.py", line 13, in <module>
    from trinity.rpc.main import (
  File "/home/ubuntu/py-evm/trinity/rpc/__init__.py", line 1, in <module>
    from .main import RPCServer  # noqa: F401
  File "/home/ubuntu/py-evm/trinity/rpc/main.py", line 9, in <module>
    from trinity.rpc.modules import (
  File "/home/ubuntu/py-evm/trinity/rpc/modules/__init__.py", line 4, in <module>
    from .evm import EVM  # noqa: F401
  File "/home/ubuntu/py-evm/trinity/rpc/modules/evm.py", line 5, in <module>
    from evm.tools.fixture_tests import (
  File "/home/ubuntu/py-evm/evm/tools/fixture_tests.py", line 10, in <module>
    import pytest
ModuleNotFoundError: No module named 'pytest'

How can it be fixed
Move pytest imports to within the function contexts that use them so that pytest isn't a hard dependency.  Wrap these imports in a try/except and raise a friendly error message when pytest is not available for import.

The  tool requires pytest.  Please install the pytest library

Fixed with https://github.com/ethereum/py-evm/commit/86e608ca1ab1c781dad549e9caa2579171db863f


[PE-D][Tester E] Phone Number as an Attribute for Uniqueness

Good job on preventing the addition of duplicates!
UG mentioned the uniqueness is done through checking name and phone number. However I feel that the phone number should be unique as two different person should not have the same phone number.

Labels: type.FeatureFlaw severity.Low
original: pzaiming/ped#8

Mentioned this in Planned Enhancement section of DG


Dependencies requiring updates (pandas and pyvis)

Hi, PyWGCNA developers,
Thanks for creating and maintaining this package, it's really a relief to finally see the pythonic implementation of WGCNA. However, I've found a couple of drawbacks when running it, which I'll split into a couple of issues.
First of all, the pandas used in the package (v1.4.4) is very outdated, I'd really recommend you update it to >2.0.0, there are a lot of great features that can't be accessed in the same environment where PyWGCNA is.
Secondly, the pyvis module appears to be installed in a wrong way: pip automatically reaches for the latest version (0.3.2), but this version seems malfunctioning, because running the WGCNA.CoexpressionModulePlot() function results in the error that comes not from PyWGCNA, but from the pyvis itself (it occurs at the net.show(f"{self.outputPath}figures/network/{file_name}.html") step). If I manually do pip install pyvis==0.3.1, the error is gone, and the rest works as it should. So I'd really recommend setting it like that in the dependencies.
Hope these suggestions will make it an ever better package!

After installing the new version, PyWGCA Version 2.0; The issue with pandas is still indicated. I tried to install both Pandas 1.5.3 as well as 2.1.2, but in both cases it displays error as below:
ModuleNotFoundError: No module named 'pandas'
Kindly assist.

@tanush84 please answer questions in #79


Fix #1966: ChronoUnit and ChronoField

This fixes the behavior of isDateBased and isTimeBased on ChronoUnit.FOREVER as well as ChronoField.INSTANT_SECONDS and ChronoField.OFFSET_SECONDS.
Fixes #1966.
Also fixes the behavior of LocalTime.isSupported on null argument (should return false instead of throw an exception).

Can one of the admins verify this patch?

Review by @nicolasstucki

Jenkins, test this please

If this is a bug (which it seems like). Please file an issue with a reproduction and reference the issue in your commit.

That is all.

Updated and rebased.

Change the commit message to Fix #1966: ...

Otherwise LGTM

Could you retest this please?

Jenkins, retest this please

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2338/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3031/
Test FAILed.

Fixed ChronoUnitTest. Please retest.

Jenkins, retest this please

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2339/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3034/
Test PASSed.

Thats all. Otherwise LGTM.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2330/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3022/
Test FAILed.


Could not find SDK "Microsoft.VCLibs.Desktop, Version=14.0".

Your Windows build number
Windows 10 version 1903 build 18895.1000
What you're doing and what's happening
Got this error:
Error	MSB3774	Could not find SDK "Microsoft.VCLibs.Desktop, Version=14.0".	OpenConsolePackage	C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\Microsoft\DesktopBridge\Microsoft.DesktopBridge.targets	266
I have exhausted all possible solutions:

Build with VS2017 (the same error)
Build with VS2019 Preview 3 (the same error)
Retarget platform toolset to v142 (the same error)
Install any components that may be missing (the same error)
Install the VS2015 platform toolset (v140) (the same error)
Switch system language from Chinese to English (the same error)
Switch system code page to UTF-8 (beta) (the same error)
Switch system code page to English-US (the same error)
Clone and rebuild many times (the same error)
Modify any possible version settings (the same error)

What's wrong / what should be happening instead
Why does a VS2017 (v141) project require VCLib 14.0 (v140)? And the error message points to the file from Visual Studio itself. I think this is beyond my understanding.
Wish a Visual Studio expert will tell me what happened.
I think this is a problem specific to this project. I can build a UWP Demo project normally. I can also build the earlier commits (https://github.com/microsoft/Terminal/commit/58ec47236df349e1ed65d47478773035736e36b5 and earlier).

Try installing VS2015 but it requires 8GB of disk space with C/C++ support. I don't think this is a reasonable solution.

It seems that VCLib 14.0 is there:

But I always get the error.

Build with command (.\tools\razzle.cmd bcz) will get the same error:

Tried both x64 Native Tools Command Prompt for VS 2017 and x64 Native Tools Command Prompt for VS 2019.

I've just built the latest gate tip with the latest VS2017 without issue.  Can you provide screenshots showing what the Visual Studio Installer shows as installed?
For example, on my system:

If you run "git status" from the command line in the source directory, does it show any changes?
Have you tried creating a new repository clone?

Just an FYI @SwimmingTiger -- v142 requires v141, but this dependency is hidden from you and is automatically installed. I'd imagine v141 may have a dependency on parts of v140. So installing VS 2015 is not the correct interpretation here.

See also #565.

@binarycrusader I have the same components as you in VS2017, except IntelliTrace (the community version does not have this feature, this should not matter).
I also installed the same components as #565 in VS2019, but I still have this error.
This should be considered as a new issue. If it doesn't happen to you, maybe it only happens on Windows 10 version 1903 build 18895.1000?

Eventually I solved the problem by "Repair" my VS2017. I noticed that a new directory Microsoft.VCLibs.Desktop.110 was added to C:\Program Files (x86)\Microsoft SDKs\Windows Kits\10\ExtensionSDKs (it didn't exist before. I didn't add or remove any components).

This repair also solved the same build problem in VS2019 (I didn't repair VS2019, just repaired VS2017). I guess these files are shared components of Visual Studio and were corrupted when I uninstalled VS2017 (at that time, I just wanted to keep VS2019) and were not reinstalled correctly after I reinstalled VS2017.


Proxy mode does not work when more than one client is accessing the same proxied stream.

When running in proxy mode, the first user to view a proxied stream will be successful. However, subsequent users trying to view the same proxied stream will fail, if the first user is still viewing it.

The original rtsp-simple-proxy works even with multiple users accessing the same proxied stream.
https://github.com/aler9/rtsp-simple-proxy/

Please use the template when opening issues as per instructions and provide detailed infos on how to replicate.

Anyway, multiple readers are fully supported, therefore you need to provide more details. Reopen the issue and follow the instructions.


fix(schedule): keynote id in the link is incorrect

Types of changes

[x] Bugfix
[ ] New feature
[ ] Refactoring
[ ] Breaking change (any change that would cause existing functionality to not work as expected)
[ ] Documentation Update
[ ] Other (please describe)

Description
The links to keynote on the schedule page are correct but do not lead to the correct session. Take Marriata's session as an example, the link is https://tw.pycon.org/2020/zh-hant/conference/keynotes/#mariatta-wijaya but it does not jump to the correct session. The root cause is the id of the keynote session is now keynote-speaker-{{slug}} (see here).
Steps to Test This Pull Request
Steps to reproduce the behavior:

Go to the schedule page and click on the keynote event

Expected behavior
It should lead the user to the target session on the keynote page
Related Issue
#910

Codecov Report

Merging #913 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #913   +/-   ##
=======================================
  Coverage   75.60%   75.60%
=======================================
  Files          80       80
  Lines        3034     3034
=======================================
  Hits         2294     2294
  Misses        740      740

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7261793...2db304b. Read the comment docs.


AppSync Simulator: TypeError: FnSplit is not a constructor

Describe the bug
Unable to start appsync in local using this plugin.
getting error like this
AppSync Simulator: TypeError: FnSplit is not a constructor
using these packages
"serverless-appsync-simulator": "^0.3.4",
"serverless-offline": "^5.12.1",
"serverless-appsync-plugin": "1.1.2",
"serverless": "^1.61.2",

added in plugin sections like this
plugins:
  - serverless-webpack
  - serverless-appsync-simulator
  - serverless-offline

@chaitanya11 FYI,  This was solved apparently
https://github.com/robessog/cfn-resolver-lib/issues/24


求增加逆回购数据

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
求增加逆回购数据
这里是数据源
http://www.pbc.gov.cn/zhengcehuobisi/125207/125213/125431/125475/index.html

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
求增加逆回购数据
这里是数据源
http://www.pbc.gov.cn/zhengcehuobisi/125207/125213/125431/125475/index.html

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

非结构化数据，暂不考虑


Serving nested files

It used to replace only the first '' in path, which doesn't work in case that there's more than two level of nested files in static files directory

Thank you for the fix. Published as 1.5.1.


[WIP] feat: redirect daemon stdout stderr to file

Signed-off-by: Jim Ma<EMAIL_ADDRESS>
Description
The dfget daemon will be launched by dfget command in backgroud, the stdout and stderr will be lost.
So we need redirect them to log files.
Related Issue

Motivation and Context

Screenshots (if appropriate)
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation Update (if none of the other choices apply)

Checklist

[x] Code compiles correctly.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Codecov Report

Merging #1244 (613b059) into main (5d3e666) will decrease coverage by 0.14%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main    #1244      +/-   ##
==========================================
- Coverage   47.29%   47.15%   -0.15%
==========================================
  Files         134      134
  Lines       10726    10729       +3
==========================================
- Hits         5073     5059      -14
- Misses       5097     5113      +16
- Partials      556      557       +1

Flag
Coverage Δ

Object-compatibility-e2etests
?

e2etests
?

unittests
47.15% <25.00%> (-0.15%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

client/daemon/rpcserver/subscriber.go
47.41% <0.00%> (ø)

client/daemon/storage/local_storage.go
29.13% <0.00%> (-0.17%)
:arrow_down:

client/daemon/storage/storage_manager.go
17.86% <ø> (ø)

...ent/daemon/peer/peertask_piecetask_synchronizer.go
47.59% <52.63%> (-9.38%)
:arrow_down:

client/daemon/peer/piece_broker.go
92.30% <0.00%> (+2.56%)
:arrow_up:


update 'glm' to <IP_ADDRESS>

TOOLCHAIN=default PROJECT_DIR=examples/glm ./jenkins.py --verbose
Generate: 0:00:24.882442s
Build: 0:00:02.273495s
Total: 0:00:27.156409s
SUCCESS

Testing:

https://ci.appveyor.com/project/ingenue/hunter/build/1.0.1769
https://travis-ci.org/ingenue/hunter/builds/239699120?utm_source=github_status&utm_medium=notification

Uploading:

https://ci.appveyor.com/project/ingenue/hunter/build/1.0.1773
https://travis-ci.org/ingenue/hunter/builds/239715105?utm_source=github_status&utm_medium=notification

Thanks.

Released: https://github.com/ruslo/hunter/releases/tag/v0.19.3


⚠ Telly has degraded performance

In ea09097, Telly ($TLY) experienced degraded performance:

HTTP code: 200
Response time: 1464 ms

Resolved: Telly performance has improved in 9e3bb6e.


Update post-install.txt

Typo

seems like https://github.com/shopware/recipes/pull/22 fixed it already 🙈


XPAwardTable incorrect CL 4\CR 5

xpawarddd->XPAwardTable[4-1][5+2] has 1800 but XP awards for killing CR 5 should be 1600 at level 4.

That does appear to be incorrect.  Have you seen any other values that are off?

That does appear to be incorrect. Have you seen any other values that are off?

No. I decided that when if someone is going to fix that one number he will recheck them all. Even if that would be me))

I think the lower levels are special-cased. Haven't thoroughly checked though.


Adds all methods to tests

and test all methods for 'any' route. Also simplifies the automated test suite - will hopefully work cross platform a little better.
cc @jeffposnick @wibblymat @addyosmani

:+1:


[BUG] ModuleNotFoundError: No module named 'zeta.nn.model'

@Augestern-L try to upgrade the zeta package: pip3 install zetascale


Commits log remains blank.

Gitea version (or commit ref): 1.1.0+75-g6a451a2b
Git version: 2.8.3
Operating system: Docker (latest), Debian testing host
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[X] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[X] No
[ ] Not relevant

Log gist:

Description
When I create a new repository I can push/pull and everything seems to be working, but the commit log never updates (when I go to the code tab I see the Quick Guide and how to clone the repo).
I saw a similar issue with gogs when the first push used ssh but was able to work around it by using http. Neither way seems to help with gitea.

Do you have follow the upgrade docs? https://docs.gitea.io/en-us/upgrade-from-gogs/

I didn't actually end up running an upgrade from GoGs, since I'm using docker and didn't have too many repositories yet, I just started over with a fresh container. Repositories that are mirrored from github seem to work fine, it's newly created Gitea repositories that are having this issue.
I did just go check the directory structure and app.ini file just to be sure though, and everything there seems to be in order.

And there is any log?

I cleared out gitea/log then created and pushed to a new repository.
It created an empty serv.log file and an xorm.log file that has 5 SQL select statments and one update statement that doesn't look particularly interesting, but I can upload if it might help.

I found part of the problem.
If I have "Initialize this repository with selected files and template" when it is created in gitea everything works as expected, but merging in my original branch is giving problems.
If that box is not checked I never see anything in the commit log.


🐛 [POSTGRES] password authentication failed for user "postgres"

Description
Out of the box, doesn't matter which password I see , I see in the log:
2023-10-15 17:26:33.587 IDT [164] LOG:  database system is ready to accept connections
2023-10-15 17:26:35.394 IDT [186] FATAL:  password authentication failed for user "postgres"
2023-10-15 17:26:35.394 IDT [186] DETAIL:  Connection matched pg_hba.conf line 101: "host all all all scram-sha-256"
2023-10-15 17:26:38.439 IDT [187] FATAL:  password authentication failed for user "postgres"
2023-10-15 17:26:38.439 IDT [187] DETAIL:  Connection matched pg_hba.conf line 101: "host all all all scram-sha-256"
2023-10-15 17:26:41.502 IDT [188] FATAL:  password authentication failed for user "postgres"
2023-10-15 17:26:41.502 IDT [188] DETAIL:  Connection matched pg_hba.conf line 101: "host all all all scram-sha-256"
Reproduction steps
1. Install addon
2. Set and save POSTGRES_PASSWORD in the configuration
3. Start addon
4. See error

Addon Logs
Starting...
/etc/cont-init.d/00-banner.sh: executing

-----------------------------------------------------------
 Add-on: Postgres
 Postgres 15
-----------------------------------------------------------
 Add-on version: 15.4
 You are running the latest version of this add-on.
 System: Home Assistant OS 11.0  (amd64 / generic-x86-64)
 Home Assistant Core: 2023.10.3
 Home Assistant Supervisor: 2023.10.0
-----------------------------------------------------------
 Please, share the above information when looking for help
 or support in, e.g., GitHub, forums
-----------------------------------------------------------
 Provided by: https://github.com/alexbelgium/hassio-addons
-----------------------------------------------------------
/etc/cont-init.d/00-global_var.sh: executing
CONFIG_LOCATION='/config/addons_config/postgres/postgresql.conf'
POSTGRES_PASSWORD=******
/etc/cont-init.d/01-custom_script.sh: executing
[17:26:32] INFO: Execute /config/addons_autoscripts/postgres.sh if existing
[17:26:32] INFO: ... no script found
/etc/cont-init.d/20-folders.sh: executing
/etc/cont-init.d/99-run.sh: executing
[17:26:32] WARNING: The config.env file found in /config/addons_config/postgres will be used. Please customize according to https://hub.docker.com/_/postgres and restart the add-on

[17:26:32] INFO: Starting the app

PostgreSQL Database directory appears to contain a database; Skipping initialization

2023-10-15 17:26:33.013 IDT [164] LOG:  starting PostgreSQL 15.4 on x86_64-pc-linux-musl, compiled by gcc (Alpine 12.2.1_git20220924-r10) 12.2.1 20220924, 64-bit
2023-10-15 17:26:33.013 IDT [164] LOG:  listening on IPv4 address "<IP_ADDRESS>", port 5432
2023-10-15 17:26:33.014 IDT [164] LOG:  listening on IPv6 address "::", port 5432
2023-10-15 17:26:33.076 IDT [164] LOG:  listening on Unix socket "/var/run/postgresql/.s.PGSQL.5432"
2023-10-15 17:26:33.159 IDT [182] LOG:  database system was interrupted; last known up at 2023-10-15 17:24:47 IDT
2023-10-15 17:26:33.301 IDT [182] LOG:  database system was not properly shut down; automatic recovery in progress
2023-10-15 17:26:33.333 IDT [182] LOG:  redo starts at 0/153B0C0
2023-10-15 17:26:33.333 IDT [182] LOG:  invalid record length at 0/153B0F8: wanted 24, got 0
2023-10-15 17:26:33.333 IDT [182] LOG:  redo done at 0/153B0C0 system usage: CPU: user: 0.00 s, system: 0.00 s, elapsed: 0.00 s
2023-10-15 17:26:33.388 IDT [180] LOG:  checkpoint starting: end-of-recovery immediate wait
2023-10-15 17:26:33.545 IDT [180] LOG:  checkpoint complete: wrote 3 buffers (0.0%); 0 WAL file(s) added, 0 removed, 0 recycled; write=0.047 s, sync=0.026 s, total=0.188 s; sync files=2, longest=0.016 s, average=0.013 s; distance=0 kB, estimate=0 kB
2023-10-15 17:26:33.587 IDT [164] LOG:  database system is ready to accept connections
2023-10-15 17:26:35.394 IDT [186] FATAL:  password authentication failed for user "postgres"
2023-10-15 17:26:35.394 IDT [186] DETAIL:  Connection matched pg_hba.conf line 101: "host all all all scram-sha-256"
2023-10-15 17:26:38.439 IDT [187] FATAL:  password authentication failed for user "postgres"
2023-10-15 17:26:38.439 IDT [187] DETAIL:  Connection matched pg_hba.conf line 101: "host all all all scram-sha-256"
2023-10-15 17:26:41.502 IDT [188] FATAL:  password authentication failed for user "postgres"
2023-10-15 17:26:41.502 IDT [188] DETAIL:  Connection matched pg_hba.conf line 101: "host all all all scram-sha-256"

Architecture
amd64
OS
HAos

Here is log with initdb:
Starting...
/etc/cont-init.d/00-banner.sh: executing

Add-on: Postgres
Postgres 15
Add-on version: 15.4
You are running the latest version of this add-on.
System: Home Assistant OS 11.0  (amd64 / generic-x86-64)
Home Assistant Core: 2023.10.3
Home Assistant Supervisor: 2023.10.0
Please, share the above information when looking for help
or support in, e.g., GitHub, forums
Provided by: https://github.com/alexbelgium/hassio-addons
/etc/cont-init.d/00-global_var.sh: executing
CONFIG_LOCATION='/config/addons_config/postgres/postgresql.conf'
POSTGRES_PASSWORD=******
/etc/cont-init.d/01-custom_script.sh: executing
[17:49:28] INFO: Execute /config/addons_autoscripts/postgres.sh if existing
[17:49:28] INFO: ... no script found
/etc/cont-init.d/20-folders.sh: executing
/etc/cont-init.d/99-run.sh: executing
[17:49:28] WARNING: The config.env file found in /config/addons_config/postgres will be used. Please customize according to https://hub.docker.com/_/postgres and restart the add-on
[17:49:28] INFO: Starting the app
The files belonging to this database system will be owned by user "postgres".
This user must also own the server process.
The database cluster will be initialized with locale "en_US.utf8".
The default database encoding has accordingly been set to "UTF8".
The default text search configuration will be set to "english".
Data page checksums are disabled.
fixing permissions on existing directory /data/database ... ok
creating subdirectories ... ok
selecting dynamic shared memory implementation ... posix
selecting default max_connections ... 100
selecting default shared_buffers ... 128MB
selecting default time zone ... Asia/Jerusalem
creating configuration files ... ok
running bootstrap script ... ok
sh: locale: not found
2023-10-15 17:49:28.809 IDT [189] WARNING:  no usable system locales were found
performing post-bootstrap initialization ... ok
syncing data to disk ... ok
initdb: warning: enabling "trust" authentication for local connections
initdb: hint: You can change this by editing pg_hba.conf or using the option -A, or --auth-local and --auth-host, the next time you run initdb.
Success. You can now start the database server using:
pg_ctl -D /data/database -l logfile start

waiting for server to start....2023-10-15 17:49:30.259 IDT [195] LOG:  starting PostgreSQL 15.4 on x86_64-pc-linux-musl, compiled by gcc (Alpine 12.2.1_git20220924-r10) 12.2.1 20220924, 64-bit
2023-10-15 17:49:30.294 IDT [195] LOG:  listening on Unix socket "/var/run/postgresql/.s.PGSQL.5432"
2023-10-15 17:49:30.420 IDT [198] LOG:  database system was shut down at 2023-10-15 17:49:29 IDT
2023-10-15 17:49:30.489 IDT [195] LOG:  database system is ready to accept connections
done
server started
/usr/local/bin/docker-entrypoint.sh: ignoring /docker-entrypoint-initdb.d/*
waiting for server to shut down....2023-10-15 17:49:30.605 IDT [195] LOG:  received fast shutdown request
2023-10-15 17:49:30.641 IDT [195] LOG:  aborting any active transactions
2023-10-15 17:49:30.644 IDT [195] LOG:  background worker "logical replication launcher" (PID 201) exited with exit code 1
2023-10-15 17:49:30.644 IDT [196] LOG:  shutting down
2023-10-15 17:49:30.674 IDT [196] LOG:  checkpoint starting: shutdown immediate
2023-10-15 17:49:30.843 IDT [196] LOG:  checkpoint complete: wrote 3 buffers (0.0%); 0 WAL file(s) added, 0 removed, 0 recycled; write=0.046 s, sync=0.021 s, total=0.200 s; sync files=2, longest=0.016 s, average=0.011 s; distance=0 kB, estimate=0 kB
2023-10-15 17:49:30.852 IDT [195] LOG:  database system is shut down
done
server stopped
PostgreSQL init process complete; ready for start up.
2023-10-15 17:49:31.031 IDT [165] LOG:  starting PostgreSQL 15.4 on x86_64-pc-linux-musl, compiled by gcc (Alpine 12.2.1_git20220924-r10) 12.2.1 20220924, 64-bit
2023-10-15 17:49:31.031 IDT [165] LOG:  listening on IPv4 address "<IP_ADDRESS>", port 5432
2023-10-15 17:49:31.031 IDT [165] LOG:  listening on IPv6 address "::", port 5432
2023-10-15 17:49:31.099 IDT [165] LOG:  listening on Unix socket "/var/run/postgresql/.s.PGSQL.5432"
2023-10-15 17:49:31.170 IDT [209] LOG:  database system was shut down at 2023-10-15 17:49:30 IDT
2023-10-15 17:49:31.204 IDT [165] LOG:  database system is ready to accept connections
2023-10-15 17:49:33.363 IDT [213] FATAL:  password authentication failed for user "postgres"
2023-10-15 17:49:33.363 IDT [213] DETAIL:  Connection matched pg_hba.conf line 100: "host all all all scram-sha-256"
2023-10-15 17:49:36.381 IDT [214] FATAL:  password authentication failed for user "postgres"
2023-10-15 17:49:36.381 IDT [214] DETAIL:  Connection matched pg_hba.conf line 100: "host all all all scram-sha-256"

Hi, is it a new install? As I don't use often the app, I had remanent elements. So I deleted the addon, deleted /config/addons_config/postgres, then reinstalled the addon. It started from the first time, and allowed connection using homeassistant as default password for the user postgres as normal

Cleaned up and reinstalled. you were right about the default password. Might be a good idea to hide it from settings as it is kind of confusing. Thanks!!!!


I don't get the cursor back in Terminal after running a SwiftTUI app

After quitting with control-c I don't get the terminal cursor back in the shell - what is the appropriate way to shutdown a SwiftTUI app to restore the cursor appropriately?

If you use control-d that should quit the app gracefully and you should get the cursor back

Ok, thanks - is there any programmatic way to restore it too in case there is a programmatic exit?

Not yet, that'd be a feature that doesn't yet exist.
I've just pushed a change to listen to interrupt signals, that way ctrl-c should also work in the next release.

Super, thanks!


Allow Ensemble with no Dask distributed client

Currently, there is no simple way to create an Ensemble instance without an associated dask.distributed.Client. While having a client-less Ensemble may not be very useful from a scientific standpoint, it could make Ensemble more lightweight. See issues #208 and #199 for relevant discussions. I've also found that debugging errors with Client is much more difficult, and, for example, pytest-generated errors are much less readable. Therefore, we could probably use a client-less approach in most tests.
I think we can modify Ensemble constructor to accept Client=False or ="no" or something like that.

In general I agree, but I am worried how technically feasible it is. Looking forward to input from Doug and Wilson.

+1 to the notion that we should enable clientless setup. How we should represent the API for this is a bit tricky. To align with Dask, client should be able to accept a Dask.distributed.client object, currently if client=None then a client is spun up. The least invasive change could be to have client take in a Dask.distributed.client as a possible input, as before, or also accept a boolean, where client=True spins up a client and passes along kwargs, and client=False doesn't.

In the above API, I would still advocate for client=True to be the default behavior

@dougbrn I agree, this issue does not propose changing of the default behavior - just giving one more option

Sounds good, I can try taking a stab at this.

Fixed by https://github.com/lincc-frameworks/tape/pull/216


[TEST] Test spellcheck by adding spelling errors to whats_new, extracellular.py

Awesome, thanks for checking @dylansdaniels !


fix: deny registering profiles with ETF2L bans

Codecov Report

Merging #138 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   91.28%   91.28%   +<.01%
==========================================
  Files          97       97
  Lines        3752     3753       +1
  Branches      177      177
==========================================
+ Hits         3425     3426       +1
  Misses        274      274
  Partials       53       53

Impacted Files
Coverage Δ

src/players/services/players.service.spec.ts
97.41% <100%> (+0.02%)
:arrow_up:

src/players/services/etf2l-profile.service.spec.ts
96.15% <100%> (ø)
:arrow_up:

src/players/services/players.service.ts
88.13% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa8ad5b...7038b92. Read the comment docs.


Question? Upload and Export Backups

@donaldzou Will exporting and uploading backups be supported? Yes or No?

Backup yes :) but not front end export, it is saved under the WireGuard directory in /etc

U can try it out in the v4.1-dev branch ;) I've implemented already. You can find it under each configuration, click on the 3 dots on the right and click Backup & Restore

@donaldzou Tested the dev beach days ago, looks great.

Heads up for the AmneziaWG integration. The "wg set" and a few other commands overwrites the interface section when creating new peers.
a project called amnezia-wg-easy is using a json file to avoid this issue.
other than that AmneziaWG(specific version) is compatible with WGDashboard. The peer creation would need to be modified slightly to avoid using "wg set" and try "wg syncconf" like the amnezia-wg-easy project.

@NOXCIS Thank u thank u... haven't have chance to test it out myself. But looked over the doc and seems like we can do a symbolic link replace wg to awg and wg-quick to awg-quick?

@donaldzou  I have a working version at WireGate. Run the dev-docker-compose.yml on the amneziawg branch.

Hi @NOXCIS , I wasn't able to run the dev docker compose file...will try later.
In this case, do you still think changes to WGDashboard is required to use AWG, or maybe system level configuration is good enough? (i.e symbolic link)

@donaldzou

symbloic links works work fine. So far no need to modify the dashboard other than passing the extra amneziaWG arguments to the clients. Which ive already halfassed in my dev demo.

There is one issue with the amnezia-go upstream where they forgot to add the address parameter causing it to be removed from the config after running "wg set" I've already submitted the issue and working on a fix in the meantime. Otherwise the dev compose I have works fine with creating peers until the container is restarted due to the missing address line from the config.

I see.. in this case, should I leave the support AmneziaWG to WireGate or you wanna merge it into WGDashboard?

The best option would be native AmneziaWG support within WGDash with backwards compatibility for standard WireGuard. Maybe with some sort of switch to avoid doing
Symbolic links so WireGuard and AmneziaWG can coexist.

-Then on WireGate I can ship two base images. One using AmneziaWG and another using WireGuard. With manifest for amd64, arm64, arm/v6/, arm/v7.

As for peer creation functionality breaking down after restarts for container that have had peers created. Two actionable options.

Some sort of wrapper function around any "wg set" calls. To restore the address in the file.

Store and retrieve each config interface address from the db instead of the actual .conf after first run or as long as db is present.

This would be ideal scenario.
However, someone else would have to add the  Amnezia Build Stage to WG-Dash existing docker image. Due to Wiregate having a conflicting environment setup and the integration of tor transports.
For bare metal setups, a similar shell function to the build stage with the addition of golang for bin compilation on the host should do the trick. Some host would have the ability to use the kernel module but that should be left to sysadmins for decision, build and install.
What do you think is the best option?

@donaldzou Nevermind. I patched the dashboard. Wiregate's  WG-Dashboard now has full AmneziaWG support and Backwards Compatability.

uses (ip addr show) and write functions to get and reappend the Interface address at all (wg) and (wg-quick) calls with respect to non AmneziaWG configs.

Same goes for downloading peer configs and backups.

Frontend support is upto you.

Use what works, modify, add support or not.   🤠

See

WireGate
dashboard.py,
wgd.sh,
entrypoint.sh
Dockerfile
compose.yml


Wallet recovery.

After scanning the recovery key, it takes about 7/8 seconds to show the "create wallet" modal.

@cakesoft-swati  can we apply Loader in between ?


Added custom MountSlider (try #2!)

Added a mount slider with nothing on it to allow for custom tracking solutions!

Dose not need to be printed, just easier.


return unique_ptr normally, without std::move

clang warns about using return std::move($LOCAL).

This kills the mingw. ... which is I think is the reason we have this in the first place. 😞

Do we need such an old mingw build (4.8?) in the first place?  Is it possible to use a newer version of mingw?

We can use whatever the minimum mingw to build Tor Browser is, although I'm having trouble finding out what that is.
But we're also stuck with ancient (14.04) Ubuntu images on Travis, so upgrading to a newer mingw is not trivial unless there are backports available.
Another option would be to move the mingw build to AppVeyor and use the native mingw build rather than cross-compile.

But we're also stuck with ancient (14.04) Ubuntu images on Travis, so upgrading to a newer mingw is not trivial unless there are backports available.

Travis had Xenial (16.04) images for a while: https://docs.travis-ci.com/user/reference/xenial/

Thanks for the heads up!  Looks like it has been available since November.  I've had a crack at switching the builds to Xenial here: https://github.com/kinetiknz/cubeb/tree/travis_xenial - there's some breakage to solve - the Android build is broken by newer CMake versions.


Update Zarr store creation functions

[ ] ~Closes #xxxx~
[x] Tests added / passed
[x] Passes pre-commit run --all-files

As discussed in https://github.com/zarr-developers/zarr-python/pull/1309#pullrequestreview-1231599350, Zarr can now handle a the creation of more types of store object from URLs thanks to the FSStore class. This means that usually Dask can just pass through the store URL with no modifications (e.g. calling get_mapper). The only exception is when the user specifies storage_options explicitly.

Can one of the admins verify this patch?
Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

Cool.  Happy to see things moved upstream.  Is this new functionality widely deployed?  Should we be concerned at all about backwards compatibility?  (how old is it / what fraction of users are likely using that version or older?)

add to allowlist

CI failure seems unrelated.  Testing main here: https://github.com/dask/dask/pull/9792

Is this new functionality widely deployed? Should we be concerned at all about backwards compatibility? (how old is it / what fraction of users are likely using that version or older?)

This should work with all versions of Zarr > 2.6.0, which was released in July, 2021. That feels like a long time ago to me, but I have no data on what fraction of users are using older versions. (Do you have some way to get those numbers?)

Makes sense.  I was just curious.  CI seems unhappy.  I suspect due to unrelated issues.  I'm going to pause on this for a moment while I check those out.  My apologies for the delay.

Thanks @rabernat .  This is in.


interactivePanGestureDissmisalDireciton retains Content View Controller

Hey!
Awesome work here.
Be careful that setting interactivePanGestureDissmisalDireciton is retaining the controller presented and do never dealloc.
I solved by adding this in viewDidDissapear
    [self removeEdgeDismissalPanGestureRecognizer];
    [self removePresentaingViewDismissalPanGestureRecognizer];

Best

ok.. maybe it was (and/or) the interactive transitionContext being strong
I made it weak and dealloc is working again
@property (nonatomic, weak) id<UIViewControllerContextTransitioning> transitionContext;

Thanks, fixed.


LocusPocus

[ Project Lead ] @schae234
[ GitHub Repo ] https://github.com/schae234/locuspocus
[ Track ] Tools: you are building a tool others can help you build
[ Level ] Beginner
Description
Genetic coordinates as a fundamental data-type (SNPs, genes, etc) implemented in python.  LocusPocus makes creating, comparing, and relating genome coordinates so easy, it will feel like MAGIC!

Want to Contribute?
Join us at the Global Sprint June 2-3. Leave a comment in this issue to let the project lead know you're interested in contributing during #mozsprint 2016!

Note to the Project Lead
Congrats, @schae234! This is your official project listing for the Mozilla Science Global Sprint 2016. To confirm your submission, please complete the following:

[x] Provide a GitHub repository for work and discussion on your project
[x] Confirm in a comment that at least one person will be available to review and answer questions on this project from 9-5 in their timezone on both June 2 & 3.

Do you want to become a featured project? :tada:
Here are some exercises that will help your project be more inviting to new contributors. We hope you'll try to complete some of these as you prepare for #mozsprint.
If you complete all the exercises, your project will be eligible to be featured in our collection of open source science projects! Once you've finished this list, contact @acabunoc to submit your project for review.

[ ] README.md:
[ ] LICENSE:
[ ] CONTRIBUTING.md:
[ ] Roadmap or an Issue Tracker (with tasks to complete):
[ ] Data Reuse Plan (if applicable):
[ ] Code of Conduct:
[ ] Personas:

Hey @acabunoc!
I will for sure be there on 6/2-3 to answer questions and review any PRs! I'll be working on getting those other checkboxes completed :+1:

You are crushing it @acabunoc!! :fireworks: :boom: :+1:

Scripts + the github api help :)

Shhhh, don't give away those secrets!

Hey :) I would like to contribute to this project, how can we coordinate? (I don't think I can stay at the event for the whole 2 days)

Hi @cmassimo!
Awesome! So good to hear! What time zone are you in? I'll be at our St Paul site 9-5 Central Time both days, maybe we can overlap through video chat. Otherwise I do plan on laying out some issues on github sometime early next week (currently a decent sized chunk of this idea is implemented in another project, which I want to fork it off into its own thing).

Ok, I'll probably be there on friday 9-5 (CEST) but I'll keep an eye on github in the meanwhile.

@schae234 I am interested to work on this problem (from mozilla science community). I am available on the gitter rooms -> https://gitter.im/mozillascience/community.

Hey @bharathi3p, just got into the lab! I should be in the gitter chat room all day! Working on opening some issues on github right now.


add shape to trial parameters

The shape features is really great :) Let's also add it to the trial parameters with others. Thanks!

Done in the dev branch, closing it. Thanks!!! :)