Improvements to execution order ambiguity reporting

Context
This PR was largely completed by @alfonsolage in #2766. I've simply rebased it and put a few finishing touches on it to get it over the finish line.
Massive thanks and full credit for all his hard work.
Objective

Execution order ambiguities suck, but our existing tool to discover them isn't very nice.
It also isn't very discoverable.
Fixes #1484

Solution

Number the reported ambiguities, to make them easier to discuss in a team.
Display function signatures of conflicting systems.
Explain which component(s) / resource(s) the systems are conflicting on.
Report ambiguities where all pairwise combinations of systems conflict on the same data as a group.
Create a simple .ignore_all_ambiguities() method that causes a system to be ignored completely in the ambiguity checker. This would only be useful for inconsequential systems like particle effect creation.
Replace ambiguity sets with a simple .ambiguous_with(system_label) method, which allows your system to be ambiguous with the provided label (or system, via #4224).
Provide an "X unresolved ambiguities detected" message that runs by default. Rather than toggling ambiguity detection on/off, have three states: off / minimal / verbose. This would provide discoverability that system ambiguities are a thing and let developers see when the change that they just made added / removed some ambiguities at a glance.
Provide an way to ignore/filter crates when using ambiguity checker.
By default, ambiguity checker should ignore internal bevy crates.
Improve docs.
Add an example of using ambiguity reporting
Added a WarnInternal reporting level, and included an example to the tools folder that reports all of the Bevy-internal ambiguities. Should be helpful for developers until we quash the last few.
Added a Deny reporting level, which reports literally every ambiguity and panics, for applications that need true determinism.
Use short version of system and type names, rather than full path (generally, this is just noise and makes the output much harder to read).

Changelog
Execution order ambiguity reporting has been significantly improved and a minimal report informing you of the number of ambiguous system pairs present in your schedule is now on by default.
It is now much easier to disable false positive ordering ambiguities, bevy-internal ambiguities are silenced by default and the output is much easier to read and act on.
Sample output:
One of your stages contains 4 pairs of systems with unknown order and conflicting data access.
You may want to add `.before()` or `.after()` constraints between some of these systems to prevent bugs.

1. `system_b` conflicts with `system_e` on ["MyResource"]
2. `system_b` conflicts with `system_d` on ["MyResource", "MyOtherResource"]
3. `system_e` conflicts with `system_c` on ["MyResource"]
4. `system_d` conflicts with `system_c` on ["MyResource"]

Migration Guide
The ReportExecutionOrderAmbiguities resource is now ExecutionOrderAmbiguities: you can adjust the level of the enum to match your preferred strictness level.
The concept of "ambiguity sets" has been simplified away: simply use .label(SharedLabel).ambiguous_with(SharedLabel) with a standard SystemLabel instead.
Future work
If you think any of these are dealbreakers, do let me know. For now though, this PR is already way too large.

[ ] solve #4364
[ ] report stage name  (requires piping some metadata through a lot of plumbing), or yeet stages
[ ] remove all internal execution order ambiguities, the example to check for these, and the ReportInternal enum variant

Comments

There's a bit of a mess when trying to report all of the ambiguities for each stage, as we can't collect exclusive and non-exclusive systems together. Once #4166 lands, that should be fixable.
Because these ambiguities are reported per stage, I really want it to report which stage it's coming from. Unfortunately, I couldn't see a good way to do so: this information is erased at the SystemStage level. I'm considering piping in the stage name somehow, but this PR is already too big.

Would it be interesting for CI purposes to have a way to exit the app with the number of conflicts as the status code? Or at least not 0 if there are conflicts

Would it be interesting for CI purposes to have a way to exit the app with the number of conflicts as the status code? Or at least not 0 if there are conflicts

IMO the way to do this is to allow users to forbid ambiguities, at both a plugin and app level. This is fundamentally what we need for determinism. I think that's very much worth pursuing, but out of scope for this.

Is there a way to un-ignore the internal plugins?

Is there a way to un-ignore the internal plugins?

I don't think so, and I don't like it. I'm going to see if I can come up with a more reasonable design for this.

That said, this whole design [for ignoring crates] is eh... I'm going to see if I can come up with a more reasonable design for this.

I took a pass at this, and it's not going to be triviak. Current problems:

This scatters the execution order ignoring all over bevy, with no rhyme or reason.
It's very hard to discover that you can do this.
We have to store two fields in ReportExecutionOrderAmbiguities, and rely on a overwrought builder struct.

Blockers:

We can't reasonably fix all of the internal ambiguities in this PR, for merge-ability reasons.
Simply adding the crates to the ignored_crates field doesn't stop ambiguities between them
We don't want internally ignored crates to also ignore ambiguities with user systems.
We can't reasonably have a "ignore conflicts on this component / resource" config without a Resource trait.

I think I can make this work though, and I think that hard-coding a list internally is the least bad solution.

Since you're using println! is this going to try to print to the console in production if people forget to turn this off?

Since you're using println! is this going to try to print to the console in production if people forget to turn this off?

Probably. I'd like to use info!() or warn!() but their logging output is very noisy: https://github.com/bevyengine/bevy/pull/4299#discussion_r836788073

@hymm @maniwani @MrGVSV I managed to swap over to the tracing macros: it's much less noisy now that I condensed the output for each stage. I think this is ready for final review now: it's in a good place, and I would really like to avoid making this PR larger.

So, the ambiguity detection currently doesn't take into account filtered queries (thanks @superdump for noticing this; Ratys had told me at one point but it slipped my mind). I'm very reluctant to ship a feature that increases the prominence of the ambiguity checker until that bug is fixed.

I'm very reluctant to ship a feature that increases the prominence of the ambiguity checker until that bug is fixed.

I really don't think this should be a blocker (and I wouldn't call it a bug when it was an intentional tradeoff.) If you insist, we can leave the ambiguity checker off by default until the situation improves, but I think this should still be merged ASAP.
False positives are at most an inconvenience since we don't error on them (unless asked). Can we detect when one of the systems has filters and clarify that user needs to confirm? And maybe we could make it easier to tell at a glance by including the function signatures in the warning, i.e. maybe FunctionSystem can get a method to return std::any::type_name::<Params>().
Like I suggested in #4211, if comparing FilteredAccess<T> works for two queries, comparing FilteredAccessSet<T> should work for two systems (if not, I don't know an alternative).
It's just worth considering what that might mean for perf. In the worst case, that would be 256 intersection tests for a single pair of systems (16 queries in each system), maybe more.

I really don't think this should be a blocker (and I wouldn't call it a bug when it was an intentional tradeoff.) If you insist, we can leave the ambiguity checker off by default until the situation improves, but I think this should still be merged ASAP.

Fair. I'll either fix it quick now if it's easy, or disable the test. We can leave the decision about the default value to Cart.

Like I suggested in https://github.com/bevyengine/bevy/pull/4211, if comparing FilteredAccess works for two queries, comparing FilteredAccessSet should work for two systems (if not, I don't know an alternative).

Yep, this should work. I'll see how hard this change would be.

It's just worth considering what that might mean for perf. In the worst case, that would be 256 intersection tests for a single pair of systems (16 queries in each system), maybe more.

There are a couple of mitigations available, should this prove to be an issue down the line:

We could create and store a combined filtered access for each system, and get this down to 1 checks per pair.
We could do a broad-phase + narrow-phase strategy, checking unfiltered access first, then filtered access.
That's an extremely large number of queries: I would expect 95% of the systems to have a zero or one query, and almost all of the remainder to have 2.
We could use an agglomerative strategy to detect ordering ambiguities, reducing our graph into smaller subsets.

I don't love the doubly quadratic nature of it either though: this is worth keeping an eye on.

Yep, this should work. I'll see how hard this change would be.

Should be pretty simple once #4211 is merged. Systems already store FilteredAccessSet for handling filtered queries, they were just missing direct set vs. set comparison methods. tbh, I can extend the PR to change the ambiguity tests to use those methods (I wasn't confident enough in that when I made the PR).

We could do a broad-phase + narrow-phase strategy, checking unfiltered access first, then filtered access.

Oh, I forgot about this. I'm pretty sure this is something we're already doing and I included it in my PR.

That's an extremely large number of queries: I would expect 95% of the systems to have a zero or one query, and almost all of the remainder to have 2.

Agreed.

Should be pretty simple once https://github.com/bevyengine/bevy/pull/4211 is merged

Sounds good to me. For now, there's no immediate way to do this (SystemContainer only gives us an Access<ComponentId>), so I'm just going to ignore this test for now and mark this as ready for review.
Ignored tests are better than the test not existing IMO, especially if we're planning to get the fix in soon.

I'm seeing this in a project with no systems, other than DefaultPlugins after switching to WarnVerbose
2022-04-20T21:47:17.633314Z  WARN bevy_ecs::schedule::ambiguity_detection: One of your stages contains 2 pairs of systems with unknown order and conflicting data access.
You may want to add `.before()` or `.after()` ordering constraints between some of these systems to prevent bugs.

1. `animation_player` conflicts with `flex_node_system` on ["Transform"]
2. `animation_player` conflicts with `ui_z_system` on ["Transform"]

I'm seeing this in a project with no systems, other than DefaultPlugins after switching to WarnVerbose

Thanks; looks like we introduced a new ambiguity... Should be easy to fix up.

 Based on the original PR description, let's carve this up as follows.
Foundational:

Provide an "X unresolved ambiguities detected" message that runs by default. Rather than toggling ambiguity detection on/off, have five states: Allow / WarnMinimal / WarnVerbose / Deny / Forbid. This would provide discoverability that system ambiguities are a thing and let developers see when the change that they just made added / removed some ambiguities at a glance.
Solve all remaining Bevy-internal ambiguities.

Disjoint improvements:

Number the reported ambiguities, to make them easier to discuss in a team.
Display function signatures of conflicting systems.
Report ambiguities where all pairwise combinations of systems conflict on the same data as a group.
Create a simple .ignore_all_ambiguities() method that causes a system to be ignored completely in the ambiguity checker. This would only be useful for inconsequential systems like particle effect creation.
Replace ambiguity sets with a simple .ambiguous_with(system_label) method, which allows your system to be ambiguous with the provided label (or system, via https://github.com/bevyengine/bevy/pull/4224).
Explain which component(s) / resource(s) the systems are conflicting on.
Provide an way to ignore/filter crates when using ambiguity checker.
Use short version of system and type names, rather than full path (generally, this is just noise and makes the output much harder to read).
Add an example of using ambiguity reporting

Incremental:

Improve docs.
Use tracing's warn and error macros, rather than println.

Yeet (fixed by 2 of foundational work):

By default, ambiguity checker should ignore internal bevy crates.
Add a WarnInternal reporting level, and included an example to the tools folder that reports all of the Bevy-internal ambiguities. Should be helpful for developers until we quash the last few.


Chapter 3 part1 missing import

In chapter 03 part 1 section 3.5.3 the test is expected to pass at the end of the section, but it fails due to a missing import.
This import needs to be added to the last code block in the text for that section:
use zero2prod::configuration::get_configuration;

Then the test passes as expected. 😄

Fixed and released, thank you!


fix(microsite): Bug fixes to the microsite siteConfig.js

Hey, I just made a Pull Request!

Ran backstage/backstage through http://LGTM.com (Looks Good to Me/Semmle), and it found one error and a warning easy to fix for the microsite. This PR fixes them, and a local microsite$ yarn start works for me.

:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)

These findings discovered by Lgtm.com, hence recommended it via #3607


Revert default autoLaunch behavior to true

- Summary
This PR reverts the default autoLaunch to true, the way it works in the current release of netlify-cli. Motivation is explained in https://github.com/netlify/cli/pull/631#issuecomment-571555799.
- Test plan
The change is really basic so not much testing is needed, but I tested it with a new basic project with and without a netlify.toml.
- Description for the changelog
Probably shouldn't be included in the changelog since it reverts a change present in master but not yet released.
- A picture of a cute animal (not mandatory but encouraged)

Thanks for the PR @ianmartorell


netflow backup created damaged tar -> OPNsense does not start because of infinite loop

I am using netflow for a small overview of what's going on, but today I had an issue.
It seems I created it by myself because I was too impatient when I wanted to restart the firewall after some problems with my DSL line. I fired the reboot command multiple times from the WebIF and then again from the SSH shell. Seems this lead to that the backup file for netflow got damaged.
The problem then was that the firewall didn't boot up anymore:
***** FILE SYSTEM MARKED CLEAN *****
Setting hostuuid: b4998a3a-5868-11e8-b348-000db9463368.
Setting hostid: 0x1ef47c8b.
Configuring vt: blanktime.
Configuring crash dump device: /dev/gpt/swapfs
swapon: adding /dev/gpt/swapfs as swap device
.ELF ldconfig path: /lib /usr/lib /usr/lib/compat /usr/local/lib /usr/local/lib/ipsec /usr/local/lib/perl5/5.26/mach/CORE
32-bit compatibility ldconfig path:
done.
>>> Invoking early script 'update'
>>> Invoking early script 'configd'
Starting configd.
>>> Invoking early script 'php'
Configuring PHP: OK
>>> Invoking early script 'backup'
>>> Invoking backup script 'captiveportal'
>>> Invoking backup script 'dhcpleases'
>>> Invoking backup script 'duid'
>>> Invoking backup script 'netflow'
tar: Damaged tar archive
tar: Retrying...
tar: Damaged tar archive
tar: Retrying...
tar: Damaged tar archive
tar: Retrying...
tar: Damaged tar archive
tar: Retrying...
tar: Damaged tar archive
tar: Retrying...

The startup was caged in that infinite loop where tar tried to open that damaged archive.
I had to connect with serial to my box and Ctrl-C that, then did a clean shutdown, which takes about 15 minutes on my box where the main part is that backup script of netflow tar'ing and zip'ing the netflow data.
So I did some research and I found no option in tar to stop when and archive is damages and return with an error code.
I wanted to bring this up here because this is not very nice and I wanted to discuss several options to resolve my issues.

It is not good that tar goes in an infinite loop, maybe someone knows how to stop that, so that it just tries once, and then bad luck, restore failed, not data there,rather than preventing the whole box from booting into a managable state.
It would be nice if there was an option where I could select if I want that data to be backed up. Or is that inlcuded in the option to backup RDD data? I also have no idea what the benefit is backing that data when I do a shutdown. If I select to backup the data when doing a config backup then it is ok, but at shutdown I don't backup the config to somewhere else other than the storage of the firewall itself, so if that storage crashed the backup is lost too. That backup take a long long time on my machine for IMHO no benefit...

Use /usr/local/etc/rc.reboot instead .. it wont damage DB instead of plain reboot command

It think the reason is when using /var in RAM so you wont loose all data when rebooting.
Regarding tar loop probably @AdSchellevis has an idea.

To be honest, I'm also not convinced it should do the backup when not using a ram filesystem, here we're disabling the backup schedule:
https://github.com/opnsense/core/blob/cae5ec3f69dfdfcd4119c1c3f69c6a61c534e410/src/etc/inc/plugins.inc.d/core.inc#L195-L201
Which we then later kick of during shutdown anyway:
https://github.com/opnsense/core/blob/eb95e8f53e56e25ce8f0898ee6936d8201bd9a29/src/etc/rc.syshook#L73
@fichtner What do you think? Maybe we can add a parameter in the cronjob then for the default start check if /var is ramfs mounted in these cases.

UFS has never been truly stable. For that reason on reboot all backup-worthy facilities are automatically saved and restored. I'd say this helped more users silently retain their data even when it was corrupted on the file system since the archive is harder to be broken by FS corruptions.
The backup on reboot is also used for seamless config import during installations:
https://github.com/opnsense/core/blob/f16167442665a8b5625cf08e63bea75dd2dcd4bb/src/sbin/opnsense-importer#L281
This should be raised to https://github.com/libarchive/libarchive -- it is a sort of a DoS scenario.

@fichtner regarding the tar thing, I am going to raise this issue with the infinite loop on the mentioned repo, no matter what we do here, there should be a possibility to handle such cases with an option. I have never heard of a self-healing archive that gets healthy again just if you try often enough...

we can add a backup option "never" for each backup type listed under system: settings: misc. we can't enable it by default as it will break expected behaviour but that would work for you from the looks of it?

Yeah, I see your point of doing a backup of vital system config if as you say UFS can have problems sometimes.
It must not be for every single config type but just for the postions that can get huge and are not so important if they get lost...

Views of "importance" can differ. The next issue raised is going to be about why it's not backed up by default if we change it. :)

As you said, I wouldn't change that default behaviour of backing up everything. As I told earlier on a normal machine this is absolutely fine as you have no issue when packing 500mb of data, but the APU board has...
So if you think just to implement options to exlude every single type of setting, that's fine too :D...

@fichtner I agree, a "never" options should fix the issue, I expect in reality this only impacts netflow since the size can grow pretty rapidly.

Defaults to "Power off" which used to be labelled "Disabled" while now "Disabled" is the new non-default mode which prevents all backups and deletes any remaining ones left on the system. Shell parsing XML is a bit iffy but it does the trick without rewriting these scripts.

PS: this will land in 18.7.8 :)

Just wanted to add that the update to 18.7.9, where that change kicked in first, went smooth and fast because of the disabled backups...
Thanks for this!

yay, glad to hear. thanks for the follow-up!


chore: Ensure only proportional recovery exits are available for ComposableStableV1

Description
We were showing the option to single asset withdraw from shallow ComposableStableV1 pools. This works if you withdraw everything, but not if you try to withdraw a specific amount, because the pool type doesn't support the required exit type. This PR effectively enforces proportional recovery withdrawals for ComposableStableV1 pools.
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How should this be tested?

[ ] Test withdrawals from this pool polygon pool 0x216690738aac4aa0c4770253ca26a28f0115c595000000000000000000000b2c you may need to unblock add-liquidity locally in order to test withdrawals.

Checklist:

[x] I have performed a self-review of my own code
[x] I have requested at least 1 review (If the PR is significant enough, use best judgement here)
[x] I have commented my code where relevant, particularly in hard-to-understand areas
[x] If package-lock.json has changes, it was intentional.
[x] The base of this PR is master if hotfix, develop if not

I've changed my mind about this change. Max single-asset exits are possible so we should leave this open. The majority of cases will be withdrawing 100% so this PR was solving a small edge case but limiting the primary use of single asset withdrawals.


feat: deploy / aws-lambda / sst waku stack

This is a first draft for a sst stack for WAKU.
Based on the fact, that there can be more than 25 folders (AWS Cloudfront routing limit) on the first level of the public folder only the folder public/images and public/assets are copied to s3 and forward by CloudFront.
A possible, but more complex solution could handle this by adding a Cloudfunction to Cloudfront which knows all routes and can forward all existing static root level routes.

@rmarscher this is based as suggested on the sst tanstack-start stack

@rmarscher this is based as suggested on the sst tanstack-start stack

It looks great on a quick read. I'll try to test it next week. I wonder if we can get them to accept it upstream...


Reinstate review dates on documentation

Background

We did have review by dates show on our docs. These appear to have gone missing.

Find out why. Put them back.
Acceptance Criteria

[ ] Pages have last reviewed banner reinstated.

Reference
How to write good user stories

Dependant on issue raised with GDS team.

Issue raised to allow a string input to fix middleman exception: https://github.com/alphagov/tech-docs-gem/issues/302

Fixed


Change URL

Is there a way to change the URL while the browser is running?
(Instead of changing the env var).

Multi container is one way to deal with this.
WPE in one container and an app in another container to change the URL env var.
https://github.com/balena-io-projects/multicontainer-demo-rpi3/blob/master/wpe/public_html/index.html


crash on startup 1.12.2

Issue Description:
I'm more than sure if there is no thaumcraft then crash solely because of this
Steps to reproduce:
I run the game and it loads a little and then it closes itself

Affected Versions (Do not use "latest"):

EnderIO-base-1.12.2-5.0.377-nightly
EnderIO-conduits-1.12.2-5.0.377-nightly
EnderIO-integration-forestry-1.12.2-5.0.377-nightly
EnderIO-integration-tic-1.12.2-5.0.377-nightly
EnderIO-machines-1.12.2-5.0.377-nightly
EnderCore-1.12.2-0.5.24
Minecraft: 1.12.2
1.12.2-forge1.12.2-<IP_ADDRESS>77

Your most recent log file where the issue was present:
[pastebin/gist/etc link here]
crash report
https://pastebin.com/stqdC9D7
recent log
https://pastebin.com/nw57T6SM

Fixed in 378, which was built before you made this issue...

Thank you so much for the fix!


[KYUUBI #5766] Do not check engine initialization timeout when engine attempt

:mag: Description
Issue References 🔗

This pull request fixes #5766
Describe Your Solution 🔧
Use CONTAINER_ID environment to determine whether the execution is attempted, and if so, skip the engine initialization timeout check.
Types of changes :bookmark:

[X] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪
Behavior Without This Pull Request :coffin:
Behavior With This Pull Request :tada:
Related Unit Tests

Checklists
📝 Author Self Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] This patch was not authored or co-authored using Generative Tooling

📝 Committer Pre-Merge Checklist

[ ] Pull request title is okay.
[ ] No license issues.
[ ] Milestone correctly set?
[ ] Test coverage is ok
[ ] Assignees are selected.
[ ] Minimum number of approvals
[ ] No changes are requested

Be nice. Be informative.

We seem to have difficulty specifying environment variables in test cases so I have difficulty implementing test case about this change.

Codecov Report
Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (e22a7f7) 61.36% compared to head (51f8426) 61.31%.
Report is 3 commits behind head on master.

Files
Patch %
Lines

...g/apache/kyuubi/engine/spark/KyuubiSparkUtil.scala
33.33%
4 Missing and 2 partials :warning:

...rg/apache/kyuubi/engine/spark/SparkSQLEngine.scala
50.00%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5776      +/-   ##
============================================
- Coverage     61.36%   61.31%   -0.05%
  Complexity       23       23
============================================
  Files           607      607
  Lines         35917    35950      +33
  Branches       4927     4936       +9
============================================
+ Hits          22040    22044       +4
- Misses        11494    11519      +25
- Partials       2383     2387       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


suggestion throws an error when triggered on specific text[Bug]

Reproducible in vscode.dev or in VS Code Desktop?

[X] Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

[ ] Not reproducible in the monaco editor playground

Monaco Editor Playground Code
case

Reproduction Steps
input text "case"
trigger suggestion
Actual (Problematic) Behavior
error is thrown in console:
errors.ts:26 Uncaught Error: Debug Failure. Invalid cast. The supplied value [object Object] did not pass the test 'Mo'.
Error: Debug Failure. Invalid cast. The supplied value [object Object] did not pass the test 'Mo'.
at Object.Rn [as cast] (tsWorker.js:9:21239)
at Be (tsWorker.js:247:49873)
at _e (tsWorker.js:247:54111)
at Object.L [as getCompletionsAtPosition] (tsWorker.js:247:30870)
at Object.a [as getCompletionsAtPosition] (tsWorker.js:255:14077)
at lm.getCompletionsAtPosition (tsWorker.js:33955:3086)
at S.fmr (workerMain.js:22:33695)
at f._handleMessage (workerMain.js:22:17684)
at Object.handleMessage (workerMain.js:22:17309)
at w._handleRequestMessage (workerMain.js:22:14120)
at errors.ts:26:12
Expected Behavior
No uncaught error in console
Additional Context
No response

I think this is a bug in typescript, not in monaco.

Should I create a counterpart issue in the Typescript repo ?

Maybe this is because we use an older version of TypeScript.


Analysis map not displayed error token

Localisation do not display map tiles
Error in network console:
https://events.mapbox.com/events/v2?access_token=no-token 401
https://api.mapbox.com/map-sessions/v1?sku=1015Mn4kQeC3N&access_token=no-token
Test URL: https://www.facebook.com/usatoday/videos/10155291452975667/

Error loading after building the plugin
Error message: An error occurred while parsing the WebWorker bundle. This is most likely due to improper transpilation by Babel; please see https://docs.mapbox.com/mapbox-gl-js/api/#transpiling-v2
Css is not loaded

Disable Map component


s3 upload on ios/safari is broken

Describe the bug, optionally with screenshots
OTT
To Reproduce
Using a ship with s3 set up, attempt to upload an image from ios/safari. You'll see that it produces this (taken via iOS simulator):

Additional context:
iOS 16.1

Ok, I don't think this is actually just a safari/ios issue. The issue seems to be that we allow the user to submit the message before the image has successfully uploaded.


LinkedIn sharing

LinkedIn sharing added

Great thanks!
Now that we start having more services, it would be great to have an easy way to choose which ones the user wants. E.g. when we instantiate it:
<script>
$('p').selectionSharer({twitter:true,facebook:true,linkedin:false});
</script>

Yes I was thinking the same. Ill try to do it sometimes tonight or tomorrow
On Feb 16, 2015 12:47 PM, "Xavier Damman"<EMAIL_ADDRESS>wrote:

Great thanks!
Now that we start having more services, it would be great to have an easy
way to choose which ones the user wants. E.g. when we instantiate it:

—
Reply to this email directly or view it on GitHub
https://github.com/xdamman/selection-sharer/pull/8#issuecomment-74546875
.

Cool, was thinking about it too, with some more settings even for the Wordpress plugin like setting your own customer URL shortener etc.

Sorry, apparently this never got merged. Can you rebase so that it can be merged automatically?

What do you mean with rebase it?

I mean pulling master back into your pull request branch and post it again.

On Jun 23, 2015, at 4:24 PM, Hans van Gent<EMAIL_ADDRESS>wrote:
What do you mean with rebase it?
—
Reply to this email directly or view it on GitHub.

Did LinkedIn ever get added to this? If so, I would love to know how to add it.

@cmalexander I don't think it ever did due to merge conflict on the PR. I'll see what I can do this evening.

@cmalexander alright. it should be there now. Will probably need to bump the version to 1.1.0 if you're using npm.

Closing. Feel free to open an issue if there are any for this.

Thanks so much shri3k! Really appreciate it!

Hey @cmalexander sorry it took me a while to get to this but LinkedIn and Facebook usually follows Open Graph Protocol and if not found they have their own algorithm to analyze and display what's on the page that you're sharing.
This is however a bit different in Twitter where they share exactly what you selected.
That said, you can control what LinkedIn and other media sharing platform displays by adding few OGP tags.
Facebook Open Graph
LinkedIn Open Graph - scroll down to "Improve content sharing with Open Graph"
Hope that helps.


Added aria label for collapseAllAriaLabel

Added aria label for PattenrFly Th.expand.collapseAllAriaLabel prop

Codecov Report

Merging #214 (eedb426) into main (5a0c062) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head eedb426 differs from pull request most recent head 3511ca5. Consider uploading reports for the commit 3511ca5 to get more accurate results

Additional details and impacted files

@@          Coverage Diff          @@
##            main    #214   +/-   ##
=====================================
  Coverage   5.73%   5.73%
=====================================
  Files         43      43
  Lines       1726    1726
  Branches     316     316
=====================================
  Hits          99      99
  Misses      1627    1627

Impacted Files
Coverage Δ

src/routes/details/DetailsTable.tsx
0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a0c062...3511ca5. Read the comment docs.


Make sure no color duplicates happen

For example, #FB1 -> #FFBB11 should happen, but it doesn't. So it can lead to duplicate roles.

Also cleanup unused roles.


Clarity on referencing Components Parameters

From @handrews feedback review:
Regarding parameters, the spec states:

A list of parameters to pass to an operation or workflow as referenced by operationId, operationRef, or workflowId. If a Reference Object is provided, it MUST link to parameters defined in components/parameters.

Would that be the Components Object in the entry document or the current document?

I'd recommend making it the current document.  That's been proposed for Discriminator in 3.1.1 (although idk whether it can go into 3.1.1 or if it would be 3.2) and its closer to how both Workflows and Moonwalk do whole-document imports.
I feel l like we are overall moving towards a document-as-local-scope model, rather than the Swagger 2.0 view where it was assumed that the resolved graph looked like a single document and therefore you didn't care about the individual document structure.  That view is incompatible with full JSON Schema support anyway, which is another reason to move away from it.


[ENH] Bep 005: Arterial Spin Labeling

follow up of https://github.com/bids-standard/bids-specification/pull/652
closes https://github.com/bids-standard/bids-specification/issues/41
rendered draft: https://bids-specification.readthedocs.io/en/bep-005/
TCON agenda and notes: https://docs.google.com/document/d/1AVj8SvVnkNcInvYpljFQgc3mpkxnjVvKTbRVigMHKBs/edit

@sappelhoff Hi Stefan, I guess the checks are unsuccessfull now due to the links added in the description of EchoTime and FlipAngle. IS that correct?

Hi Stefan, I guess the checks are unsuccessfull now due to the links added in the description of EchoTime and FlipAngle. IS that correct?

that is correct, however one broken link can already be fixed: ./99-appendices/09-entities.md --> look at the ./ with that you say: look at the 99-appendices directory in the current directory, and find the 09-entities.md file.
However, you have to take into account from where you are linking to ./99-appendices/09-entities.md
--> you are doing that from the 04-modality-specific-files folder. ... and in that folder, there is no 99-appendices folder.
So you need to do ../99-appendices/09-entities.md, because ../ means: "look in the directory above the current one".
And there you'll find 99-appendices

@patsycle you can temporarily edit this line:
https://github.com/bids-standard/bids-specification/blob/727ee8737f82678d03c3860915de6990836dff71/readthedocs.yml#L15
so that it says
 fail_on_warning: false

that way, the draft will continue to be built. Then once your missing "link" is available, we change that back to "true".
Also edit this line in the other file and remove the --strict
https://github.com/bids-standard/bids-specification/blob/727ee8737f82678d03c3860915de6990836dff71/.circleci/config.yml#L14

I temporarily disabled that the documentation build process fails upon encountering a broken link: https://github.com/bids-standard/bids-specification/pull/669/commits/bb8883a3edcd99aa9905e42888dfbd55f7ffc999
I'll  revert that commit before ASL gets merged ... once the currently still unavailable link is there (the BEP001 appendix link)

it's weird that the Travis CI check is not listed anymore in the GitHub user interface. It's just not running, as can be seen here: https://travis-ci.com/github/bids-standard/bids-specification
It says (when logged in):

Builds have been temporarily disabled for public repositories due to a negative credit balance. Please go to the Plan page to replenish your credit balance or alter your Consume paid credits for OSS setting.

Seems to me like we should switch from Travis to some CI service that does not limit the amount of hourse we can run without paying? Or we can discuss whether we have funding for paying for it (I don't though :slightly_smiling_face: ).
cc @bids-standard/maintainers

Nothing magic about Travis. Let's just switch to GitHub actions.

https://github.com/bids-standard/bids-specification/pull/689 should update this branch/PR and also resolve the conflict that occurred due to merging BEP001 PRs.

Per today's maintainers call, I think this PR is stable enough that we can start working on the schema components. I think I will open a PR directly to bep-005 that the BEP group can review. Does that sound good?

Per today's maintainers call, I think this PR is stable enough that we can start working on the schema components. I think I will open a PR directly to bep-005 that the BEP group can review. Does that sound good?

I think I will open a PR directly to bep-005 that the BEP group can review.

That would have been my suggestion.

I think I will open a PR directly to bep-005 that the BEP group can review.

That would have been my suggestion.

@patsycle @HenkMutsaerts I just merged the final BEP-001 PR. That's causing some merge conflicts. I'm happy to resolve them unless you would prefer to do it.

@patsycle @HenkMutsaerts I just merged the final BEP-001 PR. That's causing some merge conflicts. I'm happy to resolve them unless you would prefer to do it.

@patsycle @HenkMutsaerts I just merged the final BEP-001 PR. That's causing some merge conflicts. I'm happy to resolve them unless you would prefer to do it.

The conflicts look easy resolvable, I don't mind who does it :) I'm working on making ExploreASL read ASL-BIDS, in combination with bids-matlab, then we can really process all our BIDS ASL examples, which I like as a final test before merging bep005, should be done hopefully around this weekend.

@patsycle @HenkMutsaerts I just merged the final BEP-001 PR. That's causing some merge conflicts. I'm happy to resolve them unless you would prefer to do it.

The conflicts look easy resolvable, I don't mind who does it :) I'm working on making ExploreASL read ASL-BIDS, in combination with bids-matlab, then we can really process all our BIDS ASL examples, which I like as a final test before merging bep005, should be done hopefully around this weekend.

@HenkMutsaerts @patsycle we can also merge this PR (after @effigies resolved conflicts, thanks for offering), and wait with the release for a few days.

that would give you the chance to test everything for a few more days
if during these days (before the release) you notice some things that need to be remedied, you can make a small edit PR

The big benefit would be that we get this huge PR merged in, and that other PRs can continue more easily without being concerned about merge conflicts being introduced here and there.
I don't see a drawback to that approach, does anyone object?

@HenkMutsaerts @patsycle we can also merge this PR (after @effigies resolved conflicts, thanks for offering), and wait with the release for a few days.

that would give you the chance to test everything for a few more days
if during these days (before the release) you notice some things that need to be remedied, you can make a small edit PR

The big benefit would be that we get this huge PR merged in, and that other PRs can continue more easily without being concerned about merge conflicts being introduced here and there.
I don't see a drawback to that approach, does anyone object?

@sappelhoff Before doing that, we were thinking  about changing one final thing (e.g. *_labeling.jpg to *_asllabeling.jpg, for consistency with the naming of aslcontext.tsv). I will do that today.  But, how do I change this for the schemas, or could @tsalo help me out with this?

@sappelhoff Before doing that, we were thinking  about changing one final thing (e.g. *_labeling.jpg to *_asllabeling.jpg, for consistency with the naming of aslcontext.tsv). I will do that today.  But, how do I change this for the schemas, or could @tsalo help me out with this?

@HenkMutsaerts @patsycle we can also merge this PR (after @effigies resolved conflicts, thanks for offering), and wait with the release for a few days.

that would give you the chance to test everything for a few more days
if during these days (before the release) you notice some things that need to be remedied, you can make a small edit PR

The big benefit would be that we get this huge PR merged in, and that other PRs can continue more easily without being concerned about merge conflicts being introduced here and there.
I don't see a drawback to that approach, does anyone object?

No, this seems a good idea!

@HenkMutsaerts @patsycle we can also merge this PR (after @effigies resolved conflicts, thanks for offering), and wait with the release for a few days.

that would give you the chance to test everything for a few more days
if during these days (before the release) you notice some things that need to be remedied, you can make a small edit PR

The big benefit would be that we get this huge PR merged in, and that other PRs can continue more easily without being concerned about merge conflicts being introduced here and there.
I don't see a drawback to that approach, does anyone object?

No, this seems a good idea!

Conflicts resolved and appendix renumbered, since qMRI got XI. Please review the changes to be sure I didn't accidentally revert something I shouldn't have.

Conflicts resolved and appendix renumbered, since qMRI got XI. Please review the changes to be sure I didn't accidentally revert something I shouldn't have.

@effigies It all looks good, couldn't find any errors. @sappelhoff Linkchecker is failing though..

@effigies It all looks good, couldn't find any errors. @sappelhoff Linkchecker is failing though..

@patsycle I re-ran the linkchecker and it passed the second time. That issue was only temporary.
Now the BEP is merged :tada: thanks to the team and the reviewers! Now - as suggested - you can make some final checks together with @HenkMutsaerts and his pipeline ... and if everything is fine, we can release soon, because BEP001 has also been merged.
That'll be a big celebration with BEP001 and BEP005 in for BIDS 1.5 :-)

@patsycle I re-ran the linkchecker and it passed the second time. That issue was only temporary.
Now the BEP is merged :tada: thanks to the team and the reviewers! Now - as suggested - you can make some final checks together with @HenkMutsaerts and his pipeline ... and if everything is fine, we can release soon, because BEP001 has also been merged.
That'll be a big celebration with BEP001 and BEP005 in for BIDS 1.5 :-)

PS: Very sorry to merge this so early in the morning ... The champagne from the fridge would taste much better in the evening :smile:

PS: Very sorry to merge this so early in the morning ... The champagne from the fridge would taste much better in the evening :smile:

PS: Very sorry to merge this so early in the morning ... The champagne from the fridge would taste much better in the evening 😄

@sappelhoff No worries, it is already noon here. Perfect timing to open a bottle ;)

PS: Very sorry to merge this so early in the morning ... The champagne from the fridge would taste much better in the evening 😄

@sappelhoff No worries, it is already noon here. Perfect timing to open a bottle ;)


High memory consumption

Describe the bug
When we extract a large number of hosts or vulnerabilities, we see a large memory consumption.

Expected behavior

The memory consumption must be constant and predictable during the data recovery.
Current behavior

Since we have a huge and increasing number of instances, the memory consumption increases to the point of reaching more than 10Go of RAM memory.
Type of error we have from AWS step function :
{
  "errorType": "Runtime.ExitError",
  "errorMessage": "RequestId: XXXX Error: Runtime exited with error: signal: killed"
}

Possible solution

During our investigation, we have concluded the function execute is the root cause of the consumption. One way to solve this is to create a generator instead of a list that increases in size at each loop.
Steps to reproduce

Have more than 6000 hosts onboarded on primsa with vulnerabilities.
Run a script on an environment with a memory size limited to 4 Go.
Constat the crash at one point, with a MemoryError or an ExitError

Context

In our enterprise context, we want to create a useful dashboard to animate our team around vulnerabilities and patch these vulnerabilities.
Your Environment

Version used: The latest eu SaaS version
Environment name and version: Container image on python:3.11.6-slim-bullseye with prismacloud-api==5.2.8 and aws-lambda-powertools==2.26.0

I would like to propose a PR for this bug

@mgappa happy to review your PR when submitted.


Add configurable timeout for config, convert, and validate plugins

Also run 'go fmt' on changed files

Justification for this PR - See 2. in https://github.com/bitsbeats/drone-tree-config/issues/26
Though the issue was specific to a config plugin, I implemented the timeout option for validate and convert also. Projecting a bit -- it seemed useful to do so.

Great work, now it's just missing some retry logic :P

Perhaps another PR. :)

@tboerger thanks for the feedback and review.

@tboerger and reviewers: it turns out there is another 1 minute timeout in drone-go that always wins -- https://github.com/drone/drone-go/blob/master/plugin/internal/client/client.go#L96 ... As a result, this PR will have no impact until the drone-go timeout can be influence by the config. I will submit a change to drone-go and update this PR soon.

This PR is linked with the following proposed change in drone-go - https://github.com/drone/drone-go/pull/52
If it helps to validate these changes, the following config plugin can be used;
https://github.com/mach6/drone-delay-config

@tboerger @bradrydzewski Should I go ahead and add a TIMEOUT config option for all of the extensions?  Also, safe to assume this will be merged once a new version of drone-go is released? Anything you need from me?

@bradrydzewski anything you need from me on this PR? Are we waiting for a new release of drone-go perhaps?


The Scary Vault of Ur

Trying to use a https://www.wowhead.com/item=203720/restorative-water but had already used it so it might not be able to actually be used where im using it but this error poped up when trying to use it again.
2x [ADDON_ACTION_FORBIDDEN] AddOn 'BetterBags' tried to call the protected function 'UNKNOWN()'.
[string "@!BugGrabber/BugGrabber.lua"]:481: in function <!BugGrabber/BugGrabber.lua:481>
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "=[C]"]: in function UseContainerItem' [string "@FrameXML/ContainerFrame.lua"]:1424: in function <FrameXML/ContainerFrame.lua:1333> [string "=[C]"]: in function ContainerFrameItemButton_OnClick'
[string "@FrameXML/ContainerFrame.lua"]:1476: in function <FrameXML/ContainerFrame.lua:1463>
Locals:
_ = Frame {
RegisterEvent =  defined @!BugGrabber/BugGrabber.lua:487
0 =
UnregisterEvent =  defined @!BugGrabber/BugGrabber.lua:487
SetScript =  defined @!BugGrabber/BugGrabber.lua:487
}
event = "ADDON_ACTION_FORBIDDEN"
events =  {
ADDON_ACTION_BLOCKED =  defined @!BugGrabber/BugGrabber.lua:553
ADDON_ACTION_FORBIDDEN =  defined @!BugGrabber/BugGrabber.lua:553
PLAYER_LOGIN =  defined @!BugGrabber/BugGrabber.lua:547
LUA_WARNING =  defined @!BugGrabber/BugGrabber.lua:562
ADDON_LOADED =  defined @!BugGrabber/BugGrabber.lua:507
}

Are you able to reproduce this 100% of the time?

I've confirmed how this happens, and can reproduce it 100% of the time, which is great. I need to investigate a fix for it, which is extremely high priority -- I expect a fix today.

This is fixed in .64 -- thanks for the heads up!


Docker Install Script and README Hotfix

Minor hotfix to the docker-install.sh script and README.
The script now fetches the latest version published on Github which should be equivalent to the Docker Image tag.

A release isn't necessary for this.


can't build on CLI for target nRF_52840

Error Logs:
Compile [ 37.9%]: GenericGap.cpp
[Warning] BLE.h@1049,39: 'virtual ble_error_t Gap::disconnect(Gap::DisconnectionReason_t)' is deprecated: Use disconnect(Handle_t, DisconnectionReason_t) instead. [-Wdeprecated-declarations]
Compile [ 38.1%]: GenericSecurityManager.cpp
[Warning] BLE.h@1049,39: 'virtual ble_error_t Gap::disconnect(Gap::DisconnectionReason_t)' is deprecated: Use disconnect(Handle_t, DisconnectionReason_t) instead. [-Wdeprecated-declarations]
[Error] GenericSecurityManager.h@357,15: 'public_key_t' does not name a type; did you mean 'public_key_coord_t'?
[Error] GenericSecurityManager.h@358,15: 'public_key_t' does not name a type; did you mean 'public_key_coord_t'?
[Error] GenericSecurityManager.cpp@722,6: no matching function for call to 'ble::generic::GenericSecurityManager::crypto_toolbox_f4(const public_key_coord_t&, const public_key_coord_t&, ble::oob_lesc_value_t&, ble::oob_confirm_t&)'
[Error] GenericSecurityManager.cpp@756,6: prototype for 'bool ble::generic::GenericSecurityManager::crypto_toolbox_f4(const public_key_coord_t&, const public_key_coord_t&, const oob_lesc_value_t&, ble::oob_confirm_t&)' does not match any in class 'ble::generic::GenericSecurityManager'
[Error] GenericSecurityManager.h@356,17: candidate is: static bool ble::generic::GenericSecurityManager::crypto_toolbox_f4(const int&, const int&, const oob_lesc_value_t&, ble::oob_confirm_t&)
[Error] GenericSecurityManager.cpp@1049,5: no matching function for call to 'ble::generic::GenericSecurityManager::crypto_toolbox_f4(const public_key_coord_t&, const public_key_coord_t&, ble::oob_lesc_value_t&, ble::oob_confirm_t&)'
[ERROR] In file included from ./mbed-os/features/FEATURE_BLE/ble/generic/GenericGap.h:22:0,
from ./mbed-os/features/FEATURE_BLE/ble/generic/GenericSecurityManager.h:25,
from .\mbed-os\features\FEATURE_BLE\source\generic\GenericSecurityManager.cpp:19:
./mbed-os/features/FEATURE_BLE/ble/BLE.h: In member function 'ble_error_t BLE::disconnect(Gap::DisconnectionReason_t)':
./mbed-os/features/FEATURE_BLE/ble/BLE.h:1049:39: warning: 'virtual ble_error_t Gap::disconnect(Gap::DisconnectionReason_t)' is deprecated: Use disconnect(Handle_t, DisconnectionReason_t) instead. [-Wdeprecated-declarations]
return gap().disconnect(reason);
^
I

ARM Internal Ref: IOTCLT-2736

Hi @surajdagar ,
This is mbed-os build issue where you would need to have the correct setup for this board.
@dlfryar Do you have any pointers for compiling client on this board ?

Latest build steps/script and config attached.
build.sh.txt
mbed_lib.json.txt

@surajdagar is this issue resolved for you?


[PECO-1260] Support results compression

Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8c590d7) 90.51% compared to head (695a814) 90.41%.

Files
Patch %
Lines

lib/result/CloudFetchResultHandler.ts
66.66%
1 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
- Coverage   90.51%   90.41%   -0.11%
==========================================
  Files          62       62
  Lines        1423     1429       +6
  Branches      238      242       +4
==========================================
+ Hits         1288     1292       +4
- Misses         84       85       +1
- Partials       51       52       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


New query for query'ing null workflowname

Placeholder until develop is fixed.  This adds a new query that will query null workflownames.  This fixes the ga4gh endpoint.

Changes Unknown when pulling 3372a3ae9ceb3d6466a26ec5e2ba15d510c2693c on feature/ga4ghEndpointFix into ** on develop**.

Coverage decreased (-0.02%) to 71.765% when pulling cd8d266011579aa21233a261f84877ad33a3e751 on feature/ga4ghEndpointFix into ce828ebdc5cc16a54deaea3bbfe3f816055c3670 on develop.

Coverage decreased (-0.02%) to 71.765% when pulling 0a93bb5aac3c28f7454ca17ab2b22c29aa1518bf on feature/ga4ghEndpointFix into ce828ebdc5cc16a54deaea3bbfe3f816055c3670 on develop.


[Event Request] Codeunit 7312 "CreatePick" new event publisher

Hi,
we need a new Publisher in procedure ValidateQtyForSN in codeunit "CreatePick".
Current Code of 19.4 is the following:
    local procedure ValidateQtyForSN(WhseItemTrackingLine: Record "Whse. Item Tracking Line")
    begin
        if not (WhseItemTrackingLine."Quantity (Base)" in [-1, 0, 1]) then
            Error(ValidValuesIfSNDefinedErr, WhseItemTrackingLine.FieldCaption("Quantity (Base)"), WhseItemTrackingLine."Quantity (Base)");

        if not (WhseItemTrackingLine."Qty. to Handle (Base)" in [-1, 0, 1]) then
            Error(ValidValuesIfSNDefinedErr, WhseItemTrackingLine.FieldCaption("Qty. to Handle (Base)"), WhseItemTrackingLine."Qty. to Handle (Base)");
    end;

After adding the event the code should be as followed:
    local procedure ValidateQtyForSN(WhseItemTrackingLine: Record "Whse. Item Tracking Line")
    var
        IsHandled: Boolean;
    begin
        OnBeforeValidateQtyForSN(WhseItemTrackingLine,IsHandled);
        if IsHandled then
            exit;

        if not (WhseItemTrackingLine."Quantity (Base)" in [-1, 0, 1]) then
            Error(ValidValuesIfSNDefinedErr, WhseItemTrackingLine.FieldCaption("Quantity (Base)"), WhseItemTrackingLine."Quantity (Base)");

        if not (WhseItemTrackingLine."Qty. to Handle (Base)" in [-1, 0, 1]) then
            Error(ValidValuesIfSNDefinedErr, WhseItemTrackingLine.FieldCaption("Qty. to Handle (Base)"), WhseItemTrackingLine."Qty. to Handle (Base)");
    end;

    [IntegrationEvent(false, false)]
    local procedure OnBeforeValidateQtyForSN(WhseItemTrackingLine: Record "Whse. Item Tracking Line";var IsHandled: Boolean)
    begin
    end;

Could you please add the OnBeforeValidateQtyForSN publisher to the procedure?
Thanks in advanced!

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


View of dock symbols in fog shows all symbols superimposed

Original report (archived issue) by Brian Bingham (Bitbucket: brian_bingham).

When adding fog to the scene, the dock symbols have a ghosting artifact evident .
How to reproduce:

In default branch run  roslaunch vrx_gazebo dock.launch verbose:=true

Should show a god’s eye view that looks as expected

Switch to sandisland_add_fog branch which just adds fog to the sand island scene (https://osrf-migration.github.io/vrx-gh-pages/#!/osrf/vrx/commits/98149819c5d3f42ac87ba2f4e92cace4d61d53df?at=sandisland_add_fog)

re-make and re-run and now the GUI view looks like this..

I also verified that this superposition of the symbols shows up  in the camera perspective

For the purposes of the VRX competition we could use simpler dock models that don’t have all the placard symbols to see if that alleviates the problem.

Confirming this problem still exists and also affects the new placards for VRX 2022. I propose we revisit this issue after the port to Gazebo Sim.


Improving the Badges component primitive and adding Examples to the web

I think there are still some features that could be added to the Badge component primitive. I'm thinking about adding the following props:

[ ]  dot - just like in the tailwind UI docs, add an option to have a dot on the left side of the text inside the badge.
[ ] rounded/pill - this option would make the badges completely rounded - pill-shaped.
[ ] noBorder or border - this option would add or remove a border from the Badge.

For each new prop and all the existing ones, I will create an example as well.
Do you guys have any other ideas or thoughts about the props I proposed @iamhectorsosa @jvorcak ?

Looking good! Remember to test these, I know some clients won't fully support the props mentioned (i.e., rounded corners).

This PR should resolve this issue, however, there are still some issues with some clients:

Outlook on Windows - badges are rendered but the styling is not consistent, check it out here for example.
Office 365 Dark (macOS) - check the link above to view it.
Dot Badges - testi.at link to the test, Outlook + two other do not render it correctly (yahoo and gmail on IE 11)


Multipart request support for Core client

The OkHttp and Apache clients both have custom Multipart request support based on their client libraries - let's add some sort of default support for the core client, either a hand-rolled minimal support solution or one based on an external library (apache download or email library?)
Use the JavaMail Multipart API for generic multipart request/response handling - the client-specific APIs can stay but this generic handler should work for all three cases as well.

I have a working version of this... it just needs a bit more testing and some documentation.

This is done in the development branch.


update Springs plugin to the latest API

Thanks! I had more or less got there myself with the API changes, but not with the plugin structure.


'input_items' in field definition is missing on gui

Hi @perak,
from API:
input_items	array of input_item	Item list for input type "radio" and "select"
is missing on gui.
Thx

It's there, but not in form, it's in the tree (well, yes, GUI is little bit inconsistent)

OK, thx.


Bug: Searching categories request fails when there's trailing whitespace

https://github.com/user-attachments/assets/4a96d9f2-a678-4a23-8c9b-836b10a79ce8

Space is meaningful sometimes:
https://github.com/user-attachments/assets/8810147c-8f4b-4990-8ab0-b0bc0a2348a8

I see 👀, guess we can't trim it.

Sometimes I know there is a category like Views at Eiffel Tower or Views from Eiffel Tower or Views on Eiffel Tower, that starts with Views but I do not know whetherthe second word is at or from or on, so I enter a space and see what appears. My example is not real but you get the idea. 🙂


Create rpm lock file, when tzdata is required

As per title

/hold to check on testrun in https://github.com/openshift-knative/eventing/pull/943

/unhold


Duplicate Deployments for Dashboards

Hi,
while I'm playing around with monaco I probably found a bug regarding the deployment of dashboards. Im using the following files (pleas adapt  with values matching your dynatrace instance):
environments.yaml:
dev:
  - name: "DEV"
  - env-url: "<FILL>"
  - env-token-name: "DYN_TOKEN"

dev/dashboard/config.yaml:
config:
  - Dashboard: "Dashboard.json"

Dashboard:
  - name: Dashboard Test

dev/dashboard/Dashboard.json:
{
  "dashboardMetadata": {
    "name": "{{.name}}",
    "shared": true,
    "owner": "<FILL>"
  },
  "tiles": [
    {
      "name": "Header",
      "tileType": "HEADER",
      "configured": true,
      "bounds": {
        "top": 0,
        "left": 0,
        "width": 304,
        "height": 38
      },
      "tileFilter": {}
    }
  ]
}

Observed behaviour: When I deploy this configuration multiple times, multiple dashboards will be created.
Expected behaviour: Dashboard will be created if it's not existing yet, otherwise it will be updated.

Hi @zenobios, using the monaco API key, are you able to see Dashboard Test calling GET /api/config/v1/dashboards API?

Hey @tatomir146. Thx for the hint, that was the problem. I expected that if an API key has write permissions it also has implicit read access. However, its working now :)


Unable to support response description with the same output schema and different response content-types

Environment:

Python version: 3.12
Operating system: Linux
Flask version: 3.1.0
flask-openapi3 version: 4.0.3

My attempt
# Endpoints
api = APIBlueprint(
    "cv",
    __name__,
    url_prefix="/api/v1/sam2",
    # disable openapi UI
    doc_ui=True,
)
api.components_schemas["SAM2InferenceOutputEntry"] = SAM2InferenceOutputEntry.model_json_schema()
api.components_schemas["SAM2InferenceOutput"] = SAM2InferenceOutput.model_json_schema()

@api.post(
    "/inference",
    responses={
        HTTPStatus.OK: {
            "description": "Inference output",
            "content": {
                # Content type
                "application/json": {"schema": {"$ref": "#/components/schemas/SAM2InferenceOutput"}},
                "application/bson": {"schema": {"$ref": "#/components/schemas/SAM2InferenceOutput"}},
            },
        },
    },
)
@tracer.capture_method
def create_sam2_inference(body: SAM2InferenceInput) -> Response:
    """Perform inference with SAM2 model.

    Perform inference with SAM2 model using the given input.
    """
    output = perform_sam2_inference(body)
    return respond(output)

But the generated json for the swagger schema has validation errors
Resolver error at responses.200.content.application/bson.schema.$ref
Could not resolve reference: JSON Pointer evaluation failed while evaluating token "$defs" against an ObjectElement

I even tried this as it seemed natural and less verbose, but nothing gets registered
{
    # Content type
    "application/json": SAM2InferenceOutput,
    "application/bson": SAM2InferenceOutput,
}

But it crashes

Resolver error at responses.200.content.application/bson.schema.$ref
Could not resolve reference: JSON Pointer evaluation failed while evaluating token "$defs" against an ObjectElement

Sorry, I did not reproduce your issue, and you need to provide a detailed description.

So, when I use this:
@api.post(
    "/inference",
    # responses={HTTPStatus.OK: SAM2InferenceOutput},
    # openapi_extra={"application/bson": {"schema": {"$ref": "#/components/schemas/SAM2InferenceOutput"}}},
    responses={
        HTTPStatus.OK: {
            "description": "Inference output",
            "content": {
                # Content type
                "application/json": {"schema": {"$ref": "#/components/schemas/SAM2InferenceOutput"}},
                "application/bson": {"schema": {"$ref": "#/components/schemas/SAM2InferenceOutput"}},
            },
        },
    },
)

And then I open swagger-ui, I see

It's strange I still can't surface your question, can you provide a minimal py file?
My Environment:
flask-openapi3 version: 4.0.3
flask-openapi3-swagger version: 5.18.2

@api.post(
    "/inference",
    responses={
        HTTPStatus.OK: {
            "description": "Inference output",
            "content": {
                # Content type
                "application/json": {"schema": {"$ref": "#/components/schemas/SAM2InferenceOutput"}},
                "application/bson": {"schema": {"$ref": "#/components/schemas/SAM2InferenceOutput"}},
            },
        },
    },
)

only this code is right, and other code is wrong.

Ok, thanks!

Re-opened, actually that code is not right either, because one has to deal with this manually
api.components_schemas["SAM2InferenceOutputItem"] = SAM2InferenceOutputItem.model_json_schema()
api.components_schemas["SAM2InferenceInput"] = SAM2InferenceInput.model_json_schema()
api.components_schemas["SAM2InferenceOutput"] = SAM2InferenceOutput.model_json_schema()

Now, because schemas have inner references, the $refs are not resolved by flask-openapi3 and neither this will work (see schemas here under)
from enum import Enum
from typing import Generic, TypeVar

import numpy as np
from pydantic import AnyUrl, BaseModel, Field

T = TypeVar("T")

class Response(BaseModel, Generic[T]):
    data: T
    message: str | None = Field(None, description="Exception Information")
    errors: list[str] | None = Field(None, description="List of error messages")

    class Config:
        use_enum_values = True
        arbitrary_types_allowed = True
        openapi_extra = {"content": {"application/bson": {"schema": {"$ref": "#/components/schemas/Response"}}}}

class Project(BaseModel):
    Version: str
    Environment: str

class InputSourceEnum(str, Enum):
    bytes = "bytes"
    url = "url"
    s3 = "s3"
    local = "local"

class InputTypeEnum(str, Enum):
    image = "image"
    video = "video"

class SAM2PromptTypeEnum(str, Enum):
    point = "point"
    rectangle = "rectangle"

class SAM2ModelEnum(str, Enum):
    sam2_1_hiera_base_plus = "sam2.1_hiera_base_plus"
    sam2_1_hiera_large = "sam2.1_hiera_large"
    sam2_1_hiera_small = "sam2.1_hiera_small"
    sam2_1_hiera_tiny = "sam2.1_hiera_tiny"

class SAM2InferencePrompt(BaseModel):
    type: SAM2PromptTypeEnum = Field(..., description="Type of the input (either 'point' or 'rectangle')")
    label: int = Field(0, description="Label associated with the input (default: 0)", ge=0)
    data: list[int] = Field(..., description="List of integer data points", min_items=1)

    class Config:
        use_enum_values = True

class SAM2InferenceInput(BaseModel):
    source: InputSourceEnum = Field("url", description="Input source, either 'url' or 'bytes'")
    type: InputTypeEnum = Field("image", description="Input type, either 'image' or 'video'")
    model: SAM2ModelEnum = Field("sam2.1_hiera_base_plus", description="Model type")
    prompt: list[SAM2InferencePrompt] = Field(..., description="List of inference prompts")
    frame: int | None = Field(None, description="Frame index for video input")
    data: AnyUrl | bytes | np.ndarray | None = Field(
        None, description=("URI string, or for 'bytes' source with 'application/bson' input, a list of bytes " "representing the image or video content")
    )

    class Config:
        use_enum_values = True
        arbitrary_types_allowed = True

class SAM2InferenceOutputItem(BaseModel):
    counts: str = Field(..., description="Counts in RLE format")
    size: list[int] = Field(..., description="Size of the image")

class SAM2InferenceOutput(BaseModel):
    items: list[SAM2InferenceOutputItem] = Field([], description="List of inference results")

    class Config:
        title = "SAM2InferenceOutput"
        use_enum_values = True
        arbitrary_types_allowed = True

Sorry, I finally understand what you mean. You don't want to manually add the model schema to api.components_schemas.
In fact, you can handle it by configuring openapi_extra.
By the way, Config is the old usage in pydantic, and the new one should use model_config.
class SAM2InferenceOutput(BaseModel):
    items:list[str]

    model_config = {
        "openapi_extra":{
            "content": {
                "application/json": {"schema": {"$ref": "#/components/schemas/SAM2InferenceOutput"}},
                "application/bson": {"schema": {"$ref": "#/components/schemas/SAM2InferenceOutput"}},
            }
        }
    }

@api.post(
    "/inference",
    responses={
        HTTPStatus.OK: SAM2InferenceOutput
    },
)
@tracer.capture_method
def create_sam2_inference(body: SAM2InferenceInput) -> Response:
    ...

Thanks, but that above still won't work as the SAM2InferenceOutput model is not registered anywhere, the proposed PR does take care of that too.

The SAM2InferenceOutput in the example I gave will be registered unless you use it differently.
class SAM2InferenceOutput(BaseModel):
    items:list[str]

    model_config = {
        "openapi_extra":{
            "content": {
                "application/json": {"schema": {"$ref": "#/components/schemas/SAM2InferenceOutput"}},
                "application/bson": {"schema": {"$ref": "#/components/schemas/SAM2InferenceOutput"}},
            }
        }
    }

@api.post(
    "/inference",
    responses={
+        HTTPStatus.OK: SAM2InferenceOutput
    },
)
@tracer.capture_method
def create_sam2_inference(body: SAM2InferenceInput) -> Response:
    ...

I don't quite agree with the solution in your two PRs, because she disrupts the openapi definition specification, which I would prefer to implement in the openapi_extra of model_config, provided that the openapi specification is followed, of course.
If possible, you can modify your two PRs to implement multiple media types in responses and request body.

I really don't understand what you are saying with disrupt, but it is your project. Metadata in openapi_extra is an option, but it is obscure. Models should be about data, not about input/ouput formats, but that is my opinion. Why not both ? One has to dance with api behavior in so many places, that is why I say it is obscure. Even if it is only in openapi_extra, it is still required to manually register the models schemas, which currently is not handled properly and there is no documentation for it.
In any way, the project is still great!


Add Support for Watching Log4Net Files

Log4net can be configured to watch the config file for changes and
re-load it witout stopping the applicaiton. This is quite useful for
services.
You can configure log4net to do this with assembly attributes or an
entry in the App.config file. This adds the ability to specify it in the
.UseLog4Net call too for ortogonality.

Merged.


Hooking up text issue

Would it be possible to somehow hook up or manualy translate text such as this:
" <color=#ff6347><闇強化>闇属性のスキル威力増加　…5％ "
" <color=#000000><賢者>消費ＭＰ減少　　　　　　　…8％ "
It doesnt show up in _AutoGeneratedTranslations and I was able to catch it using other text hooker.

I am not sure why that text specifically would not be caught by the plugin. The plugin should have no problem picking up any text, even if it has markup.
To help you I would need a way to reproduce the issue on my end.

The title is Gears of Dragoon 2 ~Reimei no Fragments~
https://vndb.org/v17988
Here is the shop site at which you can download a trial version (体験版ダウンロード)(881.36MB)
https://www.dlsite.com/pro/work/=/product_id/VJ010100.html
The text in question shows up in character screen at enchancements list, although I just tried it for trial version and it works fine.


Internal references pointing out of the Components Object fixed fields

Hi,
I recently came across an OpenAPI Spec file from a customer where some path-level parameters/responses/headers/schemas were defined through an internal reference, but having $ref pointing to a parameter/response/header/schema defined in a previous path and not to one of the Components Object fixed fields, like in:
openapi: 3.0.2
paths:
  '/a':
    parameters:
      - name: myParam
        in: header
        get:
          responses:
            '200':
              description: some description
              headers:
                header1:
                  schema:
                    type: string
  '/b':
    parameters:
      - $ref: '#/paths/~1a/parameters/0'
      get:
        responses:
          '200':
            description: some description
              headers:
                header1:
                  $ref: '#/paths/~1a/parameters/get/responses/200/headers/header1'

For parameters and responses the spec is somehow normative and says for instance (parameters property of the Operation Object) : "The list can use the Reference Object to link to parameters that are defined at the OpenAPI Object's components/parameters."
Questions:
- Does such a formulation forbid the use of a Reference Object pointing outside of #/components/parameters or not? If yes, shouldn't we make it even more clear that the targetted parameters/responses MUST be defined in OpenAPI Object's components/parameters or components/responses
- Does this forbid also the use of external references for parameters and responses?
For request bodies, callbacks, examples, schemas, links and headers the spec is not normative at all when it comes to where should be put the targets of JSON References, like for instance the definition of the schema property of the Media Type Object: "The schema defining the content of the request, response, or parameter."
Question: Is the difference between parameters/responses and the others on purpose? If yes, would someone be so kind as to explain me why (apart from the reason that external references can be used), and if not would it be possible to amend the spec so that it says that internal references MUST be linked to components defined in the corresponding fixed field of the Components Object?
I've read #1679  but I'm not sure what is the answer, between @darrelmiller position and @MikeRalphson one.
Thanks!

@darrelmiller I don't think that we can change this prior to Moonwalk because restricting $ref targets in 3.2 would invalidate OADs that are valid under 3.1.  PR #3732 is the first of several PRs to try to put boundaries around the more confusing reference usages without causing a breaking change, which is as close as we could get.
That PR does not forbid $ref to non-Components, and (as much as I agree with you) I don't think we could get away with doing that.  But if you think we should try, I can write a PR along the same lines as #3732.  Otherwise I think this should just get closed - we're already debating a totally different approachin Moonwalk.

The specification is not clear enough to make the claim that you cannot $ref to non-components. But I would caution authors that some tooling may not support these $refs and it may be necessary to preprocess the document to inline the references before the tooling can work.  I think we can close this issue as I believe we will make sure to be very clear about this in moonwalk.

Previous comment says we can close, so closing :-)


Add interrupts support for I3C target

This maps the internal queues in the I3C emulator peripheral to the interrupt controller, and modifies the tests so that they no longer manually poll.
I also added a new package, romtime, for drivers and utilities that are useful for both ROM and Runtime. For now, this contains an implementation of print! and println! that output to the emulator UART immediately, which is useful for both ROM and when running in Tock kernel when debug! may not be available (such as during tests or interrupts).

Thanks!


Running into Error(500)

error vscode [UriError]: If a URI contains an authority component, then the path component must either be empty or begin with a slash ("/") character
error vscode Error: [UriError]: If a URI contains an authority component, then the path component must either be empty or begin with a slash ("/") character
at /usr/lib/code-server/lib/vscode/out/vs/server/entry.js:124:875
at new u (/usr/lib/code-server/lib/vscode/out/vs/server/entry.js:125:166)
at new d (/usr/lib/code-server/lib/vscode/out/vs/server/entry.js:126:773)
at Function.from (/usr/lib/code-server/lib/vscode/out/vs/server/entry.js:126:213)
at n (/usr/lib/code-server/lib/vscode/out/vs/server/entry.js:546:1003)
at t.Vscode.initialize (/usr/lib/code-server/lib/vscode/out/vs/server/entry.js:547:174)
at async process. (/usr/lib/code-server/lib/vscode/out/vs/server/entry.js:553:517)
[2021-04-09T19:50:18.382Z] error VS Code exited unexpectedly with code 1

What do you mean? can you give an example? @jalotra


Introduce new policy to skip post verification of dll exports

Describe the pull request
Introduce new policy to skip post verification of dll exports. There are no defects when policy is not used in a port.

What does your PR fix? Fixes issue #9641

Thanks for the PR and rationale!


Renamed Example folder to Sample to fix Carthage dependency manage...

Fixed: https://github.com/AliSoftware/OHHTTPStubs/issues/97

This will probably break pod try support.

Please don't drop Carthage support. A lot of people use it instead of cocoapods

I must +1 the petition of not dropping Carthage support :+1:

Be reassured, I won't drop it… but I won't corrupt/amend my project just to fix/workaround Carthage bugs either (and #97 — which this PR was a workaround for — is indeed a Carthage issue, not mine).

:+1: for that view. I think Carthage should add the flexibility to specify a target.


PP-2655 - Reusable client side form validation

Usually we write validation into the controllers
which ends up meaning we have a lot of duplication
which is a shame and is loooong.
So this is a generic browserified validation engine.
To use it anywhere you need to do a couple of things

add data-validate="true" to the form you want to validate
add data-validate to each of the input/select/textarea's you want validated
by default it will check that the value is not blank but you can add a space separated list of validations e.g. data-validate="required currency"

Currently I have only written validators for isCurrency
and isEmpty. You can add new ones to field-validation-checks.js
The validator expects them to return a string with the error message or else false

Things I wonder/worry about

Have I got carried away and used let too much?
Do in need the for loop here?
Have a included it within browsered.js in the right way, do I need to use module.export?


Backup both databases and metadata with new backup format

Version: InfluxDB 1.5.1/1.5.2
OS: Debian 9.4
Step to reproduce: run influxd backup -portable path/to/backup on the first machine and run influxd restore -portable path/to/backup on the second machine.
Expected result: users from the first machine also got replicated on the second machine along with databases.
Actual result: several shards do not get replicated, all belong to _internal database.
Additional information: the old way of backing up metadata and each database works. There is no need to backup _internal database (perhaps it's included in the metadata backup?). But I need to backup everything without knowing what database is there. And I tried mixing the new full backup and the old metadata backup, but it also didn't work (I can see the users, databases and measurements, but cannot see any series).
Edit: is copying the whole /var/lib/influxdb directory and /etc/influxdb/influxdb.ini a legit way to backup influxdb?

duplicate: https://github.com/influxdata/influxdb/issues/9723

Closing as duplicate


Tests don't run in Yaml pipeline

Where are you running it?
You can run the extensions in the cloud or on-premise

Azure DevOps Service (VSTS)

Version of Extension/Task
Latest version from market place
Expected behaviour and actual behaviour
I have written a yaml pipeline as below:

task: Pester.PesterRunner.Pester-Task.Pester@9
displayName: 'Pester Test Runner'
inputs:
scriptFolder: '$(Build.SourcesDirectory)*'
resultsFile: '$(Build.SourcesDirectory)/Test-Pester.XML'
CodeCoverageOutputFile: '$(Build.SourcesDirectory)/CC-Pester.XML'
usePSCore: ${{ parameters.pscore }}
CodeCoverageFolder: '$(Build.SourcesDirectory)'
PesterVersion: OtherVersion
preferredPesterVersion: 10.0.0

However, when executing the pipeline, the tests don't seem to run but the step is executed?
Steps to reproduce the problem

Hi
Do you have logs of the test run you can share? One thing I noticed in your config is that you've set the pester version to 10.0.0 but the latest is only 5.0.something. It's also worth noting that the v9 of the task itself only supports Pester 4.x.x so that should error out and I'll need to look into why it's not.

Hi,
I modified the pipeline to this:

task: Pester.PesterRunner.Pester-Task.Pester@9
displayName: 'Pester Test Runner'
inputs:
scriptFolder: '$(System.DefaultWorkingDirectory)/*'
resultsFile: '$(Build.SourcesDirectory)/Test-Pester.XML'
CodeCoverageOutputFile: '$(Build.SourcesDirectory)/CC-Pester.XML'
usePSCore: ${{ parameters.pscore }}
CodeCoverageFolder: '$(Build.SourcesDirectory)'
PesterVersion: 'LatestVersion|OtherVersion'
preferredPesterVersion: '4.10.1'

=================
The error in the pipeline is this:
StorageAccount.ps1                   8 Set-AzContext -SubscriptionId "a4d7052e…
StorageAccount.ps1                  10 New-AzResourceGroup -Name "AzPolicy_Sto…
StorageAccount.ps1                  15 Describe "Storage Account Secure Transf…
StorageAccount.ps1                  18 It "Insecure Transfer Should Not Be All…
StorageAccount.ps1                  26 $sa = New-AzStorageAccount -ResourceGro…
StorageAccount.ps1                  34 $exc = $_.Exception.Message
StorageAccount.ps1                  35 $errorThrown = $true
StorageAccount.ps1                  37 if ($exc.Contains("disallowed by policy…
StorageAccount.ps1                  39 $errorThrown = $true
StorageAccount.ps1                  40 Write-Host $exc
StorageAccount.ps1                  41 $errorThrown
StorageAccount.ps1                  41 Should -Be $true
StorageAccount.ps1                  45 $errorThrown = $false
StorageAccount.ps1                  46 $errorThrown
StorageAccount.ps1                  46 Should -Be $true
StorageAccount.ps1                  51 AfterEach {…
StorageAccount.ps1                  53 Remove-AzStorageAccount -ResourceGroupN…
vnet.ps1                             5 BeforeAll {…
vnet.ps1                             8 Set-AzContext -SubscriptionId "a4d7052e…
vnet.ps1                            10 New-AzResourceGroup -Name "StorageAccou…
vnet.ps1                            15 Describe "Storage Account Secure Transf…
vnet.ps1                            18 It "Insecure Transfer Not Allowed" {…
vnet.ps1                            24 $besubnet = New-AzVirtualNetworkSubnetC…
vnet.ps1                            26 $vnet = New-AzVirtualNetwork -ResourceG…
vnet.ps1                            30 $rule1 = New-AzNetworkSecurityRuleConfi…
vnet.ps1                            40 $errorThrown = $true
vnet.ps1                            41 Write-Host $errorThrown
vnet.ps1                            44 $errorThrown
vnet.ps1                            44 Should -Be $true
vnet.ps1                            51 AfterEach {…
vnet.ps1                            52 $afterEachVariable = 'AfterEach has bee…
Pester Script finished
Finishing: Pester Test Runner

I can't see any error there. Could you attach the log file after removing anything sensitive from it? Maybe run the pipeline with the diagnostics enabled as well to get some extra details.

Hmm I can't see where to enable diagnostics. I will look. But is the pipeline config correct?

The pipeline config looks correct. To enable the diagnostics there should be a tick box when you manually queue a build. You can also set it when manually queuing by setting some variables called system.debug to true and system diagnostic to true.


Unclear how to edit markdown cell

Testing #93742

I have created a new markdown cell, but now it is not possible to edit the cell contents anymore. I have tried:
double clicking
pressing enter
right clicking
looking for actions around the cell

@roblourens did we remove the edit button for markdown?

Yeah, lost that due to not considering the cellEditable default from the document.


ResourceExhaustedError: OOM when allocating tensor

Repeated calls to analyze function keeps occupying memory. Even after the analysis is complete.
To reproduce try running on the following config :
OS : Ubuntu 16
Python : 3.6,3.8
No GPU Available

Do not use analyze and verify functions in a for loop. You can pass a list to these functions.
test_set = []
for i in range(0, 100):
   test_set.append("img_%s.jpg" % (i))

DeepFace.analyze(test_set)

That's cool, but what if I want to use analyze function as a service ?

still you can pass a list to analyze function.


Suggestion/Idea: Last recall region flag on Fairy mushroom

Hello, first of all thank you for the plugin, very handy! So handy that it would be extra handy if the little region flag that appears on the crystal also appeared on the Fairy mushroom for the purposes of using the "Last-destination" right click option.
tldr: add option to show the region flag on the Fairy mushroom so its more obvious where it would take you.

Hi, thanks for the nice words.
Sorry, but for this particular plugin, features related to other relics and/or items are out of scope.


Ingressroute needs support for ingress.kubernetes.io/force-ssl-redirect: true

Ingressroute needs support for the equiv. of Ingresses ingress.kubernetes.io/force-ssl-redirect: true
This should be a property on the spec.virtualhost.tls object, it cannot be specified on a delegate.
spec:
  virtualhost:
     fqdn: "example.com"
     tls:
       force-ssl-redirect: true

force-ssl-redirect defaults to false.
Needs internal/dag and internal/e2e tests to verify that force-ssl-redirect: true generates 301 entries for all http routes.

@davecheney TLS & force-ssl-redirect are not required for the beta.1 milestone.  I'm happy to move them to the full 0.6 milestone if that works for your workflow.

ok to bump to after 0.6
On 26 June 2018 at 00:58, Ross Kukulinski<EMAIL_ADDRESS>wrote:

@davecheney https://github.com/davecheney TLS & force-ssl-redirect are
not required for the beta.1 milestone. I'm happy to move them to the full
0.6 milestone if that works for your workflow.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/heptio/contour/issues/456#issuecomment-399982137, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAcAwcFANxwSlIwgKumFecE3mkh0jSZks5uAPp4gaJpZM4U1iYb
.

Blocked on #596

#596 landed, so this is no longer blocked.

After some internal discussion, this feature as it's written in the Issue will be implemented differently.
Since defining a TLS section of a root IngressRoute tells Contour that it should set up a TLS listener and serve the provided TLS certificate/key, it's inherent that all requests be served over TLS. This results in any request to an insecure endpoint will receive a 301 http status code informing the client to redirect to the secure endpoint. No additional parameters need to be set for this functionality other than specifying TLS on the IngressRoute.
Additionally, it may be necessary to serve specific routes over an insecure endpoint. An example would be the challenges sent from LetsEncyrpt. Specific routes can set the permitInsecure parameter which will let that route serve insecure or secure traffic (Meaning no 301 redirects).

@stevesloka as you're working on this, could you see if cert-manager HTTP-01 validation works with a regular Ingress object in tandem with IngressRoute?


Setup frontend project using Vite

Create a folder called frontend
Create a new Vite project with the ReactJs + TypeScript + SWC preset

@sosualfred i will pick up this issue


Bump versions for v0.29.0-SNAPSHOT

Codecov Report
Patch and project coverage have no change.

Comparison is base (b721e7a) 78.09% compared to head (5e86fc2) 78.09%.

:exclamation: Current head 5e86fc2 differs from pull request most recent head 7336a82. Consider uploading reports for the commit 7336a82 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1530   +/-   ##
=======================================
  Coverage   78.09%   78.09%
=======================================
  Files          32       32
  Lines        2584     2584
  Branches      537      537
=======================================
  Hits         2018     2018
  Misses        401      401
  Partials      165      165

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Test


[doc] update doc of get-load-state

Proposed changes
Add return values details;
Add curl example;
Remove misplaced doc;
Remove CANCEL LABEL (covered by Cancel Load Action)
Problem Summary:
Describe the overview of changes.
Checklist(Required)

Does it affect the original behavior: (No)
Has unit tests been added: (No Need)
Has document been added or modified: (Yes)
Does it need to update dependencies: (No)
Are there any changes that cannot be rolled back: (No)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

@hf200012 please take a look ~ Is the document address still modified here? Will it conflict with your previous document refactoring?

This PR has not been updated for a long time.
There could be many reasons.
If it's caused by there are no maintainers to push or ignore this PR, I'm sorry.
If you contact maintainer or want to continue this PR, feel free to @me or @other maintainers.


Document how to produce meshes with the python server

should we move this to the wiki https://github.com/seung-lab/neuroglancer/blob/master/python/README.md#mesh-generation ?

Closing as we are now using igneous for meshing tasks.


feat(azure): Adds permission desc for UAMI BPs

Concerns: CU-96xdyn

Task linked: CU-96xdyn Azure Blueprint Replication needs additional role

Could this be added to https://docs.dev.meshcloud.io/docs/meshstack.azure.index.html#azure-rbac-permissions or is this to specific to be added in the general setup of the replicator SPN?

No this is not possible. This is only the permissions for our replicator principal. However, in order for this to work the replicator principal needs a special role on the target resource the Managed Identity lives in (e.g. the Subscription of the Managed Identitiy). This target resource is not known at the time we execute the terraform script. You probably have to assign this role manually whenever you create a new user managed identity.

No this is not possible. This is only the permissions for our replicator principal. However, in order for this to work the replicator principal needs a special role on the target resource the Managed Identity lives in (e.g. the Subscription of the Managed Identitiy). This target resource is not known at the time we execute the terraform script. You probably have to assign this role manually whenever you create a new user managed identity.

Thank you for pointing this out.


#393 Cleaning up some methods in color.rs and getting rid of more unwraps

Slowly clanking out a lot of the unwraps used in the codebase. Decided to ignore all unwraps used in tests since that's fine.
a lot of these were .lock().unwrap() which i just changed to an .expect("Poisoned") since that's the only possible error. Just think it's a little clearer what is going on. But of course always open to feeback

it didn't pass some tests so imma take this back and cook on it some more


Different calendars for different events places

I read the useful and well written tutorial by Fernando Perales, which is linked in the readme.md file.
Since I would like to use fullcalendar-rails for my application, and I am new with json, I would like to ask some questions.
My Event model has a place attribute, which is the place where the event is held.
My goal is to have different calendars for different places, because each place has its own events.
Would it work if, after defining a search method in the Event model, I defined the instance variable @events used by the index.json.builder file as @events = Event.search(params[:search]) ?
Is the index page of the RESTful Events resource the right place to define @events?
What events will I see if I go to: localhost:3000/events.json or to: localhost:3000/events?
Since the show action of the RESTful Events resource corresponds to the url /events/1 for the event with id=1, I wonder if I will be routed correctly using for each event in the index.json.builder file the html format which generates a url such as /events/1.html. In fact, as common rails practice, I would insert the partial for the generic event in app/views/events/show.html.erb
Lastly: my users choose the day of the event with jQuery date picker, so the attribute event_date will be saved as a string with format "yy-mm-dd": how can I set json start and end? Are they necessary?

I think this would be much better at https://stackoverflow.com/, write your question there and link it in a comment. I can try to respond there.

Thanks @davidwessman . I wrote my question at stackoverflow.

@knzudgt I wrote together an answer now, please close this issue and continue the discussion there :)


bug: Searching functionality is not working properly

Searching functionality is not actually working. I have typed lots but not responding.

yeah I think an api key has expired
cc @devsargam

can anyone please work on this issue fast @hkirat @devsargam

Should be fixed when https://github.com/code100x/daily-code/issues/576 has a pr

I would like to work on this can you assign me @devsargam


Precedence documentation seems missing

I think the documentation about precedence of the various regexp operators is missing. For instance, does Star r1, r2 parse as Star (r1, r2) or (Star r1), r2?

The concrete syntax is the one of OCaml patterns, following their precedence.  So Star r1, r2 is (Star r1), r2.

Probably worth documenting anyway. I've had this same question. At the very least, that one two sentence reply (i.e. "The concrete syntax is the one of OCaml patterns...) would have saved me a few minutes.


EC 11.3.0 version-manifest.txt doesn't show 11.3.0

Instead its first line is private-chef 11.2.6+20150209142733.git.6.46e29fc.
This makes it hard to know what's installed when troubleshooting a customer problem.

This is on me, as I must have missed a step in the release process.

Cool, just making sure that's all it was. Thanks @mmzyk close this if you want.

@jeremiahsnapp I'm trying to figure out if this was a mistake on my part or if something didn't work properly.
For future reference however, that line still tells you a lot.
private-chef 11.2.6+20150209142733.git.6.46e29fc
That is basically saying: this build is 6 comiits past 11.2.6 with a revision of 46e29fc
You can use that revision number to figure out the commit on github. In this case it resolves to one of the commits that was included in 11.3.0. The manifest should still say 11.3.0 however, so something went wrong.

Thanks, I knew about the revision part but I didn't know about the "6 commits past 11.2.6" part.
It could be because of something I'm not understanding regarding the git history but neither of those bit of information seem to point me to the actual tag for 11.3.0.
https://github.com/chef/opscode-omnibus/commits/11.3.0
But at least they are better indicators that it's not really 11.2.6 so it's handy for that.

@jeremiahsnapp Yeah, @stevendanna and I have been investigating to figure out what happened here, because I appear to have followed the correct process. There's something odd going on as that referenced sha in the manifest only shows up on github (perhaps one of their special things to keep track of PRs, etc). All the changes do show up locally, but under different shas.

Some additional info.  While 46e29fc exists on GitHub, we can't seem to find it on a local cloned repository:
> git show 46e29fc453d570aaa64b47cf41c63d9313d35a9f
fatal: bad object 46e29fc453d570aaa64b47cf41c63d9313d35a9f

All right, I'm going to close this out. I've looked at the code and it the way the manifest is generated seems okay and I can't find a bug there, although it should have created the manifest using the 11.3.0 tag. I've tried to determine where that orphaned commit came from on github and can't find it. I even brought back the branch that contained the changes from the dead and still couldn't find it.  I also did an adhoc build on the CI server and it created the manifest correctly.
The only other thing I can think of is that something special is going on with the release job, but that should not be the case. Guess we'll find out the next time a release is cut, but I think this was a solar flare caused blip.


Add filter spaceless

The spaceless filter was added in Twig 1.38
https://twig.symfony.com/doc/2.x/filters/spaceless.html

Thanks @RobLoach for your time and your work on twig.js 🙏

Thank you for adding the spaceless filter!! :heart:  :pray:


Questions about evaluating configuration

Hi, how are you?
I'd like to know how None, shown in Table 3 of the paper, is implemented in code (with RL and Heuristic and None below the skills in the table). Did you comment out the content below the corresponding skill or modify the type parameter or implement it in some other way?
I have provided the details of Table 3 and the code for the GAZE section below for your convenience.

Hello,
You can skip skills like this: https://github.com/facebookresearch/home-robot/blob/ede6a67a2d0c0c8e12ad3b9726f330cea6cf90f5/projects/habitat_ovmm/configs/agent/heuristic_agent.yaml#L163
We specify a set of skills to skip in the config.

Hello,
You can skip skills like this:
https://github.com/facebookresearch/home-robot/blob/ede6a67a2d0c0c8e12ad3b9726f330cea6cf90f5/projects/habitat_ovmm/configs/agent/heuristic_agent.yaml#L163
We specify a set of skills to skip in the config.

OK thank you for your reply


Create at least one debugger test that has a @mandatory tag added to the test name

The @mandatory test tag is added to ensure that a PR can safely be merged knowing that mandatory features/tests pass.
It would be good to have at least one debugger test that has a @mandatory tag added to a test.
Currently PRs are blocked on ensuring all jobs containing the text @mandatory will always pass
With the way things stand, its possible for all debugger tests to pass an a PR get merged.

Did this


Obtain true uptime through clock_gettime()

Obtain true uptime through clock_gettime() instead of subtracting 'bootime' from 'now'.
Talking about in https://github.com/nodejs/node/issues/2573, and freebsd has updated
https://github.com/freebsd/freebsd/commit/74d3ddeb3259da19ebc6183d77ed2e47ac50eae1

Thanks! Can you please resubmit the PR targetting v1.x branch and adjust the commit log to the guidelines in CONTRIBUTING.md?

resubmit #497 @saghul

Continues in #497


redirects from strangled source can break in 0.3.1

I was investigating using this library to help with migrating an old iron webserver to axum.
The iron app creates redirects with the full path, and uses the Host header from the request to create the redirect URL. I saw this approach in many other apps, so it's not unique.
Since 1645a36b2a488c657317d79f9eefdf8ffee2645c the Host-header is overwritten using the strangled authority host: https://github.com/MidasLamb/axum-strangler/blob/1645a36b2a488c657317d79f9eefdf8ffee2645c/src/lib.rs#L150-L154
which breaks this, since the redirect is generated using the strangled hostname, not the original hostname.
Was this an intentional change?

This was indeed an intentional change, reason being that sometimes there could be other proxies in between that use the hostname to forward the request to the strangled service. The one where I experienced this was that the strangled service was in a k8s cluster with traefik as ingress. Without this rewriting, the strangled service couldn't be reached.
However, the fact that it was intentional does not mean that your usecase shouldn't be supported. I see some possible avenues:

Make the request host rewriting configurable
Overwrite the host in a redirect response, if it matches the strangled host

It's probably best to make the request host rewriting configurable regardless of this specific issue, however what are your thoughts on the redirect response host rewriting?

Should be fixed by #13

#13 looks like it will solve this :)
Thank you!