Fix local and ssh backends

Base64-encoded string was not decoded.

Codecov Report
Base: 44.74% // Head: 44.74% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (ad288ff) compared to base (ee9269d).
Patch coverage: 72.19% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1395      +/-   ##
==========================================
- Coverage   44.74%   44.74%   -0.01%
==========================================
  Files         138      139       +1
  Lines        9895     9910      +15
==========================================
+ Hits         4428     4434       +6
- Misses       5191     5197       +6
- Partials      276      279       +3

Impacted Files
Coverage Δ

server/forge/bitbucket/parse.go
100.00% <ø> (ø)

server/forge/bitbucketserver/bitbucketserver.go
0.00% <0.00%> (ø)

server/forge/bitbucketserver/parse.go
0.00% <ø> (ø)

server/forge/coding/util.go
100.00% <ø> (ø)

server/forge/common/status.go
34.09% <ø> (ø)

server/forge/common/utils.go
64.51% <ø> (ø)

server/forge/gitea/parse.go
41.50% <ø> (ø)

server/forge/gitlab/helper.go
66.66% <ø> (ø)

server/forge/gitlab/status.go
0.00% <ø> (ø)

server/forge/gogs/parse.go
0.00% <ø> (ø)

... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Well good hotfix ... missed that, but we should return an unencoded func ... I send a followup

->  #1397


.travis.yml - rename PHP 7.1 env

👍

:+1:
(but why not leave nightly in with allow fail, then when 7.1 stable is released we will be testing 7.2 beta's and RC's out of the box...)

Little point. I'd recommend just adding in 7.2 in later on when we actually start to care.

exactly
I add it as nightly instead of 7.1 as it was the only option to use 7.1 on travis back there


feat: Adding support for Dangling attachment error to V2 driver

What type of PR is this?
This PR adds support for Dangling attachment error for the V2 driver. It also removes the dependency of the the azdiskdriver from the e2e test suite.

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 42.925%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
182

Relevant Lines:
424

💛  - Coveralls

From what it seems, we have two dangling attach error handling scenarios:

when AzVolumeAttachment CRI for the dangling attach exists
when AzVolumeAttachment CRI for the dangling attach does not exist.

And it is the second scenario that our driver currently does not have support for (correct me if I am wrong). Then, instead of giving the controller the full access to handling both scenarios, can we have the controller explicitly handle the second scenario only and have the controllerserver handle the first one?
I am not sure if giving the AttachDetach controller access to crdProvisioner.UnpublishVolume is the right thing to do here given that we only need this function to handle the first scenario. I think we should try to restrain from controllers making too many self-determined decisions and rolling changes on its own.

Then, instead of giving the controller the full access to handling both scenarios, can we have the controller explicitly handle the second scenario only and have the controllerserver handle the first one?

Yeah, @landreasyan and I discussed a number of different options. What I like about the current approach is:

the dangling attach error is handling in one place which makes it easier to maintain and less likely to be broken
we avoid going back-and-forth through the CRIs which make this more efficient at handling the error

I hear your concerns about the controllers making independent decisions (particularly since the attach_detach controller's design is to respond to request and not initiate one on its own). However, I believe we can tolerate a variation for this particular (rare) scenario.

Other than some minor comments, LGTM too 👍


[BUG] OpenApi30.get_hypothesis conversions doesn't handle requestBody

Describe the bug
In Open API 3 body is not in parameters and is not handled during the serialization phase.

Resolved via #862
The payload is handled differently now.


Training materials guide

A guide to creating the training materials so they all follow a common framework

Hi guys, this is great!
I've added a couple of comments / suggestions, and I'll post on slack a more general idea. If properly organised, material following this wonderful guideline could serve in a modular way for more structured training material to be assembled in different ways. pretty much as nf-core modules do for pipelines :)

@lescai Could you submit your review so I can see the comments please?

Looks great to me! I just think the questions and objectives sections have quite some overlap so maybe just one of them would be sufficient, other than that looks great to me

I would like the keep the framing questions and the intended learning outcomes separate. While they can be sometimes quite similar, the framing questions can also sometimes be more broad, while the learning outcome describes what should be learnt.


Using tabs in combination with routerLink

Hi there,
First of all thanks for this awsome framework, it allowed me to build a nice looking app in basicly no time.
I am trying to use tabs in combination with routerlinks in angular2. Currently I am able to switch tabs by clicking on the tab and dynamicly changing the content of the router output. The problem however is that, when i change the router output using a routerlinklink different from the one triggered by clicking the tab, the bar underneath the tab does not update.
I tried solving this problem using an eventEmitter, this one however requires me te specify the div which the tab triggers. Instead of seperate divs I only change the router its output. The question then is, how do i make sure the bar underneath the tabs indicating the active tab changes to the proper tab.
The html (the checkRoute function makes sure the tab gets the class active)

Orders

Plumbers

Customers

The typescript in which I am not able to specify the div causing me not to be able to activate a tab.
  tabsActions = new EventEmitter<string|MaterializeAction>();
  openTab() {
    this.tabsActions.emit({action:"tabs", params:['select_tab', '???????']});
  }

Thanks in advance,
Sander

Hi @smboelders, any updates this issue?

What if you work with routeParameters
https://myurl.com?tab=tab1
The routeParameter is the ID of your tab div, this ID is the value you'll use in the Action
this.tabsActions.emit({action:"tabs", params:['select_tab', 'tab1']});

What if you work with routeParameters
https://myurl.com?tab=tab1
The routeParameter is the ID of your tab div, this ID is the value you'll use in the Action
this.tabsActions.emit({action:"tabs", params:['select_tab', 'tab1']});

Still seeing this issue in 2018.


Documentation: Update changelog: Version 2.3.4

@aserafin Two month ping.  Any objections?

Closing due to lack of attention.


mech filtering handles nitrogen overflow

About the PR
when above 100kPa it will filter out nitrogen as well as bad stuff, to counteract the oxygen ratio skewing from breathing only oxygen
also doubled filtering speed so it can keep up with breathing
it could be sidestepped if air was changed to be a thing where you take in oxygen and nitrogen and output co2 and nitrogen separately, then recycle nitrogen to maintain pressure, but too much work
fixes #19863
Why / Balance
bug permanently making vim death trap
Technical details
when above Overflow pressure, switches from filtering Gases to OverflowGases, which for base mech includes nitrogen.
Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes
no
Changelog
no cl no fun

bad approach


New Resource SPWorkflowService

Added a new resource to register a SharePoint farm against a Workflow Service instance

This change is

Codecov Report

Merging #694 into dev will decrease coverage by <1%.
The diff coverage is 2%.

@@          Coverage Diff          @@
##             dev    #694   +/-   ##
=====================================
- Coverage     90%     90%   -1%
=====================================
  Files        104     105    +1
  Lines      10038   10072   +34
  Branches       1       1
=====================================
+ Hits        9127    9128    +1
- Misses       910     943   +33
  Partials       1       1

Looks great, some small comments

Reviewed 1 of 7 files at r1, 1 of 5 files at r2.
Review status: 2 of 6 files reviewed at latest revision, 5 unresolved discussions.

CHANGELOG.md, line 60 at r2 (raw file):

* Fixed SPSecureStoreServiceApp to return the AuditEnabled parameter
* Fixed several PSScriptAnalyzer warnings
* Added a new SPWorkflowService Resource

Can you please add the new resources to the list of new resources at the top of this section?

Modules/SharePointDsc/DSCResources/MSFT_SPWorkflowService/MSFT_SPWorkflowService.psm1, line 91 at r2 (raw file):

        Write-Verbose -Message "Processing changes"

        Register-SPWorkflowService -WorkflowHostUri $params.WorkflowHostUri -SPSite $params.SPSiteUrl -AllowOAuthHttp:$params.AllowOAuthHttp -Force

Please split this line to multiple lines

Modules/SharePointDsc/Examples/Resources/SPWorkflowService/1-RegisterWorkflowService.ps1, line 21 at r2 (raw file):

                SPSiteUrl                               = "http://sites.sharepoint.com"
                AllowOAuthHttp                          = $true
                PsDscRunAsCredential                    = $SetupAccount

Please remove some spaces on this and the previous lines. Align all on the longest parameter name.

Tests/Unit/SharePointDsc/SharePointDsc.SPWorkflowService.Tests.ps1, line 86 at r2 (raw file):

            It "properly creates the workflow service proxy" {
                Set-TargetResource @testParams

Please make sure something is actually tested, for example by testing if the mocked cmdlets is called by adding:
Assert-MockCalled Register-SPWorkflowService

Tests/Unit/SharePointDsc/SharePointDsc.SPWorkflowService.Tests.ps1, line 90 at r2 (raw file):

            It "returns the workflow service instance" {
                Get-TargetResource @testParams

Please make sure you actually check for a return value. Either by using "Should Not BeNullOrEmpty" or by using (Get-TargetResource @testParams).WorkflowHostUri | Should Be $testParams.WorkflowHostUri

Comments from Reviewable

Reviewed 1 of 7 files at r1, 4 of 5 files at r2.
Review status: all files reviewed at latest revision, 5 unresolved discussions.

Comments from Reviewable

 Waiting for tests to complete before merging.

Reviewed 1 of 5 files at r2, 4 of 4 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


AzureUSGovernment Subscription

Stepping through deploying the solution on US Gov and after I set az cli to AuzreUSGovernment and run the azbb command to Deploy the simulated on-premises datacenter, I get a:
Switched active cloud to 'AzureCloud'
For some reason, the template is reverting back to AzureCloud and not allowing me to deploy in Azure Gov.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 87139748-938e-638e-de1f-94f8becfe1da
Version Independent ID: b96371e6-defb-3e70-792a-2c0cfdc25b7d
Content: Implement a hub-spoke network topology - Azure Reference Architectures
Content Source: docs/reference-architectures/hybrid-networking/shared-services.md
Service: architecture-center
Sub-service: reference-architecture
GitHub Login: @telmosampaio
Microsoft Alias: pnp

Hi @colinweiner Thank you for your feedback! We will review and update as appropriate.

https://docs.microsoft.com/en-us/azure/active-directory/authentication/howto-mfa-nps-extension
Its the first diagram

@colinweiner AZBB is for Azure Building Blocks. Azure Buildling Blocks defaults to Public Cloud, but you can specify the --Cloud parameter to use "AzureUSGovernment", so just specify the --cloud parameter.

@colinweiner We will now proceed to close this thread for now. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Voyager spacecraft_clock_count is always null

But spacecraft_clock_count1/2 is populated.

Mark says he wrote a Python routine that converts from the string-representation of Voyager FDS to a floating point number. This should be put into OPUS. The original FDS strings should be stored and displayed to the user. The FP versions should be used for searching, just like for observation time.


v2.0.0 broke collapse section

Describe the bug
After updating to latest 2.0.0 release a collapse/expand section is added to every card (which is of course non-functional because there are no elements to be shown), even if it's not needed because there are not more elements than the number set in "collapse" config.
How to reproduce

Update to 2.0.0
Add a card with X elements, set "collapse" to "X minus 1" max. (lower than available elements)

Expected behavior
Collapse section is only shown if more elements than set in collapse config exist.
YAML configuration
type: custom:battery-state-card
entities:
  - entity: group.batterystate_switches
title: 🔲 Schalter
secondary_info: last_updated
tap_action: more-info
sort_by_level: asc
collapse: 7
filter: 0
color_thresholds:
  - value: 20
    color: red
  - value: 45
    color: yellow
  - value: 100
    color: green
bulk_rename:
  - from: ' Battery Level'
    to: ''
  - from: ' Akkufüllstand'
    to: ''

Screenshots

Version
2.0.0

Thanks for reporting. I can repro the issue and will fixx it ASAP


Fix class metadata copy bug

Resolves MovingBlocks/Terasology#1986

Thanks!

Think we can merge Cities develop -> Master so this can be fixed in the Omega zip? looks to be working with just that develop branch, without getting into the newer and maybe less stable L&S stuff :-)


Double attachments and lfs-files in backup

Gitea Version
1.16.3
Git Version
git version 2.28.0.windows.1
Operating System
Windows Server 2019
How are you running Gitea?
We are running a build from the gitea page as a windows service.
Database
PostgreSQL
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Description
After updating from version 1.15.11 to 1.16.3 we encountered a strange behaviour concerning the backups using the gitea dump command. The backups have incresed in size of several GBs without any changes to the repos, lfs etc. Further investigation yields that all attachments and lfs files are backuped twice (see screenshot for example).
Screenshots

Example from a file in lfs in a backup.

Presumably these files are at different paths - would you be able to tell us what paths they are at?
It would be helpful to see your app.ini, in particular any storage settings you have.
Could you test adding --skip-attachment-data to your dump command to see if that stops the doubled lfs dumping.

For all the storages, Gitea didn't implement deduplicate for files. It should be done by the file system. i.e. minio could deduplicate files in the architecture.

No, both files are in the same location in the zip file  (see the screenshot below).

I have no special settings in the app.ini concerning storage options.
Using --skip-attachment-data helps, all files in the attachment folder in the backup are now single. But files in the lfs folder are still doubled.

OK it looks likes the recursive exclusion of storage directories isn't working.
It would be useful to see your app.ini and to see the results of dump --verbose.

I suspect the problem is that the paths here:
		excludes = append(excludes, setting.RepoRootPath)
		excludes = append(excludes, setting.LFS.Path)
		excludes = append(excludes, setting.Attachment.Path)
		excludes = append(excludes, setting.LogRootPath)

are not absolute and they need to be.

Gist app.ini
Gist gitea dump --verbose (I have removed the logs concerning the git repos themself due to data proctection)


Add: Project Spotify Clone to the repository.

Related Issue

Description

Screenshots

@vishnu-mouli-102408 I would say that please check the docs one more time & create a new PR we added new features. so there are some conflict errors. https://github.com/priyankarpal/ProjectsHut/blob/main/contributing.md

Okay

Okay

so You can close this PR. After that create an issue for project addition. create the PR after when we will assign you


Encryption

I was looking over this and I don't see this so I thought I would confirm.  Is there any support or provision for zero knowledge encryption?
If not is that on a roadmap for consideration?
One of my children was thinking about journaling but was concerned about privacy.  I remembered this project, but was thinking even if you self host you could still be vulnerable to data leaks through bugs, hacks, etc.

Hey @magicCashew! I did look into it a little bit and really hoped it would be easy or built in somewhere, but didn't have a lot of knowledge of how to implement it myself. I thought it could get tricky and didn't actually try my hand at any sort of implementation figuring I'd mostly just be using it on my own and others would self host (which tends to be the cost in most instances).
That being said, I suppose it is possible with sensitive data being stored elsewhere you run that risk. Maybe JournalBook by trys would be a good alternative to look into? It inspired my project a lot but can't be cross platform because it stores things locally. That might be a good compromise in your case though.

Here's a link https://github.com/trys/JournalBook

Okay, cool.  I'll check it out.  Thanks!  I'd love to consider submitting an enhancement, but I am pretty slammed right now.  Maybe if things let up in the near future for me, I could circle back and see if if there's interest.


The previous PR was reverted because the characters package wasn't available in google3. This is being remedied in a CL that must be merged before this.
Related Issues
Relands https://github.com/flutter/flutter/pull/53381
Waiting on a google3 CL to add google3 support for the characters package. Merged.
Tests
See https://github.com/flutter/flutter/pull/53381
Breaking Change
None, but see https://github.com/flutter/flutter/issues/59645 where users reported needing to run flutter pub get or flutter clean after upgrading an older project.

This or https://github.com/flutter/flutter/pull/59620 appears to have broken google3 despite my CL to add characters to google3.  I must be missing some step.


Upgrade pulumi-terraform-bridge to v3.49.1

This PR was generated via $ upgrade-provider pulumi/pulumi-hcloud --kind=bridge.

Fixes https://github.com/pulumi/pulumi-hcloud/issues/175

Upgrading pulumi-terraform-bridge from v3.47.2 to v3.49.1.

https://github.com/pulumi/pulumi-hcloud/issues/224


instanceof type guard missing deduction

TypeScript Version:  2.7.0-dev.201xxxxx
Code
class C { }

function f<T extends C>(v: T | string): void {
  if (v instanceof C) {
    const x: T = v;
    console.log(x);
  }
}

Expected behavior:
No compile errors:
Actual behavior:
p.ts(5,11): error TS2322: Type 'string | T' is not assignable to type 'T'.
Type 'string' is not assignable to type 'T'.

This was an error in previous releases too because C is an empty object type. However, with #19671 we can (and should) get this right.

From last part of comment above it seems you imply that master branch after #19671 merge get this right, but this is not the case. Am I missing something?
I can confirm that if C is not an empty object type Typescript 2.6.1 compile the source without errors.

@abramobagnara I meant that with the approach we introduced in #19671 we can, but currently don't , get it right even when C is an empty class type (as in your example). You are correct that it used to work when C is not an empty class. Both issues are fixed by #20142 that I just put up.


GUI- In Brightfield, a too bright image is completely black.

This is a bit confusing, as it makes you think that you need to turn the light/exposure/gain up, instead of down.  You really lose the image completely... Not sure if this is something that is happening in the camera or our software?  This doesn't happen in the Pylon Software, it just stays white (I believe, at least it does in streampix.)

looks like this is fixed

Previously, the range of intensity was supposed to adjust min and max values to enhance, but was not functioning correctly. This is no disabled. I recommend an enhance contrast feature that can be toggled. If you want the feature, please create a new support issue.


MINOR: Fixing shadow jar publish

What
The PR fixes the publishing of kafka-clients artifact to remote maven. The kafka-clients jar is recently been shadowed which does publish the artifacts to local maven successfully but errors when publishing to remote maven. The issue triggers only with publishMavenJavaPublicationToMavenRepository and signing but publishToMavenLocal works correctly with earlier changes. Generating signed asc files error out for shadowed release artifacts as the module name (clients) differs from the artifact name (kafka-clients).
The fix is basically to explicitly define artifact of shadowJar to signing and publish plugin. project.shadow.component(mavenJava) previously outputs the name as client-<version>-all.jar though the classifier and archivesBaseName are already defined correctly in :clients and shadowJar construction.
Below is another way where the artifact details can be overridden post construction in afterEvaluate to let publish plugin know about the correct artifactId but it doesn't solve the signing plugin issue where signing plugin is unaware of kafka-client-<version>.jar and skips signing. For signing plugin the artifact should be explicitly defined as well.
            project.shadow.component(mavenJava)

            afterEvaluate {
              pom.withXml {
                asNode().dependencies.dependency.findAll() {
                  def projectName = it.artifactId.text()
                  if (['clients'].contains(projectName)) {
                    it.artifactId*.value = 'kafka-clients'
                  }
                }
              }
            }

Tests:

I created person gpg secrets locally for signing and private maven repo to upload the artifacts. I ran the release pipeline pointing to custom repo and can successfully push the kafka-clients artifacts.

Testing shaded dependencies generated successfully. I can see no difference in the previous and release shaded jars, and can also see shaded dependencies in the jar.

Query:

I compared the 3.6.1 kafka release artifacts here with generated artifacts in my personal repo, and can find module metadata artifact is missing. Debugged the issue and it seems gradle publish - from components.java actually registers both jar and module for publish which is not there in case of shadowJar hence the question is that do we require to publish module metadata information or are we good?

cc: @stanislavkozlovski @xvrl @AndrewJSchofield
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

I tested the publish again and confirmed it works!

Awesome!

Who is a good person to ask about this? Maybe some of the original reviewers of the shadow PR?

May be @ijuma or @xvrl can help here.


Connections

Hey, I want to use your "framework" but I can't establish connection by your application.
C:\Users...\Downloads>phantom-windows server_ip:29449
Starting up with remote server IP: server_ip:29449
1:37PM INF Starting idle connection handler
1:37PM INF Binding ping server to port 19132
1:37PM INF Binding proxy server to: <IP_ADDRESS>:60625
1:37PM INF Proxy server listening!
1:37PM INF Once your console pings phantom, you should see replies below.
And nothing else after couple of minutes.
I tried it on my local and in my mobile network the console looks the same.
On Minecraft Client on WIN10 I do not see any local servers.
Thanks for help.
Regards
Tomasz

UPDATE:
I tried this application on console XBOX ONE and it is work perfectly :)
Thanks a lot, but on windows 10 and on my mobile phone, it is not appear on LAN servers when I was connected on the same wi-fi network.
Regards

Hey @Yberias, thanks for the report. I'll keep it in mind. The issue with Win10 might be, if you're running both phantom and the Win10 client on the same PC, Windows has some network/security peculiarities that makes phantom not show up in the server list. I've had luck running it on another PC or connecting from another device first, then it will show up on Win10.
As for mobile, hmmmm. I'm not sure why that would happen. If you want to share any more details about your local network setup, router, wifi network, version of phantom, and server software, etc., that might provide some info to help me narrow it down.


Convert overviewpy to be more object oriented

As discussed in Issue #14, we're going to look at making overviewpy more object oriented so we have a consistent style of coding once PR #17 is merged.
This PR:

Creates an Overview class which encapsulates the functionality of overviewpy.py
Converts the existing functions to invoke the class method versions
Uncomments and corrects the unit tests for overviewpy_na

Thank you so much! I'll get a chance to look at both PRs on Monday :)


Add Carthage build folder to .gitignore

When using carthage and git-submodules, QorumLogs gets "dirty". This fixes that.

Thanks 👍


Move 100-continue behavior to use high-level request interface

Overview
Starting in urllib3 2.0, the HTTPConnection behavior was reorganized to incorporate request chunking under the same top-level request method. This removed the underlying call to _send_request that's utilized by CPython's HTTPConnection which is the parent class of the urllib3 implementation. This change effectively short circuited botocore's provisional HTTP 100-continue support.
To provide a path forward for supporting urllib3 2.0, we're moving to us urllib3's request interface. Fortunately, this also exists in CPython as a thin wrapper around _send_request. This will reenable most of our internal patches to the class to support 100-continue.
Changes in urllib3's behavior
The only significant pain point this will introduce is urllib3 has moved from using endheaders to send the body in CPython to bundling the send logic in request itself. That circumvents our ability to drop sending the body since it's not dispatched to another method that can be overwritten. In order to work around this, we need to stub out all send calls to be no-op once a non-100 response is observed. We're able to do this relatively easily because urllib3's current behavior matches what was in the standard library prior to Python 2.7.
The only other issue we needed to work around was a ~50% regression in response time for non-100 responses. This is due to the number of times urllib3 invokes send with its forced chunking. We previously only saw one send call but now for large bodies it's potentially thousands of invocations. When logging is enabled, this not only pollutes the logs but takes a non-trivial amount of time. We'll move our logging to only fire once on the first send call and let the others pass silently.
Release plan
This PR will add a new GHA test runner that will always use "urllib3<2" to ensure we're still operational with urllib3 1.26.x. It will also move to the new provisional interface that should be compatible across both urllib3 major versions without moving the urllib3 pin.
This let's us ensure we don't have any unexpected gaps and unblocks distro maintainers from migrating their code/test suites to use urllib3 2.0 if needed. Once we have confidence in the change, we'll look at moving the pin. There isn't a strict timeline on this as there are still OpenSSL issues that may affect some Lambda/Codebuild environments. We'll provide an update to the tracking ticket #2926 once we have more specifics.

Codecov Report
Patch coverage: 70.00% and project coverage change: -0.03% :warning:

Comparison is base (1a5df55) 93.36% compared to head (5fe2614) 93.34%.
Report is 16 commits behind head on develop.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2990      +/-   ##
===========================================
- Coverage    93.36%   93.34%   -0.03%
===========================================
  Files           65       66       +1
  Lines        13841    13947     +106
===========================================
+ Hits         12923    13019      +96
- Misses         918      928      +10

Files Changed
Coverage Δ

botocore/awsrequest.py
97.87% <66.66%> (-0.68%)
:arrow_down:

botocore/__init__.py
100.00% <100.00%> (ø)

... and 16 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


raise Exception if returncode is not zero.

It would be nice for debugging if amalgkit throws an error when external tools do not exit correctly. Here is an example code. Could you insert similar assertions or raise Exception() in relevant places?
    run_iqtree = subprocess.run([g['iqtree_exe'], '-s', g['alignment_file'], '-te', g['rooted_tree_file'],
                                 '-m', g['iqtree_model'], '--seqtype', 'CODON'+str(g['genetic_code']),
                                 '--threads-max', str(g['threads']), '-T', 'AUTO', '--ancestral', '--rate', '--redo'],
                                stdout=sys.stdout, stderr=sys.stderr)
    assert (run_iqtree.returncode==0), "IQ-TREE did not finish safely: {}".format(run_iqtree.stdout.decode('utf8'))

Makes sense, I'll look into it.

forgot to push this update. Rectified now.


Export dummy function if in module

It doesn't matter if the Mixin is exported or not. Always export the
dummy function so that JSC does not complain that the value is never
read.
Folllow up to 7dd70d9b09948c591ae6423fd801a1a3433dfd5e

TBR


feat: Configure telegram bot with BOT=robert

@tillprochaska for testing, the gem will complain if you start your
containers with env BOT=something docker-compose up and run
docker-compose exec app rails spec. It will complain about missing
default paths, see below :point_down:.
Failures:

  1) Requests POST /requests given a user with a telegram_chat_id is expected to send telegram message "How do you do?"
     Failure/Error: it { should respond_with_message 'How do you do?' }
       expected to make exactly 1 #<Telegram::Bot::ClientStub#13600(1245394754:AAFVzLe5HUubaz1IsEQ8RaQAFUQRFEoGqIQ)>.sendMessage requests, with [#<RSpec::Mocks::ArgumentMatchers::HashIncludingMatcher:0x000055fc2f367cd0 @expected={:chat_id=>4711, :text=>"How do you do?"}>], but made 0, and 0 with
     # ./spec/requests/requests_spec.rb:34:in `block (4 levels) in <main>'

  2) Telegram::WebhookController#start! is expected to send telegram message "Hello Joe!"
     Failure/Error: subject { -> { dispatch_command :start, { from: { username: 'Joe' } } } }

     NoMethodError:
       undefined method `default_telegram_webhook_path' for #<Module:0x000055fc2f40f598>
     # /usr/local/bundle/gems/telegram-bot-0.14.3/lib/telegram/bot/rspec/integration/rails.rb:8:in `public_send'
     # /usr/local/bundle/gems/telegram-bot-0.14.3/lib/telegram/bot/rspec/integration/rails.rb:8:in `block (2 levels) in <main>'
     # /usr/local/bundle/gems/telegram-bot-0.14.3/lib/telegram/bot/rspec/integration/rails.rb:19:in `dispatch'
     # /usr/local/bundle/gems/telegram-bot-0.14.3/lib/telegram/bot/rspec/message_helpers.rb:11:in `dispatch_message'
     # /usr/local/bundle/gems/telegram-bot-0.14.3/lib/telegram/bot/rspec/message_helpers.rb:18:in `dispatch_command'
     # ./spec/requests/telegram/webhook_spec.rb:8:in `block (4 levels) in <main>'
     # /usr/local/bundle/gems/telegram-bot-0.14.3/lib/telegram/bot/rspec/client_matchers.rb:74:in `matches?'
     # ./spec/requests/telegram/webhook_spec.rb:9:in `block (3 levels) in <main>'

@tillprochaska add your bot token to config/credentials.yml.enc


Add :max-choices parameter to single-dropdown.

Here's a PR for this issue: https://github.com/Day8/re-com/issues/102
It's a bit hard to unit test the single-dropdown component because of the reagent calls in the dropdown-top function.
I notice that the filtering has some surprising behaviour. E.g. filtering on 'Un' brings up 'Afghanistan' (presumably because 'Un' is in the group heading name "'A' Countries".

I've shown a working copy of this to a few co-workers and they all feel a dropdown with hidden extra choices has poor usability, as there is no way to easily discover the extra options.
So, I'm finding it difficult to include this. Is there something I've misunderstood?
Also, re your filtering query, yes it is intentional that group headings are included in the search and showing all items under that group name would appear to be the most sensible thing to do. e.g. if you had a list of cities grouped by country and you typed the country name, you'd get a list of all cities in that country.

Yes, I tend to agree with you on the usability aspect of this. I don't need it myself. My personal motivation was just to get a bit of experience working with reagent, and issue #102 seemed like an easy start. Perhaps you could close that issue now?
Let me know if you find anything from this PR useful to include and I could split that off into a separate PR; otherwise, feel free to decline the PR. Thanks for taking a look.
Regarding the filtering behaviour, I can see a use case for both behaviours. In the demo example, I don't think I'd find myself wanting the query to match on group names because the group names only differ by their leading letter ('A' Countries, 'B' Countries, etc). However, I can imagine that there would be situations where querying for a group name would be useful.

As per previous discussion closing without merging as hidden choices is probably poor usability.
Thanks for the effort all the same @rars

As per previous discussion closing without merging as hidden choices is probably poor usability.
Thanks for the effort all the same @rars


Why sw don't parse and save  the prometheus federate endpoint return  metrics as untyped?

Please answer these questions before submitting your issue.

Why do you submit this issue?
Question or discussion

Question

What do you want to know?
I've taken some metrics by using the prometheus federate, it return metrics like this:

  # TYPE container_cpu_cfs_periods_total untyped
   container_cpu_cfs_periods_total{replica="center"} 1000<PHONE_NUMBER>513

I add yaml file in $CLASSPATH/fetcher-prom-rules, but These metrics are not stored，if I alter  metrcis is below, it ok
  # TYPE container_cpu_cfs_periods_total gauge
   container_cpu_cfs_periods_total{replica="center"} 1000<PHONE_NUMBER>513

Why does the federate endpoint return all metrics as untyped? I find this: https://github.com/prometheus/prometheus/issues/5589
if i want stored this metrics by sw, what should i do?

Prometheus federation loses metadata due to a "complicated" reason. And from https://www.robustperception.io/federation-what-is-it-good-for, the federation is NOT good for exporting all metrics to the third platform, like SW.
I suggest using SW Prometheus fetcher directly or leverage OpenTelemetry collector to collect metrics from Prometheus then export to SW.

Agree, SkyWalking backend is more powerful and supporting cluster mode. We don't need the federation mode.

Yes, but some metric can't pull by fetcher directly, such as container cpu usage, It's included in the cluster。so，I set fetcher metrics URL is prometheus fedarate address(egg: http://prometheus:37772/federate?match[]={pod_name="test"}).

@wuwenrufeng Take a look at OpenTelemetry collector for now.

ok


AVIF support

Any plans to support AVIF? libavif can easily convert JPEGs and PNGs in AVIF images, but it is written in C, and I don't know how well it would integrate with LibrePhotos.

We could use imagecodecs. It uses libavif.
Do you want the option to use avif instead of jpegs for thumbnails or do you just want it to be able to read it?

Having the possibility to read AVIF pictures would certainly be nice, but I think that using AVIF as the default image format instead of Jpeg would be ideal, since it occupies less space, supports things like transparency and doesn't have any licensing issues.
On the other hand AVIF is probably too young, and using it by default could cause compatibility issues.
In my opinion just being able to read AVIF files would be a good start, and maybe you could reconsider the switch later.

Having the possibility to read AVIF pictures would certainly be nice, but I think that using AVIF as the default image format instead of Jpeg would be ideal, since it occupies less space, supports things like transparency and doesn't have any licensing issues.
On the other hand AVIF is probably too young, and using it by default could cause compatibility issues.
In my opinion just being able to read AVIF files would be a good start, and maybe you could reconsider the switch later.

Avif isn't supported by all browser, so we now use webp instead.


#171: Ignore bridge methods

Issue #171
Solves #171: Ignore bridge methods
The metric LCOM2 should ignore bridge methods

@yegor256/z please, pay attention to this pull request

Job #260 is now in scope, role is REV

Codecov Report

Merging #260 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #260      +/-   ##
============================================
+ Coverage     74.52%   74.57%   +0.04%
- Complexity      169      170       +1
============================================
  Files            32       32
  Lines          1052     1054       +2
  Branches         81       82       +1
============================================
+ Hits            784      786       +2
  Misses          235      235
  Partials         33       33

Impacted Files
Coverage Δ
Complexity Δ

src/main/java/org/jpeek/skeleton/XmlClass.java
93.87% <100%> (+0.26%)
13 <0> (+1)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 682c3f8...262e548. Read the comment docs.

@yegor256/z everybody who has role REV is banned at #260; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@rultor merge

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 15min)

@0crat wait #260

@0crat wait #260 (here)

@uurl Job #260 is not in scope, can't put it on hold

Fixes #171

This PR closes #171


RestClient::SSLCertificateNotVerified Error

I've been getting these errors in production. I've fixed the issue on a custom branch of mine by swapping out RestClient for Faraday.
I, [2018-03-01T15:53:16.455400 #19005]  INFO -- : Celluloid 0.17.2 is running in BACKPORTED mode. [ http://git.io/vJf3J ] Loading development environment (Rails 4.2.5) irb(main):001:0> require 'itunes' => false irb(main):002:0> Itunes::Receipt.verify!({}) RestClient::SSLCertificateNotVerified: SSL_connect returned=1 errno=0 state=error: certificate verify failed: 	from /Users/kaom/.rbenv/versions/2.1.10/lib/ruby/gems/2.1.0/gems/rest-client-1.8.0/lib/restclient/request.rb:445:in rescue in transmit'`

I'm getting the same here.

@kaomte It's not security advised but if you're desperate about it you can patch this gem to ignore SSL verifications by adding a file like this in your project:
module Itunes
  class Receipt
    def self.post_to_endpoint(request_data, endpoint = Itunes.endpoint)
      response = RestClient::Request.execute(
        method: :post,
        url: endpoint,
        payload: request_data.to_json,
        verify_ssl: OpenSSL::SSL::VERIFY_NONE
      )
      JSON.parse(response).with_indifferent_access
    end
  end
end

If you use Rails it would be lib/itunes/receipt.rb.
But we should wait for a better either anyway.

Adding more information, it looks like the actual issue is https://github.com/nov/restclient_with_cert/issues/1


Bump version

Questions
Answers

Description?
Bump version to 4.3.0

Type?
improvement

How to test?
No need QA

Thanks @PierreRambaud


Mopar component, nothing showing up in HA

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
0.53.0
Python release (python3 --version):
3.4.2
Component/platform:
Mopar component
Description of problem:
Nothing is showing up in HA, except the service "mopar" is showing up as an option in the Services section of the UI, but nothing happens when I send remote commands (testing using vehicle_index of 0)
I believe that this should set up a sensor for each vehicle?
Absolutely no errors in the logs at all.  It appears to be logging in, as there is a mopar_cookies.pickle file created in /home/homeassistant/.homeassistant.  I've tried deleting that to force a relogin, which seems to work (no errors), but still nothing in HA.
And yes, I have a full (paid) UConnect subscription, 2015 Ram 1500 pickup.
Expected:
Looking at the code, it appears that the way this is supposed to work is to create entities in the "sensor" domain for each vehicle.  I'm not seeing anything new in States.
Problem-relevant configuration.yaml entries and steps to reproduce:
sensor:
  - platform: mopar
    username<EMAIL_ADDRESS>    password: "my-password"
    pin: 1234

Traceback (if applicable):

Additional info:

Hey there, I'll try to help with this. You should indeed be getting a sensor per vehicle.
Can you try a quick test to make sure the underlying module is working? Paste this into a python file, adjust the login info, and run it (in the HA virtual environment). You should get a bunch of output about your vehicle.
import motorparts
session = motorparts.get_session('username', 'password', 5555)
summary = motorparts.get_summary(session)
report = motorparts.get_report(session, 0)
print(summary, report)

Thanks so much, I'm trying to get my head around Python so I can start contributing.  I was excited to see this new component.
I ran your test and I do see a bunch of output about my vehicle, which all looks accurate, so it certainly seems like the motorparts library is working... sanitized results below:
{'user': {'email'<EMAIL_ADDRESS>'name': 'Me'}, 'vehicles': [{'make': 'RAM', 'odometer': '35293', 'vin': '<redcated>', 'model': '2015', 'year': '2015'}]} {'engineOilOverTemp': 'Ok', 'transOverTemp': 'Ok', 'tirePressureRR': '39.0', 'wheelsAndSteering': 'Ok', 'tirePressureRF': '39.0', 'odometer': '57084.400', 'milLampStat': 'Ok', 'tirePressureLF': '38.0', 'vehicleStatus': 'Ok', 'brakeFluid': 'Ok', 'oilPressure': 'Ok', 'airbagIndLamp': 'Ok', 'ETCIndLampStatus': 'Ok', 'ABSIndLampStatus': 'Ok', 'TPMServiceWarningStatus': 'Ok', 'tirePressureLR': '38.0', 'autoOilChange': 'Ok', 'CHRGSystemFail': 'Ok'}

On a side note, I looked at your library and figured out how you pull the JSON vehicle data from Mopar, so I was able to do a manual test in a browser.  In my case, the 'model' is returned from Mopar as "2015 RAM 1500 SLT 4X2".  Your library does a split on spaces then returns the first element, which is my case is "2015".  I think that's why the result of your test program above shows 'model': '2015'.  Not a huge issue as I only own one Mopar vehicle, but just wanted to make a note.

Thanks for checking that. I think you're probably the second person to use this so far.  I took a look at the HA component and it seems like someone else may have made a change that broke it. I will confirm that tonight.
With respect to the name issue, it looks like I need to use a field other than model to get the model name. Mine reports as 1500  SLT  4X2 (coincidentally also a 2015 RAM 1500). As a quick fix, I might strip out the year, then do the split on spaces.

Ah, a fellow Ram owner, nice!  I figured that, since it was such a new component that seems to require a fairly newer UConnect system (with the mobile SIM and all), there wouldn't be many of us "early adopters" but I was very excited to see it pop up in 0.53... thanks again for contributing it!  I really with I knew Python better and could help out... I can "read the tea leaves" and get an idea how your code works, but still figuring out the whole object and class thing.
I just reran the "https://www.mopar.com/moparsvc/user/getProfile" after logging in, and here's the model snippet from the JSON returned:
"model" : "2015 RAM 1500 SLT 4X2"
Looks like Mopar has some inconsistencies when how they enter this when setting up the accounts.  It shouldn't include the year, really, since that's already a separate element.

@happyleavesaoc, I bumbled around in the code, and was going to post a possible solution, but you beat me to it.... added a "data.update()" right after "data = MoparData(session)" and my truck showed up in HA.  I guess I'm starting to finally pick up Python!  :)

I'm now showing a traceback when the mopar component tries to update the vehicle data.  For testing, I reduced the THROTTLE timer to 2 hours in mopar.py.  Deleting the mopar_cookies.pickle and restarting HA fixes it initially, but it appears the traceback occurs when HA tries to update the sensor a few hours later:
Sep 12 09:53:34 hass1 hass[28833]: #033[32m2017-09-12 09:53:34 INFO (Thread-6) [homeassistant.components.sensor.mopar] updating vehicle data#033[0m
Sep 12 09:53:34 hass1 hass[28833]: #033[31m2017-09-12 09:53:34 ERROR (MainThread) [homeassistant.helpers.entity] Update for sensor.2015_ram_2015 fails#033[0m
Sep 12 09:53:34 hass1 hass[28833]: Traceback (most recent call last):
Sep 12 09:53:34 hass1 hass[28833]: File "/srv/homeassistant/homeassistant_venv/lib/python3.4/site-packages/motorparts/__init__.py", line 113, in get_profile
Sep 12 09:53:34 hass1 hass[28833]: raise MoparError("not logged in")
Sep 12 09:53:34 hass1 hass[28833]: motorparts.MoparError: not logged in
Sep 12 09:53:34 hass1 hass[28833]: During handling of the above exception, another exception occurred:
Sep 12 09:53:34 hass1 hass[28833]: Traceback (most recent call last):
Sep 12 09:53:34 hass1 hass[28833]: File "/srv/homeassistant/homeassistant_venv/lib/python3.4/site-packages/homeassistant/helpers/entity.py", line 225, in async_update_
ha_state
Sep 12 09:53:34 hass1 hass[28833]: yield from self.hass.async_add_job(self.update)
Sep 12 09:53:34 hass1 hass[28833]: File "/usr/lib/python3.4/asyncio/futures.py", line 388, in __iter__
Sep 12 09:53:34 hass1 hass[28833]: yield self  # This tells Task to wait for completion.
Sep 12 09:53:34 hass1 hass[28833]: File "/usr/lib/python3.4/asyncio/tasks.py", line 286, in _wakeup
Sep 12 09:53:34 hass1 hass[28833]: value = future.result()
Sep 12 09:53:34 hass1 hass[28833]: File "/usr/lib/python3.4/asyncio/futures.py", line 277, in result
Sep 12 09:53:34 hass1 hass[28833]: raise self._exception
Sep 12 09:53:34 hass1 hass[28833]: File "/usr/lib/python3.4/concurrent/futures/thread.py", line 54, in run
Sep 12 09:53:34 hass1 hass[28833]: result = self.fn(*self.args, **self.kwargs)
Sep 12 09:53:34 hass1 hass[28833]: File "/srv/homeassistant/homeassistant_venv/lib/python3.4/site-packages/homeassistant/components/sensor/mopar.py", line 124, in update
Sep 12 09:53:34 hass1 hass[28833]: self._data.update()
Sep 12 09:53:34 hass1 hass[28833]: File "/srv/homeassistant/homeassistant_venv/lib/python3.4/site-packages/homeassistant/util/__init__.py", line 306, in wrapper
Sep 12 09:53:34 hass1 hass[28833]: result = method(*args, **kwargs)
Sep 12 09:53:34 hass1 hass[28833]: File "/srv/homeassistant/homeassistant_venv/lib/python3.4/site-packages/homeassistant/components/sensor/mopar.py", line 97, in update
Sep 12 09:53:34 hass1 hass[28833]: self.vehicles = motorparts.get_summary(self._session)['vehicles']
Sep 12 09:53:34 hass1 hass[28833]: File "/srv/homeassistant/homeassistant_venv/lib/python3.4/site-packages/motorparts/__init__.py", line 166, in get_summary
Sep 12 09:53:34 hass1 hass[28833]: profile = get_profile(session)
Sep 12 09:53:34 hass1 hass[28833]: File "/srv/homeassistant/homeassistant_venv/lib/python3.4/site-packages/motorparts/__init__.py", line 89, in wrapped
Sep 12 09:53:34 hass1 hass[28833]: return function(*args)
Sep 12 09:53:34 hass1 hass[28833]: File "/srv/homeassistant/homeassistant_venv/lib/python3.4/site-packages/motorparts/__init__.py", line 115, in get_profile
Sep 12 09:53:34 hass1 hass[28833]: except json.decoder.JSONDecodeError:
Sep 12 09:53:34 hass1 hass[28833]: AttributeError: 'module' object has no attribute 'JSONDecodeError'#033[0m

Ah, thanks. This is almost certainly the result of a Python 3.4 vs 3.5 difference. I'm guessing you're running 3.4?

Yes, I am, under Raspbian Jessie on a Rpi3.  I saw that HA is deprecating support so I plan on upgrading to Raspbian Stretch (with Python 3.5) over the next few days.

Ok. I pushed a fix to motorparts 1.0.2 that should fix it. When the existing PR gets merged, all three of these issues should be fixed.

Fix availabale in https://home-assistant.io/blog/2017/09/23/release-54/


Question: is Swing 's pointer coordinate and Compose's coordinate interchangable?

modifier.pointerInput(Unit) { // this - PointerInputScope
    val size = this.size
    while (true) {
        val event = awaitPointerEventScope { awaitPointerEvent() }
        val awtEvent = event.awtEvent
        when (event.type) {
            PointerEventType.Press -> {
                val pressLocation = Pair(awtEvent.x, awtEvent.y)
                // TODO: Some logic to determine the place of event press by calculating % of x, y in terms of pointerInputScore's size.
            }
        }
    }
}

An example of my use case is to calculate the width, height from the starting point to the press location. But it seems to me that (x,y) coordinate of Swing is not the same as Compose's PointerInputScope.
Is it correct?
Any suggestions to achieve what I'm describing above?
This is related to the mouse tutorial

Hello! Compose coordinates are awt coordinates * screen density

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


[BUG] Silent notification making sound.

Notifications that have the silent attribute in options set to true, still make a sound.
Going to site settings and disabling sound for that url (service worker in this case), doesn't work either.

Can you try with latest Kiwi v116 ? , I know it's been a while and not sure if you still use Kiwi. Closing this, but feel free to re-open if you still have the issue


Getting an alert dialog saying download faild

Hey,
I am a newbie at node and javascript. If you could help me out here that would be great.
I am getting the attached dialog when I hit the deeplink url.
I have made a deeplink function in the core server middleware. Whenever the server hits http://localhost:3000/deeplink* the following gets executed. The url query parameter is encoded but still this issue persists.
exports.deeplink = function(req, res, next) {
  var link = deeplink({
      fallback: 'http://' + req.headers.host,
      ios_store_link: 'https://itunes.apple.com/us/app/cups-unlimited-coffee/id556462755?mt=8&uo=4',
  });
  link(req, res, next);
};

Is it only on IOS 9 ? Haven't tested it on this version yet, there might have been some changes in Safari.
Can you try running the code in an earlier version in the simulator ?

Getting the same error on iOS 8.4 as well

deeplink already exposes a middleware, so there's no need to save it to a var before and execute it.
try doing
exports.deeplink = deeplink({
    fallback: 'http://' + req.headers.host,
    ios_store_link: 'https://itunes.apple.com/us/app/cups-unlimited-coffee/id556462755?mt=8&uo=4',
});

see example here
https://github.com/mderazon/node-deeplink/blob/master/example/app.js

No luck with that either. Same error.

Is there any way we can have a callback with the inline html and from the controller response, send the html to client?

Can you show me the complete code of what you're trying to do ?

I don't think the javascript is going to the mobile client. All I can see is standardError.html. in the Safari debugger.
I am using the mean js boilerplate code. After the reset password token validation, a function checks if the reset link was clicked by iPad or iPhone and redirects them to the mobile deeplink which makes a get request to the deeplinked URL in the core server route.
function(err, user) {
    var userAgent = req.headers['user-agent'];
    if (userAgent !== null && (userAgent.indexOf('iPhone') > -1 || userAgent.indexOf('iPad') > -1) {
  		res.redirect('/deeplink?url=myapp%3A%2F%2Freset');
    } else {
      if (!user) {
  			return res.redirect('/#!/password/reset/invalid');
  		}
  		res.redirect('/#!/password/reset/' + req.params.token);
    }

In my core server routes, there is wildcard route for deeplinks.
	// Deeplinking into apps
	app.route('/deeplink*').get(core.deeplink);

In the core server controller -
exports.deeplink = deeplink({
    fallback: 'http://localhost:3000',
    ios_store_link: 'https://itunes.apple.com/us/app/cups-unlimited-coffee/id556462755?mt=8&uo=4',
});
};

If the page doesn't load then my guess is that something is wrong in the routing configuration.
Try logging the request going right before the deeplink middleware
// Deeplinking into apps
app.route('/deeplink*').get(function(req, res, next) {
  console.log('here')
  next()
}, core.deeplink);

I don't think its a routing issue since I an able debug via the node inspector and see that the flow actually goes to the deeplink library and the javascript data to be inlined is constructed. After the inline html piping with response, I don't see any response body being constructed.

Can you post a complete sample code ?

Just uploaded the repo. I am directly hitting the url from from iOS simulator after running the server.
https://github.com/codebreaker01/Deeplink

the problem is the the MEAN server messes with the header type and sets it to text/plain instead of text/html

try updating to v0.2.2 and see how it goes

I updated the version. Now I am getting a different error.

Do you have an app that can open the deep link ? Or can you try and open it in a real device ?
I think that you can't open itunes on the simulator

Deeplinking and fallback to itunes both  are working on a real device but deeplinking is not on simulator(though I have the app installed). Any reason why deeplinking isn't happening on simulator?
Btw, thanks for the prompt responses and getting this resolved. :+1:

Hmm, weird. Not sure why it doesn't work in the simulator. The fallback to itunes probably can't work there but not sure why it's not opening the app


Integration tests don't work on raspberry pi

Seems to fail restarting the badge. Must be a serial thing.
Interestingly, it does seem to be able to read from UART - if you run the test manually, you see the messages coming from the badge

I think this is fixed in the recent updates I made


What is this Camera save action using for?

https://github.com/Jumpat/SegAnyGAussians/blob/96e5021f2544af95e7705f91ecd8db6bb5cba381/scene/__init__.py#L121
Just curious why you covert the R,T matrix. Seems you didn't use it anywhere else.

Found a relative explanation.
https://github.com/graphdeco-inria/gaussian-splatting/issues/509#issuecomment-2290932322

Yeah I just re-use the 3D-GS code.😂


feat: Added storybook with button component

This PR adds storybook to the project (along with 2 other default story files included with initialization as reference for now), and a button component based on the current draft specs. Currently only includes 2 icons. Wasn't exactly sure what kind of templates we wanted for stories, but made them based on sizes for now.
@jgresham Do you happen to know what's going on with the typescript errors with the Github Actions? I'm still new with TypeScript, and I looked it up, but it's having issues with the Storybook generated files.. I thought about ignoring these files but that doesn't seem like a good idea either :thinking:
resolves #54

I'll try to add this as part of the npm run lint command.

Ahh, I put the folder in .eslintignore temporarily to get the commits in, but I'll remove it from the file and see what the behavior is like after your commit. Thanks for the help!

I'll try to add this as part of the npm run lint command.

Ahh, I put the folder in .eslintignore temporarily to get the commits in, but I'll remove it from the file and see what the behavior is like after your commit. Should be ready to merge after that. Thanks for the help!

I'll try to add this as part of the npm run lint command.

Ahh, I put the folder in .eslintignore temporarily to get the commits in, but I'll remove it from the file and see what the behavior is like after your commit. Should be ready to merge after that. Thanks for the help!

I'm okay with not linting the stories directory as storybook is mostly for viewing components and visual testing. If linting doesn't cause extra work, I'm ok with enabling it.

Two suggestions (If you could fix first for this PR that'd be ideal):

The components shouldn't have references to storybook. The components should work in both the app code and in storybook without any changes to the component. See ExternalLink story as an example. For now we can put redesigned components in src/renderer/Generics/redesign/...
If there is app level css(scss/sass maybe) code for the redesign (ex. the purple color we will use everywhere), we can put that in a file and import it for all storybook components (ex. here https://github.com/jgresham/nice-node/pull/58/files#diff-98b614e1838b171ee71c04450a8f1a562753193fb7d4f53a4de8b9b5a7e980eeR1)

Great work!! I know config for webpack can be troublesome and hard to debug, so thanks for getting that in here. It's great to see the redesigned button in here too!
The latest commit here is deployed at https://nndesign.netlify.app/


Lb multiple pt fix

@njagadish  @ashutosh-mishra

Fixed multiple PT creation in provider PTG in case of LB.
Fixed initial LB service launch showing wrong members in heat resource-list.
Corrected logs of PT add/remove and PTG add/remove.

Changes are fine, we can merge it.


fix bugs and make it work under python 3

I have tested this plugin under python3 and airflow v1.10.3. Hope this will help others.

Thanks man.
Your version worked with v1.10


test(ef-tests): add valid blocks test

invalidBlocks test cases currently not passing. I will try to check and fix it in the following PR

@onbjerg why did we have them disabled?


Cannot Pull Container Error

Steps to reproduce
changed cdk.ts variables
region: 'us-west-2' =>  region: 'us-east-1'
difyImageTag: '0.9.1' =>  difyImageTag: '0.10.1'
Note: Even without changing anything, the application produces the same problem
✔ Expected Behavior
The application should be working fine
❌ Actual Behavior
cannotPullContainerError: ref pull has been retried 1 time(s): failed to unpack image on snapshotter overlayfs: mismatched image rootfs and manifest layers

Here is the failing service

@Yazan-Hamdan Hi, sorry for the late reply! I couldn't reproduce the issue in my environment. Because It can be a transient error, can you retry the deployment?


Update Application model to be more generic

Update the Application model to be more generic.
Currently it assume the task_id format to be hive.schema_name.table_name which is not always the case. Extend it to be more generic.

Codecov Report

Merging #166 into master will decrease coverage by 11.53%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           master     #166       +/-   ##
===========================================
- Coverage   82.98%   71.45%   -11.54%
===========================================
  Files          58       58
  Lines        2862     2862
  Branches      308      308
===========================================
- Hits         2375     2045      -330
- Misses        394      745      +351
+ Partials       93       72       -21

Impacted Files
Coverage Δ

databuilder/models/application.py
90.47% <100%> (ø)
:arrow_up:

...r/sql_parser/usage/presto/column_usage_provider.py
0% <0%> (-89.29%)
:arrow_down:

...xtractor/table_column_usage_aggregate_extractor.py
0% <0%> (-84.91%)
:arrow_down:

.../transformer/sql_to_table_col_usage_transformer.py
0% <0%> (-71.56%)
:arrow_down:

databuilder/sql_parser/usage/column.py
20% <0%> (-60.91%)
:arrow_down:

databuilder/extractor/bigquery_usage_extractor.py
32.98% <0%> (-48.46%)
:arrow_down:

databuilder/transformer/base_transformer.py
62.5% <0%> (-18.75%)
:arrow_down:

...ilder/transformer/regex_str_replace_transformer.py
87.5% <0%> (-12.5%)
:arrow_down:

databuilder/models/table_column_usage.py
90.38% <0%> (-3.85%)
:arrow_down:

...tabuilder/extractor/postgres_metadata_extractor.py
91.8% <0%> (-3.28%)
:arrow_down:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bd6cd5...66d8509. Read the comment docs.


downgrade grpc

Fixes: #32324
Tested: apache/beam/actions/runs/10839063060/job/30078643883?pr=32446
One more run in flight: https://github.com/apache/beam/actions/runs/10840227044
GRPCIO issue: https://github.com/grpc/grpc/issues/37710

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

R: @lostluck
cc: @shunping

Tomorrow I'll look into ensuring the GoPortable tests run when these. Python deps change, to reduce a regression chance. Basically just needs to be the deps file here, and anything else in the portable python runner code.

the dependency had an upper bound, so that we find sooner than later that an upgrade breaks us


Feature request: guaranteed exact result

Since this module only deals in rational numbers, and positional representation of all rational numbers either terminate or repeat with a finite period, it ought to be possible to specify an argument like exact=True which forces the base convert routine to generate as many digits as necessary to return a mathematically correct result. This will require either changing how repeating digits are found (integrating that process into fractional_base()), or generating at least max_period * min_repeat (where max_period can be calculated from the input base, the number of nonrepeating fractional digits of input, and the number of repeating fractional digits of input) before find_recurring() is called.

Attempted this approach, but struggled to find a complete solution.
Have gone a middle ground where you can set "max_depth" to 0, or "exact" to True, and optionally set MAX_DEPTH on module to as high as required


Tags support

@eviltrout can you review Monday? Because Alan is out..

I commented with some minor issues. However, a lot of code has changed and I'm not confident that I would have caught any errors with it, especially since there are no specs.
We can merge when the issues have been fixed, but we'll have to keep a close eye on it for regressions.

@eviltrout done the parseInt part and changed it as switch case.

@vinothkannans are you still working on the other issues such as missing translation keys?

@eviltrout no. actually I didn't aware of that. I will check now.

Hi @vinothkannans, I'm having trouble reviewing the changes in plugin.rb. Could you add some tests as least for the new code that you've so that we avoid adding more technical debt? Thank you so much for your work here :+1:

Ping @vinothkannans  :)

Hi, sorry for delays to add tests. I will add it as soon as possible.

@vinothkannans No hurry just wanted to see where we're at with this :)

@tgxworld I have problems while running the plugin:spec. So please help me below.
https://meta.discourse.org/t/unable-to-run-plugin-spec/58413

@tgxworld It's done. I created RSpec testing functions for both SlackController class and Slack commands. And everything looks fine now.
Only one thing is pending which I mentioned above.

@tgxworld now it can be merged :+1:

@tgxworld thanks for your detailed review. Some of your points are remain from the existing code. I didn't changed the existing code without any need. Now I changed those too as per reviews :)
Also I am just intermediate stage rails developer. That's why I have lot of styling issues. I will fix all of it.
And as per your suggestions I am doing other many changes too. I will finish it all and explain other problems on the code as soon as possible :+1:.

@tgxworld As per review I done almost all changes except translations and few specs which I am doing right now. Can you please check and tell me if there anything still wrong in my code?

@vinothkannans  Good job adding more tests :+1:

Ok closing this then :+1:


feat: Add queryComplexityPlugin for query cost analysis

This plugin aims to easily define complexity in nexus field configs. It's based on graphql-query-complexity and inspired by TypeGraphQL's built-in query complexity integration.
This will also provide typings for the complexity estimator compared to graphql-query-complexity's more generic version.
This plugin will basically copy the exposed complexity value and place it in the field's extensions object for graphql-query-complexity to intercept.
Resolves #307.
Things done:

[x] Plugin implementation
[x] Tests
[x] Docs
[x] Kitchen sink example

Hope this gets included before final release :)

The new prisma framework seems to have a different plugin syntax. Should this be hold off for now?

@BjornLuG the framework plugin system is a superset. Please see your work through here :) as you’ve already started. We can maybe integrate this plugin automatically like we did with the connection plugin.
Sent with GitHawk

That's good to know! I took a look at plugin-prisma and it seems like it uses nexus-prisma under-the-hood too, with tight integration with Prisma 2.

This is a urgently needed plugin as there seems to be no other way to do query cost analysis with nexus.
Highly appreciating any progress here! 👍

This was quite an impressive PR, very thorough. Released in 0.12.0-rc.10


Create post hardfork schnorr signatures in transaction validation engine

This one is fairly straightforward, we will use Edwards25519 elliptic curve based Schnorr signatures, which allows signatures to be always one 64 byte to spend any typical number of inputs.

cancelling this and other new features


DbUpdateConcurrencyException due to code for adding blog posts

It seems there is a problem in the code that adds blog posts to an existing blog.
            if (existingPost == null)
            {
                existingBlog.Posts.Add(post);
            }

After saving the changes we get the following exception:

Microsoft.EntityFrameworkCore.DbUpdateConcurrencyException: Database operation expected to affect 1 row(s) but actually affected 0 row(s). Data may have been modified or deleted since entities were loaded. See http://go.microsoft.com/fwlink/?LinkId=527962 for information on understanding and handling optimistic concurrency exceptions.

It seems that changing the original code to the following fixes the problem:
            if (existingPost == null)
            {
                context.Add(post);
            }

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b9826f28-46b2-e845-f1bf-5cbc2d940208
Version Independent ID: 9c4a46cf-daa2-0e14-7ff1-c195db237cd0
Content: Disconnected Entities - EF Core
Content Source: entity-framework/core/saving/disconnected-entities.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @ajcvickers
Microsoft Alias: avickers

@wldevries I just cloned and ran the sample from which this code is taken and it is working correctly. I suspect you are using a different key type or have changed key configuration to not use generated key values. If not, then please attach a small, runnable project or post a small, runnable code listing that reproduces what you are seeing so that we can investigate.

We generate our primary ids in code, but did not set them to not value generated. That is probably the problem.

I checked with my colleague and that is indeed what the problem was. All of our primary keys are set to generated values, but our domain always generates these prior to inserting them. The combination is not logical, but we would not expect such an exception to occur or at least to get a more informative error. Is there a reason EF does not protest when you insert an entity with a filled in primary key when the key is configured to generate values?
By setting our primary keys to never generate values we fixed the crash.

It's not an error to explicitly set the primary key value even if it is configured to be generated. There are scenarios where allowing both is useful. However, when doing so the state of the entity must also be explicitly set in many cases.


is this project dead?

Haven't seen any commits since 10 months.

I guess so @atifsyedali . My brackets is bugged with this extension.


32 | Longest Valid Parenthesis | C++

Title -
What will change -
Type of Issue -
Please add/delete options that are not relevant.

[x] Adding New Code
[ ] Improving Code
[ ] Improving Documentation
[ ] Bug Fix

Programming Language
Please add/delete options that are not relevant.

[ ] Python
[x] C++
[ ] Java

Self Check

Ask for issue assignment before making Pull Request.
Add your file in the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Discord server ✉ - https://discord.gg/Ftbj4a
Happy Coding,

i want to work on it

[x] Assigning to @ricky1812 .


macOS tar ball "is damaged"

Describe the bug
MacOSX x64 tar ball on the website is "damaged".
To Reproduce
Steps to reproduce the behavior:

Download macosx x64 tarball
See the following shell traces:

tar -xzf microsoft-jdk-<IP_ADDRESS>-macos-x64.tar.gz
sha256sum microsoft-jdk-<IP_ADDRESS>-macos-x64.tar.gz
2e97bd29ca204d7bbaf26b8c648b1d529a0339e396b1f27a71281d05fb75ab3c  microsoft-jdk-<IP_ADDRESS>-macos-x64.tar.gz
jdk-11.0.10+9/Contents/Home/bin/java -version

Then MacOSX will pop up with the following dialogue:

"jdk-11.0.10+9" is damaged and can't be opened. You should move it to the Bin

Expected behavior
java -version should gives you java version number
Screenshots

Desktop (please complete the following information):

OS: macOS
Version Catalina 10.15.7

@gdams can you please take a look?

those steps work for me:
➜  tmp tar -xzf microsoft-jdk-<IP_ADDRESS>-macos-x64.tar.gz
➜  tmp sha256sum microsoft-jdk-<IP_ADDRESS>-macos-x64.tar.gz
2e97bd29ca204d7bbaf26b8c648b1d529a0339e396b1f27a71281d05fb75ab3c  microsoft-jdk-<IP_ADDRESS>-macos-x64.tar.gz
➜  tmp jdk-11.0.10+9/Contents/Home/bin/java -version
openjdk version "11.0.10" 2021-01-19
OpenJDK Runtime Environment Microsoft-18724 (build 11.0.10+9)
OpenJDK 64-Bit Server VM Microsoft-18724 (build 11.0.10+9, mixed mode)

The bundle is signed:
➜  tmp codesign -dvvv jdk-11.0.10+9
Executable=/Users/gadams/tmp/jdk-11.0.10+9/Contents/MacOS/libjli.dylib
Identifier=libjli-5555494483682c6b64a23333a53e7c7c6b3c77fb
Format=bundle with Mach-O thin (x86_64)
CodeDirectory v=20500 size=827 flags=0x10000(runtime) hashes=16+5 location=embedded
Hash type=sha256 size=32
CandidateCDHash sha1=3c96432859f61dad001940f4bc2788bba84253f0
CandidateCDHashFull sha1=3c96432859f61dad001940f4bc2788bba84253f0
CandidateCDHash sha256=d18ba4f3b9a9a98d5e7c1e73638e4718aa4fb1cb
CandidateCDHashFull sha256=d18ba4f3b9a9a98d5e7c1e73638e4718aa4fb1cbc34b0c499a102a071cba2d20
Hash choices=sha1,sha256
CMSDigest=fa2ebd665b104a7b809da4055b8e684c436c398f75c4c36194e6a6af759cb9ee
CMSDigestType=2
CDHash=d18ba4f3b9a9a98d5e7c1e73638e4718aa4fb1cb
Signature size=9061
Authority=Developer ID Application: Microsoft Corporation (UBF8T346G9)
Authority=Developer ID Certification Authority
Authority=Apple Root CA
Timestamp=22 Jan 2021 at 19:24:07
Info.plist=not bound
TeamIdentifier=UBF8T346G9
Runtime Version=10.13.0
Sealed Resources=none
Internal requirements count=1 size=208

I can reproduce the breaking steps on my Mac OS X Big Sur 11.2.3.
@gdams I see you're prefixing with tmp - FYI I'm running directly out of my ~/Downloads directory using iTerm2 and zsh as the shell.

A workaround is to use:
sudo xattr -dr com.apple.quarantine jdk-11.0.10+9/

I can confirm @karianna workaround works for me.

I think if there is no way round the "dialogue" then I think we need to document this. The error sounds a bit concerning for people who is new.

one thing we notice is the Azul's macOS tar.gz file does not have this problem. we will look into this and see how we can fix this problem. we will keep you updated!

we have a fix ready:

it will be in our next release.
thanks for reporting this issue!
/CC @brunoborges


spec for ParameterProperties is outdated

https://github.com/Microsoft/TypeScript/blob/master/doc/spec.md#831-constructor-parameters:

A parameter of a ConstructorImplementation may be prefixed with a public, private, or protected modifier.

This is missing readonly.

A parameter property declaration may declare an optional parameter (by including a question mark or a default value), but the property introduced by such a declaration is always considered a required property

This is no longer true since the (not so) recent rewrite of the declaration emitter.

The entire spec is outdated. The last real comit on it was nearly three years ago: https://github.com/Microsoft/TypeScript/commits/master/doc/spec.md
See also: https://github.com/Microsoft/TypeScript/issues?q=is%3Aopen+is%3Aissue+label%3ASpec
And mainly: #15711

The spec is now an "archived" artifact and we won't be tracking defects against it anymore.


Capability to match strings within an array

Added the capability to be able to search a field where the value is an array. Matcher will run for each item in the array and return true with a partial match.

@lalooola thank you for contributing!
Please apply the changes I suggested in comments, squash them into the original commit and this one can be merged.


Supplementaries (Supplementaries mod's Cannon feature)

Describe
The Third Person mod having issue when you have it installed when you use cannon from Supplementaries.
The cannon’s view gets stuck at the player's current interaction angle and cannot be moved. If I try to adjust it, the view is forcibly pulled back to its original position.
Reproduce
Steps to reproduce the behavior:

Have Supplementaries and Third-Person installed.
Click with cannon use maneuver.
The cannon’s view gets stuck at the player's current interaction angle and cannot be moved.

https://github.com/user-attachments/assets/b8d4a8de-d75e-41de-bbfd-2cf75c05bc80
Expected behavior
The Cannon's view should be able to move freely. like blow footage.
https://github.com/user-attachments/assets/87d76ff3-da47-4660-83d7-5ecc62fafdb3
Mod versions:
leawind_third_person-v2.2.0-beta.2-mc1.20-1.20.1-forge
supplementaries-1.20-3.0.4

A fix for this would be disabling the mod when the cannon is used...


Add validation correlation checks

Add correlation checks among +name and +code, etc., to hxl.validation

[x] add unit tests
[x] implement new schema support
[x] merge to test branch
[x] deploy to beta
[x] document in wiki

Doesn't always suggest an expected value when it should, but good enough for this release. Deployed to beta and documented in the wiki: https://github.com/HXLStandard/hxl-proxy/wiki/HXL-schemas


Nitor recipe through Botania is not working.

Catalyst is correct and other recipes work but glowstone to Nitor does not work.  It wants to go to redstone instead

hmm. It should just require a normal mana poll but that go broken after the mana powder got introduced. I will have to look into the script and see if I can make heads or tails about whats going on.

Corrected in 1.10. now takes a glowstone block and returns 4 nitor, also requires 4 times the amount of mana.


[$1000] QA Testing Issue

This issue is for QA testing https://github.com/Expensify/Web-Expensify/pull/38333 and it require me adding a random contributor. If you get assigned, please ignore it.
cc @thienlnam
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01d820f6f8159e57e1
Upwork Job ID:<PHONE_NUMBER>747151872
Last Price Increase: 2023-07-31

I don't see what the bug is. https://github.com/Expensify/Web-Expensify/pull/38333 This link is broken.

This was for QA testing an internal issue, please disregard it, everyone. Apologies for the ping.


Deep copy default value

Can there be a preference to set the default value for deep copy?

Yes.

Implemented in https://github.com/inventree/InvenTree/pull/633


fix(instrumentation-ioredis): make @types/ioredis a devDependency

Which problem is this PR solving?

@types/ioredis is listed as a dependency even though it's types are not part of the `@opentelemetry/instrumentation-ioredis package's public API

Short description of the changes

move @types/ioredis to devDependencies to avoid it being installed for consumers of the package.

Testing
Tested locally by running npm pack and then installing the package into a local package with typescript and without @types/ioredis installed. Imported and instantiated the instrumentation to check that everything still compiles correctly.
Fixes #2059

^^ @pichlermarc I enabled, and then disabled auto-merge. This is the first time I tried auto-merge on a PR from a repo that doesn't allow commits to the feature branch from the PR, so I cannot update with the base branch.

@trentm this must've happened as I'm using an organization fork and did not have maintainer edits enabled.
I run a script to enable edits on my PRs via the API as GitHub does not allow enabling maintainer edits via the UI.
I forgot to run the script for this PR (turned it on for all my PRs just now).


[DO NOT MERGE] Try fix the nuget security analysis check

Description
According to https://docs.opensource.microsoft.com/tools/nuget_security_analysis.html.
Only one feed with clear tag is allowed
Task Item
#minor
Screenshots

Coverage remained the same at 55.048% when pulling 3f40c19d2f784d123981c195e0302c867f0a0695 on donglei-try-nuget into fcad8c631280f741d3ee980785b8303df90d756e on main.

Closing this due to not able to fix this issue.


Linker error : unresolved _CryptAcquireContext and _CryptGenRandom

Hi,
I'm trying to build my iOS project using WinObjC but I get this linker error.
1>crypt_B64288EE.obj : error LNK2019: symbole externe non résolu _CryptAcquireContext référencé dans la fonction _cryptrand
1>crypt_B64288EE.obj : error LNK2019: symbole externe non résolu _CryptGenRandom référencé dans la fonction _cryptrand

Any idea where these _CryptAcquireContext and _CryptGenRandom symbols come from ? And which dependency should I add to the linker parameters to be able to link ?
Thanks

Hi @Angeman! Thanks for reporting this.
It looks like CryptAcquireContext and CryptGenRandom are Windows Desktop only APIs; they can't be used from Universal applications like the ones WinObjC makes.
If you're the author of the encryption code, you should be able to adopt the UWP APIs in the Windows.Security.Cryptography namespace; namely, CryptographicBuffer.
There's some C# documentation on doing that here. You should be able to adapt it to the WinObjC projections in UWP/WSCryptography.h for Objective-C or use C++/WinRT for C++.

Sorry, I meant UWP/WindowsSecurityCryptography.h :smile:

Since this looks like code outside of our control (and using the Win32 API surface), I'll close this one pending further info.


move recirculate flag to ingress

@cc10512 @hanw Same thing with this PR as for the other one moving decision to recirculate to ingress, not egress -- I will try merging it in to make it easier to make further proposed changes on top of these.


Output size issue in alexnet and inception

AlexNet
File "/lib/python3.6/site-packages/cnn_finetune/base.py", line 158, in calculate_classifier_in_features
output = original_model.features(input_var)
File "/lib/python3.6/site-packages/torch/nn/modules/pooling.py", line 143, in forward
self.return_indices)
File "/lib/python3.6/site-packages/torch/nn/functional.py", line 334, in max_pool2d
ret = torch._C._nn.max_pool2d(input, kernel_size, stride, padding, dilation, ceil_mode)
RuntimeError: Given input size: (256x1x1). Calculated output size: (256x0x0). Output size is too small at /opt/conda/conda-bld/pytorch_1518243271935/work/torch/lib/THNN/generic
inceptionresnetv2
File "/lib/python3.6/site-packages/torch/nn/functional.py", line 90, in conv2d
return f(input, weight, bias)
RuntimeError: Given input size: (320, 1, 1). Calculated output size: (100, 0, 0). Output size is too small.
inception_v3
line 90, in conv2d
return f(input, weight, bias)
RuntimeError: Given input size: (288, 1, 1). Calculated output size: (100, 0, 0). Output size is too small.
inception_v4
Given input size: (384, 1, 1). Calculated output size: (100, 0, 0). Output size is too small.
NB1. For AlexNet, changing the train_original_classifier to True (it was False in all the above) gave the following error:
File "/lib/python3.6/site-packages/cnn_finetune/contrib/torchvision.py", line 93, in check_args
'For the original classifier '
Exception: For the original classifier input_size value must be (224, 224)
NB2. pre_trained_model = True in all the above

The problem is that some layers in a neural network (such as pooling layers or convolutions with stride > 1) reduce spatial dimensions of the activation map. So if the input image size is too small, you can't make a full forward pass through a network because activation map somewhere in the middle of the network will become too small.
One possible solution to this problem is to increase the size of the input image (for example you can rescale it or pad image borders with zeros).
I will try to make this exception less cryptic.

Now make_model will show a more clear exception message when the input_size value is too small for a selected model architecture.
For example make_model('vgg16', num_classes=10, pretrained=True, input_size=(8,8)) will raise an exception with the following message: RuntimeError: Input size (8, 8) is too small for this model. Try increasing the input size of images and change the value of input_size argument accordingly.

But increasing the input size of images will increase the computational complexity. Any other way around this?

You can modify the architecture of the original model (for example remove some downsampling layers). However, this procedure can lower the quality of the model, because the model was trained using all the layers. If you want to modify the architecture you have to use the original model definition from torchvision or pretrainedmodels, since there are many ways of doing this task and maintaining them in pytorch-cnn-finetune will be a difficult problem to solve.

Thanks! It seems that for VGGs, the minimum acceptable size is 32x32.
Not sure if there could be a warning somewhere in base.py, before the execution flow goes to Torch.


Add Sync version

Hey, I was interested in using this crate in one of projects, however I need CLruCache to be Sync, as I want to share the cache between threads. Would you be willing to either changing to be using Arc internally or providing a sync version of CLruCache?

Sure! I'll release a new version that will include Send. For Sync, I would need to review if that's appropriate but I am not sure I am qualified to do so^^ Additionally, most interesting are taking a mutable reference to self so how would exactly one would use it in a Sync context?

Additionally, most interesting methods are taking a mutable reference to self so how one would use it in a Sync context?

Through a Mutex or RwLock? The code I wrote when I tried using this library with peek to check the cache with only a read lock and then later a write lock to use put_with_weight to insert into the cache, pretty simple.

I have just tagged version 0.5.0 that should include Send.

Through a Mutex or RwLock? The code I wrote when I tried using this library with peek to check the cache with only a read lock and then later a write lock to use put_with_weight to insert into the cache, pretty simple.

Just to be clear, this is only required for a RwLock right?
There is already a test for the Mutex case and it works fine: https://github.com/marmeladema/clru-rs/blob/a464acac4594a8159d88df8b6e6ddbece8d6f3b1/src/lib.rs#L2643-L2692
About replacing the Rc by an Arc, I am worried about the performance impact it might have but I don't have benchmarks to measure it (yet?). I am not against providing a Sync version somehow, but I would want to avoid code duplication and macro rules. I'll see what I can do :)


superTuxKart: Build on Darwin

Motivation for this change
Make STK build on Darwin. I can't test functionality but I'm getting the same GL-related error with this package that I get with the official download, so I assume it works.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 123289 at f2a29c1e run on aarch64-linux 1

3 packages built successfully:

angelscript
superTuxKart
wiiuse

1 suggestion:

warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?
Near pkgs/development/interpreters/angelscript/default.nix:14:14:
   |
14 |   inherit (s) name version;
   |              ^

Near pkgs/development/interpreters/angelscript/default.nix:14:14:
   |
14 |   inherit (s) name version;
   |              ^


Unmount Error

When we change page immediately without waiting a second, It gives that error
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'geoObjects')
    at Proxy.beforeUnmount (vue-yandex-maps.esm.js?29dc:1:1)
    at callWithErrorHandling (runtime-core.esm-bundler.js?21f2:155:1)
    at callWithAsyncErrorHandling (runtime-core.esm-bundler.js?21f2:164:1)
    at hook.__weh.hook.__weh (runtime-core.esm-bundler.js?21f2:2667:1)
    at invokeArrayFns (shared.esm-bundler.js?7817:556:1)
    at unmountComponent (runtime-core.esm-bundler.js?21f2:5584:1)
    at unmount (runtime-core.esm-bundler.js?21f2:5494:1)
    at unmountComponent (runtime-core.esm-bundler.js?21f2:5593:1)
    at unmount (runtime-core.esm-bundler.js?21f2:5494:1)
    at patch (runtime-core.esm-bundler.js?21f2:4458:1)

Error comes from this part of "vue-yandex-maps.esm.js" file, and changing it like that can be temporary solution, but this time it gives another error. However, a new error does not break all application like before.
beforeUnmount: function () {
       this.myMap && this.myMap.geoObjects && this.myMap.geoObjects.removeAll();
},

New Error :)
Uncaught TypeError: Cannot read properties of null (reading 'offsetWidth')
    at Object.getSize (full-a9ffce0fd63bb5a1e51cf340bee7e3156782068f.js:1420:3319)
    at new v (full-a9ffce0fd63bb5a1e51cf340bee7e3156782068f.js:606:1096)
    at new J (full-a9ffce0fd63bb5a1e51cf340bee7e3156782068f.js:618:1508)
    at Proxy.init (vue-yandex-maps.esm.js?29dc:517:1)
    at eval (vue-yandex-maps.esm.js?29dc:243:1)
    at Array.forEach (<anonymous>)
    at e.value (vue-yandex-maps.esm.js?29dc:242:1)
    at eval (vue-yandex-maps.esm.js?29dc:310:1)

Could you make some code example to reproduce?

First of all - try to use version 1.1.0 instead os 0.12.x. It must work more stable

Fixed in ver. 0.12.7


Disable "No mixfile found in project..." notification when working on exs files

When working on a one off script, the extension publishes a No mixfile found in project. To use a subdirectory, set 'elixirLS.projectDir' in your settings notification each time the file is saved.
Expected Behavior: Do not spam "No mixfile found" messages when working on a script not using mix. A config option to disable the message entirely could also be an option.
Environment

Elixir & Erlang versions (elixir --version):
Erlang/OTP 23 [erts-11.1.3] [source] [64-bit] [smp:12:12] [ds:12:12:10] [async-threads:1] [hipe]
Elixir 1.11.0 (compiled with Erlang/OTP 23)

Operating system: Arch Linux

Editor or IDE name (e.g. Emacs/VSCode): VSCode

Troubleshooting

[X] Restart your editor (which will restart ElixirLS) sometimes fixes issues
[X] Stop your editor, remove the entire .elixir_ls directory, then restart your editor

Duplicate of https://github.com/elixir-lsp/elixir-ls/issues/307


Ordering of x and y axis in heatmaps

Allow the user to customise the ordering of x and y axis in heatmaps.
This could be:

sorting by label

sorting numerically (if numerical labels are used)
sorting lexicographically

allowing the user to specify a custom order of labels

It seems like the way to implement this is to sort the data table itself before calling the heatmap plot.

Implemented in 745d245cf53a9a368bf98f2dc315b141ea29d597


Update README.md

Missing comma at end of line. Copying and pasting into sublime caused an error message. Simples ;)

Thank you @edanedison merging now.


Create the monster sample project to verify API

See e.g. https://groups.google.com/forum/#!topic/flatbuffers/rjRlH74_H84
Will see if I can make a stab at it.

First version at https://github.com/mzaks/FlatBuffersSwift/pull/51


#7010: Replaced 'python.enableJedi' setting with 'python.languageServ…

For #7010

Updated unit tests accordingly
Updated telemetry event that records switches between language servers
Added code to automatically update existing "python.enableJedi" setting to new setting

[X] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
[X] Title summarizes what is changing
[X] Has a news entry file (remember to thank yourself!)
[X] Appropriate comments and documentation strings in the code
[X] Has sufficient logging.
[X] Has telemetry for enhancements.
[X] Unit tests & system/integration tests are added/updated
[n/a] Test plan is updated as appropriate
[n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)
[n/a] The wiki is updated with any design decisions/details.

Codecov Report

Merging #7011 into master will decrease coverage by <.01%.
The diff coverage is 95.58%.

@@            Coverage Diff             @@
##           master    #7011      +/-   ##
==========================================
- Coverage   58.31%   58.31%   -0.01%
==========================================
  Files         483      483
  Lines       21347    21368      +21
  Branches     3445     3450       +5
==========================================
+ Hits        12449    12460      +11
- Misses       8123     8136      +13
+ Partials      775      772       -3

Impacted Files
Coverage Δ

src/client/common/featureDeprecationManager.ts
36.2% <ø> (ø)
:arrow_up:

src/client/telemetry/index.ts
86.13% <ø> (ø)
:arrow_up:

...activation/languageServer/languageClientFactory.ts
95.12% <ø> (ø)
:arrow_up:

src/client/common/types.ts
100% <ø> (ø)
:arrow_up:

...nt/languageServices/proposeLanguageServerBanner.ts
58.82% <0%> (ø)
:arrow_up:

src/client/linters/linterAvailability.ts
95.83% <100%> (ø)
:arrow_up:

src/client/linters/linterInfo.ts
91.66% <100%> (ø)
:arrow_up:

src/client/common/configSettings.ts
57.54% <100%> (ø)
:arrow_up:

src/client/testing/common/updateTestSettings.ts
95.74% <100%> (+0.39%)
:arrow_up:

...-window/intellisense/dotNetIntellisenseProvider.ts
61.9% <100%> (+1.9%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a51495...f89acf8. Read the comment docs.


extract subexpression does not replace all occurrences

int foo()
{
    int x = 1 + 1;
    int y = 1 + 1;
    return x + y;
}

Extracting 1 + 1 leads to:
    auto placeholder = 1 + 1;
    int x = placeholder;
    int y = 1 + 1;

The whole purpose of the transformation is not having to replace all the occurrences manually.
Also the cursor is at placeholder^; afterwards. Instead it should multi-cursor select all occurrences of the new name so it can be changed right away.

My understanding is that this is not a goal of the "extract subexpression to variable" refactoring.
The goal is to take an expression (usually one which is not already the initializer of a variable, but rather a sub-expression of an initializer, or an expression used in some other context than an initializer), and extract a variable with that as its value, with the intent of you then subsequently adding new uses of that variable.
What you're suggesting here sounds like a new refactoring that's more challenging to implement, as it needs to search the code for other occurrences of the expression, and prove that the various occurrences of the expression do in fact have the same value (so, for example, if the expression references a non-const variable, clangd would need to prove that its value does not change between occurrences; if the expression includes a function call, clangd would need to prove that its return value does not change between calls). This latter check is data-dependent and not tractable in general (but could be in a subset of cases).

usually one which is not already the complete initializer of a variable

Just a simplified example.

it needs to search the code for other occurrences of the expression, and prove that the various occurrences of the expression do in fact have the same value

I don't expect it to be smart about it.
The reason for doing this kind of transformation is usually to get rid of copy-paste in existing code.
I just want it to automate the tedious steps.

I don't expect it to be smart about it.

If you don't expect it to be smart about it, then what would the refactoring give you over your text editor's search-and-replace?

By smart I meant it doesn't need to prove the expression always gives the same result. That's almost impossible anyway in general.
But it should restrict its actions to the current function/block. That's what the text editor doesn't do, it jumps around everywhere.
This nicely summarizes typical expectations:
https://docs.wholetomato.com/default.asp?W514

Some text editors provide a "replace all in selection" feature that's handy for such occasions (though not all -- e.g. Eclipse has it, but I'm not seeing it in VSCode).
Eclipse also provides a shortcut for "select enclosing block", maybe we could add something like that to clangd.
It sounds like the desired action could be achieved using those + textual replace.

I agree with what Nathan mentioned above. In general it's not feasible for clangd to prove that two same expressions from different contexts evaluate to the same value.
Hence this will restrict the feature only to the constant expressions and having multiple occurences of those is IMO quite rare (especially in the same code block, not even in the same file. you mention a copy paste approach, but is it really common for you to copy paste a sub expression into multiple places inside the same code block  or do you just put it into a variable and copy paste its name instead?)
As for cursor position, LSP doesn't provide a way for a server to say "put the cursor into this place" let alone multiple places after execution of a code action. So this needs to be implemented on client/editor side or the protocol needs to be changed. You can issue a rename request immediately afterwards though.

Hence this will restrict the feature only to the constant expressions and having multiple occurences of those is IMO quite rare

There are pure and idempotent function calls for example. For the latter we don't even have an attribute. The former is rarely used. Clangd can't prove anything in general and doesn't need to imho. It's just about automation.

you mention a copy paste approach, but is it really common for you to copy paste a sub expression into multiple places inside the same code block or do you just put it into a variable and copy paste its name instead?

I've seen people copy-paste whole functions which were already way too large just to change 1 or 2 occurrences of something instead of introducing another parameter. There's really no limit to this insanity in the world.

As for cursor position, LSP doesn't provide a way for a server to say "put the cursor into this place" let alone multiple places after execution of a code action. So this needs to be implemented on client/editor side or the protocol needs to be changed. You can issue a rename request immediately afterwards though.

Yeah I kind of already anticipated that. But would be a cool feature.