Fix report action draft still present after deleting the workspace

Details

When we delete a workspace, all workspace-related chat is archived, and not allowed to edit any message, but every message on edit is still present allowing to user to edit it but eventually, an error is thrown from the BE.
Fixed Issues

$ https://github.com/Expensify/App/issues/26887
PROPOSAL: https://github.com/Expensify/App/issues/26887#issuecomment-1709706116
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Prerequisites: have a workspace

Open workspace chat (either #admins or #announce)
Send any message
Press the pencil icon to start editing the message
Verify the message enter the edit mode
Delete the workspace
Verify the message back to a normal view (non-edit mode)

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/50919443/94ba7e2e-e393-4492-8fe5-d51f86d72da3

Android: mWeb Chrome

https://github.com/Expensify/App/assets/50919443/b81b02db-32d6-41d3-85b0-84b5cfa77646

iOS: Native

https://github.com/Expensify/App/assets/50919443/45fc92d7-648a-4cb5-88cf-096b7326a651

iOS: mWeb Safari

https://github.com/Expensify/App/assets/50919443/2d356248-e616-41b1-9cb7-3f2ad676d28a

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/50919443/fe1aa1fa-bd79-4790-be76-1e9c2ef29a7d

MacOS: Desktop

https://github.com/Expensify/App/assets/50919443/91f76e3f-6b83-4185-a3a4-4a0cd1a8dc87

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/cead22 in version: 1.3.91-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.91-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/cead22 in version: 1.3.93-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.93-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Error installing fermentrack - unable to locate nginx and redis-server

I tried to install fermentrack on a brand new Pi 3B+ with raspbian and latest updates to it, nothing else installed. Then tried installing fermentrack with the curl command but it failed so I tried the manual steps listed. When running command "sudo fermentrack-tools/install.sh" I get this error:
...
hat user would you like to install Fermentrack under? [fermentrack]:
fatal: Not a git repository (or any of the parent directories): .git
::: Configuring under user fermentrack
::: Configuring in directory /home/fermentrack
::: Checking for Internet connection:
::: Internet connection Success!
::: Checking whether this script is up to date...
::: /home/pi/fermentrack-tools/update-tools-repo.sh start.
::: /home/pi/fermentrack-tools/update-tools-repo.sh end.
::: Installing dependencies using apt-get
::: apt is updated - installing git-core, nginx, python-dev, and a handful of other packages.
::: (This may take a few minutes during which everything will be silent) ...
*** ----------------------------------
*** ERROR ERROR ERROR ERROR ERROR ***
*** ----------------------------------
*** See above lines for error message
*** Setup NOT completed
*** More information in the "install.log" file
Then the install log has these two errors:
::: Installing dependencies using apt-get
::: apt is updated - installing git-core, nginx, python-dev, and a handful of other packages.
::: (This may take a few minutes during which everything will be silent) ...
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package nginx
E: Unable to locate package redis-server
*** ----------------------------------
*** ERROR ERROR ERROR ERROR ERROR ***
*** ----------------------------------
*** See above lines for error message
*** Setup NOT completed
*** More information in the "install.log" file
Any hints on how to proceed with the installaton of fermentrack?

Thanks, tried the above command as well but get the same error as in the logfile. I'll try again later.

Tried several times but no luck. Also tried to install another package and got the same error so I ran "sudo apt-get update" and re-ran the installation which succeded - Fermentrack successfully installed :) Guess there was some error introduced in the raspbian updates I got after first update.

Weird. I’ll see if I can add another round of apt get update/upgrade after the first to the installer just to be safe. Part of me wonders if one of the upgraded packages changes the list of repositories, so a second round is required to see/install new packages.
In any case, glad that its working now. Let me know if you run into other issues!

Yes things look good now at least with the installation.
I am trying to configure a couple of Ispindels. Got calibration results
from the guy I bought them from along with a formula for Brewfather and one
for Monitor.beer. Not sure how to add the different coefficients A, B, C
and D so I tried to Add calibration points. The angle to specify is ok but
what unit is the Gravity specified for? The six calibration points I got
from the iSpindel seller are shown here but when I entered these I get a
reading of SG at 18.783 so I think something is wrong...
On 13 August 2018 at 17:04, John<EMAIL_ADDRESS>wrote:

Weird. I’ll see if I can add another round of apt get update/upgrade after
the first to the installer just to be safe. Part of me wonders if one of
the upgraded packages changes the list of repositories, so a second round
is required to see/install new packages.
In any case, glad that its working now. Let me know if you run into other
issues!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/thorrak/fermentrack/issues/301#issuecomment-412550510,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AoXAECMX_ZHqNfEYYqCMvbuMy45ej9ojks5uQZWWgaJpZM4V5lAS
.


Implement intrinsic to get from smart-contract ram payer for user data

available intrinsics and set ram payer intrinsic


Proposal: Integrating Validating Remote Signer (VLS) in RGB Lightning Node

Proposal: Integrating Validating Remote Signer (VLS) in RGB Lightning Node
At ThunderStack, we aim to provide the best possible service and security for our clients, developers, and users. To achieve this, we propose integrating the Validating Remote Signer (VLS) into the RGB Lightning Node.
Motivation
During the implementation of a cloud solution for the RGB Lightning Node (RLN), one of the primary concerns raised by users was the need for higher standards of security. Users emphasized the importance of separating the signer from the node to minimize attack surfaces and enhance key protection. To address these needs, we propose providing several deployment options for the signer, each offering different trade-offs in terms of security, usability, and control. See the use cases below for details.
Use Cases
1. Secure Remote Signer Deployment
By default, deploy the remote signer to AWS Nitro Enclaves, ensuring:

Isolation of the signer in a hardware-secured environment.
Protection against unauthorized access and external threats.

Reference: AWS Nitro Enclaves
2. User-Hosted Non-Custodial Signers
Provide users with:

Scripts and documentation for hosting signers locally, ensuring full key ownership.
Optional MPC-based signing for enterprise-grade security in cloud environments, inspired by Fireblocks custody solutions.

Reference: Fireblocks MPC API, AWS Nitro MPC
3. Mobile Wallet Integration
Enable signers to operate on mobile wallets by:

Supporting a non-custodial architecture suitable for mobile aligning with the Greenlight framework, to keep secret keys on user's device for signing operations.
Leveraging notification systems to wake the device for signing operations.

Reference: Breez SDK Notifications, Greenlight Key Manager
Reference Implementation
LDK VLS Implementation
The LDK VLS Implementation demonstrates the use of Lightning Development Kit (LDK) with VLS
Design Goals

Ensure compatibility with Greenlight.
Enhance security for both cloud-hosted and user-hosted setups.
Introduce enterprise-level security via MPC mechanisms.

References

AWS Nitro Enclaves
Fireblocks MPC
Breez SDK Notifications
Greenlight Key Manager
VLS Overview
VLS Transaction Diagrams

Thanks for the proposal, we'll have a deeper look at it and post our updates here. We're currently working on other tasks ATM so it could take some time for us to post a reply.

Thanks for the proposal, we'll have a deeper look at it and post our updates here. We're currently working on other tasks ATM so it could take some time for us to post a reply.

Thank you for your response! I appreciate you taking the time to consider the proposal, and I’m ready to provide anything you need from me if it helps. Looking forward to your updates!


Simplify torch DeepAR code

Description of changes: The code related to lags is a bit involved, when it can be a simple function to be called right before invoking the RNN. No wonder that, even after introducing an additional module with all the overhead, this results in saving lines.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup

the lag seq helper is useful I believe for other recurrent models, do you think it makes sense to move it somewhere else? In particular, the S4 model I have follows a similar structure to this...  but yes it's fine here too...

actually @lostella every model i implement I have to copy the get_lagged_subsequences helper... could we move this helper to the features folder?

@kashif sorry just saw your previous comment. Yes it's probably useful more in general, let me move it

this is a nice helper which is somewhat unique to the time series situation... essentially I think of it as trading off between sequence length and feature size... I do not think any other modality as far as I can tell allows such a tradeoff...

Yes, and having it as a simple function is much clearer I think. Plus it seems that it's saving us ~140 lines which is always good

yes for some reason it always feels nicer when you delete code than when you add it haha... BTW I suppose you will re-add the test in its own file?

thank you! this is super helpful I believe!


PCQ-1622 to test PCQ-Backend java upgrade changes

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/PCQ-1622
Change description
To Test PCQ-backend changes for java upgrade and reflection removal.
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

Testing has been completed so closing this ticket


Czech Koruna changed to Czech Crown

Czech Koruna didn't make sense, changed to Czech Crown which corresponds with English name for it

Wikipedia calls is "Czech koruna":
https://en.wikipedia.org/wiki/ISO_4217
https://en.wikipedia.org/wiki/Czech_koruna
We'd need a reference regarding its official name to change it, otherwise it gets political.

Closing as my last comment wasn't answered.


Amazon lookup failed, error: HTTP Error 400: Bad Request

This error is shown for every URL I'm trying.

it seems Amazon has changed the access policy:

Important Change - Managing Your AWS Secret Access Keys
As described in a previous announcement, you cannot retrieve the existing secret access keys for your AWS root account, though you can still create a new root access key at any time. As a best practice, we recommend creating an IAM user that has access keys rather than relying on root access keys.

I don't think this is the issue. For the Advertising API you have to use root access keys. This warning is just telling you that if you don't have the secret key, your not going to be able to get it back.

I'm also getting similar issues. I'm using the same email address for my PA API account, AWS Account, and Associate Account. I created a new IAM user account, retrieved the new access keys and updated the code. Still not working yet.
So many other users are also experiencing the same issues: https://forums.aws.amazon.com/message.jspa?messageID=787275. I'm pretty sure Amazon changed something about the authentication process, but I haven't found out what it is yet.

I've followed the steps provided here: https://docs.aws.amazon.com/AWSECommerceService/latest/DG/becomingDev.html

Created a new IAM account
Created a new policy giving full access to the PA API
Assigned the new policy to the new account
Downloaded IAM account keys
Updated access keys in the code

Still getting a 400 error.

Make sure you are using a US associates account. I was having trouble with my Canadian account.

yes, it is not an issue. make sure your amazon
AWSAccessKeyId, AWSSecretKey, unique Associate ID are all right and can be used

I believe that Amazon made a change about what credentials could access each region. In the past, I have been able to use my credentials to access other regions, but lately, I am only able to access regions outside of the U.S. by using credentials made specifically for those outside regions.

@ramarlina how many minutes?  it's been about an hour now.  :-/

to answer for anyone else hitting here from google:  access to PA API is no longer included by default in your associates account.  you have to apply / get approved.  you're ineligible to apply until you've completed at least 3 qualified sales through the associate's problem, and you've been manually reviewed/approved.  you can send an email through the associate's help system to request early access (it has to be an email, calling or using the chat function won't do it).  they claim a 3-4 day turnaround for the decision.  (however the amazon rep i spoke w/ using the chat function told me not to get my hopes up.)

Dear associate,
We regret to inform you that we are unable to accept your request for access to the Product Advertising API. We have reviewed your site and found the following issues that prevent us from approving your account for access: while reviewing your request, we see that you did not include a valid business justification that explained your intended use of the Product Advertising API.
However, your account is still pending review. In the meantime, you can make use of the other product linking tools available on Associate Central. You can learn more about building your website and making use of these tools via this link: https://affiliate-program.amazon.com/resource-center/?ac-ms-src=ac-nav.
FAQs on Product Linking can be found here: https://affiliate-program.amazon.com/help/node/202049370
Thank you for your interest in the Associates Program.

Pretty fed up with how Amazon handles their APIs.  Apparently, for me, I've applied for an Amazon Associates account, but I must drive at least three qualified sales within 180 days before I can be accepted.  This goes against our site's anti-ad policy (not that we'd be able to get those sales anyways).
It would be really nice if Amazon actually fixed up how they handle their APIs.  :/


User guide references

Update references of the user guide and fix correct formatting issues in docstrings.

Andreas, thanks for the review! Your comments are all included. Unfortunately, in the references, the individual classes of a module are sorted alphabetically. In our code, we did not sort the classes alphabetically. That is why the citations do not appear chronologically in the html documents.


Support for generated columns

Refs #1116. My first attempt at this worked on my laptop but broke in CI, so I'm going to iterate on it in a pull request instead.

I need to replicate these failures on my laptop. My hunch is that this is down to the version of SQLite available to Python.

On my laptop:
platform darwin -- Python 3.8.6, pytest-6.0.1, py-1.9.0, pluggy-0.13.1
SQLite: 3.33.0

In CI they are all SQLite: 3.22.0

This kind of problem is why I have a tmate workflow:

Here's the problem: https://www.sqlite.org/changes.html#version_3_26_0

2018-12-01 (3.26.0)

Added PRAGMA table_xinfo that works just like PRAGMA table_info except that it also shows hidden columns in virtual tables.

CI is running 3.22.0.

I just deployed this and its working great.
In a very unscientific benchmark my response times went from around 22-25ms to 33-36ms, but I didn't even dig enough to confirm the latency is related to the change.  It's on a VPS, so maybe the load changed.


Write up contributing guidelines, project description, code of conduct

Description

Project wiki requires project description, contributing guidelines, and code of conduct
Acceptance Criteria

[ ] Project description
[ ] Contributing guidelines
[ ] Code of conduct

Implementation details

an
Testing notes

na

@rainasong Please review ticket


Develop

@acouchman   I took inspiration from your pull request and created another implementation of the vertical wizard.  one thing I wanted to fix was the small click area on the current links.  much appreciated.

For reference https://github.com/Availity/availity-uikit/issues/30


Problem with Open Shell

Hi I hope someone might be able to help. We have Open 4_4_142 on two laptops. There have been no problems over the years until my wife suddenly had things go wrong. The W10 start andW10 desktop with basic tiles appeared in place of the Open setup and desk top shortcuts she uses. The taskbar was the basic W10 one as well. I have uninstalled and after re downloading and reinstalled Open Shell, I used my setting but its now a mix of open shell start batten, click on it and the Open Shell W7 style start is there but with The W10 desktop and task bar. To confuse things as I have tried things the old desktop can be seen on occasion but it goes back to the W10 one. Sorry if this is a bit confusing, it in my younger years it would be an interesting challenge, but now its just a pain and my wife is finding it very difficult to cope with the screen as it is.

We can't help you here. Ask in open shell

Open-Shell is the successor Project of WinNT Custom Startmenu :
https://github.com/Open-Shell/Open-Shell-Menu/issues
best

https://github.com/Open-Shell/Open-Shell-Menu


Fix node_map construction

Or if this map isn't used, we can delete it for now. I can't remember if used it if I only thought it would be needed.

I also don't see any direct use of this. I thought it might be getting used internally in onnx_importer.NodeImporter.define_function that's why didn't remove this.

Or if this map isn't used, we can delete it for now. I can't remember if used it if I only thought it would be needed.

I also don't see any direct use of this. I thought it might be getting used internally in onnx_importer.NodeImporter.define_function that's why didn't remove this.

Let's just drop it for now then. Was just a bad assumption on my part. The output to node map is probably what we actually want in the future.

Or if this map isn't used, we can delete it for now. I can't remember if used it if I only thought it would be needed.

I also don't see any direct use of this. I thought it might be getting used internally in onnx_importer.NodeImporter.define_function that's why didn't remove this.

Let's just drop it for now then. Was just a bad assumption on my part. The output to node map is probably what we actually want in the future.

Done


Enable dev.openjdk on only Linux platforms

Enable dev.openjdk on only Linux platforms
Related to upstream change: https://github.com/adoptium/ci-jenkins-pipelines/pull/57

Signed-off-by: Mesbah Alam<EMAIL_ADDRESS>

@AdamBrousseau - please review.

Spoke to Shelley about this. She suggested that this change should happen at upstream, in https://github.com/adoptium/ci-jenkins-pipelines. Otherwise there could be merge conflicts next time we pull changes from upstream. Moving this PR to draft for now.


Signature.json documentation  missing

This file is used to validate if a pack is edited or not,  this should be documented so that  content creators can safely eliminate cheating in gameplay via addons, like they can make anti x-ray ,   disable player x-ray,  disabling kill aura etc.

Adding this to our investigation work. We are investigating this task to see how we can properly handle documenting this JSON file.

Hi @tinedpakgamer - after some investigation, it seems like this is used mainly on the Minecraft Education edition side and it is not used as widely by Bedrock creators. I love learning new things, so if there is a process you use with signature.json, I would like to learn more about it. I'm going to close this issue for now. Thank you!


Make fs $refs relative to the same directory

I believe v2.5 resolved everything from the swagger.yml source directory or process.cwd(), but that appears to have changed after v3.
Is this configurable in v3?
To clarify, would prefer all references relative to a common base path, e.g. /fruits/orange.yml would use:
$ref: /fruits/apple.yml
$ref: /vegetables/carrot.yml

rather than:
$ref: ./apple.yml
$ref: ../vegetables/carrot.yml

Unfortunately, there were several aspects of Swagger Parser 2.x that did not properly adhere to the specs.  One of the major changes in version 3.0 is that we now fully follow to the specs.  This ensures that Swagger Parser works consistently with other tools and libraries.
For JSON References, you can use absolute paths (e.g. /vegetables/carrot.yml), which will always be unambiguously resolved, or you can use relative paths (e.g. ../vegetables/carrot.yml), which will be resolved relative to the current file path.

Are there any hooks in the API where I could override that?

There aren't any API hooks, since the functionality is dictated by the spec.  But all the logic is in read.js, so you can fork and modify that one file.   Specifically, the methods you'd need to change are read$RefFile (for local files) and read$RefUrl for URLs.

Thanks.


Add reviewers option

When creating the PR, it would be useful to be able to add the reviewers option

getting somewhere with this but not there yet. Getting a could not request reviewer: not found error which I haven't managed to google anything for. It works from my CLI, so maybe it's a permissions issue.

For some reason this is really hard. I also tried:

Using gh pr edit --add-reviewer - gets an error about lack of permission.
Using curl against the REST API - gets a 422 error when I run it in actions.

Too frustrating and not valuable enough to waste any more time on. I'm giving up.


Update howto-migrate-using-export-and-import.md

Amended the first pg_dump command due to the hyphens being merged by formatting as a single hyphen

@akdataai : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Changes looking good.  Thanks @akdataai .
#sign-off


Qt wallet shows a transaction as not cancelled, but funds not there.

See screenshot.

v3.1 shoudl fix that


Navigation bar - new component

The navigation bar component should tap into the navigation stack of Angular. It should expose back button upon navigation, and interacting with the back button should pop from the navigation stack and transition the application back a view.
The navigation bar should also hold a title and an icon.

The requirements for Sprint 14 is to display a back button and to allow navigating back in the navigation stack.


Returning event with arg is adding " to the string content

Describe the bug
A clear and concise description of what the bug is.
I'm doing a recursive event with string arg, but the arg content was wrapped with a pair of " in the second pass.
To Reproduce
Steps to reproduce the behavior:

Code/Link to Repo:
async def a(self, name: str):
print(name)
xxxx
return self.a(name)

Example output:
minio
"minio"
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
** Specifics (please complete the following information):**

Python Version:
Pynecone Version:
OS:
Browser (Optional):

Additional context
Add any other context about the problem here.

Perhaps related to #787; I didn't think returning an EventHandler was generally supported in 1.0.22-1.0.24.
Either way, the information provided in the issue is not enough to reproduce the problem.
I tried using this basic setup:
import pynecone as pc

class State(pc.State):
    async def a(self, name: str):
        print(f"a: {name}")
        return self.a(name)

app = pc.App(state=State)

@app.add_page
def index() -> pc.Component:
    return pc.box(pc.input(on_blur=State.a))

app.compile()

When I blur the input, I just get an exception:
a: foo
Task exception was never retrieved
future: <Task finished name='Task-36' coro=<AsyncServer._handle_event_internal() done, defined at /opt/homebrew/lib/python3.11/site-packages/socketio/asyncio_server.py:522> exception=ValidationError(model='EventHandler', errors=[{'loc': ('fn',), 'msg': '<coroutine object State.a at 0x110aec9e0> is not callable', 'type': 'type_error.callable', 'ctx': {'value': <coroutine object State.a at 0x110aec9e0>}}])>
Traceback (most recent call last):
  File "/opt/homebrew/lib/python3.11/site-packages/socketio/asyncio_server.py", line 524, in _handle_event_internal
    r = await server._trigger_event(data[0], namespace, sid, *data[1:])
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/socketio/asyncio_server.py", line 569, in _trigger_event
    return await self.namespace_handlers[namespace].trigger_event(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/socketio/asyncio_namespace.py", line 37, in trigger_event
    ret = await handler(*args)
          ^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/pynecone/app.py", line 606, in on_event
    updates = await process(self.app, event, sid, headers, client_ip)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/pynecone/app.py", line 458, in process
    updates = [await state.process(event)]
               ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/pynecone/state.py", line 578, in process
    return await self.process_event(
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/pynecone/state.py", line 614, in process_event
    events = fix_events(events, token)
             ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/pynecone/event.py", line 350, in fix_events
    e = EventHandler(fn=e)
        ^^^^^^^^^^^^^^^^^^
  File "pydantic/main.py", line 342, in pydantic.main.BaseModel.__init__
pydantic.error_wrappers.ValidationError: 1 validation error for EventHandler
fn
  <coroutine object State.a at 0x110aec9e0> is not callable (type=type_error.callable; value=<coroutine object State.a at 0x110aec9e0>)
/opt/homebrew/Cellar/python@3.11/3.11.2_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/base_events.py:1907: RuntimeWarning:

coroutine 'State.a' was never awaited

If I change a to a non-async EventHandler
Then it hits an infinite recursion and blows the stack
Traceback (most recent call last):
  File "/opt/homebrew/lib/python3.11/site-packages/pynecone/state.py", line 604, in process_event
    events = fn(**payload)
             ^^^^^^^^^^^^^
  File "/Users/masen/code/pynecone-io/repro-825/repro_825/repro_825.py", line 7, in a
    return self.a(name)
           ^^^^^^^^^^^^
  File "/Users/masen/code/pynecone-io/repro-825/repro_825/repro_825.py", line 7, in a
    return self.a(name)
           ^^^^^^^^^^^^
  File "/Users/masen/code/pynecone-io/repro-825/repro_825/repro_825.py", line 7, in a
    return self.a(name)
           ^^^^^^^^^^^^
  [Previous line repeated 972 more times]
  File "/Users/masen/code/pynecone-io/repro-825/repro_825/repro_825.py", line 6, in a
    print(f"a: {name}")
RecursionError: maximum recursion depth exceeded while calling a Python object


[WIP] Only use the first line of the description as a label (if at all)

What is this PR trying to achieve?
Make our labels be a bit less ridiculously long. New heuristic: only use the first line of the description (if any) for the new label, keep the rest in the description field.
Related: #694.
Who is this change for?
UX team, who want not-incredibly-long titles. API users who want better organisation of information.
Have the following been considered/are they needed?

[ ] Deployed new versions
[ ] Run terraform apply

Moving this back to WIP for now – I want to rethink how I do this, it’s going to get more complicated with #699.


Array::mutant may generate a lot of CRISPRs and large anomalous CRISPRs given the large chunk size.

Which is faster/better?

16-mer chunk size, rely on post-cache filtering
16-mer chunk size + per-char, rely on post-cache filtering
per-char, no reliance on post-cache filtering


Assign uppercase/constant libs when creating jruby instance

Without this, users must pass each library between methods and classes to use them
With this change, libraries are passed globally
I know you mentioned this didn't work before, it seems something has changed since then as
it works perfectly as expected for me
I left the lower case assignments around for backwards compatibility, but they should
probably be removed in the next major release of JSMacros-ruby

This was working, now it's not. Looking into it.


How to prevent delete @font-face definitions?

I write:
.pipe(uncss({
    [...]
    ignore: [
        /@font-face/
    ]
}))

but they still delete the @font-face definitions....

Hi,
This isn't the right forum for this question, as I stated on the readme;

If you have any difficulties with the output of this plugin, please use the UnCSS tracker.

This module is only a thin wrapper around UnCSS so any errors should be reported on their issue tracker.


TEST: Add a simple module loader, and test the FIPS module with it

This very simple module loader is only linked with the standard C
library, so cannot and should not provide any other symbol to the
module it tries to load.  It can thereby be used to verify that the
module it tries to load doesn't have any surprising dependencies when
it's supposed to be self contained.
A test recipe is added to verify the FIPS module with this loader.
Fixes #11020

fips.so depends on libc and libpthread locally:
$ readelf -d providers/fips.so

Dynamic section at offset 0x1aadb8 contains 28 entries:
  Tag        Type                         Name/Value
 0x0000000000000001 (NEEDED)             Shared library: [libpthread.so.0]
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.6]

Does the load fail if the application only depends on libc (and not on libpthread)?

A quick check indicates that the dlopen(3) succeeds with either LAZY or NOW specified.

A quick check indicates that the dlopen(3) succeeds with either LAZY or NOW specified.

Well yes, because fips.so currently doesn't have any unresolved libcrypto symbols.

Okay things are weird. moduleloadtest providers/fips.so OSSL_provider_init works but moduleloadtest providers/legacy.so OSSL_provider_init fails.
Both of these libraries have dependencies that aren't met by the executable (libpthread for fips.so and libcrypto for legacy.so).

Okay things are weird. moduleloadtest providers/fips.so OSSL_provider_init works but moduleloadtest providers/legacy.so OSSL_provider_init fails.

Not weird at all, you still need to have your LD_LIBRARY_PATH set right for ld.so to be able to load libcrypto.so.  In other words:
$ ./util/wrap.pl test/moduleloadtest providers/legacy.so OSSL_provider_init

Rebased for GH action fixups

Do you know that the failure case actually fails?  For exampel, add a call to CRYPTO_malloc(1) in one of the FIPS sources, build the library, and see if the test fails.

Looking at the comments of #11020, I ask what this PR actually tests.  That someone can load the FIPS provider and call the low-level API's directly?  Is that worth anything?

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Looking at the comments of #11020, I ask what this PR actually tests. That someone can load the FIPS provider and call the low-level API's directly? Is that worth anything?

The FIPS provider must be self-contained in terms of not calling outside the provider except for well defined callback APIs. Otherwise the FIPS module boundary would include libcrypto which is certainly undesirable. This PR should ensure that no libcrypto call is done.

Otherwise the FIPS module boundary would include libcrypto which is certainly undesirable

I believe we have talked about it in terms of "forbidden"

The check for OSSL_provider_init is icing on the cake rather than the central purpose of this PR

This PR should ensure that no libcrypto call is done.

Does this test do that?  Earlier comments say that dependent libraries are automatically loaded anyway. It seems to me that if you want ot make sure libcrypto isn't merged, look at the build.info file and put a comment there.

Merged
9800b1a0da90159a6bd6f5dbf8df6249ee967946 TEST: Break out the local dynamic loading code from shlibloadtest.c
527eb8d2949be19b1bc7b2fa84d0105091bb0928 TEST: Add a simple module loader, and test the FIPS module with it


Updating plex media server to <IP_ADDRESS>6-7eb2c8f6f

This PR will update Plex Media Server to the most recent version that was released <IP_ADDRESS>6-7eb2c8f6f

Confirmed working on my local install of kube-plex FWIW.

Thanks @zee-ahmed @billimek 😄


Fix formatting + rules

When formatting, always run some custom npm-groovy-lint fix rules not corresponding to CodeNarc violations
Updated fix rules:

IndentationClosingBraces
IndentationComments

New fix rules:

ClassEndsWithBlankLine

Codecov Report

Merging #20 into master will decrease coverage by 0.01%.
The diff coverage is 93.93%.

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
- Coverage   92.81%   92.79%   -0.02%
==========================================
  Files          43       44       +1
  Lines        1224     1249      +25
==========================================
+ Hits         1136     1159      +23
- Misses         88       90       +2

Impacted Files
Coverage Δ

src/groovy-lint.js
95.10% <71.42%> (-1.01%)
:arrow_down:

src/codenarc-factory.js
97.10% <100.00%> (+0.03%)
:arrow_up:

src/groovy-lint-fix.js
99.27% <100.00%> (+0.05%)
:arrow_up:

src/groovy-lint-rules.js
95.45% <100.00%> (+0.45%)
:arrow_up:

src/rules/ClassEndsWithBlankLine.js
100.00% <100.00%> (ø)

src/rules/IndentationClosingBraces.js
100.00% <100.00%> (ø)

src/rules/IndentationComments.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da605d2...34d6892. Read the comment docs.


Tune the extension tips appearance in status bar

The extension tips should appear whenever there are new extensions for a user to look at.

It is still not clear to me how this should work.
Currently it behaves this way:

The statusbar widget appears as soon as a new extension tip comes up
Once clicked, all extensions that are suggested will be remembered for 28 days. During that period, suggestions of those same extensions would not make the widget appear.
Only new suggestions for other extensions would trigger the appearance of the widget.
It has a global scope, irrelevant to workspace.

Now, I can take that 28-days-memento out, but still... what would happen to the widget when clicked? Would it go away? Why, and when would it come back?
@egamma @chrisdias

I think we should remove the 28days memento, but let's go through a scenario:

The user opens a JS file.

Code finds a list of extension suggestions for the user, e.g., vscode-eslint, vscode-jshint.

Code notifies the user that there are candidate extensions, by showing the extension tips notification in the statusbar

The user discovers the notification, clicks it, the list of extension appears in the quick box. The user reviews the extensions and installs eslint. Doesn't install jshint since he doesn't use jshint it would be nice if there was  a message above the quick box that explains that these are popular extension when editing files of this type.

Since the user has reviewed the extensions, the notification that there are interesting extensions goes away.

The user opens a PHP file

Code finds new suggestions for the user's working set.

The extension tips notification shows up again to inform the user that there are new extensions to review.

The user clicks on the notification and sees the PHP debugger in the list of suggestion

Is jshint still shown in the list at this point? I'd say no, since the user has removed it.

I don't like the idea of the notification in the status bar coming and going. I end up playing games trying to figure out how to make it come back again. What if i pressed Enter to install one of the four extensions listed (instead of clicking the download button) and now I want to install another one? If the status bar indicator is gone how do I get it back? I don't know that i can go to the command palette and choose "Extension Tips"... if I did I wouldn't need this status bar indicator at all!  Related, if we remove items from the list because I didn't install them the first time I saw them, how would I get them back?
Here is how I see the scenario:

I open a workspace with JavaScript, TypeScript, CSS, HTML, and C# files present

Assume there are 5 extensions recommended for this workspace (jshint, jscs, tslint, omnisharp, and can i use).  Also assume the suggestion icon is always in the status bar given my concerns about trying to figure out how to make it come up again.
The user clicks on the icon, gets a list of extensions they could install, and presses Enter on TSLint. The list goes away, the extension is installed, and I restart VSCode.
Now, I want to install jshint because i saw that in the list. I go back to the status bar indicator, click on it, and I see 4 items in the list now because I installed TSLint already.  I repeat the process, installing jshint and omnisharp.

A few days later I add a .php file to the workspace

Knowing that Code gave me extension suggestions before, I can click on the status bar and a list shows up that now includes a PHP extension.  I follow the same workflow as above and I install the PHP extension.
Ideally we would show a number/badge in the status bar indicating how many extensions are suggested. Maybe in a week a new extension list comes out and there are new opportunities. I could see the badge change to say "1" or "2" and I would click on it to see what's new.  If there are updated extensions I could imagine the update extension icon having a badge telling me how many are available. Same with errors.
CC @waderyan

Looks like the only disagreement is whether the extension tips notification comes and goes. Since we  have a setting to disable 'extension tips'  I'm fine with having it always in the status bar.
I would still like to have an info message in the quick box, that explains what this list is about.
The extension tips should be visually aligned with 'outdated' extensions and it should also be visually more compact than what the message is today (same as we do with errors).

Yes, removing the 28 day memento easily comes to the conclusion that that thing is always in your status bar and never goes away...
Will just do that for GA: if there are tips, just always show it. Not happy about it though. We definitely need extensions to be a core workbench concept, UI-wise.

:+1:

@seanmcbreen feel free to add more thoughts here.
Based on some early data from @seanmcbreen it seems like its worth keeping this in despite some of the user mental model confusion.
One suggestion (by @egamma and @seanmcbreen) is to add a small prompt for why these specific extensions are shown. Something like: "Here are extensions that could be useful based on the files in your workspace" (feel free to change that language).
Because of good initial data feedback from insiders it makes sense to keep this in for GA and I am in favor of always in the status bar.

Conclusion after discussion among @egamma, @joaomoreno, @waderyan, @chrisdias

remove the status bar contribution
keep the action but rename it to 'Recommended Extensions'
remove the setting
remove the time memento of 28 days
don't change the recommendation list unless the extension is installed

@egamma What about the quick open text. Currently it is ext tips . Should it be ext recommend ?

This will be worked on as part of a holistic improvement to the extension experience in product.


Duplicate spider

Hi,
I need to create multiple copies of a spider in the same project, please how can I achieve that? if I copy the spider I can't paste it anywhere while . just need to duplicate it and change a few parameters.
Thanks

I got the exact problem. I can't find a way to easily duplicate a spider in Portia.
The "Copy" button seems useless.
Thanks


Plugin not working on export

Godot 4.3
Steps to reproduce

Use the modplayer node in any scene
Try exporting your project
ModPlayer node doesnt work and throws:
SCRIPT ERROR: Cannot call method 'get_error' on a null value.         at: Mod.read_file (res://addons/modplayer/Mod.gd:119) SCRIPT ERROR: Invalid access to property or key 'data' on a base object of type 'Nil'.         at: ModPlayer._prepare_to_play (res://addons/modplayer/ModPlayer.gd:518)
This doesnt happen when you try playing from the editor

Sorry, i didnt see this repo was outdated

FYI for everyone:
Original repo on Bitbucket at https://bitbucket.org/arlez80/godot-mod-player/src/master/
Original author's site: https://arlez80.net/


Feature/refactor flutter code

Refactor the flutter code

Thanks! These look good! I especially liked how row separator was done in a much nicer way in your code, and it was good to learn there's an array spread operator. And just overall, the cleanups and refactorings make the code cleaner.


Evaluation of conditional diffusion models

Thank you for your amazing work!
I'd like to inquire if there are evaluation codes about conditional diffusion model in this repository (Sec. 5.5 and Sec. 5.6 in paper) ?

I am also interested in the implementation for LDM and SD.

We have released SecMI over LDM in https://github.com/jinhaoduan/SecMI-LDM.


[contents] add cadvisor helm chart

adding cadvisor helm-chart into contents/cAdvisor/helm-chart/
helm-chart from krakazyabra/cadvisor

Thanks @bart2001

Thanks @bart2001


Restructure site for multiple sets of documentation

This PR restructures content for the Antora site generator to support documentation for multiple aspects of devfiles. No additional content has been written at this time -- the file structure in place for the API and registry documentation is simply a placeholder.
For now, this PR assumes that we will have documentation for the devfile specification, a library/API, and devfile registry.
Note that we also still require a dedicated "start" page with general information and links to other areas of the documentation. This PR does not provide that.

I build this PR locally and it all looks good! See the screenshot to view how the new table of contents looks.

@elsony do you have a preference or opinion on the names of the new sections Kevin just made? That is, the following names:

Devfile specification
Devfile library and API
Devfile registry

See the attached screenshot for a visual

@slemeur tagging you as well. Please see my above comment.
Also, new commit, added placeholder content... reflects the most recent changes I've made.

Thanks @jc-berger for pinging me on that issue.
I think we need to extract from "Devfile Specification" section some of the end-user aspects.
This would be a proposal:
Getting Started

What are devfiles?
How devfiles works?
Quick Start Guide
Devfile samples
Tools using Devfiles

Using Devfiles

Using existing devfiles
Building a devfile for your project
Contributing a devfile to the community

Main Components

Devfile Registry
Devfile Library

** Devfile Specification**

...

Do we want that much placeholder content at this point in time?
The primary purpose of this PR, really, was to move the content "out" one more layer of abstraction so that it will be simpler to add more focused guides in the future as that content becomes available. Adding a new guide at this point essentially entails creating the directory structure and nav.adoc for it, then appending the nav.adoc into the nav key of the docs/antora.yml file. That's about as simple as we can get IMHO.
If we start building out the entire structure now, we'll have a documentation site that looks almost empty. It seems to me that it would be relatively simple to "add" guides as we write them, no? That would also allow us a bit more flexibility if we determine that we need to reevaluate that structure as more documentation is worked on.
Thinking about all of this, actually, I wonder if we might do better to remove the placeholder guides for the API/library and registry docs from this PR and simply focus on moving the content out one layer.
(As an aside, I'd also like to go ahead and get this merged in quickly so that @jc-berger can resume working on getting the spec docs in shape. :slightly_smiling_face:)
@slemeur @rkratky Let me know what you think and I'll update this PR accordingly. :slightly_smiling_face:

Looking at the suggested TOCs, I like Robert's example which blends them together. So taking our existing docs, it'd look something like what I included below. However, I do agree with Kevin that if we go this route now, we'll have a lot of placeholders, so essentially void docs, for our users. That's something we'll want to discuss as we determine what we're pushing now. Maybe placeholders or "empty" docs isn't a concern, but it's something worth brining up. Thanks!
Getting Started with Devfiles

What are devfiles?

How devfiles works?

Devfile properties

Quick Start Guide

Devfile samples

Tools using Devfiles

Using Devfiles

Using existing devfiles

Building a devfile for your project

Contributing a devfile to the community

Using Devfile Registry

...

...

Using Devfile Library

...

...

Authoring guide

...

Migration guide

...

Do we want that much placeholder content at this point in time?

@robin-owen, you misunderstand. I'm not suggesting we actually create all those subsections. I just want to make sure we design the structuring in a way that would allow us to do that in the future. For the time being (until we start adding the new content), we just want to keep the existing content. But it's important to put it in the "right" place, i.e. to name the subdirectory in a way that would play well with the expected future additions.

you misunderstand. I'm not suggesting we actually create all those subsections.

The original Jira issue that this PR addresses specifically mentions creating placeholder content for the proposed structure. :slightly_smiling_face:
It seems to me that we can create a tracking issue to cover the ToC and how we want to structure that (either on the API GitHub repository or as a docs team Jira issue). For the time being, all we have documented right now is the spec, and each variation of a ToC I've seen so far includes the spec as its own standalone set of documentation. As such, this PR does introduce the structure that we need in order to build content into the desired ToC over time.
I just don't want discussion on this PR to go off onto a tangent that isn't directly related to the changes being introduced here. I'll be removing the placeholder sections for the API and registry docs, as we don't actually have a confirmed location for either of those in the ToC just yet, and it looks like we could definitely use more discussion around how to organize the content.
Please do let me know if there are any other changes which I should introduce to this PR at this point in time or if we're good to merge the contents as-is. Thank you!

The original Jira issue that this PR addresses specifically mentions creating placeholder content for the proposed structure.

@robin-owen, right, apologies. By that, I only meant the component/guide directories, not the actual section pages etc. I.e. not the fleshing out of the TOC. My bad for the unclear formulation.

Please do let me know if there are any other changes which I should introduce to this PR at this point in time or if we're good to merge the contents as-is.

No, we're not. The directory structure introduced by this PR needs to reflect the top-level layout of the site. That's what's being discussed here. Merging the PR as it is doesn't help u in any way because we would need to change it again when this discussion is resolved. I understand your desire to merge it ASAP to get a move on, and I myself didn't realize the matter would require so much attention. Again, my bad. But Elson and Stevan have very good points that need to be taken into consideration.

Instead of dividing into using devfiles, using registry, using library, it will be nice if we present those under different persona instead of the technology area, e.g. application developer, architects (stack/sample providers), registry administrator, tools provider, etc., and then put the individual technology-specific info under each persona.

@elsony, tha's a great point, and you're absolutely right. We should've thought of that. The structure I suggested is heavily feature-based, which is not what we should be after. Basing it on personas allows us to steer it towards user story-based content, which has to be our goal.

In that case, I agree with what @elsony proposed as well.
My point is that before this PR, the documentation focused entirely on the spec as "top level" -- there was no way at all to introduce other guides without substantial work. The changes introduced here make the work trivial to add more guides to the ToC, which I thought was the goal.
If there's another step to be taken (building out the structure ahead-of-time), I don't mind doing that, but I'm not familiar enough with the docs set or what it requires in order to do that. @rkratky, just let me know what structure we'd like to see and I'm happy to implement it.

The changes introduced here make the work trivial to add more guides to the ToC, which I thought was the goal.

@robin-owen, correct, but we want to get the top-level dir structure right now -- if possible. And as the restructure will involve renaming the current home of the existing content, its name should be decided now, not later (though the other parts can wait, yes).

Per external discussion with @rkratky and @jc-berger, this PR will continue to focus on the original scope (moving the content "out" one layer, easing the creation of new guides as-needed).
I've created https://github.com/devfile/api/issues/441 (Proposal for new top-level documentation structure) based on the discussion on this PR. We can continue discussing the overall structure/reorganization there.
Thanks, all!

@robin-owen, before we merge as discussed, have you given a thought to redirects? I think we need to consider existing links and bookmarks.

In fact, now that I'm thinking about it... let's take a minute to discuss this more. I apologize for being such a scatterbrain, but it just occurred to me that it might, after all, be better to finalize the proposed new structure, and only then do this move.

Closing as we have now restructured the TOC.


Crashes when downloading age-resticted/explicit content where sign in is required from Youtube

Try "!play badass bitch lilith"

Doesn't crash for me.

I've been able to reproduce this.

@jaydenkieran try updating youtube-dl

@yanir3 My dependencies are set to update before every time I run the bot, using the latest ver.

This doesn't seem to be an issue as of recent versions of youtube-dl.


No such module 'CommonCrypto' in String+OAuthSwift.swift when installed through CocoaPods

Seems the CommonCrypto module.map is being ignored by CocoaPods.

In Build Settings under Swift Compiler - Search Paths
Add the path to OAuth/CommonCrypto directory i.e /Documents/OAuthSwift-master/OAuthSwift/CommonCrypto

Its better to add relative path like so :

${SRCROOT}/CommonCrypto

Agreed I deleted my comment by accident

Wondering if there's a better way to do that automatically using CocoaPods. For now, this works. Thanks!

Same problem here, tried to add in build settings either to app target or OAuthSwift Pod target but the error persists

+1 Having this problem too.

Hi @harlanhaskins @bizz84 @danieljacobarcher
I Removed CommonCrypto !!!!!
https://github.com/dongri/OAuthSwift/commit/5d6f60d749fe25312196c4aab7bd05973f666893
CommonCrypto setting no longer need of.
please see latest README if need...
latest version is 0.3.0

Thank you!

This is awesome! Thank you!


Behavior of blank custom DNS

It is apparently possible to set a VNet to "Custom DNS" without specifying any servers.
Does this behave the same as it would with default Azure DNS?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a7b1b215-0434-145b-cd11-95d0f32bc015
Version Independent ID: d328a868-a151-1985-2b62-f3884f7ad76c
Content: Name resolution for resources in Azure virtual networks
Content Source: articles/virtual-network/virtual-networks-name-resolution-for-vms-and-role-instances.md
Service: virtual-network
GitHub Login: @subsarma
Microsoft Alias: subsarma

@dcbrown16 I am unsure of the behavior in that case. I will test it and get back to you.


CPU implementation for Position-sensitive ROI Pool/Align

I'm working on the CPU fallback for Position-sensitive ROI Pool/Align layers as in PR #1259.
The current version can be found here: https://github.com/LukasBommes/vision/tree/ps_roi_align_cpu
The CPU version of PSROIPool works already fine. All tests in test/test_ops.py run smoothly, including newly added tests for the CPU version.
However, with the PSROIAlign I encounter the problem that always the CPU version is executed, regardless of whether input tensors are of type 'cuda' or 'cpu'.
If I run the test case below, I get the following output
Testing test_ps_roi_align_basic_cuda
before creating PSROIAlign Layer
after creating PSROIAlign Layer
x_is_cuda: True
rois_is_cuda: True
Tensor is CUDA in PSROIAlign_forward
Using CUDA version of PSROIAlign_forward
Executing CPU version of PSROIAlignForward
Segmentation fault (core dumped)

@unittest.skipIf(not torch.cuda.is_available(), "CUDA unavailable")
    def test_ps_roi_align_basic_cuda(self):
        print("Testing test_ps_roi_align_basic_cuda")
        device = torch.device('cuda')
        pool_size = 3
        x = torch.rand(1, 2 * (pool_size ** 2), 7, 7, dtype=self.dtype, device=device)
        rois = torch.tensor([[0, 0, 0, 5, 5]],  # format is (xyxy)
                            dtype=self.dtype, device=device)

        pool_h, pool_w = (pool_size, pool_size)
        print("before creating PSROIAlign Layer")
        ps_roi_align = ops.PSRoIAlign((pool_h, pool_w), spatial_scale=1, sampling_ratio=2)
        print("after creating PSROIAlign Layer")
        print("x_is_cuda: {}".format(x.is_cuda))
        print("rois_is_cuda: {}".format(rois.is_cuda))
        y = ps_roi_align(x, rois)
        print("after feedforward of data in PSROIAlign")

        gt_y = self.slow_ps_roi_align(x, rois, pool_h, pool_w, device,
                                      spatial_scale=1, sampling_ratio=2,
                                      dtype=self.dtype)
        assert torch.allclose(gt_y.cuda(), y), 'PSRoIAlign layer incorrect'

        y = ps_roi_align(x.permute(0, 1, 3, 2), rois)
        gt_y = self.slow_ps_roi_align(x.permute(0, 1, 3, 2), rois, pool_h, pool_w, device,
                                      spatial_scale=1, sampling_ratio=-1,
                                      dtype=self.dtype)
        assert torch.allclose(gt_y.cuda(), y), 'PSRoIAlign layer incorrect'

The selection of whether cuda or cpu version of PSROIAlign_Forward andPSROIAlign_Backward happens in csrc/PSROIAlign.h which I modified as shown in the snippet below.
As indicated by the console output, the function PSROIAlign_forward_cuda is selected in this header file. Weirdly, PSROIAlign_forward_cpu is executed instead, leading to the segfault, because the tensors are cuda, but access happens within the cpu implementation.
#pragma once

#include "cpu/vision_cpu.h"

#ifdef WITH_CUDA
#include "cuda/vision_cuda.h"
#endif

#include <iostream>

std::tuple<at::Tensor, at::Tensor> PSROIAlign_forward(
    const at::Tensor& input,
    const at::Tensor& rois,
    const float spatial_scale,
    const int pooled_height,
    const int pooled_width,
    const int sampling_ratio) {
  if (input.type().is_cuda()) {
  std::cout << "Tensor is CUDA in PSROIAlign_forward" << std::endl;
#ifdef WITH_CUDA
    std::cout << "Using CUDA version of PSROIAlign_forward" << std::endl;
    return PSROIAlign_forward_cuda(
        input,
        rois,
        spatial_scale,
        pooled_height,
        pooled_width,
        sampling_ratio);
#else
    AT_ERROR("Not compiled with GPU support");
#endif
  }
  std::cout << "Using CPU version of PSROIAlign_forward" << std::endl;
  return PSROIAlign_forward_cpu(
      input,
      rois,
      spatial_scale,
      pooled_height,
      pooled_width,
      sampling_ratio);
}

at::Tensor PSROIAlign_backward(
    const at::Tensor& grad,
    const at::Tensor& rois,
    const at::Tensor& mapping_channel,
    const float spatial_scale,
    const int pooled_height,
    const int pooled_width,
    const int sampling_ratio,
    const int batch_size,
    const int channels,
    const int height,
    const int width) {
  if (grad.type().is_cuda()) {
  std::cout << "Tensor is CUDA in PSROIAlign_backward" << std::endl;
#ifdef WITH_CUDA
    std::cout << "Using CUDA version of PSROIAlign_backward" << std::endl;
    return PSROIAlign_backward_cuda(
        grad,
        rois,
        mapping_channel,
        spatial_scale,
        pooled_height,
        pooled_width,
        sampling_ratio,
        batch_size,
        channels,
        height,
        width);
#else
    AT_ERROR("Not compiled with GPU support");
#endif
  }
  std::cout << "Using CPU version of PSROIAlign_backward" << std::endl;
  return PSROIAlign_backward_cpu(
      grad,
      rois,
      mapping_channel,
      spatial_scale,
      pooled_height,
      pooled_width,
      sampling_ratio,
      batch_size,
      channels,
      height,
      width);
}

The same scheme works fine for the PSROIPool layer which is why I am a bit confused.
Help is greatly appreciated so I can finalize the PR.

Hi,
First question: did you try cleaning (i.e., removing the build folder) and trying installing again? Maybe there is some artifact from a previous install?

Hey fmassa,
thanks for your reply!
I am building with pip install -v . in the 'vision' root directory inside a docker container. The code is mapped via docker volumes into the container and the changes to the code are visible inside the container immediately. I deleted all elements from previous builds. So, there are no files and directories such as build, torchvision.egg-info, *.so, versio.py.
I also tried python setup.py build develop before, but it didn't change anything. Though, I am not sure if the python module was loaded from the local shared library created by setup.py or the previous global install created via pip install -v ..
Anyway, I checked another 10 times for any typos and also replaced PSROIAlign_forward_cpu in PSROIAlign.h with PSROIAlign_forward_cuda. So, that in both cases the cuda version should be executed. But still, the cpu version is called.
I attached the console output of the entire build process.
build_output.txt

Here is my hint: change the name of PSROIAlignForward so that they differ for CPU and CUDA

Thanks for the tip. I'll try it out tomorrow and report if it worked.

@fmassa: That was indeed the solution. I changed the function names in csrc/cpu/PSROIPool_cpu.cpp and csrc/cuda/PSROIPool_cuda.cu and now it works. I'll finalize the code and create a new PR.

This has been implemented and merged in master thanks to @LukasBommes and @sampepose


[BUG] Incorrect processing of removing focus from input

Incorrect processing of removing focus from input on android devices. As the result, styles and meta tag "viewport" is still for focused input, but cupertino is closed. I have tried to make input blur before closing pane, but it is not working
Steps to reproduce the behavior:

Open cupertino with input inside
Focus on input
Press hand made close button
Meta tag

Some screens:

Expected behavior:
Removing all styles on blur

Device: Samsung Galaxy S22 Ultra
OS: Android 13
Browser: Chrome
Browser version: 114.0.5735.196
Cupertino version: 1.3.41

After looking at the source code, I can assume that the change of the "showKeyboard" variable is not working correctly on the mobile device

@Noothing  Thank you. Quick solution for you:
let settings = {
   // ...
   events: {
     onWillDismiss: (ev) => {
         document.documentElement.style.removeProperty('overflow');
         document.body.style.removeProperty('min-height');
         document.querySelector('meta[name=viewport]').setAttribute('content', 'viewport-fit=cover, width=device-width, initial-scale=1.0, minimum-scale=1.0, maximum-scale=1.0, user-scalable=no');
     }
   }
};


Missing icons (Devicon)

On the Devicon project page there are icons that are not here, you could update the list please.
For example missing:

Github
Babel
Gitlab
Vue
and more...

Apologies for missing this issue, looking into this now


Typo in path for python3 in AppVeyor testing.

Prb:  Typo in path for python3 in AppVeyor testing.
Sln:  Use the PYTHON3_DIR variable, instead of hardcoding the same thing in two different files.

I've reorganised the code a bit, moved the cmd script into the bat file, so its not split in half between the yml file and bat file.
Hopefully it will help prevent future mistakes like my last typo.


chore(main): release 1.1.1

:robot: I have created a release beep boop
1.1.1 (2023-04-18)
Bug Fixes

less line spread in title (8200413)

Miscellaneous Chores

remove src/CHANGELOG.md (8fd3a74)
保存知网查重报告 (#159) (eede45f)
保存维普查重结果 (#161) (833f58b)

Code Refactoring

拉取模板新参数 (b8657a4)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/CCXXXI/thesis/releases/tag/v1.1.1 :sunflower:


update_application ValueError with OpenIDConnect Application

I am retrieving an OpenIDConnect application, updating the application settings (adding a redirect URI), and then trying to update the application using update_application. When I try doing this, it ends up giving me this error: ValueError: too many values to unpack (expected 2)
Here is my function:
from asyncio import run
import logging
import requests
import xmltodict

from okta.client import Client as OktaClient
from okta.models import SamlApplication, TrustedOrigin

class OktaManager:

  def add_redirect_uri(self, app_id, redirect_uri):
          app = self.get_application(app_id)

          redirect_uris = app.settings.oauth_client.redirect_uris
          redirect_uris.append(redirect_uri)
          app.settings.oauth_client.redirect_uris = redirect_uris

          resp, err = run(self.client.update_application(app_id, app))

          return resp

I'm wondering if I am using this wrong or if the JSON returned by OpenIDConnect applications isn't formatted well.

@cptbldbrd Some of api methods return 3 params - (deserialized_response_body, okta_api_response, error) and some methods return 2 params if there is no response body - (okta_api_response, error). Method update_application returns 3 params, so you need to write:
resp, okta_resp, err = run(self.client.update_application(app_id, app))


自动检测然后分配足够的内存

华南理工在使用过程中提出的建议：
**现状：**提交作业时需要指定内存大小
**难点：**不同的代码跑起来不能完全确定内存的需求，希望OpenPAI可以有个自适应的管理方式，由OpenPAI自动检测然后分配足够的内存。

figure out the right amount of resource for each job and optimize the resource allocation among jobs is a multi-dimension bin packing problem (NP hard). We do not recommend to go along this direction.  Right now, the cluster divides all the resources into a fix amount of "slice", a job can choose the right amount of slices to fit its need. This is what most of the cluster scheduler does.


fixed setting secrets.credentialsSecretName doesn't do anything

Fix for #372

It seems that a fix for this is also being worked on in https://github.com/timescale/timescaledb-kubernetes/pull/359

It seems that a fix for this is also being worked on in #359

Do you want me to close the PR?

It seems that a fix for this is also being worked on in #359

That was a partial fix, there were some more issue that may break chart due to | quote he is using i addressed this in my recent commit.


Support for older PDB versions

Opening any VS6 made PDB currently throws
ERROR | Failed to load PDB file: pdb error: Unimplemented PDB feature: small MSF file format

Hi!
Yes, unfortunately older PDB files aren't supported by the pdb crate so resym can't open them. There a couple of old PDBs that I'd like to be able to browse myself.
I see two solutions to get these supported:

Implement support in the pdb crate

This might be a bit of work, I'm not sure

Implement an alternative PDB parsing backend based on the dia-rs crate in resym

This wouldn't be portable though (i.e., Windows-only)

Well it seems someone managed to add support for this without any major modifications: https://github.com/willglynn/pdb/issues/150#issuecomment-1923802296
I should try merging that on the pdb fork which is currently in use for resym.

@tomsons26 You should now be able to open VS6 PDBs from resym if you build from the master branch or use the web version: https://ergrelet.github.io/resym/


Removed manual contracts repo update

Changelog-entry: Removed manual contracts repo update
Signed-off-by: Alvaro Guzman<EMAIL_ADDRESS>

Can one of the admins verify this patch?

Hi, please squash this PR and only keep 1 commit in it, respectively the commit in which you change the submodules in .gitmodules to https

Hello Floion,
excuse me for the delay here, I was on vacation and just returned from them, I'll squash the commits and PR them.
Thanks

I did the PR in https://github.com/balena-os/balena-owa5x/pull/7


Run Zenodo integration tests with GitHub CI

Set up Github action for testing & data download from Zenodo via pooch + caching

@jluethi @m-albert
Test datasets are now on Zenodo and ready to be added as integration tests!
See links below.
SearchFirst (ome-zarr): https://zenodo.org/records/12795788
Tiled (ome-zarr, with sparse fields): https://zenodo.org/records/12795605
If we need to re-generate the zarrs or test on tifs, the raw tifs used for input are also now publicly available:
SearchFirst (tif): https://zenodo.org/records/12795729
Tiled (tif): https://zenodo.org/records/12794819

This is awesome @nrepina !


Remove exported getReport()

Details

Remove exported getReport.
Fixed Issues

$ https://github.com/Expensify/App/issues/40316
PROPOSAL: https://github.com/Expensify/App/issues/40316#issuecomment-2059982364
Tests

Test basic features of reports and report actions: New report, Order of reports in LHN, Send/Delete/Edit/Reply/Mark as unread message, Message context menu, Message notifications, Quick action, Hold IOU request,...
Some edge cases: https://github.com/Expensify/App/pull/38884, https://github.com/Expensify/App/pull/34320, https://github.com/Expensify/App/pull/28702/files#r1343844837

[x] Verify that no errors appear in the JS console

Offline tests

NA
QA Steps

Test basic features of reports and report actions: New report, Order of reports in LHN, Send/Delete/Edit/Reply/Mark as unread message, Message context menu, Message notifications, Quick action, Hold IOU request,...

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/153004152/9df6a593-9f6f-4d4e-8d24-2c0b2873bbfc

Android: mWeb Chrome

iOS: Native

https://github.com/Expensify/App/assets/153004152/19e9e4e8-f1ba-4f6d-8b37-4c00ae2a068a
https://github.com/Expensify/App/assets/153004152/01266a48-f562-4132-93ce-c1c1aa752e61

iOS: mWeb Safari

https://github.com/Expensify/App/assets/153004152/200982fc-3c24-4a63-93ff-6e3222ec8657

MacOS: Chrome / Safari

MacOS: Desktop

https://github.com/Expensify/App/assets/153004152/8015b3d7-7b43-4c72-a19a-3a4877b4627b

@gijoe0295 Any update on the use of onyxSubscribe?

@gijoe0295 Any updates on this?

@gijoe0295 What is the status of this PR? Can you please finish it up?

@gijoe0295 Any updates here?

@gijoe0295 What can I do to help get this moving along?


[Versioning] Pinocchio still says current release is 1.2.9

Macros
PINOCCHIO_MAJOR_VERSION
PINOCCHIO_MINOR_VERSION
PINOCCHIO_PATCH_VERSION

were not updated correctly since we switched to 1.3.0.
We are at 1.3.1 now, but Pinocchio still returns 1.2.9. checkVersionAtLeast(1,3,0) fails.
How should we handle this?
Is there a way to back-fix this problem in the previous two releases?
Should we correct to 1.3.1 immediately?
Should we leave it as it is and only correct in the next release, the one just before 2.0?

I have a fixe for this which is for the next release. This was due to the cmake module which was not able to handle it.
Unfortunately, there is no fix for the previous releases. I will just to make a patch for the current devel branch asap.

Ok, I also think we should wait for a new release to correct the problem, it does not make sense to change those values between two different releases, it would only make the problem worse.
So, I did not understand, for correcting the release number we wait, but should I fix the binding for printVersion()? In python, se3.printVersion('.') works, but printVersion() does not: it was returning garbage on my Macbook, and it's causing a segfault (in Python!) on ubuntu. The C++ version is fine, except that the value is wrong of course. It will be super quick.
One consideration out of this: should we keep a record of known (and hopefully fixed) bugs for each version? Maybe a changelog?

Looks cool. Thanks

Hate to raise this, but after the version macros were correctly updated to 1.3.2, now that we switched to 1.3.3 they still say 1.3.2...

Yes, you're right. I forgot to do it manually.
I think this is not dramatic for this release.
And in the future, this will be handled automatically thanks to https://github.com/jrl-umi3218/jrl-cmakemodules#162

Yes, it is not dramatic, it's just an additional patch. I just wrote it to let it be known.
Looking forward for the automated solution.

This issue has been solved by #569.


How to train NASNet with my own dataset?

hello @titu1994 , thanks for your nice work! I want to know if there any tutorials to guide me how to train NASNet with my own dataset. Looking forward to your reply ：）

https://blog.keras.io/building-powerful-image-classification-models-using-very-little-data.html
Replace VGG with NASNet.


Add ImpersonatedCredentials

Addresses https://github.com/googleapis/google-auth-library-java/issues/210
Allow for ImpersonatedCredentials in core auth library set.  Instructions to repro or to run system tests:
# Create source identity:
# gcloud iam service-accounts create source-serviceaccount --display-name="Source Identity"
# gcloud iam service-accounts keys  create svc-src.json<EMAIL_ADDRESS>

# Create target identity
# gcloud iam service-accounts create target-serviceaccount --display-name="Target Identity"

# Allow source to impersonate target
# gcloud iam service-accounts add-iam-policy-binding<EMAIL_ADDRESS><EMAIL_ADDRESS>--role='roles/iam.serviceAccountTokenCreator'

# Add resource ACL to target
# gcloud projects add-iam-policy-binding mineral-minutia-820<EMAIL_ADDRESS>--role='roles/storage.admin'

# Test the app below

# now create a GCE instance of the same source identity.
# comment out the service account section and uncomment the ComputeCredential section (as ADC)
# gcloud compute instances create impersonate-test<EMAIL_ADDRESS>--scopes=https://www.googleapis.com/auth/iam
# Upload the source below to GCE and rerun the test

output of unittests ran:
[INFO] Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.066 s - in com.google.auth.oauth2.ImpersonatedCredentialsTest
``

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@415f91b). Click here to learn what that means.
The diff coverage is 64.81%.

@@            Coverage Diff            @@
##             master     #211   +/-   ##
=========================================
  Coverage          ?   75.39%
  Complexity        ?      327
=========================================
  Files             ?       21
  Lines             ?     1463
  Branches          ?      163
=========================================
  Hits              ?     1103
  Misses            ?      276
  Partials          ?       84

Impacted Files
Coverage Δ
Complexity Δ

...om/google/auth/oauth2/ImpersonatedCredentials.java
64.81% <64.81%> (ø)
11 <11> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 415f91b...f2a326b. Read the comment docs.


Backport !93 to 0.3 - [merged]

In GitLab by @wtbarnes on Nov 15, 2020, 11:28
Merges cherry-pick-aebefe8e -> 0.3
Remove stub for temp response function
Closes #88
See merge request LMSAL_HUB/aia_hub/aiapy!93
(cherry picked from commit aebefe8ee1dfce08c4f4938d4a6f846f75018129)
02bbdf2e remove stub for temp response function

In GitLab by @codecov on Nov 15, 2020, 11:34
Codecov Report

Merging #95 (c49c9b5) into 0.3 (bd1feef) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              0.3      #95      +/-   ##
==========================================
- Coverage   97.20%   97.19%   -0.02%
==========================================
  Files          14       14
  Lines         430      428       -2
==========================================
- Hits          418      416       -2
  Misses         12       12

Impacted Files
Coverage Δ

aiapy/response/channel.py
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd1feef...c49c9b5. Read the comment docs.

In GitLab by @wtbarnes on Nov 15, 2020, 11:37
mentioned in commit 714d47ec51c7d564d1b9f1db7bc32840a4a7aca3

In GitLab by @wtbarnes on Nov 15, 2020, 11:31
enabled an automatic merge when the pipeline for c49c9b5d36fa2d4a3db1164457f504abeffc98f0 succeeds


Setting up the .html and config help

Hi, I am trying to understand how to setup this exactly,
The help to setup isnt easy for me to understand (Prolly just me), but I cant seem to understand how to add in multiple columns and link them to their correct placeholder/scoreboard objective.
And as for a webpage, I do not quite understand how to set it up correctly :/
Is there an example of any of these that can help me understand it all better?

Hi!
I think you're talking about the columns field in config.yml. That is just for the displayed columns on the web page. Tou don't need to use it, it is only for overriding the default alphabetical sorting. If you leave it commented out (default), it will display all columns you specified with objectives, database.config and placeholders.
Now, if you do want to order the columns differently, the columns are identified ("linked") by name, so for scoreboard objectives that will be their display name, and for placeholders that will be what you named them. So for example you could have:
columns: [Mine Diamond, Biome, Deaths]

objectives:
  - Deaths
  - Mine Diamond

placeholders:
  '%player_biome%': Biome

For the webpage, there is an example html file in web/example/index.html. You can see that in action here (I keep forgetting to link to that demo from the readme)
Hope this helps you, let me know if you can get it working!


list emails in a conversation view does not work

We're on the Early opt-in to 2019 release wave 2 and were looking forward to that this feature is also added to Unified Interface. Unfortunately it doesn't work after following the instructions on this page. I can select the box on personal settings, but al e-mail threads (I've checked replies and forwards) are still listed as seperate e-mails in UI, while they are listed as a thread in classic interface.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fa09a110-d91d-b551-3cc8-5c6885857e65
Version Independent ID: 3e787680-48f9-a3c6-73be-667be545e562
Content: Add an appointment, email, phone call, notes or task activity to the Timeline in a Model-driven app - PowerApps
Content Source: powerapps-docs/user/add-activities.md
Service: powerapps
GitHub Login: @mduelae
Microsoft Alias: mduelae

@timothybohte thank you for the feedback. This seems like a support issue. Please contact the support team for further assistance on this issue.
Thank you,
Mints


Notification handler err issue

Issue : console.error('Notification handler err', err)
Summary:
react-native-cli: 2.0.1
react-native: 0.40.0
react-native-fcm": "^6.1.0",
I'm testing on Android device 6.0.1
The app is running in Foreground
I can share the project if needed.

Bump, same issue here.

The issue seems to extend from line 33 in PushController.js
if (Platform.OS == 'ios')
where Platform is not defined I commented this out and it worked. I'll update this when I find out what to import for Platform to work.

I also tried both solutions, it but the problem still remains.

You're welcome I added a pull request to fix the issue for new users.

same issue here...

@nicolasdanelon it means your notification callback throws an error


Youtube video resets or instantly ends upon clicking on progress bar or timestamp

What title says. Interestingly, devtools in Youtube complain that the maximum call stack size is exceeded. I can't provide a log rn because I don't want to suffer through the hell again.

I can't replicate the maximum call stack size message anymore, but the issue in the title remains. I confirmed that extensions don't affect the issue and it only appears in Thorium AVX2 for Windows on the 16th release M109 from Releases.

I can replicate the issue the most consistently on this video: https://www.youtube.com/watch?v=RDKWxMD5yDA

Having the same issue!
Happens consistently on this video https://www.youtube.com/watch?v=CpDYaYESJIc

@lemon07r @Skalt711 Should be fixed with the latest release.


Fix  example

Following #31, I imported <HamburgerIcon /> wrongly on its example 👍🏻

:tada: This PR is included in version 1.1.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: