Optimize text area

https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components?node-id=7779%3A34916&t=zTAKJLbklgpXEsSf-1

UX Tasks

[ ] 3 Lines default
[ ] validation state

[x] 3 lines
[x] validation state

ready for second review @gfellerph https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components?node-id=7779%3A34916&t=zTAKJLbklgpXEsSf-1

what's the difference between focus and active? is it the same?

Active: user is pressing something with their finger, mouse or else.
Focus: The cursor is inside the field. In this state, the fields value can be edited.
Added for completeness


Smarter Word Wrap for Markdown Syntax

Word wrap works fine but could be enhanced to account for front matter in lists: Example:
- now is the time
for all good ...

Prefer
- now is the time
  for all good ...

Perhaps an additional API? Something like InheritWordWrapWithFrontMatter?  The API could take a list of front matter items maybe.

I was wondering if there was a way I could plugin to the word-wrapping and modify it. Can I supply my own word-wrapper?

AvalonEdit will have to provide some callback so that user code can compute the word wrap indentation. (see TextView.BuildVisualLine for the existing word wrap indentation logic)


Timestamp for this request was 1000ms ahead of the server's time

caseless:
Caseless {
dict:
{ 'content-type': 'application/json;charset=utf-8',
'transfer-encoding': 'chunked',
connection: 'close',
date: 'Sat, 27 Apr 2019 16:04:19 GMT',
server: 'nginx',
'x-mbx-used-weight': '5',
'strict-transport-security': 'max-age=31536000; includeSubdomains',
'x-frame-options': 'SAMEORIGIN',
'x-xss-protection': '1; mode=block',
'x-content-type-options': 'nosniff',
'content-security-policy': "default-src 'self'",
'x-content-security-policy': "default-src 'self'",
'x-webkit-csp': "default-src 'self'",
'cache-control': 'no-cache, no-store, must-revalidate',
pragma: 'no-cache',
expires: '0',
'x-cache': 'Error from cloudfront',
via:
'1.1 b3229c68bc96ea68371695efdc615317.cloudfront.net (CloudFront)',
'x-amz-cf-id': '6ZN6xzHzS2z0CqYUSoLeymcLKSwx3pEd3xRfZSbcorGHjvTK8daGJg==' } },
body:
{"code":-1021,"msg":"Timestamp for this request was 1000ms ahead of the server's time."} }

This is a check put in place from Binance to ensure that an api request doesn't lag too bad. Sync your system clock and it should go away.
If it doesn't, there is an additional option that can be used to sync each request with the api server.

-"Sync your system clock and it should go away."
That was the issue .. Thanks so much for your quick reply!
Have a nice time :)

Sure thing!

Im having the same problem, my clock is synced.
@bmino What is the other otption you mention to sync each request?

My suggestion is to add this fourth config option as a binance argument in the file src/main/Main.js
binance.options({
    APIKEY: CONFIG.KEYS.API,
    APISECRET: CONFIG.KEYS.SECRET,
    test: !CONFIG.TRADING.ENABLED,
    useServerTime: true
});

Even if this fixes the issue, will you please post the error if you can still replicate it? And for reference your operating system as well

Im using Windows 10, the problem is was that my the auto-sync with Internet time was off.
After enabling it and forcing sync the problem solved.


modem: uart: use ring_buf_{claim,finish} API and improve behavior with HW flow control

This API allows to drop use of preallocated isr_buf. Most importantly as
a result RAM usage is reduced for each driver utilizing modem_context
framework. Additionally there is less copying done in ISR context, as
data is direcly read from UART FIFO to ring_buf.
So far all received bytes over UART where blindly drained and pushed to
ring_buf. This approach is okay for UART devices without configured HW
flow control, as it basically decouples data processing from ISR handler
and gives more time before data overrun. However when HW flow control
is enabled, such behavior somehow suppresses UART flow control
advantage, because data can overrun when pushing to ring_buf.
Allow drivers utilizing modem_context framework to pass information
about whether HW flow control is enabled or not. If it is enabled, then
read data from UART FIFO to the point when RX ring_buf is totally filled
and follow such situation by disabling RX interrupt. Incoming data will
be paused on HW level, so there is lots of time for RX thread to process
ring_buf content. Reenable RX interrupts after all data in ring_buf is
processed, so that number of context switches is kept at minimum level.

I was testing nrf52840 based board with esp WiFi driver. The issue that I was encountering without this change was that data was pushed to RX ring_buf until it was full, then dropping rest of the data. This was observable pretty easily with downloading big files over HTTP, where ESP chip was pushing data with unsolicited responses (+IPD), each containing 2920 bytes of payload. nrf52 serial driver is pretty limited when used with UART FIFO API, as each time we just fetch single byte from UART peripheral (in case of nRF chip it is from RAM memory more specifically, because that one byte is transfered using DMA). This means that lot of time is spent in ISR and there is only little time for user threads to process data already contained in ring_buf.
After this change I tested the same setup with and without HW flow control. Without HW flow control behavior was the same as previously. With HW flow control transmission from ESP chip is successfully paused, so that we have lot of time to process data from ring_buf in user threads. I've tested that both with default 115200 and with 1Mbit UART baudrates. With 1Mbit baudrate I was able to reach 75 kB/s download speed over HTTP. This gives 600kbps, which is 60% of the "theoretical" bandwidth. I think that is a great result.
Note (for ESP chip): ESP was not respecting HW flow control by default, when that was configured either with NVS partition or requested over AT commands. After configuring HW flow control on both CTS and RTS using Kconfig (so somehow hardcoded in ESP AT firmware) it started to respect that Zephyr MCU was "busy" and pausing transmission. This seems to be a bug in ESP AT.

What sort of testing has this been put through? @jukkar were you able to test?

I have not tested this. If the changes look good and reasonable, and come from a trustworthy submitter, I am trusting that they have done the testing properly. If there are reports later that this PR causing problems, we can always revert the changes.


Windows Package Manager 1.3 manifest schema

Description of the new feature / enhancement
This is a parent issue to track outstanding schema requests for the 1.3 schema.
Inclusion in this list is not a commitment. Other schema items may be added or removed.

Note: We will be targeting the 1.4 schema with the 1.4 client.

#2252

Support for:

#140

https://github.com/microsoft/winget-cli/issues/2446
https://github.com/microsoft/winget-cli/issues/2446


Is custom implementation of an ERC20 contract needed?

https://github.com/RubiconDeFi/rubi-py/blob/990c8be9e36ff7076dfc176ef874e0cbb9a7db6a/rubi/rubi/contracts/helper/erc20.py#L6

[ ] investigate if there is a python lib we can depend on rather

links to: https://github.com/RubiconDeFi/rubi-py/issues/3


swarmig bot plist file is failing on intel mac running os12

launchctl loading the org.swarm.bot.plist is resulting in return code 78, which is function not defined. recent changes to inte/m1 conditionals might have changed the resulting values in the plist.

for M1 mac as well:
https://turquoise-internal-review.googlesource.com/c/infra/salt/+/444397

https://turquoise-internal-review.googlesource.com/c/infra/salt/+/444611


Same host in multiple Ingress resources

What is the correct behavior for Ingress controllers for the case when the same host is defined in multiple Ingress resources incuding resources from different namespaces?
Thx

OpenShift routes use 'first created'
But that has proven to be very difficult to maintain. A true reservation system with some sort of claims would likely have been a better idea...

in multiple Ingress resources incuding resources from different namespaces?

If the user do not specify a namespace nginx ingress from (contrib) use 'first created'. In case of collisions an event is emitted.

A true reservation system with some sort of claims would likely have been a better idea...

This issue propose exactly that https://github.com/kubernetes/kubernetes/issues/30151

Closing. Please reopen if you have more questions.


TrayIcon Dispose exception after Toggle

Repro:

Click
Click

I haven't been able to reproduce this. Could you share the full stack trace as well?

This does not always appear. Sometimes this happens if you then click on the tray icon.

I can confirm this as well.  To reproduce it you have to do a fresh start of the solution.  If you have run debug on the solution and closed the app at least one time this error will not happen.
Start the solution.
Start debug.
Click "Toggle Tray Icon". (Icon shows in tray)
Click "Toggle Tray Icon". (Error show above occurs)

I've decided to deprecate and ultimately remove the trayicon APIs as they are still lacking lots of features to be truly functional, and have various lifecycle issues. I'm just not happy with where they are at, but might bring the back in the future.


Fix if whitespace triming

Description & motivation
This change fixes an issue with the create table using syntax when no column is specified.
Before

create table schema.tablenusing net.snowflake.spark.snowflake

After

 create table schema.table using net.snowflake.spark.snowflake

Checklist

[x] I have verified that these changes work locally

https://github.com/dbt-labs/dbt-external-tables/pull/92


Firefox --class argument

https://github.com/amirkarimi/browser-hub/blob/575ff40c736cf80dd98f4d2932538d53a89ec5fb/README.md?plain=1#L142
In the open_cmd in the example Firefox config, you've got a --class argument, which I can't find documented anywhere in the Firefox cli options.
Can you point me in the direction of what it does?

I guess I found it in some forums but here is some reference from Arch wiki: https://wiki.archlinux.org/title/firefox#Window_manager_rules


Plugin framework 1.2

Description
Upgrades the plugin framework version
Related Issues
Fixes https://github.com/elastic/terraform-provider-ec/issues/607
How Has This Been Tested?

Unit tests, acceptance tests
Types of Changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactoring (improves code quality but has no user-facing effect)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation

Readiness Checklist

[x] My code follows the code style of this project
[x] My change requires a change to the documentation
[x] I have updated the documentation accordingly
[x] I have added tests to cover my changes
[x] All new and existing tests passed

@tobio , thanks a lot for the PR.
Does it make sense to drop CLI 1.3.9 requirement in scope of this PR?

I was still seeing the same issue running 1.4 in testing IIRC. I'll take another look.

@tobio , so we cannot yet drop 1.3.9 requirement, right?
It looks like the PR misses changelog :)


Check PID gains are in tune with new PID

What has to be done
Some changes were made on the PID to make it more resilient to jitter and make the actual math more precise when jitter is added to the call period.
How do you know it has to be done
From controls (limited) experience (took two aeronautical controls classes at ERAU 10 years ago...): The PID gains' tuning is sensitive to sample time, and the changes brought by https://github.com/RespiraWorks/VentilatorSoftware/pull/221 change the effective sample time of the PID.
Code pointers
check previous tunings: https://github.com/RespiraWorks/VentilatorSoftware/pull/233
This requires having a physical hardware with test lung to perform closed loop tuning, or full closed loop model (which we don't have yet...)

Verified it works fine; I can't distinguish between before and after this patch.


Disappearing unread counter

I confirm (by marking "x" in the [ ] below: [x]):

[x] This is not a troubleshooting question. Troubleshooting questions go here: http://www.mattermost.org/troubleshoot/.
[x] This doesn't reproduce on web browsers (such as in Chrome). If it does, issue reports go to the Mattermost Server repository.
[x] I have read contributing guidelines.

Summary
When I unlock my macOS, then unread messages marker disappearing, even if focus is not on Mattermost application.
Environment

Operating System: macOS Catalina 10.15.7 (19H15)
Mattermost Desktop App version: 4.6.0
Mattermost Server version: 5.25.5

Steps to reproduce

Run Mattermost client
Be active on some chat
Switch active application to anything else, let Mattermost with this chat will be in the background
Lock computer by pressing control-command-q
wait for any incoming message in active chat
unlock computer
just after computer is unlocked, unread messages counter disappears

Expected behavior
Unread counter will be in place until I switch to Mattermost client again.
Observed behavior
I recorded screen when it happens
Mattermost unread marker error.mov.zip
Possible fixes

do you switch the app from the background to the foreground? this might cause the current channel to be marked as read.

No. I don't. A you can see on screencast, focus is on iTerm all the time.

ah! I missed the screencast, sorry about that and thanks for providing it as it makes everything more clear.
I've tested 4.5.4 and doesn't show this behaviour so it is clearly a regression. I've created a ticket to work on it feel free to add any details there.


MSID: 92915 Version: 2 DOI: 10.1101/2<IP_ADDRESS>1953

MSID: 92915
Version: 2
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>1953
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=92915
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>1953

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/92915v2
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>1953
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/92915/v2/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

error: [journal-ref-article-title] This journal reference (id c4) has no article-title element.
warn: [journal-ref-text-content] This journal reference (id c4) has untagged textual content - ). De novo gain-of-function KCNT1 channel mutations cause malignant migrating partial seizures of infancy. . Is it tagged correctly?
warn: [journal-ref-text-content] This journal reference (id c7) has untagged textual content - , G. (. Is it tagged correctly?
warn: [journal-ref-text-content] This journal reference (id c44) has untagged textual content - , F. (. Is it tagged correctly?
error: [journal-ref-article-title] This journal reference (id c55) has no article-title element.
warn: [journal-ref-text-content] This journal reference (id c55) has untagged textual content - ). Characterization of two de novoKCNT1 mutations in children with malignant migrating partial seizures in infancy. . Is it tagged correctly?
warn: [journal-ref-text-content] This journal reference (id c78) has untagged textual content - , Y. (. Is it tagged correctly?
warn: [table-wrap-label-fig] Label for table ('Figure 1- Supplemental Table.') starts with text that suggests its a figure. Should this content be captured as a figure instead of a table?
warn: [table-wrap-label-fig] Label for table ('Figure 4- Supplemental Table.') starts with text that suggests its a figure. Should this content be captured as a figure instead of a table?
warn: [table-wrap-label-fig] Label for table ('Figure 6- Supplemental Table.') starts with text that suggests its a figure. Should this content be captured as a figure instead of a table?


RSA key generation security improvements

Description
This PR makes several security enhancements to RSA key generation. The enhancements also make mbedTLS's RSA implementation compliant with FIPS 186-4. It's not clear to me if it's a goal for mbedTLS to be compliant, but considering all the self-tests are clearly implemented according to FIPS, I'm assuming it is. Some of the improvements are useful outside of FIPS 186-4, though.
The enhancements don't touch primality testing, which is the most time-consuming part of RSA key generation. Therefore, I expect the performance impact to be minimal.
The changes are:

Avoid small private exponents during RSA key generation
Generate primes according to FIPS 186-4
Generate RSA keys according to FIPS 186-4

See the individual commit messages for detailed information on each change.
This contribution is submitted under CLA with Fortanix, Inc.
Status
READY
Requires Backporting
NO
Migrations
NO
Todos

[ ] Tests
[ ] Documentation
[ ] Changelog updated
[ ] Backported

--none--

Hi @jethrogb Thank you for your contribution!
Mbed TLS as a TLS library is mostly compliant to IETF standards, however NIST compliance is something that we would consider integrating

Good to hear. You might be interested to hear that based on our analysis so far, these changes are the only changes needed to the entire codebase to make all algorithms except for FFDH compliant with FIPS specification. FFDH would require significant changes to make compliant.

@jethrogb Thanks for your contribution! I've reviewed it and approved the general design and functionality, but requested a few minor changes.
We would highly appreciate if you could rework your PR to address review comments from myself and @hanno-arm  (except the two occurrences where I explicitly stated that after discussing them with together, we agree that no change was required after all). However, if you don't have the time to do it soon, we might opt to do the necessary rework ourselves as an exception to normal PR flow, in order to speed up its merging - please let us know, and thank again for your contribution!

@jethrogb Thanks for making those changes. To clarify, you want us to review and merge https://github.com/jethrogb/mbedtls/tree/mbedtls-pr-1380-orig, right? Can you please update this pull request accordingly? It's difficult for us to review something that isn't a PR.

No, this branch is the right one. You can compare against the linked tag if you want to see the exact changes I made.

The CI failures seem unrelated to my changes, is that right?

The CI failures are in tests that generate RSA keys, and the failures are present in commit 0d2056320342e26bfa412bd9c4bf56909d2f38ec but not in its parent. So I'm afraid it's on you. A simple make && make check fails.

retest

@gilles-peskine-arm I can't reproduce any test failure with the current head of this PR, cec7323e1a14 - can you check if you're getting a failure there too?

retest

Note: last CI run failed only in know-flaky timing self-test (https://github.com/ARMmbed/mbedtls/issues/1517) so not a blocker for merging. (Also, previous CI run passed, was only re-triggered to test a previous issue with github reporting of the test status.)

I'm sorry, I don't know how we managed to miss that, but this PR is missing a ChangeLog entry. @jethrogb  can you please add a ChangeLog entry along the following lines (I don't want to imply that we're compliant with FIPS 186-4 while we haven't been audited, accept non-approved values for the key size and public exponent, etc.)?
* Changes
Improve security of RSA key generation by including criteria from FIPS 186-4. Contributed by <preferred way to write you name and/or affiliation>. #1380

or just let us know how you'd like to be credited and we'll add the ChangeLog entry for you.

Rebased & done

retest

A note for future PRs though: once a PR has been reviewed (especially once it have been approved), please avoid rebasing it unless there is a pressing reason, as it makes it harder to us to validate that the review history is still valid.

This is a direct result of your process where 1) it takes months to get a PR reviewed and 2) you ask contributors to change the ChangeLog file as part of the pull request. Since every branch touches the ChangeLog file, it's very likely that there will be a merge conflict by the time the PR is ready (as there was is in this case). I think a more common approach to avoid exactly this issue is to generate the ChangeLog once per release based on the PRs that were merged since last release.

@jethrogb We don't mind conflicts in the ChangeLog file. We have a script that resolves the typical case and we don't mind occasionally resolving them manually. We should make this clearer in our documentation. We prefer to keep changelog entries together with the corresponding code change since they belong together when reviewing the history or porting specific patches to another branch (that mostly applies to bug fixes).
As for the time it takes for us to review PRs, we're working on improving that. Sorry for the delay.

We don't mind conflicts in the ChangeLog file.

Ah ok, I was not aware of that. It would be good to mention that when requesting adding ChangeLog entries. Most projects will not even consider merging PRs with active merge conflicts.


using caching tasks on private build server without tar

Hi,
When creating the archive for the cache, a tar command is executed.
cshell.exec(tar -xzf ${tarballPath} -C "${destinationFolder}");
This works fine on hosted 2017 agents but not on our private win2016 core agents.
Looking over the list of tools installed on a hosted vs2017 image I cannot find tar among them.
Can you point me in the right direction of which set of tools should be installed on our build servers
to get the task to work?
Kind regards,
Hans ter Wal

bsdtar is what gets installed onto Windows by default now. You can get releases of this here.
If this unblocks you, I'd love to see this added this to the documentation!

Hi Ethan,
I downloaded, compiled and added the bsdtar as tar.exe to the path of the server and restarted the vsts agent. Unfortunately i'm still getting an "
'tar' is not recognized as an internal or external command".
Is there a special setup required to use it with cshell.exe?

There isn't a cshell.exe. The typescript is referencing shell from shelljs. Can you verify that where tar from a command prompt returns the path to the tar.exe you compiled?

That looks like a permissions error to me. Can you share the folder permissions for c:\vsts-agent?

CREATOR OWNER
SYSTEM
Administrators
Users
No agent service to the root c:\vsts-agent.
Now I changed two things
1-  added VSTS_AgentService_XXXXX to have full control on the c:\VSTS-agent folder
2- I changed our win2016 server to win2019  (to have default tar experience out of the box)
Now I'm getting:
tar -C "/C/VSTS-agent/agent1/_work/1/s" -czfv "/C/VSTS-agent/agent1/_work/1/s/tmp_cache/win32-8a285725f109f9d1d20adc55d799136b707eef062ef5abf7713b031bc53425b8.tar.gz" "Src/Fh.Lhd.Rct/node_modules"
"Src/Fh.Lhd.Rct/node_modules"
/C/VSTS-agent/agent1/_work/1/s/tmp_cache/win32-8a285725f109f9d1d20adc55d799136b707eef062ef5abf7713b031bc53425b8.tar.gz
Issue creating tarball:
tar: /C/VSTS-agent/agent1/_work/1/s/tmp_cache/win32-8a285725f109f9d1d20adc55d799136b707eef062ef5abf7713b031bc53425b8.tar.gz: Couldn't find file: No such file or directory
tar: could not chdir to '/C/VSTS-agent/agent1/_work/1/s'

Can you email me the build logs? etdenn at microsoft dot com
Also, just to confirm, the win2019 build agent is your own machine (not hosted)?

Well I finally got it working using the azure images pipeline scripts.
https://github.com/microsoft/azure-pipelines-image-generation/blob/master/images/win/scripts/Installers/Install-7zip.ps1
and
https://github.com/microsoft/azure-pipelines-image-generation/blob/master/images/win/scripts/Installers/Install-Git.ps1
The last one adds the tar.exe to the path using the following line
Add-MachinePathItem "C:\Program Files\Git\usr\bin"


Add environment env variable

Type

[ ] Bug fix
[x] New feature
[ ] Improvement to existing feature

Related JIRA Issue(s)
https://www.ebi.ac.uk/panda/jira/browse/ENSWBSITES-125
Importance
Need to be merged with dev for the June-alpha release
Description

Added the key ENVIRONMENT to .env
Created a shared helper file under src/shared/helpers/environment
Enabling custom download launchbar link only when the ENVIRONMENT is 'development' or 'internal'

Other effects

[x] I have checked any requirements for Google Analytics
[x] I have created any required tests

Several things I wanted to comment on:
1. Conceptually
We aren't planning to have many different environments, I hope. So I would rather make the environment helper have a number of methods/functions that answer the question which environment we are currently in:

export const isDevelopment = () => {
  return config.isDevelopment;
}

export const isProductionDeployment = () => {
  return config.environment === Environment.PRODUCTION;
}

export const isInternalDeployment = () => {
  return config.environment === Environment.PRODUCTION;
}

then, in the launchBar:
import environment from ...
// (or could be shortened to env)

...

      enabled={environment.isDevelopment || environment.isInternalDeployment}

2. Comments on the current code
(these will be entirely unnecessary if we change the code in accordance with the previous section)
a) naming
getEnvironmentAvailability -> isEnvironment
b) wordiness
  if (environment.indexOf(config.environment as Environment) !== -1) {
    return true;
  }

  return false;

better:
return environment.includes(config.environment)

even better:
instead of overloading the getEnvironmentAvailability function, so that it accepts either a string or an array of strings, it's easier if it accepts only one type of arguments (in this case, array of strings).

getEnvironmentAvailability -> isEnvironment

Done

return environment.includes(config.environment)

Done

instead of overloading the getEnvironmentAvailability function, so that it accepts either a string or an array of strings, it's easier if it accepts only one type of arguments (in this case, array of strings).

Updated it to only accept array of strings

Didn't like section 1 then? Ok 😞 Although it looks easier to write
import {isDevelopment, isInternalDeployment} from ...

if(isDevelopment() || isInternalDeployment()){...}

than:
import {isEnvironment, Environment} from ...

if(isEnvironment([Environment.DEVELOPMENT, Environment.INTERNAL])){...}

I liked both but I didn't see any big difference so I just left it as it is.


Redesign for iOS 15

Hi, it seems like system synced widget theme does not work on iOS 14.7.1  - tried on iPhone 12 ProMax + iPhone 8 Plus -

hi @postprivee thanks for report
I will look into it


How to create a simple Yes or No dialog

The documentation is very verbose but I can't find any working example of how to create a Yes or No dialog.
I can set the button's text:

new MaterialDialog.Builder(this)
        .title(R.string.title)
        .content(R.string.content)
        .positiveText(R.string.agree)
        .negativeText(R.string.disagree)
        .show();

But this does nothing with the selection.
I could set a callback:

new MaterialDialog.Builder(this)
    .onPositive(new MaterialDialog.SingleButtonCallback() {
        @Override
        public void onClick(@NonNull MaterialDialog dialog, @NonNull DialogAction which) {
            // TODO
        }
    });

This does not work anymore as of version 0.8.1. as it couldn't find onPositive and SingleButtonCallback.

Error:(191, 39) error: cannot find symbol class SingleButtonCallback

Later in the documentation, only lists and checkboxes are used in the dialogs.
So, how could I create a simple dialog with callbacks?

The README mentions that will be introduced with version 0.8.2.
There's a method called callback() before that version.


Fixed issue 681 and included PR 687

Implemented fix for issue #681 and included fix from PR #687

[X] Change details added to Unreleased section of changelog.md?
[X] Added/updated documentation and descriptions in .schema.mof files where appropriate?
[X] Examples updated for both the single server and small farm templates in the examples folder?
[X] New/changed code adheres to Style Guidelines?
[X] Unit and Integration tests created/updated where possible?

This change is

Codecov Report

Merging #697 into dev will increase coverage by <1%.
The diff coverage is 97%.

@@          Coverage Diff           @@
##             dev    #697    +/-   ##
======================================
+ Coverage     90%     91%   +<1%
======================================
  Files        105     105
  Lines      10069   10080    +11
  Branches       1       1
======================================
+ Hits        9158    9193    +35
+ Misses       910     886    -24
  Partials       1       1

Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


PR Suggestions

Hey @bellemare ,
To address your questions/concerns in https://github.com/apache/kafka/pull/5527, I found it easier to just check it out and hack on it a bit.
Here's a compilation of the changes I'd suggest. Some of them are clearly quite bold, so please don't take offense. Everything in here is meant to be taken with a grain of salt.
At a high level:

The copartitioning problem you mentioned is solved. The error was that previously, all topics were copartitioned together, but we actually need two separate copartition groups... the subscription requests need to be copartitioned with the foreign table, and the subscription responses need to be copartitioned with the primary table. But no other combination of topics need to be copartitioned.
There was some flaws in the "graph node" construction because the graph interface itself is extremely confusing and in some cases the generic parameters are actually incorrect. It's something we're fixing in KIP-478. Sorry you had to suffer. In general, you shouldn't have to define new node types for every purpose, and I'm actually not sure if we should be using OptimizableRepartitionNode. I just flattened the graph construction to address both these problems; hopefully it's easier to grok now.
After reflecting at much greater length on the store/prefix concern, I think the best thing to do is just make the key type Bytes and define a schema object for the processors to use when interacting with the store. This means we don't need the CombinedKeySerde or the idea of a PrefixStore (or any of the implementations of it).

I'll "review" this PR with more detailed comments inline for your consideration.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Hi John
Wow! This looks excellent!  Thank you so much for your detailed work here, this is great. There is the old saying about missing the forest for the trees, and I think this was me in a nutshell. The Bytes type with the logic loaded to the Serde makes a lot of sense. I am very happy to see the prefixScan interface location deftly solved by completely removing it. As for the remainder, a few questions:

The copartitioning problem you mentioned is solved.  The error was that previously, all topics were copartitioned together...
Solved as in there was a fix that you submitted to the Kafka Steams copartitioning code? I had been testing with two separate copartitioned groups as you described, and that was still getting that exception.

There was some flaws in the "graph node" construction ...
I found it very difficult to grok when I was working on it. What you have now makes it much clearer.

After reflecting at much greater length on the store/prefix concern...
Agreed. This is far neater and solves our problem. Have you verified that the range testing works as expected? I have just taken a quick look so far but will resume tomorrow.

Hey Adam,
I'm glad you're pleased! Sorry it took me so long. I feel like it's really hard to see the forest after you spend so much time building it, tree by tree... It's a lot easier for another person to come in and see things differently with a fresh perspective.
Regarding copartitioning:
Yes, I believe it is fixed in this branch. I verified it not just by running your test, but also by inspecting the copartition groups that get generated. I think the solution may be composed of multiple parts:

two separate copartition groups
the "hack" I called out in my self-review to fix tracking internal topics
the change I made to compute the transitive closure of copartition groups
setting the "sources" on the result KTable as the whole copartition group of the primary-side sources plus the subscription response topic

I think some of those are overlapping, but I guess it doesn't hurt to do them all.
Regarding graph construction:
I think you're the first person to try implementing a new operation after we added the AST graph, and there are naturally some sharp edges in stuff we didn't happen to use when we did the implementation. It was compounded by the fact that the logic of your feature is so complex. I think we can make some tweaks to the AST code to make this easier in the future, in addition to the tweaks I already proposed here, but we should wait until KIP-478 is implemented. Sorry you had to deal with it!
Regarding the prefix search:
I didn't verify it, beyond running the existing tests... I didn't want to write a bunch of tests in case you didn't like the idea. We clearly need some extra verification on it.
Thanks again for the awesome KIP and PR. Please let me know how I can help further.


Does not work with React.lazy imports

Describe the bug
Components imported with React.lazy are not shown in the tree
To Reproduce
const Page1 = lazy(() => import('./pages/page1'));
import Page2 from './pages/page2';

export default function Routes() {
  return (
      <Switch>
        <Suspense fallback={

}>
          <Route exact path='/' component={Page1} />
          <Route exact path='/profile' component={Page2} />
        </Suspense>
      </Switch>
  );
}

only Page2 is shown in the component tree
Expected behavior
I expect Page1 to be shown as well
Desktop (please complete the following information):

OS: OSX 11.5.2

Hi benjick!
Sapling v1.2.0 has been released and we have altered the parser to handle React.lazy() style imports. Please check it out and if you still have issues open another Issue here. You might have to restart VS Code to ensure you have the latest version.


feat: allow function in noExternal

Description
noExternal only supports array of string, or Regex, but this is not enough to more dynamic things like skipping noBuiltin node dependencies. In addition the underlining api from rollup allows to define the external configuration as a function
Additional context
Allow things like:
{
  noExternal: everythingButNodeBuiltins
}

What is the purpose of this pull request?

[ ] Bug fix
[x] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the PR Title Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

/ecosystem-ci run vitest

I think this is a good extension.
As @sheremet-va commented, it would break Vitest:
Error: packages/vite-node build: src/server.ts(57,34): error TS2345: Argument of type 'string | RegExp | ((id: string) => boolean)' is not assignable to parameter of type 'string | RegExp'.

But we had merged similar features broke Vitest before in minors. I'll run full ecosystem ci to see if there are other failures (Astro and Iles are expected to fail)

/ecosystem-ci run


Create bounds for FineTune hyperparameters

Task: M-5725704280

We're only allowing the users to utilize working hyperparameters. Apart from the ones that are set by default in Flyte, we have here the fixed hyperparameters.


python310Packages.pyenvisalink: 4.2 -> 4.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.pyenvisalink is: "Python interface for Envisalink 2DS/3 Alarm API"
meta.homepage for python310Packages.pyenvisalink is: "https://github.com/Cinntax/pyenvisalink"
meta.changelog for python310Packages.pyenvisalink is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 4.3 with grep in /nix/store/s18br42i0dd0mbpnbnxbv46hh0f464cb-python3.10-pyenvisalink-4.3

found 4.3 in filename of file in /nix/store/s18br42i0dd0mbpnbnxbv46hh0f464cb-python3.10-pyenvisalink-4.3

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
2 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
python310Packages.pyenvisalink
python39Packages.pyenvisalink

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/s18br42i0dd0mbpnbnxbv46hh0f464cb-python3.10-pyenvisalink-4.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.pyenvisalink https://github.com/r-ryantm/nixpkgs/archive/edf6c78c94bd6dccf5bb78c7f1f02d79b42fb5fa.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/s18br42i0dd0mbpnbnxbv46hh0f464cb-python3.10-pyenvisalink-4.3
ls -la /nix/store/s18br42i0dd0mbpnbnxbv46hh0f464cb-python3.10-pyenvisalink-4.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

python310Packages.pyenvisalink
python39Packages.pyenvisalink

Maintainer pings
cc @fabaff for testing.

Result of nixpkgs-review pr 155806 run on x86_64-linux 1

2 packages built:

python310Packages.pyenvisalink
python39Packages.pyenvisalink


Fix: Failed to get detail policy for application

Signed-off-by: wuzhongjian<EMAIL_ADDRESS>Description of your changes
handle failure to get policy.

Fixes #5040
I have:

[x] Read and followed KubeVela's contribution process.
[ ] Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
[x] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

great work,let's add some test cases

@wonderflow done, please review


[SUGGEST] [BUG] Using pages server with the owner root domain

Hello!
I'm having an issue where I'm not able to use my owner name with my pages domain as my URL for my repo. The server only interacts with my site if the repo name is not a subdomain name (with the pages domain). I want it to look like this:
owner.example.com = index.html OR ./.
owner.example.com = /reponame

I tried to add this into my code with the source code I pulled, but nothing is changing for me. My suggestion is to add a ability to use the pages subdomain with the owner as a name to allow my index.html to be accessed with that name (in root form).
owner.example.com ---> index.html

Can you add this to the program as a feature?

Sorry, there was a problem with the previous version, it's fixed now!

This issue has been inactive for a long time and has been automatically closed. If you have any questions, please reopen it.


Support PostCSS

Is your feature request related to a problem? Please describe.
Now, jest-preview is currently supporting TailwindCSS (https://github.com/nvh95/jest-preview/issues/100). It does use postcss but only for tailwindcss
https://github.com/nvh95/jest-preview/blob/b0b598d2fac6d491070bc17820ea46ad128918c9/src/transform.ts#L251-L261
By supporting PostCSS natively, it can solve a number of issues

[x] #230
[ ] Possible #235 (need reproduction from issue author)
[x] Most importantly, a project with PostCSS a can run seamlessly with jest-preview

Describe the solution you'd like
Current logic

If a file has TailwindCSS syntax => process it with PostCSS (with tailwindcss plugins).

Desured logic

Detect if a project uses PostCSS => process with PostCSS and corresponding configuration.

Describe how should jest-preview implements this feature

To detect if a project uses PostCSS, we can use postcss-load-config

Note that postcss-load-config does not run in browser context: https://github.com/nvh95/jest-preview/pull/127#discussion_r884084360
postcss-load-config default run in async mode. However, it has to run in SYNC mode (in Jest Code Transformation), we have 2 options:

(Prefered) Use .sync: postcssrc.sync (https://github.com/postcss/postcss-load-config/issues/194#issuecomment-656192080)
Spawn a node process to make an async task becomes SYNC: https://twitter.com/kentcdodds/status/1043194634338324480

Process CSS file with above config

The pseudocode will look like this:
// src/transform.ts
export function processCss(src: string, filename: string) {
  // Pre-process file with Sass/ Less/ Stylus
  ...
  // Check if project use PostCSS
  const { plugins, options } = postcssrc.sync(ctx)
  const { css } = postcss(plugins).process(src, options)
  injectToHead(css)

  // Else, likely raw CSS, just inject to head directly
  injectToHead(src)
}

Describe alternatives you've considered
None
Additional context
Will provide if there any in the future

Implemented in #241


error opening file with -- scheme -- file local comment

I have a file containing the file local -*- scheme -*- in the first line of the file.  Interestingly enough the elisp manual is a little weird about this kind of file local variable, as opposed to doing -*- mode: scheme; foo: bar; ... -*-.  In any case, opening such a file results in:
Debugger entered--Lisp error: (wrong-type-argument listp scheme-mode)
  hack-local-variables-filter(scheme-mode nil)
  hack-local-variables()
  geiser-impl--guess(t)
  geiser-impl--set-buffer-implementation(nil t)
  geiser-mode(1)
  turn-on-geiser-mode()
  geiser-mode--maybe-activate()
  run-hooks(change-major-mode-after-body-hook prog-mode-hook scheme-mode-hook)
  apply(run-hooks (change-major-mode-after-body-hook prog-mode-hook scheme-mode-hook))
  run-mode-hooks(scheme-mode-hook)
  scheme-mode()
  set-auto-mode-0(scheme-mode nil)
  set-auto-mode()
  normal-mode(t)
  after-find-file(nil t)
  find-file-noselect-1(#<buffer menurc> "~/.gimp-2.8/menurc" nil nil "~/.gimp-2.8/menurc" (4326451 2055))
  find-file-noselect("~/.gimp-2.8/menurc" nil nil t)
  find-file("~/.gimp-2.8/menurc" t)
  funcall-interactively(find-file "~/.gimp-2.8/menurc" t)
  call-interactively(find-file nil nil)
  command-execute(find-file)

That's odd -- it works for me. I used my copy of ~/.gimp.2.8/menurc and it loads fine.
In your menurc what's the value of (hack-local-variables-filter nil)? It should be nil.
You can also try to call edebug-defun on hack-local-variables and see what part of the function is adding scheme-mode to its local result.

Here, (hack-local-variables-prop-line nil) => scheme-mode.
Stepping through, I find myself here
                  (and (setq result (hack-local-variables-prop-line
=>                                   handle-mode))
;; Result: scheme-mode

Perhaps I've gummed something up somewhere--will look more closely

Any success? Just to make sure, your first line in menurc is ; gimp GtkAccelMap rc-file         -*- scheme -*-, right?
Could you use edebug-defun on hack-local-variables-prop-line to see where it returns scheme-mode? I'm not sure how it could with a nil argument, though.

Correct, that is the first line. Pasting it again:
; gimp GtkAccelMap rc-file         -*- scheme -*-

Here, which, well, now looking at it makes sense:
	      ((looking-at "[ \t]*\\([^ \t\n\r:;]+\\)\\([ \t]*-\\*-\\)")
	       ;; Simple form: "-*- MODENAME -*-".
	       (if (memq handle-mode '(nil t))
=>		   (intern (concat (match-string 1) "-mode"))))

and so it returns the symbol scheme-mode.
Perhaps this isn't a geiser issue, but an Emacs one. There are some changes in the log of files.el that touched hack-local-variables and friends.  I follow emacs master, and perhaps this is the culprit
http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=4a80c8bb276d

Ah, I figured I should have asked for your Emacs version. Alright, it makes sense now.
As a temporary fix, you can add the argument 'no-mode to the hack-local-variables call in geiser-impl--guess.
I'd say this is an Emacs bug. When the argument to hack-local-variables is nil, then a spec of the form -*- function -*- will make hack-local-variables-prop-line return function-mode which makes hack-local-variables error.
For example, create a buffer with this line:
# gimp-2.8 GtkAccelMap rc-file         -*- org -*-

then do M-: (hack-local-variables). It will error.
Could you submit a bug report upstream?

I agree. Bug#25008 filed. Closing, thanks.


MCO-838: machineconfiguration/v1alpha1: add PinnedImageSet

This PR adds PinnedImageSet types to the  machineconfiguration.openshift.io group and a CRD

continuation of #1609, #1713

ref:

MCO-838

/test all

/test all

/test all

ClusterVersion On Update Should be able to add the marketplace capability with a ClusterVersion with base capability None, with the OperatorLifecycleManager capability

Integration failed an OLM test but PinnedImages passed. retesting
/test integration

integration failed from global timeout again PinnedImageSet tests passed.

/test integration

Niiice

/label acknowledge-critical-fixes-only
This change does not directly contribute to the payload


Feature Request: Add Support for StateRAMP/FedRAMP Inventory format

Since ARI already exports to Excel it would be nice if it exported into the StateRAMP and FedRAMP inventory workbook formats with the required columns.
You can get a copy of the StateRAMP inventory format from here: https://stateramp.org/blog/document/stateramp-inventory-workbook-template/
And the FedRAMP Inventory template from here: https://www.fedramp.gov/documents-templates/

Hi @tc-mgriff ,
To be honest I never heard of those. But that's a cool feature to add.
I will analyze it deeper to see how can we do it.
Thanks for that

Please don't close bot! I mentioned this to our StateRAMP PMO and I'm trying to get them to consider this as a format for Continuous Monitoring for StateRAMP. (StateRAMP requires a monthly Asset inventory to be provided to your 3PAO (3rd party assessor)
It would be nice if ARI would extract right into the NIST inventory format that StateRAMP and FEDRamp use, then there wouldn't need to be any ambiguity on the current format being allowed. (It's a huge pain to manually maintain a separate inventory spreadsheet outside of Azure. yes, in 2023 cloud infrastructure is still needing to follow on premise processes that don't really take that into context and the need for an inventory 😉

@Claudio-Merola can you reopen this? Did you get a chance to look into it?


Ah facade refactor

Description
Refactored a ton of code. Got rid of poros, switched hotel to places, wrote code to catch some edge cases (continual result population), implemented pagination and categories, rewrote graphql with some conditional things to catch DB weirdness.
Fixes # (issue)
n/a, was a refactor
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Basic facade tests to make sure data is retrieved and processed in correct format.

Needs sad path testing

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] Coverage is the same or higher than it was before my changes.

To-Dos

[ ] sad path testing, this api is very fallible so gotta make solutions w that in mind
[ ] Set up image api

Hey all! Just implemented some of the suggested changes to clean it up. I also added the edge case testing


Udpate Waypoint: Understanding Case Sensitivity in Variables

Tested locally. Changes made via COM1000.
Previously, users could pass all tests without changing case in declarations.

Added tests to check if both declaration and assignment sections have been camelCased.

The Man = You.

@0x0936 thanks for this PR. COM1000 won't have any saving issues :stuck_out_tongue_winking_eye:


KeyError: 'dataset'](url)

i run the demo app.py on local ,and i upload a image,then 'run' it,the console get a error message as following:
[ERROR:    Exception in ASGI application
Traceback (most recent call last):
  File "D:\Python310\lib\site-packages\uvicorn\protocols\http\h11_impl.py", line 428, in run_asgi
    result = await app(  # type: ignore[func-returns-value]
  File "D:\Python310\lib\site-packages\uvicorn\middleware\proxy_headers.py", line 78, in __call__
    return await self.app(scope, receive, send)
  File "D:\Python310\lib\site-packages\fastapi\applications.py", line 270, in __call__
    await super().__call__(scope, receive, send)
  File "D:\Python310\lib\site-packages\starlette\applications.py", line 124, in __call__
    await self.middleware_stack(scope, receive, send)
  File "D:\Python310\lib\site-packages\starlette\middleware\errors.py", line 184, in __call__
    raise exc
  File "D:\Python310\lib\site-packages\starlette\middleware\errors.py", line 162, in __call__
    await self.app(scope, receive, _send)
  File "D:\Python310\lib\site-packages\starlette\middleware\cors.py", line 84, in __call__
    await self.app(scope, receive, send)
  File "D:\Python310\lib\site-packages\starlette\middleware\exceptions.py", line 79, in __call__
    raise exc
  File "D:\Python310\lib\site-packages\starlette\middleware\exceptions.py", line 68, in __call__
    await self.app(scope, receive, sender)
  File "D:\Python310\lib\site-packages\fastapi\middleware\asyncexitstack.py", line 21, in __call__
    raise e
  File "D:\Python310\lib\site-packages\fastapi\middleware\asyncexitstack.py", line 18, in __call__
    await self.app(scope, receive, send)
  File "D:\Python310\lib\site-packages\starlette\routing.py", line 706, in __call__
    await route.handle(scope, receive, send)
  File "D:\Python310\lib\site-packages\starlette\routing.py", line 276, in handle
    await self.app(scope, receive, send)
  File "D:\Python310\lib\site-packages\starlette\routing.py", line 66, in app
    response = await func(request)
  File "D:\Python310\lib\site-packages\fastapi\routing.py", line 235, in app
    raw_response = await run_endpoint_function(
  File "D:\Python310\lib\site-packages\fastapi\routing.py", line 163, in run_endpoint_function
    return await run_in_threadpool(dependant.call, **values)
  File "D:\Python310\lib\site-packages\starlette\concurrency.py", line 41, in run_in_threadpool
    return await anyio.to_thread.run_sync(func, *args)
  File "D:\Python310\lib\site-packages\anyio\to_thread.py", line 31, in run_sync
    return await get_asynclib().run_sync_in_worker_thread(
  File "D:\Python310\lib\site-packages\anyio\_backends\_asyncio.py", line 937, in run_sync_in_worker_thread
    return await future
  File "D:\Python310\lib\site-packages\anyio\_backends\_asyncio.py", line 867, in run
    result = context.run(func, *args)
  File "D:\Python310\lib\site-packages\gradio\routes.py", line 289, in api_info
    return gradio.blocks.get_api_info(config, serialize)  # type: ignore
  File "D:\Python310\lib\site-packages\gradio\blocks.py", line 518, in get_api_info
    serializer = serializing.COMPONENT_MAPPING[type]()
KeyError: 'dataset'](url)

somebody can help me?thanks

to solve it:(https://zhuanlan.zhihu.com/p/654417983)


config(tidb): enable require code owner reviews

Proposal
https://internals.tidb.io/t/topic/374/15?u=mini256
Related PR
https://github.com/pingcap/tidb/pull/28249
How it works
Notice: When this PR is merged, the robot will automatically synchronize the configuration to the branch protection configuration of the GitHub repository.

We enable the CODEOWNERS to implement our config review mechanism by turning on the require_code_owner_reviews option.
But GitHub will require us to enable the required_approving_review_count option at the same time, and the minimum value of this option is 1.
It will require our PR to pass through at least one reviewer with write permission before it can be merged. However, our team reviewer only has read permission in the repository settings.
Notice: After enabling this option, if the PR does not get the approval of at least one committer or maintainer (whose role with write permission) before the committer comments /merge, the committer needs to perform an additional approve operation, or GitHub will prompt this.

/hold

@qw4990 @bb7133 @XuHuaiyu @cfzjywxk @morgo @tisonkun
Please also take a look at this PR, it will turn on the required_approving_review_count option at the same time if this is acceptable.
Referenced document: https://github.com/kubernetes/test-infra/tree/master/prow/cmd/branchprotector

LGTM

LGTM

/merge

/merge

/unhold


StreamOrder missing in ST 436 tracks in MXF

I have an XML output from an MXF and QuickTime version of the same media file with a EIA 708 CDP stream with cc1, cc3, service 1 and service 2.  The QuickTime version has the StreamOrder enumerated for the text streams (they are all in the same QuickTime c708 track) but it is missing on the text track in the MXF version.
QuickTime:
      <track type="Text" typeorder="4">
      <Count>301</Count>
      <StreamCount>4</StreamCount>
      <StreamKind>Text</StreamKind>
      <StreamKind_String>Text</StreamKind_String>
      <StreamKindID>3</StreamKindID>
      <StreamKindPos>4</StreamKindPos>
      <StreamOrder>8</StreamOrder>

MXF:
    <track type="Text" typeorder="4">
      <Count>301</Count>
      <StreamCount>4</StreamCount>
      <StreamKind>Text</StreamKind>
      <StreamKind_String>Text</StreamKind_String>
      <StreamKindID>3</StreamKindID>
      <StreamKindPos>4</StreamKindPos>

Is StreamOrder anything but a zero-based media file track order?  I.e. is it the same as ignoring e.g. timecode tracks and enumerating all the tracks in order in the file starting from zero?  I see a few other tickets e.g. #201  and #186 but I wasn't completely clear on the derivation of this value or if there's a specific reason the MXF doesn't have it.
em06_prores_final_cut_pro.xml.txt
em06_evs_2_7_4.mxf.xml.txt

It seems like the ID field uses the MXF Track ID in the source package - if the descriptor happened to be in a different order it would not match the track order?
Looking at the QuickTime example, since all the ancillary streams are in a QuickTime c708 track, they all have the same StreamOrder.  I would think all the ancillary streams in an MXF file would also have the same stream order number since they are in the same track.  I think it would be helpful to have this exposed for consistency between the formats.

Also curious on the definition of StreamKindID vs StreamKindPos.  For the MXF and QuickTime files I looked at, it seems that StreamKindID = typeorder - 1 and StreamKindPos = typeorder, but not sure if these values are getting pulled from somewhere.
    <track type="Text" typeorder="4">
      <Count>301</Count>
      <StreamCount>4</StreamCount>
      <StreamKind>Text</StreamKind>
      <StreamKind_String>Text</StreamKind_String>
      <StreamKindID>3</StreamKindID>
      <StreamKindPos>4</StreamKindPos>

Also curious on the definition of StreamKindID vs StreamKindPos. For the MXF and QuickTime files I looked at, it seems that StreamKindID = typeorder - 1 and StreamKindPos = typeorder, but not sure if these values are getting pulled from somewhere.

It is that, it was requested to be not starting from 0 and it does not have so much sense actually, mistake from the past and now it stays forever. At some point I'll do a big clean up of field and remove actually non relevant fields.


Provision drops to 1

Thank you for this excellent project!
I have only one big issue when i use this package:

Do you have any idea how I can get around this issue?
Thanks!

Hi Felix,
Thanks for trying it out.  The rapid drop is actually done on purpose because AWS only allows 4 decrements per calendar day but as many increments as you like, so given that it's normally much better to drop right down and pick up again if needed.
From your chart it looks like its adjusting the provisioned capacity exactly right in response to the consumed capacity.
However, if you did really want to change the behaviour then you simply need to adjust you logic in https://github.com/channl/dynamodb-lambda-autoscale/blob/master/src/Config.js in the decrement. calculateValue functions.
Hope that explains it?


HELP: How can I find the old name of a file/directory when it is renamed?

Two events are emitted whenever a rename occurs, one :moved_from event and one :moved_to event. Each of these events will have Event#related refer to the other.


[Go Live][Apr 22, 2022]

Docs Build status updates of commit 8a5f5a4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/deploy-and-publish/appsource/prepare/in-app-purchase-flow.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Make logs exposure optional

Exposing logs is useful for debugging, but is a security issue in production. Address concerns from this refinery PR: https://github.com/refinery-platform/refinery-platform/pull/2855

Fixed by #156


Add Bagisto to repositories.

ℹ Repository information

Here is the list of all issues at Bagisto and here's the list of all good first issues.

The repository has:

[x] At least three issues with the good first issue label.
[x] At least 10 contributors.
[x] Detailed setup instructions for the project.
[x] CONTRIBUTING.md
[x] Actively maintained.

Hey @papnoisanjeev  ! I tried to contribute to this repo as well but I haven't seen any activity in the last few months. I decided to fork it to keep it alive. Please see https://github.com/lucavallin/gfi and feel free to open a pull request there. At this time I am setting up the hosting and cleaning up the code. If you're up for it, I could use some help to convert the app from Nuxt.js & Python to Next.js & Typescript.


pd team:user:list only shows the first 25 users of the team instead of all

for some reason "pd team:user:list: command only shows the first 25 users of the team instead of all users of that team

Hi, thanks for reporting this! It looks like this is a bug with the endpoint, it is not filling in the total element for proper pagination. I've raised this with our product team and hope to have a resolution or a workaround soon. Thanks...

Hi again, I have just pushed a version that has a workaround for this problem. It will just send requests in series rather than in parallel if the total element is missing. When the endpoint gets fixed, the command will just get slightly faster :)
Please update to version 0.0.69 and let me know if this is resolved for you. Thanks!

Yes, it's working now with version 0.0.69. Thanks

Great! I will close this issue now. Thanks again for reporting it.


package options

@rultor release, tag is 0.0.2

@rultor release, tag is 0.0.2

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.0.2

@yegor256 Oops, I failed. You can see the full log here (spent 1min)
[1/1, ??:??/??:??] update: iexec [294k] (61551 -> 64697) ... done
running mktexlsr ...
done running mktexlsr.
running mtxrun --generate ...
done running mtxrun --generate.
tlmgr: package log updated: /usr/local/texlive/2022/texmf-var/web2c/tlmgr.log
tlmgr: command log updated: /usr/local/texlive/2022/texmf-var/web2c/tlmgr-commands.log
+ l3build tag 0.0.2
Tagging  build.lua
Tagging  docshots.dtx
+ l3build ctan
Running l3build with target "check" for module .
This is pdfTeX, Version 3.141592653-2.6-1.40.24 (TeX Live 2022) (preloaded format=pdftex)
 restricted \write18 enabled.
entering extended mode
(./docshots.ins (/usr/local/texlive/2022/texmf-dist/tex/latex/base/docstrip.tex
Utility: `docstrip' v2.6a <2020-11-23>
English documentation    <2020-11-23>

**********************************************************
* This program converts documented macro-files into fast *
* loadable files by stripping off (nearly) all comments! *
**********************************************************

********************************************************
* No Configuration file found, using default settings. *
********************************************************

)

Generating file(s) docshots.sty

Processing file docshots.dtx (package) -> docshots.sty
Lines  processed: 363
Comments removed: 188
Comments  passed: 0
Codelines passed: 151

To finish the installation you have to move the ".sty"
file into a directory searched by TeX. To produce the
documentation run the file ".dtx" through LaTeX. If any
questions, submit a new GitHub issue.
 )
No pages of output.
Transcript written on docshots.log.
Running checks on
  simple (1/1)
          --> failed

  Check failed with difference files
  - ./build/test/simple.pdftex.diff

====================
Tests failed, zip stage skipped!
====================

container 69f8e6c4c4fdb08f6448afcc9ea6377d88158a438d5c36a71fca90d5944c68eb is dead
Sat 15 Oct 2022 05:47:26 PM CEST

@rultor release, tag is 0.0.2

@rultor release, tag is 0.0.2

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.0.2

@yegor256 Done! FYI, the full log is here (took me 2min)


Use swap on class than on its all properties

swap of network/layer if using std::swap should not list everything separately
but rather just directly swap
Adding any new property, it is highly likely that it wont be added to this swap creating bugs for later.

:octocat: cibot: Thank you for posting issue #462. The person in charge will reply soon.


Openning big edxm designer file crash VS 2017

From VS Feedback:
Hello,
When Visual Studio 2017 open à very big (for me 116 829 lines) Designer.cs of a EDMX. After somes secondes, VS freeze and close.

This is a project for reproduce : CrashEf.zip
The way is :

open the projet in visual studio (I use VS Pro 15.8.2)
open the file "Model1.Designer.cs" (yes it's horrible)
Wait some secondes (10 for me)
VS Freeze and crash

@Ordanche The solution, designer, and cs file all open for me in a few seconds. You might want to try repairing or re-installing VS.

EF Team Triage: Closing this issue as the requested additional details have not been provided and we have been unable to reproduce it.
BTW this is a canned response and may have info or details that do not directly apply to this particular issue. While we'd like to spend the time to uniquely address every incoming issue, we get a lot traffic on the EF projects and that is not practical. To ensure we maximize the time we have to work on fixing bugs, implementing new features, etc. we use canned responses for common triage decisions.


Add result-state module

Q: Should we also provide an extension Flow<T>.onEachState(...)?
A: I don't think so, as it could lead to puzzles like this:
resultFlow { repository.fetchData() } // Flow<Result<T>>
    .foldEach(
        onSuccess = ::handleResult,
        onFailure = ::handleError,
    ) // Flow<R>, often Flow<Unit>
    .onEachState { resultState ->
        // Will never be printed as the failure was already handled earlier
        if (resultState.isFailure) println("Error")
    }

@osipxd aproove


Fix code scanning alert - Module is imported with 'import' and 'import from'

Tracking issue for:

[ ] https://github.com/plasma-umass/slipcover/security/code-scanning/78

Fixed in d3ebdecaa783de6d9bb5dfc1ff20f332cb0d0932.


Use Salt to manage increased maxfiles on OS X

These settings are necessary to handle running the WPT (web platform
tests); taken out of the wiki to reduce the need for manual
interventions.
Note, /etc/launchd.conf is not included because OS X no longer uses
this file and it has no effect. Whether a replacement for this
functionality is required is TBD.
Also, note that this hasn't been tested since there is no OS X Vagrant box.
cc @larsbergstrom since you added the maxfiles section to the wiki

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

@bors-servo r+
Thanks a ton for automating this! I've been doing it by hand, but this will really help. We're looking to add a bunch more OSX builders, and I probably would have forgotten this otherwise :-)

:pushpin: Commit 51fba64 has been approved by larsbergstrom

:hourglass: Testing commit 51fba64 with merge 371295c...

:sunny: Test successful - travis

Wait, do we need a replacement for /etc/launchd.conf? OS X no longer honors the file, but I presume we added it for a reason. Are we no longer running into those limits with the WPTs?
I'm looking to do some testing on servo-macpro1 in the next few days and try to make the big block of commands needed to install on OS X much smaller :)

I landed because I'm pretty sure we don't need it if it's being ignored anyway :-) All of our OSX builders are on 10.10.x. We haven't been running into those limits with the WPTs, and I'm sure we would otherwise, because the defaults are super low.
Thanks again for helping automate all of this stuff!


[FEATURE] Update to Go 1.21

Is there an existing feature request for this?

[X] I have searched the existing feature requests

Is your feature request related to a problem or use-case? Please describe.
Go 1.20 is end of support already.
Describe the solution that you would like.
We should update go.mod and CI to use Go 1.21. PR should be similar to the last one.
Describe alternatives you have considered.
No response
Anything else?
No response

/assign Adarsh-jaiss

/assign Adarsh-jaiss


[ANCHOR-410] Add tear down process for the uncleared static mocks in SepServiceTest

Description
Add missing clearAllMocks() calls in Sep1ServiceTest.
Context
The RequestLoggerFilterTest fails from time to time. We suspect it is caused by some un-cleared static mocks from previous tests.
However, I am not able to re-produce the issue at this moment. I made a fix based on possible un-cleared static mocks that may affect the stability of the tests. If the bug happens again, we should re-open this bug with detailed log messages.
Testing

./gradlew test

Reference Server Preview is available here:https://anchor-ref-pr1089.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr1089.previews.kube001.services.stellar-ops.com/


Many deprecations to fix.

DEPRECATION: `ember-cli/ext/promise` is deprecated, use `rsvp` instead. Required here:
  Object.<anonymous> (node_modules\ember-cli-deploy-build\index.js:4:15)

DEPRECATION: `ember-cli/ext/promise` is deprecated, use `rsvp` instead. Required here:
  Object.<anonymous> (node_modules\ember-cli-deploy-revision-data\lib\data-generators\file-hash.js:6:19)

DEPRECATION: `ember-cli/ext/promise` is deprecated, use `rsvp` instead. Required here:
  Object.<anonymous> (node_modules\ember-cli-deploy-revision-data\lib\data-generators\git-tag-commit.js:3:19)

DEPRECATION: `ember-cli/ext/promise` is deprecated, use `rsvp` instead. Required here:
  Object.<anonymous> (node_modules\ember-cli-deploy-revision-data\lib\data-generators\version-commit.js:4:19)

DEPRECATION: `ember-cli/ext/promise` is deprecated, use `rsvp` instead. Required here:
  Object.<anonymous> (node_modules\ember-cli-deploy-revision-data\lib\scm-data-generators\git.js:2:19)

These deprecations are coming from other plugins:
https://github.com/ember-cli-deploy/ember-cli-deploy-build/pull/35
https://github.com/ember-cli-deploy/ember-cli-deploy-revision-data/pull/55
Leaving this issue open till both are merged.

Closing as dependent plugins have now been fixed.


Scrub and mbsync are fighting over date fields

When I run beet update it's removing the month, day, and original_day fields from my tracks because of the scrub plugin but mbsync doesn't account for this when syncing the fields and rewrites them to the file. This seems like unintended behavior.
To reproduce add both plugins with their default options and run beet update and beet mbsync.

The scrub plugin shouldn't remove any of the standard beets fields, such as month. Any chance you mean zero or some other interaction? Maybe a concrete example with output would help.

Sorry for the confusion. It looks like scrub isn't the problem. I just disabled it and I'm still getting the same interaction. As for clarification beet update is setting the mentioned fields to 00 and beet mbsync is setting them back to their values. I don't think it's anything in my config but here it is in case I'm just not seeing it.
directory:      ~/Sounds/Music
library:        ~/Sounds/Music/beetslibrary.blb
asciify_paths:  yes
sort_item:      albumartist+ album+ disc+ track+
plugins:        scrub chroma embedart fetchart mbsync the play missing duplicates fromfilename info

import:
  timid:        yes
  move:         yes

ui:
  color:        yes

paths:
  default:      %the{$albumartist}/($year) $album/$track $title
  singleton:    %the{$albumartist}/($year) $album/$track $title
  comp:         %the{$albumartist}/($year) $album/$track $title

embedart:
  maxwidth:     500

acoustid:
  apikey:       3mCDWUzedB

play:
  command:      mpv --no-audio-display --playlist

As far as more help reproducing it I'm not sure what else I can say. Here's the first few lines of each command showing the output.
% beet update
Chance the Rapper feat. B.J. the Chicago Kid, Lili K, Kiara Lanier, Peter CottonTale, Will & J.P. Floyd - Acid Rap - Good Ass Intro
  month: 04 -> 00
  day: 30 -> 00
  original_day: 30 -> 00
Chance the Rapper feat. Nate Fox & Lili K - Acid Rap - Pusha Man
  month: 04 -> 00
  day: 30 -> 00
  original_day: 30 -> 00
Chance the Rapper feat. Vic Mensa & Twista - Acid Rap - Cocoa Butter Kisses
  month: 04 -> 00
  day: 30 -> 00
  original_day: 30 -> 00
Chance the Rapper - Acid Rap - Juice
  month: 04 -> 00
  day: 30 -> 00
  original_day: 30 -> 00
...

% beet mbsync
mbsync: Skipping album with no mb_albumid: ABSRDST - Mix4AMDISCS
mbsync: Skipping album with no mb_albumid: ABSRDST - Too Future Guest Mix
Chance the Rapper feat. B.J. the Chicago Kid, Lili K, Kiara Lanier, Peter CottonTale, Will & J.P. Floyd - Acid Rap - Good Ass Intro
  month: 00 -> 04
  day: 00 -> 30
  original_day: 00 -> 30
Chance the Rapper feat. Nate Fox & Lili K - Acid Rap - Pusha Man
  month: 00 -> 04
  day: 00 -> 30
  original_day: 00 -> 30
Chance the Rapper feat. Vic Mensa & Twista - Acid Rap - Cocoa Butter Kisses
  month: 00 -> 04
  day: 00 -> 30
  original_day: 00 -> 30
Chance the Rapper - Acid Rap - Juice
  month: 00 -> 04
  day: 00 -> 30
  original_day: 00 -> 30
...

This makes me think that the month, day, and original_day fields aren't being properly recorded in the beets database so update is going through changing the metadata in the files with the wrong (or missing) data from the database.
Let me know if there's anything else I could supply to make this easier. I'll probably get the time to dig through the code myself in the next week or so if you're busy but for now this is all I can do. That being said I'm still not sure if it's a bug or my fault yet.

Aha—I think this is an instance of #1334, which should be fixed in the latest source (a new version will be out very soon). Can you check whether that fixes it? Or, if you hang on for a moment, there may be a new official release for you to try.

Yup that look like the problem. Glad to see it's fixed. Thanks for your help ^_^


RHCOS MVP: single ignition server to serve multiple independent config pools

Currently: a unique Machine Config Server is added for every NodePool in hypershift. That requires a unique nodePort or route for every node pool created in the cluster and a unique deployment in every environment. As designed: this currently will not scale to the workload size IBM Cloud needs to support in a given hypershift management cluster.
We need enhancements to the Machine Config Controller and Machine Config Server where 1 machine config server can be used per cluster and through it multiple different pools of config can be served (workers, specialized worker pool configs, etc). There should be a way for these configs to get updated over time as well.
Acceptance Criteria:

[ ] Enhance Machine Config Controller to be able to run in management cluster
[ ] Define process to add MachineConfigs to a given pool. Currently this is done by adding configmaps to the management cluster with a specific label but might change in this design.
[ ] Enable the Machine Config Server to be able to serve configuration for multiple MachineConfigPools in one server
[ ] Ensure Machine Config Controller can update what the Machine Config Server is serving as MachineConfigs are added/removed.

/assign

this is enabled and complete


Use the same hashIds between projects

Is it possible to have the same Hash IDs in different Laravel projects?
I set $hashKey on the models in the two different projects to be the same, but the hash IDs are different.
When I put the same APP_KEY for both projects, the hash IDs match, but obviously this is not practical.

I have added this feature and created a pull request:
https://github.com/veelasky/laravel-hashid/pull/98


Better NetMessage API

I am unhappy with the current API for NetMessage, because it basically forces a very common case to have an unnecessary clone(), e.g.:
fn receive_network(&mut self, msg: NetMessage) -> () {
  let sender = msg.sender().clone();
  match msg.try_deserialise::<MsgType, DeserType>() {
    Ok(message) => // do stuff with sender and message
    Err(e) => // log error whatever
  }
}

The clone occurs because try_deserialise needs to consume the NetMessage.
I see a bunch of ways around this, but not sure what is the best way to go, so I'm looking for feedback or alternative suggestions.
Here's what I got so far:
Option 1
Move the serialisation id and the data into its own struct (let's call it NetData perhaps) and have NetMessage be a struct with public fields of sender, receiver, data.
Option 1B
I could of course do this destructuring eagerly and change the method signature of receive_network to something like:
fn receive_network(&mut self, sender: ActorPath, _receiver: ActorPath, msg: NetData) -> () {
  match msg.try_deserialise::<MsgType, DeserType>() {
    Ok(message) => // do stuff with sender and message
    Err(e) => // log error whatever
  }
}

But again, that's a lot of fields to ignore when we don't need receiver or sender, which bloats the code somewhat.
Option 1C
Could also add a few convenience methods to NetMessage that do the destructuring and take closures with the values, e.g.:
  msg.use_sender(|sender, data| {
    match data.try_deserialise::<MsgType, DeserType>() {
      Ok(message) => // do stuff with sender and message
      Err(e) => // log error whatever
    }
  });

Option 2
I could make the sender and receiver fields inside NetMessage an Optional<ActorPath>. This would allow people to take() them when needed, e.g.:
fn receive_network(&mut self, msg: NetMessage) -> () {
  let sender = msg.sender().take().unwrap(); // must exist the first time
  match msg.try_deserialise::<MsgType, DeserType>() {
    Ok(message) => // do stuff with sender and message
    Err(e) => // log error whatever
  }
}

It's not as verbose as destructing and more similar to code you might write Scala, for example. But on the other hand, adding an Optional for something that is guaranteed to be present is kind of misleading and the required unwrap() adds panicking logic to the code piece, which we know the Rust  compiler isn't too happy with performance-wise.

Option 3
pub struct NetMessage {
  ser_id: SerId,
  sender: ActorPath,
  receiver: ActorPath,
  data: HeapOrSer,
}

pub struct TypedMessage<T> {
  sender: ActorPath,
  receiver: ActorPath,
  data: T,
}

impl NetMessage {
  pub fn try_into_typed<T, DeserType>(self) -> TypedMessage<T> { /* ... */ }
}

// ...

fn receive_network(&mut self, msg: NetMessage) -> () {
  match msg.try_into_typed::<MsgType, DeserType>() {
    Ok(message) => {
      let sender = message.sender();
      let data = message.data();
      // do stuff with sender and message
    }
    Err(e) => // log error whatever
  }
}

Ad option 1: you could also do partial destructuring if you don't care about the receiver:
let NetMessage { sender, data, .. } = msg;

Also regarding option 1: you can just access the fields. Partial moves work https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=243976d9c3709dd6bcfdf92e15b0d53b


Hax hangs on a recursive trait with associated type

pub trait Trait1 {
    type T: Trait1;
}

pub trait Trait2: Trait1 {
    type U;
}

Running hax json on this code causes it to hang forever. Removing type U; fixes the issue.

This issue stems from the path_to function doing a depth-first search.
Doing a breadth-first search instead solves this issue, will push a PR soon.
Note that switching to a breadth-first search is not solving issue #686.


Organise repo documentations and README

Context
:scroll: View the documentation on this branch
We have good documentation on the repo but it is poorly organised and maintained.
Move large parts of the README into separate files to reduce the size of the README.
Create 3 distinct groups of documentation - Dev, Infra, General
Update dead links in the Documentation
Update the values of the tech we are using
Changes proposed in this pull request

Guidance to review

Link to Trello card
Trello Ticket
Things to check

[ ] If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
[ ] This code does not rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
[ ] API release notes have been updated if necessary
[ ] If it adds a significant user-facing change, is it documented in the CHANGELOG?
[ ] Required environment variables have been updated added to the Azure KeyVault

 Organise apply Repo README and docs


Artworks Screen - UI

Create a card for the artworks list in this scree. Topbar and bottom bar already done.
Photo for reference:

Finished


Object.activate is deprecated.

AtomLinter v0.X.Y API has been deprecated. Please refer to the Linter docs to update and the latest API: https://github.com/AtomLinter/Linter/wiki/Migrating-to-the-new-API
Object.activate (/home/steel/.atom/packages/linter/lib/main.coffee:51:8)
Package.activateNow (/usr/share/atom/resources/app.asar/src/package.js:238:19)
<unknown> (/usr/share/atom/resources/app.asar/src/package.js:219:30)
Package.measure (/usr/share/atom/resources/app.asar/src/package.js:163:15)
Package.activate (/usr/share/atom/resources/app.asar/src/package.js:211:14)
PackageManager.activatePackage (/usr/share/atom/resources/app.asar/src/package-manager.js:452:21)

+1

:+1:

:+1:

+1

and +1

:+1:

:cry:

:thumbsup:

:+1:

+1


node: fix health check package.json template

forgot to fix the template #7493

Thank you, and LGTM

test passed. merging


Add promotetest to it

I plugin the promotion/rollback into the IT. I also add a dryrun flag to the command args.

Looks good, and I think we can merge first and do update based on the test.


Update README with smashing magazine article

I was looking for the article like crazy and almost gave up. Thank you!

Thank you!


fix(EG-811): update organization-service delete() to correctly remove unique reference

This PR fixes the organization-service delete() method to correctly remove the Organization's lower-case name from the DynamoDB unique-reference table.

LGTM


Migration for Xamarin project, unable to use FileSystem

I would like to use Xamarin.essentials.FileSystem to initialize insaide the DBContext class the database Path, and make a migration.
System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.TypeInitializationException: The type initializer for 'TestDB.Connect.DataBase.DBContext.DBBaseTestDB' threw an exception. ---> Xamarin.Essentials.NotImplementedInReferenceAssemblyException: This functionality is not implemented in the portable version of this assembly. You should reference the NuGet package from your main application project in order to reference the platform-specific implementation.
   at Xamarin.Essentials.FileSystem.get_PlatformAppDataDirectory() in D:\a\1\s\Xamarin.Essentials\FileSystem\FileSystem.netstandard.cs:line 12
   at TestDB.Connect.DataBase.DBContext.DBBaseTestDB..cctor() in D:\Xamarin\connect\TestDB.Connect\TestDB.Connect.DataBase\DBContext\Base\DBBaseTestDB.cs:line 22
   --- End of inner exception stack trace ---
   at TestDB.Connect.DataBase.DBContext.DBBaseTestDB..ctor() in D:\Xamarin\connect\TestDB.Connect\TestDB.Connect.DataBase\DBContext\Base\DBBaseTestDB.cs:line 30
   --- End of inner exception stack trace ---
   at System.RuntimeTypeHandle.CreateInstance(RuntimeType type, Boolean publicOnly, Boolean wrapExceptions, Boolean& canBeCached, RuntimeMethodHandleInternal& ctor)
   at System.RuntimeType.CreateInstanceSlow(Boolean publicOnly, Boolean wrapExceptions, Boolean skipCheckThis, Boolean fillCache)
   at System.Activator.CreateInstance(Type type, Boolean nonPublic, Boolean wrapExceptions)
   at Microsoft.EntityFrameworkCore.Design.Internal.DbContextOperations.<>c__DisplayClass12_3.<FindContextTypes>b__13()
   at Microsoft.EntityFrameworkCore.Design.Internal.DbContextOperations.CreateContext(Func`1 factory)
   at Microsoft.EntityFrameworkCore.Design.Internal.DbContextOperations.CreateContext(String contextType)
   at Microsoft.EntityFrameworkCore.Design.Internal.MigrationsOperations.AddMigration(String name, String outputDir, String contextType)
   at Microsoft.EntityFrameworkCore.Design.OperationExecutor.AddMigrationImpl(String name, String outputDir, String contextType)
   at Microsoft.EntityFrameworkCore.Design.OperationExecutor.OperationBase.<>c__DisplayClass3_0`1.<Execute>b__0()
   at Microsoft.EntityFrameworkCore.Design.OperationExecutor.OperationBase.Execute(Action action)
Exception has been thrown by the target of an invocation.

Steps to reproduce
I just want to create a DBContext which affects the databasePath automatically with Xamarin.essentials FileSystem.AppDataDirectory.
But I have an error when I want to create the first migration with this command
Add-Migration InitialCreate
public static readonly string DB_PATH = FileSystem.AppDataDirectory;

Further technical details
EF Core version: latest pre-release
Database Provider: Microsoft.EntityFrameworkCore.Sqlite.Core
Operating system: Windows
IDE: VS 2019

EF Team Triage: This issue is not something that our team is planning to address in the EF6.x code base.  This does not mean that we would not consider a community contribution to address this issue.
Moving forwards, our team will be fixing bugs, implementing small improvements, and accepting community contributions to the EF6.x code base. Larger feature work and innovation will happen in the EF Core code base (https://github.com/aspnet/EntityFramework).
Closing an issue in the EF6.x project does not exclude us addressing it in EF Core. In fact, a number of popular feature requests for EF have already been implemented in EF Core (alternate keys, batching in SaveChanges, etc.).
BTW this is a canned response and may have info or details that do not directly apply to this particular issue. While we'd like to spend the time to uniquely address every incoming issue, we get a lot traffic on the EF projects and that is not practical. To ensure we maximize the time we have to work on fixing bugs, implementing new features, etc. we use canned responses for common triage decisions.

@Tristan-gu Moved to https://github.com/xamarin/Essentials/issues/754


Notify players of new olmod versions

Summary
This update checks for a newer version of olmod. If a newer version than the currently running one is found a button will show on the main menu.  A click on the button will take players to the releases page on github: https://github.com/overload-development-community/olmod/releases

Notes
Uses the first line of https://raw.githubusercontent.com/overload-development-community/olmod-stable-binaries/master/bin/README.txt to read the version. This relies on a convention, so maybe it can be made more robust in the future by including a version file somewhere.
I took the liberty of putting version handling into its own folder. I find things become unwieldly when everything is in one directory. If that is not how we roll I can change to put it into the main dir.
This is my first contribution. I didn't see any specific contribution guidelines for this repo, so just let me know if anything is off.

Please don't use olmod-stable-binaries for this purpose, that is specifically for controlling the Azure server network (and a couple other servers that rely on it), and it could be out of sync with this repo.
You could instead use the Github API by reading https://api.github.com/repos/overload-development-community/olmod/releases as JSON, and checking the tag_name property of the first object.  No API key should be required.

That said, I absolutely love this idea, and solves a problem the community has that previously needed something like OCT to manage. :)

Please don't use olmod-stable-binaries for this purpose, that is specifically for controlling the Azure server network (and a couple other servers that rely on it), and it could be out of sync with this repo.
You could instead use the Github API by reading https://api.github.com/repos/overload-development-community/olmod/releases as JSON, and checking the tag_name property of the first object. No API key should be required.

@roncli Sorry mistyped it in the description. I am actually using https://raw.githubusercontent.com/overload-development-community/olmod/master/README.md. I will check out the API, this sounds like a good way to go. Will update the PR if I get that working.

Now using https://api.github.com/repos/overload-development-community/olmod/releases which works fine. @roncli

FYI, this broke Linux builds.  Fixed in #122.


[Lint] Update space-unary-ops rule in eslintrc (fixes Atom linter crash)

space-unary-word-ops was replaced with space-unary-ops. This fixes an error in Atom with linter-eslint installed.

@amasad Can we do this yet?

I think we need to update our eslint version first. Right?

Probably the best way to approach this is to install eslint, babel-lint, and eslint-react-plugin directly so that React Native can have its own linter settings independent of any other project. My latest commit does this but there's an issue with the packager where it's finding conflicting @providesModule directives deep inside of node_modules (the "commoner" module's files) so that needs to be resolved before merging.

I had this on my list of things todo. I'll take a look soon!

Didn't forget about this. Switching to babel very soon and then we can easily use this.

I'll keep rebasing periodically so it's easy to merge and uses the latest eslint plugins.

Thanks @ide! We just switched to Babel, and we can safely merge this now (after testing internally, with phabricator etc)
@jaredly will take care of this.

Removed the unnecessary jest-cli entry from dependencies.

Thanks!
I had to make some changes to get this to work for both open source and internal, and will show up at the next sync.

Sweet, looking forward to it.

Yay! Thanks for landing it =)

:dancer:


How can I use this on a storyboard?

nvm found the solution.

@rustanacexd Would you mind sharing your solution for the sake of future readers?


Face-off dataset

I would like to know which dataset you used for the face-off application.
How would I train videos for a face off purpose.
I am working on ubuntu 16.04

OK. See https://github.com/tjwei/GANotebooks/blob/master/CycleGAN-lasagne-fber.ipynb
This is pretty much a copy of CycleGAN-lasagne.ipynb
Except that the width and height of the image can be different.
The original videos can be found at
https://www.facebook.com/1471772763091863/videos/1932197823716019/
https://www.facebook.com/chenyi326/videos/10210708140002188/
The videos are cropped and one of the video was flipped,  so that the head sizes are roughly matched and aligned.


docs: :memo: add addl. girections to resolve npx

Reflects what I had to do from my side to get this working.

I just signed 📶 the Facebook CLA. ✔


Add https://haveibeenzuckered.com/ to leaks section

Add https://haveibeenzuckered.com/ to leaks section

@edoardottt please assign this issue to me

done @ExitoLab

Hey @edoardottt can you please assign this issue to me.

@DevanshKyada27  go for it.. @edoardottt  pls use @DevanshKyada27  PR

Completed, thanks @DevanshKyada27

Thanks @edoardottt looking forward for to work with you:)


Samples Cloudfunction Deployment error

Problem:
Following the readme and instructions of
https://github.com/GoogleCloudPlatform/deploymentmanager-samples/tree/master/examples/v2/cloud_functions produces an error where reference to non-existant config file
environment: Google Cloud Shell functions
PROJECT_ID set to project
steps to reproduce

git clone repo
navigate to examples/v2/cloud_functions
gcloud deployment-manager deployments create my-function2 --config cloud_function.yaml --project $P
ROJECT_ID

$ gcloud deployment-manager deployments create my-function2 --config cloud_function.yaml --project $P
ROJECT_ID
The fingerprint of the deployment is v-Nov_ObEimwrN-X9zYNQQ==
Waiting for create [operation-1526768191644-56c966bb7a162-d039b89c-8268fc97]...failed.
ERROR: (gcloud.deployment-manager.deployments.create) Error in Operation [operation-1526768191644-56c966bb7a162-d039b89c-8268fc97]: errors:
- code: MANIFEST_EXPANSION_USER_ERROR
  location: /deployments/my-function2/manifests/manifest-1526768191913
  message: |
    Manifest expansion encountered the following errors: Error compiling Python code: No module named zipfile Resource: cloud_function.py Resource: config

Thanks for reporting this, is fixed now


add 2021 testnet to api constructors

Per report from @uscinski
We've been deploying archive nodes on OPF side. So far we have Testnet gRPC 2022-03-03 and 2021-04-13. We tried to run Nexus analyzer that includes these both archive nodes. But Nexus crashes with the following error:
{"caller":"analyzer.go:130","error":"error creating consensus client: instantiating history consensus API lite: historical API for archive 2021-04-13 not implemented","level":"error","module":"nexus","msg":"service failed to start","ts":"2024-11-07T10:48:25.841983708Z"}

To me it looks like Nexus lacks implementation of the historical API and therefore cannot work with the said node. Is this correct or do we need to configure it differently (both Nexus and gRPC node)? We also tried to include only the 2022-03-03  archive node and so far looks good.

yeah that was the testnet for v21.1


MINOR: update stream-stream join docs

Call for review @JimGalasyn @spena @ableegoldman (cf https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Streams+Join+Semantics)
Must be cherry-picked to 3.0 branch.

\cc @kkonstantine

Merged to trunk and cherry-picked to 3.0 branch.


Catch exception when pasting with invalid data in the clipboard

Similar to https://github.com/icsharpcode/AvalonEdit/pull/246 but build runs were ok.

Thank you for your contribution!


Improvements to context variables methods

Right now it just sets globalOptions.extra to the object you pass in, but it would be nice to be able to add or update a key in globalOptions.extra. It's especially bad because there's no 'getExtraContext' for us to provide an updated object.
Couple ways to go-

Provide all CRUD methods for ExtraContext?
Expose globalOptions on Raven object?
At least make a Raven.getExtraContext method.

This probably applies to Raven.setTagsContext as well.

Is the ability to dynamically change/set the ExtractContext hash available in some fashion or another?

Closing this in favor of modifications I'm going to make to #255.


Onboarding New Members (Unity)

If you have any questions please contact me, Eric, Peru, Varun, or Nitzan.

They are all done


Text-To-Text Local Viz updates

Updates in this PR:
Heatmap:

Inputs are now grouped based on interaction affects, this is done individually per output (As a result of this the Input HTML DOM is structured similar to the partition tree)
Tool Tip to show SHAP Value while hovering
Hovering over Input token while a output token is anchored, now highlights the group of tokens the token belongs to.
Changed "Alignment" to "Layout"

Saliency Plot:

Inputs are now grouped with a consistent group (Grouping is based on the values of 0th Output Token)

How does compare to the #1563 PR, does it replace it? thanks!

@slundberg #1563 is unrelated to the Viz work. Working with @michaelamoako to resolve this.