Add support for site onepiece-tube.com (which is legal)

Before this gets closed :
In Europe it is allowed as these episodes are not licensed in europe and are not shown in Europe at all.
They only show not licensed in europe ones with subs. It's all good . Don't worry
The licensed ones , aka episodes before, are missing there, check the list of episodes they are "offline"
If you still insist that I am wrong , at least tell me how to compile youtube-dl as a single file .exe , after adding a new site yourself. I have no idea how to add one though.

[x ] I've verified and I assure that I'm running youtube-dl 2017.12.23

[ x] At least skimmed through the README, most notably the FAQ and BUGS sections

[x ] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)

[x ] Site support request (request for adding support for a new site)

[ ] Feature request (request for a new functionality)

[ ] Question

[ ] Other

Single video: http://onepiece-tube.com/folge/818-z3u2V18ir

You have to view the source of the frame view where the player is , there it seems to show a mp4 link. Could someone add this to the exe of youtube-dl ? I need to extract it for Vlc

In Europe it is allowed as these episodes are not licensed in europe and are not shown in Europe at all.

This does not prove any rights for them to distribute.
Moreover,

Zusatz:
Wir hosten keine Video oder Audiodateien auf unseren Servern. Jedes Video ist lediglich verlinkt und “gepostet”.
Für Fragen bezueglich den Video oder Audiodateien befragen Sie bitte den jeweiligen Hoster. (Youtube, Blip, Sevenload etc..)
Wir sind nicht verantwortlich für die verschiedenen Posts der Animes, Folgen, Forenbeitraege oder Chatbeitraege.
Für weitere Fragen stehen wir Ihnen selbstverständlich gern zur Verfügung.

from http://onepiece-tube.com/impressum confirms this is copyright infringement.
python setup.py py2exe to build a exe.

If I view the sourcecode of the frame which is the player , I can see the mp4 link inside there , how do i get the source code of that frame in youtube-dl though? Or any good tut?


Maybe its time to officially release bitmono

I think its time to make bitmono not just pre-released every time but released and allowed to be used in production

Now it is beta, but instead of pre-release it is a release but still nonproduction (but for example, I use it in production and it seems to be ok, but find many bugs)


Have a way to do like esh vim /some/remote/path/to/file

Hi, was just going through your "TODO`S" & would like to suggest something for no.4 that it would be possible only if there was an active pid or activating it? & somehow attach(ing) to that specific one vim for example making running it client-side plausible.
BTW this is not an issue just a friendly suggestion. ;)  well done anyhow.

Hey, do you mean like, you would be attaching to a remote vim process? Is that easily possible?

yep .. exactly what i ment. that or invoking it manually. to be honest i
couldnt think of another way of doing it. unless you simply ssh on/off
having the private key of client machince already in hand!
On Mar 13, 2017 5:51 AM, "Gurinder Hans"<EMAIL_ADDRESS>wrote:

Hey, do you mean like, you would be attaching to a remote vim process? Is
that easily possible?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/gurinderhans/esh/issues/2#issuecomment-286003872, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AIWhFTiKfgw5ho8Q3BeWPL00CTEgB5AAks5rlK84gaJpZM4Mas-o
.

do you have some code that shows how this can be done? I've never done this, so any pointers would be really helpful!

honestly pid attachment could be a pain but my modest & clean "Hack-Free" reply would be :
(1) A short command:
ssh -X @ gedit &
from man ssh
-X      Enables X11 forwarding.
This can also be specified on a per-host basis in a configuration file.
    X11 forwarding should be enabled with caution.  Users with the
    ability to bypass file permissions on the remote host (for the
    user's X authorization database) can access the local X11
    display through the forwarded connection. An attacker may then
    be able to perform activities such as keystroke monitoring.

Check /etc/ssh/sshd_config on the server side:
sudo nano /etc/ssh/sshd_config
for the lines below:
X11Forwarding yes
X11UseLocalhost no
Restart the ssh srever, if you have made changes:
sudo service ssh restart
Check /etc/ssh/ssh_config on the client side:
sudo nano /etc/ssh/ssh_config
for the lines below
ForwardX11 yes
ForwardX11Trusted yes
(2) second method:
You just need to run export DISPLAY=:id# in your ssh session and programs run will run on the remote display. A quick example:
maythux@maythuxPC:~$ ssh testSSH@myServer
maythux@maythuxPC:~$ export DISPLAY=:0
maythux@maythuxPC:~$ gedit
Now gedit will run on the user named testSSH display
You can shorten this all down into single command:
ssh testSSH@myServer "DISPLAY=:0 nohup gedit"
(3) third method:
You just need to run export DISPLAY=:id# in your ssh session and programs run will run on the remote display. A quick example:
maythux@maythuxPC:~$ ssh -X testSSH@myServer  <--- or  -Y
maythux@maythuxPC:~$ export DISPLAY=:0
maythux@maythuxPC:~$ gedit
Now gedit will run on the user named testSSH display
You can shorten this all down into single command:
ssh testSSH@myServer "DISPLAY=:0 nohup gedit"
Good luck :+1:


Feature request: List out the definitions when issuing "Multiple possible ... local refs" error

Context: I had <dfn event for=IFoo>bar</dfn> and <dfn attribute for=IFoo>bar</dfn> and {{IFoo/bar}} became ambiguous:
LINK ERROR: Multiple possible 'idl' local refs for 'bar'.
Randomly chose one of them; other instances might get a different random choice.
{{IFoo/bar}}

But I'd forgotten I had the event dfn and was staring at the IDL wondering what was going on. To figure out the problem (and the fix, which was to use <a attribute for=IFoo>bar</a>) I ended up basically chopping out chunks of the spec until I went "duh". Part of the problem was that I actually had backticks around the name in the event definition, so searching for >bar< didn't turn up the event dfn.
So feature request to make it easier next time: actually list out the multiple definitions, e.g.
LINK ERROR: Multiple possible 'idl' local refs for 'bar'.
* event IFoo/bar
* attribute IFoo/bar
Randomly chose one of them; other instances might get a different random choice.
{{IFoo/bar}}

Ah yeah, this isn't much of a problem for more specific link types, but idl covers so many things I can definitely see how it's confusing.


Callbacks for click, hover, keydown

Hey @CookPete! So far, things have been going great while integrating with react-player but ran into a small roadblock. I was trying to implement -

Play/Pause onClick
Show/hide controls onMouseOver/onMouseOut
Keyboard manipulations onKeyDown

But it seems none of these events are exposed at the moment. My current workaround is to have a div around ReactPlayer and tying all the callbacks to that div but it isn't the nicest solution.
Thoughts? Do you think these can be exposed?
Thank you!

Yeah an object of props to attach to the wrapper div makes sense. What name would make sense though? events?
<ReactPlayer
  url='file.mp3'
  events={{
    onClick: () => {},
    onMouseOver: () => {}
  }}
/>

Maybe events doesn't make sense as it could hold any attribute to attach to the wrapper. Maybe wrapperProps or wrapperAttributes? Is there an established term for "other props to blindly attach to a component"?

In my experience, I think most components just pass through any other props with just the spread syntax after slicing off the props they needed.
So, I feel like we might not even need a wrapper unless you feel it is cleaner.

There is already a wrapper div here that we can attach stuff to. The problem is that using the spread syntax would require something like
const { url, playing, volume, blah, blah, blah, ...extra } = this.props

which would be huge and impractical considering the amount of props we have. That's why I'm thinking something like wrapperProps or maybe just attributes so that we can simply do
<div style={...} className={...} {...attributes} />

for the wrapper.


Enables freestyle-docs build check

This PR brings back the docs check once all versions have been fixed.

Codecov Report

Merging #359 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #359   +/-   ##
=======================================
  Coverage   80.38%   80.38%
=======================================
  Files          26       26
  Lines         209      209
  Branches        3        3
=======================================
  Hits          168      168
  Misses         41       41


Search Date shows popup after pressing enter

The following steps cause the datepicker calendar to appear it the top left corner of the window.

Click the "Search" button on a w2ui grid
Enter a date into a date field
Press Enter

The search criterion dialog disappears and the grid searches on the chosen date, but the calendar dialog remains at the top left of the window.

The user can just click somewhere in the window and the calendar disappears so it's not a major issue, but it is a bit unexpected so it confuses people a little.
Thanks for the awesome library!

Please specify the version it is happening. I have tried in the current master branch and was not able to repeat the problem.

Since no reply, closing this issue.

I am also facing same issue in version 1.5.rc1

I am also facing the same issue in version 1.5.rc1. Please help.

Facing the same issue on the 1.5.rc1 version !


Make BatchNormalization callable several times

Currently, when BatchNorm is called several times, there is an exception telling that this is not possible. This has to do with creating the running mean and std. I made a change to the call method that should solve this problem:
def build(self, input_shape):
    # [...]
    self.called_with = []

def call(self, x, mask=None):
    if self.mode == 0:
        assert self.built, 'Layer must be built before being called'
        input_shape = self.input_spec[0].shape

        reduction_axes = list(range(len(input_shape)))
        del reduction_axes[self.axis]
        broadcast_shape = [1] * len(input_shape)
        broadcast_shape[self.axis] = input_shape[self.axis]

        # mode 0
        self.called_with += [x]
        x_normed, mean, std = K.normalize_batch_in_training(
            x, self.gamma, self.beta, reduction_axes,
            epsilon=self.epsilon)

        all_x = K.concatenate(self.called_with, self.concat_axis)
        all_x_normed, all_mean, all_std = K.normalize_batch_in_training(
            all_x, self.gamma, self.beta, reduction_axes,
            epsilon=self.epsilon)

        self.updates = [K.moving_average_update(self.running_mean, all_mean, self.momentum),
                        K.moving_average_update(self.running_std, all_std, self.momentum)]

The inputs with which that layer is being call are stored in a list. After that, the list items are concatenated into one matrix/tensor. That tensor than is being batch normed and the outputs are used for the updates. If the layer is called again, the list gets extendes and self.updates get overwritten. Any thoughts?

Hi this is cool, I am having trouble with batch normalization currently. Did you implement this new update? Can you share code or create a PR?


Separate container for the WebServer

Have you considered separating the web server, my idea would be it can run on a container and acquire data from the pifire, that way you can store your old sessions regardless of the SD. A lot of the people using this would have already a docker or vm environment l, so pushing numbers instead of the complete website will also allow for wifi signal to be less critical.

This is an interesting idea.  Will consider this in the future.  For now, the implementation relies on the API being part of the webserver.


Repo sync for protected CLA branch

The pull request is created from main637999830513996939sync_temp to main to fix git push error for protected CLA branch

Learn Build status updates of commit 5d1934c:
:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Fix: apiVersion of CronJob for 1.25+ clusters

Description of your changes
Fixes #5476
I have:

[x] Read and followed KubeVela's contribution process.
[x] Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
[ ] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested
Tested it locally with k3s v1.25.5+k3s2
Special notes for your reviewer

please run make reviewable to generate the definition yaml files from CUE.
sign the DCO

Thanks for contributions!

please run make reviewable to generate the definition yaml files from CUE.
sign the DCO

Thanks for contributions!

Done.
Thanks for KubeVela!


S3 test check

Checking to keep or remove the S3-test suite https://github.com/gaul/s3-tests

FAILED (SKIP=55, errors=454, failures=23)

Let's see whether it makes sense to keep this inside the repository, or simply removing it. I have to dive into the errors but as there are so many, I assume it will just be a configuration issue right now.

s3-tests vastly improved S3Proxy compatibility so I recommend using it for gofakes3. However it is hard to work with the upstream project and I have maintained my fork for years.  Further they are porting to boto3 which seems to change everything and are not merging new pull requests to avoid conflicts.  You are welcome to use my fork but I periodically rewrite history when I track upstream changes.

FAILED (SKIP=55, errors=454, failures=23)

Do any of them pass? :laughing:
@gaul, would you recommend we use your fork or the original repo?

I recommend creating a new fork of the original repo but using my fork as a reference since it shows how to disable failing tests via attributes.  There is nothing special about my fork and I hope that upstream merges all my pull requests some day.

Codecov Report

Merging #15 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #15   +/-   ##
======================================
  Coverage    64.4%   64.4%
======================================
  Files          10      10
  Lines         500     500
======================================
  Hits          322     322
  Misses        148     148
  Partials       30      30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3053187...64ca3a3. Read the comment docs.


Refactor Popover as a controlled component

Refactor <Popover /> as controlled component. Now the users of the component should deal with displaying/hiding the popover with callbacks helping them. The generic case is still almost the same with giving more control for more specific cases. Also generally simplifies both the Popover and the components using it and actually makes tests easier to write.
Changes

Receive isOpen props and onReferenceClickClose / onOutsideClickClose
Remove closePopover prop passed renderPopover
Remove isOpen prop passed to renderReference

Well, this one requires a bit of refactoring on the consumer side, right? If so let's keep it for another release (not 0.0.3)

I am the only one using this atm (checked with @ilyanoskov), but no pressure to release it for now. It is only used for the Filter PR which is just now being opened.
I can merge it and take care of the release when the time comes, probably early next week.


Getting in page linking not enabled when inPageLinks is set to true

Error
I am getting in page linking not enabled when inPageLinks is set to true. I am using version 2.8.10
To Reproduce
Please navigate to https://amaravatitn.com/Menu?promos=1
Click on Veg / Non Veg Appetizers - OnLoad of the page writes to the console stating in page linking not enabled.
Click on Vegetarian for on page link and it does nothing
Expected behavior
Clicking on Vegetarian should got to the anchor section Vegetarian
Screenshots

Code
Your browser does not support iframes.

For a workaround I am using onclick instead of href to an anchor tag.

This should be fixed in a later version


Utilizing Tags in Routing Rules while Sending Tags through Script

While sending the extra parameter to agent conversation screen, SDK works great, but wondering if any of the custom parameter that we send through this script, can be utilized in Routing Rules in workstream or not?
There are times where Routing is depend of some activity of user on site. I mean suppose we wants to send some Tag (for an example : Technical/Support/Purchase/General) from this script and wants to use that Tag into Routing Rules. If these is a way, please let me know.

Using the context variable,.. i found the way to populate context variable and route the queue.


Prerelease repositories to be used

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Typing support for custom backenends

[x] Closes #6632

So far we have not found a good way of typing dynamically added custom backends (installed via pip).
So the only fallback option is to allow str.
I have decided to leave the Literal as type, since it gives the user a nice list of supported backends in the editor.

That fail is accidental?

Yeah probably. I've restarted it now.

Thanks @headtr1ck !

Thanks again @headtr1ck ! This is an awesome series of PRs.


Xcode 7.3

Thank you for the PR, Jan!
Is the new install path backward-compatible? Unfortunately, I don't have any older versions of Xcode handy to try.

I don’t see why not. It’s the default location Alcatraz uses in any case.
BTW: Please also check my changes to your script: https://gist.github.com/JanX2/07788c3654a4984088926065ed4aaa26

Won't install for me in 7.3 on 10.11.3 with your path change when I just run it. Installs to ~/Library/Application Support/Developer/Shared/Xcode/Plug-ins with the old path (even though old path does not point to ~/).
Can you reproduce this?
In the meantime, I'll manually add the UUID.


Incompatibility with HitScoreVisualizer

Issue: My HitScoreVisualizer usually show text (numbers), but after installing this plugin, it now show specific symbol.
Turning on Bloom seem to fix the issue temporary.
HitScoreVisualizer: https://github.com/ErisApps/HitScoreVisualizer
Without bloom (issue):
<
With bloom (work fine):

PlayerInfoViewer, but given the way the program works, there is no part of it that runs during gameplay.
I can't think of any cause that would affect the display of HitScoreVisualizer.
Perhaps PlayerInfoViewer has nothing to do with it.
https://user-images.githubusercontent.com/14249877/189636340-40901060-6260-4daf-8d5a-e4e73ab01e56.mp4
Is the display of certain symbols when HITSCORE BLOOM is OFF in HitScoreVisualizer the same as in this video?
Note that this video was taken with PlayerInfoViewer removed.
I also tried it in a minimal environment where HitScoreVisualizer and PlayerInfoViewer work, and it seems to work fine even if BLOOM is OFF at this time.
I think the cause is in another mod, but I have not been able to investigate that far.
This problem has been occurring in my environment for some time and I have been using BLOOM with it ON for a long time.

Yea it seem to be the same symbol as your video. I can try to find if it's also caused by another plugin. I switched to NalulunaFlyingScore for now since it doesn't have that issue, but I would love to go back to normal HSV.

I did a very minimal environment too and I get the exact same issue.

Changing the "displayMode" in HSV seem to change the symbol used by the HSV due to the bug. It's probably an issue somehow caused by TextMeshPro.

Update: I downloaded the source code, removed that following line and recompiled and everything work now:
textMesh.font = Instantiate(Resources.FindObjectsOfTypeAll<TMP_FontAsset>().First(t => t.name == "Teko-Medium SDF Numbers Monospaced Curved"));

Thank you for your detailed investigation.
Your identification of the cause is very helpful.
It seems that my investigation in my minimal environment was inadequate.
I checked again today and found this problem.
I am pretty sure that the part of the code you pointed out is the cause.
I am referring to NowPlaying.cs in CustomMenuMusic for this part, but
Using CustomMenuMusic with the same location removed fixed the problem in my normal environment.


Update README

Simplified README to be user specific rather than dev specific.
Fixed #510
Click to see updated documentation

LGTM

Thanks !


Maximum recursion depth exceeded during AD ingestion in _add_group_members_to_group_membership

Describe the bug
AD Ingestion fails because of stack overflow.
To Reproduce
Steps to reproduce the behavior:

Add Azure AD ingestion
Start ingestion with Azure AD Domain with huge hierarchy of groups

Expected behavior
Ingestion finishes without an issue
Screenshots
Arguments: (RecursionError('maximum recursion depth exceeded while calling a Python object'),)
Traceback (most recent call last):
  File "ingest.py", line 38, in load
    pipeline.run()
  File "/usr/local/lib/python3.8/dist-packages/datahub/ingestion/run/pipeline.py", line 348, in run
    for wu in itertools.islice(
  File "/usr/local/lib/python3.8/dist-packages/datahub/ingestion/source/identity/azure_ad.py", line 340, in get_workunits
    self._add_group_members_to_group_membership(
  File "/usr/local/lib/python3.8/dist-packages/datahub/ingestion/source/identity/azure_ad.py", line 392, in _add_group_members_to_group_membership
    self._add_group_members_to_group_membership(
  File "/usr/local/lib/python3.8/dist-packages/datahub/ingestion/source/identity/azure_ad.py", line 392, in _add_group_members_to_group_membership
    self._add_group_members_to_group_membership(
  File "/usr/local/lib/python3.8/dist-packages/datahub/ingestion/source/identity/azure_ad.py", line 392, in _add_group_members_to_group_membership
    self._add_group_members_to_group_membership(
  [Previous line repeated 968 more times]

....

Version:

DataHub v0.8.43

Hi @kirillmakhonin this seems like a troubleshooting issue, rather than a bug. We're happy to provide community support on our Slack channel, but currently reserve git issues for bugs.
If you're still having trouble, please join us at slack.datahubproject.io and we can troubleshoot there. For now, I'm going to close this issue.


TypeScript Support

Hello,
I can't use the framework in a vue 3 typescript project.
What can I do about it?
TS7016: Could not find a declaration file for module 'vue3-carousel'. 'C:/Users/Jannik/PhpstormProjects/backify-landing/node_modules/vue3-carousel/dist/carousel.js' implicitly has an 'any' type.
Try npm install @types/vue3-carousel if it exists or add a new declaration (.d.ts) file containing declare module 'vue3-carousel';

@ismail9k This doesn't work.. I get the same issue. Any fix?

I faced the same problem :(

Running into the same problem!

any update on this issue?

I added two options into "compilerOptions" in tsconfig.json,then it works.
"allowJs": true,
"noImplicitAny": false,

I added two options into "compilerOptions" in tsconfig.json,then it works. "allowJs": true, "noImplicitAny": false,

@LanShih ,
It works, you saved me =))
Tks,

fixed in v0.1.42

I am facing the same problem


scrcpy just closed when I open it

OS: [win 10]
scrcpy version: [1.22]
installation method: [ Windows zip file]
device model:Huawei p30 lite
Android version: [android10 ]

Describe the bug
Whenever I open Scrcpy if my screen close it flash and Scrcpy closed if it's not Scrcpy just Closed
I don't think there is any problem in SDK because I am programming in Flutter and there isn't any problem

Run scrcpy-console.bat to see the error.

Did you install the 64 bit version while you have a 32 bit system?

No, I'm 64 bit

Double-click on open_a_terminal_here.bat and type scrcpy.
If it does not work, what about .\scrcpy.exe? Otherwise, try the 32 bit version.

When I tried scrcpy I got:
scrcpy 1.22 <https://github.com/Genymobile/scrcpy> C:\****************\scrcpy-win64-v1.22 - 1\scrcpy-server: 1 file pushed, 0 skipped. 46.4 MB/s (40955 bytes in 0.001s) [server] INFO: Device: HUAWEI MAR-LX1M (Android 10) INFO: Renderer: direct3d INFO: Initial texture: 1080x2312 WARN: Device disconnected [server] ERROR: Exception on thread Thread[main,5,main] android.media.MediaCodec$CodecException: Error 0xfffffc0e         at android.media.MediaCodec.native_configure(Native Method)         at android.media.MediaCodec.configure(MediaCodec.java:2023)         at android.media.MediaCodec.configure(MediaCodec.java:1951)         at com.genymobile.scrcpy.ScreenEncoder.configure(ScreenEncoder.java:274)         at com.genymobile.scrcpy.ScreenEncoder.internalStreamScreen(ScreenEncoder.java:94)         at com.genymobile.scrcpy.ScreenEncoder.streamScreen(ScreenEncoder.java:73)         at com.genymobile.scrcpy.Server.scrcpy(Server.java:100)         at com.genymobile.scrcpy.Server.main(Server.java:326)         at com.android.internal.os.RuntimeInit.nativeFinishInit(Native Method)         at com.android.internal.os.RuntimeInit.main(RuntimeInit.java:359)

See #2990

Thx it works very well.
But I found the screen goes black whenever I open a thing that needs a password, and I can not write except in English.
These aren't big problems for me I don't need Scrcpy to do it now but I would see it in the future.
thx 4 ur hard work.

It's expected if you use Android 12. See #2129.


exporting multiple times messes up the cursor

:tada: This issue has been resolved in version 1.1.15 :tada:
The release is available on:

v1.1.15
GitHub release

Your semantic-release bot :package::rocket:


CRS4 Wordpress plugin all I need for wordpress, because it's missing rule exclusions from crs3.4?

I am attempting to upgrade CRS3.4 to CRS4 and have a question that needs clarification. I just want to be sure that I read the instructions correctly.
In CRS3.4, the file coreruleset-3.3.4/crs-setup.conf has a section
SecAction \
  "id:900130,\
   phase:1,\
   nolog,\
   pass,\
   t:none,\
   setvar:tx.crs_exclusions_wordpress=1"

that is no longer listed in CRS4 crs-setup.conf .
The new instructions for CRS4 seem to indicate that in order to gain the full set of wordpress rule exclusions from CRS3.4 back, I just need to install the Wordpress Rule Exclusions Plugin, and all the rule exclusions provided in CRS3.4 should now be enabled in CRS4.
My question arises because I indeed have Installed the Wordpress rule exclusions plugin, but I noticed that I can no longer get to my wordpress login page at www.example.com/wp-login.php while the plugin is active. Which means that the wordpress rule exclusions plugin doesn't include all wordpress exclusions included in crs3.4, OR, I haven't properly installed the plugin and it is not working properly. I'm not sure which one is right. So, does the wordpress r-e plugin include all of the old exclusions from crs3.4? or does it have a set of entirely new rule exclusions? Why is my wordpress login page not working while the WPRE Plugin is active on CRS4? Could someone clarify exactly what the wordpress R-E Plugin does and doesn't do? Thanks for any help and answers.

Yes, the plugin contains the same rules, essentially, with some changes, of course. But I'll let @azurit take this, he has extensive experience with it.

@Danrancan Hi, can you show audit logs? So we can see why exactly is access to wp-login.php blocked.

@Danrancan Hi, can you show audit logs? So we can see why exactly is access to wp-login.php blocked.

Darnit. For some odd reason, the problem with the login page has gone away. I've been tinkering around with the settings a little bit but I don't think I changed anything significant to make things work. I tried reverting every change I could remember to reproduce the wp-login.php 404 but have no luck as of now. The wp-login.php page seems to now be working and I can't unbreak it. Do you think you can keep this open for a few weeks just incase the problem reappears and I can then post the audit log? Let me know, and thanks a ton for your help good sir!
Dan

A few weeks seems like a long time :) I'll close this issue for now, you can always come back and reopen it, or open a new issue.

A few weeks seems like a long time :) I'll close this issue for now, you can always come back and reopen it, or open a new issue.

It just stopped working for a second, then started working again. Its being finicky. You can close it, and I will just reopen if it comes up again. Thanks again!

Maybe it is related to your other problem with cookies - browser is probably sending them also to wp-login page.


Unify fail notifications

Issue: https://issues.redhat.com/browse/AAH-1354
This pr works towards unifying fail alert notifications across the application. The effort will be broken into several prs.
Please reference this working document for a list of target notifications.

Looks good, the one thing I'm not yet sure of is where there was an existing err.message and it isn't used anymore..
-                description: err?.message,
+                description: errorMessage(status, statusText),

I think most or all of those should be ok, but I wonder if there could be places where we're ignoring a specific server response to display a generic message instead. (Such as displaying "The server was unable to complete your request." instead of something like "Name is required" coming from the server.)
Would err?.message || errorMessage(status, statusText) work?
(If not I can check those places and see what kind of API responses we could be getting.)

@himdel hmm, I think the err?.message is even more simple and generic than the errorMessage, see console logs of each:

Ooh, err?.message is always coming from the http response statusText then?
I was assuming there would be at least some cases where the message is coming from the actual API json response.


Parallel message handling does not work

Which version of the SDK was used?
github.com/Azure/go-shuttle v0.5.5
https://github.com/Azure/go-shuttle/tree/8da14c485b239d55fa6b75dd41704e7d3bd0e55f
Which platform are you using? (ex: Windows, Linux, Debian)
Linux
What problem was encountered?
How things are currently set up in go-shuttle I am only able to process one message from the service bus at a time, and don't get to move onto the next message until the first is completed. I have been unable to find any exposed feature that would allow me to handle concurrent messages.
From digging through the code base I found that there are a few locations in the dependency azure-service-bus-go that I believe are resulting in this behavior, with modification to go-shuttle I expect that either exposing a setting, a new AsyncListener or something similar could allow for concurrent handling of messages:

where handle message is called we get a blocking call until the handler completes the message:
https://github.com/Azure/azure-service-bus-go/blob/705d23958eb9c000582c03ba30413dc7e35eb25d/receiver.go#L235
PeakAndLock mode is the default, and not exposed to the user. From my understanding this means that the message will not be removed from the queue until it is completed meaning that we would not even be able to create additional Listeners to receive more messages, as we would still be blocked until the locked message was completed and removed (I expect this should not be changed, and most likely does not want to be exposed either):
https://github.com/Azure/azure-service-bus-go/blob/705d23958eb9c000582c03ba30413dc7e35eb25d/receiver.go#L108
The prefetchCount/linkCredit is set to 1 as default, and there is no setting exposed from go-shuttle to set it:
https://github.com/Azure/azure-service-bus-go/blob/705d23958eb9c000582c03ba30413dc7e35eb25d/receiver.go#L109

An additional note: as RetryLater simply pauses the process in memory, but doesn't remove the message from the queue we are unable to progress onto the next message until we actually complete it. I expect this in intended behavior, but wanted to make note.
How can we reproduce the problem in the simplest way?
Create a Azure Service Bus namespace, and a topic
Setup a go-shuttle Listener for the topic
Enqueue multiple messages
Only one message will be handled at a time with no parallelism
Have you found a mitigation/solution?
While working with a few others we have not found a solution yet, but have run some informative tests and have some ideas:

I modified code location 1. to go r.handleMessage(ctx, msg, handler), and code location 2. to mode:       ReceiveAndDeleteMode,. When running a repro test with this I was successfully able to handle the messages in parallel. I expect modifying the first code location is probably not ok as I believe it possibly changes the current behavior, but might be an alright change. I believe it would need more knowledgeable voices in the mix and isn't even for this repo. However, I highly expect that modifying ReceiveAndDeleteMode is not an acceptable solution as it changes the default behavior. I believe even exposing the option to use it in go-shuttle is not an acceptable final solution as in my understanding in the event that the consuming service crashes the message would be lost.
Working with a few other people Xiahe found the following PR that gives an example of how to implement concurrency using the azure-service-bus-go lib: https://github.com/Azure/azure-service-bus-go/pull/117/files. Based of this PR, Paul Miller created a strawman PR in go-shuttle to emulate what the example PR showed: https://github.com/Azure/go-shuttle/pull/9. I ran a repro test using this PR and was able to confirm that it worked correctly; although, it was limited to handling the number of messages equal to Paul's concurrency value which is used to set the prefetchCount/linkCredit.

I believe the most likely solution will involve something similar to Paul's PR exposed as a new AsyncListener with an option to adjust what the concurrency value is set to, or modify the current Listener and add an exposed option to adjust what the concurrency is set to with the default staying at 1.

Thanks for investigating Charlie,
1 and 3 are indeed correct.

We want to increase the link credit in go-amqp, which will allow more than 1 message "in flight" for the amqp connection. That will allow concurrent receives
The message handler needs to be run in a go-routine. That will enable concurrent processing

Batching (prefetch value) is a separate concern from concurrent receives and concurrent handling. It allows to improve performance by reducing the number of round-trips, and it definitely needs to be exposed and tuned.
PeekLock is not related to the concurrent processing that we need and should not be changed. It protects you against concurrent processing of the same message, which is what you want in 90% of cases.
One case where you need to change it would be to implement a competing consumer pattern.
RetryLater behaviour is intended, and will be just fine once we have concurrent message processing :)
About a solution, I believe concurrent processing should be the default, with sane link credit and prefetch default value.
there shouldn't be a need to expose a specific Async listener. I would rather have an async listener, but let the user set concurrency values.
there is 3 aspects to this.

Local listener concurrency (how many concurrent worker do you want your program to run). This depends on the resources available and on the type of processing each message does (network/cpu intensive for example)
Prefetch count (how many message do we fetch at once). this depends on available throughput and needs tuning.
link credit is probably a factor of 1 and 2.

Crawl, Walk, Run :)

Thanks for investigating Charlie,
1 and 3 are indeed correct.

We want to increase the link credit in go-amqp, which will allow more than 1 message "in flight" for the amqp connection. That will allow concurrent receives
The message handler needs to be run in a go-routine. That will enable concurrent processing

Batching (prefetch value) is a separate concern from concurrent receives and concurrent handling. It allows to improve performance by reducing the number of round-trips, and it definitely needs to be exposed and tuned.
PeekLock is not related to the concurrent processing that we need and should not be changed. It protects you against concurrent processing of the same message, which is what you want in 90% of cases.
One case where you need to change it would be to implement a competing consumer pattern.
RetryLater behaviour is intended, and will be just fine once we have concurrent message processing :)
About a solution, I believe concurrent processing should be the default, with sane link credit and prefetch default value.
there shouldn't be a need to expose a specific Async listener. I would rather have an async listener, but let the user set concurrency values.
there is 3 aspects to this.

Local listener concurrency (how many concurrent worker do you want your program to run). This depends on the resources available and on the type of processing each message does (network/cpu intensive for example)
Prefetch count (how many message do we fetch at once). this depends on available throughput and needs tuning.
link credit is probably a factor of 1 and 2.

Crawl, Walk, Run :)


OTG TE-2.1 Update - ATE test sync and more

ATE test sync
converted lossPct to float
replaced port stats verification to flow stats verification now
Resolves #566

Pull Request Functional Test Report for #1933 / 03f56c28fe5a9b3c6900436c3f8d1561815ea5d3
Virtual Devices

Device
Test
Test Documentation
Job
Raw Log

Arista cEOS

TE-2.1: gRIBI IPv4 Entry

Cisco 8000E

TE-2.1: gRIBI IPv4 Entry

Cisco XRd

TE-2.1: gRIBI IPv4 Entry

Juniper cPTX

TE-2.1: gRIBI IPv4 Entry

Nokia SR Linux

TE-2.1: gRIBI IPv4 Entry

Openconfig Lemming

TE-2.1: gRIBI IPv4 Entry

Help

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 46.875%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1365

Relevant Lines:
2912

💛  - Coveralls

@ANISH-GOTTAPU : Please address the CLA status check (I'm guessing you used a different email here for a commit.)

@ANISH-GOTTAPU : Please address the CLA status check (I'm guessing you used a different email here for a commit.)

@jasdeep-hundal : I used the same email ID, but I updated the branch from the web. However, when I commit something from the command line, the CLA status check passes.

@ANISH-GOTTAPU or @octpetre : Please rebase once more.

@ANISH-GOTTAPU or @octpetre : Please rebase once more.

@ANISH-GOTTAPU / @octpetre : Please grant reviewers write access to the branch if you can, that would enable me to sync to latest/merge into main much quicker.


Popover: Remove StateHasChanged suppression (#3640, #3776, #4375)

Fixes #3640
Fixes #3776
The popover handler had a locking mechanism that would prevent multiple calls to StateHasChanged on the Popover whenever something changed (like. Open, Style or Class). This doesn't work so well on BSS. It can happen that the handler stays locked for a long time and necessary changes are never rendered. This causes the autocomplete popover to not open on BSS with async search funcs.
Since StateHasChanged only sets a render flag it can be called multiple times without causing multiple render passes. That is why the locking mechanism was removed altogether. It tries to optimize something that is already optimized in Blazor and only causes said bug on BSS due to a race condition with the multi-threaded server-side renderer.

Anyone who wants to check the fix can do so now with this pre-release nuget: https://www.nuget.org/packages/MudBlazor/6.0.10-dev.2

I just tried this pre-release. Some of my pop-ups do not work anymore. They won't render the ChildComponent. However I use a wrapper, so I will not judge or blame.
That said, the real reason for commenting here is that https://dev.mudblazor.com/components/popover#popover-inception is not working anymore.
I just wanted to notify you guys.

@tsmeets2 thank you for letting us know. this was a particularly tricky bug because recursive popups caused a never-ending render loop that was very hard to suppress without breaking any other functionality. See fix in #4467

@tsmeets2 sorry, I had the wrong PR number before (now edited). The issue is fixed with PR #4479

@tsmeets2 sorry, I had the wrong PR number before (now edited). The issue is fixed with PR #4479

Thx for investigating and no worries, can't wait to test.

6.15.0 not working? https://try.mudblazor.com/snippet/wYQQOokpBKMVTBFT

6.15.0 not working? https://try.mudblazor.com/snippet/wYQQOokpBKMVTBFT

Hi. What is not working exactly? In your link I don't see any issues.
Also, what it has to do with this PR? It's relatively old one.


fix: datetime's ToUint32 when time arg is before epoch

When user specified time before epoch, for instance "10 Nov 1945", an invalid uint32 will be returned.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (424f447) to head (516764c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #294   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           42        42
  Lines         3675      3675
=========================================
  Hits          3675      3675

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add parametric "Getting Started Guide" for all supported boards

Be able to maximally reuse content between sections, and provide more up-to-date info for all boards.

Fixed by #703


Added a few words on how to get a reference to modal manager

Added a few words on how to get a reference to modal manager and some examples.

thanks!


added photogrammetry example

The Notebook should be using the cognite sdk, and its post/get methods if possible. https://cognite-sdk-python.readthedocs-hosted.com/en/latest/cognite.html#cognite-client


Archive failed with Carthage 0.26

I've tried to build (archive) with Carthage 0.26. (0.26 is new version)
But, I faced to the following error.
I'm investigating what is a cause.
*** Building scheme "EasyPeasy-iOS" in EasyPeasy.xcworkspace
Failed to write to /Users/muukii/develop/src/github.com/eure/pairs-gl-ios-shallow/worktree/space2/Carthage/Build/iOS/EasyPeasy.framework: Error Domain=NSCocoaErrorDomain Code=260 "The file “EasyPeasy.framework” couldn’t be opened because there is no such file." UserInfo={NSURL=file:///Users/muukii/Library/Caches/org.carthage.CarthageKit/DerivedData/9.0_9A235/EasyPeasy/1.6.0/Build/Intermediates.noindex/ArchiveIntermediates/EasyPeasy-iOS/BuildProductsPath/Release-iphoneos/EasyPeasy.framework, NSFilePath=/Users/muukii/Library/Caches/org.carthage.CarthageKit/DerivedData/9.0_9A235/EasyPeasy/1.6.0/Build/Intermediates.noindex/ArchiveIntermediates/EasyPeasy-iOS/BuildProductsPath/Release-iphoneos/EasyPeasy.framework, NSUnderlyingError=0x7fedc1e4fa60 {Error Domain=NSPOSIXErrorDomain Code=2 "No such file or directory"}}

I'm facing this issue too.

I think workspace cause this error.

@dkalachov @nakiostudio
I have experience about this problem.
In that time, I've fixed this with removing xcworkspace.
So, I've cleanup EasyPeasy like it.
What do you think?

It seems like Carthage 0.26 has some problems.
https://github.com/Carthage/Carthage/issues/2208
https://github.com/Carthage/Carthage/issues/2207

Apparently they have already fixed this :) Thanks for reporting!


fix: improve multiple prompts

When a prompt was followed by another prompt, React was "helping" us by not completing resetting the state. This caused an issue where the old state would be used in the next prompt, making it appear as though the prompt was already submitted.
This change will reset this state so it will not be reused.
This change also includes some small changes around what is displayed before and after prompts. For example, when an authentication prompt disappeared, the message would still say,
" needs to authenticate ." Now, the message will switch back to "Waiting for model response..."

fixes it for me 🙌

I realized later that we could clean up some of the state, so I did that.


Use semver regex to check if running preview build

Closes https://github.com/FOSSBilling/FOSSBilling/issues/221 as now the updater will always allow an update if the current version number is not a valid semver version.
Uses the official regex https://semver.org/#is-there-a-suggested-regular-expression-regex-to-check-a-semver-string

Why not
if (version_compare($version, '1.0.0') < 0) {
//preview
}else{
//release
}

https://www.php.net/manual/en/function.version-compare.php


chore: factor out -check-deactivated-plans

The upgrader.Upgrade() function has closely coupled code relating to multiple distinct actions. As such it's complex and hard to maintain. We should resolve this by applying the single responsibility principle. The upgraded.Upgrade() function should have the single responsibility of being a decider that can call other functions that have single responsibilies.
Note, this assumes that
https://github.com/cloudfoundry/upgrade-all-services-cli-plugin/pull/130 has been merged, and we might not want to do that.
Note that the new checkDeactivatedPlans() function duplicates some logic from Upgrade(). This is deliberate as it will allow the logic to be changed subsequently. For example as implemented the code will list service instances even when there are no deactivated plans, and separating the code paths allows this to be optimised away in a future refactor.

:eyes:


Fix CountingSource example stop_position bug

Please add a meaningful description for your change here
Fix the error introduced in PR https://github.com/apache/beam/pull/8781
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

R: @chamikaramj
a quick fix for the buganizer

LGTM. Thanks.


ENH: Dynamic max_step in solve_ivp

Is your feature request related to a problem? Please describe.
My application consists in computing images of plasma around black holes. This requires solving systems of ordinary differential equations along the trajectory of photons from the black hole to the camera. For obvious reasons, it is desirable to take the largest step possible. Unfortunately, the error estimate in the ODE solvers is not enough to provide a good guess for the step size. This is because has no knowledge of the underlying physics: for example, the solver may want to take steps that are so large that they do not capture the turbulence of the plasma (or other physically relevant length-scales). A solution might be to set max_step to the smallest physical scale over the domain, but this would severely limit the efficiency of the algorithm in those regions where the max_step could be larger (e.g., you can take very large steps when you are far away from the horizon).
Describe the solution you'd like.
I would like to be able to pass a function to max_step. This function should take (t, y) and should return a number with the maximum allowed step for that specific iteration of the solver.
Form a technical point of view, implementing this should not be difficult (but, I am not familiar with the internal of the package, so I might be oblivious of other technical problems). Consider for example rk.py. The way max step enters the problem is simply:
https://github.com/scipy/scipy/blob/d460f29107cb6ce2ba30c8f5ceaed8dd6d1531d0/scipy/integrate/_ivp/rk.py#L111-L115
This could be substituted with a function call (if self.max_step is not a number already).
I can probably submit a PR based on this idea (but I will need some guidance).
Describe alternatives you've considered.
At the moment, I am setting max_step to the minimum physical scale in my problem, but this is inefficient.
Additional context (e.g. screenshots, GIFs)
No response

This is a very problem-specific issue. Have you tried lowering the rtol and atol parameters ?
Otherwise, you could split the integrator in smaller intervals, each with its own max_step.

This is a very problem-specific issue.

While I cannot think of another application of the top of my head, I believe that more control over the maximum step size can be a desirable feature in general. The added runtime overhead compared to the current behavior is just one conditional branching (to check if self.max_step is a number of not).

Have you tried lowering the rtol and atol parameters ?

What I am trying to do is to use my knowledge of the physics of the problem to inform the solver. I don't think that changing accuracy would solve my issue for the general cases.

Otherwise, you could split the integrator in smaller intervals, each with its own max_step.

I thought about this too, but this would not work in the case in which your max_step is function of your solution. Consider my application, one of the conditions I would like to impose is to set max_step to eps/r, where r is the distance of the photon from the black hole, which is computed from the position, which is what the integrator is solving for. So, I don't know in advance how to partition the integration. Moreover, this would probably work well only when the number of subintervals is relatively small (because of all the added overhead due to setting up the solvers).

Can you use method-specific classes (RK22, Radau etc)? They all have a .step method, so maybe you get a better control over the step sizes.

Can you use method-specific classes (RK22, Radau etc)? They all have a .step method, so maybe you get a better control over the step sizes.

Could you elaborate on how I would do this? I looked at rk.py. The step is taken by calling a function rk_step(), which takes the step size as one of the arguments.
https://github.com/scipy/scipy/blob/46f2e9c3194eba83fb5f391081bd526ff6c0d7aa/scipy/integrate/_ivp/rk.py#L144
I don't see how I can easily change this without monkey-patching the original code.
Also, I would like to keep using the solve_ivp infrastructure, if possible, because events are a very useful feature for my application.

While I cannot think of another application of the top of my head, I believe that more control over the maximum step size can be a desirable feature in general.

I think that this is quite a sensible statement. Changes to the source code do not seem too extensive, and they would be transparent for the API.
validate_max_step in common.py would have to be updated to distinguish between an array-like and a callable, as well as __init__ and _step_impl in bdf.py, lsoda.py, radau.py and rk.py. For lsoda.py, max_step corresponds to ._integrator.rwork[5]. Indeed, tests should be updated too to reflect the changes.

Indeed, it might actually be useful !
One little issue which I just thought of: in the case where the max_step function varies quite rapidly, it is possible that evaluating max_step at the beginning of the step leads to you to violate the max_step evaluated at the end of the step.
Thus, max_step should rather be computed as follows, at the beginning of each step:
# we are at time t_n
max_step = getMaxStep( t_n )
future_max_step = getMaxStep( t_n + max_step)
max_step = min(max_step, future_max_step)

Imagine the case where your time step is a Heaviside-like function. This new evaluation procedure is the most pragmatic way to avoid violating the specified maximum step.

Could you elaborate on how I would do this? I looked at rk.py. The step is taken by calling a function rk_step(), which takes the step size as one of the arguments.

This is an example of how I do this that requires no changes to the built in code:
import matplotlib.pyplot as plt
from scipy import integrate

def fun(t, y):
    return -y

time_bound = 2.

# dynamic max_step
def max_step(t):
    return max(t, 0.00001)

y0 = [5]

rk45 = integrate.RK45(fun, 0, y0, time_bound, max_step=max_step(0))

# need to manually keep track of solution
t = []
y = []

while rk45.status == "running":
    t.append(rk45.t)
    y.append(rk45.y)

    rk45.max_step = max_step(rk45.t)

    rk45.step()
    print(rk45.max_step, rk45.step_size)
t.append(rk45.t)
y.append(rk45.y)

plt.plot(t, y)
plt.show()

This yields, where the last step is constrained by the ending time and not max_step.
1e-05 1e-05
1e-05 1e-05
2e-05 2e-05
4e-05 4e-05
8e-05 8e-05
0.00016 0.00016
0.00032 0.00032
0.00064 0.00064
0.00128 0.00128
0.00256 0.00256
0.00512 0.00512
0.01024 0.01024
0.02048 0.02048
0.04096 0.04096
0.08192 0.08192
0.16384 0.16384
0.32768 0.32768
0.65536 0.65536
1.31072 0.6892799999999999


log: fix "unsupported value" error in a log line

zap.Any() does not support the field passed at packetparser/packetparser_linux.go:217
We should find another way to log the eth0Link:
level=info caller=packetparser/packetparser_linux.go:217 msg="Attaching Packetparser to eth0" goversion=go1.21.9 os=linux arch=amd64 numcores=4 hostname=aks-nodepool1-17703939-vmss000000 podname=retina-agent-cqnxv version=b8538dc apiserver=https://vakr-04-16-vakr-04-16-9b8218-ezit2obj.hcp.westus2.azmk8s.io:443 plugins=linuxutil,packetforward,packetparser,dns,dropreason eth0Link= eth0LinkError="unsupported value type"

zap.Any() does not support the field passed at packetparser/packetparser_linux.go:217
We should find another way to log the eth0Link:
level=info caller=packetparser/packetparser_linux.go:217 msg="Attaching Packetparser to eth0" goversion=go1.21.9 os=linux arch=amd64 numcores=4 hostname=aks-nodepool1-17703939-vmss000000 podname=retina-agent-cqnxv version=b8538dc apiserver=https://vakr-04-16-vakr-04-16-9b8218-ezit2obj.hcp.westus2.azmk8s.io:443 plugins=linuxutil,packetforward,packetparser,dns,dropreason eth0Link= eth0LinkError="unsupported value type"

It's a netlink.Link interface right?

@huntergregory is this still an issue? It seems like the offending log line has been changed to remove zap.Any entirely...

@ibezrukavyi this one seem to eb outdated. Closing.


Allow uppercase characters in header names

Fixes https://github.com/istio/istio/issues/7859

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ijsnellf
If they are not already assigned, you can assign the PR to them by writing /assign @ijsnellf in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ZackButcher
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [ZackButcher]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ijsnellf: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
1067cead9e453c46b615665ed9de6e0866d77e0c
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ijsnellf: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
378d5f29d597d937b442dcc8dd5d414cc59c888a
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ijsnellf: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
378d5f29d597d937b442dcc8dd5d414cc59c888a
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
378d5f29d597d937b442dcc8dd5d414cc59c888a
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

also to release-1.0

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rshriram, ZackButcher
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [ZackButcher,rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/retest

@ijsnellf: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
378d5f29d597d937b442dcc8dd5d414cc59c888a
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-unit-tests.sh
378d5f29d597d937b442dcc8dd5d414cc59c888a
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

New changes are detected. LGTM label has been removed.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rshriram, ZackButcher
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

istioctl/OWNERS [ZackButcher,rshriram]
pilot/OWNERS [ZackButcher,rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ijsnellf: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
45083ebc1d2686d67a103f93713cacee751f3b7e
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rshriram, ZackButcher
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [ZackButcher,rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ijsnellf: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
fbd73a78799f56dffb4098591b9558f5c857605e
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rshriram, ZackButcher
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [ZackButcher,rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ijsnellf: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
fbd73a78799f56dffb4098591b9558f5c857605e
link
/test istio-unit-tests

prow/e2e-mixer-no_auth.sh
fbd73a78799f56dffb4098591b9558f5c857605e
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ijsnellf: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
fbd73a78799f56dffb4098591b9558f5c857605e
link
/test istio-unit-tests

prow/e2e-mixer-no_auth.sh
fbd73a78799f56dffb4098591b9558f5c857605e
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
fbd73a78799f56dffb4098591b9558f5c857605e
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ijsnellf: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
fbd73a78799f56dffb4098591b9558f5c857605e
link
/test istio-unit-tests

prow/e2e-mixer-no_auth.sh
fbd73a78799f56dffb4098591b9558f5c857605e
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
fbd73a78799f56dffb4098591b9558f5c857605e
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
fbd73a78799f56dffb4098591b9558f5c857605e
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


config.json: Fix invalid exercise UUID

The previous version of configlet uuid was known to generate invalid UUIDs. The latest release of Configlet v3.6.1 fixes that issue for newly added exercises, but existing exercise UUIDs need to be updated manually.
This change pertains to exercism/configlet#99

@nywilken Is the configlet checking for valid UUID?
If should, This PR should be failing?
https://github.com/exercism/swift/pull/303/files

@masters3d configlet lint is not currently checking for invalid UUIDs, it is still an open issue. I plan to start working on that next.
I didn't see the Diamond exercise PR, when I created #304. The UUID in that PR is definitely invalid and should be updated. The latest release of configlet has been patched so all newly generated UUIDs will be in a good state.

@nywilken Cool! Thanks!


Request for additional keybindings

From Nushell's repo: https://github.com/nushell/nushell/issues/510
I tried nu a few versions ago and it was really nice. I just gave it a go again and I must say it improved a lot, but this issue is IMHO still the biggest blocker to switch from other shells.
The cmd Ctrl + Z to undo works fine. I like that it undoes an entire word and not just a single letter like powershell.
I use the following combinations a lot and they are (unless it can be configured/enabled and I missed that) currently missing:

Combination
Explanation

Ctrl + LeftArrow  Ctrl + RightArrow
Works partially, IMHO some special characters like punctuation should also work as stop points (try in powershell with "some.very.long.string.with.dots"). Maybe make those characters configurable?

Ctrl + Z  Ctrl + Y
Works partially, Undo with Ctrl + Z works but there is no redo

Shift  + all Ctrl movements from above (including Shift + Home and Shift + End)
Select text

Ctrl + A
Select all

Ctrl + C  Ctrl + V  Ctrl + X
Works partially when the terminal supports it (with mouse select) but Ctrl + X + keyboard selection doesn't work

ESC (like in Powershell)  or Ctrl + U (like in bash)
Clear the current line

Let us know about features you really want to see in reedline.
References
If the feature you are interested in exists in other shells or terminal editors, please share links to documentation or screenshots to easily communicate the desired behavior!

I use this for clear
  {
    name: clear
    modifier: none
    keycode: esc
    mode: emacs
    event: { edit: clear }
  }


Improvement: Allow pfind command to work for surnames

Command pfind only looks at the first few characters of the name string. e.g. pfind b fill give you Bernice Yu, but not Roy Balakrishnan.

The current implementation is intentional and I have no intention of modifying this. Real-time searchbox is effective since you don't need type a lot to get what you want but if you includes surnames and alike (including long separated names) then you'll be getting a lot of irrelevant hits and forced to type more to narrow down the search


[KeyVault] subject alternative names for certificate policy

I'm trying to do the following task:
# Create a new self signed certificate -cert2, customize this certificate policy with subject alternative names "CN=.contoso.com" and "CN=.apps.contoso"
following the docs here: https://azure.github.io/azure-sdk-for-python/ref/azure.keyvault.certificates.html#azure.keyvault.certificates.CertificatePolicy.san_upns
Here's my code:
    cert_name = "lily-cert2"
    cert_poller = certificate_client.create_certificate(cert_name)

    policy = CertificatePolicy(
        issuer_name="Self",
        subject_name=san_upns(["CN=*.contoso.com", "CN=*.apps.contoso"]),
    )
    updated = certificate_client.update_policy(
        certificate_name="lily-cert2", policy=policy
    )

I'm getting this error:
File "keyvault_keys_certificates_tasks.py", line 156, in task7
subject_name=san_upns(["CN=.contoso.com", "CN=.apps.contoso"]),
NameError: name 'san_upns' is not defined
Is san_upns supposed to be something that I import? I don't see any specification on that in the docs above. Please help. Thanks!

Thanks @lilyjma ! //cc: @iscai-msft

I think this works now:
 policy = CertificatePolicy(
        issuer_name="Self",
        subject_name="CN=*.contoso.com",
        san_unps = ["CN=*.contoso.com", "CN=*.apps.contoso"]
    )

Hey @lilyjma assuming you are using v4.0.0.b4 of certificates, you should be using san_dns_names, it's here in the keyword arguments. I believe san_upns, san_dns, and san_emails were grouped together under san_upns during v4.0.0b2 but we have subsequently separated them

closing this issue bc it has been resolved


Add Tab Snooze

The Tab Snooze extension will provide users with the ability to right-click on a tab and choose a snooze option from a dropdown menu. This action will temporarily remove the tab from the active window and set a timer for its automatic reopening. Users can select snooze durations such as 15 minutes, 1 hour, or custom times.

@Sulagna-Dutta-Roy , ma'am i have 50 point only from this repo can you please change the level to level2

Open some level2 issues, I will assign accordingly.
Also if you check my repository has many tab related projects which were given level1 @AsmitaMishra24

Are you still working on this @AsmitaMishra24


sample-data-service mock infra client data

:nut_and_bolt: Description: What code changed, and why?

This PR only responsible to run sample-data-service using various deploy options.

Define sample-data-service as product and user can run this service using --product sample-data.

:chains: Related Resources
https://github.com/chef/automate/issues/4141
:+1: Definition of Done

sample-data-service is enabled and running.

:athletic_shoe: How to Build and Test the Change

rebuild components/sample-data-service
rebuild components/automate-deployment
in hab studio:

enable_sample_data_service

OR
> cat sample-data.toml
[deployment.v1.svc]
      products = ["sample-data", "automate"]

> chef-automate config patch sample-data.toml

OR
> chef-automate deploy --product sample-data

check sample-data-service status chef-automate status

sample-data-service     running        ok            12204      4977

:white_check_mark: Checklist

[x] I have read the CONTRIBUTING document.
[ ] Tests added/updated?
[ ] Docs added/updated?
[x] All commits have been signed-off for the Developer Certification of Origin.

:camera: Screenshots, if applicable

build fc35c99adf07 is failing due to:

./testssl.sh --parallel --quiet -n none --color 0 --severity LOW --warnings off --disable-rating --jsonfile=/tmp/testssl.lrn6Gn/jsonfile_00000037.json --fast --add-ca /hab/svc/deployment-service/data/root.crt --warnings=batch <IP_ADDRESS>:10155
--
  |
  | Start 2020-10-22 11:17:02        -->> <IP_ADDRESS>:10155 (<IP_ADDRESS>) <<--
  |
  | rDNS (<IP_ADDRESS>):       (instructed to minimize DNS queries)./testssl.sh: connect: Connection refused
  | ./testssl.sh: line 10817: /dev/tcp/<IP_ADDRESS>/10155: Connection refused
  | Oops: TCP connect problem
  |
  | Unable to open a socket to <IP_ADDRESS>:10155.
  | Fatal error: Can't connect to "<IP_ADDRESS>:10155"
  | Make sure a firewall is not between you and your scanning target!
  |
  |
  | /go/src/github.com/chef/automate
  | /usr/bin/buildkite-agent
  | 2020-10-22 11:17:41 INFO   Found 1 files that match "/tmp/tmp.Z70e6hNAQk"
  | 2020-10-22 11:17:41 INFO   Creating (0-1)/1 artifacts
  | 2020-10-22 11:17:41 INFO   Uploading artifact ec9a32da-7c90-48ba-8db8-f913e33e796b tmp/tmp.Z70e6hNAQk (54525 bytes)
  | [Thu Oct 22 11:17:43 UTC 2020][error] == SSL CONFIGURATION TEST FAILED ==
  | [Thu Oct 22 11:17:43 UTC 2020][error] Found 1 SSL config violations not whitelisted by ssl_filters.jq file
  | [Thu Oct 22 11:17:43 UTC 2020][error] Test failures may be caused by changes to https://github.com/drwetter/testssl.sh
  | [Thu Oct 22 11:17:43 UTC 2020][error] testssl.sh was last changed on Tue Oct 20 21:00:02 2020 +0200
  | [Thu Oct 22 11:17:43 UTC 2020][error] Violations (excluding whitelisted):
  | [
  | {
  | "id": "scanProblem",
  | "ip": "<IP_ADDRESS>/<IP_ADDRESS>",
  | "port": "10155",
  | "severity": "FATAL",
  | "finding": "Can't connect to '<IP_ADDRESS>:10155'\nMake sure a firewall is not between you and your scanning target!"
  | }
  | ]
  | /usr/bin/buildkite-agent
  | Deploy Failed - Uploading logs to buildkite
  | 2020-10-22 11:17:44 INFO   Found 3 files that match "logs/*"
  | 2020-10-22 11:17:44 INFO   Creating (0-3)/3 artifacts
  | 2020-10-22 11:17:44 INFO   Uploading artifact 6642c7f7-8f32-44f4-a1cf-f9d2c16862a9 logs/all (1874609 bytes)
  | 2020-10-22 11:17:44 INFO   Uploading artifact f031baf2-b17b-4740-be2f-d42fae9aa514 logs/deploy (896108 bytes)
  | 2020-10-22 11:17:44 INFO   Uploading artifact 79448e20-02b4-469d-9545-33e50b9c19b3 logs/remaining (978931 bytes)
  | [Thu Oct 22 11:17:46 UTC 2020][info] Killing background processes
  | [Thu Oct 22 11:17:46 UTC 2020][info] Exiting with 1
  | Attempting to clean up docker container automate-24792-4256
  | automate-24792-4256
  | ------------------------------------------------------------
  | To run this test locally:
  |
  | integration/run_test integration/tests/security.sh
  |
  | ------------------------------------------------------------
  | 🚨 Error: The command exited with status 1
  |

It looks like the testssl call, which checks all open ports, cannot connect to the new service, sample-data-service.
Is it supposed to be running at all times? Or something you selectively start or do not start? I guess that either the port should be excluded from the scan targets or we should check that it really comes online. 🤔

Nevermind, the description says that you have to select it. I guess the testssl deployment (i.e. the "security" test run) doesn't do it.

@vsingh-msys I've pushed a commit enabling the sample-data product for the security test. Let's see what happens now 😄

Looks like the security test now is green. ✔

Yeah, thanks @srenatus

Hoping everything is as expected, merging this PR so proceeding with the further roadmap. :crossed_fingers:


[WIP] Hydroform provisioning API implementation

Initial implementation of provisioning API.
Added:

Cluster type
Provisioner interface
...

See https://github.com/kyma-project/kyma/issues/5492

/test all

@igor-karpukhin - PROW is reporting a merge conflict in OWNERS file.
CONFLICT (add/add): Merge conflict in OWNERS


⚠ Bofrost.fr has degraded performance

In 71877a9, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1730 ms

Resolved: Bofrost.fr performance has improved in 8d72942 after 25 minutes.


"Bag of holding" abstraction pattern

@hawkw this is ready for review IMO, but relies on https://github.com/jamesmunns/forth3/pull/19 being landed first


Don't set tabindex on panels

From internal issue:

[...] a tabindex on the full panel is really only appropriate when it entirely consists of text (or the panel is large and the next focusable element is way down in the DOM). But even then, a heading with a tabindex is usually better than a full panel with one.

Ref: https://github.com/github/github/issues/137001

In the case of Preview tab, a tabindex is appropriate because it is a panel full of text and we don't control the headings. Hence my suggestion in the thread:

With this clarification we might introduce a generic marker for tabpanels that has a primary focusable area to avoid tabindex being set to the panel.

I saw that and I read the whole thread as it was up to implementer to make sure the panel had a focusable area. So in the preview tab should just have a tabindex="0" in the markup.
Could you elborate on what a "general marker" is in this context?


Move variable limits to ansible/group_vars/all

regarding distributed deployment, because distributed/group_vars/all and ansible/group_vars/all also don't define limits variable, and - name: (re)start container ansible task has a env "LIMITS_ACTIONS_INVOKES_PERMINUTE": "{{ limits.actions.invokes.perMinute }}", so the deployment wil be failed, the ansible task reports the variable limits doesn't be defined
Currently, loca, mac, docker-machine in its own all file also have variable limits, but for distributed,it doesn't have variable limits.
How to solve this question for distributed and has no influences on other envs, i think the best way is move the variable limits to ansible/group_vars/all, all envs can inherit limits value from that file.

Did you verify it's still possible to override those limits per env then?

Sorry, I will test it.

@markusthoemmes , i have tested local and distributed env, it is ok.
But for mac and docker-machine, i don't have these envs in my local, so can't test it.
But i am sure for mac and docker-machine, it will work well, why?
You can see variable defaultLimits  is defined in ansible/groups_vars/all only,
the - name: (re)start controller ansible task has a ENV "DEFAULTLIMITS_ACTIONS_INVOKES_PERMINUTE": "{{ defaultLimits.actions.invokes.perMinute }}". so after modified for limits, limits and defaultLimits are symmetrical

@ningyougang it is key though, that you are able to override limits in an environment, which is why the defaultLimits are global and limits are "local". I agree the existing scheme isn't perfect, in fact it is quite wrong with the recent changes now.
What we should do:

Remove defaultLimits, have only limits
Make each key in limits overridable, such as

limits:
  invocationsPerMinute: "{{ limit_invocations_per_minute | default(120) }}"
  concurrentInvocations: "{{ limit_invocations_concurrent | default(100) }}"
  concurrentInvocationsSystem:  "{{ limit_invocations_concurrent_system | default(5000) }}"
  firesPerMinute: "{{ limit_fires_per_minute | default(60) }}"
  sequenceLength: "{{ limit_sequence_length | default(50) }}"

That is: It adjusts the wording to conform with the UserLimits class. It also allows selective overriding per environment (by defining one of the limit_... variables), but keeps defaults up top.
What do you think?

@markusthoemmes ,for defaultLimits and limits, i just know it is using for benchmarks test,  i don't know here why remove defaultLimits, if remove, below statements will also be removed
      "DEFAULTLIMITS_ACTIONS_INVOKES_PERMINUTE": "{{ defaultLimits.actions.invokes.perMinute }}"
      "DEFAULTLIMITS_ACTIONS_INVOKES_CONCURRENT": "{{ defaultLimits.actions.invokes.concurrent }}"
      "DEFAULTLIMITS_TRIGGERS_FIRES_PERMINUTE": "{{ defaultLimits.triggers.fires.perMinute }}"
      "DEFAULTLIMITS_ACTIONS_INVOKES_CONCURRENTINSYSTEM": "{{ defaultLimits.actions.invokes.concurrentInSystem }}"
      "DEFAULTLIMITS_ACTIONS_SEQUENCE_MAXLENGTH": "{{ defaultLimits.actions.sequence.maxLength }}"

Has any bad influences?

That's the thing: We don't need both. We used to need both because we didn't have a good way to have per environment overridable settings. We do so now though, with the approach I outlined.

@markusthoemmes  i have removed defaultLimits from ansible/group_vars/all and have limits only

@ningyougang great, can you alter the scala code as well?

Throw out all usages of default limits
Throw out the fallback mechanism of WhiskConfig
Throw out optional arguments alltogether.

I can help you pick it up if you need assistance.

@markusthoemmes , i have modified again, please review again ^^

@ningyougang This looks super awesome, exactly what I meant! 🎉

@markusthoemmes @rabbah , have modified ^^

@markusthoemmes @rabbah rebase again and test.


Should not unbind foreign event handlers

Hello and thanks for a great plugin!
I found out that other components that bind the documents resize event stop working after having dragged the splitter. I believe this is because in the mouseDownHandler all resize event handlers are unbound, not just the one split-pane registered:
$(document).unbind(moveEvent);

One possible solution would perhaps be to use namespaces when binding and unbinding events?
Regards
Andreas

Thanks for reporting this!
I has been fixed in v0.4.1.

Thanks! It seems to be working now.


Create prerelease to harmonize with other projects

Release new version

[ ] Update Readme files
[x] Create release front page

[x] Getting Started
[x] Version information

[ ] Build solution to create deliverable and publish the installation package
[x] Update and publish the code help documentation
[x] Publish release
[x] Update the repository front page
[x] Update the GitHub pages documentation
[ ] Close this issue and the parent milestone

The new release 2.0.0-Alpha published.


Paging is not working properly

If page size is grate than size of result set, the result contains copies to fill up to the page size.
See org.odpi.egeria.connectors.ibm.igc.repositoryconnector.IGCOMRSMetadataCollection.findEntitiesByProperty
line 1330:                     if (pageSize == 0 || (pageSize > 0 && entityDetails.size() < pageSize)) {
entities are added to fill up entityDetails up to pageSize
If page size has divider of the size of result set, the function org.odpi.egeria.connectors.ibm.igc.repositoryconnector.IGCRepositoryHelper.processResultsForMapping(EntityMapping, List, ObjectCache, String, String, List, SearchProperties, int, SearchClassifications, String, SequencingOrder, int)
throws at line 526: org.odpi.egeria.connectors.ibm.igc.clientlibrary.errors.IGCConnectivityException: Request failed -- check IGC environment connectivity and authentication details.

Paging may indeed have issues today; however, I wouldn't expect it to be throwing exceptions like this...  Can you confirm the version of IGC you're working against?
For example, there is a known issue in v<IP_ADDRESS>sp6 where IGC's own paging (via its REST API) basically does not work.

Mandy mentioned another issue, where if the pageSize is greater than the actual number of results (eg. a pageSize of 100 but only 5 actual results), the list seems to be filled up with duplicates to reach the full size of 100.  I'll try to reproduce on my side...

I've tried reproducing, but have not had success in replicating this last problem regarding filling-up to pageSize...
Running findEntitiesByProperty with the following criteria:
{
	"class": "EntityPropertyFindRequest",
	"typeGUID": "0db3e6ec-f5ef-4d75-ae38-b7ee6fd6ec0a",
	"pageSize": 100,
	"matchCriteria": "ALL",
	"matchProperties": {
		"class": "InstanceProperties",
		"instanceProperties": {
			"displayName": {
				"class": "PrimitivePropertyValue",
				"instancePropertyCategory": "PRIMITIVE",
				"primitiveDefCategory": "OM_PRIMITIVE_TYPE_STRING",
				"primitiveValue": ".*\\QAddress\\E.*"
			}
		}
	}
}

In an environment where there are 6 such matches only returns 6 results (not the full pageSize of 100).
If I revise the query to remove any search conditions, using the following:
{
	"class": "EntityPropertyFindRequest",
	"typeGUID": "0db3e6ec-f5ef-4d75-ae38-b7ee6fd6ec0a",
	"pageSize": 100
}

... in an environment with 43 terms, I again only receive 43 results in the response (not the full pageSize of 100).
The particularly line of code referenced (line 1330 in IGCOMRSMetadataCollection.findEntitiesByProperty) exists to short-circuit the search process if there is already a full page of results (by avoiding running additional searches when the results of those additional searches would not end up on the page requested by the user anyway).
I've also, in the latest master for the connector, changed the various RuntimeExceptions (like IGCConnectivityException) over to checked exceptions, and these should all now be converted into RepositoryErrorExceptions and a full stack trace included.  Therefore, if you could please update the connector to the latest from master and re-run your scenario that produced that last exception we should have greater detail from the full stack trace on precisely what the error is (it appears to be something problematic at the IGC REST API level based on what the Java client is trying to communicate to it -- but the full stack should include details on what it attempted to request and the error from IGC's side (401, 403, 500, etc)).

Perhaps we've misunderstood that last point, though -- I can see that if I cycle through pages of results (eg. pageSize of 2 in the scenario above where there are actually 43 results), regardless of the page I request (by changing the "offset"), each page contains the same 2 results.  I'm assuming that this is the actual first issue?


JSON::Serializable leads to a compilation error if included into Exception child

See https://carc.in/#/r/5d22, also see https://carc.in/#/r/5da3. I believe the issue can be narrowed, but I can't formulate it right.

The error says that CallStack.new doesn't accept a pullparser, which is because CallStack isn't serializable. Exception contains a CallStack. So this isn't a bug. You should be able to redefine @callstack with an ignore annotation.

Sorry, @RX14, could you please elaborate with a working example?

@vladfaust https://carc.in/#/r/5da6

Awesome, @z64, thank you!

This should work but doesn't: https://carc.in/#/r/5daa

Yep, I was expecting including JSON::Serializable only into custom Error to work, because I never need to (de)serialize a plain Exception.

@asterite my example does that and still fails.

It seems putting an annotation over an inherited instance var doesn't work. I will try to take a look at it if I have time.
Reduced:
require "json"

class Foo
  @x : Int32?
end

class Bar < Foo
  @[JSON::Field(ignore: true)]
  @x : Int32?
end

def foo
  {% puts Foo.instance_vars.first.annotation(JSON::Field) %}
  {% puts Bar.instance_vars.first.annotation(JSON::Field) %}
end

foo

It prints nil in both cases but it should print the annotation in both cases.
(I would create a separate issue for this, JSON::Serializable is just a side-effect)

Or, well, just reopen Exception and mark cause as ignored, like one of the snippets above (please put the snippets here, it's hard to follow the conversation with just links pointing to play)

(so I won't take a look at this right now because it has a simple workaround)

it should print the annotation in both cases.

Really? I don't think adding an annotation in a subclass should add it in the parent.

There's only one instance var, inherited

Hm, yeah true. It might still be unexpected to change the parent scope.


[Kto] torch_dtype kwargs fix

since the kwargs is a dict the torch_dtype might be a string but transformer needs the dtype

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


feat: add contributor over time graph to README

Hi, community!
To better present how our community grows, we develop a tool to show contributors growing history on https://github.com/api7/contributor-graph. Since we found it helpful, we think maybe if it could help some other community.
 It would be the same with stars that we would update the graph each day, so the link would always present the real-time data. There is some other stuff to play around with if you would like to give it a try~

HOW IT WORKS
We use Github API to get all commits, try to find the “Github way” to filter commits so the result data would be similar to Github, and then get the first commit time of each user.
Don't hesitate to tell us if there is a better place to present this graph other than this, or there are some other worries or other features you would like to have~🍻

Very cool graph, but not sure it's useful to add it to this already large README

Have to agree with @probablykasper - this would be better on our website in the community section.

Thanks for the PR! As suggested, maybe PR this to the tauri-docs repo so the documentation team can review it :)


Allow configuration from config besides/alongside annotation

It would be great to be able to say, change the browser used via a configuration value rather than the annotation by giving it a full class. Would make simply swapping the browser for tests much easier

@GregJohnStewart PR's are welcome and the project lead @ia3andy is fantastic. He is currently working on another extension but your proposals both sound great to me!

Nice! I might try to get something going in, no promises though unfortunately


XLA dumps are not generated after setting XLA_FLAGS="--xla_dump_to=/some/path"

I was running the unit test //tensorflow/compiler/tests:categorical_op_test_gpu and wanted to see the XLA dumps for this unit test. I set the --xla_dump_to to a correct path, but dump files were never generated (the setup is correct as for other tests, It can generate XLA dumps).
I tried to investigate this issue  further and I found that detailed_logging has been hard coded to false in this location. This value is being used later on in here to reset the dump_to path.
With this empty value for dump_to, it will never generate the files even though xla_dump_to has been set. This behavior is contradictive to the XLA documentation described here

Hi,
Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.


Issues with playlists

I'm hoping someone can help me out.  I'm tearing my hair out  trying to get playlists to work.
I have these playlists defined in navidrome:

Here's what I defined on the skill (along with the default ones)

Going down the line from the web devlopment interface:
"ask navi sonic play the playlist ton"
2024-04-09 17:22:42,854 - root - DEBUG - Request received: {'dialog_state': None,
 'intent': {'confirmation_status': 'NONE',
            'name': 'NaviSonicPlayPlaylist',
            'slots': {'playlist': {'confirmation_status': 'NONE',
                                   'name': 'playlist',
                                   'resolutions': None,
                                   'slot_value': None,
                                   'value': None}}},
 'locale': 'en-US',
 'object_type': 'IntentRequest',
 'request_id': 'amzn1.echo-api.request.39491dfc-7b60-41b8-b8f7-6112d4b4a875',
 'timestamp': datetime.datetime(2024, 4, 9, 17, 22, 42, tzinfo=tzlocal())}
2024-04-09 17:22:42,854 - root - DEBUG - In NaviSonicPlayPlaylist
2024-04-09 17:22:42,854 - root - DEBUG - In GeneralExceptionHandler
2024-04-09 17:22:42,855 - root - ERROR - General Exception: 'NoneType' object has no attribute 'value'
2024-04-09 17:22:42,855 - root - ERROR - Request Type Was: IntentRequest
2024-04-09 17:22:42,855 - root - ERROR - Intent Name Was: NaviSonicPlayPlaylist

"ask navi sonic play the playlist megadeth"
Same error as above.
"ask navi sonic play the playlist a. c. d. c."
(I typed AC/DC, it was converted to the above)
Looked for an album instead of playlist?
2024-04-09 17:25:21,261 - root - DEBUG - Response sent: {'api_response': None,
 'can_fulfill_intent': None,
 'card': None,
 'directives': None,
 'experimentation': None,
 'output_speech': {'object_type': 'SSML',
                   'play_behavior': None,
                   'ssml': "<speak>I couldn't find the album ACDC in the "
                           'collection.</speak>'},
 'reprompt': {'directives': None,
              'output_speech': {'object_type': 'SSML',
                                'play_behavior': None,
                                'ssml': "<speak>I couldn't find the album ACDC "
                                        'in the collection.</speak>'}},
 'should_end_session': False}

"ask navi sonic play the playlist progressive metal"
This seems to really break things.  No JSON response on the server.

ask navi sonic play the playlist wheel
2024-04-09 17:28:12,142 - root - DEBUG - Request received: {'dialog_state': None,
 'intent': {'confirmation_status': 'NONE',
            'name': 'AMAZON.FallbackIntent',
            'slots': None},
 'locale': 'en-US',
 'object_type': 'IntentRequest',
 'request_id': 'amzn1.echo-api.request.5a640574-c370-4d63-9883-b030f7a51a78',
 'timestamp': datetime.datetime(2024, 4, 9, 17, 28, 11, tzinfo=tzlocal())}
2024-04-09 17:28:12,143 - root - DEBUG - In GeneralExceptionHandler
2024-04-09 17:28:12,143 - root - ERROR - General Exception: Unable to find a suitable request handler
2024-04-09 17:28:12,143 - root - ERROR - Request Type Was: IntentRequest
2024-04-09 17:28:12,143 - root - ERROR - Intent Name Was: AMAZON.FallbackIntent
2024-04-09 17:28:12,143 - werkzeug - INFO - <IP_ADDRESS> - - [09/Apr/2024 17:28:12] "POST / HTTP/1.0" 200 -

ask navi sonic play the playlist wicked bangers
Worked!!
ask navi sonic play the playlist puscifer
2024-04-09 17:29:58,762 - root - DEBUG - Request received: {'dialog_state': None,
 'intent': {'confirmation_status': 'NONE',
            'name': 'NaviSonicPlayPlaylist',
            'slots': {'playlist': {'confirmation_status': 'NONE',
                                   'name': 'playlist',
                                   'resolutions': None,
                                   'slot_value': None,
                                   'value': None}}},
 'locale': 'en-US',
 'object_type': 'IntentRequest',
 'request_id': 'amzn1.echo-api.request.20687878-7609-456d-a935-886321294dc1',
 'timestamp': datetime.datetime(2024, 4, 9, 17, 29, 58, tzinfo=tzlocal())}
2024-04-09 17:29:58,763 - root - DEBUG - In NaviSonicPlayPlaylist
2024-04-09 17:29:58,763 - root - DEBUG - In GeneralExceptionHandler
2024-04-09 17:29:58,763 - root - ERROR - General Exception: 'NoneType' object has no attribute 'value'
2024-04-09 17:29:58,763 - root - ERROR - Request Type Was: IntentRequest
2024-04-09 17:29:58,763 - root - ERROR - Intent Name Was: NaviSonicPlayPlaylist

The last 3 playlists are stock install and do not exist but still give weird responses.

Hi @jagauthier
Apologies for the late reply.  If this is still an issue could you retest some of the playlists with these phrases?
"Alexa, open navi sonic"
<wait to hear "Ready">
"Play the playlist TON"
and see if that makes a difference, I use playlists regularly and don't have any problems.  I did have problems with the invocation at one point which I'm reasonably sure this was based on my accent.  I ended up changing the invocation to "Nimble Fire" as two words the Alexa would understand the majority of the time.


Calling connect manually during a reconnection breaks subsequent automatic reconnection

When open() or connect() is called during a reconnection the socket stops trying to reconnect, and if it does manage to reconnect, the next time it's disconnected it won't try to reconnect automatically (even though the options say that it should).
This appears to be because the subscriptions are destroy'd by the call to open() - so the reconnection loop gets broken when the reconnection timer is cleared. Looks like it's when the engineio socket fails to connect and emits an error event which is handled by errorSub, which contains a call to cleanup()
It doesn't start reconnecting again because the reconnecting flag has been on the manager and the backoff state isn't reset, so maybeReconnectOnOpen() won't trigger a new reconnect loop to start.
The behaviour I'd expect for calling connect during a reconnection is that the reconnection is immediately retried and the backoff state is reset - useful for implementing a 'reconnect now' button for users to force reconnections.

I've submitted a pull request that I think fixes this behaviour, but the fix isn't ideal. It adds a flag to the public Manager.open / Manager.connect API that determines whether or not the backoff state should be reset, so might not be an acceptable fix.
Maybe someone that knows the code better can see a better solution!

Fixed in https://github.com/socketio/socket.io-client/pull/853


Issue with pixel type UINT16

Hello,
I would like to report an issue with your plugin in Napari. I installed everything and followed your guide on the GitHub page.
When I want to run the spitfire deconvolution in Napari, I get an error (see below). I tried to avoid the pixel type uint16 but unfortunately, the .tif format is always in this pixel type.
Can you please help me? Many thanks in advance for any type of help or suggestions.
Error from CMD:
""
File ~\miniconda3\envs\napari-env\lib\site-packages\sdeconv\deconv\spitfire.py:335, in spitfire(image=<class 'pims.frame.Frame'> (22, 166, 662, 659) uint16, psf=<class 'numpy.ndarray'> (65, 256, 256) float32, weight=0.6, delta=1.0, reg=0.995, gradient_step=0.01, precision=1e-07, pad=13, observers=[<napari_sdeconv.framework.SProgressObserver object>])
333     filter.add_observer(observer)
334 if isinstance(image, np.ndarray):
--> 335     return filter_(torch.tensor(image).to(SSettings.instance().device))
filter_ = <sdeconv.deconv.spitfire.Spitfire object at 0x0000014DD3CE8580>
image = <class 'pims.frame.Frame'> (22, 166, 662, 659) uint16
336 return filter_(image)
TypeError: can't convert np.ndarray of type numpy.uint16. The only supported types are: float64, float32, float16, complex64, complex128, int64, int32, int16, int8, uint8, and bool.
""
My napari version info:
napari: 0.4.18
Platform: Windows-10-10.0.19045-SP0
Python: 3.9.18 | packaged by conda-forge | (main, Aug 30 2023, 03:40:31) [MSC v.1929 64 bit (AMD64)]
Qt: 5.15.2
PyQt5: 5.15.10
NumPy: 1.26.2
SciPy: 1.11.4
Dask: 2023.11.0
VisPy: 0.12.2
magicgui: 0.8.0
superqt: 0.6.1
in-n-out: 0.1.9
app-model: 0.2.2
npe2: 0.7.3
OpenGL:

GL version: 4.6.0 NVIDIA 536.40
MAX_TEXTURE_SIZE: 32768

Thank you
Roman

hi, you can convert your data to 32 bit in Fiji.

Oh thank you. It worked although that was the first I tried yesterday without success but today is a new day.
I have a question regarding a user guide and GPU acceleration.
Is it possible in Napari, python or FIJI to run Spitfire decon on GPU?
Also, is there a user guide for dummies to handle the algorithm, change iterations and explain other functions of the spitfire ?
Thank you for all your help and tips or directions.
Roman

Hello, yes Spitfire napari plugin is implemented using sdeconv library that is based on pytorch. So it automatically runs on GPU when pytorch finds the GPU. If it does not run on the GPU, it might be because pytorch GPU dependencies are missing.
The two main parameters of the Spitfire methods are the weight and the regularisation:
The "weight" controls the sparsity of the image. This means that if you have fiew signal (example vesicules) you need a small value like 0.1. If you have a non-sparse signal, you can put it at 0.9.
You can see the "regularisation" as the amount of noise filtering. In a perfect image without noise, the regularisation parameter should be 1 in the sdeconv code. Decreading the regularization increase the noise filtering. In general values around 0.995 is a good choice to start finding the best regularisation.