Unable to use EOSJS in a Typescript Project

Version of EOSJS
v20.0.0
Describe the bug
I'm trying to build a Typescript module which users can use to help test their smart contracts. This declares EOSJS as a peer dependency (and dev dependency)
To Reproduce
Steps to reproduce the behavior:

Include Api from EosJS in a Typescript project.
Build with tsc.

Expected behavior
Build succeeds
Build Output
node_modules/eosjs/dist/eosjs-api.d.ts:19:18 - error TS2304: Cannot find name 'TextEncoder'.

19     textEncoder: TextEncoder;
                    ~~~~~~~~~~~

node_modules/eosjs/dist/eosjs-api.d.ts:20:18 - error TS2304: Cannot find name 'TextDecoder'.

20     textDecoder: TextDecoder;
                    ~~~~~~~~~~~

node_modules/eosjs/dist/eosjs-api.d.ts:45:23 - error TS2304: Cannot find name 'TextEncoder'.

45         textEncoder?: TextEncoder;
                         ~~~~~~~~~~~

node_modules/eosjs/dist/eosjs-api.d.ts:46:23 - error TS2304: Cannot find name 'TextDecoder'.

46         textDecoder?: TextDecoder;
                         ~~~~~~~~~~~

node_modules/eosjs/dist/eosjs-jsonrpc.d.ts:9:28 - error TS2304: Cannot find name 'Request'.

9     fetchBuiltin: (input?: Request | string, init?: RequestInit) => Promise<Response>;
                             ~~~~~~~

node_modules/eosjs/dist/eosjs-jsonrpc.d.ts:9:53 - error TS2304: Cannot find name 'RequestInit'.

9     fetchBuiltin: (input?: Request | string, init?: RequestInit) => Promise<Response>;
                                                      ~~~~~~~~~~~

node_modules/eosjs/dist/eosjs-jsonrpc.d.ts:9:77 - error TS2304: Cannot find name 'Response'.

9     fetchBuiltin: (input?: Request | string, init?: RequestInit) => Promise<Response>;
                                                                              ~~~~~~~~

node_modules/eosjs/dist/eosjs-jsonrpc.d.ts:17:35 - error TS2304: Cannot find name 'Request'.

17         fetch?: (input?: string | Request, init?: RequestInit) => Promise<Response>;
                                     ~~~~~~~

node_modules/eosjs/dist/eosjs-jsonrpc.d.ts:17:51 - error TS2304: Cannot find name 'RequestInit'.

17         fetch?: (input?: string | Request, init?: RequestInit) => Promise<Response>;
                                                     ~~~~~~~~~~~

node_modules/eosjs/dist/eosjs-jsonrpc.d.ts:17:75 - error TS2304: Cannot find name 'Response'.

17         fetch?: (input?: string | Request, init?: RequestInit) => Promise<Response>;
                                                                             ~~~~~~~~

node_modules/eosjs/dist/eosjs-serialize.d.ts:85:18 - error TS2304: Cannot find name 'TextEncoder'.

85     textEncoder: TextEncoder;
                    ~~~~~~~~~~~

node_modules/eosjs/dist/eosjs-serialize.d.ts:86:18 - error TS2304: Cannot find name 'TextDecoder'.

86     textDecoder: TextDecoder;
                    ~~~~~~~~~~~

node_modules/eosjs/dist/eosjs-serialize.d.ts:94:23 - error TS2304: Cannot find name 'TextEncoder'.

94         textEncoder?: TextEncoder;
                         ~~~~~~~~~~~

node_modules/eosjs/dist/eosjs-serialize.d.ts:95:23 - error TS2304: Cannot find name 'TextDecoder'.

95         textDecoder?: TextDecoder;
                         ~~~~~~~~~~~

node_modules/eosjs/dist/eosjs-serialize.d.ts:235:120 - error TS2304: Cannot find name 'TextEncoder'.

235 export declare function serializeActionData(contract: Contract, account: string, name: string, data: any, textEncoder: TextEncoder, textDecoder: TextDecoder): string;
                                                                                ~~~~~~~~~~~

node_modules/eosjs/dist/eosjs-serialize.d.ts:235:146 - error TS2304: Cannot find name 'TextDecoder'.

235 export declare function serializeActionData(contract: Contract, account: string, name: string, data: any, textEncoder: TextEncoder, textDecoder: TextDecoder): string;
                                                                                ~~~~~~~~~~~

node_modules/eosjs/dist/eosjs-serialize.d.ts:237:148 - error TS2304: Cannot find name 'TextEncoder'.

237 export declare function serializeAction(contract: Contract, account: string, name: string, authorization: Authorization[], data: any, textEncoder: TextEncoder, textDecoder: TextDecoder): SerializedAction;
                                                                                ~~~~~~~~~~~

node_modules/eosjs/dist/eosjs-serialize.d.ts:237:174 - error TS2304: Cannot find name 'TextDecoder'.

237 export declare function serializeAction(contract: Contract, account: string, name: string, authorization: Authorization[], data: any, textEncoder: TextEncoder, textDecoder: TextDecoder): SerializedAction;
                                                                                ~~~~~~~~~~~

node_modules/eosjs/dist/eosjs-serialize.d.ts:239:149 - error TS2304: Cannot find name 'TextEncoder'.

239 export declare function deserializeActionData(contract: Contract, account: string, name: string, data: string | Uint8Array | number[], textEncoder: TextEncoder, textDecoder: TextDecoder): any;
                                                                                ~~~~~~~~~~~

node_modules/eosjs/dist/eosjs-serialize.d.ts:239:175 - error TS2304: Cannot find name 'TextDecoder'.

239 export declare function deserializeActionData(contract: Contract, account: string, name: string, data: string | Uint8Array | number[], textEncoder: TextEncoder, textDecoder: TextDecoder): any;
                                                                                ~~~~~~~~~~~

node_modules/eosjs/dist/eosjs-serialize.d.ts:241:177 - error TS2304: Cannot find name 'TextEncoder'.

241 export declare function deserializeAction(contract: Contract, account: string, name: string, authorization: Authorization[], data: string | Uint8Array | number[], textEncoder: TextEncoder, textDecoder: TextDecoder): Action;
                                                                                ~~~~~~~~~~~

node_modules/eosjs/dist/eosjs-serialize.d.ts:241:203 - error TS2304: Cannot find name 'TextDecoder'.

241 export declare function deserializeAction(contract: Contract, account: string, name: string, authorization: Authorization[], data: string | Uint8Array | number[], textEncoder: TextEncoder, textDecoder: TextDecoder): Action;
                                                                                ~~~~~~~~~~~

Desktop (please complete the following information):

OS: Mac OS X 10.14.4
Browser: None, this issue occurs during typescript compile.
Version: Typescript 3.4.1

Additional context
I can see in the source file that TextEncoder and TextDecoder types seem to be global. Shouldn't they be imported from somewhere else as usual? I didn't dig much farther.
Not sure if this is related to #457 or not as there's no context in that issue about what the build problem actually was.

Ok, I've managed to get the build to work, but it'd be good to document how I did it.

Adding @types/text-encoding as a dev dependency fixes the errors about TextEncoding/TextDecoding.
Adding dom to my libs in tsconfig.json makes the Request, RequestInit, and Response errors go away as it brings in the types for fetch that node doesn't have by default. I'd love a better way to do this, but this works for now.

So, to fix:

npm i --save-dev @types/text-encoding
Add dom to your lib section tsconfig.jsonas follows:

{
	"compilerOptions": {
		"lib": [..., "dom"]
	},
}

Would this be best documented in the Readme? Happy to do a PR.

Including the dom lib is almost always used with the es6 or es7 libs.  While this is new to Typscript 2, it is relatively common practice.  We are currently looking into the best way to remove the need to install @types/text-encoding in consuming applications, but for now a change to the README would be great.  If you go ahead and add those two points (below NodeJS dependency section of installation) for clarity on how to integrate EOSJS into a Typescript project, we will approve it.  I'll close this once the PR is approved for the README change.

^ I created the pull request.

Documented in #568


feat: exports core in package.json and export buildRegularRoute

Description
Add core in the exports entry of package.json in order to use both methods generatePreservedRoutes and generateRegularRoutes.
Use case
As the Vite's glob import API patterns are resolved relative to project root, if you specify a custom root vite config, generouted won't work as it should. Given this vite config file:
// vite.congig.js
import { defineConfig } from 'vite'
import react from '@vitejs/plugin-react'

export default defineConfig({
  plugins: [react()],
  root: resolve(process.cwd(), 'src'),
})

and this app structure:
my-app
├── package.json
├── src
│   ├── index.html
│   ├── index.tsx
│   ├── pages
│   │   ├── 404.tsx
│   │   ├── _app.tsx
│   │   ├── index.tsx
│   └── public
│       └── translations
├── tsconfig.json
└── vite.config.mjs

Then if you import the Routes from generouted/react-router, you won't have any route generated (expect a default app route and a default 404 route) as the folder used by the glob pattern in https://github.com/oedotme/generouted/blob/e6eb81a03ff2d5bff6e18ffdefab12ed7dbce516/src/react-router.tsx#L10...L11 does not exists.
The solution proposed here is to exports methods from core and being able to build routes from other glob pattern. Like this:
import React from 'react';
import { Outlet, RouterProvider, createHashRouter } from 'react-router-dom';
import { generatePreservedRoutes, generateRegularRoutes } from 'generouted/core';
import { buildRegularRoute } from 'generouted/react-router';
import type { Module as ReactRouterDomModule } from 'generouted/react-router';

function generateRouter(app: React.FunctionComponent) {
  const AppComponent = app;

  const appRoutes = generateRegularRoutes(
    import.meta.glob<ReactRouterDomModule>([
      '/pages/**/[\\w[]*.{jsx,tsx}',
      '!**/(_app|404).*',
    ]),
    buildRegularRoute,
    [/\/pages\/|\.(jsx|tsx)$/g, ''],
  );
  const routes = [
    { element: <AppComponent children={(
      <>
        <Outlet />
      </>
    )} />, children: [...appRoutes]},
  ];

  const router = createHashRouter(routes);
  return () => <RouterProvider router={router} />;
}

Hey @Jisay! Thanks for the proposal!
I'm thinking of adding the /pages to the route pattern, which makes sense since Next.js used to support both /src/pages and /pages for defining routes. There's no need also to export the core modules, and I wouldn't recommend it. Instead you can access the core through generouted/src/core.
In this case you could have a copy of an integration in your project and replace the core imports ./core → generouted/src/core, then customize the glob directory:
import { Fragment, lazy, Suspense } from 'react'
import { createBrowserRouter, Outlet, RouterProvider } from 'react-router-dom'
import type { ActionFunction, RouteObject, LoaderFunction } from 'react-router-dom'

import { generatePreservedRoutes, generateRegularRoutes } from 'generouted/src/core'

type Element = () => JSX.Element
type Module = { default: Element; Loader: LoaderFunction; Action: ActionFunction; ErrorElement: Element }

const PRESERVED = import.meta.glob<Module>('/pages/(_app|404).{jsx,tsx}', { eager: true })
const ROUTES = import.meta.glob<Module>(['/pages/**/[\\w[]*.{jsx,tsx}', '!**/(_app|404).*'])

const preservedRoutes = generatePreservedRoutes<Element>(PRESERVED)

const regularRoutes = generateRegularRoutes<RouteObject, () => Promise<Module>>(ROUTES, (module, key) => {
  const Element = lazy(module)
  const ErrorElement = lazy(() => module().then((module) => ({ default: module.ErrorElement })))
  const index = /index\.(jsx|tsx)$/.test(key) ? { index: true } : {}

  return {
    ...index,
    element: <Suspense fallback={null} children={<Element />} />,
    loader: async (...args) => module().then((mod) => mod?.Loader?.(...args)),
    action: async (...args) => module().then((mod) => mod?.Action?.(...args)),
    errorElement: <Suspense fallback={null} children={<ErrorElement />} />,
  }
})

const App = preservedRoutes?.['_app'] || Fragment
const NotFound = preservedRoutes?.['404'] || Fragment

export const routes = [...regularRoutes, { path: '*', element: <NotFound /> }]
const router = createBrowserRouter([{ element: <App children={<Outlet />} />, children: routes }])

export const Routes = () => {
  return <RouterProvider router={router} />
}

I don't think many people will use that, but it's accessible in case needed, without exposing many things which might be confusing.
Hope that helps!

I've added the support for /pages besides /src/pages, so the example above should work now! Here's the commit 45b84c8

Hello @oedotme!
Thanks for support for pages and /src/pages. This is better than providing a Regexp as third param to generateRegularRoutes method :-)
It's OK for me to not have the core exported as there is an other solution.
But in order to avoid redefining Element and Module types and buildRoute param of generateRegularRoutes method, it should be a good idea to export those types and method in each router implementation. What do you think?
I will update my branch and pull request with this.

I have tried to import from generouted/src/core but I got the following error when vite is running:
The following dependencies are imported but could not be resolved:

  generouted/src/core (imported by ~/generouted/examples/react-router/basic/src/main.tsx)

Are they installed?

Is there something I miss?

I found a workaround for the previous this issue . I had to add an alias for generouted/src/core in my vite.config.js file that point to the core.ts file:
// vite.config.js
export default defineConfig({
  ...
  resolve: {
    alias: {
      ...
      'generouted/src/core':
        '../../../../../node_modules/generouted/src/core.ts', // temp workaround in order to import correctly the src file
    },
  },
  ...
})

It seems to be a vite bug but I didn't found an other solution (don't know if you have a better one :-)).
So this PR simply:

exports some types declared in each router implementation.
exports a buildRegularRoute method in each router implementation.

I did export the core in a quick release, as it will be referenced in other opened issues.

Great, thanks!
For the rest, ok for me. I will create a custom implementation. I close this PR ;-)


unit tests

Coverage increased (+2.7%) to 31.837% when pulling 36feb4a918937c364ff6c7819dcdd98ea3dc9301 on partition into e4c938ddba2012d218155b1490af8eeddb0c5acb on master.


Merge upstream

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@69b0ebc). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #34   +/-   ##
=========================================
  Coverage          ?   67.41%
=========================================
  Files             ?       20
  Lines             ?     1774
  Branches          ?        0
=========================================
  Hits              ?     1196
  Misses            ?      519
  Partials          ?       59

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69b0ebc...8e99a53. Read the comment docs.


Meilisearch doesn't provide guidance on creating a master key

Describe the bug
Although Meilisearch requires a master key in production environments, there is no guidance on how a user should generate this key (that I could find!).
To Reproduce
Steps to reproduce the behavior:

Go to https://docs.meilisearch.com/guides/advanced_guides/authentication.html#master-key
Read about master keys
Don't understand how to create a master key

Expected behavior
I want to get a clear understanding of how to create a master key in a way that won't compromise the security of my meilisearch instance. This would likely reference the number of bits of entropy I should be looking for (256bit maybe?), as well as some example commands I could use to generate it (e.g. openssl rand -hex $((256/8)) on Linux).
Additional context
Secure randomness is a tough topic, and one that's easy to get wrong. The only previous guidance I found on this for meilisearch was on the slack channel (https://meilicommunity.slack.com/archives/CP9DVS1RQ/p1590509143400300) where there was a suggestion to use https://randomkeygen.com/ - unfortunately, that page has a whole swathe of options with varying amounts of entropy and it's not immediately clear which ones to choose (the immediate visible ones at the top are probably the worst!).
As an example, sccache has a built-in command sccache-dist auth generate-jwt-hs256-key that will use the OS random number generator to generate a hardcoded reasonable number of bytes. That documentation also references the openssl command as a way to generate secure tokens.

Hello @aidanhs,
Thanks for your feedback!
I'm transferring this issue to the documentation repository!


PipInstaller.install_directory() called with invalid 'update' kwarg

[x] I am on the latest Poetry version.
[x] I have searched the issues of this repo and believe that this is not a duplicate.
[x] If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

OS version and name:  macOS 10.14
Poetry version:  0.12.5

Issue
58e3676c introduced update kwarg to PipInstaller.install_directory(), which is used in PipInstaller.install(). But it was removed later in e82ec7dd without removing it from the call in .install().

[TypeError]
install_directory() got an unexpected keyword argument 'update'

Exception trace:
 /Users/hermann/.poetry/lib/poetry/_vendor/py3.7/cleo/application.py in run() at line 94
   status_code = self.do_run(input_, output_)
 /Users/hermann/.poetry/lib/poetry/console/application.py in do_run() at line 88
   return super(Application, self).do_run(i, o)
 /Users/hermann/.poetry/lib/poetry/_vendor/py3.7/cleo/application.py in do_run() at line 197
   status_code = command.run(input_, output_)
 /Users/hermann/.poetry/lib/poetry/console/commands/command.py in run() at line 77
   return super(BaseCommand, self).run(i, o)
 /Users/hermann/.poetry/lib/poetry/_vendor/py3.7/cleo/commands/base_command.py in run() at line 146
   status_code = self.execute(input_, output_)
 /Users/hermann/.poetry/lib/poetry/_vendor/py3.7/cleo/commands/command.py in execute() at line 107
   return self.handle()
 /Users/hermann/.poetry/lib/poetry/console/commands/install.py in handle() at line 57
   return_code = installer.run()
 /Users/hermann/.poetry/lib/poetry/installation/installer.py in run() at line 76
   self._do_install(local_repo)
 /Users/hermann/.poetry/lib/poetry/installation/installer.py in _do_install() at line 287
   self._execute(op)
 /Users/hermann/.poetry/lib/poetry/installation/installer.py in _execute() at line 295
   getattr(self, "_execute_{}".format(method))(operation)
 /Users/hermann/.poetry/lib/poetry/installation/installer.py in _execute_install() at line 320
   self._installer.install(operation.package)
 /Users/hermann/.poetry/lib/poetry/installation/pip_installer.py in install() at line 28
   self.install_directory(package, update=update)

Any update on this?


CA Issuer's certificate is not bundled with certificate

Describe the bug:
CA Issuer's certificate is no longer bundled with the resulting issued certificate.
Expected behaviour:
The CA Issuer's certificate is bundled within tls.crt.
Steps to reproduce the bug:

Create a CA Issuer
Create a Certificate using the CA Issuer as the issuerRef
View the resulting tls.crt in the secret

Anything else we need to know?:
Environment details:

Kubernetes version (e.g. v1.10.2): 1.12
cert-manager version (e.g. v0.4.0): 0.7.0
Install method (e.g. helm or static manifests): helm

/kind bug

The actual CA itself is purposely not included as part of the tls.crt section, in favour of storing it only in the ca.crt field.
The intermediate certificate will be included if it exists however, meaning the tls.crt should form a certificate chain to the root (ca.crt).
Hope that makes sense, and please let me know if that isn't what you are seeing!

Thanks for clarifying @munnerz! In previous releases, the ca.crt was bundled, correct? If so, what was the reason this has changed?

Presumably, your issuer is configured with a self signed root? If so, there's an explicit check since v0.6 that excludes self signed roots being a part of certificate chains: https://github.com/jetstack/cert-manager/blob/2f99b3155acb8fe61400c0cdae0196d1c08f5630/pkg/util/pki/csr.go#L250-L253
The pull request that changed this: https://github.com/jetstack/cert-manager/pull/1077

Thank you for pointing me to the information @munnerz


Bitcoin network validation

Codecov Report
Attention: Patch coverage is 14.58333% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 36.63%. Comparing base (2d44997) to head (3bb0568).

Files
Patch %
Lines

src/app.rs
0.00%
23 Missing :warning:

src/bin/nomic.rs
0.00%
15 Missing :warning:

src/utils.rs
66.66%
3 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #293      +/-   ##
===========================================
- Coverage    36.84%   36.63%   -0.21%
===========================================
  Files           25       25
  Lines         9459     9501      +42
===========================================
- Hits          3485     3481       -4
- Misses        5974     6020      +46

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


refactor: general cleaning up of the tree module

Overview
Description of the changes proposed in this pull request:
There shouldn't be any functional changes in this PR, just cleaning up of the code and documentation in 2 files

shap/explainers/_tree.py
tests/explainers/test_tree.py : refactor sklearn into its own class, similar to what was done for LGBM in an earlier PR.

Mini port of the (now stale) PR: #1306
Checklist

[X] All pre-commit checks pass.
[x] Unit tests added (if fixing a bug or adding a new feature)
[ ] Added entry to CHANGELOG.md (if changes will affect users)

Thanks for the PR! It look likes a good cleanup.
There is a mix of useful functional changes (e.g. moving tests to classes, adding tests, changing documentation), and purely stylistic changes (e.g. adding spacing, commas, newlines).  Stylistic changes are largely down to personal preference and prone to "bike-shedding", and lead to a large diff.
I would like to propose the general rule:

PRs with non-style changes should generally avoid any style changes to existing code, and
PRs with style changes should have zero non-style changes, and ideally should be implemented with automated tools to remove risk of human error (e.g. ruff, isort, black, etc).

I'd be happy to approve this PR once other threads are resolved. However, for future PRs I'd like to suggest we adopt a more strict separation of style & non-style changes.

Thanks @connortann , noted on the comment regarding style vs functional. Will come back to this PR and address the other comments later this week.


File pm.json not found

When attempting to install the server on a Windows PC, everything goes smoothly until 'npm run start' must be run - the process returns an error and says that the file pm.json cannot be found.
It should be worth nothing that, to get this far, package.json lines 72-76 had to be edited for Windows compatibility.
The script in question which fails is 'pm2 start pm.json'.

Did you run npm run build:dev before running npm run start? The first one is needed to compile servers file and create the pm.json file that serves to boot various servers with PM2.

Yes, I ran npm run build:dev first.

I have very limited Windows experience so I will not be of big help here. If you already have the pm.json file (npm run build:dev), pm2 is available (npm update), I am not sure what can go wrong. The idea behind npm run start is mainly to boot up the servers using the generated pm.json file: pm2 start pm.json, considering the first error you had was about not finding that file, maybe try using an absolute path? ( c:/.../pm.json? )

When I ran the command npm run build:dev, the console returned the message 'SET NODE_ENV=dev gulp servers pm'. It appears that I don't have pm.json in my server folder.

Try decomposing it into multiple commands maybe?

SET NODE_ENV=dev
gulp servers pm

If you really can't get it to work, I can probably start a windows VM this weekend but I doubt I will have time before that sadly :/

@noahdasanaike sorry I couldn't get on this sooner, did you manage to get it working? If not, what's your current setup/shell on Windows?

@zowesiouff Thanks for getting back to me on this; unfortunately I was not able to get the server running. I'm currently running Windows 10.

Ok I managed to get some stuff out but I still don't have a fully working Kin running on Win10:
Using Git Bash, those worked (export is needed, and no space between dev and &&)
export NODE_ENV=dev&& ./node_modules/.bin/gulp pm
Git bash doesn't seem to have a way to deal with symbolic link, so you need to use the prod version of gulp servers:
export NODE_ENV=prod&& ./node_modules/.bin/gulp servers
And then you can load pm2:
./node_modules/.bin/pm2 pm.json
That said, this seems a bit flaky, and I don't have enough time on my hands right now to dive deeper and/or get Kin's current scripts more portable. I would advise you at this point to launch a small Debian in a VM :) or wait for someone with more Windows expertise to help us out.


Problems and things that would make stufff easier for installation

pip install Diso doesn't seem  to install  for me . The wheels prebuilt ones for diff guassian rasteriz ,vox2seq and nvdiffrast can be found here https://github.com/MrForExample/Comfy3D_Pre_Builds . But diso  and diffoctreerast wheels i could'nt find and got errors when pip installing .
i could'nt figure out which one has python 311 and 2.51 and cuda 12.4  ,so ended up installing  2.5.1 + cuda 12.4 on python 11 comfui portable. maybe if there is a version , pointing will be helpfull .
appreciate your time , thanks

can run in comfui portable ？  it's cool


what is the format of "llava_val_coco_fmt.json"

In file vigc/tasks/caption_train_eval.py https://github.com/opendatalab/VIGC/blob/main/vigc/tasks/caption_train_eval.py#L14 , there is "ANN_FILE = "/mnt/petrelfs/hanxiao/working/llava_process/llava_val_coco_fmt.json"
what is the format about it?

when I change ANN_FILE to llava_val.json that is downloaded by https://drive.google.com/drive/folders/1yFTZlMR1KoFrPiVBYNncVsw5zOEKbj0s
Traceback (most recent call last):
  File "train.py", line 104, in <module>
    main()
  File "train.py", line 100, in main
    runner.train()
  File "/workdir/vigc/runners/runner_base.py", line 377, in train
    val_log = self.eval_epoch(
  File "/workdir/conda_envs/vigc/lib/python3.8/site-packages/torch/autograd/grad_mode.py", line 27, in decorate_context
    return func(*args, **kwargs)
  File "/workdir/vigc/runners/runner_base.py", line 466, in eval_epoch
    return self.task.after_evaluation(
  File "/workdir/vigc/tasks/caption_train_eval.py", line 128, in after_evaluation
    metrics = self._report_metrics(
  File "/workdir/vigc/common/dist_utils.py", line 112, in wrapper
    return func(*args, **kwargs)
  File "/workdir/vigc/tasks/caption_train_eval.py", line 143, in _report_metrics
    eval_ret = cocoeval.compute_metrics(cocoeval.results)
  File "/workdir/conda_envs/vigc/lib/python3.8/site-packages/mmpretrain/evaluation/metrics/caption.py", line 90, in compute_metrics
    coco_val = coco_caption_eval(eval_result_file, self.ann_file)
  File "/workdir/conda_envs/vigc/lib/python3.8/site-packages/mmpretrain/evaluation/metrics/caption.py", line 120, in coco_caption_eval
    coco = COCO(ann_file)
  File "/workdir/conda_envs/vigc/lib/python3.8/site-packages/pycocotools/coco.py", line 83, in __init__
    assert type(dataset)==dict, 'annotation file format {} not supported'.format(type(dataset))
AssertionError: annotation file format <class 'list'> not supported

it's a coco format llava data, we extracted it from llava150k as an eval set, you can make up it with following format:
{"annotations": [
    {"question_id": xxx, "image": "xxx", "question": "xxx?", "answer": ["xxx"]},
    ...,
]
}

@wufan-tb Can you share this file？
Traceback (most recent call last):
  File "train.py", line 104, in <module>
    main()
  File "train.py", line 100, in main
    runner.train()
  File "/workdir/vigc/runners/runner_base.py", line 377, in train
    val_log = self.eval_epoch(
  File "/workdir/conda_envs/vigc/lib/python3.8/site-packages/torch/autograd/grad_mode.py", line 27, in decorate_context
    return func(*args, **kwargs)
  File "/workdir/vigc/runners/runner_base.py", line 466, in eval_epoch
    return self.task.after_evaluation(
  File "/workdir/vigc/tasks/caption_train_eval.py", line 130, in after_evaluation
    metrics = self._report_metrics(
  File "/workdir/vigc/common/dist_utils.py", line 112, in wrapper
    return func(*args, **kwargs)
  File "/workdir/vigc/tasks/caption_train_eval.py", line 145, in _report_metrics
    eval_ret = cocoeval.compute_metrics(cocoeval.results)
  File "/workdir/conda_envs/vigc/lib/python3.8/site-packages/mmpretrain/evaluation/metrics/caption.py", line 90, in compute_metrics
    coco_val = coco_caption_eval(eval_result_file, self.ann_file)
  File "/workdir/conda_envs/vigc/lib/python3.8/site-packages/mmpretrain/evaluation/metrics/caption.py", line 121, in coco_caption_eval
    coco_result = coco.loadRes(results_file)
  File "/workdir/conda_envs/vigc/lib/python3.8/site-packages/pycocotools/coco.py", line 314, in loadRes
    res.dataset['images'] = [img for img in self.dataset['images']]
KeyError: 'images'

sure, I upload this file to google drive, you can download from here: https://drive.google.com/file/d/1efNW7_I4uOh-KBfbPLDQe83SphrSm35T/view?usp=sharing


Allows loading image from URL

Use case: in oculus browser, open image in new tab and copy paste its URL

Probably depends on https://github.com/steren/stereo-img/issues/14


doc: update lean 3 -> lean 4 in declarations.md

I didn't fully rewrite this file, but I updated the syntax and naming conventions of the examples in this file, and removed a few comments that were out of date for lean 4. (I didn't look deeply into how or where this md file is used; it might just need to be removed.)

@digama0 Note that this file is currently not reachable. We were trying to move the Lean 3 reference manual to Lean 4, but did not manage to finish. So, you are not going to see the effects of your changes on the website manual.
I am going to merge the PR because one day we may want to put back this page in the manual.


Add zip for Fold

similar to https://github.com/julien-truffaut/Monocle/pull/453

In fact, I don't think it is possible


feat: impl interval type

I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?

impl interval type in common time package.
impl DataType, Vector, Value trait for IntervalMonthDayNano.
fix bug https://github.com/GreptimeTeam/greptimedb/issues/1886

Checklist

[x]  I have written the necessary rustdoc comments.
[x]  I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)
closes https://github.com/GreptimeTeam/greptimedb/issues/1886

I tested this test case locally, but it passed, and I don't know how this error happened.

Next time, I think you could open a PR to add files like src/common/time/src/interval.rs first. This file has over 700 lines and doesn't depend on other changes in this PR.

Ok，Thank you for your suggestion.

@QuenKar There are some conflicts have to be resolved.

@QuenKar There are some conflicts that have to be resolved.

I solved it (•̀ᴗ• )


Screen recording problem

The new video files  (v1.10) now crash Adobe Premiere. The videos reproduce correctly on vlc, however Movies (windows 10 video player) presents some small freezing.
I've fixed the files by transcoding them with Handbrake. The transcoded videos work normally on all programs.

Thank you for your report.
Does the problem occur on both mkv and mp4 files?

Could you test if 8d75422d21e97bca5bee2f9ed88af05f1e7792d3 fixes the problem, please?
Here is a win64 binary (to replace in your v1.10): scrcpy.exe
SHA256: 8d79bd1062bd7a78b7bc9238052d17e5b8db099e8838d8462479f53cf8b98a50

[8d75422] scrcpy.exe still presents the same problems.
I haven't tested mkv files yet. I'll report later.

And if you retry v1.9 now, it works correctly?

yes, v1.9 records correctly.

Oh, in v1.10, I upgraded FFmpeg. Could you just replace av*.dll and sc*.dll from those in v1.9?

same issues after replacing dlls. It could be something to do with asynchronous recording?

same issues after replacing dlls

Let's do the reverse: take v1.9, and replace the dll by those from v1.10. Does it still work?

It could be something to do with asynchronous recording?

Once we eliminate all others possibilities… but for now, I don't know how asynchronous recording could produce this bug: the file is expected to be the same.

How do you stop recording? By closing the window? Does it say that the recording is complete in the logs?

How do you stop recording? By closing the window? Does it say that the recording is complete in the logs?

I close the window, here is the log:

INFO: scrcpy 1.10 https://github.com/Genymobile/scrcpy
f:\scrcpy\src\scrcpy-server.jar: 1 file pushed. 1.4 MB/s (22546 bytes in 0.016s)
INFO: Recording started to mp4 file: ..\raw.mp4
INFO: Initial texture: 1080x1920
INFO: Finishing recording...
INFO: Recording complete to mp4 file: ..\raw.mp4

Let's do the reverse: take v1.9, and replace the dll by those from v1.10. Does it still work?

Yes, it works.
I've found quick fix by copying with FFmpeg.
ffmpeg -i raw.mp4 -c:v copy res.mp4
It could be related to https://github.com/Genymobile/scrcpy/issues/351###

Let's bisect manually (if you know how to build, you could do it faster on your side).
Here is a binary for 63af7fbafe3740b17b5495a8230298eff9d45581: scrcpy.exe
SHA256: b78e72e10289f5c9b5ca25b82a6844eea2b56ff1e04b05513295c9c6c130d7a6
And for 35d9185f6c3dc1c34ea7d46859ee89827e2fe74a: scrcpy.exe
SHA256: fa577f14df8a1e55f50280ec67a166b44775b66b5965c37575b1bbe2c3b23fca

Sorry I don't know how to build. I'll try those scrcpy.exe. Thanks!
v1.10 (test.mp4) doesn't have framerate mode metadata (the programs may think that it has constant framerate), v1.9 (raw.mp4) does.

Here is a binary for 63af7fb: scrcpy.exe
SHA256: b78e72e10289f5c9b5ca25b82a6844eea2b56ff1e04b05513295c9c6c130d7a6
And for 35d9185: scrcpy.exe
SHA256: fa577f14df8a1e55f50280ec67a166b44775b66b5965c37575b1bbe2c3b23fca
Both don't work.

ffmpeg -i raw.mp4 -c:v copy res.mp4
I've compared those two files, the difference is only a few lines at the end so probably it's the metadata.

Thank you for the details.
Could you test with this patch, please (of course I will not commit it as is):
diff --git a/app/src/recorder.c b/app/src/recorder.c
index 402f253..e14599c 100644
--- a/app/src/recorder.c
+++ b/app/src/recorder.c
@@ -237,6 +237,7 @@ recorder_write(struct recorder *recorder, AVPacket *packet) {
         return true;
     }

+    packet->duration = 96000;
     recorder_rescale_packet(recorder, packet);
     return av_write_frame(recorder->ctx, packet) >= 0;
 }

Here is a binary: scrcpy.exe
SHA256: a713b5d620b2c506a35d96e22cd7f2b793639a46138ac551feebfd70ad61d0c1

And if it works, here is a proper fix: 8507fea2718141075de519a3f1f53c99951cd368 (not merged yet)
Here is a binary: scrcpy.exe
SHA256: 5eccf73a4077160cda5f351be0efc4d226ec81d283785a521353a2a8be321ab5

And if it works, here is a proper fix: 8507fea (not merged yet)
Here is a binary: scrcpy.exe
SHA256: 5eccf73a4077160cda5f351be0efc4d226ec81d283785a521353a2a8be321ab5
I've just tried this binary and it's working great! Thank you!

Cool, thank you for the report and the tests. I just merged it in master.


perf-latency: Fixes to enable building perf/latency

In my aim to see how the perf/latency works,  I encountered some issues when compiling it, here I have a fix to allow compilation.
However, I miss the instructions to run it.
Is it expected for a user to create N database files names in a specific manner?

@JoanFM Btw, another process nit: please prefer rebase over merging from main because the latter creates a more complex git history for no real reason. (No need to fix this one.)


better naming conventions

I'm open to the idea of changing around naming conventions within the program as we move it from "minimum viable" to "stable".
Here are the current ideas.
PROGRAM ITSELF

SpecPy
spectroscoPy

PROGRAM COMPONENTS

hardware → machines
devices → instruments
OPAS → sources (would be a conceptual shift---widen scope to all adjustable light sources)

Thoughts?

Closing as out of scope for PyCMDS


Include run id in train.log

Added a --run-id flag that appears in logging at each training step. As default value I added a time stamp of the beginning of training. This allows for easy identification of the specific training run.
Issue: https://github.com/facebookresearch/metaseq/issues/471

I don't think we want a flag? But rather, use the SLURM_RESTART_WHATEVER variable?


Compile error with default features turned off

Version
Main
What you did
Turned off default features for LWIM
[dependencies]
bevy = { version = "0.11.2", default-features = false}
leafwing-input-manager = { git = "https://github.com/Leafwing-Studios/leafwing-input-manager.git", default-features = false}

What you expected to happen
The window to be created and the app run normally
What actually happened
A compile error is printed in the terminal
Additional information
Log:
failed to resolve: use of undeclared type `UiSystem`
   --> leafwing-input-manager/src/plugin.rs:118:32
    |
118 |                         .after(UiSystem::Focus)

This error is introduced in #375.

I did a quick change to see if it would work
#[cfg(feature = "egui")]
app.add_systems(
    PreUpdate,
    update_action_state::
        .run_if(run_if_enabled::)
        .in_set(InputManagerSystem::Update)
        .after(InputSystem)
        .after(bevy_egui::EguiSet::ProcessInput),
);
#[cfg(not(any(feature = "egui", feature = "ui")))]
app.add_systems(
    PreUpdate,
    update_action_state::
        .run_if(run_if_enabled::)
        .in_set(InputManagerSystem::Update)
        // Removed this and changed it to only run when all features are disabled
        // .after(UiSystem::Focus)
        .after(InputSystem),
);

#[cfg(feature = "ui")]
app.add_systems(
    PreUpdate,
    // Have this block use update_action_state::
    (update_action_state_from_interaction::,
    update_action_state::)
        .run_if(run_if_enabled::)
        .in_set(InputManagerSystem::ManualControl)
        .before(InputManagerSystem::ReleaseOnDisable)
        .after(InputManagerSystem::Tick)
        // Must run after the system is updated from inputs, or it will be forcibly released due to the inputs
        // not being pressed
        .after(InputManagerSystem::Update)
        .after(UiSystem::Focus)
        .after(InputSystem),
);

It fixes the compile error, but I have not extensively tested it nor am I experienced enough with cfg to know if this is the idiomatic way.

This looks like it should work, but we can probably make clever use of configure_set to reduce the tricky logic duplication.

app.configure_set(
InputManagerSystem::Update
    .run_if(run_if_enabled::)
    .in_set(InputManagerSystem::Update)
    .after(InputSystem)
);

#[cfg(feature = "egui")]
app.configure_set(InputManagerSystem::Update.after(bevy_egui::EguiSet::ProcessInput);

#[cfg(feature = "ui")]
app.configure_set(InputManagerSystem::Update.in_set(InputManagerSystem::ManualControl)
    .before(InputManagerSystem::ReleaseOnDisable)
    .after(InputManagerSystem::Tick)
    .after(UiSystem::Focus)
);

Something like that was the pattern I had in mind? Do be careful when adapting this though: this was done entirely in the Github UI so I'm sure there are mistakes.

app.configure_set(
    PreUpdate,
    InputManagerSystem::Update
        .run_if(run_if_enabled::)
        .in_set(InputManagerSystem::Update)
        .after(InputSystem)
);

#[cfg(feature = "egui")]
app.configure_set(
    PreUpdate,
    InputManagerSystem::Update
        .after(bevy_egui::EguiSet::ProcessInput)
);

#[cfg(feature = "ui")]
app.configure_set(
    PreUpdate,
    InputManagerSystem::ManualControl
    .run_if(run_if_enabled::)
        .in_set(InputManagerSystem::ManualControl)
        .before(InputManagerSystem::ReleaseOnDisable)
        .after(InputManagerSystem::Tick)
        // Must run after the system is updated from inputs, or it will be forcibly released due to the inputs
        // not being pressed
        .after(InputManagerSystem::Update)
        .after(UiSystem::Focus)
        .after(InputSystem),
);

app.add_systems(
    PreUpdate,
    update_action_state::
        .in_set(InputManagerSystem::Update)
);

#[cfg(feature = "ui")]
app.add_systems(
    PreUpdate,
    update_action_state_from_interaction::
        .in_set(InputManagerSystem::ManualControl)
);

From using your example, I managed to create this. The main difference is that the ui feature uses the ManualControl set, so I couldn't append to the Update set. I can make a pr if you like this implementation.

Yes, that sounds great! I think once that PR is merged I'll cut a release: we have a number of bug fixes piling up (mostly thanks to you <3).

Thanks for the kind words! I do think that #382 should be fixed before cutting a release, as default features being turned off is still broken. I tried to find the issue, but LWIM doesn't use AssetServer? I'm guessing I have to look at ui configs to find the problem.


Add more test coverage to graphite/dashboard

Add more test coverage to graphite/dashboard/

Fix bug in email routine
Fix bug in loading a template directly from URL
Fix two bugs in template save and delete.

You are amazing. I gave this a skim but I think you are GTG at a high level, especially since the tests you added found bugs...

[Current coverage][cc-pull] is 44.54%

Merging [#1540][cc-pull] into [master][cc-base-branch] will increase coverage by 2.92%

@@             master      #1540   diff @@
==========================================
  Files            51         51
  Lines          5777       5781     +4
  Methods           0          0
  Messages          0          0
  Branches       1116       1116
==========================================
+ Hits           2404       2575   +171
+ Misses         3155       2977   -178
- Partials        218        229    +11

Powered by Codecov. Last updated by [46feba1...40236b3][cc-compare]
[cc-base-branch]: https://codecov.io/gh/graphite-project/graphite-web/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/graphite-project/graphite-web/compare/46feba124e5a9a01154ee87eb8983a8490049f34...40236b34ea6b6dd28be9a2f9377594e479c707d8
[cc-pull]: https://codecov.io/gh/graphite-project/graphite-web/pull/1540?src=pr


Entire site is blank across multiple devices

Expected Behavior
Webapp loads
Actual Behavior
After the website loads, the webapp does not load at all, hanging on a blank white page. This behavior has been consistent since around when v3.2.0 went live—I know because I tried to use the site around that time.
Steps to Reproduce the Problem
Load the website
Specifications

Platform: Chrome version 106.0.5249.79 and Firefox 105.2.0 on Android 12 on Pixel 5a, Firefox 105.0.1 on Windows 11, unknown browser on unknown recent Android version (asked a friend to double-check that it wasn't just a problem with my devices).

Thanks for your report! We have also noticed the problem and now we are trying to solve it. Sorry for causing your inconvenience!

It's okay! Things happen.


Fix some documentation issues

:loudspeaker: Type of change

[ ] Bugfix
[ ] New feature
[ ] Enhancement
[ ] Refactoring
[x] Documentation

:scroll: Description

I've fixed some documentation issues:

https://pub.dev/documentation/sentry_flutter/latest/
https://pub.dev/documentation/sentry_flutter/latest/sentry_flutter/SentryFlutterOptions-class.html
https://pub.dev/documentation/sentry_flutter/latest/sentry_flutter/SentryNavigatorObserver-class.html

:bulb: Motivation and Context

This is kinda obvious.
:green_heart: How did you test it?
No code was changed, just documentation.
:pencil: Checklist

[x] I reviewed submitted code
[ ] I added tests to verify changes
[x] All tests passing
[x] No breaking changes

:crystal_ball: Next steps
None

Codecov Report

Merging #238 (c345db6) into main (f0746e5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #238   +/-   ##
=======================================
  Coverage   80.74%   80.74%
=======================================
  Files          52       52
  Lines        1605     1605
=======================================
  Hits         1296     1296
  Misses        309      309

Impacted Files
Coverage Δ

...lib/src/navigation/sentry_navigation_observer.dart
97.50% <ø> (ø)

flutter/lib/src/sentry_flutter_options.dart
61.44% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0746e5...c345db6. Read the comment docs.

thanks @ueman :)


Increase MAX_TAIL_CALL_CNT from 32 to 33

Describe the bug
Problem:

The current MAX_TAIL_CALL_CNT in ebpf-for-windows is 32.
The total number of tail calls supported is 31, excluding the top-level caller.

Proposal:

Increase MAX_TAIL_CALL_CNT to 33, to match Linux behavior.
Check the number of tail calls supported in Linux and match the behavior in ebpf-for-windows
2.1 33 MAX_TAIL_CALL_CNT  :  32 Tail Calls + 1 Top-level Caller
Or,
2.2 33 MAX_TAIL_CALL_CNT:   33 Tails Calls, excluding the Top-level Caller.
Fix the backend and test cases to match the increased MAX_TAIL_CALL_CNT

Please check #2496 where the problem was detected and reported.
OS information
Windows 10 and above
Steps taken to reproduce bug
Please check #2496 where the problem was detected and reported.
The test case to reproduce is in draft PR.
Expected behavior
MAX_TAIL_CALL_CNT should be 33.
Linux reference:
<EMAIL_ADDRESS>Actual outcome

The current MAX_TAIL_CALL_CNT in ebpf-for-windows is 32.
The total number of tail calls supported is 31, excluding the top-level caller.


Clean Architecture and Redux

Hi,
I'm getting more and more interested in what Uncle Bob calls The Clean Architecture. It's a very nice software architecture that decouples the application from the outside world, from frameworks of any kind etc.
I'm wondering if it's possible to use Redux as an event sourcing engine and make a Redux configurable so that it takes interactions with the outside world as dependencies. To make myself more clear : the key principle from this archi is the Dependency Inversion Principle. In Redux, dispatching synchronous actions already decouples the app from the outside world. Just call store.dispatch from anywhere (be it the UI, a CLI app...) and the state handled by Redux will change according to the business rules handled by the reducer(s). In a "true Clean Architecture" way this already couples the app to Redux, but I'm fine with this in my experiments. The problem comes from async actions. The async logic is hardcoded in the action itself, like "fetching data from this Web API", or "Interacting with some Browser API". This couples tightly the app and the outside world.
My goal (and question here) is to make this configurable at app initialisation. I'm wondering how to implement the Dependency Inversion Principle with Redux. I imagine that all async actions should be provided at app initialisation, so that different implementations of the app just have to provide these actions. The only place I see where "initialisation/configuration" may happen is when creating the store, especially when applying the middlewares. But I can't wrap my head about how to write a middleware that would handle all the implementation specific details of the connexion between the app and the outside world.
... As I'm writing this, I realise it should be enough to separate sync and async actions. If I package a Redux app with the reducers and the sync actions only (with tests and checks of any kind), maybe with the middlewares too, could I just import this app and use it in, say, a React implementation ? An Angular implemenation ? A Node CLI implementation ? The side-effecty async action would come with implementation. Does it make sense ?
Which leads to another question : how to manage state in the implementation ? I suppose I should manage it separately from the app state in Redux. In the case of a React implementation for instance, some state would live in React components (the minimum UI state necessary to track display/hidden widgets state for example), but the rest of the state... Should it live in Redux too ?
I think I should tinker with the idea and and try to implement a basic Todo App with Redux, one time with say React, another time as a Node CLI. But before I do that, I'd love your input on this discussion.
Please forgive me if the discussion is out of place here, and for the tone used. I've been scratching my head with this problem and couldn't resist trying to formulate my thoughts here.

Have you looked at Redux Saga yet? I think it does what you describe. There are no “async actions” with this approach. Actions dispatched by your components are like commands. Special daemons called “sagas” can take them, do some work, and output other actions, until they reach the store, and can implement async control flow with generators.

If I package a Redux app with the reducers and the sync actions only (with tests and checks of any kind), maybe with the middlewares too, could I just import this app and use it in, say, a React implementation ?

Unless I misunderstand you, I think so:
import reducer, { increment, decrement } from 'redux-counter'

class App extends Component {
  constructor() {
    super()
    this.state = reducer(undefined, {})
  }

  dispatch(action) {
    this.setState(state => reducer(state, action))
  }

  render() {
    return (
      <Counter
        value={this.state}
        onIncrement={() => this.dispatch(increment())}
        onDecrement={() => this.dispatch(decrement())}
      />
    )
  }
}

This is Redux pattern in React without Redux, but with your existing code. Similarly, you could translate this to Rx with scan() operator, or to other view libraries.

Please please add this to the official docs!

Thanks for your quick feedback. I had indeed already looked at Redux Saga, and re-read the whole README to make sure I understand. I don't understand how it could help me, since I don't see how I can

configure which sagas run, and what IO they use, depending on the specific environment.

to quote you.
But, your second answer is really helpful. Thanks a lot. I'll try to implement something a will keep you informed. In the meantime, closing this issue to avoid pollution.

Here's an example that might help:
https://hackernoon.com/keep-your-ui-clean-with-redux-middleware-752383016c50


Fix aggregated sample presence information for internal nodes with duplicate IDs

Currently, it "double-counts" samples across duplicate-name nodes, which causes too-large numbers.
Options include (from discussion with @kwcantrell and @ElDeveloper):

Just show stats for the single node selected, even if its name is duplicated
Don't show anything for this node (there should be a warning in the selected node menu anyway; can expand this warning to say this is why stats aren't shown)

See comment here.

For reference, as of v0.2.0 this shouldn't be a problem -- if the user searches for a node with an ambiguous name, then the resulting dialog doesn't show sample presence info for the matching nodes. In all other cases where the node isn't ambiguous (the user clicked on a node, or the user searched for a node with an unambiguous name), a table of sample presence information for just that node is shown in the dialog.
Possible cases:

user clicks on tip
user clicks on int. node with unique name
user clicks on int. node with ambiguous name
user searches for tip
user searches for int. node with unique name
user searches for int. node with ambiguous name (only case where the table should be omitted, because the node is unclear)

Although things seem to be working now, it would be good to test that things work as expected. Ideally we'd test all of the above cases, but we should at least cover 1, 3, 5, and 6.

Addressed in #274


add stemplot

Is your feature request related to a problem? Please describe.
I'd like to plot data as stemplot. Seems like there is no stemplot supported yet.
Describe the solution you'd like
Porting the functionality from matplotlib.pyplot.stem would be reasonable.

Currently you should be able to emulate this with:
spikes = hv.Spikes((x_vals, y_vals))
spikes * hv.Scatter(spikes)

@philippjfr Thx for the workaround.

Oh right, didn't see you posted this on hvPlot. I don't think we currently expose Spikes through hvPlot. This should do it:
import holoviews as hv
scatter = df.plot.scatter(x='x axis label', y='y axis label')
hv.Spikes(scatter) * scatter

import holoviews as hv
scatter = df.plot(kind='scatter', x='retention time', y='intensity')
hv.Spikes(scatter) * scatter

works. Thx.

I think we should still expose spikes in hvplot.

I think we should still expose spikes in hvplot.

Maybe update the title too to reflect that? Some people may look for spikes, some others for stem (there are maybe other names for this kind of plot).

stem is definitely much more standard than spikes.


Fix deprecated modules when running npm install

 Issue by chriskacerguis
Friday Feb 20, 2015 at 21:18 GMT
Originally opened as https://github.com/projectjellyfish/ux/issues/208

Fix deprecated modules when running nom install
npm WARN deprecated<EMAIL_ADDRESS>use gulp-rimraf instead
npm WARN deprecated<EMAIL_ADDRESS>Please use the unpathify module directly. For an example, see the GitHub repository for this module.
npm WARN deprecated<EMAIL_ADDRESS>DEPRECATED in favor of bundle-collapsed

No longer valid.  Closing


data/areas-of-interest: locate spatial data, download into Gdrive, and organize for reading in R

Locate spatial data from Erin's list, download into Google Drive into areas-of-interest folder under data/, and read into R (e.g. with sf::read_sf()

add subfolders per AOI
add README.md with:

URL:
Date accessed:
Citation(s):
Notes:

I think these are the main ones -- added some specificity below:
CalCOFI

[x] CalCOFI study area

CalCOFI Regions-- Station # > 60 = oceanic/offshore; <60 = neritic/nearshore/continental shelf (other regions include those from Venrick et al. 2012 or Stephens et al. 2018
data/calcofi_oceano-bottle-stations_convex-hull.geojson made with oceano-bottle.Rmd:

also nearshore/offshore variants made with oceano-bottle.Rmd

International

[x] Territorial <12nm
[x] High Seas >12nm

Federal

[x] Sanctuaries: sanctuaries.geojson

Channel Islands NMS
Monterey Bay NMS
Chumash Heritage NMS (proposed)

[x] IEA California Current

[x] Freshwater ecoregion - SoCal Bight

[ ] CCE biological sampling areas (Central CCE, Southern CCE)- https://www.pcouncil.org/documents/2020/02/g-1-a-iea-team-report-1.pdf/

[x] Federal waters: 3-12nm  (see image on page 16 http://www.opc.ca.gov/webmaster/ftp/pdf/docs/Documents_Page/Noteworthy/Overview_Ocean_Coastal_Laws.pdf)

[x] EEZ federal: 3 (12?) to 200 nm (see MarineCadastre.org) OR (see image on page 16 http://www.opc.ca.gov/webmaster/ftp/pdf/docs/Documents_Page/Noteworthy/Overview_Ocean_Coastal_Laws.pdf)

BOEM

[x] Wind Energy Areas
[x] OCS- Central/Southern (https://www.boem.gov/sites/default/files/documents/about-boem/POCS Environmental Setting Report FINAL 2020-02-18.pdf)
[x] aliquots, etc

State

[x] CDFW Districts (https://wildlife.ca.gov/Fishing/Commercial/Regulations/Districts)
[x] CCAs (https://nrm.dfg.ca.gov/FileHandler.ashx?DocumentID=36132&inline)
[x] MPAs (only ones that have CalCOFI stations in them?)
[x] State Assembly Districts?- http://www.legislature.ca.gov/assemblydistricts.html
[x] Senate Districts?- http://www.legislature.ca.gov/Final_2013_2014_Senate_Map_v2.pdf
[x] State waters: 0-3nm (see image on page 16 http://www.opc.ca.gov/webmaster/ftp/pdf/docs/Documents_Page/Noteworthy/Overview_Ocean_Coastal_Laws.pdf)

County/local

[x] Counties (https://www.counties.org/sites/main/files/file-attachments/california_county_map_0.pdf)
[x] Sanitation districts (not sure how defined -- https://en.wikipedia.org/wiki/Metropolitan_Water_District_of_Southern_California#/media/File:Metropolitan_Water_Districts_Member_Agencies_Map.jpg)
[x] Ports (not exactly sure how to designate -- maybe based on city bounds?)
[x] Watershed HUCs (pollutant modeling) (https://databasin.org/maps/8de1d4f19adf4fb7a10df7877bce8101/active/)
[x] Areas of Special Biological Significance - "34 ocean areas monitored and maintained for water quality by the State Water Resources Control Board"- (https://www.waterboards.ca.gov/water_issues/programs/ocean/asbs_map.shtml)

Overlap strategy
We don't need to keep features that do not intersect CalCOFI study area, eg Sanctuaries on the East Coast, but we don't want to clip intersecting features to the study area, ie keep the original polygon shape. So technically, that means keep all sf::st_intersects() (not sf::st_intersection()).
Motivation
Goal: Get AOIs that intersect CalCOFI study area for extraction of key variables over time, a la ...
https://shiny.ecoquants.com/calcofi/

Hey @bbest. Question on what to do for polygons that extend far beyond the calcofi study area. The biggest example here is with territorial and non-territorial waters. I have found these polygons no problem (available here and here), but these polygons extend way beyond the california zone., which is obviously too much. Should I clip the waters polygons to the boundary of the calcofi study area that you already found?

Hi @superjai, please read the Overlap Strategy heading above in this issue. We don’t want to clip, just retain any features that intersect. I’d start by downloading any relevant ones into Google Drive. Then run through intersecting, ideally with an R script or similar.

Please be sure to include a README with source URL in the Gdrive folders and check Task boxes as you go. Thanks!

Hey @bbest - I have gotten as far as I can with this one and I have sent emails out where I have had issues. All of the requested datasets have been saved to the google drive, with the following exceptions:

IEA California Current (I can't find it online. Sent email to Chris Harvey requesting access)
CCE biological sampling areas (I can't find it online. Sent email to Chris Harvey requesting access)
BOEM Outer Continental Shelf - "Central/Southern" (This area is actually never actually defined in the report that Erin listed as a resource. I had some suggestions how to proceed and I emailed Erin asking how she wanted to go).
BOEM "aliquots, etc" (Two issues here. First it seems like Erin wanted something beyond just aliquot data and I emailed her what additionally she was looking for. Second, the BOEM aliquot data is not available due to a 404 error at the associated data portal. I emailed BOEM to inquire where the data might be).
"Ports (not exactly sure how to designate -- maybe based on city bounds?)" - there are two kinds of port data available for california, fishing ports and shipping ports. I emailed Erin to clarify which she was looking for.

Response from Erin:
I was looking at this data (https://www.boem.gov/oil-gas-energy/mapping-and-data/pacific-cadastral-data) and was thinking of:

Pacific Planning Area Outlines (I can't tell if these are the same as the OCS boundaries...)
Standard OCS Blocks clipped to the Submerged Lands Act (SLA) boundary on the shoreward side (2304 hectares per standard block).
Active Leases

Q: What about the terrestrial layers, like Counties and Ports?
Create non-overlapping buffers for terrestrial layers
See https://ohi-science.org/pages/create_regions.html for ArcGIS Python script to handle this.

Maybe R solution here: Couple of questions about buffers and MPAs in LSP · Issue #17 · OHI-Science/ohi-science.github.io

Note! I couldn’t actually check to see if the "IEA regions" shapefile contains the desired IEA regions. Attempting to open this shapefile in RStudio caused an immediate crash of RStudio. I nonetheless saved the shapefile to the google drive.

All the data layers have now been grabbed with the exception of "CCE biological sampling areas", which is unavailable. Here's the note from Chris Harvey, NOAA scientist, who generated that sampling area map:
JAI: In the following report for which you were the lead, I was hoping to get the shapefiles you used to generate two of your figures: https://www.pcouncil.org/documents/2020/02/g-1-a-iea-team-report-1.pdf/
A. I was hoping you could direct me to the shapefiles used in Figure 2.1.a. for "oceanographic sampling locations".
B. Additionally, I was looking for the shapefiles used in Figure 2.1.c for "biological sampling areas".
CHRIS: That Figure 2 is the worst...I basically made those panels myself in Powerpoint with some screen captures and crude artwork, and frankly my computer skills are pretty limited, so there aren't any shape files per se. I'm happy to share those images with you but they're terrible and a bit out-of-date, and they've been on my list of things to improve for several years.

Ok, this is great Jai! Thanks for gathering all the data. We'll leave out the CCE biological sampling areas per Chris' comment.


The visualize program？

Awesome demo video! Would you please share the program that visualize answer log?

I saw the closed issue and find the code. I will try it. Thanks.


available in arch without the aur

wlogout is available in the arch community repository, meaning it can be installed running sudo pacman -S wlogout

Is this a request to add it to the community repo? It's not in it yet and your wording makes it sound like it is.

But it is? Or maybe thats added in by the manjaro maintainers. I'll report back

Searching for it in Arch Linux Packages doesn't turn anything up.

It is added to the Manjaro ARM repo. Works quite well on SBCs :slightly_smiling_face:
Haven't seen it in the x86_64 repos of Arch or Manjaro thus far.


It's A Pack!

The only reason this is an Asset Pack right now is because bower-main-files isn't doing any compilation.
At some point in the future, the structure of this project should be revised. It only need to be included during development, in particular.
Note also that the pack version and the dist version have diverged — dist is compliant with cd-module v1, and pack is for v2.

This tool is legacy and will be sooner deprecated than revised.


fix(model-client): fix executing bulk queries in RestWebModelClient

Fix executing bulk queries in RestWebModelClient.
To be verified by reviewers

[ ] Relevant public API members have been documented
[ ] Documentation related to this PR is complete

[ ] Boundary conditions are documented
[ ] Exceptions are documented
[ ] Nullability is documented if used

[ ] Touched existing code has been extended with documentation if missing
[ ] Code is readable
[ ] New features and fixed bugs are covered by tests

:tada: This PR is included in version 8.8.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


makeRequest and dry run

Expected Behavior

makeRequest is executed when the migration has been validated and confirmed
Actual Behavior
makeRequest runs when the migration is validated

Possible Solution

Steps to Reproduce

write a migration
use makeRequest
run the migration
observe that makeRequest ran even though you still haven't chosen to apply the migration in the cli

Context

Environment

Node Version:
Package Manager Version:
Operating System:
Package Version:

Yes, I even have looked at using the context and wiring up getClient, but having the migrations seed pass some form of flag even to allow for developer conditional execution would be helpful -- i.e. pass if it is committing the change or validating, so it is safe to run / does not have side effects


Swet variants

This is a compilation of ideas from the #developers channel on discord.
Added purple and white swets, renamed yellow swets to golden swets. Fixed damage and passenger issues with all swet types.
Purple swets inflict poison
White swets steal status effects (e.g. if the player has the poison effect, it is taken from them and given to the white swet)
Golden swets are now larger, have more health, and do more damage.
Co-Authored-By: Daniel Ferrer<EMAIL_ADDRESS>

I believe I made this pull request back when customportal wasn't working. I'll bring it up to date and we can run checks again.


[ISSUE] ES is not bumped to latest patch level in value files

Describe the issue:
ES is not bumped to latest patch level in value files.
Actual behavior:

See that current version is 7.17.10

Expected behavior:

Latest is 7.17.13
Renovate should provide respective PR

How to reproduce:
View https://github.com/camunda/camunda-platform-helm/blob/main/charts/camunda-platform/values/values-latest.yaml#L50

Logs:
n/a

Environment:
n/a
Please note: Without the following info, it's hard to resolve the issue and probably it will be closed.

Platform:
Helm CLI version:
Chart version:
Values file:

@MaxTru thank you for reporting that.
There was an issue with matching as the ES image uses the Elastic Docker registry.
It has been fixed in #877, and #879 is the Renovate PR for ES.


PRODUCTX documentation contains incorrect information

https://docs.microsoft.com/en-us/dax/productx-function-dax?source=docs
The documentation states the folloowing:
The second argument is a column that contains the numbers for which you want to compute the product, or an expression that evaluates to a column.
This is not correct. The expression does not need to evaluate to a column.  The expression can be anything you like and you are free to ignore the columns.  eg  If I have a table (called table) with 1 column (called column) as follows:
Column
A
B
C
D
the following formula does not reference any columns, and it will return the value 16
=PRODUCTX(table,2)
Can you please update accordingly.

@MattAlington Please consider moving this issue to https://github.com/MicrosoftDocs/powerbi-docs/issues


Fixed codeclimate config

Coverage remained the same at 95.215% when pulling f843a3dde834353225887f040fde86f8a3e8e4a1 on cody-codeclimate-yml into 02ba320e2d088c4f0f05ce7f2392165252020d95 on main.


Add support for Windows

This will likely require complication with flang. An example repository where we have this working for windows with flang is: https://github.com/conda-forge/slycot-feedstock

Is there a good example you could point me to for making conda-forge builds for windows? (real basic, I don't know if these use the same meta file, or something different). We have windows builds on pypi made using appveyor, so this script might help in getting it done: https://github.com/SHTOOLS/build-shtools/blob/master/appveyor.yml

We build slyclot for windows using flang here: https://github.com/conda-forge/slycot-feedstock but make use of scikit-build in slycot to help things along.

when i used this pacakge in ggtools on windows，there is a problem "'centralmeridian' is an invalid keyword argument for _SHTOOLS.Curve2Mask()"，why?

Hi @xiaojingdounaodan , could you open an issue on the main https://github.com/SHTOOLS/SHTOOLS project, and provide some output so that we can help debug this?


Can I use pions-webrtc in concurrency environment?

Hello,
I have some questions about concurrency in this project:
Should I create a new RTCDataChannel each time, when I want to send some bytes from one pion to another one? I mean, I want to send bytes from pion1 to pion2 and from pion1 to pion3 simultaneously. Should I in that case to create two different RTCDataChannels (like, webrtc.New(config)), or should I have one RTCDataChannels per application?
Also, if you have some concurrency model for this project (like, some object is not thread safe and so on), I will be happy to get it.
Thanks, folks.

Have to say that NATS would get you that concurrency.
I raised an issue already about this
On Wed, 10 Oct 2018, 23:52 Denis<EMAIL_ADDRESS>wrote:

Hello,
I have some questions about concurrency in this project:
Should I create a new RTCDataChannel each time, when I want to send some
bytes from one pion to another one? I mean, I want to send bytes from pion1
to pion2 and from pion1 to pion3 simultaneously. Should I in that case to
create two different RTCDataChannels (like, webrtc.New(config)), or
should I have one RTCDataChannels per application?
Also, if you have some concurrency model for this project (like, some
object is not thread safe and so on), I will be happy to get it.
Thanks, folks.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/pions/webrtc/issues/202, or mute the thread
https://github.com/notifications/unsubscribe-auth/ATuCwh3KUcyfrzQEFAETVyJapw94Gavsks5ujmw0gaJpZM4XWZ7s
.

Hey @Hixon10
You should create a unique RTCDataChannel for each DataChannel you want to open (like webrtc.New). I will update docs/add and error if you try to reuse to make it more user friendly, thanks for pointing that out.
Also will update the docs around what needs to be locked/unlocked. Everything in the examples should be thread safe, so if you find something with -race when following the examples that is a bug!
I will keep this issue open and close out when I fix this stuff, thanks

@Sean-Der  Thank you!

Hey @Hixon10
We updated the API so users don't have to take locks when setting things.
We also added E2E tests that run with -race and things seem to be working pretty well. If you have any suggestions I would still love to improve things, but it seems to be working ok so far.
Thanks again for using pion-WebRTC! Really excited to see people using it


Field's Option constructor class made public.

I've made Option's constructor public.

please, could you accept this pull request?

What happened to the pull request?

@stephenc something happened to jenkins...

Hello @stephenc , could you tell me how to improve the code to be acceptable by jenkins?

@aheritier do you know where that jenkins is. I cannot access even when on vpn

strange @stephenc I have no idea
no idea @Dohbedoh ?
The one I use is https://support.ci.cloudbees.com/job/DEV/job/zendesk-java-client/

Hello? Anything to say about that PR?

But Jenkins said "All checks have failed"

I'm waiting for any response....

Hi there! What happened here? Have all of you been abducted by an alien? :p

I believe this can be merged? It's causing pain


Add mention of IRC and Slack in About Page

opensourcecornell.slack.com/signup
freenode IRC at #opensourcecornell

Also output it in the log as per @lidavidm's great idea :D

Done as per 8f7176c739c589353e2409ceb68da624c6b8460c


ENH: linalg: Add wrapper for ?tgsyl

Reference issue
Closes #18404
What does this implement/fix?
This adds a low-level wrapper for Lapack functions <s/d>tgsyl
Additional information:

Not final code. Help and review welcome
In some tests I tried to calculate lhs and rhs of the sylvester equations after solution, but they don't seem to meet the desired accuracy of machine precision*100 that is used in other tests. So, I still have to debug.
For now I have these questions:

I'm not too sure what the input matrix forms should be. Lapack doc does say (a,b) and (d,e) should be quasi upper triangular and upper triangular respectively. Does quasi upper triangular mean block upper triangular?
How do we check the matrix forms like (quasi) triangular inside the template code?
I am still not sure how f2py is actually building the *.pyf.src template signature files. Does f2py itself have the mechanism to replace the templates or is there some extra build step somewhere to generate the actual *.pyf from the templates?
If you are aware of other sources for tests let me know (NAG is mentioned in code. But not sure where to find it.)

Looks almost done to me. However the test need a full PEP8 pass then this is getting ready for merge.

Looks almost done to me. However the test need a full PEP8 pass then this is getting ready for merge.
Fixed PEP8 styling issues with new tests in latest checkin

If you separate the spectrum a bit further then float32 should also get ~1e-4 level precision. So something like this should make it fly. Nevermind the scale comment above.
    atol = 1e-4 if dtype == np.float32 else 1e-10

    m, n = 10, 15

    a, _ = schur(generate_random_dtype_array([m, m], dtype=dtype))
    d = np.triu(generate_random_dtype_array([m, m], dtype=dtype))
    b, _ = schur(generate_random_dtype_array([n, n], dtype=dtype))
    e = np.triu(generate_random_dtype_array([n, n], dtype=dtype))
    c = generate_random_dtype_array([m, n], dtype=dtype)
    f = generate_random_dtype_array([m, n], dtype=dtype)

    # Adjust the spectrum of the matrices to get a more precise solution
    adjustment = np.eye(m, dtype=dtype)
    a += adjustment
    d -= 5 * adjustment
    b += adjustment
    e -= 5 * adjustment

If you separate the spectrum a bit further then float32 should also get ~1e-4 level precision. So something like this should make it fly...

I had to make a few minor changes to your suggested code due to matrix sizes but it worked on my local machine. I pushed it. Let's see if it passes all CI tests.

Tests are failing on some platforms for atol=1e-4 for single precision. Trying with atol =1e-3

Well these are tricky problems anyways so if it works with 1e-3 it is what it is, no need to dwell on it. If things pass, let's get it in instead of wasting your time.

Ah OK, the transposed problem is a different one to separate, hence the artificial push is making the 'T' option solution worse. That's why we get that silly result in float32 probably. Almost there but I'll check this tomorrow.

Ah OK, the transposed problem is a different one to separate, hence the artificial push is making the 'T' option solution worse. That's why we get that silly result in float32 probably. Almost there but I'll check this tomorrow.

Thanks for looking into it. I'm afraid I don't really know the specifics of this algorithm, so won't be much help figuring out the tolerances beyond trial and error. I'll  leave it upto you to fine tune the test and tolerances. Let me know if I can help otherwise or if I need to take any action once we are ready to merge the PR.

The one failing test on macOS tests (meson) / Meson build (3.11) (https://github.com/scipy/scipy/actions/runs/5162854702/jobs/9300833616?pr=18571) looks like its related to  #18601 ?

Ah dammit.  That's why indeed. Anyways let's wait for that one. This one is indeed ready with smaller tolerances

Ah dammit.  That's why indeed. Anyways let's wait for that one. This one is indeed ready with smaller tolerances

No worries. I agree. This one looks ready pending the build fix for macOS. Thanks for all the help!

@ilayn @Kai-Striega I just rebased and pushed and it is now passing all tests with tighter tolerances that Ilayn worked on (Looks like the BLAS package updates for #18601 must have worked to fix the OSX tests for this as well). I think this is now ready for merge.

Looks good, thank you very much @mainak33 for your patience and @Kai-Striega for the reviews. Let's click it


[PORT] Sets warnings as errors and adds FxCop analyzer to Schema project.

Port this change from botbuilder-dotnet/master branch:
https://github.com/microsoft/botbuilder-dotnet/pull/4061

Relates to #2367.

Configured TreatWarningsAsErrors on all projects in the libraries folder except for Microsoft.Bot.Builder.Dialogs.Adaptive.Testing (that needs to be addressed separately).
Created Directory.Build.props for FunctionalTests and Tests to manage excludes for the projects in those folders.
Edited projects to generate XML documentation for debug config too so we can catch this early on rather than later in the build server.
Added NoWarn properties for documentation on each project (these will be addressed by #4052).
Fixed long hanging fruit warnings.
Added Roslyn FxCop analyzer to Microsoft.Bot.Schema and fixed violations or excluded them using #pragma with justification for the exclude (most of the changes couldn't be made because of binary compat).

Changed projects

Adapters
AdaptiveExpressions
Microsoft.Bot.Builder.AI.LUIS
Microsoft.Bot.Builder.AI.QnA
Microsoft.Bot.Builder.ApplicationInsights
Microsoft.Bot.Builder.Azure
Microsoft.Bot.Builder.Dialogs.Adaptive.Testing
Microsoft.Bot.Builder.Dialogs.Adaptive
Microsoft.Bot.Builder.Dialogs.Debugging
Microsoft.Bot.Builder.Dialogs.Declarative
Microsoft.Bot.Builder.Dialogs
Microsoft.Bot.Builder.LanguageGeneration
Microsoft.Bot.Builder.TemplateManager
Microsoft.Bot.Builder.Testing
Microsoft.Bot.Builder
Microsoft.Bot.Configuration
Microsoft.Bot.Connector
Microsoft.Bot.Schema
Microsoft.Bot.Streaming
integration

Microsoft.Bot.Schema.Tests

FXCop??? N/A


the job-sharding seems not work when i create a new job?

version 2.1.4

i followed the wiki step by step and everything goes well until i create a new job in the console,

there is nothing in the 'console' and 'execute' log,i have no idea to debug it..

Hi Orangutan, could you tell me what kind of job you create ? Java or Shell ?
For Java, please make sure that your executor contains the job class you implemented.

Thanks for return@kfchu, it's Shell Job ,and i can run it in the local server,the job status always in 'READY' in console


What's the difference

What is the difference between uefi's vt version and ordinary vt version?Is it easier to avoid detection?

Please read the "Advantages and Use Cases" section in README.md for some of the usage-level differences. For implementation wise, please see the linked blog post.
https://standa-note.blogspot.com/2020/03/introduction-and-design-considerations.html


Unable to use SWRevealViewrController in UIViewController

(void)viewDidLoad {
[super viewDidLoad];
FrontViewController *frontViewController = [[FrontViewController alloc] init];
RearViewController *rearViewController = [[RearViewController alloc] init];
UINavigationController *frontNavigationController = [[UINavigationController alloc] initWithRootViewController:frontViewController];
UINavigationController *rearNavigationController = [[UINavigationController alloc] initWithRootViewController:rearViewController];

SWRevealViewController *mainRevealController = [[SWRevealViewController alloc]
    initWithRearViewController:rearNavigationController frontViewController:frontNavigationController];

mainRevealController.delegate = self;

self.viewController = mainRevealController;

self.window.rootViewController = self.viewController;
[self.window makeKeyAndVisible];

}

Why do not do that in AppDelegate? What is self.viewController?

If implemented in AppDelegate then it directly loads the app with the controller in the root view on app launch.I want to load the controller after i login to the application in my HomePage's UIViewController.
Is there a way to do that ?

Ok, what is self.viewController?

Its
@property (strong, nonatomic) SWRevealViewController *viewController;

And self.window is a property of your viewController too? Is it initialized somewhere?

Try like that:
- (void)viewDidLoad {
    [super viewDidLoad];
    // Do any additional setup after loading the view, typically from a nib.

    FrontViewController *frontViewController = [[FrontViewController alloc] init];
    RearViewController *rearViewController = [[RearViewController alloc] init];

    UINavigationController *frontNavigationController = [[UINavigationController alloc] initWithRootViewController:frontViewController];
    UINavigationController *rearNavigationController = [[UINavigationController alloc] initWithRootViewController:rearViewController];

    SWRevealViewController *mainRevealController = [[SWRevealViewController alloc]
                                                    initWithRearViewController:rearNavigationController
                                                    frontViewController:frontNavigationController];

    mainRevealController.delegate = self;

    AppDelegate *appDelegate = (AppDelegate *)[[UIApplication sharedApplication] delegate];

    appDelegate.window.rootViewController = mainRevealController;
}

yes
i have initialized both
@property (strong, nonatomic) SWRevealViewController *viewController;
@property (strong, nonatomic) UIWindow *window;
in my ViewController.h file
and in my ViewController.m in the viewDidLoad  method i have implemented the controller, but it doesn't seem to work.
Kindly suggest !

Thanks,
I tried to implement as mentioned above but ,
i get the below
Warning: Attempt to present<HomeViewController: 0x7fc14ac12fc0> on <LoginViewController: 0x7fc14ac06b90> whose view is not in the window hierarchy!
Can u implement it in a ViewController and test?

SWCreateFromController.zip

Its working perfectly with your example.
I got the mistake i did.
Really appreciate the time you have invested.
Thank you ! :)


Localize 'mTLS (Mutual Transport Layer Security)

Describe your changes
Localize 'mTLS (Mutual Transport Layer Security)
Related issue number or link
(resolves #1213 )
Checklist before opening this PR (put x in the checkboxes)

[x] This PR does not contain plagiarism

don’t copy other people’s work unless you are quoting and contributing it to them.

[x] I have signed off on all commits

signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@ARYANis0001 I have a common comment on your PRs.
PTAL: https://github.com/cncf/glossary/pull/2605#issuecomment-1815774999


New package: ParametricOperators v1.1.1

Registering package: ParametricOperators
Repository: https://github.com/slimgroup/ParametricOperators.jl
Created by: @turquoisedragon2926
Version: v1.1.1
Commit: 2d90aef0c84693cc8b4adfeb4ee761bd30d125a9
Git reference: HEAD
Description: Scalable and distributed matrix-free abstractions for machine learning and scientific computing

Could you add a README and some documentation?

Could you add a README and some documentation?

oh sure

@goerz Hello sir, I have added a README and some examples, is that sufficient?

[noblock] Thanks, that looks great!
You will have to edit your own comments to contain [noblock], and then the automatic merge should proceed

Thank you very much [noblock]


Fix/access google fit if tracking is available

1.5.3 (2021-12-13)
Bug Fixes

access google fit if tracking available (2db332d8)

Looks NEAT 🦐
Ship it! :shipit: 🚢


Add SortDocuments

I've added 2 tests and looks like there some problems with Less method.

dance sort is failing https://github.com/FerretDB/dance/runs/5658676496?check_suite_focus=true#step:7:44

dance sort is failing https://github.com/FerretDB/dance/runs/5658676496?check_suite_focus=true#step:7:44

Fixed it.


Add support for decimal.Decimal encoding

In toml 0.9.6, decimal.Decimal values are converted into strings as follows:
import toml
from decimal import Decimal

d = {"a": Decimal("0.1")}
print(toml.dumps(d))

a = "Decimal('0.1')"

It would be helpful if toml.dumps method output float values when input value types are decimal.Decimal:
a = 0.1

Hi Tsuyoshi,
Thank you for your pull request! Sorry for the delay in following up on this.
I've merged this into master. This will go out in the next 0.10.X release but it will not be part of a future 0.9.X release (if any). I just want to clarify since you explicitly mentioned version 0.9.6.


Error Code 53 (What is it and why isn't there a list of error codes and their meaning anywhere?)

Hi!
I've been trying to use diskspd.exe to run some tests for our new file server. I've been trying to test writing to a server share but whenever I run the tool I run into error 53. I went hunting for the error code and have found nothing so far.
If someone could tell me what the error is or if there is a list of error codes and their meaning (if not it's not a bad idea). I'd be much appreciated.
Command being run from Client Laptop (CL01) to File Server (FS01):
diskspd.exe -c10G -d30 -b64k -Sh -o32 -t4 -r -w100 \FS01\Test\tempfile.dat

You can see the description for certain Windows error codes using the following command:
C:\>net helpmsg 53
The network path was not found.

Is this case it appears as if you're only using a single backslash to reference the remote server.

So they do follow Windows error codes, gotcha.
That was just a typo since I didn't copy and paste whoops.
Knowing the error code is enough though. Thank you


Add a way for configurable socket timeouts

Pull Request check-list
Please make sure to review and check all of these items:

[x] Does npm test pass with this change (including linting)?
[x] Is the new or changed code fully tested?
[x] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Added a way for connected sockets to timeout. This is important for situations where a connected server stops responding and the connection should close in a reasonable time.

@BridgeAR I would support putting this in because you would need to access the the stream property directly on a connect event and this seems like a lot of extra work. Additionally, the other timeout option is confusing because its easy to assume that this timeout does exactly what this timeout option specifies.

@BridgeAR I would support putting this in because you would need to access the the stream property directly on a connect event and this seems like a lot of extra work. Additionally, the other timeout option is confusing because its easy to assume that this timeout does exactly what this timeout option specifies.

👍 for @flippmoke comment @BridgeAR

Bump on this?

@flippmoke LGTM. Please resolve the conflicts with master, and I'll merge it.

@leibale updated the branch, there are some failures but do not seem to be related to my changes.

@flippmoke please fix those eslint errors:
line 377 in test/connection.spec.js - Trailing spaces not allowed
line 363 in index.js - Missing space before function parentheses

@leibale sorry I missed those pushed now

Hi @leibale @flippmoke @BridgeAR
can you merge that PR and release a new version?
as u can see in Issues section there are a lot of ppl that find the lack of this feature disturbing.
In case of Redis server being unresponsive, the current implementation node-redis will cause the app to break since it will try to connect over an over again.
Please merge this changes in order to allow us stop the connection after given time.


[Bug]: Typescript error when attempting to run google gemini prompt

What happened?
I am receiving the below error on Windows 11 when attempting to execute a Gemini Pro prompt after setting up the built-in Google plugin:
Error: Error processing ChatGoogleNode: Class extends value undefined is not a constructor or null
What was the expected functionality?
The prompt ran successfully
Describe your environment
Windows 11, Node 18, etc.
Relevant log output
No response
Relevant screenshots

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Needed to set default executor to Node. Closing.


Improve speed with @run-at document-start

Running the script at document-start means the location change occurs earlier, by loading the script before anything else.
Please consider adding
// @run-at document-start

to the metadata block.
Thanks a lot btw!

Fixed in 7e7284e35471b23316af03826e495bde29866ea9. Thanks for suggestion, now it really works faster!


Pan feature in ol3 don´t work in mobile chrome

The exemples in http://tsauerwein.github.io/ol3/mapbox-gl-js/examples/ don´t work when I try pan in mobile chrome in my smartphone. The pan dont wont in my mobile chrome, but are working in my mobile IE. These exemples are working in my descktop chrome. Same months ago these exemples were working in my mobile chrome, but some update damaged the pan feature in maps. What can I do to fix?

The official examples are hosted at https://openlayers.org/en/latest/examples/. Those should work for you, don't they?

The exemples with ol4 are working, but the problem is with exemples with ol3. My project is using ol3...

All examples are available per version, e.g. http://openlayers.org/en/v3.19.1/examples/ for 3.19.1

For exemple. This exemplo doesn´t work: http://openlayers.org/en/v3.2.1/examples/accessible.html
I am using v3.2.1 and I can´t change now.
How do I fix this issue?

v3.2.1 is too old, you can't expect us to answer this

ok, I understand!