More extensive testing

Once #43 lands, I think we should be ready to test generating all the peripherals that a SVD contains. svd2rust -i $svd would give us the full list of peripheral then we can use svd2rust -i $svd $peripheral for each peripheral in that list.
We could even repeat this approach for several SVD files in the cmsis-svd repo. We should be careful to not overdo ourselves and end up with unreasonable test times though.

Here's a script I used to smoke test svd2rust against posborne/cmsis-svd.
set -ex

main() {
    local url='https://github.com/posborne/cmsis-svd/archive/python-0.4.tar.gz'
    local data_dir=$(mktemp -d)

    curl -L $url | tar -C $data_dir --strip-components 1 -xz

    local errors=()
    set +ex
    find $data_dir -type f -name '*.svd' -print0 | \
        while IFS= read -r -d $'\0' line; do
            svd2rust -i $line >/dev/null 2>&1 || \
                echo $(basename $line)
        done

    set -ex

    rm -rf $data_dir
}

main

These svd2rust failed to generate code from these files:
M36B.svd
M369.svd
M368.svd
M367.svd
M365.svd
SIM3L1x8_SVD.svd
LPC408x_7x_v0.7.svd
LPC178x_7x_v0.8.svd
LPC178x_7x.svd
LPC176x5x_v0.2.svd
LPC11Axxv0.6.svd
ATSAMA5D35.svd
ATSAMA5D34.svd
ATSAMA5D33.svd
ATSAMA5D31.svd
ATSAM4SD32C.svd
ATSAM4SD32B.svd
ATSAM4S8C.svd
ATSAM4S8B.svd
ATSAM4S16C.svd
ATSAM4S16B.svd
ATSAM3X8E.svd
ATSAM3X8C.svd
ATSAM3X4E.svd
ATSAM3X4C.svd
ATSAM3U4E.svd
ATSAM3U4C.svd
ATSAM3U2E.svd
ATSAM3U2C.svd
ATSAM3U1E.svd
ATSAM3U1C.svd
ATSAM3SD8C.svd
ATSAM3SD8B.svd
ATSAM3S8C.svd
ATSAM3S8B.svd
ATSAM3S4C.svd
ATSAM3S4B.svd
ATSAM3S4A.svd
ATSAM3S2C.svd
ATSAM3S2B.svd
ATSAM3S2A.svd
ATSAM3S1C.svd
ATSAM3S1B.svd
ATSAM3S1A.svd
ATSAM3N4C.svd
ATSAM3N4B.svd
ATSAM3N4A.svd
ATSAM3N2C.svd
ATSAM3N2B.svd
ATSAM3N2A.svd
ATSAM3N1C.svd
ATSAM3N1B.svd
ATSAM3N1A.svd
ATSAM3N0C.svd
ATSAM3N0B.svd
ATSAM3N0A.svd
ATSAM3N00B.svd
ATSAM3N00A.svd
ATSAM3A8C.svd
ATSAM3A4C.svd
AT91SAM9X35.svd
AT91SAM9X25.svd
AT91SAM9N12.svd
AT91SAM9M11.svd
AT91SAM9M10.svd
AT91SAM9G35.svd
AT91SAM9G25.svd
AT91SAM9G20.svd
AT91SAM9G15.svd
AT91SAM9G10.svd
AT91SAM9CN12.svd
AT91SAM9CN11.svd

I have yet to investigate the cause of the errors. The error rate is  71 out of 490 or about 14.49%.

I have now classified all the 71 errors. Most of them are caused by the SVD not being valid. As per the specification all registers must have a reset value but the SVD listed above are missing reset values in some registers.

Updated script to detect SVD files for which svd2rust does generate code without crashing but the generated code doesn't compile:
set -ex

main() {
    local url='https://github.com/posborne/cmsis-svd/archive/python-0.4.tar.gz'
    local cargo_dir=$(mktemp -d)
    local data_dir=$(mktemp -d)

    curl -L $url | tar -C $data_dir --strip-components 1 -xz

    cargo init --lib --name device $cargo_dir
    ( cd $cargo_dir && cargo add cortex-m vcell )

    local errors=()
    set +ex
    find $data_dir -type f -name '*.svd' -print0 | \
        while IFS= read -r -d $'\0' line; do
            svd2rust -i $line >$cargo_dir/src/lib.rs 2>/dev/null || \
                ( echo "I: $(basename $line)" && continue )

            cargo check --manifest-path $cargo_dir/Cargo.toml >/dev/null 2>&1 || \
                echo "II: $(basename $line)"
        done

    set -ex

    rm -rf $cargo_dir
    rm -rf $data_dir
}

main

The compile errors are referred to as class II errors, and the generation errors are referred to as class I errors.
Here's the list of class II errors I have seen so far. (The script is still running on my machine; it's taking a while to test all the SVD files). The errors have already been classified:

LPC11Cxx_v9.svd | BAD SVD | two enumeratedValues have the same name
LPC11E6x_v0.8.svd | BAD SVD | two enumeratedValues have the same name
LPC11Exx_v5.svd | BAD SVD | two enumeratedValues have the same name
LPC11Uxx_v7.svd | BAD SVD | two enumeratedValues have the same name
LPC11xx_v6.svd | BAD SVD | two enumeratedValues have the same name
LPC11xx_v6a.svd | BAD SVD | two enumeratedValues have the same name
LPC13Uxx_v1.svd | BAD SVD | two enumeratedValues have the same name
LPC15xx_v0.7.svd | BAD SVD | two enumeratedValues have the same name
LPC800_v0.3.svd | BAD SVD | two enumeratedValues have the same name
MKV56F20.svd | BAD SVD | Bad enumeratedValue values
MKV56F22.svd | BAD SVD | Bad enumeratedValue values
MKV56F24.svd | BAD SVD | Bad enumeratedValue values
MKV58F20.svd | BAD SVD | Bad enumeratedValue values
MKV58F22.svd | BAD SVD | Bad enumeratedValue values
MKV58F24.svd | BAD SVD | Bad enumeratedValue values
nrf52.svd | BAD SVD | two enumeratedValues have the same value

(up to this point these errors are not due to svd2rust bugs)

STM32L063x.svd | #91
STM32L062x.svd | #91
STM32L053x.svd | #91
STM32L052x.svd | #91
STM32L051x.svd | #91
LPC5410x_v0.4.svd | #90
LPC43xx_svd_v5.svd | SYNTAX ERROR
LPC18xx_svd_v18.svd | SYNTAX ERROR
LPC13xx_svd_v1.svd | SYNTAX ERROR
LPC11D14_svd_v4.svd | SYNTAX ERROR
LPC1102_4_v4.svd | SYNTAX ERROR
SKEAZN84.svd | #92
SKEAZN642.svd | #92
SKEAZ1284.svd | #92
MKW01Z4.svd | #92
MK81F25615.svd | #76
MK82F25615.svd | #76
MKE02Z2.svd | #92
MKE02Z4.svd | #92
MKE04Z1284.svd | #92
MKE04Z4.svd | #92
MKE06Z4.svd | #92
MKE14D7.svd | #92
MKE15D7.svd | #92
MKL02Z4.svd | #92
MKL03Z4.svd | #92
MKL04Z4.svd | #92
MKL05Z4.svd | #92
MKL13Z644.svd | #92
MKL14Z4.svd | #92
MKL15Z4.svd | #92
MKL16Z4.svd | #92
MKL17Z4.svd | #92
MKL17Z644.svd | #92
MKL24Z4.svd | #92
MKL25Z4.svd | #92
MKL26Z4.svd | #92
MKL27Z4.svd | #92
MKL27Z644.svd | #92
MKL33Z4.svd | #92
MKL33Z644.svd | #92
MKL34Z4.svd | #92
MKL36Z4.svd | #92
MKL43Z4.svd | #92
MKL46Z4.svd | #92
MKL81Z7.svd | #76
MKL82Z7.svd | #76
MKM14ZA5.svd | #92
MKM33ZA5.svd | #92
MKM34Z7.svd | #92
MKM34ZA5.svd | #92

Testing all the SVD files in cmsis-svd takes a few hours on my laptop so it seems very unlikely that will be able to run it as part of the CI testing of this repo. I think we should sample some files, specially those listed above that are causing trouble today, from the database and just use those in our test suite. At the very least we should pick on SVD file per microcontroller vendor.

Also there are some new svd files in cmsis-svd repo (on master branch) that are not yet present in 0.4 archive.

@pftbest thanks for the heads up. I'll re-run the test script on the diff between HEAD and v0.4.0.

I'll re-run the test script on the diff between HEAD and v0.4.0.

I have now tested and classified the extra files. All the TM4C files fail (svd2rust works but compilation errors) due to #97. The rest work fine.

TM4C1230C3PM.svd #97
TM4C1230D5PM.svd #97
TM4C1230E6PM.svd #97
TM4C1230H6PM.svd #97
TM4C1231C3PM.svd #97
TM4C1231D5PM.svd #97
TM4C1231D5PZ.svd #97
TM4C1231E6PM.svd #97
TM4C1231E6PZ.svd #97
TM4C1231H6PGE.svd #97
TM4C1231H6PM.svd #97
TM4C1231H6PZ.svd #97
TM4C1232C3PM.svd #97
TM4C1232D5PM.svd #97
TM4C1232E6PM.svd #97
TM4C1232H6PM.svd #97
TM4C1233C3PM.svd #97
TM4C1233D5PM.svd #97
TM4C1233D5PZ.svd #97
TM4C1233E6PM.svd #97
TM4C1233E6PZ.svd #97
TM4C1233H6PGE.svd #97
TM4C1233H6PM.svd #97
TM4C1233H6PZ.svd #97
TM4C1236D5PM.svd #97
TM4C1236E6PM.svd #97
TM4C1236H6PM.svd #97
TM4C1237D5PM.svd #97
TM4C1237D5PZ.svd #97
TM4C1237E6PM.svd #97
TM4C1237E6PZ.svd #97
TM4C1237H6PGE.svd #97
TM4C1237H6PM.svd #97
TM4C1237H6PZ.svd #97
TM4C123AE6PM.svd #97
TM4C123AH6PM.svd #97
TM4C123BE6PM.svd #97
TM4C123BE6PZ.svd #97
TM4C123BH6PGE.svd #97
TM4C123BH6PM.svd #97
TM4C123BH6PZ.svd #97
TM4C123BH6ZRB.svd #97
TM4C123FE6PM.svd #97
TM4C123FH6PM.svd #97
TM4C123GE6PM.svd #97
TM4C123GE6PZ.svd #97
TM4C123GH6PGE.svd #97
TM4C123GH6PM.svd #97
TM4C123GH6PZ.svd #97

Done in #101

The ci/script.sh file is now keeping track of the SVD files that are not working due to missing feature is svd2rust. Each of those files has been classified and issues have been filed under the 'cmsis-svd' milestone.


Merge 'ThreeMammals:develop' into 'exception-mapper-naming'

Let's update your repo with latest top-commits from head repository.
That will allow to perform rebase-operation for feature branches without merge-commits.
⚠ Warning!
Use fast-forwarding, rebase option to merge please!

Alternatively,
Could you Sync fork please? This is preferred option!
After repo synchronization, close this PR please!
Please, work on merge conflicts.


Generate example jsonld output for our test data

[ ] matches one example of .tsv and .jsonld input - and that's tested
[ ] covers all pheno attributes (where possible - dx vs control)
[ ] matches one of the BIDS examples, ideally synthetic

@alyssadai anything else you can think of for the jsonld example?

Nope, think this looks good!


az vm extension set: autoUpgradeMinorVersion by default

I haven't even checked if the CLI has "az vm extension set" command (I'm mobile right now).
But if there is any, we should make sure when we set extensions we should set autoUpgradeMinorVersion:true by default (and give users a knob to disable it).
(This is basically the version:1.* feature in ASM)
This is good and PowerShell cmdlets do this too.

It helps our users get highest minor version.
It helps us reduce fragmentation on by offering users to install highest minor version available as they might be reading some old doc.

@yugangw-msft can you please prioritize this one. It would be very preferable to have --auto-upgrade-minor-version set to true by default just like powershell does.
This will help my team (who owns almost all 1st party extensions for both Windows and Linux) reduce fragmentation on extension versions and move forward faster. LMK if you want to sync offline.

@ahmetalpbalkan , you know we already exposed it. The change will be to flip the default value. This should be done next week, once I am back to office.

@yugangw-msft thanks a lot! I was just seeking some confirmation that you folks are fine with the change.

To be picked by @yugangw-msft in this sprint

@ahmetalpbalkan, so i will hide the flag and expose the opposite one of --no-auto-upgrade, with description: by doing this, extension system will not pick the highest minor version for the specified version number, and will not auto update to the latest build/revision number on any VM updates in future
Let me know any comments/suggestions.

sounds good.


🚀 Feature: plugin-catalog-backend-module-gitlab support custom

🔖 Feature description
We use the Gitlab catalog discovery plugin, this works as defined. In our use case we want to use a specific type and catalogFile. The custom type is working fine if we import manually. The issue is that the Gitlab discovery import only supports the default url type.
🎤 Context

Support custom yaml file implementations for the gitlab discovery
Not sure if other discovery plugins have similar needs

✌ Possible Implementation
source file `src/providers/GitlabDiscoveryEntityProvider.ts``
  private createLocationSpec(project: GitLabProject): LocationSpec {
    const project_branch = project.default_branch ?? this.config.fallbackBranch;
    return {
      type: this.config.catalogType ?? 'url',
      target: `${project.web_url}/-/blob/${project_branch}/${this.config.catalogFile}`,
      presence: 'optional',
    };
  }

👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
Yes I am willing to submit a PR!

Could also make it a callback that you pass to the provider.
GitlabDiscoveryEntityProvider.fromConfig(config, {
  logger, schedule,
  createLocation: (providerConfig, project) => {
    return { type: 'custom', target: '....' };
  }
})

Thanks @freben - this might be an option as well - can you give me an example how this would be passed in?


How to generate docs?

Problem statement
I see from the docs, that it's possible to serve docs. But I don't see any method to generate static files to serve them separate from the service.

Serving doc:
swagger serve {spec}
Also generated servers come baked with a {basePath]/docs endpoint to serve the spec
Indeed, there is not static file server

Would be nice to have an extra parameter to configure the value of {basePath}/docs ... something like {basePath}/{docPath}


I urgently need a professional to help me interpret this result.

I am a novice. I have compared two mirrors, and the comparison results are as follows. How should I interpret this information?
Command-line comparison
bindiff aaa.BinExport bbb.BinExport

BinDiff 7 (@377901646, Jun  7 2021), (c)2004-2011 zynamics GmbH, (c)2011-2021 Google LLC.
Function<PHONE_NUMBER>C7FA40 is excessively large: 4 basic blocks, 4 edges, 18192 instructions. Discarding.
Function 00AB2E50 is excessively large: 18 basic blocks, 22 edges, 11431 instructions. Discarding.
Function 00BF9B64 is excessively large: 267 basic blocks, 266 edges, 10072 instructions. Discarding.
Setup: 4.15s
primary:   aaa: 173329 functions, 844637 calls
secondary: bbb: 92618 functions, 556119 calls
Matching: 19.10s
matched: 83608 of 173329/92618 (primary/secondary, 170753/89954 non-library)
call graph MD index: primary   3740.46
                     secondary 1433.78
Similarity: 16.3976% (Confidence: 54.2144%)
Writing results: 0.59s

BinDiff comparison

I sincerely hope that professionals can help me. In the upper half of the picture, what do 49.2%, 4.9%, and 45.9% represent? Which way is more recommended to view the results?

In the upper half of the picture, what do 49.2%, 4.9%, and 45.9% represent?

https://www.youtube.com/watch?v=xpfvclDlPwU&t=575s


Crashes and deletes upon opening

I have downloaded 3.2 multiple times with the same unfortunate result. I open the .exe, I get to the first screen, make the server choice and then the program closes and disappears.
Any help would be appreciated.
Thanks.

What do you choose?

I choose the default option of "auto connect."

Where did you download the exe from?  It deleting itself sounds super dodgy.  I have an recent build from @fyookball which has logging to the console which you can try, but I need to find somewhere it can be uploaded.  Are you on bchchat slack?

If the exe gets deleted from your desktop, maybe check to see if your virus checker or malware checker is killing and quarantining it.

Hi, unless you can provide some more information, I'm going to close this issue.  It is almost entirely related that it gets deleted from your desktop and killed.  That effectively proves it's either malware you downloaded from another source, or you have a virus checker or malware checker that's killing/quarantining it.


Fix live stream event info page color

What
At some point the background color of the info page changed for live stream events, probably during #199. This PR just puts that back to the correct grey.

looks good 👍


Develop

@JeffDotPng / @itsjoeoui pls review

only 1064 files changed 👍 😆

@JeffDotPng LGTM, I also removed all the editor specific configs from VSCode and JetBrains.


Add composer_package_name workflow input to daily

What does this PR do?
Specifies the composer_package_name input for the pytest-cpu.yaml reusable workflow called by the daily.yaml workflow.  This field was added to add testing for the PyPi composer package as part of PR #2049, which broke the daily.yaml workflow.  It was not caught because the daily.yaml workflow doesn't get triggered until a merge to dev.  Since the workflow file is invalid, it doesn't run and we never saw a ❌ appear next to the status checks for each commit.
This change is tested by temporarily adding the pull_request event trigger to the workflow and making sure the workflow can run as part of a PR check.  The pull_request trigger will be removed before merging.
What issue(s) does this change relate to?
Relates to CO-1901
Relates to #2048
Before submitting

[x] Have you read the contributor guidelines?
[ ] Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
[ ] Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
[ ] Did you update any related docs and document your change?
[x] Did you update any related tests and add any new tests related to your change? (see testing)
[ ] Did you run the tests locally to make sure they pass?
[ ] Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

Should we add a GPU job with composer? We have bandwidth on test cluster for it rn, so it seems safe to do?
Just added!


Allows identifying the EC2 instances through the AWS console

Just replaced the tag instance with Name for creating the EC2 instances. It allows identifying the EC2 instances through the AWS console.
PR Type

Feature Pull Request

@gustavomcarmo Can you please provide more information on that, like: why the instance was not good and why the use of "Name" tag is better. By looking at the code I am unable to figure-out why one would be prefered to another. Does any of them have a special meaning?
Interestengly this seems to be related to https://github.com/ansible/molecule/issues/2142 -- so we may also want to add a tag that marks it as managed-by: molecule (or owned-by), so we can easily filter resources managed by molecule.

The Name tag is better because it's not possible to identify the EC2 console through the AWS console without. The instances names are shown in the column Name:

This console snapshot was taken during the execution of https://github.com/codeyourinfra/codeyourinfra/blob/31e1d815a06e3c1b00accf541394432223166df9/unarchive_from_url_param/molecule/aws/create.yml#L75.
And yes, this PR is related to #2142.

Should we add a new field to the schema for the user to pass these tags in? Because I can imagine that the next person comes along to add their own tag. They should be configurable?

I don't think so, unless we can identify some use cases when having configurable tags would be better. This PR has nothing to do with my own preference, I truly believe this tiny change can bring value to those who would like to distinguish the EC2 instances when looking to the AWS console.

unless we can identify some use cases when having configurable tags would be better.

"Because I can imagine that the next person comes along to add their own tag."
https://github.com/ansible/molecule/pull/2148#issuecomment-508443225

Do you guys prefer the change below?
        instance_tags: "{{ item.instance_tags | combine({'instance': item.name})
          if item.instance_tags is defined
          else {'instance': item.name} }}"

It works as well. And add instance_tags to the schema.
I've just tested: https://github.com/codeyourinfra/unarchive_from_url_param/commit/c1128cd0890bf5579987a60fcddc97e41ea8bd53

@decentral1se I've just pushed the https://github.com/ansible/molecule/pull/2148#issuecomment-511333243 alternative.

Alright, let's get this one in. Thanks :+1:


Make objects constants

@tobiaswjohn Due to some technical limitations in PlanSys, it would be better to add the Abox of Classes as constants in the problem file instead of adding them as objects in the domain file. Do you think you can change that easily? I think it would be easier to change the translation tool than to change PlanSys.

Just to clarify your request: You want to have the individuals from the ontology as constants in the domain file rather than having them as objects in the problem file? E.g. fd_follow_pipeline should become a constant instead of an object?
I think, this is considered bad style in PDDL, but I can do that for everything that is not a number. (If I also do it for numbers, the faster update of the problem file is no longer possible)

Thanks!

I think, this is considered bad style in PDDL

Ok, when we get the system running, I can try to make these changes on the PlanSys side. But I guess it is better to leave it for later


overall coyote timer fixed

Description
made coyote timer way less lenient (it was so lenient due to a programming error on my part), also added coyote timer functionality for wall jumps, it's not too noticeable but it is present and I like it
Closed Issues
Closes #53

i did not store the wall number, i simply had it set last on wall as true and last on floor as false if it last touched the wall and vice versa, in the actual jump function, i added a separate if statement for each condition

Seems to work now, don't know if maybe the coyote time is a little high now though?

you think so? I didn't think it was very lenient, I can lower it you want me to though

up to you

I lowered it, it's less lenient than before


[auto] Automatically update latest, release, and latestReleaseDate

Works for all the pages with a auto configuration. The data was already commited in the repo _data/release-data subdirectory , this PR adds a script to update the product files against this data.
To avoid confusions, this script will only run when the underlying data is updated (so not on regular contributions) in the dependabot PRs. I've run it once locally and committed the results in this PR for a first check.

This information is getting picked up from the release-data repository
This should (hopefully, untested so far) get auto-updated along with every dependabot
PR that is raised in the repo by itself. We should still review those to make sure there aren't any bugs
Some dates are off by 1 or 2 days - mainly because our earlier
information comes from blog posts and news pages, while this is coming
from the tag information which are usually published slightly earlier. Adding timezone confusion (we calculate
dates on UTC for now) makes the drift slightly larger in some cases -
I think it's acceptable, but open to discussion.

The update script uses py:ruamel, which treats newlines in lists as
belonging to the previous element, which causes some weird newlines. Don't have a solution for this yet, except for not adding spurious newlines within the YAML. But this makes no difference, so not a big issue. (Had to use Python:Ruamel, since that's the only package I could find that supports reading and writing YAML comments back)
One quirk with this is that ruamel needs a clean newline after the --- in the markdown file or it breaks. Will add a test for that somewhere - we just have to worry about this in contributions for now.
Haven't made any changes in the layouts in this PR, will tackle them separately, but notes on plans:

Add some label/text to denote a page as auto-updating. Auto-updating only works within a releaseCycle, since we don't have EOL information for the new release.
Start using latestReleaseDate in the layout where we have it. We can use this information for proper release RSS feeds as well. We might consider maintaining it for other pages manually as well (too much overhead imo, but we'll see)

Note on update schedule: The release-data repo itself is updated 4 times a day, which then syncs back here once a day. So new releases in a product should show up usually within a day in a PR here (Worst case would be 30 hours).

For reviewing, the diff without whitespace is much easier.

Congratulations on finishing the work in this amazing PR :tada: :100: :1st_place_medal:

Thanks, will monitor this for a few days and document how all of this works on the Wiki.


input[type=date] borks model on binding if ngRequired is falsey

So this wasn't a problem in the previous version of angular that I was running (1.2.*?) but as soon as I upgraded to 1.3.1 all of my required date input types would set my model value to null upon binding (which would fire my $watches prematurely and cause havok).
It seems there have been a lot of input controller related issues arise in 1.3 but looking through the open issues I don't think this one has any related.
Check out this plunk to verify the issue:
http://plnkr.co/edit/dgsiLXD4OTDt19FF6pmi?p=info
I tracked down the problem to the default formatter that is attached to the input in input.js:createDateInputType.  It is returning an empty string if the value evaluates to isEmpty.  Looking at other formatters the rule of thumb seems to be to return the original value that evaluated to falsey (not change it to empty string).  I made this one line change and if you click the "see fixed version" at the bottom of the plunk you will see the exact same page using my fixed version of the angular.js file.

This bug still seems to be happening in 1.3.8 & 1.3.10

@weagle08 I tried the plunker and it shows the same result for the latest snapshot and the fixed version that was included. If you are referring to a different error, please open a new issue. Thanks!


Bug fixes and improvements for corner cases

When working on #88 , I noticed some defects in the current library, so I'd like to submit this separate patch, which does the following:
Fix the defect that Column() crashes on zero or a negative input
The library panics when the following code is run
script.Echo("1").Column(-1)

After the change, the program will return an empty pipe.
Fix the defect that Last() crashes on a negative input
The library panics when the following code is run
script.Echo("1").Last(-1)

After the change, the program will return an empty pipe.
Fix the defect that Regex filters crash on a nil regex expression
The library panics when the following code is run
script.Echo("1").MatchRegexp(nil)

After the change, the program will return a pipe with the error "nil regular expression"
Add unit test for WithError(); close the pipe when a non-nil error is set
When fixing the regex defect, I just wrote
if re == nil { // to prevent SIGSEGV
	return p.WithError(errors.New("nil regular expression"))
}

Then, I realized that p will not be automatically closed, since the subsequent filters and sinks will catch the error and return immediately. To fix this problem and prevent contributors from making the same mistake in the future, I think the best approach is to just close the pipe reader when a non-nil error is set.
Add ExecForEach, Reject(), and RejectRegexp to doMethodsOnPipe tests
Just some jobs that previous contributors forgot.
Improve coverage by adding equal counts in the test case of Freq
To test that lines are sorted in alphabetical order when there is a tie.
Use io.Copy() in Stdout() to improve efficiency
It seems unnecessary to write the pipe's reader into a string and then print it.
By the way, after all the changes, the total line coverage has risen from 92.7% to 93.8%.

@bitfield Hi, would you please take a look at this pull request? Many thanks.

Excellent work @gty929, thanks a lot!

Excellent work @gty929, thanks a lot!


Fix crash when the adapter changes its content

PagerAdapterWrappershould call super.notifyDataSetChanged()when a change happens  in the wrapped PageAdapter otherwise you get the following error:

The application's PagerAdapter changed the adapter's contents without calling PagerAdapter#notifyDataSetChanged

Thanks a lot! We has this problem and this change fixes it! I hope it gets merged soon!

Unfortunately this does not fix the crash !!!


Add Unit instance

Just returning unit and not actually attempting to read/parse anything here makes sense I think?

cc @paf31

Hmm. I'm not sure, really. If the value happened to be a String, would you consider it ok that you got a Unit back? I guess it depends what the instance means. If it mean, "I don't care what value goes here", then this is good, but if it means "I expect an empty object" for some reason (I don't know why...) then maybe not.
What's the use case for this? Presumably related to deriving some other instance?

I was thinking more along the lines of "I don't care what value goes here" - but now you've pointed it out, I guess that's unnecessary as it could just stay as Foreign then.

True, but if you happen to need an instance for say, Either [String] Unit, you'd expect to be able to derive it. In most cases, I suspect you could use Foreign, but it's a shame to have to map to get the type you actually want.

I guess there's void for that too.


The ClientID identified in MqttApplicationMessageReceivedEventArgs for clients, is the clients own ID and not the message sender

Describe the bug
A clear and concise description of what the bug is.
In testing between a client and a broker, the broker receives the ClientID of the sending client in the InterceptingPublishEventArgs.  So the server sees which client sends a message.
However, if a client then subscribes to the same Topic and receives the broadcasts, the ClientID in the MqttApplicationMessageReceivedEventArgs is the receiving ClientID and NOT the sender ClientID. (which makes it impossible, unless you add it to the payload) for another client to know who the sender was.
I would have expected the ClientID in the ApplicationMessage to be the sender ClientID denoting where it originated from.
Which component is your bug related to?

Client

To Reproduce
Steps to reproduce the behavior:

Using this version of MQTTnet <IP_ADDRESS>6
Run a basic broker (such as the Run_Minimal_Server() in the examples)
Run a client (client 1) to post messages on a topic
Run a second client (client 2) subscribed to the same topic
Check the MqttApplicationMessageReceivedEventArgs from the ApplicationMessageReceivedAsync event and inspect the ClientID property

Expected behavior
A clear and concise description of what you expected to happen.
The Client ID received by Client 2, should be the ClientID from Client 1
Actual Behavior
The messages received by client 2 contain Client 2's ClientID
Code example
The Handle_Received_Application_Message() Sample from the examples is sufficient to replicate the issue:
https://github.com/dotnet/MQTTnet/blob/master/Samples/Client/Client_Subscribe_Samples.cs
Checking the ClientID received in:
            mqttClient.ApplicationMessageReceivedAsync += e =>
            {
                Console.WriteLine($"Received application message. Source {e.ClientId.}");
                e.DumpToConsole();

                return Task.CompletedTask;
            };

The client implementation of the ApplicationMessageReceivedAsync will always have the client ID of the client which received the message. This becomes useful when having multiple clients and only one event handler etc.
MQTT does not contain the sender of a message at all in any packages. It is not supported and not intended. If you need the client ID in certain situations you can send it in the payload or add it as a "user property" when using MQTT 5.0.0.

MQTT does not contain the sender of a message at all in any packages. It is not supported and not intended. If you need the client ID in certain situations you can send it in the payload or add it as a "user property" when using MQTT 5.0.0.

It could be added in the topic as well (E.g. if you think of some "gateway" devices that already use their device id as ClientId as well).


Disabling rich output.

Hi. Im using mteb library as part of long-running scripts for evaluating embedding models.
When running this on on terminals the output from logging and rich uses a lot of prints and takes a lot of space on the terminal, I'd rather implement my own logs on my application code and disabling the ones included in mteb.
Setting logging.basicConfig(level=logging.ERROR) get most of them gone, in combination with verbose=0 on evaluation.run. I want to disable rich output too. I've found that setting env variable RANK to a value different than 0 can solve my problem, but It's a terrible idea when running my code on distributed environments like slurm.
Is there any way I can make a PR to disable rich output? Is it better to have an ENV variable for this or to pass an argument to evaluation.run. I'd like some guidance on how to solve this issue.

Thanks @Napuh. Seems like it might be ideal to solve #1046
Ideally, it should be possible to set the verbosity level such that you don't get rich output. I believe wrapping this in an if statement (dependent on your logging level) should solve your issue.
https://github.com/embeddings-benchmark/mteb/blob/ef4df6209fc1583fbad611b305f5add24828e150/mteb/evaluation/MTEB.py#L365

Here is the PR: https://github.com/embeddings-benchmark/mteb/pull/1395


Rename index to home

Hi @hegemonic,
This is another additional pull-request over what we discussed prior to you going on vacation, but seems to make sense to us:

Renamed 'Index' to 'Home' since 'index.html' does not actually contain an index -- the index is actually available on the right of every page.

Hi, I just recently discovered JSDoc3 and am very impressed by its capabilities! But how can we internationalize the output? For example, instead of having "Home" and a title "JSDoc: Home", I'd like to be able to see that in German (e.g. "Hauptseite" and "JSDoc: Hauptseite", "Klasse:" instead of "Class:", etc.)
I noticed that in the file "publish.js" there is a function called "buildNav" which has the string "Home" already hard-wired into the code. Can't we make this configurable? Shouldn't it be part of a template somewhere? Or is there a way to do it already that I haven't yet discovered?


Add a Chroot.RunCallback method

This commit add the RunCallback method on Chroot object.
This also fixes the action.ActionChrootHook.
Signed-off-by: David Cassany<EMAIL_ADDRESS>

@Itxaka at the end I think this is pretty reasonable. You can call any function but you have to wrap the call you want into a function without parameters and returning error. I think this is the simplest way of doing it and should be flexible enough.


SAK-29467 SAM-2576 use joda-time 2.8

Replacing PR #612 with this single commit ... upgrading joda-time from 2.7 to 2.8 and including the version in master/pom.xml

Thanks @axxter99 and @ern


Comparing the hash of the sparrow-1.8.4 file with the sparrow-1.8.4-manifest.txt file does not match the results

I was checking the hash file of the download I made of the sparrow version 1.8.4 wallet, and it does not match the information contained in the sparrow-1.8.4-manifest.txt file.

The hashes do match if you have the correct file. Have you tried downloading again? How are you performing the hashing?

Closing this off.


Flight_delay_prediction

Pull Request for PyVerse 💡
Requesting to submit a pull request to the PyVerse repository.

Issue Title
Add Flight Delay Prediction Project
This pull request adds a new folder for the Flight Delay Prediction project in the Machine Learning category.

[x] I have provided the issue title.

Info about the Related Issue
What's the goal of the project?
The aim of this project is to predict flight delays using machine learning techniques, providing insights for travelers and airlines.

[x] I have described the aim of the project.

Name
Please mention your name.
SIMMA SAI GANESH

[x] I have provided my name.

GitHub ID
Please mention your GitHub ID.
"id": 153413186
"url": https://github.com/Sai-ganesh-0004

[x] I have provided my GitHub ID.

Email ID
Please mention your email ID for further communication.
<EMAIL_ADDRESS>
[x] I have provided my email ID.

Identify Yourself
Mention in which program you are contributing (e.g., WoB, GSSOC, SSOC, SWOC).
GSSoC'24-Extd

[x] I have mentioned my participant role.

Closes
Enter the issue number that will be closed through this PR.
*Closes: #430

[x] I have provided the issue number.

Describe the Add-ons or Changes You've Made
Give a clear description of what you have added or modified.
This PR includes the addition of a Flight Delay Prediction folder in the Machine_Learning category, containing the following files: flights.csv, model.ipynb, and README.md.

[x] I have described my changes.

Type of Change
Select the type of change:

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Code style update (formatting, local variables)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

How Has This Been Tested?
Describe how your changes have been tested.
I have tested the model.ipynb to ensure it runs without errors and produces the expected results using the provided flights.csv data.

[x] I have described my testing process.

Checklist
Please confirm the following:

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly wherever it was hard to understand.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have added things that prove my fix is effective or that my feature works.
[x] Any dependent changes have been merged and published in downstream modules.

Can you please verify it and let me know if any changes are there


Support SSH GitHub remotes - convert them into normal github URLs

This is based on https://github.com/pietroppeter/nimib/pull/21 so merge it first :)
A "default" GitHub SSH remote looks like this: git@github.com:Yardanico/nimib.git
Right now I only decided to support the "default" GitHub SSH remotes (the ones that it gives when creating a new repo or checking out an existing one) without the ssh:// prefix.

yep, as I mentioned in #21, it was definitely hacky and apparently full of gotchas :D
Thanks again!


2 Hotfixes: Allow Helm to reference image digests and inject licenses

This PR allows Helm to reference image digests by allowing the injection of them for each image and also automates the extraction and copying of all licences into the images under /home/agones/LICENSES.
I'm going to monitor the bot for any test failures. I also left no trailing spaces in any of the files I touched! die spaces, die!

Fixed the first issue - here is a patch.
patch.txt
Now failing (locally) with
Step 3/6 : COPY --chown=agones:root ./bin/sdk-server.linux.amd64 /home/agones/sdk-server
 ---> b1b7a39ab966
Step 4/6 : COPY --chown=agones:root ./bin/LICENSES /home/agones/LICENSES
COPY failed: stat /usr/local/google/docker/tmp/docker-builder674808864/bin/LICENSES: no such file or directory
Makefile:314: recipe for target 'build-agones-sdk-image' failed
make: *** [build-agones-sdk-image] Error 1

Removing the "-it" from Docker run and fixing the brain fart of not referencing the sdk-server have fixed the issues \o/


[107] Add JWE "zip" support

Resolves #107
Added support for the 🗜Compression Algorithm "zip" header parameter including its handling within the processing chain ⛓.
Due to the fact that there is already a strong dependency on native iOS libraries e.g. CommonCrypto I decided to go for the iOS compression framework.
The library DataCompression that @lukaszgieraltowski mentioned in his comment provides a neat wrapper around that framework.
Since there is only one compression algorithm officially supported so far, instead of using the whole library, I went for an excerpt that covers the bare minimum.
The DeflateCompressor protocol should provide enough abstraction to exchange it with another implementation if needed.
Notes for the reviewer 🔍
Compression is performed on the plaintext before encryption and after decryption.
All the relevant base64 de- and encoding is already properly handled.
As the deprecated decryption function was not abstracted in the first place, I also did not follow the DRY principle.
Inflate and deflate are force unwrapped as the implementor has to deal with the failing of either of both functions anyhow.
Happy to receive and incorporate suggestions and feedback. 🤓

Sweet! That‘s a nice christmas present. 🎄🎁
I‘ll definitely have a look over the next days. 😍

@haeser Did you have a chance yet to look at the feedback?

Yes thank you for you feedback. But since I am contributing this in my free time I only have the weekends and evenings to incorporate it. Will do it 🔜

sorry my setup was way to messy will create a new PR incorporating your feedback


Icon and .desktop not working with Plasma 5

Hello,
with Ubuntu it seemed to work fine but when running on Arch/Plasma5 (from AUR) it will display the icon in the tray with a black background and the launcher with no icon at all.
Also when I try to start it via the startmenu I get this:

KDEInit could not launch '/tmp/yaourt-tmp-hering/aur-skype-desktop-bin/pkg/skype-desktop-bin/opt/skype_unofficial_client/skype'

Edit: Running from console I get:

/usr/bin/skype-desktop: Line 2: cd: /tmp/yaourt-tmp-hering/aur-skype-desktop-bin/pkg/skype-desktop-bin/opt/skype_unofficial_client: File or Directory not found
/usr/bin/skype-desktop: Line 3: ./skype: File or Directory not found

It looks like ${pkgdir} didn't point/opt/skype_skype_unofficial_client folder correctly.
You should re-do /usr/bin/skype-desktop and /usr/share/applications/skype-desktop.desktop
Delete all /tmp/yaourt-tmp-hering/aur-skype-desktop-bin/pkg/skype-desktop-bin/

@HighIO, please, if you have time, send a PR with the modified $(pkgdir).


how to support gpu version 10.1 rather than 12.2

Feature request
how to support gpu version 10.1 rather than 12.2
Motivation
how to support gpu version 10.1 rather than 12.2
Your contribution
how to support gpu version 10.1 rather than 12.2

You cannot update your drivers?


Envoy TLS config causes SSL WRONG_VERSION_NUMBER error

Title: Envoy TLS config causes SSL WRONG_VERSION_NUMBER
Version: envoyproxy/envoy:v1.32.1
Description:
Trying setup an envoy HTTP proxy in Kubernetes cluster. The internal pods forward
curl -k http://envoy-egress:8080 -I http://www.google.com         # This is successful
curl -k http://envoy-egress:8080 -I https://www.google.com       # This is failing with OpenSSL wrong number

What issue is being seen? Describe what should be happening instead of
When the tester pod issues the curl command, envoy throws an curl: (35) OpenSSL/3.0.13: error:0A00010B:SSL routines::wrong version number error.

root@tester-pod:/# curl -v -k http://envoy-egress:8080 -I https://www.gmail.com
* Host envoy-egress:8080 was resolved.
* IPv6: (none)
* IPv4: <IP_ADDRESS>
*   Trying <IP_ADDRESS>:8080...
* Connected to envoy-egress (<IP_ADDRESS>) port 8080
> HEAD / HTTP/1.1
> Host: envoy-egress:8080
> User-Agent: curl/8.5.0
> Accept: */*
>
< HTTP/1.1 503 Service Unavailable
HTTP/1.1 503 Service Unavailable
< content-length: 211
content-length: 211
< content-type: text/plain
content-type: text/plain
< date: Tue, 19 Nov 2024 22:53:49 GMT
date: Tue, 19 Nov 2024 22:53:49 GMT
< server: envoy
server: envoy

<
* Connection #0 to host envoy-egress left intact
* Uses proxy env variable HTTPS_PROXY == 'http://envoy-egress:8080'
* Hostname envoy-egress was found in DNS cache
*   Trying <IP_ADDRESS>:8080...
* Connected to envoy-egress (<IP_ADDRESS>) port 8080
* CONNECT tunnel: HTTP/1.1 negotiated
* allocate connect buffer
* Establish HTTP proxy tunnel to www.gmail.com:443
> CONNECT www.gmail.com:443 HTTP/1.1
> Host: www.gmail.com:443
> User-Agent: curl/8.5.0
> Proxy-Connection: Keep-Alive
>
< HTTP/1.1 200 OK
HTTP/1.1 200 OK
< date: Tue, 19 Nov 2024 22:53:49 GMT
date: Tue, 19 Nov 2024 22:53:49 GMT
< server: envoy
server: envoy
<

* CONNECT phase completed
* CONNECT tunnel established, response 200
* ALPN: curl offers h2,http/1.1
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
* OpenSSL/3.0.13: error:0A00010B:SSL routines::wrong version number
* Closing connection
curl: (35) OpenSSL/3.0.13: error:0A00010B:SSL routines::wrong version number

Envoy Proxy Logs
[2024-11-19 22:59:42.224][20][trace][connection] [source/common/network/connection_impl.cc:614] [Tags: "ConnectionId":"93"] socket event: 2
[2024-11-19 22:59:42.224][20][trace][connection] [source/common/network/connection_impl.cc:737] [Tags: "ConnectionId":"93"] write ready
[2024-11-19 22:59:42.224][20][trace][connection] [source/common/tls/ssl_socket.cc:282] [Tags: "ConnectionId":"93"] ssl write returns: 517
[2024-11-19 22:59:42.252][1][debug][main] [source/server/server.cc:237] flushing stats
[2024-11-19 22:59:42.284][20][trace][connection] [source/common/network/connection_impl.cc:614] [Tags: "ConnectionId":"93"] socket event: 3
[2024-11-19 22:59:42.284][20][trace][connection] [source/common/network/connection_impl.cc:737] [Tags: "ConnectionId":"93"] write ready
[2024-11-19 22:59:42.284][20][trace][connection] [source/common/network/connection_impl.cc:654] [Tags: "ConnectionId":"93"] read ready. dispatch_buffered_data=0
[2024-11-19 22:59:42.284][20][trace][connection] [source/common/tls/ssl_socket.cc:92] [Tags: "ConnectionId":"93"] ssl read returns: 40
[2024-11-19 22:59:42.284][20][trace][connection] [source/common/tls/ssl_socket.cc:92] [Tags: "ConnectionId":"93"] ssl read returns: -1
[2024-11-19 22:59:42.284][20][trace][connection] [source/common/tls/ssl_socket.cc:132] [Tags: "ConnectionId":"93"] ssl error occurred while read: WANT_READ
[2024-11-19 22:59:42.284][20][trace][connection] [source/common/tls/ssl_socket.cc:168] [Tags: "ConnectionId":"93"] ssl read 40 bytes
[2024-11-19 22:59:42.284][20][trace][http] [source/common/http/filter_manager.cc:904] [Tags: "ConnectionId":"92","StreamId":"14141408323196708715"] commonEncodePrefix end_stream: false, isHalfCloseEnabled: false
[2024-11-19 22:59:42.284][20][trace][misc] [source/common/event/scaled_range_timer_manager_impl.cc:60] enableTimer called on 0x41cff4ea580 for 300000ms, min is 300000ms
[2024-11-19 22:59:42.284][20][trace][http] [source/common/http/filter_manager.cc:904] [Tags: "ConnectionId":"92","StreamId":"14141408323196708715"] commonEncodePrefix end_stream: false, isHalfCloseEnabled: false

Repro steps:

Include sample requests, environment, etc. All data and inputs

Configuration for the Envoy Proxy Pod
static_resources:
  listeners:
  - name: forward_proxy_listener
    address:
      socket_address:
        protocol: TCP
        address: <IP_ADDRESS>
        port_value: 8080
    listener_filters:
    - name: "envoy.filters.listener.tls_inspector"
      typed_config:
        "@type": type.googleapis.com/envoy.extensions.filters.listener.tls_inspector.v3.TlsInspector
    filter_chains:
    - filters:
      - name: envoy.filters.network.http_connection_manager
        typed_config:
          "@type": type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager
          codec_type: AUTO
          stat_prefix: ingress_http
          route_config:
            name: local_route
            virtual_hosts:
            - name: dynamic_forward_proxy
              domains: "*"
              #domains: ["*"]
              routes:
              - match: { prefix: "/" }
                route:
                  cluster: dynamic_forward_proxy
              - match:
                  connect_matcher: {}
                route:
                  cluster: dynamic_forward_proxy
                  upgrade_configs:
                    - upgrade_type: CONNECT
                      connect_config: {}
          http_filters:
          - name: dynamic_forward_proxy
            typed_config:
              "@type": type.googleapis.com/envoy.extensions.filters.http.dynamic_forward_proxy.v3.FilterConfig
              dns_cache_config:
                name: dynamic_forward_proxy_cache
                dns_lookup_family: V4_ONLY
          - name: envoy.filters.http.router
            typed_config:
              "@type": type.googleapis.com/envoy.extensions.filters.http.router.v3.Router
  clusters:
  - name: dynamic_forward_proxy
    connect_timeout: 5s
    # lb_policy: ROUND_ROBIN
    lb_policy: CLUSTER_PROVIDED
    cluster_type:
        name: envoy.clusters.dynamic_forward_proxy
        typed_config:
          "@type": type.googleapis.com/envoy.extensions.clusters.dynamic_forward_proxy.v3.ClusterConfig
          dns_cache_config:
            name: dynamic_forward_proxy_cache
            dns_lookup_family: V4_ONLY
    transport_socket:
      name: envoy.transport_sockets.tls
      typed_config:
        "@type": type.googleapis.com/envoy.extensions.transport_sockets.tls.v3.UpstreamTlsContext
        common_tls_context:
          alpn_protocols: ["h2", "http/1.1"] # support both HTTP/2 and HTTP/1.1
          validation_context:
            trusted_ca:
              filename: /etc/ssl/certs/ca-certificates.crt
admin:
  access_log:
  - name: envoy.access_loggers.file
    typed_config:
      "@type": type.googleapis.com/envoy.extensions.access_loggers.file.v3.FileAccessLog
      path: "/dev/stdout"
  address:
    socket_address:
      address: <IP_ADDRESS>
      port_value: 9901

Envoy Deployment
# envoy-deployment.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: envoy-egress
spec:
  replicas: 1
  selector:
    matchLabels:
      app: envoy-egress
  template:
    metadata:
      labels:
        app: envoy-egress
    spec:
      containers:
      - name: envoy
        image: envoyproxy/envoy:v1.32.1
        volumeMounts:
        - name: envoy-config
          mountPath: /etc/envoy
          readOnly: true
        - name: envoy-cert
          mountPath: /etc/ssl/certs
          readOnly: true
        ports:
        - containerPort: 8080
        - containerPort: 9901
        args:
        - "--config-path"
        - "/etc/envoy/envoy.yaml"
      volumes:
      - name: envoy-config
        configMap:
          name: envoy-config
      - name: envoy-cert
        configMap:
          name: public-ca-cert

envoy-service.yaml
apiVersion: v1
kind: Service
metadata:
  name: envoy-egress
  labels:
    app: envoy
spec:
  selector:
    app: envoy-egress # Ensure this matches the labels on the Envoy pod
  ports:
  - name: http
    protocol: TCP
    port: 8080
    targetPort: 8080  # Port exposed by the Envoy container
  - name: admin
    protocol: TCP
    port: 9901
    targetPort: 9901  # Optional: for the Envoy admin interface
  type: ClusterIP

tester-pod.yaml
apiVersion: v1
kind: Pod
metadata:
  name: tester-pod
spec:
  containers:
  - name: tester
    image: ubuntu:latest
    #image: curlimages/curl:latest
    command: ["sleep", "3600"]
    env:
    - name: HTTP_PROXY
      value: "http://envoy-egress:8080"
    - name: HTTPS_PROXY
      value: "http://envoy-egress:8080"

cc @ggreenway

Sometimes an error like this is due to trying to talk TLS to a plaintext service.
cc @alyssawilk because this deals with tunnels/CONNECT.

@soulxu This is the output with the -v option
$ curl -v -k http://envoy-egress:8080 -I https://www.google.com
* Host envoy-egress:8080 was resolved.
* IPv6: (none)
* IPv4: <IP_ADDRESS>
*   Trying <IP_ADDRESS>:8080...
* Connected to envoy-egress (<IP_ADDRESS>) port 8080
* using HTTP/1.x
> HEAD / HTTP/1.1
> Host: envoy-egress:8080
> User-Agent: curl/8.11.0
> Accept: */*
>
* Request completely sent off
< HTTP/1.1 503 Service Unavailable
HTTP/1.1 503 Service Unavailable
< content-length: 211
content-length: 211
< content-type: text/plain
content-type: text/plain
< date: Thu, 21 Nov 2024 00:29:58 GMT
date: Thu, 21 Nov 2024 00:29:58 GMT
< server: envoy
server: envoy
<

* Connection #0 to host envoy-egress left intact
* Uses proxy env variable HTTPS_PROXY == 'http://envoy-egress:8080'
* Hostname envoy-egress was found in DNS cache
*   Trying <IP_ADDRESS>:8080...
* CONNECT tunnel: HTTP/1.1 negotiated
* allocate connect buffer
* Establish HTTP proxy tunnel to www.google.com:443
> CONNECT www.google.com:443 HTTP/1.1
> Host: www.google.com:443
> User-Agent: curl/8.11.0
> Proxy-Connection: Keep-Alive
>
< HTTP/1.1 200 OK
HTTP/1.1 200 OK
< date: Thu, 21 Nov 2024 00:29:58 GMT
date: Thu, 21 Nov 2024 00:29:58 GMT
< server: envoy
server: envoy
<

* CONNECT phase completed
* CONNECT tunnel established, response 200
* ALPN: curl offers h2,http/1.1
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
* TLS connect error: error:0A00010B:SSL routines::wrong version number
* closing connection #1
curl: (35) TLS connect error: error:0A00010B:SSL routines::wrong version number
~ $ command terminated with exit code 137


Trailing comment is reported as wrong indentation

Ktlint 0.36.0
For the following code:
val item = createItem()
    .copy(id = 42), // Reuse ID from previous item

KtLint complains with [experimental:indent] Missing newline after "," and reformats this code to
val item = createItem()
    .copy(id = 42),
    // Reuse ID from previous item

This is not right, sice it's a comment and it pertains to that specific line. It also fits within the column limit.

@lwasyl hm, could you post the full example? I don't think it's a valid Kotlin code, or is it new trailing comma?

Yeah, sorry, I must've copied it wrong. Overall this issue happened when I had a comment in the same line as a parameter, and there were more parameters below. It's not related to the new trailing comma feature

Weird, I've tried to reproduce it, but this is passing just fine, I guess you had something more sophisticated :)
fun test() {
    run(
        1, // blah
        "2",
        "3"
    )
}

fun run(stuff: Int, stuff1: String, stuff2: String) = Unit

That's right, I checked and here's the offending code:
fun foo(param: Foo, other: String) {
    foo(
        param = param
            .copy(foo = ""), // A comment
        other = ""
    )
}

data class Foo(val foo: String, val bar: Int)

Fails on line with .copy


Would be better if we can use the same image name while rendering in HTML.

Let say we need a addressBook Icon. In flutter we can render via  Icon(                                 icon.iconData,                                 size: 100.0,                               ),
But when we want to use the same icon to render html page we have to use address-book. So, it would be better if you put key as real icons key like address-book by mapping the real name into that object property.

Dart does not allow dashes (-) in variable names. That's why they are in lower camel case.

You can create an object and put the real-name as a property. Thank you!!

The dash (-) will be interpreted as a minus, so dart thinks you want to subtract book from address (neither is defined). That is why we cannot use dashes in the real names.
If this is it, please close the issue.


add size units

Add size unit types (.px/.dp) for size aesthetics.

also add percentages

@AndreiKingsley What's the state of this issue? Are we including it in the next release?

No, there're several problems with Lets-Plot size units, but we still need this enhancement.

Okay, Is there a corresponding issue in lets-plot that we can track?

No, it's not and lets-plot issue, lets-plot just has its own units.

Size units in Lets-plot work like this:

size and stroke aesthetics (line width, points size, border line width and others) are converted as follows into pixels https://github.com/JetBrains/lets-plot/blob/master/plot-base/src/commonMain/kotlin/org/jetbrains/letsPlot/core/plot/base/aes/AesScaling.kt
Here you can see that it is just multiplication by coefficients, so you can make pixels in kandy API and just multiply by the opposite coeff one inside the translation - nothing complicated.
Text has its own size (It goes directly into the SVG element attribute, and how it will be rendered further does not depends on Lets-Plot).
Width, height (aesthetics and parameters) have relative units of measurement - a fraction of the "resolution" on the corresponding axis.

So here we can do next:

Add pixel units for common sizes
Add special units for width/height
With text - don't know

Anyway we should add documentations for size.

https://nbviewer.org/github/JetBrains/lets-plot-kotlin/blob/master/docs/examples/jupyter-notebooks/f-4.7.1/param_size_unit.ipynb


Add RE2 release 2023-09-01.

ImportError: Python version mismatch: module was compiled for Python 3.7, but the interpreter version is incompatible: 3.11.4 (main, Jul 26 2023, 13:23:24) [Clang 16.0.3 ].

How odd. I can yeet //python:all from test for now though.

Ugh. A couple of the matrix platforms are still sad about Python. I have yeeted @re2//python:re2 from build as well.


Add cosmwasm project prefix to REST query paths

Resolves #690

@ethanfrey @maurolacy

Thanks for the changes!


excel export failed

it seems column is too large ,how to fix this
HTTP ERROR 500

Problem accessing /command/core/export-rows/.xls. Reason:

    Invalid row number (65536) outside allowable range (0..65535)

Caused by:

java.lang.IllegalArgumentException: Invalid row number (65536) outside allowable range (0..65535)

Download instead of open.

you mean
Export-custom tabular exporter -download？

csv 不是只为 excel 提供的，如果 excel 不支持，就不要拿 excel 打开。
csv file is not only for excel, if excel not support it, don't open it with excel or anything like that. Download it and write code to parse it .

我是想下载excel的 没有找到操作的地方。


FOSS Backstage CfP

Hi @anajsana,
as discussed, I've added the FOSS Backstage CfP.
Best,
Sven

Great! Thank you 🙂


yieldRegion data function does not update it's route context after initial route render.  "this" has wrong context second time around.

Currently have this  route + controller configuration in Meteor <IP_ADDRESS>:
listCampaignUsersController = ViewPageController.extend({
    waitOn: function () {
        return [
            Meteor.subscribe('campaign', {campaignId: this.params.campaignId}),
            Meteor.subscribe('campaignCirclesUsers', {campaignId: this.params.campaignId})
        ];
    },
    yieldRegions: {
        'listCampaignUsers' : {
            to: 'view_page_content',
            data: function () {
                return {
                    campaign: x3.Collections.Campaigns.findOne({_id: this.params.campaignId})

                }
            }
        }
    }
});

Router.route('/view/page/:pageId/campaigns/users/:campaignId', {
    name: 'listCampaignUsers',
    controller: listCampaignUsersController,
    yieldTemplates: {}
});

The yieldRegions in listCampaignUsersController initially loads with campaignId "123" and inside the data method calls x3.Collections.Campaigns.findOne({_id: this.params.campaignId}) with "123".  After this initial load we direct to campaignId "567" but the context still points to the old route and this.params.campaignId is still "123".  That is we first go to route:
/view/page/1/campaigns/users/123
and after to
/view/page/1/campaigns/users/567
Inspecting "this" within the "data : function () {...}" shows that the url path still points to campaign "123" and the whole context is for the previous campaign "123" route even though the url points to "567".
Interestingly the waitOn always has the right context and this.params.campaignId points to the correct id on every parameter change.

I've also run into this problem. Until it gets fixed, using Router.current() instead of this in the data function will work.


It looks like you need a null check for image->rle  in tvgSwRaster.cpp

Looking at the code below,
if image->rle is null in _rasterRGBAImage, _transformedRGBAImage is called.
_rasterTexmapPolygon is called on _transformedRGBAImage.
In _rasterTexmapPolygon, imge->rle is null. If you check image->rle->size == 0 here, it seems to be a problem. isn't it?
static bool _rasterRGBAImage(SwSurface* surface, SwImage* image, const Matrix* transform, const SwBBox& region, uint32_t opacity)
{
    //RLE Image
    if (image->rle) {
        ...
    //Whole Image
    } else {
        ...
        else return _transformedRGBAImage(surface, image, transform, region, opacity); // this image->rle is must be null
    }
}

static bool _transformedRGBAImage(SwSurface* surface, const SwImage* image, const Matrix* transform, const SwBBox& region, uint32_t opacity)
{
    ...
     return _rasterTexmapPolygon(surface, image, transform, &region, opacity, _alpha); // this image->rle is must be null
    ...
}

static bool _rasterTexmapPolygon(SwSurface* surface, const SwImage* image, const Matrix* transform, const SwBBox* region, uint32_t opacity, uint32_t (*blendMethod)(uint32_t))
{
    //Exceptions: No dedicated drawing area?
    if (!region && image->rle->size == 0) return false; // Maybe the problem is because image->rle is null here, isn't it?
   ...
}

@JoogabYun Thanks for pointing it out, it sounds like an exceptional case. probably you can submit a null check there or wait for fixing it in a week.


Guidance on this page contradicts guidance on your global communications page

Hello Microsoft,
Please note conflicting guidance that should be updated to modern times (global English, global economy, global everything: it's a small world) for improved readability by all.
This advice, specifically, is outdated:
"When a phrase ending with a colon introduces a bulleted list:

If one or more list elements complete the introductory phrase preceding the colon, use a period after every list element."

I recommend deleting this, or better yet specifically say to never do this: use a phrase with a colon followed by list items that complete the phrase. It's confusing enough for native English speakers and anyone skimming text to quickly obtain information. Each bullet point must be a complete sentence, as must lead-ins to lists, to make a text readable, scannable, and readily comprehensible by all readers in all languages with all abilities/disabilities.

That advice specifically contradicts your advice on https://docs.microsoft.com/en-us/style-guide/global-communications/writing-tips:

"Limit your use of sentence fragments. Sentence fragments can be hard to translate."
I completely agree. Fragments are just plain wrong. I also know that removing fragments, particularly avoiding lead-in list fragments like this, is a main concept in both of the global/international English reference books cited at the bottom of your Global communications main page (https://docs.microsoft.com/en-us/style-guide/global-communications/), by Kohl and Weiss.
John Kohl's book is particularly against this, and he has SAS (Statistical Analysis Software) Inc.'s research behind it. (One of my favorite reference books, written by a former co-worker of mine who still owes me his draft 2nd edition...)
--Laura Schneider
I'm a 30-year veteran tech writer/editor and Microsoft Style fan.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d9effa55-fbb9-43e0-0281-e3f1db97c66c
Version Independent ID: 08bdee4f-2676-4337-f938-2024a4f23e01
Content: Periods - Microsoft Style Guide
Content Source: styleguide/punctuation/periods.md
Product: non-product-specific
GitHub Login: @pallep
Microsoft Alias: pallep

If possible, I'd love to work on this issue @LauraDSchneider! :)


Include string.h instead of string

When building with gcc12 I get:
[   61s] src/itemlistformaction.cpp:1142:21: error: 'strcasestr' was not declared in this scope; did you mean 'xmlStrcasestr'?
[   61s]  1142 |                 if (strcasestr(visible_items[i].first->title().c_str(),
[   61s]       |                     ^~~~~~~~~~
[   61s]       |                     xmlStrcasestr
[   61s] src/itemlistformaction.cpp:1149:21: error: 'strcasestr' was not declared in this scope; did you mean 'xmlStrcasestr'?
[   61s]  1149 |                 if (strcasestr(visible_items[i].first->title().c_str(),
[   61s]       |                     ^~~~~~~~~~
[   61s]       |                     xmlStrcasestr
[   61s] make: *** [Makefile:177: src/itemlistformaction.o] Error 1

I assume this has to do with strcasestr() being a non standard
function.

Hmm, this should have been fixed by https://github.com/newsboat/newsboat/pull/2056...
I think the correct fix is to add #define _GNU_SOURCE before #include <cstring>. I don't have GCC 12 here on Debian stable, so @jubalh, could you please test that approach? I'll look into adding GCC 12 to the CI.

I can't reproduce this problem using Ubuntu 22.04 and GCC 12. To be fair, I can't reproduce the problem that #2056 fixed either, so maybe it's not compiler-related? I ran out of time for now, but I'm interested to see if the #define I suggested will work for you.

I'll test it tomorrow (or the next days). I also thought about adding the define but found that it worked for me without this if I include the mentioned header. However I was not testing latest muster but only latest release + my patch.
Will test again and report back hopefully soon.

Yep https://github.com/newsboat/newsboat/pull/2056 works as well. Also without the define.


Fixing import and export issues with invalid tracks

Motivation and context

Sometimes tracks have duplicated shapes and export/import fails here: https://github.com/cvat-ai/cvat/blob/49ec1d175d9a9ce106158a7a7936e3c6622d3672/cvat/apps/dataset_manager/annotation.py#L953
it can be reproduced with following task backup (export fails):
InvalidTracksTaskBackup.zip
Also it can be reproduced with following CVAT 1.1 annotations (import to the task above fails)
InvalidImportAnnotations.zip
PR fixes https://github.com/cvat-ai/cvat/issues/8411
And (probably) fixes the following issues:
https://github.com/cvat-ai/cvat/issues/4968
https://github.com/cvat-ai/cvat/issues/5638
https://github.com/cvat-ai/cvat/issues/6779
How has this been tested?

Checklist

[ ] I submit my changes into the develop branch
[ ] I have created a changelog fragment
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (see GitHub docs)
[ ] I have increased versions of npm packages if it is necessary
(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)

License

[ ] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

New Features

Enhanced annotation management with improved filtering and interpolation of shapes and tracks.
Added new tests to verify interpolation behavior and slicing functionality.

Bug Fixes

Updated logic to prevent duplicate shapes during interpolation.

Tests

Increased test coverage for TrackManager and AnnotationIR classes, including new test methods and classes.

Chores

Updated formatting script to include additional test files for consistent code styling.

Hwllo, @Eldies
Here is the backup: https://disk.yandex.ru/d/S51OWHYeCTHDgw

@Eldies, Could you please resolve conflicts?

@Eldies, Could you please resolve conflicts?

resolved


install from git doesnt work

hi there,
When i use
    "ng2-select": "valor-software/ng2-select#development",
in my package.json file there are js and ts files missing.  Where does this come from?
Thanks for your ideas,
Martin

Ok, i think, it has to do with the build process, so I will figure it out and open a new issue if I think that has to do with the package rather than with my local settings.

ok, after installing phantomjs on my system it works.  :)  just to know if someone else has this problem.

How exactly does it work? I'm having the same problems, no ts files are pulled from git. JS files are in .gitignore FYI.
I have phantomjs installed and it still doesn't work and even if it did it would make no sense at all, the files are not pulled from the repository at all. Are you sure you didn't do something else?


use controller.view_paths to resolve view paths when calculating widget_class_from_file

in fortitude/lib/fortitude/rails/template_handler.rb you have Rails.application.paths['app/views'], which only searches path set via the configuration, and not ones added added at request time like those from prepend_view_path
view_paths can be used to get all the paths: http://api.rubyonrails.org/classes/ActionView/ViewPaths/ClassMethods.html#method-i-view_paths
The only issue with this is that it must be called in a request context, so the TemplateHandler's call method needs to be updated to do the look up at render time.

This has been fixed in 0.9.5, which I just released.


Complete slides 9 and 10

Write and decorate slides 9 and 10 of our CEC slide deck rough draft.


22 Feb 2024 - A11y Theme Builder Meeting Minutes

Date
2024-02-22 - 9:15am EST
Zoom info

Meeting link: https://zoom.us/j/91013899295?pwd=Qnh5UVN1aUZ4ak9tODgvMVNLNUg5Zz09
Meeting id: 910 1389 9295
Password: 123225
Call-in: +1<PHONE_NUMBER> US (New York) (Check calendar for more options)

Untracked attendees

Fullname, Affiliation, (optional) GitHub username
...

Meeting notices

FINOS Project leads are responsible for observing the FINOS guidelines for running project meetings. Project maintainers can find additional resources in the FINOS Maintainers Cheatsheet.

All participants in FINOS project meetings are subject to the LF Antitrust Policy, the FINOS Community Code of Conduct and all other FINOS policies.

FINOS meetings involve participation by industry competitors, and it is the intention of FINOS and the Linux Foundation to conduct all of its activities in accordance with applicable antitrust and competition laws. It is therefore extremely important that attendees adhere to meeting agendas, and be aware of, and not participate in, any activities that are prohibited under applicable US state, federal or foreign antitrust and competition laws. Please contact<EMAIL_ADDRESS>with any questions.

FINOS project meetings may be recorded for use solely by the FINOS team for administration purposes. In very limited instances, and with explicit approval, recordings may be made more widely available.

Agenda

[ ] Convene & roll call (5mins)
[ ] Display FINOS Antitrust Policy summary slide
[ ] Review Meeting Notices (see above)
[ ] Approve past meeting minutes
[ ] DEI Bronze Badge (#795)(@PaulaPaul )
[ ] State of Open Con videos available: https://www.youtube.com/watch?v=qeOxugYs4GQ
[ ] New wireframes in #752
[ ] Feedback on Epics: https://github.com/orgs/finos/projects/87/views/1?pane=issue&itemId=53391210
[ ] ...
[ ] AOB, Q&A & Adjourn (5mins)

Minutes

Decisions Made

[ ] Decision 1
[ ] Decision 2
[ ] ...

Action Items

[ ] Action 1
[ ] Action 2
[ ] ...

Evan K - DFS

Paula Paul @PaulaPaul - Greyshore

Cody Zuschlag - Nearform

Aaron Reed - DFS
Lise Noble - DFS

Approved in today's call.  I'll open issues for non-completed tasks.


Fixes shareImage for android - context was null

Merged in https://github.com/tjvantoll/nativescript-social-share/commit/f8aa71f2d900982faaed04c7b6f75b909e754cbb. Thanks @bradmartin!


Fix ability to add duplicate entities to lists

This PR fixes a bug where an admin could accidentally add multiple of the same command to the cluster and multiple of the same application to commands.
Because we need to maintain order between these entities we have to store them in a List so we can't use a set. This PR adds checks to make sure duplicates aren't added in the application code and enforces it also at the database level via unique indices.

Coverage increased (+0.02%) to 88.95% when pulling 9b777a552f5da57e65aa1563b381a0754834a99d on tgianos:develop into 7e8549b2627baa06a6a40bc978dc805d9d6923c1 on Netflix:develop.


[Bug] exercise "en/dart/variables/9.md" has an issue

Typos
It’s the exercise before this One that has a typo + there was an other Typo but I don’t remember but it was in this section of the course

closed by https://github.com/nank1ro/codigo-questions/pull/157

@all-contributors please add @Snowy-T for bug


Masthead Importance Increased

I've just noticed that this actually breaks the masthead... lol

lol noooo! #savethemastead


discord-canary: 0.0.138 -> 0.0.139

Description of changes
Updates discord-canary
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 190492 run on x86_64-linux 1

1 package built:

discord-canary

added a commit that adds myself to discord maintainers so I get notified about these PRs

Also added myself as a maintainer, since I've been proactively bumping discord-canary recently.


Automatic threading ban approval

This would, via a command, scan the thread for a discord id (in the title or body of the post) and then get it ready for a scam ban. This would be easy to implement, and be helpful for mobile users.
To get the thread title:
Check the channel type, if it's a typeof Thread, then you can just use the name property and it will give you the title in plain text.
To get the first post, we would have to read the message history.

This would require that all titles of posts are the discord id, which is not always the case. We may need to add message scanning in that scenario

Closing this, we've not seen any necessity to do so.


Add Somers' D and Kendall Tau-a/c correlation to scipy.stats

Kendall rank correlation has three different variations: tau-a, tau-b and tau-c (see Wikipedia). Currently Scipy can only compute Tau-b. Even though that might be a sane default choice, one occasionally encounters the other variants also and it would be nice to be able to compute them using Scipy.
Somers' D (see Wikipedia) is another (quite widely used) method for measuring ordinal association between random variables that can be easily written in terms of Kendall's Tau-a. Currently Scipy doesn't offer an easy way to compute Somers' D. It should probably be added
The question is also, if Kendall Tau-a/c gets added to Scipy, should it be three separate functions for each of them or a parameter of the current kendalltau() function that controls which variant is computed? I'm willing to submit a pull request in the near future implementing all three of the new functions if some executive decision is made about this.

I think it is better to add a and c to kendalltau directly instead of separate functions.

Question is answered and the open PR for kendalltau a/c is marked for 1.4.0. Somers'D looks less urgent, but seems useful as well. PR welcome after gh-9361 is merged I'd say.
I'll close this, since no need to keep open (we're doing enhancement request spring cleaning - higher-prio requests can be added to our roadmap, for the rest we don't want many open issues).

follow up here because I was looking at related issues for statsmodels (extensions to brunnermunzel and similar)
somers' d for association between binary and continuous variable can be directly computed from the rank version in brunnermunzel and (not fully verified) mannwhitneyu
https://github.com/statsmodels/statsmodels/issues/6960#issuecomment-673840980

@josef-pkt From your post there, it looks like you're getting a discrepancy between p-values?
Not sure if this helps, but there are two ways I've seen software compute p-values for these tests: one is under the null hypothesis that the statistic equals zero (e.g. SAS FREQ, gh-12653), and the other is under the more restrictive hypothesis of independence (e.g. R, SAS CORR). SAS uses one if you use the FREQ procedure, and uses the other for CORR.

Thanks for pointing out 12653, I didn't see that PR, (or didn't pay attention because I didn't know much about somers' d)
I'm not sure what p-values you are referring to. The p-value in the test is based on brunnermunzel which also essentially tests d=0.
I haven't compared with other p-values yet, e.g. mannwhiteney differs from brunnermunzel, but I didn't try to figure out details yet.


Microsoft teams - userv in organization but without license

I understand that Microsoft teams it is free to use. We are a start-up with 20 employees but I have license Office365 only for 10 (because they work at office.
For another 10 I want to use Teams but without license because they work on the field and use only Teams on mobile.
My ask is: I can create in Admin page the users without license and use the credential to use Teams (if it is free).
thx

thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.


Recover account: jwplayer

I work at JW Player. Unfortunately the maintainer of our PyPI account left the company and we are not sure what email was used to access the account so that we can recover it.
We maintain a package there and would like to takeover the account. If you can please provide me the email that would be greatly appreciated.

The email address associated with the account is a personal email address.
If you can make your membership in the https://github.com/jwplayer organization public, I can update the email address to whatever you'd like.
I'd also recommend adding some additional owners to the jwplatform project as well besides jwplayer.

Thanks @di. Just made it public: https://github.com/ksindi. Can you please update the address to<EMAIL_ADDRESS>

Done, you should have a password reset email in your inbox.

Awesome. Thanks @di! Very much appreciate the quick turnaround.


how to run the code?

I have read your code and try to run the code，but it failed。
firstly
the module “tfplot” I can‘t installed
secondly
there is no “datasets.mnist” module
so how can I do ? how to fix it?
thanks

Can you provide the error information as well as which commit did you clone?

Could you provide me with the further information of this issue?


More improvements to the PDB writer

Ping @pgbarletta, if you want to give this a look before it is merged.

All great fixes, especially  the 1-indexing in the PDB output.
This library keeps getting better and better.


Text options

Is there a reference for what object can be added in a 'text_field'?
I tried 'asset_tag' but it doesnt work.
Any help would be good

Hi @steele-ntwrk ! Any text fields of object can be added. If you want to add device's asset_tag try this config:
'text_fields': ['asset_tag']

Hi @k01ek ,
That worked, it seems like my configuration file had some errors in it causing it not pass in the plugins-config.
Cheers mate!


Bot stop move bug

one interesting thing observed, sometimes after a decent combat, bot low on health, they will recover themself by consuming food, after fully recovered, they will standing still forever, although they still say their lines to respond your commands, but they wont move at all.

I noticed that this occurs more often with casters and hunters, possibly others. Melee classes seem unaffected. Paladins are 50% affected. Might possibly be related to the spell loop error observed in the server output console.

@rogerc66 per the above merges I believe this has been largely improved if you can please close this issue out


community: update inclusive language guidelines

Also fix some easy low hanging fruit.
Part of https://github.com/envoyproxy/envoy/issues/11596
I will follow up with additional targeted changes for redis and client_ssl_auth.
Risk Level: Low
Testing: Existing tests
Docs Changes: N/A
Release Notes: N/A

cc @envoyproxy/maintainers


Final changes for mfem-4.5.2

Tasks:

[x] Merge #3293
[x] Merge #3362
[x] Merge #3369
[x] Merge #3320
[x] Merge #3387
[x] Merge #3402
[x] Merge #3394
[x] Merge #3271
[x] Merge #3403
[x] Merge #3417
[x] Merge #3285
[x] Merge #3364
[x] Check if hypre's changes in https://github.com/hypre-space/hypre/pull/765 affect us and report on their PR
[x] Arrange CHANGELOG entries
[x] Merge #3412
[x] Merge #3503
[x] Merge #3462
[x] Merge #3501
[x] Merge #3513
[x] Merge #3532 (directly in this PR)
[x] Set actual release date in CHANGELOG

After the release:

[ ] Switch to main? https://github.com/mfem/mfem/pull/3388

PR
Author
Editor
Reviewers
Assignment
Approval
Merge

#3384
@v-dobrev
@tzanio
@tzanio
2/9/23
⌛due 2/23/23
⌛due 3/2/23

PR Checklist

[ ] Code builds.
[ ] Code passes make style.
[ ] Update CHANGELOG:

[ ] Is this a new feature users need to be aware of? New or updated example or miniapp?
[ ] Does it make sense to create a new section in the CHANGELOG to group with other related features?

[ ] Update INSTALL:

[ ] Had a new optional library been added? If so, what range of versions of this library are required? (Make sure the external library is compatible with our BSD license, e.g. it is not licensed under GPL!)
[ ] Have the version ranges for any required or optional libraries changed?
[ ] Does make or cmake have a new target?
[ ] Did the requirements or the installation process change? (rare)

[ ] Update continuous integration server configurations if necessary (e.g. with new version requirements for each of MFEM's dependencies)

[ ] .github
[ ] .appveyor.yml

[ ] Update .gitignore:

[ ] Check if make distclean; git status shows any files that were generated from the source by the project (not an IDE) but we don't want to track in the repository.
[ ] Add new patterns (just for the new files above) and re-run the above test.

[ ] New examples:

[ ] All sample runs at the top of the example source file work.
[ ] Update examples/makefile:

[ ] Add the example code to the appropriate SEQ_EXAMPLES and PAR_EXAMPLES variables.
[ ] Add any files generated by it to the clean target.
[ ] Add the example binary and any files generated by it to the top-level .gitignore file.

[ ] Update examples/CMakeLists.txt:

[ ] Add the example code to the ALL_EXE_SRCS variable.
[ ] Make sure THIS_TEST_OPTIONS is set correctly for the new example.

[ ] List the new example in doc/CodeDocumentation.dox.
[ ] If new examples directory (e.g.examples/pumi), list it in doc/CodeDocumentation.conf.in
[ ] Companion pull request for documentation in mfem/web repo:

[ ] Update or add example-specific documentation, see e.g. the src/examples.md.
[ ] Add the description, labels and screenshots in src/examples.md and src/img.
[ ] In examples.md, list the example under the appropriate categories, add new categories if necessary.
[ ] Add a short description of the example in the "Extensive Examples" section of features.md.

[ ] New miniapps:

[ ] All sample runs at the top of the miniapp source file work.
[ ] Update top-level makefile and makefile in corresponding miniapp directory.
[ ] Add the miniapp binary and any files generated by it to the top-level .gitignore file.
[ ] Update CMake build system:

[ ] Update the CMakeLists.txt file in the miniapps directory, if the new miniapp is in a new directory.
[ ] Add/update the CMakeLists.txt file in the new miniapp directory.
[ ] Consider adding a new test for the new miniapp.

[ ] List the new miniapp in doc/CodeDocumentation.dox
[ ] If new miniapps directory (e.g.miniapps/nurbs), add it to MINIAPP_SUBDIRS in the makefile.
[ ] If new miniapps directory (e.g.miniapps/nurbs), list it in doc/CodeDocumentation.conf.in
[ ] Companion pull request for documentation in mfem/web repo:

[ ] Update or add miniapp-specific documentation, see e.g. the src/meshing.md and src/electromagnetics.md files.
[ ] Add the description, labels and screenshots in src/examples.md and src/img.
[ ] The miniapps go at the end of the page, and are usually listed only under a specific "Application (PDE)" category.
[ ] Add a short description of the miniapp in the "Extensive Examples" section of features.md.

[ ] New capability:

[ ] All new public, protected, and private classes, methods, data members, and functions have full Doxygen-style documentation in source comments. Documentation should include descriptions of member data, function arguments and return values, template parameters, and prerequisites for calling new functions.
[ ] Pointer arguments and return values must specify whether ownership is being transferred or lent with the call.
[ ] Any new functions should include descriptions of their intended use e.g. for internal use only, user-facing, etc., along with references to example code whenever possible/appropriate.
[ ] Consider adding new sample runs in existing examples to highlight the new capability.
[ ] Consider saving cool simulation pictures with the new capability in the Confluence gallery (LLNL only) or submitting them, via pull request, to the gallery section of the mfem/web repo.
[ ] If this is a major new feature, consider mentioning it in the short summary inside README (rare).
[ ] List major new classes in doc/CodeDocumentation.dox (rare).

[ ] Update this checklist, if the new pull request affects it.
[ ] Run make unittest to make sure all unit tests pass.
[ ] Run the tests in tests/scripts.
[ ] (LLNL only) After merging:

[ ] Update internal tests to include the new features.

Do we want to arrange the CHANGELOG entries here, or keep this as a "bugfix release" and do that in the next main release (4.6 or 5.0)?

Do we want to arrange the CHANGELOG entries here, or keep this as a "bugfix release" and do that in the next main release (4.6 or 5.0)?

I think it makes sense to do it here -- that's the first task above.

This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch.

I'm getting a link order error in HDF5 with this branch. I will investigate more tomorrow.

We think it might be this commit, but we are still investigating. https://github.com/mfem/mfem/commit/9a7f764ac78ab23c51d30659d913f7080ae16b4a

Issue write up for what @jamiebramwell was talking about: #3467
I dug pretty deep into this and am available for a talk if that would help.

Should the copyright year be updated to 2023?

Should the copyright year be updated to 2023?

If we want to do it, it should a separate PR, I think. However, I don't know if it is strictly necessary.

@dylan-copeland wrote:

Should the copyright year be updated to 2023?

@v-dobrev wrote:

If we want to do it, it should a separate PR, I think. However, I don't know if it is strictly necessary.

I made the copyright change in https://github.com/mfem/mfem/pull/3532. I think we can merge it here before the release.

This branch is now a release candidate mfem-4.5.2 which we plan to release on Friday, March 17th.
Please test it, report issues and approve it if everything looks good!
ping: @cyrush, @kennyweiss, @artv3, @tomstitt, @jamiebramwell

Everything looks good here!

We are able to build with this branch, will launch test next.

Merged in next for testing...


_mainError.txt does not show the complete info

Version
20240601
Describe the bug
When you get an error regarding (Track 1) (-LBA), the error message is not complete in _mainError.txt
I think _mainError.txt should show the complete info so that we won't lose it when closing the console. As it is now, it seems that the dump failed when it was actually successful.
Screenshots
Console
Creating (Track AA).scm & .sub (LBA)   301561/  301561
Creating (Track 0).scm & .sub, (Track 1)(-LBA).scm & .sub (LBA)    -1154/  -10000
Failed to read. readsize=2232, total_read=20805792/20808024 [F:ConvertScmToBin][L:3490]
[F:ConvertScmToBin][L:2854] GetLastError: 2, The system cannot find the file specified.

Failed to get (Track 1)(-LBA)
Retry 1/5
Creating (Track AA).scm & .sub (LBA)   301561/  301561
Creating (Track 0).scm & .sub, (Track 1)(-LBA).scm & .sub (LBA)    -1154/  -10000
Failed to read. readsize=2232, total_read=20805792/20808024 [F:ConvertScmToBin][L:3490]
[F:ConvertScmToBin][L:2854] GetLastError: 2, The system cannot find the file specified.

Failed to get (Track 1)(-LBA)
Retry 2/5
Creating (Track AA).scm & .sub (LBA)   301561/  301561
Creating (Track 0).scm & .sub, (Track 1)(-LBA).scm & .sub (LBA)    -1154/  -10000
Failed to read. readsize=2232, total_read=20805792/20808024 [F:ConvertScmToBin][L:3490]
[F:ConvertScmToBin][L:2854] GetLastError: 2, The system cannot find the file specified.

Failed to get (Track 1)(-LBA)
Retry 3/5
Creating (Track AA).scm & .sub (LBA)   301561/  301561
Creating (Track 0).scm & .sub, (Track 1)(-LBA).scm & .sub (LBA)    -1154/  -10000
Failed to read. readsize=2232, total_read=20805792/20808024 [F:ConvertScmToBin][L:3490]
[F:ConvertScmToBin][L:2854] GetLastError: 2, The system cannot find the file specified.

Failed to get (Track 1)(-LBA)
Retry 4/5
Creating (Track AA).scm & .sub (LBA)   301561/  301561
Creating (Track 0).scm & .sub, (Track 1)(-LBA).scm & .sub (LBA)    -1154/  -10000
Failed to read. readsize=2232, total_read=20805792/20808024 [F:ConvertScmToBin][L:3490]
[F:ConvertScmToBin][L:2854] GetLastError: 2, The system cannot find the file specified.

Failed to get (Track 1)(-LBA)
Retry 5/5

_mainError.txt
Failed to read. readsize=2232, total_read=20805792/20808024 [F:ConvertScmToBin][L:3490]
Failed to read. readsize=2232, total_read=20805792/20808024 [F:ConvertScmToBin][L:3490]
Failed to read. readsize=2232, total_read=20805792/20808024 [F:ConvertScmToBin][L:3490]
Failed to read. readsize=2232, total_read=20805792/20808024 [F:ConvertScmToBin][L:3490]
Failed to read. readsize=2232, total_read=20805792/20808024 [F:ConvertScmToBin][L:3490]

some changed.
DiscImageCreator_test.zip

I think it's much better now.
Failed to read. readsize=2232, total_read=20805792/20808024 [F:ConvertScmToBin][L:3490]
[F:ConvertScmToBin][L:2854] GetLastError: 2, The system cannot find the file specified.

is gone and _mainError only shows.
Failed to get (Track 1)(-LBA)
Retry 1/5
Failed to get (Track 1)(-LBA)
Retry 2/5
Failed to get (Track 1)(-LBA)
Retry 3/5
Failed to get (Track 1)(-LBA)
Retry 4/5
Failed to get (Track 1)(-LBA)
Retry 5/5

Thanks @saramibreak!


Join all channels on connect

After connecting to the server all channels should be joined. A missing bot in a channel is an indicator that something is wrong, so that is helpful.

Update:
I started a new branch called 'makeover' a few days ago which also changes the structure of a CptHook module. This also includes a getAllChannel() functions which we can call durint initialization to easily gather a list of all channels from all modules and join them.

The new branch just got merged into development.


default login seems not to work

I installed dependency track in a tomcat7 environment running on ubuntu and also get the login screen but the default login credentials admin/admin do not work (athentication failure invalid username or password)

Did you deploy the war for version 1.0, or did you compile from the master branch?

I used the pre compiled version 1.0 and installed it via the tomcat7 manager webgui

I'm having the same problem: a freshly-installed precompiled WAR version 1.0 does not allow login with admin/admin. As one may guess, this is a complete blocker :-)

Hello, i'm having problems with default login in both versions, pre-compiled (.WAR)and compiled from source code. I installed it via the tomcat8 manager webgui to.
Is there any way to access the app?

I was able to login into the compiled master (b553c753ee4c63b505613c92bb0f7443a4c62db6) when run as Spring Boot app.

can you deploy the compiled version? i tried to compile and access and app works but login doesn't

Tomcat log contained errors saying that the server cannot create files under /usr/share/tomcat8/dependency-track. My /usr/share/tomcat8 was owned by root:root and had permissions 755, so Tomcat could not create directory dependency-track there. I do not know what should be the proper fix, but to get Dependency Track running I changed /usr/share/tomcat8 to be owned by tomcat8:tomcat8. It accepts "admin/admin" now.

I know this is an old issue, but I just downloaded the 1.0.0 GA release from OWASP and admin/admin worked for me.

v3.0 will also use the same type of directory structure. Although it defaults to ~/.dependency-track


style.css href when using a custom Express server

I'm using a custom Express server with next.js in a subdirectory. I have installed @zeit/next-css and added next.config.js and pages/_document.js per the README; however, /_next/static/style.css returns a 404. I've confirmed that the file is being built to .next/static/style.css. I've also tried to ping it at a few different URLs (e.g. /_next/-/static/style.css), but I can't find where it's being served. This is all true in both development and production. Do I need to configure the static folder in my custom server.js (code below)?
const express = require('express');
const next = require('next');

const dev = process.env.NODE_ENV !== 'production';
const app = next({ dir: './client', dev });
const handle = app.getRequestHandler();

app
  .prepare()
  .then(() => {
    const server = express();

    // custom routes
    server.get('/s/:id', (req, res) => {
      const actualPage = '/show';
      const queryParams = { id: req.params.id };
      app.render(req, res, actualPage, queryParams);
    });

    // default route
    server.get('*', (req, res) => {
      return handle(req, res);
    });

    server.listen(3000, err => {
      if(err) throw err;
      console.log('> Ready on http://localhost:3000');
    });
  })
  .catch(ex => {
    console.error(ex.stack);
    process.exit(1);
  });

Should work without any additions 🤔 https://github.com/zeit/next.js/blob/c92bc858f7665b6ea1a2e2d80455e47faf1aefec/server/index.js#L244

I have the same problem, only production.
/_next/static/style.css returns a 404.
I've also tried to ping it at a few different URLs
/src/_next/static/style.css
./src/_next/static/style.css

Just tried and I can't reproduce based on your code. Can you provide a minimal reproduction 👍

@timneutkens, thanks for taking a look. See here.

const app = next({ dir: './client', dev });
You're starting your app with ./client, but the server is inside the client folder. That's the reason.

Changing the line to
const app = next({ dir: '.', dev });
or
const app = next({ dev });
both cause the index page endpoint to throw a 404...

I added the following to server.js:
server.use('/static', express.static(path.join(__dirname, '.next/static')));
and changed the link in pages\_document.js to:
<link rel="stylesheet" href="/static/style.css" />
which works in development and production. Any potential watchouts with this approach?

TLDR - this issue was fixed here

https://github.com/zeit/next.js/pull/3722
https://github.com/zeit/next.js/commit/955cc82736f6e1e3913a8d94d549e40e5cf296d0

my setup
I was running into all of the same issues as @colinrcummings - after a lot of digging around there seems to be a discrepancy between where the distDir or dist directory gets place relative to a custom src directory.
Heres my setup:
// next.config.js
const withCSS = require('@zeit/next-css')

const opts = {
  distDir: '../dir', // the root of my project
}

module.exports = withCSS(opts)

// src/server.js
// I start my server with `NODE_PATH='./src' node src/server.js`
const next = require('next')

const port = parseInt(process.env.PORT, 10) || 3005
const express = require('express')
const expressRoutes = require('./express-routes')
const bodyParser = require('body-parser')

const dev = process.env.NODE_ENV !== 'production'
const app = next({ dir: 'src', dev, quiet: false })

const runServer = () => {
  const handle = app.getRequestHandler()
  const server = express()

  server.use(bodyParser.json())

  app.prepare()
    .then(() => {
      expressRoutes.register(app, server, handle)

      server.listen(port, (err) => {
        if (err) throw err
        /* eslint-disable no-console */
        console.log(`> Ready on http://localhost:${port}`)
      })
    })
}

runServer()

Finally, I had to track down the 404 for the static output - debugging a bunch, I found that the path resolutions inside of next/server were not relative to the dist directory.
https://github.com/zeit/next.js/blob/5.0.0/server/index.js#L243-L246
Changing it to
      '/_next/static/:path*': async (req, res, params) => {
        const p = join(this.dir, this.dist, 'static', ...(params.path || []))
        await this.serveStatic(req, res, p)
      },

Did the trick for me, but I'm using a local copy of next. I'm not sure this patch has made it to stable as of today.

Try to use "/static/css"
maybe you are using "static/css"

Wrong >                <link href="static/css/responsive.css" rel="stylesheet"/>
Correct >                <link href="/static/css/responsive.css" rel="stylesheet"/>


Add isRestored to ReplicaMetadata

Add a isRestored value to ReplicaMetadata in order to determine which Replicas are created from the restore API

I'd like us to create a new unit test inReplicaMetadataSerializerTest where we create a object with isRestore=true , then serialize it to JSON. then when we go to deseriaize it ensure it works? Also a test with isRestore=false
I think it might fail because ReplicaMetadataSerializer needs to account for this new variable?

Continuing this work in https://github.com/slackhq/kaldb/pull/357


Design/single page

I think this now works more or less as intended. There are some parts that are a bit hacky, but hopefully it's good enough for the screen cast, which is blocking on the redesign.
The way selections works is that if you have a single item selected, it'll be in the URL (and vice versa). If you have none more more than 1, you're on "/" and the selection is modified in the sidebar. This required a bit of a refactor to ComponentPage and HomePage.
Currently, a broken url redirects you to the HomePage and not NotFoundPage, but I can try to change that back if desired.
Merging a 9 day old branch with current master was a pain, so please let me know if you spot something that looks like it might have gone wrong in the merge!

@jake as per Samir's comment I will address your comments in the next PR, if that's okay!


coq_8_20: init at 8.20+rc1

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@vbgl successfully tested on https://github.com/coq-community/coq-nix-toolbox/pull/229

I’ve just added a few more changes and updated the testing PR.

Thanks, my plan was rather to add only very basic things so as to get Coq itself and then everyone can then add more but if those are easy bumps, let's indeed do them too.

Yes, they are indeed trivial changes, just enabling packages that are already here.