Error while running SV clone using the 'consensus' mode for SNVs

I want to input SNVs from multiple tools and would like to use SV Clone (with SNV) using the 'consensus' mode.
The tool does not output the required output files. Is there an example of the file that I could use with the 'consensus' mode ?
Thanks

Thanks. What should be the format for consensus file ?

Please see the documentation for the supported SNV VCF formats.

Hi,
Based on the documentation and using this file https://dcc.icgc.org/api/v1/download?fn=/release_28/Projects/BRCA-EU/simple_somatic_mutation.open.BRCA-EU.tsv.gz as an example, I created a file with the following columns to the consensus file:

chromosome
chromosome_start
chromosome_end
chromosome_strand
assembly_version
mutation_type
reference_genome_allele
mutated_from_allele
mutated_to_allele
total_read_count
mutated_allele_read_count

But, the SV Clone is not taking the SNV input.
Is there a column that might be missing ?
Or perhaps if you could point me to an example file (with open access) for the consensus approach that would be helpful.
Thank You

Can you please post the command and error message from SVclone, as well as a sample of your VCF input? The consensus format has t_ref_count and t_alt_count fields in the INFO field. I don't have a sample on hand as these data are behind ICGC access control.
There is nothing 'special' about this format specifically for consensus calls, it was just what was used in the PCAWG project by the variant calling working group. Any of the supported SNV formats will work when you create your SNV file, it will just depend on the VCF output you have available from your variant callers.

Here are the commands:
svclone annotate -i SV_input -b Bam -s sampleID --sv_format simple -cfg svclone_config.ini
svclone count -i sampleID/sampleID_svin.txt -b Bam -s sampleID
svclone filter -s sampleID -i sampleID/sampleID_svinfo.txt -p Purity_Ploidy_input.txt  --cnvs CNV_input.csv --snvs test_snv.txt --snv_format consensus
Attaching the input snv file as well.
test_snv.txt

Your SNV input is not in VCF format. Please see here for the VCF file format specification. An example vcf file is provided in the SVclone repository (this uses the mutect format).


Website resources - DIY Forms should show up for every county not just statewide

"3. Is there a way to automatically make ""Statewide"" a selection for each search, so people don't miss out on those resources if they forget to select it or don't read the description?
"
Sarah Freimiller, MoTenantHelp.org Resources - edits and additions(1-7).xlsx

Sarah made this comment, and will most likely be the one to maintain it, so I could show her how to add every county as a tag to every state.
But it also seems like there should be a way to reverse the parent-child relationship.

We are using a list of every county with statewide to fix this.  This can be done easily with airtable


[SR-15529] swift-format increases indent of multi-line string literals when using tabs for indentation

Previous ID
SR-15529

Radar
None

Original Reporter
@saagarjha

Type
Bug

Environment
.swift-format:
{
    "indentation": {
        "tabs": 1
    },
}

$ swift-format -v
0.50500.0

Additional Detail from JIRA

Votes
0

Component/s
swift-format

Labels
Bug

Assignee
None

Priority
Medium

md5: 59a5b2a30254b00568ce72e4b59f40db

Issue Description:
On this code (Note, the indentation is a literal tab)
let string = """
    Hello, this is a test string. \
    Here's another line.
    """

I'd expect this to be idempotent, but swift-format increases the indentation each time it runs:
let string = """
        Hello, this is a test string. \
        Here's another line.
        """

I have the same issue, I use VSCode and I have set format on save, so each time I save the swift file with the multi-line string it increases the indent by 1 tab.

Same issue, please fix it! thanks

I made a local fix (+unit test) for this issue on top of the 508.0.0 release, but when I was trying to prepare a pull request I noticed this issue doesn't repro on main branch anymore. So, I guess we just wait for the next full release.

Tracked in Apple’s issue tracker as rdar://126948240


Editor page structure and styling

Only presentational components and page layout; does not contain any functionality / interactivity yet.

Coverage remained the same at 71.067% when pulling 7181bbf1a04c5784ef22d4be50c632e93cd99a6a on editor-page-structure-and-styling into 81956d4b77ef4448a393970e9450ec38bac40fed on master.

Coverage remained the same at 71.067% when pulling 7181bbf1a04c5784ef22d4be50c632e93cd99a6a on editor-page-structure-and-styling into 81956d4b77ef4448a393970e9450ec38bac40fed on master.


Enable source link and bump compiler and language standard versions

What?
Enable source link and bump compiler version to v143 and language standard version to C++ 17 (to resolve source link path capital letters). Also updated the image pool to 2022 from 2019 since we bumped to v143.
Why?
Allow debugger to download underlying source files if needed
How?
Add source link package reference to config and vcxproj file
Testing?

[x] Ran end-to-end testing and ensured the file was downloaded from sourcelink while debugging

[x] Checked MSVC isn't dynamically linked
[x] Ran test build

@heaths Yes, ran the command and verified that there's no dynamic link to MSVCRT.


Fix frontend console warnings

Describe the bug
When running from the local development server, the console warns about some bugs like depreciated methods and not having ComponentWillUnmount in Canvas.js. This may cause memory leaks or future issues.
Screenshots
maybe add later

I figured out that the recompose library is one cause for the createFactory() warning. I checked their Git repo and it looks like there's already an issue about it, so there's not much we can do about that library.


High CPU on istio-pilot 1.20.1

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
Hi team,I recently upgraded Istio from version 1.18.5 to 1.20.1 in a sequential manner. While all other Istio components appear to be functioning correctly, I'm observing unusually high CPU usage within the istiod pod.
I've carefully reviewed the istiod pod logs and haven't found any apparent errors or anomalies. The logs seem to indicate normal operation.
kubectl top po -n istio-system -l app=istiod --sort-by=cpu
NAME                      CPU(cores)   MEMORY(bytes)    istiod-85486b756d-w95fc   838m         133Mi
Here that log:
2024-01-05T07:37:08.142755Z	info	ads	ADS: new connection for node:<some-node>-6988f5664f-k6z65.staging-125 2024-01-05T07:37:08.145675Z	info	ads	CDS: PUSH request for node:<some-node>-6988f5664f-k6z65.staging resources:98 size:103.2kB cached:94/94 2024-01-05T07:37:08.147129Z	info	ads	EDS: PUSH request for node:<some-node>-6988f5664f-k6z65.staging resources:83 size:18.6kB empty:0 cached:83/83 2024-01-05T07:37:08.170082Z	info	ads	LDS: PUSH request for node:<some-node>-6988f5664f-k6z65.staging resources:76 size:324.6kB 2024-01-05T07:37:08.174314Z	info	ads	RDS: PUSH request for node:<some-node>-6988f5664f-k6z65.staging resources:48 size:41.4kB cached:48/48 2024-01-05T07:37:42.553215Z	info	ads	ADS: "<IP_ADDRESS>:53508" <some-node>-7ddf6b766c-g5mgq.staging-114 terminated 2024-01-05T07:37:42.630604Z	info	ads	ADS: new connection for node:<some-node>-7ddf6b766c-g5mgq.staging-126 2024-01-05T07:37:42.632244Z	info	ads	CDS: PUSH request for node:<some-node>-7ddf6b766c-g5mgq.staging resources:98 size:103.1kB cached:94/94 2024-01-05T07:37:42.633317Z	info	ads	EDS: PUSH request for node:<some-node>-7ddf6b766c-g5mgq.staging resources:83 size:18.6kB empty:0 cached:83/83 2024-01-05T07:37:42.643037Z	info	ads	LDS: PUSH request for node:<some-node>-7ddf6b766c-g5mgq.staging resources:76 size:324.4kB 2024-01-05T07:37:42.648369Z	info	ads	RDS: PUSH request for node:<some-node>-7ddf6b766c-g5mgq.staging resources:48 size:41.3kB cached:48/48
istioctl analyze -A | grep -E 'Error|Warning'
Warning [IST0108] (Pod staging/<some-node>-7ddf6b766c-g5mgq) Unknown annotation: istio.io/rev Warning [IST0108] (Pod staging/<some-node>-6988f5664f-k6z65) Unknown annotation: istio.io/rev
istioctl proxy-status
NAME                                                         CLUSTER        CDS        LDS        EDS        RDS        ISTIOD                      VERSION <some-node>-7ddf6b766c-g5mgq.staging             Kubernetes     SYNCED     SYNCED     SYNCED     SYNCED     istiod-85486b756d-w95fc     1.20.1 <some-node>-6988f5664f-k6z65).staging             Kubernetes     SYNCED     SYNCED     SYNCED     SYNCED     istiod-85486b756d-w95fc     1.20.1
Version
$ istioctl version
client version: 1.20.1
control plane version: 1.20.1
data plane version: 1.20.1 (12 proxies)

$ kubectl version
Client Version: v1.28.4
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.27.5-gke.200

Additional Information
No response

Can you give the CPU profile result? You can refer to this https://github.com/istio/istio/wiki/Analyzing-Istio-Performance#cpu

hi @wulianglongrd this is CPU profile result

I have seen some clues and will submit an optimization PR later.

I think there have been some updates to the in-cluster analysis. I also had an optimization that could reduce the number of analysis loops, forgot to send it.

I think there have been some updates to the in-cluster analysis.

Maybe there is no performance problem in the master version?

I think there have been some updates to the in-cluster analysis.

Maybe there is no performance problem in the master version?

@wulianglongrd AFAIK there should be no related changes after https://github.com/istio/istio/pull/46647, which was released in 1.20. The analysis performance is not optimal and is keeping optiming, and there were also some discussions in the past about the optimization. I've also created an issue to track dependency analysis https://github.com/istio/istio/issues/48468, which could provide a better solution to the scalability issue.

Got it, thanks.

Reopen, because @hanxiaop has other optimizations.

I think this can be closed, the optimization will be available in 1.20.3.


robot_localization: 3.3.1-1 in 'rolling/distribution.yaml' [bloom]

Increasing version of package(s) in repository robot_localization to 3.3.1-1:

upstream repository: https://github.com/cra-ros-pkg/robot_localization.git
release repository: https://github.com/ros2-gbp/robot_localization-release.git
distro file: rolling/distribution.yaml
bloom version: 0.10.7
previous version for package: 3.3.0-2

robot_localization
* Moving to C++17 support (#725 <https://github.com/cra-ros-pkg/robot_localization/issues/725>)
* SHARED linking for Geographiclib (#624 <https://github.com/cra-ros-pkg/robot_localization/issues/624>) (#712 <https://github.com/cra-ros-pkg/robot_localization/issues/712>)
  * remove GeographicLib specific linking option
  Co-authored-by: Achmad Fathoni<EMAIL_ADDRESS>* Contributors: Stephan Sundermann, Tom Moore

Sync Released


auto-py-to-exe  ImportError

Describe the bug

Expected behavior

To Reproduce

My Platform

Additional context

Good afternoon,
I have recently tried to install auto-py-to-exe and had no errors at this step. The problem comes when I try to run the code. I get an error as follows:
ImportError: cannot import name 'chrome' from 'eel'
Complete Trace Log
C:>auto-py-to-exe
Traceback (most recent call last):
File "C:\Users\ANaberan\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 196, in _run_module_as_main
return run_code(code, main_globals, None,
File "C:\Users\ANaberan\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 86, in run_code
exec(code, run_globals)
File "C:\Users\ANaberan\AppData\Local\Programs\Python\Python310\Scripts\auto-py-to-exe.exe_main.py", line 4, in
File "C:\Users\ANaberan\AppData\Local\Programs\Python\Python310\lib\site-packages\auto_py_to_exe_main.py", line 10, in
from . import ui
File "C:\Users\ANaberan\AppData\Local\Programs\Python\Python310\lib\site-packages\auto_py_to_exe\ui.py", line 8, in
from . import utils
File "C:\Users\ANaberan\AppData\Local\Programs\Python\Python310\lib\site-packages\auto_py_to_exe\utils.py", line 8, in
from eel import chrome
ImportError: cannot import name 'chrome' from 'eel' (unknown location)
C:>
Regards and great work

Thanks, I will have a look into it and check out if any solution.


[cherry-pick-2.0.4] [Fix-7457] Support to search when pressing enter button in the search box

pr: #7461
Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Codecov Report

:exclamation: No coverage uploaded for pull request base (2.0.4-prepare@2f53c4f). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             2.0.4-prepare    #8372   +/-   ##
================================================
  Coverage                 ?   21.02%
  Complexity               ?     1577
================================================
  Files                    ?      536
  Lines                    ?    22426
  Branches                 ?     2642
================================================
  Hits                     ?     4716
  Misses                   ?    17234
  Partials                 ?      476

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f53c4f...5b22a38. Read the comment docs.


How to make the output colored?

I see that your emoticons are colored. What am I doing wrong?

@IonicaBizau: thanks for reporting this issue! :bow:
This gem works by simply converting emoji aliases to raw unicode characters: however, at this point, it's up to your system to render them appropriately.
As far as I know, Ubuntu does not support "colorful" emoji (I think it makes use of ttf-ancient-fonts) and therefore they'll be displayed very differently from the Mac version I showed in the screenshot.
Hope this helps! Thank you.


Auto hide vanquish widget

Auto hide the vanquish widget if its "0/0".

will do

done

that was fast


setup.sh: Set inherit_errexit after bash version check

inherit_errexit wasn’t available in bash 3. We have a check to show a
nice error message, but that check is after we set inherit_errexit in
setup.sh. So we can just move this to below the BASH_VERSINFO check.
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Thank you for this!


fix(docs): Change channel:analytics, bumping common ver

New version is 5.0.5, see linked PR.

@williamtdr,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

ooft, thats quite a version bump. Did you check everything looked good?

@ProbablePrime I know :( Can't check easily until the other PR gets approved and npm syncs... otherwise I'll have to the play with link and such

@ProbablePrime - all unit tests are passing. tested the result on local, and the version bump doesn't appear to affect anything. The scope is removed from /reference/oauth/index.html#oauth_scopes as expected.

Alright then thanks :)!

@ProbablePrime the major bump came from removing lodash and jojen from common, we should be good.


Fix memory leak caused by non-unregistered broadcast receiver

Fixes a memory leak that occurs when switching candash to the background (the activity is destroyed). This happens because a broadcast receiver is registered, but never destroyed.
This also installs LeakCanary as a debug implementation so that it will alert (via notification) if it detects a memory leak while running in debug mode (it will not run in production).
The downside is that when it detects a leak, it pauses the app for a short amount of time while it dumps the java heap. If this becomes a problem for those of us who daily-drive the app in debug mode, we can either increase the retained object threshold or remove LeakCanary.
For more info see https://square.github.io/leakcanary/fundamentals-how-leakcanary-works/

@osunick when you get a chance, can you test this for me since I don't have the official canserver hardware? This hotspot receiver would restart the viewModel when the hotspot state changed, so make sure that when tasker starts the hotspot that you still get data/updates on candash.
If it breaks it I can revert the last commit so that we keep the receiver but with the mem-leak fix.


app

i got this error when stop recording :
E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.writeit, PID: 3567
java.lang.AbstractMethodError: abstract method "void com.facebook.react.bridge.ActivityEventListener.onActivityResult(android.app.Activity, int, int, android.content.Intent)"
at com.facebook.react.bridge.ReactContext.onActivityResult(ReactContext.java:226)
at com.facebook.react.XReactInstanceManagerImpl.onActivityResult(XReactInstanceManagerImpl.java:620)
at com.facebook.react.ReactActivityDelegate.onActivityResult(ReactActivityDelegate.java:134)
at com.facebook.react.ReactActivity.onActivityResult(ReactActivity.java:77)
at android.app.Activity.dispatchActivityResult(Activity.java:6463)
at android.app.ActivityThread.deliverResults(ActivityThread.java:3738)
at android.app.ActivityThread.handleSendResult(ActivityThread.java:3785)
at android.app.ActivityThread.access$1400(ActivityThread.java:157)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1405)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:148)
at android.app.ActivityThread.main(ActivityThread.java:5525)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:730)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:620)

Is it a persistent error? Any more details?

It happens every time i try to record something
On Sat, Oct 15, 2016, 23:55 JoaoCnh<EMAIL_ADDRESS>wrote:

Is it a persistent error? Any more details?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/JoaoCnh/react-native-android-voice/issues/17#issuecomment-254010533,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEv7P8V6U2bF0Qbb_p5EQdB_sJkDJci9ks5q0T2ogaJpZM4KXyNH
.

What versions are you running?

LG g4 android version 6
"react": "15.3.2",
"react-native": "^0.35.0",
"react-native-android-voice": "^0.3.0",

I've just published v0.5.0. Please check if issues still persist for any of you and please feel free to report new ones.
Many thanks to everyone who contributed for v0.5.0 with PRs

@avishayhajbi Is the issue still persisting with v0.5.0?

@avishayhajbi is it working with v0.5.1? I'll close this issue for now. Feel free to re-open


docs: add NessunKim/slack-chatgpt to README

Hi. I built a simple Slack bot to use this lib!

Looks great @NessunKim – I'd highly suggest adding a screenshot to your repo to help people understand what it looks like in use 😄


Navs - activate hidden tab

In bootstrap 4 alpha 6 this code work (activate tab3, but only once)
In bootstrap beta 2 don't work, even once.

      Tab 1

      Tab 2

    Tab 1 Activate tab 3

    Tab 2

    Tab 3

It is necessary to be able to switch the panel from other panels, but at the same time in tab navs it was not

Bug reports must include a live demo of the problem. Per our contributing guidelines, please create a reduced test case via CodePen or JS Bin and report back with your link, Bootstrap version, and specific browser and OS details.

OS: Windows; Browser: FireFox & Chrome
Action steps:

Click "Activate Tab 3"
Click "Tab 2"
Click "Tab 1"
Click "Activate Tab 3"

Bootstrap-4 alpha-6: https://codepen.io/armres/pen/ooWRrb (Step 4 - don't work, tab 3 in step 4 don't show)
Bootstrap-4 beta-1: https://codepen.io/armres/pen/qVjdvE (After step 1, tab 3 don't hide)
Bootstrap-4 beta-2: https://codepen.io/armres/pen/NwjVMw (Step 1 - don't work, tab 3 - don't show)

@Johann-S

What version of Windows

@wolfy1339 updated post

We also need browser version.

@wolfy1339 update post

@Johann-S
Anyone

Is this still an issue?

seems a bug in v4.1.3 too: https://codepen.io/Johann-S/pen/JmrYNQ

I think this markup isn't supported by our plugin. Not sure if there's something we can do.

Closing as stale for v4. We'll be moving onto focus entirely on v5 and v4 will only see critical updates.


Migrate from dlib::scoped_ptr to std::unique_ptr

See #586

Right. That's good but I mean people who have written scoped_ptr in their own code will have issues unless the scoped_ptr declaration makes it into their code, which means the sockets code needs to include it even though it doesn't use it.

Ok, I'll do that. But by this logic any class that used to expose scoped_ptr in any part of non-private interface should reexport scoped_ptr.h through a local import

Indeed. But I think only the sockets expose such interfaces. Can't check at the moment though because I'm posting from my phone. But I'm pretty sure there aren't other APIs that expose it.

Looks good.  Thanks for another PR :)

In last Appveyor's log, besides the compiler running out of heap, there're C4503 warnings about exceeding name lengths. This could be because we replaced the old template with unique_ptr and perhaps is a real problem

Na, it's because of an order of header inclusion change you made accidentally.  I've had a pragma in dlib that disables it for a while but the ordering change made it not trigger.  I fixed it and the warnings are gone.
Also, the warning doesn't matter. See https://msdn.microsoft.com/en-us/library/074af4b6.aspx says that correct binaries are still produced even when this warning happens.
I also disabled parallel builds which seems to have stopped the out of memory problem.

Cool! Then we're done it seems :) It's been pleasure to work with you and thanks for the legendary lib!

You too, thanks for helping with dlib :)


util: show all the logs

This is not ideal but wip
Signed-off-by: Sébastien Han<EMAIL_ADDRESS>

It'd be better to somehow maintain a restartCount somewhere that we can use for comparison.


[webpack-cli] Invalid configuration object. Webpack has been initialized using a configuration object that does not match the API schema.  - configuration.module.rules[7].use has an unknown property 'query'. These properties are valid:    object { ident?, loader?, options? }

Got this error using webpack 5. Any help will be greatly appreciated

Sorry, this repo is no longer supported :(
I just merge pull requests.

@logivad do you know of any webpack plugin that will do the equivalent. I'm migrating an angularJs application that use this https://www.npmjs.com/package/gulp-ng-config to add constants.


Release azure-cli-lab 0.0.5

Reviewers, please verify the following for this PR:

[ ] The PR title has format Release <component-name> <version>.
[ ] setup.py has been modified with the same version as in the PR title.
[ ] HISTORY.rst has been modified with appropriate release notes.
[ ] If releasing azure-cli or azure-cli-core, __version__ defined in __init__.py should also be modified to match.

Started releasing azure-cli-lab 0.0.5...

Release of 'azure-cli-lab' with version '0.0.5' successful. View at https://pypi.python.org/pypi/azure-cli-lab/0.0.5.

GitHub release created. https://github.com/Azure/azure-cli/releases.


Modal window closed too late

When I call $uibModalInstance.dismiss() modal window is closed immediately. However, if I click the backdrop, it takes up to 8 seconds for modal window to close.
This started to happen after I migrated from version 0.13.4 to 0.14.3.

http://plnkr.co/ examples please?

@erkanarslan, please do not use the issues forum for support related requests.  Rather, please follow the instructions here.  The issues forum is reserved for bugs.
If you think you've found a bug, please follow these instructions.
Unfortunately, if you think you have found a bug and do not follow the above instructions within a reasonable amount of time, we will close the issue due to lack of activity.


fix(userspace/libsinsp): restore windows build

What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This attempts restoring the windows build and tests, broken in my previous PR by rearranging the ifinfo tests.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 290ee591e164f1553d888c34904c924c79bc1b18

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


specify Pod not to display redundant messages

Nice fix
/lgtm

I'm not sure about it. In the first step, we get the pod until no longer running, should we can get the specify pod in the secondary step?

@stewart-yu You might be right.
I thought other pods output could be a hindrance and so it could be tough to find the target information. What's more, given the pod name termination-demo is specified in the step 4, it should also be specified in the step 3 in my opinion.
However, there might be some reason for not specifying the pod name in the step 3. Otherwise, step 2 could have -o yaml option.

I agree that it's good to include the Pod name in both commands.
/approve
/lgtm


business_title is not coming part of this process.

[Enter feedback here]
Hi Team,
Please review and let us know at the earliest possible, we are not able to see business_title on Microsoft side of provisioning, where as the XML from Workday side, it has data
---Begin from Workday---
wd:Position_TitleIT Help Desk Technician</wd:Position_Title>
wd:Business_TitleHelpdesk Admin</wd:Business_Title>
---End from Workday---
Thanks,
Ramesh
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 799c371a-a17e-08aa-ef56-86eef2395f7e
Version Independent ID: 1339cc93-712c-3a32-8321-dfd016a50ed4
Content: Tutorial: Configure Workday for automatic user provisioning with on-premises Active Directory - Microsoft Entra
Content Source: articles/active-directory/saas-apps/workday-inbound-tutorial.md
Service: active-directory
Sub-service: saas-app-tutorial
GitHub Login: @cmmdesai
Microsoft Alias: chmutali

Posting again from the WD side:
wd:Position_TitleIT Help Desk Technician</wd:Position_Title>
wd:Business_TitleHelpdesk Admin</wd:Business_Title>

@dvrameshusa
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

Please also explain how to see the full XML file in Microsoft side, so that we will know, whether the information is reached/fetched or not.
Thanks in advance,
Ramesh

@dvrameshusa, we closing this issue and tracking the updates internally. Thank you for contributing to our docs.
#please-close


Civ 6062_6064 WA-3.5 Update General Apps Configuration and Permissions DMN

Before creating a pull request make sure that:

[x ] commit messages are meaningful and follow good commit message guidelines
[ x] README and other documentation has been updated / added (if needed)
[x ] tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CIV-6062
https://tools.hmcts.net/jira/browse/CIV-6064
Change description
-WA R3.5 Update the GA DMN files with the CTSC role category for specific access
-WA R3.5 Migrate old permissions to new model in the General Apps DMN file
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x ] No

GA Task Configuration DMN changes

GA Permissions DMN changes


Order of the trace coming to zipkin

Does zipkin trace needs to get processed in the order they are generated ?
For applciation M1-->M2-->M3
I have zipkin dependency showing as M1-->M3.
From the zipkin trace logs, I see M3 pointing to parent ID of M2, which is not available in zipkin trace.
If m2 trace comes later will it get processed.
Thanks
Prateek

No problem, they can be generated and processed out of order.

So in that case we need to have a fix in zipkin dependencies, as it showing traces from M1 -->M3, when some of the M2 traces have got dropped , it should take into account the parent span id of M3 and whether it exist in system , before defining the dependencies, else it gets a wrong picture projected

Sounds possible to remedy, but it also is easy to miss a detail.
To make sure we are clear, can you post a simplified json with a missing
span and the links you expect and what heuristic you would use to decide
how to create the pseudo link? Even better a pull request.
On 8 Jul 2017 07:11, "jprateekvmware"<EMAIL_ADDRESS>wrote:

So in that case we need to have a fix in zipkin dependencies, as it
showing traces from M1 -->M3, when some of the M2 traces have got dropped ,
it should take into account the parent span id of M3 and whether it exist
in system , before defining the dependencies, else it gets a wrong picture
projected
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/zipkin/issues/1648#issuecomment-313813507,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD61wEmTCL4eDbFSlT96BnOn-uLTSdWks5sLrsIgaJpZM4ORhDs
.

Done
Will track as part of it
https://github.com/openzipkin/zipkin-dependencies/pull/75

please don't re-open the issue there.. the tests are here, and likely any code around it will be, too.

@jprateekvmware I've changed the title of this to "Skip dependency links for missing intermediates" as that's the best I can understand your scenario so far.
Can you explain why you are creating child spans in an intermediary, but not reporting them to Zipkin. It is one thing for this to be an exception, but it is certainly unexpected to do routinely. Help me understand?

ps you can also hop on gitter to chat about this, too https://gitter.im/openzipkin/zipkin

Viewing JSON will reduce the round-trips on this issue (and spam to folks subscribed), please attach a pasted link to json of a trace that matches this scenario before proceeding further.

I will be there, Thanks adrian

Publishing the JSON payload.
Dependencies is captured as api-gateway--->M1-service--> central-service [Which is wrong]
whereas when i track the dependency tree based on parent id its perfect
api-gateway--> central-service--->M1-service
[
{
"traceId": "787a41fdfb6d59cb",
"name": "http:/api/v1/testworflow",
"id": "fe70d9705ea17279",
"parentId": "94aa5c0443cc5582",
"timestamp":<PHONE_NUMBER>112500,
"duration": 6099000,
"annotations": [],
"binaryAnnotations": [
{
"key": "http.host",
"value": "incoming.url.com",
"endpoint": {
"serviceName": "central-service",
"ipv4": "<IP_ADDRESS>",
"port": 3008
}
},
{
"key": "http.method",
"value": "POST",
"endpoint": {
"serviceName": "central-service",
"ipv4": "<IP_ADDRESS>",
"port": 3008
}
},
{
"key": "http.path",
"value": "/api/v1/testworflow",
"endpoint": {
"serviceName": "central-service",
"ipv4": "<IP_ADDRESS>",
"port": 3008
}
},
{
"key": "http.url",
"value": "http://incoming.url.com:9090/api/v1/testworflow",
"endpoint": {
"serviceName": "central-service",
"ipv4": "<IP_ADDRESS>",
"port": 3008
}
},
{
"key": "lc",
"value": "unknown",
"endpoint": {
"serviceName": "central-service",
"ipv4": "<IP_ADDRESS>",
"port": 3008
}
}
]
},
{
"traceId": "787a41fdfb6d59cb",
"name": "http:/myapp/api/v1/testworflow",
"id": "787a41fdfb6d59cb",
"timestamp":<PHONE_NUMBER>125000,
"duration": 6102000,
"annotations": [
{
"timestamp":<PHONE_NUMBER>125000,
"value": "sr",
"endpoint": {
"serviceName": "api-gateway",
"ipv4": "<IP_ADDRESS>",
"port": 9090
}
},
{
"timestamp":<PHONE_NUMBER>227000,
"value": "ss",
"endpoint": {
"serviceName": "api-gateway",
"ipv4": "<IP_ADDRESS>",
"port": 9090
}
}
],
"binaryAnnotations": [
{
"key": "http.host",
"value": "incoming.url.com",
"endpoint": {
"serviceName": "api-gateway",
"ipv4": "<IP_ADDRESS>",
"port": 9090
}
},
{
"key": "http.method",
"value": "POST",
"endpoint": {
"serviceName": "api-gateway",
"ipv4": "<IP_ADDRESS>",
"port": 9090
}
},
{
"key": "http.path",
"value": "/myapp/api/v1/testworflow",
"endpoint": {
"serviceName": "api-gateway",
"ipv4": "<IP_ADDRESS>",
"port": 9090
}
},
{
"key": "http.url",
"value": "https://incoming.url.com:9090/myapp/api/v1/testworflow",
"endpoint": {
"serviceName": "api-gateway",
"ipv4": "<IP_ADDRESS>",
"port": 9090
}
}
]
},
{
"traceId": "787a41fdfb6d59cb",
"name": "http:/myapp/api/v1/testworflow",
"id": "94aa5c0443cc5582",
"parentId": "787a41fdfb6d59cb",
"timestamp":<PHONE_NUMBER>125000,
"duration": 6102000,
"annotations": [
{
"timestamp":<PHONE_NUMBER>112500,
"value": "sr",
"endpoint": {
"serviceName": "central-service",
"ipv4": "<IP_ADDRESS>",
"port": 3008
}
},
{
"timestamp":<PHONE_NUMBER>125000,
"value": "cs",
"endpoint": {
"serviceName": "api-gateway",
"ipv4": "<IP_ADDRESS>",
"port": 9090
}
},
{
"timestamp":<PHONE_NUMBER>140500,
"value": "sr",
"endpoint": {
"serviceName": "M1-Service",
"ipv4": "<IP_ADDRESS>",
"port": 4060
}
},
{
"timestamp":<PHONE_NUMBER>209500,
"value": "ss",
"endpoint": {
"serviceName": "M1-Service",
"ipv4": "<IP_ADDRESS>",
"port": 4060
}
},
{
"timestamp":<PHONE_NUMBER>211500,
"value": "ss",
"endpoint": {
"serviceName": "central-service",
"ipv4": "<IP_ADDRESS>",
"port": 3008
}
},
{
"timestamp":<PHONE_NUMBER>227000,
"value": "cr",
"endpoint": {
"serviceName": "api-gateway",
"ipv4": "<IP_ADDRESS>",
"port": 9090
}
}
],
"binaryAnnotations": [
{
"key": "lc",
"value": "zuul",
"endpoint": {
"serviceName": "api-gateway",
"ipv4": "<IP_ADDRESS>",
"port": 9090
}
},
{
"key": "sa",
"value": true,
"endpoint": {
"serviceName": "api-gateway",
"ipv4": "<IP_ADDRESS>",
"port": 9090
}
}
]
},
{
"traceId": "787a41fdfb6d59cb",
"name": "http:/api/v1/action/approve",
"id": "f5f9dcc8edb20ae7",
"parentId": "94aa5c0443cc5582",
"timestamp":<PHONE_NUMBER>140500,
"duration": 6069000,
"annotations": [],
"binaryAnnotations": [
{
"key": "http.host",
"value": "<IP_ADDRESS>",
"endpoint": {
"serviceName": "M1-Service",
"ipv4": "<IP_ADDRESS>",
"port": 4060
}
},
{
"key": "http.method",
"value": "POST",
"endpoint": {
"serviceName": "M1-Service",
"ipv4": "<IP_ADDRESS>",
"port": 4060
}
},
{
"key": "http.path",
"value": "/api/v1/action/approve",
"endpoint": {
"serviceName": "M1-Service",
"ipv4": "<IP_ADDRESS>",
"port": 4060
}
},
{
"key": "http.url",
"value": "http://<IP_ADDRESS>:4060/api/v1/action/approve",
"endpoint": {
"serviceName": "M1-Service",
"ipv4": "<IP_ADDRESS>",
"port": 4060
}
},
{
"key": "lc",
"value": "unknown",
"endpoint": {
"serviceName": "M1-Service",
"ipv4": "<IP_ADDRESS>",
"port": 4060
}
}
]
},
{
"traceId": "787a41fdfb6d59cb",
"name": "http:/api/v1/action/approve",
"id": "b963390959854a97",
"parentId": "fe70d9705ea17279",
"timestamp":<PHONE_NUMBER>168000,
"duration": 6071000,
"annotations": [
{
"timestamp":<PHONE_NUMBER>168000,
"value": "cs",
"endpoint": {
"serviceName": "central-service",
"ipv4": "<IP_ADDRESS>",
"port": 3008
}
},
{
"timestamp":<PHONE_NUMBER>239000,
"value": "cr",
"endpoint": {
"serviceName": "central-service",
"ipv4": "<IP_ADDRESS>",
"port": 3008
}
}
],
"binaryAnnotations": [
{
"key": "sa",
"value": true,
"endpoint": {
"serviceName": "central-service",
"ipv4": "<IP_ADDRESS>",
"port": 3008
}
}
]
},
{
"traceId": "787a41fdfb6d59cb",
"name": "https:/outside-url/test//approve",
"id": "b49392870c173a9f",
"parentId": "f5f9dcc8edb20ae7",
"timestamp":<PHONE_NUMBER>171000,
"duration": 6066000,
"annotations": [
{
"timestamp":<PHONE_NUMBER>171000,
"value": "cs",
"endpoint": {
"serviceName": "M1-Service",
"ipv4": "<IP_ADDRESS>",
"port": 4060
}
},
{
"timestamp":<PHONE_NUMBER>237000,
"value": "cr",
"endpoint": {
"serviceName": "M1-Service",
"ipv4": "<IP_ADDRESS>",
"port": 4060
}
}
],
"binaryAnnotations": [
{
"key": "sa",
"value": true,
"endpoint": {
"serviceName": "M1-Service",
"ipv4": "<IP_ADDRESS>",
"port": 4060
}
}
]
},
{
"traceId": "787a41fdfb6d59cb",
"name": "async",
"id": "16efa3c1cc735c3c",
"parentId": "fe70d9705ea17279",
"timestamp":<PHONE_NUMBER>239000,
"duration": 27000,
"annotations": [],
"binaryAnnotations": [
{
"key": "lc",
"value": "async",
"endpoint": {
"serviceName": "central-service",
"ipv4": "<IP_ADDRESS>",
"port": 3008
}
},
{
"key": "thread",
"value": "SimpleAsyncTaskExecutor-1044",
"endpoint": {
"serviceName": "central-service",
"ipv4": "<IP_ADDRESS>",
"port": 3008
}
}
]
},
{
"traceId": "787a41fdfb6d59cb",
"name": "updateauditlog",
"id": "0436028911f276fe",
"parentId": "16efa3c1cc735c3c",
"timestamp":<PHONE_NUMBER>239000,
"duration": 27000,
"annotations": [],
"binaryAnnotations": [
{
"key": "class",
"value": "AuditLogService",
"endpoint": {
"serviceName": "central-service",
"ipv4": "<IP_ADDRESS>",
"port": 3008
}
},
{
"key": "lc",
"value": "async",
"endpoint": {
"serviceName": "central-service",
"ipv4": "<IP_ADDRESS>",
"port": 3008
}
},
{
"key": "method",
"value": "updateAuditLog",
"endpoint": {
"serviceName": "central-service",
"ipv4": "<IP_ADDRESS>",
"port": 3008
}
}
]
}
]

@jprateekvmware There are a large number of data errors in your trace. Make sure you are using latest versions of whatever instrumentation you are using, then try again. I've parsed the easy to spot problems below:
span 94aa5c0443cc5582: there's an instrumentation bug as a span should have at most one core annotation (core annotation is cs, sr, ss, cr). Yours has 2 servers responding to a single client.
span b963390959854a97 b49392870c173a9f: these are client spans, but have their endpoint (the one on cs, cr) marked as the same as its remote (the one on sa). This seems like a bug unless they are supposed to be calling themselves? They are also missing http tags, which are placed on their parents. more on that below:
span fe70d9705ea17279 f5f9dcc8edb20ae7: these look a bit distracting as they have http tags (binary annotations), yet are marked local. These will be treated as process local spans, but they seem to be half-the-data of their children.

I got all the traces arranged and it seems the
Api-gateway is pointing to m1-service.
94aa5c0443cc5582-->f5f9dcc8edb20ae7, seems problem with the way the data is generated from the Spring Sleuth, I will try having it updated with the latest version. it does not seems zipkin -dependency for the above JSON issue. But will have other use case typed
787a41fdfb6d59cb(6.102s) (api-gateway)
94aa5c0443cc5582(6.102s) (api-gateway)
fe70d9705ea17279(central-service)
b963390959854a97(central-service)
16efa3c1cc735c3c(central-service)
0436028911f276fe(central-service)
f5f9dcc8edb20ae7(M1-service)
b49392870c173a9f(M1-service)

OK please get back once things are upgraded as sleuth fixes a lot of
things. By not troubleshooting until you have things up to date, it also
reduces the amount of times folks following this repo are spammed with
comments.

I guess not, or no longer relevant. @jprateekvmware Feel free to open a new issue if this pops up again, thanks!


add default language placeholder

This PR adds a default label to the language switcher so it is not blank when you first load the page.
Resolves: https://github.com/the-hideout/tarkov-dev/issues/93

.deploy


fix JSdocs of assertAccountDefined in runtime.ts

add JSdocs param address.
add a simple address check. (maybe not needed)
Proposed Changes
+JSdocs param address.
+a simple address check. (maybe not needed)
+
Why
The point of this PR(my intention) was the calling pattern, although it's functionally correct:
This assertAccountDefined can be done before TS compile, but maybe for JS it's needed. I saw two passed args (address and  account) when I was with TS. This would be a little bit confusing, for making users think the address and the account are related.
Example
E.g. For assertAccountDefined(acc1.address,acc2), naming like assertItsGood. It's hard to see if the output would be

boolean
an acc, but unclear whether the output would be acc1 or acc2
does it asserts acc1==acc2 (at least with same addr)

This PR resolves the ambiguity of (2) and (3)
Potential followups
This function works like a filter, maybe renaming it would be better?

Any updates?

@PabloLION could you please resolve the conflicts? I have approved your PR, will merge.

@ratik21 Sorry for being late. I checked it on my phone then totally forgot about it.

Sorry that I made a space-before-blocks error for yarn lint. I just fixed it, please approve the workflow to check. Thanks.

Emmm...
I saw a bunch of ModuleNotFoundError: No module named 'yaml' and ModuleNotFoundError: No module named 'pyteal'
And I don't know how to fix. Actually I had the same error while running locally a while ago(before it was all good).
Could someone from the team fix this?

Emmm... I saw a bunch of ModuleNotFoundError: No module named 'yaml' and ModuleNotFoundError: No module named 'pyteal' And I don't know how to fix. Actually I had the same error while running locally a while ago(before it was all good). Could someone from the team fix this?

yeah, it's a separate issue. We'll fix it.

Thanks.


Module does not work when running locally via Docker

I've installed this module on a 4.3 site and I'm stuck at the following error. I cannot run dev/build... this is the error I get when I try to do that:
[Emergency] Uncaught Aws\Exception\CredentialsException: Error retrieving credentials from the instance profile metadata server. (cURL error 28: Connection timed out after 1001 milliseconds (see http://curl.haxx.se/libcurl/c/libcurl-errors.html))
After some googling it seems that the module is behaving as-if installed on an EC2 instance... the error seems to indicate that it's trying to get information about the EC2 instance it's running on but I'm running it locally via docker.
Things I have tried:

Adding these fields to my .env file

AWS_REGION = "us-east-1"
AWS_BUCKET_NAME = "bucket-name"
AWS_ACCESS_KEY_ID="XXXXX"
AWS_SECRET_ACCESS_KEY="YYYYY"

Creating a ~/.aws/credentials file with the following contents:

[default]
AWS_ACCESS_KEY_ID = XXXX
AWS_SECRET_ACCESS_KEY = YYYY

Adding the ENV values directly to docker-compose.yml

services:
  db:
    image: mysql:5.7
    environment:
      MYSQL_ROOT_PASSWORD: root
      MYSQL_DATABASE: web_db
      MYSQL_USER: devuser
      MYSQL_PASSWORD: devpass
    ports:
      - "9909:3306"
    volumes:
      - web-db:/var/lib/mysql
  web:
    build:
      dockerfile: docker/Dockerfile
      context: ./
    environment:
      SHELL: /bin/bash
      AWS_REGION: us-east-1
      AWS_BUCKET_NAME: bucket-name
      AWS_ACCESS_KEY: XXXXX
      AWS_SECRET_ACCESS_KEY: YYYYY
    volumes:
      - ./app:/work/app
      - ./html:/work/html
      - ./public:/work/public
      - ./themes:/work/themes
    depends_on:
      - db
    ports:
      - "8101:80"
    links:
      - db
volumes:
  web-db:

Nothing I do seems to change how the client is being created... please advise if there's something I'm doing wrong or something missing from the docs (highly unlikely).

You will need to update your yaml config to make sure the aws credentials are being used.
In your /app/_config/app.yml or whatever yml config file you are using for your project, add something like the following -
---
Only:
  envvarset: AWS_BUCKET_NAME
After:
  - '#assetsflysystem'
---
SilverStripe\Core\Injector\Injector:
  Aws\S3\S3Client:
    constructor:
      configuration:
        region: '`AWS_REGION`'
        version: latest
        credentials:
          key: '`AWS_ACCESS_KEY_ID`'
          secret: '`AWS_SECRET_ACCESS_KEY`'
  Intervention\Image\ImageManager:
    constructor:
      - { driver: imagick }

By default it is expecting you to be on some type of amazon system but outside if you have the following in your config you will be all set.  One thing you can do is also setup a separate yml file that is ignored from git like your .env file that contains this info as well separate from your main apps config (this is what we do locally)

This worked! Thank you  @obj63mc much for the lightning fast response ⚡
Is there any downside to leaving this .yml file in when deploying? Is it basically "overkill" to have this in prod becasue the module is set up to operate this way by default... and having the .yml file basically is more descriptive and explicit about how it's configured?

Since I host on heroku and not amazon such as say on EC2, I am not sure if the environment variables are set for AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY by default, if those two variables are not set then you would probably get a connection error when trying to access the bucket.
If those environment variables are set at your hosting provider, you can definitely leave it checked in.  The main thing is that when hosting on amazon EC2 by example, as long as you have your servers configured to your S3 buckets then you shouldn't need to specify that information.


Add Yong Wang to Contributors list

The first pull request of Yong Wang

@yongwangd, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added Facebook share and tweet feature to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

@Roshanjossey, I have been a front-end developer for a few years, and have used hundreds of open source projects. I have created quite a few GitHub repos for my personal kinds of stuff, but haven't been able to contribute to other projects. I have always wanted to start contributing to open source projects, but the first step just looks confusing to me.
I went through the tutorial yesterday and find it pretty easy to follow, considering that I have some knowledge of Git. I do appreciate your good work on this repository, and it's very helpful. I will share it when I get back home.
Regards,

@yongwangd, I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://firstcontributions.herokuapp.com

@Roshanjossey I have joined the slack channel and You have been so helpful! I definitely will start contributing to other open source projects.


Model binding doc updates

Fixes #10502
Fixes #12190
Internal staging link

Currently reviewing the docs and code...


Feature/expand e2e tests

Summary | Résumé
@dsamojlenko recently revived the Detox e2e tests in PR #1338 In this follow up PR, a new test is created to validate features of the app's internal Demo menu.
Note: testing the sample notification is a tricky feat, as the notification popup is a system-generated element and not part of our app. Thus, in Detox tests we can't easily apply an ID handle to it, which would be needed to easily reference the popup among the many elements that make up the UI stack..
On ios, we could probably do something weird like matching "by.type('_UIAlertControllerActionView')" but further research is required for this, and for android..
Also, I had no issues using an iOS Emulator for screenshots, despite some of our old docs saying the contrary.

 Create scripted end to end tests with Detox

 Create scripted end to end tests with Detox

I want to note that these tests seems broken on android for whatever reason... putting this on the backburner as we attempt to upgrade the Detox version we're running

I want to note that these tests seems broken on android for whatever reason... putting this on the backburner as we attempt to upgrade the Detox version we're running

Work here is done! Ended up not moving to v18 as lift was too large. going to move on for now and get this merged soon


How to throw a animate plot to html page

Hello!
I'm writing the .fif format file viewer (the graph) on the server environment.
Recently putted out the dynamic real-time brainwave graph on python with mne,
but I want let the graph viewing on the Internet browser.
Is there anyway to figure it out?
Thank you!

This appears to be a question about usage, not a bug report or a new feature request. Please use the MNE mailing list or the gitter channel for usage questions.


Grant permission for type resolution Gradle job

Broken main CI since yesterday because https://github.com/detekt/detekt/pull/5452 got merged.

Thanks for quickly fixing this build issue! 👏

Of course... I broke it 😅


Upgrade glob to v7.1.1

Explain the motivation for making this change. What existing problem does the pull request solve?

Of the three dependencies I have that rely on glob, react-native is the only one not on 7.x. If react-native can upgrade, then npm can deduplicate the glob dependency.
$ npm ls glob
├─┬<EMAIL_ADDRESS>│ └──<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>│ └─┬<EMAIL_ADDRESS>│   └─┬<EMAIL_ADDRESS>│     ├─┬<EMAIL_ADDRESS>│     │ └──<EMAIL_ADDRESS>│     ├─┬<EMAIL_ADDRESS>│     │ └─┬<EMAIL_ADDRESS>│     │   └──<EMAIL_ADDRESS>│     └─┬<EMAIL_ADDRESS>│       └─┬<EMAIL_ADDRESS>│         └──<EMAIL_ADDRESS>└─┬<EMAIL_ADDRESS>  ├──<EMAIL_ADDRESS>  └─┬<EMAIL_ADDRESS>    └──<EMAIL_ADDRESS>
Test plan (required)

Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. Make sure tests pass on both Travis and Circle CI.

There are three breaking changes since v5.0.15, as taken from node-glob/changelod.md:

v6.0

Remove comment and negation pattern support
Ignore patterns are always in dot:true mode

v7.0

Raise error if options.cwd is specified, and not a directory

I ran npm run test, and all tests passed locally. I also quickly grepped the codebase, to see if it used any of those breaking changes.
There are three places that specify cwd:

local-cli/core/android/findPackageClassName.js:22

const files = glob.sync('**/*.java', { cwd: folder });

local-cli/core/windows/findNamespace.js:22

const files = glob.sync('**/*.cs', { cwd: folder });

local-cli/core/windows/findPackageClassName.js:22

const files = glob.sync('**/*.cs', { cwd: folder });

If folder doesn't exist on disk, I suppose that glob@7 will throw an error, and the react-native cli would need to catch it in order to gracefully exit?
Nothing appeared to use negation or comment patterns in a glob, from my limited explorations, and there did not seem to be anything that set the dot argument, so I believe that upgrading glob should be an easy change. Hopefully.
Let me know if I missed anything or if there's another reason that react-native is pinned to glob@5! I'm happy to do more work to let you all merge this, if you need me to.
Have a great week!

As far as I can tell, Circle failed because of an unrelated error. I can't restart the job to test that theory, however.


support auto go get 3rd party packages

for example, if i import github.com/stretchr/testify package in my .go file, wide will auto go get this package for me


Respect GOBIN in Makefiles and scripts

Main change:

Add two files, etc/govars.mk and etc/govars.sh that set default values for GOPATH=$HOME/go (if unset) and GOBIN=$GOPATH/bin (if unset)
Rewrite our other scripts and makefiles to source (scripts) or include (makefiles) one of the above two files, and then use the above vars by replacing all instances of $GOPATH/bin with $GOBIN
The result is that scripts' default behavior stays the same, but if $GOBIN is set, it overrides the default $GOPATH/bin, so that scripts/makefiles are using the same path that go build uses when building Go binaries (instead of assuming $GOPATH/bin).

Secondary change:

etc/govars.mk and etc/govars.sh also set the default value PACHCTL=$GOBIN/pachctl (if unset).
Rewrite other scripts and makefiles to replace $GOBIN/pachctl with $PACHCTL
This way, when using a custom pachctl, you can force scripts/makefiles to use it as well by setting that env var and overriding the default value

This was already done by examples/Makefile, examples/Makefile.testing and examples/deferred_processing/automated_deferred_processing/Makefile but the pattern is now universal to everything that includes govars.mk and govars.sh

Other miscellaneous changes:

remove etc/user-job (had a Dockerfile for a user-job container that AFAICT is no longer used)
remove etc/initdev (had a bunch of vagrant configs that AFAICT are unused and no longer work)
remove src/cmd from .gitignore (it no longer exists)
remove .goxc* files, and remove all such paths from .gitignore (we no longer use goxc)
Remove src/server/tmp_vendorize_client_go which AFAICT is no longer used
Add .envrc and _worktree_data to .gitignore, which can be used to store/set branch-specific data when using git worktrees.

This works well with the $GOBIN change: you can work on multiple pachyderm branches simultaneously using git worktrees, and each worktree can set its own value for $GOBIN in .envrc.
When you cd into that worktree, .envrc in that worktree can set $GOBIN to _worktree_data/bin and any binaries you build there will be private to the worktree. Because our scripts and makefiles now respect $GOBIN, all of our build/test workflows would continue to work, even while multiple branches are checked out and modified simultaneously.

Merging this PR because, despite the GitHub message that build-MISC failed, it actually passed in a subsequent run (that didn't update GitHub): https://app.circleci.com/pipelines/github/pachyderm/pachyderm/3870/workflows/b9b44dcd-10d7-46d7-9c26-32804056c877
I had to cancel the previous run because when CircleCI tried to provision a TestFaster VM, it got stuck in a state where TestFaster kept saying that the VM was assigned but not ready. I cancelled that run and re-ran the failed CircleCI job, and it passed. The link above shows the all-green CircleCI run for commit 9ac96a9


Error using better-sqlite3 in Termux

Hello, I installed better-sqlite3 using npm and the installation was successful, but when I decided to use it, I did not succeed.
I saw an error:
/storage/emulated/0/Bots/Test/node_modules/bindings/bindings.js:121
        throw e;
        ^

Error: dlopen failed: couldn't map "/storage/emulated/0/Bots/Test/node_modules/better-sqlite3/build/Release/better_sqlite3.node" segment 1: Permission denied
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:1122:18)
    at Module.load (internal/modules/cjs/loader.js:928:32)
    at Function.Module._load (internal/modules/cjs/loader.js:769:14)
    at Module.require (internal/modules/cjs/loader.js:952:19)
    at require (internal/modules/cjs/helpers.js:88:18)
    at bindings (/storage/emulated/0/Bots/Test/node_modules/bindings/bindings.js:112:48)
    at Object.<anonymous> (/storage/emulated/0/Bots/Test/node_modules/better-sqlite3/lib/database.js:9:24)
    at Module._compile (internal/modules/cjs/loader.js:1063:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
    at Module.load (internal/modules/cjs/loader.js:928:32)

Thanks for the help!

This is not an issue with better-sqlite3, but an issue with the configuration of the filesystem you're using: https://www.tutorialspoint.com/unix/unix-file-permission.htm


Update web-service for API version 3.0

Thanks @maxlmo, sorry for the delay, this change has already been made on master so I'm going to close this PR.


Remove Task.Delay from delete tag test

The service team has shared that delete tag should return a result only after a tag is deleted, so any subsequent GET operations should succeed.  Look into why there appears to be a race condition here with the GET arriving while the DELETE request is still in progress.
The goal of this issue is to remove the Task.Delay() from this test entirely.  See suggestions in this PR.

Duplicate of https://github.com/Azure/azure-sdk-for-net/issues/19699


Why latency of quantized model is even more than unquantized model?

Based on my understanding, a quantized model (e.g., INT8 version) should run faster than an FP32 model, since the hardware has a specific acceleration unit for INT8 data computation. But the experimental results show that INT8 model suffers twice latency than FP16 model.
Why this happens?

@ZhangYuef quantization has a cost, and even if it unlocks some operations optimized for lower data types, the overall resulting graph might be slower.
Regarding int8 quantization, it can only shine when both activations and weights are int8, because we can use an accelerated integer matmul kernel: torch._int_mm.
However, as you can see in the middle graph, it actually doesn't, because there is a restriction on the input dimensions to be able to use that kernel: the first dimension of the input must be higher than 16.
Llama-3 is a generative model, whose inference comprises two phases:

the encoding of the context,
the iterative decoding of new tokens.
When encoding the context, the optimized kernel is called even if there is only one sequence to encode as long as the prompt contains more than 16 tokens.
When decoding, there is only one input token for each input sequence, which prevents us from using torch._int_mm if the batch_size is not > 16.
In the graph you selected, we are processing a single sequence, so the inference time is dominated by the sub-optimal decoding.

Here is the code that decides if we can use torch._int_mm or not:
https://github.com/huggingface/optimum-quanto/blob/fb505553be71175d013dc7eb0db104a151517b51/optimum/quanto/library/qbytes_mm.py#L79

Thanks for your detailed explaination. It seems that model compression does not necessarily lead to inference acceleration unless specialized matrix multiplication kernels (e.g., int8xFP16, int4xFP16) are implemented on specific hardware.


OESA Foundation - Create Application Context

This PR adds the Application Context class that behaves like a factory and it will be used for injecting implementations via annotations.
Changes

Added ApplicationContext.java class
Added ApplicationContext unit test (ApplicationContextTest)

Resolves ticket
#13

I can tell while looking at this PR's description on my mobile phone whether #13 will be closed upon merge, but this PR will not fulfill all the acceptance criteria of #13. So, I'd say remove the "resolves" thing.


remember subs settings on all devices

Hello.
Is there a way to retain subtitle settings for the account regardless of where I'm watching (browser, phone, TV, etc.)? YouTube keeps defaulting to English for subtitles, and I have to change it manually every time, which is inconvenient, especially on TV.

Sadly, there is no way to install extensions in the default browser of Android phones and TVs (Chrome).
But there is a browser in the Google Play Store with support for extensions: Kiwi browser. You can install that browser on your Android phone and Android TV (or Chromecast). Enable the desktop mode on the YouTube site, add the extension and it should work.


feat: added hover effect to social SVG icons

Fixes Issue #278
Changes proposed
Added hover effect to the social icons on the navbar, The site currently uses svg for the social icons so had to add the colour as bg, still works perfectly fine.

Screenshots

Note to reviewers

@Susmita-Dey I am unable to install react icons, i tried using npm i react-icons but it is showing error message because it is a nextjs based project, any other way to install it?

@Susmita-Dey I am unable to install react icons, i tried using npm i react-icons but it is showing error message because it is a nextjs based project, any other way to install it?

There should be any issue. Do npm i once and check if it's already there or not in the package.json file. Follow this guide

on it, thank you

@Susmita-Dey

This is the error that occurs on running the command

pnpm add react-icons -w
I am trying out this command for once, will see

@Susmita-Dey Done

pushing the changes in a bit

@Susmita-Dey Done, please check now

ah, in a min

So hat should i do for hover on the github icon, like any other colour code you have in mind?

@Susmita-Dey How does this look for github hover

Will push the changes right away, I think that should be it, five me like 5 mins

@Susmita-Dey Surely done , I was experimenting with the Links, just amidst all that, I forgot to add back the scale effect


[WFRP4e System] Night Vision Trait at character creation

When creating a new character with the Night Vision talent (a dwarf, for example), the trait is added instead of the talent.From: Txus5012foundry: 11.308wfrp4e: 7.0.2wfrp4e-core: 4.0.1Active Modules:

Closed in fe536ea0fc1ec019f8b8e19129dff8ba3fda7f8c


Support socket.io 1.x

Hello,
When you think in support socket.io 1.x?
Regards

I will be getting back to work on the repo this week, sorry for the delay, I know 1.x has been out for quite sometime

Socket.io 1.x support and Express 4.x support added


data and metadata tables advice

Thank you Josh for your work with pydbantic,
I want to store both data and metadata for my data
How do you recommend creating tables that can store pandas dataframes with arbitrary columns?
How about metadata where the metadata has some JSON fields?

@joamatab thanks for opening an issue here for these questions.

Q -  How do you recommend creating tables that can store pandas dataframes with arbitrary columns?
A - DataBaseModel s are a sub class of pydantic BaseModel and thus share the same constraints that you might face when creating a model. Fortunately custom classes and subsequently pandas DataFrame type objects can be used combined with the Config class attribute and arbitrary_types_allowed = True as documented here

from pandas import DataFrame
from pydbantic import DataBaseModel, PrimaryKey

class MyModel(DataBaseModel):
    id: str = PrimaryKey()
    frame: DataFrame

    class Config:
        arbitrary_types_allowed = True

In future releases I am considering applying a default  arbitrary_types_allowed to True, to avoid the need to set this yourself. Since DataFrame type objects are serializable via pickle, they will be stored as bytes in the database within a Binary Field in the database.

Q: How about metadata where the metadata has some JSON fields?
A : If you expect the metadata fields to change or vary, then set the field type to dict, if it will always follow a set schema, consider creating a BaseModel for the metadata, both will be stored on Binary database fields ( of course de-serialized / serialized for you).


application state is accepted after scheduler recovery

During the recovery test, @sunilgovind found when scheduler gets recovered on a restart, the application state is Accepted instead of Running.

this is fixed via #28


License missing in gemspec

https://github.com/mikik0/omochi/blob/master/omochi.gemspec doesn't include license attribute. If it's going to be released in rubygems.org (which is a different issue), we need it in gemspec.

Thank you!
https://github.com/mikik0/omochi/pull/13


Write documentation

Write a reworked, updated documentation for MelonRuntime

https://zippy-sunflower-e51862.netlify.app/
https://github.com/MelonRuntime/MelonRuntime-Docs/
In development


team member effort added to tooltip

#1688
Description
I have made the requested changes to show the team member effort in tooltip
I removed the  the bootstrap JS that is being loaded via CDN
but the other HR module were also affecting so i removed data-bs to data and the module started working completely fine at my end.

[x] I have performed a self-review of my own code.

@ASHISH-KOHLI Please fix the merge conflicts in your PR first, then assign for review.


WIP: log duplicate stories

Proposed changes:

log duplicate stories

Things to do:

[ ] check with checkpointed stories
[ ] check if check for phase is required and potentially remove it

Status (please check what you already did):

[ ] made PR ready for code review
[ ] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog

@wochinge didn't we try it together, and there were no double logging?

@Ghostvv Yes, there was no double logging with you. But still have to test this out with checkpointed stories and other stuff is currently more important. Should also be easy to be ported.


escape function crashes when escaping long Chinese strings

This problem would be easier to reproduce on iOS devices with smaller RAM, I first found it on an iPod Touch 5 with 512MB RAM. It crashes everytime when I try to encode a POST parameter with more than 500 Chinese characters, and it only gives me an EXC_BAD_ACCESS with no further information. On iPhone 5 with 1GB RAM it can handle about 1300 Chinese characters but still crash if the limitation is exceeded.
For quick reference, this is the escape function I copied from Alamofire.swift line 154
func escape(string: String) -> String {
    let allowedCharacters =  NSCharacterSet(charactersInString:" =\"#%/<>?@\\^`{}[]|&+").invertedSet
    return string.stringByAddingPercentEncodingWithAllowedCharacters(allowedCharacters) ?? string
}

I can almost sure the reason of the crash is stringByAddingPercentEncodingWithAllowedCharacters takes too much memory, this is particularly obvious when it's encoding Chinese or Japanese strings, maybe because the encoding process is more complex for these languages.
I discovered that if I slice the long string into small pieces and call stringByAddingPercentEncodingWithAllowedCharacters in batches like below will fix the memory peak problem,
func escape(string: String) -> String {
    let allowedCharacters =  NSCharacterSet(charactersInString:" =\"#%/<>?@\\^`{}[]|&+").invertedSet
    let batchSize = 100
    var escapedString = ""
    let stringLength = countElements(string)
    for var i = 0; i < stringLength; i += batchSize {
        let rangeLength = i + batchSize > stringLength ? stringLength - i : batchSize;
        let slicedString = (string as NSString).substringWithRange(NSMakeRange(i, rangeLength))
        escapedString += slicedString.stringByAddingPercentEncodingWithAllowedCharacters(allowedCharacters) ?? slicedString
    }
    return escapedString
}

I don't even need to place autoreleasepool between each for loops, I suspect there is already a autoreleasepool inside the implementation of stringByAddingPercentEncodingWithAllowedCharacters
Then I was wondering why I've never encountered this issue in AFNetworking, so I read the source code of AFURLRequestSerialization. Turns out stringByAddingPercentEncodingWithAllowedCharacters is only available after iOS 7 and AFNetworking supports iOS 6 so it use the lower level API CFURLCreateStringByAddingPercentEscapes which does not suffering from this memory peak issue, or at least not so obvious.
So here're two possible solutions we have for now:

Do it in batches
Use the lower level API like AFNetworking does.

An  example project is provided to reproduce this problem: https://github.com/PrideChung/AlamofireEscapeCrashExample

what about Afnetworking 2.0? It could also crash when escaping long Chinese strings. It crash at stringByAddingPercentEncodingWithAllowedCharacters in this function "static NSString * AFPercentEscapedStringFromString(NSString *string) ". Those are my Chinese strings "一二三四五六七八九十一二三四五六七八九十一二三四五六七八九十一二三四五六七八九十一二三四五六七八九十一二三四五六七八九十一二三四五六七八九十一二三四五六七八九十一二三四五六七八九十一二三四五六七八九十一二三四五六七八九十一二三四五六七八九十一二三四五六七八九十一二三四五六七八九十一二三四五六七八九十一二三四五六七八九十一二三四五六七八九十一二三四五六七八九十一二三四五六七八九十一二三四五六七八九十一二三四五六七八九十一二三四五六七八九十一二三四五六七八九十一二三四五六七八九十一二三四五六七八九十一二三四五六七八九十一二三四五六七八九十一二三四五六七八九十".

@TheWalkingDead1024, if you are having an issue in AFNetworking, then please open a new issue in that project.

OK.Thank you.

cc @kcharwood
Thank you for reporting this issue @TheWalkingDead1024. My apologies for first pointing you towards the AFNetworking project. This issue actually spans both projects.
The approach previously taken to use the CFURLCreateStringByAddingPercentEscapes Core Foundation call was perfectly fine until the call was deprecated in the iOS 9 SDK. Therefore, we needed to move off that call back to stringByAddingPercentEncodingWithAllowedCharacters to get away from the deprecation. Unfortunately, when that change was made, we forgot about this previously closed issue.
After much debugging, I was able to track this issue down to only occurring in Alamofire on iOS 8.1 and 8.2 using the iPhone 4S and iPhone 5 simulators. It is 100% reproducible, but is crashing in different ways depending on the size of the Chinese string that is passed in. It's always some form of a malloc error. The following sample code will reproduce the issue in the iOS Example app.
AppDelegate.swift
import Alamofire
import UIKit

@UIApplicationMain
class AppDelegate: UIResponder, UIApplicationDelegate, UISplitViewControllerDelegate {

    var window: UIWindow?

    // MARK: - UIApplicationDelegate

    func application(
        application: UIApplication,
        didFinishLaunchingWithOptions launchOptions: [NSObject : AnyObject]?)
        -> Bool
    {
        dispatch_after(
            dispatch_time(DISPATCH_TIME_NOW, Int64(2.0 * Float(NSEC_PER_SEC))),
            dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_HIGH, 0))
        {
            self.runLargeChineseCharacterEncodingTest()
        }

        return true
    }

    func runLargeChineseCharacterEncodingTest() {
        let repeatedCount = 20_000
        let URL = NSURL(string: "https://example.com/movies")!
        let parameters = ["chinese": String(count: repeatedCount, repeatedString: "一二三四五六七八九十")]

        let start = NSDate()
        print("starting parameter encoding")
        ParameterEncoding.URL.encode(NSURLRequest(URL: URL), parameters: parameters)
        print("finished parameter encoding: \(NSDate().timeIntervalSinceDate(start)) seconds")
    }
}

extension String {
    private init(count: Int, repeatedString: String) {
        var value = ""
        for _ in 0..<count { value += repeatedString }
        self = value
    }
}

I've also added a unit test in 4f6b2956 to verify that the encoding works as expected. The test will fail 100% of the time without the solution in place. Unfortunately it causes the test suite to crash rather than fail without the solution implemented, but that's the way it is due to the nature of the issue.
Unit Test
func testURLParameterEncodeStringWithThousandsOfChineseCharacters() {
    // Given
    let repeatedCount = 2_000
    let URL = NSURL(string: "https://example.com/movies")!
    let parameters = ["chinese": String(count: repeatedCount, repeatedString: "一二三四五六七八九十")]

    // When
    let (URLRequest, _) = encoding.encode(NSURLRequest(URL: URL), parameters: parameters)

    // Then
    var expected = "chinese="
    for _ in 0..<repeatedCount {
        expected += "%E4%B8%80%E4%BA%8C%E4%B8%89%E5%9B%9B%E4%BA%94%E5%85%AD%E4%B8%83%E5%85%AB%E4%B9%9D%E5%8D%81"
    }
    XCTAssertEqual(URLRequest.URL?.query ?? "", expected, "query is incorrect")
}

Solution
As reported originally by @PrideChung, the only workaround is to limit the encoding calls to a character limit by splitting the operation into a batch call. This is the approach I used in 4f6b2956 which does in fact fix the problem. I've also added documentation to the escape implementation to remove the batching once iOS 8 is no longer supported by Alamofire.
For now, I've set the batchLimit to 50 which tends to add about a 20% overhead. This overhead is negligible in most cases until the parameter to encode gets extremely large. In the event of extremely large parameter data, the encoding should be done asynchronously.

Does stringByAddingPercentEncodingWithAllowedCharacters still crash?

It was only found to crash for iOS 8.1 and 8.2, hence our workaround only affects those OSes. There shouldn't be any further issue here. If you are seeing a new crash, please open a new issue.


Archlinux ARM Build error

Linux i4p 3.14.51-1-ARCH #1 SMP Mon Aug 17 02:21:26 MDT 2015 armv7l GNU/Linux

checkout test1 builds without issues but I have the following error on the latest master
/usr/include/c++/5.2.0/bits/shared_ptr.h:629:39:   required from ‘std::shared_ptr<_Tp1> std::make_shared(_Args&& ...) [with _Tp = graphene::p2p::peer_connection; _Args = {std::shared_ptr<graphene::p2p::node>&}]’
/home/jason/tmp/graphene/libraries/p2p/node.cpp:36:67:   required from here
/usr/include/c++/5.2.0/ext/new_allocator.h:120:4: error: no matching function for call to ‘graphene::p2p::peer_connection::peer_connection(std::shared_ptr<graphene::p2p::node>&)’
  { ::new((void *)__p) _Up(std::forward<_Args>(__args)...); }
    ^
In file included from /home/jason/tmp/graphene/libraries/p2p/include/graphene/p2p/node.hpp:5:0,
                 from /home/jason/tmp/graphene/libraries/p2p/node.cpp:1:
/home/jason/tmp/graphene/libraries/p2p/include/graphene/p2p/peer_connection.hpp:55:9: note: candidate: graphene::p2p::peer_connection::peer_connection()
   class peer_connection : public message_oriented_connection_delegate,
         ^
/home/jason/tmp/graphene/libraries/p2p/include/graphene/p2p/peer_connection.hpp:55:9: note:   candidate expects 0 arguments, 1 provided
libraries/p2p/CMakeFiles/graphene_p2p.dir/build.make:62: recipe for target 'libraries/p2p/CMakeFiles/graphene_p2p.dir/node.cpp.o' failed
make[2]: *** [libraries/p2p/CMakeFiles/graphene_p2p.dir/node.cpp.o] Error 1
CMakeFiles/Makefile2:1165: recipe for target 'libraries/p2p/CMakeFiles/graphene_p2p.dir/all' failed
make[1]: *** [libraries/p2p/CMakeFiles/graphene_p2p.dir/all] Error 2
Makefile:127: recipe for target 'all' failed
make: *** [all] Error 2

Can you post the exact commit hash you are building?
The issue seems to be your compiler is getting confused because there is a function with this prototype in peer_connection.hpp:
static peer_connection_ptr make_shared(peer_connection_delegate* delegate);

but there is also a make_shared in namespace std and your compiler is getting the two confused.

Commit hash: d1484fb41e35a367a9784da0f80e0153ae2dcaec
I will try clang

Actually I found out p2p is some experimental code that got into our master branch by accident.  Feel free to comment out add_subdirectory(p2p)

Related: #273


MM-42490_Revamp: Account creation webapp

Summary
Apply new designs for the Login screen which should consider also cases when:

Default signup
OAuth options are available
Custom branding is configured
Email verification is enabled
Currently working on unit and e2e testing updates.

Ticket Link
https://mattermost.atlassian.net/browse/MM-42490
Design
https://www.figma.com/file/7BM8S6BL597zBE83U6H8CK/MM-29159-Desktop-%26-Webapp-Login-Update?node-id=926%3A35222
Screenshots
Signup with username/email

Signup with username/email and external options

Signup with external options

Email verification enabled

Messages
Email already exist

Username already exist

Password requirements

Invalid link

Resend email

Release Note
Apply new designs for the Login screen which should consider also cases when:

- Default signup
- OAuth options are available
- Custom branding is configured
- Email verification is enabled

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/195529

Currently working on unit and e2e testing updates.

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/195550

@julmondragon and @matthewbirtch - Good callout regarding simplifying the password hint text. Building on Matt's proposal, how about: "Must be 10-64 characters long and include both lowercase and uppercase letters, numbers, and special characters."

@julmondragon Haven't done a code review yet, but doing an initial pass on the test server - I was able to create my account and then copied the invitation link (https://mattermost-webapp-pr-10324.test.mattermost.cloud/signup_user_complete/?id=cswo41yy8prwfbraqfiop9xmtr)
Going to that link seems to be getting a blank screen - there are some errors in the console

@marianunez Thanks for reporting, this is solved now.

Awesome job @julmondragon. A few things from me:
...

@matthewbirtch Thanks for the feedback, I think all the styling issues were covered in latest push.

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/196438

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/196499

/e2e-test

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/197323

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/197339

@marianunez Is this for Cloud May 25th release?

No need for May 25th release, would prefer to merge directly to 7.0 branch and let it soak a bit in community.

/cherry-pick release-7.0

Cherry pick is scheduled.


Add socket size bpftrace tool

For distributed workloads that don't use http (e.g. ML model training) it's desired to be able to do network workload characterization at socket level. This tool (adapted from "BPF Performance Tools" book by Brendan Gregg) enables socket-level profiling which provides socket requests sizes, counts, and throughput.

@pixie-io-buildbot test this please

@pixie-io-buildbot test this please

@pixie-io-buildbot test this please

@pixie-io-buildbot test this please

The change looks good to me once the existing comments are addressed.

Hi @oazizi000 ,
Thanks for your thoughts;
Yes, you are totally right that it can generate a high volume of profiling data (mainly because that's how Pixie recommends). For now, I reduced the duration further to 1m and added a warning on running the tool.
As for aggregation idea, to get the same results (e.g. counts and average size), internally we use the bpftrace's stats to aggregate them:
@rstats[comm, pid, tid, @rsocket[tid], @rsock[tid], @rdad[tid], @rdp[tid], @rsad[tid], @rlp[tid]] = stats(retval);

I'll do some experimentation and will see if I can make it work with Pixie to collect those aggregated stats in intervals.
Note that, at least for us, the most valuable info out of this tool is actually the count and average size for some workload characterization at process level which are used for deterministic workloads like distributed model training; otherwise, the rx/tx total size can be collected from other tables/tools. Therefore, even if the aggregation idea doesn't work with Pixie, the current form of this tool is extremely useful (at least for us).

@pixie-io-buildbot test this please


feat(AccessKeyed): fully observe access-keyed expressions

Fixes #75, Fixes #64, Fixes aurelia/templating-binding#26

Lots of tests to add...  AccessKeyedObserver is a specialized version of CompositeObserver that knows how to manage changes to the object value or the key value.

Added tests, tested in karma chrome runner and IE runner.  This is ready.


Add HelloWorld sample of LLVM14

HelloWorld sample of LLVM14
I'm not sure if the running JIT compiler part is correct.
This sample will output:
[Output of LLVM IR]:

; ModuleID = 'Hello World'
source_filename = "Hello World"

@0 = private unnamed_addr constant [13 x i8] c"Hello World!\00", align 1

declare i32 @puts(i8* %0)

define i32 @main() {
entry:
  %0 = call i32 @puts(i8* getelementptr inbounds ([13 x i8], [13 x i8]* @0, i32 0, i32 0))
  ret i32 0
}

[Output of JIT Compiler]:

Hello World!

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: CWKSC sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


\cfrac is not implemented

It's mostly just nested <mfrac> but temml does something with scriptlevel too.

Oh, it's literally just setting scriptlevel="0" (and displaystyle="true") so that the fractions don't get smaller.

Actually, comparing \dfrac and \cfrac in LaTeX, it seems to me \cfrac also has additional padding.


Cache component

More information on the cache component can be found here: https://github.com/SlaxWeb/Framework/wiki/Documentation#16-cache
Master ticket for the cache component, the components ticket will reference it, may be closed once all tickets referencing it are resolved.

Cache component is finished, as a first version. Requires documentation.

Resolved.


TF 2.3.1. Custom Metrics are not shown

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: no
TensorFlow installed from (source or binary):Docker tag 2.3.1
TensorFlow version (use command below): 2.3.1
Python version: 3.7
Bazel version (if compiling from source):x
GCC/Compiler version (if compiling from source):x
CUDA/cuDNN version:
GPU model and memory: K80

Describe the current behavior
I used to be able (TF 2.0.0) to log custom metrics using a Callback, putting the calculated logs into the logs variable. Now (using TF 2.3.1) it seems these are not displayed anymore. Is this adjusted? It seems all that is visualized now is:
I 2020-11-17T12:47:08.315319004Z master-replica-0 Epoch 1/150
 master-replica-0
I 2020-11-17T12:47:08.315363796Z master-replica-0 160/160 - 532s - loss: 29.2287 - val_loss: 15.1582
 master-replica-0
I 2020-11-17T12:55:48.016732616Z master-replica-0 Epoch 2/150
 master-replica-0
I 2020-11-17T12:55:48.016795954Z master-replica-0 160/160 - 519s - loss: 10.9081 - val_loss: 18.8457
 master-replica-0
I 2020-11-17T13:04:21.477356137Z master-replica-0 Epoch 3/150
 master-replica-0
I 2020-11-17T13:04:21.477408088Z master-replica-0 160/160 - 513s - loss: 9.3685 - val_loss: 8.4681
 master-replica-0
I 2020-11-17T13:12:53.997353683Z master-replica-0 Epoch 4/150
 master-replica-0
I 2020-11-17T13:12:53.997419829Z master-replica-0 160/160 - 512s - loss: 10.4035 - val_loss: 8.9458
 master-replica-0
I 2020-11-17T13:21:18.459229170Z master-replica-0 Epoch 5/150
 master-replica-0
I 2020-11-17T13:21:18.459279180Z master-replica-0 160/160 - 504s - loss: 9.8809 - val_loss: 9.3682
 master-replica-0
I 2020-11-17T13:29:43.330040354Z master-replica-0 Epoch 6/150
 master-replica-0
I 2020-11-17T13:29:43.330108120Z master-replica-0 160/160 - 504s - loss: 9.5458 - val_loss: 8.8212
 master-replica-0

Can you share a very minimal code example to reproduce this?

https://colab.research.google.com/drive/1lUCnZrgUzH77okiyDNdNkHRMU1pYkMNf?usp=sharing
iirc, this should yield the result:
4/4 [==============================] - 0s 22ms/step - loss: 232.9125 - val_loss: 7.3053 - test_val: 0.8

In your colab  'metric' is not defined

Adjusted

Is this like https://github.com/tensorflow/tensorflow/issues/37187?

It seems so. I know that it has worked for me in the past.

I think you can close this, upvote and subscribe to that one

Duplicate of #37187


fixed typos

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Congrats @kcoding24 on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝


Task/638 clickable cards for detail view

Description
the home page catalog card needs to be clickable for redirecting into a detailed view of the metadata.
currently, we are still in the discussion if we should display a contribution (with talent/capability) or just a single capability/talent info page, so just have a basic structure of the flow.
I will update as soon as we have more detailed specifications.
Fixes #(add issue number here and remove parentheses)
Review Time Estimate
Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

[ ] Immediately
[ ] Within a week
[x] When possible

Type of changes
Please select a relevant option:

[ ] Bug fix (non-breaking change which fixes an issue).
[x] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[ ] Other (any another change that does not fall in one of the above categories.)

Checklist:
Please select all applicable options:

[ ] I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
[ ] I have updated the CHANGELOG.
[ ] I have read the Contributor Guidelines.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] My change requires updating the documentation.
[ ] I have made necessary changes to the documentation.
[ ] I have added tests related to my changes.
[ ] My changes generate no new warnings.
[ ] New and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.

In talent detail, it shows the raw json list. This should be decoded json info?

In talent detail, it shows the raw json list. This should be decoded json info?

In this entry, the talent is actually empty and there is one capability entry and when I clicked show talent, it showed the capability info under talent as required capabilities and I don't think this is correct.

In above entry, the talent is actually empty and there is one capability entry and when I clicked show talent, it showed the capability info under talent as required capabilities and I don't think this is correct.

To fix you can edit talent_details.html template's requiredBuildingBlocks section. (if still based on current code then i assume you can will either display entire capability by using capability's template code, or display the capability name and link to corresponding capability page)

In above entry, the talent is actually empty and there is one capability entry and when I clicked show talent, it showed the capability info under talent as required capabilities and I don't think this is correct.

To fix you can edit talent_details.html template's requiredBuildingBlocks section. (if still based on current code then i assume you can will either display entire capability by using capability's template code, or display the capability name and link to corresponding capability page)

Thank you Wenjie!

I have linked #670 and #669 to this PR for future reference. The detailed views still need to be improved. Approving and merging to continue development on follow-up tasks.


Fix a typo in example

The description in the example for player 2 should be
<App playerID="2"/>

Instead of
<App playerID="1"/>

Coverage remained the same at 100.0% when pulling cab27e62cc7ff9fdb391ac943089b73c0409cefe on SBeator:master into 4b90e84c5bbb63bb3305773cc018c9f33fffe177 on google:master.

Thanks!


Unused targets logged due when inside BufferingWrapper

Bug

NLog version: 4.4.12
Platform:  .NET Core
Current NLog config (xml or C#, if relevant)
<nlog xmlns="http://www.nlog-project.org/schemas/NLog.xsd"
      xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
      autoReload="true"
      internalLogLevel="Warn"
      internalLogFile="logs\internal\internal-nlog.txt">

  <extensions>
    <add assembly="NLog.Web.AspNetCore" />
    <add assembly="NLog.MailKit"/>
  </extensions>
    <targets>
      <target xsi:type="BufferingWrapper"
              name="MailBuffer"
              slidingTimeout="false"
              bufferSize="100"
              flushTimeout="10000">
        <target xsi:type="Mail" name="email"
              COMMENTS ="I removed my settings"
       />
      </target>
    </targets>
 <rules>
    <logger name="*" minlevel="Warn" writeTo="MailBuffer" />
  </rules>
</nlog>

**I do have other rules and targets in my actual config
In case of a BUG:

What is the current result?  The internal logger is writing Warn Unused target detected. Add a rule for this target to the configuration. TargetName: email

What is the expected result? The email target is being used by the MailBuffer target and is not unused so nothing should be detected

Is there a version in which it did worked? I was not previously using the BufferingWrapper as I did not have a need before the mailkit support was added.

Thanks for the report! This is indeed wrong!
Could you help us in fixing this? (unit test, PR)

I'd love to help but being fully unfamiliar with this project's code and style..
How would you approach this issue?
Here is what I was thinking just at a glance:

Iterate targets and store a list of the WrappedTargets if the type is WrapperTargetBase
If the normal unused check fails ignore the warning if found in the list from step 1

any thoughts or better direction from people familiar with the code would be appreciated.

We prefer adding an unit test first (TDD)

you could add this to  https://github.com/NLog/NLog/blob/master/tests/NLog.UnitTests/Config/RuleConfigurationTests.cs

the bug is in https://github.com/NLog/NLog/blob/master/src/NLog/Config/XmlLoggingConfiguration.cs,
(method CheckUnusedTargets)

I think we should check/filter the childs of the wrapper (e.g. check if configuredNamedTargets is of type WrapperTargetBase)

@304NotModified Resolved with  #2290

Thx!

@304NotModified I'm getting the same warn that happened in this release when using wrapper targets.
internal.txt
2019-11-18 13:56:10.6268 Warn Unused target detected. Add a rule for this target to the configuration. TargetName: key-error-instant-mail
2019-11-18 13:56:10.6316 Warn Unused target detected. Add a rule for this target to the configuration. TargetName: filter-mail
2019-11-18 13:56:10.6316 Warn Unused target detected. Add a rule for this target to the configuration. TargetName: key-error-bulk-mail
2019-11-18 13:56:10.6316 Warn Unused target detected. Add a rule for this target to the configuration. TargetName: buffer-key-error-mail
2019-11-18 13:56:10.6475 Warn Unused target detected. Add a rule for this target to the configuration. TargetName: bulk-mail-non-key-error
2019-11-18 13:56:10.6475 Warn Unused target detected. Add a rule for this target to the configuration. TargetName: buffer-mail-non-key-retry

nlog.config
<?xml version="1.0" encoding="utf-8" ?>
<nlog xmlns="http://www.nlog-project.org/schemas/NLog.xsd"
      xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
      autoReload="true"
      internalLogLevel="Warn"
      internalLogFile="c:\temp\internal.txt">

  <extensions>
    <add assembly="NLog.MailKit"/>
  </extensions>

  <!-- define various log targets -->
  <targets async="true">
    <!-- write logs to file -->
    <target xsi:type="File" name="error" fileName="D:\Dev\dotnet\Core\Logs\LoggingDemo\error-log-${shortdate}.log"
                 layout="${longdate}|${logger}|${uppercase:${level}}|${message} ${exception}" />
    <target xsi:type="File" name="info" fileName="D:\Dev\dotnet\Core\Logs\LoggingDemo\info-log-${shortdate}.log"
                 layout="${longdate}|${logger}|${uppercase:${level}}|${message}" />

    <target xsi:type="SplitGroup" name="key-error-mail">
      <target xsi:type="FilteringWrapper" name="filter-mail">
        <filter type="whenRepeated" layout="${aspnet-mvc-controller} ${aspnet-mvc-action} ${callsite-linenumber}" timeoutSeconds="10" action="Ignore" />
        <target xsi:type="Mail" name="key-error-instant-mail">
          <layout>
		  Stripped out other nodes to make cleaner
		  </layout>
        </target>
      </target>
      <target xsi:type="BufferingWrapper" name="buffer-key-error-mail" flushTimeout="10000">
        <target xsi:type="Mail" name="key-error-bulk-mail">
          <layout>
		  Stripped out other nodes to make cleaner
		  </layout>
        </target>
      </target>
    </target>

    <target xsi:type="BufferingWrapper" name="buffer-mail-non-key-error" flushTimeout="10000">
      <target xsi:type="RetryingWrapper" name="buffer-mail-non-key-retry" retryDelayMilliseconds="6000" retryCount="10">
        <target xsi:type="Mail" name="bulk-mail-non-key-error">
          <layout>
		  Stripped out other nodes to make cleaner
		  </layout>
        </target>
      </target>
    </target>

    <!-- set up a blackhole log catcher -->
    <target xsi:type="Null" name="blackhole" />

  </targets>

  <rules>
    <!-- Skip Microsoft logs and so log only own logs-->
    <logger name="Microsoft.*" level="Info" writeTo="blackhole" final="true" />
    <!-- Now we've sent Microsoft logs to the blackhole, we only log non Microsoft info to the info log file-->
    <logger name="*" level="Info" writeTo="info" final="true" />
    <!-- Log errors to the error email buffer and error file -->
    <logger name="*" minlevel="Error" writeTo="error" />
    <logger name="*" minlevel="Error" writeTo="key-error-mail">
      <filters defaultAction="Log">
        <when condition="starts-with('${aspnet-response-statuscode}','4')" action="Ignore" />
      </filters>
    </logger>
    <logger name="*" minlevel="Error" writeTo="buffer-mail-non-key-error">
      <filters defaultAction="Log">
        <when condition="not starts-with('${aspnet-response-statuscode}','4')" action="Ignore" />
      </filters>
    </logger>
  </rules>
</nlog>

Hi! Please open a new issue and use the template, thanks!

created -> https://github.com/NLog/NLog/issues/3690