feat: MulAction by product monoid

Commuting (Distrib)MulActions by two monoids on the same type give rise to a (Distrib)MulAction by the product monoid, and vice versa.

I originally thought of generalizing LinearMap to take DistribMulActions rather than Modules, so we can describe (R,S)-bimodule morphisms as LinearMaps w.r.t. the R × Sᵐᵒᵖ-action. However, making an R × S-action instance from the R- and S-actions would lead to diamonds, so it's not a practical approach; using IsLinearMap is probably a good compromise. Moreover, for the category of (R,S)-bimodules, the objects are Modules over the tensor product R ⊗ Sᵐᵒᵖ and can't be easily described using R × Sᵐᵒᵖ, even though the morphisms can.

Thanks for the review!

Thanks! :tada:
bors merge


[Question]Error with docker

After building docker using https://github.com/NVIDIA-Merlin/Merlin/blob/main/docker/training/dockerfile.ctr and cmake、make install HugeCTR, I cant import HugeCTR in this docker.

What i can do to solve this problem?

Hi @politefish
Could you please check $PYTHONPATH within the container and ensure that the install path is covered？

Hi，thank you for your reply, there is '/usr/local/hugectr/lib' in my PYTHONPATH, is that means make install is finished correctly?

No. Could you please show the log of "make install"?

makeinstall_log.txt
I make install again and this is the log

It looks good and could you please check hugectr.so exists in the path /usr/local/hugectr/lib?

Can import hugectr in the path /usr/local/hugectr/lib?

Yes！why？

hugectr.so is the library of the Python module. If you can import hugectr in the path /usr/local/hugectr/lib AND /usr/local/hugectr/lib is in the environment variable PYTHONPATH, then there should NOT be any problem of doing import hugectr anywhere within the container.

I pasted the wrong picture before, there are the files in /usr/local/hugectr/lib

 I pasted the wrong picture before, there are the files in /usr/local/hugectr/lib

@politefish I do not think you are building hugectr Python interface correctly based on this screenshot. It seems that you have mistakenly pass -DENABLE_INFERENCE=ON to cmake.
Could you please refer to our contributor guide https://nvidia-merlin.github.io/HugeCTR/master/hugectr_contributor_guide.html#build-hugectr-from-source to get informed of how to build HugeCTR from scratch correctly?

@politefish Please inform us if you solve the problem.

@KingsleyLiu-NV The problem is solved, thank you for your help~


how can I save the detected result of image

i have modified detect_img funciton yolo_video.py and added row after show():
r_image.save("detection.png","PNG")


fix: adjust release-please configs for cloudbuild yaml updates

Following the Update arbitrary yaml file strategy is resulting in release-please making unexpected changes to the cloudbuild yaml files. See #2350.
Modifying release-please configs to follow Update arbitrary file strategy combined with inline annotations as described in https://github.com/googleapis/release-please/blob/main/docs/customizing.md#updating-arbitrary-files:

Should there be associated x-release-please-version comments added to the cloudbuild files, as mentioned in the screenshot for this PR?

Should there be associated x-release-please-version comments added to the cloudbuild files, as mentioned in the screenshot for this PR?

Hmm yeah was thinking about this too. We have the x-version-update annotation which is slightly different from the ones listed in the readme but is the convention in most our repos including java-shared-config (which uses it to update the cloudbuild yaml files) so was curious to try this out as an initial attempt.


Switching between multiple databases using Jedis client

Hi,
We have multiple databases in our redis instance. I did not see support for SELECT index in dynomite. Can you please confirm if creating and using multiple redis databases are supported by dynomite?
Thanks,
Vasavi

Hello @vvapp you can extend Dynomite to connect to multiple Redis databases. However, the way were are using it is with a single Dynomite/Redis per instance, so this is what is implemented by default. Other than contributing to the software itself, there are several other alternative designs you can have like running separate pairs of Dynomite/Redis per database.

Thanks! We will evaluate the options. Appreciate your response.


Roadmap Project Not Showing up

Hello,
I have a project in a relatively new repository that doesn't show up, even after refreshes and clearing the data of the extension.
https://github.com/JustinGrote/Press/projects/1
Others show up fine, not sure what is different about this repository.

Any update on this? Having the exact same issue.

@Happy-Ferret hasn't been a commit since April, pretty sure this is a dead project. Hopefully Github does something first-party with their issues revamp.

@JustinGrote @Happy-Ferret unfortunately, that is true. Maintainers moved on to their own things, and a newer version cannot be published without the marketplace credentials.. Hopefully GitHub provides something in-house, apologies!  It's probably an easy fix. I just don't have time to dig into the code and I can't find anything on initial debugging. No exception or warning.
If I had the time or if somebody else was willing to contribute code, I'd gladly take over maintainership and republish the extension under a different name.

@JustinGrote @Happy-Ferret unfortunately, that is true. Maintainers moved on to their own things, and a newer version cannot be published without the marketplace credentials.. Hopefully GitHub provides something in-house, apologies! :'(

Is it possible to mark this repo as archived then?


[WTD] Azure Machine Learning Inclusion Articles

In support of #31413, here is a list of articles with line numbers of where non gender neutral language is present.

[ ]   data-science-for-beginners-ask-a-question-you-can-answer-with-data.md Line   #46
[ ]   tutorial-part1-credit-risk.md Line   #75
[ ]   group-manager-tasks.md Line   #18
[ ]   project-lead-tasks.md Line   #17

rachrobins working on this, write the docs writing day

All updates done


Minor edits

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
98
5
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit b643aa7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
98
5
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 4f3f4f5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
98
5
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 1e4bdce:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
98
5
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit b1976cd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


electronic-io: 1.0.1-1 in 'noetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository electronic-io to 1.0.1-1:

upstream repository: https://github.com/ctu-vras/electronic-io.git
release repository: https://gitlab.fel.cvut.cz/cras/ros-release/electronic-io.git
distro file: noetic/distribution.yaml
bloom version: 0.11.2
previous version for package: null

electronic_io
* Added support for simplified specification of pins in config.
* Added BinaryPWM virtual pin.
* Added virtual pins.
* It topic is set to empty, the topics and services will not be created.
* Added Battery device.
* Export the provided devices.
* Allow setting queue_size and latching for output devices.
* Added support for output groups.
* Robustified IO board client.
* Initial commit
* Contributors: Martin Pecka

electronic_io_msgs
* Initial commit
* Contributors: Martin Pecka

See my comments in https://github.com/ros/rosdistro/pull/37708#pullrequestreview-1488672975 about this package.

Reproducing the conversation from #37708
clalancette:
This name seems pretty generic to me, and thus I think it probably violates
https://www.ros.org/reps/rep-0144.html#global-guidelines point 1 or 4. It's kind of subjective,
as this is a generic package, but it isn't clearly used by large parts of the community. Thus I think
this package would be a candidate for prefixing the name of the entity.

peci1:
The goal was indeed to create a generically usable package.
I wanted to promote it a bit in the coming weeks so the community would get to know it.

I understand why you suggest prepending organization. I have two points which led me to not do so:

1.    There are (imo) really no competing packages trying to achieve this in a generic way. Yet I think some standardization would be beneficial.
2.    Was there actually some package that started with organzation prefix and then dropped it over time? I get that this is a REP recommendation, yet I think it is actually very impractical to force users of an established package to use a different name.

One point for prefixing is the dependency on cras_msgs. However, this package just adds what's missing in sensor_msgs (Voltage, ElectricCurrent...).

If you still think this package should be prefixed, I'll do it.

mjcarroll:
I think that if it's intended to be generic, then the package name is fine.

Was there actually some package that started with organzation prefix and then dropped it over time? I get that this is a REP recommendation, yet I think it is actually very impractical to force users of an established package to use a different name.

Yes, that is a big problem with that recommendation.  On the other hand, we really have no other way to do things since we need to have package names be globally unique.  I think the most likely scenario is that prefixed packages will remain prefixed forever, which isn't great but also isn't a huge deal (in my opinion).
As for this particular package, I'm OK with adding it under the current name.  So I'll go ahead and do the rest of the review on it.


Specify resource limits in nodelocaldns.yaml in the context of page "Using NodeLocal DNSCache in Kubernetes Clusters"

Please set a resource limit in nodelocaldns.yaml. I deployed this to test in my cluster and ran out of CPU and affected other services

/retitle Specify resource limits in nodelocaldns.yaml in the context of page "Using NodeLocal DNSCache in Kubernetes Clusters"

/kind feature
See https://github.com/kubernetes/website/issues/41101

Hm.. as per the given reference nodelocaldns.yaml
We can add a resource limit to it and as per #41101, this example manifest can be added as code new shortcode.
Do we need to have a whole new example manifest or we can use the same but without making reference to an internal document?

Any update on this? I think we can make a change in this sample with comments indicating the limit as well.
would like to know the opinions of matter experts and file owners regarding this.
/sig cloud-provider

/remove-lifecycle stale


Error messages rather than golang panics

I tried again today to deploy a simple redis/redis micro deployment and when I first try I get golang panics unmarshalling the manifest:
$ bosh-micro deploy assets/light-bosh-stemcell-2905-aws-xen-ubuntu-trusty-go_agent.tgz assets/bosh-aws-cpi-release-5.tgz assets/redis-9.tgz
Deployment manifest: '/Users/drnic/Projects/bosh-deployments/experiments/redis-micro/redis-micro.yml'
Deployment state: '/Users/drnic/Projects/bosh-deployments/experiments/redis-micro/deployment.json'

Started validating
  Validating stemcell... Finished (00:00:00)
  Validating releases... Finished (00:00:00)
  Validating deployment manifest...  I don't think panicing is a good UX :)
Any ideas/plans on how we will solve this?

The manifest I used was https://gist.github.com/drnic/f953407db9fcbb24a050
I'm investigating.

BTW, doing nothing but making bosh-micro deploy errors go away, the following is the minimum manifest I got away with:
---
name: redis-from-scratch

resource_pools:
- name: default
  network: default
  cloud_properties:
    instance_type: m3.medium

networks:
- name: default
  type: manual
  cloud_properties:
    subnet: subnet-37086b40
    range: <IP_ADDRESS>/24
    reserved: [<IP_ADDRESS>-<IP_ADDRESS>]
    static: [<IP_ADDRESS>]

cloud_provider:
  template:
    name: cpi
    release: bosh-aws-cpi

I didn't test smaller networks and resource_pools sections; I copied them from the gist above.

Eventual after CPI compilation, it continues failing with:
Started installing CPI
  Compiling package 'ruby_aws_cpi/052a28b8976e6d9ad14d3eaec6d3dd237973d800'... Finished (00:01:18)
  Compiling package 'bosh_aws_cpi/deabbf731a4fedc9285324d85af6456cfa74c10c'... Finished (00:00:34)
  Rendering job templates... Failed (00:00:00)
Failed installing CPI (00:01:53)

Command 'deploy' failed:
  Building installation state:
    Rendering job templates for installation:
      Rendering templates for job 'cpi/ca1bbc783f6b12eb1d066ac4b54c75fb8351465e':
        Rendering template src: cpi.yml.erb, dst: config/cpi.yml:
          Rendering template src: /var/folders/3x/fch8r6z97ljct1tfzk7kk34w0000gn/T/bosh-micro-release459033935/extracted_jobs/cpi/templates/cpi.yml.erb, dst: /var/folders/3x/fch8r6z97ljct1tfzk7kk34w0000gn/T/re$dered-jobs298615990/config/cpi.yml:
            Running ruby to render templates:
              Running command: 'ruby /var/folders/3x/fch8r6z97ljct1tfzk7kk34w0000gn/T/erb-renderer013178712/erb-render.rb /var/folders/3x/fch8r6z97ljct1tfzk7kk34w0000gn/T/erb-renderer013178712/erb-context.json /var/folders/3x/fch8r6z97ljct1tfzk7kk34w0000gn/T/bosh-micro-release459033935/extracted_jobs/cpi/templates/cpi.yml.erb /var/folders/3x/fch8r6z97ljct1tfzk7kk34w0000gn/T/rendered-jobs298615990/config/cpi.yml', st$out: '', stderr: '/var/folders/3x/fch8r6z97ljct1tfzk7kk34w0000gn/T/erb-renderer013178712/erb-render.rb:180:in `rescue in render': Error filling in template '/var/folders/3x/fch8r6z97ljct1tfzk7kk34w0000gn/T/bos$-micro-release459033935/extracted_jobs/cpi/templates/cpi.yml.erb' for cpi/0 (line 5: #<TemplateEvaluationContext::UnknownProperty: Can't find property 'aws.access_key_id'>) (RuntimeError)
        from /var/folders/3x/fch8r6z97ljct1tfzk7kk34w0000gn/T/erb-renderer013178712/erb-render.rb:166:in `render'
        from /var/folders/3x/fch8r6z97ljct1tfzk7kk34w0000gn/T/erb-renderer013178712/erb-render.rb:191:in `<main>'

But now the error message isn't as pretty as it was prior to compiling the CPI.

---
name: redis-from-scratch

resource_pools:
- name: default
  network: default
  cloud_properties:
    instance_type: m3.medium

networks:
- name: default
  type: manual
  cloud_properties:
    subnet: subnet-37086b40
    range: <IP_ADDRESS>/24
    reserved: [<IP_ADDRESS>-<IP_ADDRESS>]
    static: [<IP_ADDRESS>]

cloud_provider:
  template:
    name: cpi
    release: bosh-aws-cpi
  properties:
    aws:
      access_key_id: XXX
      secret_access_key: YYY
      default_key_name: sw-bosh-us-west-2
      default_security_groups: [bastion]
      region: us-west-2
      ec2_private_key: ~/.ssh/sw-bosh-us-west-2.pem
    registry:
      username: admin
      password: admin
      port: 6901
      host: localhost
    blobstore:
      provider: local
      path: /var/vcap/micro_bosh/data/cache
    nats:
      address: <IP_ADDRESS>
      password: nats

Was the minimum before it would try to create a stemcell

I add the jobs section and then it panics:
jobs:
- name: redis
  instances: 1
  templates:
  - name: redis
    release: redis
  networks:
  - name: default
    static_ips:
    - <IP_ADDRESS>
  properties:
  properties:
    redis:
      address: "<IP_ADDRESS>"
      password: "redis"
      port: 25255

properties:
properties:

Was the issue here. But golang panicing cannot be the UX for bad YAML. Hopefully there is something we can do to aide fools like me who write back YAML.

Perhaps a simple pre-marshaling effort to check "can this YAML be parsed as YAML?" "There's a YAML error on line XYZ"

Going to keep using this thread as a log of one person's efforts to build up a manifest.
Was getting this error:
Command 'deploy' failed:
  Deploying Microbosh:
    Creating instance 'redis/0':
      Creating VM:
        Creating vm with stemcell cid 'ami-b88da7d0 light':
          External CPI command for method 'create_vm' returned an error: CmdError{"type":"Unknown","message":"Connection refused - connect(2) (http://localhost:6901)","ok_to_retry":false}

This went away when I added the seemingly redundant cloud_provider.registrar:
cloud_provider:
  template:
    name: cpi
    release: bosh-aws-cpi
  ssh_tunnel:
    host: <IP_ADDRESS>
    port: 22
    user: vcap
    private_key: /home/ubuntu/.ssh/sw-bosh-us-east-1.pem
  registry:
    username: admin
    password: admin
    port: 6901
    host: localhost
  properties:
    aws:
      access_key_id: XXX
      secret_access_key: YYY
      default_key_name: sw-bosh-us-east-1
      default_security_groups: [redis-micro-default-vpc]
      region: us-east-1
      ec2_private_key: ~/.ssh/sw-bosh-us-east-1.pem
    registry:
      username: admin
      password: admin
      port: 6901
      host: localhost
    blobstore:
      provider: local
      path: /var/vcap/micro_bosh/data/cache
    nats:
      address: <IP_ADDRESS>
      password: nats

Seems strange to have to enter all this - most of it seems to be defaults. Perhaps they can be optional - would make the manifest much smaller.

Needed to fix path to key in cloud_provider. ssh_tunnel. private_key since I was on a different machine.
Tried ~/.ssh/sw-bosh-us-east-1.pem (like in ec2_private_key) but get:
Command 'deploy' failed:
  Deploying Microbosh:
    Creating instance 'redis/0':
      Waiting until instance is ready:
        Starting SSH tunnel:
          Reading private key file '~/.ssh/sw-bosh-us-east-1.pem':
            open ~/.ssh/sw-bosh-us-east-1.pem: no such file or directory

This issue is already raised in https://github.com/cloudfoundry/bosh-micro-cli/issues/4 but no response from anyone

With the ssh key fixed, the agent wasn't coming up. SSHing into the VM and looking at /var/vcap/bosh/log/current I see:
2015-04-04_04:24:26.38129 [settingsService] 2015/04/04 04:24:26 DEBUG - Loading settings from fetcher
2015-04-04_04:24:26.38186 [registryProvider] 2015/04/04 04:24:26 DEBUG - Using http registry at http://admin:admin@localhost:6901
2015-04-04_04:24:26.39146 [settingsService] 2015/04/04 04:24:26 ERROR - Failed loading settings via fetcher: Getting settings from url: Get http://admin:admin@localhost:6901/instances/i-f50bc508/settings: dial tcp <IP_ADDRESS>:6901: connection refused
2015-04-04_04:24:26.39158 [File System] 2015/04/04 04:24:26 DEBUG - Reading file /var/vcap/bosh/settings.json
2015-04-04_04:24:26.39169 [settingsService] 2015/04/04 04:24:26 ERROR - Failed reading settings from file Opening file /var/vcap/bosh/settings.json: open /var/vcap/bosh/settings.json: no such file or directory
2015-04-04_04:24:26.39180 [main] 2015/04/04 04:24:26 ERROR - App setup Running bootstrap: Fetching settings: Invoking settings fetcher: Getting settings from url: Get http://admin:admin@localhost:6901/instances/i-f50bc508/settings: dial tcp <IP_ADDRESS>:6901: connection refused

I'll keep trying tonight if anyone / @cppforlife is around and can suggest something.

Did you resolve this problem?

FYI, I raised the issue of the stack trace and its inscrutibility with @fraenkel in this PR: https://github.com/fraenkel/candiedyaml/issues/5
He has since added commits to https://github.com/cloudfoundry-incubator/candiedyaml to improve failure messages when unmarshalling. The dependency will need to be bumped in bosh-init to take advantage of this.

We have switched to using go-yaml library which provides better error messages for invalid YAML.


Add version file and validation

Hi @Veloctor!
@Icecovery has been helping the CKAN team to maintain this mod's compatibility manually (see KSP-CKAN/NetKAN#8794, KSP-CKAN/NetKAN#8823, KSP-CKAN/NetKAN#8867, and KSP-CKAN/NetKAN#8941). This is not optimal because it is a manual step, so the compatibility of each release is limited when it is first released until someone notices it and creates an update to fix it.
If you merge this pull request and include an up to date copy of the KerwisChineseAerospacePack.version file in your release ZIP files, then we will be able to use it to set the compatibility automatically to the range of game versions that you choose in the KSP_VERSION_MIN and KSP_VERSION_MAX properties.
This pull request also includes a GitHub workflow to validate changes to the version file as they are made using @DasSkelett's GitHub Action, to help catch syntax errors and other problems before you create the release ZIPs.
Cheers!

I have some questions about "KerwisChineseAerospacePack.version":

I have some quesions about "KerwisChineseAerospacePack.version":
1.The "URL" seems to be a link to this file in this repository, but the file is already been uploaded with the mod, so why the URL is needed? What if I forgot update this file to Github repo?(we use PlasticSCM instead of Github for version control in the development)
2.The "DOWNLOAD" seems to be the download link of the mod archive file, but if I upload archive file of new version to SpaceDock,CKAN will know the new download link. This mark seems to be meaningless. What if I forgot update this mark or written a link that different from the real link, and upload the .version file with zip file of new version?

I have some quesions about "KerwisChineseAerospacePack.version":

Thanks for merging! I'll try to answer your questions. For reference, the version file format was created for the KSP-AVC mod, and the original documentation is here:
https://github.com/CYBUTEK/KSPAddonVersionChecker/blob/master/Documents/MiniAVC/README.md

The "URL" seems to be a link to this file in this repository, but the file is already been uploaded with the mod, so why the URL is needed?

The URL property has two functions:

It can be used to announce new updates to users of the KSP-AVC mod. If a user has KSP-AVC and your mod installed, then each time they run KSP, KSP-AVC will check the version file found at this URL for updates. If you change the VERSION property of the version file on GitHub, then users of old versions will be notified that there is a newer version available.
It can be used to update the compatibility of a release without replacing the ZIP file. For example, if you someday decide that version 1.1 of this mod is compatible with KSP 1.9 but not 1.8, then you can edit the version file on GitHub, and KSP-AVC and CKAN will use the new compatibility for all users of that version.

What if I forgot update this file to Github repo?(we use PlasticSCM instead of Github for version control in the development)

If you have another place where you would prefer to store the version file, then it is fine to change the URL property to use another location. The only requirement is that it is publicly accessible.

The "DOWNLOAD" seems to be the download link of the mod archive file, but if I upload archive file of new version to SpaceDock,CKAN will know the new download link. This mark seems to be meaningless. What if I forgot update this mark or written a link that different from the real link, and upload the .version file with zip file of new version?

This property is used only by the KSP-AVC mod, not CKAN. When KSP-AVC announces an available update to the user (see my item 1 above), the DOWNLOAD property is provided as a link that they can click to download it. I have included this property for completeness and the convenience of users of KSP-AVC.

Thank you for your answer!


⚠ GitLab Server has degraded performance

In 47e69e3, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 6423 ms

Resolved: GitLab Server performance has improved in f237938.


added function to provide dual values

The newly added function is to be able to get both the list of versions and the latest version in a single call. This will reduce the time it takes to perform these 2 activities to half.

@yzainee Your image is available in the registry: docker pull MISSING_REGISTRY_NAME/MISSING_IMAGE_NAME:SNAPSHOT-PR-55


[Button/ButtonBase] Ripple activates on scroll swipe

v1-beta12
As per title. If you swipe on an element with a button/button base (i.e. a list item with an action on it), the ripple effect fires.
This isn't usually that bad of a problem, however if you are scrolling through a list of items with actions on mobile it is really jarring and janky.
As you tap to scroll, the ripple fires on the element you started your tap swipe on.
It's misleading for the user (as releasing your finger doesn't actually fire the onclick handler), and it looks plain old janky.
The solution (i think) would be to wait a few cycles before firing the ripple, and cancelling the ripple if there was pointer movement above a certain threshold.

Duplicate of #6729


Syndesis: one-to-many transformation disappears upon reopen

xref: https://issues.redhat.com/browse/ENTESB-16032
When Data Mapper step with Repeat one-to-many transformation reopens, transformation dropdown goes empty and break the mapping. This happens only in Syndesis, but not with AtlasMap standalone.
Note that the id attribute indicates that Repeat action is selected. But there's no <option> under it.
<select id="user-field-action-Repeat" data-testid="user-field-action-Repeat"
 class="pf-c-form-control" aria-invalid="false">
</select>

Correct HTML is here
<select id="user-field-action-Repeat" data-testid="user-field-action-Repeat"
  class="pf-c-form-control" aria-invalid="false">
  <option class="" value="CopyTo">CopyTo</option>
  <option class="" value="Repeat">Repeat</option>
  <option class="" value="Split">Split</option>
</select>

transformationsOptions is empty while name = Repeat is passed in

And the one-to-many transformation aren't delivered because the transition mode is ONE_TO_ONE, which have to be ONE_TO_MANY

So, at least MappingSerializer.deserializeFieldMapping() doesn't set the transition mode to ONE_TO_MANY. But when it runs in standalone, it's somehow set to ONE_TO_MANY while it stays ONE_TO_ONE when it runs in syndesis.

MappingManagementService.updateTransition() is the one does that job. It's not invoked in Syndesis as expected.


Add host/port in heartbeat

Purpose of the pull request
To avoid parsing the address to host/port in registry
Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Codecov Report

Merging #14591 (ed7fdd0) into dev (8505f18) will increase coverage by 0.00%.
The diff coverage is 33.33%.

:exclamation: Current head ed7fdd0 differs from pull request most recent head d6636cf. Consider uploading reports for the commit d6636cf to get more accurate results

@@            Coverage Diff            @@
##                dev   #14591   +/-   ##
=========================================
  Coverage     38.46%   38.46%
+ Complexity     4547     4543    -4
=========================================
  Files          1255     1255
  Lines         43727    43687   -40
  Branches       4825     4796   -29
=========================================
- Hits          16819    16805   -14
+ Misses        25037    25011   -26
  Partials       1871     1871

Impacted Files
Coverage Δ

...inscheduler/alert/registry/AlertHeartbeatTask.java
0.00% <0.00%> (ø)

...eduler/server/master/task/MasterHeartBeatTask.java
4.00% <0.00%> (-0.35%)
:arrow_down:

...eduler/server/worker/task/WorkerHeartBeatTask.java
81.25% <100.00%> (+0.81%)
:arrow_up:

... and 33 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Update count action

As you start playing the game,
when the counts are multiple of 30, we get a cookie to click.
when we click on the cookie our score increases by +10
It will be great if the count doubles everytime
for 1st time +10 ,
for 2nd time  +20,
for 3rd time +30
....

Hi @scorcism I would Like to work on this issue can you please assign me this.

@Vayras yes go for it

@scorcism i have created a pull request can you please check it , also let me know if there are any issues

@Vayras Everything was perfect.
You can create more issues for any further updates

@scorcism Absolutely, that sounds great! Looking forward to collaborating


jenkins: add Jenkinsfile for CI pipeline

See summary.

Success! Download the plugin (SHA: cbb5d25eb9256d23d64ced12d33eed88626189e6)

Success! Download the plugin (SHA: ce0a61de85b63af8d0c16d5889ec4cac4e5f9bc3)

Success! Download the plugin (SHA: fc41cfa547a3771a041e0cbacf69982b71cfaaa5)

Success! Download the plugin (SHA: a68e8d5503cd46cafded21374d092849f4f135c2)

Success! Download the plugin (SHA: fba1a976777ef4d7ecbd36e4f465c361f75b9f7d)

Success! Download the plugin (SHA: fba1a976777ef4d7ecbd36e4f465c361f75b9f7d)

Success! Download the plugin (SHA: aed55179e901c4fcc2a7ec1ae7d74403b9b26b19)

Success! Download the plugin (SHA: 7c7967fdeb776ff3159fda01facf62d594d7ab6b)

Success! Download the plugin (SHA: 811f8db089693c35cc15c6d60915d095370f2d55)

retest this please

retest this please

retest this please

retest this please

Success! Download the plugin (SHA: 5972b6a32b66d24d2ab910af5a887dbfb539ecb2)


DCOS-13661: Forbid destructuring in methods

As we've agreed that we want to keep our class interface as clear as possible it is beneficial to have a name for a param and you can always destructure it in a method body.
It is still okay to destructure in params in higher order functions and in standalone functions.

Works as expected!


Call Remote LLM API Instead Of Inferrencing Locally

Currently, Byaldi requires local inference by RAG = RAGMultiModalModel.from_pretrained("vidore/colpali-v1.2"). Can you refactor the RAGMultiModalModel class to call a remote VLLM API to complete the work? E.g. RAGMultiModalModel.from_api("https://localhost:3000/v1/completions").

Currently, Byaldi requires local inference by RAG = RAGMultiModalModel.from_pretrained("vidore/colpali-v1.2"). Can you refactor the RAGMultiModalModel class to call a remote VLLM API to complete the work? E.g. RAGMultiModalModel.from_api("https://localhost:3000/v1/completions").

This is planned, but not as a priority, mainly because there currently isn't a clear API to attach to (see https://github.com/vllm-project/vllm/issues/7983 for VLLM), and I'm not aware of any providers providing multi-modal multivector endpoints.


Add support for setting temperature scale

Currently the temperature data is only available as Celsius.
Add standard TempScale() method

added in ebaeed6e98d04e57bd8d4968f8d4735928e4a0e9


MySQL: User-defined variables leak across migrations

Which version and edition of Flyway are you using?
5.2.1
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)
flyway commandline 5.2.1
Which database are you using (type & version)?
mysql --version
mysql  Ver 15.1 Distrib 10.1.34-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2
Which operating system are you using?
ubuntu 18.10
What did you do?
Create two migrations with different variables in them, noticing the variable leak with a typo in the second migration:
V1__one.sql:
 SELECT id INTO @var1 FROM table WHEREtext = 'text1';
  ...
V2__two.sql:
 SELECT id INTO @var2 FROM table WHEREtext = 'text2';
  INSERT INTO table (tid,value) VALUES (@var1, 'value2');
What did you expect to see?
Not having access to @var1 in migration V2, thus having the second migration always fail
What did you see instead?
The second migration V2 fails only if migrated without V1 (@var1 isn't known), but works with a clean before (@var1 is used from migration V1).

Hmm interesting. Is there a way to unset all user-defined variables with MySQL?

Digging deeper into this, it appears that starting with MySQL 5.7 the following should be possible:

SELECT variable_name FROM performance_schema.user_variables_by_thread WHERE variable_value IS NOT NULL
SET all those variables to NULL in a single SET statement

This should effectively plug this leak.

Hmm looks like that table is not enabled per default:
ERROR 1146 (42S02): Table 'performance_schema.user_variables_by_thread' doesn't exist
thus probably not that portable.
Anyway, I thought flyway's parser would analyze the SQL statements figuring variables and reset them or at least reset the session to a consistent state across the migrations.
If this behavior is to be expected, it might be useful to state this in the documentation.

For MariaDB 10.2 and later it appears the query should be replaced with SELECT variable_name FROM information_schema.USER_VARIABLES WHERE variable_value IS NOT NULL . See https://mariadb.com/kb/en/library/information-schema-user_variables-table/
The fix for this will therefore only be implemented by default for MariaDB 10.2+ and MySQL 5.7+.
For earlier MariaDB versions, the existence of this table should first be checked with SELECT count(*) FROM information_schema.PLUGINS WHERE plugin_name='user_variables' and plugin_status='ACTIVE'

So I'm not getting a fix when running 10.1?
SELECT variable_name FROM information_schema.USER_VARIABLES WHERE variable_value IS NOT NULL;
ERROR 1109 (42S02): Unknown table 'user_variables' in information_schema

So I'm not getting a fix when running 10.1?

You must install the user_variables plugin for 10.1 for our upcoming fix to work for you. Read up on that topic in the MariaDB docs if you aren't familiar with this.

The plugin was introduced with MariaDB 10.2 https://mariadb.com/kb/en/library/information-schema-user_variables-table/


Add severity at config for not_accepted_value test

Describe the feature
Consider the possibility to configure severity and error_if/ warn_if at not_accepted_values test.
Additional context
This feature would help to precise the quantity that is acceptable for certain value at a table por example, and it would facilitate the monitoring of the error if the limit is attained.
Who will this benefit?
For example, we are consulting an API to generate an incremental table at our datawarehouse. However, sometimes the API attains resource limit or another error, and returns an error status as output. It is hard to have zero cases of this, and it is acceptable if it stays below a limit, but with this feature it would be possible to monitor if it is surpassing the limit and there is any other problem we have not seen beforehand.
Are you interested in contributing this feature?
I am interested in contributing with it.

I understood the test now. The severity is considered for it, but the point is that it does not return the number of rows that have not accepted values. The test returns a row for each not accepted value that is identified, not considering the number of records each value have on the column. Since I want to monitor how many rows we have for a category that should not pass the set limit, I created a custom test.


Error when running sample: ModuleNotFoundError: No module named 'google'

Describe the bug
I've followed the instructions in the README but when running it I receive the following error:
raceback (most recent call last):
  File "/workspaces/tmp-ha-google/get-token.py", line 1, in <module>
    from glocaltokens.client import GLocalAuthenticationTokens
  File "/home/vscode/.local/lib/python3.10/site-packages/glocaltokens/client.py", line 24, in <module>
    from .google.internal.home.foyer.v1_pb2 import GetHomeGraphRequest, GetHomeGraphResponse
  File "/home/vscode/.local/lib/python3.10/site-packages/glocaltokens/google/internal/home/foyer/v1_pb2.py", line 6, in <module>
    from google.protobuf import (
ModuleNotFoundError: No module named 'google'

This is in an isolated environment with python 3.10.4 installed (I ran a fresh Docker image with only Python 3 in it).

You should consider upgrading via the '/usr/local/bin/python -m pip install --upgrade pip' command.
vscode ➜ /workspaces/tmp-ha-google $ python3 get-token.py
Traceback (most recent call last):
  File "/workspaces/tmp-ha-google/get-token.py", line 1, in <module>
    from glocaltokens.client import GLocalAuthenticationTokens
  File "/home/vscode/.local/lib/python3.10/site-packages/glocaltokens/client.py", line 24, in <module>
    from .google.internal.home.foyer.v1_pb2 import GetHomeGraphRequest, GetHomeGraphResponse
  File "/home/vscode/.local/lib/python3.10/site-packages/glocaltokens/google/internal/home/foyer/v1_pb2.py", line 6, in <module>
    from google.protobuf import (
ModuleNotFoundError: No module named 'google'
vscode ➜ /workspaces/tmp-ha-google $

Does it work if you install google-api-python-client?

Done, but looks like a protobuf problem now:
vscode ➜ /workspaces/tmp-ha-google $ python3 get-token.py
Traceback (most recent call last):
  File "/workspaces/tmp-ha-google/get-token.py", line 1, in <module>
    from glocaltokens.client import GLocalAuthenticationTokens
  File "/home/vscode/.local/lib/python3.10/site-packages/glocaltokens/client.py", line 24, in <module>
    from .google.internal.home.foyer.v1_pb2 import GetHomeGraphRequest, GetHomeGraphResponse
  File "/home/vscode/.local/lib/python3.10/site-packages/glocaltokens/google/internal/home/foyer/v1_pb2.py", line 28, in <module>
    _GETASSISTANTROUTINESREQUEST = _descriptor.Descriptor(
  File "/home/vscode/.local/lib/python3.10/site-packages/google/protobuf/descriptor.py", line 313, in __new__
    _message.Message._CheckCalledFromGeneratedFile()
TypeError: Descriptors cannot not be created directly.
If this call came from a _pb2.py file, your generated code is out of date and must be regenerated with protoc >= 3.19.0.
If you cannot immediately regenerate your protos, some other possible workarounds are:
 1. Downgrade the protobuf package to 3.20.x or lower.
 2. Set PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python (but this will use pure-Python parsing and will be much slower).

More information: https://developers.google.com/protocol-buffers/docs/news/2022-05-06#python-updates

Ok, downgraded protobuf with pip install protobuf==3.19.4
Is there a way to pin the dependency so it doesn't install too newer version?

@aaronpowell I released version 0.6.5 with a fix. Can you confirm that it works without installing google-api-python-client and downgrading protobuf?


load from local file

As I understand, epubjs allow to get book from bytesArray

There is a fork here with an interesting option to load local files:
https://github.com/polymorph001/epub_viewer
but is not completed yet because I can't read the chapters from that fork and the callbacks are no working well

There is a fork here with an interesting option to load local files:
https://github.com/polymorph001/epub_viewer
but is not completed yet because I can't read the chapters from that fork and the callbacks are no working well

This seems to be a good approch


feat(analytics): added google analytics to portal

:tada: This PR is included in version 5.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


ARROW-3797: [Rust] BinaryArray::value_offset incorrect in offset case

Fixes a bug in BinaryArray::value_offset. Also added test cases to now cover this method as well as the BinaryArray::value_length method in the case where the underlying ArrayData has a nonzero offset.

Codecov Report

Merging #2971 into master will increase coverage by 1%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #2971     +/-   ##
=========================================
+ Coverage   86.45%   87.46%     +1%
=========================================
  Files         490      434     -56
  Lines       68920    65558   -3362
=========================================
- Hits        59583    57338   -2245
+ Misses       9247     8220   -1027
+ Partials       90        0     -90

Impacted Files
Coverage Δ

rust/src/array.rs
87.69% <100%> (+0.07%)
:arrow_up:

cpp/src/arrow/csv/column-builder.cc
95.3% <0%> (-2.02%)
:arrow_down:

go/arrow/array/table.go

go/arrow/math/uint64_amd64.go

go/arrow/internal/testing/tools/bool.go

go/arrow/internal/bitutil/bitutil.go

go/arrow/memory/memory_avx2_amd64.go

go/arrow/array/null.go

go/arrow/datatype_nested.go

go/arrow/array/string.go

... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 736b5b0...fea0730. Read the comment docs.


azure-sdk-for-java VS azure-spring-boot VS spring-cloud-azure

I am lost between Microsoft Azure Java libraries ....
Why do we have both azure-spring-boot and spring-cloud-azure ?
If I want storage as spring resource I have to use spring-cloud-azure but under the hood it uses a very old version azure-storage-6.1.0.jar (Nov 01, 2017)
If I want to use azure-spring-boot (this is where we arrive if we follow https://cloud.spring.io/spring-cloud-azure), I do not have storage as a spring resource integration and behind the hood it uses the not recommened version azure-storage-blob-10.5.0.jar (https://github.com/Azure/azure-storage-java)
If I want to use the recommended version of the last azure storage sdk (v12), I have no spring integration at all (https://azure.microsoft.com/en-us/blog/previewing-azure-sdks-following-new-azure-sdk-api-standards/).
I can still see releases on all these projects. What are the plans ? What should we use ?
Thanks for your help/directions.

Thanks for reaching out to us and sorry for all the confusion.
The difference between azure-spring-boot and spring-cloud-azure lies in that azure-spring-boot brings a Spring Boot starter, for auto-configure and managing dependency, while spring-cloud-azure provides Spring Resource integration.
We're planning to upgrade underlying Azure Storage SDK to v12, for both projects, so please stay tuned.

Hi @saragluna, thank you for your answer.
Here are my 2 cents :

I am not sure that 2 different libs are bringing any benefits here but I may be wrong. It makes it more difficult for you to manage/maintain/upgrade and it brings confusion. Moreover, because dependencies are not the same it makes it almost impossible to use together.
I think I saw that azure-spring-boot is bringing a lots of azure dependencies even when we are just interested in a small subset like storage, but maybe you started doing smaller specialized starter.
Maintaining dependencies up to date is really important to make it useful and secure.

I hope it gets better in the future. Thanks.

@miva2 yep, as for storage, these two starters have the same effect. You can use any one of them according to your situation.

We're migrating our projects to azure-sdk-for-java repo. The migration for azure-spring-boot project is done and spring-cloud-azure is still in process.
We deprecated the https://github.com/Azure/azure-sdk-for-java/tree/master/sdk/spring/azure-spring-boot-starter-storage and further development will be focused on https://github.com/microsoft/spring-cloud-azure/tree/master/spring-cloud-azure-starters/spring-starter-azure-storage.
Closing this issue now.


protocol: return status of ReadRawData instead of relying on SetStatus

Fixes #4928
Behavior was changed here https://codereview.chromium.org/1467603002

Thanks!


Add DataType::Utf8View and DataType::BinaryView

Which issue does this PR close?

Part of #5468 .
Rationale for this change
Add DataType::Utf8View and DataType::BinaryView. This is the first step towards supporting StringViewArray in arrow.

What changes are included in this PR?
Only the type definition and the related comments. Most of the handling of the types are unimplemented!()
I'm new to arrow and not sure if this is the commit granularity we expected, comments/suggestions welcome!

Are there any user-facing changes?

I am pleasantly surprised by how few places in the code needed to be changed.

I am pleasantly surprised by how few places in the code needed to be changed.

I mostly rely on the compiler to find where to add unimplemented!(). Other cases like:
match data_type {
  DataType::some_thing => {}
  _ => {}
}

https://github.com/XiangpengHao/arrow-rs/blob/d861177a5d0171fab8d4f646d3b72dfabf83b14d/rust/arrow/src/datatypes/field.rs#L124
Might require a closer look to make sure they are safe to escape

If there's nothing wrong with it, let's go ahead and merge it and I'll do a follow-up based on that.

If there's nothing wrong with it, let's go ahead and merge it and I'll do a follow-up based on that.

Looks like the follow up is here: https://github.com/apache/arrow-rs/pull/5470

THanks everyone -- it is so exciting to see this project begin


[feature request] Folders in the profiles dropdown

Description of the new feature/enhancement
I have a lot of profiles to remote servers I connect using SSH. It would help a lot my organization if we could organize our profiles into folders.

You can already do this. See newTabMenu
/dup #1571


Handle command arguments

Quick suggestion to handle command arguments as requested in #3
> help
                  gc - call garbage collector.
                help - well, I guess you already know.
                ping - just an example
                quit - close prompt.
             runtime - display runtime information.
> ping test
pong! [test]
> ping test 2
pong! [test 2]
> quit

Using the following action:
        cmd := prompt.Command{
                Cmd:  "ping",
                Desc: "just an example",
                Action: func(args []string) {
                        fmt.Println("pong!", args)
                },
        }

Please note that this approach would break V1 API.

Nice! :+1:


any type incorrectly inferred for async function result, differing from sync function result

TypeScript Version:  2.1.1   (current Playground as at 2017-01-05)
Code
Paste this into Playground
// A *self-contained* demonstration of the problem follows...

const asyncFunc = async () => {

    //doesn't matter - just something non-deterministic
    var r = Math.random();

    //one possibility - we return an array of ints
    if (r === 0) {
        return [1, 2, 3];
    }

    //other possibility - we return a single int wrapped in an array
    if (r === 1) {
        return [4];
    }

    //an empty array (ought to be typed as int)
    return [];
    //NOTE: changing to    return new Array<int>();    fixes this

}

var funcResult = asyncFunc();  //type is Promise<any[]>.  Should be Promise<int[]>

Expected behavior:
The inferred type of funcResult should be Promise<int[]>
Actual behavior:
It is inferred as Promise<any[]>
Note that inference works correctly with the exact same code not using async/await (since the async function didn't do any awaiting).  By that I mean, this...

const func = () => {

    //doesn't matter - just something non-deterministic
    var r = Math.random();

    //one possibility - we return an array of ints
    if (r === 0) {
        return [1, 2, 3];
    }

    //other possibility - we return a single int wrapped in an array
    if (r === 1) {
        return [4];
    }

    //an empty array
    return [];

}

var funcResult = func();  //type is correctly seen as Promise<int[]>

In case it helps, here's a shareable link to the async version.
Inspect the type of funcResult.  You'll incorrectly get Promise<any[]>
Then delete the word "async".
Inspect the type of funcResult.   You'll correctly get int[]
http://www.typescriptlang.org/play/index.html#src=const asyncFunc %3D async () %3D> {

    %2F%2Fdoesn't matter - just something non-deterministic
    var r %3D Math.random()%3B

    %2F%2Fone possibility - we return an array of ints
    if (r %3D%3D%3D 0) {
        return [1%2C 2%2C 3]%3B
    }

    %2F%2Fother possibility - we return a single int wrapped in an array
    if (r %3D%3D%3D 1) {
        return [4]%3B
    }

    %2F%2Fan empty array (ought to be typed as int)
    return []%3B
    %2F%2FNOTE%3A changing to    return new Array<int>()%3B    fixes this

}

var funcResult %3D asyncFunc()%3B  %2F%2Ftype is Promise<any[]>.  Should be Promise<int[]>

It seems a valid bug! Though annotating <number[]>[] will resolve this case, I do think compiler should do a consistent subtype reduction in both synchronous and asynchronous function.
@rbuckton should know better.

This is working correctly in latest.


Tensorflow now supports python 3.7 but mtcnn don't.

Getting this error:
site-packages/mtcnn/mtcnn.py", line 616, in del
self.__session.close()
AttributeError: 'MTCNN' object has no attribute '_MTCNN__session'
Tensorflow now support python 3.7.
https://github.com/tensorflow/tensorflow/issues/31431

fixed it maybe i will update later.

it can be found here for tensorflow 2.0
https://github.com/instabotai/instabotai-webgui

https://github.com/tensorflow/tensorflow/issues/31939

@steffanjensen @akofman @knrz @xolott @MattyB95
HI,
Hope you are well
As per your suggestion, I am using MTCNN for face detection, I take GPU,
Can you please, tell me how can I able to remove the MTCNN from GPU after it detected the face?
So, if MTCNN was removed from GPU after it detected the face, I can pass CDCN to GPU

It is set a different Steps_threshold, at MTCNN it gives different Boundary Box values
The Default Steps_threshold =[0.6,0.7,0.7]

Hope for a reply
Thank you

In my case changing mtcnn version from 0.0.9 to 0.1.0 did the trick


Submit to Colorsublime?

https://github.com/Colorsublime/Colorsublime-Themes

I'm pretty sure Colorsublime is meant only for color schemes and not themes (I've actually submitted a few color schemes to them in the past). And since Material Spacegray is mostly a theme modification that uses the base16-ocean color scheme from Spacegray, it wouldn't really make much sense to submit it. Thanks for the suggestion.


Splitted routes bug

I think that I found a bug in swagger. If we split routes as I show below the generated uri by swagger will be
/api/v1/users/
instead
/api/v1/users
(reduntant slash)
file: routes
->	/api/v1/users		                userApi.Routes
file userApi.routes
POST   /                 UserController.createUser

fixed in: https://github.com/swagger-api/swagger-play/pull/82


user/entity comment macro dropdown active items aren't visible

Looks like the recent ui-bootstrap update changed how the active selection is being styled:

Oops, meant to post this on the client repo


Add conflict condition between datadog-agent and datadog-iot-agent

What does this PR do?
Set datadog-iot-agent and datadog-agent in conflict

Motivation
These packages cannot be installed in the same time as they share installation and configuration files (see above)

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Installed lastest datadog-agent
Install latest datadog-iot-agent

Clear everything
Install custom version of datadog-agent
Install custom version of datadog-iot-agent

Install custom version of datadog-agent

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

good question, I'll have a look


Failed row of the table is not colored as red

Expected behavior
Failed row of the table should be colored as red
Actual behavior
Failed row of the table is not colored as red
Steps to reproduce

Create a sample project
Add a step in the spec file for data driven testing using a table
In that table, add a row to fail that step

Gauge version
Gauge version: 0.8.4
Plugins
html-report (4.0.0)
java (0.6.3)
spectacle (0.1.2)

@osandadeshan Please try this with the latest version i.e 0.9.0

I am sorry. Still no difference

@osandadeshan You are using the table as a param in the step. The behavior you have mentioned only works with Data Driven Execution.

@kashishm Yes. But It will be much effective for the testers if you can add that as an enhancement. It will increase the readability of the executable html report.

Is this being considered?

Unfortunately this cannot be implemented for table parameters as looping through the rows are handled inside the step implementation. There is no way to send this information while creating html reports.


dsVideoPort - L1 improvement using test profile file

use the new setting file to read the device specific values to validate in UT

This issue is a duplicate of https://github.com/rdkcentral/rdk-halif-test-device_settings/issues/62
Can be closed


[CIT- 538] fix mqtt sub on reconnect

Proposed changes
The command tedge mqtt sub misses all the messages that are published after a broker restart because the underlying library automatically reconnect to the broker but fails to re-subscribe to the topics of interest. The tedge mqtt sub is not even aware that the connection has been temporarily lost and that no more topics are subscribed to.
The fix proposed here is to restart the main loop on any protocol errors (TCP and MQTT).
Other alternatives has been considered. This one is the less invasive: only the code of the subscribe command is impacted.

The best option would be to have the issue fixed by the rumqttc crate. See https://github.com/bytebeamio/rumqtt/issues/250.
A quick fix would be to unset the clean session flag for the tedge mqtt sub command, but this defeat the purpose of that command and would produced numerous unused persistent session on the broker.
A more involved solution would to encapsulate in the mqtt_client crate the management of the subscriptions in case of a reconnect. This is more complex then expected at first because the current design introduces a strong separation between the high level actions (as subscribing) and the low level event detections (as a disconnection).
Yet another option is simply to use directly the rumqttc crate without the mqtt_client library. Indeed, this helper library was suppose to help us to write mqtt clients. In that specific case this is a failure. A following PR will be submitted proposing this option.

Types of changes
What types of changes does your code introduce to thin-edge.io?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
[ ] Documentation Update (if none of the other choices apply)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have read the CONTRIBUTING doc
[ ] I have signed the CLA (in all commits with git commit -s)
[x] I ran cargo fmt as mentioned in CODING_GUIDELINES
[ ] I used cargo clippy as mentioned in CODING_GUIDELINES
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

This PR has been closed in favor of https://github.com/thin-edge/thin-edge.io/pull/418


Command return non null code

Depending on the daemon I'm using, same command doesn't return the same code.
$ docker run --rm alpine echo foo
foo
$ echo $?
125

I would expect it to be 0.
Output of docker version:
Client:
 Version:      1.13.0
 API version:  1.22
 Go version:   go1.7.4
 Git commit:   49bf474
 Built:
 OS/Arch:      darwin/amd64

Server:
 Version:      1.10.3
 API version:  1.22 (minimum version )
 Go version:   go1.5.3
 Git commit:   20f81dd
 Built:        Thu Mar 10 15:38:58 2016
 OS/Arch:      linux/amd64
 Experimental: false

Output of docker info:
Containers: 97
 Running: 51
 Paused: 0
 Stopped: 46
Images: 2177
Server Version: 1.10.3
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 2563
 Dirperm1 Supported: true
Logging Driver: json-file
Plugins:
 Volume: local
 Network: bridge null host
Swarm:
 NodeID:
 Is Manager: false
 Node Address:
Init Binary:
containerd version:
runc version:
init version:
Kernel Version: 3.16.0-4-amd64
Operating System: Debian GNU/Linux 8 (jessie)
OSType: linux
Architecture: x86_64
CPUs: 8
Total Memory: 63 GiB
Name: staging.synbioz.com
ID: NNUK:5FUU:S2AI:VIQX:FN5X:5ELM:IKUX:BPMO:6BIV:E7JD:Q56M:WROE
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Username: fuse
Registry: https://index.docker.io/v1/
WARNING: No memory limit support
WARNING: No swap limit support
WARNING: No kernel memory limit support
WARNING: No oom kill disable support
WARNING: No cpu cfs quota support
WARNING: No cpu cfs period support
Experimental: false
Insecure Registries:
 <IP_ADDRESS>/8
Live Restore Enabled: false

Host has been created using docker-machine and the generic driver.
By the way, using a different host, or even a local VM the return code is 0.
For instance this daemon works as expected :
Output of docker version:
Client:
 Version:      1.13.0
 API version:  1.22
 Go version:   go1.7.4
 Git commit:   49bf474
 Built:
 OS/Arch:      darwin/amd64

Server:
 Version:      17.03.0-ce
 API version:  1.26 (minimum version 1.12)
 Go version:   go1.7.5
 Git commit:   60ccb22
 Built:        Thu Feb 23 11:02:43 2017
 OS/Arch:      linux/amd64
 Experimental: false

Output of docker info:
Containers: 1
 Running: 1
 Paused: 0
 Stopped: 0
Images: 2
Server Version: 17.03.0-ce
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 4
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge host macvlan null overlay
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: 977c511eda0925a723debdc94d09459af49d082a
runc version: a01dafd48bc1c7cc12bdb01206f9fea7dd6feb70
init version: 949e6fa
Security Options:
 apparmor
 seccomp
Kernel Version: 4.4.0-64-generic
Operating System: Ubuntu 16.04.2 LTS
OSType: linux
Architecture: x86_64
CPUs: 2
Total Memory: 7.795 GiB
Name: ip-172-31-36-172
ID: UHOY:U7NJ:ZADC:LWF2:XGP4:32R7:IK4M:IOGS:P6CG:QONI:COXP:7NTX
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Username: fuse
Registry: https://index.docker.io/v1/
WARNING: No swap limit support
Experimental: false
Insecure Registries:
 <IP_ADDRESS>/8
Live Restore Enabled: false

The version that's failing is quite old (1.10.3); possibly the issue has been fixed since; are you still seeing the issue if the version is updated?

Just upgraded to 17.04.0-ce and it now works as expected, thanks.

Thanks for reporting back, closing.


Bump redis chart version

Bumping Redis subchart to 18.5.0, which adds the capability to deploy Redis in a different namespace (PR https://github.com/bitnami/charts/pull/21479), if desired, using the following variable:
redis:
    namespaceOverride:

@jgmartinez, could you please add an annotation for ArtifactHub to be approved.

All should be good now @pierluigilenoci  😄
Thanks a lot!


Teckin SP23 keeps flashing rapid quick blue light after installing tasmota latest version

Hi
I have a Teckin SP23 smart socket that I flashed using Tuya Over the Air. I followed everything correctly i.e. I had my phoned connected to "vtrust-flash" and was able to flash using my raspberry pi 2b+ connected via ethernet and a wifi dongle.
I also included the latest sonoff tasmota binary file and renamed it to thirdparty.bin. I then selected option 3 to install this tasmota binary file and it was successful.
However I cannot see the Tasmota AP on my phone or computer and the blue led power on/off light is flashing on my Teckin SP23 in a rapid manner.
So I tried doing the whole process over again hoping I would be able to install a different binary file but my Teckin SP23 doesnt go in flash mode even if I turn it on or off, the blue led keeps flashing rapidly.
Here are my logs after trying to re do the process all over again:
smarthack-wifi.log:
lan0: interface state ENABLED->DISABLED
wlan0: AP-STA-DISCONNECTED 24:18:1d:47:dd:be
wlan0: AP-DISABLED
nl80211: deinit ifname=wlan0 disabled_11b_rates=0
AP closed
Stopping DNSMASQ server...
Configuring AP interface...
RTNETLINK answers: File exists
RTNETLINK answers: File exists
Starting DNSMASQ server...
Starting AP on wlan0...
Configuration file: hostapd.conf
Using interface wlan0 with hwaddr 00:0f:55:a8:d0:04 and ssid "vtrust-flash"
wlan0: interface state UNINITIALIZED->ENABLED
wlan0: AP-ENABLED
wlan0: AP-STA-CONNECTED 24:18:1d:47:dd:be

smartwifihack-mqtt.log:
^C1572999964: mosquitto version 1.4.10 terminating
1572999971: mosquitto version 1.4.10 (build date Wed, 13 Feb 2019 00:45:38 +0000) starting
1572999971: Using default config.
1572999971: Opening ipv4 listen socket on port 1883.
1572999971: Opening ipv6 listen socket on port 1883.

smartwifihack-web.log:

^CReceived SIGINT, exiting...
Listening on <IP_ADDRESS>:80
^[[32m[I 191106 00:26:15 web:2246]^[[m^O 302 GET /generate_204 (<IP_ADDRESS>) 5.69ms
^[[32m[I 191106 00:26:15 web:2246]^[[m^O 302 GET /generate_204 (<IP_ADDRESS>) 4.33ms
^[[32m[I 191106 00:27:16 web:2246]^[[m^O 302 GET /generate_204 (<IP_ADDRESS>) 5.61ms

smartwifihack-psk.log:
new client on port 443 from <IP_ADDRESS>:54818
('could not establish sslpsk socket:', SSLError(1, u'[SSL: NO_SHARED_CIPHER] no shared cipher (_ssl.c:661)'))
new client on port 443 from <IP_ADDRESS>:54820
('could not establish sslpsk socket:', SSLError(1, u'[SSL: NO_SHARED_CIPHER] no shared cipher (_ssl.c:661)'))
new client on port 443 from <IP_ADDRESS>:54822
('could not establish sslpsk socket:', SSLError(1, u'[SSL: NO_SHARED_CIPHER] no shared cipher (_ssl.c:661)'))
new client on port 443 from <IP_ADDRESS>:54828
('could not establish sslpsk socket:', SSLError(1, u'[SSL: NO_SHARED_CIPHER] no shared cipher (_ssl.c:661)'))
new client on port 443 from <IP_ADDRESS>:54832
('could not establish sslpsk socket:', SSLError(1, u'[SSL: NO_SHARED_CIPHER] no shared cipher (_ssl.c:661)'))
^CTraceback (most recent call last):
  File "./psk-frontend.py", line 105, in <module>
    main()
  File "./psk-frontend.py", line 98, in main
    r,_,_ =  select.select(readables, [], [])
KeyboardInterrupt
new client on port 443 from <IP_ADDRESS>:54880
('could not establish sslpsk socket:', SSLError(1, u'[SSL: NO_SHARED_CIPHER] no shared cipher (_ssl.c:661)'))
new client on port 443 from <IP_ADDRESS>:54882
('could not establish sslpsk socket:', SSLError(1, u'[SSL: NO_SHARED_CIPHER] no shared cipher (_ssl.c:661)'))
new client on port 443 from <IP_ADDRESS>:54884
('could not establish sslpsk socket:', SSLError(1, u'[SSL: NO_SHARED_CIPHER] no shared cipher (_ssl.c:661)'))
new client on port 443 from <IP_ADDRESS>:54886
('could not establish sslpsk socket:', SSLError(1, u'[SSL: NO_SHARED_CIPHER] no shared cipher (_ssl.c:661)'))
new client on port 443 from <IP_ADDRESS>:54892
('could not establish sslpsk socket:', SSLError(1, u'[SSL: NO_SHARED_CIPHER] no shared cipher (_ssl.c:661)'))
new client on port 443 from <IP_ADDRESS>:54896
('could not establish sslpsk socket:', SSLError(1, u'[SSL: NO_SHARED_CIPHER] no shared cipher (_ssl.c:661)'))
new client on port 443 from <IP_ADDRESS>:54906
('could not establish sslpsk socket:', SSLError(1, u'[SSL: NO_SHARED_CIPHER] no shared cipher (_ssl.c:661)'))
new client on port 443 from <IP_ADDRESS>:54908
('could not establish sslpsk socket:', SSLError(1, u'[SSL: WRONG_VERSION_NUMBER] wrong version number (_ssl.c:661)'))
new client on port 443 from <IP_ADDRESS>:54910
('could not establish sslpsk socket:', SSLError(1, u'[SSL: NO_SHARED_CIPHER] no shared cipher (_ssl.c:661)'))
new client on port 443 from <IP_ADDRESS>:54914
('could not establish sslpsk socket:', SSLError(1, u'[SSL: NO_SHARED_CIPHER] no shared cipher (_ssl.c:661)'))
new client on port 443 from <IP_ADDRESS>:54916
('could not establish sslpsk socket:', SSLError(1, u'[SSL: NO_SHARED_CIPHER] no shared cipher (_ssl.c:661)'))
new client on port 443 from <IP_ADDRESS>:54922

the above error keeps continuing...
Can anyone please help me?
Thanks.

Duplicate of #362. You tried to flash the latest Tasmota which is not within the limit (512kb). Unfortunately the only recovery option may be flashing over serial.

@kueblc man I tried to flash another sp23 smart socket and same thing has happened.
I installed the Sonoff-Tasmota v6.5.0  from your repository and after flashing I do not see the sonoff-XXX AP at all.
The sp23 stays on forever cannot do anything to it. It is really frustrating that the thirdparty.bin file in your repository did not work!!!!!1

Unfortunately this is the inherent risk you take by flashing your devices, which is explicit in the README and also the first time you run start_flash.
Please be patient as we work to include additional safety checks to avoid situations like this in the future. I'd recommend waiting until our next release before trying it again, unless we can narrow down what happened in your case.
Do you wish you share your most recent web log and firmware backup so we can figure out what happened?

Hey @kueblc so I now got the koogeek wifi smart plugs which are tuya compatible.
I want to install tasmota in them before I break everything again. Can you please confirm that the tasmota file on your repo when I download it I can use it? It's just a standard basic tasmota bin file which I can upgrade later in the tasmota user interface?
And that the size of this tasmota bin in your repo is fine to flash on koogeek smart plugs?
Thanks I am holding fire until you tell me.

Yes @bachoo786 the included Tasmota has always been safe to use. Make sure to get the latest tuya-convert that includes the additional safety checks I mentioned before.

Ok so I will download the files from the github and try it mate. Thanks

Use the install instructions on the README using git, this way you can update simply by doing git pull.

ok I tried it and this is what I get after my socket is in pairing mode the light just stops blinking and it turns off.
Starting smart config pairing procedure
Waiting for the device to install the intermediate firmware
Put device in EZ config mode (blinking fast)
Sending SSID                  vtrust-flash
Sending wifiPassword
Sending token                 00000000
Sending secret                0101
................
SmartConfig complete.
Resending SmartConfig Packets
...../start_flash.sh: line 106:  1687 Terminated              ./smartconfig/main.py
...........................................................................................................
Device did not appear with the intermediate firmware
Check the *.log files in the scripts folder
Do you want to try flashing another device? [y/N]

@kueblc all sorted now working fine thanks alot for your help mate.

Same applies to me... what did you do to make it work?

I was using raspbian stretch on my raspberry pi and once I installed raspbian buster as well as used koogeek smart plugs instead of teckin it worked fine


Jira Table Links

Hey, I just made a Pull Request!
Context
Implementation for links within the Jira Table.

The JiraDataResponse was updated to add the jql query where appropriate.
Issue ticket number and link

Fixes #177

Checklist before requesting a review

[x] I have performed a self-review of my own code
[x] I have verified that the code builds perfectly fine on my local system
[x] I have verified that my code follows the style already available in the repository
[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)

Nice work! I've added a few comments.

Nice work! I've added a few comments.

@fridajac There seems to be no comments visible :)


fix(cypress): remove parallel runs

This PR temporarily removes the parallel runs. I have explained the details to Oliver, and we will be able to re-enable this soon.

@raisedadead So #42138 is almost ready to go, running it unparalleled would not be a good idea.  Can we reenable parallelization?

@ojeytonwilliams could you please guide Sem based on what we had discussed in the past.

Sure. From what I remember the key problem was that the actions both ran too often (because of renovate) and ran too long (because each parallel run builds the client).    With that in mind, I think a reasonable strategy is to only run these specific tests on pushes to main and not have too many containers.  @Sembauke is it enough to have 3 containers, in your experience?
That might still be too much, but I think it's worth trying.

@Sembauke is it enough to have 3 containers, in your experience?

Yes, 3 containers should do the trick, it would run 800+ challenges in about 20m.

What about instead of running all Cypress e2e tests for every pull request, create a pipeline that will be triggered once a day? That would make everything faster.

What about instead of running all Cypress e2e tests for every pull request, create a pipeline that will be triggered once a day? That would make everything faster.

As a rule, we want to be able to deploy main at any point and that means we want all the tests to have run on it.  We could fallback to scheduled runs, but I think that's a last resort.


inv staging deploy

It would be nice to get inv staging deploy to be the only command that a dev needs to memorize to do a deploy (similar to how we used to just do fab staging deploy.
Currently inv staging deploy does this:
$ inv staging deploy
cd deploy/ && ansible-galaxy install -f -r 'requirements.yaml' -p roles/
- changing role caktus.django-k8s from v0.0.5 to v0.0.5
- extracting caktus.django-k8s to /home/vkurup/dev/caktus-website/deploy/roles/caktus.django-k8s
- caktus.django-k8s (v0.0.5) was installed successfully
Traceback (most recent call last):
  File "/home/vkurup/.pyenv/versions/3.7.6/envs/caktus-website/lib/python3.7/site-packages/invoke/config.py", line 111, in __getattr__
    return self._get(key)
  File "/home/vkurup/.pyenv/versions/3.7.6/envs/caktus-website/lib/python3.7/site-packages/invoke/config.py", line 176, in _get
    value = self._config[key]
KeyError: 'tag'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/vkurup/.pyenv/versions/3.7.6/envs/caktus-website/bin/inv", line 8, in <module>
    sys.exit(program.run())
  File "/home/vkurup/.pyenv/versions/3.7.6/envs/caktus-website/lib/python3.7/site-packages/invoke/program.py", line 384, in run
    self.execute()
  File "/home/vkurup/.pyenv/versions/3.7.6/envs/caktus-website/lib/python3.7/site-packages/invoke/program.py", line 566, in execute
    executor.execute(*self.tasks)
  File "/home/vkurup/.pyenv/versions/3.7.6/envs/caktus-website/lib/python3.7/site-packages/invoke/executor.py", line 129, in execute
    result = call.task(*args, **call.kwargs)
  File "/home/vkurup/.pyenv/versions/3.7.6/envs/caktus-website/lib/python3.7/site-packages/invoke/tasks.py", line 127, in __call__
    result = self.body(*args, **kwargs)
  File "/home/vkurup/.pyenv/versions/3.7.6/envs/caktus-website/lib/python3.7/site-packages/kubesae/ansible/deploy.py", line 30, in ansible_deploy
    tag = c.config.tag
  File "/home/vkurup/.pyenv/versions/3.7.6/envs/caktus-website/lib/python3.7/site-packages/invoke/config.py", line 123, in __getattr__
    raise AttributeError(err)
AttributeError: No attribute or config key found for 'tag'

Theoretically at least, we could catch that error in ansible/deploy.py line 30, and run the image task. Thoughts?

It would be nice to have something better than an AttributeError for this case.
It seems to me that implicitly running the image task may cause undesired behavior, though, for example if someone is trying to deploy to production and doesn't want to build a new image to deploy. Maybe something like catching the error and telling the user to supply a tag/build a new image is better? We could even try to give a command to get the most recent tags , like this for GCP repos:
print(
    "\nPlease specify a tag to use for the deploy. You can see the 10 most "
    "recent images and their tags with:\n    "
    f"gcloud container images list-tags {c.config.repository} --limit=10"
)

Hmm, I disagree with the second part of that. We've always done fab production deploy without forcing the user to specify which version of the code they want deployed. The most common thing to do should be the easiest thing to do. If, in your example, they really did make the mistake of wanting to deploy a specific tag, they would see that a docker build command was kicked off and would have plenty of time to Ctrl-C out if it. My hope here was to make things simpler for the user, rather than more complicated.

But I also like that command that you showed as an advanced option, in the case that you wanted to rollback a deployment quickly to a recently used tag. Maybe as a inv staging deploy:rollback? And if you didn't provide a tag to the rollback command, it would list recent tags for you to choose from? (My 2 cents, of course)

The rollback option sounds like it could be useful, and I agree that making things easier for the user is desirable. I do think we should put in something that would prevent people from accidentally deploying the wrong code, though (whether on the command line or in the config, etc.). I want to avoid the situation where being on the wrong git branch during a deploy or having uncommitted changes during a deploy means the wrong things get deployed.

Ahh, that is an excellent point! Then my suggestion would be:

If the user is on the correct branch for the environment (which we'd have to specify somewhere) and if the tree was not dirty (which we already have some code in place to check), then fab <env> deploy would run image automatically. This would make things simple for the most common scenario.
If either of those things is not in place (wrong branch, or dirty tree), then we abort with a more useful error message.

That sounds good to me.
🤝


🔒 Pass the whole signature length for the EIP1271 signature verification

Description
The EIP1271 signature standard provides an abstract interface for smart contracts signature verification.
According to the EIP description, it is a signature format agnostic:

isValidSignature can call arbitrary methods to validate a given signature, which could be context dependent (e.g. time based or state based), EOA dependent (e.g. signers authorization level within smart wallet), signature scheme Dependent (e.g. ECDSA, multisig, BLS), etc.

It means, that the correct implementation of EIP1271 may accept signatures with arbitrary lengths, not only 65 bytes long. The Authereum smart contracts could be an example of EIP1271 implementation that works with signature.length != 65.
Change the SignatureCheckerLib implementation to handle arbitrary length signatures.
Checklist
Ensure you completed all of the steps below before submitting your pull request:

[x] Ran forge snapshot?
[x] Ran npm run lint?
[x] Ran forge test?

Big thanks!


MM-24033: Compute suggestion list width

Summary
The SuggestionList inside the AddUserToChannelModel component had a fixed width that rendered smaller than the modal input box width. This PR computes the width of the SuggestionList as the parent div width minus two times the padding in the parent div.
This is very hacky, and that is why I have narrowed the change to a specific class inside the component. But we have plans to rework this modal in the near future, so we should get rid of this code hopefully sooner than later.
Ticket Link
https://mattermost.atlassian.net/browse/MM-24033
Screenshots

@agarciamontoro We face this issue in other modals as well, so instead of adding the class, we can just target all suggestion lists inside modals, and give them the css width: calc(100% - 30px);.

@asaadmahmood after double and triple checking, looks like just removing the width: 496px does fix the issue in the EditPost modal. But if we add the width: calc(100% - 30px) to all the suggestion lists in addition, it actually brings back the issue with the EditPost modal, as it is now 30px narrower than before.
What I still don't understand is why removing the fixed width works with the EditPost modal and not with the AddUserToChannel modal. I have checked the DOM in both cases and it looks exactly the same, but of course I must be missing something.
I would like to understand the root cause of this, but it looks like it will become a time sink really soon. This is what I have tested:

Change
AddUserToChannel fixed?
EditPost fixed?

Current PR (removing width: 496px from .suggestion-list__content and adding width: calc(100% - 30px) to .add-user-to-channel__suggestion-box .suggestion_list
Yes
Yes

Removing width: 496px from .suggestion-list__content
No
Yes

Replacing width: 496px in .suggestion-list__content with width: calc(100% - 30px)
Yes
No

Replacing width: 496px in .suggestion-list with width: calc(100% - 30px)
Yes
No

Given the table above and the assumption that we will rework these modals in the near future, hopefully getting rid of all these moving parts, I propose to merge this as is now to fix the current ticker. Thoughts, @asaadmahmood?

@agarciamontoro width: 496px is to have a reduced width in the center channel. And that's intentional, but I'll have a look at this PR, and submit a fix.
So keep this PR open, will submit a commit.

Thank you, @asaadmahmood!

@agarciamontoro Submitted my fix.

Your solution is definitely way better than mine. Thank you, @asaadmahmood!

Thank you @agarciamontoro
I'm seeing the channels with long name not truncated within the list. Is this out of scope of this PR?

Thank you for testing this, @jgilliam17. I did not check that the names were truncated within the list, this PR was only to fix the width issue. Should we open a new ticket for that one?

Thank you for testing this, @jgilliam17. I did not check that the names were truncated within the list, this PR was only to fix the width issue. Should we open a new ticket for that one?

I can add a new ticket for that 🙂

@amyblais, should we add this to v5.23?

Added to v5.24; not a regression

Thank you, @amyblais. Merging now!


Fix generating nested models

Tis PR fixes error when generating nested models such as:
bin/rails g scaffold admin/role name description
Closes #227

@dhh please review this when you get a moment!


RevEng: Test against new SQL Server sample database

https://github.com/Microsoft/sql-server-samples/releases/tag/wide-world-importers-v1.0

No problems with this database. A few messages about not supporting the geography data type but that is already tracked by #1100.


Lights are not turned off / on is working 2.8.0 (extended mode)

Describe the bug
After updating from 2.7.2 to 2.8.0 the lights can be switched on but aren't switched of when sending {on: "false} (extended mode). The node-red status changes to "off" in the node status but nothing happens. When sending boolean false the light is switched off (simple mode).
Expected behavior
When switching off the light should be turned off regardless of mode used.
Please complete the following information:

Node-RED version: [1.0.5]
NodeJS version: [v10.20.0]
Device running Node-RED: [Raspberry Pi 4B+ 4GB with RaspberryMatic and RedMatic]

Additional context
Maybe current RedMatic version is just not suitable for 2.8.0

Can you please try that again with this example? I tried to replicate your issue but for me it works as expected with 2.8.0?
[{"id":"dfe4b558.db7be","type":"tab","label":"Issue #179","disabled":false,"info":""},{"id":"8da2e546.81d3a8","type":"hue-light","z":"dfe4b558.db7be","name":"","lightid":"","colornamer":true,"skipevents":false,"x":380,"y":100,"wires":[[]]},{"id":"570e482e.a953d","type":"inject","z":"dfe4b558.db7be","name":"","topic":"","payload":"{\"on\":false}","payloadType":"json","repeat":"","crontab":"","once":false,"onceDelay":0.1,"x":200,"y":60,"wires":[["8da2e546.81d3a8"]]},{"id":"e2608d13.1a25e","type":"inject","z":"dfe4b558.db7be","name":"","topic":"","payload":"{\"on\":true}","payloadType":"json","repeat":"","crontab":"","once":false,"onceDelay":0.1,"x":200,"y":140,"wires":[["8da2e546.81d3a8"]]}]

Good morning,
thanks for your quick replay. I have tried and that seems to work - strange enough because I tried the same with a change node and an inject yesterday and could have be it did not work.
I noticed that the difference between your test and my real flow is a transition time in the off flow and that does not work. Please find the modified example attached (hope I copied correctly)
[{"id":"f1ece58.ddeee18","type":"tab","label":"Issue #179","disabled":false,"info":""},{"id":"b1f6331d.a5ff2","type":"hue-light","z":"f1ece58.ddeee18","name":"","lightid":"","colornamer":true,"skipevents":false,"x":400,"y":100,"wires":[[]]},{"id":"ed8f9ca6.e0edc","type":"inject","z":"f1ece58.ddeee18","name":"","topic":"","payload":"{\"on\":false,\"transitionTime\":5}","payloadType":"json","repeat":"","crontab":"","once":false,"onceDelay":0.1,"x":200,"y":60,"wires":[["b1f6331d.a5ff2"]]},{"id":"c04a9938.a5e668","type":"inject","z":"f1ece58.ddeee18","name":"","topic":"","payload":"{\"on\":true}","payloadType":"json","repeat":"","crontab":"","once":false,"onceDelay":0.1,"x":200,"y":140,"wires":[["b1f6331d.a5ff2"]]}]

Still the same result with 2.8.1 (in case this helps)

Hi, I am having exact same issue, can not turn off with transition. if you remove the transition works fine :( is there anyway to go back to the previous version?

Hi Raul, yes, you can uninstall the new version and install old version using console npm install node-red-contrib-huemagic@<version>. If using RedMatic you have to load environment values first - see here

Thanks for the quick reply @unclej84 , how do I Uninstall the current version? I cant remove it from the pallets as its in use in all my flows! :(

I used npm uninstall node-red-contrib-huemagic on the console to do it without touching Node-RED in between. I am not sure if you can uninstall via pallets when having in use.

Thanks man, that worked !!! lesson learnt, if something is working perfect, don't touch it! lol :)

Seeing the same. Version 2.7.2 works.

same for me. trying to downgrade; doesn't work with transitions.

It is not only transitionTime that is not working.
Any other value sent together with the "on": false message will prevent the lights from switching off.
I sent the "ignoreOffLights" and a "localContext" value as well
localContext is usually silently ignored.
the "on": false value is the only thing allowed in the message currently when switching off the lights.

It is not only transitionTime that is not working.
Any other value sent together with the "on": false message will prevent the lights from switching off.

Confirmed. Just faced the same problem with version 2.8.1

Guys just downgrade to 2.7.2 , it works with no issue.

The issue seems to be related to the "// SAVE FOR LATER MODE?"-Section. For groups or lights it is checked if they are not on and only if the commands are processed. That is not working for switching off the lights in extended mode.
For lights (2.8.1) in line 458:
if(!light.on||!light.reachable)
and for group (2.8.1) in line 433:
if(!group.on)
I tried to remove "!light.on" and it was working as expected.
As far as I understood the code for simple ON / OFF the save function gets called directly but extended is passing thru this section, in which "payload.on" gets deleted.
`
// SAVE FOR LATER MODE?
if(!group.on)
{
futureState = msg;
					// IGNORE ON/OFF & TOGGLE
					if(typeof futureState.payload != 'undefined')
					{
						delete futureState.payload.on;
						delete futureState.payload.toggle;
					}

					// ANY OTHER COMMANDS?
					if(typeof futureState.payload != 'undefined' && Object.keys(futureState.payload).length > 0)
					{
						return group;
					}
				}

				return bridge.client.groups.save(group);`

Can someone confirm this? Why is the code even checking if the light shall be on? Checking reachable should be enought, shouldn't it? But I am not sure about groups because there is no "reachable".

I've also got this. Now all my home lights are turned on :D. After downgrade to 2.7.2 it works fine. This kind of bug should be repaired asap. It's one of the the main features.

Sorry!  I've tested it with the latest version (v2.8.2) and it seems to be fixed now. Maybe it makes sense to create a full featured example flow for every available node and action to rule out such errors in the future… :S

All groups / lights node is still affected by this bug in version 2.8.2
In addition this node shows "some lights on" even when all are off or on.

This cause wrong statuses in my home automation hub software, and I can't switch lights because the logic is based on current status.

Issue still around with 3.0.0. I am sending
{
on: false
brightness: 34
hex: "36a6ff"
}

but the light always returns
{
on: true
brightness: 34
brightnessLevel: 86
reachable: true
rgb: array[3]
hex: "37adff"
colorTemp: 153
updated: "2020-11-26T23:18:52+00:00"
}

It is not possible to turn it on/off in extended mode.


(Dragon Age) Stat block char sheet is not displaying the mana points

It will display power points in the block sheet in the next revision.


Downgrade version Roslyn dependency

Use the oldest version possible to prevent issues with other Roslyn tooling.

Thanks. We've run into trouble with the dotnet projectfile analyzer when used in a .net 6.0 Razor webproject when Razor RuntimeCompilation is used during development. We got this exception during startup
System.TypeLoadException: Declaration referenced in a method implementation cannot be a final method.  Type: 'Microsoft.CodeAnalysis.CSharp.CSharpCompilationOptions'.  Assembly: 'Microsoft.CodeAnalysis.CSharp, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35'.
   at Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation.CSharpCompiler.EnsureOptions()
   at Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation.CSharpCompiler.get_ParseOptions()

I hope this works.

If this did not do the trick, this PR might do: https://github.com/dotnet-project-file-analyzers/dotnet-project-file-analyzers/pull/87 (it is not shipped yet)


help me please

I have got the same problem,but i don't know how to deal it, can you give me your any contact, and help me??please!

@kuiba0324 this repository isn't maintained anymore and does only support Swift 3.1. Instead use my fork vknabel/vscode-swift-development-environment which supports Swift 4.x.
Also ensure you uninstall jinmingjian.sde and install vknabel.vscode-swift-development-environment (called "Maintained Swift Development Environment") instead.
I hope this already solves your problems. If it doesn't, please open an issue here.

发送自 Windows 10 版邮件https://go.microsoft.com/fwlink/?LinkId=550986应用

发件人: Valentin Knabel<EMAIL_ADDRESS>发送时间: Friday, January 4, 2019 4:00:25 PM
收件人: jinmingjian/sde
抄送: kuiba0324; Mention
主题: Re: [jinmingjian/sde] help me please (#45)
@kuiba0324https://github.com/kuiba0324 this repository isn't maintained anymore and does only support Swift 3.1. Instead use my fork vknabel/vscode-swift-development-environmenthttps://github.com/vknabel/vscode-swift-development-environment which supports Swift 4.x.
Also ensure you uninstall jinmingjian.sdehttps://marketplace.visualstudio.com/items?itemName=jinmingjian.sde and install vknabel.vscode-swift-development-environmenthttps://marketplace.visualstudio.com/items?itemName=vknabel.vscode-swift-development-environment (called "Maintained Swift Development Environment") instead.
I hope this already solves your problems. If it doesn't, please open an issue herehttps://github.com/vknabel/vscode-swift-development-environment/issues.
―
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/jinmingjian/sde/issues/45#issuecomment-451376860, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AsDSIp6mWdAOrnetwVk9YMZMi1UrUuA8ks5u_woZgaJpZM4ZitWJ.

Thanks for your answer

Reall？!that would be grate!! Thank you very mush!!^_^
发送自 Windows 10 版邮件https://go.microsoft.com/fwlink/?LinkId=550986应用

发件人: Valentin Knabel<EMAIL_ADDRESS>发送时间: Friday, January 4, 2019 4:23:12 PM
收件人: jinmingjian/sde
抄送: kuiba0324; Mention
主题: Re: [jinmingjian/sde] help me please (#45)
Currently Windows is not supported, but if you wish I can give it a try. Though it may take a while.
According to #36https://github.com/jinmingjian/sde/pull/36 the problem on Windows seems to be related to the different path schema (/ vs \ etc)
―
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/jinmingjian/sde/issues/45#issuecomment-451381721, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AsDSIsXtfIUBv_F0ZJVEq7PXGPdlaSl3ks5u_w9wgaJpZM4ZitWJ.


Add version support and update to redhat-4

Don't forget it needs to be changed in the community version of the booster too.

Changing version labels and resubmitting PR


Report "SUCCESS" when network resources do not have a result

Hey,
it's not an issue but rather a question:
How would you report Result.Success(...) when you actually do not have a result object. This situation can happen if you just cancel a process or delete something. Any ideas? Is there a way and I didn't saw it?
Thanks in advance.

You can use a Result<(), Error> if you want to report success but don't have an actual value to pass.

Thanks 👍


Add jonas-zipprick to CODEOWNERS of the equinix-metal provider extension

How to categorize this PR?

/area TODO
/kind TODO
/platform equinix-metal
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you @jonas-zipprick for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.


Create folder structure appropriate for testing

Troels: Can you make a folder structure which is appropriate for testing? I would like to run unit tests on various function in the different modules located in src/ but when I create test modules in T/, I cannot get those modules to import the modules found in src/

On a clear install of this program using stack, I wrote a test module in T/RegAllocTest.hs and executed ghci T/RegAllocTest.hs from both the root folder and from the T/ folder. This resulted in the following error message:
`GHCi, version 7.10.3: http://www.haskell.org/ghc/  :? for help
T/RegAllocTest.hs:3:8:
Could not find module ‘MipsRegAlloc’
Use -v to see a list of the files searched for.
T/RegAllocTest.hs:4:8:
Could not find module ‘Mips’
Use -v to see a list of the files searched for.
Failed, modules loaded: none.
`

I was able to fix the importation of modules located in src/ to files located in T/. This was fixed by adding a .ghci file in the root folder containing the text
:set -isrc

Is this the correct way to handle this or should stack somehow be used?

The right way is to use Cabal's support for test suites.  I'll create a skeleton.
(I'll also do something more interesting soon.)


Check double bounds while parsing

Codecov Report

Merging #294 (b4eb15b) into main (1bb0361) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #294   +/-   ##
=======================================
  Coverage   58.22%   58.22%
=======================================
  Files          30       30
  Lines         936      936
  Branches       62       62
=======================================
  Hits          545      545
  Misses        391      391

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bb0361...b4eb15b. Read the comment docs.


Build issue with Expo

So I have followed the setup instructions in the docs. Including steps in XCode. Container is set up iCloudContainerEnvironment: Development is in the info.plist. The build gets to the end of Fastlane and throws the following error:
Error Domain=IDEFoundationErrorDomain Code=1 "exportOptionsPlist error for key "iCloudContainerEnvironment": expected one of {Development, Production}, but no value was provided" UserInfo={NSLocalizedDescription=exportOptionsPlist error for key "iCloudContainerEnvironment": expected one of {Development, Production}, but no value was provided}
Any ideas on how to fix this error?

I haven't tried buidling expo with fastlane, but I will try it when available.
Didi you tried manually add this to xx.entitlement:
<key>com.apple.developer.icloud-container-environment</key>
<string>Production</string>

and then run build ?

It worked build was successful! Just add this key-value pair to your [appname]. entitlements file located in 'ios/appname/' folder

Thanks for your feedback,  I will fix this soon 😄

发件人: psquizzle @.>
发送时间: Monday, November 28, 2022 11:24:24 PM
收件人: XHMM/react-native-cloud-store @.>
抄送: xiao xin @.>; Comment @.>
主题: Re: [XHMM/react-native-cloud-store] Build issue with Expo (Issue #7)
It worked build was successful! Just add this key-value pair to your [appname]. entitlements file located in 'ios/appname/' folder
—
Reply to this email directly, view it on GitHubhttps://github.com/XHMM/react-native-cloud-store/issues/7#issuecomment-1329291370, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AF5DMWUUM7SC7KYLTPP4IDTWKTFCRANCNFSM6AAAAAASMSDCLE.
You are receiving this because you commented.Message ID: @.***>