fix default syslog port (should be 514)

This was broken by https://github.com/mongodb-labs/mongo-connector/commit/6b8a6649e9008397ef2eb4fe1183541b90e2de5b.

Good catch. Merged.


Add code highlighting to the README

thanks, that's better indeed, I left 2 small comments, can you resolve them?

Thanks


Could this tool check for errors likes "Multiple keywords with name XXX found" ?

I had a test suite failing due to this error:
FAIL | Multiple keywords with name 'Read Json File' found. Give the full name of the keyword you want to use:
     module1.Read Json File
     module2.Read Json File

Screenshot from HTML report:

Python source code of module1.py:
import json

def read_json_file(filepath):
    with open(filepath, encoding='utf8') as file:
        return json.load(file)

...

Python source code of module2.py:
from module1 import read_json_file
...

Usage in feature.resource:
Library    ../libraries/module1.py
Library    ../libraries/module2.py
...
${body}=    Read Json File    ${CURDIR}/postPayload.json

Could robotframework-sherlock be able to detect the error raised at runtime by Robot Framework?
Note: I previously asked for the same feature to be added to https://github.com/MarketSquare/robotframework-robocop/issues/687 who mentioned this interesting project

Sorry for the (very) late answer - I'm just trying to revive Sherlock project. It's quite interesting problem I can try to analyse, but it should be totally possible to be handled by Sherlock.


(Android/Samsung) Face/Touch id doesn't work f the application is added to the Samsung Secure Folder

Add Yoroi App to the Secure folder
Start the app and click "login"
Try to unblock it via fingerprint

Actual result:
"Unknown error" message is displayed.
When you use Face Id as "Fallback" it's just returning you to "Authorize with your Fingerprint" screen and everything repeats. The only way to unlock the app is to use a password as a fallback instead of Face ID.

Link to thread with more details (and vids):
https://emurgo.slack.com/archives/GC9AM0E8K/p1550748963007600

Moved to Clubhouse
https://app.clubhouse.io/emurgo/story/1766/android-samsung-face-touch-id-doesn-t-work-f-the-application-is-added-to-the-samsung-secure-folder


Sample json of the ControlEvent

Hi,
Can someone provide the sample ControlEvent json that can be push to like Kafka topic please?
I'm not able to make sense the MetadataControlEvent.builder.
Thanks,
Calvin

I'm getting exception with below sample control event json:
{"addedExecutionPlanMap": {"id14": "from inputStream [ticker == "AAPL"] insert into outputStream"}}
Deserialized thru ControlEventSchema
ERROR:
org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.JsonMappingException: No suitable constructor found for type [simple type, class org.apache.flink.streaming.siddhi.control.ControlMessage]: can not instantiate from JSON object (missing default constructor or creator, or perhaps need to add/enable type information?

@haoch
I'm getting exception with below sample control event json:
{"addedExecutionPlanMap": {"id14": "from inputStream [ticker == "AAPL"] insert into outputStream"}}
Deserialized thru ControlEventSchema
ERROR:
org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.JsonMappingException: No suitable constructor found for type [simple type, class org.apache.flink.streaming.siddhi.control.ControlMessage]: can not instantiate from JSON object (missing default constructor or creator, or perhaps need to add/enable type information?

Any breakthrough on this ... I am also not clear on the control stream input message ...


Calculations for new state start at non-zero values

I created a test state under Javacript adapter and made sure it's value was set to zero. Then turned on sourceanalytix calculations for that state.
Then created this script and ran one time...
const state = 'sourceanalytixTest.watts';

// 1500w for 30s is 0.0125kWh
log(`Turning on: ${state}`, 'info');
setState(state, 1500, true);
setTimeout(() => {
    log(`Turning off: ${state}`, 'info');
    setState(state, 0, true);
}, 30000);

... which logged this output, showing the test power state was indeed at 1500W for precisely 30 seconds...
14:37:31.820 | info | javascript.0 (23098) Start javascript script.js.Tests.sourceanalytixTest
14:37:31.978 | info | javascript.0 (23098) script.js.Tests.sourceanalytixTest: Turning on: sourceanalytixTest.watts
14:38:01.981 | info | javascript.0 (23098) script.js.Tests.sourceanalytixTest: Turning off: sourceanalytixTest.watts

... yet this lead to these results:

As you can see, instead of recording energy usage of 0.0125kWh, the value is that (rounded) plus 1.5kWh. Clearly an error.
I find it suspicious that 1.5kWh was added for a power input of 1.5kW for 30 seconds.
FWIW, I ran the script above a further 2 times. The energy calculation should be 0.0375kWh after that. Even account for the 1.5kWh initialisation discrepancy it should be 1.5375 but in fact the value shown by sourceanalytix was 1.541. Clearly still needs work :(

Having a quick look at the code, it's probably to do with this line...
https://github.com/iobroker-community-adapters/ioBroker.sourceanalytix/blob/master/main.js#L1243
... which is reached when no prior timestamp or value are known. In this case it's illogical to return anything but a zero value.
I notice this bug was introduced in https://github.com/iobroker-community-adapters/ioBroker.sourceanalytix/commit/4a9a63e39f507fb17c69bcb89ff69dcfb2154bd2. Prior to that it would have worked as I expect. What was this commit supposed to achieve?

Having a quick look at the code, it's probably to do with this line...

I think that's also what is causing the calculated value to be too large also. Check out this debug log:
2020-12-01 17:56:41.020  - info: javascript.0 (23098) Start javascript script.js.Tests.sourceanalytixTest_js
2020-12-01 17:56:41.108  - info: javascript.0 (23098) script.js.Tests.sourceanalytixTest_js: Turning on: sourceanalytixTest.watts
2020-12-01 17:56:41.110  - info: javascript.0 (23098) script.js.Tests.sourceanalytixTest_js: registered 0 subscriptions and 0 schedules
2020-12-01 17:56:41.130  - debug: sourceanalytix.0 (25190) state javascript.0.sourceanalytixTest.watts changed : {"val":1500,"ack":true,"ts":1606841801112,"q":0,"from":"system.adapter.javascript.0","user":"system.user.admin","lc":1606841801112} SourceAnalytix calculation executed
2020-12-01 17:56:41.132  - debug: sourceanalytix.0 (25190) Calculation for javascript.0.sourceanalytixTest.watts with values : {"val":1500,"ack":true,"ts":1606841801112,"q":0,"from":"system.adapter.javascript.0","user":"system.user.admin","lc":1606841801112} and configuration : {"stateDetails":{"alias":"","consumption":false,"costs":false,"deviceName":"javascript__0__sourceanalytixTest__watts","financialCategory":"costs","headCategory":"consumed","meter_values":false,"name":"watts","stateType":"Electricity","stateUnit":"W","useUnit":"kWh"},"calcValues":{"currentValue":1.5495480000000001,"start_day":0,"start_month":0,"start_quarter":0,"start_week":0,"start_year":0,"valueAtDeviceReset":0,"previousReadingWatt":0,"previousReadingWattTs":1606838541681},"prices":{"basicPrice":"0","unitPrice":"0.14184"}}
2020-12-01 17:56:41.134  - debug: sourceanalytix.0 (25190) Watt to kWh for javascript.0.sourceanalytixTest.watts current reading : 1500 previousReading : {"stateDetails":{"alias":"","consumption":false,"costs":false,"deviceName":"javascript__0__sourceanalytixTest__watts","financialCategory":"costs","headCategory":"consumed","meter_values":false,"name":"watts","stateType":"Electricity","stateUnit":"W","useUnit":"kWh"},"calcValues":{"currentValue":1.5495480000000001,"start_day":0,"start_month":0,"start_quarter":0,"start_week":0,"start_year":0,"valueAtDeviceReset":0,"previousReadingWatt":0,"previousReadingWattTs":1606838541681},"prices":{"basicPrice":"0","unitPrice":"0.14184"}}
2020-12-01 17:56:41.135  - debug: sourceanalytix.0 (25190) Watt to kWh outcome for javascript.0.sourceanalytixTest.watts : {"currentValue":1.5495480000000001,"start_day":0,"start_month":0,"start_quarter":0,"start_week":0,"start_year":0,"valueAtDeviceReset":0,"previousReadingWatt":1500,"previousReadingWattTs":1606841801112}
2020-12-01 17:56:41.136  - debug: sourceanalytix.0 (25190) Recalculated value 1.5510975480000002
2020-12-01 17:56:41.137  - debug: sourceanalytix.0 (25190) New reading 1.5510975480000002 bigger than stored value 1.5495480000000001 processing normally
2020-12-01 17:56:41.137  - debug: sourceanalytix.0 (25190) Set calculated value 1.5510975480000002 on state : javascript__0__sourceanalytixTest__watts.Current_Reading}
2020-12-01 17:56:41.138  - debug: sourceanalytix.0 (25190) ActiveStatesArray {"currentValue":1.5510975480000002,"start_day":0,"start_month":0,"start_quarter":0,"start_week":0,"start_year":0,"valueAtDeviceReset":0,"previousReadingWatt":1500,"previousReadingWattTs":1606841801112})
2020-12-01 17:56:41.139  - debug: sourceanalytix.0 (25190) roundDigits with 1.5510975480000002 rounded 1.551

Note my test script starts and changes it's power state from 0W to 1500W. This should have no effect on the kWh calculation as it doesn't matter how long it has been since that zero value was set... zero multiplied by anything is still zero. However, you note that method in fact returns a non-zero value which is added to the meter reading which increments (1.5495480000000001 -> 1.5510975480000002).
Again, this due to https://github.com/iobroker-community-adapters/ioBroker.sourceanalytix/commit/4a9a63e39f507fb17c69bcb89ff69dcfb2154bd2.

Solved in 0.4.8-Beta.0 which will be released this weekend, alpha 0.4.8-Alpha.13 is already available for install and has all fixes included.
Please do not install any version of 0.4.8 lower than alpha 13 ! (Or wait for beta release on Sunday 15-01-2021)
thanks for your help !

Solved in 0.4.8-Beta.0 which will be released this weekend, alpha 0.4.8-Alpha.13 is already available for install and has all fixes included.
Please do not install any version of 0.4.8 lower than alpha 13 ! (Or wait for beta release on Sunday 15-01-2021)
thanks for your help !


Euler's totient function #445

Have you read the [Contributing Guidelines on Pull Requests]
Yes
Description
I have created Euler's_Totient_Function.cpp file in c++ folder and I have updated readme file.
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
#445
(Write your answer here.)

@atarax665 Sir, I have updated the file. Now it is properly indented plus the function F(n) calculates the no. of coprimes between 1 and n (inclusive of 1 and n).

@kushagraiitbbs Please do the following modifications

for user friendly interface, please display some message regarding the topic.

@siddharth25pandey I have added message of Euler's Totient Function at the beginning of code.

@atarax665 @siddharth25pandey @VijayaGB98 I am a HAKINCODE PARTICIPANT (adding it for more clearity)

@all-contributors please add @kushagraiitbbs for code


Cannot read property 'debug' of undefined in Production code

when i run production code
browser shows me
Uncaught TypeError: Cannot read property 'debug' of undefined
   at Function.set (main.f367047a957d9be7d097.js:1)
   at new e (main.f367047a957d9be7d097.js:1)
   at main.f367047a957d9be7d097.js:1
   at Jh (main.f367047a957d9be7d097.js:1)
   at main.f367047a957d9be7d097.js:1
   at new e (main.f367047a957d9be7d097.js:1)
   at Object.Cf [as createNgModuleRef] (main.f367047a957d9be7d097.js:1)
   at t.create (main.f367047a957d9be7d097.js:1)
   at main.f367047a957d9be7d097.js:1
   at n.invoke (polyfills.c6871e56cb80756a5498.js:1)

package.json
{
"dependencies": {
    "@angular/animations": "angular/animations-builds",
    "@angular/cdk": "angular/cdk-builds",
    "@angular/common": "~7.0.0",
    "@angular/compiler": "~7.0.0",
    "@angular/core": "~7.0.0",
    "@angular/forms": "~7.0.0",
    "@angular/http": "~7.0.0",
    "@angular/material": "angular/material2-builds",
    "@angular/platform-browser": "~7.0.0",
    "@angular/platform-browser-dynamic": "~7.0.0",
    "@angular/router": "~7.0.0",
    "@ngrx/effects": "^7.0.0",
    "@ngrx/router-store": "^7.0.0",
    "@ngrx/store": "^7.0.0",
    "@ngrx/store-devtools": "^7.0.0",
    "ag-grid-angular": "^19.1.2",
    "ag-grid-community": "^19.1.4",
    "angular-tree-component": "^8.4.0",
    "core-js": "^2.5.4",
    "hammerjs": "^2.0.8",
    "lodash": "^4.17.11",
    "moment": "^2.24.0",
    "ng2-search-filter": "^0.4.7",
    "ngx-filter-pipe": "^2.1.2",
    "oidc-client": "^1.6.0",
    "rxjs": "~6.3.3",
    "sweetalert": "^2.1.2",
    "zone.js": "~0.8.26"
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "~0.10.0",
    "@angular/cli": "~7.0.3",
    "@angular/compiler-cli": "~7.0.0",
    "@angular/language-service": "~7.0.0",
    "@types/jasmine": "~2.8.8",
    "@types/jasminewd2": "~2.0.3",
    "@types/lodash": "^4.14.130",
    "@types/node": "~8.9.4",
    "browser-sync": "^2.26.3",
    "codelyzer": "~4.5.0",
    "jasmine-core": "~2.99.1",
    "jasmine-spec-reporter": "~4.2.1",
    "karma": "~3.0.0",
    "karma-chrome-launcher": "~2.2.0",
    "karma-coverage-istanbul-reporter": "~2.0.1",
    "karma-jasmine": "~1.1.2",
    "karma-jasmine-html-reporter": "^0.2.2",
    "protractor": "~5.4.0",
    "ts-node": "~7.0.0",
    "tslint": "~5.11.0",
    "typescript": "~3.1.1"
  }

I think you're having some weird errors and can't debug it, and so, understandably, you're frustrated. But this is a tracker for bugs and feature requests. If we can we also try to help with support requests. We're very lucky to have awesome community members that also spend time trying to help people here in the issue tracker.
But we can't really help much at all if you don't fill in the issue template. I read your issue and have no idea what's going wrong and how to help you. And when other users search the issue tracker and see your issue, it also doesn't help them.
So I think the best thing to do is to close this issue, and ask you to open a new one. In that new one please fill in the issue template and give us an idea of what's happening and how to reproduce it. That way we'll have a chance to help you.

@s20sujith I am getting this error from time to time in both production and development modes. Did you manage to find the reason? Thank you

The Angular frontend seems to stuck during state transfer process from Angular Universal. The browser version of application does not initiate and the ssr page is shown. Stack trace:
 Uncaught TypeError: Cannot read property 'debug' of undefined     at HTMLDocument.<anonymous> (80-init.js:429)     at t.invokeTask (polyfills.8c23c0915d0cd55b66f9.js:formatted:4130)     at n.runTask (polyfills.8c23c0915d0cd55b66f9.js:formatted:3959)     at n.invokeTask [as invoke] (polyfills.8c23c0915d0cd55b66f9.js:formatted:4190)     at b (polyfills.8c23c0915d0cd55b66f9.js:formatted:5010)     at HTMLDocument.m (polyfills.8c23c0915d0cd55b66f9.js:formatted:5024)
Probably, some problems with zone.


Update versions and CHANGELOG.md

The target branch should be "master"

Sure, will create new one


Add "Create Another Listing" button

When a store is finished adding one listing, it brings them to the page viewing that listing. If they want to add another listing, it's not clear how to do that. They would need to click the Store tab again, which isn't intuitive because it's already selected:

I suggest that we add a button just to the left of the "Edit" button that says "Create Another Listing" or something to that effect, so that it would be easier to continue adding listings in a row.

Agreed. For consistency, the button should read '+ New Listing' - same as the store page.

Fixed.


Tidy data logging state.

Closes https://github.com/microbit-foundation/micropython-microbit-v2-simulator/issues/52

Maybe hold off on merging until #51 is in as I'd rather fix any conflict that way around.


Question: Why do validation errors raise InvalidMediaTypeValue?

I have noticed that, when sending an incorrect request (e.g. an object with a string where a number is expected), MediaType.cast and MediaType.unmarshal will raise InvalidMediaTypeValue in all cases, which is actually misleading: the media type is correct (e.g. application/json), but the validation raises an incorrect error. Was that on purpose?

Hi @berislavlopac
media type itself is correct but passed value (schema) is incorrect, isn't it? I called the general exceptions for media type value errors as InvalidMediaTypeValue but if you think it's misleading I'm open for naming suggestions.

I can't use from because it's not supported in Python 2 that's why CastError  is wrapped inside a media type exception. The plan is to move cast outside of schema models and get rid of media type and parameters exception wrapping.


Improve docs and checks for sink when using ASGI

Currently there is no documentation or checks in add_sink that require an async function when using the asgi app.
This is a follow up of https://github.com/falconry/falcon/pull/1769#discussion_r531449969
cc @vytas7

Not checking sinks and static routes for "asyncness" sounds like a release blocker tbh.
@kgriffs thoughts?

static routes are managed, since we use a different class in the async app (that just wraps the sync one, but it's managed)
https://github.com/falconry/falcon/blob/2f1109a476420e0c74e551b53028085c4c2fc5f2/falcon/routing/static.py#L131-L138
In the sink instead it's missing, unless I'm forgetting something
https://github.com/falconry/falcon/blob/2f1109a476420e0c74e551b53028085c4c2fc5f2/falcon/app.py#L612-L619
I'll change the milestone to 3.0. I don't think it's required for the alpha/beta, but I agree that's best if it's done for the stable

Thinking it's actually required for b1 because we want to be feature complete by then. But it is still the same Version 3.0 milestone.


Inconsistent between C and Rust implementations

Hello,
Sorry if I'm doing something wrong but I have some inconsistent. And if I was indeed doing wrong, I'm wondering why it would not give an error...
Let's say Bob and Alice uses Kyber in Rust and C respectively because they are purist.
Bob uses this code after the first part of Alice one (it was for convenient) :
/* Deterministic randombytes by Daniel J. Bernstein */
/* taken from SUPERCOP (https://bench.cr.yp.to)     */

#include <stddef.h>
#include <stdint.h>
#include <stdio.h>
#include <stdlib.h>
#include "kem.h"
#include <fcntl.h>
#include <sys/stat.h>
#include "randombytes.h"
#include <string.h>
#include <errno.h>
static uint8_t* datafromhex(char *string)
{
  //From https://stackoverflow.com/a/35452093
  //Needs the char* and returns an already allocated array
  if (string == NULL)
    return NULL;
  size_t slength = strlen(string);
  if ((slength % 2) != 0) // must be even
    return NULL;

  size_t dlength = slength / 2;

  uint8_t *data = malloc(dlength);
  memset(data, 0, dlength);

  size_t index = 0;
  while (index < slength)
  {
    char c = string[index];
    int value = 0;
    if (c >= '0' && c <= '9')
      value = (c - '0');
    else if (c >= 'A' && c <= 'F')
      value = (10 + (c - 'A'));
    else if (c >= 'a' && c <= 'f')
      value = (10 + (c - 'a'));
    else
    {
      free(data);
      return NULL;
    }

    data[(index / 2)] += value << (((index + 1) % 2) * 4);

    index++;
  }

  return data;
}

int main(void)
{
  unsigned int j;
  uint8_t pk[CRYPTO_PUBLICKEYBYTES]={0};
  uint8_t sk[CRYPTO_SECRETKEYBYTES]={0};
  char pkhex[CRYPTO_PUBLICKEYBYTES*2+1]={0};
  char skhex[CRYPTO_SECRETKEYBYTES*2+1]={0};
  FILE *file;
  FILE *skey;
  FILE *pkey;
  mode_t umode;
  uint8_t ct[CRYPTO_CIPHERTEXTBYTES];
  uint8_t key_a[CRYPTO_BYTES];
  uint8_t key_b[CRYPTO_BYTES];
  pkey = fopen("bobpublickey.pem", "r");
  if (fread(pkhex, sizeof(pkhex[0]), CRYPTO_PUBLICKEYBYTES*2, pkey) != CRYPTO_PUBLICKEYBYTES*2)
  {
    fprintf(stderr, "Cannot extract public key.\n");
    exit(EXIT_FAILURE);
  }
  uint8_t *result;
  printf("Pkhex is %s\n",pkhex);
  result=datafromhex(pkhex);
  if (result==NULL) {
    fprintf(stderr, "Cannot extract public key.\n");
    exit(EXIT_FAILURE);
  }
  *pk=*result;
  free(result);
  fclose(pkey);
    skey = fopen("bobsecretkey.pem", "r");
//  if (fread(skhex, sizeof(skhex[0]), CRYPTO_SECRETKEYBYTES*2, skey) != CRYPTO_SECRETKEYBYTES*2)
  if (fread(skhex, sizeof(skhex[0]), 6336, skey) != 6336)
  {
    fprintf(stderr, "Cannot extract secret key\n");
    exit(EXIT_FAILURE);
  }
  printf("SKhex is : %s\n",skhex);
  result=datafromhex(skhex);
  if (result==NULL) {
    fprintf(stderr, "Cannot decode secret key.\n");
    exit(EXIT_FAILURE);
  }
  *sk=*result;
  free(result);
  fclose(skey);
    // Encapsulation
  crypto_kem_enc(ct, key_b, pk);
  crypto_kem_dec(key_a, ct, sk);
  file = fopen("sharedsecret.pem", "w");
  if (file == NULL)
  {
    fprintf(stderr, "Cannot create file for shared secret.\n");
    exit(EXIT_FAILURE);
  }
  for (j = 0; j < CRYPTO_BYTES; j++)
    fprintf(file, "%02x", key_a[j]);
  fclose(file);
  file = fopen("cipher.pem", "w");
  if (file == NULL)
  {
    fprintf(stderr, "Cannot create file for shared secret.\n");
    exit(EXIT_FAILURE);
  }
  for (j = 0; j < CRYPTO_CIPHERTEXTBYTES; j++)
    fprintf(file,"%02x", ct[j]);
  fclose(file);
  return 0;
}

Bob shares its key to Alice (just to test, we don't do that in real life) so she can try her Rust code :
use hex::{self, FromHexError, decode};
use pqc_kyber::*;
use rand;
use std::fs::{self, File};
use std::io::{Error, Write};
#[cfg(target_family = "unix")]
use std::os::unix::fs::PermissionsExt;
fn encodehex(data: &[u8]) -> String {
    hex::encode(data)
}
fn decodehex(hex: &str) -> Result<Vec<u8>, FromHexError> {
    hex::decode(hex)
}

fn main() -> Result<(), KyberError> {
    let mut rng = rand::thread_rng();
    let mut alice = Ake::new();
    let mut bob = Ake::new();

    let alice_keys = keypair(&mut rng)?;
    let bob_keys = keypair(&mut rng)?;
    fs::write("bobpublickey.pem",hex::encode(bob_keys.public));
    fs::write("bobsecretkey.pem",hex::encode(bob_keys.secret));
    fs::write("alicepublickey.pem",hex::encode(alice_keys.public));
    fs::write("alicesecretkey.pem",hex::encode(alice_keys.secret));
    let bobpkey = fs::read("bobpublickey.pem").unwrap();
    let bobskey = fs::read("bobsecretkey.pem").unwrap();
    let bobpkey: [u8;KYBER_PUBLICKEYBYTES] = bobpkey[..KYBER_PUBLICKEYBYTES].try_into().unwrap();
    let bobskey: [u8;KYBER_SECRETKEYBYTES] = bobskey[..KYBER_SECRETKEYBYTES].try_into().unwrap();
    //let keys_bob = keypair(&mut rng)?;
    let keys_bob=Keypair {
        public: bobpkey,
        secret: bobskey
    };
    //Go to C to get the cipher to verify here.
    let ciphertext=fs::read_to_string("cipher.pem").unwrap();
    println!("Keys would be {}",ciphertext);
    let ciphertext = decodehex(&ciphertext.trim()).unwrap();
    // Alice encapsulates a shared secret using Bob's public key
    //let (ciphertext, shared_secret_alice) = encapsulate(&publickey, &mut rng)?;
    // Bob decapsulates a shared secret using the ciphertext sent by Alice
    let shared_secret_bob = decapsulate(&ciphertext, &keys_bob.secret)?;
    println!("Shared secret is {}",hex::encode(shared_secret_bob));
    Ok(())
}

However at the end, the shared secret is different :
Rust : 12d6dc3e341bb2afd57d7266d898771e6c25db3d28b3d321784dffec5b6f2401
C : fe3f00af8029fdfc22c84eb4f5ece5819ca9e373c94d72430623cc9fe21728fe

I don't know if I'm doing something wrong or if the implementation has some issues but the shared secret should be the same using same keys and same cipher.

I can have a look at it later tomorrow if need be but from initial inspection it is perhaps in novel C implementation of the AKE?
Could you give a try with the kyber reference AKE functions instead?  https://github.com/pq-crystals/kyber/blob/main/ref/kex.c
I'm not a fan of the current AKE and UAKE structs, they are inefficient and clunky, but will certainly investigate to make sure of interop if it doesn't work with those.

Actually my mistake here, the AKE isn't being used, you are
Can you reduce to a Minimum Reproducible Example without all the extra parts and we can go from there?
Thanks.

Sure I'II try this evening. I have redefined the C code too as there were so mistakes.
Now I have a C code that extracts correctly everything from Rust but still fails (I have changed the C code to indicate the fail instead of cmov but should not be an issue). I'm reducing the code and sending you ASAP.

Hello,
I'm sorry. It seems 90-fixslice was activated on the C compilation and therefore result was therefore different. Setting same option solves the problem for unauthentificated and UAKE handshake.
Sorry.


Treat Void formal arguments as @Nullable

This is a follow up on #595. See that PR for some of the soundness
caveats related to method overriding and the nullability of Void
in our current implementation.
This does, however, avoid some otherwise awkward suppressions,
as shown in #608.
There are two correct ways of handling Void:
a) Having it default to @Nullable as a type, which requires us
adding a "default nullability" for some types/classes and explicitly
contradicts JSpecify (jspecify/jspecify#51)
b) Supporting generics, and requiring explicitly annotating @Nullable Void.
This will probably also require third-party libraries which we consider
annotated (such as CF), to adopt this convention.
I believe (b) is the way forward long-term, which means that, for now,
this hack might be the best we can do without generics support. Once
NullAway supports generics, both this change and #595 should be reverted.

Pull Request Test Coverage Report for Build #875

0 of 0   changed or added relevant lines in 0 files are covered.
35 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.02%) to 92.133%

Files with Coverage Reduction
New Missed Lines
%

../nullaway/src/main/java/com/uber/nullaway/dataflow/AccessPath.java
2
95.74%

../nullaway/src/main/java/com/uber/nullaway/dataflow/cfg/NullAwayCFGBuilder.java
3
90.91%

../nullaway/src/main/java/com/uber/nullaway/NullAway.java
30
93.09%

Totals

Change from base Build #874:
-0.02%

Covered Lines:
4825

Relevant Lines:
5237

💛  - Coveralls

Beyond the comment below, could we add a test for assigning (Void) null to a field? I'm not sure what to expect there (though it is a more contrived case).

Will try, though I'd expect that to fail within this hack. If we want a more robust fix here, we might need some sort of mechanism to specify the default nullness of a type. Basically, forcing NullAway to expand Void into @Nullable Void everywhere (for now), then revert that once we have support for annotations on generics.


Exporting functions like HSVtoHSL, HSVtoRGB, HSVtoHex?

I find them quite useful but for now I just copy them directly into my source code
https://github.com/fritx/markppt/commit/ae7df02b5577cb6ce41dde6da60345365243b40b#diff-5f48f4b7cd5fa5aa6e97a127e55158deR271

Hi Fritz! I'd rather not do this. Although the actual downsides of exporting these functions are insignificant, I'd prefer to keep the tool focussed as possible. There are some terrific libraries for color format conversion and I'd rather direct people to those instead.

Cool! Btw, what else libraries do you think are good to use?

Chroma and Chromatist are both great.

Nice!


Jack must push his addition of Robot Builder and the command to the repo from his computer

Jack - push your changes to the repo!

Oh, I thought that was just a demonstration robot. Will do when I get home.
On Jan 3, 2015 5:08 PM, "Tarkan Al-Kazily"<EMAIL_ADDRESS>wrote:

Jack - push your changes to the repo!
—
Reply to this email directly or view it on GitHub
https://github.com/Spartronics4915/2015-Recycle-Rush/issues/3.


UnsatisfiedDependencyException: Error creating bean with name 'gitCollectorTask' defined in URL

I've built a docker container for the hygieia-scm-bitbucket-collector. On startup the database connection is made but the application fails to launch with the following error.
I've attached my log file:
bitbucket-collector.txt
2020-09-03 10:41:00,246 [main] WARN  o.s.c.a.AnnotationConfigApplicationContext - Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'gitCollectorTask' defined in URL [jar:file:/hygieia/bitbucket-scm-collector.jar!/com/capitalone/dashboard/collector/GitCollectorTask.class]: Unsatisfied dependency expressed through constructor argument with index 4 of type [com.capitalone.dashboard.collector.GitClient]: No qualifying bean of type [com.capitalone.dashboard.collector.GitClient] found for dependency: expected at least 1 bean which qualifies as autowire candidate for this dependency. Dependency annotations: {}; nested exception is org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type [com.capitalone.dashboard.collector.GitClient] found for dependency: expected at least 1 bean which qualifies as autowire candidate for this dependency. Dependency annotations: {}
My properties are:
          env:             - name: SKIP_PROPERTIES_BUILDER               value: "true"             #- name: dbhost               #value: REDACTED             - name: dbport               value: "27017"                           - name: dbname               value: dashboarddb             - name: dbreplicaset               value: "true"             - name: dbhostport               value: REDACTED:27017,REDACTED:27017             - name: dbusername               value: hygieiaadmin             - name: dbpassword               value: REDACTED             - name: logging.file               value: "/logs/bitbucket.log"                       - name: git.cron               value: '0 0/5 * * * *'             - name: git.host               value: https://tooling.wakago.net/bitbucket             - name: git.api               value: "/rest/api/1.0/"               value: https://tooling.wakago.net/bitbucket             - name:  git.username               value: REDACTED             - name: git.password               value: "REDACTED"             - name: git.commitThresholdDays               value: "15"             - name: git.pageSize               value: "25"             - name: git.product               value: server             - name: bitbucket.key               value: "REDACTED"

Closing as no longer required


Comment parsing failes to correctly resolve \r\n in skip_multiline_spacer

If used on Windows, toml files often have \r\n at the end of a line. The parser handles this relatively well, however in skip_multiline_spacer it removes the \n at the end of a comment without checking for a \r before. This results in invalid toml files written to disk using std::ofstream on windows.
Proposed fix:
Change this line:
https://github.com/ToruNiina/toml11/blob/main/include/toml11/parser.hpp#L1858
To:
if(!comment.empty() && comment.back() == '\n')
{
    comment.pop_back();
    if (!comment.empty() && comment.back() == '\r')
        comment.pop_back();
}

Good catch!
And your fix looks correct. Would you like to make a pull request? I will do some work in the next weekend, so I will wait until then.

Just created a pull request, thank you for the fast answer!

Thank you! Merged.


[minor] Update docs of montage.plot(show_names)

When playing around with raw.plot_sensors and montage.plot I figured that the docstrings are not accurate.
raw.plot_sensors() takes either a bool or a list of channel names, this is also possible in montage.plot()
I thought this should also be reflected in the docstring

Thanks @skjerns !


List of Portings

As agreed with Sasha, I'm opening this issue to take track of all the ports:

jvm, written in Kotlin

If you have a porting you'd like to add, don't hesitate to reply and I'll update the list :)

I have added a wiki page to this repository for this and also added your port.

Cool, thanks!
Shall we close this issue then or leave it open?


Created a Form Select Component

Created a Form Select Component using html & tailwindcss as mentioned in #316

Good job @abirhasanohi
Congrats 🎉, your PR got merged. To be eligible for the swags from ClueLess. Follow this steps.

Star this repository. ⭐
SignIn / SignUp in [ClueLess Website](https://www.clueless.tech/) .
Go to profile section from the top right hand corner.

Comment your profile URL under this comment tagging the person who merged your PR.

That’s it. Follow the leaderboard !
And don’t forget to share your achievement with your friends.


No feedback in UI when organization is not authorized

Issue Type: Bug

In the VS Code repo on a new machine
Sign in but forget to authorize the microsoft organization
Go to pr/issues view
It is empty.
Try pressing refresh and nothing happens

In the logs, I see
[Info] GithubRepository> Unable to fetch PR: Error: GraphQL error: Resource protected by organization SAML enforcement. You must grant your OAuth token access to this organization.
[Info] GithubRepository> Unable to fetch issues: Error: GraphQL error: Resource protected by organization SAML enforcement. You must grant your OAuth token access to this organization.

It would be great if this error was shown to users in the UI too
Extension version: 2021.2.34443
VS Code version: Code - Insiders 1.54.0-insider (c47da720f351455681978a48edc4d9a0d095ea0e, 2021-02-24T11:23:03.943Z)
OS version: Windows_NT x64 10.0.19041

System Info

Item
Value

CPUs
Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (4 x 2400)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: unavailable_offopengl: enabled_onprotected_video_decode: unavailable_offrasterization: unavailable_offskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
7.04GB (1.30GB free)

Process Argv
--crash-reporter-id 98ab83f8-a588-4ded-9863-d25098038154 --crash-reporter-id 98ab83f8-a588-4ded-9863-d25098038154 --crash-reporter-id 98ab83f8-a588-4ded-9863-d25098038154

Screen Reader
no

VM
100%

duplicate of https://github.com/microsoft/vscode-pull-request-github/issues/2385


EventHeaderSerializer

Dear Splunk fellows,
For logs that are processed asynchronously or in batches, the time in the log message may differ from the current time (also mentioned #71).  Furthermore, there seems to be a need to easily overwrite the root tags of the JSON event ( #18).  I created the EventHeaderSerializer in order to facilitate to set tags (i.e. host, source type, source,  time) based on the message, metadata or on other user logic.
Best Regards,
Norwin

I verified the EventHeaderSerialize manually using log4J . However, I'm still working on fixing the tests. Is there a simple way to run them locally without using Travis?

I verified the EventHeaderSerialize manually using log4J . However, I'm still working on fixing the tests. Is there a simple way to run them locally without using Travis?

Never mind, I managed to run the tests on my machine with the docker image "splunk/splunk".

@shakeelmohamed Is there any chance that this will be reviewed and released soon?

@snorwin hang tight, one of our developers is working on some changes we hope to release soon. Some of your issues may already be getting resolved from that work

Hi @shakeelmohamed
I have resolved the merge conflicts, could you please check again? I think this feature is really helpful in particular to feed in historical data or facilitate custom logic to set the source type.
Thanks,
Norwin

Same here, I rebased the branch to master due to the artifactory URL change.
@shakeelmohamed is there any chance that this new feature will be included in the next version?

@snorwin I will see if we can get this prioritized internally. We are even more resource constrained than usual at the moment due to COVID-19. Thank you for your patience

Hello,
Really interested in this feature! We also need to override root-level time (and other parameters)
Thanks!


Broken links to all 2017 data

Unfortunately none of the 2017 dataset links seem to be working.
For the one hosted by caltech, I get a Connection refused error:
~$ wget http://www.vision.caltech.edu/~gvanhorn/datasets/inaturalist/fgvc4_competition/train_val_images.tar.gz

--2020-07-28 18:35:19--  http://www.vision.caltech.edu/~gvanhorn/datasets/inaturalist/fgvc4_competition/train_val_images.tar.gz
Resolving www.vision.caltech.edu (www.vision.caltech.edu)... <IP_ADDRESS>
Connecting to www.vision.caltech.edu (www.vision.caltech.edu)|<IP_ADDRESS>|:80... connected.
HTTP request sent, awaiting response... 301 Moved Permanently
Location: http://people.vision.caltech.edu/~gvanhorn/datasets/inaturalist/fgvc4_competition/train_val_images.tar.gz [following]
--2020-07-28 18:35:20--  http://people.vision.caltech.edu/~gvanhorn/datasets/inaturalist/fgvc4_competition/train_val_images.tar.gz
Resolving people.vision.caltech.edu (people.vision.caltech.edu)... <IP_ADDRESS>
Connecting to people.vision.caltech.edu (people.vision.caltech.edu)|<IP_ADDRESS>|:80... failed: Connection refused.

And for each of the google API mirrors, a NoSuchBucket error:
<Error>
NoSuchBucket
<Message>The specified bucket does not exist.</Message>
</Error>

Has this data been permanently removed? Or is there a mirror or some other way to access it?
Thanks for any help.

Thanks for the heads up! I'm trying to work with Caltech and Google to see if we can get the links re-established.

The link to the un-obfuscated category names also needs to be updated.
Thanks in advance!

Update: I'm currently uploading the datasets to AWS S3. As a temporary solution I'll put them in a "requester pays" bucket so that folks can at least access them. I'll close this issue once the S3 links are ready to go (hopefully by end of day today or tomorrow). Still going back and forth with Google and Kaggle to see if we can get the original links reactivated.

That’s great, thank you!

We've uploaded the dataset files to a "requester pays" bucket on AWS S3 (see here). While this is not as convenient as free downloads it at least makes the dataset available. We'll continue the conversation with Google to see if we can get the original links to work again. Sorry for the delay!


For local development: Switch to SQL Server database

as a developer i want the webappliction to connect to a database rather than having a database deployed with every webapp. This will be done by switching from sqlite to sql server.

the sql server can be instanciated with:
docker run -e "ACCEPT_EULA=Y" -e "MSSQL_SA_PASSWORD=yourStrong(!)Password" -p 1433:1433  --name sqlpreview --hostname sqlpreview -d mcr.microsoft.com/mssql/server:2022-latest

Acceptence criteria:

Refactor your Chirp! application so that it uses an SQL Server database when executed locally
Ensure your tests are still running - using SQLite in-memory and/or test containers.
Run your production code with Azure SQL.
Ensure you apply your migrations when deploying to App Services.
Extend your CheepRepository to support create (test and implement).
Using FluentValidation to ensure all inputs are valid.
Add a Chirp! form to your app which is only visible when a user is signed in.
Ensure a user can only post to the form if she is signed in.

Migrations issue is resolved in code.


update to 1.19.4

there is problem with packet 0x08 for some reason converted to draft

Closing as superseded by 1.20.1 support


Docker Hub repository name
chrisiscoding/topmast
Terms of services

[X] I accept the term of services

/validate

@benja-M-1
Hello Benjamin, sorry to bother. I was wondering if it would be possible to change the extension address to topmast/topmast:0.1.2-alpha I haven't found a way to do it on my end.
The extension has been mistakenly published under an incorrect repository name, and I am uncertain about the appropriate steps to update the address on the published version. I would be grateful for any assistance or pointers you can provide to help me address this issue.
For your reference, here is the link to the Docker Hub repository where the extension is currently hosted: https://hub.docker.com/r/topmast/topmast
Thank you very much for your understanding and support.

Hi @Chris-isCoding you can submit the new one. Once the validation pass we will manually update the list on the marketplace.
The drawback though is that users that already have the extension installed won't be migrated to the new one. What you can do is push a new version on the wrong repo telling the users to uninstall it and install the new one.

Hi @Chris-isCoding do you want me to remove this extension from the marketplace and add the other one?

Hi @benja-M-1
Yes, please remove this extension from the marketplace and replace it with the other one that has the correct hub docker references.
I appreciate your help in making this update.
Thank you

Yes we will do

@Chris-isCoding we removed it. You can restart your Docker Desktop and it should disappear.


ensure that no query inputs -> input object must be null (or maybe {}) - not any

currently its resulting in allowing any to be passed in, which prevents some of the errors it can help resolve w/ type defs!

this will also resolve the linter error that occurs when we have an empty interface

theres linting errors that say prefer interface over type for {}, so lets go with null


Training a custom mcunet model

Hello,
I'd like to train a custom model using mcunet. Is there any tutorial/documentation on how to do this? Have the relevant parts of the code been uploaded or are they still unreleased?

hello, i have the same issue, have you resolved this?


Search for forums when creating new forum

Maybe show "5 existing forums found... [VIEW SEARCH RESULTS]" under the search bar.
Maybe search should (locally) support is:forum as a way to filter down.


Mention top-type-sizes for print-type-sizes

print-type-sizes produces unordered and cluttered output. This crate parses that output, refine it and show top types by size in compact form.

The PR as written had a partial sentence ("The tool") and I'm picky about the words used in the perf-book, so I did something similar myself in https://github.com/nnethercote/perf-book/commit/b1c64bcb3f84670a78b39fa66a9ccd4ea2967c48.
Thanks for the suggestion, I didn't know about this crate!


SELinux blocking socket

/cc @rhatdan
just to track SELinux is blocking the connection back to the docker daemon
docker: Error response from daemon: Plugin Error: Cannot connect to the Docker daemon. Is the docker daemon running on this host?, AuthZPlugin.AuthZReq.

I'm still looking for the cause..disabling SELinux (deeply sorry Dan) will fix this though

This is a policy issue.  We are blocking init_t domains from talking to docker_t.
ps -eZ | grep docker
What is the docker volume plugin running with.
You can fix this by changing the label of the executable to docker_exec_t.
chcon -R -t docker_exec_t /var/lib/docker
Then restart your daemon.  We need to make this change if we decide this is the location for these plugins.  Or we could move the plugins to /usr/sbin and then change the label there in the docker-selinux package.

What is the docker volume plugin running with.

you're right
system_u:system_r:init_t:s0       433 ?        00:00:00 docker-novolume
system_u:system_r:docker_t:s0     587 ?        00:00:00 docker

You can fix this by changing the label of the executable to docker_exec_t.
chcon -R -t docker_exec_t /var/lib/docker
Then restart your daemon. We need to make this change if we decide this is the location for these plugins. Or we could move the plugins to /usr/sbin and then change the label there in the docker-selinux package.

how do we chcon on plugin installation? (I'm not understanding :/)
generally, how do we change selinux label upon installation?

We need to fix this in docker-selinux package, I am just giving you a work around to make sure it works for you.
We just need to decide on the path we want for docker-novolume, then I can setup the proper labeling.

awesome (I'll keep this open as a reminder though)

@rhatdan any hints on how I could fix this i docker-selinux? I have no idea right now, so we can move on with this

Just pushed some policy for this to the docker-selinux package.  I will send you something to test.

fixed in latest docker-selinux pkg shipped in rawhide


Update OpenMM-Setup to 1.1

Travis is working for Python 3.6 but failing for 2.7 and 3.5.  I don't understand why.
https://travis-ci.org/omnia-md/conda-recipes/jobs/312614706#L2085-L2105
Any idea what's going on?

Do you have a dependency called "itsdangerous"?
https://travis-ci.org/omnia-md/conda-recipes/jobs/312614706#L2228

Not directly, though it's always possible one of the libraries it uses depends on that.
requirements:
  build:
    - python
    - setuptools
    - flask
    - openmm
    - pdbfixer >=1.5

The package flask is pulling in itsdangerous, and then trying to install it again through pip for some reason, which then causes the builds to fail.

It looks like it's some sort of cryptographic library, so it's probably required by Flask.  But it's been around for quite a while, and all indications are that it's supported on older Python versions.
https://pypi.python.org/pypi/itsdangerous/0.24

Should I try listing it directly as a dependency in meta.yaml?

In theory that should fix it, although I don't know why it isnt resolving, Maybe the minimum version in conda for flask needs a lower version than the pip version? that would cause this problem

No, that didn't work.

I'm looking at it now, I'll see if I can find where the dependency chain is broken

Found it. Bad news, and good news.
The bad: Its the itsdangerous package through flask on conda-forge and specifically its noarch version is being fetched by all python versions, but not recognized by setuptools as a package installed called itsdangerous, so it then tries to pull it through pip. I don't know why, and neither does the person who found the exact same problem on the itsdangerous feedstock
The Good: The person who reported this issue also engineered a work around you can see here. the short of it is, in the requirements: build block of the meta.yaml, add the following:
requirements:
  build:
    - itsdangerous 0.24 py27_1  # [py27]
    - itsdangerous 0.24 py35_1  # [py35]
    - werkzeug 0.12.2 py35_0  # [py35]
    - werkzeug 0.12.2 py27_0  # [py27]

And that works around the issue. you'll need to remove the pin to itsdangerous you added previously.

I posted on itsdangerous's feedstock, so hopefully it bumps the issue there.

Perfect!  I just committed the change.  We'll see if it works.

All tests passed.

According to https://anaconda.org/omnia/openmm-setup/files, on Windows it seems to have only built a Python 3.5 version, not a 3.6 version.  Any idea why?

 skip: True  # [win32 or (win64 and not py35)] in the meta.yaml file

Ah, right.  Oops.  Let me go fix that.


refactor: Replace common patterns from various transaction methods with common functions

Summary
This PR reduces code required in the transaction's get, runQuery, runAggregationQuery and commit methods by replacing similar blocks of code with common functions. Reducing the amount of code in each function reduces technical debt and makes it easier to spot decorator patterns that might simplify code even further.
Changes

Added a function called #sendUserCallbackData to increase code reuse. This replaces the custom code contained in each call to withBeginTransaction in get, commit, runQuery and runAggregationQuery. Response data from the resolvers in each of these functions is now provided in an array format so that it can be processed by sendUserCallbackData. This lets us eliminate each of the custom callbacks in calls to withBeginTransaction.
Added a function called callbackWithError which eliminates extra code used to build each resolver. This reduces the amount of code required in get, commit, runQuery and runAggregationQuery used to build a resolver because now a callback in the expected format is provided by this function.
Finally the prior two changes enforced stronger type alignment so in UserCallbackData the error type was changed so that it couldn't be undefined to solve come compiler errors. This is expected because callbacks either receive errors or null values in the first callback argument throughout the codebase so this provides an improvement to how types line up.

I'm a little concerned by how complex this change is getting, and this PR seems to be a step in the wrong direction. There are a lot of concepts being used, and they all interact in ways that's hard to follow.
I tried to trace the stack for a commit, and found
transaction.commit -> sendUserCallback -> withBeginTransaction -> resolver -> runCommit -> callbackWithError -> PromiseResolveFunction -> ...
From there, it wasn't completely clear to me who was calling the PromiseResolveFunction and where the arguments came from. There's just too many layers of abstraction and callbacks calling other callbacks. There must be a way to simplify this, right?
If not, maybe adding a lot more comments would be helpful

Some of that feedback applies to PR 1205 as well, but for this one specifically: the change is pretty much line-of-code neutral, and adds two more layers of indirection with sendUserCallbackData and callbackWithError. So IMO it's probably not worth making this change, unless there are other benefits I'm missing

I think this PR cleans up a little bit of technical debt. With the way it was before we are applying the same pattern in four places, but writing the pattern out explicitly each time which we shouldn't do. I see how the indirection could be confusing though.
Overall it isn't too critical to get this in because its just an internal change that cleans things up so if you want to leave it for now then perhaps it is fine.

Regarding the stack trace, without callbackWithError you will get a more anonymous callback which might be even harder to debug. We could also think about combining sendUserCallback and withBeginTransaction into one function that has both code and then it would be easier to follow.

Yeah, IMO this is a step towards more complexity, so probably better to leave it out. I'd look into combining sendUserCallback with withBeginTransaction, and callbackWithError with Resolver. See if you can flatten the call stack. I really don't think it should need this level of complexity
But maybe a node expert would have different thoughts too, so maybe a different reviewer would have different thoughts?

Closing this PR in favour of https://github.com/googleapis/nodejs-datastore/pull/1212.


[GitHub] GPG key for bug reporting

Description of the new feature / enhancement
As @crispinb says in https://github.com/microsoft/PowerToys/issues/13221#issuecomment-920341497, we should generate a GPG key for those who want to encrypt their bug reporting file due to security and privacy concerns.
Scenario when this would be used?
For anyone who wants to protect their bug reporting file when filing issues.
Supporting information
No response

@DHowett thoughts?

@franky920920 They can also send the bug report to @crutkas directly. But I like this idea

Terminal hasn't had need of something like this yet, @crutkas, so I don't have better guidance. :smile:

I would love to see this.


Refactor update commands to reduce dupe code, refactor startup code to separate out different states

This PR is a continuation of #531 and finishes off separating out the startup code into the 3 main states we care about:

Required tooling is missing
Tooling installed but no Titanium project open
Tooling installed and Titanium project open

From here we can then start creating the welcome views for the activity bar that will show.
It also refactors the update commands to reduce the duplicate code we had

Warnings

:warning:

src/commands/index.ts#L127 - src/commands/index.ts line 127 – Forbidden non-null assertion. (@typescript-eslint/no-non-null-assertion)

:warning:

src/extension.ts#L60 - src/extension.ts line 60 – Forbidden non-null assertion. (@typescript-eslint/no-non-null-assertion)

:warning:

src/extension.ts#L71 - src/extension.ts line 71 – Forbidden non-null assertion. (@typescript-eslint/no-non-null-assertion)

Messages

:book:

:white_check_mark: All tests are passing
Nice one! All 32 tests are passing.

:book:

:floppy_disk: Here's the built vsix for this change.

  Generated by :no_entry_sign: dangerJS against 2806e90de3190084ce8ce8ea788236081a723792

Warnings

:warning:

src/commands/index.ts#L127 - src/commands/index.ts line 127 – Forbidden non-null assertion. (@typescript-eslint/no-non-null-assertion)

:warning:

src/extension.ts#L60 - src/extension.ts line 60 – Forbidden non-null assertion. (@typescript-eslint/no-non-null-assertion)

:warning:

src/extension.ts#L71 - src/extension.ts line 71 – Forbidden non-null assertion. (@typescript-eslint/no-non-null-assertion)

Messages

:book:

:white_check_mark: All tests are passing
Nice one! All 32 tests are passing.

:book:

:floppy_disk: Here's the built vsix for this change.

  Generated by :no_entry_sign: dangerJS against 2806e90de3190084ce8ce8ea788236081a723792


[Python Support] Update Docs

Updating docs to reflect that Python support has been added.

PTAL @rodaine


link build badge to master branch

...and change gitter image badge to svg

Works for me.  I guess we'll have to change the gitter badge on every repo.


sourcekitd-test: be more error resilient

Ensure that we handle the error case as well.  Fix up the type mismatches in the
process.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please test and merge


Node.js Kickthemout porting

I Just took some inspiration to make a porting in Node.js :)
https://github.com/roccomuso/kickthemout

Hey there @roccomuso. Good job on that node.js script. It's nice to see that we have inspired others with our project. Thank you!


librarian cant install mcollective and choria

In order to give a easy workflow i made it so mcollective module brings in all the core choria stuff and plugins
but those again must depend on mcollective since they use its plugin installer, so that's circular.
instead the choria module should have all the module dependencies for all the choria things and the mcollective one should have none
reported by @jamtur01

Is this solved? I still can see the circular dependency between modules.

Well some changes were made. If you are having issues open a new ticket is best with full description.
But as puppet has no problem with these modules one might reasonably expect that if a puppet package manager has issues with them then the package manager has issues.


Pagination

In order to deal with rendering large amounts of data, angular-tree-component has a virtual scroll. However, it is not possible to load small chunks of data on demand.
Is it possible to implement this feature? For example, we could add "load more.." button

@gituser3000 It's possible to build this with the current tree version. Take a look at this stackblitz. It's an error repo for a virtual scroll issue, so just set virtualScroll: false in the app.component.ts to see it working.
You can build your own version based on that. We are using a variation of that for years now. Of course it requires some logic outside the tree to keep track of everything. It would be nice to move some of that logic inside the tree and add some nicer error handling.

@gituser3000 It's possible to build this with the current tree version. Take a look at this stackblitz. It's an error repo for a virtual scroll issue, so just set virtualScroll: false in the app.component.ts to see it working.
You can build your own version based on that. We are using a variation of that for years now. Of course it requires some logic outside the tree to keep track of everything. It would be nice to move some of that logic inside the tree and add some nicer error handling.


Itertools count refactor

The previous iteration used a complex adding method on a floatOrInt type receiver
in order to handle Float/Int combination arguments.
This method worked but added unnecessary complexity when compared with starlark's
Binary function.
Therefore, the previous adding method is removed, as well as the implementation of
floatOrInt (which was only used to support the addition of combo args for count and
step), and replaced in favor of the leaner starlark.Binary — alongside strict checks
for numeric types in the count_ function.

Codecov Report

Merging #19 (d282fcb) into master (582f6b5) will decrease coverage by 0.43%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   83.76%   83.33%   -0.44%
==========================================
  Files           7        7
  Lines         271      246      -25
==========================================
- Hits          227      205      -22
+ Misses         33       31       -2
+ Partials       11       10       -1

Impacted Files
Coverage Δ

itertools.go
81.19% <100.00%> (-1.20%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 582f6b5...d282fcb. Read the comment docs.


[5.2] Add root url to elixir

Thanks :+1:

:+1:

Hi,
This PR has disappeared from master branch : https://github.com/laravel/framework/blob/master/src/Illuminate/Foundation/helpers.php#L303
Is it normal ?

It seems it's also gone from 5.2 :cry:
https://github.com/laravel/framework/blob/5.2/src/Illuminate/Foundation/helpers.php#L303


Line numbers: Style inline code

I noticed that some inline code snippets aren't highlighted.

I'm just gonna merge this because of how small the change is.


Pageserver defaults cleanup

I've noted and fixed some discrepancies in pageserver defaults: some specify port 5430 instead of 64000, as well as an incorrect copy-paste of the HTTP default.
I took the liberty of bringing in const_format. If it's better to remove it, I will remove the first commit and rewrite the second via format!

I've run cargo +nightly-2021-09-08 build --all --all-targets -Z timings twice on current main and this branch cleaning target on my not-so-beefy machine the and got the time stats it took to build the new deps:

const_format_proc_macros v0.2.21 | 3.4s
const_format v0.2.21 | 1.1s

Not that big for a nice way to tie clean up all the messages IMO.


Feature: Support Authentification for REST APIs

Username, Password, Token via CLI parameter

basic auth username/password is now supported apikeys can be added to the --url ?key=sdsjhdsjdhs


Check connecttimeout when SelectionKey.OP_CONNECT event happend

related to HTTPCORE-488
InternalConnectChannel onTimeout should also invoke close method

Could you please rebase your branch off the latest master and squash all your individual commits? There is also garbage in the change-set (commit-6349d92 file presumably checked in by mistake). Could you please remove it?

Committed to master with changes. Please review and close.

thank you


Update javascript-fetch backend documentation page

Issue: the current javascript/fetch node-js documentation is outdated for Scala-js 1.x.
Error message:
Loading the global scope as a value (anywhere but as the left-hand-side of a .-selection) is not allowed.
Solution: use the globalThis property from global https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/globalThis

Thanks!


Add EncoderDecoderModel support

🚀 Feature request
Could it be possible to add adapters to the EncoderDecoderModel?
I am fine-tuning an EncoderDecoderModel with two mBERT and I would like to compare it with fine-tuning only the adapter layers

@patil-suraj

Hey @joao-alves97, I started an adapter implementation for EncoderDecoderModel in https://github.com/calpt/adapter-transformers/tree/dev/encoder_decoder (currently work in progress). Expecting it to be available soon.

Awesome! Could you send me a message once it is available? Thanks

@joao-alves97 the EncoderDecoderModel implementation has been merged into master, so you should be able to use it when installing from there. We haven't done any extensive evaluation yet though, so happy to hear about results you get :)

Awesome! Next week I'm going to try to do some experiments!

@calpt sorry for replying after 2 months but I'm trying to use adapters on top of a EncoderDecoderModel with two XLMR for translation but I'm always facing this error:
The model is not freezed. For training adapters please call the train_adapters() method
I'm using the method model.train_adapter(adapter_name).
Any idea on how to solve this problem?

@joao-alves97 This error doesn't sound expected. Would you mind opening a new (bug report) issue for this (ideally with a short snippet for us to reproduce)? Thanks!


Need testing?

Hi, thank you for making this port :)
In you conversation with Danijar, I read that you're limited in your abilities to test because of GPU availability? I'm interested in building from your code, and I'd be happy to help run tests for you. I have four Titan Xps I could dedicate to it for a bit. My limitation is that I don't have a Mujoco license (I'm working on it) so testing would be limited to Gym environments.

That would be much appreciated! Unfortunately I'm still waiting for the latest results from Danijar (fixing the bug in the RNN would improve upon the original results), and in order to check that this code is fine we'd want to compare results so that means DeepMind Control Suite.
If you're interested in getting baseline results for your own work then perhaps it would be interesting to have some results on Pendulum-v0 and MountainCarContinuous-v0 (both symbolic and visual observations) anyway? We currently have no idea what appropriate hyperparameters are, and as one of those people who also don't have easy access to MuJoCo licenses I know it'd be nice to have some completely open source reference results.

Hi @Kaixhin,
I'm running headless, and I'm able to run symbolic mode fine, but I can't run in non-sybolic mode. I have render set to False, but I get the following error:
                          Options
                          seed: 1
                          disable_cuda: False
                          env: Pendulum-v0
                          symbolic_env: False
                          max_episode_length: 1000
                          experience_size: 1000000
                          activation_function: relu
                          embedding_size: 1024
                          hidden_size: 200
                          belief_size: 200
                          state_size: 30
                          action_repeat: 2
                          action_noise: 0.3
                          episodes: 2000
                          seed_episodes: 5
                          collect_interval: 100
                          batch_size: 50
                          chunk_size: 50
                          overshooting_distance: 50
                          overshooting_kl_beta: 1
                          overshooting_reward_scale: 1
                          global_kl_beta: 0.1
                          free_nats: 2
                          learning_rate: 0.001
                          action_noise: 0.3
                          episodes: 2000
                          seed_episodes: 5
                          collect_interval: 100
                          batch_size: 50
                          chunk_size: 50
                          overshooting_distance: 50
                          overshooting_kl_beta: 1
                          overshooting_reward_scale: 1
                          global_kl_beta: 0.1
                          free_nats: 2
                          learning_rate: 0.001
                          grad_clip_norm: 1000
                          planning_horizon: 12
                          optimisation_iters: 10
                          candidates: 1000
                          top_candidates: 100
                          test_interval: 25
                          test_episodes: 10
                          checkpoint_interval: 25
                          checkpoint_experience: False
                          load_experience: False
                          load_checkpoint: 0
                          render: False
Traceback (most recent call last):
  File "main.py", line 85, in <module>
    observation, done, t = env.reset(), False, 0
  File "/home/sgreen/working/planet.pt/env.py", line 87, in reset
    return torch.tensor(cv2.resize(self._env.render(mode='rgb_array'), (64, 64), interpolation=cv2.INTER_LINEAR).transpose(2, 0, 1), dtype=torch.float32).div_(255).unsqueeze(dim=0)
  File "/ascldap/users/sgreen/anaconda3/envs/planet.pt/lib/python3.7/site-packages/gym/core.py", line 249, in render
    return self.env.render(mode, **kwargs)
  File "/ascldap/users/sgreen/anaconda3/envs/planet.pt/lib/python3.7/site-packages/gym/envs/classic_control/pendulum.py", line 61, in render
    from gym.envs.classic_control import rendering
  File "/ascldap/users/sgreen/anaconda3/envs/planet.pt/lib/python3.7/site-packages/gym/envs/classic_control/rendering.py", line 27, in <module>
    from pyglet.gl import *
  File "/ascldap/users/sgreen/anaconda3/envs/planet.pt/lib/python3.7/site-packages/pyglet/gl/__init__.py", line 239, in <module>
    import pyglet.window
  File "/ascldap/users/sgreen/anaconda3/envs/planet.pt/lib/python3.7/site-packages/pyglet/window/__init__.py", line 1896, in <module>
    gl._create_shadow_window()
  File "/ascldap/users/sgreen/anaconda3/envs/planet.pt/lib/python3.7/site-packages/pyglet/gl/__init__.py", line 208, in _create_shadow_window
    _shadow_window = Window(width=1, height=1, visible=False)
  File "/ascldap/users/sgreen/anaconda3/envs/planet.pt/lib/python3.7/site-packages/pyglet/window/xlib/__init__.py", line 166, in __init__
    super(XlibWindow, self).__init__(*args, **kwargs)
  File "/ascldap/users/sgreen/anaconda3/envs/planet.pt/lib/python3.7/site-packages/pyglet/window/__init__.py", line 501, in __init__
    display = get_platform().get_default_display()
  File "/ascldap/users/sgreen/anaconda3/envs/planet.pt/lib/python3.7/site-packages/pyglet/window/__init__.py", line 1845, in get_default_display
    return pyglet.canvas.get_display()
  File "/ascldap/users/sgreen/anaconda3/envs/planet.pt/lib/python3.7/site-packages/pyglet/canvas/__init__.py", line 82, in get_display
    return Display()
  File "/ascldap/users/sgreen/anaconda3/envs/planet.pt/lib/python3.7/site-packages/pyglet/canvas/xlib.py", line 86, in __init__
    raise NoSuchDisplayException('Cannot connect to "%s"' % name)
pyglet.canvas.xlib.NoSuchDisplayException: Cannot connect to "None"

Are you also running headless?

I am not running headless, as I'm using gym's render functionality to get image-based observations. I'm afraid you'll need to run with either a real or fake display.

I have a MuJoCo license now! Is there a sweep of MuJoCo environment tests you would like run?

Great news! I've started a run on walker-walk, so any of the others.

Will do. Other than the environment, should I use the default parser arguments of your latest commit?

Latest commit should be same settings as PlaNet camera ready so yes - only other change is the recommended action repeat per environment, which you can see in env.py.

Thanks, I started a run on cartpole-swingup, finger-spin, cheetah-run, and ball_in_cup-catch.

Hi @Kaixhin, things are looking good! I will continue to train for another day and then update, but it seems that scores are meeting or approaching Danijar's. Thanks again for making this port.
cartpole-swingup

cheetah-run

cup-catch

finger-spin

Awesome! If possible, do you mind finding a way to send me all the data once done (checkpoints and results)? Perhaps via a file sharing service, and I'll let you know once I've downloaded it all because it would take a lot of space. I'll also take the rewards and final model and make them available as a release. I've got results for walker-walk, so just kicked off a run for cartpole-balance.

Here are the final test result plots! I'm looking into sharing the checkpoints and result logs.
cartpole-swingup

cheetah-run

cup-catch

finger-spin

Awesome! Do let me know if you do something else with PlaNet, but I think the results are good. I'll close this once you get me all the data.

@sg2 if you still have some capacity would you be able to run the same environments again with the latest commit? Among various improvements I've made changes to the image processing to match what was actually done in the original (I missed some of this originally). Should only take half the time now since I've set the default number of episodes to 1000 like in the camera ready.

Would you also be able to get results for walker-walk and reacher-easy? I've got just about enough space on Google Drive to get the results for all 6 tasks, so just email me and I'll share a folder with you that you can put everything into.

Here are my test results for commit ee9b996.
cartpole-swingup

cartpole-balance

cheetah-run

cup-catch

finger-spin

reacher-easy

walker-walk

Thanks a lot! Uploaded all figures for release v1.0 and v1.1. Unfortunately walker_walk doesn't look that good either. Added notes on discrepancies to v1.0 - would be good if you can pass on the data from both sets of experiments; I'll upload final trained models for both.

No problem, thanks again for the port! Yes, I'll work on getting all the results from v1.0 and v1.1 to you. (I also trained all six agents on v1.0, before doing v1.1.)

Out of curiosity: are these results all comparable to the original PlaNet implementation? Can you explain why the cup-catch performance collapses during the middle of training and then recovers?

Apart from the high variance in cup-catch, which makes it hard to tell without more seeds if it's the same or a bit worse, results with tag 1.0 seem to be comparable. 1.1, which adds the 5-bit quantisation, noise and observation normalisation/centering, and is hence closer to the original, unfortunately seems to be worse on walker-walk and cup-catch. Not sure about cup-catch collapse, but one thing in terms of the task is that it either gets the ball in and gets reward, or not, so the score can vary a lot based on success on this precise task.

@sg2 It's very glad to know  that you have successfully run the entire code. while,when I run the  non-sybolic mode,it always collapses just at 300 or 750 episodes（ the whole episode is 1000 ）. I don't know what's the reason.Would you have met this problem?Thank you very much.

@longfeizhang617 I'm sorry to hear that. What environment are you training? Also did you continue to let it run? You can see in my last result plots that it collapses for cup catch and then recovers. I never saw it collapse and then stay collapsed forever.

@sg2 Thanks for your attention.the default environment of training is Pendulum-v0. I suspect that  planner part caused the memory overflow and thus the error,but i'm not sure.I have decreased the experience_size to be 100000(the oriainal is 1000000),and changed the batch-size/chunk-size/overshooting-distance from 50 to 30.While,the issue is still stayed.Is the experiment condition  limiting the result ? My experiment condition includes a 16G memory , a GeForce GTX 1080Ti GPU.

@longfeizhang617 I added support for Gym environments for people to try PlaNet without needing MuJoCo. However the original paper only includes experiments for DeepMind Confirm Suite, so you would have to tune hyperparameters for any other environment. I'll make a note on the README.

@Kaixhin Thank you sincerely. I really haven't got the licenses of MuJoCo,so I  just try Planet in Gym environment .You have inspired me that it  maybe collapsed because of the mismatching of hyperparameters. I will try to tune hyperparameters.These days,I also communicate  with others,at first,i suspect that there is somthing wrong in the iteration of the code,but @sg2 have accomplished it ,so i have to try more. It's really headless.

@Kaixhin @xsamgreen Do you have approximate training time stats for single/multi GPU setup  on any of the symbolic environments ? It'd be really helpful to have training stats for a few envs(symbolic or otherwise) in the readme. Btw, thank you for the code and experiments, they're really helpful !!


vimPlugins.coq_nvim: add python dependencies

Description of changes
The coq_nvim plugin tries to install python dependencies at runtime:

https://github.com/ms-jpq/coq_nvim/blob/1efb66d5e73cf984aeacc6792143712452a7925f/coq/__main__.py#L84
https://github.com/ms-jpq/coq_nvim/blob/e393fcd177ab6f5259e75af4b134968535cc0b8c/lua/coq.lua#L113

This PR ensures that those dependencies are met by packaging them properly.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 223056 run on x86_64-linux 1

1 package built:

vimPlugins.coq_nvim

What I suggest is basically
Parse the version from the pip file
For each of the two packages, create an attrset which the keys are the version and the value is the hash and index it with the version you parsed from the pip file
If upstream change the version in the requirements.txt then the build will fail in eval time and someone will have to put the hash of the new version in the attrset.

@lucasew
Ok, I get what you mean. However it seems very artisanal to me.
I am not able to find any similar approach in nixpkgs.
Moreover, I cannot thing of an easy way to parse the requirements file.
Would you do it manually (readFile + string manipulation + list filtering etc) ?

What I suggest is basically
Parse the version from the pip file
For each of the two packages, create an attrset which the keys are the version and the value is the hash and index it with the version you parsed from the pip file
If upstream change the version in the requirements.txt then the build will fail in eval time and someone will have to put the hash of the new version in the attrset.

@lucasew Ok, I get what you mean. However it seems very artisanal to me. I am not able to find any similar approach in nixpkgs. Moreover, I cannot think of an easy way to parse the requirements file. Would you do it manually (readFile + string manipulation + list filtering etc) ?

Yes

Yes

All right. I am sorry however, because despite trying for a while now I am not able to come up with a working implementation.
Could you please give me some hint / resource to help me getting started ?

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/how-to-package-neovim-plugin-with-python-application/14683/2

Yes

@lucasew
I think that I managed to implement what you had in mind.
Is it OK for you ?

bumping, it would be sweet to get this merged.

Same. It's working so Nice here
I'm literally only using a patched nixpkgs workaround because of this

The only blocker of this PR is the fact that the licenses for the two python dependencies is unknown.
I asked the maintainer for clarification but I had no answer... Hence it seems that is is not feasible/legit to add those packages to nixpkgs.
Relevant issues:

https://github.com/ms-jpq/pynvim_pp/issues/4
https://github.com/ms-jpq/std2/issues/2

As an intermediary measure you can define the license as unfree and when the author clarifies the license someone make a follow up PR fixing it.

ill update the deps to have a free license maybe tonight?
sorry for being AFK, been super busy with life

From CONTRIBUTING.md

If there is no upstream license, meta.license should default to
lib.licenses.unfree.

Em ter., 16 de mai. de 2023 19:21, i love my dog @.***>
escreveu:

ill update the deps to have a free license maybe tonight?
sorry for being AFK, been super busy with life
—
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/223056#issuecomment-1550432784,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADXXO6EJIYS6XWOBFPIKBWLXGP4X5ANCNFSM6AAAAAAWHPFELU
.
You are receiving this because you were mentioned.Message ID:
@.***>

done, license added. and just as an aside, ill start making updates to coq.nvim soon when im back from traveling aboard

oh ok so I just updated the deps on there :)


Retrieve correct filenames

magzdb version: 1.1.6
Python version: 3.9.2
Operating System: Debian Current Latest

Description
At Компьютерра 2009 № 47-48 (811-812) have Download link and saves it as [Компьютерра _811-812 2009-47-48] - (2009) - libgen.li.pdf, but magzdb saves it as get.phpdirecttruemd5fd5635dd40e1a4feb490db8bac3e384b.
Can you fix it?
Thanks.

Thanks for using magzdb, will release a fix as soon as I get time.

What you think about SuperBike Magazine 2014 № 12 (18) download link which redirect to web.archive.org archived page?

@Coool The link you specified redirects to a webpage, we can dump the webpage?

What do you suggest to do with redirect to archive and HTML pages? How name them?

I think the name provided by magzdb "SuperBike Magazine 2014 № 12 (18)" should be used

OK. Archived and HTML pages save as {Magazine Title}.html
Have you thought about  get.phpdirecttruemd5fd5635dd40e1a4feb490db8bac3e384b issue? How to retrieve filename?


update deprecated fields in kustomization documentation

Description
fixes this #48782
Issues
Closes: #48782

Hi @iheartNathan , I am the PR wrangler shadow for this week (Dec 1) and I am helping to review this PR. This is my first time reviewing a PR.

/lgtm

/assign @salaxander


Ref A: B548D00CA7A9478BAE9635C55B3ECF07 Ref B: DXB30EDGE0113 Ref C: 2023-06-12T23:54:55Z

Hi
This doesn't look like a real issue. Please provide meaningful description if you encounter an issue.
Thanks


When system updates, Star Wars skills get re-added to skill list for not Star Wars skill sets.

Unable to reproduce.  Will reopen if with more information we are able to reproduce.  There is a workaround,
After the update make sure you set the sheet in settings, then create a copy of the actor, the copy should have the skills from whatever sheet you set it to.
Make sure everything is correct and delete the old sheet.


Augment the list of known gardener extensions

How to categorize this PR?

/area open-source
/kind enhancement
What this PR does / why we need it:
Meanwhile, the gardener ecosystem has grown and there are even more extensions! 🎉 🚀
Shoutout to our community members who developed these extensions! 🥳
Also, we have fully moved to the new DNSRecord extension resource, so update the list accordingly.
Special notes for your reviewer:
cc @schrodit @NotTheEvilOne @gesslein @JensAc @MartinWeindel

/approve
/test pull-gardener-e2e-kind
/lgtm


Issues when running on nodes in a subnet with no internet egress access

Certain endpoints like tagging or autoscaling don't have a PrivateLink VPC Endpoint counterpart (or I am missing something) - which means that the controller is unable to operate in a subnet that has zero egress access.
These endpoints could be probably reverse proxied independently by whoever is operating the infrastructure - either by setting up an API gateway or using any kind of proxy server such as nginx or haproxy, but that would mean the endpoint having a different hostname, which makes me wonder how viable would it be to have an option to specify custom endpoints for AWS services? (i.e, have the controller look for the tagging endpoint a custom given URL rather than the standard "tagging.{region}.amazonaws.com")
Obviously, this seems more like an AWS limitation than anything else and it would be nice for them to provide the missing private endpoints.

/close


placement group for autoscaling nodes

As of now, placement groups are not getting created for the autoscaling pool. Can you please create a place group for autoscaling nodes and so we can avoid downtime.

This is not possible at the moment because it's not supported by the cluster autoscaler yet.


Use nindent for conditional yaml insertions

When inserting indented yaml, for the extraEnv option, it's currently being appended without a newline because of the - used to collapse whitespace on the if statement. This leads to an invalid deployment.
For example, helm template buildkite --set agent.token=abc --set extraEnv="{name: test, value: test2}", results in:
         env:
            # BUILDKITE AGENT ENV VARS
            - name: BUILDKITE_AGENT_TOKEN
              valueFrom:
                secretKeyRef:
                  name: RELEASE-NAME-buildkite
                  key: agent-token
            - name: BUILDKITE_AGENT_META_DATA
              value: "role=agent"
            # EXTRA BUILDKITE AGENT ENV VARS            - 'name: ''test'''
            - ' value: ''test2'''

This PR switches from using the indent helper to nindent, which prepends a newline to the indented yaml.

LGTM


metal workflow and ARKIT

Hi !
I wonder if the metal workflow you are implementing in the repo is compatible with ARKIT ?

@hugoliv
I didn't consider ARKit before. So if you test on ARKit and share it, I'll appreciate it.


VACMS-14824 pagination

Description
Relates to #issueid. (or closes?)
Testing done
Screenshots
QA steps
- [ ] I am a thing

Closing this PR in favor of #155


Explicitely use python2

Some distributions are using python3 as the default python.
On those ones, we need to explicitely use python2.

@twiest : We already discussed that change in PR #46 but I’ll try to split #46 in smaller changes.
I copy my explanation here for reference:
We need it on bleeding edge distributions on which python is a symlink to python3.
On my Arch Linux, without that patch and with #!/usr/bin/env python, I get the following error:
    print data_to_print
                      ^
SyntaxError: Missing parentheses in call to 'print'

The full story has been discussed on Ansible’s github there:
https://github.com/ansible/ansible/issues/2974
In short, for the distributions where python is python3,

the install script will take care of patching the shebang,
the version of the interpreter used on minions can be overridden thanks to ansible_python_interpreter
But as this file is shipped directly in this repo, it gets no chance to be "fixed".

For posterity, it is known that we are changing upstream scripts (ec2.py and gce.py), and as such each time we update those scripts we will need to make these same modifications.
It is also known that the person who's updating the scripts will likely forget to make these changes, and that there will therefore need to be additional PRs filed to fix these.
With those above caveats (and complaints as I hate modifying upstream code like this),
:+1:

The point is that today, the script fails on Arch with a rather unhelpful message:
$ ./cluster.sh create test

Creating 1 openshift-master instance(s) in AWS...
Clearing inventory cache... Done.
Traceback (most recent call last):
  File "/usr/bin/ansible-playbook", line 324, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/usr/bin/ansible-playbook", line 160, in main
    inventory = ansible.inventory.Inventory(options.inventory, vault_password=vault_pass)
  File "/usr/lib/python2.7/site-packages/ansible/inventory/__init__.py", line 118, in __init__
    self.parser = InventoryScript(filename=host_list)
  File "/usr/lib/python2.7/site-packages/ansible/inventory/script.py", line 49, in __init__
    self.groups = self._parse(stderr)
  File "/usr/lib/python2.7/site-packages/ansible/inventory/script.py", line 57, in _parse
    self.raw  = utils.parse_json(self.data)
  File "/usr/lib/python2.7/site-packages/ansible/utils/__init__.py", line 551, in parse_json
    results = json.loads(data)
  File "/usr/lib/python2.7/json/__init__.py", line 338, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python2.7/json/decoder.py", line 366, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python2.7/json/decoder.py", line 384, in raw_decode
    raise ValueError("No JSON object could be decoded")
ValueError: No JSON object could be decoded

The Arch behavior is described in PEP 394
Here is an extract of the PEP:

for the time being, all distributions should ensure that python refers to the same target as python2 .
however, end users should be aware that python refers to python3 on at least Arch Linux (that change is what prompted the creation of this PEP), so python should be used in the shebang line only for scripts that are source compatible with both Python 2 and 3.
in preparation for an eventual change in the default version of Python, Python 2 only scripts should either be updated to be source compatible with Python 3 or else to use python2 in the shebang line.

From Ansible point of view (issue #2974),

If Arch is the host from where Ansible is run, distutils takes care of patching the shebang at install time.
If Arch is the minions being configured, ansible_python_interpreter can be use to force use of python2.

The problem I have here is with ec2.py and gce.py scripts which are copied from Ansible and checked in here. So, it doesn’t fall in the two above cases.
The problem you describe is coming from the fact that those files are manually copied from outside and checked in.
They should always be automatically fetched from upstream by a piece of script, let’s say at the beginning of cluster.sh, instead of being manually re-synchronized from time to time.
That piece of script could take care of making those scripts more portable just after having fetched them.

We can't rely on cluster.sh because we do not always run these playbooks using cluster.sh.
Here are the use cases that we use all the time.

Run from cluster.sh
Run from cloud.rb directly
Run using ansible-playbook (both OPS and OSE to do it this way)
Run from tower (near future for OPS)

Therefore we can't have a script download them.
And if cluser.sh did download these, I assume you'd also want it to patch the shebang. Otherwise it'd have the exact same problem these versions have.
Also, if we're automatically fetching them from upstream, we can't guarantee they will be compatible with our scripts. We just updated the gce.py script manually and it broke this command './cloud.rb gce list'.
I wish these were shipped with the ansible RPM, but they simply aren't, so this is the best other way to get everything we want.
Now, all that being said, I did :+1: it above, I just wanted to document for posterity that we are aware of the issues of doing it this way.

@twiest eventually, it would be nice to see the dynamic inventory scripts being shipped with the ansible package itself, then we could just ensure that a symlink exists to the latest packaged version without having to manually maintain a copy ourselves.

@lhuard1A What about a step to have cluster.sh (or even cloud.rb) detect that it is being run on a host that doesn't have python2 as the default python, then it could verify that python2 is installed and either manipulate the path variable to set the python2 path before the system python path, or it could create and instantiate a virtualenv for python2?

@detiber : Thanks for the suggestion about virtualenv!
I implemented it in 361d5ea. Could you check if it is well what you had in mind?
It has the advantage of making cluster.sh work for me without requiring to patch a lot of files.
It has the disadvantage of fixing only cluster.sh.
@twiest pointed out the fact that people may also call cloud.rb or ansible-playbook directly. These use cases are not fixed.

@lhuard1A does that mean you no longer need this PR?

@twiest : I need this PR.
If don’t like the idea of patching the shebang of the gce.py and aws.py files and reject this PR, I can open another PR (or amend this one) with the virtualenv stuff proposed by @detiber in order to have 361d5ea merged upstream.
I would prefer to have this PR merged because it fixes all the use cases (use of cluster.sh, cloud.rb and ansible-playbook) whereas the virtualenv stuff fixes only the use of cluster.sh.

@lhuard1A @twiest I think I found a better solution...  Ansible has an environment variable to specify the python path for hosts that do not have /usr/bin/python default to python2. Setting ansible_python_interpreter to the path of the python2 binary should be sufficient for the ansible-playbook method. http://docs.ansible.com/intro_inventory.html#list-of-behavioral-inventory-parameters
Also, we should probably honor the same variable within the ansible-helper script to invoke any python scripts using the specified interpreter.

@detiber My understanding was that ansible_python_interpreter was only for the python interpreter to use on remote hosts.
Let’s say that I’m on my_workstation where I run ansible to provision the machine my_remote_server.
Machine
my_workstation     1.  ansible-playbook                 # python interpreter chosen at ansible installation
my_workstation     2.  +-> lib/aws.py                   # problematic
my_workstation     3.  +-> ssh my_remote_server python ~/.ansible/tmp/…
my_remote_server   4.      +-> python ~/.ansible/tmp/…  # python interpreter chosen by ansible_python_interpreter

ansible-playbook is run from my_workstation. I can rely on the packager of my distribution to have installed ansible so that it works seamlessly on my machine. Concretely, distutils will take care of putting an appropriate shebang on what it installs.
ansible works by pushing scripts to the provisioned machine and executing them via ssh.
The remote script runs on my_remote_server over ssh. The python interpreter to use on my_remote_server can be customized thanks to the ansible_python_interpreter variable attached to that host in the inventory.

If my_remote_server was a machine with the default python pointing to python3, we could have set ansible_python_interpreter on my_remote_server to point to a python2.
In our case, our roles/playbooks are very “RedHat based distribution oriented” (Use of yum, etc/sysconfig layout, etc.). And on those “RedHat based distributions” we don’t have that issue.
The problem is mostly for 2. lib/aws.py. It is run of my_workstation. So, it is not affected by ansible_python_interpreter. It is not either installed with the ansible package.

@lhuard1A ah, you are indeed correct. I'm good with changing the #! line for now, I think we'll need to tackle it more directly in the future though. Especially since we'll be replacing cloud.rb with a python script.

@twiest +1 to merging this

:+1:  with the caveats I listed previously.


add metric_type to datamodel.MetricResult

From https://github.com/SolarArbiter/solarforecastarbiter-core/pull/426#issuecomment-627605720

...adding a forecast_type (or metric_type) to MetricResult (like https://github.com/SolarArbiter/solarforecastarbiter-api/pull/237/files) will be enough information for the reports to know how to proceed

Seems reasonable, but TBD if this really required for reports. Putting it here so that the idea is not buried when I close #426.

I considered this for #467 but didn't find it useful. I guess there might be some other application, but I recommend closing this issue unless/until that application comes up.


⚠ Bofrost.be has degraded performance

In bd224c3, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1140 ms

Resolved: Bofrost.be performance has improved in 756f00e after 6 minutes.


plugin.xml is still using the old "framework" tag with type "podspec"

Your Environment

Plugin version: 0.3.0
Platform: iOS
Cordova version (cordova -v): 12.0.0
Cordova platform version (cordova platform ls): ios 7.0.1

Expected Behavior
in the plugin.xml file, there is still the old 'framework' code for the podspec code.
        <framework src="Firebase/Core" type="podspec" spec="" />
        <framework src="Firebase/Firestore" type="podspec" spec="" />

in the 'cordova-background-geolocation-lt' this is already fixed in version 4.13.0
https://github.com/transistorsoft/cordova-background-geolocation-lt/blob/master/CHANGELOG.md#4130--2023-07-12
Actual Behavior
Update the config to support the new "podspec" tag
Context
Use this package with the newest<EMAIL_ADDRESS>version
Debug logs

Logs
Failed to restore plugin "cordova-background-geolocation-firebase". You might need to try adding it again.
Error: Error [ERR_UNHANDLED_ERROR]: Uh oh!
Unhandled error. ('"framework" tag with type "podspec" is no longer supported. Please use the "podspec" tag.')

Is there any update on this? It's been more than a month and we really need this to be fixed


Single-letter words?

I noticed most single-letters (a,b,c, etc) are in the list but it's missing some. Is that purposeful or accidental?

Interesting. I guess I never paid that close attention.
Originally I was looking for a list like this but didn't find any NPM modules for it. I did come across https://github.com/nkkollaw/reserved-subdomains though which is where this list came from.
I'm open to reviewing a PR for modifications to the list.


Feat/example page test option

Please check if the PR fulfills these requirements

[ ] It's submitted to right branch according to our branching model
[ ] It's right issue type on title
[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[ ] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes/features)
[ ] Docs have been added/updated (for bug fixes/features)
[ ] It does not introduce a breaking change or has description for the breaking change

Description

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

애플리케이션 적용 가이드가 있으면 확인해볼 수 있을까요?

tui-doc 버전 업데이트
doc config 수정
exampleTest.js 파일 추가

이렇게 작업하면되나요?~

@jungeun-cho 내일 스크럼때 공유할려고 했는데 미리 url 알려드릴께요

https://nhnent.dooray.com/project/posts/2708774819123933232

리뷰 완료입니다~

[4/2] 리뷰 완료합니다. 고생 많으셨어요~

fixed #373


Jetson agx orin

Hello,
Its possible to install on Jetson agx orin nvidia device ? its a TPU Ubuntu 20.04 in ARM64 (aarch64), with a specific version of pytorch " https://developer.download.nvidia.cn/compute/redist/jp/v511/pytorch/torch-2.0.0+nv23.05-cp38-cp38-linux_aarch64.whl "
if yes, can you explain what i need to change ?
Thanks you in advance

I apologize if I wasn't clear earlier. To summarize:
I'm trying to install vllm-project on an NVIDIA Jetson AGX Orin.
This device operates on Ubuntu 20.04 (tegra 5.10.120), which is an ARM64 version.
The Jetson runs on Python 3.8, and I cannot upgrade to a newer version like Python 3.10 due to specific dependencies on this platform.
It uses a specific version of PyTorch that requires Python 3.8 and is optimized for CUDA on this platform. You can find this version of PyTorch here: [PyTorch link](https://developer.download.nvidia.cn/compute/redist/jp/v511/pytorch/torch-2.0.0+nv23.05-cp38-cp38-linux_aarch64.whl).
I aim to get guidance on making vllm-project work with this particular PyTorch version and the Jetson.

Is it possible to add support for this configuration? If not, could you guide me through the necessary steps to extend the support on my own, such as creating a PR?
Thank you for your understanding.

You can use conda to install the latest python + CUDA versions. Set up a conda environment with conda create -n vllm python=3.11, activate it with conda activate vllm and install CUDA 11.8 with conda install -c "nvidia/label/cuda-11.8.0" cuda. After that, you can simply do a pip install vllm to get started.
If you don't like conda, you can try a python version management software like pyenv or asdf. Regardless, it's never recommended to pollute your system-wide packages with pip installs; always operate within a virtual environment.

After that, you can simply do a pip install vllm to get started

It's not that simple - you will also need a CUDA-enabled PyTorch built for aarch64, which is not available via pip or conda.

Is it possible to install vllm on TPUv5. I want to deploy inference of llm model using vllm on TPU.
TPU-vm configuration:
Operating System: Ubuntu 22.04.2 LTS                         Kernel: Linux 5.19.0-1030-gcp     Architecture: x86-64

anythings update?

怎么解决呢？