lmdb database making and training

Code instructions:

imagenet_bs32_lmdb.py                                                            The config file to deploy lmdb training
data/lmdb/create_lmdb.py                                                          The Port for making LMDB database
mmcls/datasets/lmdb_dataset.py                                               LMDB dataset
mmcls/datasets/persistences/persist_lmdb.py                           Core file of persisting LMDB

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.robert seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @huiyang865, could you please use English for your commits and comments? Because most of the mmclassification users can not understand Chinese.
As for the codes, please notice that:

make sure you passed the pre-commit check.
add unit tests for newly added features.
do not revise the default setting, e.g. in configs/imagenet/resnet18_b32x8.py.
follow the original design, e.g., use argparse, instead of click.

Hi @huiyang865, could you please use English for your commits and comments? Because most of the mmclassification users can not understand Chinese.
As for the codes, please notice that:
1. make sure you passed the pre-commit check.

2. add unit tests for newly added features.

3. do not revise the default setting, e.g. in `configs/imagenet/resnet18_b32x8.py`.

4. follow the original design, e.g., use `argparse`, instead of `click`.

I have formatted my code with pre-commit, and add an unit test code with test_make_lmdb.py file, also replace the 'click' with 'argparse'.
Thanks for your suggestions.

Close this PR since there are no updates for a long time. Thanks.


Error loading document

Help me !.......

Have the same error

Have the same error

Do you know how to fix it?

Hi @MinhTamNT @Richouf95 👋🏻
Thanks for reporting the issue 🙏🏻
We have identified the issue and released a fix a few minutes ago (at 10:00 AM CEST).
You should now be able to see your storage again and delete it as well.
Please let us know if everything is good on your side and I will close the issue 🙂
Thanks!
Aurélien

That's why I currently have access to my data.
Thank you for your efforts
Le jeu. 19 sept. 2024 à 09:13, Aurélien Dupays Dexemple <
@.***> a écrit :

Hi @MinhTamNT https://github.com/MinhTamNT @Richouf95
https://github.com/Richouf95 👋🏻
Thanks for reporting the issue 🙏🏻
We have identified the issue and released a fix a few minutes ago (at
10:00 AM CEST).
You should now be able to see your storage again and delete it as well.
Please let us know if everything is good on your side and I will close the
issue 🙂
Thanks!
Aurélien
—
Reply to this email directly, view it on GitHub
https://github.com/liveblocks/liveblocks/issues/1944#issuecomment-2360292673,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXSPZOSYZTFDIAHKBIJUJPTZXKBUFAVCNFSM6AAAAABOLVXTQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRQGI4TENRXGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

Great to hear it! 🙏🏻
Closing the issue then 🙌🏻


pypi release is broken

robotframework-jsonlibrary release 0.2 is broken on pypi - but looks like relative imports are fixed on github master...  can you push the fix out as new release to pypi please? :-)
$ pip install robotframework-jsonlibrary
Collecting robotframework-jsonlibrary
Using cached https://files.pythonhosted.org/packages/e0/3c/609d90b967905c0b5c90f736666531e025756e71f3d538546cabff61ef3e/robotframework-jsonlibrary-0.2.tar.gz
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "", line 1, in
File "/tmp/pip-build-ct5ux1vz/robotframework-jsonlibrary/setup.py", line 5, in
from JSONLibrary.version import VERSION
File "/tmp/pip-build-ct5ux1vz/robotframework-jsonlibrary/JSONLibrary/init.py", line 2, in
from JSONLibraryKeywords import JSONLibraryKeywords
ModuleNotFoundError: No module named 'JSONLibraryKeywords'
----------------------------------------

Meanwhile you can install directly from master: pip install https://github.com/nottyo/robotframework-jsonlibrary/archive/master.zip

I Found some missing  in python file init.py on https://pypi.org/project/robotframework-jsonlibrary/ and this repo. It make error at same first comment. I think need to rebuild this repo to release at pypi again.

@p-sherratt please update   https://pypi.org/project/robotframework-jsonlibrary/0.3/

please update version to v0.3


reorganize project files and add dependency management logic

Description of the change:

internal/pkg/scaffold/project: move non-go project file scaffolds here
internal/pkg/scaffold/internal/deps/print_dep.go: utilities for print-deps
cmd/operator-sdk,pkg/test: rename imports

Motivation for the change:

The number of scaffold files in internal/pkg/scaffold is large, so moving non-go files related to scaffolded projects into internal/pkg/scaffold/project makes sense.
As we'll be adding support for go mod in #1001, I took some changes that added dependency manager selection logic and refactored them here.

If we are moving the test files, I would like to take this moment to argue against test files. This to me seems to usually just cause me to update things in two places and doesn't really test anything. I would prefer that we make sure the Execute function is thoroughly tested and assume that a static string will behave correctly.

@shawn-hurley you're talking about internal/pkg/scaffold/*_test.go files? They're useful to make sure output is formatted properly and there are no template issues. Plus we can check if all templates are correct with unit tests instead of waiting for a full e2e test.

@shawn-hurley I understand and agree on your point about the test files. How about we just check the generated templated output is as expected, instead of the entire file? But this might be out of the scope of this PR, so maybe we can discuss in an issue?


Remove UnicodeMixin

Fixes #135

Thanks for the PR. But as long as pyclts supports py2 as well, inheriting from object is not a drop-in replacement for UnicodeMixin. So this fix must be part of a bigger PR, removing py2 support.

@Anaphory just released pyclts 1.3 which fixes this issue.


Flash messaging

Just a thought..
Say I have a situation where I want to set the flash message based on a conditional ( Business Logic ), traditionally this has been set in the controller although do you think it is bad practice to move this into a interaction?
D

I don't think setting flash messages in an interaction is a good practice. Yes, it is business logic, but it's specific to the request.
Does that answer your question? If not, can you provide a more concrete example?

Basically we use a flash message to trigger a piece of javascript in a partial which is renders a receipt page when a user pays for an item on the site ( Spree based site ), and I was trying to put the business logic somewhere.
After much thought I came to the exact same conclusion as you though.
BTW. this is a cracking gem and exactly what we were after... keep up the good work!!

Thanks!


Update deprecated option name on Prysm config

Looks like Prysm team deprecated --http-web3provider (their setup guide is not updated yet) on the latest v3.0.0 release.
You can check it on v3.0.0 release note. (just search 'web3provider')
https://github.com/prysmaticlabs/prysm/releases/tag/v3.0.0
'--http-web3provider' was replaced with '--execution-endpoint'

Thanks for this correction. Merging.


PRNG not seeded.

Wavelet uses the default source from math/rand package, which is not seeded by default. I looked through the source code and I don't see it being seeded anywhere. Not sure if this is intended or not.

It is not seeded by default; there's no specific intention as to why.

I don't think there will be any issues if it's not seeded. As long as the randomness is uniform, Wavelet should work.
Just wondering if it's intentional, because in my experience, when PRNG is used in production, it's usually seeded. Not seeding it (i.e. seeding it with the same value) is usually done for testing purposes.

I don't think there will be any issues if it's not seeded. As long as the randomness is uniform, Wavelet should work.
Just wondering if it's intentional, because in my experience, when PRNG is used in production, it's usually seeded. Not seeding it (i.e. seeding it with the same value) is usually done for testing purposes.

Gotcha, I usually see the opposite. To make sure tests are deterministic, the PRNG is seeded. In production, there is no necessity to seed it.

Is there any resolution to that? Should we seed rand for other than tests usage?

Not seeding is fine.


chore(main): release 0.75.2

:robot: I have created a release beep boop
0.75.2 (2024-11-21)
Miscellaneous Chores

Release 0.75.2 (81f1d84)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

0.75.2
:sunflower:


Unity 2019/2018 split

Since Unity 2019 SDK has changed namespace for AndroidJavaObject et al. and we need to use a different set of DLLs for each version, we need to split development in 2 branches, one for Unity 2019 and the other for Unity 2018. This also implies releasing 2 separate DLLs.
Looking for alternative solutions like preprocessor conditions and having the linker select a different location for Unity DLLs.

The description I wrote is mistaken. It's the assembly where the AndroidJavaObject and friends are located that has changed. The namespace is still the same, so no changes to code.
Branch 2019 contains the correct libraries and configuration for Unity 2019. Since there's no 2019 LTS yet, master branch will refer to 2018 LTS version and 2019 branch will refer to 2019 version.
Fixed in commit fe766d374385e719338120e623d4959b801cbbbc


zIndex not working on ios simulator

zIndex doesn't work on ios :

But working on Android :

any updates?

same issue


Updated version to 3.25.1 to match Sonatype update.

Update for https://issues.sonatype.org/browse/NEXUS-24771

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #5   +/-   ##
=======================================
  Coverage   42.92%   42.92%
=======================================
  Files          18       18
  Lines         424      424
  Branches       25       25
=======================================
  Hits          182      182
  Misses        232      232
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8068bae...c1d2a12. Read the comment docs.


PR: Save project recent files as relative paths in workspace.ini

Description of Changes

When closing a project, recent_files are written to workspace.ini relative to project root_path
Relevant tests changed to expect the recent files fetched from workspace.ini to be relative paths from project root

This allows better portability of projects. Project directories can be moved, or stored in different locations on different systems, and opening the project will still successfully open all the recent files into tabs.
Issue(s) Resolved

Fixes #5491
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: Shannon Keough

Hello @Keou0007! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file spyder/plugins/projects/tests/test_plugin.py:

Line 201:80: E501 line too long (101 > 79 characters)
Line 224:80: E501 line too long (102 > 79 characters)

Please merge with master to get a new set of fixes for our tests.

@goanpeca, please review @Keou0007's work.

@goanpeca Do I need to do anything with this now? I got a notification saying you've assigned it to me, but merging is blocked for me because I'm not authorised.

@goanpeca Do I need to do anything with this now? I got a notification saying you've assigned it to me, but merging is blocked for me because I'm not authorised.

No need, we will merge this tomorrow :-)
Thanks!

Thanks a lot @Keou0007 for your contribution!


Add the @hidden feature.

Similar to the code example in this blog post, we can achieve this effect by adjusting the opacity.

Referring to the @highlight syntax, I have implemented the @hidden syntax to achieve this effect.

+1 for this idea, and thanks for your contribution.
will leave comments on PR


Fundamental: why a Solid Profile spec?

In this issue, I would like us to seriously reconsider the fundamental raisons d'être of the document being drafted here.
While it describes itself as a specification, the most voiced foundation seems to be to describe and preserve the way a limited subset of people currently use a number of other drafts within the Solid ecosystem. I do not have anything against current practices informing certain drafts, but I do think that specifications should start in a more specific need, and should be drafted based on arguments (e.g. use cases and technical considerations) rather than conservatism.
One concrete problem with the above genealogy, is that the document tries to do to many things at once. This causes it to be neither unique in its separate purposes, nor succesful in doing any of them very well. Especially, it results in each of these purposes being more tightly bound to others than necessary, which violates the principle of orthogonality, and thus complicates expandibility and compatibility. Therefore, I would like to propose us to split this document according to those specific needs that are found within the practices described, in order to tackle them separately, informed by current practices but based on sturdy arguments, and in cooperation with other drafts tackling the same problems.
Note that this is not only an issue of the WebID-Profile spec, but also of SAI, for example. Both contain too many pieces that overlap and could be merged into several smaller specs. Lots of powerful mechanisms on the Web work because of very small specs being able to work together.

A possible separation of concerns could look as follows.

A primary document should focus on authorization and application registrations, as suggested in https://github.com/solid/webid-profile/issues/62. The goal there should be to provide apps with a simple step from the identity of a user to a separate (sub)sphere where information can be found pertaining to the user's relation to that specific app. In other words: the application registration becomes the Profile extended with what that specific app needs and is allowed to.

Following the definitely justified separation of type indexes, and the issues raised in #65, a central discussion is remains how agents can discover where to access data. It remains important to note, however, that SAI is also looking into it, and most of both drafts are almost identical. Pooling the insights of both would prove much more valuable. Building this pooled insight on top of [1] is a must i.m.o.

We should remove the sections concerning the discovery of identity providers, storages and inboxes, as suggested in https://github.com/solid/webid-profile/issues/63. If still necessary, e.g. as minimal interoperability bundle,  we could form a (mini)spec addressing this.

If still wanted after #61 and #64, this repo/document could continue to work on a way to provide some social media extension of the WebID Document, taking into account [1] and [2].

Apart from the normative documents in [1]-[4], a separate non-normative document could continue to describe current practice for a purely informative purpose.

EDIT: added [5].

This feels like somehow a duplicate of https://github.com/solid/webid-profile/issues/63 and maybe also https://github.com/solid/webid-profile/issues/64. Can I ask you to combine them in one of the issues and close the others? Or I might have misunderstood the content of them, in which case, would you mind revising the title and have it be a clear summary of what your requested change/action is?


Improve docs of softplus

This is PR for improving docs of functions/links. Related issue: #2182
Modified functions/links:

functions/activation/softplus

I fixed the docstrings as mentioned above. Please merge after the test is passed.

I checked doctest and it's okay.
...

Document: reference/functions
-----------------------------
1 items passed all tests:
  87 tests in default
87 tests in 1 items.
87 passed and 0 failed.
Test passed.

...

Doctest summary
===============
  308 tests
    8 failures in tests
    0 failures in setup code
    0 failures in cleanup code
build finished with problems, 9 warnings.
make: *** [doctest] Error 1

I rebased the branch against master. pls rerun the Jenkins test.

LGTM


Flaky test: Test_CommunicationCycle (pod %v entered a failing state)

Bug information
This is a result of a scheduled functional test failure.
=== FAIL: test/functional/shared/mechanics Test_CommunicationCycle/deploy_testdata/corerp-mechanics-communication-cycle.bicep (45.98s)
    rptest.go:272: running step 0 of 1: deploy testdata/corerp-mechanics-communication-cycle.bicep
    deployexecutor.go:80: deploying deploy testdata/corerp-mechanics-communication-cycle.bicep from file testdata/corerp-mechanics-communication-cycle.bicep
    cli.go:468: [heartbeat] command rad deploy /home/runner/work/radius/radius/test/functional/shared/mechanics/testdata/corerp-mechanics-communication-cycle.bicep --parameters magpieimage=ghcr.io/radius-project/dev/magpiego:pr-d7e4954362 is still running after 10.000188315s
    cli.go:468: [heartbeat] command rad deploy /home/runner/work/radius/radius/test/functional/shared/mechanics/testdata/corerp-mechanics-communication-cycle.bicep --parameters magpieimage=ghcr.io/radius-project/dev/magpiego:pr-d7e4954362 is still running after 20.001[94](https://github.com/radius-project/radius/actions/runs/6558296793/job/17811811945#step:23:95)9075s
    cli.go:468: [heartbeat] command rad deploy /home/runner/work/radius/radius/test/functional/shared/mechanics/testdata/corerp-mechanics-communication-cycle.bicep --parameters magpieimage=ghcr.io/radius-project/dev/magpiego:pr-d7e4[95](https://github.com/radius-project/radius/actions/runs/6558296793/job/17811811945#step:23:96)4362 is still running after 30.002004769s
    cli.go:468: [heartbeat] command rad deploy /home/runner/work/radius/radius/test/functional/shared/mechanics/testdata/corerp-mechanics-communication-cycle.bicep --parameters magpieimage=ghcr.io/radius-project/dev/magpiego:pr-d7e4954362 is still running after 40.002593002s
    cli.go:415: [rad] Building /home/runner/work/radius/radius/test/functional/shared/mechanics/testdata/corerp-mechanics-communication-cycle.bicep...
    cli.go:415: [rad] Deploying template '/home/runner/work/radius/radius/test/functional/shared/mechanics/testdata/corerp-mechanics-communication-cycle.bicep' into environment 'kind-radius' from workspace 'kind-radius'...
    cli.go:415: [rad]
    cli.go:415: [rad] Deployment In Progress...
    cli.go:415: [rad]
    cli.go:415: [rad]
    cli.go:415: [rad] Deployment Complete
    cli.go:415: [rad]
    cli.go:415: [rad] Resources:
    cli.go:415: [rad]     corerp-mechanics-communication-cycle Applications.Core/applications
    cli.go:415: [rad]     cyclea          Applications.Core/containers
    cli.go:415: [rad]     mechanicsg      Applications.Core/containers
    cli.go:415: [rad]     routea          Applications.Core/httpRoutes
    cli.go:415: [rad]     routeb          Applications.Core/httpRoutes
    cli.go:415: [rad]
    deployexecutor.go:84: finished deploying deploy testdata/corerp-mechanics-communication-cycle.bicep from file testdata/corerp-mechanics-communication-cycle.bicep
    rptest.go:274: finished running step 0 of 1: deploy testdata/corerp-mechanics-communication-cycle.bicep
    rptest.go:282: validating output resources for deploy testdata/corerp-mechanics-communication-cycle.bicep
    rptest.go:284: finished validating output resources for deploy testdata/corerp-mechanics-communication-cycle.bicep
    rptest.go:289: no AWS resource set was specified, skipping validation
    rptest.go:304: validating creation of objects for deploy testdata/corerp-mechanics-communication-cycle.bicep
2023/10/18 08:49:07 validating objects in namespace default-corerp-mechanics-communication-cycle
    k8s.go:364: Checking pods in default-corerp-mechanics-communication-cycle with map[radapp.io/application:corerp-mechanics-communication-cycle radapp.io/resource:mechanicsg]
    k8s.go:371: Checking pod: default-corerp-mechanics-communication-cycle:mechanicsg-5776f5fcbb-bs9gg
    k8s.go:374: Pod is ready default-corerp-mechanics-communication-cycle:mechanicsg-5776f5fcbb-bs9gg
    k8s.go:364: Checking pods in default-corerp-mechanics-communication-cycle with map[radapp.io/application:corerp-mechanics-communication-cycle radapp.io/resource:cyclea]
    k8s.go:371: Checking pod: default-corerp-mechanics-communication-cycle:cyclea-555785b758-h8m2n
    k8s.go:374: Pod is ready default-corerp-mechanics-communication-cycle:cyclea-555785b758-h8m2n
    k8s.go:371: Checking pod: default-corerp-mechanics-communication-cycle:cyclea-5d88677d89-fvhdx
    k8s.go:452: watching pod cyclea-5d88677d89-fvhdx for status.. current: {Failed [{Initialized True 0001-01-01 00:00:00 +0000 UTC 2023-10-18 08:48:55 +0000 UTC  } {Ready False 0001-01-01 00:00:00 +0000 UTC 2023-10-18 08:49:10 +0000 UTC PodFailed } {ContainersReady False 0001-01-01 00:00:00 +0000 UTC 2023-10-18 08:49:10 +0000 UTC PodFailed } {PodScheduled True 0001-01-01 00:00:00 +0000 UTC 2023-10-18 08:48:55 +0000 UTC  }]    <IP_ADDRESS>  [] 2023-10-18 08:48:55 +0000 UTC [] [{cyclea {nil nil &ContainerStateTerminated{ExitCode:2,Signal:0,Reason:Error,Message:,StartedAt:2023-10-18 08:48:56 +0000 UTC,FinishedAt:2023-10-18 08:49:10 +0000 UTC,ContainerID:containerd://53d83ac73caeab67[96](https://github.com/radius-project/radius/actions/runs/6558296793/job/17811811945#step:23:97)c74ebac8d80ba9a5a415ec674ebeeca5ec44dcbda0e915,}} {nil nil nil} false 0 ghcr.io/radius-project/dev/magpiego:pr-d7e4954362 ghcr.io/radius-project/dev/magpiego@sha256:[97](https://github.com/radius-project/radius/actions/runs/6558296793/job/17811811945#step:23:98)a65ed3c12ff01a2f72f9e41a965d3f63c37dd1764f8b3e379f168758c1c784 containerd://53d83ac73caeab6796c74ebac8d80ba9a5a415ec674ebeeca5ec44dcbda0e915 0xc000faff15 map[] nil}] BestEffort [] }
    k8s.go:500:
        	Error Trace:	/home/runner/work/radius/radius/test/validation/k8s.go:500
        	            				/home/runner/work/radius/radius/test/validation/k8s.go:373
        	            				/home/runner/work/radius/radius/test/functional/shared/rptest.go:305
        	Error:      	pod %v entered a failing state
        	Test:       	Test_CommunicationCycle/deploy_testdata/corerp-mechanics-communication-cycle.bicep
        	Messages:   	cyclea-5d88677d89-fvhdx
2023/10/18 08:49:11 Start streaming Kubernetes logs - Pod cyclea-5d88677d89-fvhdx is in state: Failed
    k8s.go:374: Pod is ready default-corerp-mechanics-communication-cycle:cyclea-5d88677d89-fvhdx
    rptest.go:306: finished validating creation of objects for deploy testdata/corerp-mechanics-communication-cycle.bicep
    --- FAIL: Test_CommunicationCycle/deploy_testdata/corerp-mechanics-communication-cycle.bicep (45.[98](https://github.com/radius-project/radius/actions/runs/6558296793/job/17811811945#step:23:99)s)

AB#9904

This caused another test failure https://github.com/radius-project/radius/issues/6652

@ytimocin we can close this issue as well per your comment on https://github.com/radius-project/radius/issues/6566#issuecomment-1896698248?

Yes, we can @kachawla.


Cycle Time Percentages do not reach 100%

Fixed in https://github.com/digitalservicebund/hack-jira-cfd/commit/1e9a5824e756206182ec885bf2bd4fc129388bd3

Forgot to close


Constructor of "State" does not pass on "is_final" to function "setup"

The constructor is the following:
State::State(String name, CallbackFunction on_enter, CallbackFunction on_state, CallbackFunction on_exit, bool is_final /* = false */) {
  setup(name, on_enter, on_state, on_exit);
}

You can see that is_final is not passed on to setup.

Thanks!


Buffers build up on session over time

There are tons of badd lines in one of my main habitats now.

Might fix: https://neovim.io/doc/user/options.html#'sessionoptions'

Fixed in f61f87f7c2a29947ecbee5ad1c626650be50c7d7


[haproxy] Update description regarding EOL dates

Add a paragraph to mention<EMAIL_ADDRESS>and explain how endoflife.date is dealing with that issue (see also #661).
I also took the opportunity to normalize the page (#2124).

Thoughts on using a callout for such notices?

Thoughts on using a callout for such notices?

Nope, but that's a very good idea. Do you know if it is available on the current version of JTD ? Or is it a new feature of the last version ?

New Feature, not present in old docs. (Ref for the 0.3.3 docs link)

New Feature, not present in old docs. (Ref for the 0.3.3 docs link)

OK, will open an issue after it's being merged. Maybe we could also have a default section explaining what are our sources for each products ?

Maybe we could also have a default section explaining what are our sources for each products ?

I'd like to just use markdown citations/footnotes, with slightly different formatting to avoid issues we'd noticed earlier.


As a teacher, I want to be able to edit grades of students so that I can change students marks after reviewing

so that I can change students marks after reviewing


installation: remove invenio-records-permissions from setup.py

https://github.com/inveniosoftware/invenio-communities/blob/v2.3.2/setup.py#L69
Instead we rely on invenio-rdm-records.

Check properly bootstrapping an InvenioRDM v4 instance. I recall adding this pin because otherwise the locking process was breaking due to an incoming version of >0.12 (from records-resources somehow?)


brew Directive: Cannot Install URL Formulae Due to Case Sensitivity

The brew command allows one to use a formula at a URL. For example:
brew "https://raw.githubusercontent.com/Homebrew/homebrew-core/f1a767645f61112762f05e68a610d89b161faa99/Formula/elasticsearch.rb"

Given a server that respects case sensitivity in paths, this will not work in a Brewfile because the URL is downcased.
In the given URL, Formula is switched to formula, which results in a 404.
While I'm not familiar with the codebase, it seems the solution is to make HOMEBREW_TAP_FORMULA_REGEX case insensitive. Though not sure what affect this will have on code that uses Entry.

Sorry, it's more or less accident that URL formulae work. I strongly recommend creating and using your own tap instead.

Are URL formulas being depreciated by the brew command? If now, what's the reason for not supporting them?

They are not deprecated but we're not supporting them here because you should create a tap instead.


Group endpoint with the same path prefix

Currently endpoints a grouped by context (controller class in code) where they are situated, f.e
/api/book in class BookController
/api/book in class OneMoreBookController
/api/book/shelf in BookShelfController

Will have 3 groups in html view.
It would be convenient to have one /api/book group for all than endpoints.
NOTE
The deep of the grouping (like /api or /api/book) can be configured or replaced with a tree

Won't fix due to the termination of the Apiator UI


⚠ ClamAV has degraded performance

In 7a79a8e, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 106 ms

Resolved: ClamAV performance has improved in 20be804 after 15 minutes.


Example to use babel generate instead of escodegen

The readme mention that the lib can be user with babel generate, but @babel/generator generate method requires the source as a text as input as far as I see.
Can you please give me some hint or an example how can I use babel generator with lave?

@jed , can you help on this maybe? If you give me a hint, probably I can create the example and submit it as a PR for adjusting readme.


:rocket: Launch version 1.0.0

:arrow_up: Upgrade to libhal/[^1.0.0]. Using ^ to ensure that libhal-util can work any other library with a compatible major number of libhal.
:arrow_up: Upgrade to libhal-util/[^1.0.0]. Using ^ to ensure that libhal-util can work any other library with a compatible major number of libhal.
:arrow_up: Upgrade to libhal-armcortex/[^1.0.0]. Using ^ to ensure that libhal-util can work any other library with a compatible major number of libhal.
:recycle: Refactor code to use latest libhal code
:adhesive_bandage: Fix ordering of toolchain code in demos/CMakeLists.txt
:fire: Remove demo/empty.cpp, because it does nothing and adds no value.

The can.cpp demo needs to be tested before merging this change.

Skipping can.cpp test for now. If there are issues, it can be patched in the next version.


feat: provide named exports api

import {
  Calendar,
  DateLocalizer,
  momentLocalizer,
  globalizeLocalizer,
  move,
  Views,
  Navigate,
  components
} from 'react-big-calendar';

Rebased

the docs and examples need to be updated as well actually


325 parse appellate attachment pages

#325 PR adds new Appellate Attachment parser for Juriscraper.
Parser adds new class AppellateAttachmentPage.
Includes tests for ca1, ca9 and bankruptcy ca1.
Also includes tweak to strip_bad_html_tags_insecure function

I updated the structure as well to drop the dls_id and identify the main document in the first level of the response.  We don't have the same main document w/ attachment structure like in district court.  I hope it is now clearer

Subsumed in https://github.com/freelawproject/juriscraper/pull/358/


add option to check credits like shodan info for all providers

add option to check used or remaining credits like shodan info does, but for all providers.

This is a cool idea @gprime31 - thanks for it


[HapticFeedback] Implement vibrate()

[Before] HapticFeedback.vibrate() was not implemented
[After] The code below will cause a short vibration:
  HapticFeedback.vibrate();

Signed-off-by: Pawel Wasowski<EMAIL_ADDRESS>HapticFeedback.vibrate() was one of the features to implement on this list https://github.com/flutter-tizen/engine/issues/53#issue-837284297
Before building with this change, be sure to use tizen_tools with this commit applied: https://github.com/flutter-tizen/tizen_tools/pull/10
The change will only work on devices that support it. I have tested it on a Samsung Z3 (aka TM1) smartphone with Tizen 6.5.

As this is my first change in flutter-tizen/engine, I'm not sure about the design of my patch. I've tried to follow the contributor's guidelines from the original flutter/engine repo, but I'd like to know your opinion about some things :)

I've put FeedbackManager class implementation in platform_channel.cc. Honestly, I consider it to be a little bit of a code smell, and would rather put this class in separate files (standard .h and .cc combination for declaration and definitions), but I didn't know where to put these files in the repo's source tree. Do you think, I can put them (i.e. feedback_manager.h and feedback_manager.cc) directly in src/flutter/shell/platform/tizen/channels?
From what I've seen, Flutter has no strict rules regarding formulation of error messages. I've tried to make my messages meaningful - have I got it right?


use GetWindowScaleDPI to calculate size for rlReadScreenPixels in sceenshot/recording

On macOS when running on a display with retina resolution or on an external 4k screen, the TakeScreenshot function triggered by F12 and the gif recording triggered by Ctrl-F12 ignore the scaling so they only grab the lower left quarter of the window.
This change uses the factors from GetWindowScaleDPI() to scale width and height to allow the full window content to be grabbed even if scaling is active.
Not sure if there would be need for a check of FLAG_WINDOW_HIGHDPI, from my understanding, the scaling would be needed there to, for other cases if should be a scaling by 1, and the overhead of GetWindowScaleDPI() seems small compared to the gif or png encoding that happens afterwards.

@gulrak I'm afraid there have been many attempts to implement this same solution and everytime it broke some platform in some specific use case. I prefer to let the user manage it manually as required, that's the reason to expose GetWindowScaleDPI() for the user instead of applying it directly by raylib.
Still, I'm not closing the PR, I want to take a closer look to it.

Yeah, I understand the problem, the easy way to reduce that risk would be to tie it to the Plattform, still I'm planning to test it on Windows with and without high dpi flag and scaling and the same on Linux, just need to get some time for it, so no hurry.

@gulrak After cheking this improvement more carefully I decided to merge it.

yay!


Update README.md

few fixes, & a ReadMe update with direct link to download & installation instructions.

@FabianLauer I did as you said, but now what with this pull request?

@FabianLauer, any new ?

@pavittarx I think we had a bit of a misunderstanding regarding https://github.com/FabianLauer/chrome-vs-code/pull/6#issuecomment-393840875 🙂
What I meant was: Can you please open a PR in which you add the link to the VSIX, without any other changes? Thanks! 🙂

@FabianLauer well, I guess, I took it the other way, would you mind me opening a new PR?

Not at all, go for it 👍


WIP: engine-check: remove layers with no container|image refs

The current cleanup mechanisms only remove dangling images
and stopped containers, but do nothing with dangling layers.
Change-type: patch
Signed-off-by: Kyle Harding<EMAIL_ADDRESS>
- What I did
- How I did it
- How to verify it
- Description for the changelog

@robertgzr Hey man, I'm a little stuck at this point. I'm not sure how to access the graphDriver namespaces from engine-check and I've marked those with FIXME. Can you help me out a bit, or present a better way to solve this?

@robertgzr Hey man, I'm a little stuck at this point. I'm not sure how to access the graphDriver namespaces from engine-check and I've marked those with FIXME. Can you help me out a bit, or present a better way to solve this?

When this gets merged, we should update https://jel.ly.fish/b41ce978-088e-420a-9176-8387c9108328 accordingly

Superseded by https://github.com/balena-os/balena-engine/pull/253


QuickCheck tests for IntMap

Added QuickCheck tests for IntMap (didn't have time for more)
Important change in need of approval, we added deriving Eq to Data.UnionFind.IntMap.Point. The only other way to compare the descriptors of the points in the current implementation is to compare descriptors. As it is, only the representative point keep the descriptor, so it is not a very direct means of comparing (but it would possibly turn out correct anyway). A user of the library might also want to be able to compare Points, however, the users shouldn't confuse == with the function equivalence.
Description solution:

test/TestSuite.hs is called by cabal test and itself reference the quickCheck property tests.
test/Common.hs define a model for testing. It is essentially a list of "Calls", a type representing abstract API calls.
test/IntMapProps.hs uses Common as it tests IntMap.

We are two students (@dfurian) enrolled in a advanced functional programming course. We were told to contribute to an open source project and ended up here :) Unfortunately we did not have time to test the whole library, but hope it can be of any use.

IntMap only modifies the state when calling fresh and union, not for repr and equivalence. So the model Call in test/Common.hs only has only this simple definition:
data Call = Fresh Int | Union Int Int

where Int refer to the "id" of a point. But this model can easily be extended to include repr and equivalence


Race condition seen when there are multiple readers and writers

When there are multiple readers and/or writers using the same mbedtls_ssl_context (which is possible in the mbed-client-linux use-case since it has a background data listen thread that continuously performs read operations, and the application thread can independently send 'update registration' or other requests), mutual exclusion should be used to protect the context. For example, this code in mbedtls_ssl_flush_output(), which is called by both mbedtls_ssl_write_record() and mbedtls_ssl_read(), can result in ssl->out_left being corrupted and becoming a huge number (since it is an unsigned int) when reads and writes are performed concurrently:
while( ssl->out_left > 0 )
{
...
     ret = ssl->f_send( ssl->p_bio, buf, ssl->out_left );

     MBEDTLS_SSL_DEBUG_RET( 2, "ssl->f_send", ret );

     if( ret <= 0 )
         return( ret );

     ssl->out_left -= ret;

}

In mbed TLS thread-safe functions are marked as such.
Contexts are only intended to be used from a single thread. If you want to access a context in a multi-threaded way, you'll have to provide the guarding yourself.
See: https://tls.mbed.org/kb/development/thread-safety-and-multi-threading

Thank you for the info. I'll bring this up on the mbed client's forum, since they are the users in this case.

@vanti I am experiencing the same issue, but I would really like to use concurrent read/write operations and lock only when necessary. For some odd reason, I only noticed this issue with DTLS, never with TLS. mbedtls_ssl_flush_output is called from mbedtls_ssl_read() only for DTLS, this could explain it.  Did you solve the issue nicely on your end, or did you end up locking concurrent read/write operations?

@pjbakker is there a particular reason why there is no lock for read and write operations, such that a read operation would acquire the write lock if it needs to write, and prevent such race conditions? This might be enough to make concurrent read/write operations possible, since the vast majority of the execution time, there is no issue with doing them parallel.

@awakecoding None other than that the premise of the design of most mbed TLS contexts is that they are only used within a single thread and thus do not need such locking.

@pjbakker I have started making some changes on my own branch (https://github.com/wayk/mbedtls/tree/wayk). I'm trying to keep the changes clean enough for inclusion later on. mbedtls_ssl_context has a few logical group of member variables that could be locked independently. In my case, I added a lock to protect against a race condition I encountered around the "Record layer (outgoing data)" section (the out_* variables), and it appears to be enough. In theory, I would also need to lock session renegotiation as well, but it is currently disabled in my code. One other thing I did was to extended the mutex API to add support for trylock. mbedtls_ssl_read checks if there is pending data to be flushed, it is better to attempt locking and not bother if we can't lock: if it is already locked, some other thread is already flushing the out data anyway, so we're good. My development is not completed yet, so I can't know if the changes I made are sufficient, but so far I no longer encounter the race conditions I used to have.

@pjbakker since I'm making modifications on my branch, I also added support for configuring the MSVC static runtime, and I also added a Windows mutex implementation using critical sections. I think both would be valuable inclusions.


Slow game for Vehicle simulation 3d in some start

Operating system or device:
manjaro linux 64, drivers ati open
Issue description (what happened, and what was expected):
In some cases the game go slow if I use the vehicle simulation
Steps to reproduce:
create vehicle and terrain and load scene, the bug generate randomly If you play a game, the important is that the bug start from the beginning of played session, the game go incredibly slow.
Link to minimal example project (optional but very welcome):

I'm very sorry but this issue don't seems to be helpful.. In reproduction steps you basically said "create a game with vehicle and expect it to be slow". There are many factors that will determine speed of your program and no-one will be able to guess what you are doing wrong, or what exactly causes your problem if you don't provide some kind of really reproducible steps or at least sample project.
In fact there are couple of quite complicated projects that are using vehicle simulation and their creators never complain on the performance..

Dude.. I at some point agree with @kubecz3k .
1.] Performance is slow.
How can we measure if the game is slow? I guess core i7 vs amd E-450 will give a different result. GPU things (AMD Radeon 6320 vs R7)?
2.] Scenes Complexity matter.
When I use Unity. There is a doc for "how to achieve best performance". I believe every game engine has their own way to manage performance. And I'm pretty sure the more complex => more performance tricks should be done in order to achieve best performance.

I encountered the same issue with a GPU Intel HD 4600.
When the bug happens the scene runs like slow motion. The framerate remains good.
It's weird because I don't know the conditions who make the bug happens.
Just try to restart the scene several times. To save time, put the car a bit in the air, so you can check this immediately.

Two additional findings.
Sometimes any rigid body could be affected by the same issue. Not at the same time than other physics bodies. It seems completely random...
I made a lot of tests in another scene and I can't reproduce the issue anymore.
The scene where the issue happens has a complex collision shape made by the import feature with the  " -col " suffixe. I removed the walls and after that, the issue can't be reproduced.

I would like to step in here and say that I have been experiencing the same issue. It seems like there is no concrete way to replicate this bug, it almost happens completely at random.

I'm not dissaggreeing with anyone, but it's also possible that it could be the vehicle setup itself that is wrong. Please provide an example

The problem on my broken scene was fixed by changing the staticbody collision shape, the vehicle settings remains the same. The old project was deleted so I can't share it anymore.
As I said before the issue happens when the terrain collision shape is generated from a complicated mesh so the 3D model needs to be very clean before using this feature.

Can anyone still reproduce this on 3.2beta3 or later? If so, please upload an example project and link it here.

I'll close this issue as no minimal reproduction project was provided in time. This issue can be reopened if someone uploads a minimal reproduction project.


Missing list of options on Hexo helpers

The default values are shown but not all options are there.

Could you please elaborate?

It was a bit late when I posted this, and it's a bit silly now that I read it. Updated the issue contents in original post !

List helpers now show complete options.
I also added example of transform option.


MIC-435 remove headers for username and source

Codecov Report
Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.47%. Comparing base (021f462) to head (ab1473f).

Files
Patch %
Lines

...nplanapi/config/CsipRequestContextConfiguration.kt
77.77%
0 Missing and 2 partials :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #127      +/-   ##
============================================
- Coverage     87.50%   87.47%   -0.04%
+ Complexity      702      698       -4
============================================
  Files           136      136
  Lines          2185     2171      -14
  Branches        150      145       -5
============================================
- Hits           1912     1899      -13
+ Misses          189      188       -1
  Partials         84       84

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


A gekko watcher crashed.

Note: this is the technical bug tracker, please use other platforms for getting support and starting a (non technical) discussion. See the getting help page for details.
I'm submitting a ...
[x ] bug report
[ ] question about the decisions made in the repository
Action taken (what you did)
Running a paper trader
Expected result (what you hoped would happen)
I wanted to run a paper trader to see how it would perform
Actual result (unexpected outcome)
As soon as i clicked the button "start" a notification came up saying "Disconnected, something happened to either gekko or the connection" and so on, I think you know what messagebox i mean.
Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc)
I've tried searching on the gekko issues page but nothing really usefull found.
On the console it gives the following error:
2018-07-19 22:01 Gekko 2018-07-19-22-01-watcher-775765113616011 started.
--> POST /api/startGekko 200 14ms 1.23kb
RECEIVED ERROR IN GEKKO INSTANCE 2018-07-19-22-01-watcher-775765113616011
This Gekko instance encountered an error and can't continue
2018-07-19 22:01 A gekko watcher crashed.
2018-07-19 22:01 was unable to start.
/home/amnero/gekko/web/state/gekkoManager.js:94
if(event.log) {
^
TypeError: Cannot read property 'log' of undefined
at /home/amnero/gekko/web/state/gekkoManager.js:94:14
at Object.message (/home/amnero/gekko/core/workers/pipeline/messageHandlers/realtimeHandler.js:10:9)
at ChildProcess. (/home/amnero/gekko/core/workers/pipeline/parent.js:28:12)
at emitTwo (events.js:126:13)
at ChildProcess.emit (events.js:214:7)
at emit (internal/child_process.js:772:12)
at _combinedTickCallback (internal/process/next_tick.js:141:11)
at process._tickCallback (internal/process/next_tick.js:180:9)
Running Gekko on Ubuntu 16.04 LTS in a virtual machine, clean.

Thanks for the report. Can you post the last ~20 lines of the log for this watcher? Stored in gekko/logs.

I'd love to see them since I want to know what causes this. Nonetheless I pushed a fix that prevents this from happening in the future (available in develop branch).

Got the same error - seems to be a problem loading sqlite3.
Text of the log:
2018-07-30 16:42:58 (INFO):	Setting up Gekko in realtime mode 2018-07-30 16:42:58 (INFO):	 2018-07-30 16:42:58 (INFO):	Setting up: 2018-07-30 16:42:58 (INFO):		 Candle writer 2018-07-30 16:42:58 (INFO):		 Store candles in a database 2018-07-30 16:42:58 (ERROR):	ERROR LOADING DEPENDENCY sqlite3

That's a different problem, gekko needs a sqlite3 dependency which seems to
have not been installed properly. Please open a new issue and post:

Your OS (and version)
Output of running node gekko --version

On Tue, Jul 31, 2018 at 5:47 AM, Sam Stowers<EMAIL_ADDRESS>wrote:

Got the same error - seems to be a problem loading sqlite3.
Text of the log:
2018-07-30 16:42:58 (INFO): Setting up Gekko in realtime mode 2018-07-30
16:42:58 (INFO): 2018-07-30 16:42:58 (INFO): Setting up: 2018-07-30
16:42:58 (INFO): Candle writer 2018-07-30 16:42:58 (INFO): Store candles in
a database 2018-07-30 16:42:58 (ERROR): ERROR LOADING DEPENDENCY sqlite3
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/askmike/gekko/issues/2338#issuecomment-409022577, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA7MDyzDhvJCqgM_bmltWldz75omo_a6ks5uL371gaJpZM4VXBOn
.

--
PGP key at keybase.io/mikevanrossum
https://keybase.io/mikevanrossum/key.asc


EOF error when there is a GOAWAY response

~~Maybe an error here should fall back to the status code error path:
https://github.com/RobotsAndPencils/buford/blob/master/push/service.go#L184~~

@groob is investigating this issue.
https://github.com/golang/net/blob/master/http2/transport.go#L1592

Here's the full response from GODEBUG=http2debug=2
2016/03/03 11:36:06 http2: Transport failed to get client conn for api.push.apple.com:443: http2: no cached connection was available
2016/03/03 11:36:06 http2: Transport creating client conn to <IP_ADDRESS>:443
2016/03/03 11:36:06 http2: Framer 0xc8204e9800: wrote SETTINGS len=18, settings: ENABLE_PUSH=0, INITIAL_WINDOW_SIZE=4194304, MAX_HEADER_LIST_SIZE=10485760
2016/03/03 11:36:06 http2: Framer 0xc8204e9800: wrote WINDOW_UPDATE len=4 (conn) incr=1073741824
2016/03/03 11:36:06 http2: Framer 0xc8204e9800: read SETTINGS len=24, settings: HEADER_TABLE_SIZE=4096, MAX_CONCURRENT_STREAMS=500, MAX_FRAME_SIZE=16384, MAX_HEADER_LIST_SIZE=8000
2016/03/03 11:36:06 http2: Framer 0xc8204e9800: wrote SETTINGS flags=ACK len=0
2016/03/03 11:36:06 Unhandled Setting: [HEADER_TABLE_SIZE = 4096]
2016/03/03 11:36:06 Unhandled Setting: [MAX_HEADER_LIST_SIZE = 8000]
2016/03/03 11:36:06 http2: Transport encoding header ":authority" = "api.push.apple.com"
2016/03/03 11:36:06 http2: Transport encoding header ":method" = "POST"
2016/03/03 11:36:06 http2: Transport encoding header ":path" = "/3/device/xxx"
2016/03/03 11:36:06 http2: Transport encoding header ":scheme" = "https"
2016/03/03 11:36:06 http2: Transport encoding header "content-type" = "application/json"
2016/03/03 11:36:06 http2: Transport encoding header "content-length" = "46"
2016/03/03 11:36:06 http2: Transport encoding header "accept-encoding" = "gzip"
2016/03/03 11:36:06 http2: Transport encoding header "user-agent" = "Go-http-client/2.0"
2016/03/03 11:36:06 http2: Framer 0xc8204e9800: wrote HEADERS flags=END_HEADERS stream=1 len=132
2016/03/03 11:36:06 http2: Framer 0xc8204e9800: wrote DATA stream=1 len=46 data="{\"mdm\":\"\"}"
2016/03/03 11:36:06 http2: Framer 0xc8204e9800: wrote DATA flags=END_STREAM stream=1 len=0 data=""
2016/03/03 11:36:06 http2: Framer 0xc8204e9800: read GOAWAY len=46 LastStreamID=0 ErrCode=NO_ERROR Debug="{\"reason\":\"BadCertificateEnvironment\"}"
2016/03/03 11:36:06 http2: Transport received GOAWAY len=46 LastStreamID=0 ErrCode=NO_ERROR Debug="{\"reason\":\"BadCertificateEnvironment\"}"
2016/03/03 11:36:06 http2: Framer 0xc8204e9800: read GOAWAY len=8 LastStreamID=0 ErrCode=NO_ERROR Debug=""
2016/03/03 11:36:06 http2: Transport received GOAWAY len=8 LastStreamID=0 ErrCode=NO_ERROR Debug=""
2016/03/03 11:36:06 Transport readFrame error: (*errors.errorString) EOF
2016/03/03 11:36:06 RoundTrip failure: unexpected EOF

Looking at net/http it appears that Debug information from GoAway frames is not returned, but I'm not sure there's an issue here because the apns server is actually returning a NO_ERROR status.

I'm not sure either. http://tools.ietf.org/html/rfc7540

Reproduced the issue here using a development (sandbox) certificate against the production environment.
GODEBUG=http2debug=2 go run main.go -c ../../cert.p12 -d device-token -e production

Using just any old self-signed certificate doesn't trigger the same error.
The device token doesn't need to be valid in this case because it doesn't get that far.

// TODO: deal with GOAWAY more. particularly the error code

https://github.com/golang/net/blob/master/http2/transport.go#L1489

There is a fix to x/net/http2 that should resolve this issue (I need to test it to double check).
https://github.com/golang/go/issues/14627#issuecomment-229209837

Well, it doesn't give an EOF after updating, but still not the error from Apple.
go get -u golang.org/x/net/http2


use HEAD request in Checking()

Hi.
pget requests a GET at first in Checking(). But I think it should be a HEAD request.

Coverage remained the same at 79.21% when pulling 8d8a7b911e1f18b2960a355b67cc4a05a0beaae8 on fujiwara:first-head-instead-of-get into 564e383ad4864249bb75d255d762c0bcfff317df on Code-Hex:master.

I will try GET with Range: bytes=0-0.
Thanks for PR


Include heterogeneous reactions in MusicBox/CAMP output

A heterogeneous/surface reaction is now available in CAMP and MICM. Include these reactions in MusicBox output from the cafe. The configuration format is described here: https://open-atmos.github.io/MechanismConfiguration/reactions/surface.html

Closing as this does not apply to the new version of chemistry cafe.


test: Add cross engine tests using BigQuery target

Prior to this PR all integration tests validate an engine with itself. This is good for proving things like data type and function coverage but doesn't ensure end-to-end comparisons are good.
Based on the assumption that BigQuery is our most mature engine support then we've decided to add cross engine comparisons for other engines to BigQuery. If they all match BigQuery then they should all match each other.
We've used our CORE_DVT_TYPES test table for these comparisons. There will be a requirement for some other cross engine tests, for example for engine specific data types that are not covered by our CORE_DVT_TYPES test table. These can come later via different issues.
I've spun a number of new issues out of this work and left comments in the new tests where workarounds have been implemented.

/gcbrun

/gcbrun

/gcbrun

This looks great. I agree with the route you took to disable the homogenous Hive tests; I wonder if making our Dataproc cluster bigger would help with the slow query time.

I wondered the same. But I don't know if increasing the instance core count will automatically increase the cores available to Yarn or whether we need to change config. And I couldn't figure out how to get into the UI. In short, I gave up and disabled the tests :-D


SQL Server Importer Failure -

Hello @olliefreeman, here are details of the bug I found.
It looks like I am getting a different error from what I reported originally. See below.
Mauro, latest release, SQL importer 5.0.0 version.
Runs on Docker in Windows Server.
On the same Windows Server, there is a SQL server to which I am trying to connect.
Input (3 screens below)

Error in the UI:

Error in Docker console:

However, if I select to Import as New Branch Model Version, and select an existing model, I get the error I sent in the forum. See below:
Error in UI:

Error in Docker console:

I do not know what is the underlying problem, but I guess error messages could be more informative, if possible.
Let me know if you need any further details.
Thanks!

So this is actually 2 errors...the stacktrace does NOT relate to the errors during import, this is a separate issue....one which does also need to be looked at.
There appears to be a bug in importing as new documentation version which is whats cuasing the errors you're being shown in the UI.
I will look into both these issues

I've just updated the screenshots. I can get more information for the first issue from the logs.

excellent thank you

I will add (as an addtl useful piece of info) the concepts around documentation version is that theres no model structure difference between 2 versions but you're trying to import addtl documentation, i.e. descriptions where you have already finalised model.
Realistically this is not ever going to be the case with importing a database as we dont have the ability to import documentation from databases (not that there ever is any)
If you're trying to re-import a previously imported database because there are structural changes (new tables/columns etc) then you should use the "import as new branch model version" option leaving the branch name blank. This will create a new model version which has the concept of "this is the same model as before but with some schema/structure changes"
I would also recommend importing all databases as "finalised" unless you want to add documentation to the model before finalising as you won't be changing the schema/structure of a DataModel for a database inside Mauro, therefore it should be finalised to prevent accidental changes. However you can't add descriptions after finalisation so if you want to add descroptions then you should import as not finalised, add the descriptions then finalise

I will add (as an addtl useful piece of info) the concepts around documentation version is that theres no model structure difference between 2 versions but you're trying to import addtl documentation, i.e. descriptions where you have already finalised model.
Realistically this is not ever going to be the case with importing a database as we dont have the ability to import documentation from databases (not that there ever is any)
If you're trying to re-import a previously imported database because there are structural changes (new tables/columns etc) then you should use the "import as new branch model version" option leaving the branch name blank. This will create a new model version which has the concept of "this is the same model as before but with some schema/structure changes"
I would also recommend importing all databases as "finalised" unless you want to add documentation to the model before finalising as you won't be changing the schema/structure of a DataModel for a database inside Mauro, therefore it should be finalised to prevent accidental changes. However you can't add descriptions after finalisation so if you want to add descroptions then you should import as not finalised, add the descriptions then finalise

Hi @olliefreeman I am not sure if I follow. I was trying to import the model for the first time. Ideally I want just columns and column type to be imported, and then allow SMEs to add field descriptions. Is this how SQLServerImporter is meant to function?
And I appologize in advance if I am commenting in the wrong place. Did not want to open a new thread on the same topic.
Jelena

@jelenadreskai @olliefreeman

Hi @olliefreeman I am not sure if I follow. I was trying to import the model for the first time. Ideally I want just columns and column type to be imported, and then allow SMEs to add field descriptions. Is this how SQLServerImporter is meant to function?

That's the core use case.   The importer does the work that it can - importing the schema - and then you work on the resulting model to add the information that wasn't there in the database itself - the insights, etc. from the SMEs.
That should just work, and you're probably wondering why Ollie is suggesting finalising on import.  He'll correct me if he had something else in mind, but here's one good reason: you might well go through multiple versions of this model, all with the same schema, all derived from that same original import, but with new or revised field descriptions.
Because the 'asset' (the database) hasn't changed, we refer to these as 'documentation versions'.   The terminology isn't perfect.  What it means is that the new model is intended as a new/updated description of the same asset - the asset itself hasn't changed, there has been no new import or model created from scratch.
If this is the plan, then it could be useful to finalise the model after import, so you have taken a snapshot of the baseline, and then proceed to create a new 'documentation version' - and further documentation versions as required.
Note that you wouldn't be repeating the import in creating any of these new versions - the schema is unchanged and (as Ollie says) you're probably not reading in the field descriptions.
@olliefreeman is this what you were getting at?


Question: Ordering with partial matches

I was wondering if there is a way to enforce the ordering of path matches.
I have the following configuration:
health-check.yaml
request:
  method: GET
  path: "/health-check"
response:
  statusCode: 200
  headers:
    Content-Type:
      - application/json
  body: |
    {
      "type": "health-check",
      "request.hostname": "{{request.hostname}}",
      "request.path": "{{request.path}}",
      "request.url": "{{request.url}}"
    }

And a fallback
default.yaml
---
request:
  method: GET
  path: "/*"
response:
  statusCode: 200
  headers:
    Content-Type:
      - application/json
  body: |
    {
      "request.hostname": "{{request.hostname}}",
      "request.path": "{{request.path}}",
      "request.url": "{{request.url}}"
    }

When I make a request:
curl http://<IP_ADDRESS>:8083/health-check
I would expect to get:
{
  "type": "health-check",
  "request.hostname": "<IP_ADDRESS>",
  "request.path": "/health-check",
  "request.url": "http://<IP_ADDRESS>:8083/health-check"
}

Instead - I randomly get the default response.  Other times I get the health check response.  The output from the docker container looks like this:
2022/03/14 09:04:43 New request: GET /health-check
2022/03/14 09:04:43 Definition match found: true. Name : health-check.yaml
2022/03/14 09:04:43 New request: GET /health-check
2022/03/14 09:04:43 Definition match found: true. Name : default.yaml
2

Is this expected?  Is these an option to control the match ordering explicitly?

Disregard.  I just missed Priority

priority: Set the priority to avoid match in less restrictive mocks. Higher, more priority.


Publish Apollo Router plugin crate

Would you be up for publishing the plugin to https://crates.io?
This would allow us to build a custom Apollo Router with a number of custom plugins beyond just the Hive one.

Definitely, it's just that Apollo Router is not published as a crate and has no versioning, so it's going to be tricky to maintain yours and GraphQL Hive crates.

https://crates.io/crates/apollo-router

@kamilkisiela, I have a question that may deviate slightly from the current issue. I would like to know your thoughts on implementing a proper versioning schema for the Apollo Router (Hive Edition). To provide some context, we aim to establish a Terraform-based stack for deploying the router component. Our plan is to create a customized container image where we can inject our configuration files. Using the latest tag is not suitable for us because we want to have more control over the rollout of new router releases. Do you have any plans to tag or create a GitHub release whenever there are changes in the libraries/router directory? While using the commit SHA could work, it becomes challenging to track the specific changes made.

oops, re-opening. I will share an update here soon once the Crate is published :)

Hi @rcrowe @akoenig
You can find the Hive plugin in Crates now: https://crates.io/crates/hive-apollo-router-plugin
Also, check the Product Update and updated docs.


Where are the enhanced videos saved?

Hi, i just tested on my own video. I was able to get the metrics, but where is the enhanced video saved?

Hi supriyaarun27
As indicated in https://github.com/RyanXingQL/MFQEv2.0/blob/ac52631dee57070556060af18122609460184c8c/main_test.py#L306-L310, you may have to convert the enhanced numpy array by your own.
Sorry for the inconvenience.
For convertion, you can refer to https://github.com/RyanXingQL/PythonUtils/blob/main/conversion.py.
I may fix that if I have time later.

Thank you! Appreciate it

You're welcome


Client / server API docs update

This change updates our documentation to reflect the current client / server API. It also fixes a small formatting issue in the 'Server API' section of the docs.

Nice! I really like how the specs are json files:-)


Unknown target: deno

🐛 Bug description
I see that Deno support was added, however I am not able to use --target deno
🤔 Expected Behavior
--target deno should build for Deno
👟 Steps to reproduce
$ wasm-pack build --target deno
error: Invalid value for '--target <target>': Unknown target: deno

🌍 Your environment
Include the relevant details of your environment.
wasm-pack version: 0.10.3
rustc version: 1.64.0 (a55dd71d5 2022-09-19)
wasm-bindgen: 0.2

Seems this was added at some point, works with wasm-pack 0.12.1


Content-MD5 does not match object md5

With 3.7.3 version my code now fails when I try to put file using amazon s3 client (putObject).

12:37:49.906 [main] DEBUG org.apache.http.wire -- http-outgoing-0 >> "[0x0][0x0][0x0][0x0][0x0][0x0][0x0][0x0][0x0][0x0] ... [\r][\n]"
12:37:49.906 [main] DEBUG org.apache.http.wire -- http-outgoing-0 >> "0;chunk-signature=804a6f3d7ff45f1bc11eec20f425c5fdb9d86609a19744aacf1c0d6a300a1f4b[\r][\n]"
12:37:49.906 [main] DEBUG org.apache.http.wire -- http-outgoing-0 >> "[\r][\n]"
12:37:49.969 [main] DEBUG org.apache.http.wire -- http-outgoing-0 << "HTTP/1.1 400 Bad Request[\r][\n]"
12:37:49.969 [main] DEBUG org.apache.http.wire -- http-outgoing-0 << "Server: Jetty(12.0.8)[\r][\n]"
12:37:49.969 [main] DEBUG org.apache.http.wire -- http-outgoing-0 << "Date: Mon, 06 May 2024 10:37:49 GMT[\r][\n]"
12:37:49.969 [main] DEBUG org.apache.http.wire -- http-outgoing-0 << "Vary: Origin[\r][\n]"
12:37:49.969 [main] DEBUG org.apache.http.wire -- http-outgoing-0 << "Vary: Access-Control-Request-Method[\r][\n]"
12:37:49.969 [main] DEBUG org.apache.http.wire -- http-outgoing-0 << "Vary: Access-Control-Request-Headers[\r][\n]"
12:37:49.969 [main] DEBUG org.apache.http.wire -- http-outgoing-0 << "Content-Type: application/xml[\r][\n]"
12:37:49.969 [main] DEBUG org.apache.http.wire -- http-outgoing-0 << "Transfer-Encoding: chunked[\r][\n]"
12:37:49.969 [main] DEBUG org.apache.http.wire -- http-outgoing-0 << "[\r][\n]"
12:37:49.969 [main] DEBUG org.apache.http.wire -- http-outgoing-0 << "84[\r][\n]"
12:37:49.969 [main] DEBUG org.apache.http.wire -- http-outgoing-0 << "BadRequestContent-MD5 does not match object md5"
12:37:49.969 [main] DEBUG org.apache.http.headers -- http-outgoing-0 << HTTP/1.1 400 Bad Request
12:37:49.969 [main] DEBUG org.apache.http.headers -- http-outgoing-0 << Server: Jetty(12.0.8)
12:37:49.969 [main] DEBUG org.apache.http.headers -- http-outgoing-0 << Date: Mon, 06 May 2024 10:37:49 GMT
12:37:49.969 [main] DEBUG org.apache.http.headers -- http-outgoing-0 << Vary: Origin
12:37:49.969 [main] DEBUG org.apache.http.headers -- http-outgoing-0 << Vary: Access-Control-Request-Method
12:37:49.969 [main] DEBUG org.apache.http.headers -- http-outgoing-0 << Vary: Access-Control-Request-Headers
12:37:49.969 [main] DEBUG org.apache.http.headers -- http-outgoing-0 << Content-Type: application/xml
12:37:49.969 [main] DEBUG org.apache.http.headers -- http-outgoing-0 << Transfer-Encoding: chunked
12:37:49.969 [main] DEBUG org.apache.http.impl.execchain.MainClientExec -- Connection can be kept alive for 60000 MILLISECONDS
12:37:49.969 [main] DEBUG com.amazonaws.retry.ClockSkewAdjuster -- Reported server date (from 'Date' header): Mon, 06 May 2024 10:37:49 GMT
12:37:49.969 [main] DEBUG org.apache.http.wire -- http-outgoing-0 << "[\r][\n]"
12:37:49.969 [main] DEBUG org.apache.http.wire -- http-outgoing-0 << "0[\r][\n]"
12:37:49.969 [main] DEBUG org.apache.http.wire -- http-outgoing-0 << "[\r][\n]"
12:37:49.969 [main] DEBUG org.apache.http.impl.conn.PoolingHttpClientConnectionManager -- Connection [id: 0][route: {}->http://localhost:42908] can be kept alive for 60.0 seconds
12:37:49.969 [main] DEBUG org.apache.http.impl.conn.DefaultManagedHttpClientConnection -- http-outgoing-0: set socket timeout to 0
12:37:49.969 [main] DEBUG org.apache.http.impl.conn.PoolingHttpClientConnectionManager -- Connection released: [id: 0][route: {}->http://localhost:42908][total available: 1; route allocated: 1 of 50; total allocated: 1 of 50]
12:37:49.970 [main] DEBUG com.amazonaws.request -- Received error response: com.amazonaws.services.s3.model.AmazonS3Exception: Content-MD5 does not match object md5 (Service: Amazon S3; Status Code: 400; Error Code: BadRequest; Request ID: null; S3 Extended Request ID: null; Proxy: null), S3 Extended Request ID: null
12:37:49.970 [main] DEBUG com.amazonaws.auth.AwsChunkedEncodingInputStream -- AwsChunkedEncodingInputStream reset (will reset the wrapped stream because it is mark-supported).
com.amazonaws.services.s3.model.AmazonS3Exception: Content-MD5 does not match object md5 (Service: Amazon S3; Status Code: 400; Error Code: BadRequest; Request ID: null; S3 Extended Request ID: null; Proxy: null)
, S3 Extended Request ID: null
at com.amazonaws.http.AmazonHttpClient$RequestExecutor.handleErrorResponse(AmazonHttpClient.java:1880)
at com.amazonaws.http.AmazonHttpClient$RequestExecutor.handleServiceErrorResponse(AmazonHttpClient.java:1418)
at com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeOneRequest(AmazonHttpClient.java:1387)
at com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeHelper(AmazonHttpClient.java:1157)
at com.amazonaws.http.AmazonHttpClient$RequestExecutor.doExecute(AmazonHttpClient.java:814)
at com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeWithTimer(AmazonHttpClient.java:781)
at com.amazonaws.http.AmazonHttpClient$RequestExecutor.execute(AmazonHttpClient.java:755)
at com.amazonaws.http.AmazonHttpClient$RequestExecutor.access$500(AmazonHttpClient.java:715)
at com.amazonaws.http.AmazonHttpClient$RequestExecutionBuilderImpl.execute(AmazonHttpClient.java:697)
at com.amazonaws.http.AmazonHttpClient.execute(AmazonHttpClient.java:561)
at com.amazonaws.http.AmazonHttpClient.execute(AmazonHttpClient.java:541)
at com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:5558)
at com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:5505)
at com.amazonaws.services.s3.AmazonS3Client.access$300(AmazonS3Client.java:423)
at com.amazonaws.services.s3.AmazonS3Client$PutObjectStrategy.invokeServiceCall(AmazonS3Client.java:6639)
at com.amazonaws.services.s3.AmazonS3Client.uploadObject(AmazonS3Client.java:1892)
at com.amazonaws.services.s3.AmazonS3Client.putObject(AmazonS3Client.java:1852)

@2mars
this is probably related to #1840
Do you have a working test for me to reproduce this?

@Test
void fail_md5() throws URISyntaxException {
    AmazonS3 s3client = AmazonS3ClientBuilder.standard()
            .withCredentials(new AWSStaticCredentialsProvider(new BasicAWSCredentials("foo", "bar")))
            .withEndpointConfiguration(new EndpointConfiguration("http://localhost:42908", "eu-central-1"))
            .enablePathStyleAccess().build();
    Bucket someTestBucket = s3client.createBucket("test-baguette");
    File someGeotiff = new File(this.getClass().getResource("/sentinel_epsg32720_classified.tiff").toURI());
    s3client.putObject(new PutObjectRequest(someTestBucket.getName(), someGeotiff.getName(), someGeotiff));
    assertThat(s3client.getObject(new GetObjectRequest(someTestBucket.getName(), someGeotiff.getName()))).isNotNull();
}

thanks!
Looks like this only happens when using http as a connection method (which results in signed chunked uploads) in connection to uploading binary files like images.
In our Integration-Tests and unit-tests we're using text files for testing.
The Integration-Tests use https as a connection method with few exceptions.
That's why this issue was not caught during the refactorings I made for 3.7.3.
I'll look into a solution.

I'm having the same error with HTTP, however I'm uploading a plaintext JSON file.

@jonasholtkamp @2mars
I released 3.8.0 earlier today which should fix the problems in most cases.
Only the combination http / sync / sha256 does not work, at least with the AWS v2 SDK for Java.

Upgraded to 3.8.0, everything works like it did in 3.7.2, thank you.
One extra question, might be a little offtopic: How does one set up the HTTPS client with S3Mock? The README mentions port 9191. If I shoot HTTPS request against that port, I get these errors:
software.amazon.awssdk.core.exception.SdkClientException: Unable to execute HTTP request: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target

I suppose I need to trust a certificate first? Do I need to generate, self-sign and install one with the mock? Some guidance would be appreciated.

@jonasholtkamp
S3Mock bring its own, non-compliant SSL certificate.
The HttpClient used by the AWS SDK can be configured to ignore that. The integration-test module contains setups for a number of HttpClients, for example:
https://github.com/adobe/S3Mock/blob/main/integration-tests/src/test/kotlin/com/adobe/testing/s3mock/its/S3TestBase.kt#L156
If you run S3Mock in Docker, you could bring your own, valid SSL certificate, see #281
I'll see if I can add something to the README.md about using SSL in a later release.


[Enhancement Request] Misleading error message for 'Branch Prepare' command when source database does not exists

Background
When executing the 'Branch Prepare' command in the provided scenario, an error message indicating that the source database node does not exist is displayed. This error message can be misleading and does not provide clear guidance on the root cause of the issue.
/vt # vtctlclient --server localhost:15999 Branch -- \
>   --source_database branch_source111 \
>   --target_database branch_target111 \
>   --workflow_name branch_test \
>   --skip_copy_phase=false \
>   --stop_after_copy=false \
>   --default_filter_rules "RAND()<0.1" \
> Prepare
Branch Error: rpc error: code = Unknown desc = node doesn't exist: /vitess/global/keyspaces/branch_source111/VSchema
E0926 12:46:16.709781     141 main.go:105] remote error: rpc error: code = Unknown desc = node doesn't exist: /vitess/global/keyspaces/branch_source111/VSchema

Proposal
Enhance the error message for the 'Branch Prepare' command.

Simple "source database does not exist" is just fine.

fixed


Ability verify when an acativity should not be called

What was changed:

Added to the MockCallWrapper a way to specify that we expect Zero calls to the activity.
Why?

This can be helpful to test workflows with branches.
Checklist

Closes issue: #427

How was this tested: Unit test added

Any docs updates needed?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Orlando Vargas seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Allow patching of stream retry wait arg

Coverage decreased (-0.02%) to 94.615% when pulling f2ac610a316015aa11e0095a983aab889caff3f5 on release/1.17.2 into 0d19340f7ac7ef9efb1ff7583786dfff527d464b on master.


Update stable version in repo from 0.0.0 to 1.0.7

Think about adding version 1.0.7 to stable repository.
Version: stable=0.0.0 (0 days old) => latest=1.0.7 (30 days old)
Installs: stable=0 (0%), latest=81 (100%), total=81
Click to use developer portal
Click to edit
Note: This is an automatically generated message and not personally authored by bluefox!

This issue seems to be outdated.
This issue suggests to update the stable version of this adapter to 1.0.7 but in the meantime an update to version 1.1.1 is suggested.
So this issue will be closed and replaced by an updated one.
@mcm195 for evidence


Adding Contributors in Readme file

I want to add valuable contributors to readme.
Please assign it to me under hacktoberfest.

Hi @AnandSY, currently we don't need this :)


Version fails to compile

Steps to Reproduce (for bugs)
upgrade to version 1.0.0 and compile
seems like definition is still looking for TObject
Your Environment

Obfuscator version used: 1.0.0
Node version used: 10

Stack trace
import { TObject } from './src/types/TObject';
node_modules/javascript-obfuscator/index.d.ts:2:25 - error TS2307: Cannot find module './src/types/TObject' or its corresponding type declarations.

P.S. v0.28.1

Oh, my bad. Will fix it fast

Fixed in 1.0.1


⚠ Bofrost.lu has degraded performance

In 960e5b3, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2103 ms

Resolved: Bofrost.lu performance has improved in 0abb428 after 10 minutes.


ViT-B Training for DeiT

Thank you for your excellent work and for sharing the code! I learned a lot from what you have described.
Recently, I have been trying to use DeiT to train a plan ViT-Base model. I could follow the documentation to reproduce the ViT-Tiny and ViT-Small performance, but the same training procedure on ViT-Base has the accuracy of 78.9% on ImageNet1K, which is even worse than ViT-Small.
Therefore, I am wondering what could be the hidden tricks for training a good ViT-Base. Could you please share some hints? Thank you so much for the help!

Hey.
Did you find any configs?

@Alihjt No luck. One thing I found was that per-gpu batch size seemed to influence the numerical stability (acc improved with a smaller per-gpu batch size). Although I didn't had the chance to verify, using 16GPUs x 64 images per GPU would give a better performance.


Interior Left Nav Bug

Context:

Interior Left Nav text can get wonky when you highlight the text.
This seems to only happen in Chrome, and seems to be related to Flexbox.

[ ] Fix text from shifting

Hmmm, can you submit a gif? If you need software, I use licecap, which looks a little sparse, but it's legit.
If not, show me or one of the FEDs in the office when you get a free moment.

Thanks for tool recommendation!

@hellobrian ok I just updated the original post.

Can't reproduce


Cannot find propper way to access query parameters

Cannot find propper way to access query parameters to get access token from redirecting on my reflex frontend app
My State class is:
class State(rx.State):
    """The app state."""

    @rx.var
    def get_access_token(self):
        query_params = self.router.page.params
        print(query_params)
        access_token = query_params.get('access_token')
        print(access_token)
        return access_token

And my auth rout:
@rx.page(route='/app/auth/[[...]]', )
def auth():
    return rx.box(
        rx.text(State.get_access_token)
    )

First of all I try the following url http://localhost:8050/app/auth/#access_token=my_token/ and this give me nothing (just blank white screen). Then I try url http://localhost:8050/app/auth/access_token=my_token/ without # symbol and get in my console output from get_access_token method.
{'': ['access_token=my_token']}
None

I want to use the reflex routes with query parameters like http://localhost:8050/app/auth/#access_token=my_token/
Is there any chance do it?

Python Version: 3.12
Reflex Version: 0.6.3.post1
OS: Linux Fedora 40
Browser (Optional): Chrome

Tested your snippet locally, they are working properly when using this url :
http://localhost:3002/app/auth/?access_token=%22foobarbaz%22


CrystalDiskMark uses inno, not a generic exe

Microsoft Reviewers: Open in CodeFlow

shouldn't closing and reopening get the bots to run again?


avoid code duplication between realloc and malloc

@bors r+

@bors r+

:pushpin: Commit<PHONE_NUMBER>08238c98a386360566aac5adad0ba3 has been approved by RalfJung
It is now in the queue for this repository.

:hourglass: Testing commit<PHONE_NUMBER>08238c98a386360566aac5adad0ba3 with merge d0e9e5af9e06c81d285fd3789a9fb091eabd7a28...


There's no user agent

Meg should have its own user agent so that anyone seeing requests in their logs can see what's making them.
Ideally should be a mozilla-alike user agent for sites that do UA detection etc.

Fixed in cb942bf28


Update SDK to 0.41.4

Update Cosmos sdk dependency to v0.41.4 and Tendermint v0.34.8.  Verify that CosmWasm does not require an associated version bump.

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

@dpederson-figure or @ktalley-figure is there an associated update to wasm required?

Was resolved via direct update/commit https://github.com/provenance-io/provenance/commit/c3d9c59e02df9097933df2db27daaf67d0d1c4b7


feat: created functions to get multiple signed URLs.

Addresses issues:
#104

@dishwad run poetry run pre-commit install locally to install pre-commit hooks so that black is automatically run on every commit - that's what seems to be failing in CI right now 😄
Also you don't have to manually write the code for the sync client, we generate that using unasync - poetry run unasync  storage3 and poetry run unasync tests generates sync code for us 😅 I should probably document that somewhere

Ok I removed the code for the sync client and the sync test. I ran poetry run pre-commit install locally and black is passing for me locally.

Hm might be the case that poetry version of black  doesn't tally with the pre commit hook config. Former is 23.3.0 and latter is 23.1.0. Let me bump - might need to trouble you to rerun

Codecov Report
Patch coverage: 84.21% and project coverage change: -1.48 :warning:

Comparison is base (03c5b03) 87.18% compared to head (2a3d129) 85.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   87.18%   85.71%   -1.48%
==========================================
  Files          12       12
  Lines         320      371      +51
==========================================
+ Hits          279      318      +39
- Misses         41       53      +12

Impacted Files
Coverage Δ

storage3/_async/file_api.py
85.22% <78.57%> (-1.26%)
:arrow_down:

storage3/_sync/file_api.py
85.22% <78.57%> (-1.26%)
:arrow_down:

storage3/types.py
95.34% <100.00%> (+1.23%)
:arrow_up:

... and 2 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Odd - the pre-commit hook for black was reformatting tests/_async/test_client.py on CI but ignoring it locally. Running black manually on that file seems to have fixed it.


adding any kind of labels

I found that in some papers you can find something like this:
1,3,5-Tricyano-2,4,6-tris(2-dimethylaminovinyl)benzene (Leu-07)
and this is not allowed in the current grammar, so I decided to allow any kind of names at with length at least of 3 like Leu. @mcs07

@mcs07


Add minimum Forc version field to manifest

Proposal
Add a field, e.g. project.forc_version that defines the minimum version of Forc supported. Example:
[project]
# ...
forc_version = "0.16.2"

Cargo ref for similar field: https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field
If the current version of Forc is too low, it should error out and tell the user how to update by linking to the Sway Book's page on installing and updating.
Motivation

A common source of user issues is simply an outdated forc. This will eliminate tech support and provide actual information to the end user.
Will also avoid using a library that assumes certain compiler features (e.g. safety checks) from being used in an older codebase.

Misc
cc @mitchmindtree and @kayagokalp for thoughts. Should this also apply transitively?

I think we should definitely have this as it would mean a lot better error messages in many scenarios.
One thing that we may want to keep in mind is checking the required minimum forc version. This may require us to check all dependencies of the project and if the minimum required version coming from the dependencies is higher than the one provided with the root project we may want to produce an error.

Good idea!
For anyone interested in having a go at this, take a look at the forc_pkg::pkg::validate_dep_manifest function introduced in #2234. This is likely where we will want to check for a minimum version within the dependency manifests (this will  handle not just direct deps, but transitive deps too). validate_dep_manifest will only handle depedencies however, so we should be sure to check the top-level project's manifest too.
We'll also want to document this entry in the book and mention what forc version the feature was introduced in.


JGRP-2014 FILE_PING destination file name can include File.separator

characters
Replace File.separatorChar with '/' to fix this issue on Windows

Applied. I actually changed this slightly to replace both backslash and slash with a hyphen

Backported to 3.6 branch


Message shape

In the current code, the message shape doesn't match the spec.  Make sure they are both in sync.  Also note the conversations we had on the optional state field we currently have being allowed but not in the spec, and the spec making it clear that extra fields must be tolerated, in the spirit of Postel's law... "Be conservative in what you do, be liberal in what you accept from others."

I've removed the state field now, so that is no longer relevant.  Still need to make sure we match spec and abide by Postel's law regardless.


example_15: Wrong ctrl config

https://github.com/ros-controls/ros2_control_demos/actions/runs/11536820407
Error: ROR] [spawner-9]: process has died [pid 22202, exit code 1, cmd '/opt/ros/jazzy/lib/controller_manager/spawner position_trajectory_controller --inactive --param-file /home/runner/work/ros2_control_demos/ros2_control_demos/.work/target_ws/install/ros2_control_demo_example_15/share/ros2_control_demo_example_15/config/multi_controller_manager_rrbot_generic_controllers.yaml --ros-args -r __ns:=/rrbot_1'].
Error: s2_control_node-1] [ERROR] [1729998296.023592492] [rrbot_1.controller_manager]: The 'type' param was not defined for 'forward_position_controller'.

@saikishor could you have a look pls?

https://github.com/ros-controls/ros2_control_demos/actions/runs/11536820407
Error: ROR] [spawner-9]: process has died [pid 22202, exit code 1, cmd '/opt/ros/jazzy/lib/controller_manager/spawner position_trajectory_controller --inactive --param-file /home/runner/work/ros2_control_demos/ros2_control_demos/.work/target_ws/install/ros2_control_demo_example_15/share/ros2_control_demo_example_15/config/multi_controller_manager_rrbot_generic_controllers.yaml --ros-args -r __ns:=/rrbot_1'].
Error: s2_control_node-1] [ERROR] [1729998296.023592492] [rrbot_1.controller_manager]: The 'type' param was not defined for 'forward_position_controller'.

@saikishor could you have a look pls?

Sure!

Ah, these are the binary builds -> semi-binary builds are still fine -> will solve itself after merging the releases into rosdistro


Test the GitHub action

Add workflow to test that the action works as expected

Work across different OS
Work with different version of Node.js
Install the dependencies with pnpm

Thank you for doing this! this is great!!

Ups, look like the "Licensed" workflow uses npm
https://github.com/NullVoxPopuli/action-setup-pnpm/blob/204f670cee97eb251873d1346e052c633721e217/.github/workflows/license.yml#L15
And I switched to pnpm to test that the github action installs the dependencies

I solved it by installing licensed in the workflow instead of using the action

thank you!!! <3


[feature] Improve locking; upgrade deps

https://github.com/chanzuckerberg/go-misc/pull/63
https://github.com/chanzuckerberg/go-misc/pull/61

Codecov Report

Merging #28 into master will decrease coverage by 0.99%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   53.39%   52.39%   -1.00%
==========================================
  Files          10       10
  Lines         575      563      -12
==========================================
- Hits          307      295      -12
  Misses        245      245
  Partials       23       23

Impacted Files
Coverage Δ

pkg/aws_config_server/list_roles.go
80.21% <0.00%> (-2.31%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d804799...74d895e. Read the comment docs.


[SPARK-39766][SQL] Ensure arrayOfAnyAsSeq in GenericArrayDataBenchmark has same performance when using Scala 2.12 and 2.13

What changes were proposed in this pull request?
This PR introduce a new  helper class named GenericArrayDataHelper,  this helper class has different copy for Scala 2.12 and Scala 2.13.
In Scala 2.13 version, this PR makes special treatment for the toArray implementation of immutable.ArraySeq.ofRef[_] and mutable.ArraySeq.ofRef[_] to avoid memory copy to ensure arrayOfAnyAsSeq in GenericArrayDataBenchmark has same performance when using Scala 2.12 and Scala 2.13.
Why are the changes needed?
To Ensure arrayOfAnyAsSeq in GenericArrayDataBenchmark has same performance when using Scala 2.12 and Scala 2.13.
The performance difference scenarios before this PR are described as follows：
Before this pr, the result of  arrayOfAnyAsSeq in GenericArrayDataBenchmark using different Scala version as follows:

Scala 2.12

OpenJDK 64-Bit Server VM 1.8.0_322-b06 on Linux 5.13.0-1021-azure
Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz
constructor:                              Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
------------------------------------------------------------------------------------------------------------------------
arrayOfAnyAsSeq                                      25             29           2        395.1           2.5       0.1X

Scala 2.13

OpenJDK 64-Bit Server VM 1.8.0_332-b09 on Linux 5.13.0-1031-azure
Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
constructor:                              Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
------------------------------------------------------------------------------------------------------------------------
arrayOfAnyAsSeq                                     241            243           1         41.4          24.1       0.0X

The test code as follows:
benchmark.addCase("arrayOfAnyAsSeq") { _ =>
  val arr: scala.colletion.Seq[Any] = new Array[Any](arraySize)
  var n = 0
  while (n < valuesPerIteration) {
    new GenericArrayData(arr)
    n += 1
  }
}

def this(seq: scala.collection.Seq[Any]) = this(seq.toArray)

The performance difference is due to  memory copy is made in seq.toArray when using Scala 2.13, , but Scala 2.12 does not:

When using Scala 2.12, the class type of arr is mutable.WrappedArray$ofRef, toArray return array.asInstanceOf[Array[U]], there is no memory copy.
When using Scala 2.13, the class type of arr is mutable.ArraySeq$ofRef, toArray will call IterableOnceOps#toArray, the corresponding implementation uses memory copy.

Does this PR introduce any user-facing change?
No
How was this patch tested?

Pass GitHub Actions
Manual test 1: run GenericArrayDataBenchmark using Scala 2.13 after this pr:

OpenJDK 64-Bit Server VM 1.8.0_332-b09 on Linux 5.13.0-1031-azure
Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
constructor:                              Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
------------------------------------------------------------------------------------------------------------------------
arrayOfAnyAsSeq                                       4              4           0       2491.6           0.4       1.0X

The rate  of arrayOfAnyAsSeq from 41.4M/s to 2491.6M/s.

Manual test 2:  run catalyst and sql module test, all passed

mvn clean install -DskipTests -pl sql/core -am -Pscala-2.13
mvn clean test -pl sql/catalyst -Pscala-2.13
mvn clean test -pl sql/core -Pscala-2.13 -Dtest.exclude.tags=org.apache.spark.tags.ExtendedLevelDBTest

Run completed in 8 minutes, 42 seconds.
Total number of tests run: 6593
Suites: completed 286, aborted 0
Tests: succeeded 6593, failed 0, canceled 0, ignored 5, pending 0
All tests passed.

Run completed in 2 hours, 5 minutes, 18 seconds.
Total number of tests run: 11858
Suites: completed 524, aborted 0
Tests: succeeded 11858, failed 0, canceled 11, ignored 33, pending 0
All tests passed.

I also report this issue to Scala community (https://github.com/scala/bug/issues/12618)

Thank you for investigating this, @LuciferYang . You may want to create an umbrella JIRA issue to contain similar issues for the future (or includes some old JIRAs together).

Thank you for your advice. I create an umbrella Jira  SPARK-39786 and converted SPARK-39553,SPARK-39652 and SPARK-39766 into its subtask now, and I'll add description of SPARK-39786 later

@srowen
Summarized as follows：

Risk：The addition or deletion operation of ArraySeq(both mutable and immutable) will return a new ArraySeq and  the underlying array cannot be grown in place. But there is also a risk: mutable.ArraySeq.sortInPlace will sort on the original array in place,  which is a new method in Scala 2.13 and Spark doesn't use it.

Performance: The throughput of arrayOfAnyAsSeq scenario is 41.4M/s before this pr, and its throughput is 2491.6M/s after this pr. The performance data using Scala 2.12 are:  395.1M/s(Java 8), 1845.1M/s(Java 11) and 1245.5M/s (Java 17)

Whether case array: Array[_] => array.toSeq.toArray[Any] works： This is a TODO of mine, let me track it and if this is an issue, I will file a new Jira and try to solve it.

On the other hand, I also agree to keep this issue and wait for the new version of Scala 2.13 to fix the issue

Is this superseded by https://github.com/apache/spark/pull/37208 ?

Yes

Is this superseded by #37208 ?

No, they are 2 different issue. https://github.com/apache/spark/pull/37208 cannot solve arrayOfAnyAsSeq  scenario

EDIT : ~Yes~

Sorry for the misleading answer

daa453c merge with master.
For scenario arrayOfAnyAsSeq , there is still  10 times performance gap between using Scala 2.13 and using Scala 2.12

Should we continue this pr? I found that https://github.com/scala/bug/issues/12618 was moved into the Backlog so I think the relevant fixes should not be in Scala 2.13.9

It still feels risky to grab the array from a mutable collection, but I don't know a lot about the details of how likely that is to cause a problem

How about only keeping the changes to the immutable.ArraySeq?  For  mutable.ArraySeq, we can wait for upgrade Scala to fix it

Yeah anything that doesn't risk dealing with a mutable array would seem OK

Ok, I will update the pr to only keep the immutable part later

The code has been updated, and will do manual tests for Scala 2.13 again


Support eggs in upload_file

cc @broxtronix
No test yet, but this seems to work locally with your fringe egg.

Now with tests!


Restarting hass while viewing in browser generates a "Login attempt or request with invalid authentication" before succeeding

Home Assistant release with the issue: 0.73.0

Last working Home Assistant release (if known):
Operating environment (Hass.io/Docker/Windows/etc.):

docker, with nginx proxying
Component/platform: auth

Description of problem:
I'm trying out the new auth and noticed something while configuring:

view homeassistant from a browser
restart hass process
switch back to browser until hass completes starting up
check dev-info and see Login attempt or request with invalid authentication from <URIP>

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
auth:
http:
  use_x_forwarded_for: true
  trusted_proxies: <IP_ADDRESS> # hass runs in host mode, so nginx looks like it's coming from <IP_ADDRESS>

Traceback (if applicable):

Additional information:

It is known issue.

Thanks! Closing for that one.


Move scanner common code to common folder

What changed?
Move scanner common code to common folder

Why?
The invariant checks could be used during replication. Moving the code to common package to allow the code reused in both worker and history

How did you test it?
No code changes

Potential risks

Coverage increased (+0.6%) to 67.615% when pulling ae1a3395ee91efceed20525ef27e7b4a3cf86048 on move_scanner_common into 5aac215e88723e55549ca1ddc27b71f1fa7d47c8 on master.


Spatial part of precip pipeline.

Need to tackle the data access still, but this should be what we need for the spatial part.
Basically doing this:

I'm just going to tag the values part of this on too.
I built this for a little zoomed in bounding box to verify that it works... seems pretty decent.

This PR comes along with two .rds files that are in drive. One that is an intermediate spatial file -- it could be eliminated in hindsight. The main precip data.frame will be a very long three column data.frame with the polygon geometry repeated for ease of plotting. We could change this up so there is one geometry .rds that has an ID column and one data .rds that has the ID to join up to the geometry. Thoughts?

This is looking good! reviewing now, but thank you for the details and images. Very helpful.

I think this is ready for merge unless there are changes you want to see in the latest check in @jread-usgs.

with
precip_spatial <- readRDS("1_fetch/out/precip_spatial.rds")
precip <- readRDS("1_fetch/out/precip_values.rds")

view_polygon <- scmake("view_polygon")
source("1_fetch/src/map_utils.R")

county <- scmake("focus_geoms")

fil <- precip$time == precip$time[1]

p <- left_join(select(precip_spatial, id),
               select(filter(precip, fil), -time),
               by = "id")

plot(view_polygon, lwd = 3, main = precip$time[1])
plot(p["precip"], border = "transparent", add = TRUE)
plot(county$geometry, add = TRUE)
plot(bbox, lwd = 3, add = TRUE)

(slight mod of your code), I see

which looks good