generate slug for entity if specific symbol

I have entity skill and have field slug from field skill and when I create skill and write C++ have slug=c OR if create C. - have slug=c OR when create C# still have slug=c. I think in Gedmo have something regular expression. Maybe who know how overwrite Gedmo slug or hot to fix this problem ?
use Gedmo\Mapping\Annotation as Gedmo;

/**
 * Skills.
 *
 * @ORM\Table(name="code_directory_skills")
 */
 class Skill
 {
use Timestampable;
/**
 * @var int
 *
 * @ORM\Column(name="id", type="integer")
 * @ORM\Id
 * @ORM\GeneratedValue(strategy="AUTO")
 * @Expose()
 * @Groups({"for_skill_by_id", "for_all_skills", "for_all_skills_extended"})
 */
private $id;

/**
 * @var string
 *
 * @ORM\Column(name="skill", type="string", length=255)
 * @Expose()
 * @Groups({"for_skill_by_id", "for_all_skills", "for_all_skills_extended"})
 */
private $skill;

/**
 * @Gedmo\Slug(fields={"skill"}, updatable=true)
 * @ORM\Column(name="slug", type="string", nullable=false)
 * @Groups({"for_skill_by_id", "for_all_skills", "for_all_skills_extended"})
 * @Expose()
 */
protected $slug;

I create listener
namespace Artel\ProfileBundle\Listener;

use Gedmo\Sluggable\SluggableListener as BaseSluggableListener;

class SluggableListener extends BaseSluggableListener
{
public function __construct()
{
    $this->setTransliterator(array('\Artel\ProfileBundle\Util\Transliterator', 'transliterate'));
}
}

and create translator in $text I have C++ then in
Urlizer::urlize($text, $separator) //have have C

class:
use Gedmo\Sluggable\Util\Urlizer;

class Transliterator
{
public static function transliterate($text, $separator = '-')
{
    $text = Urlizer::unaccent($text);
    return Urlizer::urlize($text, $separator);
}
}

I change
class Transliterator
{
public static function transliterate($text, $separator = '-')
{
    $text = Urlizer::unaccent($text);

    return $text; //have C++
}
}

but in DB still have only slug=c
and config this extension:
stof_doctrine_extensions:
class:
    sluggable: Artel\ProfileBundle\Listener\SluggableListener
default_locale: "%locale%"
orm:
    default:
        timestampable: true
        sluggable:     true
        softdeleteable: true

How in Transliterator enable specific symbol for sluggable ?

hi, you can change transliterator for sluggable to any callable function and adapt it whatever way you like, like changing + sign to plus word and # sign to sharp word. Sluggable does not have these kinds of replacements by default, because it does not know your underlying business logic. It was created to transliterate sentences and create url friendly slugs by default

stof bundle makes listeners private I think and hides away much of the options. My advice is to use symfony2 manual for extensions in order to set it up with all options at hand. you can set transliterator directly in the configuration.


Remove context usage in ProgressPlugin

ProgressPlugin uses Tap.context to expose reportProgress which is unnecessary. This PR removes Tap.context usage in favor of a WeakMap.
While this API is not as convenient as the previous one, it ensures that webpack no longer rely on Tap.context and demonstrates that the previous API could be achieved in user-land.
What kind of change does this PR introduce?
refactoring
Did you add tests for your changes?
already exists
Does this PR introduce a breaking change?
yes
What needs to be documented once your changes are merged?
context.reportProgress is no longer available. It has been replaced by ProgressPlugin.getReporter(compilation)

Thanks


Support “Quick Look” for associated file type by VSCode on macOS

Current behavior:

Expected behavior:

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_smiling_face: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


mount folder

what is the best way to mount and share files ?
I used this command
docker run -v F:/data:/vmedia -d -p 5800:5800 -p 5900:5900 -e IDRAC_HOST=<IP_ADDRESS> -e IDRAC_USER=root -e IDRAC_PASSWORD=calvin domistyle/idrac6
but the vmedia file is empty ?!
any help would be appreciated
thanks

Is there anything in the F:/data folder on the host? Did you grant Docker for Windows permission to use your F drive?

there is an iso file
and yes I shared c and f drives with docker

Try resetting the credentials for your drives under Settings -> Shared Drives. Recreate the container afterwards.
It's another Docker for Windows bug.

Hi, thanks for this, I am trying to get the ISO to mount, and managed to get the drive letter and /vmedia folder to show in the iDRAC "virtual media" add image dialogue.
Unfortunately I do not see the ISO in the folder. I have the folder on Windows mounted and shared with "everyone" READ. Recreated the container numerous times.
Any ideas how you got this working?
Thanks!


Log4j2 and Lambda runtime issue which fails logger util in some scenario

What were you initially searching for in the docs?
This issue is created via discussions as part of https://github.com/aws-samples/aws-lambda-powertools-examples/issues/67
Is this related to an existing part of the documentation? Please share a link
Describe how we could make it clearer

Update docs and samples to specify class names directly when initialising logger. Thats better from cold start perspective anyways.
Clarify and address this bit in FAQ section of doc as well with a workaround on what config might be needed, if users still want to depend on log4j to figure out class name.
Update all the examples here too https://github.com/aws-samples/aws-lambda-powertools-examples which is using logger without specifying a class name-

If you have a proposed update, please share it here

Thanks to rieckpil for reporting this. @Klosephi will have a look at fixing the docs, FAQ and other bits

@Klosephi, any update on this?

@jeromevdl I would like to give this a try if this has not been picked up.

@jreijn, feel free. I think that's an easy one. Just update the doc, have a look at the examples too. And everywhere we use a logger.
Not sure you have to spend much more on this, as we'll rewrite the logging module completely in v2.

@jeromevdl yes very simple one, but I wanted to pick an easy one to get started :).


[CI][danger] Use latest as  mergeBaseCommit

Bundle size will be reported once CircleCI build #292 finishes.

  Generated by :no_entry_sign: dangerJS against f5dcfac17d969e24ce4633684e1ce86a2f60b0df


some bugs fix include(autoCellHeight,multi grid drag,drag between grid two placeholder)

1.auto cellHeight fix
2.tow gridstack acceptWidgets bugs fix
3.widget can not resize after drag between two grid bug fix
4.drag between tow grid,two placeholder fix

Coverage decreased (-0.7%) to 71.536% when pulling ea52f622b651606812df8ddee493536336a7ce2e on eagoo:master into 99653bded3afc20d67660bb98c76cf5e0e70139d on troolee:master.

Thank you

I've been told that while this PR does fix the issues listed, it causes some other ones. Could anyone elaborate and/or set me straight? A couple parts seem a little iffy in the code, so an explanation would also be great.

My team has verified the changes are needed to solve multiple grid issues like those mentioned in #718 . @eagoo could you please submit only the src/gridstack.js changes to the devel branch?

Also, please make sure that it passes all tests, including jscs. I see a couple spots in the code that won't match the style, but they're easy fixes. Simply run npm run build locally and you'll see those results.

note that "#4.drag between tow grid,two placeholder fix" doesn't appear anymore in the latest 1.0.0-dev code (using two.html sample code) so not all those fixes are needed.
the only one I see and commented on the fix is #718 which is a 2 liner fix... I recommend we pick that (I'll be happy to provide a PR)
"#1.auto cellHeight fix" I don't know what that issue is...

A few of these have been individually merged. @eagoo , could you split out the remaining fixes into individual PRs and provide jsfiddles or explanations of how to arrive at the issue / solution? Thanks so much!

Hey, guys. Do you have any updates about the issue with duplication? It still reproduces on the latest version here: http://gridstackjs.com/demo/two.html
screencast: https://gfycat.com/evilspecificadder


Refactor vuex modules tests

Link to the guide lines: https://www.notion.so/cosmosvoyager/Code-Style-b974391ca44c450191b7719eb0235970
Originally posted by @faboweb in https://github.com/cosmos/voyager/pull/1782/files/1aed9888d0c2a712cb93e6ca4fad7985477ea18d

Closing in favor of #1337


ostree-ng.sh: simplify .ks

Bring the kickstart closer to the embedded kicktstart.
The embedded kickstart performs a default installation, but requires you to select the partitioning. This does the same, but applies autopart.
This pull request includes:

[ ] adequate testing for the new functionality or fixed issue
[ ] adequate documentation informing people about the change

@teg, test is stuck at anaconda installation. That means we need more "instructions" to make it automatically.

@teg, test is stuck at anaconda installation. That means we need more "instructions" to make it automatically.

At which screen ? That's the command which is missing.
From the old tar kickstart test in lorax composer we use the following kickstart:
cmdline
lang en_US.UTF-8
timezone America/New_York
keyboard us
rootpw --lock
sshkey --username root "$PUB_KEY"
bootloader --location=mbr
zerombr
clearpart --initlabel --all
autopart
# reboot is used together with --no-reboot qemu-kvm parameter, which makes the qemu-kvm
# process exit after the installation is complete and anaconda reboots the system
# (using 'poweroff' ks command just halted the machine without powering it off)
reboot

liveimg --url file:///var/lib/lorax/composer/results/$UUID/root.tar.xz

@henrywang @atodorov seems like I should not have dropped the poweroff command. Pushed with that readded.


simulated lens glare

maybe these sources help:
https://graphics.stanford.edu/courses/cs348b-competition/cs348b-03/glare/
http://www.graphics.cornell.edu/pubs/1995/SSZG95.pdf
Currently there is no glare simulation and this can cause very bright directly or indirectly visible lights look super artificial.
Doing glare in post is pretty much making things worse and to even get some proper looking glare we would always have to render in 32bit exr for proper intensity estimation. This also throws any prior tonemapping out of the window as we now have to work with linear output.
From user perspective/artistic control we need:
ray count
rotation
power
bluring
and in octane we have 2 controls that are spectral shift and spectral intensity to control how light disperses creating some tint on the glare as it fades

If it helps here is what the result and interface looks like in corona (very similar how octane and vray do this too)
https://corona-renderer.com/stuff/helpdesk/bloomglare/bloomglare-vfb.jpg


Eliminating ambiguity of "XML"

This paragraph describes not using XML as a configuration file. So the single word "XML" refers to a configuration file, not a mapper in the context. So when we talk about using XML mappers, we should be explicit.

Coverage remained the same at 87.227% when pulling f8d4123933687c548ccabe7aec8951a9592fe238 on awxiaoxian2020:awxiaoxian2020-patch-2 into 444fed4b18384537423744b534d881419706272a on mybatis:master.

@awxiaoxian2020 Thank you!

@awxiaoxian2020 Thank you!

Thanks for merging!
I think I can sync it for Chinese doc. I have two PRs about the Chinese doc, #2506 and #2527 Should I give a new pull request for this sync or commit to the original branch I have created?
I mean that a PR maintain a file or a purpose? which is more appropriate?


Websockets Transport - Get Client Address

Most transports have a method which allows the server to gather the player's address. Websockets has it too but it is incomplete right now:
//Mirror/Runtime/Transport/Websocket/Server.cs

        public string GetClientAddress(int connectionId)
        {
            if (clients.TryGetValue(connectionId, out WebSocket client))
            {
                return ""; // Incomplete
            }
            return null;
        }

Right now I have a security feature which relies on it.
I tried googling and looking through .Net docs already, but, low-level subjects are out of my skill.

:tada: This issue has been resolved in version 3.22.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


VPN over SSH

It could be great if a SSH connection can be used as a VPN server like a bastion.
Tunnel inside WebSSH works great, but a VPN feature should work better, isn't it?

https://github.com/passepartoutvpn/tunnelkit

In-App Purchase

[ ] (Tier 3) VPN over SSH #23

Now available for every beta tester through TestFlight

```
~~~~
```
```

Sent with GitHawk


[FLINK-19279] Remove StatefulFunctionUnvierse cache

This PR removes the per JVM StatefulFunctionUniverse cache
Currently we cache the provided universe, per JVM. The cache exists to avoid scanning the class path, whenever accessing the universe across different operators executing at the same JVM, however:

Each operator accesses the universe during its open phase (once)
Having such a cache result in a shared universe across attempts, and this is undesirable. For example accessing previously released resources.

The changes in this PR were tested by executing the e2e tests, and deployed to k8s (while triggering failures)

LGTM @igalshilman, great efforts in debugging and discovering this.
Am merging this now ...


Fixed bug with FQDNs in OWA Machine resource

Currently if a machine join is specified with a fully qualified name it will fail the test method. Added logic to account for FQDNs here to remove the incorrect false results.

[X] Change details added to Unreleased section of changelog.md?
[X] Added/updated documentation and descriptions in .schema.mof files where appropriate?
[X] Examples appropriately updated?
[X] New/changed code adheres to [Style Guidelines]?(https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md)?
[X] Unit and Integration tests created/updated where possible?

This change is

@kwirkykat Can you please check the webhooks in this repo for AppVeyor - doesn't look like it is automatically running the tests now that it's been moved over.

@BrianFarnhill Updated WebHooks and started an AppVeyor build for this repo. I'm not sure that the PR will auto update though?

@kwirkykat I'll push a dummy commit in to trigger a fresh one. Thanks!


unknown error

Hi Omar, any idea what this error might be caused from? From my side, it's possible there were simultaneous token sends, and not enough pause in between them (that old issue that caused us to use 4 second delay between any sends). But wasn't sure if this was the same error ..
query_response: Dict[str, Any] = provider.get_account_transactions(   File "/home/ubuntu/NattyRadishesReservationTracker/env/lib/python3.9/site-packages/radixlib/provider.py", line 261, in get_account_transactions     return self.__dispatch(   File "/home/ubuntu/NattyRadishesReservationTracker/env/lib/python3.9/site-packages/radixlib/provider.py", line 95, in __dispatch     response: requests.Response = requests.request(   File "/home/ubuntu/NattyRadishesReservationTracker/env/lib/python3.9/site-packages/requests/api.py", line 61, in request     return session.request(method=method, url=url, **kwargs)   File "/home/ubuntu/NattyRadishesReservationTracker/env/lib/python3.9/site-packages/requests/sessions.py", line 529, in request     resp = self.send(prep, **send_kwargs)   File "/home/ubuntu/NattyRadishesReservationTracker/env/lib/python3.9/site-packages/requests/sessions.py", line 645, in send     r = adapter.send(request, **kwargs)   File "/home/ubuntu/NattyRadishesReservationTracker/env/lib/python3.9/site-packages/requests/adapters.py", line 501, in send     raise ConnectionError(err, request=request) requests.exceptions.ConnectionError: ('Connection aborted.', ConnectionResetError(104, 'Connection reset by peer'))

As Kevin has said, the issue that you're getting here originated from the requests python library. Some of the reasons for this issue are:
1- You lost internet conenction
2- You're making HTTP requests to an invalid URL
Could you tell more information about how this issue happened or how you were using the package when it happened?


Added borderColor

When borderColor is set, a border with the given color is added to the image exterior, making it better to see the image ending when the baseColor and the image background are similar
demo:

Very good!!

what a good guy.  @vinicios-cervantes

Hello @chooyan-eng,  please review this PR

@luciano-cervantes
Hi, thank you very much for your PR!
As I have few time to maintain this package, I've now started to check the PR.
As long as reading your PR description and capture, it's nice idea! Wait for my checking your code.

Still waiting...

Complicated...

Very complicated @luciano-cervantes

The best review ever done... @vinicios-cervantes

It has already completed a birthday @vinicios-cervantes . 🎉🎉

Happy birthday!! 🎂🥳🎉
https://tenor.com/view/koksalbaba-happy-birthday-blowing-candles-birthday-cake-tavalod-gif-13431516


Disable or set custom gaps in fullscreen mode

When in (non-native) fullscreen mode, I typically want to disable gaps to maximize screen usage. It would be nice if gaps could be customized for fullscreen, just like they can with monitor patterns.
Related, it would also be nice to optionally treat workspaces with a single window as fullscreen, removing gaps.

But why?
If users use gaps for practical purposes to distinguish between windows then they can only use the inner gaps and set outer gaps to zero
If users use gaps for aesthetic purposes then users will use both outer and inner gaps
Related: #54

Good point. My reason for wanting this functionality is somewhere in between: I want gaps for separation of windows. However, having only inner gaps does not look great IMO.
So for fullscreen or single-window workspaces, I don't want gaps as they add no practical value. In all other cases, I want gaps between windows for practical reasons, and around them for aesthetics.

I don't mind if somebody adds a fullscreen --no-outer-gaps flag
It's a minor priority for me, and it's a good-first-issue so PRs are welcome

Related, it would also be nice to optionally treat workspaces with a single window as fullscreen, removing gaps.

It will be fixed semi-automatically with #278 Please see https://github.com/nikitabobko/AeroSpace/issues/60#issuecomment-2170067042

Alternative name: fullscreen --ignore-gaps

fixed in #472 🎉

Released in 0.15.0-Beta


libgcrypt: 1.9.3 -> 1.9.4

Motivation for this change
https://nvd.nist.gov/vuln/detail/CVE-2021-40528
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

NEWS look OK: https://github.com/gpg/libgcrypt/blob/libgcrypt-1.9.3/NEWS


Support detecting AIX triple

This PR adds support for detecting triples of AIX targets: powerpc64-ibm-aix (and potentially powerpc-ibm-aix).

Nice! Let's wait until those triples are accepted, otherwise this looks good.

The proposal https://github.com/rust-lang/compiler-team/issues/553 has been accepted :)

Nice, merged, thank you for the PR!


save snippet incorrectly parses tabs

If the editor isn't replacing tabs with spaces, the saved snippet includes \t in place of the tabs

resolved by #12


  Use -vv to show these durations.)
=========================== short test summary info ============================
FAILED tests/cmds/test_inspect.py::TestInspectCommands::test_keys - assert 1 == 0
 +  where 1 = <Result ValueError("'chia' is not in the mnemonic dictionary; may be misspelled")>.exit_code
========================= 1 failed, 21 passed in 4.20s =========================
Error: Process completed with exit code 1.

https://github.com/Chia-Network/chia-dev-tools/actions/runs/6725284407/job/18279329999#step:4:369

close and reopen for re-run


Package Requested

[X] I would like someone else to build the manifest.
[ ] I would like help so I can submit the manifest.
[X] I have performed a search and couldn't find this package.
[X] I have checked that the installer for this package is not a standalone or portable executable or a .zip file
[X] I think there is a new version available and I have provided the URL.

Please provide the following information
Publisher: CopyTrans
Publisher Url: https://www.copytrans.net/
Package Name: CopyTrans.ControlCenter
Description: CopyTrans Control Center is the iPhone apps and documents manager. Take control over your favorite iPhone apps and app data and keep them safe.
Package Version: 5.003
Installer URL: https://www.copytrans.net/bin/Install_CopyTransControlCenter.exe
Current Package Identifier (for new versions):
https://www.copytrans.net/bin/Install_CopyTransControlCenter.exe

Manifest submitted


Update reqs to 1.0

This new device will no longer support Qiskit <0.46. Therefore testing for those versions is no longer necessary and has been deleted from the CI workflow.

[sc-63543]

Wrt codecov, it's just upset that initializing the BasicAer device isn't being tested.
We can wait to merge this until we've merged a PR removing the BasicAer device, and then re-trigger CI and it should pass. Alternatively, we can have someone with authorization override CodeCov and merge.

We can wait to merge this until we've merged a PR removing the BasicAer device, and then re-trigger CI and it should pass. Alternatively, we can have someone with authorization override CodeCov and merge.

I think we can wait and merge this after removing the BasicAer device. I'll open that PR ASAP.

Looks good! A few small loose ends to wrap up:

lets also rename tests_qiskit_1.yml to tests.yml, since that is the standard name people will be looking for to find the test CI file

Ok yeah, I didn't know that :sweat_smile:

there are also 0.46 and 1.0 tests run twice a week for the test matrix (the IBMQ tests) - we should similarly delete the 0.46 version and rename the 1.0 version to ibmq_tests.yml. Long term those tests might not make sense as we move to local testing with FakeHardware, but for now let's just do that.

Ok, makes sense 👍

Lets add a comment on the PR for the feature branch targeting master, to remind us to update the Plugin Test Matrix when the branch is eventually merged - removing the IBMQ tests will need to be reflected here (but not until the tests are removed on master)

Done.

About the tests being removed, will we be still testing for 0.46 or removing them fully? 🤔

We will be removing them fully. 0.46 and previous versions will no longer be supported.
TL;DR: In October Qiskit will no longer support 0.46 and previous versions accessing the real hardware, so it doesn't make sense for us to support it on the July release just to deprecate it in October.


Installed server can't find html files

Opening the web page at / using server_dev.py works fine, but opening it with the installed version of the server does not since it's searching for the html files in a place where they haven't been installed.
$ ga4gh_server wormtable ga4gh-example-data
 * Running on http://<IP_ADDRESS>:8000/ (Press CTRL+C to quit)
 * Restarting with stat
Traceback (most recent call last):
  File "/Users/dannyc/ga4gh/new/lib/python2.7/site-packages/flask/app.py", line 1475, in full_dispatch_request
    rv = self.dispatch_request()
  File "/Users/dannyc/ga4gh/new/lib/python2.7/site-packages/flask/app.py", line 1461, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "build/bdist.macosx-10.10-intel/egg/ga4gh/frontend.py", line 117, in index
    'index.html', info=app.serverStatus.getStatusInfo())
  File "/Users/dannyc/ga4gh/new/lib/python2.7/site-packages/flask/templating.py", line 127, in render_template
    return _render(ctx.app.jinja_env.get_or_select_template(template_name_or_list),
  File "/Users/dannyc/ga4gh/new/lib/python2.7/site-packages/jinja2/environment.py", line 830, in get_or_select_template
    return self.get_template(template_name_or_list, parent, globals)
  File "/Users/dannyc/ga4gh/new/lib/python2.7/site-packages/jinja2/environment.py", line 791, in get_template
    return self._load_template(name, self.make_globals(globals))
  File "/Users/dannyc/ga4gh/new/lib/python2.7/site-packages/jinja2/environment.py", line 765, in _load_template
    template = self.loader.load(self, name, globals)
  File "/Users/dannyc/ga4gh/new/lib/python2.7/site-packages/jinja2/loaders.py", line 113, in load
    source, filename, uptodate = self.get_source(environment, name)
  File "/Users/dannyc/ga4gh/new/lib/python2.7/site-packages/flask/templating.py", line 60, in get_source
    return loader.get_source(environment, local_name)
  File "/Users/dannyc/ga4gh/new/lib/python2.7/site-packages/jinja2/loaders.py", line 163, in get_source
    f = open_if_exists(filename)
  File "/Users/dannyc/ga4gh/new/lib/python2.7/site-packages/jinja2/utils.py", line 150, in open_if_exists
    return open(filename, mode)
IOError: [Errno 20] Not a directory: u'/Users/dannyc/ga4gh/new/lib/python2.7/site-packages/ga4gh-0.1.0a1-py2.7.egg/ga4gh/templates/index.html'

Could not reproduce.
(Was this triggered immediately, or is it a response to some client action?)
$ ga4gh_server wormtable ga4gh-example-data
 * Running on http://<IP_ADDRESS>:8000/
 * Restarting with reloader

I'm getting various client errors, so it could be a problem on my end...

You may have an unzipped egg in your site-packages for some reason?  Try blowing any ga4gh packages away and reinstalling and then trying to reproduce.

Fixed in #149


Test should NOT be launched in Source Control Tree View

Describe the bug
When trying to revert a change that happens to be on a "test" line, tests are started and cause problems. This can even pollute the screen with no way to get rid of the error message.

As a bonus, the error message is very annoying. The only way to make it go away is to quit VS Code. I think this is because the extension does not correctly support .each tests.

To Reproduce
Steps to reproduce the behavior on the example project:

Open a test file.
Add .skip after one of the tests: test(... => test.skip(...
Open Source Control View

Try to "Revert" the change using the -> without running the test by just clicking on the arrow.

Expected behavior
As a user, I do not want tests to run when I'm trying to revert code changes.
Screenshots
Added above.
Environment
(Paste info.txt content generated by the example project)

Version: 1.78.0 (Universal)
Commit: 252e5463d60e63238250799aef7375787f68b4ee
Date: 2023-05-03T20:11:00.813Z
Electron: 22.4.8
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 22.4.0
Sandboxed: Yes
Vitest version: vitest/0.29.8 darwin-x64 node-v16.18.1
Vitest plugin version: v0.2.39

Additional context
Add any other context about the problem here.

This should be fixed in pre-release 0.5.0 and higher. Note that the extension now requires Vitest 1.4.0 or higher.


Pronouns

u could ad a feature that also changes your pronouns in things like emails or similar stuff.
Also more languages would be very usefull then

This is confusing because it would replace other pronouns like if there was a person who identified as male but you were MtF, wouldn't it replace him with her, his with her's, etc. ?

u could ad a feature that also changes your pronouns in things like emails or similar stuff.
Also more languages would be very usefull then
That would require detection of context, which is harder than it sound so idk if that would be possible

Hi @Ellii13, thanks for the suggestions!
Regarding pronouns, as @aubymori pointed out, it's unfortunately not practical. See #22, and feel free to leave additional feedback there.
Regarding other languages, would that be to have the extension's text be in multiple languages? That would be possible to implement and something I can keep in mind! To be transparent, it falls low on my current priority list but I do see the benefit of eventually implementing it.
I'm going to close this issue as duplicate, but I will definitely keep the additional languages suggestion in mind. I'll add it to my todo list to create an issue specifically for additional languages


How to use with Rack?

How would I use this with a Rack app? I don't have a config object.

I never tried that. That config object is from mongoid gem, https://github.com/mongoid/mongoid/blob/master/lib/mongoid/config.rb.

You need to make mongoid work with rack app firstly.


EvaluateHoldout() function Failed

Expected behaviour
Should pass the following code:
train_arf = FileStream("covtype.csv")
train_arf.prepare_for_use()
ARF = AdaptiveRandomForest()
evaluator = EvaluateHoldout (max_time=1000, n_wait=1, batch_size = 10, metrics=['accuracy', 'true_vs_predicted'], dynamic_test_set=True)
evaluator.evaluate(stream=train_arf, model=ARF,model_names=['ARF'])
Actual behaviour
Error:  'NoneType' object is not subscriptable
Steps to reproduce the behaviour
I used the covtype.csv data from the data file.

[Note: For comments and usage-related questions please consider the users group.

If you reduce the max_samples in EvaluateHoldout, it will work correctly.
evaluator = EvaluateHoldout (max_time=1000,max_samples=1000, n_wait=1, batch_size = 10, metrics=['accuracy', 'true_vs_predicted'], dynamic_test_set=True)

Did the evaluating bar reaches 100% when you have this error ?
Evaluating...
 #################### [99%]

Yes, it is. The error shows after the evaluation bar reaches 100%.
On Mon, Feb 4, 2019 at 3:38 PM Walid Gara<EMAIL_ADDRESS>wrote:

If you reduce the max_samples in EvaluateHoldout, it will work correctly.
evaluator = EvaluateHoldout (max_time=1000,max_samples=1000, n_wait=1, batch_size = 10, metrics=['accuracy', 'true_vs_predicted'], dynamic_test_set=True)
Did the evaluating bar reaches 100% when you have this error ?
Evaluating...
#################### [99%]
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/scikit-multiflow/scikit-multiflow/issues/85#issuecomment-460403769,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXokZ5wWYB7wLQ3m5MKk6RBhej3XjXG7ks5vKJotgaJpZM4ah4BW
.

Yes, you are correct. I change the max_time to max_samples, and it works
fine.
On Mon, Feb 4, 2019 at 3:56 PM Yanjia Zhang<EMAIL_ADDRESS>wrote:

Yes, it is. The error shows after the evaluation bar reaches 100%.
On Mon, Feb 4, 2019 at 3:38 PM Walid Gara<EMAIL_ADDRESS>wrote:

If you reduce the max_samples in EvaluateHoldout, it will work correctly.
evaluator = EvaluateHoldout (max_time=1000,max_samples=1000, n_wait=1, batch_size = 10, metrics=['accuracy', 'true_vs_predicted'], dynamic_test_set=True)
Did the evaluating bar reaches 100% when you have this error ?
Evaluating...
#################### [99%]
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/scikit-multiflow/scikit-multiflow/issues/85#issuecomment-460403769,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXokZ5wWYB7wLQ3m5MKk6RBhej3XjXG7ks5vKJotgaJpZM4ah4BW
.

Good! Also, I get this error when I leave it running.
Time limit reached (1000.00s). Evaluation stopped.

Yes, you are correct. I change the max_time to max_samples, and it works fine.
…
On Mon, Feb 4, 2019 at 3:56 PM Yanjia Zhang @.> wrote: Yes, it is. The error shows after the evaluation bar reaches 100%. On Mon, Feb 4, 2019 at 3:38 PM Walid Gara @.> wrote: > If you reduce the max_samples in EvaluateHoldout, it will work correctly. > > evaluator = EvaluateHoldout (max_time=1000,max_samples=1000, n_wait=1, batch_size = 10, metrics=['accuracy', 'true_vs_predicted'], dynamic_test_set=True) > > Did the evaluating bar reaches 100% when you have this error ? > > Evaluating... > #################### [99%] > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#85 (comment)>, > or mute the thread > https://github.com/notifications/unsubscribe-auth/AXokZ5wWYB7wLQ3m5MKk6RBhej3XjXG7ks5vKJotgaJpZM4ah4BW > . >

Thanks for the info @yzhang17usf and @garawalid, it helped me out to figure this out quickly.
Two things:

The test configuration is a little unexpected given that you are setting the train set (n_wait) equal to one, while the default test_size is 5000.
The error was triggered for this unexpected configuration. I have committed a fix (6fd86e40dfbacd9ac9c5eb0ba6590f33450772cb) to address this scenario. Let me know if this works.

Now, two comments:

When using holdout evaluation you have control over the number of train and test samples. The usual setup is having a smaller test set, the default values are n_wait=10000 and test_size=5000.
The holdout class does not support the option to save all test results into a file (even if you set n_wait = 1)

Thank you for explaining these. Does there have Concept Drift Hoeffding
Tree?
Best,
Yan
On Tue, Feb 5, 2019 at 11:19 AM Jacob<EMAIL_ADDRESS>wrote:

Thanks for the info @yzhang17usf https://github.com/yzhang17usf and
@garawalid https://github.com/garawalid, it helped me out to figure
this out quickly.
Two things:

The test configuration is a little unexpected given that you are
setting the train set (n_wait) equal to one, while the default
test_size is 5000.
The error was triggered for this unexpected configuration. I have
committed a fix (6fd86e4
https://github.com/scikit-multiflow/scikit-multiflow/commit/6fd86e40dfbacd9ac9c5eb0ba6590f33450772cb)
to address this scenario. Let me know if this works.

Now, two comments:

When using holdout evaluation you have control over the number of
train and test samples. The usual setup is having a smaller test set, the
default values are n_wait=10000 and test_size=5000.
The holdout class does not support the option to save all test
results into a file (even if you set n_wait = 1)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/scikit-multiflow/scikit-multiflow/issues/85#issuecomment-460700916,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXokZzfZFkIUkBbH_s3pK-y4WVePXa-Oks5vKa8DgaJpZM4ah4BW
.

What do you mean by Concept Drift Hoeffding Tree? The closest method I can think of is the Hoeffding Adaptive Tree which is available in the package.

Sorry, it is called Concept-adapting Very Fast Decision Tree learner.
On Wed, Feb 6, 2019 at 6:53 AM Jacob<EMAIL_ADDRESS>wrote:

What do you mean by Concept Drift Hoeffding Tree? The closest method I can
think of is the Hoeffding Adaptive Tree which is available in the
package.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/scikit-multiflow/scikit-multiflow/issues/85#issuecomment-460996856,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXokZw3CGxrno0XwwrrrIdpp7K3046Afks5vKsIkgaJpZM4ah4BW
.

I see, scikit-multiflow does not have an implementation of CVFDT, hoewever the Hoeffding Adaptive Tree is a drift aware metod that has been shown to have better performance than CVFDT:
http://www.lsi.upc.edu/~abifet/Adwin-DT.pdf

Thank you so much.
Best,
Yan
On Wed, Feb 6, 2019 at 8:57 AM Jacob<EMAIL_ADDRESS>wrote:

I see, scikit-multiflow does not have an implementation of CVFDT,
hoewever the Hoeffding Adaptive Tree is a drift aware metod that has been
shown to have better performance than CVFDT:
http://www.lsi.upc.edu/~abifet/Adwin-DT.pdf
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/scikit-multiflow/scikit-multiflow/issues/85#issuecomment-461031908,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXokZ4X06jczx9h4xAXETE9WvD3LcOg7ks5vKt9fgaJpZM4ah4BW
.


Update da-dynamodb-client, da-s3-client to 0.1.30

About this PR
📦 Updates

uk.gov.nationalarchives:da-dynamodb-client
uk.gov.nationalarchives:da-s3-client

from 0.1.27 to 0.1.30
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "uk.gov.nationalarchives" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "uk.gov.nationalarchives" }
}]

labels: library-update, early-semver-minor, semver-spec-patch, commit-count:1

Superseded by #49.


Transcend 16GB JetFlash 770 USB 3.0 Flash Drive

Is the device compatible. I want to test it. I have one. But I have no Idea where to find a burner image.

What's the mico controller ?

At the back of the device i could find these two numbers. D33193 N14939.
Are these relevent?


Add Test cases

Is your feature request related to a problem? Please describe.
Need a set of test cases and scripts to ensure new code does not break functionalities.

Should extend run1.sh and run2.sh to check the output of modified scripts against known outputs.

Depends on #84.


Poi graph

Added the POI to the OSM graph and added visualization for it.

resolved conflicts. ready

@googlebot I fixed it.


RepoDb::getFtsQuery() should preprocess full_text_search.raw before passing it to the ts_headline() for identifiers

arche-core 5.3.4 started indexing identifier URI path elements as separate segments. This makes search queries match but also breaks the highlighting of the result cause the ts_headline() is unable to find the search phrase in the raw value. See arche-core's fullTextSearch2 test.

Fixed by b4d8d492d6fedc3c84a85e726ee0d66af220e447


use error dialog instead of notification

this was brought up by Karl in one of the review meetings, we should use the error dialog to show errors instead of the notification which is too small and not obvious.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 48.249%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
14799

Relevant Lines:
29107

💛  - Coveralls


QueueUriBuilder handles docker hostnames.

Fixes #16542

Hi @PureKrome.  Thank you for helping to improve the Azure SDK experience and for your contribution.  I've added some tags to help route this to the team members best able to provide feedback.

Hi! We appreciate your contribution!
I actually was already going ahead and resolving this issue by not only adding it in Queues but also in SMB Files.
https://github.com/Azure/azure-sdk-for-net/pull/15972
Is it okay if I close your PR in preference to the PR I just linked since we are going to look to merge this PR soon? Thanks!

Ah yes - you've done the same code. NP, i'll close this. sorry to have wasted your time.


The directory where pyenv installs python is the same as the directory where pyenv-virtualenv puts venv.

I think the plugin should only show venv directory.

Hi,
Im not sure what this means. You mean removing the last /venv part from the listed venvs?

pyenv install 3.10.12 install python 3.10.12 in ~/.pyenv/versions.
pyenv virtualenv 3.10.12 venv-31012 create a virtual environment in ~/.pyenv/versions.

I mean, only venv-31012 is virtual environment. VenvSelector should not display 3.10.12

Oh ok, I see what you mean now. Thank you. Im not too familiar with pyenv, and I didnt know it would install python itself inside the same path. I will see what i can do. :)

This is fixed now in the latest commit. The plugin excludes any  '3..' paths when searching for venv managers. Its not a perfect solution but fd doesnt understand regexp in excluding paths, so this was the best I could do without having my own filter function and do a secondary filter inside lua.
Hopefully people dont name their managed venvs in the same way as python versions, because then they wont show up.

Maybe we can check pyvenv.cfg if exists in the venv folder.

You mean to only exclude the path if there is a pyvenv.cfg in the venv folder?


head_navbar.tmpl not working as expected

Gitea version (or commit ref):
1.12.2
Git version:
2.20.1
Operating system:
GNU/Linux (Arch)
Database (use [x]):

[x ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[ x] Not relevant

Log gist:

Description
I am using the template found here using this guide to customize gitea. I just wanted to change the favicon and the logo in the top left for now. But I can't even get the template to work. I've placed that template in custom/template/base/ as head_navbar.tmpl and I get the error seen below:
template: base/head_navbar:154:7: executing "base/head_navbar" at <svg>: wrong number of args for svg: want 2 got 1

That template is for master (1.13) rather than your version (1.12).
The template you want is https://github.com/go-gitea/gitea/blob/release/v1.12/templates/base/head_navbar.tmpl


DOC: optimize: small doc changes in P0 and tol

fixes some minor doc issues I noticed in most recent commit.

Thanks. I noticed that math would have been better than code in the last PR, but let it slide. This fixes it.


Support unbuntu

Support build on ubuntu

Test:
https://github.com/sophia-guo/build-jdk-hotspot/runs/644289385?check_suite_focus=true

jdk14:
https://github.com/sophia-guo/build-jdk-hotspot/runs/644507309?check_suite_focus=true
hit gradle issue.

JDK14 gradle issue fixed:
got error
HEAD is now at 2ac3c1dbc5 Merging origin/master HEAD into dev
Pulling latest tags and getting the latest update version using git fetch -q --tags
NOTE: This can take quite some time!  Please be patient
From /Users/runner/runners/2.169.1/work/runaqaTest/runaqaTest/openjdk-build/workspace/./build//src
 * branch                  HEAD       -> FETCH_HEAD
WARNING: Failed to identify latest tag in the repository
Unable to detect git tag, exiting...
#

https://github.com/sophia-guo/runaqaTest/runs/647481346?check_suite_focus=true

JDK13 with openj9:
ubuntu cuda update:
checking for m4... /usr/bin/m4
configure: error: The path of cuda_home, which resolves as "/usr/local/cuda-9.0", is not found.
configure exiting with result code 1
##[error]The process '/home/runner/work/runaqaTest/runaqaTest/openjdk-build/makejdk-any-platform.sh' failed with exit code 2

Mac:
make[3]: warning: -jN forced in submake: disabling jobserver mode.
Staging OpenJ9 sourcetools in /Users/runner/runners/2.169.1/work/runaqaTest/runaqaTest/openjdk-build/workspace/build/src/build/macosx-x86_64-server-release/vm
tar: Error : invalid date string
make[3]: *** [stage-openj9-tools] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [j9vm-build] Error 2
make[2]: *** Waiting for unfinished jobs....
Compiling 19 properties into resource bundles for jdk.compiler

ERROR: Build failed for targets 'product-images mac-legacy-jre-bundle test-image' in configuration 'macosx-x86_64-server-release' (exit code 2)

No indication of failed target found.
Hint: Try searching the build log for '] Error'.
Hint: See doc/building.html#troubleshooting for assistance.

make[1]: *** [main] Error 2
make: *** [product-images] Error 2
##[error]The process '/Users/runner/runners/2.169.1/work/runaqaTest/runaqaTest/openjdk-build/makejdk-any-platform.sh' failed with exit code 3
 Run ${{ steps.buildJDK.outputs.BuildJDKDir }}/bin/java -version

https://github.com/sophia-guo/runaqaTest/runs/647478628?check_suite_focus=true

issues with openj9 on ubuntu will be fixed by next pr.

Test hotspot ubuntu jdk13: https://github.com/sophia-guo/build-jdk-hotspot/pull/3/checks?check_run_id=657480490


style(userspace/engine): avoid creating multiple versions of methods only to assume default ruleset. Use a default argument instead.

Signed-off-by: Federico Di Pierro<EMAIL_ADDRESS>What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind cleanup
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
Avoid creating multiple methods to only route that m_default_ruleset to main method; properly use a default argument instead.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: a04ae9896957440614fd60905f64dbca1bc3c30c

LGTM label has been added.  Git tree hash: a9cf792f1732d0079c2297ba402c90adc016bb61

Closing and reopening to trigger the CI
/close

@leogr: Closed this PR.

In response to this:

Closing and reopening to trigger the CI
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/reopen

@leogr: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/milestone 0.31.0


[MXNET-483] C++ tests for mkldnn convolution operator

Description
Add tests for MKLDNN convolution operator
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Add tests for MKLDNN convolution operator

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

@zheng-da can you review

@sethman please take a look as well

this PR is pending merge of https://github.com/apache/incubator-mxnet/pull/11831

kk it was merged. @zheng-da please review

sorry for the late review.

@azai91 bumping - note the review feedback

@azai91 ping for addressing review comments.
@sandeep-krishnamurthy Please change label to pr-awaiting-response

@mseth10 @zheng-da ping!
Could you please take a look?

@mseth10 @zheng-da @anirudh2290 - can you guys please take a look? this has been open for a long time. Thanks!

@lupesko Already reviewed and approved.

@lupesko I guess @azai91 has merged his changes to #13084 and there is no need to review this one.

@TaoLv this PR already got many reviews and one approval. Is it okay to merge this PR, or you have further unaddressed comments?

@eric-haibin-lin, need @azai91 's inputs about the difference of this PR and #13084.

#13084 is a branch off of this PR that includes the BN unit tests. we should merge this one first and then we can more easily review #13084.

@TaoLv I checked that this PR does not cause regression.

what MKL-DNN warnings? are they introduced in this PR or were they always present? if they were already present, then let's file an issue and tackle in a separate PR.

Thanks, @azai91 .  I noticed that there were many warnings when built mkldnn cpp test with Makefile. It would be great if you can take a look and fix them. Not necessarily in this PR.

The warnings are related to batch norm test and implicit_gemm in mshadow. Since they are not being modified in this PR, I think its fine if they are not fixed in this PR.

@azai91 @anirudh2290 thanks for the help and great works to improve the quality of MKL-DNN.


Quantisation of the inputs

Hey, wanted to ask, are you using precomputed quantized int8 VAE states?
I see you do it for T5 but not sure for VAE states?
If so have you seen any quality degradation?
Thanks!

The reason is rather funny. Only becase VAE were TINY compared to T5, it really didnt make sense to quantize it hahaha


[python] status is not a field of ResponseFunctionCallOutputItem

Please provide us with the following information:

This issue is for a: (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

In Python implementation, ResponseFunctionCallOutputItem contains a required field of status
https://github.com/Azure-Samples/aoai-realtime-audio-sdk/blob/87ca3d66a20dffac4b90ff1446f153504437ff08/python/rtclient/models.py#L365-L367
https://github.com/Azure-Samples/aoai-realtime-audio-sdk/blob/87ca3d66a20dffac4b90ff1446f153504437ff08/python/rtclient/models.py#L383-L386
While the openapi definition has no such field
https://github.com/Azure-Samples/aoai-realtime-audio-sdk/blob/87ca3d66a20dffac4b90ff1446f153504437ff08/realtime-openapi3.yml#L1078-L1083

Fixing this same problem in js in this  PR #60, will close this once I generate new versions for both languages


ngMockE2E with request in .config

Hello,
I have http requests happening in the .config method that is basically loading i18n dictionaries. How can I do a passthrough for this when the $httpBackend is being executed in the run method?
I'm also dynamically adding the angular-mock file and a new file with the run method with the $httpBackend param if its the dev environment. This means I can't include something like an $httpBackendProvider (if there is one) in the config, because it will not exist in production.
Is there a way to tell my $translateProvider in the config to wait until the .run($httpBackend) has finished executing or any other solution is welcomed.

@shawnmclean - I am not clear what you are trying to achieve here. You cannot use any Angular services in the config phase of an application. This is purely for setting up services before they are created.
Also, in Angular 1 the idea of loading code after the application has started is not yet supported. So if you want to have angular-mocks loaded then this needs to be done statically before the application starts.

So my issue was fixed by removing http calls from the .config phase.

Glad you got it working.


MM-42835_Invite People - add email+user invites

Summary
Adding the functionality to invite users by email or invite users from other teams on the server
Ticket Link
https://mattermost.atlassian.net/browse/MM-42835
Checklist

[x] Added or updated unit tests (required for all new features)
[x] Has UI changes
[x] Includes text changes and localization file updates
[x] Have tested against the 5 core themes to ensure consistency between them.

Device Information
This PR was tested on:

iPhone 13, iOS 15.2
Pixel 4, Android 12

Screenshots
Share link

Send email invite

Invite user to team

User already in team

Handle both sent and not sent invites

Release Note
- Adding functionality to invite users by email or invite users from other teams on the server

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/26959
https://circleci.com/gh/mattermost/mattermost-mobile/26958

Artifact links:
https://output.circle-artifacts.com/output/job/49b832c8-513b-4d05-825c-2f61ceb6e1ff/artifacts/0/tmp/artifacts/Mattermost_Beta.apk
https://output.circle-artifacts.com/output/job/35e3c72d-24b9-4b95-9f28-b61b1c9750c0/artifacts/0/tmp/artifacts/Mattermost_Beta.ipa

@matthewbirtch the input used here does not have a label at the top left, is that expected? If so why? Every other input has it

@matthewbirtch the input used here does not have a label at the top left, is that expected? If so why? Every other input has it

Yes @enahum this is intentional and as designed. Because the input field is so close to the title it is a bit redundant to have a label on the input field as well. It's just extra noise that isn't needed in this case.

@matthewbirtch

Can we auto-focus on the input field when the invite modal opens?
Done
There seems to be some positioning issue with the autocomplete when the keyboard is open. The autocomplete popover seems to be hidden in behind the keyboard while the software keyboard is open. Check out this screen recording:
Fixed
In the autocomplete popover, can we add a bit of vertical padding on the list (8 should do it) of the list to balance the spacing a bit better
Done
While entering a user or email address it seems like there is a significant delay (testing on simulator) before the autocomplete shows results. It doesn't seem to narrow the results at all until I've stopped typing for 1-2 seconds. That feels too long to wait.
Reduced timeout
The autocomplete popover doesn't have a shadow on iOS. I see an shadow added int he code, but it doesn't seem to be rendering. I think there is an overflow clipping this and preventing the shadow from being visible
Fixed
I was able to successfully invite myself even though I'm already on the team. I think it should show as "not sent" with a message that "This person is already on the team" in this case shouldn't it?
Updated to not be able to add email of actual user, same as in webapp.
If I enter an email address then turn off my wifi and try to send, I get an endless spinner. We should probably timeout here sooner and show the error summary state with an explanation that there was a connectivition issue.
Updated generic service error handling, please check wording for the error message:

On the summary screen, can we add a max width on the main content area? I think we can make it 480.
Done
On the summary screen, can we make the bottom margin on the title 24 instead of 16?
Done

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/27326
https://circleci.com/gh/mattermost/mattermost-mobile/27325

Artifact links:
https://output.circle-artifacts.com/output/job/4e57a3a3-cc56-4455-b27f-92dc2dac085d/artifacts/0/tmp/artifacts/Mattermost_Beta.ipa
https://output.circle-artifacts.com/output/job/21b620d6-32c3-4276-bd8e-a2ce589954d3/artifacts/0/tmp/artifacts/Mattermost_Beta.apk

Thanks @julmondragon. Those changes look good. Just this last one I think:

7. If I enter an email address then turn off my wifi and try to send, I get an endless spinner. We should probably timeout here sooner and show the error summary state with an explanation that there was a connectivition issue.

Updated generic service error handling, please check wording for the error message:

Can we update the error screen as follows:
Invitations could not be sent successfully
Something went wrong while trying to send invitations. Please check your network connection and try again.
[Try again]

And can we add the 'Back' button in the top nav bar on this screen to go back?

Building app in separate branch.

@matthewbirtch

Can we update the error screen as follows:
Invitations could not be sent successfully Something went wrong while trying to send invitations. Please check your network connection and try again. [Try again]
And can we add the 'Back' button in the top nav bar on this screen to go back?

Done

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/27473
https://circleci.com/gh/mattermost/mattermost-mobile/27472

Artifact links:
https://output.circle-artifacts.com/output/job/06988b52-5be1-4d6f-aaab-daf1c4894b0b/artifacts/0/tmp/artifacts/Mattermost_Beta.ipa
https://output.circle-artifacts.com/output/job/d37e2b19-560c-44f2-b9fd-10327a75e3ce/artifacts/0/tmp/artifacts/Mattermost_Beta.apk

@enahum @matthewbirtch @pvev All feedback addressed now.
@stevemudie This should be good to start QA review

Thanks @julmondragon. Looks good. I have a question about the 'Try again' button in this new error screen, though. When I tap it, it just takes me back to the invitation screen with nothing filled in. I was more expecting 'Try again' to try sending the invitation(s) again rather than take me back to the previous screen. Can you clarify what action is performed when I tap this button?

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/27490
https://circleci.com/gh/mattermost/mattermost-mobile/27489

Artifact links:
https://output.circle-artifacts.com/output/job/a227f978-4393-43bf-8efb-797bc995e594/artifacts/0/tmp/artifacts/Mattermost_Beta.apk
https://output.circle-artifacts.com/output/job/26f158d2-4540-40a4-924c-9e1fd255e284/artifacts/0/tmp/artifacts/Mattermost_Beta.ipa

@matthewbirtch @stevemudie  The error screen was updated now to:

Have two buttons at the bottom: [Go back] [Try again]
In the top nav bar, having the close button
[Go back] button will take user to the selection screen preserving the invitations
[Try again] button will attempt sending the invitations again

The changes look great @julmondragon!

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/27497
https://circleci.com/gh/mattermost/mattermost-mobile/27496

Artifact links:
https://output.circle-artifacts.com/output/job/c18493d9-c510-47b3-975d-531b62dc0c45/artifacts/0/tmp/artifacts/Mattermost_Beta.ipa
https://output.circle-artifacts.com/output/job/80dc523d-08ea-46da-bee2-c4b4a0fa9924/artifacts/0/tmp/artifacts/Mattermost_Beta.apk

Going to approve this to unblock. I sent you a DM with a couple minor tweaks on tablet possibly, but nothing blocking
@matthewbirtch
cc @stevemudie

Updated to cover min width issues in tablet when in summary:

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/27532
https://circleci.com/gh/mattermost/mattermost-mobile/27531

Artifact links:
https://output.circle-artifacts.com/output/job/bea59846-278c-4dc6-b2f2-1223b8c59c06/artifacts/0/tmp/artifacts/Mattermost_Beta.apk
https://output.circle-artifacts.com/output/job/3055a00f-3902-4622-ac79-8124ca7313c2/artifacts/0/tmp/artifacts/Mattermost_Beta.ipa

@avinashlng1080 @jfrerich @pvev thanks for the feedback, all changes should be covered now.

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/27580
https://circleci.com/gh/mattermost/mattermost-mobile/27579

Artifact links:
https://output.circle-artifacts.com/output/job/a0264ada-4145-44b8-864e-4779c18d3a72/artifacts/0/tmp/artifacts/Mattermost_Beta.apk
https://output.circle-artifacts.com/output/job/2e4e32d0-d2d2-42b8-82e2-641926859a65/artifacts/0/tmp/artifacts/Mattermost_Beta.ipa

@enahum Thanks for the feedback, all should be addressed now.

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/27598
https://circleci.com/gh/mattermost/mattermost-mobile/27597

Artifact links:
https://output.circle-artifacts.com/output/job/d2088ae7-3623-4bb7-bac9-ba84191e5ff9/artifacts/0/tmp/artifacts/Mattermost_Beta.ipa
https://output.circle-artifacts.com/output/job/2ad8a455-3ead-4afa-9d70-184cb6ca3f01/artifacts/0/tmp/artifacts/Mattermost_Beta.apk

@jfrerich are we reintroducing the team drop down now that the view members, invite people options are in the product?

@jfrerich are we reintroducing the team drop down now that the view members, invite people options are in the product?

I don't think view team members is available, just view channel members @esethna

I cannot attest to the view team members, but we do will have view channel members.


Poor narrowing of contextual unions that don't share properties

Bug Report
In cases with discriminant unions that don't fit the conventional form (e.g. one property that's constant among all union members) type discrimination doesn't happen as one might expect or desire, see the code example.
I tried to search to see if this had been talked about before, but couldn't find anything. I imagine the current design was around capturing a common pattern in js while not spending too much time trying to narrow the types.
To address this in the same framework: discriminateTypeByDiscriminableItems and isDiscriminantProperty would have to be tweaked to handle missing properties and it's not clear how that would work with exactOptionalPropertyTypes. Alternatively, the existing code may work by first filtering the union down to feasible assignments based on the exitance of properties, e.g. only consider types that the object literal has every non-optional property. However, doing that correctly would require constructing a filtered union type and I'm not sure if there's precedent for that.
Doing any of this will likely cause a performance penalty, so I think it's also fair to say this pattern is infrequent enough to not care about getting correct.
🔎 Search Terms
discriminant unions narrowing
🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about 3.3

⏯ Playground Link
Playground link with relevant code
💻 Code
type DiscriminatorA = {
    a: true;
    cb: (x: string) => void;
}

type DiscriminatorB = {
    b: true;
    cb: (x: number) => void;
}

declare function f(options: DiscriminatorA | DiscriminatorB): void;

f({
    b: true,
    cb: n => n.toFixed()
});

🙁 Actual behavior
Parameter 'n' implicitly has an 'any' type.(7006)
🙂 Expected behavior
type checks successfully

I understand they're not sealed, but as written, the object literal
{
    b: true,
    cb: n => n.toFixed()
}

is not assignable to DiscriminatorA. I'm not saying it should generally reject one or the other, I'm saying when called with a literal, it should be able to infer the function type in these cases.

It could be made to work for that case, but raises other questions like what to do with this
f({
    a: true,
    b: true,
    cb: n => n // string | number? string & number?
});

Overall I think your assessment of trade-offs is correct -- this pattern doesn't really work outside this immediate example and isn't worth spending cycles on


[Question] How to use llama2 for typical NLP tasks?

I am wondering how we could adapt the example.py files provided to undertake tasks such as:

Identify the extent of positive sentiment and negative sentiment in the following text.
Detect PERSON names entities and return the result as a json string.

Thanks!
sbs

@santoshbs I tried to fine tune the dataset it requires the huge GPU and also tried the RAG using Langchain and pinecone. Many Llama-2 model hallucinated for entity extraction. So I think it is necessary to combine fine tuned model with RAG with vector database.

Hi! With the improvement of Llama 3 70B, it should perform well on many NER tasks without any fine-tuning. You can follow this tutorial but use Llama3 70B cloud API instead. If you want to fine-tune, you can follow this tutorial. Let me know if there are more questions.


Manually translated version of the tutorial (Simplified Chinese)

After 3 months, 2 translated versions, I finally completed the simplified Chinese version of the Flame basic tutorial! There are quite a lot of game lovers and game developers in China, and I hope that Flame can carry forward in China with good translation!

I will gradually change the code highlighting theme to prism.js to improve the aesthetics😃. Now the first tutorial has been replaced.

The above two issues have been fixed😃😃

Merging this then 👍


Memory inflation  Realm _pthread_body

Hi
**Bug **
The memory allocated to realm inflate steadily up 3M each we write an object (even if that object is an ID + a Bool).
Impact:
This  Unbounded memory growth is messing with the performance of our app big time. After at the end of the day the app lags terribly
Expected
Reduce the memory growth, and free up memory be able release realm Object

Version 2.10.1
Our  findings in Instrument (Snapshot Attached) :
-with the timer that the  _pthread_body, that has realm ref takes all resources
it seems to keeps all my object alive long after we are done looking at them ? Is that it?

with the allocation that
I tried to understand what exactly grow and found + 1M on _ContiguousArrayStorage every time.  Is this were realm object are stored?

_ContiguousArrayStorage is the backing storage for a Swift Array. As Realm is not implemented in Swift (the Swift API is a thin wrapper around the objective-c API) it is unlikely that these objects are being allocated directly by Realm. With the information provided I can't really make any guesses as to what is being allocated.

Thank you so much, this seems to have solved most of our issue!
unfortunately we had hope this would also solved our latency in our realm notification, but that is still a work in progress


feat: Initial support for Pandas timeseries backend.

Basic support for loading dataframes using Pandas. This is implemented using a Python callback function that loads the dataframe using Pandas, and then converts it to Polars.

This worked fine for me when running the tests with my virtual environment activated. However, I appreciate that may not be working for everyone. The CI has the same issue with the Rust workflows not having the correct Python libraries available.
If this is to go ahead we might need to merge the workflows or only run some of the tests in the Python workflows.
One general option is to add a "python" feature to the schema crate that would include things like this Pandas support.

What do you think is the best way forward with this?

I've featured gated the Rust tests that need a Python environment to work. They are not currently run in the CI.


Make the node client more tolerant towards db failure

Currently the connection object is created once when the Node service starts. If the db server happens to be down during the time, all future db queries will fail. The current workaround is to delay the app service start up for 10s - 30s, depending on machines.
This approach is not desirable, as this hard coded delay needs to be replicated at a few different places in the tutorial: scripts to start docker, Dockerfile, docker-compose.yml etc. For example, see comment http://disq.us/p/1bkyocw
Suggesting to recreate the connection object upon a connection failure. Not sure if this is the standard implementation, as I have not worked with Node.js before.

@edwastone awesome, thanks so much for the PR! 👍


use source of faker instead of compiled one

fixes #336
I haven't noticed any problem with my edits, the data is correctly randomized.
Tests fail with:
1) codeToCustomMetadata should catch errors correctly:

      AssertionError: expected { Object (err) } to deeply equal { Object (err) }
      + expected - actual

       {
      -  "err": "SyntaxError: Unexpected token u in JSON at position 26"
      +  "err": "SyntaxError: Unexpected token u"
       }

      at Assertion.assertEqual (plugins/react/node_modules/chai/lib/chai/core/assertions.js:485:19)
      at Assertion.ctx.(anonymous function) [as equal] (plugins/react/node_modules/chai/lib/chai/utils/addMethod.js:41:25)
      at Context.<anonymous> (codeToCustomMetadata.js:34:48)

But it fails even on master, so I don't think it's related to this PR

LGTM, @nikgraf?

nice, looks good


[SEDONA-186] Fix ordering of columns in results of queries like SELECT * A JOIN B

Did you read the Contributor Guide?

Yes, I have read Contributor Rules and Contributor Development Guide

Is this PR related to a JIRA ticket?

Yes, the URL of the assoicated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-186

What changes were proposed in this PR?
Fixes SEDONA-186 by properly assembling result rows of join queries when left and right sub plans were swapped.
How was this patch tested?
New tests were added to SpatialJoinSuite.
Did this PR include necessary documentation updates?

No, this PR does not affect any public API so no need to change the docs.

@Kontinuation I will merge this PR for now since we will release 1.3.0 in the next few days. Maybe we can address @Kimahriman 's comment in another PR.


definePlugin doesn't let you build dll in production, while running in development

For example:
new AutoDllPlugin({
    filename: '[name]-[hash].js',
    plugins: [
      new webpack.DefinePlugin({
        NODE_ENV: JSON.stringify('production')
      }),
   ], ...

The dll runs in development if that's what the parent is running in. It would be nice to get even smaller bundles this way.

+1

It doesn't build in production even if my main build is in production!
I am using Webpack 3.


Annotate for several splitters

There is a way to insert a annotation per splitter?
Now I'm using the annotate_text as below
self.camera.annotate_text = '{0} {2}'.format(self.banner, dt.datetime.now().strftime(self.dtFormat))
But I wanna to insert a identification per video recorded.

Not possible within the GPU code.
You'll note that the annotation is being set on self.camera, so the camera component. That is common to all output streams. There is no similar support in any other component within the firmware.
You could look at writing the annotation yourself onto image buffers pulled back to the ARM.

Closing old tickets; do feel free to re-open if you've further queries about this!


Adding/Removing consortium member

[ ] bug report -> please search issues before submitting
[x] feature request
[x] documentation issue or request
[ ] regression (a behavior that used to work and stopped in a new release)

Please, provide guided example of adding consortium member to the consortium and separating consortium member without assets lost on both sides.

We have docs on how to manage members in Workbench here: https://docs.microsoft.com/en-us/azure/blockchain/workbench/manage-users

@brendalee managing member and  managing consortium member two different things. Document you have provided do not apply.

@brendalee  please re-open. Do not want to create a new ticket


Web engine fallback font initialization adds too much to first frame time.

In profiling the counter demo
flutter run -d chrome --profile
I see 80-100ms is spent in the first frame in  FallbackFontManager.createNotoFontTree
(This is on Chrome 115.0.5790.110 (Official Build) (64-bit) in Linux, on a powerful workstation, but I don't think the problem is specific to that configuration)
The code constructs an interval tree of ~25k nodes.

[ ] The initialization happens even if fallback fonts are not needed (as in the counter demo). Perhaps the initialization could be lazy, or async with substeps.
[x] Half of the time is spent in sorting. I have recently improved sorting and expect that to reduce from ~50ms to ~10ms https://github.com/dart-lang/sdk/commit/74242b1b6ceb9ff7666e66ea75921a871a692be9
[ ] 10-15% of the time is spent copying lists via sublist in the recursive makeBalancedTree. Rewriting makeBalancedTree to use a [start,end) range as parameters could completely remove this overhead.
[ ] NotoFont._unpackFontRange takes ~10%. I am working on a new encoding which should be faster because it parses fewer characters, but it still has to allocate ~25k ranges.

A more complicated idea would be to try to avoid the interval tree. The interval tree has ~25k nodes but if this is transformed into a non-overlapping range tree, there would be ~22k nodes. The nodes would then need to map to the set of fonts supporting the code point (range). This tree would be directly useful and could be 'unpacked' in approximately the same time as the aggregate calls to NotoFont._unpackFontRange. If the fallback algorithm was modified to not need NotoFont.contains, so the ranges list was not needed, this unpacking could replace _unpackFontRange.
The fallback algorithm has some inefficiencies too, but I am not sure how important that is, since one remedy is to bundle a font covering the missing code-points.

Hi @rakudrama
I'm verifying this issue but I'm not quite familiar with Chrome DevTools, can you please be more specific on Steps to reproduce the issue?  And please provide the output of flutter doctor -v as well. Thank you!


Feature/add xml upload forms

Description
First PR adds xml upload form component and some basic frontend stuff (navbar etc). Tried to focus on logic, not UI.
Related issues
Fixes #1
Type of change

[x] New feature (non-breaking change which adds functionality)

Changes Made

Xml upload form with validation for basic errors
api-service for backend
redux-based state management for global states (such as which object type is being handled)

Testing
[x] Unit Tests

@blankdots I added some tests, this is now ok to review

the code LGTM for now. I would make some changes to CSS to have a more polished UI, but this could be addressed in a different issue.
I would go with an Wizard Design pattern for the Submission process e.g.
* https://uxplanet.org/wizard-design-pattern-8c86e14f2a38

* https://miro.medium.com/max/1322/1*ePnjt7Mywi6RVrRu61rmuQ.png

Good good. Theres actually issue about styles: https://github.com/CSCfi/metadata-submitter-frontend/issues/4 Going to focus on that when program logic is ok.


Cannot read property 'Show' of undefined [iOs] BUG CRASH

1 - install de library in iOs...
2- Use the code behind:
  Tooltips.Show(                     this.phone,                     this.target,                     {                       text: phoneString,                       textSize: 16,                       autoHide: true,                       duration: 3000,                     },                   );
4- the erro screnn show the error Cannot read property 'Show' of undefined iOs
5 The same happen with de react code.

hi everyone......any news about this issue?..
Regards.

Please make sure to link the library correctly and rebuild the app (react-native run-ios).
This is clearly an issue with RNTooltips not being installed.


update k8s-quickstart content

AKDC on k8s quick start is out of sync
per design review will move all of the manual steps content from AKDC to k8s-quickstart

@bartr We had this issue on AKDC at https://github.com/retaildevcrews/akdc/issues/17. We should close or the other.

update the Dev Cluster content to sync with AKDC
https://github.com/retaildevcrews/k8s-quickstart/tree/main/02-Dev-Cluster-Setup


Fix double-counting imports in VMOffsets calculations

This fixes an oversight in the initial creation of VMOffsets for a
module to avoid double-counting imported globals, tables, and memories
for calculating the size of the VMContext. Prior to this PR imported
items are accidentally also counted as defined items for sizing
calculations meaning that when a memory is imported but not defined, for
example, the VMContext will have a space for an inline
VMMemoryDefinition when it doesn't need to.
Auditing where all this relates to it appears that the only issue from
this mistake is that VMContext is a bit larger than it would otherwise
need to be. Extra slots are uninitialized memory but nothing in Wasmtime
ever actually accesses the memory either, so it should be harmless to
have extra space here. Nevertheless it seems better to shrink the size
as much as possible to avoid wasting space where we can.

Indeed yeah I was searching around for users of it to ensure they would all work correctly if it was accidentally too large and when I found no users of it I figured I could delete it. I think you're right that when I added escaped funcs I forgot to delete this field


Bottom bar should be automatically expanded when tab is selected

The bottom bar should be automatically expanded when you click on one of the tabs. This I believe is the typical behavior for most UIs, and saved a step of having to expand out the bottom bar again.

Thanks for the suggestions. I agree, I think expanding it on tab change would reasonable.

should be fixed now


fix 502 openai error

Have had this happen for multiple 3.5 trials where openai just craps out for a couple requests. Thought this may help.
80     self._interpret_response_line(
81   File "/home/dakisho/.pyenv/versions/3.11.6/lib/python3.11/site-packages/openai/api_requestor.py", line 775, in _interpret_response_line
82     raise self.handle_error_response(
83 openai.error.APIError: Bad gateway. {"error":{"code":502,"message":"Bad gateway.","param":null,"type":"cf_bad_gateway"}} 502 {'error': {'code': 502, 'message': 'Bad gateway.', 'param': None, 'type': 'cf_bad_gateway'}} {'Date': 'Wed, 01 Nov 2023 09:23:59 GMT', 'Content-Type': 'application/json', 'Content-Length': '84', 'Connection': 'keep-alive', 'X-Frame-Options': 'SAMEORIGIN', 'Referrer-Policy': 'same-origin', 'Cache-Control': 'private, max-age=0, no-store, no-cache, must-revalidate, post-check=0, pre-check=0', 'Expires': 'Thu, 01 Jan 1970 00:00:01 GMT', 'Server': 'cloudflare', 'CF-RAY': '81f306648c6ab0ed-ATL', 'alt-svc': 'h3=":443"; ma=86400'}

@okhat minor PR @ , review and merge would be quite helpful for openAI prototyping as train/eval w/ 60+ examples fail consistently due to this API error


Upcoming Release - 7.23.0

Time Tracking: MA-38
7.23 Release Notes
This is done when:

[ ] Regression Test Plan 7.23.0 (PROD) PASS on iOS
[ ] Regression Test Plan 7.23.0 (PROD) PASS on Android

[ ] 7.23.0 (PROD) submitted for App Store review
[ ] 7.23.0 (PROD) submitted for Play Store review

[ ] 7.23.0 (PROD) approved for App Store release
[ ] 7.23.0 (PROD) approved for Play Store release

[ ] 7.23.0 (PROD) phased rollout underway for iOS and Android

Significant errors encountered while testing on Android. Please see my testing report for more information.


'CL/cl.h': No such file or directory clUtil

Please, helpme
i try to compile clkeyfinder on visual studio 2017 (win 8)
i have amd app sdk installed
but always return 'CL/cl.h': No such file or directory clUtil

Does not work with Ati rx480
do not waste your time


[ll] Resource destruction

Part of the lower level core abstraction rewrite #1102
Motivation
We want to minimize API overhead for our core library. At the moment we track resources via reference counted handles in core. In contrast, corell API directly works with the raw R::* structs. Some backends (e.g Vulkan) have explicit vkDestroy* functions, which require an handle to the device.
d3d11/12 solves this by internal reference counting.
1st Approach (Explicit destruction)
In order to destruct resources the API will expose destroy_* functions, which need to be explicitly called.
Pros: Doesn't require to store the device handle in each resource.
Cons: Requires the user to explicitly take track of the it's resources and avoid duplicated destruction.
2nd Approach (Lifetime wrapper)
We use wrapper structs ResourceObject<'a, R> for the resources R::* to have an associated lifetime. Resources now can't outlive the creating factory.
Pros: We only need to store the 'bare' device handle in the resources for destruction.
Cons: Requires all Factory methods to use &self instead of &mut self, else we won't be able to reborrow the factory for creating new resources.
3rd Approach (RAII)
The most intuitive way for user would be RAII, resources will be destructed once the handle drops.
Pros: Safe and easy to use
Cons: Requires to keep track of the underlying device handle via reference counting to avoid the resource outliving the device.
cc @kvark

I'm strongly in favour of 1st approach - explicit destruction. One of the core benefits of the new core API that I'm looking to get is zero overhead for the most demanding applications.
Not sure how the 2nd will solve the problem, perhaps you need to explain it more.

Sounds reasonable.
Regarding the 2nd approach I tried to create a small code snippet to show the underlying idea:
https://is.gd/c6zdFR
Motivation for this approach was to avoid the reference counting costs and try to couple resource lifetime to the factory/device lifetime.

I do not like the first one, because it is Rust we use and Rust takes care of memory stuff for us. It just feels like a step back to C/C++ (though gfx is abstracting over something which was initially defined with those languages in mind). In my opinion, the third approach would be the correct one to guarantee lifetimes and memory safety on the user side.

@minecrawler The third approach will still be used for the higher level gfx package. The whole point of this lower level gfx_core API is to be able to bypass the overhead of the higher level one, so the third approach would be a step back and a mistake in my opinion.
I find the second approach interesting but it seems hard to do correctly so that it does not induce any overhead elsewhere and remains flexible enough.
Here is an attempt to make it work with &mut self Factory methods: https://is.gd/JvmPau

+1 for lifetime wrapper. It might be hard to get right but I think once done correctly it can surely outperform the alternatives.
@msiglreith

Cons: Requires all Factory methods to use &self instead of &mut self, else we won't be able to reborrow the factory for creating new resources.

If we take the wrapper approach, why should any methods of Factory be marked as &mut self anyway?

@DaseinPhaos wouldn't it prevent moving the resource handles to different threads? That would be a show stopper.

If we take the wrapper approach, why should any methods of Factory be marked as &mut self anyway?

Some backends need to change some inner fields atm (e.g current d3d11 backend), so I assumed it might be nicer to use mutable borrow here.
The lifetime approach requires scoped threads afaik.

A small suggestion: why not add a Drop implementation for the resource handles that merely logs an error, and then prevent the destructor from running if you call the appropriate destory_* function (via mem::forget)? This way if you leak resources it at least won't be silent.

@JohnColanduoni Sounds reasonable, good idea! I added it on my TODO list for the ll branch. But I won't tackle it until the factory changes.

@JohnColanduoni that's what I call "poor man's linear typing" ;)

We settled with explicit destructors for vulkan portability sake.
The mentioned error logging on Drop can be considered for the validation layer #1426


Extensions are not installing

Issue Type: Bug
I keep getting this error:
Cannot read property 'local' of undefined
Even though I am trying to install an extension in a user-level installation of  VS Code, I am pretty sure I have access to the /.vscode/extensions directory.
Thanks
S
VS Code version: Code 1.35.1 (c7d83e57cd18f18026a8162d042843bda1bcf21f, 2019-06-12T14:30:02.622Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz (12 x 2592)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.51GB (25.03GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions: none

Cannot read property 'local' of undefined error is fixed in latest insiders


nuisance edit rename with shape uncertainties

Had a report that this set of renamings, all shape uncertainties, will fail:
nuisance edit rename * * CMS_ttHl_btag_HF CMS_btag_hf
nuisance edit rename * * CMS_ttHl_btag_HFStats1 CMS_btag_hfstat1
nuisance edit rename * * CMS_ttHl_btag_HFStats2 CMS_btag_hfstat2
nuisance edit rename * * CMS_ttHl_btag_LF CMS_btag_lf
nuisance edit rename * * CMS_ttHl_btag_LFStats1 CMS_btag_lfstat1
nuisance edit rename * * CMS_ttHl_btag_LFStats2 CMS_btag_lfstat2
nuisance edit rename * * CMS_ttHl_btag_cErr1 CMS_btag_cerr1
nuisance edit rename * * CMS_ttHl_btag_cErr2 CMS_btag_cerr2

The problem is this line:
https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/blob/81x-root606/python/NuisanceModifier.py#L100
When doing the edit for CMS_ttHl_btag_HF, it will match and replace both CMS_ttHl_btag_HF and the substring in CMS_ttHl_btag_HFStats1. We can't use regex in the datacard, e.g. ^CMS_ttHl_btag_HF$ because the old name will be saved for the TH1 lookup. A quick fix is to put: lsystnew = re.sub('^'+oldname+'$',newname,lsyst), but guess there's a better way @nucleosynthesis  ?

I'm not sure we need to use the regex for renaming - is there a use case where someone is doing that? If not then we can just do a strict replace of the name.

Sorry just coming back to this - I don't know of anyone using regex in nuisance edit rename specifically. We did use it in the last couple of combinations for nuisance edit add though. I think this sub-string matching behaviour could affect all the nuisance edit functions, so perhaps we can replace it with a safe matching function that allows regex but requires the full string to match, not just a sub-string. Can make a PR for this.

Yeah, if you can make a PR with the safer regex I think that would be
helful - I'm not sure if nuisance edits report themseleves but this is
perhaps something we should add (especially if wildcards are used)
On Mon, Aug 20, 2018 at 9:56 AM Andrew Gilbert<EMAIL_ADDRESS>wrote:

Sorry just coming back to this - I don't know of anyone using regex in nuisance
edit rename specifically. We did use it in the last couple of
combinations for nuisance edit add though. I think this sub-string
matching behaviour could affect all the nuisance edit functions, so perhaps
we can replace it with a safe matching function that allows regex but
requires the full string to match, not just a sub-string. Can make a PR for
this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/issues/467#issuecomment-414246190,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABhK24CoG9yB5qwXBqM01IorsJZKjshCks5uSnnTgaJpZM4TYTA_
.


Auto Input Generation

Scan CFN Parameters and build a scaffold for taskcat inputs
Tag Parameters without Defaults value as NEED_VALUES

@virtlima do you want to take a stab at this.  I will provide some code that handles json template?

Tagging for v0.9 feature request.

tag: WONTFIX


TFP claim not documented

I'm not seeing the TFP claim documented in this doc here; looks like for v2 tokens, it's replacing ACR:
https://stackoverflow.com/questions/46688455/in-azure-ad-b2c-should-the-acr-or-tfp-claim-have-the-policy-name
Can the documentation be updated to include more details on ACR/TFP for v2 tokens?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2471c08b-befe-8e1a-df08-f13e116c231e
Version Independent ID: 0d827d33-2906-6352-9398-13863def9354
Content: Microsoft identity platform access tokens - Microsoft identity platform
Content Source: articles/active-directory/develop/access-tokens.md
Service: active-directory
Sub-service: develop
GitHub Login: @hpsin
Microsoft Alias: hirsin

That's for B2C tokens, not Azure AD access tokens.  We have slightly different claims between the two systems.

That's for B2C tokens, not Azure AD access tokens.  We have slightly different claims between the two systems.

@wizdes
Based off of the authors response above I just wanted to check in and see if you had any other questions or doc enhancement requests? If not, I'll go ahead and close out this issue at the end of the day, pending a response from your end.
If you have any other questions, please let me know.
Thank you for your time and patience throughout this issue.

@wizdes
Based off of the authors response above I just wanted to check in and see if you had any other questions or doc enhancement requests? If not, I'll go ahead and close out this issue at the end of the day, pending a response from your end.
If you have any other questions, please let me know.
Thank you for your time and patience throughout this issue.

Thanks - this answered my question on this.

Thanks - this answered my question on this.


GHSA-hj57-j5cw-2mwp: add omitted CVE ID

It's in the upstream advisory, but seems to have been omitted from the GitHub one.

Oh, huh, it seems there's a stub advisory GHSA-mjqc-5c9x-xfcc mapped to that CVE number instead.  Should that advisory be removed in favor of this one?


Week4 challenge

Notebook that does code conversion, comments, and unit test cases.

Absolutely tremendous. Congratulations and thanks once again @cloudllama


Typescript support

What about it?)

Hey Bjorn - gestalt is using flow internally, but its types are pretty heavily dependent on flow types exported by graphql-js.  Because graphql-js doesn't support typescript directly, I'm not likely to add them to the existing packages.
I'm not deeply familiar w/ typescript, but maybe the best way to achieve this would be a separate package similar to https://github.com/nitintutlani/typed-graphql ?


HyREPL broken features

Hopefully we can get some more interest in this project now :)
Having looked at the code, it seems to me that there are a few issues currently:

Global / local namespaces are broken. The current use of the eval function leaks things to the wrong scope and sometimes fails to import functions from Hy core.
Sessions are broken. It seems that currently the running repl executes everything in the same environment, even if you specify a different session.
Interrupt operation just doesn't work.
There also seems to be something wrong with setup.py. I couldn't install the package using pip, but maybe I'm just installing hy modules incorrectly.

My ideas for how to go about fixing things:

It seems to me that if you want to emulate a repl in Python, then you have to use code. Maybe we can repurpose the hy cmdline repl for this.
This seems fairly straightforward to fix by having a separate namespace for each session.
I don't know what to do about this because python just doesn't have a guaranteed way of killing a thread. It seems like the standard solution is to have your thread check for an interrupt signal while doing work, but given that the repl might be executing arbitrary code from the client, this isn't possible.
I'm not sure how to do this, but this just seems like a technical issue.


[Enhancement] Supports estimating FE memory by module

Why I'm doing:
When we encounter a FE memory problem, we don't know where the memory is occupying the most, which makes it more difficult for us to troubleshoot the problem and the troubleshooting cycle is relatively long.
And for some problems, we may not be able to get the factory where the problem is caused. Users may restart directly when solving the problem, resulting in us not discovering the root cause of the problem.
What I'm doing:
Add a memory estimation and statistics module so that we can refer to it when analyzing memory problems. First, we narrow the problem to a certain range, and then we count it every 60 seconds, so that we leave a historical information. When the user restarts, We can also see which module takes up more memory based on the log history.
Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

https://github.com/Mergifyio backport branch-3.2


Allow multiple controllers and invokers in local environments.

This allows deploying multiple controllers and invokers locally to be able to test their scaleout ability.
Todo:

Add a variable allow_multiple_instances to be able to keep the double-invoker check for production environments.

Depends on:

#2452 for getting rid of the registrator.
#2507 to be able to deploy multiple invokers in one machine.

nice!

I found another dependency for this PR:
on generating the whisk.properties, two lists are generated. One with all controllers and one with all invokers.
On using these aliases, the list only contains the list of the aliases, but the IPs or hostnames are needed for the tests.
I found the following line in the internet: controller.hosts={{ groups["controllers"] | map('extract', hostvars, 'ansible_host') | list | join(",") }}
But on using this one, it does not work when using no aliases.
We should have a deeper look here.

PG2#1973 is 🔵


Checkbox

Please add checkboxes to select the desired courses after parsing. That would be very convenient.

That would be absurd considering there will be at least 100 courses

Is it absurd to exclude unnecessary or similar courses?It's up to you.I just suggested it.

I mean how do you accept yourself to go through 100+ badly arranged titles.

I mean how do you accept yourself to go through 100+ badly arranged titles.

Separate checkbox " select/cancel all"

how would that help why would you cancel all

And also there is title exclusion that gives a good amount of control over the courses