404 on CORS-preflight fetch.

When using fetch, the CORS-preflight fetch for mget seems to be returning a 404, presumably because of the OPTIONS method. Is fetch not supported?

It should be but I guess nginx is not correctly configured. I'm busy now but I will take on this tonight. Could you paste here the CURL command so that it's easier for me? Thanks.

curl "https://api.npms.io/v2/package/mget" -X OPTIONS -H "pragma: no-cache" -H "access-control-request-method: POST" -H "origin: http://localhost:3000" -H "accept-encoding: gzip, deflate, sdch, br" -H "accept-language: en-US,en;q=0.8" -H "user-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.99 Safari/537.36" -H "accept: */*" -H "cache-control: no-cache" -H "authority: api.npms.io" -H "referer: http://localhost:3000/" -H "access-control-request-headers: content-type" --compressed

I'm afraid I can't work on this today, will have to be tomorrow.

@wtgtybhertgeghgtwtg should be working! Please confirm. :)

The response gives the following message.
Fetch API cannot load https://api.npms.io/v2/package/mget. Request header field content-type is not allowed by Access-Control-Allow-Headers in preflight response.

Attempting it without defining content-type resultings in a 400.

Oh, give me a sec.

Can you test it now? Does it work?

Here is a JSFiddle: https://jsfiddle.net/52Ltk9hf/

Oddly enough, it seems to work in Edge, but not Chrome.  I do not think this is a problem with npms-io.  Sorry about that.

@wtgtybhertgeghgtwtg Thanks for the fiddle, it's now working. Just leave a comment if there's something else to be fixed.

Thank you very much.


Returns APIError error instead of std err object

Allows the following:
err := notion.Search(...)

notionErr, ok := err.(*APIError)
if ok && notionErr.Code == "rate_limited" {
	// retry
}

Please don't forget to create a new release after you merge ;)

The *APIError.Unwrap method and usage of %w in Client should already allow for getting the underlying Notion API error in your own code. For example, see this variation of your code snippet:
import "errors"

err := notion.Search(...)

if errors.Is(err, notion.ErrRateLimited) {
	// retry
}

Ref: The errors.Is method and  this article for details on sentinel errors, unwrapping, etcetera.
IMO the current implementation of APIError and usage in the Client methods sufficiently allows for handling of errors (either HTTP related or otherwise), using the . Curious to hear your thoughts if you find otherwise.

Closing this after inactivity, pending follow up to my reply.


Implement is_dirty check for GrapherStep

#94
With https://github.com/owid/etl/pull/208, we began writing the latest input checksum to grapher db. Now, we use that checksum to verify if the grapher db data is up-to-date, by implementing GrapherStep#is_dirty.

Looks good! (Assuming it was tested in some way)

Yes, tested etl maddison --grapher to verify that the data only updates when the checksum changes


Move Selected Lines indentation is buggy...

Select the "if statement" and move it up and down, you will see a buggy indent behavior.

Graphical example:
Before move selected lines

After move selected lines

Reproduces without extensions: Yes

+1

Same issue as https://github.com/Microsoft/vscode/issues/54829#issuecomment-422501144, where I left some initial investigations. Let's track this bug there.


Please  upgrade path_provider to ^2.0.1

Please  upgrade path_provider to ^2.0.1
mp_chart 0.3.1 depends on path_provider ^1.1.0
and no versions of mp_chart match >0.3.1 <0.4.0,
mp_chart ^0.3.1 requires path_provider ^1.1.0.`

mp_chart ^0.3.1 and path_provider ^2.0.1, version solving failed

Related fork.

see #163


Custom task problemMatcher results not appearing in problems panel when problem is on the first line

This may be an insufficient documentation bug. I've followed the documentation here:
https://code.visualstudio.com/docs/editor/tasks#_defining-a-problem-matcher
But I am unable to get problems to appear. I've created a minimal example to reproduce this.
See here: https://github.com/xxgreg/vscode-problem-matcher-example
You can either check this out, or follow the reproduction instructions below.
Does this issue occur when all extensions are disabled?: Yes

VS Code Version:

code --version
1.62.0
b3318bc0524af3d74034b8bb8a64df0ccf35549a
x64

OS Version:
MacOS 11.6

Steps to Reproduce:
Create a new workspace, and open it.
Add .vscode/tasks.json
{
    "version": "2.0.0",
    "tasks": [
        {
            "label": "make an error",
            "command": "echo",
            "args": ["blah.js:4:3: warning: your foo is bad"],
            "problemMatcher": {
              "fileLocation": ["relative", "${workspaceFolder}"],
              "pattern": {
                "regexp": "^(.*):(\\d+):(\\d+):\\s+(warning|error):\\s+(.*)$",
                "file": 1,
                "line": 2,
                "column": 3,
                "severity": 4,
                "message": 5
              }
            }
          }
    ]
}

Add a file blah.js

// Output an error for this line:
var bad = "foo";

Run the task "make an error".
Observe that no problem appears in the problems view, or inline in blah.js.

So it looks like the newline handling doesn't work correctly for errors on the first line of the output.
If I replace echo with the following go program it works correctly.
package main

import (
	"fmt"
	"os"
)

func main() {
	fmt.Fprintln(os.Stderr, "\n\nblah.js:5:3: warning: implicit declaration of function ‘prinft’\n\n")
}

@alexr00 we removed it per your request in https://github.com/microsoft/vscode/issues/132551

I should have read what the fix in #132551 was more carefully! Thank you.


Container image verification failed

What is not working as expected?
When verifying the signed container image with notation I am getting the error
What did you expect to happen?
I just test notation for a new build image and it work error and the reason describe is mismatch Content-Length, but I check nginx for harbor, it has not error and the request code is 200, so what means about mismatch Content-Length
How can we reproduce it?
First notation cert generate-test --default "registry-ops.cokutau.com"
notation sign --signature-format cose registry-ops.cokutau.com/dev-pjcxa/botstudio:20240906_152011       --- it works goods
notation ls registry-ops.cokutau.com/dev-pjcxa/botstudio:20240906_152011
registry-ops.cokutau.com/dev-pjcxa/botstudio@sha256:a76d65b5dc0012652c3bf216da300edc6719902b25732de6a465f536e96be030
└── application/vnd.cncf.notary.signature
└── sha256:c5902769d1f3414e4a388c25aa9f981564cf18f6d53962d268091d9e5183a49a
notation verify registry-ops.cokutau.com/dev-pjcxa/botstudio:20240906_152011 -v       -- it work errors
INFO Allowed to access the referrers API, fallback if not supported
INFO Reference 20240906_152011 resolved to manifest descriptor: {MediaType:application/vnd.docker.distribution.manifest.v2+json Digest:sha256:a76d65b5dc0012652c3bf216da300edc6719902b25732de6a465f536e96be030 Size:1786 URLs:[] Annotations:map[] Data:[] Platform: ArtifactType:}
Warning: Always verify the artifact using digest(@sha256:...) rather than a tag(:20240906_152011) because resolved digest may not point to the same signed artifact, as tags are mutable.
INFO Checking whether signature verification should be skipped or not
INFO Trust policy configuration: &{Name:registry-ops.cokutau.com RegistryScopes:[] SignatureVerification:{VerificationLevel:strict Override:map[] VerifyTimestamp:} TrustStores:[ca:registry-ops.cokutau.com] TrustedIdentities:[]}
INFO Check over. Trust policy is not configured to skip signature verification
INFO Processing signature with manifest mediaType: application/vnd.oci.image.manifest.v1+json and digest: sha256:c5902769d1f3414e4a388c25aa9f981564cf18f6d53962d268091d9e5183a49a
Error: signature verification failed: unable to retrieve digital signature with digest "sha256:c5902769d1f3414e4a388c25aa9f981564cf18f6d53962d268091d9e5183a49a" associated with "registry-ops.cokutau.com/dev-pjcxa/botstudio@sha256:a76d65b5dc0012652c3bf216da300edc6719902b25732de6a465f536e96be030" from the Repository, error : GET "https://registry-ops.cokutau.com/v2/dev-pjcxa/botstudio/manifests/sha256:c5902769d1f3414e4a388c25aa9f981564cf18f6d53962d268091d9e5183a49a": mismatch Content-Length
Describe your environment
root@1b81bd31a2ce:/tmp# uname -a
Linux 1b81bd31a2ce 5.14.0-427.13.1.el9_4.x86_64 #1 SMP PREEMPT_DYNAMIC Tue Apr 30 18:22:29 EDT 2024 x86_64 GNU/Linux
I use wget notation_$NOTATION_VERSION_linux_amd64.tar.gz and tar > /usr/local/bin/notation to use
What is the version of your Notation CLI or Notation Library?
Version:     1.2.0
Go version:  go1.23.0
Git commit:  4700ad6f1bef13e411772d7ae4399f891fc3a6ae

Hi @JanetZhouJ ,
To troubleshoot, can you please share the manifest metadata of your signed image? Maybe you can use ORAS tool to get the manifest metadata:
oras manifest fetch registry-ops.cokutau.com/dev-pjcxa/botstudio:20240906_152011

@JanetZhouJ do you have any updates on this issue?


⚠ Jenkins Plugins Artifactory has degraded performance

In c23fbec, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1337 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 5d29bec after 48 minutes.


Fix UCP test

Description
looks like https://github.com/radius-project/radius/pull/7640 broke one of the ucp tests. this PR fixes the test

Type of change

This pull request fixes a bug in Radius and has an approved issue (issue link required).
This pull request adds or changes features of Radius and has an approved issue (issue link required).
This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

talked with @willdavsmith offline. It's going to be involved to test this due to the complexity of mocking the generated clients. Since we've got tests failing right now we should merge.


[Sema] NFC: Remove dead code

ReferenceStorageTypes are handled elsewhere.
@swift-ci Please smoke test

@swift-ci Please smoke test

I couldn't come up with a convincing case that would hit this, so let's see if others can
@swift-ci please test source compatibility

I definitely hope that code isn't doing anything; I can't think of any situation where the type-checker should just be checking for WeakStorageType and not all ReferenceStorageTypes.

Wonderful.
Thanks for the cleanup!


Mitosin boot deps, and reagent snapshots are not found in clojars

I think these dependencies needs to be updated.
[metosin/boot-deps-size "0.1.0-SNAPSHOT" :scope "test"]
[reagent "0.6.1-SNAPSHOT" :scope "test"]

into
[metosin/boot-deps-size "0.1.0" :scope "test"]
[reagent "0.6.1" :scope "test"]

Fixed.


Disable the scalastyle hashCode with equals check.

cotiviti-scalastyle.xml

Disable the check that hashCode is implemented with equals. This is
because it is completely broken. The following example illustrates the
problem.
object ScalaStyleFail {

  final case class Passes() {
    override final def equals(other: Any): Boolean = false
    override final def hashCode: Int = 1
  }

  final case class FailsButShouldPass() {
    override final def equals(other: Any): Boolean = false
    override final val hashCode: Int = 1
  }

  def main(args: Array[String]): Unit = println("derp")
}

I had been entertaining the idea of sending scalastyle a patch upstream for
this, but it looks like that repo is dead.

Apologies - I missed this PR somewhere (it was not enabled for Rat Thing).  I'll review right now.


Support xarray coordinates

Constructor should allow support for non-dimensional coordinates in a manner compatible with xarray.
This required coordinates to be added to .zmetadata and DATA/.zattrs

Constructor support for coordinates is supported. The C++ API support for coordinate usage is not well defined yet.


Avoid exposing play-services-gcm library as transitive

Hi,
In my project i use few google play services libraries. Because countly sdk-messaging app includes 'com.google.android.gms:play-services-gcm' I'm getting errors that 'play-services-base' library is used with different versions.
Solution would be to update gradle plugin to version '3.0.1' and use 'implementation' keyword instead of 'compile'. In this way, gcm library won't be exposed to project.

We've updated Gradle & Android Studio in latest 18.04 release, so it's resolved.


feat: code for whisper-large-v3

I think these are the necessary changes

make feature_size/num_mels configurable, infer from model name
make num_languages configurable, infer from model name
add yue cantonese token

I didn't convert this model but looks like it's correct: https://huggingface.co/gradjitta/ct2-whisper-large-v3
Testing this locally, I am able to load model from hub and infer. I haven't tested multilingual stuff carefully, that might need more eyes.

fyi @gradjitta -- using your translated model here

Is this enough without CTranslate2 update?

Is this enough without https://github.com/OpenNMT/CTranslate2/pull/1530?

to be honest I'm not sure what that PR does? my read is that it updates some docstrings and adds the n_mels() function, but none of the logic changes inside encode. in the faster-whisper code, the feature extraction is done in Python (and already has an n_mels arg) and just passes the extracted array to CTranslate2, which works.
What would be helpful to add in CTranslate2 is the corresponding num_languages function.

I don't think that propagating num_languages is necessary as it only matters for one language. We can assume that people forcing the inference to yue know that they should not use large-v2 or large-v1.
large-v3 will be set to the new default large model
yue needs to be added to _LANGUAGE_CODES
n_mels can be infered from the model params, which is why I am updating ctranslate2 to propagate this param.

I don't think that propagating num_languages is necessary as it only matters for one language. We can assume that people forcing the inference to yue know that they should not use large-v2 or large-v1.

v3 supports code-switching https://twitter.com/jeremyphoward/status/1721696652506100175 so multi-language support does matter

When trying to use .transcribe(language='de') an error is returned, as the model is "not multilingual".

When trying to use .transcribe(language='de') an error is returned, as the model is "not multilingual".

reproduced, also with another conversion: https://github.com/guillaumekln/faster-whisper/pull/549/files#diff-dff5046df32208d1eaf3b13702e9c9a4c5b44ac2451aa59a6f31aebf8b4d66e3R24
seems like the conversion is tricky to get the is_multilingual support (this logic hasn't changed in the PR)

You didn't add the new language to _LANGUAGE_CODES so your change has no effect.

https://github.com/guillaumekln/faster-whisper/blob/9c378b681c5c73795e01f7d6aaec368ece6499cf/faster_whisper/tokenizer.py#L278

In ctranslate2 is_ultilingual is inferred from the size of the vocabulary, the condition is not met anymore

Can you give me precisely where in your PR the num_languages is necessary ?

you're right - after thinking about it more, I think it has no effect on the current release. however -- if the next version adds another language, then we will be in the same boat. I think it's useful to keep this logic here, I took it from the upstream Python repo and feel like it's more future proof. the is_multilingual logic could be similarly handled, using the same logic as upstream

In the openai repo they have the language logic because they wrapped the tiktoken tokenizer.
Faster-whisper is using the huggingface tokenizer and does not really handle the language encoding, everything is done in the hugginface tokenizer.
I think there won't be any change in the hugginface tokenizer, it won't require any parameter change either, we just need the new vocabulary file in the download folder and the tokenizer should be v3 compatible.
In the future, if openai releases a new model with different languages, just having the new vocab file and the weights in the ctranslate2 format will be enough.
I agree that is_multilingual is not very robust, especially if a model is release with less languages or with a different amount of tokens. I think that the logic should remain in ctranslate2 but could be improved if another issue comes up in the future.
I will submit a PR when the HF model will be released and after having run some tests.

when the HF model will be released

It's now released: https://huggingface.co/openai/whisper-large-v3

i have a working conversion uploaded to bababababooey/faster-whisper-large-v3
yeah the is_multilingual check never hits so you'll get something like The current model is English-only but the language parameter is set to 'yue'; using 'en' instead. if you try to use another lang. i just kind of lazily commented out all the multilingual checks in transcribe.py to test and it didnt break anything

okay i noticed quality with the english only model/tokenizer was significantly worse (missing punctuation, not segmenting sentences, etc) than when forcing the multilingual tokenizer, so i'm using multilingual for everything. seems like im getting the same quality as the openai whisper package now
i think the only thing missing now is getting is_multilingual properly set in the ct2 model? it breaks language detection (currently defaults to 'en'). if you try to force it, it throws a runtimeerror
  File "C:\git\faster-whisper-3\faster_whisper\transcribe.py", line 335, in transcribe
    results = self.model.detect_language(encoder_output)[0]
RuntimeError: detect_language can only be called on multilingual models

@stillmatic @funboarder13920

@stillmatic Opened basically the same PR yesterday lol
I think that it is best to determine is_multilingual and num_languages, as well as mel parameters, systematically from the configs provided by HF, if those are available (first two are derived from vocab_size in config.json, the latter are given in preprocessor_config.json). The latter part of this is done in my PR, feel free to merge that in here and I will close my one, since yours was the first.

The HF model was released but the tokenizer is not in the required format and I am not able to convert it to the fast tokenizer format tokenizer.json
The pytorch_model.bin is not available either but I was able to convert the model.safetensors to the bin format.
I will wait for the official files. If people are in a rush to use large-v3 they can use any of the proposed PR

As I cited on CTranslate2/pull/1530

The current check for multilingual support seems to be hardcoded with a specific vocabulary size:
_is_multilingual = vocabulary.size() == 51865;
Link to code
For instance, I believe the whisper-latest-v3 model has a vocabulary size of 51866, which is one more than the hardcoded value. This discrepancy could lead to the multilingual feature being incorrectly disabled for this model.
Probably a more dynamic check need to be implemented to ensure compatibility with future models.

I could make the model work doing the changes suggested by @flyingleafe and removing the last line for the vocabulary.json "<|30.02|>" but, of course it will affect the model and it's not a solution.

cool - let's wait for @funboarder13920 PR to be merged, the multilingual fix might be the only thing necessary there?
the other question is how to handle the num_languages and related tokenizer things. I would like to get that from CTranslate2, as that would be consistent with other operations that rely on vocab size (ie the is_multilingual check).
question on the preprocessor_config.json -- can we get it from the config.json on the hub that already exists? we're already downloading it here: https://github.com/guillaumekln/faster-whisper/blob/master/faster_whisper/utils.py#L78C10-L78C16 - has num_mel_bins. let me try and update to use this file, so that we do not need to download an additional new one.
fyi - pytorch weights are also available on hub: https://huggingface.co/openai/whisper-large-v3/blob/main/pytorch_model.bin

I will make a num_languages available in the ctranslate2 model. I don't see when we will need the num_languages though.

I think we should be able to succeed now just on this ... testing on CTranslate2 head commit now

thanks @funboarder13920! after installing the wheel from https://github.com/OpenNMT/CTranslate2/actions/runs/6801730648, is_multilingual is properly set & language detection works as expected
i fixed an off-by-1 bug in config.json in bababababooey/faster-whisper-large-v3, the <|en|> token was missing from "lang_ids" and "suppress_ids_begin" was off by 1 as well
i got tokenizer.json from my method above. i spotted the bug by comparing with the tokenizer.json from HF's conversion script, but it seems to be missing the <|yue|> token, causing similar off-by-1 issues down the line (ex, all transcribe tasks become translate tasks)

cool, I've updated to use @bungerr 's HF repo. installing CTranslate2 from scratch is a bit annoying, would be good to get a release cut there. does the PR work now with the updated repo?

haha yeah i was never able to build ct2 from scratch. i think this is the closest thing to a release until a new version gets published to pypi, just have to find the right wheel for your platform+python version & pip install. maybe we should do this in requirements.txt if the release never comes
and yes, i just pulled the new version and is working fine as far as i can tell

I've opened https://github.com/OpenNMT/CTranslate2/issues/1532 to ask for a new release

@Purfview Can you help promote this PR to be merged? In addition, I think that due to @guillaumekln limited time, we need new / co maintainer.

I have tried the models, but I'm having some strange issues where punctuation is definitely no acting the same, will keep testing...

On my end, I tried the v3 model and noticed that its significantly slower and worse translations than v2. VAD also seems to be cutting the words at weird parts. I will test more and see how it goes.

I think the changes should wait until the CTranslate2 release is cut, otherwise it will be a confusing experience -- the multilingual tokenizer issue means that results will silently degrade.

(will rerun CI when the ct2 wheels get uploaded)

hi @nguyendc-systran -- think this is ready for review!

any one can merge this ?
or only wait Guillaume Klein to do this?

Did you benchmark openai vs this PR implementation ?
It seems that there are some errors in the HF hub whisper-large-v3, another PR for faster-whisper mentions that the tokenizer must be different https://github.com/guillaumekln/faster-whisper/pull/559 , if they are right.

I am still waiting for the large-v3 HF hub to be aligned with all the other models, specifically the tokenizer.json config before trying anything

@funboarder13920 There is a very simple way to obtain the tokenizer.json file from the HF model.
from transformers import WhisperTokenizer, WhisperTokenizerFast

slow = WhisperTokenizer.from_pretrained("openai/whisper-large-v3")
fast = WhisperTokenizerFast(__slow_tokenizer=slow)
fast.save_pretrained("/path/to/dir")

This yields all the necessary files for the tokenizer including tokenizer.json

@funboarder13920 alternatively you can use conversion script from my PR to transformers heh (https://github.com/huggingface/transformers/pull/27336)
I pinged Sanchit there though regarding tokenizer.json in the official checkpoint to save everybody some hassle, so I think the issue should be resolved soon.

@flyingleafe what about config.json issue mentioned there -> https://github.com/guillaumekln/faster-whisper/pull/548#issuecomment-1802817971

@Purfview I figured the issue out, so basically the difference between large-v2 and large-v3 tokenizer checkpoints is that <|endoftext|> token is included in the additional special tokens list for previous checkpoints versions, but excluded from it for large-v3.
This token is BOS token so by the logic of tokenizers library it should not be in this list in the first place, so the fact it was there before is some kind of bug apparently. But CTranslate2 converter relied on this token being present in the list.
I opened the PR in CTranslate2 fixing this: https://github.com/OpenNMT/CTranslate2/pull/1546
The other issue which was present in the converter is that they did not get the suppressed token values from HF model's generation_config. Those are important for proper transcription (all the faster-whisper checkpoints by @guillaumekln so far included those, and they were equivalent to HF ones). I fixed that too.
https://huggingface.co/flyingleafe/faster-whisper-large-v3 <- this checkpoint is made using those fixes, together with this PR seems to be working well. @ThomasKluiters please feel free to test your punctuation issues on this checkpoint, I suspect those could be due to nonexistent suppress_tokens set in your previous attempts.

@flyingleafe I'm not an expert, but your fixes make sense. Are you sure that there are no other quirks with tokens?
Going to test it, I'll report later.

@flyingleafe Thanks! I'm gonna have a look later today!

@flyingleafe I didn't noticed any difference so far.
Btw, there is new commit: https://huggingface.co/openai/whisper-large-v3/commit/99ef777c8f3c81bade67c14cfa359a3d6303b788

@Purfview can you send me some of your test samples maybe? maybe my samples are too easy, so far the results I see are virtually identical to large-v2.
the half of the new commit to the HF checkpoint makes sense (bos/eos/pad token ids are wrong indeed), but the reduction of the vocabulary size actually does not make sense, will test HF version today with and without this change to figure out why they did that.

send me some of your test samples

Check this.

I run some benchmarks to compare large-v2 with large-v3. large-v2 is currently way better than large-v3.
Some possible explanations:

large-v3 is not accurate
there is an issue with the conversion (openai to hf or hf to ct2)
there is an issue with the code from HF we are using
there is an issue with this code
the default inference params are different from large-v2 ?

Next week I will benchmark openai/large-v3 against hf/large-v3 against ct2/large-v3 and openai/large-v2 against openai/large-v3 to narrow down the possibilities.

@funboarder13920 can confirm, on the example provided by the @Purfview large-v3 hallucinates a lot of BS in the end and in-between phrases, while large-v2 does not; no problems with punctuation though

after this long discussion
any update on the final result
as I want to be if it's ok to update to v3, at least with no negative impact copmare to v2

I ran some benchmarks to compare large-v2 with large-v3. large-v2 is currently way better than large-v3. Some possible explanations:

large-v3 is not accurate
there is an issue with the conversion (openai to hf or hf to ct2)
there is an issue with the code from HF we are using
there is an issue with this code
the default inference params are different from large-v2 ?

Next week I will benchmark openai/large-v3 against hf/large-v3 against ct2/large-v3 and openai/large-v2 against openai/large-v3 to narrow down the possibilities.

what language do you use to test ? test on mulitiple language or just English?

From my own testing, the same problem occurs with whisper v3 translation (JP to EN) task. For most parts, whisper v3 has better grammar, but it tends to hallucinate and fill in words by itself, which can cause the context to change at times. This occurs even with the Hugging face's implementation, so I am not sure if the problem lies with the conversion from open-ai's model to hf or the model itself. Whisper v2 is slightly better in terms of "word for word" so context don't change as much but hallucination is still a problem.
I also noticed that "avg_logprob" in whisper v3 tends to be lower when testing the same audio on whisper v2.

@flyingleafe
Did you use this model in your test?
https://huggingface.co/flyingleafe/faster-whisper-large-v3

@nguyendc-systran in https://huggingface.co/Systran/faster-whisper-large-v3/tree/main vocabulary is a .json but for the other models e.g. https://huggingface.co/Systran/faster-whisper-large-v2/tree/main its a .txt file. Is this intended?

@nguyendc-systran in https://huggingface.co/Systran/faster-whisper-large-v3/tree/main vocabulary is a .json but for the other models e.g. https://huggingface.co/Systran/faster-whisper-large-v2/tree/main its a .txt file. Is this intended?

Hello, Ct2 support vocabulary in both format json and txt. Recently, after this PR all the conversion will generate vocabulary.json instead of txt. That's why in https://huggingface.co/Systran/faster-whisper-large-v3/tree/main, we have vocabulary.json

Added some changes and reflections from this thread in a new PR #578

Hi @stillmatic, @Oscaarjs et al.
Thank you very much for the contribution and all discussion in this thread.
I take the liberty of closing this discussion as the remaining works has been done and merged by https://github.com/SYSTRAN/faster-whisper/pull/578
Thanks both of you ;)

Still, nospeech vs nocaptions difference in token 50363 wasn't answered.


Support contiguous-memory 2D arrays

I would like to use Yeppp on whole 2D arrays, which implies that their memory is contiguous throughout.  The Yeppp C functions will support this since they use pointer and length arguments.  Being new to Julia, I am not clear on how to type-restrict the 2D methods to throw an error if the 2D argument is non-contiguous, such as a 2D subarray.
One of the reasons Yeppp is important to me is that it has SIMD performance optimized for Intel Haswell CPUs, which use AVX2 instructions.  Pure Julia code relies on LLVM v3.3 for released Julia builds, which doesn't support Haswell/AVX2 instructions.  I hope Julia moves to LLVM v3.6 soon.  I see that a PR is active on this: https://github.com/JuliaLang/julia/issues/10786

The simplest solution is to implement the methods for Matrix for 2d, or Array for Nd, which are contiguous. The more general AbstractMatrix and AbstractArray may or may not be so.
Coming to think of it, for many of the functions, Vector can be safely replaced with Array in yeppp.jl.


Add block elements for freeform mode

It would be nice to draw in freeform mode with block elements like ▉ (U+2588), ▆ (U+2586 ) or ▒ (U+2592).

I propose a generic an hence very powerful solution for this:
At the bottom of the character selection menu, insert a text field with the label "Use this custom character" which can take a single character, any single-width unicode character that is supported.
I made a mockup:


apt upgrade stuck at "Setting up libc6:amd64 (2.37-14) ..."

Windows Version
10.0.22631.3085
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>-1
Distro Version
Debian testing
Other Software
No response
Repro Steps
In Debian Testing
sudo apt update
sudo apt dist-upgrade

While upgrading libc6:amd64 (2.37-14), it stuck forever.
Expected Behavior
Should be able to upgrade
Actual Behavior

And I can see telinit u takes 100% CPU
A lot of people also having this problem:
https://stackoverflow.com/questions/77885938/stuck-setting-up-libc6i386
https://unix.stackexchange.com/questions/767340/apt-stuck-on-setting-up-libc6
Diagnostic Logs
No response

I had the same issue, https://github.com/microsoft/WSL/discussions/11035#discussioncomment-8149890 fixed it.
As far as I can tell if you don't have
[boot] systemd=true
The /run/systemd/system directory is not created and the tests in the postinst for libc fail:
    # Restart init.  Currently handles chroots, systemd and upstart, and     # assumes anything else is going to not fail at behaving like     # sysvinit:     TELINIT=yes     if ischroot 2>/dev/null; then         # Don't bother trying to re-exec init from a chroot:         TELINIT=no     elif [ -n "${DPKG_ROOT:-}" ]; then         # Do not re-exec init if we are operating on a chroot from outside:         TELINIT=no     elif [ -d /run/systemd/system ]; then         # Restart systemd on upgrade, but carefully.         # The restart is wanted because of LP: #1942276 and Bug: #993821         # The care is needed because of https://bugs.debian.org/753725         # (if systemd --help fails the system might still be quite broken but         # that seems better than the kernel panic that results if systemd         # cannot reexec itself).         TELINIT=no         if systemd --help >/dev/null 2>/dev/null; then             systemctl daemon-reexec         else             echo "Error: Could not restart systemd, systemd binary not working" >&2         fi     fi     if [ "$TELINIT" = "yes" ]; then         telinit u 2>/dev/null || true ; sleep 1     fi


Do not hide skills

It has recently stopped hiding selected skills. I don't know if it's because of the new versions of the module or D&D5. I attach a screenshot of the error that is shown multiple times in the console when opening the configuration window.

that's due to dnd5e changing the data in v2.2 can you try this version: https://github.com/misthero/dnd5e-custom-skills/tree/dnd5e-v2.2-compatibility

I've tried that one and It works again! Thanks.
Is there plans to upgrade this fix?

live now :)


feat(ideal-image): allow translating status messages

Motivation
#4542
Have you read the Contributing Guidelines on pull requests?
Yes

someday we'll probably have to rewrite it from scratch

Oh well, that's not something I had a plan for... Maybe we do need to change the Webpack setup so other image loaders work with this, but the component can probably stay


multi: introduce status server and sub-server manager

This PR does a few things:

Adds a new subServerMgr that handles the connections to Loop, Pool & Faraday. This will also make it easy for us to add another sub server in future. This is also nice because it makes it easier in the next steps to treat these sub-servers ,& any errors we may get from them, differently to how we would treat errors from LND or LiTd.
Adds a new Status server that is "always-on". This will allow the UI to query info about the status of any of LiTs sub-servers (including LND, Loop, Pool, Faraday and LiT itself).
Does a big refactor so that Litd does not ever shutdown unless requested to via a shutdown signal. This ensures that the Status server can always be reached.

$ litcli status

{
        "sub_servers": {
                "faraday": {
                        "running": true,
                        "error": ""
                },
                "lit": {
                        "running": true,
                        "error": ""
                },
                "lnd": {
                        "running": true,
                        "error": ""
                },
                "loop": {
                        "running": true,
                        "error": ""
                },
                "pool": {
                        "running": false,
                        "error": "could not start pool: <something something>"
                }
        }
}

TODO:

[ ] documentation explaining the difference (and reasoning) between the lnd 10009 (gRPC only) and the litd 8443
[ ] More itests to cover the startup process

Fixes #421
Fixes #420
Fixes #290

@guggero - as discussed offline, I have requested your review here but am mainly looking for approach comments to begin with. And also, no rush on this as I will be afk for the next 2 weeks

@guggero: review reminder

@guggero: review reminder

@ellemouton, remember to re-request review from reviewers when ready

@ellemouton, remember to re-request review from reviewers when ready

@ellemouton, remember to re-request review from reviewers when ready

@ellemouton, remember to re-request review from reviewers when ready

@ellemouton, remember to re-request review from reviewers when ready

@ellemouton, remember to re-request review from reviewers when ready

@ellemouton, remember to re-request review from reviewers when ready

@ellemouton, remember to re-request review from reviewers when ready

@ellemouton, remember to re-request review from reviewers when ready

!lightninglabs-deploy mute

muting for the time being. Will pick up again one I have more room on my plate

I need to switch away from this for a bit now so just making a note of some issues that the current version still has:

THe itests seem to not exit
we currently construct the autopilot server and session server before getting to the registration of rpc servers. This means that if the setup of those fail, then we cant access the status server to see this. And the reason we ordered it this way is so that LND can register non-nil servers. so a bit of a catch 22 here...
I think to solve the above, we might need to add a new grpc server that just servers the status server. So that it is not dependent on the start up of LND.

replaced by https://github.com/lightninglabs/lightning-terminal/pull/516 & https://github.com/lightninglabs/lightning-terminal/pull/541


Issue #460: Fix access logging when gzip is enabled

The code that captured the content length and the status code
for the access logger depended on the http.Handler to be of a
certain type. Wrapping the handler in a gzip handler broke this
silently.
This fix removes that dependency and instead wraps the response
writer directly to capture the values required for access logging.
Fixes #460
Closes #469

Hey @magiconair, was this impacting Fabio not logging 502s? I've noticed that any release after 1.5.8 I'm getting 502s in the logs when I was not before.


Missing CONTRIBUTING.md File in Repository

The repository currently lacks a CONTRIBUTING.md file, which is an important resource for guiding potential contributors on how to engage with the project effectively. A CONTRIBUTING.md file outlines the contribution guidelines, coding standards, and procedures for submitting pull requests, thus streamlining the contribution process and ensuring consistency across contributions.
Could you please assign this issue to me under GSSOC 24.

We already have CONTRIBUTING.md File Please raise any other issue, i'll assign you
If you have any doubt you can directly send message on our discord (https://discord.gg/rZb46cCMmK), we have created seprate chennals for all projects...
Thank you :)


[Bug]: Full Screen Mode is not working

🔍 Have you checked that you are using an auto updating method or latest version of the extension?

[X] I have checked that I am on the latest version.

🔍 Is there already an issue for your problem?

[X] I have checked older issues, open and closed

Choose the extension for bug report.
Full Screen Mode
ℹ Environment / Computer Info
Spotify para Windows (64 bits)
<IP_ADDRESS>5.g02fef27a
Spicetify v2.30.0
Theme: marketplace
Extensions: playOnYouTube.js, imageOpener.js, group-session.js, quickQueue.js, fullScreenWrapper.js
Custom apps: marketplace, lyrics-plus

📝 Description
Full Screen Mode is showing a black screen. I have to shut down Spotify to be able to use it again.
I tried reinstalling but its not working.
📸 Screenshots
No response

Same here

Fixed in https://github.com/daksh2k/Spicetify-stuff/commit/4f4f76a74ef027280ffdc8bae3ca000ac305e440
It's a spicetify-cli issue, but added a workaround.


How to highlight based on multiple modifiers at once?

If I understand correctly a variable with both readOnly and fileScope will be end up with up to 3 highlight groups applied to it: Variable, ReadOnlyVariable and FileScopeVariable. That seems to assume that all modifiers are independent, but I don't think that always applies. I may want to highlight ReadOnlyFileScopeVariable specially, or at least differently from both ReadOnlyFunctionScopeVariable and (mutable) FileScopeVariable. That doesn't seem to be possible with your current table-based approach.
One option would be to have a user-supplied function like highlightGroups(fileType, tokenKind, modifierList) -> optional<highlightGroupList> and then fall back to the simple table-based approach if that returns nil. That allows fine tuning for "interesting" cases while still using a simple declarative style for normal cases. It also allows useful but non-trivial logic like looking for variables tagged with fileScope without readOnly and highlighting them MutableGlobalVariable (which is really the case I'd want to highlight).
If there is already some way in (neo)vim to color based on multiple highlight groups rather than just one, that would also work, but as far as I know, they are independent.

I've came to the conclusion that it is too complex to provide one implementation that fits all use cases as there are so many different combinations of modifiers+tokens. Your idea of this function sounds good, It could just replace this code region:
https://github.com/theHamsta/nvim-semantic-tokens/blob/master/lua/nvim-semantic-tokens.lua#L71-L81

I've went with a slightly different interface: https://github.com/theHamsta/nvim-semantic-tokens/issues/2


[Feature] NodeJS Agent Kafka  Support

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
Current NodeJS agent does not support KafkaJS(or any Kafka lib). This feature would give move visibility for the applications that heavily use Kafka.Is it possible to support this like RabbitMQ?
Use case
No response
Related issues
https://github.com/apache/skywalking/discussions/12563
Are you willing to submit a pull request to implement this on your own?

[ ] Yes I am willing to submit a pull request on my own!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Are you going to contribute this? Our issues are kept when we have owner.
Others are in discussion channel only.
SkyWalking agents rely on contributions.

Is it possible to support this like RabbitMQ?

From tech perspective, yes. But we don't have that from server side.
You could do that in your own fork. OAP is easy to expand.


Replay redis (dev)

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev@0f81e63). Click here to learn what that means.
The diff coverage is 0.00%.

@@          Coverage Diff           @@
##             dev     #507   +/-   ##
======================================
  Coverage       ?   36.75%
======================================
  Files          ?       38
  Lines          ?     5771
  Branches       ?        0
======================================
  Hits           ?     2121
  Misses         ?     3650
  Partials       ?        0

Impacted Files
Coverage Δ

assemblyline_core/replay/client.py
0.00% <0.00%> (ø)

assemblyline_core/scaler/scaler_server.py
29.14% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f81e63...4ae2635. Read the comment docs.


tailscaled: Add option to disable Taildrop

This PR adds an option to the tailscaled module to disable the Taildrop feature. The ability to disable taildrop was introduced in https://github.com/tailscale/tailscale/pull/6482.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

CC @mfrw @martinbaillie as the maintainers of the module.


Login/Register have a bit delay

Be using PMMP
Have a detailed title like "Players are being kicked randomly"

General
When player login or register after key in all details and enter it will delay
Server Software:
PMMP 3.0.0-ALPHA5
Version of PiggyAuth:
<IP_ADDRESS>
Data Provider:

JSON

Steps to Reproduce the Issue
1.Get in to server
2.Login / Register
Extra Information

This is due to async.


is Vector2 missing bounce function?

According to https://docs.godotengine.org/en/3.1/classes/class_vector2.html I'd expect to have bounce function available in Vector2 class. Currently there is no such function in Vector2

Hello @fhausman , a lot of the functionalities contained in the Godot Engine are not available in GDNative as GDNative tends to lag behind a bit on functionalities...
I saw that the bounce functionality is actually fully supported (in the Engine and in the headers), so I added this functionality in #362

This has been merged and can thus be closed @BastiaanOlij


Version Packages

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
<EMAIL_ADDRESS>Minor Changes

Support hosting NextJs apps on non-Vercel platforms by constructing req.url using host-related headers instead of using on req.url directly. CLERK_TRUST_HOST is now enabled by default. (#1492) by @dimkl

Patch Changes

Updated dependencies [6fa4768dc]:

<EMAIL_ADDRESS>

<EMAIL_ADDRESS>Minor Changes

Support hosting NextJs apps on non-Vercel platforms by constructing req.url using host-related headers instead of using on req.url directly. CLERK_TRUST_HOST is now enabled by default. (#1492) by @dimkl

Patch Changes

Updated dependencies [6fa4768dc, 4ff4b716f]:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

<EMAIL_ADDRESS>Minor Changes

Support hosting NextJs apps on non-Vercel platforms by constructing req.url using host-related headers instead of using on req.url directly. CLERK_TRUST_HOST is now enabled by default. (#1492) by @dimkl

Patch Changes

Updated dependencies [6fa4768dc, 4ff4b716f]:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

<EMAIL_ADDRESS>Minor Changes

Support hosting NextJs apps on non-Vercel platforms by constructing req.url using host-related headers instead of using on req.url directly. CLERK_TRUST_HOST is now enabled by default. (#1492) by @dimkl

Patch Changes

Updated dependencies [6fa4768dc, 4ff4b716f]:

<EMAIL_ADDRESS><EMAIL_ADDRESS>

<EMAIL_ADDRESS>Patch Changes

Updated dependencies [6fa4768dc, 671561697, 38644778e, 808e45dc4]:

<EMAIL_ADDRESS><EMAIL_ADDRESS>

<EMAIL_ADDRESS>Patch Changes

Introduce the skipInvitationScreen prop on <CreateOrganization /> component (#1501) by @panteliselef

Removes identifier from Personal Workspace in the OrganizationSwitcher list (UI) (#1502) by @panteliselef

Address spacing issues when password feedback message changes (#1482) by @raptisj

Add a full stop in form feedback(errors and warnings) when needed

In <OrganizationProfile /> component, allow an admin to leave the current organization if there are more admins present. (#1498) by @chanioxaris

Updated dependencies [6fa4768dc]:

<EMAIL_ADDRESS><EMAIL_ADDRESS>

<EMAIL_ADDRESS>Patch Changes

Updated dependencies [6fa4768dc, 671561697, 38644778e, 808e45dc4]:

<EMAIL_ADDRESS><EMAIL_ADDRESS>

<EMAIL_ADDRESS>Patch Changes

Updated dependencies [6fa4768dc, 4ff4b716f]:

<EMAIL_ADDRESS><EMAIL_ADDRESS>

<EMAIL_ADDRESS>Patch Changes

Updated dependencies [6fa4768dc, 4ff4b716f]:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

<EMAIL_ADDRESS>Patch Changes

Updated dependencies [6fa4768dc]:

<EMAIL_ADDRESS>

<EMAIL_ADDRESS>Patch Changes

Updated dependencies [6fa4768dc]:

<EMAIL_ADDRESS>

<EMAIL_ADDRESS>Patch Changes

Introduce the skipInvitationScreen prop on <CreateOrganization /> component (#1501) by @panteliselef

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


Convert to yarn for package management

Closes #3943
Moves Core to use the same package manager as EE. This is really only to enforce consistency; we chose yarn as it a bit faster (historically) and has a nicer UX.
Note: Some scripts that run during releases may still be npm to reduce the risk of finding issues during a release.

Yeah it looks like the yarn.lock is using the react v18 types which seem to introduce these issues https://github.com/bvaughn/react-error-boundary/issues/111#issuecomment-1101850212
If we can bump it back to 17.x in the yarn.lock somehow it will mirror the package-lock and we can maybe revert the code changes.

Did upgrading eslint cause all those typescript errors? If we can get rid of the new @ts-ignores we should

I tried removing most of these, but the Modal is being problematic for some reason. Unfortunately, we have some @types/ that require @types/react at 18.X, so we do have the two different type definitions.

Here is a summary of the @types/react dep tree:
$ yarn why @types/react
yarn why v1.22.19
[1/4] Why do we have the module<EMAIL_ADDRESS>[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found "<EMAIL_ADDRESS>info Has been hoisted to "@types/react"
info Reasons this module exists
   - Specified in "devDependencies"
   - Hoisted from "@types#react-dom#@types#react"
info Disk size without dependencies: "184KB"
info Disk size with unique dependencies: "1.39MB"
info Disk size with transitive dependencies: "1.39MB"
info Number of shared dependencies: 3
=> Found "@types/react-router-dom#<EMAIL_ADDRESS>info This module exists because "@types#react-router-dom" depends on it.
info Disk size without dependencies: "392KB"
info Disk size with unique dependencies: "1.59MB"
info Disk size with transitive dependencies: "1.59MB"
info Number of shared dependencies: 3
=> Found "@types/styled-components#<EMAIL_ADDRESS>info This module exists because "@types#styled-components" depends on it.
info Disk size without dependencies: "392KB"
info Disk size with unique dependencies: "1.59MB"
info Disk size with transitive dependencies: "1.59MB"
info Number of shared dependencies: 3
=> Found "@testing-library/react-hooks#<EMAIL_ADDRESS>info Reasons this module exists
   - "@testing-library#react-hooks" depends on it
   - Hoisted from "@testing-library#react-hooks#@types#react-dom#@types#react"
info Disk size without dependencies: "392KB"
info Disk size with unique dependencies: "1.59MB"
info Disk size with transitive dependencies: "1.59MB"
info Number of shared dependencies: 3
=> Found "@types/hoist-non-react-statics#<EMAIL_ADDRESS>info This module exists because "@types#styled-components#@types#hoist-non-react-statics" depends on it.
info Disk size without dependencies: "392KB"
info Disk size with unique dependencies: "1.59MB"
info Disk size with transitive dependencies: "1.59MB"
info Number of shared dependencies: 3
=> Found "@types/react-router#<EMAIL_ADDRESS>info This module exists because "@types#react-router-dom#@types#react-router" depends on it.
info Disk size without dependencies: "392KB"
info Disk size with unique dependencies: "1.59MB"
info Disk size with transitive dependencies: "1.59MB"
info Number of shared dependencies: 3
=> Found "@types/react-test-renderer#<EMAIL_ADDRESS>info This module exists because "@testing-library#react-hooks#@types#react-test-renderer" depends on it.
info Disk size without dependencies: "392KB"
info Disk size with unique dependencies: "1.59MB"
info Disk size with transitive dependencies: "1.59MB"
info Number of shared dependencies: 3
=> Found "@types/react-transition-group#<EMAIL_ADDRESS>info This module exists because "@material-ui#core#@types#react-transition-group" depends on it.
info Disk size without dependencies: "392KB"
info Disk size with unique dependencies: "1.59MB"
info Disk size with transitive dependencies: "1.59MB"
info Number of shared dependencies: 3
Done in 0.39s.

Yeah.. it looks like we've bumped up to 18 for react-test-renderer etc.. in the yarn.lock etc, which may cause issues later as we're still on react 17?
yarn import seems to keep react-test-renderer back on 17 etc and aligned with the version of react we're using. Could give that go?

yarn import seems to keep react-test-renderer back on 17 etc and aligned with the version of react we're using. Could give that go?

I had no idea about yarn import :+1: . Updated.


Miscellaneous cleanup

Coverage decreased (-0.001%) to 98.544% when pulling d9f0796b05674a8f3fc242cc58b38dbbd3e6e8f3 on jugglinmike:2019-04-cleanup into d965038168d6deff2e4f3e82f1054f9373df7a3b on jshint:master.


Feat/simple points example

This PR is the PR to support building out an example NestJS (Express) Application that uses the nestjs-rate-limiter library and provides another application to test and verify the results of the rate-limiter
This PR is in support of the following issue (#49)
Structure of the PR
This expands on the previous PR that introduced NX as a monorepo with a simple nestjs application.  This PR includes 3 additional components
Rate Limiter Express Test App
This is a simple node application that will call the APIs and expect certain responses (mainly number of successful responses) from the rate-limiter-express-app. This is structure to be executed within a CI pipeline and could be used to help ensure that nestjs-rate-limiter is working as expected
loadtest-common
Loadtest is a nodejs library that was built using promises.  The goal of this library was to extract dependencies on loadtest from the rest of the application and implement some basic typescript types for loadtest
rate-limiter-points-test
The goal of this was to build libraries that had functions that could enforce expected behaviour on the API.  This is still something that needs to be thought out in more detail.  My thought process was that as we looked at GraphQL or Fastify, that this test libraries could be used be used against the same APIs.  I suspect that this will need refactoring in the future.
Artillery vs loadtest
I initially looked at artillery (https://artillery.io/) as it seems to have more support and better functionality for testing.  I did some initial research with this but decided to go for loadtest (https://www.npmjs.com/package/loadtest ) for two reasons: The first was that artillery expect plugin (https://www.npmjs.com/package/artillery-plugin-expect) was a bit limited in what it could test.  It did not provide the ability to test partial results (i.e. expecting that 5% of calls will be successful and the rest will fail because the rate limiter kicked in).  The second reason was that the artillery.io did not seem to have an exposed API which would have allowed us to get more details of how the API calls behaved.
NOTE: Part of the reason for implementing the loadtest-common library was that in the future if someone was to replace the test suite with artillery (or another tool) it should be pretty easy.
Test Harness - Assert vs Jest
I initially started building out my test cases with jest but ran into conflicts with loadtest..  Load Test relies a lot on setTimeout to control when to fire off API calls and Jest apparently overloads the setTimeout function when it runs.  It does this to allow tests to run faster and there is some documentation on how to configure this, but I was unable to get it to work.  As a result I implemented a simple test app in rate-limiter-express-test-app  that could be easily converted over to jest specs
Note: If another contributor is able to get this to work it would be easy to convert all the tests over jest (https://jestjs.io/) with expect
NX/NestJS Boiler Plate code
This PR large and includes a lot of files; however, most of this is boiler plate being build by nx (https://nx.dev) and nestjs (https://nestjs.com/).  When you create a new library or application the following files are automatically generated
.eslintrc.json
.gitkeep
jest.config.js
README.md
tsconfig.json
tsconfig.lib.json
tsconfig.spec.json

assets/.gitkeep
environments/environment.prod.ts
environments/environment.ts

@ozkanonur If you have time would you mind looking at this PR.  It is a larger PR but most of the code is boiler plate code that was generated by nestjs/nx.  I provided some information on some of the design choices that I made and would welcome any feedback that you have.


Add missing builtins

I realized I missed doc, because it's defined elsewhere.  I also added std and workspace, but I left them Unset because I don't see any way to make that work correctly (so they really just serve as documentation).

I had a feeling something was missing but I didn't look closely enough :) Though I thought omitting std and workspace was intentional.


Add Pico RTIC Timer Blinky Example

Created RTIC example that blinks gpio25 at an interval of 1 second from a interrupt with the RTIC framework. Uses local and shared data from RTIC with pac access through the RTIC Mutex.
I couldn't get RTIC 0.5.x working as the Nr trait was needed where as 0.6.x uses InterruptNumber
Happy to fix any suggestions!
Resolves #108

We should really have used the rt version span to allow either rt 0.6 or 0.7 and let the user choose.
https://github.com/embassy-rs/rp2040-pac2/blob/9ad7223a48a065e612bc7dc7be5bf5bd0b41cfc4/Cargo.toml#L8
Not really important here - targetting rtic 0.6.0 seems like a much better option, since the only thing holding back on general release of that is better documentation.
rtic should only be a dev-dependency, we don't it to build for all users of the HAL.


Add skip to automatic version check

Skip the automatic version check when the environment variable ARCHWAY_NO_VERSION_CHECK is set to true (or 1).

I closed this pull request, we'll need to come up with another way of achieving this setting globally. All of the technical details for why environment variables cannot work are detailed in the closed PR
The TLDR; is Node doesn't inject OS level env vars and adding a .env (so it does get injected) causes problems for running the CLI

@drewstaylor you can run a simple test to confirm that this information is incorrect:
node -r process -e 'console.debug(process.env)'

This will print all OS environment variables available to the node process at the moment of the execution.


[#2162] Updated email content

Updated email content for authorized contributors

Signed-off-by: David Deal<EMAIL_ADDRESS>

Just a slight typo in there, and also some clarification on the refresh/relog depending on Gerrit or GitHub
"To get started, please navigate back to GitHub or Gerrit and start the authorization process.  Once you select the
authorization link, you will be directed to the EasyCLA Contributor Console. GitHub users will need to authorize the
tool to see your GitHub user name and email. Gerrit users will first need to log in with their LF Account. On the console landing page, select the corporate agreement option. To finish, search and select your company to acknowledge your association with your company.  This will complete the authorization process.  For GitHub users, your pull request will refresh and confirm that you are authorized. For Gerrit users, please log out of the UI and back in to complete the authorization."
And then, make sure we have the normal closing paragraph of:
"If you need help or have questions about EasyCLA, you can read the documentation or reach out to us for support."
With the links - https://docs.linuxfoundation.org/lfx/easycla https://jira.linuxfoundation.org/servicedesk/customer/portal/4/create/143


Fix MusicBrainz external ID match

We were using MusicBrainz ReleaseGroup ID as a strong identifier which caused different versions of the same album to be linked together. The strong identifier for a unique album(version) should be the MusicBrainzAlbumID and the ReleaseGroupId should only be used to lookup external (meta)data.
This PR makes this more explicit by literally naming the musicbrainz external ID's.
Note that when no MusicBrainz tags are present (e.g. streaming providers), the logic will still fallback to just name comparing to catch different versions

@Jc2k the test of jellyfin doesnt seem to like the fact that there are now multiple external id's returned.
Because external_ids is a set, the order will be random and the test will simply fail sometimes when the order is not what is expected in the snapshot file. Any ideas ?

For now I've just adjusted the tests to sort the external_ids after converting to dict.
Maybe at some point if we want to make this more future proof we could decide to implement a serialization strategy:
https://github.com/Fatal1ty/mashumaro?tab=readme-ov-file#serialization_strategy-config-option

I thought syrupy would handle sets out of the box. Will add a proper strategy soon.


Dataset

I saw that you collected 270K cartoon video clips in this paper, will you open this dataset in the future?

Same question. At least the 1K evaluation set should be provided for fair comparisons with future works.

Hi Thanks for your interest. We cannot release the dataset due to copyright issues (as we're not allowed for re-distribution).


Windows 10 1px black border at bottom

Issue Type: Bug
Steps to Reproduce:

Open Code
Expand Code window to full-screen.
Look at 1px border at bottom of window, when it is hovered cursor become s-resize, but window is not resizing by dragging it.

This bug occurs only in full-screen-expanded window...

Screenshot 1(window is expanded):

Screenshot 2(window is attached to right):

Does this issue occur when all extensions are disabled?: Yes
VS Code version: Code 1.28.2 (7f3ce96ff4729c91352ae6def877e59c561f4850, 2018-10-17T00:23:51.859Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
AMD Phenom(tm) II X4 955 Processor (4 x 3215)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: unavailable_softwarevideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
8.00GB (1.60GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions: none

Step 2 should be maximize the window, not switch to full-screen.

duplicate of https://github.com/Microsoft/vscode/issues/58427


Unset sources as well

In the bibliography tab the source entries from the previous selected element are still visible if the user deselects an element.
Please review @eScienceCenter/spacialists

This is another problem. If you select an element in the tree (an element with literature references), switch to the 'Quellennachweise' tab and then deselect the element, there are still the references from the previous selected element.


Minor fixes for store removal

Enabled server to delete removed store entry in sealed/stopped list (The list is stored in InstanceConfig).
Fixed issue that store didn't delete remaining segments in reserved pool.
Fixed the bug that DiskSpaceAllocator didn't update in-mem data structure when deleting whole store reserve directory.

Codecov Report

Merging #1285 into master will increase coverage by 0.06%.
The diff coverage is 82.75%.

@@             Coverage Diff              @@
##             master    #1285      +/-   ##
============================================
+ Coverage      72.2%   72.27%   +0.06%
- Complexity     6291     6294       +3
============================================
  Files           455      455
  Lines         36074    36091      +17
  Branches       4572     4573       +1
============================================
+ Hits          26049    26084      +35
+ Misses         8828     8811      -17
+ Partials       1197     1196       -1

Impacted Files
Coverage Δ
Complexity Δ

.../com.github.ambry/tools/admin/ServerAdminTool.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

.../com.github.ambry.clustermap/HelixParticipant.java
81.13% <100%> (ø)
21 <0> (ø)
:arrow_down:

...ava/com.github.ambry.store/DiskSpaceAllocator.java
91% <100%> (+0.53%)
77 <13> (ø)
:arrow_down:

...rc/main/java/com.github.ambry.store/BlobStore.java
90.06% <83.33%> (-0.4%)
97 <0> (-1)

...a/com.github.ambry.server/AmbryServerRequests.java
92.54% <90.9%> (-0.16%)
77 <0> (ø)

...src/main/java/com.github.ambry.commons/BlobId.java
93.52% <0%> (-0.36%)
71% <0%> (-1%)

...in/java/com.github.ambry.network/SocketServer.java
85.53% <0%> (+0.41%)
15% <0%> (ø)
:arrow_down:

...va/com.github.ambry.replication/ReplicaThread.java
89.22% <0%> (+0.75%)
93% <0%> (+1%)
:arrow_up:

...m.github.ambry.replication/ReplicationMetrics.java
96.13% <0%> (+1.2%)
44% <0%> (+1%)
:arrow_up:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d411447...e58e16e. Read the comment docs.


[Bug] [Workflow task does not execute] Workflow task does not execute

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
某个任务中的配置变量，变量值不是ds内置值，则在执行工作流时，此任务一直是提交成功状态
比如A任务 配置变量 param 值设置为$[testStr]，则在执行工作流时，执行到A任务就一直时提交成功状态
What you expected to happen
比如A任务 配置变量 param 值设置为$[testStr]，则在执行工作流时，执行到A任务就一直时提交成功状态
How to reproduce
比如A任务 配置变量 param 值设置为$[testStr]，则在执行工作流时，执行到A任务就一直时提交成功状态
Anything else
No response
Version
3.1.x
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Please use English to describe.


swth: disable metaprogramming related warnings

These methods are indeed reachable via the $CMD "$@" statement at the end of the file. If you do not like to use shellcheck, this PR is of course not required.

Well, I think these are the most boring of shellcheck's complaints.
In the end, the only valid left reason for swth is template creation, and even for that, it could be simpler.
Please dont be offended if I close this, I just don't think it a few shellcheck-exceptions here and there improve that weird script a lot. Sure, its not incorrect, but in the end, the whole script it borderline…

No problem, thanks for the comments :)


Use with external Tooltip with custom text

Hi,
is it possible to integrate with tooltip for example Material ui and add custom text to tooltip?

Hi. Can we change tooltip text?

+1 for this feature request.
While #19 was indeed a step in the right direction, the {{count}} replacement is too restrictive. In my case, the count is a time duration such as 3000s, and I would like to humanize it to "50 minutes", instead of simply printing it as "3000 seconds".
It would be more powerful to also accept a callback at the labels.tooltip property, like this-
labels.tooltip = (date, count) => ...; // any abitrary func that returns a string

Hey. I'm currently on vacation but I can look I to this after I come back end of February.

#26 will render custom props, so you could:
item = {
count: 123,
foo: "asdfasdfasdf",
bar: "fsdfsdf",
date: "date"}
tooltip = Custom tooltip with text {{foo}} and. {{bar}}

I think I found a good way to support all kinds of different tooltip components through a render property now. However, this is going to be a breaking change and will consequently be released with v2.

Hey. I've just released v2 which enables you to use all kinds of tooltip components. Check out these examples for @mui/material  and react-tooltip v5. Please let me know if this solves your requirements.


Training from scratch with random weights

💡 Your Question
Hi, I'm seeking tutorials or guidelines on how to train a YOLO NAS model using a custom dataset from scratch. Most notebooks I've encountered so far mainly focus on fine-tuning models using pretrained COCO weights. However, I understand that such models might not be suitable for commercial use due to licensing restrictions.
Is it possible to train the model from scratch by omitting the pretrained path, thus initializing it with random weights? If this approach is feasible, could you advise on the recommended size for a custom dataset to achieve effective training?
I would greatly appreciate any guidance on this matter. Thank you.
Versions
No response

All you need to do in that case is to set pretrained_weights=None when creating a model. This will initialize a model with random weights.

could you advise on the recommended size for a custom dataset to achieve effective training?
The larger the better. Thousands. Maybe tens of thousands. Maybe hundreds. It is impossible to give you any recommendations as it depends on the domain and how "hard" it is do detect objects you are aiming to detect.


How to get id selected values?

i want add a button and when button click, get checked values id, how can i do it? thanks.

Just do $("select").val() as usual. Maybe I should make the README clearer.


Implement std::error::Error for error type(s).

I'm trying to use crate snafu, but it's unable to work with types that don't implement it.

If you disable the "failure" feature std::error::Error is implemented for the Error struct.
https://github.com/gwihlidal/vk-mem-rs/blob/c9a463bcc31607a4a45394c7889fb1db8a2a6403/src/error.rs#L73-L81

Failure is now disabled by default.


Update dependencies

Noticed that the dependency badge has been yellow for a while

Updated all dependencies to latest version
Set Clojure dependency as "provided"
Reordered keys in tests (where order is deterministic but not well defined)

This last issue points to perhaps returning sets rather than ordered collections. Or at least making the tests order agnostic.

Great!


Minified distribution files no longer present

Why have you introduced this breaking change on a patch version from tags 6.0.63 to 6.0.64 by removing zoid.min.js. and others.
We depend on the minified zoid.min.js and we use this to import as a script tag.

Hi @joe90joe40 -- sorry about that. Looks like there was a problem during the last build/publish cycle. I've republished and included that file again. Apologies for the inconvenience.


CPU compatibilty?

Hi
thanks for your work. I have no access to a GPU, can i train this model with CPU?

Please look at this issue for info on this. We would strongly advise only using if a GPU is available.


App Consent Audit Workbook is missing

Description of the new workbook for "App Consent Audit" is missing.
There is no documentation available for this workbook.
Only the JSON and Workbook file exists on GitHub repo:
https://github.com/microsoft/Application-Insights-Workbooks/tree/master/Workbooks/Azure Active Directory/App Consent Audit
"What's new"-documentation references to this page without any further information.
https://docs.microsoft.com/en-us/azure/active-directory/fundamentals/whats-new#september-2019

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: eb2155a4-d8b2-a542-1aba-387183c3f2e3
Version Independent ID: 11565414-4093-d4cf-2665-1343b45a732a
Content: Azure Monitor workbooks for reports
Content Source: articles/active-directory/reports-monitoring/howto-use-azure-monitor-workbooks.md
Service: active-directory
Sub-service: report-monitor
GitHub Login: @MarkusVi
Microsoft Alias: markvi

I've created a backlog item to track this.
#please-close


bug: listener is not executed on android

Hi!
I have a problem on Android device . SpeechRecognition listener is not executed and I cannot fetch recorded text... Could you take a look at my component?
import { SpeechRecognition } from '@capacitor-community/speech-recognition';
import { Box } from '@chakra-ui/react';
import { FC, useEffect, useState } from 'react';
import '../SentenceSpeakExercise.css';

export interface SentenceSpeakExerciseNativeProps {
  recordingActive: boolean | null;
  onRecordingFinished: () => void;
  onRecordAvailable: (sentence: string) => void;
}

export const SentenceSpeakExerciseNative: FC<SentenceSpeakExerciseNativeProps> = ({ recordingActive, onRecordAvailable }) => {
  const [nativeSpeechRecognitionAvailable, setNativeSpeechRecognitionAvailable] = useState<boolean | null>(false);

  useEffect(() => {
    SpeechRecognition.available()
      .then((result) => setNativeSpeechRecognitionAvailable(result.available))
      .catch((err) => {
        console.log('SpeechRecognition.available() failed:', err);
      });
  }, []);

  const startRecording = async () => {
    try {
      console.log('start recording...'); // I can see this in logs
      await SpeechRecognition.requestPermissions();

      SpeechRecognition.addListener('partialResults', (data) => {
        // this is not executed....
        console.log('partialResults was fired', JSON.stringify(data));
        onRecordAvailable('FIXME');
      });

      await SpeechRecognition.start({
        language: 'en-US',
        maxResults: 1,
        prompt: '',
        partialResults: true,
        popup: false,
      });
    } catch (error) {
      console.error('Error starting recording:', error);
    }
  };

  const stopRecording = async () => {
    try {
      console.log('stop recording...');
      SpeechRecognition.removeAllListeners();
      await SpeechRecognition.stop();
    } catch (error) {
      console.error('Error stopping recording:', error);
    }
  };

  useEffect(() => {
    if (recordingActive) {
      startRecording();
    } else {
      stopRecording();
    }

    // Clean up listeners when component unmounts or recordingActive changes
    return () => {
      SpeechRecognition.removeAllListeners();
    };
  }, [recordingActive]);

  return (
    <Box>
      {nativeSpeechRecognitionAvailable && <Box>native speech ready</Box>}
      {nativeSpeechRecognitionAvailable === false && <Box>native not available</Box>}
    </Box>
  );
};

Could you help me and tell is it bug in plugin or my mistake?
Used versions:
   "@capacitor-community/speech-recognition": "^5.1.0",
    "@capacitor/android": "^5.0.0",
    "@capacitor/cli": "^5.0.0",
    "@capacitor/core": "^5.0.0",
    "@capacitor/status-bar": "^5.0.6"`

I found that with popup I receive speech but this listener and partial results doesnt work...

Yeah, it's documented that if using the popup the partialResults won't fire, it's a limitation on the popup.
https://github.com/capacitor-community/speech-recognition?tab=readme-ov-file#addlistenerpartialresults-

Yes, I know it...but my problem is not for popup. Check first comment


Create ROS2 Master Branch

Hi,
Right now, with only the eloquent / dashing branches, TEB is falling behind the Navigation2 interfaces quite a bit. As Nav2 is charging ahead (unlike navigation in ROS1), the migration between distributions to do all at once will be challenging and error prone. Moreover, a lot of people are running navigation2 master branch because of how many features and bug fixes they'd be missing on the older distribution branches, while they're still ABI compatible (Eloquent, mostly).
Especially since we're chatting about including TEB as a default controller. Can you create a ROS2 master branch so we can make incremental updates as required? What are your plans to keep ROS1 and ROS2 in sync (or at least make sure ROS2 gets the ROS1 updates)?
an example: https://github.com/rst-tu-dortmund/teb_local_planner/commit/594773bfc3a5e62842c0a5d9745193c8efa44d2e reverting this broke ABI with master so right now anyone running Navigation2 master cannot use TEB without a bit of work that is unclear.

Hi,
good point, I am not used to such frequent changes in the navigation API ;-).
I create ros2-master branch.
Currently, my plan is to merge ROS1 features into ros2-master and resolve conflicts manually.
But I am open to other best practices!

That's more or less best practice, but we usually use the git cherry pick, but it really depends on how picky you are about your git history (I'm not picky at all)

Awesome - thanks for the branch, the only other thing I'd want for the ros2-master is changing the penalty_epsilon from 0.1 -> 0.05 per https://github.com/rst-tu-dortmund/teb_local_planner/issues/28, assuming that makes sense in your mind as a default. Having a good "out of box experience" and all

I'll sync with ros1 tomorrow morning. And sure, we can update that parameter!

There's not enough emojis to describe how helpful that is.
 Its the face of things to come & stable enough to really dive into as of Eloquent. I wouldn't develop any new code in ROS1 anymore unless you can't help it.

done ;-)
Actually, not yet. We use turtlebot2 robots for teaching etc. and these are not even fully supported in melodic yet. But yeah, the progress of ros2 and especially navigation2 looks very good! ;-)


Added 'fonts' task to Gulp

Summary:

Task moves fonts from libs to dist
FontAwesome works now

Rationale:
FontAwesome is included in the bower.json, but you can't use it until you grab the fonts and bundle them up in the ./dist/fonts/ directory. Maybe that was an intentional decision? FontAwesome is a little bit heavy after all.

./libs/font-awesome/css/font-awesome.css expects fonts to be in ../fonts, which is ./dist/fonts/ for us. If we put them in ./dist/assets/fonts, then we'd have to alter the CSS. Since we're pulling the CSS from Bower, that's not ideal. Alternatively, I think we could use @fa-font-path with ./libs/font-awesome/less/font-awesome.less. I think it's fine to just use ./dist/fonts/, though.

Yes, you are 100% correct. My comment was rushed. It should be ./dist/fonts and ./dist/images. Solid work :).


The data model must be updated to support filtering by date ranges

Data Model
Filtering cannot rely on the existing fields for collections and datasets:

created_at
updated_at

As @maniarathi cautions:

created_at and updated_at are common, internal database fields.

There may also be a time gap between created_at for a private collection and its actual publication. This is visible on the portal where new collections are sorted in the middle of the list because there was a long period between creation and publishing of the private collection.
The recommendation is to update the data model to include:

published_on timestamp for collections and datasets
revised_on timestamp for collections and datasets

For existing collections and datasets, the timestamp for published_on must be populated from the current value of created_at when the fields are added. My preference is that this feature is implemented before Stanford begins to revise the data corpus.
The following timestamps are set when a curator publishes a private collection or a revision of a public collection:

Operation
collection published_on
collection revised_on
dataset published_on
dataset revised_on

Publish private collection
X
-
X
-

Update a dataset in revision
-
X
-
X

Add a dataset in revision
-
X
X
-

Delete a dataset in revision
-
X
-
-

Update collection information in a revision
-
-
-
-

TEAM COMMENTS:

Do we need a new ticket to pre-populate the published_on dates to reflect created_on.

@metakuni Hey team! Can you please add your planning poker estimates with ZenHub

QA Steps

Create a new collection and add a dataset.

At this point, neither timestamps should be populated for collection nor dataset, since it's not published.

Click "Publish".

Since it's the first time this collection has been published, collection.published_on and dataset.published_on should be populated.
revised_on not be populated for either.

Revisions:
3. Edit details of collection and publish.

Neither timestamps should be updated for collection.

Update a dataset in the collection and publish.

revised_on for collection and dataset should be updated.

Add a dataset in the collection and publish.

revised_on for collection should be updated, and new dataset's published_on should be populated.

Delete a dataset in the collection and publish.

revised_on for collection should be updated.

@brianraymor Emanuele brought up a great point between *_at vs. *_on. Will be renaming published_on -> published_at and revised_on -> revised_at, since these timestamps are datetime, not just dates.

I defer to Emanuele and you regarding internal naming conventions. Thanks for the heads up!

If it's already in the API responses, then I can just review in my notebook that I use for REST API testing - but see - https://app.zenhub.com/workspaces/single-cell-5e2a191dad828d52cc78b028/issues/chanzuckerberg/single-cell-data-portal/1340


History configs

Haven't done offmap powers due to not having configs on hand. I'm also giving province history a light touch right now since this should be implemented by splitting the grammar and matching by first line checks.

Like a bad documentary, we've colorized history.


Feature Request: Searching?

Similar to your Youtube Search plugin, It might be cool to search files using this plugin as an alternative keybinding. It should, naturally, only search in folders already accessible by the File Manager, which is to say files already specified by the user.

Is the find addon not good enough? You can combine it with Favourites to only search through a set list of files.

Sorry, I didn't realize that was there. Thanks.


fix(admin): basepath navigation

:tada: This PR is included in version 1.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Day19

Resolves #41

Pull Request Test Coverage Report for Build 104

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 101:
0.0%

Covered Lines:
24

Relevant Lines:
24

💛  - Coveralls


FontSize button does not appear as a dropdown on Firefox.

Jodit Version:  3.9.4
Browser: Firefox
OS:  Windows
Is React App: True
Expected behavior:
Font Size button should be a dropdown
Actual behavior:
The dropdown does not work

Show me you code please

I am sorry, I cannot share my code, but I did not do anything special, just having the JoditEditor react component and the config object where I say what buttons I want in the toolbar. It now happens on Chrome as well.
This is the error that I get in the console log:

Thank you for your time :)

I have fixed the issue, the config file was adding the "fontSize" button instead of "fontsize".


fix(button-simple): added tabindex for accessibility

Description
PR to add tabIndex prop to ButtonSimple for accessibility as the react-aria useButton doesn't forwards the received tabIndex prop and always returns undefined for it.
Links
useButton tabIndex issue.

There is a test failing, otherwise looks ok.


AutoConnect

Hi,
sorry, i didn't found another way to contact you.
Is there a way to introduce in code gmail account username and password and skip authorize on every new device?
In any case, my mail:
<EMAIL_ADDRESS>Thx,
Anton.

You can make a credential for Google services. Please read these pages: https://developers.google.com/api-client-library/python/guide/aaa_overview
Also you can acquire full permissions with the https://mail.google.com/ scope. But the credential will revoke every 6 months.
Hope it helps you. Thanks.

Thx,
i will toke a look at link.
Don't think it's easy.
Best regards.
On Mon, Dec 18, 2017 at 3:26 PM, Midworld Kim<EMAIL_ADDRESS>wrote:

Closed #36 https://github.com/midworld/unity-googledrive/issues/36.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/midworld/unity-googledrive/issues/36#event-1392086010,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVJEPUKOnGu_IkCTSt4EsLWu_bFQjrfbks5tBmgKgaJpZM4RFZXF
.


Add metdata resource to AD role + ENV Var adjustments

Description

New RBAC Permissions for AD Pods querying AD API and Updates in ENV_VARs
For PR author

[ ] Tests for change.
[ ] If changing pkg/apis/, run make gen-files
[ ] If changing versions, run make gen-versions

For PR reviewers
A note for code reviewers - all pull requests must have the following:

[ ] Milestone set according to targeted release.
[ ] Appropriate labels:

kind/bug if this is a bugfix.
kind/enhancement if this is a a new feature.
enterprise if this PR applies to Calico Enterprise only.

/merge-when-ready delete-branch

OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and delete the branch after I've merged it.

I'm sorry but I failed delete the branch after merging the pull request.


Various Typing Fixes & Client-Side Render Event (Multiple Client Compatible)

I fixed some typings for Mineflayer, specifically the bot.viewer object.
I also implemented a system that keeps track of the highest FPS of clients currently connected to the viewer. This is used to provide a "render" event that guarantees at least one firing per frame of the fastest client connected.
I chose to poll the FPS of each client every second. That can be tweaked if performance is an issue.
There is unnoticeable impact to performance, both computationally and memory-wise. (It only stores a mapping of socket ids to a number).
In the event that no clients are connected, the event will not fire and the interval that would be firing said event is cleared.

A demonstration of this technique is shown here.
https://github.com/PrismarineJS/prismarine-viewer/assets/43506958/413f781a-1faf-4f9e-95c8-47f24f98b440

That failure doesn't appear to be my fault; the error says the test did not find the server (404 error). I will attempt to re-run.


Bugfix: Input being swallowed when switching between multiplexed editors

Repro:

Set editor.split.mode to 'oni'.
Restart Oni
Edit user config
Try and make changes to the configuration file - specifically, type in characters that would engage autoclosing pairs functionality ((, <enter>, etc)

Expected: Should function as normally without being in oni split mode
Actual: Some of the input gets sent to the leftmost editor, making it impossible to do anything in the right editor.
This bug only occurs when editor.split.mode is set to 'oni' (so off by default), and is a class of issues - things that are using activeEditor will only handle the original editor.
This is fine and the code is working as designed, in the non-multiplexed world, since we only ever had one editor. The bug is that, in the 'multiplexed' world, we can now have multiple editors, and the feature hasn't been updated to handle it.
In this case, the anyEditor is a convenient proxy that always points to the currently focused editor - so the fix here is to make the AutoClosingPairs functionality multiplexed-aware by switching to anyEditor vs activeEditor in places that are deferring functionality. For example, for input bindings that might get executed later, we should use anyEditor, since the actual editor might be different depending on which editor has focus (and the bindings apply across all editors).

Updated the fix - the onBufferEnter method is actually correct, because it is called on buffer enter (so the activeEditor is always going to be the one currently focused). However, listening to the onBufferEnter event has to happen for the anyEditor, so that we pick up the buffer enter event for all editors. That event wasn't getting fired correctly (we need to fire it on focus too, between the multiplexeed editors, so that it behaves the same as non-oni splits today).

@bryphe I was testing this out this afternoon and aside from the issue with input going to the wrong editors, the resize commands don't work (C-w C-< and :vertical resize n), and when you have multiple oni splits open, C-w C-q will close all the splits and the oni window, which is not what I would expect.

@parkerault - sweet, thanks a lot for testing it out!
Ah yes, there are still some resize issues. We need to make our 'Oni-controlled' windows resizable. There's #1412 and #1414 that are tracking similiar things.
One unknown in my head is how we'll handle these sorts of cases:

Nothing to stop the user from having some crazy combination of 'oni splits' and 'vim splits'! 😄 Will be an interesting problem to rationalize how that sizing logic should work in that world..
The C-w C-q case is a good catch - I don't think we have an issue tracking the C-w C-q case - would be great to have an issue. I started this project here: https://github.com/onivim/oni/projects/13 to track the remaining work / blockers to enable this setting by default.

Since I haven't looked into how Oni integrates with nvim I'm not sure how much control you have, but is it possible to hijack all splits and make them oni splits when they are created by vim? Otherwise I guess you are always going to be limited to user-created splits. Is the use case for oni tabs primarily to avoid confusing vim newbies?

@bryphe I created an issue for the split closing bug here: https://github.com/onivim/oni/issues/1899

Sweet, thanks @parkerault ! I added it to the externalized UI project

Since I haven't looked into how Oni integrates with nvim I'm not sure how much control you have, but is it possible to hijack all splits and make them oni splits when they are created by vim?

I think this is tricky business - if we hijack splits, vim plugins that try to open splits won't be aware of the new split we create (since it's in a new neovim process).

Is the use case for oni tabs primarily to avoid confusing vim newbies?

There's a few reasons - one is it is more like the way atom / vscode / etc behave, so it is easier on newbies. But also, one thing you'll notice, is that things like our scrollbar, error adorners, etc are only visible on the active window - this is because certain metrics we need to position our UI are only available for the active window. So by 'multiplexing' we can actually provide a better experience - if our windows are 1-to-1 with the vim windows, we can have a more consistent experience across the splits.
We usually split our user personas into two cases - the 'new user' who maybe doesn't care as much about the esoteric vim functionality, and the 'pro vim user' - who knows vim in and out and doesn't want to change their workflow. For the latter case, we're okay with potentially having them turn off settings - in fact @badosu put together this great bare vim config for us.
So we might be able to strike a compromise, perhaps change C-w C-< to by default resize the oni split if editor.split.mode is 'oni' (and have the native vim behavior otherwise). We probably wouldn't be able to hook the :vertical resize n, but that's sort of the 'pro vim' use case, so it may be ok to just leave that as-is.
It'd also be nice to have draggable handles for the window splits, too, for the 'new user' case 😄 Users coming from VSCode/Atom would definitely expect it.
But nothing set in stone... still need to figure out how we can best balance that!

I'll bring this in now since it unblocks the input issue - still more work to do in #1412 and #1899 to get this stabilized, though! Thanks again for trying it out, @parkerault !


stop always SetChecked(false) on action button PostClick

it conflicts with checked= attribute

This might be tricky. This should basically re-run the checked program for the button, but it's not clear how to find it. There's a similar issue for tooltips but the "ttfn" is set directly. Maybe we need to do the same here?


Code size measurements in CI

We would like to track code-size to enable us to understand what factors affect code-size, whether the library is growing, etc.
Measurements:

library size in kB
(for PRs) difference for each variant c.f. most recent build of development

Variants:

platforms should be Arm v7-A and Arm v8-A
a few different build types, probably: all-options-enabled, one or two other more typical configurations
static, maybe dynamic?
Release builds only
Ubuntu only - skip OS X / Windows / FreeBSD

Reporting:
This should be done via the CI logs - we don't need to aggregate statistics at this time. The difference statistics for a PR should be posted back to the PR in GitHub (example of one way to present this below):

Variant
Change
Change %
Size with PR

Arm v7-A libmbedtls.a all-enabled
1.1 kB
5%
250.5 kB

Arm v8-A libmbedx509.so all-enabled
-1.5 kB
-4%
150.2 kB

I'm not sure the best way to capture the difference (as this requires knowing the size of the base commit), but I think @bensze01 had some suggestions on this.

It may also be useful to get data from different compilers.

This is a very broad task. I strongly recommend having a plan written down before starting coding. The people who know the CI best are probably Bence and me.
The CI logs already have library size measurements for baremetal configurations on several Arm platforms. In all.sh, see component_build_armcc (Arm Compiler 5 and 6) and component_build_arm_none_eabi_gcc, component_build_arm_none_eabi_gcc_arm5vte, component_build_arm_none_eabi_gcc_m0plus (GCC). All of these run on Jenkins, and Travis also runs build_arm_none_eabi_gcc_arm5vte and build_arm_none_eabi_gcc_m0plus. More similar jobs can be added to have information about different compilers, targets or configurations.
Obviously, if you want to have data from other compilers, they need to be added to the dockerfile.
Comparing with the PR base in a PR job is somewhat complicated. The CI runs on a given commit, not always in the context of a pull request, so there isn't always a base to compare with. The pr-merge job does run extra code which compares a PR's head with a PR's base: see  gen_abi_api_checking_job in the Jenkins scripts, which invokes scripts/abi_check.py from the Mbed TLS repository. However, this job runs in parallel with the build jobs, so it doesn't have access to their output. Some possible approaches:

Make the size comparison job re-run the builds on the PR head. Not an attractive solution. The CI is already slow and resource-intensive as it is.
Make the size measuring jobs additionally measure the size of the PR head if there is a PR head. This would require some pretty messy changes to all.sh or to the code that invokes it.
Make the size comparison job run in a subsequent step, in parallel with analyze_results, or as part of it. This means that the size data from head and the size data from base must be available. Doing the builds of base in the second step is not an attractive solution because it will take a long time, so they should be done in the first step. To pass the size data from the first step to the second step, use build artifacts. This is what we already do with outcome files. I propose to use a similar format for size data: a semicolon-separated CSV where the columns are {platform, configuration, file, text size, rodata size, data size}.

The workflow would thus be:

Size measurement jobs in all.sh write the size data to $MBEDTLS_TEST_SIZES_FILE.
The Groovy code runs all.sh components with MBEDTLS_TEST_SIZES_FILE set to xxx-sizes.csv, and uploads the resulting file as an artifact if present.
In run_pr_job, for a merge job, additionally run the size measurement jobs from all.sh for the base.
Extend gather_outcomes to also assemble base-sizes.csv and head-sizes.csv and run tests/scripts/analyze_sizes.py if present.

Reporting results to GitHub is a completely separate issue and I'm not sure I want it: it's a bit noisy to post a comment on every build. Our pull requests can run into hundreds of review comments and GitHub doesn't scale well. If we do start posting things on GitHub, there's a more important thing that we still haven't done, which is to post CI results.

All the parts that are likely to change often (for example, list of configurations, choice of commands to run, result collation…) should be in Python scripts (or modifications of existing shell or perl scripts) in the mbedtls repository. Avoid putting more than strictly necessary in the Groovy scripts: they can't be modified or reviewed by people who don't have access to the CI repository, they're hard to test, fewer people can maintain them adequately.

Re posting CI results: this will be covered by the OpenCI work Linaro are doing.

Note: the baremetal branch has a measurement script which may or may not be useful as an inspiration - it used a specific configuration and platform that was the only target for that branch, which for the present task we probably want to explore different options. Though as Gilles said, this is a very broad task, so perhaps starting with a single config and platform would be a good intermediate step.

For information, we're currently measuring code size in the baremetal configuration, but this isn't quite right because it includes debugging features. https://github.com/ARMmbed/mbedtls/pull/4907 creates a new preset configuration baremetal_size without debugging features.