[FLINK-34743][autoscaler] Memory tuning takes effect even if the parallelism isn't changed

What is the purpose of the change
Currently, the memory tuning related logic is only called when the parallelism is changed.
See ScalingExecutor#scaleResource to get more details.
It's better to let the memory tuning takes effect even if the parallelism isn't changed. For example, one flink job runs with desired parallelisms, but it wastes memory.
Brief change log
[FLINK-34743][autoscaler] Memory tuning takes effect even if the parallelism isn't changed

Do scaling when parallelism or memory configuration is changed.

Verifying this change
Manually test done.
The unit test is writing.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changes to the CustomResourceDescriptors: no
Core observer or reconciler logic that is regularly executed:  no

Documentation

Does this pull request introduce a new feature? no

Thanks @mxm  for the quick review and valuable suggestion!
I originally planned to add a memory scaling threshold in a subsequent PR (It's better to be done in 1.9.0). If you think it's needed in this PR, let me do it recently.
How about reuse the AutoScalerOptions#TARGET_UTILIZATION_BOUNDARY option, it's 0.3 by default, it means we will ignore this tuning when the total memory saving less than 30%.
I prefer reuse option because it can lower the user's threshold for use. WDYT?

This PR would introduce a breaking change to the autoscaling logic, effectively rendering autoscaling meaningless because we would constantly scale. Autoscaling wouldn't have a chance to realize its SLOs. Even with the thresholds, the autoscaling logic would be fundamentally changed because autoscaling loses control over the rescaling behavior.
For this feature to be mergable, it will either have to be disabled by default (opt-in via config), or be integrated with autoscaling, i.e. figure out a way to balance tuning / autoscaling decisions and feed back tuning decisions to the autoscaling algorithm to scale up whenever we redeploy for memory changes to avoid falling behind and preventing autoscaling to scale up after downtime due to memory reconfigurations.
We need to be extremely careful with these kind of changes. Soon hundreds of existing autoscaled jobs will be using autotuning. If we break the scaling behavior, there is a serious risks of impacting all of these pipelines. With more and more users, there is an additional responsibility to make sure autoscaling / autotuning does not cause major downtime for users.

Autoscaling wouldn't have a chance to realize its SLOs.

You are right. Autoscaler supports scaling parallelism and memory for now. As I understand, the downtime cannot be guaranteed even if users only use scaling parallelism. For example, flink jobs don't use the Adaptive Scheduler and the input rate is always changed, then flink jobs will be scaled frequently.
Fortunately, scaling parallelism consider the restart time than scaling memory, and then increase some parallelisms.

For this feature to be mergable, it will either have to be disabled by default (opt-in via config)

IIUC, job.autoscaler.memory.tuning.enabled is disabled by default. It means the memory tuning is turned off by default even if this PR is merged, right?

or be integrated with autoscaling, i.e. figure out a way to balance tuning / autoscaling decisions and feed back tuning decisions to the autoscaling algorithm to scale up whenever we redeploy for memory changes to avoid falling behind and preventing autoscaling to scale up after downtime due to memory reconfigurations.

The restartTime has been considered during computeScalingSummary, but we may ignore it due to the new parallelism is WithinUtilizationTarget. Do you mean we force adjust the parallelism to the new parallelism when scaling memory happens even if the new parallelism WithinUtilizationTarget?

We need to be extremely careful with these kind of changes. Soon hundreds of existing autoscaled jobs will be using autotuning. If we break the scaling behavior, there is a serious risks of impacting all of these pipelines. With more and more users, there is an additional responsibility to make sure autoscaling / autotuning does not cause major downtime for users.

Yes, I totally agree with you. We need to control this risk to avoid effect users.

Autoscaling wouldn't have a chance to realize its SLOs.

You are right. Autoscaler supports scaling parallelism and memory for now. As I understand, the downtime cannot be guaranteed even if users only use scaling parallelism. For example, flink jobs don't use the Adaptive Scheduler and the input rate is always changed, then flink jobs will be scaled frequently.

I agree that there are edge cases where the autoscaler cannot fulfill its service objectives. However, that doesn't mean we need to give up on them entirely. With restarts due to autotuning at any point in time, the autoscaling algorithm is inherently broken because downtime is never factored into the autoscaling decision.
You mentioned the adaptive scheduler. Frankly, the use of the adaptive scheduler with autoscaling isn't fully developed. I would discourage users from using it with autoscaling at its current state.

Fortunately, scaling parallelism consider the restart time than scaling memory, and then increase some parallelisms.

+1

For this feature to be mergable, it will either have to be disabled by default (opt-in via config)

IIUC, job.autoscaler.memory.tuning.enabled is disabled by default. It means the memory tuning is turned off by default even if this PR is merged, right?

Autoscaling is also disabled by default. I think we want to make sure autoscaling and autotuning work together collaboratively.

or be integrated with autoscaling, i.e. figure out a way to balance tuning / autoscaling decisions and feed back tuning decisions to the autoscaling algorithm to scale up whenever we redeploy for memory changes to avoid falling behind and preventing autoscaling to scale up after downtime due to memory reconfigurations.

The restartTime has been considered during computeScalingSummary, but we may ignore it due to the new parallelism is WithinUtilizationTarget. Do you mean we force adjust the parallelism to the new parallelism when scaling memory happens even if the new parallelism WithinUtilizationTarget?

True, the rescale time has been considered for the downscale / upscale processing capacity, but the current processing capacity doesn't factor in downtime. Unplanned restarts would reduce the processing capacity. If we know we are going to restart, the autoscaling algorithm should factor this in, e.g. by reducing the calculated processing capacity accordingly.

Thanks @mxm for the patient reply and clarification!

You mentioned the adaptive scheduler. Frankly, the use of the adaptive scheduler with autoscaling isn't fully developed. I would discourage users from using it with autoscaling at its current state.

+1, I agree with you.

the rescale time has been considered for the downscale / upscale processing capacity, but the current processing capacity doesn't factor in downtime.

Sorry, I didn't notice that. I thought the restart time has been considered for any cases before. Thanks you for pointing it out, I will check later.
Also, do you have any other specific concerns if we allow memory tuning takes effect even if the parallelism isn't changed? I could try to solve all of them in this PR.

Also, do you have any other specific concerns if we allow memory tuning takes effect even if the parallelism isn't changed? I could try to solve all of them in this PR.

For decoupling autotuning, I would prefer if users would have to opt-in via a config for now, until we are sure both autotuning and autoscaling work together cooperatively.

For decoupling autotuning, I would prefer if users would have to opt-in via a config for now, until we are sure both autotuning and autoscaling work together cooperatively.

Thanks @mxm for the patient reply, it makes sense to me. Let us do it later, I will close this PR first, and we can pick it up after we think it's the proper time to do.


Upgraded Hook API (2)

Description
This PR takes over the work done by @jkelleyrtp in https://github.com/yewstack/yew/pull/1645 as that PR has been inactive for quite a while. I have also applied the review suggestions and updated documentation.
I tried to keep @jkelleyrtp's original commits as much as I could. Almost all of the code updates in this PR are theirs.
Fixes #1644
Fixes #1757
Closes #1645  (supersedes it)
Checklist

[ ] I have run cargo make pr-flow
[x] I have reviewed my own code
[ ] I have added tests

What about use_state(0) and with_state(|| 0) which use_state uses just the value, but I wonder if we can do some optimization here so that use_state could be faster? Which is similar to rust or(0) and or_else(|| 0). Of course, the naming can be bikeshed.

@pickfire, what's wrong with passing a closure though? It is possible to have a different function but I don't think that offers any benefits.

What about use_state(0) and with_state(|| 0) which use_state uses just the value, but I wonder if we can do some optimization here so that use_state could be faster? Which is similar to rust or(0) and or_else(|| 0). Of course, the naming can be bikeshed.

You don't want to pass values directly because they will get stack allocated each time the function is run. The closure prevents the creation of the object when it won't be used - as it probably won't because this is a hook setup. Clippy will warn about this too and discourages the use .or(0) in favor of .or_else(|| 0)


Update analysis-services-create-server.md

Updated the date

Hi @jocaplan, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor. If you're full-time or an intern, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@jocaplan : Thanks for your contribution to the Azure documentation! The author, @minewiskan, has been notified to review your proposed change.

#sign-off


GNU tests should be executed as root

We have currently 73 skipped tests, they are probably because of that.

Just for the information, there are also tests that are skipped when running as root

Good point
we could parse the test to create a list of tests containing require_root_

The current test script "util/run-gnu-test.sh" already tests these root tests, but it's only enabled on GitHub Actions:
https://github.com/uutils/coreutils/blob/1054c5c365d05ecbdc0d0a73344e468827c47970/util/run-gnu-test.sh#L45-L47

This came up in https://github.com/uutils/coreutils/pull/3880#issuecomment-1229461270

Root tests are tested in GitHub CI. If you search "skip-seek-past-dev" in the CI log, it's at the end of the log, but this test is skipped because other reason: https://github.com/uutils/coreutils/runs/8177093173?check_suite_focus=true#step:10:37091


px4fmu-v2_default - Channel mapping has no effect for AUX channel pass throught

Channel mapping settled by qgroundcontrol has no effect for AUX channel pass through
AUX1 and AUX2 has fixed PWM
Other AUX channels are inactive

Looking into this.

Fixed?

I think this is fixed. It will also be cross-tested during my trigger overhauling, so I will handle it there if still present.


About how to specifying frame rate while recording videos

Hello, may I specify a recording frame rate when recording videos? I tried adding -- max-fps 60, but the recorded video didn't have the expected 60 frames per second.
If frame rate can be specified, please tell me how to operate it。
Thanks

The frame rate is intrinsically variable: a new frame is produced only when the screen content changes. For example, if you play a fullscreen video at 24fps on your device, you should not get more than 24 frames per second in scrcpy.

https://github.com/Genymobile/scrcpy/blob/master/doc/video.md#frame-rate

帧速率本质上是可变的：只有当屏幕内容发生变化时才会产生新帧。例如，如果您在设备上以 24fps 的速度播放全屏视频，则 scrcpy 中的帧速率不能超过每秒 24 帧。

https://github.com/Genymobile/scrcpy/blob/master/doc/video.md#frame-rate

yes,I read this document before and thought there may be another way to record at a specified frame rate.
anyway,thank you.

MediaCodec does not provide an option to give a constant frame rate. One possibility is to record to a file, then resample using ffmpeg.

MediaCodec does not provide an option to produce a constant frame rate. One possibility is to record to a file, then resample using ffmpeg.

That could be a way.  i am thinking if i could run a app on the screen, which keep display a small area video at high frame rate. then i use scrcpy to record the whole screen, may be i can get my idea frame rate video?


Ability to enable/disable background auto-updates from settings

Right now you're only asked to enable auto-updates when the app launches the very first time. We should add a setting to edit this behavior. This settings can be modified by setting this property on the updater class:
https://sparkle-project.org/documentation/api-reference/Classes/SPUUpdater.html#/c:objc(cs)SPUUpdater(py)automaticallyChecksForUpdates
https://sparkle-project.org/documentation/preferences-ui/

Implemented with #128.


Authentication with .dwrc is finicky

Can be fixed with a proper authentication library to handle tokens for D-Wave systems

Fixed by #19 by upgrading to dwave-system==0.2.1 which can use dwave-cloud-client's simpler config file format.


Weird Shape on Linux.

As it's no issue in your screenshots, i wanted to share this. This might be a different between right side sidebar?

I'll take a gander at this today!


0.6.0 dev temporary - do not merge

DO NOT MERGE

Codecov Report

Merging #381 (c4fdd0b) into main (29fe64c) will decrease coverage by 16.63%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

@@             Coverage Diff             @@
##             main     #381       +/-   ##
===========================================
- Coverage   80.22%   63.60%   -16.63%
===========================================
  Files          88        4       -84
  Lines        4471      261     -4210
===========================================
- Hits         3587      166     -3421
+ Misses        728       75      -653
+ Partials      156       20      -136

see 92 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae82a67...c4fdd0b. Read the comment docs.


HHH-11582 - Fix inconsistent envers behavior with modified flags

https://hibernate.atlassian.net/browse/HHH-11582
Fixes Envers inconsistent behavior when modified flags is enabled and an entity is persisted and merged within the same transaction boundary.

Applied upstream


website: don't show un-runnable examples as runnable

The example for exec.Command won't run in the playground sandbox because it depends on 'tr'.
http://golang.org/pkg/os/exec/#Command
There are other such examples. We should probably detect (somehow) that they won't run, and not display them as runnable examples on golang.org.

Did a quick run through of stdlib examples.
There were some I couldn't check because #23095 seems to effect quite a few examples.
Other than os/exec, the patterns I saw were:
A lot of tests aren't playable due to files not existing. For the go/* packages this would be fixed by #23603. For the rest that use files, they appear to fall into two categories:

Explicitly assuming the file doesn't exist and it just won't run since it's the playground
Implicitly assuming the example will be executed with the current working directory set to the package directory (a lot of os.Open("testdata/afile"))

https://golang.org/pkg/crypto/x509/#example_Certificate_Verify runs locally but fails on the playground with "certificate has expired or is not yet valid", presumably because of the fake time.
https://golang.org/pkg/log/syslog/#example_Dial doesn't run because syslog.Dial isn't defined on nacl
I'm 99.999% sure this example deadlocking is a bug but will leave it up to the experts: https://golang.org/pkg/net/#example_Listener Similarly for https://golang.org/pkg/net/http/#example_Get replying "Get http://www.google.com/robots.txt: dial tcp: Protocol not available"
Some of these examples have output and some don't. If they all did that could be used to build a static list of non-runnable examples. (But then it's not clear if they're not runnable due to programmer error or playground limitations).
Given the variety and subtlety among the examples that don't run, maybe an annotation like //godoc: noplay would be the way to go?
If the examples that cannot ever be run on the playground are tagged as such, there could probably be some sort of playground trybot that makes sure examples match their output when run on the playground.

@broady @bradfitz Is anyone working on this issue ? I can work otherwise.

Not that I know of.

Cool. I'll create CL.

Also, is it worth minimizing this issue by making more examples runnable?  For example: https://golang.org/cl/122237

64 examples out of 610 in go/src/... won't run in Playground.
Also another 6 examples are marked as non-playable.
Just a few of them can be fixed so they will run in Playground, but definitely not all of them.
How can we mark the examples that should not be played?

Posting the results of running all the examples against the playground. Most of them are net or os failures. I wonder how hard it would be to create fake network for the playground.
Some examples take too long, like time.Tick, but that should be okay when new version godoc will be deployed. It will show output even when the example has timed out.
Feel free to make any of those examples playground-friendly.
$GOROOT/src/archive/zip/example_test.go:50:22 ExampleReader
	stderr: 2009/11/10 23:00:00 open testdata/readme.zip: No such file or directory

$GOROOT/src/crypto/md5/example_test.go:29:24 ExampleNew_file
	stderr: 2009/11/10 23:00:00 open file.txt: No such file or directory

$GOROOT/src/crypto/sha1/example_test.go:29:24 ExampleNew_file
	stderr: 2009/11/10 23:00:00 open file.txt: No such file or directory

$GOROOT/src/crypto/sha256/example_test.go:28:24 ExampleNew_file
	stderr: 2009/11/10 23:00:00 open file.txt: No such file or directory

$GOROOT/src/crypto/tls/example_test.go:28:20 ExampleDial
	stderr: panic: failed to connect: dial tcp: Protocol not available

$GOROOT/src/crypto/tls/example_test.go:118:31 ExampleLoadX509KeyPair
	stderr: 2009/11/10 23:00:00 open testdata/example-cert.pem: No such file or directory

$GOROOT/src/crypto/tls/example_test.go:160:38 ExampleX509KeyPair_httpServer
	stderr: fatal error: all goroutines are asleep - deadlock!

$GOROOT/src/crypto/x509/example_test.go:16:34 ExampleCertificate_Verify
	stderr: panic: failed to verify certificate: x509: certificate has expired or is not yet valid

$GOROOT/src/database/sql/example_test.go:140:28 ExampleConn_BeginTx
	stderr: panic: runtime error: invalid memory address or nil pointer dereference

$GOROOT/src/database/sql/example_test.go:156:32 ExampleConn_ExecContext
	stderr: panic: runtime error: invalid memory address or nil pointer dereference

$GOROOT/src/database/sql/example_test.go:55:30 ExampleDB_ExecContext
	stderr: panic: runtime error: invalid memory address or nil pointer dereference

$GOROOT/src/database/sql/example_test.go:132:30 ExampleDB_PingContext
	stderr: panic: runtime error: invalid memory address or nil pointer dereference

$GOROOT/src/database/sql/example_test.go:19:31 ExampleDB_QueryContext
	stderr: panic: runtime error: invalid memory address or nil pointer dereference

$GOROOT/src/database/sql/example_test.go:40:34 ExampleDB_QueryRowContext
	stderr: panic: runtime error: invalid memory address or nil pointer dereference

$GOROOT/src/database/sql/example_test.go:70:43 ExampleDB_Query_multipleResultSets
	stderr: panic: runtime error: invalid memory address or nil pointer dereference

$GOROOT/src/database/sql/example_test.go:262:20 ExampleRows
	stderr: panic: runtime error: invalid memory address or nil pointer dereference

$GOROOT/src/database/sql/example_test.go:221:20 ExampleStmt
	stderr: panic: runtime error: invalid memory address or nil pointer dereference

$GOROOT/src/database/sql/example_test.go:242:36 ExampleStmt_QueryRowContext
	stderr: panic: runtime error: invalid memory address or nil pointer dereference

$GOROOT/src/database/sql/example_test.go:178:30 ExampleTx_ExecContext
	stderr: panic: runtime error: invalid memory address or nil pointer dereference

$GOROOT/src/database/sql/example_test.go:196:27 ExampleTx_Rollback
	stderr: panic: runtime error: invalid memory address or nil pointer dereference

$GOROOT/src/go/types/example_test.go:115:25 ExampleMethodSet
	stderr: 2009/11/10 23:00:00 celsius.go:3:8: could not import fmt (can't find import: "fmt")

$GOROOT/src/go/types/example_test.go:35:21 ExampleScope
	stderr: 2009/11/10 23:00:00 main.go:3:8: could not import fmt (can't find import: "fmt")

$GOROOT/src/image/png/example_test.go:24:22 ExampleDecode
	Errors: prog.go:15:18: undefined: io

$GOROOT/src/io/ioutil/example_test.go:91:24 ExampleReadFile
	stderr: 2009/11/10 23:00:00 open testdata/hello: No such file or directory

$GOROOT/src/io/ioutil/example_test.go:103:25 ExampleWriteFile
	stderr: 2009/11/10 23:00:00 open testdata/hello: No such file or directory

$GOROOT/src/log/syslog/example_test.go:15:20 ExampleDial
	Errors: prog.go:10:17: undefined: syslog.Dial

$GOROOT/src/net/example_test.go:14:24 ExampleListener
	stderr: fatal error: all goroutines are asleep - deadlock!

$GOROOT/src/net/example_test.go:123:31 ExampleUDPConn_WriteTo
	stderr: 2009/11/10 23:00:00 write udp <IP_ADDRESS>:2-><IP_ADDRESS>:2000: sendto: Connection refused

$GOROOT/src/net/http/example_filesystem_test.go:5:1 ExampleFileServer_dotFileHiding
	stderr: fatal error: all goroutines are asleep - deadlock!

$GOROOT/src/net/http/example_handle_test.go:5:1 ExampleHandle
	stderr: fatal error: all goroutines are asleep - deadlock!

$GOROOT/src/net/http/example_test.go:57:26 ExampleFileServer
	stderr: fatal error: all goroutines are asleep - deadlock!

$GOROOT/src/net/http/example_test.go:44:19 ExampleGet
	stderr: 2009/11/10 23:00:00 Get http://www.google.com/robots.txt: dial tcp: Protocol not available

$GOROOT/src/net/http/example_test.go:163:26 ExampleHandleFunc
	stderr: fatal error: all goroutines are asleep - deadlock!

$GOROOT/src/net/http/example_test.go:152:30 ExampleListenAndServe
	stderr: fatal error: all goroutines are asleep - deadlock!

$GOROOT/src/net/http/example_test.go:141:33 ExampleListenAndServeTLS
	stderr: 2009/11/10 23:00:00 About to listen on 8443. Go to https://<IP_ADDRESS>:8443/

$GOROOT/src/net/http/example_test.go:183:31 ExampleNotFoundHandler
	stderr: fatal error: all goroutines are asleep - deadlock!

$GOROOT/src/net/http/example_test.go:116:31 ExampleServer_Shutdown
	Errors: process took too long

$GOROOT/src/net/http/httptrace/example_test.go:14:16 Example
	stderr: 2009/11/10 23:00:00 dial tcp: Protocol not available

$GOROOT/src/net/smtp/example_test.go:13:16 Example
	stderr: 2009/11/10 23:00:00 dial tcp: Protocol not available

$GOROOT/src/net/smtp/example_test.go:57:25 ExamplePlainAuth
	stderr: 2009/11/10 23:00:00 dial tcp: Protocol not available

$GOROOT/src/net/smtp/example_test.go:68:24 ExampleSendMail
	stderr: 2009/11/10 23:00:00 dial tcp: Protocol not available

$GOROOT/src/os/example_test.go:38:21 ExampleChmod
	stderr: 2009/11/10 23:00:00 chmod some-filename: No such file or directory

$GOROOT/src/os/example_test.go:44:23 ExampleChtimes
	stderr: 2009/11/10 23:00:00 chtimes some-filename: No such file or directory

$GOROOT/src/os/example_test.go:52:24 ExampleFileMode
	stderr: 2009/11/10 23:00:00 lstat some-filename: No such file or directory

$GOROOT/src/os/exec/example_test.go:139:34 ExampleCmd_CombinedOutput
	stderr: 2009/11/10 23:00:00 exec: "sh": executable file not found in $PATH

$GOROOT/src/os/exec/example_test.go:52:26 ExampleCmd_Output
	stderr: 2009/11/10 23:00:00 exec: "date": executable file not found in $PATH

$GOROOT/src/os/exec/example_test.go:60:23 ExampleCmd_Run
	stderr: 2009/11/10 23:00:00 Running command and waiting for it to finish...

$GOROOT/src/os/exec/example_test.go:67:25 ExampleCmd_Start
	stderr: 2009/11/10 23:00:00 exec: "sleep": executable file not found in $PATH

$GOROOT/src/os/exec/example_test.go:120:30 ExampleCmd_StderrPipe
	stderr: 2009/11/10 23:00:00 exec: "sh": executable file not found in $PATH

$GOROOT/src/os/exec/example_test.go:100:29 ExampleCmd_StdinPipe
	stderr: 2009/11/10 23:00:00 exec: "cat": executable file not found in $PATH

$GOROOT/src/os/exec/example_test.go:78:30 ExampleCmd_StdoutPipe
	stderr: 2009/11/10 23:00:00 exec: "echo": executable file not found in $PATH

$GOROOT/src/os/exec/example_test.go:29:23 ExampleCommand
	stderr: 2009/11/10 23:00:00 exec: "tr": executable file not found in $PATH

$GOROOT/src/os/exec/example_test.go:41:35 ExampleCommand_environment
	stderr: 2009/11/10 23:00:00 exec: "prog": executable file not found in $PATH

$GOROOT/src/os/exec/example_test.go:21:24 ExampleLookPath
	stderr: 2009/11/10 23:00:00 installing fortune is in your future

$GOROOT/src/os/signal/example_test.go:13:22 ExampleNotify
	Errors: process took too long

$GOROOT/src/os/signal/example_test.go:25:33 ExampleNotify_allSignals
	Errors: process took too long

$GOROOT/src/runtime/trace/example_test.go:5:1 Example
	Errors: process took too long

$GOROOT/src/syscall/js/js_test.go:343:27 ExampleNewCallback
	Errors: prog.go:5:2: build constraints exclude all Go files in /usr/local/go/src/syscall/js

$GOROOT/src/syscall/syscall_windows_test.go:57:27 ExampleLoadLibrary
	Errors: prog.go:12:12: undefined: syscall.LoadLibrary

$GOROOT/src/testing/benchmark_test.go:97:29 ExampleB_RunParallel
	Errors: process took too long

$GOROOT/src/time/example_test.go:146:20 ExampleTick
	Errors: process took too long


Added cpp solution for find-area-of-a-square

find-area-of-a-square CPP solution added
closes #432

Hi @destroyer5067,
The issue you linked is an issue for the program, not language specific. Please link the language specific issue.
Thank you!

Okay, Didn't noticed , i am correcting the issue rightnow

find-area-of-a-square CPP solution added
closes #436

@victoriacheng15  i corrected the issue trackid , now you can review
Thanks for your suggestion

Update,
FindMaximumOfNNumbers.cpp added
closes #676

So basically i added two solutions here,
FindAreaOfASquare.cpp                             closes #436
FindMaximumOfNNumbers.cpp                 closes #676
Just to avoid any confusion

Hey @destroyer5067,
😅 Sorry, I just noticed that you are pushing from the master branch. Please create a branch and then add two solutions you have done. You can refer steps here.
Thank you!

@victoriacheng15  sorry for the same, i will redo  this as suggested


Testing features not possible on Windows

I am trying to build a feature, and I failed. So I wrote a test to see what failed. However, when trying to execute my test, I get this error:
🚀 Launched container.
>  containerId:          765681ff36037ff597185005ba19c57bd1db92eccda9bbd6127d536fd97c6c2e

🏃 Starting test(s)...

🧪 Starting 'oh-my-posh' tests...
Error: Exectuable 'chmod' not found on PATH 'C:\Program Files\PowerShell\7;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\Program Files (x86)\NVIDIA Corporation\PhysX\Common;...'.
    at EF (C:\Users\SebastianGingter\AppData\Roaming\npm\node_modules\@devcontainers\cli\dist\spec-node\devContainersSpecCLI.js:150:4280)
    at async Object.exec (C:\Users\SebastianGingter\AppData\Roaming\npm\node_modules\@devcontainers\cli\dist\spec-node\devContainersSpecCLI.js:150:1655)
    at async W0 (C:\Users\SebastianGingter\AppData\Roaming\npm\node_modules\@devcontainers\cli\dist\spec-node\devContainersSpecCLI.js:591:83)
    at async WtA (C:\Users\SebastianGingter\AppData\Roaming\npm\node_modules\@devcontainers\cli\dist\spec-node\devContainersSpecCLI.js:572:678)
    at async jtA (C:\Users\SebastianGingter\AppData\Roaming\npm\node_modules\@devcontainers\cli\dist\spec-node\devContainersSpecCLI.js:572:197)
    at async $H (C:\Users\SebastianGingter\AppData\Roaming\npm\node_modules\@devcontainers\cli\dist\spec-node\devContainersSpecCLI.js:567:190)
    at async AiA (C:\Users\SebastianGingter\AppData\Roaming\npm\node_modules\@devcontainers\cli\dist\spec-node\devContainersSpecCLI.js:591:4218)
    at async C:\Users\SebastianGingter\AppData\Roaming\npm\node_modules\@devcontainers\cli\dist\spec-node\devContainersSpecCLI.js:591:3506 {
  code: 'ENOENT'
}

It seems, the execTest method in testCommandImpl.ts hardcodes a call to chmod, which is executed on the cliHost. In my case this is Windows, which does not have a chmod.
See https://github.com/devcontainers/cli/blob/2a6ab1ac82f4917654205e2a9b1ac928260d902e/src/spec-node/featuresCLI/testCommandImpl.ts#L596
There's another cliHost.exec() call to chmod in line 539:
https://github.com/devcontainers/cli/blob/2a6ab1ac82f4917654205e2a9b1ac928260d902e/src/spec-node/featuresCLI/testCommandImpl.ts#L539
Maybe the chmod should be done in the container, and not on the host?

Hi 👋
Thanks for reporting, it definitely looks like a bug.
In the meanwhile, @gingters can you work within a dev container? I believe that's how most of the community runs Feature tests, hence, this wasn't reported until now.

//cc @joshspicer for visibility

Thanks for reporting. In the meantime, i'd also suggest using WSL if possible to run the CLI.


Change documentation for Rocks import

close #1316

Reviewer Tips (@arielshaqed style :) ):
import-mvcc.md is the old docs, it hasn't change except for the title.

Reviewer Tips (@arielshaqed style :) ):
import-mvcc.md is the old docs, it hasn't change except for the title.

Codecov Report

Merging #1317 (70c423f) into master (d7fd327) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1317      +/-   ##
==========================================
- Coverage   47.10%   47.09%   -0.02%
==========================================
  Files         203      203
  Lines       15903    15903
==========================================
- Hits         7491     7489       -2
- Misses       7423     7424       +1
- Partials      989      990       +1

Impacted Files
Coverage Δ

catalog/mvcc/cataloger_create_branch.go
81.53% <0.00%> (-3.08%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7fd327...70c423f. Read the comment docs.

Codecov Report

Merging #1317 (70c423f) into master (d7fd327) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1317      +/-   ##
==========================================
- Coverage   47.10%   47.09%   -0.02%
==========================================
  Files         203      203
  Lines       15903    15903
==========================================
- Hits         7491     7489       -2
- Misses       7423     7424       +1
- Partials      989      990       +1

Impacted Files
Coverage Δ

catalog/mvcc/cataloger_create_branch.go
81.53% <0.00%> (-3.08%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7fd327...70c423f. Read the comment docs.


Remove console copy task from jetty stage task

This is a follow up on a last comment in https://github.com/google/nomulus/pull/2433.
As we no longer use jetty to serve a webapp, I've decided to just remove it altogether.

This change is

This is being served by vanilla Jetty, where you don't have the issue with the "expires" header. If you remove it you'd have to come up with a different way to serve the static content. If I recall correctly you didn't want the node server to be a permanent solution, right? For now you just need to change the task to copy from the correct location. Later we can work on fine tuning the parameters used by Jetty's default servlet.


Use random salt per key

Please describe the enhancement
See design doc
Solution Proposal
Add code which generates salt per secret and stores in the DB.
Describe alternatives you've considered
No response
Additional context
No response
Acceptance Criteria
No response

Not doing this as a separate task - it will be solved as part of #3317


Switch to straight.el built-in builder for org

Since Doom updated the pinned commit for straight.el a few days ago we can now use their built-in builder for org.
See https://github.com/raxod502/straight.el/pull/535 for more info.
Two questions remain:

Should we keep using the github mirror of org or use the default option of straight (https://code.orgmode.org/bzg/org-mode.git)
Should we keep the :shadow keyword of package! since it's no longer used anywhere in the code.

Hi! Thanks for the PR, but I cannot accept it.

I want to continue using the mirror because (as the comments over our package! say), the original's server is unreliable compared to github's.
The built-in :build command does not fix the problem for shallow clones, which Doom defaults to. It only addresses full clones.
:shadow is still in use and necessary.
Your change to doom-package-recipe-repo is unnecessary as well, because straight-recipes-retrieve evaluates quoted recipes internally.

In any case, thanks for your help!


Implement "Send" button

Implementation of a "Send" button for the Webchat.

📏 Reduced input width
🔘 Add button using Preferences colors for enable/disable state (accentColor/botMessageColor)
🖼 Use SVG as an icon
💅 Run Eslint + Prettier

Preview

Thank you for the PR! 👍
I'll just update it to change the SVG used for the button, remove the preference notion, and make the button appear only on small screens.

@jhoudan Thanks :) I was out-of-office and traveling so I didn't have much choice of choosing a great SVG.

I'm just wondering why removing the "preference notion"?
Why only appearing on small screens? The request was to make it available on desktop also


Suggested improvements: Nth-Prime

I have a few questions/suggestions to improve the 'nth-prime' challenge.
Should we make people use the Prime Number Theorem? Right now people can write a solution that just finds a preset amount of primes and then picks the nth prime (which is what the example does). This is obviously not an optimized approach as you will be waiting the same time to get the 1st prime as the 100th. Could this be solved by checking the time taken to find 100 primes is greater than that of 1 in a test?
If we were to add the test:
it('huge prime', function () {
    expect(prime.nth(18000)).toEqual(200183);
  });

then the example code would fail as not enough primes are generated. To me the example code isn't that robust and the tests allow for code that isn't robust as well.
Edit: I also thought that this currently allows the exact copying of the previous 'sieve' exercise, with a small addition of grabbing a single value from the array it gives. If this can be solved with almost no unique code then is it doing its job?

@kytrinyx Is this something that this an issue shared by others? If so I happy to open a PR?

@gavinhenderson I appreciate your thoughts on this.
I think there are three issues you raise here, and I'm unconcerned about the last (unique code from the sieve exercise.)
I don't think we should require anyone to implement their solution with any specific algorithm-- that's really what the peer-to-peer discussion is about.
However, I think a better test for a quality method of generating primes would be welcome!  I encourage you to submit a PR, let's see how long it takes to build-- is this practical?  I'd love to know.
Please let me know if I can assist further.

@gavinhenderson By 'unconcerned,' I just mean that I think it's OK for people to realize that they can leverage code that they've already written.  I do that every day :)  I also think it's OK for them to decide to write new code, and I think both choices can provoke discussions like the one we're having now.
I also understand that some people will read the example code in an attempt to expand their understanding of what can and should be done, so I think it's great that you are willing to help us upgrade the example solution code.
I look forward to reviewing the PR!

Fixed #542


amend: Allow amending with pure renames

If the only staged changes are pure renames, 'git diff --cached
--quiet' will not report any changes. As a result, attempting to
'revup amend' would skip writing a new tree for the commit and the
rename would still be staged rather than added to the amended commit.
Fix this by turning off rename detection when checking for staged
changes in 'revup amend'. This should be slightly more efficient as
well.
Signed-off-by: Brian Kubisiak<EMAIL_ADDRESS>

Reviews in this chain:
└https://github.com/Skydio/revup/pull/191 amend: Allow amending with pure renames

#
head
base
diff
date
summary

0
9a5dd801
d29851a6
diff
Nov 5 5:48 AM
1 file changed, 5 insertions(+), 2 deletions(-)


not getting access to Camera in Mac-Latest versions using Webcam.getWebcams(), or Webcam.getDefaultCam()

Tried many ways using saros 0.3.12 jar and not able to access webcam (both internal and external) in latest MAC OS versions.

Same here.  Here's some other similar tickets; seems like Mac has been difficult to maintain.
https://github.com/sarxos/webcam-capture/issues/808
https://github.com/sarxos/webcam-capture/issues/766
https://github.com/sarxos/webcam-capture/issues/757
https://github.com/sarxos/webcam-capture/issues/723
Though actually, it looks like the final post in #757 ( https://github.com/sarxos/webcam-capture/issues/757#issuecomment-849632328 ) works - I don't know which components are strictly necessary, but after swapping out my dependencies for the ones that look relevant, and adding the repositories, my test code compiled and ran, apparently correctly fetching a default webcam (which was where I was stuck before).

I removed the dependency on webcam-capture-driver-openimaj, and it still fetched a webcam correctly, but both the repositories seem necessary, and presumably both webcam-capture and bridj are necessary.

Hi, please try this driver, it should work with recent MacOS versions https://github.com/eduramiba/webcam-capture-driver-native


Add configuration and splittable cventry arguments

Hi, I don't know if you'd be interested in this PR.
My editor (Helix) configured to format Markdown files changes * to _, I'm not sure why.
This PR adds two variables at the top of the Python script:

one to set the character to parse to split the dates away from cventry title
one to say if we want to keep only two arguments to cv entry or if we want to split them (in my case I chose to split on --)

Let me know, any comment or suggestion is welcome.
Thank you

Hi, I wouldn't accept the PR as is, but I would be happy to merge these changes if you can request them separately.

Support for _ in addition to * for italics, without changing the tex template. I think this would also make the optional date separator redundant.
GitLab link
Bash script for Unix-based systems


Export arrays from go-core.bash with Unit Separator, not NUL

After #107, in which I decided to use the ASCII Unit Separator ($'\x1f') to delimit array elements for @go.array_printf because doing so with NUL ($'\0') wasn't working, it seemed a good idea to switch the _GO_CMD_NAME and _GO_CMD_ARGV export mechanism to use the Unit Separator as well.

Coverage remained the same at 94.876% when pulling 1e648bd14c1940d4f301901e3e883d52601139fe on export-vars-x1f into d6dc9fccb3db2429f6c00d0d6a2d923dd5a9cc8f on master.


Add image dimensions in stack image.

Can I confirm that we really want alt text for a purely decorative image?

Personally, I'd say that image is mostly decorative, so alt="" is ok. The proposed new alt may actually make users who can't see the image wonder if this is some sort of diagram/visualization of the BS stack (with labels and arrows and such).


299 refactor dashboard

title: Issue #299  | [TASK]: Refactor dashboard

Discord Username: @dekomori_sanae09
What type of PR is this? (select all that apply)

[x] 🍕 Feature
[ ] 🐛 Bug Fix
[ ] 🚧 Breaking Change
[x] 🧑💻 Code Refactor
[ ] 📝 Documentation Update

Description
There are a lot of changes.

Renamed files to camel case.
Added components folder inside dashboard page.
It shows basic stats like races participated, snippets created, rank(for now its set to 1).
the top progress bars become a scrollable elemt in small screen/ mobile screens.
It has 2 tabs for races and snippets.

Next Steps

[ ] Add other graphs like accuracy cpm performance
[ ] Add data-table in snippets tab

Related Tickets & Documents

Related Issue #299
Closes #

QA Instructions, Screenshots, Recordings
Small demo:
https://github.com/webdevcody/code-racer/assets/95468529/c5e207b6-1f64-46fb-810f-647826def8de

UI accessibility concerns?
It is mobile responsive.

Added/updated tests?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

It looks a bit pissed on the mobile screens. Could you remove the scroll area and make the cards be in a column?

 It looks a bit pissed on the mobile screens. Could you remove the scroll area and make the cards be in a column?

ok will work on it and the scrolling too


Forwarding non-transactional API to transactional API in FileSystem

This PR adds implementations for non-transactional filesystem API to transactional api. This removes pure virtual methods. Follow up PRs will move implementations of FileSytem to transactional API, remove virtual property of non-transactional api, and convert transactional api to pure virtuals where needed.

Posting again since I posted in wrong place.
Yes. This is what I meant in the body of the PR. If I do it now, I need to change all filesystems at once since they don't implement transaction API yet.


nvme_client: set hostid during nvme connection establishment

Starting from kernel v6.5-rc1, there is a new restriction about hostid.
When hostnqn is passed without a specified hostid, the default hostid generated by nvme during initialization is used. The default hostid is already associated with the default hostnqn, So, when attempting to connect with a specified hostnqn, the connection fails due to encountering the same hostid (x) but different hostnqn (y). Therefore, hostid should be provided with hostnqn.
As multiple hostnqns are not currently supported, a constant hostid can be used.
See commit:
https://github.com/torvalds/linux/commit/ae8bd606e09bbdb2607c8249872cc2aeaf2fcc72
Issue: LBM1-30942

CC @majst01 : this is the PR for fixing the issue you are most likely running into with https://github.com/LightBitsLabs/los-csi/pull/32#issuecomment-1885039601.

Yes, I can confirm that this resolves the issue.
Tested with a busybox statefulset with a simple volume:
# lb-nvme-discovery-client:aebef130 (from main branch)
kube-system      5m23s       Normal    Created                             pod/lb-csi-node-dwd44                                   Created container lb-nvme-discovery-client
kube-system      5m23s       Normal    Pulled                              pod/lb-csi-node-dwd44                                   Container image "mwennrich/lb-nvme-discovery-client:aebef130" already present on machine
default          106s        Normal    SuccessfulCreate                    statefulset/busybox                                     create Pod busybox-0 in StatefulSet busybox successful
default          106s        Normal    SuccessfulAttachVolume              pod/busybox-0                                           AttachVolume.Attach succeeded for volume "pvc-5c52390c-67ab-4fe8-99c2-ae0092291a55"
default          43s         Warning   FailedMount                         pod/busybox-0                                           MountVolume.MountDevice failed for volume "pvc-5c52390c-67ab-4fe8-99c2-ae0092291a55" : rpc error: code = Unknown desc = OS error: no local block device for volume e28db617-dbcc-4bb1-a318-8f4d88de07b0

# => MountVolume.MountDevice failed issue is present (with lb-nvme-discovery-client from main)

# lb-nvme-discovery-client:5bb3b071 (from this guy/add_hostid branch)
kube-system      18s         Normal    Killing                             pod/lb-csi-node-dwd44                                   Stopping container lb-nvme-discovery-client
kube-system      17s         Normal    Pulling                             pod/lb-csi-node-nqnx9                                   Pulling image "mwennrich/lb-nvme-discovery-client:5bb3b071"
kube-system      15s         Normal    Created                             pod/lb-csi-node-nqnx9                                   Created container lb-nvme-discovery-client
kube-system      15s         Normal    Started                             pod/lb-csi-node-nqnx9                                   Started container lb-nvme-discovery-client
kube-system      15s         Normal    Pulled                              pod/lb-csi-node-nqnx9                                   Successfully pulled image "mwennrich/lb-nvme-discovery-client:5bb3b071" in 2.04928555s (2.049293965s including waiting)

# volume gets immediately mounted, pod can start
default          11s         Normal    Pulling                             pod/busybox-0                                           Pulling image "busybox:latest"
default          10s         Normal    Started                             pod/busybox-0                                           Started container busybox

@guy-lb looks good to me. Please verify all tests with tag discovery pass with it (-t discovery) and also that the lb-csi PR check passes with it, and let's merge. We need the same patch also in lb-csi, until we finally get rid of it.

We would love to get this together with https://github.com/LightBitsLabs/los-csi/pull/32 to have newer kernel support.

We would love to get this together with LightBitsLabs/los-csi#32 to have newer kernel support.

@majst01 I expect we'll merge them early next week and then we'll figure out how to get a release version out to you, although maybe you're fine just using the latest directly from github? The pace of changes in the dsc and the CSI plugin is pretty glacial.

PR check passed, all stable tests (16 tests) in lb-csi passed, and I ran manually tests with tag 'discovery' - also passed.
I tested this with kernel v6.6 - passed.

@guy-lb sounds good, let's merge it


Checking if selenium server is already running

Originally submitted to Google Code by markhu on 9 Jan 2012

How would I detect if the server is already running?
I'm trying to structure my tests so that a selenium server and browser only needs to be created once.
Currently my setup and teardown for each test starts selenium, opens a browser, logs in, runs the test, logs out, closes browser, stops selenium for every single test.
Some ways I could do this would be:

detect if the server is currently running and use existing instance

only call start on a server if this is the 1st test to run and only call stop if it's the last test

For #2 I would need a way to know how many tests are currently in queue and which test I'm on.
Or is there a better way to approach this ?
Thanks.

Originally submitted to Google Code by markhu on 9 Jan 2012

I have also tried to run keywords that require a selenium server and browser instance to be open using the run keyword and ignore error style wrappers but they don't trap exceptions so entire suite fails at that point.

Originally submitted to Google Code by @pekkaklarck on 10 Jan 2012

My general recommendation is to start Selenium Server either before the execution or in highest level suite setup. If neither of these work for you, could you explain why? If there's a good enough reason, perhaps Start Selenium Server keyword could be changed so that it only starts the server once and running it again does nothing.

Originally submitted to Google Code by markhu on 10 Jan 2012

Well that sounds like a great idea.. I mean as far as selenium server goes I could also just create a global flag that marks it as started but there is possibility that it could crash so your suggestion is better..
As far as the top level suite how would I go about doing that?  I believe I tried to create a top level resource file that contained suite setup and teardown but it does not run on it's own it has to be called by a test case I believe which means it would run setup/teardown for every single test which is currently where I am.

Originally submitted to Google Code by @pekkaklarck on 11 Jan 2012

Resource files cannot have setups/teardowns but both normal test case files and suite initialization files can have suite setup and suite teardown:
http://robotframework.googlecode.com/hg/doc/userguide/RobotFrameworkUserGuide.html#suite-setup-and-teardown

Originally submitted to Google Code by markhu on 17 Jan 2012

Thanks that does the trick!

Originally submitted to Google Code by @pekkaklarck on 19 Jan 2012

Great. I think this issue can be closed.


tests: drivers: build_all: sensor: do not run build-only testsuite

A recent modification to the build_all/sensor testsuite changed build-only to false in testcase.yaml, which is causing CI to go bonkers.
https://bit.ly/3rSe0Te
Please do not run build-only testsuites.
Fixes #60958

Hi @cfriedt et. al., just wanted to follow up on this. I submitted the change that added the sensors.generic_test testcase and made it build+run recently in PR #60394. What this test does is described in that PR's description but the rationale for placing it here was to take advantage of the sensor build_all test's massive devicetree of sensors. It is indented to run but I don't blame you for reverting that to get CI back on track quickly. If there is a more appropriate place to locate this I'm happy to discuss.
On the topic of what went wrong in CI based on the log, a sensor (MAX17262) got stuck in a loop within its init function and spammed the log every 10ms, attempting to make a transaction on the I2C bus. This of course fails since there is neither an emulator nor phsyical device attached, but that shouldn't matter as drivers are expected to fail gracefully if they cannot initialize and simply remain not ready. Taking a look at this driver, I found a bug where the return code from the I2C read/write function calls are not error-checked. So if the read fails the tmp variable is never loaded with an legit value leaving it uninitialized. This never happened in my dozens of local test runs, but apparently in this CI run the right bit happened to be set to get stuck in that polling loop and it held everything up. I'm going to upload a PR for this driver to add error checks to prevent this. I do think there is value in trying to initialize all of these drivers in addition to building them. This would be the second driver bug I've caught through this test (the first surfaced during development and was fixed in #60119)

Hi @cfriedt et. al., just wanted to follow up on this. I submitted the change that added the sensors.generic_test testcase and made it build+run recently in PR #60394. What this test does is described in that PR's description but the rationale for placing it here was to take advantage of the sensor build_all test's massive devicetree of sensors. It is indented to run but I don't blame you for reverting that to get CI back on track quickly. If there is a more appropriate place to locate this I'm happy to discuss.

Hi @tristan-google - I think the change you made makes total sense, so just wanted to get that out there. I try to never critique the author but try to focus on critiquing code. In this case, there wasn't even anything wrong with the code per se. It just happened to make CI go kind of off the rails.

On the topic of what went wrong in CI based on the log, a sensor (MAX17262) got stuck in a loop within its init function and spammed the log every 10ms, attempting to make a transaction on the I2C bus. This of course fails since there is neither an emulator nor phsyical device attached, but that shouldn't matter as drivers are expected to fail gracefully if they cannot initialize and simply remain not ready.

100% agree - I didn't go for a deep dive here, but thanks for looking into the root cause.

Taking a look at this driver, I found a bug where the return code from the I2C read/write function calls are not error-checked. So if the read fails the tmp variable is never loaded with an legit value leaving it uninitialized. This never happened in my dozens of local test runs, but apparently in this CI run the right bit happened to be set to get stuck in that polling loop and it held everything up. I'm going to upload a PR for this driver to add error checks to prevent this. I do think there is value in trying to initialize all of these drivers in addition to building them. This would be the second driver bug I've caught through this test (the first surfaced during development and was fixed in #60119)

Awesome - as long as @MaureenHelm is OK with it, I'm ok with that testcase.yaml permutation being run in CI too once the driver is fixed.
Thanks for following up, and sorry for not seeing your message until today, but GH notifications are a bit like drinking from the firehose for maintainers.

Thanks Chris. The bug fix for that driver is now merged in #61016. Looking forward to hearing from Maureen.


Can't send alert from Nagios to Alerta

Hi All,
I have installed Alerta and Nagios on different servers.
On the first server (Alerta) I follow the steps on official documentation on Ubuntu 16 (http://docs.alerta.io/en/latest/tutorials.html#tutorials). It run and I can send alarm from command line on localhost.
On second server I've installed Nagios Core 4 and Nagios-alerta from this repo.
But I can't send any alarm.
I try some configuration but I receive different error:

broker_module=/usr/lib/nagios/alerta-neb.o http://<IP_ADDRESS>:80/api key=API_KEY --> [1544546431] alerta: HTTP server error (status=500)
broker_module=/usr/lib/nagios/alerta-neb.o http://<IP_ADDRESS>:8080 key=API_KEY -->alerta: curl_easy_perform() failed: Couldn't connect to server (on Alerta server any service on 8080 port)
broker_module=/usr/lib/nagios/alerta-neb.o http://<IP_ADDRESS> key=API_KEY -->
[1544546544] alerta: HTTP server error (status=404)

where I wrong?
Thx.

If you set debug=1 you will be able to see the HTTP request and response in the logs. Without that it's hard to know what's going on.
Example
broker_module=/usr/lib/nagios/alerta-neb.o http://localhost:8080 debug=1

Hi,
thanks. With debug mode I saw the error. So I solved it.


JMarkman LINQ article improvements

Summary
After reading through the issue, I followed @rpetrusha's response to the ticket as closely as I could. I removed the Auto Properties section as noted, and added an example of how object initialization might work with LINQ. The example builds off of the established example in the object/collection initialization section where readers are asked to consider a hypothetical data source (in-memory collection, database, etc.) called IncomingOrders; the query itself is rudimentary, only consisting of two statements, Where and Select.
Supplementing the LINQ query is a duplicate version of said query, but written in method syntax. As such, the "For more information, see" area was modified to no longer be a single sentence but a list containing its original link to the Object and Collection Initializers page and a new link to Query Expression Syntax for Standard Query Operators as mentioned in the ticket comments by @BillWagner
A minor page fix was also added in the Anonymous Types section: the code snippet was missing a csharp tag, so I added it there for syntax highlighting.
Fixes #7331

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: jmarkman sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Make all comments show up good on godoc.

Feature description
Make all comments show up good on godoc.
Some comments are missing some just don't show up well on godoc
Main Reason for adding this feature
GoDoc is an awesome tool and we can leverage it to have our code fully documented online.

Hi, since no one has taking this up and to provide a simply walk into the project, I can take this up and go through the sources to fix comments as needed.

@influx6 Can be a great intro to the project would be great if you can take it!

this was done but we have to revisit

@y0sher is this still relevant?

Obsolete.


protractor-conf.js does not exist

module.js:340
throw err;
^
Error: Cannot find module '/Users/raamroshhai/PhpstormProjects/DevPortal/config/protractor-conf.js'

Hey, we didn't have support for Protractor, instead opting for Karma to run our e2e tests. This has now changed and you should be able to use Protractor for running e2e tests.


3bot deployer requires farms to have ip4 and ip6

this narrows the results to freefarm only, should use ip4

verified, when deploying on https://deploy3bot.grid.tf/threebot_deployer/#/ farms include both not just ipv4

verified, when deploying on https://deploy3bot.grid.tf/threebot_deployer/#/ farms include both not just ipv4


Datetime column frequency inference V2

In #1202, we added the ability to infer frequencies for temporal (datetime and timedelta) columns in a Woodwork dataframe. This inference is called for by the user and is not stored anywhere on the DataFrame. It also only works for pandas DataFrames.
There are a number of improvements we could make. They are listed here, and we can create individual issues if any of these become necessary to implement.

Store inferred frequency in the Woodwork typing info

Should likely be stored on the Datetime logical type object
If stored on Datetime logical type object, we need to implement validation in Datetime.transform (or the validation method if #1192 has implemented a LogicalType.validate method)

If we can store the frequency, automatically infer the frequency for time index columns and store it

Add frequency inference as column accessor method as well - can automatically store on logical type

Sort columns passed to infer_temporal_frequencies before trying to infer frequencies

from @freddyaboulton : I would say no until we figure out how often/useful it is to infer frequencies on multiple datetime columns. My hunch is that most users will only care about the time_index which will already be sorted so let's not double sort for now. Of course, users can have a non-sorted time_index but I don't think there's anything we can do about that.

Only pass a single subset (must be taken consecutively from series) to use for frequency inference

from @freddyaboulton: I am on the fence about this. I think we would need to do some experimentation to see what results we get with taking a sample vs not. My guess is that it's ok to do so. If we can't infer a frequency on the first k rows, we're not going to be able to infer a frequency on the whole column. In my opinion the right thing to do is to take the first-order diff of all rows and find the frequency that works the best for the most rows (like what's mentioned in #1165 for datetime format inference) but that seems like a v2 improvement?

Use multiple subsets of data (that's long enough) for frequency inference and take the mode of non-null inferred frequencies

Implement for Dask and Koalas dataframes as well (if using just a subset of data, this will be doable)

@tamargrey Can we support irregularly spaced time frequencies? My guess is pandas doesn't support it, so we would have to implement our own...


[trivial] fix typo

Fix typo
Delete duplicated code

Signed-off-by: hyeonseok lee<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #1917. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

:octocat: cibot: @lhs8928, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/1917-202205292343420.49512600898743-cdb808cf393ff0ae20e6626b292a18051b6e633e/.

:octocat: cibot: @lhs8928, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/1917-202206092207410.59491109848022-cdb808cf393ff0ae20e6626b292a18051b6e633e/.


Enabling proxy config without ingress

Would it be possible to seperate out the configuration of the http options in the configuration.yaml and it being tightly coupled with the ingress.yaml template?
I've decided to go down the route of using an Istio gateway along with a virtual service. However, setting the ingress to true to enable the http configuration below then causes ip mismatch errors to occur.

For now, I've just overwritten the template in the yaml to get around the issue.

@liamsorsby configuration.yaml is just a part of regular values file. Drop these two lines from your helm values and you are good to go, https://github.com/pajikos/home-assistant-helm-chart/blob/main/charts/home-assistant/values.yaml#L180 https://github.com/pajikos/home-assistant-helm-chart/blob/main/charts/home-assistant/values.yaml#L187 even without a enabled ingress. I just tested that with my gateway api.

@liamsorsby configuration.yaml is just a part of regular values file. Drop these two lines from your helm values and you are good to go, main/charts/home-assistant/values.yaml#L180 main/charts/home-assistant/values.yaml#L187 even without a enabled ingress. I just tested that with my gateway api.

Thank you, Lukas 💯
@liamsorsby Have you tried editing the default values?


bugfixFix cache inconsistency issue

Proposed changes

Concurrency issues:
a. One thread is performing a refresh catalog action.
b. One thread is performing an insert table action, and after completion, it executes a refresh table action.

The partitionCache will be refreshed only if the corresponding table exists in the partitionValuesCache. However, the partitionValuesCache may have been refreshed by the refresh catalog, resulting in the inability to find the corresponding table through the partitionValuesCache, resulting in the partitionCache not being refreshed.
Similarly, the fileCacheRef may not be refreshed either.
Therefore, directly search for all keys to match to prevent them from being refreshed.

No need to perform refreshAfterWriteSec operation on partitionCache.


Statistics Calculator: project form submit is triggering document event listener

Describe the Issue

Go to the last step and complete it.
Use the form and check the browser console.

Uncaught TypeError: Cannot read properties of null (reading 'match')

Client code throwing:
document.addEventListener('submit', function(e) {
  const action = e.target.getAttribute('action');
  e.preventDefault();
  if (action || action.match(/https?:\/\//)) {
    window.parent.window.alert(
      i18nContent.t('misc.iframe-form-submit-alert', { externalLink: action  })
    )
  }
}, false);

We can use stopPropagation in the project code to prevent this. But I guess as a fix for this it would be a little confusing for the camper. Not sure if we just silently add this code ourselves or if we need another solution to it.
Edit: As pointed out in the thread adding an empty action attribute will fix it as well and might be a less intrusive option. We can likely add that silently and not cause too much confusion.
I did not check if other projects using forms are affected by this, but I guess they might be.
Affected Page
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/learn-advanced-array-methods-by-building-a-statistics-calculator
Your code

Expected behavior
Not throwing errors.
Screenshots
No response
System

Device: [e.g. iPhone 6, Laptop]
OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04]
Browser: [e.g. Chrome, Safari]
Version: [e.g. 22]

Additional context
Forum: https://forum.freecodecamp.org/t/learn-advanced-array-methods-by-building-a-statistics-calculator/664404

Edit: As pointed out in the thread adding an empty action attribute will fix it as well and might be a less intrusive option. We can likely add that silently and not cause too much confusion.

I vote for this option

I agree, I also just realized they are not asked to write the HTML so it would be easy to add it without it causing any confusion.

Also, does anyone know why we have return false; in some of the HTML for the onsubmit and if we actually need that?
<form onsubmit="calculate(); return false;">

Also, does anyone know why we have return false; in some of the HTML for the onsubmit and if we actually need that?

I think there might be a step to explain that but it has been a while since I went through this project.
I believe @naomi-lgbt would have more context on that cause I think she worked on this project.

The root cause was actually incorrect boolean logic in the injected code. I've pushed a PR to resolve that.

Outside of that, I am happy to discuss updating the project:

I guess technically it is invalid HTML to leave it empty. But I'm not sure if that is a huge issue.

Yes, in HTML 4 the action attribute was required, but in HTML 5 it is optional. If provided, however, it must be non-empty. IMHO we should stick to the standard.

Also, does anyone know why we have return false; in some of the HTML for the onsubmit and if we actually need that?

Likely not. It does call both preventDefault() and stopPropagation() all at once, AFAIK. I vaguely remember fighting e.preventDefault() when building this project (probably related to binding the attribute instead of using a dedicated listener?), but I'm not at all attached to the current implementation and would be happy to switch to a proper event listener.

@naomi-lgbt Could we make a decision on this issue?

This issue was technically resolved by my earlier PR. I think we're fine to close this - we can create a separate issue if we'd like to discuss changing the project to teach different approaches.


Is it possible to have multi channel transcription?

I was interested to know if that is currently possible to have multichannel support from the same audio with different microphones or different audio sources?

To my knowledge, the model.transcribe() function only supports mono audio with single channel. But if you want to use multi channel audio, you can split your audio into multi signals then send them to the transcribe function for detection.
For plus info: https://github.com/SYSTRAN/faster-whisper/pull/97

thank you for the support


R&D on reusable styles

Let's figure out how this works for angular, react and vue and add comments below.

For Vue,
// In Component A

// In Component B

Can also import sass as well if style tag lang is set to scss

For React,
foo.css
.error {
  background-color: red;
}

button.jsx
import React from 'react';
import fooStyles from './foo.css'; // Import css modules stylesheet as styles
import './another-stylesheet.css'; // Import regular stylesheet
export default () => {
    return (<button className={fooStyles.error}>Error Button</button>);
}

Needs css-loader / sass-loader

global.scss
.something{ ... }
component.scss
@use './global';
component.html
Hello World

we can create a separate library. it will  handle our base scss files and can be import between apps and other feature libraries.
but the problem is we have to setup for every app inside angular json,
"stylePreprocessorOptions": {
              "includePaths": [
                "libs/common/ui/my-styles-library/src/lib"
              ]


Boot crash with DEBUG logging enabled in efuse component (IDFGH-3367)

Environment

Development Kit:      none
Module or chip used:  ESP32-WROVER
IDF version: v4.2-dev-1575-ga3520970f
Build System:        CMake
Compiler version (run xtensa-esp32-elf-gcc --version to find it):
xtensa-esp32-elf-gcc (crosstool-NG esp-2020r1) 8.2.0
Operating System:     Linux
Using an IDE?: Yes (CLion)
Power Supply:         External 3.3V

Problem Description
When DEBUG logging level is enabled, an abort() is triggered on startup:
The issue appears to be in the efuse component, if I comment out this everything works fine:
            ESP_LOGD(TAG, "In EFUSE_BLK%d__DATA%d_REG is used %d bits starting with %d bit",
                    (int)field[i]->efuse_block, num_reg, num_bits, start_bit);

If, rather than commenting it out I replace it with this, it still crashes:
            ESP_LOGD(TAG, "A");

I'm pretty lost at how to best debug this further.
Code to reproduce this issue
extern "C" {
    void app_main() {
        while (1) {
            vTaskDelay(1000);
        }
    }
}

Debug Logs
... (nothing usual here)
I (896) spiram: PSRAM initialized, cache is in low/high (2-core) mode.
I (900) cpu_start: Pro cpu up.
I (902) cpu_start: Application information:
I (904) cpu_start: Project name:     esp32_test
I (907) cpu_start: App version:      1
I (909) cpu_start: Compile time:     May 25 2020 16:34:05
I (912) cpu_start: ELF file SHA256:  1b891882d215d037...
I (915) cpu_start: ESP-IDF:          v4.2-dev-1575-ga3520970f-dirty
I (919) cpu_start: Starting app cpu, entry point is 0x40082088
D (922) efuse: coding scheme 0
/home/jeremy/esp/esp-idf/components/freertos/queue.c:1447 (xQueueGenericReceive)- assert failed!
Re-enable cpu cache.

abort() was called at PC 0x4008f8e8 on core 0

Backtrace:0x4008bae2:0x3ffe39b0 0x4008c229:0x3ffe39e0 0x40090add:0x3ffe3a10 0x4008f8e8:0x3ffe3a90 0x40090991:0x3ffe3ad0 0x401717b9:0x3ffe3b00 0x400908b6:0x3ffe3b40 0x400febb5:0x3ffe3b90 0x400fe8c2:0x3ffe3be0 0x400ff0d1:0x3ffe3c10 0x40082234:0x3ffe3c40 0x40079926:0x3ffe3c80 |<-CORRUPTED

ELF file SHA256: 1b891882d215d037

Rebooting...

Other items if possible
Note: sdkconfig has encryption enabled, be careful.
sdkconfig.txt

Hi @jeremyherbert!
I understand what is going on here. Thanks for your report. The solution which I will apply is to change all ESP_LOGx to ESP_EARLY_LOGx in the efuse component. We need to use  ESP_EARLY_LOGx because the efuse API is used in the early startup code, before heap allocator and syscalls have been initialized.
Thanks.

Thanks, I suspected something like that was happening.

@jeremyherbert. You can apply this patch 8904.zip, so as not to wait when it will be merged with the master.
Thanks.

great, thank you!

i was just loking for that today

Ran into this issue today. Patch works for me.
Looking forward for the merge.

Hi @KonstantinKondrashov
Thanks, the patch works.
BTW, I'm quite surprised you have the patch 24 days ago but the fix is still not in github.
(Especially the changes is quite clean as it only replaces ESP_LOG* to ESP_EARLY_LOG*)

Hi @projectgus  @KonstantinKondrashov
Above shows "projectgus pushed a commit that referenced this issue 8 days ago".
I'm wondering if something wrong, I cannot find the commit  a6ac0e8 in current master tree.
I did git pull && git submodule update but nothing is pulled (still in v4.2-dev-1905-g625bd5eb1806).

Hi @AxelLin ,
Sorry about this. Because of an internal problem with our CI checks, the release/v4.2 branch has pushed out some backported fixes which are not on master.
(You can see which branches a commit belongs to by viewing the commit in github, the branch list is at the bottom of the blue box.)
We accept this is not a good situation to be in, generally we don't want the "backported" release branches moving ahead of master. We're working to deploy master ASAP which will correct the situation.

hi @jeremyherbert  i have a question


add conversationId also when history is not enabled; add support to Application Insights and local logs to log user and bot messages

@microsoft-github-policy-service agree [company="{Microsoft}"]

This would be nice to have. Application insights seems useful.


Make coverage work with integration tests

The only thing we need to do is to mount `source` and `submodules`
in the working directory so that the coverage code can access it
(otherwise it's unable to generate reports).
Since coverage won't be enabled very often, or by end user,
the option to store it in the data directory is removed
(it also became moot since the reshuffling of the docker image).

The Dockerfile has also been slightly improved.

bash: line 1334: ./tests/system/node/0/submodules-vibe-core-source-vibe-core-path.lst: Permission denied

All files are permission 600, of course...
https://github.com/dlang/druntime/blob/873fac33014c5af680c4bed69bb74cb0f192198a/src/rt/cover.d#L419

Restarted the only failure on travis. Seems like a timing issue.

Merging since it was approved and is green (and yes it was a timing issue)


Langchain PGVector is not working is not able to call the sql alchemy in vectorstore.py (missing package error)

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
import psycopg2
from langchain_postgres.vectorstores import PGVector
from langchain_community.document_loaders import TextLoader
from langchain.text_splitter import RecursiveCharacterTextSplitter
from langchain_community.embeddings import GooglePalmEmbeddings
from langchain_google_genai import GoogleGenerativeAI
from langchain_core.documents import Document
from langchain_postgres import PGVector
from langchain_postgres.vectorstores import PGVector
from langchain_community.vectorstores import pgvector
import pgvector
from pgvector.sqlalchemy import Vector
loader=TextLoader("/home/sambasiva/dev/fastapi-template/src/api/embedding_transformer/timeline.txt",encoding="utf8")
documents=loader.load()
text_splitter = RecursiveCharacterTextSplitter(chunk_size=1000, chunk_overlap=20)
chunks = text_splitter.split_documents(documents)
embeddings = GooglePalmEmbeddings(google_api_key=API)
connection = "postgresql+psycopg://vectorapi:vectorapipass@localhost:5432/vectordb"
collection_name = "my_docs"
db=PGVector.from_documents(embedding=embeddings,documents=chunks, collection_name=collection_name,connection=connection,)
print(len(chunks))
try:
conn = psycopg2.connect(
dbname="vectordb",
user="vectorapi",
password="vectorapipass",
host="localhost",  # Optional, defaults to localhost
port="5432"  # Optional, defaults to 5432
)
print("Connection successful!")
except Exception as e:
print(f"Error connecting to database: {e}")
Error Message and Stack Trace (if applicable)
sambasiva@USLDMJTG24:~/dev/fastapi-template$ /bin/python3 /home/sambasiva/dev/fastapi-template/src/api/embedding_transformer/test.py
Traceback (most recent call last):
File "/home/sambasiva/dev/fastapi-template/src/api/embedding_transformer/test.py", line 25, in
db=PGVector.from_documents(embedding=embeddings,documents=chunks, collection_name=collection_name,connection=connection,)
File "/home/sambasiva/.local/lib/python3.10/site-packages/langchain_postgres/vectorstores.py", line 1107, in from_documents
return cls.from_texts(
File "/home/sambasiva/.local/lib/python3.10/site-packages/langchain_postgres/vectorstores.py", line 975, in from_texts
return cls.__from(
File "/home/sambasiva/.local/lib/python3.10/site-packages/langchain_postgres/vectorstores.py", line 438, in __from
store = cls(
File "/home/sambasiva/.local/lib/python3.10/site-packages/langchain_postgres/vectorstores.py", line 308, in init
self.post_init()
File "/home/sambasiva/.local/lib/python3.10/site-packages/langchain_postgres/vectorstores.py", line 317, in post_init
EmbeddingStore, CollectionStore = _get_embedding_collection_store(
File "/home/sambasiva/.local/lib/python3.10/site-packages/langchain_postgres/vectorstores.py", line 91, in _get_embedding_collection_store
from pgvector.sqlalchemy import Vector  # type: ignore
ModuleNotFoundError: No module named 'pgvector.sqlalchemy'; 'pgvector' is not a package
Description
I am trying to use the langchain library to perform a RAG application but while using the pgvector as a database i encountered th issue with the langchain package langchain_postgres/vectorstores.py
in which it is giving the error of module not found and that pgvector is not a package
System Info
langchain==0.1.19
langchain-community==0.0.38
langchain-core==0.1.52
langchain-google-genai==1.0.3
langchain-google-vertexai==1.0.3
langchain-postgres==0.0.4
langchain-text-splitters==0.0.1
platform windows
python version= 3.11

pip install pgvector should fix it

thank you, maximeperrindev, I tried the same, still getting the same error.

I am having same issue... it was working fine and then suddenly this showing up.
ModuleNotFoundError                       Traceback (most recent call last)
Cell In[23], line 1
----> 1 db = PGVector.from_documents(
2     embedding=embeddings,
3     documents=top_texts,
4     collection_name=collection_name,
5     connection=connection,
6     use_jsonb=True,
7 )
File d:\langchaindemo\lc2\env\Lib\site-packages\langchain_postgres\vectorstores.py:1731, in PGVector.from_documents(cls, documents, embedding, connection, collection_name, distance_strategy, ids, pre_delete_collection, use_jsonb, **kwargs)
[1728](file:///D:/langchaindemo/lc2/env/Lib/site-packages/langchain_postgres/vectorstores.py:1728) texts = [d.page_content for d in documents]
[1729](file:///D:/langchaindemo/lc2/env/Lib/site-packages/langchain_postgres/vectorstores.py:1729) metadatas = [d.metadata for d in documents]
-> [1731](file:///D:/langchaindemo/lc2/env/Lib/site-packages/langchain_postgres/vectorstores.py:1731) return cls.from_texts(
[1732](file:///D:/langchaindemo/lc2/env/Lib/site-packages/langchain_postgres/vectorstores.py:1732)     texts=texts,
[1733](file:///D:/langchaindemo/lc2/env/Lib/site-packages/langchain_postgres/vectorstores.py:1733)     pre_delete_collection=pre_delete_collection,
[1734](file:///D:/langchaindemo/lc2/env/Lib/site-packages/langchain_postgres/vectorstores.py:1734)     embedding=embedding,
[1735](file:///D:/langchaindemo/lc2/env/Lib/site-packages/langchain_postgres/vectorstores.py:1735)     distance_strategy=distance_strategy,
[1736](file:///D:/langchaindemo/lc2/env/Lib/site-packages/langchain_postgres/vectorstores.py:1736)     metadatas=metadatas,
[1737](file:///D:/langchaindemo/lc2/env/Lib/site-packages/langchain_postgres/vectorstores.py:1737)     connection=connection,
[1738](file:///D:/langchaindemo/lc2/env/Lib/site-packages/langchain_postgres/vectorstores.py:1738)     ids=ids,
[1739](file:///D:/langchaindemo/lc2/env/Lib/site-packages/langchain_postgres/vectorstores.py:1739)     collection_name=collection_name,
[1740](file:///D:/langchaindemo/lc2/env/Lib/site-packages/langchain_postgres/vectorstores.py:1740)     use_jsonb=use_jsonb,
[1741](file:///D:/langchaindemo/lc2/env/Lib/site-packages/langchain_postgres/vectorstores.py:1741)     **kwargs,
...
--> [106](file:///D:/langchaindemo/lc2/env/Lib/site-packages/langchain_postgres/vectorstores.py:106) from pgvector.sqlalchemy import Vector  # type: ignore
[108](file:///D:/langchaindemo/lc2/env/Lib/site-packages/langchain_postgres/vectorstores.py:108) class CollectionStore(Base):
[109](file:///D:/langchaindemo/lc2/env/Lib/site-packages/langchain_postgres/vectorstores.py:109)     """Collection store."""
ModuleNotFoundError: No module named 'pgvector.sqlalchemy'; 'pgvector' is not a package

I figured out the solution for the same problem I have encountered.
This problem arises if you have different versions of python installed on your computer. please check the interpreter version and the environment version.
If both didn't match, try "pip install pgvector" with the interpreter version.
Example:  C:/Python312/python.exe -m pip install pgvector


Fix snapshot argument for componentDidMount - Issue #985

Fixes #985

Coverage increased (+0.09%) to 95.36% when pulling 0ef2b2aef81e0a29300fcb78656279643e8ae288 on fix/snapshot-issue-985 into c57556adee0a73c9ecad17605a1c95ccae038a72 on master.

Weird other observation -- coverage seemed to have went way down... I haven't dug in but is there something up there that you can see?
https://github.com/FormidableLabs/radium/pull/1013#issuecomment-445480453

Coverage decreased (-53.6%) to 41.667%

@ryan-roemer I'm hoping it's because I pushed in an it.only on accident. We'll find out soon! otherwise i have no idea how it would jump that much.


Remove unneccesarily specific postinstall

When npm runs a script, it does it with a $PATH that includes the local node_modues/.bin or whatever other path it has used to install the binaries. There is no need to specify it.

thanks


AudioLineProvider tries to run last line of dialogue before having it load

What is the current behavior?
The AudioLineProvider is loading dialogue from a script. Due to some boolean checks the first dialogue to be spoken is the last line of dialogue that is loaded. In checking stack trace, the DialogueRunner attempts to read the last line of dialogue before it has fully loaded (presumably due to a race condition).
Please provide the steps to reproduce, and if possible a minimal demo of the problem:
Create a YarnProject with a single script. This Project needs to have multiple lines, with a boolean that makes you skip to the last line. This will make it so Yarn is trying to speak the last line that is being loaded.
What is the expected behavior?
I expect the AssetLoadComplete function to remove a pendingLoadOperation from the dictionary AFTER it has been added to the completedLoadOperations
Please tell us about your environment:

Yarn Spinner Version: 2.2.4
Unity Version: 2021.3.13f1

Other information
Original Code Snippet

Fixed Version

EDIT/UPDATE:
With further testing on this issue we have noticed that the bug is present when moving to another node outside of the starting node. When moving to another node it seems that the DialogueRunner handles the concurrent process of starting the dialogue and loading the resources differently than when starting a dialogue from the start.
This can be better tested and observed if using any script with multiple nodes. This requires use of the AudioLineProvider and VoiceOverView.

Fixed in 8089131e682f15d9dd1b073cc55ca817d0125e28


Really small icons on Explore

Text and number icons are way smaller than time icons
How to reproduce the bug

Go to Explore
You'll see that text and number icons are way smaller than time icons

Expected results
Both text and number icons are adjusted to match the time icon size.
Actual results
Text and number icons are unreadable.
Screenshots

Environment

browser type and version: Chrome
superset version: master

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Add any other context about the problem here.

@michael-s-molina were you able to repro this locally?

@michael-s-molina This should also change the underlying issue from the svgr bump: https://github.com/apache/superset/pull/24747


tools/mksymtab.sh: Support multiple additional symbols` file

Summary
Add support for multiple additional symbols` file
Impact
Makefiles calling mksymtab.sh, like apps/Makefile(selftest OK).
Forward compatible.
Testing

Selftest

  $ cat basic.txt
  test_a
  test_b
  test_c

  $ cat math.txt
  acosf
  asinf
  atan2f
  ceilf
  cosf
  expf

  $ ./mksymtab.sh ./ g_TEST basic.txt
  #include <nuttx/compiler.h>
  #include <nuttx/symtab.h>

  extern void *test_a;
  extern void *test_b;
  extern void *test_c;

  const struct symtab_s g_TEST_exports[] =
  {
    {"test_a", &test_a},
    {"test_b", &test_b},
    {"test_c", &test_c},
  };

  const int g_TEST_nexports = sizeof(g_TEST_exports) / sizeof(struct symtab_s);

  $ ./mksymtab.sh ./ g_TEST basic.txt math.txt
  #include <nuttx/compiler.h>
  #include <nuttx/symtab.h>

  extern void *acosf;
  extern void *asinf;
  extern void *atan2f;
  extern void *ceilf;
  extern void *cosf;
  extern void *expf;
  extern void *test_a;
  extern void *test_b;
  extern void *test_c;

  const struct symtab_s g_TEST_exports[] =
  {
    {"acosf", &acosf},
    {"asinf", &asinf},
    {"atan2f", &atan2f},
    {"ceilf", &ceilf},
    {"cosf", &cosf},
    {"expf", &expf},
    {"test_a", &test_a},
    {"test_b", &test_b},
    {"test_c", &test_c},
  };

  const int g_TEST_nexports = sizeof(g_TEST_exports) / sizeof(struct symtab_s);

Github CI

[Experimental Bot, please feedback here]
The PR, as presented, is missing some key information to meet NuttX requirements. Here's a breakdown:
Strengths:

Clear Summary: The summary adequately explains what the change is and its purpose.
Impact:  The impact section addresses most points, especially compatibility.
Testing: Includes example usage and mentions CI, which is good practice.

Areas for Improvement:

Impact - User:  While the change is forward compatible, will users need to modify existing Makefiles to benefit from the new feature? Be specific.
Impact - Build: The PR mentions Makefiles are impacted, but doesn't elaborate on how the build process might change for developers.
Testing - Insufficient Detail:

Build Host(s):  List the specific operating systems, architectures, and compiler versions used for testing.
Target(s): Specify the architectures and boards this was tested on (both real hardware and simulators).
Logs: The provided "logs" are example outputs of the script, not actual build/test logs. Include snippets demonstrating successful builds and tests on your listed targets before and after the change.

Recommendations:

Expand on Impact: Provide specifics about build process changes and potential user adjustments.
Detailed Testing Information: List all environments and provide actual build/test log snippets showing the change's effect.

By addressing these points, the PR will be much stronger and better adhere to NuttX's requirements.


[nodejs4.3] handler defaults to "_apex_index.handle" and can't be changed

I'm trying to change the handler in the function.json for a nodejs4.3 function but can't do so. Despite the following line:
"handler": "index.handle"
the handler in AWS appears:
_apex_index.handle
Am I missing something in the config?
OS: Mac OSX Yosemite 10.10.5
Apex version: 0.10.3

The last FAQ sort of covers what that file is: http://apex.run/#faq. Gist of it is we have an env-injecting wrapper script which delegates to whatever your handler is: https://github.com/apex/apex/blob/master/plugins/nodejs/nodejs.go#L36 but it will display _apex_index.handle in Lambda's UI

@murtyjones I'm closing this out as I believe we've answered your question. Feel free to respond if you need some more clarity.


ssl error on scaffold project

deno run -A -r https://fresh.deno.dev deno-fresh-demo

error sending request for url (https://fresh.deno.dev/): error trying to connect: tls handshake eof

also, look like the website has an SSL problem, or maybe it's down.

I can not reproduce this. Where are you connecting from?

It's fixed now.


API: add support for giving out tor test targets and psiphon config

Currently the test targets for tor and the psiphon config is given out to probes via the probe-services instance. Once we have authentication inside of the API we should implement support for giving out these targets directly in the next gen API so we can discontinue that host.
The code for the Psiphon config is pretty simple, it just reads a file from disk (https://github.com/ooni/sysadmin/blob/992c3c0539304fde0b4459456b0050bce2b3103a/ansible/group_vars/psk_orchestra_prod/vars.yml#L18) and serves it: https://github.com/ooni/orchestra/blob/master/orchestrate/orchestrate/handler/test_lists.go#L200.
The code for the Tor configuration is a little bit more tricky as it also requires communication with BridgeDB and should merge those results with the static configuration provisioned via ooni/sysadmin, see: https://github.com/ooni/orchestra/blob/master/orchestrate/orchestrate/handler/test_lists.go#L257 & https://github.com/ooni/sysadmin/blob/master/ansible/roles/probe-services/templates/tor_targets.json

This has been merged. Closing.


[Bug]: Typescript class properties not appears to be tested

Version
28.1.0
Steps to reproduce
Create a class and declare some properties. This class will not have methods. Test a class instance and jest coverage will say to you that class properties haven't been tested.
Expected behavior
A test about class instance should
Actual behavior
Class properties aren't tested by jest coverage.
Additional context
No response
Environment
System:
    OS: Windows 10 10.0.19042
    CPU: (4) x64 Intel(R) Core(TM) i5-6300U CPU @ 2.40GHz
  Binaries:
    Node: 16.14.1 - C:\Local Programs\node-v16.14.1-win-x64\node.EXE
    npm: 8.9.0 - C:\Local Programs\node-v16.14.1-win-x64\npm.CMD
  npmPackages:
    jest: ^28.1.0 => 28.1.0

Just tried a workaround from https://github.com/istanbuljs/istanbuljs/issues/547#issuecomment-613548955 with the default coverage provider. Works for me, coverage report is correct. Looks like the limitation originates in istanbuljs.


feat: bump crane-lib to v0.0.7

This updates the built-in kubernetes plugin to handle
metadata.managedFields as well as default RBAC (think default service
account) and the default CABundle.
These are resources that, by default, wouldn't need to be migrated.
Fixes #85

/lgtm


Revert "Fix the code coverage."

Reverts jcasbin/shiro-casbin#15
The code coverage is still problematic.
Please see the following screenshot.

@shy1st plz directly rewrite the git history to replace the faulty commit at: https://github.com/jcasbin/shiro-casbin/pull/15, no need to PR.


Bump version number

We're at 1.12, yet mods source still says 1.10...

It shouldn't be hard to make a workflow commit the version in the mod.json files when a release is published

Given how rare we have a minor bump, I haven't seen the need to yet but I won't complain about someone making a PR to fix it either :P


Is this a bug?

React Native Environment Info:
System:
OS: macOS 10.14.6
CPU: (4) x64 Intel(R) Core(TM) i3-8100B CPU @ 3.60GHz
Memory: 40.11 MB / 8.00 GB
Shell: 5.3 - /bin/zsh
Binaries:
Node: 12.3.1 - /usr/local/bin/node
Yarn: 1.15.2 - /usr/local/bin/yarn
npm: 6.9.0 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 13.0, DriverKit 19.0, macOS 10.15, tvOS 13.0, watchOS 6.0
IDEs:
Xcode: 11.0/11A420a - /usr/bin/xcodebuild
npmPackages:
react: 16.8.3 => 16.8.3
react-native: 0.59.9 => 0.59.9
npmGlobalPackages:
react-native-cli: 2.0.1
react-native-vector-icons: 6.6.0
is my code :

UI display:

but, I hope the numbers are followed by words.
help me   ths

Hello, can you explain in a little more detail what the issue is?

Hello, can you explain in a little more detail what the issue is?

hi  The code is very simple, just a text component contains a piece of text, but the UI display is a problem,Just wrap the Chinese in front and automatically wrap it. I hope the numbers are followed by words.


v9: Unable to get permission key for add_files (0)

I'm testing a v8 package for v9 where I upload file(s) to a File Manager folder and I get this exception:
Exception Occurred: /srv/www/htdocs/c9/concrete/src/Permission/Checker.php:70 Unable to get permission key for add_files (0)
Has that permission key gone in v9? Or been replaced? What do I do in v9 to check permissions if I can upload to the FM?

getClientSize() has been deprecated in Symfony 4.1 and removed in 5.0. You should use getSize() instead.

getSize() is not in the File or UploadedFile but it worked

File extends \SplFileInfo which has the method, https://www.php.net/manual/en/splfileinfo.getsize.php

Ah, it extends the PHP class, while I was looking for it in Symfony... Thank you.

Yes, this is due to the laravel container changing how it works in the more recent version that we've included in version 9. More info about these types of issues available here:
https://documentation.concretecms.org/tutorials/add-developers-get-your-add-ons-ready-concrete-cms-90


switch to ES2015 loose mode to fix issue with ie9 and 10

This has been done on the react-grid-layout to fix a similar issue with "this" being unbounded in IE 9 and 10. Error was still appearing to come from the resizable library, I made change to loose mode and that fixed the issue.

:+1:


vips: Improve GIF and PNG support

Description of changes
Improves support for GIF and PNG files in vips.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

I can confirm that this solves issues I've been seeing when running lemmy-ui: Input buffer contains unsupported image format.


EDGENT_243 console legend wider

Added some extra space around the legend box in the console due to the longer package names after changing from apache.quarks to org.apache.edgent.

wondering... did you consider omitting the "org.apache.edgent" or such?  Probably 99% of all oplets will be edgent oplets so the prefix is really just undesired noise imo.
Related, an oplet with a long package name (e.g., TextFileReader; can see with scripts/connectors/file sample) runs off the right edge of the box; and there isn't a right edge drawn on my mac -- that's w/o this PR's changes.

That is certainly an option.  My thoughts were that if someone had a package that was not org.apache.edgent that I the legend box would need to accommodate that length anyway.
If folks think that it is more desirable to remove org.apache.edgent then it can be done.
Cheers,
Susan

On Aug 30, 2016, at 5:55 AM, Dale LaBossiere<EMAIL_ADDRESS>wrote:
wondering... did you consider omitting the "org.apache.edgent" or such? Probably 99% of all oplets will be edgent oplets so the prefix is really just undesired noise imo.
Related, an oplet with a long package name (e.g., TextFileReader; can see with scripts/connectors/file sample) runs off the right edge of the box; and there isn't a right edge drawn on my mac -- that's w/o this PR's changes.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/apache/incubator-edgent/pull/183#issuecomment-243429213, or mute the thread https://github.com/notifications/unsubscribe-auth/AQemx1cEoTtJ5fd0ZgtAOSvXeUgECOwNks5qlChcgaJpZM4Jv4u4.


Add Py.setattr method

PyAny exposes a setattr method, but Py<T> currently doesn't.
TODO:

[x] add Py::setattr method
[x] add an entry in CHANGELOG.md
[ ] add the corresponding test

It looks like there are other methods missing from Py. Should they get the same API in general?

Should they get the same API in general?

Probably, yes, though I hadn't been rushing to add to Py because I'm not yet sure how much needs to change with #1056.


Allow user to select preferred recovery channel in the user portal

Is your suggestion related to experience? Please describe.
Currently, Identity Server is capable of supporting multiple recovery channels such as email, SMS, etc. However, currently, there is no way for a user to say which of the recovery channels is his/her preferred one.
Describe the improvement
Allow users to set the preferred recovery channel from the user portal (store this as a user's claim or attribute) and use it in recovery APIs.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Fix code scanning alert - Exception text reinterpreted as HTML

Tracking issue for:

[ ] https://github.com/erasmosoares/sample-node/security/code-scanning/7

Fixed