Control net not working on fast SD A1111

Everytime I try to use controlnet on A1111 I get the following error

I've updated the notebook to latest, also receive an error while trying to update control net

when you run the controlnet cell, it updates automatically, if you update it inside gradio, you'll need to stop the last cell an run it again

I have kind of the same errors, as I write, controlnet is updated to v1.1.230, nothings seems to work, reference triggers an error, and other preprocessors (like canny, open pose..) generate a black picture.
 Traceback (most recent call last):
      File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/modules/call_queue.py", line 55, in f
        res = list(func(*args, **kwargs))
      File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/modules/call_queue.py", line 35, in f
        res = func(*args, **kwargs)
      File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/modules/txt2img.py", line 57, in txt2img
        processed = processing.process_images(p)
      File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/modules/processing.py", line 620, in process_images
        res = process_images_inner(p)
      File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/extensions/sd-webui-controlnet/scripts/batch_hijack.py", line 42, in processing_process_images_hijack
        return getattr(processing, '__controlnet_original_process_images_inner')(p, *args, **kwargs)
      File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/modules/processing.py", line 739, in process_images_inner
        samples_ddim = p.sample(conditioning=p.c, unconditional_conditioning=p.uc, seeds=p.seeds, subseeds=p.subseeds, subseed_strength=p.subseed_strength, prompts=p.prompts)
      File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/extensions/sd-webui-controlnet/scripts/hook.py", line 350, in process_sample
        return process.sample_before_CN_hack(*args, **kwargs)
      File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/modules/processing.py", line 992, in sample
        samples = self.sampler.sample(self, x, conditioning, unconditional_conditioning, image_conditioning=self.txt2img_image_conditioning(x))
      File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/modules/sd_samplers_kdiffusion.py", line 439, in sample
        samples = self.launch_sampling(steps, lambda: self.func(self.model_wrap_cfg, x, extra_args={
      File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/modules/sd_samplers_kdiffusion.py", line 278, in launch_sampling
        return func()
      File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/modules/sd_samplers_kdiffusion.py", line 439, in <lambda>
        samples = self.launch_sampling(steps, lambda: self.func(self.model_wrap_cfg, x, extra_args={
      File "/usr/local/lib/python3.10/dist-packages/torch/utils/_contextlib.py", line 115, in decorate_context
        return func(*args, **kwargs)
      File "/content/gdrive/MyDrive/sd/stablediffusion/src/k-diffusion/k_diffusion/sampling.py", line 145, in sample_euler_ancestral
        denoised = model(x, sigmas[i] * s_in, **extra_args)
      File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1501, in _call_impl
        return forward_call(*args, **kwargs)
      File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/modules/sd_samplers_kdiffusion.py", line 177, in forward
        x_out[a:b] = self.inner_model(x_in[a:b], sigma_in[a:b], cond=make_condition_dict(c_crossattn, image_cond_in[a:b]))
      File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1501, in _call_impl
        return forward_call(*args, **kwargs)
      File "/content/gdrive/MyDrive/sd/stablediffusion/src/k-diffusion/k_diffusion/external.py", line 112, in forward
        eps = self.get_eps(input * c_in, self.sigma_to_t(sigma), **kwargs)
      File "/content/gdrive/MyDrive/sd/stablediffusion/src/k-diffusion/k_diffusion/external.py", line 138, in get_eps
        return self.inner_model.apply_model(*args, **kwargs)
      File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/modules/sd_hijack_utils.py", line 17, in <lambda>
        setattr(resolved_obj, func_path[-1], lambda *args, **kwargs: self(*args, **kwargs))
      File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/modules/sd_hijack_utils.py", line 28, in __call__
        return self.__orig_func(*args, **kwargs)
      File "/content/gdrive/MyDrive/sd/stablediffusion/ldm/models/diffusion/ddpm.py", line 858, in apply_model
        x_recon = self.model(x_noisy, t, **cond)
      File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1501, in _call_impl
        return forward_call(*args, **kwargs)
      File "/content/gdrive/MyDrive/sd/stablediffusion/ldm/models/diffusion/ddpm.py", line 1329, in forward
        out = self.diffusion_model(x, t, context=cc)
      File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1501, in _call_impl
        return forward_call(*args, **kwargs)
      File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/extensions/sd-webui-controlnet/scripts/hook.py", line 661, in forward_webui
        return forward(*args, **kwargs)
      File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/extensions/sd-webui-controlnet/scripts/hook.py", line 423, in forward
        param.control_model.to(devices.get_device_for("controlnet"))
    AttributeError: 'NoneType' object has no attribute 'to'


This is really a release update request

4.8 in Maven has a transitive vulnerability (on h2)

is it possible to get a release without the vulnerability ?

Greetings!
Thank you for reporting. We will definitely update, but not immediately because:

H2 is only a test dependency and not part of the JSQLParser package
H2-2.2.224 depends on JDK 11 while we still maintain JDK 8 compatibility

We are discussing right now how/when to raise compatibility to JDK 11.

Greetings.
@wumpz just has released 4.9 as last JDK8 compatible version.
Snapshot 4.10 has been updated to JDK11 including Test dependency to H2 2.2.224.


[BUG] ValueError when computing correlation matrix due to non-numeric data

When trying to compute the correlation matrix of the housing dataset, I encounter a ValueError. The problem occurs because there are non-numeric values in the dataset.

After pandas version 2.0 now you need to add numeric_only=True in the bracket  to avoid the issue
corr_matrix = housing.corr(numeric_only=True)


Inconsistent datasets name case in UI

Describe the bug
The DataHub UI shows a (random?) mix of uppercase and lowercase dataset names for the same database/schema.
See the attached screenshot where Snowflake has only 1 SNOWPIPE.PUBLIC database/schema but DataHub shows 2 of those. The tables in this schema are split between those two.
To Reproduce
Steps to reproduce the behavior:

Ingest a Snowflake source (tested with convert_urns_to_lowercase: true)
Snowflake dataset are split between uppercase and lowercase in the UI

Expected behavior
The DataHub UI should not split datasets between uppercase and lowercase in the UI if their Snowflake identifiers are not explicitely uppercase or lowercase.
Snowflake query:
select table_schema, count(*)
from snowpipe.information_schema.tables
where table_schema in ('PUBLIC', 'public')
group by table_schema;

returns
TABLE_SCHEMA	COUNT(*)
PUBLIC	21

(21 = 13+8 in the screenshot...)
Screenshots

Desktop (please complete the following information):

OS: MacOS
Browser: Firefox
Version: DataHub v0.12.0

Seeing the same issue with Postgres sources, even more confusing where instance, database and schema are all lowercase but show in separate folders:

@remisalmon I have a hypothesis for this, related to https://github.com/datahub-project/datahub/pull/9227
If you re-run the snowflake/postgres ingestion, does this problem appear to go away?

@remisalmon I have a hypothesis for this, related to #9227
If you re-run the snowflake/postgres ingestion, does this problem appear to go away?

Hi @hsheth2 thanks for taking a look! Yes this does go away when I re-run the ingestion (even with stateful ingestion enabled):

This is with:
> cat .env
DATAHUB_VERSION="v0.11.0"
> datahub version
DataHub CLI version: <IP_ADDRESS>
Python version: 3.11.6 (main, Oct  2 2023, 22:00:51) [Clang 14.0.3 (clang-14<IP_ADDRESS>.1)]

Hi! We have the same issue!
DataHub CLI version: <IP_ADDRESS>
Python version: 3.9.16 (main, Sep  8 2023, 00:00:00)
But when we re run the ingestión the issue is not solved, any suggestion?  Thanks!

We are also seeing the same issue on Snowflake, which doesn't disappear when rerunning the ingestion.
Datahub version: <IP_ADDRESS>

@JoakimNil that's surprising! Can we get some more details about your setup - are you using quickstart or a helm deployment? Have you tweaked any settings e.g. GMS replicas, async ingest, standalone mae/mce consumers?

@hsheth2 We're using quickstart, with all default settings. The only thing that's changed is adding the Snowflake source, with this config:
source:
    type: snowflake
    config:
        account_id: [REMOVED]
        warehouse: COMPUTE_WH
        username: datahub
        password: '${SNOWFLAKE_DATAHUB_PASSWORD}'
        incremental_lineage: true
        profiling:
            enabled: false
        stateful_ingestion:
            enabled: true

I will send you the resulting JSON in a DM in slack.

@hsheth2 hi, is this fix duplication issues with tableau, Postgres and etc. platforms?


Wizard: Update order of releases on the Image output step

Fixes https://github.com/RedHatInsights/image-builder-frontend/issues/909. Fixes https://github.com/RedHatInsights/image-builder-frontend/issues/918.
This updates the order of the releases on the Image output step to sort from newest to oldest. The RELEASES Object was converted to Map which remembers insertion order.
The color of the Show options for further development of RHEL option in the Release dropdown select was also changed to blue.

/retest

/retest

/retest

/retest


[BUG] Not able to build proto file into descriptor pool

Describe the bug
On running the export_pytorch_ensemble method with model, workflow and sparse_features_max, I am getting an error about not being able to build proto file or invalid proto descriptor, any idea on how to fix this?
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
/tmp/ipykernel_10065/2268925229.py in <module>
----> 1 from nvtabular.inference.triton import export_pytorch_ensemble
      2 export_pytorch_ensemble(
      3     model,
      4     workflow,
      5     sparse_max=sparse_features_max,

/opt/conda/envs/nvtabular_dev_11.2/lib/python3.8/site-packages/nvtabular/inference/triton/__init__.py in <module>
     25
     26 from nvtabular.dispatch import _is_list_dtype, _is_string_dtype, _make_df  # noqa
---> 27 from nvtabular.inference.triton.ensemble import (  # noqa
     28     export_hugectr_ensemble,
     29     export_pytorch_ensemble,

/opt/conda/envs/nvtabular_dev_11.2/lib/python3.8/site-packages/nvtabular/inference/triton/ensemble.py in <module>
     27 from google.protobuf import text_format  # noqa
     28
---> 29 import nvtabular.inference.triton.model_config_pb2 as model_config  # noqa
     30 from nvtabular.dispatch import _is_list_dtype, _is_string_dtype  # noqa
     31 from nvtabular.graph.node import iter_nodes  # noqa

/opt/conda/envs/nvtabular_dev_11.2/lib/python3.8/site-packages/nvtabular/inference/triton/model_config_pb2.py in <module>
     15
     16
---> 17 DESCRIPTOR = _descriptor.FileDescriptor(
     18   name='model_config.proto',
     19   package='inference',

/opt/conda/envs/nvtabular_dev_11.2/lib/python3.8/site-packages/google/protobuf/descriptor.py in __new__(cls, name, package, options, serialized_options, serialized_pb, dependencies, public_dependencies, syntax, pool, create_key)
    980           raise RuntimeError('Please link in cpp generated lib for %s' % (name))
    981       elif serialized_pb:
--> 982         return _message.default_pool.AddSerializedFile(serialized_pb)
    983       else:
    984         return super(FileDescriptor, cls).__new__(cls)

TypeError: Couldn't build proto file into descriptor pool!
Invalid proto descriptor for file "model_config.proto":
  model_config.proto: A file with this name is already in the pool.

Steps/Code to reproduce bug
import nvtabular as nvt

# define data path about where to get our data
INPUT_DATA_DIR = os.environ.get("INPUT_DATA_DIR", "workspace/data/")
workflow_path = os.path.join(INPUT_DATA_DIR, 'workflow_etl')
workflow = nvt.Workflow.load(workflow_path)

# dictionary representing max sequence length for the sequential (list) columns
sparse_features_max = {
    fname: sequence_length
    for fname in x_cat_names + x_cont_names
}

sparse_features_max

from nvtabular.inference.triton import export_pytorch_ensemble
export_pytorch_ensemble(
    model,
    workflow,
    sparse_max=sparse_features_max,
    name= "t4r_pytorch",
    model_path= "workspace/models",
    label_columns =[],
)

Expected behavior
Expected behaviour is to export the proc workflow and model in the format required by Triton Inference Server, by using the NVTabular’s export_pytorch_ensemble() function, but the error as discussed above occurs in place.
Environment details (please complete the following information):

Environment location: gcp
Method of NVTabular install: conda nvt environment as suggested on NVTabular documentation.

@Ahanmr which notebook is that? Looks like this is [Transformers4Rec GH] notebook(https://github.com/NVIDIA-Merlin/Transformers4Rec), can you please open the issue there? We also need to know about your environment. Are you using docker containers? if yes which one?
are you using your own dataset or the data set given in the example notebook?

@Ahanmr did you solve your issue. if yes, can we close this one?


KAFKA-8220: Avoid kicking out members through rebalance timeout

To make consumer group members more persist, we want to avoid kick-out unjoined members through rebalance timeout. The only exception is when leader fails to join, because we will at risk of no assignment computed during sync stage. The choice will be kicking off non-responsive leader and choose a new leader if possible.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Retest this please

@guozhangwang @hachikuji when you got time :)

@rajinisivaram Thanks a lot for the review! Yea, pinging @hachikuji @guozhangwang again since we got your green light lol.

Retest this please

Retest this please


[mp-units] depends on fmt<=8.1.1, but pulls in fmt>9.0.0 -> missing header

Describe the bug
The current mp-units port pulls in the latest fmt port, which is missing the header fmt/locale.h, but units/format.h includes that header.
mp-units 0.7.0 depends on fmt<=8.1.1.
Environment

OS: Linux
Compiler: gcc 11.3.0

To Reproduce
Steps to reproduce the behavior:

./vcpkg install mp-units
#include <units/format.h>
fatal error: fmt/locale.h: No such file or directory

Expected behavior
Pin fmt version to 8.1.1 for mp-units 0.7.0

@Neumann-A Even better, thanks!

mp-units have update to 0.8.0 #32028, this issue should be fixed.


Clean package.json

Remove unused (In open source plugins) modules

Me,
Thanks!

There are compilation instructions in readme.md
Bot using own command to compile, make-zaebis, it is uses webpack with all needed setting under the hood
Feel free to ask questions about compiling/running, i will add answers to readme.md

I don't get this, sorry. If one needs a make-zaebis, add it as dev dependency in this project package.json and simply add build section to script. One does not need to install package globally anynomre. Will it work as intended if added to package.json? Sorry for spoiling a topic of this issue, I wanted to help :)

@peterblazejewicz, thank you, now these commands placed in package.json, and make-zaebis is added as dev-depedencity (https://github.com/Creeplays/Ayzek/commit/60fff1e2b06dc35fb313420a92dc7d4902a58f4a)

I can help with cleaning a portion of these...Clean package.json #11

@jennylia, then do it 😄


Unit testing for fact.js

This pull request includes a

[ ] Bug fix
[x] New feature
[x] Testing
[ ] Translation

The following changes were made

Added __ tests __ folder with subfolder unit
Added fact.test.js into unit subfolder
Exported functions in fact.js
Added tests in fact.test.js

Comments

Only tested existing functions
Excluded testing for error handling as there weren't many error handlers
Noticed error handling needed for the function getRandomApiNum in fact.js

When number is not in range of min and max, undefined is returned instead of the number. For example, {min: 2010, max: 2011} returns undefined rather than the number itself. "undefined is an unremarkable number." This only occurs with types date and trivia.
When min and max are invalid values, undefined is also returned. For example, {min: 10, max: -20} returns undefined instead of an error message. This occurs with all 4 types (date, trivia, math, year).

#5

@silasburger @maxnawa31 @Ronihe do one of you want to take a first pass at this?

Let us know if there's any way for us to make it easier for reviewers! :)

Hey @kathyn262 - sorry for the delay. i'll take the lead on this review next week!

@mmmaaatttttt  @kathyn262  and I have completed all the suggested changes from above. We're ready for a review. Thank you!

@mmmaaatttttt, @kathyn262 and I have completed the suggested updates. 🤞

we also changed the file inputs for reader_norm and reader_manual in data.js it was pointing to a wrong path earlier


Update SQLite to 3.43.2 + cherry-picked changeset grouping enhancement

Update to Version 3.43.2
Addition changeset cherry-picked from master

Fix a problem with sqlite3changegroup_schema() and patchsets.
Add the sqlite3changegroup_schema() API. To allow changegroup objects…
Fix a problem with the changes on this branch and tables that use an …
Add missing source code comments and fix other issues with the new co…
Add tests for the sqlite3changegroup_schema() API.
Add the sqlite3changegroup_schema() API. To allow changegroups to han…
Allow a session object to generate a changeset, even if columns were …

Change group can group data changeset across schema changes
This is an issue encountered by Local Sync

Some data was added to a table and txn was saved.
Schema change causes new columns to be added to the table with data in the previous txn.
Some more data is added with additional columns and txn is saved.
create changeset failed when trying to group changesets with different numbers of columns but the same table.

/azp run imodel-native

@mergifyio backport release/4.x


Fix grayed out paint icons

CanvasItem was grayed out because it's an abstract class, but a few places used its icon for other purposes.

Thanks!


Adding MCO generation external package for KMM Day1 support

This PR add am external package that will allow user to generate an MCO yaml file. When applied , the MCO will cause a kernel module to be replaced with a customer's image before NetworkManager service starts running ( basically Day1). Pre-requisite: at least one valid network interface should be running on the node without MCO intereference
The produced MCO defines 2 systemd services:

pull service: executes after network interface (NM) is configured, and is responsible for pull
kernel module image, based on DTK, into the node. Once successfull, it reboots the node
replace kernel module service: executes before NM is configured ( no network). In case the image is already
present on the node, it will remove the in-tree kernel module, and will replce it with the kernel module
stored in the DTK-based image

The input to function that produce MCO yaml is:

MCO name - the name that will be set into the MCO.name 2) MCP reference - reference to the MachineConfigPool, which will define which nodes that MCO will affect. 3) image name - DriverContainer image, that will contain the needed kerne module driver 4) the name of the kernel driver - which kernel driver to remove/insert

/cc @qbarrand

Part of https://github.com/rh-ecosystem-edge/kernel-module-management/issues/410

It generates MC (machine config), not MCO (machine config operator :))

It generates MC (machine config), not MCO (machine config operator :))

fixed

/lgtm

Follow-up in https://github.com/rh-ecosystem-edge/kernel-module-management/pull/477


Migrate to Melange

Fixes #14.

@davesnx is it ok to merge https://github.com/davesnx/reshowcase/pull/2 in your branch?


[INF2] remove neuron settings on cache hit for the folder

Description
Based on the current setup through model type and tensor parallel degree. It is not possible to find out the diff between LLAMA-7B TP2 FP16 vs LLAMA 13B TP2 FP16. Fallback to the inefficient way of reloading.

@tosterberg


Pasting from the clipboard into an editor no longer works, instead causing the cursor to jump to seemingly random places

Type: Bug
I'm noticing this behaviour in a Python file. When pressing ctrl+v to paste from the clipboard, my cursor instead jumps to a random position, and no text is pasted.
Working on a minimal reproduceable test case.
VS Code version: Code - Insiders 1.96.0-insider<PHONE_NUMBER>1dd25c6c5da64adadc0a09de91a9fe, 2024-11-22T09:56:24.579Z)
OS version: Windows_NT x64 10.0.22631
Modes:
Remote OS version: Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

System Info

Item
Value

CPUs
AMD Ryzen 7 PRO 7840U w/ Radeon 780M Graphics   (16 x 3294)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabledwebnn: disabled_off

Load (avg)
undefined

Memory (System)
62.72GB (47.13GB free)

Process Argv
--folder-uri=vscode-remote://wsl+ubuntu/home/dickson/source/leetcode-2024 --remote=wsl+ubuntu

Screen Reader
yes

VM
40%

Item
Value

Remote
WSL: ubuntu

OS
Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

CPUs
AMD Ryzen 7 PRO 7840U w/ Radeon 780M Graphics (16 x 0)

Memory (System)
30.72GB (29.07GB free)

VM
0%

Extensions (17)

Extension
Author (truncated)
Version

astro-vscode
ast
2.15.4

vscode-eslint
dba
3.0.10

dendron
den
0.124.0

dendron-paste-image
den
1.1.1

prettier-vscode
esb
11.0.0

debugpy
ms-
2024.12.0

python
ms-
2024.20.0

vscode-pylance
ms-
2024.11.3

rust-analyzer
rus
0.4.2193

remote-containers
ms-
0.391.0

remote-ssh
ms-
0.115.1

remote-ssh-edit
ms-
0.87.0

remote-wsl
ms-
0.88.5

vscode-remote-extensionpack
ms-
0.26.0

remote-explorer
ms-
0.4.3

remote-server
ms-
1.5.2

nvda-indent-nav-accessibility
Ton
1.0.0

This is not limited to pasting. Ctrl+a or using the "select all" from palet also doesn't select the entire file.
Something seems to have screwed up really badly in the latest insider release.

Latest version is bad, <IP_ADDRESS>41122 user installer
Version: 1.96.0-insider (user setup)
Commit:<PHONE_NUMBER>1dd25c6c5da64adadc0a09de91a9fe
Date: 2024-11-22T09:56:24.579Z
Electron: 32.2.5
ElectronBuildId: 10579404
Chromium: 128.0.6613.186
Node.js: 20.18.0
V8: 12.8.374.38-electron.0
OS: Windows_NT x64 10.0.22631

Last good version that doesn't have this bug is the one before that, <IP_ADDRESS>41121 user installer
Version: 1.96.0-insider (user setup)
Commit: 69acde7458f428f0e6869de8915c9dd995cdda1a
Date: 2024-11-21T05:04:38.064Z
Electron: 32.2.5
ElectronBuildId: 10579404
Chromium: 128.0.6613.186
Node.js: 20.18.0
V8: 12.8.374.38-electron.0
OS: Windows_NT x64 10.0.22631

This impact both Linux and Mac as well, can you please provide user installers for LKG for them as well?

Yes, it's especially vexing when you need to try and verify when a problem occurred -- I saw this the day it released, but couldn't step back, so wasn't confident reporting until I'd done a bunch of extension removal, etc. which took me days.  Had I been able to step back to the prior day's release, I would have had enough data to report this on the 22nd.
Inability to roll back to earlier insiders releases really is limiting users' ability to debug issues.  This "only ever forward" mindset is explicitly contrary to basic debugging/triage first principles.

To get back to the topic, I've seen the jump-instead-of-paste misbehavior occur for C/C++, Arduino(.INO), Markdown(.MD), Rust,
TOML, Lua, you name it.  I've yet to find a filetype that doesn't exhibit the behavior.  They all exhibit the same "fixed jump-points" misbehavior too, where no matter where you start from between two jump points, it always jumps to the "immediately prior jump-point".

Hi thank you for filing this issue, this seems to be related to the combination of the edit context and the screen reader mode being enabled. I will turn off the edit context by default on Insiders, investigate all the issues and turn it back on later.

Version: 1.96.0-insider
Commit: 2dd0bca3954d4c03c427d6b447205b68817bd000
Date: 2024-11-26T05:03:52.908Z
Electron: 32.2.5
ElectronBuildId: 10579404
Chromium: 128.0.6613.186
Node.js: 20.18.0
V8: 12.8.374.38-electron.0
OS: Darwin arm64 22.6.0
ProductName:		macOS
ProductVersion:		13.7.1
BuildVersion:		22H221
I can reproduce the issue on macOS.

Enable Voice Over. Set "editor.wordWrap": "on".
Type very long lines.
When clicking at the end of a wrapped long line, the cursor moves to the end of the file.

https://github.com/user-attachments/assets/055e6e53-983c-4526-adfd-bc9d28f90244

Hi @gwiede thank you for the message. The setting name to disable the edit context is: "editor.experimentalEditContextEnabled"
The edit context has been anyway turned off by default recently so this should no longer happen until it is turned on by default again

My investigation has revealed the pasting issue happens for the following reason:

When EditContext is enabled, for each view, a hidden div node and a hidden text are node is created
The purpose of the hidden text area is to receive focus so that text can be pasted inside of it. A dom node with EditContext set on it, can not receive an execCommandI('paste') event
So before doing the pasting, we focus the hidden text area and then trigger the paste
This sends a selection change event on the document, which we listen on. We listen to this event because we need to change the cursor position when the selection changes with a tertiary party like NVDA. This listener is only set when accessibility mode is turned on (hence why this bug does not happen without accessibility mode).
We then change the editor selection because there was a selection change event

There are in fact two selection change events, one happens when we focus the hidden text area, and the other happens when we focus back on the hidden div which has the edit context

The paste logic is written in such a way so that if the cursor selection changes during pasting, the paste operation is cancelled, which is what happens

There are several possibilities for how to fix this:

Bypass the usage of the text area dom node so that no selection change event is sent. From my understanding we will soon be exploring a new pasting API which could help us fix this issue, cc @mjbvz
Use a combination of booleans, in order to ignore the selection change events and not react upon them. This is a finicky and non-rigorous solution, because we can't be sure exactly of how many events will be emitted, and so sometimes maybe pasting will work, sometimes not

We could complement the above by analyzing the selection change event with greater detail to decide whether to ignore it. ie: is the src or target element the hidden text area?

We could remove the logic that cancels a paste operation on selection change (unknown consequences thus far)

I will think of other potential solutions

Hi everyone, I have found a fix for this with the PR https://github.com/microsoft/vscode/pull/234846. I will test the edit context some more with the accessibility mode and after fixing all the issues, I will enable the edit context once again. Can I ask the users in this thread to let me know if you see any other issues with the edit context when the accessibility mode is turned on? Thank you.


[MLLIB] Use TestingUtils to compare floating point values

What changes were proposed in this pull request?
Use org.apache.spark.mllib.util.TestingUtils object across MLLIB component to compare floating point values in tests.
How was this patch tested?
build/mvn test - existing tests against updated code.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Test build #4825 has started for PR 25191 at commit d0c2ae9.

Test build #4825 has finished for PR 25191 at commit d0c2ae9.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

addressed failed style checks reported by jenkins

Retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12974/
Test PASSed.

Test build #107859 has started for PR 25191 at commit a1cfc8c.

Test build #107859 has finished for PR 25191 at commit a1cfc8c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107859/
Test FAILed.

Retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12975/
Test PASSed.

Test build #107860 has started for PR 25191 at commit 49a7efb.

Test build #107860 has finished for PR 25191 at commit 49a7efb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107860/
Test PASSed.

@dongjoon-hyun it's eugenzyx

thank you

Thank you. It's assigned to you. :)

https://issues.apache.org/jira/browse/SPARK-28440


To manage the links

Awesome! I have a suggestion that whether should add a popup page to manage the links. As the links can only be added, it can only be edited local or in github.

This issue is a duplicate of #8


treewide: remove issue #56943 workarounds

checked with diffoscope+difflog and launching the programs
i have fixed that issue in my other gir PRs https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+author%3Aartturin+gobject-introspection+
Result of nixpkgs-review pr 208268 run on x86_64-linux 1

69 packages built:

adl
arandr
bada-bib
beets (beetsPackages.beets ,beetsPackages.beets-stable)
beets-unstable (beetsPackages.beets-unstable)
beetsPackages.alternatives
beetsPackages.beets-minimal
beetsPackages.copyartifacts
beetsPackages.extrafiles
blanket
bubblemail
cambalache
cozy
curtail
devede
dfeet
gaphor
giara
gnome-feeds
gnome-keysign
gnome-photos
gnome-secrets
gnome.accerciser
gnome.gnome-tweaks
gpodder
gtg
guake
hamster
input-remapper
kazam
kupfer
lutris
lutris-free
lutris-unwrapped
mcomix
meld
minigalaxy
mpdris2
onboard
pantheon.elementary-greeter
pantheon.elementary-session-settings
pantheon.switchboard-plug-a11y
pantheon.switchboard-plug-keyboard
pantheon.switchboard-with-plugs
pantheon.wingpanel-applications-menu
pantheon.wingpanel-with-indicators
pick-colour-picker
piper
pitivi
printrun
protonvpn-gui
python310Packages.dogtail
python39Packages.dogtail
rabbitvcs
rednotebook
sc-controller
solfege
sonata
sublime-music
terminator
trackma
trackma-curses
trackma-gtk
trackma-qt
virt-manager
wike
xfce.catfish
xsser
zim

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 208268 run on x86_64-linux 1

69 packages built:

adl
arandr
bada-bib
beets (beetsPackages.beets ,beetsPackages.beets-stable)
beets-unstable (beetsPackages.beets-unstable)
beetsPackages.alternatives
beetsPackages.beets-minimal
beetsPackages.copyartifacts
beetsPackages.extrafiles
blanket
bubblemail
cambalache
cozy
curtail
devede
dfeet
gaphor
giara
gnome-feeds
gnome-keysign
gnome-photos
gnome-secrets
gnome.accerciser
gnome.gnome-tweaks
gpodder
gtg
guake
hamster
input-remapper
kazam
kupfer
lutris
lutris-free
lutris-unwrapped
mcomix
meld
minigalaxy
mpdris2
onboard
pantheon.elementary-greeter
pantheon.elementary-session-settings
pantheon.switchboard-plug-a11y
pantheon.switchboard-plug-keyboard
pantheon.switchboard-with-plugs
pantheon.wingpanel-applications-menu
pantheon.wingpanel-with-indicators
pick-colour-picker
piper
pitivi
printrun
protonvpn-gui
python310Packages.dogtail
python39Packages.dogtail
rabbitvcs
rednotebook
sc-controller
solfege
sonata
sublime-music
terminator
trackma
trackma-curses
trackma-gtk
trackma-qt
virt-manager
wike
xfce.catfish
xsser
zim

Note that some of the other setup hooks (¿was it gdk-pixbuf, or the maybe the removed hicolor-icon-theme?) may suffer from the same problem. But if you checked the wrappers with diffoscope and there were no differences then it is probably fine.

https://github.com/NixOS/nixpkgs/pull/208537

https://github.com/NixOS/nixpkgs/pull/215715


toVNode doesn't parse SVGs correctly

toVNode doesn't account for namespace when parsing an SVG.  The resulting vnode is missing data.ns causing it not to get patched correctly, resulting with the SVG not rendering.
Here's a fiddle demonstrating this behavior: http://jsfiddle.net/michael_england/07pqtbfu/47/
Uncommenting the lines to manually add data.ns fixes this, but manually adding them shouldn't be required.  Seems like any fix should account for the SVG not being a root node.

I'm running into this problem when I attempt to inline svg into my app with snabbdom. manually updating the vnode.data.ns = 'http://www.w3.org/2000/svg' value in my code doesn't seem to solve the problem. Wondering if the code changed such that this workaround in the fiddle is no longer effective.
Help please? :(

This needs to be added to line 26 of tovnode.ts
const data = { attrs };
if (
    sel[0] === 's' && sel[1] === 'v' && sel[2] === 'g' &&
    (sel.length === 3 || sel[3] === '.' || sel[3] === '#')
  ) {
    addNS(data, children, sel)
  }
    return vnode(sel, data, children, undefined, node)

(Copied from the end of h)
I think that fixes it, but I can't check right now.

That does indeed fix it. @mightyiam OK for me to go ahead and submit a PR with this?

@mightyiam hello, do you have a plan to fix it? or can I submit a PR with @macarc 's code?😅

This needs to be added to line 26 of tovnode.ts
const data = { attrs };
if (
    sel[0] === 's' && sel[1] === 'v' && sel[2] === 'g' &&
    (sel.length === 3 || sel[3] === '.' || sel[3] === '#')
  ) {
    addNS(data, children, sel)
  }
    return vnode(sel, data, children, undefined, node)

(Copied from the end of h) I think that fixes it, but I can't check right now.

Ha, I forgot about this entirely. I'll make a PR shortly.


Add resources to Machine Learning

New popular data sets, techniques, research paper links are some of the suggested ways you can contribute.

I added some more popular datasets to work with for machine learning and also added some video resources for AI #246

#255 I added a popular book, tensorflow.js

@Vishu26 Merged ! Thanks !
@suleka96 Please look at the changes requested.

I noticed that there are no topics currently on Association Rule learning and Apriori Algorithm in this project.
I would like to add some references to this and some web links that will be useful. I will create a pull request soon to add this.

Will add some material related to reinforcement learning.

Hey @vicky002 , is this issue open I would like to contribute?

Hey @AryanNayak,
You can add to this.

@Byte7 can we add ml projects

i would like to contribute to this issue , can you let me know how i can solve it.

Hey @vicky002 , is this issue open I would like to contribute?

Hello,
I have my own notes and research in Machine Learning..
If you specify what type of resources you prefer most I would love to contribute in it.

hey , is this issue open ?
i want to start my journey of open source with this

I want to contribute to this issue


Timeout Warning & Build Instructions

prints to console timeout value, if previously set and causing the termination of the process
isolated Build instructions with its own heading.  In text mode, a link at the end of an introductory paragraph can be missed.

This is my second pull request, the previous one failed because I had not correctly run checkstyle.py after committing rather than before.

Thank you for your PR.  Happy with the changes themselves, however, would you be able to provide two separate commits:

One for the build instructions change.
Second one for the timeout log message.

The merge commits and formatting fixes should not be part of the PR.

Will do.
On Sun, Feb 27, 2022, 4:02 AM naushir @.***> wrote:

Thank you for your PR. Happy with the changes themselves, however, would
you be able to provide two separate commits:

One for the build instructions change.
Second one for the timeout log message.

The merge commits and formatting fixes should not be part of the PR.
—
Reply to this email directly, view it on GitHub
https://github.com/raspberrypi/libcamera-apps/pull/264#issuecomment-1053533263,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABXP4N6ZZRXID2AEVSWZHTU5IHG5ANCNFSM5PNK3SBQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

Redoing per request to isolate changes and direct to standard error.


Design suggestion [Files 0.7.3]

I am a fan of adding the Quick Access header but I am not such a fan of shifting down the menu.

no problem, it will not look bad if it is higher, what interests me most is the size of the texts / icons and the space between them and the side

I agree with reducing the size of the font and icons, and adding the bolded headers. It adds a degree of separation and hierarchy. And while I agree with not shifting it down that much, I do like the idea of shifting it in from the left a little bit.

I agree with reducing the size of the font and icons, and adding the bolded headers. It adds a degree of separation and hierarchy. And while I agree with not shifting it down that much, I do like the idea of shifting it in from the left a little bit.

maybe like this?

I am not sure if I like the idea of a smaller font. Currently it's very easy on the eyes, if its size is decreased it might appear unsharp.
Perhaps a settings page for font and icon sizes?

I am not sure if I like the idea of a smaller font. Currently it's very easy on the eyes, if its size is decreased it might appear blurred.
Perhaps a settings page for font and icon sizes?

Whether it is blurry or not will depend on the screen resolution of the users.
an option to change the font size would be fine, everyone happy xd

Perhaps we will provide an option to choose between the compact style and regular style. However I would recommend waiting until you actually try this to see how it looks on your screen.

Perhaps we will provide an option to choose between the compact style and regular style. However I would recommend waiting until you actually try this to see how it looks on your screen.

On a semi-related note, would it be possible to make the sidebar expandable? I notice that some of my drive names are cut off, and there's no way to adjust. It would be partially fixed with smaller font, but still.

On a semi-related note, would it be possible to make the sidebar expandable?

+1

I also think that this gap looks kind of random:

The small gap is to indicate a difference between the tabs and the sidebar. The plan is to make the sidebar expandable, we just haven't gotten to that yet. For the meantime, you should be able to see the full drive name by hovering over it.

The small gap is to indicate a difference between the tabs and the sidebar.

Hm, I still don't like it :/
Maybe a header like "quick access" as already proposed would solve this issue if aligned to the very top without that gap?

Maybe a header like "quick access" as already proposed would solve this issue if aligned to the very top without that gap?

if it's too high it'll be ugly, I edited the image and moved the menu a little higher, what do you think?

@xPoppyx Yes, I also think that the first variant (on the left) looks better but what about this?

just a little bit more space between the blue bar and the icons and it will be perfect.

Maybe something like this?

perfect

We are using the default navigation menu, we don't plan on extending it further then adding an option to choose between compact and regular views. The question still remains on how large of a gap to have between the edge of the app and the header. Looking forward for some more feedback on that 🙂

We are using the default navigation menu, we don't plan on extending it further then adding an option to choose between compact and regular views. The question still remains on how large of a gap to have between the edge of the app and the header. Looking forward for some more feedback on that

This is what will work for me:

I think what is important here is, that the gap to the left has to match the gap to the top. then it will look nice.

Also a header like "Quick Access" will definitely be helpful solving the problem, imho.

The plan is to make the sidebar expandable, we just haven't gotten to that yet. In the meantime, you should be able to see the full drive name by hovering over it.

Actually, it seems to only show me the size of the drive. It's no real issue to me as I can see the majority of the name of the drive.
As for the spacing above the header, here are a few options I've seen that we can discuss:

Even amount of space on both the top and left side of the content, but clearly more space than there is between each element (here).
Same as number 1, but with more emphasis on the hierarchy of the folders to the headers (here).
The teased preview that Microsoft themselves showed of (what I can only assume is) an early look at the UWP File Explorer, which basically matches what's done here (though with colourful icons that I think look great). They abandon headers entirely and just use increased spacing, but still show some slight folder hierarchy (here).
Hamburger menu for collapsing and and integrated search bar (pretend they're lined up with the top) (here).
The name of the app in the space (again, love the colourful icons) (here).

Personally I like 2 and 5, though the idea of having a hamburger menu in that spot for whenever the collapsible sidebar is implemented would make sense. It would also be nice if it were draggable as the current implementation isn't, leaving only a tiny spot beside the new tab button to use when the tabs are full.

continue here: #692


[Interpreter]: Add back spec_gas_opcode

Motivation
Foundry needs this particular function & macro to gather information about bytecode on certain parts of the evm crate. This adds back a few constants/structs that are strictly necessary to use the function in the same place it was before.
The structure of the project has changed a bit after this was removed, so happy to move stuff around!

test failing is unrelated


Be able to get something like config.languages.rust.package

I would like to use the same exact rustc and pass it to crate2nix.
I ran nix flake init --template github:cachix/devenv#flake-parts and then added this diff:
https://github.com/bbigras/test-devenv-rust/commit/d993ef34c541c1e028673084d62e427e78b3b0b1
Note that I don't really need it set as RUST_PKG, it's just as an example.
error:
       … while calling the 'derivationStrict' builtin
         at /builtin/derivation.nix:1:208:
       … while evaluating derivation 'devenv-shell'
         whose name attribute is located at /nix/store/mnfbbcdbbwh3iif9m9xp8jnsgys65f2g-source/pkgs/stdenv/generic/make-derivation.nix:331:7

       … while evaluating attribute 'RUST_PKG' of derivation 'devenv-shell'

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: attribute 'languages' missing
       at /nix/store/a9lcxd29b63scdccpnargrzprbfwy96q-source/flake.nix:55:27:
           54|           env = {
           55|             RUST_PKG = "${config.languages.rust.package}";
             |                           ^
           56|           };

Any reasons you're using flakes? It makes this confusing. You're using config that comes from flake-parts, you should be using the one from devenv.sh

If I'm not mistaken, you can use config.devenv.shells.default.languages (or whatever shell you configured) for accessing those values as a workaround

Any reasons you're using flakes?

I prefer using flakes for my inputs.

If I'm not mistaken, you can use config.devenv.shells.default.languages (or whatever shell you configured) for accessing those values as a workaround

Thank you very much. config.devenv.shells.default.languages.rust.toolchain seems to work.


Update react-html-attributes version to fix omission of some react specific attributes

What:
Updated the minimum version of react-html-attributes because some react specific attrs such as noValidate are missing.

Why:
The latest version of that package fixes the omission of some react specific attributes.

Codecov Report

Merging #73 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #73   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          10     10
  Lines         107    107
  Branches       27     27
=====================================
  Hits          107    107

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13187cf...893bec9. Read the comment docs.


how to pass a model from training phase to test phase

I want to train a model, and then evaluate on the test set. is there a better way than writing code to look for the last saved model file?

I'm not sure what you mean exactly.
But if you want to load the latest model in a separate script, "LOGGER_DIR/checkpoint" is the last saved checkpoint.

sorry if i was unclear. i wanted to get the model_file after training and pass to sample(). i ended up using:
model_file = tf.train.get_checkpoint_state(logger.LOG_DIR).model_checkpoint_path  sample(args.data, model_file)

This would depend on how "sample" is written.
If it uses SaverRestore(model_file) in the end, then model_file can either be dir/checkpoint, or what you have right now will also work.

so:
model_file = os.path.join(logger.LOG_DIR, 'checkpoint')

yes.


Improve "Clearing artifacts from the archives configuration." message

The following message:
Clearing artifacts from the archives configuration.
 Disable this behavior with -Pdependency.analysis.clear.artifacts=false
 Suppress this warning with -Pdependency.analysis.warnings.silent=true

is fairly opaque - I've no idea which artifacts we're talking about, why they were in the archives configuration, whether I do or do not want them there, what the consequence of them being or not being there is, and consequently whether I should disable the behaviour or suppress the warning. I ended up checking out the codebase to discover that this is normal, not a result of something odd I'm doing elsewhere, and that consequently I almost certainly want to suppress the warning.
(Also, suppressing the warning seems to be a generic flag for all warnings - as it happens from examining the codebase I think this is the only one that uses it, but perhaps a more specific flag for this specific case?)

I'm open to suggestions here. Maybe this?
Clearing artifacts from the archives configuration. If you don't know what this means, don't worry about it.

Re

(Also, suppressing the warning seems to be a generic flag for all warnings - as it happens from examining the codebase I think this is the only one that uses it, but perhaps a more specific flag for this specific case?)

I also considered this, but figured I'd rather cross that bridge when I come to it. I don't want to over-engineer something I may only need once.

I see the motivation behind the warning, but I think in general it is not "very nice" of a plugin to print so many messages during configuration time for its default setup. That is, I just apply the plugin, do nothing else, and I get warnings (which are not even actionable if I have a good build setup).
This is somehow a blocker right now for me to upgrade (working hard on a build to get rid off all warnings for some time :)).
I would like to see this go to the "info" log only maybe.
I also applied the plugin to my build-logic.  And now I have two issues:
1.
> Task :gradle-build-logic:base-plugins:generatePrecompiledScriptPluginAccessors
Clearing artifacts from the archives configuration.
 Disable this behavior with -Pdependency.analysis.clear.artifacts=false
 Suppress this warning with -Pdependency.analysis.warnings.silent=true
Clearing artifacts from the archives configuration.
 Disable this behavior with -Pdependency.analysis.clear.artifacts=false
 Suppress this warning with -Pdependency.analysis.warnings.silent=true

And I think there is no way to avoid it.
2.
I need to put dependency.analysis.warnings.silent=true into multiple gradle.properties files.
Alternatively, it would be nice if "silent warnings" could be configured on an extension instead. But I see how the timing might be a problem with that.
Or maybe the default behavior could be change so that just the "artifacts" that cause trouble are removed from "archives" and then no warning is necessary at all?

Or maybe the default behavior could be change so that just the "artifacts" that cause trouble are removed from "archives" and then no warning is necessary at all?

I actually had a long conversation about this, I think with Louis Jacomet, or maybe Cédric, on the Gradle community slack (a long time ago). We actually tried in a variety of ways to clear specific artifacts, but nothing was working. It has to do with "legacy" behavior of the archives configuration when setting outgoing artifacts for simple inter-project publishing. (One possible solution is improving this story, but I can't prioritize that at this moment.)
The original motivation for clearing the artifacts was this: for some developers, it is part of their development flow to click the "make" button in the IDE, which I believe triggers assemble, and this builds everything that is in the archives configuration. As a result, these devs were seeing exploding build times when they were just trying to trigger source generation. With Gradle's encouragement, I simply started clearing that configuration.
I never really felt good about that, because I was silently changing build behavior. And indeed, eventually someone noticed because they had been relying on that old Gradle behavior -- hence the flag to not clear artifacts.
As I approach the v1 release, I decided I needed to make this behavior more visible so folks could configure it as they see fit. It's a non-ideal situation on top of a non-ideal situation.
I present all this context in case you may have better ideas for handling it. I'm not really comfortable with moving the warning to info, since I don't think many people look at that. Would quiet be better? Alternatively or secondarily, what about ensuring it only gets printed once, instead of once per project?
Regarding configuring it via extension, you understand correctly that there's a timing problem.

I don't know if you have tried this, but you should set:
isVisible = false

for the consumable you create in publishArtifact(...). The name of the flag is misleading - it means that the Configuration is not (so much) "visible" outside the current project. A better name would maybe be "opt-out of legacy behaviour".
So ideally you should always set it to false for custom/new configurations unless you need it for some specific legacy behavior. But I also often do not do that, because of the additional noise. The flags (and their wrong defaults) are really a PITA. It's all there for backward compatibility, but well....
I had a look at the Gradle sources and it looks like this is what you need:
https://github.com/gradle/gradle/blob/master/subprojects/plugins/src/main/java/org/gradle/api/plugins/BasePlugin.java#L107
My tests also show that this work and then you can remove this "clearing of artifacts" thingy completely.

Yes, please remove this if possible.
I just spent two hours or so to find out why the hell assemble does not depend on jar anymore which makes the release process with the gradle-release plugin not work as expected anymore.
Turned out to be this plugin silently doing unexpected build modification. (with version 0.80.0)

I created a PR for the change I proposed: https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/pull/625

@Vampire Please do not be rude on this issue tracker. This is your one and only warning.

I don't see where I was rude. I just intended to add my vote and plea to fix this properly with another report of how this had a negative effect on a project.

Given the associated PR, I have updated the issue title to reflect the new goal.


Can we use 1 master statefulset  to replace 3 ?

Alluxio Version:
2.1.0
Describe the bug
I notice if there are 3 alluxio masters,  we have to create 3 statefulsets. It looks odd. Can we enhance it? Can we use 1 statefulset with 3 replicas to deploy it?
To Reproduce
N/A
Expected behavior
N/A
Urgency
N/A
Additional context
Using a single stateful set will improve maintainability.

I think we can leverage to attach different services to the same statefulset https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#pod-name-label.

I think we can use 1 StatefulSet with multiple replicas for multiple Alluxio masters. We are planning to do this actually, and use volumeClaimTemplates to make the PVC be created and managed automatically. This doesn't have a concrete ETA yet but is definitely the way to go in the near future.


Package building is failing

When i tried to build package it is failing, i tried both package-all & package-win.
Here is the log
jalad@DESKTOP-E6OTOI1 MINGW64 /d/~Development/Source/diabetes/chrome-uploader (master)
$ npm run package-win

<EMAIL_ADDRESS>package-win D:~Development\Source\diabetes\chrome-uploader
npm run build && electron-builder --win --x64

<EMAIL_ADDRESS>build D:~Development\Source\diabetes\chrome-uploader
npm run build-main && npm run build-renderer

<EMAIL_ADDRESS>build-main D:~Development\Source\diabetes\chrome-uploader
yarn build-main-quiet --progress --profile --colors

yarn run v1.12.1
warning package.json: "dependencies" has dependency "eslint-plugin-lodash" with range "2.5.0" that collides with a dependency in "devDependencies" of the same name with version "2.7.0"
$ cross-env NODE_ENV=production node -r babel-register ./node_modules/webpack/bin/webpack --config webpack.config.electron.js --progress --profile --colors
4097ms building modules
15ms sealing
16ms optimizing
0ms basic module optimization
0ms module optimization
0ms advanced module optimization
0ms basic chunk optimization
0ms chunk optimization
0ms advanced chunk optimization
0ms module and chunk tree optimization
0ms chunk modules optimization
0ms advanced chunk modules optimization
0ms module reviving
0ms module order optimization
0ms module id optimization
16ms chunk reviving
0ms chunk order optimization
15ms chunk id optimization
31ms hashing
0ms module assets processing
47ms chunk assets processing
0ms additional chunk assets processing
0ms recording
0ms additional asset processing
973ms chunk asset optimization
0ms asset optimization
359ms emitting
Hash: c6e28253317077503921
Version: webpack 3.8.1
Time: 5569ms
Asset     Size  Chunks                    Chunk Names
./app/main.js  3.49 MB       0  [emitted]  [big]  main
./app/main.js.map  4.01 MB       0  [emitted]         main
[130] (webpack)/buildin/module.js 495 bytes {0} [built]
[] -> factory:390ms building:63ms = 453ms
[143] ./app/actions/sync.js 291 kB {0} [built]
[] -> factory:393ms building:297ms dependencies:94ms = 784ms
[341] ./app/constants/actionTypes.js 9.7 kB {0} [built]
[] -> factory:219ms building:578ms = 797ms
[342] ./app/constants/actionSources.js 7.58 kB {0} [built]
[] -> factory:219ms building:515ms = 734ms
[343] ./app/constants/metrics.js 4.54 kB {0} [built]
[] -> factory:219ms building:453ms = 672ms
[344] ./app/actions/utils.js 4.81 kB {0} [built]
[] -> factory:203ms building:125ms dependencies:47ms = 375ms
[345] ./lib/core/personUtils.js 1.28 kB {0} [built]
[] -> factory:219ms building:406ms dependencies:172ms = 797ms
[349] multi babel-polyfill ./app/main.development 40 bytes {0} [built]
factory:0ms building:0ms = 0ms
[552] ./app/main.development.js 12.7 kB {0} [built]
[] -> factory:157ms building:312ms = 469ms
[670] ./app/actions/index.js 6.23 kB {0} [built]
[] -> factory:188ms building:109ms = 297ms
[671] ./app/actions/async.js 52.6 kB {0} [built]
[] -> factory:909ms building:375ms dependencies:562ms = 1846ms
[700] ./app/constants/otherConstants.js 3.16 kB {0} [built]
[] -> factory:312ms building:78ms = 390ms
[701] ./app/utils/errors.js 8.83 kB {0} [built]
[] -> factory:203ms building:156ms dependencies:0ms = 359ms
[705] ./app/utils/uploadDataPeriod.js 1.94 kB {0} [built]
[] -> factory:109ms building:141ms dependencies:0ms = 250ms
[706] ./app/utils/debugMode.js 3.69 kB {0} [built]
[] -> factory:16ms building:125ms dependencies:0ms = 141ms
+ 714 hidden modules
Done in 7.83s.

<EMAIL_ADDRESS>build-renderer D:~Development\Source\diabetes\chrome-uploader
yarn build-renderer-quiet --progress --profile --colors

yarn run v1.12.1
warning package.json: "dependencies" has dependency "eslint-plugin-lodash" with range "2.5.0" that collides with a dependency in "devDependencies" of the same name with version "2.7.0"
$ cross-env NODE_ENV=production node -r babel-register ./node_modules/webpack/bin/webpack --config webpack.config.production.js --progress --profile --colors
Using the default environment, which is now production.
15970ms building modules
31ms sealing
0ms optimizing
0ms basic module optimization
0ms module optimization
0ms advanced module optimization
0ms basic chunk optimization
0ms chunk optimization
0ms advanced chunk optimization
0ms module and chunk tree optimization
0ms chunk modules optimization
0ms advanced chunk modules optimization
16ms module reviving
0ms module order optimization
0ms module id optimization
0ms chunk reviving
0ms chunk order optimization
31ms chunk id optimization
31ms hashing
0ms module assets processing
94ms chunk assets processing
0ms additional chunk assets processing
0ms recording
0ms additional asset processing
2816ms chunk asset optimization
172ms asset optimization
406ms emitting
Hash: 9994f962547eed42d8a8
Version: webpack 3.8.1
Time: 19598ms
Asset      Size  Chunks                    Chunk Names
71c4b3129c1b036c625882343856515f.woff   14.6 kB          [emitted]
3ccbd41bfd4962b57199a8fcfbcbde66.woff   14.5 kB          [emitted]
0ffd6c9760dbd98b33b40cda7c5fe855.woff   15.8 kB          [emitted]
84b1d9bb65b585d4b4a72ee9cefb2ac2.woff   15.5 kB          [emitted]
bundle.js   7.25 MB       0  [emitted]  [big]  main
style.css   24.9 kB       0  [emitted]         main
bundle.js.map   8.29 MB       0  [emitted]         main
style.css.map  86 bytes       0  [emitted]         main
../app.html   1.06 kB          [emitted]
[60] (webpack)/buildin/module.js 495 bytes {0} [built]
[] -> factory:0ms building:0ms = 0ms
[84] ./app/constants/errors.js 2.44 kB {0} [built]
[] -> factory:109ms building:172ms = 281ms
[138] ./lib/config.js 1.21 kB {0} [built]
[] -> factory:32ms building:156ms = 188ms
[151] ./lib/core/api.js 20.6 kB {0} [built]
[] -> factory:32ms building:546ms dependencies:1824ms = 2402ms
[198] ./app/utils/rollbar.js 1.35 kB {0} [built]
[] -> factory:32ms building:140ms = 172ms
[493] multi babel-polyfill ./app/index 40 bytes {0} [built]
factory:0ms building:0ms = 0ms
[696] ./app/index.js 3.1 kB {0} [built]
[] -> factory:453ms building:156ms = 609ms
[745] ./app/store/configureStore.js 263 bytes {0} [built]
[] -> factory:32ms building:156ms = 188ms
[946] ./app/containers/App.js 34.7 kB {0} [built]
[] -> factory:32ms building:375ms dependencies:4019ms = 4426ms
[1120] ./app/containers/SettingsPage.js 30.1 kB {0} [built]
[] -> factory:2183ms building:899ms dependencies:2878ms = 5960ms
[1124] ./app/containers/ClinicUserSelectPage.js 21.5 kB {0} [built]
[] -> factory:2167ms building:836ms dependencies:438ms = 3441ms
[1129] ./app/containers/ClinicUserEditPage.js 27 kB {0} [built]
[] -> factory:2167ms building:711ms dependencies:657ms = 3535ms
[1133] ./app/containers/NoUploadTargetsPage.js 20.8 kB {0} [built]
[] -> factory:2167ms building:271ms dependencies:1440ms = 3878ms
[1165] ./app/app.global.css 41 bytes {0} [built]
[] -> factory:1016ms building:1027ms = 2043ms
[1166] ./styles/main.less 41 bytes {0} [built]
[] -> factory:1032ms building:7937ms = 8969ms
+ 1152 hidden modules
ERROR in RollbarSourceMapPlugin: required field, 'accessToken', is missing.
Child html-webpack-plugin for "..\app.html":
1 asset
[0] ./node_modules/html-webpack-plugin/lib/loader.js!./app/app.html 1.34 kB {0} [built]
factory:125ms building:31ms = 156ms
[2] (webpack)/buildin/module.js 495 bytes {0} [built]
[] -> factory:172ms building:47ms = 219ms
+ 1 hidden module
Child extract-text-webpack-plugin node_modules/extract-text-webpack-plugin/dist node_modules/css-loader/index.js!app/app.global.css:
[0] ./node_modules/css-loader!./app/app.global.css 159 bytes {0} [built]
factory:125ms building:605ms = 730ms
+ 1 hidden module
Child extract-text-webpack-plugin node_modules/extract-text-webpack-plugin/dist node_modules/css-loader/index.js!node_modules/less-loader/dist/cjs.js!styles/main.less:
Asset     Size  Chunks             Chunk Names
71c4b3129c1b036c625882343856515f.woff  14.6 kB          [emitted]
3ccbd41bfd4962b57199a8fcfbcbde66.woff  14.5 kB          [emitted]
0ffd6c9760dbd98b33b40cda7c5fe855.woff  15.8 kB          [emitted]
84b1d9bb65b585d4b4a72ee9cefb2ac2.woff  15.5 kB          [emitted]
[0] ./node_modules/css-loader!./node_modules/less-loader/dist/cjs.js!./styles/main.less 17.5 kB {0} [built]
factory:468ms building:2910ms = 3378ms
[3] ./fonts/icons.woff 8.26 kB {0} [built]
[] -> factory:2561ms building:1967ms = 4528ms
[4] ./fonts/opensans.woff 83 bytes {0} [built]
[] -> factory:2561ms building:1998ms = 4559ms
[5] ./fonts/opensans-bold.woff 83 bytes {0} [built]
[] -> factory:2561ms building:1982ms = 4543ms
[6] ./fonts/opensans-italic.woff 83 bytes {0} [built]
[] -> factory:2561ms building:1998ms = 4559ms
[7] ./fonts/opensans-bolditalic.woff 83 bytes {0} [built]
[] -> factory:2561ms building:1998ms = 4559ms
+ 2 hidden modules
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>build-renderer: yarn build-renderer-quiet --progress --profile --colors
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build-renderer script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!      C:\Users\jalad\AppData\Roaming\npm-cache_logs\2018-11-16T03_06_05_939Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>build: npm run build-main && npm run build-renderer
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!      C:\Users\jalad\AppData\Roaming\npm-cache_logs\2018-11-16T03_06_05_985Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>package-win: npm run build && electron-builder --win --x64
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>package-win script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!      C:\Users\jalad\AppData\Roaming\npm-cache_logs\2018-11-16T03_06_06_033Z-debug.log

Referring to the error:
ERROR in RollbarSourceMapPlugin: required field, 'accessToken', is missing.
Child html-webpack-plugin for "..\app.html":

You don't have an access token for Rollbar, so it's not able to build the Rollbar integration in the app.
If you would like to just run the uploader to develop against it, you can follow the setup instructions in the README.

@gniezen @krystophv - are the npm package* targets intended for use by contributors? If so, it seems we should fix this (ie, build without Rollbar support if packaged by contributors), or throw an error when process.env.ROLLBAR_POST_TOKEN is not set to state that these build targets are intended for Tidepool use only.

@krystophv okay, cool. @pradeepjaladi - it seems that packing the chrome-uploader outside of our CI environment is not supported. Is there a reason you wish to do this, other than just running yarn dev?

Hi Lennart,
I am developing Health management systems with multiple integrations, One of the integration is upload Diabetes devices data, When i was googling around found about you, So thought of downloading and built it and see how it works.
We are planning to go commerical with your  HMS systems ( Not public yet ) currently working on abott, accucheck, arkay, ascensia, menarini and onetouch meters developing in Java.
Please let me know if i can help in any ways.

All of our device code is in JavaScript. These devices that you're developing support for - do they have protocol specs that are openly shareable? Will your code also be open source?

I added a card to support building a package locally without Rollbar (https://trello.com/c/QtHXeFJv) as it can be useful for example when testing the USB driver installation, or when GitHub is down and the CI webhooks aren't working.
In the meanwhile, I would also suggest to just use yarn dev to build and run the uploader instead.

Hi,
Sorry for replying back so late. If you are looking for specs or implementation for the meters please see the source code of https://sourceforge.net/projects/ggc/


travis check for createsettings and migration

In reaction of #4069 the ticket #4070 was created.
Currently this version can sanely check if createsettings and migrations wents through. The runserver command is more or less for readability and for checking the logs, since it always returns 0. A flag for the runserver command would be nice, that returns -1 when it hits failure state.

This branch is currently on purpose on track with the broken master, to make test the failing easier.

@jsaalfeld the --noreload works. I added an Error, becuase the issue with the users did not come up every time. Please have a look, remove the error, rebase and merge.


Inconsistent scrolling with mouse wheel

When scrolling with mouse wheel, amount scrolled for the same amount of wheel rotation is dependent on speed of turning the wheel.
If I scroll fast, I get less scrolling than if I scroll slowly. That is not how it should work and not how it works in other applications.
It seems that some scroll events don't get registered if they occur often.
Windows 10. GT v0.8.2623.

I am not sure I understand this issue.
is it possible that you are seeing the scrolling acceleration at play? If so, then it's a wanted behavior. This is how it works on Mac, for example.

Thank you for the clarification. That is the intended behavior.

Okay. But what is the rationale? Scrolling less when input is faster (first case) makes no sense to me.

When the list is a larger, we want the ability to scroll faster through it.

When the list is a larger, we want the ability to scroll faster through it.
Maybe my drawing wasn't clear enough, but the size of the content is the same in both cases.
And behavior in question certainly doesn't make scrolling faster. It does the opposite.
Because when you try to scroll fast (first case), you get less scrolling (per angle of wheel's rotation).

Scrolling has acceleration. So, the more frequent you scroll, the faster it gets, and the less scrolls you need to scroll the same amount of content. This is particularly useful if you have a large list and want to get to the bottom of it.

https://user-images.githubusercontent.com/6537039/225407721-89abb5f3-efb8-4c73-bb93-052966eef548.mp4

hmm, interesting. would you have the option to try with a touchpad as well?

Touchpad:
https://user-images.githubusercontent.com/6537039/225415303-15feae8e-9d67-4e3d-b75e-e6d5bb942364.mp4

Touch screen:
https://user-images.githubusercontent.com/6537039/225415517-144fad41-5813-4761-95cb-e59bdb7cce61.mp4


Bucket rewrite: able to mark original blocks for deletion after new blocks are created

Is your proposal related to a problem?

Bucket rewrite tool supports block deletion and relabeling. It creates a new block and the original block is left unchanged. Usually, the old block can be removed. But it requires another step to mark the original block.
Describe the solution you'd like

It would be handy to have a flag to mark the original blocks for deletion after the new blocks created successfully. This flag should work only in none dry run mode.

Thoughts? @bwplotka @onprem @GiedriusS

Makes total sense. For some reason I thought that we were doing this automatically already

Assign this myself.

Fixed in https://github.com/thanos-io/thanos/pull/4392.


Add Werror flag to Setup

We recently in pandas added the -Werror flag to our setup script to help proactively identify bugs - would Cython consider doing the same thing?

Generally speaking: yes.
Practically speaking: the test suite isn't free of warnings currently, and getting rid of all of those isn't always easy.
We consider C compiler warnings a bug, though. Improvements welcome.
We could get closer by adding a test tag that ignores C compiler warnings for a given test, set that on all tests that currently produce them (potentially also platform specific tags), and then clean those up later. That way, we could at least enable -Werror for now.

(Let's wait with that until we fix #3481, though.)

Marking this as a nice beginner's ticket. What needs to be done:

implement a new tag ignore_cwarnings in runtests.py (look for cerror for a similar feature)
look through the travis-CI and appveyor runs of the master branch to find tests that produce warnings.
add the tag to these tests (# tag: ignore_cwarnings)
enable -Werror for the test compilation (for C compilers that support it)
see which tests fail now due to warnings and add a tag for them, too.

Taking a look at this - can you offer any insight on how to find the tests? I see this warning in the log as an example:
compiling (c/cy2) extimported ...
=== C/C++ compiler error output: ===
cdef_syntax.c: In function â€˜__pyx_pf_11cdef_syntax_use_cdefâ€™:
cdef_syntax.c:1633:143: warning: variable â€˜__pyx_t_1â€™ set but not used [-Wunused-but-set-variable]
   __pyx_ctuple_7e355__PyObject__ptr__lParen__ptr__rParen__lParenvoid__rParen__and_PyObject__ptr__lParen__ptr__rParen__lParenvoid__rParen__etc __pyx_t_1;
                                                                                ^~~~~~~~~
====================================

Though when grepping for extimported I found nothing

./tests/compile/extimported.pyx in that case. I did find . -name "extimported*". Although that specific warning looks to come from either ./tests/compile/cdef_syntax.pyx or ./tests/errors/cdef_syntax.pyx - I wonder if things are being run in parallel and so the output is slightly jumbled?

I wonder if things are being run in parallel and so the output is slightly jumbled?

Yes, that's the case. It usually works ok-ish to recover the failed test output, so the test turnover time is considered more important than beautiful output of the test runner. (Although the latter wouldn't hurt either…)
The warning comes from tests/compile/cdef_syntax.pyx, since error tests do not pass through the C compiler.

warning: variable â€˜__pyx_t_1â€™ set but not used

That's definitely a bug, BTW. Temp variables should always be used, otherwise they shouldn't get created in the first place.


HDDS-6726. Close RocksObject in Recon and tools

What changes were proposed in this pull request?
Ensure all remaining usages of RocksObject (in tools, Recon, and everywhere) are closed. This PR encloses mostly simple uses of try-with-resource on managed RocksObject.
This is a split from #3646.
https://issues.apache.org/jira/browse/HDDS-6726
How was this patch tested?
Standard CI: https://github.com/duongnguyen0/ozone/actions/runs/2842465309

@ChenSammi @jojochuang @smengcl @szetszwo  Can you please take a look?

@duongnguyen0 , there are some Conflicting files.  Could you update this change?

@duongnguyen0 , there are some Conflicting files. Could you update this change?

Sure, thanks for noticing it. I merged from upstream and also made some updates on top of the new changes.

Thanks @duongnguyen0 for the patch. This should help us combat potential RDB iterator mem leaks because of not closing the iterator after use.

Thanks a lot for looking at it @smengcl.

Thanks @duongnguyen0 for the patch. Thanks @jojochuang @szetszwo for reviewing.


Q: Which NIPs should/can be supported?

NIP-10: On "e" and "p" tags in Text Events (kind 1): https://github.com/nostr-protocol/nips/blob/master/10.md
NIP-34: "User Statuses": https://github.com/nostr-protocol/nips/blob/master/38.md
NIP-40: "Expiration Timestamp": https://github.com/nostr-protocol/nips/blob/master/40.md

NIP-53 "Live Activities": https://github.com/nostr-protocol/nips/blob/master/53.md


Async replication "guarantee"

I believe this sentence should be change to say "replication is not guaranteed to be instantaneous."
>For scenarios where clients write to Redis frequently, partial data loss can occur because this replication is guaranteed to be instantaneous.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b2341a44-997b-3cd5-f54b-fdcf7b3494ab
Version Independent ID: 8c681051-e75e-484f-a9be-97ca34668b24
Content: Troubleshoot data loss in Azure Cache for Redis
Content Source: articles/azure-cache-for-redis/cache-troubleshoot-data-loss.md
Service: cache
GitHub Login: @yegu-ms
Microsoft Alias: yegu

@Blackbaud-TommyVernieri  We will check this and correct it after checking.

@Blackbaud-BenLambert We have made changes to the document with Pull Request https://github.com/MicrosoftDocs/azure-docs-pr/pull/115793 .
Once approved the changes will be visible inapprox 24 hrs.

message probably intended for @Blackbaud-TommyVernieri

@Blackbaud-BenLambert  Thanks for the correction. Yes it is for @Blackbaud-TommyVernieri


Converted to Swift 2

Hi, thank you for your contribution! Can you move this pull request to the swift-2.0 branch? https://github.com/malcommac/SwiftLocation/tree/swift-2.0

I just created a new pull request to he Swift 2 branch


Add ChunksToHermesBytecodePlugin

Summary
At Klarna we've been using Re.pack for a while now, and wish to contribute back our implementation of a ChunksToHermesBytecodePlugin. This PR is based on an in-house plugin developed by @oblador.
The plugin itself re-implements tranformations found in each platform (which assume a single main chunk):

For iOS the logic is copied from react-native-xcode.sh
For Android the logic is copied from BundleHermesCTask.kt (with defaults in ReactExtension.kt)

Side note: maybe these should be extracted into the react-native CLI, or scripts, instead of having separate implementations?

Test plan

[x] Add to TesterApp
[x] Verify iOS (bundle, bundle and run in Release, start and run in Dev)
[ ] Verify Android (bundle, bundle and run in Release, start and run in Dev)
[x] Verify it works as expected for the simple case

Open questions

Should this transformation happen inside the OutputPlugin (or AssetProcessors)?

There's a lot of reusable logic in those and it feels like a more natural home.

Should we transform all chunks in this plugin, or ignore the main chunk (letting react-native transform that using hermes) and transform the rest?

PRO: Letting react-native transform the main chunk means we don't have to recommend that people opt-out of this (less work, more maintainable)
CON: It means special handling within Re.pack to ignore the main chunk and risks the transformation algorithm diverging over time (and composition of source maps). This might be okay since the main chunk is usually the most important to have transformed, so if our implementation gets out of sync with RN it might not be too bad.
There is no super clean way of doing this on Android. See comment in code.

Alternative to (2): What if the ChunksToHermesBytecodePlugin accepted a transformMainChunk: boolean property?

This would allow the most flexibility

Side note: maybe we should add more fine-grained control to the configuration react-native where you can opt out of the automatic hermes transformation of the bundle, but still use Hermes as the runtime.

TODO:

[ ] Resolve open questions
[ ] Figure out how to make it work with remote chunks
[x] Add sensible defaults and messaging for misuse of the plugin
[ ] Update API docs
[ ] Update usage docs

I wonder if this should be added to the output plugin as an optional step. It needs to use a lot of the same logic to determine local vs remote chunks 🤔

Hi @mikeduminy
Regarding the open questions:

Let's keep the transformation in the separate plugin as it is because:

OutputPlugin is something we noticed adds some convenience for the user, but introduces a lot of complexity when releasing new plugins, in the future we are probably going to deprecate it and remove it from the RePack plugin.
AssetsProcessor is something that deals with assets other than chunks so it's not the right place to do this transformation

I think we want to leave the responsibility of transforming the main chunk to the react-native itself. It's hard to only disable the transformation without disabling the hermes engine and it might be quite confusing for the end user.

Good idea, only suggestion I might have is to name it 'entryChunk' instead of 'mainChunk', please tell me what you think

What I suggest we should do starting with this plugin (and apply the same pattern for the rest of the plugins in the future):

Add inputPath option to tell the plugin where to look for input
Add outputPath option to tell the plugin where to place the transformed chunks. If the path is the same as inputPath it will overwrite the existing bundles with the new transformed ones.
Add transformEntryChunk optional option (by default set to false) or in most cases we are going to be only omitting index.bundle (the name can be obtained through webpack configuration object available inside the plugin)
Add tranformIgnore optional option to provide a list of additional ignored paths

@mikeduminy
take a look here and give this a shot, I had something like this in mind: https://github.com/callstack/repack/commit/fd060760f964a705fea9e1fab117800bc2892474
compare branches here

I've managed to use assetEmitted hook instead of afterEmit so it runs before OutputPlugin and simplifies the logic of the plugin greatly.
All the transformations are now done inside build/generated directory which is the source from which OutputPlugin copies the bundles to their target directories.

Preview of the docs available here: https://6494804b67314a519583e33b--re-pack.netlify.app/docs/configuration/plugins/chunks-to-hermes


ReceiptsRoot Mismatch with Pantheon Clique

2018-11-09 10:09:21.055+00:00 | EthScheduler-Workers | WARN  | MainnetBlockBodyValidator | Invalid block: receipts root mismatch (expected=0x3dc2cb692e7b8cd4276e523dfd031960d2e09bc24fcc5ccf990434c697e67d87, actual=0x2aa024623680a960cc38a96838a71e2463b0d182a897f95ea928be00cb5560c9)
2018-11-09 10:09:21.056+00:00 | EthScheduler-Workers | WARN  | PipelinedImportChainSegmentTask | Import of chain segment (9400 to 9600) failed: Failed to import block: 9554, 0x9ba7bbf8487006902c91ded8ed04cf80ad3a6efa6e27d2c53d14f05bc5e235dc.

Gist with extended logs, block and transaction data:
https://gist.github.com/JohnnySheffield/c3deae0f33d96ec6105a3b5bc2d27060

Fixed in https://github.com/PegaSysEng/pantheon/pull/247


Added unit test for generic empty stream

This unit tests fails per #6522.
I wasn't able to reproduce the issue using the
https://github.com/grpc/grpc/blob/master/src/python/grpcio/tests/unit/framework/interfaces/face/test_cases.py infrastructure, so this is kind of a one off.

Please resolve conflicts, unskip, and produce fresh test results?

Rebased.  I've verified that the Beta API no longer has this problem, but I figured adding a unit test for the GA API going forward would be more useful.

Looks mostly good.

Addressed comments.

Luhguhtum; thanks.


⚠ Spryr has degraded performance

In 2745127, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 7241 ms

Resolved: Spryr performance has improved in 628c128 after 8 minutes.


Start to segregate property conversions from ObservableProperty.

archaius-pull-requests #163 SUCCESS
This pull request looks good

archaius-pull-requests #164 SUCCESS
This pull request looks good


Developer instructions

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Implemented in repository https://github.com/mailchain/docs.mailchain.xyz

Instructions are not included for developers. Re-opening this


Fix warning-less and unnecessary orphans.

Show instance for UTCTime doesn't appear unless you import Data.Thyme.Format / Data.Thyme.LocalTime.

@bitemyapp thanks for reporting this for me. I ran into this last night when I was baffled by the fact that the Haddock included the Show instance for UTCTime, but ghc disagreed with its availability.
I think that in general, Show instances should only be used for debug messaging, and as you provide plenty of functions for doing proper rendering of UTCTime functions to strings, it would be very helpful if these instances were not orphaned; I really prefer if runtime behavior does change depending upon which modules are imported into a scope.

I'll look into this…

This is how it is done in the time package. I'd also think it should go with the UTCTime instance, though there might be some arcane code depending on this behaviour (I guess the think shouldn't link anyway if some competing Show instance is defined?)

I ran into the same issue with ToJSON/FromJSON. The orphan instances are in Data.Thyme.Format.Aeson, and importing Data.Thyme (UTCTime) doesn't bring them into scope. It was pretty confusing.


Caught exception: Cannot read properties of undefined

I'm new to Node-RED and HA, so I just tried to import the examples to try this.
I managed to set the location, user, pw, room, name and type. When I deploy, the Guard has a green square and "connected" status. But if I  start "timestamp" (or anything else), I get "failed" and this error in the debug: "Caught exception: Cannot read properties of undefined (reading 'type')"
Any hint at what I'm doing wrong?

@4Fire4 I never saw this before. To know what is going on I would need to debug the node or I would need more information.

Maybe we can arrange a teams meeting?

I'm running "Home Assistant Operating System" on a Raspberry Pi 4.
Yes, we can arrange a teams meeting.

Reason: conversion of notification response fails as category 40 is not known: make the conversion more robust

please install new version 0.15.1 and let me know if it works for you

Tested with both Windows and Home Assistand on Raspberry Pi 4 and it works :)
I had two unread of those category 40 notifications, which seem to be not normal notifications.  questionnaire that I got due to previously detected potential leak notifications.
Thanks @windkh!

I had a look at "ondusApi.js" and you say category 40 is "unkown, maybe info". Here is a screenshot of that specific notification category 40, which seems to be a questionnaire or request for feedback:

@4Fire4  thanks for testing... yes indeed I also thought maybe the category is "question" but as this is the only type in category 40 I saw so far I left this open for now. Maybe more types in this category will be reported in future, then we will know for sure what 40 really means.

@4Fire4  I found out that category 0 is reserved for advertising and category 40 seems to be an external web url


Can't log in

Hi,
I can't log in my blog. Email and password are correct. Can you help me?

Regards

were you able to log in? i'm on Ghost V4 and logged in just fine.

Yes, I can. I think it was a certificate issue.

Thanks!


Add features property to Safe App

With the recent addition of SafeApp.features in the Safe Config Service, and given that the schema has additionalProperties set to false we need to add features to the schema to make it valid again
See https://github.com/safe-global/safe-config-service/commit/814b8eb5faaabf43809f4852e9cac330e0501335

Coverage: 78.426%. Remained the same when pulling 5472a2c1f4934ec8d24ccf6cb24842453bc7edc7 on add-features-safe-app-schema into 4538534aea898a48c9901ab36f569cf8ddd34b41 on main.

🚀
Btw, we need to include these features property in the SafeApp entity and builder as well I think (we could do it in a separate PR) 🙂

🚀
Btw, we need to include these features property in the SafeApp entity and builder as well I think (we could do it in a separate PR) 🙂

I think it makes sense to address in this PR too. Added here 9312d51


Enable py3

per #551 , remove python 3 skips (which will cause travis to fail). As people fix python 3 compatibility, things will fail less

Didn't get to this quickly enough due to NIH visit today. Can you fix the conflicts and then we can merge?
Sorry about merging #653 before this!

Let's not actually merge this (since it will cause travis to fail). I'll keep rebasing as people make progress towards python 3 compatibility

@mpharrigan : Can you rebase/merge from master when you get a chance? We can get all of this cleaned up pretty quickly thereafter.

rebased. This shouldn't be merged. The packages noted here should work to support py3

Thanks!


Automatically pinning correct provider given set SMS sender ID

Value Statement
As VANotify platform owner
I want to be able to set SMS sender ID and have the correct provider automatically chosen
So that I don't have to manually track and assign the correct provider for the set sender ID
Acceptance Criteria
GIVEN an SMS sender ID is set
THEN the SMS sender ID vs. provider matrix is followed
Checklist

[ ] Checklist item here

Assumptions

Additional Info/Resources

SMS sender ID vs provider matrix https://docs.google.com/spreadsheets/d/1H7_D7a3zGFWvWGAqw6c3u_SF9atQTHKE_gVSIBysGWI/edit?usp=sharing

Out of Scope

Open Questions

@philherbert to take a look and we add more content then it can be moved to ready for development.


raise ConnectionError jetson-container offline

Hi Dustin
great job on  Live Llava 2.0 - VILA + Multimodal NanoDB for jetson Orin
is it possible to run all the jetson-container offline instead of downloading from huggingface every time?
tried to commit the container while running but when i unplug the network cable it fail with error
raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: (MaxRetryError('HTTPSConnectionPool(host='huggingface.co', port=443): Max retries exceeded with url: /openai/clip-vit-large-patch14-336/resolve/main/model.safetensors (Caused by NameResolutionError("<urllib3.connection.HTTPSConnection object
txs

Hi @malocker, yes the models should automatically be cached under jetson-containers/data/models/huggingface (which is mounted into the container under /data)
Can you check from outside the container if those get downloaded to there?
You can also try specifying their actual path instead of the huggingface repo/model name, then it won't attempt to download them.  I think it still checks for updates in the repos and compares checksums, maybe that is what it was complaining about.

Hi Dustin
Yes the models exist on /data/models folder but keep looking to huggingface hub before start
when i try to pass folder location  as parameter --model /folder/VILA1.5-3b  i get huggingface_hubb.errors : repo id must use alphanumeric char
where  do you specify the path ? when run the container or into one of the config files ?
Thank you

/openai/clip-vit-large-patch14-336/

@malocker try changing 'ViT-L/14@336px' on this line to the directory of the CLIP model (it should have been downloaded under /data/models/clip)
https://github.com/dusty-nv/NanoLLM/blob/28fa5499e40f74c5a36883770584b0bc9fe03e76/nano_llm/agents/video_query.py#L100
You will want to edit that source inside container, or by cloning an external copy of the NanoLLM sources and mounting it into container like this:  https://www.jetson-ai-lab.com/agent_studio.html#dev-mode
If that change isn't effective, keep drilling down and replacing the model string with the path:   https://github.com/dusty-nv/NanoDB/blob/f8df95db3ac29098d2957628c8ee1fdd9f12b125/nanodb/nanodb.py#L42

I changed 'ViT-L/14@336px' on this line to the directory of the CLIP model (it should have been downloaded under /data/models/clip)
https://github.com/dusty-nv/NanoLLM/blob/28fa5499e40f74c5a36883770584b0bc9fe03e76/nano_llm/agents/video_query.py#L100
in the  container 'jetson-containers run $(autotag nano_llm) '  the file in the '/opt/NanoLLM/nano_llm/nano_llm.py' ,and Using path "/data/models/mlc/dist/models/Sheared-LLaMA-2.7B-ShareGPT" for model "Sheared-LLaMA-2.7B-ShareGPT"
and using this command "jetson-containers run $(autotag nano_llm)
python3 -m nano_llm.chat --api=hf \
--model /data/models/clip/princeton-nlp/Sheared-LLaMA-2.7B-ShareGPT
"
it's worked!

thanks for the update
i did the change video_query.py with direct folder and model name without success for me
model=None if self.db_share_embed else '/data/models/clip/ViT-L/14@336px',
here is the command am using to run the container, working but only online, is there any parameter i can pass to force look in the models folder instead of download? txs
jetson-containers run $(autotag nano_llm)   python3 -m nano_llm.agents.video_query --api=mlc     --model Efficient-Large-Model/Llama-3-VILA1.5-8B    --max-context-len 256     --max-new-tokens 32     --video-input /dev/video0     --video-output webrtc://@:8554/output     --nanodb /data/nanodb/coco/2017


Fix build command for windows

Replaced && to & to continue execution when the 'ui' folder doesn't exist and also suppressed error "The system cannot find the file specified."

@microsoft-github-policy-service agree company="IMATRONIX S.A."


Even more hot-cold clue fixes

This is some weird diff

Not sure why there were all those non-breaking spaces in there to begin with. Just changed those in a separate commit. I can back that out if needed. :man_shrugging:


Working with Aura DB

Hello,
We have been using this client on a local neo4j instance and have upgraded to Neo4j's hosted Aura database instead. Aura appears to only support the neo4j+s bolt protocol, and I am getting a messages that the protocol is not supported by Neo4jClient. Is that correct and the client won't work with Aura or am I doing something wrong? Here is how I am injecting the client into the dependency injection container:
 services.AddSingleton(context =>
  {
      var path = config.GetValue<string>("Neo4j:Path");
      if (!path.StartsWith("http") && !path.StartsWith("neo4j")) // note with aura db this condition would not be met (starts with neo4j+s)
      {
          path = $"http://{path}:7474"; // add the neo4j protocol and port if it isn't provided
      }

      return NeoServerConfiguration.GetConfigurationAsync(
          new Uri(path),
          config.GetValue<string>("Neo4j:User"),
          config.GetValue<string>("Neo4j:Password")
      ).GetAwaiter().GetResult();
  });

  services.AddSingleton<IGraphClientFactory, GraphClientFactory>();

Here is the exception I am receiving:

I was able to get a successful connection by doing this:
services.AddScoped(context =>
{
    var path = config.GetValue<string>("Neo4j:Path");

    return GraphDatabase.Driver(path, AuthTokens.Basic(config.GetValue<string>("Neo4j:User"),
        config.GetValue<string>("Neo4j:Password")));
});

services.AddScoped<IBoltGraphClient>(x =>
{
    var driver = x.GetService<IDriver>();
    return new BoltGraphClient(driver);
});

and then injecting IBoltGraphClient instead of IGraphClientFactory. Unfortunately, if the BoltGraphClient gets disposed, the underlying driver is disposed also. So it doesn't look like I can reuse the GraphDatabase.Driver and have to register it as Scoped instead of a Singleton.

I have run into the same issue working with Aura DB.
@mcalvin-kinectify for my understanding/curiosity, the issue with a Scoped lifetime is that you have to call BoltGraphClient.ConnectAsync with each connection, right?


Support Discovery Interface

When HA has more than 1 network port available it provides the option to change which interface should be used for discovery.
Settings -> System -> Network -> Network Adapter

This integration should use the specified adapter.  Currently it is using the first one which in my case is the wrong one.  In the below example, eth0 is the admin network for the UI and net1 is the IoT network where the devices are.  I ran reload to initiate discovery during each run of tcpdump.
4: eth0@if774: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1480 qdisc noqueue state UP group default qlen 1000
    link/ether 9e:e4:3c:30:88:b8 brd ff:ff:ff:ff:ff:ff link-netnsid 0
    inet <IP_ADDRESS>/32 scope global eth0
       valid_lft forever preferred_lft forever

5: net1@if2: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP group default
    link/ether 3a:af:6e:74:6c:b5 brd ff:ff:ff:ff:ff:ff link-netnsid 0
    inet <IP_ADDRESS>/24 brd <IP_ADDRESS> scope global net1
       valid_lft forever preferred_lft forever

home-assistant-6cfcdd88c5-fc96l:/# tcpdump -i net1 port 4001
tcpdump: verbose output suppressed, use -v[v]... for full protocol decode
listening on net1, link-type EN10MB (Ethernet), snapshot length 262144 bytes
^C
0 packets captured
0 packets received by filter
0 packets dropped by kernel
home-assistant-6cfcdd88c5-fc96l:/# tcpdump -i eth0 port 4001
tcpdump: verbose output suppressed, use -v[v]... for full protocol decode
listening on eth0, link-type EN10MB (Ethernet), snapshot length 262144 bytes
20:51:29.912248 IP home-assistant-6cfcdd88c5-fc96l.4002 > <IP_ADDRESS>.4001: UDP, length 57
20:51:40.274578 IP home-assistant-6cfcdd88c5-fc96l.4002 > <IP_ADDRESS>.4001: UDP, length 57
^C
2 packets captured
2 packets received by filter
0 packets dropped by kernel
home-assistant-6cfcdd88c5-fc96l:/#

There is a PR against the main ha/core repo that fixes this issue.  I have tested this on my system and it works great.


Claire/style receipts

Create Button Component, Style Form, Add Modal Styling
Button:

Accepts types: button-primary, button-secondary, button-tertiary, hover-button
Accepts colors (and styles types accordingly)
Accepts onClick func

Modal

Applies absolute positioning to allow for scroll on overflow
Adds a header based on the title prop
Adds functionality to close

Styles receipt form.
Screenshots

CC: @clairelin135

Oh shoot I will make the modal shorter! thank you


Add ability to turn of checking for cloud provider in agent

When a host is registered in rancher, we check to see if the metadata service for AWS and (just recently) Aliyum Cloud are available. If they are, we populate some labels regarding region and availability zone on the host in rancher. These labels are there to help with scheduling decisions.
With the introduction fo the Aliyum provder and to address a user concern regarding see these requests in their firewal logs, we want to add the ability to turn this feature off.
You can do so by adding -e CATTLE_DETECT_CLOUD_PROVIDER to the docker run ... rancher/agent command.

this is a dupe of another issue. closing