Fix remaining issues with GitHub Actions

[ ] Docs deployment still hasn't been migrated
[ ] MacOS Py3.9 is failing for mysterious reasons — maybe install deps from conda?
[ ] Windows is failing in caching — also mysterious!

__________________________ test_path_length_caching ___________________________

    def test_path_length_caching():
        skeleton = Skeleton(skeleton3d)
        t0 = process_time()
        distances = skeleton.path_lengths()
        t1 = process_time()
        distances2 = skeleton.path_lengths()
        t2 = process_time()
>       assert t2 - t1 < t1 - t0
E       assert (15.84375 - 15.84375) < (15.84375 - 15.84375)

Docs deployment still hasn't been migrated

So, this means moving this functionality
https://github.com/jni/skan/blob/97a217d36ec1393b380d4a797b5b7ceb68e824ec/.travis.yml#L46-L62
into .github/workflows/build-docs.yml


ENH: Adding s3_uri to the API

This is to address https://github.com/fornax-navo/fornax-cloud-access-API/issues/9
Toy example to join the the usecase from the notebook here and the s3 astropy PR by the other fornax WG:
import fornax
import pyvo
import astropy.coordinates as coord
pos = coord.SkyCoord.from_name("ngc 4151")

query_url = 'https://mast.stsci.edu/portal_vo/Mashup/VoQuery.asmx/SiaV1?MISSION=HST&'
query_result = pyvo.dal.sia.search(query_url, pos=pos, size=0.0)
table_result = query_result.to_table()
col_name = query_result.fieldname_with_ucd('VOX:Image_AccessReference')
data_product = table_result[0]

handler = fornax.get_data_product(data_product, 'aws', access_url_column=col_name)
from astropy.io import fits
fits.open(handler.s3_uri)

resulting a lazy loaded hdulist rather than a downloaded fits file:
<class 'astropy.io.fits.hdu.hdulist.HDUList'> (partially read)

this is ready for review

@zoghbi-a - I'm using this in the demo-notebook repo, and am refactoring the notebook here to be actual tests. So I don't think it's necessary, certainly should not be a blocker for this PR.


TC-TCTL-2.3 python test

Category:
Functional
Description:
Verifies that the DUT can respond to Temperature Control Cluster attribute read commands. This test case is required only if the TL feature is supported (TCTL.S.F01(TL)). Some check examples:
Verify that for SelectedTemperatureLevel attribute DUT response contains value between 0 and 31 inclusive
Verify that for SupportedTemperatureLevel attribute DUT response contains a list of up to 32 strings, with each string length not exceeding 16 characters

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Make sure all absences during the meeting are documented

I will add them this time, but for the record. If you are absent from the meeting I will add the reason as "unknown". You can edit and specify the reason later.

Done, closing this issue


Process client packets before run schedulers

Objective

Process client packets before run schedulers, removing duplicate code.

Closing as per #596


implement database

Is your feature request related to a problem? Please describe.
Implement database
Describe the solution you'd like
Implement mongodb (most likely using mongoose) into the back-end code
Describe alternatives you've considered
We considered postgresql but decided against it due to the short time available to work on this project
Additional context
https://www.mongodb.com/

https://docs.nestjs.com/recipes/mongodb


InternalServerException

I keep getting InternalServerException with one of my accounts but not the other. It happens less than 5 requests in to my session.
Anyone else had this issue that was able to resolve it?
EDIT: It happens on a SearchAsync()

I figured it out. Didn't play enough on the secondary account to access the transfer market.

What was the problem?
I get the same Error on SearchAsyn().


feat: create a new release

Create a new release manually.

New release created manually https://github.com/XollabOS/talktometechnology/releases/tag/0.0.2


decodeImageFromDataPipe() doesn't throw if given bad data

I'm looking at _UrlFetcher.loadImage().
I was reading data from an oauth2 protected url, so it was returning a 302 Moved error pointing to https://login.corp.google.com/. This meant that the data received by decodeImageFromDataPipe() was just an HTML page instead of an image. I expected that decodeImageFromDataPipe() should have thrown an exception that could be processed by _UrlFetcher.loadImage(), but instead was returning null, which caused the ImageInfo constructor to assert instead. The failure information and the response from the web server were lost, making the problem hard to debug.
flutter doctor
[✓] Flutter (on Linux, channel master)
    • Flutter at /media/jimbe/mojossd/sysui/src/third_party/flutter
    • Framework revision 5b8677d15d (4 days ago), engine revision 7fab0c350b

[✓] Android toolchain - develop for Android devices (Android SDK 23.0.2)
    • Android SDK at /usr/local/google/home/jimbe/Android/Sdk
    • Platform android-23, build-tools 23.0.2
    • OpenJDK Runtime Environment (build 1.8.0-google-v7-122278751-122271652)

[✓] Atom - a lightweight development environment for Flutter
    • Atom installed; Flutter plugin version 0.2.2

Should be fixed by https://github.com/flutter/flutter/pull/4118


Add documentation for PINOperationQueue

We should add some documentation to the methods in the public header of PINOperationQueue

Moving this to https://github.com/pinterest/PINOperation/issues


[WIP] VSD loss implementation

Do you have pics?

Do you have pics?

Yeah I’ll upload them today

@mcallisterdavid Hi, it's an excellent work, I was wondering if you have finished it? How is the result?


[SPARK-8278] Remove deprecated JsonRDD functionality

Can one of the admins verify this patch?

I'm commenting without knowing the specifics here, but in general, do you really want to delete functionality deprecated for release X in release X+1? that's the least you can do, and may make sense, but is it urgent to remove this?

It's an internal class, not part of the public API.
On Jun 9, 2015 12:40 PM, "Sean Owen"<EMAIL_ADDRESS>wrote:

I'm commenting without knowing the specifics here, but in general, do you
really want to delete functionality deprecated for release X in release
X+1? that's the least you can do, and may make sense, but is it urgent to
remove this?
—
Reply to this email directly or view it on GitHub
https://github.com/apache/spark/pull/6728#issuecomment-110480683.

Let's wait a little bit  before we completely remove it. Usually we wait for 2 releases (i.e. in this case it'd be 1.6).

We had an earlier discussion about removing it in 1.5, so I was following up. I'm fine leaving it in for another release.

(or we can wait until the end of 1.5 -- if nobody complains at all about the new implementation, we can remove it)

@NathanHowell can we close this one for now? we can reopen / revisit it in late July.

Yep.


the installer doesnt install plasma correctly when you tell it to install plasma at least on nouveau

Describe the bug
i tried going through the NixOS installed and installing KDE plasma and then when I rebooted into my install I was dropped on a TTY with no plasma. I have a GTX 1070 and i assume it's using nouveau so that's potentially related. But the plasma-based GUI installer ISO ran just fine so it's not like plasma can't run. I think that was running under X, not wayland, which is good I don't need wayland it's fine.
Steps To Reproduce

be running nouveau (maybe, I don't know if this is actually just universally broken or if its just the nvidia card)
download the plasma-based installer for NixOS from the website
go through the installer and ask the installer to install KDE Plasma
reboot
TTY

Expected behavior
Plasma, probably
Metadata
$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.15.112, NixOS, 22.11 (Raccoon), 22.11.4286.7dc71aef32e`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.11.1`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

ok yeah we swapped the gtx 1070 for a radeon hd 7770, rebooted, and it worked just fine. so it is almost certainly a nouveau issue

This happened on my Ryzen 7's integrated graphics, exact same issue. This is the second time I've gone to install Nix to try out in the past year where the installer just can't compared to its contemporaries.

so the hd 7770 is a weird GPU that's supported by both the radeon and amdgpu drivers. by default it uses the radeon driver. if we switch it to the amdgpu by adding radeon.si_support=0 amdgpu.si_support=1 to our kernel cmdline, we get this same issue where the display manager doesn't come up properly.
we were able to get the display manager to come up by logging into the TTY and manually restarting the display manager service with systemctl, and wayland/xorg sessions both work fine with it. anyways we can add a logfile from the display manager crashing later, and we can also test it against our computer with a much newer amdgpu card. will report back


"Error: ERROR : UNRECOGNIZED OS" on Chrome in Mac OS

Any idea why i get the above error when i try to run the JS in a chrome browser?

Sorry but this library is meant to be used in node.js environment where you can create child processes. You cannot use it in the browser because your browser doesn't have access to this API for security reasons.

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


Question : How are cache invalidations handled?

Say I have a web application running on 4 servers that uses FusionCache with a Redis secondary cache and I remove a cache entry from one of the web applications.  It looks like the local FusionCache will be removed and the Redis secondary cache will have it's entry removed but how will the other 3 servers know to clear their FusionCache entries?

Hi @MartyBJones , thanks for considering FusionCache.
The scenario you are talking about is an example of why I'm working on adding a backplane (see #11), which I hope will be available soon.
Btw you caught me working on it right at this very moment 😅
Another approach which would give similar results is to have a very low memory cache duration along with a higher distributed cache duration (like requested in #30) to highly reduce the differences between the memory and the distributed cache.

The backplane sounds promising!   I look forward to trying it out!
On Fri, Nov 5, 2021 at 4:10 PM Jody Donetti @.***>
wrote:

Hi @MartyBJones https://github.com/MartyBJones , thanks for considering
FusionCache.
The scenario you are talking about is an example of why I'm working on
adding a backplane (see #11
https://github.com/jodydonetti/ZiggyCreatures.FusionCache/issues/11),
which I hope will be available soon.
Btw you caught me working on it right at this very moment 😅
Another approach which would give similar results is to have a very low
memory cache duration along with a higher distributed cache duration (like
requested in #30
https://github.com/jodydonetti/ZiggyCreatures.FusionCache/issues/30) to
highly reduce the differences between the memory and the distributed cache.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jodydonetti/ZiggyCreatures.FusionCache/issues/32#issuecomment-962222044,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA562VXK4IE3M76ELWPAVRDUKRB4DANCNFSM5HOV4C2A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Hi @MartyBJones , I'm happy to say that I've finally been able to complete the design and implementation of the backplane feature.
Please take a look here, try it out and let me know what you think so I can move forward with the final version.
Thanks 🙏

That is great news!  I will try to look at it sometime next week.
On Thu, Jan 27, 2022 at 3:39 PM Jody Donetti @.***>
wrote:

Hi @MartyBJones https://github.com/MartyBJones , I'm happy to say that
I've finally been able to complete the design and implementation of the
backplane feature.
Please take a look here
https://github.com/jodydonetti/ZiggyCreatures.FusionCache/releases/tag/v0.1.10-alpha1,
try it out and let me know what you think so I can move forward with the
final version.
Thanks 🙏
—
Reply to this email directly, view it on GitHub
https://github.com/jodydonetti/ZiggyCreatures.FusionCache/issues/32#issuecomment-1023662634,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA562VX5FOR6OIAUK5TWDIDUYG3QZANCNFSM5HOV4C2A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

Meanwhile I published an (hopefully) even better alpha2 release.

Hi all, yesterday I released the BETA 3.
Unless some big problem comes up, this will be the very last release before the official one, which will be in the next few days 🎉

Closing this since with v0.9.0 the backplane is an official feature, with official docs and more.

Jody, have you don’t any performance metrics on the new backplane?  Just
wondering how many notifications it can handle.
On Tue, Feb 15, 2022 at 3:54 PM Jody Donetti @.***>
wrote:

Hi all, yesterday I released the BETA 3
https://github.com/jodydonetti/ZiggyCreatures.FusionCache/releases/tag/v0.1.10-beta3
.
Unless some big problem comes up, this will be the very last release
before the official one, which will be in the next few days 🎉
—
Reply to this email directly, view it on GitHub
https://github.com/jodydonetti/ZiggyCreatures.FusionCache/issues/32#issuecomment-1040833950,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA562VQC7OARR44KHBQWCWTU3LDSFANCNFSM5HOV4C2A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

Hi @MartyBJones , there are no intrinsic limits on how many notifications it can handle, it wholly depends on the underlying pub/sub mechanism used.
For example using the common Redis implementation on, say, an Azure Redis Cache instance will be subjected to the limits of that infrastructure and the Redis internal limits themselves (some of which you can see here).
In general I haven't found any particular bottlenecks or problems in general regarding the pub/sub part (which is what is used in the backplane), but I don't have precise number yet.


Brightness works great, but I Still can't control the volume from my monitor

Brightness works great, but I Still can't control the volume from my monitor
Please help me fix this issue.

External Monitor: BENQ PD3220U
Connection: USB-C / Thunderbolt 3
Device: 2019 Macbook Pro touchBar

First, I suggest you can try to install this https://github.com/kfix/ddcctl
Then, run

ddcctl -O -d 1 -v 60

This command may be different for you, which the -d 1 means the first external screen of my MBP, and -v 60 means put the volume to 60%
If it doesn't work on your Monitor, it may be the issue of your monitor's firmware, I don't think MonitorControl can handle this.

Same issue here.
MBP 15 Mid 2015
macOS 10.14.6
DELL U3415W via min DP to DP link

@leondeng @ulisesyaniz Please try @womeimingzi11 's suggestion and paste your output here.

Found out that controlling the volume for my Dell U3415W works, but it just does not have effect when I've got a 3.5mm plugged into the monitor for some reason...

@mathieupost You're saying it works for you, 100% as expected, without 3.5mm plugged into your monitor?
I haven't tried with 3.5mm, but I've noticed that without, the U3415w's volume value is changed. However, it does not go into effect until I either:

Restart the display (by toggling via the monitor's power button, or otherwise putting it to sleep/waking it back up).
Manually adjust the volume settings via the OSD (i.e. increasing or decreasing the monitor's volume value by 1).

Same here Dell U2719D with 3.5 mm jack. Volume controls not working.

Found out that controlling the volume for my Dell U3415W works, but it just does not have effect when I've got a 3.5mm plugged into the monitor for some reason...

@mathieupost @r3ppy Make sure your display is set as audio output device. If the audio output device is set to anything other than the display you want to control it won't work. This is to make sure that you can still change volume when using headphones and other devices.

For anyone else running into issues, see the troubleshooting wiki:
https://github.com/the0neyouseek/MonitorControl/wiki/Monitor-Troubleshooting
Regarding the 3.5mm issue, can you provide some more info? What version MonitorControl, macOS, ...
Also, it would be really helpful if someone with the issue could run the project in Xcode and post the debug output here.

Regarding the 3.5 mm jack. The 3.5 jack is plugged into the audio output of the monitor (DELL U2719D)  rooted to a set of speakers. Monitor Control is on version 1.7.1 (Build 574) on MacOS Catalina 10.15.4 (19E266). Furthermore, the brightness works fine. However, volume controls do not actually change the volume that the monitor is outputting through the speakers.
Giovanni Telussa

Op 3 apr. 2020, om 14:07 heeft Joni Van Roost<EMAIL_ADDRESS>het volgende geschreven:
For anyone else running into issues, see the troubleshooting wiki:
https://github.com/the0neyouseek/MonitorControl/wiki/Monitor-Troubleshooting https://github.com/the0neyouseek/MonitorControl/wiki/Monitor-Troubleshooting
Regarding the 3.5mm issue, can you provide some more info? What version MonitorControl, macOS, ...
Also, it would be really helpful if someone with the issue could run the project in Xcode and post the debug output here.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/the0neyouseek/MonitorControl/issues/110#issuecomment-608397155, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOEMXN5222FPZLTYJZMHLK3RKXGOJANCNFSM4ICPT6OA.

Same issue for me. Mac OS Mojave, Mac Mini 2012, connected via mini-DP to Dell U2715H. The volumn control is re-enabled but has no effect. ddcctl has no effect either, the volume remains at 98 even after trying to change.
D: NSScreen #724850640 (2560x1440 0°) 109.00 DPI I: found 1 external display I: polling display 1's EDID I: got edid.serial: GH85D7CN0KNS I: got edid.name: DELL U2715H D: action: v: 20 D: setting VCP control #98 => 20

External Monitor: BENQ PD3220U
Connection: USB-C / Thunderbolt 3
Device: 2019 Macbook Pro touchBar

I have the same issue because I have the same exact setup. Were you able to find a solution?

Software-wise, no. Added a volume control knob in between monitors and speaker: fostex pc-1.

Op 9 mei 2020 om 00:49 heeft Rico Lajom<EMAIL_ADDRESS>het volgende geschreven:

External Monitor: BENQ PD3220U
Connection: USB-C / Thunderbolt 3
Device: 2019 Macbook Pro touchBar
I have the same issue because I have the same exact setup. Were you able to find a solution?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Software-wise, no. Added a volume control knob in between monitors and speaker: fostex pc-1.
…
Op 9 mei 2020 om 00:49 heeft Rico Lajom @.***> het volgende geschreven:  External Monitor: BENQ PD3220U Connection: USB-C / Thunderbolt 3 Device: 2019 Macbook Pro touchBar I have the same issue because I have the same exact setup. Were you able to find a solution? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

I played around with this solution (Soundflower) for the volume control and it works! [https://www.macrumors.com/how-to/use-mac-volume-keys-adjust-monitor-audio/]
I use the Monitor Display to only control the brightness. Hope the Soundflower helps. ***Also note to change the knob set to 100 so when you control it through your Mac, it's not too quiet and will have a better volume range.

@mathieupost You're saying it works for you, 100% as expected, without 3.5mm plugged into your monitor?
I haven't tried with 3.5mm, but I've noticed that without, the U3415w's volume value is changed. However, it does not go into effect until I either:

Restart the display (by toggling via the monitor's power button, or otherwise putting it to sleep/waking it back up).
Manually adjust the volume settings via the OSD (i.e. increasing or decreasing the monitor's volume value by 1).

I have the same issue with my U3415w. ddcctl successfully changed the volume, but it won't take effect until I adjust the volume via OSD by 1 value. Maybe this is the DDC implementation problem of DELL. Are there any resolutions to workaround?

Unfortunatelly this issue can't be resolved as this is a display firmware specific problem. I'll close this issue for now but let us know if we can help in any way or submit a specific issue using the new issue templates. Thank you!

Did anyone tried to update their monitors firmware version? As I saw on dell's website there was a firmware update released on 2017.


rename to expedition

Background
having jade-* naming served well in the beginning to align the project, their dependencies and goals.
As the tools are growing into their own valid tools, the close naming of projects like jade-explorer and jade-service-runner and jade-signer is getting confusing while onboarding new people.
Proposed Changes

fixed in #174


register_page_action_menu_item hook

While reading your code, I found about the wagtail_hooks.HAS_ACTION_MENU_HOOK var, and just wanted to mention that the register_page_action_menu_item hook was merged in November 2018 and is available in recent versions of wagtail :)
Thanks for making this plugin, I'm learning a lot from it.  I wish the core wagtail was also using swapper :)

Updated in ddc221fcaeb63ec26cd3dde860d76c5a3c7ee717 (and support for older Wagtail versions without the hook dropped in 91dbd2dfebe5d72417f01c004d3a93082cf238e0). Thanks!


Implement minimal Lin support

Anything related Session and System, including frames.

[ ] Implementation

Add lin frame
Add lin bus error frame
Add lin no response frame
lin_sched function
lin_comm

[x] Documentation

Session/ intf docstrings
lin enums

[x] Tests

Fixed by #182 and #183, including more than basic LIN support.
The only thing left to define is LIN No Response,.  Creating a separate issue for that.


Wasted Steady Hand II buff...?

I'm simulating Dark Chestnut Lumber, as a lv56 CRP with 467 Craftsmanship, 442 Control and 297 CP.
Here's a screenshot of my crafter attributes for CRP: https://i.imgur.com/ziXfCwq.png
I am given the following output:

Monte Carlo Example
===================
 # Action                           DUR    CP      QUA      PRG    IQ  WWYW   CTL  QINC  BPRG  BQUA   WAC       Cond   S/F
 0                                   40   297        0        0     0     0   442     0     0     0     0     Normal     0
 1 Inner Quiet                       40   279        0        0     0     0   442     0     0     0     0       Good     1
 2 Steady Hand II                    40   254        0        0     0     0   442     0     0     0     0     Normal     1
 3 Hasty Touch                       30   254        0        0     0     0   442     0     0   188     0  Excellent     0
 4 Hasty Touch                       20   254      753        0     1     0   442   753     0   188     0       Poor     1
 5 Great Strides                     20   222      753        0     1     0   530     0     0     0     0     Normal     1
 6 Steady Hand II                    20   197      753        0     1     0   530     0     0     0     0     Normal     1
 7 Hasty Touch                       10   197     1194        0     2     0   530   441     0   441     0     Normal     1
 8 Manipulation                      10   109     1194        0     2     0   619     0     0     0     0     Normal     1
 9 Name of Earth                     20    94     1194        0     2     0   619     0     0     0     0     Normal     1
10 Innovative Touch                  20    86     1194        0     2     0   619     0     0   254     0       Good     0
11 Great Strides                     30    54     1194        0     2     0   840     0     0     0     0     Normal     1
12 Steady Hand II                    30    29     1194        0     2     0   840     0     0     0     0     Normal     1
13 Byregot's Brow                    20    11     2348        0     0     0   840  1154     0  1154     0     Normal     1
14 Brand of Earth                     0     5     2348      376     0     0   442     0   376     0     0     Normal     1
Progress Check: true, Durability Check: true, CP Check: true, Tricks Check: true, Reliability Check: true, Cross Class Skills: 5, Wasted Actions: 0

Monte Carlo Result of 500 runs
==============================
                          DUR    CP      QUA   PRG   HQ%
##     Expected Value:      0     5   2537.1 376.0  14.4
##       Median Value:      0     5   2375.0 376.0  11.0
##          Min Value:      0     5   1079.0 376.0   5.0

##       Success Rate:  100.0 %

Why is Step 6 another Steady Hand II?
I understand that it wants to apply SH to the HT on Step 7, but would it not make more sense to make the HT step 6, and the SH2 step 7?
I then edited the solver to this: https://i.imgur.com/6Ehx6gX.png and hit solve, which produced this:

Monte Carlo Example
===================
 # Action                           DUR    CP      QUA      PRG    IQ  WWYW   CTL  QINC  BPRG  BQUA   WAC       Cond   S/F
 0                                   40   297        0        0     0     0   442     0     0     0     0     Normal     0
 1 Comfort Zone                      40   231        0        0     0     0   442     0     0     0     0     Normal     1
 2 Inner Quiet                       40   221        0        0     0     0   442     0     0     0     0     Normal     1
 3 Steady Hand II                    40   204        0        0     0     0   442     0     0     0     0     Normal     1
 4 Innovative Touch                  30   204        0        0     0     0   442     0     0   188     0     Normal     0
 5 Great Strides                     30   180        0        0     0     0   663     0     0     0     0     Normal     1
 6 Basic Touch                       20   170      541        0     1     0   663   541     0   541     0     Normal     1
 7 Basic Touch                       10   160      845        0     2     0   751   304     0   304     0       Good     1
 8 Manipulation                      10    80      845        0     2     0   619     0     0     0     0     Normal     1
 9 Steady Hand II                    20    63      845        0     2     0   619     0     0     0     0       Good     1
10 Name of Earth                     30    56      845        0     2     0   619     0     0     0     0     Normal     1
11 Innovative Touch                  30    56      845        0     2     0   619     0     0   254     0     Normal     0
12 Great Strides                     30    24      845        0     2     0   840     0     0     0     0     Normal     1
13 Byregot's Brow                    20     6     1999        0     0     0   840  1154     0  1154     0       Good     1
14 Brand of Earth                     0     0     1999      376     0     0   663     0   376     0     0     Normal     1
Progress Check: true, Durability Check: true, CP Check: true, Tricks Check: true, Reliability Check: true, Cross Class Skills: 5, Wasted Actions: 0

Monte Carlo Result of 500 runs
==============================
                          DUR    CP      QUA   PRG   HQ%
##     Expected Value:      0     0   3026.3 376.0  16.2
##       Median Value:      0     0   2980.0 376.0  15.0
##          Min Value:      0     0   1728.0 376.0   8.0

##       Success Rate:  100.0 %

Am I doing something wrong for the initial solver to produce 500 less quality than it should with a slight amount of manual tinkering?
EDIT: The simulator is even more broken, by turning on specialist actions when that was never a part of the original configuration. I have no idea why it selected specialist actions when editing the solver, since I am not a CRP specialist and did not select it originally.

Resetting the solver completely produced this output:

Monte Carlo Example
===================
 # Action                           DUR    CP      QUA      PRG    IQ  WWYW   CTL  QINC  BPRG  BQUA   WAC       Cond   S/F
 0                                   40   297        0        0     0     0   442     0     0     0     0     Normal     0
 1 Innovation                        40   279        0        0     0     0   442     0     0     0     0       Good     1
 2 Great Strides                     40   247        0        0     0     0   663     0     0     0     0     Normal     1
 3 Innovation                        40   229        0        0     0     0   663     0     0     0     0  Excellent     1
 4 Advanced Touch                    30   181     3251        0     0     0   663  3251     0   812     0       Poor     1
 5 Great Strides                     30   149     3251        0     0     0   663     0     0     0     0     Normal     1
 6 Advanced Touch                    20   101     4063        0     0     0   663   812     0   812     0       Good     1
 7 Careful Synthesis II              10   101     4063      150     0     0   442     0   150     0     0     Normal     1
 8 Master's Mend                     40     9     4063      150     0     0   442     0     0     0     0  Excellent     1
 9 Careful Synthesis II              30     9     4063      300     0     0   442     0   150     0     0       Poor     1
10 Careful Synthesis II               0     9     4063      450     0     0   442     0   150     0     0     Normal     1
Progress Check: true, Durability Check: true, CP Check: true, Tricks Check: true, Reliability Check: true, Cross Class Skills: 2, Wasted Actions: 0

Monte Carlo Result of 500 runs
==============================
                          DUR    CP      QUA   PRG   HQ%
##     Expected Value:      0     9   1684.5 450.0   9.0
##       Median Value:      0     9   1624.0 450.0   7.0
##          Min Value:      0     9      0.0 450.0   1.0

##       Success Rate:  100.0 %

It doesn't even do anything for the first Innovation buff before overwriting it!
What am I doing wrong?

Somebody else filed a bug about it using specialist actions when it shouldn't and eventually could only resolve it by switching browsers, which is quite mystifying to to me.
With regards to the solver putting in a wasted Steady Hand, that's due to how the optimization algorithm works. Essentially, it tries many random combinations of a sequence and finds the ones that have the best quality, mutates them by randomly swapping or changing actions and seeing which ones have improved. Rinse, repeat. It's know as a genetic algorithm, meant to mimic evolution. It doesn't truly understand what the actions mean and doesn't have any heuristic rules about not wasting Steady Hand effects etc.

You can try increasing the size of the population and the number of generations that the Solver runs for in the options. You can also click the Continue button to let it run for another round of generations either the current settings to see if it can find something better with a later random mutation, but generally it will get stuck on a result that may be "good" but not necessarily the best (aka local minima).

I did find a better outcome after clicking the continue button a few times, thanks :)

Monte Carlo Example
===================
 # Action                           DUR    CP      QUA      PRG    IQ  WWYW   CTL  QINC  BPRG  BQUA   WAC       Cond   S/F
 0                                   40   297        0        0     0     0   442     0     0     0     0     Normal     0
 1 Comfort Zone                      40   231        0        0     0     0   442     0     0     0     0       Good     1
 2 Great Strides                     40   207        0        0     0     0   442     0     0     0     0     Normal     1
 3 Innovation                        40   197        0        0     0     0   442     0     0     0     0     Normal     1
 4 Advanced Touch                    30   157      812        0     0     0   663   812     0   812     0       Good     1
 5 Great Strides                     30   133      812        0     0     0   663     0     0     0     0     Normal     1
 6 Advanced Touch                    20    93     1624        0     0     0   663   812     0   812     0     Normal     1
 7 Hasty Touch                       10   101     1812        0     0     0   442   188     0   188     0       Good     1
 8 Master's Mend                     40    17     1812        0     0     0   442     0     0     0     0     Normal     1
 9 Careful Synthesis II              30    25     1812      150     0     0   442     0   150     0     0     Normal     1
10 Steady Hand II                    30     8     1812      150     0     0   442     0     0     0     0     Normal     1
11 Hasty Touch                       20    16     2000      150     0     0   442   188     0   188     0     Normal     1
12 Hasty Touch                       10    16     2188      150     0     0   442   188     0   188     0     Normal     1
13 Standard Synthesis                 0     1     2188      338     0     0   442     0   188     0     0     Normal     1
Progress Check: true, Durability Check: true, CP Check: true, Tricks Check: true, Reliability Check: true, Cross Class Skills: 5, Wasted Actions: 0

Monte Carlo Result of 500 runs
==============================
                          DUR    CP      QUA   PRG   HQ%
##     Expected Value:      0     1   2049.8 338.0   9.0
##       Median Value:      0     1   2094.0 338.0  10.0
##          Min Value:      0     1    188.0 338.0   2.0

##       Success Rate:  100.0 %

Is there a way of inputting our own sequences and having it be locked in place, so that it doesn't try to improve upon the sequence, instead just running simulations on that exact sequence?
Maybe it would be worth it for me to try to come up with my own rotation and using the simulator to try to predict the outcome (quality rating), if possible.

On the Simulayor page you can edit the sequence to put in exactly the actions you want and see the simulation results in the tabs below. You don't have to run the solver.
The solver is used to figure out a sequence from scratch or to try and improve on an existing sequence.

Yeah that works fine, thank you! Since it's not a valid bug report (other than the browser issue, but as you say it's been reported before) I'll close this.
Thanks!

Could you comment on #133 with the circumstances under which you saw the solver using specialist actions when it shouldn't? Crafter stats, recipe and the solver seed from the log if possible.


File deletion request for build-alibaba-win2012r2-x64-2

test suite/name?
TestJstack_SE80_0
Is there an existing issue elsewhere covering this?
https://github.com/AdoptOpenJDK/openjdk-tests/issues/2220
Which machine(s) does it work on?
test-ibmcloud-win2012r2-x64-2
Which machine(s) does it fail on?
build-alibaba-win2012r2-x64-2
Do you have a link to a Grinder re-run if the test with the failure?
https://ci.adoptopenjdk.net/job/Grinder/6270

Any other details:
The issue is a 9-hour hang, when the test itself should take 4-6 seconds.
Based on debug output, we believe this problem can be solved by manually deleting this:
C:\cygwin\tmp\.com_ibm_tools_attach
Please do that and resubmit the grinder. Obliged. :)

What is that file, where does it come from, and what will stop this being an issue going forward? I don't want us to just have to regularly be deleting files manually.

That file is believed to be generated by openjdk on openj9 as part of the locking system for the attach api.
As far as I can tell, this problem was seem once, two years ago at eclipse/openj9, and did not reoccur when the file/folder was deleted.
Back then, when asked whether the test could be improved to tidy up this file in the future, pdbain had this to say:
I doubt it. Note that the Attach API already cleans up after itself in the common directory (and tries to clean artifacts left by defunct processes).

The issue here is that the malformed files were in j9build's temp directory but were owned by Administrator and had what looked like the wrong permissions.

Who is the owner, what are the permissions of the file?
@JasonFengJ9 fyi

Job rerunning on build-alibaba-win2012r2-x64-2 at https://ci.adoptopenjdk.net/job/Test_openjdk17_j9_extended.functional_x86-64_windows_xl/22/console

@Haroon-Khel Since you're working on this issue can you assign yourself to it please?

Verified fixed.


docs: Link defaults.conf from Configuration article

Let's utilise the awesome feature of hyperlinking, especially, that the Configurable Settings table does not offer displaying of the default values.

Let's utilise the awesome feature of hyperlinking, especially, that the Configurable Settings table does not offer displaying of the default values.

This link would need to work from our github.io website, so we should probably opt for a full URL rather than a relative path.

@TalZaccai

we should probably opt for a full URL rather than a relative path.

Good point. Done.


Improve CLI interface

Several options can improve the CLI interface

Remove the need to have a call to cluster as it is the most used command. This can be done via https://github.com/click-contrib/click-default-group
Revert to using tex/diagnose options instead of file arguments ?
Use a detect option to avoid filling the filenames

The first two suggestions are implemented in v0.2.3. The third suggestion is a good idea: we should also add the possibility of having multiple notion files.


fix(db): miniblocks index

We added this index to the DB manually, need to have it in the migrations

to this PR? Because why not - I don't need this history, it's only a distraction

Thanks for the swift review btw


Wrong UI information

On the View your secret site, the following text shown:

We will only show the secret once.

For secrets, that allows more than one views, this information is wrong.
Suggestion: Maybe the remaining open count should be shown instead?

Yes, that information is wrong and has not been updated after that feature. No reason not to do as you suggestion states.
Thanks for reporting!


Add /.well-known/spin/locked endpoint

Returns the locked app JSON for the running app.

Will this be exposed always? And on which path, if so? Or is the idea that we need a switch in the CLI to enable it?

Hmm...I was only thinking about it in terms of local development but its true that it shouldn't be always-on. Probably ought to look at a different way of doing this.

I like the idea for debug. Opening an issue to capture this.


border render dislocation in table example

windows btw

I encountered the same problem on the windows system. Considering that the table symbols are not adapted to windows?
With other bubbletea based projects like this

oh..I think we forgot to set the encodingchcp 65001

Hey @axeprpr what encoding are you using? I think this is related to the Lip Gloss border rendering issue we've seen when the encoding is not utf-8. I've got an open PR to answer this in our FAQ for Lip Gloss (our styling library)
https://github.com/charmbracelet/lipgloss/pull/189/files

@axeprpr and @404name were you able to fix this based on the info in our Lip Gloss FAQ? This is likely an issue based on your encoding locale. Please let me know if you still need help with this one, otherwise I will close it :)

Going to close this issue as answered. If someone has this same issue and it needs to be reopened, just let us know! :)

Going to close this issue as answered. If someone has this same issue and it needs to be reopened, just let us know! :)
Sorry, I haven't logged in for a long time


Single data point on victorybar chart

Hi,
Every hour, I'm dynamically loading data to victory chart containing VictoryAxis and VictoryBar. At midnight 01 AM, it's the moment when I've only single data point in victory bar.
My issue is -
Bar is left aligned and requirement is to make it center align. I tried with all the ways but didn't succeed. Below is the snippet
<VictoryChart
    domainPadding={20}
    scale={{ x: "time" }}>
<VictoryAxis/>
<VictoryAxis dependentAxis/>
<VictoryBar
  data={[
    { x: new Date("2018-11-09T00:00:00"), y: 2}
  ]}
/>
</VictoryChart>

Please help as I'm having delivery on my head.
Thanks

@boygirl Please help me as always. I'm having this as major defect.

@arpitjain-in you're right. this is a bug. I will look into it. In the meantime, I think unfortunately you will have to add a domain manually when there is only one data point. I made a small example that should help you:
https://codesandbox.io/s/jj601wnz83

@arpitjain-in
I've fixed this bug in<EMAIL_ADDRESS>and<EMAIL_ADDRESS>should be able to pick up these changes with a fresh npm install.

Thanks a ton @boygirl. You are my life-savior.


Python 3.11, ubuntu-22.04, revert to old tests

It turns out that the old tests replaced in #11 are working fine in ubuntu-22.04, likely due to the outdated version of wand used in ubuntu-20.04. Therefore I have reverted to the old tests.

GitHub will change ubuntu-latest  to be based on ubuntu-22.04 by the end of this month.

In ubuntu-22.04, Python 2 and pip2 have to be manually installed; ci.yml has been updated for this.

Added Python 3.11

Added .coverage to .gitignore

The rollout for ubuntu-22.04 has been pushed back to March, 1st, 2023. I think we can pin ubuntu to ubuntu-22.04 for now.

Thanks, merging!


Codegen doesn't recoginize types from external files

Hello
I'm generating server types directly from .ts files with the next config
overwrite: true
schema:
  - "./src/**/*.typedefs.ts"
  - "./src/**/*.schema.ts"
generates:
  ./src/models/types.ts:
    plugins:
      - add: "/* tslint:disable */"
      - "typescript"

my typedefs are split across several files
test.schema.ts
  type Address {
    countryCode: CountryCode
  }

  ${countryCodeTypeDef}

countrycode.typedefs.ts
export const countryCodeTypeDef = gql`
  enum CountryCode {
    FR
    DE
    SE
  }
`;

with this configuration, Apollo Server starts perfectly but when I generate server types I get next error
  ✖ ./src/models/types.ts
    Failed to load schema from ./src/**/*.typedefs.ts,./src/**/*.schema.ts:

        Unknown type: "CountryCode".
        Error: Unknown type: "CountryCode".

Expected behavior
I expect the types to be generated normally
Environment

OS: MacOS
"@graphql-codegen/cli": "^1.14.0",:
NodeJS: v12.4.0

Could you create a reproduction using the template below?
https://codesandbox.io/s/github/dotansimha/graphql-code-generator-issue-sandbox-template

@ardatan
here's the sandbox for this
https://codesandbox.io/s/github/fetis/graphql-codegen-issue/tree/master/
it's connected to this repo
https://github.com/fetis/graphql-codegen-issue

@fetis
In your case, the actual issue is just a typo.
You are using:
schema:
  - "**/*.schema.ts"
  - "**/*.typdefs.ts"

But it should be typedefs (with e). I changed it and it seems to work now.

ah, you're right. in my original code filename had a type but config was fine.
thank you for your help!


Bump starlette from 0.19.1 to 0.20.0

Runs against Starlette's ~master branch~ 0.20.0.
This version drops Python 3.6.

0.84.0 was just released. It drops support for Python 3.6, which this PR required.
Does that mean this branch can now be rebased and reviewed?
I can contribute to anything if needed, incrementally bumping starlette to its newest version will include some nice bugfixes.

Thanks @Kludex! :rocket:
I updated it a bit, raised the version to 0.20.4 and added a couple of tweaks.
Thanks for the discussion and help here everyone! :coffee:


Some User Onboarding sections are missing for the tenant admin

Describe the issue:
Following user onboarding sections are missing for a tenant admin, however is available for the super tenant admin.

Organization Self Service
Self Registration

Also the Ask Password section doesn't include all the configs for the tenant admin. It only have a limited set of configs.

How to reproduce:

Create a tenant and login to console with the tenant admin
Go to Login and Registration -> User Onboarding

Expected behavior:

Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: [e.g., IS 5.10.0, IS 5.9.0]
OS: [e.g., Windows, Linux, Mac]
Database: [e.g., MySQL, H2]
Userstore: [e.g., LDAP, JDBC]

Optional Fields
Related issues:

Suggested labels:

@ThaminduDilshan Please can you check with a latest pack whether the issue still persists. Didn't noticed with latest product

The issue was not reproduced. Hence closing the issue.
https://github.com/wso2/product-is/assets/35717390/0cb59519-f2ca-487e-81c6-cf3ef6bc1dad


AWS EKS - unable to find ifindex for interface MAC

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
On EKS 1.23, with Cilium 1.12.6.
Once in awhile pods will get stuck in ContainerCreating with errors like:

Warning  FailedCreatePodSandBox  5m22s                  kubelet            Failed to create pod sandbox: rpc error: code = Unknown desc = failed to setup network for sandbox "88b9759456ee02b38d26cc1d9d094c1dbb8ea52cb5eaee4a0c515c24589065bd": plugin type="cilium-cni" name="cilium" failed (add): unable to setup interface datapath: unable to install ip rules and routes: unable to find ifindex for interface MAC: interface with MAC 06:c1:5a:44:3c:26 not found

We are using Karpenter for autoscaling. Error seems to happen on new and old nodes at random. Replacing the node does not always fix the issue. We have set max-pod values on our nodes to a value roughly 90% of the max pods text file. The issue has happened on nodes with almost no pods, and on nodes running 100+.
Sometimes the pod seems to get stuck forever, and other times it will resolve itself after approximately 10 minutes.
Restarting the cilium pod on the node and affected pods scheduled on the node seems to have no impact.
Unsure if its relevant, but this seems to only happen on our clusters in eu-central-1. The issue has not been reported on our us-east-1 clusters, but they have different usage patterns.
Cilium Version
cilium image (stable): v1.12.6
cilium image (running): v1.12.6
Kernel Version
Linux ip-10-192-4-239.ec2.internal 5.4.226-129.415.amzn2.x86_64 #1 SMP Fri Dec 9 12:54:21 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Kubernetes Version
Client Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.4", GitCommit:"e6c093d87ea4cbb530a7b2ae91e54c0842d8308a", GitTreeState:"clean", BuildDate:"2022-02-16T12:38:05Z", GoVersion:"go1.17.7", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"23+", GitVersion:"v1.23.14-eks-ffeb93d", GitCommit:"96e7d52c98a32f2b296ca7f19dc9346cf79915ba", GitTreeState:"clean", BuildDate:"2022-11-29T18:43:31Z", GoVersion:"go1.17.13", Compiler:"gc", Platform:"linux/amd64"}
Sysdump
Generated sysdump is 180mb and will not upload...
Relevant log output
Warning  FailedCreatePodSandBox  5m22s                  kubelet            Failed to create pod sandbox: rpc error: code = Unknown desc = failed to setup network for sandbox "88b9759456ee02b38d26cc1d9d094c1dbb8ea52cb5eaee4a0c515c24589065bd": plugin type="cilium-cni" name="cilium" failed (add): unable to setup interface datapath: unable to install ip rules and routes: unable to find ifindex for interface MAC: interface with MAC 06:c1:5a:44:3c:26 not found

Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Note you can limit the sysdump collecting to only a node having this issue, with --node-list. See https://docs.cilium.io/en/stable/operations/troubleshooting/#automatic-log-state-collection for details.


Bundle script with .spec

I'm creating a bundle script using .spec files of pyinstaller.

There's still a problem:

Aparently, version.json is compiled when compiling in one file, this will broke the scripts:
https://pyinstaller.org/en/stable/runtime-information.html#run-time-information
We need them as a separate files. I think I will move using built-in python and zip them.

There's something wrong:
It is giving this error when executing it:
Error loading Python DLL 'C:\Dev\hoi4-presence\dist\python311.dll'.
LoadLibrary: The specified module could not be found.

It is giving this error when executing it:

It is only setup.exe

It is due to the MERGE line
https://pyinstaller.org/en/v3.3.1/spec-files.html#example-merge-spec-file

All good


CSS

#CSS
##User Story
As a boot camp student
I want the prework notes to be structured on a webpage
So that I can easily find and read the information
##Acceptance Criteria
GIVEN a Prework Study Guide website
WHEN I view the study guide
THEN I see a dark blue header and footer, and four boxes with a shadow

Resolved as part of PR #8


How can i infer a low resolution image?

I have finished the training process, how can i use the trained model to get a high resolution text image?

Same Question!

+1

I have finished the training process, how can i use the trained model to get a high resolution text image?

请问你能达到论文所说的精度吗，可以提供一下你的预训练模型吗谢谢

大佬来个解决方法啊

+111111111


Release Prep to Next Version of CDK Observability Accelerator

Issue #, if available:
Description of changes:
Release Prep to Next Version of CDK Observability Accelerator
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/do-e2e-test single-new-eks-opensource-observability deploy

/do-e2e-test single-new-eks-opensource-observability deploy

/do-e2e-test single-new-eks-opensource-observability deploy

/do-e2e-test single-new-eks-opensource-observability destroy

Ignoring the E2E error.


OCPBUGS-2446: Expose an error condition if an error is repeated more than 15 times in a row

In an effort to improve the observability of errors, this PR sets an error condition on the CPMS status when the reconciler returns an identical error 15 times or more in a row. This happens after approximately 80s since the error first occurs.
This should help reveal spurious errors such as those like when we cannot create a machine because the validation webhooks are failing.
I've manually tested this and it seems to be working as expected.

/test lint

/lgtm

/label qe-approved

/retest-required

/approve
/retest-required

/retest-required


Possible to use without hijacking default pdb?

Originally reported by: reckoner (Bitbucket: reckoner, GitHub: reckoner)

Hi,
I really love this debugger, but unfortunately because it interferes with some other code, I cannot have it hijack the default pdb. Is there a way to stop this particular feature and just use the debugger explicitly ( without implicit pdb hijacking).
Thanks!

Bitbucket: https://bitbucket.org/antocuni/pdb/issue/39

You can use pdb.pdb.set_trace(), if that is enough?


Prune yesterdays collections for fhact in fh-messaging

Jira link's
https://issues.jboss.org/browse/RHMAP-19375
What
In cases where the fh-messaging pruning job fails on a particular day, we can end up with situations where the collections are not pruned and live on forever or until manual intervention is undertaken.
Why
Reason : ( FHOPS needs )
How
The pruning job will now also run for the previous day also, each time it is executed.
Verification steps
Info

The fh-messaging configuration metrics_rollup_job daysToKeep defaults to 31 days in production
fh-messaging uses the fh-reporting database in Mongo in the MBaaS project.
The admin password can be retrieved from the mongodb-admin-password key inside the mongodb-keys config-map in the MBaaS project.

Verification

Deploy changes to a cluster.
Connect to the Mongo primary pod in the replica set in the MBaaS project. eg: oc rsh mongodb-1-1-wt99t
Launch the mongo client: mongo <IP_ADDRESS>/admin -u admin -p
use fh-reporting use the database
show collections list the collections, and make note of the fhact_yyyymmdd collections
Connect to one of the fh-messaging pods
Run the pruning command bash bin/fh-msg-process $(date '+%F') NO_IMPORT config
show collections once more on the Mongo replica primary. And make note of the fhact_yyyymmdd collections. Collections from dates more than 31 days ago should no longer be listed.

@davidffrench can you take another look? Working on updating unit/integration tests now.

Hmm not sure how this happened?? I made a change and pushed to my fork, as I would normally??

https://github.com/feedhenry/fh-messaging/pull/60 following on in this PR.


Navigation theme configurability

Make default navigation current page marker themable
Theme option to use navigation menu boxes with border

Changes Unknown when pulling 2c043122e16b1ffd868a5b81e1af85545b65accd on tf:navigation-theme-configurability into ** on codevise:master**.


[WIP] spark: load config resolver

Do not merge. Still testing it in https://github.netflix.net/corp/bdp-apache-spark/pull/1254

Found another way to set batch.executorId in https://github.netflix.net/corp/bdp-apache-spark/pull/1257/files#diff-7f3f6f8b1c65a0a1f984854d7cb9d97e848c07b96278513a519bde658331a37e.
I don't find other use case for a custom ConfigResolver.
Abandon this PR.


Build pipeline

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: bms12 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Unable to use $gates variable in Vue 3 Composition API?

E.g. in setup() function?

Hi @musiwei! Were you able to find a solution with Vue 3?

@mreduar not yet. I was hoping the mighty Internet would solve this puzzle :(

I am looking for other alternatives, this seems to be abandoned.

Hi all,
vue-zo An alternative that can be used with composition-api and Pinia.

Hi all, vue-zo An alternative that can be used with composition-api and Pinia.

Hello, it looks good. But it does not have any documentation. Do you have a basic guide on how to use it? Or is it used exactly like vue-gates?

Hi all, vue-zo An alternative that can be used with composition-api and Pinia.

Hello, it looks good. But it does not have any documentation. Do you have a basic guide on how to use it? Or is it used exactly like vue-gates?

Docs are there... https://github.com/thonymg/vue-zo/tree/master/docs

@flashmatt I might be lost but where do you find how to use $gates variable in composition-api?

Hi all, vue-zo An alternative that can be used with composition-api and Pinia.

I might be lost but where do you find how to use $gates variable in composition-api?

I might be lost but where do you find how to use $gates variable in composition-api?

I started using vue-zo and it no longer uses that variable, but a function that helps you to validate it on the script side with composition api.


Re-instance audio previews during resource re-import

I think this fixes #27800 in most cases. It's not really a complete solution because if the audio stream preview is playing audio, it's still possible to get a use-after-free if the audio thread does a mix after AudioStreamOGGVorbis::clear_data and before AudioStreamPreviewGenerator::_update_audio_streams. I think I have a fix for #26964 that should at least prevent a crash in that situation, but it's still necessary for the preview window to re-instance all of its preview playbacks, so this PR will be necessary from a usability perspective.

This doesn't seem to work if the audio is being played back in the editor's audio preview window, but it does work otherwise. I have some improvements that should deal with the case where it's playing. I'll probably push those later tonight pacific time and make a PR shortly after.

I think there's some behavior here I don't understand. This crash may actually be preferable to what I'm observing, which is that saving a project after having renamed an ogg file actually causes it to fail to open. I'm switching this to draft to make sure it doesn't get merged, because it's true that it fixes a crash but I'd rather crash Godot than corrupt a project.

This is fixed in 4.0 as far as I can tell, so no need for this to be around anymore.

I guess this could still be worth merging in the 3.x branch for 3.5?


Add timer from rov-22

Resolves #81

Why are you setting a comical amount of 1 second timers as opposed to the full length timer.

The display needs to be updated every second, so I set a timer with an interval of one second. There is only one timer. If you're worried about drift, we could track the system time when the timer was started and then vary the length of the timer to account for any lag, but I don't really think it's going to have an issue keeping up.


Are consumers able to override default Codable conditional conformances?

I have a user id that, for legacy reasons, can come back as either a String or an Int and when adding Tagged to handle this case I was hoping to extend Tagged for this type specifically and add a custom Codable implementation to clean this up. The only problem is that the runtime always calls the default conditional conformance implementations rather than my custom ones.
This is a more general Swift question perhaps, but is there a way to override this implementation and make sure the runtime calls my version? Here's the code:
public struct User: Codable {

    public enum UserIdTag {}
    public typealias Id = Tagged<UserIdTag, String>

    let id: Id
}

extension Tagged where Tag == User.UserIdTag, RawValue == String {

    public init(from decoder: Decoder) throws {
        let container = try decoder.singleValueContainer()

        do {
            try self.init(rawValue: String(container.decode(Int.self)))
        } catch {
            try self.init(rawValue: container.decode(String.self))
        }
    }

    public func encode(to encoder: Encoder) throws {
        var container = encoder.singleValueContainer()
        try container.encode(Int(rawValue))
    }
}

I don't think this is possible unfortunately :/
In your specific case you could decode the id as an Tagged<User, Either<String, Int>>, and then make a computed property on User for the Tagged<User, Int> version that you will use everywhere.

That is a good idea, thanks for the speedy response. I'll probably tackle this in my second round of Tagged-related refactors.


Add digest subtypes and update dependencies

This adds digest subtypes, so that we can ensure that different parts of the code push the correct types of digests.  I used a rather tricky macro to implement this.
I also updated dependencies and added a script for doing so.

any updates here? looking stale...


[LUM-739] - DFract -> Move from Proposal to Tx based minting

Issue / Context
The goal of this feature is to remove the need for weekly proposals for DFract. The idea is to introduce two new params, management_address that will be the mint destination address and is_deposit_enabled to decide wether or not a user can deposit in the dfract module.
Implemented solution

[x] Change WithdrawAndMint proposal into an UpdateParams proposal with an UpdateParams handler
[x] Add a new tx based message WithdrawAndMint
[x] Unit tests

Param should be named management_address and not withdrawal_address


Unsupported child: INLINE_DRAWING

I'm getting the following error while parsing a Google Doc.
Paragraph 438 of type PARAGRAPH has an unsupported child: INLINE_DRAWING index=438 (line 155, file "Code")

This is really annoying error.

After line 154 I added:
} else if (t === DocumentApp.ElementType.INLINE_DRAWING) {
      textElements.push(' (NOTE: INLINE_DRAWING NOT SUPPORTED)');


Add task path to task output build cache key

This has the side-effect to display the task name for every failure involving a task output build cache key.

Branch build: https://builds.gradle.org/viewQueued.html?itemId=7528085

I am getting
Parallel execution is an incubating feature.
Build cache is an incubating feature.

BUILD SUCCESSFUL in 3s
1 actionable task: 1 executed

A build scan cannot be produced as an error occurred gathering build data.
Please report this problem via https://gradle.com/scans/help/plugin and include the following via copy/paste:

----------
Gradle version: 4.2-20170807142659+0000
Plugin version: 1.9-20170807095145-master

java.lang.UnsupportedOperationException
        at org.gradle.api.internal.changedetection.changes.NoHistoryArtifactState$1.getInputs(NoHistoryArtifactState.java:57)
        at org.gradle.api.internal.tasks.execution.ResolveBuildCacheKeyExecuter$OperationResultImpl.getClassLoaderHash(ResolveBuildCacheKeyExecuter.java:142)
        at com.gradle.scan.plugin.internal.a.o.r.a(SourceFile:32)
        at com.gradle.scan.plugin.internal.c.e.run(SourceFile:62)

----------

When trying to publish a build scan for baseServices:clean. Seems like there is still a problem. See also the failing test: https://builds.gradle.org/viewLog.html?buildId=7527840&tab=buildResultsDiv&buildTypeId=Gradle_Check_Quick_Java8_Oracle_Linux_core

FTR, this is the build we are waiting for: https://builds.gradle.org/viewQueued.html?itemId=7590378


The number of monsters does not change with player count

I found that when I changed the number of characters the number and type of monsters did not change.  Is that intentional?  Or is that a bug?  I am not sure.

Hi @amusedleg , it certainly should change 🙁
Can you let me know what scenario you were playing, and what number of players you changed from and to?

Closing this until there's more info


Update AWS CCM

What type of PR is this?
/kind feature
What this PR does / why we need it:

Update AWS CCM to v1.24.0, v1.23.1, v1.22.2, v1.21.1, v1.20.1
Update AWS EBS CSI driver to v1.6.2

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #2011
Does this PR introduce a user-facing change?:
Update AWS CCM to v1.24.0, v1.23.1, v1.22.2, v1.21.1, v1.20.1
Update AWS EBS CSI driver to v1.6.2

/approve
/lgtm


BUG: migrate the audit+prelude howto

Original location: https://people.redhat.com/sgrubb/audit/prelude.txt

Prelude support has been dropped from the audit repo.

It probably doesn't make sense to migrate the HOW-TO :)


Spanish translation (auth and app)

This pull request includes Spanish translations for strings in the Firebase UI project. I have translated strings from Firebase UI Auth and the example app. This way, developers don't need to worry about translating library strings (like I did before).

@javmarina thanks for this contribution!  Appreciate the effort here.  Since this is one of the languages we support on firebase.google.com (see #77) am inclined to merge, but we need a few things first:
@alfongj can you check out the Spanish here?
@morganchen12 how hard is it to port this to iOS?

@samtstern It's pretty simple to port this to iOS. I'm going to send a PR there based on this one and another one for mime

Any update on this??

@javmarina sorry for the lack of updates here, we put off translations while working on the 1.0 release and are now back to discussing how to do them best.

OK, thanks!

When do you plan to add translations? I currently use my own in my projects but it's better to include them inside the library, available for every developer. I'm willing to translate the other strings (some of them have been added/modified).

@javmarina I have decided to close translation pull requests.  They've been sitting around for a while and the silent, infinitely-open PR is not fair to you nor is it useful to us.  For now you should continue to maintain translations as part of your own app or as part of a library fork.
Eventually, we will get official translations for FirebaseUI for the major languages that Firebase supports.  When we go through that process, I will definitely provide the contents of this Pull Request as suggestions to the translators (there is a place in the system for that).
Thank you for taking the time to contribute!  We do appreciate it, even if we sometimes fail to demonstrate our appreciation.

Don't worry about that. I understand the situation and am glad you explained it to me. This PR should be closed if it interferes with your current work. I just wanted to help developers but it is not an issue to maintain those strings on my own.


Detailed platform counts error (in production)

The query https://api.aiod.eu/counts/platforms/v1?detailed=true fails with {   "detail": "Unexpected exception while processing your request. Please contact the maintainers: type object 'Platform' has no attribute 'platform'" }
I have not tested the reproducibility of this bug in other environments.

This is a duplicate of already resolved issue #365


chore: fix some shellcheck problems

Update shellcheck to the latest 0.10.0
Run shellcheck on the install script. This was not the case until now, probably by mistake.
Delete shellcheck.sh and instead explicitly list the files we're checking in the Makefile target.
Fix some warning and info messages in our scripts.

A nit, because I'm not sure I understand: do these problems break anything or is it just improving life quality? Nevertheless, LGTM

They're either:

Removing dead code
Fixing actual minor bugs
Making the code more robust, for example by preventing it from swallowing errors


Remove contain property

This change: (check at least one)

[ ] Adds a new feature
[x] Fixes a bug
[ ] Improves maintainability
[ ] Improves documentation
[ ] Is a release activity

Is this a breaking change? (check one)

[x] Yes (visual)
[ ] No

Is the: (complete all)

[x] Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
[x] Test suite(s) passing?
[x] Code coverage maximal?
[ ] Changeset added?
[ ] Component status page up to date?

What does this change address?
Fixes #585

do we want to update this readme recommendation?
https://github.com/ithaka/pharos/blob/fix/remove-contain-property/docs/development/anatomy-of-a-component.md#css-containment

@chrisjbrown yeah, good call. Meanwhile, this first pass has in fact caused visual regressions so will need to examine this a bit more critically.

Closing in favor of #614


Added Feature/french

Added French locale file
Added 'fr_FR' in the array of supported locales
Modified TestLocaleBase to avoid using pyICU

This change is

Current coverage is 77.52% (diff: 100%)

Merging #200 into master will increase coverage by 0.38%

@@             master       #200   diff @@
==========================================
  Files            14         15     +1
  Lines          1570       1597    +27
  Methods           0          0
  Messages          0          0
  Branches        288        288
==========================================
+ Hits           1211       1238    +27
  Misses          266        266
  Partials         93         93

Powered by Codecov. Last update 39405f7...cc8ad4a

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

thanks!


Better support of parallel runs when spawning multiple .executes

Until parallel execution is properly implemented in Parcels (see #17), one way that users can run multiple processes on a core is to simply spawn a number of .execute() statements, for example in a bash script.
However, the creation of the temporary directory in compiler.py can then go wrong, as all .execute() will create the same directory. While before this PR we used to check whether this temporary directory already existed, the slight lag time it takes to call makedirs(directory) sometimes meant that the directory was created while another process was creating it too. This caused an error.
To fix this, this PR uses the exist_ok argument to directory creation. Since that isn't default on python2, we use a solution suggested at
https://stackoverflow.com/questions/45283093/how-to-walk-around-exist-ok-missing-on-python-2-7

And we won't have the problem of writing the same file just afterwards?

The writing issue can relatively easily be circumvented by making sure that each .execute() process writes to its own file (with a different filename.
When we support 'proper' parallelisation, then I think we need to look into the writing more closely. But for now I don't think it's a priority


I am not able to run the server locally

I am trying to run the Cadence Web server on my local machine using Docker Compose, but I'm encountering an issue where it doesn't start successfully. While troubleshooting, I noticed that there were no open ports in the Docker container, so I manually opened port 8081. However, when I attempted to access localhost:8081, I encountered the error message displayed in the image below.

Hello, we recommend using Visual Studio Code's Dev Containers extension to start the Docker container.
We've updated the documentation with instructions on developing using Dev Containers, so you can try to follow those to see if it works for you.

Opening the cadence on the first start, its accessible on http://localhost:8088/ not port 8081
fragment from devcontainer.json
	// Use 'forwardPorts' to make a list of ports inside the container available locally.
	"forwardPorts": [8088,8090],


Focus doesn't get lost when same page is loaded with different query params

next page link will remain active when next page is opened with new content

One solution is to use Router events like below -
document.activeElement.blur()
        })

but then we have to set the focus to the body so that by keyboard the original tab-index flow is maintained as when the page reloads.
Not making this change, as this might be too nit-picky or unnecessary.

Adding tabindex=0 to body solves this issue.


fix: Only display valid Linode types for LKE node pools

This pull request alters the Linode LKE node pool type filtering logic to only include valid instance types. Previously the filter would allow certain invalid types and exclude valid types (highmem).
See: https://www.linode.com/docs/api/linode-types/#type-view__responses

https://github.com/rancher/rancher/issues/38119


Support retrieving flows of multi-tables of ovsflows command

When debugging traffic paths in OVS, we need to check flows in multiple tables most of the time. To make the debugging more convenient, this commit makes the ovsflows command accepting multiple tables instead of one.

Codecov Report

Merging #1708 (2f43e4f) into master (9d3d10b) will decrease coverage by 22.85%.
The diff coverage is 38.14%.

@@             Coverage Diff             @@
##           master    #1708       +/-   ##
===========================================
- Coverage   63.31%   40.46%   -22.86%
===========================================
  Files         170      107       -63
  Lines       14250    13328      -922
===========================================
- Hits         9023     5393     -3630
- Misses       4292     7455     +3163
+ Partials      935      480      -455

Flag
Coverage Δ

kind-e2e-tests
?

unit-tests
40.46% <38.14%> (-0.82%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

cmd/antrea-agent/agent.go
0.00% <0.00%> (ø)

pkg/agent/agent.go
12.20% <0.00%> (-36.51%)
:arrow_down:

pkg/agent/agent_linux.go
0.00% <0.00%> (-100.00%)
:arrow_down:

...g/agent/cniserver/interface_configuration_linux.go
5.79% <0.00%> (-14.44%)
:arrow_down:

pkg/agent/cniserver/pod_configuration.go
34.52% <0.00%> (-19.24%)
:arrow_down:

pkg/agent/config/node_config.go
0.00% <0.00%> (-100.00%)
:arrow_down:

...gent/controller/noderoute/node_route_controller.go
32.57% <0.00%> (-13.90%)
:arrow_down:

...agent/controller/traceflow/traceflow_controller.go
0.00% <0.00%> (-82.70%)
:arrow_down:

pkg/agent/proxy/proxier_linux.go
0.00% <0.00%> (-25.00%)
:arrow_down:

pkg/agent/querier/querier.go
66.66% <0.00%> (-21.50%)
:arrow_down:

... and 166 more

Codecov Report

Merging #1708 (2f43e4f) into master (9d3d10b) will decrease coverage by 22.85%.
The diff coverage is 38.14%.

@@             Coverage Diff             @@
##           master    #1708       +/-   ##
===========================================
- Coverage   63.31%   40.46%   -22.86%
===========================================
  Files         170      107       -63
  Lines       14250    13328      -922
===========================================
- Hits         9023     5393     -3630
- Misses       4292     7455     +3163
+ Partials      935      480      -455

Flag
Coverage Δ

kind-e2e-tests
?

unit-tests
40.46% <38.14%> (-0.82%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

cmd/antrea-agent/agent.go
0.00% <0.00%> (ø)

pkg/agent/agent.go
12.20% <0.00%> (-36.51%)
:arrow_down:

pkg/agent/agent_linux.go
0.00% <0.00%> (-100.00%)
:arrow_down:

...g/agent/cniserver/interface_configuration_linux.go
5.79% <0.00%> (-14.44%)
:arrow_down:

pkg/agent/cniserver/pod_configuration.go
34.52% <0.00%> (-19.24%)
:arrow_down:

pkg/agent/config/node_config.go
0.00% <0.00%> (-100.00%)
:arrow_down:

...gent/controller/noderoute/node_route_controller.go
32.57% <0.00%> (-13.90%)
:arrow_down:

...agent/controller/traceflow/traceflow_controller.go
0.00% <0.00%> (-82.70%)
:arrow_down:

pkg/agent/proxy/proxier_linux.go
0.00% <0.00%> (-25.00%)
:arrow_down:

pkg/agent/querier/querier.go
66.66% <0.00%> (-21.50%)
:arrow_down:

... and 166 more

It would be nice to add -T examples in antctl.md showcasing this. If I read correctly it also supports mixture of table num and name in the comma separated list right?

Thanks, just added two examples.

It would be nice to add -T examples in antctl.md showcasing this. If I read correctly it also supports mixture of table num and name in the comma separated list right?

Thanks, just added two examples.

/skip-all
Skip Jenkins, since tests do not cover this commit.

/skip-all
Skip Jenkins, since tests do not cover this commit.


CLI file matcher should respect explicit 'riff create '

This is related to https://github.com/projectriff/command-function-invoker/issues/10 but applies to the riff CLI in general, not just the command invoker.
After installing the command function invoker yaml, all matchers stop working when used with riff create or riff init.
Suggestion: Specifying an invoker explicitly with say riff create node or riff init node should force matching on just node-invoker file extensions, and is more consistent and easier than using --artifact which might still be ambiguous across invokers.

This was the intended behavior, will look into why it's not matching correctly.


Saga Support

Your platform has been working very nicely! I appreciate all the thought put into it.
One thing I'd love to see is Saga support. Sagas tend to be a lot easier to manage then the more 'thunk' like pattern (https://github.com/redux-saga/redux-saga), especially when you want to chain events.
I got very close to getting them working with the platform (thanks to all the middleware hooks etc). But there is a missing piece that revolves around saga's working server side: https://github.com/redux-saga/redux-saga/issues/13.
Saga's Resolution: https://github.com/redux-saga/redux-saga/issues/255
Essentially server side rendering and Sagas have some challenges, but they have a special 'END' event that needs to be triggered at specific point in the code.
More specifically

Run Saga Middleware (Already a hook for this)
renderToString happens
Call dispatch(end)

Example code from the saga issue 255 linked above:
       const rootTask = sagaMiddleware.run(rootSaga)

      // this will cause the universal Saga tasks to trigger
      renderToString(
         <Root store={store} renderProps={renderProps} type="server"/>
      )
      // notify Saga that there will be no more dispatches
      // this will break the while loop of watchers
      store.dispatch(END)

Another challenge that I had mostly worked around was the fact that Saga's don't return promises by default which are required by the Preload decorators. But I created a helper file that can take care of that because when you call this.sagaMiddleware.run(common) it returns the associated promise, which I then save and can be returned in the 'preload' methods. (Tho there might be some trickery I hadn't gotten to around preload running client side?)
In summary: Saga support would be awesome :)

I can expose any extra hooks this redux-saga library needs.
For that you'll need to tell me exactly which hooks are missing for you and at what point in time should they be exposed.
I'm not familiar in any way with that library.

I'm trying to figure out exactly where in the react-isormorphic-render code this should live.
I think here?
https://github.com/halt-hammerzeit/react-isomorphic-render/blob/master/source/page-server/render.js#L194
It is essentially after all the preload methods have been triggered you have to run the store.dispatch(end) so that the saga promises will close out and allow the preloads to wrap up and the content to render.

Is the only missing thing is running store.dispatch(end) in the end of server-side rendering?
If store.dispatch(end) is run on client side won't it break anything.

As for the place I'd suggest adding a hook here:
https://github.com/halt-hammerzeit/react-isomorphic-render/blob/master/source/redux/server/render.js#L62
It's after all preloads but before ReactDOM.renderToString().
Should it await store.dispatch(end)?

That should work!

We want to only END them server side
We want to END after all the preloads are executed

The best would be to have a hook there that provided the store.
Thanks :)

Try the newest version and beforeRender({ dispatch }) hook in rendering service settings
beforeRender({ dispatch }) { return dispatch(END) }

(I didn't test it)

Awesome thank you! I will give it a go :)

How is saga integration possible now that beforeRender has been removed?  I can't seem to find a place step in after reduxMiddleware to run sagas.

@chris-allen
The old beforeRender function was called only when rendering server-side after preloads have finished.
https://github.com/catamphetamine/react-website/blob/0e11dbaac18a177bfbd39b3541d5c4ab42922914/source/redux/server/render.js#L42-L50
What is your feature request?
I don't know what "saga"s are and I didn't work with them.


build(backend): use Babel for local dev as well

This'll make it all consistent :sparkles:
Note: While the local server starts for me, currently every request fails, whether logged in or not, whether guarded endpoints or just terms-and-conditions. However, this is also the case for me on master. Maybe I have something messed up in my setup, either way it's on master and not caused by this  PR :sweat_smile:


Segmentation fault: 11

Dear author,
I am trying to run the code and have encountered the follow issue
The following command works:
$ python test.py --test_dir ../data/msmd/msmd_test --test_piece Anonymous__lanative__lanative_synth --plot --gt_only
but running the trained model gives "Segmentation fault:11"
$ python test.py --param_path ../trained_models/cyolo/best_model.pt --test_dir ../data/msmd/msmd_test --test_piece Anonymous__lanative__lanative_synth --page 0
Message as follows and model does not run:
Conditioning: ContextConditioning | Parameters: {'n_lstm_layers': 1, 'activation': 'nn.ELU', 'zdim': 128, 'normalize_input': True}
Using input normalization!
Segmentation fault: 11
Please advise.

Hi!
Could you please provide me with some more information regarding the system you are running this on.

macOS 10.14.6
Python 3.9.13

Did you install the conda environment? I specified python 3.7 in there.
With the provided environment file I'm able to run python test.py --test_dir ../data/msmd/msmd_test --test_piece Anonymous__lanative__lanative_synth --plot --gt_only on my Mac without getting a segmentation fault.


[CP] Make sure FFI works on standalone Mac OS X

Commit(s) to merge
6c92ce6049223fbab9f8d18fdc17f698e6b8b338
Target
stable
Prepared changelist for beta/stable
https://dart-review.googlesource.com/c/sdk/+/335881
Issue Description
Trying to use FFI callbacks on Mac OS X using standalone dart binary causes a crash due to code signing violation. This is a regression caused by bd57548 which changed how callback pages are allocated, but did not accomodate for Mac OS X specific requirements (i.e. that executable memory should be allocated with MAP_JIT flag when hardened runtime is active).
The issue slipped through testing because we did not have coverage for hardened runtime enforced behaviors on CI - but we have now addressed this issue (see https://github.com/dart-lang/sdk/commit/4ce23629ebb08d644ef55c624c8781e2dbe9a300 and https://github.com/dart-lang/sdk/commit/906ae3a9a65b64b219717b688f2918a8d4721e2f)
What is the fix
Allocate executable memory for callback pages using MAP_JIT flag on Mac OS X.
Why cherry-pick
Users can't use FFI callbacks on Mac OS X in standalone CLI Dart.
Risk
low
Issue link(s)
https://github.com/dart-lang/sdk/issues/53928
Extra Info
No response

@athomas it is not clear to me if I should edit CHANGELOG.md or not given that 3.2 is not yet released.

Do you want this to be in 3.2.0? Or 3.2.1?
if you want it in 3.2.0, you don't need the changelog. Add the Changelog-Exempt footer with an explanation and loop in @itsjustkevin who needs to reauthor the 3.2.0 release after you submit it (ideally ~today/~tomorrow since I think we're set to ship 3.2.0 on wednesday)
if you want it in 3.2.1, wait until 3.2.0 is out and then just follow the normal procedure of adding a changelog entry.

It would be nice to rebuild 3.2.0 if possible and not ship it with a known crasher.

@mraleph is this a must have or nice to have?  We are a bit late in the cycle and I am worried about introducing risk.  However if we are okay with it, we can make it happen.  I defer to @mit-mit

@itsjustkevin Given that FFI is effectively broken on 3.2 standalone I would classify it this as must have.
I have also made sure that we actually have test coverage for the fix. We managed to regress with https://github.com/dart-lang/sdk/commit/bd57548de127c0b7570f985d1969e54718474963 because we thought we have coverage, but we did not have it. This is now fixed.

@mraleph please get a review on the CL so we can get the process started.

@itsjustkevin done.

@mraleph is this only macOS, or also iOS? If only macOS, I think we can consider doing a quick patch release (3.2.1) if it's too late to re-open the 3.2 release?

@mit-mit I think it should only be affecting standalone dart on Mac OS X. I think nothing else is affected (e.g. Flutter targeting iOS & Mac OS X should work in debug and release).
That being said it is unclear why we would want to release something that is broken if we could still quickly patch it before release.

If we have time to patch it, then yes let's do that. But I would not postpone the planned releases if we're not able to patch.

From the feedback here, it looks like patching in is the path, I’m going to mark this as approved.
@mraleph please submit, I’ll do my part and pass it on to the Flutter release eng team.

Sounds like y'all are on top of this. Just so you know how to react to these situations in general: Our infrastructure and procedures do support even last minute urgent patches prior to publication (which is the point of no return). It in practice take a couple of hours to land the change and then the release has to be reauthored and rebuilt. It won't delay the release unless we're literally on the release day. There may be additional delays on the Flutter side that I wouldn't know about, which doesn't affect the standalone Dart release.
From a project point of view, those new stable artifacts are largely untested of course, so they introduce a bit of risk that the patch is somehow bad or has unintended consequences. That's the project policy tradeoff you just made, weighing well known breakage against potential unknown breakage, or whether to just postpone the release to do the testing. The systems can handle it all so you can always decide between these options :)


feat: Expose TextEncoder and TextDecoder

This PR has for vocation to address jsdom/jsdom#2524 by complementing this package as suggested in jsdom/jsdom#2928.
This PR transforms the repo to adopt a structure similar to whatwg-url.

Hi, thanks for starting this. As a start, I'd say don't bother with some of the changes, like those to the license (LICENSE.txt), ESLint (.eslint*), Travis CI (.travis.yml), and Git configuration files (.git*) unless you have to (e.g., I realize you will have to add lib/TextEncorder.js to the .gitignore file, but you probably shouldn't change /node_modules/ to node_modules/ as it's outside the scope of this PR). You could remove the live viewer for now (live-viewer/) – if you'd like to make one for this package you could always do so after TextEncoder/Decoder gets implemented!
Additionally, I'd like you to remove the package-lock.json. We at jsdom mostly use Yarn over npm (except for whatwg-url), and as you can see we already have a yarn.lock file in this repo. Let's keep that the case.

I have started an beginning implementation utilising whatwg-encoding.js, please let me know if I'm on the right track.
Regarding your original comment, as far as I can see package-lock.json, is indeed present in this package.
https://github.com/jsdom/whatwg-encoding/blob/master/package-lock.json
I'm happy to change and use Yarm instead, but this seem to be slightly out of scope.
On that same line, I have converted tests using new Buffer() to using Buffer.from(), this also feels a bit out of scope, should I revert ?

@TimothyGu I have been able to look at this in a bit more detail. There should now be support for streams as well. There seem to limitations to bringing a compliant version up. Of those, here are some of the tings right now :

It turns out a lot of testing from https://github.com/web-platform-tests/wpt/tree/master/encoding isn't usable as such as it rests on testing functions not present in the current version of the testharness. These could be copied in this repo, what do you suggest ?

The iconv-lite package doesn't support fatal-like functionality. While we could scan the output of the decoding for [0xef, 0xbf, 0xbd], that exact sequence could have been validly input in and the strategy to deal with that is unclear. What are your thoughts ?

There seem to be multiple problems with iconv-lite not supporting a set of encodings defined in https://encoding.spec.whatwg.org/encodings.json. That is the case for x-mac-cyrillic for example.

iconv-lite seem to fail some of the conversions. For example iconvLite.decode(new Uint8Array([0x00, 0xd8]), 'utf-16le') ought to produce the same as new TextDecoder('utf-16le').decode(new Uint8Array([0x00, 0xd8])) but doesn't. Any pointers ?

Thanks for doing the additional investigation!

There should now be support for streams as well. I have had to stop relying on the decode function defined in whatwg-encoding.js because I could not see how to cleanly utilize it.

That's fine. It doesn't use decode in the spec either.

There seems to be limitations to bringing a compliant version up. Of those, here are some of the things right now :

It turns out a lot of testing from https://github.com/web-platform-tests/wpt/tree/master/encoding isn't usable as such as it relies on testing functions not present in this repo's (or whatwg-url's) current version of the testharness.js. Those new scripts could be copied in place, what do you suggest ?

I think we can copy some of those here.

The iconv-lite package doesn't support fatal-like functionality. While we could scan the output of the decoding for [0xef, 0xbf, 0xbd], that exact sequence could have been validly input in and the strategy to deal with that is unclear. What are your thoughts?

Let's just say no fatal support for now, if that's what's needed to get something working as soon as possible.

There seems to be multiple problems in tests due to iconv-lite not supporting a set of encodings defined in https://encoding.spec.whatwg.org/encodings.json. That is the case for x-mac-cyrillic for example.
iconv-lite seems to fail some of the conversions. For example iconvLite.decode(new Uint8Array([0x00, 0xd8]), 'utf-16le') ought to produce the same as new TextDecoder('utf-16le').decode(new Uint8Array([0x00, 0xd8])) but doesn't. Any pointers ?

It looks like iconv-lite doesn't fully implement the WHATWG Encoding Standard. Too bad I suppose. In the long run we should either implement our own algorithms, or change iconv-lite's conversions to conform to the Encoding Standard, or add additional codecs in iconv-lite that do conform to Encoding. For now, having any functionality is still better than not, I'd say, as long as we document these known discrepancies in the README.
For the UTF-16 issue, as uncomfortable as it is for me to say this, I think we could use Node.js' built-in TextDecoder. TextDecoder has always supported UTF-16, even on older Node.js versions when small-icu was the default, unlike other encodings. You might find the Node.js internal UTF-8 decoder to be more compliant too, in case you find discrepancies in iconv-lite.

Why jsdom cannot just expose TextEncoder and TextDecoder from node.js ? Are these do not conform spec ?

Hey, I'm wondering what the status of this PR is?  It looks like it's been sitting idle for almost a year now.  The lack of support for TextEncoder and TextDecoder within jsdom, which is heavily utilized by jest, is causing a real headache for our project right now.  We'll have to jump through a lot of hoops to work around this in all of our various repos, but it would be much nicer if this was just fixed upstream in jsdom

@TimothyGu I was having a look at this again today.
I have aligned the platform tests to the latest of WPT and updated relevant dependencies.
Beyond the elements I mentioned in https://github.com/jsdom/whatwg-encoding/pull/11#issuecomment-606022044 I have come to realize that the testing harness instrumentation from WPT simply cannot work here without a serious rewrite. There are far to many APIs they rely on, such as XMLHttpRequest, that are not implemented in NodeJS and even after trying out a couple of high level polyfills the likes of node-XMLHttpRequest I wasn't able to get more than an extra dozen test to pass.
As such, this PR, with all its limitations, at the very least might allow people with less complex requirements to have an easier life. I am happy to write a disclaimer to accompany the current code should an initial "substandard" release be done. (At this point I'd argue for a not-so-elegant release, then no release at all)
A brave soul could look at improving the test harness and support for more complex use cases later on 🧠.

@TimothyGu @fguitton are there further changes needed on this branch, or would it in its current state be a good step forwards?

Any updates?


Bash Internal Commands

Closing as part of clean-up at the moment
If needed, will be reopened to track the relevant work


[Question] ModelBinding [Required] is MVC5 BackCompat needed?

Back in february, there were an issue (https://github.com/aspnet/Mvc/issues/1971) about binding value types with [Required] attribute that doesn't creates a ModelState error.
This was 'fixed' and now we can use
[Required]
public int Age { get; set;}

and the ModelBinder will trigger a ModelState error if the parameter is not in the request. Which (to me) looks like the correct behavior.
Unfortunatelly, this isn't backcompat with MVC5 (also pointed out by myself on #1971).
Right now, I think there's work to bring back said compatibility (https://github.com/aspnet/Mvc/commit/fa56df93c3e8eb335b8f9dd6a7cf66a9fa572d72) and today I came across a issue about MVC5 Back Compat in a somehow related scenario when using [FromBody] here: https://github.com/aspnet/Mvc/issues/2423#issuecomment-105746208
I saw a [BindRequired] attribute mentioned here: https://github.com/aspnet/Mvc/issues/2526 and here: https://github.com/aspnet/Mvc/issues/2493, while I'm not sure if this is designed because of bringing back MVC5 compat with the [Required] attribute, looks like it.
Is there any real reason to keep that Back Compatibility or is just because of back-compat ? While I don't think so, I'm asking because I don't see any value of having a [Required] attribute that doesn't create ModelState errors on value types, actually I think it's a bug (not intended behavior) in MVC5.
What's the purpose of a [Required] attribute if it will always have a value and will never trigger the Required expectation ? What am I missing ?

@Bartmax the [Required] attribute is not part of MVC. What we are doing in MVC 6 is matching the BCL semantics and avoiding additional magic beyond that. See https://msdn.microsoft.com/en-us/library/system.componentmodel.dataannotations.requiredattribute.aspx for more information.
If you prefer to ensure a particular value appears on the wire, please use [BindRequired].

Then I propose to change the BCL semantics, make [Required] so it's not null, is on payload and is not empty or whitespace (i would call this smart not magic) and if you still need [NotNull] attribute then can be one but I don't see a use for it.

We can't change the underlying BCL semantics - those semantics are not specific to MVC. You have to use the features of the underlying formatter if you want these semantics.

ok, I hope we can use in mvc [BindRequired] for everything (aka inheriting from Required) and not have to deal with some attributes with required, others with bindrequired or worst with both.
I still think it's is a bad design (from a framework api perspective).

The other thing you can if you want this behavior is just customize ModelMetadata. That's a much easier task now than it was in previous versions.
Sample:
public class MyBindingDetailsProvider : IBindingMetadataProvider
{
    public void GetBindingMetadata(BindingMetadataProviderContext context)
    {
        if (context.PropertyAttributes.OfType<RequiredAttribute>().Any())
        {
            context.BindingMetadata.IsBindingRequired = true;
        }
    }
}

// In startup.cs
options.ModelMetadataDetailsProviders.Add(new MyBindingDetailsProvider());

Now [Required] implies [BindRequired]

@rynowak beautiful! that's something I'm going to use 100% of the time for sure. thanks!

@rynowak just for curiosity, why that cannot be the default binding configuration mvc uses?

why that cannot be the default binding configuration mvc uses?

[Required] is a .NET data annotation with a defined meaning and MVC interpreting it differently would be confusing. From https://msdn.microsoft.com/en-us/library/system.componentmodel.dataannotations.requiredattribute(v=vs.110).aspx

A validation exception is raised if the property is null, contains an empty string (""), or contains only white-space characters.

But as @rynowak showed, your application can easily change how [Required] is interpreted.

I see your point, and from a technical perspective that's fine but I still found very confusing (specially for new comers) that in the following code
[Required]
public int Age {get;set;}

Required does nothing, and in a web api endpoint one should use BOTH, Required and BindRequired. This clearly doesn't work as anyone would expect.
I don't see why we cannot have a extra documentation that says that for MVC ModelBinders when a required attribute is used and the property is not included in the request payload it will trigger a modelstate error.


Add more matrix tests

Looking great - thanks very much for expanding these.  We should also add some rows to test removing the individual secret (or key) as well as removing the entire collection, as these are different codepaths which need testing.
Some of the crypto rows are still TODO, of course.  We should add some tests for crypto operations other than Sign and Verify, e.g. add GEDR (generate+encrypt+decrypt+remove) tests.
Also, we should add an --owner-only flag to the secrets-tool when creating a collection, to support testing OwnerOnly as well as NoAccessControl semantics via these tests (since currently secrets-tool --create-collection does setAccessControlMode(Sailfish::Secrets::SecretManager::NoAccessControlMode) always).

Thanks, I've merged into manualtests, and will merge from there into master shortly.  Nice work.


solve the error problem

Type: Feature Request
i am getting this error "'cin' was not declared in this scope
cin >> arr[i][j]; even after including header properly,i am getting this error only with cin not with cout
VS Code version: Code 1.83.1 (f1b07bd25dfad64b0167beb15359ae573aecd2cc, 2023-10-10T23:48:05.904Z)
OS version: Windows_NT x64 10.0.22621
Modes:

We closed this issue because it is a question about using VS Code rather than an issue or feature request. Please search for help on StackOverflow, where the community has already answered thousands of similar questions. You may find their guide on asking a new question helpful if your question has not already been asked. See also our issue reporting guidelines.
Happy Coding!


fix loading xbm images

It should probably copy the data into JWM allocated memory and do XFree, just in case XFree is implemented some way other than a thin wrapper around free.  Otherwise it could cause problems later when JWM frees the image data.  In reality, I don't think it matters, but better safe than sorry.  I'll take care of it.
Thanks!


Fix lite deployment by saving geojson schema at right place

Should fix #235

I can still reproduce the issue on the lite deployment for this PR:
See https://appsharing.space/static-app?url=https://github.com/geojupyter/jupytergis/actions/runs/12274797031/artifacts/2305136325&indexPath=lite/lab/index.html

It turns out the initial issue is unrelated to this https://github.com/geojupyter/jupytergis/pull/241
But your PR is still a net improvement, thanks!

But your PR is still a net improvement, thanks!

Thanks for suggesting this in the first place :)


Adding import of spray.json as well in the documentation which is requir...

...ed for the case class object to be converted to json

Thanks!