detect-secrets v1.1.0 fails to load any plugins on py38

For some reason on my MacOS (Big Sur, pyenv, python 3.8.8 / 3.9.4) detect-secrets 1.1.0 fails to detect any secret, whereas 1.0.3 seems to work fine.
When using detect-secrets scan with 1.1.0 it returns:
% detect-secrets --version
1.1.0
% detect-secrets scan
[scan]  ERROR   No plugins to scan with!
[scan]  ERROR   No plugins to scan with!
[scan]  ERROR   No plugins to scan with!
[scan]  ERROR   No plugins to scan with!
[scan]  ERROR   No plugins to scan with!
[scan]  ERROR   No plugins to scan with!
[scan]  ERROR   No plugins to scan with!
[scan]  ERROR   No plugins to scan with!
[scan]  ERROR   No plugins to scan with!
[scan]  ERROR   No plugins to scan with!
[scan]  ERROR   No plugins to scan with!
[scan]  ERROR   No plugins to scan with!
[scan]  ERROR   No plugins to scan with!
[scan]  ERROR   No plugins to scan with!
[scan]  ERROR   No plugins to scan with!
[scan]  ERROR   No plugins to scan with!
[scan]  ERROR   No plugins to scan with!
[scan]  ERROR   No plugins to scan with!
[scan]  ERROR   No plugins to scan with!
[scan]  ERROR   No plugins to scan with!
[scan]  ERROR   No plugins to scan with!
[scan]  ERROR   No plugins to scan with!
{
  "version": "1.1.0",
  "plugins_used": [
    {
      "name": "ArtifactoryDetector"
    },
    {
      "name": "AWSKeyDetector"
    },
    {
      "name": "AzureStorageKeyDetector"
    },
    {
      "name": "Base64HighEntropyString",
      "limit": 4.5
    },
    {
      "name": "BasicAuthDetector"
    },
    {
      "name": "CloudantDetector"
    },
    {
      "name": "HexHighEntropyString",
      "limit": 3.0
    },
    {
      "name": "IbmCloudIamDetector"
    },
    {
      "name": "IbmCosHmacDetector"
    },
    {
      "name": "JwtTokenDetector"
    },
    {
      "name": "KeywordDetector",
      "keyword_exclude": ""
    },
    {
      "name": "MailchimpDetector"
    },
    {
      "name": "NpmDetector"
    },
    {
      "name": "PrivateKeyDetector"
    },
    {
      "name": "SlackDetector"
    },
    {
      "name": "SoftlayerDetector"
    },
    {
      "name": "SquareOAuthDetector"
    },
    {
      "name": "StripeDetector"
    },
    {
      "name": "TwilioKeyDetector"
    }
  ],
  "filters_used": [
    {
      "path": "detect_secrets.filters.allowlist.is_line_allowlisted"
    },
    {
      "path": "detect_secrets.filters.common.is_ignored_due_to_verification_policies",
      "min_level": 2
    },
    {
      "path": "detect_secrets.filters.heuristic.is_indirect_reference"
    },
    {
      "path": "detect_secrets.filters.heuristic.is_likely_id_string"
    },
    {
      "path": "detect_secrets.filters.heuristic.is_lock_file"
    },
    {
      "path": "detect_secrets.filters.heuristic.is_not_alphanumeric_string"
    },
    {
      "path": "detect_secrets.filters.heuristic.is_potential_uuid"
    },
    {
      "path": "detect_secrets.filters.heuristic.is_prefixed_with_dollar_sign"
    },
    {
      "path": "detect_secrets.filters.heuristic.is_sequential_string"
    },
    {
      "path": "detect_secrets.filters.heuristic.is_swagger_file"
    },
    {
      "path": "detect_secrets.filters.heuristic.is_templated_secret"
    }
  ],
  "results": {},
  "generated_at": "2021-04-16T00:24:54Z"
}

% detect-secrets scan --list-all-plugins
ArtifactoryDetector
AWSKeyDetector
AzureStorageKeyDetector
BasicAuthDetector
CloudantDetector
Base64HighEntropyString
HexHighEntropyString
IbmCloudIamDetector
IbmCosHmacDetector
JwtTokenDetector
KeywordDetector
MailchimpDetector
NpmDetector
PrivateKeyDetector
SlackDetector
SoftlayerDetector
SquareOAuthDetector
StripeDetector
TwilioKeyDetector

If I switch to Python 3.7.9 (or revert back to 1.0.3) it seems to work correctly.
% detect-secrets --version
1.0.3
% detect-secrets scan
{
  "version": "1.0.3",
  "plugins_used": [
    {
      "name": "ArtifactoryDetector"
    },
    {
      "name": "AWSKeyDetector"
    },
    {
      "name": "AzureStorageKeyDetector"
    },
    {
      "name": "Base64HighEntropyString",
      "limit": 4.5
    },
    {
      "name": "BasicAuthDetector"
    },
    {
      "name": "CloudantDetector"
    },
    {
      "name": "HexHighEntropyString",
      "limit": 3.0
    },
    {
      "name": "IbmCloudIamDetector"
    },
    {
      "name": "IbmCosHmacDetector"
    },
    {
      "name": "JwtTokenDetector"
    },
    {
      "name": "KeywordDetector",
      "keyword_exclude": ""
    },
    {
      "name": "MailchimpDetector"
    },
    {
      "name": "NpmDetector"
    },
    {
      "name": "PrivateKeyDetector"
    },
    {
      "name": "SlackDetector"
    },
    {
      "name": "SoftlayerDetector"
    },
    {
      "name": "SquareOAuthDetector"
    },
    {
      "name": "StripeDetector"
    },
    {
      "name": "TwilioKeyDetector"
    }
  ],
  "filters_used": [
    {
      "path": "detect_secrets.filters.allowlist.is_line_allowlisted"
    },
    {
      "path": "detect_secrets.filters.common.is_ignored_due_to_verification_policies",
      "min_level": 2
    },
    {
      "path": "detect_secrets.filters.heuristic.is_indirect_reference"
    },
    {
      "path": "detect_secrets.filters.heuristic.is_likely_id_string"
    },
    {
      "path": "detect_secrets.filters.heuristic.is_potential_uuid"
    },
    {
      "path": "detect_secrets.filters.heuristic.is_prefixed_with_dollar_sign"
    },
    {
      "path": "detect_secrets.filters.heuristic.is_sequential_string"
    },
    {
      "path": "detect_secrets.filters.heuristic.is_templated_secret"
    }
  ],
  "results": {
    "tests/conftest.py": [
      {
        "type": "Secret Keyword",
        "filename": "tests/conftest.py",
        "hashed_secret": "dc724af18fbdd4e59189f5fe768a5f8311527050",
        "is_verified": false,
        "line_number": 50
      }
    ]
  },
  "generated_at": "2021-04-16T00:26:42Z"
}

% detect-secrets scan --list-all-plugins
ArtifactoryDetector
AWSKeyDetector
AzureStorageKeyDetector
BasicAuthDetector
CloudantDetector
Base64HighEntropyString
HexHighEntropyString
IbmCloudIamDetector
IbmCosHmacDetector
JwtTokenDetector
KeywordDetector
MailchimpDetector
NpmDetector
PrivateKeyDetector
SlackDetector
SoftlayerDetector
SquareOAuthDetector
StripeDetector

Super interesting problem.
I took a quick look, and it turns out that the issue is with the changes that Python3.8 introduced to the multiprocessing library. I hypothesize that Python3.8 doesn't share memory between processors by default, which means that the global settings object becomes inaccessible across processors: https://github.com/Yelp/detect-secrets/blob/master/detect_secrets/core/secrets_collection.py#L58-L64
If you downgrade to Python3.7, you should be able to run this on v1.1.

I can confirm running on v1.1 works correctly on python 3.7.9. Interestingly, on an Azure DevOps pipeline running Python 3.8 (ubuntu-latest [20.04] agent, ms hosted) detect-secrets v1.1 correctly finds secrets (but because we couldn't baseline it, it meant it was failing our build). Is there some more data you'd like me to capture myself to be able address this issue or were you able to reproduce?

Weeird.
I was able to reproduce this on MacOS Catalina, pyenv, 3.8.5. And if my hypothesis is correct, you won't encounter this issue if you try scanning one file, since I wrote a bypass for that case: https://github.com/Yelp/detect-secrets/blob/master/detect_secrets/core/secrets_collection.py#L51-L53.
Could you verify that?

getting the same issue on windows 10

To add to this, can confirm the same behavior on Windows 10 using Python 3.7.9.

As mentioned above scanning an individual file completes successfully and returns good results, as well as downgrading to version 1.0.3 doesn't have the issue

Spent lot of time on this issue before coming across this ticket... downgrading to 1.0.3. works for me

It happens to me programmatically with the pypi package.
When using solely scan_file() like below I get  "[scan] ERROR No plugins to scan with!" :
...
for file in files:
    secrets.scan_file(file)
...

But when using with default_settings() everything works fine :
...
with default_settings():
    for file in files:
        secrets.scan_file(file)
...

default setting() enables all filters and plugins by default. So I can suggest to enable all plugins on the command line:
> detect-secrets scan --force-use-all-plugins

PS: I have not tested the cli solution.
Versions used :
> python3 --version
Python 3.8.6
> detect-secrets --version
1.1.0

Same problem on Windows.
> python -V
Python 3.8.0
> detect-secrets --version
1.1.0

@domanchi wrote:

I was able to reproduce this on MacOS Catalina, pyenv, 3.8.5. And if my hypothesis is correct, you won't encounter this issue if you try scanning one file, since I wrote a bypass for that case: https://github.com/Yelp/detect-secrets/blob/master/detect_secrets/core/secrets_collection.py#L51-L53.
Could you verify that?

Verified. Scanning a folder with python -m detect_secrets scan test_data with Python 3.8 gets the "No plugins to scan with!" error, while scanning a single file with python -m detect_secrets scan test_data/config.ini works.

@shadawck suggested trying --force-use-all-plugins. That didn't work, still get the "No plugins to scan with!" error.

@domanchi wrote:

I was able to reproduce this on MacOS Catalina, pyenv, 3.8.5. And if my hypothesis is correct, you won't encounter this issue if you try scanning one file, since I wrote a bypass for that case: https://github.com/Yelp/detect-secrets/blob/master/detect_secrets/core/secrets_collection.py#L51-L53.
Could you verify that?

Verified. Scanning a folder with python -m detect_secrets scan test_data with Python 3.8 gets the "No plugins to scan with!" error, while scanning a single file with python -m detect_secrets scan test_data/config.ini works.

Same here using v1.1.0 installed through homebrew on MacOS with python3 --version at 3.9.7.
Scanning the individual file was successful while all other run modes I tried fail.

Any update on this feature? I'd like to leverage the latest features in v1.1.0 but this is a blocking issue for me.  Able to repro on Windows 10/11 with Python 3.7+

I'm also willing to help test when this is resolved, as I believe I still have an organizational 'how-to' document that has a pinned version that I would love to see removed.


chore(deps): update dependency golang to v1.23.2

This PR contains the following updates:

Package
Update
Change

golang
patch
1.23.1 -> 1.23.2

[!WARNING]
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

Release Notes

golang/go (golang)
v1.23.2
Compare Source

Configuration
📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


Proposal: let the client specify an io.Writer instead of assuming os.Stdout

Hello, this looks like a very cool library. I'm excited to jump in and play with it.
Would it be a good idea to let the client choose their own io.Writer for audio data to be written to. It would be nice to let the client flexibly stream over tcp / write to file / pipe to another process all using the same underlying mixing implementation with different writers.
It does seem like it would require a change to the public interface, so that's something to consider.
Thoughts?

Thanks for checking it out! I've been kicking the tires with this a lot, and really enjoy using it for music projects.
I like this feature a lot. Actually, the only case I've been actually using so far is stdout. I run Ubuntu/Debian Linux and listen to my programs output | aplay or write them to a > file. For reasons of long-term upkeep/time-cost/distraction I have been considering deprecating the hardware bindings entirely.
To your point re: tcp, I dream about projects that might perform mixing operations in network/virtual environments for public listening..

Note in the leading branch, there is no hardware output binding: https://godoc.org/github.com/go-mix/mix
However in the last major release, there is: https://godoc.org/gopkg.in/mix.v0
It is my intention that the next release will include this feature, and be released as https://godoc.org/gopkg.in/mix.v1 -- ergo changes in the public interface are OK

I've reorganized the project around the next milestone, which I reckon to be 1.0.0 and expect  to include updates to the public interface.
Please also suggest anything else you believe essential in this release. Thanks!

Also please do feel free to challenge the way the library was originally organized into these two separate packages:
  "github.com/go-mix/mix"
  "github.com/go-mix/mix/bind"

I haven't thought it entirely though yet, but I want to be certain that it is still appropriate. It was originally designed this way because of some limitations of using the hardware binding libraries, e.g. SDL2 and Portaudio. Now, I can't think of a reason offhand why it needs to be this complex.

#57 Should help


Does it an issue of Exrin ?

I am new in using Exrin together with Xamarin, there was using Xamarin with classic application structure out-of-the-box. This finding I want to raise is the page transition effect after using Exrin, the animation for the page transition effect was strange. Each time the application push/pop a page, it will flash a white screen prior the destination page been shown, there is seems flickering and looks weird.
I am just want to keep the default behaviour for the page transition, and don't want to apply custom  renderer to override.
Please kindly suggest what can I do ? or this is an issues of Exrin ? really thanks !

@leaguefun - page flickering isn't a known issue, with Exrin. Which platform(s) are you experiencing this on? And what version of XF are you using?

Also just note, that if you want to show the animated page transition, go into NavigationProxy, find the PushAsync method, and add the true parameter to it, as you would in a standard app.

Thanks @adamped
I am using XF - <IP_ADDRESS> and Exrin 1.3.0, as the default behaviour for the PushAsync method is true for the animated parameter, but it will flash up a white screen each time new page is going to be shown, so that I had set to False to suppress the animation, any idea ?

`namespace ExrinSample.Proxy
{
using Exrin.Abstraction;
using Exrin.Framework;
using System;
using System.Collections.Generic;
using System.Threading.Tasks;
using Xamarin.Forms;
public class NavigationProxy : INavigationProxy
{

	protected NavigationPage _page = null;
    public event EventHandler<IViewNavigationArgs> OnPopped;
	protected Queue<object> _argQueue = new Queue<object>();
    public VisualStatus ViewStatus { get; set; } = VisualStatus.Unseen;

    public NavigationProxy(NavigationPage page)
    {
        _page = page;
        _page.Popped += _page_Popped;
    }

	protected void _page_Popped(object sender, NavigationEventArgs e)
    {
        if (OnPopped != null)
        {
            var poppedPage = e.Page as IView;
            var currentPage = _page.CurrentPage as IView;
            var parameter = _argQueue.Count > 0 ? _argQueue.Dequeue() : null;
            OnPopped(this, new ViewNavigationArgs() { Parameter = parameter, CurrentView = currentPage, PoppedView = poppedPage });
        }
    }

    public void SetNavigationBar(bool isVisible, object page)
    {
        var bindableObject = page as BindableObject;
        if (bindableObject != null)
            NavigationPage.SetHasNavigationBar(bindableObject, isVisible);
    }

    public object NativeView { get { return _page; } }

    public bool CanGoBack()
    {
        return _page.Navigation.NavigationStack.Count > 1;
    }

    public async Task PopAsync(object parameter)
    {
        _argQueue.Enqueue(parameter);
		if (Device.RuntimePlatform.Equals(Device.Android))
			await _page.PopAsync(false);
		else
        	await _page.PopAsync();
    }

    public async Task PopAsync()
    {
		if (Device.RuntimePlatform.Equals(Device.Android))
			await _page.PopAsync(false);
		else
        	await _page.PopAsync();
    }

    public async Task PushAsync(object page)
    {
        var xamarinPage = page as Page;

        if (xamarinPage == null)
            throw new Exception("PushAsync can not push a non Xamarin Page");

		if (Device.RuntimePlatform.Equals(Device.Android))
			await _page.PushAsync(xamarinPage, false);
		else
			await _page.PushAsync(xamarinPage);
    }

    public async Task ShowDialog(IDialogOptions dialogOptions)
    {
        if (ViewStatus == VisualStatus.Visible)
        {
            await _page.DisplayAlert(dialogOptions.Title, dialogOptions.Message, "OK");
            dialogOptions.Result = true;
        }
        else
        {
            throw new Exception("You can not call ShowDialog on a non-visible page");
        }
    }

    public Task ClearAsync()
    {
        _page = new NavigationPage();
        return Task.FromResult(true);
    }

    public Task SilentPopAsync(int indexFromTop)
    {
        _page.Navigation.RemovePage(_page.Navigation.NavigationStack[_page.Navigation.NavigationStack.Count - indexFromTop - 1]);
        return Task.FromResult(true);
    }
}

}
`
Since I changed the Background color of the page to Black in color, the flickering issues seems not obviously, but it can't on Android.

On Android platform, I cut the page transition by setting False while calling PushAsync/PopAsync, there is working as usual actually, but is there any way to revoke to android default page transition behaviour ?


Speed up tests

Description
This PR aims to reduce the time it takes for our test suite to run.
It seems to cut test times to 25-30% of the original times.
Notable changes:

Remove the pre pnpm test bundling (since this already happens in postinstall)
Removes the post install rerun of npm i
Removes the test env build completely (this was over 50% of our test time)

Results
Pre optimization test run
Ubuntu 18: 6:44 -> 1:33
Ubuntu 20: 6:21 -> 1:34
Mac 18: 12mins -> 4mins
Mac 20: 10mins -> 4mins
Windows 18: 19mins -> 6min
Windows 20: 19mins -> 6min

I'm not too hot on dropping the test-env build test, unless it's replaced with a netlify build (which would be an improvement)

Adding a netlify build is a great idea

I added a netlify build but it fails due to OOM errors...

boosted the memory and it worked

closing in favour of https://github.com/evidence-dev/evidence/pull/1801 in order to trigger netlify build of test-env


Restrict NEPA Documents by Group

[x] Disable Tab in Navigation
[ ] Restrict viewing of 'NEPA Documents' by Group
[ ] Allow Document Edit Permissions by Group

Phase 1 - Class Based Viewing
Phase 2 - Object Based View/Edit Permissions

Updated initial text to make check boxes work

After looking at the existing MW groups, it's clear that their intention is not for authorization.  The groups are joined by individual users and not managed by admin.  Is this functionality useful?  It seems like we could keep these user groups and add authorization groups.

Currently, only admins can edit NEPA Docs.  I'm going to update the site so that viewing also requires admin creds and we can move forward from there.

Also note that MW currently has four authorization roles: admin, SU, editor, and developer.
We could use (and perhaps rename) these as an interim step to redeveloping the groups.

I'll leave the approach to you whatever is quick/straightforward but takes future extendability into account. Sounds like exploiting existing authorization roles and associating groups to those and assets to groups makes it the more practical for maintenance... In other words restricting editing of NEPA Documents to a group which inherits an authorization role to do so... and restrict the ability to create/join a group to the same auth role

Navigation updated so that NEPA resources are restricted to admin users.

What is most useful right now?

Using the existing roles so that we can assign users the ability to view/edit all NEPA resources.  We can accomplish this in a few hours with existing authorization functionality.

Starting work on group authorization which will transform into class and object authorizations.  This is going to happen eventually but will take significant development time.

NEPA Group memberships and permissions complete.  Admins can create NEPA groups, add/remove users to those groups (i.e. manage memberships), and add/remove NEPA documents with readonly or edit permissions.


Cupertino blurs should boost saturation

Apple makes extensive use of blur on iOS/MacOS to guide the users focus and attention. As announced in the 2019 roadmap, Flutter wants to expand to platforms beyond mobile (such as Mac/Web) but still wants to provide the most native experience possible. This could be easily improved by providing a more open ImageFilter API to give developers the power to customize blur effects.
In order to add a iOS like blur effect in CSS, apple is using the backdrop-filter: blur(20px) saturation(180%) property. It´s particulary important to have control over the saturation to achive a high similarity to the iOS/MacOS translucency.
No saturation:

With saturation:

Most of the effects defined in UIBlurEffect.Style could be recreated when providing a saturation filter.
Similar issues like this by @matthew-carroll
or  this question on stackoverflow show that these APIs are requested for a long time. I am curious if the Flutter team is currently working on improving blur and how those APIs would look like since Hummingbird needs support for this as well.

CC @xster

@liyuqian is this something we can expose from Skia?

@xster I think we should probably solve the root problem, which is: what do we do when developers want/need a skia capability that Flutter has chosen not to expose.  Otherwise, we'll see more requests of the same.  I think the answer is in engine modularity that allows developers to essentially choose which parts of skia compile in, and which don't.  Consider that Flutter simultaneously needs to support an instant-run app below 10MB, as well as a Flutter version of Photoshop, all with the same engine.  Can we really hope to meet that breadth of requirements without said skia controls?

The root problem reminds me https://github.com/flutter/flutter/issues/21078 . For the specific ImageFilter with saturation, I'm not aware of anything useful so I'm going to ask Skia directly in the chat room.

Not related to this issue directly, but I suspect a stronger case for engine modularity would be including Skottie - https://github.com/flutter/flutter/issues/20438
This should be a fairly trivial thing to expose, and shouldn't substantially add to binary size to add it.  The only question would be whether it incurrs a particularly large performance penalty.

@liyuqian do you know if we actually need to change any of the skia flags to bring this feature into our engine or could such a filter be present already and we just need dart wrappers?

Here's as far as I got:
import 'dart:ui' as ui;

import 'package:flutter/cupertino.dart';
import 'package:flutter/services.dart';

ui.Image img;
void main() async {
  final ByteData bytes =
      await rootBundle.load('assets/designed_for_everyone_large.jpg');
  final ui.Codec codec =
      await ui.instantiateImageCodec(bytes.buffer.asUint8List());
  img = (await codec.getNextFrame()).image;
  runApp(
    Directionality(
      textDirection: TextDirection.ltr,
      child: CustomPaint(
        painter: BlurPainter(),
      ),
    ),
  );
}

class BlurPainter extends CustomPainter {
  static const double kHueR = 0.213;
  static const double kHueG = 0.715;
  static const double kHueB = 0.072;

  static List<double> matrixWithSat(double sat) {
    double r = kHueR * (1 - sat);
    double g = kHueG * (1 - sat);
    double b = kHueB * (1 - sat);

    return <double>[
      r + sat, g, b, 0, 0, //
      r, g + sat, b, 0, 0, //
      r, g, b + sat, 0, 0, //
      0, 0, 0, 1, 0, //
    ];
  }

  @override
  void paint(Canvas canvas, Size size) {
    Rect src = Rect.fromLTWH(0, 0, img.width.toDouble(), img.height * .5);
    final Rect topHalf = Rect.fromLTWH(0, 0, size.width, size.height * .5);
    final Rect bottomHalf =
        Rect.fromLTWH(0, size.height * .5, size.width, size.height * .5);
    canvas.drawImageRect(
      img,
      src,
      topHalf,
      ui.Paint()..colorFilter = ColorFilter.matrix(matrixWithSat(1.8)),
    );

    canvas.drawRect(
      topHalf,
      ui.Paint()..color = const Color(0xDD000000),
    );

    src = Rect.fromLTWH(
        0, img.height * .5, img.width.toDouble(), img.height * .5);
    canvas.drawImageRect(
      img,
      src,
      bottomHalf,
      ui.Paint(),
    );
  }

  @override
  bool shouldRepaint(CustomPainter oldDelegate) => true;
}

Unfortunately, it doesn't look like we have a way to apply an ImageFilter short of using a BackdropFilter, and I couldn't quite tget that to work on just part of an image.

Little closer with some help from @xster
import 'dart:ui' as ui;

import 'package:flutter/cupertino.dart';
import 'package:flutter/services.dart';

ui.Image img;
void main() async {
  final ByteData bytes =
      await rootBundle.load('assets/designed_for_everyone_large.jpg');
  final ui.Codec codec =
      await ui.instantiateImageCodec(bytes.buffer.asUint8List());
  img = (await codec.getNextFrame()).image;
  runApp(
    Directionality(
      textDirection: TextDirection.ltr,
      child: CustomPaint(
        painter: SaturationPainter(),
        child: FractionallySizedBox(
          alignment: Alignment.topCenter,
          heightFactor: .5,
          child: ClipRect(
            child: BackdropFilter(
              filter: ui.ImageFilter.blur(sigmaX: 25, sigmaY: 25),
              child: Container(color: Color(0xAA000000)),
            ),
          ),
        ),
      ),
    ),
  );
}

class SaturationPainter extends CustomPainter {
  static const double kHueR = 0.213;
  static const double kHueG = 0.715;
  static const double kHueB = 0.072;

  static List<double> matrixWithSat(double sat) {
    double r = kHueR * (1 - sat);
    double g = kHueG * (1 - sat);
    double b = kHueB * (1 - sat);

    return <double>[
      r + sat, g, b, 0, 0, //
      r, g + sat, b, 0, 0, //
      r, g, b + sat, 0, 0, //
      0, 0, 0, 1, 0, //
    ];
  }

  @override
  void paint(Canvas canvas, Size size) {
    Rect src = Rect.fromLTWH(0, 0, img.width.toDouble(), img.height * .5);
    final Rect topHalf = Rect.fromLTWH(0, 0, size.width, size.height * .5);
    final Rect bottomHalf =
        Rect.fromLTWH(0, size.height * .5, size.width, size.height * .5);
    canvas.drawImageRect(
      img,
      src,
      topHalf,
      ui.Paint()..colorFilter = ColorFilter.matrix(matrixWithSat(24)),
    );

    src = Rect.fromLTWH(
        0, img.height * .5, img.width.toDouble(), img.height * .5);
    canvas.drawImageRect(
      img,
      src,
      bottomHalf,
      ui.Paint(),
    );
  }

  @override
  bool shouldRepaint(CustomPainter oldDelegate) => true;
}

Our ImageFilter API is a bit painful to use though and could definitely be improved.

Are we able to apply the saturation effect on widgets that are below the backdrop?

I'm doing it here by directly painting on the canvas and applying the color filter to the paint.
I don't beleive we have an existing widget that can apply an arbitrary color filter (e.g. saturation filter) to another widget, but that seems like it wouldn't be a bad idea.

It seems like the only thing that affects background during composition stage is BackdropFilter right now which is limited by inability to add any new image filters - #16296.
The only workaround for now looks like wrapping widgets below into RepaintBoundary, capturing it into the image and drawing it on canvas similar to SaturationPainter above.
It would be great if there was a CustomPainter that would paint using layers below as "destination" which would allow to replicate almost any effect using BlendMode on Paint.

as of https://github.com/flutter/flutter/commit/43b03127d469f1f6d9a22f8dae41eea2eed2afd9, imageFilter is now a property on paint, which should make this easier to do.

@dnfield Could you please provide an example code on how to do this?

Re-summarizing where we are:
https://github.com/flutter/engine/pull/13711 adds an easy wrapper for creating matrix ImageFilters. We also have both ImageFiltered, ColorFiltered widgets to wrap the ImageFilter and ColorFilters so it's trivially easy to implement this now.
The only thing left from the original request is to actually consume them in our translucent Cupertino widgets.
Strongly welcome PRs from anyone with a sharp eye who can identify the right values to put in.

The value's probably somehow extractable from https://developer.apple.com/design/resources/ (or maybe just from CSS like in the OP) but I couldn't figure out how.

Thanks a lot!

Let's keep this bug open though since I repurposed the bug to implement the right metrics in our cupertino widgets directly.

Hey @xster, I took a look at the sketch files and these are the values used for light/dark mode.

How a ColorFilter can be applied to a BackdropFilter to achieve that outcome?

Finally I found kind of a solution for my use case with a custom blurred image. Just add a colorFilter to your DecorationImage with overlay blend mode:
colorFilter: ColorFilter.mode(Colors.white, BlendMode.overlay),
This makes the blurred image much brighter which results in a look like the saturation has been increased.

Are we able to apply the saturation effect on widgets that are below the backdrop?

@JulianBissekkou
@jamesblasco
Have you found any solution?

Hey @xster, I took a look at the sketch files and these are the values used for light/dark mode.

Did you get these directly from Apple's design resources?

Here are some estimations. The additive value makes reds more washed out. Otherwise, they appear muddy. It's not exact (maybe due to color gamut limitations?), but it looks pretty close.

List<double> buildLightColorFilterMatrix({
    required double strength,
  }) {
    const double lightLumR = 0.26;
    const double lightLumG = 0.4;
    const double lightLumB = 0.17;
    final double saturation = strength * 1 + 1;
    final double sr = (1 - saturation) * lightLumR;
    final double sg = (1 - saturation) * lightLumG;
    final double sb = (1 - saturation) * lightLumB;
    return <double>[
      sr + saturation, sg             , sb             , 0.0, 0.0, //
      sr             , sg + saturation, sb             , 0.0, 0.0, //
      sr             , sg             , sb + saturation, 0.0, 0.0, //
      0.0            , 0.0            , 0.0            , 1.0, 0.0, //
    ];
  }

  List<double> buildDarkColorFilterMatrix({
    required double strength,
  }) {
    const double additive = 0.3;
    const double darkLumR = 0.45;
    const double darkLumG = 0.8;
    const double darkLumB = 0.16;
    final double saturation = strength * 0.7 + 1;
    final double sr = (1 - saturation) * darkLumR;
    final double sg = (1 - saturation) * darkLumG;
    final double sb = (1 - saturation) * darkLumB;
    return <double>[
      sr + saturation, sg             , sb             , 0.0, additive, //
      sr             , sg + saturation, sb             , 0.0, additive, //
      sr             , sg             , sb + saturation, 0.0, additive, //
      0.0            , 0.0            , 0.0            , 1.0, 0.0     , //
    ];
  }

I am using a widget that animates the saturation and blur as a menu appears. That widget is:
// Animates the vibrance, blur, and background of the menu panel.
class _AnimatedSurfaceVibrance extends AnimatedWidget {
  const _AnimatedSurfaceVibrance({
    required Animation<double> listenable,
    required this.surfaceColor,
    required this.child,
  }) : super(listenable: listenable);

  static const Interval _surfaceDelay = Interval(0.55, 1.0);
  final Widget child;
  final Color surfaceColor;
  double get value => ui.clampDouble((super.listenable as Animation<double>).value, 0.0, 1.0);

  @override
  Widget build(BuildContext context) {
    final ui.Color resolved = CupertinoDynamicColor.maybeResolve(surfaceColor, context)
                                ?? surfaceColor;
    final ui.Color color = resolved.withOpacity(resolved.opacity * value);
    final double progress = _surfaceDelay.transform(value);
    Widget surface = CustomPaint(
      willChange: value != 0 && value != 1,
      painter: _UnclippedColorPainter(color: color),
      child: child,
    );

    // If the color is not opaque, apply a blur filter to the surface.
    if (color.alpha != 0xFF) {
      ui.ImageFilter filter = ui.ImageFilter.blur(
        sigmaX: 30 * progress,
        sigmaY: 30 * progress,
      );

      if (!kIsWeb) {
        filter = ui.ImageFilter.compose(
          outer: filter,
          inner: ui.ColorFilter.matrix(
            CupertinoTheme.maybeBrightnessOf(context) == Brightness.dark
                ? buildDarkColorFilterMatrix(strength: progress)
                : buildLightColorFilterMatrix(strength: progress),
          ),
        );
      }

      surface = BackdropFilter(
        blendMode: BlendMode.src,
        filter: filter,
        child: surface,
      );
    }

    return surface;
  }
}

// A custom painter that paints a color that is 10% larger than it's bounds.
//
// Used to fill the background color of the menu even when the menu size animation
// surpasses a heightFactor of 1.0.
class _UnclippedColorPainter extends CustomPainter {
  const _UnclippedColorPainter({required this.color});
  final Color color;

  @override
  void paint(Canvas canvas, Size size) {
    canvas.drawRect(
      Offset.zero & (size * 1.1),
      Paint()..color = color,
    );
  }

  @override
  bool shouldRepaint(_UnclippedColorPainter oldDelegate) {
    return oldDelegate.color != color;
  }

  @override
  String toString() => '_UnclippedColorPainter($color)';
}


Multiple undocumented flags (e.g. --builtin-extensions-dir)

I found some flags that I wanted to use e.g.
https://github.com/cdr/code-server/blob/d31439ec34572b6829902ea1863931071fe1fc55/src/node/cli.ts#L155
but it turned out that they aren't documented anywhere I can find.
There seems to be a bunch of flags like this which don't seem to be documented anywhere (nothing from code-server --help)
I've tried to look around, but, apart from the source code and an old PR where it was introduced, I find no reference to these features.
Edit: Turns out i probably wanted to use extra-extensions-dir or extra-builtin-extensions-dir instead. Either, documentation would be nice.

Definitely fair, there are some bugs with those flags which I'd like to fix before making them more public. Tracking: https://github.com/cdr/code-server/issues/1157


Supports wildcard

What type of PR is this?

What this PR does / why we need it (English/Chinese):

Which issue(s) this PR fixes:

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Accept-Encoding#syntax

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add volatile configuration option

With this it is now possible to define a per-source include or exclude configuration that is applicable for certain date range.
resolves #191

I like it.

I despise this, but hey it gets the job done...


Fix length check.

The length of an array is never negative, so the condition as written can never hold.

Coverage increased (+0.4%) to 66.884% when pulling 1737a73685e5cfcb57dafddd146c24acb4c7ed0a on xiemaisi:negative-length into 1de31a4ed1d0a9cd33ff64199f7e91f23e99c11e on uber:master.

Is there anything I should do to expedite review of this PR? (The CI failure looks unrelated.)


feat: password visibility toggle button

Problem
During user login, the password cannot be seen by the user while typing to check if there is any typing error or not.
Solution
I want to add a password visibility toggle button that will show the password if the user wants to check what he/ she has typed in.
Screenshot

Please assign this issue to me under gssoc.


Alloy Forgery Crash neoforge 1.21.1

Mod Name
Alloy Forgery
Mod Homepage
https://www.curseforge.com/minecraft/mc-mods/alloy-forgery
Minecraft version
1.21.1
Describe the bug
yea it crashes during loading, i thought it was owo lib, owo lib alone runs, once i add alloy forgery it just crashes. if you get it to work with alloy forgery, try adding mythic metals and see if it works with that then too. thx!
Steps to reproduce

add Connector, Add owo lib, Add alloy forgery
launch minecraft
wait for crash

Logs
https://gist.github.com/Tidoto/2d1a480489ce3140a25169497ccf7c16
Additional context
No response

I'm running Connector with Alloy Forgery 2.1.2, owo 0.11.2, and mythic metals 0.19.9 and I am not experiencing startup crashes.

I'm running Connector with Alloy Forgery 2.1.2, owo 0.11.2, and mythic metals 0.19.9 and I am not experiencing startup crashes.

owo-lib 0.11.2 is for 1.20.1 Fabric not 1.21.1 .-. it shouldnt work. Also Alloy Forgery doesnt work not Mythic Metals, it could be the NeoForge version. I tried on latest 21.1.76 and doesn't work for example and crashes because some Recipe stuff.

Ah yeah, sorry, I misread the title. I'm on 1.20.1 not 1.21.1

This is a duplicate of #1340


Apply lib.webworker.d.ts  to lib.core.es6.d.ts

This change will  ease webworker to write with ES6.
Add an ES6 lib.webworker.d.ts #6282

I'm not entirely familiar with the original suggestion, but it sounds like the idea is that there are ES6 extensions to web workers, so including the entirety of the es6 .d.ts is probably overkill.
Perhaps this work should be done after #6990 goes in. @yuit can you weigh in?

so including the entirety of the es6  .d.ts  is probably overkill

I think WebWorker limit DOM API, but don't standard JavaScript. So, including whole es6 is suitable.
(Window object is limited partly. But, window object  lib.core.es6.d.ts don't include window object.)
Functions and classes available to Web Workers

@YuichiNukiyama the PR #6990 is trying to separate ES6 into smaller features and adding new pre-set lib (such as "lib.dom.es6.d.ts" + "lib.core.es6.d.ts"). I will fold your change into the PR since it is in the same domain.

@yuit Thank you for your explanation  and suggestion


Add maven wrapper

This provides ability to run latest maven on travis-ci.  It has no effect locally unless you run as 'mvnw' rather than 'mvn'.

Closing until there is a common pom to run the entire build instead of diving in directories.  Travis expects pom in root using this method...


fix: prevent user from deleting the last training data #613

According to this discussion, if all training data is deleted, the option to add new training data doesn't appear in the UI. This creates a problem where users delete all their training data and then can't add new data due to the missing UI interface. This PR addresses the issue by preventing the deletion of the last remaining training data row, ensuring at least one row is always present, which resolves the problem.

@zainhoda  Please review


Famous book allocation problem.

This is one of the most famous and hard questions in Binary Search.

@kritipct don't forget to add your name in the contributors.html file


request

Plz, Add Euphoria technology.

Euphoria 🆚 Ragdoll
https://m.youtube.com/watch?v=kiih_08GGp4

Try to be more detailed on the title and description of your request, also why it benefits the engine and the game developers in general, also what implies the addition of that feature if you want for it to be taken seriously.
Also read
https://docs.godotengine.org/en/3.1/about/faq.html#i-have-a-great-idea-for-godot-how-can-i-share-it
And always have in mind this useful chart
https://twitter.com/reduzio/status/941799197774315525

Indeed, as it stands this feature request doesn't help at all.


No login into Artemis console if external auth service without caCertSecretName is used

Describe the bug
If an address space with an external auth service is used - where caCertSecretName has been omitted, the login into the Artemis console doesn't work.
To Reproduce
Steps to reproduce the behavior:

Create an address space with a spec like this

  "spec": {
    "type": "standard",
    "plan": "unlimited-standard-without-mqtt",
    "authenticationService": {
      "type": "external",
      "details": {
        "host": "[hostname]",
        "port": 5671,
        "saslInitHost": "default",
        "clientCertSecretName": ""
      }
    }
  }

Note that "caCertSecretName" is not set - requires the authservice to use a proper cert (not a self-signed one).

Create a port-forwarding for the broker:

kubectl port-forward -n hono broker-pooled-default-0 9999:8161

Try to access Artemis console via https://localhost:9999
-> Credentials are not accepted.

Expected behavior
Login to Artemis console works.
Additional context
Log output of Artemis container:
2018-10-29 09:44:20,754 WARN  [io.enmasse.artemis.sasl_delegation.SaslDelegatingLogin] javax.net.ssl.SSLHandshakeException: sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
2018-10-29 09:44:20,755 WARN  [io.hawt.system.Authenticator] Login failed due Exception attempting to authenticate using SASL delegation

This relates to #1580 and the fix for that.
Applies to SaslDelegatingLogin.createSSLContext().

A solution would be to replace the keytool invocation in launch.sh with this:
    local num_certs=$(grep 'END CERTIFICATE' /etc/authservice-ca/tls.crt | wc -l)
    if [ "${num_certs}" == "1" ]; then
        keytool -import -noprompt -file /etc/authservice-ca/tls.crt -alias firstCA -deststorepass ${TRUSTSTORE_PASS} -keystore ${AUTH_TRUSTSTORE_PATH}
    else
        # import certs individually
        for N in $(seq 0 $((${num_certs} - 1))); do
          cat /etc/authservice-ca/tls.crt |
            awk "n==$N { print }; /END CERTIFICATE/ { n++ }" |
              keytool -import -noprompt -alias CA-${N} -deststorepass ${TRUSTSTORE_PASS} -keystore ${AUTH_TRUSTSTORE_PATH}
        done
    fi

However, for the 133 certs in the actual scenario, this takes quite long - 28 seconds.
I wonder whether it wouldn't be better to somehow use the already existing standard java cacerts file.

I saw that approach on SO :/ agreed copying the system trust store and adding to that is better

Fixed by #1881


TextureAtlass async loading issue

[x] Convert TextAssetLoader to AsynchronousAssetLoader.
[x] Handle SynchronousAssetLoader instances on the main rendering thread.

I get an exception during TextureAtlas async loading:

Exception in thread "LWJGL Application" ktx.async.assets.AssetStorageException: Unable to load asset at: textures/preloader/preloader.atlas
at ktx.async.assets.AssetStorage$load$1.doResume(assets.kt:119)
at kotlin.coroutines.experimental.jvm.internal.CoroutineImpl.resumeWithException(CoroutineImpl.kt:60)
at ktx.async.KtxContinuation$resumeWithException$1.run(async.kt:172)
at com.badlogic.gdx.backends.lwjgl.LwjglApplication.executeRunnables(LwjglApplication.java:259)
at com.badlogic.gdx.backends.lwjgl.LwjglApplication.mainLoop(LwjglApplication.java:210)
at com.badlogic.gdx.backends.lwjgl.LwjglApplication$1.run(LwjglApplication.java:126)
Caused by: java.lang.RuntimeException: No OpenGL context found in the current thread.
at org.lwjgl.opengl.GLContext.getCapabilities(GLContext.java:124)
at org.lwjgl.opengl.GL11.glBindTexture(GL11.java:651)
at com.badlogic.gdx.backends.lwjgl.LwjglGL20.glBindTexture(LwjglGL20.java:93)
at com.badlogic.gdx.graphics.GLTexture.bind(GLTexture.java:66)
at com.badlogic.gdx.graphics.GLTexture.setFilter(GLTexture.java:162)
at com.badlogic.gdx.graphics.g2d.TextureAtlas.load(TextureAtlas.java:249)
at com.badlogic.gdx.graphics.g2d.TextureAtlas.(TextureAtlas.java:236)
at com.badlogic.gdx.assets.loaders.TextureAtlasLoader.load(TextureAtlasLoader.java:48)
at com.badlogic.gdx.assets.loaders.TextureAtlasLoader.load(TextureAtlasLoader.java:34)
at ktx.async.assets.LoadersKt.load(loaders.kt:151)
at ktx.async.assets.AssetStorage$loadWithSynchronousLoader$1.invoke(assets.kt:177)
at ktx.async.KtxAsync$asynchronous$$inlined$suspendCancellableCoroutine$lambda$1.call(async.kt:99)
at ktx.async.KtxAsync$asynchronous$$inlined$suspendCancellableCoroutine$lambda$1.call(async.kt:25)
at com.badlogic.gdx.utils.async.AsyncExecutor$2.call(AsyncExecutor.java:58)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
AL lib: (EE) alc_cleanup: 1 device not closed

Here is the code to reproduce it:
override fun create() {
        enableKtxCoroutines(asynchronousExecutorConcurrencyLevel = 1)

        val storage = AssetStorage ()

        ktxAsync {
            storage.apply {
                val texture = load<Texture>("badlogic.jpg")
                println(texture)
                val atlas = load<TextureAtlas>("textures/preloader/preloader.atlas")
                println(atlas)
            }
        }
    }

please note that Texture loaded correctly, but TextureAtlas crushes the app.
When I use AssetManager both loaded well.
It reproduced on

kotlinVersion = '1.1.2-5'
kotlinCoroutinesVersion = '0.16'
ktxVersion = '1.9.6-b5'

I will be pleased with any suggestion.
Thanks in advance.

OK, I know what's the issue. AssetManager code was highly convoluted and when I saw some kind of scheduling tasks, I assumed that SynchronousLoaders are also handled by a separate thread, but it seems that the loading tasks are actually executed on the main thread. The unit tests have not revealed this, as the OpenGL context is mocked during testing. That's an easy fix, I'll look into it soon and release 1.9.6-b6.

Yeah, I was able to reproduce the issue before the changes and it seems to be fixed after the last 2 commits. Snapshot is being released as we speak - as a quick fix, you can use 1.9.6-SNAPSHOT version for now. This is a pretty serious issue, so I'm going to upload the next beta release soon.

Great. thanks. You absolutely smashed it.

It's a bit embarrassing, really, cause I've tested AssetStorage in actual applications, but it seems I've never used atlases then.  Should have tested it more thoroughly.
Anyway, I've uploaded 1.9.6-b6 to Maven Central - it should be already available.

Great job.


duffle import does not add bundle to duffle's internal storage

duffle import and duffle export are intended to be symmetric. duffle export exports a bundle from either duffle's internal storage or a file. duffle import should import a bundle to duffle's internal storage unless the flag --destination is specified in which case it should import to the given destination on the file system.
What actually happens is that duffle import always imports the bundle to a (default) destination on the file system.
Steps to reproduce

Unzip the attachment exporttestbundle.json.zip to exporttestbundle.json.
Export from that file to an archive:$ duffle export exporttestbundle.json -t -f

Check duffle's internal storage:$ duffle bundle list
NAME	VERSION	DIGEST

Import from the exported archive:duffle import testexport-0.1.tgz

Check duffle's internal storage:$ duffle bundle list
NAME	VERSION	DIGEST

Observe the imported bundle on the file system:$ ls -l testexport-0.1
total 8
-rw-r--r--  1 glyn  staff  219 11 Apr 11:38 bundle.json

What should have happened?
At step 5, the bundle should have shown up in duffle's internal storage.
At step 6, there should not have been an imported bundle on the file system.
/cc @michelleN

https://github.com/deislabs/duffle/issues/717 would be nice to have before addressing this issue.

Unassigning so someone else can take this. I won't be able to get round to it for some time.


Configured OpenAI APIs not saving between restarts

Bug Report
Description
Bug Summary:
Whenever I set up my OpenAI compatible endpoints and hit save, it works great until I restart the container, when it gets wiped. I made sure that there is storage set up, which there is. Audio and Image generation setup also reset. All other configuration, chat history, and users save just fine.
Steps to Reproduce:

Download latest container.
Run the container.
Set up OpenAI endpoints.
Restart container.
Endpoints are gone.

Expected Behavior:
The OpenAI compatible endpoints, image config, and audio config should save between restarts.
Actual Behavior:
The OpenAI endpoints, image config, and audio config get reset between restarts.
Environment

Operating System: MacOS Sonoma 14.4.1, Ubuntu 22.04 LTS
Browser (if applicable): Firefox 125.0.1

Reproduction Details
Confirmation:

[x] I have read and followed all the instructions provided in the README.md.
[x] I am on the latest version of both Open WebUI and Ollama.
[x] I have included the browser console logs. Not Relevant.
[x] I have included the Docker container logs. Logs show no sign of issue.

Installation Method
On MacOS, followed the official Quick Start Docker instructions.
Installation on Ubuntu 22.04 LTS was manual as I'm using Coolify v4 to host all my personal use containers on my Linux server.

Duplicate:

#1264


fix(test): storage scrubber should only log to stdout with info

Problem
As @koivunej mentioned in the storage channel, for regress test, we don't need to create a log file for the scrubber, and we should reduce noisy logs.
Summary of changes

Disable log file creation for storage scrubber
Only log at info level

Checklist before requesting a review

[x] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

[ ] Do not forget to reformat commit message to not include the above checklist

Example test report. It still has the same captured (note captured stderr and stdout files) AND forwarded logging (see test log).
Overall it's more healthy to output two (stderr, "pipe" to test log) rather than three times (stderr, "pipe" to test log, write to special file). I do not understand why we need to pipe it to the test log in any case. We do not do this for pageserver, for example, or safekeepers, or postgres, or storage controller.

Well, probably it's because scrubber is a foreground process that gets explicitly called in the code path. I'll see how to fully remove it...

added a commit https://github.com/neondatabase/neon/pull/9067/commits/0d1e1d3d9354077ee6cb17513d61c96f1e15805b

should finally work now (tried different combinations of these parameters 🤣)


[Enhancement] Support excluded_trigger_tables property for materialized view

What type of PR is this：

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #13167
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[x] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[FE PR Coverage Check]
:disappointed: fail : 16 / 90 (17.78%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/analyzer/AnalyzerUtils.java
0
8
00.00%
[468, 469, 470, 471, 472, 473, 474, 476]

:large_blue_circle:
com/starrocks/common/util/PropertyAnalyzer.java
0
13
00.00%
[240, 241, 242, 243, 244, 245, 246, 247, 249, 250, 252, 253, 255]

:large_blue_circle:
com/starrocks/catalog/MaterializedView.java
1
24
04.17%
[575, 576, 578, 579, 580, 581, 582, 585, 586, 589, 590, 669, 670, 671, 686, 687, 688, 689, 692, 693, 694, 697, 698]

:large_blue_circle:
com/starrocks/server/LocalMetastore.java
1
13
07.69%
[3326, 3327, 3328, 3329, 3330, 3331, 3333, 3335, 3336, 3339, 3340, 3341]

:large_blue_circle:
com/starrocks/catalog/TableProperty.java
7
17
41.18%
[195, 196, 197, 198, 199, 200, 201, 279, 283, 284]

:large_blue_circle:
com/starrocks/transaction/PublishVersionDaemon.java
7
15
46.67%
[382, 383, 387, 388, 390, 391, 393, 397]

run starrocks_admit_test

run starrocks_fe_unittest

[FE PR Coverage Check]
:disappointed: fail : 18 / 91 (19.78%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/analyzer/AnalyzerUtils.java
0
8
00.00%
[468, 469, 470, 471, 472, 473, 474, 476]

:large_blue_circle:
com/starrocks/common/util/PropertyAnalyzer.java
0
13
00.00%
[240, 241, 242, 243, 244, 245, 246, 247, 249, 250, 252, 253, 255]

:large_blue_circle:
com/starrocks/catalog/MaterializedView.java
1
24
04.17%
[575, 576, 578, 579, 580, 581, 582, 585, 586, 589, 590, 669, 670, 671, 686, 687, 688, 689, 692, 693, 694, 697, 698]

:large_blue_circle:
com/starrocks/server/LocalMetastore.java
1
13
07.69%
[3326, 3327, 3328, 3329, 3330, 3331, 3333, 3335, 3336, 3339, 3340, 3341]

:large_blue_circle:
com/starrocks/catalog/TableProperty.java
7
17
41.18%
[195, 196, 197, 198, 199, 200, 201, 279, 283, 284]

:large_blue_circle:
com/starrocks/transaction/PublishVersionDaemon.java
9
16
56.25%
[385, 386, 390, 391, 393, 396, 397]


Return results in Operation event for visibility of actions

What is this PR doing?
Making actions and (failing results) more accessible.
How can these changes be manually tested?
Unit test for failing action.
Look at Operation event logs of for action data when all succeed, and an error message when one action fails.
Does this PR resolve or contribute to any issues?
Closes #193
Checklist

[x] I have manually tested these changes
[x] Post a link to the PR in the group chat

Guidelines

If your PR is not ready, mark it as a draft
The resolve conversation button is for reviewers, not authors

(But add a 'done' comment or similar)

Who can update what is required on the client side for this PR to be merged? @jacque006 @kautukkundan @voltrevo

@kautukkundan Will update


[WIP] Vcx mobile builds

This is debug version of #1562

Initial PR is merged, this PR doesn't required anymore


Paper reproduction results

The classifier accuracy on the EmpatheticDialogues test set is only 35.20% when i use your checkpoint of the predict_emo. It doesn't have the precision that you have in your paper. What do you think might have caused this. I am looking forward to your reply.

Hi,
We calculated the weighted precision of MEED2 (OS->ED) on ED, and the score is 0.2660. We didn't report accuracy scores.

Actually that is the emotion classifier we used to label each utterance in the OS dataset. The classifier you ran is the response emotion/intent predictor in the MEED2 model, which predicts the emotion/intent of next utterance (the reply to be generated).

I'm glad you solved my doubts. Can you open source the code of your emotion classifier？Thank you very much!

Thank you very much for your work. I wish you happy every day!


Update troubleshooting-harness.md

https://harness.atlassian.net/browse/CDS-75313
For paying customers it's 400 / 24 hours
Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.
What Type of PR is This?

[ ] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app


[Docker version 1.4.1, build 5bc2ff8] Docker build error message shows FATA instead FATAL

The error message print FATA instead of FATAL word, It confuses if we want to automate troubleshooting
The following is an example of an error message
FATA[0000] Error: We do not understand this file. Please ensure it is a valid Dockerfile. ....

This is the default format by our logging library logrus. I think the reason it does not say FATAL is so all types are of the same legth re: INFO, WARN, etc all four letters. It is easy to parse when not in a tty, aka when logs are piped to a file.
example
time="2015-01-14T13:27:46-08:00" level="info" msg="-job log(pull, debian:sid, ) = OK (0)"
time="2015-01-14T13:27:46-08:00" level="info" msg="-job pull(debian, sid) = OK (0)"
time="2015-01-14T14:13:55-08:00" level="debug" msg="Calling POST /containers/{name:.*}/resize"
time="2015-01-14T14:13:55-08:00" level="info" msg="POST /v1.16/containers/7356fc6fb486a26afcd953f0678800a848546205dab2aa6feb507fd9a95998df/resize?h=49&w=173"
time="2015-01-14T14:13:55-08:00" level="info" msg="+job resize(7356fc6fb486a26afcd953f0678800a848546205dab2aa6feb507fd9a95998df, 49, 173)"
time="2015-01-14T14:13:55-08:00" level="info" msg="-job resize(7356fc6fb486a26afcd953f0678800a848546205dab2aa6feb507fd9a95998df, 49, 173) = OK (0)"
time="2015-01-14T14:22:41-08:00" level="debug" msg="Calling POST /containers/{name:.*}/resize"
time="2015-01-14T14:22:41-08:00" level="info" msg="POST /v1.16/containers/7356fc6fb486a26afcd953f0678800a848546205dab2aa6feb507fd9a95998df/resize?h=66&w=232"
time="2015-01-14T14:22:41-08:00" level="info" msg="+job resize(7356fc6fb486a26afcd953f0678800a848546205dab2aa6feb507fd9a95998df, 66, 232)"
time="2015-01-14T14:22:41-08:00" level="info" msg="-job resize(7356fc6fb486a26afcd953f0678800a848546205dab2aa6feb507fd9a95998df, 66, 232) = OK (0)"

So closing, but let me know if there is still some confusion

heres a nice pic too that shows the output when not sent to a file:

^^ the first INFO should be a WARN, because a group of walruses is called a herd :)


Error compiling umap

I tried the basic test with iris data but I found this issue:
---------------------------------------------------------------------------
TypingError                               Traceback (most recent call last)
<ipython-input-20-31642242b990> in <module>
----> 1 embedding = reducer.fit_transform(iris.data)
      2 embedding.shape

~/anaconda/lib/python3.6/site-packages/umap/umap_.py in fit_transform(self, X, y)
   1594             Embedding of the training data in low-dimensional space.
   1595         """
-> 1596         self.fit(X, y)
   1597         return self.embedding_
   1598

~/anaconda/lib/python3.6/site-packages/umap/umap_.py in fit(self, X, y)
   1417                 self.set_op_mix_ratio,
   1418                 self.local_connectivity,
-> 1419                 self.verbose,
   1420             )
   1421         else:

~/anaconda/lib/python3.6/site-packages/numba/dispatcher.py in _compile_for_args(self, *args, **kws)
    348                 e.patch_message(msg)
    349
--> 350             error_rewrite(e, 'typing')
    351         except errors.UnsupportedError as e:
    352             # Something unsupported is present in the user code, add help info

~/anaconda/lib/python3.6/site-packages/numba/dispatcher.py in error_rewrite(e, issue_type)
    315                 raise e
    316             else:
--> 317                 reraise(type(e), e, None)
    318
    319         argtypes = []

~/anaconda/lib/python3.6/site-packages/numba/six.py in reraise(tp, value, tb)
    656             value = tp()
    657         if value.__traceback__ is not tb:
--> 658             raise value.with_traceback(tb)
    659         raise value
    660

TypingError: Failed in nopython mode pipeline (step: nopython frontend)
Unknown attribute 'shape' of type none

File "../../anaconda/lib/python3.6/site-packages/umap/umap_.py", line 93:
def smooth_knn_dist(distances, k, n_iter=64, local_connectivity=1.0, bandwidth=1.0):
    <source elided>
    target = np.log2(k) * bandwidth
    rho = np.zeros(distances.shape[0])
    ^

[1] During: typing of get attribute at /Users/Andres/anaconda/lib/python3.6/site-packages/umap/umap_.py (93)

File "../../anaconda/lib/python3.6/site-packages/umap/umap_.py", line 93:
def smooth_knn_dist(distances, k, n_iter=64, local_connectivity=1.0, bandwidth=1.0):
    <source elided>
    target = np.log2(k) * bandwidth
    rho = np.zeros(distances.shape[0])
    ^

This is not usually a problem with Numba itself but instead often caused by
the use of unsupported features or an issue in resolving types.

To see Python/NumPy features supported by the latest release of Numba visit:
http://numba.pydata.org/numba-doc/dev/reference/pysupported.html
and
http://numba.pydata.org/numba-doc/dev/reference/numpysupported.html

For more information about typing errors and how to debug them visit:
http://numba.pydata.org/numba-doc/latest/user/troubleshoot.html#my-code-doesn-t-compile

If you think your code should work with Numba, please report the error message
and traceback, along with a minimal reproducer at:
https://github.com/numba/numba/issues/new

Hi @andresgalarza-astro , thanks for trying out Numba and for reporting this. I will fixup your comment to use markdown for formatting. Also, could you list the version of Numbad and umap that you are working with with? Thanks!

Sure!
Versions are: Numba  0.43.1 and umap 0.3.9

@andresgalarza-astro great, could you perhaps upgrade to the latest Numba 0.44.1 and check if the error persists. If yes, please report back the commands you used to run the tests so that we can try to reproduce this.

Sorry for the delay.
I'll follow your suggestion and give a feedback later in the day

Closing this issue due to lack of information. If more information becomes available please add it and reopen the issue. Thanks.


CB-9881 Introduce imagevalidation Spring profile

See detailed description in the commit message.

do we have enough quota there ?

do we have enough quota there ?

I asked around in e2e channel if there can be any problems with it, and this concern was not raised. How can I verify if we have enough quota?

Application properties moved to https://github.com/hortonworks/cloudbreak-ansible-playbooks/pull/151/files


Adicionar Conquistas

Seria interessante vocês adicionarem um sistema de conquistas.

It is a suggestion that comes frequently. It is not a priority right now, but it may be worked on in the future

implemented in the #1031


Error 5 when starting the terminal

Issue Type: Bug
It was working fine until vscode restarted and updated to the 1.60 version.
Now when trying to open the terminal this error is displayed:
The terminal process failed to launch: A native exception occurred during launch (Cannot create process, error code: 5).
powershell is blocked on my machine but even configuring to run with cmd the error happens
VS Code version: Code 1.60.0 (e7d7e9a, 2021-09-01T10:41:52.311Z)
OS version: Windows_NT x64 10.0.19043

/duplicate of #132149


better @media(print) rules

Try printing the model page! it will be less janky

More coming today!


Add holographic remoting documentation article

This change adds a new holographic remoting article to the github.io documentation. It now contains the setup and connection instructions that previously were added to the release notes, with the added benefit of screenshots illustrating the steps.
The release notes were updated to replace the detailed steps with a link to this page as well as adding information about how to avoid a known issue with some versions of Unity.
While adding the new page to the table of contents, i took the opportunity to alphbetize the Tools section.

/azp run mrtk_docs

/azp run mrtk_docs

/azp run mrtk_docs

/azp run mrtk_docs

/azp run mrtk_docs

a bunch of the pictures have a lot of dead vertical space

I am happy to trim them now :)

/azp run mrtk_docs


Performance & a Progress bar

I'm using Jigsaw for a project that has many source files, so I needed a short generation time to limit the down time (because I do the build in the production).

Clean build folder after the generation, to make the down time short. (currently, cleaning happens before)
Faster by 70%...
& a Progress bar

↓

To try,  copy the following to your composer.json:
{
    "repositories": [{
        "type": "vcs",
        "url": "https://github.com/abdumu/jigsaw"
    }],
    "require": {
        "tightenco/jigsaw": "dev-master"
    }
}

There are some great ideas here that would definitely be helpful for larger sites. It might even be worth building the complete site to a temp directory, then copying the temp directory to build_production upon completion, to (1) minimize downtime, and (2) protect build_production if something goes wrong during build.
Can you explain the speed/memory difference? Is it solely the result of using path() rather than files() when calling the Symfony Finder?

Yes, my implementation will only clean build folder after the source generation ends which will prevent an empty production build folder.
The slowness is from Finder class, and my last commit I used  Symfony\Component\Finder\SplFileInfo directly for getting one fille and Finder is still good for allFiles method.
I closed this commit because it didn't pass the tests, and now it does. (except for one test which is still impassable by original code)

Excellent, thanks for updating. I'll take a look!

I'll just throw in my 2c here...
Just tested this on my site which is ~4k pages.  Vanilla jigsaw builds it in 1:12.  This PR builds it in 34 seconds.  Diff showed the site building identically.
I'd just be incredibly pleased to see this integrated.

Great...we're working on some other optimizations that will reduce that oven further.

I'm gonna close this PR.
Jigsaw is not meant for large number of files (crashes due to memory consumption) , and my upcoming changes won't be welcomed because I'm going and I did some change to the 'core' codes.
For those who face performance/speed issues with current Jigsaw, you are more than welcome to use/fix my forked repo.
Thanks.

Is this actually dead?  I thought progress was being made?

Nope, it's not dead. We'll be incorporating the SpfFileInfo change that @abdumu suggested here, along with a few other performance improvements we've been working on, in the next Jigsaw release.

@cjf
I don't think it's dead, I closed the repo because it's now a different code that what described earlier and now it has its own package for those who wants a version that focus on performance and speed:
https://github.com/abdumu/jigsaw
enjoy.

@abdumu Is there a performance improvement you think needs to be made that has not been either made or planned? This feels like a bit of a weird interaction.

@mattstauffer what "weird interaction" ?

@abdumu Keith has made it clear he's intending to including changes targeted at large numbers of files, and that he's incorporating your suggestion. You then closed the PR saying that Jigsaw won't be making the changes we said we're making, and you're now maintaining a fork because you're saying Jigsaw isn't focusing on the things that Keith just said we're going to address.
My assumption is that we're just having a miscommunication here, or everyone else reading this understands something I don't, which is why I'm asking you for clarification.
Thanks!

@mattstauffer I said "I closed [it]" because "it's now a different code than what described earlier" and " [it] changes ... the 'core' codes" ..

@abdumu OK, cool. :) Thanks for clarifying that it was about a difference in opinion of how to address an issue, not whether. <3


AzureRT PR - Update Tests & Split Large Code File

Hi @huangpf, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (phuang). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

Lots of file, but does it include updating nuget version?

@yugangw-msft Thanks for the comment. I shall update the version for ARM Compute, even though it's just splitting the files.


Image data generator parameters

Hi,
First of all, I would like to commend you on building a great toolbox for deep learning.
I am using the Image data generator in my code as follows:
datagen = ImageDataGenerator(
featurewise_center=True, # set input mean to 0 over the dataset
samplewise_center=True, # set each sample mean to 0
featurewise_std_normalization=True, # divide inputs by std of the dataset
samplewise_std_normalization=True, # divide each input by its std
zca_whitening=False, # apply ZCA whitening
rotation_range=20, # randomly rotate images in the range (degrees, 0 to 180)
width_shift_range=0.2, # randomly shift images horizontally (fraction of total width)
height_shift_range=0.2, # randomly shift images vertically (fraction of total height)
horizontal_flip=True, # randomly flip images
vertical_flip=False) # randomly flip images
X_sample,_=load_data(batch_size=300,names_file=image_files,labels_file=image_labels,stain_number=stain_no)
datagen.fit(X_sample)
After training the model using image augmentation, I would like to extract the hidden representations of the model on the training and testing data.
However, I understand that I would have to do the transformations included in the data generator like feature wise_centre and sample wise_center.
Is there a way to access the parameters of the data generator to transform the images or would I have to do them manually?
Thanks again,
Aritra

Sure, they are class attributes and you can access them. You can just check out the code for details.


Improve formatting inserted by  widget

At present, the <time> widget inserts the following formatting into the compose box, which is difficult to read at a glance:
<time:2021-07-14T00:14:00-07:00>
Instead, we should have the <time> widget insert the following formatting:
<time:2021-07-14|00:14:00|UTC-07:00>
Our parser should accept both the old and the new format.
See also CZO discussion thread.

@zulipbot claim


add verify settings to gitattributes and editorconfig

https://github.com/VerifyTests/Verify?tab=readme-ov-file#editorconfig-settings

@dmytrostruk https://github.com/VerifyTests/Verify?tab=readme-ov-file#editorconfig-settings

bump

Hi @dmytrostruk: is this something we still want to move forward with? Looking to clean up some older PRs. Thanks.

Hi @dmytrostruk: is this something we still want to move forward with? Looking to clean up some older PRs. Thanks.

Taking into account that Verify library is used only in one unit test in entire codebase, I created another PR to remove this dependency: https://github.com/microsoft/semantic-kernel/pull/9879. Based on that, I think we can close this PR.
@SimonCropp In all cases, thanks for your contribution and your interest in Semantic Kernel!


Convert LSPTypecheckerDelegate to an interface

This adds an interface class for the methods of LSPTypecheckerDelegate, with all methods marked virtual.
Motivation
For now this is a functional no-op, but later on when serving requests from stale GlobalState, we'll need to expose somewhat different implementations of these methods.
It's worth noting that I'm not sure all the methods will be implementable from stale GlobalState. I think starting from that assumption is probably the best thing to do, since every existing LSPTask depends on the interface exposed by LSPTypecheckerDelegate, but we may well want to tweak/refactor the interface down the line as we discover restrictions/limitations/caveats.
Test plan
I think this should be an "if it compiles and the existing tests pass, everything is fine" situation.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_LIAH6PrHaN3d0M
→ https://go/builds/bui_LIAHtkg4Olcb7d


Set property shortcut

Instead of having to create set_name() methods, support something like name='World'.

Done in https://github.com/adamghill/django-unicorn/commit/3a30c3fd75a8989f5597555d4d1dc208b772ad1c.


Extract sbt plugin

Current coverage is 40.67%

Merging #104 into master will not affect coverage as of c8a71b5

@@            master    #104   diff @@
======================================
  Files           36      36
  Stmts          531     531
  Branches        52      52
  Methods          0       0
======================================
  Hit            216     216
  Partial          0       0
  Missed         315     315

Review entire Coverage Diff as of c8a71b5

Powered by Codecov. Updated on successful CI builds.


Allow filtering and ordering students on the home page

When viewing the homepage with the list of all the students, let a user order alphabetically by name, or find all students of a certain grade level, or start typing the name of a student to find them. There are many ways to do this in the UI - try to figure out what's the most intuitive and has the best user experience.

make search bar for students, sort button for grades/names by numerical/alphabetical order


[Enhancement]Support show create for sync mv

What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes:

Fixes #
Problem Summary(Required):

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[ ] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

I have no idea why the unit test failed.

[FE PR Coverage Check]
:disappointed: fail : 0 / 38 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/ShowExecutor.java
0
38
00.00%
[505, 508, 509, 510, 511, 513, 514, 515, 516, 517, 518, 520, 521, 522, 523, 524, 525, 599, 600, 1090, 1091, 1095, 1096, 1097, 1098, 1099, 1100, 1101, 1102, 1103, 1104, 1106, 1107, 1110, 1111, 1113, 1115, 1116]

@Astralidea Hi, could you find any one else to review it?


Expose wait_timeout in MTV  wait  methods

Short description:
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

/approve

/approve

/verfied

/verified


How to integrate with golang/Gin framework

Hello ,
This is pretty much simple and easy to understand the script. But I am using the Golang GIN framework for my microservices.
Where I have a configuration file and some different Redis servers for which I need a simple health check service for Redis connection. Do you have any sample examples for the same? It will be really helpful to me if i get a custom example that explains how to use this lib in Gin Framework.

I think sample in readme is pretty straightforward, it can be used with Gin also.

@dhiemaz i have worked on it more than hour but i could not succeed. do you have a living example?

@bilalcaliskan
	handler := health.NewHandler()
	handler.AddChecker("Go", url.NewCheckerWithTimeout("https://golang.org/", 5 * time.Second))

	r := gin.Default()
	r.GET("/health/", gin.WrapF(handler))
	r.Run() // listen and serve on <IP_ADDRESS>:8080 (for windows "localhost:8080")

@dimiro1 that is a good example, thanks for that!


Correctly set realert, aggregation, query_delay from the config

Hi! It seems that the query_delay field isn't correctly inherited from the config file. Trying to set query_delay: {'minutes': 1} in elasticsearch.yml results in the following exception:
Traceback (most recent call last):
  File "/usr/local/bin/elastalert", line 11, in <module>
    load_entry_point('elastalert==0.1.38', 'console_scripts', 'elastalert')()
  File "/usr/local/lib/python2.7/dist-packages/elastalert/elastalert.py", line 1919, in main
    client.start()
  File "/usr/local/lib/python2.7/dist-packages/elastalert/elastalert.py", line 1100, in start
    self.run_all_rules()
  File "/usr/local/lib/python2.7/dist-packages/elastalert/elastalert.py", line 1162, in run_all_rules
    endtime = ts_now() - delay
TypeError: unsupported operand type(s) for -: 'datetime.datetime' and 'dict'

Inspecting the code, it looks like this line is setting query_delay to the dict instead of converting it to a datetime. This PR should fix the issue for all the relevant timedelta fields.

Opps, just took a look at open issues and it seems like there's already some conversation about this: #2098 #2113


Add 3D vector coordinates object to the viewer

🚀 Feature
It would be nice if the viewer could also show the current direction of each axis via a simple 3D vector triplet which can be found in many 3D viewing applications, like Blender (example).
Motivation
Having the current axis directions spelled out in the viewer may help with the general orientation of the object and the viewer. In addition, if the axes are labeled, the name of each dimension will also be shown on the tips of these arrows, which can be quite helpful. Additionally, if and when napari will have support for global and relative coordinates, these arrows will also help determining the viewer's perspective as well.
Alternatives
napari's awesome regardless of this little pointing rotating object :)

I'm fine with this as long as it is easy to turn on and off. Vispy has some machinery to make this super easy. I'd prefer to wait though until #885 goes in and we start thinking about scale bars and how we are going to overlay them. I see these visuals as more belonging to the viewer than any one particular layer, and we don't quite have that abstraction yet. It may come with some plans in #772


Add metrics

This commit adds only one metric--segment copies per second--but it lays the foundation for further adding more metrics.

@jeqo I just didn't think about this. Thank you for pointing this out. Despite I like the old style MBean hierarchy :) I'll switch to the Metrics: no need to borrow code in this case.

Thanks again @jeqo, it turned out simpler and shorter :)


Data Cleaning Pipeline

Context
We are hoping to automatically ingest our datasets in from sources (when possible and appropriate).  This task is to do data quality validation to identify existing issues, and handle any possible future ones.  The owner of this task will be responsible for creating a process that validates and corrects errors so that a future automated call to the data source will result in usable and quality data to be displayed to users.
Datasets are here
Additional Info here
Definition of Done

identify what data quality issues we have and may have in our datasets

ex: address mispellings
missing geometries
incorrectly spelled categorizations

write a script (or full fledged pipeline) that handles these errors and corrects them

Engineering Details

Please write this in Python

This may need to be split up into a research issue and an implementation issue (first lays out exactly what is dirty and second lays out the code to fix it).
I also think we may need to build the ETL pipeline first... or maybe have the research half of this be part of building out the ETL pipeline? Otherwise there's just not anywhere to put this code...


125 types for exec don't seem to be applied properly

The existing Typescript defs weren't recognized as properties of the default export, so attempting to use them in a Typescript project cause an error.

I've since discovered that one can work around #125 by importing with import { exec } from 'youtube-dl-exec' instead of using the default import:
import ytdl from 'youtube-dl-exec';
ytdl.exec('https://example.com');
// ^ property exec does not exist

… and that my PR fixes the latter but breaks the former. I'll keep working on it and see if I get keep both styles of import working.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.591%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
74

Relevant Lines:
74

💛  - Coveralls

Okay, I've found a way to rework it so that exec and create are declared both as function properties and exports. Both styles of import work now.

I've squashed my commits and redone this PR in #127, sorry for the mess 🫢


List of TODO's

Would love to see a list of TODO's required to complete this project. What are the current show-stoppers, what needs improvement etc. I think this project would a be a great addition to the ruby community, and implementing this TODO might inspire some developers to contribute.
Here's a similar list created by the Rust community: http://www.reddit.com/r/rust/comments/2j37om/the_great_big_libcollections_todo_list/

@mkonecny I no longer think the direction I was going down with Eventless is a good idea. Eventless would only ever be able to work with libraries written in pure Ruby. There are enough critical libraries that are written in C and do I/O that I think Eventless would be effectively useless. Furthermore, if you happen to use any of those gems with Eventless, your event loop will get blocked with no warning.
Thanks for your interest though!


Adding issue templates

Solving issue: Add issue template #31
Added different issue template for report bug and feature requests.
Please review my PR.

Fixes #33

I am NWoC participant. Can you add NWoC label and points?

Sure.
On Tue, Dec 8, 2020 at 1:13 AM Kerin Pithawala<EMAIL_ADDRESS>wrote:

I am NWoC participant. Can you add NWoC label and points?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/diyajaiswal11/Bloggitt/pull/32#issuecomment-740138055,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALOVF3JAOH5NSOCEANOLB43STUV5ZANCNFSM4UPF7UJQ
.


Update cz.yml

first version of czech translation
How does this pull request make you feel (in animated GIF format)?
![alt text](giphy link)
What are the relevant GitHub issues?
resolves [link to github issue]
What does this pull request do?
??
How should this be manually tested?
??
Is there any background context you want to provide for reviewers?
??
Questions for the pull request author (delete any that don't apply):

[ ] Are any needed README/wiki/documentation updates needed for this pull request?
[ ] Does the code you updated have tests? If not, could you add some please?
[ ] Does this pull request require any new server dependencies which need to be added to the build process? If so, please explain what.

Acceptance Criteria
These should be checked by the reviewers

[ ] This pull request does not cause the database export script to become out of sync with the db schema

Thank you for doing doing both of these translation PRs. But, as it turns out, the CZ one isn't used. CZ redirects to CS.
We have CZ historically because of a wrong assumption that I made when we were first adding non-EN languages to the site. We now use CS for all things Czech. I'll close this PR and we can focus on the other one instead:
#1762


[AutoSuggestBox] PlaceholderText does not vertically align to the center

Describe the bug
The PlaceholderText in the AutoSuggestBox is not vertically aligned. This requires devs to go into the control template to fix it which isn't productive
Steps to reproduce the behavior

Add AutoSuggestBox with a PlaceholderText and increase the height.
See the result

  <AutoSuggestBox PlaceholderText="Replace with" Height="48" Padding="12,12,0,0" VerticalAlignment="Center" VerticalContentAlignment="Center" />
Expected behavior
PlaceholderText should vertically align, like the actual Text in AutoSuggestBox itself. TextBox does this correctly.
Screenshots
PlaceholderText:

Actual text:

Version Info
C++, Xaml Islands, 2.7.0-prerelease.210913003

Windows version
Saw the problem?

May 2021 Update (19043)
Yes

Device form factor
Saw the problem?

Desktop
Yes

@chingucoding Do you know if there's a lightweight setting to do this? Or only overriding the template for the entire thing? Seems to be a similar issue like the one with the misaligned x or search icon?

I'm afraid there is not much you can do here @niels9001 . You can pretty much only retemplate the control to fix this bug. The fix would be to set the VerticalContentAlignment of the placeholder presenter. If the team's fine with that, I would like to fix this.


Update Documentation for OnboardingView screen

Update Documentation for OnboardingView screen
:recycle: Current situation & Problem
I noticed that the documentation for the initializers and overall descriptions of this screen were a bit unclear vague when I was trying to use them.
:books: Documentation

Added additional details for each initializer and what differentiates each one
Added more of a specific description to the overall view

:pencil: Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

[x] I agree to follow the Code of Conduct and Contributing Guidelines.

@PSchmiedmayer the set of required checks is a bit weird here. The checks getting run are slightly different to the ones that the branch protection rule enforces.

@Supereg We already adjusted them for #39 and once this is merged we could merge this PR.

Thanks @akanshyabhat for the PR! Just had some minor comments!

Thank you so much for your feedback @philippzagar! I just implemented it all and would appreciate it if you could take another look.

Thanks for incorporating the change requests, feel free to merge the PR @akanshyabhat 🚀

Thank you so much @philippzagar ! On my end, it says that merging is blocked and that there are two workflows awaiting approval. I'm also not quite sure how to show that I made the changes that Paul had requested.

@akanshyabhat Just approved the workflows, they should complete within a couple of minutes

@philippzagar I'm still getting a message saying that I can't merge until the requested changes (left by Paul) have been addressed. I'm not quite sure how I can address that beyond resolving the conversations which I've already done.

@philippzagar I'm still getting a message saying that I can't merge until the requested changes (left by Paul) have been addressed. I'm not quite sure how I can address that beyond resolving the conversations which I've already done.

The issue is resolved now, I dismissed Paul's review

@philippzagar I'm still getting a message saying that I can't merge until the requested changes (left by Paul) have been addressed. I'm not quite sure how I can address that beyond resolving the conversations which I've already done.

The issue is resolved now, I dismissed Paul's review

Thank you so much!

@akanshyabhat Your commits on the feature branch are unsigned, please ensure that you properly set up your local commit signing: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification


fix: getRelativeRepoPath for the case of vault-inside-repo

This fixes #660.
Currently, getRelativeRepoPath considers only the case of git repository is located inside the vault.
If the vault is inside a subdirectory of git repository (this is a common case when you are using a self-host publishing system like Quartz), line authoring feature won't work.
This code resolves the relative path between git repo and vault using path library.

Hey, thanks for this pr and your contribution! This was a great start, but I changed it so that the basePath setting is not needed to point to the repo root, but can be a subdirectory. Additionally, I needed to align the getRelativeVaultPath method as well. Let me know if you think something is off now. Thanks again.

Okay great. But the submodule issue was there before this pr and persisted after your version of this pr as well, right?

Yes.

thanks folks!


Fix background music interruption on plugin init on Android and iOS

This patch fixes background audio or music from other apps being interrupted when an app with this plugin was started, both on iOS and Android.
On iOS: Removed deprecated AudioSessionInitialize call and extra setCategory and setActive calls that where not really needed and where overriding the main initialization call.
On Android: removed the AudioManager requestAudioFocus call that is not really needed, playing audio will work fine without this call.

I just tried this and can verify it works on iOS

@shi11 You are describing a differenct case, whereas your app is the one that should play in the background. The fix and this issue is about not stopping possibly running background music (switched roles of the apps).

@mxmzb correct - audio from my app should continue in the background. This is existing behavior in the master branch. Unfortunately this PR breaks that. I would love for this patch to work as well as not break existing behavior.

We are now maintaining a forked version wizpanda/cordova-plugin-nativeaudio of this plugin which has this commit included.

We are now maintaining a forked version wizpanda/cordova-plugin-nativeaudio of this plugin which includes commits from this PR.

Hey, really appreciate you maintaining a fork with these changes. Has saved me a lot of time!
I'm trying to use it in a project but can't get the sound to play on iOS for some reason. The app is basically a timer that plays a sound when it reaches 0. Was working fine using cordova-plugin-nativeaudio 3.0.9 on npm but I got complaints about it stopping spotify/background music so needed an alternative. Using ionic native on ios12.2. My code is as follows:
Preload the audio:
this.nativeAudio.preloadComplex('timerFinished', 'assets/audio/timer.mp3', 1, 1, 0);
And when the timer reaches 0:
this.nativeAudio.play('timerFinished');
If I monitor the events, the are all triggered. As in, the audio seems to be preloaded, and thinks it is playing. Not getting any errors. However I never hear a sound. Any ideas what could be going wrong?

I just tried with one of my app and it worked fine. Is it possible for you to create a fresh app & test that?

@sagrawal31 many thanks for maintaining your fork of this repo. Unfortunately I don't see the Issues section in your repo so I don't know where to add my comments.
It's about pausing music in background mode. This line does it on Android.
I don't know why it was implemented like this but I think it must allow playing music on background or at least this should be optional. Is it possible to change this behavior in your fork?

Thanks @andrey3diq. We can make that as configuration for sure.


Cross Process Propagation Headers Protocol v2

Cross Process Propagation Headers Protocol v2, a.k.a. sw6 header protocol, is provided in this PR.
Differences from v1
The major differences of v2 and v1, comes from SkyWalking's evolution, including

Mesh and languages are not same always, some info in headers should be optional.
BASE64 encoding required.
Sampling flag is including.

Read PR for more details. Notice this protocol will be supported from 6.0.0-beta, not the first 6.0.0 release, also the old sw3 header will be supported too.
@adriancole Is this header similar to Zipkin new header?
@ZackButcher @lizan @dio

Coverage increased (+0.1%) to 14.194% when pulling 1263e3d8efb633afb39ec3928911a23ab6068b4a on sw6-header into c467e5c723e75b0f515b4823e84de4522824882d on master.


finishing work on marshaling/serialization bug

RFC8259 compatible MarshalJSON() and Serialize() for events.
Using fast Marshaling Unmarshaling in relay.go.
moved escapeString to helpers.go.

Have been testing publishing/subscribing with many relays. Seems like this fixes #28

too much of a mess, closing. will submit a fresh one


Don't reread the initial state

With this we only read the endpoints, models and policies once during
startup.

@espindola But won't this break chisel dev when I add a new endpoint, for example?

@espindola But won't this break chisel dev when I add a new endpoint, for example?

No. Chisel dev effectively issues 'chisel apply' on demand. The two reads were happening early on startup.


Add bogus, custom benchmarks

Hello, I've structured the setup step a bit, and added MemoryDiagnoser to see the allocations clearly (which is important in this case).
Also, It would be very nice to have standard FSharp.Core methods like Array.map, Seq.map, List.map next to their linq counterparts.
I've got the following results running it:
BenchmarkDotNet=v0.13.1, OS=macOS Big Sur 11.4 (20F71) [Darwin 20.5.0]
Intel Core i9-9980HK CPU 2.40GHz, 1 CPU, 16 logical and 8 physical cores
.NET SDK=6.0.100
  [Host]     : .NET 6.0.0 (<IP_ADDRESS>210), X64 RyuJIT DEBUG
  DefaultJob : .NET 6.0.0 (<IP_ADDRESS>210), X64 RyuJIT

Method
Mean
Error
StdDev
Median
Allocated

System_Linq_select_fslist
207.16 us
3.001 us
2.506 us
206.65 us
160 B

Funtom_Linq_select_fslist
103.02 us
0.848 us
0.751 us
103.12 us
40 B

System_Linq_select_array
81.00 us
1.336 us
2.510 us
79.80 us
112 B

Funtom_Linq_select_array
69.61 us
0.303 us
0.253 us
69.54 us
72 B

System_Linq_select_resizearray
105.14 us
0.379 us
0.355 us
105.05 us
136 B

Funtom_Linq_select_resizearray
67.09 us
1.053 us
0.985 us
66.73 us
48 B

System_Linq_select_seq
138.79 us
0.684 us
0.606 us
138.64 us
152 B

Funtom_Linq_select_seq
154.78 us
0.916 us
0.857 us
154.74 us
152 B

Please tell me your opinion on this.

Here's a followup with arm64 CPU and Seq.map, Array.map, List.map methods added for comparison.

I agree with you.
Thank you for your help!
I'm sure I'll merge your pull requests!


Calendar draws more -outside elements per month than it should

The calendar draws one more line of -outside dates per month.
On the example image below, Calendar should stop on 3rd of January but displays one more row of January dates.

This is intentional since some months can expand to use that extra row.


fix name for bower

bower install
bower BrandButtons#0.2      not-cached git://github.com/theaqua/BrandButtons.git#0.2
bower BrandButtons#0.2         resolve git://github.com/theaqua/BrandButtons.git#0.2
bower BrandButtons#0.2        download https://github.com/theaqua/BrandButtons/archive/0.2.tar.gz
bower BrandButtons#0.2         extract archive.tar.gz
bower BrandButtons#0.2        EINVALID Failed to read /var/folders/1t/y1l91wl10c1dzz3682wqvnxh0000gn/T/moi/bower/BrandButtons-60024-S4pgKb/bower.json
Additional error details:
The name contains upper case letters

Thanks!

could you probably also make a new release? otherwise its not possible to install..

➜  ~  bower info brandbuttons
bower brandbuttons#*            cached git://github.com/theaqua/BrandButtons.git#0.2.1
bower brandbuttons#*          validate 0.2.1 against git://github.com/theaqua/BrandButtons.git#*

{
  name: 'brandbuttons',
  version: '0.2.1',
  homepage: 'https://github.com/theaqua/BrandButtons',
  authors: [
    'Eugene Rodionov<EMAIL_ADDRESS>  ],
  description: 'Brand buttons for Bootstrap',
  main: 'dist/brand-buttons.min.css',
  keywords: [
    'social',
    'brands',
    'bootstrap',
    'buttons'
  ],
  license: 'MIT',
  ignore: [
    '**/.*',
    'node_modules',
    'bower_components',
    'test',
    'tests'
  ]
}

Available versions:
  - 0.2.1
You can request info for a specific version with 'bower info brandbuttons#<version>'
➜  ~


Inferring module type from MIME type vs type attribute needs clarification

This is regarding the explained purpose of the type attribute -- not attributes in general.
With the assert syntax it was obvious that the type of module is ultimately inferred from the MIME header or whatever the host decides, and the asserted type wouldn't change behaviour of the program except to error or not.
import foo from "foo.json" assert { type: "json" };

However with the with syntax, it's not so obvious anymore. But from what I understand and based on https://github.com/tc39/proposal-json-modules which is still stage 3, it's still the case that the type attribute generally doesn't alter non-errant behaviour and the module type is still absolutely determined from the mime type.
import foo from "foo.json" with { type: "json" };

Is that correct? Then it would be weird if hosts started using the same attribute key for things which do alter behaviour, instead of just exploring other keys like { type: "image", as: "canvas"}. I think it should still be strongly discouraged.
So then... should the type attribute be renamed to assertType or something to better indicate that? This would require a breaking change / demotion to https://github.com/tc39/proposal-json-modules as well.
Related issue:

#116 - Imagine with { type: "any" } vs with { assertType: "any" }.

Actually looking at https://github.com/WICG/webcomponents/issues/839 and https://github.com/whatwg/html/issues/7233 side-by-side, shouldn't security-mandated attributes just be true to purpose and look like this?
import foo from "./foo.css" with { csp: "style-src" };
// or
import foo from "./foo.css" with { csp: "weak" };
import bar from "./bar.json" with { csp: "weak" };

What would happen on the web after https://github.com/whatwg/html/issues/7233 is that type will hint to the server what type of module is expected (so it's not just an assertion), and then it will throw if the response doesn't actually match the expected type.
The reason that this proposal has been changed even after reaching stage 3 is that what HTML needs/wants is not just an assertion.
I think it's good to consider more possible import attributes, but at this point that discussion better fits in the HTML repo than here.

Thanks for the reply. I'm using the word "assertion" imprecisely and perhaps the name assertType is off the table since it's sent to the host on request.
But the distinction I'm talking about is the intended purpose of the type attribute generally being to "specify an expectation" on the MIME -> module type rather than to, say, select a transformation on the module type.
The documentation here, written under the assumption of assert { ... } being the surrounding syntax, now lacks needed clarity on what the type attribute is meant for. In my opinion the same applies to name type. Obviously I'm not proposing more attributes.

The syntax has changed; its now “with” instead of “assert”.

The syntax has changed; its now “with” instead of “assert”.

@ljharb Yeah this issue is after that, could you elaborate on your point?

@nayeemrmn ah sorry, i misread your comment. You're saying that the docs need to improve.