Docker upgraded at startup

Summary
We expericed a big issue that EC2 instances cannot join ECS cluster because of docker verison upgrades when new instances launched.
Description
We run ECS optimized AMI with docker version 20.x and ecs-agent 1.82.x, e.g. amzn2-ami-ecs-hvm-2.0.20240328-x86_64-ebs.
We can see docker upgraded to 25.x at startup:
# docker version
Client:
 Version:           25.0.5
 API version:       1.44
 Go version:        go1.22.5
 Git commit:        5dc9bcc
 Built:             Thu Aug 22 17:25:26 2024
 OS/Arch:           linux/amd64
 Context:           default

Server:
 Engine:
  Version:          25.0.6
  API version:      1.44 (minimum version 1.24)
  Go version:       go1.22.5
  Git commit:       b08a51f
  Built:            Thu Aug 22 17:26:01 2024
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.7.11
  GitCommit:        64b8a811b07ba6288238eefc14d898ee0b5b99ba
 runc:
  Version:          1.1.11
  GitCommit:        4bccb38cc9cf198d52bebf2b3a90cd14e7af8c06
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

We checked cloud-init logs and found this:
/var/log/cloud-init-output.log:
Cloud-init v. 19.3-46.amzn2.0.1 running 'modules:config' at Tue, 03 Sep 2024 00:34:30 +0000. Up 9.23 seconds.
Loaded plugins: priorities, update-motd, upgrade-helper
 --> 1:openssl-1.0.2k-24.amzn2.0.12.x86_64 from installed removed (updateinfo)
 --> 2:microcode_ctl-2.1-47.amzn2.4.17.x86_64 from installed removed (updateinfo)
 --> openssh-clients-7.4p1-22.amzn2.0.7.x86_64 from amzn2-core removed (updateinfo)
 --> libdb-utils-5.3.21-24.amzn2.0.5.x86_64 from amzn2-core removed (updateinfo)
 --> 1:openssl-libs-1.0.2k-24.amzn2.0.12.x86_64 from installed removed (updateinfo)
 --> 1:grub2-2.06-14.amzn2.0.3.x86_64 from installed removed (updateinfo)
 --> cloud-init-19.3-46.amzn2.0.2.noarch from amzn2-core removed (updateinfo)
 --> 1:grub2-tools-2.06-14.amzn2.0.3.x86_64 from installed removed (updateinfo)
 --> 1:grub2-pc-modules-2.06-14.amzn2.0.3.noarch from installed removed (updateinfo)
 --> ecs-init-1.86.2-1.amzn2.x86_64 from amzn2extra-ecs removed (updateinfo)
 --> ca-certificates-2023.2.68-1.amzn2.0.1.noarch from amzn2-core removed (updateinfo)
 --> python-jwcrypto-0.4.2-1.amzn2.0.1.noarch from amzn2-core removed (updateinfo)
 --> openssh-7.4p1-22.amzn2.0.7.x86_64 from amzn2-core removed (updateinfo)
 --> amazon-ssm-agent-3.3.380.0-1.amzn2.x86_64 from amzn2-core removed (updateinfo)
 --> 1:grub2-tools-minimal-2.06-14.amzn2.0.3.x86_64 from installed removed (updateinfo)
 --> rpm-4.11.3-48.amzn2.0.3.x86_64 from installed removed (updateinfo)
 --> python-jinja2-2.7.2-3.amzn2.0.1.noarch from installed removed (updateinfo)
 --> libdb-5.3.21-24.amzn2.0.4.x86_64 from installed removed (updateinfo)
 --> 2:tar-1.26-35.amzn2.0.4.x86_64 from amzn2-core removed (updateinfo)
 --> openssh-7.4p1-22.amzn2.0.6.x86_64 from installed removed (updateinfo)
 --> 1:grub2-tools-minimal-2.06-14.amzn2.0.4.x86_64 from amzn2-core removed (updateinfo)
 --> libdb-5.3.21-24.amzn2.0.5.x86_64 from amzn2-core removed (updateinfo)
 --> containerd-1.7.11-1.amzn2.0.1.x86_64 from @amzn2extra-docker removed (updateinfo)
 --> cyrus-sasl-lib-2.1.26-24.amzn2.x86_64 from installed removed (updateinfo)
 --> amazon-efs-utils-1.35.2-1.amzn2.noarch from @amzn2-core removed (updateinfo)
 --> amazon-ssm-agent-3.2.2303.0-1.amzn2.x86_64 from @amzn2-core removed (updateinfo)
 --> 1:grub2-tools-extra-2.06-14.amzn2.0.4.x86_64 from amzn2-core removed (updateinfo)
 --> python-jinja2-2.7.2-3.amzn2.0.2.noarch from amzn2-core removed (updateinfo)
 --> 1:grub2-pc-2.06-14.amzn2.0.3.x86_64 from installed removed (updateinfo)
 --> python2-rpm-4.11.3-48.amzn2.0.4.x86_64 from amzn2-core removed (updateinfo)
 --> python2-rpm-4.11.3-48.amzn2.0.3.x86_64 from installed removed (updateinfo)
 --> rpm-libs-4.11.3-48.amzn2.0.3.x86_64 from installed removed (updateinfo)
 --> 1:grub2-pc-modules-2.06-14.amzn2.0.4.noarch from amzn2-core removed (updateinfo)
 --> amazon-efs-utils-2.0.4-1.amzn2.x86_64 from amzn2-core removed (updateinfo)
 --> krb5-libs-1.15.1-55.amzn2.2.6.x86_64 from installed removed (updateinfo)
 --> ca-certificates-2023.2.64-1.amzn2.0.1.noarch from installed removed (updateinfo)
 --> 2:tar-1.26-35.amzn2.0.3.x86_64 from installed removed (updateinfo)
 --> 1:grub2-common-2.06-14.amzn2.0.4.noarch from amzn2-core removed (updateinfo)
 --> 1:grub2-efi-x64-ec2-2.06-14.amzn2.0.4.x86_64 from amzn2-core removed (updateinfo)
 --> 1:grub2-efi-x64-ec2-2.06-14.amzn2.0.3.x86_64 from installed removed (updateinfo)
 --> rpm-plugin-systemd-inhibit-4.11.3-48.amzn2.0.4.x86_64 from amzn2-core removed (updateinfo)
 --> curl-8.3.0-1.amzn2.0.7.x86_64 from amzn2-core removed (updateinfo)
 --> rpm-build-libs-4.11.3-48.amzn2.0.4.x86_64 from amzn2-core removed (updateinfo)
 --> rpm-build-libs-4.11.3-48.amzn2.0.3.x86_64 from installed removed (updateinfo)
 --> cyrus-sasl-lib-2.1.26-24.amzn2.0.1.x86_64 from amzn2-core removed (updateinfo)
 --> 1:grub2-2.06-14.amzn2.0.4.x86_64 from amzn2-core removed (updateinfo)
 --> rpm-libs-4.11.3-48.amzn2.0.4.x86_64 from amzn2-core removed (updateinfo)
 --> ecs-init-1.82.1-1.amzn2.x86_64 from installed removed (updateinfo)
 --> 1:grub2-common-2.06-14.amzn2.0.3.noarch from installed removed (updateinfo)
 --> libcurl-8.3.0-1.amzn2.0.7.x86_64 from amzn2-core removed (updateinfo)
 --> rpm-plugin-systemd-inhibit-4.11.3-48.amzn2.0.3.x86_64 from installed removed (updateinfo)
 --> curl-8.3.0-1.amzn2.0.6.x86_64 from installed removed (updateinfo)
 --> 2:microcode_ctl-2.1-47.amzn2.4.20.x86_64 from amzn2-core removed (updateinfo)
 --> 1:grub2-tools-2.06-14.amzn2.0.4.x86_64 from amzn2-core removed (updateinfo)
 --> rpm-4.11.3-48.amzn2.0.4.x86_64 from amzn2-core removed (updateinfo)
 --> openssh-server-7.4p1-22.amzn2.0.6.x86_64 from installed removed (updateinfo)
 --> 1:openssl-1.0.2k-24.amzn2.0.13.x86_64 from amzn2-core removed (updateinfo)
 --> openssh-clients-7.4p1-22.amzn2.0.6.x86_64 from installed removed (updateinfo)
 --> libcurl-8.3.0-1.amzn2.0.6.x86_64 from installed removed (updateinfo)
 --> 1:grub2-pc-2.06-14.amzn2.0.4.x86_64 from amzn2-core removed (updateinfo)
 --> libdb-utils-5.3.21-24.amzn2.0.4.x86_64 from installed removed (updateinfo)
 --> 1:openssl-libs-1.0.2k-24.amzn2.0.13.x86_64 from amzn2-core removed (updateinfo)
 --> cloud-init-19.3-46.amzn2.0.1.noarch from installed removed (updateinfo)
 --> krb5-libs-1.15.1-55.amzn2.2.8.x86_64 from amzn2-core removed (updateinfo)
 --> 1:grub2-tools-efi-2.06-14.amzn2.0.4.x86_64 from amzn2-core removed (updateinfo)
 --> openssh-server-7.4p1-22.amzn2.0.7.x86_64 from amzn2-core removed (updateinfo)
 --> python-jwcrypto-0.4.2-1.amzn2.noarch from installed removed (updateinfo)
 --> containerd-1.7.20-1.amzn2.0.1.x86_64 from amzn2extra-ecs removed (updateinfo)
14 package(s) needed (+0 related) for security, out of 49 available
Resolving Dependencies
--> Running transaction check
---> Package bind-export-libs.x86_64 32:9.11.4-26.P2.amzn2.13.5 will be updated
---> Package bind-export-libs.x86_64 32:9.11.4-26.P2.amzn2.13.8 will be an update
---> Package docker.x86_64 0:20.10.25-1.amzn2.0.4 will be updated
---> Package docker.x86_64 0:25.0.6-1.amzn2.0.2 will be an update
---> Package ecs-service-connect-agent.x86_64 0:v<IP_ADDRESS>-1.amzn2 will be updated
---> Package ecs-service-connect-agent.x86_64 0:v<IP_ADDRESS>-1.amzn2 will be an update
---> Package glib2.x86_64 0:2.56.1-9.amzn2.0.7 will be updated
---> Package glib2.x86_64 0:2.56.1-9.amzn2.0.8 will be an update
---> Package glibc.x86_64 0:2.26-63.amzn2.0.1 will be updated
---> Package glibc.x86_64 0:2.26-64.amzn2.0.2 will be an update
---> Package glibc-all-langpacks.x86_64 0:2.26-63.amzn2.0.1 will be updated
---> Package glibc-all-langpacks.x86_64 0:2.26-64.amzn2.0.2 will be an update
---> Package glibc-common.x86_64 0:2.26-63.amzn2.0.1 will be updated
---> Package glibc-common.x86_64 0:2.26-64.amzn2.0.2 will be an update
---> Package glibc-locale-source.x86_64 0:2.26-63.amzn2.0.1 will be updated
---> Package glibc-locale-source.x86_64 0:2.26-64.amzn2.0.2 will be an update
---> Package glibc-minimal-langpack.x86_64 0:2.26-63.amzn2.0.1 will be updated
---> Package glibc-minimal-langpack.x86_64 0:2.26-64.amzn2.0.2 will be an update
---> Package less.x86_64 0:458-9.amzn2.0.3 will be updated
---> Package less.x86_64 0:458-9.amzn2.0.4 will be an update
---> Package libcrypt.x86_64 0:2.26-63.amzn2.0.1 will be updated
---> Package libcrypt.x86_64 0:2.26-64.amzn2.0.2 will be an update
---> Package libnghttp2.x86_64 0:1.41.0-1.amzn2.0.4 will be updated
---> Package libnghttp2.x86_64 0:1.41.0-1.amzn2.0.5 will be an update
---> Package python3.x86_64 0:3.7.16-1.amzn2.0.4 will be updated
---> Package python3.x86_64 0:3.7.16-1.amzn2.0.6 will be an update
---> Package python3-libs.x86_64 0:3.7.16-1.amzn2.0.4 will be updated
---> Package python3-libs.x86_64 0:3.7.16-1.amzn2.0.6 will be an update
--> Processing Conflict: docker-25.0.6-1.amzn2.0.2.x86_64 conflicts ecs-init < 1.86.1
--> Restarting Dependency Resolution with new changes.
--> Running transaction check
---> Package ecs-init.x86_64 0:1.82.1-1.amzn2 will be updated
---> Package ecs-init.x86_64 0:1.86.2-1.amzn2 will be an update
--> Finished Dependency Resolution

Dependencies Resolved

================================================================================
 Package                 Arch   Version                    Repository      Size
================================================================================
Updating:
 bind-export-libs        x86_64 32:9.11.4-26.P2.amzn2.13.8 amzn2-core     1.1 M
 docker                  x86_64 25.0.6-1.amzn2.0.2         amzn2extra-ecs  45 M
 ecs-init                x86_64 1.86.2-1.amzn2             amzn2extra-ecs  28 M
 ecs-service-connect-agent
                         x86_64 v<IP_ADDRESS>-1.amzn2          amzn2extra-ecs  44 M
 glib2                   x86_64 2.56.1-9.amzn2.0.8         amzn2-core     2.4 M
 glibc                   x86_64 2.26-64.amzn2.0.2          amzn2-core     3.3 M
 glibc-all-langpacks     x86_64 2.26-64.amzn2.0.2          amzn2-core     7.0 M
 glibc-common            x86_64 2.26-64.amzn2.0.2          amzn2-core     774 k
 glibc-locale-source     x86_64 2.26-64.amzn2.0.2          amzn2-core     3.2 M
 glibc-minimal-langpack  x86_64 2.26-64.amzn2.0.2          amzn2-core      33 k
 less                    x86_64 458-9.amzn2.0.4            amzn2-core     119 k
 libcrypt                x86_64 2.26-64.amzn2.0.2          amzn2-core      53 k
 libnghttp2              x86_64 1.41.0-1.amzn2.0.5         amzn2-core      73 k
 python3                 x86_64 3.7.16-1.amzn2.0.6         amzn2-core      73 k
 python3-libs            x86_64 3.7.16-1.amzn2.0.6         amzn2-core     9.5 M

Transaction Summary
================================================================================
Upgrade  15 Packages

Total download size: 145 M
Downloading packages:
Delta RPMs disabled because /usr/bin/applydeltarpm not installed.

So it seems like either docker was upgraded by cloud-init directly or upgraded as dependencies by other packages.
In the other word, even docker version was installed by a specific version in the AMI, like this, but docker version can still be upgraded to break things.

Expected Behavior
Observed Behavior
Environment Details

Supporting Log Snippets

Hi @yongzhang ,
Thank you for reaching out! This is the expected behavior on AL2 instances, since docker 25 is a security update.
If you'd like to disable security updates at launch, please refer to this Amazon Linux FAQ. (search for Q: How do I disable the automatic installation of critical and important security updates on initial launch?).
To further help ECS customers from running into surprises, ECS AMIs beginning June 12, 2024 have the security updates-at-boot feature disabled by default: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs-optimized_AMI.html#ecs-optimized-AMI-security-changes
Please let us know if you have further questions. Thanks!

@singholt
I can still find this in newer versions of AMI:
repo_upgrade: security


🤷♂ Add event/record function head match in trace

#270  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @RTLS and the rest of your teammates on  Graphite


[VMR] Design and implement way of building parts of the subgraph based on platform/scenario

Describe the Problem
There are some repos that we do not need to build, based on the platform we are building, or the compliance requirements of the build. For instance:

No need to build Windows desktop repos for Linux
No need to build SBRP/SBE except when building in context of RH/Canonical (SB strict?)

Describe the Solution
The repo projects contain the build graph. This list should be filtered based on inputs to the build. Perhaps:

TargetOS
Build org?

Design and implement such a solution.
T-Shirt size: Small

T-Shirt size: Medium

Agreed. TargetOS and DotNetBuildFromSource (or the new equivalent in the future) make most sense here.

This is already implemented in the Windows PoC. Keeping this open until we get the orchestrator changes merged into installer.

Reopening this. We should have a more complete implementation of this that takes into account things like short vs. tall stacks.

Requirements:

Identify which repos actually need to build assets that contribute to the product for the given short stack vertical. Is it really just runtime (+ dependencies)?
Build locally, validate manually the build is successful and expected artifacts are produced. This probably requires (small) updates in the orchestrator and probably in runtime.
After https://github.com/dotnet/source-build/issues/3823, add legs for the tested short stack verticals to the pipeline.

https://github.com/dotnet/installer/pull/18463 represents the current status of work on this.
It's tested with android-x64, android-arm64, and browser-wasm runtime packs.
wasi-wasm is bugged and requires a runtime patch https://github.com/dotnet/runtime/pull/98004
iossimulator-x64 and other Mac variants are bugged locally, apparently due to toolchain change surprised from Apple, but may be fine in CI (this will need a runtime patch to work around the new Apple linker, but that's not VMR's responsibility)


Remove corba related tests from mauve test list

Remove corba related tests from mauve test list
Signed-off-by: Mesbah Alam<EMAIL_ADDRESS>

This PR excludes the CORBA related classes from mauve test list that were missed in : https://github.com/AdoptOpenJDK/openjdk-systemtest/pull/185#event-1944032375

@chandrams : I tested your changes for running system test in Docker and it's working fine (with the changes pertaining to this PR): https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/351/console
Once this PR is delivered, you can go ahead and create a PR with your changes.


fix: remove upcoming kits  add data governance kit

Description
remove upcoming kits from next and 24.05.
add data governance kit in the nav bar
#921
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:

[x] DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
[x] Copyright and license header are present on all affected files

Hi @manojava-gk, thank you for addressing the issue and for your contribution. However, I have one minor change request: You removed the "upcoming kits" from the sidebar, but not from the drop-down menu in the navigation on the top in docusaurus.config.js.

Its done

@arnoweiss @danielmiehle @maximilianong @stephanbcbauer
Could someone merge this PR? I would prefer to merge this PR before creating a new release.


[Docs] Favicon on docs.meshery.io should be of Meshery logo

Current State
The favicon on docs.meshery. io is not of the Meshery logo currently.
Desired State
Use Meshery logo from https://layer5.io/brand

Contributor Resources

Meshery documentation site
Meshery documentation source
Instructions for contributing to documentation
Layer5 Community Slack

I got 2 logo files in docs logo1.svg and logo.svg, which one to change?? also which logo to add?? can please help me by being a little more specific?

I would like to make my contribution starting from here.
To be clear the logo required is the one which I am attaching below or is it a different one?

@debjani1413 It's https://github.com/layer5io/meshery/blob/master/docs/_includes/logo.svg

I would like to make my contribution starting from here.
To be clear the logo required is the one which I am attaching below or is it a different one?

Hey @hrishikeshnikam2000
This issue is already taken and to answer your query, its not the one, we needed the Meshery Circle Logo without the text.
Also, feel free to have a look at other issues and find your suitable interest one. If you find it, do add a comment and I would be glad to assign it to you :)

okay I will look into other issues. thank you.

@debjani1413 @hrishikeshnikam2000 please first familiarize with the concept of a favicon. Reengaging if / when ready.


Parallel backend support

Hi there
Thank you for a great package. I would like to request whether a parallel backend could be supported when running drift calculations across large numbers of features.
Regards

Hi @niklasvm , and thanks for opening up the issue!
It is in the roadmap. Unfortunately, not immediate one due some resource constraints, but we will definitely add this.

Amazing, thank you!

Instead of the parallel backend we will support Spark. This should speed up calculations


Simplify Assertions in tests

Change assertions with simpler but equivalent calls.

Coverage decreased (-0.03%) to 84.114% when pulling 1b65d1fd90bbbe2e29d2b9dd50d14278b19cc032 on arturobernalg:feature/simplifyAssertions into ee6486d8ebf4a721f21913a7a708a33ab0374f9b on apache:master.

@arturobernalg
Please rebase on git master.
TY.

@arturobernalg
Please rebase on git master.
TY.

HI @garydgregory
Rebased
TY


Map not rendering

Hi,
My map is not rendering (I have a "blank screen").
Otherwise, I don't have any error in the console...
I added "   "  in public\index.html
Here is my Js file:
import React, {Component } from 'react';
import logo from './logo.svg';
import './App.css';

import { withGoogleMap ,
    GoogleMap,
    } from "react-google-maps";

const GettingStartedGoogleMap = withGoogleMap(props => (
    <GoogleMap
        defaultZoom={3}
        defaultCenter={{ lat: -25.363882, lng: 131.044922 }}
    >
    </GoogleMap>
));

class App extends Component {

    render() {

    return (

        <div style={{height: `100%`}}>
            <GettingStartedGoogleMap
                containerElement={
                    <div style={{ height: `100%` }} />
                }
                mapElement={
                    <div style={{ height: `100%` }} />
                }
            />

    );
  }
}

export default App;

Thanks a lot for your help

I found a solution...
I changed the style of the container and the map like that :
 containerElement={

                }
                mapElement={

                }

@Sachavent I ran into the same problem with the demo example.

@Pentatonic did you add my style?
To display a Mapview, you need "position : 'absolute' " (position relative may also work)

Please refer to Getting Help section in the README (or #469).


literalMidWordAsterisks and single character bolding

With the literalMidWordAsterisks option enabled, the following markdown doesn't render properly..
Click the **X** button

Instead of the X character being bolded, it appears in italics with wrapping asterisks.
If there is subsequent bolding, it also renders incorrectly, though not in the same fashion.
Click the **X** button and then the **OK** button

Verified. Introduced in 1.8.3

Should be fixed now in fe70e45

Donate
As you know, ShowdownJS is a free library and it will remain free forever. However, maintaining and improving the library costs time and money.
If you like our work and find our library useful, please donate through Pledgie or directly through paypal!! Your contribution will be greatly appreciated and help us continue to develop this awesome library.

That fixed it. Thanks!


[SPARK-34829][SQL] Fix higher order function results

What changes were proposed in this pull request?
This PR fixes a correctness issue with higher order functions. The results of function expressions needs to be copied in some higher order functions as such an expression can return with internal buffers and higher order functions can call multiple times the expression.
The issue was discovered with typed ScalaUDFs after https://github.com/apache/spark/pull/28979.
Why are the changes needed?
To fix a bug.
Does this PR introduce any user-facing change?
Yes, some queries return the right results again.
How was this patch tested?
Added new UT.

Test build #136475 has started for PR 31955 at commit 1232ae7.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136475/

Test build #136480 has started for PR 31955 at commit 5e18d88.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41059/

Test build #136480 has finished for PR 31955 at commit 5e18d88.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Bar2(s: String)

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136480/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41064/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41064/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41064/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41059/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41059/

cc @ueshin FYI

Test build #136563 has started for PR 31955 at commit d00e705.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136563/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41147/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41147/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41147/

late lgtm, thank you, @peter-toth and all.

Thanks you all for the review.


UP028 for multiple loops does not work

UP028 does not work when there are multiple yield loops in a function
Code example:
def text_not_ok():
    a = [1, 2, 3]
    for photo in a:
        yield photo
    for photo in a:
        yield photo

https://play.ruff.rs/b9748aaf-8e8c-45cd-8138-20f41013b979

I think this is because of this logic here: https://github.com/astral-sh/ruff/blob/c3bcd5c8422b79bd5cbc874a98f70cdb92e8d445/crates/ruff_linter/src/rules/pyupgrade/rules/yield_in_for_loop.rs#L98-L112
I.e., Ruff believes that some of the variables bound by the first loop might be referenced in the second loop, so it comes to the conclusion that it won't necessarily be safe to rewrite them as yield from statements. If you change the second loop to use different variable names, it flags both loops with UP028: https://play.ruff.rs/50ee023e-60f4-4a77-a870-3378a6c68b72
It would be possible to improve Ruff's behaviour here, I think, but it might add some complexity to our implementation

Then you need to improve ruff's behavior
Or add another rule that tracks repeating loops
Or add a warning about this behavior to the documentation


OS_API_Init() should be called before any OSAL calls are used in the unit tests

The unit tests vary in how (or if) they call OS_API_Init() before any OSAL calls are used.

Imported from trac issue 145.  Created by sseeger on 2016-01-06T13:14:06, last modified: 2019-07-26T15:13:27

Trac comment by sduran on 2016-01-11 15:43:37:
Recommend not to accept these changes.
The unit tests are correct as written based on the current implementation of OSAL.
It breaks them because the unit test was designed to test the functions that check for and return "init not called".  This condition can only be tested if OS_API_Init() has not been called yet.  It is simply testing OSAL functionality as it is.
If the CCB thinks the OSAL should work differently, and decides to change it, then the unit tests can be updated to test the updated OSAL.

Trac comment by sseeger on 2016-01-10 22:38:02:
[changeset:7914cb] ready for CCB review.
NOTE: This commit breaks "init-called-first" tests. We should discuss if it makes sense to get rid of that test. I think it does unless we explicitly test for OS_API_Init() being called in all OSAL calls. I think this is unnecessary overhead on the OSAL for something that the user should know to do. (my opinion)
Of course, building the OSAL with compile-time configurable sanity checking might be a way to go....

Trac comment by glimes on 2016-01-19 13:02:53:
Not a showstopper. We will do a real fix but not for this release;
we do not need to take immediate action on this for osal-4.2 ...

Trac comment by glimes on 2016-01-14 12:09:41:
Steve -- CCB had quite a lot of discussion around this, and I think the concensus was that in the long term, the responsibility for initializing OSAL moves into BSPs, and we allow all OSAL entry points to assume that OS_API_Init has been called, rather than having it be a runtime check.
And yes, this is a change to the interface specfiication. urk!

Trac comment by jhageman on 2019-05-13 16:13:55:
Marked for CCB review - comment 2 seems to indicate there should be a ticket about moving OSAL initialization into BSPs, then the init call could be removed from all unit tests (update ticket?)

Trac comment by jhageman on 2019-07-03 13:31:58:
Moved closed 4.2.2 milestone tickets to 4.3.0

Trac comment by jhageman on 2019-05-15 12:34:13:
CCB - 5/15/2019 : Moving Init into BSP sounds like a good idea, will open another ticket
Will close this since the unit tests were meant to test the uninitialized OSAL behavior.

Trac comment by jhageman on 2019-05-15 14:09:34:
See #214 for moving initialization into the BSP.
Closing this ticket as "invalid" since it works as intended currently

Trac comment by jhageman on 2019-07-26 15:13:27:
Milestone renamed


Displaying the skeleton component

After changing the background of the use cases on the documentation site, there was a problem with the display of loading bars in the Skeleton component.

@PKulkoRaccoonGang Great catch. A couple thoughts here:

Is this a bug only on the documentation website? Or is it also an issue for consumers of Skeleton (e.g., in MFEs)?
Are we sure the issue is due to the changed background color of the code block previews?

Presumably, the "With custom theme" example code snippet would have distinct background color from the background of the code block preview but it also does not appear.
There was also a recent change related to how we import the CSS from react-loading-skeleton, which I feel may be more of the culprit to the regression we're now seeing in the documentation website. Looking at the deploy preview on that change to the CSS import, the skeleton loaders are not visible on the docs site, but a deploy preview for just 2 PRs earlier from that recent change, the skeleton loaders do appear on the colored background (/cc @davidjoy):

Find solution.
Verify in Gatsby docs site.
Verify in example Paragon MFE.
Check in consuming MFE.

I believe this recently filed Card loading state issue will likely be resolved by this issue.

PR: https://github.com/openedx/paragon/pull/2531

This was fixed in https://github.com/openedx/paragon/pull/2865


'gb test  ' without '-cover' option?

How should I use 'gb test' to measure coverage?

At the moment the test command doesn't understand those options, and gb test doesn't have the logic to apply the rewriting rules.
At the moment the workaround is
 env GOPATH=$PROJECT:$PROJECT/vendor go test -cover $PACKAGE

Thanks for the fast answer.
That's how I do it in the CI jobs.
But that workaround is clumsy for regular development process, especially with mutliple active projects.

@davecheney thanks, this worked well for me, as seen in https://github.com/travis-ci/worker/blob/master/Makefile#L20 and https://travis-ci.org/travis-ci/worker/builds/66593224#L237-L337

I'm not sure if it will help anyone. But I modified the shell script here...
https://mlafeldt.github.io/blog/test-coverage-in-go/
for use with gb
https://gist.github.com/adamclerk/132b8e7a01e419dc3f47


Logfile - Data too long

Feldlängen-Problem
Entweder ist das Db-Feld zu klein gewählt oder auf dem UI wird die Länge nicht eingeschränkt:
2017-06-14 17:08:13,429 [DEBUG] ch.alv.sysinfos.web.rest.system.SystemMessageResource - REST request to set a new state: STATUS_CHANGED on the SystemMessage with id: 100
2017-06-14 17:08:13,799 [WARN] org.hibernate.engine.jdbc.spi.SqlExceptionHelper - SQL Error: 1406, SQLState: 22001
2017-06-14 17:08:13,799 [ERROR] org.hibernate.engine.jdbc.spi.SqlExceptionHelper - Data truncation: Data too long for column 'state_note' at row 1

In the db is state note varchar(1000). On the front end, we don't validate anyhow the input. I assume that a user tried to submit state note longer, than 1000 characters.

The UI does not validate the length, but the text area for this field has maxlength="4000".

Fixed the two cases where this problem can appear:

appended history entries are limited to the database field size (oldest history entries are cut off)
the field to enter the information update has now the same maxSize as the database field


Mobile navbar close content

If the mobile navbar is oben, there's no layer on the right side which I can click and the navbar get closed.


chore: update deps

Description
Update deps
Fixes #145
Flutter Channel:

[x] I have used the Flutter Beta channel on my local machine

Type of Change:
Delete irrelevant options.

Code

How Has This Been Tested?
Emulator
Checklist:
Delete irrelevant options.

[x] My PR follows the style guidelines of this project
[x] I have performed a self-review of my own code or materials
[x] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] Any dependent changes have been merged

Code/Quality Assurance Only

[x] My changes generate no new warnings
[ ] My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
[ ] Any dependent changes have been published in downstream modules

ci broken due to some deprecated stuff iirc. Will fix asap

on hold until #148 merges just to confirm :)


fix external-vpc

What type of this PR
Examples of user facing changes:

Bug fixes

The binary file in dist/images/ should not be commited and merged.

The binary file in dist/images/ should not be commited and merged.

The binary file in dist/images/ should not be commited and merged.

The binary file has been deleted.


Provide shape info in shape mismatch error.

While it is easy enough to obtain this info from %debug, putting it
in the error messages is helpful when those messages come from user
reports (e.g. emails).
I am guessing that this change does not call for a new test or a
documentation update, but I'm happy to add one if asked.

[x] Passes black . && mypy . && flake8

Thanks @danielballan. Nicer error messages are always welcome! I've made one small suggestion.
Also I see that this is your first xarray PR. Welcome! We hope to see you contribute often.

Thanks! I agree that your proposed wording is better and I have committed it.
Thanks for the friendly welcome. I learned OSS as a minor pandas contributor back in my grad schools days, now glad to finally have a contribution in xarray. I love this project!

:) It's great to have you contribute.


Width of the text

Hello!
I would like to know if it's possible to manage the width of the text panel in the Style Settings plugin?
Thank you!

You can adjust the text width in this section:


Vulkan: Can't start Godot with AMD integrated + NVIDIA dedicated GPU switchable graphics (Failed dispatch call vkEnumeratePhysicalDevices)

Bugsquad note: This issue has been confirmed several times already. No need to confirm it further.

Godot version
4.0
System information
Windows 10 RTX 2060 and AMD graphics chipset
Issue description

When I double click on the program I get the following error showing that I don't have the drivers I have checked everything and it is correct I have even installed it again and it is still the same.
Steps to reproduce
Open ./Godot_v4.0-alpha1_win64_console.cmd or ./Godot_v4.0-alpha1_win64.exe
Minimal reproduction project
No response

The solution I had to apply is the following by performing these actions from this video:
https://www.youtube.com/watch?v=0HdHE_sq7dw

I don't think there's anything we can do about this. Setting DISABLE_LAYER_AMD_SWITCHABLE_GRAPHICS_1 to 1 automatically is probably not a good idea.
cc @bruvzg

Related to #57396.
I don't think there's anything we can do about this. Setting DISABLE_LAYER_AMD_SWITCHABLE_GRAPHICS_1 to 1 automatically is probably not a good idea, as it will prevent forcing the use of AMD integrated graphics entirely when a dedicated GPU is present. For non-game applications, this can be problematic if you want to preserve battery life.
Did you update your graphics drivers from AMD and NVIDIA's websites (not from your laptop OEM or Windows Update)?
cc @bruvzg

drivers are updated from windows update as well as from nvidia and amd chipset manufacturers.

as it will prevent forcing the use of AMD integrated graphics entirely when a dedicated GPU is present

If I understand correctly, with DISABLE_LAYER_AMD_SWITCHABLE_GRAPHICS_1 both devices should be accessible, without it, it's presented as a single device.
@fonixgm Could you try running Godot with --verbose command line argument (both with and without DISABLE_LAYER_AMD_SWITCHABLE_GRAPHICS_1 set), and give us the output ("Vulkan devices:" part in particular).

as it will prevent forcing the use of AMD integrated graphics entirely when a dedicated GPU is present

If I understand correctly, with DISABLE_LAYER_AMD_SWITCHABLE_GRAPHICS_1 both devices should be accessible, without it, it's presented as a single device.
@fonixgm Could you try running Godot with --verbose command line argument (both with and without DISABLE_LAYER_AMD_SWITCHABLE_GRAPHICS_1 set), and give us the output ("Vulkan devices:" part in particular).

This is with DISABLE_LAYER_AMD_SWITCHCHABLE_GRAPHICS_1 on

and this is without the DISABLE_LAYER_AMD_SWITCHCHABLE_GRAPHICS_1
It seems that when you turn it on by command console it is working and boots normally without having this option activated, it is a little strange.

I have not found much useful info how VK_LAYER_AMD_SWITCHCHABLE_GRAPHICS should work, but it seems broken (there are also plenty of similar issues with the layer on Linux, so it's not Windows specific).
With the layer disabled, it should be possible to force a specific GPU for the app using Windows built-in option in "System→Display→Graphics". But I agree that we probably can't do anything with it.

I have not found much useful info how VK_LAYER_AMD_SWITCHCHABLE_GRAPHICS should work, but it seems broken (there are also plenty of similar issues with the layer on Linux, so it's not Windows specific).
With the layer disabled, it should be possible to force a specific GPU for the app using Windows built-in option in "System→Display→Graphics". But I agree that we probably can't do anything with it.

Temporarily I will use the DISABLE_LAYER_AMD_SWITCHABLE_GRAPHICS_1 to make it work and I will also investigate if there is any configuration that can solve this problem apart from using this environment variable and thus not to annoy so much the battery of my pc.

I reproduced this with a similar combination of graphics cards and fixed it locally by adding "OS::get_singleton()->set_environment("DISABLE_LAYER_AMD_SWITCHABLE_GRAPHICS_1", "1");" to the function Main::setup in main.cpp, immediately after "OS::get_singleton()->initialize();". At least the Windows implementation for that function changes the environment variable only for the current process (at least according to the documentation). Is there any reason not to do this? Updating my graphics drivers didn't do the trick and I guess it might take some time till most users with such a (not that unusual) graphics cards combination will receive an update that fixes this issue.

i want to comunicate i solve a similar problem ( #56164 ) i simply remove the official asus amd driver and put the generale amd driver using the adrenalin software this solve the problem for me.

I reproduced this with a similar combination of graphics cards and fixed it locally by adding "OS::get_singleton()->set_environment("DISABLE_LAYER_AMD_SWITCHABLE_GRAPHICS_1", "1");" to the function Main::setup in main.cpp, immediately after "OS::get_singleton()->initialize();". At least the Windows implementation for that function changes the environment variable only for the current process (at least according to the documentation). Is there any reason not to do this? Updating my graphics drivers didn't do the trick and I guess it might take some time till most users with such a (not that unusual) graphics cards combination will receive an update that fixes this issue.

How will this behave on systems with only AMD integrated graphics?

Please try 4.0 alpha 10, there was an update to VMA which might help: https://godotengine.org/article/dev-snapshot-godot-4-0-alpha-10

I have tried alpha 10 but the error persists.

The Error occurs on Branch 3.x, 3.4.x and 4.x
On my System i have a integrated Radeon AMD Vegas 11 Graphics card and a additional, second NVidia Graphics card.
I simply turned the AMD Vergas Graphic card up in Windows 10 Device manager (Nvidia still was enabled), the Editor
launched without any problems. After it, i was able to re-enable the AMD Graphics card in Device Manager (without Reboot)
and the Editor starts without any Problems.

The Error occurs on Branch 3.x, 3.4.x and 4.x
On my System i have a integrated Radeon AMD Vegas 11 Graphics card and a additional, second NVidia Graphics card. I simply turned the AMD Vergas Graphic card up in Windows 10 Device manager (Nvidia still was enabled), the Editor launched without any problems. After it, i was able to re-enable the AMD Graphics card in Device Manager (without Reboot) and the Editor starts without any Problems.

Godot 3.x uses an OpenGL renderer, so Vulkan-specific issues don't affect it.

I built 3.x, 3.4 and 4.x and the error shows up on any build, with tools or without, of it is release or debug targets or both.

I reproduced this with a similar combination of graphics cards and fixed it locally by adding "OS::get_singleton()->set_environment("DISABLE_LAYER_AMD_SWITCHABLE_GRAPHICS_1", "1");" to the function Main::setup in main.cpp, immediately after "OS::get_singleton()->initialize();". At least the Windows implementation for that function changes the environment variable only for the current process (at least according to the documentation). Is there any reason not to do this? Updating my graphics drivers didn't do the trick and I guess it might take some time till most users with such a (not that unusual) graphics cards combination will receive an update that fixes this issue.

How will this behave on systems with only AMD integrated graphics? Can anyone test this on such a system?

I don't know. I don't have such a system. Can anyone with an AMD-only system test it?

I have done an update of the latest driviers of the radeon integrated graphics and the amd just install the necessary drivers without doing a minimal installation nor a full installation when I have done this suddenly I have noticed an improvement and I am not failing the godot or shows any error when it boots it does it directly from the rtx.
I give for my part solved the problem I think it was probolema of amd and its drivers.
Translated with www.DeepL.com/Translator (free version)

if someone fails to check this as shown on screen in drivers only and this should not fail or at least it does not fail me

The main problem here isn't whether or not this works for developers. There are workarounds. The important question is: will someone who wants to play (or even buy) a game made with Godot run into this issue? Will they be willing to take any additional steps to make that one particular game work? Keep in mind that making changes to one's setup like setting environment variables isn't something everyone is familiar with and updating a graphics driver can even cause additional issues if the new version is bugged in any way.
I didn't have this problem with anything but Godot so far. So if I had first encountered this issue with a game instead, I'd blame it on the game. And I guess that's what others will do as well. And they might write angry reviews that will stop potential players (or customers) from buying the game.

The important question is: will someone who wants to play (or even buy) a game made with Godot run into this issue?

Yes, as this issue affects both the editor and exported projects. We don't know a definite way to fix this, and contributors work on a best-effort basis.

I know. The point of my post was just to make sure this issue isn't closed accidently as being solved. I agree that it isn't really urgent to fix it.

I have done an update of the latest driviers of the radeon integrated graphics and the amd just install the necessary drivers without doing a minimal installation nor a full installation when I have done this suddenly I have noticed an improvement and I am not failing the godot or shows any error when it boots it does it directly from the rtx.
I give for my part solved the problem I think it was probolema of amd and its drivers.

Installing the latest AMD drivers fixed this for me as well.
Windows 11, AMD Ryzen 7 5800H with Radeon Graphics, NVIDIA GeForce RTX 3060.

Bumping because I had this issue too.
An easy, temporary solution on Windows to force Godot to use the NVIDIA GPU is editing the cmd script to locally set the DISABLE_LAYER_AMD_SWITCHABLE_GRAPHICS_1 environment variable only for the given session.
@echo off
setlocal
	set DISABLE_LAYER_AMD_SWITCHABLE_GRAPHICS_1=1
	Godot_v4.0-beta1_win64.exe
	pause > nul
endlocal

Update AMD Radeon diver can solve this problem

If any of you can still reproduce the issue, please test https://github.com/godotengine/godot/pull/73450 locally. A Windows build is included in that PR's description.

Update AMD Radeon diver can solve this problem

confirmed here :
R7 4800H
GTX 1650
got the driver from AMD website

The solution I had to apply is the following by performing these actions from this video: https://www.youtube.com/watch?v=0HdHE_sq7dw

Thank you, its'working!!!

Bumping because I had this issue too. An easy, temporary solution on Windows to force Godot to use the NVIDIA GPU is editing the cmd script to locally set the DISABLE_LAYER_AMD_SWITCHABLE_GRAPHICS_1 environment variable only for the given session.
@echo off
setlocal
	set DISABLE_LAYER_AMD_SWITCHABLE_GRAPHICS_1=1
	Godot_v4.0-beta1_win64.exe
	pause > nul
endlocal

hello, tried your fix, and godot closes without any errors, just "not responding"

If any of you can still reproduce the issue, please test #73450 locally. A Windows build is included in that PR's description.

Works for me!

My errors are like these. It seems that it recognizes the dedicated GPU, but still cannot initialize Vulkan.

My errors are like these. It seems that it recognizes the dedicated GPU, but still cannot initialize Vulkan. Actions from the aforementioned video do not work, as it seems.

Try 4.1.rc2 as it includes https://github.com/godotengine/godot/pull/73450.

4.1.rc2 works! Thank you. I don't have any external monitors though.

for those of you arriving here in 2024 after January 27th, the issue is detailed here:
https://community.khronos.org/t/cannot-create-vulkan-instance-non-conformant-vulkan-implementation/110488/3

I’m having the same problem. Yesterday, I could open Vulkan-supported applications, but now I can’t. I updated the driver, used DDU to uninstall and reinstall it, but nothing changed. Example Vulkan applications also don’t open. I downloaded “VulkanRT-1.3.275.0-Components” from the LunarG website. The x86 version works with a warning that “dzn is not a conformant Vulkan implementation, testing use only.” However, the x64 version only gives a warning. Sometimes GPU-Z shows that it supports Vulkan, but then it disappears when the application is refreshed. My system: R5 5600G Vega 7(Cezzane), OS: Windows 11.

Edit: Uninstalling the “OpenCL™, OpenGL® and Vulkan® Compatibility Pack” fixed the problem.

This solution worked for me. You can easily find this in "Apps > Installed Apps" in Windows settings.

bro... this is not fixed yet?

bro... this is not fixed yet?

I've stopped running into this issue some time ago using godot 4. Though I'm not sure exactly which version fixed for me I'm currently on 4.2.1

This was fixed in 4.1. If you still experience a similar issue in 4.2.1 or later, please open a new issue with details.


Rename exporter class to AzureMonitorTraceExporter

Rename exporter class to AzureMonitorTraceExporter
Removing telemetry processors
Only expose connection string configuration

CHANGELOG for removing telemetryprocessor/configuration?


UP-3052 Drag & drop doesn't work on IE9

Modified the original fix for UP-3052 to work correctly with jQuery UI 1.7.2.

uPortal 4.0.2 (what is currently in master) is using jQuery 1.8.13 and this bug was fixed in 1.8.6 so I don't believe we need this, if you are seeing this with master just let us know.

On Oct 28, 2011, at 6:18 PM, edalquist wrote:

uPortal 4.0.2 (what is currently in master) is using jQuery 1.8.13 and this bug was fixed in 1.8.6 so I don't believe we need this, if you are seeing this with master just let us know.

My intent was for the patch to be applied to the rel-3-2-patches branch which still uses jQuery UI 1.7.2.  I'm a git noob, so I many not have done that correctly :)
UP-3052 is marked Resolved/Fixed in JIRA but it's really still broken since the original patch didn't work and was backed out.
Thanks!
-- Bob

Ah ok, so you were close. The things you need to do are: (some of which you've done)

Fork the Jasig uPortal repository to your account
Clone the repository to your machine
Switch to the 3.2 patches branch:
$ git checkout rel-3-2-patches
Create a working branch for the patch based on the 3.2-patches branch
$ git checkout -b UP-3052
Do your work, commit it, push your branch to your fork on GitHub
$ git commit -a
$ git push origin UP-3052
Browse to the branch in GitHub and make your pull request

From what you've submitted I'm guessing you just missed step 3 and created your branch from 'master' which is the git equivalent of 'trunk' in svn.
Thanks for the help and when the next Pull comes in for 3.2-patches I'll be sure to get it merged.
-Eric


are there any way to dynamically provide context map by server

when i use dynamic require i get this map on chunk
var map = {
"./AboutPage": 247,
"./AboutPage.jsx": 247,
"./DashBoardPage": 249,
"./DashBoardPage.jsx": 249,
"./FeedChannelPage": 251,
"./FeedChannelPage.jsx": 251,
"./HostPage": 253,
"./HostPage.jsx": 253,
"./LoginPage": 255,
"./LoginPage.jsx": 255,
"./ProfilePage": 257,
"./ProfilePage.jsx": 257
}
are there any way to dynamically provide context map by server instead and put it in redux store or something

any suggestion?

The problem is that webpack still needs to walk through filesystem to generate a require.context (static analysis). I don't see how it could work dynamically. Maybe I'm missing something.
Could you re-open at Stack Overflow with more details?


changed annotationState settings and make sure they are respected.  a…

…lso allow for dot notation in the config and unpack it

Coverage decreased (-0.04%) to 47.656% when pulling ada698c8ee6f67d1662fe781d33a198e9d39ee9c on anno-settings into 30395f81656370f4b966f3f01a0fa54cadb05621 on release2.1.


wrong attribute value

Hi, i have  encountered an issue in case of using Not explicitly:
this line of code works fine:
$goods = Good::select("goods.*")->join("products","products.id","goods.product_id")->

but this line of code:
$goods = Good::select("*")->join("products","products.id","goods.product_id")->

or this:
$goods = Good::join("products","products.id","goods.product_id")->

makes problem with i am trying to access one of the models id:
$good->id;  //it retrieves product.is instead of good.id

but if you are selecting everything
Good::select("*")
it is a expected behaviour.

But The below line get me products.id instead of goods.id
$goods = Good::select("*")->join("products","products.id","goods.product_id")->

That is expected behaviour, because now you have two fields with the same name "id" (from goods and products) in select and last id from select is fetched into results. This issue is related to the mysql, not this package...


Redesigned profile page

Redesigned profile page for both students and staff members. You can now view a student’s past record like past events attended by them or attendance-related information about the student.
Added edit functionality for both students and staff profile page information

Looks okay to me! Two main things:

The edit profile page still could improve its workflow and CSS. For staff profile, very little seems to have changed - if we could make it more like the student profile and have a dedicated "edit profile" button, that would be great. The CSS also could be updated but that isn't necessarily your job so its fine :)

Student profile history should be accessible from staff accounts, not just student accounts. This should be an easy add on though.

I'll go ahead and merge! Thanks!

@npat15 I agree the CSS could definitely be improved. For this PR, I primarily wanted to focus on adding the functionality so you could finish with your workflow.
A lot hasn't been changed for the staff profile page mainly because I believe there isn't a lot of info that we could show for the staff other than the usual name, emergency contact, etc. I added an "edit profile" button for the staff but it seemed redundant since the profile and the edit page pretty much looked the same. I wonder if we should replace the current profile page for staff with a page that shows a list of past events attended/proctored by the staff.
And, yea the student profile page on the staff accounts would be an easy add on that might be quite helpful for the staff members.


Add support for Whisper Large v3 Model

Whisper Large v3 missing mel_filters in preprocessor_config.json
Issue Description
Unlike the Tiny model, Whisper Large v3 doesn't include mel_filters in its preprocessor_config.json file.
Reference: Whisper Large v3 preprocessor_config.json
This omission causes the following error when attempting to use the model with ctranslate2-rs:
Error: missing field `mel_filters`

Potential Solution
The faster-whisper library, which implements ctranslate2, addresses this issue with the following approach:
model.feature_extractor.mel_filters = model.feature_extractor.get_mel_filters(
    model.feature_extractor.sampling_rate,
    model.feature_extractor.n_fft,
    n_mels=128
)

Reference: faster-whisper GitHub issue #547

Thanks for reporting this issue. #82 will fix it.

@jkawamoto
Thank you for the prompt fix!
I've tested it, and it's working perfectly now.


Refer to more compilers based on GCC and Clang

Fixes #251
This PR implements the version that was identified to be a good compromise in the comments for #251; examples of GCC- and Clang-based compilers are listed in a footnote.

Updated proposed change with David's feedback. Merging as per discussion in C/C++ Compiler Guide BP call 2023-11-22.


procs: fix darwin build

Motivation for this change
darwin build is broken
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[X] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

I'll remove myself, since I don't have any Macs anymore, I can't test darwin-related changes.

Thanks for fixing this! I want you to know you're appreciated 💜

@rpearce thanks for the ❤ !


error compiling

I get this error compiling
when I run this command
./gradlew assembleDebug
Here's the error. credentials.json exist

Task :step1-start-here:compileDebugJavaWithJavac
/Users/Ron/Downloads/androidthings-googleassistant/step1-start-here/src/main/java/com/example/androidthings/assistant/AssistantActivity.java:337: error: cannot access UserCredentials
.withCallCredentials(MoreCallCredentials.from(
^
class file for com.google.auth.oauth2.UserCredentials not found
1 error

FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':step1-start-here:compileDebugJavaWithJavac'.

Compilation failed; see the compiler error output for details.

Did you follow the steps in the codelab to use the google-oauthlib-tool?


Session from config not showing up

What happened?
When I sesh list, I expected to see the sessions from my config first but it's not showing up.

Version
2.1.0
Relevant log output
reverting this commit seems to fix it. https://github.com/joshmedeski/sesh/commit/53121860f125ce0dcb09a0be2ac22559f1eb1d05
is this the intended default behaviour now?
Reviewed

[X] Reviewed existing issues and made sure this bug has not already been submitted.
[X] I have read the documentation and understand how sesh works before submitting this bug

what exactly does attached mean? does attached means all active sessions? or only the session that currently focused?

Attached refers to the currently focused session. However, something went wrong with that feature and I removed it for now. So you can update to v2.1.1 and all your sessions will come back


Explore page : Filter by language (or Tag)

this issue already exists https://github.com/ln-dev7/sharuco/issues/2


Mozilla ut_parse does not present ut_domain and other fields

Hi Daniel, Ian or Mayur,
could you please take a look at
[https://community.splunk.com/t5/All-Apps-and-Add-ons/Why-is-URL-Toolbox-not-working-with-mozilla-list/m-p/586630/thread-id/76192](Splunk Answer UTBox Mozilla Issue)?
It seems latest utbox v1.9.1 has a hicup on parsing out ut_domain and other fields when using the mozilla suffix list. iana and custom work, also did v1.8 with the mozilla list. Strange, with only that small codechange from 1.8 to 1.9.1.
Thanks a lot.

A fallback to v1.8 made it work again.
testcode:
| makeresults count=1 | eval query="www.somedomain.cloudapp.net/" | eval list="mozilla" | `ut_parse_extended(query, list)`

I can confirm this resolved my mozilla list issue with v1.9.1 after replacing everything in the default and bin folder.

@Bamfax please update to 1.9.2 that was just made available on Splunkbase and verify that the list is now loaded as expected. Feel free to re-open this in case of issues, Thanks!


Fix #548: Fix e.path.indexOf check in older browsers.

In older browsers e.path is a NodeList and has no indexOf method. Convert the list only
if it's not already an array to be able to call the method successfully.

Coverage decreased (-0.3%) to 69.14% when pulling db9a77c964dcf61d04f8f92c6782472c71e033ff on ernestoalejo:master into 76690928fe742c7992a0a46d508281af4ae0df3b on chmln:master.


Driver Controller: Ensure CSI Config Creation

Describe what this PR does
If a driver CR exists but no client profile CR exists, any container that needs to mount the ceph-csi-config config map will fail. To solve the issue, the following behavior is added:

Driver controller creates an empty ceph-csi-config config map if not already exist and adds an owner ref
Driver controller watch for delete events for ceph-csi-config config map

/hold
This PR is rebased on top of #103 and should not be merged until #103 is merged

Driver controller creates an empty ceph-csi-config config map if not already exist and adds an owner ref
Driver controller watch for delete events for ceph-csi-config config map

Instead of watching for delete events can't we add the driver as the ownerRef if the configmap already exists and we don't need to consider delete events?

/unhold
#103 merged, @Madhu-1 can you please add this to your review queue?

Driver controller creates an empty ceph-csi-config config map if not already exist and adds an owner ref
Driver controller watch for delete events for ceph-csi-config config map

Instead of watching for delete events can't we add the driver as the ownerRef if the configmap already exists and we don't need to consider delete events?

We are already adding the driver as an owner ref. But there is still a need to watch for delete events for the case where the configmap goes away and need to be recreated. The delete filter makes sure that  we are not queuing an based on create or update events

Driver controller creates an empty ceph-csi-config config map if not already exist and adds an owner ref
Driver controller watch for delete events for ceph-csi-config config map

Instead of watching for delete events can't we add the driver as the ownerRef if the configmap already exists and we don't need to consider delete events?

We are already adding the driver as an owner ref. But there is still a need to watch for delete events for the case where the configmap goes away and need to be recreated. The delete filter makes sure that we are not queuing an based on create or update events

Sorry am failing to understand it as we are adding the owner ref if the configmap already exists how it will go away if the driver is not deleted? Do you mean the use will manually remove the configmap by hand?

Yes.
It can be faulty code in external automation, or some bug in rook or client, or a mistake by an admin, or someone just overwrote the entire ownerRef section instead of adding to it.
If a controller takes the responsibility to move a system toward a certain actual state it also needs to take the responsibility to readjust if that actual state has changed (for any reason)


Idea: Old Top Bar Icons Option

So, recently i found out that in the folder /content/textures/ui/TopBar the icons for the top bar is located. It would be cool for there to be an option in the Bloxstrap Mod menu to replace the new textures with old textures, instead of having to do it one by one.
This is what the folder contains:

In the UI folder (/content/textures/ui), i also found the Chat, Backpack, Old menu, and the old Emotes icons:
/ui/Backpack

/ui/Chat

/ui/Menu

/ui/Emotes

(PS: You don't have to download these icons from this issue, just search for them in your roblox install folder)
I also found the Leaderboard icons:

Maybe you could replace the leaderboard icons with these ones: (icons on the left is are the new ones, on the right are the old ones)
/ui/PlayerList/
 (there should be an option to choose if you want the BC, TBC or OBC icon)

(you are gonna have to download the icons on the right, beacuse they are not in the new roblox folder)
There is probably more old icons in the folder, but thats some that i could find.
Thanks in advance!

did you read the help documentation on making custom mods

Guess you could ddo it like that.


Import auto replace spolied all the codebase

Just wanted to express my annoyance 👿
I moved a single file, and VS code proposed to "replace imports automatically" or what does it say. What happend after: it replaced ALL relative imports ../some/path/...  to something like ~/app/some/path such paths is valid only for front-end app.
Also, it replaced import {styles} from 'typestyle' to import {styles} from 'typestyle/lib', and like that, what? I even noticed some time minutes later.
Though this probably should go to Typescript.

Does this reproduce in the latest VS Code insiders build with all extensions disabled?


Support for parsed queries (AST)

If you use graphql-tag, you need to print() your queries when passing them to graphql-request. It would be helpful if you could pass in those AST queries directly.

I understand. Would supporting this require another dependency?

Very good point @schickling. It would introduce a dependency on graphql, which you would already have when using graphql-tag. I think the best option is to make it a peer dependency. That would make the runtime method available only to those who would already have it installed, and it would not increase package size or dependencies for those who don't need it.

That sounds like a good solution. Can you create a PR?

Wouldn't this result in "peer dependency unresolved" warnings from npm/yarn when installing the package? Doesn't feel like the best developer experience when all you need is the basic graphql-request functionaly.

@MaxMilton You are right. I think it should just be a dependency.

I'd rather not have any more dependencies when it can be avoided, even polyfills are largely unnecessary. If it must go in then yes, peerDependencies is the correct field for optional/plugin packages.

It would be nice to support this as the gql template string prefix is the common trigger for graphql syntax highlighting and completion features in quite a few code editors.

@Alex-Mann I found a rather... hacky... workaround for that, and that is to just make a file, graphql-tag.js with export default tag => tag in it. I then import the file as import gql from './graphql-tag;.
Not a real solution, but it "fixed" syntax highlighting, auto-completion, Prettier and ESLint support.

I agree, I think it would be a useful addition. Can somebody create a PR for this?

If we want to do this without introducing extra dependencies it could be interesting to just export a gql function (which does nothing except for returning the same arguments), like this:
import { request, gql } from 'graphql-request'

const query = gql`{
  Movie(title: "Inception") {
    releaseDate
  }
}`

This works for me
export function gql(string) {
  return String(string).replace(`\n`, ` `)
}

Does anyone know how I can turn the GraphQL AST from graphql-tag back into a text query?  I'm needing to using my queries with graphql-request

Figured it out:
import { print } from 'graphql/language/printer';
print(AST);

Is there another way we can support this without making built-in changes to graphql-request? The current solution caused https://github.com/prismagraphql/graphql-request/issues/94

Any update on this? I'd like to use graphql-tag with graphql-request

I create an utilitiy to replace graphql-tag:
import gql from 'gql-tag'

const QUERY_TODO = `
  query Todos($id: ID) {
    todo(id: 5) {
      id
      title
    }
  }
`

const GET_TODO_GQL = gql`
  query Todos($id: ID) {
    todo(id: 5) {
      id
      title
    }
  }
`

expect(QUERY_TODO).toBe(GET_TODO_GQL) // pass

Usage:
import { request } from 'graphql-request'
import gql from 'gql-tag'

const query = gql`
  {
    Movie(title: "Inception") {
      releaseDate
      actors {
        name
      }
    }
  }
`
`

request('https://api.graph.cool/simple/v1/movies', query).then(data =>
  console.log(data)
)

Thanks to @wesbos there is a pretty easy solution. Wrap this library like so:
import { GraphQLClient } from 'graphql-request';
import { print } from 'graphql/language/printer';
import { Variables } from 'graphql-request/dist/src/types';
import { ASTNode } from 'graphql';

export const githubGql = (query: ASTNode, variables?: Variables) => {
  const client = new GraphQLClient('https://api.github.com/graphql', {
    headers: {
      authorization: `bearer ${process.env.token}`,
    },
  });

  return client.request(print(query), variables);
};

Any progress on this?

@zackify I'm going to steal your snippet 👌

I've published https://www.npmjs.com/package/awesome-graphql-client
It has support for custom query formatters and GraphQL Upload Spec. Works in NodeJS and browsers.
Hope you enjoy!

v3 fixes this issue I think, cc @jasonkuhrt

Thanks @Gomah yep this issue is resolved in v3.


Fix/monolog use files

Version 1.0.0 of Lost in Translation doesn't appear to properly write log files: when using it in testing an actual application, two things happen:

Errors are sent to both the laravel.log as well as lost-in-translation.log files, which is redundant.
Tests will fail with Error: Call to undefined method Monolog\Logger::useFiles().

This PR establishes an actual "lost-in-translation" logging channel (dynamically at runtime after a missing translation is found, unless the user sets it up in their config/logging.php file), as well as actually verifies against the filesystem that the log was written.

Coverage remained the same at 100.0% when pulling c118229c923fffd0dce8510f57a7817edffe4e1a on fix/monolog-use-files into 4fb656bad99e313375969117de566c8c859fbbb4 on develop.

Coverage remained the same at 100.0% when pulling c118229c923fffd0dce8510f57a7817edffe4e1a on fix/monolog-use-files into 4fb656bad99e313375969117de566c8c859fbbb4 on develop.

Any chance of this getting merged soon?

I'm currently dog-fooding this package on a client application, and have been running into issues with logs not saving properly — once I'm able to spend the time ensuring everything works properly, it'll be ready for merge + a fresh release.

Any update on this PR? Would love to use this package for a project but running in into this issue with Laravel 5.7. If i can help out in any way let me know.


Add logging to the rails console for easier debugging

Messages like:

action not found in policy, using default
operation not found, using default

Added in 0.9


Isotropic thermal expansion

The Lassen build is also failing on develop, so I'm guessing it's a system change issue.


Condition error

When I run your role with:
  roles:
    - role: fubarhouse.rust
      vars:
        rust_version: 1.37
        shell_profiles:
          - .zprofile
        cargo_items:
          - bat
          - lsd
          - pug
          - racer
          - rustfmt-nighty
          - sass-rs
          - spruce
      become: true

I get (screenshot taken from virtual, sorry):

Thanks for reporting!
It seems the logic needs to be updated - I'll make it happen.

Changes introduced in branch issue/20 will fix this issue.
You will however need to change rust_version to 1.37.0.
Please test when possible.
meta:
  timestamp: 2019-09-08T22:10:05.607375+10:00
  repository: git@github.com:fubarhouse/ansible-role-rust.git
  commithash: 104550badc276ddef02d83c796c4d38882e89055
  localchanges: true
  reportfile: report.yml
ansible:
  config:
    hostpath: /Users/karl/PycharmProjects/ansible-role-rust
    inventory: ""
    remotepath: /etc/ansible/roles/role_under_test
    extrarolespath: ""
    librarypath: ""
    requirementsfile: ""
    playbookfile: tests/playbook.yml
    remote: false
    verbose: true
    quiet: false
  distribution:
    cid: ""
    name: ubuntu1804
    privileged: true
    container: fubarhouse/docker-ansible:bionic
    user: fubarhouse
    distro: ubuntu1804
    family:
      name: Ubuntu
      initialise: /sbin/init
      volume: /sys/fs/cgroup:/sys/fs/cgroup:ro
  hosts:
  - localhost
  syntax: true
  requirements: false
  run:
    result: true
    time: 3m53.524527879s
  idempotence:
    result: true
    time: 10.799883279s
docker:
  run: true
  kill: true
  volumes:
  - /sys/fs/cgroup:/sys/fs/cgroup:ro
  - /Users/karl/PycharmProjects/ansible-role-rust:/etc/ansible/roles/role_under_test
  - /Users/karl/PycharmProjects/ansible-role-rust:/etc/ansible/roles/ansible-role-rust

Note that I will fix up the automated testing in the meantime.

I dont have any machine available for tests right now.

Seeing as this fixes just one piece of logic which doesn't fail with a valid version identifier of Rust, I'll merge this tonight. It seems I need to update my tester, so this can come independently of this change.

I did test it with 1.37 and it failed. I guess if your instalation goes well it's ok.

Have you tried using 1.37.0 and not 1.37?

yes

Are you able to provide a verbose output of the problem?
I thought I had successfully replicated and resolved the issue you were facing - I may have been mistaken.

I got the same error.  Here's the output, tested on Ubuntu 18.04 fresh box:
TASK [rust : Rust | Install Cargo] ********************************************************************************************************
ok: [HIDDEN.IP.ADDRESS.HERE] => (item={'name': 'ripgrep', 'binary': 'rg'})

TASK [rust : Rust | Verify Cargo] *********************************************************************************************************
failed: [HIDDEN.IP.ADDRESS.HERE] (item={'changed': False, 'end': '2020-07-01 16:55:17.367578', 'stdout': '', 'cmd': '/root/.cargo/bin/cargo install ripgrep | cat', 'rc': 0, 'start': '2020-07-01 16:55:16.252156', 'stderr': '    Updating crates.io index\n     Ignored package `ripgrep v12.1.1` is already installed, use --force to override', 'delta': '0:00:01.115422', 'invocation': {'module_args': {'creates': None, 'executable': None, '_uses_shell': True, 'strip_empty_ends': True, '_raw_params': '/root/.cargo/bin/cargo install ripgrep | cat', 'removes': None, 'argv': None, 'warn': True, 'chdir': None, 'stdin_add_newline': True, 'stdin': None}}, 'stdout_lines': [], 'stderr_lines': ['    Updating crates.io index', '     Ignored package `ripgrep v12.1.1` is already installed, use --force to override'], 'failed': False, 'item': {'name': 'ripgrep', 'binary': 'rg'}, 'ansible_loop_var': 'item'}) => {"ansible_loop_var": "item", "changed": false, "cmd": "/root/.cargo/bin/cargo", "delta": "0:00:00.009836", "end": "2020-07-01 16:55:18.377396", "failed_when_result": true, "item": {"ansible_loop_var": "item", "changed": false, "cmd": "/root/.cargo/bin/cargo install ripgrep | cat", "delta": "0:00:01.115422", "end": "2020-07-01 16:55:17.367578", "failed": false, "invocation": {"module_args": {"_raw_params": "/root/.cargo/bin/cargo install ripgrep | cat", "_uses_shell": true, "argv": null, "chdir": null, "creates": null, "executable": null, "removes": null, "stdin": null, "stdin_add_newline": true, "strip_empty_ends": true, "warn": true}}, "item": {"binary": "rg", "name": "ripgrep"}, "rc": 0, "start": "2020-07-01 16:55:16.252156", "stderr": "    Updating crates.io index\n     Ignored package `ripgrep v12.1.1` is already installed, use --force to override", "stderr_lines": ["    Updating crates.io index", "     Ignored package `ripgrep v12.1.1` is already installed, use --force to override"], "stdout": "", "stdout_lines": []}, "rc": 0, "start": "2020-07-01 16:55:18.367560", "stderr": "", "stderr_lines": [], "stdout": "Rust's package manager\n\nUSAGE:\n    cargo [OPTIONS] [SUBCOMMAND]\n\nOPTIONS:\n    -V, --version           Print version info and exit\n        --list              List installed commands\n        --explain <CODE>    Run `rustc --explain CODE`\n    -v, --verbose           Use verbose output (-vv very verbose/build.rs output)\n    -q, --quiet             No output printed to stdout\n        --color <WHEN>      Coloring: auto, always, never\n        --frozen            Require Cargo.lock and cache are up to date\n        --locked            Require Cargo.lock is up to date\n        --offline           Run without accessing the network\n    -Z <FLAG>...            Unstable (nightly-only) flags to Cargo, see 'cargo -Z help' for details\n    -h, --help              Prints help information\n\nSome common cargo commands are (see all commands with --list):\n    build       Compile the current package\n    check       Analyze the current package and report errors, but don't build object files\n    clean       Remove the target directory\n    doc         Build this package's and its dependencies' documentation\n    new         Create a new cargo package\n    init        Create a new cargo package in an existing directory\n    run         Run a binary or example of the local package\n    test        Run the tests\n    bench       Run the benchmarks\n    update      Update dependencies listed in Cargo.lock\n    search      Search registry for crates\n    publish     Package and upload this package to the registry\n    install     Install a Rust binary. Default location is $HOME/.cargo/bin\n    uninstall   Uninstall a Rust binary\n\nSee 'cargo help <command>' for more information on a specific command.", "stdout_lines": ["Rust's package manager", "", "USAGE:", "    cargo [OPTIONS] [SUBCOMMAND]", "", "OPTIONS:", "    -V, --version           Print version info and exit", "        --list              List installed commands", "        --explain <CODE>    Run `rustc --explain CODE`", "    -v, --verbose           Use verbose output (-vv very verbose/build.rs output)", "    -q, --quiet             No output printed to stdout", "        --color <WHEN>      Coloring: auto, always, never", "        --frozen            Require Cargo.lock and cache are up to date", "        --locked            Require Cargo.lock is up to date", "        --offline           Run without accessing the network", "    -Z <FLAG>...            Unstable (nightly-only) flags to Cargo, see 'cargo -Z help' for details", "    -h, --help              Prints help information", "", "Some common cargo commands are (see all commands with --list):", "    build       Compile the current package", "    check       Analyze the current package and report errors, but don't build object files", "    clean       Remove the target directory", "    doc         Build this package's and its dependencies' documentation", "    new         Create a new cargo package", "    init        Create a new cargo package in an existing directory", "    run         Run a binary or example of the local package", "    test        Run the tests", "    bench       Run the benchmarks", "    update      Update dependencies listed in Cargo.lock", "    search      Search registry for crates", "    publish     Package and upload this package to the registry", "    install     Install a Rust binary. Default location is $HOME/.cargo/bin", "    uninstall   Uninstall a Rust binary", "", "See 'cargo help <command>' for more information on a specific command."]}

PLAY RECAP ********************************************************************************************************************************
HIDDEN.IP.ADDRESS.HERE              : ok=41   changed=0    unreachable=0    failed=1    skipped=19   rescued=0    ignored=0


Add 'Raises' section to docstring

https://github.com/wattsight/wapi-python/blob/dc0d3534b4c8fe0bcc577ac25d93ebeffdfd2dc0/wapi/session.py#L115
I might have the expectation from the documentation that I will get a curve or None - in fact I get an exception if the curve is not found.

https://github.com/wattsight/wapi-python/blob/dc0d3534b4c8fe0bcc577ac25d93ebeffdfd2dc0/wapi/session.py#L470
Any response from the API that does not return the HTTP code OK 200 will throw an exception.
The API returns 404 when a curve is missing, an instance is missing etc. The API returns the appropriate HTTP error code where this makes sense. 403/401 for various authorization/authentication issues. We can also return other 4xx errors when your request exceeds limits or is otherwise malformed. 500 is returned when something has gone wrong in the API.
Returning None would not give you the error message or opportunity to handle the error correctly, which is why we throw the error(s).

https://github.com/wattsight/wapi-python/blob/dc0d3534b4c8fe0bcc577ac25d93ebeffdfd2dc0/wapi/session.py#L470
Any response from the API that does not return the HTTP code OK 200 will throw an exception.
The API returns 404 when a curve is missing, an instance is missing etc. The API returns the appropriate HTTP error code where this makes sense. 403/401 for various authorization/authentication issues. We can also return other 4xx errors when your request exceeds limits or is otherwise malformed. 500 is returned when something has gone wrong in the API.
Returning None would not give you the error message or opportunity to handle the error correctly, which is why we throw the error(s).

I think perhaps that not finding a curve is not an "exceptional event" and is in fact normal operation. However I understand your desire to communicate the error condition to the user - however none of what you have explained above is documented anywhere. Which is the point of this issue :)

I think perhaps that not finding a curve is not an "exceptional event" and is in fact normal operation. However I understand your desire to communicate the error condition to the user - however none of what you have explained above is documented anywhere. Which is the point of this issue :)

We are indeed lacking some cases around exception handling.
I will look into it for the upcoming release. We plan to add type hints to the upcoming release to ease these bits. It should be solved as a part of that process.

We are indeed lacking some cases around exception handling.
I will look into it for the upcoming release. We plan to add type hints to the upcoming release to ease these bits. It should be solved as a part of that process.


Add Ability to Display a Progress Bar

By default, no progress bar is displayed to conserve the previous default behavior.

Codecov Report

Merging #318 into master will decrease coverage by 0.03%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
- Coverage   86.25%   86.22%   -0.04%
==========================================
  Files          21       21
  Lines        3092     3099       +7
  Branches      535      536       +1
==========================================
+ Hits         2667     2672       +5
- Misses        372      373       +1
- Partials       53       54       +1

Impacted Files
Coverage Δ

pywt/_cwt.py
79.48% <77.77%> (-1.77%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8377379...33d20bd. Read the comment docs.

@TariqAHassan a progress bar in a function like cwt is highly unusual. Why do you think this is a good idea? And how slow is that for-loop for you?

Yeah, I thought I may get that question. I am working with audio (long classical music pieces) on a fairly fast computer and the computations still take 4+ minutes.
If you're primarily using cwt with short signals, I can see how a progress bar would seem odd. However, with medium sized audio clips it is pretty easy to find one's self with 15B+ element arrays (even using a low sample rate). If you combine that with the need to use a large number of scales, the calculation quickly becomes very expensive.
Lastly, I might add that the need to perform CWT on long arrays of complex signals is unlikely to be that uncommon, given the pervasiveness of audio data (particularly music).
Best,
Tariq

As an alternative, perhaps monkey-patching it something like this (not sure, haven't really contributed much since the addition of CWT) could work:
def cwt(data, scales, *args, **kwargs):
  with tqdm(total=len(scales)) as pbar:
    tmp = pywt._cwt.integrate_wavelet
    def wrapper(*args, **kwargs):
      pbar.update(1)
      return tmp(*args, **kwargs)
    pywt._cwt.integrate_wavelet = wrapper
    pywt.cwt(data, scales, *args, **kwargs)

That way, people can add whatever callback function they like to keep track of cwt if it is too slow.

Agree with @kwohlfahrt, it's easy to make a little wrapper function that adds a progress bar. This doesn't really belong in pywt. So I suggest we close this PR.

@rgommers Fair enough. However, it would be nice if kwohlfahrt's code snippet could land somewhere so it's available to others, e.g, the docs.

It seems to me that we should never encourage people to rely on private objects like pywt._cwt - it works now, but if we want to allow this kind of thing and put it in the docs, we should add a callback mechanism to cwt instead. Which seems overkill, so how about just passing in scales in smaller chunks? Something like (untested but should work):
def cwt(data, scales, *args, **kwargs):
    with tqdm(total=len(scales)) as pbar:
        for scale in scales:
            # simplest version, can also break scales in chunks of size >1
            pbar.update(1)
            pywt.cwt(data, scale, *args, **kwargs)


Docs: 1.12 RC - how to configure the swarm managers be manager-only nodes?

The https://docs.docker.com/engine/swarm/key-concepts/ mentions  "By default manager nodes are also worker nodes, but you can configure managers to be manager-only nodes.", I was not able to find how to configure the swarm managers to be manager-only nodes, maybe I missed something, but could someone shed some light on this? Thanks.

I guess you could set a constraint as mentioned in https://docs.docker.com/swarm/scheduler/filter/ (set label containerslots to the running number of containers). Not intended to do what you want but it It would do the trick, probably.

ping @vieux @aluzzardi

+1 I also wondered about this

I think the way to do this is to put them in drain;
docker node update --availability=drain <node-id>

docs may need to be improved on that
/cc @sfsmithcha

@thaJeztah Thanks, it works perfectly, after I drained the manager, the containers are not scheduled on the manager any more.  I am fine with closing this issue, if we do not need this issue to track the possible doc changes.

Docs for this are WIP.  @thaJeztah is right:
docker node update --availability=drain <node-id>

closing per @ligc 's comment

Sorry to revive this closed topic but while drain does the job, am i the only one thinking that semantically 'drain' is wrong here ? My understanding is your drain a node so you can put it out of your cluster and it seems now we are using this flag for its side effect of making sure the orchestrator will not place anything on that node.
Wouldn't it be better to introduce another availability mode that does not imply there is something wrong with the node and better express the intent ?

And this does work for "new" docker 0.12+ swarms with integrated nodes or also for "legacy" swarms that where setup with docker-machine with <=0.11/swarm:latest ?

@tronicum "Swarm" is really separate from this; please check https://github.com/docker/swarm/issues for feature requests for that


No module named 'kws_streaming'

I am trying https://github.com/google-research/google-research/blob/master/kws_streaming/colab/00_check_data.ipynb in colab.
I am getting error as :
ModuleNotFoundError                       Traceback (most recent call last)
 in ()
1
----> 2 from kws_streaming.models import models
3 from kws_streaming.models import utils
4 from kws_streaming.layers.modes import Modes
5 import tensorflow as tf
ModuleNotFoundError: No module named 'kws_streaming'

@vishalkevat007 please share error message.
You should follow steps described in experiments
For example install all dependencies before running your colab:
pip install --upgrade pip
pip install tf_nightly
pip install tensorflow_addons
pip install tensorflow_model_optimization

# install libs:
pip install pydot
pip install graphviz
pip install numpy
pip install absl-py

After all above you can execute
jupyter notebook

and run colabs

@rybakov Thank you so much.
I followed the steps mentioned by you and it worked.


Revert "Revert "CON-2003 open products from cart""

Reverts shopgate/theme-ios11#100

Coverage increased (+0.08%) to 25.958% when pulling 718227bab94f86c09a130d37d4a12d5487f0b106 on revert-100-revert-98-CON-2003-open-products-from-cart into 8f61c6bd550ae80ba58ea9f9639eac5d172f1355 on master.


Bluetooth: host: Added inline function for gatt notify by uuid

Added a static inline helper function to notify by uuid, similar to bt_gatt_notify.

I fixed the warnings from checkpath, but re-pushing apparently didn't retrigger it. Can I manually request a re-run somehow?

@Emil-Gydesen-Bose No I think checkpatch is still right. There is tabs in this part:
 *  @param uuid	The UUID. If the server contains multiple services with the same
 * 		UUID, then the first occurrence, starting from the attr given,
 * 		is used.
 *  @param attr	Pointer to an attribute that serves as the starting point for
 * 		the search of a match for the UUID.

You should align using spaces only here.


time distribution layer does not set property of underlying layer

Time distribution layer does not set property of the the underlying layer.
This leads to some properties not being set.

:octocat: cibot: Thank you for posting issue #1189. The person in charge will reply soon.


Fixes undeclared variables

Hi. Any thoughts on this merge? Without these explicit variable declarations, this package produces breaking errors when using processors like uglify, which enforce strict mode. Would very much appreciate this simple fix being merged in. Thanks.

sorry, just moved some stuff around, i'll push up a fix in another pr.

this should be fixed with https://github.com/benrlodge/react-simplemde-editor/pull/17


Write a rudimentary STAT

ttx_diff claims we match Oswald. Not cheating at all to massage the results right?
  Only fontmake produced 'GDEF', 'GPOS', 'HVAR'
  DIFF 'GSUB', build/default/fontc.GSUB.ttx build/default/fontmake.GSUB.ttx
  Identical 'GlyphOrder'
  Identical 'OS_2'
  Identical 'STAT'
  Identical 'avar'
  Identical 'cmap'
  Identical 'fvar'
  DIFF 'glyf', build/default/fontc.glyf.ttx build/default/fontmake.glyf.ttx
  DIFF 'gvar', build/default/fontc.gvar.ttx build/default/fontmake.gvar.ttx
  Identical 'head'
  Identical 'hhea'
  Identical 'hmtx'
  Identical 'loca'
  DIFF 'maxp', build/default/fontc.maxp.ttx build/default/fontmake.maxp.ttx
  Identical 'name'
  Identical 'post'

when we implement DSv5 support

I entirely agree but I would not that I was unable to identify an actual font using DSv5

I was unable to identify an actual font using DSv5

most fonts on GF are built using gftools which has its own module that uses fontTools buildStatTable API to construct a full STAT using the metadata from axisregistry. We may have to look at non-GF projects for examples of DSv5 usage for STAT building.


Support oneOf inheritance for JsonSchema Generation #832

Hello,
Just made some modifications to generate a jsonschema with oneOf inheritance. I didn't do anything for CodeGeneration as don't need it.
For schema generation do you think it is the way to go? And what did you think about when you mention inheritanceMode ? (which kind of mode would you propose?)

Refs:

#832
#13
#302

Any progress on this?

Any progress on this?

This one is about generating C# OneOf from JsonSchema OneOf.
Is any progress in another direction? I mean generating JsonSchema OneOf from C#  OneOf?

Any progress on this?

This one is about generating C# OneOf from JsonSchema OneOf. Is any progress in another direction? I mean generating JsonSchema OneOf from C# OneOf?

@RicoSuter Is any progress for it?
I really need it...

Hi.
As a work-around I was able to use an operation processor.
See https://gist.github.com/icnocop/10de946939e5046190219cc8817356c4
It works for my case, but may not be the best solution, and may not support all scenarios.
For example, it may have been better to use a schema processor instead.
Usage, in Startup.cs, in ConfigureServices:
services.AddOpenApiDocument((settings, serviceProvider) =>
{
    settings.FlattenInheritanceHierarchy = true;
    settings.SchemaType = SchemaType.OpenApi3;
    settings.OperationProcessors.Add(new OneOfOperationProcessor());
    settings.AllowReferencesWithProperties = true;
});

My types are defined and decorated similar to the following:
[KnownType(typeof(ItemA))]
[KnownType(typeof(ItemB))]
[JsonConverter(typeof(JsonInheritanceConverter), "discriminator")]
[JsonInheritance("A", typeof(ItemA))]
[JsonInheritance("B", typeof(ItemB))]
public abstract class Item
{
}

public class ItemA : Item
{
}

public class ItemB : Item
{
}

I only tested with types, and generic types with one generic type parameter.

Very old PR, closing now. Please open another PR against recent source if this is still an issue.


Use petagraph for call trace

Which components does the task require to be changed? (think hard pls)
snforge
Description
Currently we use Rc<RefCell<T>> to keep both the graph (CallTrace) and the pointer to current node in CheatnetState. It is not idiomatic + has some runtime cost (prob negligible for now)

Moving it to profiler team.
Not sure if petagraph but definitely we need to use id-based graph to guarantee uniqueness of vertices.


Bump version to 2.0.3

Questions
Answers

Description?
Bump version to 2.0.3

Type?
improvement

BC breaks?
no

Deprecations?
no

Fixed ticket?
N/A

How to test?
N/A

Thanks @Progi1984 !


How to get around "Host not authorized" error when accessing besu from second host or Metamask?

I have set:
--rpc-http-enabled=true
--rpc-http-host="<IP_ADDRESS>"
--rpc-ws-enabled=true
--rpc-ws-host="<IP_ADDRESS>"
--engine-host-allowlist=*
--engine-jwt-disabled=true
but I still can't access besu from a second server.
(note that the command below is running on a second server)
$ curl -H 'Content-Type: application/json' -X POST http://ethereumserver:8545 -d '{"jsonrpc":"2.0","method":"eth_syncing","params":[],"id":51}'
{"message":"Host not authorized."}

What am I missing?  I read the documentation that talked about the above parameters at https://besu.hyperledger.org/23.7.3/public-networks/how-to/use-engine-api
but maybe I missed it.  Thank you.

resolved by using --host-allowlist=*


Add keyboard support and create fix for image URLs containing parentheses

Implement iron-a11y-keys. Now you can press left or up arrow keys to show the previous image and right or down to show the next image in the slideshow.
Fixes #12 and fixes #13

Thank you so much 👍

No problem, thanks for making the element. I have some other ideas in mind that we can discuss later on.


Add support for "option" field in protobuf message

For a protobuf message of type
message AuthRequest {
  option (type_id) = 1001;
  // Commissioning credential
  string password = 1;
}

Resulting Swift code does not contain the option (type_id) = 1001; and the number cannot be accessed. Are there plans to add support for class descriptions (aka protobuf option)?
Is it already supported and I'm missing a plugin switch?

@idokleinman Protobuf 3 made everything optional by default and got rid of the notion of 'required' (the opposite of optional).
Now, there are arguments against and for it, but I don't think the generated code can detect if something is optional if it's been set with a default value. In fact, it's an issue I'm dealing with here, trying to figure out if a value is default set or set since it's optional, it's hard to tell.
It's a step down for some, and a step up for others. I personally would have preferred it, but not sure if swift-protobuf supports Protobuf 2 specs and I rather not go back a version that might be abandoned (Google claims they won't).

I misunderstood, and thought you meant optional.

Options are metadata that is only captured in the descriptor describing the messages.  The Swift proto runtime currently doesn't need any of this information because doesn't use it and the data can be a non trivial amount of data added to binaries that most things don't need.
The first step would likely be to bundle the generated code for _descriptor.proto` with the library (Issue #727), and then see about how it makes sense to expose this from messages.

Has there been any more thought put into this? Just discovered this myself. Our team uses custom options extensively in our protos (for better or worse).

Not really.  We did start bundling descriptor.proto a while ago to remove that issue.
As mentioned, since the data can be non trivial in size, figuring out a way to do this that doesn't bloat things is important.  The other issues asking for the protobuf reflection type apis (act on message fields generically), also need some of the same information/apis, so there's a good chance that would all be done together.

Other protobuf implementations handle this by dumping the serialized descriptors into the generated code in their entirety.  When you access your custom option, they deserialize the descriptor and look up the option data there.
If this is important to you, you can do this manually:  Use protoc to dump the descriptors, bundle them into your code, and then deserialize them and inspect them to retrieve the custom options.  It's a little tedious, but feasible.
We've been slow to implement this by default for several reasons:

Swift does not currently have a really good way to embed binary data in the generated code.
The deserialized descriptors can use a lot of memory.  Many people object to this.
Getting useful data out of the descriptors can be pretty tedious.  Other implementations have pretty involved collections of helper code to present a nicer interface to this.  We've built a little of that support for the code generator but it's not yet complete enough to support these kinds of uses.

Here are some hints for folks who want to use options:

You can generate a FileDescriptorSet using protoc:

  protoc --descriptor_set_out=.  some.proto other.proto

That FileDescriptorSet is a protobuf-serialized copy of your proto definitions.  You can deserialize it with the descriptor type that's included in the SwiftProtobuf library:

 import SwiftProtobuf
 let fileDescSet = Google_Protobuf_FileDescriptorSet(serializedData: data)

From this, you can walk the proto definition and read off any options you're interested in.  The details of the file descriptor set are in descriptor.proto here:  https://github.com/protocolbuffers/protobuf/blob/master/src/google/protobuf/descriptor.proto

In particular:

A "FileDescriptorSet" holds an array of "FileDescriptor" objects, one for each file in the set.
A "FileDescriptor" object has an array of "Descriptor" objects defining each message.
A "Descriptor" has an array of "FieldDescriptor" objects defining the fields of that message.
Each "Descriptor" and "FieldDescriptor" includes an "options" array with all options defined on that message or field.

The above information should be enough to make use of option data.  The only missing piece is somehow embedding the information into your project.  The C++ implementation does this by embedding the entire FileDescriptorSet into the generated output, and implicitly deserializing the entire thing in order to look up option information.  This has obvious problems with size (code size for the embedded data and memory size for the decoded descriptor information) which is a major reason we've been hesitant to implement this so far.
If enough people experiment with this, maybe we can collectively acquire enough experience with different approaches to come up with a good solution.  (For example, I've recently started wondering if there could be a separate generator that just generated this information as extensions to the Swift message types; you could then run that separate generator in addition to protoc-gen-swift to get this additional support.  A similar approach might be used to split out the JSON/text support logic that some people would like to omit.)


Missing locale entry of Folder Importer

There are no locale entries for

Image slices as volumetric texture
Image slices as volumeric texture (grayscale)

I've submitted a fix for this, I'll be adding it to locale shortly

https://github.com/Yellow-Dog-Man/Locale/pull/51 has the locale strings

This should be resolved now, please re-open if not


get rid of needing docker for launching ctl-runtime-deps

Closes # .
In this PR I introduce a startPostgres and a startPlutipServer function, which enable us to get rid of the need to manually start a plutip-runtime and `plutip-server.
One is now able to just run the test without any other steps being required. A developer can just
nix develop
spago test -m Plutip.Server

Pre-review checklist

[x] All code has been formatted using our config (make format for Purescript, nixpkgs-fmt for Nix)
[x] All Purescript imports are explicit, including constructors
[ ] All existing examples have been run locally against a fully-synced testnet node
[ ] The integration and unit tests have been run (npm run test) locally
[ ] The changelog has been updated under the ## Unreleased header, using the appropriate sub-headings (### Added, ### Removed, ### Fixed)

Overall - great, this is really making us deliver sooner!

Let's silence psql output.


WIP: OCPBUGS-13551: FailedPrecondition volume does not appear staged

Each Device object has a RealDev field showing the underlying device
path after resolving symlinks. GetDevMounts checks each device in the
mount table against the RealDev field and only returns mounts for that
device. However, the mount table may have symlinks, such as /dev/mapper
devices, and it should resolve those before comparing to RealDev.
Marking this WIP until upstream PR merges, want to run presubmit jobs in the mean time.
https://issues.redhat.com/browse/OCPBUGS-13551
cc @openshift/storage

/jira refresh

/reopen
/remove-lifecycle rotten

/jira refresh

[sig-etcd] etcd should not log excessive took too long messages
/retest-required

/retest

/test e2e-vsphere-ovn-upgrade

e2e-vsphere-ovn-upgrade is failing due to https://issues.redhat.com/browse/OCPBUGS-29126

/retest-required

upstream PR merged
/retitle OCPBUGS-13551: FailedPrecondition volume does not appear staged
/retest-required
/cherry-pick release-4.15 release-4.14

/lgtm