The grid widget

Can you leverage the Fulma elements to build a grid/table widget?
The reason is usually that is the most useful widget in web development.
Such as: https://ant.design/components/table/
Thanks.

For such things, you have the table element.
Example taken from our production app (so I masked the sensitive data ^^)

Are you speaking about being able to wrote this kind of display from scratch or having a datatable like component that take a source of data/columns and do the display for you ?
If that's the first then you can already do it.
For the second I am planning to add something like that into Fulma already tracked here #63 . Just need some time because I want to handle pagination support, probably search, sortable too. And this take time to do correctly.

For info, creating the datatable like component should be my work of the week now that Fulma is 100% mapped.

@MangelMaxime Good to know you have the plan to create datatable widget.
The https://ant.design/components/table/ is very powerful. Please try mimic it as much as possible. Such as header freeze, left columns / right columns freeze, filter, sort, pagination, export to excel and so on.
I am plan use Fulma/Elmish in production web in case the data table function ready, thanks.
Btw, another good sample for your reference is http://demos.krajee.com/  (Widgets for Yii2)

Thank you for the sample, I will try to port the API that make sense IMO.
And that can be supported by default by Bulma.
For example, in version 1 I will not support this example:

https://ant.design/components/table/#components-table-demo-fixed-columns-header

This one because the display is really bad and hard to optimize

https://ant.design/components/table/#components-table-demo-grouping-columns

Header groups aren't supported by Bulma as far as I know

@ScottHuangZL For info, if you want to use Ant instead of Fulma @evilz is working on fable-ant-design.
This is a binding directly on top of Ant design and so you should have the same features. The binding is still in WIP

@MangelMaxime  thanks for your info.  Glad to know @evilz start working for the ant design binding.  But the most important widget datatable still not in current future, hope can see it soon.
I am agree you split Fulma datatable to different phase, the fixed columns need more time to work.
As for the grouping columns, you cannot fully depends on Bulma, instead, think about use the table/td and so on logic, thanks.
I agree these 2 features need some efforts to make it happen, may be version 1.1:)
Thanks again.


New documentation search lacking results for Wagtail settings

With the new Algolia DocSearch merged (#6833), there are a few cases where the results aren’t as good as they could be – in this instance, Wagtail settings such as WAGTAILIMAGES_INDEX_PAGE_SIZE, because they’re only used in code blocks, which aren’t indexed.
Describe the solution you'd like
We should add a heading for each setting on https://docs.wagtail.io/en/stable/reference/settings.html, so the setting variable is in the non-code-block content, and so we can link to the documentation about a specific setting. I would suggest keeping the existing headings as-is, and just adding sub-headings, so we can keep all existing links.
Additional context

Current DocSearch results: https://docs.wagtail.io/en/latest/search.html?q=WAGTAILIMAGES_INDEX_PAGE_SIZE
Previous RTD results: https://docs.wagtail.io/en/stable/search.html?q=WAGTAILIMAGES_INDEX_PAGE_SIZE

https://github.com/algolia/docsearch-configs/blob/c184ae3c34206cfa326fc218f6ad912119ddbce6/configs/wagtail.json is the configuration for our docs.
We could ask to add code[lang=python] to the selectors, but this may dillute results. Algolia suggest key code snippets to be included in headings/regular content
https://github.com/facebook/docusaurus/issues/3172 has more relevant information in this space

Yes, I should have mentioned the above is based on Algolia’s recommendation at https://docsearch.algolia.com/docs/faq/#can-you-index-code-samples.


Fix README typo - reportAllChange to reportAllChanges

reportAllChange should be reportAllChanges

I did sign the CLA immediately after making the PR, but I'm not sure why it's not showing that here. I should be all set if you can check again. Thanks!

Ahh, yes, everything looks good. Thanks!


Bug #1064465 apps: demo_uwp5662: fixed smp classic channel

[root cause  ] fix smp fixed channel which can not find
[changes     ] zephyr/subsys/bluetooth/host
[side effects] none
[self test   ]:yes
[download normally]:yes
[power on/off normally]:yes
[do common repository/branch inspection]:yes
[is there dependence]:none
[confirm dependent commit]:none
[board]:uwp5662
[test case]:none
[change_type ] bringup --> sprd_chip_support
[tag_product ] common
[reviewers   ] quan.li

Signed-off-by: yiheng.zhou<EMAIL_ADDRESS>

close this pull request


raw value

First of all, thank you for this component.
I would like to know if there is a way to get the raw value, as a float number, as in the example:
"$ 1.30" => 1.30
Maybe we could receive this value as the second parameter in the onChange callback function.

The underlying raw value is really just a string of digits,  so I think it is probably out of scope for this component to try and convert that to a float.  I recommend just using the Number.parseFloat function on the masked value (you may need to trim off the prefix and extra spaces if any).

I see that point, It would be simple to convert american masked values with parseFloat, but we would get a different value for non american formats, such as R$ 1.000,00.
Mask is mainly useful as a visual thing, I think it would be useful receiving a raw value inside the callback
There is already a logic to get the raw value, inside the function mask. My ideia is to reuse this logic.
I will try to open a pull request, if it makes sense we could merge, what do you think?

Sounds good to me, Thank you!


UI doesn't work

When I have the addon activated, I can't press any menu items. I think the addon is conflicting with my Dominos actionbars.
Current addon version: 1.0.1
Dominos version: 10.0.22

Try updating the addon on curse, it removes the invisible frame from this addon. Let me know if that fixed the issue.

Yup, that fixed it, nice!


Add nodeSelector to chart values

To have a better control on which node pool etc. Dapr shared is placed, I'd like to have a setting for nodeSelector

@KaiWalter perfect.. this is the perfect time to add those, would you mind sending a PR for that? I am currently working on this so I am happy to review, merge and create new releases with the fixes

@salaboy had it already prepared and just waited for the merge of the other PR

Can you please add helm tests? For the other change too? It should be easy
to add the assertion

Blog: http://salaboy.com http://salaboy.wordpress.com

Github user: http://github.com/salaboy

Twitter: http://twitter.com/salaboy

Mauricio "Salaboy" Salatino -

On Tue, 9 Jan 2024 at 10:17, Kai Walter @.***> wrote:

@salaboy https://github.com/salaboy had it already prepared and just
waited for the merge of the other PR
—
Reply to this email directly, view it on GitHub
https://github.com/dapr-sandbox/dapr-shared/issues/41#issuecomment-1882787463,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACCMXVXTDD6KLNGFJYFMWDYNUKLLAVCNFSM6AAAAABBSWNWK2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBSG44DONBWGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

Can you please add helm tests? For the other change too? It should be easy to add the assertion - Blog: http://salaboy.com http://salaboy.wordpress.com - Github user: http://github.com/salaboy - Twitter: http://twitter.com/salaboy - Mauricio "Salaboy" Salatino -
…
On Tue, 9 Jan 2024 at 10:17, Kai Walter @.> wrote: @salaboy https://github.com/salaboy had it already prepared and just waited for the merge of the other PR — Reply to this email directly, view it on GitHub <#41 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACCMXVXTDD6KLNGFJYFMWDYNUKLLAVCNFSM6AAAAABBSWNWK2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBSG44DONBWGM . You are receiving this because you were mentioned.Message ID: @.>

Sure - I will try my best

@salaboy added unit tests


[RFC] Proof of concept of loading trained model

Not meant to merge but as a conversation starter!

Add fixtures for PV and NWP data
Add fixture serialized model from pv-site-prediction, which in turn is added as a submodule
Standardize the interfaces to support both serialized models and non-trained models like the cosine model.
Add fixture configs for both models (cosine and serialized) and run app.py for each.

TODOs

[ ] Fix the docker (in the meantime to run the tests: poetry run pytest tests)

Working Progress comments

I like the use of config files
And good use of peotry (keen to perhaps put this in a seperate PR), but I think thats what you plan to do.
Bit disappointed that ocf_datapipes has been stripped out. I really want this to be used. This will keep all the Database connections and all the other fun things that we should not worry about here. We've learnt in the passed it has been really useful to strip out the dataloading part. This means other modules / forecast can really use lots of things together. Let's definately discuss this, but right now, I'll be disappointed if we dont use it.
For NWP test data, I found its better to use a text fixture, you can see this in #5 . I think this keeps things tidy compared to committing files

Codecov Report

Merging #7 (9c5e486) into main (81e4ad6) will increase coverage by 1.74%.
The diff coverage is 91.19%.

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   78.66%   80.41%   +1.74%
==========================================
  Files           6       11       +5
  Lines          75      194     +119
==========================================
+ Hits           59      156      +97
- Misses         16       38      +22

Impacted Files
Coverage Δ

pv_site_production/data/nwp_data_sources.py
66.66% <66.66%> (ø)

pv_site_production/utils/imports.py
91.66% <91.66%> (ø)

pv_site_production/data/pv_data_sources.py
94.23% <94.23%> (ø)

pv_site_production/scripts/apply_model.py
94.44% <94.44%> (ø)

pv_site_production/models/common.py
100.00% <100.00%> (ø)

pv_site_production/models/cos/cos_model.py
100.00% <100.00%> (+3.33%)
:arrow_up:

pv_site_production/models/psp/psp_model.py
100.00% <100.00%> (ø)

pv_site_production/models/pv_nwp/load.py
0.00% <0.00%> (-100.00%)
:arrow_down:

pv_site_production/models/pv_nwp/nwp_pv.py
0.00% <0.00%> (-100.00%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Closing in favor of #15


Use std::function<> for recv_trailing_metadata callback in LB policy API.

Known issues: #20448 #20421 #20449 #20450 #16135 #20437


Hyperdeck Mark Timecode - Goto(TC)

Hi There,
I would like to request a feature to add. This would mark the timecode of the selected hyperdeck recording, possibly to a variable or to a text file located on the attached machine.

Then when Goto(TC) is chosen as an option you can tell it to go to the variable or to read the text file to get the timecode, then goto the timecode available.
Thanks
Curtis

Interesting idea. Do you see this as a sort of clipboard or something more elaborate, where one could build up a list of markers?

a list would be great. The only problem I would be the ability to see the list? where and how would you select a timecode to goto? although you could have a list and you could cycle next/previous then goto previous marker or goto next marker. that may work.

This is a fantastic feature request.  I'd fully support this as we would use this feature.
Maybe the use case would be:

Have a limited number of available "markers" For example, 4 or 8 markers.  Buttons "Marker 1-4"
User hits a button called "Mark" to capture the timecode.
Timecode populates the next available marker list
User hits "Marker x" button followed by "GoTo(TC)

Devil is obviously in the details, but I could see this as a huge benefit.

I think this could be done like vmix does with its replay.
You have a button called Set Marker X and that button would set the current timecode as a marker in that slot. In the BFC panel you could have an option to set the marker with an amount of time subtracted or added.
For instance, you hit the button to set the marker at 1:23:25. In the panel you've set it to the marker minus 5 seconds. So it would store marker X at 1:23:20.
Then you'd have a play marker x button that would play that particular marker. Seems pretty straight forward.
I would think BFC would just have a HyperDeck Marker option that would let you create as many different markers as you want. I havent dug in to this enough to see how it works on the backend but I would imagine it would be pretty simple to do.

I've been strategizing on this.
So far, using BFC 2.2.0 beta, I can store a time code in a custom variable in the format hh:mm:ss;ff
I'm not able to do a programatic Goto TC because the TC text field will not accept a variable. Also, the timecode option to the function requires a REGEX_TIMECODE, and one of different format than what TCs are read in...it needs hh:mm:ss:ff (the difference is semicolon vs colon on the last field).  This brings up two things to address, at least:

The REGEX_TIMECODE definition is part of the BFC core, so probably should just update the module to export the proper time code format so it doesn't have to be manipulated before use.  (This may be already fixed in the latest hyperdeck module

How can we make fields accept variables?

From there I want to come up with a way to trigger actions when TCs are reached, like Play to Mark1 then make ATEM Fade to Black etc.  The triggers that are available in BFC 2.2.0 don't seem up to the task, but we'll see.

..it needs hh:mm:ss:ff (the difference is semicolon vs colon on the last field).

The REGEX_TIMECODE should be updated to allow either.
The colon(:)/semicolon(;) is part of the timecode and distinguishes between Drop Frame ';' and Non-drop which uses ':'

+1 for his request

See my request #82. When Goto (timecode) supports variables then we can created custom variables to hold the desired mark points. Goto Clip (name) > Set custom variable Markpoint > Goto (timecode) using the variable (Markpoint in this example).

+1 any news?

This definitely makes sense and would be a welcome addition!

On Oct 11, 2023, at 11:01 AM, tubalois @.***> wrote:
+1 any news?
—
Reply to this email directly, view it on GitHub https://github.com/bitfocus/companion-module-bmd-hyperdeck/issues/12#issuecomment-1757896384, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOW3KWTCDIUEAZYHLIBUPHTX62YGJANCNFSM4JR624SA.
You are receiving this because you commented.


Copy-paste mistake in README.md

Hello :)
I believe there is a mistake in the "Strings" section of the README. Please do let me know if I'm wrong, I'd be happy to put in a PR fixing this. It currently looks like this
Command      Go API                 Description
-------      ------                 -----------
DECR         DB.Str().Incr          Decrements the integer value of a key by one.
DECRBY       DB.Str().Incr          Decrements a number from the integer value of a key.
GET          DB.Str().Get           Returns the value of a key.
GETSET       DB.Str().GetSet        Sets the key to a new value and returns the prev value.
INCR         DB.Str().Incr          Increments the integer value of a key by one.
INCRBY       DB.Str().Incr          Increments the integer value of a key by a number.
INCRBYFLOAT  DB.Str().IncrFloat     Increments the float value of a key by a number.
MGET         DB.Str().GetMany       Returns the values of one or more keys.
MSET         DB.Str().SetMany       Sets the values of one or more keys.
MSETNX       DB.Str().SetManyNX     Sets the values of one or more keys when all keys don't exist.
PSETEX       DB.Str().SetExpires    Sets the value and expiration time (in ms) of a key.
SET          DB.Str().Set           Sets the value of a key.
SETEX        DB.Str().SetExpires    Sets the value and expiration (in sec) time of a key.
SETNX        DB.Str().SetNotExists  Sets the value of a key when the key doesn't exist.

when (if I'm not mistaken) it should instead say the below
Command      Go API                 Description
-------      ------                 -----------
DECR         DB.Str().Incr          Decrements the integer value of a key by one.
DECRBY       DB.Str().IncrBy        Decrements a number from the integer value of a key.
GET          DB.Str().Get           Returns the value of a key.
GETSET       DB.Str().GetSet        Sets the key to a new value and returns the prev value.
INCR         DB.Str().Incr          Increments the integer value of a key by one.
INCRBY       DB.Str().IncrBy        Increments the integer value of a key by a number.
INCRBYFLOAT  DB.Str().IncrByFloat   Increments the float value of a key by a number.
MGET         DB.Str().GetMany       Returns the values of one or more keys.
MSET         DB.Str().SetMany       Sets the values of one or more keys.
MSETNX       DB.Str().SetManyNX     Sets the values of one or more keys when all keys don't exist.
PSETEX       DB.Str().SetExpires    Sets the value and expiration time (in ms) of a key.
SET          DB.Str().Set           Sets the value of a key.
SETEX        DB.Str().SetExpires    Sets the value and expiration (in sec) time of a key.
SETNX        DB.Str().SetNotExists  Sets the value of a key when the key doesn't exist.

Best regards,
Gorka.

It took me a while to realize what had changed and in the end, I had to use diff, It would be helpful if you just pointed out the mistakes directly instead of sending the whole fixed thing with no comments on what changed :)
The changes here were that INCR and INCRBY both referred to the same Go-API of DB.Str().Incr() where as it should be using DB.Str().IncrBy() for the INCRBY commands.

The documentation is correct, the methods are called Incr and IncrFloat.


How to block an error with a particular message?

I am using Celery for one of my projects and several times it raises this error:
child process exiting after exceeding memory limit (xyzKiB / abcKiB)
It does not have any other detail except level=error, logger=multiprocessing, runtime and server name. The only unique thing that is shown here is the message field.
I would not like to block all the multiprocessing logger errors. Instead, what I wish to do is to not send errors which contain the text:
child process exiting after exceeding memory limit
Is it possible to do that?
I have tried using the before_send argument.
def remove_unnecessary_exceptions(event, hint):
    if 'message' in event:
        if 'child process exiting after exceeding memory limit' in event['message']:
            return None
    return event

sentry_sdk.init(
        dsn=SENTRY_DSN,
        before_send=remove_unnecessary_exceptions
)

But the errors still go through

if it's an exception, try this

def remove_unnecessary_exceptions(event, hint):
    if 'exc_info' in hint:
        exc_type, exc_value, tb = hint['exc_info']
        if 'child process exiting after exceeding memory limit' in exc_value:
            return None
    return event

It seems that half of them are exceptions and the other half are just error messages (as described in the original comment). Is there a way to block just the messages as well?

then your snippet is fine, maybe the text is not an exact match?


[Bug]: App crashes and won't open again after signing in

Summary
Downloaded the app (version 2.6.0) from the F-Droid store. Opened the app and logged into the app with my Commons account. App crashes and won't open again, even after closing it repeatedly. The only thing that does help is uninstalling the app and re-installing it again, but even after that the app only works until you log in.
Steps to reproduce

Download version 2.6.0 from the F-Droid store
Open the app and log in with a Commons account

Expected behaviour
The app should work / not crash / be able to be opened again
Actual behaviour
The app crashes / can't be opened
Device name
Nokia (HMD) 3.4
Android version
Android 12 (stock version, but with Lawnchair launcher installed and in use)
Commons app version
2.6.0 (newest one)
Device logs
No response
Screen-shots

Screenshot's text translates roughly to "Commons is being closed repeatedly.", buttons are "Warren" ("wait") and "App schließen" ("close app")
Would you like to work on the issue?
Prefer not

I've got something wrong, the buttons on the screenshot are "App-Informationen" ("app information") and "App schließen" ("close app")

Sorry for the inconvenience!
Would you mind uninstalling and reinstalling the app?

Download version 2.6.0 from the F-Droid store

@Animyos Sorry about that but the version of the app in F-droid is pretty old. [side note: It's so old it only targetted Android 7.1. It's a bit surprising the app even shows you the login screen on Android 12!] The reason the F-droid version if pretty old is due to #4994
Would you able to download and use the latest version (v4.0.5) of the app from play store?

@sivaraam Yes, I’ve already done that and can confirm that the issue doesn’t happen with the newest version from PlayStore. Thanks for replying!


Use 2 pom file to handle different version of Spring Cloud Azure: 4.x and 6.x

Purpose

As title. To support samples for different version of Spring Cloud Azure libraries. We use 2 root poms: azure-spring-boot-samples-4.x-pom.xml and azure-spring-boot-samples-6.x-pom.xml.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Hi, @fangjian0423 .
Please help to review this PR when you have time.

Please ignore the failure of Markdown Links Check. The failure is not caused by this PR.


[IOTDB-1234] fix ImportCsv tool cannot parse empty string

thanks for contribution!

Hi, though the PR is merged, it left one thing...
You'd better add a Test for the case.


TypeError: Failed to fetch

`import './App.css';
export default class ItemLister extends React.Component {
constructor() {
super();
this.state = { items: [] };
}
componentDidMount() {
    fetch('https://www.getpostman.com/collections/1d8df8b0b5bf27e5009b').then(result=> {
          console.log(result.json());
          this.setState({items:result.json()});
    }).catch(err => {
       console.log(err);
       this.setState({ items:[] });
    });
}

render() {
    return(

Items:

 { JSON.stringify(this.state.items)}

    );
}

}`
error-
Fetch API cannot load https://www.getpostman.com/collections/1d8df8b0b5bf27e5009b. The 'Access-Control-Allow-Origin' header has a value 'https://www.getpostman.com' that is not equal to the supplied origin. Origin 'http://localhost:3000' is therefore not allowed access. Have the server send the header with a valid value, or, if an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.
bundle.js:18335 TypeError: Failed to fetch

Explain, I am reading React in here.


Refactor catalog fetching into service

rancher/rancher#5554

Tests failing.. also all the other services are in app/services/ instead of pods


Example code not working

Link for Repo Example
p = (DataFrame({'raw': sdf.x,
                        'smooth': sdf.x.rolling('100ms').mean(),
                        'very-smooth': sdf.x.rolling('500ms').mean()})
     .plot(width=700)
    )

yields
AttributeError: DataFrame has no attribute 'plot'

Same for me. I would actually vote to either remove this notebook as it does not add a lot of benefits compared to the quite good documentation or to add more content to it.

But it is nice :) So I fixed it instead.

I just tested this any the hvplot seems to not be working again.

What versions do you have, and what do you see?

I have jupyterlab 2.2.6, 'hvplot 0.6.0' and, bokeh 2.2
I just see an empty plot as mentioned:

@silvavn I tried your code as in screenshot hvplot seems to works.

@silvavn I tried your code it seems to work fine with master branch.


[docs] Document how to use the dynamic ASan runtime

Show how to use ASan when using the Python bindings for example.

Ughhhhh looks like my suggested edit used my AMD email which is for some reason not under the CLA. You might want to just switch those commits to only be authored by you.

Ughhhhh looks like my suggested edit used my AMD email which is for some reason not under the CLA. You might want to just switch those commits to only be authored by you.

I force pushed a fix.

Thank you for your reviews. I sqush and rebased to resolve the conflicts.


Decide fate of data_pipeline/mrtarget/resources/evidences_sources.txt

When running the data_pipeline --val step, one can either list all data files or provide no files at all and then all files listed in data_pipeline/mrtarget/resources/evidences_sources.txt will be processed. We should look at whether we want to keep this file and if so, it should get updated for each release.

After discussion, we think the best idea would be to remove this file from the git repository. We want users to explicitly point to different sources, so they know exactly what they are using (and they can tell us that if they need to).
Instead, we will create a combined evidence & annotation sources file per release in a google bucket. This per release combined sources file can then be referenced from e.g. blog posts, and should help be more reproducible. In future, other files or urls can be added to the same sources file in future releases (e.g. specific ontology versions, api call outputs, etc).


M code for tables is missing

I use ALM toolkit to inspect and compare data model for Power BI desktop models. It is great it includes the M expressions for different sources as objects. However, I find that this only works for tables that are not actually loaded into the dataset. If they are, I only get the definition of the data table, but I do not get the M expression of the same name, that is used to upload the table to the database. This is a shame, because this way part of the code is excluded from the comparison.

Hi Jeroen, can you check the partition query for the tables? That's where the M expressions for tables are stored in the AS metadata. You may need to ensure the "Consider query partitions when comparing tables" option is checked.

Hi Christian, this option was indeed unchecked. I checked it and it is now working as expected. Thanks a lot!

Good to hear!


Fix linear-meter margins

@m6jones FYI, this is what I think the margins should be (at least for our use-case). Feel free to approve this, use it as a template, or close it.

Before you merge actually, would you be able to change the margin and height values to rem units.

Should we have been expecting the perceptual diff tests to need updating?

Yes, we will need to regenerate the golden and the screenshots for the readme.

I think it skipped the visual-diff and ran the headless unit tests (as opposed to running Sauce since there are not secure keys (coming from a fork).

What can I/we do to get this merged?

I made a draft PR from a branch https://github.com/BrightspaceUI/core/pull/115
This will let us run the tests and make some goldens.


protodelim.UnmarshalOptions should support specifying a reusable buffer

Is your feature request related to a problem? Please describe.
protodelim.UnmarshalOptions.UnmarshalFrom creates a new buffer for every message that it parses. When unmarshalling many messages, this allocates a bunch of memory and costs CPU time.
Describe the solution you'd like
Allow the user to specify a reusable buffer in UnmarshalOptions. Specifically, add a Buffer field to UnmarshalOptions. If it is non-nil, attempt to use that buffer instead of creating a new one. If it's too small, allocate a bigger buffer and place it into Buffer.
Describe alternatives you've considered
protodelim.UnmarshalOptions could have an un-exported buffer field, which it always tried to reuse. This would have similar performance benefits, but it wouldn't allow the user to presize the buffer to handle their data size.
UnmarshalOptions.UnmarshalFrom could reuse the buffer even when the user didn't specify one. This would be a regression for users who care more about peak memory than CPU usage and have many live UnmarshalOptions.
Additional context
I have code which currently handrolls a version of protodelim with a reusable buffer. I would like to simplify our code by switching to using protodelim, but as is, our benchmarks are 5% slower because of allocating a new buffer for every message. Implementing the changes I suggested above makes protodelim perform as well as our existing code.

FYI: I have this implemented, and will send it for review soon.

I've created https://go-review.git.corp.google.com/c/protobuf/+/491596, but given that this is my first time using Git and Gerrit, I'm not sure if I've done everything right.

This was fixed by https://go-review.git.corp.google.com/c/protobuf/+/491596. However, instead of allowing the user to directly specify a buffer, if they pass in a bufio.Reader, we try to use the buffer from the reader.


LoadError****

LoadError****
Originally posted by @ab-ood44 in https://github.com/bossm0n5t3r/simultaneous-viewing-limit-system/pull/1#issuecomment-790315597

[x] -


As customer admin of non default IDP, cannot assign roles to new users

Date:2016/10/23 (multiple IDPs)
[Steps to reproduce]

IDPs IDP1(used as default), and IDP2 exist
customer org is assigned to IDP2
as customer org admin register new user and assign administrator or subscription manager

[Expected result]
user is created and has correct role
[Observed result]
error is displayed "You are not allowed to perform this operation."
[Details]
The user is actually created but the role assignment fails.
This makes me believe that the unit tests (all) should be also executed not only for default tenant but also for another tenant other than default.

The reason is the same as for #400, with different effect. So I will mark this issue as duplicate to #400.

[Build] 16.1 fix2 verified


[Feature Request] Sending modals confirm button update

Overview
Recommended by Product and Willy
Currently, users sending a TX with anything besides native are given multiple types of messages after clicking confirm.

After pressing Confirm when sending a TX, you are given a message that says "Broadcasting Transaction" with a spinner. A user with KK would have no idea what to do next (accepting by pressing the button on their keepkey). If a users metamask didn't open up, some new users might not know what to do next.
The suggested fix is that all sending buttons (defi, sending, trading, atom modals) after pressing confirm the button should be pulling data on what wallet the users is using and say "Confirm on [Wallet]" inside the button before moving to the next page.

References and additional details
https://discord.com/channels/554694662431178782/988892734133768192/988892737929617488
Acceptance Criteria
When a user confirms a tx in app.shapeshift.com, if a confirmation on the wallet is required (every wallet besides native) display a pending state in the CTA "Confirm on [wallet]" (ie. "Confirm on KeepKey) until they have confirmed the transaction
Need By Date
No response
Screenshots/Mockups
No response
Estimated effort
No response

Wallet info can be pulled for the current connected wallet by using useWallet().wallet / useWallet().walletInfo.
Each hdwallet has an helper to keep the checks declarative:

isNative
isMetaMask

From a functional perspective, this means that <Confirm /> and <ClaimStatus /> component will need to handle one additional step of showing a confirm state (if not on native), until the confirm actually happened.

closing as stale/low priority


update to new storage account

There is another reference to https://vstscli.blob.core.windows.net in packaged_releases/windows/scripts/build_local.cmd.

There is another reference to https://vstscli.blob.core.windows.net in packaged_releases/windows/scripts/build_local.cmd.

can't find. the other one is vstscli.azurewebsites...
we are evaluating if that also needs to move or not


feat: Particle example

This is a fairly simple particle example.
This also adds an extension to be able to add the particle render stage to the graphics compositor.

This was also on my ToDo so we can enjoy particles. Thanks for being a step ahead! 🙂


igTextEditor model updated when clicked outside of Editor

Hello Team,
I have used the igTextEditor Component in my angular 2 application. I have found that it didn't update model value while changing text inside Text Editor rather it change when clicked outside of Editor.
We would expect to have similar model binding with text editor as in normal HTML Input text control. It should update model value as in real time we try to change the value.
Can you please have a look into this problem? Refer: Forum Post
Thank you for the wonderful work. Appreciate!
Warm Regards,
Jeetendra

Hello Jeetendra,
While the Ignite UI Editors are intended to be used in place of the default HTML input, they do function differently - due to additional features like max length, excluded characters or limiting to list options, revert if not valid (and then some for more complex editors) the actual value of the control is not updated immediately - that happens on either blur (as you saw) or enter.
Would be fairly easy to allow the Text Editor to update value immediately via the textChanged event (kind of like in Knockout). @bazal4o - thoughts?
Could also force-update the numeric editors, but there's no "immediate" setting here so it'd be a bit of a change of how those behave. Mask and date partial values are pretty much useless and would really not got for instant updates on those.

Damyan

Yes we can add this functionality only for igTextEditor.

@jkumawat Could you test whether the enhancement is what you expect as functionality?

Closing the issue because there has been no feedback for 13 days. I assume the fix resolves the issue.


PEAR-1360 - New Cohort workflow based on max of 1 unsaved cohort

Description
Checklist

[x] Added proper unit tests
[x] Left proper TODO messages for any remaining tasks
[x] Scanned for web accessibility with aXe, and mitigated or documented
flagged issues

Screenshots/Screen Recordings (if Appropriate)

Looking good.
Issues

for uploading/importing the cohort (upload button on cohort bar), after clicking Save in the save cohort modal, the Import A New Cohort modal is still displayed. The Import...modal should be dismissed (just like current behaviour).

Looks like there's one location where cohorts should be saved and they are not: the 2nd and 3rd options in the Save New Cohort dropdown above the cases table and the cDAVE table. (The first option works as expected though.)

you'll need to update the title of the modals to where you pick existing cohorts as well to "Save New Cohort..."
and also show the Save Cohort modal instead of the Create Cohort one

Loving the little spinners on the buttons with +. So cute.

Issues 1-2 look good.
New(?) Issues

Not sure if it's related to this branch or surfaces more due to changes here. I can file a separate ticket too. The spinner on the case counts in the cohort bar doesn't seem to go away after saving and switching to the new saved cohort. Steps:

start with some cohort that has >0 cases; doesn't matter if it's saved or unsaved
Cohort Bar > cases table. select some cases and use one of the options in Save New Cohort.
save the cohort, then switch to it using the notification
the spinner  on the cohort bar's case counts doesn't seem to ever go away; likewise the spinner on the files count in the expanded cohort bar.
if you refresh the tab, the counts will show up.

Mutation Frequency > the buttons in the genes and mutations tables no longer work to create/save cohorts. :(

Hi @wteouchicago,

Yeah, I'm think this is probably an existing/separate issue.
Fixed

I'll file a separate ticket for 3.
4 looks good.
all good 👍

Changed ProteinPaint and OncoMatrix create cohort to use SaveCohort

Changed ProteinPaint and OncoMatrix create cohort to use SaveCohort

@craigrbarnes Thanks for the updates and fixing the tests, I'll try to review tonight or by tomorrow morning.

spinner issue is fixed. 👍  I'll close the separate jira I filed.

@craigrbarnes I tested with qa-pink and qa-uat VPNs, and also without using the VPN, and I always see the following issues regardless:

I'm getting a "There was a problem saving the cohort" in both the PP and OncoMatrix tools. This network error coincides with the error popup:

Also, the spinners are always spinning for me, the case counts does not seem to finish loading to get displayed.

If it's urgent to merge these PR, it's okay to have the PP/OM tools to be temporarily broken, I can work on PP-specific issues on a separate branch.

Hi @siosonel -- I think saving cohorts require that you are running these steps: https://github.com/NCI-GDC/gdc-frontend-framework#running-auth-in-localhost-login-and-other-auth-related-actions
When Chrome gives you the error about the cert, type thisisunsafe - https://jasonmurray.org/posts/2021/thisisunsafe/

@wteouchicago I was running using ssl-proxy, using a local https URL, in Chrome and the cohort creation (using CreateCohortModal) worked without having to disable CORS restrictions. But this same setup is not working for in this branch.
I also tried with Safari with disabled CORS and I still get the "There was a problem saving the cohort" error. My experience is that the full ssl + disabled CORS setup is only needed for features that require a user to be logged-in (such as Sequence Read), and not required for features like cohort creation that use public data.
I'll troubleshoot a bit more later today.

@wteouchicago I was running using ssl-proxy, using localhost.gdc.cancer.gov as hostname, in Chrome and the cohort creation (using CreateCohortModal) worked without having to disable CORS restrictions. But this same setup is not working for cohort creation in this branch.
I also tried with Safari with disabled CORS and I still get the "There was a problem saving the cohort" error. My experience is that the full ssl + disabled CORS setup is only needed for features that require a user to be logged-in (such as Sequence Read), and not required for features like cohort creation that use public data.
I'll troubleshoot a bit more later today.

I will also look into this. I would prefer to merge this PR without having to break PP/OM.

@siosonel I do not see those errors; however, can you create a cohort from the project page and see if you get the same issue?

@craigrbarnes I got the same error from the project page, so the issue must be related to my dev setup, and not specific to the SaveCohortModal or PP/OM tools. The issue is likely related to not using the correct GDC API URL, api.gdc.cancer.gov versus https://portal.gdc.cancer.gov/auth/v0, plus maybe incorrect VPN? I tried the portal v0 API while on qa-pink VPN, and even but I get a Not Found Error. I even tried changing to NEXT_PUBLIC_GDC_API=https://portal.gdc.cancer.gov/auth/v0 in .env.development. I'll keep looking into it.
Additional details:
In Safari (with the Disable CORS restrictions), the error for the same https://portal.gdc.cancer.gov/auth/v0/cohorts?include_case_ids=true endpoint is
<!doctype html>

  <title>Not Found</title>

Not Found

The requested resource was not found on this server.

@craigrbarnes It's likely that the /cohorts?include_case_ids=true endpoint error is unrelated to the save cohort issue that I'm seeing. In https://portal.gdc.cancer.gov/v2/analysis_page?app=OncoMatrix while on qa-pink VPN, I'm still able to create a cohort even while seeing that /cohorts error.
I'll try to trace what triggers the "There was a problem saving the cohort" message in the GFF code.

@siosonel can you try with an incognito browser? Sometimes that error can happen if the context_id in your browser cannot be found on the backend.

@siosonel can you try with an incognito browser? Sometimes that error can happen if the context_id in your browser cannot be found on the backend.

@wteouchicago Thanks, that fixed the errors! Verified to work in incognito mode for both Chrome and Safari. I'll approve the PR for now, but later there should not be an error even when not using incognito mode, most users will not be using that browser mode.

@siosonel oh good that it worked! Craig/Phil will know this better, but I think part of the issue is that we are switching environments (e.g. qa-uat, qa-pink) and a context_id stored when on one environment will not be available on another. Regular portal users shouldn't run into this situation.


[Reserved instances] Added new products to enum ReservedResourceType

The reserved instances team has onboarded new products. This change reflects the addition.

Kindly ping @aditink

It looks like I have to make updates to RestAPI specs repo first; will open a new pull request after doing so.
Thanks!


Replace welcome email with welcome message

Update the system so that it no longer sends out a welcome email to prevent SES email bounces. Replace it with a welcome message that the user will see when they first visit the dashboard page after initial account creation.

welcome email is disabled and the current dashboard message is plenty. but it would be better if you can remove the blue bar and message that says "No records associated" (screenshot below). i don't think these appeared before..?


Add edge when mouse up anywhere on node

Two nodes. I try to add an edge by mouse down on a connector point. I want to finish the add with a mouse up anywhere on the second node. In the demo, it only works when I mouse up over the second node's connection point.

You could try to make the source handle the same size as the node by default and then show the target handle when a user starts a connection. I am not 100% sure if this would work.. It's just an idea.


Port Java builder code from Apollo Android

Ports Java compiler builder code from Apollo Android.
Resolves #4312

@dwbutler: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Closing as it was merged with https://github.com/apollographql/apollo-kotlin/pull/4364. Thanks again!


Does this support deserialization ( IE use Option types for an API )?

I'd like to use these Option types in an API, IE currently an interface might be:
interface Person {
  name: string;
  display_name?: string // I'd like this to be display_name: Option<string>;
  ...
}

@dessalines

Does this support deserialization ( IE use Option types for an API )?

Yes. PlainResult &  PlainOption will be JSON directly.
For deprecated API, we need to be careful:

ClassicOption has toJSON
ClassicResult does not support it (and we will not add the support). So it will expose the internal structure directly if you do JSON.stringfiy(classicResultInstance).

If you would like to use other JSON serialization, you can write custom toJSON() to your objects:

If the value has a toJSON() method, it's responsible to define what data will be serialized.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/stringify

Okay thank you!


Add a new script to reshard model parallel parts

Summary of Changes
The existing script for resharding model parallel parts (i.e. metaseq/scripts/reshard_model_parallel.py) loads all checkpoint parts at once and might result in OOM issues under RAM constraints, especially for very large models. Here, we rewrite the script and optimize for memory usage by first allocating an unsharded model state dict and iteratively merging model parallel parts into it.
Previously, peak memory usage was close to 2X model size as we needed hold input and output state dicts, but now it's closer to 1x mode size thanks to the iterative process theoretically.
The new script produces the same output as metaseq/scripts/reshard_model_parallel.py. We delete it to avoid duplication and note that the old script still remains accessible in the internal repo (see this script).
Test Plan

Run the script with an OPT 2.7B checkpoint to reshard 4 MP parts into 8 MP parts and make sure the resulting checkpoint performs reasonably:seq 0 3 | parallel --line-buffer 'python metaseq/scripts/reshard_fsdp.py --input "/data/checkpoints/opt-2.7b/raw/checkpoint_last-model_part-{}-shard*.pt" --output "/data/checkpoints/opt-2.7b/reshard-no-os/reshard-model_part-{}.pt" --skip-optimizer-state True --unflatten-weights True --output-dtype fp16'
python -m metaseq.scripts.reshard_mp --input "/data/checkpoints/opt-2.7b/reshard_no_os/reshard-model_part-*.pt" --output "/data/checkpoints/opt-2.7b/reshard_no_os_mp8/reshard-model_part-{i}.pt" --num-output-parts 8

python metaseq/scripts/interactive.py --merges-filename /data/checkpoints/gpt2-merges.txt --vocab-filename /data/checkpoints/gpt2-vocab.json --path /data/checkpoints/opt-2.7b/reshard_no_os_mp8/reshard.pt --model-parallel-size 8 --distributed-world-size 8  --beam 3 --max-source-positions 4 --max-target-positions 128

> Prompt: What is the meaning of life?
Output: To be happy.

We compare performance with metaseq/scripts/reshard_model_parallel.py while resharding an OPT-175B checkpoint from 8 MP parts into 16 MP parts. The old script takes 849.40 seconds and results in a peak RSS delta of 668,301 MB while the new script takes 891.65 seconds and has RSS delta of 458,185 MB (a 46% reduction in RAM usage).python metaseq/scripts/reshard_model_parallel.py --pth_prefix /data/checkpoints/opt-175b/reshard_no_os_unflat/reshard.pt --new-model-parts 16 --save-prefix  /data/checkpoints/opt-175b/reshard_no_os_unflat_mp16_ref/reshard.pt
python -m metaseq.scripts.reshard_mp --input "/data/checkpoints/opt-175b/reshard_no_os_unflat/reshard-model_part-*.pt" --output "/data/checkpoints/opt-175b/reshard_no_os_unflat_mp16/reshard-model_part-{i}.pt" --num-output-parts 16

Is it possible to run $ git mv so that the new script becomes a second version of the original one? Makes it easier to review.
Also lint failed, maybe run black?

Is it possible to run $ git mv so that the new script becomes a second version of the original one? Makes it easier to review.
Also lint failed, maybe run black?

Thank you for the review. I did use git mv but it didn't trigger the comparison of file contents (perhaps they are too different). Please see updated PR for the linter fix.


Correct install_relocatable issues found by libcudf

Description
https://github.com/rapidsai/cudf/pull/13513 found 2 issues in the install_relocatable logic that caused LD_PRELOAD setup to fail. This PR corrects those two issues:

The ENVIRONMENT value always needs to be quoted to properly support multiple variables to be set
We need to scan for all cmake_install.cmake starting from the root build directory

Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.
[x] The cmake-format.json is up to date with these changes.

/merge


"An error occurred after trying to install this update:" after installing 0.59

Microsoft PowerToys version
0.59
Running as admin

[X] Yes

Area(s) with issue?
General
Steps to reproduce
I just updated to 0.59 successfully (or so it seems), but on the General pane I have this persistent error message.

Steps to repro:

Update to 0.59 from 0.58 from inside PowerToys
PowerToys restarts
General pane should be normal, show no errors

✔ Expected Behavior
General pane should show no errors.
❌ Actual Behavior
See above.
Other Software
Too many to list, like I said functionally it seems like the update went fine.

Interesting, can you please send a /bugreport ?

@jaimecbernardo Ah, my bad here's the zip!
PowerToysReport_2022-06-07-14-38-59.zip

Your update log seem to be reporting "[2022-06-07 13:42:33.127557] [p-11236] [t-43588] [error] Invoked with -update_now argument, but update state was invalid"
This seems to be correct, since you already updated to 0.59.0.
Maybe this message will stop showing up by itself after restarting the system?

@ksbrar could you please remove %localappdata%\microsoft\powertoys\UpdateState.json, restart PowerToys and try checking for updates again?

@yuyoyuppe That worked, thanks!

@ksbrar could you please remove %localappdata%\microsoft\powertoys\UpdateState.json, restart PowerToys and try checking for updates again?

Unfortunately, your advice didn't help me. But I've found another solution, that worked for me:
I've executed file %localappdata%\microsoft\powertoys\Updates\powertoyssetup-0.59.0-x64.exe manually*, and everything worked fine!

*The file mentioned above is downloaded automatically when you klick Check for updates button.


How to disable clang warnings?

Sorry if this is a silly question, but looking through the settings, I don't see a place to disable certain warnings.
I am writing in C++11 and would like to disable the -Wc++11-extensions warning. How do I do that if it is possible?

Apologies, this is probably my fault (clang-flags author, the package atom-lint uses to read .clang_complete files, and compdb files to work out per-file clang flags). I didn't keep it sufficiently up to date with Atom changes, and I think that's why it was disabled. Trunk now works again, and I'll look to make a new release of the package with the fixes in when I have a chance.

Hi @Kev - no worries! Thanks for dropping by with an update.
I appreciate it's likely the package is maintained in your free time so I'd say there's nothing to apologise, we just need thank you for it's mere existence. Then again, if you are paid, apology accepted, but the thanks still stands ;-)

For what it's worth, I made a new release of clang-flags a few weeks ago. So it could presumably be re-enabled now. I'll try to sort out a PR when I have some spare minutes (I don't have many, so probably not for a while) to re-enable it in atom-lint, if no-one gets there before me.


Initial changes for scatter plot capability.

Please note that this PR is intended for discussion only.  It will not pass pylint or pytest, and won't be merged.
  I was finally successful in getting the plot to come out with adjusted sizes for the dots.  I realized that the values themselves were being used to scale the size, with the help of a default algorithm.  These are adjusted by adjusting the values in the array in the _plot_field function.  For some reason, I can only get the scatter function to accept named Matplotlib colors.  I matched them as closely as I could to the actual colormap.
Here's an example:

@Brian-Jamison Should we close this one since you've opened #171?

Reopened as PR #171


Programming exercises: Fix Long Manual Feedback not beeing displayed

Checklist
General

[x] I tested all changes and their related features with all corresponding user types on a test server.
[x] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

[x] Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
[x] I strictly followed the principle of data economy for all database calls.
[x] I strictly followed the server coding and design guidelines.
[x] I added multiple integration tests (Spring) related to the features (with a high test coverage).
[x] I added pre-authorization annotations according to the guidelines and checked the course groups for all new REST Calls (security).
[x] I documented the Java code using JavaDoc style.

Client

[x] Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
[x] I strictly followed the principle of data economy for all client-server REST calls.
[x] I strictly followed the client coding and design guidelines.
[x] Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
[x] I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
[x] I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
[x] I documented the TypeScript code using JSDoc style.
[x] I added multiple screenshots/screencasts of my UI changes.
[x] I translated all newly inserted strings into English and German.

Changes affecting Programming Exercises

[x] High priority: I tested all changes and their related features with all corresponding user types on a test server configured with the integrated lifecycle setup (LocalVC and LocalCI).
[x] I tested all changes and their related features with all corresponding user types on a test server configured with Gitlab and Jenkins.

Motivation and Context

Fixes #9434
This is a fix which adresses following issue where long feedback was not beeing loaded properly from the server.
This is most probably either caused by the result beeing damaged or not saved properly or the feedback beeing overwritten. To tackle the second mentioned potential reason following was done (described in Description).
Additionally another bug was fixed where instructors were not able to edit long feedback in manual assessements.
Description

I refactored the method which handles saving the long feedback when its created and when a long feedback is edited then the whole feedback is loaded to avoid that instructors override the long feedback with the short feedback which is loaded per default. The BaseAPIHTTPService on the client side was adjusted to also accept text responses from the server, making the rest call look very easy to understandable.
Note: The saving of manual assesements for programming exercise needs further refactoring but this is not part of this PR!
Steps for Testing

Prerequisites:

1 Instructor
1 Student
1 Programming Exercise

Log in to Artemis as Instructor
Create a Programming Exercise
Log in as Student and participate in the Programming Exercise
Log in as Instructor and set the Due Date to now and set Manual Assesement
Navigate to the Programming Exercise and press the View button in the TutorActions tab
Press the Assesement Dashboard button
Assess the Student Sumbission by creating a new Feedback with over 1000 characters
Save this and reload the page
Verify that the feedback box now displays the whole long feedback and no shortend version
Try to edit the long feedback and save again
Verify that the long feedback was changed
Do this for Modelling and Quiz and Text Exercises aswell

Testserver States

[!NOTE]
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress

Performance Review

[ ] I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance even for very large courses with more than 2000 students.
[ ] I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance even for very large courses with more than 2000 students.

Code Review

[ ] Code Review 1
[ ] Code Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Performance Tests

[ ] Test 1
[ ] Test 2

Screenshots

Before:

After:

Summary by CodeRabbit
Summary by CodeRabbit
Release Notes

New Features

Introduced handling for long feedback texts across various assessment services.
Added conditional rendering for feedback components based on the presence of valid assessment results.
Enhanced FeedbackService to fetch long feedback text dynamically.
Implemented new input properties for components to receive result identifiers, improving feedback detail processing.

Bug Fixes

Enhanced feedback management to prevent duplicates during assessments.

Documentation

Updated comments for clarity in the BaseApiHttpService.

Tests

Improved test coverage for FeedbackService with Angular's testing utilities and HTTP request mocking.

@Malekos74 Making the size of the box adjustable to the feedback text would be part of a refactor and not bugfix. will be considered as i agree that its weird in its current situation.

@flbrgit I hope the issue is resolved now :)


Create a new example that will run full ADF package (not from notebook)

This example can be generalized to other outside diagnostic packages as well (e.g. ILAMB). The goal is to have the JupyterBook-generated web site link to the ADF website from the side bar.
All Submissions:

[x] Have you followed the guidelines in our Contributor's Guide (including the pre-commit check)?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change? Other pull requests that create the same changes do not exist; however, this is dependent upon #142

New Feature Submissions:

[ ] Does your submission pass tests?
[x] Have you lint your code locally prior to submission?

Changes to Core Features:

[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you successfully tested your changes locally?

The last thing we have to do here is to add a flag if ADF exists in build.py

We should also add documentation on how to run ADF until #105 is resolved

We may want to remove the dependency on CESM (rather than just CUPiD and ADF)-- see note in #142.

This runs for me with
$ cd ${CESM_ROOT}/tools/CUPiD/helper_scripts
$ ./generate_adf_config_file.py --cesm-root ${CESM_ROOT} --cupid-example external_diag_packages --adf-template ../externals/ADF/config_amwg_default_plots.yaml --out-file adf_config.yml
$ conda activate cupid-analysis
$ ../externals/ADF/run_adf_diag adf_config.yml # TOOK 75 seconds
$ cd ../examples/external_diag_packages/
$ conda activate cupid-dev
$ cupid-run
$ cupid-build

(assumes cupid-dev was points to ${CESM_ROOT}/tools/CUPiD/cupid`)


Add templates for gz tar and zip

Tested locally and appears to be working.

Do you think it would be better to put these in the data/classes directory under Compression.template?

That works for me.  I will re-do with with a compression branch and include more compression and archive file types.  I suppose if someone want to exclude one type they will want to exclude them all.  Thanks for the suggestion.

Closing to open new pull request.


the problem about Escape Installation

hello, I would like to do some research on the Escape platform, but after I install it on my desktop as illustrated on the web https://sb.tmit.bme.hu/escape/, I meet some problems
When I input the code" ./escape.py -df -s examples/escape-mn-req.nffg ", it shows as below:
[D][boot                   ] Not launching of_01
[D][core                   ] ESCAPEv2 going up...
[D][core                   ] Running on CPython (2.7.13/Oct 30 2017 14:22:29)
[D][core                   ] Platform is Linux-4.10.0-37-generic-x86_64-with-debian-stretch-sid
Traceback (most recent call last):
File "/home/renwei/escape/pox/pox/boot.py", line 536, in boot
core.goUp()
File "/home/renwei/escape/pox/pox/core.py", line 375, in goUp
self.raiseEvent(GoingUpEvent())
File "/home/renwei/escape/pox/pox/lib/revent/revent.py", line 291, in raiseEvent
rv = event._invoke(handler, *args, **kw)
File "/home/renwei/escape/pox/pox/lib/revent/revent.py", line 166, in _invoke
return handler(self, *args, **kw)
File "/home/renwei/escape/pox/ext/ESCAPE.py", line 47, in _start_components
from infrastructure import launch
File "/home/renwei/escape/escape/infrastructure.py", line 24, in
from escape.infr.il_API import InfrastructureLayerAPI
File "/home/renwei/escape/escape/escape/infr/il_API.py", line 19, in
from escape.infr.topology import ESCAPENetworkBuilder
File "/home/renwei/escape/escape/escape/infr/topology.py", line 24, in
from mininet.node import RemoteController, RemoteSwitch
ImportError: cannot import name RemoteSwitch

Issue is fixed in commit: bd62de21029507d771d88cec9750ddc2dda1935a


Path error when downloading reddit data

Hi, thanks for the great work. When downloading  reddit data by "python demo.py --data small", it shows:
...
zcat: can't stat: data/out/train/conv/2009-11.tsv.gz (data/out/train/conv/2009-11.tsv.gz.Z): No such file or directory
zcat: can't stat: data/out/train/conv/2009-12.tsv.gz (data/out/train/conv/2009-12.tsv.gz.Z): No such file or directory
zcat: can't stat: data/out/train.tsv.gz (data/out/train.tsv.gz.Z): No such file or directory
error occurred, b"gzip: can't stat: ./train.tsv.gz (./train.tsv.gz.gz): No such file or directory\n"
Can you help fix the problem? Seems like it relates to line 67 of demo.py. Maybe we should  delete "cd .."?

Hey. I am getting the same error. I want to download the data DialoGPT was trained on. Any advice how to do this without docker?


Filter activity by date

in the new explorer, allow users to filter transactions by date. as it is right now, it's a long list.

@danielcolinjames, I would love to work on it.


Provide ARM support

Build container images for the architecture arm64

The multi-arch support will provided by #377


ActiveRecord::Base.clear_active_connections! is deprecated in current edge Rails 7.1

No rush, but eventually we'll want to deal with this, combustion is triggering deprecation warning in current edge Rails 7.1

DEPRECATION WARNING: Calling ActiveRecord::Base.clear_active_connections! is deprecated. Please call the method directly on the connection handler; for example: ActiveRecord::Base.connection_handler.clear_active_connections!. (called from reset at combustion-8916f6bec7f1/lib/combustion/databases/postgresql.rb:5)

Just resolved this with c1bc7dadc498c970cc24f4630dda6fe4add3e6aa - and then removed MRI 2.4 and 2.5 from the test matrix, and added in 3.2 :)


anyone got an tool for user:pass to cookie?

drop a link if u have one lol (open source)

this is impossible lol without a captcha solver or 2captcha

this is impossible lol without a captcha solver or 2captcha

I got an solver

this is impossible lol without a captcha solver or 2captcha

I got an solver

give me pls


Is TimeDistributed redundant?

Please make sure that the boxes below are checked before you submit your issue. If your issue is an implementation question, please ask your question on StackOverflow or join the Keras Slack channel and ask there instead of filing a GitHub issue.
Thank you!

[x] Check that you are up-to-date with the master branch of Keras. You can update with:
pip install git+git://github.com/keras-team/keras.git --upgrade --no-deps

[x] If running on TensorFlow, check that you are up-to-date with the latest version. The installation instructions can be found here.

[x] If running on Theano, check that you are up-to-date with the master branch of Theano. You can update with:
pip install git+git://github.com/Theano/Theano.git --upgrade --no-deps

[x] Provide a link to a GitHub Gist of a Python script that can reproduce your issue (or just copy the script here if it is short).

I have attempted to rework the Climate prediction example by Chollet in his book, Deep Learning with Python. Instead of simply predicting 1 variable 24 hours in the future (i.e. delay of 144 timesteps), I want to predict a sequence of 720 timesteps, 144 timesteps  in the future. That is I want 5 days hours worth of predictions, 24 hours from now.
My many-to-many model is as follows:

1 hidden GRU layer of 16 units with return_sequences=True. Input to LSTM is (None, 720, 14). i.e. timesteps is 720 and dimensions is 14. return_sequences=true for GRU layer so output of this layer is (None,720,16) as expected.

Output layer is simply a Dense layer of 1 neuron which outputs a shape (None, 720, 1)

I have notices regardless of whether I use regular Dense (1) layer or a TimeDistributed(Dense(1)) layer as the output, the loss and predictions are exactly the same. Also, the output shape from the Dense layer is (None, 720, 1) regardless of whether I use TimeDistributed(Dense(1)) or regular Dense(1).
My questions is if this is expected and if so, in which scenario should I expect to use the  TimeDistributed functionality?
My code can be found here: https://github.com/tinkermachine/chollet/blob/master/Climate/Climate 2.py


Add another Fedora VM with cgroups v2 enabled

Depends on #3632

/cc @giuseppe getting started on this, just in case.  I think I touched all the right places for a new VM image, but we'll see soon enough :smile: ...

/approve

@giuseppe so as you saw, there's no built-in way to safely reboot during testing.  Though a newly added unrelated feature, does support this possibility in "future Cirrus-CI".  For now, we'll have to add a snowflake VM image, which this PR should do.
What were you thinking about for testing, should it execute the regular integration tests for now?  Either way, I need to update this comment.

What were you thinking about for testing, should it execute the regular integration tests for now? Either way, I need to update this comment.

I was thinking of running the e2e tests using crun instead of runc

I was thinking of running the e2e tests using crun instead of runc

Ahh okay, not sure what that is, but IIRC we can affect that by exporting $RUNC_BINARY.  While I'm messing with adding a new cache-image anyway, how do I make "crun" available?

@giuseppe PTAL.  Assuming tests pass as they did earlier, I'm going to leave the rest to you.  There's spot for runtime tweaks in contrib/cirrus/integration_test.yml.  If you need anything else cached in the VM image, take a look at the xfedora section at the end of contrib/cirrus/packer/fedora_setup.sh.  If you get stuck, just let me know.

@cevich is special_testing_cgroupv2 running on cgroupv2?  How are tests passing there? :-)

@giuseppe yes it should be, at least it's running the intended VM image with modified kernel options.  I didn't do anything special for the tests, were you expecting they should fail?
I will check the VM image, and confirm the kernel option is still set...

yes, there is no support for cgroup v2 in runc so I'd expect them to fail.

@giuseppe okay thanks, I added a image-verification test, and am re-building images.  Let's see if it fails...

...yep, and I found the problem as well (missing sudo to grubby command).

[Okay, this looks like the expected breakage]([+1740s] FAIL! -- 261 Passed | 417 Failed | 1 Flaked | 0 Pending | 22 Skipped) and the image check test I added gives me more confidence as well:
[+0001s] Checking items specific to xfedora-30-libpod-4703143915421696
[+0001s] Kernel Command-line: BOOT_IMAGE=(hd0,msdos1)/boot/vmlinuz-5.1.20-300.fc30.x86_64 root=UUID=ea711a29-e460-4879-9d70-9da99ae021f9 ro no_timer_check net.ifnames=0 console=tty1 console=ttyS0,115200n8 systemd.unified_cgroup_hierarchy=1
[+0001s] ok On xfedora-30 images, the /sys/fs/cgroup/unified directory does NOT exist
[+0001s] Total failed tests: 0

@giuseppe I'll squash all this new stuff up again, and comment out the line that actually executes the tests, so you can do what you like as far as what's needed to get them working.  This will all still be part of the normal workflows, so feel free if you need to modify the VM images further.

thanks, it looks better now :D
Is it possible to have the two combinations cgroups2 AND rootless, cgroups2 and root.  It makes no sense to test the remote client.  So we can skip it

@giuseppe yes, in fact I was going to ask if you wanted that, but then thought maybe we should leave it for a future update.  The primary reasons I had in mind were:

Conflict over $SPECIALMODE, perhaps there's a better/simpler design for this (i.e. $TESTSUITE?)
Uncertainty over differences between cgroupv2 testing vs "standard" integration testing - the new tests don't have to re-use the current ginkgo suite, they could do something entirely different if that makes more sense.
This PR is already Size/L, representing a non-trivial maintenance-burden increase (adding a snowflake VM image).

I can strip out the client-testing easy enough though, that's not a big deal.
How would you feel about: merging this and working up the actual testing (however that needs to be done).  Then when the testing is running and stable, come bother me and we'll figure out how to best to integrate rootless testing.  Would that be okay?

A related thought:  We're currently automatically publishing the binaries which have passed testing.  Third-party or out-of-band testing is the intended use-case for these. It happens for both PRs and master, providing a publicly accessible "latest" zip archive.  Would you be interested in having one of these made for cgroupv2?   It's not much work, since the machinery is already in place.

(rebase, force-push w/o cgroupv2 remote testing)

How would you feel about: merging this and working up the actual testing (however that needs to be done). Then when the testing is running and stable, come bother me and we'll figure out how to best to integrate rootless testing. Would that be okay?

I am fine with merging it as it is, so we can start using it and see what tests are failing.  Thanks!
LGTM

@cevich This needs a rebase.  Should we wait until podman 1.5 is released before putting this in?  I don't want to jeopardise the release.

Should we wait until podman 1.5 is released before putting this in? I don't want to jeopardise the release.

Yes, most definitely we should wait.

Okay, this one is ready.  @giuseppe @baude @mheon PTAL (when things quiet down a little).

/lgtm
/hold
Wait to cancel after the release of 1.5

/hold cancel

/hold
Something send to be stalling this, will investigate when I get to a
computer
On Sat, Aug 10, 2019, 05:46 Daniel J Walsh<EMAIL_ADDRESS>wrote:

/hold cancel
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/containers/libpod/pull/3607?email_source=notifications&email_token=AB3AOCDEIAMNW7GZV7RBBQDQD2FARA5CNFSM4IFGYGC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4AKE2I#issuecomment-520135273,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB3AOCAU4BHQEWN5RO6PDULQD2FARANCNFSM4IFGYGCQ
.

@cevich could you rebase it?
I've moved crun under github.com/containers.  Once we set up tests with cgroups v2, we will probably want to setup some tests on the crun repository as well to avoid regressions

we will probably want to setup some tests on the crun repository as well to avoid regressions

Can they be performed inside a container?  I'm happy to help, but there's one "implement CI on $REPO" request ahead of it.
Rebasing this, rebuilding images, and re-testing...

/lgtm

/lgtm

@giuseppe @mheon @baude this one is ready whenever y'all are.

/hold cancel


[BUG] tests marked with xfail missed

https://github.com/NVIDIA/spark-rapids/issues/1459 has been fixed, but there are still tests that are marked as xfail on it. At least some of them pass now, and we should either mark them as passing now, or file follow on issues to understand why they are still failing.

closed by #3779


Fixing the template according to the new classes in linkedin ui

Tested, and still give me an exception, stopping at applying 2nd delay

@rizkiandrianto do you remember the profile that thrown that error?


missing mp3 files for sound effects and music

Hi Nice game !
When loading under Safari (that does not support .ogg), loading fails because of missing mp3 files.
melonJS will try to load audio files based on both supported format and provided assets type as specified through the audio.init() method:
https://github.com/abdellatifAhammad/bounce_tales/blob/38c7309064b869f42ebedf2b30d118a079886cd8/src/index.js#L28

Hi mr Olivier, thanks a lot for pointing to this issue,I did't test on Safari since I don't have it, but I am 100% percent sure that I need to put the mp3 files also there, thanks a lot sir.

thanks a lot Olivier for indicating this issue, I added the mp3 files, so that will fix the issue for now.


Extract function assist will add async if required

The extract function assist will check for an AWAIT_EXPR or AWAIT_KW in the body and if found, will add async to the generated function.
closes #8232

@JamieCunliffe so given the comments I think its fine if we just look for await expressions in the body ignoring macros and the await keyword for the time being.

@Veykril I have pushed a change to only look for await expressions.

Thanks!
bors r+


Online live editor still use old version

Can you upgrade github pages to latest version?
Current mermaid is 0.5.8. Latest version is 6.0.0

Thanks for the input. I just updated to the latest version!


⚠ Bofrost.de has degraded performance

In 041149b, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 916 ms

Resolved: Bofrost.de performance has improved in 380b44e after 9 minutes.


Add drag and drop tree sample

Adds a sample that demonstrates how tree drag and drop interaction could be implemented.
This PR is not ready to get merged until ui-components is updated to 2.14, where helper methods for moving nodes in tree model are implemented.
The following is not finalized:

Sample position within the UI Trees category
Sample screenshot
Explanatory comments
Placeholder code for updating the tree model

@StefanRetief I attempted to add a few external npm packages to the sample and when I press "Run code", a runtime exception occurs. Could someone help me out on that?

 Could someone help me out on that?

So this error is a new one that's going to take some time to investigate. I'm not sure why, but the import isn't resolving as it would normally, as it's supposed to export the function as default. In this case, it exports it as a property of default. It could be a multitude of things going wrong.

Looks good to me. @Josh-Schifter, could you or someone on your team review this?

Looks good to me. @Josh-Schifter, could you or someone on your team review this?

I'll add sample screenshot before making this PR ready for review.

Looks good to me. @Josh-Schifter, could you or someone on your team review this?

I'll add sample screenshot before making this PR ready for review.


Can't test endpoint with SuperTest when it uses an overriden middleware.

Information

Version: 5.1.3
Type: Issue

Description
Can't test the failing path of an endpoint when it uses an overridden middleware.
Example
import { ExpressApplication } from '@tsed/common';
import { TestContext } from '@tsed/testing';
import * as Path from 'path';
import * as SuperTest from 'supertest';
import { Server } from '../../../../src/app';

describe('Archive endpoint', () => {

    // bootstrap the express application
    before(TestContext.bootstrap(Server));
    before(TestContext.inject([ExpressApplication], (expressApplication: ExpressApplication) => {
        this.app = expressApplication;
    }));
    after(TestContext.reset);

    describe('PUT /api/upload', () => {

        it('should return 401', (done) => {
            SuperTest(this.app)
                .put('/api/upload')
                .attach('file', Path.join(__dirname, '/test.txt'))
                .expect(400)
                .end((err, res: any) => {
                    if (err || !res.OK) {
                        throw (err);
                    }

                    done();
                });
        });
    });
});

Throws:
1) Archive endpoint
       PUT /api/upload
         should return 401:
     Uncaught Error: write ECONNABORTED
      at _errnoException (util.js:1022:11)
      at Socket._writeGeneric (net.js:767:25)
      at Socket._write (net.js:786:8)
      at doWrite (_stream_writable.js:387:12)
      at clearBuffer (_stream_writable.js:514:7)
      at Socket.Writable.uncork (_stream_writable.js:313:7)
      at connectionCorkNT (_http_outgoing.js:685:8)
      at _combinedTickCallback (internal/process/next_tick.js:135:11)
      at process._tickCallback (internal/process/next_tick.js:180:9)

Acceptance criteria
I would expect it to pass.
Repo to replicate the issue: https://github.com/Szauka/errorReplication

Thanks @Szauka I'll try your example and fix the problem ;)

Ok I found the issue. Your test isn't correctly written ;)
I sent you a PR on your repo.
See you
Romain

Hi @Romakita ,
I was still getting the error.
It turns out that the issue was with my environment as it was working on other PC.
Reinstalling node fixed the problem.
Thanks a lot for looking into this.


Hydration errors on useId inside KeepAlive tag

Vue version
3.5.6
Link to minimal reproduction
https://stackblitz.com/edit/github-1yeqp6?file=src%2Fcomponents%2FMyComponent.vue
Steps to reproduce
Run the project
See that there is no hydration mismatch issues on load (and reload if you wish).
Trigger a HMR update, by updating the script tag in MyComponent.vue (my go to is suffixing an 'a' to the console.log statement) and see the hydration mismatch warning, the Hydration completed but contains mismatches-error and notice that 'My component' is no longer visible.
Also notice you can trigger a HMR update in the MyKeepAliveContainer.vue component without getting the warning.
What is expected?
Hydration mismatch errors should be consistent with the code, not happen based on what file triggers an HMR update.
What is actually happening?
Hydration acts differently between different files and throws and error i don't think should be there.
However this only seems to happen if you use useId in a component, inside a component wrapping it in a <KeepAlive/>-tag.
System Info
System:
    OS: macOS 13.6.3
    CPU: (12) arm64 Apple M2 Pro
    Memory: 122.17 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.9.0 - ~/.nvm/versions/node/v20.9.0/bin/node
    npm: 10.1.0 - ~/.nvm/versions/node/v20.9.0/bin/npm
  Browsers:
    Safari: 16.6
    Chrome 130.0.6723.59 (Official Build) (arm64)

Any additional comments?
Initially ran into it in a Nuxt project and reported it there, but @danielroe pointed out it seems to be a Vue issue.

duplicate of #7706


feat: create fuels template optimisations

Fixes TS-622

Closes #3088

Summary
Includes the following optimizations on the Next and Vite templates as per @SilentCicero's feedback:

[x] Replace the Top-up Wallet button with a single faucet button (remove the faucet button from the left hand nav).
[x] Reduce the transfer amounts for the predicate example, the amount is not suitable for testnet
[x] Predicate text not displaying correctly on mobile, may be resolved by generally reducing mobile body padding
[x] Ensure all externally routing links have target="_blank" and opens in a new tab.
[x] Ensure faucet is embedded and for Safari/Mobile there is a redirect to the faucet url and back.
[x] Balance should update on tx submission
[x] Move Fuel Docs link beside the Home button as another nav link
[x] Improve error handling when unconnected, currently it has the default tx fail error messages, we should provide something more specific, we could grey out the action buttons when no wallet is connected
[x] Remove the Back to home links, we already have a home button in the nav
[x] Transaction pending state, when a transaction is pending the active button should reflect that
[x] Mobile formatting fixes - reduce body padding significantly and make mobile nav links cover entire width
[x] Burner wallet issues? We may need to do some additional debugging / integration tests here to debug

Checklist

[x] All changes are covered by tests (or not applicable)
[x] All changes are documented (or not applicable)
[x] I reviewed the entire PR myself (preferably, on GH UI)
[x] I described all Breaking Changes (or there's none)

@danielbate it might if the UI has changed in a certain way. The only way to really know is to run them I think

Yeah unfortunately the UI tests are failing for me. Docs will also need updating 🤔

Closing this for now, we've run into issues with the integration tests when removing the wallet abstractions. These are problems we'll also need to solve for #3125 so we'll be syncing up with @rishabhkeshan to get these over the line, but it's likely that this PR will be superceded.


return 1+0j if lens radius of curvature is infinite

as discussed in this issue: https://github.com/pydata/numexpr/issues/293, NumExpr can (at least with some libraries) return NaN instead of 1+0j for complex valued expressions such as exp((-0.-0.j)/np.inf).
This checks for infinite radii of curvature and returns a lens phasor 1+0j, since exp(something/infinity) should always return 1.

Hmm, this looks reasonable but the Travis test stalled out. I've kicked the job to try running again there and we will see whether that works or not.
Do you think it would be worth adding a unit test to verify this functionality?

it looks like Travis is dying on the fresnel tests, maybe we need to decrease the array size to use less memory again? They pass locally.
I have been thinking it might be worth adding a few unit tests to the accelerated math functions and this would follow under that umbrella.

Yes that was my conclusion - running locally it was going up to 2.8 GB for the Python process and I believe Travis nodes are capped at 3 GB so I can easily see it running into the limit. I started modifying the test but seems like I will have to tweak the assertions to still get it to pass with the smaller size. I’ll probably get to this at some point today.

Fixed the Fresnel test case to run even with lower sampling. This involved something I've long needed to do, improving the measure_fwhm function to better handle coarser sampling. And then being more careful about PSF centering when computing the FWHM. I'm running the updated tests on Travis now. Assuming that passes, then I can address the back log of PRs including this one.


missing target for python 3.12-linux-armv7-musl

Currently using uv and trying to install python 3.12, but seeing the following error when it tries to install 3.12 on armv7 architecture on alpine linux.
error: No download found for request: cpython-3.12-linux-armv7-musl

Thanks -- this is a duplicate of #6890. We don't provide musl builds right now. I suggest using a non-musl glibc, or installing Python separately.


docs: add local stack examples

Description:
Open for feedback. Experiment with local examples with generated docker configurations.
https://nickel-lang.org/ is used to generate all compose.yaml in each example.

example
description

st
single-tenant configuration without external services (except database)

st-multi
3 instances of single-tenant configuration

st-vault
single-tenant with Vault for secret storage

mt
multi-tenant configuration using built-in IAM

mt-keycloak
multi-tenant configuration using Keycloak for IAM

mt-keycloak-vault
multi-tenant configuration using Keycloak and Vault

Example we might consider in the future

vault with file storage
vault with AppRole authentication
keycloak with agent admin role
oidc4vc configuration
overriding config with application.conf
production?

Checklist:

[ ] My PR follows the contribution guidelines of this project
[ ] My PR is free of third-party dependencies that don't comply with the Allowlist
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked the PR title to follow the conventional commit specification

Thanks for all reviews, I need to update something from main and I hope to merge this within this week.


[Coverity CID :203486]Memory - corruptions in /tests/bluetooth/uuid/src/main.c

Static code scan issues seen in File: /tests/bluetooth/uuid/src/main.c
Category: Memory - corruptions
Function: test_uuid_cmp
Component: Tests
CID: 203486
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996

@jhedberg

Marked as false positive in Coverity


Be able to share compiled OpenCL binary caches among identical GPUs

This change solved the following issue

When rendering with multiple GPUs/CPUs, the generated inputmap.cl of worker threads are different to each other
Because each worker thread use its own instance of default_material in ClwSceneController, which has its own SceneObject id
Different SceneObject id means different inputmap id, lead to different inputmap.cl

Change default_material from member variable to static variable solve this issue

If rendering with multiple identical GPUs, they should have share the same kernel binary caches (with the first issue solved)
But if there is no cache exists, all the GPUs will try to compile and generate the very same binary cache, at the same time
This may cause a huge spike in memory consumption with lots of wasted works

Added a lock mechanism to allow only one worker to compile and generate binary cache, while the others will simply wait for it
Any workers with different GPU/CPU model won't be affected and will be able to generate their own version of kernel binaries

Can somebody give me a hint about the jenkins build report?
I have no access

Hello, according to the build logs the test 'AovTest.Aov_ObjectId' is failed. You should be able to reproduce this issue on Ubuntu/Windows machines. Looks like this is permanent issue for all of them. Try to launch Baikal unit tests

Thanks, I will look into it

The AovTest.Aov_ObjectId test has failed because ClwSceneController::m_default_material has become a static field. Therefore, construction order for scene objects has changed. IDs for the objects are given one by one as they constructs, so now the test objects have other IDs => other AOV color.

Yes, seems the only way to solve the issue is by update the unit test reference image
Also I made a change again, m_default_material is now part of the scene properties
A material should stay with data object instead of controller
Data required to construct a inputmap should only come from the scene, not the controller


feat(client): add ability to provide grpc dial options like client interceptors

Description
This closes #349.
A new client option to add custom grpc dial options to Zitadel client is added.
I understand that #349 is in the product backlog, but since I already need metrics I took liberty and prepared this PR. Let me know if I need to alter my code somehow for this PR to be accepted. Thanks!
Definition of Ready

[x] I am happy with the code
[x] Short description of the feature/issue is added in the pr description
[x] PR is linked to the corresponding user story
[ ] Acceptance criteria are met
[ ] All open todos and follow ups are defined in a new ticket and justified
[ ] Deviations from the acceptance criteria and design are agreed with the PO and documented.
[ ] No debug or dead code
[x] My code has no repetitions
[ ] Critical parts are tested automatically
[ ] Where possible E2E tests are implemented
[ ] Documentation/examples are up-to-date
[ ] All non-functional requirements are met
[ ] Functionality of the acceptance criteria is checked manually on the dev system.

@sashayakovtseva Thank you for the PR!
Can't explain why we did not already provide that option (we had it on v2 🤦 )
I've changed the PR title to reflect the more generic approach.
If you want a small gift for your contribution, please reach out to<EMAIL_ADDRESS>


App Icon Dark Gray Background

On a Pixel XL 2, but I'm assuming all Pixel Launcher phones, SLS icon in the app drawer has an ugly dark gray background.

Thats the general app icon design: https://github.com/tgwizard/sls/blob/master/app/src/main/res/mipmap-xxxhdpi/ic_launcher.png
Not sure what issue you have with that? Design is always individual taste. If you'd like to see a circle shape to fit Googles current design I would agree.

Oh wow I'm sorry if the gray was an intended choice, I thought it was a bug since it doesn't match the icon in the Play Store.
Let me add my argument: I think that the gray background is too similar to the red of the icon, I'd recommend using a much lighter, or even white background, for the rectangle or circle behind the logo. The gray and the red are much to similar and the icon really gets lost into it. This is magnified on the Pixel 2 screens especially since they use the more flat RGB colors.
Please just consider lightening up whichever color you decided to use for the background, to make the "as" really pop out more.


Comparison of conversion and int8 conversion for TFLite

Hi, I'm working on converting trained tensorflow model to uint8 and int8. But I found that the results between the two models are different, the followings are settings of conversion:
1. System information

OS Platform and Distribution: Ubuntu 16.04
TensorFlow installation (pip package or built from source): pip package
TensorFlow library (version, if pip package or github SHA, if built from source): 1.15.0

2. Code
[int8 conversion]
    converter.optimizations = [tf.lite.Optimize.DEFAULT]
    converter.target_spec.supported_ops = [tf.lite.OpsSet.TFLITE_BUILTINS_INT8]
    converter.inference_input_type = tf.int8
    converter.inference_output_type = tf.int8
    converter.representative_dataset = representative_data_gen
    tflite_int8_model = converter.convert()

[uint8 conversion]
    converter.target_ops = [tf.compat.v1.lite.OpsSet.TFLITE_BUILTINS, tf.compat.v1.lite.OpsSet.SELECT_TF_OPS]
    converter.inference_type = tf.uint8

    input_arrays = converter.get_input_arrays()
    converter.quantized_input_stats = {input_arrays[0]: (127, 127)}
    converter.default_ranges_stats = (-128, 127)
    tflite_uint8_model = converter.convert()

3. Failure after conversion
The results between the int8 and uint8 models are different
(int 8 model with representative dataset)

(uint8 model with input_stats and ranges_stats)

5. (optional) Any other info
I also tried to applying converter.optimizations = [tf.lite.Optimize.DEFAULT], converter.representative_dataset  and converter.quantized_input_stats, converter.default_ranges_stats simultaneously, but the generated model contains two quantize layers, which generates wrong results.

Is it possible to generate uint8 models with converter.representative_dataset  with all layers are quantized as uint8 instead of int8?
Best regards

@daverim Hi david, you may have know more details about this. Would you please take a look?


Fix internal tests for shared Windows builds

The testsuite has many so called internal tests, which link statically against libcrypto and/or libssl. All these internal tests are disabled for shared Windows builds, because the names of the static libraries collide with the names of the import libraries for the DLLs.
https://github.com/openssl/openssl/blob/f81b043ad856d8b9af5239a4978f8bd4b965dab9/test/build.info#L434-L445
There has been some discussion about whether the static libraries should be renamed, but that is only an option for the next major release. I would like to suggest a temporary workaround which would be backportable to 1.1.1 and would enable us to activate all internal tests for shared Windows builds.
Instead of renaming the installed libraries, one could build additional static libraries (on windows only) to make the static tests depending on these. One does not even have to rename the static libraries, just place them in a separate directory (e.g. static\libcrypto.lib, static\libssl.lib), to distinguish them from the import libraries. These static libraries would only be used for the internal tests and not installed later on.
If building two library versions is undesired on this notoriously slow platform, then one could add a --static-tests option for windows, which is disabled by default.
References
This request originated from a discussion with @levitte in #7462, see in particular

https://github.com/openssl/openssl/pull/7462#issuecomment-432021865
https://github.com/openssl/openssl/pull/7462#issuecomment-432106224
https://github.com/openssl/openssl/pull/7462#issuecomment-432118520

#7496 is an attempt to do this.  It's really a quick hack, but a fairly easy one to understand.

Cool,  thank you very much! That was a really fast reaction.
I'll rebase #7462 on top of this pr and and check whether it works (later this evening).

If it works, I'll try to enable all the other tests, too. (If you already started doing it, go ahead of course.)

Oh, vorget my last remark. The changes for test/build.info are already in your pr.


fix: always use database in TodoList.telefunc.ts (fix #378)

I don't know if this breaks some edge cases, feel free to simply reject if it does.

I haven't re-tested this, but I had this before, and when refreshing the page fully, the todos where always the ones when the app started (as if the .push() just did nothing)

I tried with pnpm create bati --react --telefunc --hono and it seems to work.


Add WebSocket.Factory option to Connection.Options

Closes #21

Thank you both for the review!

Thank you both for the review!


Training with more than four channels

I have an image with three different shapes and another image with 4 classes, 3 marking the shapes and one class for marking the background. I created a .CTensor from these and wrote a .set file which associates the colors to classes using

makeCompressedTensorStream testclass.set images . labels . testclass.CTensor false

When I try to train a network with the four classes, CN24 errors out with:

ERR [ ErrorLayer::CreateOutputs(49) ] Inputs need the same number of elements!

The same also happens when I modify the toy example to use four classes.
Am I missing something or is that a bug?
EDIT: this is on master, not develop

Could you post the dimensions of each entry in the Tensor stream? While CN24 may make some assumptions about the number of input channels, no such restrictions exist on output channels.

TOY.Tensor

My test tensor:


Cannot connect to my device

No HUB was found even though I used USB to connect.

Hi @Lenaxiao, sorry for coming back so late to the issue you raised. I imagine this might not be relevant anymore, but if you still want support, let me know. Otherwise, I will close this issue in a few days.


carousel height change

How can I edit the carousel height?
I have found there is .carousel-inner item in the file vendor/bootstrap/css/bootstrap.min.css
When I have tried to add there parameter like: max-height: 200px, nothing happened.
The whole template is really really cool, but the carousel is too big...
Thanks for an advice,
Rene

Hi R.
First you get the right CSS file, here /vendor/bootstrap/css/bootstrap.min.css
Then you look for the class carousel-inner
And there, you change the height (max-height: 200px; works just fine)
Hope it will help. Take care

Hi zeufparis,
many thanks for help. The carousel really decreased its size. But the content inside now does not fit the carousel dimension, nor image, nor the text (i.e. First slide; This is a description for the first slide.), etc.
I have chagned the dimension of the carousel from original 1900x1080 at 1900x540. I have chachged the image URL in index.html from:
http://placehold.it/1900x1080
at
http://placehold.it/1900x540
But it did not help. The image appears like "zoomed" in the carousel. I believe the text is hidden "bellow" the carousel.
Do I need to change some other parameters in the bootstrap.min.css file, to fit the image and text at the reduced carousel dimensions? In the indext.html code, I can not see any variables defyning image or text positions.
Many thanks,
Rene

For the caption, you have to change the .carousel-caption bottom.. To 60px or more. You have to try.
Regarding the ézoom" effect, I don't see it with my own picture, sorry
Good luck

Thanks, that again helped. When I have set the bottom at 310px, I have got the text back. But there will be something wrong with the image in the carousel, bacuse 310px is quite high number and suggeste that I miss large portion of the image.
Here is a screen how approximatelly my homepage appears now with linked 1900x540px image:

While the original image appears like:

Again, many thanks @zeufparis for the substantial help!

Ok, try with a real picture

Same behavior with the real image of dimensions 1900x540px. There will be separate scaling for carousel borders and for the image inside.
Webpage:

Original:

Did you try to change the height of your picture to 540 ?

Yes, the jpg file resolution is 1900x540. If I should change some picture-related parameter in the css file, then I did not do it. But I think we are not so far, because it appears neither of us know what to change or define specifically in the file.

Try to add the height in the css lines
.carousel-item.active,
.carousel-item-next,
.carousel-item-prev {
  display: block;
  /* add your height here */
}

Thanks @zeufparis, this really helped:
.carousel-item.active{display:block;max-height: 540px}
It appears it is working fine now with any other added parameters. I did not need to change anything else in the template. Only the carousel, because it is too large. Default settings make that over 70% of the information displayed at the Home Page is the carousel. An it is not ideal for my application.
Many thanks and best, Rene