例子无法运行起来， memory包中有好几个编译错误

例子无法运行起来， memory包中有好几个编译错误

等到 https://issues.chromium.org/issues/380911432 修复之后再修，不然同样也跑不起来

[like]  WeiYaPeng(Jim) reacted to your message:

From: Zihang Ye @.>
Sent: Thursday, November 28, 2024 2:58:28 AM
To: peter-jerry-ye/canvas @.>
Cc: WeiYaPeng(Jim) @.>; Author @.>
Subject: Re: [peter-jerry-ye/canvas] 例子无法运行起来， memory包中有好几个编译错误 (Issue #4)
等到 https://issues.chromium.org/issues/380911432 修复之后再修，不然同样也跑不起来
―
Reply to this email directly, view it on GitHubhttps://github.com/peter-jerry-ye/canvas/issues/4#issuecomment-2505170504, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAKTSGJZSBVSOC4B745KYP32C2BFJAVCNFSM6AAAAABSNAVH42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBVGE3TANJQGQ.
You are receiving this because you authored the thread.Message ID: @.***>

Issue fixed.

[heart]         WeiYaPeng(Jim) reacted to your message:

From: Zihang Ye @.>
Sent: Friday, December 13, 2024 2:41:45 AM
To: peter-jerry-ye/canvas @.>
Cc: WeiYaPeng(Jim) @.>; Author @.>
Subject: Re: [peter-jerry-ye/canvas] 例子无法运行起来， memory包中有好几个编译错误 (Issue #4)
Issue fixed.
―
Reply to this email directly, view it on GitHubhttps://github.com/peter-jerry-ye/canvas/issues/4#issuecomment-2540411531, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAKTSGJPOWXGYQVWDP5757D2FJCOTAVCNFSM6AAAAABSNAVH42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBQGQYTCNJTGE.
You are receiving this because you authored the thread.Message ID: @.***>


Add 'vault_use_config_path' for out-of-band configurations

closes: #219
This PR introduces a couple of style changes that I'm happy to revert.

@bbaassssiiee should be fixed now. Let me know if there are any other issues!

There are conflicting files now, are you able to resolve these?

Thanks!


flutter app socket exception when it running

hello, I have a problem when I run my Flutter Application in Android Studio:
Error connecting to the service protocol: failed to connect to http://<IP_ADDRESS>:61397/JGLqojHvWac=/
vm-service: Error: Unhandled exception:
WebSocketException: Invalid WebSocket upgrade request

[ERROR:flutter/runtime/dart_isolate.cc(993)] Unhandled exception:
WebSocketException: Invalid WebSocket upgrade request

but I can run success in my Terminal。
this is my "Flutter doctor":
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel dev, 1.25.0-4.0.pre, on macOS 11.0.1 20B50 darwin-x64, locale
    zh-Hans-CN)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 12.2)
[✓] Android Studio (version 4.1)
[✓] VS Code (version 1.51.1)
[✓] Proxy Configuration
[✓] Connected device (2 available)

At first I thought may be I do not setup noproxy, but i have no_proxy='<IP_ADDRESS>,localhost' in terminal and android studio...so i can not found the reason...

@shaomaicheng
can you please provide a minimal reproducible code sample

@shaomaicheng
can you please provide a minimal reproducible code sample

any project can recurrence it

@shaomaicheng
As iapicca suggested, please provide sample code about your issue.
Otherwise, we can't help you just base on your logs.

@shaomaicheng
As iapicca suggested, please provide sample code about your issue.
Otherwise, we can't help you just base on your logs.

any project can recurrence it.
also include  use flutter create create a new project

@shaomaicheng
You may try to run flutter clean to see if it helps. Also check this and this comment to see if that works for you.

@shaomaicheng,
Sorry that I miss understand you.
Originally, I think the issue is related to your projects that do some web requests and cause the problem.
However, it is not the case.

@shaomaicheng
You may try to run flutter clean to see if it helps. Also check this and this comment to see if that works for you.
thank your! now i can run my app in Android Studio. but I have a new problem , in my ios simulator, i can not build my flutter app:

this is flutter build ios --debug --verbose 's input 👍
↳
[   +1 ms]
[!] Invalid Podfile file: no implicit conversion of nil into String.
            #  from /Users/chenglei01/private/fataccount/ios/Podfile:57
            #  -------------------------------------------
            #      unless File.exist?(copied_framework_path)
            >        FileUtils.cp_r(File.join(cached_framework_dir, 'Flutter.framework'), copied_flutter_dir)
            #      end
            #  -------------------------------------------

           /Library/Ruby/Gems/2.6.0/gems/cocoapods-core-1.10.0/lib/cocoapods-core/podfile.rb:318:in `rescue in block in from_ruby'
           /Library/Ruby/Gems/2.6.0/gems/cocoapods-core-1.10.0/lib/cocoapods-core/podfile.rb:312:in `block in from_ruby'
           /Library/Ruby/Gems/2.6.0/gems/cocoapods-core-1.10.0/lib/cocoapods-core/podfile.rb:50:in `instance_eval'
           /Library/Ruby/Gems/2.6.0/gems/cocoapods-core-1.10.0/lib/cocoapods-core/podfile.rb:50:in `initialize'
           /Library/Ruby/Gems/2.6.0/gems/cocoapods-core-1.10.0/lib/cocoapods-core/podfile.rb:310:in `new'
           /Library/Ruby/Gems/2.6.0/gems/cocoapods-core-1.10.0/lib/cocoapods-core/podfile.rb:310:in `from_ruby'
           /Library/Ruby/Gems/2.6.0/gems/cocoapods-core-1.10.0/lib/cocoapods-core/podfile.rb:276:in `from_file'
           /Users/chenglei01/.gem/ruby/2.6.0/gems/cocoapods-1.10.0/lib/cocoapods/config.rb:205:in `podfile'
           /Users/chenglei01/.gem/ruby/2.6.0/gems/cocoapods-1.10.0/lib/cocoapods/command.rb:160:in `verify_podfile_exists!'
           /Users/chenglei01/.gem/ruby/2.6.0/gems/cocoapods-1.10.0/lib/cocoapods/command/install.rb:46:in `run'
           /Library/Ruby/Gems/2.6.0/gems/claide-1.0.3/lib/claide/command.rb:334:in `run'
           /Users/chenglei01/.gem/ruby/2.6.0/gems/cocoapods-1.10.0/lib/cocoapods/command.rb:52:in `run'
           /Users/chenglei01/.gem/ruby/2.6.0/gems/cocoapods-1.10.0/bin/pod:55:in `<top (required)>'
           /usr/local/bin/pod:23:in `load'
           /usr/local/bin/pod:23:in `<main>'

[   +9 ms] "flutter ios" took 11,508ms.
[   +8 ms] Error running pod install
how can i resolve it?
and it can work to build macos ...

@shaomaicheng
Is your original issue related to socket exception has been resolved or not yet ?
The latest log shows  Invalid Podfile file: no implicit conversion of nil into String. which seem to be a different issue.

@shaomaicheng
Is your original issue related to socket exception has been resolved or not yet ?
The latest log shows  Invalid Podfile file: no implicit conversion of nil into String. which seem to be a different issue.

yes, this is a new issue on ios,  socket exception is resloved after I use flutter clean

@shaomaicheng
I'd suggest you to open a new issue and provide all required details to better address your new issue.
I am going ahead and closing this since your original issue has been resolved per your comment above.

@shaomaicheng
You may try to run flutter clean to see if it helps. Also check this and this comment to see if that works for you.
thank your! now i can run my app in Android Studio. but I have a new problem , in my ios simulator, i can not build my flutter app:

this is flutter build ios --debug --verbose 's input 👍
↳
[ +1 ms]
[!] Invalid Podfile file: no implicit conversion of nil into String.
            #  from /Users/chenglei01/private/fataccount/ios/Podfile:57
            #  -------------------------------------------
            #      unless File.exist?(copied_framework_path)
            >        FileUtils.cp_r(File.join(cached_framework_dir, 'Flutter.framework'), copied_flutter_dir)
            #      end
            #  -------------------------------------------

           /Library/Ruby/Gems/2.6.0/gems/cocoapods-core-1.10.0/lib/cocoapods-core/podfile.rb:318:in `rescue in block in from_ruby'
           /Library/Ruby/Gems/2.6.0/gems/cocoapods-core-1.10.0/lib/cocoapods-core/podfile.rb:312:in `block in from_ruby'
           /Library/Ruby/Gems/2.6.0/gems/cocoapods-core-1.10.0/lib/cocoapods-core/podfile.rb:50:in `instance_eval'
           /Library/Ruby/Gems/2.6.0/gems/cocoapods-core-1.10.0/lib/cocoapods-core/podfile.rb:50:in `initialize'
           /Library/Ruby/Gems/2.6.0/gems/cocoapods-core-1.10.0/lib/cocoapods-core/podfile.rb:310:in `new'
           /Library/Ruby/Gems/2.6.0/gems/cocoapods-core-1.10.0/lib/cocoapods-core/podfile.rb:310:in `from_ruby'
           /Library/Ruby/Gems/2.6.0/gems/cocoapods-core-1.10.0/lib/cocoapods-core/podfile.rb:276:in `from_file'
           /Users/chenglei01/.gem/ruby/2.6.0/gems/cocoapods-1.10.0/lib/cocoapods/config.rb:205:in `podfile'
           /Users/chenglei01/.gem/ruby/2.6.0/gems/cocoapods-1.10.0/lib/cocoapods/command.rb:160:in `verify_podfile_exists!'
           /Users/chenglei01/.gem/ruby/2.6.0/gems/cocoapods-1.10.0/lib/cocoapods/command/install.rb:46:in `run'
           /Library/Ruby/Gems/2.6.0/gems/claide-1.0.3/lib/claide/command.rb:334:in `run'
           /Users/chenglei01/.gem/ruby/2.6.0/gems/cocoapods-1.10.0/lib/cocoapods/command.rb:52:in `run'
           /Users/chenglei01/.gem/ruby/2.6.0/gems/cocoapods-1.10.0/bin/pod:55:in `<top (required)>'
           /usr/local/bin/pod:23:in `load'
           /usr/local/bin/pod:23:in `<main>'

[ +9 ms] "flutter ios" took 11,508ms.
[ +8 ms] Error running pod install
how can i resolve it?
and it can work to build macos ...

do you solve this problem ? I meet it today


Add deflector

added proxy from fpx
added utils package and moved some things there so they can be used everywhere. i didn't copy additional types around headers helper because it has a bunch of other dependencies

for now only committing the proxy/ingestion part, mocks etc will be a part of different pr


License Inconsistentcy

The root folder has a license file showing the MIT license, but FastBitmap.cs has "The MIT License (MIT)" as a title with the "GNU General Public License" content underneath...
It's unclear which license applies to FastBitmap.cs. I'm guessing this was just an oversight and FastBitmap.cs just needs to be updated to the MIT license?

Yes, it's MIT-licensed, I must have missed the source files. I'll update them to be consistent. Thanks for pointing that out!


Inline CSS settings don't work

I tried on the Speculatron repo and it doesn't seem to be executed

These were never implemented, I'm afraid...
On Sun, Jul 17, 2022 at 8:35 PM Mushon Zer-Aviv @.***>
wrote:

I tried on the Speculatron repo and it doesn't seem to be executed
—
Reply to this email directly, view it on GitHub
https://github.com/akariv/speculatron/issues/8, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACAY5LT5YIVOAGCLEVF4QLVUQ77FANCNFSM532CMZPA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Spring Boot @Webservlet returns 401 when processing event from interactive Block (Spring Boot 2.1.5)

I am trying to click on a button generated by the block kit builder and do something on the java side with it.
Whenever I click on said button I get a 401. I managed to debug and see that the class responsible for this is SlackSignature inside the method isValid and that what happens is that the signature sent in the header X-slack-signature is different from the one generated by the class.
I had to manually get the payload parameter in another class because whenever I sent the request directly to SlackAppServlet the body would be null. To clarify:
@WebServlet("/slack/events")
public class SlackAppController extends SlackAppServlet {
    private static final Logger LOGGER = LogManager.getLogger(SlackAppServlet.class);

    private final App app;

    private final SlackAppServletAdapter adapter;

    private SlackRequestParser requestParser;

    public SlackAppController(App app) {
        super(app);
        this.app = app;
        this.adapter = new SlackAppServletAdapter(app.config());
        this.requestParser = new SlackRequestParser(app.config());
    }

    protected void doPost(HttpServletRequest req, HttpServletResponse resp) throws IOException {
            super.doPost(req, resp);
    }
}

This will lead to:
public class SlackAppServlet extends HttpServlet {
    @Generated
    private static final Logger log = LoggerFactory.getLogger(SlackAppServlet.class);
    private final App app;
    private final SlackAppServletAdapter adapter;

    public App getApp() {
        return this.app;
    }

    public SlackAppServlet(App app) {
        this.app = app;
        this.adapter = new SlackAppServletAdapter(app.config());
    }

    protected void doPost(HttpServletRequest req, HttpServletResponse resp) throws IOException {
        Request slackReq = this.adapter.buildSlackRequest(req);
        if (slackReq != null) {
            try {
                Response slackResp = this.app.run(slackReq);
                this.adapter.writeResponse(resp, slackResp);
            } catch (Exception var5) {
                log.error("Failed to handle a request - {}", var5.getMessage(), var5);
                resp.setStatus(500);
                resp.setContentType("application/json");
                resp.getWriter().write("{\"error\":\"Something is wrong\"}");
            }
        }

    }
}

But the method buildSlackRequest returns null.
Reproducible in:
mvn dependency:tree | grep com.slack.api
gradle dependencies | grep com.slack.api
java -version
sw_vers && uname -v # or `ver`

The Slack SDK version
[INFO] +- com.slack.api:bolt-servlet:jar:1.4.1:compile
[INFO] |  +- com.slack.api:slack-api-model:jar:1.4.1:compile
[INFO] |  +- com.slack.api:slack-api-client:jar:1.4.1:compile
[INFO] |  +- com.slack.api:slack-app-backend:jar:1.4.1:compile
[INFO] |  - com.slack.api:bolt:jar:1.4.1:compile
Java Runtime version
java version "1.8.0_111"
Java(TM) SE Runtime Environment (build 1.8.0_111-b14)
Java HotSpot(TM) 64-Bit Server VM (build 25.111-b14, mixed mode)
OS info
Microsoft Windows [Version 10.0.19041.630]
Steps to reproduce:

We create a webservlet using Spring boot to process the request sent when the user clicks on a button in the slack chat:

@WebServlet("/slack/events")
public class SlackAppController extends SlackAppServlet {
    private static final Logger LOGGER = LogManager.getLogger(SlackAppServlet.class);

    private final App app;

    private final SlackAppServletAdapter adapter;

    private SlackRequestParser requestParser;

    public SlackAppController(App app) {
        super(app);
        this.app = app;
        this.adapter = new SlackAppServletAdapter(app.config());
        this.requestParser = new SlackRequestParser(app.config());
    }

    protected void doPost(HttpServletRequest req, HttpServletResponse resp) throws IOException {
        SlackHttpServletRequestWrapper requestWrapper = new SlackHttpServletRequestWrapper(req);
        String retry = req.getHeader("X-Slack-Retry-Num");
        if (retry == null) {
            super.doPost(requestWrapper, resp);
        }
    }
}

As explained before we need to create our own class to get the payload parameter:

    public class SlackHttpServletRequestWrapper extends HttpServletRequestWrapper {
      public SlackHttpServletRequestWrapper(HttpServletRequest request) {
          super(request);
      }

      @Override
      public BufferedReader getReader() throws IOException {
          if (MediaType.APPLICATION_FORM_URLENCODED_VALUE.equals(getContentType())) {
              String payload = "payload=" + URLEncoder.encode(getParameter("payload"), "UTF-8");
              return new BufferedReader(new StringReader(payload));
          }
          return super.getReader();
      }
    }

Inside RequestVerification class the line that validates the X-slack-signature header returns false:

public class RequestVerification implements Middleware {
    @Generated
    private static final Logger log = LoggerFactory.getLogger(RequestVerification.class);
    private final Verifier verifier;

    public RequestVerification(Verifier verifier) {
        this.verifier = verifier;
    }

    public Response apply(Request req, Response resp, MiddlewareChain chain) throws Exception {
        if (MiddlewareOps.isNoSlackSignatureRequest(req.getRequestType())) {
            return chain.next(req);
        } else if (req.isValid(this.verifier)) {
            return chain.next(req);
        } else {
            String signature = req.getHeaders().getFirstValue("X-Slack-Signature");
            log.info("Invalid signature detected - {}", signature);
            return Response.json(401, "{\"error\":\"invalid request\"}");
        }
    }
}

the line is else if (req.isValid(this.verifier)).
Expected result:
The request should proceed through the different middlewares without problems and end up executing the eventHandler programmed by the library's user.
Actual result:
401 because req.isValid returns false.
Requirements

    <dependency>
        <groupId>com.slack.api</groupId>
        <artifactId>bolt-servlet</artifactId>
        <version>1.4.1</version>
    </dependency>

Hey @carlospalmaroldan, thanks for the detailed message and steps to reproduce!
I'm not as experienced with the Java SDK, but I wanted to ask simple question before our core maintainer @seratch is able to look at this issue.
Since you're handling a button interaction, are you using the @WebServlet("/interactive") annotation? The code sample above looks as though it's using a /slack/events annotation. You can find more info in https://github.com/slackapi/java-slack-sdk/issues/642#issuecomment-737617800, which explains the recommended way to annotate @WebServlet.
Sorry if this suggestion is way off mark, but I thought I'd offer it in case it helps unblock you!

Hello there @mwbrooks . Thanks for taking a look at the issue. #642 does not mention a problem with directly using SlackAppServlet. I was trying that but the body of the request ended up being null. Also the annotation is WebServlet, what's inside the parenthesis is just the path.

@mwbrooks
Thanks for jumping in! The reason why I suggested using @WebServlet("/interactive") in #642 was the original code in the issue was trying to use the path.
@carlospalmaroldan
Do you have any particular reason to have SlackHttpServletRequestWrapper in your app? The servlet adapter parses the request body for you. You don't need to have your own layer only for it. If you need to have a wrapper for some reason, it's totally fine to add some extra logic in the class as long as your logic does not modify the request body and headers related to the signature verification. The request body value should not be modified at all. If the raw string request body data is not exactly the same with the original data, the signature verification fails (even if the meaning of the data is the same).

"You don't need to have your own layer only for it."
I do. Here's why:

This is what happens when passing the request directly to the class SlackAppServlet

@carlospalmaroldan
What version of Spring Boot do you use? Unfortunately, 2.1 or older versions are not supported: https://github.com/slackapi/java-slack-sdk/issues/582
Another possible cause of this is that, as I mentioned in #642,

The important thing is that your controller should not consume the InputStream of request body data to construct Java objects. The reason for this is that Slack's request signature verification requires access to the raw string request body (the one which is not modified at all). So, you cannot use any built-in body parsers enabled by Spring Boot framework for this endpoint.

please make sure if there is no built-in / 3rd party configuration (you may have global configuration by annotations) that enables automatic request data parsers.
If none of the above conjecture  is correct and if an issue can arise with the latest Spring Boot, I will try to reproduce your issue later. It'd be appreciated if you could provide a minimum working example that reproduces your issue.

<!-- Spring boot. -->
    <parent>
        <groupId>org.springframework.boot</groupId>
        <artifactId>spring-boot-starter-parent</artifactId>
        <version>2.1.5.RELEASE</version>
        <relativePath />
    </parent>

@carlospalmaroldan This is our bad. Although the GitHub issue is publicly visible, there is no mention about the supported Spring Boot versions in the document. I will update the document later. Hope your Spring Boot upgrade to a newer version will go smoothly!

Updated the document: https://github.com/slackapi/java-slack-sdk/commit/4447c3ea7d5d5be70caa2a8c6296f14e04a0ae57
Let me close this issue now.


internal/lsp: get the correct symbol kind for the type alias and type definition

For the original implementation, there are just two symbol
kinds, StructSymbol and InterfaceSymbol. And it won't
take the essential type into account. Like the code bellow,
the symbol kind of alias will be StructSymbol, that's not
correct. BTW, there is no corresponding symbol kind to the
type alias.
type Node interface{}

type alias = Node

This patch consider the essential type to give a more precise
result of the symbol kind.

I will close this PR, because there is another more mature PR for this issue!


Mplayer fails to play when daemonised on linux

Mplayer blocks presumibly waiting for X.  if you add -vo null to the mplayer invocation then it works fine.
May be linux/ubuntu specific.
need to make mplayer configurable, this would be usefull anyway for people with multiple sound cards etc.

Fixed with our new daemon code.


Simplify integration test connection setup and tests (#845)

Goal
The goal of this PR is to simplify integration test & suite setup, eliminate tests interfering with each other, and increase test coverage.
Closes #845
Discussion

Checklist

[ ] Chain spec updated
[ ] Custom RPC OR Runtime API added/changed? Updated js/api-augment.
[ ] Design doc(s) updated
[x] Tests added
[ ] Benchmarks added
[ ] Weights updated

https://github.com/LibertyDSNP/frequency/pull/850#pullrequestreview-1240930191

Seems counterproductive to split this now, especially since it's been approved. But I get where you're coming from.


sort-keys missing from 0.9.0

Looks like the latest upgrades for Clojure 1.7 and the new Fipp broke this.
sort-keys was originally discussed here: https://github.com/greglook/puget/issues/12
In the past, the default was "always sort", but for interactive use, I think something around the height of one terminal screen (100 to 200) is a better default.

Ahh, I had a change renaming this to :sort-mode, but on further thought I think I'll change it back to :sort-keys instead. Numeric is probably a better default too.

Fixed in 8b1b38dbe23ad6513d1e0a3e42273916f4512a4d as part of release 0.9.1.

Oops, sorry, I should have read the change-log. I didn't realize it was simply renamed! Anyway, thanks for the prompt response and the change to the default.


No Recipes? 1.21.1

corn_delight-1.0.1-1.21.1.jar
Nothing has a single recipe.
Thanks.

I confirm, wild plants do not give their seeds too

Fixing on road, soon.

"I'M WAITING WITH ANTICIPATION. I REALLY WANT TO TRY THIS MOD.

FIXED in new version.


[META] Point In Time Search Issue List

Is your feature request related to a problem? Please describe.
This is a meta issue for all work/tasks related to Point-In-Time Search
Describe the solution you'd like
To provide Point-In-Time Search capability to OpenSearch users

[ ] OpenSearch Feature Proposal
[ ] OpenSearch Design Proposal
[ ] OpenSearch Dashboards Feature Proposal
[ ] OpenSearch Dashboards(UX) Design Proposal

Tasks and Release Timelines
This is a WIP and below are a list of current tasks identified related to support for Point-In-Time Search feature in both OpenSearch and OpenSearch Dashboards. We will continue to add/update tasks and timelines.

[ ] Point-In-Time Search OpenSearch Changes (To be released in 2.4.0)

[x] Point-In-Time POC
[x] Create Point-In-Time

[x] Feature Branch Changes
[x] Merge to mainline

[x] Create Point-In-Time Service Layer Changes
[x] Create Point-In-Time API Changes

[x] Delete Point-In-Time

[x] Feature Branch Changes
[x] Merge to mainline

[x] Delete Point-In-Time Service Layer Changes
[x] Delete Point-In-Time API Changes

[x] List all Point-In-Time

[x] Merge to mainline

[x] List all Point-In-Time Service Layer Changes
[x] List all Point-In-Time API Changes

[x] Segments/Reader Context Changes

[x] Merge to mainline

[x] Segments Service Layer Changes
[x] Segments API Changes

[x] Node Stats Changes

[x] Merge to mainline

[x] Node Stats Service Layer Changes
[x] Node Stats API Changes

[x] Point-In-Time Security

[x] Point-In-Time Security Model
[x] Security Plugin Changes
[x] Backport Security Changes
[x] Review and Appsec testing (ETA : 08/30/2022)

[x] Point-In-Time Performance Testing

[x] Add PIT related changes in OpenSearch Benchmark
[x] Performance testing using OpenSearch Benchmark

[ ] Point-In-Time Search Documentation Changes for OpenSearch

[ ] Point-In-Time Search OpenSearch Dashboards Changes

[ ] Stack Management Changes

[ ] Stack Management POC
[ ] Stack Management Changes Phase 1 (To be released in 2.4.0)
[ ] Stack Management Changes Phase 2

[ ] Discover Changes (To be released in 2.4.0)
[ ] Visualize Changes
[ ] Dashboard Changes
[ ] Point-In-Time Search Documentation Changes for OpenSearch Dashboards

Point-In-Time flaky tests : https://github.com/opensearch-project/OpenSearch/pull/4632

@bharath-techie Lets close the previous Point In Time Security Changes open PRs and only keep the new changes with the simplified model.
Did we update the security model with the simplified model that is concluded upon? If yes, lets close this alongwith pit backend design proposal

@bharath-techie @dhruv16dhr I'm pretty sure that you need the following pull request to be backported to 2.4.  I am going to start the backport process, but wait for your confirmation/approval before merging

https://github.com/opensearch-project/security/pull/2094
https://github.com/opensearch-project/security/pull/2223
https://github.com/opensearch-project/security/pull/2224

@peternied yes that's right , we'll need this PR for 2.4 release

@peternied yes that's right , we'll need this PR for 2.4 release

@bharath-techie Please close the PRs

Thanks, the 2.4 backport has been merged.  2.x backport is waiting on a retried CI workflow, I'll continue to shepherd those changes

@bharath-techie @peternied I see that all the security (including backport PRs) are merged and closed
There is nothing pending i believe, we are good for 2.4 release for "Point-In-Time Search OpenSearch Changes". Hence marked all tasks related to PIT backend as closed in this META issue.


Obtain snippets main module via package manager

The snippets package main module should be obtained via the atom.packages PackageManager instead of requiring directly.
Closes #155

Had similar problem with non-responsive keys on the latest version 1.27.2 and disabled VIM modes with success, hope this helps.


Update validation-pipeline.yaml

https://github.com/microsoft/winget-pkgs/issues/30321#issuecomment-943521645
Resolves #30321
Microsoft Reviewers: Open in CodeFlow

/azp run

/azp help

Yes, I was thinking if it could at least list the pipelines.

https://dev.azure.com/ms/winget-pkgs/_build

It can’t, since you aren’t a maintainer. ADO projects store pipelines in many repositories, being able to enumerate them even if you don’t have access to said repositories would be a security uh-oh. For this project, the only relevant ones are in this repo (and public in ADO), but that’s why you can’t use commands.
The reason I didn’t draft a PR was because I’m only 70% sure that that’s the problem (without being able to check the settings on the pipeline in ADO, I cannot be certain that’s what’s up). I was hoping the comment would get a maintainer to say “@jedieaston you dummy it was something completely different, here’s an explanation:”, or if it was the right answer, for them to do it since they’ll also have to go check the settings in ADO to make sure that they’re correct as well.

It can’t, since you aren’t a maintainer. ADO projects store pipelines in many repositories, being able to enumerate them even if you don’t have access to said repositories would be a security uh-oh. For this project, the only relevant ones are in this repo (and public in ADO), but that’s why you can’t use commands.
The reason I didn’t draft a PR was because I’m only 70% sure that that’s the problem (without being able to check the settings on the pipeline in ADO, I cannot be certain that’s what’s up). I was hoping the comment would get a maintainer to say “@jedieaston you dummy it was something completely different, here’s an explanation:”, or if it was the right answer, for them to do it since they’ll also have to go check the settings in ADO to make sure that they’re correct as well.

I would also add that it appears that there is some form of automation which also updates the pipelines, so a Maintainer should also check to make sure that this wouldn't break that automation

The behavior is the same. Internally in the DevOps configuration we had an override for the pr triggers with the same triggers that you added. I don't know what happened, but this is broken. I'll follow up with the DevOps team internally to find out what went wrong.


New Tool: tsv-pretty

Codecov Report

Merging #86 into master will increase coverage by 0.18%.
The diff coverage is 99.29%.

@@            Coverage Diff            @@
##           master     #86      +/-   ##
=========================================
+ Coverage   97.51%   97.7%   +0.18%
=========================================
  Files          15      16       +1
  Lines        3626    4052     +426
=========================================
+ Hits         3536    3959     +423
- Misses         90      93       +3

Impacted Files
Coverage Δ

tsv-pretty/src/tsv-pretty.d
99.29% <99.29%> (ø)


Importing changes to English strings from MathJax-i18n

One thing that I thought: instead of relying on the string keys in MathJax source code the script could just search the old English strings and replace it by the new ones.
Anyway, this is for post-v2.3.

No longer relevant in v3.


Can't interface on Windows ?

I follow the interface guide （https://speech.fish.audio/inference/）

This step requires running "tools/llama/generate.py" , but i can't install "WeTextProcessing" (bucause "Pynini" doesn't seem to support "Windows") .
Who Can Help Me , THANKS！

Thanks for reporting. Will push a fix later.


[Tensor] Change Add_i to have alpha signature

Changes proposed in this PR:

Add_i(Tensor &T, float alpha) for coefficient multiplication
Change test accordingly
Optimize blas implementation for multiply_i
run clang format to auto lint

See also: #166
Self evaluation:

Build test: [X]Passed [ ]Failed [ ]Skipped
Run test: [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Jihoon Lee<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.4.20191203. Thank you for submitting PR #168. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.

With this signature change,
y = beta * y + (1 - beta) * x
used to be
newy = y.chain()
        .multiply_i(beta)
        .add_i(x.multiply( 1 - beta))
        .run();

can be rewritten to
newy = y.chain()
        .multiply_i(beta)
        .add_i(x, 1 - beta)
        .run();

reducing one memory copy


readme: use same color as Unvanquished readme for irc link, do not advertise #daemon-engine anymore

readme: use same color as Unvanquished readme for irc link, do not advertise #daemon-engine anymore

The #daemon-engine was used when we were doing things with Xonotic guys, but no active developer use it anymore, we better redirect anyone to #unvanquished-dev that is enough for the job.


Disable the dropout by default in Online DPO

When there are methods that use log-probs, the added dropout causes fluctuations in its calculation compared to the reference model which, since it is typically used in eval mode, has no dropout.
To avoid this additional noise, it is usually deactivated.
We already have such option in other trainer:
https://github.com/huggingface/trl/blob/72f19c3fcecb0d53f356b1821d36073b65148aa0/trl/trainer/dpo_config.py#L157
Originally spotted by @kashif

i have fixed it in the xpo PR #1943


Add a hash script to setup the cron job

We can have a bash script that will create a cron job that runs main.py once a day so we can refresh the Chess Puzzles daily on the screen.

Closing as implemented in #8 .


Updated default checkpointer image

Update to use the latest checkpointer code by default

ok to test

coreosbot run e2e


Extract product owners

This is probably a later issue, but could be useful to have contacts to provide alerts (ie monitoring and uptime checks) and to in general, check in. This may be the same as the GitHub repo owners, which I *believe we have a list of, but need to learn where this lives, how it stays evergreen and how to connect this with the service domains and code base.

Tried to add owner, email and github repo in the template for the DNS repo, but config controller (connector?) has limitations around characters: valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue', or 'my_value', or '12345'), so needed to pull it back out. Now only have name (connected with underscore as no spaces). Need a better way to collect this metadata accurately.

Publicly on GitHub is not the best place for this information - on to an alternate solution.

code contributors?


Improve unmarshal header

No need to alloc empty slice if CSRC=0
Extensions always reset to zero length when unmarshal
Description
Reference issue

don't make empty slice can reduce bench test time.
Test result
goos: darwin
goarch: amd64
pkg: github.com/pion/rtp/v2
cpu: Intel(R) Core(TM) i7-1068NG7 CPU @ 2.30GHz
name                                                                       old time/op    new time/op    delta
UnmarshalHeader/NewStructWithoutCSRC-8    52.8ns ± 1%    47.7ns ± 1%  -9.67%  (p=0.008 n=5+5)
UnmarshalHeader/NewStructWithCSRC-8         68.2ns ±13%    67.6ns ±14%    ~     (p=1.000 n=5+5)
name                                                                       old alloc/op   new alloc/op   delta
UnmarshalHeader/NewStructWithoutCSRC-8     32.0B ± 0%     32.0B ± 0%    ~     (all equal)
UnmarshalHeader/NewStructWithCSRC-8         40.0B ± 0%     40.0B ± 0%    ~     (all equal)
name                                                                       old allocs/op  new allocs/op  delta
UnmarshalHeader/NewStructWithoutCSRC-8      1.00 ± 0%      1.00 ± 0%    ~     (all equal)
UnmarshalHeader/NewStructWithCSRC-8           2.00 ± 0%      2.00 ± 0%    ~     (all equal)

@pionbot @Sean-Der  someone can help review?


No support of feature groups in merge operation

The test is not very thorough but I finally fixed this issue :D !


re-word create activity. it's confusing

There's no way to play both the melody and bassline at the same time like the instructions on the Create activity implies ("review the main melody and bass line by performing them with the accompaniment track"). Also, there's no way to adjust the metronome count-in that Flat provides (which would pretty much be required if you wanted to play along with the accompaniment). Having only four beats to count in is fine for slower pieces, but it can be difficult to press play and bring your instrument up in that amount of time at a faster tempo.


Added missing multiple frustums to CHANGES.md, removed unused variables

Thanks for the pull request @nithinp7!

:heavy_check_mark: Signed CLA found.

Reviewers, don't forget to make sure that:

[ ] Cesium for Unreal Samples works.

@kring I just saw this forum post. Do you think the last commit here might fix the reported crash?

Good question! I posted to the forum asking the person to try the build from this branch.

Thanks @nithinp7!


BAEL-86: craedel-spring-dispatcher-servlet

Hi Slavisa,
I've added the sources for the picture and the picture itself.
Regards,
Christian

merged


I am so angry i just cant take it

I just cant take it. The way they did away with errors and warnings in the console.
Making the dev experience worse and worse.
And now that CRA is dead how the hell do you get warnings back to the console in Vite???? 😤
Lord Help

I hope this helps
https://github.com/patak-dev/vite-plugin-terminal

vite is torture, I can't config it to show the errors the way I want to, It keeps missing things, for example if you remove a file that messes up an import, if you don't save the file that is using that import u won't see the error ..., so many problems, i miss CRA


Add logging options

Add an option to disable file logging and also wire up the loglevel option.

Coverage remained the same at 27.503% when pulling 14e9946edceb4ed70121876a98a721e625039e20 on logs into 13bac64a3bc21998eeebc3258c57b4a2d9526627 on master.

Coverage remained the same at 27.503% when pulling 1bcc1af91e611cf5442bd98189000eeca6a7f747 on logs into 13bac64a3bc21998eeebc3258c57b4a2d9526627 on master.


Shooting torches with crossbow at unknown nodes crashes

AsyncErr: ServerThread::run Lua: Runtime error from mod '' in callback item_OnUse(): /home/user/.minetest/mods/torch_bomb/init.lua:286: attempt to index local 'under_def' (a nil value)
stack traceback:
	/home/user/.minetest/mods/torch_bomb/init.lua:286: in function 'find_target'
	/home/user/.minetest/mods/torch_bomb/init.lua:758: in function </home/ruser/.minetest/mods/torch_bomb/init.lua:736>

When shooting torches with a crossbow at unknown nodes (boxes that have text labeled on them reading as "unknown node"), the game crashes with that message:
Steps to reproduce:

In single player local game, use a mod that creates unique node blocks
create unique node blocks with that mod
exit the game, disable the mod
start the game again, shoot a torch at the unknown node block using any of the crossbows
crash!

Think I fixed it, torches should now stick to unknown nodes correctly. Well, as correctly as anything that deals with unknown nodes can be.

Think I fixed it, torches should now stick to unknown nodes correctly. Well, as correctly as anything that deals with unknown nodes can be.


Limit cluster access

I am not sure if validatingadmissionpolicy is required right now. And we may add more rules like only allow updates when driver is gpu.nvidia.com, something like
object.spec.driver == 'gpu.nvidia.com'
I did a quick test with the original implementation done here https://github.com/kubernetes/kubernetes/blob/4aeaf1e99e82da8334c0d6dddd848a194cd44b4f/test/e2e/dra/test-driver/deploy/example/plugin-permissions.yaml#L38
1 resourceslicecontroller.go:313] "processing ResourceSlice objects" err="update resource slice: resourceslices.resource.k8s.io \"nvidia-dra-driver-k8s-dra-driver-controller-7f78c745f6-ngnjlfwt\" is forbidden: ValidatingAdmissionPolicy 'resourceslices-policy-nvidia-dra-driver-k8s-dra-driver' with binding 'resourceslices-policy-nvidia-dra-driver-k8s-dra-driver' denied request: this user running on node 'xxxxxxxxx' may not modify cluster resourceslices" logger="UnhandledError"

We do need it, but the rule for the controller needs to be slightly different since it does not create a node-local resourceslice but rather a resourceslice associated with a group of nodes.

Also, the DCO is failing because you didn't sign your commits.

@bart0sh @pohly what is the best way to add admission policy for a pool of nodes and not just a single node. The upstream work exemplifies node level validation https://github.com/kubernetes/kubernetes/blob/4aeaf1e99e82da8334c0d6dddd848a194cd44b4f/test/e2e/dra/test-driver/deploy/example/plugin-permissions.yaml#L41
Why is this even needed, help me understand.
Our resource slice for the imex controller has these fields
kubectl explain resourceslice.spec
GROUP:      resource.k8s.io
KIND:       ResourceSlice
VERSION:    v1alpha3

FIELD: spec <ResourceSliceSpec>

DESCRIPTION:
    Contains the information published by the driver.

    Changing the spec automatically increments the metadata.generation number.
    ResourceSliceSpec contains the information published by the driver in one
    ResourceSlice.

FIELDS:
  allNodes	<boolean>
    AllNodes indicates that all nodes have access to the resources in the pool.

    Exactly one of NodeName, NodeSelector and AllNodes must be set.

  devices	<[]Device>
    Devices lists some or all of the devices in this pool.

    Must not have more than 128 entries.

  driver	<string> -required-
    Driver identifies the DRA driver providing the capacity information. A field
    selector can be used to list only ResourceSlice objects with a certain
    driver name.

    Must be a DNS subdomain and should end with a DNS domain owned by the vendor
    of the driver. This field is immutable.

  nodeName	<string>
    NodeName identifies the node which provides the resources in this pool. A
    field selector can be used to list only ResourceSlice objects belonging to a
    certain node.

    This field can be used to limit access from nodes to ResourceSlices with the
    same node name. It also indicates to autoscalers that adding new nodes of
    the same type as some old node might also make new resources available.

    Exactly one of NodeName, NodeSelector and AllNodes must be set. This field
    is immutable.

  nodeSelector	<NodeSelector>
    NodeSelector defines which nodes have access to the resources in the pool,
    when that pool is not limited to a single node.

    Must use exactly one term.

    Exactly one of NodeName, NodeSelector and AllNodes must be set.

  pool	<ResourcePool> -required-
    Pool describes the pool that this ResourceSlice belongs to.

And this is what i modified it to. I dint find any direct way to get the node label in validatingadmissionpolicyspec. You can only request node name with request.userInfo.extra[?'[authentication.kubernetes.io/node-name']0] and it does not allow complex querying.
apiVersion: admissionregistration.k8s.io/v1
kind: ValidatingAdmissionPolicy
metadata:
  name: resourceslices-policy-nvidia-dra-driver-k8s-dra-driver
spec:
  failurePolicy: Fail
  matchConstraints:
    resourceRules:
    - apiGroups: ["resource.k8s.io"]
      apiVersions: ["v1alpha3"]
      operations: ["CREATE", "UPDATE"]
      resources: ["resourceslices"]
  variables:
  - name: nodeSelectorValue
    expression: >-
      (request.operation == "DELETE" ? oldObject : object).spec.nodeSelector.nodeSelectorTerms[0].matchExpressions[0].values[0].orValue("")
  - name: poolName
    expression: >-
      (request.operation == "DELETE" ? oldObject : object).spec.pool.name.orValue("")
  validations:
  - expression: variables.nodeSelectorValue == variables.poolName
    messageExpression: >-
      "The nodeSelector value '"+variables.nodeSelectorValue+"' does not match the pool name '"+variables.poolName+"'."

Should there be any driver name validation in addition to the pool of nodes.
Thank you for your time.


hi ，when the ZeroQuant inference will be released?

Hi,
The engine of ZeroQuant inference is not released yet. The code example in DeepSpeed-Example is only to help verify the accuracy of ZeroQuant.
The kernel/engine released is on our calendar and we are actively working on it to make it compatible for various models. Please stay tuned.
For LKD, we will also release it soon.
For the last question, the code for training or accuracy testing is different than the final inference engine. Here, everything is simulated, so we can do quantization aware training or other things
Originally posted by @yaozhewei in https://github.com/microsoft/DeepSpeed/issues/2207#issuecomment-1212355792
hi ，when the ZeroQuant inference (for GPT model) will be released?

Any updates on this?

Reza  wraps up this https://github.com/microsoft/DeepSpeed/pull/2217 which answers some part of your questions, such as the model size reduction. Regarding the kernels, we are working on a plan to release it soon so that you can give it a try.
Thanks,

Any updates on this? Thanks @yaozhewei


Proposal to Translate README into Arabic for Wider Accessibility

Clear and concise description of the problem
The current README file is available only in English, which may limit accessibility for Arabic-speaking developers who are interested in contributing to or using the project but may not be comfortable with English. As the developer community is global, providing documentation in multiple languages can significantly lower the barrier to entry and foster a more inclusive and diverse community.
Suggested solution
I propose to create an Arabic translation of the README file, to be named README.ar.md, which will reside alongside the existing English README in the project repository. This translation will ensure that Arabic-speaking users can easily understand the project's purpose, setup, and contribution guidelines, thereby expanding the project's reach and inclusivity.
Alternative
No response
Additional context
To ensure the translation remains accurate and up-to-date, I will:

Regularly check the original README for updates and reflect any changes in the Arabic version.
Collaborate with other Arabic-speaking contributors to review and improve the translation for accuracy and readability.
I am committed to making this initial translation and maintaining it as part of my contribution to the project. This effort will help bridge language barriers and make the project more accessible to a wider audience.

Validations

[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Would you like to open a PR for this feature?

[X] I'm willing to open a PR

I think it's a great idea. Hopefully we can find contributors willing to submit in other languages as well. I would place it in a 'docs' folder, in the root, and we can add a link in the main README (in Arabic). Look forward to seeing what you submit.


Please invite me to the GitHub Community Organization

Please invite me to the GitHub Community Organisation.

Name: Aditya Kumar Gupta

Additional Context:

Where did you meet Eddie?
YouTube
What do you like about this community/ why do you want to join?
Would love to learn from a great community.
:nerd_face:

Invitation sent for the GitHub Organisation. Welcome to the community 🎉
Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see, you can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/EddieJaoudeCommunity/people
Tips for practising:
Customise your GitHub profile, here is a live stream on it https://www.youtube.com/watch?v=cT6GXCuS0Zo
Practice repo, instructions on how to add your name to the README in the README https://github.com/EddieJaoudeCommunity/hacktoberfest-practice
Remember contributing to open source is not just about code, its about collaboration, communication and adding value
I hope that helps


segfault on start - arm64 / 18.04

1804_nano:/external/work/nano/rai_build $ gdb -args ./rai_node --daemon
GNU gdb (Ubuntu 8.1-0ubuntu3) <IP_ADDRESS>80409-git
Copyright (C) 2018 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "aarch64-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from ./rai_node...(no debugging symbols found)...done.
(gdb) start
Temporary breakpoint 1 at 0x228bc8
Starting program: /external/work/nano/rai_build/rai_node --daemon
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/aarch64-linux-gnu/libthread_db.so.1".
bt

Temporary breakpoint 1, 0x000000555577dbc8 in main ()
(gdb) bt
#0  0x000000555577dbc8 in main ()
(gdb) c
Continuing.
[New Thread 0x7fb7d04130 (LWP 3564)]
[New Thread 0x7fb7503130 (LWP 3565)]
[New Thread 0x7fb6d02130 (LWP 3566)]
[New Thread 0x7fb6501130 (LWP 3567)]
[New Thread 0x7fb5d00130 (LWP 3568)]
[New Thread 0x7fb54ff130 (LWP 3569)]
[New Thread 0x7fb4cfe130 (LWP 3570)]
[New Thread 0x7fa7fff130 (LWP 3571)]

Thread 1 "rai_node" received signal SIGSEGV, Segmentation fault.
__GI___pthread_mutex_lock (mutex=0x7fb7ff9008) at pthread_mutex_lock.c:65
65      pthread_mutex_lock.c: No such file or directory.
(gdb) bt
#0  __GI___pthread_mutex_lock (mutex=0x7fb7ff9008) at pthread_mutex_lock.c:65
#1  0x00000055558ac534 in mdb_txn_renew0 ()
#2  0x00000055558ad5ec in mdb_txn_begin ()
#3  0x00000055557b96a4 in rai::node::node(rai::node_init&, boost::asio::io_context&, boost::filesystem::path const&, rai::alarm&, rai::node_config const&, rai::work_pool&) ()
#4  0x0000005555787128 in rai_daemon::daemon::run(boost::filesystem::path const&) ()
#5  0x000000555577dfd4 in main ()

built at f48597fe7481caa871bcf96e646b36d6e6e21ac0

Permissions issue is entirely possible, although I think I tried running as root for grins (vm). I'll have to figure out where it expects to have write access and double check. Thanks!

It's not a permissions issue. I have a binary of rai_node that segfaults when run on armv8. Anyone want to take a look?

I think another member of our team ran into the same problem. He fixed it by lowering the amount of memory mapped to LMDB. I'm not too sure on the details but we might end up putting that value in the config.

Please post exactly what processor you are using, and if your /boot/config file mentions VA_BITS. The issue I encountered was that by default lmdb is configured to use up to 1TB of addressing space. Certain ARM processors have lower limits on this virtual address space. In my case, on a Rock64 board, VA was 39 bits.

at 5ceacb949a2f71a8934ca9cf6b4dc2db355d9fea, still segfaulting

(not sure why this issue was closed, and I can't re-open it)
has write permissions, created ~/RaiBlocks successfully
(gdb) start
Temporary breakpoint 1 at 0x2287a0
Starting program: /home/name/raiblocks/build/rai_node --diagnostics
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/aarch64-linux-gnu/libthread_db.so.1".

Temporary breakpoint 1, 0x000000555577d7a0 in main ()
(gdb) c
Continuing.
[New Thread 0x7fb7d04130 (LWP 477)]
[New Thread 0x7fb7503130 (LWP 478)]
[New Thread 0x7fb6d02130 (LWP 479)]
[New Thread 0x7fb6501130 (LWP 480)]
[New Thread 0x7fb5d00130 (LWP 481)]

Thread 1 "rai_node" received signal SIGSEGV, Segmentation fault.
__GI___pthread_mutex_lock (mutex=0x7fb7ff9008) at pthread_mutex_lock.c:65
65      pthread_mutex_lock.c: No such file or directory.
(gdb) bt
#0  __GI___pthread_mutex_lock (mutex=0x7fb7ff9008) at pthread_mutex_lock.c:65
#1  0x00000055558a8434 in mdb_txn_renew0 ()
#2  0x00000055558a94ec in mdb_txn_begin ()
#3  0x00000055557b9d80 in rai::node::node(rai::node_init&, boost::asio::io_context&, boost::filesystem::path const&, rai::alarm&, rai::node_config const&, rai::work_pool&) ()
#4  0x00000055557ba66c in rai::node::node(rai::node_init&, boost::asio::io_context&, unsigned short, boost::filesystem::path const&, rai::alarm&, rai::logging const&, rai::work_pool&) ()
#5  0x00000055557ba7f0 in rai::inactive_node::inactive_node(boost::filesystem::path const&) ()
#6  0x00000055557bb4f0 in rai::handle_node_options(boost::program_options::variables_map&) ()
#7  0x000000555577dacc in main ()
(gdb)

You will need to change this line: https://github.com/nanocurrency/raiblocks/blob/d106aa4180e14295e03bb055432fbf1b7f935071/rai/node/utility.cpp#L71
auto status3 (mdb_env_set_mapsize (environment, 1ULL * 1024 * 1024 * 1024 * 1024)); // 1 Terabyte
adjust it to:
auto status3 (mdb_env_set_mapsize (environment, 1ULL * 1024 * 1024 * 1024 * 128)); // 128 Gigabyte
You may have to go lower but that did the trick for me on my Rock64. LMDB is trying to allocate all memory space for internal addressing. However, since this processor doesnt have the ability to address that much memory/address space, as soon as LMDB tries to initiate at startup it segfaults.

@icarusglider thanks, I'm surprised they didn't add any support to dynamically adjust the mapsize before closing this issue, as plenty of devices can't support allocating a TB of virtual memory.
Now I'm just getting "can't bind port" despite 24000 being unbound.

Just had a suspended gdb session which bound 24000 despite not showing in netstat.


GSD Request

--- GSD JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v5.9 to before v5.15.19",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=fa28dcb82a38f8e3993b0fae9106b1a80b59e4f0",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=0bcd484587b3b3092e448d27dc369e347e1810c3"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "fa28dcb82a38f8e3993b0fae9106b1a80b59e4f0",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "0bcd484587b3b3092e448d27dc369e347e1810c3",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "bpf: Guard against accessing NULL pt_regs in bpf_get_task_stack()\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.15.19 by commit 0bcd484587b3b3092e448d27dc369e347e1810c3, it was introduced in version v5.9 by commit fa28dcb82a38f8e3993b0fae9106b1a80b59e4f0. For more details please see the references link."
}
--- GSD JSON ---

This issue has been assigned GSD-2022-1000241


Error: Not found

We are using this action on a few of our applications. On a few applications, this action fails with the following error:
Run<EMAIL_ADDRESS>  with:
    github-token: ***
    labels: ["xxx"]
  env:
    IMAGE-NAME: xxx/yyy
    JIRA_ID: xxx
Error: Not Found
##[debug]Node Action run completed with exit code 1
##[debug]Finishing: Check PR label for dependabot

There is no clue as to why it fails. Something is not found, but i dont know what. There is no labels on the PR, but it should then return false, not exit with Error.
Also we are running this action on other pipelines, also without labels on PR, and there it runs just fine (returns false).

@digdirerik Hi, Erik:
Thank you for your report. The reason should be that a depended library had a vulnerability, which was also reported by dependabot https://github.com/shioyang/check-pr-labels-on-push-action/pull/19 several days before.
I updated the library and the issue must be fixed by PR https://github.com/shioyang/check-pr-labels-on-push-action/pull/20. Would you try the latest release v1.0.5 ?
https://github.com/shioyang/check-pr-labels-on-push-action/releases/tag/v1.0.5

@shioyang Thanks! I tested now with version 1.0.6. But unfortunatly, still exactly the same error...

@digdirerik Thank you for the testing. I'll check and investigate the issue...

Any progress on this?

@erkdahl Would you try the action with single quotes around the array of a label?
In your description:
  with:
    github-token: ***
    labels: ["xxx"]

Please try it with the workflow.yml:
  with:
    github-token: ***
    labels: '["xxx"]'

@erkdahl I added some logging codes into the latest release, v1.0.9.
Would you try to re-run a workflow with debug logging mode?


e2e: add basic release migration test

For coreos#5697.

@heyitsanthony @xiang90 Please review. This adds basic migration tests that I do manually for releases.

overall seems like the right direction

@heyitsanthony All addressed.
Test can now run with RELEASE_TEST=y, only in semaphore.
PTAL.
Thanks.

@xiang90 Just added snap-count flag to the test. PTAL.
Thanks!


Add #[attribute] methods to define Python class attributes

Here is my approach to #662: we add an attribute on methods defined in #[pymethods] impl blocks to allow defining class attributes (also named class variables).
A class attribute method cannot take arguments, and must return impl IntoPy<PyObject> or PyResult<impl IntoPy<PyObject>>. Note that in the latter case, returning an Err value will crash the Python interpreter since it will make LazyStaticType::get_or_init panic.
For example, given the following Python code:
class Foo:
    foo = 5
    BAR = 'bar'

a translation in Rust with pyo3 could be given by:
#[pyclass]
struct Foo { }

#[pymethods]
impl Foo {
    #[attribute]
    fn foo() -> i32 {
        5
    }

    #[attribute]
    #[name = "BAR"]
    fn bar() -> String {
        "bar".to_string()
    }
}

Bike-shedding on the name of the attribute (currently #[attribute]) is welcome. Also, I'm not used to the Python C API so it's possible that my code has memory errors.
I'll happily add a paragraph to the guide if this approach is validated.

Thanks for this PR, a way to add class attributes like this would be great. Couple questions (disclaimer, I haven't read the code yet):

Bike-shedding on the name of the attribute (currently #[attribute]) is welcome. Also, I'm not used to the Python C API so it's possible that my code has memory errors.

Can these things ever be settable? Maybe a pair of names like classgetter / classsetter? Though maybe these functions run only once during type object creation?

Note that in the latter case, returning an Err value will crash the Python interpreter

Did you explore mechanisms to prevent returning PyResult from these functions? It would be nice to make it impossible to compile code that's guaranteed to cause runtime crash, if that's viable.
Also, I wonder whether we could use syntax like associated constants instead of functions. But I think they're only stable for traits, not structs?

It would be nice if we could also use associated constants (which are stable, i8::MAX (not to be confused with std::i8::MAX) is a good example):
#[pymethods]
impl MyClass {
    #[attribute]
    pub const MY_CONST: &str = "blah";

    #[attribute]
    pub fn my_const2(_py: Python) -> Vec<u8> {
        vec![1, 2, 3]
    }
}

Interesting, thank you @scalexm!

It would be nice if we could also use associated constants

How about using const fn instead of constants?

Haven't dug into the implementation, but it's not clear - can you modify these at runtime? Either way I would add a test for the expected behavior if you try to assign a value to it.
Also, it's not immediately clear: Is the function evaluated when the class is constructed, or every time it is accessed?

Haven't dug into the implementation, but it's not clear - can you modify these at runtime? Either way I would add a test for the expected behavior if you try to assign a value to it.
Also, it's not immediately clear: Is the function evaluated when the class is constructed, or every time it is accessed?

In the current implementation, we just set the variable to type(PyClass).__dict__ once when the type object is created.

About returning an error
Is there any use case where we need to return an error from attribute? If not, I think we should restrict the return type to IntoPy<PyObject>.

About naming
attribute is not so bad, but aren't they called class variable in Python?
How about #[classvar]?

Can these things ever be settable?
They are settable in Python.
But since in Rust, we need to use Cell/RefCell to share mutable variables and it's not a common pattern. So I don't think we have any strong reason to support setter for it.

It would be nice if we could also use associated constants
Agreed.

Thanks for the reviews.

How about #[classvar]
Yes, that’s probably better. Always called that class attributes but indeed the official Python documentation calls them class variables :)

Is there any use case where we need to return an error from attribute
Python does support it, in which case an exception is raised when the module is imported. It’s indeed not clear how useful it is, so I guess we can disable it for now (only accept IntoPy<PyObject>) and think about it later if someone comes up with a use case.

About using associated constants, I can open a follow-up PR.

It would be nice if we could also use associated constants (which are stable, i8::MAX (not to be confused with std::i8::MAX) is a good example):

Nice, I was so sure they were stable but then when looking at documentation to confirm this last night I got bogged down in the docs for traits xD

They are settable in Python.

If they're settable in Python, but we don't want to allow setting these in Rust, I suggest we make it so that an exception is raised if a user attempts to set these attributes from Python. Otherwise the original Rust value and current Python value may become out of sync?

For comparison, here's what happens with a Cython cdef class defined like so:
cdef class MyClass:
    attr = 3

>>> from mymodule._backend import MyClass
>>> MyClass.attr
3
>>> MyClass.attr = 4
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: can't set attributes of built-in/extension type 'mymodule._backend.MyClass'
>>> MyClass().attr
3
>>> MyClass().attr = 4
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'mymodule._backend.MyClass' object attribute 'attr' is read-only

So it seems like they are called "attributes" and that it is reasonable for them to be read-only in both Python and Rust.
I think #[attribute] or #[classattr] or #[classattribute] are all reasonable spellings. I'm not terribly fond of the idea of #[classvar]. Class scoping in Python is super weird and there may be a distinction between "class variable" and "attribute" that I don't understand.

I think #[attribute] or #[classattr] or #[classattribute] are all reasonable spellings. I'm not terribly fond of the idea of #[classvar]. Class scoping in Python is super weird and there may be a distinction between "class variable" and "attribute" that I don't understand.

Thank you for the feedback.

I suggest we make it so that an exception is raised if a user attempts to set these attributes from Python.

I checked the code that Cython produced and what it does is the same as this PR. They set attr to tp_dict.
  if (PyDict_SetItem((PyObject *)__pyx_ptype_4demo_MyClass->tp_dict, __pyx_n_s_attr, __pyx_int_3) < 0) __PYX_ERR(1, 2, __pyx_L1_error)

But I don't understand how it makes the attr read-only :thinking:

But I don't understand how it makes the attr read-only  ...

Because Python enforces that, for classes defined using the C API that PyO3 uses, type objects can't be changed (I'm assuming since they're shared across all interpreters in the program) and tp_dict is considered part of that type object.

+1 for #[classattr] as my favourite of the names suggested.

Because Python enforces that, for classes defined using the C API that PyO3 uses, type objects can't be changed (I'm assuming since they're shared across all interpreters in the program) and tp_dict is considered part of that type object.

Nice. I guess should make sure there are tests in this PR to verify that trying to modify a classattr raises an exception as described.

Current status:

applied @kngwyu comments: it's cleaner that way, thanks
removed the possibility to return a PyResult: this can always be added later if someone has a use case for it
added a test to showcase that class variables from an extension module are indeed immutable

Next steps:

decide on the name: I personally don't have a strong opinion
add a paragraph to the guide
allow associated constants to define class attributes: I'd prefer to open a separate follow-up PR for that one

Thank you for the update!

decide on the name: I personally don't have a strong opinion

Me too, so the top candidate is #[classattr]?(+1 by @davidhewitt)

add a paragraph to the guide

Yeah, please place some docs in class.md.

allow associated constants to define class attributes: I'd prefer to open a separate follow-up PR for that one

:+1:

I'm happy with any of the options other than #[classvar] since the attributes act like constants, not variables.

LGTM, thank you for the update!


Greenkeeper/lint staged 9.2.1

Closes #22

:tada: This PR is included in version 1.0.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


⚠ Bofrost.lu has degraded performance

In 014d728, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1424 ms

Resolved: Bofrost.lu performance has improved in c98ca0b after 8 minutes.


[nri-kubernetes] Once available support fargate automatic injection

Once available add to helm charts a fargate feature to opt in/out fargate configuration
[Nice to have] Update wizard to have the checkbox for fargate exposed (Even if so far we do not expose any of the options, therefore we should check with FSI first)

Likely the output of the fargate work will be an operator taking care of different task, including injecting the secar, therefore it will be a different component
Keep in mind that will need to provide a way to

[ ] tag the data and the host tag with custom attributes https://github.com/newrelic/nri-kubernetes/issues/84

[ ] configure the sidecar injected through the values, we should make use as much as possible of the same convention of nri-kubernetes

We should make sure we are not deploying the sedecar on fake nodes:
#newrelic-infrastructure:
#  privileged: false
  # tolerations:
  #   - operator: "Exists"
  #     effect: "NoExecute"


[Feature]: frequency_penalties is missing in V1

🚀 The feature, motivation and pitch
I used VLLM_USE_V1=1 and found that the QPS in the chat scene increased by 13%, but the repetition rate increased severely. I found that the V1 version did not seem to implement frequency_penalties. Was the implementation of frequency_penalties removed for performance reasons? I would like to ask whether frequency_penalties will be supported in the V1 version in the future?
Alternatives
No response
Additional context
No response
Before submitting a new issue...

[X] Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.

Thank you for trying it out. This is being worked on indeed and we will announce when V1 is ready for full testing.


Fixed frequently fail after test_04_ConversionPrintingToggle().

A test case on 'LocalPrinting' test suite frequently fails because the print job remaining after exiting test_04_ConversionPrintingToggle().
I added wait for finish the print job before exiting test_04_ConversionPrintingToggle() to fix this issue.

Ok, let's give it a try.

Thank you!


logger instead of print

Codecov Report
Patch and project coverage have no change.

Comparison is base (c3b3a74) 94.44% compared to head (21a516c) 94.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #103   +/-   ##
=======================================
  Coverage   94.44%   94.44%
=======================================
  Files           1        1
  Lines          18       18
=======================================
  Hits           17       17
  Misses          1        1

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Recipe App Kanban Board

Hello 👋🏻
For this project we are a team of 2 (@Alexr16 🦁 & @Retky🦊)
Kanban Board

Hi Team,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
To Highlight 💯

Descriptive information ✔
Tasks are distributed equally ✔

Required Changes ♻

[ ] Kindly provide a description for all tasks as per this requirement. The tests tasks do not have any description.

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Hi Team,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


ci: add github actions workflow

What it does

The commit includes a github actions workflow for the project (in addition to the already existing jenkins build). The workflow will
hopefully help contributors identify issues in prs and cron job sooner.
How to test

The CI should pass:

build
lint

Review checklist

[x] as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

as a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: vince-fugnitto<EMAIL_ADDRESS>

I think this will also help whenever we have issues with Jenkins, like it's the case now, and will be in a couple of weeks when it's down for maintenance. We can then at least hope to have some confidence that we can merge without breaking everything :)

We can add tests when we have a browser version of Blueprint (*), to run them on.
(*) it's being worked-on: https://github.com/eclipse-theia/theia-blueprint/issues/74


Get SST for Newfoundland and WCAnn

@larogers123
Lauren and team will fill in SST data for Newfoundland and WCAnn surveys (these data are missing) using global datasets.

SST now filled in for Newfoundland and WCAnn, as well as for individual hauls where surf temp was missing.


Memory leak in this small example script.

Hi all,
Was able to trace down an issue I was finding in my simulation down to a small example:  https://gist.github.com/bmer/bc578a3b47911a574abe
This script quickly hogs huge amount of my system memory, but my system remains stable unless I try to do something else. Do others find the same? My numba version is: numba: 0.20.0-np19py27_20
Kind regards,
Brian

@seibert @pitrou @sklam are you able to reproduce the memory leak with the script?

@bmer, I can confirm it.

@sklam okay, good to know! I was worried about the lack of response indicating that it was a non-issue for others. Happy to patiently wait now, unless I can contribute in some way!

Fixed by: https://github.com/numba/numba/pull/1295


ISIS-1619 - blob/clob client side caching

Regarding https://issues.apache.org/jira/browse/ISIS-1619
If an action is annotated with any of the NON_IDEMPOTENT semantics, client-side caching is now deactivated for Blob/Clob (download) actions.

I need to rebase this, so closing.


Fixed a blocking by calling it in a go routine

Signed-off-by: ayush.kumar<EMAIL_ADDRESS>Description
Fixed a blocking call to edgex package by calling it in go routine. The startup.Bootstrap(...) call was blocking the control and the code below that was failing to execute.
This call is now made in go routine, so it won't block the execution and code flow will happen normally.
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
$ ./build.sh mnedcserver

MNEDC related code was below the call to startup.Bootstrap(...), it was not getting executed, since the call was blocking.
Test Configuration:

Firmware version: Ubuntu 18.04
Hardware: x86-64

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

@suresh-lc @ayush-kr I will resolve the merge conflict tomorrow morning.

@ayush-kr Please check out the current version with the merged PR #159 if this blocking issue is reproduced.


Question about masked car

Hello, it's a really great job. I have two question:
1)  if you take most of the point cloud of a car in the scene, then can you predict the car?
2)  The first task is to reconstruct a fixed number of point coordinates in every voxel, which is equivalent to getting the coordinates of so many points without any priors, and only by chamfer distance loss?

Hi,
Thanks for your interest!

I am not sure I understand the question. By "predict the car" do you mean predict its location or predict the points corresponding to the car? For the pre-training, we remove most of the point cloud and then ask the network to reconstruct the masked parts. For instance, this could be to reconstruct the point cloud of a car given only parts of the car. For the fine-tuning, we train the model on the entire point cloud and supervise it with regular 3DOD.

The prior for the points are their corresponding voxel centers, e.g., the network predicts the offset for the points within each voxel.


Better IsSubHasChinese for embedded Chinese subtitles or FILENAME.chi.ext or FILENAME.zho.ext

你使用的 chinesesubfinder 是什么版本，什么环境？
chinesesubfinder 版本: v0.18.8
$ sw_vers
ProductName:    macOS
ProductVersion: 11.6

[INFO]: 2021-12-28 18:28:38 - ChineseSubFinder Version: v0.18.8
环境: docker on macOS
你遇到什么问题了？
re-Downloads for movies/tv shows with embedded chinese subtitles  and *.chi/zho.ass.

Cant scan files with  embbed sub
Some videos from NETFLIX or Apple TV, downloaded videos has subtitles embedded on them and usually ships with Chinese, but IsSubHasChinese cant scan them.

Re download with .chi .zho

I previously organize library by setting the Traditional Chinese as .zho.ext and simplfied as .chi.ext so that player and jellyfin can auto recongize subtitles. However, since ChineseSubFinder will automatically skip those 2 encoded files, redownloading of those video will happen.
I checked the code as well as config, it seems that theres no ez way to MARK certain subtitles as Chinese so that it wont re download.
As for naming subtitles, it looks like chi and zho are supported code for chinese but in my setup the scan/downloads were performed anyway.
你的问题弄重现嘛？
能够重新
你期望的结果

Add checking/scanning for embbed subtitles
Prevent searching for movie with movie.chi.ass

可以提供遇到问题时候，电影、连续剧的信息吗？
如下填写
视频的目录: /media/tv/Squid Game (2021) [imdbid-tt10919420]
视频的信息: ./Season 01/Squid Game (2021) - s01e01.mp4
出错的日志信息可以复制一些出来吗？
Both traditional and simplified chinese subtitles can be found using ffmpeg or ffprobe:
$ ffmpeg -i Squid\ Game\ \(2021\)\ -\ s01e01.mkv

#.........
#.........
  Stream #0:36(chi): Subtitle: subrip
    Metadata:
      title           : Simplified
      BPS             : 45
      DURATION        : 00:58:06.357000000
      NUMBER_OF_FRAMES: 648
      NUMBER_OF_BYTES : 19721
      _STATISTICS_WRITING_APP: mkvmerge v61.0.0 ('So') 64-bit
      _STATISTICS_TAGS: BPS DURATION NUMBER_OF_FRAMES NUMBER_OF_BYTES
  Stream #0:37(chi): Subtitle: subrip
    Metadata:
      title           : Traditional
      BPS             : 46
      DURATION        : 00:58:06.357000000
      NUMBER_OF_FRAMES: 648
      NUMBER_OF_BYTES : 20069
      _STATISTICS_WRITING_APP: mkvmerge v61.0.0 ('So') 64-bit
      _STATISTICS_TAGS: BPS DURATION NUMBER_OF_FRAMES NUMBER_OF_BYTES

$ ffprobe -loglevel error -select_streams s -show_entries stream=index:stream_tags=language -of csv=p=0 Squid\ Game\ \(2021\)\ -\ s01e01.mkv
3,kor
# .....
36,chi
37,chi

日志在程序的 Logs 目录下，如果你用的是 docker ，那么需要你映射出来。
[INFO]: 2021-12-30 07:46:37 - 22 DlSub Start /media/tv/Squid Game (2021) [imdbid-tt10919420]
[INFO]: 2021-12-30 07:46:37 - Squid Game IMDB ID: tt10919420 NeedDownloadSubs: 9
[INFO]: 2021-12-30 07:46:37 - S1E9
[INFO]: 2021-12-30 07:46:37 - S1E1
[INFO]: 2021-12-30 07:46:37 - S1E8
[INFO]: 2021-12-30 07:46:37 - S1E3
[INFO]: 2021-12-30 07:46:37 - S1E7
[INFO]: 2021-12-30 07:46:37 - S1E2
[INFO]: 2021-12-30 07:46:37 - S1E6
[INFO]: 2021-12-30 07:46:37 - S1E4
[INFO]: 2021-12-30 07:46:37 - S1E5
[INFO]: 2021-12-30 07:46:37 - 22 shooter Start...
[INFO]: 2021-12-30 07:46:37 - 22 zimuku Start...
[INFO]: 2021-12-30 07:46:37 - 22 xunlei Start...
[INFO]: 2021-12-30 07:46:37 - ZiMuKu Not Find Sub can be download Squid Game 1 8
[INFO]: 2021-12-30 07:46:37 - ZiMuKu Not Find Sub can be download Squid Game 1 3
[INFO]: 2021-12-30 07:46:37 - ZiMuKu Not Find Sub can be download Squid Game 1 7
[INFO]: 2021-12-30 07:46:37 - ZiMuKu Not Find Sub can be download Squid Game 1 9
[INFO]: 2021-12-30 07:46:37 - ZiMuKu Not Find Sub can be download Squid Game 1 1
[INFO]: 2021-12-30 07:46:37 - ZiMuKu Not Find Sub can be download Squid Game 1 6
[INFO]: 2021-12-30 07:46:37 - ZiMuKu Not Find Sub can be download Squid Game 1 4
[INFO]: 2021-12-30 07:46:37 - ZiMuKu Not Find Sub can be download Squid Game 1 5
[INFO]: 2021-12-30 07:46:37 - ZiMuKu Not Find Sub can be download Squid Game 1 2
[INFO]: 2021-12-30 07:46:38 - 22 zimuku End...
[ERROR]: 2021-12-30 07:46:39 - 22 shooter GetSubListFromFile4Series Post "https://www.shooter.cn/api/subapi.php": x509: certificate is valid for shooter.cn, not www.shooter.cn
[INFO]: 2021-12-30 07:46:39 - 22 shooter End...
[INFO]: 2021-12-30 07:46:46 - 22 xunlei End...
[INFO]: 2021-12-30 07:46:46 - 22 DlSub End /media/tv/Squid Game (2021) [imdbid-tt10919420]
[INFO]: 2021-12-30 07:46:46 - OrgSubName: [xunlei]_0_D3A5CE8BF85E99BB7E4B88BE8BDBD5CSquid Game_S1E0.ass
[INFO]: 2021-12-30 07:46:46 - SubDownAt: /media/tv/Squid Game (2021) [imdbid-tt10919420]/Season 01/Squid Game (2021) - s01e04.zh.ass
[INFO]: 2021-12-30 07:46:46 - OrgSubName: [xunlei]_0_Squid Game_S1E3.srt
[INFO]: 2021-12-30 07:46:46 - SubDownAt: /media/tv/Squid Game (2021) [imdbid-tt10919420]/Season 01/Squid Game (2021) - s01e03.zh.srt
[INFO]: 2021-12-30 07:46:47 - OrgSubName: [xunlei]_0_srt_S0E0.srt
[INFO]: 2021-12-30 07:46:47 - SubDownAt: /media/tv/Squid Game (2021) [imdbid-tt10919420]/Season 01/Squid Game (2021) - s01e07.zh.srt
[WARNING]: 2021-12-30 07:46:49 - ReadSeriesInfoFromDir.GetImdbInfo4SeriesDir.strconv.Atoi strconv.Atoi: parsing "": invalid syntax
[ERROR]: 2021-12-30 07:46:50 - model.GetImdbInfo4OneSeriesEpisode XML syntax error on line 1: illegal character code U+0000
[ERROR]: 2021-12-30 07:46:50 - model.GetImdbInfo4OneSeriesEpisode XML syntax error on line 1: illegal character code U+0000
[ERROR]: 2021-12-30 07:46:50 - model.GetImdbInfo4OneSeriesEpisode XML syntax error on line 1: illegal character code U+0000
[ERROR]: 2021-12-30 07:46:50 - model.GetImdbInfo4OneSeriesEpisode XML syntax error on line 2: illegal character code U+0000
[ERROR]: 2021-12-30 07:46:50 - model.GetImdbInfo4OneSeriesEpisode XML syntax error on line 1: illegal character code U+0000
[ERROR]: 2021-12-30 07:46:50 - model.GetImdbInfo4OneSeriesEpisode XML syntax error on line 1: illegal character code U+0000
[ERROR]: 2021-12-30 07:46:50 - model.GetImdbInfo4OneSeriesEpisode XML syntax error on line 1: illegal character code U+0000
[ERROR]: 2021-12-30 07:46:50 - model.GetImdbInfo4OneSeriesEpisode XML syntax error on line 1: illegal character code U+0000
[ERROR]: 2021-12-30 07:46:50 - model.GetImdbInfo4OneSeriesEpisode XML syntax error on line 1: illegal character code U+0000

Add checking/scanning for embbed subtitles

This function can be considered to increase, but the priority is to achieve the caching mechanism of this program, otherwise there will be a large number of read file requests

Prevent searching for movie with movie.chi.ass

I need to confirm whether there is a logical problem with the corresponding local Chinese subtitles scanning function

I also run into a xml parsing issue with episode xml files generated using sonarr. the xml file exmaple:
part of the log
[ERROR]: 2021-12-30 07:50:18 - model.GetImdbInfo4OneSeriesEpisode XML syntax error on line 1: illegal character code U+0000
[ERROR]: 2021-12-30 07:50:18 - model.GetImdbInfo4OneSeriesEpisode XML syntax error on line 1: invalid character entity & (no semicolon)

I am not sure if the sonarr xml parsing did sth or parsed the xml in wrong format as it has happened before where they added a url at the end of the file and I had to change setting and re scan the media library thanks to *arr #124
<episodedetails>
  <title>The Conjugal Configuration</title>
  <season>12</season>
  <episode>1</episode>
  <aired>2018-09-24</aired>
  <plot>Sheldon and Amy’s honeymoon runs aground in New York, while Penny and Leonard discover they are uncomfortably similar to Amy’s parents, Mr. and Mrs. Fowler. Also, Koothrappali insults physicist Neil deGrasse Tyson and starts a Twitter war.</plot>
  <uniqueid type="sonarr" default="true">1598</uniqueid>
  <thumb>https://artworks.thetvdb.com/banners/episodes/80379/6755587.jpg</thumb>
  <watched>false</watched>
  <rating>7.9</rating>
  <fileinfo>
    <streamdetails>
      <video>
        <aspect>1.77777779</aspect>
        <bitrate>3374007</bitrate>
        <codec>x265</codec>
        <framerate>23.976</framerate>
        <height>1080</height>
        <scantype></scantype>
        <width>1920</width>
        <duration>20.609033333333333</duration>
        <durationinseconds>1237</durationinseconds>
      </video>
      <audio>
        <bitrate>352800</bitrate>
        <channels>6</channels>
        <codec>AAC</codec>
        <language>English</language>
      </audio>
      <subtitle>
        <language>English</language>
      </subtitle>
    </streamdetails>
  </fileinfo>
</episodedetails>

@allanpk716 I guess I can git and try testing and modify a bit to check for problem 2. Should be quite ez. But right now I stopped the docker instance just for the time being.
As for problem 1, theres a go lib for ffprobe, could be useful for getting video info. but we can also just invoke ffmpeg in the instance, assuming chinesesubfinder has it installed.
I'll see if I can test it locally on my mac .

I also run into a xml parsing issue with episode xml files generated using sonarr. the xml file exmaple:
part of the log
[ERROR]: 2021-12-30 07:50:18 - model.GetImdbInfo4OneSeriesEpisode XML syntax error on line 1: illegal character code U+0000
[ERROR]: 2021-12-30 07:50:18 - model.GetImdbInfo4OneSeriesEpisode XML syntax error on line 1: invalid character entity & (no semicolon)

I am not sure if the sonarr xml parsing did sth or parsed the xml in wrong format as it has happened before where they added a url at the end of the file and I had to change setting and re scan the media library thanks to *arr #124
<episodedetails>
  <title>The Conjugal Configuration</title>
  <season>12</season>
  <episode>1</episode>
  <aired>2018-09-24</aired>
  <plot>Sheldon and Amy’s honeymoon runs aground in New York, while Penny and Leonard discover they are uncomfortably similar to Amy’s parents, Mr. and Mrs. Fowler. Also, Koothrappali insults physicist Neil deGrasse Tyson and starts a Twitter war.</plot>
  <uniqueid type="sonarr" default="true">1598</uniqueid>
  <thumb>https://artworks.thetvdb.com/banners/episodes/80379/6755587.jpg</thumb>
  <watched>false</watched>
  <rating>7.9</rating>
  <fileinfo>
    <streamdetails>
      <video>
        <aspect>1.77777779</aspect>
        <bitrate>3374007</bitrate>
        <codec>x265</codec>
        <framerate>23.976</framerate>
        <height>1080</height>
        <scantype></scantype>
        <width>1920</width>
        <duration>20.609033333333333</duration>
        <durationinseconds>1237</durationinseconds>
      </video>
      <audio>
        <bitrate>352800</bitrate>
        <channels>6</channels>
        <codec>AAC</codec>
        <language>English</language>
      </audio>
      <subtitle>
        <language>English</language>
      </subtitle>
    </streamdetails>
  </fileinfo>
</episodedetails>

Can you just upload the XML file? When this program reads these files, it makes a guess at the encoding and then transcodes, which is probably caused by this part. At present, no good solution has been found to solve the problem of file coding. If it is UTF-8, it is easy to manage, and other failure rates are relatively high.

Yep, trying to upload it beforfe but gh doesnt support nfo file... I zipped it uploaded now.
example_episode_nfo.zip

problem 1:
If this feature is implemented, additional Settings will have to be given to the user to choose from. For example, in fact, many Chinese users like the function of Chinese and English subtitles, not because there are built-in subtitles, they want to skip the subtitles download, so there should be additional Settings. More inclined to let the general user hang up to use the program, rather than entanglement and Settings and selection of the program's functions.
It will also be guided on the Web interface to let users choose the environment suitable for their use, which will automatically help them to configure, but not so fast, first wait for friends to make the Web.

Yep the first problem is indeed more of a personal preference thing that
should be placed in settings.
A brief example/explanation should be added since a lot of users would
still prefer chi&eng.ass over the embedded ones, myself included.
Apart for that, maybe more setting can be set in the future as some users
have manually downloaded and curated for their collection and preferred not
to update.
Like Friends and Seinfeld tv shows I have. I have manually downloaded
before and selected the best ones, would rlly just leave that part alone.
Kind of like the monitoring /unmonitored settings in sonarr and radarr
On Thu, 30 Dec 2021 at 12:08, Chin allan @.***> wrote:

problem 1:
If this feature is implemented, additional Settings will have to be given
to the user to choose from. For example, in fact, many Chinese users like
the function of Chinese and English subtitles, not because there are
built-in subtitles, they want to skip the subtitles download, so there
should be additional Settings. More inclined to let the general user hang
up to use the program, rather than entanglement and Settings and selection
of the program's functions.
It will also be guided on the Web interface to let users choose the
environment suitable for their use, which will automatically help them to
configure, but not so fast, first wait for friends to make the Web.
—
Reply to this email directly, view it on GitHub
https://github.com/allanpk716/ChineseSubFinder/issues/139#issuecomment-1002981437,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGQJ5MDLWD3MHVTJU5D52VLUTQ4RHANCNFSM5K7PNEFA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Yep the first problem is indeed more of a personal preference thing that should be placed in settings. A brief example/explanation should be added since a lot of users would still prefer chi&eng.ass over the embedded ones, myself included. Apart for that, maybe more setting can be set in the future as some users have manually downloaded and curated for their collection and preferred not to update. Like Friends and Seinfeld tv shows I have. I have manually downloaded before and selected the best ones, would rlly just leave that part alone. Kind of like the monitoring /unmonitored settings in sonarr and radarr

There should be no need to worry about this situation. Generally speaking, as long as your video has external Chinese subtitles under it, and the video has been published for two years, it will be skipped.

Yep, trying to upload it beforfe but gh doesnt support nfo file... I zipped it uploaded now.
example_episode_nfo.zip

There is no problem with this file you uploaded, I see your fault log is about 《Squid Game (2021)》, There is no problem with this file you uploaded, I see your fault log is about

Yep, trying to upload it beforfe but gh doesnt support nfo file... I zipped it uploaded now.
example_episode_nfo.zip

There is no problem with this file you uploaded, I see your fault log is about 《Squid Game (2021)》, There is no problem with this file you uploaded, I see your fault log is about

There are many cases I saw that error I just picked one and uploaded, Heres another with TV shows, weird enough, in this case, the .chi.ass were recongized and skipped downloads, still with the xml parsing error tho.
[WARNING]: 2021-12-30 07:37:41 - IsSubHasChinese.DetermineFileTypeFromFile /media/tv/American Crime Story (2016) [imdbid-tt2788432]/Backup/._American Crime Story (2016) - s03e01.chi.ass not support SubType
[WARNING]: 2021-12-30 07:37:41 - IsSubHasChinese.DetermineFileTypeFromFile /media/tv/American Crime Story (2016) [imdbid-tt2788432]/Backup/._American Crime Story (2016) - s03e02.chi.ass not support SubType
[WARNING]: 2021-12-30 07:37:41 - IsSubHasChinese.DetermineFileTypeFromFile /media/tv/American Crime Story (2016) [imdbid-tt2788432]/Backup/._American Crime Story (2016) - s03e03.chi.ass not support SubType
[WARNING]: 2021-12-30 07:37:41 - IsSubHasChinese.DetermineFileTypeFromFile /media/tv/American Crime Story (2016) [imdbid-tt2788432]/Backup/._American Crime Story (2016) - s03e04.chi.ass not support SubType
[WARNING]: 2021-12-30 07:37:41 - IsSubHasChinese.DetermineFileTypeFromFile /media/tv/American Crime Story (2016) [imdbid-tt2788432]/Backup/._American Crime Story (2016) - s03e05.chi.ass not support SubType
[WARNING]: 2021-12-30 07:37:41 - IsSubHasChinese.DetermineFileTypeFromFile /media/tv/American Crime Story (2016) [imdbid-tt2788432]/Backup/._American Crime Story (2016) - s03e06.chi.ass not support SubType
[WARNING]: 2021-12-30 07:37:41 - IsSubHasChinese.DetermineFileTypeFromFile /media/tv/American Crime Story (2016) [imdbid-tt2788432]/Backup/._American Crime Story (2016) - s03e07.chi.ass not support SubType
[WARNING]: 2021-12-30 07:37:41 - IsSubHasChinese.DetermineFileTypeFromFile /media/tv/American Crime Story (2016) [imdbid-tt2788432]/Backup/._American Crime Story (2016) - s03e08.chi.ass not support SubType
[WARNING]: 2021-12-30 07:37:41 - IsSubHasChinese.DetermineFileTypeFromFile /media/tv/American Crime Story (2016) [imdbid-tt2788432]/Backup/._American Crime Story (2016) - s03e09.chi.ass not support SubType
[WARNING]: 2021-12-30 07:37:43 - IsSubHasChinese.DetermineFileTypeFromFile /media/tv/American Crime Story (2016) [imdbid-tt2788432]/Season 03/._American Crime Story (2016) - s03e01.chi.ass not support SubType
[WARNING]: 2021-12-30 07:37:43 - IsSubHasChinese.DetermineFileTypeFromFile /media/tv/American Crime Story (2016) [imdbid-tt2788432]/Season 03/._American Crime Story (2016) - s03e02.chi.ass not support SubType
[WARNING]: 2021-12-30 07:37:43 - IsSubHasChinese.DetermineFileTypeFromFile /media/tv/American Crime Story (2016) [imdbid-tt2788432]/Season 03/._American Crime Story (2016) - s03e03.chi.ass not support SubType
[WARNING]: 2021-12-30 07:37:43 - IsSubHasChinese.DetermineFileTypeFromFile /media/tv/American Crime Story (2016) [imdbid-tt2788432]/Season 03/._American Crime Story (2016) - s03e04.chi.ass not support SubType
[WARNING]: 2021-12-30 07:37:43 - IsSubHasChinese.DetermineFileTypeFromFile /media/tv/American Crime Story (2016) [imdbid-tt2788432]/Season 03/._American Crime Story (2016) - s03e05.chi.ass not support SubType
[WARNING]: 2021-12-30 07:37:43 - IsSubHasChinese.DetermineFileTypeFromFile /media/tv/American Crime Story (2016) [imdbid-tt2788432]/Season 03/._American Crime Story (2016) - s03e06.chi.ass not support SubType
[WARNING]: 2021-12-30 07:37:43 - IsSubHasChinese.DetermineFileTypeFromFile /media/tv/American Crime Story (2016) [imdbid-tt2788432]/Season 03/._American Crime Story (2016) - s03e07.chi.ass not support SubType
[WARNING]: 2021-12-30 07:37:43 - IsSubHasChinese.DetermineFileTypeFromFile /media/tv/American Crime Story (2016) [imdbid-tt2788432]/Season 03/._American Crime Story (2016) - s03e08.chi.ass not support SubType
[WARNING]: 2021-12-30 07:37:43 - IsSubHasChinese.DetermineFileTypeFromFile /media/tv/American Crime Story (2016) [imdbid-tt2788432]/Season 03/._American Crime Story (2016) - s03e09.chi.ass not support SubType
[ERROR]: 2021-12-30 07:37:44 - model.GetImdbInfo4OneSeriesEpisode XML syntax error on line 1: illegal character code U+0000
[ERROR]: 2021-12-30 07:37:44 - model.GetImdbInfo4OneSeriesEpisode XML syntax error on line 1: illegal character code U+0000
[ERROR]: 2021-12-30 07:37:44 - model.GetImdbInfo4OneSeriesEpisode XML syntax error on line 1: illegal character code U+0000
[ERROR]: 2021-12-30 07:37:44 - model.GetImdbInfo4OneSeriesEpisode XML syntax error on line 1: illegal character code U+0000
[ERROR]: 2021-12-30 07:37:44 - model.GetImdbInfo4OneSeriesEpisode XML syntax error on line 1: illegal character code U+0000
[ERROR]: 2021-12-30 07:37:44 - model.GetImdbInfo4OneSeriesEpisode XML syntax error on line 1: illegal character code U+0000
[ERROR]: 2021-12-30 07:37:44 - model.GetImdbInfo4OneSeriesEpisode XML syntax error on line 1: illegal character code U+0000
[ERROR]: 2021-12-30 07:37:44 - model.GetImdbInfo4OneSeriesEpisode XML syntax error on line 1: illegal character code U+0000
[ERROR]: 2021-12-30 07:37:44 - model.GetImdbInfo4OneSeriesEpisode XML syntax error on line 1: illegal character code U+0000
[ERROR]: 2021-12-30 07:37:44 - model.GetImdbInfo4OneSeriesEpisode XML syntax error on line 1: illegal character code U+0000
[INFO]: 2021-12-30 07:37:44 - Skip because find sub file and downloaded or aired over 3 months, American Crime Story 3 3
[INFO]: 2021-12-30 07:37:44 - Skip because find sub file and downloaded or aired over 3 months, American Crime Story 3 4
[INFO]: 2021-12-30 07:37:44 - Skip because find sub file and downloaded or aired over 3 months, American Crime Story 3 1
[INFO]: 2021-12-30 07:37:44 - Skip because find sub file and downloaded or aired over 3 months, American Crime Story 3 2
[INFO]: 2021-12-30 07:37:44 - 0 DlSub Start /media/tv/American Crime Story (2016) [imdbid-tt2788432]
[INFO]: 2021-12-30 07:37:44 - American Crime Story IMDB ID: tt2788432 NeedDownloadSubs: 6
[INFO]: 2021-12-30 07:37:44 - S3E5
[INFO]: 2021-12-30 07:37:44 - S3E7
[INFO]: 2021-12-30 07:37:44 - S3E8
[INFO]: 2021-12-30 07:37:44 - S3E10
[INFO]: 2021-12-30 07:37:44 - S3E6
[INFO]: 2021-12-30 07:37:44 - S3E9
[INFO]: 2021-12-30 07:37:44 - 0 shooter Start...
[INFO]: 2021-12-30 07:37:44 - 0 zimuku Start...
[INFO]: 2021-12-30 07:37:44 - 0 xunlei Start...
[ERROR]: 2021-12-30 07:37:47 - 0 shooter GetSubListFromFile4Series Post "https://www.shooter.cn/api/subapi.php": x509: certificate is valid for shooter.cn, not www.shooter.cn
[INFO]: 2021-12-30 07:37:47 - 0 shooter End...
[INFO]: 2021-12-30 07:37:48 - 0 xunlei End...
[INFO]: 2021-12-30 07:37:53 - 0 zimuku End...
[INFO]: 2021-12-30 07:37:53 - 0 DlSub End /media/tv/American Crime Story (2016) [imdbid-tt2788432]
[ERROR]: 2021-12-30 07:37:56 - model.GetImdbInfo4OneSeriesEpisode XML syntax error on line 1: illegal character code U+0000
[ERROR]: 2021-12-30 07:37:56 - model.GetImdbInfo4OneSeriesEpisode XML syntax error on line 1: illegal character code U+0000
[ERROR]: 2021-12-30 07:37:56 - model.GetImdbInfo4OneSeriesEpisode XML syntax error on line 1: illegal character code U+0000
[ERROR]: 2021-12-30 07:37:56 - model.GetImdbInfo4OneSeriesEpisode XML syntax error on line 1: illegal character code U+0000
[ERROR]: 2021-12-30 07:37:56 - model.GetImdbInfo4OneSeriesEpisode XML syntax error on line 1: illegal character code U+0000
[ERROR]: 2021-12-30 07:37:56 - model.GetImdbInfo4OneSeriesEpisode XML syntax error on line 1: illegal character code U+0000
[ERROR]: 2021-12-30 07:37:56 - model.GetImdbInfo4OneSeriesEpisode XML syntax error on line 1: illegal character code U+0000
[ERROR]: 2021-12-30 07:37:56 - model.GetImdbInfo4OneSeriesEpisode XML syntax error on line 1: illegal character code U+0000
[ERROR]: 2021-12-30 07:37:56 - model.GetImdbInfo4OneSeriesEpisode XML syntax error on line 1: invalid character entity &� (no semicolon)

tmp.zip

There is no problem with the test of this batch of files. It is estimated that the log did not print out which file was read, so it is not convenient for you to find the specific file. I updated the print of this partial log. 😂


Add TorchTRTConversion pass

Describe your changes
This PR adds TorchTRTConversion pass which converts nn.Linear modules in transformer layers to TRTModule from torch-tensorrt. torch-tensorrt is an extension to torch where TensorRT engines can be used like normal nn.Module.
We require this conversion to take advantage of 2:4 sparsity.
I have not added unit test for the pass since the pass requires GPU and we don't have GPU support for ci tests yet. I will add a unit test in a follow up PR that uses aml system to run the pass and evaluation on GPU.
Checklist before requesting a review

[ ] Add unit tests for this change.
[ ] Make sure all tests can pass.
[x] Update documents if necessary.
[x] Format your code by running pre-commit run --all-files
[ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes.
Add TorchTRTConversion pass.

(Optional) Issue link

I think you might mean integration test to test TRTConversion. Is it possible that mock compile_trt_model to test the logic in the TorchTRTConversion in unit test?

I think you might mean integration test to test TRTConversion. Is it possible that mock compile_trt_model to test the logic in the TorchTRTConversion in unit test?

I wasn’t sure if it would fall under integration test if we use aml system + pass.
Yes, I can mock the function. That sounds like a good idea since that’s the only one that requires gpu. I can probably mock the cuda related code too.