Fix unexpected feature enabling by AutoResetWidth

First, thank you for your great plugin. It's very helpful.
I found that this feature is unexpectedly enabled on help file by AutoResetWidth. This is caused because help files have modeline that sets shiftwidth or tabstop buffer locally, and AutoResetWidth just refers to b:indentLine_enabled and g:indentLine_enabled, but not filter settings. In other cases, just typing :set shiftwidth=4 can cause the same issue. And this probably be the same issue as #306.
I've created my fix. Could you merge this if it looks good?
How to fix: When b:indentLine_enabled doesn't exist and g:indentLine_enabled == 1, refer to s:Filter() instead of the value itself.
CC: @matveyt, @Mike325

Ahh, #297, #298 and #301 might be the same issues.

Thanks.


[CSL-482] Make possible to send HeadersRequest not only from ResponseMode

@zvoit
Needed for https://issues.serokell.io/issue/CSL-464

@georgeee
Postponed till CSL-447

@georgeee
Was done as implicit part of CSL-447 changes


Design view breaks when there is a fork-join statement

Description:
Design view fails to render when there is a fork-join statement.
Steps to reproduce:
Use the following code snippet
import ballerina.io;
function main (string[] args) {
    fork {
        worker w1 {
            int i = 23;
            string s = "Colombo";
            io:println("[w1] i: " + i + " s: " + s);
            i, s -> fork;
        }
        worker w2 {
            float f = 10.344;
            io:println("[w2] f: " + f);
            f -> fork;
        }
    } join (all) (map results) {
        var resW1, _ = (any[])results["w1"];
        var iW1, _ = (int)resW1[0];
        var sW1, _ = (string)resW1[1];
        io:println("[join-block] iW1: " + iW1 + " sW1: " + sW1);
        var resW2, _ = (any[])results["w2"];
        var fW2, _ = (float)resW2[0];
        io:println("[join-block] fW2: " + fW2);
    }
}

Please make sure the sample you mentioned above require enhancement. We need real world fork-join samples. Refer mail thread "[Clarification] Fork-Join not working and Composer issues (ballerina-tools-0.962.0)"
The sample I have tired in mail thread didn't work thus we need to fix runtime regression too.


Use Ansi Color Codes for ColoredConsoleTarget on Linux/.Net Core

Hi there,
Thanks a lot for already providing a beta for .Net Core RC2. It already works pretty cool!
I would love to use the ColoredConsoleTarget on Linux. Unfortunately the output is on my Linux box identical with the normal ConsoleTarget, thus no colors. I guess because Console.ForegrondColor and friends are quite different on Linux, of even not implemented on those platforms. Looking at Microsoft's own Aspnet Core Logger they make a distinction between Windows and Non-windows. On Non-Windows they use the regular System.Console class too, but use Ansi Color codes as message prefix instead of using Console.ForegrondColor. See here https://github.com/aspnet/Logging/blob/dev/src/Microsoft.Extensions.Logging.Console/Internal/AnsiLogConsole.cs and https://github.com/aspnet/Logging/blob/dev/src/Microsoft.Extensions.Logging.Console/ConsoleLogger.cs.
Probably Nlog should do something similar. I guess using Ansi Color Code is also slightly faster..
Regards and thanks a lot for your work.
Jens

Good idea, although there a some issues with the console logger in AspNet Core:
See https://github.com/aspnet/Logging/issues/281 and https://github.com/aspnet/Logging/issues/428

Thank you for your response. I have played a little bit and this is my result so far https://github.com/NLog/NLog/compare/coreCLR...jp7677:coreCLR. Works fine on my Linux box ;)
Would you be interested in a pull request if I add the missing color codes and have finished the Word highlighting? Though first I need to understand whats happening in the word highlighting code..
Regarding both issues you linked to: Well, the docker boys could use the normal ConsoleTarget or wait till the docker extension in Visual Studio is fixed. The other issue about the colors on Mac is not clear to me. We could use the ansi codes on Linux only.

Ok, after playing a little bit more it seems like dotnet does some different magic with my Linux terminal when running "dotnet run" compared to "dotnet ". It seems like the original ColoredConsoleTarget works fine when using "dotnet ", but not when doing "dotnet run". Although my version does some colors on "dotnet run" and works fine with "dotnet ". I'll research a bit more and post my results.
PS: The platform detection code in PlatformDetector isn't woking for me. Eventually you could consider this snippet instead:
`
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
return RuntimeOS.Windows;
else if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
return RuntimeOS.Unix;
else if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux))
return RuntimeOS.Unix;
return RuntimeOS.Unknown;
`

Ok, after playing a little bit more it seems like dotnet does some different magic with my Linux terminal when running "dotnet run" compared to "dotnet [entry assembly]". It seems like the original ColoredConsoleTarget works fine when using "dotnet [entry assembly]", but not when doing "dotnet run".

That's strange. So for now keep it like this?

PS: The platform detection code in PlatformDetector isn't woking for me, Microsoft.Extensions.PlatformAbstractions.PlatformServices.Default?.Runtime?.OperatingSystem return "fedora" in my case

AFAIK the  RuntimeInformation is newer and better? I think it's wise to move to RuntimeInformation then. Can you send a PR for it?

See https://github.com/NLog/NLog/pull/1488.

Regarding the colors, yes, see this screenshot made with simple Console.Write statements.

It seems like ansi escape codes and using Console.ForegroundColor/BackgroundColor do work fine when running dotnet [assembly]. One remark, using ansi escape codes seems somewhat better with backgroundcolors and line endings, this is unfortunately not visible in the screenshot.
Although when using "dotnet run" with Console.ForegroundColor/BackgroundColor I see no colors at all and with ansi escape codes I see just the non-bright/normal colors but not the bright ones (see https://en.wikipedia.org/wiki/ANSI_escape_code#Colors).
To summarize, using ansi escape codes are certainly an improvement, but still not perfect.

What would you prefer? Keep the current version or should I give a shot to get the word highlighting working with escape codes too so that it could end up in a PR?

If you think it's an improvement,  then please send a PR!  :+1:

I'm working on it ;)

:)

Please see https://github.com/NLog/NLog/pull/1495.
I gave it a try, i'm curious about your feedback.

Please note that the original coorizer works fine now using dotnet core 1.0 RTM. I still think that my implementation is more efficient, but from a functional point of view its not really really needed anymore. Though at least for Net Core on Linux. Don't know about other target platforms.

Thanks for the info.  If this isn't really adding functionality, it's I guess unwise to merge it (because of maintenance and added complexity) . What do you think?

Well, not sure. The output from both colorizers do look identical. Performance could be reason to merge. Running:
System.Diagnostics.Stopwatch watch = new System.Diagnostics.Stopwatch();
watch.Start();
for (var i = 0; i <= 100000; i++)
{
  logger.Trace("Do some trace logging....");
  logger.Debug("Do some debug logging....");
  logger.Info("Do some info logging....");
  logger.Warn("Do some warn logging....");
  logger.Error("Do some error logging....");
  logger.Fatal("Do some fatal logging....");
}
watch.Stop();
logger.Info("Total: {0}.", watch.ElapsedMilliseconds);

with the following nlog.config
<target name="console" xsi:type="ColoredConsole" layout="${longdate} ${pad:padding=5:inner=-${level}-} ${message}"
            useDefaultRowHighlightingRules="false" >
  <highlight-row condition="level==LogLevel.Trace" foregroundColor="Gray" />
  <highlight-row condition="level==LogLevel.Debug" foregroundColor="DarkGray" />
  <highlight-word text="-Info-"  foregroundColor="DarkGreen" />
  <highlight-word text="-Warn-"  foregroundColor="DarkYellow" />
  <highlight-word text="-Error-"  foregroundColor="DarkMagenta" />
  <highlight-word text="-Fatal-"  foregroundColor="DarkRed" backgroundColor="White"/>
</target>

Gives me the following results:
Original implementation:
Total: 25287.
Total: 25560.
Total: 27182.
Using AnsiColorizer:
Total: 18946.
Total: 18208.
Total: 17576.
Furthermore the AnsiColorizer is nicely unit tested. But obviously I'm a little bit biased with this question :).

Hi there, any idea how to proceed?

Looking at this thread https://github.com/dotnet/cli/issues/1977, seems like the Windows Command Prompt knows about ansi colors in windows 10 1511+. Seems like it is not that easy to detect if you got a windows prompt at that level, but eventually this will get easier in the future so that the unix way of doing things could get the standard way to go. Having the ansi color implementation already in the field for unix based platforms would give us some valuable feedback before the windows people are switching to it. (Not that I'm currently aware of any problems in the AnsiColorizer ;) )

Hey, too bad I haven't found time to look into it. Because it doesn't fix an issue, it had also low prio

No worries and completely understandable, please take your time. Sorry for pushing a little bit, just curious what you are going to do ;).

:+1: thanks

I had moved to SeriLog some time ago (that fits my target somewhat better, net core on Linux), so there is no demand from my side anymore.

Created #3018 for resolving this in the next release NLog ver. 4.6


Optimize JsonExtract.extract

Avoid creating unnecessary Exception objects. This accounts for > 5% of
worker CPU time for my query

looks good


[C++][FlightRPC] Async Flight: GetFlightInfo implementation

Describe the enhancement requested
This is a first step towards async Flight APIs. The first task will be to implement async GetFlightInfo (client-side) only, and work out the approach to client APIs. In follow-on tasks we will implement the rest of the metadata calls, then the data calls.
Component(s)
C++, FlightRPC

Any plan to implement the rest APIs? @lidavidm

It's unlikely. I have not much time now and I would prefer to explore a situation that exposes the underlying gRPC APIs instead of trying to re-wrap them.


How can we stop logging in unified service desk

I want to disable the logs creation inside folder located at AppData\Roaming\Microsoft\Microsoft Dynamics® 365 Unified Service Desk\<IP_ADDRESS>3.Is there any way out to stop creating unified service desk logs?

Hello @Pankaj-Pathania
Please see if the information available at the following topic helps you disable logging:
Configure Unified Service Desk client diagnostic logging
Please let know if this is useful or not.
Apologies for not being able to respond earlier than this.
Thank you.
Neeraja

@Pankaj-Pathania,
I hope that your query was resolved. Please let me know if I can close this issue.
Thank you.

Closing the issue as no response came from the user.


[Leaflet] Error during installation

Module build failed: Module not found:
"./vendor/symfony/ux-leaflet-map/assets/dist/map_controller.js" contains a reference to the file "@symfony/ux-map/abstract-map-controller".
This file can not be found, please check it for typos or update it if the file got moved.
"./vendor/symfony/ux-leaflet-map/assets/dist/map_controller.js" contains a reference to the file "leaflet/dist/leaflet.min.css".
This file can not be found, please check it for typos or update it if the file got moved.

Hi, how did you installed UX Map Leaflet? Did you install UX Map aswell?

Hi, how did you installed UX Map Leaflet? Did you install UX Map aswell?

That's right, I installed both libraries - I'm struggling with this again. Either I don't know something, or the error comes from the first line in the map_controllers.js file
import AbstractMapController from '@symfony/ux-map/abstract-map-controller';
should be
import AbstractMapController from '@symfony/ux-map/abstract_map_controller';
Works for me.

Ah, looks like you are not using Symfony AssetMapper/ImportMap but Webpack Encore?
The component is experimental, so we can break things without worries.
We will need to update the following lines to use @symfony/ux-map/abstract_map_controller yep:

https://github.com/symfony/ux/blob/2.x/src/Map/assets/package.json#L12
https://github.com/symfony/ux/blob/2.x/src/Map/src/Bridge/Leaflet/assets/src/map_controller.ts#L1-L2
https://github.com/symfony/ux/blob/2.x/src/Map/src/Bridge/Google/assets/src/map_controller.ts#L10-L11

👍 from me on this. I'm also using Encore and running into the same issue. I tried editing the referenced files locally but didn't have any luck (I'm not a big JS type).

Ah, looks like you are not using Symfony AssetMapper/ImportMap but Webpack Encore?
The component is experimental, so we can break things without worries.
I think we will need to update the following lines to use @symfony/ux-map/abstract_map_controller:
* https://github.com/symfony/ux/blob/2.x/src/Map/assets/package.json#L12

* https://github.com/symfony/ux/blob/2.x/src/Map/src/Bridge/Leaflet/assets/src/map_controller.ts#L1-L2

* https://github.com/symfony/ux/blob/2.x/src/Map/src/Bridge/Google/assets/src/map_controller.ts#L10-L11

Still doesn't seem to work. The following does, but I'm not sure if it's compatible with AssetMapper:
import AbstractMapController from '@symfony/ux-map';

I think we have a way to handle both WebpackEncore and AssetMapper syntax/descriptor :
https://github.com/symfony/ux/blob/2a177d6bd6899f1fd0c965e317840c94fdb7762d/src/LiveComponent/assets/package.json#L11-L28

I believe this is how we allow import LiveComponent from "@symfony/ux-live-component"
The other way could be to inline the abstract class during compilation/bundling ?
see: https://symfony.com/bundles/ux-live-component/current/index.html#working-with-the-component-in-javascript

I'm also facing this issue using symfony/ux-google-map and webpack encore.
Like @principis said, if i change the import statement from @symfony/ux-google-map/dist/map_controller.js
from
import AbstractMapController from '@symfony/ux-map/abstract-map-controller';

to
import AbstractMapController from '@symfony/ux-map';

it works
any suggestions?
thanks in advance

I will take a look

Good news are coming 🤩

PR opened #2199


Add --cfg fuzzing_repro when reproducing a crash

This makes it possible to leave large or expensive debug output in your fuzzers since it will only be active when you reproduce a crash:
#[cfg(fuzzing_repro)]
eprintln!("Expensive debug output: {}", do_something_expensive());

Fixes #343.

LGTM. I don't have a better naming suggestion than fuzzing_repro.

Thanks for merging the PR, I hope it'll be useful to people. I was also not sure what to name this, but I think @Manishearth's suggestion should work okay.


Add getLocalFileSystem API

As discussed here https://github.com/facebookincubator/velox/discussions/8071, enforce a non-null configuration is passed to the getFileSystem API call.
Add getLocalFileSystem API and use it where a local file is expected to be used.

@mbasmanova, @xiaoxmeng Can you provide feedback on this? Thanks!

I am wondering can we pass the per-query session properties to per-file options? Why we have to create one filesystem instance per each session properties setting? The filesystem is just an software abstraction.  We just need a path prefix (or file scheme) to dispatch the fs call to a particular fs module to serve the request .....

Based on your explanation, I am guessing your file scheme has the endpoint and other config encoded.
I also assume each user specifies the credentials/config via session properties.

The config passed to file system instance could be common to all the internal file system instances
This is not possible for S3 where the endpoint defines a filesystem. So there has to be a separation at the file system level.

Can you confirm how the file scheme, endpoint, credentials work for the Meta's file system?


The selection rectangle is barely visible on some tiles

Godot version:

cb82442
Issue description:

I have a tileset with blue tiles and the selection rectangle for alternate tiles seems to be of similar color. The result is this:

(seems to depend on screen color settings)
I think the rectangle should be thicker, or better, bicolored.

Ah.
Well, the idea was that it would take as selection color the opposite of the one of the grid, but thinking about it it was kind of dumb (as if you choose a color quite different from your tiles' one, you don't want to have it as a seleciton color).
I am not really sure what to do about it though, maybe it should simply choose a similar color instead, or maybe make them both configurable.

I'd just make the selection much more prominient. Here's example from RPG Maker:

Yeah, I thought about that. But if I am not mistaking, it's hard in Godot to draw several rect inside of each other (to make the black/white/black pattern), the precision issues could lead to gaps between the lines.
Though maybe I could draw a 9-patch rect for that though, I'm not sure. It's something to try I guess.


When removing row data, heightOfTallestItemInCurrentRow is always zero.

Describe the bug
When removing row data that indexInCurrentRow is more bigger than 0, heightOfTallestItemInCurrentRow is always 0.
So if i remove row that is 3 in MagazineLayout Example, layout cause error.
Screenshots

Thanks again for your contributions @youkchansim! A variation of your PR has been merged and the version has been bumped to 1.4.2 🙂


remove temporary EFS

fixes #2568

[x] descriptive statistics
[x] HF datasets
[x] duckdb index (only for workers)

Maybe make sure when deploying that the HF_DATASETS_CACHE (which is now the datasets default value at ~/.cache/huggingface/datasets) is a place that have read/write permissions ?

It will be a subdirectory of /tmp/hf-datasets-cache

Merging


wrong label translation:把招工广告

help wanted mean “需要帮助” in Chinese,Google translator is wrong, Bing translator is correct but have a grammatical mistake:)

谢谢


R-lesson: use zenodo link for input dataset and import to R by url

since this works the same for both Rstudio in Galaxy and in Cloud
ping @erasche

Will merge later, sleep well and good luck tomorrow!

ok, thanks @bgruening


Table names bug

This commit refactors the respond method in ai/tools.py to allow for table names that may contain a URL.
Resolves #853

The refactor allows for table names to be URLs

This allows for a user to run the following at the command line.
lumen-ai serve "https://datasets.holoviz.org/penguins/v1/penguins.csv" --provider llama --show

Refactored and changed the source and table separator to <->.

I think you need to find and replace all across the entire repo.

Resolved the merge conflict. Will auto merge once tests pass.


Make it easier to check for Pagination

Hi!
I'm currently working on adding the page number of the current page to the title, meta-description, breadcrumb and h1 and use it in rel-prev/next links.
To do so I create a paginator on the homepage and on taxonomy pages. I than tried to check for the created paginator and than append the page number. The code looked like this:
<head>
	<meta charset="utf-8">
	<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=5">
	<!-- create paginatior if possible and use it for title, description, proper rel canonical, prev and next -->
	{{ if and (ne .Params.ot_showlist false) (or (eq .Kind "home") (eq .Kind "taxonomy")) }}{{ $paginator := .Paginate (where .Pages ".Params.ot_showinlist" "ne" false) }}{{end}}
	<title>
		{{- if .Params.ot_seo_title -}}{{.Params.ot_seo_title}}{{- else if .Title -}}{{ .Title }}{{- else -}}{{ .Site.Title }}{{- end -}}
		{{if (and .Paginator (gt .Paginator.PageNumber 1)) }} - {{ T "page" }} {{ .Paginator.PageNumber }}{{ end }}
	</title>

This works on the homepage and on taxonomy pages. However it does not work on other page types where paginator is not supported:

This means that the template code checking for a paginator needs two if conditions and becomes kind of messy:
{{ if (or (eq .Kind "home") (eq .Kind "taxonomy")) }}{{if (and .Paginator (gt .Paginator.PageNumber 1)) }} - {{ T "page" }} {{ .Paginator.PageNumber }}{{ end }}{{ end }}

I would love to see a simpler approach for this. Do I miss something?
Best regards
Tobias

You can do if .IsNode (or even if not .IsPage) which will return true if the current page supports pagination.
When the above returns true you are on your own, so to speak. I don't think we can provide more information, as that will create a catch 22 situation: You need to create a paginator before it exists, and only you know if you ... want one (so this construct of yours doesn't make sense: if (and .Paginator (gt .Paginator.PageNumber 1)).

Thanks for pointing this out. I was not aware that .IsNode and .IsPage implied that pagination is always supported or never supported. In my mindset there is also the possibility to have paginated articles. ;-)


FreeBSD compile

engraver does not compile
cargo run returns:
error: failed to run custom build command for `sys-info v0.5.6`
process didn't exit successfully: `/usr/home/admin/engraver/target/debug/build/sys-info-f8ac6bb10e9bb895/build-script-build` (exit code: 101)
--- stderr
thread 'main' panicked at 'unsupported system: freebsd', /root/.cargo/registry/src/github.com-1ecc6299db9ec823/sys-info-0.5.6/build.rs:17:14
note: Run with `RUST_BACKTRACE=1` for a backtrace.

warning: build failed, waiting for other jobs to finish...
error: build failed

Don't have programming skills but could help building/testing on FreeBSD


Remove 3rd party repositories

all dependencies  should be available in Maven Central
or JBoss Public repository. Tried with -Dfull and empty
local maven repo and everything builds successfully.

We should not use any third party repos to ensure builds are reproducible, fast, etc. See https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/blob/master/README.md#requirements-for-dependencies for more details.

Does it still compile with these repositories removed?

Yes, tried with -Dfull -Dmaven.repo.local=maven-repo (the maven-repo dir was empty).

http://github.com/uberfire/uberfire/commit/297999768

Thanks Petr.


Support ReactiveLB in WebClient

Enhancement
Recently, new reactive load-balancer was added in https://github.com/spring-cloud/spring-cloud-commons/pull/402.
It would be nice to add this support for WebClient.
I can submit PR.

Sorry, I wanted to create this issue in commons project, so closing this one.


Consider declaring prefix^ as a static member of Type Protocol

I think this should be a static member in an extension of TypeProtocol, neh?
Originally posted by @dabrahams in https://github.com/val-lang/val/pull/107#discussion_r1031897746

Unfortunately, doing so messes with Swift's type inference.


[don't merge this] testing

Description
trying to figure out why CI tests are broken
doing this as a separate PR from the openfermion stuff, so I eliminate the dependency issue as a possible source of error.
Please verify that you have completed the following steps

[ ] I have self-reviewed my code.
[ ] I have included test cases validating introduced feature/fix.
[ ] I have updated documentation.

Codecov Report

Merging #27 (5e93f59) into main (57eb541) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   95.00%   94.96%   -0.04%
==========================================
  Files           7        7
  Lines         320      318       -2
==========================================
- Hits          304      302       -2
  Misses         16       16

Impacted Files
Coverage Δ

...ntegrations/cirq/conversions/_pauli_conversions.py
100.00% <100.00%> (ø)

src/orquestra/integrations/cirq/simulator/_base.py
89.61% <100.00%> (-0.14%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[BUG] the NuGet project URL for Azure.Security.KeyVault.Secrets points to an invalid URL

Describe the bug
The project url on https://www.nuget.org/packages/Azure.Security.KeyVault.Secrets/ points to Page not found.
Exception or Stack Trace
Add the exception log and stack trace if available
To Reproduce
Follow the link from the NuGet Gallery site or use the project link from the Visual Studio IDE for package management.
Code Snippet
N/A
Expected behavior
The link should point to https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/keyvault/Azure.Security.KeyVault.Secrets/Readme.md
Screenshots
N/A
Setup (please complete the following information):

N/A

Additional context
N/A
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[ ] Bug Description Added
[ ] Repro Steps Added
[ ] Setup information Added

Looks like the link to the KeyVault Readme is changing with regard to the link for Steps to Reproduce.

Looks like the link to the KeyVault Readme is changing with regard to the expected behavior.

@KSchlobohm thanks for pointing it out! I believe that is fixed now. Please let me know if that is not the case.


[BUG] VM memory shows NaN Gi

It happens in the following cases:
case 1: Import Harvester to Rancher v2.6.2 and provision an RKE2 cluster using Harvester node driver.
case 2: Create a VM using the API:
$ kubectl apply -f https://kubevirt.io/labs/manifests/vm.yaml

Environment:

Harvester ISO version: v1.0.0-rc1

Additional context
UI gets the value from resource limit according to the change in https://github.com/harvester/harvester/issues/1429
For compatibility, we should show the CPU/memory info correctly when the limit is missing.

According to the previous discussion, the limit value should always exist regardless of the VM deployed in any way.

Yes as it should be automatically filled by the mutation webhook, I'm wondering why it was missing with kubectl apply

I've also hit this issue in the following case:

import harvester into rancher's virtualization dashboard
through rancher -> harvester, create a VM

in rancher, memory shows up as correct value

visit the harvester cluster through harvester UI (instead of rancher)

memory shows up as NaN

Need to confirm the behaviors on different scenarios:

User provides resources.requests only: Fill limits with that requests value.
User provides no limits nor requests: Invalid operation.

Any comment? @guangbochen @WuJun2016

@weihanglo, @guangbochen,
I have also tried this issue both on rancher v2.6.3-rc2 and v2.6.3-rc3
I found on v2.6.3-rc2 the default node driver version is v0.3.2

I tried to remove builtin and manual edit node driver to v0.3.4 , it can provision rke2 cluster correctly.
Also I double confirmed on v2.6.3-rc3, the built in node driver have already use v0.3.4 and can also provision rke2 correctly
Provide my test result to improve troubleshooting.

@weihanglo I think we also include User provides resources.limits only: Fill limits with that value and auto-fill the resources.request. ?
And @TachunLin it is correct that the supported Harvester node driver is v0.3.4, so prefer to ask users to test using the current latest Rancher v2.6.3-rc3 or above.

tested in master-655c251a-head with Rancher v2.6-head. I imported the testvm by config and provioned VMs with RKE1 and RKE2. The RKE1 and RKE2 VMs showed correctly. The

case 2: Create a VM using the API:
$ kubectl apply -f https://kubevirt.io/labs/manifests/vm.yaml
VM showed as having valid memory in Harvester UI, but NaN when looking through the harvester dashboard in virtualization management in Rancher.

@noahgildersleeve this is fixed in the single Harvester UI and haven't been merged to the upstream yet, for validation purpose can we just replace the Rancher UI index on the Rancher dashboard -> Global Settings -> ui-dashboard-index with https://releases.rancher.com/harvester-ui/dashboard/latest/index.html, thanks

Tested in master-3d096946-head. Verified as fixed.
Test Steps

Create new VM via $ kubectl apply -f https://kubevirt.io/labs/manifests/vm.yaml in harvester
Set ui-dashboard index to https://releases.rancher.com/harvester-ui/dashboard/latest/index.html
Set ui-offline-preferred to Remote
Bring up virtualization management and open dashboard
Open VM list
Verify size


Fails to build on macOS

Building the mongo_driver crate fails to link on macOS:
Undefined symbols for architecture x86_64:
"_SSLSetProtocolVersionMin", referenced from:
    _mongoc_stream_tls_secure_transport_new in libmongoc_sys-4624d9f5191db692.rlib(libmongoc_1_0_la-mongoc-stream-tls-secure-transport.o)
"_SSLSetSessionOption", referenced from:
    _mongoc_stream_tls_secure_transport_new in libmongoc_sys-4624d9f5191db692.rlib(libmongoc_1_0_la-mongoc-stream-tls-secure-transport.o)
"_SSLSetConnection", referenced from:
    _mongoc_stream_tls_secure_transport_new in libmongoc_sys-4624d9f5191db692.rlib(libmongoc_1_0_la-mongoc-stream-tls-secure-transport.o)
"_CFRelease", referenced from:
    __mongoc_secure_transport_RFC2253_from_cert in libmongoc_sys-4624d9f5191db692.rlib(libmongoc_1_0_la-mongoc-secure-transport.o)
"_SSLHandshake", referenced from:
    _mongoc_stream_tls_secure_transport_handshake in libmongoc_sys-4624d9f5191db692.rlib(libmongoc_1_0_la-mongoc-stream-tls-secure-transport.o)

...

Linking the Security and CoreFoundation frameworks appears to resolve the linking issues.

Looks like this broke in Sierra, a fully clean compile does not work on my Mac anymore either.
The error on my machine is:
Undefined symbols for architecture x86_64:
  "_SSL_CTX_set1_param", referenced from:
      _mongoc_stream_tls_openssl_new in libmongoc-priv.a(libmongoc_priv_la-mongoc-stream-tls-openssl.o)
  "_X509_VERIFY_PARAM_set1_host", referenced from:
      _mongoc_stream_tls_openssl_new in libmongoc-priv.a(libmongoc_priv_la-mongoc-stream-tls-openssl.o)
  "_X509_VERIFY_PARAM_set1_ip_asc", referenced from:
      _mongoc_stream_tls_openssl_new in libmongoc-priv.a(libmongoc_priv_la-mongoc-stream-tls-openssl.o)
  "_X509_VERIFY_PARAM_set_hostflags", referenced from:
      _mongoc_stream_tls_openssl_new in libmongoc-priv.a(libmongoc_priv_la-mongoc-stream-tls-openssl.o)
ld: symbol(s) not found for architecture x86_64

Upgrading the C driver in #21 did not fix it.

These instructions fixed it for me:
brew install openssl
export LDFLAGS="-L/usr/local/opt/openssl/lib"
export CPPFLAGS="-I/usr/local/opt/openssl/include"

I've added a note about this to the readme: 08ef8fbf2b94bb93d0f5e36e310a895d8539695c
Currently I don't see good options to make this smoother, so closing the issue.

@thijsc I've noticed that when pkg-config is installed on macOS, CPPFLAGS and LDFLAGS do not have effect, as the configure script tries to use pkg-config to detect OpenSSL and fails to do it because pkg-config package for OpenSSL is not configured by Homebrew. Once I've uninstalled pkg-config, the instructions with LDFLAGS and CPPFLAGS worked for me. It might be worth to mention this behavior in README.


EC2 - fix missing AZ on auto-generated volumes for instances

Using aws ec2 run-instance ... automatically creates a Volume. This volume had an empty AvailabilityZone field when not deployed in us-east-1 since this was hardcoded previously. Creating Volumes manually did set the AZ properly, so no changes where necessary in this case.

Codecov Report

Merging #4560 (38a03a2) into master (a290f8e) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4560      +/-   ##
==========================================
- Coverage   95.16%   95.07%   -0.09%
==========================================
  Files         500      515      +15
  Lines       56680    58727    +2047
==========================================
+ Hits        53939    55835    +1896
- Misses       2741     2892     +151

Flag
Coverage Δ

servertests
47.90% <100.00%> (-0.59%)
:arrow_down:

test_responses
32.39% <100.00%> (+0.05%)
:arrow_up:

unittests
94.98% <100.00%> (-0.09%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

moto/__init__.py
98.59% <100.00%> (+0.15%)
:arrow_up:

moto/ec2/models.py
93.91% <100.00%> (-0.85%)
:arrow_down:

moto/settings.py
75.75% <0.00%> (-24.25%)
:arrow_down:

moto/ec2/responses/elastic_network_interfaces.py
75.82% <0.00%> (-22.46%)
:arrow_down:

moto/sagemaker/models.py
88.34% <0.00%> (-2.43%)
:arrow_down:

moto/kms/models.py
93.56% <0.00%> (-2.28%)
:arrow_down:

moto/server.py
62.50% <0.00%> (-2.00%)
:arrow_down:

moto/redshift/models.py
96.83% <0.00%> (-1.26%)
:arrow_down:

moto/ec2/utils.py
91.46% <0.00%> (-1.11%)
:arrow_down:

... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca09cc3...38a03a2. Read the comment docs.


add french support

I added support for french in addition to other languages provided my the ministry of health
As an active member of the community of Olim for France in Israel , I am constantly updating french Olim who don't speak hebew and hence do not have access to Ministry of Health instructions ( which are provided in 5 languages but not in french)
This is a very small modification for the app that can help many new immigrants to have full access to ministry of Health instructions and recommandations and contribute to saving many lives in our country.

Thanks @LioraLevy !  The MoH team would have to advise before adding French.

Will you publish compiled APK for non-Google Play phones?
(e.g https://grapheneos.org/)

Hey @LioraLevy  and @ybaruchel, I'm happy to share that the MoH team decided to add French and to accept your version! We'll add it to the next release.


Access to Grafana and Node Red Flows

Hello,
I downloaded and installed your app on my CtrlX Core.  However, when I click on Node-Red Flows I get an error page stating the site cannot be reached.  The address it tries to go to is the :1880.  I already have the Node-Red app from Rexroth installed on my CtrlX core and when I go through that app it takes me to /node-red.  What am I missing to open the node red flows from your app?
I get the same message when I click on the Grafana dashboard button.  It tries to go to :3000.  I get a message stating the site cannot be reached.
If you have any other write on this I'd love to see more info.  We are looking at using this exact config for a customer and this apps seems like it could simplify things.  Thanks!

Hi!
I've seen this error before in previous versions. Please, what version of the app are you using? Is it on a real device or on ctrlX Core Virtual? Have you already tried uninstalling the Rexroth official Node RED app? (maybe some conflict?)
I'll try my best to solve this.


Move roletemplate out of cluster lifecycle

Problem:
cluster-roletemplate-sync was cluster scoped which means with 2k clusters there will 2k annotations and 2k finalizers on each roleTemplate. This causes slowdown when listing and also makes the object impossible to look at in general.
Solution:
Move cluster-roletemplate-sync to a management level lifecycle to handle the downstream cluster deletion of the cluster roles and setup a cluster scoped handler to handle syncing the roleTemplate to clusterTemplate on changes.
issue: https://github.com/rancher/rancher/issues/23923

Should there be an upgrade test?

The tests that were updated cover upgrade

Offline discussion: update the user controller sync to validate the clusterrole has a roletemplate in management and delete clusterrole if there isn't a corresponding roletemplate


is there no way to recover from 'too high" Klock clock setting

I accidently set K to 260 in the config menu
when I started putty again, it had trying setting the clock to 260 but then hung
it seems like since the 260 is in the nvram, it will always try to set that frequency when I reboot
reloading the uf2 doesn't clear the clock freq to lower default.
hmm. I think I can load a nother uf2 that will wipe the nvram
will that work?
https://github.com/dwelch67/raspberrypi-pico/blob/main/flash_nuke.uf2
installing that fixed things.
I suppose it might be nice if there was a single command to everything to default values, to recover from this situation
maybe not important.
maybe not important..just need to document what to do in this case (bad Klock)
~

here's a more official flash nuke. I've not tried this one, so don't know if it loads with zeroes
Resetting Flash memory
Pico’s BOOTSEL mode lives in read-only memory inside the RP2040 chip, and can’t be overwritten accidentally. No matter what, if you hold down the BOOTSEL button when you plug in your Pico, it will appear as a drive onto which you can drag a new UF2 file. There is no way to brick the board through software. However, there are some circumstances where you might want to make sure your Flash memory is empty. You can do this by dragging and dropping a special UF2 binary onto your Pico when it is in mass storage mode.
Download the [UF2 file]
https://datasheets.raspberrypi.com/soft/flash_nuke.uf2
See the [code on Github]
https://github.com/raspberrypi/pico-examples/blob/master/flash/nuke/nuke.c

I did a bunch of things in using the pico sdk for checking whether it's going to be successful with a particular voltage before taking it, and fixed up some things for recovering when the nvram has all bad values (like all 1's) from a flash nuke to recover from a bad (too high ) Klock speed setting
I think everything is recoverable now, or shouldn't happen normally. If you set it to something like 400 and it wedges, you'll have to nuke the nvram with another uf2 (available online) but then even if the nvram is all 1's, it self recovers to a default clock (115) but you'll have to manually set some other things
mainly callsign, channel and importantly the custom pcb =1 (or it will look like you can't talk to gps

for the first several seconds the clock is always supposed to run at default speed.
the way i intended it to work, and the way it worked for me when i also bricked a pico with too high a clock frequency, is that you have a few seconds after power-up to enter the user-interface menu. clock speed is supposed to remain default until after the user-menu is closed.
but i may have seen this same thing with a v2 pcb, so i will leave this open and have to look into it. (i also used the nuke file, among many other things i tried. did eventually recover).
after running the nuke, nvram is obvioulsy wiped and so its expected to give you that "BAD values in NVRAM detected! will reboot in 10 seconds... press any key to enter user-setup menu.."
and the reason i force a reboot after 10 seconds is in case there is a mis-read nvram during a flight. it will reboot and try reading nvram again until the data looks correct

so i just tried this with one of my v2 PCBs. i set Klock to 270Mhz (which i knew would lock up this batch) and it did lock. after power cycling it would blink for a few seconds and then lock up again.
I unpluged and re-plugged to the PC, and this time I connected Putty and hit a key ASAP and it opened the setup menu and let me change the Klock back down.
I will close this issue for now until it can be replicated. you just need to be quick when trying to open the setup menu.


Tables not being created when loading plugin on MySQL database.

Description

When I start my server I get this error:
java.util.concurrent.CompletionException: java.sql.SQLSyntaxErrorException: Table 'permscv.luckperms_groups' doesn't exist
I have the latest version of LP and I have tried making new of everything but it doesn't work. I have figured out that its not actually creating the table in the DataBase so it isn't finding it.
Reproduction steps

Put your database credits in config.yml
Restart the server
See error
If you want to further make sure that its not actually creating the tables then you can go to you MySQL Command Line Client and type show tables; and it will show you that only luckperms_messenger has been created.

Expected behaviour

Environment details

Server type/version: PaperMC running version 1.16.4 build 415
LuckPerms version: v5.2.92

Full LP startup log: https://bytebin.lucko.me/s39CuTJIoh
Any other relevant details

Try stopping your server, then dropping all LP tables, then starting it again.
If that doesn't fix it, then it's most likely an issue with your database server. The first thing I would check is that the MySQL user has the right privileges assigned to create tables, etc.

Try stopping your server, then dropping all LP tables, then starting it again.
If that doesn't fix it, then it's most likely an issue with your database server. The first thing I would check is that the MySQL user has the right privileges assigned to create tables, etc.


chore(deps): update terraform-module

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/event-notifications/ibm (source)
module
patch
1.15.5 -> 1.15.8

terraform-ibm-modules/secrets-manager/ibm (source)
module
patch
1.19.4 -> 1.19.8

Release Notes

terraform-ibm-modules/terraform-ibm-event-notifications (terraform-ibm-modules/event-notifications/ibm)
v1.15.8
Compare Source
Bug Fixes

deps: update terraform-module (#357) (2b4f55c)

v1.15.7
Compare Source
Bug Fixes

deps: update terraform-module (#353) (75cb73c)

v1.15.6
Compare Source
Bug Fixes

deps: update terraform ibm to latest for the deployable architecture solution (#348) (3a46daf)

terraform-ibm-modules/terraform-ibm-secrets-manager (terraform-ibm-modules/secrets-manager/ibm)
v1.19.8
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/event-notifications/ibm to v1.15.7 (#258) (af11cdb)

v1.19.7
Compare Source
Bug Fixes

deps: update terraform-module (#249) (20ac785)

v1.19.6
Compare Source
Bug Fixes

deps: DA updates:- locked ibm provider version to 1.73.08 updated KMS module version to 4.18.1 (#257) (51b861f)

v1.19.5
Compare Source
Bug Fixes

updated the region selector in the DA to only show Secrets Manager supported regions (#251) (b43e33b)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline


Add support for parsing more than one package

The current implementation only supports parsing a single package in the SPDX document. There can be one or more packages as mentioned here. We should add support for parsing more than one package.

Not sure this issue has been resolved or I am doing something wrong, I just couldn't get it to work with multiple packages, I'am always getting the error:
spdx.parsers.builderexceptions.OrderError: File::SPDXID

@licquia , we are still facing same issue with multiple packages.
"spdx.parsers.builderexceptions.OrderError: File::SPDXID"
Can you please let us know how we can get over it?


Migrate from Laravel Mix to Vite

This pull request includes changes for migrating from Laravel Mix to Vite outlined in Migration Guide and automated by the Vite Converter.
Before merging, you need to:

Checkout the shift-64735 branch
Run composer update
Run npm install
Review all comments for additional changes
Thoroughly test your application (no tests?, no CI?)

Please send your feedback to<EMAIL_ADDRESS>or share the good vibes on Twitter.

:alembic: This Shift is still being refined. Please report any issues or suggestions to<EMAIL_ADDRESS>Your feedback is what helps improve the experience for everyone.


Misc fixes on segment validation for uploaded real-time segments

Subtask of #8283

For newly pushed segment with LLC segment name, validate whether it contains start/end offset in the metadata
Fix multiple checks that doesn't handle the UPLOADED segment properly
Fix RealtimeToOfflineSegmentsTask to properly handle UPLOADED segments
Simplify some handling of LLC segment name
Added test to verify the behavior

Codecov Report

Merging #8786 (f9f916e) into master (11a060c) will decrease coverage by 44.42%.
The diff coverage is 53.47%.

@@              Coverage Diff              @@
##             master    #8786       +/-   ##
=============================================
- Coverage     69.63%   25.21%   -44.43%
+ Complexity     4621       45     -4576
=============================================
  Files          1736     1723       -13
  Lines         91203    90821      -382
  Branches      13632    13587       -45
=============================================
- Hits          63513    22899    -40614
- Misses        23269    65729    +42460
+ Partials       4421     2193     -2228

Flag
Coverage Δ

integration1
?

integration2
25.21% <53.47%> (-0.06%)
:arrow_down:

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...he/pinot/common/tier/FixedTierSegmentSelector.java
0.00% <0.00%> (-93.34%)
:arrow_down:

.../helix/core/realtime/SegmentCompletionManager.java
37.47% <0.00%> (-35.35%)
:arrow_down:

...eaderwriter/RealtimeIndexOffHeapMemoryManager.java
0.00% <0.00%> (-80.65%)
:arrow_down:

...va/org/apache/pinot/spi/utils/CommonConstants.java
0.00% <0.00%> (-20.97%)
:arrow_down:

...r/validation/RealtimeSegmentValidationManager.java
55.88% <37.50%> (-17.73%)
:arrow_down:

...apache/pinot/controller/api/upload/ZKOperator.java
43.88% <42.85%> (-24.78%)
:arrow_down:

...ot/controller/helix/core/util/ZKMetadataUtils.java
72.91% <44.44%> (-14.32%)
:arrow_down:

.../core/realtime/PinotLLCRealtimeSegmentManager.java
54.70% <51.35%> (-22.90%)
:arrow_down:

...ata/manager/realtime/RealtimeTableDataManager.java
66.93% <61.53%> (-1.59%)
:arrow_down:

.../org/apache/pinot/common/utils/LLCSegmentName.java
47.69% <75.00%> (-11.14%)
:arrow_down:

... and 1265 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11a060c...f9f916e. Read the comment docs.


[BEAM-10601] DICOM API Beam IO connector

Create a new Apache Beam I/O connector that helps customers facilitate the reading and writing data to the DICOM Healthcare API, it has three components:

An Ptransform that takes QIDO request and output result metadata as pcollection.
An I/O sink that takes DICOM files and writes them to DICOM store via API.
An Ptransform that convert pubsub message to Qido search request..

RAT PreCommit checks that there is a license header on every new file. You'll need to add license headers to all files.
If you have test data files, you will have to add exclusions for them

You can run the automatic formatter locally from your virtualenv using tox -e py3-yapf

You can run PythonLint locally from your virtualenv using tox -e py37-lint

Run PythonDocker PreCommit

Run Portable_Python PreCommit

Run Python PreCommit

LGTM. I'll merge once tests pass.


Compose and Dockerfile

Hi! I've been working in a new Dockerfile and docker-compose for your react app. It runs but I couldn't test it propertly as I've never worked with firebase before.
If you could put your variables in the env.file and run the compose we can test if it works propertly :)
#7

Hi @sergioarroyop Thank you for the pull request. I've tested it locally with firebase and it is working. 👍 🎉


Add to Open VSX?

Hi there 👋
Would love to see this available on Open VSX. 🙂

Sry, don't want to set account on eclipse foundation.


[MAHOUT-1895] Add convenience methods for converting Vectors to Scala Types

adds the following methods to Vector
.toMap
.toArray

[x] Add Methods
[x] Add Tests

Minor Improvement
Relevent JIRA:
MAHOUT-1895
Requires no license updates

"While dense and sparse vectors may be created from TraversableOnce[Double] such as Array[Double] and TraversableOnce[(Int, AnyVal)] such as Map[Int,Double] respectively"

This is, iirc,  is not quite true.
only dense vectors can be created from arrays, sparse vectors are explicitly disallowed (or not supported, depends on your take).
So i have a few problems with this.
(1) similarly, if we want to create vector 2 array transformation, it probably should only be allowed for dense vectors only, otherwise it invites misuses.
(2) even when i do need an array out of dense vector, i usually use it without copying (shallowly). In some implementations, it is adding array() method which returns shallow backing array, if any, similarly to ByteBuffer.array(); and in some implementations I am using a reflection to access the private attribute (which is admittedly is a hack). The former is preferred.
Either way, the gist of this point is that one quite more often needs a backing array rather than a copy of such. This implementation forces copy-only approach. Note that ByteBuffer doesn't have copying implementation (.toArray()) and only has backing array access (array()) for perhaps the same reasons. Inviting misuse and inefficiency.
(3) Assuming (1) and (2) are overcome, this implementation is still suboptimal for sparse implemetnations.

Thanks for the comments @dlyubimov .  Do you mean we should add a method to expose this for dense implementations?
For SequentialAccessSparseVector could we expose the OrderedIntDoubleMapping underlying and then add a method to expose indices and values then zip them into a Map as a convenience.
Similarly for [Int2DoubleOpenHashMap backing RandomAccessSparseVector] we could expose values and then using the interface for it.unimi.dsi.fastutil.ints.Int2DoubleOpenHashMap we could get the keySet() and values which in turn are IntSet and DoubleCollection respectively, however both have toArray() methods.
If these are unacceptable, do you have any alternative approaches (and apologies if I entirely missed your point regarding the DenseVectors)

@rawkintrevo there are really two reasons to want toArray(). One is to have its contracts (I guess it is what you are appealing to when you say you want to wrtie summaries etc.) and one is because Array is common part of somebody else's contract.
On reason one, the refute is simple because Vector does all Array contract does, i.e., it has random access contract with exact the same scala signature. Actually it has much more, including things like pretty print that are useful for summaries.
On reason two, it is a more valid case. However, i found that one much more often wants avoid copying memory anyway and that optional array() is much more desired in all of my usecases. It is true i am an algorithm developer and so my use cases are skewed that way.  One example would be repackaging of dense matrices and vectors we had in VCL integration. that's what we wanted there -- the optionally supported  non-copying array() method. but we did not want a copying method at all since we were repackaging it into native memory anyway. So were some similar other cases.
I am sure you can provide a specific case where you want toArray(), which i suspect might be the motivation where you have to use some other 3rd party contract  and then it might be a better shaped argument if you give us some concrete examples of that 3rd party contract you've encountered a need to use.

Thanks for the comments @dlyubimov . Do you mean we should add a method to expose this for dense implementations?

yes. This is an alternative i would need.
exposing non-copying collection.Map implementation makes sense for RandomAccessSparseVector and whatever other implementations that adhere to Map's promise of O(1) lookup. For Sequential i don't see it as appropriate non-copying for the same very reason -- it violates O(1) contract promise.
In general it has occured to me that I am somehwat more ready to consider toMap, toSeq (and even toArray) that implement correspondent Scala collections because it is consistent with strict Scala collection contract use (i.e., admittance of a copying contract) as long as it is available in Scala only. Regardless, implementation must consider individual underlying structure for the copying efficiency. I.e., it has to use non-default element iterators where appropriate (just like we do with VCL adapting).
But i happen to want implementing collection.Map for random access and optional array() for DenseVector more than the copying contracts.

Another though i had, if you feel strongly going about toMap, toSeq, toArray method support, perhaps you could group it into a separate decorator implementation, similar to JavaCollections._ approach ((say import MahoutCollections._), , so that it can be invoked only when needed, but is cleanly separated from the algebra dialects (which are enabled by import RlikeOps._). In other words, i don't what RlikeOps to enable this by default.

+1 from me

@dlyubimov per your comments- I moved to MahoutCollections.


135 - Files table UI [2/2] - File Action Buttons and File Level Messages

What this PR does / why we need it:
This PR adds the File Actions Buttons of the Files Table as well as some File Level Messages. (All download options not included since they are included in another UI issue #63 )
This is only the UI, no backend connected yet.
Which issue(s) this PR closes:

Closes #139

Special notes for your reviewer:
This is only the UI work, so some variables for the conditional render have been hardcoded until we can get them from the js-dataverse module.
Changes

Remove msw from Storybook because we don't need to mock the API calls, we can mock the repositories.
Changes to the design system:
a. ButtonGroup now accepts HTMLAttributes
b. Type prop added to the Button component
c. Disabled prop added to the DropdownButtonItem component
d. New DropdownHeader component added to the design system
SessionProvider added to the application to get the information of the authenticated user at any point of the application
Some new properties added to the File model to manage different states of the restricted access
DatasetUploadFilesButton added to the Dataset page
File Actions column added to the Files Table, this includes:
a. EditFilesMenu component at the Header of the column
b. AccessFileMenu at cell level to check the access status of the file
c. RequestAccessModal, display work only, since we are not including write actions in this Milestone 2.
d. File Options menu, display work only, since we are not including write actions in this Milestone 2.
e. FileInfoMessages

All file actions not included in this PR are not considered for the MVP.
Suggestions on how to test this:

npm i
cd packages/design-system && npm run build
cd ../../
npm run storybook
Check the files table at localhost:6006 storybook in the Dataset page. There are 2 modes now, Default and Logged In as Owner to check the appearance of these Action Buttons.
Some other sections have been added to the storybook to check the different states of the File Action Buttons, check these sections at Sections/Dataset Page/DatasetFiles/FilesTable/FileActionsCell/ in the Storybook.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:
File Action Buttons added to the Files Table UI
Additional documentation:

coverage: 98.116% (-0.3%) from 98.441% when pulling 86ce0d24c9c851856ad55345e1b74e9b48120281 on feature/139-files-table-file-action-buttons-ui into f74247673e75a01d76b8cc4ba3aab9a2b25552cf on feature/149-react-table-manual-pagination-setup.

I have not been able to test the appearance of the tooltip in Storybook. I am referring to this behavior, from your screenshots:

All Storybook files show the message but without the tooltip:

Are these tooltips implemented?
On the other hand, I have created a separate issue to refine the styling of the UI with some details that I have identified, so we don't slow down this PR:
https://github.com/IQSS/dataverse-frontend/issues/174

@GPortas After reading your comments, I don't know what I was thinking while working on this issue, I think I was just thinking that everything that was not in the current Dataset and Files models I had to leave it with a TODO to be implemented in a different issue.
Guess I were overwhelmed by the amount of new properties and states in this issue.
But you're right, the new properties can be added to the models even if they are not implemented in the js-dataverse module yet.
I can do that, but the thing now is that I'm working on the Dataset Action buttons and I've implemented most of these new Dataset properties there so I don't want to repeat the work here. Maybe we can leave the TODO's for the Dataset properties and implement them in the Dataset Action buttons issue and the Files properties such as isDeleted implement them in this issue?
Let me know what you think

@MellyGray
No problem, there are many issues and chained PRs. The good thing is that we know how we can proceed.
As you suggest, let's implement the file-related properties in this PR and leave the dataset-related ones for the other issue you're working on.

@GPortas I added the requested changes, please let me know if I missed something

I have not been able to test the appearance of the tooltip in Storybook. I am referring to this behavior, from your screenshots:

I added a commit, you can check all the different messages in Storybook at http://localhost:6006/?path=/story/sections-dataset-page-datasetfiles-filestable-fileactionscell-fileinfomessages-fileinfomessages--ingest-in-progress

Thanks @MellyGray. Looks good.
Only a minor detail. I tested the new Storybook changes and found the following:
In Storybook, the width of the file info message with tooltip appears smaller than the one without a tooltip (that occupies the width of the screen).
Tooltip:

No tooltip:

Not sure if this is relevant, but just in case.

@MellyGray Unfortunately, I'm seeing the same error and blank page.

@MellyGray I'm getting blank screens with this but with many console errors. We've seen this and deleting the node dir seemed to help before but now not helping.

I haven't change anything since yesterday, how is this possible 😢 We can try again today to troubleshoot this in a zoom call before the standup, I'm available from 9-11h


Profile and Settings screen

Additionally, users should be retrieved using their uid (especially since they're now available in the Profile interface, which should make your life a lot simpler).
@alexandrepiveteau this is something I will do in the next sprint

I'm a bit concerned by the duplication between the SettingScreen (which btw should probably be named SettingsScreen) and the ProfileScreen composables. In my opinion, this would be the perfect opportunity to use a slot-based approach (documentation).
Very elegant. Thank you. I will apply it directly


Device tunnel deployment

Please provide better instructions, how to deploy the device profile with SCCM. In VPN ALO deployment whitepaper, there is a good instructions what to do with User Tunnel profile xml, reference connection and how to "capture" profile for deployment. But this Device tunnel article is very unclear about it, what to do with xml. Also, xml's of user tunnel and device tunnel are very different.
Currently I use user tunnel profile xml, change EAP to Machine Cert and capture device tunnel with it. Not sure is it right way to approach.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 06629f78-c4b1-4345-578c-596e92dff977
Version Independent ID: e3686eef-c2c6-5a21-ac76-6bac575e7cfc
Content: Configure the VPN device tunnel in Windows 10
Content Source: WindowsServerDocs/remote/remote-access/vpn/vpn-device-tunnel-config.md
Product: windows-server-threshold
GitHub Login: @shortpatti
Microsoft Alias: pashort

@MihaiSP, can you take a look at this issue?

Any update on this? There are still no clear instructions on how to deploy these profiles via SCCM, using the powershell method is not acceptable in our environment due to audit requirements.

Any updates? I'm trying to deploy a machine tunnel via SCCM and while the user tunnel works, the machine tunnel deployment never works.


Viewport doesn't show anything if set to never clear, unless it is told to clear once

Godot 3.0.6
Windows 10 64 bits
OpenGL ES 3.0 Renderer: GeForce GTX 1060 6GB/PCIe/SSE2
I am trying to setup a simple scene for a shader feedback effect, with a viewport that always render and never clears so I can accumulate frames.
but found a number of confusing stuff.
First one is, my viewport doesn't show anything, no matter what I do. BUT, if I set it temporarily to always clear, then back to never clear, it works fine and starts accumulating frames.
Why is this happening? It's quite inconvenient for such a setup to happen.
Reproduction project:
FeedbackViewportIssues.zip

Open main.tscn, you should normally see something but nothing is shown
Change the Viewport to always clear: boom, stuff is appearing
Change it back to its previous setting: all is fine now, but ideally we should not need to go through step 1 and 2 just to make this work... (and you have to redo this everytime you open the scene)

Edit: I'm told to use ClearOnce, but what is NeverClear for then? Why can't it simply work with NeverClear?

Works correctly in 4e0f31a
(although still broken in 3.2.2 rc2)


Document that none driver doesn't work with snap docker

Document that none driver doesn't work with snap docker
fixes https://github.com/kubernetes/minikube/issues/4953

/assign @RA489

/lgtm
/approve


[RUNTIME] Make Runtime and RPC endian aware

This is a non-backward compatible change in RPC protocol, upgrade of both compiler and device side runtime is needed to keep things consistent. Tested on x86(compiler) and powerpc(rpc host)
But hopefully the price pay off as now the RPC and serialization protocol is endian invariant:

Start an RPC server on a big-endian machine and connect to it from a little-endian one
Proper byteswap operations will be inserted to ensure we always use little endian in serialized format
Save a parameter dict in little endian machine and load it back on big endian one.

cc @eqy @Laurawly @merrymercy @yidawang

cross ref https://discuss.tvm.ai/t/how-to-load-and-read-the-params-in-big-endian-system/203/19


[TEST] Refactor test classes to match multi frontend protocol

Why are the changes needed?
As Kyuubi supports REST frontend protocol now, and MySQL frontend protocol is coming soon, Thrift is not the only one, this PR refacotor the test classes to match the changes.
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

Codecov Report

Merging #1331 (8610721) into master (8f3cca9) will increase coverage by 0.00%.
The diff coverage is 81.81%.

@@            Coverage Diff            @@
##             master    #1331   +/-   ##
=========================================
  Coverage     78.55%   78.55%
  Complexity      110      110
=========================================
  Files           179      179
  Lines          7278     7280    +2
  Branches        891      891
=========================================
+ Hits           5717     5719    +2
  Misses         1075     1075
  Partials        486      486

Impacted Files
Coverage Δ

...e/kyuubi/server/KyuubiRESTfulFrontendService.scala
84.90% <70.00%> (ø)

...in/scala/org/apache/kyuubi/config/KyuubiConf.scala
95.26% <91.66%> (+0.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f3cca9...8610721. Read the comment docs.

any thoughts? @yaooqinn

https://docs.github.com/en/rest

https://developer.twitter.com/en/docs

https://developer.paypal.com/docs/api/overview/#make-rest-api-calls

Sound like we should change rest to REST?

https://www.ics.uci.edu/~fielding/pubs/dissertation/rest_arch_style.htm

Sound like we should change rest to REST?

the rest is ok to me from the given URLs, they are mostly contains lower case rest

I can not find any supporting evidence from your PR description so I did some research on my own. Some from the best practices of big companies and some from the original author.

WDYT other changes of this PR?

Thanks, merging to master


Process killed

Hello! First of all, thanks for pushing this out. I've been testing this on my end directly with the run_fastsurfer.py file. Unfortunately the process gets killed and I'm not sure why. I do suspect it may have to do with memory.
(fastsurfer) sid@sid-research:~/Repos/FastSurfer$ python run_fastsurfer.py --sid IAM_1116 --sd ~/Desktop/FastSurfer/Out/ --seg /home/sid/Desktop/FastSurfer/Out/IAM_1116/aparc+aseg_deep.mgz --t1 '/home/sid/Desktop/FastSurfer/In/IAM_1116/anat/IAM_1116_5_t1_mprage_sag_p2_iso__.nii.gz' --n_threads 16
Reading volume /home/sid/Desktop/FastSurfer/In/IAM_1116/anat/IAM_1116_5_t1_mprage_sag_p2_iso__.nii.gz
Conforming image to UCHAR, RAS orientation, and 1mm isotropic voxels
Input:    min: 0  max: 684
rescale:  min: 0.0  max: 454.86  scale: 0.5606120564569318
Output:   min: 0.0  max: 255.0
Loading Axial
Successfully loaded Image from /home/sid/Desktop/FastSurfer/In/IAM_1116/anat/IAM_1116_5_t1_mprage_sag_p2_iso__.nii.gz
Loading Sagittal
Successfully loaded Image from /home/sid/Desktop/FastSurfer/In/IAM_1116/anat/IAM_1116_5_t1_mprage_sag_p2_iso__.nii.gz
Loading Coronal.
Successfully loaded Image from /home/sid/Desktop/FastSurfer/In/IAM_1116/anat/IAM_1116_5_t1_mprage_sag_p2_iso__.nii.gz
Cuda available: True, # Available GPUS: 1, Cuda user disabled (--no_cuda flag): False, --> Using device: cuda
Loading Axial Net from ./checkpoints/Axial_Weights_FastSurferCNN/ckpts/Epoch_30_training_state.pkl
Axial model loaded.
--->Batch 0 Axial Testing Done.
--->Batch 1 Axial Testing Done.
--->Batch 2 Axial Testing Done.
--->Batch 3 Axial Testing Done.
--->Batch 4 Axial Testing Done.
--->Batch 5 Axial Testing Done.
--->Batch 6 Axial Testing Done.
--->Batch 7 Axial Testing Done.
--->Batch 8 Axial Testing Done.
--->Batch 9 Axial Testing Done.
--->Batch 10 Axial Testing Done.
--->Batch 11 Axial Testing Done.
--->Batch 12 Axial Testing Done.
--->Batch 13 Axial Testing Done.
--->Batch 14 Axial Testing Done.
--->Batch 15 Axial Testing Done.
Axial View Tested in 18.0291 seconds
Loading Coronal Net from ./checkpoints/Coronal_Weights_FastSurferCNN/ckpts/Epoch_30_training_state.pkl
Killed

This is running in a Python 3.6 environment on a system with Ryzen 2700x, GTX1080 and 16 GB RAM.
EDIT: Upon further investigation, it is indeed an out of memory error:
[Wed Jun 24 14:40:37 2020] Out of memory: Killed process 20341 (python) total-vm:31198980kB, anon-rss:11861040kB, file-rss:99992kB, shmem-rss:12288kB, UID:1000 pgtables:26172kB oom_score_adj:0

That translates to ~32 gigabytes of memory that the script requested. I'll try this on a system with larger memory.

Hey,
first, it would be better if you used the shell script (run_fastsurfer.sh). The memory problem is most likely caused by the batch size (it is 16 by default). You can change it with the flag --batch (or --batch_size for the python script)  e.g. set it to 1 to see if the problem goes away.

This is probably resolved. In case reducing the batch size did not solve it, we can reopen.

This fixed it, thanks!

Hi,
I used docker and it seems that the process stopped for some reason:
/fastsurfer/FastSurferCNN /fastsurfer
python3.8 eval.py --in_name /data/sub-1070.nii.gz --out_name /output/subject3/mri/aparc.DKTatlas+aseg.deep.mgz --conformed_name /output/subject3/mri/orig.mgz --order 1 --network_sagittal_path /fastsurfer/checkpoints/Sagittal_Weights_FastSurferCNN/ckpts/Epoch_30_training_state.pkl --network_axial_path /fastsurfer/checkpoints/Axial_Weights_FastSurferCNN/ckpts/Epoch_30_training_state.pkl --network_coronal_path /fastsurfer/checkpoints/Coronal_Weights_FastSurferCNN/ckpts/Epoch_30_training_state.pkl --batch_size 8 --simple_run --run_viewagg_on check
Reading volume /data/sub-1070.nii.gz
The input image is not conformed.
A conformed image must satisfy the following criteria:

Dimensions 256x256x256:        False
Voxel size 1x1x1:              True
Orientation LIA:               False
Dtype uint8:                   False
Conforming image to UCHAR, RAS orientation, and 1mm isotropic voxels

Input:    min: 0.0  max: 1946030.0
rescale:  min: 0.0  max: 1321354.3699999999  scale: 0.00019298380948329556
Output:   min: 0.0  max: 255.0
Saving conformed original image to /output/subject3/mri/orig.mgz
Cuda available: False, # Available GPUS: 0, Cuda user disabled (--no_cuda flag): False, --> Using device: cpu
Loading Axial
Successfully loaded Image from /data/sub-1070.nii.gz
Loading Axial Net from /fastsurfer/checkpoints/Axial_Weights_FastSurferCNN/ckpts/Epoch_30_training_state.pkl
Axial model loaded.
I used deepmi/fastsurfer:cpu-v1.1.1
Many thanks for any suggestions!
Wei


Auto port forwarding does not work with nodemon

Version: 1.53.2 (user setup)
Commit: 622cb03f7e070a9670c94bae1a45d78d7181fbd4
Date: 2021-02-11T11:48:04.245Z
Electron: 11.2.1
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.18363
Note: this bug happens in Codespaces
Steps to Reproduce:

Start express in nodemon and console.log "http://<IP_ADDRESS>:8080" from the app.listen function
the port is not auto forwarded

Code that the error is observable: https://github.com/i5heu/personal-edms/tree/529eae0b16c7aa4fe17b63318289ec8415c553cf
npm i && npx nodemon

Does this issue occur when all extensions are disabled?: Yes

https://user-images.githubusercontent.com/22565269/108589526-f1748f00-735e-11eb-95af-0cf839b17884.mp4

@i5heu can you please collect some logs? Steps:

Run the command Developer: Set Log Level. Choose Trace.
Repro your issue.
Open the Output panel and share the logs from Log (Window), Log (Extension Host), and Log (Remote Extension Host).


[ResourceManager] Local extensions overrides

Summary
The focus of these changes is to fix the project reference CI leg which is failing due to in-process work to bump extension package dependencies.  These packages are being bumped locally to force transitive dependencies to play nice while we work on the central updates.
References and related

[EngSys] Bump extensions package references (#47365)

API change check
API changes are not detected in this pull request.


Sally - install and run system diagnostics

Docs Build status updates of commit ebb06a0:
:clock10: Pending: waiting for processors (6 builds ahead of you)
:warning: Docs Build is busy, currently there are 6 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit ebb06a0:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

dynamicsax2012-technet/install-run-system-diagnostics.md
:x:Error

Details

dynamicsax2012-technet/install-run-system-diagnostics.md

Line 14: [Error] Cannot resolve '../../includes/banner.md' relative to 'install-run-system-diagnostics.md'.
Line 185: [Warning] Invalid file link: './media/testpermissions.jpg'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit fd17547:
:clock10: Pending: waiting for processors (6 builds ahead of you)
:warning: Docs Build is busy, currently there are 6 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit b508198:
:clock10: Pending: waiting for processors (5 builds ahead of you)
:warning: Docs Build is busy, currently there are 5 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit fd17547:
:warning: Validation status: warnings

File
Status
Preview URL
Details

dynamicsax2012-technet/install-run-system-diagnostics.md
:warning:Warning
View
Details

dynamicsax2012-technet/install-run-system-diagnostics.md

Line 184: [Warning] Invalid file link: './media/testpermissions.jpg'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit b508198:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

dynamicsax2012-technet/install-run-system-diagnostics.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 7d94ddd:
:clock10: Pending: waiting for processors (9 builds ahead of you)
:warning: Docs Build is busy, currently there are 9 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 7d94ddd:
:warning: Validation status: warnings

File
Status
Preview URL
Details

dynamicsax2012-technet/toc.yml
:warning:Warning
View
Details

dynamicsax2012-technet/install-run-system-diagnostics.md
:white_check_mark:Succeeded
View

dynamicsax2012-technet/toc.yml

Line 8469: [Warning] Invalid file link: 'install-run-system-diagnostics-lcs.md'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 6e69db9:
:clock10: Pending: waiting for processors (13 builds ahead of you)
:warning: Docs Build is busy, currently there are 13 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 6e69db9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

dynamicsax2012-technet/install-run-system-diagnostics.md
:white_check_mark:Succeeded
View

dynamicsax2012-technet/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Support the null value in bloom_filter_agg Spark aggregate function

Currently, the velox BloomFilterAggregate checks the input row and throws an exception if there are some null values in the row. So we need to be consistent with spark's behavior and ignore null values.
The spark  BloomFilterAggregate will Ignore null values. https://github.com/apache/spark/blob/6cdca10f148433664b3e2be6f655b0ddba817537/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/BloomFilterAggregate.scala#L180-L188
 override def update(buffer: BloomFilter, inputRow: InternalRow): BloomFilter = {
    val value = child.eval(inputRow)
    // Ignore null values.
    if (value == null) {
      return buffer
    }
    updater.update(buffer, value)
    buffer
  }

@rui-mo @jinchengchenghh  PTAL.

Hi @weixiuli, thanks for your fix. We are doing daily rebase now, so this change will be included very soon once it get merged in Velox community. cc @PHILO-HE


dyld: lazy symbol binding failed: Symbol not found: _RSA_generate_key

I'm having some issues using the ursa module on electron.
I installed the module using npm like so:
npm install --save ursa

Then rebuilt the native extensions for electron like so:
./node_modules/.bin/electron-rebuild

This seemed to exit immediately / not actually do anything, and when I ran the app I got the usual error message:
Error: Module version mismatch. Expected 44, got 14.

So I rebuild the native extension manually using node-gyp like so:
HOME=~/.electron-gyp node-gyp rebuild --target=0.28.1 --arch=ia64 --dist-url=https://atom.io/download/atom-shell

And I now get the following error message:
dyld: lazy symbol binding failed: Symbol not found: _RSA_generate_key
  Referenced from: /Users/daniel/work/kuddl/electron-client/node_modules/ursa/build/Release/ursaNative.node
  Expected in: dynamic lookup

dyld: Symbol not found: _RSA_generate_key
  Referenced from: /Users/daniel/work/kuddl/electron-client/node_modules/ursa/build/Release/ursaNative.node
  Expected in: dynamic lookup

Here's my code:
var ursa = require('ursa');
var key = ursa.generatePrivateKey(2048, 65537);

I think this may be related to this issue: https://github.com/atom/electron/issues/1410
Version Numbers:

Electron Version
v0.28.1

Operating System
Mac OSX 10.10.0

ursa
v0.8.5

Yeah it is a duplicate of #1410.


Automatically asign users to Enterprise Application Azure

The options shown here are either administrator ór user driven. Is it possible to populate the "Users and Groups" section of an Enterprise Application automatically, by filtering on certain propertie (group, department, manager)?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 93597292-2326-629a-3d21-267980e4e6d3
Version Independent ID: 02e7e532-c6e6-332e-85eb-d7480cf1275a
Content: Understand how users are assigned to apps - Microsoft Entra
Content Source: articles/active-directory/manage-apps/ways-users-get-assigned-to-applications.md
Service: active-directory
Sub-service: app-mgmt
GitHub Login: @eringreenlee
Microsoft Alias: ergreenl

Wait! I might solve this myself with a runbook.

@MeanDoubleStain You can create a Dynamic Group in Azure AD with an expression to add users automatically to the group based on certain user properties. Under the "Users and Groups" section of the Enterprise Application, you can then add the dynamic group.

Yes, that would be ideal, but we haven't got the subscription plan that supports that, yet.

@MeanDoubleStain There is a programmatic way to Assign a user to the application that you can use via Graph SDK as well.

This is really cool! Thanks, I am going to digg in to this.

@MeanDoubleStain Closing out the issue. Feel free to tag me in your reply if you have any questions.


class: does not work well as a parameter for application classes

If you specify a parameter name as :class it gets translated to :className before handed over to the component.
So if you want to receive a parameter called :class you have to declare it as :className
This is happening because of some translation needed for react.js components (where they expect className rather than class.)  Could get tricky...
Anyway its not a patch level fix, as in most cases if you are trying to pass :class you really want to be just collecting all other attributes, and then passing them all along to the lower level components.

I don't even think we need this for 0.9, if it get fixed before then great, if not, oh well.


IconResolver not working with custom icons

Describe the bug
IconsResolver don't find svg icons for global use. Manual import with "import MyIcon from '~icons/myName/my-icon';" is working.
This is my vite.config.ts:
// https://github.com/antfu/unplugin-icons
Icons({
  compiler: 'vue3',
  customCollections: {
    myName: FileSystemIconLoader('src/assets/icons'),
  },
}),

// https://github.com/antfu/unplugin-vue-components
Components({
  deep: true,
  dts: './src/components.d.ts',
  directoryAsNamespace: true,
  resolvers: [
    IconsResolver({
      customCollections: ['myName'],
    }),
  ],
}),

Reproduction
I  tried it with "vite + vue3" example from this repo, it only works with default config. If i change customCollections name from "custom" to another name, this items are not listet anymore.
System Info
System:
    OS: Windows 10 10.0.19044
    CPU: (16) x64 Intel(R) Core(TM) i7-10875H CPU @ 2.30GHz
    Memory: 13.95 GB / 31.72 GB
  Binaries:
    Node: 16.17.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.15 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 8.15.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: 106.0.5249.119
    Edge: Spartan (44.19041.1266.0), Chromium (106.0.1370.47)
    Internet Explorer: 11.0.19041.1566

Used Package Manager
yarn
Validations

[x] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

Hi @RuBaWa maybe check that the following:

Whether you included your components.d.ts file inside yourtsconfig.json:

{
	"include": ["src/**/*.d.ts"]
}

Whether you used the right element syntax

<template>
 	<i-myName-iconName>
</template>

You are rigtht, its working with:
<template>
 	<i-myName-iconName>
</template>

I was confused, because this custom icons are not updated in components.d.ts dts file, where all other components are listet. In demo project for vite + vue3 they also listet in this file. But after some tests it is working fine without beeing listet in this file.
One more question:
I would like to build a wrapper component like
<my-icon name="svgName">

Something like this is not working:
<script setup lang="ts">
...
const currentIcon = computed(() => `i-custom-${props.name}`);
</script>

<template>
  <component :is="currentIcon" />
</template>

This component is rendered as  <i-custom-svg-name />, but not resolved to the svg file instead.
Do you have any ideas or expiriences with this problem?

Perfect. Glad I could help @RuBaWa ;)
I think this issue can be closed then.


Fix prettier glob pattern

I found that some files are not formatted with npm run prettier = prettier --write src/**/*.ts test/**/*.ts. It is because shell parses glob patterns, not prettier parses them.
If glob pattern arguments are not quoted, the shell parses them and pass parsed strings to the  command. For easy understanding, I replace prettier command to echo.
$ echo test/**/*.ts
test/browser/main.ts
test/deno/cdn.test.ts
test/deno/local.test.ts
test/typings/index.d.ts
test/typings/shared.d.ts

(I inserted new line manually for readability) This is cause of the problem. I'm using ubuntu 22.04 with bash 5.1.16(1)-release, my bash parses test/**/*.ts to a small part of the files. I don't know why.
When I quote the argument,
$ echo 'test/**/*.ts'
test/**/*.ts

It was passed to the command as-is. So back to kysely, if I change this line
https://github.com/koskimas/kysely/blob/71507c4102ca1ae86fa18940c53310aa6e15ac1b/package.json#L31
to     "prettier": "prettier --write 'src/**/*.ts' 'test/**/*.ts'",
then finally all files in the project could be formatted.
I ran prettier again(a99b912), and found not formatted files. So I think this issue is not only relevant to me but also to other people.

Thank you!


Unable to Update Multiple Choice/Check Box Columns in SharePoint List Using MSGraph Explorer

Describe the bug
I am trying to update a SharePoint List item using the MS Graph API. According to the documentation (ListItem Update), the API should support updating all column types. However, updating Multiple Choice / Check Box columns results in an "Invalid request" error. The documentation does not specify any special requirements for these column types.
To Reproduce
Steps to reproduce the behavior:

Go to Microsoft Graph Explorer.
Authenticate and ensure the necessary permissions (Sites.ReadWrite.All) are granted.
Select "PATCH" method and enter the endpoint: https://graph.microsoft.com/v1.0/sites/{site-id}/lists/{list-id}/items/{item-id}/fields
Enter the request body containing the multi-choice column name and values:{
  "Ranby": {
    "results": [
      "Test User 1",
      "Test User 2"
    ]
  }
}

Click "Run Query".
Observe the error response:{
  "error": {
    "code": "invalidRequest",
    "message": "Invalid request",
    "innerError": {
      "date": "2024-07-08T20:15:57",
      "request-id": "XXXXX",
      "client-request-id": "XXXXX"
    }
  }
}

Expected behavior
The API should successfully update the multi-choice column values or return a clear and specific error message indicating why the request is invalid. Ideally, the documentation should provide detailed information on how to format the request payload for different column types, including multi-choice columns.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g., Windows 10]
Browser [e.g., Chrome 91]
Version [e.g., 91.0.4472.124]

Additional context
This issue is specific to columns that allow multiple choices (check boxes). Single-choice columns and other types of columns update successfully with the same request format. The lack of detailed error messages makes it difficult to understand the root cause of the issue.

Hi @trothe,
This is likely an issue with the SharePoint API's . Please post this on the Microsoft Q&A forum where the appropriate team will be able to help.


 I converted them into webp which has reduced the size dramatically while mostly preserving the quality needed:
❯ git branch --show-current
main
❯ l
Permissions Size User     Date Modified Name
.rw-r--r--  1.1M sangeeth 30 Oct 01:12  1.png
.rw-r--r--  1.1M sangeeth 30 Oct 01:12  2.png
.rw-r--r--  1.2M sangeeth 30 Oct 01:12  3.png
.rw-r--r--   55k sangeeth 30 Oct 01:12  banner-light.png
.rw-r--r--  644k sangeeth 30 Oct 01:12  screenshot.png
.rw-r--r--  598k sangeeth 30 Oct 01:12  tn.png
❯ gco chore/optimize-readme-images
Switched to branch 'chore/optimize-readme-images'
Your branch is up to date with 'origin/chore/optimize-readme-images'.
❯ l
Permissions Size User     Date Modified Name
.rw-r--r--  234k sangeeth 30 Oct 01:12  1.webp
.rw-r--r--  228k sangeeth 30 Oct 01:12  2.webp
.rw-r--r--  318k sangeeth 30 Oct 01:12  3.webp
.rw-r--r--  9.3k sangeeth 30 Oct 01:12  banner-light.webp
.rw-r--r--  168k sangeeth 30 Oct 01:12  screenshot.webp
.rw-r--r--  126k sangeeth 30 Oct 01:12  tn.webp

This should also make it easier to do shallow clones of this repo but it might be worthwhile cleaning up the large images in older commits to make it faster to do a full clone. But that's a bigger task and would need force pushes.

Nice work, I'll take care of force pushing if it's not too destructive.

Wait I saw that you changed the urls in the README, they are like this so https://themes.gohugo.io/themes/typo/ can render them correctly. Please change them to the raw path. Also, now that I think about this, I hope webp can be rendered correctly on that website.

Ah, my bad. I had a feeling that could be the case too. Sure thing, will fix that.
I believe rendering shouldn't be affected but the user must be using a newer browser with webp support which looks great these days: https://caniuse.com/?search=webp

@tomfran updated it. Tested render by changing the extension to .png locally so once webp files are there, should reflect that.


GH-671 - Deprecate events aws sns and sqs modules

Closes : #671
cc: @odrotbohm

That's merged. Thanks!


Add weak generics for array type objects

Summary

Add weak default generics of the kind <array-key, mixed> for default casts that returns those generics, i.e. json, array, arrayable and collection casts.
Solves #1614
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

[x] Existing tests have been adapted and/or new tests have been added
[x] Update the README.md
[x] Code style has been fixed via composer fix-style

Could we get this merged?


Updated description of Fluo in README.md

related changes apache/fluo-website#146 apache/fluo-website#147


Lasagna Master: Improve task 3 (AddSecretIngredient)

Fix #2036

Update to README.md to install golint
Update AddSecretIngredient tests to update myList instead of returning
Update exemplar, instructions and hints

One last thing: for your contribution to this exercise, feel free to add your github handle to the contributors of the exercise: https://github.com/exercism/go/blob/main/exercises/concept/lasagna-master/.meta/config.json#L4


Work around internal API of 2024.2 OpenInRightSplitSplit

2024.2 made this API internal without a replacement, despite use in published plugins.
This has been reported to JetBrains YouTrack  at https://youtrack.jetbrains.com/issue/IJPL-158380
"Generate OpenAPI" does not open a split mode anymore, so this use of the split action was removed.
This PR also updates to the latest beta of 2024.2 to make sure that the plugin verifier is running with a version which already contains the API change.
This change can be tested by navigating to a source file from the AppMap webview.
I've tested this on 2023.1 and 2024.2 eap.

:tada: This issue has been resolved in version 0.73.0 :tada:
The release is available on:

v0.73.0
GitHub release

Your semantic-release bot :package::rocket:


Release procedure - further automation

Inside #221 we did a great step towards release automation.
Need to think about automating some steps that are still manual: release branch creation, pull request to master, tag creation and pushing, manual call of mvn clean deploy.
Maybe maven-release-plugin would further automate these steps

Tag creation is in fact automated in #221
Our readme is inaccurate which should be improved in #341


Add a project prelude

Related to #14.

Merged with https://github.com/lwm/tasty-discover/commit/c7bd5e129f2b36575ef632834b6f8ea1ca7bae2b


create a Hub interface

Enhancement: create an interface for Hub.
Fixes #271

[x] All tests passed
[x] Add change to changelog.md

Environment

OS: Mac OS
Go version: 1.19

In general, we try not to export types if possible since they become part of our public contract.
In my tests I usually create an interface in my own code to represent 3rd party libraries. It sounds like you're not able to do this, but I'm curious if you could help me get your use case a bit more.
So, for instance, I'd define this interface in my own code (ie, not in eventhubs):
https://github.com/Azure/azure-event-hubs-go/pull/272/files#diff-953fe0899f69d47c633cae4a70be7c2838ecc0098165d06066e295f6d019d6e6R60
And then here:
https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/12795/files#diff-81400d54e06c8ca9e9898e2be70ab7318917716a47612dd658b5933191a44abfR44
I'd create a function that takes that interface, and pass the result of the constructor function to it.
Closing this for now, but please feel free to reopen/reply.

The Hub struct implements Receive(ctx context.Context, partitionID string, handler eventhub.Handler, opts ...eventhub.ReceiveOption) (*eventhub.ListenerHandle, error), which returns a ListenerHandle struct which is a struct I cannot mock. ListenerHandle has unexported fields, so I cannot set ctx orr in it.
When I try to bind to the lifecycle of the handle, I get a panic since ctx is not set:
// Done will close the channel when the listener has stopped
func (lc *ListenerHandle) Done() <-chan struct{} {
	return lc.ctx.Done()
}

Not sure how to address this, except by building a complete wrapper around your implementation and expanding quite some time doing so.


Rename classes to start using the Port and `

This issue was created by error. The correct one is #270


Pre-set keyboard to be lowercase

Change need to change to lower case when adding items / shops to shopping list

See issue #11


Scientific notation in output

Allow configuration of the output format (as done with to exact/20dp/etc) but for scientific notation.
This might be possible already, but I can't figure out how to do this.
We might also allow for other notations, like those mentioned in the above Wikipedia article. I would be willing to put some work into this.
Thank You!

Thanks for raising this issue! Yeah, scientific notation is not currently supported as an output format, but I agree it’d be a really nice feature to have.
Unfortunately the whole formatting part of the code is quite a mess, but if do you feel up to implementing this I’d be super grateful :)

Nice! Well, I've looked through the code and found BigRat::format_as_decimal, but there's a lot more for me to comprehend. I might continue this journey when I have more time at hand. I haven't seen enough code to understand how the formatting code could be simplified, but yeah, it's quite complex :D

Scientific notation would be very useful, I think it should follow the usual convention 1.234E12, perhaps even with an option to write it as 1.234*10^12
There should also be an option to set the number of significant digits, usually only 3 are relevant (4, if the first digit is a 1, as in the example above).


Include initContainers when calculating pod overhead

https://github.com/2i2c-org/infrastructure/pull/3569 changed the cryptnono daemonset to have different resource requests for the init containers as well as the container. While working on https://github.com/2i2c-org/infrastructure/pull/3566, I noticed this was generating wrong choices - the overhead was calculated wrong (too small).
We were intentionally ignoring init containers while calculating overhead, and turns out the scheduler and the autoscaler both do take it into consideration. The effective resource request for a pod is the higher of the resource requests for the containers or the init containers - this ensures that a pod with higher requests for init containers than containers (like our cryptnono pod!) will actually run. This is documented at
https://kubernetes.io/docs/concepts/workloads/pods/init-containers/#resource-sharing-within-containers, and implemented in Kubernetes itself at
https://github.com/kubernetes/kubernetes/blob/9bd0ef5f173de3cc2d1d629a4aee499d53690aee/pkg/api/v1/resource/helpers.go#L50 (this is the library code that the cluster autoscaler uses).
This PR updates the two places we currently have that calculate effective resource requests (I assume eventually these will be merged into one - I haven't kept up with the team's work last quarter here).
I've updated the node-capacity-info.json file, which is what seems to be used by the generator script right now.

Put up the adjusted memory limits in https://github.com/2i2c-org/infrastructure/pull/3573 - I'm not sure why an update for r5.4xlarge was needed (seems unrelated to the fixes here, as the fix should be a no-op).

@yuvipanda this looks great, I added a commit where I re-executed the generate command for all clusters based on a comment in the daemonset-requests.yaml file:
# This file isn't updated by automation, but can easily be updated by manually
# running a command once for each cluster:
#
#     ls config/clusters | xargs -I {} deployer generate resource-allocation daemonset-requests {}
#

Ah, thank you @consideRatio! I'll do that next time I change any code that affects these generated.