Miss-aligned headers on Android and iOS - Reported by @adeel0202

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Login in New Dot
Go to Settings > Preferences

Go to Settings > Security

Expected Result:
Tittle on top should be aligned
Actual Result:
Tittle on top is miss aligned
Workaround:
User can use New Dot without problems
Platform:

Where is this issue occurring?

Android
iOS

Version Number: 1.1.33-3
Reproducible in staging?: Y
Reproducible in production?:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @aldo-expensify @adeel0202
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1643179669442200
View all open jobs on GitHub

Triggered auto assignment to @strepanier03 (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Current assignee @MitchExpensify is eligible for the External assigner, not assigning anyone new.

this issue is happening because within header.js we are using subtitle wrong:
https://github.com/Expensify/App/blob/2c14f01af550f554bc1f488a35654c36b437ba65/src/components/Header.js#L29-L34
props.subtitle will allways be a string, we must compare it with another way, and we also need return a fragment if we dont want to return a subtitle:
i suggest we change to:
const Header = props => (
    <View style={[styles.flex1, styles.flexRow]}>
        <View style={styles.mw100}>
            <Text numberOfLines={2} style={[styles.headerText, styles.textLarge]}>
                {props.title}
            </Text>
            {/* If there's no subtitle then display a fragment to avoid an empty space which moves the main title */}
            {(props.subtitle.trim().lenght > 0)
                ? <Text style={[styles.mutedTextLabel]}>{props.subtitle}</Text>
                : <></>}
        </View>
        {props.shouldShowEnvironmentBadge && (
            <EnvironmentBadge />
        )}
    </View>
);

Previously raised by the contributor here https://expensify.slack.com/archives/C01GTK53T8Q/p1643179669442200
Issue was not opened by applause earlier as there was no feedback on the issue from Expensify employees.

The issue is reproducible on iOS too.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

Triggered auto assignment to @mountiny (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@adeel0202 Would like to propose a solution or should I review the existing ones?

@parasharrajat, you can review the existing one.

Updated the title so we do not forget to pay @adeel0202 for reporting the issue.
Let's not forget it is happening on both iOS and Android.

@mateusbra I think we can just add a Boolean check with _.isString
Boolean(props.subtitle) &&  _.isString(props.subtitle)

Should that be enough?

@parasharrajat I think it is, updated my proposal.

Yeah, correct.
It should be like
{_.isString(props.subtitle)
         ? Boolean(props.subtitle) && <Text style={[styles.mutedTextLabel]}>{props.subtitle}</Text>
         : props.subtitle}

Proposal updated again, also added IOS's screenshots

📣 @mateusbra You have been assigned to this job by @mountiny!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

Thank you for the review @parasharrajat. @mateusbra Feel free to create a PR. Thank you for working on this!

@mountiny May I send a proposal on upwork?

Sure!

Proposal sent on upwork, once I'm hired I'll rise a PR

@parasharrajat hired for eventual C+ payment
@mateusbra hired for eventual solution payment
@adeel0202 please also apply for eventual reporting payment - Job - Thank you!

@MitchExpensify, applied on Upwork for reporting. Thanks

PR was merged 💪

Hired @adeel0202 ! Thanks

This was deployed to production on Friday 2022-02-04. The wrong format of linking the PR has been used which caused that the automatic update has not happened.

There is one thing that we missed in the PR. we forgot to update the HeaderView component. https://github.com/Expensify/App/blob/8431ed41e33092af1e42a143d7364f95b14287fe/src/pages/home/HeaderView.js#L150-L161
@mateusbra Will, you be able to create a follow-up PR?

Paid!


Rock, Paper, Scissors!

Before jumping into Pr first comment for assign.All Problem from Edabit. Link is mandatory to add
Problem statement: Write a function to simulate the rock, paper, scissors game between Abigail and Benson.
Problem Link: https://edabit.com/challenge/p6uXeD7JC7cmxeD2Z

Before submitting a PR please Check some details.Check Edabit for problem task

[ ] fileName formet should be in camelcase
example- returnTheNextNumber.py
[ ]  Add label for Problem
[ ]  In file there should be problem statement and link to probelm
example -

'''
Abigail and Benson are playing Rock, Paper, Scissors.

Each game is represented by an array of length 2, where the first element represents what Abigail played and the second element represents what Benson played.

Given a sequence of games, determine who wins the most number of matches. If they tie, output "Tie".

R stands for Rock
P stands for Paper
S stands for Scissors

Examples
calculate_score([["R", "P"], ["R", "S"], ["S", "P"]]) ➞ "Abigail"

# Ben wins the first game (Paper beats Rock).
# Abigail wins the second game (Rock beats Scissors).
# Abigail wins the third game (Scissors beats Paper).
# Abigail wins 2/3.

calculate_score([["R", "R"], ["S", "S"]]) ➞ "Tie"

calculate_score([["S", "R"], ["R", "S"], ["R", "R"]]) ➞ "Tie"

This repository is vaild for HacktoberFest2020

Read before making PR - [How to contribute on Github](https://www.dataschool.io/how-to-contribute-on-github/)
Good Luck,

@aayushi-droid: Please add the label hard and assign this issue to me.
Thanks in advance.

can I work on this problem
could you assign this problem to me

Assign me to this task

@rianrishu @DevLokCodes This is already solved, I have made a PR for this aswell. Please follow the repo guidelines and make another issue.

Thanks for messaging but priority will give to issue-author(who created the issue)


Fix some things

Fix some things, not all

Hi

I added a title and removed the facebook image

Almost forgot, also removed the stackoverflow image on the notifications


dev > master for 2.0 release

Many thanks to contributing to nf-core/rnaseq!
To ensure that your build passes, please make sure your pull request is to the dev branch rather than to master. Thank you!
Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).
PR checklist

[ ] PR is to dev rather than master
[ ] This comment contains a description of changes (with reason)
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If necessary, also make a PR on the nf-core/rnaseq branch on the nf-core/test-datasets repo
[ ] Ensure the test suite passes (nextflow run . -profile test,docker).
[ ] Make sure your code lints (nf-core lint .).
[ ] Documentation in docs is updated
[ ] CHANGELOG.md is updated
[ ] README.md is updated

Learn more about contributing: https://github.com/nf-core/rnaseq/tree/master/.github/CONTRIBUTING.md

Thanks for the review @apeltzer! Addressed all of the comments :)

The EBI API is misbehaving again for some reason which is why that single test is failing in all of the tests so far 😞 Its a timeout downloading the files from the EBI which may or may not sort itself out. Will look into it further at some point.


Create schedule modal notifications missing padding

There is no padding around the notifications section of the modal.

@Jagjit-Thind for updates.


handle IOExceptions while writing resubscriptions (and pending data) …

IOExceptions thrown as a result of writing to the OutputStream during a reconnect, whilst trying to write subscription (and pending) commands should not be silently ignored.  This could lead to the scenario where the library believes it has successfully recovered a connection, but where some subscriptions have not been re-established.
This scenario may also be especially likely, given that the reconnection code may run where there are networking issues/partitions .  At this time, conceivably, a backlog of pending RPC-like requests (i.e., publishes that require a response via a one-shot inbox) may have accumulated, leading to an excess of subscriptions to re-establish.

Coverage decreased (-0.1%) to 93.624% when pulling 432c7fd64e5a3063d647bc899a90230167bd7ca9 on edam:resub-bw-fix into 28ae1cc2ef8f63251993c23d76ca1e59ff18e3f1 on nats-io:master.

Too many library changes to bring this PR in, if you see something similar in 2.x please resubmit.


Client method "CheckUserSubsription" -> "CheckUserSubscription"

Simple spelling mistake—you'll definitely want to merge this before you release v2, though =b

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.55%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1205

Relevant Lines:
1302

💛  - Coveralls


Add support for posting content via a REST API

This PR adds a REST API that can be accessed by users to perform the following operations:

Create an article: api.articles.store
Update an article: api.articles.update
Delete an article: api.articles.delete

The idea is that bloggers could set up an API integration that would allow them to automatically publish content to Laravel IO when their articles go live. This would make it far easier to port content over to Laravel IO and increase article output.
These routes are protected by Laravel Sanctum. Tokens can be created and deleted from a user's profile settings page.
All 3 endpoints reuse the existing controllers, allowing for validation rules, request objects and more to be shared across HTTP and REST, reducing the amount of maintenance required to keep the API up to date.

@lukeraymonddowning can you maybe rebase with main to make sure the new UI is working on the recently merged Tailwind v3 PR?

@driesvints rebased. UI is fine after the update 👍

I'll try to review all of this again this weekend. Thanks!

This was a fantastic PR. Thank you so much for this @lukeraymonddowning 👏
I also opened an issue to follow up with some documentation eventually: https://github.com/laravelio/laravel.io/issues/803. We'll try to look into that when we find some time.

I'm not sure if I miss something but I think that there is currently no way to obtain the api token created by sanctum. The user profile only displays the hashed api token. The unhashed token should be displayed once after creating the api token was created (see docs)

@SamuelNitsche you're right, an oversight by me. Going to push a fix later


Fixed typo

Some might debate that both forms are right, but "First things first" is the correct form of the idiom :)
https://english.stackexchange.com/questions/7419/which-is-the-correct-idiom-first-things-first-or-first-things-first
https://www.englishforums.com/English/FirstThingsFirstFirstThings-First/xjjrg/post.htm

Thanks!


Add method to IOperationalStoreNotification for device code cleanup

IOperationalStoreNotification has a method for when persisted grants are cleaned up. Consider adding a corresponding method for when device codes are cleaned up.
This is a breaking change.

now's the time @scottbrady91

PR merged.


Write moar tests (WIP)

Don't merge!
I need to add some validation for the login component, and then write the tests for it. Will also add Actions and Reducers tests.

Good to merge!


[Partner submission] [Data Validation] Ensure email address format is valid (email address prefix + @ symbol + email domain)

Submitted Description:
UST Portal rejected an upload for the email address b/c someone entered “James Comer<EMAIL_ADDRESS>- would be a nice-to-have feature to ensure entries follow a valid email address format ((email address prefix + @ symbol + email domain) either in Render or Excel
(Optional) Uploaded file - click to download:
https://www.jotform.com/uploads/grants.dev/212695501572052/5341677518212551069/Capture12.PNG

This submissions can be deleted, it's a duplicate. I must've submitted the same request twice.


v4 Emulator fails to connect using Node.js proactive bot file.

Sample information

Sample type: samples
Sample language: nodejs
Sample name: 16.proactive-messages

Describe the bug
The .bot file refuses to open in the v4 Emulator.
To Reproduce
Steps to reproduce the behavior:

Open the BotBuilder-Samples/samples/javascript_nodejs/16.proactive-messages/ folder in VS Code.

In the terminal, enter npm i and npm start to get the bot running.

Open the v4 Emulator.

Try to open the Node.js proactive-messages.bot.
Nothing happens.
Try to open the Node.js echobot-with-counter.bot [sample 2], which uses the same port.
The Emulator connects to the bot.

Expected behavior
Opening the proactive-messages.bot file in the Emulator should connect to the bot.
Additional context
I tried copy-pasting the contents of the echobot-with-counter.bot file to the proactive-messages.bot file, then updating the "name" property, and still got the same behavior. I am completely baffled.
[bug]

@JonathanFingold What version of the emulator are you using?
Are you on a Mac, PC or linux?

@benbrown I'm on Windows 10 Enterprise x64, using "Bot Framework Emulator (V4 PREVIEW) version 4.0.196-nightly.

@benbrown PS. Creating an echo bot from the Yeoman template produces the same behavior. I've tried both js and ts templates.

@JonathanFingold thanks for the info. I am not able to reproduce so far, but I'm still investigating.

Here's some additional system info:
node v8.12.0
npm 6.4.1
python 3.7.0
yeoman 2.0.5
botbuilder 4.0.6

@JonathanFingold can you give it a shot with a slightly newer build of the emulator? I can't reproduce with 577-nightly for example.

@benbrown Well, that appears to have been mostly it. I uninstalled the emulator and installed the preview, and now it's working, at least with the changes I had already made to the .bot file.
I'll revert those to see if it still works
Bot Framework Emulator (V4 PREVIEW)
version: 4.0.0-preview.40326

@benbrown Okay, it seems to work, even after reverting the .bot file. Closing.


Ctrl+C shortcut broken

Describe the bug

Upon activating the shortcut, two windows for Add Shortcut open, one with no text selected, and one containing the word that was selected.
If you select a word and press the shortcut to Add Shortcut, it creates two windows. Trying to add a chord through the window that has the selected word results in an error The chord for '' needs to be at least two characters. and trying to press the "Close" button on the window with the word closes the other window instead, and results in an error without closing this window:

Error: Invalid Gui name.

Specifically: 0xc0552:Destroy

              Line#
--->       108: Gui,%window_handle%:Destroy

The current thread will exit.

Pressing the "Close" button further after the window without the selected word has been closed does nothing but output the error,  and trying to close the window manually via the window controls results in the same error, but closes the window.

Useful Details

Default ZipChord settings, available upon installation.
The appearance of this bug seems to be influenced by how long the Ctrl+C shortcut is pressed for.

Thanks, @kurushimee! The Add Shortcut window should now simply refocus if the Add Shortcut feature is triggered again by the keyboard shortcut or from the tray icon.


Package doesn’t actually contain typings

Check it out<EMAIL_ADDRESS>

Good catch!


faucet bug

What version of Wallet are you using?
0.7.2
What is happening?
When I'm testing both faucets (the SwaySwap one, and the faucet-beta-3.fuel.network), none of them are working. The receive Ether button just keeps endlessly loading and at the end of the day I get nothing but this errors
1: "Failed to submit transaction with error: Response errors; Transaction is not inserted. UTXO is not existing: 0xffdc1e1d44dfdf5b169691ea17b08b178728d6609c93dce6e16dcb8fd280c10b01"
2: "Failed to submit transaction with error: Response errors; Transaction is not inserted. More priced tx 0x9384963263e33e3d5a536b59c5d50b9533149ae62f13163b63d47ef610400f70 already spend this UTXO output: 0x63863116dbc37ed969cd7e5c6c8a60f3557a027710d76bd407b7980b6eaa227501"
steps to reproduce
Freshly created wallet, localhost ip, clean browser cache
How it should behave?
Having used it in Beta-2 testnet, I know that it just should send testnet tokens to my wallet in the matter of seconds
What os are you seeing the problem on?
Windows Desktop
What browser?
Chrome
What is your browser version?
Version 111.0.5563.64 (Official Build) (64-bit)

@edikbass777, thanks for the report. In the past weeks, our network was unstable, causing transactions to be very slow and not finishing the execution, making things like the faucet unable to create TXs. This should be solved now.


Train Data Format

Hi, I'm trying to train DeLF on my custom dataset but I'm not able to understand how to arrange the data set. Where should i place my data and in what format should it be. Could anyone please help me.
Any help would be great.

i want to know too

I have same problem

DeLF use ImageFolder to load data.
https://pytorch.org/docs/stable/torchvision/datasets.html?highlight=imagefolder#torchvision.datasets.ImageFolder


While signing CCLA, I added new org called 'corona', however in Salesforce, company is created with name 'Erasmus Corona' and email is triggered with the same name.

Steps:

While signing CCLA, enter an org name which doesn't exists in DB. I entered an org name called 'corona', it didn't exist so I clicked on add new org and added org name 'corona'

Select No option for CLA Manager.
Enter CLA Manager detail.
Check Salesforce for the newly created org.

Actual Result 1: Email is received with subject having different org name 'Erasmus Corona' which I have not created: "EasyCLA: Invitation to Sign the Erasmus Corona Corporate CLA and add to approved list mayurbr"

Expected Result 1: Org. should be created with the same name what is entered.

Login to Corporate console with the CLA Manger Credential and sign the CCLA. Observe the org name on the template.
Template shows correct Org name on template. In my case it shows org Name 'corona'

@dealako @wanyaland Pranab is also able to reproduce this issue. He added organization called 'tabletop' and it prepended 'BHS' in front of it. Recording is shared over slack.

@dealako @ashav-github. This case is due to a core services check that gets company name based on a the given url it now updates the company name and disregards the input that was provided for the name.
{
    "id": "57add517-0477-4d90-9b4e-87bc77c15332",
    "name": "BHS tabletop",
    "legalName": null,
    "domain": "tabletop.com",
    "domainAliases": [],
    "site": {
        "phoneNumbers": [],
        "emailAddresses": []
    },
    "category": {
        "sector": "Information Technology",
        "industryGroup": "Software & Services",
        "industry": "Internet Software & Services",
        "subIndustry": "Internet",
        "sicCode": "87",
        "naicsCode": "54"
    },
    "tags": [
        "Internet",
        "Technology",
        "B2C",
        "B2B"
    ],
    "description": null,
    "foundedYear": nul

Spoke with @niravpatel27 on this topic. He is going to work with the Organization Service team to provide an API to query using the website URL to obtain the Organization name from the clearbit service.

Once the above API is in place, we can add a link to this API from the EasyCLA to allow the contributor console use the query to determine if the website URL can obtain the organization legal name.

It was discussed in the  18-Dec bug triage that it should be marked for Post-EasyCLAv2Release however we should try to get it in the release.

Closing this issue due to inactivity or lack of interest. This issue is likely already resolved.


Change check for ups setup

In Spack builds, was giving:
CMake Error at /scratch/supercalifragilisticexpialidocious_extra_padding_directory/cetmodules/2.16.02/linux-scientific7-x86_64-gcc-9.3.0-efgr3lefvtp7ov743itbkatnmudqw3sx/Modules/FindCppUnit.cmake:9 (if):
if given arguments:
"AND" "EXISTS" "/lib/pkgconfig/cppunit.pc"

Unknown arguments specified

I'm confused, @marcmengel: PR #1  should have fixed this, and I'm not seeing the error on my Mac. Could you verify the error still occurs for you with just the code as it is as of 126aef7?

Sorry, totally missed the double quotes in the develop branch.

NP.


Builiding Problem

Hi @xiaocong
I am trying  to build this using gradle but I am stuck on some nanohttpd, jsonrpc4j and jackson  dependency problem. Please help. How do I point the project to the right address/repository?
Here are the errors I am getting:-
FAILURE: Build failed with an exception.

What went wrong:
A problem occurred configuring project ':app'.

Could not resolve all dependencies for configuration ':app:_debugAndroidTestCompile'.
Could not resolve com.nanohttpd:nanohttpd:2.1.1.
Required by:
android-uiautomator-server-master:app:unspecified
Could not resolve com.nanohttpd:nanohttpd:2.1.1.
Could not get resource 'https://jcenter.bintray.com/com/nanohttpd/nanohttpd/2.1.1/nanohttpd-2.1.1.pom'.
Could not GET 'https://jcenter.bintray.com/com/nanohttpd/nanohttpd/2.1.1/nanohttpd-2.1.1.pom'.
Connection to https://jcenter.bintray.com refused
Could not resolve com.nanohttpd:nanohttpd:2.1.1.
Could not get resource 'https://repo1.maven.org/maven2/com/nanohttpd/nanohttpd/2.1.1/nanohttpd-2.1.1.pom'.
Could not GET 'https://repo1.maven.org/maven2/com/nanohttpd/nanohttpd/2.1.1/nanohttpd-2.1.1.pom'.
Connection to https://repo1.maven.org refused
Could not resolve com.fasterxml.jackson.core:jackson-core:2.5.3.
Required by:
android-uiautomator-server-master:app:unspecified
Could not resolve com.fasterxml.jackson.core:jackson-core:2.5.3.
Could not get resource 'https://jcenter.bintray.com/com/fasterxml/jackson/core/jackson-core/2.5.3/jackson-core-2.5.3.pom'.
Could not GET 'https://jcenter.bintray.com/com/fasterxml/jackson/core/jackson-core/2.5.3/jackson-core-2.5.3.pom'.
Connection to https://jcenter.bintray.com refused
Could not resolve com.fasterxml.jackson.core:jackson-core:2.5.3.
Could not get resource 'https://repo1.maven.org/maven2/com/fasterxml/jackson/core/jackson-core/2.5.3/jackson-core-2.5.3.pom'.
Could not GET 'https://repo1.maven.org/maven2/com/fasterxml/jackson/core/jackson-core/2.5.3/jackson-core-2.5.3.pom'.
Connection to https://repo1.maven.org refused
Could not resolve com.fasterxml.jackson.core:jackson-annotations:2.5.3.
Required by:
android-uiautomator-server-master:app:unspecified
Could not resolve com.fasterxml.jackson.core:jackson-annotations:2.5.3.
Could not get resource 'https://jcenter.bintray.com/com/fasterxml/jackson/core/jackson-annotations/2.5.3/jackson-annotations-2.5.3.pom'.
Could not GET 'https://jcenter.bintray.com/com/fasterxml/jackson/core/jackson-annotations/2.5.3/jackson-annotations-2.5.3.pom'.
Connection to https://jcenter.bintray.com refused
Could not resolve com.fasterxml.jackson.core:jackson-annotations:2.5.3.
Could not get resource 'https://repo1.maven.org/maven2/com/fasterxml/jackson/core/jackson-annotations/2.5.3/jackson-annotations-2.5.3.po
Could not GET 'https://repo1.maven.org/maven2/com/fasterxml/jackson/core/jackson-annotations/2.5.3/jackson-annotations-2.5.3.pom'.
Connection to https://repo1.maven.org refused
Could not resolve com.fasterxml.jackson.core:jackson-databind:2.5.3.
Required by:
android-uiautomator-server-master:app:unspecified
Could not resolve com.fasterxml.jackson.core:jackson-databind:2.5.3.
Could not get resource 'https://jcenter.bintray.com/com/fasterxml/jackson/core/jackson-databind/2.5.3/jackson-databind-2.5.3.pom'.
Could not GET 'https://jcenter.bintray.com/com/fasterxml/jackson/core/jackson-databind/2.5.3/jackson-databind-2.5.3.pom'.
Connection to https://jcenter.bintray.com refused
Could not resolve com.fasterxml.jackson.core:jackson-databind:2.5.3.
Could not get resource 'https://repo1.maven.org/maven2/com/fasterxml/jackson/core/jackson-databind/2.5.3/jackson-databind-2.5.3.pom'.
Could not GET 'https://repo1.maven.org/maven2/com/fasterxml/jackson/core/jackson-databind/2.5.3/jackson-databind-2.5.3.pom'.
Connection to https://repo1.maven.org refused
Could not resolve com.github.briandilley.jsonrpc4j:jsonrpc4j:1.1.
Required by:
android-uiautomator-server-master:app:unspecified
Could not resolve com.github.briandilley.jsonrpc4j:jsonrpc4j:1.1.
Could not get resource 'https://jcenter.bintray.com/com/github/briandilley/jsonrpc4j/jsonrpc4j/1.1/jsonrpc4j-1.1.pom'.
Could not GET 'https://jcenter.bintray.com/com/github/briandilley/jsonrpc4j/jsonrpc4j/1.1/jsonrpc4j-1.1.pom'.
Connection to https://jcenter.bintray.com refused
Could not resolve com.github.briandilley.jsonrpc4j:jsonrpc4j:1.1.
Could not get resource 'https://repo1.maven.org/maven2/com/github/briandilley/jsonrpc4j/jsonrpc4j/1.1/jsonrpc4j-1.1.pom'.
Could not GET 'https://repo1.maven.org/maven2/com/github/briandilley/jsonrpc4j/jsonrpc4j/1.1/jsonrpc4j-1.1.pom'.
Connection to https://repo1.maven.org refused
Could not resolve javax.servlet:servlet-api:2.5.
Required by:
android-uiautomator-server-master:app:unspecified
Could not resolve javax.servlet:servlet-api:2.5.
Could not get resource 'https://jcenter.bintray.com/javax/servlet/servlet-api/2.5/servlet-api-2.5.pom'.
Could not GET 'https://jcenter.bintray.com/javax/servlet/servlet-api/2.5/servlet-api-2.5.pom'.
Connection to https://jcenter.bintray.com refused
Could not resolve javax.servlet:servlet-api:2.5.
Could not get resource 'https://repo1.maven.org/maven2/javax/servlet/servlet-api/2.5/servlet-api-2.5.pom'.
Could not GET 'https://repo1.maven.org/maven2/javax/servlet/servlet-api/2.5/servlet-api-2.5.pom'.
Connection to https://repo1.maven.org refused
Could not resolve javax.portlet:portlet-api:2.0.
Required by:
android-uiautomator-server-master:app:unspecified
Could not resolve javax.portlet:portlet-api:2.0.
Could not get resource 'https://jcenter.bintray.com/javax/portlet/portlet-api/2.0/portlet-api-2.0.pom'.
Could not GET 'https://jcenter.bintray.com/javax/portlet/portlet-api/2.0/portlet-api-2.0.pom'.
Connection to https://jcenter.bintray.com refused
Could not resolve javax.portlet:portlet-api:2.0.
Could not get resource 'https://repo1.maven.org/maven2/javax/portlet/portlet-api/2.0/portlet-api-2.0.pom'.
Could not GET 'https://repo1.maven.org/maven2/javax/portlet/portlet-api/2.0/portlet-api-2.0.pom'.
Connection to https://repo1.maven.org refused
Could not resolve junit:junit-dep:4.10.
Required by:
android-uiautomator-server-master:app:unspecified > com.android.support.test:runner:0.2
Could not resolve junit:junit-dep:4.10.
Could not get resource 'https://jcenter.bintray.com/junit/junit-dep/4.10/junit-dep-4.10.pom'.
Could not GET 'https://jcenter.bintray.com/junit/junit-dep/4.10/junit-dep-4.10.pom'.
Connection to https://jcenter.bintray.com refused
Could not resolve junit:junit-dep:4.10.
Could not get resource 'https://repo1.maven.org/maven2/junit/junit-dep/4.10/junit-dep-4.10.pom'.
Could not GET 'https://repo1.maven.org/maven2/junit/junit-dep/4.10/junit-dep-4.10.pom'.
Connection to https://repo1.maven.org refused

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED
Total time: 1 mins 16.99 secs

could u check if ur internet connection is ok?

@xiaocong
Internet is working fine, see below..
c:\Automation\ui_test\android-uiautomator-server-master>curl http://www.google.co.za
<!doctype html>Google

Hi @xiaocong
I managed to fix this. I had to set the HTTPS proxy on gradle. For some reason, it was not picking up the default proxy and on my cmd, I was only setting HTTP.
Here is the solution in case anyone comes across this problem:
gradle -Dhttp.proxyHost=<proxy>  -Dhttp.proxyPort=<port> -Dhttps.proxyHost=<proxy>  -Dhttps.proxyPort=<port> build

Great :+1:


iso-image: make reproducible by not relying on mcopy's readdir

Motivation for this change
https://r13y.com/diff/a367e8e30543e46b5ba60b938d64758ec869a804cdfc4b741baa49a6787115bb-5e7bb023000e2db7a008918f0f7bb59a6f66d17fe4974a54ee7945e9cf9675d8.html
My investigation ended up in mcopy's copying implementation relying on readdir order (file unixdir.c).
I'm not sure of the fix yet, as diffoscope raises a much bigger than expected diff. If someone knows the attribute path to one of our tests that exercises this code, I'll be happy to trigger an ofborg run.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Looks like this did break master as reported in #58691. I've reverted for now and re-opened as WIP in https://github.com/NixOS/nixpkgs/pull/58694


Add a tendermint-validator crate

fixes #1134

[x] Referenced an issue explaining the need for the change
[x] Updated all relevant documentation in docs
[x] Updated all code comments where relevant
[x] Wrote tests
[x] Added entry in .changelog/

this PR may be a bit big, so will wait for https://github.com/informalsystems/tendermint-rs/pull/1147 to be merged + will split this one up (perhaps traits and server mods to be in two separate PRs)

A note on the tendermint-validator name: to me that name implies this code implements a validating full node, so it feels a little misleading.
Perhaps tendermint-privval would be a better name to indicate this code implements the server-side of a "privval" connection coming from a validator?

Thanks @tony-iqlusion ! Yes, tendermint-privval may be a better name.
As for the SignerProvider trait, I guess there are a few options:

use async_signature::Signer directly instead and require public keys as a separate explicit input argument to the privval service (this may be a bit more error-prone and one will find out any signer-related issues only after the first signing request arrives)
a new version of async_signature that will add public key retrieval functions and use that directly instead
change SignerProvider to take async_signature::Signer as a type parameter

What do you think?

@tomtau for "public key retrieval", in cosmrs we use a helper trait with a blanket impl:
https://docs.rs/cosmrs/latest/cosmrs/crypto/secp256k1/trait.EcdsaSigner.html
Upstreaming something like this into signature/async-signature is something I've considered.

Codecov Report

Merging #1152 (2e20e64) into master (6a28510) will increase coverage by 1.1%.
The diff coverage is 86.7%.

@@           Coverage Diff            @@
##           master   #1152     +/-   ##
========================================
+ Coverage    64.7%   65.8%   +1.1%
========================================
  Files         232     238      +6
  Lines       15667   16203    +536
========================================
+ Hits        10138   10667    +529
- Misses       5529    5536      +7

Impacted Files
Coverage Δ

privval/src/error.rs
0.0% <0.0%> (ø)

tendermint/src/signature.rs
58.3% <0.0%> (-1.7%)
:arrow_down:

privval/src/config.rs
60.0% <60.0%> (ø)

privval/src/server.rs
85.1% <85.1%> (ø)

privval/src/state.rs
97.1% <97.1%> (ø)

privval/src/lib.rs
100.0% <100.0%> (ø)

privval/src/signer.rs
100.0% <100.0%> (ø)

tendermint/src/consensus/state.rs
99.4% <100.0%> (+10.0%)
:arrow_up:

tendermint/src/private_key.rs
61.2% <100.0%> (+4.4%)
:arrow_up:

tendermint/src/block/commit_sig.rs
78.4% <0.0%> (-2.0%)
:arrow_down:

... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@tony-iqlusion that's the third option and it seems good: if it's upstreamed into signature/async-signature in the future, it shouldn't be difficult to change. So, I switched SignerProvider to be a helper trait.
@thanethomson this PR should be good to go (sans some questions on the other PR: https://github.com/informalsystems/tendermint-rs/pull/1147#issuecomment-1170799635 ) -- I could possibly add those signature trait implementations in #1147 if it's preferable to split it that way.

Did a quick pass and this is looking good now!
I'll try to more thoroughly review this next week.

@tomtau here's a PR to add a Keypair trait to the signature crate:
https://github.com/RustCrypto/traits/pull/1080
It could have a corresponding AsyncKeypair trait in the async-signature crate.

Added AsyncKeypair: https://docs.rs/async-signature/0.2.0/async_signature/trait.AsyncKeypair.html

It seems this is blocked on #1225

I'm not sure when I'll get to this PR. Are you looking into merging it soon or is anyone interested in taking over it?

No rush from our side, so feel free to come back to it whenever it suits you if you are still interested in getting this merged. And sorry for not being very reactive with this PR, we've had and still have limited capacity to work on tendermint-rs this past quarter.


$injector cannot instantiate ES6 classes

This code (paraphrasing) fails with TypeError: Class constructors cannot be invoked without 'new':
class Foo { constructor() { } }
var foo = $injector.instantiate(Foo);

The reason is that ES6 disallows using fn.apply on class constructors.

+1

@mprobst I've encountered the similar issue before and ended by splitting the solution into separate extension, ng-classified.
Just have checked #12598, I have a feeling that patching up instantiate is halfhearted job, it will just affect performance by propagating new everywhere and not targeting the classes. And other things that could benefit from classes will still get their TypeErrors (the world is bigger than controllers).
It is evident that I've managed it more drastically, it is $injector.invoke which is primarily responsible for calling class constructors directly. And I consider it the right idea because it is a great opportunity to pull up mature 1.x to fit contemporary expectations (particularly excited by Angular 2) by using DI-enabled classes everywhere where 1.x would expect constructor functions, without breaking anything.
It's not that simple, what's good for extension, is bad for framework. Due to the fact that only Chrome/V8 native class implementation can be easily detected (even FF native classes appear as functions for now), I've had to introduce some conventions and add flag checks to avoid trying-catching TypeErrors on every invoke.
Is it acceptable to make $injector configurable on framework level? I'm not sure at all. But I think it is inevitable to provide some degree of configurability to deal with classes in future-proof manner while keeping the performance high for classless apps.


Spacing Issue between videos and image's section fixed

Give a ss of your work

Here is the screenshot


Added option to provide version in nuget updating

The PR adds option to provide package version during nuget updating. This is same as doing
Update-Package FooBar -Version <IP_ADDRESS>

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: nikhilagrawaldotnet sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


News

I'm thinking we should cut this feature. We don't have the UI to create news / interact with it, and our time would be better spent on the paper / poster at this point.


RPC refactoring

Part of https://github.com/nanocurrency/raiblocks/issues/1112
This is just moving things around, should be low risk.
There's a separate rpc lib with handler source files for the major RPC action categories.

#1038 is in the same category

Does it fix https://github.com/nanocurrency/raiblocks/issues/896?

@rotilho This PR doesn't fix any bugs, it's just a refactoring to split the source into smaller files and a separate cmake subdir.

Anything touching RPC will break this PR, so I'll await rebasing until we decide if this is something we wanna merge.

I wanna redo this with a few manageable PRs, e.g. do the rpc-as-a-lib-project first, the handler split-up next etc.


does this integreation use a github account?

I do not believe this is the case, but, has this always been the case?
we likely have a left over account on my end from some internal testing, but, id like to validate its not in use by this integration

@mccannical so sorry, this question slipped through the cracks.
TLDR; We only use your personal account to install the app on an organization.  After that everything is done through the Github App API.
When you install a github app, you need to use your account to do so.  You can only install the app on organizations you have admin access to.  You need to accept the permissions that the app is requesting.
Once that is done, there's a transaction that happens between github and our app where we keep an installation id which is unique to each organization we are installed on.  The app itself is already registered on github and secured through a unique private key only available to our app.  From this point forward, everything the app does is based on this installation id and the private key to be able to call Github APIs on your organization's behalf.  Think of it like the app being it's own separate user which you've allowed X access to your organizational repos and we use that identity for all interactions.
I hope that answers your question.

Hey @mccannical. As it's been several weeks with no activity on this issue, I'm going to go ahead and close it. Please feel free to reopen and ask more questions if you need further clarification.


firetruck gets stuck at intersections in Town01 when using autopilot

Related to Issue #3860
CARLA version: 0.9.12
Platform/OS: Ubuntu 18.04
Problem you have experienced: certain vehicle models (e.g. vehicle.carlamotors.firetruck) are too big for some intersections and will get stuck even with autopilot / traffic manager enabled
What you expected to happen: vehicle.carlamotors.firetruck is able to complete turns at all bundled map intersections with autopilot (traffic-manager) enabled.
Steps to reproduce:  run carla_debug.txt, watch for the firetruck to get stuck at an intersection in Town01, per the attached photo .

Unfortunately, due to the guardrail placed there, and the route provided from the OpenDrive file, Firetrucks are not able to perform that turn in Town01. It's a known issue, but the map is fairly old and the model is new.


not work well in single task launch Mode

due to inject invoke time,when an activity is start in single task / instance mode,
new params not in use on "onNewIntent(intent: Intent?)" lifecycle
wait for fix

I‘ll check that later.

Try with the version 2.0-beta3:
@Override
public void onNewIntent(Intent intent) {
    super.onNewIntent(intent);
    MyActivityBuilder.processNewIntent(this, intent);
}

or in Kotlin:
override fun onNewIntent(intent: Intent?) {
    super.onNewIntent(intent)
    processNewIntent(intent)
}


Add Tournament Help in /roomhelp

This is way too detailed.

You especially don't need all the aliases for the commands.

Just tour create, tour start, tour end. You link to the full docs anyway.


Update refined to 0.8.4

All Scala.js builds failed with errors like this:
org.scalajs.core.ir.IRVersionNotSupportedException: Failed to deserialize info of file compiled with Scala.js 0.6.17 (supported: 0.6.0, 0.6.13, 0.6.3, 0.6.4, 0.6.6, 0.6.14, 0.6.8, 0.6.5, 0.6.15): /home/travis/.ivy2/cache/eu.timepit/refined_sjs0.6_2.12/jars/refined_sjs0.6_2.12-0.8.4.jar:eu/timepit/refined/macros/RefineMacro$$typecreator5$1.sjsir

Probably because refined is on Scala.js 0.6.20 while Monocle is on 0.6.16.

Could you try to upgrade scala-js in monocle at the same time?

Done. I also needed to update sbt to 0.13.16 to fix a java.lang.NoSuchMethodError: sbt.package$.Zero()Lsbt/Global$; on startup.  Let's see what Travis says about this now.

Awesome, thanks Thomas


Anime4K GAN shaders cause video to freeze

Describe the bug
I added the following line to my mpv input.conf
CTRL+8 no-osd change-list glsl-shaders set "~~/shaders/Anime4K_Restore_GAN_UUL.glsl:~~/shaders/Anime4K_Upscale_GAN_x4_UUL.glsl:~~/shaders/Anime4K_Restore_CNN_Soft_M.glsl:~~/shaders/Anime4K_Upscale_CNN_x2_M.glsl"; show-text "Anime4K: Mode GAN (HQ)"
Upon pressing CTRL+8, the video freezes while audio continues as normal. I am not even able to control mpv as normal and instead have to kill the process on the terminal.
To Reproduce
Steps to reproduce the behavior:

Add the above line to your mpv config.
Play a low res anime show
Activate the shader
See error

Expected behavior
I expected the video to be upscaled to some degree.
Screenshots
Unable to take screenshots as the display just completely freezes.
Desktop (please complete the following information):

OS: openSUSE Tumbleweed
Version: Latest snapshot
GPU/Version: Asus RX 6900XT with the current GPU drivers
Media Player and Version: mpv v0.34

Additional context
This was done using the latest pull of the master branch of Anime4k.
An semi-blindly edited config based on mode A with the CNN stages replaced with GAN seems to work, although the results are not as nice as I'd want.
CTRL+7 no-osd change-list glsl-shaders set "~~/shaders/Anime4K_Clamp_Highlights.glsl:~~/shaders/Anime4K_Restore_GAN_UL.glsl:~~/shaders/Anime4K_Upscale_GAN_x2_M.glsl:~~/shaders/Anime4K_AutoDownscalePre_x2.glsl:~~/shaders/Anime4K_AutoDownscalePre_x4.glsl:~~/shaders/Anime4K_Upscale_GAN_x2_M.glsl"; show-text "Anime4K: Mode GAN"

I have the same situation on my pc (gentoo linux, 6800xt)
When switching to GAN, the playback stops. mpv does not display any valid information. At this time, I can terminate mpv playback by pressing ctrl+c twice in the terminal.

您的邮件已收到！谢谢！

This sounds like a shader compilation problem... Is the CPU being used when the display freezes? And how long does the display freeze for? Shader compilation should complete at worst within ~2 minutes even with a slow, but modern CPU.
Is there intermittent unfreezes or is it completely frozen solid for a long time?

I re-tested once and after switching to GAN and waiting more than 5 minutes MPV showed: "[vo/gpu/opengl] shader link log (status=0): error: insufficient contiguous locations available for vertex shader input `vertex_texcoord15' "
During this period, the cpu usage of mpv has been at 100%(my pc cpu is 5950x)

Maybe the latest generation of GPUs' drivers have some issues with mpv, have you tried using the Vulkan renderer --gpu-api=vulkan instead of OpenGL, or tried the new experimental backend --vo=gpu-next?

after trying --gpu-api=vulkan it can be played normally, but the --vo=gpu-next option is not found. The version of mpv is 0.34.1

after trying --gpu-api=vulkan it can be played normally, but the --vo=gpu-next option is not found. The version of mpv is 0.34.1

Great, that's fine as gpu-next is currently in development and only available for testing in the latest nightly builds of mpv.

Thanks for the help, --gpu-api=vulkan definitely works!


Update MD file on new branch 2017-16-18_05-11-47

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Expose hosting context (env and configuration) on UseKestrel config

cc @davidfowl

cc @danroth27

Isn't this a dupe of #1334?

Dup of #1334


Proposal: Changing the way these overlays work to integrate nix into them

Sorry for always talking about nix, but it really could be quite useful for this project. Like, I am working on an architecture for this project on my personal fork that uses the nix store for these system extensions.
Basically, the idea is to use nix packages instead of manually fetching static binaries for every program these extensions aim to use, but you can't just copy stuff from the /nix/store off to anywhere you want, so the idea was to:

Make a symlink farm FHS-compatible root with all the /nix/store symlinks for the extension
Make readonly bind-mount or overlayfs onto /nix with the contents of an entire nix store so that all the .sos work on the symlinks
Do that for all extensions

That would be just like the nix bundles, but unbundled, without nix itself being necessarily installed on the host system, removing all the slow unpacking time for every package!
The final layout would look pretty much like this:

User declares the configuration on a config.json file (stuff like sysext-name, OS, arch, and packages)
Dockerfile with nix generates tar file with /nix/store with all the depencies for the target package
Dockerfile also makes a symlink tree with symlinks to that /nix/store (/usr/bin/hello -> /nix/store/HASH-name-VERSION/bin/hello)
Utility script or program unpacks tar file with the nix store, dumps it into /var/cache/sysext-layers/${layer-name}
Utility generates a systemd-sysext compatible squashfs file from the symlink tree
Utility overlays (or bind-mounts) /var/cache/sysext-layers/${layer-name}/nix on top of /nix
Utility activates systemd-sysext and systemd-confext and overlays your target nix-based extension
User is happy!

Overlaying stuff on /nix/store should work since all of the packages/libraries inside of it are completely self-contained and thus, completely bind-mount compatible, just like Docker does with their nix-based docker images (but instead of being a docker image its your entire system).
This is my personal fork, you can check out progress for this proposal in it!

Same thing in the PR!


Music player timestamp is not uniform

https://www.youtube.com/watch?v=cWtgGTCAjYY
The music duration is 4 minutes long, but the music ends before 4 mins mark is reached. Notice the time stamp updating speed is not regular.

Fixed in v2.5.1 by changing to a different music-downloader platform.


Added method to retrieve a direction vector from one point to another

I found its kinda a useful math operation. Direction from vector a to vector b is : (b - a).normalized  so the proposal is to modify it to a.direction_to(b) - I think it looks more ellegant and understandable(for newbies especially) than writing it in current form.  I've added it to both Vector2 and Vector3.

This looks ok, guess it will also need to be added to C# and GDnative :P

Added to C#, GDNative and fixed "directed" to "pointed" :)

@akien-mga I think it's ok for merging now - I've added it correctly + added to Mono. GDNative is up to @karroffel

Thanks!

Cherry-picked for 3.1.1.


Documentation for gelocation plugin should be updated to meet new apple rules about location access

Feature Request
Motivation Behind Feature

Apple identified some issues without specified NSLocationAlwaysUsageDescription in info,plist, so the documentation for geolocation plugin is missed some informations, please update the documentation and add these rules to it:
edit-config target="NSLocationAlwaysAndWhenInUseUsageDescription" file="-Info.plist" mode="merge">
string>Need location access to find things nearby. /string>
/edit-config>
edit-config target="NSLocationWhenInUseUsageDescription" file="-Info.plist" mode="merge">
string>Need location access to find things nearby. /string>
/edit-config>
edit-config target="NSLocationAlwaysUsageDescription" file="*-Info.plist" mode="merge">
string>Need location access to find things nearby./string>
/edit-config>
(*** please note that i removed the start of codes because github not allowed these, so please add < in the first of each code)
Apple will send an email about issues found if you don't add the previous rules to info.plist.
Message from apple:
Missing Purpose String in Info.plist File - Your app's code references one or more APIs that access sensitive user data. The app's Info.plist file should contain a NSLocationAlwaysUsageDescription key with a user-facing purpose string explaining clearly and completely why your app needs the data. Starting Spring 2019, all apps submitted to the App Store that access user data will be required to include a purpose string. If you're using external libraries or SDKs, they may reference APIs that require a purpose string. While your app might not use these APIs, a purpose string is still required. You can contact the developer of the library or SDK and request they release a version of their code that doesn't contain the APIs. Learn more (https://developer.apple.com/documentation/uikit/core_app/protecting_the_user_s_privacy).
Feature Description

Please add these rules to the documentation:
/edit-config target="NSLocationAlwaysAndWhenInUseUsageDescription" file="-Info.plist" mode="merge">
string>Need location access to find things nearby. /string>
/edit-config>
edit-config target="NSLocationWhenInUseUsageDescription" file="-Info.plist" mode="merge">
string>Need location access to find things nearby. /string>
/edit-config>
edit-config target="NSLocationAlwaysUsageDescription" file="*-Info.plist" mode="merge">
string>Need location access to find things nearby./string>
/edit-config>
(*** please note that i removed the start of codes because github not allowed these, so please add < in the first of each code)
Alternatives or Workarounds

Please see https://guides.github.com/features/mastering-markdown/#GitHub-flavored-markdown on how to format code in markdown


[Feature]: Moving the widgets off the entity explorer

Is there an existing issue for this?

[X] I have searched the existing issues

Summary
Currently adding a widget isn't the easiest task. Widgets are hidden behind a button on the entity explorer. It also is the only item in the entity explorer which doesn't open a submenu, so it does not maintain consistency.
This could be moved off the entity explorer so that users can access this more easily, and quicker
Why should this be worked on?
Adding and removing a widget is one of the fundamental steps of building an appsmith app, and it should always be accessible, and not hidden behind a click/wall as it is now in the entity explorer, it should be somewhere hyper accessible to all users at all times while on the canvas
It also is the only item in the entity explorer which doesn't open a submenu, so it does not maintain consistency

@arunvjn please feel free to elaborate on this

Being addressed here
https://github.com/appsmithorg/appsmith/issues/17511


Add non-function requirements to DG

Add the following to the DG, based on your project notes from the previous weeks.
Some examples of these can be found in the AB3 Developer Guide.

[x] Non-functional requirements: Note: Many of the given project constraints can be considered NFRs. You can add more. e.g. performance requirements, usability requirements, scalability requirements, etc.

Closed by #25


Chromecast

I have 2 devices chromecast and google home speaker. I had add them to default devices for video and audio playback for my program device. But It cant play video or music with request "play some music on tv" or  "play some music on speaker"...... All time I get same answer -  I cant help with that.

And some time I get this "abort"
assistant_sdk wrote first request: config { audio_in_config { encoding: LINEAR16 sample_rate_hertz: 16000 } audio_out_config { encoding: LINEAR16 sample_rate_hertz: 16000 } dialog_state_in { language_code: "en-US" } device_config { device_id: "default" device_model_id: "default" } screen_out_config { } }
assistant_sdk waiting for response ...
AudioInputALSA snd_pcm_readi returned -32
terminate called without an active exception
Aborted
smartpi@orangepi2:~/assistant-sdk-cpp$

Assistant SDK devices do not work well with casting.


change from string literal to nameof operator.

fix use nameof operator instead of string literal on initializing binding property.
related issue #200.

Thanks for your great work!


global name 'cuda_toolkit_path_full' is not defined

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):  Ubuntu 18.04.1 LTS  64 bit
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: N/A
TensorFlow installed from (source or binary):   Source
TensorFlow Version:  r.1.11
Python version:  3.6
Bazel version (if compiling from source):  0.15.2 (tried/same problem with 0.15.2, 1.16.1, 0.18.0)
GCC/Compiler version (if compiling from source):  7.3.0
CUDA/cuDNN version:  10.0 / 7.7.3
GPU model and memory: RTX 2080 TI 11GB
Exact command to reproduce:  ./configure with answers below

Describe the problem
configure fails with following error:
anatolii@workstation:~/tensorflow$ ./configure
WARNING: --batch mode is deprecated. Please instead explicitly shut down your Bazel server using the command "bazel shutdown".
You have bazel 0.15.2 installed.
Please specify the location of python. [Default is /usr/bin/python]: /usr/bin/python3
Found possible Python library paths:
/usr/lib/python3/dist-packages
/usr/local/lib/python3.6/dist-packages
Please input the desired Python library path to use.  Default is [/usr/lib/python3/dist-packages]
Do you wish to build TensorFlow with jemalloc as malloc support? [Y/n]:
jemalloc as malloc support will be enabled for TensorFlow.
Do you wish to build TensorFlow with Google Cloud Platform support? [Y/n]:
Google Cloud Platform support will be enabled for TensorFlow.
Do you wish to build TensorFlow with Hadoop File System support? [Y/n]:
Hadoop File System support will be enabled for TensorFlow.
Do you wish to build TensorFlow with Amazon AWS Platform support? [Y/n]:
Amazon AWS Platform support will be enabled for TensorFlow.
Do you wish to build TensorFlow with Apache Kafka Platform support? [Y/n]:
Apache Kafka Platform support will be enabled for TensorFlow.
Do you wish to build TensorFlow with XLA JIT support? [y/N]:
No XLA JIT support will be enabled for TensorFlow.
Do you wish to build TensorFlow with GDR support? [y/N]:
No GDR support will be enabled for TensorFlow.
Do you wish to build TensorFlow with VERBS support? [y/N]:
No VERBS support will be enabled for TensorFlow.
Do you wish to build TensorFlow with nGraph support? [y/N]:
No nGraph support will be enabled for TensorFlow.
Do you wish to build TensorFlow with OpenCL SYCL support? [y/N]:
No OpenCL SYCL support will be enabled for TensorFlow.
Do you wish to build TensorFlow with CUDA support? [y/N]: y
CUDA support will be enabled for TensorFlow.
Please specify the CUDA SDK version you want to use. [Leave empty to default to CUDA 9.0]: CUDA 10.0
Please specify the location where CUDA CUDA 10.0 toolkit is installed. Refer to README.md for more details. [Default is /usr/local/cuda]:
Traceback (most recent call last):
File "./configure.py", line 1592, in
main()
File "./configure.py", line 1527, in main
set_tf_cuda_version(environ_cp)
File "./configure.py", line 855, in set_tf_cuda_version
(tf_cuda_version, cuda_toolkit_path_full))
NameError: global name 'cuda_toolkit_path_full' is not defined

TensorFlow officially supports CUDA 9.0. However it is compatible with CUDA 10.0 but not supported currently. For using TF with cuda 10, you have to build it from sources yourself. You need to update the "./configure.py" file with appropriate CUDA, cuDNN versions. You can also take a look at installations done by another users to make it work.

@ymodak  - sorry I don't see any notes on modifying configure.py at the installations link you mentioned, perhaps you meant that CUDA version is to be typed when running configure ? - because that I did, as shown in the issue description above. Please clarify. thanks!

Yes, I see now that you have already mentioned CUDA version 10. Did you add CUDA path variable in the bashrc file? The link in previous comments mentions the changes you need to adopt to build successfully for CUDA 10. I recommend that you follow the tutorial and build again, since I may be missing some points.

yep, I had modified PATH and LD_LIBRARY_PATH in ~/.profile to reflect /usr/local/cuda-10.0/bin and lib64 respectively.

@toli-belo
I think you need to specify "10.0" instead of "CUDA 10.0" when it asks you for cuda version

Is this still an issue? Did you get a chance to follow the tutorial I sent in previous comment?

I met the same error.
I looked into configure.py and found the code below
cuda_toolkit_paths_full = [os.path.join(cuda_toolkit_path, x) for x in cuda_rt_lib_paths]
......(4 lines here)
print('Invalid path to CUDA %s toolkit. %s cannot be found' %
      (tf_cuda_version, cuda_toolkit_path_full))

The print is where the error happened, so I think it's just a misspelling…
The script wants to tell you that your path to CUDA is invalid, so maybe check again the location you tell the script where CUDA is installed.

thanks everyone! I was able to build tensorflow with cuda 10


Contact Page

Description
Create the Contact Page
Tasks

[ ] Design the contact us page

[ ] Ensure responsiveness for different screen sizes.

[ ] Ensure proper styling and theming.
[ ] Test the design on various devices.

Acceptance Criteria

Thecontact us page should be user-friendly and visually appealing.
The layout should be responsive and work on different screen sizes.

@emmanuelAkpe I'm taking up the task


Added Templates for PRs and Issues

Made the requested changes. Please check.
Issue fix: #15

Thanks for your contribution!


[Batch] Batch API update

These tests should pass once #1311 has been merged :)

Codecov Report

Merging #1318 into master will increase coverage by 0.08%.
The diff coverage is 90.83%.

@@            Coverage Diff             @@
##           master    #1318      +/-   ##
==========================================
+ Coverage   55.96%   56.04%   +0.08%
==========================================
  Files        2682     2691       +9
  Lines       71088    71246     +158
==========================================
+ Hits        39782    39932     +150
- Misses      31306    31314       +8

Impacted Files
Coverage Δ

azure-batch/azure/batch/models/job_manager_task.py
27.77% <ø> (ø)
:arrow_up:

...ure-batch/azure/batch/models/pool_add_parameter.py
100% <ø> (ø)
:arrow_up:

...ure-batch/azure/batch/models/pool_specification.py
20% <ø> (ø)
:arrow_up:

azure-batch/azure/batch/models/output_file.py
100% <ø> (ø)
:arrow_up:

azure-batch/azure/batch/models/__init__.py
100% <100%> (ø)
:arrow_up:

azure-batch/azure/batch/models/inbound_endpoint.py
100% <100%> (ø)

...atch/models/compute_node_endpoint_configuration.py
100% <100%> (ø)

azure-batch/azure/batch/models/compute_node.py
100% <100%> (ø)
:arrow_up:

.../azure/batch/models/network_security_group_rule.py
100% <100%> (ø)

azure-batch/azure/batch/models/inbound_nat_pool.py
100% <100%> (ø)

... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 535da36...f24dee4. Read the comment docs.


Use usage template in subcommand help

What type of PR is this?

bug

What this PR does / why we need it:
Use existing usage template in subcommand help to remove (confusing) difference between templates.
Which issue(s) this PR fixes:
Closes #1879

@meatballhat Do we need to display different formats depending on whether there are subcommands?
For example, fix the templ variable in ShowSubcommandHelp function like this:
templ := SubcommandHelpTemplate
if cCtx.Command != nil {
  if cCtx.Command.CustomHelpTemplate != "" {
    templ = cCtx.Command.CustomHelpTemplate
  } else if len(cCtx.Command.VisibleCommands()) == 0 {
    templ = CommandHelpTemplate
  }
}

@vimiix good point! I'd like to see if that logic can be part of "usageTemplate" 👀


Add Higher Quality Device Image

Figured you like a better image for the plugin that doesn't have a white background.

You'll want to edit the js and remove the comment to load the png from your repo.

You'll want to edit the js and remove the comment to load the png from your repo, and of course delete the other line.

ya I had notice it, I still wanna add more things, I'm change it when I push new commit.


Changed Item_Base CollisionMask to 0

Fixes issue space-wizards/space-station-14#696

Does this still work now that the collision mask PR was changed to only be a test?
And also, wouldn't this make it so that items can go through walls?

Yes and yes but items can only move when thrown and the throw code modifies their collision mask.

Ah, alright.


google calendar app on Chrome doesn't work

System Information:

Version: 2.1
Language: en-US
Timezone Offset: +08:00
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/32.0.1653.0 Safari/537.36

What steps will reproduce the problem?

click "authorize google calendar" button with no response

What is the expected result?
to be resolved
What happens instead?
I need to restore the lower version of  google calendar on my Chrome's toolbar
Screenshot URL:
Logs:
[2015-03-11T08:19:08.135Z] browseraction.initialize()
[2015-03-11T08:19:08.162Z] browseraction.loadCalendarsIntoQuickAdd_()
[2015-03-11T08:19:08.204Z] browseraction.showEventsFromFeed_()
[2015-03-11T08:19:08.955Z] getAuthToken "OAuth2 not granted or revoked."
[2015-03-11T08:19:08.966Z] getAuthToken "OAuth2 not granted or revoked."
[2015-03-11T10:10:17.263Z] options.loadCalendarList()
[2015-03-11T10:10:21.577Z] Creating bug report.

Have you tried all steps under Troubleshooting ?

Yes. I've tried many times. No response.


[PartEditor] Event handler for dispose

This will add event handler for PartEditor to dispose request of itself.
ONE-vscode-DCO-1.0-Signed-off-by: SaeHie Park<EMAIL_ADDRESS>

for #822 from draft #851


Using function for icon in weather widget

https://github.com/resoai/TileBoard/commit/68e3ee00982dff88193b6a4b8a4c0785e10702a1 added the ability to use a function for icons: for widgets, but this doesn't seem to work for the weather widget since it uses a different method of specifying and showing an icon.
Backstory: https://community.home-assistant.io/t/new-dashboard-for-ha/57173/122?u=cgarwood
Weather widget uses this instead of the icons: directive.
fields: {
  icon: 'clear-day',
  iconMap: {
    'clear-day': 'clear'
  },
}

Please check this out https://github.com/resoai/TileBoard/commit/3121ed341a2b972810e69ec69bc23fb6eb00c98e

That works perfect. Thanks!


Position/Alignment of movable box

When I setup this to work with a list of image thumbnails on my page, the movable blue box is below the images.  Attached is a screenshot of what it looks like.

@contd  I have the same issue, did you find the reason?

Parent element should has position: relative;

@contd could you check workaround provided by @stefanaz ?
It would be nice if you can make a Minimal Reproduction of the bug on codesandbox/jsfiddle/codepen or whatever you like

have you find solution on this issues? @contd  @probil

@probil i have also encountered this issue. Attached below is the screenshots

@lynmije  try to play with margin-top of your container and position:relative/absolute;

Hi,
I have the same problem, I use Vue Material and I think that is the source of this issue.
Do I have to add position: relative on each parents ?
Thanks

@ibadass It depends on how you've implemented that. 🤔
If you have Moveable in few unrelated places - yeah, you should have position: relative on each exiting parent wrapper.
If you have few related Moveable instances in one place (see screenshot of contd about) you can have just one parent with position: relative
I don't think CSS framework is an issue - you can always add one more wrapper with position: relative 😉
I mean

   <Movable />

can be

     <Movable />

@probil Thank you for your answer, I understand.
Here is a codesandbox in order to understand my problem and maybe find a solution...

@ibadass You need to pass container ref as a prop to <Moveable>:

            <Moveable
              class="moveable"
              v-model="row.key"
              v-bind="moveable"
              :container="$refs.container"
              @drag="handleDrag"
              @resize="handleResize"
              @scale="handleScale"
              @rotate="handleRotate"
              @warp="handleWarp"
              v-for="(row, index) in rows"
              :key="index"
            >
              Vue Moveable
            </Moveable>

https://codesandbox.io/s/vue-material-also-works-on-the-right-side-j5psx

I think this should help other guys (like @contd ) as well

@probil Thanks, it works great !
Just a thing, in my example, : when I create 2 shapes and manipulate one of them, it move "automatically" on the other.

@ibadass I saw that. It's because you are using one $frame object.
In the latest version of the library you can get rid of $frame completely. Check examples in repo

@probil Thank you ! It's perfect !

I had the same issue and added position:relative like suggested above. Not using vue material though. Just trying to get the bounding controls to show up around my images on load.
Currently the bounding controls only surround the image like I want, once I click on the image.
Could be because I'm looping through and using slots to have many images loaded with moveable component.

Is the issue still relevant? :thinking:

same as #86 issue

@stefanaz thanks for linking the issues! The container prop worked for me 🙌

@andreasvirkus sure


Setting name "githubIssues.workingIssueBranch"

re #1939
Maybe find a better name for workingIssueBranch. How about issueBranchTitle (similar to window.title) or issueBranchNameTemplate

I like issueBranchTitle, but this setting is already in stable. Will need to migrate.

@alexr00 I don't know if the blog posts needs to be up to date (But I think they're kind of vscode documentation?) but it still mentions the old setting name githubIssues.workingIssueBranch
https://code.visualstudio.com/blogs/2020/05/06/github-issues-integration#_working-on-issues

Thanks @Ahmeed2m, I just pushed an update to our docs repo!

hey guys, I just read the vscode docs here and I still find the old setting name workingIssueBranch. I have to google to find this PR. Not sure where to open issue for that?

Thanks @robertwt7, I've just pushed a change to replace the old setting name in the docs. Next time the website is updated the change will be picked up.


enable_node_public_ip doesn't have any effect in AmlCompute.provisioning_configuration due to old api version

Package Name: azureml-core
Package Version: 1.40.0.post2
Operating System:Ubuntu 18.04.4 LTS
Python Version: 3.7

Describe the bug
When trying to create a compute cluster in a secured Azure ML workspace (dedicated subnet), without assigning public IP to the cluster nodes
the cluster is always created with public IP option enabled.
To Reproduce
Steps to reproduce the behavior:

Assuming there is Azure ML workspace secured <vnet_resourcegroup_name,vnet_name,subnet_name>, try to create a AmlCompute as a compute target with enable_node_public_ip=False using following code:

from azureml.core.compute import AmlCompute
from azureml.core import Workspace, Dataset, Datastore, ComputeTarget  # noqa
from azureml.core.runconfig import RunConfiguration  # noqa

def main():
    workspace_name = "your workspace"
    subscription_id = "your subscription"
    resource_group = "your rg"
    vnet_resourcegroup_name = "your vnet rg"
    vnet_name = "your vnet"
    subnet_name = "your subnet"
    compute_name = "test01"

    workspace = Workspace.get(
        name=workspace_name,
        subscription_id=subscription_id,
        resource_group=resource_group,
    )

    compute_config = AmlCompute.provisioning_configuration(
        vm_size="STANDARD_DS2_V2",
        vm_priority="lowpriority",
        min_nodes=1,
        max_nodes=4,
        idle_seconds_before_scaledown="300",
        identity_type="SystemAssigned",
        enable_node_public_ip=False,
        vnet_resourcegroup_name=vnet_resourcegroup_name,
        vnet_name=vnet_name,
        subnet_name=subnet_name,
        remote_login_port_public_access='Disabled'
    )

    compute_target = ComputeTarget.create(
        workspace, compute_name, compute_config
    )
    compute_target.wait_for_completion(
        show_output=True, min_node_count=None, timeout_in_minutes=10
    )

if __name__ == "__main__":
    main()

Check in Azure Portal that the cluster has been created but doesn't have "No public IP" in Resource properties.

Expected behavior
Compute cluster should have been created with "No public IP" == true in Resource properties.
Screenshots
If applicable, add screenshots to help explain your problem.
when using python3.7/site-packages/azureml/_compute/_constants.py:MLC_WORKSPACE_API_VERSION = '2020-02-02'

when using python3.7/site-packages/azureml/_compute/_constants.py:MLC_WORKSPACE_API_VERSION = '2022-01-01-preview'

Additional context
I found a solution to fix this issue.
This is casued by the fact that azureml-core is using the old Azure ML REST API version:
python3.7/site-packages/azureml/_compute/_constants.py:MLC_WORKSPACE_API_VERSION = '2020-02-02'
When I manually changed it to the latest one:
python3.7/site-packages/azureml/_compute/_constants.py:MLC_WORKSPACE_API_VERSION = '2022-01-01-preview'
the same code worked without issues and the compute cluster has been created with the option "No public IP"

@pawel-f  Thanks for the issue. We will take a look asap.
@msyyc Can you take a look?

Hi @luigiw , please help on the issue

@azureml-github

v1 SDK is in maintenance only mode in favor of the v2 SDK being GA. Please file an issue for v2 SDK if your requests stand for v2.
https://learn.microsoft.com/en-us/azure/machine-learning/how-to-migrate-from-v1


Header format

Hello,
I needed to add double brackets in the date row in the first example in 14.4 for the file to knit, as in:
date   : "r format(Sys.time(), '%d/%m/%Y')"
Also, there seems to be a typo in 14.9: "looks" instead of "lookis"?
With best regards

Thanks for noticing this, I corrected it.


Remove Aggregate part cache

This PR removes the LoadingCache of AggregateParts in the AggregateRoot.

@armiol, PTAL.

The changes regarding the way parts discover each other have been accidentally merged together with #1062. This PR now only contains the LoadingCache usage removal and some minor clean up.
@armiol, PTAL.


Update k8s_cluster.yaml

fixed typo reported by user: supprot -> support

I approve, but I'm not an admin....

Thanks for making this change. However, it will get overwritten when we regenerate this yaml. The upstream fix would be here: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/1de40deebf2aa4993f46d2b98131e9be1817fa07/receiver/k8sclusterreceiver/config.go#L40
This is my bad as I need to add docs to this repo to make this clear. It's now on my todo list!
If anyone wants to open a PR for the above that would be swell, otherwise I'm happy to do it.
cc: @theletterf


Suggestion/Request - Enable audio out for the voice narrations

Hi, I find this RuneLite Plugin extremely useful for doing raids with voice requirements. I have a suggestion that I think would greatly benefit it's users.
When doing raids I am currently using Virtual Audio Cable (VB cable) along with a Microsoft store app called "type to voice chat" to currently call information to my raiding mates via voice.
If this plugin could be potentially updated to allow the voice-converted text messages typed into in-game chat to be sent as microphone input, It would be of great benefit to its users.

I see, ill add it to my TODO list and look into it sometime, i doubt many people would have use for this feature but who knows.
Also you could use some other program to route your runelite output into your microphone but that would also send everything else the game plays so that wouldn't be the best solution tho.


Add support for coma separated ignore (--ignore=123,456)

Fixes #341
This adds support for providing ignore as --ignore=123,456
The previous format --ignore=123 --ignore=456 is still supported for backward compatilibity, I guess you don't want to introduce a breaking change here.
Let me know if there is anything I should fix in the PR.

Any update on this?

Hi, sorry to insist but is there any chance to get it merged?

Hi @bagerard, thanks for this PR! Yes, we have a coming version of Safety, I expect to merge this PR after the new 2.0 release. I'm sorry for don't reply with an update in this PR before.

Alright no problem, thanks for the feedback :+1:

Just fixed this PR, there were lots of conflict with recent changes, let me know if anything else is needed


testhost.x86.exe should be able to handle large addresses.

Description
There could be scenarios where testhost.x86.exe requires more than 2 GB of memory. In those cases, current testhost.x86.exe could fail with StackOverFlowException/OutOfMemoryException as 32-bit programs receive only 2 GB of address space.
We should consider using /LARGEADDRESSAWARE flag in testhost.x86.exe.
When this flag is used while compiling, testhost.x86.exe can use up to 4GB of address space.
We also need to investigate the same has to be applied in DataCollector.exe and vstest.console.exe as well.

cc @codito @smadala @Faizan2304 @singhsarab

Current Status:
Currently dotnet tooling doesn't have support to use /LARGEADDRESSAWARE for cross platRelated Issue
Workaround:
User can run their test for platform x64.
Action:
Moving this bug from milestone 15.5 and will address once the above issue will get fixed.

The required compiler feature is already implemented going back to the first VS2015 release. See my comment in the linked issue.

this appears to have been fixed in VS 2019

Weird. I refiled this as #1985 and then fixed it in #1986.

@sharwell Cool! Thanks.
@fifthgearonline Thanks for confirmation.


DBUser using DBCluster causes the controller to crash

DBUser using DBCluster causes the controller to crash.
apiVersion: v1
data:
    password: ZGVhZGJlYWZkZWFkYmVhZmRlYWRiZWFm
kind: Secret
metadata:
    name: branche-test-rds-master-password
---
apiVersion: rds.services.k8s.aws/v1alpha1
kind: DBCluster
metadata:
    name: branche-test
spec:
    databaseName: database_name
    dbClusterIdentifier: us-east-1-branche-test
    dbSubnetGroupName: branche-test
    engine: aurora-mysql
    masterUserPassword:
        key: password
        name: branche-test-rds-master-password
        namespace: preview
    masterUsername: root
---
apiVersion: rds.services.k8s.aws.adobe.io/v1alpha1
kind: DBUser
metadata:
    name: branche-test-admin
spec:
    dbClusterIdentifier: -branche-test
    grantStatement: GRANT ALL ON `%`.* TO ? REQUIRE SSL
    useIAMAuthentication: true
    username: admin

This was fixed by #4 and #7


Fuzzing

Even though this code was written with care and has a test suite, there's still potential for unexpected issues. Setting up fuzzing would help vet this code more thoroughly.
I don't have any experience in this area, so it might be a good learning exercise too.

I think this is the suggested resource https://rust-fuzz.github.io/book/cargo-fuzz.html


sendSMSMessage sendErrorResponse check

Hi, thank you for the library. Actually it's almost impossible to find nexmo nodejs that works.
Apparently they change something in their API response, so sendSMSMessage is not handling errors correctly anymore.
    sendRequest('POST', _ENDPOINT.sms, data, function(err, apiResponse) {
      if (!err && apiResponse.status && apiResponse.messages && apiResponse.messages[0].status > 0) {
        return sendErrorResponse(callback, new Error(apiResponse.messages[0]['error-text'], apiResponse));
      }

      if (callback) {
        callback(err, apiResponse);
      }
    });

It seems that API is not returning apiResponse.status anymore, so all responses are now evaluated as successful.
Proposed fix:
    sendRequest('POST', _ENDPOINT.sms, data, function(err, apiResponse) {
      if (!err && (apiResponse.status > 0 || (apiResponse.messages && apiResponse.messages[0].status > 0))) {
        return sendErrorResponse(callback, new Error(apiResponse.messages[0]['error-text'], apiResponse));
      }

      if (callback) {
        callback(err, apiResponse);
      }
    });

@mauron85 The api response error check has been fixed now.

Great. Thank you.


Add scaladoc examples for Vec and Bundle

Added some simple example for Vec and Bundle creation.
Comments welcome

Did you miss tagging the second example? In Bundle?

@ducky64 as a matter of fact I did miss second @example, tag fixed now

How does it actually look with the example tags? I think it might move them away so that text in between them may not make sense

You can preview by building the scaladoc?

The @example tag doesn't seem to be doing anything. And the first example in Bundle still doesn't have it

Actually, I was behind, the tag does move the example elsewhere, so maybe the tag isn't right for the style here? Scala List seems to use the tag sometimes but not always depending on what they're trying to do

@jackkoenig That is weird stuff, looking into it


request to add target == '_replace'

Is it possible to add

} else if (target == '_replace') {
   return false;
}

just before or after the

} else if (target == '_webapp') {
  ......
}

to jqtouch as a standard ? Then target='_replace' can be used with the extension from
https://gist.github.com/596912 for replacing an list item (with anchor tag) with new data...
I get 30 list items, and the last one is "Get more items"... clicking that link should replace the entire list item with 30 new items so that the entire list is 60...
Thanks
Bart

I believe if the href is just "#", it will do the behavior you're looking for... Give it a try?


containers: implement garbage collection

https://github.com/ostreedev/ostree-rs-ext/blob/90c455b9f4eaf594a4c34ef91ab585dfc44a20f2/lib/src/container/store.rs#L404

The original issue here is about removing unreferenced blobs.
However, there's another related issue here, which is we should have an API (+CLI) that removes images that are not deployed.
Right now for example rpm-ostree rebase to a new container image will keep the old image around.  (Which is not true of rebasing between ostree refs, right now we prune the old one.  Perhaps, arguably we should just fix that to keep it symmetric.  But this issue would still stand either way)


Resolve plugins in monorepo project

I have the following folder structure
/.vscode
.../setting.json
/linter
.../node_modules <== contains eslint and plugins
.../package.json
/project-a
.../eslintrc.json
/project-b
.../eslintrc.json

setting.json
{
        "eslint.nodePath": "./ci/js/eslint/node_modules"
 }

project-a .eslintrc.json
{
 "extends": [
        "plugin:vue/recommended",
        "../lint/node_modules/eslint-config-standard/.eslintrc.json"
    ],
}

Eslint output

[Info  - 11:46:43 PM] ESLint server is starting
[Info  - 11:46:43 PM] ESLint server running in node v16.13.0
[Info  - 11:46:43 PM] ESLint server is running.
[Info  - 11:46:45 PM] ESLint library loaded from: /home/User/main-project/lint/node_modules/eslint/lib/api.js
[Info  - 11:46:45 PM]  Failed to load plugin 'vue' declared in 'project-a/.eslintrc.json': Cannot find module 'eslint-plugin-vue' Require stack: - /home/User/main-project/project-a/placeholder.js Referenced from: /home/User/main-project/project-a/.eslintrc.json

Eslint works fine from CLI when used with --resolve-plugins-relative-to, but I cannot find a similar functionality to resolve plugin paths in the vscode extensions

@suhith42 have a look to eslint.workingDirectories setting. To find out how to best use the setting try running eslint from a terminal. If you need to cd into a directory to make it work correctly in the terminal then that directory is a good candidate for a working directory for this extension.
I will close the issue. Please ping if it doesn't help.

Thanks for your response @dbaeumer!
I added the eslint containing directory to eslint.workingDirectories,
{
    "eslint.nodePath": "./linter/node_modules",
    "eslint.workingDirectories":[
        {
            "directory":"./linter",
            "changeProcessCWD": true
        }
    ]
}

but still getting the same error.
I reproduced the error in this repo https://github.com/suhith42/eslint-reproduce. It would be great if you could have a look please.

@dbaeumer  package.json and eslintrc files are inside the relevant directories.
package.json with Eslint is present inside linter directory and eslintrc files are in project-a and project-b are inside those directories respectively.

The correct setup for this layout is:
{
    "eslint.nodePath": "./linter",
    "eslint.workingDirectories":[
        "./project-a",
        "./project-b"
    ]
}

However linting in the terminal fails as well (with the same error as it does in VS Code). It results in:
project-a (master ✗) $ ../linter/node_modules/.bin/eslint index.js

Oops! Something went wrong! :(

ESLint: 8.19.0

ESLint couldn't find the plugin "eslint-plugin-import".

(The package "eslint-plugin-import" was not found when loaded as a Node module from the directory "/workspaces/eslint-reproduce/project-a".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

    npm install eslint-plugin-import@latest --save-dev

The plugin "eslint-plugin-import" was referenced from the config file in ".eslintrc » ../linter/node_modules/eslint-config-standard/.eslintrc.json".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

I recommend that you try to get linting working in the terminal. If it does things are mostly OK in the extension then as well.
I will close the issue. Please ping if you still think this is an issue with the extension.

Linting works fine in terminal. You just have to run eslint from linter directory.
cd linter
yarn lint-project-a

Output

I would actually not recommend such a setup since eslint resolves some of its configuration files (e.g. ignore files) relative to the working directory and not the location where the file to be linted is. What You can do is using the following setup:
{
    "eslint.nodePath": "./linter",
    "eslint.workingDirectories":[
        "./project-a",
        "./project-b"
    ],
    "eslint.options": {
        "resolvePluginsRelativeTo": "../linter/node_modules"
    }
}

That at least makes sure you start in the correct working directory. But limits the working directories to be siblings of the linter folder.

That works! Thanks a lot for your time


ArityException. Wrong number of parameters specified in the documentation?

Using the calculator run-server example at the bottom of the Readme gives me a ArityException.
Is this because run-server now only takes 2 parameters? I apologize if my terminology is off. I am new to Clojure.
form_filler.clj
(require '[pdfboxing.form :as form])
(require '[pdfboxing.merge :as pdf])
(require '[clojure.core.async :as async :refer  [<! >! <!! go]])
(require '[clojure-erlastic.core :refer  [run-server log]])
(use '[clojure.core.match :only  (match)])
(log "Starting ....")
(run-server
 (fn [] 0)
 (fn [term state] (match term
                         [:add n] [:noreply (+ state n)]
                         [:rem n] [:noreply (- state n)]
                         :get [:reply state state])) [])

(log "end application, clean if necessary")

Exception
iex(2)> Starting ....
Exception in thread "main" clojure.lang.ArityException: Wrong number of args (3) passed to: core/run-server, compiling:(/Users/st23am/src/elixir/mcc_gen/priv/pdf_filler/form_filler.clj:6:22)
	at clojure.lang.Compiler.load(Compiler.java:7142)
	at clojure.lang.Compiler.loadFile(Compiler.java:7086)
	at clojure.main$load_script.invoke(main.clj:274)
	at clojure.main$script_opt.invoke(main.clj:336)
	at clojure.main$main.doInvoke(main.clj:420)
	at clojure.lang.RestFn.invoke(RestFn.java:408)
	at clojure.lang.Var.invoke(Var.java:379)
	at clojure.lang.AFn.applyToHelper(AFn.java:154)
	at clojure.lang.Var.applyTo(Var.java:700)
	at clojure.main.main(main.java:37)
Caused by: clojure.lang.ArityException: Wrong number of args (3) passed to: core/run-server
	at clojure.lang.AFn.throwArity(AFn.java:429)
	at clojure.lang.AFn.invoke(AFn.java:40)
	at user$eval7803.invoke(form_filler.clj:14)
	at clojure.lang.Compiler.eval(Compiler.java:6703)
	at clojure.lang.Compiler.load(Compiler.java:7130)
	... 9 more

Yes the README is not  right anymore, there are now only 2 parameters (or one with the default init function) because the initial state is the first message sent by the erlang port (before, the third parameter was the initial state).
So when you use run-server you have to keep that in mind when you code the erlang side, the first message is the initial state. That is meant to be used with exos on the elixir side, a very simple wrapper around GenServer taking that into account : https://github.com/awetzel/exos/blob/master/lib/exos.ex#L28-L29

Excellent thank you for getting back to me! Also Exos looks really cool. I'll check it out. :+1:


request create from byte[] range

have signed CLA.

Works for me. Just one nitpick.

done.

Awesome. (Sorry for sitting on this!)
CLA looks good. My last request: do you mind squashing this into a single commit? See http://rebaseandsqua.sh for instructions.

done

Thanks!


[$500] IOU-Entering impossible distance as add stop, user able to make distance request.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.3-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
Action Performed:

Go to https://staging.new.expensify.com/

Go to Workspace chat

Tap plus icon---Request money

Tap distance

Enter start and finish waypoints

Tap next

Tap distance

Tap add stop

Enter an impossible distance which exceeds maximum distance limitation

Tap back button

Tap Request TBD

Tap distance request created to open distance request detail page

Tap distance

Expected Result:
Entering impossible distance as add stop, user must not be allowed to make distance request.
Actual Result:
Entering impossible distance as add stop, user able to make distance request.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/d10005e6-6504-4a6a-9fbb-4917b4fe9789

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01aafcbed52de2a27b
Upwork Job ID:<PHONE_NUMBER>766031360
Last Price Increase: 2023-11-24

Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
We are not discarding the recent transaction changes when navigating back if the route has errors.
What changes do you think we should make in order to solve the problem?
We should discard the modified transaction changes when navigating back if the route has errors:
https://github.com/Expensify/App/blob/d521dd6783c382297e06a429701ae1936f808041/src/components/DistanceRequest/index.js#L136-L138
What alternative solutions did you explore? (Optional)

@neil-marcellini, I'm a little hazy on the expected results here. If the stop is invalid shouldn't we be discarding it?

Same question for @neil-marcellini as of Friday, Melv. :)

Thanks for the tag in Slack @paultsimura. That or DM is best for me.

@neil-marcellini, I'm a little hazy on the expected results here. If the stop is invalid shouldn't we be discarding it?

@trjExpensify I wouldn't say the stop is invalid, it's more that the set of waypoints is invalid. It's a different situation than an invalid address because the stop could be used if the route didn't exceed the max length.
I like @paultsimura's proposal. However I would also like to add that we should prevent the Next button from doing anything when there are errors. So the end result is that if the user hits the back button their changes are discarded, and alternatively then can't move forward with their edits unless they fix the errors by modifying the waypoints.
I also like this additional improvement.

show an error message if there are less than 2 validated waypoints when editing the request without needing to submit:

Thanks @neil-marcellini.

We should prevent the Next button from doing anything when there are errors

I feel like this is already implemented, we only have issues when coming back:
https://github.com/Expensify/App/assets/12595293/6a49deea-3871-4092-ab8b-39d1ba3d0a67

Proposal
Updated proposal https://github.com/Expensify/App/issues/31816#issuecomment-1825534206

But because current codebase, it too sticks with the original transaction. I.e Transaction.updateWaypoints, Transaction.createInitialWaypoints, Transaction.getRoute... => It's a pain if we replace original transaction with TRANSACTION_DRAFT

I would suggest changing all the distance-related operations to update the draft transaction in both cases: when creating the new request and when modifying it.
And only persist the draft transaction when:
Clicking "next" on the DistanceRequest page (when both creating the request on the initial page, and modifying it on the confirmation step):

Clicking "Save" when modifying the already existing distance request (in the transaction thread):

This way, it may require a bit more code changes, but the result will be more fail-proof. And because it will be changed in all scenarios, we won't need to split the logic into "edit" and "add", therefore won't need to update TRANSACTION_DRAFT in some cases, and in other – TRANSACTION

👋 checklist time!

Thanks! So we have this regression test, should we add to it?

Global Create > Request Money
Select Distance option
Enter a start location in San Diego, California and a finish location in Honolulu, Hawaii
Verify an error message displays below the map saying there is no route and instructing you to edit the waypoints
5. Change the finish location to San Francisco, California
6. Verify the map recalculates and the error message clears
7. Select Next to move to the confirmation screen
8. Select Distance to edit the waypoints
**9. Select add a stop > enter in Honolulu, Hawaii **
10. Verify an error message displays below the map saying there is no route and instructing you to edit the waypoints
11. Select the Honolulu waypoint > clear the field > Save
12. Verify the stop is removed and the distance is reverted to the previous valid two waypoints only

On that note, this is failing and not showing an error message. What's going on there?

Hey, I'm back from the Christmas break!
https://github.com/Expensify/App/issues/31816#issuecomment-1867491766 - Ah, I bet this is because I'm internal and see these MISSING TRANSLATION messages when the error message doesn't have a Spanish translation. Does this not have one then and it should?
On this comment, I'm not sure I'm following your suggestion. Can you restate it please or write it out in full using this reference point above? Thanks!

it's BE error so we haven't supported Spanish translation yet.

Got it, should we be though?

@trjExpensify Updated Regression Test Proposal here https://github.com/Expensify/App/issues/31816#issuecomment-1864785142

Thanks, I've created the issue for Applause!

Alrighty, settled up. Thanks ya'll!


query config param wait_timeout_mills was renamed shutdown_wait_timeout_ms

Config param was renamed in https://github.com/datafuselabs/databend/commit/5c46a271e8ee913f9f8443dafc99b2dd4c803303, but docs still indicate that this is valid param value.

https://github.com/datafuselabs/databend-docs/pull/832


Make all web pages support multiple languages

If you find that the multi-language display of any web page is incorrect, you can support it. For example: setting page: https://www.memfree.me/zh/settings
You could refer this PR: https://github.com/memfreeme/memfree/commit/781cd1f1b8438e72edac1bf1f3a98ace5bcdda2a
You can translate to multiple languages through memfree.me

Can you assign me this issue under hacktoberfest label?


feat(dashboard): fetch charts by owners instead of created_by

SUMMARY

The charts tab in the dashboard edit pane fetches from /sliceasync/api/read?_flt_0_created_by=2 which are charts the user created. This updates switches over to using the new api endpoint for charts and fetches charts the user owns.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

Navigate to the charts tab in the dashboard edit pane.
The tab should now be populated with charts the user owns.
Nothing else should have changed.

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #11336 into master will increase coverage by 1.10%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##           master   #11336      +/-   ##
==========================================
+ Coverage   61.56%   62.67%   +1.10%
==========================================
  Files         835      441     -394
  Lines       39653    14720   -24933
  Branches     3604     3606       +2
==========================================
- Hits        24414     9226   -15188
+ Misses      15058     5312    -9746
- Partials      181      182       +1

Flag
Coverage Δ

#javascript
62.67% <16.66%> (-0.01%)
:arrow_down:

#python
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...et-frontend/src/dashboard/actions/sliceEntities.js
12.12% <16.66%> (+2.44%)
:arrow_up:

superset/views/base_schemas.py

...ons/a33a03f16c4a_add_extra_column_to_savedquery.py

superset/migrations/versions/d39b1e37131d_.py

superset/dashboards/commands/create.py

...ations/versions/130915240929_is_sqllab_viz_flow.py

superset/utils/cache_manager.py

superset/utils/urls.py

.../versions/3325d4caccc8_dashboard_scoped_filters.py

superset/migrations/versions/1e2841a4128_.py

... and 385 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e97c4f...0a755d1. Read the comment docs.


Anonymous API calls

Hi,
Parts of my API must be accessible to anonymous users, so I added anonymous: true to the api firewall:
api:
  pattern:   ^/api
  stateless: true
  anonymous: true
  guard:
    authenticators:
      - lexik_jwt_authentication.jwt_token_authenticator

But when I call without a token, I get {"code":401,"message":"JWT Token not found"}. What am I missing here?

Hey, your issue is probably related to access controls which should allow being anonymously authenticated e.g:
access_controls:
    - { path: ^/api, roles: [IS_AUTHENTICATED_FULLY, IS_AUTHENTICATED_ANONYMOUSLY]] }

Hi, thanks for the quick response. I checked the access_controls, but that's not the issue unfortunately.

I just tried on our sandbox and it works as expected with anonymous listener enabled and proper access_controls. Could you try it and maybe fork it with the changes necessary to reproduce your issue? Usage:
git clone https://github.com/chalasr/lexik-jwt-authentication-sandbox/tree/allow-anonymous
cd lexik-jwt-authentication-sandbox
composer install
bin/console doctrine:database:create
bin/console doctrine:schema:update --force
bin/console server:run
curl http://localhost:8000/api

I found the problem, but not yet the solution.
I have
   access_decision_manager:
        strategy:             unanimous
        allow_if_all_abstain: true

in my security settings, and it looks like that doesn't play nicely with the anonymous api access.

If I define my anonymous routes explicit in the access_controls, it does work:
Works:
access_control:
        - { path: ^/api/login, roles: IS_AUTHENTICATED_ANONYMOUSLY }
        - { path: ^/api/forgot-password, roles: IS_AUTHENTICATED_ANONYMOUSLY }
        - { path: ^/api,       roles: [IS_AUTHENTICATED_FULLY] }

Does not work:
access_control:
        - { path: ^/api/login, roles: IS_AUTHENTICATED_ANONYMOUSLY }
        - { path: ^/api,       roles: [IS_AUTHENTICATED_FULLY, IS_AUTHENTICATED_ANONYMOUSLY] }

I am having a similar issue, but I do define the whole route explicitly and it still requires jwt

I am having a similar issue, but I do define the whole route explicitly and it still requires jwt

My issue was unrelated, it was security settings on Entity attributes

Having no issue here, i think it is the security bundle bug and should be fixed long time ago already. Consider update/upgrade the Symfony version for more stable and bug fix.


remove the filter condition on assigned time series office

we want to be able to retrieve empty groups
the documentation specified that the office id is for the group, so we don't care what office the category is in and category names are unique

Good idea, I added a comment.


skydive binaries require glibc version？

I try to build a skydive binary on my server, but found some warnning. Does it mean skydive binary requires glibc version?
if my guess is true, is there any way to build a pure static binary?
thanks for your help:)

It seems you are building the binary with make static right ? There is no easy way to build a completely static version of a Go binary that makes use of some features. So you need indeed to have glibc installed, but as the symbols used are pretty old and stable, an old version of glibc should work

thanks for your replay. I finally resolved this probelm by switching server os from debian to ubuntu.

@lhuang001 Thank you for your answer