add support for image family

I ran into an issue today where Cloud Build was... having a moment?

I really needed to enable cgroups v2 to the images (I couldn't do it as a startup script because reasons, and I needed cgroups v2 because I wanted to test k3s in rootless mode. I was bummed that cloud build wasn't working, but realized that I could instantiate previously built images, do the change to the grub config, and then save as a machine image. The steps looked like this:

Went to Compute Engine -> Images
Create an instance from each
Install cgroups v2 (instructions below)
Stop the instances
Under Compute Engine -> Image "Create an Image"
Create each one from Source Disk from the image Don't forget to use the same prefix for the family (e.g., flux-cgroups-manager-x86-052123 has family flux-cgroups-manager).

Note it's important to set the family for the images as this is how they are selected here. Also note that a machine image is NOT the same as just an image in compute engine (I made this mistake first, oops).
Here are the instructions I used to enable cgroups 2. Note that since I login as my user, sudo is needed. If this is in a root run start script, you likely wouldn't need it.
# This is what I ran manually to update the machines and save new images
sudo dnf install -y grubby
sudo grubby --update-kernel=ALL --args="systemd.unified_cgroup_hierarchy=1"

sudo mkdir -p<EMAIL_ADDRESS>cat <<EOF | sudo tee<EMAIL_ADDRESS>[Service]
Delegate=cpu cpuset io memory pids
EOF
sudo systemctl daemon-reload

And then I was able to update the family to be the families I defined here (allowed by the content of this PR) and create the cluster and verify that cgroups 2 is enabled (this was on the login node):
cat /sys/fs/cgroup/cgroup.controllers
cpuset cpu io memory hugetlb pids rdma

I was able to get k3s (master / control plane) running and am still working on the worker nodes, but I've gotten far enough with this change to open this PR! Feel free to disregard / not add, because it's probably a rare use case to want to modify the family, but I am finding it essential today.
ping @wkharold
TLDR
Problem: the user wants to use a custom image family, and currently the families are hard coded.
Solution: add the family name as a variable.

Woot!! :partying_face: I love contributing to Google projects on GitHub <3 Thanks @wkharold!


Support auto-completion of Metaflow objects/API in notebooks

We could support some form of auto-completion for Metaflow in iPython. Some examples:
def _ipython_key_completions_(self):
    return [s.id for s in self.steps()]

on a run to complete something like my_run['<tab>
Details on the possibilities here: https://ipython.readthedocs.io/en/stable/config/integrating.html#tab-completion

Hey @romain-intel can I take this up?
I think this would apply flow, all the flow components from Flow to task right?

Of course -- I am not currently working on it. But yes, it would apply to the objects in the client/core.py file so flows to artifacts.

Got it, will send a PR soon!

@romain-intel Should this be closed or kept open for adding autocomplete during object creation?


Strange not working at all :(

Hi,
I have a problem with mongolian. Callbacks are never called.
So I try to run the mongolian tests, and it freeze early :
npm test
npm info it worked if it ends with ok
npm info using<EMAIL_ADDRESS>npm info using<EMAIL_ADDRESS>npm info pretest<EMAIL_ADDRESS>npm info test<EMAIL_ADDRESS>
><EMAIL_ADDRESS>test /home/romain/node-mongolian
> node_modules/.bin/nodeunit test

collection1

I change mongodb version to 0.9.7-0 and it works now.
Thanks #64


updated readme with troubleshooting section

This pull request updates the README file for the Tech Talks X IntelligenZ project by adding a comprehensive troubleshooting section. The new section addresses common issues that users may encounter while setting up and running the website. It includes solutions for installation errors, server startup issues, API response problems, and general troubleshooting tips. This enhancement aims to improve user experience by providing clear guidance for resolving potential issues.

hello @Sanskriti1102, Could you please look into the pull request at your earliest convenience? I’d appreciate it if this could be reviewed soon so my points can be reflected on the leaderboard.


Filtering with IN, ANY operators

Hi,
I want to filter the data with multiple values with some operators or methods.
How Can I filter?
I tried the below one...but it throws error. Need a better documentation on filter, sorting etc with some sample queries.
query {
products(filter: "mediaCode.any[1,2,3]") {
items {
clientCode
mediaCode
}
}
}

The syntax is for calling a method is with braces () - so it should be mediaCode.any([1,2,3]).
Having said that, the array style may not be supported currently. I will update https://entitygraphql.github.io/docs/field-extensions/filtering with examples of each call and fix any issues found along the way.

Could you please give exact query?
I tried
query {
products(mediaCode.any([1,2,3])) {
items {
clientCode
mediaCode
}
}
}

As I thought above, this is currently not possible. Currently the any method works like the Enumerable.Any LINQ method. E.g.
{
  people(filter: "actorIn.any(name == \"Star Wars\")") { ... }
}

Basically translates into C#
people.Where(p => p.ActorIn.Any(a => a.Name == "Star Wars"))

I will look at adding support for above and update the docs too.

I know it is longer but you can (assuming mediaCode is just an int) write this
products(filter: "mediaCode ==  1 || mediaCode= 2 || mediaCode == 3")


deploy/kubernetes/manifests/payment-dep.yaml fails due to checkin f366007a2110013ddd29dc92afc8d30ada06de10

Not sure if this is on purpose but checkin f366007a2110013ddd29dc92afc8d30ada06de10 seems to cause the manifest of payment-dep.yaml to fail create due to requesting more resources than limit in kubernetes gke cluster.

Thank you @gaganapplatix. Investigating now.

PR here: https://github.com/microservices-demo/microservices-demo/pull/754


Snippets per host/group

Describe the bug
Update 14.16 has changed the feature ‘snippets’. Before update I had different snippets per host configured. Now they all merged into 1 list and only the first 5 (alfabetische in the list) are shown as icon. This makes for me the snippets much less usable.
Please restore the feature back to previous version.
Informations

Device : iPhone XS MAX
OS : iOS 14.15.1
WebSSH Pro version : 14.16.10

Sorry to hear that this new intended behavior doesn't comply with your needs 😢  but it was a nightmare to maintain.
I need some time to think about your issue.

Perhaps the best is to implement tags on snippets : a snippet could have a tag and the snippet will be displayed if the tag is the same as the host.
What do you think?

If it is possible to assign multiple tags to snippets and hosts then that would be maybe a solution.

Tags would be a fine way to handle this. Maybe instead of free form tags a user could screw up, just have it so user can select the hosts they want the snippet available in or check boxes.

I'm confused... is this still planned? What's the ETA?

@mbierman Hello 👋

Still planned but still delayed in favour of bugs.
No ETA. I don't drive by ETA.
What about https://github.com/isontheline/pro.webssh.net/issues/309#issuecomment-859897583 ?

Work In Progress : Ability to add tags on snippets and hosts

Tags on servers and snippets

From terminal
Server list

Hello @mbierman @hunter-nl @ash34 👋
I hope your are fine 🏖
Could you try WebSSH 15.0.8?
https://testflight.apple.com/join/QSrBK59z
Have a nice day ☀

Hello @mbierman @hunter-nl @ash34 👋
I hope your are fine 🏖

I am indeed!

Could you try WebSSH 15.0.8?
https://testflight.apple.com/join/QSrBK59z

I cannot get to snippets. Clicking the gear brings up the keyboard.

Have a nice day ☀
You too.

@mbierman Thanks for your feedback but I don't understand 😕

Are you sure that you don't press the search bar?
Are you running iOS 14 or iOS 15?
Could you make a video to replay the bug?

Sure. I can’t use snippets at all because they aren’t selectable. All that happens is the keyboard opens.
https://youtu.be/b3VP2TlIp3E

@mbierman OK I see 😬 sorry.
I will send a fix tonight.

No worries. That’s what testing is for.  Thank you

Does WebSSH 15.0.9 fix the issue?

@isontheline yes, but I don't understand how to assign snippets to one or more connections. Tags don't seem to do it.

@mbierman When a connection and a snippet share at least one tag then they are linked.
There is a limit of five snippets that can be shown at same time (due to yesterday bug), but others snippets can be shown inside a list when you press the gear.

O.K. some feedback

It can be hard to edit the ssh list in some cases. See the last one in my list which is covered by the “+” button.

How can I add two tags? “A,b” “A/b” “A b”? It would be nice if there was some example text in the UI to remind users.

Does capitalization matter?

Maybe there can be a default tag for connections? Hostname or IP? Initially I applied tags to snippets and nothing happened.

@mbierman

I have planned a fix thank you! Workaround : you can also edit a connection by long pressing a row.
Tags can be separated by any of these chars : ,;/-| and space. You can mix the separators on the same line. OK I will add a reminder.
Tags are always capitalized. It's "not possible" to add a lower case tag (or should be reported as bug).
By default a blank tag is applied so all snippets are linked to all connections. If you add a tag to a snippet, the same tag should applied to a connection in order to link them. You can also use the wildcard * to link a snippet to all connections.

@mbierman Does my previous feedback answers all your questions or do you need more information?

So if space is a valid separator can you quote two words to have a tag with a space?

No - yet - only one word tags are supported in order to reduce complexity of implementation.


rlhf-v数据格式中, rejected和chosen字段是否支持list of conversations with images？

Reminder

[X] I have read the README and searched the existing issues.

System Info

llamafactory version: 0.9.1.dev0
Platform: Linux-5.15.0-91-generic-x86_64-with-glibc2.31
Python version: 3.10.0
PyTorch version: 2.4.0+cu121 (GPU)
Transformers version: 4.45.0.dev0
Datasets version: 2.20.0
Accelerate version: 0.34.0
PEFT version: 0.12.0
TRL version: 0.8.6
GPU type: NVIDIA L20
DeepSpeed version: 0.15.2
vLLM version: 0.6.1.post2

Reproduction
通过文档，可以知道目前支持类似RLHF-V的数据格式:
"Conversations": [ { "from": "human", "value": "Are there any stop signs with yellow writing on them?" } ]
"Rejected": { "from": "gpt", "value": "Yes" }
"Chosen": { "from": "gpt", "value": "No" }
请问Rejected/Chosen是否支持conversations的格式？例如
"Conversations": [{"from": "human","value": "Hello"}, {"from": "gpt","value": "Hi"},{"from": "human","value": "Have a nice day!"}],
"chosen": [
{"from": "gpt",   "value": "OK!" },
{"from": "human",  "value": "How are you?"},
{"from": "gpt", "value": "I'm fine"}
],
"rejected": [ {"from": "gpt", "value": "No, I'm bad"} ]
Expected behavior
preference数据集格式中，reject or chosen字段支持list of conversations with image
Others
No response

目前仅支持给定的格式


Issue with legends in process_and_plot_files

The process_and_plot_files cannot display legends for the plots. Have to fix it.

fixed  in ad7432cdaf6728747d3ca60a0b5c65b51636e6aa


Polyfill for TextDecoder

I was toying around with server side blazor and the first culprit i run into was the lack of Edge support 😉
I've extracted the least amount of Polyfil necessary from https://github.com/samthor/fast-text-encoding/blob/master/text.js#L137 which worked for my experiments and still uses the native TextDecoder in other browsers.
Not sure if this is acceptable or how / where i need to attribute this.
Fixes #1131

Can it be that the tests are flaky? I pushed, got 2 failed tests, ran it locally, got one failed test, tested the current master HEAD locally, tests passed, reapplied my patch, tests passed again, force pushed a comment change to retrigger CI, got 4 test failures?!

Thanks @Suchiman for suggesting this.
Yes, you're right: the E2E tests are currently flaky since we put in the ones for server execution. This is because the browser UI updates occur asynchronously in this mode, and not all the tests allow for that. In #1153 I'm working on making them all robust.
Your selection of polyfill here looks good. However we do need to do something about attribution, which I will figure out. Also I think we'll probably use this polyfill internally in the Blazor library and not attach it globally to window because we don't want to interfere with any other polyfill the developer is trying to use. So if it's OK with you, I will reorganize some aspects of this PR before I merge it!

So if it's OK with you, I will reorganize some aspects of this PR before I merge it!

Of course

As discussed, moving this over to #1168 so I can make some additions.


kafka-python v1.4.5 drastically impacts consumer performance.

I made an issue over in the kafka-python project about new versions causing the consumer to perform with only an eighth of the throughput. You can see the here:
https://github.com/dpkp/kafka-python/issues/1888
In our case, this is a big issue as the the latest versions of this project can no longer keep up with our __consumer_offsets topic in some clusters.
I think that this project should explicitly depend on kafka-python v1.4.4 until this is fixed.

Decided in https://github.com/braedon/prometheus-kafka-consumer-group-exporter/pull/31 not to hold back kafka-python for now, since the performance decrease in 1.4.5+ isn't expected to be problematic for most users.
Leaving this issue open until https://github.com/dpkp/kafka-python/issues/1888 is resolved.
If you're affected by this issue, please weigh in!

@braedon kafka-python 1.4.7 should be in a good state. Can we cut a new release of this project to update the dependency?

I've released 0.5.4 with exclusions for kafka-python 1.4.5 and 1.4.6. The 0.5.4 docker tag has been built using kafka-python 1.4.7.


App/website for less techy users

inste.ad
Hi, thanks for the 'awesome' work done in combiling this list!
I could not but think that a much wider base of users/people should have access to such knowledge.
So, my feature request is that you/someone creates an app on phones and a website with a very simple graphical interface.
The main functionality would be as follows:

The user enters their usual go to service such as "google forms" in an input field that has an auto complete
The output comes up with recommended alternatives, and with simple icons next to them indicating one or two things, e.g., when was this alternative added or checked/audited to be still respecting privacy.

I guess an organization can support such work because of the financial costs involved, there are many NGOs in the EU that work in this domain, and I have a feeling they would be interested in such a project.
I know privacytools.io exists, but that's still a geeky resource with jargon, loads of text, and the website is a bit creepy as if seeking privacy is hiding a crime.
An example of a use case I am thinking of is someone in a small company/institution is about to create a google form, instead of opening the browser to google forms, they would do a couple of more clicks, they would go to INSTE.AD app or website, type google forms, get the alternatives, see a green check next to it as it was recently cheked, and click on it to use it.
And yes, I thought of the name of the service and the domain too, inste.ad is a great name for easy marketing no? and as of writing this post on 19 August 2023, it is available for registration.
If someone is willing to lead this, I would be happy to give more ideas...

Hi, creating a website has been on my mind for a long time. I may dive into it soon!

I just got my github education benefits, tell me and I'd register. I mean why not if we can get a domain for free for one year. Along with that, will love to contribute on the new project. Let's get started. 🚀


Patch May-July 2019

CFF Patch: Improving RMCDHF and extending terms to J = 17/2 (l, m-)
In May @cffischer sent me a collection of updates, fixes and general improvements that I've put together into a single patch. The most important fixes are related to how the Lagrange multipliers are calculated in RMCDHF, and she has also extended the allowed terms on step to J=17/2 (l, m-). I've also added some minor fixes to the rwfnmchfmcdf code and the ldlbl1 and 2 files in the transition codes which should remove some warnings during compilation.
Check the patch out and see what you think, review the code and let's get back to this in a week or so for merging.
A description of the mods by Charlotte follows.
/Jon
Patch summary (CFF)
'RMCDHF' is not robust in that accurate initial estimates are needed.
When algorithms fail, the messages are misleading, and in some instances
the program simply stops. Several changes have been introduced that
increase the robustness and the efficiency.
Tests
The changes have been tested for a correlation study for Li 1s(2)2s(1) J=1/2 for wavefunctions from SDT excitations to nl=9l.
Libmod - increase J of allowed terms.

terms_C.f90

Changes have been introduced that increase the maximum J to 17/2
or l or m-.
Lib9290 - joining point evaluation has been improved

setpot.f90

This routine uses an algorithm that involves the orbital energy for
finding a join.  When the energy estimate is such that the criteria
for the join is not met, the program STOPS. The STOP has been
replaced  by  JP=NNNP/2.  This sets the join to be the middle of the grid.

start.90

Remove the comment about accuracy because the problem is not related to
accuracy and is misleading.
RMCDHF

setlag.f90 and setlagmpi.f90

There was a logical  error in the section determining
Lagrange multilpliers.  When two subshells are
both varied the solution is not unique so the
desired solution is one where the lagrange
multiplier is zero.  But as soon as the orbitals
for one is fixed, a lagrange multiplier is needed.
Also, the order of the lagrange multipliers were
not in the most efficient order.
The calculation of Lagrange multipliers in the CSF
procedure for heavy elements is the most time
consuming task particularly the calculation of the
exchange term. The order of computation has been
modified so that POTL and XCH functions are called
the minimum number of times.  In Francine (Fr)
45 calls to exchange were reduced to 30 call.`When
Correlation is included, XCH function includes
contributions from all the interactions as well as
exchange.

in.f90

When the algorithm for finding the outward boundary
condition did not find an end-point, because of poor initial
estimates an error message claimed the range was insufficient.
In the present code it is defined to be NNNP-1.  An
appropriate "end point" is determined in subsequent
iterations.  The range NNNP=590 has been found adequate
for all test cases.
Tools - increase dimension of the tools codes
Many of the routines in the tool library, do not use the GRASP
parameters for determining dimensions and are subject to error.  In
particular, "lines" of input data have character dimension of 100.  For
heavy elements, this may not be sufficient and the program does not
detect that information is lost.
The two corrected cases are,

rmixaccumulate.f90
rmixextract.f90

but there are probably more.
Actually, it is not a correction really since this just changes 100 => 200. But
there are several other cases that probably also are wrong.  Unless
someone else updates the online GRASP2018 code, Charlotte said she will do that as soon, possibly this summer. rmixextract.f90 also had another error that she fixed.
Additional fixes (JG)

tools/rwfnmchfmcdf.f90

Bugfix: initialization loop of arrays were done in an old fashioned style, but also from element 0 which gave a warning during compilation. This is now changed to simple A = 0 statements.

rtransition(_mpi)/ldlbl1(2).f90

Fixed legacy-style read statements.

I have reviewed the changes --- all look good.

OK

Ok, I think we're good to go. Will go on vacation on Tuesday, so will probably try to merge this into master on Monday latest if there are no further objections.

Aight, removed the final timestamps suggested by @mortenpi. Will merge now then!

Done! Thanks to @cffischer for the update and @mortenpi for the reviews. Let's hope everything works as expected now then.


Structure templates/customers schematic folders

Current Behavior
Customers templates are empty liquid files with no related js or scss files.
Expected Behavior
Customers templates should be defined inside a folder with basic liquid structure and have the related js and scss files.
Related Issue(s)

Fixes #

:tada: This PR is included in version 1.0.0-alpha.1 :tada:
The release is available on:

GitHub release
npm package (@alpha dist-tag)

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-beta.1 :tada:
The release is available on:

GitHub release
npm package (@beta dist-tag)

Your semantic-release bot :package::rocket:


Make Bar Visualizer Responsive

I love both of the visualizers, but it would be rad if the bar version would recalculate width on resize. It's rad that it at least loads the right size initially though.

Bummer that the mini mode doesn't do the same.


A little question about the applications in real word senarios.

Great job! However, I believe that when using few-shot learning, real-world scenarios often involve dealing with samples that are difficult to obtain. In such cases, can pre-trained models such as GPT and DALL-E provide good results?

Great job! However, I believe that when using few-shot learning, real-world scenarios often involve dealing with samples that are difficult to obtain. In such cases, can pre-trained models such as GPT and DALL-E provide good results?

请问，imagenet数据集怎么下载啊，我下载之后，运行报错。


Migrate packages to Github Actions

What would you like to be added:
Before we can start to migrate each package pipeline, we need to finish the following issues first, before we can move on with this one:

#1786

Once those prerequisites are fullfilled, we can start to migrate each package pipeline to Github. These includes:

[ ] tar
[ ] systemd
[ ] syslinux
[ ] sudosh2
[ ] sops
[ ] selinux-policy-targeted-fedora
[ ] selinux-basics
[ ] runc
[ ] refpolicy
[ ] python3.11
[ ] python3.10
[ ] python3-defaults
[ ] perl
[ ] pam
[ ] ostree
[ ] oras
[ ] openssl
[ ] openssh
[ ] onmetal-image
[ ] microsoft-authentication-library-for-python
[ ] metalbond
[ ] linux kernel (6.1, 5.15, 5.10)
[ ] tdx
[ ] libyang
[ ] libstoragemgmgt
[ ] libpam-ssh
[ ] kpatch
[ ] iproute2
[ ] ignition
[ ] golang-1.20
[ ] glibc
[ ] gardenlinux-selinux-module
[ ] gardenlinux-repo-manager
[ ] frr
[ ] ferm
[ ] ena dkms
[ ] docker.io
[ ] docker-machine
[ ] cyrus-sasl2
[ ] curl
[ ] containerd
[ ] cloud-init
[ ] aws-sdk-cpp
[ ] aws-kms-pkcs11

Why is this needed:
In order to streamline the whole Garden Linux build, we want to migrate all pipelines to Github Actions to streamline the whole building process end to end.

I create https://github.com/gardenlinux/package-build/issues/38 to track the migration status.

All package repos that should be migrated, are migrated now.
Some package repos shouldn't be migrated as stated in https://github.com/gardenlinux/package-build/issues/27
Others are already migrated but we still work on the build itself that might. Those packages are tracked in https://github.com/gardenlinux/package-build/issues/38
As a result, since the actual repos itself have been migrated, I'm closing this specific issue. The mentioned issues above will track the further progress.


Having stage statistics

Currently it is possible to know if a job failed, but it would be interesting to know in what stage of the pipeline the job failed.
Example of use case:
Jenkins job is devided into the following stages:

lint
build
test backend
test frontend
functional tests

Knowing that a job fails during build or during functional tests requires very different actions to fix.

Hi @Tiagojdferreira, this sounds like a nice feature. It's not something we'll be working on in the immediate future, but feel free to submit a PR if you get started before we do. Thanks!

This issue is duplicated now and is being discussed in https://github.com/DataDog/jenkins-datadog-plugin/issues/152. Closing this issue. @Tiagojdferreira If you have a simple pipeline script i could use to test, that would be great 😄


Turtlebot4 Showing LiDAR data in model but not map

Robot Model
Turtlebot4 Standard
ROS distro
Humble
Networking Configuration
Discovery Server
OS
Ubuntu 22.04
Built from source or installed?
Installed
Package version
?
Command returned:
dpkg-query: package 'ros-humble-turtlebot4-package_with_issue' is not installed and no information is available
Use dpkg --info (= dpkg-deb --info) to examine archive files.
Type of issue
Networking
Expected behaviour
When I launch the SLAM map in Rviz2 a map is displayed that is captured by the Turtlebot4 LiDAR
Actual behaviour
A small white circle is displayed and the terminal complains that the data from 'rplidar' isn being used due to the queue being full
Error messages
No response
To Reproduce

Have network type set to Discovery Server
Launch Rviz2 to view the LiDAR map with this command "ros2 launch turtlebot4_viz view_robot.launch.py"
Observe Rviz2 display

Other notes
A similar issue that was closed due to inactivity can be found here: https://github.com/turtlebot/turtlebot4/issues/288
I am currently using the TurtleBot4 with a discovery server due to being on a university wifi. I tried to view the mapping software for the turtlebot4 but was instead met with a white circle. The terminal window is also filled with warnings for the queue being full for the 'rplidar' (I don't currently have access to robot so I am unable to give exact message). As seen in the linked post, my model window looks the exact same with the model being loaded and the room boundaries discovered by the LiDAR displayed as dots, but when I try to view the data as a map, I just have the white circle as seen in the post.
The package version not being available on my system concerns me but I am certain I have installed everything, but am happy to do so again.

Hello @LiamCClarke ,
Thank you for reaching out on the official Turtlebot 4 Github page. Out of curiosity what is the fixed frame set to in RVIZ? Double check to ensure it is set to base link, or if using a map, that the map file is readable by RVIZ. Would it be possible to share an excerpt from the terminal output, as well as a screenshot from RVIZ. Looking forward to hearing from you soon.
Best Regards,
Saif

Hi Saif, thanks for responding. I have just checked RViz2 with the TurtleBot model and sensor data launched and seen that the Fixed Frame is set to "base_link"

The entire window looks like this

As you can see, I am receiving the correct model, sensor data, and camera data. Here is the terminal for the model view

Here is an attempt at viewing a map:
First I sourced my Ros bash file, then I attempted to launch synchronous SLAM via my PC but was met by the 'rplidar_link' queue is full messages

I then launched another terminal to open Rviz2 with this command
ros2 launch turtlebot4_viz view_robot.launch.py
again showing the same warning messages.

Finally, the Rviz2 window looks like this

@LiamCClarke Can you share a full topic list when you are running slam?

@hilary-luo Hello, Here is the ros2 topic list while I am running synchronous SLAM in another terminal window

From what I can gather, Rviz is complaining that the frame [map] doesn't exist. Using the "2D Pose Estimate" feature doesn't create my [map] frame. Setting the Fixed Frame to something like base_link or rplidar_link gives me LiDAR data. I am assuming that there needs to be some kind of publisher that completes the TF tree for map?? I dont quite understand what I have just typed but seen a lot of advice pointing to a solution like this. Do you have any experience with this? Thanks

@LiamCClarke are you able to echo the create3 topics on your PC? (dock_status, odom etc.)
Also, can you confirm that if you run ip route, do you have an entry along the lines of <IP_ADDRESS>/24 via <IP_ADDRESS> dev wlp0s20f3 where the second value is the IP address of your raspberry pi and the last is your wifi interface across which you are communicating with the raspberry pi?

@hilary-luo , Yes I currently have an IP route for my turtlebot.

@LiamCClarke and you can successfully echo the topics I mentioned above? I have seen this sort of presentation before when there was an issue with the ip routing from the PC to the create3 (it was entered incorrectly). In that situation Nav2 was receiving the lidar information from the robot but was unable to do anything with it and unable to produce the map because it was missing the odometry from the create3. Hence, none of the lidar data is being processed and you get the queue is full messages.

@hilary-luo sorry I missed that part. I tried echoing the odom topic and received no return message. I have attached the command I used as I am not too familiar with bash and ros so you can correct me if I have called it incorrectly

@LiamCClarke That is the correct command. Be aware though it could take as long as a few seconds to receive the first message depending on your network. If you did wait for a significant amount of time with no response, it confirms that you are not getting the create3 data successfully. Since you can see the create3 topics that tells me that the ROS system is set up correctly (both the create3 and your computer are checking in with the Discovery Server on the Pi). This therefore leads me to believe that there is a problem with your IP routing. Either there is an error with the IP routing table entry or you have a more complex networking setup which requires more changes. Given my understanding of your system so far, you should not be able to ping the create3 currently and the issue will be solved when you are able to ping the create3 (ping <IP_ADDRESS>).
The following steps assume that you are not using a VM or container etc. Those elements make the networking more complicated. If you are using anything like this then please provide detailed information about your networking setup. If not, then go ahead:
First I would confirm that the route aforementioned is accurate to your system. Is the IP Address listed for your raspberry pi accurate? (Ensure that it is the IP address that your wifi router has assigned to the pi and if you have not reserved the IP address on your router know that it may change over reboots. Make sure that you can ping the raspberry pi at this address and if you have more than one turtlebot4, turn the rest of them off and make sure that you are pinging the correct pi). Do not use any environment variables to define this IP address, ensure that it is hard coded with the IP address itself.
Next I would confirm that the network also listed in that same route is correct and matches the network that your computer will need to use to connect to the robot. For example, if my computer is connected to the same wifi as the turtelbot4 then I will be using the wifi connection to communicate with the robot. Therefore, the wireless network interface name should be listed after dev. This should be the same name as is listed for the network if I run ip a. However, if I have a wired connection to my router while the turtlebot4 is on the wifi network provided by that same router then my ip route should list my wired network interface connection.
The goal right now is to be able to identify the issue. Depending on what the issue is, you may have to rerun the discovery server configure script to make the change permanent.

@hilary-luo Thanks for the detailed reply. I tried to echo the odom topic and didn't receive a reply after several minutes. I am not using any type of VM or container but instead use a dual boot system though I don't think this affects anything. As you said, I am unable to ping the Create3.

The IP route seems correct and whenever my network does change the IP, I rerun the script to recreate the iproute and test that it works. my network interface is the same as what is listed after the dev.

@hilary-luo I have had similar problems.  You need to be receiving the /odom topic else the TF mapping from /map to /base_link cannot be accomplished.
A couple of troubleshooting things you can try (works for me, using Discovery Server):

Completely reboot the turtlebot4 (power off (pull off dock and press large button on base until it chimes, about 8 seconds) and then power on by putting on dock, wait for "chime" (indicates create3 base has restarted).  If you do not see 5 green LEDs on turtlebot4, then you need to reboot the pi (ssh into pi and "sudo reboot")
Make sure to see a "<IP_ADDRESS>/24 via  dev " when you do an "ip r"
"ros2 topic echo /tf_static --once | head", check that the "header | stamp | sec" indicates a current time (int >1711571993), can check by putting number into something like https://www.unixtimestamp.com/.  The pi does not have a real-time clock and so can  have an invalid "old" time after a reboot.
"ros2 topic echo /odom --once | head" to also check "header | stamp | sec" as this is coming from the create3 base and it may not have properly synced its timestamp
If all the above works, then slam "map" should work

Note that due to a delay in the "/odom" topic coming from the create3 base relative to the topics coming from the pi (I typically see on the order of 10s of milliseconds), this typically screws up Rviz if trying to vie the LIDAR using "/odom" versus "base-link".  I did a workaround by rebroadcasting the /odom tf by adding 0.1 s to the header timestamp, but that is a bit of a kluge and not necessary when using SLAM/NAV2.

Hello @LiamCClarke ,
Have you tried the suggestions mentioned by @arkcom55 ? Were they successful? If you have any updates please feel free to share them. Looking forward to hearing from you soon.
Best Regards,
Saif

Hello,
This issue is being closed due to inactivity. If you are still experiencing the issue, feel free to reopen this ticket when you are ready to continue the troubleshooting process.
Best Regards,
Saif


One aggregate per actor pattern

Efficiently support the pattern to have one DDD Aggregate per EventsourcedActor. The example application still follows the many aggregates per actor pattern but it has already been re-written by @remcobeckers to follow the one aggregate per actor pattern (see also this discussion). Eventuate should support efficient implementations of this pattern by providing the following enhancements:

the event log must be indexed by aggregate id for efficient recovery of individual aggregates
if an aggregate actor writes an event, the event log should only notify those aggregate actor replicas with the same aggregate id (and not all other actors subscribed to the event log). Nevertheless, EventsourcedViews or non-aggregate EventsourcedActors continue to receive all events written to the event log (to support the one view for many actors pattern, for example).
implement EventsourcedAggregate as specialization of EventsourcedActor to support implementing the one aggregate per actor pattern.
consider implementing aggregate services similar to CRDT services to free applications from dealing with low-level details.
the one aggregate per actor prototype is already implemented in a way that vector clock sizes scale with the number of replicas only instead of the potentially large number of aggregates. Ensure that an implementation of EventsourcedAggregate cannot break this property.

I didn't have time yet to write this up, so awesome you already took the time! I couldn't have put it more accurate. If all of this is supported it would reduce the amount of code needed for one aggregate per actor to the minimum I think.
I was initially thinking of implementing a VersionedObject (for a single aggregate) similar to the VersionedObjects which I have been heavily borrowing from to implement the one aggregate per actor in the example. I think offering an EventsourcedAggregate is a better idea. With that the boilerplate needed can be reduced further and the intended usage is much clearer. A VersionedObject might be useful in building the EventsourcedAggregate though.

@remcobeckers no worries!
Glad that the summary fits your requirements. I agree, something like VersionedObject should be part of the implementation as well. Not only for EventsourcedAggregate but also for re-use in views.
I still need to complete some other tickets first but hope to be able to start working on this soon.

@remcobeckers I just committed a first implementation supporting the one-aggregate-per-actor pattern. It introduces an optional aggregateId to EventsourcedActor. If aggregateId is not defined, the actor receives all events from the event log (backwards compatibility). If aggregateId is defined, the actor only receives events from EventsourcedActor replicas with the same aggregate id (isolating aggregate actors from each other). I did not introduce a separate EventsourcedAggregate. This wasn't necessary but could be easily done by applications to require an aggregate id, for example. The Scala example application is re-written and applies the new pattern, the Java example still uses the old n-aggregates-per-actor pattern but I'll rewrite that later too.
The event log is not indexed yet, so an aggregate recovery is a full log scan at the moment but this is an implementation details in the event log. The index will come with one of the next commits (together with user doc and API doc updates and further tests).
Would be great if you could take a look at the commit and let me know if it fits your requirements.
Cheers,
Martin


Development

I removed because weapon Type because it comes down to ItemType but with less possibilities like grenades.
I removed the switch case because I find it dangerous.
It has been replaced by an extinguishing method that does the same job.

I have a bug and I do not understand why, it is not present on my machine but when I tested with a friend it appears


Create any DB docker e.g. Postgres and Admin to manipulate the objects

Create docker container for Postgres server
PG Admin, probably a web based adminer will be great
Wiki - Commands for docker-compose
Wiki - How to start stop server / container
WIki - How to remove the container and this images
Wiki - How to map the ports and pick the IP/host/BD name as cofig foro an application

Done now.

WIki >> https://github.com/authorjapps/zerocode/wiki/Sample-DB-SQL-Executor
Docker >> https://github.com/authorjapps/zerocode-docker-factory/wiki/Docker-container-for-a-Postgres-DB

@Pulsar1224, this might be useful for your usecase. 👍
Related issue https://github.com/authorjapps/zerocode/issues/158


Validations

Validate if configmap exist and is in the namespace/name format
Verifiy if watch-namespace option exist

This change is

Coverage increased (+0.02%) to 43.265% when pulling 3524361bd35e006ea736d0ad29b0b63254a1bb8d on gianrubio:validate-configmap into 0cb8f59f70f3f351c0534a101b1b98a803c26ac4 on kubernetes:master.

Coverage increased (+0.09%) to 43.126% when pulling c6195c44f3c124e918173c3627ec8fc0d5b5b612 on gianrubio:validate-configmap into 041f269770f08662c4dd45a22169ae4b6d458734 on kubernetes:master.

/lgtm

@gianrubio thanks!


Example are not building

Hi,
I am new guy to Flutter, so maybe I am doing something wrong, however while trying to run example from the project I got next error

Launching lib/main.dart on iPhone 8 in debug mode...
Removing obsolete reference to flutter_assets from Runner.app
Xcode build done.                                            3.8s
Failed to build iOS app
Error output from Xcode build:
↳
** BUILD FAILED **
Xcode's output:
↳
=== BUILD TARGET image_picker OF PROJECT Pods WITH CONFIGURATION Debug ===
/Users/someuser/projects/PUBLIC/flutter_proj/flutter_tflite/ios/Classes/TflitePlugin.mm:19:10: fatal error: 'tensorflow/lite/kernels/register.h' file not found
#include "tensorflow/lite/kernels/register.h"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

I tried other projects containing tflite as a dependency and I didn't get such an error.
Also, I tried to change workspace and project build system to legacy, but it didn't help.

I have the same issue... Any help on this?

On Android, I am getting the following when running the example: ByteBuffer is not a valid flatbuffer model (when initially loading the model). Is this a versioning issue perhaps? Thanks.

Hi @adyachok @Statyk7,
Can you check if the tensorflow header files are located in "tensorflow/lite/kernels/register.h"? I know in earlier versions the headers are in "tensorflow/contrib/lite/kernels/register.h".
You can use CONTRIB_PATH to toggle the path. Uncomment //#define CONTRIB_PATH:
https://github.com/shaqian/flutter_tflite/blob/master/ios/Classes/TflitePlugin.mm#L1
Thanks,
Qian

I'm closing the issue for now. Feel free to reopen if you have other questions.
Thanks,
Qian

This is not working for me at the moment


jetstream/fortify over breeze

Hi,
I was wondering why you went chose breeze over fortify which offers extras like 2fa? Was there a particular reason/impediment or would it be possible for me to remove breeze for jetstream?

we will going to change breeze with jetstream on the next version v2


There should be an option to upload the image if the admin is trying to add velocity metadata in the footer left content section

Bagisto Version: Master
Steps To reproduce--
1. Log in as an admin.
2. Click on velocity
3. Reach  on footer-left-contant section.
4. Try to insert image
Expected result: There should be an option to upload the image if the admin is trying to add velocity metadata in the footer left content  section
Actual result: The admin is not able to upload for footer from the velocity footer-left-content section. Please find the screenshot Here

@Sanjaybhattwebkul
It is not a bug as in source field you need to put image link.

Considering this as enhancmenet.


instantiateToBounds sometimes fails to eliminate type parameters

When the following code snippet is analyzed in strong mode:
    class C<T extends C<T, U>, U extends num> {}
    C x;

The type of x is being instantiated to C<C<dynamic, U>, num>.  This can't be right, since U is not in scope at the site of the declaration of x.
Reading through the code for StrongTypeSystemImpl.instantiateToBounds, it's not clear to me what the intended behavior is.
Note that if the order of generic args is reversed, i.e.:
    class C<S extends num, T extends C<S, T>> {}
    C x;

the type of x is instantiated to C<num, C<num, dynamic>>.

ah it's a recursive bound. in general we don't handle those very well in strong mode.

Oh shoot. We had an (apparently incorrect) assumption that earlier type parameter bounds did not depend on later type parameters. But here the bound on T depends on U. Thoughts @leafpetersen ?

I had in mind that the F-bounded subtyping for strong mode would be ordered, rather than mutually recursive, in which case the initial example is broken code and should get an error.
This might be too restrictive - I'd like to consider supporting mutually recursive bounds.  It covers some useful cases.
I also think I need to rethink the implicit instantiation logic - I am leaning towards just not allowing implicit instantiation for things with f-bounds.  The answer you get there is almost never what you want.

I also think I need to rethink the implicit instantiation logic - I am leaning towards just not allowing implicit instantiation for things with f-bounds. The answer you get there is almost never what you want.

yeah, great idea.
another place this comes up is generic functions/methods, when the upper bounds can be the best result we get out of inference. Would we want to also disable inference in those cases?

Yeah, at least in the f-bounded case, I'm thinking that we should probably just ignore the bounds for inference.  We could think about how to use them, but in general I don't think we can do so usefully.  We may want to use them in the non-f-bounded case, but I think it's pretty marginal benefit.

Question came to mind.
How is this being handled for cases like class Enum<E extends Enum<E>>?
In the case where you extend it you have to resolve the circular nature, ie, class IntEnum extends Enum<IntEnum>, but in this case the correct behavior as far as I can tell is to construct the infinite type Enum<Enum<Enum<Enum<Enum....
Maybe the correct behavior is to detect this and report that it cannot be instantiated without specifying the type parameters because they would be infinite. Or maybe the infinite nature could be handled with some tricky algorithms.

that's a really good question :D. There's a lot of discussion over in this issue: https://github.com/dart-lang/sdk/issues/27526

This is now fixed.


Look for image change by comparing props

Since state.image.src is replaced by a high-res version when handleUnzoom is called, checking for an image change by comparing nextProps to this.state will always return true. The result is that the high-res image is replaced by the low-res and left that way.

Oops. I didn't pay attention to what this was branched from. Will fix


'Distance' property of undefined, while parsing scene

While training unreal model on medium-sized SUNCG dataset I found problem with one scene (wish only one, as I couldn't continue my train after an error occurred).
I don't know concrete reason but while running .js script for scene parsing it couldn't establish scene and its distance.
Please, look here at sim00/simserver.log traceback (other 3 servers has the same error, when loaded scene).
Is it due to partial data, included in suncg.v2.zip archive? It was provided to me by the authors of SUNCG alone for minos task.

2018-03-13 20:10:45,387 INFO b'preloadData { loadSceneStatistics: true, loadSounds: false }'
2018-03-13 20:10:45,387 INFO b'Loading scene  p5dScene.cf85f3aafa09bb6fc7c228835ef25a33'
2018-03-13 20:10:45,392 INFO b'preloading /root/data/suncg//navgrid_10/cf85f3aafa09bb6fc7c228835ef25a33/cf85f3aafa09bb6fc7c228835ef25a33.empty.grid.json'
2018-03-13 20:10:45,392 INFO b'preloading /root/data/suncg//wall/cf85f3aafa09bb6fc7c228835ef25a33/cf85f3aafa09bb6fc7c228835ef25a33.arch.json'
2018-03-13 20:10:45,392 INFO b'preloading /root/data/suncg//wall/cf85f3aafa09bb6fc7c228835ef25a33/cf85f3aafa09bb6fc7c228835ef25a33.arch.json'
2018-03-13 20:10:45,397 INFO b'Removing subscribers for event drain [ 0 ]'
2018-03-13 20:10:45,549 INFO b'Timing loadScene: 159.492ms'
2018-03-13 20:10:45,559 INFO b'Loaded p5dScene.cf85f3aafa09bb6fc7c228835ef25a33 bbdims: [5.282054875069392,2.7800000104308142,8.214471497729662]'
2018-03-13 20:10:45,559 INFO b'Retexture scene'
2018-03-13 20:10:48,012 INFO b'buildBVH.scene: 5.133ms'
2018-03-13 20:10:48,012 INFO b'SimState.sample: 10.781ms'
2018-03-13 20:10:48,012 INFO b'Timing for initial is 0'
2018-03-13 20:10:48,012 INFO b'Parsing grid for p5dScene.cf85f3aafa09bb6fc7c228835ef25a33 navmap'
2018-03-13 20:10:48,012 INFO b'Refining grid'
2018-03-13 20:10:48,013 INFO b'Populating occupancy'
2018-03-13 20:10:48,013 INFO b'set active level 0'
2018-03-13 20:10:48,017 INFO b'started... waiting for all images to load'
2018-03-13 20:10:48,084 INFO b'Removing subscribers for event drain [ 0 ]'
2018-03-13 20:10:48,085 INFO b'Timing waitImages: 68.464ms'
2018-03-13 20:10:48,126 ERROR b'/root/repos/minos/minos/server/node_modules/sstk/client/build/STK-core.bundle.js:32592'
2018-03-13 20:10:48,126 ERROR b'\t          if (c.distance < room.distance) {'
2018-03-13 20:10:48,128 ERROR b'\t                ^'
2018-03-13 20:10:48,128 ERROR b''
2018-03-13 20:10:48,128 ERROR b"TypeError: Cannot read property 'distance' of undefined"
2018-03-13 20:10:48,128 ERROR b'    at SceneState.__getIntersectedRoomAt (/root/repos/minos/minos/server/node_modules/sstk/client/build/STK-core.bundle.js:32592:18)'
2018-03-13 20:10:48,129 ERROR b'    at SceneState.getIntersectedRoomAt (/root/repos/minos/minos/server/node_modules/sstk/client/build/STK-core.bundle.js:32607:20)'
2018-03-13 20:10:48,129 ERROR b'    at Simulator.getObservations (/root/repos/minos/minos/server/node_modules/sstk/client/build/STK-core.bundle.js:104361:48)'
2018-03-13 20:10:48,130 ERROR b'    at /root/repos/minos/minos/server/node_modules/sstk/client/build/STK-core.bundle.js:104290:12'
2018-03-13 20:10:48,131 ERROR b'    at /root/repos/minos/minos/server/node_modules/sstk/client/build/STK-core.bundle.js:35281:10'
2018-03-13 20:10:48,131 ERROR b'    at eachOfArrayLike (/root/repos/minos/minos/server/node_modules/sstk/client/build/STK-core.bundle.js:35215:10)'
2018-03-13 20:10:48,131 ERROR b'    at eachOf (/root/repos/minos/minos/server/node_modules/sstk/client/build/STK-core.bundle.js:35263:6)'
2018-03-13 20:10:48,131 ERROR b'    at _asyncMap (/root/repos/minos/minos/server/node_modules/sstk/client/build/STK-core.bundle.js:35279:6)'
2018-03-13 20:10:48,131 ERROR b'    at Object.map (/root/repos/minos/minos/server/node_modules/sstk/client/build/STK-core.bundle.js:35268:17)'
2018-03-13 20:10:48,131 ERROR b'    at Simulator.getGoalObservations (/root/repos/minos/minos/server/node_modules/sstk/client/build/STK-core.bundle.js:104282:10)'
2018-03-13 20:10:48,243 INFO Finished simserver stderr
2018-03-13 20:10:48,243 INFO Finished simserver stdout

I encountered the same issue, I just evades using that specific room.

@kojimano
Thnx for solution.
I would like to ask you for an example of valid object_suncg_mf.py file, considering filtering that particular scene, and 10 first scenes, which you and msavva noticed to be in evaluation (or they are already filtered in some code in main repository or in unreal)?

I am asking, because I tried to filter scene with new
    'scene_filter': lambda s: 2 < s['nrooms'] < 6 or s['sceneId'] == 'cf85f3aafa09bb6fc7c228835ef25a33',

which spends eternity to load scene and not even try to initialize server.

@kvas7andy The filter you copied will not work because you need to use 'id' not 'sceneId' (refer to the column headers of the file specified in "scenes_file" for valid filter columns).  You are likely observing freezing on initialization because the process is throwing an error.  Also, you probably want the filter logic to use an "and" not an "or" if you want to exclude episodes from the specific scene.
I am currently investigating the reason for the distance undefined error you observe in that scene and will let you know when that is resolved.

Thank you, @msavva
I was not neat enough.
Similar issue comes from scene number "0c818d79073de53af1b620d950f0ad75"

@kvas7andy the commits to master should help to resolve this issue.  Please follow the installation steps to rebuild the server module, and let us know if you still observe any crashes.

@kvas7andy did you get a chance to check whether the current master code resolves the issue on your end?

@msavva
No similar error came up till now, thank you!


add wsSquid token to wallet button

Address #6
There was also a strange grey border around the buttons that looked a bit weird, imo (esp since wsSquid button was slighlty longer than the other 2 buttons). Set background color of the buttons to transparent to solve that.

@squiddaodev made your changes


DNS features needed for Oh-My-Vagrant

Hey there,
I think I let this patch stay idle for a while, and it's now back in my more pressing issues TODO list.
It started in: https://github.com/smdahlen/vagrant-hostmanager/pull/109 and https://github.com/smdahlen/vagrant-hostmanager/pull/111
It's now been updated to be rebased against current git master.
Please have a look and hopefully merge.
It works with the oh-my-vagrant branch: https://github.com/purpleidea/oh-my-vagrant/tree/feat/hostmanager
If you don't like this patch as is, or if there is something that you think should be done differently, if you could propose/merge those changes so I can use them in oh-my-vagrant, that would be great.
Thanks,
James

Hi there, I really would like to see this merge as it blocks some of the Atomic Host stuff we are doing. Thx :)


Warnings when Stroom initialising MySQL 8.0 database

When Stroom attempts to initialise a MySQL 8.0 database instance the following warnings appear
WARN   [2020-02-23T12:17:02.888Z] [main] org.flywaydb.core.internal.dbsupport.JdbcTemplate -  DB: 'utf8' is currently an alias for the character set UTF8MB3, but will be an alias for UTF8MB4 in a future release. Please consider using UTF8MB4 in order to be unambiguous. (SQL State: HY000 - Error Code: 3719)

WARN   [2020-02-23T12:19:08.264Z] [main] org.flywaydb.core.internal.dbsupport.JdbcTemplate -  DB: Integer display width is deprecated and will be removed in a future release. (SQL State: HY000 - Error Code: 1681)

Fixed by gh-2094 and gh-2096


Enhancement: Option to force a resync from launch page/terminal

Hello,
Maybe this isn't something that would be required in mainnet, but in the case of ending up on the wrong chain, it would be good to be able to force a resync from the launch page and/or via terminal command, effectively doing whatever happens when the phone is rebooted and a synchronisation to the latest block occurs.
If this is just testnet issues then feel free to ignore!
Thanks
Jazmin

Absolutely.
This is in the road map.
It should only require a seed phrase and an archive node.. for a full
resync from genesis..
OR.. if you have moved your coins in last 3 months should be possible from
any user to any user.
:)
On Mon, 2 Aug 2021, 21:45 Jazmin, @.***> wrote:

Hello,
Maybe this isn't something that would be required in mainnet, but in the
case of ending up on the wrong chain, it would be good to be able to force
a resync from the launch page and/or via terminal command, effectively
doing whatever happens when the phone is rebooted and a synchronisation to
the latest block occurs.
If this is just testnet issues then feel free to ignore!
Thanks
Jazmin
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/minima-global/Minima/issues/357, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEIYNUQIT7S6Y2HPRX3IX5TT237VXANCNFSM5BNPCIUA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

Good to know, thank you!
Interested to learn how the archive nodes will work and who will run them, maybe a question for the next Dev call? :)


updates

These updates include:

updating census10 to automatically pull the complementary columns that census20 does
updating the grouper function to work with pop splits
re-incorporating hierarchical block dissolve
adding a plotting tutorial
updating the scoring tutorial for compactness
adding compactness scores
fixing some plotting bugs relating to defining colors for proposed plans

Other random action items:

Bump version/go through release process once this is merged.
Close all PRs this one is derived from with a comment pointing to this PR.


Auto generate

Is there an accepted autogenerator for .tern-project files from package.json, or maybe a yarn lock file?

I'm not aware of such a tool

@marijnh thanks, would you be alright with the command line tern providing that functionality ?

What kind of information would you get from package.json that'd help configure .tern-project?

@marijnh Well tern doesn't work as well unless I explicitly give some paths to loadEagerly,
 "loadEagerly":[
    "node_modules/react/dist/react.js",

and so on.
I can just generate that from package.json instead of having to hand write it each time.

If you use a module system, that shouldn't be necessary -- in fact, I'm not sure how it could help at all, unless you're getting bindings from the global scope.

This is consistently true on the node side, I get better code completion and type info when I explicitly give the path to the index.js of a project.

Can you provide a minimal example of a project where this is true, and define 'better code completion' more precisely?

Yes sorry, I will whip something up.

Open that tool

@marijnh
ReactNative example.

reactnative  init someproject
yarn
do: import { App } from 'react-native';

Without a .tern-project file containing the loadEagerly to react-native's node_module, I get no code completion. When I add the respective path, then I get code completion of App{State, Registry}

The react-native module does not appear to export a binding App, going by this file, which is the main module of the library.

This was just one example, it still the case that giving a full path help code completion

I've never used react native, and if you can't give me an actually correct example I won't be able to look at this.

It had nothing to do with react native besides being an example.
I can give other examples as well.

@marijnh Ping.
Here is an example repo that shows what I'm talking about.
https://github.com/fxfactorial/animations
Only two commits, first one without .tern-project file and one with it. In the first commit, I get this auto completion
(207309504912481b4e4e1728d072dfb71a63f795)

But in the second commit, where I help out tern with the tern-project file paths hard coded, then I get much better code completion
(2c612e77168a41e87a2583003881337c074fdb28)

@marijnh Ping: I realize you're busy, just letting you know I made the example project as you requested.


feat(images): accept url or base64 data

Hi @wyozi ,
I know you want a more centralized solution for both background and image components. I'm using the contract of data that would be passed to the html src tag data:<content type>;base64,<data>. How's this approach for you? How would you like to see this implemented for approval?
I tested it locally via preview and test generated ppt. Works well so far.
Generated PPT
Test image crated with small data file

Render
Preview code and replaced image

Error when no url or data
How would you like to handle this? Only one prop from the image component? url with some base64 regex?

Yeah, I'm not sure about using separate props for data and url. Is there ever a case where both would need to be specified (which would be the biggest reason to have the two imo)?
The idea of clearly separating between urls and data is solid, but even then it could even be done with a single prop e.g. <Image src={{kind: "data", data: "..."}}>. Now that specific example syntax is quite ugly, but it has some nice properties like only one prop name you need to remember, very clear error messages, and reasonable fallback to just passing in a string for a URL.

url with some base64 regex?
This could be it. It's not the nicest or the most efficient solution, but there is (even if questionable) prior art in how HTML <img> works and it keeps the api reasonable slim.

Agree. One prop makes sense, and I like the src tag approach you highlighted vs. using regex.
Would you like to keep url? in place for the time being vs. introducing a breaking change with a deprecated console message? Or get the breaking change in now?

@mckdanoventa I think with library of this size early breaking changes are okay and good to keep the code clean especially if they're this easily fixable.
I'm wondering if the src prop should still accept a plain string as the URL? I think url would still make sense as the default case, although having two types of input props could cause some confusion.

Hi @wyozi. I updated it to only support the src prop. I agree, I think having both supported might get a bit confusing, and would only use it as a stop gap. That being said, if you wanted to support both, we could implement a fall back to regex image vs. http prefix. and have string or type.
I've updated the preview and test examples. Slide Background and Images are now supporting the data or path workflows.

Cool. Thanks for the PR!


I cant install container

I have this error on bulid image from tar of your code
Step 1/6 : FROM node:12-alpine
---> 37b988e559b7
Step 2/6 : WORKDIR /usr/src/app
---> Running in 657c31f788a2
Removing intermediate container 657c31f788a2
---> 6c7eddfcf3de
Step 3/6 : COPY package*.json ./
---> bbe77da595cc
Step 4/6 : RUN npm install --only=prod
---> Running in 171ded4724d6

Fatal error in , line 0
unreachable code

#FailureMessage Object: 0x7edde31c
The command '/bin/sh -c npm install --only=prod' returned a non-zero code: 132

Hmm, what exactly are you trying to do?
If you install it with the provided docker-compose.yaml it should take the docker image I provided. So, no need to create your own docker image.


MINOR: fix warn logging in RecordCollectorImpl

Fix warn log message in RecordCollectorImpl so it prints the exception message rather than {}
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@mjsax, @guozhangwang, @bbejeck

Thanks @dguy LGTM.
But I do have one meta question - do we want to change the format of the logging on line 110 to include the stack trace? \cc @guozhangwang @mjsax

thanks for clarifying @mjsax

retest this please

LGTM. Merged to trunk.


Link not working "Quickstart: Enable users and create a SQL endpoint"

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1095c135-0915-f6c8-8032-4d04354fd40a
Version Independent ID: fe24dd29-de3f-a0de-26cf-2d7f0d4ad637
Content: What is Azure Databricks SQL Analytics?
Content Source: databricks/scenarios/what-is-azure-databricks-sqla.md
Service: azure-databricks
Sub-service: databricks-sql-analytics
GitHub Login: @mamccrea
Microsoft Alias: mamccrea

@bozgul Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.
@mamccrea Could you please review the document and update appropriately?

These links are fixed.
#please-close


Feature/Wasoko Adding information on founders

Fixes #127
Researched the company and saw that it is still active.
Corrected the founders according to Crunchbase information.

Thanks!


Resolve: Bug: rules() "required" is generated before "*_default" #22

Fixes https://github.com/php-openapi/yii2-openapi/issues/22

Although it seems to fix #22, putting required at the end does not sound good to me. Require check should be applied before any more specific validation.
Default and require are in conflict, so I'm not sure how to handle it correctly.


Permissions are not checked for curse toggling

Was this fixed by @lizelive already or were those some other permissions?

If this wasn't fixed before, it should be fixed by some changes in idofront a little back


Preserve causes of custom AssertionError

While adding the support for custom AssertionError types, used in
testing libraries, the cause chain of such errors was lost.
This commit makes sure that the cause is preserved.

@bot-gradle test RFM

OK, I've already triggered ReadyForMerge build for you.


apptainer, singularity: precede system-level bin paths in defaultPath and fix singularity image running

Description of changes
apptainer and singularity now prioritize PATH from the system over those constructed from dependent packages, when it comes to the substitution of defaultPath values (the PATH hard-coded inside Apptainer/Singularity library for them to find third-party utilities). It is now constructed by the following sources, ordered by their precedence:

systemBinPaths, a new argument introduced to specify the /**/bin paths from the system, especially those with their SUID bit set.
The original defaultPath value, making it work out of the box in FHS systems.
defaultPathInputs, a list of packages to form the fall-back PATH.

This change is required to enable Sylabs SingularityCE (singularity) to run images, as it requires a fusermount3 commant with SUID bit set.
The arguments newuidmapPath and newgidmapPath is deprecated in favour of systemBinPaths. Their support will be removed in future releases.
New option programs.singularity.systemBinPaths is introduced to specify the systemBinPaths argument of the overridden package. It includes "/run/wrappers/bin" even if specified empty.
The option programs.singularity.enableFakeroot is deprecated and has no effect. --fakeroot support is now always enabled as long as programs.singularity.systemBinPaths is not forcefully overridden.
This PR depends on #306656 and #306716, and currently contains their commits. The size of this PR will reduce once the dependent PRs are merged.
Together with #306716, this PR fixes #295809 and prevents the broken singularity from going into the stable release. If this fails to merge before the branch-off, I would like to have the changes backported without the deprecation warnings.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[X] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[X] (Package updates) Added a release notes entry if the change is major or breaking
[X] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I rebased this PR on top of master, and both apptainer and singularity seems working well.
I don't know how to test those GPG-related functionality. @SomeoneSerge @FynnFreyer, could you help test if the GPU works with these changes applied?
BTW, should we rename pkgs.{apptainer,singularity}-overriden-nixos to pkgs.{apptainer,singularity}-overridden-nixos in this PR? The renaming should not break any workflow we maintain, and we have explicitly stated that the two variant packages are for binary caching only.

@SomeoneSerge, could you help look at this PR? This will fix the issues regarding third-party utility access for Apptainer and SingularityCE.

I am terribly, terribly sorry about losing touch on this one. I remember I had tried building the gpu tests just via the flake reference and I couldn't because the cuda image blew up in size. I'll give it another try

Ok, with https://github.com/NixOS/nixpkgs/pull/323056 in I can finally run the test without modifying the diskSize arguments:
❯ (nix build --impure .#apptainer.gpuChecks.image-saxpy --print-out-paths ; echo saxpy) | xargs apptainer exec --nv
trace: warning: cudaPackages.autoAddDriverRunpath is deprecated, use pkgs.autoAddDriverRunpath instead
warning: 'http://nixpkgs-cuda.cs-338.someonex.net:38180/nixpkgs-cuda' does not appear to be a binary cache
INFO:    gocryptfs not found, will not be able to use gocryptfs
WARNING: passwd file doesn't exist in container, not updating
WARNING: group file doesn't exist in container, not updating
Start
Runtime version: 12020
Driver version: 12050
Host memory initialized, copying to the device
Scheduled a cudaMemcpy, calling the kernel
Scheduled a kernel call
Max error: 0.000000

I think this is backport-able, but I'll look into this some more

Thank you again @ShamrockLee

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

#306716 needs to be backported first so that we could backport this one.


Refactor code

Is your feature request related to a problem? Please describe.
Some parts of the code are ugly and should be refactored for readability.

This can also include a global variable list. Now, we have some numbers which are kind of vague and can be replaced by global constants

This should also include a more logical directory structure (especially on the backend side of things).


Single characters in math mode text operator

Description
The text operator in math mode only works for strings with a minimum length of two:
$ op("m")^3 $
does not work, but
$ op("cm")^3 $
does. If this is intended, it should be documented I think.
Reproduction URL
No response
Operating system
Web app
Typst version

[X] I am using the latest version of Typst

op(upright("m")) should work. This is due to math not actually distinguishing between m and "m", see also #1125

I just had the same issue and we had a discussion on the Discord. I think this behavior should be changed. (Also see the Discord post in#support for suggestions.)

Duplicate of https://github.com/typst/typst/issues/274
That being said, the post is misleading. math.op is doing what it's supposed to do. What you're presumably looking for is upright.


vanilla 14.04 bootstrap triggers dconf errors

During the post-install script, seven of the following errors were displayed (three for each of two PIDs, one for a third PID):
(process:<%PID%>): dconf-CRITICAL **: unable to create file '/home/user/.cache/dconf/user': Permission denied. dconf will not work properly.
No other package management utilities running at the time.

Doing a 14.04 install later today, will chase down and should have something back shortly.
Thanks and regards,
Barry

On 9 Feb 2015, at 1:21 pm, Erik Kristensen<EMAIL_ADDRESS>wrote:
During the post-install script, seven of the following errors were displayed (three for each of two PIDs, one for a third PID):
(process:<%PID%>): dconf-CRITICAL **: unable to create file '/home/user/.cache/dconf/user': Permission denied. dconf will not work properly.
No other package management utilities running at the time.
—
Reply to this email directly or view it on GitHub https://github.com/sans-dfir/sift/issues/48.

Can confirm that these errors are false as the file already exists. Can strace the process to get to the source of the issue or we can accept them as false alarms.
Cheers,
Barry

On 9 Feb 2015, at 1:21 pm, Erik Kristensen<EMAIL_ADDRESS>wrote:
During the post-install script, seven of the following errors were displayed (three for each of two PIDs, one for a third PID):
(process:<%PID%>): dconf-CRITICAL **: unable to create file '/home/user/.cache/dconf/user': Permission denied. dconf will not work properly.
No other package management utilities running at the time.
—
Reply to this email directly or view it on GitHub https://github.com/sans-dfir/sift/issues/48.

bump. Did you get anywhere with troubleshooting? I can't reliably reproduce.

I have some time this afternoon - I'll have a look then with strace; as I said above it's fairly clear they're false positives as the command is blindly trying to create a file that already exists.

The latest bootstrap script suppresses these messages. I have not been able to determine yet why they occur. The changes still take place even when the errors show up.


fix: update next-intl framework config

This fixes the regex in getScopeRange function for the Next-intl framework.
One of the function names was incorrect.

Sorry, wrong repo :)


[Request] AppSettingsDialog callbacks

Basic Information
Device type: Samsung Galaxy S8
OS version: Oreo 8.0
EasyPermissions version: 1.3.0
Describe the problem
It would be nice to have callbacks for the AppSettingsDialog actions similar to the ones that are already in place for the rationale dialog.
Use case: One of my tabs requires a permission before it can load any content. In the event that the user permanently denies the permission, a "click to fix" Snackbar is displayed that re-checks permissions. If the user cancels out of the resulting AppSettingsDialog, however, the Snackbar has been dismissed and the user now has no way of triggering the permission check. With the callback, I could re-display the Snackbar.

You can simply check to see if you have the permissions in onActivityResult

@SUPERCILEX 's suggestion is correct, so going to close this issue.  Hope that makes sense @heath3n


feat(#170): Add cypress tests

I only tested index.html and the core documentation, but it'll at least check that the website comes up.
Fixes #170

Thanks for your help @Ginsusamurai ! These commits landed in https://github.com/doug-wade/tybalt/pull/521


[FIX][SC-40685]  fix inescapable tabbing on month

Fix the tab loop when the calendar is open
and some chores:

factorize test utils
remove logs in tests

(Internal) Associated ticket: sc-40685
Associated issue: https://github.com/Hacker0x01/react-datepicker/issues/3930

PR opened on the main repo => https://github.com/Hacker0x01/react-datepicker/pull/4049


docs: fix import as

In the documentation, some imports were given with the following syntax:
import { x: y } from z
instead of:
import { x as y } from z
This commit uses "as".
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.888%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1408

Relevant Lines:
1432

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.888%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1408

Relevant Lines:
1432

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.888%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1408

Relevant Lines:
1432

💛  - Coveralls


TNB MMO - Week - 1

📝 Weekly Report For TNB Projects
Basic Details

🧪 Name of the Project: TNB MMO
📅 Report Date: [02-19-2021]
📜 Team Work Report

✅ Accomplishments this week

Worked on more details of the story
Actively recruiting more people to our project
Talked about design concepts

🚩 Goals for next week

Complete all designs
Move on to the extension redesign

👨💻👩💻 Team Members Contribution Details

mrbusysky:

Actively coordinated with all teammates
Hired a part-time writer to start working on the back story https://docs.google.com/document/d/10yaARWHvucewxcEIpls-4pi1Ak-uaNnWI7Ij3FfINxQ/edit?usp=sharing
Chatted with the main team's organizer on the recruitment path.

zinoadidi:

Posted recruitment details https://i.gyazo.com/f3193c91f3f79bf57b74896ebd5490af.png
Made posts to and joined new Facebook groups while scouting for new team members
Coordinate portfolio and cv submission by prospects
Engaged existing prospective hire's in discussions to further understand their offering as well as see if they can refer their friends.
Worked with the team lead to establish / defined timeline on the first stage of the hiring process

gushinmikhailgushinmikhail:

Shared some styles of environment designs: https://media.discordapp.net/attachments/808300225117945877/812374019164471356/3.png
Gone over the story to decide what concept art should be made.

keyframeguy:
Actively researching: movement of mmo's for character, monsters, and more. Not much detail can be said about this because this involves playing games, watching videos and so on which were not capable of tracking.
dashapvlv:

Has been helping generate ideas for the main storyline: https://i.gyazo.com/dd717b295fbddde850de32e1b4501b96.png
The discord is open to the public there is way to much to post so it's as easy as going through the discord channel to see. People like chuy are in the discord channel so he should be able to relay if this is true or not of her activeness.

approved by me

approved by me


Propagate build errors up to the integration

If a build fail, the related kit will be marked as failing (after a number of attempt to recovery from the error) but the integration that has triggered the creation of the kit and the build, will stuck in "building kit" phase

I was going to take a look into this but seems it was already taken care of in https://github.com/apache/camel-k/commit/d7086fdbc8ca240a2cd39751c08b322df567cd68. See here.
I tested and it works as expected.

So I've fixed it by chance :)


segfault with python binaries

Hi There,
I have a weird error in pyreadr that I hope you can help me to solve:
Until librdata commit ba28c3ba1bb224901b873ce477282f61a51c567e on Aug 26 everything was fine. But starting on the next commit 27b1e13e0178275b6995dbbb41959ff0cdd2a68e on Sept 11, altough on my dev machine everything was fine, travis jobs were failing with compilation errors in rdata_read.c about I should compile with the std=c99 flag. See below for the errors. These errors appear on travis for linux only and not for Mac, and windows on appveyour is fine too. I maintained the pyreadr code the same between librdata changes for testing, so I can tell the problem is coming from librdata.
I corrected the errors by introducing the flag -std=c99 for travis only (since on my machine that would make it to fail) and apparently everything was fine, travis compiles and runs the tests succesfully. However just now it was reported here and I can confirm that the python wheels (binaries) produced by the travis job seg fault when trying to read any R file in any other machine.
Any suggestion?
Thanks in advance!
Here the last succesful build with commit from Aug 26
https://travis-ci.com/github/ofajardo/pyreadr_wheels2/jobs/439123757
Here the failing build with commit from Sept 11
https://travis-ci.com/github/ofajardo/pyreadr_wheels2/jobs/439126418
Here the relevant errors:
pyreadr/libs/librdata/src/rdata_read.c: In function ‘read_st_z’:
  pyreadr/libs/librdata/src/rdata_read.c:267:27: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
           if (bytes_written == len)
                             ^
  pyreadr/libs/librdata/src/rdata_read.c: In function ‘lseek_st’:
  pyreadr/libs/librdata/src/rdata_read.c:381:43: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
           } else if (read_st(ctx, buf, len) != len) {
                                             ^
  pyreadr/libs/librdata/src/rdata_read.c: In function ‘rdata_parse’:
  pyreadr/libs/librdata/src/rdata_read.c:693:46: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
       if (is_rdata && v2_header.format_version != header_line[3] - '0') {
                                                ^
  pyreadr/libs/librdata/src/rdata_read.c: In function ‘read_character_string’:
  pyreadr/libs/librdata/src/rdata_read.c:949:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
       if (length == -1 || length == 0) {
                  ^
  pyreadr/libs/librdata/src/rdata_read.c: In function ‘read_compact_intseq’:
  pyreadr/libs/librdata/src/rdata_read.c:1110:9: error: ‘for’ loop initial declarations are only allowed in C99 mode
           for (int i=0; i<vals[0]; i++) {
           ^
  pyreadr/libs/librdata/src/rdata_read.c:1110:9: note: use option -std=c99 or -std=gnu99 to compile your code
  pyreadr/libs/librdata/src/rdata_read.c: In function ‘read_string_vector_n’:
  pyreadr/libs/librdata/src/rdata_read.c:1267:31: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
           if (string_length + 1 > buffer_size) {
                                 ^
  pyreadr/libs/librdata/src/rdata_read.c:1290:41: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
                   if (4*string_length + 1 > utf8_buffer_size) {
                                           ^
  pyreadr/libs/librdata/src/rdata_read.c: In function ‘read_value_vector’:
  pyreadr/libs/librdata/src/rdata_read.c:1376:37: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
       if (read_st(ctx, vals, buf_len) != buf_len) {
                                       ^
  pyreadr/libs/librdata/src/rdata_read.c:1384:24: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
               for (i=0; i<buf_len/sizeof(double); i++) {
                          ^
  pyreadr/libs/librdata/src/rdata_read.c:1389:24: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
               for (i=0; i<buf_len/sizeof(uint32_t); i++) {
                          ^
  pyreadr/libs/librdata/src/rdata_read.c: In function ‘recursive_discard’:
  pyreadr/libs/librdata/src/rdata_read.c:1554:24: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
               for (i=0; i<length; i++) {
                          ^
  error: command 'gcc' failed with exit status 1

OK using std=gnu99 solves the issue. Do you think that's good for my project? (at least on linux). gnu11 is good as well as seem to be the default these days, maybe that's better?
I don't understand why the compiler was not complaining before tough.
I also don't understand why if the default these days is std=gnu11 it needs that flag, although it may be that the toolchain I am using is using centos somehow and that has gcc 4.8 which still is in std=90 or 89 I think.

Hi, I think we can enforce C99 in configure.ac:
https://stackoverflow.com/questions/11647208/where-to-add-a-cflag-such-as-std-gnu99-into-an-autotools-project

(Unless you are copying sources and compiling without the autoconf toolchain)

yes, I am copying sources right now as it is the cannonical way to build python extensions.
It's fine, the people from the python toolchain I am using clarified me they are using centos which has an old gcc, that's why. The difference between c99 and gnu99 should not be, they suggested me to file an issue about that.
So, all good now, thanks!


Permission required for Android 8

On Android 8 Oreo (API 26) the downloaded apk file is not installed automatically, you should add required permission of install APK files, so add this permission into the manifest file to run on Android 8 properly:
"android.permission.REQUEST_INSTALL_PACKAGES"

Thanks for your issue. Please see the latest version of the library.  Now automatically install will work in Android Oreo.