Reverse engineering outgoing messages. How to breakpoint the AES or Sha256?

I'm trying to understand outgoing messages from WhatsApp Web. I caught all the interactions and some things are obvious (the 0x80 || 128 before the binary data starts etc). I was now thinking about reversing the encryption order so I can see what the dictionary (that gets proto'd and encrypted) looks like.
Now my problem: after the AESEncryption, it Sha256's the message. As hashing can't really be reverted back to data, I don't know what do to now.
Where can I set breakpoints in order to catch what gets sent to the Sha256 in the original WhatsApp Web page's JS code? Or where can I set breakpoints to see what outgoing messages look like before they get proto'd or before they get hashed and encrypted?

Turns out I found the correct functions for the binary conversion, it's just the Chrome Console that works badly and sometimes skips breakpoints, please ignore this issue, got it working.

@chatterbro
Dear I am using chrome and I want to understand what is the
https://i.vgy.me/IKMKxx.png
Binary message , is there a tool which helps to decode these messages?


Discussion: Preferred code styles

I'd like to gather opinions from the team regarding preferred code styles for certain situations:
1. return statements
Currently, we have three types of return styles in our codebase:

return: Implicitly returns None.
return None: Explicitly returns None.
No return statement: Implicitly returns None.

I would propose adopting the last style consistently (not having return statement) .
2. Unpacking
Currently, we often perform unpacking operations like this:
coord = [1, 2]

x = coord[0] # x=1
y = coord[1] # y=2

I suggest changing the code style to the following for conciseness and flexibility:
coord = [1, 2]

x, y = coord # x=1, y=2

This change makes the code more concise and allows for unpacking any data type that can be unpacked, such as an iterator:
coord = (i for i in range(1, 3))

x, y = coord # x=1, y=2

3. isinstance usage
In some places in the codebase, direct type comparisons like if type(x) == list are used. I propose changing these to if isinstance(x, list) for improved flexibility and robustness.
4. Avoiding indexing assumptions
While indexing is convenient, it's advantageous to avoid reliance on it when possible. For instance, rather than accessing the first element of a data structure with x[0], we can use next(iter(x)) if x is iterable (typically it is). This approach enhances code versatility and adaptability to diverse data structures.
While there's no definitive right or wrong when it comes to code style, consistency within our codebase is highly beneficial. If we can reach a consensus on the preferred code style, I'm more than willing to submit a PR reflecting our decision.

Hey, thanks for taking the time to carefully write out the challenges and helpful suggestions! I think everything you've said for 1-3 is spot on, and would be uncontroversial and useful to refactor to use! (I'm surprised 3 is not picked up by the linter 😓 ).
RE 4, I know that codebases juggle a bit between functions that operate on lists/sequences of things, verses a single thing. I have less strong opinions about how a first element is grabbed. There might be worthwhile cases to clean up though, like when...

a function expects a list of elements, but then
everything that uses it wraps a single element in a list, then
pulls the first element out of the result.


Add poetry support

I believe poetry is nowadays python dependency resolution practice.
It would be great to add poetry support.

I've been working on supporting Poetry now, but have not yet properly tested everything yet.
Feel free to look over the pull request, or try it out if you have the time.
I haven't used Poetry myself yet, and have only written this based on the documentation available, so I'll give it some more test runs before I push out a new version with this.

I'm working on PullRequest. But it my first acquaintance with vscode and it's extensions (especially debuting extensions)


Graphql shield applied to one part of the schema

Question about GraphQL Shield
Brief summary, our schema is separated into 2 different types, autogenerated simple crud resolvers and custom resolvers.
We are using Graphql shield to create authorization as a default set of rules a for all the the autogenerated part of the schema.
But thats causing issue since those rules get applied to our entire schema and we have to exclude all custom resolvers manually inside the file.
Would it be possible to apply graphql shield to only one part of our schema file

+1 if this feature is added.


jstree._append_json_data() callback always asynchronous, even when no worker is used

This PR is a fix for #2258 issue, according to my tests on Google Chrome.
It basically uses Promise in all major browsers and setImmediate where available, to make jstree._append_json_data() always async.

This has the added benefit of making UI more responsive while processing a lot of nodes, and possibly a better option than using a worker.

I propose to use setImmediate(cb) instead of setTimeout(cb, 0) in places where wait time is not desired.
Currently setTimeout(cb, 0) deafults to 4ms wait after 5th nested call.

Thank you for this PR - looks great and seems fully backward compatible. It really is a nice alternative to the worker (which has its own problems). I do have one question though - how much slower is the new version on average? Freeing the UI thread is great, and I do prefer the async approach in all my projects, but there are some use cases, where devs prefer to block the UI, but deliver the tree faster. I need that information before I merge - if you have not tested - I will test it myself and merge.

I did not do an extensive test.
I've just tested in the context of my app and measured the overall time of a search, since start till search callback invoked.
On my dataset, with ~1400 nodes to open and ~4000 nodes to load, it takes ~4 sec with or without this PR. With worker enabled it is ~2 min.
The UI isn't smooth but isn't completely blocked either during the 4 sec.
I also use setImmediate polyfill.
With setImmediate/Promise, the delay between invocation and execution is one cycle, which is in the range of nano- or microseconds (not 100% sure), when there are no other tasks on the queue (like UI, I/O, GC), and with this PR there are few invocations to setImmediate (~1400 in my case I guess), which would not add up to even some 10ms.
So, this doesn't free the UI thread much but at least solves the Maximum call stack size exceeded error completely and gives the UI and other tasks some chance of execution.
Maybe using this technique in other places where there is a synchronous callback invocation in a chain would improve the responsiveness of the UI even more.
If I were to use setTiemout(cb, 0), I suppose it would take considerably more time, because of the 4ms delay, but would also make the UI much more responsive. I've used this technique in one of my projects successfully.
So, basically, this PR is a solution to #2258 and a proof of concept on which we could extend and improve the jsTree further, I hope.

That is great - thank you for the information. We should probably adopt this approach for v.4 as well.


Is this in NPM?

If it is, I cannot find it, and am being quite silly.

Hi @DSchau,
You're right, sorry, I just published it (and updated the readme): https://www.npmjs.com/package/angular-hot-reloader. It works well with our actual config but has not been tested outside. Please tell us if you have any issues with it

Thanks, I'll be sure to give it a look and let you know if I run into any issues!


[Event Request] Codeunit 231 Gen. Jnl.-Post - OnAfterPostBatch

Hi Team,
In codeunit 231 we need possibility to replace and avoid using standard code with our own. Having event in the procedure Code on after GenJnlPostBatch.Run, would be a perfect solution :

[IntegrationEvent(false, false)]
local procedure OnAfterPostBatch(var GenJnlLine: Record "Gen. Journal Line")

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


chore: mod path of image pull secret

Move the image pull secret to be under image, not base.
Description

Move the image pull secret to be under image, not base.
This is the more logical location.
Motivation and Context

Regression
No

How Has This Been Tested?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added unit tests to cover my changes.

bors try

bors try

Re-requested reviews because of a change in the logic of the pull-secrets helper function.

One further change - use default secret name of "login" if the legacy method is used to enable the secret and the name is not specified.

bors merge


Add additional areas for single page view.

Added a custom view for OAuth login pages...

Added a custom view for OAuth login pages...


Adding exist_ok=True in RAVEN parser to aviod FileExistsError

Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
In RAVEN run RAVEN, it might have file exist error in method os.makedirs(slaveDir), closes #1070
What are the significant changes in functionality due to this change request?
Adding exist_ok=True inside os.makedirs() to aviod FileExistsError

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[x] 1. Review all computer code.
[x] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[x] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[x] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[ ] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True.
[x] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[ ] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[x] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
[x] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@PaulTalbot-INL ready for review.

This isn't limited to the HPC; it can randomly happen in parallel anywhere. It is definitely more common on the HPC.
@alfoa, I can't think a way to test this; the line is covered in existing tests, but I don't think we have a way to force a folder to get created between checking if it's there and making it. Is covering the line sufficient for testing?

@JiaZhou-PU Did you talk to @PaulTalbot-INL ?

Yes, I was wrong, it's not a parallel problem, it's a relative pathing problem.
For example, if I have the following structure:
  root/
      outer.xml
      inner.xml
      working_outer/
            step_name/
                  1/
                      inner.xml
                      working_inner/

and if I need the pickled ROM arma.pk in the inner, in the inner.xml inside root/ I specify the path to the file as ../../arma.pk, then when the OUTER tries to copy root/working_inner/../../arma.pk to root/working_outer/step_name/1/working_inner/../../arma.pk, of course this ends up being root/working_outer/step_name/arma.pk which the the same for each run. For every inner, the outer will try to rewrite this file.
This coincides with the problem that, really, arma.pk doesn't need to be copied at all, it can be referenced from a single location.

Okay. So As I imagined, this PR does not fix anything. Right? we can close this and remove the issue.

Well, it does fix the RAVENparser error, but not in the way we want to long term, as you suggest. Agreed.

It looks like the root issue has been reported before: https://github.com/idaholab/raven/issues/753 but in older libraries the "copy" didn't error if the file already exists.

Check tests.

Ready for review @alfoa

Checklist passed.
Merging approved.


Replace 'parseCueTime' with 'parseTimeStamp'

Hi, I found that there is no "parseCueTime" in Video.dev.js(4.12.9) which is the stable version now. So I changed the "parseTimeStamp" function of Video.js and replaced "videojs.TextTrack.prototype.parseCueTime" with it. Maybe this will be better :)

In commit "410cc7d", I added 300ms delay for "keyup" events and reset the slider when control panels' value are both correct.


PKG ERR! when extending eslint configs

I have the following .eslintrc in one of my projects:
{
  "extends": "touchlay",
  "env": {
    "node": true
  }
}

Additionally, I have eslint-config-touchlay installed and in package.json:
{
  ...
  "devDependencies": {
    ...
    "eslint-config-touchlay": "^0.2.2",
    ...
  }
}

eslint-config-touchlay has the plugins and other dependencies in its package.json, so they get installed correctly and linting works fine, however, running npm-check does not:
eslint-plugin-react              😟  PKG ERR!  Not in the package.json. Found in: /.eslintrc

eslint-config-standard           😟  PKG ERR!  Not in the package.json. Found in: /.eslintrc

eslint-config-plugin:import      😟  MISSING!  Not installed.
                                 😟  PKG ERR!  Not in the package.json. Found in: /.eslintrc
                                 ⛔  NPM ERR!  Registry error Package `eslint-config-plugin:import` doesn't exist

eslint-plugin-standard           😟  PKG ERR!  Not in the package.json. Found in: /.eslintrc

eslint-plugin-promise            😟  PKG ERR!  Not in the package.json. Found in: /.eslintrc

Use npm-check -u for interactive update.

It also seems to have a problem (NPM ERR!) with eslint-config-plugin, which uses the following syntax to load the plugin via extends: "plugin:import/errors", "plugin:import/warnings"

got this too:
eslint-config-plugin:react   😟  MISSING! Not installed.
                             😟  PKG ERR! Not in the package.json. Found in: /.eslintrc.json
                             ⛔  NPM ERR!  Registry error Package `eslint-config-plugin:react` doesn't exi

because my .eslintrc.json says:
{
  "extends": [
    "standard",
    "plugin:react/all"
  ]
}

@dylang

@dylang Do we have any progress here?

@LinusU

@StyleT I would recommend making a PR to this PR, which adds tests to this project

This is still an outstanding issue.
https://eslint.org/docs/user-guide/configuring#extending-configuration-files
	extends: [
		'plugin:node/recommended'
	],

eslint-config-plugin:react   😟  MISSING!  Not installed.
                             😟  PKG ERR!  Not in the package.json. Found in: /.eslintrc
                             ⛔  NPM ERR!  Registry error Package `eslint-config-plugin:react` doesn't exist

Any chance this will get fixed soon?

Any chance that this will be considered to be fixed or not?

Noticing this as well.....

Maintainer of depcheck here, surely the culprit for this issue.

Any chance that this will be considered to be fixed or not?

There is 100% chance it will be done if you open a PR yes.
I will take a look on my side and make a PR here to update the dependency

@rumpl was this ever fixed?


Add missing NavigationLock component to list of built-in-components

I noticed that the NavigationLock component is missing from the list of built-in components.
Additionally, I've added a subtitle to the Routing article to enhance clarity and enable cross-referencing.

Internal previews

📄 File
🔗 Preview link

aspnetcore/blazor/components/built-in-components.md
ASP.NET Core built-in Razor components

@guardrex I understand. I just feel it's a pity that NavigationLock in the routing.md page doesn't have its own heading, even though the text related to this component clearly has a specific beginning and is followed by a section describing its usage and behavior. Perhaps the Routing page deserves an overall reorganization of headings, but okay, I get it.


Sync the contract ABI

Codecov Report

Merging #448 (a34685b) into batching/main (826fbf0) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@                Coverage Diff                @@
##           batching/main     #448      +/-   ##
=================================================
- Coverage          49.18%   49.18%   -0.01%
=================================================
  Files                 36       36
  Lines               9005     9003       -2
=================================================
- Hits                4429     4428       -1
+ Misses              4576     4575       -1

Flag
Coverage Δ

test
49.18% <0.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/contracts/abi.rs
0.00% <0.00%> (ø)

tests/common/abi.rs
0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 826fbf0...a34685b. Read the comment docs.


first

@bls1999 @EternalUF you guys are slow

@famelegend1 no u, I saw this 3 days ago but there was nothing to post about


MAT-4516 return type validation for population definitions

MADiE PR
Jira Ticket: MAT-4516
(Optional) Related Tickets:
Summary
All Submissions

[x] This PR has the JIRA linked.
[x] Required tests are included.
[x] No extemporaneous files are included (i.e Complied files or testing results).
[x] This PR is merging into the correct branch.
[ ] All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
[ ] Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps
If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

[ ] This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).
[ ] All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo).

Reviewers
By Approving this PR you are attesting to the following:

Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
The tests appropriately test the new code, including edge cases.
If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

Seeing the error message live, I find it confusing. Which "Encounter" should I align with? Does that message live here or in the backend service?

@jkotanchik-SB It doesn't need to align with a specific encounter. Just return type should be of type Encounter resource. But yeah, that message doesn't make much sense(copied from the story).


Copy analyser to docker container

Pull Request
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

#96  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JackPlowman and the rest of your teammates on  Graphite

Merge activity

Sep 30, 3:07 PM EDT: @JackPlowman merged this pull request with Graphite.


Performance fix in JwtDefinitionSource

Removing the syncronized block as the ConcurrentHashMap is already synchronized and Thread safe which reduces performance

@alhudson Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@alhudson Thank you for signing the Contributor License Agreement!

Closing as this PR is stale and needs to be rebased on master (2.4.x). If this is still valid, please rebase and submit a new PR.


Payment create_password redirects to localhost

I have deployed saleor on heroku, i use Braintree as a payment method.
After a successful card payment i should get redirected to

http://<heroku_addres>/order/<order_code>/create-password/

insted of heroku_address i get redirected to localhost:

http://localhost:8000/order/<order_code>/create-password/

if i replace the localhost address with heroku address everything is fine.

@xtakacsx You have to set an appropriate site domain in the dashboard http://<heroku_addres>/dashboard/settings/

Thanks a lot!
I have changed the domain from localhost:8000 to heroku.com


update style

Motivation
Which issue does this fix? Fixes #issue number
If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?
Checklist

[ ] Code follows coding conventions held in this repo
[ ] Automated tests have been added
[ ] Tests are passing
[ ] Docs have been updated (if applicable)
[ ] Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test
If manual testing is required, what are the steps?

This appears to be just a slight color/style change with no justification.


Test with whois.arin.net

Test server: whois.arin.net

looks like it uses a different query syntax

this server will have to be tested for each query method to determine if will support it.


Added all conversions in stack

Pull Request for PyVerse 💡
Requesting to submit a pull request to the PyVerse repository.
Added all converions in stack
Issue Title
#513 completed

[x] I have provided the issue title.

Info about the Related Issue
What's the goal of the project?
To add the algos of
infix to postfix
infix to prefix
postfix to infix
prefix to infix
postfix to prefix
prefix to postfix

[ ] I have described the aim of the project.

Name
Please mention your name.
Mansi Sharma

[x] I have provided my name.

GitHub ID
Please mention your GitHub ID.
https://github.com/Mansi07sharma

[x] I have provided my GitHub ID.

Email ID
Please mention your email ID for further communication.
<EMAIL_ADDRESS>
[x] I have provided my email ID.

Identify Yourself
Mention in which program you are contributing (e.g., WoB, GSSOC, SSOC, SWOC).
GSSOC

[x] I have mentioned my participant role.

Closes
Enter the issue number that will be closed through this PR.
*Closes: #512

[x] I have provided the issue number.

Describe the Add-ons or Changes You've Made
Give a clear description of what you have added or modified.
I add the py files of converions

[x] I have described my changes.

Type of Change
Select the type of change:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Describe how your changes have been tested.
All are tested.

[x] I have described my testing process.

Checklist
Please confirm the following:

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly wherever it was hard to understand.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have added things that prove my fix is effective or that my feature works.
[ ] Any dependent changes have been merged and published in downstream modules.

@Mansi07sharma link your issue properly

@UTSAVS26 It's done , If this was not your mean then provide me in detail that what should I have to actually do?


Href '#' URL fragments do not work with abspath on

Webroot is set as abspath. After html is vulcanized, anchors with href referencing '#' url fragments do not work. Instead, anchor is pointing to http://localhost/path/to/html/#

What version of vulcanize are you using?

I'm using vulcanize 0.7.5 and grunt-vulcanize 0.6.1

Ah, that was fixed in 0.7.6 with https://github.com/Polymer/vulcanize/commit/115870286b49f3cedbe15e6ac384a100698f2f16. 0.7.10 is the latest for polymer 0.5 elements.

Yes that fixed the problem, thank you!


Remove if helptags

Because the doc contains an if tag, it conflicts with the if in the vim doc and causes an error.
The error in dein is as follows.
[dein] Error generating helptags:
[dein] Vim(helptags):E154: Duplicate tag "if" in file /Users/yuki-yano/.vim/bundle/.cache/init.vim/.dein/doc/indent_blankline.txt
[dein] function dein#recache_runtimepath[1]..dein#install#_recache_runtimepath[31]..<SNR>175_helptags, line 10

Thanks, but this has already been fixed in #463


vimPlugins.zellij-nav-nvim: init at 2024-01-29

Description of changes

Add zellij-nav.nvim Neovim plugin.
Package manually added to generated.nix by running vim-plugins-updater and picking out just this package.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 329264 run on x86_64-linux 1

2 packages built:

vimPlugins.zellij-nav-nvim
vimPluginsUpdater


/shrug commands need to be their own word/group

The regex for these commands currently fail our standards for our already-implemented tests. We need each command's string to only be triggered if the word itself is used in a message, otherwise it will accidentally be triggered by unrelated messages in the chat.
An example of a regex that passes all of the necessary test is our  /notes command .
Once you begin fixing the regex, you may ensure the regex passes all necessary requirements by running npm test commandName.test.js in the terminal. A passing output will look like this:

Once you have a passing regex, our pre-push hook will not allow you to push your commit because the other commands currently do not pass their respective tests. To circumvent our pre-push hook, please push your changes using git push --no-verify, then make your pull request.
ACCEPTANCE CRITERIA:

[ ] The fixed regex passes all regex-related tests
[ ] The snapshot tests all pass and are not made obsolete by the new regex

If this hasn't been worked on by any others, I'd be happy to work on this :)
Just quick heads up on me, are we looking for shrug to pass or shurg to pass???

If this hasn't been worked on by any others, I'd be happy to work on this :)
Just quick heads up on me, are we looking for shrug to pass or shurg to pass???


Adding missing event namespace in form validation

The namespace for e.g. the submit handler has been missed, which causes 'destroy' not to tear them down.
I'm on Meteor which reuses DOM elements all the time, so I have to destroy / reinitialise my dynamic form all the time. This bug caused submit handlers to stack up.

Thanks for the fix! Merged this into next.
Be sure to merge future PR to that branch


Feat feedback gui

Added The GUI Elements in Matches (Flow View, Grid View) that Open a Send Request Dialog -> to see the Feedback Buttons you need to click on your Post within a Match (Bottom of the element), this should open a Dialog to send a request. Be aware that there is no backend integration for this yet and these are only Interface Elements without any Functionality so far

@sbyim's update got pulled into devel so that matches & incoming requests now work. however automatic merging with this branch isn't possible thusly atm. Could you merge from devel once more? :)

@m0ru @sbyim i will merge devel into this branch first thing tomorrow and resolve the conflicts, also i try to write some (more) comments just to understand what i was trying to do


Create pkg_expand to allow for combination of archives

pkg_tar has a unique ability to absorb other tarballs in its deps attribute into its output.
This should be generalized into allowing any archive to be expanded into another.  As a start, this can simply support the extraction of tar and zip archives.  Others can be added later if needed.

Design note:

we don't want to have to unzip the entire package just to send it out to the remote executor to have the files read
thus, build_*.py must be able to actually do the expansion

Related: #265

Some other design notes:

We may not be able to identify the type of package based on its filename.  A new rule (e.g. pkg_import) could be created to emit a provider that could tell pkg_expand what type of package it is, or just have a tool detect it based on file type magic.
Incoming packages should be treated like TreeArtifacts, and handled similarly (#440), unless their contents can be provided as metadata to pkg_import somehow.
Would (or should) users be able to add additional package handling types without modifying rules_pkg?

We could start with pkg_expand only expanding things with PkgFilegroupInfo.
That would essentially just re-return the PkgFilegroupInfo and remove the srcs from the DefaultInfo.

My plan:
Phase 1:
pkg_expand(
   name = ...,
   srcs = [ tar or zip files ],
   preserve_owners = False,
   preserve_timestamps = False,
   exclude_paths = [path regexes],   # maybe glob syntax?
   include_paths = [path regexes],
   strip_prefix = 'string to strip',
   prefix = 'prefix to add',
)

new provider which holds all of the above.
weave that into manifest format
create python library which takes a input source and the reconstituted manifest entry to stream out files and content
modify build_*.py to call this new functionality as we find it

That will cover a few related bugs about preserving owners and mtimes in pkg_tar.
We can consider regex replacing paths in the future, but after 1.0 release.

@philsc    I think this is the kind of thing we were talking about at Bazelcon last week.
Perhaps we also had a more generic path rewrite capability in there too.

@AustinSchuh  I think this is the kind of thing we were talking about at Bazelcon last week.
Perhaps we also had a more generic path rewrite capability in there too.
Sorry @philsc, I had the wrong person.

Thanks @aiuto !  This looks like exactly what I'm running into.

Now it's just a small matter of programming. :-)


Update OrchardCore.Localization.Core to 1.5.0

@Rick-Anderson seems there's already a sample that target .NET 6, but the underlying package it not upgraded, please close #18559 once you merge
I might revise the other samples


when import 'react-easy-state',I can't print Chinese??? how?

when  import 'react-easy-state'，but don't  never use it ,  I can't print Chinese??? how?
"react": "^16.13.1",
"react-dom": "^16.13.1",
"react-easy-state": "^6.1.3",
Explame:
`import React, {
useEffect,
useState,
useContext,
useRef,
forwardRef,
useMemo,
// useContext
} from 'react';
import {view, store} from 'react-easy-state';
export const Main = () => {
const [val, setVal] = useState ('');
return (
<input
value={val}
onChange={({target}) => {
setVal (target.value);
}}
/>
);
};
ReactDOM.render(, document.getElementById('root'));`

sorry, react-easy-state is error  but @risingstack/react-easy-state ,this is ok.


Want to confirm whether the sriov-cni-plugin support bnx2x NIC card

Hi,
Now I use bnx2x NIC card to create sriov resource pool, but the POD could NOT use it and always report Non-valid Ethernet address:

So I want to confirm whether the plugin support bnx2x NIC card?
Thanks
Darcy

@darcyllingyan This card has not been tested to my knowledge, but I don't see why it wouldn't work with the cni plugin. The above is a driver error and it looks like there's some issue with the MAC address you're setting. Are you picking an explicit MAC address? Could you please fill out one of our issue templates so we have some basic info about your set up?

Hi @killianmuldoon ,
Thanks very much for the response.
I don't assign VF MAC address directly, suppose the DANM will create MAC address for VFs when the sriov-net is used for POD.
My resourceList is:
{
    "resourceList": [
        {
            "resourceName": "sriov_eno2",
            "selectors": {
                "pfNames": [
                    "eno2"
                ]
            }
        }
    ]
}

My allocatable is:
[root@~]# kubectl get node node-01  -o json | jq '.status.allocatable'
{
  "cpu": "31",
  "ephemeral-storage": "41153760Ki",
  "hugepages-1Gi": "0",
  "hugepages-2Mi": "0",
  "memory": "97663808Ki",
  "k8s.io/sriov_eno2": "4",
  "k8s.io/sriov_eno3": "0",
  "pods": "110"
}

The ip link is:
[root@ihhps-worker-02 ~]# ip link
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN mode DEFAULT group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
56066: eno1.100@eno1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP mode DEFAULT group default qlen 1000
    link/ether f0:92:1c:13:91:90 brd ff:ff:ff:ff:ff:ff
2: eno1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP mode DEFAULT group default qlen 1000
    link/ether f1:92:1c:15:90:90 brd ff:ff:ff:ff:ff:ff
3: eno2: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP mode DEFAULT group default qlen 1000
    link/ether f1:92:1c:15:90:91 brd ff:ff:ff:ff:ff:ff
    vf 0 MAC 00:00:00:00:00:00, tx rate 10000 (Mbps), max_tx_rate 10000Mbps, spoof checking on, link-state auto
    vf 1 MAC 00:00:00:00:00:00, tx rate 10000 (Mbps), max_tx_rate 10000Mbps, spoof checking on, link-state auto
    vf 2 MAC 00:00:00:00:00:00, tx rate 10000 (Mbps), max_tx_rate 10000Mbps, spoof checking on, link-state auto
    vf 3 MAC 00:00:00:00:00:00, tx rate 10000 (Mbps), max_tx_rate 10000Mbps, spoof checking on, link-state auto

Create one DanmNet to use:
apiVersion: danm.k8s.io/v1
kind: DanmNet
metadata:
  name: sriov-a
spec:
  NetworkID: sriov-a
  NetworkType: sriov
  Options:
    #Change this to the name of a valid SR-IOV Device Pool in your cluster
    device_pool: "k8s.io/sriov_eno2"
    cidr: xxx.xxx.xxx.xxx/16
    allocation_pool:
      start: xxx.xxx.xxx.xxx
      end: xxx.xxx.xxx.xxx

When I want to create POD with eth1 to use this sriov-a network, it report the above error.

@darcyllingyan at first glance this may have something to do with the all-zero mac address from your NIC. The error doesn't seem to be coming from SRIOV CNI though and this looks like a driver dependent issue. Can you try to explicitly set the MAC address to a known valid one?

Hi @killianmuldoon ,
Thanks very much, yes, it is the MAC address issue. After changed it to valid one, it works well.


Fix invalid mask implementation

Fix masking implementation at TextEncoderT5.
Issue

The current implementation has different mask implementation with Tokenizer's attention mask that uses 1 for attended positions and 0 for masked positions. That is, the current implementation sets the attending token to 0 and the masking token to 1. So, it prevents proper masking functionality.

Solution

Fix the attentionMask implementation.
token == padToken ? maskToken : padToken => token == padToken ? padToken : maskToken

Thank you for the feedback. I have tested cases to cover the encoder functionality with modified codes, specifically focusing on the aspect you mentioned.
Before talking about the test results, let me tell you about a fix that were added:
attentionMask[0] = bosToken => attentionMask[0] = eosToken
It's the same reason as the previous modification.
Test Env

Used baseline T5 model: google/t5-v1_1-base
Test device: iPhone 15 pro
iOS version: 17.6

Result
Here are the results of my tests (each result only extracts the first 100 elements):

The test device's output with current version
(token == padToken ? padToken : maskToken & attentionMask[0] = bosToken):

[0.4260242, -0.13146661, -0.05443061, 0.4278283, -0.08791171, 0.07497577, 0.27828237, -0.08772106, 0.025646126,
0.13052055, -0.11672092, 0.008639214, -0.25987187, -0.3600051, -0.19493277, -0.041954715, -0.0004980617,
0.27182093, 0.43326083, -0.0035369801, 0.15730482, 0.20143896, 0.110297814, -0.16129531, -0.11004589,
-0.028402163, -0.12952378, -0.25261134, 0.28395727, -0.26019362, 0.13527231, -0.33412644, 0.29622442,
-0.4236819, -0.12266792, 0.036390632, 0.13896675, -0.017689465, -0.016119154, -0.20535961, 0.016372599,
0.3201423, 0.5513491, 0.12941936, 0.0044890335, -0.020545868, 1.0494097, -0.05484867, -0.08088168, 0.04241238,
0.032832634, 0.029508296, -0.13568477, -0.06957459, 0.13856326, 0.04223821, -0.19883841, 0.17156312,
0.20071374, 0.14013502, 0.01915358, -0.015412725, -0.3586532, 0.19870706, -0.032982983, 0.011797173,
-0.029784583, -0.14813012, 0.15077302, 0.34914255, 0.09121524, 0.11863368, 0.1667563, 0.28975943, 0.03273004,
0.31420997, 0.0073143677, -0.09999864, -0.07020134, 0.051774386, -0.20251463, -0.2000018, -0.12373174,
-0.13639234, 0.14170212, -0.1797655, -0.27845755, -0.59155124, -0.09609143, 0.26174963, -0.306249, 0.04012702,
0.043527234, 0.12504794, 0.18454747, 0.47887146, -0.0998203, 0.41656193, 0.056153394, 0.16919865,
-0.034775756]

The test device's output with fixed version
(token == padToken ? maskToken : padToken & attentionMask[0] = eosToken):

[-0.07631074, 0.020202171, 0.107408315, 0.16560224, 0.01083674, -0.26095173, 0.06565774, 0.12822415,
-0.15619999, -0.1736349, 0.17435148, 0.23238882, 0.0015687324, 0.07438593, 0.06850898, -0.05751907,
0.001194903, 0.21067473, 0.37535632, 0.31674048, 0.4225261, -0.15225923, 0.17576945, 0.01786299, -0.2679231,
0.19424905, -0.09404993, 0.0605059, 0.11416181, 0.11132382, 0.11258528, 0.0664307, 0.13322611, -0.25261748,
0.081475206, 0.17849542, 0.17070141, 0.05419595, -0.267129, -0.05937576, 0.1273334, -0.3682904, 0.012873589,
-0.057012416, 0.12541112, -0.01752916, 0.12443144, 0.14152816, 0.053368524, 0.13122968, 0.13614295, -0.16103818,
0.15859632, 0.012001296, -0.13215841, -0.013239053, 0.19885042, 0.2342411, 0.11136218, 0.14910215, -0.14328463,
-0.10696429, -0.14799124, 0.18553326, -0.05146354, -0.3661642, -0.26175126, 0.0993159, -0.04179929, 0.20667534,
0.16085686, 0.04715261, 0.2693186, 0.107595906, -0.0286839, -0.2055541, 0.30528533, -0.08761179, 0.15906587,
-0.08903981, 0.0024355464, 0.017705016, 0.32590625, -0.19161393, -0.15557778, -0.10807836, 0.16928717,
-0.15476838, 0.1307424, -0.42686257, -0.21989107, -0.05892702, 0.14845355, 0.37275925, -0.0014533018,
-0.037888847, 0.16911794, 0.09435404, 0.19486858, -0.18566807, -0.1713055]

The baseline's output:

[-0.0763,  0.0202,  0.1074,  0.1656,  0.0108, -0.2610,  0.0657,  0.1282,
-0.1562, -0.1736,  0.1744,  0.2324,  0.0016,  0.0744,  0.0685, -0.0575,
0.0012,  0.2107,  0.3754,  0.3167,  0.4225, -0.1523,  0.1758,  0.0179,
-0.2679,  0.1942, -0.0941,  0.0605,  0.1142,  0.1113,  0.1126,  0.0664,
0.1332, -0.2526,  0.0815,  0.1785,  0.1707,  0.0542, -0.2671, -0.0594,
0.1273, -0.3683,  0.0129, -0.0570,  0.1254, -0.0175,  0.1244,  0.1415,
0.0534,  0.1312,  0.1361, -0.1610,  0.1586,  0.0120, -0.1322, -0.0132,
0.1989,  0.2342,  0.1114,  0.1491, -0.1433, -0.1070, -0.1480,  0.1855,
-0.0515, -0.3662, -0.2618,  0.0993, -0.0418,  0.2067,  0.1609,  0.0472,
0.2693,  0.1076, -0.0287, -0.2056,  0.3053, -0.0876,  0.1591, -0.0890,
0.0024,  0.0177,  0.3259, -0.1916, -0.1556, -0.1081,  0.1693, -0.1548,
0.1307, -0.4269, -0.2199, -0.0589,  0.1485,  0.3728, -0.0015, -0.0379,
0.1691,  0.0944,  0.1949, -0.1857, -0.1713]

The results above show that the results of the modified version match the results of the baseline.
Reason
As I mentioned, the T5 baseline model uses results from the tokenizer as inputs. So, I think this issue is caused by the difference in the way AttentionMask is implemented between Tokenizer and the current version.
Summary
The tests run successfully and validate the expected behavior. However, I will leave the GitHub address where all the code I used for testing is located, as it is possible that my mistakes in converting and testing the model may cause errors in the results. So, please let me know if there are any additional improvements.

@KyuHwan00 A good way to test this would to provide T5 embeddings into the model using this logic vs the old logic and comparing the resulting images - I would expect them to be significantly different. Could you provide these two images to represent an "end to end" test, as well as steps to reproduce it, perhaps via the CLI?
Here is a good example of a PR with this kind of end to end test: https://github.com/apple/ml-stable-diffusion/pull/357

@ZachNagengast Thanks for the your feedback. I'll get back with the appropriate test cases ASAP.

@ZachNagengast @alejandro-isaza Thanks for your patience first, I report on the results for the appropriate test cases.

Prompt: A beautiful painting of flowing colors and styles forming the words "The SD3 research paper is here!", the background is speckled with drops and splashes of paint

Result of old version

Result of my modified version

As you can see from the generated images shown above, you can see that the modified version does not produce an appropriate output for the prompt. Perhaps this difference is made because the code is a specific version of T5 exported to optimize the calculation of Apple Silicon, as @ZachNagengast mentioned. Sorry for missing out on this. Finally, thanks for your feedback.

Thanks for running these, since the two models are different, perhaps you can adjust your converter code to conform to the pre-exported model. I think the logic makes sense as-is but lmk if you think otherwise:
token == padToken ? maskToken : padToken

When building the attention mask, if we see a pad token in the input ids, we should mask it out, because it doesn't contain meaningful information about the text describing the image.
If it is not a pad token, ie it is meaningful text, we should not mask it, thus the pad token.

attentionMask[0] = bosToken

Since the input ids will have bos tokens, which is the same value as the pad token, we overwrite the first entry in the mask to attend to the bos token on the input, because otherwise it would be masked out.


Unable to call super.initialize()

I'm new to backbone, so I could be missing something. But I have something like:
var ChildClass = BaseClass.extend(
{
initialize: function()
{
Backbone.Model.prototype.initialize.call(this);
alert("child init (should see parent init before this but you don't)!");
}
}
Maybe I'm going about this wrong? I've been coding all day so forgive me if so :). But why can't I call super.initialize this way?

You're mixing two different things here.  I'm very confused as to what your actual situation looks like.
var SubModel = Backbone.Model.extend({
  initialize: function() {
    Backbone.Model.prototype.initialize.apply(this, arguments);
  }
});

I have no idea what BaseClass is in your example.

Base class is something along the lines of:
var BaseClass= Backbone.Model.extend({
 initialize: function() {
   alert("this is the base class");
 }
});

And child:
var ChildClass= BaseClass.extend({
 initialize: function() {
   Backbone.Model.prototype.initialize.apply(this, arguments);
   alert("child initialized!");
 }
});

I was under the impression that Models extend Backbone.Model, and their children would extend the BaseModel?
The example in the docs I believe was Note = Backbone.Model.extend and PrivateNote = Note.extend.
Does that make sense?
I want to initialize my ChildModel by doing:
var c = new ChildModel();
and see both alerts so I know both initialize functions were called. Just a layer of abstraction in my classes/models to keep everything clean.

Try BaseClass.prototype.initialize.apply(this, arguments); instead

Have a look at this line of the BB's source code.
Can be used as follows. Test it here.
var BaseClass = Backbone.Model.extend({
  method: function () {
    alert('Greetings from BaseClass');
  }
});

var ChildClass = BaseClass.extend({
  method: function () {
    this.constructor.__super__.method.apply(this);
    alert('...and ChildClass!');
  }
});

var test = new ChildClass();

test.method();

// alerts:
// => Greetings from BaseClass
// => ...and ChildClass!

this.constructor.__super__.method.apply(this);

Works! I didn't see that in the documentation anywhere, so I'm not sure if this is user error or just missing documentation, but either way I really appreciate the help!

Actually, from what I'm seeing here:
https://github.com/documentcloud/backbone/pull/787#issuecomment-3143358
I should not be using super, and the
Backbone.Model.Prototype.initialize.call(this);

does NOT call the parent initialize as I would have expected, so maybe there is a bug here.

No bug here. When doing new MyModel the resulting object owns a constructor property which points to MyClass. MyClass owns a __super__ property which maps to the class it was extended from. So if you need to call the initialization of the class you extended from you need to access initialize inside the __super__ property of the constructor, which leads to this.constructor.__super__.initialize.

Even though the link I had said:

Yes __ super __ is not intended for you to use it directly, as the underscored name implies."

?

That's true, you shouldn't use it. What I meant was that you're approach is not correct.
Let's clarify things: Backbone.Model.prototype.initialize.call(this) means "execute the original, Backbone.Model's, initialize function as if it was called on myself (this)". The actual body of that function can be found here, and does no magic at all. Ahem, it does nothing at all!
So your use shouldn't be Backbone.Model.prototype.initialize.call(this) (which does nothing as we saw) but to execute the super class method, which can be called as BaseClass.prototype.initialize.call(this).

Ohhhh that makes perfect sense! Call it lack of coffee, or my new transition to javascript. Thanks so much! I'll go ahead and close this then.
Thanks!

@framerate @yuchi I'm glad you guys finally came to the conclusion that I posted two hours ago

@blocka I misread yours, since I read it before coffee. :)

@blocka Actually I forgot to say that I agreed with your message. I simply tried to give some more context


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/30662

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/33378

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/40065

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/43888


How is filter_empty_mask interpreted for 3D kernels?

This field:

Makes sense for 2D models, but what is a 'slice' in a 3D kernel? If this field is set to True, does this imply that the 3D patch is discarded if at leat one slice is empty?

Makes sense for 2D models, but what is a 'slice' in a 3D kernel? If this field is set to True, does this imply that the 3D patch is discarded if at leat one slice is empty?

It does not apply to 3D kernels at all.
All slice_filter_params apply only to 2D slices.

A 2D slice is an entire 2D image taken from a 3D volume, ex: an image of size 128x128 taken from a volume of size 128x128x16
A 2D patch is a portion of that entire 2D image, ex: a patch of 32x32 taken from a slice of 128x128
A 3D slice is a concept that does not exist for our purposes.
A 3D patch would be a portion of a volume used for training i.e. a subvolume, ex: a patch of 32x32x16 from a volume of 128x128x16.

There was previously an issue (#1163) and PR (#1164) dedicated to adding the feature to 3D as well, but it seems that changes have not been merged.
Note that in the case of 3D, it would not be a "slice" filter, but a "patch" filter as all training in 3D are done with subvolumes.
We should probably clarify the documentation about the difference between a slice and a patch as well (ref to #1235).


Panic on start when -c is passed

Describe the bug
The dock started to crash on start yesterday when I specify -c.
To Reproduce
Steps to reproduce the behavior:
1- Start the dock: nwg-dock-hyprland -c "rofi -show drun -theme config.rasi"
2- Immediately crashes with
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x5ee243]

goroutine 1 [running]:
main.buildMainBox(0xc0000ac070)
        nwg-dock-hyprland/main.go:218 +0xb83
main.main()
        nwg-dock-hyprland/main.go:567 +0x145e

Expected behavior
Dock starts
Desktop (please complete the following information):

Linux distribution: Arch Linux, the dock is installed via nix: v0.1.8
go version: go1.22.3 linux/amd64
gtk-layer-shell version: 0.8.2-1

I'm closing this issue as after a day of consistently crashing, the issue went away on it's own.


Add Module::version

Q
A

Is bugfix?
no

New feature?
yes

Breaks BC?
yes

Tests pass?
yes

Fixed issues
#12726

Just noticed: yii\base\Application already has a version public property:
https://github.com/yiisoft/yii2/blob/master/framework/base/Application.php#L100

Legacy Application::version removed.
Thus this PR produces a slight BC break, as it will return version based on timestamp instead of 1.0 be default.

Timestamp-based versions are useless anyway. mtime is completely unrelated to real application version - changes in application not always change mtime of project root.

Timestamp-based versions are useless anyway.

Make sense. I have changed default value to 1.0 keeping the BC.

Just noticed: yii\base\Application already has a version public property

This shows that its an idea to open a topic to further cleanup Application & Module. Bootstrap for instance, is something that is useful too for Modules.


Remove mention of dvc plots subcommands from plot anchor definitions

You may disregard these recommendations if you used the Edit on GitHub button from dvc.org to improve a doc in place.

❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention Fix #issue (if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.
Please choose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏

Closes https://github.com/iterative/dvc.org/issues/5038

My bigger concern was text like this:

<DVC_METRIC_TITLE> - a title for the plot, that can be defined with the --title option of the dvc plots subcommands.

This seems too focused on the CLI.

Thanks @mattseddon! Added a few changes to reference dvc.yaml. PTAL.


[Feature] replace console logs with logger

Is your feature request related to a problem? Please describe.
After #337, some references to console.warn are still in the codebase:

https://github.com/ekalinin/sitemap.js/blob/965c4a77d9034d5e8aab8843aac76d8853a4a629/lib/utils.ts#L64
https://github.com/ekalinin/sitemap.js/blob/965c4a77d9034d5e8aab8843aac76d8853a4a629/lib/utils.ts#L74

It should be useful to switch to a logger implementation entirely.
Describe the solution you'd like
1- Pass a logger inside the options, that defaults to console. (for backwards compatibility),
2- AND/OR allow to pass a custom "handleError" function as an option, so that we can customize the handling of internal errors.

Thanks for your PR. I've merged and released it. It looks like validator's console.warn still needs to be handled. I'll take a look at that tomorrow.


Set heater water temperature

Hello :)
I found your work amazing
I saw there is no sensor/option to read the water temperature for heater. There is with domestic hot water, but miss for the heater.
I own a Ariston ClassOneL30, connected with CubeSNet
I set the heater to ignore smart thermostat becouse I already have a thermostat for room, cabled on valves. Connecting as default the CubeSNet it would ignore thermostat and only use the smart one.
I don't know very much of home assistant so I'm not sure about which entity should be added, if there is a schema with "thermnostat" or something, or maybe we could create another "thermostat" entity that does manage the water temperature (we can see from Ariston web page the actual temperature, and the sat one)
I could prepare a PR if guided on which file may have some sample to see how it's working, i'm not very experted in python though...

Hello!
I have an Ariston Alteas One Net. The water heater entity in Home Assistant is water_heater.aaon . AAON is the name I've set in configuration.yaml file here:
username: !secret ariston_username
password: !secret ariston_password
name: 'AAON' #friendly name for integration, default is Ariston
The climate entity is climate.aaon.
The card I use in Lovelace for water heater is:
type: custom:water-heater-card
entity: water_heater.aaon
You can find the custom water-heater-card here: https://github.com/rsnodgrass/water-heater-card.
You can find this custom card in HACS as Water Heater Card in Frontend section.
I hope the information is helpful!


Refactor boot policies suite test case to use new xyz

Refactor boot policies suite test case to use new xyz

@swe12345 : Please try to work on this story as discussed.


installing Azure Devops Server 2019 Update1 RC1 over Devops Server 2019.01 warns about  Azure File Copy task version

Installing Azure Devops Server 2019 Update1 RC1 over Devops Server 2019.01.
The last configuration wizard throw this warning:
[2019-07-03 09:54:34Z][Warning] Updating an existing task Azure File Copy (eb72cb01-a7e5-427b-a8a1-1b31ccac8a43) with an older version 1.0.144. Please contact Task author to bump their task version, the service already had version 1.0.145 in record. Reference github repository's contributors to find Task author. (https://github.com/Microsoft/vsts-tasks).
Does it mean the RC1 includes a older task version compared to the 2019.01 ?

@spashx - Thanks for reporting. We also identified this issue and it is fixed with #10742 & #10751 . There is no functional issue with Azure file copy task, hence you can ignore this warning in 2019.01. The fix will be present in 2019 update 1 RC2.


Add homework-1

Metric
Value

alert_status
:white_check_mark: OK

bugs
0

code_smells
47

reliability_rating
A (0 Bugs)Note: A being best, E being worst

security_rating
A (0 Vulnerabilities)Note: A being best, E being worst

vulnerabilities
0


wrong spatial alignment for visual inertial poses (T_W_E) and laser poses (T_B_H)

Dear author,
Thank you for open sourcing the hand eye calibration algorithm.
Following the instructions at README.md, I built the hand eye calibration package in Ubuntu 16.04 + ROS kinetic. The data was collected with a lidar (laser range finder) and a camera and an IMU, the three mounted rigidly to a moving platform.
Then the poses of the camera(eye) expressed in a world frame (the camera frame at the start), T_W_E, was obtained by a visual inertial odometry method with loop closure. And the poses of the lidar (hand) expressed in a base frame (the lidar frame at the start), T_B_H, was computed with a 2d lidar package. The data files are in the input directory of the attached zip file.
mydata.zip
In the end, the below command was executed.
rosrun hand_eye_calibration compute_complete_handeye_calibration.sh \
poses_B_H.csv poses_W_E.csv

And the resulting log, figures, and data files are in the output directory of the attached zip file.
It appears that the temporal calibration is done well. However, the spatial calibration is wildly wrong.
Can you please look into the issue? Am I missing certain points?

The problem is 2d lasers provide constraints only in xy motion and yaw, which causes the optimization problem to be degenerate and not converge. To solve this you would have to change the initial estimate and pass the appropriate priors to the optimization algorithm.

Do you mean the dual-quaternion-based hand-eye calibration requires the sensor to rotate about at least two axes?
As you suggested, the initial estimates contained in calibration.json was updated to the below values:
{
    "delay": -18.388532638549805,
    "rotation": {
       "i": -0.0364413,
       "j": -0.705874,
       "k": 0.706455,
       "w": 0.0365489
    },
    "translation": {
       "x": -0.374,
       "y": -0.657,
       "z": -0.61
    }
}

Then the below command was executed:
rosrun hand_eye_calibration_batch_estimation batch_estimator \
   --v 1 \
   --pose1_csv poses_B_H.csv \
   --pose2_csv poses_W_E.csv \
   --init_guess_file calibration.json \
   --output_file calibration_optimized.json

The resultant calibration_optimized.json has below content:
{
    "delay": "-18.364190020999999",
    "rotation": {
        "i": "0.08702350670296348",
        "j": "-0.70107073682332255",
        "k": "0.70236266525664703",
        "w": "-0.087258117345047473"
    },
    "translation": {
        "x": "-0.30239376833050313",
        "y": "-0.56651254374484339",
        "z": "-0.61006163744095709"
    }
}

These values looks reasonable. For this test, the optimization algorithm indeed handles the degenerate case well.

Yes, sounds reasonable. The idea of the hand eye calibration is to calibrate 2 fully 6DoF tracks, meaning it would require motion in all of the degrees of freedom. For the degenerate case indeed the first problem is coming up with an initial estimate.
The optimizer could then theoretically handle the case. Did it in the end converge to some visually correct looking result? To have a guarantee of it working would require giving the optimizer some knowledge about the priors (for example an initial height estimate with a covariance). This does not mean that you could not obtain a result in some cases. But since without full 6DoF movement some of the variables are not fully constrained and there could be multiple solutions (or even an infinity), you have no clear guarantees.

I agree.
IMHO, the optimized T_H_E results in visually correct alignment. Below are the figures before and after alignment drawn by hand_eye_calibration.
The visuals before alignment:
original size:

zoom in:

Using the manually measured T_H_E, the alignment result looks like:

Using the optimized T_H_E initialized with the manually measured value, the alignment result looks like:
 and

Don't think the alignment is correct. They are both on the same z plane indeed, but the thin red and green lines between the frames which represent the trajectories are not overlain. I still see about a 90 degree rotation offset between the aligned trajectories.

I appreciate that you pointed out my misinterpretation of the figure. I used Horn's method implemented in https://vision.in.tum.de/data/datasets/rgbd-dataset/tools to get an initial rough value for T_H_E, and implemented a correlation approach to estimate the initial time offset, and finally updated calibration.json to
{
    "delay": -18.217288,
    "rotation": {
       "i": -0.50038157,
       "j": 0.49597917,
       "k": -0.50092414,
       "w": 0.50269053
    },
    "translation": {
       "x": 0.186525,
       "y": 0.436177,
       "z": 0.118397
    }
}

With the updated calibration.json, after running the batch_estimator, the calibration_optimized.json looks like:
{
    "delay": "-18.215783967",
    "rotation": {
        "i": "-0.50868042643872924",
        "j": "0.48512137503036812",
        "k": "-0.49618751775785747",
        "w": "0.5096069447368512"
    },
    "translation": {
        "x": "0.19301951643356816",
        "y": "0.069235089106293432",
        "z": "0.11977924556405914"
    }
}

And the results are visualized like follows.
The figure showing results of evaluate_alignment which used estimates from calibration_optimized.json.

The figure showing the 3D poses after alignment by using estimates from calibration_optimized.json.

And the aligned poses from another perspective.

I believe these results look fine. FYI, the log for batch_estimator is also attached.
batch_estimator.log
One comment about the initial time alignment in this hand_eye_calibration repository.
I have tried several approaches to estimate the time offset. All the estimates fall into [-18.22, -18.22]. And your batch_estimator also gave such an estimate, -18.2158. However, the compute_aligned_poses modules gave an exceptional estimate, -18.3885.  Running batch_estimator initialized with this exceptional time offset estimate took much longer than with an estimate in range [-18.22, -18.21].


Cannot use response.mapError with ByteResponse

Using a HttpResponse<byte[]> response, I cannot use mapError on it because it converts the byte array, like [97, 98, 99] into a literal String representation of the array, like '[97, 98, 99]', instead of abc, in getErrorBody.
To Reproduce
Steps to reproduce the behavior:

Have an endpoint that would return an octet/stream in case of success, but a JSON in case of failure, like a Spring REST controller would do, with the default error handling:

{
    "timestamp": "2022-01-05T16:56:26.920+0000",
    "status": 500,
    "error": "Internal Server Error",
    "message": "Some message",
    "path": "/getContent"
}

static class Content {
	String error;
	String message;
}

Unirest.get(url)
	.asBytes()
	.ifFailure((HttpResponse<byte[]> httpResponse) -> {
		// this will invoke BaseResponse.getErrorBody
		// which will invoke getBody() that returns the byte array
		// and the byte array passed through `config.getObjectMapper().writeValue(body)`
		// which returns something like Arrays.toString(byteArray)
		Content error = response.mapError(Content.class);
		response.getParsingError()
			// no parsing error here actually, the object will be empty
			.ifPresent(e -> logger.error("Unable to parse body", e));
		if (error.message == null) {
			// this will have the same result as Arrays.toString(body)
			// not the actual string representation constructed from the byte array, like new String(body)
			System.out.println(response.mapError(String.class));
		}
	});

Since I can't find such a public endpoint, I can offer a test that proves just the conversion to String:
String url = "https://httpbin.org/bytes/-1";
Unirest.get(url)
	.asBytes()
	.ifFailure((HttpResponse<byte[]> httpResponse) -> {
		// we don't really know the response encoding, since it's stored in the request, doh, assuming UTF-8
		String body = httpResponse.mapBody(bytes -> new String(bytes, StandardCharsets.UTF_8));
		System.out.println(body);
		// this should have printed the same HTML as above
		System.out.println(httpResponse.mapError(String.class));
	});

Expected behavior
I expected both mapError to be able to return an object instance populated with the values from the response, but since the byte array gets converted to String using Arrays.toString(..), it will fail.
Screenshots
If applicable, add screenshots to help explain your problem.
Environmental Data:

Java Version: 8 latest
Version 3.13.4

Wow, what is this JavaScript 🤣
This is actually even weirder than it looks, the final string conversion is done by the ObjectMapper which is being asked to encode the body to a string and does so literally, I've bypassed that for the case of byte[] to go to a string(byte[]) but I'm not sure this is the fully correct answer, we don't actually know fully if the byte[] is in fact a string. I've patched it to pass the tests in 3.13.6. I think it's more right than it was before, but probably not 100% right, need to mull on that a bit.
At the very least it still needs to look at the response body for the encoding (which should in fact be there), it's assuming UTF-8 right now.

Thanks for the fix 🙂
Should I create a ticket for the HTTP response encoding to be available in the response object?
It seems weird that it's in the request...

The request contains the encoding that you asked for (or a default of UTF-8) which might not be what you got. We have to look at the response Content-Type, which in the case you cited should be application/json or application/json;charset=utf-8 or whatever the encoding it. It could ALSO come from the Content-Encoding header which might tell us that the byte[] is gziped (in which case these tests would probably fail maybe...although it might already be deflated by the time we get here).
If you want to open a new issue feel free otherwise I will.

well, I guess we do use the request one, sometimes, eh, I think we just assume the response is what we asked for. So that might be another issue, if the response says something that contradicts the request. Pretty edge case.


Partials v2

Credits to @vbuterin for exploring partials early on. I rebased his branch on the dev branch, since the older PR (#1184) was based off of an intermediate SSZ implementation, with missing features/bugfixes/types/consistency. Now we are building towards fully SSZ-compatible partials again, incl. use with spec state transition functions.
Status:

initial partials code by @vbuterin refactored (WIP) to be more class-based, to fit seamlessly in with the other SSZ types.
logistical functions mostly updated to use new types
need to split some of the helper functions, move their functionality into the partial types. Problem was that every helper func needed a typ param, and did a big switch-like statement on SSZ types. Instead we can generalize this nicely, make type information easily accessible, and move it into the right part of the type inheritance tree.

Summary of design:
note the difference between abstraction levels in the inheritance structure:

object: instance of a SSZValue
ssz class: class for an object, instance of SSZType
ssz class type: form of ssz type, subclass of SSZType. E.g. some ssz classes are a BasicType, some not. Some are ElementsType: they have an elem_type and length property.

Due to limitations in python, Container has no ContainerType metaclass. This means that we use the __annotations__ attribute to get the fields and their types from a Container subclass. These are accessible with classmethod-annotated functions, to allow for typ.get_fields(): retrieve class information without creating an object (but it does create the class)
Partials can be modeled as subclasses of the ssz classes. With a Partials class mixed in to provide partials functionality (pre-refactor). This enables a partial of a given type to be passed into any function that accepts that regular type.
In this refactor, I'm splitting the Partials class, so that the different variations can subclass ssz-classes, which lets us get rid of the typ argument, and fetch type data like fields, length, element type etc. from the super type. Along with the values in the super class.
Get/Set-item/attribute is overridden to inject the partials logic: retrieve elements/fields from included data, or error when the data is unknown (i.e. not included in the partial)
I'll post a visual overview of the OOP structure after refactoring some more.
I think the final idea is to support something like:
state_partial = Partial[BeaconState](data objects, root index)
v = state_partial.validators[my_index]
and...
get_important_value(state_partial)# and any other spec function that accepts BeaconState
etc...

And then we can start building POC light clients on top of SSZ.
this is still very experimental, work in progress.
Misc ideas
SSZValue (and any subclass) as path root, give the class a / operator overload, and then output a SSZPath, carrying the generalized index and the type of the path node.
Then also define / for the SSZPath, and we can use paths to abstract away any light client logic.
Basic example:
path = BeaconState / "validators" / 123 / "slashed"
# see if slashed, in generic way. Could be proving more at the same time.
value = some_partial.proof(path.gen_index, False)

What's the status here @protolambda ?

Put everything together, incl. multi-proofs code from latest spec, and fixed types/usage, along with improvements in type structure (ComplexValue/Type, and length<>limit separation). Plan is now to implement a Partial[...InnerType...] notation, to have static type-checked partials available.
E.g.:
# subset of the fields (*random* example)
class LightState(Partial[BeaconState]):
    eth1_data: Eth1Data
    finalized_checkpoint: ExamplePartCheckPoint
    some_list: Partial[List[128, Foo], [3,4,100]]

class ExamplePartCheckPoint(Partial[Checkpoint]):
   root: Hash
   # epoch is ignored but proof data is supported by Partial wrapper

And then defer proof construction to when we need it, instead of tracking the branches and leaf chunks inside the Parital instance. This should be cheaper and more realistic. And then on Partial instantiation, we can parse the multi-proof, verify correctness (both merkleization as typing), and have the thing available wherever we need it. (As the wrapper produces a subclass instance of the wrapped type).

Update: there is a lot of trial and error in this PR, along with the previous partials PR. But made some great progress in a long IRL discussion with Matt to decide on a new clean design, which also works as a pattern for use in an ewasm setting. Me and Matt went over this in the python call, and are planning to put out a new updated doc some time this week, after getting feedback from Vitalik here in Berlin, and more iteration on this new approach.

See https://github.com/ethereum/eth2.0-specs/issues/1303#issuecomment-526366715
Current thoughts are that a multi-proof behind an interface is sufficient (and efficient for our needs) for a partial, and that we may want to standardize offsets or other data to encode the structure of the proof with the packed data efficiently. Leaving this for now though, as phase 0 interop work is more pressing. Let me know if someone likes to pick this up in the meantime.

The latest idea is to separate and isolate complexity better, and layer it as:

proof-backings, support multiple options
multi-proofs: interface to work with bare proof backings
partials: typing around the multi-proof interface

This PR is largely outdated, as it still mixes these layers.
During devcon discussions about ssz/merkleization/standards it became clear that SSZ is outgrowing this specs repo, and that partials and other advanced features need a place to live with an "experimental" standardization stage. I started a SSZ specs repo draft here, and plan to discuss on the implementers call of 24 Oct.
Closing this PR after the call, and will keep track of the SSZ repo transition progress in some new issue/PR.

See https://github.com/protolambda/eth-merkle-trees/blob/master/typing_partials.md for a write up of how typing over binary tree backings would work. I've an open python project in progress that implements this, but will keep it separate from the spec for now.


feat: add delegates page

Summary
Closes: https://github.com/snapshot-labs/sx-ui/issues/566
This PR adds adds delegates page that can be added to the space by configuring API url.
Test plan

Create new space or edit existing space profile to add delegation API URL (for example https://api.thegraph.com/subgraphs/name/arr00/uniswap-governance-v2).
Go to space page.
Go to Delegates page.

Screenshots

Looks great! Can you just:

Remove the "delegator(s)" column on mobile
Add an input for the settings where you can select the type / standard being used for the API, this will help later once we deal with others standard, for Compound based subgraph it can be "Governor subgraph" id : governor-subgraph


Fix map proof

Coverage decreased (-0.4%) to 90.885% when pulling 59addbfd8616881b863e9317d8eec528b2a1fff5 on boguslavsky:fix-map-proof into ae76792c791b78d35fd6dc0eeb8330a44c229e2b on exonum:master.


lockfile causes issue with the same chart of different versions

When running commands such as template on a helmfile that has the same chart, but at different versions.
in ./helmfile.yaml: in .helmfiles[1]: in helm/account/dev/x/dev/helmfile.yaml: duplicate chart dependency "x". you can't have two or more charts with the same name but with different urls or versions: existing={x s3://charts/charts 1.4.3}, new={x s3://charts/charts 1.5.0}
charts:
- name: x1
  <<: *default
  version: 1.4.3
- name: x2
  <<: *default
  version: 1.5.0

@sstarcher Hey! Good catch. This is unfortunately how helmfile works today.
I think I can safely loosen the restriction, that would exclude releases with correct semver(not version range) in version specified.
After that, in your case x1 and x2 will be exluced from the dependency locking process, as they are already "locked" anyway with the explicit semver specified in your helmfile.yaml.
Does that sound ok?

The gotcha is that this won't still succeed:
charts:
- name: x1
  <<: *default
  version: "> 1.4.3"
- name: x2
  <<: *default
  version: "> 1.4.4"

Do you need support for the above, that helmfile accepts different version constraints for the same chart? It is a bit harder to implement, but not impossible. Just wanted to confirm if you really need it.

After some thought it doesn't seem that hard.
Assuming helm uses https://github.com/Masterminds/semver for semvers and version constraints, I think helmfile could easily leverage it so that it parses version in your helmfile.yaml, retrieves only one of the locked versions matching the constraint from helmfile.lock.
That way we can easily remove the helmfile restriction?


[!] Unable to find a specification for Texture (= 2.3.2)

When I cloned this and ran 'pod install' I got this error.
I also ran pod repo update.
I'm new to cocoapods so I may have made a rookie mistake.

This is actually a bug with cocoa pods. Run
pod repo remove master
pod setup


Configure 404 response behaviour for @rest directive

What do you think about just making this the default? It seems very odd someone would need to modify this, better to add less APIs if possible

It is already the default in this PR, so it's just a matter of whether we keep the param that allows modifying it or not.
Since it's an optional param that most people will probably ignore and not send in most cases, I don't really feel strongly in either direction, both options seem fine to me


Elin/merge main v0.13.1 into main

This change is

Codecov Report
Attention: 58 lines in your changes are missing coverage. Please review.

Comparison is base (d4e3b93) 69.88% compared to head (85bef82) 69.50%.

Files
Patch %
Lines

crates/blockifier/src/versioned_constants.rs
32.55%
50 Missing and 8 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1534      +/-   ##
==========================================
- Coverage   69.88%   69.50%   -0.39%
==========================================
  Files          59       59
  Lines        8180     8220      +40
  Branches     8180     8220      +40
==========================================
- Hits         5717     5713       -4
- Misses       2005     2044      +39
- Partials      458      463       +5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Switch from getSimpleName to getSimpleNameOfAnObjectsClass

This PR fixes #992 by replacing the calls to .getClass.getSimpleName with org.scalatest.Suite.getSimpleNameOfAnObjectsClass which avoids getSimpleName and implements its own version on top of the more safe .getName. Note that there is  SI-8110 open about the issues with getSimpleName on objects.
I couldn't submit any test because sbt tests runs forever even without my patch, not sure why, and because I'm not sure where to put them.

fwiw, I'd love to have a 3.0.2 with this fix

FYI: The commit is cherry-picked into 3.0.x and 3.0.2 is released.

awesome!

I guess this ticket can be closed?


Webscrapping working for only Amazon, need to update for rest of the websites

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

This bug was existing from before, we made the changes for other websites and they are working now. Hence closing the issue.


Add about menu

Similar to https://github.com/mueller-ma/PrepaidBalance/commit/9cc583cf375bd71fe904f941c0c8ace54ec6c96b
The PreferenceActivity can be added here as it will be required for #24

@yoobi is working on this


Update Kendo UI entries

Added Kendo UI for Angular Data Grid
Updated the KendoReact entry
Added the TreeList component to the description of both.

@tsvetomir Thank you for this! I've incorporated these changes with a few changes:

The TreeView functionality was changed to a feature comment. This allows the library to appear if a user filters by the trees feature and displays the comment as a tooltip.
I've also added a Kendo UI for Vue file. I considered combining all of the Kendo libraries into one, but after reviewing the docs, each of the Kendo implementations for React, Vue and Angular appear to be significantly different enough to warrant separate cards.

Thanks again!

Thank you, the edits are spot on!


As a user I want to find healthsites in my area by typing in the name

free form search tool that queries geonames

Currently broken, the service that I use to get the list of geonames is down. Need to find another one.

impendiment, needs data of polygon for each of place in geoname


Uncaught Error: Cannot read property 'object' of undefinedTypeError: Cannot read property 'objec...

[Enter steps to reproduce:]

Just had a tab open, I think it has something to do with Linter and ESLint though.

Atom: 1.17.0 x64
Electron: 1.3.15
OS: Mac OS X 10.12.5
Thrown From: Atom Core
Stack Trace
Uncaught Error: Cannot read property 'object' of undefined
TypeError: Cannot read property 'object' of undefined
at ObjectsRegistry.get (/Applications/Atom.app/Contents/Resources/electron.asar/browser/objects-registry.js:41:28)
at EventEmitter. (/Applications/Atom.app/Contents/Resources/electron.asar/browser/rpc-server.js:306:31)
at emitMany (events.js:127:13)
at EventEmitter.emit (events.js:201:7)
at WebContents. (/Applications/Atom.app/Contents/Resources/electron.asar/browser/api/web-contents.js:222:13)
at emitTwo (events.js:106:13)
at WebContents.emit (events.js:191:7)
At /Applications/Atom.app/Contents/Resources/electron.asar/renderer/api/remote.js:217

Error: Cannot read property 'object' of undefined
TypeError: Cannot read property 'object' of undefined
    at ObjectsRegistry.get (/Applications/Atom.app/Contents/Resources/electron.asar/browser/objects-registry.js:41:28)
    at EventEmitter.<anonymous> (/Applications/Atom.app/Contents/Resources/electron.asar/browser/rpc-server.js:306:31)
    at emitMany (events.js:127:13)
    at EventEmitter.emit (events.js:201:7)
    at WebContents.<anonymous> (/Applications/Atom.app/Contents/Resources/electron.asar/browser/api/web-contents.js:222:13)
    at emitTwo (events.js:106:13)
    at WebContents.emit (events.js:191:7)
    at metaToValue (/Applications/Atom.app/Contents/Resources/electron.asar/renderer/api/remote.js:217:13)
    at undefined.remoteMemberFunction (/Applications/Atom.app/Contents/Resources/electron.asar/renderer/api/remote.js:113:18)
    at AtomEnvironment.module.exports.AtomEnvironment.getWindowDimensions (/Applications/Atom.app/Contents/Resources/app/src/atom-environment.js:663:1)
    at AtomEnvironment.module.exports.AtomEnvironment.storeWindowDimensions (/Applications/Atom.app/Contents/Resources/app/src/atom-environment.js:697:1)
    at WindowEventHandler.module.exports.WindowEventHandler.handleWindowBlur (/Applications/Atom.app/Contents/Resources/app/src/window-event-handler.js:184:1)
    at /Applications/Atom.app/Contents/Resources/app/src/window-event-handler.js:3:1

Commands

Non-Core Packages
busy-signal 1.4.1
docblockr 0.10.3
editorconfig 2.2.2
hyperclick 0.0.40
intentions 1.1.2
language-marko 2.9.4
linter 2.1.4
linter-bootlint 1.0.4
linter-csslint 1.3.4
linter-eslint 8.1.7
linter-sass-lint 1.7.4
linter-ui-default 1.6.0
pigments 0.39.1
sort-lines 0.14.0

Thanks for taking the time to contribute!
We noticed that this is a duplicate of #11692. You may want to subscribe there for updates.
Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.


Update build and release setup

Bump go vendoring.
Add VERSION/CHANGELOG to make releases.
Add promu config for building and releaseing.
Re-arrange repo slightly to follow Go cmd/ pattern.

Signed-off-by: Ben Kochie<EMAIL_ADDRESS>

Updated first release version to 0.1.0 and updated the build and use in the README.

Thanks!


[Bug]: Contact us page. The link<EMAIL_ADDRESS>moves to https://s.apache.org/beam-slack-channel

What happened?
Steps:

Open the website https://beam.apache.org/
Click on the button "Contact Us" in the Footer
Find the section "Available contact channels"
Find the line with purpose "Firehose of build notifications from Jenkins"
Click on the link<EMAIL_ADDRESS>in CHANNEL column

Actual result: The page with address "https://the-asf.slack.com/?redir=%2Fmessages%2FC9H0YNP3P%2F" opens
Expected result: The page with address<EMAIL_ADDRESS>opens
Issue Priority
Priority: 1
Issue Component
Component: beam-model

.take-issue


Feature/first experiments

Summary
Created an experiment folder for my cloud gaming project, based on the Caeplin experiments.
Created a tool that generates traces and meta CSV files.
Made the experiments work with CSV files instead of the parquet files.
Implementation Notes :hammer_and_pick:
There experiment file itself contains some clutter now because of the CSV implementation, will clean that up in a future PR when I see that everything works fine.

Whoops, not into that repo!

Did not mean to create a PR for the main repo, but into my fork, sorry.


feat(bridge): Show loading bar only on initial data fetch #4910

This PR

makes sure that the loading indicator is shown only on initial data fetch

Related Issues
Fixes #4910
Signed-off-by: ermin.muratovic<EMAIL_ADDRESS>

As discussed with @laneli and @Kirdock, we are removing the loading bar. Loading indicators should be used in place where data is loaded.

Could you align the other loading icons then?
They are different across the screens.
For example:
uniform:

services:

And some screens don't have a loading indicator like the environment or secret screen.


[refactor] - Remove GMS GraphQL Service

Checklist

[X ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[X] Tests for the changes have been added/updated (if applicable)
[X] Docs related to the changes have been added/updated (if applicable)

Back in Jan'21 when GMS did not have a graphql endpoint this service was added, now that GMS itself hosts both Rest.li and GraphQL endpoints there i snot reason for this service to exist. So, cleaning it up.
Also, found a JQ dependency while installing datahub so added to the quickstart.

Looks like flaky tests..need a re-run

Help me

Yayyyyy! Thank you Arun!

Seems that CI is failing - once that is resolved this should be good

Sure!

@jjoyce0510 CI Looks good now.

LGTM. Thanks again!


How to Configure Environmental Variables from terminal

Trying to stop all type checks using a .env in the root of my project.
Typescript TSC_COMPILE_ON_ERROR=true
tried TSC_COMPILE_ON_ERROR=true and REACT_APP_TSC_COMPILE_ON_ERROR with no success how can I set CRA Advanced configurations from my terminal?

Tried  all

So that don't work for me. How can I set my CRA Advanced figurations in the terminal?
https://create-react-app.dev/docs/advanced-configuration/

Found a solution thru the terminal
On Unix like shells like macOS or Linux you can set env vars in the shell by adding the variable in-front of your command:
$ TSC_COMPILE_ON_ERROR=true yarn start
or
$ TSC_COMPILE_ON_ERROR=true npm start


Adds Gas Analyzer

Closes #1584

Feels a bit gross (ab)using tooltips like this.

Floating text was not good enough to read long text and I thought the chat was not "direct" enough

I was thinking it probably needs a full window.
I know that's quite a lot of boilerplate for a few lines of info though.
Is there anything cool you could add to a full-scale window? display the icons of the gases? pie chart of the tile's total mix percentages?

Fixed the reviews, but I think I'm gonna do Remie's idea instead, so this pr will be drafted

Current images:
UI:

Tooltip hover;

ItemStatus:

Pressure units need to be specified in that first image.


QuickStart - Add closing instructions

Version
1.5.0
Hardware configuration
12th Gen Intel® Core™ i7 with Intel® Arc™ A770M Graphics (Serpent Canyon)
Describe the bug
On the quick start guide (https://github.com/intel-retail/automated-self-checkout), suggest add instructions after step 4 showing how to stop the demo (it keeps running in the browser, and then when the browser is closed it starts it again).

@vmilhoan Step 5 is to stop the entire demo with the command make clean-all


Add manifest file for CDex v2.24 x86

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

Microsoft Reviewers: Open in CodeFlow

/AzurePipelines run

At the end of setup a message box appears. Is there a way to suppress that?  It may block scripts trying to install the app.


fix(versions): update Activiti/example-runtime-bundle versions into master

UpdateBot pushed maven dependency: org.activiti.cloud.rb:activiti-cloud-runtime-bundle-dependencies to: 7.1.191

UpdateBot commands:
updatebot push-version --kind maven org.activiti.cloud.rb:activiti-cloud-runtime-bundle-dependencies 7.1.191


Beacons tab empty

I've had my RAK miner set up for about a week, and the beacons tab is completely empty. The beacons, challenges, witnesses do show up in the all activity tab. sweet powder mouse

I also noticed that it just seems to have disappeared off the explorer map. But it's still working witnessing, challenging, etc

we started investigating this the other day with @danielcolinjames. the data is there, just something is blocking your connection to the api to get that data.

Ok thanks. I moved my hotspot about 5 days ago, and it's still displaying the old ip when I do a status check on hotspotty.io. it's also showing port 44159 instead of 44158. Maybe that has something to do with it?

no, that's entirely unrelated. if you moved it, double check your network configuration.

Glad to see i am not the only one with this. I dont see any beacons or activity, but other people have seen jt for my miner. I tried different browsers, devices, internet connection. Could not find the reason.

Yeah i was also suspecting some cache or cdn because i dont see activities for my miner but someone else sees them for my miner

closing as this has gone stale. if this is still a problem, please open another issue.
and you're right. it's because of cache.


Haddock link issues

It seems that every link to Pos1 of the documentations on Hackage tries to link to c:/Users/Doug/AppData/Local/GitHub/PortableGit_c2ba306e536fdf878271f7fe636a147ff37326ad/package/numtype-dk-0.5/docs/Numeric-NumType-DK-Integers.html#v:Pos1; the same goes for Zero, etc.

Thanks for the report Ivan. Evidently I stuffed up building the documentation to upload to Hackage. I will look in to fixing it ASAP.

I believe the issue may be that I built the documentation in a cabal sandbox that had an add-source dependency on numtype-dk left over from when that was in flux. I've trashed that sandbox and am in the process of making a new one, the docs from that should have links to the correct places.

Any particular reason for not letting Hackage build the documentation rather than building it yourself?

Do you know how long it usually takes? I waited about 12 hours and then took the fact that it hadn't happened as a sign that it wasn't going to, and started researching how to upload them myself. It could be that I did something else wrong that prevented them from building, but it said no build reports were available yet either.

I can't fix this for the life of me. All the scripts I can find for making it happen are very unhappy on windows for reasons I don't quite understand.

I believe it batches them daily or something.
Otherwise, I think Neil Mitchell uses Windows, and he has some custom scripts here.

I've given hackage a few days to build it and it doesn't seem to have tried, at least it still says no build reports are available.
I'll see what I can do with Neil's scripts. Thanks.

I think that once you've uploaded documentation, then Hackage doesn't bother trying to build it.
That said, the latest version of postgresql-simple has been on Hackage for a few weeks and hasn't had any build yet either, so maybe something is broken on Hackage and no docs are being built :s

The button to delete the documentation I had uploaded claimed that it would trigger a rebuild.
It does appear that perhaps something is wrong with this feature of Hackage.
I wish I could figure out how to generate them myself with the correct links. I've tried a few people's scripts and am having trouble. (Curse of Windows.) One of them generated the correct links but then couldn't compress them properly for some reason I didn't understand. I will try again tonight after work.

And eventually it did trigger a documentation build, but that failed due to what appears to be an issue with vector. Log at http://hackage.haskell.org/package/dimensional-<IP_ADDRESS>/reports/1. Snipping relevant portion:
[13 of 21] Compiling Data.Vector.Primitive.Mutable ( Data/Vector/Primitive/Mutable.hs, dist/build/Data/Vector/Primitive/Mutable.o )

Data/Vector/Primitive/Mutable.hs:53:1:
    Bad interface file: /home/builder/hackage-server/build-cache/tmp-install/lib/x86_64-linux-ghc-7.10.2/primitive-<IP_ADDRESS>-5Jnw7oEuYtM9dmKXelGXVb/Data/Primitive/ByteArray.hi
        /home/builder/hackage-server/build-cache/tmp-install/lib/x86_64-linux-ghc-7.10.2/primitive-<IP_ADDRESS>-5Jnw7oEuYtM9dmKXelGXVb/Data/Primitive/ByteArray.hi: openBinaryFile: does not exist (No such file or directory)

Data/Vector/Primitive/Mutable.hs:54:1:
    Bad interface file: /home/builder/hackage-server/build-cache/tmp-install/lib/x86_64-linux-ghc-7.10.2/primitive-<IP_ADDRESS>-5Jnw7oEuYtM9dmKXelGXVb/Data/Primitive.hi
        /home/builder/hackage-server/build-cache/tmp-install/lib/x86_64-linux-ghc-7.10.2/primitive-<IP_ADDRESS>-5Jnw7oEuYtM9dmKXelGXVb/Data/Primitive.hi: openBinaryFile: does not exist (No such file or directory)
Failed to install vector-<IP_ADDRESS>

I don't understand what this means, so I guess I'll take another swing at building them myself on windows.

Hackage built the docs for the new version <IP_ADDRESS> almost immediately and successfully.
Let us proclaim the mystery of hackage.


Video Won't Play

For my code, I want to play a video using the video-button-response plugin. This is the way that I am calling the plugin:
var video_instructions = {         type: 'video-button-response',         stimulus: "/static/video/instructional_video.mp4",         choices: ["Yes", "No"],         prompt: 'Did you understand the instructions?',         response_allowed_while_playing: false,         autoplay: true,     }
While the buttons appear, the video does not at all, even though the code claims to have preloaded the video. When I inspect the element, and look specifically at the video this is what the html output of this code is:

I would really appreciate it if someone could help me with this issue! Thanks

Hi @radrogue1 ,
The stimulus parameter for the video plugins should be an array (see docs here). This is because <video> elements in HTML allow for multiple source files to be specified so that if one kind of video files type can't be played on a particular browser a different one can be used instead.


Remove occupiesGeographically and occupiesGeographicallyPermanently?

During the inverse working group meeting, we noticed a potential redundancy with the following predicates.

Currently, we have isGeographicallyOccupiedBy and its inverse, occupiesGeographically. We also have isGeographicallyPermanentlyOccupiedBy and its inverse, occupiesGeographicallyPermanently.
While not formally specified, these predicates are likely intended to relate objects to spatial regions. (isGeographicallyContainedIn, a further property not on the list above, is likely intended to relate spatial regions to spatial regions.)
Arguably, hasPhysicalLocation could do the work that occupiesGeographically does, and for this reason we may want to remove occupiesGeographically and its inverse to avoid redundancy.
If we were to remove occupiesGeographicallyPermanently and its inverse, there is a question as to whether we would want to add an analogous hasPermanentPhysicalLocation.

See also #812 for a renaming proposal if we decide to keep them.

define hasPermanentPhysicalLocation to cover the sense of permanent location

I am in favor of this. The restriction on Landmark can be easily updated to say:
			[
				a owl:Restriction ;
				owl:onProperty gist:hasPermanentPhysicalLocation ;
				owl:someValuesFrom [
					a owl:Class ;
					owl:unionOf (
						gist:GeoRegion
						gist:GeoVolume
					) ;
				] ;
			]

There are subtle distinctions between this and to 'occupy' that one can make, but I don't think we need that for gist.

Granting the distinction between something occupying an entire space and merely being located within it, I wonder if we can rely on a single predicate like hasPhysicalLocation for both cases. In cases where it's more useful to know the precise chunk of space that something is occupying, you can dial up the specificity of the location.

We have to loosen the SVF restriction to gist:Place, since (1) presumably this will be a subproperty of gist:hasPhysicalLocation and (2) we want to include things like a sock being in a drawer, which I suppose is literally a geo region of some sort but not the sense in which gist uses geo regions.

Granting the distinction between something occupying an entire space and merely being located within it, I wonder if we can rely on a single predicate like hasPhysicalLocation for both cases. In cases where it's more useful to know the precise chunk of space that something is occupying, you can dial up the specificity of the location.

I agree that this could be important on some occasions. But is it universal enough to go in gist?

Peter: Permanence depends on time-frame. Need to define what we mean by permanent.
Dave: The permanent idea was to distinguish between, e.g., houses and cars. Now I think we should use a temporal relation if we want to time-delimit it, rather than two distinct predicates.
Boris: Agrees with Dave.
Mark: Agrees with removal of occupies predicates and dropping the permanent predicate
Michael: No way to distinguish Landmark.
Mark: Use annotations to make the permanent/impermanent distinction.
Rebecca: Do we need a subclass of TemporalRelation for locations?
Mark: (1) The temporal relation model is for gist extension, not gistCore. (2) Don't limit the usage of hasPhysicalLocation in annotations - let people use it the way they want.
DECISION:

Remove the occupies predicates
Add an annotation to hasPhysicalLocation that this could include either permanent or temporal relations, and to time-delimit it you should use an temporal relation (the last half is my addition, use it if you want).
Maybe change restriction on Landmark that it's a subclass of a SVF restriction on hasPhysicalLocation. [ NOTE: I no longer think this is a good idea, because it's already a subclass of Place. All places are located in places (with the exception of the universe, I suppose) so there's no need to add this to Landmark in particular.

See also #757