Duplicate Model in models.ts

Description
In the OpenAPI spec when tags request has properties and a component's name is the same as {tag name}Data
Example being tag of Ledger: generates LedgerService in the services.ts and generates LedgerData in the modals folder - and a component named LedgerData in the modals folder.
There are duplicate exports in the modals folder named LedgerData in this case.
OpenAPI specification (optional)
...
paths:
  /external/enrollments/seller/{sellerId}/buyer/{buyerBranchId}/ledger:
    get:
      operationId: getDataForLedgerIds
      summary: Returns the ledger sent status for a seller and buyer branch
      parameters:
        - $ref: '#/components/parameters/sellerIdParam'
        - $ref: '#/components/parameters/buyerBranchIdParam'
      tags:
        - ledger
      responses:
        '200':
          description: The ledger sent status for a seller and buyer branch
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/LedgerData'
        "404":
          description: The ledger data was not found
components:
  parameters:
    buyerBranchIdParam:
      name: buyerBranchId
      in: path
      required: true
      schema:
        $ref: "#/components/schemas/BuyerBranchId"
    sellerIdParam:
      name: sellerId
      in: path
      required: true
      schema:
        $ref: "#/components/schemas/SellerId"
  schemas:
    BuyerBranchId:
      description: The id of a buyer branch
      format: uuid
      type: string
    LedgerData:
      allOf:
        - $ref: '#/components/schemas/BuyerBranchId'
        - $ref: '#/components/schemas/SellerId'
        - $ref: '#/components/schemas/StoredEntity'
        - type: object
          properties:
            messageSendState:
              $ref: '#/components/schemas/LedgerStatus'
            timesMessagePublished:
              type: number
    LedgerStatus:
      description: State of the ledger send request
      type: string
      enum:
        - pending
        - sent
    SellerId:
      description: The id of a seller company
      format: uuid
      type: string
    StoredEntity:
      type: object
      required:
        - created
        - updated
      properties:
        created:
          type: number
          description: Timestamp of when the entity was first created
        updated:
          type: number
          description: Timestamp of when the entity was last updated
...

Configuration
openapi-ts --input api/openapi.yaml --output src/generated --name EnrollmentClient --client fetch
System information (optional)
macOS 14,
npm: 10.5.0
node: 21.7.1

And here I was thinking that's enough of a unique name. Any suggestions for naming service interfaces?

Good idea @seriouslag. I think we'll do some mix of OpenAPI/HeyAPI namespace to minimise the chance of conflict. If we keep failing, configuration might be necessary :(

We will be exporting a single namespace for all types – $OpenApiTs. Here's me hoping no one names their models with the same name 🤞


test updates due to cosmos adding screenshots in metadata label

Screenshots used to be removed in the label if they weren't populated, but now they are reported with screenshots: None.

:ship:


Add Support to block Swagger-ui via Spring Profiles

Based on this SO answer, it appears the recommended way to disable the swagger endpoint hosting is by using an @Profile annotation on the @Configuration class for Springfox. This works great for the swagger endpoints themselves. But how do you also disable the /swagger-ui.html and webjars/ endpoints with that same profile?
For example, if you're using these dependencies in build.gradle:
    compile 'io.springfox:springfox-swagger2:2.6.1'
    compile 'io.springfox:springfox-swagger-ui:2.6.1'

If you're using spring-boot, you can disable WebMvcAutoConfiguration and create an @Component bean that implements WebMvcConfigurerAdapter
@Configuration
@Profile("development,test")
public class WebConfig extends WebMvcConfigurerAdapter {

  @Override
  public void addResourceHandlers(ResourceHandlerRegistry registry) {
    registry.addResourceHandler("/public/**").addResourceLocations("classpath:/public/");
    ... code to register resource handlers for swagger-ui
  }
}

@dilipkrish Thanks for getting back to me, but I don't understand how to do what you're suggesting in a way that won't break Spring's REST support.
Yes, I am using Spring Boot (v1.5.3). I think you're suggesting that I change my main class annotation from @SpringBootApplication to @SpringBootApplication(exclude = WebMvcAutoConfiguration.class). Isn't that the most critical part of Spring Boot's autoconfiguration, which provides all of the base Servlet handling for Spring's @RestController support, which I'm of course using (and what  SpringFox is documenting)?
Also, you mentioned that I should create my own @Component and implement WebMvcConfigurerAdapter and override the addResourceHandlers(..) method. A couple questions on this:

What is this line for?
registry.addResourceHandler("/public/**").addResourceLocations("classpath:/public/"); I don't see a /public path used or referenced anywhere in the SpringFox docs, nor any resources in a public directory that'll end up in my classpath.
You mentioned I should add the code to register resource handlers for swagger-ui. Where do I find out what that code is? I've looked through the SpringFox source on GitHub and don't see this anywhere.

Also, the answer to this question might be a great thing for the SpringFox docs, as I think many people would be interested in how to do this.

+1

Isn't that the most critical part of Spring Boot's autoconfiguration, which provides all of the base Servlet handling for Spring's @RestController support, which I'm of course using (and what SpringFox is documenting)?

A little googling leads me to believe you can easily do this via a setting in your property/yaml file under specific profiles.
spring.resources.add-mappings=false

@dilipkrish Thank you. Helped me a lot

@vrudikov Care to post your final solution? Or maybe add it to the docs?

@pluttrell i've used spring.resources.add-mappings=false and it helped me a lot, because my server is API only. i don't have any web-resources there


Document speedrun

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1068
Originally created by @bencodezen on 2019-09-30 14:47:01

[x] Document process for speedrun
[x] Leave every screen on for at least 2 seconds after it changes so I can see it.
[x] Rename dogfood to speedrun for section title
[x] Do talk during the run, just don't delay the progress.
Try to use Postgres?

View 18 previous comments from the original issue on GitLab


Filter Problem Reports by Organisation

Presents the work in https://github.com/alphagov/support-api/pull/60 to the user.
Their are some TODO notes left by other members of the team. We'll address these when the team is back together next week.

:+1:


Added another YouTube video and collapsed the screenshots.

I'm going to wait until the next version is released before merging as this will break the current links in the application.

ok

Thank you!


Add internal ZIPing of individual tiles within tile pack MBTiles

As suggested in https://github.com/tangrams/tangram-es/issues/1552#issuecomment-310866480 it may improve overall file size and is a valid MBTiles option.

We can definitely do this, but the best way to improve overall file size is to zip the entire mbtiles file, not individual tiles.
Compressing individual tiles just means there's slightly less data to read out of sqlite for each tile.


[todo] Change anime source

Bahamut only allowed bot's request from Taiwan.
But this bot hosting at other country, so bot gets 403 status every times.

[ ] Find a API or website can use
[ ] Check that API can use and get all informations I needed
[ ] Test API at bot's code
[ ] Done!
[ ] Merge branch!

This issue will close.
I can't find any other API can use.
So this feature is archive


ci: run tests on pull requests

@martinm82 I just started looking at this and enabled to workflow to run.
You'll see that the workflow ran with errors.
If I get the tests to pass using the merge-pr-375 branch , we can get the merge done.

@martinm82 I just started looking at this and enabled to workflow to run. You'll see that the workflow ran with errors. If I get the tests to pass using the merge-pr-375 branch , we can get the merge done.

@decyjphr I would love to see the unit test passing.


3467 use headers for httpconnection on every request

The Code Generator now creates a second method called ExecuteAsync that allows to set contentHeaders, requestHeaders and authenticationHeaderValue.
Closes #3467

That is not actually what #3467 defines. We would want to generate proper type structures that can be used in the middleware.

Are you still interested in working on 3467?

Closing this PR since we got no feedback. If you are still interested in working on 3467 we would love to proceed on that and could setup a meeting.


903 - Approved Premises seeding job

This can be triggered by placing a CSV file in the /seed directory (in dev etc.) or ./seed when running locally with the following format:
id,name,addressLine1,postcode,totalBeds,notes,probationRegionId,localAuthorityAreaId,characteristicIds,status,apCode,qCode
...

The job is then started by sending a POST to /seed from within the container (or just from postman if running locally) with the following body (where our CSV file is named ap-upload.csv):
{
    "seedType": "approved_premises",
    "fileName": "ap-upload"
}

This will return a 202 Accepted to indicate the job has been started.  You can then monitor the progress of the job from the API logs.
An initial pass is made to ensure each row can be deserialized (e.g. are UUIDs well formed, do we have integers where we need them etc.)  If any rows fails this stage then no processing will happen and an error will be logged explaining the issue that needs to be remediated.
The processing then begins.  For each row, IDs are checked first to ensure they actually correspond to real entities (e.g. for Local Authority Areas and Characteristics) then the Premises is either created or updated if it already exists.
Processing happens synchronously, if any row fails the job will stop.

I'm largely happy with this approach, but could we add a helper script to run the seed? (using cURL or wget, or whatever the container has installed). I dunno if we could also automate the upload of the CSV to the container too, but I think that is something we do so rarely, that we should be more deliberate about that action.

I'm largely happy with this approach, but could we add a helper script to run the seed? (using cURL or wget, or whatever the container has installed). I dunno if we could also automate the upload of the CSV to the container too, but I think that is something we do so rarely, that we should be more deliberate about that action.

Have appended 2 commits to the scaffolding branch this one is based off: https://github.com/ministryofjustice/hmpps-approved-premises-api/pull/304


Revisit global else

Revisit else used for 0s interval problem analytics engine has. See if the changes can eliminate the need for a global else.
pkg/controller/experiment/reconcile.go ~ 140

@kimikowang I believe you addressed this in your integration test PR. Is that right?


Users expected cursor to auto-forward

we have been talking about this, it would be really good especially if you are not used to using a mouse

@GWSunderland @joanneSouthern We follow the GDS Design pattern on this that recommends not auto forwarding date fields as being the least problematic approach overall. I've added a link to this page to the page where this design pattern is discussed  so if you have any more specific observations on this topic, please add them, as they will help inform this design pattern

Not having the auto forward function is a minor inconvenience to sighted users. But in terms of accessibility, for people using a screen reader and keyboard to move around a screen (e.g. visually impaired), having the cursor auto-forward to the next field is unexpected behaviour and can make it almost impossible for them to complete the fields.

@Becktacular I thought that was the case. It's interesting though that the current pattern causes so many usability issues with this audience - especially those older users with poor motor skills, who struggle when they then have to edit the text they've entered into tiny input fields. I wonder if there is a solution out there can address both sets of needs?

Thanks for sharing this - it's an interesting example of the needs of two groups conflicting with each other. I also think this is one of those things we'll need to keep an eye on, as it's affected by users expectations, which can shift over time.

@sanjaypoyzer I assign this to you in case anything can be done to at least have the cursor located in the 1st box of the page by default.


Codify fails when the input yaml object names have a dash in it.

Took the example stateless app from https://kubernetes.io/docs/tasks/run-application/run-stateless-application-deployment/ and ran it against naml.
[...]
kind: Deployment
metadata:
  name: nginx-deployment
[...]

Ran this through naml:
kubectl get deployments -oyaml | naml c
Error during codify: unable to auto format code: 88:2: expected identifier on left side of :=2021-08-01T18:41:03-07:00 [Critical  ]  unable to auto format code: 88:2: expected identifier on left side of :=

I disabled gofmt to see the actual error and found this:
nginx-deploymentDeployment := &appsv1.Deployment{

We should probably trim illegal characters, though this may in rare circumstances cause a duplicate name. e.g. two deployments on the same system with names nginx-deployment vs nginxdeplolyment

Looks like we can safely rename all - characters in k8s object names to _ in go. K8s does not allow _ and go does not allow - in variable names.

pull requests accepted :)
https://github.com/kris-nova/naml/blob/main/codify/codify.go#L140

working on it :)

#46

fixed in #46

closed with #46
released binaries with the patch https://github.com/kris-nova/naml/releases/tag/0.2.4


feat: Evaluating prompts at scale with Gemini Batch Prediction API

Python notebook for evaluating prompts at scale with Gemini Batch Prediction API

Ok, only remaining item is the Looker Dashboard. Once it's publicly accessible, resolve this comment and I'll merge.
https://github.com/GoogleCloudPlatform/generative-ai/pull/907#discussion_r1695348335


Enable start of MPD player interface even w/o MPD running

Jukebox should start w/o errors even if MPD connection cannot be estabilshed at the time of startup. Implementation is simple by test re-connecting to MPD when an MPD command is issued.
This could allow to drop the mpd.service requirement from the jukebox.service configuration and allow to start the Jukebox process in parallel to MPD and gain boot up speed.
Based on idea from the discussion in #1703.

yes, I think this should tried. You aware that the MPD service will be started by the first access to the mpd.socket!? So there should be no dependency ("Requires or After") in the jukebox-daemon.service

Yes, I know. However, starting MPD takes times. Uur current code does not wait for MPD to start when it access the socket. We need to code that into our MPD interface. Only after that, we can change the service configuration file and remove the after=mpd constraint.

ok, thank you - fully agree now.


This plugin slows down Homebridge. Devices response is slow.

Describe the bug

Plugin works but it's too slow to respond after pressing the button.
I get the following comments in homebridge platform:

This plugin slows down Homebridge. The read handler for the characteristic 'On' didn't respond at all!. Please check that you properly call the callback! See https://git.io/JtMGR for more info.

This plugin slows down Homebridge. The read handler for the characteristic 'Hue' didn't respond at all!. Please check that you properly call the callback! See https://git.io/JtMGR for more info.

This plugin slows down Homebridge. The read handler for the characteristic 'Saturation' didn't respond at all!. Please check that you properly call the callback! See https://git.io/JtMGR for more info.

This plugin slows down Homebridge. The read handler for the characteristic 'Brightness' didn't respond at all!. Please check that you properly call the callback! See https://git.io/JtMGR for more info.

Steps To Reproduce

Plugin Version

@milo526/homebridge-tuya-web v1.1.1
Homebridge Config

{
"name": "TuyaWebPlatform",
"options": {
"username": "XXXXXXX",
"password": "XXXXXXX",
"countryCode": "30",
"platform": "smart_life"
},
"defaults": [
{
"device_type": "form"
}
],
"scenes": false,
"platform": "TuyaWebPlatform"
}
Device Config

Additional Context

Running homebridge on a Raspberry Pi 3 Model B

I’ve started to see this just recently. I agree that it’s also started being slow to respond to button presses


Does it support GitHub App?

Here is spec: https://developer.github.com/apps/building-integrations/setting-up-and-registering-github-apps/identifying-users-for-github-apps/

Github apps support OAuth, so yes.


Use latest git-sync version

also removes trailing whitespace.

@ghodss I do not have any objection in merging this PR.
Is it ok for you ?

@pieterlange sorry I am just getting around to this now. Thanks for the suggestion. It appears there is now a newer release v0.2.6 available, can you bump the version to that one instead?

@gregory-lyons This was mostly done in reference to https://github.com/kubernetes/git-sync/pull/58
Take care to include a known_hosts file in your ssh secrets if you're syncing over git+ssh (i think 99% of usecases).
The risk in this case involves cluster takeover if someone can trick your kube-applier+git-sync pod to connect to their repo (through DNS takeover or otherwise).

@pieterlange can you rebase your commits on top of the current master branch? (sorry, I should have merged yours first before my own #27).

@pieterlange can you rebase your commits on top of the current master branch? (sorry, I should have merged yours first before my own #27).

The commit itself is meaningless, just make sure you understand what's happening with git-sync.


Revert "Upgrade worker and serde-wasm-bindgen"

Based on #253 (merge that first).
Downgrade worker 0.0.14 -> 0.0.12 and serde-wasm-bindgen -> 0.5.0 -> 0.4.5. In particular:

Revert commit 92903d8bdfdd121df588cffa1c9d44a95c2dde97

daphne_worker: Address an API-breaking change in worker

We observed bugs in workers-rs 0.0.14 that we could not reproduce locally (wrangler dev), but only in Workers. We have not yet determined the root cause, but it seemed to be associated with known bugs in 0.0.14.
The next version, 0.0.15, is out, but we will need to test it thoroughly before we move to it. See #251.

Yup, it was previously based on top of it, but I've now rebased on main.


Bring threshold_crypto into fedimint org ?

Currently we're running with:
threshold_crypto = { git = "https://github.com/jkitman/threshold_crypto", branch = "upgrade-threshold-crypto-libs" }

Given how integral part it is, we should do something about it.
Do we expect it join with the upstream, or stay forked forever? If so, should we create fedimint_threshold_crypto? Make a new repo in github org for it? Or make a crate inside fedimint/fedimint?

@jkitman @elsirion

I think it was created by the Honey Badger folks, but the projects pretty much died in 2020.
We forked them them under the fedimint repo.  We should upstream my changes to those forks, the only thing preventing us has been the mock_crypto in threshold_crypto being broken after some lib upgrades that we never got around to fixing.

We should upstream my changes to those forks, the only thing preventing us has been the mock_crypto in threshold_crypto being broken after some lib upgrades that we never got around to fixing.

Technical debt. :moneybag:

Let's still move it into the org and track the tech debt.

We can close, maybe one day we'll have time for #515


Use Underscore.js to simplify add() and remove() in Backbone.Collection

I made this change and Pull Request from GH web interface so haven't had a chance to run the tests against this. Unless the tests put expectations on the implementation, this shouldn't change anything (I tested it in Webkit Inspector).
IMO, it makes the code smaller and cleaner and a bit DRYer.
When I get to a decent computer with enough time to spare, I'll check the tests to be sure.

By having to _.flatten everything on the way in (and wrapping it in an array), there's a MAJOR performance degradation.
Here's a jsperf with comparing your patch to whats in 0.5.3: http://jsperf.com/backbone-issue-709

Well then ... fair enough.
I'm going to have to dive into the implementation of flatten to see why it's so much slower. I could understand that degradation if it was a very nested array, but I find that surprising in this case.
Regardless, definitely not worth this change. Thanks for taking the time :)


skip SI_ TABL objects if they are empty

#219
@ed-holland can you help testing this change?

Sure... will find some time for it today.

PR branch code gives this error:

The LV_STRING which is retrieved from the file does not contain a DD02V tag (from si_fkkopr.tabl.xml).
<?xml version="1.0" encoding="utf-8"?>#<abapGit version="v1.0.0" serializer="LCL_OBJECT_TABL" serializer_version="v1.0.0"># <asx:abap version="1.0" xmlns:asx="http://www.sap.com/abapxml"/>#</abapGit>

hmm, try setting a breakpoint

hmm, try setting a breakpoint

That is how i got the LV_STRING. It did not replace anything so no fields where added.

okay, new plan
https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-us/abenddic_customizing_includes.htm
if SI_, includes are not found, abaplint will continue without errors,
https://github.com/abaplint/abaplint/blob/master/packages/core/src/objects/table.ts#L82

try again, logic updated

In SCI, the issue is now gone. Thx.
I've noticed two side effects:

AbapLint now shows the error (did not before)

Local Code shows difference with Remote Code

Is this caused by this PR or by the XML reduction also reducing namespace code?

1: si_fkkopr should not be part of deps anymore, did you update deps? Or perhaps there is a bug in it so it does not delete objects
2: I'm guessing its due to https://github.com/abaplint/abaplint-sci-client/pull/205

Updated AG/SCI to latest.
I've checked it using the deps_list utility and the includes are not generated anymore.
After the nightly rebuild of the Deps, they are also gone from the Dependency Repository. All is fine now.

Also the local differences are gone.


Add temporary rake task to unpublish /api

We are retiring the Content API. The application used to publish a
special route: /api. Since the application has now been retired, we
need to unpublish that content item.
This commit adds a temporary rake task that will unpublish the enpoint.
Note:
Ideally, this should have been done in the app itself. When I realised I
needed to unpublish it, the app was no longer deployable, which is why
I'm creating this temporary rake task in content-tagger.
After the rake task runs in production, we should delete it.
Trello: https://trello.com/c/2MF97xce/154-retire-content-api

I suspect that this doesn't work because the item is owned by content_api, so you need the original content_api publishing-api token for this. Not sure tho.

@tijmenb going to try it now... will let you know if any problems.


Addresses issue with duplicate keys when multiple arches

When the api call constants.get_blueprints_deps returns a list of dependencies, if a package has more than one arch, then each arch is a separate item in the array of dependencies. Since the list item key is based on the name, this results in issues when rendering the list of contents as they are updated due to the key not being unique.
This update removes duplicates in the list of selected components and dependencies.

Codecov Report

Merging #597 into master will decrease coverage by 0.21%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #597      +/-   ##
==========================================
- Coverage    73.4%   73.18%   -0.22%
==========================================
  Files          66       66
  Lines        3128     3133       +5
  Branches      597      598       +1
==========================================
- Hits         2296     2293       -3
- Misses        832      840       +8

Impacted Files
Coverage Δ

core/sagas/blueprints.js
67.79% <100%> (+0.35%)
:arrow_up:

components/ListView/ListItemImages.js
58.73% <0%> (-3.18%)
:arrow_down:

core/sagas/inputs.js
71.42% <0%> (-3.07%)
:arrow_down:

components/ListView/ListItemComponents.js
80% <0%> (-2.23%)
:arrow_down:

core/selectors.js
92.96% <0%> (-0.79%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f2ba08...340865d. Read the comment docs.


No documentation of create_xls.py

In GitLab by @hlux on Apr 24, 2018, 14:42
@mkovari could you please write a documentation for the create_xls.py utility in the PROCESS user guide.
Thanks,
Hanni

create_xls.py no longer exists within the repo and mfile_to_csv.py is still present. If more functionality is to be added then it can be done there.


docs: fetch: add --max-size and --types

Fixes #4668

Happy to address any additional comments in a followup.

@efiop  there are some indentation / style issues?

Yep, my fault, sorry 🤦 Fixing


[Feature]: simple server/client without http3

Before request a new feature

[X] I have searched the issues of this repository and believe that this is not a duplicate.

Describe the feature you'd like supported
Can provide some demo such as echo server/client which is not including http3.
Describe alternatives you've considered
No response
Additional context
No response

OK, we'll provide a simple sample next month.

test_client with -N option might satisfy your requirement, with a self-defined ALPN named transport, providing the features of rfc8999 to rfc9002.


Don't need "calculated variables" to be calculated every time we create project card.

I'm wondering if we need to create the calculated variables?
We shouldn't be creating project cards for them so I'm wondering what the reasoning was?
If the reason is because we are reading in a log-file with calculated properties, then we should just ignore those properties as that would probably be a lot quicker than doing a bunch of GIS joins and we are starting to have issues with performance.
https://github.com/wsp-sag/Lasso/blob/6bdfeccffd2d3b2b35c4583f244d94b0ca320abd/lasso/project.py#L231

Should work now. St Paul network read in for project card creation is a couple seconds on my laptop.


ISPN-7708 Use UnsuccesfulResponse to signalize command failure

https://issues.jboss.org/browse/ISPN-7708

@rvansa I guess the WriteResponse can be removed and the triangle can use the Successful and Unsuccessful command. wdyt?

@pruivo OK, it seems we can remove the WriteResponse and TriangleResponseGenerator. Should I do that in this PR or in a follow-up one?

@rvansa if you don't mind, it can be done in this PR. But if you are busy, I'll do it after it is integrated :)

@pruivo Rebased & updated.

@rvansa it looks good but I'm not 100% convinced that it works with the triangle because the triangle always need a reply from the primary owner. Let me write some tests to double check if everything is ok.

everything is fine. it is ready to go. just waiting for CI :+1:

@pruivo Will you add those extra tests when integrating this PR, too?

@danberindei That's what you get when running with trace logging by default :) Fixed.

@rvansa I haven't added any test. I guess it is good to go...

integrated! thanks @rvansa !


Incorrect parsing for URLs with parenthesis in them

Given a file that includes:
// https://en.wikipedia.org/wiki/ANSI_escape_code#SGR_(Select_Graphic_Rendition)_parameters

I would expect https://en.wikipedia.org/wiki/ANSI_escape_code#SGR_(Select_Graphic_Rendition)_parameters to be parsed as URL. However, when I inspect the parse tree, I see that it says:
(comment ; [28, 0] - [28, 91]
  (source ; [28, 0] - [28, 91]
    (uri))) ; [28, 3] - [28, 79]

it considers it as URL up to, but not including, the closing parenthesis: https://en.wikipedia.org/wiki/ANSI_escape_code#SGR_(Select_Graphic_Rendition.

not a go parser issue

My bad, sorry for the noise & thank you for the quick reply.


Improve failure message for IterableAssert.contains* when collection size or expected size is 1

Feature summary
See year: 2019 sample in https://truth.dev/comparison#failure-messages
Rule 1) When the size of the expected collection is 1, then there's no point in printing "but some elements were not found".
Of course, they were not found, and the sole element has already been displayed in "to contain.." block.
Rule 2) The same goes for the case when actual collection has size of 1. If it did not match, then there's no point in printing "and others were not expected".
Example
    assertThat(
      Collections.singletonList(
        "year: 2019\n" +
          "month: 7\n" +
          "day: 15\n"
      )
    )
      .containsExactly(
        "year: 2019\n" +
          "month: 6\n" +
          "day: 30\n"
      );

Current output:
java.lang.AssertionError:
Expecting actual:
  ["year: 2019
month: 7
day: 15
"]
to contain exactly (and in same order):
  ["year: 2019
month: 6
day: 30
"]
but some elements were not found: <-- should be removed as per Rule 1
  ["year: 2019
month: 6
day: 30
"]
and others were not expected: <-- should be removed as per Rule 2
  ["year: 2019
month: 7
day: 15
"]

	at org.assertj.core.error.AssertionErrorCreator.assertionError(AssertionErrorCreator.java:93)
	at org.assertj.core.internal.Failures.failure(Failures.java:126)
	at org.assertj.core.internal.Iterables.shouldContainExactlyWithDiffAssertionError(Iterables.java:1150)
	at org.assertj.core.internal.Iterables.assertContainsExactly(Iterables.java:1141)
	at org.assertj.core.api.AbstractIterableAssert.containsExactlyForProxy(AbstractIterableAssert.java:426)
	at org.assertj.core.api.AbstractIterableAssert.containsExactly(AbstractIterableAssert.java:419)

Hi,
I think this issue should be broken down into smaller issues as contains* has many implementations.


Feature pull request

My first pull request for "Hello Microverse" mini project in module #1 for review before merging to main branch.

Good morning. I am awaiting a review.
On Thu, Jun 1, 2023 at 4:32 AM Abraham Christopher @.***>
wrote:

@.**** commented on this pull request.
In readme.md
https://github.com/Drew246/firstMicroProject/pull/1#discussion_r1212793217
:

+

+# 📗 Table of Contents
+
+- 📖 About the Project
+- 👥 Authors
+
+
+
+
+# 📖 [Hello Microverse]
+
+
+
+[Hello Microverse] is my first mniproject from module 1. This project serves to familiarize students with Git, Github,gitflow and linters.
+
+
+
+
+## 👥 Authors
+
+👤 Andrew McCollin
+
+- GitHub: (https://github.com/Drew246)
+- LinkedIn: [www.linkedin.com/in/andrew-mccollin)
+
Hello @Drew246 https://github.com/Drew246 , Kindly note that
maintaining a professional tone throughout the README, including the header
section, is a requirement. In instances where the content does not
currently apply to the project, it can be replaced with 'N/A'.
For further guidance and to ensure adherence to the expected standards, I
recommend consulting the Microverse Readme Template
https://github.com/microverseinc/readme-template. 👍🏿
—
Reply to this email directly, view it on GitHub
https://github.com/Drew246/firstMicroProject/pull/1#discussion_r1212793217,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATMBYTQWEFEBTZVKND4H3IDXJBHSVANCNFSM6AAAAAAYWOPRKE
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thank you very much.
On Fri, Jun 2, 2023, 11:15 PM Emmanuel Orji-Ihuoma @.***>
wrote:

@.**** approved this pull request.
Hi @Drew246 https://github.com/Drew246,
Status: Approved ✅
Your project is complete! There is nothing else to say other than... it's
time to merge it [image: :shipit:]
Congratulations! 🎉
https://user-images.githubusercontent.com/20554583/220871050-9893fe6a-46a0-42a3-8a44-46ac0f7f1154.gif
Good Highlights✔

Requested changes have been implemented

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something
is not 100% clear.
Please, remember to tag me in your question so I can receive the
notification.
As described in the Code reviews limits policy
https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a
limited number of reviews per project (check the exact number in your
Dashboard). If you think that the code review was not fair, you can request
a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.
—
Reply to this email directly, view it on GitHub
https://github.com/Drew246/firstMicroProject/pull/1#pullrequestreview-1458827728,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATMBYTVGMZD4HV4HOD7MEG3XJKT4VANCNFSM6AAAAAAYWOPRKE
.
You are receiving this because you were mentioned.Message ID:
@.***>


Did you close the forum

Hi,
Did you close the forum or did we need an authorization to access? Thanks

The forum was not intentionally closed. From what I understand, the community website was hacked, and it is not yet back to full functionality.

Hope for more good news!


Undo cyclic dev-dependency that is confusing rust-analyzer

c533b3f9b160e33b18adc460275ab6e3f459625d introduced a cyclic dev-dependency so common could do some tests via host, which has been making rust-analyzer very sad -- this is something cargo apparently supports but only in not-very-reliable ways that are often confusing and apparently confuse r-a.
Easy fix: move the tests a layer down to host.

:tada::tada::tada: Thank you @graydon, you are a true life saver :sob:

Was this causing rust-analyzer to break or was it just a warning. Whilst I saw the warning too it didn't seem to impact rust-analyzer for me, but I might not have noticed the impact.
Related issues on rust-analyzer appear to be:

https://github.com/rust-lang/rust-analyzer/issues/2414
https://github.com/rust-lang/rust-analyzer/issues/8330

The inconvenience of this change is that tests in the host crate will with the CODEOWNERS definition require review from the core team, so now all changes that are tested in common will require review from the core team.
Maybe we should instead have these in a soroban-env-common-tests crate that isn't published?

Maybe we should instead have these in a soroban-env-common-tests crate that isn't published?

I don't think we should hastily spend time on this, but it seems like our crate setup is a bit artificial because:

some things in common can only be tested in SDK
some things in common can only be tested in host

@leighmcculloch it was causing r-a to emit hard errors, not warnings, and fail to resolve / typecheck / allow navigation of a substantial fraction of imported types (all definitions imported from common). It was fairly unusable for editing the host crate.
Concerning the permission-to-edit-tests-in-the-host issue: I have no problem with any of the following solutions:

making the soroban-env-host/tests directory more widely co-owned (CODEOWNERS allows overrides on subdirs)
adding a special co-owned subdir of tests
adding a new unpublished testing crate
moving these tests to the SDK so they're under your purview

Got it. All good ideas I think. Let's not move these tests to the SDK though, that just means this code can break here and be found to be broken only when the SDK is updated.
I'm leaning towards embracing the integration test mindset and having a special co-owned subdir of tests, but have them in a separate crate which is like the "here lives the integration tests" so that tests in the host crate are clearly more focused on unit testing the host itself.

Thanks for fixing this.


Minikube deployment error: unable to recognize "default.yaml": no matches for kind "VirtualService" in version "networking.istio.io/v1alpha3"

Get started: https://www.kubeflow.org/docs/started/getting-started-minikube/
after
${KUBEFLOW_SRC}/scripts/kfctl.sh apply all

such output:
+ ENV_FILE=env.sh
+ SKIP_INIT_PROJECT=false
+ GKE_API_VERSION=v1beta1
+ GCP_DEFAULT_ZONE=us-east1-d
+++ dirname /home/alex/tmp/kubeflow/scripts/kfctl.sh
++ cd /home/alex/tmp/kubeflow/scripts
++ pwd
+ DIR=/home/alex/tmp/kubeflow/scripts
+ source /home/alex/tmp/kubeflow/scripts/util.sh
+ source /home/alex/tmp/kubeflow/scripts/gke/util.sh
++ set -xe
+ source /home/alex/tmp/kubeflow/scripts/azure/util.sh
++ set -xe
+ source /home/alex/tmp/kubeflow/scripts/aws/util.sh
++ set -xe
+ source /home/alex/tmp/kubeflow/scripts/util-minikube.sh
++ RED='\033[0;31m'
++ GREEN='\033[0;32m'
++ YELLOW='\033[0;33m'
++ NC='\033[0m'
++ MOUNT_LOCAL=true
+ INPUT=()
+ FORMAT=()
+ export 'KUBEFLOW_COMPONENTS="ambassador","jupyter","notebook-controller","jupyter-web-app","profiles","centraldashboard","tf-job-operator","pytorch-operator","spartakus","argo","pipeline"'
+ KUBEFLOW_COMPONENTS='"ambassador","jupyter","notebook-controller","jupyter-web-app","profiles","centraldashboard","tf-job-operator","pytorch-operator","spartakus","argo","pipeline"'
+ export KUBEFLOW_EXTENDEDINFO=false
+ KUBEFLOW_EXTENDEDINFO=false
+ which envsubst
+ [[ 2 -lt 2 ]]
+ COMMAND=apply
+ WHAT=all
+ shift
+ shift
+ main
+ [[ apply == \i\n\i\t ]]
+ source env.sh
++ PLATFORM=minikube
++ KUBEFLOW_REPO=/home/alex/tmp/kubeflow
++ KUBEFLOW_VERSION=master
++ KUBEFLOW_COMPONENTS='"ambassador","jupyter","notebook-controller","jupyter-web-app","profiles","centraldashboard","tf-job-operator","pytorch-operator","spartakus","argo","pipeline"'
++ KUBEFLOW_EXTENDEDINFO=false
++ KUBEFLOW_KS_DIR=/home/alex/tmp/kubeflow/kfapp/ks_app
++ KUBEFLOW_DOCKER_REGISTRY=
++ DOCKER_REGISTRY_KATIB_NAMESPACE=
++ CLUSTER_ADMIN=alex
++ K8S_NAMESPACE=kubeflow
++ KUBEFLOW_PLATFORM=minikube
++ MOUNT_LOCAL=true
++ DEPLOYMENT_NAME=kfapp
+ [[ -z apply ]]
+ [[ -z all ]]
+ check_installed_deps
+ kf_deps=("ks" "kubectl")
+ declare -a kf_deps
+ kf_dep=ks
+ min_ks_ver=0.11.0
++ ks version
++ cut '-d ' -f3
++ head -1
+ ks_ver=0.13.1
+ '[' 0.13.1 '<' 0.11.0 ']'
+ [[ minikube == \g\c\p ]]
+ [[ minikube == \a\z\u\r\e ]]
+ [[ minikube == \a\w\s ]]
+ [[ apply == \g\e\n\e\r\a\t\e ]]
+ [[ apply == \a\p\p\l\y ]]
+ [[ all == \p\l\a\t\f\o\r\m ]]
+ [[ all == \a\l\l ]]
+ [[ minikube == \g\c\p ]]
+ [[ minikube == \a\z\u\r\e ]]
+ [[ minikube == \a\w\s ]]
+ [[ all == \k\8\s ]]
+ [[ all == \a\l\l ]]
+ ksApply
+ pushd /home/alex/tmp/kubeflow/kfapp/ks_app
~/tmp/kubeflow/kfapp/ks_app ~/tmp/kubeflow/kfapp
+ createNamespace
+ set +e
++ kubectl get namespace kubeflow
+ O='NAME       STATUS    AGE
kubeflow   Active    1d'
+ RESULT=0
+ set -e
+ [[ 0 -eq 0 ]]
+ echo 'namespace kubeflow already exists'
namespace kubeflow already exists
+ createKsEnv
+ pushd /home/alex/tmp/kubeflow/kfapp/ks_app
~/tmp/kubeflow/kfapp/ks_app ~/tmp/kubeflow/kfapp/ks_app ~/tmp/kubeflow/kfapp
+ set +e
++ ks env describe default
+ O='name: default
kubernetesversion: v1.14.1
path: default
destination:
  server: https://<IP_ADDRESS>:8443
  namespace: kubeflow
targets: []
libraries: {}'
+ RESULT=0
+ set -e
+ '[' 0 -eq 0 ']'
+ echo environment default already exists
environment default already exists
+ popd
~/tmp/kubeflow/kfapp/ks_app ~/tmp/kubeflow/kfapp
+ [[ minikube != \m\i\n\i\k\u\b\e ]]
+ popd
~/tmp/kubeflow/kfapp
+ [[ minikube == \g\c\p ]]
+ [[ minikube == \a\w\s ]]
+ pushd /home/alex/tmp/kubeflow/kfapp/ks_app
~/tmp/kubeflow/kfapp/ks_app ~/tmp/kubeflow/kfapp
+ ks param set application name kfapp
+ [[ false == true ]]
+ ks param set application components '["ambassador","jupyter","notebook-controller","jupyter-web-app","profiles","centraldashboard","tf-job-operator","pytorch-operator","spartakus","argo","pipeline"]'
+ ks show default -c metacontroller -c application
+ kubectl apply --validate=false -f default.yaml
customresourcedefinition.apiextensions.k8s.io "applications.app.k8s.io" configured
customresourcedefinition.apiextensions.k8s.io "compositecontrollers.metacontroller.k8s.io" configured
customresourcedefinition.apiextensions.k8s.io "controllerrevisions.metacontroller.k8s.io" configured
customresourcedefinition.apiextensions.k8s.io "decoratorcontrollers.metacontroller.k8s.io" configured
customresourcedefinition.apiextensions.k8s.io "notebooks.kubeflow.org" configured
customresourcedefinition.apiextensions.k8s.io "profiles.kubeflow.org" configured
customresourcedefinition.apiextensions.k8s.io "pytorchjobs.kubeflow.org" configured
customresourcedefinition.apiextensions.k8s.io "scheduledworkflows.kubeflow.org" configured
customresourcedefinition.apiextensions.k8s.io "tfjobs.kubeflow.org" configured
customresourcedefinition.apiextensions.k8s.io "viewers.kubeflow.org" configured
customresourcedefinition.apiextensions.k8s.io "workflows.argoproj.io" configured
clusterrole.rbac.authorization.k8s.io "centraldashboard" configured
clusterrole.rbac.authorization.k8s.io "jupyter-web-app-cluster-role" configured
clusterrole.rbac.authorization.k8s.io "notebooks-controller" configured
clusterrole.rbac.authorization.k8s.io "ambassador" configured
clusterrole.rbac.authorization.k8s.io "argo" configured
clusterrole.rbac.authorization.k8s.io "argo-ui" configured
clusterrole.rbac.authorization.k8s.io "ml-pipeline-persistenceagent" configured
clusterrole.rbac.authorization.k8s.io "ml-pipeline-viewer-controller-role" configured
clusterrole.rbac.authorization.k8s.io "pipeline-runner" configured
clusterrole.rbac.authorization.k8s.io "pytorch-operator" configured
clusterrole.rbac.authorization.k8s.io "spartakus" configured
clusterrole.rbac.authorization.k8s.io "tf-job-dashboard" configured
clusterrole.rbac.authorization.k8s.io "tf-job-operator" configured
clusterrolebinding.rbac.authorization.k8s.io "centraldashboard" configured
clusterrolebinding.rbac.authorization.k8s.io "jupyter-web-app-binding" configured
clusterrolebinding.rbac.authorization.k8s.io "meta-controller-cluster-role-binding" configured
clusterrolebinding.rbac.authorization.k8s.io "notebooks-controller" configured
clusterrolebinding.rbac.authorization.k8s.io "profile-controller-cluster-role-binding" configured
clusterrolebinding.rbac.authorization.k8s.io "ambassador" configured
clusterrolebinding.rbac.authorization.k8s.io "argo" configured
clusterrolebinding.rbac.authorization.k8s.io "argo-ui" configured
clusterrolebinding.rbac.authorization.k8s.io "ml-pipeline-persistenceagent" configured
clusterrolebinding.rbac.authorization.k8s.io "ml-pipeline-scheduledworkflow" configured
clusterrolebinding.rbac.authorization.k8s.io "ml-pipeline-viewer-crd-role-binding" configured
clusterrolebinding.rbac.authorization.k8s.io "pipeline-runner" configured
clusterrolebinding.rbac.authorization.k8s.io "pytorch-operator" configured
clusterrolebinding.rbac.authorization.k8s.io "spartakus" configured
clusterrolebinding.rbac.authorization.k8s.io "tf-job-dashboard" configured
clusterrolebinding.rbac.authorization.k8s.io "tf-job-operator" configured
compositecontroller.metacontroller.k8s.io "kfapp-controller" configured
secret "mlpipeline-minio-artifact" unchanged
configmap "jupyter-config" unchanged
configmap "jupyter-web-app-config" unchanged
configmap "kfapp-controller-hooks" unchanged
configmap "workflow-controller-configmap" unchanged
persistentvolumeclaim "minio-pvc" unchanged
persistentvolumeclaim "mysql-pv-claim" unchanged
serviceaccount "ambassador" unchanged
serviceaccount "argo" unchanged
serviceaccount "argo-ui" unchanged
serviceaccount "centraldashboard" unchanged
serviceaccount "default-editor" unchanged
serviceaccount "jupyter" unchanged
serviceaccount "jupyter-notebook" unchanged
serviceaccount "jupyter-web-app" unchanged
serviceaccount "meta-controller-service" unchanged
serviceaccount "ml-pipeline" unchanged
serviceaccount "ml-pipeline-persistenceagent" unchanged
serviceaccount "ml-pipeline-scheduledworkflow" unchanged
serviceaccount "ml-pipeline-ui" unchanged
serviceaccount "ml-pipeline-viewer-crd-service-account" unchanged
serviceaccount "notebook-controller" unchanged
serviceaccount "pipeline-runner" unchanged
serviceaccount "profiles" unchanged
serviceaccount "pytorch-operator" unchanged
serviceaccount "spartakus" unchanged
serviceaccount "tf-job-dashboard" unchanged
serviceaccount "tf-job-operator" unchanged
role.rbac.authorization.k8s.io "profiles" unchanged
role.rbac.authorization.k8s.io "centraldashboard" unchanged
role.rbac.authorization.k8s.io "jupyter-notebook-role" unchanged
role.rbac.authorization.k8s.io "jupyter-role" unchanged
role.rbac.authorization.k8s.io "ml-pipeline" unchanged
role.rbac.authorization.k8s.io "ml-pipeline-scheduledworkflow" unchanged
role.rbac.authorization.k8s.io "ml-pipeline-ui" unchanged
rolebinding.rbac.authorization.k8s.io "profiles" unchanged
rolebinding.rbac.authorization.k8s.io "centraldashboard" unchanged
rolebinding.rbac.authorization.k8s.io "default-editor-role-binding" unchanged
rolebinding.rbac.authorization.k8s.io "jupyter-notebook-role" unchanged
rolebinding.rbac.authorization.k8s.io "jupyter-role" unchanged
rolebinding.rbac.authorization.k8s.io "ml-pipeline" unchanged
rolebinding.rbac.authorization.k8s.io "ml-pipeline-ui" unchanged
service "ambassador" unchanged
service "ambassador-admin" unchanged
service "argo-ui" unchanged
service "centraldashboard" unchanged
service "jupyter-0" unchanged
service "jupyter-lb" unchanged
service "jupyter-web-app" unchanged
service "kfam" unchanged
service "kfapp-controller" unchanged
service "minio-service" unchanged
service "ml-pipeline" unchanged
service "ml-pipeline-tensorboard-ui" unchanged
service "ml-pipeline-ui" unchanged
service "mysql" unchanged
service "notebooks-controller" unchanged
service "pytorch-operator" unchanged
service "tf-job-dashboard" unchanged
service "tf-job-operator" unchanged
deployment.apps "jupyter-web-app" unchanged
deployment.apps "kfam" unchanged
deployment.apps "profiles" unchanged
deployment.apps "ambassador" configured
deployment.apps "kfapp-controller" unchanged
deployment.apps "minio" unchanged
deployment.apps "notebooks-controller" unchanged
deployment.apps "ml-pipeline" unchanged
deployment.apps "ml-pipeline-persistenceagent" unchanged
deployment.apps "ml-pipeline-scheduledworkflow" unchanged
deployment.apps "ml-pipeline-ui" unchanged
deployment.apps "ml-pipeline-viewer-controller-deployment" unchanged
deployment.apps "mysql" unchanged
deployment.extensions "argo-ui" unchanged
deployment.extensions "centraldashboard" unchanged
deployment.extensions "pytorch-operator" unchanged
deployment.extensions "spartakus-volunteer" unchanged
deployment.extensions "tf-job-dashboard" unchanged
deployment.extensions "tf-job-operator" unchanged
deployment.extensions "workflow-controller" unchanged
statefulset.apps "jupyter" unchanged
statefulset.apps "metacontroller" unchanged
application.app.k8s.io "kfapp" configured
error: unable to recognize "default.yaml": no matches for kind "VirtualService" in version "networking.istio.io/v1alpha3"

As result - I have no deployments in minikube dashboard

Thanks for reporting this error. The Minikube docs are out of date. A doc update is in progress. Please take a look at this issue for further info, including a quick guide to what the doc should say:
https://github.com/kubeflow/website/issues/1023

I'll close this issue, as it's a duplicate of https://github.com/kubeflow/website/issues/1023
/close


fix: resolve redundant JSObject action saving

Description
Fixes https://github.com/appsmithorg/appsmith/issues/36879
Automation
/ok-to-test<EMAIL_ADDRESS>:mag: Cypress test results

[!IMPORTANT]
🟣 🟣 🟣 Your tests are running.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11436445192
Commit: c8be91e3281e913fafc3cadf2ac24218ea021d22
Workflow: PR Automation test suite
Tags: @tag.JS
Spec: ``
Mon, 21 Oct 2024 08:42:35 UTC

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[ ] No

Summary by CodeRabbit

New Features

Introduced enhanced methods for creating, updating, and moving action collections, improving validation and consistency.
Added a new interface for better handling of JavaScript actions and variables, enhancing data processing efficiency.

Bug Fixes

Improved error reporting from pages to collections, ensuring accurate tracking of action errors.

Documentation

Updated comments and documentation for clarity on new functionalities and changes.

/build-deploy-preview skip-tests=true

Executing both functions always executes the later part, according to this we show an error for the 2nd function. We should avoid overriding the first function definition.

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true

@rishabhrathod01 Should we add unit test cases for the changes?

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true


ART deprecation

Hey everyone,
I became a react-native-art maintainer some time ago when I extracted this module as a part of the Lean Core effort. From day zero, I've noticed that there were a lot of legacy code and the library itself relied on old and no longer maintained library - art. This makes it challenging to maintain this lib, especially for somebody who didn't create it. react-native-art was never officially documented in react-native which made me do a lot of calculated guesses - tried to do my best to create it, but I'm still not sure that it is 100% correct and complete.
React-native-svg is a much better alternative to ART and provides a lot more features and community support. Also, I don't see any point in splitting the community and maintaining two libraries that are used for the same exact reasons, and to achieve the same goals.
My only worry is that ART is still generating noticeable traffic on NPM, mainly because of react-native-progress.
Going forward into the future, I think we should deprecate react-native-art in favor of react-native-svg. WDYT?

i'm fully on board with this. the library is not necessary and contributors would have higher impact spending their time elsewhere. from react-native-progress:

I’ll accept a PR migrating to the svg lib. Reason I went with ART to begin with was ease of integration which is now lost anyways and we’re just stuck with the bugs.
— @oblador, maintainer of react-native-progress (among other things)

it would help for deprecation of this library if someone in the community helped rewrite react-native-progress to use react-native-svg instead of react-native-art. although, perhaps deprecating ART would motivate people to do it.

My only worry is that ART is still generating noticeable traffic on NPM, mainly because of react-native-progress.

Just a note that react-native-progress recently migrated its dependency to react-native-svg in its latest release, if that were to influence your decision to deprecate react-native-art.

@Esemesek @brentvatne Since react-native-progress migrated to react-native-svg there are only a handful of dependents with a somewhat considerable amount of weekly downloads left:

react-qr-code (20.937 weekly downloads)
Migration to RNSVG looks to be as easy as switching out a few imports.
react-native-barcode-builder (6.532 weekly downloads)
Already has an open PR for migrating to RNSVG.
react-native-sparkline (2.058 weekly downloads)
Migration to RNSVG looks to be possible without too much hassle.
@momo-platform/component-kits (1.656 weekly downloads)
Doesn't seem to be open source, not sure what ART is used for in this package.
react-native-neomorph-shadows (1.110 weekly downloads)
Migrated from RNSVG to ART a while ago for performance reasons, so probably still needs ART.

I think it would be safe to add a deprecation notice to the README of this package right now and refer to react-native-svg instead.
Once the majority of people have upgraded react-native-progress from 4.1.2 to 5.0.0 and react-qr-code has migrated to RNSVG you could go further and add a deprecation notice to the npm package itself.


docs: add new sanitize strategies

resolve #1575
provides some information about sce and sceParameters sanitize strategies

@adarrra  Thank you for the nice contribution.

Picked as 8d7eeb0


Is there any way to download the Account statement as a .csv file?

Hello Matheus,
is it possible to indicate the location in Degiro’s website of the csv you are looking for ?
Thanks

@Chavithra
Login > Activity > Account statement > Export

This table content can be fetched using the method get_account_overview.
More information about get_account_overview method is available in the README.
Can add a method to fetch directly the csv if you are interested by this feature.

fetching the csv file file directly would be very interesting

fetching the csv file file directly would be very interesting

Ok will take a look at that when I will have some time.
Will update this issue once the feature is added.

get_account_overview does not provide the ISIN values, does it?

The endpoint called by get_account_overview method, does not provide the ISIN.
It only provides what you can see in the Account statement table in the website and the productId.

Humm, I see. Thank you.
This is what the csv file provides.

It has some extra data on top of the get_account_overview method.

Ok I see  get_account_overview  provide productId instead of this columns from the csv :

Product
ISIN

The rest of the fields seems to be there.

I have published a new version of this library.
The following method was added :

get_cash_account_report

This method is documented.
This should let you export in CSV among other formats.

Closing this issue.
Feel free to open a new one if you have others questions.


Help

Not working in Android 12!

Could be related to https://source.android.com/docs/security/test/tagged-pointers

Could you re-run with RUST_LOG=debug ./termux-adb and attach logs from $TMPDIR? There should be adb..log and also termux-adb..log.
Anyway, that line about "pointer tag" is really peculiar. Nothing like that on my Pixel 3a (with Android 12 too).
What kind of a device do you have actually?

Realme 7 RMX2151

Ok, if I can take a look at the logs, maybe I'll see where the problem is. Judging from the screenshot, adb server doesn't crash immediately but it doesn't become ready either.

Ok, if I can take a look at the logs, maybe I'll see where the problem is. Judging from the screenshot, adb server doesn't crash immediately but it doesn't become ready either.

using /dev/bus/usb/001/024: fd = 7
cannot connect to daemon at tcp:5037: Connection refused
DEBUG: dlsym works!
[2022-11-06T13:35:21Z INFO  adbhooks] listening on socket fd 4
* daemon not running; starting now at tcp:5037
DEBUG: dlsym works!
[2022-11-06T13:35:21Z DEBUG adbhooks] reading TERMUX_USB_FD
[2022-11-06T13:35:21Z DEBUG adbhooks] calling libusb_set_option
[2022-11-06T13:35:21Z DEBUG adbhooks] called opendir with /dev/bus/usb, remapping to virtual DirStream
[2022-11-06T13:35:21Z DEBUG adbhooks] called readdir with virtual DirStream
[2022-11-06T13:35:21Z DEBUG adbhooks] readdir returned dirent with d_name=001
[2022-11-06T13:35:21Z DEBUG adbhooks] opening device from 7
[2022-11-06T13:35:21Z DEBUG adbhooks] getting device from handle
[2022-11-06T13:35:21Z DEBUG adbhooks] requesting device descriptor
[2022-11-06T13:35:21Z DEBUG adbhooks] device descriptor: vid=6353, pid=20199, iSerial=3
[2022-11-06T13:35:21Z INFO  adbhooks] device serial path: /sys/bus/usb/devices/1-1/serial
Pointer tag for 0x7741e15000 was truncated, see 'https://source.android.com/devices/tech/debug/tagged-pointers'.
ADB server didn't ACK
Full server startup log: /data/data/com.termux/files/usr/tmp/adb.10245.log
Server had pid: 29169
[2022-11-06T13:35:21Z DEBUG adbhooks] called open with pathname=/data/data/com.termux/files/usr/tmp/adb.10245.log flags=0
[2022-11-06T13:35:21Z DEBUG adbhooks] open returned fd with value -1
* failed to start daemon
error: cannot connect to daemon
adb start-server exited with error status

Thanks. Was there a second log file or termux-adb.*.log only? I expect there should also be the log generated by adb itself. This is just what the launcher logged.
Anyway, I have a theory what could be wrong here but I'm unable to reproduce the issue on any of my devices.
If you'd be willing to test some custom builds for me, that would be really helpful. I'll prepare a change that I think could fix the problem.

Okay sir 🙂

Well, if the file  /data/data/com.termux/files/usr/tmp/adb.10245.log (or $TMPDIR/adb.10245.log) exists, it would help me if you shared it too. I think you only gave me termux-adb.10245.log.
I'll get back to you when I have an update. I can try a few things.

Adb log file is not exist

Ok then, no worries. I'll try to work with what I have.

I'd like to collect a little more information. Can you please download the new release (https://github.com/nohajc/termux-adb/releases/tag/v0.1.1), run RUST_LOG=debug ./termux-adb again and post the termux-adb log here?
It will fail but also log some pointer addresses which should help me diagnose the exact cause of the issue.

adb logs
--- adb starting (pid 29662) ---
adb I 11-07 07:30:10 29662 29662 main.cpp:63] Android Debug Bridge version 1.0.41
adb I 11-07 07:30:10 29662 29662 main.cpp:63] Version 31.0.3p1-android-tools
adb I 11-07 07:30:10 29662 29662 main.cpp:63] Installed as /data/data/com.termux/files/usr/bin/adb
adb I 11-07 07:30:10 29662 29662 main.cpp:63]
adb I 11-07 07:30:10 29662 29662 auth.cpp:417] adb_auth_init...
adb I 11-07 07:30:10 29662 29662 auth.cpp:152] loaded new key from '/data/data/com.termux/files/home/.android/adbkey' with fingerprint 5B17F393BDE89465D0EE415317447A34BA4B246B1F7CE5B7A0320DCB04FBF348
adb I 11-07 07:30:10 29662 29662 auth.cpp:392] adb_auth_inotify_init...

termux-adb logs
using /dev/bus/usb/001/003: fd = 7
cannot connect to daemon at tcp:5037: Connection refused
DEBUG: dlsym works!
[2022-11-07T02:10:07Z INFO  adbhooks] listening on socket fd 4
* daemon not running; starting now at tcp:5037
DEBUG: dlsym works!
[2022-11-07T02:10:07Z DEBUG adbhooks] reading TERMUX_USB_FD
[2022-11-07T02:10:07Z DEBUG adbhooks] calling libusb_set_option
[2022-11-07T02:10:07Z DEBUG adbhooks] called opendir with /dev/bus/usb, remapping to virtual DirStream
[2022-11-07T02:10:07Z DEBUG adbhooks] called readdir with dirp 0xb400007345e4c000
[2022-11-07T02:10:07Z DEBUG adbhooks] readdir: dirp is virtual DirStream
[2022-11-07T02:10:07Z DEBUG adbhooks] readdir returned dirent 0xb400007345e4c008 with d_name=001
[2022-11-07T02:10:07Z DEBUG adbhooks] called closedir with dirp 0xb400007345e4c000
[2022-11-07T02:10:07Z DEBUG adbhooks] closedir: dirp is virtual DirStream
[2022-11-07T02:10:07Z DEBUG adbhooks] opening device from 7
[2022-11-07T02:10:07Z DEBUG adbhooks] getting device from handle
[2022-11-07T02:10:07Z DEBUG adbhooks] requesting device descriptor
[2022-11-07T02:10:07Z DEBUG adbhooks] device descriptor: vid=6353, pid=20199, iSerial=3
[2022-11-07T02:10:07Z INFO  adbhooks] device serial path: /sys/bus/usb/devices/1-1/serial
Pointer tag for 0x7345e15000 was truncated, see 'https://source.android.com/devices/tech/debug/tagged-pointers'.
ADB server didn't ACK
Full server startup log: /data/data/com.termux/files/usr/tmp/adb.10245.log
Server had pid: 4516
[2022-11-07T02:10:07Z DEBUG adbhooks] called open with pathname=/data/data/com.termux/files/usr/tmp/adb.10245.log flags=0
[2022-11-07T02:10:07Z DEBUG adbhooks] open returned fd with value 5
* failed to start daemon
error: cannot connect to daemon
adb start-server exited with error status

Ok, I'm still not sure what exactly is happening. Can you try running RUST_LOG=debug ./termux-adb without any connected USB device, see if it starts and then connect the cable?
I'd like to know how the logs look like in that case.

But it can still see some USB device at the start. I need you to disconnect everything and just run RUST_LOG=debug ./termux-adb. Then share the log files again please.
You should see that it prints "no device connected yet" to standard output.
In case it starts, then you can try to connect the device.
There is some initialization code which only runs if there's already something connected. I'm trying to pinpoint if the problem is in the initialization or something else...

It works but take some times to show device open dialog

Logs files:
https://drive.google.com/file/d/1hbRbCgtim2QTYa-BKh6UfqqKK0uEqDIZ/view?usp=drivesdk

All right, this is interesting! Can you still share the logs from the working run?
This must be some weird timing issue if it doesn't manifest in this case.
Yeah, it can take a couple seconds for the dialogue to appear. This is expected because I don't get any event when a device is connected. I have to poll every couple of seconds and I don't want to waste resources by having the period too short.

I have one question! Can i ask?

Of course, ask anything.

I want to make an Android application that contains static adb binary how to execute using ProcessBuilder class with usb support on non-rooted device?

Sorry, but I don't know much about the Java/Android SDK part. I'm more of a linux person.
You'd probably need to check how termux-usb does its magic. I now it uses some Android API to get the file descriptors for USB devices (after opening to authorization dialogue). So your application would presumably do the same and then feed the descriptor into adb.
If you're bundling your own copy of adb, it might be simpler to just patch it. But the problem I see is the background execution. Android has some strict rules about that. Termux somehow emulates the unix way but I'm not sure how all that would work in your custom APK.
Either way, if you don't want to reimplement the adb protocol, adb binary needs to run in the background and receive USB file descriptors as devices connect and disconnect. I use unix domain sockets for that. Normally only child processes inherit open file descriptors but if you have a socket connection between two arbitrary processes, you can use it to transfer descriptors from one to the other.

If you don't want to reply to this then ignore it, sorry

It's all right, I was just slow.

If you don't want to reply to this then ignore it, sorry

It's all right, I was just slow.

Thanks

Sorry, but I don't know much about the Java/Android SDK part. I'm more of a linux person. You'd probably need to check how termux-usb does its magic. I now it uses some Android API to get the file descriptors for USB devices (after opening to authorization dialogue). So your application would presumably do the same and then feed the descriptor into adb.
If you're bundling your own copy of adb, it might be simpler to just patch it. But the problem I see is the background execution. Android has some strict rules about that. Termux somehow emulates the unix way but I'm not sure how all that would work in your custom APK.
Either way, if you don't want to reimplement the adb protocol, adb binary needs to run in the background and receive USB file descriptors as devices connect and disconnect. I use unix domain sockets for that. Normally only child processes inherit open file descriptors but if you have a socket connection between two arbitrary processes, you can use it to transfer descriptors from one to the other.

Okey sir, thanks

If you don't want to reply to this then ignore it, sorry

It's all right, I was just slow.

No problem

Can you try the latest release and let me know if it fixes the original issue?
First connect the device, then start termux-adb. I removed special handling when the device is available before adb server is started, so now it should behave the same as if you connected the device later. Hopefully.

Can you try the latest release and let me know if it fixes the original issue?
First connect the device, then start termux-adb. I removed special handling when the device is available before adb server is started, so now it should behave the same as if you connected the device later. Hopefully.

That's great! Thanks again for cooperation. If there isn't anything else, I'm closing the issue.

How did the Bugjeager application work, how did it get modified?

I don't know anything about that app... Does it do the same thing as adb in Termux?

I don't know anything about that app... Does it do the same thing as adb in Termux?

adb in termux doesn't connect to another Android device via USB OTG(until your project came, thankyou very much for that), But that app (Bugjaeger) can connect to another Android device via USB OTG and then can perform adb commands.
I also wonder why can't android-tools (package of termux) do what that app does? [Performing adb commands over USB OTG.]

I guess the difference is android-tools ships basically unmodified adb for linux (which only works on rooted devices) whereas Bugjaeger is a custom app re-implementing parts of the adb USB protocol specifically for Android.
Fastboot from android-tools is actually already patched to work with termux-usb but it's not obvious (or even documented AFAIK) how to use it. Adb would be more tricky to patch (though of course not impossible). I chose the dll injection approach exactly because it lets me use the unmodified adb binary.

Sir, can you write one for me 🙃; like this for  my app but without termux-usb

Sorry, but I don't know much about the Java/Android SDK part. I'm more of a linux person. You'd probably need to check how termux-usb does its magic. I now it uses some Android API to get the file descriptors for USB devices (after opening the authorization dialogue). So your application would presumably do the same and then feed the descriptor into adb.
If you're bundling your own copy of adb, it might be simpler to just patch it. But the problem I see is the background execution. Android has some strict rules about that. Termux somehow emulates the unix way but I'm not sure how all that would work in your custom APK.
Either way, if you don't want to reimplement the adb protocol, adb binary needs to run in the background and receive USB file descriptors as devices connect and disconnect. I use unix domain sockets for that. Normally only child processes inherit open file descriptors but if you have a socket connection between two arbitrary processes, you can use it to transfer descriptors from one to the other.

I thank you for your idea, I have patched adb and it works very well.


rebuild numpy with python 3.12 and emscripten 3.1.58 and pin pytest to >= 8

tests should run when #1268 is merged

@KGB99 I think we need to bump the build number of pytester


Bugfix/910 missing data

Moved to JOOQ call. Applied similar logic as what the cwms-data-access library did.
Updated description on the Timeseries.Record class to provide clarity.
Expanded existing test to include missing data of both supported types.

Thanks Mike. What are the ways to write null with this update? Looks like -340282346638528859811704183484516925440 will be one way. Is there a shorthand way like 'nan' or 'null' that would work too? If not maybe worth adding something in cwms-python so we don't have to remember that long number. I don't know of a good way to get to -Float.MAX_VALUE in python easily.

None in python is the equivalent to null and the python json library should correctly set it. If not, open an issue on the cwms-python library as it needs to be dealt with there now.

Tested behavior with new release. Missing value of -340282346638528859811704183484516925440  and missing quality code of 5 are still both required.

null or none did not work?

also was this directly or with cwms-js or cwms-python?

if cwms-python likely related to https://github.com/HydrologicEngineeringCenter/cwms-python/issues/105

also was this directly or with cwms-js or cwms-python?

cwms-python, let me test null or none.


Poly 1

Codecov Report
Attention: 60 lines in your changes are missing coverage. Please review.

Comparison is base (f677c8a) 31.79% compared to head (5ac6501) 50.54%.

Files
Patch %
Lines

dkg/Poly.cs
43.03%
41 Missing and 4 partials :warning:

dkg/Sec256k1Group.cs
28.57%
15 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##             main       #2       +/-   ##
===========================================
+ Coverage   31.79%   50.54%   +18.74%
===========================================
  Files           5        5
  Lines         651      645        -6
  Branches       75       66        -9
===========================================
+ Hits          207      326      +119
+ Misses        428      302      -126
- Partials       16       17        +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


unit test for ermrestjs error handling

Generate unit testing to test error handling in ermrestjs.

Are the changes on branch errortests? @chiragsanghvi

@shinyichen Yes they're on errortests branch.

I noticed a few of the methods didn't get tested, Entity.getBefore and Entity.getAfter. However, these will be replaced with the new API, so maybe this was intentional.
A couple of the test cases didn't make sense: schemas.get (02.schema_error.js) and tables.get (03.table_error.js). These are not ermrest calls, they only access what's already in the schema. These tests should be similar to what you are doing with annotations.get and expect NotFoundError.
https://github.com/informatics-isi-edu/ermrestjs/blob/errortests/test/specs/errors/tests/02.schema_error.js#L19-L23
https://github.com/informatics-isi-edu/ermrestjs/blob/errortests/test/specs/errors/tests/03.table_error.js#L19-L23
A few missing tests for non-ermrest calls with NotFoundError: columns.get, keys.get, mappings.get, foreignkeys.get.
Finally, does this issue cover retries for 500 and 503 errors, and special case of entity.delete with 404 error?

@shinyichen There is an HTTP retry test case for 500 error in the sample folder, which I had written initially to document use of the mocking framework nock. You can see it here. I need to push the changes that handle 503 and entity.delete with 404 error scenarios in an another branch. I will move the test to error folder and push the changes.
Apart from that the column.get and mapping.get were almost similar to annotations.get so I didn't write them.
keys.get and foreignkeys.get are not testable as I can't access the colset class directly.

@shinyichen I have added the http_retry testcase to errortests branch.

Fixed in PR #132


[0.5pt] Find external API - group task

Find an API to base the development of the webapp around it. The API should allow you to

Get a list of items with a unique item id (or generate the unique id).
For a given item, get detailed information about it.
choose an APIs that doesn't need authentication. if you select an API that requires authentication, you should implement it on your own. Also, if you select an API that provides image resources your webapp will be more visual.

TVmaze API: data about TV series and movies.)


Deleting the last desktop link recreates default links

Deleting the last desktop link recreates all default desktop links, as Costa apparently recognizes this as a corruption of the desktop link file.

Resolved in 2d801cb.
New behaviour:
If the desklnkX.dat file exists but contains no icons, or if the user manually deletes the last desktop link, Costa will ask if the user wants to recreate default links. If not, Costa will remember this choice and not ask again, allowing the user to have an empty desktop.
If the dsklnkX.dat file is not found, the default links will be recreated without prompt, but the user will be informed of this action.


Add scss to anduin-build

Add scss to anduin-build

@ngbinh @cmpham for fixing issue https://github.com/anduintransaction/stargazer/issues/4882 in stargazer


Create framework for extracting, verifying and updating model reproducibility and performance

As a model component developer I want a tool verify model reproducibility. As a model developer I want the same tool to work for all the components of the model.
As a release team member I want to be able to use the same tool when developing CI tests for a number of different models.
As a user of models I want to be confident that model updates will not change the answers of my experiments, unless this has been specifically documented.

@aidanheerdegen Has ACCESS-NRI decided on how to use rose stem tests to test executable reproducibility? Would this be part of an approach to test model reproducibility?

@aidanheerdegen Has ACCESS-NRI decided on how to use rose stem tests to test executable reproducibility? Would this be part of an approach to test model reproducibility?

No decision has been made. I need to read some documentation about rose stem testing, but if you had an example suite for testing on NCI that I could look at it that would be helpful.

@MartinDix uses rose stem to test each each UM release. I believe that this rose stem test is just a subset of the tests in https://code.metoffice.gov.uk/trac/um/browser/main/trunk/rose-stem

The standard UM rose stem tests aren't a good match for our configurations, e.g. nothing with CABLE and nothing anywhere near as old as ESM1.5. They're convenient for testing the effect of code updates across a range of configurations but if we're interested in changes to released configurations we could use something more targeted.

The standard UM rose stem tests aren't a good match for our configurations, e.g. nothing with CABLE and nothing anywhere near as old as ESM1.5. They're convenient for testing the effect of code updates across a range of configurations but if we're interested in changes to released configurations we could use something more targeted.

That said, if we intend to contribute code changes upstream, we would probably also need corresponding rose stem tests.


Retry wrapped around hystrix call?

Hi.
Does it really make sense, that the http retry mechanism is outside the CB call?
For me this seems very unintuitive:
When the CB is open, there will still be retries and also time.Sleep() backoffs. Isn't the intent of an opened CB also for the calling system to get a fast feedback and don't waste time?
Even on a completely new request there is no check if the cb is currently open. Why would one do retries and spend time waiting on an open CB?
For me it would make more sense to do the retries inside the cb. So you define the following behavior:

remote systems may fail, but the CB should only count a failure after the retries did not help
if the remote system fails and the cb is open, do not even try to send requests, but immediately return an error

Or maybe I do get the idea wrong.
Please help clarify.

@ybbus This library was built with the above-mentioned decision. Let me research on this topic more. If you have some examples of some other resilience libraries doing it otherwise can you help point me to those?

Based on the MSFT docs on the circuit breaker pattern, it still makes sense to combine retries with CB as long as errors are transient.

The purpose of the Circuit Breaker pattern is different than the Retry pattern. The Retry pattern enables an application to retry an operation in the expectation that it'll succeed. The Circuit Breaker pattern prevents an application from performing an operation that is likely to fail. An application can combine these two patterns by using the Retry pattern to invoke an operation through a circuit breaker. However, the retry logic should be sensitive to any exceptions returned by the circuit breaker and abandon retry attempts if the circuit breaker indicates that a fault is not transient.

https://docs.microsoft.com/en-us/azure/architecture/patterns/circuit-breaker


"Go to definition" does not work with macros

Environment

Elixir & Erlang versions (elixir --version):
Erlang/OTP 25 [erts-13.0.3] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] [jit]
Elixir 1.14.1 (compiled with Erlang/OTP 25)

Elixir Language Server version: elixir-ls-14

Operating system: OSX

Editor or IDE name (e.g. Emacs/VSCode): emacs

Editor Plugin/LSP Client name and version: LSP

Current behavior
lsp-find-definition does not work on macros
Expected behavior
lsp-find-definition should work on macros

Please post a project that reproduces it

https://github.com/robsonpeixoto/elixir-ls-go-to-definition-bug
Open the file https://github.com/robsonpeixoto/elixir-ls-go-to-definition-bug/blob/main/lib/bug.ex and try to go-to-defition of ModA.say_hi function.

I cannot reproduce it when building elixir-ls locally

```
[Info  - 2:33:44 PM] Started ElixirLS v0.12.0
[Info  - 2:33:44 PM] ElixirLS built with elixir "1.14.2" on OTP "25"
[Info  - 2:33:44 PM] Running on elixir "1.14.2 (compiled with Erlang/OTP 25)" on OTP "25"
```
but I can when I run it in installed plugin
[Info  - 2:36:55 PM] Started ElixirLS v0.12.0
[Info  - 2:36:55 PM] ElixirLS built with elixir "1.11.4" on OTP "22"
[Info  - 2:36:55 PM] Running on elixir "1.14.2 (compiled with Erlang/OTP 25)" on OTP "25"

It's a duplicate of https://github.com/elixir-lsp/elixir-ls/issues/193

@lukaszsamson the linked issue mentions that the problem comes from building elixir-ls with an elixir version different from system version. But I have the elixir-ls-1.14-25.1 and Elixir 1.14.1, are these not the same version?
I downloaded directly from the Relase page here in github, not the VSCode marketplace or whatever.
oh but when I look into the version of the LSP: ElixirLS compiled with Elixir 1.11.4
so why is elixir-ls-1.14-25.1 compiled with Elixir 1.11.4?

So apparently there was a lingering ElixirLS version that was taking precedence over the latest one. I ended up building from source. Came across this issue, and this solved it: https://github.com/elixir-lsp/elixir-ls/issues/783#issuecomment-1338926724
Can confirm I can follow macros now.


Android camera stays black after permission is given

Describe the bug
A clear and concise description of what the bug is.
When on android, the camera component is rendered for the first time and asks for permission, and the user gives permission.
Seems like the camera component is not updated and stays black, until the page is reloaded.
The same thing works on ios as expected. After the user gives permission, the camera is activated.
*To Reproduce
            <CameraScreen
                cameraType={CameraType.Back}
                focusMode="on"
                actions={{ leftButtonText: 'Cancel' }}
                onBottomButtonPressed={() => navigation.goBack()}
                scanBarcode={true}
                onReadCode={(event) => onBarcodeScan(event.nativeEvent.codeStringValue)}
                showFrame={true}
                laserColor="transparent"
            />

Expected behavior
When the user gives permission. The camera should turn on by itself, not needing a page/screen reload.

OS: Andorid

I have the same issue

Having the same issue.

The only workaround I came up with is checking if the user gave permission a few seconds after mounting the camera component 😞 .
Then reloading the component.
It is not very good but it is the only thing that is working.

by asking the camera permissions before opening the camera resolved my issue.


bug(menu): menu doesn't work in full screen mode

If I put md-toolbar with md-menu on a div element and go into full screen mode using
var elem = document.getElementById("my-div-id");
if (elem.requestFullscreen) {
  elem.requestFullscreen();
}
else if (elem.webkitRequestFullScreen) {
  elem.webkitRequestFullScreen();
}

then md-menu doesn't show at all
plunker: http://plnkr.co/edit/NCYYbZklZIdYra0xYsfF?p=preview
PS: you should launch it in separate window in order to process fullscreen requests
Environment: Angular 2.0.1 with Material alpha-9-3 using ng-cli
Browsers: latest Chrome & Firefox

Also the same problems appears with dialog, tooltip - all overlay-based components. It looks like overlay service should be tweaked to support full-screen mode (i.e. temporarily use another ElementRef to inject overlays)

Should be closed via #1949, right?

Yep

Can this be re-opened? I am still able to reproduce this issue: https://codepen.io/anon/pen/zRXqwm

@nancy-ly This is a library for Angular 2 and later, not for Angular 1.x

@jelbourn this should be reopened
https://angular-material2-issue-siqbmy.stackblitz.io

you should provide full screen overlay:
{ provide: OverlayContainer, useClass: FullscreenOverlayContainer },
import {
  OverlayContainer,
  FullscreenOverlayContainer
} from '@angular/cdk/overlay';


DOC: update pip_qiuckstart (submodules)

Reference issue

https://github.com/scipy/scipy.org/issues/436
What does this implement/fix?

Update the pip quickstart instructions: we now need to init/update submodules.
Additional information

Verified on a clean virtualenv install locally.

CI error is a usual timeout.


BulkLoaderVertexProgram for generalized batch loading across graphs

BulkLoaderVertexProgram now supports

several inputs (HadoopGraph with all its supported InputFormats and any TinkerPop3 enabled graph, like TinkerGraph or Neo4j)
any TinkerPop3 enabled graph, even if it only supports single threaded access

Samples are provided in the docs. Tests were added to ensure proper functionality of BulkLoaderVertexPrograms configuration options.

Why are these needed in TinkerGraph's pom.xml?
+        <dependency>
+            <groupId>org.neo4j</groupId>
+            <artifactId>neo4j-tinkerpop-api</artifactId>
+            <version>0.1</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.neo4j</groupId>
+            <artifactId>neo4j-tinkerpop-api-impl</artifactId>
+            <version>0.1-2.2</version>
+            <scope>test</scope>
+        </dependency>

Good catch! I actually had a TODO item to remove those dependencies, but ... wanted to see if RTC works out :).

I VOTE +1 -- assuming @dkuppitz has the docs building fully and integration tests passing.

FYI: Yes, integration tests pass and docs are looking good.

After learning that I can vote on my own PR and doing a lot more tests than anybody else is likely going to do...
Vote: +1

Am I missing something obvious here?

Probably. The test uses TinkerGraph.

Oh - so in the case i was specifying, it reads from Neo4j and writes to TinkerGraph.  Now I get it - it was something obvious.
Looking at the asserts in the test - they largely just assert counts.  Is it possible to use:
https://github.com/apache/incubator-tinkerpop/blob/master/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/structure/io/IoTest.java#L643
to assert the entire Modern graph rather than just the counts. Note that there's some options there to ignore the ids and stuff.  If you could do that, then that should validate the work you have in IncrementalBulkLoader which I don't think has tests at all.
I also think adding a test of "The Crew" is worthwhile to assure the meta/multi property stuff is solid.

Nice idea. The problem is, that assertToyGraph also checks edge ids, which will never be preserved by BLVP. I can add some more "manual" assertions though and especially a test case for the Crew graph.

i'm open to you editing that "assert" to allow for your case where ids are ignored.  As long a the existing test cases still assert the ids, i'm cool with whatever you have to change there.  That assert function is as complete as you can get and would be fairly bullet proof for what you're doing.  If you don't want to touch it, that's fine, but might be less work that new "reasonable" manual assertions.

 I added a test case for the Crew graph, only to realize that multi-valued properties aren't handled properly by BLVP. I thought it's easy to fix, but it's not.
The default implementation of IncrementalBulkLoader doesn't know anything about a schema. Now, if it's about to write a property, how should it know, whether it should overwrite an existing value or simply append the new value? I don't think there's a general solution and multi-valued properties need to be handled domain specific.
IncrementalBulkLoader should always assume single-valued properties.
Thoughts?

Here's the pattern used in Attachable:
https://github.com/apache/incubator-tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/Attachable.java#L333-L335
basically, you can query the graph for the cardinality of the property:
graph.features().vertex().getCardinality(k)

I have no idea what that check will do to the speed of your load, but perhaps we worry about optimizing later (unless you see an easy way to avoid lots of repeated checks to this method that we get stuck with in Attachable).

Eek.  Well, each VertexProperty has a unique id. Thus, can't you treat it like an edge? You can have multiple edges with the same label between two vertices.... How do you solve that?

IncrementalBulkLoader supports only one edge with the same label between 2 particular vertices. It's actually the same problem - if the behavior is not sufficient, you'll need to provide a domain specific BulkLoader implementation.
I can add that to the docs, but we need a default behavior for multi-valued properties. I still tend to support only single-valued properties.
Regarding @spmallette's suggestion: As you can see in TheCrew, cardinalitites can be mixed; name is single-valued, location is multi-valued.

@dkuppitz -- I think the default behavior should be multi-property. If the original dataset has two of the same property, well, add the second... Or am I missing something?

Imagine a partially loaded TheCrew graph where some of the locations are missing and some names are wrong. We know that names should be replaced as they are single valued (or maybe we decided to add middle names, who knows), but locations should be appended (if they don't exist yet; note that this is the distinction between list and set).
IncrementalBulkLoader can only replace OR append, it can't make a decision based on the property name (or anything else). Incremental loading over TheCrew graph requires domain specific knowledge.

Huh. Is it possible for someone to do a builder to provide "schema" ? Not that this should be in bulk loader vertex program, but in like Schema object. dah -- @pietermartin ...

Well, we talked about a rule based BL, that would solve the problem. However, that's something to consider for 3.1.0, not 3.0.2.

Okay. Well perhaps we have the "easy version" now. And hopefully if we do something like Schema in the future, we can do something like:
blvp.writeGraph(conf).schema(Schema.build().....create())

If you don't provide a schema, then the default behavior is what you (@dkuppitz) think is reasonable.

i'm ok with this working as-is (replace OR append) for 3.0.2 with the idea that it will be improved for 3.1.0.  I'm just glad to know the limitation before we hung it out there in release so it can be documented clearly.  So based on that are there any other commits to look at?  are you amending the test changes based on what we talked about earlier?

@dkuppitz --- two things to be aware of (though you might already, just to be clear).

Vertex properties and edges have unique ids.
Graph.features().getCardinality()

VOTE: +1 - that's 3 +1s - ready to merge.


make pip installation work with Python 3.11+ (Ubuntu 23.04)

Ubuntu 23.04 ships with Python 3.11. Since that version it is not possible to just run python3 -m pip install because of PEP 668 – Marking Python base environments as "externally managed" (https://peps.python.org/pep-0668/)
There are at least two solutions:

Use --break-system-packages which is the easiest fix, but might also result in breaking the user's system (hence the name ^^)
Create a virtual environment. This would be cleaner, but requires to activate the environment every time one wants to use AFLGo's Python scripts (not so convenient)

In the README.md there is already this sentence:

Be careful in these steps we would download, build and install LLVM 11.0.0 from source, which may have unexpected impacts on compiler toolchain in current system.

So we could use 1. as suggested in the patch and just add another note about the pip installation. One could also assume that users setup Docker containers for their fuzzing campaigns where it would not matter to "break the system".
In the case of 2. I could introduce a virtual environment which would also work across all Python/Ubuntu versions and would be cleaner. The documentation and example scripts would have to be updated as well.
Another alternative would be to just add a comment about Python 3.11+ versions and leave everything else as it is :)

No matter which solution is adopted, I believe it would be better to remind users of this trouble in Readme.md.


feat(rax): add bytedance-microapp support (#390)

https://github.com/ice-lab/icepkg/pull/390

Codecov Report
Base: 78.81% // Head: 78.81% // No change to project coverage :thumbsup:

Coverage data is based on head (0587a14) compared to base (67e5ed1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           stable/0.x     #391   +/-   ##
===========================================
  Coverage       78.81%   78.81%
===========================================
  Files              20       20
  Lines             812      812
  Branches          164      164
===========================================
  Hits              640      640
  Misses            172      172

Impacted Files
Coverage Δ

packages/ice-npm-utils/src/index.ts
87.85% <100.00%> (ø)

packages/iceworks-cli/src/utils/extractTarball.ts
80.85% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Start devlxd on VMs as early as possible

This adds a file to the config drive as a hint for the lxd-agent to start the devlxd server early.
This way, any systemd services starting after the lxd-agent will be able to access /dev/lxd/sock.

Testsuite passed

@stgraber says that we do unmount the config drive, so we need to check if its remounted and config is copied when lxd-agent is restarted. So we need to check that @monstermunchkin


/usr/bin/ld: cannot find -lQt5::Widgets

On a Debian unstable system, I run into the following problem when compiling cartographer_ros:
[100%] Linking CXX executable ../devel/lib/cartographer_ros/cartographer_node
/usr/bin/ld: cannot find -lQt5::Widgets
collect2: error: ld returned 1 exit status
cartographer_ros/CMakeFiles/cartographer_node.dir/build.make:353: recipe for target 'devel/lib/cartographer_ros/cartographer_node' failed
make[2]: *** [devel/lib/cartographer_ros/cartographer_node] Error 1
CMakeFiles/Makefile2:2202: recipe for target 'cartographer_ros/CMakeFiles/cartographer_node.dir/all' failed
make[1]: *** [cartographer_ros/CMakeFiles/cartographer_node.dir/all] Error 2
Makefile:138: recipe for target 'all' failed
make: *** [all] Error 2

The linking against Qt5::Widgets seems to come from the vtk library as is evident from looking through my CMakeFiles directory and into the vtk cmake files installed on my system. A shared library namey Qt5::Widgets does probably not exist - instead, this is the qt cmake way of linking against the Qt5 widgets library. Indeed the problem seems to be known:
http://www.vtk.org/pipermail/vtk-developers/2014-May/030456.html
As proposed, after adding find_package(Qt5Widgets REQUIRED) to the CMakeLists.txt of cartographer_ros, the linking process finishes successfully.
It is not obvious where the bug here is, whether it's a bug in cartographer_ros, which should add a find_package(Qt5Widgets REQUIRED) or whether vtk should do that instead. The fact is, that currently, because of this problem, cartographer_ros does not link successfully on Debian unstable.
There also seem to be a fix for this problem in vtk:
http://review.source.kitware.com/15372

@josch Could you try out https://github.com/SirVer/cartographer_ros/tree/find_qt_widgets and report if that fixes the issue?

And if it does not, could you try with and without the line and also with removing set(QT_LIBRARIES Qt5::Widgets) around the same area changed in https://github.com/SirVer/cartographer_ros/commit/470b06774bb5211f03c7d3dcd93efbcffca18e38

@SirVer Thank you, your commit fixes this problem.

thanks for checking.


chore(package.json): pin down lint-staged pkg version

Description:
This is simple pkg pin down, I found latest ^ bump up (above 3.2.7) has regressions to deal with windows paths.
Related issue (if exists):

Coverage remained the same at 97.687% when pulling 74c350a86d106368268f72f794e2c40e6ccb4ba5 on kwonoj:chore-pkg into 6c8811c0558021a7e96c5d55f0c7ebb5a224cfb8 on ReactiveX:master.


Add indoor_keith

feat: include indoor_keith account info to developers.json

Thanks for this. Don't be alarmed if you get a notification about something failing - the CI/CD is having trouble with PRs coming from forks and I need to find time to fix it. Your profile will still appear on the site within a few minutes of the merge


Semantics: rename Opts to InitialState

This should make the use of init/2 easier for everyone. Also doesn't have to be the actual state BUT if the user uses maps then it's a pretty good name.

We should also make InitialState optional, defaulting to either undefined or #{}, probably the latter. Most handlers don't actually need an initial state.

Believe that's done.

Should handler_opts also be renamed to handler_state? Just curious.

Probably. It's a little late for that though so let's deprecate it later and remove handler_opts in 3.0.


Enable frozen natural orbital CC

Codecov Report

Merging #549 into master will decrease coverage by 0.01%.
The diff coverage is 8%.

@@            Coverage Diff             @@
##           master     #549      +/-   ##
==========================================
- Coverage   82.29%   82.28%   -0.02%
==========================================
  Files         574      574
  Lines      109938   110003      +65
==========================================
+ Hits        90473    90511      +38
- Misses      19465    19492      +27

Impacted Files
Coverage Δ

pyscf/mp/ump2.py
84.92% <8%> (-3.86%)
:arrow_down:

pyscf/data/elements.py
90.9% <0%> (-4.55%)
:arrow_down:

pyscf/pbc/cc/eom_kccsd_ghf.py
93.85% <0%> (-0.08%)
:arrow_down:

pyscf/scf/test/test_rhf.py
99.66% <0%> (ø)
:arrow_up:

pyscf/gto/test/test_mole.py
96.45% <0%> (+0.04%)
:arrow_up:

pyscf/gto/mole.py
94% <0%> (+0.1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e426b2...9632db9. Read the comment docs.